Timeline



Jul 29, 2008:

11:14 PM Changeset in webkit [35443] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-07-29 Kevin Calhoun <​kcalhoun@apple.com>

Reviewed by Adele.

Fix for <rdar://problem/6060647> Adopt QTMovieOpenForPlaybackAttribute flag

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie):
11:05 PM Changeset in webkit [35442] by ap@webkit.org
  • 15 edits in trunk

Reviewed by Geoff Garen.

Implement JSContextGroup APIs to make concurrent execution possible for
JavaScriptCore clients.

This changes the behavior of JSGlobalContextCreate(), so that it now uses a private context
group for each context, making JSlock implicit locking unnecessary.

  • API/JSContextRef.h:
  • API/JSContextRef.cpp: (JSContextGroupCreate): (JSContextGroupRetain): (JSContextGroupRelease): (JSGlobalContextCreate): (JSGlobalContextCreateInGroup): (JSGlobalContextRelease): (JSContextGetGroup): Added new methods. JSGlobalContextCreate() calls JSGlobalContextCreateInGroup() now.
  • API/APICast.h: (toJS): (toRef): Added converters for JSContextGroupRef.
  • API/JSBase.cpp: (JSGarbageCollect): JSGarbageCollect(0) is now a no-op, and the passed in context is actually used.
  • API/JSBase.h: Aded a typedef for JSContextGroupRef. Updated documentation for JSGarbageCollect().
  • kjs/JSGlobalData.cpp:
  • kjs/JSGlobalData.h: Removed support for JSGlobalData shared instance. JSGlobalData::isSharedInstance member variable still remains, to be deleted in a followup patch.
  • kjs/JSLock.cpp: (KJS::JSLock::JSLock): Disabled JSLock, to be deleted in a follow-up patch.


  • kjs/collector.cpp: (KJS::Heap::markOtherThreadConservatively): Removed an assertion that referenced JSGlobalData::sharedInstance.
  • kjs/collector.h: Made Heap destructor public, so that JSContextRelease can use it.

JavaScriptGlue:

  • JSRun.cpp: (JSRun::JSRun):
  • JSUtils.cpp: (getThreadGlobalExecState): Changed JavaScriptGlue to use a JSGlobalData of its own, now that there is no shared instance.
11:02 PM Changeset in webkit [35441] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-07-29 Kevin Calhoun <​kcalhoun@apple.com>

Reviewed by Adele.

Fix for <rdar://problem/6031021> Make standalone video render more like the quicktime plugin to improve performance

For standalone video, use QTMovieView to draw.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieView): Moved nil checks to setUpVideoRendering. Associate the QTMovieView with the WebCoreMovieObserver. If we're in a media document, allow QTMovieView to render in its default mode; otherwise tell it to draw synchronously. (WebCore::MediaPlayerPrivate::detachQTMovieView): Set the WebCoreMovieObserver's view to nil. (WebCore::MediaPlayerPrivate::createQTVideoRenderer): Nil check is now in setUpVideoRendering, which is the only caller of this. (WebCore::MediaPlayerPrivate::setUpVideoRendering): Added nil checks. Call createQTMovieView for media documents. (WebCore::MediaPlayerPrivate::tearDownVideoRendering): Call detachQTMovieView if a QTMovieView exists. (WebCore::MediaPlayerPrivate::setRect): Call setFrame on the QTMovieView if necessary. (-[WebCoreMovieObserver menuForEventDelegate:]): Added. Returns the frame view's menu. (-[WebCoreMovieObserver setView:]): Added.
10:55 PM Changeset in webkit [35440] by ap@webkit.org
  • 3 edits in trunk/JavaScriptCore

Reviewed by Geoff Garen.

Fix a leak of ThreadRegistrar objects.

As the heap is usually deleted when registered threads still exist, ThreadSpecific doesn't
have a chance to clean up per-thread object. Switched to native pthread calls, storing a
plain pointer that doesn't require cleanup.

  • kjs/collector.cpp: (KJS::PlatformThread::PlatformThread): (KJS::Heap::Thread::Thread): (KJS::Heap::Heap): (KJS::Heap::~Heap): (KJS::Heap::registerThread): (KJS::Heap::unregisterThread):
  • kjs/collector.h:
10:52 PM Changeset in webkit [35439] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=20169
Memory allocated with fastMalloc is freed with delete

  • VM/JSPropertyNameIterator.cpp: (KJS::JSPropertyNameIterator::invalidate): Free the array properly. (KJS::JSPropertyNameIterator::~JSPropertyNameIterator): Delete the array by calling invalidate().
10:42 PM Changeset in webkit [35438] by adele@apple.com
  • 7 edits in trunk/WebCore

2008-07-29 Adele Peterson <​adele@apple.com>

Reviewed by Dan Bernstein.

Fix for <rdar://problem/6073372> Move built-in controls below <video> element for standalone media documents

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Added -webkit-full-page-media pseudo class.
  • css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoFullPageMedia.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added case to apply PseudoFullPageMedia for elements in a full page media document.
  • css/html4.css: Added rule to shift control panel down for video in standalone media documents.
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::lowestPosition): Added implementation that takes the controls into account. This makes sure that scrollbars on the page will account for controls not directly contained in the RenderMedia. (WebCore::RenderMedia::rightmostPosition): ditto. (WebCore::RenderMedia::leftmostPosition): ditto.
  • rendering/RenderMedia.h:
10:34 PM Changeset in webkit [35437] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

Reviewed by Sam Weinig.

Add tooltip support to the wx port.

​https://bugs.webkit.org/show_bug.cgi?id=20173

10:00 PM Changeset in webkit [35436] by alice.liu@apple.com
  • 4 edits in trunk/WebKit/win

2008-07-29 Alice Liu <​alice.liu@apple.com>

Reviewed by Geoff Garen.

Fix WebDocumentLoader leak on Windows.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createDocumentLoader):
  • WebDocumentLoader.cpp: (WebDocumentLoader::create):
  • WebDocumentLoader.h:
7:39 PM Changeset in webkit [35435] by weinig@apple.com
  • 29 edits
    12 adds in trunk

WebCore:

2008-07-29 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

<rdar://problem/6084585> Investigate upload progress events.

  • Add progress notifications for data being sent via a ResourceHandle.
  • Add XMLHttpRequestUpload support.

Upload notifications only work on the Mac right now as the CFNetwork API
on windows does not expose enough information.

Tests: http/tests/xmlhttprequest/upload-onload-event.html

http/tests/xmlhttprequest/upload-onloadstart-event.html
http/tests/xmlhttprequest/upload-onprogress-event.html
http/tests/xmlhttprequest/upload-progress-events.html

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSEventTargetBase.cpp: (WebCore::toJS):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::mark):
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: Added. (WebCore::JSXMLHttpRequestUpload::mark): (WebCore::JSXMLHttpRequestUpload::onabort): (WebCore::JSXMLHttpRequestUpload::setOnabort): (WebCore::JSXMLHttpRequestUpload::onerror): (WebCore::JSXMLHttpRequestUpload::setOnerror): (WebCore::JSXMLHttpRequestUpload::onload): (WebCore::JSXMLHttpRequestUpload::setOnload): (WebCore::JSXMLHttpRequestUpload::onloadstart): (WebCore::JSXMLHttpRequestUpload::setOnloadstart): (WebCore::JSXMLHttpRequestUpload::onprogress): (WebCore::JSXMLHttpRequestUpload::setOnprogress): (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener): (WebCore::JSXMLHttpRequestUpload::dispatchEvent):
  • dom/EventTarget.cpp: (WebCore::EventTarget::toXMLHttpRequestUpload):
  • dom/EventTarget.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didSendData):
  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didSendData):
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didSendData):
  • page/DOMWindow.idl:
  • platform/network/FormData.cpp: (WebCore::FormData::FormData):
  • platform/network/FormData.h: (WebCore::FormData::alwaysStream): (WebCore::FormData::setAlwaysStream):
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didSendData):
  • platform/network/mac/FormDataStreamMac.h:
  • platform/network/mac/FormDataStreamMac.mm: (WebCore::getStreamFormDataMap): (WebCore::getStreamResourceHandleMap): (WebCore::associateStreamWithResourceHandle): (WebCore::disassociateStreamWithResourceHandle): (WebCore::DidSendDataCallbackData::DidSendDataCallbackData): (WebCore::performDidSendDataCallback): (WebCore::formCreate): (WebCore::formFinalize): (WebCore::formRead): (WebCore::setHTTPBody): (WebCore::httpBodyFromStream):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::~XMLHttpRequest): (WebCore::XMLHttpRequest::upload): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::createRequest): (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::networkError): (WebCore::XMLHttpRequest::abortError): (WebCore::XMLHttpRequest::didSendData):
  • xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::optionalUpload):
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestUpload.cpp: Added. (WebCore::XMLHttpRequestUpload::XMLHttpRequestUpload): (WebCore::XMLHttpRequestUpload::addEventListener): (WebCore::XMLHttpRequestUpload::removeEventListener): (WebCore::XMLHttpRequestUpload::dispatchEvent): (WebCore::XMLHttpRequestUpload::dispatchXMLHttpRequestProgressEvent): (WebCore::XMLHttpRequestUpload::dispatchAbortEvent): (WebCore::XMLHttpRequestUpload::dispatchErrorEvent): (WebCore::XMLHttpRequestUpload::dispatchLoadEvent): (WebCore::XMLHttpRequestUpload::dispatchLoadStartEvent): (WebCore::XMLHttpRequestUpload::dispatchProgressEvent):
  • xml/XMLHttpRequestUpload.h: Added. (WebCore::XMLHttpRequestUpload::create): (WebCore::XMLHttpRequestUpload::toXMLHttpRequestUpload): (WebCore::XMLHttpRequestUpload::associatedXMLHttpRequest): (WebCore::XMLHttpRequestUpload::disconnectXMLHttpRequest): (WebCore::XMLHttpRequestUpload::setOnAbortListener): (WebCore::XMLHttpRequestUpload::onAbortListener): (WebCore::XMLHttpRequestUpload::setOnErrorListener): (WebCore::XMLHttpRequestUpload::onErrorListener): (WebCore::XMLHttpRequestUpload::setOnLoadListener): (WebCore::XMLHttpRequestUpload::onLoadListener): (WebCore::XMLHttpRequestUpload::setOnLoadStartListener): (WebCore::XMLHttpRequestUpload::onLoadStartListener): (WebCore::XMLHttpRequestUpload::setOnProgressListener): (WebCore::XMLHttpRequestUpload::onProgressListener): (WebCore::XMLHttpRequestUpload::eventListeners): (WebCore::XMLHttpRequestUpload::refEventTarget): (WebCore::XMLHttpRequestUpload::derefEventTarget):
  • xml/XMLHttpRequestUpload.idl: Added.

LayoutTests:

2008-07-29 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

<rdar://problem/6084585> Investigate upload progress events

  • fast/dom/Window/window-properties-expected.txt:
  • http/tests/xmlhttprequest/upload-onload-event-expected.txt: Added.
  • http/tests/xmlhttprequest/upload-onload-event.html: Added.
  • http/tests/xmlhttprequest/upload-onloadstart-event-expected.txt: Added.
  • http/tests/xmlhttprequest/upload-onloadstart-event.html: Added.
  • http/tests/xmlhttprequest/upload-onprogress-event-expected.txt: Added.
  • http/tests/xmlhttprequest/upload-onprogress-event.html: Added.
  • http/tests/xmlhttprequest/upload-progress-events-expected.txt: Added.
  • http/tests/xmlhttprequest/upload-progress-events.html: Added.
  • platform/win/Skipped: Skip new tests on windows where the feature is not implemented yet.
4:33 PM Changeset in webkit [35434] by britto@apple.com
  • 2 edits in trunk/WebCore

2008-07-29 Maxime Britto <​britto@apple.com>

Reviewed by Darin.

<rdar://problem/6095023> "When pan-scrolling, mouse click on hyperlink stop the pan-Scroll but follow the link after that."
With this patch we now stop the pan scroll and swallow the event to prevent any following action.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): If we were in pan scrolling mode we no longer just stop the pan scroll and continue with the function, we now stop and return true to attest that we swallowed the event.
3:59 PM Changeset in webkit [35433] by britto@apple.com
  • 3 edits
    2 adds in trunk

2008-07-29 Maxime Britto <​britto@apple.com>

Reviewed by adele.

Test: fast/events/autoscroll-in-textfield.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled): reverted a bad change introduced in r35244 nb:the test case introduced in r35244 is still working.

2008-07-29 Maxime Britto <​britto@apple.com>

Reviewed by adele.
This test verifies that the autoscroll works within textfields.

  • fast/events/autoscroll-in-textfield-expected.txt: Added.
  • fast/events/autoscroll-in-textfield.html: Added.
3:47 PM Changeset in webkit [35432] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Attempt to fix the Qt build.

  • wtf/ThreadingQt.cpp: Add the extra argument to createThread.
3:38 PM Changeset in webkit [35431] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Mark Rowe.

  • update results for console.group and console.groupEnd
  • fast/dom/Window/window-properties-expected.txt:
1:58 PM Changeset in webkit [35430] by mrowe@apple.com
  • 3 edits in trunk/WebKit/mac

Tweak to the build fix to keep Dan happy.

1:28 PM Changeset in webkit [35429] by adele@apple.com
  • 6 edits
    2 adds in trunk

WebCore:

2008-07-29 Adele Peterson <​adele@apple.com>

Reviewed by Sammy Weinig.

Fix for <rdar://problem/6103024>
When a QT movie is loaded directly in the browser, I can't pause it by single-clicking on the video

Test: media/video-click-dlbclick-standalone.html

  • loader/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler): For standalone media documents, match the default Quicktime plugin behavior to allow clicking and double-clicking to pause and play the media.
  • loader/MediaDocument.h: Added defaultEventHandler.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::defaultEventHandler): Return early if the event has been handled.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlMuteButtonElement::defaultEventHandler): Correct what was probably a typo. Instead of "event->defaultHandled()", it is supposed to be "event->setDefaultHandled()". (WebCore::MediaControlPlayButtonElement::defaultEventHandler): ditto. (WebCore::MediaControlSeekButtonElement::defaultEventHandler): ditto. (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): ditto.

LayoutTests:

2008-07-29 Adele Peterson <​adele@apple.com>

Reviewed by Sammy Weinig.

Test for <rdar://problem/6103024>
When a QT movie is loaded directly in the browser, I can't pause it by single-clicking on the video

  • media/video-click-dlbclick-standalone-expected.txt: Added.
  • media/video-click-dlbclick-standalone.html: Added.
1:13 PM Changeset in webkit [35428] by mrowe@apple.com
  • 3 edits in trunk/WebKit/mac

Build fix.

11:55 AM Changeset in webkit [35427] by mitz@apple.com
  • 7 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6059648> Some content not visible when the window is short at courtneyalbright.com

Test: fast/overflow/float-in-relpositioned.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::lowestPosition): Add this block's relative offset to floats' and positioned objects' lowest position. (WebCore::RenderBlock::rightmostPosition): Ditto. (WebCore::RenderBlock::leftmostPosition): Ditto.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::lowestPosition): Removed redundant test. (WebCore::RenderBox::rightmostPosition): Ditto. (WebCore::RenderBox::leftmostPosition): Ditto.

LayoutTests:

Reviewed by Dave Hyatt.

  • test, updated test and results for <rdar://problem/6059648> Some content not visible when the window is short at courtneyalbright.com
  • fast/overflow/float-in-relpositioned.html: Added.
  • fast/repaint/containing-block-position-change.html: Changed to avoid a full repaint due to a scroll bar appearing.
  • platform/mac/fast/clip/015-expected.txt:
  • platform/mac/fast/overflow/float-in-relpositioned-expected.checksum: Added.
  • platform/mac/fast/overflow/float-in-relpositioned-expected.png: Added.
  • platform/mac/fast/overflow/float-in-relpositioned-expected.txt: Added.
  • platform/mac/fast/repaint/clipped-relative-expected.txt:
11:51 AM Changeset in webkit [35426] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6048566> Repaint original element's position, not its offset position

Test: fast/repaint/layout-state-relative.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::absolutePosition): Changed the LayoutState-enabled code path to account for the object's relative offset. (WebCore::RenderBox::computeAbsoluteRepaintRect): Ditto.

LayoutTests:

Reviewed by Dave Hyatt.

  • repaint test for <rdar://problem/6048566> Repaint original element's position, not its offset position
  • fast/repaint/layout-state-relative.html: Added.
  • platform/mac/fast/repaint/layout-state-relative-expected.checksum: Added.
  • platform/mac/fast/repaint/layout-state-relative-expected.png: Added.
  • platform/mac/fast/repaint/layout-state-relative-expected.txt: Added.
11:51 AM Changeset in webkit [35425] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Change Vector::find to return an index instead of an iterator

Indices are more natural than iterators when working with Vector.

Reviewed by John Sullivan.

  • wtf/Vector.h: (WTF::Vector::find): Changed to iterate the Vector manually and return the index of the found item, rather than an iterator. When the item could not be found, we return WTF::notFound.
11:28 AM Changeset in webkit [35424] by hyatt@apple.com
  • 3 adds in trunk/LayoutTests/platform/mac/fast/css/variables/alternate-syntax
11:27 AM Changeset in webkit [35423] by hyatt@apple.com
  • 1 edit
    5 adds in trunk/LayoutTests

2008-07-29 David Hyatt <​hyatt@apple.com>

Add a layout test for using multiple variable declaration blocks in a single style rule.

  • fast/css/variables/alternate-syntax/multiple-blocks-test.html: Added.
  • fast/css/variables/multiple-blocks-test.html: Added.
  • platform/mac/fast/css/variables/multiple-blocks-test-expected.checksum: Added.
  • platform/mac/fast/css/variables/multiple-blocks-test-expected.png: Added.
  • platform/mac/fast/css/variables/multiple-blocks-test-expected.txt: Added.
11:10 AM Changeset in webkit [35422] by Adam Roben
  • 3 edits in trunk/WebKit/win

Export detachThread

Reviewed by Geoff Garen.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def:
11:04 AM Changeset in webkit [35421] by timothy@apple.com
  • 10 edits in trunk/WebCore

Fixed Bug 19158: Inspector should support console.group/console.groupEnd

<​https://bugs.webkit.org/show_bug.cgi?id=19158>

Reviewed by Tim Hatcher and Adam Roben.

  • bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::group): Added.
  • page/Console.cpp: (WebCore::Console::group): Added. (WebCore::Console::groupEnd): Added.
  • page/Console.h: (WebCore::):
  • page/Console.idl: Added group/groupEnd.
  • page/InspectorController.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::InspectorController::InspectorController): Added m_groupLevel. (WebCore::InspectorController::addMessageToConsole): Added groupLevel argument. (WebCore::InspectorController::startGroup): Increments m_groupLevel by one and calls js function if needed. (WebCore::InspectorController::endGroup): Decrements m_groupLevel by one and calls js function if needed. (WebCore::InspectorController::addScriptConsoleMessage): Added groupLevel argument. (WebCore::InspectorController::didCommitLoad): Resets m_groupLevel.
  • page/InspectorController.h:
  • page/inspector/Console.js: (WebInspector.Console): Added groupLevel and currentGroup topGroup. (WebInspector.Console.addMessage): Calls addMessage method in the currentGroup. (WebInspector.Console.startGroup): Added. (WebInspector.Console.endGroup): Added. (WebInspector.Console.clearMessages): Resets groupLevel and currentGroup. (WebInspector.ConsoleMessage): Added groupLevel property. (WebInspector.ConsoleMessage.MessageLevel.GroupTitle): Added. (WebInspector.ConsoleGroup): Added. (WebInspector.ConsoleGroup.addMessage): Adds console message to group. (WebInspector.ConsoleGroup._titleClicked): Adds "collapsed" style class.
  • page/inspector/inspector.css:
  • page/inspector/inspector.js: (WebInspector.startGroupInConsole): Calls console.startGroup (WebInspector.endGroupInConsole): Calls console.endGroup
9:23 AM Changeset in webkit [35420] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Windows build fix

  • wtf/ThreadingWin.cpp: (WTF::setThreadName): Move a misplaced assertion to here... (WTF::createThread): ...from here.
9:11 AM Changeset in webkit [35419] by Adam Roben
  • 15 edits in trunk

Add support for setting thread names on Windows

JavaScriptCore:

Add support for setting thread names on Windows

These thread names make it much easier to identify particular threads
in Visual Studio's Threads panel.

WTF::createThread now takes a const char* representing the thread's
name. On Windows, we throw a special exception to set this string as
the thread's name. Other platforms do nothing with this name for now.

Reviewed by Anders Carlsson.

  • JavaScriptCore.exp: Export the new version of createThread that takes 3 arguments (the old one continues to be exported for backward compatibility).
  • wtf/Threading.h: Add a threadName argument to createThread.
  • wtf/ThreadingGtk.cpp: (WTF::createThread):
  • wtf/ThreadingNone.cpp: (WTF::createThread): Updated for function signature change.
  • wtf/ThreadingPthreads.cpp: (WTF::createThread): Updated for function signature change. We keep around the old 2-argument version of createThread for backward compatibility.
  • wtf/ThreadingWin.cpp: (WTF::setThreadName): Added. This function's implementation came from MSDN. (WTF::initializeThreading): Set the name of the main thread. (WTF::createThread): Call setThreadName. We keep around the old 2-argument version of createThread for backward compatibility.

WebCore:

Add names for WebCore's threads

Reviewed by Anders Carlsson.

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open):
  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::start):
  • storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::start): Pass in names to createThread.
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::runLoaderThread): (WebCore::ResourceHandle::loaderRunLoop): Changed to use WTF::createThread.

WebKit/win:

Export the new version of createThread

Reviewed by Anders Carlsson.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def: Also moved the old version of createThread into the deprecated section.
1:16 AM Changeset in webkit [35418] by ap@webkit.org
  • 8 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt.

Store UString::Rep::isStatic bit in identifierTable pointer instead of reportedCost for
slightly nicer code and a 0.5% SunSpider improvement.

Jul 28, 2008:

5:37 PM Changeset in webkit [35417] by andersca@apple.com
  • 3 edits in trunk/WebCore

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Based on a patch from Dimcho Balev.


Windows part of


​https://bugs.webkit.org/show_bug.cgi?id=18676
<rdar://problem/6106578>
Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs

  • plugins/PluginStream.cpp: (WebCore::PluginStream::wantsAllStreams):
  • plugins/PluginStream.h:
4:38 PM Changeset in webkit [35416] by jchaffraix@webkit.org
  • 11 edits
    2 adds in branches/XBL2

WebCore:

2008-07-28 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Bug 20196: [XBL] Re-enable CSS binding attachment

  • Re-enable legacy CSS attachment code.
  • Add XBLBindingManager bits so that it also creates / removes the required bindings.
  • Renamed '-webkit-binding' property to 'binding' (the name in the specification)

Test: fast/xbl/xbl-css-attachment.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::removeBindings): Added remove bindings and the style information associated.
  • css/CSSStyleSelector.h:
  • dom/Element.cpp: (WebCore::Element::hasBinding): Update the style as it will cause binding updates.
  • rendering/style/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::BindingURI::BindingURI):
  • rendering/style/RenderStyle.h:
  • xbl/XBLBindingManager.cpp: (WebCore::XBLBindingManager::addBinding): Limit to one binding per element with the same uri as the CSS attachment code can be hit twice.

LayoutTests:

2008-07-28 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Test case for bug 20196: [XBL] Re-enable CSS binding attachment

  • fast/xbl/xbl-css-attachment-expected.txt: Added.
  • fast/xbl/xbl-css-attachment.html: Added.
4:34 PM Changeset in webkit [35415] by beidson@apple.com
  • 6 edits
    4 adds in trunk

WebCore:

2008-07-28 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

Test: security/autocomplete-cleared-on-back.html

<rdar://problem/6093281> - autocomplete="off" should work when going back

Taken care of in two ways:
1 - Listening for the page cache notification to clear the form, in cases where the page

is being restored from the page cache

2 - Not saving such form elements when doing the normal "save state" to a history item,

for cases with no page cache

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::~HTMLFormElement): (WebCore::HTMLFormElement::parseMappedAttribute): (WebCore::HTMLFormElement::didRestoreFromCache): (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): (WebCore::HTMLFormElement::didMoveToNewOwnerDocument):
  • html/HTMLFormElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::saveState): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::needsCacheCallback): (WebCore::HTMLInputElement::registerForCacheCallbackIfNeeded): Only register if the type or attribute indicate we should. (WebCore::HTMLInputElement::unregisterForCacheCallbackIfNeeded): Only unregister if both the type and attribute are clear of needing registration. (WebCore::HTMLInputElement::didRestoreFromCache): (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): (WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
  • html/HTMLInputElement.h:

LayoutTests:

2008-07-28 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

<rdar://problem/6093281> - autocomplete="off" should work when going back

  • security/autocomplete-cleared-on-back-expected.txt: Added.
  • security/autocomplete-cleared-on-back.html: Added.
  • security/resources: Added.
  • security/resources/autocomplete-cleared-on-back2.html: Added.
3:50 PM Changeset in webkit [35414] by hyatt@apple.com
  • 14 edits
    16 adds in trunk

2008-07-28 David Hyatt <​hyatt@apple.com>

Add support for CSS variable declaration blocks.

Reviewed by Sam

Added tests in fast/css/variables.

  • css/CSSGrammar.y:
  • css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::isMutableStyleDeclaration):
  • css/CSSParser.cpp: (WebCore::CSSParser::addVariableDeclarationBlock):
  • css/CSSParser.h:
  • css/CSSProperty.cpp: (WebCore::CSSProperty::cssText):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::addMatchedDeclaration): (WebCore::CSSStyleSelector::resolveVariablesForDeclaration):
  • css/CSSStyleSelector.h:
  • css/CSSValueList.h: (WebCore::CSSValueList::isValueList):
  • css/CSSVariablesDeclaration.cpp: (WebCore::CSSVariablesDeclaration::CSSVariablesDeclaration): (WebCore::CSSVariablesDeclaration::getVariableValue): (WebCore::CSSVariablesDeclaration::removeVariable): (WebCore::CSSVariablesDeclaration::addParsedVariable): (WebCore::CSSVariablesDeclaration::getParsedSimpleVariable): (WebCore::CSSVariablesDeclaration::getParsedComplexVariable):
  • css/CSSVariablesDeclaration.h: (WebCore::CSSVariablesDeclaration::create):
  • css/StyleBase.cpp: (WebCore::StyleBase::cssText):
  • css/StyleBase.h: (WebCore::StyleBase::isValueList): (WebCore::StyleBase::isMutableStyleDeclaration):
3:46 PM Changeset in webkit [35413] by andersca@apple.com
  • 4 edits
    4 adds in trunk

../../../../../../LayoutTests:

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam.

<rdar://problem/6098335>
​https://bugs.webkit.org/show_bug.cgi?id=20150


Add tests.


  • http/tests/xmlhttprequest/resources/forbidden.txt: Added.
  • http/tests/xmlhttprequest/resources/redirect.php: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html: Added.

../../../../../../WebCore:

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam.

<rdar://problem/6098335>
​https://bugs.webkit.org/show_bug.cgi?id=20150


Handle willSendRequest correctly.

  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::willSendRequest): Make sure to keep the previous URL around so we know when to call willSendRequest.


  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::processSyncLoadResults): Abort if we don't have access to the response URL.


(WebCore::XMLHttpRequest::willSendRequest):
Dispatch a network error if we can't access the new URL.

2:15 PM Changeset in webkit [35412] by jchaffraix@webkit.org
  • 4 edits
    1 add in branches/XBL2/WebCore

2008-07-28 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Bug 20171: [XBL] Add <binding> 'element' attribute

  • DerivedSources.make: Add attrs file.
  • GNUmakefile.am: Ditto.
  • WebCore.pro: Ditto.
  • xbl/xblattrs.in: Added.
1:04 PM Changeset in webkit [35411] by ggaren@apple.com
  • 25 edits in trunk

JavaScriptCore:

2008-07-28 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Renamed "ConstructTypeNative" => "ConstructTypeHost".

WebCore:

2008-07-28 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Renamed "ConstructTypeNative" => "ConstructTypeHost".

12:23 PM Changeset in webkit [35410] by andersca@apple.com
  • 2 edits in trunk

Add radar number

12:20 PM Changeset in webkit [35409] by andersca@apple.com
  • 10 edits in trunk

../../../../../../WebCore:

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Based on a patch by Dimcho Balev.

​https://bugs.webkit.org/show_bug.cgi?id=18676
Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs


  • bridge/npapi.h: Add new enum values.


  • loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): When the plug-in indicates that it wants all streams to be delivered, don't cancel the stream if an error occurs.


  • loader/NetscapePlugInStreamLoader.h: (WebCore::NetscapePlugInStreamLoaderClient::wantsAllStreams): Add new client method.

../../../../../../WebKit/mac:

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Based on a patch by Dimcho Balev.


​https://bugs.webkit.org/show_bug.cgi?id=18676
Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs

  • Plugins/WebBaseNetscapePluginStream.h: Add NPP_GetValue pointer.


  • Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream setPlugin:]): Initialize NPP_GetValue.


(-[WebBaseNetscapePluginStream wantsAllStreams]):
Call NPP_GetValue.


  • Plugins/WebPlugInStreamLoaderDelegate.h:
  • WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h:
  • WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm: (WebNetscapePlugInStreamLoaderClient::wantsAllStreams): Implement this and call down to the stream.
9:59 AM Changeset in webkit [35408] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam.

<rdar://problem/6105529>
​https://bugs.webkit.org/show_bug.cgi?id=19659
Turning off plugins causes crash


When an active page has plug-ins, and plug-ins are disabled, they will be stopped and will
end up in a state where they don't have an event handler. Because of this, we need to
check that the plug-in has been started before calling the event handler.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendDrawRectEvent:]): (-[WebBaseNetscapePluginView setHasFocus:]): (-[WebBaseNetscapePluginView mouseDown:]): (-[WebBaseNetscapePluginView mouseUp:]): (-[WebBaseNetscapePluginView mouseEntered:]): (-[WebBaseNetscapePluginView mouseExited:]): (-[WebBaseNetscapePluginView handleMouseMoved:]): (-[WebBaseNetscapePluginView mouseDragged:]): (-[WebBaseNetscapePluginView scrollWheel:]): (-[WebBaseNetscapePluginView keyUp:]): (-[WebBaseNetscapePluginView keyDown:]): (-[WebBaseNetscapePluginView flagsChanged:]): (-[WebBaseNetscapePluginView cut:]): (-[WebBaseNetscapePluginView copy:]): (-[WebBaseNetscapePluginView paste:]): (-[WebBaseNetscapePluginView selectAll:]): (-[WebBaseNetscapePluginView drawRect:]): (-[WebBaseNetscapePluginView inputContext]):
12:37 AM Changeset in webkit [35407] by mrowe@apple.com
  • 2 edits in trunk/WebKitSite

2008-07-28 Robert Blaut <​webkit@blaut.biz>

Reviewed by Mark Rowe.

Fix for bug: Website provides no guidance on debugging
<​https://bugs.webkit.org/show_bug.cgi?id=3643>

  • building/debug.html: added info about Xcode Debugging Guide.

Jul 27, 2008:

3:03 PM Changeset in webkit [35406] by weinig@apple.com
  • 5 edits
    6 adds in trunk

WebCore:

2008-07-27 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=20176
querySelectorAll id optimization no longer working

Turn the querySelector/querySelectorAll id optimization back on
for only strict and almost strict mode. In quirks mode, the optimiztion
won't work as the id match is not case sensitive.

Tests: fast/dom/SelectorAPI/caseID-almost-strict.html

fast/dom/SelectorAPI/caseID-strict.html
fast/dom/SelectorAPI/caseID.html

  • dom/Node.cpp: (WebCore::Node::querySelector): (WebCore::Node::querySelectorAll):
  • dom/SelectorNodeList.cpp: (WebCore::createSelectorNodeList):
  • dom/SelectorNodeList.h:

LayoutTests:

2008-07-27 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Tests for ​https://bugs.webkit.org/show_bug.cgi?id=20176
querySelectorAll id optimization no longer working

  • fast/dom/SelectorAPI/caseID-almost-strict-expected.txt: Added.
  • fast/dom/SelectorAPI/caseID-almost-strict.html: Added.
  • fast/dom/SelectorAPI/caseID-expected.txt: Added.
  • fast/dom/SelectorAPI/caseID-strict-expected.txt: Added.
  • fast/dom/SelectorAPI/caseID-strict.html: Added.
  • fast/dom/SelectorAPI/caseID.html: Added.
2:34 PM Changeset in webkit [35405] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/qt

Fix Qt build failure.

  • Api/qwebframe.h: (QWebFrame::setScrollOffset): Make argument const.
2:27 PM Changeset in webkit [35404] by ddkilzer@apple.com
  • 3558 edits in trunk/LayoutTests

Set svn:mime-type to image/png.

2:08 PM Changeset in webkit [35403] by ddkilzer@apple.com
  • 9 edits
    3 adds in trunk

WebCore:

2008-07-21 Anatoli Papirovski <​apapirovski@mac.com>

Reviewed by Dave Hyatt.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=14346
Modified the css parser:

  • not to fail when closing braces are not found for a declaration at the end of the file
  • not to accept "!important fail" as valid
  • to keep accepting @import when it comes after invalid @ rules
  • not to drop the whole @media block when there's an error before the closing brace + some other minor css parsing revisions.

CSSGrammar.y tweaked by David Kilzer to fix Tiger builds.

  • css/CSSGrammar.y:

LayoutTests:

2008-07-21 Anatoli Papirovski <​apapirovski@mac.com>

Reviewed by Dave Hyatt.

Updated layout CSS2.1 test suite tests related to css parsing:
​https://bugs.webkit.org/show_bug.cgi?id=14346

  • platform/mac/css2.1/t040105-import-01-b-expected.checksum:
  • platform/mac/css2.1/t040105-import-01-b-expected.png:
  • platform/mac/css2.1/t040105-import-01-b-expected.txt:
  • platform/mac/css2.1/t0402-syntax-05-f-expected.checksum:
  • platform/mac/css2.1/t0402-syntax-05-f-expected.png:
  • platform/mac/css2.1/t0402-syntax-05-f-expected.txt:
  • platform/mac/css2.1/t0402-syntax-06-f-expected.checksum:
  • platform/mac/css2.1/t0402-syntax-06-f-expected.png:
  • platform/mac/css2.1/t0402-syntax-06-f-expected.txt:
3:43 AM Changeset in webkit [35402] by jmalonzo@webkit.org
  • 5 edits in trunk/WebCore

2008-07-27 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Eric Seidel.

Use --outputDir instead of --output when invoking make_names.pl
There's no option named "output" in make_names.pl

  • GNUmakefile.am:
  • WebCore.pro:
  • DerivedSources.make: Remove --output. Not necessary here.
  • bindings/scripts/generate-bindings.pl: Rename --outputdir to --outputDir for consistency with make_names.pl
3:28 AM HackingGtk edited by jserv.tw@gmail.com
(diff)

Jul 26, 2008:

11:56 PM Changeset in webkit [35401] by mrowe@apple.com
  • 3 edits in trunk/LayoutTests

2008-07-26 Mark Rowe <​mrowe@apple.com>

Update some layout test results.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/domListEnumeration-expected.txt:
11:08 PM Changeset in webkit [35400] by mrowe@apple.com
  • 2 edits in trunk/WebKitSite

2008-07-26 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Oliver Hunt.

Update the Squirrelfish bytecode documentation.

  • specs/squirrelfish-bytecode.html:
11:02 PM Changeset in webkit [35399] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-07-26 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Eric Seidel.

​http://bugs.webkit.org/show_bug.cgi?id=18694
[CAIRO] Problem with rotation in a given matrix in SVG

Changed values given to AffineTransform.

  • platform/graphics/cairo/AffineTransformCairo.cpp: (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::setMatrix):
11:00 PM Changeset in webkit [35398] by jmalonzo@webkit.org
  • 3 edits in trunk

2008-07-25 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Mark Rowe.

Copy the way Gtk detects jpeglib. Hinted by Wouter Bolsterlee.

[Gtk] Improve detection jpeglib
​https://bugs.webkit.org/show_bug.cgi?id=17865

  • GNUmakefile.am:
  • configure.ac:
10:59 PM Changeset in webkit [35397] by mrowe@apple.com
  • 3 edits in trunk/WebKit/qt

2008-07-26 Marc Ordinas i Llopis <​marc.ordinasillopis@collabora.co.uk>

Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=20010
[Qt] Add API access to scrolling

  • Api/qwebframe.cpp: Added access to a frame scroll offset. (QWebFrame::scroll): (QWebFrame::scrollOffset): (QWebFrame::setScrollOffset):
  • Api/qwebframe.h:
10:58 PM Changeset in webkit [35396] by mitz@apple.com
  • 3 edits in trunk/LayoutTests

Rubber-stamped by Sam Weinig.

  • update test and expected results for attributes added to HTMLFormElement and HTMLSelectElement.
  • fast/dom/domListEnumeration-expected.txt:
  • fast/dom/resources/domListEnumeration.js:
10:53 PM Changeset in webkit [35395] by mrowe@apple.com
  • 2 edits in trunk/WebKitSite

2008-07-26 Robert Blaut <​webkit@blaut.biz>

Reviewed by Eric Seidel.

Fix for <​https://bugs.webkit.org/show_bug.cgi?id=19712>
Corrected validation errors in main.css file.

  • css/main.css:
10:52 PM Changeset in webkit [35394] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-07-26 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Mark Rowe.

Call curl_global_cleanup() to release resources acquired by curl_global_init()

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::~ResourceHandleManager):
10:49 PM Changeset in webkit [35393] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-07-26 Marc Ordinas i Llopis <​marc.ordinasillopis@collabora.co.uk>

Reviewed by Simon Hausmann.

Bug 18938: [GTK] Plugins not resized
​https://bugs.webkit.org/show_bug.cgi?id=18938

  • plugins/PluginView.cpp: (WebCore::PluginView::setFrameGeometry): When viewing a full-page plugin in unix, geometry changes have to be passed to the plugin.
10:44 PM Changeset in webkit [35392] by mrowe@apple.com
  • 6 edits
    1 add in trunk/WebCore

2008-07-26 Keishi Hattori <​casey.hattori@gmail.com>

Reviewed by Adam Roben.

Add console.time/timeEnd.
​https://bugs.webkit.org/show_bug.cgi?id=19159

  • manual-tests/inspector/console-time.html: Added. Test cases for console.time/timeEnd.
  • page/Console.cpp: (WebCore::Console::time): Added. (WebCore::Console::timeEnd): Added.
  • page/Console.h:
  • page/Console.idl: Added console.time/timeEnd.
  • page/InspectorController.cpp: (WebCore::InspectorController::startTiming): Added. (WebCore::InspectorController::stopTiming): Added.
  • page/InspectorController.h:
10:40 PM Changeset in webkit [35391] by mrowe@apple.com
  • 3 edits in trunk/WebCore

2008-07-26 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Nikolas Zimmermann.

Fixes rendering issues with gradients in SVG/Cairo.

  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::boundingRect):
  • svg/graphics/cairo/SVGPaintServerGradientCairo.cpp: (WebCore::applyStrokeStyleToContext): (WebCore::SVGPaintServerGradient::setup):
10:38 PM Changeset in webkit [35390] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-07-26 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Nikolas Zimmermann.

Added pattern-support for SVG in Cairo.

  • svg/graphics/cairo/SVGPaintServerPatternCairo.cpp: (WebCore::applyStrokeStyleToContext): (WebCore::SVGPaintServerPattern::setup):
10:32 PM Changeset in webkit [35389] by mrowe@apple.com
  • 2 edits in trunk/WebKitSite

2008-07-26 Robert Blaut <​webkit@blaut.biz>

Reviewed by Alexey Proskuryakov.

Fix for bug: <​https://bugs.webkit.org/show_bug.cgi?id=18186>
Added notes about unsupported Visual Studio versions.

  • building/tools.html:
10:29 PM Changeset in webkit [35388] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-26 Mark Rowe <​mrowe@apple.com>

Speculative fix for the wx build.

  • JavaScriptCoreSources.bkl: Add JSStaticScopeObject.cpp to the list of source files.
10:27 PM Changeset in webkit [35387] by mrowe@apple.com
  • 2 edits in trunk/WebKit/gtk

2008-07-26 Mark Rowe <​mrowe@apple.com>

Build fix. Changes to accommodate newly named/signatured loading methods in WebCore.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame):
10:23 PM Changeset in webkit [35386] by mrowe@apple.com
  • 3 edits in trunk/WebKit/qt

2008-07-26 Daniel Jalkut <​jalkut@red-sweater.com>

Build fix. Adjust to updated WebCore FrameLoader method names & signatures.

  • Api/qwebpage.cpp: (QWebPage::triggerAction):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createFrame):
10:20 PM Changeset in webkit [35385] by mrowe@apple.com
  • 2 edits in trunk/WebKitSite

2008-07-26 Robert Blaut <​webkit@blaut.biz>

Reviewed by Eric Seidel.

Fix for <​https://bugs.webkit.org/show_bug.cgi?id=16719>
Removed basic requirements for undetected version of WebKit.

  • quality/reporting.html:
10:18 PM Changeset in webkit [35384] by mrowe@apple.com
  • 2 edits in trunk/WebKitSite

2008-07-26 Robert Blaut <​webkit@blaut.biz>

Reviewed by Adele Petersen.

Fix for bug 7436: Truncated title on webkit DOM page.
<​https://bugs.webkit.org/show_bug.cgi?id=7436>

  • projects/dom/index.html: Added basic project informations.
10:14 PM Changeset in webkit [35383] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-07-26 Keishi Hattori <​casey.hattori@gmail.com>

Reviewed by Adam Roben.

Fixed bug 18540: console.log('multiple', 'strings') quotes all strings after the first
<​https://bugs.webkit.org/show_bug.cgi?id=18540>

  • page/inspector/Console.js: (WebInspector.ConsoleMessage.prototype._format): String arguments are appended without formatting.
10:10 PM Changeset in webkit [35382] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-07-26 Anthony Ricaud <​rik24d@gmail.com>

Reviewed by Tim Hatcher.

<​https://bugs.webkit.org/show_bug.cgi?id=17589> Line highlighting should last longer

Restore the fade out effect after highlighting.

  • page/inspector/SourceFrame.js: Add a class for fade-out effects and sets it at the end of highlighting time.
10:08 PM Changeset in webkit [35381] by mrowe@apple.com
  • 13 edits
    20 adds in trunk

2008-07-26 Michelangelo De Simone <​michelangelo@me.com>

Reviewed by Adele Petersen.

Added the simple willValidate attribute to form controls according to
WebForms 2 spec.

URL: ​http://www.w3.org/TR/web-forms-2/#willvalidate

Tests: fast/forms/willvalidate-000.html

fast/forms/willvalidate-001.html
fast/forms/willvalidate-002.html
fast/forms/willvalidate-003.html
fast/forms/willvalidate-004.html
fast/forms/willvalidate-005.html
fast/forms/willvalidate-006.html
fast/forms/willvalidate-007.html
fast/forms/willvalidate-008.html
fast/forms/willvalidate-009.html

  • html/HTMLButtonElement.h: Added willValidate(), always false.
  • html/HTMLButtonElement.idl: willValidate attribute exposed.
  • html/HTMLFieldSetElement.h: Added willValidate(), always false.
  • html/HTMLFieldSetElement.idl: willValidate attribute exposed.
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::willValidate): Added base willValidate() implementation.
  • html/HTMLFormControlElement.h: Added willValidate().
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::willValidate): Added willValidate(), checks for input type.
  • html/HTMLInputElement.h: Added willValidate()
  • html/HTMLInputElement.idl: willValidate attribute exposed.
  • html/HTMLSelectElement.idl: willValidate attribute exposed.
  • html/HTMLTextAreaElement.idl: willValidate attribute exposed.

2008-07-26 Michelangelo De Simone <​m.des@mac.com>

Reviewed by Adele Petersen.

Test suite for the willValidate form controls attribute.

  • fast/forms/willvalidate-000-expected.txt: Added.
  • fast/forms/willvalidate-000.html: Added.
  • fast/forms/willvalidate-001-expected.txt: Added.
  • fast/forms/willvalidate-001.html: Added.
  • fast/forms/willvalidate-002-expected.txt: Added.
  • fast/forms/willvalidate-002.html: Added.
  • fast/forms/willvalidate-003-expected.txt: Added.
  • fast/forms/willvalidate-003.html: Added.
  • fast/forms/willvalidate-004-expected.txt: Added.
  • fast/forms/willvalidate-004.html: Added.
  • fast/forms/willvalidate-005-expected.txt: Added.
  • fast/forms/willvalidate-005.html: Added.
  • fast/forms/willvalidate-006-expected.txt: Added.
  • fast/forms/willvalidate-006.html: Added.
  • fast/forms/willvalidate-007-expected.txt: Added.
  • fast/forms/willvalidate-007.html: Added.
  • fast/forms/willvalidate-008-expected.txt: Added.
  • fast/forms/willvalidate-008.html: Added.
  • fast/forms/willvalidate-009-expected.txt: Added.
  • fast/forms/willvalidate-009.html: Added.
9:21 PM Changeset in webkit [35380] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Build fix.

9:10 PM Changeset in webkit [35379] by mitz@apple.com
  • 3 edits in trunk/LayoutTests

Rubber-stamped by Mark Rowe.

  • platform/win/Skipped: Added fast/text/international/bidi-AN-after-empty-run.html (<rdar://problem/5075790>) and svg/custom/stroke-width-click.svg (<rdar://problem/5539822>).
  • platform/win/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Updated results for the new way path data is dumped after <​http://trac.webkit.org/changeset/34117>.
9:07 PM Changeset in webkit [35378] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Build fix.

8:49 PM Changeset in webkit [35377] by mrowe@apple.com
  • 16 edits in trunk

2008-07-26 Daniel Jalkut <​jalkut@red-sweater.com>

Reviewed by Geoff Garen.

Revised the FrameLoader class to clean up a variety of load methods, and hopefully
move things closer to integrating into a smaller set of load methods. To this
end, I renamed many of the overloaded load() methods to have more meaningful and
easier to search names. I added comments to the header file to provide clues as
to how many of the load methods are being used, and how they fit into the loading
process. I suspect that the renamed methods and comments indicating their present
usage will facilitate easier cleanup by myself and others as inspiration strikes.

Updated clients of FrameLoader where necessary to adapt to the new method names and signatures.

Combined the 3 canLoad() methods into a single canLoad which expresses the
intended logic of the 3 with a single method interface.

Removed unnecessary "treatAsLocal" attribute of CachedResource. It was only called from
one place in FrameLoader.cpp, and it derived at initialization time by calling back to FrameLoader.

Removed unused userGesture parameter to one variant of the urlSelected method, and
moved one of the urlSelected methods so that it lives nearer to its overloaded
sibling.

  • WebCore.base.exp:
  • loader/Cache.cpp: (WebCore::Cache::requestResource):
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource):
  • loader/CachedResource.h: (WebCore::CachedResource::errorOccurred):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::loadPlugin): (WebCore::FrameLoader::loadFrameRequestWithFormState): (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::loadWithNavigationAction): (WebCore::FrameLoader::load): (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::canLoad): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::loadPostRequest): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::loadItem):
  • loader/FrameLoader.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):

2008-07-26 Daniel Jalkut <​jalkut@red-sweater.com>

Reviewed by Geoff Garen.

Changes to accommodate newly named/signatured loading methods in WebCore.

  • Plugins/WebNetscapePluginStream.mm: (-[WebNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
  • Plugins/WebPluginContainerCheck.mm: (-[WebPluginContainerCheck _isForbiddenFileLoad]):
  • WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]):

2008-07-26 Matt Lilek <​webkit@mattlilek.com>

Reviewed by Geoff Garen.

Changes to accommodate newly named/signatured loading methods in WebCore.

  • WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle):
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::loadURLIntoChild):
7:47 PM Changeset in webkit [35376] by weinig@apple.com
  • 2 edits in trunk

Add radar number to ChangeLog

7:45 PM Changeset in webkit [35375] by weinig@apple.com
  • 6 edits
    8 adds in trunk

WebCore:

2008-07-26 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=20122
REGRESSION (r35075-r35110): Cannot enlarge images at Apple Store product page

Use strict parsing when in AlmostStrict mode.

Tests: fast/dom/SelectorAPI/dumpNodeList-almost-strict.html

fast/dom/SelectorAPI/id-fastpath-almost-strict.html
fast/dom/SelectorAPI/id-fastpath-strict.html

  • dom/Node.cpp: (WebCore::Node::querySelector): (WebCore::Node::querySelectorAll):

LayoutTests:

2008-07-26 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=20122
REGRESSION (r35075-r35110): Cannot enlarge images at Apple Store product page

  • Additionally, fix some errors introduced in old tests.
  • fast/dom/SelectorAPI/dumpNodeList-almost-strict-expected.txt: Added.
  • fast/dom/SelectorAPI/dumpNodeList-almost-strict.html: Added.
  • fast/dom/SelectorAPI/dumpNodeList-expected.txt:
  • fast/dom/SelectorAPI/dumpNodeList.html:
  • fast/dom/SelectorAPI/id-fastpath-almost-strict-expected.txt: Added.
  • fast/dom/SelectorAPI/id-fastpath-almost-strict.html: Added.
  • fast/dom/SelectorAPI/id-fastpath-strict-expected.txt: Added.
  • fast/dom/SelectorAPI/id-fastpath-strict.html: Added.
  • fast/dom/SelectorAPI/resources/id-fastpath-almost-strict.js: Added.
  • fast/dom/SelectorAPI/resources/id-fastpath-strict.js: Added.
  • fast/dom/SelectorAPI/resources/id-fastpath.js:
4:59 PM Changeset in webkit [35374] by mitz@apple.com
  • 1 edit
    2 moves
    2 adds in trunk/LayoutTests
  • move Leopard-only expected failure results back to mac-leopard; these are covered by <rdar://problem/5539818> and <rdar://problem/5539820>.
  • platform/mac-leopard/http: Added.
  • platform/mac-leopard/http/tests: Added.
  • platform/mac-leopard/http/tests/security: Copied from platform/mac/http/tests/security.
  • platform/mac-leopard/security: Copied from platform/mac/security.
  • platform/mac/http/tests/security: Removed.
  • platform/mac/http/tests/security/dataURL: Removed.
  • platform/mac/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Removed.
  • platform/mac/security: Removed.
  • platform/mac/security/block-test-expected.txt: Removed.
4:37 PM Changeset in webkit [35373] by mitz@apple.com
  • 2 edits
    1 copy
    1 move
    1 add
    3 deletes in trunk/LayoutTests

Reviewed by Oliver Hunt.

  • clean up expected layout test results
  • fast/encoding/idn-security-expected.txt: Replaced with LayoutTests/platform/mac/fast/encoding/idn-security-expected.txt, which is the version of the results for platforms that have "newer ICU".
  • platform/mac-leopard/Skipped: Added svg/custom/stroke-width-click.svg.
  • platform/mac-tiger/fast/encoding: Added.
  • platform/mac-tiger/fast/encoding/idn-security-expected.txt: Copied from LayoutTests/fast/encoding/idn-security-expected.txt, as Tiger still needs the "older ICU" version of the results.
  • platform/mac/fast/encoding/idn-security-expected.txt: Removed.
  • platform/mac/svg/custom/stroke-width-click-expected.checksum: Removed pixel results for a text-only test.
  • platform/mac/svg/custom/stroke-width-click-expected.png: Ditto.
  • platform/mac/svg/custom/stroke-width-click-expected.txt: Removed platform-specific results for a text-only test.
1:04 PM Changeset in webkit [35372] by jchaffraix@webkit.org
  • 5 edits
    2 adds in branches/XBL2

WebCore:

2008-07-26 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by David Hyatt.

Bug 20172: [XBL] XBL elements should not be rendered

  • Roll out renderer disabling bits as they were bogus.
  • Add XBL CSS default rules to html4.css.

Test: fast/xbl/xbl-default-rules.xhtml

  • css/html4.css:
  • xbl/XBLDocument.h: (WebCore::XBLDocument::XBLDocument):
  • xbl/XBLElement.h: (WebCore::XBLElement::isXBLElement):

LayoutTest:

2008-07-26 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by David Hyatt.

Test case for bug 20172: [XBL] XBL elements should not be rendered

  • fast/xbl/xbl-default-rules-expected.txt: Added.
  • fast/xbl/xbl-default-rules.xhtml: Added.
11:59 AM Changeset in webkit [35371] by mitz@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

Rubber-stamped by Nikolas Zimmermann.

  • move platform-independent results back to the generic location
  • platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.txt: Removed.
  • svg/dom/SVGRectElement/rect-modify-rx-expected.txt: Copied from LayoutTests/platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.txt.
6:03 AM Changeset in webkit [35370] by Simon Hausmann
  • 3 edits in trunk/WebCore

2008-07-25 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

Switch off QPainter's anti aliasing when painting the widgets using QStyle
because otherwise the widgets will look blurry and not crisp.

  • platform/qt/RenderThemeQt.cpp: (WebCore::StylePainter::StylePainter): (WebCore::StylePainter::~StylePainter):
  • platform/qt/RenderThemeQt.h:

Jul 25, 2008:

10:18 PM Changeset in webkit [35369] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Whoops, forgot to save style correction.

RS=Cameron Zwarich

8:52 PM Changeset in webkit [35368] by oliver@apple.com
  • 12 edits
    2 adds in trunk

Bug 19718: Named anonymous functions are slow accessing global variables
<​https://bugs.webkit.org/show_bug.cgi?id=19718>

Reviewed by Cameron Zwarich.

To fix this we switch over to an activation-like scope object for
on which we attach the function name property, and add logic to
prevent cross scope assignment to read only properties.

7:28 PM Changeset in webkit [35367] by kevino@webkit.org
  • 2 edits in trunk/JavaScriptCore

On wx/Win, including windows.h in Threading.h causes multiply-defined symbol errors for libjpeg and wx, and also wx needs to include windows.h itself first for wx includes to work right. So until we can find a better solution to this problem on wx, we work around the need to include windows.h here.

5:35 PM Changeset in webkit [35366] by mitz@apple.com
  • 1 edit
    1541 copies
    1 move
    9 adds
    7 deletes in trunk/LayoutTests

Rubber-stamped by Sam Weinig.

  • moved expected results from platform/mac-leopard to platform/mac. Where the mac baseline differed from the Leopard results, moved the results from mac to mac-tiger.
5:34 PM Changeset in webkit [35365] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKitTools

2008-07-25 Jan Michael Alonzo <​jmalonzo@webkit.org>

DRT/Gtk build fix for r35362

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::elementDoesAutoCompleteForElementWithId):
5:00 PM Changeset in webkit [35364] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

  • fix crash due to re-entering purgeInactiveFontData() now that it is called by releaseFontData()

Not testable in DumpRenderTree

  • platform/graphics/FontCache.cpp: (WebCore::FontCache::purgeInactiveFontData): Added a reentry guard.
4:22 PM Changeset in webkit [35363] by beidson@apple.com
  • 1 edit in trunk/WebCore/WebCore.base.exp

Need to check this in, too *sigh*

4:20 PM Changeset in webkit [35362] by beidson@apple.com
  • 10 edits
    2 adds in trunk

WebCore:

2008-07-25 Brady Eidson <​beidson@apple.com>

Reviewed by Sam

Test: security/set-form-autocomplete-attribute.html

Part of the fix for <rdar://problem/6093281> - Improper handling of autocomplete

The autocomplete attribute works on both <form> and <input> elements, but was not
inherited properly when someone asked an <input> if it should autocomplete.

I fixed this up based on the rules in the current WF2 spec so if the <input> element
has its own autocomplete attribute set, it will follow that but otherwise it will
inherit from its parent <form>

  • WebCore.base.exp:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::init): (WebCore::HTMLInputElement::autoComplete): (WebCore::HTMLInputElement::parseMappedAttribute):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::):

WebKitTools:

2008-07-25 Brady Eidson <​beidson@apple.com>

Reviewed by Sam

Add the ability to dump whether-or-not an element should have autocomplete enabled,
from the perspective of the WebKit API

  • DumpRenderTree/LayoutTestController.cpp: (elementDoesAutoCompleteForElementWithIdCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::elementDoesAutoCompleteForElementWithId):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::elementDoesAutoCompleteForElementWithId): Stub for now until I can get on Windows

LayoutTests:

2008-07-25 Brady Eidson <​beidson@apple.com>

Reviewed by Sam

Test for autocomplete attribute cleanup

  • platform/win/Skipped:
  • security/set-form-autocomplete-attribute-expected.txt: Added.
  • security/set-form-autocomplete-attribute.html: Added.
4:16 PM Changeset in webkit [35361] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-07-25 Wouter Bolsterlee <​uws+webkit@xs4all.nl>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=20078
[GTK] Use G_* macros instead of deprecated GTK_* macros in gtk2xtbin.h

  • plugins/gtk/gtk2xtbin.h:
4:12 PM Changeset in webkit [35360] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-07-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam.

Add workaround for a Leopard bug which causes webarchive/test-xml-stylesheet.xml to fail.

  • platform/network/mac/WebCoreURLResponse.mm: (-[NSURLResponse _webcore_MIMEType]):
3:43 PM Changeset in webkit [35359] by andersca@apple.com
  • 3 edits
    1 add in trunk/LayoutTests

2008-07-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Mitz.

Make the willCacheResponse test more robust.


  • http/tests/misc/resources/willCacheResponse-success.html: Added.
  • http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
  • http/tests/misc/willCacheResponse-delegate-callback.html:
3:13 PM Changeset in webkit [35358] by hyatt@apple.com
  • 1 add in trunk/LayoutTests/fast/css/variables/alternate-syntax/color-hex-test-expected.txt

Add result for hex color test

2:42 PM Changeset in webkit [35357] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Anders Carlsson.

  • http/tests/misc/acid3.html: Updated test 77 from acidtests.org. Added alert()ing the log when the score is less than 100.
1:59 PM Changeset in webkit [35356] by mitz@apple.com
  • 1 edit
    9 adds
    2 deletes in trunk/LayoutTests

Rubber-stamped by Brady Eidson.

  • add missing pixel results and move the render tree results under the platform directory
  • platform/mac/svg/dom/SVGRectElement: Added.
  • platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.checksum: Added.
  • platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.png: Added.
  • platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.txt: Added.
  • platform/mac/webarchive: Added.
  • platform/mac/webarchive/loading: Added.
  • platform/mac/webarchive/loading/cache-expired-subresource-expected.checksum: Added.
  • platform/mac/webarchive/loading/cache-expired-subresource-expected.png: Added.
  • platform/mac/webarchive/loading/cache-expired-subresource-expected.txt: Added.
  • svg/dom/SVGRectElement/rect-modify-rx-expected.txt: Removed.
  • webarchive/loading/cache-expired-subresource-expected.txt: Removed.
1:35 PM Changeset in webkit [35355] by Chris Fleizach
  • 9 edits
    4 adds in trunk

<rdar://problem/6084806> AX: REGRESSION: returned line number from TextArea is incorrect

1:21 PM Changeset in webkit [35354] by mitz@apple.com
  • 4 edits
    5 adds in trunk

WebCore:

2008-07-25 Jacob Refstrup <​jacob.refstrup@hp.com>

Reviewed by mitz.


Test: fast/block/float/editable-text-overlapping-float.html

  • rendering/RenderBlock.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::skipTrailingWhitespace):
  • renamed to reflect usage and removed call to position floats; they only get added (WebCore::RenderBlock::skipLeadingWhitespace):
  • renamed to reflect usage (WebCore::RenderBlock::findNextLineBreak):
  • use skipTrailingWhitespace at end of line (as before but with new name)

LayoutTests:

2008-07-25 Jacob Refstrup <​jacob.refstrup@hp.com>

Reviewed by mitz.


  • fast/block/float/editable-text-overlapping-float.html: Added.
  • platform/mac/fast/block/float/editable-text-overlapping-float-expected.checksum: Added.
  • platform/mac/fast/block/float/editable-text-overlapping-float-expected.png: Added.
  • platform/mac/fast/block/float/editable-text-overlapping-float-expected.txt: Added.
  • platform/qt/fast/block/float/editable-text-overlapping-float-expected.txt: Added.
12:27 PM Changeset in webkit [35353] by Adam Roben
  • 2 edits in trunk/WebKitTools

Try to fix the Windows build bot

  • DumpRenderTree/win/DumpRenderTree.vcproj: Don't try to copy files that don't exist for people outside of Apple.
12:10 PM Changeset in webkit [35352] by mitz@apple.com
  • 2 edits in trunk/WebCore

2008-07-25 Dan Bernstein <​mitz@apple.com>

Reviewed by Sam Weinig.

  • platform/graphics/FontCache.cpp: (WebCore::FontDataCacheKeyTraits): Changed needsDestruction to true because FontPlatformData instances hold references to the platform resources and release them in the destructor. (WebCore::cTargetInactiveFontData): Added, replacing cInactiveFontDataPurgeRatio with the number of inactive FontData instances to leave in the cache when automatically purging. (WebCore::FontCache::getCachedFontData): Moved the code that checks if there are too many inactive FontData instances and if so calls purgeInactiveFontData() from here... (WebCore::FontCache::releaseFontData): ... to here. (WebCore::FontCache::purgeInactiveFontData): Added code to also purge the platform font data cache. All FontPlatformData instances that do not have entries in the font data cache are removed, thus releasing the platform resources (such as HFONTs and NSFonts).
11:33 AM Changeset in webkit [35351] by hyatt@apple.com
  • 14 edits
    71 adds in trunk

WebCore:

2008-07-24 David Hyatt <​hyatt@apple.com>

Add support for an alternate syntax for CSS variables. Testers on www-style will be able to try out
both versions of the syntax in WebKit to help us make a decision regarding which one to go with.

Reviewed by Dan

Added fast/css/variables/alternate-syntax/ (duplicated all existing CSS variables tests)

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::createVariablesRule): (WebCore::CSSParser::checkForVariables):
  • css/CSSParser.h:
  • css/CSSParserValues.cpp: (WebCore::CSSParserValue::isVariable): (WebCore::CSSParserValueList::addValue): (WebCore::CSSParserValueList::deleteValueAt): (WebCore::CSSParserValue::createCSSValue):
  • css/CSSParserValues.h:
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::getStringValue): (WebCore::CSSPrimitiveValue::cssText): (WebCore::CSSPrimitiveValue::parserValue):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::): (WebCore::CSSPrimitiveValue::isVariable):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::addMatchedDeclaration):
  • css/CSSVariablesRule.cpp: (WebCore::CSSVariablesRule::CSSVariablesRule): (WebCore::CSSVariablesRule::cssText):
  • css/CSSVariablesRule.h: (WebCore::CSSVariablesRule::create):
  • css/maketokenizer:
  • css/tokenizer.flex:

LayoutTests:

2008-07-24 David Hyatt <​hyatt@apple.com>

Add support for an alternate proposed syntax for CSS variables. This alternate syntax will allow
testers on www-style to try out both versions of the syntax (to help make a decision regarding
which one should be used).

Reviewed by Dan

  • fast/css/variables/alternate-syntax: Added.
  • fast/css/variables/alternate-syntax/color-hex-test.html: Added.
  • fast/css/variables/alternate-syntax/colors-test.html: Added.
  • fast/css/variables/alternate-syntax/font-test.html: Added.
  • fast/css/variables/alternate-syntax/image-test.html: Added.
  • fast/css/variables/alternate-syntax/import-test.html: Added.
  • fast/css/variables/alternate-syntax/inline-style-test.html: Added.
  • fast/css/variables/alternate-syntax/invalid-variable-test.html: Added.
  • fast/css/variables/alternate-syntax/margin-test.html: Added.
  • fast/css/variables/alternate-syntax/misplaced-import-test.html: Added.
  • fast/css/variables/alternate-syntax/misplaced-variables-test.html: Added.
  • fast/css/variables/alternate-syntax/multiple-term-test.html: Added.
  • fast/css/variables/alternate-syntax/override-test.html: Added.
  • fast/css/variables/alternate-syntax/print-test.html: Added.
  • fast/css/variables/alternate-syntax/remove-variable-test.html: Added.
  • fast/css/variables/alternate-syntax/resources: Added.
  • fast/css/variables/alternate-syntax/resources/bad.css: Added.
  • fast/css/variables/alternate-syntax/resources/good.css: Added.
  • fast/css/variables/alternate-syntax/resources/listmark.gif: Added.
  • fast/css/variables/alternate-syntax/set-variable-test.html: Added.
  • fast/css/variables/alternate-syntax/shorthand-test.html: Added.
  • fast/css/variables/alternate-syntax/variable-iteration-test.html: Added.
11:30 AM Changeset in webkit [35350] by britto@apple.com
  • 2 edits in trunk/WebCore

2008-07-25 Maxime Britto <​britto@apple.com>

Reviewed by Anders Carlsson.

<rdar://6102387> "REGRESSION: horizontal scroll with the mouse wheel is inverted on some subframes"

  • page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent): Inverted the scroll direction relative to the delta value (positive scrolls left,negative scrolls right)
10:46 AM Changeset in webkit [35349] by Adam Roben
  • 2 edits in trunk/WebKit/win

Try to fix the Windows build bot

  • WebKit.vcproj/WebKit.sln: Linearize the project dependencies. Each project now depends only on the project that should immediately precede it in the build. For the frameworks, this order makes sense. For the applications built on top of the frameworks, the order is arbitrary (but roughly follows the applications' complexity).
10:11 AM Changeset in webkit [35348] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-07-25 Adele Peterson <​adele@apple.com>

Another build fix.

  • platform/win/PlatformScrollBarSafari.cpp: (WebCore::PlatformScrollbar::paint):
9:54 AM Changeset in webkit [35347] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-07-25 Adele Peterson <​adele@apple.com>

More build fixes.

  • platform/win/PlatformScrollBarSafari.cpp: (WebCore::PlatformScrollbar::paint):
9:30 AM Changeset in webkit [35346] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-07-25 Adele Peterson <​adele@apple.com>

Build fix.

  • platform/win/PlatformScrollBarSafari.cpp:
8:58 AM Changeset in webkit [35345] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Windows build fix

  • JavaScriptCore.vcproj/testapi/testapi.vcproj: Add API/ to the include path.
6:11 AM Changeset in webkit [35344] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-07-25 Simon Hausmann <Simon Hausmann>

Fix the build of jsc on Qt/Windows, make sure os-win32 is in the
include search path (added by WebKit.pri).

6:05 AM Changeset in webkit [35343] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-07-25 Joerg Bornemann <​joerg.bornemann@trolltech.com>

Reviewed by Simon.

Compile with QT_NO_PRINTER.

5:05 AM Changeset in webkit [35342] by ap@webkit.org
  • 4 edits
    13 moves
    1 add in trunk/JavaScriptCore

Reviewed by Simon Hausmann.

Move JavaScriptCore API tests into a subdirectory of their own to avoid header name
conflicts and developer confusion.

  • API/JSNode.c: Removed.
  • API/JSNode.h: Removed.
  • API/JSNodeList.c: Removed.
  • API/JSNodeList.h: Removed.
  • API/Node.c: Removed.
  • API/Node.h: Removed.
  • API/NodeList.c: Removed.
  • API/NodeList.h: Removed.
  • API/minidom.c: Removed.
  • API/minidom.html: Removed.
  • API/minidom.js: Removed.
  • API/testapi.c: Removed.
  • API/testapi.js: Removed.
  • API/tests: Added.
  • API/tests/JSNode.c: Copied from JavaScriptCore/API/JSNode.c.
  • API/tests/JSNode.h: Copied from JavaScriptCore/API/JSNode.h.
  • API/tests/JSNodeList.c: Copied from JavaScriptCore/API/JSNodeList.c.
  • API/tests/JSNodeList.h: Copied from JavaScriptCore/API/JSNodeList.h.
  • API/tests/Node.c: Copied from JavaScriptCore/API/Node.c.
  • API/tests/Node.h: Copied from JavaScriptCore/API/Node.h.
  • API/tests/NodeList.c: Copied from JavaScriptCore/API/NodeList.c.
  • API/tests/NodeList.h: Copied from JavaScriptCore/API/NodeList.h.
  • API/tests/minidom.c: Copied from JavaScriptCore/API/minidom.c.
  • API/tests/minidom.html: Copied from JavaScriptCore/API/minidom.html.
  • API/tests/minidom.js: Copied from JavaScriptCore/API/minidom.js.
  • API/tests/testapi.c: Copied from JavaScriptCore/API/testapi.c.
  • API/tests/testapi.js: Copied from JavaScriptCore/API/testapi.js.
  • GNUmakefile.am:
  • JavaScriptCore.vcproj/testapi/testapi.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
5:05 AM Changeset in webkit [35341] by vestbo@webkit.org
  • 3 edits in trunk/WebCore

2008-07-24 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon

Provide access to the underlying QKeyEvent in PlatformKeyboardEvent.

5:04 AM Changeset in webkit [35340] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-07-24 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon

Don't insert text on keyDown event in EditorClientQt.

4:43 AM Changeset in webkit [35339] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-07-25 Simon Hausmann <Simon Hausmann>

Fix linking of QtWebKit against the statically built JavaScriptCore
library, under Windows/Mac we may need _d/_debug suffixes.

4:02 AM Changeset in webkit [35338] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-07-25 Simon Hausmann <Simon Hausmann>

Prospective WX build fix, add JavaScriptCore/API to the include search
path.

3:56 AM Changeset in webkit [35337] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-07-25 Simon Hausmann <Simon Hausmann>

Rubber-stamped by Lars.

Fix the build on Windows. operator new for ArgList is implemented using fastMalloc()
but operator delete was not implemented. Unfortunately MSVC decides to call/reference
the function, so a simple implementation using fastFree() fixes the build.

3:55 AM Changeset in webkit [35336] by Simon Hausmann
  • 3 edits in trunk/WebCore

2008-07-25 Simon Hausmann <Simon Hausmann>

Rubber-stamped by Lars.

Fix the Qt build by adapting to the latest ArgList API changes and
replacing the inclusion of npapi.h in MainThreadScheduler with a forward
declaration of NPP to avoid an include conflict. npapi.h on X11 includes
X headers, which include wonderful defines such as "#define Status" that
cause conflicts.

3:55 AM Changeset in webkit [35335] by Simon Hausmann
  • 8 edits
    1 add in trunk

2008-07-25 Simon Hausmann <Simon Hausmann>

Discussed with and rubber-stamped by Lars.

Fix the build system for the Qt port.

Recent JavaScriptCore changes require the addition of JavaScriptCore/API to the
include search path. With a build process that combines JavaScriptCore and
WebCore in one build process/Makefile the existance of
JavaScriptCore/API/Node.h and WebCore/dom/Node.h causes include conflicts.

This commit solves this by introducing a separate build of JavaScriptCore into
a static library.

As a result of the split-up a race-condition due to broken dependencies of
regular source files to header files of generated sources showed up very
frequently when doing parallel builds (which the buildbot does). This commit at
the same time tries to address the dependency problem by making the
addExtraCompiler() function also generate a pseudo extra compiler that
represents the header file output, so that qmake is aware of the creation of
the header file for dependency calculation.

At the same time I removed a lot of cruft from the pro files to ease maintenance.

Note: See TracTimeline for information about the timeline view.