Timeline



Aug 1, 2008:

11:10 PM Changeset in webkit [35524] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • tweak a comment
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw):
10:48 PM ApplicationsGtk edited by alp@atoker.com
Updates (diff)
10:19 PM Changeset in webkit [35523] by jmalonzo@webkit.org
  • 1 edit in trunk/WebKit/gtk/ChangeLog

Forgot to add the reviewer of r35522.

  • WebKit/gtk/ChangeLog:
10:12 PM Changeset in webkit [35522] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-08-01 Wouter Bolsterlee <​uws@xs4all.nl>

​https://bugs.webkit.org/show_bug.cgi?id=20035
[GTK] Fix return value for webkit_web_view_go_to_back_forward_item()

  • webkit/webkitwebview.cpp:
10:11 PM Changeset in webkit [35521] by jmalonzo@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

2008-08-01 Jan Michael Alonzo <​jmalonzo@webkit.org>

  • ChangeLog: Fix date of previous commit (r35520)
10:01 PM Changeset in webkit [35520] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-06-17 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=19603
[SOUP] segfault when closing a file using gio

Call client->didFinishLoading() only after releasing all the gio
resources.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::closeCallback): (WebCore::readCallback):
5:29 PM Changeset in webkit [35519] by andersca@apple.com
  • 4 edits in trunk

../../../../../../WebCore:

2008-08-01 Anders Carlsson <​andersca@apple.com>

Reviewed by Jon.

<rdar://problem/6120206>
Crash when plug-in queries for NPPVpluginWantsAllNetworkStreams.


Pass in a pointer to a void* to make sure that plug-ins don't overwrite the stack.


  • plugins/PluginStream.cpp: (WebCore::PluginStream::wantsAllStreams):

../../../../../../WebKit/mac:

2008-08-01 Anders Carlsson <​andersca@apple.com>

Reviewed by Jon.

<rdar://problem/6120206>
Crash when plug-in queries for NPPVpluginWantsAllNetworkStreams.


Pass in a pointer to a void* to make sure that plug-ins don't overwrite the stack.

  • Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream wantsAllStreams]):
5:06 PM Changeset in webkit [35518] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Eric Seidel.

Native rendering implementations for form elements in the wx port.

​https://bugs.webkit.org/show_bug.cgi?id=19069

2:50 PM Changeset in webkit [35517] by Beth Dakin
  • 4 edits in trunk/WebKit/win

2008-08-01 Beth Dakin <Beth Dakin>

Reviewed by Adam Roben.

Fix for <rdar://problem/6119382> Need to hook up WebFrame's
disconnected frame API on Windows.

  • Interfaces/IWebFrame.idl:
  • WebFrame.cpp: (WebFrame::setIsDisconnected):
  • WebFrame.h:
2:32 PM Changeset in webkit [35516] by Adam Roben
  • 2 edits in trunk/WebKit/win

Fix <rdar://6118733> REGRESSION (r35502): Crash when submitting any form

Reviewed by Darin Adler.

  • COMPropertyBag.h: (COMPropertyBag::QueryInterface): Cast to an appropriate type before assigning into ppvObject.
1:24 PM Changeset in webkit [35515] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-07-30 David Hyatt <​hyatt@apple.com>

Improvements to selection drawing.

Clip out floating and positioned objects when drawing selection so
that there is no "double painting" of selection when the selection spans both the space behind the positioned/floating
object and the positioned/floating object itself. Improves most Web pages.

Do not paint left/right selection gaps if the object's edge is already outside the boundary (at a negative
position). Significantly improves the look of selections on digg.com, since it uses giant negative text-indent.

Reviewed by Dan

Covered by existing selection pixel tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isSelectionRoot): (WebCore::RenderBlock::paintSelection): (WebCore::clipOutPositionedObjects): (WebCore::RenderBlock::fillSelectionGaps): (WebCore::RenderBlock::fillLeftSelectionGap): (WebCore::RenderBlock::fillRightSelectionGap):
1:23 PM Changeset in webkit [35514] by timothy@apple.com
  • 4 edits in trunk/WebCore

Adds the ability to disable individual properties of a CSS rule.
When hovering over a rule, checkboxes show up to the right of all
properties and toggling a checkbox disables/enables the property.
Behind the scenes the property is removed from the rule when disabled,
but still remains in the list and in the computed style. When disabled
the property has a line through it, and is faded in computed style.

<rdar://problem/5712828> Support disabling individual CSS properties
​https://bugs.webkit.org/show_bug.cgi?id=14377

Reviewed by Adam Roben.

  • page/inspector/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): Include the inline style when it also has disabled properties. Call deleteDisabledProperty for any property that is in the style, since it might have been added back by the page. Remember all disabled properties so they show up in computed style. (deleteDisabledProperty): Helper function to delete all the right properties that track disabled properties. (WebInspector.StylePropertiesSection): Add the computed-style class when the section is Computed Style. (WebInspector.StylePropertiesSection.prototype.onpopulate): Include disabled properties. (WebInspector.StylePropertyTreeElement): Added a disabled argument. (WebInspector.StylePropertyTreeElement.prototype.get/set disabled): Sets the _disabled property and calls updateState. (WebInspector.StylePropertyTreeElement.prototype.get priority): Return the priority of enabled or disabled properties. (WebInspector.StylePropertyTreeElement.prototype.get value): Return the value of enabled or disabled properties. (WebInspector.StylePropertyTreeElement.prototype.updateTitle): Use the priority and value getter. Append the checkbox for root elements of an editable section. (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled): Add or remove properties from the rule and remember removed ones by adding three objects to the style: disabledProperties, disabledPropertyValues and disabledPropertyPriorities. The disabledProperties object will include all longhand properties of a shorthand for use by Computed Style. (WebInspector.StylePropertyTreeElement.prototype.updateState): Use the value getter. Update the disabled state.
  • page/inspector/inspector.css:
  • page/inspector/utilities.js: (Object.hasProperties): Added. Helper to test if an object has any properties.
12:23 PM Changeset in webkit [35513] by andersca@apple.com
  • 13 edits in trunk

../../../../../../WebCore:

2008-07-31 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin.

<rdar://problem/5949410>
Add the ability to transfer a given application cache to a new database.


  • WebCore.base.exp: Export ApplicationCacheStorage::storeCopyOfCache.


  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::~ApplicationCache): Don't call cacheDestroyed for our special "copy" groups.


  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): (WebCore::ApplicationCacheGroup::~ApplicationCacheGroup): Add a "copy" flag to the ApplicationCacheGroup constructor. A "copied" group is special and can only be stored to disk.


  • loader/appcache/ApplicationCacheGroup.h: (WebCore::ApplicationCacheGroup::isCopy): New getter.


  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::store): Make sure to set the storageID when storing an application resource.


(WebCore::ApplicationCacheStorage::storeNewestCache):
Change this to return true/false depending on whether storing the cache succeeded or not.


(WebCore::ApplicationCacheStorage::storeCopyOfCache):
New method which stores a given cache in a new storage (database file).


  • loader/appcache/ApplicationCacheStorage.h: Add new methods.

../../../../../../WebKit/mac:

2008-07-31 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin.

<rdar://problem/5949410>
Add the ability to transfer a given application cache to a new database.

  • Misc/WebKitNSStringExtras.h:
  • Misc/WebKitNSStringExtras.m: (+[NSString _webkit_applicationCacheDirectoryWithBundleIdentifier:]): New method which returns the appopriate cache directory for a given bundle identifier.


  • WebView/WebDataSource.mm: (-[WebDataSource _transferApplicationCache:]): Transfer the application cache.


  • WebView/WebDataSourcePrivate.h:
  • WebView/WebView.mm: (WebKitInitializeApplicationCachePathIfNecessary): Change this to use _webkit_applicationCacheDirectoryWithBundleIdentifier.
11:20 AM Changeset in webkit [35512] by Adam Roben
  • 2 edits in trunk/WebKitSite

Add a link to the instructions to use Apple's Safari for Windows symbol server

Reviewed by Eric Seidel.

  • building/debug.html:
1:38 AM Changeset in webkit [35511] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Rubber-stamped by Maciej.

Remove JSGlobalData::DataInstance. It was only needed when we had per-thread JSGlobalData
instances.

  • kjs/JSGlobalData.h:
1:06 AM Changeset in webkit [35510] by mrowe@apple.com
  • 4 edits in tags/Safari-6528.0.1

Versioning.

1:06 AM Changeset in webkit [35509] by mrowe@apple.com
  • 2 edits in tags/Safari-6528.0.1/WebKit/mac

Build fix.

12:53 AM Changeset in webkit [35508] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.0.1

New tag.

Jul 31, 2008:

8:10 PM Changeset in webkit [35507] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

7:52 PM Changeset in webkit [35506] by mrowe@apple.com
  • 4 edits in tags/Safari-6528

Versioning.

7:52 PM Changeset in webkit [35505] by mrowe@apple.com
  • 3 edits in tags/Safari-6528/WebKit/mac

Merge r35428 and r35430.

7:32 PM Changeset in webkit [35504] by mrowe@apple.com
  • 1 copy in tags/Safari-6528

New tag.

5:08 PM Changeset in webkit [35503] by ddkilzer@apple.com
  • 5 edits in trunk/LayoutTests

Updated test results for DumpRenderTree fix in r35497

  • svg/custom/image-with-prefix-in-webarchive-expected.webarchive: Contents of the main resource are now displayed instead of encoded data.
  • svg/webarchive/svg-cursor-subresources-expected.webarchive: Ditto.
  • svg/webarchive/svg-feimage-subresources-expected.webarchive: Ditto.
  • svg/webarchive/svg-script-subresouces-expected.webarchive: Ditto. Also updated MIME types for JavaScript source now that we don't mangle application/x-javascript into text/javascript.
4:16 PM Changeset in webkit [35502] by andersca@apple.com
  • 5 edits
    2 deletes in trunk/WebKit/win

2008-07-31 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam.

Get rid of FormValuesPropertyBag and use COMPropertyBag instead.


  • COMPropertyBag.h: Implement parts of IPropertyBag2. Currently just one method (CountProperties) is implemented.


  • WebCoreSupport/FormValuesPropertyBag.cpp: Removed.
  • WebCoreSupport/FormValuesPropertyBag.h: Removed.


  • WebFrame.cpp: (WebFrame::dispatchWillSubmitForm): Create a COMPropertyBag instead.


  • WebKit.vcproj/WebKit.vcproj:
3:18 PM Changeset in webkit [35501] by Adam Roben
  • 2 edits in trunk/WebKitTools

Follow-up to r35500

  • WinLauncher/WinLauncher.vcproj: Set the manifest properties for the Release configuration, too.
3:12 PM Changeset in webkit [35500] by Adam Roben
  • 2 edits in trunk/WebKitTools

2008-07-31 Stefan Landvogt <​stefan.landvogt@gmail.com>

Fix Bug 20245: WinLauncher does not start in WebKit-debug right out of
the box

<​https://bugs.webkit.org/show_bug.cgi?id=20245>

Reviewed by Adam Roben.

  • WinLauncher/WinLauncher.vcproj: adding the following properties to WinLauncher > Properties > Manifest Tool > Isolated COM Type Library File: $(WebKitOutputDir)\lib\WebKit.tlb Component File Name: WebKit$(WebKitDLLConfigSuffix) Doing the change on "All Configurations"
2:42 PM Changeset in webkit [35499] by sullivan@apple.com
  • 11 edits in trunk

WebCore:

2008-07-31 John Sullivan <​sullivan@apple.com>

WebCore part of <rdar://problem/6116650> Text-only zoom setting should be stored in WebKit prefs

Reviewed by Hyatt

  • WebCore.base.exp: export symbol for WebCoreSettings::setZoomsTextOnly()


  • page/Frame.cpp: (WebCore::Frame::isZoomFactorTextOnly): use value from Settings instead of data member (WebCore::Frame::shouldApplyTextZoom): call isZoomFactorTextOnly() to get value instead of accessing now-removed data member (WebCore::Frame::shouldApplyPageZoom): ditto (WebCore::Frame::setZoomFactor): set value into Settings rather than into data member (WebCore::FramePrivate::FramePrivate): don't set initial value of now-removed data member; this is managed by Settings now


  • page/FramePrivate.h: removed m_zoomFactorIsTextOnly


  • page/Settings.cpp: (WebCore::Settings::setZoomsTextOnly): new function, sets values and reapplies styles in all frames


  • page/Settings.h: (WebCore::Settings::zoomsTextOnly): new function, returns value of new data member

WebKit/mac:

2008-07-31 John Sullivan <​sullivan@apple.com>

WebKit part of <rdar://problem/6116650> Text-only zoom setting should be stored in WebKit prefs

Reviewed by Hyatt

  • WebView/WebPreferenceKeysPrivate.h: added WebKitZoomsTextOnlyPreferenceKey


  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): default value of YES for WebKitZoomsTextOnlyPreferenceKey (-[WebPreferences zoomsTextOnly]): getter for WebKitZoomsTextOnlyPreferenceKey (-[WebPreferences setZoomsTextOnly:]): setter for WebKitZoomsTextOnlyPreferenceKey


  • WebView/WebPreferencesPrivate.h: declare zoomsTextOnly/setZoomsTextOnly:


  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): update WebCore::Settings value for zoomsTextOnly
2:35 PM Changeset in webkit [35498] by Adam Roben
  • 2 edits in trunk/WebKitTools

Windows build bot fix

  • DumpRenderTree/win/ImageDiff.vcproj: Don't fail if files that only exist for people at Apple can't be found. Also updated the ICU version to 3.8.
2:21 PM Changeset in webkit [35497] by ddkilzer@apple.com
  • 10 edits
    1 add
    1 delete in trunk

Fix layout test results for webarchive/test-xml-stylesheet.xml

WebKit:

Fix layout test results for webarchive/test-xml-stylesheet.xml

Reviewed by Darin.

  • WebKit.xcodeproj/project.pbxproj: Added WebHTMLRepresentationInternal.h. Changed WebHTMLRepresentationInternal.h and WebHTMLRepresentationPrivate.h to private so they're copied into PrivateHeaders.

WebKit/mac:

Fix layout test results for webarchive/test-xml-stylesheet.xml

Reviewed by Darin.

Needed to expose -[WebHTMLRepresentation supportedNonImageMIMETypes]
for DumpRenderTree.

  • WebView/WebHTMLRepresentationInternal.h: Added.

WebKitTools:

Fix layout test results for webarchive/test-xml-stylesheet.xml

Reviewed by Darin.

  • DumpRenderTree/mac/DumpRenderTree.mm: (convertMIMEType): Work around the "text/xml" local file type regression in Leopard using the BUILDING_ON_LEOPARD macro. Also stop mangling "application/x-javascript" into "text/javascript". (convertWebResourceDataToString): When checking whether to dump a resource as text, also check to see if the MIME type is in the -[WebHTMLRepresentation supportedNonImageMIMETypes] array.
  • DumpRenderTree/mac/DumpRenderTreeMac.h: Added BUILDING_ON_LEOPARD macro.

LayoutTests:

Fix layout test results for webarchive/test-xml-stylesheet.xml

Reviewed by Darin.

  • platform/mac/webarchive/test-xml-stylesheet-expected.txt: Removed unused test results.
  • webarchive/test-duplicate-resources-expected.webarchive: Updated results now that we don't mangle application/x-javascript into text/javascript.
  • webarchive/test-script-src-expected.webarchive: Ditto.
  • webarchive/test-xml-stylesheet-expected.webarchive: Updated results now that we handle application/xml correctly.
2:10 PM Changeset in webkit [35496] by Simon Fraser
  • 2 edits in trunk/WebCore

2008-07-31 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Null-check parent clip rects, because they may not have been
set up yet.
​https://bugs.webkit.org/show_bug.cgi?id=20243

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects):
1:55 PM Changeset in webkit [35495] by andersca@apple.com
  • 2 copies in trunk/WebKit/win/WebCoreSupport

Did not mean to remove these files.

1:54 PM Changeset in webkit [35494] by andersca@apple.com
  • 2 edits
    2 deletes in trunk/WebKit/win

2008-07-31 Anders Carlsson <​andersca@apple.com>

Reviewed by Jon.


Tweak the names.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin):
1:48 PM Changeset in webkit [35493] by andersca@apple.com
  • 5 edits
    3 adds in trunk/WebKit/win

2008-07-31 Anders Carlsson <​andersca@apple.com>

Reviewed by Jon.

<rdar://problem/5826110>


Add a way for WebKit clients to embed custom content in web pages.


  • Interfaces/IWebEmbeddedView.idl: Added. New interface which an embedded view must implement.


  • Interfaces/IWebUIDelegatePrivate.idl: Add new UI delegate method for creating an embedded view.


  • Interfaces/WebKit.idl: Include IWebEmbeddedView.idl.


  • WebCoreSupport/EmbeddedWidget.cpp: Added.
  • WebCoreSupport/EmbeddedWidget.h: Added. Add EmbeddedWidget, a widget subclass which can hold an IWebEmbeddedView.


  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Check if the UI delegate wants to create an embedded view.


  • WebKit.vcproj/WebKit.vcproj: Add EmbeddedWidget.{cpp|h}
1:46 PM Changeset in webkit [35492] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6058958> REGRESSION (r34210): Seams are visible in border-image
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw): To work around a Core Graphics interpolation issue, reverted to using a temporary subimage for drawing a portion of the image with scaling and high-quality interpolation in effect.
1:44 PM Changeset in webkit [35491] by Chris Fleizach
  • 8 edits
    2 adds in trunk

<rdar://problem/3563671> VO doesn't highlight characters when interacting when static text in web areas

Add ability to get bounds for individual characters through accessibility

1:39 PM Changeset in webkit [35490] by ddkilzer@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Removed da BOM from the ChangeLog.

12:15 PM Changeset in webkit [35489] by ap@webkit.org
  • 2 edits in trunk/WebKit/mac

Release build fix.

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView setWindowIfNecessary]): Don't define to npErr in release builds, as it is only used for logging.
10:50 AM Changeset in webkit [35488] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

2008-07-31 John Sullivan <​sullivan@apple.com>

Fixed <​https://bugs.webkit.org/show_bug.cgi?id=5195>
drawing with cacheDisplayInRect:toBitmapImageRep: doesn't trigger layout on Leopard

Reviewed by Dan

  • WebView/WebHTMLView.mm: (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): include Leopard in the #ifdef that forces a layout if needed
10:33 AM Changeset in webkit [35487] by kevino@webkit.org
  • 7 edits in trunk

Second attempt at Windows/wx build fix. Instead of avoiding inclusion of windows.h, use defines, etc. to avoid conflicts in each affected file.

10:20 AM Changeset in webkit [35486] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-07-31 Erik Bunce <​elbunce@thehive.com>

Reviewed by Simon.

​https://bugs.webkit.org/show_bug.cgi?id=20224

Include the Writing Direction sub-menu in the context menu of all
platforms but GTK. This fixes a regression introduced by revision
34426.

10:14 AM Changeset in webkit [35485] by beidson@apple.com
  • 9 edits in trunk

WebCore:

2008-07-31 Brady Eidson <​beidson@apple.com>

Reviewed by Adam and Hyatt

Fix for <rdar://problem/6099748>

Adds a "don't enforce CSS mime type in strict mode" quirk for iWeb 2

  • WebCore.base.exp:
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::setCSSStyleSheet):
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::canUseSheet):
  • loader/CachedCSSStyleSheet.h: (WebCore::CachedCSSStyleSheet::sheetText):
  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setEnforceCSSMIMETypeInStrictMode):

  • page/Settings.h: (WebCore::Settings::enforceCSSMIMETypeInStrictMode):

WebKit/mac:

2008-07-30 Brady Eidson <​beidson@apple.com>

Reviewed by Adam and Hyatt

Fix for <rdar://problem/6099748>

  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Set the "don't enforce CSS mime type in strict mode" quirk when running under iWeb 2
9:56 AM Changeset in webkit [35484] by andersca@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-07-31 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam.

Fix Windows build.


  • kjs/collector.h:
  • wtf/FastMalloc.cpp:
8:11 AM Changeset in webkit [35483] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-07-31 Erik Bunce <​elbunce@thehive.com>

Reviewed by Simon.

Added the ability to get SQLite headers and source from the location·
specified via the SQLITE3SRCDIR environtment variable.

8:10 AM Changeset in webkit [35482] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

2008-07-31 Erik Bunce <​elbunce@thehive.com>

Reviewed by Simon.

Make run-launcher set DYLD_LIBRARY_PATH to make things work on Mac OS X.

8:03 AM Changeset in webkit [35481] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-07-31 Erik Bunce <​elbunce@thehive.com>

Reviewed by Simon.

Make sure edit actions get updated when the contents change.

8:00 AM Changeset in webkit [35480] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-07-31 Erik Bunce <​elbunce@thehive.com>

Reviewed by Simon.

Add simple edit test abilities to QtLauncher.

8:00 AM Changeset in webkit [35479] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-07-31 Csaba Osztrogonac <​oszi@inf.u-szeged.hu>

Reviewed by Simon.

Bug 20170: [Qt] missing namespace defines in JavaScriptCore.pro
<​https://bugs.webkit.org/show_bug.cgi?id=20170>

5:19 AM Changeset in webkit [35478] by ap@webkit.org
  • 102 edits
    5 deletes in trunk

Rubber-stamped by Maciej.

Eliminate JSLock (it was already disabled, removing the stub implementaion and all
call sites now).

2:58 AM Changeset in webkit [35477] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Rubber-stamped by Oliver Hunt.

Fix the Mac project to not display "test/" as part of file name for tests.

1:44 AM Changeset in webkit [35476] by eric@webkit.org
  • 10 edits in trunk/JavaScriptCore

Reviewed by Alexey Proskuryakov.

Rename USE(MULTIPLE_THREADS) to ENABLE(JSC_MULTIPLE_THREADS)
to better match the use/enable pattern (and better describe
the usage of the feature in question.)

I also fixed a couple other ENABLE_ macros to be pre-processor
definition override-able to match the rest of the ENABLE_ macros
since it seems to be our convention that build systems can set
ENABLE_ macros in Makefiles.

  • kjs/InitializeThreading.cpp: (KJS::initializeThreadingOnce):
  • kjs/JSGlobalData.cpp: (KJS::JSGlobalData::JSGlobalData): (KJS::JSGlobalData::~JSGlobalData):
  • kjs/MathObject.cpp:
  • kjs/collector.cpp: (KJS::Heap::Heap): (KJS::Heap::~Heap): (KJS::allocateBlock): (KJS::Heap::markStackObjectsConservatively):
  • kjs/collector.h:
  • kjs/dtoa.cpp: (KJS::pow5mult): (KJS::rv_alloc): (KJS::freedtoa): (KJS::dtoa):
  • wtf/FastMalloc.cpp:
  • wtf/Platform.h:
  • wtf/RefCountedLeakCounter.cpp:
12:37 AM Changeset in webkit [35475] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

Windows build fix.

Jul 30, 2008:

11:38 PM Changeset in webkit [35474] by eric@webkit.org
  • 4 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

Try to clean up our usage of USE(MULTIPLE_THREADS) vs. USE(PTHREADS) a little.
It looks like JSC assumes that if MULTIPLE_THREADS is defined, then pthreads will always be available
I'm not sure that's always the case for gtk, certainly not for Windows. We should eventually go back
and fix wtf/Threading.h to cover all these cases some day.

  • kjs/JSLock.cpp:
  • kjs/collector.h:
  • wtf/Platform.h:
11:14 PM Changeset in webkit [35473] by mrowe@apple.com
  • 2 edits in trunk/WebKit/win

Windows build fix.

9:04 PM Changeset in webkit [35472] by timothy@apple.com
  • 4 edits in trunk/WebCore

Fix various minor bugs with style editing in the Inspector.

  • Restores the scroll position to 0,0 when finished editing a string that was longer than the editing input area.
  • Adjusts the margin of the list item to ensure the text does not shift when entering and exiting editing mode.
  • Reliably remembers if a shorthand has children when the children haven't been populated yet.
  • Reliably remembers if a shorthand was expanded, and expands if needed after editing finishes.
  • Hides color swatches when editing.

​https://bugs.webkit.org/show_bug.cgi?id=20238

Reviewed by Adam Roben.

  • page/inspector/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.startEditing): Store the expanded state and children state in wasExpanded and reallyHasChildren properties. (WebInspector.StylePropertyTreeElement.prototype.editingEnded): Removed the wasExpanded argument and use the reallyHasChildren and wasExpanded properties to restore state. Deletes the state properties. (WebInspector.StylePropertyTreeElement.prototype.editingCancelled): Removed the wasExpanded argument. (WebInspector.StylePropertyTreeElement.prototype.editingCommitted): Removed the wasExpanded argument.
  • page/inspector/inspector.css: Tweak the margin and hides the color swatches. ALso removes a rule that was not needed.
  • page/inspector/inspector.js: (WebInspector.startEditing): Restore the scrollLeft and scrollTop to zero when editing finishes.
6:21 PM Changeset in webkit [35471] by andersca@apple.com
  • 3 edits
    2 deletes in trunk/WebKit/win

2008-07-30 Anders Carlsson <​andersca@apple.com>

Reviewed by Mitz.

Use a COMPropertyBag instead of the HTTPHeaderPropertyBag.


  • HTTPHeaderPropertyBag.cpp: Removed.
  • HTTPHeaderPropertyBag.h: Removed.
  • WebURLResponse.cpp: (WebURLResponse::allHeaderFields):
6:11 PM Changeset in webkit [35470] by andersca@apple.com
  • 3 edits in trunk/WebKit/win

2008-07-30 Anders Carlsson <​andersca@apple.com>

Fix copyright years.


  • COMPropertyBag.h:
  • COMVariantSetter.h:
5:33 PM Changeset in webkit [35469] by alice.liu@apple.com
  • 5 edits in trunk/WebCore

2008-07-30 Alice Liu <​alice.liu@apple.com>

Implement userIdleTime() for Windows, and place a band-aid over other
platform implementations of userIdleTime(). This will fix the issue
of indefinitely postposing releasing pages from the PageCache
on non-Mac platforms, causing us to hang onto just about everything
else about a web page.


Reviewed by Sam Weinig.

  • platform/gtk/TemporaryLinkStubs.cpp:
  • platform/wx/TemporaryLinkStubs.cpp:
  • platform/qt/TemporaryLinkStubs.cpp: (WebCore::userIdleTime): set to FLT_MAX
  • platform/win/SystemTimeWin.cpp: (WebCore::userIdleTime): implemented
5:19 PM Changeset in webkit [35468] by andersca@apple.com
  • 3 edits in trunk/WebKit/win

2008-07-30 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam.

More property bag work.


  • COMPropertyBag.h: (COMPropertyBag::COMPropertyBag): (::adopt): (::Read):
  • COMVariantSetter.h: (COMIUnknownVariantSetter::setVariant):
5:01 PM Changeset in webkit [35467] by Beth Dakin
  • 11 edits in trunk

WebCore:

2008-07-30 Beth Dakin <Beth Dakin>

Reviewed by Anders Carlsson.

Fixes <rdar://problem/6041390>

Adds the ability to have a frame that is "disconnected" from the
main frame from the perspective of top and parent in
Javascript.

  • WebCore.base.exp:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::parent): (WebCore::DOMWindow::top):
  • page/Frame.cpp: (WebCore::Frame::isDisconnectedFrame): (WebCore::Frame::setIsDisconnectedFrame): (WebCore::FramePrivate::FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameTree.cpp: (WebCore::FrameTree::parent): (WebCore::FrameTree::top):
  • page/FrameTree.h:

WebKit/mac:

2008-07-30 Beth Dakin <Beth Dakin>

Reviewed by Anders Carlsson.

Fixes <rdar://problem/6041390>

Adds the ability to have a frame that is "disconnected" from the
main frame from the perspective of top and parent in
Javascript.

  • WebView/WebFrame.mm: (-[WebFrame _setIsDisconnectedFrame]):
  • WebView/WebFramePrivate.h:
4:14 PM Changeset in webkit [35466] by eric@webkit.org
  • 5 edits in trunk/JavaScriptCore

Reviewed by Oliver.

MSVC warns when structs are called classes or vice versa.
Make all the source refer to JSGlobalData as a class.

  • kjs/CommonIdentifiers.h:
  • kjs/JSGlobalData.h:
  • kjs/Parser.h:
  • kjs/lexer.h:
4:13 PM Changeset in webkit [35465] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Justin.

Crash Safari when dragging images into Google presentations
​https://bugs.webkit.org/show_bug.cgi?id=20161

Test: manual-tests/remove-on-drop-crash.html

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • manual-tests/remove-on-drop-crash.html: Added.
3:59 PM Changeset in webkit [35464] by jess@apple.com
  • 2 edits in trunk/WebKitTools

2008-07-30 Jessica Kahn <​jess@apple.com>

Reviewed by Adam Roben.

Slightly stricter checking for previous change, suggested by Adam.


  • Scripts/extract-localizable-strings:
3:29 PM Changeset in webkit [35463] by andersca@apple.com
  • 3 edits
    2 adds in trunk/WebKit/win

2008-07-30 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam.

Add COMPropertyBag, a simple template class that implements the IPropertyBag interface. All
property bag values must be of the same type.


The COMVariantSetter helpers are now in COMVariantSetter.h


  • COMEnumVariant.h:
  • COMPropertyBag.h: Added.
  • COMVariantSetter.h: Added.
  • WebKit.vcproj/WebKit.vcproj:
3:22 PM Changeset in webkit [35462] by jess@apple.com
  • 2 edits in trunk/WebKitTools

2008-07-30 Jessica Kahn <​jess@apple.com>

Reviewed by Darin Adler.

Added support for UI_STRING and UI_STRING_KEY macros with flexible prefixes.


  • Scripts/extract-localizable-strings:
2:12 PM Changeset in webkit [35461] by christian@webkit.org
  • 2 edits in trunk/WebCore

Build fix for Cairo < 1.6

  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::boundingRect): use cairo_stroke_extends for < 1.6

Reviewed by Mark.

1:34 PM Changeset in webkit [35460] by alice.liu@apple.com
  • 52 edits in trunk/WebKit/win

2008-07-30 Alice Liu <​alice.liu@apple.com>

Reviewed by Adam Roben.

Adding logging of COM class names and counts to facilitate
investigating memory issues.

  • Interfaces/IWebKitStatistics.idl:
  • WebKitDLL.cpp:
  • WebKitDLL.h:
  • WebKitStatistics.cpp: (WebKitStatistics::comClassNameCounts):
  • WebKitStatistics.h:
1:17 PM Changeset in webkit [35459] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-07-29 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Geoff.

<rdar://problem/6110314> Crash in profiler dereferencing null frame or
page (20214)

  • Null check.
  • page/Console.cpp: (WebCore::Console::finishedProfiling):
1:16 PM Changeset in webkit [35458] by ap@webkit.org
  • 3 edits in trunk/JavaScriptCore

Reviewed by Geoff Garen.

Add consistency checks to UString to document and enforce its design.

  • kjs/ustring.cpp: (KJS::UString::Rep::create): (KJS::UString::Rep::destroy): (KJS::UString::Rep::checkConsistency): (KJS::UString::expandCapacity): (KJS::UString::expandPreCapacity): (KJS::UString::UString): (KJS::UString::spliceSubstringsWithSeparators): (KJS::UString::append):
  • kjs/ustring.h: (KJS::UString::Rep::checkConsistency):
1:02 PM Changeset in webkit [35457] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-07-30 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=18070


Full page zoom needs to work properly with JS mouse events. Make sure to adjust the coordinates of the
JS mouse event to account for zoom.

Reviewed by olliej

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent):
12:00 PM Changeset in webkit [35456] by weinig@apple.com
  • 17 edits
    4 moves
    10 deletes in trunk

WebCore:

2008-07-29 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Update Cross-site XMLHttpRequests using Access control to
the latest spec. (Editor's Draft 8 July 2008)

  • This leaves us at about the same place as we previously were still needing preflight caching and better redirect support.
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • xml/AccessControlList.cpp: Removed.
  • xml/AccessControlList.h: Removed.
  • xml/AccessItem.cpp: Removed.
  • xml/AccessItem.h: Removed.
  • xml/AccessItemRule.cpp: Removed.
  • xml/AccessItemRule.h: Removed.
  • xml/XMLHttpRequest.cpp: (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::isSimpleCrossSiteAccessRequest): (WebCore::XMLHttpRequest::makeCrossSiteAccessRequest): (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest): (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight): (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult): (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::clearRequest): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::didFinishLoadingPreflight): (WebCore::XMLHttpRequest::accessControlCheck): (WebCore::XMLHttpRequest::didReceiveResponse): (WebCore::parseAccessControlAllowList): (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
  • xml/XMLHttpRequest.h:

LayoutTests:

2008-07-29 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Update Cross-site XMLHttpRequests using Access control to
the latest spec. (Editor's Draft 8 July 2008)

  • Update syntax in tests a remove tests for removed features.
  • http/tests/xmlhttprequest/access-control-basic-allow-async.html:
  • http/tests/xmlhttprequest/access-control-basic-blacklist-request-headers-expected.txt: Removed.
  • http/tests/xmlhttprequest/access-control-basic-blacklist-request-headers.html: Removed.
  • http/tests/xmlhttprequest/access-control-basic-exclude.html: Removed.
  • http/tests/xmlhttprequest/access-control-basic-non-simple-allow-async-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-not-get-allow-async-expected.txt.
  • http/tests/xmlhttprequest/access-control-basic-non-simple-allow-async.html: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-not-get-allow-async.html.
  • http/tests/xmlhttprequest/access-control-basic-non-simple-allow-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-not-get-allow-expected.txt.
  • http/tests/xmlhttprequest/access-control-basic-non-simple-allow.html: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-not-get-allow.html.
  • http/tests/xmlhttprequest/access-control-basic-not-get-allow-async-expected.txt: Removed.
  • http/tests/xmlhttprequest/access-control-basic-not-get-allow-async.html: Removed.
  • http/tests/xmlhttprequest/access-control-basic-not-get-allow-expected.txt: Removed.
  • http/tests/xmlhttprequest/access-control-basic-not-get-allow.html: Removed.
  • http/tests/xmlhttprequest/resources/access-control-basic-allow-access-control-origin-header.cgi:
  • http/tests/xmlhttprequest/resources/access-control-basic-allow-print-headers.cgi:
  • http/tests/xmlhttprequest/resources/access-control-basic-allow-star.cgi:
  • http/tests/xmlhttprequest/resources/access-control-basic-allow.cgi:
  • http/tests/xmlhttprequest/resources/access-control-basic-exclude.cgi: Removed.
  • http/tests/xmlhttprequest/resources/access-control-basic-get-fail-non-simple.cgi:
  • http/tests/xmlhttprequest/resources/access-control-basic-non-get-allow.cgi:
  • http/tests/xmlhttprequest/resources/access-control-basic-whitelist-response-headers.cgi:
11:17 AM Changeset in webkit [35455] by christian@webkit.org
  • 5 edits in trunk

[GTK] Auto generate webkitmarshal.list

Auto generate webkitmarshal.list from source files to reduce the
number of conflicts when merging git branches or when applying
patches.
Also rename webkit-marshal.* to webkitmarshal.* for consistency.

Reviewed by Holger.

10:38 AM Changeset in webkit [35454] by barraclough@apple.com
  • 14 edits
    2 copies in trunk/JavaScriptCore

2008-07-30 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Geoff Garen.

Fixes for Windows and non-AllInOne file build with SamplingTool, plus review fixes.

  • GNUmakefile.am: Adding SamplingTool.cpp to build.
  • JavaScriptCore.exp: Export hooks to init & control SamplingTool.
  • JavaScriptCore.pri: Adding SamplingTool.cpp to build.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Adding SamplingTool.cpp to build.
  • JavaScriptCore.xcodeproj/project.pbxproj: Adding SamplingTool.cpp to build.
  • JavaScriptCoreSources.bkl: Adding SamplingTool.cpp to build.
  • VM/Machine.cpp: MACHINE_SAMPLING_callingNativeFunction renamed MACHINE_SAMPLING_callingHostFunction
  • VM/Machine.h:
  • VM/Opcode.cpp: SamplingTool moved to SamplingTool.cpp/.h, opcodeNames generated from FOR_EACH_OPCODE_ID.
  • VM/Opcode.h:
  • VM/SamplingTool.cpp: Added .cpp/.h for SamplingTool.
  • VM/SamplingTool.h:
  • kjs/Shell.cpp: Switched SAMPLING_TOOL_ENABLED to ENABLE_SAMPLING_TOOL.
  • wtf/Platform.h: Added ENABLE_SAMPLING_TOOL config option.
  • kjs/nodes.cpp: Header include to fix non-AllInOne builds.
10:09 AM Changeset in webkit [35453] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

2008-07-30 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam.

Copy icu38* files instead of icu36* files.


  • DumpRenderTree/win/DumpRenderTree.vcproj:
9:58 AM Changeset in webkit [35452] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-07-30 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Alexey Proskuryakov.

Fix compilation without multi-threading support.

  • kjs/collector.cpp: (KJS::Heap::Heap):
9:37 AM Changeset in webkit [35451] by andersca@apple.com
  • 1 edit
    1 add in trunk/JavaScriptCore

2008-07-30 Anders Carlsson <​andersca@apple.com>

Add WebKitAvailability.h forwarding header.


  • ForwardingHeaders/JavaScriptCore/WebKitAvailability.h: Added.
9:24 AM Changeset in webkit [35450] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-30 Anders Carlsson <​andersca@apple.com>

Fix the else.


  • API/WebKitAvailability.h:
9:22 AM Changeset in webkit [35449] by andersca@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-07-30 Anders Carlsson <​andersca@apple.com>

  • API/WebKitAvailability.h: Fix Windows (and other non-Mac builds).


  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add WebKitAvailability.h to the project.
9:17 AM Changeset in webkit [35448] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-30 Anders Carlsson <​andersca@apple.com>

One step closer towards fixing the Windows build.


  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Make sure to copy WebKitAvailability.h
8:24 AM Changeset in webkit [35447] by christian@webkit.org
  • 2 edits in trunk/WebKit/gtk

Typo in comment for bracer ending block

​https://bugs.webkit.org/show_bug.cgi?id=20205

  • webkit/webkitprivate.cpp: Typo fix in comment for the brace

that ends the WebKit namespace; WebCore -> WebKit

Reviewed by Sam.

7:42 AM Changeset in webkit [35446] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-29 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Geoff Garen.

Bug 20209: Atomize constant strings
<​https://bugs.webkit.org/show_bug.cgi?id=20209>

Prevents significant performance degradation seen when a script contains multiple
identical strings that are used as keys to identify properties on objects.

No performance change on SunSpider.

  • kjs/nodes.cpp: Atomize constant strings.
1:00 AM Changeset in webkit [35445] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

<rdar://problem/6111648> JavaScript exceptions fail if the scope chain includes the global object

Reviewed by Alexey Proskuryakov.

In an attempt to remove the branch I just added to KJS::depth I
used the existence of a Variable Object at a point in the scope
chain as an indicator of function or global scope activation.
However this assumption results in incorrect behaviour if the
global object is injected into the scope chain with 'with'.

12:09 AM Changeset in webkit [35444] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff Garen.

Don't call JSGarbageCollect() on a released context.

  • API/testapi.c: (main):

Jul 29, 2008:

11:14 PM Changeset in webkit [35443] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-07-29 Kevin Calhoun <​kcalhoun@apple.com>

Reviewed by Adele.

Fix for <rdar://problem/6060647> Adopt QTMovieOpenForPlaybackAttribute flag

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie):
11:05 PM Changeset in webkit [35442] by ap@webkit.org
  • 15 edits in trunk

Reviewed by Geoff Garen.

Implement JSContextGroup APIs to make concurrent execution possible for
JavaScriptCore clients.

This changes the behavior of JSGlobalContextCreate(), so that it now uses a private context
group for each context, making JSlock implicit locking unnecessary.

  • API/JSContextRef.h:
  • API/JSContextRef.cpp: (JSContextGroupCreate): (JSContextGroupRetain): (JSContextGroupRelease): (JSGlobalContextCreate): (JSGlobalContextCreateInGroup): (JSGlobalContextRelease): (JSContextGetGroup): Added new methods. JSGlobalContextCreate() calls JSGlobalContextCreateInGroup() now.
  • API/APICast.h: (toJS): (toRef): Added converters for JSContextGroupRef.
  • API/JSBase.cpp: (JSGarbageCollect): JSGarbageCollect(0) is now a no-op, and the passed in context is actually used.
  • API/JSBase.h: Aded a typedef for JSContextGroupRef. Updated documentation for JSGarbageCollect().
  • kjs/JSGlobalData.cpp:
  • kjs/JSGlobalData.h: Removed support for JSGlobalData shared instance. JSGlobalData::isSharedInstance member variable still remains, to be deleted in a followup patch.
  • kjs/JSLock.cpp: (KJS::JSLock::JSLock): Disabled JSLock, to be deleted in a follow-up patch.


  • kjs/collector.cpp: (KJS::Heap::markOtherThreadConservatively): Removed an assertion that referenced JSGlobalData::sharedInstance.
  • kjs/collector.h: Made Heap destructor public, so that JSContextRelease can use it.

JavaScriptGlue:

  • JSRun.cpp: (JSRun::JSRun):
  • JSUtils.cpp: (getThreadGlobalExecState): Changed JavaScriptGlue to use a JSGlobalData of its own, now that there is no shared instance.
11:02 PM Changeset in webkit [35441] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-07-29 Kevin Calhoun <​kcalhoun@apple.com>

Reviewed by Adele.

Fix for <rdar://problem/6031021> Make standalone video render more like the quicktime plugin to improve performance

For standalone video, use QTMovieView to draw.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieView): Moved nil checks to setUpVideoRendering. Associate the QTMovieView with the WebCoreMovieObserver. If we're in a media document, allow QTMovieView to render in its default mode; otherwise tell it to draw synchronously. (WebCore::MediaPlayerPrivate::detachQTMovieView): Set the WebCoreMovieObserver's view to nil. (WebCore::MediaPlayerPrivate::createQTVideoRenderer): Nil check is now in setUpVideoRendering, which is the only caller of this. (WebCore::MediaPlayerPrivate::setUpVideoRendering): Added nil checks. Call createQTMovieView for media documents. (WebCore::MediaPlayerPrivate::tearDownVideoRendering): Call detachQTMovieView if a QTMovieView exists. (WebCore::MediaPlayerPrivate::setRect): Call setFrame on the QTMovieView if necessary. (-[WebCoreMovieObserver menuForEventDelegate:]): Added. Returns the frame view's menu. (-[WebCoreMovieObserver setView:]): Added.
10:55 PM Changeset in webkit [35440] by ap@webkit.org
  • 3 edits in trunk/JavaScriptCore

Reviewed by Geoff Garen.

Fix a leak of ThreadRegistrar objects.

As the heap is usually deleted when registered threads still exist, ThreadSpecific doesn't
have a chance to clean up per-thread object. Switched to native pthread calls, storing a
plain pointer that doesn't require cleanup.

  • kjs/collector.cpp: (KJS::PlatformThread::PlatformThread): (KJS::Heap::Thread::Thread): (KJS::Heap::Heap): (KJS::Heap::~Heap): (KJS::Heap::registerThread): (KJS::Heap::unregisterThread):
  • kjs/collector.h:
10:52 PM Changeset in webkit [35439] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=20169
Memory allocated with fastMalloc is freed with delete

  • VM/JSPropertyNameIterator.cpp: (KJS::JSPropertyNameIterator::invalidate): Free the array properly. (KJS::JSPropertyNameIterator::~JSPropertyNameIterator): Delete the array by calling invalidate().
10:42 PM Changeset in webkit [35438] by adele@apple.com
  • 7 edits in trunk/WebCore

2008-07-29 Adele Peterson <​adele@apple.com>

Reviewed by Dan Bernstein.

Fix for <rdar://problem/6073372> Move built-in controls below <video> element for standalone media documents

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Added -webkit-full-page-media pseudo class.
  • css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoFullPageMedia.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added case to apply PseudoFullPageMedia for elements in a full page media document.
  • css/html4.css: Added rule to shift control panel down for video in standalone media documents.
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::lowestPosition): Added implementation that takes the controls into account. This makes sure that scrollbars on the page will account for controls not directly contained in the RenderMedia. (WebCore::RenderMedia::rightmostPosition): ditto. (WebCore::RenderMedia::leftmostPosition): ditto.
  • rendering/RenderMedia.h:
10:34 PM Changeset in webkit [35437] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

Reviewed by Sam Weinig.

Add tooltip support to the wx port.

​https://bugs.webkit.org/show_bug.cgi?id=20173

10:00 PM Changeset in webkit [35436] by alice.liu@apple.com
  • 4 edits in trunk/WebKit/win

2008-07-29 Alice Liu <​alice.liu@apple.com>

Reviewed by Geoff Garen.

Fix WebDocumentLoader leak on Windows.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createDocumentLoader):
  • WebDocumentLoader.cpp: (WebDocumentLoader::create):
  • WebDocumentLoader.h:
7:39 PM Changeset in webkit [35435] by weinig@apple.com
  • 29 edits
    12 adds in trunk

WebCore:

2008-07-29 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

<rdar://problem/6084585> Investigate upload progress events.

  • Add progress notifications for data being sent via a ResourceHandle.
  • Add XMLHttpRequestUpload support.

Upload notifications only work on the Mac right now as the CFNetwork API
on windows does not expose enough information.

Tests: http/tests/xmlhttprequest/upload-onload-event.html

http/tests/xmlhttprequest/upload-onloadstart-event.html
http/tests/xmlhttprequest/upload-onprogress-event.html
http/tests/xmlhttprequest/upload-progress-events.html

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSEventTargetBase.cpp: (WebCore::toJS):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::mark):
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: Added. (WebCore::JSXMLHttpRequestUpload::mark): (WebCore::JSXMLHttpRequestUpload::onabort): (WebCore::JSXMLHttpRequestUpload::setOnabort): (WebCore::JSXMLHttpRequestUpload::onerror): (WebCore::JSXMLHttpRequestUpload::setOnerror): (WebCore::JSXMLHttpRequestUpload::onload): (WebCore::JSXMLHttpRequestUpload::setOnload): (WebCore::JSXMLHttpRequestUpload::onloadstart): (WebCore::JSXMLHttpRequestUpload::setOnloadstart): (WebCore::JSXMLHttpRequestUpload::onprogress): (WebCore::JSXMLHttpRequestUpload::setOnprogress): (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener): (WebCore::JSXMLHttpRequestUpload::dispatchEvent):
  • dom/EventTarget.cpp: (WebCore::EventTarget::toXMLHttpRequestUpload):
  • dom/EventTarget.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didSendData):
  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didSendData):
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didSendData):
  • page/DOMWindow.idl:
  • platform/network/FormData.cpp: (WebCore::FormData::FormData):
  • platform/network/FormData.h: (WebCore::FormData::alwaysStream): (WebCore::FormData::setAlwaysStream):
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didSendData):
  • platform/network/mac/FormDataStreamMac.h:
  • platform/network/mac/FormDataStreamMac.mm: (WebCore::getStreamFormDataMap): (WebCore::getStreamResourceHandleMap): (WebCore::associateStreamWithResourceHandle): (WebCore::disassociateStreamWithResourceHandle): (WebCore::DidSendDataCallbackData::DidSendDataCallbackData): (WebCore::performDidSendDataCallback): (WebCore::formCreate): (WebCore::formFinalize): (WebCore::formRead): (WebCore::setHTTPBody): (WebCore::httpBodyFromStream):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::~XMLHttpRequest): (WebCore::XMLHttpRequest::upload): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::createRequest): (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::networkError): (WebCore::XMLHttpRequest::abortError): (WebCore::XMLHttpRequest::didSendData):
  • xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::optionalUpload):
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestUpload.cpp: Added. (WebCore::XMLHttpRequestUpload::XMLHttpRequestUpload): (WebCore::XMLHttpRequestUpload::addEventListener): (WebCore::XMLHttpRequestUpload::removeEventListener): (WebCore::XMLHttpRequestUpload::dispatchEvent): (WebCore::XMLHttpRequestUpload::dispatchXMLHttpRequestProgressEvent): (WebCore::XMLHttpRequestUpload::dispatchAbortEvent): (WebCore::XMLHttpRequestUpload::dispatchErrorEvent): (WebCore::XMLHttpRequestUpload::dispatchLoadEvent): (WebCore::XMLHttpRequestUpload::dispatchLoadStartEvent): (WebCore::XMLHttpRequestUpload::dispatchProgressEvent):
  • xml/XMLHttpRequestUpload.h: Added. (WebCore::XMLHttpRequestUpload::create): (WebCore::XMLHttpRequestUpload::toXMLHttpRequestUpload): (WebCore::XMLHttpRequestUpload::associatedXMLHttpRequest): (WebCore::XMLHttpRequestUpload::disconnectXMLHttpRequest): (WebCore::XMLHttpRequestUpload::setOnAbortListener): (WebCore::XMLHttpRequestUpload::onAbortListener): (WebCore::XMLHttpRequestUpload::setOnErrorListener): (WebCore::XMLHttpRequestUpload::onErrorListener): (WebCore::XMLHttpRequestUpload::setOnLoadListener): (WebCore::XMLHttpRequestUpload::onLoadListener): (WebCore::XMLHttpRequestUpload::setOnLoadStartListener): (WebCore::XMLHttpRequestUpload::onLoadStartListener): (WebCore::XMLHttpRequestUpload::setOnProgressListener): (WebCore::XMLHttpRequestUpload::onProgressListener): (WebCore::XMLHttpRequestUpload::eventListeners): (WebCore::XMLHttpRequestUpload::refEventTarget): (WebCore::XMLHttpRequestUpload::derefEventTarget):
  • xml/XMLHttpRequestUpload.idl: Added.

LayoutTests:

2008-07-29 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

<rdar://problem/6084585> Investigate upload progress events

  • fast/dom/Window/window-properties-expected.txt:
  • http/tests/xmlhttprequest/upload-onload-event-expected.txt: Added.
  • http/tests/xmlhttprequest/upload-onload-event.html: Added.
  • http/tests/xmlhttprequest/upload-onloadstart-event-expected.txt: Added.
  • http/tests/xmlhttprequest/upload-onloadstart-event.html: Added.
  • http/tests/xmlhttprequest/upload-onprogress-event-expected.txt: Added.
  • http/tests/xmlhttprequest/upload-onprogress-event.html: Added.
  • http/tests/xmlhttprequest/upload-progress-events-expected.txt: Added.
  • http/tests/xmlhttprequest/upload-progress-events.html: Added.
  • platform/win/Skipped: Skip new tests on windows where the feature is not implemented yet.
4:33 PM Changeset in webkit [35434] by britto@apple.com
  • 2 edits in trunk/WebCore

2008-07-29 Maxime Britto <​britto@apple.com>

Reviewed by Darin.

<rdar://problem/6095023> "When pan-scrolling, mouse click on hyperlink stop the pan-Scroll but follow the link after that."
With this patch we now stop the pan scroll and swallow the event to prevent any following action.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): If we were in pan scrolling mode we no longer just stop the pan scroll and continue with the function, we now stop and return true to attest that we swallowed the event.
3:59 PM Changeset in webkit [35433] by britto@apple.com
  • 3 edits
    2 adds in trunk

2008-07-29 Maxime Britto <​britto@apple.com>

Reviewed by adele.

Test: fast/events/autoscroll-in-textfield.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled): reverted a bad change introduced in r35244 nb:the test case introduced in r35244 is still working.

2008-07-29 Maxime Britto <​britto@apple.com>

Reviewed by adele.
This test verifies that the autoscroll works within textfields.

  • fast/events/autoscroll-in-textfield-expected.txt: Added.
  • fast/events/autoscroll-in-textfield.html: Added.
3:47 PM Changeset in webkit [35432] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Attempt to fix the Qt build.

  • wtf/ThreadingQt.cpp: Add the extra argument to createThread.
3:38 PM Changeset in webkit [35431] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Mark Rowe.

  • update results for console.group and console.groupEnd
  • fast/dom/Window/window-properties-expected.txt:
1:58 PM Changeset in webkit [35430] by mrowe@apple.com
  • 3 edits in trunk/WebKit/mac

Tweak to the build fix to keep Dan happy.

1:28 PM Changeset in webkit [35429] by adele@apple.com
  • 6 edits
    2 adds in trunk

WebCore:

2008-07-29 Adele Peterson <​adele@apple.com>

Reviewed by Sammy Weinig.

Fix for <rdar://problem/6103024>
When a QT movie is loaded directly in the browser, I can't pause it by single-clicking on the video

Test: media/video-click-dlbclick-standalone.html

  • loader/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler): For standalone media documents, match the default Quicktime plugin behavior to allow clicking and double-clicking to pause and play the media.
  • loader/MediaDocument.h: Added defaultEventHandler.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::defaultEventHandler): Return early if the event has been handled.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlMuteButtonElement::defaultEventHandler): Correct what was probably a typo. Instead of "event->defaultHandled()", it is supposed to be "event->setDefaultHandled()". (WebCore::MediaControlPlayButtonElement::defaultEventHandler): ditto. (WebCore::MediaControlSeekButtonElement::defaultEventHandler): ditto. (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): ditto.

LayoutTests:

2008-07-29 Adele Peterson <​adele@apple.com>

Reviewed by Sammy Weinig.

Test for <rdar://problem/6103024>
When a QT movie is loaded directly in the browser, I can't pause it by single-clicking on the video

  • media/video-click-dlbclick-standalone-expected.txt: Added.
  • media/video-click-dlbclick-standalone.html: Added.
1:13 PM Changeset in webkit [35428] by mrowe@apple.com
  • 3 edits in trunk/WebKit/mac

Build fix.

11:55 AM Changeset in webkit [35427] by mitz@apple.com
  • 7 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6059648> Some content not visible when the window is short at courtneyalbright.com

Test: fast/overflow/float-in-relpositioned.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::lowestPosition): Add this block's relative offset to floats' and positioned objects' lowest position. (WebCore::RenderBlock::rightmostPosition): Ditto. (WebCore::RenderBlock::leftmostPosition): Ditto.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::lowestPosition): Removed redundant test. (WebCore::RenderBox::rightmostPosition): Ditto. (WebCore::RenderBox::leftmostPosition): Ditto.

LayoutTests:

Reviewed by Dave Hyatt.

  • test, updated test and results for <rdar://problem/6059648> Some content not visible when the window is short at courtneyalbright.com
  • fast/overflow/float-in-relpositioned.html: Added.
  • fast/repaint/containing-block-position-change.html: Changed to avoid a full repaint due to a scroll bar appearing.
  • platform/mac/fast/clip/015-expected.txt:
  • platform/mac/fast/overflow/float-in-relpositioned-expected.checksum: Added.
  • platform/mac/fast/overflow/float-in-relpositioned-expected.png: Added.
  • platform/mac/fast/overflow/float-in-relpositioned-expected.txt: Added.
  • platform/mac/fast/repaint/clipped-relative-expected.txt:
11:51 AM Changeset in webkit [35426] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6048566> Repaint original element's position, not its offset position

Test: fast/repaint/layout-state-relative.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::absolutePosition): Changed the LayoutState-enabled code path to account for the object's relative offset. (WebCore::RenderBox::computeAbsoluteRepaintRect): Ditto.

LayoutTests:

Reviewed by Dave Hyatt.

  • repaint test for <rdar://problem/6048566> Repaint original element's position, not its offset position
  • fast/repaint/layout-state-relative.html: Added.
  • platform/mac/fast/repaint/layout-state-relative-expected.checksum: Added.
  • platform/mac/fast/repaint/layout-state-relative-expected.png: Added.
  • platform/mac/fast/repaint/layout-state-relative-expected.txt: Added.
11:51 AM Changeset in webkit [35425] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Change Vector::find to return an index instead of an iterator

Indices are more natural than iterators when working with Vector.

Reviewed by John Sullivan.

  • wtf/Vector.h: (WTF::Vector::find): Changed to iterate the Vector manually and return the index of the found item, rather than an iterator. When the item could not be found, we return WTF::notFound.
11:28 AM Changeset in webkit [35424] by hyatt@apple.com
  • 3 adds in trunk/LayoutTests/platform/mac/fast/css/variables/alternate-syntax
11:27 AM Changeset in webkit [35423] by hyatt@apple.com
  • 1 edit
    5 adds in trunk/LayoutTests

2008-07-29 David Hyatt <​hyatt@apple.com>

Add a layout test for using multiple variable declaration blocks in a single style rule.

  • fast/css/variables/alternate-syntax/multiple-blocks-test.html: Added.
  • fast/css/variables/multiple-blocks-test.html: Added.
  • platform/mac/fast/css/variables/multiple-blocks-test-expected.checksum: Added.
  • platform/mac/fast/css/variables/multiple-blocks-test-expected.png: Added.
  • platform/mac/fast/css/variables/multiple-blocks-test-expected.txt: Added.
11:10 AM Changeset in webkit [35422] by Adam Roben
  • 3 edits in trunk/WebKit/win

Export detachThread

Reviewed by Geoff Garen.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def:
11:04 AM Changeset in webkit [35421] by timothy@apple.com
  • 10 edits in trunk/WebCore

Fixed Bug 19158: Inspector should support console.group/console.groupEnd

<​https://bugs.webkit.org/show_bug.cgi?id=19158>

Reviewed by Tim Hatcher and Adam Roben.

  • bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::group): Added.
  • page/Console.cpp: (WebCore::Console::group): Added. (WebCore::Console::groupEnd): Added.
  • page/Console.h: (WebCore::):
  • page/Console.idl: Added group/groupEnd.
  • page/InspectorController.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::InspectorController::InspectorController): Added m_groupLevel. (WebCore::InspectorController::addMessageToConsole): Added groupLevel argument. (WebCore::InspectorController::startGroup): Increments m_groupLevel by one and calls js function if needed. (WebCore::InspectorController::endGroup): Decrements m_groupLevel by one and calls js function if needed. (WebCore::InspectorController::addScriptConsoleMessage): Added groupLevel argument. (WebCore::InspectorController::didCommitLoad): Resets m_groupLevel.
  • page/InspectorController.h:
  • page/inspector/Console.js: (WebInspector.Console): Added groupLevel and currentGroup topGroup. (WebInspector.Console.addMessage): Calls addMessage method in the currentGroup. (WebInspector.Console.startGroup): Added. (WebInspector.Console.endGroup): Added. (WebInspector.Console.clearMessages): Resets groupLevel and currentGroup. (WebInspector.ConsoleMessage): Added groupLevel property. (WebInspector.ConsoleMessage.MessageLevel.GroupTitle): Added. (WebInspector.ConsoleGroup): Added. (WebInspector.ConsoleGroup.addMessage): Adds console message to group. (WebInspector.ConsoleGroup._titleClicked): Adds "collapsed" style class.
  • page/inspector/inspector.css:
  • page/inspector/inspector.js: (WebInspector.startGroupInConsole): Calls console.startGroup (WebInspector.endGroupInConsole): Calls console.endGroup
9:23 AM Changeset in webkit [35420] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Windows build fix

  • wtf/ThreadingWin.cpp: (WTF::setThreadName): Move a misplaced assertion to here... (WTF::createThread): ...from here.
9:11 AM Changeset in webkit [35419] by Adam Roben
  • 15 edits in trunk

Add support for setting thread names on Windows

JavaScriptCore:

Add support for setting thread names on Windows

These thread names make it much easier to identify particular threads
in Visual Studio's Threads panel.

WTF::createThread now takes a const char* representing the thread's
name. On Windows, we throw a special exception to set this string as
the thread's name. Other platforms do nothing with this name for now.

Reviewed by Anders Carlsson.

  • JavaScriptCore.exp: Export the new version of createThread that takes 3 arguments (the old one continues to be exported for backward compatibility).
  • wtf/Threading.h: Add a threadName argument to createThread.
  • wtf/ThreadingGtk.cpp: (WTF::createThread):
  • wtf/ThreadingNone.cpp: (WTF::createThread): Updated for function signature change.
  • wtf/ThreadingPthreads.cpp: (WTF::createThread): Updated for function signature change. We keep around the old 2-argument version of createThread for backward compatibility.
  • wtf/ThreadingWin.cpp: (WTF::setThreadName): Added. This function's implementation came from MSDN. (WTF::initializeThreading): Set the name of the main thread. (WTF::createThread): Call setThreadName. We keep around the old 2-argument version of createThread for backward compatibility.

WebCore:

Add names for WebCore's threads

Reviewed by Anders Carlsson.

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open):
  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::start):
  • storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::start): Pass in names to createThread.
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::runLoaderThread): (WebCore::ResourceHandle::loaderRunLoop): Changed to use WTF::createThread.

WebKit/win:

Export the new version of createThread

Reviewed by Anders Carlsson.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def: Also moved the old version of createThread into the deprecated section.
1:16 AM Changeset in webkit [35418] by ap@webkit.org
  • 8 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt.

Store UString::Rep::isStatic bit in identifierTable pointer instead of reportedCost for
slightly nicer code and a 0.5% SunSpider improvement.

Jul 28, 2008:

5:37 PM Changeset in webkit [35417] by andersca@apple.com
  • 3 edits in trunk/WebCore

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Based on a patch from Dimcho Balev.


Windows part of


​https://bugs.webkit.org/show_bug.cgi?id=18676
<rdar://problem/6106578>
Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs

  • plugins/PluginStream.cpp: (WebCore::PluginStream::wantsAllStreams):
  • plugins/PluginStream.h:
4:38 PM Changeset in webkit [35416] by jchaffraix@webkit.org
  • 11 edits
    2 adds in branches/XBL2

WebCore:

2008-07-28 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Bug 20196: [XBL] Re-enable CSS binding attachment

  • Re-enable legacy CSS attachment code.
  • Add XBLBindingManager bits so that it also creates / removes the required bindings.
  • Renamed '-webkit-binding' property to 'binding' (the name in the specification)

Test: fast/xbl/xbl-css-attachment.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::removeBindings): Added remove bindings and the style information associated.
  • css/CSSStyleSelector.h:
  • dom/Element.cpp: (WebCore::Element::hasBinding): Update the style as it will cause binding updates.
  • rendering/style/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::BindingURI::BindingURI):
  • rendering/style/RenderStyle.h:
  • xbl/XBLBindingManager.cpp: (WebCore::XBLBindingManager::addBinding): Limit to one binding per element with the same uri as the CSS attachment code can be hit twice.

LayoutTests:

2008-07-28 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Test case for bug 20196: [XBL] Re-enable CSS binding attachment

  • fast/xbl/xbl-css-attachment-expected.txt: Added.
  • fast/xbl/xbl-css-attachment.html: Added.
4:34 PM Changeset in webkit [35415] by beidson@apple.com
  • 6 edits
    4 adds in trunk

WebCore:

2008-07-28 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

Test: security/autocomplete-cleared-on-back.html

<rdar://problem/6093281> - autocomplete="off" should work when going back

Taken care of in two ways:
1 - Listening for the page cache notification to clear the form, in cases where the page

is being restored from the page cache

2 - Not saving such form elements when doing the normal "save state" to a history item,

for cases with no page cache

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::~HTMLFormElement): (WebCore::HTMLFormElement::parseMappedAttribute): (WebCore::HTMLFormElement::didRestoreFromCache): (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): (WebCore::HTMLFormElement::didMoveToNewOwnerDocument):
  • html/HTMLFormElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::saveState): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::needsCacheCallback): (WebCore::HTMLInputElement::registerForCacheCallbackIfNeeded): Only register if the type or attribute indicate we should. (WebCore::HTMLInputElement::unregisterForCacheCallbackIfNeeded): Only unregister if both the type and attribute are clear of needing registration. (WebCore::HTMLInputElement::didRestoreFromCache): (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): (WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
  • html/HTMLInputElement.h:

LayoutTests:

2008-07-28 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

<rdar://problem/6093281> - autocomplete="off" should work when going back

  • security/autocomplete-cleared-on-back-expected.txt: Added.
  • security/autocomplete-cleared-on-back.html: Added.
  • security/resources: Added.
  • security/resources/autocomplete-cleared-on-back2.html: Added.
3:50 PM Changeset in webkit [35414] by hyatt@apple.com
  • 14 edits
    16 adds in trunk

2008-07-28 David Hyatt <​hyatt@apple.com>

Add support for CSS variable declaration blocks.

Reviewed by Sam

Added tests in fast/css/variables.

  • css/CSSGrammar.y:
  • css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::isMutableStyleDeclaration):
  • css/CSSParser.cpp: (WebCore::CSSParser::addVariableDeclarationBlock):
  • css/CSSParser.h:
  • css/CSSProperty.cpp: (WebCore::CSSProperty::cssText):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::addMatchedDeclaration): (WebCore::CSSStyleSelector::resolveVariablesForDeclaration):
  • css/CSSStyleSelector.h:
  • css/CSSValueList.h: (WebCore::CSSValueList::isValueList):
  • css/CSSVariablesDeclaration.cpp: (WebCore::CSSVariablesDeclaration::CSSVariablesDeclaration): (WebCore::CSSVariablesDeclaration::getVariableValue): (WebCore::CSSVariablesDeclaration::removeVariable): (WebCore::CSSVariablesDeclaration::addParsedVariable): (WebCore::CSSVariablesDeclaration::getParsedSimpleVariable): (WebCore::CSSVariablesDeclaration::getParsedComplexVariable):
  • css/CSSVariablesDeclaration.h: (WebCore::CSSVariablesDeclaration::create):
  • css/StyleBase.cpp: (WebCore::StyleBase::cssText):
  • css/StyleBase.h: (WebCore::StyleBase::isValueList): (WebCore::StyleBase::isMutableStyleDeclaration):
3:46 PM Changeset in webkit [35413] by andersca@apple.com
  • 4 edits
    4 adds in trunk

../../../../../../LayoutTests:

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam.

<rdar://problem/6098335>
​https://bugs.webkit.org/show_bug.cgi?id=20150


Add tests.


  • http/tests/xmlhttprequest/resources/forbidden.txt: Added.
  • http/tests/xmlhttprequest/resources/redirect.php: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html: Added.

../../../../../../WebCore:

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam.

<rdar://problem/6098335>
​https://bugs.webkit.org/show_bug.cgi?id=20150


Handle willSendRequest correctly.

  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::willSendRequest): Make sure to keep the previous URL around so we know when to call willSendRequest.


  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::processSyncLoadResults): Abort if we don't have access to the response URL.


(WebCore::XMLHttpRequest::willSendRequest):
Dispatch a network error if we can't access the new URL.

2:15 PM Changeset in webkit [35412] by jchaffraix@webkit.org
  • 4 edits
    1 add in branches/XBL2/WebCore

2008-07-28 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Bug 20171: [XBL] Add <binding> 'element' attribute

  • DerivedSources.make: Add attrs file.
  • GNUmakefile.am: Ditto.
  • WebCore.pro: Ditto.
  • xbl/xblattrs.in: Added.
1:04 PM Changeset in webkit [35411] by ggaren@apple.com
  • 25 edits in trunk

JavaScriptCore:

2008-07-28 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Renamed "ConstructTypeNative" => "ConstructTypeHost".

WebCore:

2008-07-28 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Renamed "ConstructTypeNative" => "ConstructTypeHost".

12:23 PM Changeset in webkit [35410] by andersca@apple.com
  • 2 edits in trunk

Add radar number

12:20 PM Changeset in webkit [35409] by andersca@apple.com
  • 10 edits in trunk

../../../../../../WebCore:

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Based on a patch by Dimcho Balev.

​https://bugs.webkit.org/show_bug.cgi?id=18676
Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs


  • bridge/npapi.h: Add new enum values.


  • loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): When the plug-in indicates that it wants all streams to be delivered, don't cancel the stream if an error occurs.


  • loader/NetscapePlugInStreamLoader.h: (WebCore::NetscapePlugInStreamLoaderClient::wantsAllStreams): Add new client method.

../../../../../../WebKit/mac:

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Based on a patch by Dimcho Balev.


​https://bugs.webkit.org/show_bug.cgi?id=18676
Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs

  • Plugins/WebBaseNetscapePluginStream.h: Add NPP_GetValue pointer.


  • Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream setPlugin:]): Initialize NPP_GetValue.


(-[WebBaseNetscapePluginStream wantsAllStreams]):
Call NPP_GetValue.


  • Plugins/WebPlugInStreamLoaderDelegate.h:
  • WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h:
  • WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm: (WebNetscapePlugInStreamLoaderClient::wantsAllStreams): Implement this and call down to the stream.
9:59 AM Changeset in webkit [35408] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam.

<rdar://problem/6105529>
​https://bugs.webkit.org/show_bug.cgi?id=19659
Turning off plugins causes crash


When an active page has plug-ins, and plug-ins are disabled, they will be stopped and will
end up in a state where they don't have an event handler. Because of this, we need to
check that the plug-in has been started before calling the event handler.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendDrawRectEvent:]): (-[WebBaseNetscapePluginView setHasFocus:]): (-[WebBaseNetscapePluginView mouseDown:]): (-[WebBaseNetscapePluginView mouseUp:]): (-[WebBaseNetscapePluginView mouseEntered:]): (-[WebBaseNetscapePluginView mouseExited:]): (-[WebBaseNetscapePluginView handleMouseMoved:]): (-[WebBaseNetscapePluginView mouseDragged:]): (-[WebBaseNetscapePluginView scrollWheel:]): (-[WebBaseNetscapePluginView keyUp:]): (-[WebBaseNetscapePluginView keyDown:]): (-[WebBaseNetscapePluginView flagsChanged:]): (-[WebBaseNetscapePluginView cut:]): (-[WebBaseNetscapePluginView copy:]): (-[WebBaseNetscapePluginView paste:]): (-[WebBaseNetscapePluginView selectAll:]): (-[WebBaseNetscapePluginView drawRect:]): (-[WebBaseNetscapePluginView inputContext]):
12:37 AM Changeset in webkit [35407] by mrowe@apple.com
  • 2 edits in trunk/WebKitSite

2008-07-28 Robert Blaut <​webkit@blaut.biz>

Reviewed by Mark Rowe.

Fix for bug: Website provides no guidance on debugging
<​https://bugs.webkit.org/show_bug.cgi?id=3643>

  • building/debug.html: added info about Xcode Debugging Guide.
Note: See TracTimeline for information about the timeline view.