Timeline



Aug 9, 2008:

10:32 PM CygwinInstallerPackages created by wilsong@gmail.com
A list of all the packages included in the cygwin installer for …
10:19 PM BuildingOnWindows edited by wilsong@gmail.com
Adding a link to a new list of all packages included in the cygwin … (diff)
8:11 PM Changeset in webkit [35656] by alp@webkit.org
  • 2 edits in trunk

2008-08-09 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=19045
[gtk] ./configure doesn't check for x toolkit availability

Some old versions of Xt do not provide xt.pc, in this case use
AC_CHECK_LIB to check if the library is installed and then fall back
to using just -lXt.

  • configure.ac:
8:00 PM Changeset in webkit [35655] by alp@webkit.org
  • 2 edits in trunk

2008-08-09 Alp Toker <​alp@nuanti.com>

GTK+ build fixes.

Back out r20338 libxslt check (conditional check already exists and
this broke the build).

Make the flex version check a warning rather than fatal to fix the
build bot.

  • configure.ac:
7:03 PM Changeset in webkit [35654] by jmalonzo@webkit.org
  • 2 edits in trunk

2008-08-08 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=20338
[Gtk] Autotools should check for libxslt

Autotools check for libxslt

  • configure.ac:
2:14 PM Changeset in webkit [35653] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-08-09 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Fix some style issues in the sampling tool.

  • VM/SamplingTool.cpp: (KJS::sleepForMicroseconds): (KJS::SamplingTool::dump):
4:00 AM Changeset in webkit [35652] by cwzwarich@webkit.org
  • 5 edits in trunk/JavaScriptCore

2008-08-09 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Revision 35651, despite being a rather trivial change, introduced a
large regression on the regexp-dna SunSpider test. This regression
stemmed from an increase in the size of CodeBlock::dump(). There is
no reason for this method (and several related methods) to be compiled
in non-debug builds with the sampling tool disabled. This patch
conditionally compiles them, reversing the regression on SunSpider.

  • JavaScriptCore.exp:
  • VM/CodeBlock.cpp:
  • VM/CodeBlock.h:
  • VM/Machine.cpp:

Aug 8, 2008:

8:56 PM Changeset in webkit [35651] by cwzwarich@webkit.org
  • 4 edits
    3 adds in trunk

2008-08-08 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 20330: JSCore crash loading any filehurricane media page
<​https://bugs.webkit.org/show_bug.cgi?id=20330>

Fix a typo in the constant loading patch. Also, add a case for
op_unexpected_load to CodeBlock::dump().

JavaScriptCore:

  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::addUnexpectedConstant):

LayoutTests:

  • fast/js/resources/unexpected-constant-crash.js: Added.
  • fast/js/unexpected-constant-crash-expected.txt: Added.
  • fast/js/unexpected-constant-crash.html: Added.
8:37 PM Changeset in webkit [35650] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by John Sullivan.

  • fix <rdar://problem/6130216> Exception "windowRegionBeingDrawn != nil" in NSView when caching image of a subframe

This change reintroduces <​https://bugs.webkit.org/show_bug.cgi?id=5195> on Leopard.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): Removed an unsuccessful workaround for <rdar://problem/5668489>, because invoking layout may change the view hierarchy during the drawing operation, which is not supported on Leopard.
6:05 PM Changeset in webkit [35649] by Beth Dakin
  • 4 edits in trunk/WebCore

2008-08-08 Beth Dakin <Beth Dakin>

Reviewed by Darin.

This patch makes the findString and markAllMatchesForText functions
work with disconnected frames that are contained within
overflow:hidden blocks.

  • editing/Editor.cpp: (WebCore::Editor::rangeVisibility): (WebCore::Editor::firstVisibleRange): (WebCore::Editor::lastVisibleRange):
  • editing/Editor.h: (WebCore::Editor::):
  • page/Frame.cpp: (WebCore::Frame::findString): (WebCore::Frame::markAllMatchesForText):
5:15 PM Changeset in webkit [35648] by britto@apple.com
  • 15 edits
    2 adds in trunk

2008-08-08 Maxime Britto <​britto@apple.com>

Reviewed by Adele.

Test: fast/events/scroll-to-anchor-in-overflow-hidden.html
​https://bugs.webkit.org/show_bug.cgi?id=20270
Jump to an anchor wasn't working when the overflow:hidden CSS attribute was set on the page.

  • WebCore.base.exp:
  • dom/Element.cpp: (WebCore::Element::scrollIntoView): (WebCore::Element::scrollIntoViewIfNeeded):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseDraggedEvent):
  • page/Frame.cpp: (WebCore::Frame::revealSelection): (WebCore::Frame::revealCaret):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Takes a new parameter "scrollToAnchor" since it's a special case of scroll. It passes this new bool to canBeProgrammaticallyScrolled. (WebCore::RenderLayer::autoscroll):
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.h: (WebCore::RenderListBox::canBeProgramaticallyScrolled):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled): If the call is coming from a scrollToAnchor we don't need scrollBars to accept.
  • rendering/RenderObject.h:
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::canBeProgramaticallyScrolled):

2008-08-08 Maxime Britto <​britto@apple.com>

Reviewed by Adele.

  • WebView/WebFrame.mm: (-[WebFrame _scrollDOMRangeToVisible:]):

2008-08-08 Maxime Britto <​britto@apple.com>

Reviewed by Adele.
​https://bugs.webkit.org/show_bug.cgi?id=20270
This test is automatic and can also be run manually.

  • fast/events/scroll-to-anchor-in-overflow-hidden-expected.txt: Added.
  • fast/events/scroll-to-anchor-in-overflow-hidden.html: Added.
4:40 PM Changeset in webkit [35647] by britto@apple.com
  • 2 edits in trunk/WebCore

2008-08-08 Maxime Britto <​britto@apple.com>

Reviewed by Adele.

<rdar://problem/6137022>
<​https://bugs.webkit.org/show_bug.cgi?id=20331>
REGRESSION(r35177-r35203): Scrolling slowly over a scrollable field scrolls the page instead of the field (20331)

  • page/EventHandler.cpp: (WebCore::scrollAndAcceptEvent): fixed the wrong cast for the wheel delta which was truncated to 0 on slow wheel scrolls.
1:44 PM Changeset in webkit [35646] by dino@apple.com
  • 7 edits
    3 adds in trunk/WebCore

Execute CSS Animations using new AnimationController
​https://bugs.webkit.org/show_bug.cgi?id=20119

I still need to file some follow-on bugs that EricS noticed.

Reviewed by Dave Hyatt

Some new tests:

  • manual-tests/animate-duration.html: Added.
  • manual-tests/animate-left.html: Added.
  • manual-tests/animate-none.html: Added.
  • css/CSSStyleSelector.cpp:
  • dom/Document.cpp:
    • don't redo style when page is place into cache
  • page/AnimationController.cpp:
  • page/AnimationController.h:
    • execute the animations
  • rendering/RenderObject.cpp:
  • rendering/style/RenderStyle.h:
    • make border radii const (for blending)
1:25 PM Changeset in webkit [35645] by kmccullough@apple.com
  • 5 edits in trunk/WebCore

2008-08-08 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/6136326> JSProfiler: Start/stop profiling button in the
Web Inspector does not match the menu.

  • page/InspectorController.cpp: (WebCore::InspectorController::toggleRecordButton): Toggle the record button in the webInspector. (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling):
  • page/InspectorController.h:
  • page/inspector/ProfilesPanel.js: Move the UI part of the record button into its funtion so that it can be called from the Inspector controller.
  • page/inspector/inspector.js:
11:57 AM Changeset in webkit [35644] by pewtermoose@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-08-08 Matt Lilek <​webkit@mattlilek.com>

Not reviewed, build fix.

11:48 AM Changeset in webkit [35643] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

2008-08-08 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

Fix for <rdar://problem/5865504>

This bug was actually *largely* fixed by ​http://trac.webkit.org/changeset/35538.
But with that same patch, it became possible for a WebResource to fail to initialize.
Therefore we were trying to add nil to an NSCFArray for certain situations, which is bad.
Lets fix that, shall we?

  • WebView/WebArchive.mm: (-[WebArchive subresources]):
11:21 AM Changeset in webkit [35642] by kmccullough@apple.com
  • 3 edits in trunk/WebCore

2008-08-08 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/6131187> Profiles don't show up immediately when run
with the UI.

  • page/InspectorController.cpp: (WebCore::startProfiling): Added so that the inspector's JS code could call through to the same function used by the Develop menu. This way both can call didFinishAllExecution() which puts the profile in the Web Inspector. (WebCore::stopProfiling): Ditto (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::stopUserInitiatedProfiling): Now calls didFinishAllExecution() to put the profile in the Web Inspector. This should be safe since the UIs shouldn't work if JS is still running.
  • page/inspector/ProfilesPanel.js: Use the new functions.
10:38 AM Changeset in webkit [35641] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • fix <rdar://problem/5961260> GDI text: transparent fill color text does not render if it it has a stroke or shadow
  • platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs):
5:59 AM Changeset in webkit [35640] by jchaffraix@webkit.org
  • 11 edits
    7 adds in branches/XBL2

WebCore:

2008-08-08 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Tests: fast/xbl/xbl-crash-inline.xhtml

fast/xbl/xbl-document-sheets-modification.xhtml
fast/xbl/xbl-element-binding.xhtml

Bug 20212: [XBL] Add full support for element="" attachment

  • Add attributeChanged method to XBLBindingElement to catch "element" changes and update the bindings.
  • Translate "element" attribute to a stylesheet that is added to the bound document's sheets.
  • GNUmakefile.am: Add XBLBindingElement.cpp.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): Add binding sheets.
  • dom/Document.cpp: (WebCore::Document::~Document): Remove binding sheet information.

(WebCore::Document::recalcStyleSelector): When
recalculating the style selector, remove all the bindings
as the removed sheets would never remove theirs.

(WebCore::Document::addBindingSheet): Update binding manager
information.
(WebCore::Document::removeBindingSheet): Ditto.

  • dom/Document.h:
  • xbl/XBLBindingElement.cpp: Added. (WebCore::XBLBindingElement::XBLBindingElement): (WebCore::XBLBindingElement::attributeChanged): Check for "element" changes and update the cached sheet and the bound element's bindings style sheets.

(WebCore::XBLBindingElement::generateBindingSheet): Create
the style sheet from the "element" attribute.

  • xbl/XBLBindingElement.h:
  • xbl/XBLBindingManager.cpp: (WebCore::XBLBindingManager::addBindingSheet): (WebCore::XBLBindingManager::removeBindingSheet): (WebCore::XBLBindingManager::clearBindingSheets): (WebCore::XBLBindingManager::getBindingSheets): All 4 previous methods are used to manage the binding sheets.
  • xbl/XBLBindingManager.h:

LayoutTests:

2008-08-08 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Test case for bug 20212: [XBL] Add full support for element="" attachment


  • fast/xbl/xbl-crash-inline-expected.txt: Added.
  • fast/xbl/xbl-crash-inline.xhtml: Added.
  • fast/xbl/xbl-document-sheets-modification-expected.txt: Added.
  • fast/xbl/xbl-document-sheets-modification.xhtml: Added.
  • fast/xbl/xbl-element-binding-expected.txt: Added.
  • fast/xbl/xbl-element-binding.xhtml: Added.


2:48 AM Changeset in webkit [35639] by oliver@apple.com
  • 5 edits in trunk/JavaScriptCore

Improve performance of arithmetic operators

Reviewed by Cameron Zwarich

Added a fast (non-virtual) mechanism to determine if a non-immediate JSValue*
is a JSNumberCell. We then use this to allow improved specialisation in many
arithmetic operators. SunSpider reports a 2.5% progression overall, with greater
than 10% progressions on a number of arithmetic heavy tests.

2:32 AM Changeset in webkit [35638] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-08-08 Adam Treat <​treat@kde.org>

Reviewed by Simon.

Return the canonical file path in Qt's listDirectory as WebCore::PluginDatabase
uses this method to retrieve a list of possible plugins. Many linux systems
have nested symbolic links scattered throughout the plugin directories which
resulted in the PluginDatabase loading the same plugin N times depending on
the number of symbolic links.

1:21 AM Changeset in webkit [35637] by jchaffraix@webkit.org
  • 5 edits in branches/XBL2/WebCore

008-08-08 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Re-enable last bits of XBLDocument loading
legacy code.

  • loader/DocLoader.cpp: (WebCore::DocLoader::requestXBLDocument): (WebCore::DocLoader::requestResource):
  • loader/DocLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addLowBandwidthDisplayRequest):
  • xbl/XBLDocument.h: (WebCore::XBLDocument::create): Removed adoptRef to match other Document 'create' method as it would lead to refcount churn. Also added missing 'const' in isXBLDocument.

Aug 7, 2008:

9:05 PM Changeset in webkit [35636] by timothy@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix bug numbers.

9:04 PM Changeset in webkit [35635] by mrowe@apple.com
  • 1 edit in tags/Safari-6528.0.3/WebCore/DerivedSources.cpp

Build fix.

9:04 PM Changeset in webkit [35634] by mrowe@apple.com
  • 4 edits in tags/Safari-6528.0.3

Versioning.

8:56 PM Changeset in webkit [35633] by timothy@apple.com
  • 2 edits in trunk/WebCore

Change highlight time from 300ms to 500ms and fade effect from 1s to 2s

​https://bugs.webkit.org/show_bug.cgi?id=17589

Reviewed by Timothy Hatcher.

  • page/inspector/SourceFrame.js:
8:55 PM Changeset in webkit [35632] by timothy@apple.com
  • 3 edits in trunk/WebCore

The search is only performed if the field contains more than 3
letters or if Enter is pressed.

Search is now performed through a keyup event.

Added a WebInspector.lastQuery to remember the last query and not
perform it again (eg. the user hits a modifier key).

​https://bugs.webkit.org/show_bug.cgi?id=18548

Reviewed by Timothy Hatcher.

  • page/inspector/inspector.html: Removed the onsearch and incremental attributes
  • page/inspector/inspector.js:
8:30 PM Changeset in webkit [35631] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.0.3

New tag.

5:35 PM Changeset in webkit [35630] by mrowe@apple.com
  • 2 edits
    1 add in tags/Safari-6528.0.2/WebCore

Merge r35629.

4:38 PM Changeset in webkit [35629] by sfalken@apple.com
  • 2 edits
    1 add in trunk/WebCore

Compile derived sources through an all-in-one cpp file.
Fixes Windows release build on non-x64 systems by reducing the size of WebCore.lib from 1.5GB to 1GB.


Reviewed by Mark Rowe.

  • DerivedSources.cpp: Added.
  • WebCore.vcproj/WebCore.vcproj:
3:29 PM Changeset in webkit [35628] by kmccullough@apple.com
  • 4 edits in trunk/WebCore

2008-08-07 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Adam.

<rdar://problem/5712917> Confusing console error message clear
behavior (16791)
​https://bugs.webkit.org/show_bug.cgi?id=16791
<rdar://problem/5831899> The Web Inspector does not correctly clear the
console messages

  • page/InspectorController.cpp: Clear the message so they don't show up in the inspector after it has cleared them. (WebCore::clearMessages): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::windowScriptObjectAvailable):
  • page/InspectorController.h:
  • page/inspector/Console.js: Tell the InspectorController to clear the messages it's holding onto.
2:55 PM Changeset in webkit [35627] by Simon Fraser
  • 10 edits
    2 adds in trunk/WebCore

2008-08-07 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig

Rename Marquee to RenderMarquee and move to its own file.
​https://bugs.webkit.org/show_bug.cgi?id=20319

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLMarqueeElement.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::styleChanged):
  • rendering/RenderLayer.h:
  • rendering/RenderMarquee.cpp: Added. (WebCore::RenderMarquee::RenderMarquee): (WebCore::RenderMarquee::marqueeSpeed): (WebCore::RenderMarquee::direction): (WebCore::RenderMarquee::isHorizontal): (WebCore::RenderMarquee::computePosition): (WebCore::RenderMarquee::start): (WebCore::RenderMarquee::suspend): (WebCore::RenderMarquee::stop): (WebCore::RenderMarquee::updateMarqueePosition): (WebCore::RenderMarquee::updateMarqueeStyle): (WebCore::RenderMarquee::timerFired):
  • rendering/RenderMarquee.h: Added. (WebCore::RenderMarquee::speed): (WebCore::RenderMarquee::reverseDirection): (WebCore::RenderMarquee::setEnd):
1:32 PM Changeset in webkit [35626] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6118816> Initial empty page or bookmarks view window has white strip where vertical scrollbar would be (which vanishes on resize)
  • page/Frame.cpp: (WebCore::Frame::setZoomFactor): If the view has never had a layout with the old zoom factor, then there is no need to explicitly call layout() here.
10:28 AM Changeset in webkit [35625] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-08-07 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Geoff.

<rdar://problem/6115981> Start the profiler in Heavy view

  • page/inspector/ProfileView.js:
9:04 AM Changeset in webkit [35624] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Delete backing stores before 5 second WM_TIMER fires if more than 2 are already queued.


WM_TIMER-based timers can be starved if enough other events are keeping
our message loop busy. This change prevents many backing store deletes from stacking
up in this case.


Reviewed by Geoff Garen.

  • WebView.cpp: (WebView::deleteBackingStore): (WebView::deleteBackingStoreSoon): (WebView::cancelDeleteBackingStoreSoon):
5:09 AM Changeset in webkit [35623] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-08-07 Alp Toker <​alp@nuanti.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=20313
Add null check in String::fromUTF8()

Make String::fromUTF8() consistent with other constructors by
returning a null String when the input is null instead of crashing.

  • platform/text/String.cpp: (WebCore::String::fromUTF8):
5:08 AM Changeset in webkit [35622] by jmalonzo@webkit.org
  • 3 edits in trunk

2008-08-07 Kalle Vahlman <​zuh@iki.fi>

Reviewed by David Kilzer.

Check for correct flex version to avoid faulty builds

A correct Webkit build requires flex 2.5.33 but autotools build doesn't check for it
​https://bugs.webkit.org/show_bug.cgi?id=20253

acinclude.m4: Import AX_COMPARE_VERSION macro
configure.ac: Check for flex version

  • acinclude.m4:
  • configure.ac:
4:31 AM Changeset in webkit [35621] by Simon Hausmann
  • 3 edits
    8 adds in trunk

2008-08-07 Simon Hausmann <Simon Hausmann>

Rubber-stamped by Lars.

Added API tests for QWebPage/QWebFrame based on QTestLib.

Aug 6, 2008:

8:52 PM Changeset in webkit [35620] by kevino@webkit.org
  • 4 edits
    2 adds in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Create a wxWebFrame API to match other ports and to prepare for frames support.
Also fixes a frame leak in wx port on trunk.

​https://bugs.webkit.org/show_bug.cgi?id=19041

5:46 PM Changeset in webkit [35619] by mrowe@apple.com
  • 1 edit in trunk/WebKitLibraries/win/tools/scripts/VERSION

Versioning.

4:48 PM Changeset in webkit [35618] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix after Frame -> ScriptController moves. Also, remove a character which was in an unknown encoding and replace it with an ANSI representation (which the author used for their Bugzilla account too).

4:08 PM Changeset in webkit [35617] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-08-06 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

  • Make XHR console message clearer.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
4:07 PM Changeset in webkit [35616] by kmccullough@apple.com
  • 4 edits in trunk/WebCore

2008-08-06 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

  • Created a new function to create DOM links from text without converting back and forth from HTML and messing with escaping special characters.
  • page/inspector/Console.js:
  • page/inspector/inspector.js:
  • page/inspector/utilities.js:
3:39 PM Changeset in webkit [35615] by eric@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by hyatt.

Fix a large animation leak found on the buildbot
(m_animations and m_transitions were never deleted)
Drag RenderStyle (kicking and screaming) into the 21st century
of memory management with a little application of OwnPtr.

  • rendering/style/RenderStyle.cpp: (WebCore::FillLayer::cullEmptyLayers): (WebCore::RenderStyle::diff): (WebCore::RenderStyle::contentDataEquivalent): (WebCore::RenderStyle::setContent): (WebCore::BindingURI::BindingURI): (WebCore::RenderStyle::setBoxShadow): (WebCore::ShadowData::ShadowData): (WebCore::RenderStyle::counterDirectives): (WebCore::RenderStyle::accessCounterDirectives): (WebCore::RenderStyle::adjustAnimations): (WebCore::RenderStyle::adjustTransitions): (WebCore::RenderStyle::accessAnimations): (WebCore::RenderStyle::accessTransitions):
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::clearAnimations): (WebCore::RenderStyle::clearTransitions):
3:17 PM Changeset in webkit [35614] by beidson@apple.com
  • 4 edits in trunk/WebCore

2008-08-06 Brady Eidson <​beidson@apple.com>

Reviewed by MitzPettel

<rdar://problem/6078543> - Many LocalStorageThreads may be started

The original decision to key LocalStorage sets to PageGroups was a poor one.

It seems a much better solution is to key them to the actual path of on-disk storage,
which also solves all of the avenues that could lead to a boundless number of threads.

In this patch, I am not attempting to completely sever the attachment of LocalStorage
to PageGroups as that would require a more substantial re-working of the lifetime
between pages, groups, and local storage threads.

  • page/PageGroup.cpp: (WebCore::PageGroup::addPage):
  • storage/LocalStorage.cpp: (WebCore::localStorageMap): Map paths to LocalStorage objects here. (WebCore::LocalStorage::localStorage): Return the shared LocalStorage object for this path, or create a new one if it doesn't yet exist. (WebCore::LocalStorage::LocalStorage): (WebCore::LocalStorage::~LocalStorage): Add to remove the path->LocalStorage mapping
  • storage/LocalStorage.h:
3:12 PM Changeset in webkit [35613] by Beth Dakin
  • 2 edits in trunk/WebCore

2008-08-06 Beth Dakin <Beth Dakin>

Reviewed by Adele.

Fix for <rdar://problem/6130724>

Disconnected frames should not be allowed to resize the window.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::resizeBy): (WebCore::DOMWindow::resizeTo):
2:27 PM Changeset in webkit [35612] by mitz@apple.com
  • 1 edit in trunk/WebKitTools/ChangeLog

Added bug URLs

2:15 PM Changeset in webkit [35611] by ddkilzer@apple.com
  • 5 edits
    2 adds in trunk

WebCore:

Bug 20038: REGRESSION (r35151): Can't post comments on flickr.com

<​https://bugs.webkit.org/show_bug.cgi?id=20038>
<rdar://problem/6092270>

Reviewed by Eric Seidel.

Test: fast/forms/submit-to-url-fragment.html

The problem was that isFormSubmission was not being set to true in
FrameLoader::loadWithDocumentLoader() when we were actually
submitting a form, causing the page to scroll instead of the form to
be submitted.

The isFormSubmission variable wasn't set to true because a FormState
object was not being created in
FrameLoader::loadFrameRequestWithFormAndValues().

The FormState object was not being created because
HTMLFormElement::submit(Event*, bool activateSubmitButton) would
only set FrameLoader::m_formAboutToBeSubmitted to the current form
if there was a "text field" element in the form (type = text,
password, search or isindex).

Thus when FrameLoader::submitForm(const FrameLoadRequest&, Event*)
called FrameLoader::loadFrameRequestWithFormAndValues(), a null
HTMLFormElement pointer would be sent and cause the above failures.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Call new FrameLoader::setFormAboutToBeSubmitted() method outside the for loop so we always set FrameLoader::m_formAboutToBeSubmitted exactly once for any form submission. The FrameLoader::recordFormValue() method is only called with the name/value pair of each text field.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::setFormAboutToBeSubmitted): Added method that only sets m_formAboutToBeSubmitted. (WebCore::FrameLoader::recordFormValue): Removed PassRefPtr<HTMLFormElement> argument since this method only sets name/value pairs on m_formValuesAboutToBeSubmitted now. (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): Create a FormState object as long as submitForm is not null so that other FrameLoader methods know when a form is being submitted.
  • loader/FrameLoader.h:

LayoutTests:

Bug 20038: REGRESSION (r35151): Can't post comments on flickr.com

<​https://bugs.webkit.org/show_bug.cgi?id=20038>
<rdar://problem/6092270>

Reviewed by Eric Seidel.

  • fast/forms/submit-to-url-fragment-expected.txt: Added.
  • fast/forms/submit-to-url-fragment.html: Added.
1:26 PM Changeset in webkit [35610] by ddkilzer@apple.com
  • 4 edits in trunk/WebCore

BUILD FIX: Add HTMLPlugInImageElement.cpp to all other build systems

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCoreSources.bkl:
1:22 PM Changeset in webkit [35609] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • Windows build fix
  • WebCore.vcproj/WebCore.vcproj: Added PlugInImageElement.*
1:01 PM Changeset in webkit [35608] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

Reviewed by darin.

Fix leaks seen on build-bot by fixing memory management of AccessibilityUIElement.

I've made AccessibilityUIElement a stack object for now. It could be
made RefCounted, but I figured that might be overkill for the moment.
Essentially it's just a RefPtr itself. :)

I also fixed a few typos, such as AccessibilityUIElement() instead of ~AccessibilityUIElement()
which was causing additional leaks. :)

I added toAXElement to remove a bunch of copy/paste code.

  • DumpRenderTree/AccessibilityController.h:
  • DumpRenderTree/AccessibilityUIElement.cpp: (toAXElement): (allAttributesCallback): (attributesOfLinkedUIElementsCallback): (attributesOfChildrenCallback): (lineForIndexCallback): (boundsForRangeCallback): (childAtIndexCallback): (getRoleCallback): (getTitleCallback): (getDescriptionCallback): (getWidthCallback): (getHeightCallback): (getIntValueCallback): (getMinValueCallback): (getMaxValueCallback): (getInsertionPointLineNumberCallback): (finalize):
  • DumpRenderTree/AccessibilityUIElement.h: (AccessibilityUIElement::platformUIElement):
  • DumpRenderTree/mac/AccessibilityControllerMac.mm: (AccessibilityController::focusedElement):
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::getLinkedUIElements): (AccessibilityUIElement::getChildren): (AccessibilityUIElement::getChildAtIndex): (AccessibilityUIElement::attributesOfLinkedUIElements): (AccessibilityUIElement::attributesOfChildren):
11:47 AM Changeset in webkit [35607] by kmccullough@apple.com
  • 4 edits in trunk/WebCore

2008-08-06 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim and Darin.

<rdar://problem/6126160> URLs in the console should be clickable.

  • Implemented and now use linkifyString() to parse console messages for URLs.
  • page/inspector/Console.js:
  • page/inspector/inspector.js:
  • page/inspector/utilities.js:
10:23 AM Changeset in webkit [35606] by ddkilzer@apple.com
  • 8 edits
    10 adds in trunk

WebCore:

Images using QT plugin do not display correctly

<​https://bugs.webkit.org/show_bug.cgi?id=9214>
<rdar://problem/5683413>

Reviewed by Darin.

Tests: fast/images/embed-image.html

fast/images/object-image.html

Use RenderImage instead of RenderPartObject for a renderer when
the <embed> tag references an image. Extract common code from
HTMLEmbedElement and HTMLObjectElement into HTMLPlugInImageElement.

  • WebCore.xcodeproj/project.pbxproj: Added new source files.
  • html/HTMLEmbedElement.cpp: Cleaned up #include statements. (WebCore::HTMLEmbedElement::HTMLEmbedElement): Extend HTMLPlugInImageElement which extends HTMLPlugInElement. (WebCore::HTMLEmbedElement::parseMappedAttribute): Split codeAttr and srcAttr cases. Create or clear HTMLImageLoader as needed for srcAttr. (WebCore::HTMLEmbedElement::rendererIsNeeded): Use HTMLPlugInElement::rendererIsNeeded() for images. (WebCore::HTMLEmbedElement::createRenderer): Create a RenderImage instead of a RenderPartObject for images. (WebCore::HTMLEmbedElement::attach): Create HTMLImageLoader, load image and populate RenderImage for images. (WebCore::HTMLEmbedElement::updateWidget): Don't call RenderPartObject::updateWidget() for images. (WebCore::HTMLEmbedElement::imageSourceAttributeName): Added.
  • html/HTMLEmbedElement.h: Removed unneeded namespace and class declarations. Extend HTMLPlugInImageElement which extends HTMLPlugInElement. (WebCore::HTMLEmbedElement::imageSourceAttributeName): Added. (WebCore::HTMLEmbedElement::serviceType): Moved to HTMLPlugInImageElement. (WebCore::HTMLEmbedElement::url): Ditto.
  • html/HTMLObjectElement.cpp: Cleaned up #include statements. (WebCore::HTMLObjectElement::attach): Removed local variable. (WebCore::HTMLObjectElement::isImageType): Moved to HTMLPlugInImageElement.
  • html/HTMLObjectElement.h: Extend HTMLPlugInImageElement which extends HTMLPlugInElement. (WebCore::HTMLObjectElement::isImageType): Moved to HTMLPlugInImageElement. (WebCore::HTMLObjectElement::serviceType): Ditto. (WebCore::HTMLObjectElement::url): Ditto.
  • html/HTMLPlugInImageElement.cpp: Added. (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Added. (WebCore::HTMLPlugInImageElement::~HTMLPlugInImageElement): Added. (WebCore::HTMLPlugInImageElement::isImageType): Moved from HTMLObjectElement.
  • html/HTMLPlugInImageElement.h: Added. (WebCore::HTMLPlugInImageElement::isImageType): Added from HTMLObjectElement. (WebCore::HTMLPlugInImageElement::serviceType): Ditto. (WebCore::HTMLPlugInImageElement::url): Ditto.
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteImageURL): Return urlString for embed elements with images.

LayoutTests:

Images using QT plugin do not display correctly

<​https://bugs.webkit.org/show_bug.cgi?id=9214>
<rdar://problem/5683413>

Reviewed by Darin.

Test images rendered by both embed and object elements.

  • fast/images/embed-image.html: Added.
  • fast/images/object-image.html: Added.
  • platform/mac/fast/images/embed-image-expected.checksum: Added.
  • platform/mac/fast/images/embed-image-expected.png: Added.
  • platform/mac/fast/images/embed-image-expected.txt: Added.
  • platform/mac/fast/images/object-image-expected.checksum: Added.
  • platform/mac/fast/images/object-image-expected.png: Added.
  • platform/mac/fast/images/object-image-expected.txt: Added.
9:33 AM Changeset in webkit [35605] by Chris Fleizach
  • 4 edits in trunk

Fix an accessibility layout test that was failing on different platforms

7:50 AM Changeset in webkit [35604] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Try to fix the Windows build bots

  • API/JSBase.cpp: Touch this to force JSC to rebuild and re-copy the WTF headers.
6:30 AM Changeset in webkit [35603] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-08-06 Benjamin C Meyer <​ben@meyerhome.net>

Reviewed by Simon.

During the drag operation only accept the event if the action is not ignore action.

6:02 AM Changeset in webkit [35602] by vestbo@webkit.org
  • 2 edits in trunk/JavaScriptCore

Revert change 35595.

5:46 AM Changeset in webkit [35601] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-08-06 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Eric Seidel.

​http://bugs.webkit.org/show_bug.cgi?id=20295
RegularExpression::match should not crash when a null string is passed

RegularExpression::match used to pass null subject strings to
jsRegExpExecute causing an ASSERT failure and then a crash.
There is no need to fix also RegularExpression:search and
RegularExpression::searchRev as they just call
RegularExpression::match.

  • platform/text/RegularExpression.cpp: (WebCore::RegularExpression::match): Return -1 if the string is null.
5:40 AM Changeset in webkit [35600] by jmalonzo@webkit.org
  • 2 edits in trunk

2008-08-06 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Eric Seidel.

​http://bugs.webkit.org/show_bug.cgi?id=20276
[GTK] Makefile rules for the enum GTypes files depend on Makefile
instead of GNUmakefile

The patch committed in revision 34649 added the code needed to
generate GTypes for enums but the makefile rules for
stamp-webkitenumtypes.h and webkitenumtypes.cpp were depending on
Makefile (used by other ports) instead of GNUmakefile.

  • GNUmakefile.am: Depend on GNUmakefile instead of Makefile.
5:35 AM Changeset in webkit [35599] by jmalonzo@webkit.org
  • 3 edits in trunk/WebCore

2008-08-06 Jan Michael Alonzo <​jmalonzo@webkit.org>

Gtk build fix only

  • bindings/js/ScriptControllerGtk.cpp:
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::getValue): (WebCore::PluginView::~PluginView):
5:11 AM Changeset in webkit [35598] by eric@webkit.org
  • 11 edits in trunk

Reviewed by Cameron Zwarich.

Fix warnings and errors seen on Qt bot.
Including one correctness fix for ThreadingQt.
According to the Qt 4.4 docs, we were always passing
seconds to "wait()" when we should have been passing
milliseconds.

Lots of float <-> int conversion warnings.

  • css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
  • dom/Element.cpp: (WebCore::adjustForLocalZoom): (WebCore::adjustForAbsoluteZoom): (WebCore::Element::setScrollLeft): (WebCore::Element::setScrollTop):
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent):
  • loader/CachedImage.cpp: (WebCore::CachedImage::imageRect):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::innerHeight): (WebCore::DOMWindow::innerWidth): (WebCore::DOMWindow::scrollX): (WebCore::DOMWindow::scrollY): (WebCore::DOMWindow::scrollTo):
  • page/EventHandler.cpp: (WebCore::scrollAndAcceptEvent):
  • plugins/npapi.cpp:
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::getValue): (WebCore::PluginView::~PluginView):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::intrinsicSizeChanged):
4:46 AM Changeset in webkit [35597] by vestbo@webkit.org
  • 4 edits in trunk

2008-08-06 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Fix the Qt build due to recent ScriptController refactoring.

4:46 AM Changeset in webkit [35596] by vestbo@webkit.org
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix non-Mac build.

4:17 AM Changeset in webkit [35595] by vestbo@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-08-06 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Fix non-Mac build.

3:50 AM Changeset in webkit [35594] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-08-06 Csaba Osztrogonac <​oszi@inf.u-szeged.hu>

Reviewed by Darin. Landed by Cameron.

Bug 20272: typo in JavaScriptCore
<​https://bugs.webkit.org/show_bug.cgi?id=20272>

Correct the documentation for op_not. (typo)
Fix #undef. (typo)

  • VM/Machine.cpp: (KJS::Machine::privateExecute):
3:37 AM Changeset in webkit [35593] by cwzwarich@webkit.org
  • 18 edits
    3 adds in trunk

2008-08-06 Cameron Zwarich <​cwzwarich@webkit.org>

Reviewed by Maciej.

Bug 20286: Load constants all at once instead of using op_load
<​https://bugs.webkit.org/show_bug.cgi?id=20286>

Load constants all at once into temporary registers instead of using
individual instances of op_load.

This is a 2.6% speedup on SunSpider.

JavaScriptCore:

  • JavaScriptCore.exp:
  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump): (KJS::CodeBlock::mark):
  • VM/CodeBlock.h:
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator): (KJS::CodeGenerator::newTemporary): (KJS::CodeGenerator::addConstant): (KJS::CodeGenerator::addUnexpectedConstant): (KJS::CodeGenerator::emitLoad): (KJS::CodeGenerator::emitUnexpectedLoad): (KJS::CodeGenerator::emitNewError):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (KJS::slideRegisterWindowForCall): (KJS::Machine::unwindCallFrame): (KJS::Machine::throwException): (KJS::Machine::execute): (KJS::Machine::privateExecute):
  • VM/Machine.h:
  • VM/Opcode.h:
  • VM/RegisterID.h: (KJS::RegisterID::RegisterID): (KJS::RegisterID::makeConstant): (KJS::RegisterID::isTemporary):
  • kjs/NodeInfo.h:
  • kjs/Parser.cpp: (KJS::Parser::didFinishParsing):
  • kjs/Parser.h: (KJS::Parser::parse):
  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::NullNode::emitCode): (KJS::BooleanNode::emitCode): (KJS::NumberNode::emitCode): (KJS::StringNode::emitCode): (KJS::ArrayNode::emitCode): (KJS::DeleteResolveNode::emitCode): (KJS::DeleteValueNode::emitCode): (KJS::VoidNode::emitCode): (KJS::ConstDeclNode::emitCodeSingle): (KJS::ReturnNode::emitCode): (KJS::ScopeNode::ScopeNode): (KJS::ProgramNode::ProgramNode): (KJS::ProgramNode::create): (KJS::EvalNode::EvalNode): (KJS::EvalNode::create): (KJS::FunctionBodyNode::FunctionBodyNode): (KJS::FunctionBodyNode::create): (KJS::FunctionBodyNode::emitCode):
  • kjs/nodes.h: (KJS::ScopeNode::neededConstants):

LayoutTests:

  • fast/js/constant-count-expected.txt: Added.
  • fast/js/constant-count.html: Added.
  • fast/js/deep-recursion-test.html:
  • fast/js/resources/constant-count.js: Added.
3:34 AM Changeset in webkit [35592] by eric@webkit.org
  • 6 edits in trunk/WebCore

Build fix only, no review.

Attempt to fix the Windows and Qt builds.

  • bindings/js/ScriptControllerWin.cpp: add runtime.h include
  • bindings/js/ScriptControllerQt.cpp: add QWidget include
  • page/win/FrameWin.cpp: remove bogus using namespace
  • plugins/PluginView.cpp: (WebCore::PluginView::bindingInstance): use script()
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::getValue): use script() (WebCore::PluginView::~PluginView): use script()
3:17 AM Changeset in webkit [35591] by eric@webkit.org
  • 3 edits in trunk/WebCore

Build fix only, no review.

Attempt to fix the Linux and --no-svg builds.

  • bindings/js/ScriptController.h: wrap RetainPtr include in PLATFORM(MAC)
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): add missing CSSProperties to switch
3:01 AM Changeset in webkit [35590] by eric@webkit.org
  • 35 edits
    3 copies
    1 add in trunk

Reviewed by Cameron Zwarich.

Move more methods from Frame into ScriptController
​https://bugs.webkit.org/show_bug.cgi?id=20294

Finally finish more of the work which Darin started long ago
Move a few more Frame methods into ScriptController.
I also took this opportunity to clean up some of the plugin
code as well, and moved some of that into ScriptController.

I removed Frame::clearScriptController() and ScriptController::clear() is now clearWindowShell()

No functional changes, thus no test cases.

  • GNUmakefile.am:
  • WebCore.NPAPI.exp:
  • WebCore.base.exp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::~ScriptController): (WebCore::ScriptController::bindingRootObject): (WebCore::ScriptController::createRootObject): (WebCore::ScriptController::windowScriptNPObject): (WebCore::ScriptController::createScriptObjectForPluginElement): New method. (WebCore::ScriptController::clearPlatformScriptObjects): (WebCore::ScriptController::disconnectPlatformScriptObjects): (WebCore::ScriptController::cleanupScriptObjectsForPlugin): (WebCore::ScriptController::clearScriptObjects):
  • bindings/js/ScriptController.h: (WebCore::ScriptController::sourceURL): (WebCore::ScriptController::clearFormerWindow):
  • bindings/js/ScriptControllerGtk.cpp: Copied from WebCore/page/gtk/FrameGtk.cpp. (WebCore::Frame::createScriptInstanceForWidget):
  • bindings/js/ScriptControllerMac.mm: Added. (WebCore::ScriptController::createScriptInstanceForWidget): (WebCore::ScriptController::windowScriptObject): (WebCore::ScriptController::clearPlatformScriptObjects): (WebCore::ScriptController::disconnectPlatformScriptObjects): (WebCore::updateRenderingForBindings): (WebCore::ScriptController::initJavaJSBindings):
  • bindings/js/ScriptControllerQt.cpp: Copied from WebCore/page/gtk/FrameGtk.cpp. (WebCore::ScriptController::createScriptInstanceForWidget):
  • bindings/js/ScriptControllerWin.cpp: Copied from WebCore/svg/graphics/cg/SVGResourceMaskerCg.cpp. (WebCore::ScriptController::createScriptInstanceForWidget):
  • bindings/objc/DOM.mm: (-[DOMNode KJS::Bindings::]):
  • bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
  • bridge/jni/jni_jsobject.mm: (createRootObject):
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::renderWidgetForJSBindings):
  • html/HTMLAppletElement.h:
  • html/HTMLEmbedElement.cpp: (WebCore::findWidgetRenderer): (WebCore::HTMLEmbedElement::renderWidgetForJSBindings):
  • html/HTMLEmbedElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::~HTMLObjectElement): (WebCore::HTMLObjectElement::renderWidgetForJSBindings): (WebCore::HTMLObjectElement::detach):
  • html/HTMLObjectElement.h:
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::~HTMLPlugInElement): (WebCore::HTMLPlugInElement::detach): (WebCore::HTMLPlugInElement::getInstance): (WebCore::HTMLPlugInElement::parseMappedAttribute): (WebCore::HTMLPlugInElement::getNPObject):
  • html/HTMLPlugInElement.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear):
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::pageDestroyed): (WebCore::FramePrivate::FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/gtk/FrameGtk.cpp:
  • page/mac/FrameMac.mm:
  • page/qt/FrameQt.cpp:
  • page/win/FrameWin.cpp: (WebCore::computePageRectsForFrame):
2:06 AM Changeset in webkit [35589] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

Reviewed by Cameron Zwarich.

Speculative fix for an error I keep seeing in my Cygwin build

  • Scripts/webkitdirs.pm: make determineConfigurationProductDir() always call determineConfiguration() even on cygwin
12:09 AM Changeset in webkit [35588] by mitz@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by Mark Rowe.

  • fix an assertion failure in Cache::setCapacities()
  • Misc/WebKitSystemBits.h: Changed the return type of WebMemorySize() to uint64_t.
  • Misc/WebKitSystemBits.m: (WebMemorySize):
  • WebView/WebView.mm: (+[WebView _setCacheModel:]):

Aug 5, 2008:

9:33 PM Changeset in webkit [35587] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2008-08-05 Steve Falkenburg <​sfalken@apple.com>

Fix last timer fix.
Add null check, clear timer using InterlockedExchange.


Reviewed by Alice Liu.

  • platform/win/SharedTimerWin.cpp: (WebCore::clearTimer): (WebCore::queueTimerProc): (WebCore::stopSharedTimer):
9:29 PM Changeset in webkit [35586] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-08-05 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Cameron.

  • add fast path for immediates to % operator, as we have for many other math ops


This fixes handling for a 0 divisor relative to the last patch. Only an 0.2% speedup on SunSpider but
still a 1.4x win on Oliver's prime test.


  • VM/Machine.cpp: (KJS::Machine::privateExecute):
5:57 PM Changeset in webkit [35585] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2008-08-05 Steve Falkenburg <​sfalken@apple.com>

Fix timer leak, flag.


Timers need to be deleted explicitly, even if they fire.
Also added WT_EXECUTEONLYONCE flag, since this is not a repeating timer.


Reviewed by Ada Chan.

  • platform/win/SharedTimerWin.cpp: (WebCore::queueTimerProc):
5:39 PM Changeset in webkit [35584] by cwzwarich@webkit.org
  • 5 edits in trunk

2008-08-05 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Bug 20293: Crash in JavaScript codegen for eval("const a;")
<​https://bugs.webkit.org/show_bug.cgi?id=20293>

Correctly handle constant declarations in eval code with no initializer.

JavaScriptCore:

  • kjs/nodes.cpp: (KJS::ConstDeclNode::emitCodeSingle):

LayoutTests:

  • fast/js/const-expected.txt:
  • fast/js/resources/const.js:
5:36 PM Changeset in webkit [35583] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-08-05 Anders Carlsson <​andersca@apple.com>

Pass in the correct class here.


  • WebView/WebResource.mm: (-[WebResourcePrivate dealloc]):
5:19 PM Changeset in webkit [35582] by andersca@apple.com
  • 15 edits in trunk

WebCore:

2008-08-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin.

<rdar://problem/6037398>
ER: Deallocate WebKit objects on the main thread, even if released on secondary thread


Add calls to WebCoreObjCScheduleDeallocateOnMainThread in dealloc methods of objects we expose.


  • bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor dealloc]):
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject dealloc]):
  • platform/mac/SharedBufferMac.mm: (-[WebCoreSharedBufferData dealloc]):

WebKit/mac:

2008-08-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin.

<rdar://problem/6037398>
ER: Deallocate WebKit objects on the main thread, even if released on secondary thread


Add calls to WebCoreObjCScheduleDeallocateOnMainThread in dealloc methods of objects we expose.

  • Carbon/CarbonWindowAdapter.m: (-[CarbonWindowAdapter dealloc]):
  • History/WebBackForwardList.mm: (-[WebBackForwardList dealloc]):
  • History/WebHistoryItem.mm: (-[WebHistoryItem dealloc]):
  • Misc/WebElementDictionary.mm: (+[WebElementDictionary initialize]): (-[WebElementDictionary dealloc]):
  • WebCoreSupport/WebEditorClient.mm: (-[WebEditCommand dealloc]):
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebArchive.mm: (-[WebArchivePrivate dealloc]):
  • WebView/WebDataSource.mm: (-[WebDataSourcePrivate dealloc]):
  • WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLView dealloc]):
  • WebView/WebResource.mm: (-[WebResourcePrivate dealloc]):
4:43 PM Changeset in webkit [35581] by andersca@apple.com
  • 9 edits
    2 deletes in trunk

../../../../../../WebCore:

2008-08-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin.

Move the main thread deallocator here from WebKit.


  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/WebCoreObjCExtras.c: (method_getImplementation): (deallocCallback): (WebCoreObjCScheduleDeallocateOnMainThread):
  • platform/mac/WebCoreObjCExtras.h:

../../../../../../WebKit:

2008-08-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin.

Remove MainThreadObjectDeallocator.{h|mm}.


  • WebKit.xcodeproj/project.pbxproj:

../../../../../../WebKit/mac:

2008-08-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin.

Remove MainThreadObjectDeallocator.{h|mm}.

  • WebView/MainThreadObjectDeallocator.h: Removed.
  • WebView/MainThreadObjectDeallocator.mm: Removed.


  • WebView/WebView.mm: (-[WebView dealloc]): Call WebCoreObjCScheduleDeallocateOnMainThread instead.
4:01 PM Changeset in webkit [35580] by dino@apple.com
  • 16 edits
    4 adds in trunk/WebCore

Parse CSS Animations, including the new
-webkit-animation properties and the @-webkit-keyframes rule.
Adds some new interfaces for the style rules.

​https://bugs.webkit.org/show_bug.cgi?id=20088

Reviewed by David Hyatt.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:

build config for new files

  • css/tokenizer.flex:
  • css/CSSGrammar.y:
  • css/CSSParser.cpp:
  • css/CSSParser.h:

new @-webkit-keyframes parsing

  • css/CSSPropertyNames.in:

-webkit-animation properties

  • css/CSSRule.h:
  • css/CSSStyleSelector.cpp:
  • css/CSSStyleSelector.h:
  • css/CSSValueKeywords.in:
  • css/StyleBase.h:
  • css/WebKitCSSKeyframeRule.cpp: Added.
  • css/WebKitCSSKeyframeRule.h: Added.
  • css/WebKitCSSKeyframesRule.cpp: Added.
  • css/WebKitCSSKeyframesRule.h: Added.
3:57 PM Changeset in webkit [35579] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2008-08-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin.

Make the main thread object deallocator work with subclasses.


  • WebView/MainThreadObjectDeallocator.h:
  • WebView/MainThreadObjectDeallocator.mm: (deallocCallback): Call the correct dealloc method.


(scheduleDeallocateOnMainThread):
Store both the class and the instance, so we know which dealloc method to call.


  • WebView/WebView.mm: (-[WebViewPrivate dealloc]): Schedule deallocation on the main thread.
3:50 PM Changeset in webkit [35578] by adachan@apple.com
  • 4 edits in trunk/WebKit/win

Add a getter for CFURLRequestRef in WebMutableURLRequest.

Reviewed by Anders Carlsson.

  • Interfaces/IWebMutableURLRequestPrivate.idl:
  • WebMutableURLRequest.cpp: (WebMutableURLRequest::cfRequest):
  • WebMutableURLRequest.h:
3:35 PM Changeset in webkit [35577] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-08-05 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

  • LayoutTests fix. Log only to the Inspector because other listeners may not want XHR notifications, including DRT and the numerous tests that don't expect them.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
3:34 PM Changeset in webkit [35576] by timothy@apple.com
  • 5 edits in trunk/WebCore

Makes DOM attribute editing start on double-click to match the styles
pane. Links in attributes are now triggered with a single click again.

​https://bugs.webkit.org/show_bug.cgi?id=20281

Reviewed by Adam Roben.

  • English.lproj/localizedStrings.js: Removed some strings.
  • page/inspector/ElementsPanel.js: (WebInspector.DOMNodeTreeElement.prototype.onattach): Call _preventFollowingLinksOnDoubleClick. (WebInspector.DOMNodeTreeElement.prototype._preventFollowingLinksOnDoubleClick): Renamed from _makeURLsActivateOnModifiedClick. Simply sets the preventFollowOnDoubleClick property on all links. (WebInspector.DOMNodeTreeElement.prototype.onselect): Removed _selectedByCurrentMouseDown. (WebInspector.DOMNodeTreeElement.prototype.onmousedown): Moved editing code to ondblclick. (WebInspector.DOMNodeTreeElement.prototype.ondblclick): Calls _startEditing. Removed URL check. (WebInspector.DOMNodeTreeElement.prototype._updateTitle): Calls _preventFollowingLinksOnDoubleClick.
  • page/inspector/inspector.css: (.editing): Removed the text-decoration property. (.editing, .editing *): Added the text-decoration property here so it removes underlines on child elements.
  • page/inspector/inspector.js: (WebInspector.documentClick): Removed the followOnAltClick code. Added support for preventFollowOnDoubleClick, which sets a timeout on the first click where future clicks will cancel it (double click). If the timeout isn't canceled, the link is followed.
3:10 PM Changeset in webkit [35575] by Antti Koivisto
  • 3 edits in trunk/WebCore

2008-08-05 Antti Koivisto <Antti Koivisto>

Reviewed by Sam Weinig.

<rdar://problem/6112219> Video in standalone media document flashes when navigating away

When navigating out from a page, MediaPlayer was set invisible and then immediately
made visible again causing flicker in some cases.


The document is not yet marked being in page cache when willSaveToCache() is called.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::willSaveToCache):
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::updatePlayer):
3:06 PM Changeset in webkit [35574] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • fix typo
  • page/mac/FrameMac.mm:
3:04 PM Changeset in webkit [35573] by mitz@apple.com
  • 3 edits in trunk/WebKit/mac

Reviewed by Mark Rowe and Anders Carlsson.

  • fix WebMemorySize() reporting a value capped at 2GB
  • misc/WebKitSystemBits.m: (WebMemorySize): Changed to return the max_mem field, which, unlike memory_size, is not capped at 2GB.
  • WebView/WebView.mm: (+[WebView _setCacheModel:]): Made the cache sizes for over 2GB RAM the same as for 2GB, so that behavior on machines that have more than 2GB RAM is not affected by the fix to WebMemorySize().
3:03 PM Changeset in webkit [35572] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • try to fix the 64-bit build
  • page/mac/FrameMac.mm:
2:41 PM Changeset in webkit [35571] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-08-05 Alp Toker <​alp@nuanti.com>

Remove leftover mark pragma from r35568 to fix compiler warning spew.

  • rendering/style/RenderStyle.h:
2:33 PM Changeset in webkit [35570] by alp@webkit.org
  • 3 edits in trunk

2008-08-05 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=19045
[gtk] ./configure doesn't check for x toolkit availability

Check for the .pc file for Xt instead of hard coding -lXt in the
GNUmakefile.am.

Thanks to Dominik Röttsches for the initial patch.

  • GNUmakefile.am:
  • configure.ac:
12:15 PM Changeset in webkit [35569] by kmccullough@apple.com
  • 1 edit
    1 add in trunk/WebCore

2008-08-05 Kevin McCullough <​kmccullough@apple.com>

  • Added a test that checks for several edge cases (see description in test.
  • manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html: Added.
12:08 PM Changeset in webkit [35568] by dino@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Dave Hyatt

Add support for CSS Animation properties to RenderStyle
​https://bugs.webkit.org/show_bug.cgi?id=20068

(also fix some minor whitespace issues and remove debugging code)

  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSStyleSelector.cpp:
  • page/AnimationController.cpp:
  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:
12:07 PM Changeset in webkit [35567] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-08-05 Kevin McCullough <​kmccullough@apple.com>

  • Updated a manual test to be an accurate description of what it is actually testing.
  • manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html:
12:06 PM Changeset in webkit [35566] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

2008-08-05 Steve Falkenburg <​sfalken@apple.com>

Don't invalidate a WebView in the process of being closed when prefs change.


Reviewed by Ada Chan.

  • WebView.cpp: (WebView::notifyPreferencesChanged):
11:00 AM Changeset in webkit [35565] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-08-05 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/5732836> XMLHttpRequest: Inspector should show network
activity/XHR in Console (17233)

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
10:48 AM Changeset in webkit [35564] by dino@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix the ChangeLog that was corrupted by r34545.

9:47 AM Changeset in webkit [35563] by timothy@apple.com
  • 2 edits in trunk/WebCore

Makes the selection surround just the name or value that was
double clicked when editing CSS properties. This regressed when
the Inspector started using focus/blur events, since a focus on
a content editable region changes the selection.

​https://bugs.webkit.org/show_bug.cgi?id=20280

Reviewed by Adam Roben.

  • page/inspector/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.startEditing): Change the selection after calling WebInspector.startEditing, since WebInspector.startEditing will set an initial selection due to a focus event.
9:47 AM Changeset in webkit [35562] by timothy@apple.com
  • 2 edits in trunk/WebCore

Changes the editing behavior in the Inspector to commit changes
when focus is lost, instead of reverting the changes.

​https://bugs.webkit.org/show_bug.cgi?id=20279

Reviewed by Adam Roben.

  • page/inspector/inspector.js: (WebInspector.startEditing): Call editingCommitted in blurEventListener instead of editingCancelled.
9:47 AM Changeset in webkit [35561] by timothy@apple.com
  • 4 edits in trunk/WebCore

Adds the ability to increment/decrement numbers in editable style
properties with the arrow and page keys.

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=20273

  • page/inspector/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateAll): Updates all properties in the current section, or all sections depending in the argument passed. (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled): Call updateAll instead of having duplicate code. (WebInspector.StylePropertyTreeElement.prototype.startEditing): Assign the list element's handleKeyEvent to editingKeyDown. (WebInspector.StylePropertyTreeElement.prototype.editingKeyDown): Handles the Up and Down arrows keys. Finds the word based on the selection and extracts the number, prefix and suffix. Increments or decrements the number based on the key and modifiers. Replaces the original word with the new value and selects it. Also applies the style so the page reflects the changes live. (WebInspector.StylePropertyTreeElement.prototype.editingEnded): Delete the handleKeyEvent and originalCSSText properties. (WebInspector.StylePropertyTreeElement.prototype.editingCancelled): If originalCSSText exists, set the cssText to that value and call updateAll. Otherwise just call updateTitle like before. (WebInspector.StylePropertyTreeElement.prototype.editingCommitted): Factored out the style applying code to applyStyleText. (WebInspector.StylePropertyTreeElement.prototype.applyStyleText): Factored out from editingCommitted. Takes an argument that specifies if the interface should be updated when the style is applied.
  • page/inspector/inspector.js: (WebInspector.startEditing): Call the original key handler, if one existed before interrupting key events.
  • page/inspector/utilities.js: (getStyleTextWithShorthands): Helper to return CSS text that preserves shorthand values, since the cssText property only outputs longhands.
9:46 AM Changeset in webkit [35560] by timothy@apple.com
  • 4 edits in trunk/WebCore

Factors out the TextPrompt.scanBackwards function into a generic
helper function on the Node prototype, named rangeOfWord.

Reviewed by Adam Roben.

  • page/inspector/Console.js: (WebInspector.Console.prototype.completions): Use rangeOfWord.
  • page/inspector/TextPrompt.js: (WebInspector.TextPrompt.prototype.complete): Ditto. (WebInspector.TextPrompt.prototype.scanBackwards): Removed.
  • page/inspector/utilities.js: (Node.prototype.rangeOfWord): Added. Copied from TextPrompt.scanBackwards, and added a direction argument allowing scanning forward, backward or both directions from the offset.
9:46 AM Changeset in webkit [35559] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes a bug where the property toggle button would not be hidden
during editing.

Reviewed by Adam Roben.

  • page/inspector/inspector.css: (li.editing .swatch, li.editing .enabled-button): Make the display !important, since a more specific rule for .enabledbutton overrides display.
6:40 AM Changeset in webkit [35558] by vestbo@webkit.org
  • 4 edits in trunk/WebKit/qt

2008-08-05 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Move event handling of the return-key from EditorClientQt to QWebPage.

​https://bugs.webkit.org/show_bug.cgi?id=20191

This is a first step in refactoring the big switch block
in EditorClientQt::handleKeyboardEvent to using WebActions
instead.

The new logic uses two new StandardKeys from QKeySequence:

  • InsertParagraphSeparator
  • InsertLineSeparator

Which translate to the commands InsertNewline and InsertLineBreak
respectivly. On Windows/X11 pressing the shift modifier will invoke
the latter action. For Mac this is triggered by pressing the meta
modifier (Ctrl).

Initial patch by: Erik Bunce

5:51 AM S60CheckoutAndBuild edited by kvmayank@gmail.com
(diff)
4:00 AM Changeset in webkit [35557] by cwzwarich@webkit.org
  • 3 edits
    3 adds in trunk

2008-08-05 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Roll out r35555 because of correctness issues.

JavaScriptCore:

  • VM/Machine.cpp: (KJS::Machine::privateExecute):

LayoutTests:

  • fast/js/mod-crash-expected.txt: Added.
  • fast/js/mod-crash.html: Added.
  • fast/js/resources/mod-crash.js: Added.
12:40 AM Changeset in webkit [35556] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Geoffrey Garen.

  • remove redundant #imports from FrameMac.mm
  • page/mac/FrameMac.mm:
12:15 AM Changeset in webkit [35555] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-08-05 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Geoff.


  • add fast path for immediates to % operator, as we have for many other math ops


0.6% speedup on SunSpider. 1.4x speedup on a prime testing torture test that Oliver whipped up.

  • VM/Machine.cpp: (KJS::Machine::privateExecute):
Note: See TracTimeline for information about the timeline view.