Timeline
Aug 17, 2008:
- 8:21 PM Changeset in webkit [35814] by
-
- 3 edits in trunk/WebCore
Complete in scope variables in the Console when paused.
Reviewed by Geoffrey Garen.
- page/inspector/Console.js: (WebInspector.Console.prototype.completions): If the expressionString is null or empty and the debugger is paused, call variablesInScopeForSelectedCallFrame to get an object that declares all the in scope variables. That way "top level" expressions are completed.
- page/inspector/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.variablesInScopeForSelectedCallFrame): Return an object that has all the variables that are in scope for the selected call frame. The value of each property is just true. The return object is useful for quick lookups or auto completion.
- 7:42 PM Changeset in webkit [35813] by
-
- 7 edits in trunk
2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej.
Change the counting of constants so that preincrement and predecrement of
const local variables are considered unexpected loads.
- kjs/nodes.cpp: (KJS::PrefixResolveNode::emitCode):
- kjs/nodes.h: (KJS::ScopeNode::neededConstants):
LayoutTests:
- fast/js/deep-recursion-test.html:
- 4:38 PM Changeset in webkit [35812] by
-
- 3 edits3 adds in trunk
<rdar://problem/6150322> In Gmail, a crash occurs at KJS::Machine::privateExecute() when applying list styling to text after a quote had been removed
<https://bugs.webkit.org/show_bug.cgi?id=20386>
Reviewed by Cameron Zwarich.
This crash was caused by "depth()" incorrectly determining the scope depth
of a 0 depth function without a full scope chain. Because such a function
would not have an activation the depth function would return the scope depth
of the parent frame, thus triggering an incorrect unwind. Any subsequent
look up that walked the scope chain would result in incorrect behaviour,
leading to a crash or incorrect variable resolution. This can only actually
happen in try...finally statements as that's the only path that can result in
the need to unwind the scope chain, but not force the function to need a
full scope chain.
- 2:34 PM Changeset in webkit [35811] by
-
- 2 edits in trunk/WebCore
2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Not reviewed.
Speculative Qt build fix.
- bridge/qt/qt_runtime.cpp: (KJS::Bindings::convertValueToQVariant): (KJS::Bindings::QtRuntimeMethod::QtRuntimeMethod):
- 2:27 PM Changeset in webkit [35810] by
-
- 5 edits in trunk/JavaScriptCore
2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej.
Bug 20419: Remove op_jless
<https://bugs.webkit.org/show_bug.cgi?id=20419>
Remove op_jless, which is rarely used now that we have op_loop_if_less.
- VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitJumpIfTrue):
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- VM/Opcode.h:
- 2:18 PM Changeset in webkit [35809] by
-
- 2 edits in trunk/JavaScriptCore
2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Dan Bernstein.
Fix a typo in r35807 that is also causing build failures for
non-AllInOne builds.
- kjs/NumberConstructor.cpp:
- 1:28 PM Changeset in webkit [35808] by
-
- 9 edits in trunk
JavaScriptGlue:
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Updated project files to XCode 3.1.
- JavaScriptGlue.xcodeproj/project.pbxproj:
WebCore:
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Updated project files to XCode 3.1.
- manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj:
WebKit:
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Updated project files to XCode 3.1.
- WebKit.xcodeproj/project.pbxproj:
WebKitTools:
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Updated project files to XCode 3.1.
- DrawTest/DrawTest.xcodeproj/project.pbxproj:
- WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
- 1:23 PM Changeset in webkit [35807] by
-
- 85 edits in trunk
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Made room for a free word in JSCell.
SunSpider says no change.
I changed JSCallbackObjectData, Arguments, JSArray, and RegExpObject to
store auxiliary data in a secondary structure.
I changed InternalFunction to store the function's name in the property
map.
I changed JSGlobalObjectData to use a virtual destructor, so WebCore's
JSDOMWindowBaseData could inherit from it safely. (It's a strange design
for JSDOMWindowBase to allocate an object that JSGlobalObject deletes,
but that's really our only option, given the size constraint.)
I also added a bunch of compile-time ASSERTs, and removed lots of comments
in JSObject.h because they were often out of date, and they got in the
way of reading what was actually going on.
Also renamed JSArray::getLength to JSArray::length, to match our style
guidelines.
WebCore:
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Made room for a free word in JSCell.
Changed JSDOMWindowBase to store its auxiliary data in a subclass of
JSGlobalData, so the two could share a pointer.
Added a bunch of ASSERTs, to help catch over-sized objects.
WebKit/mac:
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Made room for a free word in JSCell.
(Updated for JavaScriptCore changes.)
- 12:57 AM Changeset in webkit [35806] by
-
- 10 edits in trunk/JavaScriptCore
2007-08-16 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Sped up property access for array.length and string.length by adding a
mechanism for returning a temporary value directly instead of returning
a pointer to a function that retrieves the value.
Also removed some unused cruft from PropertySlot.
SunSpider says 0.5% - 1.2% faster.
NOTE: This optimization is not a good idea in general, because it's
actually a pessimization in the case of resolve for assignment,
and it may get in the way of other optimizations in the future.
Aug 16, 2008:
- 10:06 PM Changeset in webkit [35805] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Geoffrey Garen.
Disable dead code stripping in debug builds.
- Configurations/Base.xcconfig:
- JavaScriptCore.xcodeproj/project.pbxproj:
- 8:28 PM Changeset in webkit [35804] by
-
- 3 edits in trunk/WebCore
2008-08-15 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
Disable dead code stripping in debug builds.
- Configurations/Base.xcconfig:
- WebCore.xcodeproj/project.pbxproj:
Aug 15, 2008:
- 11:53 PM Changeset in webkit [35803] by
-
- 2 edits in trunk/JavaScriptCore
<rdar://problem/6143072> FastMallocZone's enumeration code makes assumptions about handling of remote memory regions that overlap
Reviewed by Oliver Hunt.
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_Central_FreeList::enumerateFreeObjects): Don't directly compare pointers mapped into the local process with
a pointer that has not been mapped. Instead, calculate a local address for the pointer and compare with that.
(WTF::TCMallocStats::FreeObjectFinder::findFreeObjects): Pass in the remote address of the central free list so that it can
be used when calculating local addresses.
(WTF::TCMallocStats::FastMallocZone::enumerate): Ditto.
- 11:48 PM Changeset in webkit [35802] by
-
- 15 edits in trunk
<rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
Rubber-stamped by Geoff Garen.
- 3:58 PM Changeset in webkit [35801] by
-
- 6 edits in trunk/WebCore
2008-08-15 Antti Koivisto <Antti Koivisto>
Reviewed by Anders.
Don't start preloading body resources before the head is complete. This prevents
body preloads from slowing down initial display when there is limited amount
of bandwidth available.
Works by queuing up found body preloads to DocLoader and only issuing them
after document has rendering.
With bandwidth capped to 300kbit/s this speeds up cnn.com initial display by ~25% or 5s
without affecting complete load time.
- html/PreloadScanner.cpp: (WebCore::PreloadScanner::PreloadScanner): (WebCore::PreloadScanner::scanningBody): (WebCore::PreloadScanner::emitTag): (WebCore::PreloadScanner::emitCSSRule):
- html/PreloadScanner.h:
- loader/DocLoader.cpp: (WebCore::DocLoader::preload): (WebCore::DocLoader::checkForPendingPreloads): (WebCore::DocLoader::requestPreload):
- loader/DocLoader.h:
- loader/loader.cpp: (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail):
- 2:08 PM Changeset in webkit [35800] by
-
- 2 edits in trunk/WebCore
Use item's computed style if the render style is 0 before falling back to the <select>'s style.
This way style set on an <hr> within a <select> will be honored.
Reviewed by Dave Hyatt and Dan Bernstein.
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::itemStyle):
- 1:48 PM Changeset in webkit [35799] by
-
- 3 edits in trunk/WebCore
2008-08-15 Antti Koivisto <Antti Koivisto>
Reviewed by Oliver.
Some loader performance tweaks:
- Make stylesheets highest priority instead of scripts. We block script execution on stylesheets. Especially if a stylesheet @imports other stylesheets it is important to get them to the front of the queue to not delay rendering.
- Issue the first resource load for a host immediately even if the resource is low priority. TCP connection setup can take long time when latency is high so it is good to get started early.
- When the document is fully parsed and stylesheets have been loaded there is no need to keep managing the load queues. Issue remaining loads to the network layer.
- loader/loader.cpp: (WebCore::Loader::determinePriority): (WebCore::Loader::load): (WebCore::Loader::Host::servePendingRequests):
- loader/loader.h:
- 11:35 AM Changeset in webkit [35798] by
-
- 2 edits in trunk/WebCore
Detach the script debugger when the Web Inspector's window closes.
This has always been the intended design, but never fully implemented.
Reviewed by Adam Roben.
- page/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): Call stopDebugging() if the window is no longer visible.
- 11:27 AM Changeset in webkit [35797] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Tim Hatcher.
- update results for console.dir
- fast/dom/Window/window-properties-expected.txt:
- 11:12 AM Changeset in webkit [35796] by
-
- 7 edits in trunk/WebKit/qt
2008-08-15 Håvard Wall <hwall@trolltech.com>
Reviewed by Simon.
Fixes: compile with QT_NO_UNDOCOMMAND/STACK
- 11:12 AM Changeset in webkit [35795] by
-
- 2 edits in trunk/WebKit/qt
2008-08-15 Håvard Wall <hwall@trolltech.com>
Reviewed by Simon.
Fixes: compile with QT_NO_STYLE_STYLESHEET
- 11:12 AM Changeset in webkit [35794] by
-
- 2 edits in trunk/WebKit/qt
Håvard Wall <hwall@trolltech.com>
Fixes: compile with QT_NO_SHORTCUT
- 11:12 AM Changeset in webkit [35793] by
-
- 9 edits in trunk
2008-08-15 Håvard Wall <hwall@trolltech.com>
Reviewed by Simon.
Fixes: compile with QT_NO_CONTEXTMENU
- 11:11 AM Changeset in webkit [35792] by
-
- 7 edits in trunk
2008-08-15 Håvard Wall <hwall@trolltech.com>
Reviewed by Simon.
Fixes: compile with QT_NO_WHEELEVENT
- 11:11 AM Changeset in webkit [35791] by
-
- 3 edits in trunk/WebKit/qt
Håvard Wall <hwall@trolltech.com>
Fixes: compile with QT_NO_PRINTER
- 11:10 AM Changeset in webkit [35790] by
-
- 3 edits in trunk/WebKit/qt
2008-08-15 David Boddie <dboddie@trolltech.com>
Reviewed by Simon.
Doc: Added documentation for default property values.
- 11:10 AM Changeset in webkit [35789] by
-
- 2 edits in trunk/WebKit/qt
David Boddie <dboddie@trolltech.com>
Doc: Renamed snippets that appear in the code directory.
- 10:48 AM Changeset in webkit [35788] by
-
- 7 edits in trunk/WebCore
Fixed Bug 20210: Console groups are incorrect when closing and reopening the Inspector
Reviewed by Tim Hatcher.
- page/Console.cpp: (WebCore::Console::group): (WebCore::Console::groupEnd):
- page/Console.h: (WebCore::): Removed GroupTitleMessageLevel. Added StartGroupMessaageLevel and EndGroupMessageLevel.
- page/InspectorController.cpp: (WebCore::InspectorController::startGroup): Increments group level by one and adds console message with StartGroupMessaageLevel. (WebCore::InspectorController::endGroup): Decrements group level by one and adds console message with EndGroupMessaageLevel.
- page/InspectorController.h:
- page/inspector/Console.js: (WebInspector.Console.prototype.addMessage): Creates new ConsoleGroup if the message is StartGroupMessaageLevel. (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleGroup.prototype.addMessage):
- page/inspector/inspector.js:
- 10:35 AM Changeset in webkit [35787] by
-
- 8 edits in trunk/WebCore
Adds support for console.dir to the Inspector
Reviewed by Tim Hatcher.
- bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::dir):
- page/Console.cpp: (WebCore::Console::dir):
- page/Console.h: Added ObjectMessageLevel.
- page/Console.idl: Added console.dir.
- page/inspector/Console.js: (WebInspector.ConsoleMessage.prototypet.toMessageElement): Creates an ObjectPropertiesSection if the MessageLevel is Object.
- page/inspector/ObjectPropertiesSection.js: "in" operator can't be used on primitive data types.
- page/inspector/inspector.css:
- 10:06 AM Changeset in webkit [35786] by
-
- 2 edits in trunk/WebCore
Adds support for clear() in the Inspector console.
Reviewed by Tim Hatcher.
- page/inspector/Console.js:
- 10:02 AM Changeset in webkit [35785] by
-
- 2 edits in trunk/WebCore
Cmd-F on Mac or Ctrl-F on other platforms now focus the search field.
Platform distinction and modifier key matching adjusted
by Daniel Jalkut <jalkut@red-sweater.com>
Bug 16313: text search (find) keybindings should work in the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=16313
Reviewed by Tim Hatcher.
- page/inspector/inspector.js: Added a case for the F key
- 9:50 AM Changeset in webkit [35784] by
-
- 2 edits in trunk/WebCore
Fix for error when the string doesn't contain a webkit-profile link.
Reviewed by Tim Hatcher.
- page/inspector/inspector.js:
- 9:33 AM Changeset in webkit [35783] by
-
- 3 edits1 add in trunk/WebCore
Fixes two bugs where JavaScript could be executed from the page
while the debugger is paused.
The first issue was JSLazyEventListener not checking the paused
state before parsing the code.
The second issue was with the PageGroup version of
JavaScriptDebugServer::setJavaScriptPaused always passing false
to the Page version of JavaScriptDebugServer::setJavaScriptPaused,
and not the paused argument.
Reviewed by Adam Roben.
- bindings/js/JSEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): Check the paused state of the ScriptController. Return early if paused.
- manual-tests/inspector/debugger-execution-while-paused.html: Added.
- page/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::setJavaScriptPaused): Pass the paused argument to the Page version of setJavaScriptPaused.
- 7:55 AM Changeset in webkit [35782] by
-
- 2 edits in trunk/JavaScriptCore
Fix the 64-bit build.
Add extra cast to avoid warnings about loss of precision when casting from
JSValue* to an integer type.
- kjs/JSImmediate.h:
(KJS::JSImmediate::intValue):
(KJS::JSImmediate::uintValue):
- 4:59 AM Changeset in webkit [35781] by
-
- 2 edits in trunk/JavaScriptCore
Still fixing Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Added OpaqueJSString to yet another place.
- 4:41 AM Changeset in webkit [35780] by
-
- 1 edit in trunk/JavaScriptCore/kjs/JSImmediate.h
Windows build fix
- 4:14 AM Changeset in webkit [35779] by
-
- 1 edit1 add in trunk/JavaScriptCore
Trying to fix non-Apple builds.
- ForwardingHeaders/JavaScriptCore/OpaqueJSString.h: Added.
- 3:42 AM Changeset in webkit [35778] by
-
- 2 edits in trunk/JavaScriptCore
2008-08-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Allow JSImmediate to hold 31 bit signed integer immediate values. The low two bits of a
JSValue* are a tag, with the tag value 00 indicating the JSValue* is a pointer to a
JSCell. Non-zero tag values used to indicate that the JSValue* is not a real pointer,
but instead holds an immediate value encoded within the pointer. This patch changes the
encoding so both the tag values 01 and 11 indicate the value is a signed integer, allowing
a 31 bit value to be stored. All other immediates are tagged with the value 10, and
distinguished by a secondary tag.
Roughly +2% on SunSpider.
- kjs/JSImmediate.h: Encoding of JSImmediates has changed - see comment at head of file for
descption of new layout.
- 3:18 AM Changeset in webkit [35777] by
-
- 4 edits in trunk/JavaScriptCore
More build fixes.
- API/OpaqueJSString.h: Add a namespace to friend declaration to appease MSVC.
- API/JSStringRefCF.h: (JSStringCreateWithCFString) Cast UniChar* to UChar* explicitly.
- JavaScriptCore.exp: Added OpaqueJSString::create(const KJS::UString&) to fix WebCore build.
- 1:32 AM Changeset in webkit [35776] by
-
- 5 edits in trunk/JavaScriptCore
Build fix.
- JavaScriptCore.xcodeproj/project.pbxproj: Marked OpaqueJSString as private
- kjs/identifier.cpp: (KJS::Identifier::checkSameIdentifierTable):
- kjs/identifier.h: (KJS::Identifier::add): Since checkSameIdentifierTable is exported for debug build's sake, gcc wants it to be non-inline in release builds, too.
- JavaScriptCore.exp: Don't export inline OpaqueJSString destructor.
- 12:43 AM Changeset in webkit [35775] by
-
- 19 edits2 adds in trunk
Reviewed by Geoff Garen.
JSStringRef is created context-free, but can get linked to one via an identifier table,
breaking an implicit API contract.
Made JSStringRef point to OpaqueJSString, which is a new string object separate from UString.
Aug 14, 2008:
- 11:15 PM Changeset in webkit [35774] by
-
- 2 edits in trunk/WebKit/win
Update cache capacities to match values used on Mac.
Reviewed by Dan Bernstein.
- WebView.cpp: (WebView::setCacheModel):
- 10:10 PM Changeset in webkit [35773] by
-
- 2 edits in trunk/WebCore
wx !USE(WXGC) build fix. This is necessary until we find a way to replace GDI with an alternative that performs reasonably well. (GDI+ is too slow in many cases.)
- 5:53 PM Changeset in webkit [35772] by
-
- 2 edits in trunk/WebCore
2008-08-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele.
Fix for https://bugs.webkit.org/show_bug.cgi?id=20388
<video> elements on Windows never becomes visible when a page is restored from the cache
Always pass "set" calls down to MediaPlayerPrivate instead of only when the
value is different from the cached value. Let the implementation decide when
to avoid work because nothing has changed.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::setVolume): (WebCore::MediaPlayer::setRate): (WebCore::MediaPlayer::setRect): (WebCore::MediaPlayer::setVisible):
- 5:44 PM Changeset in webkit [35771] by
-
- 4 edits in trunk/WebKit/win
2008-08-14 Sam Weinig <sam@webkit.org>
Reviewed by Jon Honeycutt.
Add WebView SPI to set HTMLTokenizer yielding parameters.
- Interfaces/IWebViewPrivate.idl:
- WebView.cpp: (WebView::setCustomHTMLTokenizerTimeDelay): (WebView::setCustomHTMLTokenizerChunkSize):
- WebView.h:
- 4:58 PM Changeset in webkit [35770] by
-
- 1 edit in trunk/WebCore/ChangeLog
Add the bug URL to the ChangeLog.
- 4:57 PM Changeset in webkit [35769] by
-
- 2 edits1 add in trunk/WebCore
Make Firebug command line API respect predefined variables.
Reviewed by Tim Hatcher.
- page/inspector/Console.js:
- 4:45 PM Changeset in webkit [35768] by
-
- 2 edits2 adds in trunk/LayoutTests
2008-08-14 Simon Fraser <Simon Fraser>
Fix testcase and add pixel results for testcase in
https://bugs.webkit.org/show_bug.cgi?id=20367
- platform/mac/fast/css/font-face-in-media-rule-expected.checksum: Added.
- platform/mac/fast/css/font-face-in-media-rule-expected.png: Added.
- platform/mac/fast/css/font-face-in-media-rule-expected.txt:
- 4:33 PM Changeset in webkit [35767] by
-
- 9 edits in trunk
WebCore:
2008-08-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen and Timothy Hatcher.
Allow programatically setting the HTMLTokenizers time delay and chunk size
which are used for determining how aggressively we yield.
- WebCore.base.exp:
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::begin): (WebCore::HTMLTokenizer::continueProcessing):
- html/HTMLTokenizer.h:
- page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::setCustomHTMLTokenizerTimeDelay): (WebCore::Page::setCustomHTMLTokenizerChunkSize):
- page/Page.h: (WebCore::Page::hasCustomHTMLTokenizerTimeDelay): (WebCore::Page::customHTMLTokenizerTimeDelay): (WebCore::Page::hasCustomHTMLTokenizerChunkSize): (WebCore::Page::customHTMLTokenizerChunkSize):
WebKit/mac:
2008-08-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen and Timothy Hatcher.
Add WebView SPI to set HTMLTokenizer yielding parameters.
- WebView/WebView.mm: (-[WebView _setCustomHTMLTokenizerTimeDelay:]): (-[WebView _setCustomHTMLTokenizerChunkSize:]):
- WebView/WebViewPrivate.h:
- 4:20 PM Changeset in webkit [35766] by
-
- 7 edits in trunk/WebCore
Reviewed by Beth.
Move us one step closer to cross-platform svg/graphics code
- WebCore.xcodeproj/project.pbxproj:
- html/CanvasStyle.cpp:
- platform/graphics/Color.cpp: (WebCore::colorWithOverrideAlpha):
- platform/graphics/Color.h:
- svg/graphics/cg/CgSupport.cpp: (WebCore::applyStrokeStyleToContext): (WebCore::strokeBoundingBox):
- svg/graphics/cg/SVGPaintServerSolidCg.cpp: (WebCore::SVGPaintServerSolid::setup):
- 4:19 PM Changeset in webkit [35765] by
-
- 4 edits in trunk/WebCore
Reviewed by Alexey.
Remove un-need includes from HTMLCanvas and use the
Gradient platform abstraction in one place in CanvasStyle
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fillRect):
- html/CanvasStyle.cpp:
- html/HTMLCanvasElement.cpp:
- 4:19 PM Changeset in webkit [35764] by
-
- 2 edits in trunk/WebCore
Reviewed by Alexey.
Clean up GlyphBuffer.h, removing more #ifdefs
- platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::glyphAt): (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add):
- 4:19 PM Changeset in webkit [35763] by
-
- 6 edits in trunk/WebCore
Reviewed by Sam.
Clean up AffineTransform.h, removing #ifdefs
- platform/graphics/AffineTransform.h:
- platform/graphics/cairo/AffineTransformCairo.cpp:
- platform/graphics/cg/AffineTransformCG.cpp:
- platform/graphics/qt/AffineTransformQt.cpp:
- platform/graphics/wx/AffineTransformWx.cpp:
- 4:12 PM Changeset in webkit [35762] by
-
- 4 edits in trunk/WebCore
2008-08-14 Dan Bernstein <mitz@apple.com>
- fix non-CG builds by adding an ImageSource::frameSizeAtIndex() that returns size().
- platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameSizeAtIndex):
- platform/graphics/qt/ImageSourceQt.cpp: (WebCore::ImageSource::frameSizeAtIndex):
- platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::frameSizeAtIndex):
- 4:08 PM Changeset in webkit [35761] by
-
- 6 edits in trunk/WebCore
2008-08-14 Dan Bernstein <mitz@apple.com>
Reviewed by Brady Eidson.
- fix <rdar://problem/5993323> REGRESSION (r34210): Apple.com favicon appears stretched/clipped
- platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage): Added initialization of m_hasUniformFrameSize. (WebCore::BitmapImage::cacheFrame): Added code to get the size of the cached frame for use in decoded size computation and for setting m_hasUniformFrameSize. (WebCore::BitmapImage::currentFrameSize): Added. (WebCore::BitmapImage::dataChanged): Added code to reset m_hasUniformFrameSize.
- platform/graphics/BitmapImage.h: Added currentFrameSize() and m_hasUniformFrameSize.
- platform/graphics/ImageSource.h: Added frameSizeAtIndex().
- platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw): Changed to use currentFrameSize(). This fixes the bug, which resulted from assuming that the frame being drawn was the same size as the first frame.
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::frameSizeAtIndex): Renamed size() to this and changed to get the size of the frame at the given index. (WebCore::ImageSource::size): Added. Returns frameSizeAtIndex(0).
- 4:04 PM Changeset in webkit [35760] by
-
- 3 edits2 adds in trunk
2008-08-13 Simon Fraser <Simon Fraser>
Reviewed by Eric Seidel
Fix @font-face inside @media rule crash.
https://bugs.webkit.org/show_bug.cgi?id=20367
Test: fast/css/font-face-in-media-rule.html
- css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::addRulesFromSheet):
- 3:52 PM Changeset in webkit [35759] by
-
- 6 edits in trunk/WebCore
wx build fixes after recent changes to Canvas and Image classes.
- 12:26 PM Changeset in webkit [35758] by
-
- 2 edits in trunk/WebCore
2008-08-14 Maxime Britto <britto@apple.com>
Reviewed by Sam Weinig.
rdar://6102511
When pan-scrolling, typing on the keyboard should either stop the pan scroll or be ignored
IE and FF are both preventing the keyboard event to interact with the page while scrolling.
Some differences exist between them concerning the kind of key which is pressed :
IE7 : every key leads to a stop of the panning
FF3 : the ESC and TAB keys leads to a stop, the other keys are inactive.
For WebKit this patch is adopting the FF3 behavior except for the TAB key which is inactive too.
- page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Verifies which key has been hit and decide either to stop the pan scroll or to swallow the key event.
- 12:14 PM Changeset in webkit [35757] by
-
- 4 edits in trunk/WebCore
Gtk+/ Cairo build fix, patch by Dirk Schulze.
- 11:11 AM Changeset in webkit [35756] by
-
- 16 edits in trunk
2008-08-14 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/6115819> Notify of profile in console
- Profiles now have a unique ID so that they can be linked to the console message that announces that a profile completed.
- profiler/HeavyProfile.cpp: (KJS::HeavyProfile::HeavyProfile):
- profiler/Profile.cpp: (KJS::Profile::create): (KJS::Profile::Profile):
- profiler/Profile.h: (KJS::Profile::uid):
- profiler/ProfileGenerator.cpp: (KJS::ProfileGenerator::create): (KJS::ProfileGenerator::ProfileGenerator):
- profiler/ProfileGenerator.h:
- profiler/Profiler.cpp: (KJS::Profiler::startProfiling):
- profiler/TreeProfile.cpp: (KJS::TreeProfile::create): (KJS::TreeProfile::TreeProfile):
- profiler/TreeProfile.h:
WebCore:
2008-08-14 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/6115819> Notify of profile in console
- page/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::addProfileMessageToConsole): Called by addProfile this is the function that adds a message to the console that a profile finished.
- page/InspectorController.h:
- page/JavaScriptProfile.cpp: Expose the profiler's unique ID to match the console log to the profile in the web inspector. (WebCore::getUniqueIdCallback): (WebCore::ProfileClass):
- page/inspector/ProfilesPanel.js: Created a map of all the profiles by Id to bring up the requested profile. Also select and reveal the profile in the profile panel. And created displayTitleForProfileLink() which formats a title taking into account if it's user initiated or if there are multiples. Lasty, I put the user initiated profile in a variable.
- page/inspector/inspector.js: Make the profile title be a clickable link that will take the user to the identified profile. Also expose the count of user initiated profiles so they can be displayed in the console with the correct count.
- 10:41 AM Changeset in webkit [35755] by
-
- 3 edits in trunk/WebCore
Avoid formating ConsoleMessages twice unless the message will be
displayed in bubbles of a SourceFrame.
Reviewed by Kevin McCullough.
- page/inspector/Console.js: (WebInspector.ConsoleMessage): Only format the plain text message if the URL and line are valid and the level is error or warning. (WebInspector.ConsoleMessage.prototype.isErrorOrWarning): Added. Helper to test for error or warning level.
- page/inspector/SourceFrame.js: (WebInspector.SourceFrame.prototype.addMessage): Don't add the message if there is no message or valid line or if the msg isn't an error or warning.
- 9:12 AM Changeset in webkit [35754] by
-
- 2 edits in trunk/WebKit/mac
Fixes a bug where Safari's find banner would be permanently hidden
when attaching or closing the Web Inspector while attached.
Reviewed by Kevin McCullough.
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController close]): Carefully manipulate the WebFrameView's frame when closing to not assume the WebFrameView's frame fills the inspected WebView. (-[WebInspectorWindowController setAttachedWindowHeight:]): Carefully manipulate the WebFrameView's frame when docking to not assume the WebFrameView plus the Web Inspector WebViews fills the full inspected WebView.
- 8:07 AM Changeset in webkit [35753] by
-
- 2 edits in trunk/WebCore
2008-08-14 Jan Michael Alonzo <jmalonzo@webkit.org>
partial Gtk build fix, not reviewed
- platform/graphics/cairo/PatternCairo.cpp:
Aug 13, 2008:
- 9:49 PM Changeset in webkit [35752] by
-
- 2 edits in trunk/WebCore
2008-08-13 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlson.
Fix style issue.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::pickMedia):
- 9:26 PM Changeset in webkit [35751] by
-
- 2 edits in trunk/WebKit/mac
2008-08-13 Stephanie Lewis <Stephanie Lewis>
fix 64bit build
- WebCoreSupport/WebInspectorClient.mm:
- 8:43 PM Changeset in webkit [35750] by
-
- 2 edits in trunk/JavaScriptCore
2007-08-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Nixed a PIC branch from JSObject::getOwnPropertySlot, by forcing
fillGetterProperty, which references a global function pointer,
out-of-line.
.2% SunSpider speedup, 4.3% access-nbody speedup, 8.7% speedup on a
custom property access benchmark for objects with one property.
- kjs/JSObject.cpp: (KJS::JSObject::fillGetterPropertySlot):
- 8:16 PM Changeset in webkit [35749] by
-
- 4 edits in trunk
Versioning.
- 8:13 PM Changeset in webkit [35748] by
-
- 1 copy in tags/Safari-6528.1
New tag.
- 8:06 PM Changeset in webkit [35747] by
-
- 2 edits in trunk/WebCore
Build fix for Cairo, not reviewed. (exposed by gtk build slave)
Continue Erics build fixes, after the Image cleanup.
- 7:38 PM Changeset in webkit [35746] by
-
- 2 edits in trunk/WebCore
Build fix for Qt, not reviewed.
Don't declare eventuallyMarkAsParserCreated in a block wrapped by !USE_QXMLSTREAM.
- 7:26 PM Changeset in webkit [35745] by
-
- 2 edits in trunk/WebCore
Build fix, not reviewed.
Add ScriptElement.cpp to Gtk build.
- 7:22 PM Changeset in webkit [35744] by
-
- 10 edits2 adds in trunk/WebCore
Reviewed by Eric.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=20372
Refactor HTMLScriptElement's code into a common base class: ScriptElement.
SVGScriptElement will be converted to use ScriptElement in a follow-up patch.
This resolves code duplications and allows us to completly replace the old
SVGScriptElement (which doesn't use CachedScript, no dynamic injected scripts etc..)
As ScriptElement, doesn't actually inherit from Element, we may want to rename
it, though StyleElement uses the same naming convention, so I left it as is for now.
Eventually we'll rename both files in future.
No functional changes yet, as SVGScriptElement doesn't yet use the new base class.
- 7:17 PM Changeset in webkit [35743] by
-
- 4 edits in trunk/WebCore
Attempt to fix the Gtk build, no review.
I removed the bogus GraphicsContext::translatePoint() hack for Gtk in the process.
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
- platform/graphics/qt/GradientQt.cpp:
- platform/graphics/qt/GraphicsContextQt.cpp:
- platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozWidget):
- 7:06 PM Changeset in webkit [35742] by
-
- 2 edits in trunk/WebKit/win
Attempt to fix the windows build, not review.
- WebIconDatabase.cpp: (WebIconDatabase::getOrCreateDefaultIconBitmap):
- 7:03 PM Changeset in webkit [35741] by
-
- 3 edits in trunk/WebCore
Attempt to fix the Windows build, no review.
- platform/win/CursorWin.cpp: (WebCore::loadCursorByName):
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::paint):
- 6:29 PM Changeset in webkit [35740] by
-
- 3 edits in trunk/WebCore
Attempt to fix the Windows build, no review.
- platform/win/CursorWin.cpp: (WebCore::loadCursorByName):
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::paint):
- 6:24 PM Changeset in webkit [35739] by
-
- 2 edits in trunk/WebCore
Attempt to fix the Qt build, no review.
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::image):
- 6:21 PM Changeset in webkit [35738] by
-
- 3 edits in trunk/WebCore
Attempt to fix the Windows build, no review.
- platform/graphics/win/ImageWin.cpp: (WebCore::Image::loadPlatformResource):
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::paintMissingPluginIcon):
- 6:15 PM Changeset in webkit [35737] by
-
- 3 edits in trunk/WebCore
Another attempt to fix the Qt build, no review.
- platform/graphics/qt/ImageQt.cpp:
- platform/graphics/qt/StillImageQt.h:
- 6:05 PM Changeset in webkit [35736] by
-
- 2 edits in trunk/WebCore
No review, build fix only.
Fix mac build, due to change in new code since my patch was written.
- svg/graphics/cg/SVGResourceMaskerCg.mm: (WebCore::SVGResourceMasker::applyMask):
- 5:59 PM Changeset in webkit [35735] by
-
- 3 edits in trunk/WebCore
Build fix only, no review.
Attempt to fix the Qt build.
- platform/graphics/qt/ImageBufferQt.cpp:
- platform/graphics/qt/StillImageQt.h: (WebCore::StillImage::create): (WebCore::StillImage::destroyDecodedData): (WebCore::StillImage::decodedSize):
- 5:42 PM Changeset in webkit [35734] by
-
- 2 edits in trunk/WebCore
Build fix only, no review.
Attempt to fix the Qt build.
- html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
- 5:30 PM Changeset in webkit [35733] by
-
- 3 edits3 adds in trunk
Reviewed by Sam.
Match HTML5 spec by throwing INVALID_STATE_ERR when
createPattern is called and the HTMLImageElement is not
yet done loading the image (!isComplete)
https://bugs.webkit.org/show_bug.cgi?id=20351
Test: http/misc/canvas-pattern-from-incremental-image.html
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
- 5:29 PM Changeset in webkit [35732] by
-
- 16 edits5 adds in trunk/WebCore
Reviewed by Niko.
Split out a Pattern class from CanvasPattern
and remove all the Pattern-related #ifdefs
(This will break non-mac platforms! I will fix them.)
https://bugs.webkit.org/show_bug.cgi?id=20351
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- html/CanvasPattern.cpp: (WebCore::CanvasPattern::parseRepetitionType): (WebCore::CanvasPattern::CanvasPattern):
- html/CanvasPattern.h: (WebCore::CanvasPattern::create): (WebCore::CanvasPattern::pattern): (WebCore::CanvasPattern::originClean):
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern): (WebCore::CanvasRenderingContext2D::applyStrokePattern): (WebCore::CanvasRenderingContext2D::applyFillPattern):
- html/CanvasRenderingContext2D.h:
- html/HTMLCanvasElement.cpp:
- html/HTMLCanvasElement.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::createHistoryItem):
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::applyStrokePattern): (WebCore::GraphicsContext::applyFillPattern):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::clipToImageBuffer): (WebCore::GraphicsContext::applyStrokePattern): (WebCore::GraphicsContext::applyFillPattern):
- 5:29 PM Changeset in webkit [35731] by
-
- 26 edits in trunk/WebCore
Reviewed by Niko.
Make Images RefCounted (and clean up callers)
https://bugs.webkit.org/show_bug.cgi?id=20351
- editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI):
- loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::brokenImage): (WebCore::nullImage): (WebCore::CachedImage::image): (WebCore::CachedImage::notifyObservers): (WebCore::CachedImage::createImage):
- loader/CachedImage.h:
- loader/icon/IconRecord.cpp: (WebCore::IconRecord::setImageData): (WebCore::IconRecord::loadImageFromResource):
- loader/icon/IconRecord.h:
- platform/graphics/BitmapImage.h: (WebCore::BitmapImage::create):
- platform/graphics/GeneratedImage.h:
- platform/graphics/Gradient.cpp:
- platform/graphics/Gradient.h:
- platform/graphics/Image.cpp: (WebCore::Image::nullImage):
- platform/graphics/Image.h:
- platform/graphics/ImageBuffer.h:
- platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::image):
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::image): (WebCore::ImageBuffer::getImageData): (WebCore::ImageBuffer::putImageData):
- platform/graphics/cg/PDFDocumentImage.h: (WebCore::PDFDocumentImage::create): (WebCore::PDFDocumentImage::destroyDecodedData): (WebCore::PDFDocumentImage::decodedSize):
- platform/graphics/gtk/ImageGtk.cpp: (WebCore::Image::loadPlatformResource):
- platform/graphics/mac/ImageMac.mm: (WebCore::Image::loadPlatformResource):
- rendering/RenderImage.cpp:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintOverflowControls):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame):
- svg/graphics/SVGImage.h: (WebCore::SVGImage::create): (WebCore::SVGImage::destroyDecodedData): (WebCore::SVGImage::decodedSize): (WebCore::SVGImage::frameAtIndex):
- svg/graphics/cairo/SVGPaintServerPatternCairo.cpp: (WebCore::SVGPaintServerPattern::setup):
- svg/graphics/cairo/SVGResourceMaskerCairo.cpp: (WebCore::SVGResourceMasker::applyMask):
- svg/graphics/cg/SVGPaintServerPatternCg.cpp: (WebCore::patternCallback):
- svg/graphics/cg/SVGResourceMaskerCg.mm: (WebCore::SVGResourceMasker::applyMask):
- 5:28 PM Changeset in webkit [35730] by
-
- 6 edits in trunk/WebCore
Reviewed by Sam.
Remove #ifdefs from CanvasStyle by using platform/Color.h
There are some down-sides to this commit.
This commit limits us to 255 levels of grey for calls like:
context.setStrokeStyle(.37, 1.0)
previously CG might have used up to 32bits to store the grey level
Since setStrokeStyle is not part of HTML5, I don't suspect the web will notice.
Likewise, setStrokeStyle/setFillStyle calls which used float colors are now limited
to RGBA32 (like all the rest of colors in WebCore), thus:
context.setStrokStyle(.37, .24, .456, .99) will now have the same precision as:
context.strokeStyle = "rgba(.37, .24, .456, .99)", which is to say RGBA32
If this is a problem for Dashboard, we can either roll out this commit
or add a beefier Color abstraction, which can be used internally by GraphicsContext
when keeping state, and then GraphicsContext can grow some additional set* routines
for setting the a grey/float/whatever fill and stroke.
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFillStyle):
- html/CanvasStyle.cpp: (WebCore::CanvasStyle::CanvasStyle): (WebCore::colorWithOverrideAlpha): (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
- html/CanvasStyle.h:
- platform/graphics/Color.cpp: (WebCore::colorFloatToRGBAByte): (WebCore::makeRGBA32FromFloats):
- platform/graphics/Color.h:
- 4:50 PM Changeset in webkit [35729] by
-
- 3 edits2 adds in trunk
WebCore:
2008-08-13 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
Fix for <rdar://problem/6137931>
https://bugs.webkit.org/show_bug.cgi?id=20360
Remove all parameters from the MIME type before checking with the MIME type registry
Tests: media/video-source-type-params.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::pickMedia): only pass the portion before the first ';' to isSupportedMediaMIMEType()
LayoutTests:
2008-08-13 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
<rdar://problem/6137931>
https://bugs.webkit.org/show_bug.cgi?id=20360
Add test case for parameters on a <source> element 'type' attribute.
- media/video-source-type-params-expected.txt: Added.
- media/video-source-type-params.html: Added.
- 2:36 PM Changeset in webkit [35728] by
-
- 4 edits in trunk/WebCore
2008-08-13 Beth Dakin <Beth Dakin>
Reviewed by Sam Weinig.
Fix for <rdar://problem/6141345>
This patch refines findString and markAllMatchesForText functions'
interactions with disconnected frames. They no longer rely on
knowing where a range is relative to the visible region and work
with disconnected frames that contain frames.
- editing/Editor.cpp: (WebCore::Editor::insideVisibleArea): Now returns a bool instead of the visiblity enum. (WebCore::Editor::firstVisibleRange): This now returns the very first visible range in the document. It's no longer dependent on searching forward. (WebCore::Editor::lastVisibleRange): This now returns the very last visible range in the document. It's no longer dependent on searching backwards. (WebCore::Editor::nextVisibleRange): This returns the next visible range in the appropriate direction from the current range.
- editing/Editor.h:
- page/Frame.cpp: (WebCore::Frame::findString): (WebCore::Frame::markAllMatchesForText):
- 1:07 PM Changeset in webkit [35727] by
-
- 2 edits in trunk/WebCore
wx build fix for case-sensitive platforms, like Linux.
- 1:00 PM Changeset in webkit [35726] by
-
- 2 edits in trunk/JavaScriptCore
2008-08-13 Alp Toker <alp@nuanti.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=20349
WTF::initializeThreading() fails if threading is already initialized
Fix threading initialization logic to support cases where
g_thread_init() has already been called elsewhere.
Resolves database-related crashers reported in several applications.
- wtf/ThreadingGtk.cpp: (WTF::initializeThreading):
- 12:56 PM Changeset in webkit [35725] by
-
- 2 edits in trunk/WebCore
2008-08-13 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=16881
[GTK] PlatformScreenGtk is unimplemented
Original patch by Christian Dywan.
- platform/gtk/PlatformScreenGtk.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
- 12:42 PM Changeset in webkit [35724] by
-
- 2 edits in trunk/WebCore
2008-08-13 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=20318
SharedTimerGtk should use G_PRIORITY_DEFAULT_IDLE for g_idle_add
g_idle_add is the same as g_idle_add_full with a priority of
G_PRIORITY_DEFAULT_IDLE, so we can safely use that.
- platform/gtk/SharedTimerGtk.cpp: (WebCore::setSharedTimerFireTime):
- 12:03 PM Changeset in webkit [35723] by
-
- 6 edits in trunk/WebKit/win
Implemented DOMHTMLElement::idName() and WebFrame::frameElement().
Added IWebFrame::paintDocumentRectToContext() so we can paint a frame's
content into a device context. Changed WebView::paintDocumentRectToContext()
to call that WebFrame method.
Reviewed by Adam Roben.
- DOMHTMLClasses.cpp: (DOMHTMLElement::idName):
- Interfaces/IWebFramePrivate.idl:
- WebFrame.cpp: (WebFrame::paintDocumentRectToContext): (WebFrame::frameElement):
- WebFrame.h:
- WebView.cpp: (WebView::paintDocumentRectToContext):
- 11:11 AM Changeset in webkit [35722] by
-
- 7 edits in trunk
Remember the docked state of the Web Inspector, so it can be reopened docked if it was last docked.
WebCore:
2008-08-13 Timothy Hatcher <timothy@apple.com>
Changed the InspectorController so it can be notified when the
attached state of the Inspector changes in WebKit.
Reviewed by Kevin McCullough.
- WebCore.base.exp: Updated the symbol for setWindowVisible.
- page/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): Added an attached argument, that defaults to false.Call setAttachedWindow with the attached argument. (WebCore::InspectorController::setAttachedWindow): Call the script version of setAttachedWindow.
- page/InspectorController.h:
- page/inspector/inspector.js: (WebInspector.setAttachedWindow): Set the attached property.
WebKit/mac:
2008-08-13 Timothy Hatcher <timothy@apple.com>
Remember the docked state of the Web Inspector, so it can be
reopened docked if it was last docked.
Reviewed by Kevin McCullough.
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): Initialize _shouldAttach to the value stored in the user defaults. If there has never been a value stored, default to being attached. (-[WebInspectorWindowController showWindow:]): Pass the attached state to InspectorController::setWindowVisible.
- 11:10 AM Changeset in webkit [35721] by
-
- 2 edits in trunk/WebKit/mac
Remove the Inspector's WebView for the view hierarchy when closed
while attached. This prevents it from showing in the background
while the page changes.
Reviewed by Kevin McCullough.
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController close:]): Call removeFromSuperview on the Inspector's WebView if it isn't attached, so it will not be visible when navigating pages while closed.
- 11:10 AM Changeset in webkit [35720] by
-
- 6 edits1 add in trunk/WebCore
Added a close button to the Inspector's toolbar when docked.
Reviewed by Kevin McCullough.
- page/InspectorController.cpp: (WebCore::closeWindow): Call InspectorController::closeWindow. (WebCore::InspectorController::windowScriptObjectAvailable): Added closeWindow to the script class.
- page/InspectorController.h:
- page/inspector/Images/closeButtons.png: Added.
- page/inspector/inspector.css: Added and changed styles.
- page/inspector/inspector.html: Added the close button.
- page/inspector/inspector.js: (WebInspector.loaded): Added click event listener to the close button. (WebInspector.close): Call InspectorController.closeWindow.
- 11:10 AM Changeset in webkit [35719] by
-
- 23 edits in trunk
Make the docked Web Inspector resizable.
WebCore:
2008-08-12 Timothy Hatcher <timothy@apple.com>
Make the docked Web Inspector resizable. This is the cross platform
portion of the code. Each InspectorClient needs to implement the
real resize code.
Reviewed by Kevin McCullough.
- loader/EmptyClients.h: Added an empty setAttachedWindowHeight.
- page/InspectorClient.h: Added setAttachedWindowHeight.
- page/InspectorController.cpp: (WebCore::setAttachedWindowHeight): Call setAttachedWindowHeight on the InspectorController. (WebCore::InspectorController::setAttachedWindowHeight): Call setAttachedWindowHeight on the client. (WebCore::InspectorController::windowScriptObjectAvailable): Added setAttachedWindowHeight to the script class.
- page/InspectorController.h:
- page/inspector/inspector.css: Make the cursor on the toolbar be row-resize when docked.
- page/inspector/inspector.js: (WebInspector.loaded): Always add the toolbarDragStart event listener. (WebInspector.toolbarDragStart): Return early if we are not attached and not on Leopard. Call WebInspector.elementDragStart. (WebInspector.toolbarDragEnd): Call WebInspector.elementDragEnd. (WebInspector.toolbarDrag): When attached call setAttachedWindowHeight, otherwise call moveByUnrestricted.
WebKit/gtk:
2008-08-12 Timothy Hatcher <timothy@apple.com>
Add a stub for InspectorClient::setAttachedWindowHeight.
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::setAttachedWindowHeight): Call notImplemented().
- WebCoreSupport/InspectorClientGtk.h:
WebKit/mac:
2008-08-12 Timothy Hatcher <timothy@apple.com>
Make the docked Web Inspector resizable.
Reviewed by Kevin McCullough.
- WebCoreSupport/WebInspectorClient.h:
- WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::setAttachedWindowHeight): Call setAttachedWindowHeight: on the WebInspectorWindowController. (-[WebInspectorWindowController showWindow:]): Call setAttachedWindowHeight:. (-[WebInspectorWindowController setAttachedWindowHeight:]): Moved code from showWindow: and generalized to allow being called multiple times. Remembers the last height passed, which is used by showWindow: the next time the Inspector attaches.
WebKit/qt:
2008-08-12 Timothy Hatcher <timothy@apple.com>
Add a stub for InspectorClient::setAttachedWindowHeight.
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::setAttachedWindowHeight): Call notImplemented().
- WebCoreSupport/InspectorClientQt.h:
WebKit/win:
2008-08-12 Timothy Hatcher <timothy@apple.com>
Add a stub for InspectorClient::setAttachedWindowHeight.
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::setAttachedWindowHeight): Add a FIXME to implement this.
- WebCoreSupport/WebInspectorClient.h:
WebKit/wx:
2008-08-12 Timothy Hatcher <timothy@apple.com>
Add a stub for InspectorClient::setAttachedWindowHeight.
- WebKitSupport/InspectorClientWx.cpp: (WebCore::InspectorClientWx::setAttachedWindowHeight): Call notImplemented().
- WebKitSupport/InspectorClientWx.h:
- 7:32 AM Changeset in webkit [35718] by
-
- 2 edits in trunk/WebKit/qt
2008-08-13 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Use full-page zoom in QtLauncher.
- QtLauncher/main.cpp: (MainWindow::zoomIn): (MainWindow::zoomOut): (MainWindow::resetZoom): (MainWindow::setupUI):
- 7:32 AM Changeset in webkit [35717] by
-
- 2 edits in trunk/WebKit/qt
2008-08-13 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Fix linking with QtWebKit.
- Api/qwebframe.h: remove non-existing function/property.
- 6:43 AM Changeset in webkit [35716] by
-
- 9 edits in trunk
WebCore:
2008-08-13 Simon Hausmann <Simon Hausmann>
Reviewed by Holger.
Initialize m_zoomsTextOnly in the Settings constructor.
WebKit/qt:
2008-08-13 Simon Hausmann <Simon Hausmann>
Reviewed by Holger.
Based on patch by Siraj razick <siraj.razick@collabora.co.uk>
Added functions to get/set the zoom factor.
Added a QWebFrame/QWebView::zoomFactor as well as a boolean
ZoomTextOnly attribute in QWebSettings.
- 6:33 AM Changeset in webkit [35715] by
-
- 2 edits in trunk/LayoutTests
Removing http/tests/xmlhttprequest/readystatechange.html from Windows skipped list -
this test hasn't been failing locally for a long time.
- platform/win/Skipped:
- 6:31 AM Changeset in webkit [35714] by
-
- 4 edits in trunk
2008-08-13 Brad Hughes <bhughes@trolltech.com>
Reviewed by Simon.
Fix compiling of QtWebKit in release mode with the Intel C++ Compiler for Linux
The latest upgrade of the intel compiler allows us to compile all of
Qt with optimizations enabled (yay!).
- 6:24 AM Changeset in webkit [35713] by
-
- 2 edits in trunk/WebCore
2008-08-13 Prasanth Ullattil <prasanth.ullattil@trolltech.com>
Reviewed by Simon.
Fix QtWebKit not displaying content on 403 HTTP responses
Just like with 404 responses also display content with 403, as
used by http://audiio.ejamming.proteus-tech.com/audiio/profile/original_signup/
- 6:16 AM Changeset in webkit [35712] by
-
- 3 edits2 adds in trunk
WebCore:
2008-08-13 Simon Hausmann <Simon Hausmann>
Reviewed by Holger.
Make the formatting of String::format() locale independent through the use of QString::vsprintf.
LayoutTests:
2008-08-13 Simon Hausmann <Simon Hausmann>
Reviewed by Holger.
Adjusted the length-list-parser layout test to compensate for the subtle difference of
dropping a sign for a "negative zero" as a result of the QString::vsprintf use.
- 5:07 AM Changeset in webkit [35711] by
-
- 2 edits in trunk/WebKitTools
2008-08-13 Simon Hausmann <Simon Hausmann>
Rubber-stamped by Holger.
Revert r31585 and disable http tests for the Qt build again unless
explicitly enabled.
Running the http tests unfortunately currently still triggers
failures in non-http tests due to side-effects. Disable them by default for
now, for more reliable results.
- 5:02 AM Changeset in webkit [35710] by
-
- 4 edits in trunk
2008-08-13 Simon Hausmann <Simon Hausmann>
Reviewed by Lars.
Fix QWebFrame::setHtml() not setting the new contents immediately.
Added a setter to the DocumentLoader to toggle the deferred loading of the main
resource when it comes from substitute data.
Disable deferred loading of the main resource when we have valid substitute data,
as used by QWebFrame::setHtml.
- 4:51 AM Changeset in webkit [35709] by
-
- 4 edits in trunk/WebKit/qt
2008-08-13 Simon Hausmann <Simon Hausmann>
Rubber-stamped by Holger.
Fix QWebPage::isModified().
isModified() would return true after loading a new page or it would continue to
return true after undoing modifications. Fix this by eliminating the
QWebPagePrivate::modified variable and use the undoStack's canUndo() property
instead.
- 4:38 AM Changeset in webkit [35708] by
-
- 2 edits in trunk/WebKit/qt
2008-08-13 David Boddie <dboddie@trolltech.com>
Reviewed by Simon.
Updated docs with the signal emission behavior of urlChanged()
- 4:35 AM Changeset in webkit [35707] by
-
- 2 edits in trunk/WebKit/qt
2008-08-13 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Fix Ctrl+Y to work again when editing text in contextEditable mode.
This fixes regression in LayoutTests/editing/pasteboard/emacs-cntl-y-001.html
- 2:58 AM Changeset in webkit [35706] by
-
- 2 edits in trunk/WebCore
Speculative GTK build fix.
- 2:11 AM Changeset in webkit [35705] by
-
- 4 edits in trunk
2008-08-13 Thiago Macieira <tjmaciei@trolltech.com>
Reviewed by Simon.
Fix encoding of [ and ] in the host part of the URL
Until QUrl is fixed (making QUrl's tolerant parser more tolerant), we have to
add this workaround to the QUrl <> WebCore::KURL conversion operator so that it
doesn't encode [ and ] when they are found in the host part. That is, the
following URL:
http://[::1]/
is valid and should not be reencoded to:
http://%5b::1%5d/
