Timeline



Aug 24, 2008:

10:43 PM Changeset in webkit [35912] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2008-08-24 Steve Falkenburg <​sfalken@apple.com>

Add a "last chance" WM_TIMER to the Windows shared timer.


The last chance timer fires every 5 seconds to run any lost WM_TIMER based timers.
Failure to fire a timer is fatal to the cross-platform Timer code, since it won't re-schedule
timers if a timer with an earlier expiration is already pending. This results in no timers
firing from that point on.


We lose WM_TIMER messages occasionally (in the neighborhood of 1 per hour) probably due to a
buggy window message hook.


This timer will start when the first WM_TIMER is scheduled, and will
fire every 5 seconds thereafter, causing any lost timers to be fired.


Found this via one of its symptoms: leaking WebFrames. The fix prevents timers from stalling
and prevents the WebFrame leak.


Reviewed by Darin Adler, Geoff Garen.

  • platform/win/SharedTimerWin.cpp: (WebCore::): (WebCore::TimerWindowWndProc): (WebCore::setSharedTimerFireTime):
9:08 PM Changeset in webkit [35911] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-08-24 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver Hunt.

Bug 20093: JSC shell does not clear exceptions after it executes toString on an expression
<​https://bugs.webkit.org/show_bug.cgi?id=20093>

Clear exceptions after evaluating any code in the JSC shell. We do not
report exceptions that are caused by calling toString on the final
valued, but at least we avoid incorrect behaviour.

Also, print any exceptions that occurred while evaluating code at the
interactive prompt, not just while evaluating code from a file.

  • kjs/Shell.cpp: (runWithScripts): (runInteractive):
8:22 PM Changeset in webkit [35910] by mitz@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6065547> REGRESSION (r34879): "Subject" in unread emails in Yahoo mail is not shown in bold

Test: fast/css/font-property-priority.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Changed to pass the 'important' flag to the font-property-parsing functions. (WebCore::CSSParser::parseFontStyle): Added an 'important' argument and changed to use it rather than the m_important member. (WebCore::CSSParser::parseFontVariant): Ditto. (WebCore::CSSParser::parseFontWeight): Ditto.
  • css/CSSParser.h:

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/6065547> REGRESSION (r34879): "Subject" in unread emails in Yahoo mail is not shown in bold
  • fast/css/font-property-priority-expected.txt: Added.
  • fast/css/font-property-priority.html: Added.
6:27 PM Changeset in webkit [35909] by Beth Dakin
  • 4 edits in trunk/WebKit/win

2008-08-24 Beth Dakin <Beth Dakin>

Reviewed by John Sullivan.

Provide the excludeFromTextSearch SPI on Windows as well.

  • Interfaces/IWebFrame.idl:
  • WebFrame.cpp: (WebFrame::setExcludeFromTextSearch):
  • WebFrame.h:
3:28 PM Changeset in webkit [35908] by timothy@apple.com
  • 2 edits
    1 add in trunk/WebCore

Fixes a bug where the Inspector's UI would not animate or
fully function because JavaScript timeouts, intervals and
CSS animation timers where not firing while paused at a
a breakpoint in the inspected page.

​https://bugs.webkit.org/show_bug.cgi?id=20042

Reviewed by Darin Adler.

Test: manual-tests/inspector/forzen-ui-while-paused.html

  • page/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::pauseIfNeeded): Add a call to TimerBase::fireTimersInNestedEventLoop before spinning the EventLoop.
3:25 PM Changeset in webkit [35907] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.2

New tag.

2:30 PM Changeset in webkit [35906] by cwzwarich@webkit.org
  • 2 edits in trunk

2008-08-24 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Remove an unnecessary RefPtr to a RegisterID.

  • kjs/nodes.cpp: (KJS::DeleteBracketNode::emitCode):
11:07 AM Changeset in webkit [35905] by rwlbuis@webkit.org
  • 4 edits
    4 adds in trunk

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=20324
A change in SVG Glyph wont show up

Invalidate the glyph cache when the d attribute is set.

Test: svg/custom/glyph-setting-d-attribute.svg

5:59 AM Changeset in webkit [35904] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

2008-08-24 Jon Honeycutt <​jhoneycutt@apple.com>

Cannot get the focused accessible object from the root object.

AccessibleBase::get_AccFocus() checks whether the focused object is a
child of the current object, but
​http://msdn.microsoft.com/en-us/library/ms696150(VS.85).aspx states that
the result is the object itself, if it has focus, or a child object of
the active window, not a child of the object.

Reviewed by Sam Weinig.

  • AccessibleBase.cpp: (AccessibleBase::get_accFocus): Don't check whether the focused object is our child.
5:56 AM Changeset in webkit [35903] by jhoneycutt@apple.com
  • 7 edits
    2 adds in trunk/WebKitTools

2008-08-24 Jon Honeycutt <​jhoneycutt@apple.com>

Initial support for accessibility layout tests on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=20497

Reviewed by Sam Weinig.

  • DumpRenderTree/AccessibilityController.h: Fix typos.
  • DumpRenderTree/AccessibilityUIElement.cpp: Change #import to #include.
  • DumpRenderTree/AccessibilityUIElement.h: Define _WINSOCKAPI_ to prevent oleacc.h, which includes windows.h, from including winsock.h. Fixed typos.
  • DumpRenderTree/win/AccessibilityControllerWin.cpp: Added. (AccessibilityController::AccessibilityController): (AccessibilityController::~AccessibilityController): (AccessibilityController::focusedElement): Get the root element, and request its focused object. (AccessibilityController::rootElement): Query Windows for the accessible client object for the WebView's window.
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added. (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::~AccessibilityUIElement): (AccessibilityUIElement::getLinkedUIElements): Not implemented. (AccessibilityUIElement::getChildren): Get the child count, and append each child. (AccessibilityUIElement::getChildAtIndex): Get the child at the given index offset by 1. In MSAA, child 0 is the object itself. (AccessibilityUIElement::allAttributes): Not implemented. (AccessibilityUIElement::attributesOfLinkedUIElements): Same. (AccessibilityUIElement::attributesOfChildren): Same. (AccessibilityUIElement::parameterizedAttributeNames): Same. (self): Return a VARIANT representing the "self" object. This is used when calling methods that require a child variant. (AccessibilityUIElement::role): Get the MSAA role, a long value, and convert it into a string with GetRoleText(). (AccessibilityUIElement::title): Get the element's title, and convert it to a JS String. (AccessibilityUIElement::description): Same, for description. (AccessibilityUIElement::width): (AccessibilityUIElement::height): (AccessibilityUIElement::intValue): Get the object's value as a string, and convert the string to a double. (AccessibilityUIElement::minValue): Not implemented. (AccessibilityUIElement::maxValue): Same. (AccessibilityUIElement::insertionPointLineNumber): Same. (AccessibilityUIElement::attributesOfColumnHeaders): Same. (AccessibilityUIElement::attributesOfRowHeaders): Same. (AccessibilityUIElement::attributesOfColumns): Same. (AccessibilityUIElement::attributesOfRows): Same. (AccessibilityUIElement::attributesOfVisibleCells): Same. (AccessibilityUIElement::attributesOfHeader): Same. (AccessibilityUIElement::indexInTable): Same. (AccessibilityUIElement::rowIndexRange): Same. (AccessibilityUIElement::columnIndexRange): Same. (AccessibilityUIElement::lineForIndex): Same. (AccessibilityUIElement::boundsForRange): Same. (AccessibilityUIElement::cellForColumnAndRow): Same.
  • DumpRenderTree/win/DumpRenderTree.vcproj: Add accessibility files to project. Link to oleacc.lib, the MSAA library.
  • DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::FrameLoadDelegate): Initialize the accessibility controller. (FrameLoadDelegate::didClearWindowObject): Create a new window object for the accessibility controller.
  • DumpRenderTree/win/FrameLoadDelegate.h:
2:18 AM Changeset in webkit [35902] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • rendering/RenderText.cpp: (WebCore::RenderText::trimmedPrefWidths): Moved the assignment to beginWS and endWS before the early return to ensure that they are initialized in that case.
1:35 AM Changeset in webkit [35901] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Use the correct version number for when JSGlobalContextCreate was introduced.

Reviewed by Oliver Hunt.

Aug 23, 2008:

1:16 AM Changeset in webkit [35900] by cwzwarich@webkit.org
  • 108 edits in trunk

2008-08-23 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Rubber-stamped by Mark Rowe.

Remove modelines.

JavaScriptCore:

  • API/APICast.h:
  • API/JSBase.cpp:
  • API/JSCallbackConstructor.cpp:
  • API/JSCallbackConstructor.h:
  • API/JSCallbackFunction.cpp:
  • API/JSCallbackFunction.h:
  • API/JSCallbackObject.cpp:
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:
  • API/JSClassRef.cpp:
  • API/JSContextRef.cpp:
  • API/JSObjectRef.cpp:
  • API/JSProfilerPrivate.cpp:
  • API/JSStringRef.cpp:
  • API/JSStringRefBSTR.cpp:
  • API/JSStringRefCF.cpp:
  • API/JSValueRef.cpp:
  • API/tests/JSNode.c:
  • API/tests/JSNode.h:
  • API/tests/JSNodeList.c:
  • API/tests/JSNodeList.h:
  • API/tests/Node.c:
  • API/tests/Node.h:
  • API/tests/NodeList.c:
  • API/tests/NodeList.h:
  • API/tests/minidom.c:
  • API/tests/minidom.js:
  • API/tests/testapi.c:
  • API/tests/testapi.js:
  • JavaScriptCore.pro:
  • kjs/FunctionConstructor.h:
  • kjs/FunctionPrototype.h:
  • kjs/JSArray.h:
  • kjs/JSString.h:
  • kjs/JSWrapperObject.cpp:
  • kjs/NumberConstructor.h:
  • kjs/NumberObject.h:
  • kjs/NumberPrototype.h:
  • kjs/lexer.h:
  • kjs/lookup.h:
  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
  • wtf/HashCountedSet.h:
  • wtf/HashFunctions.h:
  • wtf/HashIterators.h:
  • wtf/HashMap.h:
  • wtf/HashSet.h:
  • wtf/HashTable.h:
  • wtf/HashTraits.h:
  • wtf/ListHashSet.h:
  • wtf/ListRefPtr.h:
  • wtf/Noncopyable.h:
  • wtf/OwnArrayPtr.h:
  • wtf/OwnPtr.h:
  • wtf/PassRefPtr.h:
  • wtf/Platform.h:
  • wtf/RefPtr.h:
  • wtf/RefPtrHashMap.h:
  • wtf/RetainPtr.h:
  • wtf/UnusedParam.h:
  • wtf/Vector.h:
  • wtf/VectorTraits.h:
  • wtf/unicode/Unicode.h:
  • wtf/unicode/icu/UnicodeIcu.h:

WebCore:

  • WebCore.pro:
  • bridge/testbindings.cpp:
  • dom/DocPtr.h:
  • loader/SubstituteData.h:
  • page/Chrome.cpp:
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Frame.h:
  • page/FrameLoadRequest.h:
  • page/FrameTree.cpp:
  • page/FrameTree.h:
  • page/Page.h:
  • page/mac/ChromeMac.mm:
  • platform/network/HTTPHeaderMap.h:
  • platform/network/ResourceErrorBase.cpp:
  • platform/network/ResourceErrorBase.h:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/ResourceRequestBase.cpp:
  • platform/network/ResourceRequestBase.h:
  • platform/network/ResourceResponseBase.cpp:
  • platform/network/ResourceResponseBase.h:
  • platform/network/cf/ResourceError.h:
  • platform/network/cf/ResourceRequest.h:
  • platform/network/cf/ResourceRequestCFNet.h:
  • platform/network/cf/ResourceResponse.h:
  • platform/network/cf/ResourceResponseCFNet.h:
  • platform/network/curl/ResourceError.h:
  • platform/network/curl/ResourceRequest.h:
  • platform/network/curl/ResourceResponse.h:
  • platform/network/mac/ResourceError.h:
  • platform/network/mac/ResourceErrorMac.mm:
  • platform/network/mac/ResourceRequest.h:
  • platform/network/mac/ResourceRequestMac.mm:
  • platform/network/mac/ResourceResponse.h:
  • platform/network/mac/ResourceResponseMac.mm:
  • platform/network/qt/ResourceError.h:
  • platform/network/qt/ResourceRequest.h:
  • platform/network/qt/ResourceResponse.h:
  • platform/network/soup/CookieJarSoup.cpp:
  • platform/network/soup/ResourceError.h:
  • platform/network/soup/ResourceRequest.h:
  • platform/network/soup/ResourceResponse.h:
12:16 AM Changeset in webkit [35899] by mitz@apple.com
  • 14 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline

Test: fast/table/vertical-align-baseline.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::getBaselineOfFirstLineBox): Added. Returns the baseline of the first table row, if there is one, -1 otherwise.
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::baselinePosition): Changed to follow the CSS2.1 definition of the baseline of a table cell.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::getBaselineOfFirstLineBox): Added. Returns the baseline of the first row in the section.
  • rendering/RenderTableSection.h:

LayoutTests:

Reviewed by Dave Hyatt.

  • test and updated results for <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline
  • fast/table/vertical-align-baseline.html: Added.
  • platform/mac/fast/table/form-with-table-style-expected.checksum:
  • platform/mac/fast/table/form-with-table-style-expected.png:
  • platform/mac/fast/table/form-with-table-style-expected.txt:
  • platform/mac/fast/table/vertical-align-baseline-expected.checksum: Added.
  • platform/mac/fast/table/vertical-align-baseline-expected.png: Added.
  • platform/mac/fast/table/vertical-align-baseline-expected.txt: Added.
  • platform/mac/tables/mozilla/bugs/bug3037-1-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:

Aug 22, 2008:

8:17 PM Changeset in webkit [35898] by cwzwarich@webkit.org
  • 8 edits in trunk/JavaScriptCore

2008-08-22 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Some cleanup to match our coding style.

  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
  • kjs/ExecState.cpp:
  • kjs/ExecState.h:
  • kjs/completion.h:
  • kjs/identifier.cpp: (KJS::Identifier::equal): (KJS::CStringTranslator::hash): (KJS::CStringTranslator::equal): (KJS::CStringTranslator::translate): (KJS::UCharBufferTranslator::equal): (KJS::UCharBufferTranslator::translate): (KJS::Identifier::remove):
  • kjs/operations.h:
4:44 PM Changeset in webkit [35897] by jhoneycutt@apple.com
  • 10 edits in trunk

2008-08-18 Jon Honeycutt <​jhoneycutt@apple.com>

Add SPI to make a Windows WebView transparent.

Reviewed by Dan Bernstein.

  • Interfaces/IWebViewPrivate.idl:
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::transitionToCommittedForNewPage): Call updateBackground() when a new frame is attached, matching the Mac.
  • WebFrame.cpp: (WebFrame::updateBackground): Propagate WebView transparency to ourself and our child frames.
  • WebFrame.h:
  • WebView.cpp: (WebView::WebView): (WebView::paintIntoBackingStore): Pass m_transparent when creating a GraphicsContext, so the context will be created with an alpha channel. (WebView::setTransparent): (WebView::transparent):
  • WebView.h:
4:44 PM Changeset in webkit [35896] by jhoneycutt@apple.com
  • 4 edits in trunk/WebKit/win

2008-08-12 Jon Honeycutt <​jhoneycutt@apple.com>

Add SPI to get a handle to the WebView's backing store bitmap.

Reviewed by Dan Bernstein.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp: (WebView::backingStore):
  • WebView.h:
1:35 PM Changeset in webkit [35895] by timothy@apple.com
  • 2 edits in trunk/WebCore

Rolls out r35834 because it caused a regression in the Inspector's
Console where some expressions always threw a syntax error.

​https://bugs.webkit.org/show_bug.cgi?id=20487

  • page/inspector/Console.js: (Console.prototype._evalInInspectedWindow): Removes parenthesis around the expression.
12:39 PM Changeset in webkit [35894] by andersca@apple.com
  • 2 edits in trunk/JavaScriptGlue

2008-08-22 Anders Carlsson <​andersca@apple.com>

Fix build for real this time.


  • UserObjectImp.h:
12:14 PM Changeset in webkit [35893] by andersca@apple.com
  • 3 edits in trunk/JavaScriptGlue

2008-08-22 Anders Carlsson <​andersca@apple.com>

Fix build.


  • UserObjectImp.cpp: (UserObjectImp::toPrimitive):
  • UserObjectImp.h:
11:39 AM Changeset in webkit [35892] by timothy@apple.com
  • 3 edits
    2 adds in trunk

Makes getStyleProperty return a value for the overflow property when overflow-x and overflow-y are equal.

WebCore:

2008-08-22 Timothy Hatcher <​timothy@apple.com>

Makes getStyleProperty return a value for the overflow property
when overflow-x and overflow-y are equal.

​https://bugs.webkit.org/show_bug.cgi?id=20485

Reviewed by Dan Bernstein.

Test: fast/css/overflow-property.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue):

LayoutTests:

2008-08-22 Timothy Hatcher <​timothy@apple.com>

Test for the tests the parsing and retrieval of the overflow,
overflow-x and overflow-y properties

​https://bugs.webkit.org/show_bug.cgi?id=20485

Reviewed by Dan Bernstein.

  • fast/css/overflow-property-expected.txt: Added.
  • fast/css/overflow-property.html: Added.
11:39 AM Changeset in webkit [35891] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes a bug where while editing in the Inspector the
sidebar scroll position would jump to the top.

​https://bugs.webkit.org/show_bug.cgi?id=20484

Reviewed by Darin Adler.

  • page/inspector/treeoutline.js: (TreeOutline._removeChildren): Remove the offsetTop call that was forcing a layout, since layout causes scroll positions to be clamped to the new scrollHeight/Width. Layout will happen normally when needed.
10:38 AM Changeset in webkit [35890] by Simon Fraser
  • 1 edit
    2 deletes in trunk/LayoutTests

Reviewed by Darin Adler

css3/transform-computed-style-001.html is better tested
by fast/css/getComputedStyle-transform.html, so removed.
​https://bugs.webkit.org/show_bug.cgi?id=20477

  • css3/transform-computed-style-001-expected.txt: Removed.
  • css3/transform-computed-style-001.fhtml: Removed.
9:25 AM Changeset in webkit [35889] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix. Add AccessibilityTable sources.

Aug 21, 2008:

11:29 PM Changeset in webkit [35888] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Jon Honeycutt and Alexey Proskuryakov.

  • fix <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics

Test: platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html

  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit): Add 8% to Geeza Pro's reported ascent and 100% to its reported descent.

LayoutTests:

Reviewed by Jon Honeycutt and Alexey Proskuryakov.

  • test for <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics
  • platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum: Added.
  • platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
  • platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html: Added.
7:20 PM Changeset in webkit [35887] by mrowe@apple.com
  • 2 edits in trunk/WebKit/win

2008-08-21 Jonas Klink <​klinktech@gmail.com>

Reviewed by Jon Honeycutt.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=20231
Bug 20231: accNavigate: no screen element found in the specified direction should return S_FALSE

Per <​http://msdn.microsoft.com/en-us/library/ms696145(VS.85).aspx>, we should return S_FALSE
from accNavigate if no screen element is found in the specified direction.

  • AccessibleBase.cpp: (AccessibleBase::accNavigate):
7:20 PM Changeset in webkit [35886] by mrowe@apple.com
  • 2 edits in trunk/WebKit/win

2008-08-21 Jonas Klink <​klinktech@gmail.com>

Reviewed by Jon Honeycutt.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=20230
Bug 20230: get_accState should be testing state on childObj

Also initializes output parameter action to 0 in get_accDefaultAction.

  • AccessibleBase.cpp: (AccessibleBase::get_accState): (AccessibleBase::get_accDefaultAction):
7:10 PM Changeset in webkit [35885] by mrowe@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix bug number in ChangeLog.

7:07 PM Changeset in webkit [35884] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-08-21 Kalle Vahlman <​kalle.vahlman@movial.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=19171
[GTK] Crash on some pages due to a plugin

Fix handling of badly formatted and empty plugin mime descriptions

  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo):
7:07 PM Changeset in webkit [35883] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-08-21 Kevin Watters <​kevinwatters@gmail.com>

Reviewed by Darin Adler.

Follow other ports (and IE) in ImageSourceWx.cpp never to return an
animated GIF frame duration of less than 50ms.

  • platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::frameDurationAtIndex):
5:39 PM Changeset in webkit [35882] by britto@apple.com
  • 3 edits
    3 adds in trunk

2008-08-21 Maxime Britto <​britto@apple.com>

Reviewed by Kevin McCullough.

Test: fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html
​https://bugs.webkit.org/show_bug.cgi?id=20451


rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)
When we climb up the rendering tree looking for a scrollable renderer, we need to be able to jump outside of an iframe.
This way we can see if what is embedding the iframe can be scrolled even if the iframe content can't.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDraggedEvent): when we reach the document node and it can't be scrolled we set the next parent as the document's owner element if it exists.

(WebCore::EventHandler::handleMousePressEvent): ditto

2008-08-21 Maxime Britto <​britto@apple.com>

Reviewed by Kevin McCullough.

rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)
​https://bugs.webkit.org/show_bug.cgi?id=20451

This test can be run automatically or manually as well.

  • fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div-expected.txt: Added.
  • fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html: Added.
  • fast/events/resources/big-page-with-overflow-hidden.html: Added.
4:54 PM Changeset in webkit [35881] by timothy@apple.com
  • 2 edits in trunk/WebCore

Small optimization for when the dividers in the Inspector's
Resources panel are updated.

Reviewed by Tim Hatcher.

  • page/inspector/ResourcesPanel.js: (WebInsector.ResourcesPanel.prototype._updateGraphDividersIfNeeded): Combind a for loop and clone the divider element.
4:44 PM Changeset in webkit [35880] by Simon Fraser
  • 2 edits in trunk/WebKitTools

Reviewed by Mark Rowe

Make build-launcher-app work when run from a git repository.
​https://bugs.webkit.org/show_bug.cgi?id=20478

  • BuildSlaveSupport/build-launcher-app:
4:35 PM Changeset in webkit [35879] by dino@apple.com
  • 3 edits
    2 adds in trunk

2008-08-21 Chris Marrin <​cmarrin@apple.com>

Allow 0 (without units) for Time eg. duration
Fix for ​https://bugs.webkit.org/show_bug.cgi?id=20467

Reviewed by Dave Hyatt.

Test: css1/units/zero-duration-without-units.html

  • css/CSSParser.cpp: (WebCore::CSSParser::validUnit):
1:13 PM Changeset in webkit [35878] by timothy@apple.com
  • 2 edits in trunk/WebCore

Make deleting all text while editing a DOM attribute in
the Inspector delete the attribute. This also fixes
an exception that would happen before.

​https://bugs.webkit.org/show_bug.cgi?id=20472

Reviewed by Kevin McCullough.

  • page/inspector/ElementsPanel.js: (WebInspector.DOMNodeTreeElement.prototype._attributeEditingCommitted): Don't check for hasAttributes on the parseElement, continuing through the function will correctly remove the attribute. If the parseElement is null, call _editingCancelled not editingCancelled, this fixes an exception.
1:12 PM Changeset in webkit [35877] by timothy@apple.com
  • 3 edits in trunk/WebCore

Update the Inspector's Metrics pane when editing in
the Styles pane. This makes sure the metrics shown
always match what the Styles pane shows.

​https://bugs.webkit.org/show_bug.cgi?id=20470

Reviewed by Kevin McCullough.

  • page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel): Add event listeners for the "style edited" and "style property toggled" events, so the Metrics pane is updated. (WebInspector.ElementsPanel.prototype._stylesPaneEdited): Update the Metrics pane.
  • page/inspector/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled): Dispatch the "style property toggled" event. (WebInspector.StylePropertyTreeElement.prototype.editingCancelled): Dispatch the "style edited" event when the CSS text is restored. (WebInspector.StylePropertyTreeElement.prototype.applyStyleText): Dispatch the "style edited" event.
1:12 PM Changeset in webkit [35876] by timothy@apple.com
  • 4 edits in trunk/WebCore

Make the Inspector's Metrics sidebar pane editable.

​https://bugs.webkit.org/show_bug.cgi?id=17218
rdar://problem/5732818

Reviewed by Kevin McCullough.

  • page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel): Add an event listener for the "metrics edited" event, so the Styles pane is updated.
  • page/inspector/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.update): Remember the node so future updates work. Add a double click event listener for the metric values to start editing. (WebInspector.MetricsSidebarPane.prototype.startEditing): Call WebInspector.startEditing with some context. (WebInspector.MetricsSidebarPane.prototype.editingCancelled): (WebInspector.MetricsSidebarPane.prototype.editingCommitted): Set the user input on the elements inline style. Fire the "metrics edited" event.
11:42 AM Changeset in webkit [35875] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Fix a race condition in Windows timer code.
Timer function could end up being called with a 0 timer, leading to a Windows exception.


Don't post a timer message if one is already pending.


Reviewed by Ada Chan.

  • platform/win/SharedTimerWin.cpp: (WebCore::TimerWindowWndProc): (WebCore::clearTimer): (WebCore::queueTimerProc): (WebCore::setSharedTimerFireTime):
9:36 AM Changeset in webkit [35874] by timothy@apple.com
  • 2 edits in trunk/WebCore

After trying to add the expression, try again with quotes for
easier edition.

​https://bugs.webkit.org/show_bug.cgi?id=20466

Reviewed by Tim Hatcher.

  • page/inspector/ObjectPropertiesSection.js: Added an evaluateExpression function.
9:33 AM Changeset in webkit [35873] by timothy@apple.com
  • 2 edits in trunk/WebCore

Perform Inspector searches on search event to clear results when
clicking the cross to empty it. Delete the lastQuery when the field
is emptied in order to perform the search if exactly the same query
is entered next.

​https://bugs.webkit.org/show_bug.cgi?id=20462

Reviewed by Tim Hatcher.

  • page/inspector/inspector.js:
4:22 AM Changeset in webkit [35872] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-08-21 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=19656
[SOUP] The gio code should call didFail() instead of
didFinishLoading() in case of error

In case of error call didFail() instead of didReceiveResponse() and
didFinishLoading().

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::networkErrorForFile): (WebCore::readCallback): (WebCore::openCallback): (WebCore::queryInfoCallback):

Aug 20, 2008:

11:52 PM Changeset in webkit [35871] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix build failure.

Reviewed by Jon Honeycutt.

  • bridge/c/c_instance.cpp:

(KJS::Bindings::CInstance::getPropertyNames): Declare count as uint32_t rather than unsigned
as that is what NPEnumerationFunctionPtr is declared as accepting.

10:03 PM Changeset in webkit [35870] by timothy@apple.com
  • 2 edits in trunk/PlanetWebKit

Add Anthony Ricaud's blog.

Reviewed by Tim Hatcher.

  • config.ini: Add Anthony Ricaud's blog.
9:01 PM Changeset in webkit [35869] by mrowe@apple.com
  • 3 edits in trunk/WebCore

Build fix.

5:33 PM Changeset in webkit [35868] by mitz@apple.com
  • 14 edits in trunk

WebCore:

Rubber-stamped by John Sullivan.

  • rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen and rename related methods and variables accordingly.
  • WebCore.base.exp:
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::shouldUpdateWhileOffscreen): (WebCore::FrameView::setShouldUpdateWhileOffscreen):
  • page/FrameView.h:
  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::updateContents):

WebKit/mac:

Rubber-stamped by John Sullivan.

  • rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen, rename related methods and variables accordingly, and make -setShouldUpdateWhileOffscreen: and -shouldUpdateWhileOffscreen WebView API.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage):
  • WebView/WebFrame.mm: (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.mm: (-[WebHTMLView windowWillOrderOnScreen:]):
  • WebView/WebView.h:
  • WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebView setBackgroundColor:]): (-[WebView setDrawsBackground:]): (-[WebView setShouldUpdateWhileOffscreen:]): (-[WebView shouldUpdateWhileOffscreen]):
  • WebView/WebViewPrivate.h:
5:13 PM Changeset in webkit [35867] by beidson@apple.com
  • 2 edits in trunk/WebCore

2008-08-20 Brady Eidson <​beidson@apple.com>

Reviewed by Mitzpettel

<rdar://problem/6163636> - Many images broken in Mail

This can be traced back to the preload scanner. With that change, CachedResources are created a lot
sooner than before and confuse the WebArchive machinery.

When referencing WebArchive subresources directly through the WebKit API it is appropriate to ignore
such CachedResources since they are placeholders and have not been submitted to the ResourceLoadDelegate
machinery and nothing is known about where the data will eventually come from.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): Ignore a CachedResource if its preloadResult is CachedResource::PreloadReferenced.
4:20 PM Changeset in webkit [35866] by mrowe@apple.com
  • 7 edits in trunk/WebKit/mac

Switch to non-deprecated NSFileManager APIs.

In order to minimize #if's the new NSFileManager APIs have been implemented for
Tiger and call sites updated to use the new methods.

Reviewed by Darin Adler.

4:04 PM Changeset in webkit [35865] by Simon Fraser
  • 2 adds in trunk/LayoutTests/fast/css

Reviewed by Dave Hyatt

getComputedStyle() for webkitTransform should return a transform
that does not have the transform origin baked into it.
​https://bugs.webkit.org/show_bug.cgi?id=20464

  • fast/css/getComputedStyle-transform-expected.txt: Added.
  • fast/css/getComputedStyle-transform.html: Added.

(Missed these test files on last commit)

3:50 PM Changeset in webkit [35864] by zecke@webkit.org
  • 3 edits in trunk/WebCore

2008-08-20 Holger Hans Peter Freyther <​zecke@selfish.org>

Unreviewed compile fix

Catch up with the JSValue::type elimination.

  • bridge/qt/qt_instance.cpp: (KJS::Bindings::QtRuntimeObjectImp::construct): (KJS::Bindings::QtInstance::defaultValue):
  • bridge/qt/qt_runtime.cpp: (KJS::Bindings::QtRuntimeConnectionMethod::call):
3:15 PM Changeset in webkit [35863] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-08-20 Chris Teague <​chris.teague@gmail.com>

Reviewed by Mark Rowe.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=20449
Bug 20449: Build fails if LOW_BANDWIDTH_DISPLAY is defined

  • ChangeLog:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
2:57 PM Changeset in webkit [35862] by Simon Fraser
  • 5 edits in trunk

Reviewed by Dave Hyatt

getComputedStyle() for webkitTransform should return a transform
that does not have the transform origin baked into it.
​https://bugs.webkit.org/show_bug.cgi?id=20464

Test: fast/css/getComputedStyle-transform.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::computedTransform):
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::applyTransform):
  • rendering/style/RenderStyle.h:
2:04 PM Changeset in webkit [35861] by andersca@apple.com
  • 6 edits in trunk

WebCore:

2008-08-20 Josh Aas <​joshmoz@gmail.com>

Reviewed and landed by Anders.

<rdar://problem/6163636>
rename NPCocoaEvent's "event" struct to "data" (20446)


  • bridge/npapi.h: (_NPCocoaEvent::):

WebKit/mac:

2008-08-20 Josh Aas <​joshmoz@gmail.com>

Reviewed and landed by Anders.

<rdar://problem/6163636>
rename NPCocoaEvent's "event" struct to "data" (20446)

  • Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::drawRect): (WebNetscapePluginEventHandlerCocoa::sendMouseEvent): (WebNetscapePluginEventHandlerCocoa::flagsChanged): (WebNetscapePluginEventHandlerCocoa::sendKeyEvent): (WebNetscapePluginEventHandlerCocoa::windowFocusChanged): (WebNetscapePluginEventHandlerCocoa::focusChanged):

WebKitExamplePlugins:

2008-08-20 Josh Aas <​joshmoz@gmail.com>

Reviewed and landed by Anders.

<rdar://problem/6163636>
rename NPCocoaEvent's "event" struct to "data" (20446)

  • NetscapeCocoaPlugin/main.m: (handleMouseEvent): (handleKeyboardEvent): (NPP_HandleEvent):
1:46 PM Changeset in webkit [35860] by Beth Dakin
  • 12 edits in trunk

WebCore:

2008-08-20 Beth Dakin <Beth Dakin>

Reviewed by Darin.

Fix for <rdar://problem/6145626>
This patch fixes a number of remaining problems getting
disconnected frames to work correctly with markAllMatchesForText()
and findString(). Details inline.

This was a static helper function in Frame, but this patch requires
the same functionality in Editor, so I just added it as a function
on Node.

  • dom/Node.cpp: (WebCore::Node::isInShadowTree):
  • dom/Node.h:
  • editing/Editor.cpp: (WebCore::Editor::insideVisibleArea): Returns false if excludeFromTextSearch() is true.

In a normal (non-disconnected) frame, findString returns a range of
the document node if the text is not found in the frame. I changed
firstVisibleRange and lastVisibleRange to match that behavior when
the text is not found
(WebCore::Editor::firstVisibleRange):
(WebCore::Editor::lastVisibleRange):

Here are the bulk of the changes in the patch. A lot of text was
not being found in disconnected frames because I failed to account
for all of the possible problems associated with shadow trees. That
is fixed here.
(WebCore::Editor::nextVisibleRange):

  • editing/Editor.h:

excludeFromTextSearch() is new. It allows a WebKit client to mark a
frame as not-text-searchable through SPI.

  • WebCore.base.exp:
  • page/Frame.cpp: (WebCore::Frame::excludeFromTextSearch): (WebCore::Frame::setExcludeFromTextSearch): (WebCore::FramePrivate::FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:

(WebCore::Frame::findString):
(WebCore::Frame::markAllMatchesForText): I kept running into an
assertion failure in paining code because of the forced paint on
empty visible rects.

WebKit/mac:

2008-08-20 Beth Dakin <Beth Dakin>

Reviewed by Darin.

Fix for <rdar://problem/6145626>
Allows a WebKit client to mark a frame as not-text-searchable
through SPI.

  • WebView/WebFrame.mm: (-[WebFrame _setExcludeFromTextSearch:]):
  • WebView/WebFramePrivate.h:
12:10 PM Changeset in webkit [35859] by timothy@apple.com
  • 4 edits in trunk/WebCore

Adds a positon box to the Inspector's Metrics sidebar
pane. When an element is not statically positioned, there
is now a position box that show top, right, bottom and
left computed values.

Reviewed by Kevin McCullough.

  • English.lproj/localizedStrings.js: Updated the strings.
  • page/inspector/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.update): Renamed the boxPartValue function to createBoxPartElement and made it create the entire element. Made it understand how to get position style properties. Don't use the figure dash when 0px is used for positions, since the 0 is meaningful there. Instead use the figure dash when a position is auto.
  • page/inspector/inspector.css: Added a new rule for position.
12:01 PM Changeset in webkit [35858] by britto@apple.com
  • 5 edits in trunk

2008-08-20 Maxime Britto <​britto@apple.com>

Reviewed by Ada Chan.

rdar://5259746
Mouse events are sent to page while resizing window (affects Gmail)
In the WebView, if the MouseEvent is located in the resize corner, we send it back to the UIDelegate and early return.

  • Interfaces/IWebUIDelegatePrivate.idl: Add a new method to the UIDelegate to send the resize message
  • WebView.cpp: (WebView::handleMouseEvent): If the mouse event is in the resize corner and our UIDelegate supports the message it sends the new message and early returns

2008-08-20 Maxime Britto <​britto@apple.com>

Reviewed by Ada Chan.

rdar://5259746

Mouse events are sent to page while resizing window (affects Gmail)

  • DumpRenderTree/win/UIDelegate.h: (UIDelegate::webViewSendResizeMessage): Add the new interface method, not implemented.
11:34 AM Changeset in webkit [35857] by Chris Fleizach
  • 2 edits in trunk/WebCore

Qt build fix

11:28 AM Changeset in webkit [35856] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

  • avoid using a deprecated NSScroller method on Leopard
  • platform/mac/PlatformScrollBarMac.mm: (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion):
4:40 AM Changeset in webkit [35855] by jmalonzo@webkit.org
  • 3 edits in trunk/WebCore

2008-08-20 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Oliver Hunt.

Gtk build fix

  • GNUmakefile.am:
  • page/AccessibilityTable.cpp: Change nil to 0 (WebCore::AccessibilityTable::cellForColumnAndRow):
3:40 AM Changeset in webkit [35854] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

  • API/WebKitAvailability.h: Define DEPRECATED_ATTRIBUTE.
12:23 AM Changeset in webkit [35853] by ap@webkit.org
  • 100 edits
    5 adds in trunk

Reviewed by Geoff Garen.

Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.

Note: See TracTimeline for information about the timeline view.