Timeline



Aug 28, 2008:

10:20 PM Changeset in webkit [35986] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-08-28 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Rubber-stamped by Sam Weinig.

Change 'term' to 'expr' in variable names to standardize terminology.

  • kjs/nodes.cpp: (KJS::BinaryOpNode::emitCode): (KJS::ReverseBinaryOpNode::emitCode): (KJS::ThrowableBinaryOpNode::emitCode):
  • kjs/nodes.h: (KJS::BinaryOpNode::BinaryOpNode): (KJS::ReverseBinaryOpNode::ReverseBinaryOpNode): (KJS::MultNode::): (KJS::DivNode::): (KJS::ModNode::): (KJS::AddNode::): (KJS::SubNode::): (KJS::LeftShiftNode::): (KJS::RightShiftNode::): (KJS::UnsignedRightShiftNode::): (KJS::LessNode::): (KJS::GreaterNode::): (KJS::LessEqNode::): (KJS::GreaterEqNode::): (KJS::ThrowableBinaryOpNode::): (KJS::InstanceOfNode::): (KJS::InNode::): (KJS::EqualNode::): (KJS::NotEqualNode::): (KJS::StrictEqualNode::): (KJS::NotStrictEqualNode::): (KJS::BitAndNode::): (KJS::BitOrNode::): (KJS::BitXOrNode::):
  • kjs/nodes2string.cpp: (KJS::MultNode::streamTo): (KJS::DivNode::streamTo): (KJS::ModNode::streamTo): (KJS::AddNode::streamTo): (KJS::SubNode::streamTo): (KJS::LeftShiftNode::streamTo): (KJS::RightShiftNode::streamTo): (KJS::UnsignedRightShiftNode::streamTo): (KJS::LessNode::streamTo): (KJS::GreaterNode::streamTo): (KJS::LessEqNode::streamTo): (KJS::GreaterEqNode::streamTo): (KJS::InstanceOfNode::streamTo): (KJS::InNode::streamTo): (KJS::EqualNode::streamTo): (KJS::NotEqualNode::streamTo): (KJS::StrictEqualNode::streamTo): (KJS::NotStrictEqualNode::streamTo): (KJS::BitAndNode::streamTo): (KJS::BitXOrNode::streamTo): (KJS::BitOrNode::streamTo):
10:09 PM Changeset in webkit [35985] by alp@webkit.org
  • 6 edits in trunk

2008-08-28 Alp Toker <​alp@nuanti.com>

GTK+ dist/build fix. List newly added header files.

6:13 PM Changeset in webkit [35984] by weinig@apple.com
  • 7 edits in trunk

JavaScriptCore:

2008-08-28 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Change to throw a ReferenceError at runtime instead of a ParseError
at parse time, when the left hand side expression of a for-in statement
is not an lvalue.

  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::ForInNode::emitCode):

LayoutTests:

2008-08-28 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Update test results now that test actually works.

  • fast/js/kde/exception_propagation-expected.txt:
  • fast/js/kde/resources/exception_propagation.js:
4:04 PM Changeset in webkit [35983] by Simon Fraser
  • 7 edits
    2 adds in trunk

2008-08-28 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Various WebKitCSSTransformValue-related fixes
​https://bugs.webkit.org/show_bug.cgi?id=20562

Test: css3/transform-value-types.html

  • bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS):
  • css/CSSValue.h:
  • css/WebKitCSSTransformValue.cpp: (WebCore::WebKitCSSTransformValue::cssText):
  • css/WebKitCSSTransformValue.h: (WebCore::WebKitCSSTransformValue::):
  • css/WebKitCSSTransformValue.idl:
3:53 PM Changeset in webkit [35982] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Steve Falkenburg.

  • do not let the "last chance" WM_TIMER trigger WebCore timers when they should be deferred
  • platform/win/SharedTimerWin.cpp: (WebCore::TimerWindowWndProc):
2:45 PM Changeset in webkit [35981] by hyatt@apple.com
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Make sure new header files are put in private headers.

2:40 PM Changeset in webkit [35980] by Simon Fraser
  • 2 edits in trunk/LayoutTests

2008-08-28 Simon Fraser <Simon Fraser>

Fix window properties now that CSSRule includes
keyframe-related constants.
Also add window.console.count [function]
​https://bugs.webkit.org/show_bug.cgi?id=20552

  • fast/dom/Window/window-properties-expected.txt:
2:38 PM Changeset in webkit [35979] by hyatt@apple.com
  • 12 edits
    7 adds in trunk/WebCore

2008-08-28 David Hyatt <​hyatt@apple.com>

RenderStyle cleanup.

Break out StyleImage, StyleGeneratedImage, StyleCachedImage and NinePieceImage into separate files.

Reviewed by Adam

  • css/CSSImageGeneratorValue.cpp:
  • css/CSSImageValue.cpp:
  • css/CSSStyleSelector.cpp:
  • rendering/RenderImageGeneratedContent.cpp:
  • rendering/style/NinePieceImage.cpp: Added.
  • rendering/style/NinePieceImage.h: Added.
  • rendering/style/RenderStyle.cpp: (WebCore::FillLayer::operator==): (WebCore::FillLayer::containsImage): (WebCore::StyleInheritedData::operator==): (WebCore::RenderStyle::contentDataEquivalent):
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleCachedImage.cpp: Added.
  • rendering/style/StyleCachedImage.h: Added.
  • rendering/style/StyleGeneratedImage.cpp: Added.
  • rendering/style/StyleGeneratedImage.h: Added.
  • rendering/style/StyleImage.h: Added.
2:29 PM Changeset in webkit [35978] by Simon Fraser
  • 5 edits in trunk/WebCore

2008-08-28 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Make all the 'isFoo()' methods on CSSValue const,
and fix the subclasses.

​https://bugs.webkit.org/show_bug.cgi?id=20561

  • css/CSSTimingFunctionValue.h:
  • css/CSSValue.h: (WebCore::CSSValue::isFontValue): (WebCore::CSSValue::isImageGeneratorValue): (WebCore::CSSValue::isImageValue): (WebCore::CSSValue::isImplicitInitialValue):
  • css/CSSValueList.h:
  • css/FontValue.h:
1:48 PM Changeset in webkit [35977] by kmccullough@apple.com
  • 2 edits in trunk/WebKit/mac

2008-08-28 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Geoff.

<rdar://problem/6095949> REGRESSION (5525.8-6527.1?): "this" is null
when you first hit a breakpoint in Dashcode

  • We wanted to reset the callframe whenever eval() was called but dashcode uses eval() when broken to evaluate the state of the current call frame.
  • WebView/WebScriptDebugger.mm: (WebScriptDebugger::willExecuteProgram): (WebScriptDebugger::didExecuteProgram):
1:08 PM Changeset in webkit [35976] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2008-08-28 David Hyatt <​hyatt@apple.com>

The great RenderStyle cleanup begins!

Move LengthBox and LengthSize out of RenderStyle and into Length.

Reviewed by Adam

  • rendering/Length.h: (WebCore::): (WebCore::Length::Length): (WebCore::Length::operator==): (WebCore::Length::operator!=): (WebCore::Length::value): (WebCore::Length::rawValue): (WebCore::Length::percent): (WebCore::Length::type): (WebCore::Length::quirk): (WebCore::Length::setValue): (WebCore::Length::setRawValue): (WebCore::Length::calcValue): (WebCore::Length::calcMinValue): (WebCore::Length::calcFloatValue): (WebCore::Length::isUndefined): (WebCore::Length::isZero): (WebCore::Length::isPositive): (WebCore::Length::isNegative): (WebCore::Length::isAuto): (WebCore::Length::isRelative): (WebCore::Length::isPercent): (WebCore::Length::isFixed): (WebCore::Length::isStatic): (WebCore::Length::isIntrinsicOrAuto): (WebCore::Length::blend): (WebCore::LengthBox::LengthBox): (WebCore::LengthBox::operator=): (WebCore::LengthBox::operator==): (WebCore::LengthBox::operator!=): (WebCore::LengthBox::nonZero): (WebCore::LengthSize::LengthSize):
  • rendering/style/RenderStyle.h:
12:53 PM Changeset in webkit [35975] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2008-08-28 David Hyatt <​hyatt@apple.com>

Reviewed by Darin

​https://bugs.webkit.org/show_bug.cgi?id=18091

font-size should be animatable using -webkit-transition.

  • page/AnimationController.cpp: (WebCore::AnimationControllerPrivate::ensurePropertyMap):
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::setFontSize):
11:08 AM Changeset in webkit [35974] by adele@apple.com
  • 2 edits in trunk/WebKit/win

2008-08-28 Adele Peterson <​adele@apple.com>

Build fix.

  • WebIconDatabase.cpp: (WebIconDatabase::getOrCreateDefaultIconBitmap):
10:45 AM Changeset in webkit [35973] by mitz@apple.com
  • 2 edits in trunk/WebCore

2008-08-28 Brad Garcia <​bgarcia@google.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=20549
Correctly determine when cursor is over a resizable border within
a nested frameset.

  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::canResizeRow): (WebCore::RenderFrameSet::canResizeColumn):
10:30 AM Changeset in webkit [35972] by Simon Fraser
  • 3 edits
    6 adds in trunk

2008-08-28 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel

Add RuleTypes to CSSRule.idl for keyframes and keyframe rules.
​https://bugs.webkit.org/show_bug.cgi?id=20552

Test: animations/animation-css-rule-types.html

  • css/CSSRule.idl:
10:26 AM Changeset in webkit [35971] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-08-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin and Darin.

<rdar://problem/6182541>
​https://bugs.webkit.org/show_bug.cgi?id=20202
Missing http status line from the http headers.


Add a status line to the header string.


  • plugins/PluginStream.cpp: (WebCore::PluginStream::startStream):
8:56 AM Changeset in webkit [35970] by zecke@webkit.org
  • 6 edits
    1 delete in trunk

WebCore:
2008-08-28 Holger Hans Peter Freyther <​zecke@selfish.org>

Rubber-stamped by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=17261

Make it possible to theme the default Url icon and enable this for
the Qt port. To have a minimal usage of #ifdef in the code the setting
of the icon was moved to a new method which comes in two flavors.

  • loader/icon/IconDatabase.cpp: (WebCore::loadDefaultIconRecord): Load or set the default icon (WebCore::IconDatabase::defaultIcon):

WebKit/win:
2008-08-28 Holger Hans Peter Freyther <​zecke@selfish.org>

Rubber-stamped by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=17261

Remove the urlIcon.png from the project and the resource file. Remove
the usage of this icon from WebKitDLL.cpp and change WebIconDatabase
to get the icon from the IconDatabase code which is using a version of
the icon that is compiled into the code.

  • WebIconDatabase.cpp: (WebIconDatabase::getOrCreateDefaultIconBitmap): Use the icon from the IconDatabase.cpp
  • WebKit.vcproj/WebKit.rc: Remove urlIcon.cpp
  • WebKit.vcproj/urlIcon.png: Removed.
  • WebKitDLL.cpp: (loadResourceIntoBuffer): Remove "urlIcon"
8:03 AM Changeset in webkit [35969] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2008-08-28 Holger Hans Peter Freyther <​zecke@selfish.org>

Unreviewed compile fix

  • platform/graphics/qt/GraphicsContextQt.cpp: Remove redefinitions
6:34 AM Changeset in webkit [35968] by Adam Roben
  • 2 edits in trunk/WebCore

Windows (and others?) build fix

  • page/Chrome.cpp: Added a missing #include. (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Fixed typo.
5:04 AM Changeset in webkit [35967] by eric@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by Oliver Hunt.

Qt and Cairo support from krit (and blind stab @ wx compile support)
​https://bugs.webkit.org/show_bug.cgi?id=20373

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::drawPath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setImageInterpolationQuality): (WebCore::GraphicsContext::imageInterpolationQuality): (WebCore::GraphicsContext::setPlatformFillPattern): (WebCore::GraphicsContext::setPlatformStrokePattern): (WebCore::GraphicsContext::setPlatformFillGradient): (WebCore::GraphicsContext::setPlatformStrokeGradient):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::clipToImageBuffer): (WebCore::GraphicsContext::setPlatformFillPattern): (WebCore::GraphicsContext::setPlatformStrokePattern): (WebCore::GraphicsContext::setPlatformFillGradient): (WebCore::GraphicsContext::setPlatformStrokeGradient): (WebCore::GraphicsContext::setImageInterpolationQuality): (WebCore::GraphicsContext::imageInterpolationQuality):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::clipToImageBuffer): (WebCore::GraphicsContext::setImageInterpolationQuality): (WebCore::GraphicsContext::imageInterpolationQuality): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::drawPath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformFillPattern): (WebCore::GraphicsContext::setPlatformStrokePattern): (WebCore::GraphicsContext::setPlatformFillGradient):
5:04 AM Changeset in webkit [35966] by eric@webkit.org
  • 23 edits in trunk/WebCore

Reviewed by Oliver Hunt.

Add stroke/fill Gradient and Pattern support to GraphicsContext and update <canvas> to use it.
​https://bugs.webkit.org/show_bug.cgi?id=20373

Changed pattern() to canvasPattern() on CanvasStyle to match canvasGradient()

Made Generator (aka Gradient) RefCounted so that GraphicsContext didn't
have to store large Gradient objects in the GraphicsContextState

Made Pattern RefCounted for the same reason.

Many updates to GraphicsContext to support easier drawing with
Patterns and Gradients.

  • WebCore.xcodeproj/project.pbxproj: Add pre-existing GraphicsContextPrivate.h
  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::toJS):
  • css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::createGradient):
  • css/CSSGradientValue.h:
  • html/CanvasGradient.cpp: (WebCore::CanvasGradient::CanvasGradient):
  • html/CanvasGradient.h: (WebCore::CanvasGradient::gradient): (WebCore::CanvasGradient::addColorStop): (WebCore::CanvasGradient::getColor):
  • html/CanvasPattern.cpp:
  • html/CanvasPattern.h: (WebCore::CanvasPattern::pattern): (WebCore::CanvasPattern::originClean):
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::State::State): (WebCore::CanvasRenderingContext2D::setStrokeStyle): (WebCore::CanvasRenderingContext2D::setFillStyle): (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::strokeRect):
  • html/CanvasRenderingContext2D.h:
  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
  • html/CanvasStyle.h:
  • platform/graphics/GeneratedImage.h: (WebCore::GeneratedImage::GeneratedImage):
  • platform/graphics/Generator.h:
  • platform/graphics/Gradient.h: (WebCore::Gradient::create):
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::fillRule): (WebCore::GraphicsContext::setFillRule): (WebCore::GraphicsContext::setStrokePattern): (WebCore::GraphicsContext::setFillPattern): (WebCore::GraphicsContext::setStrokeGradient): (WebCore::GraphicsContext::setFillGradient):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContextPrivate.h: (WebCore::): (WebCore::GraphicsContextState::GraphicsContextState):
  • platform/graphics/GraphicsTypes.h:
  • platform/graphics/Path.h:
  • platform/graphics/Pattern.h: (WebCore::Pattern::create): (WebCore::Pattern::tileImage):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::calculateDrawingMode): (WebCore::GraphicsContext::drawPath): (WebCore::fillPathWithFillRule): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformStrokePattern): (WebCore::GraphicsContext::setPlatformFillPattern): (WebCore::GraphicsContext::setPlatformStrokeGradient): (WebCore::GraphicsContext::setPlatformFillGradient):
4:44 AM Changeset in webkit [35965] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Not reviewed, build fix (at least for OpenBSD, posssibly more).

​https://bugs.webkit.org/show_bug.cgi?id=20545
missing #include <unistd.h> in JavaScriptCore/VM/SamplingTool.cpp

  • VM/SamplingTool.cpp: add the missing include.
4:42 AM Changeset in webkit [35964] by eric@webkit.org
  • 8 edits in trunk/WebCore

Reviewed by Darin and Alexey.

Close a leak of PausedTimeouts if the JavaScriptDebugServer was destroyed
with timeouts paused.
​https://bugs.webkit.org/show_bug.cgi?id=20469

I attempted to clean up the memory management of PausedTimeouts, I'm not
sure the solution I came up with is "cleaner", but it's in some ways
"safer", since it no longer uses raw pointers and manual new/delete.

This also now prevents CachedPage from needlessly creating Window
objects when caching pages which didn't already have one. :)

I also made Chrome.cpp no longer depend on the JavaScript bindings
(aka JSDOMWindowBase.h), since there was no real reason for it to.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::pauseTimeouts): (WebCore::JSDOMWindowBase::resumeTimeouts):
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::pauseTimeouts): (WebCore::ScriptController::resumeTimeouts):
  • bindings/js/ScriptController.h:
  • history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::restore):
  • page/Chrome.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
  • page/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::~JavaScriptDebugServer): (WebCore::JavaScriptDebugServer::setJavaScriptPaused):

Aug 27, 2008:

8:36 PM Changeset in webkit [35963] by zecke@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2008-08-27 Holger Hans Peter Freyther <​zecke@selfish.org>

Unreviewed compile fix

Add the stub for the Qt port.

  • WebCore.pro:
  • page/qt/AccessibilityObjectQt.cpp: Added. (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
8:25 PM Changeset in webkit [35962] by zecke@webkit.org
  • 4 edits in trunk/WebKit/qt

2008-08-27 Erik Bunce <​elbunce@thehive.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=20223

Add QWebPage::contentsChanged() signal to notify of content changes.

  • Api/qwebpage.cpp:
  • Api/qwebpage.h:
  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::respondToChangedContents):
7:18 PM Changeset in webkit [35961] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2008-08-27 Alp Toker <​alp@nuanti.com>

Reviewed by Eric.

​https://bugs.webkit.org/show_bug.cgi?id=20551
[GTK] search popup crash

  • platform/gtk/SearchPopupMenuGtk.cpp: (WebCore::SearchPopupMenu::enabled): Fix a search popup crasher by disabling the history popup since we don't support this feature yet in the GTK+ port.
7:15 PM Changeset in webkit [35960] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2008-08-27 Alp Toker <​alp@nuanti.com>

Reviewed by Eric.

​https://bugs.webkit.org/show_bug.cgi?id=20551
[GTK] curl crashers

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::startScheduledJobs): Remove the resource handle from the pending list before starting the job, not afterwards. Fixes crashers in the test suite.

Test: fast/dom/clientWidthAfterDocumentIsRemoved.html
Test: fast/encoding/char-encoding.html

7:11 PM Changeset in webkit [35959] by alice.liu@apple.com
  • 4 edits in trunk/WebKit/win

2008-08-27 Alice Liu <​alice.liu@apple.com>

Add interface for obtaining JS object counts broken down by type

Reviewed by Steve Falkenburg.

  • Interfaces/IWebCoreStatistics.idl:
  • WebCoreStatistics.cpp: (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
  • WebCoreStatistics.h:
6:42 PM Changeset in webkit [35958] by zecke@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-08-27 Adrien Nader <​camaradetux@gmail.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=20099
[GTK] SHIFT+PAGE_UP/DOWN doesn't extend selection

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeyboardEvent):
6:20 PM Changeset in webkit [35957] by zecke@webkit.org
  • 2 edits
    1 add in trunk

2008-08-27 Mike Hommey <​glandium@debian.org>

Reviewed by Holger.

  • GNUmakefile.am:
  • symbols.filter: Added.
5:50 PM Changeset in webkit [35956] by weinig@apple.com
  • 3 edits
    2 adds in trunk

WebKit/mac:

2008-08-27 Robert Kroeger <​rjkroege@liqui.org>

Tweaked by Sam Weinig.

Reviewed by Eric Seidel.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=6595
<rdar://problem/4432150>
Right-click does not fire mouseup event

Adds a rightMouseUp handler to the WebHTMLView.

The added method generates mouseup events for button 2. The result
is that webkit will deliver mousedown and mouseup events for button
2 in a fashion identical to FireFox and will retain event ordering
identical to Internet Explorer.

Test: fast/events/mouseup-from-button2.html

  • WebView/WebHTMLView.mm: (-[WebHTMLView rightMouseUp:]):

LayoutTests:

2008-08-27 Robert Kroeger <​rjkroege@liqui.org>

Reviewed by Eric Seidel.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=6595

  • fast/events/mouseup-from-button2-expected.txt: Added.
  • fast/events/mouseup-from-button2.html: Added.
5:26 PM Changeset in webkit [35955] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by eseidel.

Fix canvas drawImage to support composite operations.
Composite had no effect on canvas elements like these:
​http://philip.html5.org/tests/canvas/suite/tests/index.2d.composite.canvas.html

[CAIRO] Canvas composite don't work on canvas-elements.
​https://bugs.webkit.org/show_bug.cgi?id=20548

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): pass the current composite operator to the drawImage call
5:04 PM Changeset in webkit [35954] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Eric Seidel.

Fix the data content of an image with a base64.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl): Remove the String and use only the data Vector because the data.latin1().data() convert the data content and the image test ( ​https://bugs.webkit.org/attachment.cgi?id=21726 ) is not drawn correctly.
4:59 PM Changeset in webkit [35953] by Antti Koivisto
  • 2 edits in trunk/WebCore

2008-08-27 Antti Koivisto <Antti Koivisto>

Reviewed by Eric Seidel.

Crash after OK in dialog box and reloading page in secure mode
​https://bugs.webkit.org/show_bug.cgi?id=20493


The new run loop spawned by a modal dialog causes a timer in the loader to run
synchronously inside didFinishLoading() deleting "this" object.


Defer all WebCore timers when a modal dialog is up. They are not
safe to execute.

  • page/Chrome.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
4:16 PM Changeset in webkit [35952] by Simon Fraser
  • 3 edits in trunk/WebCore

2008-08-27 Chris Marrin <​cmarrin@apple.com>

Reviewed by Dave Hyatt

Memory leaks when animating transforms
​https://bugs.webkit.org/show_bug.cgi?id=20532

  • rendering/style/RenderStyle.cpp: (WebCore::ScaleTransformOperation::blend): (WebCore::RotateTransformOperation::blend): (WebCore::SkewTransformOperation::blend): (WebCore::TranslateTransformOperation::blend): (WebCore::MatrixTransformOperation::blend):
  • rendering/style/RenderStyle.h:
3:54 PM Changeset in webkit [35951] by adachan@apple.com
  • 2 edits in trunk/WebKit/win

Fixed build.

  • WebFrame.cpp: (WebFrame::pluginWillHandleLoadError):
3:03 PM Changeset in webkit [35950] by timothy@apple.com
  • 13 edits in trunk

Add support for support for -webkit-appearance: default-button on the Mac platform.

WebCore:

2008-08-27 Timothy Hatcher <​timothy@apple.com>

Add support for support for -webkit-appearance: default-button on the Mac platform.

<rdar://problem/6173530>

Reviewed by Dave Hyatt.

  • WebCore.base.exp: Export new symbols.
  • platform/mac/WebCoreSystemInterface.h: Add wkAdvanceDefaultButtonPulseAnimation.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.
  • rendering/RenderButton.cpp: (WebCore::RenderButton::RenderButton): Remove #if PLATFORM(WIN). (WebCore::RenderButton::setStyle): Ditto.
  • rendering/RenderButton.h: Ditto.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustRepaintRect): Add a case for DefaultButtonAppearance. (WebCore::RenderThemeMac::setButtonCellState): Set the key equivalent to the return key if the button is default, otherwise reset the key equivalent. (WebCore::RenderThemeMac::paintButton): If the button is default call setDefaultButtonCell: on the window, then wkAdvanceDefaultButtonPulseAnimation before painting. Restore the window's previous default button cell when finished.

WebKit/mac:

2008-08-27 Timothy Hatcher <​timothy@apple.com>

Add support for support for -webkit-appearance: default-button on the Mac platform.

<rdar://problem/6173530>

Reviewed by Dave Hyatt.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Init AdvanceDefaultButtonPulseAnimation.
  • WebView/WebPreferenceKeysPrivate.h: Added WebKitApplicationChromeModeEnabledPreferenceKey.
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): Set WebKitApplicationChromeModeEnabledPreferenceKey to NO. (-[WebPreferences applicationChromeModeEnabled]): Added. (-[WebPreferences setApplicationChromeModeEnabledEnabled:]): Added.
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Call Settings::setApplicationChromeMode with the value of -[WebPreferences applicationChromeModeEnabled].
2:18 PM Changeset in webkit [35949] by hyatt@apple.com
  • 5 edits in trunk/WebCore

2008-08-26 David Hyatt <​hyatt@apple.com>

First cut at making form controls on OS X respect full page zoom. There are lots of bugs.

Reviewed by weinig

Added fast/forms/zoomed-controls.html

  • css/CSSStyleSelector.cpp: (WebCore::addIntrinsicMargins):
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::calcPrefWidths):
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustRepaintRect): (WebCore::RenderThemeMac::inflateRect): (WebCore::RenderThemeMac::baselinePosition): (WebCore::RenderThemeMac::setControlSize): (WebCore::RenderThemeMac::sizeForFont): (WebCore::RenderThemeMac::sizeForSystemFont): (WebCore::RenderThemeMac::setFontFromControlSize): (WebCore::RenderThemeMac::paintCheckbox): (WebCore::RenderThemeMac::setCheckboxCellState): (WebCore::RenderThemeMac::paintRadio): (WebCore::RenderThemeMac::setRadioCellState): (WebCore::RenderThemeMac::setButtonPaddingFromControlSize): (WebCore::RenderThemeMac::adjustButtonStyle): (WebCore::RenderThemeMac::setButtonCellState): (WebCore::RenderThemeMac::paintButton): (WebCore::RenderThemeMac::paintMenuList): (WebCore::RenderThemeMac::paintMenuListButton): (WebCore::RenderThemeMac::popupInternalPaddingLeft): (WebCore::RenderThemeMac::popupInternalPaddingRight): (WebCore::RenderThemeMac::popupInternalPaddingTop): (WebCore::RenderThemeMac::popupInternalPaddingBottom): (WebCore::RenderThemeMac::setPopupButtonCellState): (WebCore::RenderThemeMac::paintSliderTrack): (WebCore::RenderThemeMac::paintSliderThumb): (WebCore::RenderThemeMac::adjustSliderThumbSize): (WebCore::RenderThemeMac::paintSearchField): (WebCore::RenderThemeMac::adjustSearchFieldStyle): (WebCore::RenderThemeMac::paintSearchFieldCancelButton): (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
1:29 PM Changeset in webkit [35948] by timothy@apple.com
  • 4 edits in trunk/WebKitLibraries

Adds the WKAdvanceDefaultButtonPulseAnimation function.

<rdar://problem/6173530> Add Mac support for -webkit-appearance: default-button

Reviewed by Adele Peterson.

  • WebKitSystemInterface.h: Added WKAdvanceDefaultButtonPulseAnimation.
  • libWebKitSystemInterfaceLeopard.a: Updated.
  • libWebKitSystemInterfaceTiger.a: Updated.
1:12 PM Changeset in webkit [35947] by mrowe@apple.com
  • 68 moves in tags/old

Move aside more old tags.

12:59 PM Changeset in webkit [35946] by beidson@apple.com
  • 16 edits in trunk

WebCore:

2008-08-27 Brady Eidson <​beidson@apple.com>

Reviewed by Anders

<rdar://problem/6134133> - Crash when loading large movie as a standalone document

We hand off these loads to Quicktime which manages and spools the data itself, but we also continued
to load and buffer the data for the movie in WebCore. With large media files, this results in blowing
away the virtual address space and a crash.

  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::pluginWillHandleLoadError):
  • loader/FrameLoaderClient.h: Added client method to get platform specific error for "plugin will handle load"
  • loader/MediaDocument.cpp: (WebCore::MediaTokenizer::createDocumentStructure): Tell the MainResourceLoader to not buffer data, and cancel the WebCore-managed load (WebCore::MediaTokenizer::writeRawData): (WebCore::MediaTokenizer::finish):

WebKit/gtk:

2008-08-27 Brady Eidson <​beidson@apple.com>

Reviewed by Anders

<rdar://problem/6134133> - Crash when loading large movie as a standalone document

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::pluginWillHandleLoadError): Stubbed for now
  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

2008-08-27 Brady Eidson <​beidson@apple.com>

Reviewed by Anders

<rdar://problem/6134133> - Crash when loading large movie as a standalone document

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::pluginWillHandleLoadError):

WebKit/qt:

2008-08-27 Brady Eidson <​beidson@apple.com>

Reviewed by Anders

<rdar://problem/6134133> - Crash when loading large movie as a standalone document

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::pluginWillHandleLoadError): Stubbed for now
  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

2008-08-27 Brady Eidson <​beidson@apple.com>

Reviewed by Anders

<rdar://problem/6134133> - Crash when loading large movie as a standalone document

  • WebFrame.cpp: (WebFrame::pluginWillHandleLoadError):
  • WebFrame.h:
12:53 PM Changeset in webkit [35945] by mrowe@apple.com
  • 855 moves
    1 add in /

Move aside old tags and branches.

12:47 PM Changeset in webkit [35944] by alice.liu@apple.com
  • 3 edits in trunk/WebKit/win

2008-08-26 Alice Liu <​alice.liu@apple.com>

Implement COMPropertyBag::GetPropertyInfo
and a variant setter for type int

Reviewed by Anders Carlsson.

  • COMPropertyBag.h: (::GetPropertyInfo):
  • COMVariantSetter.h:
11:19 AM Changeset in webkit [35943] by Simon Fraser
  • 6 edits in trunk

2008-08-26 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel

Linear timing functions should have control points 0, 0, 1, 1.
​https://bugs.webkit.org/show_bug.cgi?id=20535

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::mapAnimationTimingFunction):
  • rendering/style/RenderStyle.h:
7:52 AM Changeset in webkit [35942] by Adam Roben
  • 2 edits in trunk/WebCore

Windows build fix

  • WebCore.vcproj/WebCore.vcproj: Fix file extension.

Aug 26, 2008:

9:35 PM WikiStart edited by wsiegrist@apple.com
Fixed register and login links (diff)
5:14 PM Changeset in webkit [35941] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2008-08-26 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=20456

  • http/tests/security/object-literals-expected.txt: Added.
  • http/tests/security/object-literals.html: Added.
  • http/tests/security/resources/object-literals-cross-origin.html: Added.
  • http/tests/security/resources/object-literals-same-origin.html: Added.
4:47 PM Changeset in webkit [35940] by kmccullough@apple.com
  • 3 edits
    3 adds in trunk

JavaScriptCore:

2008-08-26 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Geoff and Cameron.

<rdar://problem/6174603> Hitting assertion in Register::codeBlock when
loading facebook (20516).

  • This was a result of my line numbers change. After a host function is called the stack does not get reset correctly.
  • Oddly this also appears to be a slight speedup on SunSpider.
  • VM/Machine.cpp: (KJS::Machine::privateExecute):

LayoutTests:

2008-08-26 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Geoff and Cameron.

<rdar://problem/6174603> Hitting assertion in Register::codeBlock when
loading facebook (20516).

  • This was a result of my line numbers change. After a host function is called the stack does not get reset correctly.
  • Oddly this also appears to be a slight speedup on SunSpider.
  • fast/js/resources/stack-unwinding.js: Added.
  • fast/js/stack-unwinding-expected.txt: Added.
  • fast/js/stack-unwinding.html: Added.
3:56 PM Changeset in webkit [35939] by Chris Fleizach
  • 8 edits
    6 adds in trunk

<rdar://problem/6069462> REGRESSION: webkit is returning flash objects as AXUnknown

3:43 PM Changeset in webkit [35938] by Chris Fleizach
  • 2 edits in trunk/WebCore

<rdar://problem/5817770> can't bring up contextual menu for embedded objects

3:29 PM Changeset in webkit [35937] by Chris Fleizach
  • 3 edits
    2 adds in trunk

<rdar://problem/6176924> CrashTracer: [USER] 4 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::numColumns

2:21 PM Changeset in webkit [35936] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-08-26 Sam Weinig <​sam@webkit.org>

Reviewed by Beth Dakin.

Fix typo.

  • dom/DOMCoreException.h:
12:56 PM Changeset in webkit [35935] by weinig@apple.com
  • 5 edits
    3 adds in trunk

WebCore:

2008-08-26 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=20479
<rdar://problem/6167660>
Take image redirects into account when tainting the canvas.

Test: http/tests/security/canvas-remote-read-redirect-to-remote-image.html

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::drawImageFromRect):

LayoutTests:

2008-08-26 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=20479

  • http/tests/security/canvas-remote-read-redirect-to-remote-image-expected.txt: Added.
  • http/tests/security/canvas-remote-read-redirect-to-remote-image.html: Added.
  • http/tests/security/canvas-remote-read-svg-image-expected.txt:
  • http/tests/security/canvas-remote-read-svg-image.html: Fix incorrect log message.
  • http/tests/security/resources/redir.php: Added.
12:51 PM Changeset in webkit [35934] by weinig@apple.com
  • 7 edits in trunk/WebCore

2008-08-26 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Change canvas tainting logic to ask the image if it contains
any resources outside of its own origin. Since there is no
way to determine if SVG images contain any resources outside its
origin, we always assume it does.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::drawImageFromRect):
  • platform/graphics/BitmapImage.h: (WebCore::BitmapImage::hasSingleSecurityOrigin):
  • platform/graphics/GeneratedImage.h: (WebCore::GeneratedImage::hasSingleSecurityOrigin):
  • platform/graphics/Image.h: (WebCore::Image::hasSingleSecurityOrigin):
  • platform/graphics/cg/PDFDocumentImage.h: (WebCore::PDFDocumentImage::hasSingleSecurityOrigin):
  • svg/graphics/SVGImage.h:
10:51 AM Changeset in webkit [35933] by britto@apple.com
  • 6 edits in trunk/WebCore

2008-08-26 Maxime Britto <​britto@apple.com>

Reviewed by Adele.

<rdar://6159244> Pan-scrolling does not work on particular sites (starmagazine.com, nytimes.com)
This patch fixes the issues and modify the behavior of the panscroll by allowing it to jump to a parent layer when it reaches the end of its scrollable area.
This is matching the behavior of the mouse wheel when trying to scroll in a smaller layer of the page (div, textarea, ...) and when we reach the edge and keep scrolling then the whole page scrolls.

  • page/EventHandler.cpp: (WebCore::EventHandler::updateAutoscrollRenderer): if we switch to the parent layer to do the scroll we want to change the renderer for the panning
  • page/EventHandler.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::panScrollFromPoint): now calls the scrollByRecursively method when it has computed the xDelta and yDelta (WebCore::RenderLayer::scrollByRecursively): try to scroll the current layer by the xDelta and yDelta provided, if it can't it ask its parent layer to do so.
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled): a RenderObject must have a RenderLayer to be programatically scrolled (WebCore::RenderObject::autoscroll): No need to check for the layer anymore since we verify it's present in the upmentionned method (WebCore::RenderObject::panScroll): No need to check for the layer anymore too.
9:07 AM Changeset in webkit [35932] by Adam Roben
  • 2 edits in trunk/WebKitLibraries

Disable a truncation warning that is disabled/doesn't exist on Mac

This warning was firing when initializing floats from double literals.
I haven't yet found any other situation that would cause this warning
to arise.

Reviewed by Sam Weinig.

  • win/tools/vsprops/common.vsprops: Turn off warning C4305.
3:27 AM Changeset in webkit [35931] by jchaffraix@webkit.org
  • 6 edits
    3 adds in trunk

WebCore:

2008-08-25 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin.

Bug 20247: setAttributeNode() does not work when attribute name has a capital letter in it
​https://bugs.webkit.org/show_bug.cgi?id=20247

<rdar://problem/6118218>

Add a boolean parameter to getAttributeItem to choose between case sensitive and case insensitive
check. This keeps the behaviour for setAttribute / hasAttribute (case sensitive) and getAttribute
(case insensitive for HTML elements).

Test: fast/dom/Element/getAttribute-check-case-sensitivity.html

  • dom/Element.cpp: (WebCore::Element::getAttribute):
  • dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::getNamedItem): (WebCore::NamedAttrMap::getAttributeItem):
  • dom/NamedAttrMap.h:

LayoutTests:

2008-08-25 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin.

Test case for Bug 20247: setAttributeNode() does not work when attribute name
has a capital letter in it
​https://bugs.webkit.org/show_bug.cgi?id=20247

<rdar://problem/6118218>

Most of this test case was done by Eric Roman <​minatoar@gmail.com>, the rest by ap and was
tweaked by me.

  • fast/dom/Element/getAttribute-check-case-sensitivity-expected.txt: Added.
  • fast/dom/Element/getAttribute-check-case-sensitivity.html: Added.
  • fast/dom/Element/resources/getAttribute-check-case-sensitivity.js: Added.
12:05 AM Changeset in webkit [35930] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff and Tim.

Export new API methods.

12:00 AM Changeset in webkit [35929] by mrowe@apple.com
  • 2 edits in trunk/WebKitSite

Modernize the bug reporting guidelines and make them a little less Mac-specific.

Reviewed by Dan Bernstein.

  • quality/bugwriting.html:

Aug 25, 2008:

9:19 PM Changeset in webkit [35928] by weinig@apple.com
  • 5 edits
    3 adds in trunk

WebCore:

2008-08-25 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=20514
<rdar://problem/6174096>
Treat SVG images as dirty when drawing to a canvas.

Test: http/tests/security/canvas-remote-read-svg-image.html

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::drawImageFromRect):
  • platform/graphics/Image.h: (WebCore::Image::isSVGImage):
  • svg/graphics/SVGImage.h: (WebCore::SVGImage::isSVGImage):

LayoutTests:

2008-08-25 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=20514

  • http/tests/security/canvas-remote-read-svg-image-expected.txt: Added.
  • http/tests/security/canvas-remote-read-svg-image.html: Added.
  • http/tests/security/resources/image-wrapper.svg: Added.
6:52 PM Changeset in webkit [35927] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-08-25 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=20377
Leak in XMLHttpRequest.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
5:59 PM Changeset in webkit [35926] by sfalken@apple.com
  • 2 edits in trunk/WebKitTools

Build fix. Copy correct version of ICU.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
2:48 PM Changeset in webkit [35925] by beidson@apple.com
  • 2 edits in trunk/WebCore

2008-08-25 Brady Eidson <​beidson@apple.com>

Reviewed by Anders

Speculative fix for <rdar://problem/6173217>

Moves the "clearArchivedResources()" call to exactly where it used to be in the old version of WebArchive code.
Also, adds a null check for m_documentLoader since DocumentLoader::stopLoading() can end up clearing it, rendering
the first null check invalid.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopAllLoaders):
2:28 PM Changeset in webkit [35924] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-08-25 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/6157711> Heavy/Tree view selector is not grayed out if
there is no profile, can cause crash

  • page/inspector/ProfilesPanel.js:
2:06 PM Changeset in webkit [35923] by dino@apple.com
  • 3 edits
    4 adds in trunk

2008-08-25 Dean Jackson <​dino@apple.com>

Reviewed by Dave Hyatt

Make sure 'inherit' is handled by transition property.
​https://bugs.webkit.org/show_bug.cgi?id=20513

Test: transitions/inherit.html
Test: transitions/inherit-other-props.html

  • css/CSSStyleSelector.cpp: fix macro to check existence of list before getting size
1:56 PM Changeset in webkit [35922] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-08-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Mark.

<rdar://problem/6149787> crash @ com.apple.JavaScriptCore: WTF::callOnMainThread + 37.


Initialize threading in the call to WebCoreObjCFinalizeOnMainThread. We currently assume
(safely) that any class that needs finalization on the main thread will also need to be deallocated
on the main thread, and calling initializeThreading from WebCoreObjCFinalizeOnMainThread instead of
calling it from WebCoreObjCScheduleDeallocateOnMainThread seems safer.

  • platform/mac/WebCoreObjCExtras.c: (WebCoreObjCFinalizeOnMainThread):
1:41 PM Changeset in webkit [35921] by Antti Koivisto
  • 4 edits in trunk/WebCore

2008-08-25 Antti Koivisto <Antti Koivisto>

Reviewed by Dan Bernstein.

Rename CachedResource::referenced() to CachedResource::hasClients() to
match previous ref() -> addClient() rename.

  • loader/Cache.cpp: (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources): (WebCore::Cache::remove): (WebCore::Cache::getStatistics): (WebCore::Cache::dumpLRULists):
  • loader/CachedResource.cpp: (WebCore::CachedResource::addClient): (WebCore::CachedResource::removeClient): (WebCore::CachedResource::setDecodedSize): (WebCore::CachedResource::setEncodedSize):
  • loader/CachedResource.h: (WebCore::CachedResource::hasClients): (WebCore::CachedResource::canDelete):
12:53 PM Changeset in webkit [35920] by Adam Roben
  • 2 edits in trunk/WebKit/win

Fix an assertion when showing the Web Inspector

Reviewed by Kevin McCullough.

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::attachWindow): (WebInspectorClient::detachWindow): Recent code changes have caused these functions to get called even when the window is already attached/detached, respectively. Handle this case gracefully instead of asserting something that is no longer true.
11:33 AM Changeset in webkit [35919] by timothy@apple.com
  • 2 edits in trunk/WebCore

Add a missing Inspector localized string for "other".

​https://bugs.webkit.org/show_bug.cgi?id=20509

Reviewed by Tim Hatcher.

  • English.lproj/localizedStrings.js:
11:18 AM Changeset in webkit [35918] by kmccullough@apple.com
  • 12 edits
    2 adds in trunk

JavaScriptCore:

2008-08-25 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Geoff, Tim and Mark.

<rdar://problem/6150623> JSProfiler: It would be nice if the profiles
in the console said what file and line number they came from

  • Lay the foundation for getting line numbers and other data from the JavaScript engine. With the cleanup in kjs/ExecState this is actually a slight performance improvement.
  • JavaScriptCore.exp: Export retrieveLastCaller() for WebCore.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • VM/Machine.cpp: Now Host and JS functions set a call frame on the exec state, so this and the profiler code were pulled out of the branches. (KJS::Machine::privateExecute): (KJS::Machine::retrieveLastCaller): This get's the lineNumber, sourceID and sourceURL for the previously called function.
  • VM/Machine.h:
  • kjs/ExecState.cpp: Remove references to JSFunction since it's not used anywhere.
  • kjs/ExecState.h:

WebCore:

2008-08-22 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Geoff, Mark and Tim.

<rdar://problem/6150623> JSProfiler: It would be nice if the profiles
in the console said what file and line number they came from

  • Lay the foundation for getting line numbers and other data from the JavaScript engine.
  • ForwardingHeaders/VM: Added.
  • ForwardingHeaders/VM/Machine.h: Added.
  • page/Console.cpp: Gather the line number and file information when profileEnd has been called, but don't use it until didFinishProfiling is called. We won't need to wait once we remove the profiler "zombie" mode which this patch helps pave the foundation for. (WebCore::Console::Console): (WebCore::Console::profileEnd): (WebCore::Console::finishedProfiling):
  • page/Console.h:
  • page/InspectorController.cpp: Modify calls to addProfileMessageToConsole to satisfy the new arguments it takes. (WebCore::InspectorController::finishedProfiling): (WebCore::InspectorController::addProfile): (WebCore::InspectorController::addProfileMessageToConsole): (WebCore::InspectorController::finishedProfiling):
  • page/InspectorController.h:
9:21 AM ApplicationsGtk edited by vperetokin@gmail.com
Fixed the gtkmm entry, because it pointed to the internals of a git … (diff)
5:40 AM Changeset in webkit [35917] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

Ensure that JSGlobalContextRelease() performs garbage collection, even if there are other
contexts in the current context's group.

This is only really necessary when the last reference is released, but there is no way to
determine that, and no harm in collecting slightly more often.

  • API/JSContextRef.cpp: (JSGlobalContextRelease): Explicitly collect the heap if it is not being destroyed.
3:08 AM Changeset in webkit [35916] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

2008-08-25 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Simon.

[run-webkit-tests] Use QtLauncher to show the results of the tests
konqueror might not be installed, xdg-open might not be installed but the
QtLauncher should be present.

3:06 AM Changeset in webkit [35915] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-08-25 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Simon.

[inspector] Update the WebKit.qrc Qt resources file
Catchup with the changes in the directory.

3:06 AM Changeset in webkit [35914] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

[inspector] Emit signals from attachWindow and detachWindow in the Qt platform

Allow the user of the API to honor the attachWindow and detachWindow
requests and attach the QWebPage/QWebView wherever it is wanted. This needs
some more API in QWebPage to be properly exposed.

12:10 AM Changeset in webkit [35913] by Simon Hausmann
  • 2 edits in trunk/WebCore

008-08-25 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Simon.

Transformed the radian to degree, to get rotate()
in canvas work as expected.

[Qt] Canvas.rotate() doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=20496

Aug 24, 2008:

10:43 PM Changeset in webkit [35912] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2008-08-24 Steve Falkenburg <​sfalken@apple.com>

Add a "last chance" WM_TIMER to the Windows shared timer.


The last chance timer fires every 5 seconds to run any lost WM_TIMER based timers.
Failure to fire a timer is fatal to the cross-platform Timer code, since it won't re-schedule
timers if a timer with an earlier expiration is already pending. This results in no timers
firing from that point on.


We lose WM_TIMER messages occasionally (in the neighborhood of 1 per hour) probably due to a
buggy window message hook.


This timer will start when the first WM_TIMER is scheduled, and will
fire every 5 seconds thereafter, causing any lost timers to be fired.


Found this via one of its symptoms: leaking WebFrames. The fix prevents timers from stalling
and prevents the WebFrame leak.


Reviewed by Darin Adler, Geoff Garen.

  • platform/win/SharedTimerWin.cpp: (WebCore::): (WebCore::TimerWindowWndProc): (WebCore::setSharedTimerFireTime):
9:08 PM Changeset in webkit [35911] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-08-24 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver Hunt.

Bug 20093: JSC shell does not clear exceptions after it executes toString on an expression
<​https://bugs.webkit.org/show_bug.cgi?id=20093>

Clear exceptions after evaluating any code in the JSC shell. We do not
report exceptions that are caused by calling toString on the final
valued, but at least we avoid incorrect behaviour.

Also, print any exceptions that occurred while evaluating code at the
interactive prompt, not just while evaluating code from a file.

  • kjs/Shell.cpp: (runWithScripts): (runInteractive):
8:22 PM Changeset in webkit [35910] by mitz@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6065547> REGRESSION (r34879): "Subject" in unread emails in Yahoo mail is not shown in bold

Test: fast/css/font-property-priority.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Changed to pass the 'important' flag to the font-property-parsing functions. (WebCore::CSSParser::parseFontStyle): Added an 'important' argument and changed to use it rather than the m_important member. (WebCore::CSSParser::parseFontVariant): Ditto. (WebCore::CSSParser::parseFontWeight): Ditto.
  • css/CSSParser.h:

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/6065547> REGRESSION (r34879): "Subject" in unread emails in Yahoo mail is not shown in bold
  • fast/css/font-property-priority-expected.txt: Added.
  • fast/css/font-property-priority.html: Added.
6:27 PM Changeset in webkit [35909] by Beth Dakin
  • 4 edits in trunk/WebKit/win

2008-08-24 Beth Dakin <Beth Dakin>

Reviewed by John Sullivan.

Provide the excludeFromTextSearch SPI on Windows as well.

  • Interfaces/IWebFrame.idl:
  • WebFrame.cpp: (WebFrame::setExcludeFromTextSearch):
  • WebFrame.h:
3:28 PM Changeset in webkit [35908] by timothy@apple.com
  • 2 edits
    1 add in trunk/WebCore

Fixes a bug where the Inspector's UI would not animate or
fully function because JavaScript timeouts, intervals and
CSS animation timers where not firing while paused at a
a breakpoint in the inspected page.

​https://bugs.webkit.org/show_bug.cgi?id=20042

Reviewed by Darin Adler.

Test: manual-tests/inspector/forzen-ui-while-paused.html

  • page/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::pauseIfNeeded): Add a call to TimerBase::fireTimersInNestedEventLoop before spinning the EventLoop.
3:25 PM Changeset in webkit [35907] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.2

New tag.

2:30 PM Changeset in webkit [35906] by cwzwarich@webkit.org
  • 2 edits in trunk

2008-08-24 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Remove an unnecessary RefPtr to a RegisterID.

  • kjs/nodes.cpp: (KJS::DeleteBracketNode::emitCode):
11:07 AM Changeset in webkit [35905] by rwlbuis@webkit.org
  • 4 edits
    4 adds in trunk

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=20324
A change in SVG Glyph wont show up

Invalidate the glyph cache when the d attribute is set.

Test: svg/custom/glyph-setting-d-attribute.svg

5:59 AM Changeset in webkit [35904] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

2008-08-24 Jon Honeycutt <​jhoneycutt@apple.com>

Cannot get the focused accessible object from the root object.

AccessibleBase::get_AccFocus() checks whether the focused object is a
child of the current object, but
​http://msdn.microsoft.com/en-us/library/ms696150(VS.85).aspx states that
the result is the object itself, if it has focus, or a child object of
the active window, not a child of the object.

Reviewed by Sam Weinig.

  • AccessibleBase.cpp: (AccessibleBase::get_accFocus): Don't check whether the focused object is our child.
5:56 AM Changeset in webkit [35903] by jhoneycutt@apple.com
  • 7 edits
    2 adds in trunk/WebKitTools

2008-08-24 Jon Honeycutt <​jhoneycutt@apple.com>

Initial support for accessibility layout tests on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=20497

Reviewed by Sam Weinig.

  • DumpRenderTree/AccessibilityController.h: Fix typos.
  • DumpRenderTree/AccessibilityUIElement.cpp: Change #import to #include.
  • DumpRenderTree/AccessibilityUIElement.h: Define _WINSOCKAPI_ to prevent oleacc.h, which includes windows.h, from including winsock.h. Fixed typos.
  • DumpRenderTree/win/AccessibilityControllerWin.cpp: Added. (AccessibilityController::AccessibilityController): (AccessibilityController::~AccessibilityController): (AccessibilityController::focusedElement): Get the root element, and request its focused object. (AccessibilityController::rootElement): Query Windows for the accessible client object for the WebView's window.
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added. (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::~AccessibilityUIElement): (AccessibilityUIElement::getLinkedUIElements): Not implemented. (AccessibilityUIElement::getChildren): Get the child count, and append each child. (AccessibilityUIElement::getChildAtIndex): Get the child at the given index offset by 1. In MSAA, child 0 is the object itself. (AccessibilityUIElement::allAttributes): Not implemented. (AccessibilityUIElement::attributesOfLinkedUIElements): Same. (AccessibilityUIElement::attributesOfChildren): Same. (AccessibilityUIElement::parameterizedAttributeNames): Same. (self): Return a VARIANT representing the "self" object. This is used when calling methods that require a child variant. (AccessibilityUIElement::role): Get the MSAA role, a long value, and convert it into a string with GetRoleText(). (AccessibilityUIElement::title): Get the element's title, and convert it to a JS String. (AccessibilityUIElement::description): Same, for description. (AccessibilityUIElement::width): (AccessibilityUIElement::height): (AccessibilityUIElement::intValue): Get the object's value as a string, and convert the string to a double. (AccessibilityUIElement::minValue): Not implemented. (AccessibilityUIElement::maxValue): Same. (AccessibilityUIElement::insertionPointLineNumber): Same. (AccessibilityUIElement::attributesOfColumnHeaders): Same. (AccessibilityUIElement::attributesOfRowHeaders): Same. (AccessibilityUIElement::attributesOfColumns): Same. (AccessibilityUIElement::attributesOfRows): Same. (AccessibilityUIElement::attributesOfVisibleCells): Same. (AccessibilityUIElement::attributesOfHeader): Same. (AccessibilityUIElement::indexInTable): Same. (AccessibilityUIElement::rowIndexRange): Same. (AccessibilityUIElement::columnIndexRange): Same. (AccessibilityUIElement::lineForIndex): Same. (AccessibilityUIElement::boundsForRange): Same. (AccessibilityUIElement::cellForColumnAndRow): Same.
  • DumpRenderTree/win/DumpRenderTree.vcproj: Add accessibility files to project. Link to oleacc.lib, the MSAA library.
  • DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::FrameLoadDelegate): Initialize the accessibility controller. (FrameLoadDelegate::didClearWindowObject): Create a new window object for the accessibility controller.
  • DumpRenderTree/win/FrameLoadDelegate.h:
2:18 AM Changeset in webkit [35902] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • rendering/RenderText.cpp: (WebCore::RenderText::trimmedPrefWidths): Moved the assignment to beginWS and endWS before the early return to ensure that they are initialized in that case.
1:35 AM Changeset in webkit [35901] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Use the correct version number for when JSGlobalContextCreate was introduced.

Reviewed by Oliver Hunt.

Note: See TracTimeline for information about the timeline view.