Timeline



Sep 13, 2008:

11:23 PM ProposedWebInspectorRearchitecting edited by timothy@apple.com
(diff)
11:21 PM ProposedWebInspectorRearchitecting edited by timothy@apple.com
Further define the message types and callback functions. (diff)
10:53 PM ProposedWebInspectorRearchitecting edited by timothy@apple.com
Defines some messages for Console. (diff)
10:29 PM Changeset in webkit [36400] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/PlatformScrollBar.h

Fix Qt bustage.

10:05 PM Changeset in webkit [36399] by hyatt@apple.com
  • 1 edit in trunk/WebKit/win/WebScrollBar.cpp

Fix Windows bustage.

9:53 PM Changeset in webkit [36398] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/mac/PlatformScrollBar.h

Fix Mac build bustage.

9:25 PM ProposedWebInspectorRearchitecting edited by timothy@apple.com
Define some of the Console API. (diff)
6:57 PM Changeset in webkit [36397] by jmalonzo@webkit.org
  • 3 edits in trunk/WebCore

2008-09-13 Jan Michael Alonzo <​jmalonzo@webkit.org>

Gtk build fix, not reviewed.

  • platform/gtk/PlatformScrollBarGtk.cpp: (PlatformScrollbar::PlatformScrollbar):
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::updateScrollbars):
6:26 PM Changeset in webkit [36396] by hyatt@apple.com
  • 17 edits in trunk/WebCore

Eliminate Scrollbar's setRect method. Clients can now just use the Widget base class method, setFrameGeometry instead.

6:06 PM Changeset in webkit [36395] by hyatt@apple.com
  • 11 edits in trunk/WebCore

Remove setEnabled from all Scrollbar subclasses that were just using their Widget base class methods.

5:58 PM Changeset in webkit [36394] by hyatt@apple.com
  • 10 edits in trunk/WebCore

Remove width()/height() from Scrollbar and subclasses that just need to use the Widget method.

5:50 PM Changeset in webkit [36393] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/gtk/PlatformScrollBar.h

Remove now unused methods from GTK scrollbars.

5:49 PM Changeset in webkit [36392] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/gtk/PlatformScrollBarGtk.cpp

Remove now unused methods from GTK scrollbars.

5:32 PM Changeset in webkit [36391] by hyatt@apple.com
  • 6 edits in trunk/WebCore

Move stopTimerIfNeeded out of PlatformScrollbar destructors and into Scrollbar's destructor.

5:22 PM Changeset in webkit [36390] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/ScrollBar.h

Fix Qt build bustage.

4:57 PM Changeset in webkit [36389] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2008-09-13 David Hyatt <​hyatt@apple.com>

Move maximum() from Qt's PlatformScrollbar to be a cross-platform
function on Scrollbar. Fixes Qt build bustage.

Reviewed by Sam Weinig

  • platform/ScrollBar.h: (WebCore::Scrollbar::orientation): (WebCore::Scrollbar::value): (WebCore::Scrollbar::maximum):
  • platform/qt/PlatformScrollBar.h:
4:47 PM Changeset in webkit [36388] by hyatt@apple.com
  • 2 edits in trunk/WebKit/qt/Api

Fix Qt bustage.

4:34 PM Changeset in webkit [36387] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/wx/TemporaryLinkStubs.cpp

Fix wx bustage.

4:32 PM Changeset in webkit [36386] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/ScrollbarThemeQt.cpp

Fix Qt bustage.

4:21 PM Changeset in webkit [36385] by hyatt@apple.com
  • 3 edits in trunk/WebCore/platform

Fix Qt, Gtk, and Mac build bustage.

4:10 PM Changeset in webkit [36384] by hyatt@apple.com
  • 1 edit in trunk/WebCore/WebCore.pro

Fix Qt bustage.

4:08 PM Changeset in webkit [36383] by hyatt@apple.com
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fix Mac bustage.

4:06 PM Changeset in webkit [36382] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Sam Weinig.

  • use the LastResort font for missing glyphs instead of showing the primary font's missing glyph

Test: platform/mac/fast/text/last-resort-font.html

  • platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): Changed to return the last resort font if a substitute font cannot be found. (WebCore::FontCache::getLastResortFallbackFont): Removed an outdated comment (the user's preferred standard font is included in the search thanks to code in FontCache::getFontData()) and changed to return the LastResort font.

LayoutTests:

Reviewed by Sam Weinig.

  • test that the LastResort font is used for missing glyphs rather than the primary font's missing glyph
  • platform/mac/fast/text/last-resort-font-expected.checksum: Added.
  • platform/mac/fast/text/last-resort-font-expected.png: Added.
  • platform/mac/fast/text/last-resort-font-expected.txt: Added.
  • platform/mac/fast/text/last-resort-font.html: Added.
3:59 PM Changeset in webkit [36381] by hyatt@apple.com
  • 2 edits in trunk/WebKit/win

Add ScrollbarTheme to control scrollbar metrics (and eventually hit testing and rendering.

3:59 PM Changeset in webkit [36380] by hyatt@apple.com
  • 16 edits
    11 adds in trunk/WebCore

Add ScrollbarTheme to control scrollbar metrics (and eventually hit testing and rendering.

2:30 PM Changeset in webkit [36379] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-09-13 Adrien Nader <​camaradetux@gmail.com>

Gtk build fix, not reviewed.

  • webkit/webkitwebview.cpp:
2:05 PM Changeset in webkit [36378] by Chris Fleizach
  • 20 edits in trunk

<rdar://problem/5060439> Web elements should have an AXTopLevelUIElement

expose AXTopLevelUIElement as an attribute

1:51 PM Changeset in webkit [36377] by hyatt@apple.com
  • 2 edits in trunk/WebKit/qt/Api

Fix Qt build bustage.

1:37 PM Changeset in webkit [36376] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/wx/ScrollViewWx.cpp

Fix wx build bustage.

1:33 PM Changeset in webkit [36375] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/PlatformScrollBarQt.cpp

Fix Qt build bustage.

1:27 PM Changeset in webkit [36374] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Timothy Hatcher.

  • fix <rdar://problem/6171280> REGRESSION (r35667): Assertion failure in WebCore::FrameView::scheduleRelayout() when releasing a page with counters from the b/f cache

No regression test because the back/forward cache is disabled in DumpRenderTree

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::invalidateCounters): Bail out if the document is being destroyed.
12:14 PM Changeset in webkit [36373] by hyatt@apple.com
  • 3 edits in trunk/WebCore

Fix Mac build bustage.

11:52 AM Changeset in webkit [36372] by hyatt@apple.com
  • 2 edits in trunk/WebCore/platform

Fix Qt build bustage.

11:48 AM Changeset in webkit [36371] by kevino@webkit.org
  • 3 edits in trunk/WebCore

wx build fixes for new methods recently introduced.

11:41 AM Changeset in webkit [36370] by hyatt@apple.com
  • 2 edits in trunk/WebKit/win

more scrollbar refactoring.

11:39 AM Changeset in webkit [36369] by hyatt@apple.com
  • 29 edits
    1 add in trunk/WebCore

More scrollbar refactoring.

Sep 12, 2008:

9:57 PM Changeset in webkit [36368] by cwzwarich@webkit.org
  • 9 edits in trunk/JavaScriptCore

2008-09-12 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej Stachowiak.

Bug 20819: JSValue::isObject() is slow
<​https://bugs.webkit.org/show_bug.cgi?id=20819>

Optimize JSCell::isObject() and JSCell::isString() by making them
non-virtual calls that rely on the StructureID type information.

This is a 0.7% speedup on SunSpider and a 1.0% speedup on the V8
benchmark suite.

  • JavaScriptCore.exp:
  • kjs/JSCell.cpp:
  • kjs/JSCell.h: (JSC::JSCell::isObject): (JSC::JSCell::isString):
  • kjs/JSObject.cpp:
  • kjs/JSObject.h:
  • kjs/JSString.cpp:
  • kjs/JSString.h: (JSC::JSString::JSString):
  • kjs/StructureID.h: (JSC::StructureID::type):
7:59 PM Changeset in webkit [36367] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Fix Mac build.

  • css/CSSStyleSelector.cpp: (WebCore::getTransformOperationType):
6:10 PM Changeset in webkit [36366] by hyatt@apple.com
  • 1 edit in trunk/WebCore/css/CSSStyleSelector.cpp

Fix Windows build bustage.

5:47 PM Changeset in webkit [36365] by dino@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Cleaning up LayoutTests/ChangeLog.

5:45 PM Changeset in webkit [36364] by dino@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Cleaning up WebCore/ChangeLog

5:41 PM Changeset in webkit [36363] by mrowe@apple.com
  • 15 edits
    5 deletes in trunk

Roll out r36360 as it broke all non-Mac builds.

5:33 PM Changeset in webkit [36362] by dino@apple.com
  • 13 edits in trunk

2008-09-12 Chris Marrin <​cmarrin@apple.com>

Reviewed by Dave Hyatt.

Make transform animation behavior match spec
​https://bugs.webkit.org/show_bug.cgi?id=20770

Tests: transitions/transform-op-list-match.html

transitions/transform-op-list-no-match.html

  • css/CSSStyleSelector.cpp:
  • css/CSSStyleSelector.h:
  • page/animation/AnimationBase.cpp:
  • page/animation/AnimationBase.h:
  • page/animation/ImplicitAnimation.cpp:
  • page/animation/ImplicitAnimation.h:
  • page/animation/KeyframeAnimation.cpp:
  • page/animation/KeyframeAnimation.h:
  • rendering/RenderLayer.cpp:
  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:
4:30 PM Changeset in webkit [36361] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

2008-09-12 John Sullivan <​sullivan@apple.com>

Fixed <rdar://problem/6110941> Clicking the print button in PDF content does nothing

Reviewed by Darin Adler

  • WebView/WebPDFView.mm: (-[WebPDFView PDFViewPerformPrint:]): Implemented PDFKit delegate method that's called after a Print action in the PDF content
4:27 PM Changeset in webkit [36360] by Chris Fleizach
  • 15 edits
    5 adds in trunk

<rdar://problem/4003789> Expose lists as AXList
<rdar://problem/5707399> VO: Definition lists not announced in Safari

Exposes <ol>, <ul> and <dl> lists as AXLists through accessibility

3:43 PM Changeset in webkit [36359] by timothy@apple.com
  • 4 edits
    1 add in trunk/WebCore

Properly escape contents of links added to the inspector.
For now, just build the link with the DOM and get the
outerHTML. Eventually, we probably just want to do
this entirely with the DOM.

Reviewed by Timothy Hatcher.

​https://bugs.webkit.org/show_bug.cgi?id=20684

  • manual-tests/inspector/escape-links.html: Added.
  • page/inspector/StylesSidebarPane.js:
  • page/inspector/inspector.js:
  • page/inspector/utilities.js:
3:14 PM Changeset in webkit [36358] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-09-12 Adele Peterson <​adele@apple.com>

Reviewed by John Sullivan and Kevin McCullough.

Fix for <rdar://problem/6216951> REGRESSION (r36000?): Crash due to infinite recursion into EventHandler::hitTestResultAtPoint() with disconnected frames

  • page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint): Hit testing again on the main frame will only work if we aren't already on the main frame. If we are already on the main frame, that will cause infinite recursion. This change checks that we're not already on the main frame before hit testing again.
3:08 PM Changeset in webkit [36357] by kmccullough@apple.com
  • 5 edits in trunk

WebCore:

2008-09-12 Kevin McCullough <​kmccullough@apple.com>

RS by Tim .

Re-introducing the code since it was not the cause of the crash.
See r36343.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled):
  • rendering/RenderObject.h:

LayoutTests:

2008-09-12 Kevin McCullough <​kmccullough@apple.com>

RS by Tim.

Re-introducing the code since it was not the cause of the crash.
See r36343.

  • fast/events/autoscroll-with-non-scrollable-parent.html:
2:54 PM Changeset in webkit [36356] by dino@apple.com
  • 7 edits
    2 adds in trunk

2008-09-12 Chris Marrin <​cmarrin@apple.com>

Reviewed by Dave Hyatt.

When changing one animation in a list, don't reset other animations
​https://bugs.webkit.org/show_bug.cgi?id=20675

Test: animations/change-one-anim.html

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::getNumProperties):
  • page/animation/AnimationBase.h:
  • page/animation/AnimationController.cpp:
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateKeyframeAnimations):
  • page/animation/CompositeAnimation.h:
  • page/animation/ImplicitAnimation.cpp:
  • page/animation/KeyframeAnimation.cpp:
  • page/animation/KeyframeAnimation.h: (WebCore::KeyframeAnimation::setIndex):
2:43 PM Changeset in webkit [36355] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/gtk/ScrollViewGtk.cpp

Fix Gtk build bustage.

2:42 PM Changeset in webkit [36354] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/ScrollViewQt.cpp

Fix Qtbuild bustage.

11:47 AM ProposedWebInspectorRearchitecting edited by ojan@chromium.org
(diff)
11:40 AM Changeset in webkit [36353] by beidson@apple.com
  • 2 edits in trunk/WebCore

2008-09-12 Brady Eidson <​beidson@apple.com>

Reviewed by Mitz Pettel

Fix the ASSERT and failure in webarchive/archive-empty-frame-source.html

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::mainResource): Further restoration of original WebArchive behavior. Subresources can never be created from nil data, but there is always a MainResource, whether or not there's any data. So in the case where the main resource has no data, fake it for the sake of creating the ArchiveResource.
11:39 AM ProposedWebInspectorRearchitecting edited by ojan@chromium.org
(diff)
11:37 AM Changeset in webkit [36352] by hyatt@apple.com
  • 10 edits in trunk/WebCore

Make Scrollbar derive from Widget. Remove isWidget guards on Scrollbars.

11:22 AM Changeset in webkit [36351] by mitz@apple.com
  • 9 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • page/animation/AnimationController.cpp:
  • page/animation/AnimationController.h:
  • page/animation/CompositeAnimation.cpp:
  • page/animation/CompositeAnimation.h:
  • page/animation/ImplicitAnimation.cpp:
  • page/animation/ImplicitAnimation.h:
  • page/animation/KeyframeAnimation.cpp:
  • page/animation/KeyframeAnimation.h:
10:58 AM Changeset in webkit [36350] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by John Sullivan.

  • fix a crash in -visibleRect when it is called during WebFrameView deallocation
  • WebView/WebFrameView.mm: (-[WebFrameView visibleRect]): Added an early return if _private is 0.

Sep 11, 2008:

9:44 PM Changeset in webkit [36349] by timothy@apple.com
  • 5 edits in trunk/WebCore

Add a renderedImage method to DOMNode to get an image
of the rendering for the node and it's descendants.

<rdar://problem/5849349> Would like API to create
an image for a DOM node

Reviewed by Oliver Hunt.

  • bindings/objc/DOM.mm: (-[DOMNode renderedImage]): Call Frame::nodeImage.
  • bindings/objc/DOMPrivate.h:
  • page/Frame.h:
  • page/mac/FrameMac.mm: (WebCore::Frame::nodeImage):
6:25 PM Changeset in webkit [36348] by dino@apple.com
  • 3 edits in trunk/LayoutTests

2008-09-11 Dean Jackson <​dino@apple.com>

Unfortunately the fix for
​https://bugs.webkit.org/show_bug.cgi?id=20680
didn't update the relevant test

  • css3/keyframes-rule-expected.txt:
  • css3/keyframes-rule.html:
5:36 PM Changeset in webkit [36347] by dino@apple.com
  • 11 edits
    2 adds in trunk

2008-09-08 Chris Marrin <​cmarrin@apple.com>

Reviewed by Dave Hyatt

Need to support comma separated list of key times in keyframes selectors
​https://bugs.webkit.org/show_bug.cgi?id=20680

Test: animations/keyframes-comma-separated.html

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::createKeyframeRule):
  • css/CSSParser.h:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::addKeyframeStyle):
  • css/WebKitCSSKeyframeRule.cpp: (WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule): (WebCore::WebKitCSSKeyframeRule::cssText): (WebCore::WebKitCSSKeyframeRule::parseKeyString):
  • css/WebKitCSSKeyframeRule.h: (WebCore::WebKitCSSKeyframeRule::keyText): (WebCore::WebKitCSSKeyframeRule::setKeyText): (WebCore::WebKitCSSKeyframeRule::getKeys):
  • css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::append): (WebCore::WebKitCSSKeyframesRule::insertRule): (WebCore::WebKitCSSKeyframesRule::deleteRule): (WebCore::WebKitCSSKeyframesRule::findRule): (WebCore::WebKitCSSKeyframesRule::findRuleIndex):
  • css/WebKitCSSKeyframesRule.h:
  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::blendProperties):
5:24 PM Changeset in webkit [36346] by mrowe@apple.com
  • 4 edits in tags/Safari-6528.3.1

Versioning.

5:24 PM Changeset in webkit [36345] by mrowe@apple.com
  • 2 edits in tags/Safari-6528.3.1/JavaScriptCore

Merge r36292.

5:15 PM Changeset in webkit [36344] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.3.1

New tag.

3:57 PM Changeset in webkit [36343] by kmccullough@apple.com
  • 5 edits in trunk

WebCore:

2008-09-11 Kevin McCullough <​kmccullough@apple.com>

RS by Tim.

Reverting because this caused a crash.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled): (WebCore::RenderObject::hasScrollableView):
  • rendering/RenderObject.h:

LayoutTests:

2008-09-11 Kevin McCullough <​kmccullough@apple.com>

RS = Tim.

Reverted because this caused a crash.

  • fast/events/autoscroll-with-non-scrollable-parent.html:
3:32 PM Changeset in webkit [36342] by Stephanie Lewis
  • 2 edits in trunk/JavaScriptCore

2008-09-11 Stephanie Lewis <Stephanie Lewis>

Reviewed by Oliver Hunt.

Turn off PGO Optimization on CTI.cpp -> <rdar://problem/6207709>. Fixes
crash on CNN and on Dromaeo.
Fix Missing close tag in vcproj.

2:59 PM Changeset in webkit [36341] by dino@apple.com
  • 3 edits
    2 adds in trunk

2008-09-11 Dean Jackson <​dino@apple.com>

Reviewed by Dan Bernstein.

Fix assertion on transition property "none"
​https://bugs.webkit.org/show_bug.cgi?id=20751

Test: transitions/transition-end-event-set-none.html

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions):
2:54 PM Changeset in webkit [36340] by dsmith@webkit.org
  • 1 edit
    1 delete in trunk/WebCore

2008-09-11 David Smith <​catfish.man@gmail.com>

Rubber-stamped by mitzpettel.

Remove an accidentally added extra file.

  • WebCore: Removed.
2:41 PM Changeset in webkit [36339] by dsmith@webkit.org
  • 13 edits
    4 adds in trunk/WebCore

2008-09-11 David Smith <​catfish.man@gmail.com>

Reviewed by Darin

​https://bugs.webkit.org/show_bug.cgi?id=20180


This speeds up :nth-child matching as tested by querySelectorAll by around 10% by inlining the common case of Node::renderStyle(). Many thanks to mitzpettel and othermaciej for suggestions and help.

  • WebCore.xcodeproj/project.pbxproj: Add NodeRenderStyle.h
  • css/CSSStyleSelector.cpp: include NodeRenderStyle.h
  • dom/Element.cpp: include NodeRenderStyle.h
  • dom/Node.cpp: Remove the definition of renderStyle() (WebCore::Node::nonRendererRenderStyle):
  • dom/Node.h: Make renderStyle() nonvirtual and add nonRendererRenderStyle()
  • dom/NodeRenderStyle.h: Added. (WebCore::Node::renderStyle): Inline the common case of this, call nonRendererRenderStyle for the part that needed to be virtual
  • html/HTMLOptGroupElement.cpp: include NodeRenderStyle.h
  • html/HTMLOptGroupElement.h: (WebCore::HTMLOptGroupElement::nonRendererRenderStyle): override to return m_style
  • html/HTMLOptionElement.cpp: include NodeRenderStyle.h
  • html/HTMLOptionElement.h: (WebCore::HTMLOptionElement::nonRendererRenderStyle): override to return m_style
  • rendering/RenderListBox.cpp: include NodeRenderStyle.h
  • rendering/RenderMenuList.cpp: include NodeRenderStyle.h
  • svg/SVGUseElement.cpp: include NodeRenderStyle.h
2:15 PM Changeset in webkit [36338] by cwzwarich@webkit.org
  • 1 edit
    2 adds in trunk/JavaScriptCore

2008-09-11 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Not reviewed.

Correct an SVN problem with the last commit and actually add the new
files.

  • wrec/CharacterClassConstructor.cpp: Added. (JSC::): (JSC::getCharacterClassNewline): (JSC::getCharacterClassDigits): (JSC::getCharacterClassSpaces): (JSC::getCharacterClassWordchar): (JSC::getCharacterClassNondigits): (JSC::getCharacterClassNonspaces): (JSC::getCharacterClassNonwordchar): (JSC::CharacterClassConstructor::addSorted): (JSC::CharacterClassConstructor::addSortedRange): (JSC::CharacterClassConstructor::put): (JSC::CharacterClassConstructor::flush): (JSC::CharacterClassConstructor::append):
  • wrec/CharacterClassConstructor.h: Added. (JSC::CharacterClassConstructor::CharacterClassConstructor): (JSC::CharacterClassConstructor::isUpsideDown): (JSC::CharacterClassConstructor::charClass):
2:13 PM Changeset in webkit [36337] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-09-11 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej Stachowiak.

Bug 20788: Split CharacterClassConstructor into its own file
<​https://bugs.webkit.org/show_bug.cgi?id=20788>

Split CharacterClassConstructor into its own file and clean up some
style issues.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wrec/CharacterClassConstructor.cpp: Added. (JSC::): (JSC::getCharacterClassNewline): (JSC::getCharacterClassDigits): (JSC::getCharacterClassSpaces): (JSC::getCharacterClassWordchar): (JSC::getCharacterClassNondigits): (JSC::getCharacterClassNonspaces): (JSC::getCharacterClassNonwordchar): (JSC::CharacterClassConstructor::addSorted): (JSC::CharacterClassConstructor::addSortedRange): (JSC::CharacterClassConstructor::put): (JSC::CharacterClassConstructor::flush): (JSC::CharacterClassConstructor::append):
  • wrec/CharacterClassConstructor.h: Added. (JSC::CharacterClassConstructor::CharacterClassConstructor): (JSC::CharacterClassConstructor::isUpsideDown): (JSC::CharacterClassConstructor::charClass):
  • wrec/WREC.cpp: (JSC::WRECParser::parseCharacterClass):
1:29 PM Changeset in webkit [36336] by mitz@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by John Sullivan.

  • eliminate excessive repainting when a clipped iframe is moved (noticed in <rdar://problem/6204032>)
  • WebView/WebFrame.mm: (-[WebFrame _getVisibleRect:]): Added. If the frame is in a RenderPart and has layout, gets the visible rect of the RenderPart and returns YES. Returns NO otherwise.
  • WebView/WebFrameInternal.h:
  • WebView/WebFrameView.mm: (-[WebFrameView visibleRect]): Added. Overrides this NSView method to take clipping in the render tree into account.
10:45 AM ProposedWebInspectorRearchitecting edited by ojan@chromium.org
(diff)
10:39 AM Changeset in webkit [36335] by kmccullough@apple.com
  • 5 edits in trunk

WebCore:

2008-09-11 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Adele and Tim.

<rdar://problem/6100597> REGRESSION: clicking on search results in Web
Inspector does not scroll to the line of the results (20167)

  • This was put in by Max to fix auto scrolling but is not correct for the whole web: rdar://problem/6213098
  • rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled):
  • rendering/RenderObject.h:

LayoutTests:

2008-09-11 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Adele and Tim.

<rdar://problem/6100597> REGRESSION: clicking on search results in Web
Inspector does not scroll to the line of the results (20167)

  • This was put in by Max to fix some auto scroll behavior but is not correct for the whole web: rdar://problem/6213098
  • fast/events/autoscroll-with-non-scrollable-parent.html:
9:24 AM Changeset in webkit [36334] by Chris Fleizach
  • 3 edits
    2 adds in trunk

<rdar://problem/6210511> AX: if a frame has a title, that should be reported as the AXWebArea's title

3:50 AM Changeset in webkit [36333] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-09-11 Tor Arne Vestbø <​tavestbo@trolltech.com>

Rubber-stamped by Simon.

Prevent leaking pages and frames in QWebKit autotest

2:53 AM Changeset in webkit [36332] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-09-11 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon

Fix QtWebKit autotest

1:03 AM Changeset in webkit [36331] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-09-11 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Simon.

Fixed stroke() and strokeRect() to support gradients
and patterns on Qt.

[Qt] Canvas stroke don't work for gradients and patterns
​https://bugs.webkit.org/show_bug.cgi?id=20749

12:37 AM Changeset in webkit [36330] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-09-11 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Simon.

​https://bugs.webkit.org/show_bug.cgi?id=20729

Fixed canvas gradients for Qt

12:34 AM Changeset in webkit [36329] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-09-11 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Simon.

​https://bugs.webkit.org/show_bug.cgi?id=20568

Add support for patterns to Qt.

12:09 AM Changeset in webkit [36328] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-09-10 Simon Hausmann <Simon Hausmann>

Not reviewed but trivial one-liner for yet unused macro.

Changed PLATFORM(WINCE) to PLATFORM(WIN_CE) as requested by Mark.

(part of ​https://bugs.webkit.org/show_bug.cgi?id=20746)

Sep 10, 2008:

10:28 PM Changeset in webkit [36327] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-09-10 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Rubber-stamped by Oliver Hunt.

Fix a typo by renaming the overloaded orl_rr that takes an immediate to
orl_i32r.

  • VM/CTI.cpp: (JSC::CTI::emitFastArithPotentiallyReTagImmediate):
  • masm/X86Assembler.h: (JSC::X86Assembler::orl_i32r):
  • wrec/WREC.cpp: (JSC::WRECGenerator::generatePatternCharacter): (JSC::WRECGenerator::generateCharacterClassInverted):
9:01 PM Changeset in webkit [36326] by weinig@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2008-09-10 Sam Weinig <​sam@webkit.org>

Rubber-stamped by David Hyatt.

Add additional test by Feng Qian.

  • fast/dom/StyleSheet/ownerNode-lifetime-2-expected.txt: Added.
  • fast/dom/StyleSheet/ownerNode-lifetime-2.html: Added.
7:42 PM Changeset in webkit [36325] by weinig@apple.com
  • 9 edits in trunk/JavaScriptCore

2008-09-10 Sam Weinig <​sam@webkit.org>

Reviewed by Geoff Garen.

Add inline property storage for JSObject.

1.2% progression on Sunspider. .5% progression on the v8 test suite.

  • JavaScriptCore.exp:
  • VM/CTI.cpp: (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain):
  • kjs/JSObject.cpp: (JSC::JSObject::mark): There is no reason to check storageSize now that we start from 0. (JSC::JSObject::allocatePropertyStorage): Allocates/reallocates heap storage.
  • kjs/JSObject.h: (JSC::JSObject::offsetForLocation): m_propertyStorage is not an OwnArrayPtr now so there is no reason to .get() (JSC::JSObject::usingInlineStorage): (JSC::JSObject::JSObject): Start with m_propertyStorage pointing to the inline storage. (JSC::JSObject::~JSObject): Free the heap storage if not using the inline storage. (JSC::JSObject::putDirect): Switch to the heap storage only when we know we know that we are about to add a property that will overflow the inline storage.
  • kjs/PropertyMap.cpp: (JSC::PropertyMap::createTable): Don't allocate the propertyStorage, that is now handled by JSObject. (JSC::PropertyMap::rehash): PropertyStorage is not a OwnArrayPtr anymore.
  • kjs/PropertyMap.h: (JSC::PropertyMap::storageSize): Rename from markingCount.
  • kjs/StructureID.cpp: (JSC::StructureID::addPropertyTransition): Don't resize the property storage if we are using inline storage.
  • kjs/StructureID.h:
7:10 PM Changeset in webkit [36324] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Inline immediate number version of op_mul.

Reviewed by Geoff Garen

Renamed mull_rr to imull_rr as that's what it's
actually doing, and added imull_i32r for the constant
case immediate multiply.

1.1% improvement to SunSpider.

1:30 PM Changeset in webkit [36323] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-09-10 Alp Toker <​alp@nuanti.com>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=17267
[GTK] Primary selection/clipboard support

Implement primary selection support (copying only, no paste yet).

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::clipboard_get_contents_cb): (WebKit::clipboard_clear_contents_cb): (WebKit::EditorClient::respondToChangedSelection):
1:22 PM ProposedWebInspectorRearchitecting edited by ojan@chromium.org
(diff)
12:48 PM ProposedWebInspectorRearchitecting created by ojan@chromium.org
12:30 PM Web Inspector edited by ojan@chromium.org
(diff)
11:21 AM Changeset in webkit [36322] by mitz@apple.com
  • 8 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • clean up AnimationBase
  • page/animation/AnimationBase.cpp:
  • page/animation/AnimationBase.h:
  • page/animation/CompositeAnimation.cpp:
  • page/animation/ImplicitAnimation.cpp:
  • page/animation/ImplicitAnimation.h:
  • page/animation/KeyframeAnimation.cpp:
  • page/animation/KeyframeAnimation.h:
11:19 AM Changeset in webkit [36321] by mitz@apple.com
  • 17 edits in trunk/WebCore

Revert erroneous checkin

11:17 AM Changeset in webkit [36320] by mitz@apple.com
  • 15 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • clean up AnimationBase
  • page/animation/AnimationBase.cpp:
  • page/animation/AnimationBase.h:
  • page/animation/CompositeAnimation.cpp:
  • page/animation/ImplicitAnimation.cpp:
  • page/animation/ImplicitAnimation.h:
  • page/animation/KeyframeAnimation.cpp:
  • page/animation/KeyframeAnimation.h:
9:42 AM Changeset in webkit [36319] by ap@webkit.org
  • 4 edits
    15 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=20741
REGRESSION: ISO-8859-8-I encoding is registered incorrectly

Turns out that there were no real behavior changes for 8859-8, as it was only a debug-only
check to ignore this specific registration that was failing. Yet, I decided to add a bunch of
tests for ISO-8859-8 encoding aliases, as we handle them in a quite complicated manner.

I also found and fixed a potential crasher for non-Mac ports.

Tests: fast/encoding/hebrew/8859-8-e.html

fast/encoding/hebrew/8859-8-i.html
fast/encoding/hebrew/8859-8.html
fast/encoding/hebrew/csISO88598I.html
fast/encoding/hebrew/hebrew.html
fast/encoding/hebrew/iso-ir-138.html
fast/encoding/hebrew/logical.html

  • platform/text/TextEncodingRegistry.cpp: (WebCore::checkExistingName): Check for iso-8859-8 (case-insensitively, because different versions of ICU report this MIME name in different case).
  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Updated some comments. (WebCore::TextCodecICU::registerExtendedCodecs): Try both MIME and IANA names here, too. There are four names in ICU that only have MIME names (x-mac-* ones), so we could end up with an encoding map entry, but no codec for these. This was not an issue on the Mac, as we also support these via TEC (which we should stop doing), but on Windows, this would likely crash.
3:15 AM Changeset in webkit [36318] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-09-10 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Not reviewed.

Mac build fix.

2:23 AM Changeset in webkit [36317] by oliver@apple.com
  • 9 edits in trunk/JavaScriptCore

Add optimised access to known properties on the global object.

Reviewed by Maciej Stachowiak

Improve cross scope access to the global object by emitting
code to access it directly rather than by walking the scope chain.

This is a 0.8% win in SunSpider and a 1.7% win in the v8 benchmarks.

1:42 AM Changeset in webkit [36316] by mjs@apple.com
  • 17 edits in trunk/JavaScriptCore

2008-09-10 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver.


  • enable polymorphic inline caching of properties of primitives


1.012x speedup on SunSpider.

We create special structure IDs for JSString and
JSNumberCell. Unlike normal structure IDs, these cannot hold the
true prototype. Due to JS autoboxing semantics, the prototype used
when looking up string or number properties depends on the lexical
global object of the call site, not the creation site. Thus we
enable StructureIDs to handle this quirk for primitives.


Everything else should be straightforward.


  • VM/CTI.cpp: (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain):
  • VM/CTI.h: (JSC::CTI::compileGetByIdProto): (JSC::CTI::compileGetByIdChain):
  • VM/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::JSPropertyNameIterator):
  • VM/Machine.cpp: (JSC::Machine::Machine): (JSC::cachePrototypeChain): (JSC::Machine::tryCachePutByID): (JSC::Machine::tryCacheGetByID): (JSC::Machine::privateExecute): (JSC::Machine::tryCTICachePutByID): (JSC::Machine::tryCTICacheGetByID):
  • kjs/GetterSetter.h: (JSC::GetterSetter::GetterSetter):
  • kjs/JSCell.h:
  • kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • kjs/JSGlobalData.h:
  • kjs/JSGlobalObject.h: (JSC::StructureID::prototypeForLookup):
  • kjs/JSNumberCell.h: (JSC::JSNumberCell::JSNumberCell): (JSC::jsNumberCell):
  • kjs/JSObject.h: (JSC::JSObject::prototype):
  • kjs/JSString.cpp: (JSC::jsString): (JSC::jsSubstring): (JSC::jsOwnedString):
  • kjs/JSString.h: (JSC::JSString::JSString): (JSC::JSString::): (JSC::jsSingleCharacterString): (JSC::jsSingleCharacterSubstring): (JSC::jsNontrivialString):
  • kjs/SmallStrings.cpp: (JSC::SmallStrings::createEmptyString): (JSC::SmallStrings::createSingleCharacterString):
  • kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::addPropertyTransition): (JSC::StructureID::getterSetterTransition): (JSC::StructureIDChain::StructureIDChain):
  • kjs/StructureID.h: (JSC::StructureID::create): (JSC::StructureID::storedPrototype):
1:09 AM Changeset in webkit [36315] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-09-09 Joerg Bornemann <​joerg.bornemann@trolltech.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=20746

Added WINCE platform macro.

  • wtf/Platform.h:
12:03 AM Changeset in webkit [36314] by weinig@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-09-09 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Remove unnecessary override of getOffset.

Sunspider reports this as a .6% progression.

  • JavaScriptCore.exp:
  • kjs/JSObject.h: (JSC::JSObject::getDirectLocation): (JSC::JSObject::getOwnPropertySlotForWrite): (JSC::JSObject::putDirect):
  • kjs/PropertyMap.cpp:
  • kjs/PropertyMap.h:

Sep 9, 2008:

10:29 PM Changeset in webkit [36313] by hyatt@apple.com
  • 3 edits in trunk/WebCore

Resurrect PlatformScrollbarWin.

8:43 PM Changeset in webkit [36312] by cwzwarich@webkit.org
  • 2 edits in trunk/SunSpider

2008-09-09 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Rubber-stamped by Maciej Stachowiak.

The bleeding edge branch of V8 now supports passing fileanmes after
'-f', so the SunSpider script should be changed to do this again.
This allows all 3 major JavaScript engines to be used with the
unmodified SunSpider script.

  • sunspider:
8:22 PM Changeset in webkit [36311] by cwzwarich@webkit.org
  • 8 edits
    1 add
    4 deletes in trunk

2008-09-09 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej Stachowiak.

Bug 20759: Remove MacroAssembler
<​https://bugs.webkit.org/show_bug.cgi?id=20759>

Remove MacroAssembler and move its functionality to X86Assembler.

JavaScriptCore:

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::emitPutArg): (JSC::CTI::emitPutCTIParam): (JSC::CTI::emitGetCTIParam): (JSC::CTI::emitPutToCallFrameHeader): (JSC::CTI::emitGetFromCallFrameHeader): (JSC::CTI::emitPutResult): (JSC::CTI::emitDebugExceptionCheck): (JSC::CTI::emitJumpSlowCaseIfNotImm): (JSC::CTI::emitJumpSlowCaseIfNotImms): (JSC::CTI::emitFastArithDeTagImmediate): (JSC::CTI::emitFastArithReTagImmediate): (JSC::CTI::emitFastArithPotentiallyReTagImmediate): (JSC::CTI::emitFastArithImmToInt): (JSC::CTI::emitFastArithIntToImmOrSlowCase): (JSC::CTI::emitFastArithIntToImmNoCheck): (JSC::CTI::compileOpCall): (JSC::CTI::emitSlowScriptCheck): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile): (JSC::CTI::privateCompileGetByIdSelf): (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain): (JSC::CTI::privateCompilePutByIdReplace): (JSC::CTI::privateArrayLengthTrampoline): (JSC::CTI::privateStringLengthTrampoline): (JSC::CTI::compileRegExp):
  • VM/CTI.h: (JSC::CallRecord::CallRecord): (JSC::JmpTable::JmpTable): (JSC::SlowCaseEntry::SlowCaseEntry): (JSC::CTI::JSRInfo::JSRInfo):
  • masm/MacroAssembler.h: Removed.
  • masm/MacroAssemblerWin.cpp: Removed.
  • masm/X86Assembler.h: (JSC::X86Assembler::emitConvertToFastCall): (JSC::X86Assembler::emitRestoreArgumentReference):
  • wrec/WREC.h: (JSC::WRECGenerator::WRECGenerator): (JSC::WRECParser::WRECParser):

WebCore:

  • ForwardingHeaders/masm/IA32MacroAsm.h: Removed.
  • ForwardingHeaders/masm/MacroAssembler.h: Removed.
  • ForwardingHeaders/masm/X86Assembler.h: Added.
7:36 PM Changeset in webkit [36310] by weinig@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-09-09 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

Don't waste the first item in the PropertyStorage.

  • Fix typo (makingCount -> markingCount)
  • Remove undefined method declaration.

No change on Sunspider.

  • kjs/JSObject.cpp: (JSC::JSObject::mark):
  • kjs/PropertyMap.cpp: (JSC::PropertyMap::put): (JSC::PropertyMap::remove): (JSC::PropertyMap::getOffset): (JSC::PropertyMap::insert): (JSC::PropertyMap::rehash): (JSC::PropertyMap::resizePropertyStorage): (JSC::PropertyMap::checkConsistency):
  • kjs/PropertyMap.h: (JSC::PropertyMap::markingCount): Fix typo.
6:26 PM Changeset in webkit [36309] by alp@webkit.org
  • 6 edits in trunk/WebCore

2008-09-09 Alp Toker <​alp@nuanti.com>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=16792
[GTK] Fails to render Japanese/Chinese text with simple path

​https://bugs.webkit.org/show_bug.cgi?id=16942
[GTK] Oddities in font selection and fall back

​https://bugs.webkit.org/show_bug.cgi?id=16862
[GTK] Custom fonts hard-coded to use grayscale antialiasing and no hinting

GTK+ font fixes and enhancements.

Implement font fallback for the simple FontConfig-based text path and
improve the Pango-based complex text path to make use of requested
font properties and available font selection.

Add text shadow support to the complex path.

  • platform/graphics/gtk/FontCacheGtk.cpp: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData):
  • platform/graphics/gtk/FontGtk.cpp: (WebCore::setPangoAttributes): (WebCore::Font::drawComplexText): (WebCore::getDefaultPangoLayout): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
  • platform/graphics/gtk/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::hash):
  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformDestroy):
6:21 PM Changeset in webkit [36308] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-09-09 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Not reviewed.

Speculative Windows build fix.

  • masm/MacroAssemblerWin.cpp: (JSC::MacroAssembler::emitConvertToFastCall): (JSC::MacroAssembler::emitRestoreArgumentReference):
6:11 PM Changeset in webkit [36307] by cwzwarich@webkit.org
  • 6 edits in trunk/JavaScriptCore

2008-09-09 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej Stachowiak.

Bug 20755: Create an X86 namespace for register names and other things
<​https://bugs.webkit.org/show_bug.cgi?id=20755>

Create an X86 namespace to put X86 register names. Perhaps I will move
opcode names here later as well.

  • VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::emitPutArg): (JSC::CTI::emitPutArgConstant): (JSC::CTI::emitPutCTIParam): (JSC::CTI::emitGetCTIParam): (JSC::CTI::emitPutToCallFrameHeader): (JSC::CTI::emitGetFromCallFrameHeader): (JSC::CTI::emitPutResult): (JSC::CTI::emitDebugExceptionCheck): (JSC::CTI::emitJumpSlowCaseIfNotImms): (JSC::CTI::compileOpCall): (JSC::CTI::emitSlowScriptCheck): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile): (JSC::CTI::privateCompileGetByIdSelf): (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain): (JSC::CTI::privateCompilePutByIdReplace): (JSC::CTI::privateArrayLengthTrampoline): (JSC::CTI::privateStringLengthTrampoline): (JSC::CTI::compileRegExp):
  • VM/CTI.h:
  • masm/X86Assembler.h: (JSC::X86::): (JSC::X86Assembler::emitModRm_rm): (JSC::X86Assembler::emitModRm_rm_Unchecked): (JSC::X86Assembler::emitModRm_rmsib):
  • wrec/WREC.cpp: (JSC::WRECGenerator::generateNonGreedyQuantifier): (JSC::WRECGenerator::generateGreedyQuantifier): (JSC::WRECGenerator::generateParentheses): (JSC::WRECGenerator::generateBackreference): (JSC::WRECGenerator::gernerateDisjunction):
  • wrec/WREC.h:
5:07 PM Changeset in webkit [36306] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-09 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Remove unnecessary friend declaration.

  • kjs/PropertyMap.h:
4:51 PM Changeset in webkit [36305] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Fix the classic look on Windows by resolving the constants conflict between slider parts and buttons/checkboxes.

4:42 PM Changeset in webkit [36304] by weinig@apple.com
  • 6 edits in trunk/JavaScriptCore

2008-09-09 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Replace uses of PropertyMap::get and PropertyMap::getLocation with
PropertyMap::getOffset.

Sunspider reports this as a .6% improvement.

  • JavaScriptCore.exp:
  • kjs/JSObject.cpp: (JSC::JSObject::put): (JSC::JSObject::deleteProperty): (JSC::JSObject::getPropertyAttributes):
  • kjs/JSObject.h: (JSC::JSObject::getDirect): (JSC::JSObject::getDirectLocation): (JSC::JSObject::locationForOffset):
  • kjs/PropertyMap.cpp: (JSC::PropertyMap::remove): (JSC::PropertyMap::getOffset):
  • kjs/PropertyMap.h:
4:36 PM Changeset in webkit [36303] by dino@apple.com
  • 3 edits
    4 adds in trunk

2008-09-05 Chris Marrin <​cmarrin@apple.com>

Reviewed by Sam Weinig.

Need to handle the case when 0% or 100% keyframe is omitted
​https://bugs.webkit.org/show_bug.cgi?id=20679

Tests: animations/keyframes-from-missing.html

animations/keyframes-to-missing.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::addKeyframeStyle):
4:11 PM Changeset in webkit [36302] by hyatt@apple.com
  • 5 edits in trunk/WebCore

Resurrect RenderThemeWin and bring it up to ToT.

3:35 PM Changeset in webkit [36301] by cwzwarich@webkit.org
  • 5 edits in trunk/JavaScriptCore

2008-09-09 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Sam Weinig.

Bug 20754: Remove emit prefix from assembler opcode methods
<​https://bugs.webkit.org/show_bug.cgi?id=20754>

  • VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::emitPutArg): (JSC::CTI::emitPutArgConstant): (JSC::CTI::emitPutCTIParam): (JSC::CTI::emitGetCTIParam): (JSC::CTI::emitPutToCallFrameHeader): (JSC::CTI::emitGetFromCallFrameHeader): (JSC::CTI::emitPutResult): (JSC::CTI::emitDebugExceptionCheck): (JSC::CTI::emitCall): (JSC::CTI::emitJumpSlowCaseIfNotImm): (JSC::CTI::emitJumpSlowCaseIfNotImms): (JSC::CTI::emitFastArithDeTagImmediate): (JSC::CTI::emitFastArithReTagImmediate): (JSC::CTI::emitFastArithPotentiallyReTagImmediate): (JSC::CTI::emitFastArithImmToInt): (JSC::CTI::emitFastArithIntToImmOrSlowCase): (JSC::CTI::emitFastArithIntToImmNoCheck): (JSC::CTI::compileOpCall): (JSC::CTI::emitSlowScriptCheck): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile): (JSC::CTI::privateCompileGetByIdSelf): (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain): (JSC::CTI::privateCompilePutByIdReplace): (JSC::CTI::privateArrayLengthTrampoline): (JSC::CTI::privateStringLengthTrampoline): (JSC::CTI::compileRegExp):
  • masm/MacroAssemblerWin.cpp: (JSC::MacroAssembler::emitConvertToFastCall): (JSC::MacroAssembler::emitRestoreArgumentReference):
  • masm/X86Assembler.h: (JSC::X86Assembler::pushl_r): (JSC::X86Assembler::pushl_m): (JSC::X86Assembler::popl_r): (JSC::X86Assembler::popl_m): (JSC::X86Assembler::movl_rr): (JSC::X86Assembler::addl_rr): (JSC::X86Assembler::addl_i8r): (JSC::X86Assembler::addl_i32r): (JSC::X86Assembler::addl_mr): (JSC::X86Assembler::andl_rr): (JSC::X86Assembler::andl_i32r): (JSC::X86Assembler::cmpl_i8r): (JSC::X86Assembler::cmpl_rr): (JSC::X86Assembler::cmpl_rm): (JSC::X86Assembler::cmpl_i32r): (JSC::X86Assembler::cmpl_i32m): (JSC::X86Assembler::cmpw_rm): (JSC::X86Assembler::orl_rr): (JSC::X86Assembler::subl_rr): (JSC::X86Assembler::subl_i8r): (JSC::X86Assembler::subl_i32r): (JSC::X86Assembler::subl_mr): (JSC::X86Assembler::testl_i32r): (JSC::X86Assembler::testl_rr): (JSC::X86Assembler::xorl_i8r): (JSC::X86Assembler::xorl_rr): (JSC::X86Assembler::sarl_i8r): (JSC::X86Assembler::sarl_CLr): (JSC::X86Assembler::shl_i8r): (JSC::X86Assembler::shll_CLr): (JSC::X86Assembler::mull_rr): (JSC::X86Assembler::idivl_r): (JSC::X86Assembler::cdq): (JSC::X86Assembler::movl_mr): (JSC::X86Assembler::movzwl_mr): (JSC::X86Assembler::movl_rm): (JSC::X86Assembler::movl_i32r): (JSC::X86Assembler::movl_i32m): (JSC::X86Assembler::leal_mr): (JSC::X86Assembler::ret): (JSC::X86Assembler::jmp_r): (JSC::X86Assembler::jmp_m): (JSC::X86Assembler::call_r):
  • wrec/WREC.cpp: (JSC::WRECGenerator::generateBacktrack1): (JSC::WRECGenerator::generateBacktrackBackreference): (JSC::WRECGenerator::generateBackreferenceQuantifier): (JSC::WRECGenerator::generateNonGreedyQuantifier): (JSC::WRECGenerator::generateGreedyQuantifier): (JSC::WRECGenerator::generatePatternCharacter): (JSC::WRECGenerator::generateCharacterClassInvertedRange): (JSC::WRECGenerator::generateCharacterClassInverted): (JSC::WRECGenerator::generateCharacterClass): (JSC::WRECGenerator::generateParentheses): (JSC::WRECGenerator::gererateParenthesesResetTrampoline): (JSC::WRECGenerator::generateAssertionBOL): (JSC::WRECGenerator::generateAssertionEOL): (JSC::WRECGenerator::generateAssertionWordBoundary): (JSC::WRECGenerator::generateBackreference): (JSC::WRECGenerator::gernerateDisjunction):
1:44 PM Changeset in webkit [36300] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-09-09 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej Stachowiak.

Clean up the WREC code some more.

  • VM/CTI.cpp: (JSC::CTI::compileRegExp):
  • wrec/WREC.cpp: (JSC::getCharacterClassNewline): (JSC::getCharacterClassDigits): (JSC::getCharacterClassSpaces): (JSC::getCharacterClassWordchar): (JSC::getCharacterClassNondigits): (JSC::getCharacterClassNonspaces): (JSC::getCharacterClassNonwordchar): (JSC::WRECGenerator::generateBacktrack1): (JSC::WRECGenerator::generateBacktrackBackreference): (JSC::WRECGenerator::generateBackreferenceQuantifier): (JSC::WRECGenerator::generateNonGreedyQuantifier): (JSC::WRECGenerator::generateGreedyQuantifier): (JSC::WRECGenerator::generatePatternCharacter): (JSC::WRECGenerator::generateCharacterClassInvertedRange): (JSC::WRECGenerator::generateCharacterClassInverted): (JSC::WRECGenerator::generateCharacterClass): (JSC::WRECGenerator::generateParentheses): (JSC::WRECGenerator::gererateParenthesesResetTrampoline): (JSC::WRECGenerator::generateAssertionBOL): (JSC::WRECGenerator::generateAssertionEOL): (JSC::WRECGenerator::generateAssertionWordBoundary): (JSC::WRECGenerator::generateBackreference): (JSC::WRECGenerator::gernerateDisjunction): (JSC::WRECParser::parseCharacterClass): (JSC::WRECParser::parseEscape): (JSC::WRECParser::parseTerm):
  • wrec/WREC.h:
12:50 PM Changeset in webkit [36299] by dino@apple.com
  • 3 edits
    4 adds in trunk

2008-09-09 Dean Jackson <​dino@apple.com>

Reviewed by Sam Weinig.

Document::createEvent missing cases for animation and
transition events.
​https://bugs.webkit.org/show_bug.cgi?id=20734

Test: transitions/transition-end-event-create.html
Test: animations/animation-events-create.html

  • dom/Document.cpp: (WebCore::Document::createEvent):
    • add the two cases
12:07 PM Changeset in webkit [36298] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac
  • Tiger build fix
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
11:48 AM Changeset in webkit [36297] by mitz@apple.com
  • 5 edits in trunk/WebCore
  • Tiger build fix
  • WebCore.Tiger.exp:
  • WebCore.base.exp:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
11:12 AM Changeset in webkit [36296] by mitz@apple.com
  • 13 edits in trunk

WebCore:

Reviewed by Darin Adler.

  • WebCore part of <rdar://problem/6206244> Use alternate character-to-glyph interface on Leopard
  • WebCore.Tiger.exp:
  • WebCore.base.exp:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp: (WebCore::GlyphPage::fill):
  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::initFontData): (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformDestroy):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

WebKit/mac:

Reviewed by Darin Adler.

  • WebKit part of <rdar://problem/6206244> Use alternate character-to-glyph interface on Leopard
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

WebKitLibraries:

Reviewed by Darin Adler.

  • WebKitLibraries part of <rdar://problem/6206244> Use alternate character-to-glyph interface on Leopard
  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
9:40 AM Changeset in webkit [36295] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-09-09 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/6198545> REGRESSION: Inspector debugger barfs on
breakpoints inside eval.

  • page/inspector/inspector.js:
7:17 AM Changeset in webkit [36294] by Simon Hausmann
  • 4 edits in trunk/WebCore

2008-09-09 Joerg Bornemann <​joerg.bornemann@trolltech.com>

Reviewed by Simon.

Fix compilation of the Qt port with disabled plugins on Windows

7:17 AM Changeset in webkit [36293] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-09-09 Joerg Bornemann <​joerg.bornemann@trolltech.com>

Reviewed by Simon.

Added missing WebCore prefix to ResourceRequest

This is needed for Windows/CE compilation where there is a conflict
with a global ResourceRequest type. Elsewhere in this file ResourceRequest

is also prefixed with WebCore
2:01 AM Changeset in webkit [36292] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix, rubber-stamped by Anders Carlsson.

Silence spurious build warnings about missing format attributes on functions in Assertions.cpp.

2:00 AM Changeset in webkit [36291] by mrowe@apple.com
  • 6 edits
    1 move
    1 delete in trunk/JavaScriptCore

Fix builds using the "debug" variant.

Rubber-stamped by Oliver Hunt.

This reverts r36130 and tweaks Identifier to export the same symbols for Debug
and Release configurations.

(JSC::Identifier::addSlowCase): #ifdef the call to checkSameIdentifierTable so that
there is no overhead in Release builds.
(JSC::Identifier::checkSameIdentifierTable): Add empty functions for Release builds.

  • kjs/identifier.h:

(JSC::Identifier::add): #ifdef the calls to checkSameIdentifierTable so that there is
no overhead in Release builds, and remove the inline definitions of checkSameIdentifierTable.

1:55 AM Changeset in webkit [36290] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-09-09 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej Stachowiak.

Clean up WREC a bit to bring it closer to our coding style guidelines.

  • wrec/WREC.cpp: (JSC::): (JSC::getCharacterClass_newline): (JSC::getCharacterClass_d): (JSC::getCharacterClass_s): (JSC::getCharacterClass_w): (JSC::getCharacterClass_D): (JSC::getCharacterClass_S): (JSC::getCharacterClass_W): (JSC::CharacterClassConstructor::append): (JSC::WRECGenerator::generateNonGreedyQuantifier): (JSC::WRECGenerator::generateGreedyQuantifier): (JSC::WRECGenerator::generateCharacterClassInverted): (JSC::WRECParser::parseQuantifier): (JSC::WRECParser::parsePatternCharacterQualifier): (JSC::WRECParser::parseCharacterClassQuantifier): (JSC::WRECParser::parseBackreferenceQuantifier):
  • wrec/WREC.h: (JSC::Quantifier::): (JSC::Quantifier::Quantifier):
1:11 AM Changeset in webkit [36289] by ap@webkit.org
  • 7 edits in trunk

2008-09-09 Jungshik Shin <​jungshik.shin@gmail.com>

Reviewed by Alexey Proskuryakov.

Try MIME charset names before trying IANA names
( ​https://bugs.webkit.org/show_bug.cgi?id=17537 )

With this change, shorter and more widely used names (preferred MIME
names) are returned by document.charset, document.characterSet,
document.inputEncoding rather than IANA names. This helps
fixing bug 18085 in addition to web developers who are more familiar
with MIME names. For instance, EUC-JP, ISO-8859-X and US-ASCII will be
returned instead of Extended_UNIX_Code_Packed_Format_for_Japanese,
ISO-8859-X:19xx, and ANSI_X3.4-1968. It also replaces IBM8xx with cp8xx.
Note that cp/IBM 8xx are extremly rare in today's web. Even if they're
used, the former is still recognized as aliases to the latter so that
there's very little, if any, to worry about.

1:05 AM Changeset in webkit [36288] by cwzwarich@webkit.org
  • 3 edits
    3 adds in trunk

2008-09-09 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Mark Rowe.

Bug 20719: REGRESSION (r36135-36244): Hangs, then crashes after several seconds
<​https://bugs.webkit.org/show_bug.cgi?id=20719>
<rdar://problem/6205787>

Fix a typo in the case-insensitive matching of character patterns.

JavaScriptCore:

  • wrec/WREC.cpp: (JSC::WRECGenerator::generatePatternCharacter):

LayoutTests:

  • fast/js/regexp-char-insensitive-expected.txt: Added.
  • fast/js/regexp-char-insensitive.html: Added.
  • fast/js/resources/regexp-char-insensitive.js: Added.
1:00 AM Changeset in webkit [36287] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Maciej Stachowiak.

  • update results for the addition of console.dirxml
  • fast/dom/Window/window-properties-expected.txt:
12:58 AM Changeset in webkit [36286] by mjs@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-09-09 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Sam Weinig.


  • allow polymorphic inline cache to handle Math object functions and possibly other similar things


1.012x speedup on SunSpider.

  • kjs/MathObject.cpp: (JSC::MathObject::getOwnPropertySlot):
  • kjs/lookup.cpp: (JSC::setUpStaticFunctionSlot):
  • kjs/lookup.h: (JSC::getStaticPropertySlot):
Note: See TracTimeline for information about the timeline view.