Timeline
Oct 7, 2008:
- 11:36 PM Changeset in webkit [37408] by
-
- 5 edits in trunk/JavaScriptCore
2008-10-07 Sam Weinig <sam@webkit.org>
Roll out r37405.
- 10:24 PM Changeset in webkit [37407] by
-
- 1 copy in tags/Safari-5525.26
New tag.
- 9:56 PM Changeset in webkit [37406] by
-
- 6 edits in trunk/JavaScriptCore
Switch CTI runtime calls to the fastcall calling convention
Reviewed by Cameron Zwarich
Basically this means that we get to store the argument for CTI
calls in the ECX register, which saves a register->memory write
and subsequent memory->register read.
This is a 1.7% progression in SunSpider and 2.4% on commandline
v8 tests on Windows
- 8:46 PM Changeset in webkit [37405] by
-
- 5 edits in trunk/JavaScriptCore
2008-10-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Mark Rowe.
- optimize away multiplication by constant 1.0
2.3% speedup on v8 RayTrace benchmark
Apparently it's not uncommon for JavaScript code to multiply by
constant 1.0 in the mistaken belief that this converts integer to
floating point and that there is any operational difference.
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): Optimize to_jsnumber for case where parameter is already number. (JSC::CTI::privateCompileSlowCases): ditto
- VM/Machine.cpp: (JSC::Machine::privateExecute): ditto
- kjs/grammar.y: (makeMultNode): Transform as follows: +FOO * BAR ==> FOO * BAR FOO * +BAR ==> FOO * BAR FOO * 1 ==> +FOO 1 * FOO ==> +FOO (makeDivNode): Transform as follows: +FOO / BAR ==> FOO / BAR FOO / +BAR ==> FOO / BAR (makeSubNode): Transform as follows: +FOO - BAR ==> FOO - BAR FOO - +BAR ==> FOO - BAR
- kjs/nodes.h: (JSC::ExpressionNode::stripUnaryPlus): Helper for above grammar.y changes (JSC::UnaryPlusNode::stripUnaryPlus): ditto
- 8:46 PM Changeset in webkit [37404] by
-
- 1 edit3 adds in trunk/LayoutTests
2008-10-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Mark Rowe.
- test cases that will check some possible edge cases for math optimizations
- fast/js/math-transforms-expected.txt: Added.
- fast/js/math-transforms.html: Added.
- fast/js/resources/math-transforms.js: Added.
- 5:42 PM Changeset in webkit [37403] by
-
- 4 edits in trunk
2008-10-07 Alp Toker <alp@nuanti.com>
GTK+ build fix for older automake versions (1.7). Discussed in bug
#21392.
- 5:15 PM Changeset in webkit [37402] by
-
- 2 edits in trunk/JavaScriptCore
2008-10-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
- make constant folding code more consistent
Added a makeSubNode to match add, mult and div; use the makeFooNode functions always,
instead of allocating nodes directly in other places in the grammar.
- kjs/grammar.y:
- 5:12 PM Changeset in webkit [37401] by
-
- 5 edits4 deletes in trunk
Roll out r37391 as it appears to have broken 40+ regression tests.
- 4:49 PM Changeset in webkit [37400] by
-
- 6 edits in trunk/JavaScriptCore
2008-10-07 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Move hasGetterSetterProperties flag from PropertyMap to StructureID.
- kjs/JSObject.cpp: (JSC::JSObject::put): (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter):
- kjs/JSObject.h: (JSC::JSObject::hasGetterSetterProperties): (JSC::JSObject::getOwnPropertySlotForWrite): (JSC::JSObject::getOwnPropertySlot):
- kjs/PropertyMap.h:
- kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::addPropertyTransition): (JSC::StructureID::toDictionaryTransition): (JSC::StructureID::changePrototypeTransition): (JSC::StructureID::getterSetterTransition):
- kjs/StructureID.h: (JSC::StructureID::hasGetterSetterProperties): (JSC::StructureID::setHasGetterSetterProperties):
- 4:31 PM Changeset in webkit [37399] by
-
- 2 edits in trunk/WebCore
2008-10-07 Anders Carlsson <andersca@apple.com>
Reviewed by Antti Koivisto.
<rdar://problem/6273887> Crash in ApplicationCacheGroup
Make sure to stop loading even before a cache update is in progress so that the
manifest load will be stopped.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::~ApplicationCacheGroup): (WebCore::ApplicationCacheGroup::stopLoading): (WebCore::ApplicationCacheGroup::cacheUpdateFailed):
- 3:09 PM Changeset in webkit [37398] by
-
- 2 edits in trunk/WebCore/bindings/objc
Fix the build due to a bad patch apply.
- 3:08 PM Changeset in webkit [37397] by
-
- 2 edits in trunk/WebCore/bindings/objc
Fix the build due to a bad patch apply.
- 2:49 PM Changeset in webkit [37396] by
-
- 10 edits2 adds in trunk/WebCore
Auto-generate DOMDocument's createNodeIterator: and createTreeWalker: methods.
Reviewed by Sam Weinig.
- WebCore.xcodeproj/project.pbxproj: Add ObjCNodeFilterCondition.{mm,h}.
- bindings/objc/DOM.mm: Remove previous category implementations on DOMDocument for createNodeIterator: and createTreeWalker:. Also moves ObjCNodeFilterCondition to its own file.
- bindings/objc/DOMTraversal.h: Remove the category methods that added createNodeIterator: and createTreeWalker: to DOMDocument. This is fine to do since DOmDocument.h is included still, and has these methods.
- bindings/objc/DOMUtility.mm: (JSC::createDOMWrapper): Remove special case for JSNodeIterator and JSTreeWalker now that the ObjC binding conforms to the standard wrap.
- bindings/objc/ObjCNodeFilterCondition.h: Split out from DOM.mm. (WebCore::ObjCNodeFilterCondition::create): Moved from DOM.mm. (WebCore::ObjCNodeFilterCondition::ObjCNodeFilterCondition): Ditto.
- bindings/objc/ObjCNodeFilterCondition.mm: Split out from DOM.mm. (WebCore::ObjCNodeFilterCondition::acceptNode): Moved from DOM.mm.
- bindings/objc/PublicDOMInterfaces.h: Add the createNodeIterator: and createTreeWalker: methods to DOMDocument.
- bindings/scripts/CodeGeneratorObjC.pm: (GetObjCTypeGetter): Add a case for NodeFilter. (AddIncludesForType): Include ObjCNodeFilterCondition.h for NodeFilter. (GenerateImplementation): Remove existing NodeFilter special case that used the m_filter member variable. Add a new special getter for protocol types that aren't EventTarget, so the right class is used for NodeFilter. Add a special case for NodeFilter where it creates an ObjCNodeFilterCondition.
- dom/Document.idl: Remove the #ifdef LANGUAGE_OBJECTIVE_C. Add the OldStyleObjC extended attribute to createNodeIterator and createTreeWalker. Rename the entityReferenceExpansion parameter to expandEntityReferences to match the previous ObjC API.
- dom/NodeIterator.idl: Remove ObjCIvar from the filter attribute. The m_filter member variable was never used in practice, it was always nil! We can remove it and not pad the object because this can't be subclassed.
- dom/TreeWalker.idl: Ditto.
- 2:49 PM Changeset in webkit [37395] by
-
- 7 edits2 adds in trunk/WebCore
Auto-generate the DOMEventTarget protocol implementation for
DOMNode and DOMSVGElementInstance.
Reviewed by Darin Adler.
- WebCore.xcodeproj/project.pbxproj: Add ObjCEventListener.{mm,h}.
- bindings/objc/DOM.mm: Remove many unneeded header includes. Move ObjCEventListener to it's own file. Remove the manual impelmentations of the DOMEventTarget protocol for DOMNode and DOMSVGElementInstance.
- bindings/objc/DOMEvents.h: Remove the categories that defined DOMEventTarget for DOMNode and DOMSVGElementInstance.
- bindings/objc/ObjCEventListener.h: Split out from DOM.mm.
- bindings/objc/ObjCEventListener.mm: Split out from DOM.mm. (WebCore::ObjCEventListener::find): Moved from DOM.mm. (WebCore::ObjCEventListener::wrap): Use PassRefPtr to prevent the callers from doing a manual deref. (WebCore::ObjCEventListener::ObjCEventListener): Moved from DOM.mm. (WebCore::ObjCEventListener::~ObjCEventListener): Ditto.
- bindings/scripts/CodeGeneratorObjC.pm: (GetObjCTypeGetter): Add a case for EventListener and use WTF::getPtr. (AddIncludesForType): Include ObjCEventListener.h for EventListener. And include EventTargetSVGElementInstance.h for SVGElementInstance. (GenerateHeader): Remove the check for multiple parents. (GenerateImplementation): Remove the check for multiple parents. Remove the @deprecatedFunctions array since deprecated methods get generated into the main @interface now to work with protocols. Add support for the EventTargetNodeCast extended attribute. Add support for EventListener parameters.
- dom/Node.idl: Define superclasses for ObjC so the implementation and interface implement the DOMEventTarget protocol. Explicitly specify Object as a superclass to use DOMEventTarget. Object will turn into DOMObject. This is needed to take the code generator down the right path of multiple super-classes as protocols. It is ObjC only for legacy reasons. The event target methods are normally on NodeEventTarget, a subclass of Node. But the ObjC API has never has this subclass and they are on DOMNode.
- svg/SVGElementInstance.idl: Ditto.
- 2:36 PM Changeset in webkit [37394] by
-
- 3 edits in trunk/WebCore
2008-10-07 David Hyatt <hyatt@apple.com>
Add new pseudo-elements and pseudo-classes that will enable scrollbars to be styled by CSS.
The new pseudo-elements are:
scrollbar
scrollbar-button
scrollbar-corner
scrollbar-thumb
scrollbar-track
These elements will work with all the usual pseudo-classes (:hover, :active, :enabled, :disabled, etc.) and with
the following new pseudo-classes:
scrollbar-active
scrollbar-back
scrollbar-forward
scrollbar-horizontal
scrollbar-vertical
Reviewed by Adele
- css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
- css/CSSSelector.h: (WebCore::CSSSelector::):
- 2:35 PM Changeset in webkit [37393] by
-
- 2 edits in trunk/WebKitTools
Make sure short functions get included in ChangeLog output for git repositories
Reviewed by Dave Kilzer.
- Scripts/prepare-ChangeLog: (sub diffCommand): Pass -U0 to git diff so that each contiguous change will get its own chunk without any surrounding context. (sub extractLineRange): Use the line numbers from the chunk header without modifying them now that they're accurate.
- 2:29 PM Changeset in webkit [37392] by
-
- 3 edits in trunk/WebKitLibraries
2008-10-07 Anders Carlsson <andersca@apple.com>
Reviewed by Mitz Pettel.
Update WebKitSystemInterface.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 2:27 PM Changeset in webkit [37391] by
-
- 5 edits4 adds in trunk
Reviewed by Darin Adler, Nikolas Zimmermann and Dave Hyatt.
svgElement.className.baseValue = "foo" does not work
https://bugs.webkit.org/show_bug.cgi?id=20651
- dom/StyledElement.cpp: (WebCore::StyledElement::classAttributeChanged): (WebCore::StyledElement::parseMappedAttribute):
- dom/StyledElement.h:
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::svgAttributeChanged):
- 2:22 PM Changeset in webkit [37390] by
-
- 2 edits in trunk/SunSpider
2008-10-07 David Hyatt <hyatt@apple.com>
Remove global substitution from SunSpider regexp test, since only Firefox was honoring it and
we want all browsers to be doing the same thing on the test.
Reviewed by Maciej
- tests/regexp-dna.js:
- 2:08 PM Changeset in webkit [37389] by
-
- 3 edits in trunk/WebCore
Add support to the Resources panel for queries like "#123", "foo #123",
"line: 123" and "foo line: 123". These will match the query limiting
the search only to the line specified. If only a line is specified,
the whole line is matched.
Reviewed by Darin Adler.
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.sourceRow): Don't return the last row if the index is greater than the rows collection. Let it return undefined by indexing out-of-bounds.
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.performSearch): Add support for queries like "#123", "foo #123", "line: 123" and "foo line: 123". Also match the whole query to the whole document in case there are colors like "#333".
- 1:49 PM Changeset in webkit [37388] by
-
- 10 edits in trunk/JavaScriptCore
2008-10-07 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Roll r37370 back in with bug fixes.
- PropertyMap::storageSize() should reflect the number of keys + deletedOffsets and has nothing to do with the internal deletedSentinel count anymore.
- 1:32 PM Changeset in webkit [37387] by
-
- 4 edits in trunk/WebKit/mac
2008-10-07 David Hyatt <hyatt@apple.com>
Move viewless WebKit methods that Safari needs from WebViewInternal to WebViewPrivate.
Reviewed by Tim Hatcher
- WebView/WebView.mm: (WebKitInitializeApplicationCachePathIfNecessary): (-[WebView _registerDraggedTypes]): (-[WebView _usesDocumentViews]): (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]): (-[WebView isFlipped]): (-[WebView viewWillDraw]):
- WebView/WebViewInternal.h:
- WebView/WebViewPrivate.h:
- 1:27 PM Changeset in webkit [37386] by
-
- 7 edits in trunk/JavaScriptCore
2008-10-07 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Move callframe initialization into JIT code, again.
As a part of the restructuring the second result from functions is now
returned in edx, allowing the new value of 'r' to be returned via a
register, and stored to the stack from JIT code, too.
4.5% progression on v8-tests. (3% in their harness)
- VM/CTI.cpp: (JSC::): (JSC::CTI::emitCall): (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile):
- VM/CTI.h: (JSC::CallRecord::CallRecord):
- VM/Machine.cpp: (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_construct_JSConstruct): (JSC::Machine::cti_op_resolve_func): (JSC::Machine::cti_op_post_inc): (JSC::Machine::cti_op_resolve_with_base): (JSC::Machine::cti_op_post_dec):
- VM/Machine.h:
- kjs/JSFunction.h:
- kjs/ScopeChain.h:
- 1:17 PM Changeset in webkit [37385] by
-
- 2 edits in trunk/WebKit/mac
2008-10-07 David Hyatt <hyatt@apple.com>
Fix crash in isFlipped. Null check _private since isFlipped can get called from within AppKit
machinery during teardown of the WebView.
Reviewed by Adam Roben
- WebView/WebView.mm: (-[WebView isFlipped]):
- 1:15 PM Changeset in webkit [37384] by
-
- 4 edits in trunk/WebKit/mac
2008-10-07 David Hyatt <hyatt@apple.com>
Make viewless WebKit update focused and active state when the window becomes and loses key.
The focus controller has been patched to understand that in viewless mode it can recur down and
update all of the frames, which is why this code works now when placed just on the WebView.
Reviewed by Adam Roben
- WebView/WebView.mm: (-[WebView addWindowObservers]): (-[WebView removeWindowObservers]): (-[WebView viewWillMoveToWindow:]): (-[WebView viewDidMoveToWindow]): (-[WebView _updateFocusedAndActiveState]): (-[WebView _windowDidBecomeKey:]): (-[WebView _windowDidResignKey:]): (-[WebView _windowWillOrderOnScreen:]):
- 12:35 PM Changeset in webkit [37383] by
-
- 3 edits in trunk/JavaScriptCore
Fix typo in method name.
- 11:28 AM Changeset in webkit [37382] by
-
- 4 edits in trunk
2008-10-07 Alp Toker <alp@nuanti.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=21392
[GTK] Auto-generate JS DOM binding sources list
Remove the huge lists of generated DOM binding sources and headers in
the build system. These are difficult to maintain and can be derived
automatically.
The new strategy is to re-use the existing lists of IDL sources (which
are needed for dist support anyway). This will also ease the addition
of new language bindings.
- 11:17 AM Changeset in webkit [37381] by
-
- 10 edits in trunk/JavaScriptCore
2008-10-07 Cameron Zwarich <zwarich@apple.com>
Rubber-stamped by Mark Rowe.
Roll out r37370.
- 10:30 AM Changeset in webkit [37380] by
-
- 6 edits4 adds in branches/Safari-3-2-branch
Merge r35415.
- 10:30 AM Changeset in webkit [37379] by
-
- 11 edits2 adds in branches/Safari-3-2-branch
Merge r35362.
- 10:27 AM Changeset in webkit [37378] by
-
- 2 edits in trunk/WebKitSite
2008-10-07 Darin Adler <Darin Adler>
- coding/RefPtr.html: Second draft.
- 9:30 AM Changeset in webkit [37377] by
-
- 2 edits in trunk/WebCore
2008-10-07 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Don't attempt to paint when updating control tints
We don't have a valid PlatformGraphicsContext so schedule
the dirty scrollbar/scrollview area for repaint instead.
- 4:20 AM Changeset in webkit [37376] by
-
- 2 edits in trunk/WebKit/qt
2008-10-07 Tor Arne Vestbø <tavestbo@trolltech.com>
QtWebKit build fix after changes to FrameLoaderClient.h in r37371
- 3:39 AM QtWebKitContrib edited by
- add irc nicks (diff)
- 3:36 AM QtWebKitJournal edited by
- (diff)
- 1:09 AM Changeset in webkit [37375] by
-
- 2 edits in trunk/WebKit/mac
2008-10-07 David Hyatt <hyatt@apple.com>
Make sure the parent visibility state is set up properly on the outermost ScrollView widget.
This fixes the repainting issues with viewless WebKit on Mac.
Reviewed by Sam Weinig
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage):
- 12:54 AM Changeset in webkit [37374] by
-
- 4 edits in trunk
[qt] Build fix after Scrollbar.h and Widget.h changes.
- 12:50 AM Changeset in webkit [37373] by
-
- 2 edits in trunk/WebKit/mac
2008-10-07 David Hyatt <hyatt@apple.com>
Make sure viewless Mac WebKit does a layout if needed before drawing.
Reviewed by Sam Weinig
- WebView/WebView.mm: (-[WebView viewWillDraw]):
- 12:47 AM Changeset in webkit [37372] by
-
- 3 edits in trunk/WebKit/mac
2008-10-07 David Hyatt <hyatt@apple.com>
Make sure observers get hooked up to watch for size changes in viewless WebKit mode.
Reviewed by Sam Weinig
- ChangeLog:
- WebView/WebFrame.mm: (-[WebFrame _drawRect:contentsOnly:]):
- WebView/WebView.mm: (-[WebView viewWillDraw]): (-[WebView _boundsChanged]): (-[WebView addSizeObservers]): (-[WebView viewDidMoveToWindow]): (-[WebView viewDidMoveToSuperview]):
Oct 6, 2008:
- 11:58 PM Changeset in webkit [37371] by
-
- 31 edits in trunk
WebCore:
2008-10-06 David Hyatt <hyatt@apple.com>
Enable viewless Mac WebKit to (kinda sorta) paint basic pages (with no frames on them).
Reviewed by Sam Weinig
- WebCore.base.exp:
- WebCore.xcodeproj/project.pbxproj:
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::hasWebView):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::transitionToCommitted):
- loader/FrameLoaderClient.h:
- page/FocusController.cpp: (WebCore::FocusController::setActive):
- page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::init): (WebCore::FrameView::layoutIfNeededRecursive):
- page/FrameView.h:
WebKit/gtk:
2008-10-06 David Hyatt <hyatt@apple.com>
Enable viewless Mac WebKit to paint some basic pages.
Reviewed by Sam Weinig
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
- WebCoreSupport/FrameLoaderClientGtk.h:
WebKit/mac:
2008-10-06 David Hyatt <hyatt@apple.com>
Enable viewless Mac WebKit to paint some basic pages.
Reviewed by Sam Weinig
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::windowResizerRect): (WebChromeClient::repaint): (WebChromeClient::screenToWindow): (WebChromeClient::windowToScreen): (WebChromeClient::platformWindow):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::forceLayoutForNonHTML): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::transitionToCommittedForNewPage): (WebFrameLoaderClient::createFrame):
- WebView/WebFrame.mm: (-[WebFrame _drawRect:contentsOnly:]):
- WebView/WebFrameInternal.h:
- WebView/WebFrameView.mm:
- WebView/WebFrameViewInternal.h:
- WebView/WebHTMLView.mm: (-[WebHTMLView drawSingleRect:]): (-[WebHTMLView drawRect:]):
- WebView/WebView.mm: (-[WebView isFlipped]): (-[WebView _boundsChanged]): (-[WebView _mustDrawUnionedRect:singleRects:count:]): (-[WebView drawSingleRect:]): (-[WebView drawRect:]): (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView initWithFrame:frameName:groupName:]): (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]): (-[WebView initWithCoder:]): (-[WebView removeSizeObservers]): (-[WebView viewWillMoveToWindow:]): (-[WebView viewWillMoveToSuperview:]): (-[WebView _usesDocumentViews]):
- WebView/WebViewInternal.h:
WebKit/qt:
2008-10-06 David Hyatt <hyatt@apple.com>
Enable viewless Mac WebKit to paint some basic pages.
Reviewed by Sam Weinig
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
WebKit/win:
2008-10-06 David Hyatt <hyatt@apple.com>
Enable viewless Mac WebKit to paint some basic pages.
Reviewed by Sam Weinig
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createFrame):
- WebCoreSupport/WebFrameLoaderClient.h:
WebKit/wx:
2008-10-06 David Hyatt <hyatt@apple.com>
Enable viewless Mac WebKit to paint some basic pages.
Reviewed by Sam Weinig
- WebKitSupport/FrameLoaderClientWx.cpp:
- WebKitSupport/FrameLoaderClientWx.h:
- 10:43 PM Changeset in webkit [37370] by
-
- 10 edits in trunk/JavaScriptCore
2008-10-06 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Fix for https://bugs.webkit.org/show_bug.cgi?id=21415
Improve the division between PropertyStorageArray and PropertyMap
- Rework ProperyMap to store offsets in the value so that they don't change when rehashing. This allows us not to have to keep the PropertyStorageArray in sync and thus not have to pass it in.
- Rename PropertyMap::getOffset -> PropertyMap::get since put/remove now also return offsets.
- A Vector of deleted offsets is now needed since the storage is out of band.
1% win on SunSpider. Wash on V8 suite.
- JavaScriptCore.exp:
- VM/CTI.cpp: (JSC::transitionWillNeedStorageRealloc):
- VM/Machine.cpp: (JSC::Machine::privateExecute): Transition logic can be greatly simplified by the fact that the storage capacity is always known, and is correct for the inline case.
- kjs/JSObject.cpp: (JSC::JSObject::put): Rename getOffset -> get. (JSC::JSObject::deleteProperty): Ditto. (JSC::JSObject::getPropertyAttributes): Ditto. (JSC::JSObject::removeDirect): Use returned offset to clear the value in the PropertyNameArray. (JSC::JSObject::allocatePropertyStorage): Add assert.
- kjs/JSObject.h: (JSC::JSObject::getDirect): Rename getOffset -> get (JSC::JSObject::getDirectLocation): Rename getOffset -> get (JSC::JSObject::putDirect): Use propertyStorageCapacity to determine whether or not to resize. Also, since put now returns an offset (and thus addPropertyTransition does also) setting of the PropertyStorageArray is now done here. (JSC::JSObject::transitionTo):
- kjs/PropertyMap.cpp: (JSC::PropertyMap::checkConsistency): PropertyStorageArray is no longer passed in. (JSC::PropertyMap::operator=): Copy the delete offsets vector. (JSC::PropertyMap::put): Instead of setting the PropertyNameArray explicitly, return the offset where the value should go. (JSC::PropertyMap::remove): Instead of removing from the PropertyNameArray explicitly, return the offset where the value should be removed. (JSC::PropertyMap::get): Switch to using the stored offset, instead of the implicit one. (JSC::PropertyMap::insert): (JSC::PropertyMap::expand): This is never called when m_table is null, so remove that branch and add it as an assertion. (JSC::PropertyMap::createTable): Consistency checks no longer take a PropertyNameArray. (JSC::PropertyMap::rehash): No need to rehash the PropertyNameArray now that it is completely out of band.
- kjs/PropertyMap.h: (JSC::PropertyMapEntry::PropertyMapEntry): Store offset into PropertyNameArray. (JSC::PropertyMap::get): Switch to using the stored offset, instead of the implicit one.
- kjs/StructureID.cpp: (JSC::StructureID::StructureID): Initialize the propertyStorageCapacity to JSObject::inlineStorageCapacity. (JSC::StructureID::growPropertyStorageCapacity): Grow the storage capacity as described below. (JSC::StructureID::addPropertyTransition): Copy the storage capacity. (JSC::StructureID::toDictionaryTransition): Ditto. (JSC::StructureID::changePrototypeTransition): Ditto. (JSC::StructureID::getterSetterTransition): Ditto.
- kjs/StructureID.h: (JSC::StructureID::propertyStorageCapacity): Add propertyStorageCapacity which is the current capacity for the JSObjects PropertyStorageArray. It starts at the JSObject::inlineStorageCapacity (currently 2), then when it first needs to be resized moves to the JSObject::nonInlineBaseStorageCapacity (currently 16), and after that doubles each time.
- 9:42 PM Changeset in webkit [37369] by
-
- 2 edits in trunk/WebCore
- build fix
- bindings/objc/DOMEvents.h:
- 9:16 PM Changeset in webkit [37368] by
-
- 4 edits3 adds in branches/Safari-3-2-branch
Merge r33567.
- 9:16 PM Changeset in webkit [37367] by
-
- 3 edits2 adds in branches/Safari-3-2-branch/WebCore
Merge r36108.
- 8:53 PM Changeset in webkit [37366] by
-
- 8 edits in trunk/JavaScriptCore
2008-10-06 Cameron Zwarich <zwarich@apple.com>
Reviewed by Oliver Hunt.
Bug 21396: Remove the OptionalCalleeActivation call frame slot
<https://bugs.webkit.org/show_bug.cgi?id=21396>
Remove the OptionalCalleeActivation call frame slot. We have to be
careful to store the activation object in a register, because objects
in the scope chain do not get marked.
This is a 0.3% speedup on both SunSpider and the V8 benchmark.
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): (JSC::CodeGenerator::emitReturn):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (JSC::Machine::dumpRegisters): (JSC::Machine::unwindCallFrame): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_push_activation): (JSC::Machine::cti_op_tear_off_activation): (JSC::Machine::cti_op_construct_JSConstruct):
- VM/Machine.h: (JSC::Machine::initializeCallFrame):
- VM/RegisterFile.h: (JSC::RegisterFile::):
- 7:15 PM Changeset in webkit [37365] by
-
- 2 edits in branches/Safari-3-2-branch/WebKit/mac/Misc
Merge _webkit_localCacheDirectoryWithBundleIdentifier:.
- 6:21 PM Changeset in webkit [37364] by
-
- 2 edits in trunk/JavaScriptCore
2008-10-06 Tony Chang <tony@chromium.org>
Reviewed by Alexey Proskuryakov.
Chromium doesn't use pthreads on windows, so make its use conditional.
Also convert a WORD to a DWORD to avoid a compiler warning. This
matches the other methods around it.
- wtf/ThreadingWin.cpp: (WTF::wtfThreadEntryPoint): (WTF::ThreadCondition::broadcast):
- 6:15 PM Changeset in webkit [37363] by
-
- 2 edits in trunk/JavaScriptCore
2008-10-06 Mark Mentovai <mark@moxienet.com>
Reviewed by Tim Hatcher.
Allow ENABLE_DASHBOARD_SUPPORT and ENABLE_MAC_JAVA_BRIDGE to be
disabled on the Mac.
- wtf/Platform.h:
- 6:14 PM Changeset in webkit [37362] by
-
- 6 edits in trunk/WebCore
2008-10-06 Mark Mentovai <mark@moxienet.com>
Reviewed by Tim Hatcher.
Use #if ENABLE(feature) where possible, and #if ENABLE_feature where
Platform.h is not available, in preference to #ifdef ENABLE_feature.
#ifdef is wrong now that features are disabled by #defining
ENABLE_feature to 0.
- bindings/objc/DOMEvents.h:
- bindings/objc/PublicDOMInterfaces.h:
- dom/Document.idl:
- page/DOMWindow.idl:
- svg/svgtags.in:
- 6:11 PM Changeset in webkit [37361] by
-
- 2 edits in trunk/WebCore
2008-10-06 Mark Mentovai <mark@moxienet.com>
Reviewed by Sam Weinig.
- platform/network/mac/FormDataStreamMac.mm: #import <wtf/Threading.h> to get the declaration for isMainThread().
- 6:10 PM Changeset in webkit [37360] by
-
- 2 edits in branches/Safari-3-2-branch/WebCore
Merge r36811.
- 6:10 PM Changeset in webkit [37359] by
-
- 7 edits2 adds in branches/Safari-3-2-branch
Merge r37008.
- 6:09 PM Changeset in webkit [37358] by
-
- 2 edits1 move in trunk/WebCore
2008-10-06 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Tim Hatcher.
WebCoreObjCExtras.c is actually an obj-c++ file, so change its name
to reflect that.
- WebCore.xcodeproj/project.pbxproj:
- platform/mac/WebCoreObjCExtras.c: Removed.
- platform/mac/WebCoreObjCExtras.mm: Copied from WebCore/platform/mac/WebCoreObjCExtras.c.
- 6:05 PM Changeset in webkit [37357] by
-
- 2 edits in trunk/WebCore
2008-10-06 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Dan Bernstein.
Added C++ forward declaration for the NSURLAuthenticationChallenge class
so that the m_currentMacChallenge variable doesn't cause a
compilation error when ResourceHandleInternal.h is included from a C++ file.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=21411
- platform/network/ResourceHandleInternal.h:
- 5:38 PM Changeset in webkit [37356] by
-
- 3 edits3 adds in branches/Safari-3-2-branch
Merge r36810.
- 5:38 PM Changeset in webkit [37355] by
-
- 4 edits3 adds in branches/Safari-3-2-branch
Merge r33972.
- 5:17 PM Changeset in webkit [37354] by
-
- 2 edits in trunk/WebCore
Windows build fix.
- 4:47 PM Changeset in webkit [37353] by
-
- 4 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=21416
Pass 0 for size to VirtualAlloc, as documented by MSDN.
Identified by Application Verifier.
Reviewed by Darin Adler.
- kjs/collector.cpp: (KJS::freeBlock):
WebCore:
https://bugs.webkit.org/show_bug.cgi?id=21416
Add missing null checks identified by Application Verifier.
Reviewed by Darin Adler.
- platform/win/SharedTimerWin.cpp: (WebCore::clearTimer):
- 4:15 PM Changeset in webkit [37352] by
-
- 2 edits in trunk/WebCore
2008-10-06 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim Hatcher.
Removed accidentally left in debugging statement.
- inspector/front-end/inspector.js:
- 4:10 PM Changeset in webkit [37351] by
-
- 1 edit in trunk/WebCore/ChangeLog
2008-10-06 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim Hatcher and Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=21412
Bug 21412: Refactor user initiated profile count to be more stable
- inspector/InspectorController.cpp: Keep track of the user-initiated profiles here now. (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling):
- inspector/InspectorController.h: The front end will now need to check for the existence of the user- initiated profile title and use its count instead of keeping its own.
- inspector/front-end/ProfilesPanel.js:
- 4:09 PM Changeset in webkit [37350] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
2008-10-06 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim Hatcheri and Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=21412
Bug 21412: Refactor user initiated profile count to be more stable
- Export UString::from for use with creating the profile title.
- JavaScriptCore.exp:
- 4:08 PM Changeset in webkit [37349] by
-
- 6 edits in trunk
2008-10-06 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=21412
Bug 21412: Refactor user initiated profile count to be more stable
- Export UString::from for use with creating the profile title.
- JavaScriptCore.exp:
WebCore:
2008-10-06 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=21412
Bug 21412: Refactor user initiated profile count to be more stable
- inspector/InspectorController.cpp: Keep track of the user-initiated profiles here now. (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling):
- inspector/InspectorController.h: The front end will now need to check for the existence of the user- initiated profile title and use its count instead of keeping its own.
- inspector/front-end/ProfilesPanel.js:
- 3:41 PM Changeset in webkit [37348] by
-
- 5 edits in trunk/WebKit/mac
Rubber-stamped by Anders Carlsson.
Rename _webkit_applicationCacheDirectoryWithBundleIdentifier to _webkit_localCacheDirectoryWithBundleIdentifier.
- Misc/WebKitNSStringExtras.h:
- Misc/WebKitNSStringExtras.m: (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
- WebView/WebDataSource.mm: (-[WebDataSource _transferApplicationCache:]):
- WebView/WebView.mm: (WebKitInitializeApplicationCachePathIfNecessary):
- 3:22 PM Changeset in webkit [37347] by
-
- 3 edits in trunk/WebKit/mac
2008-10-06 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Make WebNetscapePluginStream a WebCore::NetscapePlugInStreamLoaderClient.
- Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::~WebNetscapePluginStream):
- Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::didReceiveResponse): (-[WebBaseNetscapePluginStream startStreamWithResponse:]): (WebNetscapePluginStream::wantsAllStreams): (-[WebBaseNetscapePluginStream wantsAllStreams]): (WebNetscapePluginStream::didFail): (-[WebBaseNetscapePluginStream destroyStreamWithError:]): (WebNetscapePluginStream::didFinishLoading): (-[WebBaseNetscapePluginStream finishedLoading]): (WebNetscapePluginStream::didReceiveData): (-[WebBaseNetscapePluginStream receivedData:]):
- 2:56 PM Changeset in webkit [37346] by
-
- 3 edits in trunk/WebKit/mac
2008-10-06 Anders Carlsson <andersca@apple.com>
Bring back the stop method. It was called through performSelector, which
is why I couldn't find any references to it.
- Plugins/WebBaseNetscapePluginStream.h:
- Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream stop]):
- 2:28 PM Changeset in webkit [37345] by
-
- 4 edits in trunk/WebKit/mac
2008-10-06 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
More conversion and cleanup.
- Plugins/WebBaseNetscapePluginStream.h:
- Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::startStream): (-[WebBaseNetscapePluginStream startStreamWithResponse:]):
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
- 2:05 PM Changeset in webkit [37344] by
-
- 3 edits in trunk/WebKit/mac
2008-10-06 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Fold initWithRequestURL into initWithRequest.
- Plugins/WebBaseNetscapePluginStream.h:
- Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
- 1:57 PM Changeset in webkit [37343] by
-
- 3 edits in trunk/WebKit/mac
2008-10-06 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Change the init methods not to return nil on failures. (These failures never occur anyway)
Use initWithRequest as the initializer, initWithRequestURL is going to be merged with it.
- Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]):
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
- 1:34 PM Changeset in webkit [37342] by
-
- 4 edits in trunk/WebKit/mac
2008-10-06 Anders Carlsson <andersca@apple.com>
Reviewed by David Hyatt.
Convert more methods over to C++.
- Plugins/WebBaseNetscapePluginStream.h:
- Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::ownerForStream): (WebNetscapePluginStream::pluginCancelledConnectionError): (WebNetscapePluginStream::errorForReason): (-[WebBaseNetscapePluginStream errorForReason:]): (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): (WebNetscapePluginStream::cancelLoadAndDestroyStreamWithError): (-[WebBaseNetscapePluginStream cancelLoadAndDestroyStreamWithError:]): (WebNetscapePluginStream::deliverData): (WebNetscapePluginStream::deliverDataTimerFired): (WebNetscapePluginStream::deliverDataToFile): (-[WebBaseNetscapePluginStream finishedLoading]): (-[WebBaseNetscapePluginStream receivedData:]):
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView destroyStream:reason:]):
- 1:25 PM Changeset in webkit [37341] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig.
- separate GDI text drawing into its own function
- platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs): (WebCore::Font::drawGlyphs):
- 1:13 PM Changeset in webkit [37340] by
-
- 3 edits in trunk/WebKit/mac
2008-10-06 David Hyatt <hyatt@apple.com>
Add SPI for a new viewless WebKit mode. The idea is that when this flag is set there will be no
views created except for the outermost WebView.
Reviewed by Tim Hatcher
- WebView/WebView.mm:
- WebView/WebViewInternal.h:
- 1:02 PM Changeset in webkit [37339] by
-
- 4 edits in trunk/WebKit/mac
2008-10-06 Anders Carlsson <andersca@apple.com>
Reviewed by David Hyatt.
Convert more methods over to C++.
- Plugins/WebBaseNetscapePluginStream.h:
- Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::reasonForError): (WebNetscapePluginStream::destroyStreamWithReason): (WebNetscapePluginStream::cancelLoadWithError): (-[WebBaseNetscapePluginStream cancelLoadWithError:]): (WebNetscapePluginStream::destroyStreamWithError): (-[WebBaseNetscapePluginStream destroyStreamWithError:]): (-[WebBaseNetscapePluginStream cancelLoadAndDestroyStreamWithError:]): (-[WebBaseNetscapePluginStream _deliverDataToFile:]): (-[WebBaseNetscapePluginStream finishedLoading]):
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithError:]):
- 12:55 PM Changeset in webkit [37338] by
-
- 3 edits in trunk/WebCore
<rdar://problem/6249833> Fix default button appearance
Reviewed by Adele Peterson.
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::supportsFocus): (WebCore::RenderThemeWin::determineClassicState): (WebCore::RenderThemeWin::determineButtonState): (WebCore::RenderThemeWin::getClassicThemeData): (WebCore::RenderThemeWin::getThemeData): (WebCore::drawControl):
- rendering/RenderThemeWin.h:
- 11:31 AM Changeset in webkit [37337] by
-
- 21 edits in trunk
2008-10-06 Maciej Stachowiak <mjs@apple.com>
Not reviewed. Build fix.
- API/JSValueRef.cpp: (JSValueToBoolean):
- ChangeLog:
- JavaScriptCore.exp:
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
- VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_loop_if_true): (JSC::Machine::cti_op_not): (JSC::Machine::cti_op_jtrue):
- kjs/ArrayPrototype.cpp: (JSC::arrayProtoFuncFilter): (JSC::arrayProtoFuncEvery): (JSC::arrayProtoFuncSome):
- kjs/BooleanConstructor.cpp: (JSC::constructBoolean): (JSC::callBooleanConstructor):
- kjs/GetterSetter.h:
- kjs/JSCell.h: (JSC::JSValue::toBoolean):
- kjs/JSNumberCell.cpp: (JSC::JSNumberCell::toBoolean):
- kjs/JSNumberCell.h:
- kjs/JSObject.cpp: (JSC::JSObject::toBoolean):
- kjs/JSObject.h:
- kjs/JSString.cpp: (JSC::JSString::toBoolean):
- kjs/JSString.h:
- kjs/JSValue.h:
- kjs/RegExpConstructor.cpp: (JSC::setRegExpConstructorMultiline):
- kjs/RegExpObject.cpp: (JSC::RegExpObject::match):
- kjs/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString):
JavaScriptGlue:
2008-10-06 Maciej Stachowiak <mjs@apple.com>
Not reviewed. Build fix.
- JSUtils.cpp: (KJSValueToCFTypeInternal):
- 11:19 AM Changeset in webkit [37336] by
-
- 2 edits in trunk/JavaScriptGlue
2008-10-06 Maciej Stachowiak <mjs@apple.com>
Not reviewed.
- fix build; toBoolean no longer takes an ExecState
- JSUtils.cpp: (KJSValueToCFTypeInternal):
- 11:11 AM Changeset in webkit [37335] by
-
- 7 edits in trunk/WebCore
2008-10-06 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Add native virtual keycode to PlatformKeyboardEvent
- 10:51 AM Changeset in webkit [37334] by
-
- 5 edits in trunk/WebCore
2008-10-06 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Enable WebCore::String <> CFStringRef conversion functions for QtWebKit/Mac
- 10:50 AM Changeset in webkit [37333] by
-
- 19 edits in trunk/JavaScriptCore
2008-10-06 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
- optimize op_jtrue, op_loop_if_true and op_not in various ways https://bugs.webkit.org/show_bug.cgi?id=21404
1) Make JSValue::toBoolean nonvirtual and completely inline by
making use of the StructureID type field.
2) Make JSValue::toBoolean not take an ExecState; doesn't need it.
3) Make op_not, op_loop_if_true and op_jtrue not read the
ExecState (toBoolean doesn't need it any more) and not check
exceptions (toBoolean can't throw).
- API/JSValueRef.cpp: (JSValueToBoolean):
- JavaScriptCore.exp:
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
- VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_loop_if_true): (JSC::Machine::cti_op_not): (JSC::Machine::cti_op_jtrue):
- kjs/ArrayPrototype.cpp: (JSC::arrayProtoFuncFilter): (JSC::arrayProtoFuncEvery): (JSC::arrayProtoFuncSome):
- kjs/BooleanConstructor.cpp: (JSC::constructBoolean): (JSC::callBooleanConstructor):
- kjs/GetterSetter.h:
- kjs/JSCell.h: (JSC::JSValue::toBoolean):
- kjs/JSNumberCell.cpp:
- kjs/JSNumberCell.h: (JSC::JSNumberCell::toBoolean):
- kjs/JSObject.cpp:
- kjs/JSObject.h: (JSC::JSObject::toBoolean): (JSC::JSCell::toBoolean):
- kjs/JSString.cpp:
- kjs/JSString.h: (JSC::JSString::toBoolean):
- kjs/JSValue.h:
- kjs/RegExpConstructor.cpp: (JSC::setRegExpConstructorMultiline):
- kjs/RegExpObject.cpp: (JSC::RegExpObject::match):
- kjs/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString):
- 10:46 AM Changeset in webkit [37332] by
-
- 3 edits in trunk/WebCore
2008-10-06 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Use bundles on QtWebKit/Mac for platform modules
- 10:00 AM Changeset in webkit [37331] by
-
- 6 edits in trunk
2008-10-06 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Build fix for MinGW.
- platform/win/SystemTimeWin.cpp:
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::invalidateRect):
2008-10-06 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Build fix for MinGW.
- JavaScriptCore.pri:
- kjs/DateMath.cpp: (JSC::highResUpTime):
- 8:44 AM Changeset in webkit [37330] by
-
- 2 edits in trunk/WebCore
Mimic the inspector/ directory structure in WebCore.vcproj
- WebCore.vcproj/WebCore.vcproj:
- 8:39 AM Changeset in webkit [37329] by
-
- 2 edits in trunk/WebCore
Windows build fix
- WebCore.vcproj/WebCore.vcproj: Update the Include path for all configurations to include WebCore/inspector.
- 1:23 AM Changeset in webkit [37328] by
-
- 938 edits in trunk
Reviewed by Darin Adler.
SVG should support ascent and descent properties <font-face> instead of <font>!
https://bugs.webkit.org/show_bug.cgi?id=21365
Tested by many many existing SVG tests.
- svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::ascent): (WebCore::SVGFontFaceElement::descent):
Oct 5, 2008:
- 11:44 PM Changeset in webkit [37327] by
-
- 2 edits in trunk/WebCore
2008-10-05 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
REGRESSION: crash in ScriptElement::notifyFinished
Fixes https://bugs.webkit.org/show_bug.cgi?id=21329
- dom/ScriptElement.cpp: (WebCore::ScriptElementData::notifyFinished): Revert part of r35744 to ensure that the ScriptElementData object is not destroyed prematurely.
- 11:33 PM Changeset in webkit [37326] by
-
- 2 edits in trunk/JavaScriptCore
2008-10-05 Cameron Zwarich <zwarich@apple.com>
Reviewed by Oliver Hunt.
Remove ScopeNode::containsClosures() now that it is unused.
- kjs/nodes.h: (JSC::ScopeNode::containsClosures):
- 11:05 PM Changeset in webkit [37325] by
-
- 3 edits in trunk/JavaScriptCore
2008-10-05 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- fix releas-only test failures caused by the fix to bug 21375
- VM/Machine.cpp: (JSC::Machine::unwindCallFrame): Update ExecState while unwinding call frames; it now matters more to have a still-valid ExecState, since dynamicGlobalObject will make use of the ExecState's scope chain.
- VM/Machine.h:
- 11:00 PM Changeset in webkit [37324] by
-
- 15 edits in trunk
2008-10-05 Cameron Zwarich <zwarich@apple.com>
Reviewed by Oliver Hunt.
Bug 21364: Remove the branch in op_ret for OptionalCalleeActivation and OptionalCalleeArguments
<https://bugs.webkit.org/show_bug.cgi?id=21364>
Use information from the parser to detect whether an activation is
needed or 'arguments' is used, and emit explicit instructions to tear
them off before op_ret. This allows a branch to be removed from op_ret
and simplifies some other code. This does cause a small change in the
behaviour of 'f.arguments'; it is no longer live when 'arguments' is not
mentioned in the lexical scope of the function.
It should now be easy to remove the OptionaCalleeActivation slot in the
call frame, but this will be done in a later patch.
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitReturn):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (JSC::Machine::unwindCallFrame): (JSC::Machine::privateExecute): (JSC::Machine::retrieveArguments): (JSC::Machine::cti_op_create_arguments): (JSC::Machine::cti_op_tear_off_activation): (JSC::Machine::cti_op_tear_off_arguments):
- VM/Machine.h:
- VM/Opcode.h:
- kjs/Arguments.cpp: (JSC::Arguments::mark):
- kjs/Arguments.h: (JSC::Arguments::isTornOff): (JSC::Arguments::Arguments): (JSC::Arguments::copyRegisters): (JSC::JSActivation::copyRegisters):
- kjs/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
- kjs/JSActivation.h:
LayoutTests:
- fast/js/function-dot-arguments-expected.txt:
- fast/js/resources/function-dot-arguments.js:
- 7:48 PM Changeset in webkit [37323] by
-
- 8 edits in trunk/JavaScriptCore
2008-10-05 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
- fixed "REGRESSION (r37297): fast/js/deep-recursion-test takes too long and times out" https://bugs.webkit.org/show_bug.cgi?id=21375
The problem is that dynamicGlobalObject had become O(N) in number
of call frames, but unwinding the stack for an exception called it
for every call frame, resulting in O(N2) behavior for an
exception thrown from inside deep recursion.
Instead of doing it that way, stash the dynamic global object in JSGlobalData.
- JavaScriptCore.exp:
- VM/Machine.cpp: (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Helper class to temporarily store and later restore a dynamicGlobalObject in JSGlobalData. (JSC::DynamicGlobalObjectScope::~DynamicGlobalObjectScope): (JSC::Machine::execute): In each version, establish a DynamicGlobalObjectScope. For ProgramNode, always establish set new dynamicGlobalObject, for FunctionBody and Eval, only if none is currently set.
- VM/Machine.h:
- kjs/ExecState.h:
- kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): Ininitalize new dynamicGlobalObject field to 0.
- kjs/JSGlobalData.h:
- kjs/JSGlobalObject.h: (JSC::ExecState::dynamicGlobalObject): Moved here from ExecState for benefit of inlining. Return lexical global object if this is a globalExec(), otherwise look in JSGlobalData for the one stashed there.
- 6:43 PM Changeset in webkit [37322] by
-
- 3 edits in trunk/WebCore
2008-10-05 Chris Lord <chris@openedhand.com>
Reviewed by Alp Toker. Landed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=20624
WebKit-gtk uses deprecated GtkType/GtkObject
- plugins/gtk/gtk2xtbin.c: (gtk_xtbin_get_type):
- plugins/gtk/gtk2xtbin.h:
- 5:58 PM Changeset in webkit [37321] by
-
- 5 edits in trunk/JavaScriptCore
2008-10-05 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Avoid an extra lookup when transitioning to an existing StructureID
by caching the offset of property that caused the transition.
1% win on V8 suite. Wash on SunSpider.
- kjs/PropertyMap.cpp: (JSC::PropertyMap::put):
- kjs/PropertyMap.h:
- kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::addPropertyTransition):
- kjs/StructureID.h: (JSC::StructureID::setCachedTransistionOffset): (JSC::StructureID::cachedTransistionOffset):
- 3:47 PM Changeset in webkit [37320] by
-
- 4 edits in trunk/JavaScriptCore
2008-10-05 Cameron Zwarich <zwarich@apple.com>
Reviewed by Maciej Stachowiak.
Bug 21364: Remove the branch in op_ret for OptionalCalleeActivation and OptionalCalleeArguments
<https://bugs.webkit.org/show_bug.cgi?id=21364>
This patch does not yet remove the branch, but it does a bit of refactoring
so that a CodeGenerator now knows whether the associated CodeBlock will need
a full scope before doing any code generation. This makes it possible to emit
explicit tear-off instructions before every op_ret.
- VM/CodeBlock.h: (JSC::CodeBlock::CodeBlock):
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::generate): (JSC::CodeGenerator::CodeGenerator): (JSC::CodeGenerator::emitPushScope): (JSC::CodeGenerator::emitPushNewScope):
- kjs/nodes.h: (JSC::ScopeNode::needsActivation):
- 2:57 PM Changeset in webkit [37319] by
-
- 2 edits in trunk/WebCore
2008-10-05 Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Reviewed by David Hyatt.
GTK_WINDOW_HWND not GTK_WINDOWING_HWND
https://bugs.webkit.org/show_bug.cgi?id=20725
Updated to ToT by Jan Alonzo.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::getValue):
- 2:50 PM Changeset in webkit [37318] by
-
- 2 edits in trunk/WebCore
2008-10-05 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Darin Adler.
Invalid cast from GdkWindow to GtkWidget
https://bugs.webkit.org/show_bug.cgi?id=21391
Fix a misplaced closing parenthesis to actually cast the widget, not the window
- platform/gtk/PlatformScreenGtk.cpp: (WebCore::screenDepth):
- 12:12 PM Changeset in webkit [37317] by
-
- 11 edits30 adds in trunk
WebCore:
2008-10-04 Adam Barth <abarth@webkit.org>
Reviewed by Darin Alder.
Attach the Origin header to POST requests to help defend against
cross-site request forgery.
Collin Jackson <collinj@webkit.org> also contributed to this patch.
Tests: http/tests/security/originHeader/origin-header-for-data.html
http/tests/security/originHeader/origin-header-for-empty.html
http/tests/security/originHeader/origin-header-for-get.html
http/tests/security/originHeader/origin-header-for-https.html
http/tests/security/originHeader/origin-header-for-post.html
- bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::outgoingOrigin): (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::loadPostRequest): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::loadItem):
- loader/FrameLoader.h:
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
- loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests):
- platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::toHTTPOrigin):
- platform/SecurityOrigin.h:
- platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::httpOrigin): (WebCore::ResourceRequestBase::setHTTPOrigin): (WebCore::ResourceRequestBase::clearHTTPOrigin):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest): (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight): (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult): (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
LayoutTests:
2008-10-04 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Tests for the new Origin header.
Collin Jackson <collinj@webkit.org> also contributed to this patch.
- http/tests/security/originHeader: Added.
- http/tests/security/originHeader/origin-header-for-data-expected.txt: Added.
- http/tests/security/originHeader/origin-header-for-data.html: Added.
- http/tests/security/originHeader/origin-header-for-empty-expected.txt: Added.
- http/tests/security/originHeader/origin-header-for-empty.html: Added.
- http/tests/security/originHeader/origin-header-for-get-expected.txt: Added.
- http/tests/security/originHeader/origin-header-for-get.html: Added.
- http/tests/security/originHeader/origin-header-for-https-expected.txt: Added.
- http/tests/security/originHeader/origin-header-for-https.html: Added.
- http/tests/security/originHeader/origin-header-for-post-expected.txt: Added.
- http/tests/security/originHeader/origin-header-for-post.html: Added.
- http/tests/security/originHeader/origin-header-for-xmlhttprequest-expected.txt: Added.
- http/tests/security/originHeader/origin-header-for-xmlhttprequest.html: Added.
- http/tests/security/originHeader/resources: Added.
- http/tests/security/originHeader/resources/origin-header-post-to-http.html: Added.
- http/tests/security/originHeader/resources/print-origin.cgi: Added.
- 10:38 AM Changeset in webkit [37316] by
-
- 4 edits in trunk/JavaScriptCore
2008-10-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Cameron Zwarich.
Fix for bug #21387 - using SamplingTool with CTI.
(1) A repatch offset offset changes due to an additional instruction to update SamplingTool state.
(2) Fix an incusion order problem due to ExecState changes.
(3) Change to a MACHINE_SAMPLING macro, use of exec should now be accessing global data.
- VM/CTI.h: (JSC::CTI::execute):
- VM/SamplingTool.h: (JSC::SamplingTool::privateExecuteReturned):
- kjs/Shell.cpp:
- 1:28 AM Changeset in webkit [37315] by
-
- 3 edits2 adds in trunk
Bug 21381: Incremental parsing of html causes bogus line numbers in some cases
<https://bugs.webkit.org/show_bug.cgi?id=21381>
Reviewed by Tim Hatcher.
If we hit a parsing boundary (end of a packet, etc) in the middle of a
<script> element when we are doing an incremental parse, we exit the
parser, and reenter later when more data is available. During this
reentry we incorrectly reset the scriptStartLineno to the current line
in the parser, which is now part way through the script element.
The solution is to track whether we are entering or reentering the parsing
of a script element. We do this simply by 0 checking scriptStartLineno,
and resetting it after we complete parsing of each script element.
Test: http/tests/incremental/pause-in-script-element.pl
Oct 4, 2008:
- 11:13 PM Changeset in webkit [37314] by
-
- 2 edits in trunk/WebCore
2008-10-04 Alp Toker <alp@nuanti.com>
Reviewed by David Hyatt. Landed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=20924
[Gtk] Linux/Gtk: Recent tree revisions fail Acid2 and Acid3
https://bugs.webkit.org/show_bug.cgi?id=19578
[CURL] problem in parseDataUrl
De-obfuscate parseDataUrl() and fix regressions introduced in r35954.
This patch also fixes encoding support in escaped (non-Base64) data
URLs. All manual data URL tests now pass in both GLib and non-GLib
code paths.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl):
- 9:12 PM Changeset in webkit [37313] by
-
- 5 edits1 add in trunk/WebCore
Makes breakpoints and debugging code during page load work in the
Web Inspector's debugger. Specifically, this makes the source
code for loading resources show up in the Scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=19053
rdar://problem/5933408
Reviewed by Mark Rowe.
- WebCore.xcodeproj/project.pbxproj: Mark the inspector group as not using tabs and a tab width of 8.
- inspector/InspectorController.cpp: (WebCore::addResourceSourceToFrame): Return a bool to report if the source was added successfully or not. (WebCore::addSourceToFrame): Ditto.
- inspector/front-end/ScriptView.js: (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded): Return early if the InspectorController.addSourceToFrame fails. Moved the delete of the _frameNeedsSetup property after that call so if the source wasn't added it will be attempted again.
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.detach): Move a comment. (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded): Don't check if the resource is finished or failed, just attempt to add the source to the frame. WebCore has the source, but the finished property hasn't been set yet. Return early if the InspectorController.addSourceToFrame fails. Moved the delete of the _frameNeedsSetup property after that call so if the source wasn't added it will be attempted again. (WebInspector.SourceView.prototype._resourceLoadingFinished): Clear the _frameNeedsSetup and _sourceFrameSetup properties so the source frame will we populated again now that the resource load has finished.
- manual-tests/inspector/debugger-pause-during-load.html: Added.
- 8:04 PM Changeset in webkit [37312] by
-
- 8 edits in trunk
Add a 'Check For Weak VTables' build phase to catch weak vtables as early as possible.
Reviewed by Tim Hatcher.
- 8:04 PM Changeset in webkit [37311] by
-
- 2 edits in trunk/WebKitTools
Update check-for-weak-vtables to check only the final linked image for weak vtables.
This gives more useful results than checking each object file independently.
Reviewed by Tim Hatcher.
- 7:55 PM Changeset in webkit [37310] by
-
- 1 edit in trunk/WebCore/platform/qt/WidgetQt.cpp
Fix Qt build bustage.
- 7:21 PM Changeset in webkit [37309] by
-
- 12 edits in trunk/WebKitSite
Upgrade to WordPress 2.6.2.
- blog:
- 6:38 PM Changeset in webkit [37308] by
-
- 4 edits in branches/Safari-3-2-branch
Update format of CFBundleShortVersionString for <rdar://problem/6269394>.
- 6:04 PM Changeset in webkit [37307] by
-
- 1 edit in trunk/WebCore/platform/ScrollView.h
Fix build bustage I just introduced.
- 5:55 PM Changeset in webkit [37306] by
-
- 3 edits in trunk/WebCore
2008-10-04 David Hyatt <hyatt@apple.com>
Tear down scrollbars in FrameView rather than ScrollView so that the connection to the hostWindow()
is still present.
Reviewed by Mark Rowe
- page/FrameView.cpp: (WebCore::FrameView::~FrameView):
- 5:22 PM Changeset in webkit [37305] by
-
- 4 edits in branches/Safari-3-2-branch
Versioning.
- 5:21 PM Changeset in webkit [37304] by
-
- 12 edits in branches/Safari-3-2-branch
Merge r35278.
- 4:33 PM Changeset in webkit [37303] by
-
- 1 edit in trunk/WebCore/platform/qt/QWebPopup.cpp
Fix Qt bustage.
- 4:15 PM Changeset in webkit [37302] by
-
- 1 edit in trunk/WebCore/platform/qt/QWebPopup.cpp
Fix Qt bustage.
- 3:52 PM Changeset in webkit [37301] by
-
- 8 edits in trunk/WebCore
2008-10-04 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Avoid copying a Vector when using getSupportedKeySizes.
- html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::HTMLKeygenElement):
- platform/SSLKeyGenerator.h:
- platform/gtk/TemporaryLinkStubs.cpp: (WebCore::getSupportedKeySizes):
- platform/mac/SSLKeyGeneratorMac.mm: (WebCore::getSupportedKeySizes):
- platform/qt/TemporaryLinkStubs.cpp: (WebCore::getSupportedKeySizes):
- platform/win/TemporaryLinkStubs.cpp: (WebCore::getSupportedKeySizes):
- platform/wx/TemporaryLinkStubs.cpp: (WebCore::getSupportedKeySizes):
- 2:57 PM Changeset in webkit [37300] by
-
- 3 edits in trunk/JavaScriptCore
2008-10-04 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Fix https://bugs.webkit.org/show_bug.cgi?id=21320
leaks of PropertyNameArrayData seen on buildbot
- Fix RefPtr cycle by making PropertyNameArrayData's pointer back to the StructureID a weak pointer.
- kjs/PropertyNameArray.h: (JSC::PropertyNameArrayData::setCachedStructureID): (JSC::PropertyNameArrayData::cachedStructureID):
- kjs/StructureID.cpp: (JSC::StructureID::getEnumerablePropertyNames): (JSC::StructureID::clearEnumerationCache): (JSC::StructureID::~StructureID):
- 2:56 PM Changeset in webkit [37299] by
-
- 1 edit in trunk/WebCore/WebCore.pro
Speculative fix for Qt bustage from inspector directory move.
- 2:53 PM Changeset in webkit [37298] by
-
- 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj
Fix build bustage from the inspector directory move on Windows.
- 2:12 PM Changeset in webkit [37297] by
-
- 24 edits in trunk
2008-10-04 Darin Adler <Darin Adler>
Reviewed by Cameron Zwarich.
- https://bugs.webkit.org/show_bug.cgi?id=21295 Bug 21295: Replace ExecState with a call frame Register pointer
10% faster on Richards; other v8 benchmarks faster too.
A wash on SunSpider.
This does the minimum necessary to get the speedup. Next step in
cleaning this up is to replace ExecState with a CallFrame class,
and be more judicious about when to pass a call frame and when
to pass a global data pointer, global object pointer, or perhaps
something else entirely.
- VM/CTI.cpp: Remove the debug-only check of the exception in ctiVMThrowTrampoline -- already checked in the code the trampoline jumps to, so not all that useful. Removed the exec argument from ctiTrampoline. Removed emitDebugExceptionCheck -- no longer needed. (JSC::CTI::emitCall): Removed code to set ExecState::m_callFrame. (JSC::CTI::privateCompileMainPass): Removed code in catch to extract the exception from ExecState::m_exception; instead, the code that jumps into catch will make sure the exception is already in eax.
- VM/CTI.h: Removed exec from the ctiTrampoline. Also removed the non-helpful "volatile". Temporarily left ARG_exec in as a synonym for ARG_r; I'll change that on a future cleanup pass when introducing more use of the CallFrame type. (JSC::CTI::execute): Removed the ExecState* argument.
- VM/ExceptionHelpers.cpp: (JSC::InterruptedExecutionError::InterruptedExecutionError): Take JSGlobalData* instead of ExecState*. (JSC::createInterruptedExecutionException): Ditto.
- VM/ExceptionHelpers.h: Ditto. Also removed an unneeded include.
- VM/Machine.cpp: (JSC::slideRegisterWindowForCall): Removed the exec and exceptionValue arguments. Changed to return 0 when there's a stack overflow rather than using a separate exception argument to cut down on memory accesses in the calling convention. (JSC::Machine::unwindCallFrame): Removed the exec argument when constructing a DebuggerCallFrame. Also removed code to set ExecState::m_callFrame. (JSC::Machine::throwException): Removed the exec argument when construction a DebuggerCallFrame. (JSC::Machine::execute): Updated to use the register instead of ExecState and also removed various uses of ExecState. (JSC::Machine::debug): (JSC::Machine::privateExecute): Put globalData into a local variable so it can be used throughout the interpreter. Changed the VM_CHECK_EXCEPTION to get the exception in globalData instead of through ExecState. (JSC::Machine::retrieveLastCaller): Turn exec into a registers pointer by calling registers() instead of by getting m_callFrame. (JSC::Machine::callFrame): Ditto. Tweaked exception macros. Made new versions for when you know you have an exception. Get at global exception with ARG_globalData. Got rid of the need to pass in the return value type. (JSC::Machine::cti_op_add): Update to use new version of exception macros. (JSC::Machine::cti_op_pre_inc): Ditto. (JSC::Machine::cti_timeout_check): Ditto. (JSC::Machine::cti_op_instanceof): Ditto. (JSC::Machine::cti_op_new_func): Ditto. (JSC::Machine::cti_op_call_JSFunction): Optimized by using the ARG values directly instead of through local variables -- this gets rid of code that just shuffles things around in the stack frame. Also get rid of ExecState and update for the new way exceptions are handled in slideRegisterWindowForCall. (JSC::Machine::cti_vm_compile): Update to make exec out of r since they are both the same thing now. (JSC::Machine::cti_op_call_NotJSFunction): Ditto. (JSC::Machine::cti_op_init_arguments): Ditto. (JSC::Machine::cti_op_resolve): Ditto. (JSC::Machine::cti_op_construct_JSConstruct): Ditto. (JSC::Machine::cti_op_construct_NotJSConstruct): Ditto. (JSC::Machine::cti_op_resolve_func): Ditto. (JSC::Machine::cti_op_put_by_val): Ditto. (JSC::Machine::cti_op_put_by_val_array): Ditto. (JSC::Machine::cti_op_resolve_skip): Ditto. (JSC::Machine::cti_op_resolve_global): Ditto. (JSC::Machine::cti_op_post_inc): Ditto. (JSC::Machine::cti_op_resolve_with_base): Ditto. (JSC::Machine::cti_op_post_dec): Ditto. (JSC::Machine::cti_op_call_eval): Ditto. (JSC::Machine::cti_op_throw): Ditto. Also rearranged to return the exception value as the return value so it can be used by op_catch. (JSC::Machine::cti_op_push_scope): Ditto. (JSC::Machine::cti_op_in): Ditto. (JSC::Machine::cti_op_del_by_val): Ditto. (JSC::Machine::cti_vm_throw): Ditto. Also rearranged to return the exception value as the return value so it can be used by op_catch.
- kjs/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::functionName): Pass globalData. (JSC::DebuggerCallFrame::evaluate): Eliminated code to make a new ExecState.
- kjs/DebuggerCallFrame.h: Removed ExecState argument from constructor.
- kjs/ExecState.h: Eliminated all data members and made ExecState inherit privately from Register instead. Also added a typedef to the future name for this class, which is CallFrame. It's just a Register* that knows it's a pointer at a call frame. The new class can't be constructed or copied. Changed all functions to use the this pointer instead of m_callFrame. Changed exception-related functions to access an exception in JSGlobalData. Removed functions used by CTI to pass the return address to the throw machinery -- this is now done directly with a global in the global data.
- kjs/FunctionPrototype.cpp: (JSC::functionProtoFuncToString): Pass globalData instead of exec.
- kjs/InternalFunction.cpp: (JSC::InternalFunction::name): Take globalData instead of exec.
- kjs/InternalFunction.h: Ditto.
- kjs/JSGlobalData.cpp: Initialize the new exception global to 0.
- kjs/JSGlobalData.h: Declare two new globals. One for the current exception and another for the return address used by CTI to implement the throw operation.
- kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): Removed code to set up globalExec, which is now the same thing as globalCallFrame. (JSC::JSGlobalObject::reset): Get globalExec from our globalExec function so we don't have to repeat the logic twice. (JSC::JSGlobalObject::mark): Removed code to mark the exception; the exception is now stored in JSGlobalData and marked there. (JSC::JSGlobalObject::globalExec): Return a pointer to the end of the global call frame.
- kjs/JSGlobalObject.h: Removed the globalExec data member.
- kjs/JSObject.cpp: (JSC::JSObject::putDirectFunction): Pass globalData instead of exec.
- kjs/collector.cpp: (JSC::Heap::collect): Mark the global exception.
- profiler/ProfileGenerator.cpp: (JSC::ProfileGenerator::addParentForConsoleStart): Pass globalData instead of exec to createCallIdentifier.
- profiler/Profiler.cpp: (JSC::Profiler::willExecute): Pass globalData instead of exec to createCallIdentifier. (JSC::Profiler::didExecute): Ditto. (JSC::Profiler::createCallIdentifier): Take globalData instead of exec. (JSC::createCallIdentifierFromFunctionImp): Ditto.
- profiler/Profiler.h: Change interface to take a JSGlobalData instead of an ExecState.
WebKit/mac:
2008-10-04 Darin Adler <Darin Adler>
Reviewed by Cameron Zwarich.
- https://bugs.webkit.org/show_bug.cgi?id=21295 Bug 21295: Replace ExecState with a call frame Register pointer
- WebView/WebScriptDebugger.mm: (WebScriptDebugger::WebScriptDebugger): Remove 0 passed for ExecState.
- 2:10 PM Changeset in webkit [37296] by
-
- 3 edits in trunk/WebCore
2008-10-04 Darin Adler <Darin Adler>
Reviewed by Cameron Zwarich.
- prepare for https://bugs.webkit.org/show_bug.cgi?id=21295 Bug 21295: Replace ExecState with a call frame Register pointer
- bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom): Remove bogus "const".
- bindings/js/JSQuarantinedObjectWrapper.h: Ditto.
- 2:03 PM Changeset in webkit [37295] by
-
- 12 edits1 add in trunk/WebCore
2008-10-04 David Hyatt <hyatt@apple.com>
Make PopupMenuClient obey the platform abstraction. Remove any connection to Document and RenderStyle.
Reviewed by Darin Adler
- WebCore.xcodeproj/project.pbxproj:
- platform/PopupMenuClient.h:
- platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::show):
- platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show):
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::populate):
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize): (WebCore::PopupMenu::paint): (WebCore::PopupWndProc):
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::itemStyle): (WebCore::RenderMenuList::menuStyle): (WebCore::RenderMenuList::hostWindow):
- rendering/RenderMenuList.h:
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::itemStyle): (WebCore::RenderTextControl::menuStyle): (WebCore::RenderTextControl::hostWindow):
- rendering/RenderTextControl.h:
- 1:32 PM Changeset in webkit [37294] by
-
- 7 edits in trunk/JavaScriptCore
2008-10-04 Cameron Zwarich <zwarich@apple.com>
Reviewed by Darin Adler.
Bug 21369: Add opcode documentation for all undocumented opcodes
<https://bugs.webkit.org/show_bug.cgi?id=21369>
This patch adds opcode documentation for all undocumented opcodes, and
it also renames op_init_arguments to op_create_arguments.
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator):
- VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_create_arguments):
- VM/Machine.h:
- VM/Opcode.h:
- 11:41 AM Changeset in webkit [37293] by
-
- 2 edits in trunk/WebCore
2008-10-04 Matt Lilek <webkit@mattlilek.com>
Build fix - restore Private role to headers that had it before the move.
- WebCore.xcodeproj/project.pbxproj:
- 11:37 AM Changeset in webkit [37292] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix ChangeLog.
- 11:37 AM Changeset in webkit [37291] by
-
- 3 edits in trunk/WebCore
2008-10-04 Darin Adler <Darin Adler>
- try to fix build
- DerivedSources.make: Add new inspector directory to VPATH.
- GNUmakefile.am:
- 10:28 AM Changeset in webkit [37290] by
-
- 2 edits in trunk/WebCore
2008-10-04 Matt Lilek <webkit@mattlilek.com>
Not reviewed, attempt to fix Gtk build.
- GNUmakefile.am:
- 1:10 AM Changeset in webkit [37289] by
-
- 6 edits156 moves3 adds in trunk/WebCore
Move the Web Inspector files into a top-level "inspector" folder.
Reviewed by Dave Hyatt.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- inspector/InspectorClient.h: Renamed from WebCore/page/InspectorClient.h.
- inspector/InspectorController.cpp: Renamed from WebCore/page/InspectorController.cpp.
- inspector/InspectorController.h: Renamed from WebCore/page/InspectorController.h.
- inspector/JavaScriptCallFrame.cpp: Renamed from WebCore/page/JavaScriptCallFrame.cpp.
- inspector/JavaScriptCallFrame.h: Renamed from WebCore/page/JavaScriptCallFrame.h.
- inspector/JavaScriptCallFrame.idl: Renamed from WebCore/page/JavaScriptCallFrame.idl.
- inspector/JavaScriptDebugListener.h: Renamed from WebCore/page/JavaScriptDebugListener.h.
- inspector/JavaScriptDebugServer.cpp: Renamed from WebCore/page/JavaScriptDebugServer.cpp.
- inspector/JavaScriptDebugServer.h: Renamed from WebCore/page/JavaScriptDebugServer.h.
- inspector/JavaScriptProfile.cpp: Renamed from WebCore/page/JavaScriptProfile.cpp.
- inspector/JavaScriptProfile.h: Renamed from WebCore/page/JavaScriptProfile.h.
- inspector/JavaScriptProfileNode.cpp: Renamed from WebCore/page/JavaScriptProfileNode.cpp.
- inspector/JavaScriptProfileNode.h: Renamed from WebCore/page/JavaScriptProfileNode.h.
- inspector/front-end/Breakpoint.js: Renamed from WebCore/page/inspector/Breakpoint.js.
- inspector/front-end/BreakpointsSidebarPane.js: Renamed from WebCore/page/inspector/BreakpointsSidebarPane.js.
- inspector/front-end/CallStackSidebarPane.js: Renamed from WebCore/page/inspector/CallStackSidebarPane.js.
- inspector/front-end/Console.js: Renamed from WebCore/page/inspector/Console.js.
- inspector/front-end/DataGrid.js: Renamed from WebCore/page/inspector/DataGrid.js.
- inspector/front-end/Database.js: Renamed from WebCore/page/inspector/Database.js.
- inspector/front-end/DatabaseQueryView.js: Renamed from WebCore/page/inspector/DatabaseQueryView.js.
- inspector/front-end/DatabaseTableView.js: Renamed from WebCore/page/inspector/DatabaseTableView.js.
- inspector/front-end/DatabasesPanel.js: Renamed from WebCore/page/inspector/DatabasesPanel.js.
- inspector/front-end/ElementsPanel.js: Renamed from WebCore/page/inspector/ElementsPanel.js.
- inspector/front-end/ElementsTreeOutline.js: Renamed from WebCore/page/inspector/ElementsTreeOutline.js.
- inspector/front-end/FontView.js: Renamed from WebCore/page/inspector/FontView.js.
- inspector/front-end/ImageView.js: Renamed from WebCore/page/inspector/ImageView.js.
- inspector/front-end/Images/back.png: Renamed from WebCore/page/inspector/Images/back.png.
- inspector/front-end/Images/checker.png: Renamed from WebCore/page/inspector/Images/checker.png.
- inspector/front-end/Images/clearConsoleButtons.png: Renamed from WebCore/page/inspector/Images/clearConsoleButtons.png.
- inspector/front-end/Images/closeButtons.png: Renamed from WebCore/page/inspector/Images/closeButtons.png.
- inspector/front-end/Images/consoleButtons.png: Renamed from WebCore/page/inspector/Images/consoleButtons.png.
- inspector/front-end/Images/database.png: Renamed from WebCore/page/inspector/Images/database.png.
- inspector/front-end/Images/databaseTable.png: Renamed from WebCore/page/inspector/Images/databaseTable.png.
- inspector/front-end/Images/databasesIcon.png: Renamed from WebCore/page/inspector/Images/databasesIcon.png.
- inspector/front-end/Images/debuggerContinue.png: Renamed from WebCore/page/inspector/Images/debuggerContinue.png.
- inspector/front-end/Images/debuggerPause.png: Renamed from WebCore/page/inspector/Images/debuggerPause.png.
- inspector/front-end/Images/debuggerStepInto.png: Renamed from WebCore/page/inspector/Images/debuggerStepInto.png.
- inspector/front-end/Images/debuggerStepOut.png: Renamed from WebCore/page/inspector/Images/debuggerStepOut.png.
- inspector/front-end/Images/debuggerStepOver.png: Renamed from WebCore/page/inspector/Images/debuggerStepOver.png.
- inspector/front-end/Images/debuggingButtons.png: Renamed from WebCore/page/inspector/Images/debuggingButtons.png.
- inspector/front-end/Images/disclosureTriangleSmallDown.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallDown.png.
- inspector/front-end/Images/disclosureTriangleSmallDownBlack.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallDownBlack.png.
- inspector/front-end/Images/disclosureTriangleSmallDownWhite.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallDownWhite.png.
- inspector/front-end/Images/disclosureTriangleSmallRight.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRight.png.
- inspector/front-end/Images/disclosureTriangleSmallRightBlack.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightBlack.png.
- inspector/front-end/Images/disclosureTriangleSmallRightDown.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightDown.png.
- inspector/front-end/Images/disclosureTriangleSmallRightDownBlack.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightDownBlack.png.
- inspector/front-end/Images/disclosureTriangleSmallRightDownWhite.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightDownWhite.png.
- inspector/front-end/Images/disclosureTriangleSmallRightWhite.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightWhite.png.
- inspector/front-end/Images/dockButtons.png: Renamed from WebCore/page/inspector/Images/dockButtons.png.
- inspector/front-end/Images/elementsIcon.png: Renamed from WebCore/page/inspector/Images/elementsIcon.png.
- inspector/front-end/Images/errorIcon.png: Renamed from WebCore/page/inspector/Images/errorIcon.png.
- inspector/front-end/Images/errorMediumIcon.png: Renamed from WebCore/page/inspector/Images/errorMediumIcon.png.
- inspector/front-end/Images/excludeButtons.png: Renamed from WebCore/page/inspector/Images/excludeButtons.png.
- inspector/front-end/Images/focusButtons.png: Renamed from WebCore/page/inspector/Images/focusButtons.png.
- inspector/front-end/Images/forward.png: Renamed from WebCore/page/inspector/Images/forward.png.
- inspector/front-end/Images/glossyHeader.png: Renamed from WebCore/page/inspector/Images/glossyHeader.png.
- inspector/front-end/Images/glossyHeaderPressed.png: Renamed from WebCore/page/inspector/Images/glossyHeaderPressed.png.
- inspector/front-end/Images/glossyHeaderSelected.png: Renamed from WebCore/page/inspector/Images/glossyHeaderSelected.png.
- inspector/front-end/Images/glossyHeaderSelectedPressed.png: Renamed from WebCore/page/inspector/Images/glossyHeaderSelectedPressed.png.
- inspector/front-end/Images/goArrow.png: Renamed from WebCore/page/inspector/Images/goArrow.png.
- inspector/front-end/Images/largerResourcesButtons.png: Renamed from WebCore/page/inspector/Images/largerResourcesButtons.png.
- inspector/front-end/Images/nodeSearchButtons.png: Renamed from WebCore/page/inspector/Images/nodeSearchButtons.png.
- inspector/front-end/Images/paneBottomGrow.png: Renamed from WebCore/page/inspector/Images/paneBottomGrow.png.
- inspector/front-end/Images/paneBottomGrowActive.png: Renamed from WebCore/page/inspector/Images/paneBottomGrowActive.png.
- inspector/front-end/Images/paneGrowHandleLine.png: Renamed from WebCore/page/inspector/Images/paneGrowHandleLine.png.
- inspector/front-end/Images/pauseOnExceptionButtons.png: Renamed from WebCore/page/inspector/Images/pauseOnExceptionButtons.png.
- inspector/front-end/Images/percentButtons.png: Renamed from WebCore/page/inspector/Images/percentButtons.png.
- inspector/front-end/Images/profileGroupIcon.png: Renamed from WebCore/page/inspector/Images/profileGroupIcon.png.
- inspector/front-end/Images/profileIcon.png: Renamed from WebCore/page/inspector/Images/profileIcon.png.
- inspector/front-end/Images/profileSmallIcon.png: Renamed from WebCore/page/inspector/Images/profileSmallIcon.png.
- inspector/front-end/Images/profilesIcon.png: Renamed from WebCore/page/inspector/Images/profilesIcon.png.
- inspector/front-end/Images/recordButtons.png: Renamed from WebCore/page/inspector/Images/recordButtons.png.
- inspector/front-end/Images/reloadButtons.png: Renamed from WebCore/page/inspector/Images/reloadButtons.png.
- inspector/front-end/Images/resourceCSSIcon.png: Renamed from WebCore/page/inspector/Images/resourceCSSIcon.png.
- inspector/front-end/Images/resourceDocumentIcon.png: Renamed from WebCore/page/inspector/Images/resourceDocumentIcon.png.
- inspector/front-end/Images/resourceDocumentIconSmall.png: Renamed from WebCore/page/inspector/Images/resourceDocumentIconSmall.png.
- inspector/front-end/Images/resourceJSIcon.png: Renamed from WebCore/page/inspector/Images/resourceJSIcon.png.
- inspector/front-end/Images/resourcePlainIcon.png: Renamed from WebCore/page/inspector/Images/resourcePlainIcon.png.
- inspector/front-end/Images/resourcePlainIconSmall.png: Renamed from WebCore/page/inspector/Images/resourcePlainIconSmall.png.
- inspector/front-end/Images/resourcesIcon.png: Renamed from WebCore/page/inspector/Images/resourcesIcon.png.
- inspector/front-end/Images/resourcesSizeGraphIcon.png: Renamed from WebCore/page/inspector/Images/resourcesSizeGraphIcon.png.
- inspector/front-end/Images/resourcesTimeGraphIcon.png: Renamed from WebCore/page/inspector/Images/resourcesTimeGraphIcon.png.
- inspector/front-end/Images/scriptsIcon.png: Renamed from WebCore/page/inspector/Images/scriptsIcon.png.
- inspector/front-end/Images/searchSmallBlue.png: Renamed from WebCore/page/inspector/Images/searchSmallBlue.png.
- inspector/front-end/Images/searchSmallBrightBlue.png: Renamed from WebCore/page/inspector/Images/searchSmallBrightBlue.png.
- inspector/front-end/Images/searchSmallGray.png: Renamed from WebCore/page/inspector/Images/searchSmallGray.png.
- inspector/front-end/Images/searchSmallWhite.png: Renamed from WebCore/page/inspector/Images/searchSmallWhite.png.
- inspector/front-end/Images/segment.png: Renamed from WebCore/page/inspector/Images/segment.png.
- inspector/front-end/Images/segmentEnd.png: Renamed from WebCore/page/inspector/Images/segmentEnd.png.
- inspector/front-end/Images/segmentHover.png: Renamed from WebCore/page/inspector/Images/segmentHover.png.
- inspector/front-end/Images/segmentHoverEnd.png: Renamed from WebCore/page/inspector/Images/segmentHoverEnd.png.
- inspector/front-end/Images/segmentSelected.png: Renamed from WebCore/page/inspector/Images/segmentSelected.png.
- inspector/front-end/Images/segmentSelectedEnd.png: Renamed from WebCore/page/inspector/Images/segmentSelectedEnd.png.
- inspector/front-end/Images/splitviewDimple.png: Renamed from WebCore/page/inspector/Images/splitviewDimple.png.
- inspector/front-end/Images/splitviewDividerBackground.png: Renamed from WebCore/page/inspector/Images/splitviewDividerBackground.png.
- inspector/front-end/Images/statusbarBackground.png: Renamed from WebCore/page/inspector/Images/statusbarBackground.png.
- inspector/front-end/Images/statusbarBottomBackground.png: Renamed from WebCore/page/inspector/Images/statusbarBottomBackground.png.
- inspector/front-end/Images/statusbarButtons.png: Renamed from WebCore/page/inspector/Images/statusbarButtons.png.
- inspector/front-end/Images/statusbarMenuButton.png: Renamed from WebCore/page/inspector/Images/statusbarMenuButton.png.
- inspector/front-end/Images/statusbarMenuButtonSelected.png: Renamed from WebCore/page/inspector/Images/statusbarMenuButtonSelected.png.
- inspector/front-end/Images/statusbarResizerHorizontal.png: Renamed from WebCore/page/inspector/Images/statusbarResizerHorizontal.png.
- inspector/front-end/Images/statusbarResizerVertical.png: Renamed from WebCore/page/inspector/Images/statusbarResizerVertical.png.
- inspector/front-end/Images/timelinePillBlue.png: Renamed from WebCore/page/inspector/Images/timelinePillBlue.png.
- inspector/front-end/Images/timelinePillGray.png: Renamed from WebCore/page/inspector/Images/timelinePillGray.png.
- inspector/front-end/Images/timelinePillGreen.png: Renamed from WebCore/page/inspector/Images/timelinePillGreen.png.
- inspector/front-end/Images/timelinePillOrange.png: Renamed from WebCore/page/inspector/Images/timelinePillOrange.png.
- inspector/front-end/Images/timelinePillPurple.png: Renamed from WebCore/page/inspector/Images/timelinePillPurple.png.
- inspector/front-end/Images/timelinePillRed.png: Renamed from WebCore/page/inspector/Images/timelinePillRed.png.
- inspector/front-end/Images/timelinePillYellow.png: Renamed from WebCore/page/inspector/Images/timelinePillYellow.png.
- inspector/front-end/Images/tipBalloon.png: Renamed from WebCore/page/inspector/Images/tipBalloon.png.
- inspector/front-end/Images/tipBalloonBottom.png: Renamed from WebCore/page/inspector/Images/tipBalloonBottom.png.
- inspector/front-end/Images/tipIcon.png: Renamed from WebCore/page/inspector/Images/tipIcon.png.
- inspector/front-end/Images/tipIconPressed.png: Renamed from WebCore/page/inspector/Images/tipIconPressed.png.
- inspector/front-end/Images/toolbarItemSelected.png: Renamed from WebCore/page/inspector/Images/toolbarItemSelected.png.
- inspector/front-end/Images/treeDownTriangleBlack.png: Renamed from WebCore/page/inspector/Images/treeDownTriangleBlack.png.
- inspector/front-end/Images/treeDownTriangleWhite.png: Renamed from WebCore/page/inspector/Images/treeDownTriangleWhite.png.
- inspector/front-end/Images/treeRightTriangleBlack.png: Renamed from WebCore/page/inspector/Images/treeRightTriangleBlack.png.
- inspector/front-end/Images/treeRightTriangleWhite.png: Renamed from WebCore/page/inspector/Images/treeRightTriangleWhite.png.
- inspector/front-end/Images/treeUpTriangleBlack.png: Renamed from WebCore/page/inspector/Images/treeUpTriangleBlack.png.
- inspector/front-end/Images/treeUpTriangleWhite.png: Renamed from WebCore/page/inspector/Images/treeUpTriangleWhite.png.
- inspector/front-end/Images/userInputIcon.png: Renamed from WebCore/page/inspector/Images/userInputIcon.png.
- inspector/front-end/Images/userInputPreviousIcon.png: Renamed from WebCore/page/inspector/Images/userInputPreviousIcon.png.
- inspector/front-end/Images/warningIcon.png: Renamed from WebCore/page/inspector/Images/warningIcon.png.
- inspector/front-end/Images/warningMediumIcon.png: Renamed from WebCore/page/inspector/Images/warningMediumIcon.png.
- inspector/front-end/Images/warningsErrors.png: Renamed from WebCore/page/inspector/Images/warningsErrors.png.
- inspector/front-end/MetricsSidebarPane.js: Renamed from WebCore/page/inspector/MetricsSidebarPane.js.
- inspector/front-end/Object.js: Renamed from WebCore/page/inspector/Object.js.
- inspector/front-end/ObjectPropertiesSection.js: Renamed from WebCore/page/inspector/ObjectPropertiesSection.js.
- inspector/front-end/Panel.js: Renamed from WebCore/page/inspector/Panel.js.
- inspector/front-end/Placard.js: Renamed from WebCore/page/inspector/Placard.js.
- inspector/front-end/ProfileView.js: Renamed from WebCore/page/inspector/ProfileView.js.
- inspector/front-end/ProfilesPanel.js: Renamed from WebCore/page/inspector/ProfilesPanel.js.
- inspector/front-end/PropertiesSection.js: Renamed from WebCore/page/inspector/PropertiesSection.js.
- inspector/front-end/PropertiesSidebarPane.js: Renamed from WebCore/page/inspector/PropertiesSidebarPane.js.
- inspector/front-end/Resource.js: Renamed from WebCore/page/inspector/Resource.js.
- inspector/front-end/ResourceCategory.js: Renamed from WebCore/page/inspector/ResourceCategory.js.
- inspector/front-end/ResourceView.js: Renamed from WebCore/page/inspector/ResourceView.js.
- inspector/front-end/ResourcesPanel.js: Renamed from WebCore/page/inspector/ResourcesPanel.js.
- inspector/front-end/ScopeChainSidebarPane.js: Renamed from WebCore/page/inspector/ScopeChainSidebarPane.js.
- inspector/front-end/Script.js: Renamed from WebCore/page/inspector/Script.js.
- inspector/front-end/ScriptView.js: Renamed from WebCore/page/inspector/ScriptView.js.
- inspector/front-end/ScriptsPanel.js: Renamed from WebCore/page/inspector/ScriptsPanel.js.
- inspector/front-end/SidebarPane.js: Renamed from WebCore/page/inspector/SidebarPane.js.
- inspector/front-end/SidebarTreeElement.js: Renamed from WebCore/page/inspector/SidebarTreeElement.js.
- inspector/front-end/SourceFrame.js: Renamed from WebCore/page/inspector/SourceFrame.js.
- inspector/front-end/SourceView.js: Renamed from WebCore/page/inspector/SourceView.js.
- inspector/front-end/StylesSidebarPane.js: Renamed from WebCore/page/inspector/StylesSidebarPane.js.
- inspector/front-end/TextPrompt.js: Renamed from WebCore/page/inspector/TextPrompt.js.
- inspector/front-end/View.js: Renamed from WebCore/page/inspector/View.js.
- inspector/front-end/WebKit.qrc: Renamed from WebCore/page/inspector/WebKit.qrc.
- inspector/front-end/inspector.css: Renamed from WebCore/page/inspector/inspector.css.
- inspector/front-end/inspector.html: Renamed from WebCore/page/inspector/inspector.html.
- inspector/front-end/inspector.js: Renamed from WebCore/page/inspector/inspector.js.
- inspector/front-end/treeoutline.js: Renamed from WebCore/page/inspector/treeoutline.js.
- inspector/front-end/utilities.js: Renamed from WebCore/page/inspector/utilities.js.
- 1:09 AM Changeset in webkit [37288] by
-
- 2 edits in trunk/WebCore
Adds support to the Web Inspector's Elements panel for fast tag name,
class name, id and attribute name searching. The panel first tries
using getElementById, getElementsByClassName and getElementsByTagName
with the search query. Then does a slower search using XPath for partial
matches, text and comment matches.
Adds support for search queries like "<div>", "<h" and "frame>".
These forms limit the search to tag names, text and comment matches.
Reviewed by Maciej Stachowiak.
- page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.performSearch): Add tag syntax support. Add new search functions that try exact matches first.
- 1:09 AM Changeset in webkit [37287] by
-
- 2 edits in trunk/WebCore
Changes how searching works in the Web Inspector's Elements
panel. The search tasks are divided into chunks that are small
units of work that are performed at a time interval. This
change also prevents queries that will select all elements,
since that isn't useful.
Reviewed by Oliver Hunt.
- page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.searchCancled): Remove the searchResultsProperty form results since there might be an unfinished search. (WebInspector.ElementsPanel.prototype.performSearch): Divide the documents and search functions into chunks that are performed on a interval of 25ms. Prevent searches for "*" and "*".
- 1:00 AM Changeset in webkit [37286] by
-
- 1 edit in trunk/WebCore/page/inspector/Panel.js
Fix a typo.
- 12:15 AM Changeset in webkit [37285] by
-
- 21 edits3 adds in trunk
2008-10-03 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- "this" object in methods called on primitives should be wrapper object https://bugs.webkit.org/show_bug.cgi?id=21362
I changed things so that functions which use "this" do a fast
version of toThisObject conversion if needed. Currently we miss
the conversion entirely, at least for primitive types. Using
TypeInfo and the primitive check, I made the fast case bail out
pretty fast.
This is inexplicably an 1.007x SunSpider speedup (and a wash on V8 benchmarks).
Also renamed some opcodes for clarity:
init ==> enter
init_activation ==> enter_with_activation
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::generate): (JSC::CodeGenerator::CodeGenerator):
- VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_convert_this):
- VM/Machine.h:
- VM/Opcode.h:
- kjs/JSActivation.cpp: (JSC::JSActivation::JSActivation):
- kjs/JSActivation.h: (JSC::JSActivation::createStructureID):
- kjs/JSCell.h: (JSC::JSValue::needsThisConversion):
- kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
- kjs/JSGlobalData.h:
- kjs/JSNumberCell.h: (JSC::JSNumberCell::createStructureID):
- kjs/JSStaticScopeObject.h: (JSC::JSStaticScopeObject::JSStaticScopeObject): (JSC::JSStaticScopeObject::createStructureID):
- kjs/JSString.h: (JSC::JSString::createStructureID):
- kjs/JSValue.h:
- kjs/TypeInfo.h: (JSC::TypeInfo::needsThisConversion):
- kjs/nodes.h: (JSC::ScopeNode::usesThis):
WebCore:
2008-10-03 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- "this" object in methods called on primitives should be wrapper object https://bugs.webkit.org/show_bug.cgi?id=21362
Updated so toThis conversion for the split window is handled properly.
- bindings/scripts/CodeGeneratorJS.pm:
LayoutTests:
2008-10-03 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- test case for: "this" object in methods called on primitives should be wrapper object
- fast/js/primitive-method-this-expected.txt: Added.
- fast/js/primitive-method-this.html: Added.
- fast/js/resources/primitive-method-this.js: Added.
Oct 3, 2008:
- 11:40 PM Changeset in webkit [37284] by
-
- 1 edit in trunk/WebCore/platform/qt/WidgetQt.cpp
Fix Qt bustage.
- 10:47 PM Changeset in webkit [37283] by
-
- 2 edits in trunk/JavaScriptCore
2008-10-03 Cameron Zwarich <zwarich@apple.com>
Reviewed by Maciej Stachowiak.
Bug 21356: The size of the RegisterFile differs depending on 32-bit / 64-bit and Debug / Release
<https://bugs.webkit.org/show_bug.cgi?id=21356>
The RegisterFile decreases in size (measured in terms of numbers of
Registers) as the size of a Register increases. This causes
js1_5/Regress/regress-159334.js
to fail in 64-bit debug builds. This fix makes the RegisterFile on all
platforms the same size that it is in 32-bit Release builds.
- VM/RegisterFile.h: (JSC::RegisterFile::RegisterFile):
- 10:16 PM Changeset in webkit [37282] by
-
- 6 edits3 moves in trunk/WebCore
2008-10-03 Sam Weinig <sam@webkit.org>
Reviewed by David "The Motivator" Hyatt.
Patch for https://bugs.webkit.org/show_bug.cgi?id=21355
Move SecurityOrigin out of platform/ to page/.
It was a layering violation for SecurityOrigin to be in platform
as it depended on FrameLoader.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- page/SecurityOrigin.cpp: Copied from platform/SecurityOrigin.cpp.
- page/SecurityOrigin.h: Copied from platform/SecurityOrigin.h.
- page/SecurityOriginHash.h: Copied from platform/SecurityOriginHash.h.
- platform/SecurityOrigin.cpp: Removed.
- platform/SecurityOrigin.h: Removed.
- platform/SecurityOriginHash.h: Removed.
- 9:24 PM Changeset in webkit [37281] by
-
- 2 edits in trunk/WebCore
2008-10-03 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=18832
[curl] file upload does not work
The curl_off_t integer type has a different size depending if large
file support is enabled or not. There is no different public API for
the two cases, so the same function accepts a different type based on
a compilation option the could be different in WebKit and libcurl.
To fix the bug we query libcurl at runtime for large file support and
pass the right type based on that.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPOST):
- 9:02 PM Changeset in webkit [37280] by
-
- 7 edits in trunk/WebCore
2008-10-03 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by David Hyatt.
Gtk build fixes.
- platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::openFileChooser):
- platform/gtk/PlatformScreenGtk.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenAvailableRect):
- platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::show):
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformAddChild): (WebCore::ScrollView::platformRemoveChild):
- platform/gtk/WidgetGtk.cpp: (WebCore::Widget::setCursor):
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::getValue): (WebCore::PluginView::forceRedraw): (WebCore::PluginView::init):
- 8:31 PM Changeset in webkit [37279] by
-
- 1 edit in trunk/WebCore/platform/qt/PopupMenuQt.cpp
Fix Qt bustage.
- 7:02 PM Changeset in webkit [37278] by
-
- 1 edit in trunk/WebKit/win/WebCoreSupport/WebChromeClient.h
Fix Windows bustage in WebKit side.
- 7:01 PM Changeset in webkit [37277] by
-
- 3 edits in trunk/WebKit/win
Fix Windows bustage in WebKit side.
- 6:50 PM Changeset in webkit [37276] by
-
- 1 edit in trunk/WebCore/platform/win/FileChooserWin.cpp
Fix Win bustage.
- 6:39 PM Changeset in webkit [37275] by
-
- 9 edits in trunk/JavaScriptCore
2008-10-03 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- Some code cleanup to how we handle code features.
1) Rename FeatureInfo typedef to CodeFeatures.
2) Rename NodeFeatureInfo template to NodeInfo.
3) Keep CodeFeature bitmask in ScopeNode instead of trying to break it out into individual bools.
4) Rename misleadingly named "needsClosure" method to "containsClosures", which better describes the meaning
of ClosureFeature.
5) Make setUsersArguments() not take an argument since it only goes one way.
- JavaScriptCore.exp:
- VM/CodeBlock.h: (JSC::CodeBlock::CodeBlock):
- kjs/NodeInfo.h:
- kjs/Parser.cpp: (JSC::Parser::didFinishParsing):
- kjs/Parser.h: (JSC::Parser::parse):
- kjs/grammar.y:
- kjs/nodes.cpp: (JSC::ScopeNode::ScopeNode): (JSC::ProgramNode::ProgramNode): (JSC::ProgramNode::create): (JSC::EvalNode::EvalNode): (JSC::EvalNode::create): (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::create):
- kjs/nodes.h: (JSC::ScopeNode::usesEval): (JSC::ScopeNode::containsClosures): (JSC::ScopeNode::usesArguments): (JSC::ScopeNode::setUsesArguments):
- 6:11 PM Changeset in webkit [37274] by
-
- 2 edits in trunk/WebKit/gtk
2008-10-03 David Hyatt <hyatt@apple.com>
Fix Gtk bustage from use of containingWindow() over on the WebKit side. Replace with HostWindow use.
- webkit/webkitwebview.cpp:
- 6:09 PM Changeset in webkit [37273] by
-
- 2 edits in trunk/WebCore
2008-10-03 David Hyatt <hyatt@apple.com>
Fix Qt bustage from missing include.
- platform/qt/PlatformScreenQt.cpp:
- 6:08 PM Changeset in webkit [37272] by
-
- 2 edits in trunk/WebCore
2008-10-03 David Hyatt <hyatt@apple.com>
Fix Windows scrollbar bustage in popup menus.
- platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc):
- 6:07 PM Changeset in webkit [37271] by
-
- 5 edits in trunk/WebCore
2008-10-03 David Hyatt <hyatt@apple.com>
Fix Windows bustage.
- platform/win/FileChooserWin.cpp: (WebCore::FileChooser::openFileChooser):
- platform/win/PlatformScreenWin.cpp: (WebCore::monitorInfoForWidget):
- platform/win/WidgetWin.cpp:
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::getValue): (WebCore::PluginView::forceRedraw): (WebCore::PluginView::init):
- 5:21 PM Changeset in webkit [37270] by
-
- 2 edits in trunk/WebKitTools
2008-10-03 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Darin Adler
Render images to RGBA8 bitmaps independently of platform endianness.
Create image difference bitmap in reference image colorspace instead of device colorspace
(which depends on the main display profile), so that no color matching happens.
- DumpRenderTree/cg/ImageDiffCG.cpp: (createDifferenceBitmap): (computePercentageDifferent): (compareImages):
- 5:16 PM Changeset in webkit [37269] by
-
- 2 edits in trunk/WebKitTools
2008-10-02 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Fix hang when running with --pixel --reset, which occurs
because DRT spews PNG data when the script does not expect it.
- Scripts/run-webkit-tests:
- 5:10 PM Changeset in webkit [37268] by
-
- 5 edits in trunk/JavaScriptCore
2008-10-03 Cameron Zwarich <zwarich@apple.com>
Reviewed by Maciej Stachowiak.
Bug 21343: REGRESSSION (r37160): ecma_3/ExecutionContexts/10.1.3-1.js and js1_4/Functions/function-001.js fail on 64-bit
<https://bugs.webkit.org/show_bug.cgi?id=21343>
A fix was landed for this issue in r37253, and the ChangeLog assumes
that it is a compiler bug, but it turns out that it is a subtle issue
with mixing signed and unsigned 32-bit values in a 64-bit environment.
In order to properly fix this bug, we should convert our signed offsets
into the register file to use ptrdiff_t.
This may not be the only instance of this issue, but I will land this
fix first and look for more later.
- VM/Machine.cpp: (JSC::Machine::getArgumentsData):
- VM/Machine.h:
- kjs/Arguments.cpp: (JSC::Arguments::getOwnPropertySlot):
- kjs/Arguments.h: (JSC::Arguments::init):
- 4:15 PM Changeset in webkit [37267] by
-
- 2 edits in trunk/WebKit/mac
2008-10-03 John Sullivan <sullivan@apple.com>
Fixed Release build
- Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::destroyStream): added !LOG_DISABLED guard around declaration of npErr used only in LOG
- 3:55 PM Changeset in webkit [37266] by
-
- 2 edits in trunk/WebCore
2008-10-03 Darin Adler <Darin Adler>
- bindings/js/JSInspectedObjectWrapper.cpp: Try to fix a build failure seen on some machines but not others by adding an include.
- 3:41 PM Changeset in webkit [37265] by
-
- 3 edits in trunk/WebCore
2008-10-03 Darin Adler <Darin Adler>
- Qt build fix
- bridge/qt/qt_runtime.cpp: Remove long-obsolete codeType and execute functions. Declarations for these relied on the CodeType enumeration, which used to be in ExecState.h; but the functions aren't needed at all.
- bridge/qt/qt_runtime.h: Ditto.
- 3:29 PM Changeset in webkit [37264] by
-
- 3 edits in trunk/JavaScriptCore
2008-10-03 Darin Adler <Darin Adler>
- VM/CTI.cpp: Another Windows build fix. Change the args of ctiTrampoline.
- kjs/JSNumberCell.h: A build fix for newer versions of gcc. Added declarations of JSGlobalData overloads of jsNumberCell.
- 3:24 PM Changeset in webkit [37263] by
-
- 1 edit in trunk/WebKit/wx/WebKitSupport/ChromeClientWx.cpp
Fix wx bustage.
- 3:24 PM Changeset in webkit [37262] by
-
- 1 edit in trunk/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp
Fix Qt bustage.
- 3:23 PM Changeset in webkit [37261] by
-
- 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp
Fix Gtk bustage.
- 2:58 PM Changeset in webkit [37260] by
-
- 3 edits in trunk/WebKit/mac
2008-10-03 Anders Carlsson <andersca@apple.com>
Reviewed by David Hyatt.
Convert destroyStream over to C++.
- Plugins/WebBaseNetscapePluginStream.h:
- Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::destroyStream): (-[WebBaseNetscapePluginStream _destroyStreamWithReason:]): (-[WebBaseNetscapePluginStream _deliverData]):
- 2:54 PM Changeset in webkit [37259] by
-
- 2 edits in trunk/JavaScriptCore
2008-10-03 Darin Adler <Darin Adler>
- try to fix Windows build
- kjs/ScopeChain.h: Add forward declaration of JSGlobalData.
- 2:45 PM Changeset in webkit [37258] by
-
- 3 edits in trunk/WebKit/mac
2008-10-03 Anders Carlsson <andersca@apple.com>
Reviewed by David Hyatt.
Use a Timer instead of -[NSObject performSelector:withObject:afterDelay];
- Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::WebNetscapePluginStream):
- Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream _destroyStream]): (-[WebBaseNetscapePluginStream _deliverData]): (WebNetscapePluginStream::deliverDataTimerFired):
- 2:39 PM Changeset in webkit [37257] by
-
- 42 edits in trunk
2008-10-03 Darin Adler <Darin Adler>
Reviewed by Geoff Garen.
- next step of https://bugs.webkit.org/show_bug.cgi?id=21295 Turn ExecState into a call frame pointer.
Remove m_globalObject and m_globalData from ExecState.
SunSpider says this is a wash (slightly faster but not statistically
significant); which is good enough since it's a preparation step and
not supposed to be a spedup.
- API/JSCallbackFunction.cpp: (JSC::JSCallbackFunction::JSCallbackFunction):
- kjs/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor):
- kjs/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor):
- kjs/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
- kjs/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor):
- kjs/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype):
- kjs/JSFunction.cpp: (JSC::JSFunction::JSFunction):
- kjs/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor):
- kjs/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor):
- kjs/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor):
- kjs/PrototypeFunction.cpp: (JSC::PrototypeFunction::PrototypeFunction):
- kjs/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor):
- kjs/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor): Pass JSGlobalData* instead of ExecState* to the InternalFunction constructor.
- API/OpaqueJSString.cpp: Added now-needed include.
- JavaScriptCore.exp: Updated.
- VM/CTI.cpp: (JSC::CTI::emitSlowScriptCheck): Changed to use ARGS_globalData instead of ARGS_exec.
- VM/CTI.h: Added a new argument to the CTI, the global data pointer. While it's possible to get to the global data pointer using the ExecState pointer, it's slow enough that it's better to just keep it around in the CTI arguments.
- VM/CodeBlock.h: Moved the CodeType enum here from ExecState.h.
- VM/Machine.cpp: (JSC::Machine::execute): Pass fewer arguments when constructing ExecState, and pass the global data pointer when invoking CTI. (JSC::Machine::firstCallFrame): Added. Used to get the dynamic global object, which is in the scope chain of the first call frame. (JSC::Machine::cti_op_add): Use globalData instead of exec when possible, to keep fast cases fast, since it's now more expensive to get to it through the exec pointer. (JSC::Machine::cti_timeout_check): Ditto. (JSC::Machine::cti_op_put_by_id_second): Ditto. (JSC::Machine::cti_op_get_by_id_second): Ditto. (JSC::Machine::cti_op_mul): Ditto. (JSC::Machine::cti_vm_compile): Ditto. (JSC::Machine::cti_op_get_by_val): Ditto. (JSC::Machine::cti_op_sub): Ditto. (JSC::Machine::cti_op_put_by_val): Ditto. (JSC::Machine::cti_op_put_by_val_array): Ditto. (JSC::Machine::cti_op_negate): Ditto. (JSC::Machine::cti_op_div): Ditto. (JSC::Machine::cti_op_pre_dec): Ditto. (JSC::Machine::cti_op_post_inc): Ditto. (JSC::Machine::cti_op_lshift): Ditto. (JSC::Machine::cti_op_bitand): Ditto. (JSC::Machine::cti_op_rshift): Ditto. (JSC::Machine::cti_op_bitnot): Ditto. (JSC::Machine::cti_op_mod): Ditto. (JSC::Machine::cti_op_post_dec): Ditto. (JSC::Machine::cti_op_urshift): Ditto. (JSC::Machine::cti_op_bitxor): Ditto. (JSC::Machine::cti_op_bitor): Ditto. (JSC::Machine::cti_op_call_eval): Ditto. (JSC::Machine::cti_op_throw): Ditto. (JSC::Machine::cti_op_is_string): Ditto. (JSC::Machine::cti_op_debug): Ditto. (JSC::Machine::cti_vm_throw): Ditto.
- VM/Machine.h: Added firstCallFrame.
- kjs/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate): Pass fewer arguments when constructing ExecState.
- kjs/ExecState.cpp: Deleted contents. Later we'll remove the file altogether.
- kjs/ExecState.h: Removed m_globalObject and m_globalData. Moved CodeType into another header. (JSC::ExecState::ExecState): Take only a single argument, a call frame pointer. (JSC::ExecState::dynamicGlobalObject): Get the object from the first call frame since it's no longer stored. (JSC::ExecState::globalData): Get the global data from the scope chain, since we no longer store a pointer to it here. (JSC::ExecState::identifierTable): Ditto. (JSC::ExecState::propertyNames): Ditto. (JSC::ExecState::emptyList): Ditto. (JSC::ExecState::lexer): Ditto. (JSC::ExecState::parser): Ditto. (JSC::ExecState::machine): Ditto. (JSC::ExecState::arrayTable): Ditto. (JSC::ExecState::dateTable): Ditto. (JSC::ExecState::mathTable): Ditto. (JSC::ExecState::numberTable): Ditto. (JSC::ExecState::regExpTable): Ditto. (JSC::ExecState::regExpConstructorTable): Ditto. (JSC::ExecState::stringTable): Ditto. (JSC::ExecState::heap): Ditto.
- kjs/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor): Pass JSGlobalData* instead of ExecState* to the InternalFunction constructor. (JSC::constructFunction): Pass the global data pointer when constructing a new scope chain.
- kjs/InternalFunction.cpp: (JSC::InternalFunction::InternalFunction): Take a JSGlobalData* instead of an ExecState*. Later we can change more places to work this way -- it's more efficient to take the type you need since the caller might already have it.
- kjs/InternalFunction.h: Ditto.
- kjs/JSCell.h: (JSC::JSCell::operator new): Added an overload that takes a JSGlobalData* so you can construct without an ExecState*.
- kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): Moved creation of the global scope chain in here, since it now requires a pointer to the global data. Moved the initialization of the call frame in here since it requires the global scope chain node. Removed the extra argument to ExecState when creating the global ExecState*.
- kjs/JSGlobalObject.h: Removed initialization of globalScopeChain and the call frame from the JSGlobalObjectData constructor. Added a thisValue argument to the init function.
- kjs/JSNumberCell.cpp: Added versions of jsNumberCell that take JSGlobalData* rather than ExecState*.
- kjs/JSNumberCell.h: (JSC::JSNumberCell::operator new): Added a version that takes JSGlobalData*. (JSC::JSNumberCell::JSNumberCell): Ditto. (JSC::jsNumber): Ditto.
- kjs/JSString.cpp: (JSC::jsString): Ditto. (JSC::jsSubstring): Ditto. (JSC::jsOwnedString): Ditto.
- kjs/JSString.h: (JSC::JSString::JSString): Changed to take JSGlobalData*. (JSC::jsEmptyString): Added a version that takes JSGlobalData*. (JSC::jsSingleCharacterString): Ditto. (JSC::jsSingleCharacterSubstring): Ditto. (JSC::jsNontrivialString): Ditto. (JSC::JSString::getIndex): Ditto. (JSC::jsString): Ditto. (JSC::jsSubstring): Ditto. (JSC::jsOwnedString): Ditto.
- kjs/ScopeChain.h: Added a globalData pointer to each node. (JSC::ScopeChainNode::ScopeChainNode): Initialize the globalData pointer. (JSC::ScopeChainNode::push): Set the global data pointer in the new node. (JSC::ScopeChain::ScopeChain): Take a globalData argument.
- kjs/SmallStrings.cpp: (JSC::SmallStrings::createEmptyString): Take JSGlobalData* instead of ExecState*. (JSC::SmallStrings::createSingleCharacterString): Ditto.
- kjs/SmallStrings.h: (JSC::SmallStrings::emptyString): Ditto. (JSC::SmallStrings::singleCharacterString): Ditto.
WebCore:
2008-10-03 Darin Adler <Darin Adler>
Reviewed by Geoff Garen.
- next step of https://bugs.webkit.org/show_bug.cgi?id=21295 Turn ExecState into a call frame pointer.
Remove m_globalObject and m_globalData from ExecState.
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData): Removed an argument now that JSGlobalObject doesn't need it any more. (WebCore::JSDOMWindowBase::JSDOMWindowBase): Removed the argument from the JSDOMWindowBaseData constructor, and added the this argument to the JSGlobalObject constructor. This is because a couple key bits of initialization moved from the data constructor to the JSGlobalObject constructor.
- bindings/js/JSDOMWindowBase.h: Ditto.
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
- bridge/runtime_method.cpp: (JSC::RuntimeMethod::RuntimeMethod): Pass JSGlobalData* instead of ExecState* to the InternalFunction constructor.
- 2:34 PM Changeset in webkit [37256] by
-
- 1 edit2 adds in trunk/LayoutTests
2008-10-03 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Testcase for "white-space: -webkit-nowrap" only being converted to
"white-space: nowrap" on <td> and <th> now, not any element with a table-cell
dispay type.
- fast/table/td-display-nowrap-expected.txt: Added.
- fast/table/td-display-nowrap.html: Added.
- 2:34 PM Changeset in webkit [37255] by
-
- 3 edits in trunk/WebKit/mac
2008-10-03 Anders Carlsson <andersca@apple.com>
Reviewed by David Hyatt.
More plug-in stream cleanup.
- Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::create): (WebNetscapePluginStream::WebNetscapePluginStream):
- Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream initWithFrameLoader:]): (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]): (-[WebBaseNetscapePluginStream setPlugin:]): (WebNetscapePluginStream::setPlugin): (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): (-[WebBaseNetscapePluginStream _destroyStream]):
- 2:16 PM Changeset in webkit [37254] by
-
- 19 edits in trunk
2008-10-03 David Hyatt <hyatt@apple.com>
Fix Windows/Qt build bustage.
Reviewed by ggaren
- loader/EmptyClients.h: (WebCore::EmptyChromeClient::platformWindow):
- page/Chrome.cpp: (WebCore::Chrome::platformWindow):
- page/Chrome.h:
- page/ChromeClient.h:
- platform/HostWindow.h:
- platform/qt/PlatformScreenQt.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
- platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::show):
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): (WebCore::PopupMenu::calculatePositionAndSize): (WebCore::PopupWndProc):
- 1:56 PM Changeset in webkit [37253] by
-
- 2 edits in trunk/JavaScriptCore
2008-10-03 Cameron Zwarich <zwarich@apple.com>
Reviewed by Geoff Garen.
Bug 21343: REGRESSSION (r37160): ecma_3/ExecutionContexts/10.1.3-1.js and js1_4/Functions/function-001.js fail on 64-bit
<https://bugs.webkit.org/show_bug.cgi?id=21343>
Add a workaround for a bug in GCC, which affects GCC 4.0, GCC 4.2, and
llvm-gcc 4.2. I put it in an #ifdef because it was a slight regression
on SunSpider in 32-bit, although that might be entirely random.
- kjs/Arguments.cpp: (JSC::Arguments::getOwnPropertySlot):
- 1:20 PM Changeset in webkit [37252] by
-
- 46 edits in trunk/WebCore
2008-10-03 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Make setStyle() take a const RenderStyle, to ensure that an
earlier RenderStyle::diff() remains valid.
- 1:10 PM Changeset in webkit [37251] by
-
- 10 edits in trunk/WebCore
2008-10-03 David Hyatt <hyatt@apple.com>
Preparation for enabling scrollbars to hit test properly inside transforms. Clean up the scrollbar
event handlers to no longer be virtual. Don't pass a mouse event where none is needed. Add a new
method on Scrollbars called transformEvent that will apply all of the transforms to make a new event
that will work properly for hit testing. This patch just stubs out that method to return the same
event untransformed.
Reviewed by Darin Adler
- page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::passMousePressEventToScrollbar):
- page/gtk/EventHandlerGtk.cpp:
- page/mac/EventHandlerMac.mm:
- page/qt/EventHandlerQt.cpp:
- page/win/EventHandlerWin.cpp:
- page/wx/EventHandlerWx.cpp:
- platform/Scrollbar.cpp: (WebCore::Scrollbar::mouseMoved): (WebCore::Scrollbar::mouseExited): (WebCore::Scrollbar::mouseUp): (WebCore::Scrollbar::mouseDown): (WebCore::Scrollbar::transformEvent):
- platform/Scrollbar.h:
- 1:00 PM Changeset in webkit [37250] by
-
- 1 edit6 adds in trunk/LayoutTests
2008-10-03 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyat
Clean up code that changes the RenderStyle passed in to
table renderer setStyle() methods.
- fast/table/floating-th.html: Added.
- fast/table/table-display-types-strict.html: Added.
- fast/table/table-display-types.html: Added.
- platform/mac/fast/table/floating-th-expected.txt: Added.
- platform/mac/fast/table/table-display-types-expected.txt: Added.
- platform/mac/fast/table/table-display-types-strict-expected.txt: Added.
- 12:17 PM Changeset in webkit [37249] by
-
- 12 edits in trunk
WebCore:
2008-10-03 David Hyatt <hyatt@apple.com>
Remove "containingWindow()/setContainingWindow()" from Widget. HostWindow covers this now.
Reviewed by Dan Bernstein & Darin Adler
- platform/ScrollView.cpp: (WebCore::ScrollView::addChild):
- platform/Widget.cpp: (WebCore::Widget::init):
- platform/Widget.h:
- platform/mac/WidgetMac.mm:
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show):
WebKit/gtk:
2008-10-03 David Hyatt <hyatt@apple.com>
Remove "containingWindow()/setContainingWindow()" from Widget. HostWindow covers this now.
Reviewed by Dan Bernstein & Darin Adler
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
WebKit/win:
2008-10-03 David Hyatt <hyatt@apple.com>
Remove "containingWindow()/setContainingWindow()" from Widget. HostWindow covers this now.
Reviewed by Dan Bernstein & Darin Adler
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::transitionToCommittedForNewPage):
- WebScrollBar.cpp: (WebScrollBar::WebScrollBar): (WebScrollBar::init): (WebScrollBar::invalidateScrollbarRect):
- WebScrollBar.h:
- 12:06 PM Changeset in webkit [37248] by
-
- 2 edits in trunk/WebCore
2008-10-03 Adele Peterson <adele@apple.com>
Reviewed by Sam Weinig.
- css/CSSFontSelector.cpp: (WebCore::fontDataForGenericFamily): Return early if settings is nil.
- 12:00 PM Changeset in webkit [37247] by
-
- 3 edits2 adds in trunk
Reviewed by Darin.
https://bugs.webkit.org/show_bug.cgi?id=20134
REGRESSION (2.0.4-3.0.4): No default value set for <input type=range> with an even difference of (max - min)
Make sure the input element gets the right default value when no value is set.
Test: fast/forms/range-default-value.html
- 11:50 AM Changeset in webkit [37246] by
-
- 3 edits in trunk/WebKit/qt
2008-10-03 David Hyatt <hyatt@apple.com>
Fix scroll method on Qt. The delta was supposed to use .width()/.height() and not .x()/.y().
Fix the QtPluginWidget to do an invalidate properly.
Reviewed by ggaren
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::scroll):
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::):
- 11:42 AM Changeset in webkit [37245] by
-
- 1 edit in trunk/WebCore/platform/win/WidgetWin.cpp
Remove commented out method.
- 11:29 AM Changeset in webkit [37244] by
-
- 9 edits1 delete in trunk/WebCore
2008-10-03 David Hyatt <hyatt@apple.com>
Instead of a cross-platform init/destroy that forces every ScrollView platform to have a constructor/
destructor that calls them, switch to having a cross-platform constructor/destructor that calls
platform-specific init/destroy methods.
With this change, ScrollViewWin.cpp can be removed from the build (yay!).
Reviewed by Darin Adler
- WebCore.vcproj/WebCore.vcproj:
- platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView): (WebCore::ScrollView::platformInit): (WebCore::ScrollView::platformDestroy): (WebCore::ScrollView::platformAddChild): (WebCore::ScrollView::platformRemoveChild):
- platform/ScrollView.h:
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformInit): (WebCore::ScrollView::platformDestroy):
- platform/mac/ScrollViewMac.mm:
- platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::platformInit): (WebCore::ScrollView::platformDestroy):
- platform/win/ScrollViewWin.cpp: Removed.
- platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::platformInit): (WebCore::ScrollView::platformDestroy): (WebCore::ScrollView::setPlatformWidget):
- 11:13 AM Changeset in webkit [37243] by
-
- 2 edits in trunk/WebCore
2008-10-03 Adele Peterson <adele@apple.com>
Reviewed by Dan Bernstein.
Fix for <rdar://problem/6012018>
https://bugs.webkit.org/show_bug.cgi?id=21335
CrashTracer: [USER] 4959 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 8
- css/CSSFontSelector.cpp: (WebCore::fontDataForGenericFamily): Return early if the frame is nil.
- 10:27 AM Changeset in webkit [37242] by
-
- 2 edits in trunk/JavaScriptCore
2008-10-03 Darin Adler <Darin Adler>
Rubber stamped by Alexey Proskuryakov.
- kjs/Shell.cpp: (main): Don't delete JSGlobalData. Later, we need to change this tool to use public JavaScriptCore API instead.
- 10:01 AM Changeset in webkit [37241] by
-
- 2 edits in trunk/WebKit/qt
2008-10-03 Ariya Hidayat <ariya.hidayat@trolltech.com>
Build fix. Remove addToDirtyRegion from the header file.
- WebCoreSupport/ChromeClientQt.h:
- 9:09 AM Changeset in webkit [37240] by
-
- 2 edits in trunk/JavaScriptCore
2008-10-03 Darin Adler <Darin Adler>
Suggested by Alexey Proskuryakov.
- kjs/JSGlobalData.cpp: (JSC::JSGlobalData::~JSGlobalData): Remove call to heap.destroy() because it's too late to ref the JSGlobalData object once it's already being destroyed. In practice this is not a problem because WebCore's JSGlobalData is never destroyed and JSGlobalContextRelease takes care of calling heap.destroy() in advance.
- 9:02 AM Changeset in webkit [37239] by
-
- 5 edits in trunk
2008-10-03 Ariya Hidayat <ariya.hidayat@trolltech.com>
Build fix.
- platform/qt/WidgetQt.cpp: (WebCore::Widget::invalidateRect):
2008-10-03 Ariya Hidayat <ariya.hidayat@trolltech.com>
Build fix.
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::scroll):
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::): (WebCore::FrameLoaderClientQt::createPlugin):
- 6:36 AM Changeset in webkit [37238] by
-
- 6 edits in trunk
2008-10-03 Alp Toker <alp@nuanti.com>
Remove some left-over GTK+ includes. No change in functionality.
- 5:59 AM Changeset in webkit [37237] by
-
- 2 edits in trunk/WebKit/gtk
2008-10-03 Alp Toker <alp@nuanti.com>
Build fix following r37234. Remove addToDirtyRegion from the header
too.
- WebCoreSupport/ChromeClientGtk.h:
- 5:38 AM Changeset in webkit [37236] by
-
- 2 edits in trunk/WebCore
2008-10-03 Alp Toker <alp@nuanti.com>
Build fix for trailing comment after #endif
- dom/ElementRareData.h:
- 4:11 AM Changeset in webkit [37235] by
-
- 2 edits in trunk/JavaScriptCore
Replace SSE3 check with an SSE2 check, and implement SSE2 check on windows.
Reviewed by Maciej Stachowiak
5.6% win on SunSpider on windows.
- 2:03 AM Changeset in webkit [37234] by
-
- 19 edits in trunk
WebCore:
2008-10-03 David Hyatt <hyatt@apple.com>
Remove addToDirtyRegion.
Reviewed by Oliver Hunt
- page/Chrome.cpp:
- page/Chrome.h:
- page/ChromeClient.h:
- platform/ScrollView.h:
- platform/gtk/ScrollViewGtk.cpp:
- platform/qt/ScrollViewQt.cpp:
- platform/win/ScrollViewWin.cpp:
WebKit/gtk:
2008-10-03 David Hyatt <hyatt@apple.com>
Remove addToDirtyRegion.
Reviewed by Oliver Hunt
- WebCoreSupport/ChromeClientGtk.cpp:
WebKit/mac:
2008-10-03 David Hyatt <hyatt@apple.com>
Remove addToDirtyRegion.
Reviewed by Oliver Hunt
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
WebKit/qt:
2008-10-03 David Hyatt <hyatt@apple.com>
Remove addToDirtyRegion.
Reviewed by Oliver Hunt
- WebCoreSupport/ChromeClientQt.cpp:
WebKit/win:
2008-10-03 David Hyatt <hyatt@apple.com>
Remove addToDirtyRegion.
Reviewed by Oliver Hunt
- WebCoreSupport/WebChromeClient.cpp:
WebKit/wx:
2008-10-03 David Hyatt <hyatt@apple.com>
Remove addToDirtyRegion.
Reviewed by Oliver Hunt
- WebKitSupport/ChromeClientWx.cpp:
- 2:00 AM Changeset in webkit [37233] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej Stachowiak.
- fix a CachedResource leak introduced in r37176
Undo r37176 and instead allow pruneDeadResources() to be re-entered, but
afterwards bail out of the outer pruneDeadResources().
- loader/Cache.cpp: (WebCore::Cache::Cache): (WebCore::Cache::pruneDeadResources): (WebCore::Cache::remove):
- loader/Cache.h:
- 1:50 AM Changeset in webkit [37232] by
-
- 4 edits in trunk/WebCore
2008-10-03 David Hyatt <hyatt@apple.com>
Fix Gtk adjustments so that they are properly checked again before creating horizontal/vertical
scrollbars.
Reviewed by Oliver Hunt
- platform/ScrollView.cpp: (WebCore::ScrollView::setHasHorizontalScrollbar): (WebCore::ScrollView::setHasVerticalScrollbar): (WebCore::ScrollView::platformHasHorizontalAdjustment): (WebCore::ScrollView::platformHasVerticalAdjustment):
- platform/ScrollView.h:
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::adjustmentChanged): (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView): (WebCore::ScrollView::setGtkAdjustments): (WebCore::ScrollView::platformHandleHorizontalAdjustment): (WebCore::ScrollView::platformHandleVerticalAdjustment):
- 1:15 AM Changeset in webkit [37231] by
-
- 4 edits in trunk/WebCore
2008-10-03 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Maciej Stachowiak.
Bug 21106: .in format discussed changes
https://bugs.webkit.org/show_bug.cgi?id=21106
Change "upperCase" to "interfaceName" per-tag parameter as
discussed on the mailing list. Removed the per-attribute version
as it was not used.
Also add the "Element" suffix to all interfaceName parameter to match
the class name (and thus remove it from make_names.pl).
- dom/make_names.pl:
- html/HTMLTagNames.in:
- svg/svgtags.in:
- 12:52 AM Changeset in webkit [37230] by
-
- 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp
Another speculative Gtk scrolling fix.
- 12:52 AM Changeset in webkit [37229] by
-
- 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp
Another speculative Gtk scrolling fix.
- 12:51 AM Changeset in webkit [37228] by
-
- 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp
Another speculative Gtk scrolling fix.
- 12:47 AM Changeset in webkit [37227] by
-
- 2 edits in trunk/JavaScriptCore
2008-10-03 Maciej Stachowiak <mjs@apple.com>
Rubber stamped by Cameron Zwarich.
fix mistaken change of | to which caused a big perf regression on EarleyBoyer - kjs/grammar.y:
- 12:44 AM Changeset in webkit [37226] by
-
- 1 edit in trunk/WebCore/platform/ScrollView.h
Fix Qt bustage.
- 12:41 AM Changeset in webkit [37225] by
-
- 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp
Speculative fix for gtk not painting on scroll.
- 12:38 AM Changeset in webkit [37224] by
-
- 4 edits in trunk/WebCore
2008-10-03 David Hyatt <hyatt@apple.com>
Preserve Qt's disabling of blitting when any native widgets are present anywhere on the page (ick).
Hopefully this is a temporary hack that could eventually be removed.
Reviewed by Sam Weinig
- platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents):
- platform/ScrollView.h: (WebCore::ScrollView::rootPreventsBlitting):
- platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView): (WebCore::ScrollView::platformAddChild): (WebCore::ScrollView::platformRemoveChild):
- 12:06 AM Changeset in webkit [37223] by
-
- 31 edits in trunk
WebCore:
2008-10-02 David Hyatt <hyatt@apple.com>
Make widget invalidation more cross-platform.
(1) Make invalidateRect a pure virtual function on Widget. All leaf widgets must now implement this function.
(2) Scrollbars now send invalidations through the ScrollbarClient. windowClipRect on ScrollbarClient has been removed and replaced with this invalidation call.
This allows all scrollbar invalidations to go through the render tree so that transforms and reflections will be respected.
(3) Plugins now have the native window invalidation code for windowed plugins. Windowless plugins do a repaintRectangle on the plugin's renderer.
(4) FrameViews now do a repaintRectangle on their owner element's renderer.
Reviewed by Sam Weinig
- WebCore.base.exp:
- page/FrameView.cpp: (WebCore::FrameView::invalidateRect): (WebCore::FrameView::invalidateScrollbarRect):
- page/FrameView.h:
- platform/PopupMenu.h:
- platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents):
- platform/ScrollView.h:
- platform/Scrollbar.cpp: (WebCore::Scrollbar::setEnabled): (WebCore::Scrollbar::invalidateRect):
- platform/Scrollbar.h:
- platform/ScrollbarClient.h:
- platform/Widget.h:
- platform/gtk/WidgetGtk.cpp:
- platform/mac/WidgetMac.mm:
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::invalidateScrollbarRect):
- platform/win/WidgetWin.cpp:
- plugins/PluginView.cpp: (WebCore::PluginView::invalidateTimerFired): (WebCore::PluginView::invalidateWindowlessPluginRect):
- plugins/PluginView.h:
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::invalidateRect):
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::invalidateRect):
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::invalidateRect): (WebCore::PluginView::invalidateRegion):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::invalidateScrollbarRect):
- rendering/RenderLayer.h:
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): (WebCore::RenderListBox::paintScrollbar): (WebCore::RenderListBox::invalidateScrollbarRect):
- rendering/RenderListBox.h:
WebKit/mac:
2008-10-02 David Hyatt <hyatt@apple.com>
Make widget invalidation more cross-platform.
(1) Make invalidateRect a pure virtual function on Widget. All leaf widgets must now implement this function.
(2) Scrollbars now send invalidations through the ScrollbarClient. windowClipRect on ScrollbarClient has been removed and replaced with this invalidation call.
This allows all scrollbar invalidations to go through the render tree so that transforms and reflections will be respected.
(3) Plugins now have the native window invalidation code for windowed plugins. Windowless plugins do a repaintRectangle on the plugin's renderer.
(4) FrameViews now do a repaintRectangle on their owner element's renderer.
Reviewed by Sam Weinig
- WebCoreSupport/WebFrameLoaderClient.mm: (PluginWidget::PluginWidget): (PluginWidget::invalidateRect): (NetscapePluginWidget::NetscapePluginWidget): (WebFrameLoaderClient::createPlugin):
WebKit/win:
2008-10-02 David Hyatt <hyatt@apple.com>
Make widget invalidation more cross-platform.
(1) Make invalidateRect a pure virtual function on Widget. All leaf widgets must now implement this function.
(2) Scrollbars now send invalidations through the ScrollbarClient. windowClipRect on ScrollbarClient has been removed and replaced with this invalidation call.
This allows all scrollbar invalidations to go through the render tree so that transforms and reflections will be respected.
(3) Plugins now have the native window invalidation code for windowed plugins. Windowless plugins do a repaintRectangle on the plugin's renderer.
(4) FrameViews now do a repaintRectangle on their owner element's renderer.
Reviewed by Sam Weinig
- WebCoreSupport/EmbeddedWidget.cpp: (EmbeddedWidget::invalidateRect):
- WebCoreSupport/EmbeddedWidget.h:
- WebScrollBar.cpp: (WebScrollBar::invalidateScrollbarRect):
- WebScrollBar.h:
