Context Navigation

editing/Editor.cpp: (WebCore::Editor::ignoreSpelling): Remove misspelling markers from the word. (WebCore::Editor::learnSpelling): Added a FIXME about <rdar://problem/5396072>, which will probably require a change more complicated than just marking the learned word as misspelled. I'll address it with a separate patch.
editing/EditorCommand.cpp: (WebCore::executeIgnoreSpelling): Added. (WebCore::CommandEntry::): Added an entry for IgnoreSpelling.

WebKit/mac:

2008-10-28 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin Adler.

<rdar://problem/5188560> REGRESSION: Spell checker doesn't clear spelling/grammar marker after error is marked as Ignored

WebView/WebHTMLView.mm: IgnoreSpelling is now a WebCore command. That command handles calling back into WebKit to perform the cross platform work that was removed in this change.

6:54 PM Changeset in webkit [37956] by cwzwarich@webkit.org

77 edits
27 moves
2 adds in trunk

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Reviewed by Mark Rowe.

Move ForwardingHeaders to their correct location after the creation of
the runtime directory in JavaScriptCore.

WebCore:

ForwardingHeaders/kjs/ArrayPrototype.h: Removed.
ForwardingHeaders/kjs/BooleanObject.h: Removed.
ForwardingHeaders/kjs/CallData.h: Removed.
ForwardingHeaders/kjs/ConstructData.h: Removed.
ForwardingHeaders/kjs/DateInstance.h: Removed.
ForwardingHeaders/kjs/Error.h: Removed.
ForwardingHeaders/kjs/FunctionConstructor.h: Removed.
ForwardingHeaders/kjs/FunctionPrototype.h: Removed.
ForwardingHeaders/kjs/InternalFunction.h: Removed.
ForwardingHeaders/kjs/JSArray.h: Removed.
ForwardingHeaders/kjs/JSFunction.h: Removed.
ForwardingHeaders/kjs/JSGlobalObject.h: Removed.
ForwardingHeaders/kjs/JSNumberCell.h: Removed.
ForwardingHeaders/kjs/JSObject.h: Removed.
ForwardingHeaders/kjs/JSString.h: Removed.
ForwardingHeaders/kjs/JSValue.h: Removed.
ForwardingHeaders/kjs/ObjectPrototype.h: Removed.
ForwardingHeaders/kjs/PropertyMap.h: Removed.
ForwardingHeaders/kjs/PrototypeFunction.h: Removed.
ForwardingHeaders/kjs/StringObject.h: Removed.
ForwardingHeaders/kjs/StringObjectThatMasqueradesAsUndefined.h: Removed.
ForwardingHeaders/kjs/StringPrototype.h: Removed.
ForwardingHeaders/kjs/StructureID.h: Removed.
ForwardingHeaders/runtime: Added.
ForwardingHeaders/runtime/ArrayPrototype.h: Copied from ForwardingHeaders/kjs/ArrayPrototype.h.
ForwardingHeaders/runtime/BooleanObject.h: Copied from ForwardingHeaders/kjs/BooleanObject.h.
ForwardingHeaders/runtime/CallData.h: Copied from ForwardingHeaders/kjs/CallData.h.
ForwardingHeaders/runtime/ConstructData.h: Copied from ForwardingHeaders/kjs/ConstructData.h.
ForwardingHeaders/runtime/DateInstance.h: Copied from ForwardingHeaders/kjs/DateInstance.h.
ForwardingHeaders/runtime/Error.h: Copied from ForwardingHeaders/kjs/Error.h.
ForwardingHeaders/runtime/FunctionConstructor.h: Copied from ForwardingHeaders/kjs/FunctionConstructor.h.
ForwardingHeaders/runtime/FunctionPrototype.h: Copied from ForwardingHeaders/kjs/FunctionPrototype.h.
ForwardingHeaders/runtime/InternalFunction.h: Copied from ForwardingHeaders/kjs/InternalFunction.h.
ForwardingHeaders/runtime/JSArray.h: Copied from ForwardingHeaders/kjs/JSArray.h.
ForwardingHeaders/runtime/JSFunction.h: Copied from ForwardingHeaders/kjs/JSFunction.h.
ForwardingHeaders/runtime/JSGlobalObject.h: Copied from ForwardingHeaders/kjs/JSGlobalObject.h.
ForwardingHeaders/runtime/JSNumberCell.h: Copied from ForwardingHeaders/kjs/JSNumberCell.h.
ForwardingHeaders/runtime/JSObject.h: Copied from ForwardingHeaders/kjs/JSObject.h.
ForwardingHeaders/runtime/JSString.h: Copied from ForwardingHeaders/kjs/JSString.h.
ForwardingHeaders/runtime/JSValue.h: Copied from ForwardingHeaders/kjs/JSValue.h.
ForwardingHeaders/runtime/ObjectPrototype.h: Copied from ForwardingHeaders/kjs/ObjectPrototype.h.
ForwardingHeaders/runtime/PropertyMap.h: Copied from ForwardingHeaders/kjs/PropertyMap.h.
ForwardingHeaders/runtime/PrototypeFunction.h: Copied from ForwardingHeaders/kjs/PrototypeFunction.h.
ForwardingHeaders/runtime/StringObject.h: Copied from ForwardingHeaders/kjs/StringObject.h.
ForwardingHeaders/runtime/StringObjectThatMasqueradesAsUndefined.h: Copied from ForwardingHeaders/kjs/StringObjectThatMasqueradesAsUndefined.h.
ForwardingHeaders/runtime/StringPrototype.h: Copied from ForwardingHeaders/kjs/StringPrototype.h.
ForwardingHeaders/runtime/StructureID.h: Copied from ForwardingHeaders/kjs/StructureID.h.
bindings/js/JSCSSStyleDeclarationCustom.cpp:
bindings/js/JSCanvasRenderingContext2DCustom.cpp:
bindings/js/JSClipboardCustom.cpp:
bindings/js/JSConsoleCustom.cpp:
bindings/js/JSCustomPositionCallback.h:
bindings/js/JSCustomPositionErrorCallback.h:
bindings/js/JSCustomSQLStatementCallback.h:
bindings/js/JSCustomSQLStatementErrorCallback.h:
bindings/js/JSCustomSQLTransactionErrorCallback.h:
bindings/js/JSCustomVoidCallback.h:
bindings/js/JSCustomXPathNSResolver.h:
bindings/js/JSDOMBinding.cpp:
bindings/js/JSDOMBinding.h:
bindings/js/JSDOMGlobalObject.h:
bindings/js/JSDOMWindowBase.cpp:
bindings/js/JSDOMWindowCustom.cpp:
bindings/js/JSDOMWindowShell.cpp:
bindings/js/JSDatabaseCustom.cpp:
bindings/js/JSEventListener.cpp:
bindings/js/JSEventTarget.h:
bindings/js/JSHTMLDocumentCustom.cpp:
bindings/js/JSHistoryCustom.cpp:
bindings/js/JSInspectedObjectWrapper.cpp:
bindings/js/JSJavaScriptCallFrameCustom.cpp:
bindings/js/JSLocationCustom.cpp:
bindings/js/JSNodeFilterCondition.h:
bindings/js/JSQuarantinedObjectWrapper.cpp:
bindings/js/JSQuarantinedObjectWrapper.h:
bindings/js/JSXMLHttpRequestCustom.cpp:
bindings/js/JSXMLHttpRequestUploadCustom.cpp:
bindings/objc/WebScriptObject.mm:
bindings/objc/WebScriptObjectPrivate.h:
bindings/scripts/CodeGeneratorJS.pm:
bridge/NP_jsobject.cpp:
bridge/c/c_instance.cpp:
bridge/c/c_utility.cpp:
bridge/c/c_utility.h:
bridge/jni/jni_instance.cpp:
bridge/jni/jni_jsobject.h:
bridge/jni/jni_jsobject.mm:
bridge/jni/jni_runtime.cpp:
bridge/jni/jni_utility.cpp:
bridge/jni/jni_utility.h:
bridge/objc/objc_instance.mm:
bridge/objc/objc_runtime.h:
bridge/objc/objc_runtime.mm:
bridge/objc/objc_utility.h:
bridge/objc/objc_utility.mm:
bridge/runtime.h:
bridge/runtime_array.cpp:
bridge/runtime_array.h:
bridge/runtime_method.cpp:
bridge/runtime_method.h:
bridge/runtime_object.cpp:
bridge/runtime_object.h:
bridge/runtime_root.cpp:
inspector/JavaScriptCallFrame.cpp:
inspector/JavaScriptProfile.cpp:
inspector/JavaScriptProfile.h:
inspector/JavaScriptProfileNode.cpp:
inspector/JavaScriptProfileNode.h:
loader/FrameLoader.cpp:
page/Console.cpp:
plugins/PluginView.cpp:
plugins/gtk/PluginViewGtk.cpp:
plugins/qt/PluginViewQt.cpp:
plugins/win/PluginViewWin.cpp:

WebKit/mac:

ForwardingHeaders/kjs/JSFunction.h: Removed.
ForwardingHeaders/kjs/JSObject.h: Removed.
ForwardingHeaders/kjs/JSString.h: Removed.
ForwardingHeaders/kjs/JSValue.h: Removed.
ForwardingHeaders/runtime: Added.
ForwardingHeaders/runtime/JSFunction.h: Copied from ForwardingHeaders/kjs/JSFunction.h.
ForwardingHeaders/runtime/JSObject.h: Copied from ForwardingHeaders/kjs/JSObject.h.
ForwardingHeaders/runtime/JSString.h: Copied from ForwardingHeaders/kjs/JSString.h.
ForwardingHeaders/runtime/JSValue.h: Copied from ForwardingHeaders/kjs/JSValue.h.
WebView/WebScriptDebugDelegate.mm:
WebView/WebScriptDebugger.mm:
WebView/WebView.mm:

WebKit/win:

WebScriptCallFrame.h:

WebKit/wx:

WebFrame.cpp:
WebView.cpp:

5:57 PM Changeset in webkit [37955] by mitz@apple.com

2 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

export WTF::atomicallyInitializedStaticMutex

JavaScriptCore.exp:

5:37 PM Changeset in webkit [37954] by adele@apple.com

2 edits in trunk/WebCore

2008-10-28 Adele Peterson <adele@apple.com>

Windows build fix. This removes Cairo include directories from non-Cairbo build configurations.

WebCore.vcproj/WebCore.vcproj:

5:20 PM Changeset in webkit [37953] by adele@apple.com

2 edits in trunk/WebCore

2008-10-28 Adele Peterson <adele@apple.com>

Build fix.

platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::create):

5:12 PM Changeset in webkit [37952] by cwzwarich@webkit.org

2 edits in trunk/WebCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Roll out a mistaken attempt at fixing the GTK build in r37947.

GNUmakefile.am:

5:11 PM Changeset in webkit [37951] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2005-10-28 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.

Fixed CodeBlock dumping to accurately report constant register indices.

VM/CodeBlock.cpp: (JSC::CodeBlock::dump):

5:04 PM Changeset in webkit [37950] by alp@webkit.org

2 edits in trunk/WebKitTools

2008-10-28 Alp Toker <alp@nuanti.com>

Reviewed by Mark Rowe.

Fix recently introduced double-free crashes in GTK DRT.

LayoutTestController was made ref-counted in r36606 and Mac/Win DRT
were updated to call ->deref() but GTK DRT was still deleting
gLayoutTestController manually. This patch updates GTK to match the
other ports and resolves the memory allocation issues.

DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest):

4:36 PM Changeset in webkit [37949] by adele@apple.com

15 edits in trunk

WebCore:

2008-10-28 Adele Peterson <adele@apple.com>

Reviewed by John Sullivan.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
"files" string for multifile uploads needs to be localized

page/mac/WebCoreViewFactory.h:
platform/LocalizedStrings.h:
platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth):
platform/gtk/LocalizedStringsGtk.cpp: (WebCore::multipleFileUploadText):
platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth):
platform/mac/LocalizedStringsMac.mm: (WebCore::multipleFileUploadText):
platform/qt/Localizations.cpp: (WebCore::multipleFileUploadText):
platform/wx/LocalizedStringsWx.cpp: (WebCore::multipleFileUploadText):

WebKit:

2008-10-28 Adele Peterson <adele@apple.com>

Reviewed by John Sullivan.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
"files" string for multifile uploads needs to be localized

English.lproj/Localizable.strings: Updated with new string.

WebKit/mac:

2008-10-28 Adele Peterson <adele@apple.com>

Reviewed by John Sullivan.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
"files" string for multifile uploads needs to be localized

WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory multipleFileUploadTextForNumberOfFiles:]): Added.

WebKit/win:

2008-10-28 Adele Peterson <adele@apple.com>

Reviewed by John Sullivan.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
"files" string for multifile uploads needs to be localized

WebCoreLocalizedStrings.cpp: (multipleFileUploadText):

4:10 PM Changeset in webkit [37948] by brettw@chromium.org

6 edits
3 adds in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21816

Remove platform ifdefs in ImageBuffer.h by moving platform specific code
into a new PlatformImageBuffer class. Move the static create function
into the header because it can be cross-platform. Initialization now
happens in the cunstructor which sets a flag that create uses to know
whether it should return null or not. I also made passing of IntSize
more consistent (always by reference).

This change also changes the ifdefs in GraphicsContext to allow Skia
ports to implement text drawing modes.

3:22 PM Changeset in webkit [37947] by cwzwarich@webkit.org

2 edits in trunk/WebCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the GTK build.

GNUmakefile.am:

3:14 PM Changeset in webkit [37946] by cwzwarich@webkit.org

2 edits in trunk/WebCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Another Qt build fix.

WebCore.pro:

3:04 PM Changeset in webkit [37945] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

More Qt build fixes.

JavaScriptCore.pri:

2:59 PM Changeset in webkit [37944] by alp@webkit.org

2 edits in trunk/WebKitTools

2008-10-28 Alp Toker <alp@nuanti.com>

Reviewed by Mark Rowe.

Fix GTK DRT hang when running the tests.

Update output from the DRT tool to print an additional '#EOF' to match
breaking changes that were made in r37434.

DumpRenderTree/gtk/DumpRenderTree.cpp: (dump):

2:52 PM Changeset in webkit [37943] by timothy@apple.com

1 edit in trunk/WebKit/win/WebInspector.cpp

Windows build fix.

2:43 PM Changeset in webkit [37942] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the Qt build, hopefully for real this time.

JavaScriptCore.pri:

2:42 PM Changeset in webkit [37941] by ddkilzer@apple.com

2 edits in trunk/WebCore

2008-10-28 Greg Bolsinga <bolsinga@apple.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=21932
Add non-pointer constant lookups to SoftLinking.h

platform/mac/SoftLinking.h:

2:36 PM Changeset in webkit [37940] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the Qt build.

JavaScriptCore.pri:

2:26 PM Changeset in webkit [37939] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the Windows build.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

2:06 PM Changeset in webkit [37938] by cwzwarich@webkit.org

17 edits
99 moves
1 add in trunk/JavaScriptCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Create a runtime directory in JavaScriptCore and begin moving files to
it. This is the first step towards removing the kjs directory and
placing files in more meaningful subdirectories of JavaScriptCore.

API/JSBase.cpp:
API/JSCallbackConstructor.cpp:
API/JSCallbackConstructor.h:
API/JSCallbackFunction.cpp:
API/JSClassRef.cpp:
API/JSClassRef.h:
API/JSStringRefCF.cpp:
API/JSValueRef.cpp:
API/OpaqueJSString.cpp:
DerivedSources.make:
GNUmakefile.am:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
kjs/AllInOneFile.cpp:
kjs/ArrayConstructor.cpp: Removed.
kjs/ArrayConstructor.h: Removed.
kjs/ArrayPrototype.cpp: Removed.
kjs/ArrayPrototype.h: Removed.
kjs/BooleanConstructor.cpp: Removed.
kjs/BooleanConstructor.h: Removed.
kjs/BooleanObject.cpp: Removed.
kjs/BooleanObject.h: Removed.
kjs/BooleanPrototype.cpp: Removed.
kjs/BooleanPrototype.h: Removed.
kjs/CallData.cpp: Removed.
kjs/CallData.h: Removed.
kjs/ClassInfo.h: Removed.
kjs/ConstructData.cpp: Removed.
kjs/ConstructData.h: Removed.
kjs/DateConstructor.cpp: Removed.
kjs/DateConstructor.h: Removed.
kjs/DateInstance.cpp: Removed.
kjs/DateInstance.h: Removed.
kjs/DateMath.cpp: Removed.
kjs/DateMath.h: Removed.
kjs/DatePrototype.cpp: Removed.
kjs/DatePrototype.h: Removed.
kjs/Error.cpp: Removed.
kjs/Error.h: Removed.
kjs/ErrorConstructor.cpp: Removed.
kjs/ErrorConstructor.h: Removed.
kjs/ErrorInstance.cpp: Removed.
kjs/ErrorInstance.h: Removed.
kjs/ErrorPrototype.cpp: Removed.
kjs/ErrorPrototype.h: Removed.
kjs/FunctionConstructor.cpp: Removed.
kjs/FunctionConstructor.h: Removed.
kjs/FunctionPrototype.cpp: Removed.
kjs/FunctionPrototype.h: Removed.
kjs/GlobalEvalFunction.cpp: Removed.
kjs/GlobalEvalFunction.h: Removed.
kjs/InternalFunction.cpp: Removed.
kjs/InternalFunction.h: Removed.
kjs/JSArray.cpp: Removed.
kjs/JSArray.h: Removed.
kjs/JSCell.cpp: Removed.
kjs/JSCell.h: Removed.
kjs/JSFunction.cpp: Removed.
kjs/JSFunction.h: Removed.
kjs/JSGlobalObject.cpp: Removed.
kjs/JSGlobalObject.h: Removed.
kjs/JSGlobalObjectFunctions.cpp: Removed.
kjs/JSGlobalObjectFunctions.h: Removed.
kjs/JSImmediate.cpp: Removed.
kjs/JSImmediate.h: Removed.
kjs/JSNotAnObject.cpp: Removed.
kjs/JSNotAnObject.h: Removed.
kjs/JSNumberCell.cpp: Removed.
kjs/JSNumberCell.h: Removed.
kjs/JSObject.cpp: Removed.
kjs/JSObject.h: Removed.
kjs/JSString.cpp: Removed.
kjs/JSString.h: Removed.
kjs/JSValue.cpp: Removed.
kjs/JSValue.h: Removed.
kjs/JSVariableObject.cpp: Removed.
kjs/JSVariableObject.h: Removed.
kjs/JSWrapperObject.cpp: Removed.
kjs/JSWrapperObject.h: Removed.
kjs/MathObject.cpp: Removed.
kjs/MathObject.h: Removed.
kjs/NativeErrorConstructor.cpp: Removed.
kjs/NativeErrorConstructor.h: Removed.
kjs/NativeErrorPrototype.cpp: Removed.
kjs/NativeErrorPrototype.h: Removed.
kjs/NumberConstructor.cpp: Removed.
kjs/NumberConstructor.h: Removed.
kjs/NumberObject.cpp: Removed.
kjs/NumberObject.h: Removed.
kjs/NumberPrototype.cpp: Removed.
kjs/NumberPrototype.h: Removed.
kjs/ObjectConstructor.cpp: Removed.
kjs/ObjectConstructor.h: Removed.
kjs/ObjectPrototype.cpp: Removed.
kjs/ObjectPrototype.h: Removed.
kjs/PropertyMap.cpp: Removed.
kjs/PropertyMap.h: Removed.
kjs/PropertySlot.cpp: Removed.
kjs/PropertySlot.h: Removed.
kjs/PrototypeFunction.cpp: Removed.
kjs/PrototypeFunction.h: Removed.
kjs/PutPropertySlot.h: Removed.
kjs/SmallStrings.cpp: Removed.
kjs/SmallStrings.h: Removed.
kjs/StringConstructor.cpp: Removed.
kjs/StringConstructor.h: Removed.
kjs/StringObject.cpp: Removed.
kjs/StringObject.h: Removed.
kjs/StringObjectThatMasqueradesAsUndefined.h: Removed.
kjs/StringPrototype.cpp: Removed.
kjs/StringPrototype.h: Removed.
kjs/StructureID.cpp: Removed.
kjs/StructureID.h: Removed.
kjs/completion.h:
kjs/interpreter.h:
runtime: Added.
runtime/ArrayConstructor.cpp: Copied from kjs/ArrayConstructor.cpp.
runtime/ArrayConstructor.h: Copied from kjs/ArrayConstructor.h.
runtime/ArrayPrototype.cpp: Copied from kjs/ArrayPrototype.cpp.
runtime/ArrayPrototype.h: Copied from kjs/ArrayPrototype.h.
runtime/BooleanConstructor.cpp: Copied from kjs/BooleanConstructor.cpp.
runtime/BooleanConstructor.h: Copied from kjs/BooleanConstructor.h.
runtime/BooleanObject.cpp: Copied from kjs/BooleanObject.cpp.
runtime/BooleanObject.h: Copied from kjs/BooleanObject.h.
runtime/BooleanPrototype.cpp: Copied from kjs/BooleanPrototype.cpp.
runtime/BooleanPrototype.h: Copied from kjs/BooleanPrototype.h.
runtime/CallData.cpp: Copied from kjs/CallData.cpp.
runtime/CallData.h: Copied from kjs/CallData.h.
runtime/ClassInfo.h: Copied from kjs/ClassInfo.h.
runtime/ConstructData.cpp: Copied from kjs/ConstructData.cpp.
runtime/ConstructData.h: Copied from kjs/ConstructData.h.
runtime/DateConstructor.cpp: Copied from kjs/DateConstructor.cpp.
runtime/DateConstructor.h: Copied from kjs/DateConstructor.h.
runtime/DateInstance.cpp: Copied from kjs/DateInstance.cpp.
runtime/DateInstance.h: Copied from kjs/DateInstance.h.
runtime/DateMath.cpp: Copied from kjs/DateMath.cpp.
runtime/DateMath.h: Copied from kjs/DateMath.h.
runtime/DatePrototype.cpp: Copied from kjs/DatePrototype.cpp.
runtime/DatePrototype.h: Copied from kjs/DatePrototype.h.
runtime/Error.cpp: Copied from kjs/Error.cpp.
runtime/Error.h: Copied from kjs/Error.h.
runtime/ErrorConstructor.cpp: Copied from kjs/ErrorConstructor.cpp.
runtime/ErrorConstructor.h: Copied from kjs/ErrorConstructor.h.
runtime/ErrorInstance.cpp: Copied from kjs/ErrorInstance.cpp.
runtime/ErrorInstance.h: Copied from kjs/ErrorInstance.h.
runtime/ErrorPrototype.cpp: Copied from kjs/ErrorPrototype.cpp.
runtime/ErrorPrototype.h: Copied from kjs/ErrorPrototype.h.
runtime/FunctionConstructor.cpp: Copied from kjs/FunctionConstructor.cpp.
runtime/FunctionConstructor.h: Copied from kjs/FunctionConstructor.h.
runtime/FunctionPrototype.cpp: Copied from kjs/FunctionPrototype.cpp.
runtime/FunctionPrototype.h: Copied from kjs/FunctionPrototype.h.
runtime/GlobalEvalFunction.cpp: Copied from kjs/GlobalEvalFunction.cpp.
runtime/GlobalEvalFunction.h: Copied from kjs/GlobalEvalFunction.h.
runtime/InternalFunction.cpp: Copied from kjs/InternalFunction.cpp.
runtime/InternalFunction.h: Copied from kjs/InternalFunction.h.
runtime/JSArray.cpp: Copied from kjs/JSArray.cpp.
runtime/JSArray.h: Copied from kjs/JSArray.h.
runtime/JSCell.cpp: Copied from kjs/JSCell.cpp.
runtime/JSCell.h: Copied from kjs/JSCell.h.
runtime/JSFunction.cpp: Copied from kjs/JSFunction.cpp.
runtime/JSFunction.h: Copied from kjs/JSFunction.h.
runtime/JSGlobalObject.cpp: Copied from kjs/JSGlobalObject.cpp.
runtime/JSGlobalObject.h: Copied from kjs/JSGlobalObject.h.
runtime/JSGlobalObjectFunctions.cpp: Copied from kjs/JSGlobalObjectFunctions.cpp.
runtime/JSGlobalObjectFunctions.h: Copied from kjs/JSGlobalObjectFunctions.h.
runtime/JSImmediate.cpp: Copied from kjs/JSImmediate.cpp.
runtime/JSImmediate.h: Copied from kjs/JSImmediate.h.
runtime/JSNotAnObject.cpp: Copied from kjs/JSNotAnObject.cpp.
runtime/JSNotAnObject.h: Copied from kjs/JSNotAnObject.h.
runtime/JSNumberCell.cpp: Copied from kjs/JSNumberCell.cpp.
runtime/JSNumberCell.h: Copied from kjs/JSNumberCell.h.
runtime/JSObject.cpp: Copied from kjs/JSObject.cpp.
runtime/JSObject.h: Copied from kjs/JSObject.h.
runtime/JSString.cpp: Copied from kjs/JSString.cpp.
runtime/JSString.h: Copied from kjs/JSString.h.
runtime/JSValue.cpp: Copied from kjs/JSValue.cpp.
runtime/JSValue.h: Copied from kjs/JSValue.h.
runtime/JSVariableObject.cpp: Copied from kjs/JSVariableObject.cpp.
runtime/JSVariableObject.h: Copied from kjs/JSVariableObject.h.
runtime/JSWrapperObject.cpp: Copied from kjs/JSWrapperObject.cpp.
runtime/JSWrapperObject.h: Copied from kjs/JSWrapperObject.h.
runtime/MathObject.cpp: Copied from kjs/MathObject.cpp.
runtime/MathObject.h: Copied from kjs/MathObject.h.
runtime/NativeErrorConstructor.cpp: Copied from kjs/NativeErrorConstructor.cpp.
runtime/NativeErrorConstructor.h: Copied from kjs/NativeErrorConstructor.h.
runtime/NativeErrorPrototype.cpp: Copied from kjs/NativeErrorPrototype.cpp.
runtime/NativeErrorPrototype.h: Copied from kjs/NativeErrorPrototype.h.
runtime/NumberConstructor.cpp: Copied from kjs/NumberConstructor.cpp.
runtime/NumberConstructor.h: Copied from kjs/NumberConstructor.h.
runtime/NumberObject.cpp: Copied from kjs/NumberObject.cpp.
runtime/NumberObject.h: Copied from kjs/NumberObject.h.
runtime/NumberPrototype.cpp: Copied from kjs/NumberPrototype.cpp.
runtime/NumberPrototype.h: Copied from kjs/NumberPrototype.h.
runtime/ObjectConstructor.cpp: Copied from kjs/ObjectConstructor.cpp.
runtime/ObjectConstructor.h: Copied from kjs/ObjectConstructor.h.
runtime/ObjectPrototype.cpp: Copied from kjs/ObjectPrototype.cpp.
runtime/ObjectPrototype.h: Copied from kjs/ObjectPrototype.h.
runtime/PropertyMap.cpp: Copied from kjs/PropertyMap.cpp.
runtime/PropertyMap.h: Copied from kjs/PropertyMap.h.
runtime/PropertySlot.cpp: Copied from kjs/PropertySlot.cpp.
runtime/PropertySlot.h: Copied from kjs/PropertySlot.h.
runtime/PrototypeFunction.cpp: Copied from kjs/PrototypeFunction.cpp.
runtime/PrototypeFunction.h: Copied from kjs/PrototypeFunction.h.
runtime/PutPropertySlot.h: Copied from kjs/PutPropertySlot.h.
runtime/SmallStrings.cpp: Copied from kjs/SmallStrings.cpp.
runtime/SmallStrings.h: Copied from kjs/SmallStrings.h.
runtime/StringConstructor.cpp: Copied from kjs/StringConstructor.cpp.
runtime/StringConstructor.h: Copied from kjs/StringConstructor.h.
runtime/StringObject.cpp: Copied from kjs/StringObject.cpp.
runtime/StringObject.h: Copied from kjs/StringObject.h.
runtime/StringObjectThatMasqueradesAsUndefined.h: Copied from kjs/StringObjectThatMasqueradesAsUndefined.h.
runtime/StringPrototype.cpp: Copied from kjs/StringPrototype.cpp.
runtime/StringPrototype.h: Copied from kjs/StringPrototype.h.
runtime/StructureID.cpp: Copied from kjs/StructureID.cpp.
runtime/StructureID.h: Copied from kjs/StructureID.h.

2:01 PM Changeset in webkit [37937] by ddkilzer@apple.com

2 edits in trunk/WebCore

2008-10-28 Greg Bolsinga <bolsinga@apple.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=2192
Missing semi-colons in Geoposition.idl

page/Geoposition.idl: Add missing semi-colons

1:55 PM Changeset in webkit [37936] by adele@apple.com

7 edits
1 delete in trunk

WebKit:

2008-10-28 Adele Peterson <adele@apple.com>

Reviewed by Sam Weinig.

English.lproj/Localizable.strings: Updated.

WebKit/win:

2008-10-28 Adele Peterson <adele@apple.com>

Reviewed by Sam Weinig.

English.lproj: Removed.
English.lproj/Localizable.strings: Removed.
WebKit.vcproj/WebKit.vcproj: Updated to use Localizable.strings in the top directory, to share with the Mac.

WebKitTools:

2008-10-28 Adele Peterson <adele@apple.com>

Reviewed by Sam Weinig.

Specify which Localizable.strings to update since we don't always want to update the file in the same
directory where we're searching for the strings to localize.

Scripts/extract-localizable-strings:
Scripts/update-webkit-localizable-strings:

1:48 PM Changeset in webkit [37935] by timothy@apple.com

3 edits in trunk/WebCore/inspector/front-end/Images

Set svn:mime-type to image/png for the new images I just added.

1:42 PM Changeset in webkit [37934] by timothy@apple.com

2 edits in trunk/LayoutTests

Remove fast/profiler from the skipped list for Tiger since the fix
for <rdar://problem/6211578> should make things work.

<rdar://problem/6316530> Profiler tests fail on Tiger

Reviewed by Kevin McCullough.

platform/mac-tiger/Skipped:

1:42 PM Changeset in webkit [37933] by timothy@apple.com

114 edits
4 adds
1 delete in trunk

Make the JavaScript profiler opt-in, so it does not slow down JavaScript all the time.
Make the Profiles panel in the Web Inspector have an enable screen.
Profiling now needs to be enabled before console.profile() works.

WebCore:

2008-10-27 Timothy Hatcher <timothy@apple.com>

Make the Profiles panel in the Web Inspector have an enable screen.
Profiling now needs to be enabled before console.profile() works.

<rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
not slow down JavaScript all the time

Reviewed by Darin Adler and Kevin McCullough.

English.lproj/localizedStrings.js: New strings.
WebCore.base.exp: New and changed exports.
WebCore.vcproj/WebCore.vcproj: Add the PanelEnablerView.js file.
bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::supportsProfiling): Call InspectorController:profilerEnabled.
inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): Initialize the m_startProfiling Timer to call InspectorController::startUserInitiatedProfiling. (WebCore::InspectorController::startUserInitiatedProfilingSoon): Start a one-shot timer that calls InspectorController::startUserInitiatedProfiling. (WebCore::InspectorController::startUserInitiatedProfiling): Recompile all JavaScript and enable the profiler if the profiler was not enabled. (WebCore::InspectorController::stopUserInitiatedProfiling): Rearrange code for readability. (WebCore::InspectorController::enableProfiler): Recompile all the JavaScript functions if the skipRecompile argument is false. Call the profilerWasEnabled script function. (WebCore::InspectorController::disableProfiler): Recompile all the JavaScript functions. Call the profilerWasEnabled script function. (WebCore::InspectorController::disableDebugger): Set m_attachDebuggerWhenShown to false, so it won't be started later.
inspector/InspectorController.h: (WebCore::InspectorController::profilerEnabled): Return enabled() && m_profilerEnabled.
inspector/front-end/Images/debuggingButtons.png: Remove.
inspector/front-end/Images/enableButtons.png: Added.
inspector/front-end/Images/profilesSilhouette.png: Added.
inspector/front-end/Images/scriptsSilhouette.png: Added.
inspector/front-end/PanelEnablerView.js: Added. (WebInspector.PanelEnablerView): (WebInspector.PanelEnablerView.prototype._enableButtonCicked): Fire the "enable clicked" event so listeners can do their thing. (WebInspector.PanelEnablerView.prototype._windowResized): Test if the icon should be hidden.
inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): Create the PanelEnablerView and the strings needed for it. (WebInspector.ProfilesPanel.prototype.get statusBarItems): Include the enableToggleButton. (WebInspector.ProfilesPanel.prototype.profilerWasEnabled): Call reset and populateInterface. (WebInspector.ProfilesPanel.prototype.profilerWasDisabled): Call reset. (WebInspector.ProfilesPanel.prototype.reset): Call _updateInterface. (WebInspector.ProfilesPanel.prototype.setRecordingProfile): Moved in the code, no changes. (WebInspector.ProfilesPanel.prototype._updateInterface): Update the toggle button and show/hide other buttons. Also show/hide the PanelEnablerView. (WebInspector.ProfilesPanel.prototype._enableProfiling): Call _toggleProfiling if not enabled. (WebInspector.ProfilesPanel.prototype._toggleProfiling): Call InspectorController's disableProfiler or enableProfiler.
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): Replace the overlay element with a PanelEnablerView. Replace the debuggingButton with the enableToggleButton. (WebInspector.ScriptsPanel.prototype.get statusBarItems): Replace the debuggingButton with the enableToggleButton. (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): Hide/show the pauseOnExceptionButton when needed. Replace the overlay element with a PanelEnablerView. Replace the debuggingButton with the enableToggleButton. (WebInspector.ScriptsPanel.prototype._enableDebugging): Call _toggleDebugging when not enabled. (WebInspector.ScriptsPanel.prototype._toggleDebugging): Remove the call to _clearInterface, since reset is called from debuggerWasEnabled and debuggerWasDisabled.
inspector/front-end/View.js: Inherit from WebInspector.Object.
inspector/front-end/WebKit.qrc: Add the PanelEnablerView.js file.
inspector/front-end/inspector.css: New styles for the PanelEnablerView.
inspector/front-end/inspector.html: Add the PanelEnablerView.js file.
inspector/front-end/inspector.js: (WebInspector.profilerWasEnabled): Added. Calls the ProfilesPanel. (WebInspector.profilerWasDisabled): Ditto.
page/Console.cpp: (WebCore::Console::error): Remove null check for m_frame, since m_frame isn't used. (WebCore::Console::info): Ditto. (WebCore::Console::log): Ditto. (WebCore::Console::assertCondition): Ditto. (WebCore::Console::dirxml): Remove null check for m_frame and use this->page(). (WebCore::Console::count): Ditto. (WebCore::Console::profile): Return early if InspectorController::profilerEnabled is false. (WebCore::Console::profileEnd): Ditto. (WebCore::Console::warn): Remove null check for m_frame, since m_frame isn't used.
page/Settings.cpp: (WebCore::Settings::Settings): Remove initialization of m_didInitializeDeveloperExtrasEnabled. (WebCore::Settings::setDeveloperExtrasEnabled): Remove code that recompiled functions. Now just sets the member boolean.
page/Settings.h: Remove m_didInitializeDeveloperExtrasEnabled.

WebKit/mac:

2008-10-28 Timothy Hatcher <timothy@apple.com>

Add WebInspector methods to enable the profiler.

https://bugs.webkit.org/show_bug.cgi?id=21927

<rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
not slow down JavaScript all the time

Reviewed by Darin Adler and Kevin McCullough.

WebInspector/WebInspector.h:
WebInspector/WebInspector.mm: (-isJavaScriptProfilingEnabled): Added. Calls InspectorController::profilerEnabled. (-setJavaScriptProfilingEnabled:): Added. Call InspectorController's disableProfiler or enableProfiler methods.

WebKit/win:

2008-10-28 Timothy Hatcher <timothy@apple.com>

Add IWebInspector methods to enable the profiler.

https://bugs.webkit.org/show_bug.cgi?id=21927

<rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
not slow down JavaScript all the time

Reviewed by Darin Adler and Kevin McCullough.

WebInspector.cpp: (WebInspector::isJavaScriptProfilingEnabled): Added. Calls InspectorController::profilerEnabled. (WebInspector::setJavaScriptProfilingEnabled): Added. Call InspectorController's disableProfiler or enableProfiler methods.
WebInspector.h:

WebKitTools:

2008-10-28 Timothy Hatcher <timothy@apple.com>

Add support for enabling the profiler, so the profiling tests can continue
work now that the profiler is not always enabled.

https://bugs.webkit.org/show_bug.cgi?id=21927

<rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
not slow down JavaScript all the time

Reviewed by Darin Adler and Kevin McCullough.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Make the editor use spaces.
DumpRenderTree/LayoutTestController.cpp: (setJavaScriptProfilingEnabledCallback): Added. Calls LayoutTestController::setJavaScriptProfilingEnabled. (LayoutTestController::staticFunctions): Added setJavaScriptProfilingEnabled to the script class.
DumpRenderTree/LayoutTestController.h:
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setJavaScriptProfilingEnabled): Stubbed out with a FIXME.
DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.

LayoutTests:

2008-10-28 Timothy Hatcher <timothy@apple.com>

Update profiler tests to opt-in to profiling and clean up the output.

https://bugs.webkit.org/show_bug.cgi?id=21927

<rdar://problem/6211578> Make the JavaScript profiler opt-in, so it
does not slow down JavaScript all the time

Reviewed by Darin Adler and Kevin McCullough.

fast/profiler/anonymous-event-handler-expected.txt:
fast/profiler/anonymous-event-handler.html:
fast/profiler/anonymous-function-called-from-different-contexts-expected.txt:
fast/profiler/anonymous-function-called-from-different-contexts.html:
fast/profiler/anonymous-function-calls-built-in-functions-expected.txt:
fast/profiler/anonymous-function-calls-built-in-functions.html:
fast/profiler/anonymous-function-calls-eval-expected.txt:
fast/profiler/anonymous-function-calls-eval.html:
fast/profiler/apply-expected.txt:
fast/profiler/apply.html:
fast/profiler/built-in-function-calls-anonymous-expected.txt:
fast/profiler/built-in-function-calls-anonymous.html:
fast/profiler/built-in-function-calls-user-defined-function-expected.txt:
fast/profiler/built-in-function-calls-user-defined-function.html:
fast/profiler/call-expected.txt:
fast/profiler/call-nodelist-as-function-expected.txt:
fast/profiler/call-nodelist-as-function.html:
fast/profiler/call.html:
fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope-expected.txt:
fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html:
fast/profiler/compare-multiple-profiles-expected.txt:
fast/profiler/compare-multiple-profiles.html:
fast/profiler/constructor-expected.txt:
fast/profiler/constructor.html:
fast/profiler/dead-time-expected.txt:
fast/profiler/dead-time.html:
fast/profiler/document-dot-write-expected.txt:
fast/profiler/document-dot-write.html:
fast/profiler/event-handler-expected.txt:
fast/profiler/event-handler.html:
fast/profiler/execution-context-and-eval-on-same-line-expected.txt:
fast/profiler/execution-context-and-eval-on-same-line.html:
fast/profiler/heavy-view-expected.txt:
fast/profiler/heavy-view.html:
fast/profiler/inline-event-handler-expected.txt:
fast/profiler/inline-event-handler.html:
fast/profiler/many-calls-in-the-same-scope-expected.txt:
fast/profiler/many-calls-in-the-same-scope.html:
fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt:
fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html:
fast/profiler/multiple-and-different-scoped-function-calls-expected.txt:
fast/profiler/multiple-and-different-scoped-function-calls.html:
fast/profiler/multiple-frames-expected.txt:
fast/profiler/multiple-frames.html:
fast/profiler/nested-anonymous-functon-expected.txt:
fast/profiler/nested-anonymous-functon.html:
fast/profiler/nested-start-and-stop-profiler-expected.txt:
fast/profiler/nested-start-and-stop-profiler.html:
fast/profiler/no-execution-context-expected.txt:
fast/profiler/no-execution-context.html:
fast/profiler/one-execution-context-expected.txt:
fast/profiler/one-execution-context.html:
fast/profiler/profile-calls-in-included-file-expected.txt:
fast/profiler/profile-calls-in-included-file.html:
fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt:
fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html:
fast/profiler/profiling-from-a-nested-location-expected.txt:
fast/profiler/profiling-from-a-nested-location.html:
fast/profiler/resources/profiler-test-JS-resources.js: (endTest): Remove some whitespace. (insertGivenText): Hide the output of this method, sicne it is not important to the test. (insertNewText): Ditto. (printHeavyProfilesDataWithoutTime): Output plain text an not console.log. (printProfilesDataWithoutTime): Ditto. (printProfileNodeWithoutTime): Ditto.
fast/profiler/simple-event-call-expected.txt:
fast/profiler/simple-event-call.html:
fast/profiler/simple-no-level-change-expected.txt:
fast/profiler/simple-no-level-change.html:
fast/profiler/start-and-stop-profiler-multiple-times-expected.txt:
fast/profiler/start-and-stop-profiler-multiple-times.html:
fast/profiler/start-and-stop-profiling-in-the-same-function-expected.txt:
fast/profiler/start-and-stop-profiling-in-the-same-function.html:
fast/profiler/start-but-dont-stop-profiling-expected.txt:
fast/profiler/start-but-dont-stop-profiling.html:
fast/profiler/stop-profiling-after-setTimeout-expected.txt:
fast/profiler/stop-profiling-after-setTimeout.html:
fast/profiler/stop-then-function-call-expected.txt:
fast/profiler/stop-then-function-call.html:
fast/profiler/throw-exception-from-eval-expected.txt:
fast/profiler/throw-exception-from-eval.html:
fast/profiler/two-execution-contexts-expected.txt:
fast/profiler/two-execution-contexts.html:
fast/profiler/user-defined-function-calls-built-in-functions-expected.txt:
fast/profiler/user-defined-function-calls-built-in-functions.html:
fast/profiler/window-dot-eval-expected.txt:
fast/profiler/window-dot-eval.html:

1:42 PM Changeset in webkit [37932] by timothy@apple.com

11 edits in trunk

Rename a few methods related to attaching and detaching the debugger. Also adds stub methods for enabling and disabling the profiler.

WebCore:

2008-10-27 Timothy Hatcher <timothy@apple.com>

Rename a few methods related to attaching and detaching the debugger. Also
adds stub methods for enabling and disabling the profiler.

Rename attachDebugger to enableDebugger.
Rename detachDebugger to disableDebugger.
Rename the debuggerAttached getter to debuggerEnabled.
Rename the debuggerAttached callback to debuggerWasEnabled.
Rename the debuggerDetached callback to debuggerWasDisabled.

Reviewed by Darin Adler.

WebCore.base.exp:
inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::close): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::pauseInDebugger): (WebCore::InspectorController::resumeDebugger): (WebCore::InspectorController::stepOverStatementInDebugger): (WebCore::InspectorController::stepIntoStatementInDebugger): (WebCore::InspectorController::stepOutOfFunctionInDebugger):
inspector/InspectorController.h: (WebCore::InspectorController::profilerEnabled): (WebCore::InspectorController::debuggerEnabled):
inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
inspector/front-end/Object.js:
inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get statusBarItems): (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype.debuggerWasDetached): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype.canShowResource): (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton): (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): (WebInspector.ScriptsPanel.prototype._toggleDebugging):
inspector/front-end/View.js:
inspector/front-end/inspector.css:
inspector/front-end/inspector.html:
inspector/front-end/inspector.js: (WebInspector.addResource): (WebInspector.debuggerWasEnabled): (WebInspector.debuggerWasDisabled):

WebKit/mac:

2008-10-27 Timothy Hatcher <timothy@apple.com>

Rename a few methods related to attaching and detaching the debugger.

Rename attachDebugger to enableDebugger.
Rename detachDebugger to disableDebugger.
Rename the debuggerAttached getter to debuggerEnabled.

Reviewed by Darin Adler.

WebInspector/WebInspector.mm: (-isDebuggingJavaScript): (-startDebuggingJavaScript:): (-stopDebuggingJavaScript:):

WebKit/win:

2008-10-27 Timothy Hatcher <timothy@apple.com>

Rename a few methods related to attaching and detaching the debugger.

Rename attachDebugger to enableDebugger.
Rename detachDebugger to disableDebugger.
Rename the debuggerAttached getter to debuggerEnabled.

Reviewed by Darin Adler.

WebInspector.cpp: (WebInspector::isDebuggingJavaScript): (WebInspector::toggleDebuggingJavaScript):

1:41 PM Changeset in webkit [37931] by timothy@apple.com

2 edits in trunk/WebCore

Fix an exception when searching the Resources panel while there
and resources queued to be added to the list.

Reviewed by Kevin McCullough.

inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.searchCanceled): Null check the _resourcesTreeElement property. (WebInspector.ResourcesPanel.prototype.performSearch): Ditto.

12:14 PM Changeset in webkit [37930] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-10-28 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Fixed https://bugs.webkit.org/show_bug.cgi?id=21919
Sampler reports bogus time in op_enter during 3d-raytrace.js

Fixed a bug where we would pass the incorrect Instruction* during some
parts of CTI codegen.

VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
VM/SamplingTool.cpp: (JSC::SamplingTool::run):
wtf/Platform.h:

10:48 AM Changeset in webkit [37929] by kmccullough@apple.com

3 edits in trunk/JavaScriptCore

2008-10-28 Kevin McCullough <kmccullough@apple.com>

Reviewed by Dan Bernstein.

-Removed unused includes.
Apparent .4% speedup in Sunspider

kjs/JSObject.cpp:
kjs/interpreter.cpp:

10:26 AM Changeset in webkit [37928] by Simon Fraser

13 edits
2 adds in trunk/WebKitTools

2008-10-28 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Dan Bernstein

Primary changes in DumpRenderTree:

Ensure font smoothing is disabled (this is also called LCD anti-aliasing and is different from regular font CG anti-aliasing) as font-smoothing settings depends on the display and can also be changed by the user
Use a new cleared buffer for each test instead of the reusing same one to avoid potential result corruption across tests
Can now receive the expected pixel hash as a suffix to the test path or url as "path'hash"
Make sure hash is computed in a endian-independent way
Improve the code that sets/restores the screen color profile
Make the code more cross-platformy with std::string goodness
Added an "on-screen" mode where the snapshot will take into account surfaces on the window (like OpenGL content): this uses the new CG APIs on 10.5 or reading from the display framebuffer on 10.4. This mode is not active by default for performance reason, but must be explicitly activated from the test file using the new "testOnscreen()" JS API.

Primary changes in ImageDiff:

Provide a new comparison algorithm that is more tolerant to "acceptable" failures (i.e. very small differences in font rendering, which --threshold is not really good at handling)
Generate normalized intensity-only diff images

Primary changes in run-webkit-tests:

Take advantage of hashes for pixel tests which makes them much faster by minimizing image comparisons
Removed repaint options as these should be set from within test files using JS API
Replaced "threshold" option in by "tolerance" expressed in percents
Added more logging when in "verbose" mode

10:17 AM Changeset in webkit [37927] by mitz@apple.com

1 edit
12 moves
3 deletes in trunk/LayoutTests

2008-10-28 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=21821

Ensure all baseline images are in the right location and delete the ones that aren't needed.

editing/inserting/5607069-1-expected.checksum: Removed.
editing/inserting/5607069-1-expected.png: Removed.
editing/pasteboard/paste-text-013-expected.png: Removed.
fast/css/invalid-percentage-property-expected.checksum: Removed.
fast/css/invalid-percentage-property-expected.png: Removed.
fast/css/text-align-expected.checksum: Removed.
fast/css/text-align-expected.png: Removed.
fast/selectors/lang-inheritance-expected.checksum: Removed.
fast/selectors/lang-inheritance-expected.png: Removed.
fast/selectors/lang-inheritance2-expected.checksum: Removed.
fast/selectors/lang-inheritance2-expected.png: Removed.
fast/selectors/lang-vs-xml-lang-expected.checksum: Removed.
fast/selectors/lang-vs-xml-lang-expected.png: Removed.
fast/selectors/lang-vs-xml-lang-xhtml-expected.checksum: Removed.
fast/selectors/lang-vs-xml-lang-xhtml-expected.png: Removed.
platform/mac/fast/css/invalid-percentage-property-expected.checksum: Copied from LayoutTests/fast/css/invalid-percentage-property-expected.checksum.
platform/mac/fast/css/invalid-percentage-property-expected.png: Copied from LayoutTests/fast/css/invalid-percentage-property-expected.png.
platform/mac/fast/css/text-align-expected.checksum: Copied from LayoutTests/fast/css/text-align-expected.checksum.
platform/mac/fast/css/text-align-expected.png: Copied from LayoutTests/fast/css/text-align-expected.png.
platform/mac/fast/selectors/lang-inheritance-expected.checksum: Copied from LayoutTests/fast/selectors/lang-inheritance-expected.checksum.
platform/mac/fast/selectors/lang-inheritance-expected.png: Copied from LayoutTests/fast/selectors/lang-inheritance-expected.png.
platform/mac/fast/selectors/lang-inheritance2-expected.checksum: Copied from LayoutTests/fast/selectors/lang-inheritance2-expected.checksum.
platform/mac/fast/selectors/lang-inheritance2-expected.png: Copied from LayoutTests/fast/selectors/lang-inheritance2-expected.png.
platform/mac/fast/selectors/lang-vs-xml-lang-expected.checksum: Copied from LayoutTests/fast/selectors/lang-vs-xml-lang-expected.checksum.
platform/mac/fast/selectors/lang-vs-xml-lang-expected.png: Copied from LayoutTests/fast/selectors/lang-vs-xml-lang-expected.png.
platform/mac/fast/selectors/lang-vs-xml-lang-xhtml-expected.checksum: Copied from LayoutTests/fast/selectors/lang-vs-xml-lang-xhtml-expected.checksum.
platform/mac/fast/selectors/lang-vs-xml-lang-xhtml-expected.png: Copied from LayoutTests/fast/selectors/lang-vs-xml-lang-xhtml-expected.png.

9:18 AM Changeset in webkit [37926] by alp@webkit.org

3 edits in trunk/WebCore

2008-10-28 Alp Toker <alp@nuanti.com>

GTK+ build fix for older versions of Pango where PANGO_VERSION_CHECK
isn't defined.

platform/graphics/gtk/FontGtk.cpp: (WebCore::getDefaultPangoLayout):
platform/graphics/gtk/FontPlatformDataPango.cpp:

7:30 AM Changeset in webkit [37925] by alp@webkit.org

2 edits in trunk

2008-10-28 Mike Hommey <glandium@debian.org>

Reviewed by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=21885
[GTK] libwebkit doesn't link against libpangoft2

Add pkg-config check for pangoft2 which provides
pango_fc_font_description_from_pattern() used in the FreeType font
backend.

configure.ac:

6:42 AM Changeset in webkit [37924] by ap@webkit.org

8 edits
3 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21893
Character set is incorrect for external scripts in XHTML pages

<rdar://problem/6317451> Incorrect encoding for text in a popup at http://xpoint.ru/

Test: fast/encoding/external-script-charset.xhtml

Expose scriptCharset() function on all ScriptElements, and call it from XML tokenizer.

dom/ScriptElement.h:
dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::endElementNs):
dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::parseEndElement):
html/HTMLScriptElement.h:
svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::scriptCharset):
svg/SVGScriptElement.h:

5:53 AM Changeset in webkit [37923] by alp@webkit.org

6 edits in trunk

2008-10-28 Alp Toker <alp@nuanti.com>

Include copyright license files in the autotools dist target and
exclude unused zlib headers.

Change suggested by Mike Hommey.

Oct 27, 2008:

10:24 PM Changeset in webkit [37922] by weinig@apple.com

2 edits in trunk/WebCore

2008-10-27 Sam Weinig <sam@webkit.org>

Reviewed by Maciej Stachowiak.

Clear the window shell when destroying a page to allow documents
which have no way of being reached anymore, to be torn down.

page/Frame.cpp: (WebCore::Frame::pageDestroyed):

8:06 PM Changeset in webkit [37921] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch

Versioning.

8:05 PM Changeset in webkit [37920] by mrowe@apple.com

1 copy in tags/Safari-5525.26.6

New tag.

7:40 PM Changeset in webkit [37919] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

2008-10-27 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Stop discarding CodeBlock samples that can't be charged to a specific
opcode. Instead, charge the relevant CodeBlock, and provide a footnote
explaining the situation.

This will help us tell which CodeBlocks are hot, even if we can't
identify specific lines of code within the CodeBlocks.

VM/SamplingTool.cpp: (JSC::ScopeSampleRecord::sample): (JSC::compareScopeSampleRecords): (JSC::SamplingTool::dump):

VM/SamplingTool.h: (JSC::ScopeSampleRecord::ScopeSampleRecord): (JSC::ScopeSampleRecord::~ScopeSampleRecord):

7:21 PM Changeset in webkit [37918] by Antti Koivisto

1 edit
1 add in trunk/WebKitSite

2008-10-27 Antti Koivisto <Antti Koivisto>

Add a file.

blog-files/squirrelfish-link-animated.svg: Added.

6:40 PM Changeset in webkit [37917] by andersca@apple.com

1 edit in trunk/WebKit/mac/Plugins/WebBaseNetscapePluginStream.h

Whoops, did not mean to commit this.

6:39 PM Changeset in webkit [37916] by andersca@apple.com

3 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Maciej Stachowiak.

Use the C++ stream object for JS requests as well.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebBaseNetscapePluginView destroyStream:reason:]):

6:31 PM Changeset in webkit [37915] by andersca@apple.com

4 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Use the C++ stream object in WebBaseNetscapePluginView. Use a HashSet of RefPtrs to keep track of the streams.

Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::~WebNetscapePluginStream): (WebNetscapePluginStream::setPlugin): (WebNetscapePluginStream::startStream): (WebNetscapePluginStream::destroyStream): (WebNetscapePluginStream::destroyStreamWithReason): (WebNetscapePluginStream::cancelLoadAndDestroyStreamWithError): (WebNetscapePluginStream::deliverData):
Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView stop]): (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): (-[WebBaseNetscapePluginView disconnectStream:]): (-[WebBaseNetscapePluginView dealloc]): (-[WebBaseNetscapePluginView pluginView:receivedResponse:]): (-[WebBaseNetscapePluginView pluginView:receivedData:]): (-[WebBaseNetscapePluginView pluginView:receivedError:]): (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

6:07 PM Changeset in webkit [37914] by andersca@apple.com

3 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Mitz Pettel.

Move code from dealloc and finalize to the WebNetscapePluginStream destructor.

Plugins/WebBaseNetscapePluginStream.h:
Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::~WebNetscapePluginStream): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]):

6:01 PM Changeset in webkit [37913] by andersca@apple.com

4 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Get rid of WebNetscapePlugInStreamLoaderClient, the plug-in stream is its own client.

Plugins/WebBaseNetscapePluginStream.h:
Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]):
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginView:receivedError:]): (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]): (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebBaseNetscapePluginView destroyStream:reason:]):

5:43 PM Changeset in webkit [37912] by andersca@apple.com

3 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Change the Obj-C init methods to simply call WebNetscapePluginStream::create.

Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::create):
Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream initWithFrameLoader:]): (WebNetscapePluginStream::WebNetscapePluginStream): (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):

5:18 PM Changeset in webkit [37911] by andersca@apple.com

4 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Convert more code over to C++.

Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::plugin): (WebNetscapePluginStream::setRequestURL): Convert to C++.

Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::start): (WebNetscapePluginStream::stop): Ditto.

(WebNetscapePluginStream::startStreamWithResponse):
Ditto.

(-[WebBaseNetscapePluginStream startStreamWithResponse:]):
Call the C++ version.

(-[WebBaseNetscapePluginStream impl]):
New accessor for the C++ class.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginView:receivedData:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): (-[WebBaseNetscapePluginView destroyStream:reason:]): Call the C++ methods.

4:48 PM Changeset in webkit [37910] by mrowe@apple.com

2 edits in branches/Safari-3-2-branch/WebCore

Merge r37628.

4:47 PM Changeset in webkit [37909] by mrowe@apple.com

2 edits in branches/Safari-3-2-branch/WebCore

Merge r37897.

4:25 PM Changeset in webkit [37908] by Antti Koivisto

1 edit
2 adds in trunk/WebKitSite

2008-10-27 Antti Koivisto <Antti Koivisto>

Add some svg files.

blog-files/cubes-7.svg: Added.
blog-files/number-morph.svg: Added.

3:57 PM Changeset in webkit [37907] by Darin Adler

2 edits in trunk/WebKit

2008-10-27 Darin Adler <Darin Adler>

StringsNotToBeLocalized.txt: Updated for recent changes.

3:15 PM Changeset in webkit [37906] by kevino@webkit.org

2 edits in trunk

Reviewed by Kevin Ollivier.

Update the active state as well as the focused state as both need to be true
for the caret to be drawn.

https://bugs.webkit.org/show_bug.cgi?id=21900

3:10 PM Changeset in webkit [37905] by Darin Adler

2 edits in trunk/BugsSite

2008-10-27 Darin Adler <Darin Adler>

template/en/custom/attachment/reviewform.html.tmpl: Leave out the comment if it's untouched.

3:07 PM Changeset in webkit [37904] by kevino@webkit.org

6 edits in trunk

wx build fix on Linux/GTK. Enable support for #include <JavaScriptCore/XYZ.h> style includes.

2:45 PM Changeset in webkit [37903] by jmalonzo@webkit.org

2 edits in trunk/WebKit/gtk

2008-10-27 Michael Tross <michael@tross.org>

Reviewed by Alp Toker. Landed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=21827
[GTK] Fix memory leak in webkit_web_view_load_string

webkit/webkitwebview.cpp:

2:20 PM Changeset in webkit [37902] by Darin Adler

13 edits in trunk/WebCore

2008-10-27 Michael Knaup <michael.knaup@mac.com>

Reviewed and tweaked by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=8988

Bug 8988: Add support for Mozilla CSS custom cursors.
Added -webkit-grab and -webkit-grabbing cursor suppport
for the Mac, dummy implementations for other platforms.

css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Updated since the -webkit-grabbing cursor is now the last one.

css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING.

css/CSSValueKeywords.in: Added -webkit-grab and -webkit-grabbing.

manual-tests/cursor.html: Added -webkit-zoom-in, webkit-zoom-out, -webkit-grab, and -webkit-grabbing.

page/EventHandler.cpp: (WebCore::EventHandler::selectCursor): Added CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING.

platform/Cursor.h: Added grabCursor and grabbingCursor.

platform/gtk/CursorGtk.cpp: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.
platform/mac/CursorMac.mm: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.
platform/qt/CursorQt.cpp: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.
platform/win/CursorWin.cpp: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.
platform/wx/CursorWx.cpp: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.

rendering/style/RenderStyleConstants.h: Added CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING. Also broke ECursor out into a single constant per line. Also added a couple of comments.

1:37 PM Changeset in webkit [37901] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

2008-10-27 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Added a mutex around the SamplingTool's ScopeNode* map, to solve a crash
when sampling the v8 tests.

VM/SamplingTool.cpp: (JSC::SamplingTool::run): (JSC::SamplingTool::notifyOfScope):
VM/SamplingTool.h: Since new ScopeNodes can be created after the SamplingTools has begun sampling, reads and writes to / from the map need to be synchronized. Shark says this doesn't measurably increase sampling overhead.

1:07 PM Changeset in webkit [37900] by eric@webkit.org

2 edits in trunk/WebCore

2008-10-27 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

svg/SVGAnimatedTemplate.h: needed a HashMap define

12:49 PM Changeset in webkit [37899] by eric@webkit.org

3 edits
2 adds in trunk

Reviewed by Dave Hyatt.

Infinite recursion crash in WebCore::RenderSVGRoot::absoluteClippedOverflowRect on a <stop> element outside of a gradient block
https://bugs.webkit.org/show_bug.cgi?id=20400

Test: svg/custom/stop-crash.svg

WebCore.xcodeproj/project.pbxproj:
rendering/RenderSVGGradientStop.h: (WebCore::RenderSVGGradientStop::absoluteClippedOverflowRect):

11:55 AM Changeset in webkit [37898] by andersca@apple.com

2 edits in trunk/WebCore

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

No need to call release if the connection is null.

platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start):

11:52 AM Changeset in webkit [37897] by andersca@apple.com

2 edits in trunk/WebCore

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

<rdar://problem/6322650> Crash in fast/loader/simultaneous-reloads-assert.html

Make sure to null check the NSURLConnection object.

platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::setDefersLoading):

1:53 AM Changeset in webkit [37896] by ap@webkit.org

5 edits in trunk/WebCore

Fix non-Mac builds.

GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCoreSources.bkl: Renamed JSHTMLOptionElementConstructor to JSOptionConstructor.

12:59 AM Changeset in webkit [37895] by ap@webkit.org

10 edits
2 moves
2 adds in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21886
window.HTMLOptionElement == "[object HTMLElementConstructor]" instead of HTMLOptionElementConstructor

Test: fast/dom/HTMLOptionElement/option-prototype.html

We now have separate objects for window.Option and window.HTMLOptionElement - the latter
"constructor" cannot be used to construct anything. This matches Firefox behavior.

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMWindowBase.cpp: (jsDOMWindowBaseOption):
bindings/js/JSHTMLOptionElementConstructor.cpp: Removed.
bindings/js/JSHTMLOptionElementConstructor.h: Removed.
bindings/js/JSOptionConstructor.cpp: Copied from WebCore/bindings/js/JSHTMLOptionElementConstructor.cpp.
bindings/js/JSOptionConstructor.h: Copied from WebCore/bindings/js/JSHTMLOptionElementConstructor.h.
html/HTMLOptionElement.idl: Renamed JSHTMLOptionElementConstructor to JSOptionConstructor.

html/HTMLOptionElement.idl: Generate a constructor.

Oct 25, 2008:

1:26 PM Changeset in webkit [37894] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-10-25 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Windows build.

VM/Machine.cpp: (JSC::Machine::privateExecute): Provide a dummy value to the HostCallRecord in CTI non-sampling builds, to silence compiler warning.

1:21 PM Changeset in webkit [37893] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-10-25 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Windows build.

VM/SamplingTool.h: (JSC::SamplingTool::encodeSample): Explicitly cast bool to int, to silence compiler warning.

1:03 PM Changeset in webkit [37892] by ggaren@apple.com

3 edits in trunk/WebCore

2008-10-25 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Mac debug build on the buildbot.

platform/FileChooser.cpp: (WebCore::FileChooserClient::~FileChooserClient):
platform/FileChooser.h: Moved destructor to .cpp file, to avoid a weak exported symbol.

12:59 PM Changeset in webkit [37891] by ggaren@apple.com

16 edits in trunk/JavaScriptCore

2008-10-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig, with Gavin Barraclough's help.

Fixed Sampling Tool:

Made CodeBlock sampling work with CTI
Improved accuracy by unifying most sampling data into a single 32bit word, which can be written / read atomically.
Split out three different #ifdefs for modularity: OPCODE_SAMPLING; CODEBLOCK_SAMPLING; OPCODE_STATS.
Improved reporting clarity
Refactored for code clarity

JavaScriptCore.exp: Exported another symbol.

VM/CTI.cpp: (JSC::CTI::emitCTICall): (JSC::CTI::compileOpCall): (JSC::CTI::emitSlowScriptCheck): (JSC::CTI::compileBinaryArithOpSlowCase): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile):
VM/CTI.h: Updated CTI codegen to use the unified SamplingTool interface for encoding samples. (This required passing the current vPC to a lot more functions, since the unified interface samples the current vPC.) Added hooks for writing the current CodeBlock* on function entry and after a function call, for the sake of the CodeBlock sampler. Removed obsolete hook for clearing the current sample inside op_end. Also removed the custom enum used to differentiate flavors of op_call, since the OpcodeID enum works just as well. (This was important in an earlier version of the patch, but now it's just cleanup.)

VM/CodeBlock.cpp: (JSC::CodeBlock::lineNumberForVPC):
VM/CodeBlock.h: Upated for refactored #ifdefs. Changed lineNumberForVPC to be robust against vPCs not recorded for exception handling, since the Sampler may ask for an arbitrary vPC.

VM/Machine.cpp: (JSC::Machine::execute): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_construct_NotJSConstruct):
VM/Machine.h: (JSC::Machine::setSampler): (JSC::Machine::sampler): (JSC::Machine::jitCodeBuffer): Upated for refactored #ifdefs. Changed Machine to use SamplingTool helper objects to record movement in and out of host code. This makes samples a bit more precise.

VM/Opcode.cpp: (JSC::OpcodeStats::~OpcodeStats):
VM/Opcode.h: Upated for refactored #ifdefs. Added a little more padding, to accomodate our more verbose opcode names.

VM/SamplingTool.cpp: (JSC::ScopeSampleRecord::sample): Only count a sample toward our total if we actually record it. This solves cases where a CodeBlock will claim to have been sampled many times, with reported samples that don't match.

(JSC::SamplingTool::run): Read the current sample into a Sample helper
object, to ensure that the data doesn't change while we're analyzing it,
and to help decode the data. Only access the CodeBlock sampling hash
table if CodeBlock sampling has been enabled, so non-CodeBlock sampling
runs can operate with even less overhead.

(JSC::SamplingTool::dump): I reorganized this code a lot to print the
most important info at the top, print as a table, annotate and document
the stuff I didn't understand when I started, etc.

VM/SamplingTool.h: New helper classes, described above.

kjs/Parser.h:
kjs/Shell.cpp: (runWithScripts):
kjs/nodes.cpp: (JSC::ScopeNode::ScopeNode): Updated for new sampling APIs.

wtf/Platform.h: Moved sampling #defines here, since our custom is to put ENABLE #defines into Platform.h. Made explicit the fact that CODEBLOCK_SAMPLING depends on OPCODE_SAMPLING.

12:11 PM Changeset in webkit [37890] by kevino@webkit.org

2 edits in trunk/WebKit/wx

wx build fix.

8:22 AM Changeset in webkit [37889] by vestbo@webkit.org

4 edits in trunk

2008-10-25 Jade Han <jade.han@nokia.com>

Reviewed by Anders.

Enable custom properties for Qt runtime objects in QtWebKit

https://bugs.webkit.org/show_bug.cgi?id=21813

2:37 AM Changeset in webkit [37888] by jmalonzo@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-25 Jan Michael Alonzo <jmalonzo@webkit.org>

JSC Build fix, not reviewed.

VM/CTI.cpp: add missing include stdio.h for debug builds

12:24 AM Changeset in webkit [37887] by jmalonzo@webkit.org

2 edits in trunk

2008-10-25 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix: add '-' to Wl which was missed in r36845

GNUmakefile.am:

Oct 24, 2008:

11:58 PM Changeset in webkit [37886] by weinig@apple.com

2 edits in trunk/WebKit/win

2008-10-24 Sam Weinig <sam@webkit.org>

Yet another windows build fix.

WebCoreSupport/WebChromeClient.cpp:

11:39 PM Changeset in webkit [37885] by weinig@apple.com

2 edits in trunk/WebKit/qt

2008-10-24 Sam Weinig <sam@webkit.org>

Another Qt build fix.

WebCoreSupport/ChromeClientQt.cpp:

11:38 PM Changeset in webkit [37884] by weinig@apple.com

2 edits in trunk/WebKit/win

2008-10-24 Sam Weinig <sam@webkit.org>

Another windows build fix.

WebCoreSupport/WebChromeClient.cpp:

11:36 PM Changeset in webkit [37883] by weinig@apple.com

3 edits in trunk/WebCore

2008-10-24 Sam Weinig <sam@webkit.org>

Fix windows build.

page/Chrome.cpp:
page/Chrome.h:

11:31 PM Changeset in webkit [37882] by weinig@apple.com

2 edits in trunk/WebKit/gtk

2008-10-24 Sam Weinig <sam@webkit.org>

Fix the Gtk build.

WebCoreSupport/ChromeClientGtk.cpp:

11:29 PM Changeset in webkit [37881] by weinig@apple.com

2 edits in trunk/WebCore

2008-10-24 Sam Weinig <sam@webkit.org>

Fix Qt build.

platform/qt/FileChooserQt.cpp:

11:02 PM Changeset in webkit [37880] by weinig@apple.com

28 edits in trunk

WebCore:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

Move file choosing into WebKit ChromeClient.

loader/EmptyClients.h: (WebCore::EmptyChromeClient::runOpenPanel):
page/Chrome.cpp: (WebCore::Chrome::runOpenPanel):
page/Chrome.h:
page/ChromeClient.h:
page/mac/ChromeMac.mm:
platform/FileChooser.h:
platform/mac/FileChooserMac.mm:
platform/qt/FileChooserQt.cpp:
platform/win/FileChooserWin.cpp:
platform/wx/TemporaryLinkStubs.cpp:
rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click):

WebKit/gtk:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::runOpenPanel):
WebCoreSupport/ChromeClientGtk.h:

WebKit/mac:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm: (WebChromeClient::runOpenPanel):

WebKit/qt:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runOpenPanel):
WebCoreSupport/ChromeClientQt.h:

WebKit/win:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::runOpenPanel):
WebCoreSupport/WebChromeClient.h:

WebKit/wx:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::runOpenPanel):
WebKitSupport/ChromeClientWx.h:

9:48 PM Changeset in webkit [37879] by eric@webkit.org

1 edit
1 add in trunk/LayoutTests

Reviewed by Sam Weinig.

Add missing results.

fast/js/global-constructors-expected.txt: Added.

6:34 PM Changeset in webkit [37878] by kevino@webkit.org

2 edits in trunk/WebCore

wx build fix - add newIconForFiles stub.

6:15 PM Changeset in webkit [37877] by kevino@webkit.org

3 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Use the CGFont metrics APIs for more accurate measurements, and tweak the y
value the text is drawn at (it was a couple pixels off before because wx
internally adds to the y value.

https://bugs.webkit.org/show_bug.cgi?id=21853

5:09 PM Changeset in webkit [37876] by eric@webkit.org

2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Get rid of a bonus ASSERT when using a null string as a regexp.
Specifically calling: RegularExpression::match() with String::empty()
will hit this ASSERT.
Chromium hits this, but I don't know of any way to make a layout test.

pcre/pcre_exec.cpp: (jsRegExpExecute):

4:46 PM Changeset in webkit [37875] by eric@webkit.org

9 edits
2 adds
1 delete in trunk

Reviewed by Sam Weinig.

Generate missing constructors and add test to prevent missing ones in the future
https://bugs.webkit.org/show_bug.cgi?id=21846

fast/dom/wrapper-classes-expected.txt results were incorrectly platform-specific
that test used to be platform-dependent, but isn't anymore

fast/dom/Window/window-properties-expected.txt:
fast/dom/wrapper-classes-expected.txt:
fast/js/global-constructors.html: Added.
fast/js/resources/global-constructors.js: Added.
platform/mac/fast/dom/wrapper-classes-expected.txt: Removed.

4:39 PM Changeset in webkit [37874] by ap@webkit.org

3 edits
3 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21836
REGRESSION: Sign-in on Fancast.com causes crash in Webkit nightly

Test: http/tests/xmlhttprequest/detaching-frame.html

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dropProtection): Null check the window - even though XHR needs a context (AKA frame) to be serviced, the frame may be disconnected when dispatching the same callback that results in this function being called.

4:07 PM Changeset in webkit [37873] by andersca@apple.com

2 edits in trunk/WebKitTools

2008-10-24 Anders Carlsson <andersca@apple.com>

Try fixing the 64-bit build.

DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: (testGetProperty):

4:06 PM Changeset in webkit [37872] by andersca@apple.com

2 edits in trunk/WebKit/mac

2008-10-24 Anders Carlsson <andersca@apple.com>

Fix Tiger build.

WebView/WebUIDelegate.h:

4:04 PM Changeset in webkit [37871] by ddkilzer@apple.com

2 edits in trunk/WebCore

Gtk build fix.

platform/gtk/TemporaryLinkStubs.cpp: (WebCore::setFocusRingColorChangeFunction): Removed in r37858.

3:20 PM Changeset in webkit [37870] by mrowe@apple.com

2 edits in trunk/WebCore

<rdar://problem/6164952> Use constant kCGInterpolationMedium in GraphicsContextCG.cpp rather than hard-coded values.

Reviewed by Sam Weinig.

3:16 PM Changeset in webkit [37869] by andersca@apple.com

19 edits
2 adds in trunk

WebCore:

2008-10-24 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/5440917> Support NPN_Construct

WebCore.NPAPI.exp: Export _NPN_Construct.

bridge/NP_jsobject.cpp: (_NPN_Construct): Implement this.

bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::supportsConstruct): (JSC::Bindings::CInstance::invokeConstruct): Have this call the appropriate NPClass method.

bridge/npruntime.h: Add NPN_Construct.

bridge/npruntime_impl.h: Add _NPN_Construct.

bridge/runtime.h: (JSC::Bindings::Instance::supportsConstruct): (JSC::Bindings::Instance::invokeConstruct): New methods.

bridge/runtime_object.cpp: (JSC::callRuntimeConstructor): Call the native instance.

(JSC::RuntimeObjectImp::getConstructData):
Implement this.

bridge/runtime_object.h: Add new method declarations.

plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::load):
plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::load):
plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load): Initialize m_pluginFuncs.construct.

WebKit/mac:

2008-10-24 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/5440917> Support NPN_Construct

Set construct.

Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):

WebKitTools:

2008-10-24 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/5440917> Support NPN_Construct

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (testCallback): Fix a memory leak.

(testConstruct):
New test method that treats it first argument as a constructor and invokes it with the rest of the arguments.

(pluginInvoke):
Handle testConstruct.

DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: (testGetProperty): Add objectPointer property.

(testEnumerate):
Only enumerate the two first properties.

(testConstruct):
Add a simple construct implementation that just returns the test object.

LayoutTests:

2008-10-24 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/5440917> Support NPN_Construct

Add testcase.

plugins/netscape-construct-expected.txt: Added.
plugins/netscape-construct.html: Added.

3:16 PM Changeset in webkit [37868] by ap@webkit.org

2 edits in trunk/JavaScriptCore

Suggested and rubber-stamped by Geoff Garen.

Fix a crash when opening Font Picker.

The change also hopefully fixes this bug, which I could never reproduce:
https://bugs.webkit.org/show_bug.cgi?id=20241
<rdar://problem/6290576> Safari crashes at JSValueUnprotect() when fontpicker view close

API/JSContextRef.cpp: (JSContextGetGlobalObject): Use lexical global object instead of dynamic one.

3:09 PM Changeset in webkit [37867] by adele@apple.com

3 edits in trunk/WebCore

2008-10-24 Adele Peterson <adele@apple.com>

Build fix.

platform/FileChooser.h: (WebCore::FileChooserClient::~FileChooserClient):
platform/graphics/mac/IconMac.mm: (WebCore::Icon::newIconForFiles):

2:51 PM Changeset in webkit [37866] by ddkilzer@apple.com

2 edits in trunk/WebCore

2008-10-24 Greg Bolsinga <bolsinga@apple.com>

Fix GTK build break.

Reviewed by David Kilzer.

GNUmakefile.am: Do not include .idl files whose generated files should not be compiled.

2:46 PM Changeset in webkit [37865] by ddkilzer@apple.com

2 edits in trunk/WebCore

Wx build fix.

platform/wx/TemporaryLinkStubs.cpp: (WebCore::setFocusRingColorChangeFunction): Removed in r37858.

2:44 PM Changeset in webkit [37864] by mrowe@apple.com

2 edits in trunk/WebKit/mac

<rdar://problem/6119711> Remove the dependency on Foundation's private COCOA_FORMAL_PROTOCOLS define.

Rubber-stamped by Tim Hatcher.

2:12 PM Changeset in webkit [37863] by adele@apple.com

23 edits
6 adds in trunk

WebCore:

2008-10-24 Adele Peterson <adele@apple.com>

Reviewed by Sam Weinig.

WebCore part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.

This change adds support for multiple file selection in an <input type="file"> control when the "multiple" attribute is used.
This is consistent with the direction HTML5 will be going in the future.

The initial implementation here will show "n files" as the text next to the control when multiple files are selected. You can view
the individual files in a tooltip for now. Improvements to this control will come later.

Web developers will be able to access the FileList from the HTMLInputElement element, where they can get a base name and a size for each file.
These FileList Files can also be sent in an XMLHTTPRequest.

manual-tests/post-multi-file-upload.html: Added.
manual-tests/resources/multiFileResources: Added.
manual-tests/resources/multiFileResources/post-echo-and-notify-done.cgi: Added.
manual-tests/resources/multiFileResources/testFile1.html: Added.
manual-tests/resources/multiFileResources/testFile2.html: Added.
manual-tests/resources/multiFileResources/testFile3.html: Added.

WebCore.base.exp: Added support to export the new "chooseFilenames" method to be used in WebKit.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Add support for the multiple attribute. (WebCore::HTMLInputElement::value): Added comments. The HTML5 spec says that value shouldn't apply for the file upload control, but we don't want to break the behavior for existing websites that may rely on this. (WebCore::HTMLInputElement::setValue): ditto. (WebCore::HTMLInputElement::setValueFromRenderer): This is no longer used for file upload controls. setFileListFromRenderer is used instead. (WebCore::HTMLInputElement::setFileListFromRenderer): Added.
html/HTMLInputElement.h:

page/Chrome.cpp: (WebCore::Chrome::setToolTip): Show a tooltip with the file name list for the multi-file upload control.

page/DragController.cpp: (WebCore::DragController::concludeDrag): Updated to support multiple files.

platform/FileChooser.cpp: Add support for maintaining a list of file paths that can be retrieved by the renderer. (WebCore::FileChooser::FileChooser): (WebCore::FileChooser::create): (WebCore::FileChooser::clear): (WebCore::FileChooser::chooseFile): (WebCore::FileChooser::chooseFiles): (WebCore::FileChooser::chooseIcon):
platform/FileChooser.h: (WebCore::FileChooser::filePaths): (WebCore::FileChooser::allowsMultipleFiles):

platform/graphics/Icon.h:
platform/graphics/mac/IconMac.mm: (WebCore::Icon::newIconForFiles): Returns a generic icon for multiple files.
platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::newIconForFiles): stubbed out.
platform/graphics/qt/IconQt.cpp: (WebCore::Icon::newIconForFiles): ditto.
platform/graphics/win/IconWin.cpp: (WebCore::Icon::newIconForFiles): ditto.

platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth): Updated to deal with new filenames vector.
platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth): ditto.
platform/qt/FileChooserQt.cpp: (WebCore::FileChooser::openFileChooser): (WebCore::FileChooser::basenameForWidth):
platform/win/FileChooserWin.cpp: (WebCore::FileChooser::basenameForWidth):

platform/network/mac/FormDataStreamMac.mm: (WebCore::disassociateStreamWithResourceHandle): Removed unnecessary assertion. This can get hit when connectionDidFinishLoading and cancel both get called for the same ResourceHandle. This getting called twice has no negative effect.

rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::valueChanged): Calls setFileListFromRenderer. (WebCore::RenderFileUploadControl::allowsMultipleFiles): Added. (WebCore::RenderFileUploadControl::updateFromElement): Uses the new filenames call from FileChooser. (WebCore::RenderFileUploadControl::receiveDroppedFiles): Updated to support multiple files.
rendering/RenderFileUploadControl.h:

WebKit/mac:

2008-10-24 Adele Peterson <adele@apple.com>

Reviewed by Sam Weinig.

WebKit part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.

WebCoreSupport/WebChromeClient.mm: (WebChromeClient::runOpenPanel): (-[WebOpenPanelResultListener chooseFilenames:]):
WebView/WebUIDelegate.h:

2:09 PM Changeset in webkit [37862] by Adam Roben

2 edits in trunk/WebKit/cf

Windows build fix

WebCoreSupport/WebInspectorClientCF.cpp: Define WTF_PLATFORM_CF manually. Normally this gets defined on Windows by including config.h, but Mac has no config.h for WebKit, so we can't do that here.

2:07 PM Changeset in webkit [37861] by cwzwarich@webkit.org

3 edits in trunk/JavaScriptCore

2008-10-24 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Remove ScopeChainNode::bottom() and inline it into its only caller,
ScopeChainnode::globalObject().

kjs/JSGlobalObject.h: (JSC::ScopeChainNode::globalObject):
kjs/ScopeChain.h: (JSC::ScopeChain::bottom):

1:54 PM Changeset in webkit [37860] by ddkilzer@apple.com

2 edits in trunk/WebKit/wx

Build fix.

Reviewed by Greg Bolsinga.

WebKitSupport/InspectorClientWx.cpp: (WebCore::InspectorClientWx::populateSetting): Changed

InspectorClient: to InspectorClientWx::. (WebCore::InspectorClientWx::storeSetting): Ditto. (WebCore::InspectorClientWx::removeSetting): Ditto.

1:44 PM Changeset in webkit [37859] by cwzwarich@webkit.org

3 edits in trunk/JavaScriptCore

2008-10-24 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Bug 21862: Create JSFunction prototype property lazily
<https://bugs.webkit.org/show_bug.cgi?id=21862>

This is a 1.5% speedup on SunSpider and a 1.4% speedup on the V8
benchmark suite, including a 3.8% speedup on Earley-Boyer.

kjs/JSFunction.cpp: (JSC::JSFunction::getOwnPropertySlot):
kjs/nodes.cpp: (JSC::FuncDeclNode::makeFunction): (JSC::FuncExprNode::makeFunction):

1:43 PM Changeset in webkit [37858] by pkasting@chromium.org

6 edits in trunk/WebCore

2008-10-23 Peter Kasting <pkasting@google.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=21844
Remove setFocusRingColorChangeFunction.

page/Page.cpp: (WebCore::Page::Page):
platform/graphics/Color.h:
platform/graphics/mac/ColorMac.mm: (WebCore::focusRingColor):
platform/graphics/qt/GraphicsContextQt.cpp:
platform/graphics/win/ColorSafari.cpp:

1:32 PM Changeset in webkit [37857] by ddkilzer@apple.com

2 edits in trunk/WebCore

Build fix for Qt.

Reviewed by Greg.

WebCore.pro: Added missing *.idl files.

1:27 PM Changeset in webkit [37856] by timothy@apple.com

1 edit in trunk/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp

Fix the Windows build.

1:23 PM Changeset in webkit [37855] by Simon Fraser

2 edits in trunk/LayoutTests

2008-10-24 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig

Add to the comment some new CSSRule types that are not yet tested.

fast/dom/wrapper-classes.html:

1:10 PM Changeset in webkit [37854] by ddkilzer@apple.com

20 edits
24 adds in trunk

JavaScriptCore:

2008-10-24 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21475

Provide support for the Geolocation API

http://dev.w3.org/geo/api/spec-source.html

wtf/Platform.h: ENABLE_GEOLOCATION defaults to 0

WebCore:

2008-10-24 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21475

Provide support for the Geolocation API

http://dev.w3.org/geo/api/spec-source.html

Test: geolocation/geolocation-not-implemented.html

DerivedSources.make:
GNUmakefile.am: Added Geolocation support
WebCore.pro: Added Geolocation support
WebCore.vcproj/WebCore.vcproj: Added Geolocation support
WebCore.xcodeproj/project.pbxproj: Added Geolocation support
WebCoreSources.bkl: Added Geolocation support
bindings/js/JSCustomPositionCallback.cpp: Added. (WebCore::JSCustomPositionCallback::JSCustomPositionCallback): (WebCore::JSCustomPositionCallback::handleEvent):
bindings/js/JSCustomPositionCallback.h: Added. (WebCore::JSCustomPositionCallback::create):
bindings/js/JSCustomPositionErrorCallback.cpp: Added. (WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback): (WebCore::JSCustomPositionErrorCallback::handleEvent):
bindings/js/JSCustomPositionErrorCallback.h: Added. (WebCore::JSCustomPositionErrorCallback::create):
bindings/js/JSDOMBinding.cpp: move markDOMObjectWrapper here from JSDOMWindowCustom (WebCore::markDOMObjectWrapper):
bindings/js/JSDOMBinding.h: move markDOMObjectWrapper here from JSDOMWindowCustom
bindings/js/JSDOMWindowCustom.cpp: move markDOMObjectWrapper to JSDOMBinding
bindings/js/JSGeolocationCustom.cpp: Added. (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):
bindings/js/JSNavigatorCustom.cpp: handle marking Geolocation (WebCore::JSNavigator::mark):
dom/Document.cpp: (WebCore::Document::Document):
dom/Document.h: (WebCore::Document::setUsingGeolocation): (WebCore::Document::usingGeolocation):
loader/FrameLoader.cpp: don't add to back forward cache if using Geolocation (WebCore::FrameLoader::canCachePage):
page/Geolocation.cpp: Added. (WebCore::Geolocation::GeoNotifier::GeoNotifier): (WebCore::Geolocation::GeoNotifier::timerFired): (WebCore::Geolocation::Geolocation): (WebCore::Geolocation::disconnectFrame): (WebCore::Geolocation::getCurrentPosition): (WebCore::Geolocation::watchPosition): (WebCore::Geolocation::clearWatch): (WebCore::Geolocation::stopUpdatingIfEmpty): (WebCore::Geolocation::sendErrorToOneShots): (WebCore::Geolocation::sendErrorToWatchers): (WebCore::Geolocation::sendPositionToOneShots): (WebCore::Geolocation::sendPositionToWatchers): (WebCore::Geolocation::handleError): (WebCore::Geolocation::geolocationServicePositionChanged): (WebCore::Geolocation::geolocationServiceErrorOccurred):
page/Geolocation.h: Added. (WebCore::Geolocation::create): (WebCore::Geolocation::~Geolocation): (WebCore::Geolocation::lastPosition): (WebCore::Geolocation::GeoNotifier::create):
page/Geolocation.idl: Added.
page/Geoposition.cpp: Added. (WebCore::Geoposition::toString):
page/Geoposition.h: Added. (WebCore::Geoposition::create): (WebCore::Geoposition::latitude): (WebCore::Geoposition::longitude): (WebCore::Geoposition::altitude): (WebCore::Geoposition::accuracy): (WebCore::Geoposition::altitudeAccuracy): (WebCore::Geoposition::heading): (WebCore::Geoposition::velocity): (WebCore::Geoposition::timestamp): (WebCore::Geoposition::Geoposition):
page/Geoposition.idl: Added.
page/Navigator.cpp: (WebCore::Navigator::disconnectFrame): disconnect Geolocation (WebCore::Navigator::geolocation): accessor for Geolocation
page/Navigator.h: (WebCore::Navigator::optionalGeolocation): accessor for Geolocation
page/Navigator.idl: accessor for Geolocation
page/PositionCallback.h: Added. (WebCore::PositionCallback::~PositionCallback):
page/PositionCallback.idl: Added.
page/PositionError.h: Added. (WebCore::PositionError::): (WebCore::PositionError::create): (WebCore::PositionError::code): (WebCore::PositionError::message): (WebCore::PositionError::PositionError):
page/PositionError.idl: Added.
page/PositionErrorCallback.h: Added. (WebCore::PositionErrorCallback::~PositionErrorCallback):
page/PositionErrorCallback.idl: Added.
page/PositionOptions.h: Added. (WebCore::PositionOptions::create): (WebCore::PositionOptions::enableHighAccuracy): (WebCore::PositionOptions::setEnableHighAccuracy): (WebCore::PositionOptions::timeout): (WebCore::PositionOptions::setTimeout): (WebCore::PositionOptions::PositionOptions):
page/PositionOptions.idl: Added.
platform/GeolocationService.cpp: Added. (WebCore::GeolocationService::GeolocationService): (WebCore::GeolocationService::positionChanged): (WebCore::GeolocationService::errorOccurred):
platform/GeolocationService.h: Added. (WebCore::GeolocationServiceClient::~GeolocationServiceClient): (WebCore::GeolocationServiceClient::geolocationServicePositionChanged): (WebCore::GeolocationServiceClient::geolocationServiceErrorOccurred): (WebCore::GeolocationService::~GeolocationService):

LayoutTests:

2008-10-24 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21475

Provide support for the Geolocation API

http://dev.w3.org/geo/api/spec-source.html

Tests to verify Geolocation isn't implemented (so that it didn't leak into
WebCore for platforms that do not support it).

geolocation: Added.
geolocation/geolocation-not-implemented-expected.txt: Added.
geolocation/geolocation-not-implemented.html: Added.
geolocation/geolocation-test.js: Copied from LayoutTests/media/video-test.js. (reset): (hanged): (watchPositionAndEnd): (watchPosition._positionCallback): (watchPosition): (watchPositionTestAndEnd): (watchPositionAndFail): (watchPositionAndTest._positionCallback): (watchPositionAndTest): (getCurrentPositionAndEnd): (getCurrentPosition._positionCallback): (getCurrentPosition): (getCurrentPositionTestAndEnd): (getCurrentPositionAndFail): (getCurrentPositionAndTest._positionCallback): (getCurrentPositionAndTest): (endTest): (relativeURL):

12:59 PM Changeset in webkit [37853] by Simon Fraser

4 edits in trunk/LayoutTests

2008-10-24 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=21858

Add additional CSSRule types to the DOM-wrapper tests.

fast/dom/resources/wrapper-identity-base.js:
fast/dom/wrapper-identity-expected.txt:
platform/mac/fast/dom/objc-wrapper-identity-expected.txt:

12:32 PM Changeset in webkit [37852] by Simon Fraser

7 edits
1 add in trunk/WebCore

2008-10-24 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=21818

Add HashTraits for AtomicString so that AtomicString can be used as
the key for a HashMap or HashSet.

GNUmakefile.am: add AtomicStringHash.h
WebCore.vcproj/WebCore.vcproj: add AtomicStringHash.h
WebCore.xcodeproj/project.pbxproj: add AtomicStringHash.h
platform/text/AtomicString.h: (WebCore::AtomicString::AtomicString): (WebCore::AtomicString::isHashTableDeletedValue):

specialize DefaultHash for AtomicString to use AtomicStringHash

platform/text/AtomicStringHash.h: Added.
platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl):

compute the hash up-front for the empty string

platform/text/StringImpl.h: (WebCore::StringImpl::existingHash):

method to get the hash without a test and branch, for callers like
AtomicStringHash who can guarantee that the hash has already been computed.

12:15 PM Changeset in webkit [37851] by Simon Fraser

2 edits in trunk/WebCore

2008-10-24 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig

https://bugs.webkit.org/show_bug.cgi?id=21857

Add WebKitCSSKeyframeRule and WebKitCSSKeyframesRule to the
switch in _wrapCSSRule.

bindings/objc/DOMCSS.mm: (+[DOMCSSRule _wrapCSSRule:WebCore::]):

12:14 PM Changeset in webkit [37850] by Adam Roben

2 edits in trunk/WebCore

Windows build fix

plugins/PluginView.cpp:

12:10 PM Changeset in webkit [37849] by mitz@apple.com

3 edits
4 adds in trunk

WebCore:

Reviewed by Sam Weinig.

fix https://bugs.webkit.org/show_bug.cgi?id=21851 <rdar://problem/6304151> REGRESSION (r36513): Crash when removing a widget with percent height

Test: fast/replaced/percent-height-in-anonymous-block-widget.html

rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy): Copied code added to RenderBox::destroy() in r36513 into this function.

LayoutTests:

Reviewed by Sam Weinig.

test for https://bugs.webkit.org/show_bug.cgi?id=21851 <rdar://problem/6304151> REGRESSION (r36513): Crash when removing a widget with percent height

fast/replaced/percent-height-in-anonymous-block-widget.html: Added.
platform/mac/fast/replaced/percent-height-in-anonymous-block-widget-expected.checksum: Added.
platform/mac/fast/replaced/percent-height-in-anonymous-block-widget-expected.png: Added.
platform/mac/fast/replaced/percent-height-in-anonymous-block-widget-expected.txt: Added.

11:49 AM Changeset in webkit [37848] by timothy@apple.com

22 edits
4 adds in trunk

Add a mechanism to store and retrieve preferences for the Web Inspector.

WebCore:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Add a mechanism to ask the InspectorClient for key/value setting pairs.
These settings can be strings, numbers, booleans or string vectors. The
settings are also bridged to and from JavaScript.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

WebCore.base.exp: Expose the String CFStringRef constructor.
inspector/InspectorClient.h: (WebCore::InspectorClient::populateSetting): Added, pure virtual. (WebCore::InspectorClient::storeSetting): Ditto. (WebCore::InspectorClient::removeSetting): Ditto.
inspector/InspectorController.cpp: (WebCore::setting): Calls InspectorController::setting and wraps the result in script types. (WebCore::setSetting): Calls InspectorController::setSetting after converting from script types. (WebCore::InspectorController::InspectorController): Increment a global static to track the number of live InspectorControllers. (WebCore::InspectorController::~InspectorController): Decrement the global static that tracks the number of live InspectorControllers. Delete the setting cache if there are no more live controllers. (WebCore::InspectorController::setting): Check the cache and return the setting from there, otherwise make a new Setting and ask the client to populate it. (WebCore::InspectorController::setSetting): Change the cache and ask the client to store it. (WebCore::InspectorController::windowScriptObjectAvailable): Add setting and setSetting to the InspectorController script class.
inspector/InspectorController.h: (WebCore::InspectorController::Setting::Setting): (WebCore::InspectorController::Setting::operator=): (WebCore::InspectorController::Setting::type): Return m_type. (WebCore::InspectorController::Setting::string): Return m_string. Assert the type is correct. (WebCore::InspectorController::Setting::stringVector): Return m_stringVector. Assert the type is correct. (WebCore::InspectorController::Setting::doubleValue): Return m_simpleContent.m_double. Assert the type is correct. (WebCore::InspectorController::Setting::integerValue): Return m_simpleContent.m_integer. Assert the type is correct. (WebCore::InspectorController::Setting::booleanValue): Return m_simpleContent.m_boolean. Assert the type is correct. (WebCore::InspectorController::Setting::set): Overloaded for each data type, sets the right field and the type.
loader/EmptyClients.h: (WebCore::EmptyInspectorClient::populateSetting): Added, empty method. (WebCore::EmptyInspectorClient::storeSetting): Ditto. (WebCore::EmptyInspectorClient::removeSetting): Ditto.

WebKit:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Implement new InspectorClient methods to work with Settings.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

WebKit.xcodeproj/project.pbxproj: Add the new InspectorClientCF.cpp file.

WebKit/gtk:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Stub out new InspectorClient methods.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::populateSetting): Not implemented. (WebKit::InspectorClient::storeSetting): Ditto. (WebKit::InspectorClient::removeSetting): Ditto.
WebCoreSupport/InspectorClientGtk.h:

WebKit/mac:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Implement new InspectorClient methods to work with Settings.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

WebCoreSupport/WebInspectorClient.h: Add the new methods and guard the ObjC parts of the header.

WebKit/qt:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Stub out new InspectorClient methods.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::populateSetting): Not implemented. (WebCore::InspectorClientQt::storeSetting): Ditto. (WebCore::InspectorClientQt::removeSetting): Ditto.
WebCoreSupport/InspectorClientQt.h:

WebKit/win:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Implement new InspectorClient methods to work with Settings.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Adam Roben.

WebKit.vcproj/WebKit.vcproj: Add the new InspectorClientCF.cpp file.
WebCoreSupport/WebInspectorClient.h: Add the new methods.

WebKit/wx:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Stub out new InspectorClient methods.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

WebKitSupport/InspectorClientWx.cpp: (WebCore::InspectorClient::populateSetting): Not implemented. (WebCore::InspectorClient::storeSetting): Ditto. (WebCore::InspectorClient::removeSetting): Ditto.
WebKitSupport/InspectorClientWx.h:

11:19 AM Changeset in webkit [37847] by ddkilzer@apple.com

3 edits in trunk/WebKitTools

Bug 21850: svn-apply and svn-unapply should preserve patch line endings

<https://bugs.webkit.org/show_bug.cgi?id=21850>

Reviewed by Adam Roben.

Scripts/svn-apply: Save end-of-line characters when stripping them off each line of a patch so that they may be restored after processing the line.
Scripts/svn-unapply: Ditto.

11:10 AM Changeset in webkit [37846] by cwzwarich@webkit.org

2 edits in trunk/WebCore

2008-10-24 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

Remove some C-style casts.

html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):

9:22 AM Changeset in webkit [37845] by Darin Adler

301 edits in trunk

JavaScriptCore: