Timeline



Oct 29, 2008:

9:33 PM Changeset in webkit [37991] by oliver@apple.com
  • 13 edits in trunk/JavaScriptCore

Initial work to reduce cost of JSNumberCell allocation

Reviewed by Geoffrey Garen

This does the initial work needed to bring more of number
allocation into CTI code directly, rather than just falling
back onto the slow paths if we can't guarantee that a number
cell can be reused.

Initial implementation only used by op_negate to make sure
it all works. In a negate heavy (though not dominated) test
it results in a 10% win in the non-reusable cell case.

8:38 PM Changeset in webkit [37990] by sfalken@apple.com
  • 6 edits in trunk

JavaScriptCore:

2008-10-29 Steve Falkenburg <sfalken@apple.com>

<rdar://problem/6326563> Crash on launch

For Windows, export explicit functions rather than exporting data for atomicallyInitializedStaticMutex.


Exporting data from a DLL on Windows requires specifying declspec(dllimport) in the header used by
callers, but
declspec(dllexport) when defined in the DLL implementation. By instead exporting
the explicit lock/unlock functions, we can avoid this.


Fixes a crash on launch, since we were previously erroneously exporting atomicallyInitializedStaticMutex as a function.


Reviewed by Darin Adler.

  • wtf/Threading.h: (WTF::lockAtomicallyInitializedStaticMutex): (WTF::unlockAtomicallyInitializedStaticMutex):
  • wtf/ThreadingWin.cpp: (WTF::lockAtomicallyInitializedStaticMutex): (WTF::unlockAtomicallyInitializedStaticMutex):

WebKit/win:

2008-10-29 Steve Falkenburg <sfalken@apple.com>

<rdar://problem/6326563> Crash on launch


For Windows, export explicit functions rather than exporting data for atomicallyInitializedStaticMutex.


Exporting data from a DLL on Windows requires specifying declspec(dllimport) in the header used by
callers, but
declspec(dllexport) when defined in the DLL implementation. By instead exporting
the explicit lock/unlock functions, we can avoid this.


Fixes a crash on launch, since we were previously erroneously exporting atomicallyInitializedStaticMutex as a function.


Reviewed by Darin Adler.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def:
7:44 PM Changeset in webkit [37989] by weinig@apple.com
  • 9 edits in trunk/JavaScriptCore

2008-10-29 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Remove direct use of PropertyMap.

  • JavaScriptCore.exp:
  • runtime/JSObject.cpp: (JSC::JSObject::mark): (JSC::JSObject::put): (JSC::JSObject::deleteProperty): (JSC::JSObject::getPropertyAttributes): (JSC::JSObject::removeDirect):
  • runtime/JSObject.h: (JSC::JSObject::getDirect): (JSC::JSObject::getDirectLocation): (JSC::JSObject::hasCustomProperties): (JSC::JSObject::JSObject): (JSC::JSObject::putDirect):
  • runtime/PropertyMap.cpp: (JSC::PropertyMap::get):
  • runtime/PropertyMap.h: (JSC::PropertyMap::isEmpty): (JSC::PropertyMap::get):
  • runtime/StructureID.cpp: (JSC::StructureID::dumpStatistics):
  • runtime/StructureID.h: (JSC::StructureID::propertyStorageSize): (JSC::StructureID::get): (JSC::StructureID::put): (JSC::StructureID::remove): (JSC::StructureID::isEmpty):
6:38 PM Changeset in webkit [37988] by pewtermoose@webkit.org
  • 2 edits in trunk/WebKit

2008-10-29 Matt Lilek <webkit@mattlilek.com>

Not reviewed, build fix.

  • WebKit.xcodeproj/project.pbxproj:
5:49 PM Changeset in webkit [37987] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-10-29 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove an unused forward class declaration.


  • Plugins/WebBaseNetscapePluginView.h:
5:46 PM Changeset in webkit [37986] by andersca@apple.com
  • 7 edits
    2 deletes in trunk/WebKit/mac

2008-10-29 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove WebBaseNetscapePluginViewInternal.h and WebBaseNetscapePluginViewPrivate.h.

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginViewInternal.h: Removed.
  • Plugins/WebBaseNetscapePluginViewPrivate.h: Removed.
  • Plugins/WebNetscapePluginEventHandler.mm:
  • Plugins/WebNetscapePluginEventHandlerCarbon.mm:
  • Plugins/WebNetscapePluginEventHandlerCocoa.mm:
  • Plugins/npapi.mm:
  • WebView/WebHTMLView.mm:
4:52 PM Changeset in webkit [37985] by weinig@apple.com
  • 6 edits
    1 copy in trunk/JavaScriptCore

2008-10-29 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Rename and move the StructureID transition table to its own file.

  • GNUmakefile.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/StructureID.cpp: (JSC::StructureID::addPropertyTransition):
  • runtime/StructureID.h: (JSC::StructureID::):
  • runtime/StructureIDTransitionTable.h: Copied from runtime/StructureID.h. (JSC::StructureIDTransitionTableHash::hash): (JSC::StructureIDTransitionTableHash::equal):
4:47 PM Changeset in webkit [37984] by andersca@apple.com
  • 8 edits
    4 deletes in trunk/WebKit/mac

2008-10-29 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove WebNetscapePluginEmbeddedView, it adds nothing extra now.


Remove WebNetscapePlugInStreamLoaderClient since WebNetscapePluginStream is the client now.


  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.mm:
  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebKitPluginContainerView.h:
  • Plugins/WebNetscapePluginEmbeddedView.h: Removed.
  • Plugins/WebNetscapePluginEmbeddedView.mm: Removed.
  • Plugins/WebNetscapePluginEventHandler.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::NetscapePluginWidget): (NetscapePluginWidget::handleEvent): (WebFrameLoaderClient::createPlugin):
  • WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h: Removed.
  • WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm: Removed.
  • WebView/WebHTMLView.mm: (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
3:53 PM Changeset in webkit [37983] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2008-10-29 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove the WebBaseNetscapePluginStream Objective-C object.


  • Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::create):
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginView:receivedResponse:]): (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
3:39 PM Changeset in webkit [37982] by zecke@webkit.org
  • 13 edits
    2 adds in trunk

2008-10-29 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Holger Freyther.

Added all the files that need to be installed for the Inspector to
work.

WebCore/ChangeLog:
2008-10-29 Gustavo Noronha Silva <gns@gnome.org>

Reviewed and slightly changed by Holger Freyther.

Added all the files that need to be installed for the Inspector to
work.

  • GNUmakefile.am: Invoke the shell to get the files.

WebKit/gtk:
2008-10-29 Gustavo Noronha Silva <gns@gnome.org>

Reviewed and slightly changed by Holger Freyther.

Implemented a new WebKitWebInspector class to provide a GObject
API for the Web Inspector. Also implemented InspectorClient.

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::notifyWebViewDestroyed): (WebKit::InspectorClient::InspectorClient): (WebKit::InspectorClient::inspectorDestroyed): (WebKit::InspectorClient::webViewDestroyed): (WebKit::InspectorClient::createPage): (WebKit::InspectorClient::showWindow): (WebKit::InspectorClient::closeWindow): (WebKit::InspectorClient::attachWindow): (WebKit::InspectorClient::detachWindow): (WebKit::InspectorClient::inspectedURLChanged):
  • WebCoreSupport/InspectorClientGtk.h:
  • webkit/webkit.h:
  • webkit/webkit-marshal.list:
  • webkit/webkitdefines.h:
  • webkit/webkitprivate.h:
  • webkit/webkitwebinspector.cpp: Added. (_WebKitWebInspectorPrivate::webkit_inspect_web_view_request_handled): (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init): (_WebKitWebInspectorPrivate::webkit_web_inspector_init): (_WebKitWebInspectorPrivate::webkit_web_inspector_finalize): (_WebKitWebInspectorPrivate::webkit_web_inspector_set_property): (_WebKitWebInspectorPrivate::webkit_web_inspector_get_property): (_WebKitWebInspectorPrivate::webkit_web_inspector_set_web_view):
  • webkit/webkitwebinspector.h: Added.
  • webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::): (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
  • webkit/webkitwebview.cpp:
  • webkit/webkitwebview.h:
3:27 PM Changeset in webkit [37981] by weinig@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-10-29 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21958
Pack bits in StructureID to reduce the size of each StructureID by 2 words.

  • runtime/PropertyMap.h: (JSC::PropertyMap::propertyMapSize):
  • runtime/StructureID.cpp: (JSC::StructureID::dumpStatistics): Add additional size statistics when dumping. (JSC::StructureID::StructureID):
  • runtime/StructureID.h:
2:45 PM Changeset in webkit [37980] by darin@chromium.org
  • 2 edits in trunk/WebCore

2008-10-29 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Darin Adler

Add MediaPlayerPrivateChromium to MediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=21930

  • platform/graphics/MediaPlayer.cpp:
2:43 PM Changeset in webkit [37979] by justin.garcia@apple.com
  • 2 edits in trunk/WebCore

2008-10-29 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin Adler.

Some preparation for:
<rdar://problem/6104369> Hitting return at the end of a quoted line creates an extraneous quoted line


Added an early return to avoid a level of if-nesting. No other changes. We probably don't
need to rebalance whitespace before the early return but for now don't risk any change in behavior
I'll revisit that later.

  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
2:21 PM Changeset in webkit [37978] by jhoneycutt@apple.com
  • 3 edits in trunk/WebKit/win

2008-10-29 Jon Honeycutt <jhoneycutt@apple.com>

Export atomicallyInitializedStaticMutex.

Rubber-stamped by Steve Falkenburg.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def:
1:19 PM Changeset in webkit [37977] by zecke@webkit.org
  • 3 edits in trunk

2008-10-29 Mike Hommey <glandium@debian.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=21884
Test presence and link against libpng.

  • GNUmakefile.am:
  • configure.ac:
1:13 PM Changeset in webkit [37976] by kevino@webkit.org
  • 8 edits
    1 add in trunk

wx build fixes after addition of runtime and ImageBuffer changes.

12:59 PM Changeset in webkit [37975] by beidson@apple.com
  • 3 edits in trunk/WebKit/mac

2008-10-29 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

https://bugs.webkit.org/show_bug.cgi?id=21952


Address an outstanding FIXME by removing unused SPI

  • History/WebHistory.mm: (-[WebHistory _addItemForURL:title:]): Fold addItem: into this method
  • History/WebHistoryPrivate.h: Removed unused/unneccessary SPI
12:34 PM Changeset in webkit [37974] by jmalonzo@webkit.org
  • 3 edits in trunk

2008-10-29 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

Add --enable-optimizations to enable optimized builds. The default
is to enable it for release builds, and disabled for debug builds.
This option will allow builders to have a debug as well as
optimized builds.

  • GNUmakefile.am:
  • configure.ac:
9:38 AM Changeset in webkit [37973] by brettw@chromium.org
  • 2 edits in trunk/WebCore

Allow Skia implementations to get text style changed notifications.

8:19 AM Web Inspector edited by dmitrykichenko@gmail.com
(diff)
8:18 AM Web Inspector edited by dmitrykichenko@gmail.com
The instructions here did not work for me but adding the key into … (diff)
8:02 AM Changeset in webkit [37972] by timothy@apple.com
  • 3 edits
    1 add in trunk

Emit the WillExecuteStatement debugger hook before the "else" body when there is no block for the "else" body. This allows breakpoints on those statements in the Web Inspector.

JavaScriptCore:

2008-10-28 Timothy Hatcher <timothy@apple.com>

Emit the WillExecuteStatement debugger hook before the "else" body
when there is no block for the "else" body. This allows breakpoints
on those statements in the Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=21944

Reviewed by Maciej Stachowiak.

  • kjs/nodes.cpp: (JSC::IfElseNode::emitCode): Emit the WillExecuteStatement debugger hook before the else node if isn't a block.

WebCore:

2008-10-28 Timothy Hatcher <timothy@apple.com>

Add a manual test that checks breakpoints on a blockless body of
an "else" statement.

https://bugs.webkit.org/show_bug.cgi?id=21944

Reviewed by Maciej Stachowiak.

  • manual-tests/inspector/debugger-pause-on-else-statements.html: Added.
3:44 AM Changeset in webkit [37971] by ap@webkit.org
  • 4 edits in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21921
MessagePort messages are dispatched to documents that are not fully active

Covered by corrected fast/events/message-port-inactive-document.html

  • bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent): Don't dispatch messages to contexts that are not fully active.
3:40 AM Changeset in webkit [37970] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Build fix.

3:37 AM Changeset in webkit [37969] by ap@webkit.org
  • 6 edits in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21922
Expose MessagePort global constructor

Covered by existing dumper tests.

  • dom/MessagePort.idl:
  • page/DOMWindow.idl:
3:35 AM Changeset in webkit [37968] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21924
HashTable internal index is not always deleted

  • bindings/js/JSDOMBinding.cpp: (WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap): Call deleteTable for HashTables that are being deleted.
3:31 AM Changeset in webkit [37967] by ap@webkit.org
  • 3 edits in trunk/LayoutTests/platform/mac/svg/carto.net

Missed these files in an earlier check-in for <https://bugs.webkit.org/show_bug.cgi?id=21893>.

3:26 AM Changeset in webkit [37966] by ap@webkit.org
  • 35 edits
    2 adds in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21923
Create an abstraction for script execution context

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Added ScriptExecutionContext.{h,cpp}.
  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSAudioConstructor.h:
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSImageConstructor.h:
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSOptionConstructor.h:
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
  • bindings/js/JSXMLHttpRequestConstructor.h: Pass ScriptExecutionContext instead of Document to make getDOMConstructor() happy. Since these objects can only work within documents now, it is immediately converted back to Document.
  • bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): (WebCore::JSMessageChannelConstructor::construct):
  • bindings/js/JSMessageChannelConstructor.h: (WebCore::JSMessageChannelConstructor::scriptExecutionContext): MessageChannel needs to be supported in workers right away, so the constructor operates with it directly.
  • dom/ActiveDOMObject.cpp: (WebCore::ActiveDOMObject::ActiveDOMObject): (WebCore::ActiveDOMObject::~ActiveDOMObject): (WebCore::ActiveDOMObject::contextDestroyed):
  • dom/ActiveDOMObject.h: (WebCore::ActiveDOMObject::scriptExecutionContext):
  • bindings/js/JSDOMBinding.cpp: (WebCore::markActiveObjectsForContext): (WebCore::markCrossHeapDependentObjectsForContext): Use ScriptExecutionContext instead of Document, now that ActiveDOMObject and MessagePort tracking is handled by ScriptExecutionContext.
  • bindings/js/JSDOMBinding.h: (WebCore::getDOMPrototype): Moved to JSDOMGlobalObject.
  • bindings/js/JSDOMGlobalObject.h: (WebCore::getDOMConstructor): Moved to this file, as constructors live in JSDOMGlobalObject. Also, the two-argument version that used to be in JSDOMWindowBase.cpp need to be accessible to worker context implementation. (WebCore::scriptExecutionContext): Added a pure virtual method to access ScriptExecutionContext, implemented by subclasses.
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::scriptExecutionContext): Implement by returning the associated document. Note that this method currently gives bogus results after navigation - DOMWindow Frame reference is not zeroed out, so we get a document that is currently in the frame, not the one associated with this window.
  • bindings/js/JSDedicatedWorkerConstructor.cpp: Removed unnecessary include of DOMWindow.h.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::mark): Call markActiveObjectsForContext() by its new name.
  • dom/DedicatedWorker.cpp: (WebCore::DedicatedWorker::DedicatedWorker): (WebCore::DedicatedWorker::document):
  • dom/DedicatedWorker.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::document):
  • xml/XMLHttpRequest.h: Added a document() function that upcasts ScriptExecutionContext, as these objects only work within documents currently (at least for XMLHttpRequest, this will change soon though).
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): Moved active object and MessagePort tracking up to ScriptExecutionContext, to share code with workers.


  • dom/Document.h: (WebCore::Document::isDocument): (WebCore::Document::refScriptExecutionContext): (WebCore::Document::derefScriptExecutionContext): Inherit from ScriptExecutionContext.
  • dom/MessageChannel.cpp: (WebCore::MessageChannel::MessageChannel):
  • dom/MessageChannel.h: (WebCore::MessageChannel::create): Use ScriptExecutionContext instead of Document.
  • dom/MessagePort.cpp: (WebCore::CloseMessagePortTimer::CloseMessagePortTimer): Make m_port a RefPtr, because MessagePort doesn't ref() itself when posting this event any more (this is a fix for an unrelated issue that was causing random crashes in layout tests). (WebCore::MessagePort::MessagePort): (WebCore::MessagePort::~MessagePort): (WebCore::MessagePort::associatedFrame): (WebCore::MessagePort::clone): (WebCore::MessagePort::postMessage): (WebCore::MessagePort::startConversation): (WebCore::MessagePort::start): (WebCore::MessagePort::contextDestroyed): (WebCore::MessagePort::dispatchMessages):
  • dom/MessagePort.h: (WebCore::MessagePort::create): (WebCore::MessagePort::scriptExecutionContext): Use ScriptExecutionContext instead of Document. This is a step toward making MessagePort work in worker contexts - we need to also make some its method thread safe for cross-thread messaging, and make event dispatching thread safe.
  • dom/ScriptExecutionContext.cpp: Added.
  • dom/ScriptExecutionContext.h: Added. ActiveDOMObject and MessagePort tracking is moved from Document. It is debatable whether ScriptExecutionContext should be a parent of Document or DOMWindow, but as I'm just moving Document code, and it is Document that is the main context object in our implementation currently. Changing ScriptExecutionContext to be a parent of DOMWindow causes a number of bugs that seem non-trivial to fix, and isn't really a part of this task.

Oct 28, 2008:

11:01 PM Changeset in webkit [37965] by timothy@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/IWebInspector.idl

Attempt to fix the Windows build.

10:28 PM Changeset in webkit [37964] by timothy@apple.com
  • 1 edit in trunk/WebKitTools/DumpRenderTree/win/DumpRenderTree.cpp

Attempt to fix the Windows build.

10:22 PM Changeset in webkit [37963] by alp@webkit.org
  • 4 edits in trunk

2008-10-28 Alp Toker <alp@nuanti.com>

Fix builddir != srcdir builds after kjs -> runtime breakage. Sources
may now be generated in both kjs/ and runtime/.

Also sort the sources list for readability.

List newly-added ImageBufferData.h in build system.

9:47 PM Changeset in webkit [37962] by alp@webkit.org
  • 2 edits in trunk/WebKitTools

2008-10-28 Alp Toker <alp@nuanti.com>

Fix GTK DRT following build breakage in r37928.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dump): (runTest): (main):
9:42 PM Changeset in webkit [37961] by timothy@apple.com
  • 1 edit in trunk/WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp

Attempt to fix the Windows build.

8:20 PM Changeset in webkit [37960] by alp@webkit.org
  • 4 edits in trunk

2008-10-28 Alp Toker <alp@nuanti.com>

Reviewed by Cameron Zwarich.

Build fix attempt after kjs -> runtime rename.

De-list unused WebCore ForwardingHeaders to fix the dist target.

8:02 PM Changeset in webkit [37959] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Remove a duplicate includes directory.

7:41 PM Changeset in webkit [37958] by cwzwarich@webkit.org
  • 5 edits in trunk

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Attempt to fix the Windows build.

JavaScriptCore:

WebCore:

  • WebCore.vcproj/WebCore.vcproj:
7:07 PM Changeset in webkit [37957] by justin.garcia@apple.com
  • 5 edits in trunk

WebCore:

2008-10-28 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin Adler.

<rdar://problem/5188560> REGRESSION: Spell checker doesn't clear spelling/grammar marker after error is marked as Ignored

  • editing/Editor.cpp: (WebCore::Editor::ignoreSpelling): Remove misspelling markers from the word. (WebCore::Editor::learnSpelling): Added a FIXME about <rdar://problem/5396072>, which will probably require a change more complicated than just marking the learned word as misspelled. I'll address it with a separate patch.
  • editing/EditorCommand.cpp: (WebCore::executeIgnoreSpelling): Added. (WebCore::CommandEntry::): Added an entry for IgnoreSpelling.

WebKit/mac:

2008-10-28 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin Adler.


<rdar://problem/5188560> REGRESSION: Spell checker doesn't clear spelling/grammar marker after error is marked as Ignored

  • WebView/WebHTMLView.mm: IgnoreSpelling is now a WebCore command. That command handles calling back into WebKit to perform the cross platform work that was removed in this change.
6:54 PM Changeset in webkit [37956] by cwzwarich@webkit.org
  • 77 edits
    27 moves
    2 adds in trunk

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Reviewed by Mark Rowe.

Move ForwardingHeaders to their correct location after the creation of
the runtime directory in JavaScriptCore.

WebCore:

  • ForwardingHeaders/kjs/ArrayPrototype.h: Removed.
  • ForwardingHeaders/kjs/BooleanObject.h: Removed.
  • ForwardingHeaders/kjs/CallData.h: Removed.
  • ForwardingHeaders/kjs/ConstructData.h: Removed.
  • ForwardingHeaders/kjs/DateInstance.h: Removed.
  • ForwardingHeaders/kjs/Error.h: Removed.
  • ForwardingHeaders/kjs/FunctionConstructor.h: Removed.
  • ForwardingHeaders/kjs/FunctionPrototype.h: Removed.
  • ForwardingHeaders/kjs/InternalFunction.h: Removed.
  • ForwardingHeaders/kjs/JSArray.h: Removed.
  • ForwardingHeaders/kjs/JSFunction.h: Removed.
  • ForwardingHeaders/kjs/JSGlobalObject.h: Removed.
  • ForwardingHeaders/kjs/JSNumberCell.h: Removed.
  • ForwardingHeaders/kjs/JSObject.h: Removed.
  • ForwardingHeaders/kjs/JSString.h: Removed.
  • ForwardingHeaders/kjs/JSValue.h: Removed.
  • ForwardingHeaders/kjs/ObjectPrototype.h: Removed.
  • ForwardingHeaders/kjs/PropertyMap.h: Removed.
  • ForwardingHeaders/kjs/PrototypeFunction.h: Removed.
  • ForwardingHeaders/kjs/StringObject.h: Removed.
  • ForwardingHeaders/kjs/StringObjectThatMasqueradesAsUndefined.h: Removed.
  • ForwardingHeaders/kjs/StringPrototype.h: Removed.
  • ForwardingHeaders/kjs/StructureID.h: Removed.
  • ForwardingHeaders/runtime: Added.
  • ForwardingHeaders/runtime/ArrayPrototype.h: Copied from ForwardingHeaders/kjs/ArrayPrototype.h.
  • ForwardingHeaders/runtime/BooleanObject.h: Copied from ForwardingHeaders/kjs/BooleanObject.h.
  • ForwardingHeaders/runtime/CallData.h: Copied from ForwardingHeaders/kjs/CallData.h.
  • ForwardingHeaders/runtime/ConstructData.h: Copied from ForwardingHeaders/kjs/ConstructData.h.
  • ForwardingHeaders/runtime/DateInstance.h: Copied from ForwardingHeaders/kjs/DateInstance.h.
  • ForwardingHeaders/runtime/Error.h: Copied from ForwardingHeaders/kjs/Error.h.
  • ForwardingHeaders/runtime/FunctionConstructor.h: Copied from ForwardingHeaders/kjs/FunctionConstructor.h.
  • ForwardingHeaders/runtime/FunctionPrototype.h: Copied from ForwardingHeaders/kjs/FunctionPrototype.h.
  • ForwardingHeaders/runtime/InternalFunction.h: Copied from ForwardingHeaders/kjs/InternalFunction.h.
  • ForwardingHeaders/runtime/JSArray.h: Copied from ForwardingHeaders/kjs/JSArray.h.
  • ForwardingHeaders/runtime/JSFunction.h: Copied from ForwardingHeaders/kjs/JSFunction.h.
  • ForwardingHeaders/runtime/JSGlobalObject.h: Copied from ForwardingHeaders/kjs/JSGlobalObject.h.
  • ForwardingHeaders/runtime/JSNumberCell.h: Copied from ForwardingHeaders/kjs/JSNumberCell.h.
  • ForwardingHeaders/runtime/JSObject.h: Copied from ForwardingHeaders/kjs/JSObject.h.
  • ForwardingHeaders/runtime/JSString.h: Copied from ForwardingHeaders/kjs/JSString.h.
  • ForwardingHeaders/runtime/JSValue.h: Copied from ForwardingHeaders/kjs/JSValue.h.
  • ForwardingHeaders/runtime/ObjectPrototype.h: Copied from ForwardingHeaders/kjs/ObjectPrototype.h.
  • ForwardingHeaders/runtime/PropertyMap.h: Copied from ForwardingHeaders/kjs/PropertyMap.h.
  • ForwardingHeaders/runtime/PrototypeFunction.h: Copied from ForwardingHeaders/kjs/PrototypeFunction.h.
  • ForwardingHeaders/runtime/StringObject.h: Copied from ForwardingHeaders/kjs/StringObject.h.
  • ForwardingHeaders/runtime/StringObjectThatMasqueradesAsUndefined.h: Copied from ForwardingHeaders/kjs/StringObjectThatMasqueradesAsUndefined.h.
  • ForwardingHeaders/runtime/StringPrototype.h: Copied from ForwardingHeaders/kjs/StringPrototype.h.
  • ForwardingHeaders/runtime/StructureID.h: Copied from ForwardingHeaders/kjs/StructureID.h.
  • bindings/js/JSCSSStyleDeclarationCustom.cpp:
  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • bindings/js/JSClipboardCustom.cpp:
  • bindings/js/JSConsoleCustom.cpp:
  • bindings/js/JSCustomPositionCallback.h:
  • bindings/js/JSCustomPositionErrorCallback.h:
  • bindings/js/JSCustomSQLStatementCallback.h:
  • bindings/js/JSCustomSQLStatementErrorCallback.h:
  • bindings/js/JSCustomSQLTransactionErrorCallback.h:
  • bindings/js/JSCustomVoidCallback.h:
  • bindings/js/JSCustomXPathNSResolver.h:
  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/JSDatabaseCustom.cpp:
  • bindings/js/JSEventListener.cpp:
  • bindings/js/JSEventTarget.h:
  • bindings/js/JSHTMLDocumentCustom.cpp:
  • bindings/js/JSHistoryCustom.cpp:
  • bindings/js/JSInspectedObjectWrapper.cpp:
  • bindings/js/JSJavaScriptCallFrameCustom.cpp:
  • bindings/js/JSLocationCustom.cpp:
  • bindings/js/JSNodeFilterCondition.h:
  • bindings/js/JSQuarantinedObjectWrapper.cpp:
  • bindings/js/JSQuarantinedObjectWrapper.h:
  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  • bindings/objc/WebScriptObject.mm:
  • bindings/objc/WebScriptObjectPrivate.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/NP_jsobject.cpp:
  • bridge/c/c_instance.cpp:
  • bridge/c/c_utility.cpp:
  • bridge/c/c_utility.h:
  • bridge/jni/jni_instance.cpp:
  • bridge/jni/jni_jsobject.h:
  • bridge/jni/jni_jsobject.mm:
  • bridge/jni/jni_runtime.cpp:
  • bridge/jni/jni_utility.cpp:
  • bridge/jni/jni_utility.h:
  • bridge/objc/objc_instance.mm:
  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:
  • bridge/objc/objc_utility.h:
  • bridge/objc/objc_utility.mm:
  • bridge/runtime.h:
  • bridge/runtime_array.cpp:
  • bridge/runtime_array.h:
  • bridge/runtime_method.cpp:
  • bridge/runtime_method.h:
  • bridge/runtime_object.cpp:
  • bridge/runtime_object.h:
  • bridge/runtime_root.cpp:
  • inspector/JavaScriptCallFrame.cpp:
  • inspector/JavaScriptProfile.cpp:
  • inspector/JavaScriptProfile.h:
  • inspector/JavaScriptProfileNode.cpp:
  • inspector/JavaScriptProfileNode.h:
  • loader/FrameLoader.cpp:
  • page/Console.cpp:
  • plugins/PluginView.cpp:
  • plugins/gtk/PluginViewGtk.cpp:
  • plugins/qt/PluginViewQt.cpp:
  • plugins/win/PluginViewWin.cpp:

WebKit/mac:

  • ForwardingHeaders/kjs/JSFunction.h: Removed.
  • ForwardingHeaders/kjs/JSObject.h: Removed.
  • ForwardingHeaders/kjs/JSString.h: Removed.
  • ForwardingHeaders/kjs/JSValue.h: Removed.
  • ForwardingHeaders/runtime: Added.
  • ForwardingHeaders/runtime/JSFunction.h: Copied from ForwardingHeaders/kjs/JSFunction.h.
  • ForwardingHeaders/runtime/JSObject.h: Copied from ForwardingHeaders/kjs/JSObject.h.
  • ForwardingHeaders/runtime/JSString.h: Copied from ForwardingHeaders/kjs/JSString.h.
  • ForwardingHeaders/runtime/JSValue.h: Copied from ForwardingHeaders/kjs/JSValue.h.
  • WebView/WebScriptDebugDelegate.mm:
  • WebView/WebScriptDebugger.mm:
  • WebView/WebView.mm:

WebKit/win:

  • WebScriptCallFrame.h:

WebKit/wx:

  • WebFrame.cpp:
  • WebView.cpp:
5:57 PM Changeset in webkit [37955] by mitz@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

  • export WTF::atomicallyInitializedStaticMutex
5:37 PM Changeset in webkit [37954] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-10-28 Adele Peterson <adele@apple.com>

Windows build fix. This removes Cairo include directories from non-Cairbo build configurations.

  • WebCore.vcproj/WebCore.vcproj:
5:20 PM Changeset in webkit [37953] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-10-28 Adele Peterson <adele@apple.com>

Build fix.

  • platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::create):
5:12 PM Changeset in webkit [37952] by cwzwarich@webkit.org
  • 2 edits in trunk/WebCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Roll out a mistaken attempt at fixing the GTK build in r37947.

  • GNUmakefile.am:
5:11 PM Changeset in webkit [37951] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2005-10-28 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.


Fixed CodeBlock dumping to accurately report constant register indices.

  • VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
5:04 PM Changeset in webkit [37950] by alp@webkit.org
  • 2 edits in trunk/WebKitTools

2008-10-28 Alp Toker <alp@nuanti.com>

Reviewed by Mark Rowe.

Fix recently introduced double-free crashes in GTK DRT.

LayoutTestController was made ref-counted in r36606 and Mac/Win DRT
were updated to call ->deref() but GTK DRT was still deleting
gLayoutTestController manually. This patch updates GTK to match the
other ports and resolves the memory allocation issues.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest):
4:36 PM Changeset in webkit [37949] by adele@apple.com
  • 15 edits in trunk

WebCore:

2008-10-28 Adele Peterson <adele@apple.com>

Reviewed by John Sullivan.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
"files" string for multifile uploads needs to be localized

  • page/mac/WebCoreViewFactory.h:
  • platform/LocalizedStrings.h:
  • platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth):
  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::multipleFileUploadText):
  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth):
  • platform/mac/LocalizedStringsMac.mm: (WebCore::multipleFileUploadText):
  • platform/qt/Localizations.cpp: (WebCore::multipleFileUploadText):
  • platform/wx/LocalizedStringsWx.cpp: (WebCore::multipleFileUploadText):

WebKit:

2008-10-28 Adele Peterson <adele@apple.com>

Reviewed by John Sullivan.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
"files" string for multifile uploads needs to be localized

  • English.lproj/Localizable.strings: Updated with new string.

WebKit/mac:

2008-10-28 Adele Peterson <adele@apple.com>

Reviewed by John Sullivan.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
"files" string for multifile uploads needs to be localized

  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory multipleFileUploadTextForNumberOfFiles:]): Added.

WebKit/win:

2008-10-28 Adele Peterson <adele@apple.com>

Reviewed by John Sullivan.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
"files" string for multifile uploads needs to be localized

  • WebCoreLocalizedStrings.cpp: (multipleFileUploadText):
4:10 PM Changeset in webkit [37948] by brettw@chromium.org
  • 6 edits
    3 adds in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21816

Remove platform ifdefs in ImageBuffer.h by moving platform specific code
into a new PlatformImageBuffer class. Move the static create function
into the header because it can be cross-platform. Initialization now
happens in the cunstructor which sets a flag that create uses to know
whether it should return null or not. I also made passing of IntSize
more consistent (always by reference).

This change also changes the ifdefs in GraphicsContext to allow Skia
ports to implement text drawing modes.

3:22 PM Changeset in webkit [37947] by cwzwarich@webkit.org
  • 2 edits in trunk/WebCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the GTK build.

  • GNUmakefile.am:
3:14 PM Changeset in webkit [37946] by cwzwarich@webkit.org
  • 2 edits in trunk/WebCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Another Qt build fix.

  • WebCore.pro:
3:04 PM Changeset in webkit [37945] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

More Qt build fixes.

2:59 PM Changeset in webkit [37944] by alp@webkit.org
  • 2 edits in trunk/WebKitTools

2008-10-28 Alp Toker <alp@nuanti.com>

Reviewed by Mark Rowe.

Fix GTK DRT hang when running the tests.

Update output from the DRT tool to print an additional '#EOF' to match
breaking changes that were made in r37434.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dump):
2:52 PM Changeset in webkit [37943] by timothy@apple.com
  • 1 edit in trunk/WebKit/win/WebInspector.cpp

Windows build fix.

2:43 PM Changeset in webkit [37942] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the Qt build, hopefully for real this time.

2:42 PM Changeset in webkit [37941] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

2008-10-28 Greg Bolsinga <bolsinga@apple.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=21932
Add non-pointer constant lookups to SoftLinking.h

  • platform/mac/SoftLinking.h:
2:36 PM Changeset in webkit [37940] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the Qt build.

2:26 PM Changeset in webkit [37939] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the Windows build.

2:06 PM Changeset in webkit [37938] by cwzwarich@webkit.org
  • 17 edits
    99 moves
    1 add in trunk/JavaScriptCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Create a runtime directory in JavaScriptCore and begin moving files to
it. This is the first step towards removing the kjs directory and
placing files in more meaningful subdirectories of JavaScriptCore.

  • API/JSBase.cpp:
  • API/JSCallbackConstructor.cpp:
  • API/JSCallbackConstructor.h:
  • API/JSCallbackFunction.cpp:
  • API/JSClassRef.cpp:
  • API/JSClassRef.h:
  • API/JSStringRefCF.cpp:
  • API/JSValueRef.cpp:
  • API/OpaqueJSString.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/AllInOneFile.cpp:
  • kjs/ArrayConstructor.cpp: Removed.
  • kjs/ArrayConstructor.h: Removed.
  • kjs/ArrayPrototype.cpp: Removed.
  • kjs/ArrayPrototype.h: Removed.
  • kjs/BooleanConstructor.cpp: Removed.
  • kjs/BooleanConstructor.h: Removed.
  • kjs/BooleanObject.cpp: Removed.
  • kjs/BooleanObject.h: Removed.
  • kjs/BooleanPrototype.cpp: Removed.
  • kjs/BooleanPrototype.h: Removed.
  • kjs/CallData.cpp: Removed.
  • kjs/CallData.h: Removed.
  • kjs/ClassInfo.h: Removed.
  • kjs/ConstructData.cpp: Removed.
  • kjs/ConstructData.h: Removed.
  • kjs/DateConstructor.cpp: Removed.
  • kjs/DateConstructor.h: Removed.
  • kjs/DateInstance.cpp: Removed.
  • kjs/DateInstance.h: Removed.
  • kjs/DateMath.cpp: Removed.
  • kjs/DateMath.h: Removed.
  • kjs/DatePrototype.cpp: Removed.
  • kjs/DatePrototype.h: Removed.
  • kjs/Error.cpp: Removed.
  • kjs/Error.h: Removed.
  • kjs/ErrorConstructor.cpp: Removed.
  • kjs/ErrorConstructor.h: Removed.
  • kjs/ErrorInstance.cpp: Removed.
  • kjs/ErrorInstance.h: Removed.
  • kjs/ErrorPrototype.cpp: Removed.
  • kjs/ErrorPrototype.h: Removed.
  • kjs/FunctionConstructor.cpp: Removed.
  • kjs/FunctionConstructor.h: Removed.
  • kjs/FunctionPrototype.cpp: Removed.
  • kjs/FunctionPrototype.h: Removed.
  • kjs/GlobalEvalFunction.cpp: Removed.
  • kjs/GlobalEvalFunction.h: Removed.
  • kjs/InternalFunction.cpp: Removed.
  • kjs/InternalFunction.h: Removed.
  • kjs/JSArray.cpp: Removed.
  • kjs/JSArray.h: Removed.
  • kjs/JSCell.cpp: Removed.
  • kjs/JSCell.h: Removed.
  • kjs/JSFunction.cpp: Removed.
  • kjs/JSFunction.h: Removed.
  • kjs/JSGlobalObject.cpp: Removed.
  • kjs/JSGlobalObject.h: Removed.
  • kjs/JSGlobalObjectFunctions.cpp: Removed.
  • kjs/JSGlobalObjectFunctions.h: Removed.
  • kjs/JSImmediate.cpp: Removed.
  • kjs/JSImmediate.h: Removed.
  • kjs/JSNotAnObject.cpp: Removed.
  • kjs/JSNotAnObject.h: Removed.
  • kjs/JSNumberCell.cpp: Removed.
  • kjs/JSNumberCell.h: Removed.
  • kjs/JSObject.cpp: Removed.
  • kjs/JSObject.h: Removed.
  • kjs/JSString.cpp: Removed.
  • kjs/JSString.h: Removed.
  • kjs/JSValue.cpp: Removed.
  • kjs/JSValue.h: Removed.
  • kjs/JSVariableObject.cpp: Removed.
  • kjs/JSVariableObject.h: Removed.
  • kjs/JSWrapperObject.cpp: Removed.
  • kjs/JSWrapperObject.h: Removed.
  • kjs/MathObject.cpp: Removed.
  • kjs/MathObject.h: Removed.
  • kjs/NativeErrorConstructor.cpp: Removed.
  • kjs/NativeErrorConstructor.h: Removed.
  • kjs/NativeErrorPrototype.cpp: Removed.
  • kjs/NativeErrorPrototype.h: Removed.
  • kjs/NumberConstructor.cpp: Removed.
  • kjs/NumberConstructor.h: Removed.
  • kjs/NumberObject.cpp: Removed.
  • kjs/NumberObject.h: Removed.
  • kjs/NumberPrototype.cpp: Removed.
  • kjs/NumberPrototype.h: Removed.
  • kjs/ObjectConstructor.cpp: Removed.
  • kjs/ObjectConstructor.h: Removed.
  • kjs/ObjectPrototype.cpp: Removed.
  • kjs/ObjectPrototype.h: Removed.
  • kjs/PropertyMap.cpp: Removed.
  • kjs/PropertyMap.h: Removed.
  • kjs/PropertySlot.cpp: Removed.
  • kjs/PropertySlot.h: Removed.
  • kjs/PrototypeFunction.cpp: Removed.
  • kjs/PrototypeFunction.h: Removed.
  • kjs/PutPropertySlot.h: Removed.
  • kjs/SmallStrings.cpp: Removed.
  • kjs/SmallStrings.h: Removed.
  • kjs/StringConstructor.cpp: Removed.
  • kjs/StringConstructor.h: Removed.
  • kjs/StringObject.cpp: Removed.
  • kjs/StringObject.h: Removed.
  • kjs/StringObjectThatMasqueradesAsUndefined.h: Removed.
  • kjs/StringPrototype.cpp: Removed.
  • kjs/StringPrototype.h: Removed.
  • kjs/StructureID.cpp: Removed.
  • kjs/StructureID.h: Removed.
  • kjs/completion.h:
  • kjs/interpreter.h:
  • runtime: Added.
  • runtime/ArrayConstructor.cpp: Copied from kjs/ArrayConstructor.cpp.
  • runtime/ArrayConstructor.h: Copied from kjs/ArrayConstructor.h.
  • runtime/ArrayPrototype.cpp: Copied from kjs/ArrayPrototype.cpp.
  • runtime/ArrayPrototype.h: Copied from kjs/ArrayPrototype.h.
  • runtime/BooleanConstructor.cpp: Copied from kjs/BooleanConstructor.cpp.
  • runtime/BooleanConstructor.h: Copied from kjs/BooleanConstructor.h.
  • runtime/BooleanObject.cpp: Copied from kjs/BooleanObject.cpp.
  • runtime/BooleanObject.h: Copied from kjs/BooleanObject.h.
  • runtime/BooleanPrototype.cpp: Copied from kjs/BooleanPrototype.cpp.
  • runtime/BooleanPrototype.h: Copied from kjs/BooleanPrototype.h.
  • runtime/CallData.cpp: Copied from kjs/CallData.cpp.
  • runtime/CallData.h: Copied from kjs/CallData.h.
  • runtime/ClassInfo.h: Copied from kjs/ClassInfo.h.
  • runtime/ConstructData.cpp: Copied from kjs/ConstructData.cpp.
  • runtime/ConstructData.h: Copied from kjs/ConstructData.h.
  • runtime/DateConstructor.cpp: Copied from kjs/DateConstructor.cpp.
  • runtime/DateConstructor.h: Copied from kjs/DateConstructor.h.
  • runtime/DateInstance.cpp: Copied from kjs/DateInstance.cpp.
  • runtime/DateInstance.h: Copied from kjs/DateInstance.h.
  • runtime/DateMath.cpp: Copied from kjs/DateMath.cpp.
  • runtime/DateMath.h: Copied from kjs/DateMath.h.
  • runtime/DatePrototype.cpp: Copied from kjs/DatePrototype.cpp.
  • runtime/DatePrototype.h: Copied from kjs/DatePrototype.h.
  • runtime/Error.cpp: Copied from kjs/Error.cpp.
  • runtime/Error.h: Copied from kjs/Error.h.
  • runtime/ErrorConstructor.cpp: Copied from kjs/ErrorConstructor.cpp.
  • runtime/ErrorConstructor.h: Copied from kjs/ErrorConstructor.h.
  • runtime/ErrorInstance.cpp: Copied from kjs/ErrorInstance.cpp.
  • runtime/ErrorInstance.h: Copied from kjs/ErrorInstance.h.
  • runtime/ErrorPrototype.cpp: Copied from kjs/ErrorPrototype.cpp.
  • runtime/ErrorPrototype.h: Copied from kjs/ErrorPrototype.h.
  • runtime/FunctionConstructor.cpp: Copied from kjs/FunctionConstructor.cpp.
  • runtime/FunctionConstructor.h: Copied from kjs/FunctionConstructor.h.
  • runtime/FunctionPrototype.cpp: Copied from kjs/FunctionPrototype.cpp.
  • runtime/FunctionPrototype.h: Copied from kjs/FunctionPrototype.h.
  • runtime/GlobalEvalFunction.cpp: Copied from kjs/GlobalEvalFunction.cpp.
  • runtime/GlobalEvalFunction.h: Copied from kjs/GlobalEvalFunction.h.
  • runtime/InternalFunction.cpp: Copied from kjs/InternalFunction.cpp.
  • runtime/InternalFunction.h: Copied from kjs/InternalFunction.h.
  • runtime/JSArray.cpp: Copied from kjs/JSArray.cpp.
  • runtime/JSArray.h: Copied from kjs/JSArray.h.
  • runtime/JSCell.cpp: Copied from kjs/JSCell.cpp.
  • runtime/JSCell.h: Copied from kjs/JSCell.h.
  • runtime/JSFunction.cpp: Copied from kjs/JSFunction.cpp.
  • runtime/JSFunction.h: Copied from kjs/JSFunction.h.
  • runtime/JSGlobalObject.cpp: Copied from kjs/JSGlobalObject.cpp.
  • runtime/JSGlobalObject.h: Copied from kjs/JSGlobalObject.h.
  • runtime/JSGlobalObjectFunctions.cpp: Copied from kjs/JSGlobalObjectFunctions.cpp.
  • runtime/JSGlobalObjectFunctions.h: Copied from kjs/JSGlobalObjectFunctions.h.
  • runtime/JSImmediate.cpp: Copied from kjs/JSImmediate.cpp.
  • runtime/JSImmediate.h: Copied from kjs/JSImmediate.h.
  • runtime/JSNotAnObject.cpp: Copied from kjs/JSNotAnObject.cpp.
  • runtime/JSNotAnObject.h: Copied from kjs/JSNotAnObject.h.
  • runtime/JSNumberCell.cpp: Copied from kjs/JSNumberCell.cpp.
  • runtime/JSNumberCell.h: Copied from kjs/JSNumberCell.h.
  • runtime/JSObject.cpp: Copied from kjs/JSObject.cpp.
  • runtime/JSObject.h: Copied from kjs/JSObject.h.
  • runtime/JSString.cpp: Copied from kjs/JSString.cpp.
  • runtime/JSString.h: Copied from kjs/JSString.h.
  • runtime/JSValue.cpp: Copied from kjs/JSValue.cpp.
  • runtime/JSValue.h: Copied from kjs/JSValue.h.
  • runtime/JSVariableObject.cpp: Copied from kjs/JSVariableObject.cpp.
  • runtime/JSVariableObject.h: Copied from kjs/JSVariableObject.h.
  • runtime/JSWrapperObject.cpp: Copied from kjs/JSWrapperObject.cpp.
  • runtime/JSWrapperObject.h: Copied from kjs/JSWrapperObject.h.
  • runtime/MathObject.cpp: Copied from kjs/MathObject.cpp.
  • runtime/MathObject.h: Copied from kjs/MathObject.h.
  • runtime/NativeErrorConstructor.cpp: Copied from kjs/NativeErrorConstructor.cpp.
  • runtime/NativeErrorConstructor.h: Copied from kjs/NativeErrorConstructor.h.
  • runtime/NativeErrorPrototype.cpp: Copied from kjs/NativeErrorPrototype.cpp.
  • runtime/NativeErrorPrototype.h: Copied from kjs/NativeErrorPrototype.h.
  • runtime/NumberConstructor.cpp: Copied from kjs/NumberConstructor.cpp.
  • runtime/NumberConstructor.h: Copied from kjs/NumberConstructor.h.
  • runtime/NumberObject.cpp: Copied from kjs/NumberObject.cpp.
  • runtime/NumberObject.h: Copied from kjs/NumberObject.h.
  • runtime/NumberPrototype.cpp: Copied from kjs/NumberPrototype.cpp.
  • runtime/NumberPrototype.h: Copied from kjs/NumberPrototype.h.
  • runtime/ObjectConstructor.cpp: Copied from kjs/ObjectConstructor.cpp.
  • runtime/ObjectConstructor.h: Copied from kjs/ObjectConstructor.h.
  • runtime/ObjectPrototype.cpp: Copied from kjs/ObjectPrototype.cpp.
  • runtime/ObjectPrototype.h: Copied from kjs/ObjectPrototype.h.
  • runtime/PropertyMap.cpp: Copied from kjs/PropertyMap.cpp.
  • runtime/PropertyMap.h: Copied from kjs/PropertyMap.h.
  • runtime/PropertySlot.cpp: Copied from kjs/PropertySlot.cpp.
  • runtime/PropertySlot.h: Copied from kjs/PropertySlot.h.
  • runtime/PrototypeFunction.cpp: Copied from kjs/PrototypeFunction.cpp.
  • runtime/PrototypeFunction.h: Copied from kjs/PrototypeFunction.h.
  • runtime/PutPropertySlot.h: Copied from kjs/PutPropertySlot.h.
  • runtime/SmallStrings.cpp: Copied from kjs/SmallStrings.cpp.
  • runtime/SmallStrings.h: Copied from kjs/SmallStrings.h.
  • runtime/StringConstructor.cpp: Copied from kjs/StringConstructor.cpp.
  • runtime/StringConstructor.h: Copied from kjs/StringConstructor.h.
  • runtime/StringObject.cpp: Copied from kjs/StringObject.cpp.
  • runtime/StringObject.h: Copied from kjs/StringObject.h.
  • runtime/StringObjectThatMasqueradesAsUndefined.h: Copied from kjs/StringObjectThatMasqueradesAsUndefined.h.
  • runtime/StringPrototype.cpp: Copied from kjs/StringPrototype.cpp.
  • runtime/StringPrototype.h: Copied from kjs/StringPrototype.h.
  • runtime/StructureID.cpp: Copied from kjs/StructureID.cpp.
  • runtime/StructureID.h: Copied from kjs/StructureID.h.
2:01 PM Changeset in webkit [37937] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

2008-10-28 Greg Bolsinga <bolsinga@apple.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=2192
Missing semi-colons in Geoposition.idl

  • page/Geoposition.idl: Add missing semi-colons
1:55 PM Changeset in webkit [37936] by adele@apple.com
  • 7 edits
    1 delete in trunk

WebKit:

2008-10-28 Adele Peterson <adele@apple.com>

Reviewed by Sam Weinig.

  • English.lproj/Localizable.strings: Updated.

WebKit/win:

2008-10-28 Adele Peterson <adele@apple.com>

Reviewed by Sam Weinig.

  • English.lproj: Removed.
  • English.lproj/Localizable.strings: Removed.
  • WebKit.vcproj/WebKit.vcproj: Updated to use Localizable.strings in the top directory, to share with the Mac.

WebKitTools:

2008-10-28 Adele Peterson <adele@apple.com>

Reviewed by Sam Weinig.

Specify which Localizable.strings to update since we don't always want to update the file in the same
directory where we're searching for the strings to localize.


  • Scripts/extract-localizable-strings:
  • Scripts/update-webkit-localizable-strings:
1:48 PM Changeset in webkit [37935] by timothy@apple.com
  • 3 edits in trunk/WebCore/inspector/front-end/Images

Set svn:mime-type to image/png for the new images I just added.

1:42 PM Changeset in webkit [37934] by timothy@apple.com
  • 2 edits in trunk/LayoutTests

Remove fast/profiler from the skipped list for Tiger since the fix
for <rdar://problem/6211578> should make things work.

<rdar://problem/6316530> Profiler tests fail on Tiger

Reviewed by Kevin McCullough.

  • platform/mac-tiger/Skipped:
1:42 PM Changeset in webkit [37933] by timothy@apple.com
  • 114 edits
    4 adds
    1 delete in trunk

Make the JavaScript profiler opt-in, so it does not slow down JavaScript all the time.
Make the Profiles panel in the Web Inspector have an enable screen.
Profiling now needs to be enabled before console.profile() works.

WebCore:

2008-10-27 Timothy Hatcher <timothy@apple.com>

Make the Profiles panel in the Web Inspector have an enable screen.
Profiling now needs to be enabled before console.profile() works.

<rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
not slow down JavaScript all the time

Reviewed by Darin Adler and Kevin McCullough.

  • English.lproj/localizedStrings.js: New strings.
  • WebCore.base.exp: New and changed exports.
  • WebCore.vcproj/WebCore.vcproj: Add the PanelEnablerView.js file.
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::supportsProfiling): Call InspectorController:profilerEnabled.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): Initialize the m_startProfiling Timer to call InspectorController::startUserInitiatedProfiling. (WebCore::InspectorController::startUserInitiatedProfilingSoon): Start a one-shot timer that calls InspectorController::startUserInitiatedProfiling. (WebCore::InspectorController::startUserInitiatedProfiling): Recompile all JavaScript and enable the profiler if the profiler was not enabled. (WebCore::InspectorController::stopUserInitiatedProfiling): Rearrange code for readability. (WebCore::InspectorController::enableProfiler): Recompile all the JavaScript functions if the skipRecompile argument is false. Call the profilerWasEnabled script function. (WebCore::InspectorController::disableProfiler): Recompile all the JavaScript functions. Call the profilerWasEnabled script function. (WebCore::InspectorController::disableDebugger): Set m_attachDebuggerWhenShown to false, so it won't be started later.
  • inspector/InspectorController.h: (WebCore::InspectorController::profilerEnabled): Return enabled() && m_profilerEnabled.
  • inspector/front-end/Images/debuggingButtons.png: Remove.
  • inspector/front-end/Images/enableButtons.png: Added.
  • inspector/front-end/Images/profilesSilhouette.png: Added.
  • inspector/front-end/Images/scriptsSilhouette.png: Added.
  • inspector/front-end/PanelEnablerView.js: Added. (WebInspector.PanelEnablerView): (WebInspector.PanelEnablerView.prototype._enableButtonCicked): Fire the "enable clicked" event so listeners can do their thing. (WebInspector.PanelEnablerView.prototype._windowResized): Test if the icon should be hidden.
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): Create the PanelEnablerView and the strings needed for it. (WebInspector.ProfilesPanel.prototype.get statusBarItems): Include the enableToggleButton. (WebInspector.ProfilesPanel.prototype.profilerWasEnabled): Call reset and populateInterface. (WebInspector.ProfilesPanel.prototype.profilerWasDisabled): Call reset. (WebInspector.ProfilesPanel.prototype.reset): Call _updateInterface. (WebInspector.ProfilesPanel.prototype.setRecordingProfile): Moved in the code, no changes. (WebInspector.ProfilesPanel.prototype._updateInterface): Update the toggle button and show/hide other buttons. Also show/hide the PanelEnablerView. (WebInspector.ProfilesPanel.prototype._enableProfiling): Call _toggleProfiling if not enabled. (WebInspector.ProfilesPanel.prototype._toggleProfiling): Call InspectorController's disableProfiler or enableProfiler.
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): Replace the overlay element with a PanelEnablerView. Replace the debuggingButton with the enableToggleButton. (WebInspector.ScriptsPanel.prototype.get statusBarItems): Replace the debuggingButton with the enableToggleButton. (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): Hide/show the pauseOnExceptionButton when needed. Replace the overlay element with a PanelEnablerView. Replace the debuggingButton with the enableToggleButton. (WebInspector.ScriptsPanel.prototype._enableDebugging): Call _toggleDebugging when not enabled. (WebInspector.ScriptsPanel.prototype._toggleDebugging): Remove the call to _clearInterface, since reset is called from debuggerWasEnabled and debuggerWasDisabled.
  • inspector/front-end/View.js: Inherit from WebInspector.Object.
  • inspector/front-end/WebKit.qrc: Add the PanelEnablerView.js file.
  • inspector/front-end/inspector.css: New styles for the PanelEnablerView.
  • inspector/front-end/inspector.html: Add the PanelEnablerView.js file.
  • inspector/front-end/inspector.js: (WebInspector.profilerWasEnabled): Added. Calls the ProfilesPanel. (WebInspector.profilerWasDisabled): Ditto.
  • page/Console.cpp: (WebCore::Console::error): Remove null check for m_frame, since m_frame isn't used. (WebCore::Console::info): Ditto. (WebCore::Console::log): Ditto. (WebCore::Console::assertCondition): Ditto. (WebCore::Console::dirxml): Remove null check for m_frame and use this->page(). (WebCore::Console::count): Ditto. (WebCore::Console::profile): Return early if InspectorController::profilerEnabled is false. (WebCore::Console::profileEnd): Ditto. (WebCore::Console::warn): Remove null check for m_frame, since m_frame isn't used.
  • page/Settings.cpp: (WebCore::Settings::Settings): Remove initialization of m_didInitializeDeveloperExtrasEnabled. (WebCore::Settings::setDeveloperExtrasEnabled): Remove code that recompiled functions. Now just sets the member boolean.
  • page/Settings.h: Remove m_didInitializeDeveloperExtrasEnabled.

WebKit/mac:

2008-10-28 Timothy Hatcher <timothy@apple.com>

Add WebInspector methods to enable the profiler.

https://bugs.webkit.org/show_bug.cgi?id=21927

<rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
not slow down JavaScript all the time

Reviewed by Darin Adler and Kevin McCullough.

WebKit/win:

2008-10-28 Timothy Hatcher <timothy@apple.com>

Add IWebInspector methods to enable the profiler.

https://bugs.webkit.org/show_bug.cgi?id=21927

<rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
not slow down JavaScript all the time

Reviewed by Darin Adler and Kevin McCullough.

  • WebInspector.cpp: (WebInspector::isJavaScriptProfilingEnabled): Added. Calls InspectorController::profilerEnabled. (WebInspector::setJavaScriptProfilingEnabled): Added. Call InspectorController's disableProfiler or enableProfiler methods.
  • WebInspector.h:

WebKitTools:

2008-10-28 Timothy Hatcher <timothy@apple.com>

Add support for enabling the profiler, so the profiling tests can continue
work now that the profiler is not always enabled.

https://bugs.webkit.org/show_bug.cgi?id=21927

<rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
not slow down JavaScript all the time

Reviewed by Darin Adler and Kevin McCullough.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Make the editor use spaces.
  • DumpRenderTree/LayoutTestController.cpp: (setJavaScriptProfilingEnabledCallback): Added. Calls LayoutTestController::setJavaScriptProfilingEnabled. (LayoutTestController::staticFunctions): Added setJavaScriptProfilingEnabled to the script class.
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setJavaScriptProfilingEnabled): Stubbed out with a FIXME.
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.

LayoutTests:

2008-10-28 Timothy Hatcher <timothy@apple.com>

Update profiler tests to opt-in to profiling and clean up the output.

https://bugs.webkit.org/show_bug.cgi?id=21927

<rdar://problem/6211578> Make the JavaScript profiler opt-in, so it
does not slow down JavaScript all the time

Reviewed by Darin Adler and Kevin McCullough.

  • fast/profiler/anonymous-event-handler-expected.txt:
  • fast/profiler/anonymous-event-handler.html:
  • fast/profiler/anonymous-function-called-from-different-contexts-expected.txt:
  • fast/profiler/anonymous-function-called-from-different-contexts.html:
  • fast/profiler/anonymous-function-calls-built-in-functions-expected.txt:
  • fast/profiler/anonymous-function-calls-built-in-functions.html:
  • fast/profiler/anonymous-function-calls-eval-expected.txt:
  • fast/profiler/anonymous-function-calls-eval.html:
  • fast/profiler/apply-expected.txt:
  • fast/profiler/apply.html:
  • fast/profiler/built-in-function-calls-anonymous-expected.txt:
  • fast/profiler/built-in-function-calls-anonymous.html:
  • fast/profiler/built-in-function-calls-user-defined-function-expected.txt:
  • fast/profiler/built-in-function-calls-user-defined-function.html:
  • fast/profiler/call-expected.txt:
  • fast/profiler/call-nodelist-as-function-expected.txt:
  • fast/profiler/call-nodelist-as-function.html:
  • fast/profiler/call.html:
  • fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope-expected.txt:
  • fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html:
  • fast/profiler/compare-multiple-profiles-expected.txt:
  • fast/profiler/compare-multiple-profiles.html:
  • fast/profiler/constructor-expected.txt:
  • fast/profiler/constructor.html:
  • fast/profiler/dead-time-expected.txt:
  • fast/profiler/dead-time.html:
  • fast/profiler/document-dot-write-expected.txt:
  • fast/profiler/document-dot-write.html:
  • fast/profiler/event-handler-expected.txt:
  • fast/profiler/event-handler.html:
  • fast/profiler/execution-context-and-eval-on-same-line-expected.txt:
  • fast/profiler/execution-context-and-eval-on-same-line.html:
  • fast/profiler/heavy-view-expected.txt:
  • fast/profiler/heavy-view.html:
  • fast/profiler/inline-event-handler-expected.txt:
  • fast/profiler/inline-event-handler.html:
  • fast/profiler/many-calls-in-the-same-scope-expected.txt:
  • fast/profiler/many-calls-in-the-same-scope.html:
  • fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt:
  • fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html:
  • fast/profiler/multiple-and-different-scoped-function-calls-expected.txt:
  • fast/profiler/multiple-and-different-scoped-function-calls.html:
  • fast/profiler/multiple-frames-expected.txt:
  • fast/profiler/multiple-frames.html:
  • fast/profiler/nested-anonymous-functon-expected.txt:
  • fast/profiler/nested-anonymous-functon.html:
  • fast/profiler/nested-start-and-stop-profiler-expected.txt:
  • fast/profiler/nested-start-and-stop-profiler.html:
  • fast/profiler/no-execution-context-expected.txt:
  • fast/profiler/no-execution-context.html:
  • fast/profiler/one-execution-context-expected.txt:
  • fast/profiler/one-execution-context.html:
  • fast/profiler/profile-calls-in-included-file-expected.txt:
  • fast/profiler/profile-calls-in-included-file.html:
  • fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt:
  • fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html:
  • fast/profiler/profiling-from-a-nested-location-expected.txt:
  • fast/profiler/profiling-from-a-nested-location.html:
  • fast/profiler/resources/profiler-test-JS-resources.js: (endTest): Remove some whitespace. (insertGivenText): Hide the output of this method, sicne it is not important to the test. (insertNewText): Ditto. (printHeavyProfilesDataWithoutTime): Output plain text an not console.log. (printProfilesDataWithoutTime): Ditto. (printProfileNodeWithoutTime): Ditto.
  • fast/profiler/simple-event-call-expected.txt:
  • fast/profiler/simple-event-call.html:
  • fast/profiler/simple-no-level-change-expected.txt:
  • fast/profiler/simple-no-level-change.html:
  • fast/profiler/start-and-stop-profiler-multiple-times-expected.txt:
  • fast/profiler/start-and-stop-profiler-multiple-times.html:
  • fast/profiler/start-and-stop-profiling-in-the-same-function-expected.txt:
  • fast/profiler/start-and-stop-profiling-in-the-same-function.html:
  • fast/profiler/start-but-dont-stop-profiling-expected.txt:
  • fast/profiler/start-but-dont-stop-profiling.html:
  • fast/profiler/stop-profiling-after-setTimeout-expected.txt:
  • fast/profiler/stop-profiling-after-setTimeout.html:
  • fast/profiler/stop-then-function-call-expected.txt:
  • fast/profiler/stop-then-function-call.html:
  • fast/profiler/throw-exception-from-eval-expected.txt:
  • fast/profiler/throw-exception-from-eval.html:
  • fast/profiler/two-execution-contexts-expected.txt:
  • fast/profiler/two-execution-contexts.html:
  • fast/profiler/user-defined-function-calls-built-in-functions-expected.txt:
  • fast/profiler/user-defined-function-calls-built-in-functions.html:
  • fast/profiler/window-dot-eval-expected.txt:
  • fast/profiler/window-dot-eval.html:
1:42 PM Changeset in webkit [37932] by timothy@apple.com
  • 11 edits in trunk

Rename a few methods related to attaching and detaching the debugger. Also adds stub methods for enabling and disabling the profiler.

WebCore:

2008-10-27 Timothy Hatcher <timothy@apple.com>

Rename a few methods related to attaching and detaching the debugger. Also
adds stub methods for enabling and disabling the profiler.

  • Rename attachDebugger to enableDebugger.
  • Rename detachDebugger to disableDebugger.
  • Rename the debuggerAttached getter to debuggerEnabled.
  • Rename the debuggerAttached callback to debuggerWasEnabled.
  • Rename the debuggerDetached callback to debuggerWasDisabled.

Reviewed by Darin Adler.

  • WebCore.base.exp:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::close): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::pauseInDebugger): (WebCore::InspectorController::resumeDebugger): (WebCore::InspectorController::stepOverStatementInDebugger): (WebCore::InspectorController::stepIntoStatementInDebugger): (WebCore::InspectorController::stepOutOfFunctionInDebugger):
  • inspector/InspectorController.h: (WebCore::InspectorController::profilerEnabled): (WebCore::InspectorController::debuggerEnabled):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
  • inspector/front-end/Object.js:
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get statusBarItems): (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype.debuggerWasDetached): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype.canShowResource): (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton): (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): (WebInspector.ScriptsPanel.prototype._toggleDebugging):
  • inspector/front-end/View.js:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.addResource): (WebInspector.debuggerWasEnabled): (WebInspector.debuggerWasDisabled):

WebKit/mac:

2008-10-27 Timothy Hatcher <timothy@apple.com>

Rename a few methods related to attaching and detaching the debugger.

  • Rename attachDebugger to enableDebugger.
  • Rename detachDebugger to disableDebugger.
  • Rename the debuggerAttached getter to debuggerEnabled.

Reviewed by Darin Adler.

WebKit/win:

2008-10-27 Timothy Hatcher <timothy@apple.com>

Rename a few methods related to attaching and detaching the debugger.

  • Rename attachDebugger to enableDebugger.
  • Rename detachDebugger to disableDebugger.
  • Rename the debuggerAttached getter to debuggerEnabled.

Reviewed by Darin Adler.

  • WebInspector.cpp: (WebInspector::isDebuggingJavaScript): (WebInspector::toggleDebuggingJavaScript):
1:41 PM Changeset in webkit [37931] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fix an exception when searching the Resources panel while there
and resources queued to be added to the list.

Reviewed by Kevin McCullough.

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.searchCanceled): Null check the _resourcesTreeElement property. (WebInspector.ResourcesPanel.prototype.performSearch): Ditto.
12:14 PM Changeset in webkit [37930] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-10-28 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed https://bugs.webkit.org/show_bug.cgi?id=21919
Sampler reports bogus time in op_enter during 3d-raytrace.js


Fixed a bug where we would pass the incorrect Instruction* during some
parts of CTI codegen.

  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
  • VM/SamplingTool.cpp: (JSC::SamplingTool::run):
  • wtf/Platform.h:
10:48 AM Changeset in webkit [37929] by kmccullough@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-10-28 Kevin McCullough <kmccullough@apple.com>

Reviewed by Dan Bernstein.

-Removed unused includes.
Apparent .4% speedup in Sunspider

  • kjs/JSObject.cpp:
  • kjs/interpreter.cpp:
10:26 AM Changeset in webkit [37928] by Simon Fraser
  • 13 edits
    2 adds in trunk/WebKitTools

2008-10-28 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Dan Bernstein

Primary changes in DumpRenderTree:

  • Ensure font smoothing is disabled (this is also called LCD anti-aliasing and is different from regular font CG anti-aliasing) as font-smoothing settings depends on the display and can also be changed by the user
  • Use a new cleared buffer for each test instead of the reusing same one to avoid potential result corruption across tests
  • Can now receive the expected pixel hash as a suffix to the test path or url as "path'hash"
  • Make sure hash is computed in a endian-independent way
  • Improve the code that sets/restores the screen color profile
  • Make the code more cross-platformy with std::string goodness
  • Added an "on-screen" mode where the snapshot will take into account surfaces on the window (like OpenGL content): this uses the new CG APIs on 10.5 or reading from the display framebuffer on 10.4. This mode is not active by default for performance reason, but must be explicitly activated from the test file using the new "testOnscreen()" JS API.

Primary changes in ImageDiff:

  • Provide a new comparison algorithm that is more tolerant to "acceptable" failures (i.e. very small differences in font rendering, which --threshold is not really good at handling)
  • Generate normalized intensity-only diff images

Primary changes in run-webkit-tests:

  • Take advantage of hashes for pixel tests which makes them much faster by minimizing image comparisons
  • Removed repaint options as these should be set from within test files using JS API
  • Replaced "threshold" option in by "tolerance" expressed in percents
  • Added more logging when in "verbose" mode
10:17 AM Changeset in webkit [37927] by mitz@apple.com
  • 1 edit
    12 moves
    3 deletes in trunk/LayoutTests

2008-10-28 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=21821

Ensure all baseline images are in the right location and delete the ones that aren't needed.

  • editing/inserting/5607069-1-expected.checksum: Removed.
  • editing/inserting/5607069-1-expected.png: Removed.
  • editing/pasteboard/paste-text-013-expected.png: Removed.
  • fast/css/invalid-percentage-property-expected.checksum: Removed.
  • fast/css/invalid-percentage-property-expected.png: Removed.
  • fast/css/text-align-expected.checksum: Removed.
  • fast/css/text-align-expected.png: Removed.
  • fast/selectors/lang-inheritance-expected.checksum: Removed.
  • fast/selectors/lang-inheritance-expected.png: Removed.
  • fast/selectors/lang-inheritance2-expected.checksum: Removed.
  • fast/selectors/lang-inheritance2-expected.png: Removed.
  • fast/selectors/lang-vs-xml-lang-expected.checksum: Removed.
  • fast/selectors/lang-vs-xml-lang-expected.png: Removed.
  • fast/selectors/lang-vs-xml-lang-xhtml-expected.checksum: Removed.
  • fast/selectors/lang-vs-xml-lang-xhtml-expected.png: Removed.
  • platform/mac/fast/css/invalid-percentage-property-expected.checksum: Copied from LayoutTests/fast/css/invalid-percentage-property-expected.checksum.
  • platform/mac/fast/css/invalid-percentage-property-expected.png: Copied from LayoutTests/fast/css/invalid-percentage-property-expected.png.
  • platform/mac/fast/css/text-align-expected.checksum: Copied from LayoutTests/fast/css/text-align-expected.checksum.
  • platform/mac/fast/css/text-align-expected.png: Copied from LayoutTests/fast/css/text-align-expected.png.
  • platform/mac/fast/selectors/lang-inheritance-expected.checksum: Copied from LayoutTests/fast/selectors/lang-inheritance-expected.checksum.
  • platform/mac/fast/selectors/lang-inheritance-expected.png: Copied from LayoutTests/fast/selectors/lang-inheritance-expected.png.
  • platform/mac/fast/selectors/lang-inheritance2-expected.checksum: Copied from LayoutTests/fast/selectors/lang-inheritance2-expected.checksum.
  • platform/mac/fast/selectors/lang-inheritance2-expected.png: Copied from LayoutTests/fast/selectors/lang-inheritance2-expected.png.
  • platform/mac/fast/selectors/lang-vs-xml-lang-expected.checksum: Copied from LayoutTests/fast/selectors/lang-vs-xml-lang-expected.checksum.
  • platform/mac/fast/selectors/lang-vs-xml-lang-expected.png: Copied from LayoutTests/fast/selectors/lang-vs-xml-lang-expected.png.
  • platform/mac/fast/selectors/lang-vs-xml-lang-xhtml-expected.checksum: Copied from LayoutTests/fast/selectors/lang-vs-xml-lang-xhtml-expected.checksum.
  • platform/mac/fast/selectors/lang-vs-xml-lang-xhtml-expected.png: Copied from LayoutTests/fast/selectors/lang-vs-xml-lang-xhtml-expected.png.
9:18 AM Changeset in webkit [37926] by alp@webkit.org
  • 3 edits in trunk/WebCore

2008-10-28 Alp Toker <alp@nuanti.com>

GTK+ build fix for older versions of Pango where PANGO_VERSION_CHECK
isn't defined.

  • platform/graphics/gtk/FontGtk.cpp: (WebCore::getDefaultPangoLayout):
  • platform/graphics/gtk/FontPlatformDataPango.cpp:
7:30 AM Changeset in webkit [37925] by alp@webkit.org
  • 2 edits in trunk

2008-10-28 Mike Hommey <glandium@debian.org>

Reviewed by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=21885
[GTK] libwebkit doesn't link against libpangoft2

Add pkg-config check for pangoft2 which provides
pango_fc_font_description_from_pattern() used in the FreeType font
backend.

  • configure.ac:
6:42 AM Changeset in webkit [37924] by ap@webkit.org
  • 8 edits
    3 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21893
Character set is incorrect for external scripts in XHTML pages

<rdar://problem/6317451> Incorrect encoding for text in a popup at http://xpoint.ru/

Test: fast/encoding/external-script-charset.xhtml

Expose scriptCharset() function on all ScriptElements, and call it from XML tokenizer.

  • dom/ScriptElement.h:
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::endElementNs):
  • dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::parseEndElement):
  • html/HTMLScriptElement.h:
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::scriptCharset):
  • svg/SVGScriptElement.h:
5:53 AM Changeset in webkit [37923] by alp@webkit.org
  • 6 edits in trunk

2008-10-28 Alp Toker <alp@nuanti.com>

Include copyright license files in the autotools dist target and
exclude unused zlib headers.

Change suggested by Mike Hommey.

Oct 27, 2008:

10:24 PM Changeset in webkit [37922] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-10-27 Sam Weinig <sam@webkit.org>

Reviewed by Maciej Stachowiak.

Clear the window shell when destroying a page to allow documents
which have no way of being reached anymore, to be torn down.

  • page/Frame.cpp: (WebCore::Frame::pageDestroyed):
8:06 PM Changeset in webkit [37921] by mrowe@apple.com
  • 4 edits in branches/Safari-3-2-branch

Versioning.

8:05 PM Changeset in webkit [37920] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.26.6

New tag.

7:40 PM Changeset in webkit [37919] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-10-27 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Stop discarding CodeBlock samples that can't be charged to a specific
opcode. Instead, charge the relevant CodeBlock, and provide a footnote
explaining the situation.


This will help us tell which CodeBlocks are hot, even if we can't
identify specific lines of code within the CodeBlocks.

  • VM/SamplingTool.cpp: (JSC::ScopeSampleRecord::sample): (JSC::compareScopeSampleRecords): (JSC::SamplingTool::dump):
  • VM/SamplingTool.h: (JSC::ScopeSampleRecord::ScopeSampleRecord): (JSC::ScopeSampleRecord::~ScopeSampleRecord):
7:21 PM Changeset in webkit [37918] by Antti Koivisto
  • 1 edit
    1 add in trunk/WebKitSite

2008-10-27 Antti Koivisto <Antti Koivisto>

Add a file.

  • blog-files/squirrelfish-link-animated.svg: Added.
6:40 PM Changeset in webkit [37917] by andersca@apple.com
  • 1 edit in trunk/WebKit/mac/Plugins/WebBaseNetscapePluginStream.h

Whoops, did not mean to commit this.

6:39 PM Changeset in webkit [37916] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Maciej Stachowiak.

Use the C++ stream object for JS requests as well.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebBaseNetscapePluginView destroyStream:reason:]):
6:31 PM Changeset in webkit [37915] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.


Use the C++ stream object in WebBaseNetscapePluginView. Use a HashSet of RefPtrs to keep track of the streams.


  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::~WebNetscapePluginStream): (WebNetscapePluginStream::setPlugin): (WebNetscapePluginStream::startStream): (WebNetscapePluginStream::destroyStream): (WebNetscapePluginStream::destroyStreamWithReason): (WebNetscapePluginStream::cancelLoadAndDestroyStreamWithError): (WebNetscapePluginStream::deliverData):
  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView stop]): (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): (-[WebBaseNetscapePluginView disconnectStream:]): (-[WebBaseNetscapePluginView dealloc]): (-[WebBaseNetscapePluginView pluginView:receivedResponse:]): (-[WebBaseNetscapePluginView pluginView:receivedData:]): (-[WebBaseNetscapePluginView pluginView:receivedError:]): (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
6:07 PM Changeset in webkit [37914] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Mitz Pettel.


Move code from dealloc and finalize to the WebNetscapePluginStream destructor.


  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::~WebNetscapePluginStream): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]):
6:01 PM Changeset in webkit [37913] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Get rid of WebNetscapePlugInStreamLoaderClient, the plug-in stream is its own client.


  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginView:receivedError:]): (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]): (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebBaseNetscapePluginView destroyStream:reason:]):
5:43 PM Changeset in webkit [37912] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Change the Obj-C init methods to simply call WebNetscapePluginStream::create.


  • Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::create):
  • Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream initWithFrameLoader:]): (WebNetscapePluginStream::WebNetscapePluginStream): (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
5:18 PM Changeset in webkit [37911] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Convert more code over to C++.


  • Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::plugin): (WebNetscapePluginStream::setRequestURL): Convert to C++.
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::start): (WebNetscapePluginStream::stop): Ditto.


(WebNetscapePluginStream::startStreamWithResponse):
Ditto.


(-[WebBaseNetscapePluginStream startStreamWithResponse:]):
Call the C++ version.


(-[WebBaseNetscapePluginStream impl]):
New accessor for the C++ class.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginView:receivedData:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): (-[WebBaseNetscapePluginView destroyStream:reason:]): Call the C++ methods.
4:48 PM Changeset in webkit [37910] by mrowe@apple.com
  • 2 edits in branches/Safari-3-2-branch/WebCore

Merge r37628.

4:47 PM Changeset in webkit [37909] by mrowe@apple.com
  • 2 edits in branches/Safari-3-2-branch/WebCore

Merge r37897.

4:25 PM Changeset in webkit [37908] by Antti Koivisto
  • 1 edit
    2 adds in trunk/WebKitSite

2008-10-27 Antti Koivisto <Antti Koivisto>

Add some svg files.

  • blog-files/cubes-7.svg: Added.
  • blog-files/number-morph.svg: Added.
3:57 PM Changeset in webkit [37907] by Darin Adler
  • 2 edits in trunk/WebKit

2008-10-27 Darin Adler <Darin Adler>

  • StringsNotToBeLocalized.txt: Updated for recent changes.
3:15 PM Changeset in webkit [37906] by kevino@webkit.org
  • 2 edits in trunk

Reviewed by Kevin Ollivier.

Update the active state as well as the focused state as both need to be true
for the caret to be drawn.

https://bugs.webkit.org/show_bug.cgi?id=21900

3:10 PM Changeset in webkit [37905] by Darin Adler
  • 2 edits in trunk/BugsSite

2008-10-27 Darin Adler <Darin Adler>

  • template/en/custom/attachment/reviewform.html.tmpl: Leave out the comment if it's untouched.
3:07 PM Changeset in webkit [37904] by kevino@webkit.org
  • 6 edits in trunk

wx build fix on Linux/GTK. Enable support for #include <JavaScriptCore/XYZ.h> style includes.

2:45 PM Changeset in webkit [37903] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-10-27 Michael Tross <michael@tross.org>

Reviewed by Alp Toker. Landed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=21827
[GTK] Fix memory leak in webkit_web_view_load_string

  • webkit/webkitwebview.cpp:
2:20 PM Changeset in webkit [37902] by Darin Adler
  • 13 edits in trunk/WebCore

2008-10-27 Michael Knaup <michael.knaup@mac.com>

Reviewed and tweaked by Darin Adler.

Bug 8988: Add support for Mozilla CSS custom cursors.
Added -webkit-grab and -webkit-grabbing cursor suppport
for the Mac, dummy implementations for other platforms.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Updated since the -webkit-grabbing cursor is now the last one.
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING.
  • css/CSSValueKeywords.in: Added -webkit-grab and -webkit-grabbing.
  • manual-tests/cursor.html: Added -webkit-zoom-in, webkit-zoom-out, -webkit-grab, and -webkit-grabbing.
  • page/EventHandler.cpp: (WebCore::EventHandler::selectCursor): Added CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING.
  • platform/Cursor.h: Added grabCursor and grabbingCursor.
  • platform/gtk/CursorGtk.cpp: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.
  • platform/mac/CursorMac.mm: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.
  • platform/qt/CursorQt.cpp: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.
  • platform/win/CursorWin.cpp: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.
  • platform/wx/CursorWx.cpp: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.
  • rendering/style/RenderStyleConstants.h: Added CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING. Also broke ECursor out into a single constant per line. Also added a couple of comments.
1:37 PM Changeset in webkit [37901] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-10-27 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Added a mutex around the SamplingTool's ScopeNode* map, to solve a crash
when sampling the v8 tests.

  • VM/SamplingTool.cpp: (JSC::SamplingTool::run): (JSC::SamplingTool::notifyOfScope):
  • VM/SamplingTool.h: Since new ScopeNodes can be created after the SamplingTools has begun sampling, reads and writes to / from the map need to be synchronized. Shark says this doesn't measurably increase sampling overhead.
1:07 PM Changeset in webkit [37900] by eric@webkit.org
  • 2 edits in trunk/WebCore

2008-10-27 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

  • svg/SVGAnimatedTemplate.h: needed a HashMap define
12:49 PM Changeset in webkit [37899] by eric@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Dave Hyatt.

Infinite recursion crash in WebCore::RenderSVGRoot::absoluteClippedOverflowRect on a <stop> element outside of a gradient block
https://bugs.webkit.org/show_bug.cgi?id=20400

Test: svg/custom/stop-crash.svg

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderSVGGradientStop.h: (WebCore::RenderSVGGradientStop::absoluteClippedOverflowRect):
11:55 AM Changeset in webkit [37898] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

No need to call release if the connection is null.


  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start):
11:52 AM Changeset in webkit [37897] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

<rdar://problem/6322650> Crash in fast/loader/simultaneous-reloads-assert.html


Make sure to null check the NSURLConnection object.


  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::setDefersLoading):
1:53 AM Changeset in webkit [37896] by ap@webkit.org
  • 5 edits in trunk/WebCore

Fix non-Mac builds.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCoreSources.bkl: Renamed JSHTMLOptionElementConstructor to JSOptionConstructor.
12:59 AM Changeset in webkit [37895] by ap@webkit.org
  • 10 edits
    2 moves
    2 adds in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21886
window.HTMLOptionElement == "[object HTMLElementConstructor]" instead of HTMLOptionElementConstructor

Test: fast/dom/HTMLOptionElement/option-prototype.html

We now have separate objects for window.Option and window.HTMLOptionElement - the latter
"constructor" cannot be used to construct anything. This matches Firefox behavior.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowBase.cpp: (jsDOMWindowBaseOption):
  • bindings/js/JSHTMLOptionElementConstructor.cpp: Removed.
  • bindings/js/JSHTMLOptionElementConstructor.h: Removed.
  • bindings/js/JSOptionConstructor.cpp: Copied from WebCore/bindings/js/JSHTMLOptionElementConstructor.cpp.
  • bindings/js/JSOptionConstructor.h: Copied from WebCore/bindings/js/JSHTMLOptionElementConstructor.h.
  • html/HTMLOptionElement.idl: Renamed JSHTMLOptionElementConstructor to JSOptionConstructor.
  • html/HTMLOptionElement.idl: Generate a constructor.

Oct 25, 2008:

1:26 PM Changeset in webkit [37894] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-10-25 Geoffrey Garen <ggaren@apple.com>

Not reviewed.


Try to fix Windows build.

  • VM/Machine.cpp: (JSC::Machine::privateExecute): Provide a dummy value to the HostCallRecord in CTI non-sampling builds, to silence compiler warning.
1:21 PM Changeset in webkit [37893] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-10-25 Geoffrey Garen <ggaren@apple.com>

Not reviewed.


Try to fix Windows build.

  • VM/SamplingTool.h: (JSC::SamplingTool::encodeSample): Explicitly cast bool to int, to silence compiler warning.
1:03 PM Changeset in webkit [37892] by ggaren@apple.com
  • 3 edits in trunk/WebCore

2008-10-25 Geoffrey Garen <ggaren@apple.com>

Not reviewed.


Try to fix Mac debug build on the buildbot.

  • platform/FileChooser.cpp: (WebCore::FileChooserClient::~FileChooserClient):
  • platform/FileChooser.h: Moved destructor to .cpp file, to avoid a weak exported symbol.
12:59 PM Changeset in webkit [37891] by ggaren@apple.com
  • 16 edits in trunk/JavaScriptCore

2008-10-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig, with Gavin Barraclough's help.


Fixed Sampling Tool:

  • Made CodeBlock sampling work with CTI
  • Improved accuracy by unifying most sampling data into a single 32bit word, which can be written / read atomically.
  • Split out three different #ifdefs for modularity: OPCODE_SAMPLING; CODEBLOCK_SAMPLING; OPCODE_STATS.
  • Improved reporting clarity
  • Refactored for code clarity
  • VM/CTI.cpp: (JSC::CTI::emitCTICall): (JSC::CTI::compileOpCall): (JSC::CTI::emitSlowScriptCheck): (JSC::CTI::compileBinaryArithOpSlowCase): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile):
  • VM/CTI.h: Updated CTI codegen to use the unified SamplingTool interface for encoding samples. (This required passing the current vPC to a lot more functions, since the unified interface samples the current vPC.) Added hooks for writing the current CodeBlock* on function entry and after a function call, for the sake of the CodeBlock sampler. Removed obsolete hook for clearing the current sample inside op_end. Also removed the custom enum used to differentiate flavors of op_call, since the OpcodeID enum works just as well. (This was important in an earlier version of the patch, but now it's just cleanup.)
  • VM/CodeBlock.cpp: (JSC::CodeBlock::lineNumberForVPC):
  • VM/CodeBlock.h: Upated for refactored #ifdefs. Changed lineNumberForVPC to be robust against vPCs not recorded for exception handling, since the Sampler may ask for an arbitrary vPC.
  • VM/Machine.cpp: (JSC::Machine::execute): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_construct_NotJSConstruct):
  • VM/Machine.h: (JSC::Machine::setSampler): (JSC::Machine::sampler): (JSC::Machine::jitCodeBuffer): Upated for refactored #ifdefs. Changed Machine to use SamplingTool helper objects to record movement in and out of host code. This makes samples a bit more precise.


  • VM/Opcode.cpp: (JSC::OpcodeStats::~OpcodeStats):
  • VM/Opcode.h: Upated for refactored #ifdefs. Added a little more padding, to accomodate our more verbose opcode names.
  • VM/SamplingTool.cpp: (JSC::ScopeSampleRecord::sample): Only count a sample toward our total if we actually record it. This solves cases where a CodeBlock will claim to have been sampled many times, with reported samples that don't match.

(JSC::SamplingTool::run): Read the current sample into a Sample helper
object, to ensure that the data doesn't change while we're analyzing it,
and to help decode the data. Only access the CodeBlock sampling hash
table if CodeBlock sampling has been enabled, so non-CodeBlock sampling
runs can operate with even less overhead.

(JSC::SamplingTool::dump): I reorganized this code a lot to print the
most important info at the top, print as a table, annotate and document
the stuff I didn't understand when I started, etc.

  • VM/SamplingTool.h: New helper classes, described above.
  • kjs/Parser.h:
  • kjs/Shell.cpp: (runWithScripts):
  • kjs/nodes.cpp: (JSC::ScopeNode::ScopeNode): Updated for new sampling APIs.
  • wtf/Platform.h: Moved sampling #defines here, since our custom is to put ENABLE #defines into Platform.h. Made explicit the fact that CODEBLOCK_SAMPLING depends on OPCODE_SAMPLING.
12:11 PM Changeset in webkit [37890] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wx build fix.

8:22 AM Changeset in webkit [37889] by vestbo@webkit.org
  • 4 edits in trunk

2008-10-25 Jade Han <jade.han@nokia.com>

Reviewed by Anders.

Enable custom properties for Qt runtime objects in QtWebKit

https://bugs.webkit.org/show_bug.cgi?id=21813

2:37 AM Changeset in webkit [37888] by jmalonzo@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-25 Jan Michael Alonzo <jmalonzo@webkit.org>

JSC Build fix, not reviewed.

  • VM/CTI.cpp: add missing include stdio.h for debug builds
12:24 AM Changeset in webkit [37887] by jmalonzo@webkit.org
  • 2 edits in trunk

2008-10-25 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix: add '-' to Wl which was missed in r36845

  • GNUmakefile.am:
Note: See TracTimeline for information about the timeline view.