Timeline
Dec 9, 2008:
- 11:59 PM Changeset in webkit [39165] by
-
- 2 edits1 move in trunk
Rubber-stamped by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=19762
Crash in svg/webarchive/svg-cursor-subresources.svg
- svg/webarchive/svg-cursor-subresources.svg: Copied from LayoutTests/svg/webarchive/svg-cursor-subresources.svg-disabled.
- svg/webarchive/svg-cursor-subresources.svg-disabled: Removed. Re-enabling the test.
- 11:54 PM Changeset in webkit [39164] by
-
- 4 edits1 copy2 adds in trunk
2008-12-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Added WREC support for an assertion followed by a quantifier. Fixed
PCRE to match.
- wrec/WRECParser.cpp: (JSC::WREC::Parser::parseParentheses): Throw away the quantifier, since it's meaningless. (Firefox does the same.)
- pcre/pcre_compile.cpp: (compileBranch): ditto.
LayoutTests:
2008-12-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Added a test for an assertion followed by a quantifier.
- fast/regex/quantified-assertions-expected.txt: Added.
- fast/regex/quantified-assertions.html: Added.
- fast/regex/resources/quantified-assertions.js: Copied from fast/regex/resources/alternative-length-miscalculation.js.
- 10:48 PM Changeset in webkit [39163] by
-
- 4 edits in trunk/WebCore
2008-12-09 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Add ScriptController::updateSecurityOrigin to notify the bindings
that a document's securityOrigin has been updated. This is used by
V8 to update its security context.
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::updateSecurityOrigin):
- bindings/js/ScriptController.h:
- dom/Document.cpp: (WebCore::Document::setDomain):
- 8:59 PM Changeset in webkit [39162] by
-
- 12 edits in trunk
2008-12-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
In preparation for compiling WREC without PCRE:
Further relaxed WREC's parsing to be more web-compatible. Fixed PCRE to
match in cases where it didn't already.
Changed JavaScriptCore to report syntax errors detected by WREC, rather
than falling back on PCRE any time WREC sees an error.
- pcre/pcre_compile.cpp: (checkEscape): Relaxed parsing of \c and \N escapes to be more web-compatible.
- runtime/RegExp.cpp: (JSC::RegExp::RegExp): Only fall back on PCRE if WREC has not reported a syntax error.
- wrec/WREC.cpp: (JSC::WREC::Generator::compileRegExp): Fixed some error reporting to match PCRE.
- wrec/WRECParser.cpp: Added error messages that match PCRE.
(JSC::WREC::Parser::consumeGreedyQuantifier):
(JSC::WREC::Parser::parseParentheses):
(JSC::WREC::Parser::parseCharacterClass):
(JSC::WREC::Parser::parseNonCharacterEscape): Updated the above functions to
use the new setError API.
(JSC::WREC::Parser::consumeEscape): Relaxed parsing of \c \N \u \x \B
to be more web-compatible.
(JSC::WREC::Parser::parseAlternative): Distinguish between a malformed
quantifier and a quantifier with no prefix, like PCRE does.
(JSC::WREC::Parser::consumeParenthesesType): Updated to use the new setError API.
- wrec/WRECParser.h: (JSC::WREC::Parser::error): (JSC::WREC::Parser::syntaxError): (JSC::WREC::Parser::parsePattern): (JSC::WREC::Parser::reset): (JSC::WREC::Parser::setError): Store error messages instead of error codes, to provide for exception messages. Use a setter for reporting errors, so errors detected early are not overwritten by errors detected later.
LayoutTests:
2008-12-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Updated regular expression layout tests to be agnostic between WREC
and PCRE quirks. Also, updated results to match new, more web-compatible
regular expression parsing.
- fast/js/regexp-charclass-crash-expected.txt:
- fast/js/regexp-charclass-crash.html:
- fast/js/regexp-no-extensions-expected.txt:
- fast/js/resources/regexp-no-extensions.js:
- fast/regex/test1-expected.txt:
- 8:22 PM Changeset in webkit [39161] by
-
- 3 edits in trunk/JavaScriptCore
2008-12-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Use va_args to access cti function arguments.
https://bugs.webkit.org/show_bug.cgi?id=22774
This may be a minor regression, but we'll take the hit if so to reduce fragility.
- interpreter/Interpreter.cpp:
- interpreter/Interpreter.h:
- 5:42 PM Changeset in webkit [39160] by
-
- 2 edits in trunk/WebKitTools
Fix gdb-safari on Tiger.
gdb on Tiger does not take the -arch flag, so do not pass it.
Rubber-stamped by Ada Chan.
- 5:35 PM Changeset in webkit [39159] by
-
- 1 edit3 adds in trunk/LayoutTests
2008-12-09 David Levin <levin@chromium.org>
Reviewed by Eric Seidel.
Add a test to check for checks when attaching an event to a document created by
'document.implementation.createDocument'.
- fast/events/create-document-crash-on-attach-event-expected.txt: Added.
- fast/events/create-document-crash-on-attach-event.html: Added.
- fast/events/resources/create-document-crash-on-attach-event.js: Added. (doc.onload):
- 5:28 PM Changeset in webkit [39158] by
-
- 1 edit5 adds in trunk/LayoutTests
2008-12-09 David Levin <levin@chromium.org>
Reviewed by Eric Seidel.
Add a test to check the event order for context clicks on Windows.
- platform/win/fast/events/context-click-events-expected.txt: Added.
- platform/win/fast/events/context-click-events.html: Added.
- platform/win/fast/events/resources: Added.
- platform/win/fast/events/resources/TEMPLATE.html: Added.
- platform/win/fast/events/resources/context-click-events.js: Added. (clickHandler): (traceMouseEvent):
- 4:39 PM Changeset in webkit [39157] by
-
- 3 edits in trunk/JavaScriptCore
2008-12-09 Sam Weinig <sam@webkit.org>
Reviewed twice by Cameron Zwarich.
Fix for https://bugs.webkit.org/show_bug.cgi?id=22752
Clear SymbolTable after codegen for Function codeblocks that
don't require an activation
This is a ~1.5MB improvement on Membuster-head.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dumpStatistics): Add logging of non-empty symbol tables and total size used by symbol tables.
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::generate): Clear the symbol table here.
- 4:26 PM Changeset in webkit [39156] by
-
- 5 edits in trunk/JavaScriptCore
2008-12-09 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Remove unnecessary extra lookup when throwing an exception.
We used to first lookup the target offset using getHandlerForVPC
and then we would lookup the native code stub using
nativeExceptionCodeForHandlerVPC. Instead, we can just pass around
the HandlerInfo.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::handlerForVPC): Return the HandlerInfo.
- bytecode/CodeBlock.h: Remove nativeExceptionCodeForHandlerVPC.
- interpreter/Interpreter.cpp: (JSC::Interpreter::throwException): Return a HandlerInfo instead of and Instruction offset. (JSC::Interpreter::privateExecute): Get the offset from HandlerInfo. (JSC::Interpreter::cti_op_throw): Get the native code from the HandleInfo. (JSC::Interpreter::cti_vm_throw): Ditto.
- interpreter/Interpreter.h:
- 4:14 PM Changeset in webkit [39155] by
-
- 2 edits in trunk/WebKit/mac
2008-12-09 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Fix typecast.
- WebView/WebHTMLView.mm: (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]):
- 4:13 PM Changeset in webkit [39154] by
-
- 5 edits in trunk/WebKit/mac
2008-12-09 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Implement software rendering of hosted plug-ins.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCInvalidateRect): New MiG function. This is called by the plug-in host when it has drawn something.
- Plugins/Hosted/WebHostedNetscapePluginView.h:
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView createPlugin]): Create a software renderer.
(-[WebHostedNetscapePluginView destroyPlugin]):
Destroy the software renderer.
(-[WebHostedNetscapePluginView drawRect:]):
Draw using the software renderer.
- Plugins/Hosted/WebKitPluginClient.defs: Add InvalidateRect.
- 4:11 PM Changeset in webkit [39153] by
-
- 4 edits in trunk
No review, build fix only.
Fix a few config issues to let the Chromium Windows WebCore build get further.
- WebCore.scons:
- 4:01 PM Changeset in webkit [39152] by
-
- 16 edits in trunk
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=22177
Add a callback on ChromeClient that the state of form elements on
the page has changed. This is to allow clients implementing session
saving to know when the current state is dirty.
- 3:51 PM Changeset in webkit [39151] by
-
- 2 edits in trunk/WebKit/mac
2008-12-09 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Make sure to pause null events for hosted plug-ins as well.
- WebView/WebHTMLView.mm: (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]):
- 3:49 PM Changeset in webkit [39150] by
-
- 3 edits in trunk/WebKit/mac
2008-12-09 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
- Plugins/Hosted/NetscapePluginHostProxy.h:
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Unfortunately we can't use a libdispatch source right now, because of <rdar://problem/6393180>.
- 3:36 PM Changeset in webkit [39149] by
-
- 6 edits in trunk/WebCore
2008-12-09 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Fix intermittent crash in buildbot. The CSSCursorImageValues and
SVGCursorElements held onto raw SVGElement pointers without any
guarantee that the element is still around.
We did not fix the design that resulted in this issue, we just fixed
the pointer lifetimes.
- css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::~CSSCursorImageValue): Zero out the back pointers. (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed): Set up a back pointer. (WebCore::CSSCursorImageValue::removeReferencedElement): Added. Used when the element is destroyed.
- css/CSSCursorImageValue.h: Added removeReferencedElement.
- svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::~SVGCursorElement): Zero out the back pointers. (WebCore::SVGCursorElement::addClient): Set up a back pointer. (WebCore::SVGCursorElement::removeClient): Zero out the back pointer.
- svg/SVGElement.cpp: (WebCore::SVGElement::SVGElement): Initialize back pointers to zero. (WebCore::SVGElement::~SVGElement): Call both the element and cursor image value to remove the element from their sets.
- svg/SVGElement.h: (WebCore::SVGElement::setCursorElement): Added. (WebCore::SVGElement::setCursorImageValue): Added.
- 3:33 PM Changeset in webkit [39148] by
-
- 2 edits in trunk/JavaScriptCore
No review, build fix only.
Add ExecutableAllocator files missing from Scons build.
- JavaScriptCore.scons:
- 3:11 PM Changeset in webkit [39147] by
-
- 2 edits in trunk/WebKit/cf
2008-12-09 Dimitri Glazkov <Dimitri Glazkov>
Fix bustage.
- WebCoreSupport/WebInspectorClientCF.cpp:
- 2:36 PM Changeset in webkit [39146] by
-
- 2 edits in trunk/WebCore
2008-12-09 David Hyatt <hyatt@apple.com>
Add code that will create custom CSS scrollbars from the <body>, the document element (<html>) and the owning
frame/iframe. If any of them set a custom style, it will be used. The scrollbars do not update dynamically
yet as you switch from page to page (until they are destroyed and recreated).
Reviewed by Adele
- page/FrameView.cpp: (WebCore::FrameView::createScrollbar):
- 2:02 PM Changeset in webkit [39145] by
-
- 3 edits in trunk/WebKit/mac
Implement a few methods needed to keep Dictionary.app working on Leopard.
<rdar://problem/6002160> Internal changes to WebKit in Safari 4
Developer Preview might break Dictionary
Reviewed by Dan Bernstein.
- WebView/WebFrame.mm: (-[WebFrame convertNSRangeToDOMRange:]): Added. Calls _convertNSRangeToDOMRange. (-[WebFrame convertDOMRangeToNSRange:]): Added. Calls _convertDOMRangeToNSRange.
- WebView/WebHTMLView.mm: (-[WebHTMLView _bridge]): Added. Returns the WebFrame, which has the methods that Dictionary.app is using.
- 1:46 PM Changeset in webkit [39144] by
-
- 7 edits in trunk/WebCore
2008-12-09 Ojan Vafai <ojan@chromium.org>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=22689
Match Firefox button metrics on Windows.
- rendering/RenderButton.cpp: (WebCore::RenderButton::addChild): (WebCore::RenderButton::styleDidChange): (WebCore::RenderButton::setupInnerStyle):
- rendering/RenderButton.h:
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustButtonInnerStyle):
- rendering/RenderTheme.h:
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustSliderThumbSize): (WebCore::RenderThemeWin::adjustButtonInnerStyle):
- rendering/RenderThemeWin.h:
- 12:43 PM Changeset in webkit [39143] by
-
- 1 edit4 adds in trunk/WebCore
2008-12-09 Darin Fisher <darin@chromium.org>
Fixes bustages.
https://bugs.webkit.org/show_bug.cgi?id=22631
Adding missing files from previous commit.
- bindings/js/ScriptCallFrame.cpp: Added. (WebCore::ScriptCallFrame::ScriptCallFrame): (WebCore::ScriptCallFrame::~ScriptCallFrame): (WebCore::ScriptCallFrame::argumentAt):
- bindings/js/ScriptCallFrame.h: Added. (WebCore::ScriptCallFrame::functionName): (WebCore::ScriptCallFrame::sourceURL): (WebCore::ScriptCallFrame::lineNumber): (WebCore::ScriptCallFrame::argumentCount):
- bindings/js/ScriptCallStack.cpp: Added. (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::~ScriptCallStack): (WebCore::ScriptCallStack::at): (WebCore::ScriptCallStack::size): (WebCore::ScriptCallStack::initialize):
- bindings/js/ScriptCallStack.h: Added. (WebCore::ScriptCallStack::state):
- 12:25 PM Changeset in webkit [39142] by
-
- 19 edits in trunk
2008-12-09 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Timothy Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=22631
Streamline Console.cpp, abstract out the use of JSC::ExecState and
JSC::ArgList by introducing ScriptCallFrame and ScriptCallStack
abstractions.
- GNUmakefile.am: Added ScriptCallFrame and ScriptCallStack to build
- WebCore.pro: Added ScriptCallFrame and ScriptCallStack to build
- WebCore.vcproj/WebCore.vcproj: Added ScriptCallFrame and ScriptCallStack to project
- WebCore.xcodeproj/project.pbxproj: Added ScriptCallFrame and ScriptCallStack to project
- bindings/js/JSConsoleCustom.cpp: Remove custom bindings.
- bindings/js/ScriptCallFrame.cpp: Added. (WebCore::ScriptCallFrame::ScriptCallFrame): (WebCore::ScriptCallFrame::~ScriptCallFrame): (WebCore::ScriptCallFrame::argumentAt):
- bindings/js/ScriptCallFrame.h: Added. (WebCore::ScriptCallFrame::functionName): (WebCore::ScriptCallFrame::sourceURL): (WebCore::ScriptCallFrame::lineNumber): (WebCore::ScriptCallFrame::argumentCount):
- bindings/js/ScriptCallStack.cpp: Added. (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::~ScriptCallStack): (WebCore::ScriptCallStack::at): (WebCore::ScriptCallStack::size): (WebCore::ScriptCallStack::initialize):
- bindings/js/ScriptCallStack.h: Added. (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::~ScriptCallStack): (WebCore::ScriptCallStack::state): (WebCore::ScriptCallStack::at): (WebCore::ScriptCallStack::size): (WebCore::ScriptCallStack::initialize):
- bindings/js/ScriptString.h: Added missing PlatformString include. (WebCore::ScriptString::ScriptString): Added default constructor. (WebCore::ScriptString::operator==): Added equality operator. (WebCore::ScriptString::operator!=):
- bindings/js/ScriptValue.cpp: Added isNull and isUndefined. (WebCore::ScriptValue::isNull): (WebCore::ScriptValue::isUndefined):
- bindings/js/ScriptValue.h: Added isNull and isUndefined
- bindings/scripts/CodeGeneratorJS.pm: Add handling for CustomArgumentHandling attribute.
- inspector/InspectorController.cpp: Refactored to use ScriptCallFrame and ScriptCallStack. (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::addScriptConsoleMessage): (WebCore::InspectorController::count): (WebCore::InspectorController::startTiming): (WebCore::InspectorController::stopTiming):
- inspector/InspectorController.h: Refactored to use ScriptCallFrame and ScriptCallStack.
- inspector/front-end/Console.js: Modified to use argument value itself rather than f.name for stack trace.
- page/Console.cpp: Refactored to use ScriptCallFrame and ScriptCallStack. (WebCore::getFirstArgumentAsString): (WebCore::Console::addMessage): (WebCore::Console::debug): (WebCore::Console::error): (WebCore::Console::info): (WebCore::Console::log): (WebCore::Console::dir): (WebCore::Console::dirxml): (WebCore::Console::trace): (WebCore::Console::assertCondition): (WebCore::Console::count): (WebCore::Console::profile): (WebCore::Console::profileEnd): (WebCore::Console::time): (WebCore::Console::timeEnd): (WebCore::Console::group): (WebCore::Console::warn):
- page/Console.h:
- page/Console.idl: Removed Custom attributes, added CustomArgumentHandling attributes, and tweaked argument defs.
- 11:19 AM Changeset in webkit [39141] by
-
- 5 edits in trunk/JavaScriptCore
2008-12-08 Judit Jasz <jasy@inf.u-szeged.hu>
Reviewed and tweaked by Cameron Zwarich.
Bug 22352: Annotate opcodes with their length
<https://bugs.webkit.org/show_bug.cgi?id=22352>
- bytecode/Opcode.cpp:
- bytecode/Opcode.h:
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- 10:42 AM Changeset in webkit [39140] by
-
- 7 edits in trunk/WebCore
2008-12-09 Darin Adler <Darin Adler>
Try to fix non-Mac builds.
- GNUmakefile.am: Added NavigatorBase.
- WebCore.pro: Ditto.
- WebCore.scons: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCoreSources.bkl: Ditto.
Unrelated tweak sitting in my tree.
- bindings/objc/DOMAbstractView.mm: Remove pointless override of finalize method.
- 10:38 AM Changeset in webkit [39139] by
-
- 2 edits in trunk/WebCore
2008-12-09 Darin Adler <Darin Adler>
Try to fix Tiger build.
- platform/network/mac/NetworkStateNotifierMac.cpp: Declare CFRunLoopGetMain.
- 9:58 AM Changeset in webkit [39138] by
-
- 17 edits7 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22719
Implement Navigator object in Workers
Test: fast/workers/worker-navigator.html
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj: Added WorkerNavigator sources.
- bindings/js/JSWorkerContext.cpp: (WebCore::jsWorkerContextNavigator): Worker.navigator returns a WoerkerNavigator object (it is named just Navigator in the spec, but it is not the same interface that is available on Windows).
- dom/Worker.cpp: (WebCore::Worker::notifyFinished):
- dom/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::navigator):
- dom/WorkerContext.h: (WebCore::WorkerContext::create):
- dom/WorkerThread.cpp: (WebCore::WorkerThread::create): (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::workerThread):
- dom/WorkerThread.h: Pass a pre-computed user agent string into worker, because it cannot call a client method directly, and pre-computing is easier than sending a synchronous message to the main thread.
- page/Navigator.cpp:
- page/Navigator.h:
- page/NavigatorBase.cpp: Added.
- page/NavigatorBase.h: Added. Factor out common (and uncommon, but very similar) functionality into a base class.
- page/WorkerNavigator.cpp: Added.
- page/WorkerNavigator.h: Added.
- page/WorkerNavigator.idl: Added. Per Web Workers and HTML5, implement a small subset of what we currently have in Window.Navigator.
- platform/network/NetworkStateNotifier.cpp: (WebCore::networkStateNotifier): Make networkStateNotifier() static constructor thread safe. The object is created on the thread it is first called from, while callbacks are registered on the main thread. Calls to onLine() from other threads are safe, because it is just loading a boolean.
- platform/network/mac/NetworkStateNotifierMac.cpp: (WebCore::NetworkStateNotifier::NetworkStateNotifier): Schedule notifications on main event loop, not the current one.
- 9:53 AM Changeset in webkit [39137] by
-
- 2 edits in trunk/LayoutTests
2008-12-09 Pamela Greene <pam@chromium.org>
Submitted without review.
Corrected results so the test passes.
- fast/events/special-key-events-in-input-text-expected.txt:
- 8:42 AM QtWebKitGitInstructions edited by
- (diff)
- 8:40 AM Changeset in webkit [39136] by
-
- 2 edits in trunk/WebKit/qt
008-12-09 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon Hausmann.
Fix the documentation of the localStorageDatabasePath setters/getters.
- 6:50 AM Changeset in webkit [39135] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Alexey Proskuryakov.
Forgot to update Qt/WML build - add some new files to the build.
- 6:48 AM Changeset in webkit [39134] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fixed more ChangeLog dates.
- 6:42 AM Changeset in webkit [39133] by
-
- 16 edits2 moves13 adds in trunk
Reviewed by Alexey Proskuryakov.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22637
Implement the GET method for WMLGoElement, and some test covering it's behaviour.
Update all build systems supporting WML that haven't been updated since a while.
Add WMLPostField stub implementation, needed for implementing POST method.
Tests: wml/go-task-get-method-external-deck-with-href.html
wml/go-task-get-method-external-deck.html
wml/go-task-get-method-same-deck.html
- 2:13 AM Changeset in webkit [39132] by
-
- 4 edits in trunk/WebKit/qt
2008-12-08 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon Hausmann.
Multiple files support for the file chooser.
- Api/qwebpage.cpp: (QWebPage::chooseFiles):
- Api/qwebpage.h:
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runOpenPanel):
Dec 8, 2008:
- 11:48 PM Changeset in webkit [39131] by
-
- 1 edit3 adds in trunk/LayoutTests
2008-12-08 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
Test for https://bugs.webkit.org/show_bug.cgi?id=22710
Verifies that active timeout does not cause memory leak.
- fast/dom/Window/resources/long_timeout.html: Added.
- fast/dom/Window/timeout-released-on-close-expected.txt: Added.
- fast/dom/Window/timeout-released-on-close.html: Added.
- 11:24 PM Changeset in webkit [39130] by
-
- 6 edits in trunk/JavaScriptCore
2008-12-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Implemented more of the relaxed and somewhat weird rules for deciding
how to interpret a non-pattern-character.
- wrec/Escapes.h:
(JSC::WREC::Escape::):
(JSC::WREC::Escape::Escape): Eliminated Escape::None because it was
unused. If you see an '
', it's either a valid escape or an error.
- wrec/Quantifier.h: (JSC::WREC::Quantifier::Quantifier):
- wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateNonGreedyQuantifier): (JSC::WREC::Generator::generateGreedyQuantifier): Renamed "noMaxSpecified" to "Infinity", since that's what it means.
- wrec/WRECParser.cpp: (JSC::WREC::Parser::consumeGreedyQuantifier): Re-wrote {n,m} parsing rules because they were too strict before. Added support for backtracking in the case where the {n,m} fails to parse as a quantifier, and yet is not a syntax error.
(JSC::WREC::Parser::parseCharacterClass):
(JSC::WREC::Parser::parseNonCharacterEscape): Eliminated Escape::None,
as above.
(JSC::WREC::Parser::consumeEscape): Don't treat ASCII and _ escapes
as syntax errors. See fast/regex/non-pattern-characters.html.
- wrec/WRECParser.h: (JSC::WREC::Parser::SavedState::SavedState): (JSC::WREC::Parser::SavedState::restore): Added a state backtracker, since parsing {n,m} forms requires backtracking if the form turns out not to be a quantifier.
- 11:07 PM Changeset in webkit [39129] by
-
- 2 edits in trunk/WebKitTools
2008-12-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Added a shortcut for --jsDriver-args, which I use a lot.
- Scripts/run-javascriptcore-tests:
- 10:47 PM Changeset in webkit [39128] by
-
- 4 edits in trunk/JavaScriptCore
2008-12-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Refactored WREC parsing so that only one piece of code needs to know
the relaxed and somewhat weird rules for deciding how to interpret a
non-pattern-character, in preparation for implementing those rules.
Also, implemented the relaxed and somewhat weird rules for '}' and ']'.
- wrec/WREC.cpp: Reduced the regular expression size limit. Now that WREC handles ']' properly, it compiles fast/js/regexp-charclass-crash.html, which makes it hang at the old limit. (The old limit was based on the misimpression that the same value in PCRE limited the regular expression pattern size; in reality, it limited the expected compiled regular expression size. WREC doesn't have a way to calculate an expected compiled regular expression size, but this should be good enough.)
- wrec/WRECParser.cpp: (JSC::WREC::parsePatternCharacterSequence): Nixed this function because it contained a second copy of the logic for handling non-pattern-characters, which is about to get a lot more complicated.
(JSC::WREC::PatternCharacterSequence::PatternCharacterSequence):
(JSC::WREC::PatternCharacterSequence::size):
(JSC::WREC::PatternCharacterSequence::append):
(JSC::WREC::PatternCharacterSequence::flush): Helper object for generating
an optimized sequence of pattern characters.
(JSC::WREC::Parser::parseNonCharacterEscape): Renamed to reflect the fact
that the main parseAlternative loop handles character escapes.
(JSC::WREC::Parser::parseAlternative): Moved pattern character sequence
logic from parsePatternCharacterSequence to here, using
PatternCharacterSequence to help with the details.
- wrec/WRECParser.h: Updated for renames.
- 10:46 PM Changeset in webkit [39127] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Geoff Garen.
<rdar://problem/6166088> Give JSGlobalContextCreate a behavior that is concurrency aware,
and un-deprecate it
- API/JSContextRef.cpp: (JSGlobalContextCreate):
- API/JSContextRef.h: Use a unique context group for the context, unless the application was linked against old JavaScriptCore.
- 10:29 PM Changeset in webkit [39126] by
-
- 2 edits in trunk/WebKit/win
Reviewed by Adam Roben.
- Fix nightly builds
- Interfaces/IWebViewPrivate.idl: Moved globalHistoryItem() to the end, so that it comes after all methods used by Safari 3.2.1.
- 10:23 PM Changeset in webkit [39125] by
-
- 3 edits in trunk/LayoutTests
2008-12-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed js-test-pre.js to print a meaningful, complete sentence when
exception tests fail.
- fast/js/const-expected.txt: Updated test for new results.
- fast/js/resources/js-test-pre.js: (shouldThrow):
- 9:34 PM Changeset in webkit [39124] by
-
- 2 edits in trunk/WebKitTools
2008-12-08 Stephanie Lewis <Stephanie Lewis>
Fix Tiger build.
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
- 9:27 PM Changeset in webkit [39123] by
-
- 5 edits in trunk/JavaScriptCore
2008-12-08 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Fix for <rdar://problem/6428332> Remove the CTI return address table from CodeBlock
Step 1:
Remove use of jitReturnAddressVPCMap when looking for vPC to store Structures
in for cached lookup. Instead, use the offset in the StructureStubInfo that is
already required.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dumpStatistics): Fix extraneous semicolon.
- interpreter/Interpreter.cpp: (JSC::Interpreter::tryCTICachePutByID): (JSC::Interpreter::tryCTICacheGetByID): (JSC::Interpreter::cti_op_get_by_id_self_fail): (JSC::Interpreter::cti_op_get_by_id_proto_list):
- jit/JIT.h: (JSC::JIT::compileGetByIdSelf): (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdChain): (JSC::JIT::compilePutByIdReplace): (JSC::JIT::compilePutByIdTransition):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): Remove extra call to getStubInfo. (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace):
- 8:54 PM Changeset in webkit [39122] by
-
- 3 edits in trunk/JavaScriptCore
2008-12-08 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Port the op_j?n?eq_null JIT code generation to use the MacroAssembler,
and clean up slightly at the same time. The 'j' forms currently compare,
then set a register, then compare again, then branch. Branch directly on
the result of the first compare.
Around a 1% progression on deltablue, crypto & early boyer, for about 1/2%
overall on v8-tests.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdSlowCase):
- 6:10 PM Changeset in webkit [39121] by
-
- 5 edits in trunk/JavaScriptCore
2008-12-08 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Expand MacroAssembler to support more operations, required by the JIT.
Generally adds more operations and permutations of operands to the existing
interface. Rename 'jset' to 'jnz' and 'jnset' to 'jz', which seem clearer,
and require that immediate pointer operands (though not pointer addresses to
load and store instructions) are wrapped in a ImmPtr() type, akin to Imm32().
No performance impact.
- assembler/MacroAssembler.h: (JSC::MacroAssembler::): (JSC::MacroAssembler::ImmPtr::ImmPtr): (JSC::MacroAssembler::add32): (JSC::MacroAssembler::and32): (JSC::MacroAssembler::or32): (JSC::MacroAssembler::sub32): (JSC::MacroAssembler::xor32): (JSC::MacroAssembler::loadPtr): (JSC::MacroAssembler::load32): (JSC::MacroAssembler::storePtr): (JSC::MacroAssembler::store32): (JSC::MacroAssembler::poke): (JSC::MacroAssembler::move): (JSC::MacroAssembler::testImm32): (JSC::MacroAssembler::jae32): (JSC::MacroAssembler::jb32): (JSC::MacroAssembler::jePtr): (JSC::MacroAssembler::je32): (JSC::MacroAssembler::jnePtr): (JSC::MacroAssembler::jne32): (JSC::MacroAssembler::jnzPtr): (JSC::MacroAssembler::jnz32): (JSC::MacroAssembler::jzPtr): (JSC::MacroAssembler::jz32): (JSC::MacroAssembler::joSub32): (JSC::MacroAssembler::jump): (JSC::MacroAssembler::sete32): (JSC::MacroAssembler::setne32): (JSC::MacroAssembler::setnz32): (JSC::MacroAssembler::setz32):
- assembler/X86Assembler.h: (JSC::X86Assembler::addl_mr): (JSC::X86Assembler::andl_i8r): (JSC::X86Assembler::cmpl_rm): (JSC::X86Assembler::cmpl_mr): (JSC::X86Assembler::cmpl_i8m): (JSC::X86Assembler::subl_mr): (JSC::X86Assembler::testl_i32m): (JSC::X86Assembler::xorl_i32r): (JSC::X86Assembler::movl_rm): (JSC::X86Assembler::modRm_opmsib):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JITInlineMethods.h: (JSC::JIT::emitGetVirtualRegister): (JSC::JIT::emitPutCTIArgConstant): (JSC::JIT::emitPutCTIParam): (JSC::JIT::emitPutImmediateToCallFrameHeader): (JSC::JIT::emitInitRegister): (JSC::JIT::checkStructure): (JSC::JIT::emitJumpIfJSCell): (JSC::JIT::emitJumpIfNotJSCell): (JSC::JIT::emitJumpSlowCaseIfNotImmNum):
- 6:01 PM Changeset in webkit [39120] by
-
- 2 edits in trunk/LayoutTests
2008-12-08 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Dan Bernstein.
Increase timeout in video-paint-test.js so that <video> tests pass on the Tiger pixel bot which is slower
than the Leopard one.
- media/video-paint-test.js: (init):
- 5:10 PM Changeset in webkit [39119] by
-
- 4 edits3 adds in trunk
2008-12-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed a bug where WREC would allow a quantifier whose minimum was
greater than its maximum.
- wrec/Quantifier.h: (JSC::WREC::Quantifier::Quantifier): ASSERT that the quantifier is not backwards.
- wrec/WRECParser.cpp: (JSC::WREC::Parser::consumeGreedyQuantifier): Verify that the minimum is not greater than the maximum.
LayoutTests:
2008-12-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added a test for interesting uses of non-pattern-characters in regular
expressions.
- fast/regex/non-pattern-characters-expected.txt: Added.
- fast/regex/non-pattern-characters.html: Added.
- fast/regex/resources/non-pattern-characters.js: Added.
- 5:09 PM Changeset in webkit [39118] by
-
- 2 edits in trunk/JavaScriptCore
Build fix only, no review.
- JavaScriptCore.scons: add bytecode/JumpTable.cpp
- 5:07 PM Changeset in webkit [39117] by
-
- 12 edits in trunk/WebKit/mac
2008-12-08 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
More work towards getting NPN_GetURL working.
- Plugins/Hosted/HostedNetscapePluginStream.h: Inherit from NetscapePlugInStreamLoaderClient.
(WebKit::HostedNetscapePluginStream::streamID):
- Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::startStream): Keep track of the resposne URL and the MIME type. Pass the response URL to the plug-in host.
(WebKit::HostedNetscapePluginStream::didFinishLoading):
Disconnect the stream.
(WebKit::HostedNetscapePluginStream::start):
Create a plug-in stream loader and start loading.
(WebKit::HostedNetscapePluginStream::stop):
Cancel the load.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCLoadURL): Fix the parameter order.
(WKPCCancelLoadURL):
New function that cancels a load of a stream with a given reason.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::destroy): Stop the streams.
(WebKit::NetscapePluginInstanceProxy::pluginStream):
Return a plug-in stream given a stream ID.
(WebKit::NetscapePluginInstanceProxy::disconnectStream):
Remove the stream from the streams map.
(WebKit::NetscapePluginInstanceProxy::loadRequest):
Create a stream and load it.
- Plugins/Hosted/WebKitPluginClient.defs: Add CancelLoadURL.
- Plugins/Hosted/WebKitPluginHost.defs: Add responseURL to StartStream.
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginPackage]): Move this down to the base class from WebNetscapePluginView.
- Plugins/WebNetscapePluginView.h:
- Plugins/WebNetscapePluginView.mm:
- 5:06 PM Changeset in webkit [39116] by
-
- 3 edits in trunk/JavaScriptCore
2008-12-08 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Patch for https://bugs.webkit.org/show_bug.cgi?id=22716
<rdar://problem/6428315>
Add RareData structure to CodeBlock for infrequently used auxiliary data
members.
Reduces memory on Membuster-head by ~.5MB
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::dumpStatistics): (JSC::CodeBlock::mark): (JSC::CodeBlock::getHandlerForVPC): (JSC::CodeBlock::nativeExceptionCodeForHandlerVPC): (JSC::CodeBlock::shrinkToFit):
- bytecode/CodeBlock.h: (JSC::CodeBlock::numberOfExceptionHandlers): (JSC::CodeBlock::addExceptionHandler): (JSC::CodeBlock::exceptionHandler): (JSC::CodeBlock::addFunction): (JSC::CodeBlock::function): (JSC::CodeBlock::addUnexpectedConstant): (JSC::CodeBlock::unexpectedConstant): (JSC::CodeBlock::addRegExp): (JSC::CodeBlock::regexp): (JSC::CodeBlock::numberOfImmediateSwitchJumpTables): (JSC::CodeBlock::addImmediateSwitchJumpTable): (JSC::CodeBlock::immediateSwitchJumpTable): (JSC::CodeBlock::numberOfCharacterSwitchJumpTables): (JSC::CodeBlock::addCharacterSwitchJumpTable): (JSC::CodeBlock::characterSwitchJumpTable): (JSC::CodeBlock::numberOfStringSwitchJumpTables): (JSC::CodeBlock::addStringSwitchJumpTable): (JSC::CodeBlock::stringSwitchJumpTable): (JSC::CodeBlock::evalCodeCache): (JSC::CodeBlock::createRareDataIfNecessary):
- 4:35 PM Changeset in webkit [39115] by
-
- 4 edits in trunk
2008-11-26 Peter Kasting <pkasting@google.com>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=16814
Allow ports to disable ActiveX->NPAPI conversion for Media Player.
Improve handling of miscellaneous ActiveX objects.
- wtf/Platform.h: Add another ENABLE(...).
WebCore:
2008-11-26 Peter Kasting <pkasting@google.com>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=16814
Allow ports to disable ActiveX->NPAPI conversion for Media Player.
Improve handling of miscellaneous ActiveX objects.
- rendering/RenderPartObject.cpp: (WebCore::mapClassIdToServiceType): (WebCore::shouldUseChildEmbedOfObject): (WebCore::RenderPartObject::updateWidget):
- 4:15 PM Changeset in webkit [39114] by
-
- 13 edits1 copy7 adds in trunk
WebCore:
2008-12-03 Darin Adler <Darin Adler>
Reviewed by John Sullivan.
- fix https://bugs.webkit.org/show_bug.cgi?id=22409 REGRESSION: cmd-shift-left/right don't switch tabs, instead select text
Tests: editing/execCommand/enabling-and-selection-2.html
editing/execCommand/enabling-and-selection.html
- editing/EditorCommand.cpp: Updated table to use these functions by their new names. (WebCore::enabledVisibleSelection): Renamed this to reflect its new algorithm. An invisible selection with a position that selects no characters doesn't count as a visible selection. (WebCore::enabledVisibleSelectionAndMark): Ditto.
WebKitTools:
2008-12-08 Darin Adler <Darin Adler>
Reviewed by John Sullivan.
- test machinery for https://bugs.webkit.org/show_bug.cgi?id=22409 REGRESSION: cmd-shift-left/right don't switch tabs, instead select text
- DumpRenderTree/LayoutTestController.cpp: (isCommandEnabledCallback): Added. (LayoutTestController::staticFunctions): Added "isCommandEnabled".
- DumpRenderTree/LayoutTestController.h: Ditto.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::isCommandEnabled): Ditto.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (-[CommandValidationTarget initWithAction:]): Added. Used to get the command validation system to tell us if a comment is enabled. (-[CommandValidationTarget action]): Ditto. (-[CommandValidationTarget tag]): Ditto. (LayoutTestController::isCommandEnabled): Ditto.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::isCommandEnabled): Ditto.
LayoutTests:
2008-12-08 Darin Adler <Darin Adler>
Reviewed by John Sullivan.
- tests for https://bugs.webkit.org/show_bug.cgi?id=22409 REGRESSION: cmd-shift-left/right don't switch tabs, instead select text
- editing/execCommand/enabling-and-selection-2-expected.txt: Added.
- editing/execCommand/enabling-and-selection-2.html: Added.
- editing/execCommand/enabling-and-selection-expected.txt: Added.
- editing/execCommand/enabling-and-selection.html: Added.
- editing/execCommand/resources: Added.
- editing/execCommand/resources/TEMPLATE.html: Copied from LayoutTests/fast/js/resources/TEMPLATE.html.
- editing/execCommand/resources/enabling-and-selection-2.js: Added.
- editing/execCommand/resources/enabling-and-selection.js: Added.
- fast/canvas/canvas-setTransform.html: Let make-js-test-wrappers update this.
- fast/canvas/canvas-strokeRect.html: Ditto.
- platform/qt/Skipped: Added enabling-and-selection-2 to the skipped list.
- platform/win/Skipped: Ditto.
- 4:14 PM Changeset in webkit [39113] by
-
- 3 edits in trunk/JavaScriptCore
2008-12-08 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Add dumping of CodeBlock member structure usage.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dumpStatistics):
- bytecode/EvalCodeCache.h: (JSC::EvalCodeCache::isEmpty):
- 4:11 PM Changeset in webkit [39112] by
-
- 2 edits in trunk/WebCore
Remove duplicate entries from WebCore project.
Reviewed by Eric Seidel.
Bug 22555: Sort "children" sections in Xcode project files.
<https://bugs.webkit.org/show_bug.cgi?id=22555>
Recipe for removing duplicates:
$ ./WebKitTools/Scripts/sort-Xcode-project-file project.pbxproj
$ uniq < project.pbxproj | diff -u project.pbxproj - | patch -p0 project.pbxproj
- WebCore.xcodeproj/project.pbxproj: Removed duplicates.
- 4:06 PM Changeset in webkit [39111] by
-
- 10 edits in trunk/WebCore
2008-12-08 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Bug 22665: Remove setCreatedByParser(bool) from the few elements that use it
https://bugs.webkit.org/show_bug.cgi?id=22665
Remove setCreatedByParser from the script elements (HTML and SVG).
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::eventuallyMarkAsParserCreated): Removed call to setCreatedByParser for the 2 elements.
- dom/make_names.pl: Modified to call the constructor with the createByParser parameter if 'constructorNeedsCreatedByParser' is set.
- html/HTMLElementFactory.cpp: (WebCore::scriptConstructor):
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::HTMLScriptElement):
- html/HTMLScriptElement.h:
- html/HTMLTagNames.in: Added constructorNeedsCreatedByParser to script.
- svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::SVGScriptElement):
- svg/SVGScriptElement.h:
- svg/svgtags.in: Added constructorNeedsCreatedByParser to script.
- 4:03 PM Changeset in webkit [39110] by
-
- 1 edit2 adds in trunk/LayoutTests
2008-12-08 Pamela Greene <pam@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22739
Test the sequence of keyboard events generated for a keypress.
- fast/events/special-key-events-in-input-text-expected.txt: Added.
- fast/events/special-key-events-in-input-text.html: Added.
- 4:01 PM Changeset in webkit [39109] by
-
- 15 edits in trunk
Bug 22555: Sort "children" sections in Xcode project files
Reviewed by Eric Seidel.
- JavaScriptCore.xcodeproj/project.pbxproj: Sorted.
JavaScriptGlue:
- JavaScriptGlue.xcodeproj/project.pbxproj: Sorted.
WebCore:
- WebCore.xcodeproj/project.pbxproj: Sorted.
- manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj: Sorted.
WebKit:
- WebKit.xcodeproj/project.pbxproj: Sorted.
WebKitExamplePlugins:
- NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj: Sorted.
WebKitTools:
- DrawTest/DrawTest.xcodeproj/project.pbxproj: Sorted.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Sorted.
- WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Sorted.
- 3:57 PM Changeset in webkit [39108] by
-
- 2 edits in trunk/WebKit
2008-12-08 Darin Adler <Darin Adler>
- StringsNotToBeLocalized.txt: Updated for recent changes.
- 3:44 PM Changeset in webkit [39107] by
-
- 2 edits in trunk/WebKitTools
Bug 22555: Sort "children" sections in Xcode project files
Reviewed by Timothy Hatcher.
- Scripts/sort-Xcode-project-file: By popular request, don't sort the mainGroup in the project (the list of items below the top-level project file).
- 3:42 PM Changeset in webkit [39106] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-08 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
Enable Pan scrolling only when building on PLATFORM(WIN_OS)
Previously platforms like Apple Windows WebKit, Cairo Windows WebKit,
Wx and Chromium were enabling it explicitly, now we just turn it on
for all WIN_OS, later platforms can turn it off as needed on Windows
(or turn it on under Linux, etc.)
https://bugs.webkit.org/show_bug.cgi?id=22698
- wtf/Platform.h:
- 3:42 PM Changeset in webkit [39105] by
-
- 7 edits in trunk/WebCore
2008-12-08 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
Add a bool to GraphicsContext so that shadows can ignore
transformations. This is needed by HTML canvas element
where the spec says shadows are applied w/o transformations.
https://bugs.webkit.org/show_bug.cgi?id=22580
No functional changes, thus no tests.
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setShadow): (WebCore::CanvasRenderingContext2D::applyShadow):
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer):
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setShadowsIgnoreTransforms):
- platform/graphics/GraphicsContext.h:
- platform/graphics/GraphicsContextPrivate.h: (WebCore::GraphicsContextState::GraphicsContextState):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
- 3:18 PM Changeset in webkit [39104] by
-
- 10 edits10 adds in trunk
WebCore:
2008-12-08 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Bug 17897: Not Rendering Images Imported from XHTML Document
<rdar://problem/5827614>
When we were loading document with XMLHttpRequest that contained images, the images
would not be fetched as they would not be displayed. However if we inserted such
an image element into a rendered document, we would not fetch the image and thus never
display it.
Now we check if the image has been loaded when we insert an HTMLImageElement into a
document.
To enable this, the image loader has an error flag. To avoid doing several attempts
when we know that the image is in error, we store the failed URL.
However Firefox and Opera ignore errors when the 'src' attribute changes and thus
we also have an updateFromElementIgnoringPreviousError to match the other browser.
Tests: http/tests/misc/image-blocked-src-change.html
http/tests/misc/image-blocked-src-no-change.html
http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded-svg.svg
http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded.html
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parseMappedAttribute): Changed to call updateFromElementIgnoringPreviousError.
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): Ditto. (WebCore::HTMLImageElement::insertedIntoDocument): Call updateFromElement if we do not have an image.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Changed to call updateFromElementIgnoringPreviousError.
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parseMappedAttribute): Ditto.
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::parseMappedAttribute): Ditto.
- loader/ImageLoader.cpp: (WebCore::ImageLoader::setImage): Added an assertion. (WebCore::ImageLoader::updateFromElement): Added a check for load error (to avoid displaying multiple errors in the console for a single image load).
(WebCore::ImageLoader::updateFromElementIgnoringPreviousError): This method clears previous error
before calling updateFromElement.
(WebCore::ImageLoader::notifyFinished): Added an assertion.
- loader/ImageLoader.h:
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::svgAttributeChanged): Changed to call updateFromElementIgnoringPreviousError.
LayoutTests:
2008-12-08 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Tests cases for bug 17897: Not Rendering Images Imported from XHTML Document
<rdar://problem/5827614>
- xmlhttprequest-image-not-loaded*: test that an image loaded by an XMLHttpRequest and inserted into a XHTML or SVG Document is properly rendered.
- image-blocked-src-change.html and image-blocked-src-no-change.html: test that an image that was in error is responding to src attribute change (whether it does really change the url or not).
- http/tests/misc/image-blocked-src-change-expected.txt: Added.
- http/tests/misc/image-blocked-src-change.html: Added.
- http/tests/misc/image-blocked-src-no-change-expected.txt: Added.
- http/tests/misc/image-blocked-src-no-change.html: Added.
- http/tests/xmlhttprequest/resources/load-icon.svg: Added.
- http/tests/xmlhttprequest/resources/load-icon.xhtml: Added.
- http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded-expected.txt: Added.
- http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded-svg-expected.txt: Added.
- http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded-svg.svg: Added.
- http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded.html: Added.
- 2:36 PM Changeset in webkit [39103] by
-
- 5 edits in trunk/WebCore
2008-12-08 David Hyatt <hyatt@apple.com>
Make scrollbar creation virtual on ScrollView so that FrameView can have the capability to create
custom CSS scrollbars.
Reviewed by Eric Seidel
- page/FrameView.cpp: (WebCore::FrameView::createScrollbar):
- page/FrameView.h:
- platform/ScrollView.cpp: (WebCore::ScrollView::setHasHorizontalScrollbar): (WebCore::ScrollView::setHasVerticalScrollbar): (WebCore::ScrollView::createScrollbar):
- platform/ScrollView.h:
- 1:40 PM Changeset in webkit [39102] by
-
- 3 edits in trunk/JavaScriptCore
2008-12-08 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Add basic memory statistics dumping for CodeBlock.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dumpStatistics): (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::~CodeBlock):
- bytecode/CodeBlock.h:
- 1:39 PM Changeset in webkit [39101] by
-
- 1 edit2 moves in trunk/LayoutTests
Disable the WML tests since no platforms build with WML enabled by default and the test failures are annoying.
Rubber-stamped by Sam Weinig.
- wml/variable-reference-invalid-character.html-disabled: Renamed from LayoutTests/wml/variable-reference-invalid-character.html.
- wml/variable-reference-valid.html-disabled: Renamed from LayoutTests/wml/variable-reference-valid.html.
- 1:18 PM Changeset in webkit [39100] by
-
- 11 edits in trunk
WebCore:
Reviewed by John Sullivan.
- WebCore part of tracking the global history item for a WebView
- loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Set the page's global history item to the current back/forward list item, respecting private browsing mode. (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Ditto in this case. (WebCore::FrameLoader::goToItem): Ditto in this case. (WebCore::FrameLoader::updateHistoryForStandardLoad): If this load creates a new global history item, set the page's global history item to it. (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory): Ditto.
- page/Page.cpp: (WebCore::Page::setGlobalHistoryItem): Added this setter.
- page/Page.h: Added a m_globalHistoryItem data member. (WebCore::Page::globalHistoryItem): Added this getter.
WebKit/mac:
Reviewed by John Sullivan.
- WebKit/mac part of tracking the global history item for a WebView
- WebView/WebView.mm: (-[WebView _globalHistoryItem]): Added. Returns the page's global history item.
- WebView/WebViewPrivate.h:
WebKit/win:
Reviewed by John Sullivan.
- WebKit/win part of tracking the global history item for a WebView
- Interfaces/IWebViewPrivate.idl: Declared globalHistoryItem()
- WebView.cpp: (WebView::globalHistoryItem): Added. Gets the page's global history item.
- WebView.h:
- 11:28 AM Changeset in webkit [39099] by
-
- 2 edits in trunk/WebCore
2008-12-08 Antti Koivisto <Antti Koivisto>
Reviewed by Dave Kilzer.
A few stylistic fixes suggested by Dave Kilzer.
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::createIdentifier): (WebCore::CSSPrimitiveValue::create):
- 10:36 AM Changeset in webkit [39098] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22737
Try debug version when locating CFNetwork
- platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::findCFNetworkModule): (WebCore::findCFURLRequestSetContentDispositionEncodingFallbackArrayFunction): (WebCore::findCFURLRequestCopyContentDispositionEncodingFallbackArrayFunction):
- platform/network/win/CookieJarCFNetWin.cpp: (WebCore::findCFNetworkModule): (WebCore::findIsHTTPOnlyFunction):
- 10:13 AM Changeset in webkit [39097] by
-
- 14 edits in trunk
2008-12-08 Aaron Boodman <aa@chromium.org>
Reviewed by Stephanie Lewis.
https://bugs.webkit.org/show_bug.cgi?id=22301
Make dispatchDidFinishLoading() always fire before didFinishLoadForFrame().
- loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedParsing):
- 8:56 AM Changeset in webkit [39096] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-08 Simon Hausmann <simon.hausmann@nokia.com>
Fix the Linux build with newer gcc/glibc.
- jit/ExecutableAllocatorPosix.cpp: Include unistd.h for getpagesize(), according to http://opengroup.org/onlinepubs/007908775/xsh/getpagesize.html
- 8:53 AM Changeset in webkit [39095] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-08 Simon Hausmann <simon.hausmann@nokia.com>
Fix the build with Qt on Windows.
- JavaScriptCore.pri: Compile ExecutableAllocatorWin.cpp on Windows.
- 5:38 AM Changeset in webkit [39094] by
-
- 2 edits in trunk/WebCore
2008-12-08 Trenton Schulz <trenton.schulz@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
Fix build warning on Mac
- 2:42 AM Changeset in webkit [39093] by
-
- 2 edits in trunk/WebCore
Fix the Qt build
- 2:35 AM Changeset in webkit [39092] by
-
- 3 edits2 adds in trunk
Bug 22398: r39059: Crash when clearing webkitTransitionDuration in webkitTransitionEnd event handler
<rdar://problem/6426245> REGRESSION(r39059): Reproducible crash when clearing webkitTransitionDuration in webkitTransitionEnd event handler (22398)
Reviewed by Alexey Proskuryakov.
This regression was caused by r39059 replacing the protector on the active
animation with a protector on just the composition. It turns out that both
protectors are necessary.
Test: transitions/transition-duration-cleared-in-transitionend-crash.html
- 12:54 AM Changeset in webkit [39091] by
-
- 9 edits2 deletes in trunk/WebCore
2008-12-08 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=22732
Remove unused files PausedTimeouts.h,.cpp
The change that deprecated this code was https://bugs.webkit.org/show_bug.cgi?id=22620
- GNUmakefile.am:
- WebCore.pro:
- WebCore.scons:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl: These are build files which had PausedTimeouts referenced.
- bindings/js/PausedTimeouts.cpp: Removed.
- bindings/js/PausedTimeouts.h: Removed.
- bindings/js/ScriptController.cpp: Removed '#include'
- page/Chrome.cpp: Removed '#include' and unused variable.
Dec 7, 2008:
- 10:58 PM Changeset in webkit [39090] by
-
- 5 edits2 adds in trunk
2008-12-07 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
Fix issues which break reading inline style for -webkit-transition
and -webkit-transform-origin.
Test: fast/css/transform-inline-style.html
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue): Add cases for CSSPropertyWebkitTransformOrigin and CSSPropertyWebkitTransition so that these shorthand properties are returned correctly.
- css/CSSParser.cpp: (WebCore::CSSParser::parseAnimationProperty): Create CSSPrimitiveValues with the correct CSSValueAll and CSSValueNone identifiers, not the RenderStyle-level cAnimateAll, cAnimateNone.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::mapAnimationProperty): Special-case CSSValueAll and CSSValueNone values to set cAnimateAll and cAnimateNone transition properties.
- 8:16 PM Changeset in webkit [39089] by
-
- 2 edits in trunk/JavaScriptCore
Fix non-WREC builds
- 5:29 PM Changeset in webkit [39088] by
-
- 3 edits in trunk/WebCore
2008-12-07 Antti Koivisto <Antti Koivisto>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22717
Make CSS values use less memory
Share CSSPrimitiveValue objects for commonly used values including
- idents
- colors
- small integers
This reduces the amount CSSPrimitiveValue instances by > 80%.
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::createIdentifier): (WebCore::CSSPrimitiveValue::createColor): (WebCore::CSSPrimitiveValue::create):
- css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::create):
- 5:28 PM Changeset in webkit [39087] by
-
- 4 edits in trunk/JavaScriptCore
Put ENABLE(ASSEMBLER) guards around use of ExecutableAllocator in global data
Correct Qt and Gtk project files
- 5:27 PM Changeset in webkit [39086] by
-
- 8 edits in trunk/WebCore
2008-12-07 Antti Koivisto <Antti Koivisto>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22717
Make CSS values use less memory
Get CSSValues off from the common StyleBase base class. They don't
need a parent pointer or anything else there and there is no real
reason to have them in same data structures with other CSSOM objects.
Disabled (instead of refactoring around the lack of common base) the ability
to have style declaration blocks as CSS variable values. They don't exist in
the spec so I wasn't sure if they have future or not. It would not be hard to
get them back. CSS variables are in any case an experimental feature and
not enabled by default.
- css/CSSInitialValue.h: (WebCore::CSSInitialValue::createExplicit): (WebCore::CSSInitialValue::createImplicit):
- css/CSSParser.cpp: (WebCore::CSSParser::addVariableDeclarationBlock):
- css/CSSParser.h:
- css/CSSValue.h: (WebCore::CSSValue::~CSSValue): (WebCore::CSSValue::parserValue):
- css/CSSVariablesDeclaration.cpp: (WebCore::CSSVariablesDeclaration::CSSVariablesDeclaration): (WebCore::CSSVariablesDeclaration::getVariableValue): (WebCore::CSSVariablesDeclaration::removeVariable): (WebCore::CSSVariablesDeclaration::addParsedVariable): (WebCore::CSSVariablesDeclaration::getParsedVariable): (WebCore::CSSVariablesDeclaration::getParsedVariableDeclarationBlock):
- css/CSSVariablesDeclaration.h: (WebCore::CSSVariablesDeclaration::create):
- css/StyleBase.h:
- 4:39 PM Changeset in webkit [39085] by
-
- 3 edits in trunk/JavaScriptCore
Add new files to other projects.
Reviewed by NOBODY (Build fix).
- 4:35 PM Changeset in webkit [39084] by
-
- 2 edits1 move in trunk/JavaScriptCore
Rename ExecutableAllocatorMMAP to the more sensible ExecutableAllocatorPosix
Rubber stamped by Mark Rowe.
- 3:55 PM Changeset in webkit [39083] by
-
- 27 edits4 adds in trunk/JavaScriptCore
<rdar://problem/6309878> Need more granular control over allocation of executable memory (21783)
<https://bugs.webkit.org/show_bug.cgi?id=21783>
Reviewed by Cameron Zwarich and Sam Weinig
Add a new allocator for use by the JIT that provides executable pages, so
we can get rid of the current hack that makes the entire heap executable.
1-2% progression on SunSpider-v8, 1% on SunSpider. Reduces memory usage as well!
- 11:16 AM Changeset in webkit [39082] by
-
- 3 edits2 adds in trunk
[Gtk+] Use glib's unit test facilities to test the WebKit/Gtk+ API
Add the skeleton to WebKit/gtk/tests and integrate that into the
buildsystem. Testing support was added in glib 2.16. For versions
using glib < 2.16 we compile an empty application.
- 10:41 AM Changeset in webkit [39081] by
-
- 2 edits in trunk
[GTK] Define ENABLE_JIT_OPTIMIZE_CALL, ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS, ENABLE_JIT_OPTIMIZE_ARITHMETIC
When building the jit on i*86 also enable the above optimizations.
- 1:23 AM Changeset in webkit [39080] by
-
- 3 edits3 adds in trunk
2008-12-07 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
WebCore:
Add gradient and pattern support for strokeRect on canvas/Cg.
Canvas strokeRect() doesn't support gradients
https://bugs.webkit.org/show_bug.cgi?id=19790
Test: fast/canvas/canvas-strokeRect.html
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::strokeRect):
LayoutTests:
Tests strokeRect with patterns and gradients.
- fast/canvas/canvas-strokeRect-expected.txt: Added.
- fast/canvas/canvas-strokeRect.html: Added.
- fast/canvas/resources/canvas-strokeRect.js: Added.
Dec 6, 2008:
- 11:48 PM Changeset in webkit [39079] by
-
- 9 edits3 adds in trunk
2008-12-06 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
WebCore:
Add support for setTransform() in canvas.
<canvas> lacks transform() and setTransform()
https://bugs.webkit.org/show_bug.cgi?id=16604
Test: fast/canvas/canvas-setTransform.html
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::State::State): (WebCore::CanvasRenderingContext2D::setStrokeStyle): (WebCore::CanvasRenderingContext2D::setFillStyle): (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::beginPath): (WebCore::CanvasRenderingContext2D::closePath): (WebCore::CanvasRenderingContext2D::moveTo): (WebCore::CanvasRenderingContext2D::lineTo): (WebCore::CanvasRenderingContext2D::quadraticCurveTo): (WebCore::CanvasRenderingContext2D::bezierCurveTo): (WebCore::CanvasRenderingContext2D::arcTo): (WebCore::CanvasRenderingContext2D::arc): (WebCore::CanvasRenderingContext2D::rect): (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::clip): (WebCore::CanvasRenderingContext2D::isPointInPath): (WebCore::CanvasRenderingContext2D::clearRect): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::strokeRect): (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::drawImageFromRect): (WebCore::CanvasRenderingContext2D::willDraw): (WebCore::CanvasRenderingContext2D::drawTextInternal):
- html/CanvasRenderingContext2D.h:
- html/CanvasRenderingContext2D.idl:
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::baseTransform):
- html/HTMLCanvasElement.h:
- platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::baseTransform):
LayoutTests:
Added tests for canvas's setTransform() and updated an existing one.
- fast/canvas/canvas-setTransform-expected.txt: Added.
- fast/canvas/canvas-setTransform.html: Added.
- fast/canvas/resources/canvas-setTransform.js: Added.
- fast/dom/Window/window-properties-expected.txt:
- 10:15 PM Changeset in webkit [39078] by
-
- 3 edits4 adds in trunk
2008-12-06 Simon Fraser <Simon Fraser>
Reviewed by Antti Koivisto, Dan Bernstein
Fix logic related to repainting when transform changes:
If an object has a layer, and the transform changes, then we need
to do a repaintIncludingDescendants(), not just a repaint.
Test: fast/repaint/transform-repaint-descendants.html
- rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange):
- 8:20 PM Changeset in webkit [39077] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-06 Sam Weinig <sam@webkit.org>
Fix the Gtk build.
- jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath):
- 6:05 PM Changeset in webkit [39076] by
-
- 2 edits in trunk/WebCore
2008-12-06 Antti Koivisto <Antti Koivisto>
Reviewed by Darin Adler.
Also copy m_implicit field. Darin wanted this change commited separately.
- css/CSSProperty.h: (WebCore::CSSProperty::operator=):
- 5:40 PM Changeset in webkit [39075] by
-
- 14 edits in trunk
WebCore:
2008-12-06 Antti Koivisto <Antti Koivisto>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22379
Make CSSOM use less memory
Use vector instead of a double linked list for properties in CSSMutableStyleDeclaration.
Taught setter functions to use existing slots to avoid memory moves, plus some
other optimizations.
- WebCore.xcodeproj/project.pbxproj:
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration): (WebCore::CSSMutableStyleDeclaration::operator=): (WebCore::CSSMutableStyleDeclaration::getPropertyCSSValue): (WebCore::CSSMutableStyleDeclaration::removeShorthandProperty): (WebCore::CSSMutableStyleDeclaration::removeProperty): (WebCore::CSSMutableStyleDeclaration::getPropertyPriority): (WebCore::CSSMutableStyleDeclaration::getPropertyShorthand): (WebCore::CSSMutableStyleDeclaration::isPropertyImplicit): (WebCore::CSSMutableStyleDeclaration::setProperty): (WebCore::CSSMutableStyleDeclaration::setPropertyInternal): (WebCore::CSSMutableStyleDeclaration::setStringProperty): (WebCore::CSSMutableStyleDeclaration::setImageProperty): (WebCore::CSSMutableStyleDeclaration::parseDeclaration): (WebCore::CSSMutableStyleDeclaration::addParsedProperties): (WebCore::CSSMutableStyleDeclaration::addParsedProperty): (WebCore::CSSMutableStyleDeclaration::setLengthProperty): (WebCore::CSSMutableStyleDeclaration::length): (WebCore::CSSMutableStyleDeclaration::item): (WebCore::CSSMutableStyleDeclaration::cssText): (WebCore::CSSMutableStyleDeclaration::setCssText): (WebCore::CSSMutableStyleDeclaration::merge): (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet): (WebCore::CSSMutableStyleDeclaration::copy): (WebCore::CSSMutableStyleDeclaration::findPropertyWithId):
- css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclarationConstIterator::operator*): (WebCore::CSSMutableStyleDeclarationConstIterator::operator->): (WebCore::CSSMutableStyleDeclarationConstIterator::operator!=): (WebCore::CSSMutableStyleDeclarationConstIterator::operator==): (WebCore::CSSMutableStyleDeclaration::create): (WebCore::CSSMutableStyleDeclaration::begin): (WebCore::CSSMutableStyleDeclaration::end): (WebCore::CSSMutableStyleDeclarationConstIterator::CSSMutableStyleDeclarationConstIterator): (WebCore::CSSMutableStyleDeclarationConstIterator::~CSSMutableStyleDeclarationConstIterator): (WebCore::CSSMutableStyleDeclarationConstIterator::operator=): (WebCore::CSSMutableStyleDeclarationConstIterator::operator++): (WebCore::CSSMutableStyleDeclarationConstIterator::operator--):
- css/CSSProperty.h: (WTF::):
- css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::diff): (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::resolveVariablesForDeclaration): (WebCore::CSSStyleSelector::keyframeStylesForAnimation): (WebCore::CSSStyleSelector::applyDeclarations):
- dom/EventTarget.h:
- editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): (WebCore::ApplyStyleCommand::isHTMLStyleNode): (WebCore::ApplyStyleCommand::removeHTMLFontStyle): (WebCore::ApplyStyleCommand::removeCSSStyle):
- editing/Editor.cpp: (WebCore::Editor::selectionStartHasStyle): (WebCore::updateState):
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::handleStyleSpans):
- editing/markup.cpp: (WebCore::appendStartMarkup):
LayoutTests:
2008-12-06 Antti Koivisto <Antti Koivisto>
Reusing property slots changed property ordering in this text.
- editing/pasteboard/5780697-2-expected.txt:
- 5:07 PM Changeset in webkit [39074] by
-
- 3 edits in trunk/LayoutTests
2008-12-06 Simon Fraser <Simon Fraser>
Update expected image now that the caret renders in transformed
content.
- platform/mac/fast/forms/search-transformed-expected.checksum:
- platform/mac/fast/forms/search-transformed-expected.png:
- 5:03 PM Changeset in webkit [39073] by
-
- 3 edits4 adds in trunk
2008-12-06 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
When painting the selection on a replaced element, paint
using local coordinates so that the selection is correctly
painted for transformed elements.
Test: fast/replaced/selection-rect-transform.html
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
- 2:31 PM Changeset in webkit [39072] by
-
- 3 edits in trunk/JavaScriptCore
2008-12-06 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich,
Move CodeBlock constructor into the .cpp file.
Sunspider reports a .7% progression, but I can only assume this
is noise.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h:
- 2:19 PM Changeset in webkit [39071] by
-
- 8 edits2 copies in trunk/JavaScriptCore
2008-12-06 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Split JumpTable code into its own file.
- GNUmakefile.am:
- JavaScriptCore.pri:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- JavaScriptCoreSources.bkl:
- bytecode/CodeBlock.cpp:
- bytecode/CodeBlock.h:
- bytecode/JumpTable.cpp: Copied from bytecode/CodeBlock.cpp.
- bytecode/JumpTable.h: Copied from bytecode/CodeBlock.h.
- 2:01 PM Changeset in webkit [39070] by
-
- 19 edits in trunk/JavaScriptCore
2008-12-05 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Fix for https://bugs.webkit.org/show_bug.cgi?id=22715
Encapsulate more CodeBlock members in preparation
of moving some of them to a rare data structure.
- bytecode/CodeBlock.cpp: (JSC::locationForOffset): (JSC::printConditionalJump): (JSC::printGetByIdOp): (JSC::printPutByIdOp): (JSC::CodeBlock::printStructure): (JSC::CodeBlock::printStructures): (JSC::CodeBlock::dump): (JSC::CodeBlock::~CodeBlock): (JSC::CodeBlock::unlinkCallers): (JSC::CodeBlock::derefStructures): (JSC::CodeBlock::refStructures): (JSC::CodeBlock::mark): (JSC::CodeBlock::getHandlerForVPC): (JSC::CodeBlock::nativeExceptionCodeForHandlerVPC): (JSC::CodeBlock::lineNumberForVPC): (JSC::CodeBlock::expressionRangeForVPC): (JSC::CodeBlock::shrinkToFit):
- bytecode/CodeBlock.h: (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::addCaller): (JSC::CodeBlock::removeCaller): (JSC::CodeBlock::isKnownNotImmediate): (JSC::CodeBlock::isConstantRegisterIndex): (JSC::CodeBlock::getConstant): (JSC::CodeBlock::isTemporaryRegisterIndex): (JSC::CodeBlock::getStubInfo): (JSC::CodeBlock::getCallLinkInfo): (JSC::CodeBlock::instructions): (JSC::CodeBlock::setJITCode): (JSC::CodeBlock::jitCode): (JSC::CodeBlock::ownerNode): (JSC::CodeBlock::setGlobalData): (JSC::CodeBlock::setThisRegister): (JSC::CodeBlock::thisRegister): (JSC::CodeBlock::setNeedsFullScopeChain): (JSC::CodeBlock::needsFullScopeChain): (JSC::CodeBlock::setUsesEval): (JSC::CodeBlock::usesEval): (JSC::CodeBlock::setUsesArguments): (JSC::CodeBlock::usesArguments): (JSC::CodeBlock::codeType): (JSC::CodeBlock::source): (JSC::CodeBlock::sourceOffset): (JSC::CodeBlock::addGlobalResolveInstruction): (JSC::CodeBlock::numberOfPropertyAccessInstructions): (JSC::CodeBlock::addPropertyAccessInstruction): (JSC::CodeBlock::propertyAccessInstruction): (JSC::CodeBlock::numberOfCallLinkInfos): (JSC::CodeBlock::addCallLinkInfo): (JSC::CodeBlock::callLinkInfo): (JSC::CodeBlock::numberOfJumpTargets): (JSC::CodeBlock::addJumpTarget): (JSC::CodeBlock::jumpTarget): (JSC::CodeBlock::lastJumpTarget): (JSC::CodeBlock::numberOfExceptionHandlers): (JSC::CodeBlock::addExceptionHandler): (JSC::CodeBlock::exceptionHandler): (JSC::CodeBlock::addExpressionInfo): (JSC::CodeBlock::numberOfLineInfos): (JSC::CodeBlock::addLineInfo): (JSC::CodeBlock::lastLineInfo): (JSC::CodeBlock::jitReturnAddressVPCMap): (JSC::CodeBlock::numberOfIdentifiers): (JSC::CodeBlock::addIdentifier): (JSC::CodeBlock::identifier): (JSC::CodeBlock::numberOfConstantRegisters): (JSC::CodeBlock::addConstantRegister): (JSC::CodeBlock::constantRegister): (JSC::CodeBlock::addFunction): (JSC::CodeBlock::function): (JSC::CodeBlock::addFunctionExpression): (JSC::CodeBlock::functionExpression): (JSC::CodeBlock::addUnexpectedConstant): (JSC::CodeBlock::unexpectedConstant): (JSC::CodeBlock::addRegExp): (JSC::CodeBlock::regexp): (JSC::CodeBlock::symbolTable): (JSC::CodeBlock::evalCodeCache): New inline setters/getters.
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::ProgramCodeBlock::~ProgramCodeBlock):
(JSC::ProgramCodeBlock::clearGlobalObject):
- bytecode/SamplingTool.cpp: (JSC::ScopeSampleRecord::sample): (JSC::SamplingTool::dump):
- bytecompiler/BytecodeGenerator.cpp:
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/Label.h:
- interpreter/CallFrame.cpp:
- interpreter/Interpreter.cpp:
- jit/JIT.cpp:
- jit/JITCall.cpp:
- jit/JITInlineMethods.h:
- jit/JITPropertyAccess.cpp:
- parser/Nodes.cpp:
- runtime/Arguments.h:
- runtime/ExceptionHelpers.cpp:
- runtime/JSActivation.cpp:
- runtime/JSActivation.h:
- runtime/JSGlobalObject.cpp: Change direct access to use new getter/setters.
- 11:58 AM Changeset in webkit [39069] by
-
- 37 edits4 adds in trunk
2008-12-06 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Fix caret rendering to behave correctly with transforms:
- Rename caretRect() methods to localCaretRect() and absoluteCaretBounds() as appropriate
- Fix localCaretRect() methods to return a rect in the appropriate coordinates.
- Pass tx, ty down through the paintCaret() methods, after fixing them up to account for differences between contents coords, and renderer-local coords (via RenderBlock::offsetForContents()).
- Remove m_caretPositionOnLayout from SelectionController, and instead call invalidateSelection() from RenderLayer::scrollToOffset(), because we can no longer assume simple x/y offsets from scrolling with transforms.
- Move the logic to compute which RenderObject actually paints the caret into SelectionController::caretRenderer(), rather than having it in RenderBlock.
- SelectionController now computes and caches a local caret rect. For invalidation, it computes the absolute bounds of that (possibly transformed) local rect. The local rect is computed in the coordinate system of the RenderObject that will paint the caret (this may require offsetting from the actual renderer at the start of the selection).
- Fix LayoutState(RenderObject* root) to take transforms into account
- Make offsetFromContainer() a virtual method on RenderObject, and implement the RenderObject version. It's used to map from selection start renderer to caret renderer.
Test: fast/transforms/transformed-caret.html
- 9:20 AM Changeset in webkit [39068] by
-
- 1 edit in trunk/WebCore/ChangeLog
Added reference to bugs.webkit.org bug.
- 9:15 AM Changeset in webkit [39067] by
-
- 2 edits in trunk/WebCore
BUILD FIX for r39065: Forgot parentheses after "document".
Bug 22666: Clean up data structures used when collecting URLs of subresources for webarchives
<https://bugs.webkit.org/show_bug.cgi?id=22666>
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::addSubresourceAttributeURLs): Changed document to document().
- 8:04 AM Changeset in webkit [39066] by
-
- 2 edits in trunk/WebCore
2008-12-06 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=22710
Memory leak due to circular reference Document->DOMTimer->ScheduledAction->[JS objects]->Document
- bindings/js/DOMTimer.cpp: (WebCore::DOMTimer::stop): Delete ScheduledAction, which contains a protected object.
- 3:54 AM Changeset in webkit [39065] by
-
- 43 edits in trunk
Bug 22666: Clean up data structures used when collecting URLs of subresources for webarchives
Reviewed by Darin Adler.
WebCore:
When creating a webarchive from WebCore::LegacyWebArchive::create(),
HashSet<String>, Vector<KURL> and Vector<String> were all used to
store a list of URLs for resources found in the document. Instead
use a single ListHashSet<KURL> to store the list and resolve the
relative URLs as they're added. We use a new inline method called
WebCore::addSubresourceURL() to add KURL objects to the ListHashSet
to prevent "null" KURL objects from crashing in the KURL hashing
function.
- WebCore.base.exp: Changed export of WebCore::Node::getSubresourceURLs() to take a ListHashSet<KURL> argument instead of a Vector<KURL>.
- WebCore.xcodeproj/project.pbxproj: Marked KURLHash.h as a private header for use in WebKit.
- css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Renamed from addSubresourceURLStrings(). Changed to use ListHashSet<KURL> instead of HashSet<String>. Cleaned up code.
- css/CSSStyleSheet.h: (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Ditto.
- css/StyleSheet.h: (WebCore::StyleSheet::addSubresourceStyleURLs): Ditto.
- dom/Node.cpp: (WebCore::Node::getSubresourceURLs): Changed to use ListHashSet<KURL> instead of Vector<KURL>. Cleaned up code.
- dom/Node.h: (WebCore::Node::getSubresourceURLs): Ditto. (WebCore::Node::addSubresourceAttributeURLs): Renamed from getSubresourceAttributeStrings(). Changed to use ListHashSet<KURL> instead of Vector<String>. (WebCore::addSubresourceURL): Added. Safely adds new KURL objects to a ListHashSet<KURL> object. A "null" KURL object will cause the hash function to crash since it contains a null StringImpl. Used in Node::addSubresourceAttributeURLs() and addSubresourceStyleURLs() in the style subsystem.
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::addSubresourceAttributeURLs): Renamed from getSubresourceAttributeStrings(). Changed to use ListHashSet<KURL> instead of Vector<String>. Use WebCore::addSubresourceURL() to add new KURL objects.
- dom/ProcessingInstruction.h: Ditto.
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLBodyElement.h: Ditto.
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLEmbedElement.h: Ditto.
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLImageElement.h: Ditto.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLInputElement.h: Ditto.
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLLinkElement.h: Ditto.
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLObjectElement.h: Ditto.
- html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLParamElement.h: Ditto.
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLScriptElement.h: Ditto.
- html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLStyleElement.h: Ditto.
- html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLTableCellElement.h: Ditto.
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLTableElement.h: Ditto.
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Changed from using HashSet<String> to ListHashSet<KURL> for tracking unique subresources. Changed from using Vector<KURL> to ListHashSet<KURL> when calling WebCore::Node::getSubresourceURLs(). Cleaned up code.
- svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::addSubresourceAttributeURLs): Renamed from getSubresourceAttributeStrings(). Changed to use ListHashSet<KURL> instead of Vector<String>. Use WebCore::addSubresourceURL() to add new KURL objects.
- svg/SVGCursorElement.h: Ditto.
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::addSubresourceAttributeURLs): Ditto.
- svg/SVGFEImageElement.h: Ditto.
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::addSubresourceAttributeURLs): Ditto.
- svg/SVGImageElement.h: Ditto.
- svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::addSubresourceAttributeURLs): Ditto.
- svg/SVGScriptElement.h: Ditto.
WebKit/mac:
- DOM/WebDOMOperations.mm: (-[DOMNode _subresourceURLs]): Changed from using Vector<KURL> to ListHashSet<KURL> when calling WebCore::Node::getSubresourceURLs().
- 3:51 AM Changeset in webkit [39064] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fixed ChangeLog date.
Dec 5, 2008:
- 9:00 PM Changeset in webkit [39063] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Mis-commit in ChangeLog entry
- 8:57 PM Changeset in webkit [39062] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Please don't die in a fire while trying to compile Interpreter.cpp on GCC 4.2.
Added "-fno-var-tracking" compiler flag.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 7:25 PM Changeset in webkit [39061] by
-
- 4 edits in trunk/JavaScriptCore
2008-12-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Ordering of branch operands in MacroAssembler in unnecessarily inconsistent.
je, jg etc take an immediate operand as the second argument, but for the
equality branches (je, jne) the immediate operand was the first argument. This
was unnecessarily inconsistent. Change je, jne methods to take the immediate
as the second argument.
- assembler/MacroAssembler.h: (JSC::MacroAssembler::je32): (JSC::MacroAssembler::jne32):
- jit/JIT.cpp: (JSC::JIT::compileOpStrictEq):
- wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter): (JSC::WREC::Generator::generateNonGreedyQuantifier): (JSC::WREC::Generator::generateGreedyQuantifier): (JSC::WREC::Generator::generatePatternCharacterPair): (JSC::WREC::Generator::generatePatternCharacter): (JSC::WREC::Generator::generateCharacterClassInvertedRange): (JSC::WREC::Generator::generateCharacterClassInverted): (JSC::WREC::Generator::generateAssertionBOL): (JSC::WREC::Generator::generateAssertionWordBoundary):
- 6:27 PM Changeset in webkit [39060] by
-
- 4 edits in trunk/WebCore
Reviewed by Darin Adler.
Make the page group use the proper link hashing functions rather than
calling the string hash functions directly. Add Chromium-specfic ifdefs
in the visited link computation functions to allow integration.
- page/PageGroup.cpp:
(WebCore::PageGroup::isLinkVisited):
(WebCore::PageGroup::addVisitedLink):
- platform/LinkHash.cpp:
(WebCore::visitedLinkHash):
- platform/LinkHash.h:
- 5:42 PM Changeset in webkit [39059] by
-
- 6 edits4 adds in trunk
2008-12-05 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=22635
For iteration and end events, previous fixes to prevent the deletion of
Animation objects (ref counting and hanging onto a ref during event callbacks)
was sufficient to prevent dangling pointers. But start events are sent in
the styleAvailable() call, which iterates over CompositeAnimation objects,
which are not ref counted. So that object can get destroyed in the event
handler while still active. So I added refcounting for CompositeAnimations.
Additionally, when am iterating over the CompositingAnimation list, it can
be deleted, which mutates the list. So I now make one pass over the list
building a vector of CompositeAnimation objects that need to be called and
then iterate over that vector to make the actual calls.
Finally, to make sure the lifetime of the CompositeAnimation exceeds that of
the Animation objects it owns, I now keep a ref to the CompositeAnimation
in the timer callback for the iteration and end events. That means I no
longer need to keep a ref to the Animation objects themselves in that timer
callback, since the CompositeAnimation already has one.
Tests: animations/animation-iteration-event-destroy-renderer.html
animations/animation-start-event-destroy-renderer.html
- 5:36 PM Changeset in webkit [39058] by
-
- 5 edits in trunk/JavaScriptCore
2008-12-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Second tranche of porting JIT.cpp to MacroAssembler interface.
- assembler/MacroAssembler.h: (JSC::MacroAssembler::mul32): (JSC::MacroAssembler::jl32): (JSC::MacroAssembler::jnzSub32): (JSC::MacroAssembler::joAdd32): (JSC::MacroAssembler::joMul32): (JSC::MacroAssembler::jzSub32):
- jit/JIT.cpp: (JSC::JIT::emitSlowScriptCheck): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::emitJumpIfNotJSCell): (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
- 5:07 PM Changeset in webkit [39057] by
-
- 2 edits in trunk
Added bugs.webkit.org URL to ChangeLog entry.
- 5:05 PM Changeset in webkit [39056] by
-
- 7 edits in trunk
<rdar://problem/6331749> Provide a mechanism to disable perfect hashing in the DOM at build time
Reviewed by Darin Adler.
Initial patch by Yosen Lin. Adapted for ToT WebKit by David Kilzer.
Added back the code that generates a "compact" hash (instead of a
perfect hash) as a build-time option using the
ENABLE(PERFECT_HASH_SIZE) macro as defined in Lookup.h.
- create_hash_table: Rename variables to differentiate perfect hash values from compact hash values. Added back code to compute compact hash tables. Generate both hash table sizes and emit conditionalized code based on ENABLE(PERFECT_HASH_SIZE).
- runtime/Lookup.cpp: (JSC::HashTable::createTable): Added version of createTable() for use with compact hash tables. (JSC::HashTable::deleteTable): Updated to work with compact hash tables.
- runtime/Lookup.h: Defined ENABLE(PERFECT_HASH_SIZE) macro here. (JSC::HashEntry::initialize): Set m_next to zero when using compact hash tables. (JSC::HashEntry::setNext): Added for compact hash tables. (JSC::HashEntry::next): Added for compact hash tables. (JSC::HashTable::entry): Added version of entry() for use with compact hash tables.
- runtime/Structure.cpp: (JSC::Structure::getEnumerablePropertyNames): Updated to work with compact hash tables.
WebCore:
- bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): Compute the number of elements that will be stored in each hash table and pass it to GenerateHashTable(). (GenerateHashTable): Added new second parameter representing the number of elements to store in the compact hash table. Added back code to compute compact hash tables. Generate both hash table sizes and emit conditionalized code based on ENABLE(PERFECT_HASH_SIZE).
- 4:52 PM Changeset in webkit [39055] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Remove redundant calls to JIT::emitSlowScriptCheck.
This is checked in the hot path, so is not needed on the slow path - and the code
was being planted before the start of the slow case, so was completely unreachable!
- jit/JIT.cpp: (JSC::JIT::privateCompileSlowCases):
- 4:02 PM Changeset in webkit [39054] by
-
- 1 edit2 adds in trunk/LayoutTests
2008-12-05 Pamela Greene <pam@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22608
Add a test for line numbers of uncaught JS exceptions.
- fast/js/uncaught-exception-line-number-expected.txt: Added.
- fast/js/uncaught-exception-line-number.html: Added.
- 3:57 PM Changeset in webkit [39053] by
-
- 4 edits in trunk/JavaScriptCore
2008-12-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Move JIT::compileOpStrictEq to MacroAssembler interface.
The rewrite also looks like a small (<1%) performance progression.
- jit/JIT.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::emitJumpIfJSCell): (JSC::JIT::emitJumpSlowCaseIfJSCell):
- 3:56 PM Changeset in webkit [39052] by
-
- 1 edit2 adds in trunk/LayoutTests
2008-12-05 Pamela Greene <pam@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22604
Add test for onload handler named 'onload'.
- fast/events/onload-name-collision-expected.txt: Added.
- fast/events/onload-name-collision.html: Added.
- 3:53 PM Changeset in webkit [39051] by
-
- 1 edit4 adds in trunk/LayoutTests
2008-12-05 Pamela Greene <pam@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22601
Add test to verify that calling functions on a Java applet from JS works.
- fast/dom/java-applet-calls-expected.txt: Added.
- fast/dom/java-applet-calls.html: Added.
- fast/dom/resources/TestApplet.class: Added.
- fast/dom/resources/TestApplet.java: Added. (TestApplet): Source of test applet for use by layout test(s). (TestApplet.init): (TestApplet.setString): (TestApplet.getString):
- 3:48 PM Changeset in webkit [39050] by
-
- 1 edit2 adds in trunk/LayoutTests
2008-12-05 Pamela Greene <pam@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22592
Make sure the onload handler is only called once, even when there are
multiple <body> nodes in the document.
- fast/events/onload-fires-twice-expected.txt: Added.
- fast/events/onload-fires-twice.html: Added.
- 3:25 PM Changeset in webkit [39049] by
-
- 1 edit2 adds in trunk/LayoutTests
2008-12-05 Pamela Greene <pam@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22575
Add a test for accessing NodeList items by name.
- fast/dom/NodeList/nodelist-item-with-name-expected.txt: Added.
- fast/dom/NodeList/nodelist-item-with-name.html: Added.
- 3:22 PM Changeset in webkit [39048] by
-
- 2 edits in trunk/WebCore
Merge branch 'ownptr' into ownptr_commit
- 3:19 PM Changeset in webkit [39047] by
-
- 1 edit2 adds in trunk/LayoutTests
2008-12-05 Pamela Greene <pam@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=22632
Add a test for DOM operations with incompatible receivers or arguments.
- fast/dom/incompatible-operations-expected.txt: Added.
- fast/dom/incompatible-operations.html: Added.
- 3:13 PM Changeset in webkit [39046] by
-
- 2 edits in trunk/WebCore
Reviewed by Eric Seidel.
Add a missing include for OwnPtr to make CSSSelector compile without
precompiled headers.
- css/CSSSelector.h:
- 2:53 PM Changeset in webkit [39045] by
-
- 2 edits in trunk/WebKitTools
Bug 22555: Sort "children" sections in Xcode project files
Reviewed by Darin Adler.
Sort "children" sections alphabetically, moving groups (folders) to
the top of each of the lists. Files are assumed to have extensions,
so %isFile is used to override this behavior.
- Scripts/sort-Xcode-project-file: (sortChildrenByFileName): Added. (sortFilesByFileName): Renamed from sortByFileName().
- 2:15 PM Changeset in webkit [39044] by
-
- 5 edits in trunk/WebKitTools
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=22683
Fix gtk and qt builds which depend on --qt and --gtk being removed from ARGV
Add a new argumentsForConfiguration() function and clean up some old code to use it.
Rename checkArgV to checkForArgumentAndRemoveFromARGV to be more self-documenting.
- Scripts/run-javascriptcore-tests:
- Scripts/run-launcher:
- Scripts/run-webkit-tests:
- Scripts/webkitdirs.pm:
- 2:14 PM Changeset in webkit [39043] by
-
- 5 edits in trunk/JavaScriptCore
2008-12-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Remove m_assembler from MacroAssembler::Jump.
Keeping a pointer allowed for some syntactic sugar - "link()" looks nicer
than "link(this)". But maintaining this doubles the size of Jump, which
is even more unfortunate for the JIT, since there are many large structures
holding JmpSrcs. Probably best to remove it.
- assembler/MacroAssembler.h: (JSC::MacroAssembler::Jump::Jump): (JSC::MacroAssembler::Jump::link): (JSC::MacroAssembler::Jump::linkTo): (JSC::MacroAssembler::JumpList::link): (JSC::MacroAssembler::JumpList::linkTo): (JSC::MacroAssembler::jae32): (JSC::MacroAssembler::je32): (JSC::MacroAssembler::je16): (JSC::MacroAssembler::jg32): (JSC::MacroAssembler::jge32): (JSC::MacroAssembler::jl32): (JSC::MacroAssembler::jle32): (JSC::MacroAssembler::jnePtr): (JSC::MacroAssembler::jne32): (JSC::MacroAssembler::jnset32): (JSC::MacroAssembler::jset32): (JSC::MacroAssembler::jump): (JSC::MacroAssembler::jzSub32): (JSC::MacroAssembler::joAdd32): (JSC::MacroAssembler::call):
- wrec/WREC.cpp: (JSC::WREC::Generator::compileRegExp):
- wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter): (JSC::WREC::Generator::generateBackreferenceQuantifier): (JSC::WREC::Generator::generateNonGreedyQuantifier): (JSC::WREC::Generator::generateGreedyQuantifier): (JSC::WREC::Generator::generatePatternCharacter): (JSC::WREC::Generator::generateCharacterClassInvertedRange): (JSC::WREC::Generator::generateCharacterClassInverted): (JSC::WREC::Generator::generateCharacterClass): (JSC::WREC::Generator::generateParenthesesAssertion): (JSC::WREC::Generator::generateParenthesesInvertedAssertion): (JSC::WREC::Generator::generateParenthesesNonGreedy): (JSC::WREC::Generator::generateParenthesesResetTrampoline): (JSC::WREC::Generator::generateAssertionBOL): (JSC::WREC::Generator::generateAssertionEOL): (JSC::WREC::Generator::generateAssertionWordBoundary): (JSC::WREC::Generator::generateBackreference): (JSC::WREC::Generator::terminateAlternative): (JSC::WREC::Generator::terminateDisjunction):
- wrec/WRECParser.h:
- 2:10 PM Changeset in webkit [39042] by
-
- 4 edits in trunk/WebCore
2008-12-05 Finnur Thorarinsson <finnur.webkit@gmail.com>
Reviewed by Darin Adler.
Bug 22579: Providing a function to ScrollbarClient.h which allows us to get at the tickmarks
without relying on high-level WebCore types, as requested by Dave Hyatt.
No functional changes, thus no test cases.
- page/FrameView.cpp: (WebCore::FrameView::getTickmarks):
- page/FrameView.h:
- platform/ScrollbarClient.h:
- 1:54 PM Changeset in webkit [39041] by
-
- 4 edits in trunk/LayoutTests
2008-12-05 Justin Garcia <justin.garcia@apple.com>
Updating these test results. On Tiger the fragment created from RTFD data
contained interchange newlines that we incorrectly handled before r38983.
- platform/mac-tiger/editing/pasteboard/paste-RTFD-expected.checksum:
- platform/mac-tiger/editing/pasteboard/paste-RTFD-expected.png:
- platform/mac-tiger/editing/pasteboard/paste-RTFD-expected.txt:
- 12:56 PM Changeset in webkit [39040] by
-
- 1 edit3 adds in trunk/LayoutTests
2008-12-05 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added a test for a bug I discovered while working on
https://bugs.webkit.org/show_bug.cgi?id=22685.
- fast/regex/non-capturing-backtracking-expected.txt: Added.
- fast/regex/non-capturing-backtracking.html: Added.
- fast/regex/resources/non-capturing-backtracking.js: Added.
- 12:39 PM Changeset in webkit [39039] by
-
- 4 edits in trunk/JavaScriptCore
2008-12-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoffrey Garen.
Simplify JIT generated checks for timeout code, by moving more work into the C function.
https://bugs.webkit.org/show_bug.cgi?id=22688
- interpreter/Interpreter.cpp: (JSC::Interpreter::cti_timeout_check):
- interpreter/Interpreter.h:
- jit/JIT.cpp: (JSC::JIT::emitSlowScriptCheck):
- 12:27 PM Changeset in webkit [39038] by
-
- 6 edits in trunk/JavaScriptCore
2008-12-05 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Encapsulate access to jump tables in the CodeBlock in preparation
of moving them to a rare data structure.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::shrinkToFit):
- bytecode/CodeBlock.h: (JSC::CodeBlock::numberOfImmediateSwitchJumpTables): (JSC::CodeBlock::addImmediateSwitchJumpTable): (JSC::CodeBlock::immediateSwitchJumpTable): (JSC::CodeBlock::numberOfCharacterSwitchJumpTables): (JSC::CodeBlock::addCharacterSwitchJumpTable): (JSC::CodeBlock::characterSwitchJumpTable): (JSC::CodeBlock::numberOfStringSwitchJumpTables): (JSC::CodeBlock::addStringSwitchJumpTable): (JSC::CodeBlock::stringSwitchJumpTable):
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::generate): (JSC::BytecodeGenerator::endSwitch):
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): (JSC::Interpreter::cti_op_switch_imm): (JSC::Interpreter::cti_op_switch_char): (JSC::Interpreter::cti_op_switch_string):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- 11:00 AM Changeset in webkit [39037] by
-
- 4 edits in trunk
2008-12-05 Dean Jackson <dino@apple.com>
Reviewed by David Hyatt.
WebCore:
Make sure Window event listeners also tell the
Document about the event type, so noisy events
will be dispatched even if nothing in the document
is listening.
https://bugs.webkit.org/show_bug.cgi?id=20572
- dom/Document.cpp: (WebCore::Document::addWindowEventListener):
LayoutTests:
No longer need to add a fake listener on a document
node in order to get events passed up to Window.
https://bugs.webkit.org/show_bug.cgi?id=20572
- transitions/transition-end-event-window.html:
- 10:27 AM Changeset in webkit [39036] by
-
- 40 edits in trunk/LayoutTests
2008-12-05 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim Hatcher.
- Fix intermittent profiler test failures. The problem is that idle time only shows up some times, probably dependent on if the system is running a little slow or has a network hiccup. I've removed this.
- I've also added <rdar://problem/6422004> Profiler tests fail because they sometimes don't have (idle) time. This is to investigate whether or not idle time should be showing up at all when running these tests.
- fast/profiler/anonymous-event-handler-expected.txt:
- fast/profiler/anonymous-function-called-from-different-contexts-expected.txt:
- fast/profiler/anonymous-function-calls-built-in-functions-expected.txt:
- fast/profiler/anonymous-function-calls-eval-expected.txt:
- fast/profiler/apply-expected.txt:
- fast/profiler/built-in-function-calls-anonymous-expected.txt:
- fast/profiler/built-in-function-calls-user-defined-function-expected.txt:
- fast/profiler/call-expected.txt:
- fast/profiler/call-nodelist-as-function-expected.txt:
- fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope-expected.txt:
- fast/profiler/compare-multiple-profiles-expected.txt:
- fast/profiler/constructor-expected.txt:
- fast/profiler/dead-time-expected.txt:
- fast/profiler/document-dot-write-expected.txt:
- fast/profiler/event-handler-expected.txt:
- fast/profiler/execution-context-and-eval-on-same-line-expected.txt:
- fast/profiler/heavy-view-expected.txt:
- fast/profiler/inline-event-handler-expected.txt:
- fast/profiler/many-calls-in-the-same-scope-expected.txt:
- fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt:
- fast/profiler/multiple-and-different-scoped-function-calls-expected.txt:
- fast/profiler/multiple-frames-expected.txt:
- fast/profiler/nested-anonymous-functon-expected.txt:
- fast/profiler/nested-start-and-stop-profiler-expected.txt:
- fast/profiler/one-execution-context-expected.txt:
- fast/profiler/profile-calls-in-included-file-expected.txt:
- fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt:
- fast/profiler/profiling-from-a-nested-location-expected.txt:
- fast/profiler/resources/profiler-test-JS-resources.js: (printProfileNodeWithoutTime):
- fast/profiler/simple-event-call-expected.txt:
- fast/profiler/simple-no-level-change-expected.txt:
- fast/profiler/start-and-stop-profiler-multiple-times-expected.txt:
- fast/profiler/start-and-stop-profiling-in-the-same-function-expected.txt:
- fast/profiler/stop-profiling-after-setTimeout-expected.txt:
- fast/profiler/stop-then-function-call-expected.txt:
- fast/profiler/throw-exception-from-eval-expected.txt:
- fast/profiler/two-execution-contexts-expected.txt:
- fast/profiler/user-defined-function-calls-built-in-functions-expected.txt:
- fast/profiler/window-dot-eval-expected.txt:
- 10:03 AM Changeset in webkit [39035] by
-
- 2 edits in trunk/WebKit
Mac build fix.
- WebKit.xcodeproj/project.pbxproj:
- 9:23 AM Changeset in webkit [39034] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-05 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
Disable the JIT for the Qt build alltogether again, after observing
more miscompilations in a wider range of newer gcc versions.
- 9:22 AM Changeset in webkit [39033] by
-
- 2 edits in trunk/WebCore
Windows build fix after r39026
- platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest): Add some missing .get()s.
- 9:21 AM Changeset in webkit [39032] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix after r39020
- jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference): (JSC::JIT::restoreArgumentReferenceForTrampoline): Add some apparently-missing .
- 9:20 AM Changeset in webkit [39031] by
-
- 2 edits in trunk/WebKit
Mac build fix.
- WebKit.xcodeproj/project.pbxproj:
- 8:49 AM Changeset in webkit [39030] by
-
- 5 edits in trunk/JavaScriptCore
2008-12-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Added support for the assertion (?=) and inverted assertion (?!) atoms
in WREC.
- wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateParenthesesAssertion): (JSC::WREC::Generator::generateParenthesesInvertedAssertion): Split the old (unused) generateParentheses into these two functions, with more limited capabilities.
- wrec/WRECGenerator.h: (JSC::WREC::Generator::): Moved an enum to the top of the class definition, to match the WebKit style, and removed a defunct comment.
- wrec/WRECParser.cpp: (JSC::WREC::Parser::parseParentheses): (JSC::WREC::Parser::consumeParenthesesType):
- wrec/WRECParser.h: (JSC::WREC::Parser::): Added support for parsing (?=) and (?!).
- 8:33 AM Changeset in webkit [39029] by
-
- 2 edits in trunk/WebCore
Tiger build fix.
- platform/network/mac/ResourceRequestMac.mm: Define NSUInteger.
- 7:53 AM Changeset in webkit [39028] by
-
- 20 edits2 moves in trunk
Reviewed by Darin Adler.
<rdar://problem/6405599> Tiger Mail crashes when using "Mail Contents of This Page"
in Safari before opening a mail message in Mail
WebCore:
- platform/mac/WebCoreObjCExtras.mm: (WebCoreObjCFinalizeOnMainThread): Don't call initializeThreading: we now expect the caller to do it, to simplify keeping Tiger and post-Tiger behavior in line.
- bindings/objc/DOMRGBColor.mm: (+[DOMRGBColor initialize]):
- bindings/objc/WebScriptObject.mm: (+[WebScriptObject initialize]):
- page/mac/AccessibilityObjectWrapper.mm: (+[AccessibilityObjectWrapper initialize]):
- platform/mac/SharedBufferMac.mm: (+[WebCoreSharedBufferData initialize]): Call JSC::initializeThreading();
WebKit:
- Carbon/CarbonWindowAdapter.m: Removed.
- Carbon/CarbonWindowAdapter.mm: Copied from WebKit/mac/Carbon/CarbonWindowAdapter.m. (+[CarbonWindowAdapter initialize]):
- History/WebBackForwardList.mm: (+[WebBackForwardList initialize]):
- History/WebHistoryItem.mm: (+[WebHistoryItem initialize]):
- Misc/WebElementDictionary.mm: (+[WebElementDictionary initialize]):
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (+[WebHostedNetscapePluginView initialize]):
- Plugins/WebBaseNetscapePluginView.mm:
- Plugins/WebBasePluginPackage.m: Removed.
- Plugins/WebBasePluginPackage.mm: Copied from WebKit/mac/Plugins/WebBasePluginPackage.m. (+[WebBasePluginPackage initialize]):
- Plugins/WebNetscapePluginView.mm: (+[WebNetscapePluginView initialize]):
- WebCoreSupport/WebEditorClient.mm: (+[WebEditCommand initialize]):
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebView/WebArchive.mm: (+[WebArchivePrivate initialize]):
- WebView/WebDataSource.mm: (+[WebDataSourcePrivate initialize]):
- WebView/WebHTMLView.mm: (+[WebHTMLViewPrivate initialize]): (+[WebHTMLView initialize]):
- WebView/WebResource.mm: (+[WebResourcePrivate initialize]):
- WebView/WebView.mm: (+[WebViewPrivate initialize]): Call JSC::initializeThreading();
- 7:47 AM Changeset in webkit [39027] by
-
- 2 edits in trunk/WebKit/win
2008-12-05 Darin Adler <Darin Adler>
Reviewed by Alexey Proskuryakov.
- fix https://bugs.webkit.org/show_bug.cgi?id=22674 Webkit r39005 does not start, an entry point not found
- WebView.cpp: (findCFNetworkModule): Added. (findCopySharedURLCacheFunction): Added. (WebView::setCacheModel): Call CFURLCacheCopySharedURLCache via dynamic loading instead of compiling based on which version of CFNetwork headers are present.
- 6:43 AM Changeset in webkit [39026] by
-
- 6 edits in trunk/WebCore
Reviewed by Darin Adler.
<rdar://problem/4072827> Downloaded non-ASCII file name becomes garbled
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray):
- platform/network/ResourceRequestBase.h:
- platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::findCFURLRequestSetContentDispositionEncodingFallbackArrayFunction): (WebCore::findCFURLRequestCopyContentDispositionEncodingFallbackArrayFunction): (WebCore::setContentDispositionEncodingFallbackArray): (WebCore::copyContentDispositionEncodingFallbackArray): (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest):
- platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdateResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest): Added a way to specify encoding fallback list for Content-Disposition header.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest): Generate and pass a list of encodings to try when decoding Content-Disposition header, as described in comments.
- 6:23 AM Changeset in webkit [39025] by
-
- 6 edits2 adds3 deletes in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22672
ASSERT(m_table) when xhr.onabort creates another xhr or calls setTimeout
Test: http/tests/xmlhttprequest/send-on-abort.html
- dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects): (WebCore::ScriptExecutionContext::suspendActiveDOMObjects): (WebCore::ScriptExecutionContext::resumeActiveDOMObjects): (WebCore::ScriptExecutionContext::stopActiveDOMObjects): Add a comment explaining that ActiveDOMObject methods shouldn't execute arbitrary JS.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::stop): Don't dispatch events. This reverts a recent change that made the behavior slightly closer to Firefox - but the compatibility effect should be very minor if any, and Firefox itself behaves inconsistently.
- 5:02 AM Changeset in webkit [39024] by
-
- 2 edits in trunk/WebCore
2008-12-05 Tobias König <tobias.koenig@nokia.com>
Reviewed by Simon Hausmann.
Record required package dependencies for the Qt build for a correct
pkg-config file.
- 4:50 AM Changeset in webkit [39023] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-05 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Disable the JIT for the Qt build on Linux unless gcc is >= 4.2,
due to miscompilations.
- 3:27 AM Changeset in webkit [39022] by
-
- 2 edits in trunk/WebCore
2008-12-05 Tor Arne Vestbø <tavestbo@trolltech.com>
Rubber-stamped by Simon Hausmann.
[Qt/Mac] Blacklist QuickTime plugin until we support the QuickDraw drawing model
- 1:48 AM Changeset in webkit [39021] by
-
- 5 edits2 moves3 adds in trunk
2008-12-05 Jungshik Shin <jshin@chromium.org>
Reviewed by Alexey Proskuryakov.
Revises charset alias map for TextCodecICU.
- Uses windows-949 and windows-874 instead of windows-949-2000 and windows-874-2000
- Replaces 'windows874' in a couple of place with 'windows-874' (for the canonical name)
- Maps 'dos-874' to 'windows-874'. Currently, it's aliases to 'cp874', which is in turn mapped to 'TIS-620'. 'TIS-620' is manually aliased to 'windows-874'. We'd better directly alias 'dos-874' to 'windows-874'.
- Replaces 'EUC-CN' with 'GBK' when it's used as the canonical name. Similar to the above case, we're getting rid of indirection that eventually leads to 'GBK' by directly going to 'GBK'.
- Adds 'x-uhc' as an alias for 'windows-949'. It's used in some web pages.
Tests: fast/encoding/char-decoding-mac.html
fast/encoding/char-decoding.html
- platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames):
