Timeline
Dec 22, 2008:
- 11:08 PM Changeset in webkit [39450] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Fix rounding / bounds / signed comparison bug in ExecutableAllocator.
ExecutableAllocator::alloc assumed that m_freePtr would be aligned. This was
not always true, since the first allocation from an additional pool would not
be rounded up. Subsequent allocations would be unaligned, and too much memory
could be erroneously allocated from the pool, when the size requested was
available, but the size rounded up to word granularity was not available in the
pool. This may result in the value of m_freePtr being greater than m_end.
Under these circumstances, the unsigned check for space will always pass,
resulting in pointers to memory outside of the arena being returned, and
ultimately segfaulty goodness when attempting to memcpy the hot freshly jitted
code from the AssemblerBuffer.
https://bugs.webkit.org/show_bug.cgi?id=22974
... and probably many, many more.
- jit/ExecutableAllocator.h: (JSC::ExecutablePool::alloc): (JSC::ExecutablePool::roundUpAllocationSize): (JSC::ExecutablePool::ExecutablePool): (JSC::ExecutablePool::poolAllocate):
- 7:05 PM Changeset in webkit [39449] by
-
- 5 edits in trunk/WebCore
2008-12-22 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Save a word in all Elements by moving the 5 loose bits to Node,
where we had 16 spare.
- dom/Element.cpp: (WebCore::Element::Element):
- dom/Element.h:
- dom/Node.cpp: (WebCore::Node::Node):
- dom/Node.h:
- 6:14 PM Changeset in webkit [39448] by
-
- 6 edits2 adds in trunk/WebCore
Reviewed by George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22972
Add WML <meta> element support. All needed functionality is present
in Document::processHttpEquiv, already covered by tests.
- 5:55 PM Changeset in webkit [39447] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Darin Adler.
Don't reference specific layout tests in comments.
- 5:31 PM Changeset in webkit [39446] by
-
- 2 edits in trunk/WebCore
Reviewed by George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22965
Add WML <head> element support. Doesn't require a WMLHeadElement.
No functional behaviour, as we already created a WMLElement for headTag, by default.
It's just cleaner to list <head> in WMLTagNames, forwarding to a WMLElement constructor.
- 5:29 PM Changeset in webkit [39445] by
-
- 3 edits3 adds in trunk
Reviewed by George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22971
Fix regression caused by the HTMLFormElement refactorization.
File form elements without a name have to be included in multipart/form-data
submission. Cover this behaviour with a new test case.
- 5:06 PM Changeset in webkit [39444] by
-
- 2 edits in trunk/WebCore
<rdar://problem/6438298> Bump schema version for app cache
Reviewed by Alexey Proskuryakov.
- loader/appcache/ApplicationCacheStorage.cpp: Increment SchemaVersion from 2 to 3.
- 4:49 PM Changeset in webkit [39443] by
-
- 2 edits in trunk/WebCore
Use Deque in CSSStyleSheet::addSubresourceStyleURLs()
Reviewed by Darin Adler.
- css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Replaced use of ListHashSet with more efficient Deque.
- 4:25 PM Changeset in webkit [39442] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig.
Fix obvious crash fix for WML enabled builds.
- 4:00 PM Changeset in webkit [39441] by
-
- 46 edits16 adds in trunk
Bug 11850: Webarchive fails to save images referenced in CSS
Reviewed by Darin Adler.
WebCore:
This entry contains two parts since the tests for adding a
completeURL() method to StyleSheet and CSSStyleSheet (part 1) depend
on Bug 11850 being fixed (part 2).
--
Tests: http/tests/webarchive/test-css-url-encoding-shift-jis.html
http/tests/webarchive/test-css-url-encoding-utf-8.html
http/tests/webarchive/test-css-url-encoding.html
Added completeURL() methods to StyleSheet and CSSStyleSheet that
match the behavior of Document::completeURL(). Most notably,
CSSStyleSheet::completeURL() uses the charset of the stylesheet
(if it exists) to construct URLs, just like Document::completeURL().
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Use CSSStyleSheet::completeURL(). (WebCore::CSSParser::parseContent): Ditto. (WebCore::CSSParser::parseFillImage): Ditto. (WebCore::CSSParser::parseFontFaceSrc): Ditto. (WebCore::CSSParser::parseBorderImage): Ditto.
- css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::completeURL): Added.
- css/CSSStyleSheet.h: (WebCore::CSSStyleSheet::completeURL): Added declaration.
- css/StyleSheet.cpp: (WebCore::StyleSheet::completeURL): Added.
- css/StyleSheet.h: (WebCore::StyleSheet::completeURL): Added declaration.
- dom/Document.cpp: (WebCore::Document::completeURL): Added comment referring to the new completeURL() methods in StyleSheet and CSSStyleSheet.
--
Tests: webarchive/test-css-url-resources-in-stylesheets.html
webarchive/test-css-url-resources-inline-styles.html
Walk stylesheets and inline style attributes for url() references
when building a list of URLs to include in a webarchive. Note that
not all URLs found this way will be included in the webarchive if
they were not used (and thus not downloaded) when laying out the
page.
The key method for CSS stylesheets is
CSSStyleSheet::addSubresourceStyleURLs() which iterates over all
CSSStyleSheet objects recursively referenced from its own stylesheet
through @import rules. Starting with the CSSRule objects in each
sheet and continuing down through the CSSMutableStyleDeclaration and
CSSValue objects, addSubresourceStyleURLs() methods are called to
gather URLs.
For inline style attributes in HTML DOM elements,
StyledElement::addSubresourceAttributeURLs() calls
CSSMutableStyleDeclaration::addSubresourceStyleURLs() to gather URLs
from each element, hence the need to call
addSubresourceAttributeURLs() on superclasses when the method is
implemented on the element class itself.
- css/CSSBorderImageValue.cpp: (WebCore::CSSBorderImageValue::addSubresourceStyleURLs): Added.
- css/CSSBorderImageValue.h: (WebCore::CSSBorderImageValue::addSubresourceStyleURLs): Added declaration.
- css/CSSFontFaceRule.cpp: (WebCore::CSSFontFaceRule::addSubresourceStyleURLs): Added.
- css/CSSFontFaceRule.h: (WebCore::CSSFontFaceRule::addSubresourceStyleURLs): Added declaration.
- css/CSSFontFaceSrcValue.cpp: (WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs): Added.
- css/CSSFontFaceSrcValue.h: (WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs): Added declaration.
- css/CSSImportRule.cpp: (WebCore::CSSImportRule::addSubresourceStyleURLs): Added.
- css/CSSImportRule.h: (WebCore::CSSImportRule::addSubresourceStyleURLs): Added declaration.
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::addSubresourceStyleURLs): Added. Iterates over m_properties vector of CSSProperty objects calling addSubresourceStyleURLs() on each property's CSSValue object.
- css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::addSubresourceStyleURLs): Added declaration.
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::addSubresourceStyleURLs): Added.
- css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::addSubresourceStyleURLs): Added declaration.
- css/CSSReflectValue.cpp: (WebCore::CSSReflectValue::addSubresourceStyleURLs): Added.
- css/CSSReflectValue.h: (WebCore::CSSReflectValue::addSubresourceStyleURLs): Added declaration.
- css/CSSRule.h: (WebCore::CSSRule::addSubresourceStyleURLs): Added. Virtual method with empty implementation that's overridden by subclasses as needed.
- css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::addSubresourceStyleURLs): Added.
- css/CSSStyleRule.h: (WebCore::CSSStyleRule::addSubresourceStyleURLs): Added declaration.
- css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Updated to call CSSRule::addSubresourceStyleURLs on each rule to extract URLs. Removed unneeded baseURL parameter now that the completeURL() method exists.
- css/CSSStyleSheet.h: (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Updated declaration.
- css/CSSValue.h: (WebCore::CSSValue::addSubresourceStyleURLs): Added. Virtual method with empty implementation that's overridden by subclasses as needed.
- css/CSSValueList.cpp: (WebCore::CSSValueList::addSubresourceStyleURLs): Added. Iterates over m_values vector of CSSValue objects calling addSubresourceStyleURLs() on each.
- css/CSSValueList.h: (WebCore::CSSValueList::addSubresourceStyleURLs): Added declaration.
- css/StyleSheet.h: (WebCore::StyleSheet::addSubresourceStyleURLs): Updated declaration to remove unneeded baseURL parameter.
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::addSubresourceAttributeURLs): Fixed to use the StyleBase::baseURL() method to get the stylesheet's URL instead of calling Document::completeURL().
- dom/StyledElement.cpp: (WebCore::StyledElement::addSubresourceAttributeURLs): Added method to extract URLs from inline style declarations.
- dom/StyledElement.h: (WebCore::StyledElement::addSubresourceAttributeURLs): Added declaration.
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::addSubresourceAttributeURLs): Call addSubresourceAttributeURLs() in superclass to extract URLs from inline style declarations.
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::addSubresourceAttributeURLs): Ditto.
- svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::addSubresourceAttributeURLs): Ditto.
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::addSubresourceAttributeURLs): Ditto.
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::addSubresourceAttributeURLs): Ditto.
- svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::addSubresourceAttributeURLs): Ditto.
LayoutTests:
The first set of files below tests that URLs are encoded properly
based on the charset of the stylesheet. Normally this behavior may
only be tested by looking at web server logs with manual tests, but
webarchives represent this information in such a way that they may
be tested by DumpRenderTree. Note that these tests depend on Bug
11850 being fixed, so it's not possible to separate them.
The second set of files below tests that all types of resources
referenced by url() in CSS stylesheets are now saved in webarchives.
- http/tests/webarchive/resources/.htaccess: Added.
- http/tests/webarchive/resources/apple.gif: Copied from LayoutTests/fast/canvas/resources/apple.gif.
- http/tests/webarchive/resources/test-no-charset.css: Added.
- http/tests/webarchive/resources/test-shift-jis.css: Added.
- http/tests/webarchive/resources/test-utf-8.css: Added.
- http/tests/webarchive/test-css-url-encoding-expected.webarchive: Added.
- http/tests/webarchive/test-css-url-encoding-shift-jis-expected.webarchive: Added.
- http/tests/webarchive/test-css-url-encoding-shift-jis.html: Added.
- http/tests/webarchive/test-css-url-encoding-utf-8-expected.webarchive: Added.
- http/tests/webarchive/test-css-url-encoding-utf-8.html: Added.
- http/tests/webarchive/test-css-url-encoding.html: Added.
- webarchive/resources/Ahem.ttf: Copied from LayoutTests/fast/css/resources/Ahem.ttf.
- webarchive/test-css-url-resources-in-stylesheets-expected.webarchive: Added.
- webarchive/test-css-url-resources-in-stylesheets.html: Added.
- webarchive/test-css-url-resources-inline-styles-expected.webarchive: Added.
- webarchive/test-css-url-resources-inline-styles.html: Added.
- 1:21 PM Changeset in webkit [39440] by
-
- 8 edits in trunk/JavaScriptCore
2008-12-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Rename all uses of the term "repatch" to "patch".
- assembler/MacroAssembler.h: (JSC::MacroAssembler::DataLabelPtr::patch): (JSC::MacroAssembler::DataLabel32::patch): (JSC::MacroAssembler::Jump::patch): (JSC::MacroAssembler::PatchBuffer::PatchBuffer): (JSC::MacroAssembler::PatchBuffer::setPtr): (JSC::MacroAssembler::loadPtrWithAddressOffsetPatch): (JSC::MacroAssembler::storePtrWithAddressOffsetPatch): (JSC::MacroAssembler::storePtrWithPatch): (JSC::MacroAssembler::jnePtrWithPatch):
- assembler/X86Assembler.h: (JSC::X86Assembler::patchAddress): (JSC::X86Assembler::patchImmediate): (JSC::X86Assembler::patchPointer): (JSC::X86Assembler::patchBranchOffset):
- interpreter/Interpreter.cpp: (JSC::Interpreter::tryCTICachePutByID): (JSC::Interpreter::tryCTICacheGetByID): (JSC::Interpreter::cti_op_put_by_id): (JSC::Interpreter::cti_op_get_by_id): (JSC::Interpreter::cti_op_get_by_id_self_fail): (JSC::Interpreter::cti_op_get_by_id_proto_list): (JSC::Interpreter::cti_vm_dontLazyLinkCall):
- jit/JIT.cpp: (JSC::ctiPatchCallByReturnAddress): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JIT.h:
- jit/JITCall.cpp: (JSC::JIT::unlinkCall): (JSC::JIT::linkCall): (JSC::JIT::compileOpCall):
- jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdSlowCase): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace):
- 1:20 PM Changeset in webkit [39439] by
-
- 2 edits in trunk/WebCore
2008-12-22 Dhananjoy Chutia <dhanrd@gmail.com>
Reviewed by David Kilzer.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22959
Memory leak fixes for WebKit+soup
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::finishedCallback):
- 11:19 AM Changeset in webkit [39438] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Anders Carlsson.
<rdar://problem/6449588> REGRESSION (r38279-r38280): Minimize them remaximize a window with a flash plugin, plugin doesn't resume at full speed
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView windowDidDeminiaturize:]): Deminiaturizing should restart timers, not stop timers.
- 10:16 AM Changeset in webkit [39437] by
-
- 4 edits5 adds in trunk
Reviewed by Darin Adler.
<rdar://problem/6277060> ASSERTION FAILED: !m_cacheBeingUpdated if the manifest is not available
Tests: http/tests/appcache/404-manifest.html
http/tests/appcache/fail-on-update.html
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::stopLoading): Removed the incorrect assertion.
- loader/appcache/ApplicationCacheGroup.h: Added an explanation of somewhat nonintuitive m_currentHandle handling.
- 8:00 AM Changeset in webkit [39436] by
-
- 13 edits8 adds in trunk
Reviewed by Alexey Proskuryakov & George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22961
Add WML <fieldset> element support.
Unlike HTML's <fieldset> element, WML doesn't provide a <legend> child element
to describe the <fieldset>. WML instead offers a 'title' attribute on the <fieldset>
element. To integrate within the existing RenderFieldset code, we just create an
internal <insertedLegend> element as first child for a WML <fieldset> element, containing
the title attribute value.
- 6:28 AM Changeset in webkit [39435] by
-
- 2 edits in trunk/JavaScriptCore
Build fix after r39428
- jit/JITCall.cpp: (JSC::JIT::compileOpCallSlowCase): Added a missing MacroAssembler::
Dec 21, 2008:
- 11:31 PM Changeset in webkit [39434] by
-
- 6 edits in trunk/LayoutTests
2008-12-21 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
Attempted fix for 4 failing XMLHttpReuqest tests on Tiger:
access-control-basic-allow-preflight-cache-invalidation-by-header.html
access-control-basic-allow-preflight-cache-invalidation-by-method.html
access-control-basic-allow-preflight-cache-timeout.html
access-control-basic-allow-preflight-cache.html
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-invalidation.php:
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-timeout.php:
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache.php:
- http/tests/xmlhttprequest/resources/portabilityLayer.php:
- http/tests/xmlhttprequest/resources/reset-temp-file.php:
- 6:57 PM Changeset in webkit [39433] by
-
- 2 edits in trunk/WebCore
Not reviewed. Try to fix clean Mac builds, set role=private for FormDataBuilder.h
- 6:22 PM Changeset in webkit [39432] by
-
- 80 edits in trunk
Rubber-stamped by George Staikos.
Unify all TorchMobile copyright lines. Consolidate in a single line, as requested by Mark Rowe, some time ago.
- 6:04 PM Changeset in webkit [39431] by
-
- 16 edits17 adds in trunk
Reviewed by George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22638
Add POST method support to WMLGoElement. GET & POST over HTTP
covered by a new set of WML HTTP layout tests.
Tests: http/tests/wml/go-task-get-method-accept-charset.html
http/tests/wml/go-task-get-method.html
http/tests/wml/go-task-post-method-accept-charset.html
http/tests/wml/go-task-post-method.html
- 5:45 PM Changeset in webkit [39430] by
-
- 9 edits2 adds in trunk/WebCore
Reviewed by Darin Adler and George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22949
Refactor HTMLFormElement to share a maximum level of code between HTMLFormElement & WMLGoElement.
Create a new helper class 'FormDataBuilder', which is hold as member variable in those classes.
It encapsulates all functionality needed to generate a FormData object, usable for HTML/WML form
submission, including boundary string generation, multi-part form handling etc.
No functional changes, no test cases affected.
WMLGoElement will be converted in a follow-up patch.
- 5:42 PM Changeset in webkit [39429] by
-
- 4 edits in trunk/JavaScriptCore
Rubber-stamped by George Staikos.
Fix copyright of the new RandomNumber* files.
- 5:00 PM Changeset in webkit [39428] by
-
- 9 edits in trunk/JavaScriptCore
2008-12-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt & Cameron Zwarich.
Add support for call and property access repatching on x86-64.
No change in performance on current configurations (2x impovement on v8-tests with JIT enabled on x86-64).
- assembler/MacroAssembler.h: (JSC::MacroAssembler::DataLabelPtr::repatch): (JSC::MacroAssembler::DataLabelPtr::operator X86Assembler::JmpDst): (JSC::MacroAssembler::DataLabel32::repatch): (JSC::MacroAssembler::RepatchBuffer::addressOf): (JSC::MacroAssembler::add32): (JSC::MacroAssembler::sub32): (JSC::MacroAssembler::loadPtrWithAddressOffsetRepatch): (JSC::MacroAssembler::storePtrWithAddressOffsetRepatch): (JSC::MacroAssembler::jePtr): (JSC::MacroAssembler::jnePtr): (JSC::MacroAssembler::jnePtrWithRepatch): (JSC::MacroAssembler::differenceBetween):
- assembler/X86Assembler.h: (JSC::X86Assembler::addl_im): (JSC::X86Assembler::subl_im): (JSC::X86Assembler::cmpl_rm): (JSC::X86Assembler::movq_rm_disp32): (JSC::X86Assembler::movq_mr_disp32): (JSC::X86Assembler::repatchPointer): (JSC::X86Assembler::X86InstructionFormatter::oneByteOp64_disp32):
- jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JIT.h:
- jit/JITCall.cpp: (JSC::JIT::unlinkCall): (JSC::JIT::linkCall): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
- jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReferenceForTrampoline):
- jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compilePutByIdSlowCase): (JSC::resizePropertyStorage): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- wtf/Platform.h:
- 3:44 PM Changeset in webkit [39427] by
-
- 14 edits1 add in trunk/WebCore
2008-12-21 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler, Nikolas Zimmermann.
Move the the platform dependent strokeBBox functionality out of RenderPath
into Path with strokeBoundingRect.
RenderPath clean-up for strokeBoundingBox
https://bugs.webkit.org/show_bug.cgi?id=22902
- GNUmakefile.am:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/GraphicsContext.h:
- platform/graphics/Path.h:
- platform/graphics/StrokeStyleApplier.h: Added. (WebCore::StrokeStyleApplier::~StrokeStyleApplier):
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::strokeBoundingRect):
- platform/graphics/cg/PathCG.cpp: (WebCore::createScratchContext): (WebCore::scratchContext): (WebCore::Path::strokeBoundingRect):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::pen):
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeBoundingRect):
- rendering/RenderPath.cpp: (WebCore::StrokeBoundingRectStyleApplier::StrokeBoundingRectStyleApplier): (WebCore::StrokeBoundingRectStyleApplier::strokeStyle): (WebCore::RenderPath::relativeBBox):
- rendering/RenderPath.h:
- svg/graphics/cairo/RenderPathCairo.cpp:
- svg/graphics/cg/RenderPathCg.cpp:
- svg/graphics/qt/RenderPathQt.cpp:
- 6:49 AM Changeset in webkit [39426] by
-
- 4 edits in trunk/WebKit/gtk
2008-12-21 Xan Lopez <xan@gnome.org>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=16092
[GTK] Middle-mouse click should allow opening a URL in a new tab
Add mouse button and keyboard state modifiers info to navigation action.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
- webkit/webkitwebnavigationaction.cpp: (_WebKitWebNavigationActionPrivate::): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_property): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_property): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_class_init): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_button): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_modifier_state):
- webkit/webkitwebnavigationaction.h:
Dec 20, 2008:
- 2:41 PM Changeset in webkit [39425] by
-
- 4 edits1 add in trunk/WebKit/win
Reviewed by Ada Chan.
- expose the new allItems() method via a new IWebHistoryPrivate interface
- Interfaces/IWebHistoryPrivate.idl: Added.
- Interfaces/WebKit.idl: Added IWebHistoryPrivate.idl.
- WebHistory.cpp: (WebHistory::QueryInterface): Added IWebHistoryPrivate. (WebHistory::allItems):
- WebHistory.h:
- 12:52 PM Changeset in webkit [39424] by
-
- 3 edits in trunk/WebCore
Fix typo "CSSAferRuleValue" to "CSSAfterRuleValue"
- html/PreloadScanner.cpp: (WebCore::PreloadScanner::tokenizeCSS):
- html/PreloadScanner.h: (WebCore::PreloadScanner::CSSState):
- 2:26 AM Changeset in webkit [39423] by
-
- 3 edits in trunk/WebCore
Reviewed by Geoff Garen.
<rdar://problem/6454076> Random crashes on JS raytracer
No test, because the crash is not readily reproducible.
- platform/text/StringImpl.cpp: (WebCore::StringImpl::empty):
- platform/text/StringImpl.h: Made empty string per-thread.
- 2:11 AM Changeset in webkit [39422] by
-
- 8 edits in trunk/JavaScriptCore
2008-12-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Port optimized property access generation to the MacroAssembler.
- assembler/MacroAssembler.h: (JSC::MacroAssembler::AbsoluteAddress::AbsoluteAddress): (JSC::MacroAssembler::DataLabelPtr::repatch): (JSC::MacroAssembler::DataLabel32::DataLabel32): (JSC::MacroAssembler::DataLabel32::repatch): (JSC::MacroAssembler::Label::operator X86Assembler::JmpDst): (JSC::MacroAssembler::Jump::repatch): (JSC::MacroAssembler::JumpList::empty): (JSC::MacroAssembler::RepatchBuffer::link): (JSC::MacroAssembler::add32): (JSC::MacroAssembler::and32): (JSC::MacroAssembler::sub32): (JSC::MacroAssembler::loadPtrWithAddressRepatch): (JSC::MacroAssembler::storePtrWithAddressRepatch): (JSC::MacroAssembler::push): (JSC::MacroAssembler::ja32): (JSC::MacroAssembler::jePtr): (JSC::MacroAssembler::jnePtr): (JSC::MacroAssembler::jnePtrWithRepatch): (JSC::MacroAssembler::align): (JSC::MacroAssembler::differenceBetween):
- assembler/X86Assembler.h: (JSC::X86Assembler::movl_rm_disp32): (JSC::X86Assembler::movl_mr_disp32): (JSC::X86Assembler::X86InstructionFormatter::oneByteOp_disp32): (JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
- jit/JIT.cpp: (JSC::ctiRepatchCallByReturnAddress): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JIT.h:
- jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compilePutByIdSlowCase): (JSC::resizePropertyStorage): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace):
- wtf/RefCounted.h: (WTF::RefCountedBase::addressOfCount):
Dec 19, 2008:
- 7:18 PM Changeset in webkit [39421] by
-
- 11 edits4 adds in trunk
2008-12-19 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=16562
[gtk] Implement WebPolicyDelegate methods
Original work by Pierre-Luc Beaudoin. Final touches by Gustavo
Noronha.
This implements the delegates methods of WebPolicyDelegate.
Since Gtk+/C doesn't have delegate methods, they are replaced with
signals.
A new object WebKitWebPolicyDecision allows the browser to delay its
response in certain cases. WebKitWebNavigationAction contains the
information about what caused a navigation request.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::FrameLoaderClient): (WebKit::FrameLoaderClient::~FrameLoaderClient): (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebKit::FrameLoaderClient::cancelPolicyCheck): (WebKit::FrameLoaderClient::canShowMIMEType):
- WebCoreSupport/FrameLoaderClientGtk.h:
- webkit/webkit.h:
- webkit/webkitdefines.h:
- webkit/webkitprivate.cpp: (WebKit::kit): (WebKit::core):
- webkit/webkitprivate.h:
- webkit/webkitwebnavigationaction.cpp: Added. (_WebKitWebNavigationActionPrivate::): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_property): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_property): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_init): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_finalize): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_class_init): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_reason): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_reason): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_original_uri): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_original_uri):
- webkit/webkitwebnavigationaction.h: Added.
- webkit/webkitwebpolicydecision.cpp: Added. (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_class_init): (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_init): (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_new): (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_use): (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_ignore): (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_download): (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_cancel):
- webkit/webkitwebpolicydecision.h: Added.
- 6:35 PM Changeset in webkit [39420] by
-
- 2 edits in trunk/LayoutTests
2008-12-19 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Holger Freyther.
Enable more tests for testing on Gtk+ port.
- platform/gtk/Skipped:
- 6:04 PM Changeset in webkit [39419] by
-
- 7 edits in trunk/WebCore
2008-12-19 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Replace some uses of HardRetain etc with RetainPtr.
- platform/mac/DragImageMac.mm:
- platform/mac/SharedBufferMac.mm: (WebCore::SharedBuffer::createCFData):
- rendering/RenderThemeMac.mm:
- svg/graphics/cg/SVGResourceFilterCg.mm: (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
- svg/graphics/mac/SVGResourceFilterPlatformDataMac.h:
- svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm: (WebCore::SVGResourceFilterPlatformDataMac::SVGResourceFilterPlatformDataMac):
- 5:39 PM Changeset in webkit [39418] by
-
- 2 edits in trunk/WebKit/win
2008-12-19 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebHistory.cpp: (WebHistory::allItems):
- 4:31 PM Changeset in webkit [39417] by
-
- 6 edits in trunk/WebKit
WebKit/mac:
2008-12-19 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler, Adele Peterson, Brady Eidson.
Added SPI for getting an unsorted vector of all items in history.
- History/WebHistory.h:
- History/WebHistory.mm: (-[WebHistory allItems]):
WebKit/win:
2008-12-19 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler, Adele Peterson, Brady Eidson.
Added SPI for getting an unsorted vector of all items in history.
- WebHistory.cpp: (WebHistory::orderedItemsLastVisitedOnDay): (WebHistory::allItems):
- WebHistory.h:
- 4:28 PM Changeset in webkit [39416] by
-
- 10 edits2 adds in trunk
Reviewed by Kevin Ollivier.
Add Context Menu support to wx bindings.
https://bugs.webkit.org/show_bug.cgi?id=22675
- 4:03 PM Changeset in webkit [39415] by
-
- 2 edits in trunk/WebKitTools
2008-12-19 David Levin <levin@chromium.org>
Reviewed by Mark Rowe.
Make the git diff command used for preparing the change log avoid using any external diff tools.
- Scripts/prepare-ChangeLog:
- 2:54 PM Changeset in webkit [39414] by
-
- 2 edits in trunk/WebCore
2008-12-19 Beth Dakin <Beth Dakin>
Reviewed by Darin Adler.
Temporary band-aide fix for <rdar://problem/6372481> In Gmail, a
crash occurs at
AccessibilityTable::isTableExposableThroughAccessibility() when
attempting to create a link in a rich text message
We need to disable Accessibility Tables until we get this fixed for
real to prevent rampant crashing.
- page/AccessibilityTable.cpp: (WebCore::AccessibilityTable::AccessibilityTable):
- 2:44 PM Changeset in webkit [39413] by
-
- 3 edits4 adds in trunk
2008-12-19 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
When the document element is transformed, we need to paint
the view background to avoid unpainted areas.
Test: fast/transforms/transformed-document-element.html
- rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
- 1:37 PM Changeset in webkit [39412] by
-
- 2 edits in trunk/WebKitSite
2008-12-19 Dean Jackson <dino@apple.com>
Media queries that return <integer> but are really boolean
are restricted to 0 and 1. This is in line with other
media features.
- specs/MediaQueriesExtensions.html:
- 1:19 PM Changeset in webkit [39411] by
-
- 2 edits in trunk/WebCore
Fix build.
- WebCore.vcproj/WebCore.vcproj:
- 11:10 AM Changeset in webkit [39410] by
-
- 1 edit2 adds in trunk/LayoutTests
2008-12-19 Pamela Greene <pam@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22612
Add test to verify type enforcement in DOM setters.
Resubmitting corrected copies; first submission had patching errors.
- fast/dom/setter-type-enforcement-expected.txt: Added.
- fast/dom/setter-type-enforcement.html: Added.
- 10:52 AM Changeset in webkit [39409] by
-
- 6 edits in trunk
wx build fixes after recent changes.
- 10:34 AM Changeset in webkit [39408] by
-
- 2 edits in trunk/WebCore
[GTK] Fix make distcheck again
These files were moved to WebCore/platform/animation
and WebCore/platform/graphics/transforms.
- 8:54 AM Changeset in webkit [39407] by
-
- 2 edits in trunk
2008-12-19 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
Use ustar tar format for WebKit/GTK+'s make dist target, so that
storing files whose filenames are > 99 is possible.
- configure.ac:
- 8:53 AM Changeset in webkit [39406] by
-
- 2 edits in trunk/WebCore
2008-12-19 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
Fix AtomicString usage, so that building works.
- platform/network/soup/ResourceHandleSoup.cpp:
- 8:47 AM Changeset in webkit [39405] by
-
- 4 edits in trunk
JavaScriptCore:
2008-12-19 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
Added file which was missing to the javascriptcore_sources
variable, so that it shows up in the tarball created by `make
dist'.
- GNUmakefile.am:
WebKitTools
2008-12-19 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
Added files which were missing from the TestNetscapePlugin
directory to the SOURCES variable, so that they will be
distributed in a make dist.
- GNUMakefile.am:
- 8:35 AM Changeset in webkit [39404] by
-
- 2 edits in trunk
[GTK] Build fix by defining WTF_USE_JIT_STUB_ARGUMENT_VA_LIST
Fix the jit compilation on i*686 on Linux by using the va_list
to pass arguments to the CTI. This is done on the MAC as well
and sunspider and javascriptcore seem to work with that.
- 7:32 AM Changeset in webkit [39403] by
-
- 2 edits in trunk/WebCore
Windows build fix on older versions of CFNetwork after r39393
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::highestSupportedCFURLConnectionClientVersion): Changed preprocessor directives not to leave in unreachable code on old versions of CFNetwork.
- 4:45 AM Changeset in webkit [39402] by
-
- 2 edits in trunk/WebCore
2008-12-19 Antti Koivisto <Antti Koivisto>
Comment fix.
- platform/PurgeableBuffer.h:
- 3:27 AM Changeset in webkit [39401] by
-
- 2 edits in trunk/JavaScriptCore
Build fix when building JS API tests with a c89 c compiler
Do not use C++ style comments and convert them to C comments.
- 3:26 AM Changeset in webkit [39400] by
-
- 2 edits in trunk/WebCore
[GTK] Build fix by adding the new files
- 2:41 AM Changeset in webkit [39399] by
-
- 4 edits in trunk
2008-12-19 Jade Han <jade.han@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Allow conversion of JavaScript Number and Boolean types to Qt types
- 2:05 AM Changeset in webkit [39398] by
-
- 4 edits in trunk/WebCore
2008-12-19 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Holger Freyther.
Implement ImageDecoder::filenameExtension() for Qt
- 1:14 AM Changeset in webkit [39397] by
-
- 1 edit in trunk/WebCore/WebCore.pro
Fix the Qt build after r39378
- 1:03 AM Changeset in webkit [39396] by
-
- 9 edits in trunk/WebCore
2008-12-18 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Implement ImageSource::filenameExtension for Cario
- platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::filenameExtension):
- platform/image-decoders/ImageDecoder.h:
- platform/image-decoders/bmp/BMPImageDecoder.h: (WebCore::BMPImageDecoder::filenameExtension):
- platform/image-decoders/gif/GIFImageDecoder.h: (WebCore::GIFImageDecoder::filenameExtension):
- platform/image-decoders/ico/ICOImageDecoder.h: (WebCore::ICOImageDecoder::filenameExtension):
- platform/image-decoders/jpeg/JPEGImageDecoder.h: (WebCore::JPEGImageDecoder::filenameExtension):
- platform/image-decoders/png/PNGImageDecoder.h: (WebCore::PNGImageDecoder::filenameExtension):
- platform/image-decoders/xbm/XBMImageDecoder.h: (WebCore::XBMImageDecoder::filenameExtension):
- 12:52 AM Changeset in webkit [39395] by
-
- 1 edit in trunk/JavaScriptCore/wtf/Platform.h
Fix build break in Platform.h
- 12:19 AM Changeset in webkit [39394] by
-
- 2 edits in trunk/WebKit/qt
2008-12-18 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Tor Arne Vestbø.
When Web Inspector is launched without an associated node,
call show() instead of inspect().
Dec 18, 2008:
- 11:34 PM Changeset in webkit [39393] by
-
- 33 edits in trunk
WebCore:
Reviewed by Sam Weinig.
- avoid using the ResourceHandle-level credential storage, if any, unless the client opts to use it; when use of the credential storage is disallowed, all authentication challenges are sent to the client.
- let the FrameLoaderClient decide whether to use the credential storage.
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::shouldUseCredentialStorage): Added. Returns false.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::shouldUseCredentialStorage): Added. Calls through to the FrameLoaderClient.
- loader/FrameLoader.h: Declared shouldUseCredentialStorage().
- loader/FrameLoaderClient.h: Declared shouldUseCredentialStorage().
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::shouldUseCredentialStorage): Added. Calls through to the FrameLoader.
- loader/ResourceLoader.h: (WebCore::ResourceLoader::shouldUseCredentialStorage): Implemented this ResourceHandleClient method.
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::shouldUseCredentialStorage): Added. Overrides the ResourceLoader implementation by letting the client supply the return value. If the client does not do this, continues with the ResourceLoader behavior of asking the FrameLoader.
- loader/SubresourceLoader.h: Removed an unused #include and declared shouldUseCredentialStorage().
- loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::getShouldUseCredentialStorage): Added a default implementation which returns false, meaning the client does not wish to decide whether the credential storage should be used.
- platform/network/ResourceHandle.h: Removed unused forward declarations. Declared a new member function, shouldUseCredentialStorage(), on Mac and CFNetwork-using builds.
- platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::shouldUseCredentialStorage): Added this default implementation that returns false.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::findCFNetworkModule): Added. Returns a handle to the CFNetwork module. (WebCore::cfNetworkVersion): Added. Returns the high word of the CFNetwork library's product version. (WebCore::highestSupportedCFURLConnectionClientVersion): Added. Returns the highest version of the CFURLConnectionClient structure supported by the CFNetwork library. The only reason to check this at runtime is that WebKit may be linking at runtime against an older version of CFNetwork than the one it was built with, as is the case with nightly builds. (WebCore::shouldUseCredentialStorageCallback): Added this CFURLConnection callback which calls through to ResourceHandle::shouldUseCredentialStorage(). (WebCore::ResourceHandle::start): Pass a version 3 CFURLConnectionClient including the shouldUseCredentialStorage callback. At runtime, clamp the client structure version down to the highest supported by CFNetwork. (WebCore::ResourceHandle::shouldUseCredentialStorage): Added. Calls through to the client if there is one. Otherwise returns false.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::shouldUseCredentialStorage): Ditto. (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]): Added this delegate method which callls through to ResourceHandle::shouldUseCredentialStorage().
WebKit/gtk:
Reviewed by Sam Weinig.
- stub out FrameLoaderClient::shouldUseCredentialStorage().
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::shouldUseCredentialStorage):
- WebCoreSupport/FrameLoaderClientGtk.h:
WebKit/mac:
Reviewed by Sam Weinig.
- implement FrameLoaderClient::shouldUseCredentialStorage() by calling a new resource load delegae method.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::shouldUseCredentialStorage): Added. Calls the delegate method. If the method is unimplemented, returns true for backwards compatibility.
- WebView/WebView.mm: (-[WebView _cacheResourceLoadDelegateImplementations]): Initialize the shouldUseCredentialStorageFunc member. (CallResourceLoadDelegateReturningBoolean): Added.
- WebView/WebViewInternal.h:
- WebView/WebResourceLoadDelegatePrivate.h: Declared the delegate method -webView:resource:shouldUseCredentialStorageForDataSource:.
WebKit/qt:
Reviewed by Sam Weinig.
- stub out FrameLoaderClient::shouldUseCredentialStorage().
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::shouldUseCredentialStorage):
- WebCoreSupport/FrameLoaderClientQt.h:
WebKit/win:
Reviewed by Sam Weinig.
- implement FrameLoaderClient::shouldUseCredentialStorage() by calling a new resource load delegae method.
- Interfaces/IWebResourceLoadDelegatePrivate.idl: Added a ne interface, IWebResourceLoadDelegatePrivate2, including a new method, shouldUseCredentialStorage().
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::shouldUseCredentialStorage): Added. Calls the delegate method. If the method is unimplemented, returns true for backwards compatibility.
- WebCoreSupport/WebFrameLoaderClient.h:
WebKit/wx:
Reviewed by Sam Weinig.
- stub out FrameLoaderClient::shouldUseCredentialStorage().
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::shouldUseCredentialStorage):
- WebKitSupport/FrameLoaderClientWx.h:
- 10:54 PM Changeset in webkit [39392] by
-
- 2 edits in trunk/WebKit/mac
2008-12-18 Cameron Zwarich <zwarich@apple.com>
Reviewed by Jonathan Honeycutt.
Fix an apparent typo in r39385 that is causing lots of crashes.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
- 7:21 PM Changeset in webkit [39391] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-18 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Same as last revision, adding cases for pre & post inc & dec.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- 6:58 PM Changeset in webkit [39390] by
-
- 2 deletes in trunk/LayoutTests/fast/dom
Revert 39363 because the test doesn't pass.
- 6:30 PM Changeset in webkit [39389] by
-
- 5 edits in trunk/JavaScriptCore
2008-12-18 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Fixes for the JIT's handling of JSImmediate values on x86-64.
On 64-bit systems, the code in JSImmediate.h relies on the upper
bits of a JSImmediate being a sign extension of the low 32-bits.
This was not being enforced by the JIT, since a number of inline
operations were being performed on 32-bit values in registers, and
when a 32-bit result is written to a register on x86-64 the value
is zero-extended to 64-bits.
This fix honors previous behavoir. A better fix in the long run
(when the JIT is enabled by default) may be to change JSImmediate.h
so it no longer relies on the upper bits of the pointer,... though
if we're going to change JSImmediate.h for 64-bit, we probably may
as well change the format so that the full range of 32-bit ints can
be stored, rather than just 31-bits.
- assembler/MacroAssembler.h: (JSC::MacroAssembler::addPtr): (JSC::MacroAssembler::andPtr): (JSC::MacroAssembler::orPtr): (JSC::MacroAssembler::or32): (JSC::MacroAssembler::xor32): (JSC::MacroAssembler::xorPtr): (JSC::MacroAssembler::signExtend32ToPtr):
- assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::andq_rr): (JSC::X86Assembler::andq_ir): (JSC::X86Assembler::orq_rr): (JSC::X86Assembler::xorq_ir): (JSC::X86Assembler::movsxd_rr):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JITInlineMethods.h: (JSC::JIT::emitFastArithReTagImmediate): (JSC::JIT::emitFastArithPotentiallyReTagImmediate): (JSC::JIT::emitFastArithImmToInt):
- 5:51 PM Changeset in webkit [39388] by
-
- 2 edits in trunk/WebCore
Reset role to "Private" on 6 header files to fix clean builds after r39378
Reviewed by BUILD FIX.
- WebCore.xcodeproj/project.pbxproj: Added back "Private" role that was lost on 6 headers when they were "moved": AffineTransform.h, Animation.h, AnimationList.h, TimingFunction.h, TransformOperation.h and TransformOperations.h.
- 5:49 PM Changeset in webkit [39387] by
-
- 2 edits in trunk/WebCore
2008-12-18 Pamela Greene <pam@chromium.org>
Reviewed by Dan Bernstein.
Add initializer for m_textDirectionSubmenuInclusionBehavior.
https://bugs.webkit.org/show_bug.cgi?id=22926
- page/Settings.cpp: (WebCore::Settings::Settings): Initialize m_textDirectionSubmenuInclusionBehavior
- 5:37 PM Changeset in webkit [39386] by
-
- 4 edits in trunk/WebKit/mac
2008-12-18 Brady Eidson <beidson@apple.com>
Reviewed by John Sullivan
Initial visit to a website creates history items that start with a visit count of
zero instead of one
- History/WebHistory.mm: (-[WebHistoryPrivate visitedURL:withTitle:]): Set the visit count on new items
- History/WebHistoryItem.mm: (-[WebHistoryItem _setVisitCount:]): Call through to the WebCore item
- History/WebHistoryItemInternal.h:
- 5:15 PM Changeset in webkit [39385] by
-
- 29 edits in trunk
WebCore:
2008-12-18 Sam Weinig <sam@webkit.org>
Reviewed by John Sullivan.
Add new FrameLoaderClient method to indicate the first visually
non-empty layout based on an heuristic. Right now that heuristic
is the first layout after an image, text or plugin has been added
to the render tree, but I can imagine it becoming much smarter.
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::didFirstVisuallyNonEmptyLayout):
- loader/FrameLoader.h:
- loader/FrameLoaderClient.h:
- page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::layout): (WebCore::FrameView::performPostLayoutTasks): (WebCore::FrameView::setIsVisuallyNonEmpty):
- page/FrameView.h:
- rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage):
- rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::RenderPartObject):
- rendering/RenderText.cpp: (WebCore::RenderText::RenderText):
WebKit/gtk:
2008-12-18 Sam Weinig <sam@webkit.org>
Reviewed by John Sullivan.
Stub out FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout()
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
- WebCoreSupport/FrameLoaderClientGtk.h:
WebKit/mac:
2008-12-18 Sam Weinig <sam@webkit.org>
Reviewed by John Sullivan.
Implement FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout() by calling
a new private frame load delegate method.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
- WebView/WebView.mm: (-[WebView _cacheFrameLoadDelegateImplementations]):
- WebView/WebViewInternal.h:
- WebView/WebViewPrivate.h:
WebKit/qt:
2008-12-18 Sam Weinig <sam@webkit.org>
Reviewed by John Sullivan.
Stub out FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout()
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidFirstVisuallyNonEmptyLayout):
- WebCoreSupport/FrameLoaderClientQt.h:
WebKit/win:
2008-12-18 Sam Weinig <sam@webkit.org>
Reviewed by John Sullivan.
Implement FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout() by calling
a new private frame load delegate method.
- Interfaces/IWebFrameLoadDelegatePrivate.idl:
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
- WebCoreSupport/WebFrameLoaderClient.h:
WebKit/wx:
2008-12-18 Sam Weinig <sam@webkit.org>
Reviewed by John Sullivan.
Stub out FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout()
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::dispatchDidFirstVisuallyNonEmptyLayout):
- WebKitSupport/FrameLoaderClientWx.h:
- 4:39 PM Changeset in webkit [39384] by
-
- 35 edits3 moves1 add in trunk/LayoutTests
2008-12-18 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Darin Adler.
Rewrote some of the transition layout tests that were using setTimeout() to use the transition pause API in DRT when available.
Rewrote the transition layout tests that were specifically testing the transition end event to use common JS code from transition-end-event-helpers.js.
Fixed some typos.
- transitions/end-event-helpers.js: Removed.
- transitions/interrupt-transform-transition-expected.txt:
- transitions/interrupt-transform-transition.html:
- transitions/opacity-transition-zindex.html:
- transitions/start-transform-transition.html:
- transitions/transform-op-list-match-expected.txt:
- transitions/transform-op-list-match.html:
- transitions/transform-op-list-no-match-expected.txt:
- transitions/transform-op-list-no-match.html:
- transitions/transition-end-event-all-properties-expected.txt:
- transitions/transition-end-event-all-properties.html:
- transitions/transition-end-event-attributes-expected.txt:
- transitions/transition-end-event-attributes.html:
- transitions/transition-end-event-container-expected.txt:
- transitions/transition-end-event-container.html:
- transitions/transition-end-event-helpers.js: Copied from LayoutTests/transitions/end-event-helpers.js. (recordTransitionEndEvent): (runTransitionTest.processEndEvents.compareEventInfo): (runTransitionTest.processEndEvents.examineResults): (runTransitionTest.processEndEvents): (runTransitionTest.startTest): (runTransitionTest.window): (runTransitionTest):
- transitions/transition-end-event-left-expected.txt:
- transitions/transition-end-event-left.html:
- transitions/transition-end-event-multiple-01-expected.txt:
- transitions/transition-end-event-multiple-01.html:
- transitions/transition-end-event-multiple-02-expected.txt:
- transitions/transition-end-event-multiple-02.html:
- transitions/transition-end-event-multiple-03-expected.txt:
- transitions/transition-end-event-multiple-03.html:
- transitions/transition-end-event-multiple-04-expected.txt:
- transitions/transition-end-event-multiple-04.html:
- transitions/transition-end-event-nested-expected.txt:
- transitions/transition-end-event-nested.html:
- transitions/transition-end-event-set-none-expected.txt:
- transitions/transition-end-event-set-none.html:
- transitions/transition-end-event-transform-expected.txt:
- transitions/transition-end-event-transform.html:
- transitions/transition-end-event-window-expected.txt:
- transitions/transition-end-event-window.html:
- transitions/transition-test-helpers.js: Added. (runTransitionTest.isCloseEnough): (runTransitionTest.checkExpectedValue): (runTransitionTest.endTest): (runTransitionTest.runTest): (runTransitionTest.startTest): (runTransitionTest.if):
- transitions/transition-timing-function-expected.txt: Copied from LayoutTests/transitions/transition-timing-function-software-expected.txt.
- transitions/transition-timing-function-software-expected.txt: Removed.
- transitions/transition-timing-function-software.html: Removed.
- transitions/transition-timing-function.html: Copied from LayoutTests/transitions/transition-timing-function-software.html.
- transitions/zero-duration-in-list-expected.txt:
- transitions/zero-duration-in-list.html:
- 3:58 PM Changeset in webkit [39383] by
-
- 4 edits in trunk/WebCore
2008-12-18 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
- fix <rdar://problem/6449841> reduce memory use of ResourceResponseBase by removing two maps
We were parsing the cache-control and pragma header field values into maps.
I changed that so instead we only cache two bits with the data we were actually
using. Later we might want to move this responsibility out of this class entirely;
we can cache it at the higher level instead.
- loader/CachedResource.cpp: (WebCore::CachedResource::mustRevalidate): Changed to call a specific API to get at the bits in quest instead of a general "cache control directives" API.
- platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::setHTTPHeaderField): Remove the logic for the pragma header field since no one is using this for now. (WebCore::ResourceResponseBase::parseCacheControlDirectives): Eliminated the return value and made this function have side effects only. Changed it so it's the caller's responsibility to check m_haveParsedCacheControl. Set m_cacheControlContainsNoCache and m_cacheControlContainsMustRevalidate rather than keeping a map around.
- platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::cacheControlContainsNoCache): Added. (WebCore::ResourceResponseBase::cacheControlContainsMustRevalidate): Added. (WebCore::ResourceResponseBase::ResourceResponseBase): Updated since I removed m_haveParsedCacheControl and renamed m_haveParsedCacheControlHeader to remove the imprecise use of the term "header".
- 3:07 PM Changeset in webkit [39382] by
-
- 22 edits in trunk/WebCore
Build fix.
Delete 2nd copy of code in these files.
- platform/animation/Animation.cpp:
- platform/animation/Animation.h:
- platform/animation/AnimationList.cpp:
- platform/animation/AnimationList.h:
- platform/animation/TimingFunction.h:
- platform/graphics/transforms/AffineTransform.cpp:
- platform/graphics/transforms/AffineTransform.h:
- platform/graphics/transforms/IdentityTransformOperation.h:
- platform/graphics/transforms/MatrixTransformOperation.cpp:
- platform/graphics/transforms/MatrixTransformOperation.h:
- platform/graphics/transforms/RotateTransformOperation.cpp:
- platform/graphics/transforms/RotateTransformOperation.h:
- platform/graphics/transforms/ScaleTransformOperation.cpp:
- platform/graphics/transforms/ScaleTransformOperation.h:
- platform/graphics/transforms/SkewTransformOperation.cpp:
- platform/graphics/transforms/SkewTransformOperation.h:
- platform/graphics/transforms/TransformOperation.h:
- platform/graphics/transforms/TransformOperations.cpp:
- platform/graphics/transforms/TransformOperations.h:
- platform/graphics/transforms/TranslateTransformOperation.cpp:
- platform/graphics/transforms/TranslateTransformOperation.h:
- 2:51 PM Changeset in webkit [39381] by
-
- 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj
Partial build fix.
- 2:14 PM Changeset in webkit [39380] by
-
- 7 edits in trunk/JavaScriptCore
2008-12-18 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Just a tidy up - rename & refactor some the #defines configuring the JIT.
- interpreter/Interpreter.cpp: (JSC::Interpreter::cti_op_convert_this): (JSC::Interpreter::cti_op_end): (JSC::Interpreter::cti_op_add): (JSC::Interpreter::cti_op_pre_inc): (JSC::Interpreter::cti_timeout_check): (JSC::Interpreter::cti_register_file_check): (JSC::Interpreter::cti_op_loop_if_less): (JSC::Interpreter::cti_op_loop_if_lesseq): (JSC::Interpreter::cti_op_new_object): (JSC::Interpreter::cti_op_put_by_id_generic): (JSC::Interpreter::cti_op_get_by_id_generic): (JSC::Interpreter::cti_op_put_by_id): (JSC::Interpreter::cti_op_put_by_id_second): (JSC::Interpreter::cti_op_put_by_id_fail): (JSC::Interpreter::cti_op_get_by_id): (JSC::Interpreter::cti_op_get_by_id_second): (JSC::Interpreter::cti_op_get_by_id_self_fail): (JSC::Interpreter::cti_op_get_by_id_proto_list): (JSC::Interpreter::cti_op_get_by_id_proto_list_full): (JSC::Interpreter::cti_op_get_by_id_proto_fail): (JSC::Interpreter::cti_op_get_by_id_array_fail): (JSC::Interpreter::cti_op_get_by_id_string_fail): (JSC::Interpreter::cti_op_instanceof): (JSC::Interpreter::cti_op_del_by_id): (JSC::Interpreter::cti_op_mul): (JSC::Interpreter::cti_op_new_func): (JSC::Interpreter::cti_op_call_JSFunction): (JSC::Interpreter::cti_op_call_arityCheck): (JSC::Interpreter::cti_vm_dontLazyLinkCall): (JSC::Interpreter::cti_vm_lazyLinkCall): (JSC::Interpreter::cti_op_push_activation): (JSC::Interpreter::cti_op_call_NotJSFunction): (JSC::Interpreter::cti_op_create_arguments): (JSC::Interpreter::cti_op_create_arguments_no_params): (JSC::Interpreter::cti_op_tear_off_activation): (JSC::Interpreter::cti_op_tear_off_arguments): (JSC::Interpreter::cti_op_profile_will_call): (JSC::Interpreter::cti_op_profile_did_call): (JSC::Interpreter::cti_op_ret_scopeChain): (JSC::Interpreter::cti_op_new_array): (JSC::Interpreter::cti_op_resolve): (JSC::Interpreter::cti_op_construct_JSConstruct): (JSC::Interpreter::cti_op_construct_NotJSConstruct): (JSC::Interpreter::cti_op_get_by_val): (JSC::Interpreter::cti_op_resolve_func): (JSC::Interpreter::cti_op_sub): (JSC::Interpreter::cti_op_put_by_val): (JSC::Interpreter::cti_op_put_by_val_array): (JSC::Interpreter::cti_op_lesseq): (JSC::Interpreter::cti_op_loop_if_true): (JSC::Interpreter::cti_op_negate): (JSC::Interpreter::cti_op_resolve_base): (JSC::Interpreter::cti_op_resolve_skip): (JSC::Interpreter::cti_op_resolve_global): (JSC::Interpreter::cti_op_div): (JSC::Interpreter::cti_op_pre_dec): (JSC::Interpreter::cti_op_jless): (JSC::Interpreter::cti_op_not): (JSC::Interpreter::cti_op_jtrue): (JSC::Interpreter::cti_op_post_inc): (JSC::Interpreter::cti_op_eq): (JSC::Interpreter::cti_op_lshift): (JSC::Interpreter::cti_op_bitand): (JSC::Interpreter::cti_op_rshift): (JSC::Interpreter::cti_op_bitnot): (JSC::Interpreter::cti_op_resolve_with_base): (JSC::Interpreter::cti_op_new_func_exp): (JSC::Interpreter::cti_op_mod): (JSC::Interpreter::cti_op_less): (JSC::Interpreter::cti_op_neq): (JSC::Interpreter::cti_op_post_dec): (JSC::Interpreter::cti_op_urshift): (JSC::Interpreter::cti_op_bitxor): (JSC::Interpreter::cti_op_new_regexp): (JSC::Interpreter::cti_op_bitor): (JSC::Interpreter::cti_op_call_eval): (JSC::Interpreter::cti_op_throw): (JSC::Interpreter::cti_op_get_pnames): (JSC::Interpreter::cti_op_next_pname): (JSC::Interpreter::cti_op_push_scope): (JSC::Interpreter::cti_op_pop_scope): (JSC::Interpreter::cti_op_typeof): (JSC::Interpreter::cti_op_is_undefined): (JSC::Interpreter::cti_op_is_boolean): (JSC::Interpreter::cti_op_is_number): (JSC::Interpreter::cti_op_is_string): (JSC::Interpreter::cti_op_is_object): (JSC::Interpreter::cti_op_is_function): (JSC::Interpreter::cti_op_stricteq): (JSC::Interpreter::cti_op_nstricteq): (JSC::Interpreter::cti_op_to_jsnumber): (JSC::Interpreter::cti_op_in): (JSC::Interpreter::cti_op_push_new_scope): (JSC::Interpreter::cti_op_jmp_scopes): (JSC::Interpreter::cti_op_put_by_index): (JSC::Interpreter::cti_op_switch_imm): (JSC::Interpreter::cti_op_switch_char): (JSC::Interpreter::cti_op_switch_string): (JSC::Interpreter::cti_op_del_by_val): (JSC::Interpreter::cti_op_put_getter): (JSC::Interpreter::cti_op_put_setter): (JSC::Interpreter::cti_op_new_error): (JSC::Interpreter::cti_op_debug): (JSC::Interpreter::cti_vm_throw):
- interpreter/Interpreter.h:
- jit/JIT.cpp: (JSC::): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompile):
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference): (JSC::JIT::restoreArgumentReferenceForTrampoline):
- wtf/Platform.h:
- 1:21 PM Changeset in webkit [39379] by
-
- 7 edits2 adds in trunk/WebCore
2008-12-18 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=22859
Abstract away the use of JSDOMWindow in CachedPage and introduce
ScriptCachedPageData abstraction.
- GNUmakefile.am: Added ScriptCachedPageData to project.
- WebCore.pro: Added ScriptCachedPageData to project.
- WebCore.vcproj/WebCore.vcproj: Added ScriptCachedPageData to project.
- WebCore.xcodeproj/project.pbxproj: Added ScriptCachedPageData to
project.
- bindings/js/ScriptCachedPageData.cpp: Added. (WebCore::ScriptCachedPageData::ScriptCachedPageData): (WebCore::ScriptCachedPageData::~ScriptCachedPageData): (WebCore::ScriptCachedPageData::restore): (WebCore::ScriptCachedPageData::clear):
- bindings/js/ScriptCachedPageData.h: Added.
- history/CachedPage.cpp: Replaced JSDOMWindow and ProtectedPtr with
ScriptCachedPageData.
(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::domWindow):
(WebCore::CachedPage::restore):
(WebCore::CachedPage::clear):
- history/CachedPage.h: Replaced JSDOMWindow and ProtectedPtr with
ScriptCachedPageData.
- 1:06 PM Changeset in webkit [39378] by
-
- 2 edits23 adds21 deletes in trunk/WebCore
Reviewed by Dave Hyatt.
To avoid future dependency issues, all the TransformOperations and Animation related files need to be moved to platform
- 10:19 AM Changeset in webkit [39377] by
-
- 12 edits3 adds in trunk
2008-12-18 Cameron Zwarich <zwarich@apple.com>
Reviewed by Geoff Garen.
Bug 21855: REGRESSION (r37323): Gmail complains about popup blocking when opening a link
<https://bugs.webkit.org/show_bug.cgi?id=21855>
<rdar://problem/6278244>
If JavaScript is not currently executing, the handleEvent member function
of JSAbstractEventListener should set the dynamic global object to the
global object of the context in which the event occurred.
If this is not set, then JavaScriptCore will simply take the global object
of the context where the event handler function was created, which may be
a different frame. This will cause the popup blocker to incorrectly block
windows opened from onclick events inside of an iframe whose handler was
created in the outer frame, as it will check the outer frame and see that
it is not processing any events.
- interpreter/Interpreter.cpp:
- runtime/JSGlobalObject.h: (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): (JSC::DynamicGlobalObjectScope::~DynamicGlobalObjectScope):
WebCore:
- bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent):
WebKitTools:
- DumpRenderTree/mac/EventSendingController.h:
- DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): Expose scheduleAsynchronousClick to JavaScript. (-[EventSendingController scheduleAsynchronousClick]): Add.
LayoutTests:
- fast/events/popup-blocking-click-in-iframe-expected.txt: Added.
- fast/events/popup-blocking-click-in-iframe.html: Added.
- fast/events/resources/popup-blocking-click-in-iframe-otherFrame.html: Added.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 10:02 AM Changeset in webkit [39376] by
-
- 1 edit1 delete in trunk
2008-12-18 Pamela Greene <pam@chromium.org>
Submitted without review.
Right, remove the whole misplaced directory, not just the tests.
- fast: Removed.
- fast/dom: Removed.
- 9:56 AM Changeset in webkit [39375] by
-
- 2 edits2 moves in trunk
Root level:
2008-12-18 Pamela Greene <pam@chromium.org>
Submitted without review.
Moving layout test into LayoutTests where it belongs.
- fast/dom/setter-type-enforcement-expected.txt: Removed.
- fast/dom/setter-type-enforcement.html: Removed.
LayoutTests:
2008-12-18 Pamela Greene <pam@chromium.org>
Submitted without review.
Moving layout test from root level into LayoutTests where it belongs.
- fast/dom/setter-type-enforcement-expected.txt: Copied from fast/dom/setter-type-enforcement-expected.txt.
- fast/dom/setter-type-enforcement.html: Copied from fast/dom/setter-type-enforcement.html.
- 9:45 AM Changeset in webkit [39374] by
-
- 3 edits3 adds in trunk
2008-12-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin Barraclough.
Fixed https://bugs.webkit.org/show_bug.cgi?id=22393
Segfault when caching property accesses to primitive cells.
Changed some asObject casts to asCell casts in cases where a primitive
value may be a cell and not an object.
Re-enabled property caching for primitives in cases where it had been
disabled because of this bug.
Updated a comment to better explain something Darin thought needed
explaining in an old patch review.
- interpreter/Interpreter.cpp: (JSC::countPrototypeChainEntriesAndCheckForProxies): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::tryCTICacheGetByID): (JSC::Interpreter::cti_op_get_by_id_self_fail): (JSC::Interpreter::cti_op_get_by_id_proto_list):
LayoutTests:
2008-12-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin Barraclough.
Added a test for https://bugs.webkit.org/show_bug.cgi?id=22393
Segfault when caching property accesses to primitive cells.
- fast/js/primitive-property-access-edge-cases-expected.txt: Added.
- fast/js/primitive-property-access-edge-cases.html: Added.
- fast/js/resources/primitive-property-access-edge-cases.js: Added. ():
- 9:42 AM Changeset in webkit [39373] by
-
- 5 edits4 adds in trunk
2008-12-17 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Add the ability to compute clip rects independently from
caching them on the RenderLayer. When painting reflections, use
such temporarily computed clipRects, otherwise the layer may cache
clipRects which are invalid, since they have been computed with
a rootLayer that is not the one usually used to paint.
Test: fast/reflections/reflection-overflow-hidden.html
- 6:37 AM Changeset in webkit [39372] by
-
- 2 edits in trunk/WebCore
2008-12-17 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
Fix MinGW QtWebKit linking problems and also make the
QtWebKit build system more robust.
