⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 25, 2009:

11:04 PM Changeset in webkit [41243] by cwzwarich@webkit.org
  • 3 edits
    3 adds in trunk

2009-02-25 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Gavin Barraclough.

Bug 24086: Regression (r40993): WebKit crashes after logging in to lists.zenbe
<​https://bugs.webkit.org/show_bug.cgi?id=24086>
<rdar://problem/6625111>

The numeric sort optimization in r40993 generated bytecode for a function
without generating JIT code. This breaks an assumption in some parts of
the JIT's function calling logic that the presence of a CodeBlock implies
the existence of JIT code.

In order to fix this, we simply generate JIT code whenever we check whether
a function is a numeric sort function. This only incurs an additional cost
in the case when the function is a numeric sort function, in which case it
is not expensive to generate JIT code for it.

JavaScriptCore:

  • runtime/ArrayPrototype.cpp: (JSC::isNumericCompareFunction):

LayoutTests:

  • fast/js/resources/sort-no-jit-code-crash.js: Added.
  • fast/js/sort-no-jit-code-crash-expected.txt: Added.
  • fast/js/sort-no-jit-code-crash.html: Added.
8:31 PM Changeset in webkit [41242] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-02-25 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed build fix. Add WebCore/workers to the list of paths
searched by the bindings generator perl script.

  • GNUmakefile.am:
7:45 PM Changeset in webkit [41241] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-02-25 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Add canvas to the list of RenderObjects that can mark a page as
visually not empty.

  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
6:19 PM Changeset in webkit [41240] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-02-25 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dave Hyatt.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint): Remove assertion fired when child has layer as RenderMedia with controls always has a layer.
6:12 PM Changeset in webkit [41239] by Simon Fraser
  • 3 edits in trunk/WebKitTools

2009-02-25 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel

Fix spew about a WebView being deallocated while key value observers are
still registered with it by making sure that we always stop observing
_isUsingAcceleratedCompositing in -[DumpRenderTreeWindow close].

  • DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree):
  • DumpRenderTree/mac/DumpRenderTreeWindow.mm: (-[DumpRenderTreeWindow close]):
5:24 PM Changeset in webkit [41238] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Simon Fraser.

Test: fast/gradients/background-clipped.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Intersect the destination rectangle passed to drawTiledImage() with the dirty rectangle. This makes it more likely for the destination rect to be contained in a single tile rect, which results in a faster code path being taken down the road (just drawing a single tile instead of tiling).

LayoutTests:

Reviewed by Simon Fraser.

  • fast/gradients/background-clipped.html: Added.
  • platform/mac/fast/gradients/background-clipped-expected.checksum: Added.
  • platform/mac/fast/gradients/background-clipped-expected.png: Added.
  • platform/mac/fast/gradients/background-clipped-expected.txt: Added.
4:35 PM Changeset in webkit [41237] by eric@webkit.org
  • 8 edits in trunk

2009-02-25 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

Fix test regressions from positionForCoordinates patch.
​https://bugs.webkit.org/show_bug.cgi?id=24148

  • rendering/RenderBlock.cpp: (WebCore::positionForPointWithInlineChildren): Remove ASSERT that placeholder text codepath is hitting.
4:27 PM Changeset in webkit [41236] by Chris Fleizach
  • 21 edits
    2 adds in trunk

Bug 24143: Crash occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when applying a link in GMail
​https://bugs.webkit.org/show_bug.cgi?id=24143

When an AX object is marked dirty, do not create AX elements while going up the parent chain.
Do not allow AXRenderObjects to remove their own IDs from the cache, all the cache to do that work
Make sure the AXObjectWrapper's have an object before calling them
In AXObjectCache, change get -> getOrCreate. Use get() to only retrieve an element if it exists

4:16 PM Changeset in webkit [41235] by Beth Dakin
  • 2 edits in trunk/WebCore

2009-02-25 Beth Dakin <Beth Dakin>

Reviewed by Geoff Garen.

Re-working of <rdar://problem/6487249> repro crash in
WebCore::CSSParser::parseFillImage copying entire contents of this
page
-and corresponding: ​https://bugs.webkit.org/show_bug.cgi?id=24172

Fixes a bunch of layout test failures I caused!

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseContent): (WebCore::CSSParser::parseFillImage): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseBorderImage):
3:59 PM Changeset in webkit [41234] by Dimitri Glazkov
  • 1 edit
    8 adds in trunk/WebCore

2009-02-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24174
Add more V8 custom bindings.

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: Added. (WebCore::hasCSSPropertyNamePrefix): (WebCore::cssPropertyName): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_SETTER):
  • bindings/v8/custom/V8DOMStringListCustom.cpp: Added. (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8EventCustom.cpp: Added. (WebCore::ACCESSOR_SETTER): (WebCore::ACCESSOR_GETTER):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: Added. (WebCore::NAMED_PROPERTY_DELETER): (WebCore::NAMED_PROPERTY_SETTER): (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: Added. (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: Added. (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8NodeListCustom.cpp: Added. (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8StyleSheetListCustom.cpp: Added. (WebCore::NAMED_PROPERTY_GETTER):
3:52 PM Changeset in webkit [41233] by Dimitri Glazkov
  • 6 edits in trunk/WebCore

2009-02-25 Scott Violet <​sky@google.com>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=24171
Provides a RenderTheme method for getting the scroll bar size and
changes RenderListBox to use it. RenderTheme returns a size of regular,
and Mac's override to return small. Changes ScrollbarThemeChromium to
use the scrollbarsize of the scrollbar when getting the size
instead of passing in no-args.

  • platform/chromium/ScrollbarThemeChromium.cpp: (WebCore::ScrollbarThemeChromium::trackRect): (WebCore::ScrollbarThemeChromium::buttonSize):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::createScrollbar):
  • rendering/RenderTheme.h: (WebCore::RenderTheme::scrollbarControlSizeForPart):
  • rendering/RenderThemeChromiumMac.h: (WebCore::RenderThemeChromiumMac::scrollbarControlSizeForPart):
  • rendering/RenderThemeMac.h: (WebCore::RenderThemeMac::scrollbarControlSizeForPart):
3:44 PM Changeset in webkit [41232] by ggaren@apple.com
  • 12 edits
    3 adds in trunk

JavaScriptCore:

2009-02-25 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Fixed <rdar://problem/6611174> REGRESSION (r36701): Unable to select
messages on hotmail (24052)


The bug was that for-in enumeration used a cached prototype chain without
validating that it was up-to-date.


This led me to refactor prototype chain caching so it was easier to work
with and harder to get wrong.


After a bit of inlining, this patch is performance-neutral on SunSpider
and the v8 benchmarks.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::tryCachePutByID): (JSC::Interpreter::tryCacheGetByID):
  • jit/JITStubs.cpp: (JSC::JITStubs::tryCachePutByID): (JSC::JITStubs::tryCacheGetByID): (JSC::JITStubs::cti_op_get_by_id_proto_list): Use the new refactored goodness. See lines beginning with "-" and smile.
  • runtime/JSGlobalObject.h: (JSC::Structure::prototypeForLookup): A shout out to const.
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::next): We can use a pointer comparison to see if our cached structure chain is equal to the object's structure chain, since in the case of a cache hit, we share references to the same structure chain.
  • runtime/Operations.h: (JSC::countPrototypeChainEntriesAndCheckForProxies): Use the new refactored goodness.
  • runtime/PropertyNameArray.h: (JSC::PropertyNameArray::PropertyNameArray): (JSC::PropertyNameArray::setShouldCache): (JSC::PropertyNameArray::shouldCache): Renamed "cacheable" to "shouldCache" to communicate that the client is specifying a recommendation, not a capability.


  • runtime/Structure.cpp: (JSC::Structure::Structure): No need to initialize a RefPtr. (JSC::Structure::getEnumerablePropertyNames): Moved some code into helper functions.

(JSC::Structure::prototypeChain): New centralized accessor for a prototype
chain. Revalidates on every access, since the objects in the prototype
chain may have mutated.

(JSC::Structure::isValid): Helper function for revalidating a cached
prototype chain.

(JSC::Structure::getEnumerableNamesFromPropertyTable):
(JSC::Structure::getEnumerableNamesFromClassInfoTable): Factored out of
getEnumerablePropertyNames.

  • runtime/Structure.h:
  • runtime/StructureChain.cpp: (JSC::StructureChain::StructureChain):
  • runtime/StructureChain.h: (JSC::StructureChain::create): No need for structureChainsAreEqual, since we use pointer equality now. Refactored StructureChain to make a little more sense and eliminate special cases for null prototypes.

LayoutTests:

2009-02-24 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Added a test for <rdar://problem/6611174> REGRESSION (r36701): Unable to
select messages on hotmail (24052)

  • fast/js/for-in-cached-expected.txt: Added.
  • fast/js/for-in-cached.html: Added.
  • fast/js/resources/for-in-cached.js: Added. (forIn):
2:58 PM Changeset in webkit [41231] by Beth Dakin
  • 3 edits
    2 adds in trunk

WebCore:

2009-02-25 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

Fix for <rdar://problem/6487249> repro crash in
WebCore::CSSParser::parseFillImage copying entire contents of this
page
-and corresponding: ​https://bugs.webkit.org/show_bug.cgi?id=24172

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Null-check m_styleSheet

LayoutTests:

2009-02-25 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

Test for <rdar://problem/6487249> repro crash in
WebCore::CSSParser::parseFillImage copying entire contents of this
page
-and corresponding: ​https://bugs.webkit.org/show_bug.cgi?id=24172

  • editing/pasteboard/copy-crash-with-extraneous-attribute-expected.txt: Added.
  • editing/pasteboard/copy-crash-with-extraneous-attribute.html: Added.
1:37 PM Changeset in webkit [41230] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-02-25 Adam Treat <​adam.treat@torchmobile.com>

Fix the Qt build.

  • WebCore.pro:
12:59 PM Changeset in webkit [41229] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2009-02-25 Simon Fraser <Simon Fraser>

Build fix with ACCELERATED_COMPOSITING turned on.

I missed a spot in my last commit in renaming to
_stoppedAcceleratedCompositingForFrame:

  • WebView/WebHTMLView.mm: (-[WebHTMLView close]):
12:45 PM Changeset in webkit [41228] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

2009-02-25 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by Alexey Proskuryakov.

Do not queue the calls to 'DumpRenderTree::dump()' as this can result
in more than one call as a test that calls 'notifyDone()' can then be
subsequently fully loaded and initiate a second dump. Also make sure
to stop any existing page load that is happening before running the next
test. Combined this serves to produce 217 more passing tests for the
Qt port or roughly 5% at this point.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::open):
12:39 PM Changeset in webkit [41227] by jmalonzo@webkit.org
  • 3 edits in trunk/WebCore

2009-02-25 Jan Michael Alonzo <​jmalonzo@webkit.org>

Gtk build fix. Not reviewed.

Add files to the build per r41218.
Rename WebkitPoint.h to WebKitPoint.h in DOMWindow.cpp

  • GNUmakefile.am:
  • page/DOMWindow.cpp:
12:29 PM Changeset in webkit [41226] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-02-25 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=24043
When faced with URLs with unsupported protocol on Gtk port,
report the error through an idle function and return true, so
a proper resource handle is created.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::reportUnknownProtocolError): (WebCore::ResourceHandle::start):
12:22 PM Changeset in webkit [41225] by sfalken@apple.com
  • 16 edits in trunk/WebCore

Windows build fix.
Use struct to forward declare ResourceRequest.

  • history/HistoryItem.h:
  • inspector/InspectorController.h:
  • loader/DocumentThreadableLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.h:
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h:
  • loader/ThreadableLoader.h:
  • loader/WorkerThreadableLoader.h:
  • platform/CrossThreadCopier.h:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h:
  • platform/network/ResourceRequestBase.h:
  • platform/network/cf/ResourceRequestCFNet.h:
  • xml/XMLHttpRequest.h:
12:12 PM Changeset in webkit [41224] by Simon Fraser
  • 10 edits in trunk

2009-02-25 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

​https://bugs.webkit.org/show_bug.cgi?id=23854

Make an observable property, _isUsingAcceleratedCompositing, on
WebView that DumpRenderTree can use to specialize behavior.

This is implemented via a count of Frames that are using
accelerated compositing.

11:56 AM Changeset in webkit [41223] by alp@webkit.org
  • 4 edits in trunk/WebKit/win

2009-02-25 Andreia Gaita <​shana@jitted.com>

Reviewed by Alp Toker.

Update Win def files with recent JavaScriptCore API additions.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_Cairo.def:
  • WebKit.vcproj/WebKit_debug.def:
11:50 AM Changeset in webkit [41222] by sfalken@apple.com
  • 3 edits in trunk/WebCore

Partial Windows build fix.


  • DerivedSources.cpp:
  • WebCore.vcproj/WebCore.vcproj:
11:43 AM Changeset in webkit [41221] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-02-25 Dirk Schulze <​krit@webkit.org>

Reviewed by Oliver Hunt.

Ported arcTo to Qt. Qt has no native support for arcTo. This changes
calculate the behavior of arcTo and draws it with lineTo and arc.

[QT] implement Canvas arcTo
​https://bugs.webkit.org/show_bug.cgi?id=23873

  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArcTo):
11:29 AM Changeset in webkit [41220] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-02-25 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

Remove idl files from Resources, and sort.

  • WebCore.xcodeproj/project.pbxproj:
11:11 AM Changeset in webkit [41219] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Use timeBeginPeriod to enable timing resolution greater than 16ms in command line jsc for Windows.
Allows more accurate reporting of benchmark times via command line jsc.exe. Doesn't affect WebKit's use of JavaScriptCore.


Reviewed by Adam Roben.

  • jsc.cpp: (main):
11:09 AM Changeset in webkit [41218] by cmarrin@apple.com
  • 15 edits
    6 adds in trunk

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=23943

Added webkitConvertPointFromNodeToPage and webkitConvertPointFromPageToNode on
the window object. Also added WebKitPoint object, which is passed in and out
of these functions.

10:06 AM Changeset in webkit [41217] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-02-25 Jian Li <​jianli@chromium.org>

Reviewed by Alexey Proskuryakov.

Remove "#if ENABLE(WORKERS)" wrap from CrossThreadCopier files.
​https://bugs.webkit.org/show_bug.cgi?id=24145

  • platform/CrossThreadCopier.cpp:
  • platform/CrossThreadCopier.h:
10:06 AM Changeset in webkit [41216] by levin@chromium.org
  • 8 edits in trunk/WebCore

2009-02-25 David Levin <​levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 23688: ThreadableLoader needs a sync implementation for Workers.
<​https://bugs.webkit.org/show_bug.cgi?id=23688>

No observable change in behavior, so no test.

  • loader/ThreadableLoader.cpp: (WebCore::ThreadableLoader::loadResourceSynchronously):
  • loader/ThreadableLoaderClientWrapper.h: (WebCore::ThreadableLoaderClientWrapper::clearClient): (WebCore::ThreadableLoaderClientWrapper::done): (WebCore::ThreadableLoaderClientWrapper::didFinishLoading): (WebCore::ThreadableLoaderClientWrapper::didFail): (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck): (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper): Expose whether the loader is done (based on what callbacks were done).
  • loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): (WebCore::WorkerThreadableLoader::loadResourceSynchronously): Each loader is given its own mode so that only its callbacks get through the run loop.

The xhr spec says that the readystatechange events are synchronous, so in the case of a
nested sync xhr no readystatechange events should be fired for the outer xhr.

(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):

  • loader/WorkerThreadableLoader.h: (WebCore::WorkerThreadableLoader::create): (WebCore::WorkerThreadableLoader::done):
  • workers/WorkerRunLoop.cpp: (WebCore::WorkerRunLoop::WorkerRunLoop):
  • workers/WorkerRunLoop.h: (WebCore::WorkerRunLoop::createUniqueId): Simple method to create a uniqueId on demand with respect to the run loop.
  • workers/WorkerThread.h:
10:06 AM Changeset in webkit [41215] by levin@chromium.org
  • 10 edits in trunk

WebCore:

2009-02-25 David Levin <​levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24089: ThreadableLoader::loadResourceSynchronously should do callbacks like the async code.
<​https://bugs.webkit.org/show_bug.cgi?id=24089>

Make threadable loader callbacks to happen during the sync load call.

Changes the behavior of sync xhr for insecure redirects in two ways:
+ Sends an error event instead of an abort event (which is the same as async xhr's behavior).
+ Throws a network exception which is what other browsers do and what the spec
says to do (​http://www.w3.org/TR/XMLHttpRequest/).

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadResourceSynchronously):
  • loader/DocumentThreadableLoader.h:
  • loader/ThreadableLoader.cpp: (WebCore::ThreadableLoader::loadResourceSynchronously):
  • loader/ThreadableLoader.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::loadRequestSynchronously): (WebCore::XMLHttpRequest::loadRequestAsynchronously): (WebCore::XMLHttpRequest::didFail): (WebCore::XMLHttpRequest::didFailRedirectCheck):
  • xml/XMLHttpRequest.h:

LayoutTests:

2009-02-25 David Levin <​levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24089: ThreadableLoader::loadResourceSynchronously should do callbacks like the async code.
<​https://bugs.webkit.org/show_bug.cgi?id=24089>

Modified the test to account for behavior change and output more information to better detect
future changes in behavior.

  • http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect-expected.txt:
  • http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html:
9:55 AM Changeset in webkit [41214] by cmarrin@apple.com
  • 5 edits
    8 adds in trunk

Reviewed by David Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=23368

Added logic to correctly hit test accelerated layers.

9:01 AM Changeset in webkit [41213] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24067
REGRESSION: Crash in WebCore::Document::initSecurityContext

The crash started to happen when we removed a check for frame->document() being null.
However, the original document shouldn't be null here, because it is needed to alias
security origins. So, this patch fixes the crash by correcting security origin behavior.

Test: http/tests/security/aboutBlank/window-open-self-about-blank.html
This tests for not crashing, and for inheriting the domain from the document being replaced.
Preserving the aliasing cannot be tested for automatically, because we'd need a non-trivial
domain to remove a prefix from.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Create a new document before clearing the frame, so that Document::initSecurityContext() could access the old one.
8:58 AM Changeset in webkit [41212] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-02-25 Jay Campan <​jcampan@google.com>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=24066

Items in drop-downs were not painted correctly. Makes sure the
PopupListBox invalidates in the coordinates of the window as this is
FramelessScrollView::invalidateRect paints to.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::invalidateRow):
8:14 AM QtWebKitContrib edited by henrique@bastos.net
added Zack Rusin's irc nickname (diff)
6:12 AM Changeset in webkit [41211] by treat@webkit.org
  • 8 edits
    3 adds in trunk

2009-02-25 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by Zack Rusin.

​https://bugs.webkit.org/show_bug.cgi?id=24158
Implement the queue*() methods of the layoutTestController and begin
implementing the dump of the back/forward list. This results in 2% more
tests passing as well as 23 currently skipped tests now passing.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::dumpBackForwardList): (WebCore::DumpRenderTree::dump):
  • DumpRenderTree/qt/DumpRenderTree.h:
  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/jsobjects.cpp: (findFrameNamed): (LoadItem::invoke): (ReloadItem::invoke): (ScriptItem::invoke): (BackForwardItem::invoke): (LayoutTestController::reset): (LayoutTestController::processWork): (LayoutTestController::maybeDump): (LayoutTestController::queueBackNavigation): (LayoutTestController::queueForwardNavigation): (LayoutTestController::queueLoad): (LayoutTestController::queueReload): (LayoutTestController::queueScript):
  • DumpRenderTree/qt/jsobjects.h: (LayoutTestController::shouldDumpBackForwardList): (LayoutTestController::dumpBackForwardList):
4:12 AM Changeset in webkit [41210] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-02-25 Kavindra Palaraja <​kavindra.palaraja@nokia.com>

Reviewed by Simon Hausmann.

Fix the documentation for the linkHovered signal.

  • Api/qwebpage.cpp:

Feb 24, 2009:

10:18 PM Changeset in webkit [41209] by Simon Fraser
  • 6 edits
    13 adds in trunk

2009-02-24 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson

​https://bugs.webkit.org/show_bug.cgi?id=15081

Make display:none work for applet, emebed and object elements
by calling rendererIsNeeded() on superclasses.

Tests: fast/replaced/applet-display-none.html

fast/replaced/embed-display-none.html
fast/replaced/object-display-none.html

  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::rendererIsNeeded):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::rendererIsNeeded):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::rendererIsNeeded):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::rendererIsNeeded):
6:50 PM Changeset in webkit [41208] by Simon Fraser
  • 24 edits
    2 adds in trunk/WebCore

2009-02-24 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=24137

Fix localToAbsolute() and absoluteToLocal() to map points through 3d transforms,
taking perspective and transform-style: preserve-3d into account.

In order to support transform-style: preserve-3d, which keeps elements in a
3d space, we have to carry along an accumulated matrix in TransformState.
We also need to apply the perspective from the parent, if any, with the
appropriate origin.

6:38 PM Changeset in webkit [41207] by weinig@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2009-02-24 Sam Weinig <​sam@webkit.org>

Reviewed by David Hyatt.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=23990
Regression (r40837): JavaScript image popup doesn't work

Make the getClientRects and getBoundingClientRect methods return rects
relative to the viewport.

Test: fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html

  • dom/Element.cpp: (WebCore::Element::getClientRects): (WebCore::Element::getBoundingClientRect):

LayoutTests:

2009-02-24 Sam Weinig <​sam@webkit.org>

Reviewed by David Hyatt.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=23990
Regression (r40837): JavaScript image popup doesn't work

  • fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt: Added.
  • fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html: Added.
5:46 PM Changeset in webkit [41206] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-02-24 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

SVG pages don't have a body or an html element!
Don't return early if there is no body.

  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition):
5:34 PM Changeset in webkit [41205] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/fast/block/float/033-expected.txt

Update some layout test results from my previous checkin.

5:33 PM Changeset in webkit [41204] by hyatt@apple.com
  • 3 edits in trunk/LayoutTests/platform/mac/fast/repaint

Update some layout test results from my previous checkin.

5:21 PM Changeset in webkit [41203] by hyatt@apple.com
  • 18 edits
    8 adds in trunk

WebCore:

2009-02-23 David Hyatt <​hyatt@apple.com>

Reviewed by Eric Seidel

​https://bugs.webkit.org/show_bug.cgi?id=23740, painting order wrong for normal flow elements with overflow: hidden


This patch reworks the painting of overflow. There is now the concept of a "self-painting layer." All
layers are considered to be self-painting except for overflow layers that are normal flow (and that don't have
reflections or masks).


If an overflow layer is not self-painting, then it ends up painted by its parent just like any other normal flow object.
The only difference is that the clip has to be pushed and popped when painting the object's children.


The lightweight clipping scheme used for controls has been extended to cover overflow now in this simplified case. With
the code consolidated into reusable push/pop functions, all of the renderers that use overflow have been patched to
use the new functions.


Hit testing has also been patched to check the overflow clip rect first before recurring into children.


Scrollbar paint has been moved into RenderBlock for now, since none of the table objects support scrollbars
yet, and scrollbar hit testing was already there anyway. Now the two code paths are more symmetrical.


Masks are now treated like normal flow layers (just like reflections).

A couple of test cases have been added to fast/overflow to test the stacking order.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint): (WebCore::InlineFlowBox::paint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::repaintOverhangingFloats): (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintFloats): (WebCore::RenderBlock::insertFloatingObject): (WebCore::RenderBlock::floatRect): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::addOverhangingFloats): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestContents):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint): (WebCore::RenderBox::pushContentsClip): (WebCore::RenderBox::popContentsClip):
  • rendering/RenderBox.h: (WebCore::RenderBox::paintObject):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::hasSelfPaintingLayer):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::shouldBeNormalFlowOnly): (WebCore::RenderLayer::isSelfPaintingLayer):
  • rendering/RenderLayer.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint): (WebCore::RenderTable::paintObject): (WebCore::RenderTable::nodeAtPoint):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint): (WebCore::RenderTableRow::paint):
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint): (WebCore::RenderTableSection::paintObject): (WebCore::RenderTableSection::nodeAtPoint):
  • rendering/RenderTableSection.h:
  • rendering/RenderTreeAsText.cpp: (WebCore::write): (WebCore::writeLayers):

LayoutTests:

2009-02-24 David Hyatt <​hyatt@apple.com>

Reviewed by Eric Seidel

​https://bugs.webkit.org/show_bug.cgi?id=23740, painting order wrong for normal flow elements with overflow: hidden


This patch reworks the painting of overflow. There is now the concept of a "self-painting layer." All
layers are considered to be self-painting except for overflow layers that are normal flow (and that don't have
reflections or masks).


If an overflow layer is not self-painting, then it ends up painted by its parent just like any other normal flow object.
The only difference is that the clip has to be pushed and popped when painting the object's children.


The lightweight clipping scheme used for controls has been extended to cover overflow now in this simplified case. With
the code consolidated into reusable push/pop functions, all of the renderers that use overflow have been patched to
use the new functions.


Hit testing has also been patched to check the overflow clip rect first before recurring into children.


Scrollbar paint has been moved into RenderBlock for now, since none of the table objects support scrollbars
yet, and scrollbar hit testing was already there anyway. Now the two code paths are more symmetrical.


Masks are now treated like normal flow layers (just like reflections).


A couple of test cases have been added to fast/overflow to test the stacking order.

  • fast/overflow/overflow-float-stacking.html: Added.
  • fast/overflow/overflow-stacking.html: Added.
  • platform/mac/fast/overflow/overflow-float-stacking-expected.checksum: Added.
  • platform/mac/fast/overflow/overflow-float-stacking-expected.png: Added.
  • platform/mac/fast/overflow/overflow-float-stacking-expected.txt: Added.
  • platform/mac/fast/overflow/overflow-stacking-expected.checksum: Added.
  • platform/mac/fast/overflow/overflow-stacking-expected.png: Added.
  • platform/mac/fast/overflow/overflow-stacking-expected.txt: Added.
5:05 PM Changeset in webkit [41202] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-02-24 David Levin <​levin@chromium.org>

Reviewed by NOBODY (build fix).

Attempted build fix for wx-mac.

  • WebCoreSources.bkl:
4:54 PM Changeset in webkit [41201] by Simon Fraser
  • 2 edits in trunk/LayoutTests

2009-02-24 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel

​https://bugs.webkit.org/show_bug.cgi?id=24135

Update the expected value after testcase change.

  • fast/events/offsetX-offsetY-expected.txt:
4:46 PM Changeset in webkit [41200] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-02-24 David Levin <​levin@chromium.org>

Reviewed by NOBODY (build fix).

Attempted build fixes for qt-linux and wx-mac.

  • WebCore.pro:
  • webcore-base.bkl:
4:32 PM Changeset in webkit [41199] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-02-24 Ojan Vafai <​ojan@chromium.org>

Reviewed by Sam Weinig

Fix null pointer error. If the node is the Document, then ownerDocument()
returns null, document() does not.

  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition):
4:20 PM Changeset in webkit [41198] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-02-24 Jian Li <​jianli@chromium.org>

Reviewed by NOBODY (attempted build fixes).

Fix build break for Windows and Linux.

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
4:18 PM Changeset in webkit [41197] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-02-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24131
Fix-up COM/RefCounted dichotomy in Chromium port.

  • page/chromium/AccessibilityObjectWrapper.h: (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper): Added explicit setting of recount.
4:13 PM Changeset in webkit [41196] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-02-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24141
Add clarity to V8 interceptor helper function.

  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): Renamed to notHandledByInterceptor. (WebCore::NAMED_PROPERTY_SETTER): Ditto. (WebCore::INDEXED_PROPERTY_GETTER): Ditto. (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
3:57 PM Changeset in webkit [41195] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-02-24 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel

Minor numeric cleanup: convert float literals to doubles.

  • platform/graphics/transforms/RotateTransformOperation.cpp: (WebCore::RotateTransformOperation::blend):
3:22 PM Changeset in webkit [41194] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-02-24 Mark Mentovai <​mark@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24139
Add missing include.

  • bindings/v8/ScriptInstance.h:
3:16 PM Changeset in webkit [41193] by levin@chromium.org
  • 8 edits
    20 moves
    1 add in trunk/WebCore

2009-02-24 Jian Li <​jianli@chromium.org>

Reviewed by Alexey Proskuryakov.

Move worker related files from dom directory to worker directory under WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=24123

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.scons:
  • WebCore.vcproj/MigrateIDLAndScripts:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/CrossThreadCopier.cpp: Renamed from WebCore/dom/CrossThreadCopier.cpp.
  • platform/CrossThreadCopier.h: Renamed from WebCore/dom/CrossThreadCopier.h.
  • workers/GenericWorkerTask.h: Renamed from WebCore/dom/GenericWorkerTask.h.
  • workers/Worker.cpp: Renamed from WebCore/dom/Worker.cpp.
  • workers/Worker.h: Renamed from WebCore/dom/Worker.h.
  • workers/Worker.idl: Renamed from WebCore/dom/Worker.idl.
  • workers/WorkerContext.cpp: Renamed from WebCore/dom/WorkerContext.cpp.
  • workers/WorkerContext.h: Renamed from WebCore/dom/WorkerContext.h.
  • workers/WorkerContext.idl: Renamed from WebCore/dom/WorkerContext.idl.
  • workers/WorkerContextProxy.h: Renamed from WebCore/dom/WorkerContextProxy.h.
  • workers/WorkerLocation.cpp: Renamed from WebCore/dom/WorkerLocation.cpp.
  • workers/WorkerLocation.h: Renamed from WebCore/dom/WorkerLocation.h.
  • workers/WorkerLocation.idl: Renamed from WebCore/dom/WorkerLocation.idl.
  • workers/WorkerMessagingProxy.cpp: Renamed from WebCore/dom/WorkerMessagingProxy.cpp.
  • workers/WorkerMessagingProxy.h: Renamed from WebCore/dom/WorkerMessagingProxy.h.
  • workers/WorkerObjectProxy.h: Renamed from WebCore/dom/WorkerObjectProxy.h.
  • workers/WorkerRunLoop.cpp: Renamed from WebCore/dom/WorkerRunLoop.cpp.
  • workers/WorkerRunLoop.h: Renamed from WebCore/dom/WorkerRunLoop.h.
  • workers/WorkerThread.cpp: Renamed from WebCore/dom/WorkerThread.cpp.
  • workers/WorkerThread.h: Renamed from WebCore/dom/WorkerThread.h.
2:57 PM Changeset in webkit [41192] by Simon Fraser
  • 3 edits in trunk/WebCore

2009-02-24 Simon Fraser <Simon Fraser>

Fix build when ACCELERATED_COMPOSITING is turned on
(overflowList() -> normalFlowList()).

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::hasNonCompositingContent): (WebCore::RenderLayerBacking::paintIntoLayer):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds): (WebCore::RenderLayerCompositor::computeCompositingRequirements): (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect): (WebCore::RenderLayerCompositor::layerHas3DContent):
2:28 PM Changeset in webkit [41191] by eric@webkit.org
  • 8 edits
    12 adds
    5 deletes in trunk

2009-02-05 Ojan Vafai <​ojan@chromium.org> and Eric Seidel <​eric@webkit.org>

Reviewed by Dave Hyatt.

Make cursor positions match IE6/IE7/FF3 when clicking in margins/padding
around divs inside editable regions.
​https://bugs.webkit.org/show_bug.cgi?id=23605

Fix clicks outside editable regions from focusing the editable region.
​https://bugs.webkit.org/show_bug.cgi?id=23607

Removed editing/selection/contenteditable-click-outside.html as it's
not as useful as our new tests.

Clean up RenderBlock::positionForCoordinates to remove dead code,
duplicate code, and generally make it more readable.

Tests: editing/selection/click-in-margins-inside-editable-div.html

editing/selection/click-in-padding-with-multiple-line-boxes.html
editing/selection/click-outside-editable-div.html

  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition):
  • rendering/RenderBlock.cpp: (WebCore::positionForPointRespectingEditingBoundaries): (WebCore::positionForPointWithInlineChildren): (WebCore::RenderBlock::positionForCoordinates): (WebCore::RenderBlock::updateFirstLetter):
2:22 PM Changeset in webkit [41190] by weinig@apple.com
  • 13 edits in trunk

WebCore:

2009-02-24 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Related to <rdar://problem/6590295>
Allow disabling javascript: urls.

  • WebCore.base.exp:
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::parseMappedAttribute):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::executeIfJavaScriptURL):
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::setJavaScriptURLsAreAllowed): (WebCore::Page::javaScriptURLsAreAllowed):
  • page/Page.h:

WebKit/mac:

2009-02-24 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Related to <rdar://problem/6590295>
Allow disabling javascript: urls.

  • WebView/WebView.mm: (-[WebView _setJavaScriptURLsAreAllowed:]):
  • WebView/WebViewPrivate.h:

WebKit/win:

2009-02-24 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Related to <rdar://problem/6590295>
Allow disabling javascript: urls.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp: (WebView::setJavaScriptURLsAreAllowed):
  • WebView.h:
2:19 PM Changeset in webkit [41189] by Simon Fraser
  • 4 edits in trunk

2009-02-24 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

​https://bugs.webkit.org/show_bug.cgi?id=24135

Round the FloatPoint returned by absoluteToLocal(), rather than
truncating it.

  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::receivedTarget):
1:34 PM Changeset in webkit [41188] by Beth Dakin
  • 5 edits
    4 adds in trunk

WebCore:

2009-02-24 Beth Dakin <Beth Dakin>

Reviewed by Sam Weinig.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=24004 REGRESSION:
Ordered list item marker misaligned when line height is not 1.2
-and corresponding <rdar://problem/6602506>

This is a regression from ​http://trac.webkit.org/changeset/40880
where createInlineBox was taken off of RenderObject and moved to
RenderBox. The problem was that the RenderBox version still needs
to be virtual because there is still an existing implementation in
RenderListMarker.

  • rendering/RenderBox.h:
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::createInlineBox):
  • rendering/RenderListMarker.h:

LayoutTests:

2009-02-24 Beth Dakin <Beth Dakin>

Reviewed by Sam Weinig.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=24004 REGRESSION:
Ordered list item marker misaligned when line height is not 1.2
-and corresponding <rdar://problem/6602506>

  • fast/lists/list-marker-with-line-height.html: Added.
  • platform/mac/fast/lists/list-marker-with-line-height-expected.checksum: Added.
  • platform/mac/fast/lists/list-marker-with-line-height-expected.png: Added.
  • platform/mac/fast/lists/list-marker-with-line-height-expected.txt: Added.
12:47 PM Changeset in webkit [41187] by Adam Roben
  • 3 edits in trunk/WebKit/win

Windows build fix

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def: Export WTF::ThreadCondition::timedWait.
12:23 PM Changeset in webkit [41186] by Dimitri Glazkov
  • 1 edit
    6 adds in trunk/WebCore

2009-02-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24128
Upstream more V8 custom bindings: constructors, XSLTProcessor.

  • bindings/v8/custom/V8DOMParserConstructor.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8MessageChannelConstructor.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8XMLSerializerConstructor.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8XPathEvaluatorConstructor.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
11:46 AM Changeset in webkit [41185] by treat@webkit.org
  • 2 edits in trunk/LayoutTests

2009-02-24 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by Simon Fraser.

Adding these tests back in and removing from the Skipped list as
these tests are all now passing on my machine as of latest revision.

  • platform/qt/Skipped:
10:54 AM Changeset in webkit [41184] by levin@chromium.org
  • 6 edits in trunk/WebCore

2009-02-24 David Levin <​levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24090: WorkerThreadableLoader needs to be able to post tasks for a mode.
<​https://bugs.webkit.org/show_bug.cgi?id=24090>

No observable change in behavior, so no test.

  • dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::postMessageToWorkerContext): (WebCore::WorkerMessagingProxy::postTaskToWorkerContext): Fixed the bug that m_unconfirmedMessageCount was getting incremented for non-message tasks.

(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):

  • dom/WorkerMessagingProxy.h:
  • loader/ThreadableLoader.cpp: (WebCore::ThreadableLoader::create):
  • loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData): (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse): (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck): (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation): Changed these methods to post task using a mode.
  • loader/WorkerThreadableLoader.h: (WebCore::WorkerThreadableLoader::create):
10:17 AM Changeset in webkit [41183] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

2009-02-24 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by Alexey Proskuryakov.

Don't print out that you are generating new results if you are not in fact
generating new results and disable generating new results by default for
the all ports other than the canonical Apple Mac port since this can litter
the source directory with hundreds of new results since other ports
are not as up to date.

  • Scripts/run-webkit-tests:
8:33 AM Changeset in webkit [41182] by mrowe@apple.com
  • 4 copies
    1 add in releases/Apple/Safari 4 Public Beta

Tag the Safari 4 Public Beta release.

This release consists of JavaScriptCore-x528.15, JavaScriptGlue-x528.15, WebCore-x528.16 and WebKit-x528.16.

8:23 AM Changeset in webkit [41181] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

2009-02-24 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by Cameron Zwarich.

The Qt port does not support these yet nor does the nm check work with
QMake based build.

  • Scripts/webkitdirs.pm:
8:12 AM Changeset in webkit [41180] by treat@webkit.org
  • 2 edits in trunk/LayoutTests

2009-02-24 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by Cameron Zwarich.

Remove tests from the Qt Skipped list that no longer even exist.

  • platform/qt/Skipped:
7:23 AM Changeset in webkit [41179] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-02-24 Geoffrey Garen <​ggaren@apple.com>

Build fix?

  • GNUmakefile.am:
5:42 AM Changeset in webkit [41178] by ap@webkit.org
  • 3 edits
    4 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24091
<rdar://problem/6468660> Start of redirect chain ends up as master entry in Application Cache

Test: http/tests/appcache/access-via-redirect.php

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): Use the URL we ended up with, not the original one.
5:26 AM Changeset in webkit [41177] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptGlue

<rdar://problem/6407844> JavaScriptGlue should use -Os rather than -O2

Rubber-stamped by Dan Bernstein.

  • Configurations/Base.xcconfig:
4:35 AM Changeset in webkit [41176] by mrowe@apple.com
  • 11 edits in trunk

<rdar://problem/6259220> Rename AVAILABLE_AFTER_WEBKIT_VERSION_3_1 (etc.) to match the other macros

Reviewed by Oliver Hunt.

  • API/JSBasePrivate.h:
  • API/JSContextRef.h:
  • API/JSObjectRef.h:
  • API/WebKitAvailability.h:
  • Carbon/CarbonUtils.h:
  • Carbon/HIWebView.h:
  • Plugins/WebPlugin.h:
  • Plugins/WebPluginViewFactory.h:
  • WebView/WebUIDelegate.h:
2:21 AM Changeset in webkit [41175] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Reviewed by Mark Rowe ("awesome!").

Make test for <​https://bugs.webkit.org/show_bug.cgi?id=15707> more reliable.

  • fast/dom/onload-open.html: Added waitUntilDone().
1:44 AM Changeset in webkit [41174] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-02-24 Jian Li <​jianli@chromium.org>

Reviewed by Alexey Proskuryakov.

Change to include WorkerObjectProxy.h instead of WorkerMessagingProxy.h in WorkerContext.cpp and WorkerScriptController.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=24112

  • bindings/js/WorkerScriptController.cpp:
  • dom/WorkerContext.cpp:
1:39 AM Changeset in webkit [41173] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

2009-02-24 Peter Ammon <​pammon@apple.com>

Reviewed by Mark Rowe.

Fix <rdar://problem/6251410> Services can modify non-editable content in Safari

  • WebView/WebHTMLView.mm: (-[WebHTMLView validRequestorForSendType:returnType:]): Return self only if we can handle both the send and return type. We should also handle a nil send or return type by ignoring the argument and returning whether we can handle the other type passed in.
1:22 AM Changeset in webkit [41172] by jmalonzo@webkit.org
  • 4 edits in trunk

[Gtk] add options for 3D transforms and HTML5 channel messaging to the build
​https://bugs.webkit.org/show_bug.cgi?id=24072

Reviewed by Alexey Proskuryakov.

Add options for toggling 3D transforms and HTML5 channel messaging
support on or off.

Also fix the web-workers option. It should be web-workers and not workers.

  • configure.ac:

Allow toggling of 3D transforms and HTML5 channel messaging
support for the Autotools (Gtk) build.

Also add '--gtk' in the build-webkit help doc and fix autotools
option for web-workers support.

  • Scripts/build-webkit:
12:57 AM Changeset in webkit [41171] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

2009-02-24 David Levin <​levin@chromium.org>

Reviewed by Dave Hyatt.

Update expected results due to better results introduced by r41090.

  • platform/mac/media/video-layer-crash-expected.txt:
Note: See TracTimeline for information about the timeline view.