Timeline
Mar 4, 2009:
- 11:28 PM Changeset in webkit [41444] by
-
- 2 edits in trunk/WebKit/mac
<rdar://problem/6206172> Adoption of new Cocoa API for dictionary contextual menu
Reviewed by Dan Bernstein.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _lookUpInDictionaryFromMenu:]):
- 10:04 PM Changeset in webkit [41443] by
-
- 3 edits in trunk/JavaScriptCore
<rdar://problem/6354858> FastMallocZone's enumeration code reports fragmented administration space
Reviewed by Oliver Hunt.
The handling of MALLOC_ADMIN_REGION_RANGE_TYPE in FastMalloc's zone was incorrect. It was attempting
to record the memory containing and individual span as an administrative region, when all memory
allocated via MetaDataAlloc should in fact be recorded. This was causing memory regions allocated
via MetaDataAlloc to appear as "VM_ALLOCATE ?" in vmmap output. They are now correctly reported as
"MALLOC_OTHER" regions associated with the JavaScriptCore FastMalloc zone.
Memory is allocated via MetaDataAlloc from two locations: PageHeapAllocator, and TCMalloc_PageMap{2,3}.
These two cases are handled differently.
PageHeapAllocator is extended to keep a linked list of memory regions that it has allocated. The
first object in an allocated region contains the link to the previously allocated region. To record
the administrative regions of a PageHeapAllocator we can simply walk the linked list and record
each allocated region we encounter.
TCMalloc_PageMaps allocate memory via MetaDataAlloc to store each level of the radix tree. To record
the administrative regions of a TCMalloc_PageMap we walk the tree and record the storage used for nodes
at each position rather than the nodes themselves.
A small performance improvement is achieved by coalescing adjacent memory regions inside the PageMapMemoryUsageRecorder
so that fewer calls in to the range recorder are necessary. We further reduce the number of calls to the
range recorder by aggregating the in-use ranges of a given memory region into a local buffer before recording
them with a single call. A similar approach is also used by AdminRegionRecorder.
- wtf/FastMalloc.cpp:
(WTF::PageHeapAllocator::Init):
(WTF::PageHeapAllocator::New):
(WTF::PageHeapAllocator::recordAdministrativeRegions):
(WTF::TCMallocStats::FreeObjectFinder::isFreeObject):
(WTF::TCMallocStats::PageMapMemoryUsageRecorder::~PageMapMemoryUsageRecorder):
(WTF::TCMallocStats::PageMapMemoryUsageRecorder::recordPendingRegions):
(WTF::TCMallocStats::PageMapMemoryUsageRecorder::visit):
(WTF::TCMallocStats::AdminRegionRecorder::AdminRegionRecorder):
(WTF::TCMallocStats::AdminRegionRecorder::recordRegion):
(WTF::TCMallocStats::AdminRegionRecorder::visit):
(WTF::TCMallocStats::AdminRegionRecorder::recordPendingRegions):
(WTF::TCMallocStats::AdminRegionRecorder::~AdminRegionRecorder):
(WTF::TCMallocStats::FastMallocZone::enumerate):
(WTF::TCMallocStats::FastMallocZone::FastMallocZone):
(WTF::TCMallocStats::FastMallocZone::init):
- wtf/TCPageMap.h:
(TCMalloc_PageMap2::visitValues):
(TCMalloc_PageMap2::visitAllocations):
(TCMalloc_PageMap3::visitValues):
(TCMalloc_PageMap3::visitAllocations):
- 7:10 PM Changeset in webkit [41442] by
-
- 2 edits2 adds in trunk/SunSpider
Added a few more tests to ubench
RS=Gavin Barraclough
Adding a couple of test to cover too few and too many arguments. This
is needed to prevent regressions in all call paths from my current refactoring.
- 6:36 PM Changeset in webkit [41441] by
-
- 2 edits in trunk/WebCore
2009-03-04 Simon Fraser <Simon Fraser>
Reviewed by Eric Seidel
If an element has backface-visibility: hidden, hit testing should not
hit the back sides of elements. Test for that by inverting the accumulated
transform and looking at the z vector.
Tested by transforms/3d/hit-testing/backface-hit-test.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):
- 6:11 PM Changeset in webkit [41440] by
-
- 1 edit21 adds in trunk/LayoutTests
2009-03-04 Simon Fraser <Simon Fraser>
Rubber-stamped by Eric Seidel.
New layout tests for point mapping and hit testing through 3d transforms.
Not run by default yet.
- platform/mac/transforms/3d/hit-testing/backface-hit-test-expected.txt: Added.
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt: Added.
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt: Added.
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt: Added.
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt: Added.
- platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt: Added.
- transforms/3d/cssmatrix-3d-interface-expected.txt: Added.
- transforms/3d/cssmatrix-3d-interface.xhtml: Added.
- transforms/3d/hit-testing/backface-hit-test.html: Added.
- transforms/3d/point-mapping/3d-point-mapping-2.html: Added.
- transforms/3d/point-mapping/3d-point-mapping-deep.html: Added.
- transforms/3d/point-mapping/3d-point-mapping-origins.html: Added.
- transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html: Added.
- transforms/3d/point-mapping/3d-point-mapping.html: Added.
- transforms/3d/point-mapping/point-mapping-helpers.js: Added. (mousemoved): (dispatchEvent): (clicked): (log): (runTest):
- 5:13 PM Changeset in webkit [41439] by
-
- 2 edits in trunk/LayoutTests
2009-03-04 Eric Carlson <eric.carlson@apple.com>
- Correct bogus result checked in as part of r41432.
- media/video-can-play-type-expected.txt:
- 4:57 PM Changeset in webkit [41438] by
-
- 2 edits in trunk/WebCore
2009-03-04 Adam Langley <agl@google.com>
Reviewed by Darin Fisher.
r41362 mistakenly added functions "RenderThemeWin::" into
RenderThemeChromiumGtk.cpp. When correcting this, I somehow changed
them to void return types. This patch switches them back to ints.
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingLeft): (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingRight): (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingTop): (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingBottom):
- 4:57 PM Changeset in webkit [41437] by
-
- 3 edits in trunk/WebCore
2009-03-04 Adam Langley <agl@google.com>
Reviewed by Darin Fisher.
Chromium Linux: change some metrics to better match Windows after
r41416. Aesthetically this may be worse, but web-compat is king.
Also, the previous code had an off by one error when drawing
scrollbars which caused the scrollbar to overflow it's bounds by 1px
at the right and bottom edges.
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::): (WebCore::RenderThemeChromiumLinux::systemFont):
- platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromium::paintTrackPiece):
- 3:48 PM Changeset in webkit [41436] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-03-04 Pamela Greene <pam@chromium.org>
Reviewed by Darin Fisher.
Add test to ensure that window.frames is self-referential
https://bugs.webkit.org/show_bug.cgi?id=24341
- fast/dom/Window/window-frames-self-referential-expected.txt: Added.
- fast/dom/Window/window-frames-self-referential.html: Added.
- 2:58 PM Changeset in webkit [41435] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben.
Add an ASSERT to better demonstrate the cause of the crash in
https://bugs.webkit.org/show_bug.cgi?id=23736
- loader/DocLoader.cpp: (WebCore::DocLoader::~DocLoader):
- 2:29 PM Changeset in webkit [41434] by
-
- 3 edits5 adds in trunk
WebCore:
2009-03-04 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
<https://bugs.webkit.org/show_bug.cgi?id=24337>
Tests: http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html
- loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willCacheResponse): An identifier is only asssigned if resource load callbacks are done. So don't send willCacheResponse which uses identifier if resource load callbacks aren't being sent.
LayoutTests:
2009-03-04 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
<https://bugs.webkit.org/show_bug.cgi?id=24337>
- http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html: Added.
- http/tests/xmlhttprequest/workers/resources/xmlhttprequest-file-not-found.js: Added. (log): (done):
- http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found-expected.txt: Added.
- http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html: Added.
- 2:29 PM Changeset in webkit [41433] by
-
- 4 edits4 adds in trunk
WebCore:
2009-03-04 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Bug 24330: Sync xhr in workers should send an abort exception when the worker is terminated.
<https://bugs.webkit.org/show_bug.cgi?id=24330>
Test: http/tests/xmlhttprequest/workers/abort-exception-assert.html
- dom/ExceptionCode.cpp: (WebCore::xmlHttpRequestExceptionNames): Added missing ABORT_ERR whose absence caused an assert.
- loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::loadResourceSynchronously): (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel): Add more logic to handle the termination case for sync xhr.
LayoutTests:
2009-03-04 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Bug 24330: Sync xhr in workers should send an abort exception when the worker is terminated.
<https://bugs.webkit.org/show_bug.cgi?id=24330>
Added test to verify to terminate a worker while it is doing a synchronous xhr.
It does not verify that the exception is a ABORT_ERR because I couldn't figure out a way
to actually do this.
- http/tests/xmlhttprequest/workers/abort-exception-assert-expected.txt: Added.
- http/tests/xmlhttprequest/workers/abort-exception-assert.html: Added.
- http/tests/xmlhttprequest/workers/resources/endless-response.php: Copied from LayoutTests/http/tests/xmlhttprequest/resources/endlessxml.php.
- http/tests/xmlhttprequest/workers/resources/endless-sync-xhr.js: Added.
- 2:21 PM Changeset in webkit [41432] by
-
- 8 edits2 adds in trunk
2009-03-04 Eric Carlson <eric.carlson@apple.com>
Reviewed by Antti Koivisto.
https://bugs.webkit.org/show_bug.cgi?id=24364
Add support for HTMLMediaElement canPlayType method. Make
MediaPlayer::supportsType take a ContentType instead of a
separate mime type and codecs parameter.
Test: media/video-can-play-type.html
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::canPlayType): Add canPlayType method. (WebCore::HTMLMediaElement::loadInternal): selectMediaURL returns a ContentType. (WebCore::HTMLMediaElement::selectMediaURL): Return a ContentType instead of raw MIME type. (WebCore::HTMLMediaElement::initialURL): selectMediaURL returns a ContentType.
- html/HTMLMediaElement.h: Add prototype.
- html/HTMLMediaElement.idl: Ditto.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load): Take a ContentType instead of raw MIME type. (WebCore::MediaPlayer::supportsType): Ditto.
- platform/graphics/MediaPlayer.h:
2009-03-04 Eric Carlson <eric.carlson@apple.com>
Reviewed by Antti Koivisto.
https://bugs.webkit.org/show_bug.cgi?id=24364
Test HTMLMediaElement canPlayType method.
- media/video-can-play-type-expected.txt: Added.
- media/video-can-play-type.html: Added.
- 2:01 PM Changeset in webkit [41431] by
-
- 7 edits in trunk
2009-03-04 Antti Koivisto <Antti Koivisto>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=24359
Repaint throttling mechanism
Set ENABLE_REPAINT_THROTTLING to 0 by default.
- wtf/Platform.h:
WebCore:
2009-03-04 Antti Koivisto <Antti Koivisto>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=24359
Repaint throttling mechanism
Excessive repainting can slow down page loadind. This implements a timer
based throttling mechanism. It is behind ENABLE(REPAINT_THROTTLING) and not
enabled by default.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::checkCompleted):
- page/EventHandler.cpp: (WebCore::EventHandler::dispatchDragEvent): (WebCore::EventHandler::dispatchMouseEvent): (WebCore::EventHandler::keyEvent): (WebCore::EventHandler::handleTextInputEvent):
- page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::reset): (WebCore::FrameView::repaintContentRectangle): (WebCore::FrameView::beginDeferredRepaints): (WebCore::FrameView::endDeferredRepaints): (WebCore::FrameView::checkStopDelayingDeferredRepaints): (WebCore::FrameView::doDeferredRepaints): (WebCore::FrameView::updateDeferredRepaintDelay): (WebCore::FrameView::resetDeferredRepaintDelay): (WebCore::FrameView::adjustedDeferredRepaintDelay): (WebCore::FrameView::deferredRepaintTimerFired): (WebCore::FrameView::paintContents):
- page/FrameView.h:
- 1:53 PM Changeset in webkit [41430] by
-
- 9 edits in trunk/WebCore
2009-03-04 Sam Weinig <sam@webkit.org>
Rubber-stamped by Antti Koivisto.
Remove LOW_BANDWIDTH_DISPLAY as it is not being used by any platforms.
- dom/Document.cpp: (WebCore::Document::Document):
- dom/Document.h: (WebCore::Document::haveStylesheetsLoaded):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler):
- loader/Cache.cpp: (WebCore::Cache::requestResource):
- loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
- loader/DocLoader.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::begin): (WebCore::FrameLoader::write): (WebCore::FrameLoader::endIfNotLoadingMainResource): (WebCore::FrameLoader::checkCompleted): (WebCore::FrameLoader::requestObject): (WebCore::FrameLoader::loadItem):
- loader/FrameLoader.h:
- 1:24 PM Changeset in webkit [41429] by
-
- 6 edits in trunk/LayoutTests
2009-03-04 Kevin McCullough <kmccullough@apple.com>
- Build bot fix.
- fast/profiler/many-calls-in-the-same-scope-expected.txt:
- fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt:
- fast/profiler/multiple-and-different-scoped-function-calls-expected.txt:
- fast/profiler/nested-start-and-stop-profiler-expected.txt:
- fast/profiler/profile-calls-in-included-file-expected.txt:
- 12:57 PM Changeset in webkit [41428] by
-
- 8 edits2 moves in trunk
2009-03-02 Xan Lopez <xan@gnome.org>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=24287
[GTK] Move auth dialog feature to WebKit/
Add WebKitSoupAuthDialog files to build.
- GNUmakefile.am:
WebCore:
2009-03-02 Xan Lopez <xan@gnome.org>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=24287
[GTK] Move auth dialog feature to WebKit/
Remove WebKitSoupAuthDialog files from build and stop using it.
- GNUmakefile.am:
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ensureSessionIsInitialized):
- platform/network/soup/webkit-soup-auth-dialog.c: Removed.
- platform/network/soup/webkit-soup-auth-dialog.h: Removed.
WebKit/gtk:
2009-03-02 Xan Lopez <xan@gnome.org>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=24287
[GTK] Move auth dialog feature to WebKit/
Add WebKitSoupAuthDialog and add it to the session in webkit_init.
- webkit/webkitprivate.cpp: (currentToplevelCallback): (webkit_init):
- webkit/webkitsoupauthdialog.c: Added. (webkit_soup_auth_dialog_class_init): (webkit_soup_auth_dialog_init): (webkit_soup_auth_dialog_session_feature_init): (free_authData): (set_password_callback): (response_callback): (table_add_entry): (show_auth_dialog): (find_password_callback): (session_authenticate): (attach):
- webkit/webkitsoupauthdialog.h: Added.
- 11:58 AM Changeset in webkit [41427] by
-
- 3 edits4 adds in trunk
2009-03-04 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Reinstate code that sets result.innerNode when hitTest() returns true,
but never filled in the innerNode. Fixes hit testing of generated content.
Test: fast/css-generated-content/hit-test-generated-content.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestContents):
- 11:56 AM Changeset in webkit [41426] by
-
- 18 edits in trunk
WebCore:
2009-03-04 Adam Barth <abath@webkit.org>
Reviewed by Alexey Proskuryakov.
Fix WebKit style for allowUniversalAccessFromFileURLs.
- WebCore.base.exp:
- dom/Document.cpp: (WebCore::Document::initSecurityContext):
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setAllowUniversalAccessFromFileURLs):
- page/Settings.h: (WebCore::Settings::allowUniversalAccessFromFileURLs):
WebKit/mac:
2009-03-04 Adam Barth <abath@webkit.org>
Reviewed by Alexey Proskuryakov.
Fix WebKit style for allowUniversalAccessFromFileURLs.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences allowUniversalAccessFromFileURLs]): (-[WebPreferences setAllowUniversalAccessFromFileURLs:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
WebKit/qt:
2009-03-04 Adam Barth <abath@webkit.org>
Reviewed by Alexey Proskuryakov.
Fix WebKit style for allowUniversalAccessFromFileURLs.
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
WebKit/win:
2009-03-04 Adam Barth <abath@webkit.org>
Reviewed by Alexey Proskuryakov.
Fix WebKit style for allowUniversalAccessFromFileURLs.
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::allowUniversalAccessFromFileURLs): (WebPreferences::setAllowUniversalAccessFromFileURLs):
- WebPreferences.h:
- WebView.cpp: (WebView::notifyPreferencesChanged):
- 10:25 AM Changeset in webkit [41425] by
-
- 2 edits in trunk/WebCore
2009-03-04 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
<rdar://problem/6619630> Quick Look of vCards stuck on image of first card opened.
I narrowed this down to http://trac.webkit.org/changeset/39304 which, among other things,
consolidated some of the various decision making pieces of the Cache into the new method
FrameLoader::cachePolicy().
Before 39304, when deciding whether to use an existing CachedResource, we checked if the FrameLoader
is reloading. If it is, we'd evict any existing resource then recreate it. Quick looks uses the
same URL for this image every time and expects it to be reloaded with each new card.
The FrameLoader::isReloading() check did one thing - Ask the DocumentLoader if it's cache policy
is "ReloadIgnoringCacheData". This check was lost in the consolidation to the new method.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::cachePolicy): Restore the DocumentLoader's cachePolicy check as a possible condition for returning CachePolicyReload.
- 9:59 AM Changeset in webkit [41424] by
-
- 2 edits in trunk/WebCore
- English.lproj/localizedStrings.js: Update strings to include "DATABASES", "LOCAL STORAGE" and "SESSION STORAGE".
- 9:59 AM Changeset in webkit [41423] by
-
- 2 edits in trunk/WebCore
Fix a regression where the Web Inspector console would not animate
in or out correctly.
Reviewed by Anders Carlsson.
- inspector/front-end/inspector.css: Move a z-index to a child element to get the correct stacking order during the animation.
- 9:56 AM Changeset in webkit [41422] by
-
- 5 edits4 adds in trunk
WebCore:
2009-03-03 David Hyatt <hyatt@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=24201, pathologically bad block layout.
Make sure to factor clear deltas into y position estimates. Also avoid doing the comparison of
the final position against the y position estimate until after the clear has happened. This gets rid
of some duplicated cut/pasted code and also ensures a layout delta only has to be put in once.
Reviewed by Dan Bernstein
Added fast/block/float/nested-clearance.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::estimateVerticalPosition): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::getClearDelta):
- rendering/RenderBlock.h:
LayoutTests:
2009-03-03 David Hyatt <hyatt@apple.com>
Test case for https://bugs.webkit.org/show_bug.cgi?id=24201
Reviewed by Dan Bernstein
- fast/block/float/nested-clearance.html: Added.
- platform/mac/fast/block/float/nested-clearance-expected.checksum: Added.
- platform/mac/fast/block/float/nested-clearance-expected.png: Added.
- platform/mac/fast/block/float/nested-clearance-expected.txt: Added.
- 9:39 AM Changeset in webkit [41421] by
-
- 3 edits in trunk/WebKit/qt
2009-03-03 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Expose AllowUniversalAccessFromFileUrls to Qt clients.
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
- Api/qwebsettings.h:
- 6:42 AM Changeset in webkit [41420] by
-
- 8 edits in trunk/WebCore
2009-03-02 Kim Grönholm <kim.gronholm@nomovok.com>
Reviewed by Simon Hausmann.
Improvement to 3d transformations rendering in QtWebKit. QTransform is used
instead of QMatrix. This allows perspective transformations since QTransform is
a true 3x3 matrix.
- 6:21 AM Changeset in webkit [41419] by
-
- 3 edits in trunk/WebCore
2009-02-24 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=24151
Fix Qt/S60 build break
- 1:56 AM BuildingGtk edited by
- (diff)
- 1:54 AM QtWebKitTodo edited by
- (diff)
Mar 3, 2009:
- 11:20 PM Changeset in webkit [41418] by
-
- 2 edits in trunk/WebCore
2009-03-03 Mike Belshe <mike@belshe.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=21939
Uninitialized ExceptionCode in DOMWindow::postMessage
- dom/MessagePort.cpp: (WebCore::MessagePort::postMessage):
- 10:49 PM Changeset in webkit [41417] by
-
- 11 edits in trunk
<rdar://problem/6581203> WebCore and WebKit should install the same set of headers during installhdrs phase as build phase
Reviewed by Mark Rowe.
- Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME based on PLATFORM_NAME to work around the missing definition on Tiger. Updated HAVE_DTRACE to use REAL_PLATFORM_NAME.
WebCore:
The fix is to add INSTALLHDRS_COPY_PHASE = YES and
INSTALLHDRS_SCRIPT_PHASE = YES to WebCore.xcconfig, then to make
sure various build phase scripts work with the installhdrs build
phase.
- Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME based on PLATFORM_NAME to work around the missing definition on Tiger.
- Configurations/WebCore.xcconfig: Added JAVASCRIPTCORE_PRIVATE_HEADERS_DIR variable to simplify logic in the "Generate Derived Sources" script. Added INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.
- WebCore.xcodeproj/project.pbxproj:
- Added shell code to prevent running "Check For Global Initializers", "Check For Exit Time Destructors" and "Check For Weak VTables" scripts during the installhdrs build phase.
- Made "Generate Derived Sources" work for the installhdrs build phase. Also simplified setting of CREATE_HASH_TABLE by using JAVASCRIPTCORE_PRIVATE_HEADERS_DIR.
WebKit:
The fix is to add INSTALLHDRS_COPY_PHASE = YES and
INSTALLHDRS_SCRIPT_PHASE = YES to WebKit.xcconfig, then to
make sure various build phase scripts work with the installhdrs
build phase.
- WebKit.xcodeproj/project.pbxproj:
- Added shell code to prevent running "Check For Global Initializers", "Check For Exit Time Destructors" and "Check For Weak VTables" scripts during the installhdrs build phase.
- Removed UMBRELLA_FRAMEWORKS_DIR from the Debug and Release targets since it's no longer needed after defining WEBCORE_PRIVATE_HEADERS_DIR in WebKit.xcconfig.
WebKit/mac:
The fix is to add INSTALLHDRS_COPY_PHASE = YES and
INSTALLHDRS_SCRIPT_PHASE = YES to WebKit.xcconfig, then to
make sure various build phase scripts work with the installhdrs
build phase.
- Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME based on PLATFORM_NAME to work around the missing definition on Tiger.
- Configurations/WebKit.xcconfig: Added WEBCORE_PRIVATE_HEADERS_DIR variable to remove definition of UMBRELLA_FRAMEWORKS_DIR for Debug and Release builds in the Xcode project file. Added INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.
- 10:09 PM Changeset in webkit [41416] by
-
- 6 edits2 moves in trunk/WebCore
2009-03-02 Adam Langley <agl@google.com>
Reviewed by Darin Fisher.
Chromium Linux: Switch to using Skia to render widgets.
In order to sandbox the Chromium renderer on Linux we need to remove
the X connection. GTK cannot render without an X connection so, for
now, we render widgets ourselves.
Previously didn't use anti-alias fonts in order to match Windows font
rendering exactly. This was helpful when bootstrapping our layout
tests. Now, however, we are ready to enable it.
- platform/chromium/ScrollbarThemeChromium.cpp: (WebCore::ScrollbarThemeChromium::buttonSize):
- platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromium::scrollbarThickness): (WebCore::ScrollbarThemeChromium::paintTrackPiece): (WebCore::ScrollbarThemeChromium::paintButton): (WebCore::ScrollbarThemeChromium::paintThumb):
- platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint):
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::PlatformContextSkia): (PlatformContextSkia::~PlatformContextSkia):
- platform/graphics/skia/PlatformContextSkia.h:
- rendering/RenderThemeChromiumGtk.cpp: Removed.
- rendering/RenderThemeChromiumGtk.h: Removed.
- rendering/RenderThemeChromiumLinux.cpp: Added.
- rendering/RenderThemeChromiumLinux.h: Added.
- 9:39 PM Changeset in webkit [41415] by
-
- 2 edits in trunk/WebCore
2009-03-03 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=24261
Fix return types.
Test: LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg
- bindings/v8/V8Binding.h: (WebCore::toInt32): change return type to int (WebCore::toFloat): change return type to float.
- 5:10 PM Changeset in webkit [41414] by
-
- 7 edits in trunk
WebCore:
2009-03-03 Anders Carlsson <andersca@apple.com>
Reviewed by John Sullivan.
https://bugs.webkit.org/show_bug.cgi?id=22884
<rdar://problem/6449783>
modified layout test crashes Safari
Null check NPStream before dereferencing it.
- plugins/PluginView.cpp: (WebCore::PluginView::destroyStream):
WebKitTools:
2009-03-03 Anders Carlsson <andersca@apple.com>
Reviewed by John Sullivan.
https://bugs.webkit.org/show_bug.cgi?id=22884
<rdar://problem/6449783>
modified layout test crashes Safari
Add destroyNullStream test function to the test plug-in.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (destroyNullStream): (pluginInvoke):
LayoutTests:
2009-03-03 Anders Carlsson <andersca@apple.com>
Reviewed by John Sullivan.
https://bugs.webkit.org/show_bug.cgi?id=22884
<rdar://problem/6449783>
modified layout test crashes Safari
Update tests.
- plugins/destroy-stream-twice-expected.txt:
- plugins/destroy-stream-twice.html:
- 5:06 PM Changeset in webkit [41413] by
-
- 117 edits in trunk/LayoutTests
2009-03-03 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=24294
Bug 24294: Improve media layout test logging
Make all media layout tests log the condition that is being tested,
success or failure, plus observed value when a test condition fails
so it is possible to see exactly what failed without having to hack
the test source. Consolidate some of the logic in the shared JavaScript file.
- media/audio-constructor-expected.txt:
- media/audio-constructor-src-expected.txt:
- media/audio-constructor-src.html:
- media/audio-constructor.html:
- media/audio-mpeg-supported-expected.txt:
- media/audio-mpeg-supported.html:
- media/broken-video-expected.txt:
- media/broken-video.html:
- media/constructors-expected.txt:
- media/constructors.html:
- media/loopend-limits-expected.txt:
- media/loopstart-limits-expected.txt:
- media/progress-event-expected.txt:
- media/progress-event-total-expected.txt:
- media/progress-event-total.html:
- media/progress-event.html:
- media/remove-from-document-expected.txt:
- media/remove-from-document-no-load-expected.txt:
- media/remove-from-document-no-load.html:
- media/remove-from-document.html:
- media/unsupported-rtsp-expected.txt:
- media/unsupported-rtsp.html:
- media/unsupported-tracks-expected.txt:
- media/unsupported-tracks.html:
- media/video-append-source-expected.txt:
- media/video-append-source.html:
- media/video-autoplay-expected.txt:
- media/video-autoplay.html:
- media/video-buffered-expected.txt:
- media/video-buffered.html:
- media/video-controls-expected.txt:
- media/video-controls-transformed-expected.txt:
- media/video-controls-transformed.html:
- media/video-controls.html:
- media/video-currentTime-expected.txt:
- media/video-currentTime-set.html:
- media/video-currentTime-set2-expected.txt:
- media/video-currentTime-set2.html:
- media/video-currentTime.html:
- media/video-dom-autoplay-expected.txt:
- media/video-dom-autoplay.html:
- media/video-dom-end-expected.txt:
- media/video-dom-end.html:
- media/video-dom-loopcount-expected.txt:
- media/video-dom-loopcount.html:
- media/video-dom-loopend-expected.txt:
- media/video-dom-loopend.html:
- media/video-dom-loopstart-expected.txt:
- media/video-dom-loopstart.html:
- media/video-dom-src-expected.txt:
- media/video-dom-src.html:
- media/video-dom-start-expected.txt:
- media/video-dom-start.html:
- media/video-end-expected.txt:
- media/video-end.html:
- media/video-error-abort-expected.txt:
- media/video-error-abort.html:
- media/video-error-does-not-exist-expected.txt:
- media/video-error-does-not-exist.html:
- media/video-load-networkState-expected.txt:
- media/video-load-networkState.html:
- media/video-load-readyState-expected.txt:
- media/video-load-readyState.html:
- media/video-loopcount-expected.txt:
- media/video-loopcount.html:
- media/video-loopend-expected.txt:
- media/video-loopend.html:
- media/video-loopstart-expected.txt:
- media/video-loopstart.html:
- media/video-muted-expected.txt:
- media/video-muted.html:
- media/video-no-autoplay-expected.txt:
- media/video-no-autoplay.html:
- media/video-pause-empty-events-expected.txt:
- media/video-pause-empty-events.html:
- media/video-play-empty-events-expected.txt:
- media/video-play-empty-events.html:
- media/video-play-pause-events-expected.txt:
- media/video-play-pause-events.html:
- media/video-poster-expected.txt:
- media/video-poster.html:
- media/video-seek-past-end-paused-expected.txt:
- media/video-seek-past-end-paused.html:
- media/video-seek-past-end-playing-expected.txt:
- media/video-seek-past-end-playing.html:
- media/video-seekable-expected.txt:
- media/video-seekable.html:
- media/video-seeking-expected.txt:
- media/video-seeking.html:
- media/video-size-expected.txt:
- media/video-size.html:
- media/video-source-expected.txt:
- media/video-source-media-expected.txt:
- media/video-source-media.html:
- media/video-source-type-expected.txt:
- media/video-source-type-params-expected.txt:
- media/video-source-type-params.html:
- media/video-source-type.html:
- media/video-source.html:
- media/video-src-change-expected.txt:
- media/video-src-change.html:
- media/video-src-expected.txt:
- media/video-src-remove-expected.txt:
- media/video-src-remove.html:
- media/video-src-set-expected.txt:
- media/video-src-set.html:
- media/video-src-source-expected.txt:
- media/video-src-source.html:
- media/video-src.html:
- media/video-start-expected.txt:
- media/video-start.html:
- media/video-test.js: (test): (testExpected): (waitForEvent._eventCallback): (waitForEvent): (waitForEventAndTest._eventCallback): (waitForEventAndTest): (testException): (logResult):
- media/video-volume-expected.txt:
- media/video-volume.html:
- media/video-width-height-expected.txt:
- media/video-width-height.html:
- 4:44 PM Changeset in webkit [41412] by
-
- 3 edits in trunk/WebCore
2009-03-03 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Fix for <rdar://problem/6641045>
Don't call QTKit to get movie properties until movie metadata has been loaded.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h: (WebCore::MediaPlayerPrivate::metaDataAvailable): defined
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTTime): return default if !metaDataAvailable. (WebCore::MediaPlayerPrivate::play): Ditto. (WebCore::MediaPlayerPrivate::pause): Ditto. (WebCore::MediaPlayerPrivate::duration): Ditto. (WebCore::MediaPlayerPrivate::currentTime): Ditto. (WebCore::MediaPlayerPrivate::seek): Ditto. (WebCore::MediaPlayerPrivate::seekTimerFired): Ditto. (WebCore::MediaPlayerPrivate::paused): Ditto. (WebCore::MediaPlayerPrivate::seeking): Ditto. (WebCore::MediaPlayerPrivate::naturalSize): Ditto. (WebCore::MediaPlayerPrivate::hasVideo): Ditto. (WebCore::MediaPlayerPrivate::setVolume): Ditto. (WebCore::MediaPlayerPrivate::setRate): Ditto. (WebCore::MediaPlayerPrivate::dataRate): Ditto. (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto. (WebCore::MediaPlayerPrivate::totalBytes): Ditto.
- 4:38 PM Changeset in webkit [41411] by
-
- 2 edits2 adds in trunk/LayoutTests
2009-03-03 Kevin McCullough <kmccullough@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/6031674> JSProfiler: Multiple anonymous functions get
the same entry in profiler if called from same function
- This no longer happens but I thought I'd make a test case anyway.
- fast/profiler/multiple-anonymous-functions-called-from-the-same-function-expected.txt: Added.
- fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html: Added.
- fast/profiler/resources/profiler-test-JS-resources.js: (anotherAnonymousFunction):
- 4:08 PM Changeset in webkit [41410] by
-
- 2 edits in trunk/WebCore
2009-03-03 Kevin McCullough <kmccullough@apple.com>
- Spelling fix.
- page/Console.cpp: (WebCore::Console::profile):
- 3:30 PM Changeset in webkit [41409] by
-
- 4 edits in trunk/WebKit
Remove last vestiges of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR from WebKit
Reviewed by Adam Roben.
Use of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR was removed in r37465
since NPAPI headers had migrated from JavaScriptCore to WebCore
before that.
WebKit:
- WebKit.xcodeproj/project.pbxproj: Removed JAVASCRIPTCORE_PRIVATE_HEADERS_DIR build setting from from Debug and Release configurations.
WebKit/mac:
- Configurations/WebKit.xcconfig: Removed definition of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR used in Production builds.
- 2:57 PM Changeset in webkit [41408] by
-
- 2 edits in trunk/WebCore
2009-03-03 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=23657
Remove Database API callback IDLs from the project.
They were removed in r40633.
- WebCore.xcodeproj/project.pbxproj: Removed IDL files from the project.
- 2:47 PM Changeset in webkit [41407] by
-
- 5 edits2 adds in trunk
2009-03-03 Kevin McCullough <kmccullough@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/6639110> console.profile() doesn't work without a title
- profiler/Profiler.cpp: (JSC::Profiler::startProfiling): assert if there is not title to ensure we don't start profiling without one.
WebCore:
2009-03-03 Kevin McCullough <kmccullough@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/6639110> console.profile() doesn't work without a title
- page/Console.cpp: (WebCore::Console::profile): If there is no title assume this is a user initiated profile and give it the next incremented title name.
LayoutTests:
2009-03-03 Kevin McCullough <kmccullough@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/6639110> console.profile() doesn't work without a title
- fast/profiler/profile-with-no-title-expected.txt: Added.
- fast/profiler/profile-with-no-title.html: Added.
- 2:27 PM Changeset in webkit [41406] by
-
- 1 edit in trunk/WebCore/ChangeLog
Add bug URLs for my last commit.
- 2:25 PM Changeset in webkit [41405] by
-
- 1 edit6 deletes in trunk/LayoutTests
2009-03-03 Pamela Greene <pam@chromium.org>
Remove junk files that must have been accidentally committed.
Submitted without review.
- fast/block/float/t0905-c414-flt-fit-01-d-g.html.orig: Removed.
- fast/block/float/t0905-c414-flt-fit-01-d-g.html.rej: Removed.
- fast/block/float/t0905-c5525-fltblck-00-d-ag.html.orig: Removed.
- fast/block/float/t0905-c5525-fltblck-00-d-ag.html.rej: Removed.
- fast/block/float/t0905-c5526-flthw-00-c-g.html.orig: Removed.
- fast/block/float/t0905-c5526-flthw-00-c-g.html.rej: Removed.
- 2:24 PM Changeset in webkit [41404] by
-
- 8 edits1 add in trunk/WebCore
Fix a regression that broke dirxml and caused an ASSERT in debug builds. Also simplified
the console code and refactored things to have fewer code paths and duplication.
Reviewed by Kevin McCullough.
Test: manual-tests/inspector/console-dir.html
- bindings/js/JSInspectedObjectWrapper.cpp: (WebCore::JSInspectedObjectWrapper::wrap): Use the lexicalGlobalObject instead of dynamicGlobalObject to fix an ASSERT about using a wrapper from the wrong ExecState.
- bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper): Ditto. (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom): Ditto.
- inspector/front-end/Console.js: (WebInspector.Console.prototype._format): Remove the inline argument and add forceObjectFormat. When forceObjectFormat is true, the only formatter used is _formatobject. (WebInspector.Console.prototype._formatvalue): Remove the inline argument. (WebInspector.Console.prototype._formatstring): Ditto. (WebInspector.Console.prototype._formatregexp): Ditto. (WebInspector.Console.prototype._formatarray): Ditto. (WebInspector.Console.prototype._formatnode): Remove the inline argument and make a DOM tree instead of an anchor. (WebInspector.Console.prototype._formatobject): Remove the inline argument and always make a property graph. (WebInspector.Console.prototype._formaterror): Remove the inline argument. (WebInspector.ConsoleMessage): Remove the case for MessageLevel.Node and simplify the case for MessageLevel.Object to use the normal _format code path with the %O formatter. (WebInspector.ConsoleMessage.prototype._format.formatForConsole): Don't pass an additional true argument for inline. (WebInspector.ConsoleMessage.prototype._format.formatAsObjectForConsole): Added. Pass a true argument for forceObjectFormat. (WebInspector.ConsoleMessage.prototype._format): Added support for the %O formatter. Use formatForConsole for all arguments. (WebInspector.ConsoleMessage.prototype.toString): Add the other message levels.
- inspector/front-end/inspector.css: Tweak styles to look and work correctly.
- inspector/front-end/utilities.js: (Object.type): Return "node" for Node objects. (Object.describe): Handle the "node" type.
- page/Console.cpp: (WebCore::printMessageSourceAndLevelPrefix): Fix an assert by adding the other message level types. (WebCore::Console::dirxml): Use the standard log fuction since it prints a DOM tree for nodes by default.
- page/Console.h: (WebCore::enum MessageLevel): Removed NodeMessageLevel. Added a FIXME.
- 1:07 PM Changeset in webkit [41403] by
-
- 3 edits2 adds in trunk
WebCore:
2009-03-03 Scott Violet <sky@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=24325
Crash on replacing document contents during drop.
Makes sure a node is in the document during a move before using it.
Test: fast/events/crash-on-mutate-during-drop.html
- editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::doApply):
LayoutTests:
2009-03-03 Scott Violet <sky@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=24325
Crash on replacing document contents during drop
Makes sure we don't crash during dnd with DOM mutation event listener
that mutates the document on drop.
- fast/events/crash-on-mutate-during-drop-expected.txt: Added.
- fast/events/crash-on-mutate-during-drop.html: Added.
- 11:53 AM Changeset in webkit [41402] by
-
- 4 edits in trunk/WebCore
2009-03-03 Jungshik Shin <jshin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23028
Enable dynamic web font support to Chromium on Windows.
Files that were omitted by mistake in the latest patch
that was landed.
- loader/CachedFont.cpp: (WebCore::CachedFont::~CachedFont): (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::platformDataFromCustomData): (WebCore::CachedFont::allClientsRemoved):
- platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::EOTStream::EOTStream): (WebCore::createFontCustomPlatformData):
- platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::EOTStream::EOTStream): (WebCore::createFontCustomPlatformData):
- 11:48 AM Changeset in webkit [41401] by
-
- 12 edits2 adds in trunk
2009-03-03 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=16826
[Gtk] Implement WebKitDownload
Adding new files related to WebKitDownload to the GTK+ port.
- GNUmakefile.am:
WebCore:
2009-03-03 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=16826
[Gtk] Implement WebKitDownload
Make the Soup backend able to handle requests without a frame,
since we may have such things now that we support downloads.
- platform/network/ResourceHandleInternal.h:
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::start):
WebKit/gtk:
2009-03-03 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=16826
[Gtk] Implement WebKitDownload
Implement download, and provide a nice object wrapping the
download process. Initial work done by Marco Barisione and
Pierre-Luc Beaudoin for Collabora.
- WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::ContextMenuClient::downloadURL):
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::download): (WebKit::FrameLoaderClient::startDownload):
- webkit/webkit.h:
- webkit/webkitdefines.h:
- webkit/webkitdownload.cpp: Added. (_WebKitDownloadPrivate::): (_WebKitDownloadPrivate::webkit_download_dispose): (_WebKitDownloadPrivate::webkit_download_finalize): (_WebKitDownloadPrivate::webkit_download_get_property): (_WebKitDownloadPrivate::webkit_download_set_property): (_WebKitDownloadPrivate::webkit_download_class_init): (_WebKitDownloadPrivate::webkit_download_init): (_WebKitDownloadPrivate::webkit_download_new): (_WebKitDownloadPrivate::webkit_download_open_stream_for_uri): (_WebKitDownloadPrivate::webkit_download_close_stream): (_WebKitDownloadPrivate::webkit_download_start): (_WebKitDownloadPrivate::webkit_download_cancel): (_WebKitDownloadPrivate::webkit_download_get_uri): (_WebKitDownloadPrivate::webkit_download_get_network_request): (_WebKitDownloadPrivate::webkit_download_set_response): (_WebKitDownloadPrivate::webkit_download_get_suggested_filename): (_WebKitDownloadPrivate::webkit_download_get_destination_uri): (_WebKitDownloadPrivate::webkit_download_set_destination_uri): (_WebKitDownloadPrivate::webkit_download_get_state): (_WebKitDownloadPrivate::webkit_download_get_total_size): (_WebKitDownloadPrivate::webkit_download_get_current_size): (_WebKitDownloadPrivate::webkit_download_get_progress): (_WebKitDownloadPrivate::webkit_download_get_elapsed_time): (_WebKitDownloadPrivate::webkit_download_received_data): (_WebKitDownloadPrivate::webkit_download_finished_loading): (_WebKitDownloadPrivate::webkit_download_error): (_WebKitDownloadPrivate::DownloadClient::DownloadClient): (_WebKitDownloadPrivate::DownloadClient::didReceiveResponse): (_WebKitDownloadPrivate::DownloadClient::didReceiveData): (_WebKitDownloadPrivate::DownloadClient::didFinishLoading): (_WebKitDownloadPrivate::DownloadClient::didFail): (_WebKitDownloadPrivate::DownloadClient::wasBlocked): (_WebKitDownloadPrivate::DownloadClient::cannotShowURL):
- webkit/webkitdownload.h: Added.
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp:
- webkitmarshal.list:
- 11:29 AM Changeset in webkit [41400] by
-
- 3 edits in trunk/WebKit/mac
2009-03-03 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Fix <rdar://problem/6633834>.
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin): Create a new plug-in instance if the plug-in host has crashed.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::invalidate): Add a null check for the plug-in host proxy.
- 11:18 AM Changeset in webkit [41399] by
-
- 2 edits4 copies1 add in trunk/WebCore
2009-03-03 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=24331
Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame.
- bindings/v8/custom/V8AttrCustom.cpp: Added.
- bindings/v8/custom/V8CustomBinding.cpp: Added.
- bindings/v8/custom/V8CustomBinding.h: Added attribute-checking helpers.
- bindings/v8/custom/V8ElementCustom.cpp: Added.
- bindings/v8/custom/V8HTMLFrameElementCustom.cpp: Added.
- bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Added.
- 11:08 AM Changeset in webkit [41398] by
-
- 15 edits3 adds in trunk
WebCore:
2009-03-03 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
<rdar://problem/6616664> - Quick looks of various file types is broken
In http://trac.webkit.org/changeset/40553 there was an attempt to prevent NSURLRequest churn
for non-HTTP loads when the underlying ResourceRequest changed. Unfortunately it was a little
overzealous as the mainDocumentURL is relevant for all loads, not only HTTP/HTTPS loads.
Partially reverted behavior to always set the mainDocumentURL in situations when we would've
before that patch.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::setMainDocumentURL):
WebKitTools:
2009-03-03 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
Support layout test covering <rdar://problem/6616664>
Change NSURLRequest/IWebURLRequest dumping to include the mainDocumentURL
- DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURLRequest _drt_descriptionSuitableForTestResult]): Return both the request URL and the mainDocumentURL.
- DumpRenderTree/win/ResourceLoadDelegate.cpp: (descriptionSuitableForTestResult): Return both the request URL and the mainDocumentURL.
LayoutTests:
2009-03-03 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
Layout test covering <rdar://problem/6616664> - Quick looks of various file types is broken
Added to test the changes:
- fast/loader/main-document-url-for-non-http-loads-expected.txt: Added.
- fast/loader/main-document-url-for-non-http-loads.html: Added.
- fast/loader/resources/subframe-notify-done.html: Added.
Updated the following for the new info from dumpResourceLoadCallbacks():
- http/tests/misc/window-dot-stop-expected.txt:
- http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt:
- platform/mac-leopard/security/block-test-expected.txt:
- platform/mac-tiger/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
- platform/mac/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
- platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
- security/block-test-expected.txt:
- webarchive/loading/test-loading-archive-expected.txt:
- 10:55 AM Changeset in webkit [41397] by
-
- 2 edits in trunk/WebCore
Reviewed by Simon Fraser.
Added a WebCoreForceSoftwareAnimation flag.
- 10:48 AM Changeset in webkit [41396] by
-
- 11 edits2 adds in trunk
Reviewed by Sam Weinig.
Added prototype properties for several classes with constructors that
were missing them, including the one mentioned in the bug.
- 10:46 AM Changeset in webkit [41395] by
-
- 3 edits in trunk/WebKit/qt
2009-03-03 Ariya Hidayat <ariya.hidayat@trolltech.com>
Rubber-stamped by Simon Hausmann.
[Qt] Create and update the action for SelectAll.
- Api/qwebpage.cpp: (QWebPagePrivate::updateAction): (QWebPagePrivate::updateEditorActions): (QWebPage::action):
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::textSelection):
- 10:38 AM Changeset in webkit [41394] by
-
- 1 edit4 adds in trunk/WebCore
2009-03-03 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=24321
Add V8 bindings headers.
- bindings/v8/V8Binding.h: Added.
- bindings/v8/V8Proxy.h: Added.
- bindings/v8/custom/V8CustomBinding.h: Added.
- bindings/v8/custom/V8CustomEventListener.h: Added.
- 10:33 AM Changeset in webkit [41393] by
-
- 1 edit20 adds in trunk/LayoutTests
2009-03-03 Jungshik Shin <jshin@chromium.org>
Reviewed by Darin Adler.
http://bugs.webkit.org/show_bug.cgi?id=23482
Add the following CSS 2.1 tests, with YinYang character (U+262F)
and SouthEast Arrow (U+2798) replaced by png images,
to fast/block/float. Leftward white arrow (U+21E6) is also
replaced by an ASCII-equivalent of '<-'.
css2.1/t0905-c414-flt-fit-01-d-g.html
css2.1/t0905-c5525-fltblck-00-d-ag.html
css2.1/t0905-c5526-flthw-00-c-g.html
On platforms where no font covers those characters (e.g. Windows),
the above tests can be skipped and the new tests can be used, instead.
They're equivalent in terms of what they test.
- fast/block/float/resources/se_arrow.png: Added.
- fast/block/float/resources/yinyang.png: Added.
- fast/block/float/t0905-c414-flt-fit-01-d-g.html: Copied from LayoutTests/css2.1/t0905-c414-flt-fit-01-d-g.html.
- fast/block/float/t0905-c5525-fltblck-00-d-ag.html: Copied from LayoutTests/css2.1/t0905-c5525-fltblck-00-d-ag.html.
- fast/block/float/t0905-c5526-flthw-00-c-g.html: Copied from LayoutTests/css2.1/t0905-c5526-flthw-00-c-g.html.
- platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.checksum: Added.
- platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.png: Added.
- platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.txt: Added.
- platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.checksum: Added.
- platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.png: Added.
- platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.txt: Added.
- platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.checksum: Added.
- platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.png: Added.
- platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.txt: Added.
- 10:21 AM Changeset in webkit [41392] by
-
- 2 edits in trunk/WebCore
2009-03-03 Jungshik Shin <jshin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23803
Fix an 'off-by-1' error in ChromiumWin's font fallback.
- platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::FontCache::getFontDataForCharacters):
- 10:20 AM Changeset in webkit [41391] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix ChangeLog dates.
- 10:18 AM Changeset in webkit [41390] by
-
- 2 edits2 moves1 add in trunk/WebCore
2009-03-03 Jungshik Shin <jshin@chromium.org>
Reviewed by Eric Seidel.
http://bugs.webkit.org/show_bug.cgi?id=23028
Enable dynamic web font support to Chromium on Windows: Part 1
- Move OpenTypeUtilities.{cpp,h} to platform/graphics/opentype from platform/graphics/win because both Windows port and Chromium Windows port will use them.
- Adjust WebCore.vcproj accordingly.
- WebCore.vcproj/WebCore.vcproj:
- platform/graphics/opentype: Added.
- platform/graphics/opentype/OpenTypeUtilities.cpp: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.cpp.
- platform/graphics/opentype/OpenTypeUtilities.h: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.h.
- platform/graphics/win/OpenTypeUtilities.cpp: Removed.
- platform/graphics/win/OpenTypeUtilities.h: Removed.
- 10:10 AM Changeset in webkit [41389] by
-
- 6 edits in trunk/WebCore
2009-03-02 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Take 3D transforms into account when hit testing:
- Maintain a bit on each RenderLayer that is set when the layer has 3d descendants, so that we know when to fall into the slow hit testing path.
- Make a ref-counted HitTestingTransformState, which is used to store an accumulated transform, and the hit test point, and hitTestRect in the plane of the ancestor non-3d ('flattening') layer.
It's ref-counted so we can heap allocate it (to avoid stack bloat),
and avoid copying when hitTestLayer calls itself after applying the transform.
- Add logic to hitTestLayer to depth-test just direct descendants, if any have 3D transforms, or to do deep depth-testing when traversing a preserves-3d hierarchy. When hit, layers compute a z-offset from the ancestor flattening layer, which allows for correct depth testing.
The existing early-return codepath is unaffected when there are no 3d transforms
and no preserve-3d.
- 9:54 AM Changeset in webkit [41388] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix typo in ChangeLog from last commit.
- 9:52 AM Changeset in webkit [41387] by
-
- 4 edits in trunk/WebCore
2009-03-02 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Factor the code that compute a transform relative to the container
into RenderObject::transformFromContainer().
- rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToAbsolutePoint): (WebCore::RenderBox::mapAbsoluteToLocalPoint):
- rendering/RenderObject.cpp: (WebCore::RenderObject::transformFromContainer):
- rendering/RenderObject.h:
- 9:50 AM Changeset in webkit [41386] by
-
- 2 edits in trunk/WebCore
2009-03-02 Brett Wilson <brettw@chromium.org>
Fix uninitialized memory reads in the Chromium Windows transparency
code that were identified by Purify,
Reviewed by Darin Disher.
- platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers): (WebCore::TransparencyWin::initializeNewContext):
- 9:43 AM Changeset in webkit [41385] by
-
- 2 edits in trunk/WebCore
2009-03-02 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Always return |true| from RenderTextControlMultiLine::nodeAtPoint() if
the superclass found a node, otherwise we set the innerNode of the
HitTestResult, but don't actually report that we found a hit.
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):
- 9:31 AM Changeset in webkit [41384] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fixing bug number for last ChangeLog entry; thanks to Ariya for
catching this problem.
- 9:26 AM Changeset in webkit [41383] by
-
- 3 edits1 add in trunk/WebCore
2009-03-03 Onne Gorter <onne.gorter@avinity.net>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=27385
resizing plugins does not work, because the plugin never gets informed
Make gtk plugins resize correctly, by sending them the setwindow event
correctly. Also ensure that all plugin eventing is done with correct
locking/calling. Mostly copied from mac implementation.
manual test: manual-tests/gtk/plugin-resize-scroll.html
- plugins/PluginView.h:
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::dispatchNPEvent): ensure locking/calling for NPEvents (WebCore::PluginView::updatePluginWidget): if something changed, let setNPWindowIfNeeded handle it (WebCore::PluginView::paint): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent): ensure calling conventions (WebCore::PluginView::setNPWindowRect): just pass control to setNPWindowIfNeeded (WebCore::PluginView::setNPWindowIfNeeded): event the plugin correctly of new window (WebCore::PluginView::init): init through the new setup
- 8:45 AM Changeset in webkit [41382] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=4343
XMLHttpRequest doesn't work in a JavaScript-created window
The problem was fixed a while ago (r34506), just adding a test.
- http/tests/xmlhttprequest/request-from-popup-expected.txt: Added.
- http/tests/xmlhttprequest/request-from-popup.html: Added.
- 8:44 AM Changeset in webkit [41381] by
-
- 1 edit in trunk/WebCore/ChangeLog
Adding bug URL and title to ChangeLog for a recent check-in.
- 8:06 AM Changeset in webkit [41380] by
-
- 3 edits in trunk/WebCore
2009-03-03 Mike Belshe <mike@belshe.com>
Reviewed by Darin Fisher.
- dom/Document.idl:
- html/HTMLCanvasElement.idl:
Mar 2, 2009:
- 10:15 PM Changeset in webkit [41379] by
-
- 3 edits2 adds in trunk
2009-03-02 Simon Fraser <Simon Fraser>
Reviewed by Adele Peterson
If RenderTextControlSingleLine::nodeAtPoint() pokes a node into the
HitTestResult, then it had better well return |true|. And m_innerBlock
could never have been set as the hit node by the superclass, because
the superclass knows nothing about m_innerBlock.
Test: fast/forms/input-hit-test-border.html
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):
- 6:24 PM Changeset in webkit [41378] by
-
- 8 edits in trunk
2009-03-02 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Enable Geolocation (except on Tiger and Leopard).
- Configurations/JavaScriptCore.xcconfig:
WebCore:
2009-03-02 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Enable Geolocation (except on Tiger and Leopard).
- Configurations/WebCore.xcconfig:
WebKit/mac:
2009-03-02 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Enable Geolocation (except on Tiger and Leopard).
- Configurations/WebKit.xcconfig:
WebKitTools:
2009-03-02 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Enable Geolocation (except on Tiger and Leopard).
- Scripts/build-webkit:
- 6:12 PM Changeset in webkit [41377] by
-
- 2 edits in trunk/WebCore
2009-03-02 Ojan Vafai <ojan@chromium.org>
Reviewed by Adele Peterson.
Fix https://bugs.webkit.org/show_bug.cgi?id=24307
Null out m_highlightedNode on hideHighlight().
Ran WebCore/manual-tests/inspector/highlight-nodes.html.
- inspector/InspectorController.cpp: (WebCore::InspectorController::hideHighlight):
- 5:51 PM Changeset in webkit [41376] by
-
- 5 edits in trunk/WebKit/mac
2009-03-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
WebKit part of <rdar://problem/6638658>.
- Plugins/Hosted/NetscapePluginHostManager.h:
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::createPropertyListFile): Spawn the plug-in host and wait for it to create the property list.
- Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage createPropertyListFile]): Factor code out into a new method.
(-[WebBasePluginPackage pListForPath:createFile:]):
Call the newly added createPropertyListFile method.
- Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage createPropertyListFile]): Tell the plug-in host manager to create a property list file for us.
- 5:47 PM Changeset in webkit [41375] by
-
- 13 edits2 adds in trunk
WebCore:
2009-03-02 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Fix for <rdar://problem/6507404> Add Geolocation support.
This is not yet turned on for any Mac platform.
- WebCore.xcodeproj/project.pbxproj:
- page/Chrome.cpp: (WebCore::Chrome::shouldAllowGeolocationForFrame):
- page/Chrome.h:
- page/ChromeClient.h: (WebCore::ChromeClient::shouldAllowGeolocationForFrame):
- page/Geolocation.cpp: (WebCore::Geolocation::Geolocation): (WebCore::Geolocation::disconnectFrame): Remove call to setUsingGeolocation as the document will not be alive at this point. (WebCore::Geolocation::getCurrentPosition): Check if the embedding app allows geolocation and return a PERMISSION_DENIED if not. (WebCore::Geolocation::watchPosition): Ditto. (WebCore::Geolocation::shouldAllowGeolocation): Perform request to embedding layer of whether to allow geolocation and cache the result.
- page/Geolocation.h: (WebCore::Geolocation::):
- platform/GeolocationService.cpp:
- platform/GeolocationService.h: (WebCore::GeolocationService::~GeolocationService): (WebCore::GeolocationService::stopUpdating):
- platform/mac/GeolocationServiceMac.h: Added. (WebCore::GeolocationServiceMac::lastPosition): (WebCore::GeolocationServiceMac::lastError):
- platform/mac/GeolocationServiceMac.mm: Added. (WebCore::GeolocationService::create): (WebCore::GeolocationServiceMac::GeolocationServiceMac): (WebCore::GeolocationServiceMac::~GeolocationServiceMac): (WebCore::GeolocationServiceMac::startUpdating): (WebCore::GeolocationServiceMac::stopUpdating): (WebCore::GeolocationServiceMac::suspend): (WebCore::GeolocationServiceMac::resume): (WebCore::GeolocationServiceMac::positionChanged): (WebCore::GeolocationServiceMac::errorOccurred): (-[WebCoreCoreLocationObserver initWithCallback:]): (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]): (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):
WebKit/mac:
2009-03-02 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Fix for <rdar://problem/6507404> Add Geolocation support.
This is not yet turned on for any Mac platform.
Add SPI to ask the embedding application whether to allow
Geolocation for an origin.
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldAllowGeolocationForFrame):
- WebView/WebUIDelegatePrivate.h:
- 5:36 PM Changeset in webkit [41374] by
-
- 2 edits in trunk/WebKit/mac
2009-03-02 Anders Carlsson <andersca@apple.com>
Fix PowerPC build.
- Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _tryLoad]):
- 5:36 PM UsingGitWithWebKit edited by
- (diff)
- 4:20 PM Changeset in webkit [41373] by
-
- 1 edit in trunk/WebKit/mac/ChangeLog
Fix tyop
- 4:14 PM Changeset in webkit [41372] by
-
- 2 edits in trunk/WebKit/mac
2009-03-02 Anders Carlsson <andersca@apple.com>
Reviewed by John Sullivan, Ada Chan.
Factor loading code out into its own method and get rid of a bunch of goots.
- Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage load]):
- 4:00 PM Changeset in webkit [41371] by
-
- 2 edits in trunk/WebKit/mac
2009-03-02 Anders Carlsson <andersca@apple.com>
Build fix.
- Plugins/WebNetscapeDeprecatedFunctions.h:
- 3:58 PM Changeset in webkit [41370] by
-
- 2 edits in trunk/WebKit
2009-03-02 Anders Carlsson <andersca@apple.com>
WebNetscapePluginPackage.mm is an Objective-C++ file.
- WebKit.xcodeproj/project.pbxproj:
- 3:53 PM Changeset in webkit [41369] by
-
- 3 edits1 move in trunk/WebKit
WebKit:
2009-03-02 Anders Carlsson <andersca@apple.com>
Reviewed by John Sullivan.
Rename WebNetscapePluginPackage.m to WebNetscapePluginPackage.mm
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2009-03-02 Anders Carlsson <andersca@apple.com>
Reviewed by John Sullivan.
Rename WebNetscapePluginPackage.m to WebNetscapePluginPackage.mm
- Plugins/WebNetscapePluginPackage.m: Removed.
- Plugins/WebNetscapePluginPackage.mm: Copied from mac/Plugins/WebNetscapePluginPackage.m.
- 3:29 PM Changeset in webkit [41368] by
-
- 11 edits in trunk
Build fixes for wxWidgets Mac trunk build.
- 3:25 PM Changeset in webkit [41367] by
-
- 2 edits in trunk/WebCore
wxGTK missing header build fix.
- 1:55 PM Changeset in webkit [41366] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben.
- fix https://bugs.webkit.org/show_bug.cgi?id=21811 REGRESSION: Windows Build Not Selecting Proper Font
- platform/graphics/win/FontCacheWin.cpp: (WebCore::createGDIFont): Added back code to verify that the created HFONT has the requested face name.
- 1:38 PM Changeset in webkit [41365] by
-
- 2 edits in trunk/WebCore
Fixes a regression caused by splitting the input and output of console commands.
Reviewed by Kevin McCullough.
- inspector/front-end/Console.js: (WebInspector.Console.prototype.addMessage): Don't treat ConsoleCommandResult as a normal ConsoleMessage when appending. This prevents resetting repeatCounts incorrectly.
- 1:38 PM Changeset in webkit [41364] by
-
- 4 edits in trunk/WebCore
Make exception messages and logged Error objects display consistently.
Reviewed by Adam Roben.
- English.lproj/localizedStrings.js: Remove a string for line numbers.
- inspector/front-end/Console.js: (WebInspector.Console.prototype._enterKeyPressed): Pass the exception boolean to the ConsoleCommandResult constructor and don't pass level. (WebInspector.Console.prototype._formatnode): Fix a className typo. (WebInspector.Console.prototype._formaterror): Add an error-message classed span around the message to show in red and remove the console-message-url class from the link so it doesn't float right. Instead enclose the link in parentheses and use displayNameForURL to shorten the URL in the link. (WebInspector.ConsoleMessage.prototype.toMessageElement): Simplify how line numbers are shown since link underlining a string with parentheses looks bad. (WebInspector.ConsoleCommandResult): Take an exception boolean flag instead of a level and get line and URL based on that flag.
- inspector/front-end/inspector.css: Tweaks to the styles.
- 1:38 PM Changeset in webkit [41363] by
-
- 2 edits in trunk/WebKitTools
Allow for multiline quoted text in JavaScript files when looking for function names.
Reviewed by David Kilzer.
- Scripts/prepare-ChangeLog:
- 11:16 AM Changeset in webkit [41362] by
-
- 10 edits in trunk/WebCore
2009-03-02 Ojan Vafai <ojan@chromium.org>
Reviewed by Adele Peterson.
Bug 24048: extra windows button padding doesn't apply when there's no appearance
<https://bugs.webkit.org/show_bug.cgi?id=24048>
Replace adjustButtonInnerStyle with buttonInternalPaddingLeft/Right/Top/Bottom.
No tests added as existing tests already cover this behavior.
- rendering/RenderButton.cpp: (WebCore::RenderButton::setupInnerStyle):
- rendering/RenderTheme.cpp:
- rendering/RenderTheme.h: (WebCore::RenderTheme::buttonInternalPaddingLeft): (WebCore::RenderTheme::buttonInternalPaddingRight): (WebCore::RenderTheme::buttonInternalPaddingTop):
- rendering/RenderThemeChromiumGtk.cpp: (WebCore::RenderThemeWin::buttonInternalPaddingLeft): (WebCore::RenderThemeWin::buttonInternalPaddingRight): (WebCore::RenderThemeWin::buttonInternalPaddingTop): (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
- rendering/RenderThemeChromiumGtk.h:
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::buttonInternalPaddingLeft): (WebCore::RenderThemeChromiumWin::buttonInternalPaddingRight): (WebCore::RenderThemeChromiumWin::buttonInternalPaddingTop): (WebCore::RenderThemeChromiumWin::buttonInternalPaddingBottom):
- rendering/RenderThemeChromiumWin.h:
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::buttonInternalPaddingLeft): (WebCore::RenderThemeWin::buttonInternalPaddingRight): (WebCore::RenderThemeWin::buttonInternalPaddingTop): (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
- rendering/RenderThemeWin.h:
- 10:26 AM Changeset in webkit [41361] by
-
- 5 edits in trunk
2009-03-02 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Eric Seidel.
Add three new drt helper functions that enable all of the tests in
LayoutTests/animation/* and LayoutTests/transitions/* to now pass.
- Api/qwebframe.cpp: (qt_drt_pauseAnimation): (qt_drt_pauseTransitionOfProperty): (qt_drt_numberOfActiveAnimations):
- DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId): (LayoutTestController::numberOfActiveAnimations):
- DumpRenderTree/qt/jsobjects.h:
- 8:55 AM Changeset in webkit [41360] by
-
- 2 edits in trunk/WebKit/qt
2009-03-02 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=21230
On X11 match the behavior of Firefox and also copy the url to the
clipboard selection when the action Copy Link Location is executed.
- Api/qwebpage.cpp: (QWebPage::triggerAction):
- 8:30 AM Changeset in webkit [41359] by
-
- 2 edits in trunk/WebCore
2009-03-02 Adam Treat <adam.treat@torchmobile.com>
Build fix for Qt port. Remove unnecessary assert.
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::putImageData):
- 7:37 AM Changeset in webkit [41358] by
-
- 9 edits in trunk/WebCore
2009-03-02 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Adam Roben and previously by Eric Seidel and Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=24227
Ensure that the checkForSolidColor() optimization is correctly triggered
for all cases of drawPattern. Currently, the optimization was not triggered
when the check had not been previously performed via a request for the
image's NativeImagePtr.
Implement the Qt version of the checkForSolidColor() method. Combined with
the bug fix this reduces the time it takes to draw a repeating background
of a 1x1 image from ~50msecs to ~0msecs on my machine.
- platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage):
- platform/graphics/BitmapImage.h: (WebCore::BitmapImage::mayFillWithSolidColor):
- platform/graphics/Image.h: (WebCore::Image::mayFillWithSolidColor):
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor):
- platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor):
- platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::checkForSolidColor):
- platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImage::checkForSolidColor):
- platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::checkForSolidColor):
- 6:56 AM Changeset in webkit [41357] by
-
- 4 edits in trunk
2009-03-02 Gustavo Noronha Silva <Gustavo Noronha Silva>
Unreviewed build fix; adding missing files to EXTRA_DIST, so that
they show up in the tarball.
- GNUmakefile.am:
- 6:38 AM QtWebKitTodo edited by
- (diff)
- 6:38 AM Changeset in webkit [41356] by
-
- 1 edit in trunk/WebCore/ChangeLog
2009-03-02 Dirk Schulze <krit@webkit.org>
Just a correction of the ChangeLog. Removed Ariya Hidayat
from the reviewing process.
- 6:22 AM Changeset in webkit [41355] by
-
- 2 edits in trunk/WebCore
2009-03-02 Dirk Schulze <krit@webkit.org>
Reviewed by Holger Freyther, rubber-stamped by Ariya Hidayat.
Added putImageData to Qt.
[Qt] lacks putImageData support in Canvas
https://bugs.webkit.org/show_bug.cgi?id=22186
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::putImageData):
- 5:26 AM Changeset in webkit [41354] by
-
- 2 edits in trunk/WebKitTools
Windows build fix after r41349
- DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::getChildrenWithRange):
- 12:22 AM Changeset in webkit [41353] by
-
- 2 edits in trunk/WebCore
Show exception messages again when evaluating bad expressions in the
Web Inspector's console.
Reviewed by Oliver Hunt.
- bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState): Fix the order in which the exception is set and cleared now that the exception is stored in the shared GlobalData, not per ExecState.
- 12:22 AM Changeset in webkit [41352] by
-
- 3 edits1 add in trunk/WebCore
Make input in the Web Inspector console print before any output
that might be added by the called function.
Reviewed by Oliver Hunt.
- inspector/front-end/Console.js: (WebInspector.Console.prototype._enterKeyPressed): Add the command message before evaluating the result. Associate the originating command to the result, so if they are adjacent there is no divider. (WebInspector.ConsoleCommand): No longer take a result. (WebInspector.ConsoleCommand.prototype.toMessageElement): Result code removed since it isn't used now. (WebInspector.ConsoleCommandResult): Subclass ConsoleMessage. (WebInspector.ConsoleCommandResult.prototype.toMessageElement): Call the ConsoleMessage toMessageElement and add a style class.
- inspector/front-end/inspector.css: Add a new style class for adjacent results to hide the divider. Also tweak the position of the disclosure triangle for objects to not use the left margin.
Mar 1, 2009:
- 9:46 PM Changeset in webkit [41351] by
-
- 1 edit in trunk/WebKitTools/DumpRenderTree/mac/AccessibilityUIElementMac.mm
Fix the Mac build.
- 8:18 PM Changeset in webkit [41350] by
-
- 4 edits in trunk/JavaScriptCore
<rdar://problem/6635688> Move HAVE_DTRACE check to Base.xcconfig
Reviewed by Mark Rowe.
- Configurations/Base.xcconfig: Set HAVE_DTRACE Xcode variable based on PLATFORM_NAME and MAC_OS_X_VERSION_MAJOR. Also define it as a preprocessor macro by modifying GCC_PREPROCESSOR_DEFINITIONS.
- JavaScriptCore.xcodeproj/project.pbxproj: Changed "Generate DTrace header" script phase to check for HAVE_DTRACE instead of MACOSX_DEPLOYMENT_TARGET.
- wtf/Platform.h: Removed definition of HAVE_DTRACE macro since it's defined in Base.xcconfig now.
- 6:55 PM Changeset in webkit [41349] by
-
- 6 edits in trunk
Bug 24282: AX Palindrome error when asking for a specific index of the AXChildren array
<https://bugs.webkit.org/show_bug.cgi?id=24282>
- 4:45 PM Changeset in webkit [41348] by
-
- 2 edits in trunk/WebKit/mac
2009-03-01 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
WebKit side of <rdar://problem/6449689>
Pass the visible name to the plug-in host.
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
- 4:41 PM Changeset in webkit [41347] by
-
- 19 edits in trunk
2009-03-01 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
Bug 24251: Cleanup: replace positionForCoordinates with positionForPoint
<https://bugs.webkit.org/show_bug.cgi?id=24251>
Make RenderObject::positionForCoordinate non-virtual and
RenderObject::positionForPoint virtual in preparation for
removing positionFor* from RenderObject/RenderText.
- page/Frame.cpp: (WebCore::Frame::visiblePositionForPoint):
- rendering/RenderBR.cpp: (WebCore::RenderBR::positionForPoint):
- rendering/RenderBR.h:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForPoint):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint):
- rendering/RenderBox.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::positionForPoint):
- rendering/RenderInline.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::positionForCoordinates): (WebCore::RenderObject::positionForPoint):
- rendering/RenderObject.h:
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::positionForPoint):
- rendering/RenderReplaced.h:
- rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::positionForPoint):
- rendering/RenderSVGInlineText.h:
- rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint):
- rendering/RenderText.h:
- 4:41 PM Changeset in webkit [41346] by
-
- 4 edits in trunk/WebCore
2009-03-01 Larry Ewing <lewing@novell.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=24080
NPN_GetValue casting to the wrong type and writing outside bounds
Make sure to cast the value to the correct type so that only
memory owned by the value is written to.
- plugins/gtk/PluginViewGtk.cpp (PluginView::getValueStatic):
- plugins/qt/PluginViewQt.cpp (PluginView::getValueStatic):
- plugins/mac/PluginViewMac.cpp (PluginView::getValueStatic): (PluginView::getValue):
- 4:41 PM Changeset in webkit [41345] by
-
- 9 edits in trunk/WebCore
2009-03-01 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=24197 and
https://bugs.webkit.org/show_bug.cgi?id=23512
The Windows version of cgColor() is conditionally compiled using
!PLATFORM(MAC) change this to PLATFORM(WIN_OS) so that Chrome
can use the OS X version instead of the Windows version.
Also rename cgColor() -> createCGColor()
No observable change in behavior, so no test.
- platform/graphics/Color.h:
- platform/graphics/cg/ColorCG.cpp: (WebCore::createCGColor):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
- platform/graphics/mac/ColorMac.mm: (WebCore::createCGColor):
- platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawFocusRing):
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::setLayerBorderColor): (WebCore::setLayerBackgroundColor): (WebCore::GraphicsLayerCA::setBackgroundColor):
- platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::drawFocusRing):
- svg/graphics/filters/cg/SVGFEHelpersCg.mm: (WebCore::ciColor):
- 1:09 PM Changeset in webkit [41344] by
-
- 17 edits9 adds in trunk
WebCore:
2009-03-01 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Bug 24271: XMLHttpRequest needs js bindings for Workers.
<https://bugs.webkit.org/show_bug.cgi?id=24271>
Tests: http/tests/xmlhttprequest/workers/methods-async.html
http/tests/xmlhttprequest/workers/methods.html
- bindings/js/JSWorkerContextBase.cpp: (WebCore::JSWorkerContextBase::getOwnPropertySlot): (jsWorkerContextBaseXMLHttpRequest): (setJSWorkerContextBaseXMLHttpRequest): Expose XMLHttpRequest to Workers.
- bindings/js/JSWorkerContextBase.h:
- bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor): (WebCore::constructXMLHttpRequest): (WebCore::JSXMLHttpRequestConstructor::mark): Removed the dependencies on Document.
- bindings/js/JSXMLHttpRequestConstructor.h: (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext):
- dom/EventException.idl:
- dom/EventListener.idl: Chnage to have the NoStaticTables attribute since they are used from XHR.
- loader/WorkerThreadableLoader.cpp: (WebCore::workerContextDidFinishLoading): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading): Fixed identifier to be unsigned long.
- loader/WorkerThreadableLoader.h:
- workers/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Stop active objects when the thread is getting shutdown so that xhr gets properly shutdown.
- xml/XMLHttpRequestUpload.cpp:
- xml/XMLHttpRequest.idl:
- xml/XMLHttpRequestException.idl:
- xml/XMLHttpRequestProgressEvent.idl:
- xml/XMLHttpRequestUpload.idl: Chnage to have the NoStaticTables attribute since they are used from XHR.
LayoutTests:
2009-03-01 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Bug 24271: XMLHttpRequest needs js bindings for Workers.
<https://bugs.webkit.org/show_bug.cgi?id=24271>
Some sanity checks for xhr done from workers. These are the same as
tests done for normal workers.
- http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
- http/tests/xmlhttprequest/workers/methods-async.html: Added.
- http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
- http/tests/xmlhttprequest/workers/methods.html: Added.
- http/tests/xmlhttprequest/workers/resources/methods-async.js: Added. (onmessage): (log): (done): (onReqAbort): (onSyncReqError): (start): (processStateChange):
- http/tests/xmlhttprequest/workers/resources/methods.cgi: Copied from LayoutTests/http/tests/xmlhttprequest/methods.cgi.
- http/tests/xmlhttprequest/workers/resources/methods.js: Added. (log): (done):
- 12:14 PM Changeset in webkit [41343] by
-
- 1 edit in trunk/JavaScriptCore/parser/Nodes.h
Build fix. Add isBlock() back since there was a new client since the patch was made.
- 11:37 AM Applications using WebKit edited by
- (diff)
- 11:35 AM Changeset in webkit [41342] by
-
- 4 edits5 adds in trunk
2009-03-01 Horia Olaru <olaru@adobe.com>
By looking in grammar.y there are only a few types of statement nodes
on which the debugger should stop.
Removed isBlock and isLoop virtual calls. No need to emit debug hooks in
the "statementListEmitCode" method as long as the necessary hooks can be
added in each "emitCode".
Reviewed by Kevin McCullough.
- parser/Nodes.cpp: (JSC::ConstStatementNode::emitBytecode): (JSC::statementListEmitCode): (JSC::EmptyStatementNode::emitBytecode): (JSC::ExprStatementNode::emitBytecode): (JSC::VarStatementNode::emitBytecode): (JSC::IfNode::emitBytecode): (JSC::IfElseNode::emitBytecode): (JSC::DoWhileNode::emitBytecode): (JSC::WhileNode::emitBytecode): (JSC::ForNode::emitBytecode): (JSC::ForInNode::emitBytecode): (JSC::ContinueNode::emitBytecode): (JSC::BreakNode::emitBytecode): (JSC::ReturnNode::emitBytecode): (JSC::WithNode::emitBytecode): (JSC::SwitchNode::emitBytecode): (JSC::LabelNode::emitBytecode): (JSC::ThrowNode::emitBytecode): (JSC::TryNode::emitBytecode):
- parser/Nodes.h:
WebCore:
2009-03-01 Horia Olaru <olaru@adobe.com>
Adding manual debugger test cases for bug.
Reviewed by Kevin McCullough.
- manual-tests/inspector/debugger-step-on-do-while-statements.html: Added.
- manual-tests/inspector/debugger-step-on-for-in-statements.html: Added.
- manual-tests/inspector/debugger-step-on-for-statements.html: Added.
- manual-tests/inspector/debugger-step-on-while-statements.html: Added.
- manual-tests/inspector/resources/loop-statements.js: Added.
- 11:22 AM Changeset in webkit [41341] by
-
- 7 edits in trunk
2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259
Added API to get the response mime type from a frame. We need this
so we can decide if we need to dump the frame as text or its
render tree
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp:
2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259
Determine the frame's response and decide whether to dump as text
or the render tree
- DumpRenderTree/gtk/DumpRenderTree.cpp: (dump):
2009-02-28 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259
Enable http tests, excluding tests/folders that fail or untested
- platform/gtk/Skipped:
- 11:21 AM Changeset in webkit [41340] by
-
- 4 edits in trunk/WebKitTools
2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259
Implement dumping of WebKitWebBackForwardList and its history
items.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (compareHistoryItems): (dumpHistoryItem): (dumpBackForwardListForWebView): (dump): (runTest):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::clearBackForwardList):
- DumpRenderTree/gtk/WorkQueueItemGtk.cpp: (BackForwardItem::invoke):
- 11:21 AM Changeset in webkit [41339] by
-
- 4 edits in trunk/WebKit/gtk
2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259
Create a WebKitWebHistoryItem for each WebCore::HistoryItem when
necessary.
Add necessary API additions for us to be able to dump a WebKitWebHistoryItem
- webkit/webkitprivate.h:
- webkit/webkitwebbackforwardlist.cpp: (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit): (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit):
- webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_target): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_children): (WebKit::core): (WebKit::kit):
- 11:02 AM Changeset in webkit [41338] by
-
- 4 edits2 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts
Test: fast/events/scroll-during-zoom-change.html
- dom/Document.cpp: (WebCore::Document::recalcStyle): Pause scheduled events during style reclaculation. Changes to the zoom property result in scroll events being generated during style recalc, and those events need to be deferred until the render tree is consistent.
- page/FrameView.cpp: (WebCore::FrameView::layout): Changed to account for a case in which the post-layout tasks trigger a nested layout, which reactivates the post-layout task timer.
LayoutTests:
Reviewed by Darin Adler.
- test for <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts
- fast/events/scroll-during-zoom-change-expected.txt: Added.
- fast/events/scroll-during-zoom-change.html: Added.
- 11:00 AM Changeset in webkit [41337] by
-
- 4 edits in trunk/WebKit/gtk
2009-03-01 Christian Dywan <christian@twotoasts.de>
Reviewed by Holger Freyther.
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp: (webkit_web_view_get_encoding):
- webkit/webkitwebview.h: Implement 'encoding' and 'custom-encoding' properties as well as webkit_web_view_get_encoding.
- 10:47 AM Changeset in webkit [41336] by
-
- 2 edits in trunk/WebKitTools
2009-02-28 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Holger Freyther.
Set the resolution for the default screen to 72.0.
This way, setting font sizes results in expected values.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (setDefaultsToConsistentStateValuesForTesting):
- 8:53 AM Changeset in webkit [41335] by
-
- 3 edits in trunk/WebCore
Alphabetically sort scripts in the Script's panel file popup menu.
Reviewed by Timothy Hatcher.
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
- inspector/front-end/utilities.js: (insertionIndexForObjectInListSortedByFunction): (indexOfObjectInListSortedByFunction):
- 8:42 AM Changeset in webkit [41334] by
-
- 3 edits in trunk/WebCore
Pass securityOrigin->host() instead of securityOrigin->domain() to WebInspector
when creating databases, localStorage or sessionStorage. Changing document.domain
should have no affect on databases, localStorage and sessionStorage in Web Inspector.
Reviewed by Timothy Hatcher.
- inspector/InspectorController.cpp: (WebCore::InspectorController::addDOMStorageScriptResource): (WebCore::InspectorController::didUseDOMStorage):
- storage/Database.cpp: (WebCore::Database::openDatabase):
- 8:22 AM Changeset in webkit [41333] by
-
- 2 edits in trunk/WebCore
2009-03-01 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
Avoid leaking errors when reporting GIO errors.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::readCallback): (WebCore::openCallback): (WebCore::queryInfoCallback):
- 8:21 AM Changeset in webkit [41332] by
-
- 2 edits in trunk/WebCore
2009-03-01 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
Fixes crash when the GIO backend is given the URI for a directory.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::networkErrorForFile):
- 8:04 AM Changeset in webkit [41331] by
-
- 2 edits in trunk/WebKit/gtk
Simple wording fix for the NEWS file.
- 7:39 AM Changeset in webkit [41330] by
-
- 2 edits in trunk
2009-03-01 Christian Dywan <christian@twotoasts.de>
- configure.ac: Bump GTK port version to 1.1.1.
- 7:38 AM Changeset in webkit [41329] by
-
- 1 edit1 add in trunk/WebKit/gtk
2009-03-01 Xan Lopez <xan@gnome.org>
Add NEWS file to track progress between releases.
- NEWS: Added.
- 7:29 AM Changeset in webkit [41328] by
-
- 2 edits in trunk/WebKitTools
2009-02-28 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
Adds a WebKitMakeArguments environment variable to enable passing
of arguments such as '-j2' to make for the autotools build.
- Scripts/webkitdirs.pm:
- 7:28 AM Changeset in webkit [41327] by
-
- 2 edits in trunk/WebKitTools
2009-02-28 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
Add a GTK+-only option to enable GNOME Keyring when building.
- Scripts/build-webkit:
Feb 28, 2009:
- 10:21 PM Changeset in webkit [41326] by
-
- 2 edits in trunk/WebKitTools
2009-02-28 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[Gtk] webkitdirs.pm modify path in when detecting 3D transforms and accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=24076
Refactor gtk lib detection and put it in builtDylibPathForName
- Scripts/webkitdirs.pm:
- 9:28 PM Changeset in webkit [41325] by
-
- 3 edits in trunk/WebCore
2009-02-28 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=24261
Fix V8 custom binding scrubbing error.
Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
Test: traversal/exception-forwarding.html
TesT: traversal/stay-within-root.html
- bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
- bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::toV8): Replace v8::Undefined() return value with v8::Null().
- bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::toV8): Ditto.
- 8:27 PM Changeset in webkit [41324] by
-
- 2 edits in trunk/WebCore
2009-02-28 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=24261
Fix V8 custom binding scrubbing error.
Test: fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html
- WebCore.xcodeproj/project.pbxproj:
- bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: (WebCore::cssPropertyName): Remove dubious checks, left over from
incomplete conversion of parameter from pointer to pass-by-ref.
(WebCore::NAMED_PROPERTY_GETTER): Initialize parameter.
(WebCore::NAMED_PROPERTY_SETTER): Ditto.
- 6:47 PM Changeset in webkit [41323] by
-
- 3 edits in trunk/LayoutTests
- correct a color profile mismatch in expected pixel results
- platform/mac/fast/gradients/background-clipped-expected.checksum:
- platform/mac/fast/gradients/background-clipped-expected.png:
- 12:29 PM Changeset in webkit [41322] by
-
- 2 edits in trunk/WebCore
Add a ref to the ResourceHandle in startHttp so we can keep it
alive untill all callbacks have been executed, and unref it when
soup tells us it's done with the SoupMessage (in
finishedCallback). Fixes a number of crashes when calling
didReceiveData whould crash because of the handle dying.
- 12:12 PM Changeset in webkit [41321] by
-
- 2 edits in trunk/WebKitTools
Use the new webkit_web_view_load_uri to open URIs.
- 12:04 PM Changeset in webkit [41320] by
-
- 2 edits in trunk/WebKit/gtk
- webkit/webkitwebview.cpp: Let webkit_web_view_open add file:// if a
locale path is passed for compatibility, since we used to support that.
- 6:43 AM Changeset in webkit [41319] by
-
- 2 edits in trunk/WebCore
2009-02-28 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=24226
[SOUP] HTTP status text is never set
Set HTTP status text to SoupMessage reason_phrase.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
- 2:01 AM Changeset in webkit [41318] by
-
- 2 edits in trunk/WebCore
- fix malformed project file
- WebCore.xcodeproj/project.pbxproj:
- 1:44 AM Changeset in webkit [41317] by
-
- 4 edits4 adds in trunk
WebCore:
Reviewed by Oliver Hunt.
- fix https://bugs.webkit.org/show_bug.cgi?id=23848 <rdar://problem/6573250> REGRESSION: Crash when mouse cursor moves over a link on www.opportuno.de
Test: fast/layers/inline-dirty-z-order-lists.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange): Moved the code that dirties a layer's and its stacking context's z-order lists when the layer's z-index or visibility change from here...
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::styleWillChange): ...to here, so that it will apply to RenderInline too.
LayoutTests:
Reviewed by Oliver Hunt.
- test for https://bugs.webkit.org/show_bug.cgi?id=23848 <rdar://problem/6573250> REGRESSION: Crash when mouse cursor moves over a link on www.opportuno.de
- fast/layers/inline-dirty-z-order-lists.html: Added.
- platform/mac/fast/layers/inline-dirty-z-order-lists-expected.checksum: Added.
- platform/mac/fast/layers/inline-dirty-z-order-lists-expected.png: Added.
- platform/mac/fast/layers/inline-dirty-z-order-lists-expected.txt: Added.
- 12:45 AM Changeset in webkit [41316] by
-
- 2 edits in trunk/WebKit/mac
2009-02-27 Alice Liu <alice.liu@apple.com>
Fix <rdar://problem/6531265> REGRESSION (r39185): adding ".jpeg"
extension to images that already have .jpg extension
Reviewed by Oliver Hunt.
- WebView/WebHTMLView.mm: (-[NSString matchesExtensionEquivalent:]): (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Relax the check for the proper extension to allow for known equivalents, special-cased in matchesExtensionEquivalent function.
- 12:06 AM Changeset in webkit [41315] by
-
- 4 edits in trunk/WebCore
Reviewed by David Hyatt.
Don't include TextResourceDecoder.h in Document.h
This undoes inlining of Document::displayStringModifiedByEncoding() to avoid world rebuilds
when TextResourceDecoder.h is modified. Performance impact is expected to be negligible.
