Timeline



May 6, 2009:

11:48 PM Changeset in webkit [43335] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-05-06 Julie Parent <jparent@google.com>

Reviewed by Eric Seidel.

Bug 25608: Unused m_frame in ChromiumClipboard.
https://bugs.webkit.org/show_bug.cgi?id=25608

  • platform/chromium/ClipboardChromium.h:

No tests added as this is only removing dead code, no functional changes.

11:36 PM Changeset in webkit [43334] by ggaren@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-05-06 Geoffrey Garen <ggaren@apple.com>

Reviewed by Gavin "++" Barraclough.


Added some abstraction around the JIT stub calling convention by creating
a struct to represent the persistent stack frame JIT code shares with
JIT stubs.


SunSpider reports no change.

  • jit/JIT.h:
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_convert_this): (JSC::JITStubs::cti_op_end): (JSC::JITStubs::cti_op_add): (JSC::JITStubs::cti_op_pre_inc): (JSC::JITStubs::cti_timeout_check): (JSC::JITStubs::cti_register_file_check): (JSC::JITStubs::cti_op_loop_if_less): (JSC::JITStubs::cti_op_loop_if_lesseq): (JSC::JITStubs::cti_op_new_object): (JSC::JITStubs::cti_op_put_by_id_generic): (JSC::JITStubs::cti_op_get_by_id_generic): (JSC::JITStubs::cti_op_put_by_id): (JSC::JITStubs::cti_op_put_by_id_second): (JSC::JITStubs::cti_op_put_by_id_fail): (JSC::JITStubs::cti_op_get_by_id): (JSC::JITStubs::cti_op_get_by_id_second): (JSC::JITStubs::cti_op_get_by_id_self_fail): (JSC::JITStubs::cti_op_get_by_id_proto_list): (JSC::JITStubs::cti_op_get_by_id_proto_list_full): (JSC::JITStubs::cti_op_get_by_id_proto_fail): (JSC::JITStubs::cti_op_get_by_id_array_fail): (JSC::JITStubs::cti_op_get_by_id_string_fail): (JSC::JITStubs::cti_op_instanceof): (JSC::JITStubs::cti_op_del_by_id): (JSC::JITStubs::cti_op_mul): (JSC::JITStubs::cti_op_new_func): (JSC::JITStubs::cti_op_call_JSFunction): (JSC::JITStubs::cti_op_call_arityCheck): (JSC::JITStubs::cti_vm_dontLazyLinkCall): (JSC::JITStubs::cti_vm_lazyLinkCall): (JSC::JITStubs::cti_op_push_activation): (JSC::JITStubs::cti_op_call_NotJSFunction): (JSC::JITStubs::cti_op_create_arguments): (JSC::JITStubs::cti_op_create_arguments_no_params): (JSC::JITStubs::cti_op_tear_off_activation): (JSC::JITStubs::cti_op_tear_off_arguments): (JSC::JITStubs::cti_op_profile_will_call): (JSC::JITStubs::cti_op_profile_did_call): (JSC::JITStubs::cti_op_ret_scopeChain): (JSC::JITStubs::cti_op_new_array): (JSC::JITStubs::cti_op_resolve): (JSC::JITStubs::cti_op_construct_JSConstruct): (JSC::JITStubs::cti_op_construct_NotJSConstruct): (JSC::JITStubs::cti_op_get_by_val): (JSC::JITStubs::cti_op_get_by_val_string): (JSC::JITStubs::cti_op_get_by_val_byte_array): (JSC::JITStubs::cti_op_resolve_func): (JSC::JITStubs::cti_op_sub): (JSC::JITStubs::cti_op_put_by_val): (JSC::JITStubs::cti_op_put_by_val_array): (JSC::JITStubs::cti_op_put_by_val_byte_array): (JSC::JITStubs::cti_op_lesseq): (JSC::JITStubs::cti_op_loop_if_true): (JSC::JITStubs::cti_op_load_varargs): (JSC::JITStubs::cti_op_negate): (JSC::JITStubs::cti_op_resolve_base): (JSC::JITStubs::cti_op_resolve_skip): (JSC::JITStubs::cti_op_resolve_global): (JSC::JITStubs::cti_op_div): (JSC::JITStubs::cti_op_pre_dec): (JSC::JITStubs::cti_op_jless): (JSC::JITStubs::cti_op_not): (JSC::JITStubs::cti_op_jtrue): (JSC::JITStubs::cti_op_post_inc): (JSC::JITStubs::cti_op_eq): (JSC::JITStubs::cti_op_lshift): (JSC::JITStubs::cti_op_bitand): (JSC::JITStubs::cti_op_rshift): (JSC::JITStubs::cti_op_bitnot): (JSC::JITStubs::cti_op_resolve_with_base): (JSC::JITStubs::cti_op_new_func_exp): (JSC::JITStubs::cti_op_mod): (JSC::JITStubs::cti_op_less): (JSC::JITStubs::cti_op_neq): (JSC::JITStubs::cti_op_post_dec): (JSC::JITStubs::cti_op_urshift): (JSC::JITStubs::cti_op_bitxor): (JSC::JITStubs::cti_op_new_regexp): (JSC::JITStubs::cti_op_bitor): (JSC::JITStubs::cti_op_call_eval): (JSC::JITStubs::cti_op_throw): (JSC::JITStubs::cti_op_get_pnames): (JSC::JITStubs::cti_op_next_pname): (JSC::JITStubs::cti_op_push_scope): (JSC::JITStubs::cti_op_pop_scope): (JSC::JITStubs::cti_op_typeof): (JSC::JITStubs::cti_op_is_undefined): (JSC::JITStubs::cti_op_is_boolean): (JSC::JITStubs::cti_op_is_number): (JSC::JITStubs::cti_op_is_string): (JSC::JITStubs::cti_op_is_object): (JSC::JITStubs::cti_op_is_function): (JSC::JITStubs::cti_op_stricteq): (JSC::JITStubs::cti_op_to_primitive): (JSC::JITStubs::cti_op_strcat): (JSC::JITStubs::cti_op_nstricteq): (JSC::JITStubs::cti_op_to_jsnumber): (JSC::JITStubs::cti_op_in): (JSC::JITStubs::cti_op_push_new_scope): (JSC::JITStubs::cti_op_jmp_scopes): (JSC::JITStubs::cti_op_put_by_index): (JSC::JITStubs::cti_op_switch_imm): (JSC::JITStubs::cti_op_switch_char): (JSC::JITStubs::cti_op_switch_string): (JSC::JITStubs::cti_op_del_by_val): (JSC::JITStubs::cti_op_put_getter): (JSC::JITStubs::cti_op_put_setter): (JSC::JITStubs::cti_op_new_error): (JSC::JITStubs::cti_op_debug): (JSC::JITStubs::cti_vm_throw):
  • jit/JITStubs.h: (JSC::):
8:38 PM Changeset in webkit [43333] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Simon Fraser and Justin Garcia.

  • fix another part of <rdar://problem/6703873> Triple-click quoted line and type Return creates an extra quoted blank line

Test: editing/inserting/6703873-2.html

  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): Corrected the logic for determining the first node that should go into the new blockquote given the split position: if it is at the end of a container, use the next node after the container. Otherwise, use the child at the position's offset.

LayoutTests:

Reviewed by Simon Fraser and Justin Garcia.

  • test for another part of <rdar://problem/6703873> Triple-click quoted line and type Return creates an extra quoted blank line
  • editing/inserting/6703873-2-expected.txt: Added.
  • editing/inserting/6703873-2.html: Added.
6:23 PM Changeset in webkit [43332] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-05-06 Simon Fraser <Simon Fraser>

Rubber-stampted by Eric Seidel

Add braces to clarify logic flow in RenderObject::adjustStyleDifference.
Only affects ACCELERATED_COMPOSITING builds.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::adjustStyleDifference):
5:06 PM Changeset in webkit [43331] by barraclough@apple.com
  • 15 edits in trunk/JavaScriptCore

2009-05-06 Gavin Barraclough <barraclough@apple.com>

Reviewed by Maciej Stachowiak & Darin Adler.

Improve string concatenation (as coded in JS as a sequence of adds).

Detect patterns corresponding to string concatenation, and change the bytecode
generation to emit a new op_strcat instruction. By handling the full set of
additions within a single function we do not need allocate JSString wrappers
for intermediate results, and we can calculate the size of the output string
prior to allocating storage, in order to prevent reallocation of the buffer.

1.5%-2% progression on Sunspider, largely due to a 30% progression on date-format-xparb.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):

Add new opcodes.

  • bytecode/Opcode.h:

Add new opcodes.

  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitStrcat): (JSC::BytecodeGenerator::emitToPrimitive):

Add generation of new opcodes.

  • bytecompiler/BytecodeGenerator.h:

Add generation of new opcodes.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):

Add implmentation of new opcodes.

  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):

Add implmentation of new opcodes.

  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_to_primitive): (JSC::JITStubs::cti_op_strcat):

Add implmentation of new opcodes.

  • jit/JITStubs.h:

Add implmentation of new opcodes.

  • parser/Nodes.cpp: (JSC::BinaryOpNode::emitStrcat): (JSC::BinaryOpNode::emitBytecode): (JSC::ReadModifyResolveNode::emitBytecode):

Add generation of new opcodes.

  • parser/Nodes.h: (JSC::ExpressionNode::): (JSC::AddNode::):

Add methods to allow identification of add nodes.

  • parser/ResultType.h: (JSC::ResultType::definitelyIsString): (JSC::ResultType::forAdd):

Fix error in detection of adds that will produce string results.

  • runtime/Operations.h: (JSC::concatenateStrings):

Add implmentation of new opcodes.

  • runtime/UString.cpp: (JSC::UString::appendNumeric):

Add methods to append numbers to an existing string.

  • runtime/UString.h: (JSC::UString::Rep::createEmptyBuffer): (JSC::UString::BaseString::BaseString):

Add support for creating an empty string with a non-zero capacity available in the BaseString.

4:56 PM Changeset in webkit [43330] by kevino@webkit.org
  • 7 edits in trunk

wx build fix, fixes for wx trunk builds.

3:55 PM Changeset in webkit [43329] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-05-06 Albert J. Wong <ajwong@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=25597
Fix API drift compile errors that occurred while this was ifdef-ed out.
The two big issues were that RenderObject::element() became
RenderObject::node() and some of the wk* drawing functions had
an extra theme parameter added to the argument list.

  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::paintMediaFullscreenButton): (WebCore::RenderThemeChromiumMac::paintMediaMuteButton): (WebCore::RenderThemeChromiumMac::paintMediaPlayButton): (WebCore::RenderThemeChromiumMac::paintMediaSeekBackButton): (WebCore::RenderThemeChromiumMac::paintMediaSeekForwardButton): (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb):
3:00 PM Changeset in webkit [43328] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-05-06 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25385
Upstream changes to V8 bindings for supporting nested workers.

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::ToV8Object): (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object):
  • bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::getEventListener): (WebCore::ACCESSOR_SETTER WorkerOnmessage): (WebCore::CALLBACK_FUNC_DECL WorkerAddEventListener):
3:00 PM Changeset in webkit [43327] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-05-06 Dave Moore <davemoore@google.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25513
The V8 bindings convert every javascript property to its associated css style
name. It then calls functions that convert that name to an id. This makes
getting or setting css styles on elements slow.

The patch fixes this by caching the results of the transformation, mapping a
javascript property name to its css property id. It then calls the already
public webkit methods that take the id in place of the string property names.

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
3:00 PM Changeset in webkit [43326] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-05-06 Nate Chapin <japhet@google.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25591
Upstream V8HTMLFormElement from the Chromium repository.

  • bindings/v8/custom/V8HTMLFormElementCustom.cpp: (WebCore::INDEXED_PROPERTY_GETTER HTMLFormElement): Upstreamed from Chromium repository (WebCore::NAMED_PROPERTY_GETTER HTMLFormElement): Changed empty element return case to return notHandledByInterceptor(); (WebCore::CALLBACK_FUNC_DECL HTMLFormElementSubmit): Upstreamed from Chromium repository
2:59 PM Changeset in webkit [43325] by levin@chromium.org
  • 1 edit
    1 add in trunk/WebCore

2009-05-06 Albert J. Wong <ajwong@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25595
Upstream V8CanvasPixelArrayCustom from chromium port tree.

  • bindings/v8/V8CanvasPixelArrayCustom.cpp: Added.
2:31 PM Changeset in webkit [43324] by Simon Fraser
  • 3 edits in trunk/WebCore

2009-05-06 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

<rdar://problem/6862550> Reduce size of RenderText in 64-bit

Rearrange data members of RenderText so that an int comes
first, to minimize padding.

  • rendering/RenderText.cpp: (WebCore::RenderText::RenderText):
  • rendering/RenderText.h:
2:21 PM Changeset in webkit [43323] by Simon Fraser
  • 3 edits in trunk/WebCore

2009-05-06 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

<rdar://problem/6862823> Reduce size of RenderStyle in 64-bit

Rearrange data members of RenderStyle to minimize padding
when building for 64-bit.

  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::RenderStyle):
  • rendering/style/RenderStyle.h: (WebCore::):
2:07 PM Changeset in webkit [43322] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-05-06 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25596

Fixes Chromium build bustage caused by r43317 (making
RefCountedBase::m_refCount private)

  • page/chromium/AccessibilityObjectWrapper.h: (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper):
12:57 PM Changeset in webkit [43321] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-05-06 Hin-Chung Lam <hclam@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=25593

Refactor for MediaPlayerPrivate for Chromium port. Remove
the implementation of MediaPlayerPrivateInferface from it.

12:46 PM Changeset in webkit [43320] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2009-05-06 Daniel Nylander <po@danielnylander.se>

Rubber-stamped by Gustavo Noronha.

Swedish translation for WebKitGTK+.

  • sv.po: Added.
12:38 PM Changeset in webkit [43319] by kov@webkit.org
  • 5 edits in trunk/WebKit/gtk

2009-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=24786
WebKitDownload sometimes suggests peculiar filenames

When a download is requested by an ongoing request, use the already
provided response to set the suggested filename for the WebKitDownload
object, if available.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::download):
  • webkit/webkitdownload.cpp: (_WebKitDownloadPrivate::webkit_download_set_property): (_WebKitDownloadPrivate::webkit_download_get_suggested_filename): (_WebKitDownloadPrivate::webkit_download_set_suggested_filename):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp:
12:23 PM Changeset in webkit [43318] by sfalken@apple.com
  • 4 edits in trunk

WebKit/win:

2009-05-06 Steve Falkenburg <sfalken@apple.com>

Change default value of WebKitPaintNativeControls to true.


Reviewed by Adam Roben.

  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):

WebKitTools:

2009-05-06 Steve Falkenburg <sfalken@apple.com>

Explicitly set WebKitPaintNativeControls to false to allow Windows results to match Mac.

Reviewed by Adam Roben.

  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
12:15 PM Changeset in webkit [43317] by Darin Adler
  • 3 edits in trunk/JavaScriptCore

2009-05-06 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Made RefCounted::m_refCount private.

  • runtime/Structure.h: Removed addressOfCount.
  • wtf/RefCounted.h: Made m_refCount private. Added addressOfCount.
11:57 AM Changeset in webkit [43316] by Simon Fraser
  • 3 edits in trunk/WebCore

2009-05-06 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt, Dan Bernstein

<rdar://problem/6860197> Reduce the size of FontFallbackList in 64-bit

Re-order the data members of FontFallbackList to save 8 bytes when building 64-bit.

  • platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::FontFallbackList):
  • platform/graphics/FontFallbackList.h:
11:47 AM Changeset in webkit [43315] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-05-06 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler, Dan Bernstein

<rdar://problem/6860068> Reduce size of InlineBox in 64-bit

Re-order the data members of InlineBox to save 8 bytes when building 64-bit.

  • rendering/InlineBox.h: (WebCore::InlineBox::InlineBox):
11:28 AM Changeset in webkit [43314] by levin@chromium.org
  • 1 edit
    1 add in trunk/WebCore

2009-05-06 David Levin <levin@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25588
Adding the custom v8 bindings Document.location.

  • bindings/v8/custom/V8DocumentLocationCustom.cpp: Added.
11:17 AM Changeset in webkit [43313] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2009-05-06 Darin Adler <Darin Adler>

Fixed assertion seen a lot!

  • parser/Nodes.cpp: (JSC::FunctionBodyNode::~FunctionBodyNode): Removed now-bogus assertion.
10:50 AM Changeset in webkit [43312] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2009-05-06 Kevin McCullough <kmccullough@apple.com>

-Clarified a comment

  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
10:10 AM Changeset in webkit [43311] by Darin Adler
  • 9 edits
    1 copy in trunk/JavaScriptCore

2009-05-06 Darin Adler <Darin Adler>

Working with Sam Weinig.

Redo parse tree constructor optimization without breaking the Windows
build the way I did yesterday. The previous try broke the build by adding
an include of Lexer.h and all its dependencies that had to work outside
the JavaScriptCore project.

  • GNUmakefile.am: Added NodeConstructors.h.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Removed byteocde directory -- we no longer are trying to include Lexer.h outside JavaScriptCore.
  • JavaScriptCore.xcodeproj/project.pbxproj: Change SegmentedVector.h and Lexer.h back to internal files. Added NodeConstructors.h.
  • parser/Grammar.y: Added include of NodeConstructors.h. Changed use of ConstDeclNode to use public functions.
  • parser/NodeConstructors.h: Copied from parser/Nodes.h. Just contains the inlined constructors now.
  • parser/Nodes.cpp: Added include of NodeConstructors.h. Moved node constructors into the header. (JSC::FunctionBodyNode::FunctionBodyNode): Removed m_refCount initialization.
  • parser/Nodes.h: Removed all the constructor definitions, and also removed the JSC_FAST_CALL from them since these are all inlined, so the calling convention is irrelevant. Made more things private. Used a data member for operator opcodes instead of a virtual function. Removed the special FunctionBodyNode::ref/deref functions since the default functions are now just as fast.
  • runtime/FunctionConstructor.cpp: (JSC::extractFunctionBody): Fixed types here so we don't typecast until after we do type checking.
8:44 AM Changeset in webkit [43310] by Nikolas Zimmermann
  • 21 edits in trunk/WebCore

Not reviewed. Fix WML enabled builds by including "MappedAttribute.h" in several places.

8:24 AM Changeset in webkit [43309] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Disable more new tests.

  • platform/gtk/Skipped:
7:25 AM Changeset in webkit [43308] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-05-06 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=25526
[Gtk] Additional support is needed for caret browsing

Emit AtkText::text-selection-changed when the selection changes
and the current selection is of Range (ie, the start and end
positions are different) type. This seems to match what Gecko
does.

  • editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
7:24 AM Changeset in webkit [43307] by xan@webkit.org
  • 3 edits
    2 adds in trunk/WebCore

2009-05-05 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=25526
[Gtk] Additional support is needed for caret browsing

Emit AtkText::text-caret-moved when selection changes.

  • GNUmakefile.am:
  • editing/SelectionController.h:
  • editing/gtk/SelectionController.cpp: Added. (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
7:04 AM Changeset in webkit [43306] by zecke@webkit.org
  • 3 edits in trunk/WebCore

2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Gustavo Noronha.

Use mozilla cursors for the previously not implemented
cursors. The manual-tests/cursor.html is looking complete
now.

  • platform/gtk/CursorGtk.cpp: (WebCore::cellCursor): (WebCore::noDropCursor): (WebCore::progressCursor): (WebCore::noneCursor): (WebCore::notAllowedCursor): (WebCore::grabCursor): (WebCore::grabbingCursor):
  • platform/gtk/CursorGtk.h:
7:03 AM Changeset in webkit [43305] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Xan Lopez.

Properly indent the header file.

  • platform/gtk/CursorGtk.h:
7:03 AM Changeset in webkit [43304] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Gustavo Noronha.

Use the mozilla copyright header. Use MPL1.1/GPL2.0
and LGPL2.1 as the license compared to LGPL2.0.

  • platform/gtk/CursorGtk.h:
7:03 AM Changeset in webkit [43303] by zecke@webkit.org
  • 3 edits in trunk/WebCore

2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Gustavo Noronha.

Move PluginView::invalidateRegion from the
TemporaryLinkStubs to PluginViewGtk.cpp and implement
it with a call to Widget::invalidate() just like
mac is doing. Optimisations would have to be window
system specific.

  • platform/gtk/TemporaryLinkStubs.cpp:
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::invalidateRegion):
6:56 AM Changeset in webkit [43302] by jmalonzo@webkit.org
  • 14 edits in trunk/WebKit/gtk

2009-05-06 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

GTK+ API implementation files have bogus extern "C" entries
https://bugs.webkit.org/show_bug.cgi?id=24322

Remove bogus extern "C" from the source files.

  • webkit/webkitdownload.cpp: (DownloadClient::cannotShowURL):
  • webkit/webkiterror.cpp: (webkit_plugin_error_quark):
  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_get_uri):
  • webkit/webkitprivate.cpp: (webkit_init):
  • webkit/webkitversion.cpp: (webkit_micro_version):
  • webkit/webkitwebbackforwardlist.cpp:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_get_load_status):
  • webkit/webkitwebhistoryitem.cpp:
  • webkit/webkitwebinspector.cpp: (webkit_web_inspector_set_inspector_client):
  • webkit/webkitwebnavigationaction.cpp: (webkit_web_navigation_action_get_modifier_state):
  • webkit/webkitwebpolicydecision.cpp: (webkit_web_policy_decision_cancel):
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_get_spell_languages):
  • webkit/webkitwebview.cpp:
  • webkit/webkitwebwindowfeatures.cpp: (webkit_web_window_features_equal):
6:24 AM Changeset in webkit [43301] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-06 Eric Seidel <eric@webkit.org>

No review, just fixing my previous broken commit.

Commit correct results for event-function-toString.html

  • fast/events/event-function-toString-expected.txt:
6:20 AM Changeset in webkit [43300] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Fixing typo in my last commit.

  • platform/gtk/Skipped:
6:12 AM Changeset in webkit [43299] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Disabling failing new tests that do not represent regressions.

  • platform/gtk/Skipped:
6:12 AM Changeset in webkit [43298] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Fix the Qt build on Windows.

6:11 AM Changeset in webkit [43297] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Fix the Qt build on Windows.

6:11 AM Changeset in webkit [43296] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Enable the JIT for the Qt build on Windows.

5:24 AM Changeset in webkit [43295] by jmalonzo@webkit.org
  • 4 edits in trunk

2009-05-06 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

Misc fixes to InspectorClientGtk.

  • GNUmakefile.am: Add localizedStrings.js to webinspector_DATA. This prevents copious amounts "Localized string not found" errors in the console

2009-05-06 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

Misc fixes to InspectorClientGtk.

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::createPage): use g_filename_to_uri to get the URI and use web_view_load_uri instead of the deprecated web_view_open method for loading the URI. (WebKit::InspectorClient::localizedStringsURL): implement.
3:40 AM QtWebKitJournal edited by Simon Hausmann
(diff)
3:39 AM QtWebKitTodo edited by Simon Hausmann
(diff)
3:32 AM Applications using WebKit edited by dan@f-box.org
adding Air Browser (diff)
3:26 AM Changeset in webkit [43294] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

2009-05-05 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Improve behaviour of the QWebElement enclose* functions, to work
similar to the jQuery wrap functions. We now enclose the contents
of the element in the child of the deepest descendant element
within the structure of the enclose element structure given.

3:23 AM Changeset in webkit [43293] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-05-06 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

After commit rev @43215, setHtml() without a <head> tag,
automatically adds it, so update our test case to respect this.

2:34 AM Changeset in webkit [43292] by Simon Hausmann
  • 4 edits in trunk

JavaScriptCore:

2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Tweak JavaScriptCore.pri for being able to override the generated sources dir for the
generated_files target.

WebCore:

2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Tweak WebCore.pro for being able to override the generated sources dir for the
generated_files target.

2:12 AM Changeset in webkit [43291] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Holger Freyther.

Fix the Qt/Windows build, use iface instead of interface to avoid conflict
with VS2005 headers.

1:53 AM Changeset in webkit [43290] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-05-06 Joerg Bornemann <joerg.bornemann@trolltech.com>

Reviewed by Simon Hausmann.

We need to include StringExtras.h on Windows CE to access the strdup function.

1:25 AM Changeset in webkit [43289] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2009-05-06 Soren Gjesse <sgjesse@chromium.org>

Reviewed by Eric Seidel.

Changed the toString behaviour for non document dom node event handlers in the V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=25544

In the V8 bindings non document dom node event handlers are wrapped in a number of with blocks and uses an inner
function. This causes the default toString on such a handler to return all this wrapper code. As some web sites
use the source of an event handler to create new functions this wrapper code causes compatibility problems.

Create a specific toString function for these handlers which will return a function source compatible with the
source returned by the JSC bindings and other browsers.

Test: fast/events/event-function-toString.html

  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener): (WebCore::V8LazyEventListener::getListenerFunction): (WebCore::V8LazyEventListenerToString): (WebCore::V8LazyEventListener::getWrappedListenerFunction):
  • bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::create):
1:20 AM Changeset in webkit [43288] by vestbo@webkit.org
  • 11 edits in trunk

Build QtWebKit as a framework on Mac

This implies both debug and release build by default, unless
one of the --debug or --release config options are passed to
the build-webkit script.

Frameworks can be disabled by passing CONFIG+=webkit_no_framework
to the build-webkit script.

To be able to build both debug and release targets in parallel
we have to use separate output directories for the generated
sources, which is not optimal, but required to avoid race conditions.

An optimization would be to only require this spit-up on Mac.

1:20 AM Changeset in webkit [43287] by vestbo@webkit.org
  • 4 edits in trunk

[Qt] Use $$GENERATED_SOURCES_DIR as output when running bison

A couple of the generators left the bison output file in the source
tree, and then moved it into $$GENERATED_SOURCES_DIR, which did not
work well when building release and debug configurations in parallel.

1:02 AM Changeset in webkit [43286] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Justin Garcia.

  • fix an assertion failure in RemoveNodeCommand() when deleting a <br> between a block and a mail blockquote

Test: editing/deleting/removeNodeCommand-assert.html

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): Pass the start block to prune() instead of passing m_upstreamStart.node(), because the latter may have been removed already.

LayoutTests:

Reviewed by Justin Garcia.

  • test for an assertion failure in RemoveNodeCommand() when deleting a <br> between a block and a mail blockquote
  • editing/deleting/removeNodeCommand-assert-expected.txt: Added.
  • editing/deleting/removeNodeCommand-assert.html: Added.
12:27 AM Changeset in webkit [43285] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>

Unreviewed Qt build fix.

Dont' use ENABLE() in Qt API headers, as they are not available when building
against the API.

May 5, 2009:

11:40 PM Changeset in webkit [43284] by eric@webkit.org
  • 3 edits
    2 deletes in trunk

2009-05-05 Eric Seidel <eric@webkit.org>

No review, roll out only.

Roll out r23072 since it broke layout tests

  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
11:00 PM Changeset in webkit [43283] by eric@webkit.org
  • 66 edits in trunk

2009-05-05 Ben Murdoch <benm@google.com>

Reviewed by Eric Seidel.

Add #if ENABLE(DATABASE) guards around database code so toggling ENABLE_DATABASE off does not break builds.
https://bugs.webkit.org/show_bug.cgi?id=24776

No functional changes, thus no tests.

  • bindings/js/JSCustomSQLStatementCallback.cpp:
  • bindings/js/JSCustomSQLStatementCallback.h:
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  • bindings/js/JSCustomSQLStatementErrorCallback.h:
  • bindings/js/JSCustomSQLTransactionCallback.cpp:
  • bindings/js/JSCustomSQLTransactionCallback.h:
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
  • bindings/js/JSCustomSQLTransactionErrorCallback.h:
  • bindings/js/JSDatabaseCustom.cpp:
  • bindings/js/JSSQLTransactionCustom.cpp:
  • loader/EmptyClients.h:
  • page/ChromeClient.h:
  • storage/ChangeVersionWrapper.cpp:
  • storage/ChangeVersionWrapper.h:
  • storage/Database.cpp: (WebCore::Database::databaseInfoTableName):
  • storage/Database.h:
  • storage/Database.idl:
  • storage/DatabaseTask.cpp:
  • storage/DatabaseTask.h:
  • storage/DatabaseThread.cpp:
  • storage/DatabaseThread.h:
  • storage/DatabaseTracker.cpp:
  • storage/DatabaseTracker.h:
  • storage/DatabaseTrackerClient.h:
  • storage/OriginQuotaManager.cpp:
  • storage/OriginQuotaManager.h:
  • storage/SQLStatement.cpp:
  • storage/SQLStatement.h:
  • storage/SQLTransaction.cpp:
  • storage/SQLTransaction.h:
  • storage/SQLTransaction.idl:
10:49 PM Changeset in webkit [43282] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-05-05 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Eric Seidel.

Add some documentation to InlineBox::x(),y().
https://bugs.webkit.org/show_bug.cgi?id=25378

  • rendering/InlineBox.h:
10:47 PM Changeset in webkit [43281] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-05-05 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Disable all the SVG features for WebKit/Qt if ENABLE_SVG=0
https://bugs.webkit.org/show_bug.cgi?id=24693

  • WebCore.pro:
10:46 PM Changeset in webkit [43280] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-05-05 Sankar Aditya Tanguturi <sankaraditya@gmail.com>

Reviewed by Eric Seidel.

Anonymous blocks should not be exposed in accessibility tree.
Part of https://bugs.webkit.org/show_bug.cgi?id=23072

Tests: accessibility/ignore-anonymous-block.html

platform/win/accessibility/document-role.html

  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):Return true for Anonymous blocks. Matching Firefox 2.0.0.14
10:37 PM Changeset in webkit [43279] by eric@webkit.org
  • 5 edits
    2 adds in trunk

2009-05-05 Jungshik Shin <jshin@chromium.org>

Reviewed by Alexey Proskuryakov.

http://bugs.webkit.org/show_bug.cgi?id=25487

For euc-kr and other 8bit Korean encodings
(similar to euc-kr/windows-949), make document.charset return
EUC-KR instead of windows-949. The latter is not recognized by
Korean web servers.

Add domName method to TextEncoding to deal with cases where
our internal encoding name does not match what's widely recognized
by web servers. Currently, the only case is 'windows-949' (internal
name) vs 'EUC-KR'.

Test: fast/encoding/euckr-name.html

  • dom/Document.cpp: (WebCore::Document::encoding): Call TextEncoding.domName() instead of TextEncoding.name().
  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::domName): For the canonical name 'windows-949', return 'EUC-KR'. Otherwise, just return the canonical name.
  • platform/text/TextEncoding.h:
10:30 PM Changeset in webkit [43278] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2009-05-05 Adam Langley <agl@google.com>

Reviewed by Darin Adler.

Rendering fix for <select> elements.
https://bugs.webkit.org/show_bug.cgi?id=25558

When switching a <select> element from display:none to default
display, we would fail to invalidate the parent's pref widths in some
situations:

When attaching the element, RenderMenuList::updateOptionsWidth would
call setNeedsLayoutAndPrefWidthsRecalc before the parent pointer was
set. This would mark the pref widths as dirty, but not for any parent
objects.

When RenderObjectChildList::appendChildNode later calls
setNeedsLayoutAndPrefWidthsRecalc again, with a valid parent pointer,
nothing would be done because the pref widths were already dirty for.
the RenderMenuList.

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateOptionsWidth):
10:23 PM Changeset in webkit [43277] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-05-05 Antony Sargent <asargent@chromium.org>

Reviewed by Dimitri Glazkov.

Switch V8EventListenerList to use HashTable<T>.
https://bugs.webkit.org/show_bug.cgi?id=25496

This avoids some tricky issues with event listener removal in the
current implementation and has slightly better performance.

No new functionality so no new tests.

  • bindings/v8/V8EventListenerList.cpp: Added V8EventListenerListIterator.
  • bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::size):
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
9:50 PM Changeset in webkit [43276] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-05 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Simplified a bit of codegen.

  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
9:47 PM Changeset in webkit [43275] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-05-05 Darin Fisher <darin@chromium.org>

Fixing build bustage.

Add some missing includes to fix the Chromium build.

  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
9:25 PM Changeset in webkit [43274] by darin@chromium.org
  • 7 edits
    2 adds in trunk

2009-05-05 Darin Fisher <darin@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25570

history.{back,forward,go} should always be dispatched asynchronously,
even when the history navigation would just result in scrolling the
page. This matches the behavior of other browsers like IE and FF.

Test: fast/history/back-forward-is-asynchronous.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::scheduleHistoryNavigation):
8:20 PM Changeset in webkit [43273] by ggaren@apple.com
  • 6 edits in trunk/JavaScriptCore

2009-05-05 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.


Moved all the JIT stub related code into one place.

  • jit/JIT.cpp:
  • jit/JIT.h:
  • jit/JITCode.h:
  • jit/JITStubs.cpp: (JSC::):
  • jit/JITStubs.h:
8:15 PM Changeset in webkit [43272] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip newly-added SVG tests that fail on Windows

See Bug 25583: New SVG regression tests added in r43269 fail on
Windows
<https://bugs.webkit.org/show_bug.cgi?id=25583>

Rubber-stamped in advance by Eric Seidel.

  • platform/win/Skipped: Added the two new SVG tests.
7:20 PM Changeset in webkit [43271] by Adam Roben
  • 3 edits in trunk/WebKit/win

Add a call to notify the UI delegate when the WebView gets invalidated

Reviewed by Steve Falkenburg.

  • Interfaces/IWebUIDelegatePrivate.idl: Added webViewDidInvalidate.
  • WebView.cpp: (WebView::addToDirtyRegion): Call webViewDidInvalidate.
6:22 PM Changeset in webkit [43270] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-05-05 Sam Weinig <sam@webkit.org>

Try to fix Windows build.

Move Node constructor to the .cpp file.

  • parser/Nodes.cpp:
  • parser/Nodes.h:
6:20 PM Changeset in webkit [43269] by eric@webkit.org
  • 7 edits
    8 adds in trunk

Reviewed by Simon Fraser.

Add an ASSERT(useTransforms) to mapLocalToContainer implementations in SVG.
https://bugs.webkit.org/show_bug.cgi?id=25532
https://bugs.webkit.org/show_bug.cgi?id=25568

Adding this ASSERT exposed a bug in SVGPaintServerPattern::setup
which was causing transformed SVG text when filled/stroked with a
pattern using patternUnits=objectBoundingBox to draw incorrectly.

I fixed the incorrect drawing (by removing the broken code) and added
two test cases to test the fix:

  • svg/transforms/text-with-pattern-inside-transformed-html.xhtml
  • svg/transforms/text-with-pattern-with-svg-transform.svg
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::mapLocalToContainer):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::mapLocalToContainer):
  • svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setup):
5:56 PM Changeset in webkit [43268] by Darin Adler
  • 2 edits in trunk/WebKitTools

2009-05-05 Darin Adler <Darin Adler>

Try to fix Mac build.

  • DumpRenderTree/AccessibilityUIElement.cpp: (elementAtPointCallback): Initialize x and y.
5:54 PM Changeset in webkit [43267] by bolsinga@apple.com
  • 5 edits
    2 adds in trunk

WebCore:

2009-05-05 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=25554

Support HTML5 text control input types: email, number, tel, url

Test: fast/html/text-field-input-types.html

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isTextField]): Call HTMLInputElement::isTextField directly.
  • html/HTMLInputElement.cpp: Use the new types where appropriate. (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::type): (WebCore::HTMLInputElement::saveState): (WebCore::HTMLInputElement::restoreState): (WebCore::HTMLInputElement::accessKeyAction): (WebCore::HTMLInputElement::rendererIsNeeded): (WebCore::HTMLInputElement::createRenderer): (WebCore::HTMLInputElement::appendFormData): (WebCore::HTMLInputElement::valueWithDefault): (WebCore::HTMLInputElement::storesValueSeparateFromAttribute): (WebCore::HTMLInputElement::defaultEventHandler):
  • html/HTMLInputElement.h: Ditto. (WebCore::HTMLInputElement::): (WebCore::HTMLInputElement::isTextField):

LayoutTests:

2009-05-05 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=25554

Support HTML5 text control input types: email, number, tel, url

  • fast/html/text-field-input-types-expected.txt: Added.
  • fast/html/text-field-input-types.html: Added.
5:54 PM Changeset in webkit [43266] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2009-05-05 Darin Adler <Darin Adler>

Try to fix Windows build.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Added bytecompiler to the list of directories where the headers get copied.
5:51 PM Changeset in webkit [43265] by kevino@webkit.org
  • 10 edits in trunk

Reviewed by Kevin Ollivier.

Full Keyboard shortcut support.
Implement wxBrowser Cut/Copy/Paste menu items.

https://bugs.webkit.org/show_bug.cgi?id=24797

5:39 PM Changeset in webkit [43264] by Darin Adler
  • 4 edits in trunk/JavaScriptCore

2009-05-05 Darin Adler <Darin Adler>

Try to fix Windows build.

Try to fix Mac build.

  • JavaScriptCore.xcodeproj/project.pbxproj: Made SegmentedVector.h private.
5:19 PM Changeset in webkit [43263] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2009-05-05 Darin Adler <Darin Adler>

Try to fix Mac build.

4:22 PM Changeset in webkit [43262] by cmarrin@apple.com
  • 1 edit in trunk/LayoutTests/platform/win/Skipped

I didn't realize that the video-zoom-controls.html test will only succeed when run with Safari 4 shell. So disabling again

4:16 PM Changeset in webkit [43261] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix for Windows, add missing include.

https://bugs.webkit.org/show_bug.cgi?id=24798

4:11 PM Changeset in webkit [43260] by kevino@webkit.org
  • 5 edits in trunk

Reviewed by Kevin Ollivier.

Have wxWebkit make use of gcc(4 and greater) hidden visibility feature

https://bugs.webkit.org/show_bug.cgi?id=24345

4:09 PM Changeset in webkit [43259] by Darin Adler
  • 8 edits in trunk/JavaScriptCore

2009-05-05 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Bug 25569: make ParserRefCounted use conventional reference counting
https://bugs.webkit.org/show_bug.cgi?id=25569

SunSpider speedup of about 1.6%.

  • parser/Nodes.cpp: (JSC::NodeReleaser::releaseAllNodes): ALWAYS_INLINE. (JSC::NodeReleaser::adopt): Ditto. (JSC::ParserRefCounted::ParserRefCounted): Removed most of the code. Add the object to a Vector<RefPtr> that gets cleared after parsing. (JSC::ParserRefCounted::~ParserRefCounted): Removed most of the code.
  • parser/Nodes.h: Made ParserRefCounted inherit from RefCounted and made inline versions of the constructor and destructor. Made the Node constructor inline.
  • parser/Parser.cpp: (JSC::Parser::parse): Call globalData->parserObjects.shrink(0) after parsing, where it used to call ParserRefCounted::deleteNewObjects.
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): Eliminated code to manage the newParserObjects and parserObjectExtraRefCounts. (JSC::JSGlobalData::~JSGlobalData): Ditto.
  • runtime/JSGlobalData.h: Replaced the HashSet and HashCountedSet with a Vector.
  • wtf/PassRefPtr.h: (WTF::PassRefPtr::~PassRefPtr): The most common thing to do with a PassRefPtr in hot code is to pass it and then destroy it once it's set to zero. Help the optimizer by telling it that's true.
4:04 PM Changeset in webkit [43258] by Chris Fleizach
  • 16 edits
    2 adds in trunk

Bug 25574: AXImageMap children links don't respond properly to accessibilityHitTest:
https://bugs.webkit.org/show_bug.cgi?id=25574

3:34 PM Changeset in webkit [43257] by christian@webkit.org
  • 2 edits in trunk/WebKitTools

2009-05-06 Christian Dywan <christian@twotoasts.de>

Reviewed by Gustavo Noronha.

http://bugs.webkit.org/show_bug.cgi?id=17066
[GTK] Improve frameloader signals

Update GtkLauncher to use the new load-status and progress properties
instead of the previous loading signals.

  • GtkLauncher/main.c: (update_title): (notify_load_status_cb): (notify_progress_cb): (create_browser): (create_window):
3:34 PM Changeset in webkit [43256] by christian@webkit.org
  • 7 edits in trunk/WebKit/gtk

2009-05-06 Christian Dywan <christian@twotoasts.de>

Reviewed by Gustavo Noronha.

http://bugs.webkit.org/show_bug.cgi?id=17066
[GTK] Improve frameloader signals

Implement load-status and progress properties on the view, as well as
load-status on the frame. This supersedes the different load signals
load-progress-changed, load-committed, load-done, load-started and
load-finished which are not only misnamed but broken by design.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::notifyStatus): (WebKit::FrameLoaderClient::postProgressStartedNotification): (WebKit::FrameLoaderClient::postProgressEstimateChangedNotification): (WebKit::FrameLoaderClient::dispatchDidFinishLoad): (WebKit::FrameLoaderClient::dispatchDidStartProvisionalLoad):
  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebframe.h:
  • webkit/webkitwebview.cpp:
  • webkit/webkitwebview.h:
3:32 PM Changeset in webkit [43255] by kmccullough@apple.com
  • 3 edits
    5 adds in trunk

WebCore:

2009-05-05 Kevin McCullough <kmccullough@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6552129> Select a quote line and paste elsewhere, you
get that line and an extra quoted blank line
<rdar://problem/6609308> Triple-click a quoted header line, copy, paste
onto an empty line makes an extra quoted line

  • When pasting a blockquote with a newline, make sure we put the newline outside of the blockquote so that it is not quoted.
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):

LayoutTests:

2009-05-05 Kevin McCullough <kmccullough@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6552129> Select a quote line and paste elsewhere, you
get that line and an extra quoted blank line
<rdar://problem/6609308> Triple-click a quoted header line, copy, paste
onto an empty line makes an extra quoted line

  • Testing different scenarios where we paste quoted text into a non-quoted area and we do not want a trailing newline to be quoted.
  • editing/pasteboard/paste-blockquote-before-blockquote-expected.txt: Added.
  • editing/pasteboard/paste-blockquote-before-blockquote.html: Added.
  • editing/pasteboard/paste-double-nested-blockquote-before-blockquote-expected.txt: Added.
  • editing/pasteboard/paste-double-nested-blockquote-before-blockquote.html: Added.
  • editing/pasteboard/resources/paste-blockquote-before-blockquote.js: Added. (copyAndPasteNode):
3:04 PM Changeset in webkit [43254] by cmarrin@apple.com
  • 1 edit in trunk/LayoutTests/platform/win/Skipped

Reenabled media test after fixing <rdar://problem/6825079>

3:00 PM Changeset in webkit [43253] by kov@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-05 Xan Lopez <xlopez@igalia.com> and Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Oliver Hunt.

Disable the NativeFunctionWrapper for all non-Mac ports for now,
as it is also crashing on Linux/x86.

  • runtime/NativeFunctionWrapper.h:
2:41 PM Changeset in webkit [43252] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

STATE_CHANGED event is now named LOAD

https://bugs.webkit.org/show_bug.cgi?id=25549

2:37 PM Changeset in webkit [43251] by weinig@apple.com
  • 5 edits in branches/nitro-extreme/JavaScriptCore

2009-05-05 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Remove the NumberHeap.

  • JavaScriptCore.exp:
  • runtime/Collector.cpp: (JSC::Heap::Heap): (JSC::Heap::destroy): (JSC::Heap::recordExtraCost): (JSC::Heap::heapAllocate): (JSC::Heap::markConservatively): (JSC::Heap::sweep): (JSC::Heap::collect): (JSC::Heap::objectCount): (JSC::Heap::statistics): (JSC::typeName): (JSC::Heap::isBusy):
  • runtime/Collector.h: (JSC::Heap::globalData):
  • runtime/JSCell.h:
1:16 PM Changeset in webkit [43250] by jmalonzo@webkit.org
  • 3 edits in trunk/WebCore

2009-05-05 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

Call moz_gtk_shutdown on RenderThemeGtk destruction.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::~RenderThemeGtk):
  • platform/gtk/RenderThemeGtk.h:
12:57 PM Changeset in webkit [43249] by Darin Adler
  • 2 edits in trunk/WebCore

2009-05-05 Darin Adler <Darin Adler>

Reviewed by Steve Falkenburg.

<rdar://problem/6858340> REGRESSION: can't drag local HTML files into Safari because CFURLCreateWithFileSystemPath inserts "localhost"

  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::urlFromPath): Remove localhost.
12:19 PM Changeset in webkit [43248] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

2009-05-05 Peter Kasting <pkasting@google.com>

Reviewed by Brady Eidson.

Safety-check m_documentLoader before dereferencing. While it seems
unlikely this could fail (as Safari 3 shipped without this),
technically almost any call can change or reset m_documentLoader.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedFirstData):
12:05 PM Changeset in webkit [43247] by sfalken@apple.com
  • 3 edits in trunk/JavaScriptCore

Fix build.

11:16 AM Changeset in webkit [43246] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • Tiger build fix
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::toCSSIdentifier):
10:47 AM Changeset in webkit [43245] by mitz@apple.com
  • 2 edits in trunk

Add Bugzilla links

10:46 AM Changeset in webkit [43244] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

2009-05-05 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25303
No need to ref the internal buffer inside the Skia ImageDecoder.

  • platform/image-decoders/skia/ImageDecoder.h: (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::bitmap): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setStatus): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setRGBA):
10:33 AM Changeset in webkit [43243] by mitz@apple.com
  • 20 edits in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/5760774> Replying to a Mail message that contains fixed width text can change the size of the text

Covered by existing tests: editing/pasteboard/5027857.html

editing/pasteboard/paste-pre-002.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword): Added. If the font-size is keyword-based, returns the keyword value instead of the pixel size. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): If font-family is a generic family, return the generic family instead of the the internal string -webkit-[serif|sans-serif|cursive|fantasy |monospace]. (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties): For the font-size property, prefer a keyword value over a pixel size.
  • css/CSSComputedStyleDeclaration.h:
  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::currentlyHasStyle): For the font-size property, call getFontSizeCSSValuePreferringKeyword().
  • platform/graphics/FontDescription.h: (WebCore::FontDescription::keywordSize): Changed the return type to unsigned. (WebCore::FontDescription::setKeywordSize): Changed the parameter type to unsigned. (WebCore::FontDescription::m_keywordSize): Changed the type of this 4-bit field to unsigned, because it takes values as high as 8.

LayoutTests:

Reviewed by Darin Adler.

  • updated results for <rdar://problem/5760774> Replying to a Mail message that contains fixed width text can change the size of the text
  • editing/execCommand/19089-expected.txt:
  • editing/execCommand/5770834-1-expected.txt:
  • platform/mac/editing/deleting/delete-br-011-expected.txt:
  • platform/mac/editing/deleting/delete-select-all-001-expected.txt:
  • platform/mac/editing/execCommand/remove-formatting-2-expected.txt:
  • platform/mac/editing/pasteboard/5027857-expected.checksum:
  • platform/mac/editing/pasteboard/5027857-expected.png:
  • platform/mac/editing/pasteboard/5027857-expected.txt:
  • platform/mac/editing/pasteboard/paste-pre-002-expected.checksum:
  • platform/mac/editing/pasteboard/paste-pre-002-expected.png:
  • platform/mac/editing/pasteboard/paste-pre-002-expected.txt:
  • platform/mac/editing/style/block-style-004-expected.txt:
  • platform/mac/editing/style/block-style-005-expected.txt:
  • platform/mac/editing/style/block-style-006-expected.txt:
9:41 AM Changeset in webkit [43242] by oliver@apple.com
  • 4 edits in trunk

Fix http/tests/misc/DOMContentLoaded-event.html

Reviewed by Maciej Stachowiak

The native call performance improvement removed a few places where we
unintentionally performed a toThisObject conversion. This patch updates
the bindings codegen to not rely on this bug.

9:39 AM Changeset in webkit [43241] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[GTK] Implement WebCore::directoryName

9:21 AM Changeset in webkit [43240] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-05 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

Fix memory leaks.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::checkSpellingOfString):
8:58 AM Changeset in webkit [43239] by Adam Roben
  • 2 edits in trunk/WebKitTools

Don't use pdevenv when building with VC++ Express

Fixes Bug 25308: REGRESSION (r42182): Build fails after following
build instructions on webkit.org fail when using VC++ Express
<https://bugs.webkit.org/show_bug.cgi?id=25308>

Reviewed by Eric Seidel.

  • Scripts/webkitdirs.pm: (setupCygwinEnv): When Visual Studio is installed, set $vcBuildPath to point to pdevenv. When VC++ Express is installed, set $vcBuildPath to point to VC++ Express, as before. (buildVisualStudioProject): Use $vcBuildPath to build instead of hard-coding pdevenv.
8:49 AM Changeset in webkit [43238] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Adam Roben.

Add test case to cover V8 crasher (which JSC does not share).
https://bugs.webkit.org/show_bug.cgi?id=25550

  • svg/custom/polyline-points-crash-expected.txt: Added.
  • svg/custom/polyline-points-crash.html: Added.
8:41 AM Changeset in webkit [43237] by eric@webkit.org
  • 4 edits
    2 adds in trunk

Reviewed by Adam Roben.

Fix mappedAttributes() access without NULL check
https://bugs.webkit.org/show_bug.cgi?id=25553

SVGStyledElement::getPresentationAttribute was using mappedAttributes()
without checking for NULL.

HTMLInputElement::setInputType also doesn't NULL check, but I was not
able to get it to crash with a test case so I just added an ASSERT.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::getPresentationAttribute):
8:36 AM QtWebKitJournal edited by Simon Hausmann
(diff)
8:23 AM QtWebKitTodo edited by Simon Hausmann
(diff)
8:20 AM Changeset in webkit [43236] by Simon Hausmann
  • 3 edits
    3 adds in trunk/WebKit/qt

2009-05-05 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Various improvements to the class documentation, including a simple snippet for QWebElement.

6:50 AM Changeset in webkit [43235] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Make windows work again

6:48 AM Changeset in webkit [43234] by eric@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

Reviewed by Maciej Stachowiak.

Add a testcase using SVG in HTML with CSS transforms
https://bugs.webkit.org/show_bug.cgi?id=23112

We currently fail the <text> section of this test but pass the path and image sections.

  • platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.checksum: Added.
  • platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png: Added.
  • platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.txt: Added.
  • svg/transforms/animated-path-inside-transformed-html.xhtml: Added.
6:45 AM Changeset in webkit [43233] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[GTK] Implement WebCore::imageTitle

6:25 AM Changeset in webkit [43232] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows debug build fix

5:44 AM Changeset in webkit [43231] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Hopefully the last of the build fixes

5:31 AM Changeset in webkit [43230] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Fix build failure caused by other build fix

5:28 AM Changeset in webkit [43229] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Yet more windows build fixes.

5:22 AM Changeset in webkit [43228] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

More windows build fixes.

5:16 AM Changeset in webkit [43227] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

More build fixes

5:11 AM Changeset in webkit [43226] by oliver@apple.com
  • 6 edits in trunk/JavaScriptCore

Buildfix: Now include JSFunction.h basically everywhere we include PrototypeFunction.h

5:05 AM Changeset in webkit [43225] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Build fixes

5:02 AM Changeset in webkit [43224] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

More build fixes

4:58 AM Changeset in webkit [43223] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix

4:52 AM Changeset in webkit [43222] by oliver@apple.com
  • 7 edits in trunk/JavaScriptCore

Windows build fix

4:42 AM Changeset in webkit [43221] by oliver@apple.com
  • 1 edit
    1 add in trunk/JavaScriptCore

Add missing file

4:34 AM Changeset in webkit [43220] by oliver@apple.com
  • 39 edits
    2 adds in trunk

Bug 25559: Improve native function call performance
<https://bugs.webkit.org/show_bug.cgi?id=25559>

Reviewed by Gavin Barraclough

In order to cache calls to native functions we now make the standard
prototype functions use a small assembly thunk that converts the JS
calling convention into the native calling convention. As this is
only beneficial in the JIT we use the NativeFunctionWrapper typedef
to alternate between PrototypeFunction and JSFunction to keep the
code sane. This change from PrototypeFunction to NativeFunctionWrapper
is the bulk of this patch.

3:23 AM Changeset in webkit [43219] by Simon Hausmann
  • 5 edits in trunk

2009-05-05 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Make convertValueToQVariant more robust against null JSValues.

Don't require the caller to do the null check.

2:10 AM Changeset in webkit [43218] by eric@webkit.org
  • 3 edits in trunk/WebCore

No review, just a revert.

Roll out http://trac.webkit.org/changeset/43213 as it caused 4 tests to crash.

  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::mapLocalToContainer):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::mapLocalToContainer):
1:59 AM Changeset in webkit [43217] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-05-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Rubber-stamped by Simon Hausmann.

Mention --qt as an option in the build-webkit help

1:58 AM Changeset in webkit [43216] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-05 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

For convenience, let the sampling flags tool clear multiple flags at once.

  • jsc.cpp: (GlobalObject::GlobalObject): (functionSetSamplingFlags): (functionClearSamplingFlags):
1:52 AM Changeset in webkit [43215] by ap@webkit.org
  • 391 edits
    2 adds in trunk

Reviewed by Dave Hyatt.

<rdar://problem/6576889> REGRESSION (r35185): Cannot watch Flash movies on omg.yahoo.com

The problem was caused by missing <head> element - we used to create it when moving a
misplaced <style> element, but we now handle those in place. Other browsers always create
a <head> element.

There is no guarantee that a <head> element always exists - first, it can be removed with
removeChild or innerHTML, and also, we don't currently create it for frameset documents, or
for manually created ones (e.g. ImageDocument).

Test: fast/parser/head-element-for-yahoo-player.html

WebKit:

  • dom/Document.cpp: (WebCore::Document::implicitClose): Create a <head> element for about:blank. A removed comment talked about rdar://3758785, but that problem doesn't re-occur even if this code is removed completely.
  • html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::checkDTD): No longer allow <script> elements as children of <html>. This isn't directly related to this bug, but it was easier to fix both at once (IE and Firefox both don't allow such mispositioned <script> elements).
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Move <script> to <head> if <body> hasn't been created yet. Create a <head> it a <body> is created implicitly to contain some other element. (WebCore::HTMLParser::bodyCreateErrorCheck): Ensure that a <head> exists when <body> is explicitly present in source. (WebCore::HTMLParser::createHead): Do the work even if <html> element hasn't been created yet.

LayoutTests:

  • fast/parser/head-element-for-yahoo-player-expected.txt: Added.
  • fast/parser/head-element-for-yahoo-player.html: Added. Test the regression case (a misplaced <style> that used to create <head> implicitly).
  • editing/selection/select-all-005.html: Use a new index when selecting the body.
  • fast/dom/Document/document-write-doctype-expected.txt:
  • fast/dom/Document/resources/document-write-doctype.js: Removed checks for "Gecko quirk" of implicitly adding HEAD - that not a quirk, but standard behavior per HTML5.
  • editing/execCommand/create-list-1-expected.txt:
  • platform/mac/editing/deleting/4845371-expected.txt:
  • platform/mac/editing/deleting/4866671-expected.txt:
  • platform/mac/editing/deleting/4875189-expected.txt:
  • platform/mac/editing/deleting/5026848-1-expected.txt:
  • platform/mac/editing/deleting/5026848-2-expected.txt:
  • platform/mac/editing/deleting/5026848-3-expected.txt:
  • platform/mac/editing/deleting/5032066-expected.txt:
  • platform/mac/editing/deleting/5091898-expected.txt:
  • platform/mac/editing/deleting/5099303-expected.txt:
  • platform/mac/editing/deleting/5115601-expected.txt:
  • platform/mac/editing/deleting/5126166-expected.txt:
  • platform/mac/editing/deleting/5156801-2-expected.txt:
  • platform/mac/editing/deleting/5168598-expected.txt:
  • platform/mac/editing/deleting/5272440-expected.txt:
  • platform/mac/editing/deleting/5300379-expected.txt:
  • platform/mac/editing/deleting/5390681-expected.txt:
  • platform/mac/editing/deleting/5408255-expected.txt:
  • platform/mac/editing/deleting/5433862-2-expected.txt:
  • platform/mac/editing/deleting/5483370-expected.txt:
  • platform/mac/editing/deleting/delete-at-start-or-end-expected.txt:
  • platform/mac/editing/deleting/delete-block-table-expected.txt:
  • platform/mac/editing/deleting/delete-hr-expected.txt:
  • platform/mac/editing/deleting/delete-mixed-editable-content-001-expected.txt:
  • platform/mac/editing/deleting/delete-to-select-table-expected.txt:
  • platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
  • platform/mac/editing/deleting/merge-endOfParagraph-expected.txt:
  • platform/mac/editing/deleting/merge-no-br-expected.txt:
  • platform/mac/editing/deleting/merge-whitespace-pre-expected.txt:
  • platform/mac/editing/execCommand/4641880-1-expected.txt:
  • platform/mac/editing/execCommand/4641880-2-expected.txt:
  • platform/mac/editing/execCommand/4747450-expected.txt:
  • platform/mac/editing/execCommand/4786404-1-expected.txt:
  • platform/mac/editing/execCommand/4786404-2-expected.txt:
  • platform/mac/editing/execCommand/4916402-expected.txt:
  • platform/mac/editing/execCommand/4916541-expected.txt:
  • platform/mac/editing/execCommand/4916583-expected.txt:
  • platform/mac/editing/execCommand/4920488-expected.txt:
  • platform/mac/editing/execCommand/4920742-1-expected.txt:
  • platform/mac/editing/execCommand/4924441-expected.txt:
  • platform/mac/editing/execCommand/5049671-expected.txt:
  • platform/mac/editing/execCommand/5080333-1-expected.txt:
  • platform/mac/editing/execCommand/5080333-2-expected.txt:
  • platform/mac/editing/execCommand/5119244-expected.txt:
  • platform/mac/editing/execCommand/5120591-expected.txt:
  • platform/mac/editing/execCommand/5136770-expected.txt:
  • platform/mac/editing/execCommand/5142012-1-expected.txt:
  • platform/mac/editing/execCommand/5142012-2-expected.txt:
  • platform/mac/editing/execCommand/5142012-3-expected.txt:
  • platform/mac/editing/execCommand/5144139-1-expected.txt:
  • platform/mac/editing/execCommand/5164796-expected.txt:
  • platform/mac/editing/execCommand/5207369-expected.txt:
  • platform/mac/editing/execCommand/5210032-expected.txt:
  • platform/mac/editing/execCommand/5432254-1-expected.txt:
  • platform/mac/editing/execCommand/5432254-2-expected.txt:
  • platform/mac/editing/execCommand/5481523-expected.txt:
  • platform/mac/editing/execCommand/5482524-expected.txt:
  • platform/mac/editing/execCommand/5569741-expected.txt:
  • platform/mac/editing/execCommand/5573879-expected.txt:
  • platform/mac/editing/execCommand/5700414-1-expected.txt:
  • platform/mac/editing/execCommand/5700414-2-expected.txt:
  • platform/mac/editing/execCommand/insert-list-empty-div-expected.txt:
  • platform/mac/editing/input/5576619-expected.txt:
  • platform/mac/editing/inserting/12882-expected.txt:
  • platform/mac/editing/inserting/4840662-expected.txt:
  • platform/mac/editing/inserting/4875189-1-expected.txt:
  • platform/mac/editing/inserting/4875189-2-expected.txt:
  • platform/mac/editing/inserting/4959067-expected.txt:
  • platform/mac/editing/inserting/4960120-1-expected.txt:
  • platform/mac/editing/inserting/4960120-2-expected.txt:
  • platform/mac/editing/inserting/5002441-expected.txt:
  • platform/mac/editing/inserting/5058163-2-expected.txt:
  • platform/mac/editing/inserting/5156401-2-expected.txt:
  • platform/mac/editing/inserting/5549929-2-expected.txt:
  • platform/mac/editing/inserting/5549929-3-expected.txt:
  • platform/mac/editing/inserting/5607069-2-expected.txt:
  • platform/mac/editing/inserting/5607069-3-expected.txt:
  • platform/mac/editing/inserting/editable-html-element-expected.txt:
  • platform/mac/editing/inserting/editable-inline-element-expected.txt:
  • platform/mac/editing/inserting/edited-whitespace-1-expected.txt:
  • platform/mac/editing/inserting/editing-empty-divs-expected.txt:
  • platform/mac/editing/inserting/typing-tab-designmode-forms-expected.txt:
  • platform/mac/editing/pasteboard/4806874-expected.txt:
  • platform/mac/editing/pasteboard/4861080-expected.txt:
  • platform/mac/editing/pasteboard/4944770-1-expected.txt:
  • platform/mac/editing/pasteboard/4944770-2-expected.txt:
  • platform/mac/editing/pasteboard/4947130-expected.txt:
  • platform/mac/editing/pasteboard/4989774-expected.txt:
  • platform/mac/editing/pasteboard/5027857-expected.txt:
  • platform/mac/editing/pasteboard/5032095-expected.txt:
  • platform/mac/editing/pasteboard/5065605-expected.txt:
  • platform/mac/editing/pasteboard/5071074-2-expected.txt:
  • platform/mac/editing/pasteboard/5071074-expected.txt:
  • platform/mac/editing/pasteboard/5075944-2-expected.txt:
  • platform/mac/editing/pasteboard/5075944-3-expected.txt:
  • platform/mac/editing/pasteboard/5075944-expected.txt:
  • platform/mac/editing/pasteboard/5134759-expected.txt:
  • platform/mac/editing/pasteboard/5156401-1-expected.txt:
  • platform/mac/editing/pasteboard/5247341-expected.txt:
  • platform/mac/editing/pasteboard/5387578-expected.txt:
  • platform/mac/editing/pasteboard/5478250-expected.txt:
  • platform/mac/editing/pasteboard/5483567-expected.txt:
  • platform/mac/editing/pasteboard/5601583-1-expected.txt:
  • platform/mac/editing/pasteboard/copy-paste-bidi-expected.txt:
  • platform/mac/editing/pasteboard/input-field-1-expected.txt:
  • platform/mac/editing/pasteboard/merge-after-delete-1-expected.txt:
  • platform/mac/editing/pasteboard/merge-after-delete-2-expected.txt:
  • platform/mac/editing/pasteboard/merge-after-delete-expected.txt:
  • platform/mac/editing/pasteboard/merge-start-blockquote-expected.txt:
  • platform/mac/editing/pasteboard/paste-unrendered-select-expected.txt:
  • platform/mac/editing/pasteboard/prevent-block-nesting-01-expected.txt:
  • platform/mac/editing/pasteboard/select-element-1-expected.txt:
  • platform/mac/editing/selection/13804-expected.txt:
  • platform/mac/editing/selection/14971-expected.txt:
  • platform/mac/editing/selection/4397952-expected.txt:
  • platform/mac/editing/selection/4818145-expected.txt:
  • platform/mac/editing/selection/4866671-expected.txt:
  • platform/mac/editing/selection/4889598-expected.txt:
  • platform/mac/editing/selection/4895428-1-expected.txt:
  • platform/mac/editing/selection/4895428-2-expected.txt:
  • platform/mac/editing/selection/4895428-3-expected.txt:
  • platform/mac/editing/selection/4895428-4-expected.txt:
  • platform/mac/editing/selection/4932260-1-expected.txt:
  • platform/mac/editing/selection/4932260-2-expected.txt:
  • platform/mac/editing/selection/4932260-3-expected.txt:
  • platform/mac/editing/selection/4947387-expected.txt:
  • platform/mac/editing/selection/4960116-expected.txt:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/4983858-expected.txt:
  • platform/mac/editing/selection/5007143-2-expected.txt:
  • platform/mac/editing/selection/5007143-expected.txt:
  • platform/mac/editing/selection/5057506-2-expected.txt:
  • platform/mac/editing/selection/5057506-expected.txt:
  • platform/mac/editing/selection/5076323-1-expected.txt:
  • platform/mac/editing/selection/5076323-2-expected.txt:
  • platform/mac/editing/selection/5076323-3-expected.txt:
  • platform/mac/editing/selection/5081257-1-expected.txt:
  • platform/mac/editing/selection/5081257-2-expected.txt:
  • platform/mac/editing/selection/5099303-expected.txt:
  • platform/mac/editing/selection/5109817-expected.txt:
  • platform/mac/editing/selection/5136696-expected.txt:
  • platform/mac/editing/selection/5195166-1-expected.txt:
  • platform/mac/editing/selection/5195166-2-expected.txt:
  • platform/mac/editing/selection/5234383-1-expected.txt:
  • platform/mac/editing/selection/5234383-2-expected.txt:
  • platform/mac/editing/selection/5240265-expected.txt:
  • platform/mac/editing/selection/5333725-expected.txt:
  • platform/mac/editing/selection/5354455-1-expected.txt:
  • platform/mac/editing/selection/addRange-expected.txt:
  • platform/mac/editing/selection/caret-before-select-expected.txt:
  • platform/mac/editing/selection/contains-boundaries-expected.txt:
  • platform/mac/editing/selection/drag-select-1-expected.txt:
  • platform/mac/editing/selection/editable-html-element-expected.txt:
  • platform/mac/editing/selection/inconsistent-in-removeChildNode-expected.txt:
  • platform/mac/editing/selection/inline-closest-leaf-child-expected.txt:
  • platform/mac/editing/selection/mixed-editability-6-expected.txt:
  • platform/mac/editing/selection/mixed-editability-7-expected.txt:
  • platform/mac/editing/selection/move-by-sentence-linebreak-expected.txt:
  • platform/mac/editing/selection/select-all-005-expected.txt:
  • platform/mac/editing/selection/table-caret-1-expected.txt:
  • platform/mac/editing/selection/table-caret-2-expected.txt:
  • platform/mac/editing/selection/table-caret-3-expected.txt:
  • platform/mac/editing/selection/wrapped-line-caret-1-expected.txt:
  • platform/mac/editing/selection/wrapped-line-caret-2-expected.txt:
  • platform/mac/editing/style/4916887-expected.txt:
  • platform/mac/editing/style/5017613-1-expected.txt:
  • platform/mac/editing/style/5017613-2-expected.txt:
  • platform/mac/editing/style/5046875-1-expected.txt:
  • platform/mac/editing/style/5046875-2-expected.txt:
  • platform/mac/editing/style/5065910-expected.txt:
  • platform/mac/editing/style/5084241-expected.txt:
  • platform/mac/editing/style/5091898-expected.txt:
  • platform/mac/editing/style/5228141-expected.txt:
  • platform/mac/editing/style/5279521-expected.txt:
  • platform/mac/editing/style/font-family-with-space-expected.txt:
  • platform/mac/editing/style/fontsize-1-expected.txt:
  • platform/mac/editing/style/highlight-expected.txt:
  • platform/mac/editing/style/non-inheritable-styles-expected.txt:
  • platform/mac/editing/undo/5378473-expected.txt:
  • platform/mac/fast/block/float/relative-painted-twice-expected.txt:
  • platform/mac/fast/dom/delete-contents-expected.txt:
  • platform/mac/fast/events/context-no-deselect-expected.txt:
  • platform/mac/fast/events/label-focus-expected.txt:
  • platform/mac/fast/forms/input-appearance-focus-expected.txt:
  • platform/mac/fast/forms/input-text-click-inside-expected.txt:
  • platform/mac/fast/forms/input-text-click-outside-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/forms/input-text-drag-down-expected.txt:
  • platform/mac/fast/forms/input-text-option-delete-expected.txt:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt:
  • platform/mac/fast/forms/textfield-overflow-expected.txt:
  • platform/mac/fast/inline/25277-2-expected.txt:
  • platform/mac/fast/inline/25277-expected.txt:
  • platform/mac/fast/lists/drag-into-marker-expected.txt:
  • platform/mac/fast/overflow/overflow-focus-ring-expected.txt:
  • platform/mac/fast/repaint/4776765-expected.txt:
  • platform/mac/fast/repaint/selection-after-delete-expected.txt:
  • platform/mac/fast/repaint/selection-after-remove-expected.txt:
  • platform/qt/editing/deleting/4845371-expected.txt:
  • platform/qt/editing/deleting/4866671-expected.txt:
  • platform/qt/editing/deleting/4875189-expected.txt:
  • platform/qt/editing/deleting/5026848-1-expected.txt:
  • platform/qt/editing/deleting/5026848-2-expected.txt:
  • platform/qt/editing/deleting/5026848-3-expected.txt:
  • platform/qt/editing/deleting/5032066-expected.txt:
  • platform/qt/editing/deleting/5091898-expected.txt:
  • platform/qt/editing/deleting/5099303-expected.txt:
  • platform/qt/editing/deleting/5115601-expected.txt:
  • platform/qt/editing/deleting/5126166-expected.txt:
  • platform/qt/editing/deleting/5144139-2-expected.txt:
  • platform/qt/editing/deleting/5156801-2-expected.txt:
  • platform/qt/editing/deleting/5168598-expected.txt:
  • platform/qt/editing/deleting/5272440-expected.txt:
  • platform/qt/editing/deleting/5300379-expected.txt:
  • platform/qt/editing/deleting/5390681-expected.txt:
  • platform/qt/editing/deleting/5408255-expected.txt:
  • platform/qt/editing/deleting/delete-at-start-or-end-expected.txt:
  • platform/qt/editing/deleting/delete-block-table-expected.txt:
  • platform/qt/editing/deleting/delete-hr-expected.txt:
  • platform/qt/editing/deleting/delete-link-1-expected.txt:
  • platform/qt/editing/deleting/delete-mixed-editable-content-001-expected.txt:
  • platform/qt/editing/deleting/delete-to-select-table-expected.txt:
  • platform/qt/editing/deleting/deletionUI-single-instance-expected.txt:
  • platform/qt/editing/deleting/merge-endOfParagraph-expected.txt:
  • platform/qt/editing/deleting/merge-no-br-expected.txt:
  • platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
  • platform/qt/editing/execCommand/4641880-1-expected.txt:
  • platform/qt/editing/execCommand/4641880-2-expected.txt:
  • platform/qt/editing/execCommand/4747450-expected.txt:
  • platform/qt/editing/execCommand/4786404-1-expected.txt:
  • platform/qt/editing/execCommand/4786404-2-expected.txt:
  • platform/qt/editing/execCommand/4916402-expected.txt:
  • platform/qt/editing/execCommand/4916541-expected.txt:
  • platform/qt/editing/execCommand/4916583-expected.txt:
  • platform/qt/editing/execCommand/4920488-expected.txt:
  • platform/qt/editing/execCommand/4920742-1-expected.txt:
  • platform/qt/editing/execCommand/4924441-expected.txt:
  • platform/qt/editing/execCommand/5049671-expected.txt:
  • platform/qt/editing/execCommand/5062376-expected.txt:
  • platform/qt/editing/execCommand/5080333-1-expected.txt:
  • platform/qt/editing/execCommand/5080333-2-expected.txt:
  • platform/qt/editing/execCommand/5119244-expected.txt:
  • platform/qt/editing/execCommand/5120591-expected.txt:
  • platform/qt/editing/execCommand/5136770-expected.txt:
  • platform/qt/editing/execCommand/5142012-1-expected.txt:
  • platform/qt/editing/execCommand/5142012-2-expected.txt:
  • platform/qt/editing/execCommand/5142012-3-expected.txt:
  • platform/qt/editing/execCommand/5144139-1-expected.txt:
  • platform/qt/editing/execCommand/5164796-expected.txt:
  • platform/qt/editing/execCommand/5207369-expected.txt:
  • platform/qt/editing/execCommand/5210032-expected.txt:
  • platform/qt/editing/execCommand/5432254-1-expected.txt:
  • platform/qt/editing/execCommand/5432254-2-expected.txt:
  • platform/qt/editing/execCommand/insert-list-empty-div-expected.txt:
  • platform/qt/editing/inserting/12882-expected.txt:
  • platform/qt/editing/inserting/4840662-expected.txt:
  • platform/qt/editing/inserting/4875189-1-expected.txt:
  • platform/qt/editing/inserting/4875189-2-expected.txt:
  • platform/qt/editing/inserting/4959067-expected.txt:
  • platform/qt/editing/inserting/4960120-1-expected.txt:
  • platform/qt/editing/inserting/4960120-2-expected.txt:
  • platform/qt/editing/inserting/5002441-expected.txt:
  • platform/qt/editing/inserting/5058163-2-expected.txt:
  • platform/qt/editing/inserting/5156401-2-expected.txt:
  • platform/qt/editing/inserting/editable-html-element-expected.txt:
  • platform/qt/editing/inserting/editable-inline-element-expected.txt:
  • platform/qt/editing/inserting/edited-whitespace-1-expected.txt:
  • platform/qt/editing/inserting/editing-empty-divs-expected.txt:
  • platform/qt/editing/inserting/insert-before-link-1-expected.txt:
  • platform/qt/editing/pasteboard/4806874-expected.txt:
  • platform/qt/editing/pasteboard/4840662-expected.txt:
  • platform/qt/editing/pasteboard/4944770-1-expected.txt:
  • platform/qt/editing/pasteboard/4989774-expected.txt:
  • platform/qt/editing/pasteboard/5027857-expected.txt:
  • platform/qt/editing/pasteboard/5032095-expected.txt:
  • platform/qt/editing/pasteboard/5065605-expected.txt:
  • platform/qt/editing/pasteboard/5071074-2-expected.txt:
  • platform/qt/editing/pasteboard/5071074-expected.txt:
  • platform/qt/editing/pasteboard/5075944-2-expected.txt:
  • platform/qt/editing/pasteboard/5075944-3-expected.txt:
  • platform/qt/editing/pasteboard/5075944-expected.txt:
  • platform/qt/editing/pasteboard/5134759-expected.txt:
  • platform/qt/editing/pasteboard/5156401-1-expected.txt:
  • platform/qt/editing/pasteboard/5245519-expected.txt:
  • platform/qt/editing/pasteboard/5247341-expected.txt:
  • platform/qt/editing/pasteboard/5387578-expected.txt:
  • platform/qt/editing/pasteboard/5478250-expected.txt:
  • platform/qt/editing/pasteboard/5483567-expected.txt:
  • platform/qt/editing/pasteboard/copy-paste-bidi-expected.txt:
  • platform/qt/editing/pasteboard/merge-after-delete-1-expected.txt:
  • platform/qt/editing/pasteboard/merge-after-delete-2-expected.txt:
  • platform/qt/editing/pasteboard/merge-after-delete-expected.txt:
  • platform/qt/editing/pasteboard/merge-start-blockquote-expected.txt:
  • platform/qt/editing/pasteboard/paste-unrendered-select-expected.txt:
  • platform/qt/editing/pasteboard/prevent-block-nesting-01-expected.txt:
  • platform/qt/editing/selection/13804-expected.txt:
  • platform/qt/editing/selection/4397952-expected.txt:
  • platform/qt/editing/selection/4818145-expected.txt:
  • platform/qt/editing/selection/4866671-expected.txt:
  • platform/qt/editing/selection/4889598-expected.txt:
  • platform/qt/editing/selection/4895428-2-expected.txt:
  • platform/qt/editing/selection/4895428-3-expected.txt:
  • platform/qt/editing/selection/4932260-1-expected.txt:
  • platform/qt/editing/selection/4932260-2-expected.txt:
  • platform/qt/editing/selection/4932260-3-expected.txt:
  • platform/qt/editing/selection/4960116-expected.txt:
  • platform/qt/editing/selection/4983858-expected.txt:
  • platform/qt/editing/selection/5007143-2-expected.txt:
  • platform/qt/editing/selection/5007143-expected.txt:
  • platform/qt/editing/selection/5076323-1-expected.txt:
  • platform/qt/editing/selection/5076323-2-expected.txt:
  • platform/qt/editing/selection/5076323-3-expected.txt:
  • platform/qt/editing/selection/5081257-1-expected.txt:
  • platform/qt/editing/selection/5081257-2-expected.txt:
  • platform/qt/editing/selection/5099303-expected.txt:
  • platform/qt/editing/selection/5136696-expected.txt:
  • platform/qt/editing/selection/5195166-1-expected.txt:
  • platform/qt/editing/selection/5195166-2-expected.txt:
  • platform/qt/editing/selection/5234383-1-expected.txt:
  • platform/qt/editing/selection/5234383-2-expected.txt:
  • platform/qt/editing/selection/5240265-expected.txt:
  • platform/qt/editing/selection/addRange-expected.txt:
  • platform/qt/editing/selection/caret-before-select-expected.txt:
  • platform/qt/editing/selection/editable-html-element-expected.txt:
  • platform/qt/editing/selection/mixed-editability-6-expected.txt:
  • platform/qt/editing/selection/mixed-editability-7-expected.txt:
  • platform/qt/editing/selection/move-by-sentence-linebreak-expected.txt:
  • platform/qt/editing/selection/select-all-005-expected.txt:
  • platform/qt/editing/selection/table-caret-1-expected.txt:
  • platform/qt/editing/selection/table-caret-2-expected.txt:
  • platform/qt/editing/selection/table-caret-3-expected.txt:
  • platform/qt/editing/style/4916887-expected.txt:
  • platform/qt/editing/style/5017613-1-expected.txt:
  • platform/qt/editing/style/5017613-2-expected.txt:
  • platform/qt/editing/style/5046875-1-expected.txt:
  • platform/qt/editing/style/5046875-2-expected.txt:
  • platform/qt/editing/style/5065910-expected.txt:
  • platform/qt/editing/style/5084241-expected.txt:
  • platform/qt/editing/style/5228141-expected.txt:
  • platform/qt/editing/style/5279521-expected.txt:
  • platform/qt/editing/style/font-family-with-space-expected.txt:
  • platform/qt/editing/style/fontsize-1-expected.txt:
  • platform/qt/editing/style/highlight-expected.txt:
  • platform/qt/editing/style/non-inheritable-styles-expected.txt:
  • platform/qt/editing/undo/5378473-expected.txt:
  • platform/qt/fast/dom/delete-contents-expected.txt:
  • platform/qt/fast/events/label-focus-expected.txt:
  • platform/qt/fast/forms/input-appearance-focus-expected.txt:
  • platform/qt/fast/forms/input-maxlength-2-expected.txt:
  • platform/qt/fast/forms/input-text-click-inside-expected.txt:
  • platform/qt/fast/forms/input-text-option-delete-expected.txt:
  • platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/qt/fast/forms/textfield-drag-into-disabled-expected.txt:
  • platform/qt/fast/forms/textfield-overflow-expected.txt:
  • platform/qt/fast/overflow/overflow-focus-ring-expected.txt:
  • platform/qt/fast/repaint/4776765-expected.txt:
  • platform/qt/fast/repaint/selection-after-delete-expected.txt:
  • platform/qt/fast/repaint/selection-after-remove-expected.txt:
  • platform/win/editing/deleting/5168598-expected.txt:
  • platform/win/editing/inserting/4960120-1-expected.txt:
  • platform/win/editing/inserting/5607069-2-expected.txt:
  • platform/win/editing/inserting/5607069-3-expected.txt:
  • platform/win/editing/inserting/typing-tab-designmode-forms-expected.txt:
  • platform/win/editing/pasteboard/4806874-expected.txt:
  • platform/win/editing/selection/4895428-3-expected.txt:
  • platform/win/editing/selection/5136696-expected.txt:
  • platform/win/editing/selection/drag-select-1-expected.txt:
  • platform/win/fast/events/context-no-deselect-expected.txt:
  • platform/win/fast/events/label-focus-expected.txt:
  • platform/win/fast/forms/input-appearance-focus-expected.txt:
  • platform/win/fast/forms/input-text-click-inside-expected.txt:
  • platform/win/fast/forms/input-text-click-outside-expected.txt:
  • platform/win/fast/forms/input-text-double-click-expected.txt:
  • platform/win/fast/forms/input-text-drag-down-expected.txt:
  • platform/win/fast/forms/input-text-option-delete-expected.txt:
  • platform/win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/win/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/win/fast/forms/textfield-drag-into-disabled-expected.txt:
  • platform/win/fast/forms/textfield-overflow-expected.txt: Updated BODY element index in test output (for some tests, it increased because of the implicitly added <head>, and for others, it decreased because mispositoned <script> is being moved into <head>).
  • webarchive/adopt-attribute-styled-body-webarchive-expected.webarchive:
  • webarchive/archive-empty-frame-dom-expected.webarchive: Updated to include the implicitly added <head> elements.
1:24 AM Changeset in webkit [43214] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-05-04 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

As Qtish implementation of MIMETypeRegistry::getMIMETypeForExtension()
returns the application/octet-stream mimetype when it can't associate
extension with any mimetype, it can happen that the application/octet-stream
mimetype will hit the list of supported image formats. For instance,
it is possible when QImageReader or QImageWriter support an extension
that is not in the extensions map.

Make sure that this mimetype is not treated as displayable image type.

1:15 AM Changeset in webkit [43213] by eric@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Simon Fraser.

ASSERT(useTransforms) in SVG mapLocalToContainer implementations
https://bugs.webkit.org/show_bug.cgi?id=25532

  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::mapLocalToContainer):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::mapLocalToContainer):
1:15 AM Changeset in webkit [43212] by eric@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Simon Fraser.

Remove m_absoluteBounds hack from RenderSVGText
https://bugs.webkit.org/show_bug.cgi?id=25532

No functional changes (SVGs inside CSS transformed HTML should theoretically repaint better)

  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
  • rendering/RenderSVGText.h:
1:15 AM Changeset in webkit [43211] by eric@webkit.org
  • 15 edits in trunk

Reviewed by Simon Fraser.

Remove the vestigial calculateLocalTransform()
https://bugs.webkit.org/show_bug.cgi?id=25532

RenderSVGContainer is now the only render which needs this
function, but it no longer returns the unused bool.

calculateLocalTransform() previously was called by the DOM before
transform updates were part of layout().

  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
  • rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::localTransform):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout):
  • rendering/RenderPath.h:
  • rendering/RenderSVGContainer.cpp:
  • rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::calculateLocalTransform):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout):
  • rendering/RenderSVGImage.h:
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
  • rendering/RenderSVGText.h:
  • rendering/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
  • rendering/RenderSVGTransformableContainer.h:
1:14 AM Changeset in webkit [43210] by eric@webkit.org
  • 7 edits in trunk/WebCore

Reviewed by Simon Fraser.

Move more code into SVGRenderBase
https://bugs.webkit.org/show_bug.cgi?id=25532

clippedOverflowRectForRepaint, computeRectForRepaint and mapLocalToContainer
are now all shared via SVGRenderBase.

RenderForeignObject should also be sharing this code, but I've left it
alone for now, as changing that would likely cause test changes.

No test changes. It's possible that transformed <svg:image> elements will
now show up with better metrics in the inspector.

  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::clippedOverflowRectForRepaint): (WebCore::RenderSVGImage::computeRectForRepaint): (WebCore::RenderSVGImage::mapLocalToContainer):
  • rendering/RenderSVGImage.h:
  • rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint): (WebCore::RenderSVGModelObject::computeRectForRepaint): (WebCore::RenderSVGModelObject::mapLocalToContainer):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::clippedOverflowRectForRepaint): (WebCore::RenderSVGText::computeRectForRepaint): (WebCore::RenderSVGText::mapLocalToContainer):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::clippedOverflowRectForRepaint): (WebCore::SVGRenderBase::computeRectForRepaint): (WebCore::SVGRenderBase::mapLocalToContainer):
  • rendering/SVGRenderSupport.h:
1:14 AM Changeset in webkit [43209] by eric@webkit.org
  • 11 edits in trunk/WebCore

Reviewed by Simon Fraser.

Add SVGRenderBase to share logic between SVG renderers
https://bugs.webkit.org/show_bug.cgi?id=25532

I've added an SVGRenderBase base class which is shared by
all of the SVG renders now. This patch is just moving code
there are no functional changes in this patch.

Currently I've left these functions in SVGRenderSupport.h
In a later patch I will rename SVGRenderSupport.* to SVGRenderBase.*

clampImageBufferSizeToViewport now takes a FrameView* which makes some code easier to read.

  • rendering/RenderSVGBlock.h:
  • rendering/RenderSVGImage.h:
  • rendering/RenderSVGModelObject.h:
  • rendering/RenderSVGRoot.h:
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent): (WebCore::clampImageBufferSizeToViewport): (WebCore::SVGRenderBase::computeContainerBoundingBox): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkEndCallback): (WebCore::SVGRootInlineBox::paint):
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern):
  • svg/graphics/SVGPaintServerGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient): (WebCore::clipToTextMask):
12:51 AM Changeset in webkit [43208] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-05 Sam Weinig <sam@webkit.org>

Fix build.

  • runtime/JSValue.h: (JSC::JSValue::): s/#PLATFORM/#if PLATFORM/
12:18 AM Changeset in webkit [43207] by Simon Hausmann
  • 18 edits in trunk/WebCore

2009-05-05 Simon Hausmann <simon.hausmann@nokia.com>

Unreviewed SVG build fix.

Include MappedAttribute.h after r43187.

May 4, 2009:

11:01 PM Changeset in webkit [43206] by weinig@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-05-04 Sam Weinig <sam@webkit.org>

Make CallFrame dumping more useful by dumping a description and
all 64 bits of registers.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::dumpRegisters):
  • runtime/JSValue.cpp: (JSC::JSValue::description):
  • runtime/JSValue.h:
10:37 PM Changeset in webkit [43205] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-04 Maciej Stachowiak <mjs@apple.com>

Rubber stamped by Gavin.

  • inline Vector::resize for a ~1.5% speedup on string-tagcloud
  • wtf/Vector.h: (WTF::Vector::resize): Inline
9:46 PM Changeset in webkit [43204] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-04 Geoffrey Garen <ggaren@apple.com>

Reviewed by Mark Rowe.


PPC fix.

  • runtime/JSValue.h: (JSC::JSValue::): endian little hate i.
9:45 PM Changeset in webkit [43203] by zecke@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-04 Holger Hans Peter Freyther <zecke@selfish.org>

Disabling accessibility/canvas.html due the lack of a
an AccessibilityController implementation in DRT.

  • platform/gtk/Skipped:
9:06 PM Changeset in webkit [43202] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-04 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix regression in fast/js/exception-sequencing-binops.html caused by
evaluating the arguments passed to fmod in the wrong order.

All LayoutTests now pass.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
6:47 PM Changeset in webkit [43201] by ggaren@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-05-04 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed some number bugs. 3x speedup, since this patch restores all our
int-based optimizations.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): Make sure negate of 0 yields -0.
  • runtime/JSValue.cpp: (JSC::JSValue::description): Fixed some typos in debug logging code. (Missing "else" before "if".)
  • runtime/JSValue.h: (JSC::JSValue::JSValue): Convert doubles to int if possible, as we do on trunk.
6:18 PM Changeset in webkit [43200] by beidson@apple.com
  • 3 edits in trunk/WebCore

2009-05-04 Brady Eidson <beidson@apple.com>

Reviewed by Sam 'The Belly' Weinig

<rdar://problem/6828894> - Facebook photo uploader applet broken on Leopard only

In r41568 we started adding a default codebase attribute to <applet> tags if they didn't specify one
themselves. Leopard's Java plug-in mishandles this case and fails to load code for the applet.

The spirit of r41568 can be maintained by removing the "default codebase" piece and only performing
the canLoad() check if a codebase was actually set on the applet tag.

  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::createRenderer): Don't create a default codebase attribute.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createJavaAppletWidget): Only perform the canLoad() check if the codebase was set.
6:04 PM Changeset in webkit [43199] by weinig@apple.com
  • 9 edits
    1 add
    1 delete in branches/nitro-extreme

JavaScriptCore:

2009-05-04 Sam Weinig <sam@webkit.org>

Make WebCore compile with the new JS number representation.

WebCore:

2009-05-04 Sam Weinig <sam@webkit.org>

Make WebCore compile with the new JS number representation.

  • ForwardingHeaders/runtime/JSAPIValueWrapper.h: Added.
  • ForwardingHeaders/runtime/JSNumberCell.h: Removed.
  • bindings/js/ScriptEventListener.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/c/c_instance.cpp:
6:00 PM Changeset in webkit [43198] by Adam Roben
  • 3 edits in trunk/WebCore

Windows build fix

  • html/HTMLCollection.h:
  • html/HTMLFormElement.h: Declare CollectionCache as a struct, not a class, to match its definition.
5:39 PM Changeset in webkit [43197] by Chris Fleizach
  • 3 edits
    2 adds in trunk

Bug 25557: REGRESSION: Canvas elements are ignored instead of being exposed as AXImage
https://bugs.webkit.org/show_bug.cgi?id=25557

5:25 PM Changeset in webkit [43196] by beidson@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

2009-05-04 Brady Eidson <beidson@apple.com>

Fix an ancient Changelog entry where Sam Weinig flat out lied and confused my exploration of a bug.

  • ChangeLog
5:20 PM Changeset in webkit [43195] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-05-04 Kai Brüning <kai@granus.net>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24883
24883: Bad success test in parseXMLDocumentFragment in XMLTokenizerLibxml2.cpp

Fixed test whether all the chunk has been processed to correctly count utf8 bytes.

Test: fast/innerHTML/innerHTML-nbsp.xhtml

  • dom/XMLTokenizerLibxml2.cpp: (WebCore::parseXMLDocumentFragment):
3:37 PM Changeset in webkit [43194] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-04 Sam Weinig <sam@webkit.org>

Re-enable Yarr! It still works.

  • wtf/Platform.h:
3:29 PM Changeset in webkit [43193] by weinig@apple.com
  • 33 edits
    2 moves in branches/nitro-extreme/JavaScriptCore

2009-05-04 Sam Weinig <sam@webkit.org>

Land initial commit of new number representation for 32 bit platforms.

1:11 PM Changeset in webkit [43192] by Darin Adler
  • 2 edits in trunk/LayoutTests

2009-05-04 Darin Adler <Darin Adler>

  • platform/gtk/Skipped: Disable a test that's timing out.
1:08 PM Changeset in webkit [43191] by Darin Adler
  • 2 edits in trunk/WebKit/win

2009-05-04 Darin Adler <Darin Adler>

First try at fixing the Windows build.

  • DOMHTMLClasses.cpp: Added include of HTMLCollection.h.
12:38 PM Changeset in webkit [43190] by kov@webkit.org
  • 2 edits
    2 deletes in trunk/LayoutTests

2009-05-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Disabling new tests, as they are failing because of font
configuration mismatch between my machine and the bot.

  • platform/gtk/Skipped:
  • platform/gtk/editing/spelling/spellcheck-attribute-expected.txt: Removed.
  • platform/gtk/svg/text/foreignObject-repaint-expected.txt: Removed.
12:13 PM Changeset in webkit [43189] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-05-04 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Fix <rdar://problem/6797644>.


Make sure to send a reply even when an instance proxy can't be found.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): (WKPCInvoke): (WKPCInvokeDefault): (WKPCGetProperty): (WKPCHasProperty): (WKPCHasMethod): (WKPCEnumerate):
11:12 AM Changeset in webkit [43188] by kov@webkit.org
  • 3 edits
    6 adds in trunk

LayoutTests:

2009-05-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Alexey Proskuryakov.

Add results for two new tests, for the GTK+ port.

  • platform/gtk/editing/spelling/spellcheck-attribute-expected.txt: Added.
  • platform/gtk/svg/text/foreignObject-repaint-expected.txt: Added.

WebKitTools:

2009-05-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Alexey Proskuryakov.

Enable spell-checking in DumpRenderTree.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
11:00 AM Changeset in webkit [43187] by Darin Adler
  • 137 edits
    3 copies in trunk

WebCore:

2009-05-04 Darin Adler <Darin Adler>

Reviewed by Eric Seidel.

Bug 24924: remove Document.h include of Attr.h and HTMLCollection.h,
and NamedMappedAttrMap.h include of MappedAttribute.h
https://bugs.webkit.org/show_bug.cgi?id=24924

Make compiles faster, and debugging info smaller.

  • GNUmakefile.am: Added new source files.
  • WebCore.pro: Ditto.
  • WebCore.scons: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS): Updated for new collection type names.
  • dom/Document.cpp: (WebCore::Document::createAttribute): Added. No longer inline. (WebCore::Document::images): Updated for new collection type names. (WebCore::Document::applets): Ditto. (WebCore::Document::embeds): Ditto. (WebCore::Document::plugins): Ditto. (WebCore::Document::objects): Ditto. (WebCore::Document::scripts): Ditto. (WebCore::Document::links): Ditto. (WebCore::Document::forms): Ditto. (WebCore::Document::anchors): Ditto. (WebCore::Document::all): Ditto. (WebCore::Document::windowNamedItems): Ditto. (WebCore::Document::documentNamedItems): Ditto. (WebCore::Document::nameCollectionInfo): Ditto.
  • dom/Document.h: Changed around includes and forward declarations. Updated for changes to collection types.
  • dom/NamedMappedAttrMap.h: Removed include of MappedAttribute.h.
  • html/CollectionCache.cpp: Copied from WebCore/html/HTMLCollection.cpp. Contains the class that used to be HTMLCollection::CollectionInfo.
  • html/CollectionCache.h: Copied from WebCore/html/HTMLCollection.h. Ditto.
  • html/CollectionType.h: Copied from WebCore/html/HTMLCollection.h. Has the enum that used to be HTMLCollection::Type.
  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::HTMLCollection): Update for collection type change. (WebCore::HTMLCollection::create): Ditto. (WebCore::HTMLCollection::resetCollectionInfo): Ditto. (WebCore::HTMLCollection::itemAfter): Ditto.
  • html/HTMLCollection.h: Ditto.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::children): Updated for new collection type names.
  • html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::formCollectionInfo): Ditto. (WebCore::HTMLFormCollection::HTMLFormCollection): Ditto.
  • html/HTMLFormCollection.h: Ditto.
  • html/HTMLFormElement.h: Ditto.
  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::areas): Ditto.
  • html/HTMLNameCollection.cpp: (WebCore::HTMLNameCollection::HTMLNameCollection): Ditto.
  • html/HTMLNameCollection.h: (WebCore::HTMLNameCollection::create): Ditto.
  • html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::collectionInfo): Ditto.
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::tBodies):Ditto.
  • html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::cells):Ditto.
  • html/HTMLTableRowsCollection.cpp: (WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection): Ditto.
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::rows): Ditto.
  • bindings/js/JSDOMWindowBase.cpp: Added newly-needed includes.
  • bindings/js/JSHTMLFrameSetElementCustom.cpp: Ditto.
  • css/CSSStyleSelector.cpp: Ditto.
  • dom/Element.cpp: Ditto.
  • dom/InputElement.cpp: Ditto.
  • dom/NamedAttrMap.cpp: Ditto.
  • dom/NamedMappedAttrMap.cpp: Ditto.
  • dom/Node.cpp: Ditto.
  • dom/StyledElement.cpp: Ditto.
  • dom/StyledElement.h: Ditto.
  • editing/ApplyStyleCommand.cpp: Ditto.
  • editing/DeleteSelectionCommand.cpp: Ditto.
  • editing/Editor.cpp: Ditto.
  • editing/EditorCommand.cpp: Ditto.
  • editing/InsertParagraphSeparatorCommand.cpp: Ditto.
  • editing/ReplaceSelectionCommand.cpp: Ditto.
  • editing/markup.cpp: Ditto.
  • html/CanvasRenderingContext2D.cpp: Ditto.
  • html/HTMLAnchorElement.cpp: Ditto.
  • html/HTMLAppletElement.cpp: Ditto.
  • html/HTMLAreaElement.cpp: Ditto.
  • html/HTMLBRElement.cpp: Ditto.
  • html/HTMLBaseElement.cpp: Ditto.
  • html/HTMLBodyElement.cpp: Ditto.
  • html/HTMLButtonElement.cpp: Ditto.
  • html/HTMLCanvasElement.cpp: Ditto.
  • html/HTMLDivElement.cpp: Ditto.
  • html/HTMLEmbedElement.cpp: Ditto.
  • html/HTMLFontElement.cpp: Ditto.
  • html/HTMLFormControlElement.cpp: Ditto.
  • html/HTMLFormElement.cpp: Ditto.
  • html/HTMLFrameElement.cpp: Ditto.
  • html/HTMLFrameElementBase.cpp: Ditto.
  • html/HTMLFrameSetElement.cpp: Ditto.
  • html/HTMLHRElement.cpp: Ditto.
  • html/HTMLIFrameElement.cpp: Ditto.
  • html/HTMLImageElement.cpp: Ditto.
  • html/HTMLInputElement.cpp: Ditto.
  • html/HTMLIsIndexElement.cpp: Ditto.
  • html/HTMLKeygenElement.cpp: Ditto.
  • html/HTMLLIElement.cpp: Ditto.
  • html/HTMLLinkElement.cpp: Ditto.
  • html/HTMLMarqueeElement.cpp: Ditto.
  • html/HTMLMetaElement.cpp: Ditto.
  • html/HTMLOListElement.cpp: Ditto.
  • html/HTMLObjectElement.cpp: Ditto.
  • html/HTMLOptionElement.cpp: Ditto.
  • html/HTMLParagraphElement.cpp: Ditto.
  • html/HTMLParamElement.cpp: Ditto.
  • html/HTMLPlugInElement.cpp: Ditto.
  • html/HTMLPreElement.cpp: Ditto.
  • html/HTMLScriptElement.cpp: Ditto.
  • html/HTMLSelectElement.cpp: Ditto.
  • html/HTMLStyleElement.cpp: Ditto.
  • html/HTMLTableCaptionElement.cpp: Ditto.
  • html/HTMLTableCellElement.cpp: Ditto.
  • html/HTMLTableColElement.cpp: Ditto.
  • html/HTMLTablePartElement.cpp: Ditto.
  • html/HTMLTextAreaElement.cpp: Ditto.
  • html/HTMLTokenizer.cpp: Ditto.
  • html/HTMLUListElement.cpp: Ditto.
  • html/HTMLVideoElement.cpp: Ditto.
  • html/HTMLViewSourceDocument.cpp: Ditto.
  • loader/ImageDocument.cpp: Ditto.
  • page/Frame.cpp: Ditto.
  • rendering/RenderTreeAsText.cpp: Ditto.
  • svg/SVGAElement.cpp: Ditto.
  • svg/SVGAnimateMotionElement.cpp: Ditto.
  • svg/SVGAnimateTransformElement.cpp: Ditto.
  • svg/SVGAnimationElement.cpp: Ditto.
  • svg/SVGCircleElement.cpp: Ditto.
  • svg/SVGClipPathElement.cpp: Ditto.
  • svg/SVGCursorElement.cpp: Ditto.
  • svg/SVGElement.cpp: Ditto.
  • svg/SVGEllipseElement.cpp: Ditto.
  • svg/SVGExternalResourcesRequired.cpp: Ditto.
  • svg/SVGFitToViewBox.cpp: Ditto.
  • svg/SVGFontFaceElement.cpp: Ditto.
  • svg/SVGFontFaceUriElement.cpp: Ditto.
  • svg/SVGForeignObjectElement.cpp: Ditto.
  • svg/SVGGlyphElement.cpp: Ditto.
  • svg/SVGGradientElement.cpp: Ditto.
  • svg/SVGImageElement.cpp: Ditto.
  • svg/SVGLangSpace.cpp: Ditto.
  • svg/SVGLineElement.cpp: Ditto.
  • svg/SVGLinearGradientElement.cpp: Ditto.
  • svg/SVGMarkerElement.cpp: Ditto.
  • svg/SVGMaskElement.cpp: Ditto.
  • svg/SVGPathElement.cpp: Ditto.
  • svg/SVGPatternElement.cpp: Ditto.
  • svg/SVGPolyElement.cpp: Ditto.
  • svg/SVGRadialGradientElement.cpp: Ditto.
  • svg/SVGRectElement.cpp: Ditto.
  • svg/SVGSVGElement.cpp: Ditto.
  • svg/SVGScriptElement.cpp: Ditto.
  • svg/SVGStopElement.cpp: Ditto.
  • svg/SVGStyleElement.cpp: Ditto.
  • svg/SVGStyledElement.cpp: Ditto.
  • svg/SVGStyledTransformableElement.cpp: Ditto.
  • svg/SVGTests.cpp: Ditto.
  • svg/SVGTextContentElement.cpp: Ditto.
  • svg/SVGTextElement.cpp: Ditto.
  • svg/SVGTextPathElement.cpp: Ditto.
  • svg/SVGTextPositioningElement.cpp: Ditto.
  • svg/SVGURIReference.cpp: Ditto.
  • svg/SVGUseElement.cpp: Ditto.
  • svg/SVGViewElement.cpp: Ditto.
  • svg/animation/SVGSMILElement.cpp: Ditto.
  • xml/XPathStep.cpp: Ditto.

WebKit/mac:

2009-05-04 Darin Adler <Darin Adler>

Reviewed by Eric Seidel.

Bug 24924: remove Document.h include of Attr.h and HTMLCollection.h,
and NamedMappedAttrMap.h include of MappedAttribute.h
https://bugs.webkit.org/show_bug.cgi?id=24924

  • WebView/WebFrame.mm: Added include of CSSMutableStyleDeclaration.h and ScriptValue.h.
10:57 AM Changeset in webkit [43186] by kevino@webkit.org
  • 8 edits
    7 adds in trunk

Initial DRT implementation for wx.

10:50 AM Changeset in webkit [43185] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

2009-05-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Do not instantiate hidden WebInspector panels. Otherwise they are hitting unimplemented InspectorController methods.
https://bugs.webkit.org/show_bug.cgi?id=25520

10:02 AM Changeset in webkit [43184] by Darin Adler
  • 3 edits in trunk/LayoutTests

2009-05-04 Darin Adler <Darin Adler>

Reviewed by Adam Roben.

  • media/video-size-intrinsic-scale-expected.txt: Changed to match test.
  • media/video-size-intrinsic-scale.html: Removed doubled "Movie" word.
9:20 AM Changeset in webkit [43183] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-05-04 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6839881> With "Mail Contents of This Page" in Safari images don't appear in the Tiger Mail compose window

DocumentLoader::subresource() is the implementation for the WebKit API [WebDataSource subresourceForURL:] and has
particularly sticky behavior.

If the DocumentLoader represents a WebArchive, this method should return ArchiveResources from that archive. However, we
prefer CachedResources over ArchiveResources because they might represent fresher data than what was originally loaded
from the WebArchive.

In some instances, CachedResources are created and associated with the DocumentLoader but not immediately run through the
loading delegate machinery. This was always a possibility, but the Preload Scanner made this significantly more likely.

When this happens and someone asks the WebDataSource for a subresource, it would prefer the CachedResource over an
ArchiveResource it has even if the CachedResource hasn't been loaded yet. The CachedResource has nil data, so no
WebResource is returned, and the client thinks the subresource doesn't exist even though it does.

This broke Tiger Mail and probably various other WebKit applications but has a fairly straightforward fix.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): If there is a CachedResource but it hasn't been loaded yet, fallback to the ArchiveResource.
8:56 AM Changeset in webkit [43182] by eric.carlson@apple.com
  • 6 edits
    1 add in trunk

2009-05-04 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adam Roben.


https://bugs.webkit.org/show_bug.cgi?id=25545
Bug 25545: HTMLMediaElement: display anamorphic video correctly


Tell QuickTime to use clean aperture mode so movies with non-square pixels are sized
and displayed correctly.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie): Ask QuickTime to use clean aperture mode.
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::load): Ditto. Add ASSERT to ensure that static movie property array isn't filled beyond capacity.

2009-05-04 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=25545
Bug 25545: HTMLMediaElement: display anamorphic video correctly


Added 720x576i PAL anamorphic movie, extended video-size-intrinsic-scale
test to check that it is sized correctly.

  • media/content/720x576i-anamorphic.mov: Added.
  • media/video-size-intrinsic-scale-expected.txt:
  • media/video-size-intrinsic-scale.html:
8:38 AM Changeset in webkit [43181] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix <https://bugs.webkit.org/show_bug.cgi?id=25332>.
Bug 25332: Plug-in inserted in to DOM of PluginDocument fails to load

Reviewed by Darin Adler.

Only the first plug-in in a PluginDocument can use the main resource data. For all
subsequent plug-ins, such as the plug-in that ClickToFlash inserts when swapping itself
out for the real Flash plug-in, we need to load the resource data in the same manner
as for other embedded plug-ins.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadPlugin):

8:25 AM Changeset in webkit [43180] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-05-04 Simon Hausmann <simon.hausmann@nokia.com>

Rubber-stamped by Ariya Hidayat.

Update the qrc file for the Web Inspector in the Qt build
with missing files.

12:17 AM Changeset in webkit [43179] by eric@webkit.org
  • 7 edits in trunk/WebCore

Reviewed by George Staikos.

Move absoluteRects and absoluteQuads into RenderSVGInline and remove absoluteTransform() usage
https://bugs.webkit.org/show_bug.cgi?id=25532

  • rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::absoluteRects): (WebCore::RenderSVGInline::absoluteQuads):
  • rendering/RenderSVGInline.h:
  • rendering/RenderSVGTSpan.cpp:
  • rendering/RenderSVGTSpan.h:
  • rendering/RenderSVGTextPath.cpp:
  • rendering/RenderSVGTextPath.h:
12:17 AM Changeset in webkit [43178] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by George Staikos.

Move RenderSVGText off of localToAbsolute()
https://bugs.webkit.org/show_bug.cgi?id=25532

  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteRects): (WebCore::RenderSVGText::absoluteQuads):
12:16 AM Changeset in webkit [43177] by eric@webkit.org
  • 11 edits in trunk

Reviewed by George Staikos.

Remove broken absoluteTransform() code from RenderSVGInlineText
https://bugs.webkit.org/show_bug.cgi?id=25532

This improved SVG text focus rings.
This also improved SVG.getScreenCTM() results.

SVGSVGElement::getScreenCTM was passing "true" for the second argument in
localToAbsolute, which is "fixed" it meant to pass "true" for the
third argument (useTransforms). That change alone caused no layout test changes, however
before I fixed this, it was hitting ASSERT(!fixed) in RenderSVGRoot::mapLocalToContainer

mapLocalToContainer implementations really should be shared,
but I'll do that in a later patch.

  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::styleDidChange): (WebCore::RenderSVGInlineText::absoluteQuads): (WebCore::RenderSVGInlineText::computeRepaintRectForRange): (WebCore::RenderSVGInlineText::computeRepaintQuadForRange):
  • rendering/RenderSVGInlineText.h:
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::mapLocalToContainer):
  • rendering/RenderSVGRoot.h:
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::mapLocalToContainer):
  • rendering/RenderSVGText.h:
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::getScreenCTM):
12:15 AM Changeset in webkit [43176] by eric@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by George Staikos.

Remove dead code from RenderPath
https://bugs.webkit.org/show_bug.cgi?id=25532

  • rendering/RenderPath.cpp:
  • rendering/RenderPath.h:
12:15 AM Changeset in webkit [43175] by eric@webkit.org
  • 5 edits in trunk/WebCore

Reviewed by George Staikos.

Share layout code between RenderSVGViewportContainer and RenderSVGContainer
https://bugs.webkit.org/show_bug.cgi?id=25532

  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
  • rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::calcViewport):
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::applyViewportClip):
  • rendering/RenderSVGViewportContainer.h:
12:15 AM Changeset in webkit [43174] by eric@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by George Staikos.

Remove redundant disableLayoutState() calls
https://bugs.webkit.org/show_bug.cgi?id=25532

  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::layout):
12:14 AM Changeset in webkit [43173] by eric@webkit.org
  • 2 edits
    4 adds in trunk

Reviewed by George Staikos.

Simplify RenderForeignObject::paint and fix a repaint bug.
Paint now calls applyTransformToPaintInfo which correctly transforms the damage rect.
https://bugs.webkit.org/show_bug.cgi?id=16939

  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):

May 3, 2009:

11:46 PM Changeset in webkit [43172] by sfalken@apple.com
  • 2 edits in tags/Safari-6530.8.2/JavaScriptCore

Merged r43169.

11:39 PM Changeset in webkit [43171] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

No review, just adding missing results.

Add Win results for editing/spelling/spellcheck-attribute
Pixel results are still missing, but I have no easy way
to add them, and the bots aren't generating them currently.

  • platform/win/editing/spelling/spellcheck-attribute-expected.txt: Added.
11:37 PM Changeset in webkit [43170] by sfalken@apple.com
  • 1 copy in tags/Safari-6530.8.2

New tag.

11:36 PM Changeset in webkit [43169] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

11:05 PM Changeset in webkit [43168] by eric@webkit.org
  • 4 edits
    4 adds in trunk

2009-05-03 Hironori Bono <hbono@chromium.org>

Reviewed by Eric Seidel.

Test: editing/spelling/spellcheck-attribute.html

Bug 14552: Add a way to disable spell checking for specific element
https://bugs.webkit.org/show_bug.cgi?id=14552

For compatibility with Firefox, this code ascends the DOM tree when an element does
not have its "spellcheck" attribute.

  • editing/Editor.cpp: (WebCore::markMisspellingsOrBadGrammar): Retrieve the value of the "spellcheck" attribute of an element before calling a spell checker or a grammar checker.
  • html/HTMLAttributeNames.in: Add a "spellcheck" attribute.
7:00 PM Changeset in webkit [43167] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-03 Gustavo Noronha Silva <gns@gnome.org>

Three more failing tests caused by the disabling of the others.

  • platform/gtk/Skipped:
6:38 PM Changeset in webkit [43166] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-03 Gustavo Noronha Silva <gns@gnome.org>

Disable more tests that fail on the bot, and those which fail when
we disable some. Hopefully this finishes our massage to the
skipped list and we can go back to working on fixing tests now.

  • platform/gtk/Skipped:
5:42 PM Changeset in webkit [43165] by mrowe@apple.com
  • 4 edits in trunk/JavaScriptCore

Fix the 64-bit build.

  • API/APICast.h:

(toJS):
(toRef):

  • runtime/JSNumberCell.cpp:

(JSC::jsAPIMangledNumber):

  • runtime/JSNumberCell.h:
4:25 PM Changeset in webkit [43164] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

Reviewed by Sam Weinig.

Dump more metrics from svgsvgelement-ctm test.
(And break up the first SVG into two SVGs for easier reading of the metrics)

  • svg/custom/svgsvgelement-ctm-expected.txt:
  • svg/custom/svgsvgelement-ctm.xhtml:
2:57 PM QtWebKitJournal edited by Simon Hausmann
(diff)
2:54 PM QtWebKitTodo edited by Simon Hausmann
(diff)
2:44 PM Changeset in webkit [43163] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-03 Gustavo Noronha Silva <gns@gnome.org>

Some tests are still failing on the bot, despite working
locally. Disabling for now.

  • platform/gtk/Skipped:
2:41 PM Changeset in webkit [43162] by weinig@apple.com
  • 1 copy in branches/nitro-extreme

New branch

2:32 PM Changeset in webkit [43161] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-03 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

Enable more tests that succeed and style up the list a bit.

  • platform/gtk/Skipped:
2:02 PM Changeset in webkit [43160] by weinig@apple.com
  • 18 edits in trunk

JavaScriptCore:

2009-05-02 Sam Weinig <sam@webkit.org>

Roll JSC API number marshaling back in one last time (I hope).

WebCore:

2009-05-03 Sam Weinig <sam@webkit.org>

Roll JSC API number marshaling back in one last time (I hope).

1:59 PM Changeset in webkit [43159] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

2009-05-03 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Don't pass an exception parameter if we don't care about the value.

  • DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
12:56 PM Changeset in webkit [43158] by weinig@apple.com
  • 18 edits in trunk

JavaScriptCore:

2009-05-03 Sam Weinig <sam@webkit.org>

Roll JSC API number marshaling back out. It still breaks windows.

WebCore:

2009-05-03 Sam Weinig <sam@webkit.org>

Roll JSC API number marshaling back out. It still breaks windows.

12:27 PM Changeset in webkit [43157] by weinig@apple.com
  • 18 edits in trunk

JavaScriptCore:

2009-05-02 Sam Weinig <sam@webkit.org>

Roll JSC API number marshaling back in.

WebCore:

2009-05-02 Sam Weinig <sam@webkit.org>

Roll JSC API number marshaling back in.

9:49 AM Changeset in webkit [43156] by Darin Adler
  • 9 edits in trunk/JavaScriptCore

2009-05-02 Darin Adler <Darin Adler>

Reviewed by Maciej Stachowiak.

Bug 25519: streamline lexer by handling BOMs differently
https://bugs.webkit.org/show_bug.cgi?id=25519

Roughly 1% faster SunSpider.

  • parser/Grammar.y: Tweak formatting a bit.
  • parser/Lexer.cpp: (JSC::Lexer::Lexer): Remove unnnecessary initialization of data members that are set up by setCode. (JSC::Lexer::currentOffset): Added. Used where the old code would look at m_currentOffset. (JSC::Lexer::shift1): Replaces the old shift function. No longer does anything to handle BOM characters. (JSC::Lexer::shift2): Ditto. (JSC::Lexer::shift3): Ditto. (JSC::Lexer::shift4): Ditto. (JSC::Lexer::setCode): Updated for name change from yylineno to m_line. Removed now-unused m_eatNextIdentifier, m_stackToken, and m_restrKeyword. Replaced m_skipLF and m_skipCR with m_skipLineEnd. Replaced the old m_length with m_codeEnd and m_currentOffset with m_codeStart. Added code to scan for a BOM character and call copyCodeWithoutBOMs() if we find any. (JSC::Lexer::copyCodeWithoutBOMs): Added. (JSC::Lexer::nextLine): Updated for name change from yylineno to m_line. (JSC::Lexer::makeIdentifier): Moved up higher in the file. (JSC::Lexer::matchPunctuator): Moved up higher in the file and changed to use a switch statement instead of just if statements. (JSC::Lexer::isLineTerminator): Moved up higher in the file and changed to have fewer branches. (JSC::Lexer::lastTokenWasRestrKeyword): Added. This replaces the old m_restrKeyword boolean. (JSC::Lexer::isIdentStart): Moved up higher in the file. Changed to use fewer branches in the ASCII but not identifier case. (JSC::Lexer::isIdentPart): Ditto. (JSC::Lexer::singleEscape): Moved up higher in the file. (JSC::Lexer::convertOctal): Moved up higher in the file. (JSC::Lexer::convertHex): Moved up higher in the file. Changed to use toASCIIHexValue instead of rolling our own here. (JSC::Lexer::convertUnicode): Ditto. (JSC::Lexer::record8): Moved up higher in the file. (JSC::Lexer::record16): Moved up higher in the file. (JSC::Lexer::lex): Changed type of stringType to int. Replaced m_skipLF and m_skipCR with m_skipLineEnd, which requires fewer branches in the main lexer loop. Use currentOffset instead of m_currentOffset. Removed unneeded m_stackToken. Use isASCIIDigit instead of isDecimalDigit. Split out the two cases for InIdentifierOrKeyword and InIdentifier. Added special case tight loops for identifiers and other simple states. Removed a branch from the code that sets m_atLineStart to false using goto. Streamlined the number-handling code so we don't check for the same types twice for non-numeric cases and don't add a null to m_buffer8 when it's not being used. Removed m_eatNextIdentifier, which wasn't working anyway, and m_restrKeyword, which is redundant with m_lastToken. Set the m_delimited flag without using a branch. (JSC::Lexer::scanRegExp): Tweaked style a bit. (JSC::Lexer::clear): Clear m_codeWithoutBOMs so we don't use memory after parsing. Clear out UString objects in the more conventional way. (JSC::Lexer::sourceCode): Made this no-longer inline since it has more work to do in the case where we stripped BOMs.
  • parser/Lexer.h: Renamed yylineno to m_lineNumber. Removed convertHex function, which is the same as toASCIIHexValue. Removed isHexDigit function, which is the same as isASCIIHedDigit. Replaced shift with four separate shift functions. Removed isWhiteSpace function that passes m_current, instead just passing m_current explicitly. Removed isOctalDigit, which is the same as isASCIIOctalDigit. Eliminated unused arguments from matchPunctuator. Added copyCoodeWithoutBOMs and currentOffset. Moved the makeIdentifier function out of the header. Added lastTokenWasRestrKeyword function. Added new constants for m_skipLineEnd. Removed unused yycolumn, m_restrKeyword, m_skipLF, m_skipCR, m_eatNextIdentifier, m_stackToken, m_position, m_length, m_currentOffset, m_nextOffset1, m_nextOffset2, m_nextOffset3. Added m_skipLineEnd, m_codeStart, m_codeEnd, and m_codeWithoutBOMs.
  • parser/SourceProvider.h: Added hasBOMs function. In the future this can be used to tell the lexer about strings known not to have BOMs.
  • runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncUnescape): Changed to use isASCIIHexDigit.
  • wtf/ASCIICType.h: Added using statements to match the design of the other WTF headers.

May 2, 2009:

9:17 PM Changeset in webkit [43155] by adachan@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix windows build (when doing a clean build)

9:09 PM Changeset in webkit [43154] by mitz@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • another fix for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line

Test: editing/deleting/type-delete-after-quote-2.html

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): Initialize m_startsAtEmptyLine. (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): When the selection starts at an empty line, do not prevent the merging of blocks. This is what allows the text after the line break to be merged into the block containing the line break. Also set m_startsAtEmptyLine to true. (WebCore::DeleteSelectionCommand::mergeParagraphs): If m_startsAtEmptyLine is true, create a placeholder BR to serve as the merge destination.
  • editing/DeleteSelectionCommand.h:

LayoutTests:

Reviewed by Darin Adler.

  • another test for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line
  • editing/deleting/type-delete-after-quote-2-expected.txt: Added.
  • editing/deleting/type-delete-after-quote-2.html: Added.
6:58 PM Changeset in webkit [43153] by ggaren@apple.com
  • 44 edits in trunk

JavaScriptCore:

2009-05-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Simplified null-ish JSValues.


Replaced calls to noValue() with calls to JSValue() (which is what
noValue() returned). Removed noValue().


Replaced almost all uses of jsImpossibleValue() with uses of JSValue().
Its one remaining use is for construction of hash table deleted values.
For that specific task, I made a new, private constructor with a special
tag. Removed jsImpossibleValue().


Removed "JSValue()" initialiazers, since default construction happens...
by default.

  • API/JSCallbackObjectFunctions.h: (JSC::::call):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitLoad):
  • bytecompiler/BytecodeGenerator.h:
  • debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
  • debugger/DebuggerCallFrame.h: (JSC::DebuggerCallFrame::DebuggerCallFrame):
  • interpreter/CallFrame.h: (JSC::ExecState::clearException):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveLastCaller):
  • interpreter/Register.h: (JSC::Register::Register):
  • jit/JITCall.cpp: (JSC::JIT::unlinkCall): (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCall):
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_call_eval): (JSC::JITStubs::cti_vm_throw):
  • profiler/Profiler.cpp: (JSC::Profiler::willExecute): (JSC::Profiler::didExecute):
  • runtime/ArrayPrototype.cpp: (JSC::getProperty):
  • runtime/Completion.cpp: (JSC::evaluate):
  • runtime/Completion.h: (JSC::Completion::Completion):
  • runtime/GetterSetter.cpp: (JSC::GetterSetter::getPrimitiveNumber):
  • runtime/JSArray.cpp: (JSC::JSArray::putSlowCase): (JSC::JSArray::deleteProperty): (JSC::JSArray::increaseVectorLength): (JSC::JSArray::setLength): (JSC::JSArray::pop): (JSC::JSArray::sort): (JSC::JSArray::compactForSorting):
  • runtime/JSCell.cpp: (JSC::JSCell::getJSNumber):
  • runtime/JSCell.h: (JSC::JSValue::getJSNumber):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSImmediate.h: (JSC::JSImmediate::fromNumberOutsideIntegerRange): (JSC::JSImmediate::from):
  • runtime/JSNumberCell.cpp: (JSC::jsNumberCell):
  • runtime/JSObject.cpp: (JSC::callDefaultValueFunction):
  • runtime/JSObject.h: (JSC::JSObject::getDirect):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::toPrimitive):
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::next):
  • runtime/JSValue.h: (JSC::JSValue::): (JSC::JSValueHashTraits::constructDeletedValue): (JSC::JSValueHashTraits::isDeletedValue): (JSC::JSValue::JSValue):
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::JSWrapperObject):
  • runtime/Operations.h: (JSC::resolveBase):
  • runtime/PropertySlot.h: (JSC::PropertySlot::clearBase): (JSC::PropertySlot::clearValue):

WebCore:

2009-05-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Simplified null-ish JSValues.


Replaced calls to noValue() with calls to JSValue() (which is what
noValue() returned). Removed noValue().


Removed "JSValue()" initialiazers, since default construction happens...
by default.

  • bindings/js/JSDOMBinding.cpp: (WebCore::setDOMException):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::evaluate):
  • bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/js/ScriptValue.h: (WebCore::ScriptValue::ScriptValue): (WebCore::ScriptValue::hasNoValue):
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
  • bridge/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bridge/jni/jni_runtime.cpp: (JavaField::dispatchValueFromInstance): (JavaField::dispatchSetValueToInstance):
  • bridge/runtime.h: (JSC::Bindings::Instance::invokeConstruct):

WebKit/mac:

2009-05-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Simplified null-ish JSValues.


Replaced calls to noValue() with calls to JSValue() (which is what
noValue() returned). Removed noValue().


Removed "JSValue()" initialiazers, since default construction happens...
by default.

  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame evaluateWebScript:]):
4:43 PM Changeset in webkit [43152] by Antti Koivisto
  • 5 edits in trunk/WebCore

2009-05-02 Antti Koivisto <Antti Koivisto>

Reviewed by Dan Bernstein.

<rdar://problem/6631735> Crash in WebCore::CSSStyleSelector::applyProperty(int, WebCore::CSSValue*) (RenderStyle.h:454)


Avoid re-entering style selector from load delegates by not issuing resource loads synchronously during attach().

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::suspendPostAttachCallbacks): (WebCore::ContainerNode::resumePostAttachCallbacks): (WebCore::ContainerNode::attach):
  • dom/Element.cpp: (WebCore::Element::attach):
  • loader/loader.cpp: (WebCore::Loader::Loader): (WebCore::Loader::servePendingRequests): (WebCore::Loader::suspendPendingRequests): (WebCore::Loader::resumePendingRequests): (WebCore::Loader::Host::servePendingRequests):
  • loader/loader.h: (WebCore::Loader::isSuspendingPendingRequests):
2:59 PM Changeset in webkit [43151] by Darin Adler
  • 2 edits in trunk/WebKitTools

2009-05-02 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Another cut at getting tests passing on Windows again.

  • DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didStartProvisionalLoadForFrame): Tweak formatting. (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto. (FrameLoadDelegate::didCommitLoadForFrame): Ditto. (FrameLoadDelegate::didFinishLoadForFrame): Ditto. (FrameLoadDelegate::didFailLoadWithError): Added missing logging.
2:38 PM Changeset in webkit [43150] by Darin Adler
  • 2 edits in trunk/WebKitTools

2009-05-02 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Try to get tests passing on Windows again.

  • DumpRenderTree/win/DumpRenderTree.cpp: (shouldLogFrameLoadDelegates): Allow either "/" or "\" as a path separator. Also require separator before as well as after path name.
2:14 PM Changeset in webkit [43149] by Darin Adler
  • 3 edits
    2 copies
    1 add in trunk

WebCore:

2009-05-02 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 25352: REGRESSION(r42322): style isn't applied at bmwusa.com
https://bugs.webkit.org/show_bug.cgi?id=25352
rdar://problem/6823239

Test: http/tests/mime/standard-mode-loads-stylesheet-with-text-css-and-invalid-type.html

  • platform/network/HTTPParsers.cpp: (WebCore::extractMIMETypeFromMediaType): Allow comma as a separator.

LayoutTests:

2009-05-02 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 25352: REGRESSION(r42322): style isn't applied at bmwusa.com
https://bugs.webkit.org/show_bug.cgi?id=25352
rdar://problem/6823239

  • http/tests/mime/resources/style-with-text-css-and-invalid-type.php: Copied from LayoutTests/http/tests/mime/resources/style-with-charset.php and adapted.
  • http/tests/mime/standard-mode-loads-stylesheet-with-text-css-and-invalid-type-expected.txt: Added.
  • http/tests/mime/standard-mode-loads-stylesheet-with-text-css-and-invalid-type.html: Copied from LayoutTests/http/tests/mime/standard-mode-loads-stylesheet-with-empty-content-type.html and adapted.
12:58 PM Changeset in webkit [43148] by Darin Adler
  • 8 edits
    3 adds in trunk

WebCore:

2009-05-02 Darin Adler <Darin Adler>

Reviewed by Brady Eidson.

Bug 25491: WebFrame leak when a subframe removes itself
https://bugs.webkit.org/show_bug.cgi?id=25491
rdar://problem/6833859

Test: fast/loading/subframe-removes-itself.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame): When isStopping is true, treat load as complete, even if isLoadingInAPISense is still returning true.

LayoutTests:

2009-05-02 Darin Adler <Darin Adler>

Reviewed by Brady Eidson (except for the non-fast/loading test fixes).

Bug 25491: WebFrame leak when a subframe removes itself
https://bugs.webkit.org/show_bug.cgi?id=25491
rdar://problem/6833859

  • fast/loading: Added.
  • fast/loading/resources: Added.
  • fast/loading/resources/subframe-that-removes-itself.html: Added.
  • fast/loading/subframe-removes-itself-expected.txt: Added.
  • fast/loading/subframe-removes-itself.html: Added.
  • fast/frames/location-put-after-removal-expected.txt: Updated. For some reason, fixing the loader sequence results in output that has one more blank line.
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html: Updated tests so they don't terminate when the partial load of the subframe completes, but rather wait until the subsequent load of about:blank occurs.
  • platform/gtk/Skipped: Skip loading tests.
12:50 PM Changeset in webkit [43147] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-02 Gustavo Noronha Silva <gns@gnome.org>

Skip test that sometimes fails in GTK+.

  • platform/gtk/Skipped:
12:39 PM Changeset in webkit [43146] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-02 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=25466
WebKitGtk+ 1.1.6 prints weird error messages in Liferea

Use strlen instead of g_utf8_strlen when calculating the size of
the data that is being given to webkit_web_frame_load_string to be
loaded, so that we don't miss any of the content.

  • webkit/webkitwebframe.cpp:
5:47 AM Changeset in webkit [43145] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-02 Gustavo Noronha Silva <gns@gnome.org>

Skip new test that does not represent a regression.

  • platform/gtk/Skipped:
4:33 AM Changeset in webkit [43144] by mjs@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-05-02 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron Zwarich.

  • speed up the lexer in various ways

~2% command-line SunSpider speedup

  • parser/Lexer.cpp: (JSC::Lexer::setCode): Moved below shift() so it can inline. (JSC::Lexer::scanRegExp): Use resize(0) instead of clear() on Vectors, since the intent here is not to free the underlying buffer. (JSC::Lexer::lex): ditto; also, change the loop logic a bit for the main lexing loop to avoid branching on !m_done twice per iteration. Now we only check it once. (JSC::Lexer::shift): Make this ALWAYS_INLINE and tag an unusual branch as UNLIKELY
  • parser/Lexer.h: (JSC::Lexer::makeIdentifier): force to be ALWAYS_INLINE
  • wtf/Vector.h: (WTF::::append): force to be ALWAYS_INLINE (may have helped in ways other than parsing but it wasn't getting inlined in a hot code path in the lexer)
2:06 AM Changeset in webkit [43143] by ap@webkit.org
  • 2 edits in trunk/WebKit/mac

Reviewed by Dan Bernstein.

<rdar://problem/6741615> REGRESSION (r38629): Shortcut "Flag/Junk" in MobileMe does not work
when Kotoeri is used.

  • WebView/WebHTMLView.mm: (-[WebHTMLView inputContext]): Return a nil input context when focus is not in editable content.
12:00 AM Changeset in webkit [43142] by sfalken@apple.com
  • 2 edits in tags/Safari-6530.8.1/JavaScriptCore

Merged r43140.

Note: See TracTimeline for information about the timeline view.