Timeline
May 26, 2009:
- 11:53 PM Changeset in webkit [44181] by
-
- 7 edits in trunk
WebCore:
2009-05-26 Sam Weinig <sam@webkit.org>
Reviewed by Brady Eidson.
Fix for <rdar://problem/6916371>
iWeb 'Announce' button does nothing after publishing to MobileMe
Add ability to force content sniffing for all urls (including file: urls)
- WebCore.base.exp:
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::shouldContentSniffURL): (WebCore::ResourceHandle::forceContentSniffing):
- platform/network/ResourceHandle.h:
WebKit/mac:
2009-05-26 Sam Weinig <sam@webkit.org>
Reviewed by Brady Eidson.
Fix for <rdar://problem/6916371>
iWeb 'Announce' button does nothing after publishing to MobileMe
Add linked-on-or-after check to allow older WebKit apps to use the
old behavior of sniffing everything (including file: urls)
- Misc/WebKitVersionChecks.h:
- WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
- 11:35 PM Changeset in webkit [44180] by
-
- 5 edits1 add in trunk/WebKit/qt
2009-05-26 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by Holger Freyther.
Add an API to generate a QUrl out of a string correcting for errors and missing information.
See the API documentation for more details about the function.
Autotests: included
- Api/qwebview.cpp: (QWebView::guessUrlFromString):
- Api/qwebview.h:
- QtLauncher/main.cpp: (MainWindow::MainWindow): (MainWindow::changeLocation):
- tests/qwebview/.gitignore: Added.
- tests/qwebview/qwebview.pro:
- tests/qwebview/tst_qwebview.cpp: (tst_QWebView::initTestCase): (tst_QWebView::cleanupTestCase): (tst_QWebView::init): (tst_QWebView::cleanup): (tst_QWebView::guessUrlFromString_data): (tst_QWebView::guessUrlFromString):
- 11:35 PM Changeset in webkit [44179] by
-
- 2 edits in trunk/WebCore
2009-05-26 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
[Qt] Dead-code stripping for unix
- WebCore.pro: Turn on GCC dead-code stripping flags for Unix
- 11:25 PM Changeset in webkit [44178] by
-
- 8 edits in branches/WWDC-2009-branch/WebCore
2009-05-26 Beth Dakin <Beth Dakin>
Rubber-stamped by Dan Bernstein and Darin Adler.
Fix for <rdar://problem/6922919> Revert back to Safari 3 text
control metrics calculations
We're rolling this change out of the branch because we think it
needs more bake time.
- css/html4.css:
- platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData):
- platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::lineGap):
- platform/graphics/mac/SimpleFontDataMac.mm:
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcPrefWidths):
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::preferredContentWidth):
- 10:25 PM Changeset in webkit [44177] by
-
- 6 edits in trunk/WebCore
[GTK] Send onscroll events for the main FrameView
2009-05-10 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Dave Hyatt.
[GTK] Send onscroll events for the main FrameView
WebKit/GTK+ is currently not sending any onscroll
events for a frame with external adjustments. This is
due the fact that the value-changed signal of the GtkAdjustment
is handled by WebCore::ScrollView directly and is not going through
the WebCore::Scrollbar -> WebCore::ScrollbarClient ->
WebCore::FrameView::valueChanged -> WebCore::ScrollView::valueChanged
path.
Fix the above problem by wrapping the GtkAdjustment we get
assigned from GTK+ in a ScrollbarGtk that will not have any
visual appearance. Remove code from ScrollView that knows
about adjustments and create a special case for
WebCore::ScrollView::createScrollbar that will create such
a special WebCore::ScrollbarGtk.
- platform/ScrollView.cpp: Remove adjustment code (WebCore::ScrollView::setHasHorizontalScrollbar): (WebCore::ScrollView::setHasVerticalScrollbar): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::wheelEvent):
- platform/ScrollView.h: Remove adjustment code
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformDestroy): (WebCore::ScrollView::createScrollbar): (WebCore::ScrollView::setGtkAdjustments):
- platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::createScrollbar): Special case. (ScrollbarGtk::ScrollbarGtk): New ctor and work on the adjustment (ScrollbarGtk::~ScrollbarGtk): Disconnect signal (ScrollbarGtk::frameRectsChanged): Do nothing when we lack a platformWidget
- platform/gtk/ScrollbarGtk.h:
- 10:20 PM Changeset in webkit [44176] by
-
- 2 edits in trunk/WebCore
2009-05-26 Cameron Zwarich <zwarich@apple.com>
Reviewed by Maciej Stachowiak.
Bug 26035: Make ImageSource::frameHasAlphaAtIndex() return false for JPEGs with CG
<https://bugs.webkit.org/show_bug.cgi?id=26035>
<rdar://problem/6924087>
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::frameHasAlphaAtIndex): return false if the image is JPEG, there is no image type, or m_decoder is null.
- 9:30 PM Changeset in webkit [44175] by
-
- 2 edits in trunk/WebCore
Fix build breakage of JPEGImageDecoder.cpp by including stdio.h again.
2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
Unreviewed build fix for the JPEGImageDecoder.
Revision 44167 removed stdio.h from the included headers and
this will lead to an error that FILE is not known inside the
jpeglib.h Put back the stdio.h include.
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
- 8:22 PM Changeset in webkit [44174] by
-
- 6 edits3 adds in trunk
<rdar://problem/6924033> REGRESSION: Assertion failure due to forward references
Reviewed by Gavin Barraclough.
Add a pattern type for forward references to ensure that we don't confuse the
quantifier alternatives assertion.
- 7:54 PM Changeset in webkit [44173] by
-
- 2 edits in trunk/WebCore
2009-05-26 Yichao Yin <yichao.yin@torchmobile.com.cn>
Reviewed by Maciej Stachowiak.
Fix the crash issue while running layout tests after enabled XHTMLMP
https://bugs.webkit.org/show_bug.cgi?id=26017
- 7:47 PM Changeset in webkit [44172] by
-
- 2 edits in trunk/WebKit/mac
2009-05-26 Stephanie Lewis <Stephanie Lewis>
Reviewed by Ada Chan and Oliver Hunt.
Remove WebView observers in during fast teardown.
<rdar://problem/6922619> REGRESSION (Tiger-only?): After restoring windows from the previous session, a crash occurs while attempting to quit Safari
- WebView/WebView.mm: (-[WebView _closeWithFastTeardown]):
- 7:47 PM Changeset in webkit [44171] by
-
- 6 edits in trunk/JavaScriptCore
2009-05-26 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Fix for: <rdar://problem/6918095> REGRESSION: jQuery load() issue (25981),
and also an ASSERT failure on http://ihasahotdog.com/.
When overwriting a property on a dictionary with a cached specific value,
clear the cache if new value being written is different.
- JavaScriptCore.exp:
Export the new symbols.
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_get_by_id_method_check_second):
Close dictionary prototypes upon caching a method access, as would happen when caching
a regular get_by_id.
- runtime/JSObject.h: (JSC::JSObject::propertyStorage): (JSC::JSObject::locationForOffset):
Make these methods private.
(JSC::JSObject::putDirectInternal):
When overwriting a property on a dictionary with a cached specific value,
clear the cache if new value being written is different.
- runtime/Structure.cpp: (JSC::Structure::despecifyDictionaryFunction):
Reset the specific value field for a given property in a dictionary.
(JSC::Structure::despecifyFunctionTransition):
Rename of 'changeFunctionTransition' (this was already internally refered to as a despecification).
- runtime/Structure.h:
Declare new method.
- 5:45 PM Changeset in webkit [44170] by
-
- 11 edits in trunk
WebCore:
2009-05-26 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6901751>
REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
Don't use the WKCGContextIsSafeToClip function; it wasn't working correctly. Instead, just disable
the improved selection drawing on Tiger.
- WebCore.Tiger.exp:
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::strokeRect):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::fillSelectionGaps):
WebKit/mac:
2009-05-26 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6901751>
REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
Remove WKCGContextIsSafeToClip.
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
WebKitLibraries:
2009-05-26 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6901751>
REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
Remove WKCGContextIsSafeToClip.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceTiger.a:
- 5:33 PM Changeset in webkit [44169] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-26 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver "pieces of eight" Hunt.
When reseting RegexPattern class, should fully reset the class, not just bits of it.
In particular, we delete the cached character classes (for wordchars, etc), but do
not reset the set of pointers to the cached classes. In the case of a repeated parse
due to an illegal back-reference we will continue to use the deleted character class.
- yarr/RegexPattern.h: (JSC::Yarr::RegexPattern::reset):
- 5:29 PM Changeset in webkit [44168] by
-
- 3 edits in trunk/SunSpider
2009-05-26 Olivier DOLE <odole@pleyo.com>
Reviewed by Maciej.
Store sunspider test suite results in a specific directory for each
different type of benchmark (sunspider, V8 or ubench).
- sunspider:
- sunspider-compare-results:
- 5:20 PM Changeset in webkit [44167] by
-
- 22 edits in trunk/WebCore
2009-05-26 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25709 part two
Mostly cosmetic changes, mainly to get image decoders for Cairo build to
comply with WebKit style guidelines:
- Fix header guard names
- Fix initializer list wrapping
- Fix class/function "{" wrapping
- Fix wrapping of long boolean expressions
- Fix whitespace around operators
- Eliminate whitespace on otherwise-blank lines
- No {} on single-line conditional arms
- Use 0 instead of NULL
- Don't #include "config.h" in headers
Also a few non-cosmetic changes:
- Remove unneeded #ifdef protecting the contents of these files. The platforms listed don't match who uses these files anymore (even without considering Skia), and platforms which don't use them at all (like CG) aren't harmed by the files, since they don't have equivalently-named classes. It's simpler to just ditch these.
- Convert a use of Vector<>& into SharedBuffer*, since that's how the data is really stored anyway.
- Use size() instead of m_size, for consistency with Skia code, and future-proofing (if a particular decoder wants to specialize this).
- Move an ASSERT that was slightly more aggressive than necessary.
- Change variable names/types for clarity/accuracy and to match Skia.
- Remove unnecessary macro magic to work around a problem which no longer exists in the third-party JPEG headers.
- Stop silencing a portability warning about setjmp (the vcproj/vsprops are the right place for this)
- In Skia code, don't explicitly check |m_failed| before calling isSizeAvailable(), which itself checks |m_failed|.
- platform/image-decoders/ImageDecoder.h: Fix header guards, "{" wrapping. (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::RGBA32Buffer): Fix initializer list wrapping. (WebCore::ImageDecoder::ImageDecoder): Fix initializer list wrapping.
- platform/image-decoders/bmp/BMPImageDecoder.cpp: Remove unneeded #ifdef.
- platform/image-decoders/bmp/BMPImageDecoder.h: Fix header guards, "{" wrapping.
- platform/image-decoders/gif/GIFImageDecoder.cpp: Remove unneeded #ifdef, fix "{" wrapping. (WebCore::GIFImageDecoderPrivate::GIFImageDecoderPrivate): Use an initializer instead of a block-level statement. (WebCore::GIFImageDecoderPrivate::decode): Expect a SharedBuffer. (WebCore::GIFImageDecoderPrivate::getColorMap): (WebCore::GIFImageDecoder::GIFImageDecoder): Fix initializer list wrapping. (WebCore::GIFImageDecoder::frameCount): Add comment. (WebCore::GIFImageDecoder::frameBufferAtIndex): Explicitly cast, fix whitespace around operators. (WebCore::GIFImageDecoder::decode): Pass a SharedBuffer. (WebCore::GIFImageDecoder::initFrameBuffer): Use size() instead of m_size, move ASSERT, fix boolean wrapping, fix indenting. (WebCore::GIFImageDecoder::prepEmptyFrameBuffer): Use size() instead of m_size. (WebCore::GIFImageDecoder::haveDecodedRow): Use size() instead of m_size, eliminate unneeded whitespace, change variable name. (WebCore::GIFImageDecoder::frameComplete): Use size() instead of m_size, no {} on single-line conditional arms, fix boolean wrapping.
- platform/image-decoders/gif/GIFImageDecoder.h: Fix header guards, "{" wrapping.
- platform/image-decoders/gif/GIFImageReader.cpp: Remove unneeded #ifdef. (GIFImageReader::read):
- platform/image-decoders/gif/GIFImageReader.h: Fix header guards, change variable type.
- platform/image-decoders/ico/ICOImageDecoder.cpp: Remove unneeded #ifdef.
- platform/image-decoders/ico/ICOImageDecoder.h: Fix header guards, "{" wrapping.
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Remove unneeded #ifdef, macro magic, silencing of warning. (WebCore::JPEGImageDecoder::outputScanlines): Use size() instead of m_size, change variable name.
- platform/image-decoders/jpeg/JPEGImageDecoder.h: Fix header guards, "{" wrapping.
- platform/image-decoders/png/PNGImageDecoder.cpp: Remove unneeded #ifdef, silencing of warning, change variable type. (WebCore::PNGImageReader::PNGImageReader): Fix initializer list wrapping. (WebCore::PNGImageReader::close): Add comment, zero another member for consistency. (WebCore::PNGImageDecoder::PNGImageDecoder): Fix indenting. (WebCore::PNGImageDecoder::decodingFailed): Define in .cpp, not .h. (WebCore::PNGImageDecoder::rowAvailable):
- platform/image-decoders/png/PNGImageDecoder.h: Fix header guards, "{" wrapping.
- platform/image-decoders/skia/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily. (WebCore::GIFImageDecoder::frameBufferAtIndex): Fix whitespace around operators.
- platform/image-decoders/skia/GIFImageReader.h: "unsigned" is sufficient to convey "unsigned int".
- platform/image-decoders/skia/ImageDecoder.h: Remove unnecessary #includes. (WebCore::ImageDecoder::ImageDecoder): Fix initializer list wrapping.
- platform/image-decoders/skia/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::JPEGImageReader): Use 0 instead of NULL. (WebCore::JPEGImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily.
- platform/image-decoders/skia/PNGImageDecoder.cpp: (WebCore::PNGImageReader::PNGImageReader): Fix initializer list wrapping. (WebCore::PNGImageDecoder::PNGImageDecoder): Fix indenting. (WebCore::PNGImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily. (WebCore::rowAvailable):
- platform/image-decoders/skia/XBMImageDecoder.h: Don't #include config.h.
- platform/image-decoders/xbm/XBMImageDecoder.cpp: Remove unneeded #ifdef.
- platform/image-decoders/xbm/XBMImageDecoder.h: Fix header guards, "{" wrapping.
- 5:13 PM Changeset in webkit [44166] by
-
- 1 edit in trunk/WebKitLibraries/win/tools/scripts/VERSION
Versioning.
- 4:57 PM Changeset in webkit [44165] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Fixed a regression caused by my recent fix for NaN.
- jit/JITArithmetic.cpp: (JSC::JIT::emitBinaryDoubleOp): Actually do the comparison in reverse order, like the ChangeLog said we would, bokay?
- 4:57 PM Changeset in webkit [44164] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Darin Adler.
- fix <rdar://problem/6922371> REGRESSION (r43973): Can't type first character with an umlaut, circumflex, or accent in Mail or in a wiki
- WebView/WebHTMLView.mm: (isTextInput): Moved here. (isInPasswordField): Moved here. (-[WebHTMLView becomeFirstResponder]): Update the exposeInputContext flag and let NSApplication update the input manager with the new input context if necessary. (-[WebHTMLView _updateSelectionForInputManager]): Changed to use the NSApp global instead of +[NSApplication sharedApplication].
- 4:06 PM Changeset in webkit [44163] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-26 Brent Fulgham <bfulgham@webkit.org>
Build fix to correct r44161.
- wtf/FastAllocBase.h:
- 3:58 PM Changeset in webkit [44162] by
-
- 3 edits in trunk/WebCore
2009-05-26 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25944
Remove the uses of V8 Locker in worker execution code. No additional test is needed.
The normal WebKit layout tests should cover it. However, layout tests that start
multiple workers will fail to pass due to test shell limitation in Chromium. To cover
this, UI tests will be added (http://code.google.com/p/chromium/issues/detail?id=12554).
- bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::handleEvent):
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::initV8IfNeeded): (WebCore::WorkerContextExecutionProxy::evaluate): (WebCore::WorkerContextExecutionProxy::findOrCreateEventListenerHelper): (WebCore::WorkerContextExecutionProxy::RemoveEventListener):
- 3:25 PM Changeset in webkit [44161] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-26 Zoltan Horvath <horvath.zoltan.6@stud.u-szeged.hu>
Reviewed by Maciej Stachowiak.
Inherite HashTable from FastAllocBase, because it has been instantiated by
'new' in JavaScriptCore/runtime/JSGlobalData.cpp.
- wtf/HashTable.h:
- wtf/FastAllocBase.h: Remove 'wtf' path from TypeTraits.h to allow use outside of wtf.
- 2:41 PM Changeset in webkit [44160] by
-
- 4 edits in trunk/WebCore
2009-05-26 Dmitry Titov <dimich@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25974
Enable timers in Chromuim workers.
- bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute): Added function which can execute a callback using WorkerContext.
- bindings/v8/ScheduledAction.h: (WebCore::ScheduledAction::ScheduledAction): added url parameter to capture the worker's location.
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::SetTimeoutOrInterval): replaced NotImplemented with code to create ScheduledAction and DOMTimer. Also, removed declarations for clearTimeout/clearInterval callbacks since they are now directly generated from IDL.
- 2:19 PM Changeset in webkit [44159] by
-
- 1 edit2 deletes in trunk/LayoutTests
2009-05-26 Adam Barth <abarth@webkit.org>
Unreviewed change to disable flaky test as requested by Sam Weinig.
- http/tests/security/postMessage/origin-follows-lexical-scope-expected.txt: Removed.
- http/tests/security/postMessage/origin-follows-lexical-scope.html: Removed.
- 1:43 PM Changeset in webkit [44158] by
-
- 2 edits in trunk/WebKit/mac
Fix the Tiger build.
- Misc/WebNSObjectExtras.mm:
(-[NSInvocation _webkit_invokeAndHandleException:]): Rename the local variable so that
it doesn't conflict with a member variable on Tiger.
- 1:28 PM Changeset in webkit [44157] by
-
- 3 edits in trunk/WebCore
2009-05-26 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
https://bugs.webkit.org/show_bug.cgi?id=23649
Update V8 bindings to match SQLTransactionErrorCallback change.
- bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent): Changed to return void.
- bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Ditto.
- 1:05 PM Changeset in webkit [44156] by
-
- 4 edits2 adds2 deletes in trunk/WebCore
2009-05-26 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Move FilterEffect to platform/graphics/filters. First step to get an
SVG independent filter system.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/filters/FilterEffect.cpp: Added. (WebCore::FilterEffect::FilterEffect): (WebCore::FilterEffect::~FilterEffect): (WebCore::FilterEffect::externalRepresentation):
- platform/graphics/filters/FilterEffect.h: Added. (WebCore::FilterEffect::xBoundingBoxMode): (WebCore::FilterEffect::setXBoundingBoxMode): (WebCore::FilterEffect::yBoundingBoxMode): (WebCore::FilterEffect::setYBoundingBoxMode): (WebCore::FilterEffect::widthBoundingBoxMode): (WebCore::FilterEffect::setWidthBoundingBoxMode): (WebCore::FilterEffect::heightBoundingBoxMode): (WebCore::FilterEffect::setHeightBoundingBoxMode): (WebCore::FilterEffect::subRegion): (WebCore::FilterEffect::setSubRegion): (WebCore::FilterEffect::resultImage): (WebCore::FilterEffect::setEffectBuffer):
- svg/FilterEffect.cpp: Removed.
- svg/FilterEffect.h: Removed.
- 12:37 PM Changeset in webkit [44155] by
-
- 7 edits2 adds in trunk
WebCore:
2009-05-26 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=23649
Update SQLTransactionErrorCallback to not return a value per changes in
HTML5 spec.
Test: storage/transaction-error-callback.html
- bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
- bindings/js/JSCustomSQLTransactionErrorCallback.h:
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::postflightAndCommit): (WebCore::SQLTransaction::handleTransactionError): (WebCore::SQLTransaction::deliverTransactionErrorCallback): (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
- storage/SQLTransaction.h:
- storage/SQLTransactionErrorCallback.h:
LayouTests:
2009-05-26 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=23649
Add layout test for various cases of SQLTransactionErrorCallback
invocation.
- storage/transaction-error-callback-expected.txt: Added.
- storage/transaction-error-callback.html: Added.
- 11:29 AM Changeset in webkit [44154] by
-
- 2 edits in trunk/WebKit/mac
2009-05-26 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
<rdar://problem/6921835> REGRESSION (r44115): Crash in Leopard Mail viewing message
Fix case where we autorelease an object on the main thread that we are returning
to another thread when using our _webkit_invokeOnMainThread method.
- Misc/WebNSObjectExtras.mm: (returnTypeIsObject): Added. (-[WebMainThreadInvoker forwardInvocation:]): Autorelease the object on the calling thread, balancing a retain done on the main thread. (-[NSInvocation _webkit_invokeAndHandleException:]): Retain the object on the main thread.
- 11:26 AM Changeset in webkit [44153] by
-
- 2 edits in trunk/WebKit/mac
2009-05-26 David Hyatt <hyatt@apple.com>
Back out the workaround for Mail crashing. Darin is working on the real fix.
- Misc/WebNSObjectExtras.mm: (-[WebMainThreadInvoker forwardInvocation:]):
- 11:16 AM Changeset in webkit [44152] by
-
- 7 edits8 adds in trunk
WebCore:
2009-05-26 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler.
Detect the case where we can fit without scrollbars when the view shrinks, so that we don't mistakenly
continue to show scrollbars.
Added two tests in fast/dynamic.
- platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars):
WebKit/mac:
2009-05-26 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler.
Stop using notifications for boundsChanged, since the notifications are being sent too late.
Since subviews get resized before parents do, the notification comes in telling the WebHTMLView
that its size has changed *before* we've done setNeedsLayout in the WebView size change callback.
Become more like the Windows platform and just do the bounds changed immediately as our size is
being altered by subclassing setFrameSize in WebView.
Also patch WebDynamicScrollbarsView to detect the case where neither axis is really spilling out
past the viewport, so that in shrinking situations we figure out that we don't need scrollbars
any more.
- WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):
- WebView/WebView.mm: (-[WebView _boundsChangedToNewSize:]): (-[WebView setFrameSize:]): (-[WebView viewWillMoveToWindow:]): (-[WebView viewDidMoveToWindow]):
LayoutTests:
2009-05-26 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler.
Fix for bug 25969, scrollbars remain after document shrinks. Add a couple of layout tests
written by Dan that show various problems with scrollbars following resizes.
- fast/dynamic/window-resize-scrollbars-test.html: Added.
- fast/dynamic/window-scrollbars-test.html: Added.
- platform/mac/fast/dynamic/window-resize-scrollbars-test-expected.checksum: Added.
- platform/mac/fast/dynamic/window-resize-scrollbars-test-expected.png: Added.
- platform/mac/fast/dynamic/window-resize-scrollbars-test-expected.txt: Added.
- platform/mac/fast/dynamic/window-scrollbars-test-expected.checksum: Added.
- platform/mac/fast/dynamic/window-scrollbars-test-expected.png: Added.
- platform/mac/fast/dynamic/window-scrollbars-test-expected.txt: Added.
- 10:49 AM Changeset in webkit [44151] by
-
- 8 edits6 moves in trunk/WebCore
Bug 25801: change AccessibilityAria -> AccessibilityARIA
https://bugs.webkit.org/show_bug.cgi?id=25801
- 9:00 AM Changeset in webkit [44150] by
-
- 2 edits in trunk/WebCore
2009-05-26 Stephen White <senorblanco@chromium.org>
Reviewed by Dimitri Glazkov.
Fix the Skia path to normalize the given source rect when
drawing patterns, so it accepts negative width/height (as CG does).
Fixes Chromium bug http://www.crbug.com/6167.
- platform/graphics/skia/ImageSkia.cpp: (WebCore::Image::drawPattern):
- 5:23 AM Changeset in webkit [44149] by
-
- 6 edits in trunk/WebCore
2009-05-26 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Serialize calls to WebInspector. This is the first step where method
calls are being serialized to arrays (not yet JSON stringified ones) and
are being dispatched on the client. This change also allows client to override
InspectorFrontend, so that the serialized calls can be made on a given object
instead of in-process WebInspector global. This will be the main control flow
when InspectorController is decoupled from the in-process frontend.
- inspector/InspectorController.cpp: (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::overrideFrontendObject): (WebCore::InspectorController::show): (WebCore::InspectorController::populateScriptObjects):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addMessageToConsole): (WebCore::InspectorFrontend::addResource): (WebCore::InspectorFrontend::updateResource): (WebCore::InspectorFrontend::removeResource): (WebCore::InspectorFrontend::updateFocusedNode): (WebCore::InspectorFrontend::setAttachedWindow): (WebCore::InspectorFrontend::inspectedWindowScriptObjectCleared): (WebCore::InspectorFrontend::showPanel): (WebCore::InspectorFrontend::populateInterface): (WebCore::InspectorFrontend::reset): (WebCore::InspectorFrontend::debuggerWasEnabled): (WebCore::InspectorFrontend::debuggerWasDisabled): (WebCore::InspectorFrontend::profilerWasEnabled): (WebCore::InspectorFrontend::profilerWasDisabled): (WebCore::InspectorFrontend::parsedScriptSource): (WebCore::InspectorFrontend::failedToParseScriptSource): (WebCore::InspectorFrontend::addProfile): (WebCore::InspectorFrontend::setRecordingProfile): (WebCore::InspectorFrontend::pausedScript): (WebCore::InspectorFrontend::resumedScript): (WebCore::InspectorFrontend::addDatabase): (WebCore::InspectorFrontend::addDOMStorage): (WebCore::InspectorFrontend::newFunctionCall): (WebCore::InspectorFrontend::callSimpleFunction):
- inspector/InspectorFrontend.h:
- inspector/front-end/inspector.js: (WebInspector.dispatch):
- 12:30 AM Changeset in webkit [44148] by
-
- 3 edits3 adds in branches/nitro-extreme
2009-05-26 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig and Oliver Hunt.
Fixed two edge cases in %:
- Don't do -2147483648 % x as a fast case, since you might do -2147483648 % -1, which will signal a hardware exception due to overflow.
- In the case of a zero remainder, be sure to store negative zero if the dividend was zero.
SunSpider reports no change.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mod): (JSC::JIT::emitSlow_op_mod):
LayoutTests:
2009-05-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig and Oliver Hunt.
Added test for arithmetic edge cases.
- fast/js/arithmetic-expected.txt: Added.
- fast/js/arithmetic.html: Added.
- fast/js/resources/arithmetic.js: Added.
May 25, 2009:
- 11:20 PM Changeset in webkit [44147] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
<rdar://problem/6918671> REGRESSION (r41700): Crashes in debug DumpRenderTree at RefCountedBase::ref().
- dom/QualifiedName.cpp: (WebCore::QualifiedName::QualifiedName):
- dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl): Adjust empty namespace before QNameComponentsTranslator black magic, not after.
- 11:03 PM Changeset in webkit [44146] by
-
- 3 edits3 adds in branches/nitro-extreme
2009-05-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Fixed a regression when comparing to NaN.
- jit/JITArithmetic.cpp: (JSC::JIT::emitBinaryDoubleOp): For op_jnless and op_jnless_eq, do the comparison in reverse order, and jump if the result is below or below-or-equal. This ensures that we do jump in the case of NaN.
LayoutTests:
2009-05-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Added test for NaN comparisons.
- fast/js/nan-expected.txt: Added.
- fast/js/nan.html: Added.
- fast/js/resources/nan.js: Added. ():
- 9:21 PM Changeset in webkit [44145] by
-
- 8 edits5 adds in trunk
2009-05-25 David Levin <levin@chromium.org>
Reviewed by Maciej Stachowiak and Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=25126
Allow the buffer underlying UString to be shared.
In order to not grow the underlying size of any structure,
there is a union in the Rep string which holds
+ m_sharedBuffer -- a pointer to the shared ref counted buffer
if the class is BaseString and the buffer is being shared OR
+ m_baseString -- the BaseString if the class is only UString::Rep
but not a UString::BaseString
Ideally, m_sharedBuffer would be a RefPtr, but it cannot be because
it is in a union.
No change in sunspider perf.
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/UString.cpp: (JSC::UString::Rep::share): (JSC::UString::Rep::destroy): (JSC::UString::BaseString::sharedBuffer): (JSC::UString::BaseString::setSharedBuffer): (JSC::UString::BaseString::slowIsBufferReadOnly): (JSC::expandCapacity): (JSC::UString::Rep::reserveCapacity): (JSC::UString::expandPreCapacity): (JSC::concatenate): (JSC::UString::append):
- runtime/UString.h: (JSC::UString::Rep::Rep): (JSC::UString::Rep::): (JSC::UString::BaseString::isShared): (JSC::UString::BaseString::isBufferReadOnly): (JSC::UString::Rep::baseString):
- wtf/CrossThreadRefCounted.h: (WTF::CrossThreadRefCounted::isShared):
- wtf/OwnFastMallocPtr.h: Added. (WTF::OwnFastMallocPtr::OwnFastMallocPtr): (WTF::OwnFastMallocPtr::~OwnFastMallocPtr): (WTF::OwnFastMallocPtr::get): (WTF::OwnFastMallocPtr::release):
JavaScriptGlue:
2009-05-25 David Levin <levin@chromium.org>
Reviewed by Maciej Stachowiak and Oliver Hunt.
Added forwarding headers.
- ForwardingHeaders/wtf/CrossThreadRefCounted.h: Added.
- ForwardingHeaders/wtf/OwnFastMallocPtr.h: Added.
WebCore:
2009-05-25 David Levin <levin@chromium.org>
Reviewed by Maciej Stachowiak and Oliver Hunt.
Added forwarding headers.
- ForwardingHeaders/wtf/CrossThreadRefCounted.h: Added.
- ForwardingHeaders/wtf/OwnFastMallocPtr.h: Added.
- 9:00 PM Changeset in webkit [44144] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
SunSpider says no change.
Fixed regressions in fast/js/var-declarations-shadowing.html and
fast/js/equality.html, caused by recent == and != optimizations.
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_eq): Don't treat "compare to string" as always numeric or string comparison. If the second operand is an object, you need to ToPrimitive it, and start all over again. Also, I wrote out each of the possible cases explicitly, to cut down on redundant branching.
- 5:20 PM Changeset in webkit [44143] by
-
- 2 edits in trunk/JavaScriptCore
Re-add interpreter logic to jit-enabled builds as GCC mysteriously regresses without it
Reviewed by Maciej Stachowiak
- 5:08 PM Changeset in webkit [44142] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-25 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Fix bug in fast/js/constant-folding.html where we were not negating
-0 properly.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_negate):
- 4:52 PM Changeset in webkit [44141] by
-
- 15 edits in branches/WWDC-2009-branch
Merge r44136.
- 4:52 PM Changeset in webkit [44140] by
-
- 2 edits in branches/WWDC-2009-branch/WebKit/mac
Merge r44132.
- 4:52 PM Changeset in webkit [44139] by
-
- 3 edits2 adds in branches/WWDC-2009-branch
Merge r44075.
- 4:52 PM Changeset in webkit [44138] by
-
- 2 edits in branches/WWDC-2009-branch/WebKit/mac
Merge r44069.
- 4:51 PM Changeset in webkit [44137] by
-
- 2 edits in branches/WWDC-2009-branch/WebCore
Merge r44066.
- 3:48 PM Changeset in webkit [44136] by
-
- 15 edits in trunk
WebCore:
2009-05-25 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
- WebCore side of <rdar://problem/6914001>.
Add a new m_allowPopupsFromPlugin flag.
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::processingUserGesture):
- bindings/js/ScriptController.h: (WebCore::ScriptController::setAllowPopupsFromPlugin): (WebCore::ScriptController::allowPopupsFromPlugin):
WebKit/mac:
2009-05-25 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
- WebKit side of <rdar://problem/6914001>.
- Plugins/Hosted/NetscapePluginHostManager.h:
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::didCreateWindow): Iterate over all plug-in hosts. If one is in full-screen mode, make sure to activate the WebKit app instead.
- Plugins/Hosted/NetscapePluginHostProxy.h: (WebKit::NetscapePluginHostProxy::isMenuBarVisible): Add getter.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): Add allowPopups flag.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::PluginRequest::PluginRequest): (WebKit::NetscapePluginInstanceProxy::PluginRequest::allowPopups): (WebKit::NetscapePluginInstanceProxy::loadURL): (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): (WebKit::NetscapePluginInstanceProxy::loadRequest): (WebKit::NetscapePluginInstanceProxy::evaluate): Use "allowPopups" instead of "userGesture".
- Plugins/Hosted/WebKitPluginClient.defs: Add allowPopups argument to Evaluate.
- Plugins/Hosted/WebKitPluginHostTypes.h: Use "allowPopups" instead of "userGesture".
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): Call didCreateWindow here.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchCreatePage): Ditto.
- 2:33 PM Changeset in webkit [44135] by
-
- 10 edits8 adds in trunk
WebCore:
2009-05-25 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Sort out our use of dynamicGlobalObject and lexicalGlobalObject for
window.location. The correct use appears to be as follows:
1) Use dynamicGlobalObject to find the user gesture.
2) Use dynamicGlobalObject to complete URLs.
3) Use lexicalGlobalObject to find the referrer.
4) Use lexicalGlobalObject for the frame navigation checks.
5) Use lexicalGlobalObject for the XSS checks.
Tests: http/tests/security/frameNavigation/context-for-location-assign.html
http/tests/security/frameNavigation/context-for-location-href.html
http/tests/security/frameNavigation/context-for-location.html
- bindings/js/JSDOMBinding.cpp: (WebCore::shouldAllowNavigation): (WebCore::toLexicalFrame): (WebCore::processingUserGesture): (WebCore::completeURL):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation):
- bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::JSLocation::setHref): (WebCore::JSLocation::replace): (WebCore::JSLocation::reload): (WebCore::JSLocation::assign): (WebCore::JSLocation::toString): (WebCore::JSLocationPrototype::customPut):
- bindings/v8/V8Utilities.cpp: (WebCore::processingUserGesture): (WebCore::shouldAllowNavigation): (WebCore::completeURL): (WebCore::navigateIfAllowed):
- bindings/v8/V8Utilities.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetLocation):
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-25 Adam Barth <abarth@webkit.og>
Reviewed by Sam Weinig.
Test our use of dynamicGlobalObject and lexicalGlobalObject for
window.location.
- http/tests/security/frameNavigation/context-for-location-assign-expected.txt: Added.
- http/tests/security/frameNavigation/context-for-location-assign.html: Added.
- http/tests/security/frameNavigation/context-for-location-expected.txt: Added.
- http/tests/security/frameNavigation/context-for-location-href-expected.txt: Added.
- http/tests/security/frameNavigation/context-for-location-href.html: Added.
- http/tests/security/frameNavigation/context-for-location.html: Added.
- http/tests/security/frameNavigation/resources/middle-frame-for-location.html: Added.
- http/tests/security/frameNavigation/resources/target-for-location.html: Added.
- 2:11 PM Changeset in webkit [44134] by
-
- 2 edits in trunk/LayoutTests/http/tests/security/postMessage
Unreviewed attempt to fix flaky origin-follows-lexical-scope test. (Test only fails on buildbot.)
- 12:33 PM Changeset in webkit [44133] by
-
- 4 edits1 add in trunk/LayoutTests
2009-05-25 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Try to make test less flaky.
- http/tests/security/postMessage/origin-follows-lexical-scope-expected.txt:
- http/tests/security/postMessage/origin-follows-lexical-scope.html:
- http/tests/security/postMessage/resources/middle-frame-for-lexical.html:
- http/tests/security/postMessage/resources/post-message-listener-with-ready.html: Added.
- 11:48 AM Changeset in webkit [44132] by
-
- 2 edits in trunk/WebKit/mac
2009-05-25 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
- Fix <rdar://problem/6915849>.
Release the placeholder window after -[NSApplication runModalForWindow] returns.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::beginModal): (WebKit::NetscapePluginHostProxy::endModal):
- 8:41 AM Changeset in webkit [44131] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-25 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Maciej Stachowiak.
The functions written in assembly need to have a leading
underscore on Windows too.
- jit/JITStubs.cpp:
- 8:41 AM Changeset in webkit [44130] by
-
- 3 edits in trunk/WebCore
2009-05-25 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Maciej Stachowiak.
With Windows compilers older then MSVC 2005, the functions
gmtime_s and localtime_s don't exist. The gmtime and localtime are
on Windows always thread safe. So use them in the cases where
gmtime_s and localtime_s are not present.
- loader/FTPDirectoryDocument.cpp:
- loader/FTPDirectoryParser.cpp:
- 5:55 AM Changeset in webkit [44129] by
-
- 2 edits in trunk/WebCore
2009-05-25 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon Hausmann.
Follow up on r44120. PluginPackageMac.cpp is used
by Qt on Mac and contained a copy of the m_browserFunc
assignments and ::equal, ::hash and ::compareFileVersion.
Change it to use the ones from PluginPackage.cpp as well.
- 5:39 AM Changeset in webkit [44128] by
-
- 3 edits in trunk/WebCore
2009-05-25 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Support conditionals in the tag factories, by placing
feature #ifdefs around the individual factory functions
and the registration.
Made the Audio and Video elements conditional in the tag factories
- 4:45 AM Changeset in webkit [44127] by
-
- 2 edits in trunk/WebCore
2009-05-25 Simon Hausmann <simon.hausmann@nokia.com>
Fix the Gtk build when video is disabled.
- 4:35 AM Changeset in webkit [44126] by
-
- 2 edits in trunk/WebCore
2009-05-25 Simon Hausmann <simon.hausmann@nokia.com>
Fix the Qt build when video is disabled.
- WebCore.pro: Always generate the IDL files for the media elements. They contain proper ENABLE(VIDEO) #ifdefs.
- 1:36 AM Changeset in webkit [44125] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix ChangeLog typo.
- 1:29 AM Changeset in webkit [44124] by
-
- 4 edits3 adds in trunk
WebCore:
2009-05-25 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
The origin for postMessage should follow lexical scope, not dynamic
scope. Yes, this is a super-obscure conner case.
Test: http/tests/security/postMessage/origin-follows-lexical-scope.html
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::postMessage):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
LayoutTests:
2009-05-25 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Test that the origin for postMessage follows the lexical scope.
- http/tests/security/postMessage/origin-follows-lexical-scope-expected.txt: Added.
- http/tests/security/postMessage/origin-follows-lexical-scope.html: Added.
- http/tests/security/postMessage/resources/middle-frame-for-lexical.html: Added.
May 24, 2009:
- 11:27 PM Changeset in webkit [44123] by
-
- 2 edits in trunk/WebCore
2009-05-24 Darin Fisher <darin@chromium.org>
Reviewed by Mark Rowe.
Fix build bustage related to PassOwnPtr changes.
- platform/graphics/chromium/TransparencyWin.cpp:
- 10:20 PM Changeset in webkit [44122] by
-
- 2 edits in trunk/WebKit/mac
- revert an accidental change from r43964.
- WebView/WebView.mm: (+[WebView _setShouldUseFontSmoothing:]):
- 8:29 PM Changeset in webkit [44121] by
-
- 2 edits in trunk/WebCore
2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Maciej Stachowiak.
Minor cleanup in PluginPackage::hash. Let the compiler
figure out the size of the array. Do not have it in the
definition and specially not the in the call to
StringImpl::hash.
- plugins/PluginPackage.cpp: (WebCore::PluginPackage::hash):
- 8:29 PM Changeset in webkit [44120] by
-
- 6 edits in trunk/WebCore
2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Maciej Stachowiak.
Move ::hash, ::equal and ::compareFileVersion from
the duplicated copies in PluginPackageQt.cpp and
PluginPackageGtk to PluginPackage.cpp. We need to #ifdef
this for the PluginPackageWin version. Use the new style
ENABLE() for this feature/policy and enable it in the Gtk+
and Qt buildsystem.
- GNUmakefile.am:
- WebCore.pro:
- plugins/PluginPackage.cpp: (WebCore::PluginPackage::hash): (WebCore::PluginPackage::equal): (WebCore::PluginPackage::compareFileVersion):
- plugins/gtk/PluginPackageGtk.cpp:
- plugins/qt/PluginPackageQt.cpp:
- 8:28 PM Changeset in webkit [44119] by
-
- 6 edits in trunk/WebCore
2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Maciej Stachowiak.
So far the initialization of the browserfuncs struct
is done in PluginPackageQt, PluginPackageGtk and
PluginPackageWin there is no need for this duplication.
The PluginPackageWin version got copied to PluginPackage
- plugins/PluginPackage.cpp: (WebCore::PluginPackage::initializeBrowserFuncs):
- plugins/PluginPackage.h:
- plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::load):
- plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::load):
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):
- 3:43 PM Changeset in webkit [44118] by
-
- 5 edits5 adds in trunk/WebCore
2009-05-24 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991
Added standard input for filter system.
No testcases were added. Filter system is still off.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/filters/SourceAlpha.cpp: Added. (WebCore::SourceAlpha::create): (WebCore::SourceAlpha::effectName): (WebCore::SourceAlpha::apply): (WebCore::SourceAlpha::dump):
- platform/graphics/filters/SourceAlpha.h: Added. (WebCore::SourceAlpha::SourceAlpha):
- platform/graphics/filters/SourceGraphic.cpp: Added. (WebCore::SourceGraphic::create): (WebCore::SourceGraphic::effectName): (WebCore::SourceGraphic::apply): (WebCore::SourceGraphic::dump):
- platform/graphics/filters/SourceGraphic.h: Added. (WebCore::SourceGraphic::SourceGraphic):
- svg/FilterBuilder.cpp: Added. (WebCore::FilterBuilder::FilterBuilder): (WebCore::FilterBuilder::add): (WebCore::FilterBuilder::getEffectById): (WebCore::FilterBuilder::clearEffects):
- svg/FilterBuilder.h:
- 12:35 PM QtWebKitContrib edited by
- (diff)
- 11:13 AM Changeset in webkit [44117] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-24 Steve Falkenburg <sfalken@apple.com>
Build fix for experimental PGO Windows target.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 11:10 AM Changeset in webkit [44116] by
-
- 3 edits in trunk/WebCore
2009-05-24 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Maciej Stachowiak.
Add support conditionals in the JSC bindings generator code for attributes,
by placing feature #ifdefs around the setters/getters.
Made the audio and video element specific DOM attributes conditional
in the generated code, by moving the #ifdefs from the IDL files into
the generated code. This allows for re-using the same generated code
with or without ENABLE(VIDEO).
- 9:34 AM Changeset in webkit [44115] by
-
- 2 edits in trunk/WebKit/mac
2009-05-24 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein and Tim Hatcher.
<rdar://problem/6913045> New console message spewed by automator CLI after installing JetstreamLeo40B21a
- Misc/WebNSObjectExtras.mm: (-[WebMainThreadInvoker initWithTarget:]): Tweaked argument name. (-[WebMainThreadInvoker forwardInvocation:]): Removed call to retainArguments. This was unneeded and in the case of a newly created but not yet fully initialized NSView object it caused the abovementioned bug. (-[WebMainThreadInvoker handleException:]): Tweaked argument name. Added assertion. (-[NSInvocation _webkit_invokeAndHandleException:]): Tweaked name of local variable that holds the exception.
- 8:34 AM Changeset in webkit [44114] by
-
- 2 edits in trunk/WebKit
2009-05-24 Darin Adler <Darin Adler>
- StringsNotToBeLocalized.txt: Updated for recent changes. Got rid of most full-file exceptions.
- 12:48 AM Changeset in webkit [44113] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=25987
[GTK] Clarify WebKitWebView::download-requested documentation
Explain a bit why this signal is not emitted by default and offer
a common solution/setup for that issue.
- webkit/webkitwebview.cpp: (webkit_web_view_class_init):
May 23, 2009:
- 11:38 PM Changeset in webkit [44112] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix for Qt. Change signature to have PassOwnPtr.
- 10:14 PM Changeset in webkit [44111] by
-
- 5 edits7 adds in trunk/WebKitTools
Land the updated version of WebKitLauncher that the nightly builds have been using.
Reviewed by Oliver Hunt.
Changes include:
1) Support for self-updating via Sparkle.
2) Now respects the "Open using Rosetta" preference.
3) Passes environment variables through to the spawned Safari process.
4) Logs a list of extensions that are detected to the system console.
5) Disables extensions that are known to cause crashes too early in the
launch process to be detected by the extension-detection code.
- WebKitLauncher/Configurations/Base.xcconfig: Added.
- WebKitLauncher/Configurations/WebKitLauncher.xcconfig: Added.
- WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig: Added.
- WebKitLauncher/Info.plist:
- WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
- WebKitLauncher/WebKitNightlyEnabler.h: Added.
- WebKitLauncher/WebKitNightlyEnabler.m:
(myBundleDidLoad):
(myApplicationWillFinishLaunching):
(poseAsWebKitApp):
(webKitLauncherBundle):
(enableWebKitNightlyBehaviour):
- WebKitLauncher/WebKitNightlyEnablerSparkle.h: Added.
- WebKitLauncher/WebKitNightlyEnablerSparkle.m: Added.
(initializeSparkle):
(updatePermissionPromptDescription):
(skipSignatureVerificationInDownloadDidFinish):
(updateAlertPanel):
(updateAlertInitForAlertPanel):
(-[NSAlert webKitHandleButtonPress:]):
(setMethodImplementation):
- WebKitLauncher/main.m:
(displayErrorAndQuit):
(getLastVersionShown):
(saveLastVersionShown):
(getPathForStartPage):
(getCurrentVersion):
(getShowStartPageVersion):
(startPageDisabled):
(addStartPageToArgumentsIfNeeded):
(preferredArchitecture):
(myExecve):
(locateSafariBundle):
(currentMacOSXVersion):
(checkFrameworkPath):
(main):
- 9:21 PM Changeset in webkit [44110] by
-
- 1 edit in trunk/ChangeLog
Fix typo "am" -> "an" in the Changelog of my previous commit
- 9:06 PM Changeset in webkit [44109] by
-
- 2 edits in trunk
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Unreviewed build fix. Add gstreamer-video-0.10 libs to
GSTREAMER_LIBS to resolve am undefined reference to gst_video_get_size
- symbol used in MediaPlayerPrivateGstreamer.
- configure.ac:
- 4:28 PM Changeset in webkit [44108] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
- clean up ColorMac a little
- platform/graphics/mac/ColorMac.h: Whitespace change.
- platform/graphics/mac/ColorMac.mm: Removed redundant #import statements and sorted the remaining ones. (WebCore::makeRGBAFromNSColor): Replaced four Objective-C method calls with a single call and removed redundant casts to int. (WebCore::nsColor): Removed ".0f" from number literals used as CGFloats. In one case, this avoids an intermediate conversion to float before conversion to double on 64-bit. (WebCore::CGColorFromNSColor): Replaced four Objective-C method calls with a single call. (WebCore::focusRingColor): (+[WebCoreControlTintObserver controlTintDidChange]): Whitespace change.
- 3:55 PM Changeset in webkit [44107] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Refactored new slow case codegen for == and !=.
SunSpider reports no change, maybe a tiny speedup.
- jit/JITOpcodes.cpp: (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emitSlow_op_neq): Made a vptr comparison a *Ptr operation, instead of *32, to make it portable to 64bit. Reorganized the string and generic cases to make their control flow a little clearer.
- 3:39 PM Changeset in webkit [44106] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Rubber-stamped by Gustavo Noronha.
Break the switch once private browsing is selected.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_set_property): (webkit_web_settings_get_property):
- 3:35 PM Changeset in webkit [44105] by
-
- 7 edits in trunk
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha and Xan Lopez.
[Gtk] Enable database and localStorage support
https://bugs.webkit.org/show_bug.cgi?id=25629
Enable storage/ tests for Gtk.
- platform/gtk/Skipped:
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha and Xan Lopez.
[Gtk] Enable database and localStorage support
https://bugs.webkit.org/show_bug.cgi?id=25629
Add settings to enable or disable database and localStorage
support and enable them by default. This allows databases to be
shown in the WebInspector as well as allow us to run the storage
layout tests.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha and Xan Lopez.
[Gtk] Enable database and localStorage support
https://bugs.webkit.org/show_bug.cgi?id=25629
Enable database and localStorage for running the storage/ tests.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- 3:22 PM Changeset in webkit [44104] by
-
- 2 edits in trunk/WebCore
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] ROLE_ROW_HEADER should not be used for list item bullets/numbers
https://bugs.webkit.org/show_bug.cgi?id=25900
Use ATK_ROLE_TEXT for ListMarkerRole.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkRole):
- 3:20 PM Changeset in webkit [44103] by
-
- 2 edits in trunk
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286
Refactor library LIBS. Move third-party libs in libwebkit instead
of libWebCore.
- GNUmakefile.am:
- 3:08 PM Changeset in webkit [44102] by
-
- 2 edits in trunk/WebCore
Reformat WebCore::requiresContextForWordBoundary()
- platform/text/TextBoundaries.h: (WebCore::requiresContextForWordBoundary):
- 2:29 PM Changeset in webkit [44101] by
-
- 2 edits in trunk/WebCore
Not reviewed. Roll out ResourceHandle patch, that I accidently included in my last commit.
- 2:25 PM Changeset in webkit [44100] by
-
- 23 edits2 adds in trunk/WebCore
Reviewed by Darin Adler.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=23808
After a long journey, add the last missing ABC to share form control element support with HTMLSelectElement.
RenderListBox/RenderMenuList operates on SelectElement instead of HTMLSelectElement now, querying selected index etc.
This makes it possible to use these render objects for ie. WML, as it's done before for input & option elements.
WMLSelectElement will be created soon, in a follow-up patch, adding more methods to SelectElement, sharing code between
HTMLSelectElement/WMLSelectElement.
- 10:32 AM Changeset in webkit [44099] by
-
- 3 edits in trunk/WebCore
Fix Gtk/Qt builds for PassOwnPtr
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern): Use an OwnPtr<ImageBuffer> instead of an std::auto_ptr<ImageBuffer> to store the result of ImageBuffer::create() now that it returns a PassOwnPtr<ImageBuffer>.
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeContains): Ditto. (WebCore::Path::strokeBoundingRect): Ditto.
- 10:16 AM Changeset in webkit [44098] by
-
- 3 edits in trunk/WebKit/win
Windows build fix for PassOwnPtr
- WebHistory.cpp: (WebHistory::visitedURL): Changed std::auto_ptr<Vector<String> >() to 0.
- WebHistoryItem.cpp: (WebHistoryItem::initFromDictionaryRepresentation): Changed type of redirectURLsVector from std::auto_ptr<Vector<String> > to OwnPtr<Vector<String> >.
- 10:06 AM Changeset in webkit [44097] by
-
- 6 edits in branches/nitro-extreme/JavaScriptCore
2009-05-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Optimized == and != for our new value representation -- especially for strings.
14% speedup on date-format-tofte.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq):
- jit/JITStubCall.h: (JSC::JITStubCall::JITStubCall):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_eq): (JSC::JITStubs::cti_op_eq_strings): (JSC::JITStubs::cti_op_call_eval):
- jit/JITStubs.h: (JSC::):
- runtime/JSValue.h:
- 9:39 AM Changeset in webkit [44096] by
-
- 42 edits in trunk
Part 2 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
Reviewed by Oliver Hunt.
WebCore:
No test cases added since there is no change in behavior.
- WebCore.base.exp: Updated export for HistoryItem::setRedirectURLs() which now takes a PassOwnPtr.
- dom/Node.cpp: (WebCore::Node::childNodes): Use NodeListsNodeData::create() instead of new NodeListsNodeData. (WebCore::Node::registerDynamicNodeList): Ditto. (WebCore::Node::getElementsByTagNameNS): Ditto. (WebCore::Node::getElementsByName): Ditto. (WebCore::Node::getElementsByClassName): Ditto.
- dom/NodeRareData.h: (WebCore::NodeListsNodeData::create): Added. Implements create() pattern popularized by RefCounted classes. (WebCore::NodeListsNodeData::NodeListsNodeData): Declared private constructor. (WebCore::NodeRareData::setNodeLists): Now takes a PassOwnPtr<> instead of an auto_ptr<>.
- history/HistoryItem.cpp: (WebCore::HistoryItem::setRedirectURLs): Ditto.
- history/HistoryItem.h: (WebCore::HistoryItem::setRedirectURLs): Ditto.
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer): Updated to use assignment operator now that ImageBuffer::create() returns a PassOwnPtr<>.
- loader/EmptyClients.h: (WebCore::EmptyChromeClient::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
- page/ChromeClient.h: (WebCore::ChromeClient::createHTMLParserQuirks): Ditto.
- platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::create): Return PassOwnPtr<> instead of auto_ptr<>. Use OwnPtr<> instead of auto_ptr<> for stack variable.
- platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- platform/text/TextCodec.h: (WebCore::NewTextCodecFunction): Return PassOwnPtr<> instead of auto_ptr<>.
- platform/text/TextCodecICU.cpp: (WebCore::newTextCodecICU): Ditto.
- platform/text/TextCodecLatin1.cpp: (WebCore::newStreamingTextDecoderWindowsLatin1): Ditto.
- platform/text/TextCodecUTF16.cpp: (WebCore::newStreamingTextDecoderUTF16LE): Ditto. (WebCore::newStreamingTextDecoderUTF16BE): Ditto.
- platform/text/TextCodecUserDefined.cpp: (WebCore::newStreamingTextDecoderUserDefined): Ditto.
- platform/text/TextEncodingRegistry.cpp: (WebCore::newTextCodec): Ditto.
- platform/text/TextEncodingRegistry.h: (WebCore::newTextCodec): Ditto.
- platform/text/mac/TextCodecMac.cpp: (WebCore::newTextCodecMac): Ditto.
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent): Ditto. Return OwnPtr<> instead of auto_ptr<>.
- svg/SVGMaskElement.h: (WebCore::SVGMaskElement::drawMaskerContent): Return OwnPtr<> instead of auto_ptr<>.
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame): Updated to use assignment operator now that ImageBuffer::create() returns a PassOwnPtr<>.
- svg/graphics/SVGPaintServerGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setTile): Updated to take a PassOwnPtr<> instead of an auto_ptr<>. (WebCore::SVGPaintServerPattern::setup): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- svg/graphics/SVGPaintServerPattern.h: (WebCore::SVGPaintServerPattern::setTile): Updated to take a PassOwnPtr<> instead of an auto_ptr<>.
- svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask): Updated to use assignment operator now that SVGMaskElement::drawMaskerContent() returns a PassOwnPtr<>. Use OwnPtr<> instead of auto_ptr<> for stack variable.
WebKit/gtk:
- WebCoreSupport/ChromeClientGtk.h: (WebKit::ChromeClient::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
WebKit/mac:
- History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:method:wasFailure:]): Return 0 instead of an empty auto_ptr<>.
- History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- WebCoreSupport/WebChromeClient.h: (WebChromeClient::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
WebKit/qt:
- WebCoreSupport/ChromeClientQt.h: (WebCore::ChromeClientQt::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
WebKit/win:
- WebCoreSupport/WebChromeClient.h: (WebChromeClient::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
WebKit/wx:
- WebKitSupport/ChromeClientWx.h: (WebCore::ChromeClientWx::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
- 9:39 AM Changeset in webkit [44095] by
-
- 10 edits10 adds in trunk
Part 1 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
Reviewed by Oliver Hunt.
- GNUmakefile.am: Added OwnPtrCommon.h and PassOwnPtr.h.
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
- JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
- wtf/OwnPtr.h: (WTF::OwnPtr::OwnPtr): Added constructors that take a PassOwnPtr. Also added a copy constructor declaration that's required when assigning a PassOwnPtr to a stack-based OwnPtr. (WTF::operator=): Added assignment operator methods that take a PassOwnPtr. (WTF::swap): Reformatted. (WTF::operator==): Whitespace changes. (WTF::operator!=): Ditto.
- wtf/OwnPtrCommon.h: Added. (WTF::deleteOwnedPtr):
- wtf/PassOwnPtr.h: Added. (WTF::PassOwnPtr::PassOwnPtr): (WTF::PassOwnPtr::~PassOwnPtr): (WTF::PassOwnPtr::get): (WTF::PassOwnPtr::clear): (WTF::PassOwnPtr::release): (WTF::PassOwnPtr::operator*): (WTF::PassOwnPtr::operator->): (WTF::PassOwnPtr::operator!): (WTF::PassOwnPtr::operator UnspecifiedBoolType): (WTF::::operator): (WTF::operator==): (WTF::operator!=): (WTF::static_pointer_cast): (WTF::const_pointer_cast): (WTF::getPtr):
JavaScriptGlue:
- ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
- ForwardingHeaders/wtf/PassOwnPtr.h: Added.
WebCore:
- ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
- ForwardingHeaders/wtf/PassOwnPtr.h: Added.
- WebCore.vcproj/WebCore.vcproj: Added OwnPtrCommon.h and PassOwnPtr.h.
WebKit/mac:
- ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
- ForwardingHeaders/wtf/PassOwnPtr.h: Added.
WebKitTools:
- DumpRenderTree/ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
- DumpRenderTree/ForwardingHeaders/wtf/PassOwnPtr.h: Added.
- 9:15 AM Changeset in webkit [44094] by
-
- 14 edits in trunk/WebCore
Fix Mac builds by backing out r44093
- bindings/js/JSCustomPositionCallback.cpp:
- bindings/js/JSCustomPositionCallback.h:
- bindings/js/JSCustomPositionErrorCallback.cpp:
- bindings/js/JSCustomPositionErrorCallback.h:
- bindings/js/JSGeolocationCustom.cpp:
- page/Geolocation.cpp:
- page/Geolocation.idl:
- page/Geoposition.cpp:
- page/Geoposition.h:
- page/Geoposition.idl:
- page/Navigator.cpp: (WebCore::Navigator::disconnectFrame): (WebCore::Navigator::geolocation):
- page/PositionError.idl:
- platform/GeolocationService.cpp: (WebCore::GeolocationService::create):
- 8:28 AM Changeset in webkit [44093] by
-
- 14 edits in trunk/WebCore
2009-05-23 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
Add GEOLOCATION guards around Geolocation API code
https://bugs.webkit.org/show_bug.cgi?id=25756
- bindings/js/JSCustomPositionCallback.cpp:
- bindings/js/JSCustomPositionCallback.h:
- bindings/js/JSCustomPositionErrorCallback.cpp:
- bindings/js/JSCustomPositionErrorCallback.h:
- bindings/js/JSGeolocationCustom.cpp:
- page/Geolocation.cpp:
- page/Geolocation.idl:
- page/Geoposition.cpp:
- page/Geoposition.h:
- page/Geoposition.idl:
- page/Navigator.cpp: (WebCore::Navigator::disconnectFrame): (WebCore::Navigator::geolocation):
- page/PositionError.idl:
- platform/GeolocationService.cpp:
- 8:21 AM Changeset in webkit [44092] by
-
- 2 edits in trunk/WebKitTools
resolve-ChangeLogs: Add missing newline to status message
- Scripts/resolve-ChangeLogs: Added newline to status message
that is printed when the -ccontinue switch is used but there are unmerged files remaining in the git working directory.
- 8:07 AM Changeset in webkit [44091] by
-
- 4 edits in trunk/WebCore
Rename startupdateStyleIfNeededDispatcher to startUpdateStyleIfNeededDispatcher
In r42377, startUpdateRenderingDispatcher() was renamed to
startupdateStyleIfNeededDispatcher(), but the camelCase "U" was
dropped. This change restores it.
- WebCore.order:
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::startUpdateStyleIfNeededDispatcher): (WebCore::AnimationControllerPrivate::addEventToDispatch): (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch): (WebCore::AnimationControllerPrivate::pauseAnimationAtTime): (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
- page/animation/AnimationControllerPrivate.h:
- 7:03 AM Changeset in webkit [44090] by
-
- 3 edits in trunk/WebKit/qt
2009-05-23 Jakob Truelsen <antialize@gmail.com>
Reviewed by Holger Freyther.
Expose the default text encoding property to Qt.
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::setDefaultTextEncoding): (QWebSettings::defaultTextEncoding):
- Api/qwebsettings.h:
- 6:55 AM Changeset in webkit [44089] by
-
- 2 edits in trunk/WebCore
Unreviewed build-fix for Qt. Disable SVG Filters.
SVG Filters can not be built right now and Qt should not have
them enabled anyway as they did not carry out any filtering.
- 4:08 AM Changeset in webkit [44088] by
-
- 5 edits in trunk
Remove interpreter specific logic from the JIT builds
Reviewed by Maciej Stachowiak.
This saves ~100k in JSC release builds.
- 2:06 AM Changeset in webkit [44087] by
-
- 1 edit3 adds in trunk/LayoutTests
Add tests to cover exceptions thrown from non-object results of get_by_id
Reviewed by Maciej Stachowiak
- 1:25 AM Changeset in webkit [44086] by
-
- 2 edits in trunk/WebKitTools
Add an error message to a die statement
- 12:32 AM Changeset in webkit [44085] by
-
- 2 edits in trunk/WebCore
2009-05-23 Dirk Schulze <krit@webkit.org>
Unreviewed build-fix for gtk. Remove source input files
for SVG filter system from the build for the moment and
add them later again.
- GNUmakefile.am:
- 12:22 AM Changeset in webkit [44084] by
-
- 2 edits1 delete in trunk/LayoutTests
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Unreviewed. Skip new tests introduced in r44010. These tests
require an eventSender implementation which the gtk port
currently do not have.
Also remove gtk-specific result for
fast/canvas/canvas-composite-alpha. The non-platform specific
result now works.
- platform/gtk/Skipped:
- platform/gtk/fast/canvas/canvas-composite-alpha-expected.txt: Removed.
- 12:19 AM Changeset in webkit [44083] by
-
- 38 edits in trunk/WebCore
2009-05-23 Dirk Schulze <krit@webkit.org>
Reviewed by Eric Seidel.
WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991
Preparing Filter primitves for the new filter system.
No testcases were added. SVG filters are off by default.
- GNUmakefile.am:
- platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):
- platform/graphics/filters/FEBlend.h:
- platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
- platform/graphics/filters/FEColorMatrix.h:
- platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::apply):
- platform/graphics/filters/FEComponentTransfer.h:
- platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
- platform/graphics/filters/FEComposite.h:
- svg/Filter.h:
- svg/FilterBuilder.h: (WebCore::FilterBuilder::lastFilter):
- svg/FilterEffect.cpp: (WebCore::FilterEffect::FilterEffect):
- svg/FilterEffect.h: (WebCore::FilterEffect::xBoundingBoxMode): (WebCore::FilterEffect::setXBoundingBoxMode): (WebCore::FilterEffect::yBoundingBoxMode): (WebCore::FilterEffect::setYBoundingBoxMode): (WebCore::FilterEffect::widthBoundingBoxMode): (WebCore::FilterEffect::setWidthBoundingBoxMode): (WebCore::FilterEffect::heightBoundingBoxMode): (WebCore::FilterEffect::setHeightBoundingBoxMode): (WebCore::FilterEffect::subRegion): (WebCore::FilterEffect::setSubRegion): (WebCore::FilterEffect::resultImage): (WebCore::FilterEffect::setEffectBuffer):
- svg/graphics/filters/SVGFEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::apply):
- svg/graphics/filters/SVGFEConvolveMatrix.h:
- svg/graphics/filters/SVGFEDiffuseLighting.cpp: (WebCore::FEDiffuseLighting::apply):
- svg/graphics/filters/SVGFEDiffuseLighting.h:
- svg/graphics/filters/SVGFEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply):
- svg/graphics/filters/SVGFEDisplacementMap.h:
- svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::apply):
- svg/graphics/filters/SVGFEFlood.h:
- svg/graphics/filters/SVGFEGaussianBlur.cpp: (WebCore::FEGaussianBlur::apply):
- svg/graphics/filters/SVGFEGaussianBlur.h:
- svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::apply):
- svg/graphics/filters/SVGFEImage.h:
- svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::apply):
- svg/graphics/filters/SVGFEMerge.h:
- svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply):
- svg/graphics/filters/SVGFEMorphology.h:
- svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
- svg/graphics/filters/SVGFEOffset.h:
- svg/graphics/filters/SVGFESpecularLighting.cpp: (WebCore::FESpecularLighting::apply):
- svg/graphics/filters/SVGFESpecularLighting.h:
- svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):
- svg/graphics/filters/SVGFETile.h:
- svg/graphics/filters/SVGFETurbulence.cpp: (WebCore::FETurbulence::apply):
- svg/graphics/filters/SVGFETurbulence.h:
May 22, 2009:
- 11:25 PM Changeset in webkit [44082] by
-
- 2 edits in trunk/WebCore
2009-05-22 Dirk Schulze <krit@webkit.org>
Unreviewed build-fix for gtk. Breakage caused by a wrong call of ImageBuffer.
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
- 11:00 PM Changeset in webkit [44081] by
-
- 2 edits in trunk/WebCore
2009-05-22 Dirk Schulze <vbs85@gmx.de>
Reviewed by Eric Seidel.
Added the use of tileRect() for a correct drawing of
border-images.
Testcases for border-image are in fast/borders like
border-image-01.html and will be activated for cairo, once
gtk supports pixel tests.
https://bugs.webkit.org/show_bug.cgi?id=19652
[CAIRO] wrong drawing of border-image
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
- 10:47 PM Changeset in webkit [44080] by
-
- 3 edits in trunk/JavaScriptCore
Part two of an attempted Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 10:47 PM Changeset in webkit [44079] by
-
- 2 edits in trunk/WebCore
Ask the Scrollbar for the orientation.
https://bugs.webkit.org/show_bug.cgi?id=25684
Use Scrollbar::orientation to figure out the
direction of scrolling.
- 10:13 PM Changeset in webkit [44078] by
-
- 3 edits in trunk/JavaScriptCore
Part one of an attempted Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 9:51 PM Changeset in webkit [44077] by
-
- 2 edits in trunk/WebKit/gtk
Improve network request docs
- 6:48 PM Changeset in webkit [44076] by
-
- 30 edits in trunk/JavaScriptCore
2009-05-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
op_method_check
Optimize method calls, by caching specific function values within the Structure.
The new opcode is used almost like an x86 opcode prefix byte to optimize op_get_by_id,
where the property access is being used to read a function to be passed to op-call (i.e.
'foo.bar();'). This patch modifies the Structure class such that when a property is
put to an object for the first time we will check if the value is a function. If it is,
we will cache the function value on the Structure. A Structure in such a state guarantees
that not only does a property with the given identifier exist on the object, but also that
its value is unchanged. Upon any further attempt to put a property with the same identifier
(but a different value) to the object, it will transition back to a normal Structure (where
it will guarantee the presence but not the value of the property).
op_method_check makes use of the new information made available by the Structure, by
augmenting the functionality of op_get_by_id. Upon generating a FunctionCallDotNode a
check will be emitted prior to the property access reading the function value, and the JIT
will generate an extra (initially unlinked but patchable) set of checks prior to the regular
JIT code for get_by_id. The new code will do inline structure and prototype structure check
(unlike a regular get_by_id, which can only handle 'self' accesses inline), and then performs
an immediate load of the function value, rather than using memory accesses to load the value
from the obejct's property storage array. If the method check fails it will revert, or if
the access is polymorphic, the op_get_by_id will continue to operate - and optimize itself -
just as any other regular op_get_by_id would.
~2.5% on v8-tests, due to a ~9% progression on richards.
- API/JSCallbackObjectFunctions.h: (JSC::::put): (JSC::::staticFunctionGetter):
- API/JSObjectRef.cpp: (JSObjectMakeConstructor):
- JavaScriptCore.exp:
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::differenceBetween):
- assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::moveWithPatch):
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
- bytecode/CodeBlock.h: (JSC::getMethodCallLinkInfoReturnLocation): (JSC::CodeBlock::getMethodCallLinkInfo): (JSC::CodeBlock::addMethodCallLinkInfos): (JSC::CodeBlock::methodCallLinkInfo):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitMethodCheck):
- bytecompiler/BytecodeGenerator.h:
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile):
- jit/JIT.h: (JSC::MethodCallCompilationInfo::MethodCallCompilationInfo):
- jit/JITOpcodes.cpp:
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_method_check): (JSC::JIT::emitSlow_op_method_check): (JSC::JIT::emit_op_get_by_id): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emitSlow_op_put_by_id): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::patchMethodCallProto):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_get_by_id_method_check): (JSC::JITStubs::cti_op_get_by_id_method_check_second):
- jit/JITStubs.h:
- jsc.cpp: (GlobalObject::GlobalObject):
- parser/Nodes.cpp: (JSC::FunctionCallDotNode::emitBytecode):
- runtime/Arguments.cpp: (JSC::Arguments::put):
- runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor):
- runtime/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor):
- runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
- runtime/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor): (JSC::constructError):
- runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
- runtime/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor):
- runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype):
- runtime/InternalFunction.cpp: (JSC::InternalFunction::InternalFunction):
- runtime/JSActivation.cpp: (JSC::JSActivation::put): (JSC::JSActivation::putWithAttributes):
- runtime/JSByteArray.cpp: (JSC::JSByteArray::JSByteArray):
- runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): (JSC::JSFunction::getOwnPropertySlot):
- runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::putWithAttributes): (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::mark):
- runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): (JSC::JSGlobalObject::methodCallDummy):
- runtime/JSObject.cpp: (JSC::JSObject::put): (JSC::JSObject::putWithAttributes): (JSC::JSObject::deleteProperty): (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::getPropertyAttributes): (JSC::JSObject::getPropertySpecificFunction): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectFunctionWithoutTransition):
- runtime/JSObject.h: (JSC::getJSFunction): (JSC::JSObject::getDirectLocation): (JSC::JSObject::putDirect): (JSC::JSObject::putDirectWithoutTransition):
- runtime/LiteralParser.cpp: (JSC::LiteralParser::parseObject):
- runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
- runtime/Lookup.h: (JSC::lookupPut):
- runtime/MathObject.cpp: (JSC::MathObject::MathObject):
- runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor): (JSC::NativeErrorConstructor::construct):
- runtime/NativeErrorPrototype.cpp: (JSC::NativeErrorPrototype::NativeErrorPrototype):
- runtime/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor):
- runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor):
- runtime/PropertyMapHashTable.h: (JSC::PropertyMapEntry::PropertyMapEntry):
- runtime/PrototypeFunction.cpp: (JSC::PrototypeFunction::PrototypeFunction):
- runtime/PutPropertySlot.h: (JSC::PutPropertySlot::): (JSC::PutPropertySlot::PutPropertySlot): (JSC::PutPropertySlot::setNewProperty): (JSC::PutPropertySlot::setDespecifyFunctionProperty): (JSC::PutPropertySlot::isCacheable): (JSC::PutPropertySlot::cachedOffset):
- runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor):
- runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
- runtime/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
- runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::~Structure): (JSC::Structure::materializePropertyMap): (JSC::Structure::addPropertyTransitionToExistingStructure): (JSC::Structure::addPropertyTransition): (JSC::Structure::changeFunctionTransition): (JSC::Structure::addPropertyWithoutTransition): (JSC::Structure::get): (JSC::Structure::despecifyFunction): (JSC::Structure::put): (JSC::Structure::remove):
- runtime/Structure.h: (JSC::Structure::get): (JSC::Structure::specificFunction):
- runtime/StructureTransitionTable.h: (JSC::StructureTransitionTableHashTraits::emptyValue):
- wtf/Platform.h:
- 6:34 PM Changeset in webkit [44075] by
-
- 3 edits2 adds in trunk
WebCore:
2009-05-22 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
<rdar://problem/6916082> Incorrect handling of % as CSS value.
Test: fast/css/percent-character-as-value.html
- css/CSSGrammar.y: Make a stray % character reliably cause CSS parsing to succeed, but the CSS value to be ignored because of incorrect type. A type of 0 has this effect.
LayoutTests:
2009-05-22 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6916082> Incorrect handling of % as CSS value.
- fast/css/percent-character-as-value-expected.txt: Added.
- fast/css/percent-character-as-value.html: Added.
- 6:01 PM Changeset in webkit [44074] by
-
- 1 edit in trunk/WebCore/ChangeLog
Add bugs.webkit.org URL for r44046
- 5:59 PM Changeset in webkit [44073] by
-
- 5 edits in trunk
WebCore:
2009-05-22 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=25971
Correct a handful of build errors in the Windows Cairo variant
due to missing VIDEO support.
- WebCore.vcproj/WebCore.vcproj: Exclude RenderMediaControls for the Cairo-based Windows target.
- rendering/RenderThemeWin.cpp: Avoid #include of RenderMediaControls for non-VIDEO builds.
WebKit/win:
2009-05-22 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=25971
Correct some build errors for Windows Cairo variant.
- WebKit.vcproj/WebKit.vcproj: Remove WTF.lib link commands as the new JavaScriptCore.dll supplies this now.
- 5:54 PM Changeset in webkit [44072] by
-
- 4 edits in branches/WWDC-2009-branch
Versioning.
- 5:53 PM Changeset in webkit [44071] by
-
- 1 copy in tags/Safari-6530.12
New tag.
- 5:48 PM Changeset in webkit [44070] by
-
- 2 edits in trunk/WebCore
One <limits> is enough
- html/HTMLMediaElement.cpp: Removed duplicate #include <limits>.
- 3:58 PM Changeset in webkit [44069] by
-
- 2 edits in trunk/WebKit/mac
2009-05-22 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
- Fix <rdar://problem/6913765> REGRESSION (r42331-r42334): Extra scroll bars appearing on Welcome panels of iLife '09 apps
- WebView/WebView.mm: (needsUnwantedScrollBarWorkaround): Added. Checks if this is a panel where scroll bars are unwanted. For safety, limited to only Apple applications. (-[WebView viewDidMoveToWindow]): If the workaround is needed, disallow scrolling the main frame. This prevents scroll bars from appearing.
- 2:57 PM Changeset in webkit [44068] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Fix non-SSE enabled builds.
- jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_add): Don't early return here, we still need to call the JIT stub. (JSC::JIT::emitSlow_op_sub): Ditto.
- 2:54 PM Changeset in webkit [44067] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Here's a thought: let's not take a jit stub call just to multiply by 1,
bokay?
imul doesn't set the zero flag, so to test for a zero result, we need
an explicit instruction. (Luckily, it does set the overflow flag, so
we can still use that.)
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul): (JSC::JIT::emitMul32InPlace):
- 2:30 PM Changeset in webkit [44066] by
-
- 2 edits in trunk/WebCore
2009-05-22 Jon Honeycutt <jhoneycutt@apple.com>
<rdar://problem/6915957> REGRESSION: Hang when leaving page with VLC
plug-in
Reviewed by Steve Falkenburg.
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::determineQuirks): Look for the VLC plug-in's new name.
- 2:15 PM Changeset in webkit [44065] by
-
- 3 edits in trunk/WebCore
2009-05-22 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Remove redudant member from Chromium's ResourceRequest. We already
have this data in the cross-platform ResourceRequestBase. Also, rename
ChromiumBridge parameter to be consistant with the new name for this
piece of data.
- platform/chromium/ChromiumBridge.h:
- platform/network/chromium/ResourceRequest.h:
- 2:14 PM Changeset in webkit [44064] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-05-22 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey "Premature Commit" Garen.
Add back constant integer cases for op_add.
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_add): (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emitSlowAdd32Constant):
- jit/JITInlineMethods.h: (JSC::JIT::getConstantOperandImmediateDouble): (JSC::JIT::isOperandConstantImmediateDouble):
- 2:11 PM Changeset in webkit [44063] by
-
- 5 edits2 adds in trunk
Modify projects to use CFLite when not building the Apple Windows port.
- 2:07 PM Changeset in webkit [44062] by
-
- 7 edits in branches/nitro-extreme/JavaScriptCore
2009-05-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added fast double cases for op_jnless and op_jnlesseq.
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::JumpList::jumps): New accesor, used by addSlowCase.
- assembler/X86Assembler.h: (JSC::X86Assembler::ucomisd_rm): New method for comparing register to memory.
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::emit_op_add): (JSC::JIT::emit_op_sub): (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_mul): (JSC::JIT::emit_op_div): Modified emitBinaryDoubleOp to accept comparison/jump operations in addition to operations with explicit result registers.
- jit/JITInlineMethods.h: (JSC::JIT::addSlowCase): Added an "addSlowCase" for JumpLists, so clients can track multiple jumps to the same slow case condition together.
- 1:48 PM Changeset in webkit [44061] by
-
- 3 edits in trunk/LayoutTests
2009-05-22 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
- Made the global-function-resolve test independent of hashing order by using a fixed set of properties. This also removes the need for us to update this test every time we add something to the window object or the js-test-pre.js family of scripts.
- fast/js/global-function-resolve-expected.txt: Updated.
- fast/js/resources/global-function-resolve.js: Use a fixed array instead of using all property names from the global object; also made other small changes that don't have an effect on the substance of the test.
- 1:35 PM Changeset in webkit [44060] by
-
- 6 edits in trunk
Reviewed by Kevin Ollivier.
Triple-click support for wx port. Also, switch to allocating GraphicsContext
on the stack in OnPaint since we only need it within that function.
https://bugs.webkit.org/show_bug.cgi?id=25962
- 1:32 PM Changeset in webkit [44059] by
-
- 1 edit in trunk/WebCore/ChangeLog
Date fix on ChangeLog.
- 1:31 PM Changeset in webkit [44058] by
-
- 1 edit2 deletes in trunk/LayoutTests
Reviewed by Darin Adler.
- remove a test that was supposed to test the text/* change to MIME types from r43979, since the change was rolled out, and the test seems to be ineffective anyway, since it was passing on Mac after rolling out the change.
- http/tests/mime/accept-all-text-types-expected.txt: Removed.
- http/tests/mime/accept-all-text-types.html: Removed.
- 1:11 PM Changeset in webkit [44057] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
Only account for overhang for multi-character strings.
https://bugs.webkit.org/show_bug.cgi?id=25961
- 1:03 PM Changeset in webkit [44056] by
-
- 3 edits in trunk/WebCore
wx build fix. Switch to CURL cookies so we can benefit from API updates.
- 12:41 PM Changeset in webkit [44055] by
-
- 1 edit in trunk/ChangeLog
Fixing changelog message
- 12:40 PM Changeset in webkit [44054] by
-
- 2 edits in trunk
2009-05-22 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Gustavo Noronha.
Make Gtk build not bail out if gtk-doc-tools is not installed.
Warning message dumped instead.
- autogen.sh:
- 12:07 PM Changeset in webkit [44053] by
-
- 3 edits in trunk
2009-05-22 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Add big warnings about the glib unicode backend being slow and
incomplete, since it is a work in progress.
- autotools/webkit.m4:
- configure.ac:
- 12:06 PM Changeset in webkit [44052] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-21 Xan Lopez <xlopez@igalia.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=24818
[GTK] http auth dialog pops up twice after a cancelled atempt
Workaround libsoup bug
http://bugzilla.gnome.org/show_bug.cgi?id=583462, which made
libsoup emit the 'authenticate' signal more often than it was
expected.
We'll be able to remove this when we depend on libsoup > 2.26.2.
- webkit/webkitsoupauthdialog.c: (session_authenticate):
- 11:39 AM Changeset in webkit [44051] by
-
- 8 edits in trunk/WebCore
2009-05-22 Peter Kasting <pkasting@google.com>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=25709 part one
Indent contents of namespaces in header files, to comply with the
style guide. No functional change.
- platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::bytes): (WebCore::RGBA32Buffer::rect): (WebCore::RGBA32Buffer::height): (WebCore::RGBA32Buffer::status): (WebCore::RGBA32Buffer::duration): (WebCore::RGBA32Buffer::disposalMethod): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setRect): (WebCore::RGBA32Buffer::ensureHeight): (WebCore::RGBA32Buffer::setStatus): (WebCore::RGBA32Buffer::setDuration): (WebCore::RGBA32Buffer::setDisposalMethod): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setRGBA): (WebCore::ImageDecoder::m_failed): (WebCore::ImageDecoder::~ImageDecoder): (WebCore::ImageDecoder::setData): (WebCore::ImageDecoder::size): (WebCore::ImageDecoder::frameCount): (WebCore::ImageDecoder::repetitionCount): (WebCore::ImageDecoder::supportsAlpha): (WebCore::ImageDecoder::failed): (WebCore::ImageDecoder::setFailed): (WebCore::ImageDecoder::clearFrameBufferCache):
- platform/image-decoders/bmp/BMPImageDecoder.h: (WebCore::BMPImageDecoder::filenameExtension):
- platform/image-decoders/gif/GIFImageDecoder.h: (WebCore::GIFImageDecoder::filenameExtension): (WebCore::GIFImageDecoder::frameDurationAtIndex): (WebCore::GIFImageDecoder::):
- platform/image-decoders/ico/ICOImageDecoder.h: (WebCore::ICOImageDecoder::filenameExtension):
- platform/image-decoders/jpeg/JPEGImageDecoder.h: (WebCore::JPEGImageDecoder::filenameExtension): (WebCore::JPEGImageDecoder::supportsAlpha): (WebCore::JPEGImageDecoder::reader): (WebCore::JPEGImageDecoder::setSize):
- platform/image-decoders/png/PNGImageDecoder.h: (WebCore::PNGImageDecoder::filenameExtension): (WebCore::PNGImageDecoder::reader): (WebCore::PNGImageDecoder::decodingFailed):
- platform/image-decoders/xbm/XBMImageDecoder.h: (WebCore::XBMImageDecoder::filenameExtension):
- 11:06 AM Changeset in webkit [44050] by
-
- 14 edits4 adds in trunk
WebCore
2009-05-22 Dominik Röttsches <dominik.roettsches@access-company.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=15914
[GTK] Implement Unicode functionality using GLib
Minor changes that allow building a hybrid version of WebKit
that has WTF Unicode backend based on GLib functions while
text codecs and TextBreakIterator remain based on ICU.
Fixed some includes that were assuming a WTF ICU backend and
introduced temporary usage of WTF_USE_GLIB_ICU_UNICODE_HYBRID
macro.
- platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::ThreadGlobalData): (WebCore::ThreadGlobalData::~ThreadGlobalData):
- platform/ThreadGlobalData.h:
- platform/text/TextBoundariesICU.cpp:
- platform/text/TextCodecICU.h:
- platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encode):
- platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): (WebCore::extendTextCodecMaps):
2009-05-22 Dominik Röttsches <dominik.roettsches@access-company.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=15914
[GTK] Implement Unicode functionality using GLib
Original patch by Jürg Billeter and Naiem Shaik.
Implementing WTF Unicode functionality based on GLib.
- GNUmakefile.am:
- wtf/unicode/Unicode.h:
- wtf/unicode/glib: Added.
- wtf/unicode/glib/UnicodeGLib.cpp: Added. (WTF::Unicode::foldCase): (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::direction): (WTF::Unicode::umemcasecmp):
- wtf/unicode/glib/UnicodeGLib.h: Added. (WTF::Unicode::): (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::toTitleCase): (WTF::Unicode::isArabicChar): (WTF::Unicode::isFormatChar): (WTF::Unicode::isSeparatorSpace): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isDigit): (WTF::Unicode::isPunct): (WTF::Unicode::mirroredChar): (WTF::Unicode::category): (WTF::Unicode::isLower): (WTF::Unicode::digitValue): (WTF::Unicode::combiningClass): (WTF::Unicode::decompositionType):
- wtf/unicode/glib/UnicodeMacrosFromICU.h: Added.
- 9:59 AM Changeset in webkit [44049] by
-
- 1 edit in trunk/WebKit/win/WebMutableURLRequest.cpp
Unreviewed build fix.
- 9:45 AM Changeset in webkit [44048] by
-
- 16 edits in trunk
WebCore:
2009-05-22 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Remove the policyBaseURL parameter from setCookie. This parameter is
redundant with the document parameter.
- WebCore.base.exp:
- WebCore.order:
- dom/Document.cpp: (WebCore::Document::setCookie):
- platform/CookieJar.h:
- platform/mac/CookieJar.mm: (WebCore::setCookies):
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::firstPartyForCookies): (WebCore::ResourceRequestBase::setFirstPartyForCookies):
- platform/network/chromium/CookieJarChromium.cpp: (WebCore::setCookies):
- platform/network/curl/CookieJarCurl.cpp: (WebCore::setCookies):
- platform/network/soup/CookieJarSoup.cpp: (WebCore::setCookies):
- platform/network/win/CookieJarCFNetWin.cpp: (WebCore::setCookies):
- platform/network/win/CookieJarWin.cpp: (WebCore::setCookies):
- platform/qt/CookieJarQt.cpp: (WebCore::setCookies):
WebKit/mac:
2009-05-22 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Remove the policyBaseURL parameter from setCookie. This parameter is
redudant with the document parameter.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::setCookies):
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView setVariable:forURL:value:length:]):
- 9:44 AM Changeset in webkit [44047] by
-
- 14 edits in trunk/WebCore
2009-05-22 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Rename policyBaseURL and mainDocumentURL to firstPartyForCookies. The
previous names were confusing and inaccurate.
- WebCore.order:
- dom/Document.cpp: (WebCore::Document::setCookie):
- dom/Document.h: (WebCore::Document::firstPartyForCookies): (WebCore::Document::setFirstPartyForCookies):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::updateFirstPartyForCookies): (WebCore::FrameLoader::setFirstPartyForCookies): (WebCore::FrameLoader::open): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::loadResourceSynchronously):
- loader/FrameLoader.h:
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest):
- platform/CookieJar.h:
- platform/mac/CookieJar.mm: (WebCore::setCookies):
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::adopt): (WebCore::ResourceRequestBase::copyData): (WebCore::ResourceRequestBase::firstPartyForCookies): (WebCore::ResourceRequestBase::setFirstPartyForCookies): (WebCore::equalIgnoringHeaderFields):
- platform/network/ResourceRequestBase.h:
- platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest):
- platform/network/chromium/CookieJarChromium.cpp: (WebCore::setCookies):
- platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdateResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest):
- 9:08 AM Changeset in webkit [44046] by
-
- 2 edits in trunk/WebCore
Fix the call to editingCancelled to be this._editingCancelled, since
editingCancelled doesn't exist and throws an exception.
Reviewed by Timothy Hatcher.
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
- 8:33 AM Changeset in webkit [44045] by
-
- 2 edits in trunk/WebKitTools
2009-05-22 Andre Pedralho <andre.pedralho@openbossa.org>
Reviewed by Simon Hausmann.
Fixed --makeargs usage in Qt build.
- 8:00 AM Changeset in webkit [44044] by
-
- 2 edits in trunk/WebCore
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25928
Several errors detected by cppcheck
Fix all (the only one) problem in cross-platform code found by the tool. Port maintainers
should take a look at other reports.
- css/CSSParser.cpp: (WebCore::CSSParser::addProperty): Don't leak the property even if there are billions of those.
- 7:26 AM Changeset in webkit [44043] by
-
- 2 edits in trunk/WebKitTools
2009-05-22 Zoltan Horvath <horvath.zoltan.6@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
Correcting error message on missing WEBKIT_TESTFONTS
environment varible in Qt-port.
- 7:26 AM Changeset in webkit [44042] by
-
- 2 edits in trunk/LayoutTests
2009-05-22 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Skip tests depending on platform dependent results.
- 6:24 AM Changeset in webkit [44041] by
-
- 7 edits in trunk
2009-05-22 Shinichiro Hamaji <hamaji@google.com>
Reviewed by Oliver Hunt.
Remove optimization path alpha=0 case from GraphicContext(CG|Skia).
This optimization doesn't make sense for some composite mode (e.g., 'copy' operation).
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::strokeRect):
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::strokeRect):
- 6:12 AM Changeset in webkit [44040] by
-
- 3 edits1 add in trunk/WebKit/qt
2009-05-21 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Simon Hausmann.
[Qt] Additional test for resource load (CSS file) for QWebFrame.
- tests/qwebframe/qwebframe.qrc:
- tests/qwebframe/style.css: Added.
- tests/qwebframe/tst_qwebframe.cpp:
- 6:03 AM QtWebKitContrib edited by
- (diff)
- 2:10 AM QtWebKitContrib edited by
- (diff)
- 1:37 AM Changeset in webkit [44039] by
-
- 3 edits in trunk/WebCore
2009-05-22 Xan Lopez <xlopez@igalia.com>
Unreviewed build fix.
Revert the whole thing, since we can't figure out a way to make it
work in all platforms.
- rendering/SVGInlineTextBox.cpp: (WebCore::pathForDecoration):
- svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):
- 1:36 AM Changeset in webkit [44038] by
-
- 3 edits in trunk/WebKit/qt
2009-05-22 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed Qt build fix.
Provide dummy implementation of pure virtual EditorClient method.
- 1:20 AM Changeset in webkit [44037] by
-
- 2 edits in trunk/WebCore
2009-05-22 Xan Lopez <xlopez@igalia.com>
Try to fix Windows build.
Apparently it can't tell if '1.0f' is float or double, so cast to
float.
- rendering/SVGInlineTextBox.cpp: (WebCore::pathForDecoration):
- 1:11 AM Changeset in webkit [44036] by
-
- 3 edits in trunk/WebCore
2009-05-22 Xan Lopez <xlopez@igalia.com>
Try to fix breakage from the previous patch.
- rendering/SVGInlineTextBox.cpp: (WebCore::pathForDecoration):
- svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):
- 12:28 AM Changeset in webkit [44035] by
-
- 3 edits in trunk/WebCore
2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=25805
In debug build, mingw win32 build has problems with powf
Change C-style calls to powf and sqrtf to C++-style calls to
overloaded pow and sqrt. This solves also a problem with mingw
compiler during the debug build.
- rendering/SVGInlineTextBox.cpp: (WebCore::pathForDecoration):
- svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):
