Timeline



May 31, 2009:

11:06 PM Changeset in webkit [44310] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-05-31 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Olliej "you just need to change NativeFunctionWrapper.h" Hunt.

Add ENABLE_JIT_OPTIMIZE_NATIVE_CALL switch to allow JIT to operate without native call optimizations.

  • runtime/NativeFunctionWrapper.h:
  • wtf/Platform.h:
10:36 PM Changeset in webkit [44309] by krit@webkit.org
  • 8 edits
    2 adds
    2 deletes in trunk/WebCore

2009-05-31 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

WebKit needs cross-platform filter system
​https://bugs.webkit.org/show_bug.cgi?id=19991

A short clean-up. FilterBuilder is SVG specific. Move it
to svg/graphics/filters and rename it to SVGFilterBuilder.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/FilterBuilder.cpp: Removed.
  • svg/FilterBuilder.h: Removed.
  • svg/SVGFilterElement.cpp:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::SVGResourceFilter):
  • svg/graphics/SVGResourceFilter.h: (WebCore::SVGResourceFilter::builder):
  • svg/graphics/filters/SVGFilterBuilder.cpp: Added. (WebCore::SVGFilterBuilder::SVGFilterBuilder): (WebCore::SVGFilterBuilder::add): (WebCore::SVGFilterBuilder::getEffectById): (WebCore::SVGFilterBuilder::clearEffects):
  • svg/graphics/filters/SVGFilterBuilder.h: Added. (WebCore::SVGFilterBuilder::lastEffect):
10:35 PM Changeset in webkit [44308] by ap@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Fix a typo in ChangeLog.

10:23 PM Changeset in webkit [44307] by ap@webkit.org
  • 6 edits in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=13233
Need to implement an optimizing XPath evaluator

Avoid sorting results of hierarchical paths that are natuarlly sorted. On a flat data structure
with 128K nodes and a simple XPath expression, this changes evaluation time from 1.5 minutes
to 33 ms.

  • xml/XPathNodeSet.h: Keep track of whether subtrees rooted at nodes in set are disjoint, which is useful for optimization. (WebCore::XPath::NodeSet::NodeSet): Removed, it was identical to compiler generated one. (WebCore::XPath::NodeSet::operator=): Ditto. (WebCore::XPath::NodeSet::swap): Ditto. (WebCore::XPath::NodeSet::isSorted): Single element sets are always sorted, even if sort() was never called. (WebCore::XPath::NodeSet::markSubtreesDisjoint): Just like being sorted, the new flag is maintained by callers. (WebCore::XPath::NodeSet::subtreesAreDisjoint): A single element set only has one subtree. Currently, the only way for a set to gain this flag is to be produced from a single element set with a hierarchical location path.
  • xml/XPathPath.cpp: (WebCore::XPath::LocationPath::evaluate): Use the new flag to avoid maintaining a set of unique nodes, and to avoid sorting the result.
9:18 PM Changeset in webkit [44306] by ap@webkit.org
  • 14 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=13233
Need to implement an optimizing XPath evaluator

This patch adds some infrastructure and simple optimizations. Namely,

  • we now avoid building a full NodeSet just to evaluate a predicate in some cases;
  • "/descendant-or-self::node()/child::" is optimized to iterate the tree once when possible;

WebCore:

  • xml/XPathExpressionNode.cpp: (WebCore::XPath::Expression::Expression):
  • xml/XPathExpressionNode.h: (WebCore::XPath::Expression::addSubExpression): (WebCore::XPath::Expression::isContextNodeSensitive): (WebCore::XPath::Expression::isContextPositionSensitive): (WebCore::XPath::Expression::isContextSizeSensitive): (WebCore::XPath::Expression::setIsContextNodeSensitive): (WebCore::XPath::Expression::setIsContextPositionSensitive): (WebCore::XPath::Expression::setIsContextSizeSensitive): XPath expression now knows its result type, and whether evaluation depends on context.
  • xml/XPathFunctions.cpp: (WebCore::XPath::FunLast::resultType): (WebCore::XPath::FunLast::FunLast): (WebCore::XPath::FunPosition::resultType): (WebCore::XPath::FunPosition::FunPosition): (WebCore::XPath::FunCount::resultType): (WebCore::XPath::FunId::resultType): (WebCore::XPath::FunLocalName::resultType): (WebCore::XPath::FunLocalName::FunLocalName): (WebCore::XPath::FunNamespaceURI::resultType): (WebCore::XPath::FunNamespaceURI::FunNamespaceURI): (WebCore::XPath::FunName::resultType): (WebCore::XPath::FunName::FunName): (WebCore::XPath::FunString::resultType): (WebCore::XPath::FunString::FunString): (WebCore::XPath::FunConcat::resultType): (WebCore::XPath::FunStartsWith::resultType): (WebCore::XPath::FunContains::resultType): (WebCore::XPath::FunSubstringBefore::resultType): (WebCore::XPath::FunSubstringAfter::resultType): (WebCore::XPath::FunSubstring::resultType): (WebCore::XPath::FunStringLength::resultType): (WebCore::XPath::FunStringLength::FunStringLength): (WebCore::XPath::FunNormalizeSpace::resultType): (WebCore::XPath::FunNormalizeSpace::FunNormalizeSpace): (WebCore::XPath::FunTranslate::resultType): (WebCore::XPath::FunBoolean::resultType): (WebCore::XPath::FunNot::resultType): (WebCore::XPath::FunTrue::resultType): (WebCore::XPath::FunFalse::resultType): (WebCore::XPath::FunLang::resultType): (WebCore::XPath::FunLang::FunLang): (WebCore::XPath::FunNumber::resultType): (WebCore::XPath::FunNumber::FunNumber): (WebCore::XPath::FunSum::resultType): (WebCore::XPath::FunFloor::resultType): (WebCore::XPath::FunCeiling::resultType): (WebCore::XPath::FunRound::resultType): (WebCore::XPath::Function::setArguments): Set optimization details for the expression. Normally, a function does not introduce context node set dependency, but some use context node as default argument, or otherwise use the context.
  • xml/XPathFunctions.h: Tweaked style.
  • xml/XPathPath.cpp: (WebCore::XPath::Filter::Filter): A filter is as context node set sensitive as its expression is. (WebCore::XPath::LocationPath::LocationPath): A location path can only be context node sensitive, and only if the path relative. (WebCore::XPath::LocationPath::appendStep): Invoke compile-time Step optimizations. (WebCore::XPath::LocationPath::insertFirstStep): Ditto. (WebCore::XPath::Path::Path): A path is as context node set sensitive as its filter is.
  • xml/XPathPath.h: (WebCore::XPath::Filter::resultType): Result type of a filter is the same as of its expression (useful filters return NodeSets, of course). (WebCore::XPath::LocationPath::setAbsolute): An absolute location path if context node set insensitive. (WebCore::XPath::LocationPath::resultType): A path's result is always a node set. (WebCore::XPath::Path::resultType): Ditto.
  • xml/XPathPredicate.h: (WebCore::XPath::Number::resultType): Return a proper result type. (WebCore::XPath::StringExpression::resultType): Ditto. (WebCore::XPath::Negative::resultType): Ditto. (WebCore::XPath::NumericOp::resultType): Ditto. (WebCore::XPath::EqTestOp::resultType): Ditto. (WebCore::XPath::LogicalOp::resultType): Ditto. (WebCore::XPath::Union::resultType): Ditto. (WebCore::XPath::Predicate::isContextPositionSensitive): A predicate can be context position sensitive even if its expression is not, because e.g. [5] is a shortcut for [position()=5]. (WebCore::XPath::Predicate::isContextSizeSensitive): This matches expression result.
  • xml/XPathStep.h: (WebCore::XPath::Step::NodeTest::Kind): Removed unused ElementNodeTest, which was previously borrowed from XPath 2.0 to express some optimizations. (WebCore::XPath::Step::NodeTest::mergedPredicates): To avoid building a huge node set and filtering it with predicates, we now try to apply predicates while enumerating an axis. (WebCore::XPath::Step::nodeTest): Expose m_nodeTest.
  • xml/XPathStep.cpp: (WebCore::XPath::Step::~Step): The step owns NodeTest merged predicates, so it is still possible to copy NodeTests. (WebCore::XPath::Step::optimize): Merge predicates into NodeTest if possible. (WebCore::XPath::optimizeStepPair): Optimize some expressions containing "". (WebCore::XPath::Step::predicatesAreContextListInsensitive): The above optimization is only possible if there are no context sensitive predicates for "". (WebCore::XPath::Step::evaluate): Track context position for the first merged predicate. (WebCore::XPath::nodeMatchesBasicTest): Check whether the node matches node test, ignoring merged predicates. (WebCore::XPath::nodeMatches): Additionally check merged predicates, and update position. (WebCore::XPath::Step::nodesInAxis): Check merged predicates in optimized attribute code path.
  • xml/XPathVariableReference.h: (WebCore::XPath::VariableReference::resultType): Variable references are not used with XPathEvaluator, so we'll only need them if we decide to reimplement XSLT. The type of variable reference is not known at compile time.

LayoutTests:

  • fast/xpath/attribute-node-predicate-expected.txt: Added.
  • fast/xpath/attribute-node-predicate.html: Added. Test that predicates on attribute nodes are applied correctly (which I had wrong for a while when working on this patch).
  • fast/xpath/position-expected.txt:
  • fast/xpath/position.html: Added an example from XPath spec.
8:59 PM Changeset in webkit [44305] by mitz@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Add Windows results for fast/forms/isindex-placeholder.html

8:55 PM Changeset in webkit [44304] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

2009-05-31 Sam Weinig <​sam@webkit.org>

Implement LayoutTestController::clearAllDatabases()
on Windows.

8:05 PM Changeset in webkit [44303] by weinig@apple.com
  • 4 edits
    1 delete in trunk/WebCore

2009-05-31 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Dan Bernstein.

Remove unused JSEventTargetBase.h

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventTargetBase.h: Removed.
7:56 PM Changeset in webkit [44302] by weinig@apple.com
  • 6 edits in trunk

WebCore:

2009-05-31 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Part of ​https://bugs.webkit.org/show_bug.cgi?id=26100
Add missing event handler properties to the DOMWindow

Add missing oncanplay, oncanplaythrough, ondurationchange, onemptied,
onended, onloadeddata, onloadedmetadata, onpause, onplay, onplaying,
onratechange, onseeked, onseeking, ontimeupdate, onvolumechange,
onwaiting, onloadstart, onprogress, onstalled, onsuspend, ondrag,
ondragend, ondragenter, ondragleave, ondragover, ondragstart and
ondrop event handlers to the DOMWindow.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::ondrag): (WebCore::DOMWindow::setOndrag): (WebCore::DOMWindow::ondragend): (WebCore::DOMWindow::setOndragend): (WebCore::DOMWindow::ondragenter): (WebCore::DOMWindow::setOndragenter): (WebCore::DOMWindow::ondragleave): (WebCore::DOMWindow::setOndragleave): (WebCore::DOMWindow::ondragover): (WebCore::DOMWindow::setOndragover): (WebCore::DOMWindow::ondragstart): (WebCore::DOMWindow::setOndragstart): (WebCore::DOMWindow::ondrop): (WebCore::DOMWindow::setOndrop): (WebCore::DOMWindow::oncanplay): (WebCore::DOMWindow::setOncanplay): (WebCore::DOMWindow::oncanplaythrough): (WebCore::DOMWindow::setOncanplaythrough): (WebCore::DOMWindow::ondurationchange): (WebCore::DOMWindow::setOndurationchange): (WebCore::DOMWindow::onemptied): (WebCore::DOMWindow::setOnemptied): (WebCore::DOMWindow::onended): (WebCore::DOMWindow::setOnended): (WebCore::DOMWindow::onloadeddata): (WebCore::DOMWindow::setOnloadeddata): (WebCore::DOMWindow::onloadedmetadata): (WebCore::DOMWindow::setOnloadedmetadata): (WebCore::DOMWindow::onpause): (WebCore::DOMWindow::setOnpause): (WebCore::DOMWindow::onplay): (WebCore::DOMWindow::setOnplay): (WebCore::DOMWindow::onplaying): (WebCore::DOMWindow::setOnplaying): (WebCore::DOMWindow::onratechange): (WebCore::DOMWindow::setOnratechange): (WebCore::DOMWindow::onseeked): (WebCore::DOMWindow::setOnseeked): (WebCore::DOMWindow::onseeking): (WebCore::DOMWindow::setOnseeking): (WebCore::DOMWindow::ontimeupdate): (WebCore::DOMWindow::setOntimeupdate): (WebCore::DOMWindow::onvolumechange): (WebCore::DOMWindow::setOnvolumechange): (WebCore::DOMWindow::onwaiting): (WebCore::DOMWindow::setOnwaiting): (WebCore::DOMWindow::onloadstart): (WebCore::DOMWindow::setOnloadstart): (WebCore::DOMWindow::onprogress): (WebCore::DOMWindow::setOnprogress): (WebCore::DOMWindow::onstalled): (WebCore::DOMWindow::setOnstalled): (WebCore::DOMWindow::onsuspend): (WebCore::DOMWindow::setOnsuspend):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

2009-05-31 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Part of ​https://bugs.webkit.org/show_bug.cgi?id=26100
Add missing event handler properties to the DOMWindow

Add missing oncanplay, oncanplaythrough, ondurationchange, onemptied,
onended, onloadeddata, onloadedmetadata, onpause, onplay, onplaying,
onratechange, onseeked, onseeking, ontimeupdate, onvolumechange,
onwaiting, onloadstart, onprogress, onstalled, onsuspend, ondrag,
ondragend, ondragenter, ondragleave, ondragover, ondragstart and
ondrop event handlers to the DOMWindow.

  • fast/dom/Window/window-properties-expected.txt:
5:20 PM Changeset in webkit [44301] by weinig@apple.com
  • 8 edits in trunk

WebCore:

2009-05-31 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Part of ​https://bugs.webkit.org/show_bug.cgi?id=26100
Add missing event handler properties to the DOMWindow

Add missing onstorage event handler to the DOMWindow.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::onstorage): (WebCore::DOMWindow::setOnstorage):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

2009-05-31 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Part of ​https://bugs.webkit.org/show_bug.cgi?id=26100
Add missing event handler properties to the DOMWindow

Add missing onstorage event handler to the DOMWindow.

  • fast/dom/Window/window-properties-expected.txt:
  • storage/domstorage/window-attributes-exist-expected.txt:
  • storage/domstorage/window-attributes-exist.html:
4:47 PM Changeset in webkit [44300] by weinig@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

2009-05-31 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Mark Rowe.

Remove duplicate file. The version of window-properties-expected.txt in the
platform/mac-leopard was identical to the one in the normal spot.

  • platform/mac-leopard/fast/dom/Window/window-properties-expected.txt: Removed.
4:12 PM Changeset in webkit [44299] by krit@webkit.org
  • 41 edits in trunk/WebCore

2009-05-31 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

WebKit needs cross-platform filter system
​https://bugs.webkit.org/show_bug.cgi?id=19991

Make use of the new filter system in WebCore for SVG. Deleted Mac bindings
and replace it by a platform independent code. Calculation of subRegions
is missing but needed for a first filter effect.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/Filter.h: (WebCore::Filter::~Filter): (WebCore::Filter::setSourceImage):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent):
  • svg/FilterBuilder.h: (WebCore::FilterBuilder::lastEffect):
  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::SVGFEBlendElement): (WebCore::SVGFEBlendElement::build):
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement): (WebCore::SVGFEColorMatrixElement::build):
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement): (WebCore::SVGFEComponentTransferElement::build):
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::SVGFECompositeElement): (WebCore::SVGFECompositeElement::build):
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement): (WebCore::SVGFEDiffuseLightingElement::build):
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::SVGFEDisplacementMapElement): (WebCore::SVGFEDisplacementMapElement::build):
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::SVGFEFloodElement): (WebCore::SVGFEFloodElement::build):
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement): (WebCore::SVGFEGaussianBlurElement::build):
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::SVGFEImageElement): (WebCore::SVGFEImageElement::notifyFinished): (WebCore::SVGFEImageElement::build):
  • svg/SVGFEImageElement.h:
  • svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::SVGFEMergeElement): (WebCore::SVGFEMergeElement::build):
  • svg/SVGFEMergeElement.h:
  • svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::SVGFEOffsetElement): (WebCore::SVGFEOffsetElement::build):
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::SVGFESpecularLightingElement): (WebCore::SVGFESpecularLightingElement::build):
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::SVGFETileElement): (WebCore::SVGFETileElement::build):
  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement): (WebCore::SVGFETurbulenceElement::build):
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::canvasResource):
  • svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
  • svg/SVGFilterPrimitiveStandardAttributes.h: (WebCore::SVGFilterPrimitiveStandardAttributes::contextElement):
  • svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::SVGResourceFilter): (WebCore::SVGResourceFilter::addFilterEffect): (WebCore::SVGResourceFilter::filterBBoxForItemBBox): (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter): (WebCore::SVGResourceFilter::externalRepresentation):
  • svg/graphics/SVGResourceFilter.h: (WebCore::SVGResourceFilter::filterBoundingBox): (WebCore::SVGResourceFilter::setFilterBoundingBox): (WebCore::SVGResourceFilter::itemBoundingBox): (WebCore::SVGResourceFilter::setItemBoundingBox): (WebCore::SVGResourceFilter::builder):
3:24 PM Changeset in webkit [44298] by weinig@apple.com
  • 8 edits in trunk

WebCore:

2009-05-30 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=26110
Update online/offline events to match the current spec.

  • Also adds window.ononline and window.onoffline event handler properties.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::onoffline): (WebCore::DOMWindow::setOnoffline): (WebCore::DOMWindow::ononline): (WebCore::DOMWindow::setOnonline):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • page/Page.cpp: (WebCore::networkStateChanged):

LayoutTests:

2009-05-30 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=26110
Update online/offline events to match the current spec.

  • Also adds window.ononline and window.onoffline event handler properties.
  • fast/dom/Window/window-properties-expected.txt:
  • platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
11:22 AM Changeset in webkit [44297] by krit@webkit.org
  • 6 edits in trunk/WebCore

2009-05-31 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

WebKit needs cross-platform filter system
​https://bugs.webkit.org/show_bug.cgi?id=19991

Adding 'in1' attribute support for <feFlood>, as specified in SVG 1.1.
This change helps creating test cases, once filters are activated.

  • svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::SVGFEFloodElement): (WebCore::SVGFEFloodElement::parseMappedAttribute): (WebCore::SVGFEFloodElement::build):
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEFloodElement.idl:
  • svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::FEFlood): (WebCore::FEFlood::create):
  • svg/graphics/filters/SVGFEFlood.h:
10:34 AM Changeset in webkit [44296] by krit@webkit.org
  • 41 edits
    3 adds
    2 deletes in trunk/WebCore

2009-05-31 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

WebKit needs cross-platform filter system
​https://bugs.webkit.org/show_bug.cgi?id=19991

Replace all occurrences of SVGResourceFilter by Filter. This is the last
step for a SVG independent filter system. Every other part of WebCore can
use the filter system by creating a new Filter object.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):
  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::apply):
  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/Filter.h: Added. (WebCore::Filter::setSourceImage): (WebCore::Filter::sourceImage):
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::apply):
  • platform/graphics/filters/SourceAlpha.h:
  • platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::apply):
  • platform/graphics/filters/SourceGraphic.h:
  • svg/Filter.cpp: Removed.
  • svg/Filter.h: Removed.
  • svg/graphics/filters/SVGFEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::apply):
  • svg/graphics/filters/SVGFEConvolveMatrix.h:
  • svg/graphics/filters/SVGFEDiffuseLighting.cpp: (WebCore::FEDiffuseLighting::apply):
  • svg/graphics/filters/SVGFEDiffuseLighting.h:
  • svg/graphics/filters/SVGFEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply):
  • svg/graphics/filters/SVGFEDisplacementMap.h:
  • svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::apply):
  • svg/graphics/filters/SVGFEFlood.h:
  • svg/graphics/filters/SVGFEGaussianBlur.cpp: (WebCore::FEGaussianBlur::apply):
  • svg/graphics/filters/SVGFEGaussianBlur.h:
  • svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::apply):
  • svg/graphics/filters/SVGFEImage.h:
  • svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::apply):
  • svg/graphics/filters/SVGFEMerge.h:
  • svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply):
  • svg/graphics/filters/SVGFEMorphology.h:
  • svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
  • svg/graphics/filters/SVGFEOffset.h:
  • svg/graphics/filters/SVGFESpecularLighting.cpp: (WebCore::FESpecularLighting::apply):
  • svg/graphics/filters/SVGFESpecularLighting.h:
  • svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):
  • svg/graphics/filters/SVGFETile.h:
  • svg/graphics/filters/SVGFETurbulence.cpp: (WebCore::FETurbulence::apply):
  • svg/graphics/filters/SVGFETurbulence.h:
  • svg/graphics/filters/SVGFilter.cpp: Added. (WebCore::SVGFilter::SVGFilter): (WebCore::SVGFilter::calculateEffectSubRegion): (WebCore::SVGFilter::create):
  • svg/graphics/filters/SVGFilter.h: Added.

May 30, 2009:

8:26 PM Changeset in webkit [44295] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Build fix for platforms without plugins support.

7:32 PM Changeset in webkit [44294] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=25979

Fix regression, local WML files won't load anymore, as the mimetype isn't correctly detected.
Bug filed at <rdar://problem/6917571> to cover this CFNetwork limitation.

5:58 PM Changeset in webkit [44293] by weinig@apple.com
  • 17 edits in trunk

WebCore:

2009-05-29 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=26091
Make storage events match the current spec.

  • Storage event listeners are added to the window.
  • Storage events are dispatched to the window.

Updated existing tests.

  • dom/Document.cpp: (WebCore::Document::dispatchWindowEvent):
  • dom/Document.h:
  • dom/Node.cpp:
  • dom/Node.h:
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute):
  • storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::dispatchStorageEvent):
  • storage/SessionStorageArea.cpp: (WebCore::SessionStorageArea::dispatchStorageEvent):

LayoutTests:

2009-05-29 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=26091
Make storage events match the current spec.

  • Storage event listeners are added to the window.
  • Storage events are dispatched to the window.
  • storage/domstorage/localstorage/iframe-events.html:
  • storage/domstorage/localstorage/index-get-and-set.html:
  • storage/domstorage/localstorage/resources/iframe-events-second.html:
  • storage/domstorage/localstorage/simple-events.html:
  • storage/domstorage/sessionstorage/iframe-events.html:
  • storage/domstorage/sessionstorage/index-get-and-set.html:
  • storage/domstorage/sessionstorage/resources/iframe-events-second.html:
  • storage/domstorage/sessionstorage/simple-events.html:
4:27 PM Changeset in webkit [44292] by Darin Adler
  • 7 edits in trunk

WebCore:

2009-05-30 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

Bug 26097: REGRESSION (r44283): Tab key doesn't work when focus is on a <select> element

Test: fast/forms/focus-control-to-page.html

  • dom/SelectElement.h: Made destructor protected. Tweaked a bit.
  • html/HTMLSelectElement.cpp: Removed unneeded includes. (WebCore::HTMLSelectElement::remove): Removed unneeded range check of the result of optionToListIndex. (WebCore::HTMLSelectElement::parseMappedAttribute): Removed code to set the unused attribute, m_minwidth. (WebCore::HTMLSelectElement::defaultEventHandler): The actual bug fix. Call through to the base class defaultEventHandler if the event hasn't been handled yet.
  • html/HTMLSelectElement.h: Removed unneeded includes. Made a lot more functions private. Removed unused minWidth function and m_minwidth data member.

LayoutTests:

2009-05-30 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

Bug 26097: REGRESSION (r44283): Tab key doesn't work when focus is on a <select> element

  • fast/forms/focus-control-to-page-expected.txt: Updated.
  • fast/forms/focus-control-to-page.html: Added test of <select>, <textarea>, and <input type="password">, and made sure we can tab both in and out of each type.
4:20 PM Changeset in webkit [44291] by bfulgham@webkit.org
  • 2 edits
    1 move
    1 delete in trunk/WebCore

2009-05-30 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Holger Freyther.

The two KeyboardCodes.h files are basically identical and the
qt one is properly #ifdef-ed for different win32 systems. Share
them between Qt and Gtk implementations.

  • GNUmakefile.am:
  • platform/KeyboardCodes.h: Copied from WebCore/platform/qt/KeyboardCodes.h.
  • platform/gtk/KeyboardCodes.h: Removed.
  • platform/qt/KeyboardCodes.h: Removed.
3:58 PM Changeset in webkit [44290] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

Add JSLock to -[WebScriptCallFrame scopeChain]

Reviewed by Darin Adler.

In Debug builds of WebKit, Dashcode launching MobileSafari could
cause the ASSERT(JSLock::lockCount() > 0) assertion to fire in
JSC::Heap::heapAllocate() because the JSLock wasn't taken.

  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]): Take JSLock before calling into JavaScriptCore.
3:38 PM Changeset in webkit [44289] by bfulgham@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2009-05-30 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Sam Weinig.

LocalStorage and SessionStorage's implicit setters do not correctly
handle null. The custom JS bindings should convert to strings
unconditionally and not try to handle null specially.
​https://bugs.webkit.org/show_bug.cgi?id=25970

  • storage/domstorage/localstorage/string-conversion-expected.txt: Added.
  • storage/domstorage/localstorage/string-conversion.html: Added.
  • storage/domstorage/sessionstorage/string-conversion-expected.txt: Added.
  • storage/domstorage/sessionstorage/string-conversion.html: Added.
3:38 PM Changeset in webkit [44288] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-05-30 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Sam Weinig.

LocalStorage and SessionStorage's implicit setters do not correctly
handle null. The custom JS bindings should convert to strings
unconditionally and not try to handle null specially.
​https://bugs.webkit.org/show_bug.cgi?id=25970

Tests: storage/domstorage/localstorage/string-conversion.html

storage/domstorage/sessionstorage/string-conversion.html

  • bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::customPut):
1:35 PM Changeset in webkit [44287] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6935192> REGRESSION (Safari 3-TOT): Scroll bars in key window draw as inactive if the WebView is not active

Test: platform/mac/scrollbars/key-window-not-first-responder.html

  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint): Use the window's key state instead of the WebView's first responder state to switch between active and inactive state.

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/6935192> REGRESSION (Safari 3-TOT): Scroll bars in key window draw as inactive if the WebView is not active
  • platform/mac/scrollbars/key-window-not-first-responder-expected.checksum: Added.
  • platform/mac/scrollbars/key-window-not-first-responder-expected.png: Added.
  • platform/mac/scrollbars/key-window-not-first-responder-expected.txt: Added.
  • platform/mac/scrollbars/key-window-not-first-responder.html: Added.
1:27 PM Changeset in webkit [44286] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2009-05-30 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

<rdar://problem/6935193> REGRESSION (r42734): Celtic Kane JavaScript benchmark does not run:
"Maximum call stack size exceeded"

  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncToString): Use the same recursion limit as the other recursion checks. We need a limit of at least 100 to run the benchmark above. (JSC::arrayProtoFuncToLocaleString): Ditto. (JSC::arrayProtoFuncJoin): Ditto.
10:50 AM Changeset in webkit [44285] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Simon Fraser.

Test: fast/backgrounds/body-generated-image-propagated-to-root.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Check if this is the root element painting a background layer propagated from the body, and if it is, use the body's renderer as the client to StyleImage::image().

LayoutTests:

Reviewed by Simon Fraser.

  • fast/backgrounds/body-generated-image-propagated-to-root.html: Added.
  • platform/mac/fast/backgrounds/body-generated-image-propagated-to-root-expected.checksum: Added.
  • platform/mac/fast/backgrounds/body-generated-image-propagated-to-root-expected.png: Added.
  • platform/mac/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt: Added.
9:50 AM Changeset in webkit [44284] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-05-30 Holger Hans Peter Freyther <​zecke@selfish.org>

Unreviewed build fix for AXObjectCache.

For !HAVE(ACCESSIBILITY) postNotification was defined twice. Move
that into the #ifdef.

  • accessibility/AXObjectCache.cpp:

May 29, 2009:

6:38 PM Changeset in webkit [44283] by Nikolas Zimmermann
  • 22 edits
    6 adds in trunk

Reviewed by George Staikos.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=26072

Add support for the last missing WML element: <select>. This patch adds WMLSelectElement, providing
the same functionality HTMLSelectElement has. The WML specific features will follow soon.

Add simple testcase covering <select> element rendering: fast/wml/select.wml

3:55 PM Changeset in webkit [44282] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-29 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

Fixed compile warning when comparing the different navigation types

  • webkit/webkitwebnavigationaction.cpp: (webkit_web_navigation_action_class_init):
3:42 PM Changeset in webkit [44281] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-05-29 David Levin <​levin@chromium.org>

Reviewed by NOBODY (build fix for windows).

​http://trac.webkit.org/changeset/44279 left in a "Vector<WCHAR> localeNameBuf"
that it was trying to replace. Resulting in this variable being defined twice (and
the second time incorrectly).

  • platform/win/Language.cpp: (WebCore::localeInfo):
3:02 PM Changeset in webkit [44280] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-05-29 Takeshi Yoshino <​tyoshino@google.com>

Reviewed by Darin Alder.

​https://bugs.webkit.org/show_bug.cgi?id=26018

Fix behavior of the Element View of the Web Inspector for double
clicking the element outline tree.

Double clicking the element outline tree should
1) on attribute: enter attribute editing mode
2) on text: enter text editing mode
3) otherwise: change root node to the parent element of double clicked

element.

Now, 3) is broken. For example, clicking <html> clears the element
outline view.

rootDOMNode should be updated to this.representedObject.parentNode, not
this.parent.representedObject which is parent inside the element
outline tree itself.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.ondblclick):
3:02 PM Changeset in webkit [44279] by levin@chromium.org
  • 9 edits in trunk/WebCore

2009-05-29 David Moore <​davemoore@google.com>

Reviewed by Darin Alder.

​https://bugs.webkit.org/show_bug.cgi?id=26001
Change many of the uses of String::adopt() to String::createUninitialized().
This allows those strings to use an inlined buffer for their characters.

  • dom/StyleElement.cpp: Loop over nodes to precompute length of string and then write the characters into the allocated inline buffer (WebCore::StyleElement::process):
  • dom/Text.cpp: Loop over nodes to precompute length of string and then write the characters into the allocated inline buffer (WebCore::Text::wholeText): (WebCore::Text::rendererIsNeeded): (WebCore::Text::createRenderer): (WebCore::Text::createWithLengthLimit): (WebCore::Text::formatForDebugger):
  • platform/text/String.cpp: (WebCore::String::append): (WebCore::String::insert): (WebCore::String::truncate): (WebCore::String::remove):
  • platform/text/StringBuilder.cpp: (WebCore::StringBuilder::toString):
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::lower): (WebCore::StringImpl::upper): (WebCore::StringImpl::secure): (WebCore::StringImpl::foldCase): (WebCore::StringImpl::replace):
  • platform/text/TextCodecLatin1.cpp: (WebCore::TextCodecLatin1::decode):
  • platform/text/TextCodecUserDefined.cpp: (WebCore::TextCodecUserDefined::decode):
  • platform/win/Language.cpp: (WebCore::localeInfo):
3:02 PM Changeset in webkit [44278] by levin@chromium.org
  • 3 edits
    4 adds in trunk

WebCore:

2009-05-29 Takeshi Yoshino <​tyoshino@google.com>

Reviewed by Darin Alder.

Bug 25911: Apply href in base elements to anchors shown on the source viewer
​https://bugs.webkit.org/show_bug.cgi?id=25911

In rendering HTML sources, parse base elements to apply the base URI to
anchors shown on the source viewer.

This issue was originally reported to the Chromium issue tracker.
​http://code.google.com/p/chromium/issues/detail?id=2418

Test: fast/frames/viewsource-link-on-href-value.html

  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):

LayoutTests:

2009-05-29 Takeshi Yoshino <​tyoshino@google.com>

Reviewed by Darin Alder.

Bug 25911: Apply href in base elements to anchors shown on the source viewer
​https://bugs.webkit.org/show_bug.cgi?id=25911

In rendering HTML sources, parse base elements to apply the base URI to
anchors shown on the source viewer.

Add tests to verify this change.

This issue was originally reported to the Chromium issue tracker.
​http://code.google.com/p/chromium/issues/detail?id=2418

  • fast/frames/resources/viewsource-frame-3.html: Added.
  • fast/frames/resources/viewsource-frame-4.html: Added.
  • fast/frames/viewsource-link-on-href-value-expected.txt: Added.
  • fast/frames/viewsource-link-on-href-value.html: Added.
3:02 PM Changeset in webkit [44277] by levin@chromium.org
  • 3 edits
    2 adds in trunk

WebCore:

2009-05-29 Rob Buis <​rwlbuis@gmail.com>

Reviewed by David Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=22429
document.styleSheets collection ignores media=presentation

Ensure that stylesheets though <link> show up in document.styleSheets regardless of media attribute.

Test: fast/css/sheet-collection-link.html

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):

LayoutTests:

2009-05-29 Rob Buis <​rwlbuis@gmail.com>

Reviewed by David Hyatt.

Testcase for:
​https://bugs.webkit.org/show_bug.cgi?id=22429
document.styleSheets collection ignores media=presentation

  • fast/css/sheet-collection-link.html: Added.
  • fast/css/sheet-collection-link-expected.txt: Added.
3:02 PM Changeset in webkit [44276] by levin@chromium.org
  • 4 edits in trunk/WebCore

2009-05-29 Itai Danan <​idanan@chromium.org>

Reviewed by Jon Honeycutt.

Bug 24791: Should have a preference to disable auto scrolling
​https://bugs.webkit.org/show_bug.cgi?id=24791

To understand why this is required see the discussion in
issue 24722 (​https://bugs.webkit.org/show_bug.cgi?id=24722).

The code review was done in ​https://bugs.webkit.org/show_bug.cgi?id=21794.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Use autoscroll behavior flag to determine if autoscroll needs to be released on this event. (WebCore::EventHandler::handleMouseReleaseEvent): Use autoscroll behavior flag to determine if autoscroll needs to be released on this event (reverse logic of for Press event).
  • page/Settings.cpp: (WebCore::Settings::Settings): Initialize autoscroll behavior setting.
  • page/Settings.h: (WebCore::Settings::setUsesStickyPanScroll): Autoscroll behavior setting setter. (WebCore::Settings::usesStickyPanScroll): Autoscroll behavior setting getter.
2:58 PM Changeset in webkit [44275] by jianli@chromium.org
  • 3 edits
    3 adds in trunk

WebCore:

2009-05-29 Jian Li <​jianli@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=26069
Fix a crash in custom V8 bindings code for XMLHttpRequest.

Test: fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self.html

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-29 Jian Li <​jianli@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=26069
Test for the above bug.

  • fast/xmlhttprequest/resources/xmlhttprequest-open-after-iframe-onload-remove-self-child.html: Added.
  • fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self.html: Added.
2:38 PM Changeset in webkit [44274] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-05-29 David Levin <​levin@chromium.org>

Reviewed by Darin Adler.

Bug 26074: SQLTransaction::executeSQL does an unnecessary call to String::copy.
​https://bugs.webkit.org/show_bug.cgi?id=26074

The constructor for SQLStatement already does a copy for this string.

  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::executeSQL):
1:53 PM Changeset in webkit [44273] by Adam Roben
  • 2 edits in trunk/WebKit/win

Implement WebFrame::startDownload

Fixes the WebKit side of Bug 25729: Alt-clicking a link doesn't start
a download <​https://bugs.webkit.org/show_bug.cgi?id=25729>. Fixing
this all the way will require a change in Safari.

Reviewed by Darin Adler.

  • WebFrame.cpp: (WebFrame::startDownload): Call through to WebView::downloadURL.
1:51 PM Changeset in webkit [44272] by Darin Adler
  • 3 edits in trunk/WebCore

2009-05-29 Darin Adler <Darin Adler>

Fix build; the new Cairo code compiled on Windows only.

  • platform/graphics/gtk/FontPlatformData.h: Added syntheticBold and syntheticOblique functions as in the Windows version to make it easier to use this cross-platform. Later we can make data members private as in the Windows version.
  • platform/graphics/mac/FontPlatformData.h: Ditto.
1:48 PM Changeset in webkit [44271] by Adam Roben
  • 4 edits in trunk/WebKit/win

Move WebContextMenuClient's downloading code to WebView

This will allow other code to trigger downloads using this code, and
matches Mac.

Reviewed by Darin Adler.

  • WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::downloadURL): Moved code from here...
  • WebView.cpp: (WebView::downloadURL): ...to here. Also tightened up the code a little bit and removed an unnecessary LOG_ERROR.
  • WebView.h: Added downloadURL.
1:41 PM Changeset in webkit [44270] by Adam Roben
  • 7 edits in trunk

Roll out r44269

It contained some changes I didn't mean to have landed, and squashed
some distinct patches into a single commit.

1:33 PM Changeset in webkit [44269] by bfulgham@webkit.org
  • 7 edits in trunk

WebCore:

2009-05-29 Adam Roben <Adam Roben>

Make sure PlatformMouseEvent::modifierFlags contains MK_ALT when the
Alt key is pressed

First part of fixing Bug 25729: Alt-clicking a link doesn't start a
download
<​https://bugs.webkit.org/show_bug.cgi?id=25729>

Reviewed by Darin Adler.

No test possible.

  • platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Add MK_ALT to the modifier flags when the Alt key is pressed.

WebKit/win:

2009-05-29 Adam Roben <Adam Roben>

Implement WebFrame::startDownload

Fixes Bug 25729: Alt-clicking a link doesn't start a download
<​https://bugs.webkit.org/show_bug.cgi?id=25729>

Reviewed by Darin Adler.

  • WebFrame.cpp: (WebFrame::startDownload): Call through to WebView::downloadURL.
12:53 PM Changeset in webkit [44268] by bfulgham@webkit.org
  • 6 edits in trunk/WebCore

2009-05-29 Alexander Macdonald <​alexmac@adobe.com>

Reviewed by Darin Adler.

Added support for synthetic bold/oblique font rendering
on platforms that use cairo.

  • platform/graphics/SimpleFontData.h:
  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::SimpleFontData::platformInit):
11:49 AM Changeset in webkit [44267] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit/win

2009-05-29 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Darin Adler.

Correct Windows Cairo build error caused by @r42767.
​http://bugs.webkit.org/show_bug.cgi?id=26082.

  • WebError.cpp: (WebError::localizedDescription):
11:32 AM Changeset in webkit [44266] by Chris Fleizach
  • 13 edits in trunk/WebCore

Bug 26024: AX: possible to fail assertion because AXPostNotification calls accessibilityIsIgnored
​https://bugs.webkit.org/show_bug.cgi?id=26024

9:55 AM Changeset in webkit [44265] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-05-29 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Adam Roben.

Build fix for Windows Cairo target.
​https://bugs.webkit.org/show_bug.cgi?id=25972

Compiler mistakenly selects SMILTime min/max instead of STL version,
resulting in a build error. This change makes the meaning of the
min/max explicit and avoids the problem.

  • html/TimeRanges.h: (WebCore::TimeRanges::Range::unionWithOverlappingOrContiguousRange):
8:56 AM Changeset in webkit [44264] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-29 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=26075
[GTK] Refactor key scrolling code

After the scrolling changes in r44177 we can now use the
FrameView::scroll method like the other ports, keeping the magic
constants for the scrolling amounts inside WebCore proper.

  • webkit/webkitwebview.cpp: (webkit_web_view_real_move_cursor):
7:48 AM Changeset in webkit [44263] by kov@webkit.org
  • 12 edits
    2 adds in trunk

2009-05-29 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Jan Alonzo.

Add a test-case for our HTTP backend, currently checking the
ref-counting of the SoupMessage.

  • GNUmakefile.am:

WebCore:

2009-05-29 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Jan Alonzo.

Make SoupMessage a member of ResourceRequest, instead of creating
it in startHttp. Implement updating of ResourceRequest from
SoupMessage, and vice versa.

  • GNUmakefile.am:
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::~ResourceHandle): (WebCore::gotHeadersCallback): (WebCore::ResourceHandle::startHttp):
  • platform/network/soup/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::~ResourceRequest):
  • platform/network/soup/ResourceRequestSoup.cpp: Added. (WTF::SoupURI): (WebCore::ResourceRequest::soupMessage): (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::doUpdateResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest):

WebKit/gtk:

2009-05-29 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Jan Alonzo.

Make NetworkRequest carry a reference of the SoupMessage used by
ResourceRequest, and use that to create new ResourceRequests where
needed, so that no information is lost while passing around
NetworkRequest objects.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebKit::FrameLoaderClient::startDownload):
  • webkit/webkitdownload.cpp: (webkit_download_start):
  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_finalize): (webkit_network_request_new_with_core_request): (webkit_network_request_new): (webkit_network_request_get_message):
  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_load_request):
4:10 AM Changeset in webkit [44262] by oliver@apple.com
  • 2 edits in trunk/LayoutTests

Fix error in test case i accidentally introduced.

May 28, 2009:

5:45 PM Changeset in webkit [44261] by mrowe@apple.com
  • 4 edits in branches/WWDC-2009-branch

Versioning.

5:40 PM Changeset in webkit [44260] by mrowe@apple.com
  • 1 copy in tags/Safari-6530.14

New tag.

5:34 PM Changeset in webkit [44259] by mrowe@apple.com
  • 7 edits
    4 adds in branches/WWDC-2009-branch

Merge r44218.

5:34 PM Changeset in webkit [44258] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebCore

Merge r44241.

5:34 PM Changeset in webkit [44257] by mrowe@apple.com
  • 4 edits in branches/WWDC-2009-branch

Merge r44216.

4:44 PM Changeset in webkit [44256] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-05-28 Dmitry Titov <​dimich@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=26068
V8: Remove the remaining b8::Locker usage in worker code.
This completes the fix for ​https://bugs.webkit.org/show_bug.cgi?id=25944,
since the patches for enabling timers and that bug have "crossed in the queue".
Existing LayoutTests/fast/workers/worker-timeout.html covers this fix (will start work in Chromium).

  • bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
3:38 PM Changeset in webkit [44255] by mrowe@apple.com
  • 4 edits in trunk/WebKit/mac

Build fix. Move off a deprecated NSFileManager method.

Rubber-stamped by Dan Bernstein.

  • Misc/WebNSFileManagerExtras.h:
  • Misc/WebNSFileManagerExtras.m:

(-[NSFileManager destinationOfSymbolicLinkAtPath:error:]): Implement a new-in-Leopard method for Tiger to use.
(-[NSFileManager attributesOfItemAtPath:error:]): Ditto.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _initWithPath:]): Use the new non-deprecated methods.

3:18 PM Changeset in webkit [44254] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-05-28 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Simplify the Accept-Encoding header we are sending out, for it
seems some servers do not enjoy parsing the full, explicit
version.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):
3:10 PM Changeset in webkit [44253] by krit@webkit.org
  • 186 edits in trunk

2009-05-28 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Added a new build flag --filters. This replaces the old --svg-filters and enables
other parts of WebKit to use some basic filters of platform/graphics/filters if needed.
This patch also fixes a bug in dom/DOMImplementation.cpp where we used SVG_FILTER. This flag
doesn't exist and was replaced by FILTERS as well as all SVG_FILTERS occurrences.
Filters are not working yet. This patch is just a preperation. Filters are deactivated by
default.

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • bindings/objc/DOM.mm: (WebCore::createElementClassMap):
  • dom/DOMImplementation.cpp: (WebCore::isSVG10Feature): (WebCore::isSVG11Feature):
  • page/DOMWindow.idl:
  • platform/graphics/filters/FEBlend.cpp:
  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp:
  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp:
  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.cpp:
  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FilterEffect.cpp:
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/SourceAlpha.cpp:
  • platform/graphics/filters/SourceAlpha.h:
  • platform/graphics/filters/SourceGraphic.cpp:
  • platform/graphics/filters/SourceGraphic.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::selfWillPaint):
  • rendering/RenderSVGModelObject.cpp:
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::selfWillPaint):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
  • svg/Filter.cpp:
  • svg/Filter.h:
  • svg/FilterBuilder.cpp:
  • svg/FilterBuilder.h:
  • svg/SVGComponentTransferFunctionElement.cpp:
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGComponentTransferFunctionElement.idl:
  • svg/SVGFEBlendElement.cpp:
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEBlendElement.idl:
  • svg/SVGFEColorMatrixElement.cpp:
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEColorMatrixElement.idl:
  • svg/SVGFEComponentTransferElement.cpp:
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFEComponentTransferElement.idl:
  • svg/SVGFECompositeElement.cpp:
  • svg/SVGFECompositeElement.h:
  • svg/SVGFECompositeElement.idl:
  • svg/SVGFEDiffuseLightingElement.cpp:
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDiffuseLightingElement.idl:
  • svg/SVGFEDisplacementMapElement.cpp:
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEDisplacementMapElement.idl:
  • svg/SVGFEDistantLightElement.cpp:
  • svg/SVGFEDistantLightElement.h:
  • svg/SVGFEDistantLightElement.idl:
  • svg/SVGFEFloodElement.cpp:
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEFloodElement.idl:
  • svg/SVGFEFuncAElement.cpp:
  • svg/SVGFEFuncAElement.h:
  • svg/SVGFEFuncAElement.idl:
  • svg/SVGFEFuncBElement.cpp:
  • svg/SVGFEFuncBElement.h:
  • svg/SVGFEFuncBElement.idl:
  • svg/SVGFEFuncGElement.cpp:
  • svg/SVGFEFuncGElement.h:
  • svg/SVGFEFuncGElement.idl:
  • svg/SVGFEFuncRElement.cpp:
  • svg/SVGFEFuncRElement.h:
  • svg/SVGFEFuncRElement.idl:
  • svg/SVGFEGaussianBlurElement.cpp:
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEGaussianBlurElement.idl:
  • svg/SVGFEImageElement.cpp:
  • svg/SVGFEImageElement.h:
  • svg/SVGFEImageElement.idl:
  • svg/SVGFELightElement.cpp:
  • svg/SVGFELightElement.h:
  • svg/SVGFEMergeElement.cpp:
  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMergeElement.idl:
  • svg/SVGFEMergeNodeElement.cpp:
  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEMergeNodeElement.idl:
  • svg/SVGFEOffsetElement.cpp:
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFEOffsetElement.idl:
  • svg/SVGFEPointLightElement.cpp:
  • svg/SVGFEPointLightElement.h:
  • svg/SVGFEPointLightElement.idl:
  • svg/SVGFESpecularLightingElement.cpp:
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFESpecularLightingElement.idl:
  • svg/SVGFESpotLightElement.cpp:
  • svg/SVGFESpotLightElement.h:
  • svg/SVGFESpotLightElement.idl:
  • svg/SVGFETileElement.cpp:
  • svg/SVGFETileElement.h:
  • svg/SVGFETileElement.idl:
  • svg/SVGFETurbulenceElement.cpp:
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFETurbulenceElement.idl:
  • svg/SVGFilterElement.cpp:
  • svg/SVGFilterElement.h:
  • svg/SVGFilterElement.idl:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/graphics/SVGResourceFilter.cpp:
  • svg/graphics/SVGResourceFilter.h:
  • svg/graphics/cairo/SVGResourceFilterCairo.cpp:
  • svg/graphics/cg/SVGResourceFilterCg.cpp:
  • svg/graphics/cg/SVGResourceFilterCg.mm:
  • svg/graphics/filters/SVGDistantLightSource.h:
  • svg/graphics/filters/SVGFEConvolveMatrix.cpp:
  • svg/graphics/filters/SVGFEConvolveMatrix.h:
  • svg/graphics/filters/SVGFEDiffuseLighting.cpp:
  • svg/graphics/filters/SVGFEDiffuseLighting.h:
  • svg/graphics/filters/SVGFEDisplacementMap.cpp:
  • svg/graphics/filters/SVGFEDisplacementMap.h:
  • svg/graphics/filters/SVGFEFlood.cpp:
  • svg/graphics/filters/SVGFEFlood.h:
  • svg/graphics/filters/SVGFEGaussianBlur.cpp:
  • svg/graphics/filters/SVGFEGaussianBlur.h:
  • svg/graphics/filters/SVGFEImage.cpp:
  • svg/graphics/filters/SVGFEImage.h:
  • svg/graphics/filters/SVGFEMerge.cpp:
  • svg/graphics/filters/SVGFEMerge.h:
  • svg/graphics/filters/SVGFEMorphology.cpp:
  • svg/graphics/filters/SVGFEMorphology.h:
  • svg/graphics/filters/SVGFEOffset.cpp:
  • svg/graphics/filters/SVGFEOffset.h:
  • svg/graphics/filters/SVGFESpecularLighting.cpp:
  • svg/graphics/filters/SVGFESpecularLighting.h:
  • svg/graphics/filters/SVGFETile.cpp:
  • svg/graphics/filters/SVGFETile.h:
  • svg/graphics/filters/SVGFETurbulence.cpp:
  • svg/graphics/filters/SVGFETurbulence.h:
  • svg/graphics/filters/SVGFilterEffect.cpp:
  • svg/graphics/filters/SVGFilterEffect.h:
  • svg/graphics/filters/SVGLightSource.cpp:
  • svg/graphics/filters/SVGLightSource.h:
  • svg/graphics/filters/SVGPointLightSource.h:
  • svg/graphics/filters/SVGSpotLightSource.h:
  • svg/graphics/filters/cg/SVGFEHelpersCg.h:
  • svg/graphics/filters/cg/SVGFEHelpersCg.mm:
  • svg/graphics/filters/cg/SVGFilterEffectCg.mm:
  • svg/graphics/filters/cg/WKArithmeticFilter.h:
  • svg/graphics/filters/cg/WKArithmeticFilter.m:
  • svg/graphics/filters/cg/WKComponentMergeFilter.h:
  • svg/graphics/filters/cg/WKComponentMergeFilter.m:
  • svg/graphics/filters/cg/WKDiffuseLightingFilter.h:
  • svg/graphics/filters/cg/WKDiffuseLightingFilter.m:
  • svg/graphics/filters/cg/WKDiscreteTransferFilter.h:
  • svg/graphics/filters/cg/WKDiscreteTransferFilter.m:
  • svg/graphics/filters/cg/WKDisplacementMapFilter.h
  • svg/graphics/filters/cg/WKDisplacementMapFilter.m:
  • svg/graphics/filters/cg/WKDistantLightFilter.h:
  • svg/graphics/filters/cg/WKDistantLightFilter.m:
  • svg/graphics/filters/cg/WKGammaTransferFilter.h:
  • svg/graphics/filters/cg/WKGammaTransferFilter.m:
  • svg/graphics/filters/cg/WKIdentityTransferFilter.h:
  • svg/graphics/filters/cg/WKIdentityTransferFilter.m:
  • svg/graphics/filters/cg/WKLinearTransferFilter.h:
  • svg/graphics/filters/cg/WKLinearTransferFilter.m:
  • svg/graphics/filters/cg/WKNormalMapFilter.h:
  • svg/graphics/filters/cg/WKNormalMapFilter.m:
  • svg/graphics/filters/cg/WKPointLightFilter.h:
  • svg/graphics/filters/cg/WKPointLightFilter.m:
  • svg/graphics/filters/cg/WKSpecularLightingFilter.h:
  • svg/graphics/filters/cg/WKSpecularLightingFilter.m:
  • svg/graphics/filters/cg/WKSpotLightFilter.h:
  • svg/graphics/filters/cg/WKSpotLightFilter.m:
  • svg/graphics/filters/cg/WKTableTransferFilter.h:
  • svg/graphics/filters/cg/WKTableTransferFilter.m:
  • svg/graphics/mac/SVGResourceFilterPlatformDataMac.h:
  • svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm:
  • svg/graphics/qt/SVGResourceFilterQt.cpp:
  • svg/graphics/skia/SVGResourceFilterSkia.cpp:
  • svg/svgtags.in:

*WebKit/mac/
2009-05-28 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Added new build flag --filters. More details in WebCore/ChangeLog.

  • Configurations/FeatureDefines.xcconfig:

*.
2009-05-28 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Enable the new build flag --filters for Gtk. More details in WebCore/ChangeLog.

  • configure.ac:

*JavaScriptCore/
2009-05-28 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Added new build flag --filters for Mac. More details in WebCore/ChangeLog.

  • Configurations/FeatureDefines.xcconfig:

*WebKitTools
2009-05-28 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Added new build flag --filters. More details in WebCore/ChangeLog.

  • Scripts/build-webkit:
2:05 PM Changeset in webkit [44252] by brettw@chromium.org
  • 2 edits in trunk/WebCore

2009-05-28 Brett Wilson <​brettw@chromium.org>

Unreviewed, build fix.

​https://bugs.webkit.org/show_bug.cgi?id=26067

Add casts for scale function to make more explicit what is happening
and fix a compiler warning.

  • platform/graphics/IntSize.h: (WebCore::IntSize::scale):
1:56 PM Changeset in webkit [44251] by mrowe@apple.com
  • 2 edits in trunk/WebKit

Symlink WebKitPluginHost.app in to place if needed.

Rubber-stamped by Anders Carlsson.

  • WebKit.xcodeproj/project.pbxproj:
12:37 PM Changeset in webkit [44250] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.8

Tagging 1.1.8.

12:27 PM Changeset in webkit [44249] by weinig@apple.com
  • 4 edits in trunk/WebCore

2009-05-28 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Remove the returnValueSlot concept from JSDOMWindowBase. Now that windows
are not cleared on navigation it is no longer necessary.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData): (WebCore::JSDOMWindowBase::willRemoveFromWindowShell):
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::showModalDialog):
11:35 AM Changeset in webkit [44248] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-28 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=26048
navigation-policy-decision-requested documentation incomplete

Fix documentation for all policy decision request signals, to
mention that an actual decision is expected when you return TRUE,
meaning that you handled the signal.

  • webkit/webkitwebview.cpp: (webkit_web_view_class_init):
11:33 AM Changeset in webkit [44247] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-28 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Mention the implementation of the new AtkText methods.

  • NEWS:
11:20 AM Changeset in webkit [44246] by xan@webkit.org
  • 5 edits
    1 add in trunk

2009-05-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo and Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Add new test file for ATK.

  • GNUmakefile.am:

WebCore:

2009-05-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo and Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Implement atk_text_get_text_{at,after,before}_offset.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

WebKit/gtk:

2009-05-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo and Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

New test file for ATK functionality.

  • tests/testatk.c: Added. (bail_out): (test_get_text_function): (test_webkit_atk_get_text_at_offset): (main):
11:04 AM Changeset in webkit [44245] by Nikolas Zimmermann
  • 5 edits in trunk/WebCore

Rubber-stamped by Darin Adler.
Remove unnecessary destructor from InputElementData/OptionElementData.

10:50 AM Changeset in webkit [44244] by sfalken@apple.com
  • 3 edits in tags/Safari-6530.13.1/WebCore

Merge r44233.

10:49 AM Changeset in webkit [44243] by Nikolas Zimmermann
  • 9 edits in trunk/WebCore

Reviewed by Darin Adler.
Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=26062

Refactor code from all virtual methods in HTMLSelectElement (that are also needed for WMLSelectElement)
in the recently introduced SelectElement abstract base class. Follow the same design sheme that InputElement uses.

10:48 AM Changeset in webkit [44242] by kov@webkit.org
  • 2 edits in trunk

2009-05-28 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Fix webkitgtk_cleanfiles to clean gtk-doc-related files in the
correct directory, so that we pass make distcheck.

  • GNUmakefile.am:
10:46 AM Changeset in webkit [44241] by Adam Roben
  • 2 edits in trunk/WebCore

Don't try to use the new combobox parts on Vista in Classic mode

Fixes:
<rdar://problem/6929277> REGRESSION (r42289+r42350): Windows Classic
theme: drop down lists in Preferences get a line/square
<rdar://problem/6929298> REGRESSION (r42289): Windows Classic: drop
down lists are black with a circle on many sites

Reviewed by Steve Falkenburg.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintMenuList): Only use the new combobox parts when we have a theme (i.e., when we're not in Classic mode). When we don't have a theme, fall back to the pre-r42289 code.
10:36 AM Changeset in webkit [44240] by sfalken@apple.com
  • 1 copy in tags/Safari-6530.13.1

New tag.

10:35 AM Changeset in webkit [44239] by sfalken@apple.com
  • 1 delete in tags/Safari-6530.13.1

Delete incorrect tag.

10:34 AM Changeset in webkit [44238] by sfalken@apple.com
  • 1 copy in tags/Safari-6530.13.1

New tag.

10:29 AM Changeset in webkit [44237] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

2009-05-27 Peter Kasting <​pkasting@google.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=25659
Avoid calling frameCount() unnecessarily (which could lead to extra
GIF decoding).

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedDataIfNecessary):
9:58 AM Changeset in webkit [44236] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-28 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Document changes worth noting for 1.1.8.

  • NEWS:
9:55 AM Changeset in webkit [44235] by bfulgham@webkit.org
  • 16 edits
    6 adds in trunk

WebCore:

2009-05-28 Simon Fraser <Simon Fraser>

Reviewed by Oliver Hunt.


​https://bugs.webkit.org/show_bug.cgi?id=8736

Tests: fast/borders/border-radius-constraints.html

fast/borders/border-radius-split-inline.html


When the sum of the corner radii on a side exceed the length of the side,
reduce the radii according to CSS 3 rules.


Add RenderStyle::getBorderRadiiForRect() to fetch corner radii, applying
the constraints. Use that for painting borders, box-shadow, clipping replaced
elements

  • platform/graphics/IntSize.h: (WebCore::IntSize::scale): Add a scale method that scales by a float (using C rounding rules, like IntRect::scale()).
  • platform/graphics/Path.cpp: Make the QUARTER const static.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip): Use getBorderRadiiForRect to fetch border radii.
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Use getBorderRadiiForRect to fetch border radii.

(WebCore::RenderBoxModelObject::paintBorder):
Use getBorderRadiiForRect to fetch border radii, and fix a bug when drawing
borders for split inlines, which used to apply the radii for each segment,
and no longer does.

(WebCore::RenderBoxModelObject::paintBoxShadow):
Use getBorderRadiiForRect to fetch border radii.

  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint): Use getBorderRadiiForRect to fetch border radii for clipping.
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Use getBorderRadiiForRect to fetch border radii for clipping.
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::getBorderRadiiForRect): New bottleneck method to fetch corner radiil given a rect, applying the constraint rules.

LayoutTests:

2009-05-28 Simon Fraser <Simon Fraser>

Reviewed by Oliver Hunt.


​https://bugs.webkit.org/show_bug.cgi?id=8736

  • fast/borders/border-radius-constraints.html: Added.
  • platform/mac/fast/borders/border-radius-constraints-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-constraints-expected.png: Added.
  • platform/mac/fast/borders/border-radius-constraints-expected.txt: Added.


Test that corner radii are constrained according to CSS3 rules.

  • fast/borders/border-radius-huge-assert.html:
  • platform/mac/fast/borders/border-radius-huge-assert-expected.checksum:
  • platform/mac/fast/borders/border-radius-huge-assert-expected.png:
  • platform/mac/fast/borders/border-radius-huge-assert-expected.txt:


Now that we constrain border-radius, update the text of the test, and the
expected result.


  • fast/borders/border-radius-split-inline.html: Added.
  • platform/mac/fast/borders/border-radius-split-inline-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-split-inline-expected.png: Added.
  • platform/mac/fast/borders/border-radius-split-inline-expected.txt: Added.


New test for border-radius on a split inline.


  • fast/box-shadow/border-radius-big.html:
  • platform/mac/fast/box-shadow/border-radius-big-expected.checksum:
  • platform/mac/fast/box-shadow/border-radius-big-expected.png:
  • platform/mac/fast/box-shadow/border-radius-big-expected.txt:

Now that we constrain border-radius, update the text of the test, and the
expected result.

9:50 AM Changeset in webkit [44234] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitTools

2009-05-28 Olivier DOLE <​odole@pleyo.com>

Reviewed by Maciej.

Add options to sunspider-compare-results to know which test suite to
compare (see bug #15941).

  • Scripts/sunspider-compare-results:
9:46 AM Changeset in webkit [44233] by mitz@apple.com
  • 3 edits in branches/WWDC-2009-branch/WebCore

Windows build fix after r44178

9:23 AM Changeset in webkit [44232] by ap@webkit.org
  • 9 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=26005
Optimization for XPath * does not preserve context size

Test: fast/xpath/position.html

Fixed the bug by removing the incorrect optimization, and made enough micro-optimizations to
get a performance progression on my tests.

  • xml/XPathPath.h: Removed broken optimizeStepPair().
  • xml/XPathPath.cpp: (WebCore::XPath::LocationPath::evaluate): Style fix. (WebCore::XPath::LocationPath::appendStep): Don't call optimizeStepPair(). (WebCore::XPath::LocationPath::insertFirstStep): Ditto. (WebCore::XPath::Path::Path): Style fix.
  • xml/XPathStep.cpp: (WebCore::XPath::primaryNodeType): Turned this member function into a static inline helper. (WebCore::XPath::nodeMatches): Ditto. Don't check for namespace axis, which is unsupported (and might never be). (WebCore::XPath::Step::nodesInAxis): Updated for the new nodeMatches() signature.
  • xml/XPathStep.h: (WebCore::XPath::Step::NodeTest::data): (WebCore::XPath::Step::NodeTest::namespaceURI): Made these data members AtomicString to avoid repeated conversions. This is the biggest performance win here.
  • xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Reserve some capacity upfront.
9:20 AM Changeset in webkit [44231] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-05-28 Stephen White <​senorblanco@chromium.org>

Reviewed by Dimitri Glazkov.

When creating a linear or radial gradient with a single stop
at offset 1.0, the Skia layer was allocating 3 stops, but only
filling 2, leaving one uninitialized. Only 2 stops are necessary
in this case, at offsets (0.0, 1.0).

​http://bugs.webkit.org/show_bug.cgi?id=26063

Covered by: LayoutTests/svg/W3C-SVG-1.1/pservers-grad-16-b.svg

LayoutTests/svg/custom/gradient-stop-corner-cases.svg
LayoutTests/svg/custom/js-late-gradient-and-object-creation.svg

  • platform/graphics/skia/GradientSkia.cpp: (WebCore::totalStopsNeeded):
9:14 AM Changeset in webkit [44230] by Dimitri Glazkov
  • 8 edits in trunk/WebCore

2009-05-28 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Timothy Hatcher.

​https://bugs.webkit.org/show_bug.cgi?id=26041
Allow adding resource source to WebInspector.SourceFrame asynchronously.

Provide common implementation for InspectorController::addResourceSourceToFrame and
InspectorController::addSourceToFrame methods.

  • bindings/js/JSInspectorControllerCustom.cpp:
  • bindings/v8/custom/V8InspectorControllerCustom.cpp:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addResourceSourceToFrame):
  • inspector/InspectorController.h:
  • inspector/InspectorController.idl:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.revealLine): (WebInspector.SourceFrame.prototype.highlightLine): (WebInspector.SourceFrame.prototype._loaded): (WebInspector.SourceFrame.prototype._isContentLoaded):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded): (WebInspector.SourceView.prototype._contentLoaded):
8:45 AM Changeset in webkit [44229] by xan@webkit.org
  • 2 edits in trunk

2009-05-28 Xan Lopez <​xlopez@igalia.com>

Bump version numbers in preparation for 1.1.8 release.

  • configure.ac:
7:52 AM Changeset in webkit [44228] by xan@webkit.org
  • 6 edits in trunk/WebKit/gtk

2009-05-27 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=26039
[GTK] WebKitWebHistoryItem lifetime fixes

Modify the management of history items by the BackForward list.

Having the objects add themselves to a hash table with an extra
reference made impossible for the cleanup code in the dispose
method to be ever called in normal conditions, since dispose is
called before getting rid of the last reference, which the objects
were making to themselves. Get rid of this extra reference and
move the responsibility of the cleanup to the BackForward list
itself, which effectively owns the WebKitWebHistoryItems now.

Also, update the tests to reflect this change.

  • tests/testwebbackforwardlist.c: (test_webkit_web_history_item_lifetime): (test_webkit_web_back_forward_list_order): (test_webkit_web_back_forward_list_add_item):
  • tests/testwebhistoryitem.c: (web_history_item_fixture_setup): (web_history_item_fixture_teardown):
  • webkit/webkitprivate.h:
  • webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_dispose): (webkit_web_back_forward_list_class_init):
  • webkit/webkitwebhistoryitem.cpp: (webkit_history_items): (webkit_history_item_add): (webkit_web_history_item_dispose): (WebKit::kit):
7:52 AM Changeset in webkit [44227] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-26 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=26039
[GTK] WebKitWebHistoryItem lifetime fixes

Delete the BackForwardList before the Page, otherwise the references
to the WebKitWebHistoryItems will be gone.

  • webkit/webkitwebview.cpp: (webkit_web_view_dispose):
5:04 AM Changeset in webkit [44226] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-05-28 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Xan Lopez.

After r44177 we had a problem when increasing the size
of the window the scrollbars stayed and were not hidden.
This was due WebCore giving up on the Scrollbar as it became
unnecessary but the GtkAdjustment remained unchanged.
So from the point of view of the GtkScrolledWindow scrolling
was still necessary and the GtkScrollbar kept being displayed.

Solve the issue by resetting the GtkAdjustment in the
destructor of ScrollbarGtk.

  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::~ScrollbarGtk):
1:04 AM Changeset in webkit [44225] by abarth@webkit.org
  • 7 edits
    2 adds in trunk

WebCore:

2009-05-28 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Clean up window.open()'s use of lexical and dynamic scope.

(Added one unreviewed tweak: use dynamicFrame instead of lexicalFrame
for DOMWindow::allowPopUp.)

Test: http/tests/security/frameNavigation/context-for-window-open.html

  • bindings/js/JSDOMBinding.cpp: (WebCore::toDynamicFrame): (WebCore::processingUserGesture): (WebCore::completeURL):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow): (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::createWindow):

LayoutTests:

2009-05-28 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Test whether lexical or dynamic scope is used for window.open().

  • http/tests/security/frameNavigation/context-for-window-open-expected.txt: Added.
  • http/tests/security/frameNavigation/context-for-window-open.html: Added.
  • http/tests/security/frameNavigation/resources/middle-frame-for-location.html:
12:31 AM Changeset in webkit [44224] by abarth@webkit.org
  • 886 edits
    2 deletes in trunk

Revert 44221.

May 27, 2009:

11:36 PM Changeset in webkit [44223] by mrowe@apple.com
  • 1 edit in trunk/WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a

Fix MIME type.

11:31 PM Changeset in webkit [44222] by mrowe@apple.com
  • 5 edits
    1 add in trunk

Update build-webkit to handle a new version of WebKitSystemInterface.

Rubber-stamped by Dan Bernstein.

  • Scripts/build-webkit:

Update WebKitSystemInterface.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a: Added.
  • libWebKitSystemInterfaceTiger.a:
11:25 PM Changeset in webkit [44221] by abarth@webkit.org
  • 7 edits
    2 adds in trunk

WebCore:

2009-05-27 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Clean up window.open()'s use of lexical and dynamic scope.

Test: http/tests/security/frameNavigation/context-for-window-open.html

  • bindings/js/JSDOMBinding.cpp: (WebCore::toDynamicFrame): (WebCore::processingUserGesture): (WebCore::completeURL):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow): (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::createWindow):

LayoutTests:

2009-05-27 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Test whether lexical or dynamic scope is used for window.open().

  • http/tests/security/frameNavigation/context-for-window-open-expected.txt: Added.
  • http/tests/security/frameNavigation/context-for-window-open.html: Added.
  • http/tests/security/frameNavigation/resources/middle-frame-for-location.html:
11:02 PM Changeset in webkit [44220] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=26056
XPath string() function can be very slow

  • xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Use an intermediate Vector when appending.
10:30 PM Changeset in webkit [44219] by mjs@apple.com
  • 2 edits in trunk/WebKitSite

2009-05-27 Maciej Stachowiak <​mjs@apple.com>

Not reviewed, demo content.


  • Add doctype to Calendar demo.
  • demos/calendar/Calendar.html:
10:25 PM Changeset in webkit [44218] by mitz@apple.com
  • 7 edits
    4 adds in trunk

WebCore:

Reviewed by Sam Weinig.

  • fix <rdar://problem/6927761> <isindex> placeholder text is unstylable and initially not visible

Test: fast/forms/isindex-placeholder.html

  • css/html4.css: Added a default style for <isindex> placeholder text.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Changed to call the new protected function updatePlaceholderVisibility().
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::updatePlaceholderVisibility): Added this protected function to allow HTMLIsIndexElement::parseMappedAttribute() to invoke InputElement::updatePlaceholderVisibility().
  • html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::parseMappedAttribute): Call updatePlaceholderVisibility() when parsing the placeholder attribute.
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::createInnerTextStyle): If there is no placeholder pseudo-element style, use the normal style.

LayoutTests:

Reviewed by Sam Weinig.

  • test for <rdar://problem/6927761> <isindex> placeholder text is unstylable and initially not visible
  • fast/forms/isindex-placeholder.html: Added.
  • platform/mac/fast/forms/isindex-placeholder-expected.checksum: Added.
  • platform/mac/fast/forms/isindex-placeholder-expected.png: Added.
  • platform/mac/fast/forms/isindex-placeholder-expected.txt: Added.
10:06 PM Changeset in webkit [44217] by weinig@apple.com
  • 7 edits in trunk/WebCore

2009-05-27 Sam Weinig <​sam@webkit.org>

Reviewed by Maciej Stachowiak.

More cleanup of DOMWindow related functions.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::willRemoveFromWindowShell): Renamed from JSDOMWindowBase::clear()
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::showModalDialog): Update Comment.
  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/JSDOMWindowShell.h: Remove JSDOMWindowShell::clear(). It was unused.
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell):
8:36 PM Changeset in webkit [44216] by oliver@apple.com
  • 4 edits in trunk

<rdar://problem/6928025> Stack overflow in JSC::stringProtoFuncReplace() running jsFunFuzz

Reviewed by Mark Rowe

Add an additional exception check for stack overflow in String.replace

8:17 PM Changeset in webkit [44215] by weinig@apple.com
  • 7 edits in trunk/WebCore

2009-05-27 Sam Weinig <​sam@webkit.org>

Reviewed by David Hyatt.

Miscellaneous cleanup of DOMWindow related functions.

  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject): Fix poorly named variables.
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::supportsProfiling): Don't jump through hoops checking for null frames if the build does not support profiling. (WebCore::JSDOMWindowBase::clear): Use setCurrentEvent(0) instead of calling clearHelperObjectProperties(). It is clearer.
  • bindings/js/JSDOMWindowBase.h: Removed now unused clearHelperObjectProperties() function, empty disconnectFrame() function, and the empty destructor.
  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/JSDOMWindowShell.h: Remove disconnectFrame() which only called JSDOMWindowBase::disconnectFrame(), which is a no-op.
  • page/Frame.cpp: (WebCore::Frame::~Frame): (WebCore::Frame::pageDestroyed): Remove calls to JSDOMWindowShell::disconnectFrame() which only called JSDOMWindowBase::disconnectFrame(), which is a no-op.
6:50 PM Changeset in webkit [44214] by mrowe@apple.com
  • 4 edits in branches/WWDC-2009-branch

Versioning.

6:49 PM Changeset in webkit [44213] by mrowe@apple.com
  • 1 copy in tags/Safari-6530.13

New tag.

5:28 PM Changeset in webkit [44212] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebKit/mac

Merge r44194.

5:27 PM Changeset in webkit [44211] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebCore

Merge r44189.

5:27 PM Changeset in webkit [44210] by mrowe@apple.com
  • 7 edits in branches/WWDC-2009-branch

Merge r44181.

5:27 PM Changeset in webkit [44209] by mrowe@apple.com
  • 6 edits
    3 adds in branches/WWDC-2009-branch

Merge r44174.

5:27 PM Changeset in webkit [44208] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebKit/mac

Merge r44172.

5:27 PM Changeset in webkit [44207] by mrowe@apple.com
  • 11 edits in branches/WWDC-2009-branch

Merge r44170.

5:27 PM Changeset in webkit [44206] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/JavaScriptCore

Merge r44169.

5:27 PM Changeset in webkit [44205] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebKit/mac

Merge r44164.

5:27 PM Changeset in webkit [44204] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebKit/mac

Merge r44122.

5:13 PM Changeset in webkit [44203] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-27 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Xan Lopez.

Add comment to clarify why scrolling is done as it is and not with
gdk_window_scroll.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::scroll):
3:16 PM Changeset in webkit [44202] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-05-27 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

​https://bugs.webkit.org/show_bug.cgi?id=25974
Remove extra qualifiers from the ScheduledAction decl.

  • bindings/v8/ScheduledAction.h: Removed extraneous class qualifiers.
2:23 PM Changeset in webkit [44201] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-05-27 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed make distcheck fix. One more missing file.

  • GNUmakefile.am:
2:09 PM Changeset in webkit [44200] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-05-27 Antonio Gomes <​antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] Fixed trunk build on Linux after r44126.

1:46 PM Changeset in webkit [44199] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-05-27 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6926046> REGRESSION (r43972): ​http://www.youtube.com/html5 crashes on open

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load): Don't look for a media engine based on an empty MIME type.
1:04 PM Changeset in webkit [44198] by mjs@apple.com
  • 1 edit
    18 adds in trunk/WebKitSite

2009-05-27 Maciej Stachowiak <​mjs@apple.com>

Not reviewed, demo content.


  • add Calendar demo.
  • demos/calendar: Added.
  • demos/calendar/Boom.aiff: Added.
  • demos/calendar/Calendar.css: Added.
  • demos/calendar/Calendar.html: Added.
  • demos/calendar/Calendar.js: Added.
  • demos/calendar/Calendar.manifest: Added.
  • demos/calendar/CalendarApp.icns: Added.
  • demos/calendar/Images: Added.
  • demos/calendar/Images/AirPort4.png: Added.
  • demos/calendar/Images/AirPortError.png: Added.
  • demos/calendar/Images/disclosureTriangleSmallDown.png: Added.
  • demos/calendar/Images/disclosureTriangleSmallRight.png: Added.
  • demos/calendar/Images/statusbarBackground.png: Added.
  • demos/calendar/Images/statusbarResizerVertical.png: Added.
  • demos/calendar/LocationImage.js: Added.
  • demos/calendar/Utilities.js: Added.
  • demos/calendar/favicon.ico: Added.
  • demos/calendar/mime.types: Added.
12:20 PM Changeset in webkit [44197] by kov@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-27 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed (make distcheck) build fix; adding missing headers.

  • GNUmakefile.am:
12:14 PM Changeset in webkit [44196] by jberlin@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-05-27 Jessie Berlin <​jberlin@apple.com>

Reviewed by aroben


Fix the Windows build.

12:03 PM Changeset in webkit [44195] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-05-27 David Levin <​levin@chromium.org>

Reviewed by Maciej Stachowiak.

Bug 26029: FrameLoader::canLoad should allow calls with just a security origin
​https://bugs.webkit.org/show_bug.cgi?id=26029

No functional changes, so no tests.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::canLoad):
  • loader/FrameLoader.h:
11:01 AM Changeset in webkit [44194] by ap@webkit.org
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=26009
<rdar://problem/6925656> REGRESSION (r43973): Problems While Working With OpenVanilla

  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateSelectionForInputManager]): Don't call updateWindows if the selection is None. This routinely happens during editing, and it doesn't mean that we left an editable area (in which case the selection changes to a non-editable one).
10:57 AM Changeset in webkit [44193] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-05-27 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed build fix.

Remove file that does not exist from the build.

  • GNUmakefile.am:
10:33 AM Changeset in webkit [44192] by Nikolas Zimmermann
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

Remove two unneeded protected constructors, these classes have pure-virtual functions, and can't be constructed anyway.

10:27 AM Changeset in webkit [44191] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-27 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed. Adding new symbols index for 1.1.8.

  • docs/webkitgtk-docs.sgml:
10:21 AM Changeset in webkit [44190] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=17725
XPath should be case insensitive for HTML

Test: fast/xpath/node-name-case-sensitivity.html

  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodeMatches): Made node name check case insensitive for HTML elements in HTML documents.
10:00 AM Changeset in webkit [44189] by sullivan@apple.com
  • 2 edits in trunk/WebCore

2009-05-27 John Sullivan <​sullivan@apple.com>

fixed <rdar://problem/6925482> repro crash in WebCore::DragController::dragExited dropping
bookmarks (at least) over Top Sites (at least)

Reviewed by Kevin Decker

  • page/DragController.cpp: (WebCore::DragController::dragExited): nil check m_documentUnderMouse and take the "local file" case if it's nil
7:02 AM Changeset in webkit [44188] by kov@webkit.org
  • 4 edits in trunk

WebCore and JavaScriptCore

2009-05-27 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Gustavo Noronha.

When building on Windows, consider Windows specific files.

  • GNUmakefile.am:
5:25 AM Changeset in webkit [44187] by Nikolas Zimmermann
  • 5 edits in trunk/WebCore

Reviewed by George Staikos.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=26031

InputElementData is too heavy, save storing two pointers by passing them
directly to the static helper functions (the only place which needs them).

5:23 AM Changeset in webkit [44186] by Nikolas Zimmermann
  • 5 edits in trunk/WebCore

Reviewed by George Staikos.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=26033

OptionElementData saves an Element pointer, which is unnessary.
Just pass it to the static function calls directly.

5:17 AM Changeset in webkit [44185] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-27 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Disabling new tests to make the bot green.

  • platform/gtk/Skipped:
5:04 AM Changeset in webkit [44184] by kov@webkit.org
  • 6 edits in trunk

2009-05-27 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Maciej Stachowiak.

When building with MinGW, don't use the declspec(dl{import,export})
decorations and rely on the linker to use its nifty auto-import feature.
It is extremely hard to get the decorations right with MinGW in general
and impossible in WebKit, where the resulting shared library is linking
together some static libraries.

3:21 AM Changeset in webkit [44183] by zecke@webkit.org
  • 9 edits
    2 adds in trunk

JavaScripCore:
2009-05-26 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=25613

Be able to use GOwnPtr for GHashTable as well. The assumption
is that the hash table has been created with g_hash_table_new_full
and has proper destruction functions.

  • wtf/GOwnPtr.cpp: (WTF::GHashTable):
  • wtf/GOwnPtr.h:

WebCore:
2009-05-26 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=25613

Add a WebCore::Widget that can embed GtkWidget with and
without a GdkWindow. This can be used to embed any GtkWidget.

Some bits are directly copied from the Scrollbar implementation
but can not be easily shared here.

  • GNUmakefile.am:
  • platform/gtk/GtkPluginWidget.cpp: Added. (WebCore::GtkPluginWidget::GtkPluginWidget): (WebCore::GtkPluginWidget::invalidateRect): (WebCore::GtkPluginWidget::frameRectsChanged): (WebCore::GtkPluginWidget::paint):
  • platform/gtk/GtkPluginWidget.h: Added.

WebKit:
2009-05-26 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=25613

Add a new signal called "create-plugin-widget" and emit it from
within the FrameLoaderClientGtk::createPlugin method. If a
GtkWidget gets returned it will be embedded as a WebCore::Widget
using the new GtkPluginWidget.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createPlugin):
  • webkit/webkitwebview.cpp: (webkit_signal_accumulator_object_handled): (webkit_web_view_class_init):
  • webkitmarshal.list:
3:21 AM Changeset in webkit [44182] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-05-26 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25613

Implement Widget::setIsSelected for Gtk+ by searching
for a property of the name "webkit-widget-is-selected" and if
such property exists we are going to set it. We expect
the property to take a boolean.

  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::setIsSelected):
Note: See TracTimeline for information about the timeline view.