Timeline
Jun 22, 2009:
- 10:53 PM Changeset in webkit [44975] by
-
- 5 edits in trunk/LayoutTests
2009-06-22 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Alexey Proskuryakov.
Skip layout tests for DST if the test runs not in PST/PDT.
- fast/js/date-DST-time-cusps-expected.txt:
- fast/js/date-big-setdate-expected.txt:
- fast/js/resources/date-DST-time-cusps.js:
- fast/js/resources/date-big-setdate.js:
- 10:44 PM Changeset in webkit [44974] by
-
- 6 edits in trunk
Bug 26640: JSON.stringify needs to special case Boolean objects
<https://bugs.webkit.org/show_bug.cgi?id=26640>
Reviewed by Alexey Proskuryakov.
Add special case handling of the Boolean object so we match current
ES5 errata.
- 9:53 PM Changeset in webkit [44973] by
-
- 2 edits in trunk/WebCore
2009-06-22 Simon Fraser <Simon Fraser>
Reviewed by Oliver Hunt.
<rdar://problem/6991146> Scrollbars in hardware layers don't change to the
inactive look in background windows
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Don't short-circuit the "painting" pass that is used to udpate control tints.
- 9:36 PM Changeset in webkit [44972] by
-
- 3 edits1 add in trunk/WebCore
2009-06-22 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=26567
Upstream V8 bindings code generator. With this change, also added interface ancestor
traversal to IDL parser, which is necessary for V8 bindings. The traversal is used
to determine whether an interface is a Node to facilitate proper casting and storage
in V8DOMMap.
- bindings/scripts/CodeGenerator.pm: Added parent traversal sub, needed
by V8 bindings.
- bindings/scripts/CodeGeneratorV8.pm: Added.
- bindings/scripts/IDLParser.pm: Modified to allow limited parsing for
parent traversal cases.
- 8:37 PM Changeset in webkit [44971] by
-
- 8 edits in branches/nitro-extreme/JavaScriptCore
2009-06-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Remove 'arguments' field from Register union. Having JSCell derived types in the union is
dangerous since it opens the possibility for the field to be written as a raw pointer but
then read as a JSValue. This will lead to statle data being read for the tag, which may
be dangerous. Having removed Arguments* types form Register, all arguments objects must
always explicitly be stored in the register file as JSValues.
- interpreter/CallFrame.h: (JSC::ExecState::optionalCalleeArguments):
- interpreter/Interpreter.cpp: (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
- interpreter/Register.h: (JSC::Register::):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_tear_off_arguments):
- runtime/Arguments.h: (JSC::JSActivation::copyRegisters):
- runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
- runtime/JSActivation.h:
- 8:07 PM Changeset in webkit [44970] by
-
- 2 edits in trunk/WebKitTools
Roll out r44967 as that build slave hates freedom.
- 8:05 PM Changeset in webkit [44969] by
-
- 8 edits in trunk
WebCore:
2009-06-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Add event handler attribute getter/setters to HTMLFrameSetElement
as specified in HTML 5. These match the ones on HTMLBodyElement.
- dom/Node.h:
- html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute): (WebCore::HTMLFrameSetElement::onblur): (WebCore::HTMLFrameSetElement::setOnblur): (WebCore::HTMLFrameSetElement::onerror): (WebCore::HTMLFrameSetElement::setOnerror): (WebCore::HTMLFrameSetElement::onfocus): (WebCore::HTMLFrameSetElement::setOnfocus): (WebCore::HTMLFrameSetElement::onload): (WebCore::HTMLFrameSetElement::setOnload): (WebCore::HTMLFrameSetElement::onbeforeunload): (WebCore::HTMLFrameSetElement::setOnbeforeunload): (WebCore::HTMLFrameSetElement::onmessage): (WebCore::HTMLFrameSetElement::setOnmessage): (WebCore::HTMLFrameSetElement::onoffline): (WebCore::HTMLFrameSetElement::setOnoffline): (WebCore::HTMLFrameSetElement::ononline): (WebCore::HTMLFrameSetElement::setOnonline): (WebCore::HTMLFrameSetElement::onresize): (WebCore::HTMLFrameSetElement::setOnresize): (WebCore::HTMLFrameSetElement::onstorage): (WebCore::HTMLFrameSetElement::setOnstorage): (WebCore::HTMLFrameSetElement::onunload): (WebCore::HTMLFrameSetElement::setOnunload):
- html/HTMLFrameSetElement.h:
- html/HTMLFrameSetElement.idl:
LayoutTests:
2009-06-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Add event handler attribute getter/setters to HTMLFrameSetElement
as specified in HTML 5. These match the ones on HTMLBodyElement.
- fast/dom/event-attribute-availability-expected.txt:
- fast/dom/resources/event-attribute-availability.js:
- 6:27 PM Changeset in webkit [44968] by
-
- 5 edits in trunk
Bug 26591: Support revivers in JSON.parse
<https://bugs.webkit.org/show_bug.cgi?id=26591>
Reviewed by Darin Adler.
Add reviver support to JSON.parse. This completes the JSON object.
- 6:27 PM Changeset in webkit [44967] by
-
- 2 edits in trunk/WebKitTools
Update build.webkit.org config for new machine.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 6:04 PM Changeset in webkit [44966] by
-
- 6 edits in trunk/WebCore
2009-06-22 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 25425: DOM attribute getter/setter functions should use const AtomicString& type
https://bugs.webkit.org/show_bug.cgi?id=25425
- bindings/scripts/CodeGeneratorJS.pm: Added handling for ReflectURL.
- bindings/scripts/CodeGeneratorObjC.pm: Ditto.
- dom/Element.cpp: (WebCore::Element::getURLAttribute): Added. For use implementing getters for ReflectURL.
- dom/Element.h: Added getURLAttribute.
- html/HTMLImageElement.idl: Use Reflect and ReflectURL.
- 5:41 PM Changeset in webkit [44965] by
-
- 2 edits in trunk/WebCore
2009-06-22 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 26626: Make WorkerContextExecutionProxy::toV8Object handle exception
objects.
https://bugs.webkit.org/show_bug.cgi?id=26626
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::ToV8Object):
- 4:24 PM Changeset in webkit [44964] by
-
- 10 edits2 adds in trunk/WebCore
2009-06-22 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
Add RenderDataGrid to the build. Give it some basic default styling (that more or less matches a listbox). It has a default size
of 300x150.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- css/html4.css:
- html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::createRenderer):
- html/HTMLDataGridElement.h:
- html/HTMLDataGridElement.idl:
- rendering/RenderDataGrid.cpp: Added. (WebCore::RenderDataGrid::RenderDataGrid): (WebCore::RenderDataGrid::~RenderDataGrid): (WebCore::RenderDataGrid::calcPrefWidths): (WebCore::RenderDataGrid::paintObject): (WebCore::RenderDataGrid::valueChanged): (WebCore::RenderDataGrid::invalidateScrollbarRect): (WebCore::RenderDataGrid::isActive):
- rendering/RenderDataGrid.h: Added. (WebCore::RenderDataGrid::renderName): (WebCore::RenderDataGrid::canHaveChildren): (WebCore::RenderDataGrid::scrollbarCornerPresent):
- 4:01 PM Changeset in webkit [44963] by
-
- 2 edits in trunk/WebKitTools
Remove errant line of code mistakenly checked in.
- DumpRenderTree/win/DumpRenderTree.cpp: (main):
- 4:00 PM Changeset in webkit [44962] by
-
- 2 edits in trunk/WebKitTools
Pass correct value to setShouldPaintNativeControls.
Rubber stamped by Mark Rowe.
- DumpRenderTree/win/DumpRenderTree.cpp: (main):
- 3:45 PM Changeset in webkit [44961] by
-
- 7 edits2 adds in trunk
2009-06-22 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=26430
<rdar://problem/6944442> Elements jump around when they become composited (WWDC checkers demo)
<rdar://problem/6989006> Lots of time spent in RenderLayerCompositor::calculateCompositedBounds()
during window resize when using hardware layers
Fix an ordering dependency which caused the compositing position of a layer
to be affected by some later sibling, which affected the compositing ancestor's
composited bounds.
The fix is to only update the compositing positions of layers in some subtree
when updateAfterLayout() has been called on all the layers in that subtree,
from the ancestor down.
Also cache the composited bounds of a RenderLayerBacking, now that we can
guarantee that those bounds are accurate.
Test: compositing/sibling-positioning.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::hitTestLayer):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking): (WebCore::RenderLayerBacking::updateAfterLayout): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::contentOffsetInCompostingLayer): (WebCore::RenderLayerBacking::paintContents): (WebCore::RenderLayerBacking::compositedBounds): (WebCore::RenderLayerBacking::setCompositedBounds):
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking): (WebCore::RenderLayerCompositor::updateLayerCompositingState): (WebCore::RenderLayerCompositor::calculateCompositedBounds): (WebCore::RenderLayerCompositor::layerWillBeRemoved): (WebCore::RenderLayerCompositor::computeCompositingRequirements): (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): (WebCore::RenderLayerCompositor::updateCompositingChildrenGeometry):
- rendering/RenderLayerCompositor.h:
- 3:41 PM Moving to Git edited by
- Add link to evmar's doc (diff)
- 3:31 PM Moving to Git edited by
- Discussion of patch review branches (diff)
- 2:59 PM Changeset in webkit [44960] by
-
- 5 edits in branches/nitro-extreme
Merged r43552:43558 into nitro-extreme branch.
- 2:58 PM Changeset in webkit [44959] by
-
- 15 edits2 copies in trunk/WebCore
2009-06-22 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
First step in https://bugs.webkit.org/show_bug.cgi?id=25376
Add StorageSyncManager.cpp/h
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
In preparation for combining SessionStorage and LocalStorage into a
single StorageManager, move the syncing bits out of LocalStorage and
into its own class.
The next step is to combine LocalStorageArea and SessionStorageArea
into one. Then SessionStorage and LocalStorage can be combined.
Note that combining them will cut down on code paths that must be
proxied, eliminate virtual dispatch, and allow Chromium to (eventually)
write historical sessionStorage to disk when memory is getting tight.
Also remove a couple bits of cruft including code for quotas which is
unnecessary (since a meta-data db is unnecessary since you can just
count bytes as you read the local storage databases into memory).
- storage/LocalStorage.cpp: (WebCore::LocalStorage::LocalStorage): (WebCore::LocalStorage::storageArea): (WebCore::LocalStorage::close):
- storage/LocalStorage.h:
- storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::LocalStorageArea): (WebCore::LocalStorageArea::scheduleFinalSync): (WebCore::LocalStorageArea::syncTimerFired): (WebCore::LocalStorageArea::performImport):
- storage/LocalStorageArea.h: (WebCore::LocalStorageArea::create):
- storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::performTask):
- storage/LocalStorageTask.h: (WebCore::LocalStorageTask::): (WebCore::LocalStorageTask::createImport):
- storage/LocalStorageThread.cpp:
- storage/LocalStorageThread.h:
- storage/SessionStorage.h:
- storage/StorageSyncManager.cpp: Copied from WebCore/storage/LocalStorage.cpp. (WebCore::StorageSyncManager::create): (WebCore::StorageSyncManager::StorageSyncManager): (WebCore::StorageSyncManager::fullDatabaseFilename): (WebCore::StorageSyncManager::close): (WebCore::StorageSyncManager::scheduleImport): (WebCore::StorageSyncManager::scheduleSync):
- storage/StorageSyncManager.h: Copied from WebCore/storage/LocalStorage.h. (WebCore::):
- 2:47 PM Changeset in webkit [44958] by
-
- 2 edits in branches/nitro-extreme
Merged r43550:43552 into nitro-extreme branch - fix error in merging changelogs.
- 2:43 PM Changeset in webkit [44957] by
-
- 5 edits7 copies in branches/nitro-extreme
Merged r43550:43552 into nitro-extreme branch.
- 2:38 PM Changeset in webkit [44956] by
-
- 3 edits in trunk/WebCore
2009-06-22 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=26622
Add ChromiumDataObject::copy()
- platform/chromium/ChromiumDataObject.cpp:
- platform/chromium/ChromiumDataObject.h:
- 2:31 PM Changeset in webkit [44955] by
-
- 2 edits in trunk/WebKit/mac
Add Mail on Tiger and Leopard to the list of applications that need the WebView init thread workaround.
<rdar://problem/6929524> Console shows WebKit Threading Violations from Mail
Reviewed by Anders Carlsson.
- WebView/WebView.mm: (clientNeedsWebViewInitThreadWorkaround): Return true for com.apple.Mail.
- 2:30 PM Moving to Git edited by
- (diff)
- 2:25 PM Changeset in webkit [44954] by
-
- 2 edits1 add in trunk/WebCore
Add a silhouette image for the enable view of the Resource panel.
Reviewed by Kevin McCullough.
- inspector/front-end/Images/resourcesSilhouette.png: Added.
- inspector/front-end/inspector.css:
- 2:02 PM Changeset in webkit [44953] by
-
- 2 edits1 add in trunk/WebCore
2009-06-22 Kyle Prete <kylep@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=26552
Add V8 JS bindings for Audio Constructor.
- bindings/v8/custom/V8CustomBinding.h: Added a callback declaration for audio ctor to macro.
- bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: Added the whole file.
- 1:14 PM Changeset in webkit [44952] by
-
- 2 edits in trunk/WebCore
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=26600
StringImpl::copy() no longer copies empty string correctly
- platform/text/StringImpl.cpp: (WebCore::StringImpl::ustring): Changed method calling syntax to look less like calling a static method. (WebCore::StringImpl::copy): Reverted part of r41917 that caused the problem.
- 12:51 PM Changeset in webkit [44951] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Anders Carlsson.
- speculative fix for <rdar://problem/6889082> Crash at -[WebHTMLView(WebPrivate) _updateMouseoverWithEvent:]
The crash seems to happen because lastHitView points to a deleted
object. Since -close calls -_clearLastHitViewIfSelf, I speculate that
lastHitView has been set to an already-closed view.
- WebView/WebHTMLView.mm: (-[WebHTMLView hitTest:]): Return nil if the view is closed.
- 12:34 PM Changeset in webkit [44950] by
-
- 3 edits in trunk/LayoutTests
2009-06-22 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix layout tests to account for removal of DOMStringList, which was done
in http://trac.webkit.org/changeset/44943.
- fast/dom/Window/window-properties-expected.txt:
- fast/js/global-constructors-expected.txt:
- 12:20 PM Changeset in webkit [44949] by
-
- 3 edits in branches/nitro-extreme/WebCore
Merged r43544:43550 into nitro-extreme branch.
- 11:54 AM Changeset in webkit [44948] by
-
- 2 edits1 add in trunk/WebCore
2009-06-22 Xiaomei Ji <xji@chromium.org>
Reviewed by Eric Seidel
Not auto-testable since it involves sending a keyboard event to
the popup, which is not possible (eventSender sends the key
events through webview, we want to go through the webwidget).
This patch is one part of the fix for issue "keyboard selection in
Hebrew select element does not work in Windows". The other part of the
fix is in chromium's webkit/glue layer.
https://bugs.webkit.org/show_bug.cgi?id=25899
- manual-tests/keyboard_select_non_english.html: Added.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::isCharacterTypeEvent): Added. Check whether the event is a character type event. "Char" in Windows or "KeyDown" in Mac is character type event. (WebCore::PopupListBox::typeAheadFind): Since m_lastCharTime is used to indicate whether user types multiple characters continuely as a search prefix or not, it should be only assigned when the event is character type event.
- 11:51 AM Changeset in webkit [44947] by
-
- 5 edits in trunk/WebCore
2009-06-22 Kevin McCullough <kmccullough@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6115819> Notify of profile start in console
Put a message in the console that announces that a profile has started,
similar to how a console message announces that a profile has finished.
- inspector/InspectorController.cpp: (WebCore::InspectorController::addProfile): Use renamed function. (WebCore::InspectorController::addProfileFinishedMessageToConsole): Renamed. (WebCore::InspectorController::addStartProfilingMessageToConsole): New function that logs the message about the profile starting. (WebCore::InspectorController::startUserInitiatedProfiling): Ditto
- inspector/InspectorController.h:
- inspector/front-end/ProfilesPanel.js: Print the "run" of the profile's title if there are multiple profiles, and take into account the fact that titles are displayed twice as much now. (WebInspector.ProfilesPanel.prototype.displayTitleForProfileLink):
- page/Console.cpp: (WebCore::Console::profile): Call new function.
- 11:47 AM Changeset in webkit [44946] by
-
- 17 edits3 adds in trunk/WebCore
2009-06-22 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
Add IDL interface for datagrid cell elements. Add a few more properties to the datagrid itself that
correspond to ones you find on <select> elements.
Add an expanded property to row elements.
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- html/HTMLAttributeNames.in:
- html/HTMLDataGridCellElement.cpp: Added. (WebCore::HTMLDataGridCellElement::HTMLDataGridCellElement): (WebCore::HTMLDataGridCellElement::label): (WebCore::HTMLDataGridCellElement::setLabel): (WebCore::HTMLDataGridCellElement::focused): (WebCore::HTMLDataGridCellElement::setFocused): (WebCore::HTMLDataGridCellElement::checked): (WebCore::HTMLDataGridCellElement::setChecked): (WebCore::HTMLDataGridCellElement::indeterminate): (WebCore::HTMLDataGridCellElement::setIndeterminate): (WebCore::HTMLDataGridCellElement::progress): (WebCore::HTMLDataGridCellElement::setProgress):
- html/HTMLDataGridCellElement.h: Added. (WebCore::HTMLDataGridCellElement::endTagRequirement): (WebCore::HTMLDataGridCellElement::tagPriority):
- html/HTMLDataGridCellElement.idl: Added.
- html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::autofocus): (WebCore::HTMLDataGridElement::setAutofocus): (WebCore::HTMLDataGridElement::disabled): (WebCore::HTMLDataGridElement::setDisabled): (WebCore::HTMLDataGridElement::size): (WebCore::HTMLDataGridElement::setSize):
- html/HTMLDataGridElement.h:
- html/HTMLDataGridElement.idl:
- html/HTMLDataGridRowElement.cpp: (WebCore::HTMLDataGridRowElement::checkDTD): (WebCore::HTMLDataGridRowElement::expanded): (WebCore::HTMLDataGridRowElement::setExpanded):
- html/HTMLDataGridRowElement.h:
- html/HTMLDataGridRowElement.idl:
- html/HTMLElementsAllInOne.cpp:
- html/HTMLTagNames.in:
- 11:32 AM Changeset in webkit [44945] by
-
- 2 edits in trunk/WebKitTools
Fix last DumpRenderTree change to correctly set preferences flag without crashing.
Reviewed by Mark Rowe.
- DumpRenderTree/win/DumpRenderTree.cpp: (main):
- 11:32 AM Changeset in webkit [44944] by
-
- 13 edits in trunk
WebCore:
2009-06-22 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Add event handler attribute getter/setters to HTMLBodyElement
as specified in HTML 5.
- Removes erroneous inclusion of the onresize and onunload event handler attributes in Element and Document.
- dom/Document.cpp: (WebCore::Document::getWindowAttributeEventListener):
- dom/Document.h:
- dom/Document.idl:
- dom/Element.idl:
- dom/Node.cpp:
- dom/Node.h: onblur, onerror, onfocus, and onload all need to be declared virtual, since their behavior for HTMLBodyElement differs from the base implementation.
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::onblur): (WebCore::HTMLBodyElement::setOnblur): (WebCore::HTMLBodyElement::onerror): (WebCore::HTMLBodyElement::setOnerror): (WebCore::HTMLBodyElement::onfocus): (WebCore::HTMLBodyElement::setOnfocus): (WebCore::HTMLBodyElement::onload): (WebCore::HTMLBodyElement::setOnload): (WebCore::HTMLBodyElement::onbeforeunload): (WebCore::HTMLBodyElement::setOnbeforeunload): (WebCore::HTMLBodyElement::onmessage): (WebCore::HTMLBodyElement::setOnmessage): (WebCore::HTMLBodyElement::onoffline): (WebCore::HTMLBodyElement::setOnoffline): (WebCore::HTMLBodyElement::ononline): (WebCore::HTMLBodyElement::setOnonline): (WebCore::HTMLBodyElement::onresize): (WebCore::HTMLBodyElement::setOnresize): (WebCore::HTMLBodyElement::onstorage): (WebCore::HTMLBodyElement::setOnstorage): (WebCore::HTMLBodyElement::onunload): (WebCore::HTMLBodyElement::setOnunload):
- html/HTMLBodyElement.h:
- html/HTMLBodyElement.idl:
LayoutTests:
2009-06-22 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Add event handler attribute getter/setters to HTMLBodyElement
as specified in HTML 5.
- fast/dom/event-attribute-availability-expected.txt:
- fast/dom/resources/event-attribute-availability.js:
- 11:22 AM Changeset in webkit [44943] by
-
- 24 edits7 deletes in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26601
Remove disabled code for appcache dynamic entries
This also removes code for DOM 3 Core DOMStringList, which we don't use for anything else yet.
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSDOMStringListCustom.cpp: Removed.
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8DOMStringListCustom.cpp: Removed.
- dom/DOMStringList.cpp: Removed.
- dom/DOMStringList.h: Removed.
- dom/DOMStringList.idl: Removed.
- dom/StaticStringList.cpp: Removed.
- dom/StaticStringList.h: Removed.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
- loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::addResource):
- loader/appcache/ApplicationCache.h:
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
- loader/appcache/ApplicationCacheResource.cpp: (WebCore::ApplicationCacheResource::dumpType):
- loader/appcache/ApplicationCacheResource.h: (WebCore::ApplicationCacheResource::):
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::storeUpdatedType):
- loader/appcache/DOMApplicationCache.cpp:
- loader/appcache/DOMApplicationCache.h:
- loader/appcache/DOMApplicationCache.idl:
- page/DOMWindow.idl:
- 10:56 AM Changeset in webkit [44942] by
-
- 3 edits in trunk/WebCore
Windows build fix.
- DerivedSources.cpp:
- html/HTMLElementsAllInOne.cpp:
- 10:33 AM Changeset in webkit [44941] by
-
- 4 edits in trunk
Reviewed by John Sullivan.
<rdar://problem/6956606> REGRESSION (S4Beta -> Final): After the password is input,
Japanese can't be input.
WebKit uses a per-frame input context for most editable fields, and application's global
context for password fields, manually controlling secure input state and the list of available
input methods.
We were setting TSMDocument property to disable non-Roman input methods after focus changed
to a password field, but before selection was updated. This resulted in the property being
applied to a wrong TSMDocument in some cases, because TSMGetActiveDocument() uses input
context cached by +[NSApplication updateWindows], we change context based on selection,
not on focus.
- page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry): Since there is only one context that we use for password fields - the global one - there is no need to get the active one.
- 10:20 AM Changeset in webkit [44940] by
-
- 8 edits3 adds in trunk
WebCore:
2009-06-22 David Levin <levin@chromium.org>
Reviewed by David Hyatt and Eric Seidel.
REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
https://bugs.webkit.org/show_bug.cgi?id=26326
Test: scrollbars/scrollbar-crash-on-refresh.html
- dom/Document.cpp: (WebCore::Document::detach): Gives the FrameView a change to do any necessary cleanup on Document::detach() which is where the renderArena gets detroyed.
- page/FrameView.cpp: (WebCore::FrameView::detachCustomScrollbars): Gets rid of any custom scrollbars (if the docment supplied them).
- page/FrameView.h:
- platform/Scrollbar.h: (WebCore::Scrollbar::isCustomScrollbar):
- rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Removed the check for document()->frame(). If frame() is 0 in this code, then the call to animation() is also incorrect (since it does document()->frame()->animation()).
- rendering/RenderScrollbar.h: (WebCore::RenderScrollbar::isCustomScrollbar):
LayoutTests:
2009-06-22 David Levin <levin@chromium.org>
Reviewed by David Hyatt and Eric Seidel.
REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
https://bugs.webkit.org/show_bug.cgi?id=26326
Test that refreshing an iframe with custom scrollbars works without crashing.
- scrollbars/resources/page-with-custom-scrollbars.html: Added.
- scrollbars/scrollbar-crash-on-refresh-expected.txt: Added.
- scrollbars/scrollbar-crash-on-refresh.html: Added.
- 9:50 AM Changeset in webkit [44939] by
-
- 3 edits in trunk/WebKit/mac
Reviewed by Dave Hyatt.
- fix <rdar://problem/6990938> REGRESSION (r42787): After showing and hiding the Find banner, the WebHTMLView's height is not restored
- WebView/WebFrameView.mm: (-[WebFrameView setFrameSize:]): Mark the FrameView for layout when the WebFrameView's size changes.
- WebView/WebView.mm: (-[WebView setFrameSize:]): Left the resize logic here, but only for the single view model.
- 9:42 AM Changeset in webkit [44938] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Simon Fraser.
- fix https://bugs.webkit.org/show_bug.cgi?id=23606 <rdar://problem/6537777> CSS gradient not repainted when image load completes
Test: fast/repaint/background-generated.html
- rendering/RenderObject.cpp: (WebCore::mustRepaintFillLayers): Return true if the layer does not specify a size and the image uses the container size.
LayoutTests:
Reviewed by Simon Fraser.
- test for https://bugs.webkit.org/show_bug.cgi?id=23606 <rdar://problem/6537777> CSS gradient not repainted when image load completes
- fast/repaint/background-generated.html: Added.
- platform/mac/fast/repaint/background-generated-expected.checksum: Added.
- platform/mac/fast/repaint/background-generated-expected.png: Added.
- platform/mac/fast/repaint/background-generated-expected.txt: Added.
- 9:34 AM Changeset in webkit [44937] by
-
- 15 edits3 adds in trunk/WebCore
2009-06-22 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
Add IDL for HTMLDataGridRowElement.
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- html/HTMLAttributeNames.in:
- html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::primary): (WebCore::HTMLDataGridColElement::setPrimary):
- html/HTMLDataGridColElement.h:
- html/HTMLDataGridColElement.idl:
- html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::checkDTD): (WebCore::HTMLDataGridElement::multiple): (WebCore::HTMLDataGridElement::setMultiple):
- html/HTMLDataGridElement.h:
- html/HTMLDataGridElement.idl:
- html/HTMLDataGridRowElement.cpp: Added. (WebCore::HTMLDataGridRowElement::HTMLDataGridRowElement): (WebCore::HTMLDataGridRowElement::selected): (WebCore::HTMLDataGridRowElement::setSelected): (WebCore::HTMLDataGridRowElement::focused): (WebCore::HTMLDataGridRowElement::setFocused):
- html/HTMLDataGridRowElement.h: Added. (WebCore::HTMLDataGridRowElement::tagPriority):
- html/HTMLDataGridRowElement.idl: Added.
- html/HTMLTagNames.in:
- 9:32 AM Changeset in webkit [44936] by
-
- 2 edits in trunk/LayoutTests
2009-06-22 Darin Adler <Darin Adler>
- platform/gtk/Skipped: Skip two new tests.
- 8:44 AM Changeset in webkit [44935] by
-
- 2 edits in trunk/LayoutTests
2009-06-22 Darin Adler <Darin Adler>
- fast/js/JSON-stringify-expected.txt: Update results.
- 6:22 AM Changeset in webkit [44934] by
-
- 3 edits1 add in trunk/WebCore
2009-06-19 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Holger Freyther.
Fix a crash in case that the QNetworkReply::readReady signal is
"stuck" in deferred mode due to JavaScript alert, and in the meantime,
QNetworkreply::finished signal is received and processed before
QNetworkReply::readReady is processed.
- manual-tests/qt/unload-alert.html: Added.
- platform/network/qt/QNetworkReplyHandler.cpp:
- platform/network/qt/QNetworkReplyHandler.h:
- 4:55 AM Changeset in webkit [44933] by
-
- 2 edits in trunk/WebCore
2009-06-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Fix the Qt build.
- WebCore.pro:
- 12:33 AM Changeset in webkit [44932] by
-
- 2 edits in trunk/WebKitTools
Set up global native controls flag before creating the first WebView.
Reviewed by Darin Adler.
- DumpRenderTree/win/DumpRenderTree.cpp: (main):
Jun 21, 2009:
- 11:35 PM Changeset in webkit [44931] by
-
- 6 edits in trunk
Bug 26592: Support standard toJSON functions
<https://bugs.webkit.org/show_bug.cgi?id=26592>
Reviewed by Darin Adler
Add support for the standard Date.toJSON function.
- 11:17 PM Changeset in webkit [44930] by
-
- 4 edits in trunk/WebCore
2009-06-21 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 25425: DOM attribute getter/setter functions should use const AtomicString& type
https://bugs.webkit.org/show_bug.cgi?id=25425
- bindings/scripts/CodeGeneratorJS.pm: Tweaked mechanism for includes to be a bit more consistent and to make SVGElement.h be included in the header rather than in every implementation file that includes the header. Added code to use getAttribute and setAttribute directly when the [Reflect] extended attribute is used.
- bindings/scripts/CodeGeneratorObjC.pm: Ditto.
- html/HTMLElement.idl: Used [Reflect] for all the attributes in this class that reflect content attributes. Restricting this to one class for now to keep the patch small and start out slowly.
- 10:08 PM Changeset in webkit [44929] by
-
- 3 edits3 adds in trunk
Bug 26594: JSC needs to support Date.toISOString
<https://bugs.webkit.org/show_bug.cgi?id=26594>
Reviewed by Sam Weinig
Add support for Date.toISOString.
- 9:59 PM Changeset in webkit [44928] by
-
- 7 edits3 adds in trunk
WebCore:
2009-06-21 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=26596
Only expose event handler attributes to elements and documents.
Test: fast/dom/event-attribute-availability.html
- dom/Document.idl:
- dom/Element.idl:
- dom/Node.cpp:
- dom/Node.h:
- dom/Node.idl:
LayoutTests:
2009-06-21 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Test for https://bugs.webkit.org/show_bug.cgi?id=26596
Only expose event handler attributes to elements and documents.
- fast/dom/event-attribute-availability-expected.txt: Added.
- fast/dom/event-attribute-availability.html: Added.
- fast/dom/resources/event-attribute-availability.js: Added.
- 6:39 PM Changeset in webkit [44927] by
-
- 4 edits3 adds in trunk
WebCore:
2009-06-21 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Fix to enable XSSAuditor on child windows.
Test: http/tests/security/xssAuditor/link-opens-new-window.html
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::isEnabled): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject):
- page/XSSAuditor.h: Removed method setXSSAuditorEnabled, and field m_isEnabled. Moved implementation of isEnabled to XSSAuditor.cpp and changed implementation to query Settings.
LayoutTests:
2009-06-21 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Tests that XSSAuditor (if enabled) prevents script execution in child window.
- http/tests/security/xssAuditor/link-opens-new-window-expected.txt: Added.
- http/tests/security/xssAuditor/link-opens-new-window.html: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-and-notify.php: Added.
- 5:23 PM Changeset in webkit [44926] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Mark Rowe.
- make repaint tests more reliable when run in Safari
- fast/repaint/resources/repaint.js: (runRepaintTest): Increased the timeout from 0 to 100, to ensure that painting occurs once before repaintTest() is called.
- 5:03 PM Changeset in webkit [44925] by
-
- 2 edits in trunk/WebKitTools
Set a sensible user agent string for the HTTP requests that Sparkle makes (checking for and downloading updates).
Reviewed by Sam Weinig.
- WebKitLauncher/WebKitNightlyEnablerSparkle.m:
(userAgentStringForSparkle):
(initializeSparkle):
- 4:32 PM Changeset in webkit [44924] by
-
- 2 edits in trunk/JavaScriptCore
Fix build by removing dead code.
- 4:02 PM Changeset in webkit [44923] by
-
- 7 edits3 adds in trunk
Bug 26587: Support JSON.parse
<https://bugs.webkit.org/show_bug.cgi?id=26587>
Reviewed by Darin Adler and Cameron Zwarich.
Extend the LiteralParser to support the full strict JSON
grammar, fix a few places where the grammar was incorrectly
lenient. Doesn't yet support the JSON.parse reviver function
but that does not block the JSON.parse functionality itself.
- 3:46 PM Changeset in webkit [44922] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-21 David Levin <levin@chromium.org>
Reviewed by NOBODY (speculative build fix for windows).
Simply removed some whitespace form this file to make windows build wtf and
hopefully copy the new MessageQueque.h so that WebCore picks it up.
- wtf/Assertions.cpp:
- 3:16 PM Changeset in webkit [44921] by
-
- 2 edits in trunk/WebCore
2009-06-21 David Levin <levin@chromium.org>
Reviewed by NOBODY.
Speculative windows build fix (idea by Mark Rowe).
- WebCore.vcproj/WebCore.vcproj:
- 3:03 PM Changeset in webkit [44920] by
-
- 2 edits2 adds in trunk/WebKitTools
Add a hook to the WebKit launcher application to allow a link on the nightly build start page to
trigger an update via the built-in software update mechanism.
Reviewed by Sam Weinig.
- WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
- WebKitLauncher/WebKitLauncherURLProtocol.h: Added.
- WebKitLauncher/WebKitLauncherURLProtocol.m: Added.
(+[WebKitLauncherURLProtocol load]):
(+[WebKitLauncherURLProtocol canInitWithRequest:]): Only allow use of the x-webkit-launcher scheme from .webkit.org subdomains.
(+[WebKitLauncherURLProtocol canonicalRequestForRequest:]):
(-[WebKitLauncherURLProtocol startLoading]):
(-[WebKitLauncherURLProtocol stopLoading]):
(-[WebKitLauncherURLProtocol handleIsWebKitLauncherAvailableJS]): Return a brief JavaScript snippet that can be used to programatically
determine whether the x-webkit-launcher is available and working.
(-[WebKitLauncherURLProtocol handleCheckForUpdates]): Trigger a software update on the main thread.
(-[WebKitLauncherURLProtocol resourceNotFound]): Fail with a generic "File does not exist" error.
- 3:02 PM Changeset in webkit [44919] by
-
- 2 edits in trunk/WebCore
2009-06-21 David Levin <levin@chromium.org>
Reviewed by NOBODY (Speculative gtk build fix).
- GNUmakefile.am:
- 2:56 PM Changeset in webkit [44918] by
-
- 3 edits in trunk/WebCore
2009-06-21 David Levin <levin@chromium.org>
Reviewed by NOBODY.
Speculative tiger build fix and a windows build fix.
More fixes may still be in order.
- WebCore.vcproj/WebCoreCommon.vsprops:
- dom/default/PlatformMessagePortChannel.h: (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
- 2:46 PM Changeset in webkit [44917] by
-
- 2 edits in trunk/WebCore
2009-06-21 David Levin <levin@chromium.org>
Reviewed by NOBODY (Speculative tiger build fix).
- dom/default/PlatformMessagePortChannel.h: (WebCore::PlatformMessagePortChannel::MessagePortQueue::~MessagePortQueue):
- 2:32 PM Changeset in webkit [44916] by
-
- 9 edits2 adds in trunk
WebCore:
2009-06-21 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
Added optimized GC for MessagePorts when the entangled port is run by the same thread.
Fixed bug in isProxyFor() that was not properly throwing an exception when trying to clone the entangled port.
- bindings/js/JSDOMBinding.cpp: (WebCore::markActiveObjectsForContext): Now marks remotely entangled ports as in-use, in addition to those with pending activity.
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark): Now checks if the entangled port is local (run by same thread) and if so mark()s it.
- dom/MessagePort.cpp: (WebCore::MessagePort::postMessage): (WebCore::MessagePort::disentangle): Removes cloned ports from the ScriptExecutionContext - this allows cloned ports to be GC'd as otherwise they look like remotely entangled ports. (WebCore::MessagePort::start): (WebCore::MessagePort::locallyEntangledPort): Added API for fetching the entangled port if it is run by the same thread
- dom/MessagePort.h:
- dom/MessagePortProxyWrapper.h:
- dom/default/MessagePortProxy.cpp: (WebCore::MessagePortProxyWrapper::locallyEntangledPort): Added API for fetching the entangled port if it is run by the same thread (WebCore::MessagePortProxy::hasPendingActivity): Changed definition of hasPendingActivity() to be stricter - only returns true if there are pending messages. (WebCore::MessagePortProxy::locallyEntangledPort):
- dom/default/MessagePortProxy.h:
LayoutTests:
2009-06-21 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
New tests for MessagePort GC cases that weren't previously covered.
- fast/events/message-channel-gc-4-expected.txt: Added. Test for case where both MessagePorts are in-transit (cloned) when a GC occurs.
- fast/events/message-channel-gc-4.html-disabled: Added.
- 2:32 PM Changeset in webkit [44915] by
-
- 23 edits1 move7 adds2 deletes in trunk
2009-06-21 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
<https://bugs.webkit.org/show_bug.cgi?id=25043>
Added support for multi-threaded MessagePorts.
- wtf/MessageQueue.h: (WTF::::appendAndCheckEmpty):
Added API to test whether the queue was empty before adding an element.
WebCore:
2009-06-21 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
<https://bugs.webkit.org/show_bug.cgi?id=25043>
Removed obsolete MessagePort.startConversation(), active and onclose APIs.
Refactored MessagePortProxy into MessagePortChannel and a platform-dependent PlatformMessagePortChannel
implementation. Modified APIs to simplify cross-process implementations by moving the messaging code
entirely into the platform-dependent proxy.
Created a thread-safe default PlatformMessagePortChannel implementation.
Changed DOMWindow messaging to create the MessageEvent in the target ScriptExecutionContext to match how
cross-thread MessagePorts work.
- GNUMakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Added MessagePortChannel/PlatformMessagePortChannel files.
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark):
Changed ports to not mark their entangled pair as reachable, per the spec.
- bindings/v8/custom/V8MessagePortCustom.cpp:
- dom/MessageChannel.cpp: (WebCore::MessageChannel::MessageChannel):
Updated to use PlatformMessagePortChannel::createChannel() to entangle the ports.
- dom/MessagePort.cpp: (WebCore::MessagePort::MessagePort): (WebCore::MessagePort::~MessagePort): (WebCore::MessagePort::postMessage): (WebCore::MessagePort::disentangle): (WebCore::MessagePort::messageAvailable): (WebCore::MessagePort::start): (WebCore::MessagePort::close): (WebCore::MessagePort::entangle): (WebCore::MessagePort::contextDestroyed): (WebCore::MessagePort::dispatchMessages): (WebCore::MessagePort::setOnmessage): (WebCore::MessagePort::hasPendingActivity):
Changed these APIs to delegate to new PlatformMessagePortChannel APIs.
- dom/MessagePort.h:
Renamed isQueueOpen() to started().
- dom/MessagePort.idl:
Removed startConversation and onclose.
- dom/MessagePortProxy.h: Removed.
- dom/MessagePortChannel.cpp: Added. (WebCore::MessagePortChannel::EventData::create): (WebCore::MessagePortChannel::EventData::EventData): (WebCore::MessagePortChannel::~MessagePortChannel):
- dom/MessagePortChannel.h: Added. (WebCore::MessagePortChannel::EventData::message): (WebCore::MessagePortChannel::EventData::channel):
Changed EventData to hold a reference to a MessagePortChannel object instead of a MessagePort to enable cross-thread messaging.
(WebCore::MessagePortChannel::MessagePortChannel):
(WebCore::MessagePortChannel::create):
- dom/ScriptExecutionContext.cpp: (WebCore:ScriptExecutionContext::dispatchMessagePortEvents):
Renamed isQueueOpen() to started().
- dom/default/PlatformMessagePortChannel.cpp: Added. (WebCore::MessagePortChannel::entangleIfOpen): (WebCore::MessagePortChannel::disentangle): (WebCore::MessagePortChannel::postMessageToRemote): (WebCore::MessagePortChannel::tryGetMessageFromRemote): (WebCore::MessagePortChannel::close): (WebCore::MessagePortChannel::isConnectedTo): (WebCore::MessagePortChannel::hasPendingActivity): (WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::~PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::createChannel): (WebCore::PlatformMessagePortChannel::entangleIfOpen): (WebCore::PlatformMessagePortChannel::disentangle): (WebCore::PlatformMessagePortChannel::setRemotePort): (WebCore::PlatformMessagePortChannel::remotePort): (WebCore::PlatformMessagePortChannel::entangledChannel): (WebCore::PlatformMessagePortChannel::setEntangledChannel): (WebCore::PlatformMessagePortChannel::postMessageToRemote): (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote): (WebCore::PlatformMessagePortChannel::isConnectedTo): (WebCore::PlatformMessagePortChannel::close): (WebCore::PlatformMessagePortChannel::closeInternal): (WebCore::PlatformMessagePortChannel::hasPendingActivity):
- dom/default/PlatformMessagePortChannel.h: Added. (WebCore::PlatformMessagePortChannel::MessagePortQueue::create): (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage): (WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty): (WebCore::PlatformMessagePortChannel::MessagePortQueue::isEmpty): (WebCore::PlatformMessagePortChannel::MessagePortQueue::MessagePortQueue):
- page/DOMWindow.cpp: (WebCore::PostMessageTimer::PostMessageTimer):
Changed DOMWindow messaging to create the MessageEvent in the target ScriptExecutionContext to match how cross-thread MessagePorts work.
(WebCore::PostMessageTimer::event):
(WebCore::DOMWindow::postMessage):
(WebCore::DOMWindow::postMessageTimerFired):
LayoutTests:
2009-06-21 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
<https://bugs.webkit.org/show_bug.cgi?id=25043>
Updated MessageChannel/MessagePorts tests to reflect latest spec (close event has been removed).
Added more tests of port cloning.
- fast/events/message-channel-gc-2-expected.txt:
- fast/events/message-channel-gc-2.html-disabled:
- fast/events/message-channel-gc-3-expected.txt:
- fast/events/message-channel-gc-3.html-disabled:
- fast/events/message-channel-gc-expected.txt:
- fast/events/message-channel-gc.html-disabled:
- fast/events/message-port-clone-expected.txt: Added.
- fast/events/message-port-clone.html-disabled: Added.
- fast/events/message-port-expected.txt:
- fast/events/message-port-no-wrapper-expected.txt: Added.
- fast/events/message-port-onclose-expected.txt: Removed.
- fast/events/message-port-onclose.html-disabled: Removed.
- fast/events/message-port.html-disabled:
- 1:56 PM Changeset in webkit [44914] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Sam Weinig.
- fix https://bugs.webkit.org/show_bug.cgi?id=15383 <rdar://problem/5682745> resize: vertical does not restrict to vertical resize
Test: fast/css/resize-single-axis.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize): Ignore movement along the non-resizing axis.
LayoutTests:
Reviewed by Sam Weinig.
- test for https://bugs.webkit.org/show_bug.cgi?id=15383 <rdar://problem/5682745> resize: vertical does not restrict to vertical resize
- fast/css/resize-single-axis-expected.txt: Added.
- fast/css/resize-single-axis.html: Added.
- 1:47 PM Changeset in webkit [44913] by
-
- 3 edits2 adds in trunk
WebCore:
2009-06-21 Sam Weinig <sam@webkit.org>
Reviewed by Eric Seidel
Fix for https://bugs.webkit.org/show_bug.cgi?id=26578
event.currentTarget for listener registered on window should point to the window object like in Firefox
Test: fast/events/event-trace.html
- dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): Make the DOMWindow the currentTarget when events are dispatched to it. We previously used the document because DOMWindow was not yet an EventTarget.
LayoutTests:
2009-06-21 Sam Weinig <sam@webkit.org>
Reviewed by Eric Seidel.
Test for https://bugs.webkit.org/show_bug.cgi?id=26578
event.currentTarget for listener registered on window should point to the window object like in Firefox
- fast/events/event-trace-expected.txt: Added.
- fast/events/event-trace.html: Added.
- 1:16 PM Changeset in webkit [44912] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Sam Weinig.
- fix https://bugs.webkit.org/show_bug.cgi?id=9694 resize value not compared
Test: fast/css/resize-value-compared.html
- rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::operator==): Compare the resize member.
LayoutTests:
Reviewed by Sam Weinig.
- test for https://bugs.webkit.org/show_bug.cgi?id=9694 resize value not compared
- fast/css/resize-value-compared-expected.txt: Added.
- fast/css/resize-value-compared.html: Added.
- 12:19 AM Changeset in webkit [44911] by
-
- 2 edits in trunk/LayoutTests
2009-06-21 Darin Adler <Darin Adler>
- platform/gtk/Skipped: Skip one more test.
Jun 20, 2009:
- 11:19 PM Changeset in webkit [44910] by
-
- 2 edits in trunk/LayoutTests
2009-06-20 Darin Adler <Darin Adler>
- platform/gtk/Skipped: Skip some new tests.
- 11:15 PM Changeset in webkit [44909] by
-
- 2 edits in trunk/WebKit/win
2009-06-20 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
<rdar://problem/6964221> Need more processing of pluginspage.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
- 10:42 PM Changeset in webkit [44908] by
-
- 3 edits3 adds in trunk
WebCore:
2009-06-19 Alice Liu <alice.liu@apple.com>
Fix https://bugs.webkit.org/show_bug.cgi?id=26568
Repro crash animating GIF if previously used in a closed window's back/forward list
Also filed as <rdar://problem/6978362>
Reviewed by Maciej Stachowiak.
Can't test this bug with an automated layout test since it requires b/f caching
- manual-tests/animated-gif-bfcache-crash.html: Added.
- manual-tests/resources/containsAnimatedGif.html: Added.
Adding checks for hostWindow() since there is no guarantee that the Page is alive
- platform/ScrollView.cpp: (WebCore::ScrollView::scrollRectIntoViewRecursively): (WebCore::ScrollView::contentsToScreen): (WebCore::ScrollView::screenToContents): (WebCore::ScrollView::wheelEvent):
LayoutTests:
2009-06-19 Alice Liu <alice.liu@apple.com>
Fix https://bugs.webkit.org/show_bug.cgi?id=26568
Repro crash animating GIF if previously used in a closed window's back/forward list
Also filed as <rdar://problem/6978362>
Reviewed by Maciej Stachowiak.
Adding resource used in WebCore/manual-tests/animated-gif-bfcache-crash.html
- http/tests/misc/resources/animated-gif-with-offsets.gif: Added.
- 7:43 PM Changeset in webkit [44907] by
-
- 2 edits in trunk/WebKit/win
Roll out the Windows portion of r44905 as it broke the build.
- 7:05 PM Changeset in webkit [44906] by
-
- 6 edits in trunk
WebCore:
2009-06-20 Sam Weinig <sam@webkit.org>
Reviewed by Adam Barth.
Fix for https://bugs.webkit.org/show_bug.cgi?id=26554
Shadowing of top and parent
- page/DOMWindow.idl:
LayoutTests:
2009-06-20 Sam Weinig <sam@webkit.org>
Reviewed by Adam Barth.
Test writing to parent and top.
- http/tests/security/cross-frame-access-put-expected.txt:
- http/tests/security/cross-frame-access-put.html:
- http/tests/security/resources/cross-frame-iframe-for-put-test.html:
- 4:07 PM Changeset in webkit [44905] by
-
- 4 edits in trunk/WebKit
WebKit/mac:
2009-06-20 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
<rdar://problem/6964221> Need more processing of pluginspage.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
WebKit/win:
2009-06-20 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
<rdar://problem/6964221> Need more processing of pluginspage.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
- 2:57 PM Changeset in webkit [44904] by
-
- 6 edits in trunk
Reviewed by Gustavo Noronha and Xan Lopez.
[Gtk] Implement DRT XSS auditor support
https://bugs.webkit.org/show_bug.cgi?id=26571
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setXSSAuditorEnabled):
- 2:56 PM Changeset in webkit [44903] by
-
- 3 edits in trunk/WebKit/gtk
2009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha and Xan Lopez.
webkit_web_back_forward_list_add_item() should add a ref for the history item
https://bugs.webkit.org/show_bug.cgi?id=26517
Add a ref to the WebHistoryItem when it's added to the back
forward list through webkit_web_back_forward_list_add_item.
This keeps the history item alive and prevents pywebkitgtk from
crashing
- tests/testwebbackforwardlist.c: (test_webkit_web_history_item_lifetime): (test_webkit_web_back_forward_list_order): (test_webkit_web_back_forward_list_add_item):
- webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_add_item):
- 2:54 PM Changeset in webkit [44902] by
-
- 3 edits2 adds in trunk
Fix <https://bugs.webkit.org/show_bug.cgi?id=15106>.
Bug 15106: REGRESSION: Can't drag text as element when user-select is set to none
Reviewed by Dan Bernstein.
We allow selections to begin within an element that has -webkit-user-select: none set,
unless the element is draggable as dragging should take priority over starting a selection.
Test: editing/selection/user-drag-element-and-user-select-none.html
- dom/Node.cpp:
(WebCore::Node::canStartSelection):
Test for <https://bugs.webkit.org/show_bug.cgi?id=15106>.
Bug 15106: REGRESSION: Can't drag text as element when user-select is set to none
- editing/selection/user-drag-element-and-user-select-none-expected.txt: Added.
- editing/selection/user-drag-element-and-user-select-none.html: Added.
- 1:34 PM Changeset in webkit [44901] by
-
- 5 edits in trunk
WebCore:
2009-06-20 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 26528: REGRESSION (r44674): Assertion in TextIterator::pushFullyClippedState while counting matches for "a" on apple.com
https://bugs.webkit.org/show_bug.cgi?id=26528
rdar://problem/6985329
- editing/TextIterator.cpp: (WebCore::TextIterator::handleReplacedElement): When entering a text control, start at the top of the shadow tree (by calling shadowTreeRootNode). Also remove assumption that innerTextElement will never be 0 since RenderTextControl doesn't really guarantee this.
LayoutTests:
2009-06-20 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 26528: REGRESSION (r44674): Assertion in TextIterator::pushFullyClippedState while counting matches for "a" on apple.com
https://bugs.webkit.org/show_bug.cgi?id=26528
rdar://problem/6985329
- editing/selection/find-in-text-control-expected.txt: Updated to expect finding text in <input type="text"> and <input type="search">, but not in <input type="password">.
- editing/selection/find-in-text-control.html: Added tests for <input> elements as well as <textarea> elements. Also tweaked result output format to accomodate multiple text nodes.
- 11:06 AM Changeset in webkit [44900] by
-
- 2 edits in trunk/JavaScriptCore
Fix namespace comment in SegmentedVector.h
- wtf/SegmentedVector.h: Updated namespace comment to reflect new namespace after r44897.
- 6:27 AM Changeset in webkit [44899] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-20 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Bug 24986: ARM JIT port
<https://bugs.webkit.org/show_bug.cgi?id=24986>
Reviewed by Oliver Hunt.
An Iterator added for SegmentedVector. Currently
only the pre ++ operator is supported.
- wtf/SegmentedVector.h: (WTF::SegmentedVectorIterator::~SegmentedVectorIterator): (WTF::SegmentedVectorIterator::operator*): (WTF::SegmentedVectorIterator::operator->): (WTF::SegmentedVectorIterator::operator++): (WTF::SegmentedVectorIterator::operator==): (WTF::SegmentedVectorIterator::operator!=): (WTF::SegmentedVectorIterator::operator=): (WTF::SegmentedVectorIterator::SegmentedVectorIterator): (WTF::SegmentedVector::alloc): (WTF::SegmentedVector::begin): (WTF::SegmentedVector::end):
- 6:20 AM Changeset in webkit [44898] by
-
- 3 edits1 add in trunk
2009-06-20 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Jan Alonzo.
Initial test case for loading statuses.
- tests/testloading.c: Added. (load_finished_cb): (status_changed_cb): (test_loading_status): (main):
- 6:14 AM Changeset in webkit [44897] by
-
- 8 edits1 move in trunk/JavaScriptCore
2009-06-20 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Bug 24986: ARM JIT port
<https://bugs.webkit.org/show_bug.cgi?id=24986>
Reviewed by Oliver Hunt.
Move SegmentedVector to /wtf subdirectory
and change "namespace JSC" to "namespace WTF"
Additional build file updates by David Kilzer.
- GNUmakefile.am: Updated path to SegmentedVector.h.
- JavaScriptCore.order: Updated SegmentedVector namespace from JSC to WTF in mangled C++ method name.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Removed reference to bytecompiler\SegmentedVector.h.
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Added reference to wtf\SegmentedVector.h.
- JavaScriptCore.xcodeproj/project.pbxproj: Moved SegmentedVector.h definition from bytecompiler subdirectory to wtf subdirectory.
- bytecompiler/BytecodeGenerator.h: Updated #include path to
- SegmentedVector.h and prepended WTF
- namespace to its use.
- parser/Lexer.h: Ditto.
- wtf/SegmentedVector.h: Renamed from JavaScriptCore/bytecompiler/SegmentedVector.h. (WTF::SegmentedVector::SegmentedVector): (WTF::SegmentedVector::~SegmentedVector): (WTF::SegmentedVector::size): (WTF::SegmentedVector::at): (WTF::SegmentedVector::operator[]): (WTF::SegmentedVector::last): (WTF::SegmentedVector::append): (WTF::SegmentedVector::removeLast): (WTF::SegmentedVector::grow): (WTF::SegmentedVector::clear): (WTF::SegmentedVector::deleteAllSegments): (WTF::SegmentedVector::segmentExistsFor): (WTF::SegmentedVector::segmentFor): (WTF::SegmentedVector::subscriptFor): (WTF::SegmentedVector::ensureSegmentsFor): (WTF::SegmentedVector::ensureSegment):
- 5:34 AM Changeset in webkit [44896] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Jan Alonzo.
Fix the ordering in which the new load status goes into the enum
to avoid ABI breakage.
- webkit/webkitwebframe.h:
- 2:48 AM Changeset in webkit [44895] by
-
- 2 edits in trunk/WebCore
2009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by NOBODY.
Speculative Qt build fix - add HTMLDataGridColElement to the build script.
- WebCore.pro:
- 2:20 AM Changeset in webkit [44894] by
-
- 3 edits in trunk/WebCore
2009-06-19 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Remove a memcpy by retrieving the already existing copy of a string
instead of making a new one.
- bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::source):
- bindings/js/StringSourceProvider.h: (WebCore::StringSourceProvider::source):
- 1:11 AM Changeset in webkit [44893] by
-
- 2 edits in trunk/LayoutTests
2009-06-20 Xan Lopez <xlopez@igalia.com>
Skip new accessibility test, we still lack and accessibilityController.
- platform/gtk/Skipped:
- 1:00 AM Changeset in webkit [44892] by
-
- 2 edits in trunk/LayoutTests
2009-06-20 Xan Lopez <xlopez@igalia.com>
We don't seem to support these new HTTP tests either, skip them.
- platform/gtk/Skipped:
- 12:53 AM Changeset in webkit [44891] by
-
- 2 edits in trunk/LayoutTests
2009-06-20 Xan Lopez <xlopez@igalia.com>
Skip test that requires eventSender.
- platform/gtk/Skipped:
Jun 19, 2009:
- 11:21 PM Changeset in webkit [44890] by
-
- 2 edits in trunk/WebKit/win
2009-06-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Steve Falkenburg.
https://bugs.webkit.org/show_bug.cgi?id=26494
Bug 26494: RenderTheme::themeForPage reads from Settings before it has
been initialized by WebKit
Get the shouldPaintNativeControls preference and update the settings
before initializing the page, as the page depends on it after the
themeForPage change.
- WebView.cpp: (WebView::initWithFrame):
- 6:29 PM Changeset in webkit [44889] by
-
- 9 edits in trunk/JavaScriptCore
2009-06-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (build fix take 2 - rename FIELD_OFFSET to something that doesn't conflict with winnt.h).
- jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::emitGetVariableObjectRegister): (JSC::JIT::emitPutVariableObjectRegister):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::compileBinaryArithOp):
- jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCall):
- jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference): (JSC::JIT::checkStructure):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_construct_verify): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emit_op_catch): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emit_op_profile_will_call): (JSC::JIT::emit_op_profile_did_call): (JSC::JIT::emitSlow_op_get_by_val):
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emit_op_method_check): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::compilePutDirectOffset): (JSC::JIT::compileGetDirectOffset): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength):
- jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
- 6:29 PM Changeset in webkit [44888] by
-
- 2 edits in trunk/WebKitTools
2009-06-19 Darin Adler <Darin Adler>
- Scripts/do-webcore-rename: More renaming ideas.
- 6:19 PM Changeset in webkit [44887] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (Windows build fix).
- jit/JIT.h:
- jit/JITInlineMethods.h:
- 6:07 PM Changeset in webkit [44886] by
-
- 12 edits in trunk/JavaScriptCore
2009-06-19 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Reorganize ARM architecture specific macros.
Use PLATFORM_ARM_ARCH(7) instead of PLATFORM(ARM_V7).
Bug 24986: ARM JIT port
<https://bugs.webkit.org/show_bug.cgi?id=24986>
- assembler/ARMv7Assembler.h:
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Imm32::Imm32):
- assembler/MacroAssembler.h:
- assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
- jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReferenceForTrampoline):
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- wtf/Platform.h:
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn):
- 5:52 PM Changeset in webkit [44885] by
-
- 1 edit in trunk/WebKit/win/ChangeLog
Fixed the changelog, copied the same thing into both on accident.
- 5:49 PM Changeset in webkit [44884] by
-
- 6 edits in trunk/JavaScriptCore
2009-06-19 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Fix armv7 JIT build issues.
Unfortunate the arm compiler does not like the use of offsetof on JITStackFrame (since it now contains non POD types),
and the FIELD_OFFSET macro does not appear constantish enough for it to be happy with its use in COMPILE_ASSERT macros.
- Replace offsetofs with FIELD_OFFSETs (safe on C++ objects).
- Move COMPILE_ASSERTs defending layout of JITStackFrame structure on armv7 into JITThunks constructor.
- jit/JIT.cpp:
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_catch):
- jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
- 5:35 PM Changeset in webkit [44883] by
-
- 7 edits1 add in trunk
2009-06-19 Brian Weinstein <bweinstein@apple.com>
Reviewed by Steve Falkenburg.
https://bugs.webkit.org/show_bug.cgi?id=26488
No Support for Single Finger or Two Finger Panning in Windows 7
The code in WebCore allows us to interpret a Pan gesture as
a mousewheel event, and we are able to reuse the scrolling code.
Another constructor was created in WheelEventWin which takes data
better suited to the pan guesture than what was currently there.
Unable to add tests to simulate touch behavior/gestures.
- platform/PlatformWheelEvent.h:
- platform/win/WheelEventWin.cpp:
2009-06-19 Brian Weinstein <bweinstein@apple.com>
Reviewed by Steve Falkenburg.
https://bugs.webkit.org/show_bug.cgi?id=26488
No Support for Single Finger or Two Finger Panning in Windows 7
The code in WebCore allows us to interpret a Pan gesture as
a mousewheel event, and we are able to reuse the scrolling code.
Another constructor was created in WheelEventWin which takes data
better suited to the pan guesture than what was currently there.
Unable to add tests to simulate touch behavior/gestures.
- platform/PlatformWheelEvent.h:
- platform/win/WheelEventWin.cpp:
- 5:27 PM Changeset in webkit [44882] by
-
- 2 edits1 add4 deletes in trunk/LayoutTests
2009-06-19 Ryosuke Niwa <rniwa@google.com>
Reviewed by Maciej Stachowiak.
This fixs the bug 26361. The original test case did not invoke the event that
triggered the actual test. This patch adds code to invoke this event, and also
converts it from a pixel test to a dumpAsText test.
- 4:54 PM Changeset in webkit [44881] by
-
- 2 edits in trunk/WebCore
Fixed a build error, which only shows up in the i386 compile
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::animateTransform):
- 4:35 PM Changeset in webkit [44880] by
-
- 2 edits in trunk/WebCore
2009-06-19 Simon Fraser <Simon Fraser>
Reviewed by Oliver Hunt.
<rdar://problem/6988385> REGRESSION: In full page video player, movie's
video track becomes detached from its controller.
When in the media document, the MediaPlayer should not report that it
is capable of hardware acceleration, because it renders via a QTMovieView
which is already accelerated.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
- 4:14 PM Changeset in webkit [44879] by
-
- 2 edits in trunk/WebCore
Adding XSSAuditor.cpp to the wx build.
- 3:43 PM Changeset in webkit [44878] by
-
- 2 edits in trunk/WebCore
If I am doing a Matrix hardware animation and any matrix is singular, I revert to software.
This is not really testable, since we can't see what the hardware animation is doing.
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::animateTransform):
- 3:32 PM Changeset in webkit [44877] by
-
- 5 edits in trunk/WebCore
2009-06-19 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
An additional fix for Bug 26532: Native functions do not correctly unlink
from optimised callsites when they're collected
<https://bugs.webkit.org/show_bug.cgi?id=26532> | <rdar://problem/6625385>
Use "NativeFunctionWrapper" instead of "PrototypeFunction" in cross-frame
accessors, so the type of object you get to wrap a function is the same,
regardless of whether the access to the function is cross-frame.
This is faster and more idiomatic than what we had before. It also would
have avoided Bug 26532 because it would have prevented a conflicting
PrototypeFunction from being allocated to wrap postMessage, where a
NativeFunctionWrapper had been allocated previously.
- bindings/js/JSDOMBinding.cpp: (WebCore::objectToStringFunctionGetter):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::nonCachingStaticFunctionGetter):
- bindings/js/JSHistoryCustom.cpp: (WebCore::nonCachingStaticBackFunctionGetter): (WebCore::nonCachingStaticForwardFunctionGetter): (WebCore::nonCachingStaticGoFunctionGetter):
- bindings/js/JSLocationCustom.cpp: (WebCore::nonCachingStaticReplaceFunctionGetter): (WebCore::nonCachingStaticReloadFunctionGetter): (WebCore::nonCachingStaticAssignFunctionGetter):
- 3:23 PM Changeset in webkit [44876] by
-
- 2 edits in trunk/WebCore
2009-06-19 Simon Fraser <Simon Fraser>
Reviewed by John Sullivan
<rdar://problem/6953673> Crash in RenderLayerCompositor::setCompositingParent
Fix a crash that could occur in complex content due to timing issues
when doing a partial layer tree rebuild which is required when painting;
setCompositingParent() could be called with a parent which has not been made
compositing yet.
- 3:16 PM Changeset in webkit [44875] by
-
- 2 edits in trunk/WebCore
2009-06-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Build fix. Adding missing HTMLDataGrid* files to the build.
- GNUmakefile.am:
- 2:49 PM Changeset in webkit [44874] by
-
- 7 edits in trunk/WebCore
2009-06-19 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26460 part three
Make BMPImageReader a standalone class that is used by ICOImageDecoder
and BMPImageDecoder to decode individual BMPs within a file. These
decoders now inherit directly from ImageDecoder.
This also makes these decoders decode on-demand in isSizeAvailable() and
frameBufferAtIndex(), like the other decoders, instead of when setData()
is called, like before. This should provide a speedup on pages
containing BMPs that aren't immediately onscreen.
- platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::BMPImageDecoder): (WebCore::BMPImageDecoder::setData): (WebCore::BMPImageDecoder::isSizeAvailable): (WebCore::BMPImageDecoder::frameBufferAtIndex): (WebCore::BMPImageDecoder::decodeWithCheckForDataEnded): (WebCore::BMPImageDecoder::decode): (WebCore::BMPImageDecoder::processFileHeader):
- platform/image-decoders/bmp/BMPImageDecoder.h: (WebCore::BMPImageDecoder::readUint32):
- platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::BMPImageReader): (WebCore::BMPImageReader::decodeBMP): (WebCore::BMPImageReader::readInfoHeaderSize): (WebCore::BMPImageReader::processInfoHeader): (WebCore::BMPImageReader::readInfoHeader): (WebCore::BMPImageReader::processBitmasks): (WebCore::BMPImageReader::processColorTable): (WebCore::BMPImageReader::processRLEData): (WebCore::BMPImageReader::processNonRLEData): (WebCore::BMPImageReader::setFailed):
- platform/image-decoders/bmp/BMPImageReader.h: (WebCore::BMPImageReader::readUint16): (WebCore::BMPImageReader::readUint32): (WebCore::BMPImageReader::setBuffer): (WebCore::BMPImageReader::setData): (WebCore::BMPImageReader::): (WebCore::BMPImageReader::pastEndOfImage): (WebCore::BMPImageReader::readCurrentPixel): (WebCore::BMPImageReader::setRGBA):
- platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::setData): (WebCore::ICOImageDecoder::isSizeAvailable): (WebCore::ICOImageDecoder::size): (WebCore::ICOImageDecoder::frameBufferAtIndex): (WebCore::ICOImageDecoder::decodeWithCheckForDataEnded): (WebCore::ICOImageDecoder::decode): (WebCore::ICOImageDecoder::processDirectory): (WebCore::ICOImageDecoder::processDirectoryEntries): (WebCore::ICOImageDecoder::readDirectoryEntry): (WebCore::ICOImageDecoder::processImageType):
- platform/image-decoders/ico/ICOImageDecoder.h: (WebCore::ICOImageDecoder::readUint16): (WebCore::ICOImageDecoder::readUint32):
- 2:31 PM Changeset in webkit [44873] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-19 Adam Treat <adam.treat@torchmobile.com>
Blind attempt at build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 2:09 PM Changeset in webkit [44872] by
-
- 1 add in trunk/WebCore/html/HTMLDataGridElement.cpp
Add missed file.
- 2:07 PM Changeset in webkit [44871] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-19 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Oliver Hunt.
Inherits CallIdentifier struct from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/profiler/CallIdentifier.h:86.
- wtf/HashCountedSet.h:
- 1:57 PM Changeset in webkit [44870] by
-
- 6 edits6 adds in trunk
2009-06-19 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=26540
Currently the SunSpider test driver lacks an option to run a test suite that
will test JavaScriptCore parsing performance only. This patch adds just such
a test suite and option to SunSpider as well as the jsc test shell. I've included
three large javascript source files found in the wild: jquery, mootools and prototype.
Combined with the concatenation of all three, these form a new testsuite to measure
and test pure JavaScriptCore parsing performance.
- 1:38 PM Changeset in webkit [44869] by
-
- 6 edits in trunk/WebCore
2009-06-19 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Fix the Chromium canary bot. Turns out ScriptSourceCode doesn't have
the same API in V8 and JSC.
- WebCore/bindings/js/ScriptController.cpp:
- WebCore/bindings/js/ScriptSourceCode.h:
- WebCore/bindings/v8/ScriptController.cpp:
- WebCore/page/XSSAuditor.cpp:
- WebCore/page/XSSAuditor.h:
- 1:30 PM Changeset in webkit [44868] by
-
- 3 edits1 add in trunk
009-06-19 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Inherits HashCountedSet class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Collector.cpp:1095.
- wtf/HashCountedSet.h:
- 1:17 PM Changeset in webkit [44867] by
-
- 16 edits3 adds in trunk
WebCore:
2009-06-19 David Hyatt <hyatt@apple.com>
Reviewed by Anders Carlsson.
Implement the IDL interface for HTMLDataGridColElement.
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- html/HTMLAttributeNames.in:
- html/HTMLDataGridColElement.cpp: Added. (WebCore::HTMLDataGridColElement::HTMLDataGridColElement): (WebCore::HTMLDataGridColElement::label): (WebCore::HTMLDataGridColElement::setLabel): (WebCore::HTMLDataGridColElement::type): (WebCore::HTMLDataGridColElement::setType): (WebCore::HTMLDataGridColElement::sortable): (WebCore::HTMLDataGridColElement::setSortable): (WebCore::HTMLDataGridColElement::sortDirection): (WebCore::HTMLDataGridColElement::setSortDirection): (WebCore::HTMLDataGridColElement::selected): (WebCore::HTMLDataGridColElement::setSelected):
- html/HTMLDataGridColElement.h: Added. (WebCore::HTMLDataGridColElement::endTagRequirement): (WebCore::HTMLDataGridColElement::tagPriority):
- html/HTMLDataGridColElement.idl: Added.
- html/HTMLDataGridElement.h:
- html/HTMLElementsAllInOne.cpp:
- html/HTMLTagNames.in:
- page/DOMWindow.idl:
LayoutTests:
2009-06-19 David Hyatt <hyatt@apple.com>
Reviewed by Anders Carlsson.
Implement the IDL interface for HTMLDataGridColELement.
- fast/dom/Window/window-properties-expected.txt:
- fast/js/global-constructors-expected.txt:
- 1:09 PM Changeset in webkit [44866] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-19 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=26558
Declare these symbols extern for WINCE as they are provided by libce.
- runtime/DateConstructor.cpp:
- runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
- 12:54 PM Changeset in webkit [44865] by
-
- 2 edits in trunk/WebCore
2009-06-19 Chris Evans <scarybeasts@gmail.com>
Reviewed by Eric Seidel.
There is no new test because this cannot be tested deterministically.
I've not been able to cause a crash at all in the test framework, but
I have verified that this is happening in the wild and that the patch
fixes the likely cause in the debugger.
- loader/TextResourceDecoder.cpp: careful not to iterate off the end of our input buffer looking for the end of the comment.
- 12:37 PM Changeset in webkit [44864] by
-
- 4 edits in trunk
Versioning.
- 12:35 PM Changeset in webkit [44863] by
-
- 1 copy in tags/Safari-6531
New tag.
- 11:48 AM Changeset in webkit [44862] by
-
- 2 edits in trunk/JavaScriptCore
<rdar://problem/6988973> ScopeChain leak in interpreter builds
Reviewed by Maciej Stachowiak
Move the Scopechain destruction code in JSFunction outside of the ENABLE(JIT)
path.
- 11:25 AM Changeset in webkit [44861] by
-
- 3 edits in trunk/WebCore
2009-06-19 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Fix external-script-URL-location.html and
write-external-script-open.html LayoutTests.
implicitOpen is called from several places. We need to setXSSAuditor
each time, so I moved the call inside implicitOpen.
- dom/Document.cpp: (WebCore::Document::open): (WebCore::Document::implicitOpen):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::begin):
- 11:22 AM Changeset in webkit [44860] by
-
- 2 edits in trunk/WebCore
2009-06-19 Kent Tamura <tkent@chromium.org>
Reviewed by David Levin.
Use WebCore::multipleFileUploadText() in Chromium to fix a problem
that Chromium shows only the first filename even if a user selects
multiple files for <input type=file multiple>.
<https://bugs.webkit.org/show_bug.cgi?id=26502>
- platform/chromium/FileChooserChromium.cpp: (WebCore::FileChooser::basenameForWidth):
- 11:14 AM Changeset in webkit [44859] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/6967596> Safari hung using 100% CPU when I tried to look up a word in Dictionary using command-control-d
Test: editing/selection/move-by-line-005.html
The root cause of this bug was searchAheadForBetterMatch() continuing
past the first rendered text object after the given object. While we
want to skip non-rendered text and empty containers, when we encounter
rendered text object, we must return a text box for that object.
- dom/Position.cpp: (WebCore::searchAheadForBetterMatch):
LayoutTests:
Reviewed by Dave Hyatt.
- text for <rdar://problem/6967596> Safari hung using 100% CPU when I tried to look up a word in Dictionary using command-control-d
- editing/selection/move-by-line-005-expected.txt: Added.
- editing/selection/move-by-line-005.html: Added.
- 10:46 AM Changeset in webkit [44858] by
-
- 2 edits1 add in trunk/WebCore
2009-06-18 Jungshik Shin <jshin@chromium.org>
Reviewed by David Levin
Chromium Linux port does not handle non-BMP characters properly.
It's fixed with a 'UTF-16 iterator macro' to extract Unicode
codepoints out of a UTF-16 input string.
A manual test is added for non-BMP character rendering,
which we can use until a small freely-distributable font
covering non-BMP is added to the Webkit source tree.
- platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
- manual-tests/non-bmp.html: Added.
- 10:01 AM Changeset in webkit [44857] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-19 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=26543
Windows CE uses 'GetLastError' instead of 'errno.'
- interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile): (JSC::RegisterFile::grow):
- 9:52 AM Changeset in webkit [44856] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Anders Carlsson.
- update test results after r44806
- platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
- 8:47 AM Changeset in webkit [44855] by
-
- 3 edits in trunk/WebCore
2009-06-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Dimitri Glazkov.
V8 Bindings: return proper state from the script stack.
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
- bindings/v8/ScriptCallStack.h: (WebCore::ScriptCallStack::state):
- 8:34 AM Changeset in webkit [44854] by
-
- 2 edits in trunk/WebCore
2009-06-19 Jessie Berlin <jberlin@apple.com>
Reviewed by Simon Fraser.
Windows build fix.
- platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
- 7:28 AM Changeset in webkit [44853] by
-
- 3 edits in trunk/WebCore
2009-06-19 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Simon Hausmann.
Build fix after 44825.
- platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::isSizeAvailable):
- platform/graphics/qt/ImageDecoderQt.h:
- 5:18 AM Changeset in webkit [44852] by
-
- 2 edits in trunk/WebKit/qt
2009-06-19 Daniel Teske <qt-info@nokia.com>
Reviewed by Simon Hausmann.
Remove warnings for QString() constructions from const char *
By explicitly wrapping it with QLatin1String() / QLatin1Char()
- 2:58 AM Changeset in webkit [44851] by
-
- 2 edits in trunk/WebKitTools
2009-06-15 Andre Pedralho <andre.pedralho@openbossa.org>
Reviewed by Tor Arne Vestbø.
Only pass --makeargs along if an argument is given.
- 2:23 AM Changeset in webkit [44850] by
-
- 6 edits in trunk
2009-06-18 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Oliver Hunt.
Bug 26426: Canvas: rotation of 'no-repeat' pattern is weird
<https://bugs.webkit.org/show_bug.cgi?id=26426>
Use 1<<23-1 as steps of no-repeat patterns instead of 100000000.0f.
The original number cannot be represented by mantissa of float
(23bit) so that it caused some error.
Test: fast/canvas/image-object-in-canvas.html:
- platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
- 2:06 AM Changeset in webkit [44849] by
-
- 1 edit in trunk/WebCore/bindings/v8/ScriptController.cpp
Fix copy/paste error.
- 1:57 AM Changeset in webkit [44848] by
-
- 4 edits in trunk/WebCore
2009-06-19 abarth <abarth@webkit.org>
Unreviewed attempt to fix the Chromium build.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluate):
- bindings/v8/ScriptController.h: (WebCore::ScriptController::xssAuditor):
- bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
- 1:29 AM Changeset in webkit [44847] by
-
- 3 edits in trunk/WebKitTools
2009-06-19 Adam Barth <abarth@webkit.org>
Unreviewed attempt to fix Windows build.
- DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setXSSAuditorEnabled):
- 1:12 AM Changeset in webkit [44846] by
-
- 35 edits7 adds in trunk
WebCore:
2009-06-18 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Added an experimental reflective XSS filter. The filter is disabled by
default.
Test: http/tests/security/xssAuditor/script-tag.html
- GNUmakefile.am:
- WebCore.base.exp:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluate):
- bindings/js/ScriptController.h: (WebCore::ScriptController::xssAuditor):
- bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
- dom/Tokenizer.h: (WebCore::Tokenizer::xssAuditor): (WebCore::Tokenizer::setXSSAuditor): (WebCore::Tokenizer::Tokenizer):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::requestObject):
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setXSSAuditorEnabled):
- page/Settings.h: (WebCore::Settings::xssAuditorEnabled):
- page/XSSAuditor.cpp: Added. (WebCore::isControlCharacter): (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::~XSSAuditor): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::decodeURL): (WebCore::XSSAuditor::findInRequest):
- page/XSSAuditor.h: Added. (WebCore::XSSAuditor::isEnabled): (WebCore::XSSAuditor::setXSSAuditorEnabled):
WebKit/mac:
2009-06-18 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Added preference to enable the XSSAuditor.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences isXSSAuditorEnabled]): (-[WebPreferences setXSSAuditorEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
WebKit/win:
2009-06-18 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Added preference to enable the XSSAuditor.
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::isXSSAuditorEnabled): (WebPreferences::setXSSAuditorEnabled):
- WebPreferences.h:
- WebView.cpp: (WebView::notifyPreferencesChanged):
WebKitTools:
2009-06-18 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Add support for testing the XSSAuditor.
- DumpRenderTree/LayoutTestController.cpp: (setXSSAuditorEnabledCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setXSSAuditorEnabled):
- DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setXSSAuditorEnabled):
- DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setXSSAuditorEnabled): (LayoutTestController::setPopupBlockingEnabled):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setXSSAuditorEnabled):
LayoutTests:
2009-06-18 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Added a basic test for the XSSAuditor.
- http/tests/security/xssAuditor/resources/echo-intertag.php: Added.
- http/tests/security/xssAuditor/script-tag-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag.html: Added.
- 12:59 AM Changeset in webkit [44845] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-19 David Levin <levin@chromium.org>
Reviewed by NOBODY (Windows build fix).
Add export for Windows corresponding to OSX export done in r44844.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 12:10 AM Changeset in webkit [44844] by
-
- 11 edits in trunk/JavaScriptCore
Bug 26532: Native functions do not correctly unlink from optimised callsites when they're collected
<https://bugs.webkit.org/show_bug.cgi?id=26532> <rdar://problem/6625385>
Reviewed by Gavin "Viceroy of Venezuela" Barraclough.
We need to make sure that each native function instance correctly unlinks any references to it
when it is collected. Allowing this to happen required a few changes:
- Every native function needs a codeblock to track the link information
- To have this codeblock, every function now also needs its own functionbodynode so we no longer get to have a single shared instance.
- Identifying a host function is now done by looking for CodeBlock::codeType() == NativeCode
