Timeline
Aug 7, 2009:
- 11:08 PM Changeset in webkit [46951] by
-
- 2 edits in trunk/WebCore
Gtk build fix - add html/canvas to the binding generator's include path
- 10:17 PM Changeset in webkit [46950] by
-
- 1 edit3 adds in trunk/LayoutTests
Test function declaration parsing
Reviewed by Cameron Zwarich
- 9:42 PM Changeset in webkit [46949] by
-
- 2 edits in trunk/WebKit/mac
2009-08-07 Simon Fraser <Simon Fraser>
Fix the build on 10.6.
- WebView/WebHTMLView.mm: (-[WebHTMLView attachRootLayer:]):
- 9:14 PM Changeset in webkit [46948] by
-
- 2 edits in trunk/WebKit/mac
2009-08-07 Simon Fraser <Simon Fraser>
Fix a stylistic nit related to the location of the *, which, for some
ridiculous reason, WebKit style dictates to be different between Objective-C and C++.
- WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
- 9:08 PM Changeset in webkit [46947] by
-
- 4 edits in trunk/WebKit/mac
2009-08-07 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Work around an issue on Leopard where composited layers are misplaced and squished when the page
gets over 4096px tall.
https://bugs.webkit.org/show_bug.cgi?id=27272
<rdar://problem/7067892> [Leopard] Composisted layers are misplaced and squished on on long pages
<rdar://problem/7068252> [Leopard] When switching to a tab with HW layers, they fade in
- WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView reflectScrolledClipView:]): Call -_updateLayerHostingViewPosition after scrolling.
- WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]): Call -_updateLayerHostingViewPosition after the view changes size.
(-[WebHTMLView attachRootLayer:]):
Turn off default animations, to avoid animations of sublayer transform, and fading-in
when tab switching.
- WebView/WebHTMLViewInternal.h: (-[WebHTMLView _updateLayerHostingViewPosition]): New method that constrains the height of the layer-hosting view to a max height of 4096px, and compensates for the height restriction by placing the layer-hosting view at the top of the visible part of the WebHTMLView, and adjusting the position of the hosted layers via sublayer transform.
- 8:31 PM Changeset in webkit [46946] by
-
- 2 edits in trunk/LayoutTests
2009-08-07 Jan Michael Alonzo <jmalonzo@webkit.org>
[Gtk] Skip two new tests (from r46896) needing gtk-specific results.
- platform/gtk/Skipped:
- 8:06 PM Changeset in webkit [46945] by
-
- 2 edits in trunk/WebKitSite
2009-08-07 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Oliver Hunt.
Fix webkit-jobs link
- contact.html:
- 7:33 PM Changeset in webkit [46944] by
-
- 2 edits in trunk/WebKitTools
Unreviewed Gtk build fix
- 7:22 PM Changeset in webkit [46943] by
-
- 3 edits in trunk/WebCore
Another windows build fix attempt
- 7:11 PM Changeset in webkit [46942] by
-
- 2 edits in trunk/WebCore
Windows build fix
- 6:57 PM Changeset in webkit [46941] by
-
- 2 edits in trunk/WebCore
2009-08-07 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix - add html/canvas to the include path.
- GNUmakefile.am:
- 6:43 PM Changeset in webkit [46940] by
-
- 2 edits in trunk/WebCore
Prospective build fix for Qt following r46937.
Patch by Adam Treat <adam.treat@torchmobile.com> on 2009-08-07
- WebCore.pro:
- 6:25 PM Changeset in webkit [46939] by
-
- 2 edits in trunk/WebCore
2009-08-07 Yong Li <yong.li@torchmobile.com>
WINCE PORT: store only width for GlyphBufferAdvance, to save space on low-memory devices
https://bugs.webkit.org/show_bug.cgi?id=27734
- platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::advanceData): (WebCore::GlyphBuffer::add):
- 6:24 PM Changeset in webkit [46938] by
-
- 2 edits in trunk/WebCore
2009-08-07 Yong Li <yong.li@torchmobile.com>
Reviewed by Eric Seidel.
WINCE PORT: pass unrecognized glyphs to GDI to handle
https://bugs.webkit.org/show_bug.cgi?id=27734
- platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter):
- 6:01 PM Changeset in webkit [46937] by
-
- 8 edits14 moves1 add in trunk/WebCore
Move Canvas related file to a subdirectories
https://bugs.webkit.org/show_bug.cgi?id=28026
- 5:54 PM Changeset in webkit [46936] by
-
- 2 edits in trunk/WebCore
2009-08-07 Szabo Carol <carol.szabo@nokia.com>
Reviewed by David Hyatt.
QtWebkit ignores letter-spacing and word-spacing styles.
QtWebkit handles custom letter-spacing and word-spacing in the native QFont
class, but the values for these options are not not passed on from
the platform independent part of the Font class.
Fixed QtWebkit behavior by applying the options to QFont when it is
returned via Font::font()
LayoutTests:
fast/css/word-space-extra.html
css2.1/t1604-c542-letter-sp-00-b-a.html
css2.1/t1604-c541-word-sp-01-b-a.html
css1/text_properties/word_spacing.html
- platform/graphics/qt/FontQt.cpp: (WebCore::Font::font):
- 5:52 PM Changeset in webkit [46935] by
-
- 3 edits in trunk/WebCore
2009-08-07 Nicolas Weber <thakis@chromium.org>
Reviewed by Darin Adler.
Use correct highlight color for listboxes and completion popups.
- rendering/RenderThemeChromiumMac.h:
- rendering/RenderThemeChromiumMac.mm: Rename activeListBoxSelectionBackgroundColor to platformActiveListBoxSelectionBackgroundColor, so that it actually overrides a virtual method.
- 5:48 PM Changeset in webkit [46934] by
-
- 1 edit4 adds in trunk/WebCore
2009-08-07 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
Added a fourth bunch of Haiku-specific files for WebCore.
https://bugs.webkit.org/show_bug.cgi?id=26988
- platform/haiku/PasteboardHaiku.cpp: Added. (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::generalPasteboard): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::clear):
- platform/haiku/PlatformKeyboardEventHaiku.cpp: Added. (WebCore::keyIdentifierForHaikuKeyCode): (WebCore::windowsKeyCodeForKeyEvent): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): (WebCore::PlatformKeyboardEvent::currentCapsLockState):
- platform/haiku/PlatformMouseEventHaiku.cpp: Added. (WebCore::PlatformMouseEvent::PlatformMouseEvent):
- platform/haiku/PlatformWheelEventHaiku.cpp: Added. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- 5:41 PM Changeset in webkit [46933] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-07 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Eric Seidel.
Allow custom memory allocation control for Noncopyable class
https://bugs.webkit.org/show_bug.cgi?id=27879
Several classes which are inherited from Noncopyable are instantiated by
operator new, so Noncopyable class has been inherited from FastAllocBase.
- wtf/Noncopyable.h:
2009-08-07 George Staikos <george.staikos@torchmobile.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=27305
Implement WinCE-specific unicode layer.
Written by George Staikos <george.staikos@torchmobile.com>
with bug fixes by Yong Li <yong.li@torchmobile.com>
refactored by Joe Mason <joe.mason@torchmobile.com>
- wtf/Platform.h:
- wtf/unicode/Unicode.h:
- wtf/unicode/wince/UnicodeWince.cpp: Added. (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::foldCase): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isSpace): (WTF::Unicode::isLetter): (WTF::Unicode::isUpper): (WTF::Unicode::isLower): (WTF::Unicode::isDigit): (WTF::Unicode::isPunct): (WTF::Unicode::toTitleCase): (WTF::Unicode::direction): (WTF::Unicode::category): (WTF::Unicode::decompositionType): (WTF::Unicode::combiningClass): (WTF::Unicode::mirroredChar): (WTF::Unicode::digitValue):
- wtf/unicode/wince/UnicodeWince.h: Added. (WTF::Unicode::): (WTF::Unicode::isSeparatorSpace): (WTF::Unicode::isHighSurrogate): (WTF::Unicode::isLowSurrogate): (WTF::Unicode::isArabicChar): (WTF::Unicode::hasLineBreakingPropertyComplexContext): (WTF::Unicode::umemcasecmp): (WTF::Unicode::surrogateToUcs4):
- 5:06 PM Changeset in webkit [46932] by
-
- 2 edits in trunk/LayoutTests
- platform/gtk/Skipped: Skip a newly-failing test. I filed a bug about it too.
- 5:03 PM Changeset in webkit [46931] by
-
- 2 edits in trunk/WebCore
2009-08-07 Nicolas Weber <thakis@chromium.org>
Teach WebKit how to decode jpegs in cmyk and ycck color spaces.
Heavily inspired by Firefox's take on this issue.
Reviewed by Eric Seidel.
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode): Tell jpeglib to convert ycck to cmyk and keep cmyk. (WebCore::convertCMYKToRGBA): Added function to convert cmyk to rgb. (WebCore::convertRGBToRGBA): Extracted existing conversion logic into its own function. (WebCore::JPEGImageDecoder::outputScanlines): Call convertCMYKToRGBA for cmyk images, convertRGBToRGBA for rgb images.
- 5:03 PM Changeset in webkit [46930] by
-
- 2 edits in trunk/LayoutTests
- platform/gtk/Skipped: Updated since textarea-arrow-navigation.html moved.
- 5:02 PM Changeset in webkit [46929] by
-
- 2 edits in trunk/LayoutTests
2009-08-07 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Mark Rowe.
Add http/tests/misc/favicon-loads-with-images-disabled.html to get the
Windows Debug bot back green.
- platform/win/Skipped:
- 4:51 PM Changeset in webkit [46928] by
-
- 1 edit4 adds in trunk
2009-07-30 Martin Robinson <mrobinson@appcelerator.com>
Reviewed by Xan Lopez, Gustavo Noronha and Jan Alonzo.
[GTK] new-window-policy-decision-requested provides no information about the target frame
https://bugs.webkit.org/show_bug.cgi?id=27792
Add frameName property to the WebKitWebNavigation object.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::getNavigationAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
- webkit/webkitwebnavigationaction.cpp: (webkit_web_navigation_action_get_property): (webkit_web_navigation_action_set_property): (webkit_web_navigation_action_class_init): (webkit_web_navigation_action_get_target_frame): (webkit_web_navigation_action_set_target_frame):
- webkit/webkitwebnavigationaction.h:
- 4:34 PM Changeset in webkit [46927] by
-
- 2 edits in trunk/WebKitTools
- Scripts/commit-log-editor: Fix unchecked access to environment
variable that may not be there.
- 4:25 PM Changeset in webkit [46926] by
-
- 16 edits2 moves1 add5 deletes in trunk/LayoutTests
"Shadow tree" DOM nodes are being accidentally exposed to JavaScript
https://bugs.webkit.org/show_bug.cgi?id=28086
Patch by Darin Adler <Darin Adler> on 2009-08-07
Reviewed by Adele Peterson.
Rewrite tests that depend on selection inside <input> and <textarea> elements
from showing up with getSelection(), since does not match Firefox and needs to
change soon.
- editing/deleting/delete-ligature-002-expected.txt: Updated.
- editing/deleting/delete-ligature-002.html: Changed to use a contenteditable
<div> element instead of a <textarea> element.
- editing/deleting/delete-ligature-003-expected.txt: Updated.
- editing/deleting/delete-ligature-003.html: Changed to use a contenteditable
<div> element instead of a <textarea> element.
- editing/deleting/skip-virama-001-expected.txt: Updated.
- editing/deleting/skip-virama-001.html: Changed to use a contenteditable
<div> element instead of a <textarea> element.
- editing/input/textarea-arrow-navigation-expected.txt: Moved to fast/forms.
- editing/input/textarea-arrow-navigation.html: Ditto.
- editing/inserting/insert-thai-characters-001-expected.txt: Updated.
- editing/inserting/insert-thai-characters-001.html: Changed to use a contenteditable
<div> element instead of a <textarea> element.
- editing/selection/5213963-expected.txt: Added. This is now a text-only test.
- editing/selection/5213963.html: Added a call to dumpAsText(). Changed selection
testing to use selectionEnd instead of getSelection().type.
- editing/selection/find-in-text-control-expected.txt: Updated.
- editing/selection/find-in-text-control.html: Changed test to distinguish the
different text controls. Made it use activeElement to find out if the selection
is inside a control.
- editing/selection/move-begin-end-expected.txt: Updated.
- editing/selection/move-begin-end.html: Changed to use a contenteditable
<div> element instead of a <textarea> element.
- editing/text-iterator/thai-cursor-movement-expected.txt: Updated.
- editing/text-iterator/thai-cursor-movement.html: Changed to use a contenteditable
<div> element instead of a <textarea> element.
- fast/forms/textarea-arrow-navigation-expected.txt: Moved from editing/input since
this is a <textarea> test, not a general editing test.
- fast/forms/textarea-arrow-navigation.html: Ditto.
Changed to use eventSender instead of the editing machinery to test the down arrow.
- platform/mac/editing/selection/5213963-expected.checksum: Removed.
This is now a text-only test.
- platform/mac/editing/selection/5213963-expected.png: Ditto.
- platform/mac/editing/selection/5213963-expected.txt: Ditto.
- platform/qt/editing/selection/5213963-expected.txt: Ditto.
- platform/win/editing/selection/5213963-expected.txt: Ditto.
- 4:24 PM Changeset in webkit [46925] by
-
- 6 edits2 adds in trunk
WebCore:
2009-08-07 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
SharedWorkers should be shared
https://bugs.webkit.org/show_bug.cgi?id=28058
Added tracking of shared workers to the SharedWorkerRepository.
- workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerProxy::create): Changed SharedWorkerProxy to derive from ThreadSafeShared, as it needs to outlive the repository (if closed while some documents are still loading). (WebCore::SharedWorkerProxy::thread): (WebCore::SharedWorkerProxy::closing): Added flag used to determine whether the worker has closed itself while loading. (WebCore::SharedWorkerProxy::url): (WebCore::SharedWorkerProxy::name): Proxy now tracks worker URL and name to allow validity checks per section 4.8.3 of the WebWorkers spec. (WebCore::SharedWorkerProxy::SharedWorkerProxy): (WebCore::SharedWorkerProxy::addToDocumentSet): Added API to track the document set for a worker to allow worker shutdown. Currently does nothing. (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader): Renamed SharedWorkerLoader to be SharedWorkerScriptLoader for clarity. (WebCore::SharedWorkerScriptLoader::load): (WebCore::SharedWorkerScriptLoader::notifyFinished): (WebCore::DefaultSharedWorkerRepository::instance): (WebCore::DefaultSharedWorkerRepository::workerScriptLoaded): Now handles "worker already loaded" case. (WebCore::SharedWorkerRepository::connect): Delegates to DefaultSharedWorkerRepository::connectToWorker (WebCore::DefaultSharedWorkerRepository::connectToWorker): Added code to track the SharedWorkerProxy in a map, and to handle the "worker already loaded" case. (WebCore::DefaultSharedWorkerRepository::getProxy): Atomic get-or-create operation on the internal tracking HashMap.
- workers/DefaultSharedWorkerRepository.h:
- workers/SharedWorker.cpp: (WebCore::SharedWorker::SharedWorker):
- workers/SharedWorkerRepository.h: Removed instance() API and made constructor private to prevent instantiation. (WebCore::SharedWorkerRepository::SharedWorkerRepository):
LayoutTests:
2009-08-07 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
SharedWorkers should be shared
https://bugs.webkit.org/show_bug.cgi?id=28058
Added tracking to the SharedWorkerRepository so instances of SharedWorkers are shared across pages.
- fast/workers/shared-worker-shared-expected.txt: Added.
- fast/workers/shared-worker-shared.html-disabled: Added sharing test.
- 4:14 PM Changeset in webkit [46924] by
-
- 1 edit4 adds in trunk/WebCore
2009-08-07 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
Added four Haiku-specific files for WebCore:
PopupMenuHaiku.cpp, ScreenHaiku.cpp,
SearchPopupMenuHaiku.cpp and SoundHaiku.cpp
https://bugs.webkit.org/show_bug.cgi?id=28080
- platform/haiku/PopupMenuHaiku.cpp: Added. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural):
- platform/haiku/ScreenHaiku.cpp: Added. (WebCore::screenRect): (WebCore::screenAvailableRect): (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome):
- platform/haiku/SearchPopupMenuHaiku.cpp: Added. (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches): (WebCore::SearchPopupMenu::enabled):
- platform/haiku/SoundHaiku.cpp: Added. (WebCore::systemBeep):
- 4:14 PM Changeset in webkit [46923] by
-
- 1 edit2 adds in trunk/WebCore
2009-08-07 Maxime Simon <Maxime Simon>
Reviewed by Eric Seidel.
Added two Haiku-specific files to WebCore:
TemporaryLinkStubs.cpp and WidgetHaiku.cpp
https://bugs.webkit.org/show_bug.cgi?id=28080
- platform/haiku/TemporaryLinkStubs.cpp: Added. (loadResourceIntoArray): (WebCore::historyContains): (WebCore::supportedKeySizes): (WebCore::signedPublicKeyAndChallengeString): (WebCore::userIdleTime): (WebCore::callOnMainThread): (WebCore::SharedBuffer::createWithContentsOfFile): (WebCore::KURL::fileSystemPath): (WebCore::getSupportedKeySizes):
- platform/haiku/WidgetHaiku.cpp: Added. (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect): (WebCore::Widget::setFocus): (WebCore::Widget::setCursor): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::paint): (WebCore::Widget::setIsSelected):
- 4:12 PM Changeset in webkit [46922] by
-
- 4 edits in trunk/WebCore
2009-08-07 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Fix the problem that isAttribute is set to false for onerror and
onmessage in worker custom code.
https://bugs.webkit.org/show_bug.cgi?id=28083
- bindings/v8/custom/V8AbstractWorkerCustom.cpp: (WebCore::getEventListener): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::ACCESSOR_SETTER):
- bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::getEventListener): (WebCore::ACCESSOR_SETTER):
- 4:11 PM Changeset in webkit [46921] by
-
- 3 edits in trunk/WebCore
2009-08-07 Vitaly Repeshko <vitalyr@quad.spb.corp.google.com>
Reviewed by Dimitri Glazkov.
V8 bindings: speed up lookupDOMWrapper by using new V8 API function.
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::lookupDOMWrapper):
- 4:05 PM Changeset in webkit [46920] by
-
- 5 edits8 adds in trunk
WebCore: selectionHasStyle doesn't handle text-specific properties properly
https://bugs.webkit.org/show_bug.cgi?id=27858
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-07
Reviewed by Justin Garcia.
This patch modifies selectionHasStyle so that it returns TrueTriState when text styles
(text-decoration, font-style, font-weight, & color) are present in all text nodes,
regardless of whether the style is also present in their ancestor nodes or not.
e.g. New behavior concludes that <b><i>hello</i><i>world</i></b> has italic style.
WebKit now applies the text styles (bold, italic, etc) if the specified style was not present on
at least one text node, rather than at the beginning of selection except on Mac.
On Mac, WebKit applies the text style if the style was not present at the beginning of style.
Test: editing/execCommand/toggle-compound-styles.html
- editing/ApplyStyleCommand.cpp:
(WebCore::getPropertiesNotInComputedStyle): bug fix, must use copy instead of makeMutable for a mutable style.
- editing/Editor.cpp:
(WebCore::):
(WebCore::triStateOfStyleInComputedStyle): Added a boolean type to ignore text-specific styles
(WebCore::Editor::selectionHasStyle): Ignores text-specific styles for all but text nodes
- editing/EditorCommand.cpp:
(WebCore::executeToggleStyle): Uses selectionHasStyle instead of selectionStartHasStyle
LayoutTests: selectionHasStyle doesn't handle text-specific properties properly
https://bugs.webkit.org/show_bug.cgi?id=27858
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-07
Reviewed by Justin Garcia.
This patch adds toggle-compound-styles to make sure WebKit can handle nested text styles
such as <b><i>hello</i>world</b> (italicized) and <b><i>hello</i>world</b> (not italicized)
on all platforms except on Mac (to match TextEdit's behavior).
- editing/execCommand/resources/toggle-compound-styles.js: Added.
(testSingleToggle):
- editing/execCommand/toggle-compound-styles.html: Added.
- platform/gtk/editing/execCommand: Added.
- platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt: Added.
- platform/mac/editing/execCommand/toggle-compound-styles-expected.txt: Added.
- platform/qt/editing/execCommand/toggle-compound-styles-expected.txt: Added.
- platform/win/editing/execCommand: Added.
- platform/win/editing/execCommand/toggle-compound-styles-expected.txt: Added.
- 3:36 PM Changeset in webkit [46919] by
-
- 2 edits in trunk/WebCore
2009-08-07 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Do not register V8 error message listener in WorkerContextExecutionProxy.
https://bugs.webkit.org/show_bug.cgi?id=28082
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
- 3:25 PM Changeset in webkit [46918] by
-
- 2 edits in trunk/WebCore
2009-08-07 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
Cairo-based Windows port does not handle cookies properly
https://bugs.webkit.org/show_bug.cgi?id=27414
curl handles cookies by itself, so using WinINet functions
to get and set cookies is wrong.
Replace CookieJarWin.cpp with CookieJarCurl.cpp so that
cookies can be implemented later once curl provides an API to
get and set cookies.
- WebCore.vcproj/WebCore.vcproj:
- 3:09 PM Changeset in webkit [46917] by
-
- 9 edits1 add in trunk/WebCore
2009-08-07 Michael Nordman <Michael Nordman>
Reviewed by Dimitri Glazkov.
V8 bindings for the window.applicationCache attribute.
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8DOMApplicationCacheCustom.cpp: Added.
- 2:41 PM Changeset in webkit [46916] by
-
- 4 edits in trunk/LayoutTests
2009-08-07 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
Fix three tests so they are not dependent on the getSelection() result
reflecting selections inside <input> and <textarea> elements.
- fast/events/right-click-focus.html: Removed unneeded check of anchorNode. The test works fine by just testing the actual result of typing.
- fast/forms/focus-style-pending.html: Detect focus with an onfocus attribute rather than by looking at getSelection().focusNode.
- fast/forms/search-click-in-placeholder.html: Detect focus with an onfocus attribute rather than by looking at getSelection().baseNode.
- 2:39 PM Changeset in webkit [46915] by
-
- 3 edits2 adds in trunk
WebCore: Right click on timeline of media controls panel cause seek
https://bugs.webkit.org/show_bug.cgi?id=27920
Patch by Alpha Lam <hclam@chromium.org> on 2009-08-07
Reviewed by Eric Seidel.
Add a test simulate the behavior of seeking by right clicking
on the time bar of media controls while playing.
- media/controls-right-click-on-timebar-expected.txt: Added.
- media/controls-right-click-on-timebar.html: Added.
LayoutTests: Right click on timeline of media controls panel cause seek
https://bugs.webkit.org/show_bug.cgi?id=27920
Patch by Alpha Lam <hclam@chromium.org> on 2009-08-07
Reviewed by Eric Seidel.
Add a test simulate the behavior of seeking by right clicking
on the time bar of media controls while playing.
- media/controls-right-click-on-timebar-expected.txt: Added.
- media/controls-right-click-on-timebar.html: Added.
- 2:36 PM Changeset in webkit [46914] by
-
- 13 edits in trunk/WebCore
deprecatedCopyInheritableProperties must be replaced by two different functions
https://bugs.webkit.org/show_bug.cgi?id=28057
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-07
Reviewed by Justin Garcia.
This patch deletes deprecatedInheritableProperties and modifies call callees to call either editingStyleAtPosition
or prepareEditingStyleToApplyAt. The concept of editing style is introduced in this patch,
which consists of all CSS properties need to be preserved under editing operations.
No test is added since this patch does not change any behavior.
- css/CSSComputedStyleDeclaration.cpp: Removed deprecatedCopyInheritableProperties
- css/CSSComputedStyleDeclaration.h: Removed deprecatedCopyInheritableProperties
- editing/ApplyStyleCommand.cpp:
(WebCore::):
(WebCore::editingStyleAtPosition): Obtains the editing-specific computed style at the position
(WebCore::prepareEditingStyleToApplyAt): Removes redundant editing styles at the specified position
(WebCore::removeStylesAddedByNode): Removes the style derived from the specified node
- editing/ApplyStyleCommand.h:
(WebCore::):
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphs): Uses editingStyleAtPosition
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Uses editingStyleAtPosition
- editing/DeleteSelectionCommand.cpp:
(WebCore::removeEnclosingAnchorStyle): Uses removeStyleOfNode
(WebCore::DeleteSelectionCommand::saveTypingStyleState): Uses editingStyleAtPosition
(WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Uses prepareEditingStyleToApplyAt
- editing/EditCommand.cpp:
- editing/EditCommand.h:
- editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Uses editingStyleAtPosition
(WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Uses prepareEditingStyleToApplyAt
- editing/RemoveFormatCommand.cpp:
(WebCore::RemoveFormatCommand::doApply): Uses editingStyleAtPosition
- editing/ReplaceSelectionCommand.cpp:
(WebCore::handleStyleSpansBeforeInsertion): Uses editingStyleAtPosition
(WebCore::ReplaceSelectionCommand::handleStyleSpans): Uses editingStyleAtPosition and prepareEditingStyleToApplyAt
(WebCore::ReplaceSelectionCommand::doApply): Uses prepareEditingStyleToApplyAt
- editing/markup.cpp:
(WebCore::removeEnclosingMailBlockquoteStyle): Uses removeStyleOfNode
(WebCore::removeDefaultStyles): Uses prepareEditingStyleToApplyAt
(WebCore::createMarkup): Uses editingStyleAtPosition
- 2:36 PM Changeset in webkit [46913] by
-
- 2 edits in trunk/LayoutTests
2009-08-07 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
Another try at making the gc-9.html test less prone to intermittent failure.
- fast/dom/gc-9.html: Changed this to do the "before garbage collection" test right after setting the properties. This practically eliminates the possibility that we will get unlucky and get a garbage collection between when theproperty is set and tested, which seems to have happened at least once on the buildbot.
- 2:10 PM Changeset in webkit [46912] by
-
- 2 edits in trunk/WebKitTools
Handle the case where only a single test is missing results.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 2:07 PM Changeset in webkit [46911] by
-
- 3 edits3 adds in trunk/JavaScriptCore
2009-08-07 George Staikos <george.staikos@torchmobile.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=27305
Implement WinCE-specific unicode layer.
Written by George Staikos <george.staikos@torchmobile.com>
with bug fixes by Yong Li <yong.li@torchmobile.com>
refactored by Joe Mason <joe.mason@torchmobile.com>
- wtf/Platform.h:
- wtf/unicode/Unicode.h:
- wtf/unicode/wince/UnicodeWince.cpp: Added. (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::foldCase): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isSpace): (WTF::Unicode::isLetter): (WTF::Unicode::isUpper): (WTF::Unicode::isLower): (WTF::Unicode::isDigit): (WTF::Unicode::isPunct): (WTF::Unicode::toTitleCase): (WTF::Unicode::direction): (WTF::Unicode::category): (WTF::Unicode::decompositionType): (WTF::Unicode::combiningClass): (WTF::Unicode::mirroredChar): (WTF::Unicode::digitValue):
- wtf/unicode/wince/UnicodeWince.h: Added. (WTF::Unicode::): (WTF::Unicode::isSeparatorSpace): (WTF::Unicode::isHighSurrogate): (WTF::Unicode::isLowSurrogate): (WTF::Unicode::isArabicChar): (WTF::Unicode::hasLineBreakingPropertyComplexContext): (WTF::Unicode::umemcasecmp): (WTF::Unicode::surrogateToUcs4):
- 1:19 PM CreatingLayoutTests created by
- Initial Version
- 1:15 PM Changeset in webkit [46910] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-07 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Eric Seidel.
Add inline to help winscw compiler resolve specialized argument in
templated functions.
- runtime/LiteralParser.cpp: (JSC::LiteralParser::Lexer::lexString):
- 1:09 PM Changeset in webkit [46909] by
-
- 3 edits in trunk/LayoutTests
2009-08-07 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Adam Treat.
Move fast/forms/menulist-style-color.html to Skipped list for mac/win.
Bug filed - https://bugs.webkit.org/show_bug.cgi?id=28079
- platform/mac/Skipped:
- platform/win/Skipped:
- 12:52 PM Changeset in webkit [46908] by
-
- 2 edits in trunk/WebKit/mac
2009-08-07 Anders Carlsson <andersca@apple.com>
Fix Tiger build.
- WebView/WebRenderNode.mm: (-[WebRenderNode _initWithCoreFrame:]):
- 12:51 PM Changeset in webkit [46907] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-07 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Eric Seidel.
Allow custom memory allocation control for RegExpObjectData struct
http://bugs.webkit.org/show_bug.cgi?id=26750
Inherits RegExpObjectData struct from FastAllocBase because
it has been instantiated by 'new' in JavaScriptCore/runtime/RegExpObject.cpp:62
- runtime/RegExpObject.h:
- 12:28 PM Creating and Submitting Layout Tests and Patches edited by
- (diff)
- 12:27 PM Changeset in webkit [46906] by
-
- 4 edits2 deletes in trunk/WebCore
2009-08-07 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
Bug 27250: Geolocation callback function IDL files are superfluous
https://bugs.webkit.org/show_bug.cgi?id=27250
The objects for the Geolocation success and error callbacks are created 'manually' in
WebCore/bindings/js/JSGeolocationCustom.cpp. Furthermore, the callback interfaces are
marked 'NoInterfaceObject' in the W3C spec, so the prototype should not
appear on the window object. Hence IDL files for these callbacks are not required.
See http://www.w3.org/TR/geolocation-API/#geolocation_interface and
http://www.w3.org/TR/WebIDL/#NoInterfaceObject.
No new tests required.
- DerivedSources.make: Modified. Removed reference to IDL files.
- WebCore.gypi: Modified. Removed reference to IDL files.
- WebCore.xcodeproj/project.pbxproj: Modified. Removed reference to IDL files.
- page/PositionCallback.idl: Removed.
- page/PositionErrorCallback.idl: Removed.
- 12:17 PM Changeset in webkit [46905] by
-
- 2 edits in trunk/WebKitTools
2009-08-07 George Wright <george.wright@torchmobile.com>
Reviewed by Adam Treat.
Fix DumpRenderTree for the Qt port to always dump the
PNG data unless the expected and actual hashes match.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::dump):
- 11:51 AM Changeset in webkit [46904] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-08-07 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Adam Treat.
Add Test results for mac and windows for new tests.
- platform/mac/fast/forms/text-style-color-expected.txt: Added.
- platform/win/fast/forms/text-style-color-expected.txt: Added.
- 11:51 AM Changeset in webkit [46903] by
-
- 1 edit2 adds in trunk
2009-08-07 Adam Treat <adam.treat@torchmobile.com>
Reviewed by David Levin.
Build fix for Qt when ENABLE_VIDEO = 0. This was necessitated by r46890 which
put the idl files back into play regardless of compile time defines.
- html/TimeRanges.idl:
- 11:38 AM Changeset in webkit [46902] by
-
- 2 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=28076
Add fast/images/icon-decoding.html to Qt skip list until it has
results.
Reviewed by Adam Treat.
- platform/qt/Skipped:
- 11:36 AM Changeset in webkit [46901] by
-
- 3 edits in trunk/WebKit/mac
2009-08-07 Anders Carlsson <andersca@apple.com>
Reviewed by Timothy Hatcher and Sam Weinig.
Change WebRenderNode to take a WebFrame instead of a WebFrameView.
- WebView/WebRenderNode.h:
- WebView/WebRenderNode.mm: (-[WebRenderNode _initWithName:position:rect:coreFrame:children:]): (copyRenderNode): (-[WebRenderNode _initWithCoreFrame:]): (-[WebRenderNode initWithWebFrame:]):
- 11:17 AM Changeset in webkit [46900] by
-
- 2 edits in trunk/WebCore
2009-08-07 Adam Treat <adam.treat@torchmobile.com>
Reviewed by David Levin.
Build fix for Qt when ENABLE_VIDEO = 0. This was necessitated by r46890 which
put the idl files back into play regardless of compile time defines.
- html/TimeRanges.idl:
- 11:14 AM Changeset in webkit [46899] by
-
- 2 edits in trunk/WebKitTools
2009-08-07 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Eric Seidel.
commit-log-editor does not produce a git commit log that is git friendly.
https://bugs.webkit.org/show_bug.cgi?id=27754
We make sure we end up with:
- A first paragraph describing the bug. It is eventually prefixed by "WebKit: <line>" or "WebCore: <line>". This used to be "WebCore:\n\n<line>".
- The Reviewed By line.
- An eventual Patch By line if author and committer doesn't match.
- The rest of the commit.
- Scripts/commit-log-editor:
- 10:56 AM Changeset in webkit [46898] by
-
- 1 edit in trunk/WebKitTools/Scripts/run-webkit-unittests
Make run-webkit-unittests executable.
- 10:37 AM Changeset in webkit [46897] by
-
- 2 edits in trunk/WebCore
2009-08-07 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by George Staikos.
Coding style patches for RenderThemeQt.cpp based on results from cpp_style.py.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::baselinePosition): (WebCore::inflateButtonRect): (WebCore::RenderThemeQt::supportsFocus): (WebCore::RenderThemeQt::applyTheme):
- 10:37 AM Changeset in webkit [46896] by
-
- 4 edits4 adds in trunk
2009-08-07 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Eric Seidel.
Prevent RenderThemeQt AdjustStyle based calls for TextField, MenuList and MenuListButton
from discarding style colour.
Add new tests and remove tests from platform/qt/Skipped that now pass.
- fast/forms/menulist-style-color.html: Added.
- fast/forms/text-style-color.html: Added.
- platform/qt/Skipped:
- platform/qt/fast/forms/menulist-style-color-expected.txt: Added.
- platform/qt/fast/forms/text-style-color-expected.txt: Added.
2009-08-07 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Eric Seidel.
Prevent RenderThemeQt AdjustStyle based calls for TextField, MenuList and MenuListButton
from discarding style colour.
Add tests and remove tests from platform/qt/Skipped that now pass.
Tests: fast/forms/menulist-style-color.html
fast/forms/text-style-color.html
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::adjustTextFieldStyle): (WebCore::RenderThemeQt::adjustMenuListStyle): (WebCore::RenderThemeQt::adjustMenuListButtonStyle):
- 10:22 AM Changeset in webkit [46895] by
-
- 2 edits in trunk/WebKitTools
2009-08-07 Adam Barth <abarth@webkit.org>
Unreviewed. (Darin Adler indicated he'd prefer if we landed these
kinds of changes unreviewed, like editing the WebKit Team wiki page.)
Added Pierre d'Herbemont to list of committers.
- Scripts/modules/committers.py:
- 9:15 AM QtWebKitTodo edited by
- (diff)
- 8:57 AM Changeset in webkit [46894] by
-
- 5 edits in trunk/WebCore
2009-08-07 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
https://bugs.webkit.org/show_bug.cgi?id=22495
[V8] Re-land http://trac.webkit.org/changeset/46821, now that
http://trac.webkit.org/changeset/46874 re-landed
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- 8:52 AM Changeset in webkit [46893] by
-
- 3 edits in trunk/WebCore
2009-08-07 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Darin Adler and George Staikos.
Add rectToRect convenience function which returns the TransformationMatrix
which maps the 'from' rectangle to the 'to' rectangle.
No tests as this would require binding the method to js and since it is static
that doesn't seem possible. Please check the math.
- platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::rectToRect):
- platform/graphics/transforms/TransformationMatrix.h:
- 8:35 AM Changeset in webkit [46892] by
-
- 10 edits2 adds in trunk
WebCore:
2009-08-07 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
Implement the HTML5 hashchange event.
https://bugs.webkit.org/show_bug.cgi?id=21605
Test: fast/loader/hashchange-event.html
- dom/EventNames.h: Add "hashchange"
- html/HTMLAttributeNames.in: Add "onhashchange"
- loader/FrameLoader.cpp: (WebCore::HashChangeEventTask::create): (WebCore::HashChangeEventTask::performTask): (WebCore::HashChangeEventTask::HashChangeEventTask): (WebCore::FrameLoader::scrollToAnchor): When an anchor navigation is completed and the new fragment identifier is different from the old one, queue a hash change event on the Document.
Add a window event listener for the hashchange event if onhashchange is encountered:
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute):
- html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute):
Add a new string utility method that gives "null and empty are equivalent" behavior:
- platform/text/PlatformString.h: (WebCore::equalIgnoringNullity):
- platform/text/StringImpl.cpp: (WebCore::equalIgnoringNullity):
- platform/text/StringImpl.h:
LayoutTests:
2009-08-07 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
Implement the HTML5 hashchange event.
https://bugs.webkit.org/show_bug.cgi?id=21605
- fast/loader/hashchange-event-expected.txt: Added.
- fast/loader/hashchange-event.html: Added.
- 7:57 AM Changeset in webkit [46891] by
-
- 7 edits in trunk/WebCore
2009-08-07 Jessie Berlin <jberlin@apple.com>
Add the initial implementation of the ability to resize the columns in
a DataGrid in the Web Inspector. Enables that functionality in both the
Profile View and in the Local Storage View.
Reviewed by Timothy Hatcher.
In this version, resizing a column can change the width of at most two
columns (the columns to the left and right of the resizer being dragged).
Possible changes in future patches:
1) Be able to specify the minimum size of a column and the maximum size
of a column. If the minimum size is equal to the maximum size, the
column can't be resized.
2) Make the behavior more in line with the following description:
Everything before the column that is resized stays fixed size. The
resized column changes sizes. The other columns except the last stay
the same size. And the last column adjusts to fit with a minimum size.
If the last column is already the minimum, the next to last column
shrinks, etc.
3) Make it possible to scale the column sizes appropriately when the
Web Inspector window gets resized.
- inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView.prototype.update): Once the DataGrid is added to the DOM, update the widths of the DataGrid in order to put the resizers in place. (WebInspector.DOMStorageItemsView.prototype.resize): Update the widths of the DataGrid in order to correctly adjust the positions of the resizers.
- inspector/front-end/DataGrid.js: (WebInspector.DataGrid): Store column groups whose widths can later be changed when the columns are resized by the user. Also, keep track of whether the widths of the columns have been initialized. (WebInspector.DataGrid.prototype.updateWidths): Create the resizers for the columns. (WebInspector.DataGrid.prototype._clickInDataTable): Didn't actually change anything in this method, just added a comma to the end of the function. (WebInspector.DataGrid.prototype._startResizerDragging): Store the resizer that is currently dragging. (WebInspector.DataGrid.prototype._resizerDragging): Constrain the area that the resizer can be dragged to the column to it's left and right, with some padding added to make sure that the neighboring columns don't disappear. (WebInspector.DataGrid.prototype._endResizerDragging):
- inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.resize): Resize the view. (WebInspector.DatabasesPanel.prototype._updateSidebarWidth): ditto.
- inspector/front-end/ProfileView.js: (WebInspector.ProfileView.prototype.show): Now that the DataGrid is actually attached to the DOM, update the widths of the DataGrid in order to put the resizers in place. (WebInspector.ProfileView.prototype.resize): Update the widths of the DataGrid in order to correctly adjust the positions of the resizers.
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.resize): Resize the view. (WebInspector.ProfilesPanel.prototype._updateSidebarWidth): ditto.
- inspector/front-end/inspector.css: Add in a style rule for a resizer in the Data Grid.
- 3:56 AM UsingGitWithWebKit edited by
- (diff)
- 3:22 AM WebKit Team edited by
- Fix my entry (diff)
- 2:55 AM Changeset in webkit [46890] by
-
- 5 edits in trunk/WebCore
2009-08-07 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Back out r46847 and fix the Qt build system to always generate
all the JS binding files from IDL files. The generated files
have #if feature guards, so the #ifs are not needed in the
files using them.
- WebCore.pro:
- bindings/js/JSEventTarget.cpp:
- bindings/js/JSWorkerContextBase.cpp:
- bindings/js/WorkerScriptController.cpp:
- 2:44 AM WebKit Team edited by
- Add my entry. (diff)
- 1:21 AM WebKit Team edited by
- Add my entry. (diff)
- 12:32 AM Changeset in webkit [46889] by
-
- 7 edits3 adds in trunk
2009-08-07 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Adele Peterson.
Cannot scroll for box-reflect:right
https://bugs.webkit.org/show_bug.cgi?id=27979
Update m_overflowLeft an m_overflowWidth for reflection just like
m_overflowTop and m_overflowHeight.
- fast/reflections/reflection-overflow-scroll-expected.txt: Added.
- fast/reflections/reflection-overflow-scroll.html: Added.
- fast/reflections/resources/reflection-overflow-scroll.js: Added.
- platform/mac/fast/reflections/reflection-nesting-expected.txt:
- platform/mac/fast/repaint/reflection-redraw-expected.txt:
2009-08-07 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Adele Peterson.
Cannot scroll for box-reflect:right
https://bugs.webkit.org/show_bug.cgi?id=27979
Update m_overflowLeft an m_overflowWidth for reflection just like
m_overflowTop and m_overflowHeight.
Test: fast/reflections/reflection-overflow-scroll.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
2009-08-07 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Adele Peterson.
Cannot scroll for box-reflect:right
https://bugs.webkit.org/show_bug.cgi?id=27979
Update m_overflowLeft an m_overflowWidth for reflection just like
m_overflowTop and m_overflowHeight.
- Scripts/make-js-test-wrappers: Added regexp to skip box-shadow-overflo
w-scroll.js
Aug 6, 2009:
- 11:53 PM WebKit Team edited by
- add janm to the team! (diff)
- 11:53 PM Changeset in webkit [46888] by
-
- 5 edits4 adds in trunk
2009-08-06 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Adam Barth.
box-shadow's spread is ignored with <table>
https://bugs.webkit.org/show_bug.cgi?id=28017
Use RenderStyle::getBoxShadowExtent just like RenderBlock.
- fast/box-shadow/box-shadow-overflow-scroll-expected.txt: Added.
- fast/box-shadow/box-shadow-overflow-scroll.html: Added.
- fast/box-shadow/resources/box-shadow-overflow-scroll.js: Added.
2009-08-06 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Adam Barth.
box-shadow's spread is ignored with <table>
https://bugs.webkit.org/show_bug.cgi?id=28017
Use RenderStyle::getBoxShadowExtent just like RenderBlock.
Test: fast/box-shadow/box-shadow-overflow-scroll.html
- rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
2009-08-06 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Adam Barth.
box-shadow's spread is ignored with <table>
https://bugs.webkit.org/show_bug.cgi?id=28017
Use RenderStyle::getBoxShadowExtent just like RenderBlock.
- Scripts/make-js-test-wrappers: Added regexp to skip box-shadow-overflow-scroll.js
- 11:44 PM HackingGtk edited by
- Add l10n, docs and tests folder; Removed unused backends and … (diff)
- 11:14 PM Changeset in webkit [46887] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-08-06 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Copy expected (txt only) result from Mac for
fast/images/icon-decoding.html from r46871 since we seem to pass this
test as well.
- platform/gtk/fast/images/icon-decoding-expected.txt: Copied from LayoutTests/platform/mac/fast/images/icon-decoding-expected.txt.
- 10:51 PM Changeset in webkit [46886] by
-
- 2 edits in trunk/WebCore
2009-08-06 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Timothy Hatcher.
Inspector: NodeLists Don't Display Well in the Console
https://bugs.webkit.org/show_bug.cgi?id=28061
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._format): Specific check if the object is a NodeList, display as an "array"
- 10:39 PM Changeset in webkit [46885] by
-
- 4 edits in trunk/WebCore
2009-08-06 Yusuke Sato <yusukes@chromium.org>
Reviewed by David Levin.
Chromium Linux: add support for @font-face
https://bugs.webkit.org/show_bug.cgi?id=28015
- loader/CachedFont.cpp: (WebCore::CachedFont::~CachedFont): (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::platformDataFromCustomData): (WebCore::CachedFont::allClientsRemoved):
Modified #ifdefs so that chromium linux can load remote fonts.
- platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::createFontCustomPlatformData):
Create SkTypeface for a web font by calling SkTypeface::CreateFromStream function.
(WebCore::RemoteFontStream::RemoteFontStream):
(WebCore::RemoteFontStream::~RemoteFontStream):
(WebCore::RemoteFontStream::rewind):
(WebCore::RemoteFontStream::read):
New class that implements SkStream interface and wraps wtf's SharedBuffer.
- platform/graphics/chromium/FontCustomPlatformData.h: (WebCore::FontCustomPlatformData::FontCustomPlatformData):
Added member variables for Linux.
- 10:09 PM Changeset in webkit [46884] by
-
- 2 edits in trunk/WebCore
2009-08-06 Yong Li <yong.li@torchmobile.com>
Reviewed by Eric Seidel.
Fix JPEGImageDecoder.cpp compile error on WinCE
https://bugs.webkit.org/show_bug.cgi?id=28051
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
- 9:45 PM Changeset in webkit [46883] by
-
- 1 edit1 add in trunk/WebKit/wx
Reviewed by Eric Seidel.
Adding support for building wx Python bindings using the waf build system.
https://bugs.webkit.org/show_bug.cgi?id=27619
- 9:24 PM Changeset in webkit [46882] by
-
- 1 edit1 add in trunk/WebCore
Reviewed by Eric Seidel.
Adding WebCore support for the waf build system for wx.
https://bugs.webkit.org/show_bug.cgi?id=27619
- 9:11 PM Changeset in webkit [46881] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-06 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Darin Adler.
Updated patch for bug #27059:
Symbian platform always uses little endian encoding,
regardless of compiler.
We need to make sure that we correctly detect EABI architecture
for armv5 targets on Symbian,
where EABI is set but not ARM_EABI
- wtf/Platform.h:
- 8:30 PM Changeset in webkit [46880] by
-
- 7 edits in trunk
2009-08-06 Adam Barth <abarth@webkit.org>
Unreviewed revert.
Revert 46877 because it broke GTK.
- wtf/Noncopyable.h:
WebCore:
2009-08-06 Adam Barth <abarth@webkit.org>
Unreviewed revert.
Revert 46877 because it broke GTK.
- platform/graphics/wince/GraphicsContextWince.cpp:
WebKit/win:
2009-08-06 Adam Barth <abarth@webkit.org>
Unreviewed revert.
Revert 46877 because it broke GTK.
- COMPropertyBag.h:
- 8:05 PM Changeset in webkit [46879] by
-
- 14 edits in trunk/JavaScriptCore
2009-08-06 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Make get_by_id/put_by_id/method_check/call defer optimization using a data flag rather than a code modification.
( https://bugs.webkit.org/show_bug.cgi?id=27635 )
This improves performance of ENABLE(ASSEMBLER_WX_EXCLUSIVE) builds by 2-2.5%, reducing the overhead to about 2.5%.
(No performance impact with ASSEMBLER_WX_EXCLUSIVE disabled).
- bytecode/CodeBlock.cpp:
(JSC::printStructureStubInfo):
- Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
- bytecode/CodeBlock.h:
(JSC::):
(JSC::CallLinkInfo::seenOnce):
(JSC::CallLinkInfo::setSeen):
(JSC::MethodCallLinkInfo::seenOnce):
(JSC::MethodCallLinkInfo::setSeen):
- Change a pointer in CallLinkInfo/MethodCallLinkInfo to use a PtrAndFlags, use a flag to track when an op has been executed once.
- bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
- Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
- bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::StructureStubInfo):
(JSC::StructureStubInfo::initGetByIdSelf):
(JSC::StructureStubInfo::initGetByIdProto):
(JSC::StructureStubInfo::initGetByIdChain):
(JSC::StructureStubInfo::initGetByIdSelfList):
(JSC::StructureStubInfo::initGetByIdProtoList):
(JSC::StructureStubInfo::initPutByIdTransition):
(JSC::StructureStubInfo::initPutByIdReplace):
(JSC::StructureStubInfo::seenOnce):
(JSC::StructureStubInfo::setSeen):
- Make StructureStubInfo store the type as an integer, rather than an OpcodeID, add a flag to track when an op has been executed once.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
- Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
- jit/JIT.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::unlinkCall):
- Remove the "don't lazy link" stage of calls.
- jit/JIT.h:
(JSC::JIT::compileCTIMachineTrampolines):
- Remove the "don't lazy link" stage of calls.
- jit/JITCall.cpp:
(JSC::JIT::compileOpCallSlowCase):
- Remove the "don't lazy link" stage of calls.
- jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::JITStubs::DEFINE_STUB_FUNCTION):
(JSC::JITStubs::getPolymorphicAccessStructureListSlot):
- Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.
- jit/JITStubs.h:
(JSC::JITThunks::ctiStringLengthTrampoline):
(JSC::JITStubs::):
- Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.
- wtf/PtrAndFlags.h:
(WTF::PtrAndFlags::PtrAndFlags):
(WTF::PtrAndFlags::operator!):
(WTF::PtrAndFlags::operator->):
- Add ! and -> operators, add constuctor with pointer argument.
- 6:56 PM Changeset in webkit [46878] by
-
- 7 edits in trunk/WebCore
2009-08-06 Chris Fleizach <Chris Fleizach>
Reviewed by Eric Seidel.
Bug 27956 - AX: roleValue should be cached for performance
https://bugs.webkit.org/show_bug.cgi?id=27956
Caches the role value of an accessibility object instead of calculating it everytime.
The changes gained a 5% speedup using VoiceOver to navigate a webpage.
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::handleAriaRoleChanged):
Use generic role setter instead of specific ARIA role setter.
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::AccessibilityObject):
- accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::headingLevel):
Make headingLevel into instance method so that it can *safely* be called in the constructor.
(WebCore::AccessibilityObject::setRoleValue):
(WebCore::AccessibilityObject::roleValue):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::AccessibilityRenderObject): (WebCore::AccessibilityRenderObject::headingLevel): (WebCore::AccessibilityRenderObject::intValue): (WebCore::AccessibilityRenderObject::updateAccessibilityRole): (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/AccessibilityRenderObject.h:
- accessibility/mac/AccessibilityObjectWrapper.mm: (AXAttributeStringSetHeadingLevel):
- 6:09 PM Changeset in webkit [46877] by
-
- 6 edits in trunk
2009-08-06 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Adam Barth.
Allow custom memory allocation control for Noncopyable class
https://bugs.webkit.org/show_bug.cgi?id=27879
Several classes which inherited from Noncopyable are instantiated by
operator new, so Noncopyable class has been inherited from FastAllocBase.
- wtf/Noncopyable.h:
2009-08-06 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Adam Barth.
Change Noncopyable inheriting to public
http://bugs.webkit.org/show_bug.cgi?id=27879
Since Noncopyable is inherited from FastAllocBase, Noncopyable's
inheriting has been changed to public.
- platform/graphics/wince/GraphicsContextWince.cpp:
2009-08-06 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Adam Barth.
Change Noncopyable inheriting to public
http://bugs.webkit.org/show_bug.cgi?id=27879
Since Noncopyable is inherited from FastAllocBase,
Noncopyable's inheriting has been changed to public.
- COMPropertyBag.h:
- 5:59 PM Changeset in webkit [46876] by
-
- 8 edits in trunk
Add explicit dependencies for our build verification scripts to ensure that they always run after linking has completed.
Rubber-stamped by Sam Weinig.
- 5:59 PM Changeset in webkit [46875] by
-
- 2 edits in trunk/LayoutTests
2009-08-06 Simon Fraser <Simon Fraser>
Make the test a little more sloppy to try to fix sporadic failures on Windows.
- animations/play-state.html:
- 5:32 PM Changeset in webkit [46874] by
-
- 17 edits2 copies3 adds in trunk
2009-08-05 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Implement the matchMedium method on the Media interface described in the CSSOM View Module.
https://bugs.webkit.org/show_bug.cgi?id=22495
Add a new Media interface, obtainable via the AbstractView, that can
evaluate queries via its matchesMedium() method.
Test: fast/media/matchmedium-query-api.html
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl: Add Media.* files to the build.
- css/Media.cpp: Added. (WebCore::Media::Media): (WebCore::Media::type): (WebCore::Media::matchMedium):
- css/Media.h: Added. (WebCore::Media::create): (WebCore::Media::document):
- css/Media.idl: Added. Media::matchMedium() uses a MediaQueryEvaluator() to test the query.
- page/AbstractView.idl:
- page/DOMWindow.cpp: (WebCore::DOMWindow::media):
- page/DOMWindow.h:
- page/DOMWindow.idl: Add a readonly attribute for Media.
- 5:28 PM Changeset in webkit [46873] by
-
- 3 edits in trunk/LayoutTests
2009-08-06 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
- fast/dom/gc-9-expected.txt: Generated new results.
- fast/dom/gc-9.html: Turned off tests that are unpredictable based on what happens during garbage collection. These do represent bugs, so we want to turn them back on again once the bugs are fixed.
- 5:27 PM Changeset in webkit [46872] by
-
- 2 edits in trunk/WebKitLibraries
2009-08-06 Peter Kasting <pkasting@google.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=27323
Strip line endings at all points auto-version.sh reads data, not just
the one I happened to run into.
- win/tools/scripts/auto-version.sh:
- 5:25 PM Changeset in webkit [46871] by
-
- 1 edit8 adds in trunk/LayoutTests
2009-08-06 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=28025
Add a test for .ico decoding.
- fast/images/icon-decoding.html: Added.
- fast/images/resources/1bit.ico: Added.
- fast/images/resources/2entries.ico: Added.
- fast/images/resources/32bit.ico: Added.
- fast/images/resources/8bit.ico: Added.
- platform/mac/fast/images/icon-decoding-expected.checksum: Added.
- platform/mac/fast/images/icon-decoding-expected.png: Added.
- platform/mac/fast/images/icon-decoding-expected.txt: Added.
- 4:46 PM Changeset in webkit [46870] by
-
- 2 edits in trunk/WebKit/mac
2009-08-06 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler and Dan Bernstein.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::hasHTMLView): Always return true when we're in viewless mode.
- 4:45 PM Changeset in webkit [46869] by
-
- 12 edits8 adds in trunk
2009-08-06 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=27455
Test suite for form controls' custom validation message.
- fast/dom/domListEnumeration-expected.txt: Corrected
- fast/dom/resources/domListEnumeration.js: Corrected
- fast/forms/ValidityState-customError-001-expected.txt: Added.
- fast/forms/ValidityState-customError-001.html: Added.
- fast/forms/ValidityState-customError-002-expected.txt: Added.
- fast/forms/ValidityState-customError-002.html: Added.
- fast/forms/ValidityState-customError-003-expected.txt: Added.
- fast/forms/ValidityState-customError-003.html: Added.
- fast/forms/ValidityState-customError-004-expected.txt: Added.
- fast/forms/ValidityState-customError-004.html: Added.
2009-08-06 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=27455
Support for a custom validation message in ValidityState and related
form controls.
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#dom-cva-setcustomvalidity
Tests: fast/forms/ValidityState-customError-001.html
fast/forms/ValidityState-customError-002.html
fast/forms/ValidityState-customError-003.html
fast/forms/ValidityState-customError-004.html
- html/HTMLButtonElement.idl: setCustomValidity DOM method
- html/HTMLFieldSetElement.idl: ditto
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::setCustomValidity): ditto
- html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::valueMissing): moved down
- html/HTMLInputElement.idl: ditto
- html/HTMLSelectElement.idl: ditto
- html/HTMLTextAreaElement.idl:
- html/ValidityState.h: (WebCore::ValidityState::setCustomErrorMessage): method to set custom validation message (WebCore::ValidityState::customError): validation flag
- 4:00 PM Changeset in webkit [46868] by
-
- 6 edits in trunk
Bring a little order to our otherwise out of control lives.
- 3:56 PM Changeset in webkit [46867] by
-
- 2 edits in trunk/WebCore
Stop copying .idl files in to the framework resources directory.
- WebCore.xcodeproj/project.pbxproj:
- 3:51 PM Changeset in webkit [46866] by
-
- 2 edits in trunk/WebKit/mac
2009-08-06 Anders Carlsson <andersca@apple.com>
Remove WebGraphicsExtras.h include.
- Plugins/WebNetscapePluginView.mm:
- 3:51 PM Changeset in webkit [46865] by
-
- 2 edits in trunk/WebCore
Fix the build some more.
Add JSWebSocket.cpp and JSWebSocket.h to the Xcode project, and move the WebSocket-related
files and groups in to the appropriate locations.
- WebCore.xcodeproj/project.pbxproj:
- 3:38 PM Changeset in webkit [46864] by
-
- 2 edits in trunk/WebKit
Build fix.
Don't attempt to build a file that Anders just deleted.
- WebKit.xcodeproj/project.pbxproj:
- 3:30 PM Changeset in webkit [46863] by
-
- 4 edits7 adds in trunk/WebCore
2009-08-06 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Add WebSocket.idl
https://bugs.webkit.org/show_bug.cgi?id=27209
Add WebSocket.idl in WebCore/websockets/.
Add build systems only for GNUmakefile.am and WebCore.xcodeproj now.
Other build systems will be updated once the code is functional.
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSWebSocketConstructor.cpp: Added.
- bindings/js/JSWebSocketConstructor.h: Added.
- bindings/js/JSWebSocketCustom.cpp: Added.
- websockets/WebSocket.cpp: Added.
- websockets/WebSocket.h: Added.
- websockets/WebSocket.idl: Added.
- 3:08 PM Changeset in webkit [46862] by
-
- 1 edit2 deletes in trunk/WebKit/mac
2009-08-06 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Remove WebGraphicsExtras, it is no longer used.
- Misc/WebGraphicsExtras.c: Removed.
- Misc/WebGraphicsExtras.h: Removed.
- 2:57 PM Changeset in webkit [46861] by
-
- 2 edits in trunk/LayoutTests
2009-08-06 Simon Fraser <Simon Fraser>
Fix a test in http/tests/media that was missed in the earlier 'media' rename.
- http/tests/media/video-play-stall.html:
- 2:41 PM Changeset in webkit [46860] by
-
- 2 edits1 add4 deletes in trunk/LayoutTests
2009-08-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
LayoutTests/editing/execCommand/boldSelection.html must be a dumpAsText test
https://bugs.webkit.org/show_bug.cgi?id=28055
This patch converts boldSelection.html to a dumpAsText and adds description on what it tests.
Namely, it tests bolding the first 21 letters of a sentence.
Since bolding must be done by adding b tag instead of a style span, we print innerHTML of the result.
- editing/execCommand/boldSelection-expected.txt: Added.
- editing/execCommand/boldSelection.html:
- platform/mac/editing/execCommand/boldSelection-expected.checksum: Removed.
- platform/mac/editing/execCommand/boldSelection-expected.png: Removed.
- platform/mac/editing/execCommand/boldSelection-expected.txt: Removed.
- platform/qt/editing/execCommand/boldSelection-expected.txt: Removed.
- 2:38 PM BuildingQtOnWindows edited by
- (diff)
- 2:29 PM Changeset in webkit [46859] by
-
- 10 edits in trunk/WebCore
2009-08-06 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Style cleaning for WorkerContextExecutionProxy.
https://bugs.webkit.org/show_bug.cgi?id=27997
Cleanup WorkerContextExecutioonProxy related files to follow
WebKit coding styles after all V8 binding codes are upstreamed.
1) Lower-case the first letter of remaining functins in class
WorkerContextExecutionProxy. Update the V8 code generator
and all other references accordingly.
2) Integrate getConstructor from WorkerContextExecutionProxy
to V8DOMWrapper.
3) Other misc changes, like removing trailing whitespaces and
sorting the include files.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructorForContext): (WebCore::V8DOMWrapper::convertToV8Object):
- bindings/v8/V8DOMWrapper.h:
- bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::~V8WorkerContextEventListener): (WebCore::V8WorkerContextEventListener::handleEvent): (WebCore::V8WorkerContextEventListener::reportError): (WebCore::V8WorkerContextEventListener::getReceiverObject):
- bindings/v8/V8WorkerContextObjectEventListener.cpp: (WebCore::weakObjectEventListenerCallback):
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::handleConsoleMessage): (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): (WebCore::WorkerContextExecutionProxy::convertToV8Object): (WebCore::WorkerContextExecutionProxy::convertEventToV8Object): (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object): (WebCore::WorkerContextExecutionProxy::convertWorkerContextToV8Object): (WebCore::WorkerContextExecutionProxy::toV8): (WebCore::WorkerContextExecutionProxy::forgetV8EventObject): (WebCore::WorkerContextExecutionProxy::removeEventListener):
- bindings/v8/WorkerContextExecutionProxy.h: (WebCore::WorkerContextExecutionProxy::context): (WebCore::WorkerContextExecutionProxy::convertToV8Object):
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL):
- 2:21 PM BuildingQtOnWindows edited by
- (diff)
- 2:15 PM Changeset in webkit [46858] by
-
- 1 edit2 moves in trunk/LayoutTests
2009-08-06 Simon Fraser <Simon Fraser>
Rubber-stamped by Dan Bernstein.
Move a video test from fast/media to media/, since fast/media is all about
CSS media queries.
- media/video-controls-with-mutation-event-handler-expected.txt: Renamed from LayoutTests/fast/media/video-controls-with-mutation-event-handler-expected.txt.
- media/video-controls-with-mutation-event-handler.html: Renamed from LayoutTests/fast/media/video-controls-with-mutation-event-handler.html.
- 2:09 PM Changeset in webkit [46857] by
-
- 29 edits in trunk/LayoutTests
2009-08-06 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=28056
Change media tests to not use a variable in global scope with the name
'media', to avoid conflict with window.media.
- media/audio-constructor-autobuffer-expected.txt:
- media/audio-constructor-autobuffer.html:
- media/audio-constructor-src.html:
- media/audio-constructor.html:
- media/audio-data-url-expected.txt:
- media/audio-data-url.html:
- media/audio-mpeg-supported-expected.txt:
- media/audio-mpeg-supported.html:
- media/media-load-event-expected.txt:
- media/media-load-event.html:
- media/video-can-play-type.html:
- media/video-loop-expected.txt:
- media/video-loop.html:
- media/video-seek-past-end-paused-expected.txt:
- media/video-seek-past-end-paused.html:
- media/video-seek-past-end-playing-expected.txt:
- media/video-seek-past-end-playing.html:
- media/video-source-media.html:
- media/video-source-type-params.html:
- media/video-source-type.html:
- media/video-source.html:
- media/video-src-invalid-remove.html:
- media/video-src-plus-source-expected.txt:
- media/video-src-plus-source.html:
- media/video-src-source.html:
- media/video-src.html:
- media/video-test.js: (findMediaElement): (waitForEvent): (waitForEventAndTest): (relativeURL):
- media/video-timeupdate-during-playback.html:
- 1:50 PM Changeset in webkit [46856] by
-
- 3 edits in trunk/WebKitTools
2009-08-06 Eric Seidel <eric@webkit.org>
No review, only changing make-js-test-wrappers.
Fix make-js-test-wrappers to ignore a few more js tests
with custom templates.
- Scripts/make-js-test-wrappers:
- 1:20 PM Changeset in webkit [46855] by
-
- 2 edits in trunk/WebKitTools
2009-08-06 Eric Seidel <eric@webkit.org>
No review, only changing make-js-test-wrappers.
Fix make-js-test-wrappers to ignore a few more js tests
with custom templates.
- Scripts/make-js-test-wrappers:
- 12:17 PM Changeset in webkit [46854] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-06 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Allow custom memory allocation control for JavaScriptCore's PolymorphicAccessStructureList struct
https://bugs.webkit.org/show_bug.cgi?id=27877
Inherits PolymorphicAccessStructureList struct from FastAllocBase because it has been instantiated by
'new' in JavaScriptCore/jit/JITStubs.cpp:1229.
- bytecode/Instruction.h:
- 11:49 AM Changeset in webkit [46853] by
-
- 2 edits in trunk/PlanetWebKit
2009-08-06 Brent Fulgham <bfulgham@webkit.org>
Rubber-stamped by Adam Barth.
Update my blog's address.
- config.ini: Update Blog address.
- 11:25 AM Changeset in webkit [46852] by
-
- 9 edits5 copies9 adds in trunk/LayoutTests
2009-08-06 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
Refactored worker tests to share code with shared worker versions. Shared worker tests are currently disabled by default.
Worker layout tests should be refactored to enable testing SharedWorkers also.
https://bugs.webkit.org/show_bug.cgi?id=27963
- fast/workers/resources/shared-worker-common.js: (onconnect): (gc): (handleMessage):
- fast/workers/resources/shared-worker-create-common.js: Added. (createWorker.worker.port.onmessage): (createWorker.worker.postMessage): (createWorker):
- fast/workers/resources/worker-context-gc.js: Added. (log): (worker.onmessage):
- fast/workers/resources/worker-create-common.js: Added. (createWorker):
- fast/workers/resources/worker-location.js: Added. (log): (gc): (worker.onmessage):
- fast/workers/resources/worker-navigator.js: Added. (log): (worker.onmessage):
- fast/workers/resources/worker-replace-global-constructor.js:
- fast/workers/resources/worker-replace-self.js: Added. (log): (worker.onmessage):
- fast/workers/shared-worker-context-gc-expected.txt: Added.
- fast/workers/shared-worker-context-gc.html-disabled: Added.
- fast/workers/shared-worker-location-expected.txt: Added.
- fast/workers/shared-worker-location.html-disabled: Added.
- fast/workers/shared-worker-navigator-expected.txt: Added.
- fast/workers/shared-worker-navigator.html-disabled: Added.
- fast/workers/shared-worker-replace-global-constructor.html-disabled:
- fast/workers/shared-worker-replace-self-expected.txt: Added.
- fast/workers/shared-worker-replace-self.html-disabled: Added.
- fast/workers/worker-context-gc.html:
- fast/workers/worker-location.html:
- fast/workers/worker-navigator.html:
- fast/workers/worker-replace-global-constructor.html:
- fast/workers/worker-replace-self.html:
- 11:02 AM Changeset in webkit [46851] by
-
- 2 edits in trunk/WebCore
2009-08-06 Darin Adler <Darin Adler>
Fix Mac Leopard debug build.
- platform/text/StringImpl.cpp: (WebCore::equalIgnoringCase): Removed meaningless assertion; an unsigned is always >= 0 and checking causes a warning in the newer versions of gcc.
- 9:43 AM Changeset in webkit [46850] by
-
- 10 edits4 deletes in trunk
WebCore:
2009-08-06 Adam Barth <abarth@webkit.org>
Unreview rollout.
Revert 46840 because it broke the reliability tests.
- bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::execute):
- bindings/v8/ScheduledAction.h: (WebCore::ScheduledAction::ScheduledAction):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl):
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::SetTimeoutOrInterval):
LayoutTests:
2009-08-06 Adam Barth <abarth@webkit.org>
Unreviewed rollout.
Revert 46840 because it broke the reliability tests.
- http/tests/security/isolatedWorld/window-setTimeout-function-expected.txt: Removed.
- http/tests/security/isolatedWorld/window-setTimeout-function.html: Removed.
- http/tests/security/isolatedWorld/window-setTimeout-string-expected.txt: Removed.
- http/tests/security/isolatedWorld/window-setTimeout-string.html: Removed.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 9:43 AM Changeset in webkit [46849] by
-
- 3 edits in trunk/WebCore
2009-08-06 Adam Barth <abarth@webkit.org>
Unreviewed rollout.
Revert 46840 in preparation to revert 46838, which broke the reliability tests.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::updateDocumentWrapperCache): (WebCore::V8Proxy::initContextIfNeeded): (WebCore::V8Proxy::mainWorldContext):
- bindings/v8/V8Proxy.h: (WebCore::V8Proxy::context):
- 9:37 AM Changeset in webkit [46848] by
-
- 5 edits in trunk/WebCore
2009-08-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: move style-related utilities into InjectedScript.
- inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration): (WebInspector.CSSStyleDeclaration.prototype.isPropertyImplicit): (WebInspector.CSSStyleDeclaration.prototype.styleTextWithShorthands): (WebInspector.CSSStyleDeclaration.prototype.getLonghandProperties): (WebInspector.CSSStyleDeclaration.prototype.getShorthandPriority):
- inspector/front-end/InjectedScript.js: (InjectedScript.applyStyleText): (InjectedScript.toggleStyleEnabled): (InjectedScript._serializeStyle): (InjectedScript._getUniqueStyleProperties): (InjectedScript._getLonghandProperties): (InjectedScript._getShorthandPriority):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._update): (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded): (WebInspector.StylePropertiesSection.prototype.onpopulate): (WebInspector.StylePropertyTreeElement.prototype.get priority): (WebInspector.StylePropertyTreeElement.prototype.get value): (WebInspector.StylePropertyTreeElement.prototype):
- inspector/front-end/utilities.js:
- 8:58 AM Changeset in webkit [46847] by
-
- 4 edits in trunk/WebCore
2009-08-06 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed build fix, add #ifdef guards around
inclusions of shared worker specific files.
- bindings/js/JSEventTarget.cpp:
- bindings/js/JSWorkerContextBase.cpp:
- bindings/js/WorkerScriptController.cpp:
- 8:57 AM Changeset in webkit [46846] by
-
- 4 edits in trunk/WebCore
2009-08-06 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
cssgrammar.cpp fails to compile with RVCT compiler
https://bugs.webkit.org/show_bug.cgi?id=27952
- css/CSSGrammar.y: Do not convert to String to get rid of the stray memory allocation
- platform/text/StringImpl.cpp: (WebCore::equalIgnoringCase):
- platform/text/StringImpl.h: (WebCore::equalIgnoringCase): Add charactersEqualIgnoringCase function that works with a character pointer and length
- 8:30 AM Changeset in webkit [46845] by
-
- 30 edits9 copies13 adds in trunk
WebCore:
2009-08-01 Drew Wilson <atwilson@google.com>
Reviewed by NOBODY (OOPS!).
Created first working implementation of SharedWorkers (execution only, no sharing).
https://bugs.webkit.org/show_bug.cgi?id=27927
Added initial implementations of SharedWorkerThread and SharedWorkerContext.
No v8 bindings yet.
- DerivedSources.cpp: Added shared worker files.
- DerivedSources.make: Added shared worker files.
- GNUmakefile.am: Added shared worker files.
- WebCore.gypi: Added shared worker files.
- WebCore.pro: Added shared worker files.
- WebCore.vcproj/WebCore.vcproj: Added shared worker files.
- WebCore.xcodeproj/project.pbxproj: Added shared worker files.
- bindings/js/JSEventTarget.cpp: (WebCore::toJS): Added code to convert from EventTarget to correct JS class. (WebCore::toEventTarget): Added code to cast from JS object to appropriate EventTarget impl class.
- bindings/js/JSSharedWorkerConstructor.cpp: (WebCore::JSSharedWorkerConstructor::JSSharedWorkerConstructor): (WebCore::constructSharedWorker): Tweaked the constructor code to pass in the lexical global object like normal workers.
- bindings/js/JSSharedWorkerContextCustom.cpp: Added. (WebCore::JSSharedWorkerContext::mark): Custom marking of the onconnect handler.
- bindings/js/JSWorkerContextBase.cpp: (WebCore::toJSSharedWorkerContext): (WebCore::toJSWorkerContext): Added proper conversion to the correct WorkerContext derived class.
- bindings/js/JSWorkerContextBase.h:
- bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::initScript): Updated WorkerScriptController to create the correct type of binding object (JSSharedWorkerContext vs JSDedicatedWorkerContext)
- bindings/scripts/CodeGeneratorV8.pm: Added support for SharedWorkerContext.
- bindings/v8/DOMObjectsInclude.h: Added shared worker bindings files.
- dom/EventNames.h: Added connect event.
- dom/EventTarget.cpp: (WebCore::EventTarget::toSharedWorkerContext): Added API for casting to new derived class (SharedWorkerContext).
- dom/EventTarget.h:
- workers/AbstractWorker.cpp: (WebCore::AbstractWorker::resolveURL): Moved code that resolves/validates URLs to base class so it can be shared between dedicated/shared workers.
- workers/AbstractWorker.h:
- workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::logException): Refactored exception handling code - moved onerror handling to base class.
- workers/DedicatedWorkerContext.h: (WebCore::DedicatedWorkerContext::isDedicatedWorkerContext):
- workers/SharedWorker.cpp: (WebCore::SharedWorker::SharedWorker): Changed constructor to fire up worker thread.
- workers/SharedWorker.h:
- workers/SharedWorkerContext.cpp: Added. (WebCore::SharedWorkerContext::SharedWorkerContext): (WebCore::SharedWorkerContext::~SharedWorkerContext): (WebCore::SharedWorkerContext::logException): (WebCore::SharedWorkerContext::addMessage): Placeholder methods until we add support for sending exceptions/messages to console. (WebCore::SharedWorkerContext::dispatchConnect): (WebCore::SharedWorkerContext::thread):
- workers/SharedWorkerContext.h: Added. (WebCore::SharedWorkerContext::create): (WebCore::SharedWorkerContext::isSharedWorkerContext): (WebCore::SharedWorkerContext::toSharedWorkerContext): (WebCore::SharedWorkerContext::setOnconnect): (WebCore::SharedWorkerContext::onconnect): (WebCore::SharedWorkerContext::name):
- workers/SharedWorkerContext.idl: Added.
- workers/SharedWorkerRepository.h: Added. (WebCore::SharedWorkerRepository::~SharedWorkerRepository):
- workers/DefaultSharedWorkerRepository.cpp: Added. Implementation of core singleton class that will be used to implement sharing. (WebCore::SharedWorkerProxy::setThread): Proxy object used to handle resource loading for a given shared worker. (WebCore::SharedWorkerProxy::postTaskToLoader): (WebCore::SharedWorkerProxy::postTaskForModeToWorkerContext): Placeholder routines until we implement loading. (WebCore::SharedWorkerConnectTask::create): Creates a task to fire off a connect event on the worker thread. (WebCore::SharedWorkerConnectTask::SharedWorkerConnectTask): (WebCore::SharedWorkerConnectTask::performTask): (WebCore::SharedWorkerLoader::SharedWorkerLoader): Added helper object to load the initial script for the worker. (WebCore::SharedWorkerLoader::load): (WebCore::SharedWorkerLoader::notifyFinished): (WebCore::SharedWorkerRepository::instance): (WebCore::DefaultSharedWorkerRepository::instance): (WebCore::DefaultSharedWorkerRepository::workerScriptLoaded): Fires off the worker thread once the script is loaded. (WebCore::SharedWorkerRepository::connect): (WebCore::DefaultSharedWorkerRepository::DefaultSharedWorkerRepository): (WebCore::DefaultSharedWorkerRepository::~DefaultSharedWorkerRepository):
- workers/DefaultSharedWorkerRepository.h: Added.
- workers/SharedWorkerThread.cpp: Added. (WebCore::SharedWorkerThread::create): (WebCore::SharedWorkerThread::SharedWorkerThread): (WebCore::SharedWorkerThread::~SharedWorkerThread): (WebCore::SharedWorkerThread::createWorkerContext):
- workers/SharedWorkerThread.h: Added.
- workers/Worker.cpp: (WebCore::Worker::Worker):
- workers/WorkerContext.cpp: (WebCore::WorkerContext::reportException):
- workers/WorkerContext.h: (WebCore::WorkerContext::isSharedWorkerContext): (WebCore::WorkerContext::isDedicatedWorkerContext): Added APIs to determine the type of a given context.
LayoutTests:
2009-08-05 Drew Wilson <atwilson@google.com>
Reviewed by NOBODY (OOPS!).
SharedWorkers should instantiate a thread and a SharedWorkerContext
https://bugs.webkit.org/show_bug.cgi?id=27927
Added disabled tests for SharedWorker minimal functionality.
Began refactoring of dedicated worker tests to allow sharing test cases between shared and dedicated worker (will continue in another patch).
- fast/workers/resources/shared-worker-common.js: Added.
- fast/workers/resources/shared-worker-script-error.js: Added.
- fast/workers/resources/worker-replace-global-constructor.js: Moved common code into shared .js file.
- fast/workers/shared-worker-constructor.html-disabled:
- fast/workers/shared-worker-gc-expected.txt: Added.
- fast/workers/shared-worker-gc.html-disabled: Added.
- fast/workers/shared-worker-load-error-expected.txt: Added.
- fast/workers/shared-worker-load-error.html-disabled: Added.
- fast/workers/shared-worker-replace-global-constructor-expected.txt: Added.
- fast/workers/shared-worker-replace-global-constructor.html-disabled: Added.
- fast/workers/shared-worker-script-error-expected.txt: Added.
- fast/workers/shared-worker-script-error.html-disabled: Added.
- fast/workers/shared-worker-simple-expected.txt: Added.
- fast/workers/shared-worker-simple.html-disabled: Added.
- fast/workers/worker-replace-global-constructor.html:
- 8:12 AM Changeset in webkit [46844] by
-
- 6 edits in trunk
Added ENABLE_3D_CANVAS flag to build, default to off
- 7:59 AM BuildingGtk edited by
- (diff)
- 7:26 AM Changeset in webkit [46843] by
-
- 2 edits in trunk/WebCore
2009-08-06 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] windowsKeyCodeForKeyEvent fix
Fix windowsKeyCodeForKeyEvent to determine wheter the event comes from the keypad.
- platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
- 7:12 AM Changeset in webkit [46842] by
-
- 1 edit1 delete in trunk/WebCore
2009-08-06 George Staikos <george.staikos@torchmobile.com>
Rubber-stamped by Ariya Hidayat.
Remove the dead wince/ directory that should never have gone in.
- svg/graphics/wince: Removed.
- svg/graphics/wince/SVGResourceFilterWince.cpp: Removed.
- 2:52 AM Changeset in webkit [46841] by
-
- 6 edits1 add in trunk/WebCore
2009-08-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Extract style editing into a separate file that is
going to be loaded in page context.
- inspector/front-end/InjectedScript.js: Added. (InjectedScript.applyStyleText): (InjectedScript.setStyleText): (InjectedScript.toggleStyleEnabled): (InjectedScript.setStyleRule):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.callback): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 1:27 AM Changeset in webkit [46840] by
-
- 3 edits in trunk/WebCore
2009-08-06 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
[V8] Remove bug-bait V8Proxy::context()
https://bugs.webkit.org/show_bug.cgi?id=27826
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::updateDocumentWrapperCache): (WebCore::V8Proxy::initContextIfNeeded): (WebCore::V8Proxy::mainWorldContext):
- bindings/v8/V8Proxy.h:
- 1:17 AM Changeset in webkit [46839] by
-
- 2 edits in trunk/WebCore
2009-08-06 Adam Barth <abarth@webkit.org>
Unreviewed attempt to fix the Chromium Linux build. This function is
not used.
- bindings/v8/OwnHandle.h:
- 12:42 AM Changeset in webkit [46838] by
-
- 10 edits4 adds in trunk
WebCore:
2009-08-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[V8] Teach ScheduledAction::execute about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27703
We now save a weak handle to the original context. We use that handle
to call the timeout in the right context / world.
Tests: http/tests/security/isolatedWorld/window-setTimeout-function.html
http/tests/security/isolatedWorld/window-setTimeout-string.html
- bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::execute):
- bindings/v8/ScheduledAction.h: (WebCore::ScheduledAction::ScheduledAction):
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl):
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::SetTimeoutOrInterval):
LayoutTests:
2009-08-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[V8] Teach ScheduledAction::execute about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27703
Add test coverage for the interaction between setTimeout and isolated
worlds.
- http/tests/security/isolatedWorld/window-setTimeout-function-expected.txt: Added.
- http/tests/security/isolatedWorld/window-setTimeout-function.html: Added.
- http/tests/security/isolatedWorld/window-setTimeout-string-expected.txt: Added.
- http/tests/security/isolatedWorld/window-setTimeout-string.html: Added.
Aug 5, 2009:
- 11:57 PM Changeset in webkit [46837] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-05 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Allow custom memory allocation control for JavaScriptCore's ScopeNodeData struct
https://bugs.webkit.org/show_bug.cgi?id=27875
Inherits ScopeNodeData struct from FastAllocBase because it has been instantiated by
'new' in JavaScriptCore/parser/Nodes.cpp:1848.
- parser/Nodes.h:
- 11:53 PM Changeset in webkit [46836] by
-
- 2 edits in trunk/LayoutTests
2009-08-05 Xan Lopez <xlopez@igalia.com>
Skip new test using eventSender, since the GTK+ port does not have
it yet.
- platform/gtk/Skipped:
- 11:10 PM Changeset in webkit [46835] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 11:10 PM Changeset in webkit [46834] by
-
- 1 copy in tags/Safari-6531.10
New tag.
- 11:08 PM Changeset in webkit [46833] by
-
- 3 edits in branches/safari-4-branch/WebKit/win
Merge r46638.
- 10:33 PM Changeset in webkit [46832] by
-
- 5 edits in trunk/JavaScriptCore
2009-08-05 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Add floating point support for generic ARM port.
https://bugs.webkit.org/show_bug.cgi?id=24986
- assembler/ARMAssembler.cpp: (JSC::ARMAssembler::doubleTransfer):
- assembler/ARMAssembler.h: (JSC::ARM::): (JSC::ARMAssembler::): (JSC::ARMAssembler::faddd_r): (JSC::ARMAssembler::fsubd_r): (JSC::ARMAssembler::fmuld_r): (JSC::ARMAssembler::fcmpd_r): (JSC::ARMAssembler::fdtr_u): (JSC::ARMAssembler::fdtr_d): (JSC::ARMAssembler::fmsr_r): (JSC::ARMAssembler::fsitod_r): (JSC::ARMAssembler::fmstat):
- assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::): (JSC::MacroAssemblerARM::supportsFloatingPoint): (JSC::MacroAssemblerARM::loadDouble): (JSC::MacroAssemblerARM::storeDouble): (JSC::MacroAssemblerARM::addDouble): (JSC::MacroAssemblerARM::subDouble): (JSC::MacroAssemblerARM::mulDouble): (JSC::MacroAssemblerARM::convertInt32ToDouble): (JSC::MacroAssemblerARM::branchDouble):
- jit/JIT.h:
- 10:22 PM Changeset in webkit [46831] by
-
- 11 edits in trunk/JavaScriptCore
2009-08-05 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Add JIT support for generic ARM port without optimizations.
https://bugs.webkit.org/show_bug.cgi?id=24986
All JIT optimizations are disabled.
Signed off by Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Signed off by Gabor Loki <loki@inf.u-szeged.hu>
- assembler/ARMAssembler.cpp: (JSC::ARMAssembler::baseIndexTransfer32):
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Imm32::Imm32):
- assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::store32): (JSC::MacroAssemblerARM::move): (JSC::MacroAssemblerARM::branch32): (JSC::MacroAssemblerARM::add32): (JSC::MacroAssemblerARM::sub32): (JSC::MacroAssemblerARM::load32):
- bytecode/CodeBlock.h: (JSC::CodeBlock::getBytecodeIndex):
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference):
- jit/JITOpcodes.cpp:
- jit/JITStubs.cpp:
- jit/JITStubs.h: (JSC::JITStackFrame::returnAddressSlot):
- wtf/Platform.h:
- 10:19 PM Changeset in webkit [46830] by
-
- 4 edits in trunk/LayoutTests
2009-08-05 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
Need to test throwing exceptions from Workers after calling close().
https://bugs.webkit.org/show_bug.cgi?id=27924
- fast/workers/resources/worker-close.js:
- fast/workers/worker-close-expected.txt:
- fast/workers/worker-close.html:
- 8:50 PM Changeset in webkit [46829] by
-
- 5 edits in trunk/WebCore
2009-08-05 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[V8] Revert http://trac.webkit.org/changeset/46821, which was
landed to supplement http://trac.webkit.org/changeset/46816, but
now that the latter is reverted, the former needs the same.
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- 8:27 PM Changeset in webkit [46828] by
-
- 4 edits1 add in trunk/WebCore
2009-08-05 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Timothy Hatcher.
Color is only reported in rgb() format; should toggle between rgb() and hex
https://bugs.webkit.org/show_bug.cgi?id=13516
New Class to Parse and Change Between Color Representations:
- inspector/front-end/Color.js: Added. (WebInspector.Color):
Representations of Colors in Raw Form. (May be Lazy Loaded):
(WebInspector.Color.prototype.get shorthex):
(WebInspector.Color.prototype.get hex):
(WebInspector.Color.prototype.set hex):
(WebInspector.Color.prototype.get rgb):
(WebInspector.Color.prototype.set rgb):
(WebInspector.Color.prototype.get hsl):
(WebInspector.Color.prototype.set hsl):
(WebInspector.Color.prototype.get nickname):
(WebInspector.Color.prototype.set nickname):
(WebInspector.Color.prototype.get rgba):
(WebInspector.Color.prototype.set rgba):
(WebInspector.Color.prototype.get hsla):
(WebInspector.Color.prototype.set hsla):
Helpers and Standard String Representations:
(WebInspector.Color.prototype.hasShortHex):
(WebInspector.Color.prototype.toRgb):
(WebInspector.Color.prototype.toHsl):
(WebInspector.Color.prototype.toShortHex):
(WebInspector.Color.prototype.toHex):
(WebInspector.Color.prototype.toRgba):
(WebInspector.Color.prototype.toHsla):
(WebInspector.Color.prototype.toNickname):
Conversion Functions to Determine Other Representations:
My Sources for all algorithms and sample data:
Wikipedia: http://en.wikipedia.org/wiki/HSV_color_space
CSS Specification: http://www.w3.org/TR/css3-color/#hsla-color
(WebInspector.Color.prototype.rgbToHex):
(WebInspector.Color.prototype.hexToRgb):
(WebInspector.Color.prototype.rgbToHsl):
(WebInspector.Color.prototype.hslToRgb.hueToRgb):
(WebInspector.Color.prototype.hslToRgb):
(WebInspector.Color.prototype.rgbaToHsla):
(WebInspector.Color.prototype.hslaToRgba):
Called from the constructor, attempts to parse and will throw an error
if it cannot parse. If simple then the "hex" value is guarenteed.
If advanced then both the "rgba" and "hsla" are guarenteed. If it is
a nickname in any way (e.g. "transparent", "black") then this is
guarenteed to be set as well.
(WebInspector.Color.prototype.parse):
Clicking on the swatch will rotate through Color Representations.
Simple: rgb -> hsl -> nickname? -> shorthex? -> hex -> (loop around)
Advanced: rgba -> hsla -> nickname? -> (loop around)
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle.value.): (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
Load Color.js:
- inspector/front-end/inspector.html:
- 8:05 PM Changeset in webkit [46827] by
-
- 4 edits in trunk/WebCore
2009-08-05 John Abd-El-Malek <jam@chromium.org>
Reviewed by Dimitri Glazkov.
Support setting event listeners for message ports in the worker process.
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::retrieve): (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object):
- bindings/v8/WorkerContextExecutionProxy.h:
- bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::getEventListener): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
- 7:39 PM Changeset in webkit [46826] by
-
- 2 edits in trunk/WebCore
2009-08-05 Stephen White <senorblanco@chromium.org>
Reviewed by Dimitri Glazkov.
Minor fix for media code on chromium/skia.
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintMediaSliderTrack):
- 6:37 PM Changeset in webkit [46825] by
-
- 3 edits2 adds in trunk
WebCore:
2009-08-05 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Client side image maps did not handle zoom correctly.
Client side image maps did not handle border and padding correctly.
Test: fast/images/image-map-zoom.html
- rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint): Compute the values to pass in to the map element using the content box and the effective zoom.
LayoutTests:
2009-08-05 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Client side image maps did not handle zoom correctly.
Client side image maps did not handle border and padding correctly.
- fast/images/image-map-zoom-expected.txt: Added.
- fast/images/image-map-zoom.html: Added.
- 6:30 PM Changeset in webkit [46824] by
-
- 5 edits in trunk
Add more missing ResourceLoadDelegate methods for WinDRT, and remove another test from the skipped list.
- 5:52 PM WebKit Team edited by
- (diff)
- 5:12 PM Changeset in webkit [46823] by
-
- 14 edits5 deletes in trunk
Roll out r46816 as it broke many tests.
- 5:11 PM Changeset in webkit [46822] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=28027
<rdar://7064428> Files with accents in names are submitted incorrectly due to use of
precomposed Unicode
- platform/network/mac/FormDataStreamMac.mm: (WebCore::setHTTPBody): Use getFileSize() from FileSystem.h instead of custom code for getting file size. This adds path normalization necessary with some file systems on Mac. This also loses a S_IFMT check, which didn't seem important anyway.
- 4:47 PM Changeset in webkit [46821] by
-
- 5 edits in trunk/WebCore
2009-08-05 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[V8] Include Media into V8 bindings.
- bindings/v8/DOMObjectsInclude.h: Added Media include.
- bindings/v8/DerivedSourcesAllInOne.cpp: Added V8Media include.
- bindings/v8/V8Index.cpp: Added decl for V8Media.
- bindings/v8/V8Index.h: Added V8Media include.
- 4:41 PM Changeset in webkit [46820] by
-
- 5 edits1 delete in trunk
WebKitTools:
2009-08-05 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
Win DRT's resource load delegate is missing didReceiveResponse
https://bugs.webkit.org/show_bug.cgi?id=28033
- DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveResponse):
- DumpRenderTree/win/ResourceLoadDelegate.h:
LayoutTests:
2009-08-05 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
Win DRT's resource load delegate is missing didReceiveResponse
https://bugs.webkit.org/show_bug.cgi?id=28033
- platform/win/Skipped: Remove a test that now passes
Remove platform specific results for the XFrameOptions suite which now matches cross platform results:
- platform/win/http/tests/security: Removed.
- platform/win/http/tests/security/XFrameOptions: Removed.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Removed.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt: Removed.
- 4:18 PM Changeset in webkit [46819] by
-
- 4 edits in trunk/WebCore
2009-08-04 Jon Honeycutt <jhoneycutt@apple.com>
Fix Windows layout test crashes.
PluginView::removeFromUnstartedListIfNecessary() would try to remove
any unstarted PluginView from the Page's set of unstarted plug-ins,
regardless of why the PluginView wasn't started. If we tried to start a
plug-in, but it failed to start, we would hit an assertion in
Page::removeUnstartedPlugin() that asserts that we would only modify the
unstarted plug-ins set if we were not currently starting plug-ins.
Fix this by having PluginView track whether it's waiting to be started,
and to check this before trying to remove itself from the Page's
unstarted plug-ins set.
Reviewed by Darin Adler.
- page/Page.cpp: (WebCore::Page::removeUnstartedPlugin): Assert that the passed PluginView is in the unstarted set.
- plugins/PluginView.cpp: (WebCore::PluginView::start): Set that we are not waiting to be started. (WebCore::PluginView::startOrAddtoUnstartedList): Set that we are waiting to be started. (WebCore::PluginView::removeFromUnstartedListIfNecessary): Check not whether we are started, but whether we are waiting to be started. (WebCore::PluginView::PluginView):
- plugins/PluginView.h:
- 3:48 PM Changeset in webkit [46818] by
-
- 2 edits in trunk/WebCore
2009-08-05 Jeremy Orlow <jorlow@chromium.org>
Fix DOM Storage memory leak
https://bugs.webkit.org/show_bug.cgi?id=28029
Forgot to use adoptRef in one place. This caused the = operator to
increment the ref count when it shouldn't have, so StorageAreaImpl's were
never freed.
- storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::storageArea):
- 2:51 PM Changeset in webkit [46817] by
-
- 2 edits in trunk/WebCore
2009-08-05 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[Chromium] Let CodeGeneratorV8.pm know that Media is ref-counted.
- bindings/scripts/CodeGeneratorV8.pm: Added Media check to IsRefPtrType.
- 2:26 PM Changeset in webkit [46816] by
-
- 14 edits2 copies3 adds in trunk
2009-08-05 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Implement the matchMedium method on the Media interface described in the CSSOM View Module.
https://bugs.webkit.org/show_bug.cgi?id=22495
Add a new Media interface, obtainable via the AbstractView, that can
evaluate queries via its matchesMedium() method.
Test: fast/media/matchmedium-query-api.html
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl: Add Media.* files to the build.
- css/Media.cpp: Added. (WebCore::Media::Media): (WebCore::Media::type): (WebCore::Media::matchMedium):
- css/Media.h: Added. (WebCore::Media::create): (WebCore::Media::document):
- css/Media.idl: Added. Media::matchMedium() uses a MediaQueryEvaluator() to test the query.
- page/AbstractView.idl:
- page/DOMWindow.cpp: (WebCore::DOMWindow::media):
- page/DOMWindow.h:
- page/DOMWindow.idl: Add a readonly attribute for Media.
- 2:25 PM Changeset in webkit [46815] by
-
- 96 edits in trunk/WebCore
2009-08-05 Darin Adler <Darin Adler>
Reviewed by David Levin.
Use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522
Last patch. Makes all the casts of RenderObject use checked
casts instead of using static_cast directly.
- accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::visibleChildren): (WebCore::AccessibilityListBox::doAccessibilityHitTest):
- accessibility/AccessibilityListBoxOption.cpp: (WebCore::AccessibilityListBoxOption::elementRect):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::textUnderElement): (WebCore::AccessibilityRenderObject::stringValue): (WebCore::AccessibilityRenderObject::titleUIElement): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
- accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySliderThumb::elementRect):
- dom/InputElement.cpp: (WebCore::InputElement::updatePlaceholderVisibility):
- dom/SelectElement.cpp: (WebCore::SelectElement::scrollToSelection): (WebCore::SelectElement::recalcStyle): (WebCore::SelectElement::setRecalcListItems): (WebCore::SelectElement::menuListDefaultEventHandler): (WebCore::SelectElement::listBoxDefaultEventHandler):
- editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
- html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::renderWidgetForJSBindings):
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::reset):
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::updateWidget):
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::attach):
- html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::defaultEventHandler):
- html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::attach):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): (WebCore::HTMLInputElement::addSearchResult): (WebCore::HTMLInputElement::onSearch):
- html/HTMLLIElement.cpp: (WebCore::HTMLLIElement::parseMappedAttribute): (WebCore::HTMLLIElement::attach):
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::mediaPlayerDurationChanged): (WebCore::HTMLMediaElement::mediaPlayerSizeChanged): (WebCore::HTMLMediaElement::mediaPlayerRenderingCanBeAccelerated): (WebCore::HTMLMediaElement::mediaPlayerGraphicsLayer): (WebCore::HTMLMediaElement::defaultEventHandler): (WebCore::HTMLMediaElement::finishParsingChildren):
- html/HTMLOListElement.cpp: (WebCore::HTMLOListElement::parseMappedAttribute):
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::updateWidget):
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::defaultEventHandler):
- page/DragController.cpp: (WebCore::DragController::concludeEditDrag):
- page/EventHandler.cpp: (WebCore::EventHandler::selectCursor): (WebCore::EventHandler::capsLockStateMayHaveChanged):
- page/Frame.cpp: (WebCore::Frame::ownerRenderer):
- page/FrameView.cpp: (WebCore::FrameView::detachCustomScrollbars):
- page/wince/FrameWince.cpp: (WebCore::computePageRectsForFrame):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally):
- rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::defaultEventHandler):
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):
- rendering/RenderCounter.cpp: (WebCore::planCounter):
- rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::computeEdgeInfo): (WebCore::RenderFrameSet::setIsResizing):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::contentsBox):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking): (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
- rendering/RenderListItem.cpp: (WebCore::previousListItem): (WebCore::RenderListItem::explicitValueChanged):
- rendering/RenderObject.cpp: (WebCore::updateListMarkerNumbers):
- rendering/RenderObjectChildList.cpp: (WebCore::updateListMarkerNumbers): (WebCore::invalidateCountersInContainer):
- rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::minimumThumbLength): (WebCore::RenderScrollbarTheme::backButtonRect): (WebCore::RenderScrollbarTheme::forwardButtonRect): (WebCore::RenderScrollbarTheme::trackRect): (WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces): (WebCore::RenderScrollbarTheme::paintScrollbarBackground): (WebCore::RenderScrollbarTheme::paintTrackBackground): (WebCore::RenderScrollbarTheme::paintTrackPiece): (WebCore::RenderScrollbarTheme::paintButton): (WebCore::RenderScrollbarTheme::paintThumb):
- rendering/RenderSlider.cpp: (WebCore::SliderThumbElement::defaultEventHandler):
- rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::paintSliderThumb): (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::determineSliderThumbState):
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSliderThumb):
- rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintSliderThumb):
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::determineSliderThumbState):
- rendering/SVGCharacterLayoutInfo.cpp: (WebCore::SVGCharacterLayoutInfo::addLayoutInformation):
- rendering/SVGRootInlineBox.cpp: (WebCore::findSVGRootObject):
- rendering/TextControlInnerElements.cpp: (WebCore::RenderTextControlInnerBlock::nodeAtPoint): (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::attach):
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::canvasResource):
- svg/SVGTextContentElement.cpp: (WebCore::rootInlineBoxForTextContentElement):
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler): Use checked casts.
- rendering/RenderApplet.h:
- rendering/RenderCounter.h:
- rendering/RenderFieldset.h:
- rendering/RenderFileUploadControl.h:
- rendering/RenderFrame.h:
- rendering/RenderFrameSet.h:
- rendering/RenderHTMLCanvas.h:
- rendering/RenderListBox.h:
- rendering/RenderListItem.h:
- rendering/RenderListMarker.h:
- rendering/RenderMedia.h:
- rendering/RenderMenuList.h:
- rendering/RenderPart.h:
- rendering/RenderPartObject.h:
- rendering/RenderPath.h:
- rendering/RenderSVGContainer.h:
- rendering/RenderSVGRoot.h:
- rendering/RenderSVGTextPath.h:
- rendering/RenderSVGViewportContainer.h:
- rendering/RenderScrollbar.h:
- rendering/RenderSlider.h:
- rendering/RenderTextControlMultiLine.h:
- rendering/RenderTextControlSingleLine.h:
- rendering/RenderVideo.h: Added a checked cast. Also made most members protected or private.
- rendering/RenderBlock.h:
- rendering/RenderInline.h:
- rendering/RenderReplaced.h:
- rendering/RenderSVGBlock.h:
- rendering/RenderSVGImage.h:
- rendering/RenderSVGInlineText.h:
- rendering/RenderSVGText.h:
- rendering/RenderTextControl.h: Made most members protected or private.
- rendering/RenderInline.cpp:
- rendering/RenderSVGContainer.cpp:
- rendering/RenderSVGHiddenContainer.cpp:
- rendering/RenderSVGImage.cpp:
- rendering/RenderSVGRoot.cpp: Removed unneeded destructor.
- rendering/RenderSVGHiddenContainer.h: Removed unneeded virtual function overrides that did the same as the default and base class.
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::paint): Updated to use m_viewport directly instead of using a function call. (WebCore::RenderSVGViewportContainer::applyViewportClip): Ditto. (WebCore::RenderSVGViewportContainer::viewportTransform): Ditto. (WebCore::RenderSVGViewportContainer::localToParentTransform): Ditto. (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip): Ditto.
- rendering/RenderScrollbar.cpp: (WebCore::pseudoForScrollbarPart): Changed switch statement to use cases for all values instead of using a default case.
- rendering/RenderTreeAsText.cpp: (WebCore::operator<<): Removed dependency on casting to types that don't have any public members we need to get at. Instead, use function names to identify the type rather than doing so much overloading. Changed to use checked casts. (WebCore::write): Ditto.
- rendering/SVGRenderSupport.cpp: (WebCore::renderSubtreeToImage): Changed to use a checked cast and also added a comment about the fact that the code does not do sufficient type checking before doing the cast.
- rendering/SVGRenderTreeAsText.cpp: (WebCore::writeRenderSVGTextBox): Renamed this from operator<<. (WebCore::writeSVGInlineTextBoxes): Renamed this from writeSVGInlineText. (WebCore::writeSVGText): Renamed this from write. (WebCore::writeSVGInlineText): Ditto. (WebCore::writeSVGImage): Ditto.
- rendering/SVGRenderTreeAsText.h: Updated for name changes. Removed unneeded default arguments.
- 2:14 PM Changeset in webkit [46814] by
-
- 3 edits in trunk/WebCore
2009-08-05 Peter Kasting <pkasting@google.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=27851
Fix a pair of compiler warnings on the GTK Linux buildbot.
- platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::processFileHeader): Don't use multi-character constants, they're not portable.
- platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::setSize): Simpler code that also doesn't compare signed with unsigned.
- 2:00 PM Changeset in webkit [46813] by
-
- 1 edit4 copies in trunk/LayoutTests
2009-08-05 Brady Eidson <beidson@apple.com>
Rubberstamped by Mark Rowe.
As a followup to http://trac.webkit.org/changeset/46811, Windows-specific results *did* have some differences, so restoring those results.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt.
- 1:46 PM Changeset in webkit [46812] by
-
- 1 edit6 deletes in trunk/LayoutTests
2009-08-05 Brady Eidson <beidson@apple.com>
Rubberstamped by Mark Rowe.
Actually, for all 6 of these tests Tiger now matches the cross-platform results, so removing all the Tiger results.
- platform/mac-tiger/http/tests/loading/redirect-methods-expected.txt: Removed.
- platform/mac-tiger/http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Removed.
- platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
- platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
- platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Removed.
- platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
- 1:31 PM Changeset in webkit [46811] by
-
- 1 edit4 deletes in trunk/LayoutTests
2009-08-05 Brady Eidson <beidson@apple.com>
Rubberstamped by Mark Rowe.
As a followup to http://trac.webkit.org/changeset/46809, Windows-specific results now match the cross-platform results,
so I'm removing them.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Removed.
- platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
- 1:26 PM Changeset in webkit [46810] by
-
- 3 edits in trunk/LayoutTests
2009-08-05 Brady Eidson <beidson@apple.com>
Rubberstamped by Mark Rowe.
As a followup to http://trac.webkit.org/changeset/46809, update Tiger platform specific results for these tests.
- platform/mac-tiger/http/tests/loading/redirect-methods-expected.txt:
- platform/mac-tiger/http/tests/misc/favicon-loads-with-images-disabled-expected.txt:
- 1:16 PM Changeset in webkit [46809] by
-
- 12 edits in trunk
2009-08-05 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
Add layoutTestController.dumpWillCacheResponse
https://bugs.webkit.org/show_bug.cgi?id=28010
willCacheResponse is only interesting for embedders of mainline WebKit on Mac.
Splitting off a new dumpWillCacheResponse allows a number of existings tests
to run across platforms.
The test that was specifically verifying willCacheResponse now calls
dumpWillCacheResponse.
- DumpRenderTree/LayoutTestController.cpp: Add dumpWillCacheResponse (LayoutTestController::LayoutTestController): (dumpWillCacheResponseCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpWillCacheResponse): (LayoutTestController::setDumpWillCacheResponse):
- DumpRenderTree/mac/ResourceLoadDelegate.mm: Inspect dumpWillCacheResponse instead of dumpResourceLoadCallbacks. (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
- 12:56 PM Changeset in webkit [46808] by
-
- 4 edits in trunk/LayoutTests
Fix two tests to not load a resource that takes five seconds to load.
Reviewed by Brady Eidson.
We achieve this by making the delay in slow-resource.pl configurable in a query parameter.
This drops the run time of each of the tests from over five seconds to less than a third
of a second.
- http/tests/misc/DOMContentLoaded-event.html:
- http/tests/navigation/multiple-back-forward-entries.html:
- http/tests/navigation/resources/slow-resource.pl:
- 12:36 PM Changeset in webkit [46807] by
-
- 7 edits1 delete in trunk/WebCore
2009-08-05 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26460
Return multiple icon entries from the ICO decoder as separate frames,
sorted by decreasing quality (much like the CG ICO decoder does).
As a result of this change, we can eliminate the Skia-specific setData()
hack that the Chromium port used to select the desired icon size -- now
callers can just enumerate the frames and ask for the data from the one
they like.
Under the hood, the ICO decoder now keeps vectors for a number of things
(including directory entries and image decoders) where it used to have
single members. However, callers (that I have seen) will only request
one frame from the icon, so practically there aren't going to be lots of
instantiated image decoders.
- platform/graphics/ImageSource.h: Move |m_decoder| back to private now that Skia no longer needs to access it.
- platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::createDecoder): Remove size argument from ICO decoder instantiation.
- platform/graphics/skia/ImageSourceSkia.cpp: (WebCore::createDecoder): Remove size argument from ICO decoder instantiation. (WebCore::ImageSource::setData): Remove function to ask for a particular icon size.
- platform/graphics/skia/ImageSourceSkia.h: Removed.
- platform/graphics/wx/ImageSourceWx.cpp: (WebCore::createDecoder): Remove size argument from ICO decoder instantiation.
- platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::~ICOImageDecoder): Delete all instantiated per-frame decoders. (WebCore::ICOImageDecoder::setData): Send data to all instantiated per-frame decoders. (WebCore::ICOImageDecoder::isSizeAvailable): Use size from icon directory instead of PNG decoder (if applicable) so we can report it without decoding the PNG frames. (WebCore::ICOImageDecoder::size): Report frame-specific size if BMP decoder is calling. Otherwise, use size from icon directory instead of PNG decoder (if applicable). (WebCore::ICOImageDecoder::frameSizeAtIndex): Implement. (WebCore::ICOImageDecoder::setSize): Sanity check value if BMP decoder is calling. (WebCore::ICOImageDecoder::frameCount): Implement. (WebCore::ICOImageDecoder::frameBufferAtIndex): Sanity check size for PNG frames. (WebCore::ICOImageDecoder::compareEntries): Add utility function for sorting entries. (WebCore::ICOImageDecoder::setDataForPNGDecoderAtIndex): Factor out utility function for passing correct data blob to a PNG decoder. (WebCore::ICOImageDecoder::decodeWithCheckForDataEnded): Split decode() into two pieces. (WebCore::ICOImageDecoder::decodeDirectory): The first part of the old decode(). (WebCore::ICOImageDecoder::decodeAtIndex): The second part of the old decode(), split off so we avoid decoding an entry until it's requested. (WebCore::ICOImageDecoder::processDirectory): Add resizing of internal data structures based on directory contents. (WebCore::ICOImageDecoder::processDirectoryEntries): Sort entries by quality. (WebCore::ICOImageDecoder::imageTypeAtIndex): Return type to caller instead of setting a member.
- platform/image-decoders/ico/ICOImageDecoder.h:
- 11:38 AM Changeset in webkit [46806] by
-
- 3 edits2 adds in trunk
2009-08-05 Szabo Carol <carol.szabo@nokia.com>
Reviewed by Darin Adler.
Test for https://bugs.webkit.org/show_bug.cgi?id=27942
Form Reset does not work per w3c standard when single selection
SELECT element has more than one option marked as selected.
- fast/forms/select-reset-multiple-selections-4-single-selection-expected.txt: Added.
- fast/forms/select-reset-multiple-selections-4-single-selection.html: Added.
2009-08-05 Szabo Carol <carol.szabo@nokia.com>
Reviewed by Darin Adler.
Test: fast/forms/select-reset-multiple-selections-4-single-selection.html
- dom/SelectElement.cpp: (WebCore::SelectElement::reset):
Added HTML 4.01 compliant handling of broken webpages that
specify more than one selected option for single selection SELECT
element, in a manner that emulates Firefox and is similar to IE 7
- 11:22 AM Changeset in webkit [46805] by
-
- 2 edits in trunk/WebKitTools
2009-08-05 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
Add my name to committers.py
https://bugs.webkit.org/show_bug.cgi?id=28013
Add my name to committers.py.
- Scripts/modules/committers.py:
- 8:17 AM Changeset in webkit [46804] by
-
- 2 edits in trunk/WebCore
2009-08-05 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
WebCore.pro bugfix
Fix the gperf lines to properly include the string.h header at compilation with gperf version 3.0.3 and newer.
- WebCore.pro:
- 8:14 AM Changeset in webkit [46803] by
-
- 2 edits in trunk/WebKit/qt
2009-08-05 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Simon Hausmann.
[Qt] Fix build error caused by http://trac.webkit.org/changeset/46763
- Api/qwebpluginfactory.h: Export macro added.
- 7:56 AM Changeset in webkit [46802] by
-
- 3 edits in trunk/WebKitTools
2009-08-05 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
A minor refactoring of the Qt DRT to be a bit more similar to
the other DRTs, as well as more understandable.
Splitting up resetJSObjects into a LayoutTestController->reset()
plus a new closeRemainingWindows() method.
Added a resetToConsistentStateBeforeTesting() method to keep
the code in one place, making it easier to verify that we are
doing things properly.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::closeRemainingWindows):
- DumpRenderTree/qt/DumpRenderTree.h:
- 7:51 AM Changeset in webkit [46801] by
-
- 5 edits in trunk/WebKitTools
2009-08-05 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
Make the Qt DRT WorkQueue work similarily to the cross platform
one. This means that all items return true if they started
loading.
This change paves the way for unforking the WorkQueue, if we [Qt]
would like that.
- DumpRenderTree/qt/WorkQueue.cpp: (WorkQueue::processWork):
- DumpRenderTree/qt/WorkQueue.h:
- DumpRenderTree/qt/WorkQueueItem.h:
- DumpRenderTree/qt/jsobjects.cpp: (LoadItem::invoke): (ReloadItem::invoke): (ScriptItem::invoke): (BackForwardItem::invoke): (LayoutTestController::processWork): (LayoutTestController::maybeDump):
- 7:48 AM Changeset in webkit [46800] by
-
- 2 edits in trunk/WebKitTools
2009-08-04 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
If load of a test fails, don't dump as it will be dumped
in the preceding test, resulting in a invalid incorrect layout.
- DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::maybeDump):
- 7:46 AM Changeset in webkit [46799] by
-
- 2 edits in trunk/WebKitTools
2009-08-04 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
Make the Qt DumpRenderTree more similar to the mac one.
Changes include:
1) Reset zoom factor before each test
2) Only dump the backforward list when we got other dump result
3) When we dump the render tree, and got zero result print out:
[mainFrame renderTreeAsExternalRepresentation]
and not:
[frame renderTreeAsExternalRepresentation]
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open): (WebCore::methodNameStringForFailedTest): (WebCore::DumpRenderTree::dump):
- 7:39 AM Changeset in webkit [46798] by
-
- 4 edits in trunk
WebCore:
2009-08-05 Chris Fleizach <Chris Fleizach>
Fix Tiger build breakage.
- accessibility/mac/AccessibilityObjectWrapper.mm:
WebKitTools:
2009-08-05 chris fleizach <Chris Fleizach>
Fix Tiger build breakage.
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
- 5:40 AM EFLWebKit edited by
- (diff)
- 4:40 AM Changeset in webkit [46797] by
-
- 2 edits in trunk
2009-08-05 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] macros in webkit.m4 should be defined once only
https://bugs.webkit.org/show_bug.cgi?id=27929
The macros in webkit.m4 are not meant to be called multiple times
so we'll make them AC_DEFUN_ONCE. Also make AC_HEADER_STDC and AC_PROG_CXX
AC_REQUIRE to remove the automake warnings when doing autogen.sh.
Lastly, make sure CXXFLAGS and CFLAGS are defined before
AC_PROG_CXX gets expanded so it doesn't add "-g -O2" on Release builds.
- autotools/webkit.m4:
- 1:13 AM Changeset in webkit [46796] by
-
- 2 edits in trunk
2009-08-05 Xan Lopez <xlopez@igalia.com>
Revert r46714, it was making us build debug images by default.
- autotools/webkit.m4:
Aug 4, 2009:
- 10:50 PM Changeset in webkit [46795] by
-
- 2 edits in trunk/WebCore
2009-08-04 Simon Hausmann <Simon Hausmann>
Prospective build fix for Qt build bot: Fix dependency of HTMLNames.cpp
to both source files, HTMLTagNames.in and HTMLAttributeNames.in
- WebCore.pro:
- 10:40 PM Changeset in webkit [46794] by
-
- 18 edits in trunk/LayoutTests
2009-08-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[V8] Teach ScheduledAction::execute about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27703
Rename queueScriptInIsolatedWorld to evaluateScriptInIsolatedWorld
because I've changed this API to be synchronous instead of asynchronous
to work around some strange behavior in the work_queue_. Turns out we
don't need the complexity of an asynchronous API to test this feature.
- http/tests/security/isolatedWorld/all-window-properties.html:
- http/tests/security/isolatedWorld/all-window-prototypes.html:
- http/tests/security/isolatedWorld/body-properties.html:
- http/tests/security/isolatedWorld/body-prototype.html:
- http/tests/security/isolatedWorld/click-event.html:
- http/tests/security/isolatedWorld/document-open.html:
- http/tests/security/isolatedWorld/document-properties.html:
- http/tests/security/isolatedWorld/document-prototype.html:
- http/tests/security/isolatedWorld/global-variables.html:
- http/tests/security/isolatedWorld/image-properties.html:
- http/tests/security/isolatedWorld/image-prototype.html:
- http/tests/security/isolatedWorld/location-properties.html:
- http/tests/security/isolatedWorld/location-prototype.html:
- http/tests/security/isolatedWorld/number-prototype.html:
- http/tests/security/isolatedWorld/object-prototype.html:
- http/tests/security/isolatedWorld/string-prototype.html:
- http/tests/security/isolatedWorld/window-properties.html:
- 10:20 PM Changeset in webkit [46793] by
-
- 2 edits in trunk/WebCore
2009-08-04 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adele Peterson.
Keypress should exit from pan scrolling mode.
https://bugs.webkit.org/show_bug.cgi?id=28005
Change the logic from only exiting pan scrolling on escape to exiting on any key press,
making it easier for users to back out of an accidental pan scroll.
- page/EventHandler.cpp: (WebCore::EventHandler::keyEvent):
- 9:36 PM Changeset in webkit [46792] by
-
- 5 edits1 add in trunk
2009-08-04 Eric Seidel <eric@webkit.org>
Reviewed by Simon Fraser.
REGRESSION (r45064): Drop caret remains in text control after the mouse exits
https://bugs.webkit.org/show_bug.cgi?id=26787
Fix some bogus comments noticed during testing.
- fast/forms/drag-into-textarea.html:
- fast/forms/drag-out-of-textarea.html:
2009-08-04 Eric Seidel <eric@webkit.org>
Reviewed by Simon Fraser.
REGRESSION (r45064): Drop caret remains in text control after the mouse exits
https://bugs.webkit.org/show_bug.cgi?id=26787
Add back missing dragController()->clear() call.
- manual-tests/drag-caret.html: Added.
- page/DragController.cpp: (WebCore::DragController::tryDocumentDrag):
- 7:22 PM Changeset in webkit [46791] by
-
- 2 edits in trunk/WebKit/win
2009-08-04 Alice Liu <alice.liu@apple.com>
"Shift + Enter" should behave like "Enter" in editable fields.
Affects backward search in find-in-page in Safari for Windows
Reviewed by Jon Honeycutt.
- WebView.cpp: Register shift+enter as InsertNewline command, similar to other modifier+Enter combinations.
- 6:34 PM Changeset in webkit [46790] by
-
- 2 edits1 add5 deletes in trunk/LayoutTests
2009-08-04 Chris Fleizach <Chris Fleizach>
Reviewed by Darin Adler.
Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=27994
- platform/mac/accessibility/aria-valuetext-expected.txt: Added.
- platform/mac/accessibility/aria-valuetext.html: Added.
- 5:32 PM Changeset in webkit [46789] by
-
- 2 edits in trunk/WebCore
2009-08-04 Chris Fleizach <Chris Fleizach>
Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=27994
Forgot to commit attribute names.
- html/HTMLAttributeNames.in:
- 5:29 PM Changeset in webkit [46788] by
-
- 11 edits2 adds in trunk
WebCore:
2009-08-04 Chris Fleizach <Chris Fleizach>
Reviewed by Darin Adler.
Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=27994
Test: platform/mac/accessibility/aria-valuetext.html
- accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::valueDescription):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::valueDescription):
- accessibility/AccessibilityRenderObject.h:
- accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
- html/HTMLAttributeNames.in:
WebKitTools:
2009-08-04 Chris Fleizach <Chris Fleizach>
Reviewed by Darin Adler.
Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=27994
Expose valueDescription for accessibility.
- DumpRenderTree/AccessibilityUIElement.cpp: (getValueDescriptionCallback): (AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::valueDescription):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::valueDescription):
LayoutTests:
2009-08-04 Chris Fleizach <Chris Fleizach>
Reviewed by Darin Adler.
Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=27994
- platform/mac/accessibility/aria-valuetext-expected.txt: Added.
- platform/mac/accessibility/aria-valuetext.html: Added.
- 5:21 PM Changeset in webkit [46787] by
-
- 2 edits in trunk/WebKitTools
2009-08-04 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
REGRESSION: run-webkit-tests crashes if you have non-system perl in PATH
https://bugs.webkit.org/show_bug.cgi?id=28006
Hard-code perl to /usr/bin/perl and swig to /usr/bin/swig
- DumpRenderTree/mac/PerlSupport/Makefile:
- 5:18 PM Changeset in webkit [46786] by
-
- 19 edits in trunk
2009-08-04 Michael Nordman <Michael Nordman>
Reviewed by Alexey Proskuryakov.
No new features, no new tests. Existing layout tests pass.
- WebCore.base.exp:
Export AppliationCacheGroup::storeCopyOfCache
- WebCore.xcodeproj/project.pbxproj:
Restore DOMApplicationCache.h and ApplicationCacheHost.h to 'project' headers
instead of 'private' headers since they're no longer in the DocumentLoader.h
include graph.
- html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::insertedIntoDocument):
Reinstate the test for manifest.isNull instead of .isEmtpty().
Added a FIXME to revisit once the spec gets clarified.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::mainReceivedError): (WebCore::DocumentLoader::detachFromFrame):
- loader/DocumentLoader.h: (WebCore::DocumentLoader::applicationCacheHost):
ApplicationCacheHost is held in an OwnPtr<> by DocumentLoader. This was done
for compile time friendliness, it results in a smaller include graph for files
dependent on DocumentLoader.h.
- loader/FrameLoader.cpp:
- loader/MainResourceLoader.cpp:
- loader/ResourceLoader.cpp:
Cleanup ussage of ENABLE(xxx) around includes, generally remove those guards.
This was done for readability at the include site. The included files contain appropriate guards,
so they're not needed at the include site.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): (WebCore::ApplicationCacheGroup::failedLoadingMainResource): (WebCore::ApplicationCacheGroup::update): (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::manifestNotFound): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): (WebCore::ApplicationCacheGroup::startLoadingEntry): (WebCore::CallCacheListenerTask::create): (WebCore::CallCacheListenerTask::performTask): (WebCore::CallCacheListenerTask::CallCacheListenerTask): (WebCore::ApplicationCacheGroup::postListenerTask):
- loader/appcache/ApplicationCacheGroup.h:
Use ApplicationCachHost defined constants, no longer depends on DOMApplicationCache.
- loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::ApplicationCacheHost): (WebCore::ApplicationCacheHost::setDOMApplicationCache): (WebCore::ApplicationCacheHost::notifyEventListener): (WebCore::ApplicationCacheHost::status):
- loader/appcache/ApplicationCacheHost.h: (WebCore::ApplicationCacheHost::):
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::storeCopyOfCache):
- loader/appcache/ApplicationCacheStorage.h:
Merge recently added transferApplicationCache and pre-existing storeCopyOfCache methods.
- loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::status): (WebCore::DOMApplicationCache::addEventListener): (WebCore::DOMApplicationCache::removeEventListener): (WebCore::DOMApplicationCache::callListener): (WebCore::DOMApplicationCache::toEventType): (WebCore::DOMApplicationCache::toEventID):
- loader/appcache/DOMApplicationCache.h: (WebCore::DOMApplicationCache::setAttributeEventListener): (WebCore::DOMApplicationCache::getAttributeEventListener): (WebCore::DOMApplicationCache::clearAttributeEventListener): (WebCore::DOMApplicationCache::callEventListener): (WebCore::DOMApplicationCache::setOnchecking): (WebCore::DOMApplicationCache::onchecking): (WebCore::DOMApplicationCache::setOnerror): (WebCore::DOMApplicationCache::onerror): (WebCore::DOMApplicationCache::setOnnoupdate): (WebCore::DOMApplicationCache::onnoupdate): (WebCore::DOMApplicationCache::setOndownloading): (WebCore::DOMApplicationCache::ondownloading): (WebCore::DOMApplicationCache::setOnprogress): (WebCore::DOMApplicationCache::onprogress): (WebCore::DOMApplicationCache::setOnupdateready): (WebCore::DOMApplicationCache::onupdateready): (WebCore::DOMApplicationCache::setOncached): (WebCore::DOMApplicationCache::oncached): (WebCore::DOMApplicationCache::setOnobsolete): (WebCore::DOMApplicationCache::onobsolete):
Use ApplicationCachHost defined constants for Status and EventIDs.
- 4:31 PM Changeset in webkit [46785] by
-
- 2 edits in trunk/WebKitTools
2009-08-04 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Add pkasting to bugzilla-tool as a committer
https://bugs.webkit.org/show_bug.cgi?id=28002
- Scripts/modules/committers.py:
- 4:20 PM Changeset in webkit [46784] by
-
- 3 edits in trunk/WebCore
2009-08-04 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Revert r46421 and r46769, which appear to have totally hosed the v8 bindings.
- 4:04 PM Changeset in webkit [46783] by
-
- 15 edits2 adds in trunk
WebCore:
2009-08-04 Chris Fleizach <Chris Fleizach>
Reviewed by Darin Adler.
Bug 27993 - AXSliders are missing required attributes and actions
https://bugs.webkit.org/show_bug.cgi?id=27993
Expose appropriate actions and attributes for sliders.
Test: platform/mac/accessibility/slider-supports-actions.html
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::orientation):
- accessibility/AccessibilityObject.h: (WebCore::):
- accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySlider::orientation):
- accessibility/AccessibilitySlider.h:
- accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityActionNames]): (-[AccessibilityObjectWrapper accessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
WebKitTools:
2009-08-04 Chris Fleizach <Chris Fleizach>
Reviewed by Darin Adler.
Bug 27993 - AXSliders are missing required attributes and actions
https://bugs.webkit.org/show_bug.cgi?id=27993
Add ability to check if any arbitrary action is supported.
- DumpRenderTree/AccessibilityUIElement.cpp: (isActionSupportedCallback): (AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::isActionSupported):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::isActionSupported):
LayoutTests:
2009-08-04 Chris Fleizach <Chris Fleizach>
Reviewed by Darin Adler.
Bug 27993 - AXSliders are missing required attributes and actions
https://bugs.webkit.org/show_bug.cgi?id=27993
Update tests to use more generic isActionSupported.
- accessibility/aria-link-supports-press.html:
- accessibility/button-press-action.html:
- accessibility/onclick-handlers.html:
- platform/mac/accessibility/slider-supports-actions-expected.txt: Added.
- platform/mac/accessibility/slider-supports-actions.html: Added.
- 3:52 PM Changeset in webkit [46782] by
-
- 2 edits in trunk/WebCore
2009-08-04 Jian Li <jianli@chromium.org>
Reviewed by David Levin.
[V8] Fix an assert in WebCoreStringResource that causes worker script
evaluation failed.
https://bugs.webkit.org/show_bug.cgi?id=27996
The fix is to check for the same thread, instead of the main thread.
This is because Chromium's workers use v8 in a single thread that is
not the main thread.
- bindings/v8/V8Binding.cpp: (WebCore::WebCoreStringResource::WebCoreStringResource): (WebCore::WebCoreStringResource::~WebCoreStringResource): (WebCore::WebCoreStringResource::atomicString):
- 3:46 PM Changeset in webkit [46781] by
-
- 1 edit1 add in trunk/WebKitTools
2009-08-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
bugzilla-tool unit tests need a test harness
https://bugs.webkit.org/show_bug.cgi?id=27977
- Scripts/run-webkit-unittests: Added.
- 3:19 PM Changeset in webkit [46780] by
-
- 3 edits in trunk/WebKit/wx
wx build fix after InspectorClient API change.
- 2:43 PM Changeset in webkit [46779] by
-
- 2 edits in trunk/LayoutTests
2009-08-04 Eric Seidel <eric@webkit.org>
Reviewed by Simon Fraser.
LayoutTests are too slow
https://bugs.webkit.org/show_bug.cgi?id=27995
Shave 5 seconds off of run-webkit-tests.
- fast/events/click-count.html: use eventSender.leapForward instead of setTimeout
- 2:35 PM Changeset in webkit [46778] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-04 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Oiver Hunt.
Revert r46643 since this breaks the Yarr::Interpreter running the v8 tests.
https://bugs.webkit.org/show_bug.cgi?id=27874
- yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::allocDisjunctionContext): (JSC::Yarr::Interpreter::freeDisjunctionContext): (JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext): (JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext):
- 1:59 PM BuildingOnWindows edited by
- Move the information about setting the WebKitLibrariesDir out of the … (diff)
- 1:54 PM Changeset in webkit [46777] by
-
- 2 edits in trunk/JavaScriptCore
PPC64 Build fix
- 12:57 PM Changeset in webkit [46776] by
-
- 3 edits2 adds in trunk
2009-08-04 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Add support for transitions/animations of text-indent.
Test: transitions/text-indent-transition.html
- page/animation/AnimationBase.cpp: (WebCore::ensurePropertyMap):
- 12:52 PM Changeset in webkit [46775] by
-
- 2 edits in trunk/WebKitTools
Ensure that DumpRenderTreeSupport is regenerated when switching between OS versions
by listing the DumpRenderTree binary as a dependency. Xcode has the smarts to rebuild
DumpRenderTree itself when switching OS versions so this dependency removes the need
for any smarts in the Makefile.
Rubber-stamped by Gavin "Gavvy" Barraclough.
- DumpRenderTree/mac/PerlSupport/Makefile:
- 12:46 PM Changeset in webkit [46774] by
-
- 2 edits in trunk/LayoutTests
Update test results after addition of AXRequired in r46768.
- platform/mac/accessibility/lists-expected.txt:
- 12:38 PM Changeset in webkit [46773] by
-
- 3 edits2 adds in trunk
2009-08-04 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Add support for transitions of min- and max-width, and min- and max-height.
https://bugs.webkit.org/show_bug.cgi?id=27990
Test: transitions/min-max-width-height-transitions.html
- page/animation/AnimationBase.cpp: (WebCore::ensurePropertyMap):
- 12:17 PM Changeset in webkit [46772] by
-
- 2 edits1 add in trunk/WebKitTools
2009-08-04 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool needs unit tests
https://bugs.webkit.org/show_bug.cgi?id=26916
Add some basic unit testing for scm.py.
- Scripts/modules/scm.py:
- Scripts/modules/scm_unittest.py: Added.
- 12:06 PM Changeset in webkit [46771] by
-
- 2 edits in trunk/WebKitTools
2009-08-04 Mike Fenton <mike.fenton@torchmobile.com>
Reviewed by Adam Treat.
Fix --skipped=only mode to honor flags such as --no-http and platform ignored directories by checking
to make sure the Skipped entries are not in the $ignoredDirectories array. Directories commonly included
are (http, media, compositing, wml, wcss).
- Scripts/run-webkit-tests:
- 11:15 AM Changeset in webkit [46770] by
-
- 8 edits2 adds in trunk
Bug 27964 - WAI-ARIA: radio button does not determine its label from text content
https://bugs.webkit.org/show_bug.cgi?id=27964
- 10:28 AM Changeset in webkit [46769] by
-
- 2 edits in trunk/WebCore
2009-08-04 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Missed a place that expects window.event to be hidden when it shouldn't be.
- 9:15 AM Changeset in webkit [46768] by
-
- 16 edits2 adds in trunk
Bug 27958 - WAI-ARIA: Implement 'aria-required' attribute.
https://bugs.webkit.org/show_bug.cgi?id=27958
- 8:20 AM Changeset in webkit [46767] by
-
- 3 edits in trunk/WebKit/qt
2009-08-04 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Simon Hausmann.
[Qt] QWebFrame::requestedUrl method can mis-behave in case of unhandled sslErrors.
https://bugs.webkit.org/show_bug.cgi?id=27804
- Api/qwebframe.cpp: (QWebFrame::requestedUrl):
- tests/qwebframe/tst_qwebframe.cpp:
- 7:58 AM Changeset in webkit [46766] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-04 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by Adam Treat
Explicitly include limits.h header when using INT_MAX and INT_MIN
- interpreter/Interpreter.cpp
- 7:51 AM Changeset in webkit [46765] by
-
- 2 edits8 adds in trunk/LayoutTests
2009-08-04 Ariya Hidayat <ariya.hidayat@nokia.com>
Rubber-stamped by Simon Hausmann.
[Qt] Add passed test results, with pixel tests.
- platform/qt/Skipped:
- platform/qt/fast/canvas/canvas-composite-expected.checksum: Added.
- platform/qt/fast/canvas/canvas-composite-expected.png: Added.
- platform/qt/fast/canvas/canvas-composite-expected.txt: Added.
- platform/qt/fast/canvas/drawImage-expected.checksum: Added.
- platform/qt/fast/canvas/drawImage-expected.png: Added.
- platform/qt/fast/canvas/drawImage-expected.txt: Added.
- platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.checksum: Added.
- platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.png: Added.
- 7:50 AM Changeset in webkit [46764] by
-
- 5 edits in trunk/WebKit/qt
2009-08-04 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Rename QWebPlugin to QWebPluginInfo, as discussed on IRC.
- Api/qwebplugindatabase.cpp: (QWebPluginInfoPrivate::QWebPluginInfoPrivate): (QWebPluginInfo::QWebPluginInfo): (QWebPluginInfo::~QWebPluginInfo): (QWebPluginInfo::name): (QWebPluginInfo::description): (QWebPluginInfo::mimeTypes): (QWebPluginInfo::supportsMimeType): (QWebPluginInfo::path): (QWebPluginInfo::isNull): (QWebPluginInfo::setEnabled): (QWebPluginInfo::isEnabled): (QWebPluginInfo::operator==): (QWebPluginInfo::operator!=): (QWebPluginInfo::operator=): (QWebPluginDatabase::plugins): (QWebPluginDatabase::pluginForMimeType): (QWebPluginDatabase::setPreferredPluginForMimeType):
- Api/qwebplugindatabase.h:
- Api/qwebplugindatabase_p.h:
- tests/qwebplugindatabase/tst_qwebplugindatabase.cpp: (tst_QWebPluginDatabase::installedPlugins): (tst_QWebPluginDatabase::searchPaths): (tst_QWebPluginDatabase::null_data): (tst_QWebPluginDatabase::null): (tst_QWebPluginDatabase::pluginForMimeType): (tst_QWebPluginDatabase::enabled): (tst_QWebPluginDatabase::operatorequal_data): (tst_QWebPluginDatabase::operatorequal): (tst_QWebPluginDatabase::preferredPlugin):
- 7:50 AM Changeset in webkit [46763] by
-
- 5 edits in trunk/WebKit/qt
2009-08-04 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Adam Treat.
Replace QWebPlugin::MimeType with a typedef to
QWebPluginFactory::MimeType.
- Api/qwebplugindatabase.cpp:
- Api/qwebplugindatabase.h:
- Api/qwebpluginfactory.cpp: (QWebPluginFactory::MimeType::operator==):
- Api/qwebpluginfactory.h:
- 7:50 AM Changeset in webkit [46762] by
-
- 7 edits6 adds in trunk
WebCore:
2009-08-04 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
Add QWebPluginDatabase API to the Qt API.
- WebCore.pro:
WebKit/qt:
2009-08-04 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
Add QWebPluginDatabase API to the Qt API.
- Api/headers.pri:
- Api/qwebplugindatabase.cpp: Added. (QWebPluginPrivate::QWebPluginPrivate): (QWebPluginDatabasePrivate::QWebPluginDatabasePrivate): (QWebPlugin::MimeType::operator==): (QWebPlugin::QWebPlugin): (QWebPlugin::~QWebPlugin): (QWebPlugin::name): (QWebPlugin::description): (QWebPlugin::mimeTypes): (QWebPlugin::supportsMimeType): (QWebPlugin::path): (QWebPlugin::isNull): (QWebPlugin::setEnabled): (QWebPlugin::isEnabled): (QWebPlugin::operator==): (QWebPlugin::operator!=): (QWebPlugin::operator=): (QWebPluginDatabase::QWebPluginDatabase): (QWebPluginDatabase::~QWebPluginDatabase): (QWebPluginDatabase::plugins): (QWebPluginDatabase::defaultSearchPaths): (QWebPluginDatabase::searchPaths): (QWebPluginDatabase::setSearchPaths): (QWebPluginDatabase::addSearchPath): (QWebPluginDatabase::refresh): (QWebPluginDatabase::pluginForMimeType): (QWebPluginDatabase::setPreferredPluginForMimeType):
- Api/qwebplugindatabase.h: Added.
- Api/qwebplugindatabase_p.h: Added.
- Api/qwebsettings.cpp: (QWebSettings::pluginDatabase):
- Api/qwebsettings.h:
- tests/qwebplugindatabase/qwebplugindatabase.pro: Added.
- tests/qwebplugindatabase/tst_qwebplugindatabase.cpp: Added. (tst_QWebPluginDatabase::installedPlugins): (tst_QWebPluginDatabase::searchPaths): (tst_QWebPluginDatabase::null_data): (tst_QWebPluginDatabase::null): (tst_QWebPluginDatabase::pluginForMimeType): (tst_QWebPluginDatabase::enabled): (tst_QWebPluginDatabase::operatorequal_data): (tst_QWebPluginDatabase::operatorequal): (tst_QWebPluginDatabase::preferredPlugin):
- tests/tests.pro:
- 7:34 AM Changeset in webkit [46761] by
-
- 2 edits in trunk/WebCore
2009-08-04 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Adam Treat.
[Qt] PlusDarker is not supported. Fall back to CompositionMode_Darken
(as it is the closest match) instead of CompositionMode_SourceOver.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode):
- 7:24 AM Changeset in webkit [46760] by
-
- 2 edits in trunk/LayoutTests
2009-08-04 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Adam Treat.
[Qt] Fix the metrics.
- platform/qt/fast/canvas/canvas-before-css-expected.txt:
- 6:30 AM Changeset in webkit [46759] by
-
- 3 edits14 adds in trunk/LayoutTests
2009-08-04 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Add pixel tests result.
- platform/qt/Skipped:
- platform/qt/fast/canvas/canvas-as-image-expected.checksum: Added.
- platform/qt/fast/canvas/canvas-as-image-expected.png: Added.
- platform/qt/fast/canvas/canvas-as-image-expected.txt: Added.
- platform/qt/fast/canvas/canvas-as-image-incremental-repaint-expected.checksum: Added.
- platform/qt/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Added.
- platform/qt/fast/canvas/canvas-as-image-incremental-repaint-expected.txt: Added.
- platform/qt/fast/canvas/canvas-before-css-expected.checksum: Added.
- platform/qt/fast/canvas/canvas-before-css-expected.png: Added.
- platform/qt/fast/canvas/canvas-before-css-expected.txt:
- platform/qt/fast/canvas/canvas-bg-expected.checksum: Added.
- platform/qt/fast/canvas/canvas-bg-expected.png: Added.
- platform/qt/fast/canvas/canvas-bg-expected.txt: Added.
- platform/qt/fast/canvas/canvas-bg-zoom-expected.checksum: Added.
- platform/qt/fast/canvas/canvas-bg-zoom-expected.png: Added.
- platform/qt/fast/canvas/canvas-bg-zoom-expected.txt: Added.
- 6:26 AM Changeset in webkit [46758] by
-
- 2 edits in trunk/LayoutTests
2009-08-04 Adam Treat <adam.treat@torchmobile.com>
Fix buildbot. This was supposed to be part of the last commit r46757, but the hunk never made it in.
- platform/qt/fast/block/float/033-expected.txt:
- 5:45 AM EFLWebKit edited by
- (diff)
- 5:22 AM Changeset in webkit [46757] by
-
- 2 edits in trunk/LayoutTests
2009-08-04 Renata Hodovan <hodovan.renata@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
Remove LayoutTests/fast/block/float/033.html from the Qt Skipped list
The expected value was incorrect and it has been modified. The new expected value is similar to the MAC version as well.
- platform/qt/Skipped:
- platform/qt/fast/block/float/033-expected.txt:
- 2:28 AM Changeset in webkit [46756] by
-
- 2 edits in trunk/WebCore
2009-08-04 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>
Reviewed by Adam Barth.
[v8] Fix crash when converting empty v8 string to atomic webkit string.
https://bugs.webkit.org/show_bug.cgi?id=27975
collection-null-like-arguments.html tests for this.
- bindings/v8/V8Binding.cpp: (WebCore::v8StringToAtomicWebCoreString):
- 2:26 AM Changeset in webkit [46755] by
-
- 3 edits in trunk/WebKitTools
2009-08-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
bugzilla-tool --commit-queue should validate commit-queue setter is a committer
https://bugs.webkit.org/show_bug.cgi?id=27974
With a test!
- Scripts/modules/bugzilla.py:
- Scripts/modules/bugzilla_unittest.py:
- 1:59 AM Changeset in webkit [46754] by
-
- 2 edits in trunk/WebKitTools
2009-08-04 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
REGRESSION(r46700): bugzilla-tool land-diff double-spaces ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=27973
The trailing comma (suppresses newlines) was lost in r46700.
- Scripts/bugzilla-tool:
- 1:54 AM Changeset in webkit [46753] by
-
- 4 edits in trunk/WebKitTools
2009-08-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
bugzilla-tool has too many fatal errors
https://bugs.webkit.org/show_bug.cgi?id=27969
Replace several fatal errors with ScriptError exceptions.
- Scripts/bugzilla-tool:
- Scripts/modules/bugzilla.py:
- Scripts/modules/scm.py:
- 1:34 AM Changeset in webkit [46752] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
2009-08-04 Eric Seidel <eric@webkit.org>
No review, ChangeLog fix only.
Fix a ChangeLog line-spacing disaster caused by:
https://bugs.webkit.org/show_bug.cgi?id=27973
Still unsure what the fix for bugzilla-tool will be.
- 1:18 AM Changeset in webkit [46751] by
-
- 3 edits in trunk/WebKitTools
2009-08-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
bugzilla-tool --commit-queue should only land commit-queue+ patches
https://bugs.webkit.org/show_bug.cgi?id=27970
commit-queue mode for bugzilla-tool
https://bugs.webkit.org/show_bug.cgi?id=27918
Make bugzilla tool smart enough to find the commit-queue+ flags and
land those patches.
When we call land-patches with --commit-queue, we should filter the
patches we land to only those that have the commit-queue+ flag set.
That way, when we call bugzilla-tool from a main commit queue process,
we won't land the wrong patches.
- Scripts/bugzilla-tool:
- Scripts/modules/bugzilla.py:
- 1:14 AM Changeset in webkit [46750] by
-
- 2 edits3 adds in trunk/WebKitTools
2009-08-04 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
committer logic should be split out of bugzilla.py into its own module
I also added unit tests for the functionality I added.
- Scripts/modules/bugzilla.py:
- Scripts/modules/bugzilla_unittest.py: Added.
- Scripts/modules/commiters_unittest.py: Added.
- Scripts/modules/committers.py: Added.
- 12:13 AM Changeset in webkit [46749] by
-
- 4 edits in trunk/WebCore
2009-08-04 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
selectionHasStyle needs clean up to fix Bug 27858
https://bugs.webkit.org/show_bug.cgi?id=27865
This patch cleans up selectionStartHasStyle and selectionHasStyle.
No test is added because the patch does not change any behavior.
- editing/ApplyStyleCommand.cpp: (WebCore::getPropertiesNotInComputedStyle): Used in triStateOfStyleInComputedStyle but will be used here as well
- editing/ApplyStyleCommand.h: Added the prototype of getPropertiesNotInComputedStyle
- editing/Editor.cpp: (WebCore::triStateOfStyleInComputedStyle): Determines if the specified style is present in the specified computed style. (WebCore::Editor::selectionStartHasStyle): Uses triStateOfStyleInComputedStyle (WebCore::Editor::selectionHasStyle): Uses triStateOfStyleInComputedStyle instead of updateState
- 12:06 AM Changeset in webkit [46748] by
-
- 4 edits in trunk/WebCore
2009-08-03 John Abd-El-Malek <jam@chromium.org>
Reviewed by David Levin.
Fix MessagePort construction in worker process. Also make the other object constructions match this.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertToV8Object):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException):
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::ToV8Object):
Aug 3, 2009:
- 11:34 PM Changeset in webkit [46747] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Fixup ChangeLog
- 11:14 PM Changeset in webkit [46746] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-03 Harald Fernengel <harald.fernengel@nokia.com>
Reviewed by NOBODY
Fix ambiguity in abs(long int) call by calling labs() instead
- wtf/DateMath.cpp: replace call to abs() with labs()
- 10:39 PM Changeset in webkit [46745] by
-
- 5 edits in trunk/WebCore
2009-08-03 Christian Plesner Hansen <christian.plesner.hansen@gmail.com>
Reviewed by David Levin.
[V8] Cache atomic strings in externalized v8 strings
https://bugs.webkit.org/show_bug.cgi?id=27762
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8Binding.cpp: (WebCore::WebCoreStringResource::WebCoreStringResource): (WebCore::WebCoreStringResource::~WebCoreStringResource): (WebCore::WebCoreStringResource::data): (WebCore::WebCoreStringResource::length): (WebCore::WebCoreStringResource::webcoreString): (WebCore::WebCoreStringResource::atomicString): (WebCore::WebCoreStringResource::toStringResource): (WebCore::v8StringToWebCoreString): (WebCore::v8StringToAtomicWebCoreString): (WebCore::v8ValueToWebCoreString): (WebCore::v8ValueToAtomicWebCoreString):
- bindings/v8/V8Binding.h: (WebCore::):
- dom/Document.idl:
- 7:24 PM UsingGitWithWebKit edited by
- Added Section on Ignores (diff)
- 7:21 PM Changeset in webkit [46744] by
-
- 3 edits in trunk/WebCore
2009-08-03 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Timothy Hatcher.
Inspector: DOM Storage Live Updating Should Not Affect Tabbing
https://bugs.webkit.org/show_bug.cgi?id=27957
- inspector/front-end/DOMStorageDataGrid.js: (WebInspector.DOMStorageDataGrid.prototype._startEditingColumnOfDataGridNode): disable storage event listener (WebInspector.DOMStorageDataGrid.prototype._startEditing): disable storage event listener (WebInspector.DOMStorageDataGrid.prototype._editingCancelled): enable storage event listener
- inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype._unregisterStorageEventListener): quick return if no listener
- 7:14 PM Changeset in webkit [46743] by
-
- 6 edits in trunk
2009-08-03 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
[Qt] Consolidate common gcc flags to WebKit.pri
https://bugs.webkit.org/show_bug.cgi?id=27934
- JavaScriptCore.pro:
2009-08-03 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
[Qt] Consolidate common gcc flags to WebKit.pri
https://bugs.webkit.org/show_bug.cgi?id=27934
- WebCore.pro:
2009-08-03 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
[Qt] Consolidate common gcc flags to WebKit.pri
https://bugs.webkit.org/show_bug.cgi?id=27934
- WebKit.pri:
- 6:29 PM Changeset in webkit [46742] by
-
- 3 edits in trunk/WebKitTools
2009-08-03 Peter Kasting <pkasting@google.com>
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=27323
Handle any kind of line endings in svn-apply and svn-unapply, instead
of assuming LF.
- Scripts/svn-apply:
- Scripts/svn-unapply:
- 6:08 PM Changeset in webkit [46741] by
-
- 7 edits in trunk/WebCore
2009-08-03 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Chromium code sometimes isn't sandboxed and needs to access the FS.
https://bugs.webkit.org/show_bug.cgi?id=27954
These changes are the WebKit side of http://codereview.chromium.org/159778 which
aims to make LocalStorage persistent.
This change runs all FileSystem routines through the ChromiumBridge so that
WebKitClients can handle them if they choose to. For now, the only such client
will be the one running in the browser process.
It also adds a method called sandboxEnabled to the Chromium bridge so that the
SQLite file system code can shift its behavior depending on whether we're
inside a sandbox or not.
- platform/chromium/ChromiumBridge.h:
- platform/chromium/FileSystemChromium.cpp: (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileModificationTime): (WebCore::directoryName): (WebCore::pathByAppendingComponent): (WebCore::makeAllDirectories): (WebCore::fileExists):
- platform/sql/chromium/SQLiteFileSystemChromium.cpp: (WebCore::SQLiteFileSystem::openDatabase):
- platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: (WebCore::SQLiteFileSystem::registerSQLiteVFS):
- 5:43 PM Changeset in webkit [46740] by
-
- 5 edits in trunk/WebCore
2009-08-03 Alpha Lam <hclam@chromium.org>
Reviewed by David Levin.
[chromium] Implement media slider for chromium
https://bugs.webkit.org/show_bug.cgi?id=27859
Implemented the media slider for chromium port. The implementation
is using Skia for drawing the thumb and buffered region instead of
using any native system controls so different platforms would have
the same look and feel.
No new tests because this is covered by existing tests.
- css/mediaControlsChromium.css:
- rendering/RenderThemeChromiumSkia.cpp:
- rendering/RenderThemeChromiumSkia.h:
- rendering/RenderThemeChromiumWin.cpp:
- 5:28 PM Changeset in webkit [46739] by
-
- 3 edits in trunk/WebKitTools
2009-08-03 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
bugzilla-tool land-patches needs --queue mode
https://bugs.webkit.org/show_bug.cgi?id=27961
Add a --commit-queue command line option to suppress user interaction.
- Scripts/bugzilla-tool:
- Scripts/modules/scm.py:
- 4:48 PM Changeset in webkit [46738] by
-
- 12 edits in trunk/WebCore
2009-07-27 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26460
Plumbing and cleanup in advance of returning multiple frames from the
ICOImageDecoder:
- Make ImageDecoder::frameCount() return a size_t like ImageSource::frameCount() and BitmapImage::frameCount() already do.
- Add ImageDecoder::frameSizeAtIndex() alongside size(), to report the size of a particular frame. Hook all the ImageSource::frameSizeAtIndex() implementations to this. No ImageDecoder implements this yet; that will come in my next change.
- platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
- platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::frameCount): returns size_t.
- platform/graphics/qt/ImageDecoderQt.h: frameCount() returns size_t.
- platform/graphics/qt/ImageSourceQt.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
- platform/graphics/skia/ImageSourceSkia.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
- platform/graphics/win/ImageCGWin.cpp: (WebCore::BitmapImage::drawFrameMatchingSourceSize): frameCount() returns size_t.
- platform/graphics/win/ImageCairoWin.cpp: (WebCore::BitmapImage::drawFrameMatchingSourceSize): frameCount() returns size_t.
- platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::frameSizeAtIndex): Hook to ImageDecoder function.
- platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::size): Clarify comment. (WebCore::ImageDecoder::frameSizeAtIndex): Add. (WebCore::ImageDecoder::frameCount): returns size_t. (WebCore::ImageDecoder::frameBufferAtIndex): Remove unneeded param name.
- platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::frameCount): returns size_t. (WebCore::GIFImageDecoder::frameBufferAtIndex): frameCount() returns size_t.
- platform/image-decoders/gif/GIFImageDecoder.h: frameCount() returns size_t.
- 4:42 PM Changeset in webkit [46737] by
-
- 2 edits in trunk/WebKitTools
Build fix. Add installsrc, installhdrs and install targets.
- DumpRenderTree/mac/PerlSupport/Makefile:
- 3:59 PM Changeset in webkit [46736] by
-
- 2 edits in trunk/WebCore
2009-08-03 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Darin Adler.
Fix a bug that could cause an ASSERT to fail incorrectly, leading
to a renderer crash in Chromium.
All tests in storage/ pass.
- platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::~SQLiteTransaction): (WebCore::SQLiteTransaction::begin):
- 3:05 PM Changeset in webkit [46735] by
-
- 4 edits in trunk/WebKitSite
Update two WordPress plug-ins that we use.
- blog/wp-content/plugins/akismet/akismet.php:
- blog/wp-content/plugins/akismet/readme.txt:
- blog/wp-content/plugins/commentcontrol.php:
- 3:02 PM Changeset in webkit [46734] by
-
- 1 edit2 copies15 moves114 adds129 deletes in trunk/WebKitSite
Add some missing files and delete some obsolete files.
- blog:
- 2:55 PM Changeset in webkit [46733] by
-
- 2 edits in trunk/WebCore
2009-08-03 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
Based on work by Yael Aharon.
Implement keyboard event forwarding for windowless plugins
for the Qt port.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::dispatchNPEvent): (WebCore::setSharedXEventFields): (WebCore::setXKeyEventSpecificFields): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent):
- xml/NativeXPathNSResolver.cpp:
- 2:28 PM Changeset in webkit [46732] by
-
- 8 edits1 move2 adds in trunk/WebCore
Make the bottom "drawer" of the Web Inspector more extensible to support other views.
2009-08-03 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Timothy Hatcher.
Inspector: Make Bottom "Drawer" More Extensible To Support Other Views
https://bugs.webkit.org/show_bug.cgi?id=27928
- English.lproj/localizedStrings.js:
"Show changes view", "Hide changes view", "Clear changes log", "%d style change", "%d style changes"
- inspector/front-end/ChangesView.js: Added. (WebInspector.ChangesView): (WebInspector.ChangesView.prototype._clearButtonClicked): (WebInspector.ChangesView.prototype._toggleChangesButtonClicked): (WebInspector.ChangesView.prototype.attach): (WebInspector.ChangesView.prototype.show): (WebInspector.ChangesView.prototype.hide):
To be a new view to show Changes made via the inspector. DOM, CSS, or otherwise.
- inspector/front-end/Console.js: Removed.
Sliding View aspect moved to Drawer.js. The "console" itself has moved to ConsoleView.js
- inspector/front-end/ConsoleView.js: Added.
Little has changed from its move from Console.js other then support for working with the Drawer.
- inspector/front-end/Drawer.js: Added. (WebInspector.Drawer): (WebInspector.Drawer.prototype.get visibleView): (WebInspector.Drawer.prototype.set visibleView): (WebInspector.Drawer.prototype.show.animationFinished): (WebInspector.Drawer.prototype.show): (WebInspector.Drawer.prototype.hide.animationFinished): (WebInspector.Drawer.prototype.hide): (WebInspector.Drawer.prototype._safelyRemoveChildren): (WebInspector.Drawer.prototype._startStatusBarDragging): (WebInspector.Drawer.prototype._statusBarDragging): (WebInspector.Drawer.prototype._endStatusBarDragging):
Allow for multiple views inside the Sliding Drawer.
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.renameSelector): (WebInspector.ElementsPanel.prototype.addStyleChange): (WebInspector.ElementsPanel.prototype.removeStyleChange): (WebInspector.ElementsPanel.prototype.generateStylesheet):
Starting work on the "Changes" Panel. The ability to generate a Stylesheet from Styles added via the Inspector.
- inspector/front-end/Images/styleIcon.png: Added.
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.isInspectorStylesheet): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.BlankStylePropertiesSection.prototype.makeNormal): (WebInspector.StylePropertyTreeElement.prototype):
Interface with ElementsPanel for generating a Stylesheet of Changes.
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css: Refactored to allow for multiple views in the drawer.
- inspector/front-end/inspector.html: Refactored to allow for multiple views in the drawer.
- inspector/front-end/inspector.js: (WebInspector.get styleChanges): (WebInspector.set styleChanges): (WebInspector._updateChangesCount): (WebInspector.loaded): (WebInspector.documentKeyDown): (WebInspector.showConsole): (WebInspector.showChanges):
Support for the drawer and "styles changed icon" similar to the "errors and warnings" icons.
- 2:24 PM Changeset in webkit [46731] by
-
- 338 edits18 copies1 move133 adds14 deletes in trunk/WebKitSite
Update WordPress to the latest version.
- blog:
- 2:00 PM Changeset in webkit [46730] by
-
- 2 edits in trunk/WebCore
2009-08-03 Dean McNamee <deanm@chromium.org>
Reviewed by Adam Barth.
Correct an assert on a PassRefPtr in the v8 svg bindings.
https://bugs.webkit.org/show_bug.cgi?id=27951
- bindings/v8/V8SVGPODTypeWrapper.h: (WebCore::V8SVGDynamicPODTypeWrapper::V8SVGDynamicPODTypeWrapper):
- 1:23 PM Changeset in webkit [46729] by
-
- 2 edits in trunk/LayoutTests
2009-08-03 Jan Michael Alonzo <jmalonzo@webkit.org>
[Gtk] Skip accessibility/input-slider.html as it needs
Accessibility support in DRT which the Gtk do not have an
implementation at the moment.
- platform/gtk/Skipped:
- 1:00 PM Changeset in webkit [46728] by
-
- 3 edits3 adds in trunk
WebCore:
2009-08-03 Dirk Pranke <dpranke@chromium.org>
Reviewed by Sam Weinig.
Fix for https://bugs.webkit.org/show_bug.cgi?id=27748
crash w/ stack overflow when same CSS file loaded repeatedly
Fix crash caused by a stack overflow when repeatedly loading very large
CSS files. CSSRuleData in CSSStyleSelector.h destroyed itself
recursively rather than iteratively.
Test: fast/css/large-list-of-rules-crash.html
- css/CSSStyleSelector.h: (WebCore::CSSRuleData::~CSSRuleData): (WebCore::CSSRuleDataList::~CSSRuleDataList):
LayoutTests:
2009-08-03 Dirk Pranke <dpranke@chromium.org>
Reviewed by Sam Weinig.
Test for https://bugs.webkit.org/show_bug.cgi?id=27748
crash w/ stack overflow when same CSS file loaded repeatedly
Fix crash caused by a stack overflow when repeatedly loading very large
CSS files. CSSRuleData in CSSStyleSelector.h destroyed itself
recursively rather than iteratively.
- fast/css/large-list-of-rules-crash-expected.txt: Added.
- fast/css/large-list-of-rules-crash.html: Added.
- fast/css/resources/large-list-of-rules-crash.css: Added.
- 12:40 PM Changeset in webkit [46727] by
-
- 20 edits in trunk
2009-08-03 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Make the DRT APIs to pause transitions and animations work for accelerated animations
<https://bugs.webkit.org/show_bug.cgi?id=27627>
<rdar://problem/6442932>
Fix the 'pauseAnimationAtTimeOnElementWithId' and 'pauseTransitionAtTimeOnElementWithId' APIs
available to LayoutTests to work with accelerated animations and transitions. Done by sending
the pause time down to the GraphicsLayer, and using it to stop time on the layer.
I also added an assertion to check that the animation has actually started when we
try to pause it, to check that the pause time we compute is valid. This revealed a number
of tests that tried to pause before animations started, required some amount of test fixing.
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::freezeAtTime):
- page/animation/AnimationBase.h:
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::pauseAnimationAtTime): (WebCore::CompositeAnimation::pauseTransitionAtTime):
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::suspendAnimations):
- platform/graphics/GraphicsLayer.h:
- platform/graphics/mac/GraphicsLayerCA.h:
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::suspendAnimations):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::suspendAnimations):
- rendering/RenderLayerBacking.h:
- 11:47 AM Changeset in webkit [46726] by
-
- 2 edits in trunk/WebCore
2009-08-03 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
Fix Chromium build by removing PluginView.h from Page.cpp.
Chromium doesn't use PluginView and the pointer is never
dereferenced so the header doesn't need to be included.
https://bugs.webkit.org/show_bug.cgi?id=27946
No new tests because this is a build fix.
- page/Page.cpp:
- 11:46 AM Changeset in webkit [46725] by
-
- 2 edits in trunk/JavaScriptCore
Fixed the Tiger build.
- wtf/FastMalloc.cpp:
- 11:34 AM Changeset in webkit [46724] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin Adler.
Don't use background thread to scavenge memory on Tiger until we figure out why it causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=27900
- wtf/FastMalloc.cpp:
- 11:00 AM Changeset in webkit [46723] by
-
- 2 edits in trunk/WebCore
2009-08-03 Eric Carlson <eric.carlson@apple.com>
One more build fix after https://bugs.webkit.org/show_bug.cgi?id=46720.
Unreviewed.
- WebCoreSources.bkl:
- 10:34 AM Changeset in webkit [46722] by
-
- 5 edits in trunk/WebCore
2009-08-03 Eric Carlson <eric.carlson@apple.com>
Build fix after https://bugs.webkit.org/show_bug.cgi?id=46720.
Unreviewed.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- 10:13 AM Changeset in webkit [46721] by
-
- 6 edits2 adds in trunk
Bug 27943 - Need to implement ARIA role="radiogroup"
https://bugs.webkit.org/show_bug.cgi?id=27943
- 10:07 AM Changeset in webkit [46720] by
-
- 14 edits4 adds in trunk
2009-08-03 Eric Carlson <eric.carlson@apple.com>
Reviewed by Eric Seidel.
HTMLInputElement is not controllable by assistive technologies
https://bugs.webkit.org/show_bug.cgi?id=27941
Test: accessibility/input-slider.html
- WebCore.xcodeproj/project.pbxproj:
Add AccessibilitySlider.cpp/.h
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::getOrCreate):
Create AccessibilitySlider and AccessibilitySliderThumb.
- accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::increment): (WebCore::AccessibilityObject::decrement):
Add default, do nothing, base class methods.
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
Correct typo.
- accessibility/AccessibilitySlider.cpp: Added. (WebCore::AccessibilitySlider::AccessibilitySlider): (WebCore::AccessibilitySlider::create): (WebCore::AccessibilitySlider::children): (WebCore::AccessibilitySlider::addChildren): (WebCore::AccessibilitySlider::getAttribute): (WebCore::AccessibilitySlider::valueForRange): (WebCore::AccessibilitySlider::maxValueForRange): (WebCore::AccessibilitySlider::minValueForRange): (WebCore::AccessibilitySlider::changeValue): (WebCore::AccessibilitySlider::setValue): (WebCore::AccessibilitySlider::increment): (WebCore::AccessibilitySlider::decrement): (WebCore::AccessibilitySlider::element): (WebCore::AccessibilitySliderThumb::AccessibilitySliderThumb): (WebCore::AccessibilitySliderThumb::create): (WebCore::AccessibilitySliderThumb::elementRect): (WebCore::AccessibilitySliderThumb::size):
- accessibility/AccessibilitySlider.h: Added. (WebCore::AccessibilitySlider::~AccessibilitySlider): (WebCore::AccessibilitySlider::roleValue): (WebCore::AccessibilitySlider::accessibilityIsIgnored): (WebCore::AccessibilitySlider::isSlider): (WebCore::AccessibilitySlider::canSetValueAttribute): (WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb): (WebCore::AccessibilitySliderThumb::roleValue): (WebCore::AccessibilitySliderThumb::accessibilityIsIgnored): (WebCore::AccessibilitySliderThumb::setParentObject): (WebCore::AccessibilitySliderThumb::parentObject):
- accessibility/mac/AccessibilityObjectWrapper.mm: (RoleEntry::):
SliderThumbRole -> NSAccessibilityValueIndicatorRole
(-[AccessibilityObjectWrapper roleDescription]):
Return role description for NSAccessibilitySliderRole and NSAccessibilityValueIndicatorRole.
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
Minor coding style correction.
(-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
If attachement view handles press action, don't also call object wrapper.
(-[AccessibilityObjectWrapper accessibilityPerformIncrementAction]):
New, call object's increment() method.
(-[AccessibilityObjectWrapper accessibilityPerformDecrementAction]):
New, call object's decrement() method.
(-[AccessibilityObjectWrapper accessibilityPerformAction:]):
Respond to NSAccessibilityIncrementAction and NSAccessibilityDecrementAction.
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::thumbRect):
Factor logic out of layout so AccessibilitySliderThumb can get thumb location/size.
(WebCore::RenderSlider::layout):
Move code to thumbRect().
- rendering/RenderSlider.h:
2009-08-03 Eric Carlson <eric.carlson@apple.com>
Reviewed by Eric Seidel.
HTMLInputElement is not controllable by assistive technologies
https://bugs.webkit.org/show_bug.cgi?id=27941
Accessibility control of a slider required adding increment() and decrement()
methods to AccessibilityObject, so expose thos methods on AccessibilityUIElement.
- DumpRenderTree/AccessibilityUIElement.cpp: (incrementCallback): New, call UI element increment method. (decrementCallback): New, call UI element decrement method. (AccessibilityUIElement::getJSClass): Expose increment and decrement methods.
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::increment): New, send NSAccessibilityIncrementAction to Mac wrapper. (AccessibilityUIElement::decrement): New, send NSAccessibilityDecrementAction to Mac wrapper.
- DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::increment): New, do nothing. (AccessibilityUIElement::decrement): New, do nothing.
2009-08-03 Eric Carlson <eric.carlson@apple.com>
Reviewed by Eric Seidel.
HTMLInputElement is not controllable by assistive technologies
https://bugs.webkit.org/show_bug.cgi?id=27941
Add test for <input type=range> accessibility .
- accessibility/input-slider.html: Added.
- platform/mac/accessibility/input-slider-expected.txt: Added.
- 10:00 AM Changeset in webkit [46719] by
-
- 3 edits in trunk/WebCore
2009-08-03 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
Build fix if Netscape plugin support is turned off
https://bugs.webkit.org/show_bug.cgi?id=27940
- plugins/PluginView.cpp: (WebCore::PluginView::stop): Do not call NPN_MemFree if NPAPI is disabled
- plugins/PluginViewNone.cpp: (WebCore::PluginView::platformStart): Empty stub.
- 9:12 AM Changeset in webkit [46718] by
-
- 2 edits in trunk/WebCore
2009-07-31 Joe Mason <joe.mason@torchmobile.com>
Reviewed by George Staikos.
WINCE port: LOAD_WITH_ALTERED_SEARCH_PATH param of
LoadLibraryEx not supported on WINCE
https://bugs.webkit.org/show_bug.cgi?id=27917
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):use LoadLibrary instead of LoadLibraryEx
- 7:50 AM Changeset in webkit [46717] by
-
- 2 edits in trunk/WebKit/qt
2009-08-03 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
Do memory cleanup when running robotized QtLauncher in debug as well.
- QtLauncher/main.cpp: (launcherMain): (main):
- 5:03 AM Changeset in webkit [46716] by
-
- 2 edits in trunk/JavaScriptCore
2009-08-03 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Jan Alonzo.
Fix build break on Gtk/x86_64.
https://bugs.webkit.org/show_bug.cgi?id=27936
Use JSVALUE64 for X86_64 LINUX, except Qt.
- wtf/Platform.h:
- 3:27 AM Changeset in webkit [46715] by
-
- 1 edit in trunk/ChangeLog
Fix ChangeLog - r46714 was rubber-stamped by Eric
- 3:23 AM Changeset in webkit [46714] by
-
- 2 edits in trunk
2009-08-03 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Eric Seidel.
[Gtk] macros in webkit.m4 should be defined once only
https://bugs.webkit.org/show_bug.cgi?id=27929
The macros in webkit.m4 are not meant to be called multiple times
so we'll make them AC_DEFUN_ONCE. Also make AC_HEADER_STDC and AC_PROG_CXX
AC_REQUIRE to remove the automake warnings when doing autogen.sh.
- autotools/webkit.m4:
- 2:14 AM Changeset in webkit [46713] by
-
- 1 edit in trunk/WebCore/ChangeLog
Remove extra linebreaks in WebCore/ChangeLog introduced in r46711
