Timeline
Sep 10, 2009:
- 10:48 PM Changeset in webkit [48284] by
-
- 6 edits44 adds in trunk
2009-09-10 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Detect mixed content
https://bugs.webkit.org/show_bug.cgi?id=29003
Add some tests for mixed content. All but one of these tests pass
currently. The one that fails is pretty tricky, but I wanted to get it
into the tree with a FIXME so we won't forget it. I'll file a followup
bug about fixing it.
- http/tests/security/mixedContent/about-blank-iframe-in-main-frame-expected.txt: Added.
- http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html: Added.
- http/tests/security/mixedContent/data-url-iframe-in-main-frame-expected.txt: Added.
- http/tests/security/mixedContent/data-url-iframe-in-main-frame.html: Added.
- http/tests/security/mixedContent/data-url-script-in-iframe-expected.txt: Added.
- http/tests/security/mixedContent/data-url-script-in-iframe.html: Added.
- http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt: Added.
- http/tests/security/mixedContent/insecure-css-in-iframe.html: Added.
- http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt: Added.
- http/tests/security/mixedContent/insecure-css-in-main-frame.html: Added.
- http/tests/security/mixedContent/insecure-iframe-in-iframe-expected.txt: Added.
- http/tests/security/mixedContent/insecure-iframe-in-iframe.html: Added.
- http/tests/security/mixedContent/insecure-iframe-in-main-frame-expected.txt: Added.
- http/tests/security/mixedContent/insecure-iframe-in-main-frame.html: Added.
- http/tests/security/mixedContent/insecure-image-in-iframe-expected.txt: Added.
- http/tests/security/mixedContent/insecure-image-in-iframe.html: Added.
- http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt: Added.
- http/tests/security/mixedContent/insecure-image-in-main-frame.html: Added.
- http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt: Added.
- http/tests/security/mixedContent/insecure-script-in-iframe.html: Added.
- http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame-expected.txt: Added.
- http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html: Added.
- http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt: Added.
- http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html: Added.
- http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt: Added.
- http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html: Added.
- http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe-expected.txt: Added.
- http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html: Added.
- http/tests/security/mixedContent/resources/boring.html: Added.
- http/tests/security/mixedContent/resources/frame-with-about-blank-frame.html: Added.
- http/tests/security/mixedContent/resources/frame-with-data-url-frame.html: Added.
- http/tests/security/mixedContent/resources/frame-with-data-url-script.html: Added.
- http/tests/security/mixedContent/resources/frame-with-insecure-css.html: Added.
- http/tests/security/mixedContent/resources/frame-with-insecure-frame.html: Added.
- http/tests/security/mixedContent/resources/frame-with-insecure-image.html: Added.
- http/tests/security/mixedContent/resources/frame-with-insecure-script.html: Added.
- http/tests/security/mixedContent/resources/frame-with-redirect-http-to-https-frame.html: Added.
- http/tests/security/mixedContent/resources/frame-with-redirect-http-to-https-script.html: Added.
- http/tests/security/mixedContent/resources/frame-with-redirect-https-to-http-frame.html: Added.
- http/tests/security/mixedContent/resources/frame-with-redirect-https-to-http-script.html: Added.
- http/tests/security/mixedContent/resources/script.js: Added.
- http/tests/security/mixedContent/resources/style.css: Added.
2009-09-10 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Detect mixed content
https://bugs.webkit.org/show_bug.cgi?id=29003
Detect some basic kinds of mixed content (HTTP content loaded into an
HTTPS context). This new detection logic isn't perfect, but it's a
place to start.
Tests: http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html
http/tests/security/mixedContent/data-url-iframe-in-main-frame.html
http/tests/security/mixedContent/data-url-script-in-iframe.html
http/tests/security/mixedContent/insecure-css-in-iframe.html
http/tests/security/mixedContent/insecure-css-in-main-frame.html
http/tests/security/mixedContent/insecure-iframe-in-iframe.html
http/tests/security/mixedContent/insecure-iframe-in-main-frame.html
http/tests/security/mixedContent/insecure-image-in-iframe.html
http/tests/security/mixedContent/insecure-image-in-main-frame.html
http/tests/security/mixedContent/insecure-script-in-iframe.html
http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html
http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html
http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html
- loader/DocLoader.cpp: (WebCore::DocLoader::canRequest): (WebCore::DocLoader::requestResource): (WebCore::DocLoader::checkCacheObjectStatus):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::isMixedContent): (WebCore::FrameLoader::checkIfDisplayInsecureContent): (WebCore::FrameLoader::checkIfRunInsecureContent):
- loader/FrameLoader.h:
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest):
- 9:03 PM Changeset in webkit [48283] by
-
- 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj
Revert http://trac.webkit.org/changeset/48277, as it wasn't the right way to fix the build.
- 8:34 PM Changeset in webkit [48282] by
-
- 2 edits in trunk/WebCore
Fix the Windows build.
Restore platform/mock to the header search path after it was removed in r48270.
- WebCore.vcproj/WebCoreCommon.vsprops:
- 8:17 PM Changeset in webkit [48281] by
-
- 3 edits in trunk/WebCore
Web Inspector: Move the option to create a new style rule under the Styles' gear menu.
https://bugs.webkit.org/show_bug.cgi?id=29039
Reviewed by Sam Weinig.
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane): Add "New Style Rule" option to the gear menu.
(WebInspector.StylesSidebarPane.prototype._update): Check instanceof BlankStylePropertiesSection instead.
(WebInspector.StylesSidebarPane.prototype._changeSetting): Added. Keeps the color format setting selected
while calling the correct action.
(WebInspector.StylesSidebarPane.prototype._createNewRule): Creates a new section and edits the selector.
(WebInspector.StylesSidebarPane.prototype.addBlankSection): Insert the section in a cleaner way.
(WebInspector.StylesSidebarPane.prototype.removeSection): Added. Removes the passed in section.
(WebInspector.StylesSidebarPane.prototype.appropriateSelectorForNode): Return an empty string if there is no node.
(WebInspector.StylePropertiesSection.prototype.expand): Removed the check for _blank.
(WebInspector.StylePropertiesSection.prototype.startEditingSelector): No need for the context, the original selector
is remembered by the editing code.
(WebInspector.StylePropertiesSection.prototype.editingSelectorCancelled): Do nothing. The original text is already
restored by the editing code.
(WebInspector.BlankStylePropertiesSection): Call the StylePropertiesSection constructor with appropriate data.
Remove event listener code.
(WebInspector.BlankStylePropertiesSection.prototype.expand): Added. Does nothing to prevent expanding.
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.callback): Correctly construct the
WebInspector.CSSStyleDeclaration. Call editingSelectorCancelled instead of editingCancelled.
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted): Renamed from editingCommitted to
override the base class.
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCancelled): Remove the section.
(WebInspector.BlankStylePropertiesSection.prototype.makeNormal): Removed event listener code. Removed the delete lines
since they were doing nothing (deleting nonexistent properties that exist only on the prototype.) Change prototypes at
the end to correctly swtich to a real StylePropertiesSection.
- inspector/front-end/inspector.js:
(WebInspector.startEditing.editingCancelled): Ceck for null/undefined callbacks.
(WebInspector.startEditing.editingCommitted): Ditto.
- 8:10 PM Changeset in webkit [48280] by
-
- 12 edits in trunk
2009-09-10 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
[Qt] Fix comparison between signed and unsigned integer warnings
https://bugs.webkit.org/show_bug.cgi?id=29162
No functional change.
- Api/qwebelement.cpp: (QWebElement::findAll):
- Api/qwebhistory.cpp: (QWebHistory::items): (QWebHistory::backItems): (QWebHistory::forwardItems): (QWebHistory::saveState):
- Api/qwebplugindatabase.cpp: (QWebPluginDatabase::setSearchPaths):
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runOpenPanel):
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
2009-09-10 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
[Qt] Fix comparison between signed and unsigned integer warnings
https://bugs.webkit.org/show_bug.cgi?id=29162
No functional change.
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::findMethodIndex):
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): (WebCore::initializeSupportedImageMIMETypesForEncoding):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawFocusRing):
- platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::duration): (WebCore::ImageDecoderQt::imageAtIndex):
- plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::fetchInfo):
- 7:45 PM Changeset in webkit [48279] by
-
- 2 edits in trunk/WebCore
2009-09-10 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha.
Build fix for GTK+ after r48267.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::buffered):
- 7:14 PM Changeset in webkit [48278] by
-
- 2 edits in trunk/WebKitTools
<http://webkit.org/b/29147> run-webkit-tests: make -h show help
Reviewed by Mark Rowe.
- Scripts/run-webkit-tests: Updated to make -h switch show help.
- 7:13 PM Changeset in webkit [48277] by
-
- 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj
Attemped Windows build fix by adding platform/mock headers to be copied.
- 6:22 PM MathML edited by
- (diff)
- 6:16 PM WikiStart edited by
- (diff)
- 4:59 PM Changeset in webkit [48276] by
-
- 1 edit in trunk/WebCore/rendering/RenderPartObject.cpp
Sorry, one more unused paramater breaking Mac build. Will test on my Mac first next time.
- 4:57 PM Changeset in webkit [48275] by
-
- 1 edit in trunk/WebCore/rendering/RenderPartObject.cpp
Fix build break on Mac
- 4:38 PM Changeset in webkit [48274] by
-
- 4 edits in trunk
2009-09-08 John Abd-El-Malek <jam@chromium.org>
Reviewed by Dimitri Glazkov.
Remove unneeded define for ActiveX.
https://bugs.webkit.org/show_bug.cgi?id=29054
- wtf/Platform.h:
WebCore:
2009-09-08 John Abd-El-Malek <jam@chromium.org>
Reviewed by Dimitri Glazkov.
Remove unneeded define for ActiveX.
https://bugs.webkit.org/show_bug.cgi?id=29054
- rendering/RenderPartObject.cpp: (WebCore::createClassIdToTypeMap): (WebCore::serviceTypeForClassId): (WebCore::RenderPartObject::updateWidget):
- 4:16 PM Changeset in webkit [48273] by
-
- 4 edits in trunk
Update JavaScriptCore and WebKit's FeatureDefines.xcconfig so that they are in sync with WebCore as they need to be.
Rubber-stamped by Sam Weinig.
- 4:06 PM Changeset in webkit [48272] by
-
- 2 edits in trunk/WebCore
Don't copy IDL files in to the built framework.
Rubber-stamped by Sam Weinig.
- WebCore.xcodeproj/project.pbxproj:
- 4:00 PM Changeset in webkit [48271] by
-
- 6 edits2 adds in trunk
2009-09-10 Xiaomei Ji <xji@chromium.org>
Reviewed by Eric Seidel.
Implement Range.expand().
https://bugs.webkit.org/show_bug.cgi?id=27632
- fast/dom/Range/range-expand-expected.txt: Added.
- fast/dom/Range/range-expand.html: Added.
- fast/dom/Window/window-properties-expected.txt:
2009-09-10 Xiaomei Ji <xji@chromium.org>
Reviewed by Eric Seidel.
Implment Range.expand().
https://bugs.webkit.org/show_bug.cgi?id=27632
Test: fast/dom/Range/range-expand.html
- dom/Range.cpp: (WebCore::Range::expand):
- dom/Range.h:
- dom/Range.idl:
- 3:45 PM Changeset in webkit [48270] by
-
- 25 edits5 adds in trunk
Reviewed by Alexey Proskuryakov.
WebSocket API implementation.
https://bugs.webkit.org/show_bug.cgi?id=28038
Add build systems for GNUmakefile.am, WebCore.xcodeproj and
WebCore.vcproj.
Add websockets directory and WebSocket.idl in qt build system.
Tests will be landed once the code is completed and functional.
- 3:28 PM Changeset in webkit [48269] by
-
- 2 edits in trunk/WebCore
2009-09-10 Albert J. Wong <ajwong@chromium.org>
No review, windows build fix only.
Spurious semicolon causing parse error in chromium build on windows.
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::buffered): Removed semicolon.
- 3:15 PM Changeset in webkit [48268] by
-
- 2 edits in trunk/WebCore
2009-09-10 Albert J. Wong <ajwong@chromium.org>
No review, build fix only.
Adding in a missed include from the last patch that is breaking the
chromium build.
- rendering/RenderThemeChromiumMac.mm: include TimeRanges.h
- 2:46 PM Changeset in webkit [48267] by
-
- 17 edits in trunk/WebCore
HTMLMediaElement buffered attribute should report a list of time ranges
https://bugs.webkit.org/show_bug.cgi?id=29041
Patch by Alpha Lam <hclam@chromium.org> on 2009-09-10
Reviewed by Eric Carlson.
Changed MediaPlayerPrivateInterface and MediaPlayer's definition to
report a list of buffered time ranges as WebCore::TimeRanges. This
change also got rid of the maxTimeBuffered() method.
No new tests since this is a API change.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::percentLoaded):
Use MediaPlaier::buffered() instead of maxTimeBuffered().
(WebCore::HTMLMediaElement::buffered):
ditto.
- platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::buffered):
Use MediaPlayerPrivateInterface::buffered() instead of maxTimeBuffered().
(WebCore::MediaPlayer::buffered):
ditto.
- platform/graphics/MediaPlayer.h:
Removed maxTimeBuffered() and defines PassRefPtr<TimeRanges> buffered().
- platform/graphics/MediaPlayerPrivate.h:
ditto.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
Implements PassRefPtr<TimeRanges> buffered();
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
Removed maxTimeBuffered() and defines PassRefPtr<TimeRanges> buffered().
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
Removed maxTimeBuffered() and defines PassRefPtr<TimeRanges> buffered().
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivate::buffered):
Implementation of buffered().
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
Implements PassRefPtr<TimeRanegs> buffered().
- platform/graphics/qt/MediaPlayerPrivatePhonon.h:
Removed maxTimeBuffered() and defines PassRefPtr<TimeRanges> buffered().
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
Implements PassRefPtr<TimeRanges> buffered().
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
Removed maxTimeBuffered() and defines PassRefPtr<TimeRanges> buffered().
- platform/graphics/wince/MediaPlayerPrivateWince.h:
ditto.
- rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
Use buffered() instead of maxTimeBuffered().
- rendering/RenderThemeChromiumSkia.cpp:
ditto.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMediaSliderTrack):
ditto.
- 2:34 PM Changeset in webkit [48266] by
-
- 6 edits in trunk/WebCore
2009-09-10 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
Make bindings generators more aware of IDL dependencies
https://bugs.webkit.org/show_bug.cgi?id=29114
Make the JS and ObjC bindings generators able to output dependency
rules for DerivedSources.make to consume. These rules make a given
generated binding class file header, JSWhatever.h, depend on Whatever's
ancestor interfaces.
- DerivedSources.make: Pass --write-dependencies to generate-bindings.pl when generating JS and ObjC bindings. Include dependency fies that are generated due to that.
- bindings/scripts/CodeGenerator.pm: Make AddMethodsConstantsAndAttributesFromParentClasses accumulate a list of the ancestor interfaces that were visited.
- bindings/scripts/CodeGeneratorJS.pm: Optionally write out a dependency file.
- bindings/scripts/CodeGeneratorObjC.pm: Ditto.
- bindings/scripts/generate-bindings.pl: Add a --write-dependencies option.
- 1:49 PM Changeset in webkit [48265] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
Make StructureTransitionTable use an enum for the PtrAndFlags member
used for the single transition slot optimisation.
- 1:01 PM Changeset in webkit [48264] by
-
- 5 edits in trunk/JavaScriptCore
Refactor StructureTransitionTable and Structure to unify handling of the single slot optimization
https://bugs.webkit.org/show_bug.cgi?id=29141
Reviewed by Geoff Garen
Make StructureTransitionTable encapsulate the single transition slot optimization.
- 12:52 PM Changeset in webkit [48263] by
-
- 4 edits in trunk/WebKit/qt
Rubber-stamped by Ariya Hidayat.
Patch by Simon Hausmann <Simon Hausmann> on 2009-09-10
Fix a bunch of qdoc warnings: Invalid references, non-standard
wording, etc.
- Api/qwebelement.cpp:
- Api/qwebgraphicsitem.cpp:
- Api/qwebsecurityorigin.cpp:
- 12:42 PM Changeset in webkit [48262] by
-
- 5 edits in trunk/WebKit/qt
Fix context menu event delivery with QWebGraphicsItem.
Patch by Simon Hausmann <Simon Hausmann> on 2009-09-10
Reviewed by Ariya Hidayat.
Re-implement the correct context menu virtual function using
a QGraphicsSceneContextMenuEvent and forward & handle it in
QWebPage.
- Api/qwebgraphicsitem.cpp:
(QWebGraphicsItem::contextMenuEvent):
- Api/qwebgraphicsitem.h:
- Api/qwebpage.cpp:
(QWebPagePrivate::contextMenuEvent):
(QWebPage::event):
- Api/qwebpage_p.h:
- 11:24 AM MathML edited by
- (diff)
- 11:24 AM MathML edited by
- (diff)
- 11:19 AM MathML edited by
- (diff)
- 11:18 AM MathML created by
- 10:58 AM Changeset in webkit [48261] by
-
- 3 edits in trunk/WebCore
2009-09-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez and Dan Winship.
Give all requests to libsoup, to let it queue, and schedule them
itself, instead of throttling the number of requests in WebCore.
- platform/network/ResourceRequestBase.cpp:
- platform/network/soup/ResourceRequestSoup.cpp: (WebCore::initializeMaximumHTTPConnectionCountPerHost):
- 10:39 AM Changeset in webkit [48260] by
-
- 3 edits5 adds in trunk
WebCore: [V8] Make XMLHttpRequest.send handle File object.
https://bugs.webkit.org/show_bug.cgi?id=28924
Reviewed by Eric Seidel.
Test: http/tests/local/send-dragged-file.html
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
LayoutTests: [V8] Make XMLHttpRequest.send handle File object.
https://bugs.webkit.org/show_bug.cgi?id=28924
Reviewed by Eric Seidel.
Add a new layout test.
- http/tests/local/resources/file-for-drag-to-send.txt: Added.
- http/tests/local/resources/send-dragged-file.js: Added.
- http/tests/local/send-dragged-file-expected.txt: Added.
- http/tests/local/send-dragged-file.html: Added.
- 10:33 AM Changeset in webkit [48259] by
-
- 6 edits in trunk
2009-09-10 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Implement fastDeleteSkippingDestructor for FastAllocBase and fastDeleteAllValues for HashSet
https://bugs.webkit.org/show_bug.cgi?id=25930
FastAllocBase has been extended with fastDeleteSkippingDestructor function which
releases memory without destructor call. fastDeleteAllValues has been implemented
similar as deleteAllValues but it uses fastDelete function to release memory.
- wtf/FastAllocBase.h: (WTF::fastDeleteSkippingDestructor):
- wtf/HashSet.h: (WTF::fastDeleteAllValues):
2009-09-10 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Use fastNew and fastDelete instead of operator new and delete for CSSSelector class.
https://bugs.webkit.org/show_bug.cgi?id=25930
Change using of operator new to fastNew and operator delete to
fastDeleteSkippingDestructor for CSSSelector class to avoid mismatched function call.
This change fixes valgrind's 'mismatched free' notification.
- css/CSSParser.cpp: (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::createFloatingSelector):
- css/CSSSelectorList.cpp: (WebCore::CSSSelectorList::adoptSelectorVector):
- 10:16 AM Changeset in webkit [48258] by
-
- 5 edits6 adds in trunk
WebCore: Geolocation does not correctly handle reentrant calls from callbacks.
https://bugs.webkit.org/show_bug.cgi?id=29040
Patch by Steve Block <steveblock@google.com> on 2009-09-10
Reviewed by Darin Adler.
Tests: fast/dom/Geolocation/reentrant-error.html
fast/dom/Geolocation/reentrant-success.html
- page/Geolocation.cpp: Modified.
(WebCore::Geolocation::handleError): Modified. Call sendError directly, clearing notifier lists before making callback.
(WebCore::Geolocation::makeSuccessCallbacks): Modified. Call sendPosition directly, clearing notifier lists before making callback.
- page/Geolocation.h: Modified. Deleted sendErrorToXX and sendPositionToXXX methods.
LayoutTests: Geolocation does not correctly handle reentrant calls from callbacks.
https://bugs.webkit.org/show_bug.cgi?id=29040
Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Darin Adler.
- fast/dom/Geolocation/resources/reentrant-error.js: Added. Tests that reentrant calls from the error callback are OK.
- fast/dom/Geolocation/reentrant-error.html: Added. Wrapper for above test.
- fast/dom/Geolocation/reentrant-error-expected.txt: Added. Expected result for above test.
- fast/dom/Geolocation/resources/reentrant-success.js: Added. Tests that reentrant calls from the success callback are OK.
- fast/dom/Geolocation/reentrant-success.html: Added. Wrapper for above test.
- fast/dom/Geolocation/reentrant-success-expected.txt: Added. Expected result for above test.
- platform/gtk/Skipped: Modified. Skips above tests.
- 10:03 AM Changeset in webkit [48257] by
-
- 5 edits3 adds in trunk
2009-09-10 Erik Arvidsson <arv@chromium.org>
Reviewed by Eric Seidel.
Fixes issue where focused elements did not get blur and focus events when the window was blurred and focused.
https://bugs.webkit.org/show_bug.cgi?id=27105
- fast/events/blur-focus-window-should-blur-focus-element-expected.txt: Added.
- fast/events/blur-focus-window-should-blur-focus-element.html: Added.
- fast/events/resources/blur-focus-window-should-blur-focus-element.js: Added. (divElement.onfocus.divElement.onblur.window.onfocus.window.onblur.innerDiv.onfocus.innerDiv.onblur.iframe.onfocus.iframe.onblur): (testNextEvent):
- fast/events/resources/tabindex-focus-blur-all.js: (test):
- fast/events/tabindex-focus-blur-all-expected.txt:
2009-09-10 Erik Arvidsson <arv@chromium.org>
Reviewed by Eric Seidel.
Fixes issue where focused elements did not get blur and focus events when the window was blurred and focused.
https://bugs.webkit.org/show_bug.cgi?id=27105
Test: fast/events/blur-focus-window-should-blur-focus-element.html
- page/FocusController.cpp: (WebCore::dispatchEventsOnWindowAndFocusedNode): (WebCore::FocusController::setFocused): (WebCore::FocusController::setActive):
- 9:41 AM Changeset in webkit [48256] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-09-10 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Added a test case for inserting a new line character into the
request-uri.
- http/tests/xmlhttprequest/newline-in-request-uri-expected.txt: Added.
- http/tests/xmlhttprequest/newline-in-request-uri.html: Added.
- 8:56 AM Changeset in webkit [48255] by
-
- 2 edits in trunk/WebCore
Make the play/pause button in <video> controls indicate the button's action, not the movie state
This matches the Mac behavior, iTunes, and many other media players.
No test possible.
Fixes <http://webkit.org/b/29126> Play/pause button in <video>
controls shows the wrong image
Reviewed by Eric Carlson.
- rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::paintMediaControlsPart): Reversed when
we show the play vs. pause artwork, so that the button reflects what
will happen when you click it, rather than the current state of the
movie.
- 8:34 AM Changeset in webkit [48254] by
-
- 3 edits in trunk/WebKit/qt
2009-09-10 Laszlo Gombos <Laszlo Gombos>
Unreviewed.
qevent and qstyleoption are QtGui interfaces.
- Api/qwebgraphicsitem.cpp:
- Api/qwebgraphicsitem.h:
- 7:04 AM Changeset in webkit [48253] by
-
- 2 edits in trunk/WebKitTools
2009-09-10 Martin Robinson <martin.james.robinson@gmail.com>
[GTK] EventSender does not properly convert some keyDown strings
https://bugs.webkit.org/show_bug.cgi?id=29119
Add more keyDown string to character code conversions for GTK+ EventSender.
- DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
- 6:26 AM Changeset in webkit [48252] by
-
- 15 edits3 adds2 deletes in trunk
WebCore: Geolocation Coordinates::toString() prints bogus values for unspecified properties.
https://bugs.webkit.org/show_bug.cgi?id=29080
Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Maciej Stachowiak.
Test: fast/dom/Geolocation/position-string.html
- GNUmakefile.am: Modified. Removes Geoposition.cpp and Coordinates.cpp.
- WebCore.gypi: Modified. Removes Geoposition.cpp and Coordinates.cpp.
- WebCore.pro: Modified. Removes Geoposition.cpp and Coordinates.cpp.
- WebCore.vcproj/WebCore.vcproj: Modified. Removes Geoposition.cpp and Coordinates.cpp.
- WebCore.xcodeproj/project.pbxproj: Modified. Removes Geoposition.cpp and Coordinates.cpp.
- WebCoreSources.bkl: Modified. Removes Geoposition.cpp and Coordinates.cpp.
- page/Coordinates.cpp: Removed.
- page/Coordinates.h: Modified. Removes toString method.
- page/Coordinates.idl: Modified. Removes toString method.
- page/Geoposition.cpp: Removed.
- page/Geoposition.h: Modified. Removes toString method.
- page/Geoposition.idl: Modified. Removes toString method.
WebKitTools: Geolocation Coordinates::toString() prints bogus values for unspecified properties.
https://bugs.webkit.org/show_bug.cgi?id=29080
Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Maciej Stachowiak.
- Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list.
LayoutTests: Geolocation Coordinates::toString() prints bogus values for unspecified properties.
https://bugs.webkit.org/show_bug.cgi?id=29080
Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Maciej Stachowiak.
- fast/dom/Geolocation/resources/position-string.js: Added. Tests output of position.toString().
- fast/dom/Geolocation/position-string.html: Added. Wrapper for above test.
- fast/dom/Geolocation/position-string-expected.txt: Added. Expected result for above test.
- platform/gtk/Skipped: Modified. Skips above test.
- 5:45 AM Changeset in webkit [48251] by
-
- 2 edits in trunk/JavaScriptCore
2009-09-10 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
ARM compiler does not understand GCC visibility attribute
https://bugs.webkit.org/show_bug.cgi?id=29079
- API/JSBase.h: Make the test more specific to hit only the GCC compiler
- 4:59 AM Changeset in webkit [48250] by
-
- 2 edits in trunk
2009-09-10 Laszlo Gombos <Laszlo Gombos>
Reviewed by Ariya Hidayat.
Disable some ARM compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=29083
The following ARM compiler warnings are disabled
- #68-D: integer conversion resulted in a change of sign
- #111-D: statement is unreachable
- #177-D: variable XXX was declared but never referenced
- #368-D: class XXX defines no constructor to initialize the following: YYY
- #830-D: function XXX "XXX::operator new" has no corresponding operator delete
- #1293-D: assignment in condition
- WebKit.pri:
- 4:32 AM Changeset in webkit [48249] by
-
- 5 edits6 adds in trunk
WebCore: Correctly applies the Geolocation timeout property.
https://bugs.webkit.org/show_bug.cgi?id=27256
Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Adam Barth.
If a timeout is specified, the timer is started as soon as the location acquistion process starts.
If a position fix is not obtained within the timeout interval, the position request is cancelled
and the error callback (if specified) is invoked. If a position fix is obtained within the timeout
interval, the timer is stopped. Permissions are then requested from the user if required. See
http://www.w3.org/TR/geolocation-API/#position-options.
Note that this logic means that the time required to obtain permissions from the user is not
included in the timeout interval.
Tests: fast/dom/Geolocation/timeout.html
fast/dom/Geolocation/timeout-zero.html
- page/Geolocation.cpp: Modified.
(WebCore::Geolocation::GeoNotifier::GeoNotifier): Modified. Takes Geolocation object as parameter.
(WebCore::Geolocation::GeoNotifier::hasZeroTimeout): Added. Determines whether this request has a zero timeout.
(WebCore::Geolocation::GeoNotifier::startTimerIfNeeded): Renamed from startTimer. Starts the timer if a timeout was specified.
(WebCore::Geolocation::GeoNotifier::timerFired): Modified. Calls the error callback if specified, and reports the timeout to the Geolocation object.
(WebCore::Geolocation::getCurrentPosition): Modified. Calls maybeStartTimer when starting the location acquisition process.
(WebCore::Geolocation::watchPosition): Modified. Calls maybeStartTimer when starting the location acquisition process.
(WebCore::Geolocation::requestTimedOut): Added. Cancels a request when it times out.
(WebCore::Geolocation::setIsAllowed): Modified. No longer starts timers.
(WebCore::Geolocation::sendPosition): Modified. No longer stops timers.
(WebCore::Geolocation::stopTimer): Added. Stops the timers for a vector of notifiers.
(WebCore::Geolocation::stopTimersForOneShots): Added. Stops the timers for all one-shots.
(WebCore::Geolocation::stopTimersForWatchers): Added. Stops the timers for all watchers.
(WebCore::Geolocation::stopTimers): Added. Stops the timers for all requests.
(WebCore::Geolocation::geolocationServicePositionChanged): Modfified. Stops the timers for all requests.
- page/Geolocation.h: Modified.
(WebCore::Geolocation::GeoNotifier::create): Modified. Takes Geolocation object as parameter.
LayoutTests: Correctly applies the Geolocation timeout property.
https://bugs.webkit.org/show_bug.cgi?id=27256
Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Adam Barth.
- fast/dom/Geolocation/resources/timeout.js: Added. Tests that when a non-zero timeout is used, the success callback is invoked as expected.
- fast/dom/Geolocation/timeout.html: Added. Wrapper for above test.
- fast/dom/Geolocation/timeout-expected.txt: Added. Expected result for above test.
- fast/dom/Geolocation/resources/timeout-zero.js: Added. Tests that when a zero timeout is used, the error callback is invoked with code TIMEOUT.
- fast/dom/Geolocation/timeout-zero.html: Added. Wrapper for above test.
- fast/dom/Geolocation/timeout-zero-expected.txt: Added. Expected result for above test.
- platform/gtk/Skipped: Modified. Skips the above tests.
- 2:08 AM Changeset in webkit [48248] by
-
- 2 edits in trunk/JavaScriptCore
2009-09-10 Adam Barth <abarth@webkit.org>
Unreviewed revert of the previous change. It broke the tests.
- wtf/dtoa.cpp: (WTF::dtoa):
- 1:51 AM Changeset in webkit [48247] by
-
- 2 edits in trunk/JavaScriptCore
2009-09-10 Ben Laurie <benl@google.com>
Reviewed by Adam Barth.
If dtoa was given a small buffer and the number was either infinite or
NaN, then the buffer would be overflowed.
- wtf/dtoa.cpp:
Sep 9, 2009:
- 11:58 PM Changeset in webkit [48246] by
-
- 2 edits in trunk/WebKit/qt
Call the right base class function QGraphicsWidget::event() instead
of skipping it and using QObject::event() instead.
Patch by Simon Hausmann <Simon Hausmann> on 2009-09-09
Reviewed by Tor Arne Vestbø.
- Api/qwebgraphicsitem.cpp:
(QWebGraphicsItem::event):
- 11:47 PM Changeset in webkit [48245] by
-
- 2 edits in trunk/WebCore
AX notifications should be an ENUM type instead of strings
https://bugs.webkit.org/show_bug.cgi?id=28963
Build fix for Qt.
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::postPlatformNotification):
- 11:38 PM Changeset in webkit [48244] by
-
- 15 edits in trunk/WebCore
AX notifications should be an ENUM type instead of strings
https://bugs.webkit.org/show_bug.cgi?id=28963
Reviewed by Darin Adler.
Moves AX notifications over to an ENUM type instead of
using the actual string values that are used on OS X.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::selectedChildrenChanged):
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
- accessibility/chromium/AXObjectCacheChromium.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
- accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
- accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
- dom/Document.cpp:
(WebCore::Document::implicitClose):
- dom/Element.cpp:
(WebCore::Element::updateAfterAttributeChanged):
- editing/Editor.cpp:
(WebCore::Editor::respondToChangedContents):
- editing/mac/SelectionControllerMac.mm:
(WebCore::SelectionController::notifyAccessibilityForSelectionChange):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setChecked):
- page/FrameView.cpp:
(WebCore::FrameView::layout):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::setInnerTextValue):
- 10:25 PM Changeset in webkit [48243] by
-
- 3 edits in trunk/WebKitTools
2009-09-09 Eric Seidel <eric@webkit.org>
Reviewed by Eric Carlson.
reviewer/committer lookups are backwards
https://bugs.webkit.org/show_bug.cgi?id=29113
I also moved Eric Carlson from the committer list to the reviewer list now that he is one.
- Scripts/modules/bugzilla.py:
- Scripts/modules/committers.py:
- 10:17 PM Changeset in webkit [48242] by
-
- 3 edits in trunk/WebKitTools
2009-09-09 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
svn-unapply doesn't revert directories correctly
https://bugs.webkit.org/show_bug.cgi?id=29065
- Scripts/svn-unapply: Make svnStatus consistently return status lines including a newline.
- Scripts/svn-apply: Keep svnStatus in sync with the one in svn-unapply, in lieu of moving it to a common file.
- 9:52 PM Changeset in webkit [48241] by
-
- 2 edits in trunk/BugsSite
Update data/params parameters
- data/params: Updated 'attachment_base' parameter for secure attachments. Updated 'mybugstemplate' parameter to search for bugs in UNCONFIRMED, ASSIGNED and REOPENED status in addition to NEW status.
- 7:54 PM Changeset in webkit [48240] by
-
- 3 edits5 adds in trunk
2009-09-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Missing checkout for getSVGDocument()
https://bugs.webkit.org/show_bug.cgi?id=29064
The V8 code generator didn't understand SVGCheckSecurityDocument.
Tests: http/tests/security/xss-DENIED-getSVGDocument-iframe.html
http/tests/security/xss-DENIED-getSVGDocument-object.html
- bindings/scripts/CodeGeneratorV8.pm:
2009-09-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Missing checkout for getSVGDocument()
https://bugs.webkit.org/show_bug.cgi?id=29064
Add tests that getSVGDocument() has the proper checks.
- http/tests/security/resources/flag.php: Added.
- http/tests/security/xss-DENIED-getSVGDocument-iframe-expected.txt: Added.
- http/tests/security/xss-DENIED-getSVGDocument-iframe.html: Added.
- http/tests/security/xss-DENIED-getSVGDocument-object-expected.txt: Added.
- http/tests/security/xss-DENIED-getSVGDocument-object.html: Added.
- 5:55 PM Changeset in webkit [48239] by
-
- 5 edits6 adds in trunk
2009-09-09 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
Make SVGStyleElement inherit from SVGLangSpace
https://bugs.webkit.org/show_bug.cgi?id=29058
Required by SVG 1.1 Second Edition:
http://dev.w3.org/SVG/profiles/1.1F2/publish/styling.html#InterfaceSVGStyleElement
- svg/dom/SVGStyleElement: Added.
- svg/dom/SVGStyleElement/resources: Added.
- svg/dom/SVGStyleElement/resources/TEMPLATE.html: Copied from LayoutTests/svg/dom/resources/TEMPLATE.html with some "../"s added.
- svg/dom/SVGStyleElement/resources/style-langspace.js: Added.
- svg/dom/SVGStyleElement/style-langspace-expected.txt: Added.
- svg/dom/SVGStyleElement/style-langspace.html: Added.
2009-09-09 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
Make SVGStyleElement inherit from SVGLangSpace
https://bugs.webkit.org/show_bug.cgi?id=29058
Required by SVG 1.1 Second Edition:
http://dev.w3.org/SVG/profiles/1.1F2/publish/styling.html#InterfaceSVGStyleElement
Test: svg/dom/SVGStyleElement/style-langspace.html
- svg/SVGStyleElement.cpp: Drop methods xmlspace and setXmlspace. (WebCore::SVGStyleElement::SVGStyleElement): Add SVGLangSpace() initializer. (WebCore::SVGStyleElement::parseMappedAttribute): Call parseMappedAttribute on SVGLangSpace.
- svg/SVGStyleElement.h: Drop xmlspace and setXmlspace declarations.
- svg/SVGStyleElement.idl: Drop xmlspace attribute and add SVGLangSpace as a superinterface.
- 5:39 PM Changeset in webkit [48238] by
-
- 2 edits in trunk/WebCore
2009-09-09 Nate Chapin <Nate Chapin>
Reviewed by David Levin.
Remove unnecessary includes and forward declarations in V8Proxy.h
- bindings/v8/V8Proxy.h:
- 4:55 PM Changeset in webkit [48237] by
-
- 11 edits1 add in trunk/LayoutTests
2009-09-09 Alpha Lam <hclam@chromium.org>
Reviewed by Eric Carlson.
Media layout tests should have a way to provide test files in different formats
https://bugs.webkit.org/show_bug.cgi?id=28327
Added media-file.js which has a findMediaFile(type, name) method
to find a proper media file to load according to supported codecs.
Also changed 10 layout tests to use above method to locate the test file.
- media/controls-strict.html: Use findMediaFile(type, name).
- media/controls-styling.html: ditto.
- media/media-file.js: Added. Provide findMediaFile(type, name).
- media/video-append-source.html: Use findMediaFile(type, name).
- media/video-aspect-ratio.html: ditto.
- media/video-autoplay.html: ditto.
- media/video-buffered.html: ditto.
- media/video-controls-rendering.html: ditto.
- media/video-layer-crash.html: ditto.
- media/video-transformed.html: Use findMediaFile(type, name).
- media/video-zoom-controls.html: ditto.
- 4:41 PM Changeset in webkit [48236] by
-
- 2 edits in trunk/WebKitTools
2009-09-09 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
svn-apply doesn't handle changes to files copied to new directories properly
https://bugs.webkit.org/show_bug.cgi?id=29059
- Scripts/svn-apply: Don't treat "--- revision 0" patches as being additions if we know that we've just copied a file to this name.
- 4:25 PM Changeset in webkit [48235] by
-
- 6 edits in trunk/WebCore
2009-07-30 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add more position constructors
positionBeforeNode, positionAfterNode
firstPositionInNode, lastPositionInNode
https://bugs.webkit.org/show_bug.cgi?id=25494
I also added a lastOffsetInNode and deployed it to a couple places.
There are no callers to these new constructors yet, but those
will be coming in future patches.
- dom/Position.cpp: (WebCore::Position::computeOffsetInContainerNode):
- dom/Position.h: (WebCore::positionBeforeNode): (WebCore::positionAfterNode): (WebCore::lastOffsetInNode): (WebCore::firstPositionInNode): (WebCore::lastPositionInNode):
- editing/ApplyStyleCommand.cpp:
- editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
- editing/htmlediting.cpp: (WebCore::lastOffsetForEditing):
- 4:25 PM Changeset in webkit [48234] by
-
- 16 edits1 add in trunk/WebCore
2009-07-30 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Rename positionBeforeNode to positionInParentBeforeNode
and positionAfterNode to positionInParentAfterNode
in preparation for adding a positionBeforeNode
which returns a neighbor-anchored position.
https://bugs.webkit.org/show_bug.cgi?id=25494
No functional changes, thus no tests.
- dom/PositionConstructors.h: (WebCore::positionInParentBeforeNode): (WebCore::positionInParentAfterNode):
- dom/PositionIterator.cpp: (WebCore::PositionIterator::operator Position):
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle):
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionOutsideTabSpan): (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
- editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply):
- editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::deleteTarget):
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): (WebCore::updatePositionForNodeRemoval):
- editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
- editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply):
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
- editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): (WebCore::ReplaceSelectionCommand::doApply):
- editing/VisibleSelection.cpp: (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
- editing/htmlediting.cpp: (WebCore::firstEditablePositionAfterPositionInRoot): (WebCore::lastEditablePositionBeforePositionInRoot): (WebCore::rangeCompliantEquivalent): (WebCore::positionBeforeContainingSpecialElement): (WebCore::positionAfterContainingSpecialElement): (WebCore::positionBeforeTabSpan):
- 4:25 PM Changeset in webkit [48233] by
-
- 7 edits in trunk/WebCore
2009-07-30 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Re-organize position creation functions in preparation for adding more
https://bugs.webkit.org/show_bug.cgi?id=25494
Make position functions inline to avoid ref-churn.
Remove startPosition/endPosition as they were only used in one place.
No functional changes, thus no tests.
- dom/Position.cpp:
- dom/Position.h: (WebCore::positionBeforeNode): (WebCore::positionAfterNode):
- editing/SelectionController.cpp: (WebCore::SelectionController::moveTo):
- editing/TypingCommand.cpp:
- editing/htmlediting.cpp:
- editing/htmlediting.h: (WebCore::firstDeepEditingPositionForNode): (WebCore::lastDeepEditingPositionForNode):
- rendering/RenderObject.cpp:
- 3:50 PM Changeset in webkit [48232] by
-
- 2 edits1 add in trunk/WebCore
Reviewed by Kevin Ollivier.
[wx] Add wxSize conversions for IntSize.
https://bugs.webkit.org/show_bug.cgi?id=29104
- 3:35 PM Changeset in webkit [48231] by
-
- 2 edits in trunk/WebCore
2009-09-09 Yaar Schnitman <yaar@chromium.org>
Reviewed by David Levin.
Chromium uses its own config.h file that was forked from webkit's config.h.
By merging in Chromium's defines, Chromium would again be able to use webkit's
config.h.
- config.h: Added chromium-specific defines.
- 3:21 PM Changeset in webkit [48230] by
-
- 3 edits in trunk/WebKitTools
2009-09-09 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
commit-queue hangs if a builder has never built
https://bugs.webkit.org/show_bug.cgi?id=29091
- Scripts/modules/buildbot.py:
- Scripts/modules/buildbot_unittest.py:
- 3:19 PM Changeset in webkit [48229] by
-
- 10 edits2 adds in trunk
2009-09-09 Jens Alfke <snej@chromium.org>
Reviewed by Eric Seidel.
Initialize DataTransfer's effectAllowed and dropEffect properties correctly
according to HTML5 spec (sec. 7.9.2-7.9.3).
https://bugs.webkit.org/show_bug.cgi?id=26700
- fast/events/drag-dropeffect-expected.txt: Added.
- fast/events/drag-dropeffect.html: Added.
2009-09-09 Jens Alfke <snej@chromium.org>
Reviewed by Eric Seidel.
Initialize DataTransfer's effectAllowed and dropEffect properties correctly
according to HTML5 spec (sec. 7.9.2-7.9.3).
https://bugs.webkit.org/show_bug.cgi?id=26700
- At the start of a drag operation, the value of effectAllowed should be the string "uninitialized".
- At end of dragstart handler, if effectAllowed hasn't been set yet, it should be set to "copy".
- on dragenter and dragover event, dropEffect should be initialized to a default value based on the value of effectAllowed.
- at end of dragenter and dragover the dropEffect should be set to "none" if the value set by the handler doesn't match the effectAllowed.
- on dragleave event, dropEffect should be "none".
- on drop event, dropEffect should be the previously negotiated value.
Test: fast/events/drag-dropeffect.html
- WebCore.base.exp:
Added a parameter to EventHandler::dragSourceMovedTo.
- dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard):
Initialize m_effectAllowed to "uninitialized".
(WebCore::Clipboard::sourceOperation):
Treat "uninitialized" as meaning no value has been set.
- page/DragController.cpp: (WebCore::DragController::DragController):
Initialize new member m_destinationDragOperation.
(WebCore::DragController::dragExited):
Set m_destinationDragOperation to none on dragExit.
(WebCore::DragController::performDrag):
Set m_destinationDragOperation to current dropEffect.
(WebCore::DragController::dragEnteredOrUpdated):
Make sure to clear the operation if drag source doesn't allow it.
(WebCore::DragController::tryDHTMLDrag):
Set a default value for the dst drag op before sending dragEnter/Over.
(WebCore::DragController::startDrag):
Clear m_destinationDragOperation at start of drag.
- page/DragController.h: (WebCore::DragController::destinationDragOperation):
Added new member m_destinationDragOperation, and its public getter.
- page/EventHandler.cpp: (WebCore::EventHandler::updateDragAndDrop):
dropEffect should be 'none' during dropleave handler, per spec.
(WebCore::EventHandler::dragSourceMovedTo):
Added DragOperation parameter, so the handler sees the current dropEffect.
(WebCore::EventHandler::handleDrag):
Assume DragOperationEvery for non-DHTML drags.
- page/EventHandler.h:
Added DragOperation parameter to dragSourceMovedTo().
2009-09-09 Jens Alfke <snej@chromium.org>
Reviewed by Eric Seidel.
Initialize DataTransfer's effectAllowed and dropEffect properties correctly
according to HTML5 spec (sec. 7.9.2-7.9.3).
https://bugs.webkit.org/show_bug.cgi?id=26700
- WebView/WebFrame.mm: (-[WebFrame _dragSourceMovedTo:]):
Pass current drag operation (if known) to EventHandler::dragSourceMovedTo().
- 3:10 PM Changeset in webkit [48228] by
-
- 8 edits2 adds in trunk
2009-09-09 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
[GTK] DumpRenderTree needs eventSender object and implementation
https://bugs.webkit.org/show_bug.cgi?id=25990
Enable plenty of tests that now pass thanks to (only) partial
EventSender implementation.
- platform/gtk/Skipped:
2009-09-09 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
[GTK] DumpRenderTree needs eventSender object and implementation
https://bugs.webkit.org/show_bug.cgi?id=25990
Creates a function that is accessible from the DumpRenderTree tool
and calls the layout method on the frame view.
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp: (webkit_web_frame_layout):
2009-09-09 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
[GTK] DumpRenderTree needs eventSender object and implementation
https://bugs.webkit.org/show_bug.cgi?id=25990
Implements most of the EventSender object's functionality for
the DumpRenderTree tool. Implementation still lacks support
for drag and drop tests and forward leaps.
Based on work by Holger Hans Peter Freyther.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): Focus on the view before loading a new test. (webViewWindowObjectCleared):
- DumpRenderTree/gtk/EventSender.cpp: Added. (getDragModeCallback): (setDragModeCallback): (leapForwardCallback): (contextClickCallback): (updateClickCount): (mouseDownCallback): (mouseUpCallback): (mouseMoveToCallback): (beginDragWithFilesCallback): (replaySavedEvents): (keyDownCallback): (textZoomInCallback): (textZoomOutCallback): (zoomPageInCallback): (zoomPageOutCallback): (getClass): (makeEventSender):
- DumpRenderTree/gtk/EventSender.h: Added.
- GNUmakefile.am: Add build rules for EventSender.
- 2:35 PM Changeset in webkit [48227] by
-
- 14 edits2 adds in trunk
2009-09-09 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
Adding a test for the database authorizer.
- storage/test-authorizer-expected.txt: Added.
- storage/test-authorizer.html: Added.
2009-09-09 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Dimitri Glazkov.
- Adding support/bindings for read-only transactions.
- Disallowing the SQLITE_*_VIEW and REINDEX operations in the private browsing mode.
- Adding an authorizer test.
Test: storage/test-authorizer.html
- bindings/js/JSDatabaseCustom.cpp: (WebCore::createTransaction): Parses all arguments and executes a transaction. (WebCore::JSDatabase::transaction): Refactored to use createTransaction(). (WebCore::JSDatabase::readTransaction): Added to execute read-only transactions using createTransaction().
- bindings/v8/custom/V8CustomBinding.h: Added the binding for Database::readTransaction().
- bindings/v8/custom/V8DatabaseCustom.cpp: (WebCore::createTransaction): Parses all arguments and executes a transaction. (WebCore::transaction): Refactored to use createTransaction(). (WebCore::readTransaction): Added to execute read-only transactions using createTransaction().
- storage/Database.cpp: (WebCore::Database::transaction): Added support for read-only transactions.
- storage/Database.h: Added support for read-only transactions.
- storage/Database.idl: Added support for read-only transactions.
- storage/DatabaseAuthorizer.cpp: (WebCore::DatabaseAuthorizer::createTempTable): Make it obvious that the statement will be denied in private browsing mode and read-only transactions. (WebCore::DatabaseAuthorizer::dropTempTable): Same. (WebCore::DatabaseAuthorizer::createTempIndex): Same. (WebCore::DatabaseAuthorizer::dropTempIndex): Same. (WebCore::DatabaseAuthorizer::createTempTrigger): Same. (WebCore::DatabaseAuthorizer::dropTempTrigger): Same. (WebCore::DatabaseAuthorizer::createView): Deny in private browsing mode and read-only transactions. (WebCore::DatabaseAuthorizer::createTempView): Same. (WebCore::DatabaseAuthorizer::dropView): Same. (WebCore::DatabaseAuthorizer::dropTempView): Same. (WebCore::DatabaseAuthorizer::allowReindex): Same.
- storage/DatabaseAuthorizer.h:
- storage/SQLTransaction.cpp: Added support for read-only transactions. (WebCore::SQLTransaction::create): (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::executeSQL): (WebCore::SQLTransaction::acquireLock):
- storage/SQLTransaction.h:
- storage/SQLTransactionCoordinator.cpp: (WebCore::SQLTransactionCoordinator::acquireLock): Added a new parameter in preparation for a change that will allow multiple read-only transactions on the same DB to run concurrently.
- storage/SQLTransactionCoordinator.h:
- 2:30 PM QtWebKitContrib edited by
- (diff)
- 2:28 PM Changeset in webkit [48226] by
-
- 2 edits in trunk/WebKitSite
Add instructions to bug reporting guidlines on how and when
to apply port-specific keywords.
Reviewed by Mark Rowe.
- quality/bugwriting.html:
- 2:21 PM Changeset in webkit [48225] by
-
- 4 edits in trunk/WebCore/page
Fix namespace typos.
- 2:21 PM Changeset in webkit [48224] by
-
- 1 edit in trunk/WebCore/page/FrameTree.cpp
Fix namespace typos.
- 2:18 PM Changeset in webkit [48223] by
-
- 2 edits in trunk/WebKit/qt
Fix comment at Tor Arne Vestbø's request.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-09
- Api/qwebgraphicsitem.cpp:
(QWebGraphicsItem::sceneEvent):
(QWebGraphicsItem::event):
- 2:12 PM Changeset in webkit [48222] by
-
- 23 edits4 adds in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=29102, add support for user stylesheet injection. This is similar
to user script injection but allows for user stylesheets to be added. The stylesheets are applied immediately
to all Frames in the PageGroup.
Reviewed by Adam Roben.
Added userscripts/simple-stylesheet.html test case.
- WebCore.base.exp:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
- css/CSSStyleSelector.h:
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::attach):
(WebCore::Document::pageGroupUserSheets):
(WebCore::Document::clearPageGroupUserSheets):
(WebCore::Document::recalcStyleSelector):
- dom/Document.h:
- loader/PlaceholderDocument.cpp:
(WebCore::PlaceholderDocument::attach):
- page/PageGroup.cpp:
(WebCore::PageGroup::addUserStyleSheet):
(WebCore::PageGroup::removeUserContentForWorld):
(WebCore::PageGroup::removeAllUserContent):
- page/PageGroup.h:
(WebCore::PageGroup::userStyleSheets):
- page/UserStyleSheet.h: Added.
(WebCore::UserStyleSheet::UserStyleSheet):
(WebCore::UserStyleSheet::source):
(WebCore::UserStyleSheet::url):
(WebCore::UserStyleSheet::patterns):
(WebCore::UserStyleSheet::worldID):
- page/UserStyleSheetTypes.h: Added.
WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=29102, add support for user stylesheet injection. This is similar
to user script injection but allows for user stylesheets to be added. The stylesheets are applied immediately
to all Frames in the PageGroup.
Reviewed by Adam Roben.
Added userscripts/simple-stylesheet.html test case.
- WebView/WebView.mm:
(+[WebView _addUserStyleSheetToGroup:source:url:worldID:patterns:]):
- WebView/WebViewPrivate.h:
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=29102, add support for user stylesheet injection. This is similar
to user script injection but allows for user stylesheets to be added. The stylesheets are applied immediately
to all Frames in the PageGroup.
Reviewed by Adam Roben.
Added userscripts/simple-stylesheet.html test case.
- platform/mac/userscripts/simple-stylesheet-expected.checksum: Added.
- platform/mac/userscripts/simple-stylesheet-expected.png: Added.
- platform/mac/userscripts/simple-stylesheet-expected.txt: Added.
- userscripts/simple-stylesheet.html: Added.
- 2:11 PM Changeset in webkit [48221] by
-
- 3 edits in trunk/WebKit/qt
Implement some virtual event methods so that we can fix
event-related bugs in Qt patch releases.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-09
Reviewed by Tor Arne Vestbø.
- Api/qwebgraphicsitem.cpp:
(QWebGraphicsItem::sceneEvent):
(QWebGraphicsItem::event):
- Api/qwebgraphicsitem.h:
- 1:40 PM Changeset in webkit [48220] by
-
- 5 edits6 adds in trunk
2009-09-09 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] CSS Style -webkit-box-shadow is not rendered correctly on
Qt platform
https://bugs.webkit.org/show_bug.cgi?id=23291
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): Added the ability to draw shadows for all these curves.
2009-09-09 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] -webkit-box-shadow CSS Style is not rendered correctly on
Qt platform
https://bugs.webkit.org/show_bug.cgi?id=23291
- platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
- platform/qt/fast/box-shadow/basic-shadows-expected.png:
- platform/qt/fast/box-shadow/inset-expected.checksum:
- platform/qt/fast/box-shadow/inset-expected.png:
- platform/qt/fast/box-shadow/spread-expected.checksum:
- platform/qt/fast/box-shadow/spread-expected.png: Updated to show the new shadows.
- 1:15 PM Changeset in webkit [48219] by
-
- 8 edits5 adds in trunk
.: [Qt] Add the alternative QtLauncher (based on QGraphicsView) to the build.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-09
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=28862
- WebKit.pro:
WebCore: Add the qwebgraphicsitem.cpp to the build system.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-09
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=28862
- WebCore.pro:
WebKit/qt: Add a new QGraphicsWidget based version of the "QWebView"
under the name "QWebGraphicsItem".
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org>, Antonio Gomes <antonio.gomes@openbossa.org> on 2009-09-09
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=28862
Includes an alternative Qt launcher using the QGraphicsView.
- Api/headers.pri:
- Api/qwebgraphicsitem.cpp: Added.
- Api/qwebgraphicsitem.h: Added.
- Api/qwebpage.h:
- QGVLauncher/QGVLauncher.pro: Copied from WebKit/qt/QtLauncher/QtLauncher.pro.
- QGVLauncher/main.cpp: Added.
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::repaint):
(WebCore::ChromeClientQt::scroll):
- 11:41 AM Changeset in webkit [48218] by
-
- 2 edits in trunk/WebKitTools
2009-09-09 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Roben.
Added pre- and post- build events so that on build failure, the file
buildfailed is written to the directory $(WebKitOutputDir).
- WinLauncher/WinLauncher.vcproj:
- 11:09 AM Changeset in webkit [48217] by
-
- 2 edits in trunk/JavaScriptCore
2009-09-09 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
Change reinterpret_cast to static_cast in r48212.
- jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
- 10:56 AM Changeset in webkit [48216] by
-
- 2 edits in trunk/JavaScriptCore
2009-09-09 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
Remove WTF_PLATFORM_FORCE_PACK as it is no longer used
https://bugs.webkit.org/show_bug.cgi?id=29066
- wtf/Platform.h:
- 10:42 AM Changeset in webkit [48215] by
-
- 2 edits in trunk/WebKitTools
Unreviewed.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-09
Add myself to list of committers.
- Scripts/modules/committers.py:
- 10:36 AM Changeset in webkit [48214] by
-
- 6 edits in trunk/WebKitTools
2009-09-08 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
commit-queue gets stuck if a non-committer sets commit-queue+ or review+
https://bugs.webkit.org/show_bug.cgi?id=28605
https://bugs.webkit.org/show_bug.cgi?id=28916
- Scripts/bugzilla-tool:
- Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit" comment now that it's used for rejecting patches for invalid committers too.
- Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them.
- Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916.
- Scripts/modules/bugzilla.py:
- Make _parse_attachment_element not validate reviewer/committer.
- Share flag parsing code in _parse_attachment_flag.
- Add _validate* methods for validating reviewers and committers and updating bugs when validation fails.
- Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not.
- Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction.
- Scripts/modules/bugzilla_unittest.py:
- Update this test to no longer expect committer/reviewer validation.
- Scripts/modules/committers.py:
- Return None on failed lookups instead of raising Exceptions.
- Scripts/modules/committers_unittest.py:
- Update tests to expect None returns instead of exceptions.
- 10:35 AM Changeset in webkit [48213] by
-
- 7 edits8 adds in trunk/WebCore
Reviewed by Kevin Ollivier.
[wx port] Move functions in TemporaryLinkStubs.cpp out to files where
they belong.
- 9:46 AM Changeset in webkit [48212] by
-
- 2 edits in trunk/JavaScriptCore
2009-09-09 Laszlo Gombos <Laszlo Gombos>
Reviewed by Ariya Hidayat.
Implement flushing the instruction cache for Symbian
https://bugs.webkit.org/show_bug.cgi?id=29075
- jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush): Call IMB_Range to flush the instruction cache on Symbian
- 9:44 AM Changeset in webkit [48211] by
-
- 3 edits in trunk/LayoutTests
2009-09-09 Erik Arvidsson <arv@chromium.org>
Reviewed by David Levin.
Fix preference name in layout test.
https://bugs.webkit.org/show_bug.cgi?id=29038
- fast/events/click-focus-anchor.html:
- fast/events/tab-focus-anchor.html:
- 9:27 AM Changeset in webkit [48210] by
-
- 8 edits3 adds in trunk
2009-09-09 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Geolocation incorrectly calls error callback in case of exception in success callback.
https://bugs.webkit.org/show_bug.cgi?id=27255
- fast/dom/Geolocation/resources/callback-exception.js: Added. Tests that when an exception is thrown from the success callback, the error callback is not invoked.
- fast/dom/Geolocation/callback-exception.html: Added. Wrapper for above test.
- fast/dom/Geolocation/callback-exception-expected.txt: Added. Expected result for above test.
- platform/gtk/Skipped: Modified. Adds the above tests to the skipped list.
2009-09-09 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Geolocation incorrectly calls error callback in case of exception in success callback.
https://bugs.webkit.org/show_bug.cgi?id=27255
Test: fast/dom/Geolocation/callback-exception.html
- bindings/js/JSCustomPositionCallback.cpp: Modified. (WebCore::JSCustomPositionCallback::handleEvent): Modified. Removed raisedException out param.
- bindings/js/JSCustomPositionCallback.h: Modified. Removed raisedException out param from handleEvent method and made handleEvent private.
- bindings/js/JSCustomPositionErrorCallback.h: Modified. Made handleEvent private.
- page/Geolocation.cpp: Modified. (WebCore::Geolocation::sendPosition): Modified. No longer call error callback in case of exception in success callback.
- page/PositionCallback.h: Modified. Removed raisedException out param from handleEvent method.
- 8:59 AM Changeset in webkit [48209] by
-
- 5 edits6 adds in trunk
WebCore: When Geolocation permission is denied, stops watches as well as one-shots.
https://bugs.webkit.org/show_bug.cgi?id=28305.
Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Darin Adler.
Tests: fast/dom/Geolocation/watch.html
fast/dom/Geolocation/permission-denied-stops-watches.html
- page/Geolocation.cpp: Modified.
(WebCore::Geolocation::setIsAllowed): Modified. Marks the permission error as fatal.
(WebCore::Geolocation::handleError): Modified. If the error is fatal, stops watchers as well as one-shots.
- page/PositionError.h: Modified.
(WebCore::PositionError::setIsFatal): Added. Marks an error as fatal.
(WebCore::PositionError::isFatal): Added. Determines whether an error is fatal.
LayoutTests: When Geolocation permission is denied, stops watches as well as one-shots.
https://bugs.webkit.org/show_bug.cgi?id=28305.
Patch by Steve Block <steveblock@google.com> on 2009-09-09
Reviewed by Darin Adler.
- fast/dom/Geolocation/resources/watch.js: Added. Tests that a watch correctly reports updates from the Geolocation service.
- fast/dom/Geolocation/watch.html: Added. Wrapper for above test.
- fast/dom/Geolocation/watch-expected.txt: Added. Expected result for above test.
- fast/dom/Geolocation/resources/permission-denied-stops-watches.js: Added. Tests that when Geolocation permission is denied, watches are stopped, as well as one-shots.
- fast/dom/Geolocation/permission-denied-stops-watches.html: Added. Wrapper for above test.
- fast/dom/Geolocation/permission-denied-stops-watches-expected.txt: Added. Expected result for above test.
- 8:15 AM Changeset in webkit [48208] by
-
- 2 edits in trunk/WebCore
2009-09-09 Roland Steiner <rolandsteiner@google.com>
Reviewed by Eric Seidel.
Bug 28964 - [Chromium] ChromiumDataObject should have getter/setter interface
Added getter/setter methods and trivial inline implementations for each.
(Note that they are not yet actually used.)
Once the Chromium code is changed to use them instead of directly accessing the
member variables, the member variables should be made private and cleaned up.
No new tests (no functional behavior changed).
- platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::mainURL): (WebCore::ChromiumDataObject::setMainURL): (WebCore::ChromiumDataObject::mainURLTitle): (WebCore::ChromiumDataObject::setMainURLTitle): (WebCore::ChromiumDataObject::textPlain): (WebCore::ChromiumDataObject::setTextPlain): (WebCore::ChromiumDataObject::textHTML): (WebCore::ChromiumDataObject::setTextHTML): (WebCore::ChromiumDataObject::htmlBaseURL): (WebCore::ChromiumDataObject::setHTMLBaseURL): (WebCore::ChromiumDataObject::content): (WebCore::ChromiumDataObject::releaseContent): (WebCore::ChromiumDataObject::setContent): (WebCore::ChromiumDataObject::contentFileExtension): (WebCore::ChromiumDataObject::setContentFileExtension): (WebCore::ChromiumDataObject::contentFileName): (WebCore::ChromiumDataObject::setContentFileName): (WebCore::ChromiumDataObject::fileNames): (WebCore::ChromiumDataObject::setFileNames): (WebCore::ChromiumDataObject::takeFileNames):
- 7:56 AM Changeset in webkit [48207] by
-
- 4 edits1 move in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=29024
Make JavaScriptCore compile on platforms with case-insensitive file systems and typeinfo.h in STL
Patch by Kent Hansen <khansen@trolltech.com> on 2009-09-09
Reviewed by Darin Adler.
These platforms include Microsoft Visual Studio 2003, and Symbian with Metrowerks compiler.
- JavaScriptCore.gypi:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/JSTypeInfo.h: Copied from JavaScriptCore/runtime/TypeInfo.h.
- runtime/Structure.h:
- runtime/TypeInfo.h: Removed.
- 7:49 AM Changeset in webkit [48206] by
-
- 2 edits in trunk/WebKitTools
<http://webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIElement::clickPointY()
Reviewed by Mark Rowe.
No change to layout test results.
- DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::clickPointY): Changed to return y value instead of x value.
- 6:26 AM Changeset in webkit [48205] by
-
- 2 edits in trunk
[Qt] locale date displays incorrect date format in symbian.
https://bugs.webkit.org/show_bug.cgi?id=29032
Patch by Pat Bradley <vincent.bradley@nokia.com> on 2009-09-08
Reviewed by Ariya Hidayat.
strftime() in Symbian does not support #
Layout tests cannot be run on Symbian yet, so they are not updated.
- runtime/DatePrototype.cpp:
- 2:53 AM Changeset in webkit [48204] by
-
- 2 edits in trunk/WebCore
NPAPI Plugin NPP_AsFile not working on Qt Webkit
https://bugs.webkit.org/show_bug.cgi?id=29068
Patch by Rohini Ananth <rohini.ananth@nokia.com> on 2009-09-09
Reviewed by Simon Hausmann.
- platform/qt/FileSystemQt.cpp:
(WebCore::openTemporaryFile)
Autoremove property of QTemporaryFile has been set to false. Hence closeFile() just closes and does not delete the file.
This solves the deletion of created temp file in PluginStream::destroyStream() before passing to plugin in NPP_AsFile.
- 12:13 AM Changeset in webkit [48203] by
-
- 2 edits in trunk/WebKitLibraries
Adjust WinCairo-specific property sheet to use static versions of
libjpeg.lib and libpng.lib. Change to libpng.lib required addition
of zlib.lib to link.
Reviewed by Dave Levin.
- win/tools/vsprops/WinCairo.vsprops:
- 12:02 AM Changeset in webkit [48202] by
-
- 5 edits in trunk
JSON.stringify(Date) loses the milliseconds information
https://bugs.webkit.org/show_bug.cgi?id=29063
Reviewed by Maciej Stachowiak.
Make sure we include milliseconds in the output of toISOString.
Sep 8, 2009:
- 10:55 PM Changeset in webkit [48201] by
-
- 2 edits in trunk/WebCore
Reviewed by NOBODY (Build fix).
Remove a few incorrect changes I left in.
- 9:32 PM Changeset in webkit [48200] by
-
- 24 edits in trunk/WebCore
Support numeric index getters in bindings
https://bugs.webkit.org/show_bug.cgi?id=29067
Reviewed by Sam Weinig.
Add HasNumericIndexGetter to indicate a non-custom getter that
returns a number. The numeric index getter also uses PropertySlot's
setValue rather than setCustomIndex to avoid an additional indirect
call.
- 8:03 PM Changeset in webkit [48199] by
-
- 2 edits in trunk/WebKitTools
2009-09-08 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Mark Rowe.
Reduce dglazkov's boboiness by properly concatenating revision value.
- BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution
rather than "+".
- 7:25 PM Changeset in webkit [48198] by
-
- 2 edits in trunk/WebKitTools
wxWebKit Python extension build fix - get swig.py if it doesn't exist.
- 7:20 PM Changeset in webkit [48197] by
-
- 2 edits in trunk/WebCore
wx build fix for 2.8.
- 6:45 PM Changeset in webkit [48196] by
-
- 2 edits in trunk/LayoutTests
shared-worker-exception.html needs to pause to let console messages get written out
https://bugs.webkit.org/show_bug.cgi?id=29043
Reviewed by Maciej Stachowiak.
- fast/workers/resources/shared-worker-exception.js:
(worker.onmessage):
Now invokes layoutTestController.notifyDone() via a timer so any pending ReportException tasks get a chance to fire.
- 5:29 PM Changeset in webkit [48195] by
-
- 2 edits in trunk/WebCore
2009-09-08 Jens Alfke <snej@chromium.org>
Reviewed by Eric Seidel.
In Mac Chromium, clicking below the last line of an editable area (textarea or
contenteditable) should put the caret at the end of the last line, as in Mac Safari.
Tests: LayoutTests/editing/selection/click-in-margins-inside-editable-div.html
LayoutTests/editing/selection/click-in-padding-with-multiple-line-boxes.html
- page/Settings.cpp: (WebCore::Settings::Settings): Change #if PLATFORM_MAC to be Mac-Chrome-inclusive.
- 5:01 PM Changeset in webkit [48194] by
-
- 2 edits in trunk/WebKitTools
Fix an incorrect variable name in UpdateChromiumSource.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 3:51 PM Changeset in webkit [48193] by
-
- 2 edits in trunk/WebKitTools
Don't check for leaks on the release SnowLeopard builder.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 3:39 PM Changeset in webkit [48192] by
-
- 2 edits in trunk/WebKitTools
Add a SnowLeopard release builder.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 3:17 PM Changeset in webkit [48191] by
-
- 2 edits in trunk/WebCore
Make sure not to do an early return when a data URL stylesheet successfully loads. We need to still
clear the old cached sheet out of all existing Frames. Fixes the data URL stylesheet layout test failure.
Reviewed by Mark Rowe.
- page/Page.cpp:
(WebCore::Page::userStyleSheetLocationChanged):
- 3:14 PM Changeset in webkit [48190] by
-
- 2 edits in trunk/WebCore
Fix windows build.
- dom/Document.idl:
- 3:11 PM Changeset in webkit [48189] by
-
- 2 edits in trunk/WebCore
More robust wx build fix for 2.9.
- 3:02 PM Changeset in webkit [48188] by
-
- 6 edits5 adds in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=27046
Implement CSSOM DocumentView.caretRangeFromPoint
Reviewed by Timothy Hatcher.
Tests: fast/dom/Document/CaretRangeFromPoint/basic.html
fast/dom/Document/CaretRangeFromPoint/replace-element.html
- dom/Document.cpp:
(WebCore::Document::caretRangeFromPoint):
- dom/Document.h:
- dom/Document.idl:
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=27046
Implement CSSOM DocumentView.caretRangeFromPoint
Reviewed by Timothy Hatcher.
- fast/dom/Document/CaretRangeFromPoint: Added.
- fast/dom/Document/CaretRangeFromPoint/basic-expected.txt: Added.
- fast/dom/Document/CaretRangeFromPoint/basic.html: Added.
- fast/dom/Document/CaretRangeFromPoint/replace-element-expected.txt: Added.
- fast/dom/Document/CaretRangeFromPoint/replace-element.html: Added.
- fast/dom/Window/window-properties-expected.txt:
- 2:46 PM Changeset in webkit [48187] by
-
- 2 edits in trunk/WebKitTools
Remove end of line whitespace check from check-webkit-style.
https://bugs.webkit.org/show_bug.cgi?id=29053
Patch by David Levin <levin@chromium.org> on 2009-09-08
Reviewed by Darin Adler.
- Scripts/modules/cpp_style.py:
- 2:32 PM Changeset in webkit [48186] by
-
- 4 edits in trunk
wx build fix, generate derived sources earlier in order to make sure
they're found by the build system when generating the list of sources to build.
- 2:11 PM Changeset in webkit [48185] by
-
- 2 edits in trunk/WebCore
2009-09-08 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
<iterator> include in V8Proxy.h is spurious and causing ObjC compile issues for Chromium.
Test: Chromium mac canary build is fixed.
- 2:05 PM Changeset in webkit [48184] by
-
- 3 edits in trunk/LayoutTests
2009-09-08 Brian Weinstein <bweinstein@apple.com>
Rubber-stamped by Adam Roben.
Updated results for media/audio-controls-rendering.html, and added 3 failing
tests to the Skipped list to investigate further <http://webkit.org/b/29047>.
- platform/win/Skipped:
- platform/win/media/audio-controls-rendering-expected.txt:
- 2:01 PM Changeset in webkit [48183] by
-
- 3 edits in trunk/WebKit/gtk
2009-09-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=29044
[GTK] Should update suggested-filename when the response is received
Set suggested filename also when the response only comes after the
download has started.
- webkit/webkitdownload.cpp: (webkit_download_set_response): (webkit_download_set_suggested_filename):
- webkit/webkitwebview.cpp: (webkit_web_view_request_download):
- 1:34 PM Changeset in webkit [48182] by
-
- 2 edits in trunk/WebCore
2009-09-08 Xan Lopez <xlopez@igalia.com>
Unreviewed attempt to fix the GTK+ build.
- GNUmakefile.am:
- 1:26 PM Changeset in webkit [48181] by
-
- 9 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=28987, make the Document cache the page's user stylesheet in
parsed form. Allows the sheet to survive across destruction/re-creation of the CSSStyleSelector.
Reviewed by Eric Seidel.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
- css/CSSStyleSelector.h:
- dom/Document.cpp:
(WebCore::Document::attach):
(WebCore::Document::pageUserSheet):
(WebCore::Document::clearPageUserSheet):
(WebCore::Document::recalcStyleSelector):
- dom/Document.h:
- loader/PlaceholderDocument.cpp:
(WebCore::PlaceholderDocument::attach):
- page/Page.cpp:
(WebCore::Page::userStyleSheetLocationChanged):
- page/Settings.cpp:
(WebCore::Settings::setUserStyleSheetLocation):
- 1:23 PM Changeset in webkit [48180] by
-
- 2 edits in trunk/WebCore
Unreviewed buildfix.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
Fix Qt build after 48167, by adding the new cpp/h files
added to WebCore.gypi to WebCore.pro as well.
- WebCore.pro:
- 1:11 PM Changeset in webkit [48179] by
-
- 2 edits in trunk/WebKit/qt
Unreviewed build fix.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
Potential build fix for Qt 4.5
- Api/qwebpage.cpp:
(QWebPagePrivate::mousePressEvent):
- 1:06 PM Changeset in webkit [48178] by
-
- 2 edits in trunk/WebCore
2009-09-08 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
should not pass URI fragments to libsoup
https://bugs.webkit.org/show_bug.cgi?id=28687
Strip the fragment from the URI before passing it to soup, since
it forwards it to servers in some cases (like when using a proxy)
which confuses them and makes them return 403/404.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp): (WebCore::):
- 12:40 PM Changeset in webkit [48177] by
-
- 8 edits in trunk
WebCore: Add QGraphicsScene events support to the Qt platform events.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
Reviewed by Simon Hausmann.
- platform/PlatformMouseEvent.h:
- platform/PlatformWheelEvent.h:
- platform/qt/PlatformMouseEventQt.cpp:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
- platform/qt/WheelEventQt.cpp:
(WebCore::PlatformWheelEvent::applyDelta):
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
WebKit/qt: Add support for handling QGraphicsScene events.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
Reviewed by Simon Hausmann.
- Api/qwebpage.cpp:
(QWebPagePrivate::mouseMoveEvent):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseDoubleClickEvent):
(QWebPagePrivate::mouseTripleClickEvent):
(QWebPagePrivate::handleClipboard):
(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::wheelEvent):
(QWebPagePrivate::dragEnterEvent):
(QWebPagePrivate::dragLeaveEvent):
(QWebPagePrivate::dragMoveEvent):
(QWebPagePrivate::dropEvent):
(QWebPage::event):
- Api/qwebpage_p.h:
- 12:40 PM Changeset in webkit [48176] by
-
- 2 edits in trunk/WebKitSite
Update Security Group Members list.
Reviewed by Adele Peterson.
- security/security-group-members.html:
- 12:28 PM Changeset in webkit [48175] by
-
- 3 edits in trunk/WebCore
2009-09-08 Michael Nordman <Michael Nordman>
Reviewed by Eric Seidel.
[Chromium] Cleanup: remove a few deprecated methods.
https://bugs.webkit.org/show_bug.cgi?id=28960
No new tests, just syntactic sugar.
- platform/network/chromium/ResourceRequest.h:
- platform/network/chromium/ResourceResponse.h:
- 12:21 PM Changeset in webkit [48174] by
-
- 2 edits in trunk/WebCore
2009-09-08 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] make npapi.h compile in winscw compiler.
Add XP_SYMBIAN macro to identify Symbian OS; this macro should be used for Symbian
specific changes in npapi.h.
Undefine XP_WIN when building for Symbian to avoid including Windows specific code.
- bridge/npapi.h:
- 12:06 PM Changeset in webkit [48173] by
-
- 6 edits in trunk/WebKit/gtk
2009-09-08 Priit Laes <plaes@plaes.org>
Reviewed by Gustavo Noronha.
Fix up erroneus 'Since: @version@' tags in documentation.
- webkit/webkitwebdatasource.cpp:
- webkit/webkitwebresource.cpp: (webkit_web_resource_class_init):
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
- webkit/webkitwebview.cpp: (webkit_web_view_class_init):
- webkit/webkitwebwindowfeatures.cpp:
- 12:02 PM Changeset in webkit [48172] by
-
- 2 edits in trunk/WebCore
Web Inspector assertion failure related to marking
https://bugs.webkit.org/show_bug.cgi?id=28997
Reviewed by Geoff Garen.
When wrapping the callback the JSInspectorCallbackWrapper creator was using
inheritorID for the prototype structure which is unsafe for anything other
than a pure JS object. Instead we now create a new structure, which while
inefficient is not problematic as this code is not hit frequently.
- 11:34 AM Changeset in webkit [48171] by
-
- 2 edits in trunk/WebCore
2009-09-08 Kelly Norton <knorton@google.com>
Reviewed by Dimitri Glazkov.
Add missing extension to the file entry in WebCore.vcproj.
- WebCore.vcproj/WebCore.vcproj: Added "cpp".
- 11:02 AM Changeset in webkit [48170] by
-
- 2 edits in trunk/WebKitTools
2009-09-08 Cameron McCormack <cam@mcc.id.au>
Reviewed by Darin Adler.
Fix DumpRenderTree build from clean tree on Tiger
https://bugs.webkit.org/show_bug.cgi?id=28927
- DumpRenderTree/mac/PerlSupport/Makefile: Ensure the DerivedSources/DumpRenderTree directory exists when building on Tiger.
- 11:02 AM Changeset in webkit [48169] by
-
- 5 edits in trunk
WebCore: dataTransfer.types() should not return Files if file list is empty in the clipboard.
https://bugs.webkit.org/show_bug.cgi?id=28891
Reviewed by David Levin.
We change the behavior to handle the empty file list in order to match the spec.
Tested by clipboard-file-access.html.
- platform/mac/ClipboardMac.mm:
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):
LayoutTests: dataTransfer.types() should not return Files if file list is empty in the clipboard.
https://bugs.webkit.org/show_bug.cgi?id=28891
Reviewed by David Levin.
Update the test script and expected result to reflect the behavior change.
- http/tests/security/clipboard/clipboard-file-access-expected.txt:
- http/tests/security/clipboard/resources/clipboard-file-access.js:
- 10:58 AM Changeset in webkit [48168] by
-
- 7 edits3 adds in trunk
2009-09-08 Steve VanDeBogart <vandebo@chromium.org>
Reviewed by Eric Seidel.
Handle middle click in Chromium like QT
https://bugs.webkit.org/show_bug.cgi?id=28696
Tested by middle-click-onpaste.html.
- 10:55 AM Changeset in webkit [48167] by
-
- 20 edits7 adds in trunk/WebCore
2009-09-08 Kelly Norton <knorton@google.com>
Reviewed by Eric Seidel.
WebInspector: Adds a timeline agent to InspectorController that collects
high-level timing data about event dispatch, layout, painting and HTML
parsing and makes it available to Inspector.
https://bugs.webkit.org/show_bug.cgi?id=25503
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp: (WebCore::Document::recalcStyle):
- dom/Document.h: (WebCore::Document::inspectorTimelineAgent):
- dom/Node.cpp: (WebCore::Node::dispatchGenericEvent):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
- inspector/DOMDispatchTimelineItem.cpp: Added. (WebCore::DOMDispatchTimelineItem::DOMDispatchTimelineItem): (WebCore::DOMDispatchTimelineItem::convertToScriptObject):
- inspector/DOMDispatchTimelineItem.h: Added. (WebCore::DOMDispatchTimelineItem::~DOMDispatchTimelineItem):
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::enableTimeline): (WebCore::InspectorBackend::disableTimeline): (WebCore::InspectorBackend::timelineEnabled):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::enableTimeline): (WebCore::InspectorController::disableTimeline): (WebCore::InspectorController::timelineEnabled):
- inspector/InspectorController.h: (WebCore::InspectorController::timelineAgent):
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::timelineWasEnabled): (WebCore::InspectorFrontend::timelineWasDisabled): (WebCore::InspectorFrontend::addItemToTimeline):
- inspector/InspectorFrontend.h:
- inspector/InspectorTimelineAgent.cpp: Added. (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::willDispatchDOMEvent): (WebCore::InspectorTimelineAgent::didDispatchDOMEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::reset): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::currentTimeInMilliseconds): (WebCore::InspectorTimelineAgent::sessionTimeInMilliseconds):
- inspector/InspectorTimelineAgent.h: Added.
- inspector/TimelineItem.cpp: Added. (WebCore::TimelineItem::TimelineItem): (WebCore::TimelineItem::addToTimeline): (WebCore::TimelineItem::convertToScriptObject): (WebCore::TimelineItem::convertChildrenToScriptArray): (WebCore::TimelineItem::addChildItem):
- inspector/TimelineItem.h: Added. (WebCore::): (WebCore::TimelineItem::~TimelineItem): (WebCore::TimelineItem::previous): (WebCore::TimelineItem::releasePrevious): (WebCore::TimelineItem::setEndTime): (WebCore::TimelineItem::type):
- inspector/front-end/TimelineAgent.js: Added. (WebInspector.TimelineAgent): (WebInspector.addItemToTimeline): (WebInspector.timelineWasEnabled): (WebInspector.timelineWasDisabled):
- inspector/front-end/inspector.html:
- page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::paintContents):
- page/FrameView.h: (WebCore::FrameView::inspectorTimelineAgent):
- page/Page.cpp: (WebCore::Page::inspectorTimelineAgent):
- page/Page.h:
- 10:44 AM Changeset in webkit [48166] by
-
- 2 edits in trunk/WebKit/qt
2009-09-08 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=29007
Add a test for the signal QWebFrame::javaScriptWindowObjectCleared()
- tests/qwebframe/tst_qwebframe.cpp:
- 10:37 AM Changeset in webkit [48165] by
-
- 7 edits in trunk
2009-09-08 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
[Qt] Fix unused variable warnings
https://bugs.webkit.org/show_bug.cgi?id=29018
No functional change, no tests.
- history/qt/HistoryItemQt.cpp: (WebCore::HistoryItem::restoreState):
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::putImageData):
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintMenuList):
2009-09-08 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
[Qt] Fix unused variable warnings
https://bugs.webkit.org/show_bug.cgi?id=29018
- Api/qwebpage.cpp: (QWebPagePrivate::keyPressEvent):
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::startDownload): (WebCore::FrameLoaderClientQt::createFrame):
- 10:30 AM Changeset in webkit [48164] by
-
- 5 edits in trunk
2009-09-08 Laszlo Gombos <Laszlo Gombos>
Reviewed by Ariya Hidayat.
[Qt] Use the declaration order in initializer lists
https://bugs.webkit.org/show_bug.cgi?id=29017
No functional change, no new tests.
- platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
2009-09-08 Laszlo Gombos <Laszlo Gombos>
Reviewed by Ariya Hidayat.
[Qt] Use the declaration order in initializer lists
https://bugs.webkit.org/show_bug.cgi?id=29017
- Api/qwebframe_p.h:
- 10:23 AM Changeset in webkit [48163] by
-
- 5 edits3 adds in trunk
2009-09-08 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Tests for ValidityState::typeMismatch() for <input type=number>.
https://bugs.webkit.org/show_bug.cgi?id=28934
- fast/forms/ValidityState-typeMismatch-number-expected.txt: Added.
- fast/forms/ValidityState-typeMismatch-number.html: Added.
- fast/forms/resources/ValidityState-typeMismatch-number.js: Added.
2009-09-08 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Implement ValidityState::typeMismatch() for <input type=number>.
https://bugs.webkit.org/show_bug.cgi?id=28934
Test: fast/forms/ValidityState-typeMismatch-number.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::formStringToDouble):
- html/HTMLInputElement.h:
- html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch):
- html/ValidityState.h:
- 10:19 AM Changeset in webkit [48162] by
-
- 2 edits in trunk/WebKitTools
wx build fix after introduction of platform/mock directory.
- 10:15 AM Changeset in webkit [48161] by
-
- 2 edits in trunk/JavaScriptCore
2009-09-08 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
Build fix when USE(LOCKFREE_THREADSAFESHARED) is not defined
https://bugs.webkit.org/show_bug.cgi?id=29011
- wtf/Threading.h: Use LOCKFREE_THREADSAFESHARED guard for atomicIncrement and atomicDecrement
- 9:39 AM Changeset in webkit [48160] by
-
- 2 edits in trunk/WebKitTools
Unreviewed.
Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-09-08
Add myself to list of committers.
- Scripts/modules/committers.py:
- 9:08 AM Changeset in webkit [48159] by
-
- 2 edits in trunk/WebKitTools
2009-09-08 Laszlo Gombos <Laszlo Gombos>
Unreviewed.
Add myself to list of committers.
- Scripts/modules/committers.py:
- 8:51 AM Changeset in webkit [48158] by
-
- 2 edits in trunk/WebKitTools
2009-09-08 Cameron McCormack <cam@mcc.id.au>
Reviewed by Darin Adler.
prepare-ChangeLog too chatty on file additions
https://bugs.webkit.org/show_bug.cgi?id=29019
- Scripts/prepare-ChangeLog: Omit description of added properties on newly added files.
- 8:49 AM Changeset in webkit [48157] by
-
- 2 edits in trunk/WebCore
2009-09-08 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Gustavo Noronha.
[Gtk] Another attempt of a buildfix.
- GNUmakefile.am: Modified. Remove some extra IDL files added in r48153.
- 8:43 AM Changeset in webkit [48156] by
-
- 6 edits6 adds in trunk
2009-09-08 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Adds a LayoutTestController method to set the permission state for Geolocation.
This is required to use the mock Geolocation service for testing.
https://bugs.webkit.org/show_bug.cgi?id=29027
- fast/dom/Geolocation/resources/permission-denied.js: Added. Tests that the error callback is invoked with a permission error code when Geolocation permission is denied and the Geolocation service provides a good position fix.
- fast/dom/Geolocation/permission-denied-expected.txt: Added. Expected result for above test.
- fast/dom/Geolocation/permission-denied.html: Added. Wrapper for above test.
- fast/dom/Geolocation/resources/success.js: Added. Tests that the success callback is invoked when the Geolocation service provides a good position fix.
- fast/dom/Geolocation/success-expected.txt: Added. Expected result for above test.
- fast/dom/Geolocation/success.html: Added. Wrapper for above test.
- platform/gtk/Skipped:
2009-09-08 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Adds a LayoutTestController method to set the permission state for Geolocation.
This is required to use the mock Geolocation service for testing.
https://bugs.webkit.org/show_bug.cgi?id=29027
- DumpRenderTree/LayoutTestController.cpp: Modified. (setDatabaseQuotaCallback): Modified. Style fix. (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state. (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController.
- DumpRenderTree/LayoutTestController.h: Modified. (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state. (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set. (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state.
- DumpRenderTree/mac/UIDelegate.mm: Modified. (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state.
- 8:17 AM WebKit Team edited by
- (diff)
- 8:00 AM Changeset in webkit [48155] by
-
- 2 edits in trunk/JavaScriptCore
2009-09-07 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Allow custom memory allocation control in Yarr's RegexInterpreter
https://bugs.webkit.org/show_bug.cgi?id=29025
Inherits RegexInterpreter classes from FastAllocBase (bug #20422), which has
been instantiated by 'new':
class ByteDisjunction
-> instantiated in JavaScriptCore/yarr/RegexInterpreter.cpp:1462
struct BytecodePattern
-> instantiated in JavaScriptCore/yarr/RegexInterpreter.cpp:1279
- yarr/RegexInterpreter.h:
- 7:58 AM WebKit Team edited by
- (diff)
- 7:43 AM Changeset in webkit [48154] by
-
- 6 edits in trunk
WebCore: [Qt] Make cursor set cleaner in QtWebKit Api: eliminate SetCursorEvent hack.
https://bugs.webkit.org/show_bug.cgi?id=28865
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
Reviewed by Simon Hausmann.
Save the QCursor as a property in WidgetQt::setCursor
and actually change the cursor in QWebView::event() by making use
of the QEvent::DynamicPropertyChange event type.
When unsetCursor() is called on the QWidget we can fallback to
the cursor set by WebCore.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> and
Antonio Gomes <antonio.gomes@openbossa.org> on 2009-09-07
- platform/qt/WidgetQt.cpp:
(WebCore::Widget::setCursor):
WebKit/qt: [Qt] Make cursor set cleaner in QtWebKit Api: eliminate SetCursorEvent hack.
https://bugs.webkit.org/show_bug.cgi?id=28865
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-08
Reviewed by Simon Hausmann.
Clean up the unserCursor hack to use the QCursor set
as a property of the QWidget by WebCore::WidgetQt.
Remove all code that are no longer necessary for getting
cursor change events.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> and
Antonio Gomes <antonio.gomes@openbossa.org> on 2009-09-07
- Api/qwebpage.cpp:
- Api/qwebpage_p.h:
- Api/qwebview.cpp:
(QWebViewPrivate::QWebViewPrivate):
(QWebView::event):
- 7:34 AM Changeset in webkit [48153] by
-
- 2 edits in trunk/WebCore
2009-09-08 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Gustavo Noronha.
[Gtk] Buildfix for build error introduced in r48150.
- GNUmakefile.am: Modified. Added missing IDL files.
- 7:05 AM Changeset in webkit [48152] by
-
- 2 edits in trunk/WebCore
[Qt] Buildfix. Build error caused by r48150.
Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-08
Reviewed by Tor Arne Vestbø.
- WebCore.pro: missing IDL files added
- 6:44 AM QtWebKitContrib edited by
- (diff)
- 6:31 AM QtWebKitContrib edited by
- (diff)
- 6:27 AM Changeset in webkit [48151] by
-
- 8 edits in trunk
2009-09-08 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
[Qt] QtWebKit single API to enable persistency
https://bugs.webkit.org/show_bug.cgi?id=28682
Disable LocalStorage, ApplicationCache, HTML5 offline storage by
default.
If persistency is enabled the default directory for LocalStorage and
ApplicationCache is now based on QDesktopServices::DataLocation and not
QDesktopServices::CacheLocation (as it is expected to keep this data
around after a reboot).
If persistency is enabled initialize HTML5 offline storage as well - this
fixed offline Storage for QtLauncher.
- 6:01 AM Changeset in webkit [48150] by
-
- 17 edits48 adds in trunk/WebCore
Update Canvas 3D implementation to match spec
https://bugs.webkit.org/show_bug.cgi?id=29010
This adds several new CanvasXXXArray classes each of which has a custom constructor
and custom getters and setters. Also changed CanvasRenderingContext3D and GraphicsContext3D
to match the new and changed API.
- 5:35 AM Changeset in webkit [48149] by
-
- 1 edit2 adds in trunk/LayoutTests
[Qt] Add expected files for new tests since we pass them.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-09-08
Reviewed by Tor Arne Vestbø.
- platform/qt/fast/reflections/abs-position-in-reflection-expected.txt: Added.
- platform/qt/fast/repaint/rel-positioned-inline-with-overflow-expected.txt: Added.
- 5:27 AM Changeset in webkit [48148] by
-
- 2 edits in trunk/WebKitTools
Refactor --strict switch to --ignore-metrics and correct the
implementation to make the feature usable on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=28907
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-09-07
Reviewed by Tor Arne Vestbø.
run-webkit-tests --ignore-metrics strips the font related metrics from
the actual and expected data before comparing them.
In this way the render trees can be checked for obvious differences but
a successful test implies by no means that the layout is actually correct.
- Scripts/run-webkit-tests:
- 2:51 AM Changeset in webkit [48147] by
-
- 1 edit in trunk/WebKitTools/Scripts/modules/committers.py
Unreviewed.
Change my mail address on the list of committers.
- 12:45 AM Changeset in webkit [48146] by
-
- 2 edits in trunk/WebCore
Make m_windowVisible more consistent with the actual visibility of the inspector.
Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-08
Reviewed by Timothy Hatcher.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::setWindowVisible):
Sep 7, 2009:
- 11:22 PM Changeset in webkit [48145] by
-
- 2 edits in trunk/WebCore
2009-09-07 Adam Barth <abarth@webkit.org>
Unreviewed speculative build fix for Snow Leopard.
- platform/GeolocationService.cpp: (WebCore::createGeolocationServiceNull):
- 11:13 PM Changeset in webkit [48144] by
-
- 30 edits2 copies6 adds in trunk
2009-09-07 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Adds a mock Geolocation service. This will be used to provide predictable behavior of the
Geolocation API for use in LayoutTests. Later changes will integrate the the mock
Geolocation service with DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=28264
- fast/dom/Geolocation/resources/error.js: Added. Tests that the error callback is called when the service reports an error.
- fast/dom/Geolocation/error-expected.txt: Added. Expected result for above test.
- fast/dom/Geolocation/error.html: Added. Wrapper for above test.
2009-09-07 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Adds a mock Geolocation service. This will be used to provide predictable behavior of the
Geolocation API for use in LayoutTests. Later changes will integrate the the mock
Geolocation service with DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=28264
The mock Geolocation service returns a fixed position or error. This position or error can be
set through static methods on the GeolocationService class. The position or error is shared
between all instances of the mock Geolocation service.
Implementation details.
The GeolocationService object maintains a pointer to a factory function which it uses to create
Geolocation service instances. Each platform implementing Geolocation sets this pointer
to the factory function for their platform's implementation. When the mock Geolocation service
is activated, the factory function pointer is reset to the factory function for the mock service.
Test: fast/dom/Geolocation/error.html
- WebCore.base.exp: Modified. Exports GeolocationServiceMock methods.
- GNUMakefile.am: Modified. Added GeolocationServiceMock files.
- WebCore.gypi: Modified. Added GeolocationServiceMock files.
- WebCore.pro: Modified. Added GeolocationServiceMock files.
- WebCore.vcproj/WebCore.vcproj: Modified. Added GeolocationServiceMock files.
- WebCore.vcproj/WebCoreCommon.vsprops: Modified. Added mock directory to includes.
- WebCore.xcodeproj/project.pbxproj: Modified. Added GeolocationServiceMock files and exports some headers.
- WebCoreSources.bkl: Modified. Added GeolocationServiceMock files.
- page/ChromeClient.h: Modified. Fixed comment.
- page/Geolocation.cpp: Modified. (WebCore::Geolocation::setIsAllowed): Modified. Fixed error string.
- platform/GeolocationService.cpp: Modified. (WebCore::createGeolocationServiceNull): Added. Returns null in place of a Geolocation service. Used to avoid link errors on platforms where Geolocation is not implemented. (WebCore::GeolocationService::create): Added. Uses the factory function pointer to create a Geolocation service implementation. (WebCore::GeolocationService::useMock): Added. Configures the GeolocationServie to use the mock implementation.
- platform/GeolocationService.h: Modified.
- platform/mock: Added.
- platform/mock/GeolocationServiceMock.cpp: Added. (WebCore::GeolocationServiceMock::create): Added. Creates a GeolocationServiceMock object. (WebCore::GeolocationServiceMock::GeolocationServiceMock): Added. Constructor. (WebCore::GeolocationServiceMock::~GeolocationServiceMock): Added. Destructor. (WebCore::GeolocationServiceMock::setPosition): Added. Sets the position that will be returned by the object. (WebCore::GeolocationServiceMock::setError): Added. Sets the error that will be returned by the object. (WebCore::GeolocationServiceMock::startUpdating): Added. GeolocationService implementation. Starts the service. (WebCore::GeolocationServiceMock::stopUpdating): Added. GeolocationService implementation. Stops the service. (WebCore::GeolocationServiceMock::timerFired): Added. Used to provide an asynchronous callback when the service is started. (WebCore::GeolocationServiceMock::makeGeolocationCallbackFromAllInstances): Added. Used to call back when the position or error is updated. (WebCore::GeolocationServiceMock::makeGeolocationCallback): Added. Used to call back when the service starts. (WebCore::GeolocationServiceMock::initStatics): Added. Initializes statics members with constructors. (WebCore::GeolocationServiceMock::cleanUpStatics): Added. Cleans up static members with constructors.
- platform/mock/GeolocationServiceMock.h: Added. (WebCore::GeolocationServiceMock::lastPosition): Added. Returns the fixed position. (WebCore::GeolocationServiceMock::lastError): Added. Returns the fixed error.
- platform/gtk/GeolocationServiceGtk.cpp: Modified. (WebCore::GeolocationServiceGtk::create): Added. Creates an instance of GeolocationServiceGtk.
- platform/gtk/GeolocationServiceGtk.h: Modified.
- platform/mac/GeolocationServiceMac.h: Modified.
- platform/mac/GeolocationServiceMac.mm: Modified. (WebCore::GeolocationServiceMac::create): Added. Creates an instance of GeolocationServiceMac.
2009-09-07 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Adds a mock Geolocation service. This will be used to provide predictable behavior of the
Geolocation API for use in LayoutTests. Later changes will integrate the the mock
Geolocation service with DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=28264
- WebKit.xcodeproj/project.pbxproj: Modified. Adds WebGeolocationMock.
2009-09-07 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Adds a mock Geolocation service. This will be used to provide predictable behavior of the
Geolocation API for use in LayoutTests. Later changes will integrate the the mock
Geolocation service with DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=28264
- WebCoreSupport/WebGeolocationMockPrivate.h: Added.
- WebCoreSupport/WebGeolocationMock.mm: Added. (+[WebGeolocationMock setError:code:]): Added. Used by DumpRender tree to configure the mock Geolocation service. (+[WebGeolocationMock setPosition:latitude:longitude:accuracy:]): Added. Used by DumpRender tree to configure the mock Geolocation service.
- WebKit.exp: Modified. Exports WebGeolocationMock.
2009-09-07 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Adds a mock Geolocation service. This will be used to provide predictable behavior of the
Geolocation API for use in LayoutTests. Later changes will integrate the the mock
Geolocation service with DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=28264
- DumpRenderTree/LayoutTestController.cpp: Modified. (setMockGeolocationPositionCallback): Added. Configures the mock Geolocation service. (setMockGeolocationErrorCallback): Added. Configures the mock Geolocation service. (LayoutTestController::staticFunctions): Added. Registers the above functions on the LayoutTestController.
- DumpRenderTree/LayoutTestController.h: Modified.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: Modified. (LayoutTestController::setMockGeolocationPosition): Added. Configures the mock Geolocation service. (LayoutTestController::setMockGeolocationError): Added. Configures the mock Geolocation service.
- 10:19 PM Changeset in webkit [48143] by
-
- 6 edits2 adds in trunk/LayoutTests
2009-09-07 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Eric Seidel.
Clean up localStorage.clear() layout test.
https://bugs.webkit.org/show_bug.cgi?id=28939
This is the first step of https://bugs.webkit.org/show_bug.cgi?id=27897 which
is a pretty major cleanup of all the dom storage layout tests. I'm just
changing this one to begin with to get buy-in on the approach.
This also adds a new method to the fast/js/js-test-pre.js that runs a command
and prints it to the screen. This should really help with making the output of
the tests readable without looking at the source code.
- fast/js/resources/js-test-pre.js: (tryAndLog): Runs a command and logs it to the screen.
- storage/domstorage/localstorage/clear-expected.txt:
- storage/domstorage/localstorage/clear.html:
- storage/domstorage/resources: Added.
- storage/domstorage/resources/clear.js: Added.
The meat of the test is now in this file.
- storage/domstorage/sessionstorage/clear-expected.txt:
- storage/domstorage/sessionstorage/clear.html:
- 6:25 PM Changeset in webkit [48142] by
-
- 2 edits in trunk/WebCore
2009-09-07 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
We need to be slightly more careful about how we pick up a script
execution context. In particular, we were getting the wrong document
for frames that had been navigated somewhere else.
In the long term, we should think about a better algorithm for
computing the script context.
Fixes LayoutTests/http/tests/xmlhttprequest/detaching-frame-2.html
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::retrieveFrame):
- 5:32 PM Changeset in webkit [48141] by
-
- 4 edits in trunk/LayoutTests
Rubber-stamped by Sam Weinig.
Rebaseline tests for GTK platform, and skipping shared worker XHR tests (worker XHR tests are already skipped).
Tracked as https://bugs.webkit.org/show_bug.cgi?id=29020.
- platform/gtk/Skipped:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
- 5:08 PM Changeset in webkit [48140] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test fixup.
Added shared worker lifecycle tests to Skipped test list due to missing DRT functionality on Qt platform.
- platform/qt/Skipped:
- 4:55 PM Changeset in webkit [48139] by
-
- 1 edit21 moves in trunk/LayoutTests
Enable shared worker tests.
https://bugs.webkit.org/show_bug.cgi?id=28977
Reviewed by David Levin.
Just moved tests from shared-worker-xxxx.html-disabled to shared-worker-xxxx.html. No other changes.
- fast/workers/shared-worker-constructor.html: Renamed from LayoutTests/fast/workers/shared-worker-constructor.html-disabled.
- fast/workers/shared-worker-context-gc.html: Renamed from LayoutTests/fast/workers/shared-worker-context-gc.html-disabled.
- fast/workers/shared-worker-event-listener.html: Renamed from LayoutTests/fast/workers/shared-worker-event-listener.html-disabled.
- fast/workers/shared-worker-exception.html: Renamed from LayoutTests/fast/workers/shared-worker-exception.html-disabled.
- fast/workers/shared-worker-frame-lifecycle.html: Renamed from LayoutTests/fast/workers/shared-worker-frame-lifecycle.html-disabled.
- fast/workers/shared-worker-gc.html: Renamed from LayoutTests/fast/workers/shared-worker-gc.html-disabled.
- fast/workers/shared-worker-lifecycle.html: Renamed from LayoutTests/fast/workers/shared-worker-lifecycle.html-disabled.
- fast/workers/shared-worker-load-error.html: Renamed from LayoutTests/fast/workers/shared-worker-load-error.html-disabled.
- fast/workers/shared-worker-location.html: Renamed from LayoutTests/fast/workers/shared-worker-location.html-disabled.
- fast/workers/shared-worker-navigator.html: Renamed from LayoutTests/fast/workers/shared-worker-navigator.html-disabled.
- fast/workers/shared-worker-replace-global-constructor.html: Renamed from LayoutTests/fast/workers/shared-worker-replace-global-constructor.html-disabled.
- fast/workers/shared-worker-replace-self.html: Renamed from LayoutTests/fast/workers/shared-worker-replace-self.html-disabled.
- fast/workers/shared-worker-script-error.html: Renamed from LayoutTests/fast/workers/shared-worker-script-error.html-disabled.
- fast/workers/shared-worker-shared.html: Renamed from LayoutTests/fast/workers/shared-worker-shared.html-disabled.
- fast/workers/shared-worker-simple.html: Renamed from LayoutTests/fast/workers/shared-worker-simple.html-disabled.
- http/tests/workers/shared-worker-importScripts.html: Renamed from LayoutTests/http/tests/workers/shared-worker-importScripts.html-disabled.
- http/tests/workers/shared-worker-redirect.html: Renamed from LayoutTests/http/tests/workers/shared-worker-redirect.html-disabled.
- http/tests/xmlhttprequest/workers/shared-worker-close.html: Renamed from LayoutTests/http/tests/xmlhttprequest/workers/shared-worker-close.html-disabled.
- http/tests/xmlhttprequest/workers/shared-worker-methods-async.html: Renamed from LayoutTests/http/tests/xmlhttprequest/workers/shared-worker-methods-async.html-disabled.
- http/tests/xmlhttprequest/workers/shared-worker-methods.html: Renamed from LayoutTests/http/tests/xmlhttprequest/workers/shared-worker-methods.html-disabled.
- http/tests/xmlhttprequest/workers/shared-worker-xhr-file-not-found.html: Renamed from LayoutTests/http/tests/xmlhttprequest/workers/shared-worker-xhr-file-not-found.html-disabled.
- 4:05 PM Changeset in webkit [48138] by
-
- 2 edits in trunk/WebCore
wx build fix for 2.8 compilation.
- 3:23 PM Changeset in webkit [48137] by
-
- 18 edits5 deletes in trunk
JavaScriptCore: Reverting r48121 to fix Windows build errors.
- JavaScriptCore.exp:
WebCore: Unreviewed build fix.
Reverting r48121 to fix Windows build errors.
- DerivedSources.cpp:
- GNUmakefile.am:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
(WebCore::toEventTarget):
- dom/EventTarget.cpp:
- dom/EventTarget.h:
- page/DOMWindow.idl:
- websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
(WebCore::WebSocket::send):
(WebCore::WebSocket::close):
(WebCore::WebSocket::bufferedAmount):
(WebCore::WebSocket::addEventListener):
(WebCore::WebSocket::removeEventListener):
(WebCore::WebSocket::dispatchEvent):
(WebCore::WebSocket::didConnect):
(WebCore::WebSocket::didReceiveMessage):
(WebCore::WebSocket::didClose):
(WebCore::WebSocket::dispatchOpenEvent):
(WebCore::WebSocket::dispatchMessageEvent):
(WebCore::WebSocket::dispatchCloseEvent):
- websockets/WebSocket.h:
(WebCore::WebSocket::create):
(WebCore::WebSocket::):
(WebCore::WebSocket::setOnopen):
(WebCore::WebSocket::onopen):
(WebCore::WebSocket::setOnmessage):
(WebCore::WebSocket::onmessage):
(WebCore::WebSocket::setOnclose):
(WebCore::WebSocket::onclose):
(WebCore::WebSocket::toWebSocket):
(WebCore::WebSocket::refEventTarget):
(WebCore::WebSocket::derefEventTarget):
- websockets/WebSocketChannel.cpp: Removed.
- websockets/WebSocketChannel.h: Removed.
- websockets/WebSocketChannelClient.h: Removed.
- websockets/WebSocketHandshake.cpp: Removed.
- websockets/WebSocketHandshake.h: Removed.
LayoutTests: Unreviewed build fix.
Reverting r48121 to fix Windows build errors.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/js/global-constructors-expected.txt:
- 2:29 PM Changeset in webkit [48136] by
-
- 2 edits in trunk/WebCore
Unreviewed speculative build fix.
Reverted previous build fix as it didn't fix the problem.
- bindings/js/JSEventTarget.cpp:
(WebCore::toEventTarget):
- 2:20 PM Changeset in webkit [48135] by
-
- 2 edits in trunk/WebCore
2009-09-07 Laszlo Gombos <Laszlo Gombos>
Unreviewed, build fix.
[Qt] Fix build after SHARED_WORKERS are enabled by default (r48131)
- WebCore.pro:
- 1:50 PM Changeset in webkit [48134] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix.
Temporarily removed depenency between JSEventTarget.cpp and WebSocket.h in an attempt to fix a windows build break.
- bindings/js/JSEventTarget.cpp:
(WebCore::toEventTarget):
- 1:10 PM Changeset in webkit [48133] by
-
- 2 edits in trunk/WebKit/gtk
2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Link new objects documents in the main document.
- docs/webkitgtk-docs.sgml:
- 1:04 PM Changeset in webkit [48132] by
-
- 3 edits in trunk/WebKit/gtk
2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Documentation control files updated for 1.1.14.
- docs/webkitgtk-docs.sgml:
- docs/webkitgtk-sections.txt:
- 12:53 PM Changeset in webkit [48131] by
-
- 27 edits in trunk
JavaScriptCore: Enable SHARED_WORKERS by default
https://bugs.webkit.org/show_bug.cgi?id=28959
Reviewed by David Levin.
- Configurations/FeatureDefines.xcconfig:
WebCore: Enable SHARED_WORKERS by default.
https://bugs.webkit.org/show_bug.cgi?id=28959
Reviewed by David Levin.
Tests (enabled in a separate patch):
fast/workers/shared-worker-constructor.html
fast/workers/shared-worker-context-gc.html
fast/workers/shared-worker-event-listener.html
fast/workers/shared-worker-exception.html
fast/workers/shared-worker-frame-lifecycle.html
fast/workers/shared-worker-gc.html
fast/workers/shared-worker-lifecycle.html
fast/workers/shared-worker-load-error.html
fast/workers/shared-worker-location.html
fast/workers/shared-worker-navigator.html
fast/workers/shared-worker-replace-global-constructor.html
fast/workers/shared-worker-replace-self.html
fast/workers/shared-worker-shared.html
fast/workers/shared-worker-simple.html
http/tests/workers/shared-worker-importScripts.html
http/tests/workers/shared-worker-redirect.html
http/tests/xmlhttprequest/workers/shared-worker-close.html
http/tests/xmlhttprequest/workers/shared-worker-methods-async.html
http/tests/xmlhttprequest/workers/shared-worker-methods.html
http/tests/xmlhttprequest/workers/shared-worker-xhr-file-not-found.html
- config.h: Removed some whitespace/touched the file to force a full rebuild on the build-bots.
- Configurations/FeatureDefines.xcconfig:
- WebCore.pro:
- WebCore.vcproj/WebCoreCommon.vsprops:
- WebCore.vcproj/build-generated-files.sh:
- dom/DOMWindow.idl: Removed unnecessary whitespace to force a rebuild on the build-bots to pickup the flag change.
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::load):
Clean up bitrot in SharedWorker code - DenyCrossOriginRedirect is now DenyCrossOriginRequests.
- workers/SharedWorkerContext.cpp:
(WebCore::SharedWorkerContext::dispatchConnect):
Clean up bitrot - updated SharedWorker code to reflect new MessageEvent API.
WebKit/mac: Enable SHARED_WORKERS by default.
https://bugs.webkit.org/show_bug.cgi?id=28959
Reviewed by David Levin.
- Configurations/FeatureDefines.xcconfig:
WebKit/win: Enable SHARED_WORKERS by default.
https://bugs.webkit.org/show_bug.cgi?id=28959
Reviewed by David Levin.
- WebKit.vcproj/WebKit.vcproj:
WebKitTools: Enable SHARED_WORKERS by default
https://bugs.webkit.org/show_bug.cgi?id=28959
Reviewed by David Levin.
- Scripts/build-webkit:
LayoutTests: Enable SHARED_WORKERS by default
https://bugs.webkit.org/show_bug.cgi?id=28959
Reviewed by David Levin.
Update test expectations to reflect the availability of the SharedWorker constructor.
Fixup bitrot in disabled tests - now reflects new MessagePort API.
- fast/dom/Window/window-properties-expected.txt:
Updated expectations now that window.SharedWorkers is defined.
- fast/dom/prototype-inheritance-2-expected.txt:
Updated expectations now that window.SharedWorkers is defined.
- fast/dom/prototype-inheritance-expected.txt:
Updated expectations now that window.SharedWorkers is defined.
- fast/workers/shared-worker-script-error-expected.txt
Updated expectations to reflect current (correct) behavior (unhandled exceptions are logged to console).
- fast/workers/shared-worker-script-error.html
Pauses before exiting the test to allow pending console errors to get emitted (makes test less flaky).
- fast/workers/resources/shared-worker-script-error.js
(onerror):
Now properly handles the exception (onerror function has to return false to swallow the exception).
- fast/js/global-constructors-expected.txt:
Updated expectations now that window.SharedWorkers is defined.
- http/tests/workers/resources/worker-importScripts.js:
Clean up bitrot in tests - MessageEvent.messagePort => MessageEvent.ports.
(handleConnect.self.postMessage):
(handleConnect):
- http/tests/workers/resources/worker-redirect-target.js:
Clean up bitrot in tests - MessageEvent.messagePort => MessageEvent.ports.
(self.onconnect):
- http/tests/xmlhttprequest/workers/resources/worker-pre.js:
Clean up bitrot in tests - MessageEvent.messagePort => MessageEvent.ports.
- 12:47 PM Changeset in webkit [48130] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.14
Tagging 1.1.14.
- 12:27 PM Changeset in webkit [48129] by
-
- 2 edits in trunk/LayoutTests
2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Skipping one more test affected by the libsoup issue, a new test,
and tests that require eventSender.
- platform/gtk/Skipped:
- 11:57 AM Changeset in webkit [48128] by
-
- 2 edits in trunk/LayoutTests
2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Skipping tests that are failing because of a libsoup
problem. Bug reported.
- platform/gtk/Skipped:
- 11:52 AM Changeset in webkit [48127] by
-
- 2 edits in trunk/WebKit/qt
[PATCH 2/6] Speed up the QWebPluginInfo::supportsMimeType() function.
https://bugs.webkit.org/show_bug.cgi?id=27651
Instead of going through the MIME types list constructed with
mimeTypes() function, look up the internal mimeToDescriptions map.
- 11:16 AM Changeset in webkit [48126] by
-
- 2 edits in trunk/WebCore
2009-09-07 Xan Lopez <xlopez@igalia.com>
Unreviewed build fix.
Add new file to sources list.
- GNUmakefile.am:
- 10:53 AM Changeset in webkit [48125] by
-
- 7 edits in trunk
wx build fixes for wx SVN trunk.
- 10:21 AM Changeset in webkit [48124] by
-
- 2 edits in trunk/WebKit/gtk
2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
What's new for 1.1.14.
- NEWS:
- 10:16 AM Changeset in webkit [48123] by
-
- 2 edits in trunk
2009-09-07 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Gustavo Noronha.
Bump versions in preparation for 1.1.14 release.
- configure.ac:
- 10:07 AM Changeset in webkit [48122] by
-
- 2 edits in trunk/WebCore
[Qt] Use direct includes for Phonon, not the pretty ones
Patch by Chris Hills <chaz@chaz6.com> on 2009-09-07
Reviewed by Tor Arne Vestbø.
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
- 10:02 AM Changeset in webkit [48121] by
-
- 18 edits5 adds in trunk
2009-09-07 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Export WTF::tryFastMalloc used in WebSocketChannel.
https://bugs.webkit.org/show_bug.cgi?id=28038
- JavaScriptCore.exp:
2009-09-07 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Add WebSocket API.
https://bugs.webkit.org/show_bug.cgi?id=28038
WebSocket constructor is available in window object.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/js/global-constructors-expected.txt:
2009-09-07 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket API implementation.
https://bugs.webkit.org/show_bug.cgi?id=28038
Add build systems only for GNUmakefile.am and WebCore.xcodeproj now.
Other build systems will be updated once the code is functional.
Tests will be landed once the code is completed and functional.
- DerivedSources.cpp:
- GNUmakefile.am:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::webSocket):
- bindings/js/JSEventTarget.cpp: (WebCore::toJS): (WebCore::toEventTarget):
- dom/EventTarget.cpp: (WebCore::EventTarget::toWebSocket):
- dom/EventTarget.h:
- page/DOMWindow.idl:
- websockets/WebSocket.cpp: (WebCore::ProcessWebSocketEventTask::create): (WebCore::ProcessWebSocketEventTask::performTask): (WebCore::ProcessWebSocketEventTask::ProcessWebSocketEventTask): (WebCore::isValidProtocolString): (WebCore::WebSocket::connect): (WebCore::WebSocket::send): (WebCore::WebSocket::close): (WebCore::WebSocket::bufferedAmount): (WebCore::WebSocket::addEventListener): (WebCore::WebSocket::removeEventListener): (WebCore::WebSocket::dispatchEvent): (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didReceiveMessage): (WebCore::WebSocket::didClose): (WebCore::WebSocket::dispatchOpenEvent): (WebCore::WebSocket::dispatchMessageEvent): (WebCore::WebSocket::dispatchCloseEvent):
- websockets/WebSocket.h: (WebCore::WebSocket::create): (WebCore::WebSocket::): (WebCore::WebSocket::setOnopen): (WebCore::WebSocket::onopen): (WebCore::WebSocket::setOnmessage): (WebCore::WebSocket::onmessage): (WebCore::WebSocket::setOnclose): (WebCore::WebSocket::onclose): (WebCore::WebSocket::toWebSocket): (WebCore::WebSocket::eventListeners): (WebCore::WebSocket::refEventTarget): (WebCore::WebSocket::derefEventTarget):
- websockets/WebSocketChannel.cpp: Added.
- websockets/WebSocketChannel.h: Added.
- websockets/WebSocketChannelClient.h: Added.
- websockets/WebSocketHandshake.cpp: Added.
- websockets/WebSocketHandshake.h: Added.
- 9:31 AM Changeset in webkit [48120] by
-
- 2 edits in trunk/WebKit/gtk
2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Use g_return_if_fail to check for the SoupURI creation, instead of
printing a custom warning.
- webkit/webkitnetworkrequest.cpp: (webkit_network_request_set_uri):
- 9:29 AM Changeset in webkit [48119] by
-
- 1 edit in trunk/WebKit/gtk/ChangeLog
Fixing name of reviewer in some older commits. Xan suggested the fix,
but Jan reviewed.
- 9:27 AM Changeset in webkit [48118] by
-
- 17 edits4 adds in trunk
2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=26854
[GTK] Needs API to allow more control over outgoing requests
- GNUmakefile.am: new files added to the build for new class WebKitNetworkResponse
WebCore:
2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=26854
[GTK] Needs API to allow more control over outgoing requests
Add infrastructure required to provide the new
WebKitNetworkResponse object in our API.
- GNUmakefile.am: Add new files to the build.
- platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateFromSoupMessage):
- platform/network/soup/ResourceResponse.h:
- platform/network/soup/ResourceResponseSoup.cpp: Added. (WebCore::ResourceResponse::toSoupMessage):
WebKit/gtk
2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=26854
[GTK] Needs API to allow more control over outgoing requests
Map the willSendRequest delegate to the 'resource-request-starting'
signal, allowing more control of the resources that are fetched.
Mapping willSendRequest properly requires an appropriate Response
object, so we are introducing WebKitNetworkResponse, which works in a
way similar to WebKitNetworkRequest.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchWillSendRequest): (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest): (WebKit::FrameLoaderClient::dispatchDidFinishLoading): (WebKit::FrameLoaderClient::dispatchDidFailLoading):
- tests/testnetworkresponse.c: Added. (test_network_response_create_destroy): (test_network_response_properties): (main):
- tests/testwebresource.c: (resource_request_starting_cb): (load_finished_cb): (test_web_resource_loading): (main):
- webkit/webkit.h:
- webkit/webkitdefines.h:
- webkit/webkitnetworkrequest.cpp:
- webkit/webkitnetworkresponse.cpp: Added. (webkit_network_response_dispose): (webkit_network_response_finalize): (webkit_network_response_get_property): (webkit_network_response_set_property): (webkit_network_response_class_init): (webkit_network_response_init): (webkit_network_response_new_with_core_response): (webkit_network_response_new): (webkit_network_response_set_uri): (webkit_network_response_get_uri): (webkit_network_response_get_message):
- webkit/webkitnetworkresponse.h: Added.
- webkit/webkitprivate.cpp: (WTF::SoupMessage): (WTF::WebKitNetworkRequest): (WTF::WebKitNetworkResponse): (WTF::WebKitWebResource):
- webkit/webkitprivate.h:
- webkit/webkitwebresource.cpp: (webkit_web_resource_cleanup): (webkit_web_resource_finalize): (webkit_web_resource_class_init): (webkit_web_resource_set_property): (webkit_web_resource_get_uri):
- webkit/webkitwebview.cpp: (webkit_web_view_class_init):
- webkitmarshal.list:
- 8:28 AM Changeset in webkit [48117] by
-
- 2 edits in trunk/WebKit/gtk
2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=28979
[GTK] Misc improvments to NetworkRequest
Unref message in dispose, as it should be, not in finalize.
- webkit/webkitnetworkrequest.cpp: (webkit_network_request_dispose): (webkit_network_request_finalize): (webkit_network_request_class_init):
- 8:28 AM Changeset in webkit [48116] by
-
- 2 edits in trunk/WebKit/gtk
2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=28979
[GTK] Misc improvments to NetworkRequest
Bring documentation up-to-date with reality regarding NetworkRequest.
- webkit/webkitnetworkrequest.cpp:
- 8:11 AM Changeset in webkit [48115] by
-
- 2 edits in trunk/WebKit/gtk
2009-09-07 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Make the auth dialog usable when libsoup does not have a
SoupPasswordManager, since it might go away in the next
development cycle.
- webkit/webkitsoupauthdialog.c: (response_callback): (session_can_save_passwords): (session_authenticate):
- 7:49 AM Changeset in webkit [48114] by
-
- 2 edits in trunk/WebCore
2009-09-07 Mads Ager <ager@chromium.org>
Reviewed by Adam Barth.
[V8] Cleanup document/frame null-checking in V8DOMWindowCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=29009
Be consistent in document and frame null checks.
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::V8Custom::ClearTimeoutImpl):
- 7:21 AM Changeset in webkit [48113] by
-
- 4 edits in trunk/WebKit/qt
2009-09-07 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
Speed up the QWebPluginInfo::mimeTypes() function.
https://bugs.webkit.org/show_bug.cgi?id=27651
Instead of constructing a list of MIME types every time it is called,
do this only once.
- Api/qwebplugindatabase.cpp: (QWebPluginInfo::mimeTypes): (QWebPluginInfo::operator=):
- Api/qwebplugindatabase.h:
- tests/qwebplugindatabase/tst_qwebplugindatabase.cpp: (tst_QWebPluginDatabase::operatorassign_data): (tst_QWebPluginDatabase::operatorassign):
- 7:15 AM Changeset in webkit [48112] by
-
- 3 edits1 delete in trunk/WebKit/qt
2009-09-07 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
Remove the private classes from QWebPluginDatabase.
https://bugs.webkit.org/show_bug.cgi?id=27651
Instead, hold the PluginDatabase and PluginPackage objects as class
members and take care of refcounting on our own instead of using RefPtr.
This way we not only made the code cleaner but also got rid of
redundant allocations when constructing null QWebPluginInfo objects.
The private classes have been forward-declared and the d-pointers left
to be on the safe side.
- Api/qwebplugindatabase.cpp: (QWebPluginInfo::QWebPluginInfo): (QWebPluginInfo::~QWebPluginInfo): (QWebPluginInfo::name): (QWebPluginInfo::description): (QWebPluginInfo::mimeTypes): (QWebPluginInfo::path): (QWebPluginInfo::isNull): (QWebPluginInfo::setEnabled): (QWebPluginInfo::isEnabled): (QWebPluginInfo::operator==): (QWebPluginInfo::operator!=): (QWebPluginInfo::operator=): (QWebPluginDatabase::QWebPluginDatabase): (QWebPluginDatabase::~QWebPluginDatabase): (QWebPluginDatabase::plugins): (QWebPluginDatabase::searchPaths): (QWebPluginDatabase::setSearchPaths): (QWebPluginDatabase::addSearchPath): (QWebPluginDatabase::refresh): (QWebPluginDatabase::pluginForMimeType): (QWebPluginDatabase::setPreferredPluginForMimeType):
- Api/qwebplugindatabase.h:
- Api/qwebplugindatabase_p.h: Removed.
- 6:38 AM Changeset in webkit [48111] by
-
- 2 edits in trunk/WebCore
2009-09-07 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[Soup] Limit the number of connections
https://bugs.webkit.org/show_bug.cgi?id=18431
Increase the maximum number of per host and total connections to
similar values than those used by the other modern browsers. Seems
to significantly improve page loading time in many cases.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ensureSessionIsInitialized):
- 3:09 AM Changeset in webkit [48110] by
-
- 2 edits in trunk/LayoutTests
[Qt] Disable a few tests that require missing controller features
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-09-07
Reviewed by Tor Arne Vestbø
- platform/qt/Skipped:
- 12:35 AM Changeset in webkit [48109] by
-
- 4 edits in trunk/WebCore
2009-09-07 Michael Nordman <Michael Nordman>
Reviewed by Darin Fisher.
Various minor chromium appcache modifications.
https://bugs.webkit.org/show_bug.cgi?id=28960
No new tests.
- bindings/v8/custom/V8DOMApplicationCacheCustom.cpp: Fix a null pointer exception. (WebCore::ACCESSOR_GETTER):
- platform/network/chromium/ResourceRequest.h: Switch from appCache 'context' to 'host' terminology. Note: leaving the old deprecated accessors in place until the matching change in chrome is landed to use the new accessors. (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::appCacheHostID): (WebCore::ResourceRequest::setAppCacheHostID): (WebCore::ResourceRequest::appCacheContextID): (WebCore::ResourceRequest::setAppCacheContextID):
- platform/network/chromium/ResourceResponse.h: Add an appCacheManifestURL getter/setter. Drop the 'get' prefix from the appCacheID getter. Note: leaving the old deprecated 'get' prefixed accessor in place until the matching change in chrome is landed to use the new accessor. (WebCore::ResourceResponse::appCacheID): (WebCore::ResourceResponse::appCacheManifestURL): (WebCore::ResourceResponse::setAppCacheManifestURL): (WebCore::ResourceResponse::getAppCacheID):
- 12:28 AM Changeset in webkit [48108] by
-
- 5 edits2 adds in trunk
2009-09-07 Michael Nordman <Michael Nordman>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=28359
Test to ensure the the window.applicationCache attribute is defined but non-functional
with the feature disabled.
- http/tests/appcache/disabled-expected.txt: Added.
- http/tests/appcache/disabled.html: Added.
2009-09-07 Michael Nordman <Michael Nordman>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=28359
Cleanup: Undo some accidental changes around DOMApplicationCache.
- Restore support for constructing a DOMApplicationCache object with a null frame ptr.
- Return a non-null object for window.applicationCache when the feature is disabled.
- Simplify the swapCache method.
Test: http/tests/appcache/disabled.html
- loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::DOMApplicationCache): (WebCore::DOMApplicationCache::swapCache): (WebCore::DOMApplicationCache::scriptExecutionContext):
- loader/appcache/DOMApplicationCache.h:
- page/DOMWindow.cpp: (WebCore::DOMWindow::applicationCache):
Sep 6, 2009:
- 10:25 PM Changeset in webkit [48107] by
-
- 5 edits in trunk
2009-09-06 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
hostname and host are mixed up when manipulating anchor elements.
https://bugs.webkit.org/show_bug.cgi?id=28954
Added test case for when port is 0.
- fast/dom/Element/hostname-host-expected.txt:
- fast/dom/Element/hostname-host.html:
2009-09-06 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
hostname and host are mixed up when manipulating anchor elements.
https://bugs.webkit.org/show_bug.cgi?id=28954
handle the case of port 0.
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::host):
- 10:10 PM Changeset in webkit [48106] by
-
- 31 edits6 adds in trunk
2009-09-06 Erik Arvidsson <arv@chromium.org>
Reviewed by Eric Seidel.
Tests for https://bugs.webkit.org/show_bug.cgi?id=27099
Make hidden elements not focusable. This is important becaue we should
not allow tabbing to a hidden element.
The patch also makes a element without href behave like generic elements
when it comes to focus. Added tests that asserts that this works as
expected.
- fast/events/click-focus-anchor-expected.txt: Added.
- fast/events/click-focus-anchor.html: Added.
- fast/events/resources/tabindex-focus-blur-all.js: (test): (testProgrammaticFocus):
- fast/events/tab-focus-anchor-expected.txt: Added.
- fast/events/tab-focus-anchor.html: Added.
- fast/events/tab-focus-hidden-expected.txt: Added.
- fast/events/tab-focus-hidden.html: Added.
- fast/events/tabindex-focus-blur-all-expected.txt:
2009-09-06 Erik Arvidsson <arv@chromium.org>
Reviewed by Eric Seidel.
Make hidden elements not focusable.
Clean up supportsFocus and isFocusable.
supportsFocus now strictly means that the node can be focused by default.
This is true for links, form controls and content editable elements for example.
isFocusable means that the user can actually focus it.
All (2) calls to supportsFocus have been updated to take this into account.
Make a elements without href work correctly as well.
Tests: fast/events/click-focus-anchor.html
fast/events/tab-focus-anchor.html
fast/events/tab-focus-hidden.html
- dom/Element.cpp: (WebCore::Element::focus):
- dom/Node.cpp: (WebCore::Node::supportsFocus): (WebCore::Node::isFocusable):
- dom/Node.h:
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::supportsFocus): (WebCore::HTMLAnchorElement::isMouseFocusable): (WebCore::HTMLAnchorElement::isKeyboardFocusable):
- html/HTMLAnchorElement.h:
- html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::supportsFocus):
- html/HTMLAreaElement.h:
- html/HTMLElement.cpp: (WebCore::HTMLElement::supportsFocus):
- html/HTMLElement.h:
- html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::supportsFocus):
- html/HTMLFieldSetElement.h:
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::supportsFocus): (WebCore::HTMLFormControlElement::isFocusable):
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::supportsFocus):
- html/HTMLFrameElementBase.h:
- html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::supportsFocus):
- html/HTMLLegendElement.h:
- html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::supportsFocus): (WebCore::HTMLOptGroupElement::isFocusable):
- html/HTMLOptGroupElement.h:
- html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::supportsFocus): (WebCore::HTMLOptionElement::isFocusable):
- html/HTMLOptionElement.h:
- page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent):
- page/FocusController.cpp: (WebCore::FocusController::advanceFocus):
- svg/SVGAElement.cpp: (WebCore::SVGAElement::supportsFocus): (WebCore::SVGAElement::isFocusable):
- wml/WMLAElement.cpp: (WebCore::WMLAElement::supportsFocus):
- wml/WMLAElement.h:
- wml/WMLFormControlElement.cpp: (WebCore::WMLFormControlElement::supportsFocus): (WebCore::WMLFormControlElement::isFocusable):
- wml/WMLFormControlElement.h:
- 9:15 PM Changeset in webkit [48105] by
-
- 3 edits in trunk/WebCore
2009-09-06 Joel Stanley <joel@jms.id.au>
Reviewed by Dimitri Glazkov.
Expose functions to set the caret blink interval for Linux Chromium.
Default value is set to that of RenderTheme::caretBlankInterval().
Uses caretBlinkIntervalInternal to avoid overriding
RenderThemeChromiumSkia::caretBlankInterval to preserve the disabling
of blinking caret required for layout tests.
https://bugs.webkit.org/show_bug.cgi?id=28931
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux): (WebCore::RenderThemeChromiumLinux::setCaretBlinkInterval): (WebCore::RenderThemeChromiumLinux::caretBlinkIntervalInternal):
- rendering/RenderThemeChromiumLinux.h:
- 7:27 PM Changeset in webkit [48104] by
-
- 2 edits in trunk/WebCore
Remove an extra </File> in WebCore.vcproj.
- WebCore.vcproj/WebCore.vcproj:
- 3:44 PM Changeset in webkit [48103] by
-
- 2 edits in trunk/WebKit/gtk
2009-09-06 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Update the unitests to latest changes wrt scrollbar policy.
- tests/testwindow.c: (test_webkit_window_scrollbar_policy):
- 1:43 PM Changeset in webkit [48102] by
-
- 6 edits1 add in trunk/WebCore
Adds a persistent setting for color format in the Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=28889
Reviewed by Dan Bernstein.
- English.lproj/localizedStrings.js: New strings.
- inspector/front-end/Color.js: Minor style fixes.
(WebInspector.Color.prototype.toString): Added. Replaces the individual
"toFoo" functions. Takes a optional arguments for the color format to return.
- inspector/front-end/Images/paneSettingsButtons.png: Added.
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._changeColorFormat): Update the sections to show
the new color format.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor.changeColorDisplay):
Use the new toString function on Color.
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor): Use the persistent setting
to format colors by default. Add a tooltip for the color swatch.
- inspector/front-end/inspector.css: New styles for the settings menu.
- inspector/front-end/inspector.js:
(WebInspector.loaded): Initilize the colorFormat preference.
- 7:31 AM Changeset in webkit [48101] by
-
- 15 edits4 adds in trunk
2009-09-06 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha, Jan Alonzo and Xan Lopez.
[Gtk] Expose a database API
https://bugs.webkit.org/show_bug.cgi?id=27899
Expose an HTML5 database API for GTK+.
- GNUmakefile.am:
LayoutTests:
2009-09-06 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha, Jan Alonzo and Xan Lopez.
[Gtk] Expose a database API
https://bugs.webkit.org/show_bug.cgi?id=27899
Expose an HTML5 database API for GTK+.
- platform/gtk/Skipped:
WebKit/gtk:
2009-09-06 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Gustavo Noronha, Jan Alonzo and Xan Lopez.
[Gtk] Expose a database API
https://bugs.webkit.org/show_bug.cgi?id=27899
Expose an HTML5 database API for GTK+.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::print):
- webkit/webkit.h:
- webkit/webkitdefines.h:
- webkit/webkitprivate.cpp: (webkit_init):
- webkit/webkitprivate.h:
- webkit/webkitsecurityorigin.cpp: Added. (webkit_security_origin_finalize): (webkit_security_origin_dispose): (webkit_security_origin_set_property): (webkit_security_origin_get_property): (webkit_security_origins): (webkit_security_origin_class_init): (webkit_security_origin_init): (webkit_security_origin_get_protocol): (webkit_security_origin_get_host): (webkit_security_origin_get_port): (webkit_security_origin_get_web_database_usage): (webkit_security_origin_get_web_database_quota): (webkit_security_origin_set_web_database_quota): (webkit_security_origin_get_all_web_databases): (WebKit::kit): (WebKit::core): (webkit_security_origin_get_web_database):
- webkit/webkitsecurityorigin.h: Added.
- webkit/webkitwebdatabase.cpp: Added. (webkit_web_database_finalize): (webkit_web_database_dispose): (webkit_web_database_set_property): (webkit_web_database_get_property): (webkit_web_database_class_init): (webkit_web_database_init): (webkit_web_database_set_security_origin): (webkit_web_database_set_name): (webkit_web_database_get_security_origin): (webkit_web_database_get_name): (webkit_web_database_get_display_name): (webkit_web_database_get_expected_size): (webkit_web_database_get_size): (webkit_web_database_get_filename): (webkit_web_database_remove): (webkit_remove_all_web_databases): (webkit_get_web_database_directory_path): (webkit_set_web_database_directory_path): (webkit_get_default_web_database_quota):
- webkit/webkitwebdatabase.h: Added.
- webkit/webkitwebframe.cpp: (webkit_web_frame_new): (webkit_web_frame_get_focused_accessible_element): (webkit_web_frame_get_horizontal_scrollbar_policy):
- webkit/webkitwebframe.h:
- webkit/webkitwebview.cpp: (webkit_web_view_class_init):
- 5:38 AM Changeset in webkit [48100] by
-
- 3 edits in trunk/WebCore
2009-09-06 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
[Qt] Remove Qt v4.6 check from the prefetchDNS implementation
https://bugs.webkit.org/show_bug.cgi?id=28993
- platform/network/qt/DnsPrefetchHelper.cpp:
- platform/network/qt/DnsPrefetchHelper.h:
- 12:24 AM Changeset in webkit [48099] by
-
- 24 edits3 deletes in trunk
2009-09-06 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991
Update test not to expect a <definition-src> element to be of type
SVGDefinitionSrcElement.
- svg/dom/font-face-elements-expected.txt:
- svg/dom/font-face-elements.html:
2009-09-06 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991
http://dev.w3.org/SVG/profiles/1.1F2/publish/changes.html#FontsChapter
- DerivedSources.cpp: Remove references to definition-src.
- DerivedSources.make: Ditto.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/objc/DOM.mm: (WebCore::createElementClassMap): Ditto.
- bindings/objc/DOMSVG.h: Ditto.
- bindings/v8/DerivedSourcesAllInOne.cpp: Ditto.
- bindings/v8/V8DOMWrapper.cpp: Ditto.
- bindings/v8/V8Index.cpp: Ditto.
- bindings/v8/V8Index.h: Ditto.
- svg/SVGAllInOne.cpp: Ditto.
- svg/SVGDefinitionSrcElement.cpp: Removed.
- svg/SVGDefinitionSrcElement.h: Removed.
- svg/SVGDefinitionSrcElement.idl: Removed.
- svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::rebuildFontFace): Don't search for definition-src child.
- svg/svgtags.in: Remove definition-src.
2009-09-06 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991
- MigrateHeaders.make: Remove reference to ObjC definition-src binding class.
2009-09-06 Cameron McCormack <cam@mcc.id.au>
Reviewed by Eric Seidel.
Drop <definition-src> support
https://bugs.webkit.org/show_bug.cgi?id=28991
When SVG 1.1 Second Edition is a Recommendation we can remove the
entry altogether.
- projects/svg/status.xml: Update page to state that <definition-src> is not supported.
