Timeline
Oct 18, 2009:
- 11:59 PM Changeset in webkit [49767] by
-
- 3 edits10 adds in trunk
2009-10-18 Erik Arvidsson <arv@chromium.org>
Reviewed by Adam Barth.
Fixes issue where doubleclicking a word could select following adjacent newlines.
https://bugs.webkit.org/show_bug.cgi?id=30234
- platform/mac/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt: Added.
- platform/mac/editing/selection/doubleclick-should-not-expand-across-lines.html: Added.
- platform/mac/editing/selection/script-tests/TEMPLATE.html: Added.
- platform/mac/editing/selection/script-tests/doubleclick-should-not-expand-across-lines.js: Added. (description.doubleClickOnElement): (doubleClickAt): (selectionShouldBe):
- platform/win/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt: Added.
- platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html: Added.
- platform/win/editing/selection/script-tests/TEMPLATE.html: Added.
- platform/win/editing/selection/script-tests/doubleclick-should-not-expand-across-lines.js: Added. (description.doubleClickOnElement): (doubleClickAt): (selectionShouldBe):
2009-10-18 Erik Arvidsson <arv@chromium.org>
Reviewed by Adam Barth.
Fixes issue where doubleclicking a word could select following adjacent newlines.
https://bugs.webkit.org/show_bug.cgi?id=30234
Tests: platform/mac/editing/selection/doubleclick-should-not-expand-across-lines.html
platform/mac/editing/selection/script-tests/TEMPLATE.html
platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html
platform/win/editing/selection/script-tests/TEMPLATE.html
- editing/VisibleSelection.cpp: (WebCore::VisibleSelection::appendTrailingWhitespace):
- 11:51 PM Changeset in webkit [49766] by
-
- 7 edits in trunk
2009-10-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
Rename fixedContentsSize property to preferredContentsSize as
agreed upon with Siman Hausmann and Matthias Ettrich.
- Api/qwebpage.cpp: (QWebPage::preferredContentsSize): (QWebPage::setPreferredContentsSize):
- Api/qwebpage.h:
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
2009-10-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
Use the setPreferredContentsSize method instead
of setFixedContentsSize, as the method has been renamed.
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setFixedContentsSize):
- 11:50 PM QtBackLog edited by
- (diff)
- 11:46 PM QtBackLog edited by
- Move QtWebKit problems into a table. (diff)
- 11:43 PM Changeset in webkit [49765] by
-
- 2 edits in trunk/JavaScriptCore
2009-10-18 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Use _stricmp and _strnicmp instead of deprecated stricmp and strnicmp.
https://bugs.webkit.org/show_bug.cgi?id=30474
stricmp and strnicmp are deprecated beginning in Visual
C++ 2005. Use _stricmp and _strnicmp instead in StringExtras.h.
- wtf/StringExtras.h: (strncasecmp): (strcasecmp):
- 11:42 PM QtBackLog edited by
- Change Qt items into a table (diff)
- 11:34 PM QtBackLog edited by
- Add completed items to the bottom (diff)
- 8:53 PM Changeset in webkit [49764] by
-
- 2 edits in trunk/WebCore
CURL build fix, use proper header name.
- 7:38 PM Changeset in webkit [49763] by
-
- 2 edits in trunk/WebKit/mac
<rdar://problem/7309062> Crashes in WebCore::DocumentLoader::isStopping below WebKit::NetscapePluginInstanceProxy::loadRequest.
Reviewed by Dan Bernstein.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::loadRequest): Null-check the DocumentLoader before deferencing it.
- 7:09 PM Changeset in webkit [49762] by
-
- 9 edits in trunk
2009-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Properties on Arrays and NodeLists are not logged correctly.
WebCore:
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._formatarray): (WebInspector.ConsoleView.prototype._printArray):
LayoutTests:
- inspector/console-format-expected.txt:
- inspector/console-format.html:
- 6:20 PM Changeset in webkit [49761] by
-
- 2 edits in trunk/WebCore
2009-10-18 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: touching WebCore so that it
initiated inspector frontend deployment on Windows.
Web Inspector: frontend files are not deployed in Windows
incremental build.
- inspector/InspectorDOMAgent.cpp:
- 5:20 PM Changeset in webkit [49760] by
-
- 6 edits6 adds in trunk/LayoutTests
2009-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: make console tests more granular.
- inspector/console-dir-expected.txt: Added.
- inspector/console-dir.html: Added.
- inspector/console-dirxml-expected.txt: Added.
- inspector/console-dirxml.html: Added.
- inspector/console-format-expected.txt: Added.
- inspector/console-format.html: Added.
- inspector/console-tests-expected.txt:
- inspector/console-tests.html:
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 4:48 PM Changeset in webkit [49759] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 4:17 PM Changeset in webkit [49758] by
-
- 4 edits in trunk
2009-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Title of dir(["test", "test2"]) should be Array
Test: inspector/console-tests.html
- inspector/front-end/InjectedScript.js:
- 2:15 PM Changeset in webkit [49757] by
-
- 9 edits in trunk
2009-10-18 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
REGRESSION: SVG Mask doesn't work for maskContentUnits="objectBoundingBox"
https://bugs.webkit.org/show_bug.cgi?id=30480
Patch for SVGMaskElement landed in r49598 should correct the location of
the mask image graphics context. It only corrects the location for userSpaceOnUse
mode in maskContentUnits but breaks objectBoundingBoxMode.
The maskDestRect shouldn't be moved. It is not responsible for the correct context
postioin but for the correct position of the mask image.
This patch calculates the context postion independently from the maskDestRect.
It also uses lineareRGB color space for masking on CG now. This is the default
color space for masking operations.
We already have tests for both maskContentUnits modes.
*svg/W3C-SVG-1.1/masking-intro-01-f.svg
*svg/custom/mask-with-default-value.svg
Some tests needed new pixel tests because of the new color space.
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
The color space of masking operations in SVG changed to linearSVG.
This needs an update of some masking pixel tests.
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
- platform/mac/svg/batik/masking/maskRegions-expected.checksum:
- platform/mac/svg/batik/masking/maskRegions-expected.png:
- platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
- platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
- 12:55 PM Changeset in webkit [49756] by
-
- 2 edits in trunk/WebCore
2009-10-18 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Use v8::Integer::NewFromUnsigned when converting unsigneds into V8's numbers.
That is notably faster for small numbers (most common case).
https://bugs.webkit.org/show_bug.cgi?id=30493
- bindings/scripts/CodeGeneratorV8.pm:
- 12:29 PM Changeset in webkit [49755] by
-
- 5 edits5 adds in trunk
2009-10-18 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[GTK] Add MathML to the build system
https://bugs.webkit.org/show_bug.cgi?id=30487
Add --enable-mathml to configure.
- configure.ac:
Add MathML sources if MathML support is enabled.
- GNUmakefile.am:
Include layout test baseline for Gtk.
- platform/gtk/mathml/presentation/sub-expected.txt: Added.
- platform/gtk/mathml/presentation/sup-expected.txt: Added.
- platform/gtk/mathml/presentation/tables-expected.txt: Added.
- 11:21 AM Changeset in webkit [49754] by
-
- 2 edits in trunk/WebCore
Non-PCH build fix. Added missing header.
- 10:17 AM Changeset in webkit [49753] by
-
- 7 edits4 adds in trunk
2009-10-18 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Compositing layers not correctly updated after partial layout
https://bugs.webkit.org/show_bug.cgi?id=30425
When a partial layout happened, for example as the result of a postion-change-only
layout, then some compositing layer positions were not correctly updated. To fix
this, updateLayerPositions() now carries along a flag that is set at the rootmost
layer being updated, and used to determine when we hit the first compositing layer
in this update. RenderLayerBacking::updateAfterLayout() makes use of this information
to do a full geometry update on that layer, which is thus the rootmost compositing
layer that is being updated.
Test: compositing/geometry/partial-layout-update.html
- page/FrameView.cpp: (WebCore::FrameView::layout):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::scrollToOffset):
- rendering/RenderLayer.h: (WebCore::RenderLayer::):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterLayout):
- rendering/RenderLayerBacking.h:
- 10:02 AM Changeset in webkit [49752] by
-
- 6 edits in trunk
Reviewed by Kevin Ollivier.
Add the ability to specify a proxy for wxWebKit.
https://bugs.webkit.org/show_bug.cgi?id=30446
- 9:23 AM Changeset in webkit [49751] by
-
- 2 edits in trunk/WebCore
2009-10-18 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez
https://bugs.webkit.org/show_bug.cgi?id=25901
Use ATK_ROLE_SECTION for divTag and ATK_ROLE_LABEL for labelTag
Replaces the use of ATK_ROLE_PANEL with the expected accessible roles.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):
- 9:08 AM Changeset in webkit [49750] by
-
- 4 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Add basic database support to wx API
https://bugs.webkit.org/show_bug.cgi?id=30445
- 9:00 AM Changeset in webkit [49749] by
-
- 2 edits in trunk/LayoutTests
2009-10-18 Eric Carlson <eric.carlson@apple.com>
Skip media/video-empty-source.html until <rdar://problem/6563117> has been fixed.
- platform/mac/Skipped:
- 7:50 AM QtBackLog edited by
- (diff)
- 2:35 AM QtWebKitPlugins edited by
- (diff)
Oct 17, 2009:
- 11:27 PM Changeset in webkit [49748] by
-
- 2 edits in trunk/LayoutTests
2009-10-17 Yuta Kitamura <yutak@chromium.org>
Reviewed by Darin Adler.
Fix inefficient string concatenation.
LayoutTests/fast/css/large-list-of-rules-crash.html contains code that
concatenate strings in an inefficient way. Concatenation of strings should be
done with Array.join method. This patch fixes this issue, and also fixes typos
in the test.
fast/css/large-list-of-rules-crash.html concatenates strings in an inefficient way
https://bugs.webkit.org/show_bug.cgi?id=30436
- fast/css/large-list-of-rules-crash.html:
- 6:46 PM QtBackLog edited by
- (diff)
- 6:41 PM QtBackLog edited by
- (diff)
- 6:22 PM QtBackLog edited by
- (diff)
- 6:15 PM QtBackLog edited by
- (diff)
- 4:07 PM Changeset in webkit [49747] by
-
- 4 edits in trunk
Versioning.
- 4:06 PM Changeset in webkit [49746] by
-
- 1 copy in tags/Safari-532.2
New tag.
- 3:52 PM Changeset in webkit [49745] by
-
- 13 edits2 adds in trunk/WebCore
2009-10-17 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by George Staikos.
Cleanup SVGElement code, preparing for animVal support
https://bugs.webkit.org/show_bug.cgi?id=30466
Add new SynchronizablePropertyController and move the code for SVG property <-> XML attribute synchronization
from SVGElement. This is a further preparation for animVal support, where SynchronizablePropertyController will
be used to control the start/end state of an animated property.
We're currently tracking animated properties that need synchronization, generalize this concept and use
it to track their creation (bound to certain SVG*Element classes) as well as a flag determing the need
of synchronization (no SVG DOM object wrappers, no synchronization needed).
No change in functionality, thus no tests.
- GNUmakefile.am: Add 'SynchronizablePropertyController.cpp/h' to build
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- svg/SVGAllInOne.cpp: Ditto.
- svg/SVGAnimatedProperty.h: Add registerProperty() function (WebCore::::SVGAnimatedProperty): Call registerProperty() function (WebCore::::registerProperty): Add new registerProperty() function, announcing new properties to SynchronizablePropertyController.
- svg/SVGAnimatedTemplate.h: Use propertyController() method, to access the new functions moved from SVGElement. (WebCore::lookupOrCreateWrapper):
- svg/SVGElement.cpp: Adapt to code moving to SynchronizablePropertyController. (WebCore::SVGElement::updateAnimatedSVGAttribute):
- svg/SVGElement.h: Move handling SVG property synchronization to SynchronizablePropertyController. (WebCore::SVGElement::propertyController): Expose reference to SynchronizablePropertyController object.
- svg/SVGViewSpec.cpp: Reorder initialization order of contextElement, leading to possible crashes. (WebCore::SVGViewSpec::SVGViewSpec): (WebCore::SVGViewSpec::viewTarget):
- svg/SVGViewSpec.h: Ditto. (WebCore::SVGViewSpec::contextElement):
- svg/SynchronizablePropertyController.cpp: Added. (WebCore::SynchronizablePropertyController::SynchronizablePropertyController): (WebCore::SynchronizablePropertyController::registerProperty): (WebCore::SynchronizablePropertyController::setPropertyNeedsSynchronization): (WebCore::SynchronizablePropertyController::synchronizeProperty): (WebCore::SynchronizablePropertyController::synchronizeAllProperties): (WebCore::SynchronizablePropertyController::startAnimation): (WebCore::SynchronizablePropertyController::stopAnimation):
- svg/SynchronizablePropertyController.h: Added. (WebCore::SynchronizableProperty::SynchronizableProperty): (WebCore::SynchronizableProperty::isHashTableDeletedValue): (WebCore::SynchronizableProperty::operator==): (WebCore::SynchronizablePropertyHash::hash): (WebCore::SynchronizablePropertyHash::equal): (WebCore::SynchronizablePropertyHashTraits::constructDeletedValue): (WebCore::SynchronizablePropertyHashTraits::isDeletedValue):
- 3:38 PM Changeset in webkit [49744] by
-
- 2 edits in trunk/BugsSite
Reviewed by Eric Carlson.
https://bugs.webkit.org/show_bug.cgi?id=30470
Make marking a bug as duplicate easier
- js/field.js: (setResolutionToDuplicate): Focus the edit field, too.
- 1:00 PM Changeset in webkit [49743] by
-
- 2 edits in trunk/WebCore
2009-10-17 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25413
[GTK] Please expose the level of headings
Exposes the heading level as an attribute of the AtkObject.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (addAttributeToSet): (webkit_accessible_get_attributes): (webkit_accessible_class_init):
- 8:54 AM Changeset in webkit [49742] by
-
- 2 edits in trunk/WebCore
2009-10-17 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
EventHandler::eventLoopHandleMouseDragged needs ENABLE(DRAG_SUPPORT) guards
https://bugs.webkit.org/show_bug.cgi?id=30472
Put ENABLE(DRAG_SUPPORT) guards around EventHandler::eventLoopHandleMouseDragged
in EventHandler.cpp. MSVC fails to compile when DRAG_SUPPORT not enabled.
- page/EventHandler.cpp:
- 8:49 AM Changeset in webkit [49741] by
-
- 3 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Optionally allow the user to zoom text using the mouse wheel.
https://bugs.webkit.org/show_bug.cgi?id=30444
- 8:45 AM Changeset in webkit [49740] by
-
- 2 edits in trunk/WebCore
2009-10-17 Alpha Lam <hclam@chromium.org>
Reviewed by Eric Seidel.
[chromium] Video controls not zoomed / transformed correctly
https://bugs.webkit.org/show_bug.cgi?id=30461
Draw the images in the controls scaled.
No new tests. With this change Chromium will pass the following tests:
LayoutTests/media/video-controls-zoomed.html
LayoutTests/media/video-controls-transformed.html
- rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaButton): Pass along the target rect directly. (WebCore::RenderMediaControlsChromium::adjustMediaSliderThumbSize): Adjust the thumb slide applied with the scale factor.
- 12:53 AM Changeset in webkit [49739] by
-
- 2 edits in trunk/WebCore
2009-10-17 Laszlo Gombos <Laszlo Gombos>
Unreviewed.
[Gtk] Build fix for WebKitGtk after r49723.
Add bindings/js/JSExceptionBase.* to the build.
- GNUmakefile.am:
- 12:46 AM Changeset in webkit [49738] by
-
- 2 edits in trunk/WebCore
2009-10-17 Laszlo Gombos <Laszlo Gombos>
Unreviewed.
Add bindings/js/JSExceptionBase.cpp to the build.
- WebCore.pro:
- 12:32 AM Changeset in webkit [49737] by
-
- 3 edits in trunk/LayoutTests
2009-10-17 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: reduce inspector console test size - it times out.
- inspector/console-tests-expected.txt:
- inspector/console-tests.html:
Oct 16, 2009:
- 11:59 PM Changeset in webkit [49736] by
-
- 2 edits in trunk/BugsSite
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=30470
Make marking a bug as duplicate easier
- js/field.js: (setResolutionToDuplicate): Show edit field right away, don't make the user click again.
- 11:50 PM WebKit Team edited by
- Added Drag and Drop to my section. (diff)
- 11:29 PM Changeset in webkit [49735] by
-
- 12 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=30456
Fixes for new Debug_All Windows build configuration.
Reviewed by Dan Bernstein.
WebCore:
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::findCFNetworkModule): Ask for the correct library instead of guessing.
- platform/win/ScrollbarThemeSafari.cpp: Use new DEBUG_ALL preprocessor define for library naming.
- rendering/RenderMediaControls.cpp: Use new DEBUG_ALL preprocessor define for library naming.
- rendering/RenderThemeSafari.cpp: Use new DEBUG_ALL preprocessor define for library naming.
WebKit/win:
- WebKitClassFactory.cpp: Use new DEBUG_ALL preprocessor define for library naming.
WebKitLibraries:
- win/tools/vsprops/debug_all.vsprops:
Define DEBUG_ALL in Debug_All configuration.
Continue to define USE_DEBUG_SAFARI_THEME for open source SafariTheme header usage.
WebKitTools:
- DumpRenderTree/win/DumpRenderTree.cpp:
(sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
- DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
- 10:52 PM Changeset in webkit [49734] by
-
- 98 edits1 add in trunk
Rolled back in r49717 with the build maybe working now?
- 10:15 PM Changeset in webkit [49733] by
-
- 5 edits in trunk/WebKit/mac
Reviewed by Jon Honeycutt.
<rdar://problem/7304575>
- Plugins/WebBaseNetscapePluginView.h: Added new boolean ivar and -hasBeenHalted instance method.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView halt]):Update _hasBeenHalted. (-[WebBaseNetscapePluginView hasBeenHalted]): Added.
- WebView/WebView.mm: (+[WebView _hasPluginForNodeBeenHalted:]): Checks to see if a plug-in node's been halted.
- WebView/WebViewPrivate.h: Added -_hasPluginForNodeBeenHalted method.
- 9:38 PM Changeset in webkit [49732] by
-
- 8 edits in trunk
Add SPI to determine whether a plug-in has ever been halted.
Part of <rdar://problem/7312158>.
Reviewed by Dan Bernstein.
WebCore:
- plugins/PluginView.cpp:
(WebCore::PluginView::PluginView):
Initialize m_hasBeenHalted.
- plugins/PluginView.h:
(WebCore::PluginView::hasBeenHalted):
Return m_hasBeenHalted.
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::halt):
Set m_hasBeenHalted.
WebKit/win:
- Interfaces/IWebViewPrivate.idl:
Add hasPluginForNodeBeenHalted().
- WebView.cpp:
(pluginViewForNode):
Code factored out of isNodeHaltedPlugin().
(WebView::isNodeHaltedPlugin):
Remove STDMETHODCALLTYPE, as it has no use at the definition. Use
pluginViewForNode().
(WebView::restartHaltedPluginForNode):
Ditto.
(WebView::hasPluginForNodeBeenHalted):
Get the PluginView for the given node. Return the result of
PluginView::hasBeenHalted().
- WebView.h:
Declare hasPluginForNodeBeenHalted().
- 9:23 PM Changeset in webkit [49731] by
-
- 2 edits in trunk/LayoutTests
2009-10-16 Simon Fraser <Simon Fraser>
Skip this test:
compositing/animation/animated-composited-inside-hidden.html
because the fix for https://bugs.webkit.org/show_bug.cgi?id=26770 was backed out.
- platform/mac/Skipped:
- 8:54 PM Changeset in webkit [49730] by
-
- 2 edits in trunk/WebKit/qt
[Qt] QGLauncher leaks WebPage object
https://bugs.webkit.org/show_bug.cgi?id=30465
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-16
Reviewed by Simon Hausmann.
Make 'SharedScene' to own 'WebPage' reference and delete it at its destructor.
- Api/qwebpage.cpp:
(QWebPage::view):
- Api/qwebpage_p.h:
- QGVLauncher/main.cpp:
(SharedScene::SharedScene):
(SharedScene::~SharedScene):
- 8:51 PM Changeset in webkit [49729] by
-
- 3 edits in trunk/WebKit/qt
[Qt] "dangling" pointer to qwebpage's view object can leads QGLauncher to crash
https://bugs.webkit.org/show_bug.cgi?id=30459
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-16
Reviewed by Simon Hausmann.
Remove all setView(ev->widget()) calls in QWebPage and QGWV event handling methods,
since QWebPageClient would do the trick.
- Api/qgraphicswebview.cpp:
(QGraphicsWebView::hoverMoveEvent):
- Api/qwebpage.cpp:
(QWebPagePrivate::mouseMoveEvent):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseDoubleClickEvent):
(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::wheelEvent):
(QWebPagePrivate::dragEnterEvent):
(QWebPagePrivate::dragLeaveEvent):
(QWebPagePrivate::dragMoveEvent):
- 8:35 PM Changeset in webkit [49728] by
-
- 4 edits in trunk/LayoutTests
Updated expected results of tests that give CONSOLE messages for
new verbose output.
- fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt:
- fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt:
- platform/mac/fast/dynamic/015-expected.txt:
- 8:10 PM Changeset in webkit [49727] by
-
- 3 edits12 adds in trunk
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
@charset rule after the first byte causes the rest of css to be ignored
https://bugs.webkit.org/show_bug.cgi?id=18265
Apparently we're supposed to tolerate whitespace before the charset
rule so folks can write code like this:
<style>
@charset "utf-8"
...
</style>
I'm told this is one of the top compatability problems in China.
Tests: fast/css/comment-before-charset-external.html
fast/css/comment-before-charset.html
fast/css/many-spaces-before-charset.html
fast/css/space-before-charset-external.html
fast/css/space-before-charset.html
- css/CSSGrammar.y:
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
@charset rule after the first byte causes the rest of css to be ignored
https://bugs.webkit.org/show_bug.cgi?id=18265
Test that we allow whitespace and comments before the charset rule.
These test results all match Firefox.
- fast/css/comment-before-charset-expected.txt: Added.
- fast/css/comment-before-charset-external-expected.txt: Added.
- fast/css/comment-before-charset-external.html: Added.
- fast/css/comment-before-charset.html: Added.
- fast/css/many-spaces-before-charset-expected.txt: Added.
- fast/css/many-spaces-before-charset.html: Added.
- fast/css/resources/comment-before-charset.css: Added.
- fast/css/resources/space-before-charset.css: Added.
- fast/css/space-before-charset-expected.txt: Added.
- fast/css/space-before-charset-external-expected.txt: Added.
- fast/css/space-before-charset-external.html: Added.
- fast/css/space-before-charset.html: Added.
- 7:31 PM Changeset in webkit [49726] by
-
- 29 edits in trunk
Roll out r49717 as it broke the build.
- 6:23 PM Changeset in webkit [49725] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Adam Roben.
Remove inspector tests from Windows Skipped list, because they pass locally
and the front-end changes are picked up by the bots.
- platform/win/Skipped:
- 6:20 PM Changeset in webkit [49724] by
-
- 2 edits in trunk/JavaScriptCore
Build fix: apparently we shouldn't export those symbols?
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-16
- JavaScriptCore.exp:
- 6:18 PM Changeset in webkit [49723] by
-
- 10 edits8 adds in trunk
WebCore: Fixes part of <http://webkit.org/b/30412>.
Web Inspector should get human readable DOM Exceptions.
Reviewed by Darin Adler.
Add a description field to ExceptionBase, and call it through
reportException which allows the user/developer to get a more detailed
and coherent error explanation through the Web Inspector.
This only applies to exceptions that come from a script on the page when
it is run. DOM Exceptions that come from the code run in the console, or DOM
exceptions that are caught and logged will come in a future patch.
Tests: inspector/uncaught-dom1-exception.html
inspector/uncaught-dom3-exception.html
inspector/uncaught-dom8-exception.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
- bindings/js/JSExceptionBase.cpp: Added.
(WebCore::toExceptionBase):
- bindings/js/JSExceptionBase.h: Added.
- dom/ExceptionBase.cpp:
(WebCore::ExceptionBase::ExceptionBase):
- dom/ExceptionBase.h:
(WebCore::ExceptionBase::description):
- dom/ExceptionCode.cpp:
(WebCore::):
(WebCore::getExceptionCodeDescription):
- dom/ExceptionCode.h:
LayoutTests: Fixes part of <http://webkit.org/b/30412>.
Web Inspector should get human readable DOM Exceptions.
Reviewed by Darin Adler.
Adds tests for output of uncaught exceptions to the Web Inspector
Console. Tests DOM exceptions 1, 3, and 8 (INDEX_SIZE_ERR, NOT_FOUND_ERR, and
HIERARCHY_REQUEST_ERR).
- inspector/uncaught-dom1-exception-expected.txt: Added.
- inspector/uncaught-dom1-exception.html: Added.
- inspector/uncaught-dom3-exception-expected.txt: Added.
- inspector/uncaught-dom3-exception.html: Added.
- inspector/uncaught-dom8-exception-expected.txt: Added.
- inspector/uncaught-dom8-exception.html: Added.
- 6:09 PM Changeset in webkit [49722] by
-
- 2 edits in trunk/JavaScriptCore
Build fix: export some symbols.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-16
- JavaScriptCore.exp:
- 6:06 PM Changeset in webkit [49721] by
-
- 30 edits in trunk/JavaScriptCore
structure typeinfo flags should be inherited.
https://bugs.webkit.org/show_bug.cgi?id=30468
Reviewed by Gavin Barraclough.
Add StructureFlag constant to the various JSC classes and use
it for the TypeInfo construction. This allows us to simply
accumulate flags by basing each classes StructureInfo on its parents.
- 5:45 PM Changeset in webkit [49720] by
-
- 2 edits in trunk/WebCore
Build fix: forgot to check in this #include.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-16
- bridge/runtime_root.h:
- 5:40 PM Changeset in webkit [49719] by
-
- 2 edits in trunk/WebKitSite
- coding/RefPtr.html: Minor revision, updating a link and tweaking
wording a bit in few places.
- 5:32 PM Changeset in webkit [49718] by
-
- 1 copy in tags/Safari-6531.21.3
New tag.
- 5:28 PM Changeset in webkit [49717] by
-
- 27 edits in trunk/JavaScriptCore
Fast for-in enumeration: Cache JSPropertyNameIterator; cache JSStrings
in JSPropertyNameIterator; inline more code.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-16
Reviewed by Oliver Hunt.
1.024x as fast on SunSpider (fasta: 1.43x as fast).
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetPropertyNames):
(JSC::BytecodeGenerator::emitNextPropertyName):
- bytecompiler/BytecodeGenerator.h: Added a few extra operands to
op_get_pnames and op_next_pname so that we can track iteration state
in the register file instead of in the JSPropertyNameIterator. (To be
cacheable, the JSPropertyNameIterator must be stateless.)
- interpreter/Interpreter.cpp:
(JSC::Interpreter::tryCachePutByID):
(JSC::Interpreter::tryCacheGetByID): Updated for rename to
"normalizePrototypeChain" and removal of "isCacheable".
(JSC::Interpreter::privateExecute): Updated for in-RegisterFile
iteration state tracking.
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_pnames): Updated for in-RegisterFile
iteration state tracking.
(JSC::JIT::emit_op_next_pname): Inlined code generation for op_next_pname.
- jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID): Updated for rename to
"normalizePrototypeChain" and removal of "isCacheable".
(JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
(JSC::): Added has_property and to_object stubs. Removed op_next_pname
stub, since has_property is all we need anymore.
- parser/Nodes.cpp:
(JSC::ForInNode::emitBytecode): Updated for in-RegisterFile
iteration state tracking.
- runtime/JSCell.h:
- runtime/JSObject.cpp:
(JSC::JSObject::getPropertyNames): Don't do caching at this layer
anymore, since we don't create a JSPropertyNameIterator at this layer.
- runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create): Do do caching at this layer.
(JSC::JSPropertyNameIterator::get): Updated for in-RegisterFile
iteration state tracking.
(JSC::JSPropertyNameIterator::markChildren): Mark our JSStrings.
- runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::size):
(JSC::JSPropertyNameIterator::setCachedStructure):
(JSC::JSPropertyNameIterator::cachedStructure):
(JSC::JSPropertyNameIterator::setCachedPrototypeChain):
(JSC::JSPropertyNameIterator::cachedPrototypeChain):
(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
(JSC::Structure::setEnumerationCache): Don't store iteration state in
a JSPropertyNameIterator. Do cache a JSPropertyNameIterator in a
Structure.
- runtime/JSValue.h:
(JSC::asCell):
- runtime/MarkStack.h: Make those mischievous #include gods happy.
- runtime/ObjectConstructor.cpp:
- runtime/Operations.h:
(JSC::normalizePrototypeChain): Renamed countPrototypeChainEntriesAndCheckForProxies
to normalizePrototypeChain, since it changes dictionary prototypes to
non-dictionary objects.
- runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
- runtime/PropertyNameArray.h:
(JSC::PropertyNameArrayData::PropertyNameArrayData):
(JSC::PropertyNameArray::data):
(JSC::PropertyNameArray::size):
(JSC::PropertyNameArray::begin):
(JSC::PropertyNameArray::end): Simplified some code here to help with
current and future refactoring.
- runtime/Protect.h:
- runtime/Structure.cpp:
(JSC::Structure::~Structure):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition): No need to clear
the enumeration cache with adding / removing properties without
transition. It is an error to add / remove properties without transition
once an object has been observed, and we can ASSERT to catch that.
- runtime/Structure.h:
(JSC::Structure::enumerationCache): Changed the enumeration cache to
hold a JSPropertyNameIterator.
- runtime/StructureChain.cpp:
- runtime/StructureChain.h:
(JSC::StructureChain::head): Removed StructureChain::isCacheable because
it was wrong-headed in two ways: (1) It gave up when a prototype was a
dictionary, but instead we want un-dictionary heavily accessed
prototypes; (2) It folded a test for hasDefaultGetPropertyNames() into
a generic test for "cacheable-ness", but hasDefaultGetPropertyNames()
is only releavant to for-in caching.
- 5:27 PM Changeset in webkit [49716] by
-
- 5 edits in branches/safari-4-branch/WebCore
Merge r48971.
- 5:27 PM Changeset in webkit [49715] by
-
- 8 edits in branches/safari-4-branch
Merge r48683.
- 5:27 PM Changeset in webkit [49714] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 5:20 PM Changeset in webkit [49713] by
-
- 3 edits5 adds in trunk
2009-10-16 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Transform layer gets stuck with the wrong transform after an animation ends
<rdar://problem/7311662>
Work around a CoreAnimation bug which causes an animated transform layer to
end up with a stale transform.
Test: compositing/animation/state-at-end-event-transform-layer.html
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::bug7311367Workaround): (WebCore::GraphicsLayerCA::removeAnimationFromLayer):
- 5:20 PM Changeset in webkit [49712] by
-
- 2 edits in trunk/WebKit/wx
wxMSW non-precomp headers build fix.
- 5:17 PM Changeset in webkit [49711] by
-
- 4 edits20 adds in trunk
2009-10-16 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
After running a transition with an end event listener, can't change the transform
https://bugs.webkit.org/show_bug.cgi?id=30454
Fix an issue where, if a document had any listener for webkitTransitionEnd or webkitAnimationEnd,
the animations would not get cleaned up correctly, which broke subsequent changes of transform.
Now, we always clean up the animations right after queuing up the end events.
Tests: animations/state-at-end-event.html
transitions/move-after-transition.html
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::onAnimationEnd):
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::onAnimationEnd):
- 5:11 PM Changeset in webkit [49710] by
-
- 3 edits in trunk/WebKit/mac
Reviewed by Anders Carlson.
Small code cleanup
- Plugins/WebBaseNetscapePluginView.mm: (WebHaltablePlugin::halt): Just call -[WebBaseNetscapePluginView halt]. (WebHaltablePlugin::restart): Just call -[WebBaseNetscapePluginView resumeFromHalt] (-[WebBaseNetscapePluginView halt]): (-[WebBaseNetscapePluginView resumeFromHalt]):
- WebView/WebView.mm: (_pluginViewForNode): Added a check if a render is a widget. This prevents a later assertion.
- 5:08 PM Changeset in webkit [49709] by
-
- 2 edits in trunk/WebCore
2009-10-15 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: Handle the Enter Key in the Elements Tree Hierarchy
https://bugs.webkit.org/show_bug.cgi?id=30428
TextNode => Edit Text Node
Has Attributes => Edit First Attribute
No Attributes => Start Editing New Attribute
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): handle the "Enter" key (WebInspector.ElementsTreeElement.prototype.set hovered): only add new attribute button on nodes with attributes (WebInspector.ElementsTreeElement.prototype._addNewAttribute): prevent moving backwards where there are no attributes (WebInspector.ElementsTreeElement.prototype._startEditingFromEvent): renamed to be clearer (WebInspector.ElementsTreeElement.prototype._startEditing): transition to the appropriate edit state for a tree element
- 5:04 PM Changeset in webkit [49708] by
-
- 4 edits in trunk/WebKitTools
2009-10-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue status bot should list which buildbot is blocking the queue
https://bugs.webkit.org/show_bug.cgi?id=30452
Add new methods and testing.
- Scripts/bugzilla-tool:
- Scripts/modules/buildbot.py:
- Scripts/modules/buildbot_unittest.py:
- 4:57 PM Changeset in webkit [49707] by
-
- 3 edits in trunk/WebKitTools
2009-10-16 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
run-webkit-tests fails when CWD is not inside a WebKit checkout
https://bugs.webkit.org/show_bug.cgi?id=30451
- Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
- Scripts/modules/scm_unittest.py:
- Remove use of original_path (we don't need to restore the CWD).
- Don't use '.' to find the webkit checkout, use file instead.
- 4:44 PM Changeset in webkit [49706] by
-
- 7 edits in trunk/WebCore
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Fix header indent style for FrameLoader and friends
https://bugs.webkit.org/show_bug.cgi?id=30430
- loader/FrameLoader.h: (WebCore::FrameLoader::frame): (WebCore::FrameLoader::policyChecker): (WebCore::FrameLoader::history): (WebCore::FrameLoader::notifier): (WebCore::FrameLoader::isLoadingMainResource): (WebCore::FrameLoader::documentLoader): (WebCore::FrameLoader::policyDocumentLoader): (WebCore::FrameLoader::provisionalDocumentLoader): (WebCore::FrameLoader::state): (WebCore::FrameLoader::client): (WebCore::FrameLoader::url): (WebCore::FrameLoader::isLoadingFromCachedPage): (WebCore::FrameLoader::committingFirstRealLoad): (WebCore::FrameLoader::committedFirstRealDocumentLoad): (WebCore::FrameLoader::creatingInitialEmptyDocument):
- loader/HistoryController.h: (WebCore::HistoryController::currentItem): (WebCore::HistoryController::provisionalItem):
- loader/PolicyCallback.h: (WebCore::PolicyCallback::request):
- loader/PolicyChecker.h: (WebCore::PolicyChecker::loadType): (WebCore::PolicyChecker::setLoadType): (WebCore::PolicyChecker::delegateIsDecidingNavigationPolicy): (WebCore::PolicyChecker::delegateIsHandlingUnimplementablePolicy):
- loader/RedirectScheduler.h:
- loader/ResourceLoadNotifier.h:
- 3:31 PM Changeset in webkit [49705] by
-
- 32 edits1 add in trunk
Add a Debug_All configuration to build entire stack as debug.
Change Debug_Internal to:
- stop using _debug suffix for all WebKit/Safari binaries
- not use _debug as a DLL naming suffix
- use non-debug C runtime lib.
Reviewed by Adam Roben.
- JavaScriptCore.vcproj/JavaScriptCore.make: Debug build in makefile should build Debug_All.
- JavaScriptCore.vcproj/JavaScriptCore.sln: Add Debug_All configuration.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add Debug_All configuration.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Renamed single configuration from "Release" to "all".
- JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Add Debug_All configuration.
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Add Debug_All configuration.
- JavaScriptCore.vcproj/jsc/jsc.vcproj: Add Debug_All configuration.
- JavaScriptCore.vcproj/testapi/testapi.vcproj: Add Debug_All configuration.
WebCore:
- WebCore.vcproj/QTMovieWin.vcproj: Add Debug_All configuration.
- WebCore.vcproj/WebCore.make: Debug build in makefile should build Debug_All.
- WebCore.vcproj/WebCore.sln: Add Debug_All configuration.
- WebCore.vcproj/WebCore.submit.sln: Add Debug_All configuration.
- WebCore.vcproj/WebCore.vcproj: Add Debug_All configuration.
- WebCore.vcproj/WebCoreGenerated.vcproj: Renamed single configuration from "Release" to "all".
WebKit/win:
- WebKit.vcproj/InterfacesGenerated.vcproj: Renamed single configuration from "Release" to "all".
- WebKit.vcproj/WebKit.make: Debug build in makefile should build Debug_All.
- WebKit.vcproj/WebKit.sln: Add Debug_All configuration.
- WebKit.vcproj/WebKit.submit.sln: Add Debug_All configuration.
- WebKit.vcproj/WebKit.vcproj:
Remove extraneous OutputDirectory/IntermediateDirectory in Debug_Cairo.
Add Debug_All configuration.
- WebKit.vcproj/WebKitGUID.vcproj: Add Debug_All configuration.
WebKitLibraries:
- win/tools/vsprops/debug_all.vsprops: Added.
Use debug C runtime library in debug_all.
Specify USE_DEBUG_SAFARI_THEME to get "_debug" suffix for debug_all.
- win/tools/vsprops/debug_internal.vsprops:
Don't specify debug C runtime library in debug_internal.
Don't specify _debug suffix for standard debug_internal builds.
WebKitTools:
- DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
- DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
- DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
Add missing debug.vsprops inherited property sheet.
Add Debug_All configuration.
- FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
- WinLauncher/WinLauncher.vcproj:
Removed extraneous definitions inherited from vsprops.
Add Debug_All configuration.
- 3:28 PM Changeset in webkit [49704] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Rolling out r49661 since it makes tests fail on GTK+ and Mac with Xiph plugin
- 3:07 PM Changeset in webkit [49703] by
-
- 3 edits in trunk/WebCore
2009-10-16 Dimitri Glazkov <Dimitri Glazkov>
No review, rolling out r49693, because it broke Chromium build.
http://trac.webkit.org/changeset/49693
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- 3:03 PM Changeset in webkit [49702] by
-
- 5 edits4 adds in trunk
2009-10-16 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Carlson.
Updated media resource selection algorithm to reflect latest HTML 5 specification.
- media/video-play-pause-exception-expected.txt:
- media/video-play-pause-exception.html:
- media/video-src-empty-expected.txt: Added.
- media/video-src-empty.html: Added.
- media/video-src-none-expected.txt: Added.
- media/video-src-none.html: Added.
2009-10-16 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Carlson.
Updated media resource selection algorithm to reflect latest HTML 5 specification.
Noticable changes:
- Elements with no source should have their network state set to NETWORK_EMPTY as opposed to NETWORK_NO_SOURCE
- Empty string ("") is now considered a valid URL resolving to the current page and will be loaded
Tests: media/video-src-empty.html
media/video-src-none.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::selectMediaResource): Updated code and comments to match spec.
- 2:33 PM Changeset in webkit [49701] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-10-16 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
Tests that the JavaScript array event.dataTransfer.types can be accessed
within an ondrop handler without causing a crash.
Although this issue has been resolved as of nightly r49550 we should add a
test case so that we can prevent a regression of this issue.
- fast/events/drag-and-drop-dataTransfer-types-nocrash-expected.txt: Added.
- fast/events/drag-and-drop-dataTransfer-types-nocrash.html: Added.
- 2:30 PM Changeset in webkit [49700] by
-
- 3 edits3 adds in trunk
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Insecure plug-ins don't trigger mixed content
https://bugs.webkit.org/show_bug.cgi?id=30431
- http/tests/security/mixedContent/insecure-plugin-in-iframe-expected.txt: Added.
- http/tests/security/mixedContent/insecure-plugin-in-iframe.html: Added.
- http/tests/security/mixedContent/resources/frame-with-insecure-plugin.html: Added.
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Insecure plug-ins don't trigger mixed content
https://bugs.webkit.org/show_bug.cgi?id=30431
Added the missing check.
Test: http/tests/security/mixedContent/insecure-plugin-in-iframe.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadPlugin):
- 2:26 PM Changeset in webkit [49699] by
-
- 4 edits in trunk/WebKit/win
Add SPI to restart a halted plug-in.
Part of <rdar://problem/7273354> Halted plug-ins should restart on
mouseover
https://bugs.webkit.org/show_bug.cgi?id=30151
Reviewed by Kevin Decker.
- Interfaces/IWebViewPrivate.idl:
Add restartHaltedPluginForNode().
- WebView.cpp:
(WebView::restartHaltedPluginForNode):
From the IDOMNode, query for the DOMNode. From the DOMNode, get the
WebCore::Node. Get the node's renderer, and check whether it is a
RenderWidget. If so, get its Widget, and check whether it's a
PluginView. If so, call PluginView::restart().
- WebView.h:
Declare restartHaltedPluginForNode().
- 2:21 PM Changeset in webkit [49698] by
-
- 2 edits in trunk/WebCore
2009-10-16 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Carlson.
Set autobuffer to true and schedule load in V8 audio element constructor.
Covered by existing tests.
- bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL): Set autobuffer to true and schedule load.
- 2:06 PM Changeset in webkit [49697] by
-
- 2 edits in trunk/WebCore
2009-10-16 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Seidel.
Remove FIXME in RenderMediaControlsChromium as bug was fixed upstream.
Covered by existing media layout tests.
- rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaSlider): Removed round() and FIXME.
- 2:01 PM BuildingOnWindows edited by
- Added note about error PRJ0002 - i.e. cannot find mspdb80.dll (diff)
- 1:57 PM Changeset in webkit [49696] by
-
- 3 edits in trunk/WebKit/mac
Reviewed by Anders Carlson.
Last part of:
<rdar://problem/7273354>
- WebView/WebView.mm: (_pluginViewForNode): Added with code extracted from _isNodeHaltedPlugin (+[WebView _isNodeHaltedPlugin:]): Made this a class method. (+[WebView _restartHaltedPluginForNode:]): Added. Restarts a plug-in
- WebView/WebViewPrivate.h: Added +_restartHaltedPluginForNode to header.
- 1:56 PM Changeset in webkit [49695] by
-
- 2 edits in trunk/WebCore
2009-10-16 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Seidel.
Fix Chromium media controls to render a disabled play button when the element is unintialized.
Covered by existing layout tests.
- rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaPlayButton): Include check for NETWORK_EMPTY to render disabled play button.
- 1:39 PM Changeset in webkit [49694] by
-
- 40 edits in trunk
Make typeinfo flags default to false
https://bugs.webkit.org/show_bug.cgi?id=30372
Reviewed by Gavin Barraclough.
Last part -- replace HasDefaultGetPropertyNames with OverridesGetPropertyNames
flag.
- 1:37 PM Changeset in webkit [49693] by
-
- 3 edits in trunk/WebCore
2009-10-16 Steven Knight <sgk@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=30447
Handle long link lines by building .idl-generated bindings in a
separate webcore_bindings library target. Avoid Visual Studio
dependency issues by building additional generated .cpp and .h files
in a separate webcore_bindings_sources target.
Chrome should still build and test successfully.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- 1:28 PM Changeset in webkit [49692] by
-
- 2 edits in trunk/WebCore
2009-10-16 Simon Fraser <Simon Fraser>
Reviewed by Eric Carlson.
Transform transitions that used to be accelerated are no longer so
https://bugs.webkit.org/show_bug.cgi?id=30453
The change in r49633, to not run accelerated animations/transitions on layers that
are not attached, broke accelerated transitions/animations in many cases where they start
as soon as the page loads. This change reverts the code that tests for the GraphicsLayer being
attached.
No test, because it's not possible from a test to know whether a transition is accelerated or not.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation): (WebCore::RenderLayerBacking::startTransition):
- 1:21 PM Changeset in webkit [49691] by
-
- 2 edits in trunk/LayoutTests
2009-10-16 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
LayoutTests/fast/loader/local-JavaScript-from-local.html times out in case of error.
https://bugs.webkit.org/show_bug.cgi?id=30434
- fast/loader/local-JavaScript-from-local.html:
- 11:46 AM Changeset in webkit [49690] by
-
- 3 edits in trunk/WebKitTools
check-webkit-style is wrong about indent checking in namespaces
in header files and a few other things
https://bugs.webkit.org/show_bug.cgi?id=30362
Patch by Carol Szabo <carol.szabo@nokia.com> on 2009-10-16
Reviewed by David Levin.
The few other things include:
+ check-webkit-style does not require spaces around the equal sign
inside 'if' statements and around binary operators that take
numeric literals.
+ check-webkit-style reports false errors for the / operator
when part of a filename in the #include directive.
- Scripts/modules/cpp_style.py:
Improved indentation checking and space checking around
binary operators. While the checks are still not perfect,
they are clearly better than before.
- Scripts/modules/cpp_style_unittest.py:
Added test cases for the newly supported checks and modified old
test cases to match the new guidelines
- 11:33 AM Changeset in webkit [49689] by
-
- 5 edits in trunk/WebKit/mac
Reviewed by Anders.
<rdar://problem/7273354>
- Plugins/WebBaseNetscapePluginView.h: Added _isHalted ivar and three new methods: -halt, -resumeFromHalt, and -isHalted
- Plugins/WebBaseNetscapePluginView.mm: (WebHaltablePlugin::halt): Call -halt instead of -stop. (WebHaltablePlugin::restart):Call -resumeFromHalt instead of -start. (-[WebBaseNetscapePluginView halt]): Added. Stop the plug-in, update _isHalted. (-[WebBaseNetscapePluginView resumeFromHalt]): Added. Start the plug-in, update _isHalted. (-[WebBaseNetscapePluginView isHalted]): Added.
- WebView/WebView.mm: (-[WebView _isNodeHaltedPlugin:]): Added. Queries a DOMNode to determine if it's a halted plug-in.
- WebView/WebViewPrivate.h: Added _isNodeHaltedPlugin.
- 11:23 AM Changeset in webkit [49688] by
-
- 6 edits in trunk
wxMSW build fix, we can't use the simple hash there because the PlatformModuleVersion
structure differs.
- 10:46 AM Changeset in webkit [49687] by
-
- 1 edit1 add in trunk/WebCore
2009-10-16 Adam Barth <abarth@webkit.org>
Unreviewed build fix. Add back MIMETypeRegistryChromium with the right
casing.
- platform/chromium/MIMETypeRegistryChromium.cpp: Added. (WebCore::MIMETypeRegistry::getMIMETypeForExtension): (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): (WebCore::MIMETypeRegistry::getMIMETypeForPath): (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding): (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedMediaMIMEType): (WebCore::MIMETypeRegistry::isJavaAppletMIMEType): (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): (WebCore::dummyHashSet): (WebCore::MIMETypeRegistry::getSupportedImageMIMETypes): (WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes): (WebCore::MIMETypeRegistry::getSupportedImageMIMETypesForEncoding): (WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes): (WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes):
- 10:41 AM Changeset in webkit [49686] by
-
- 2 edits1 delete in trunk/WebCore
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
MimeTypeRegistryChromium is mis-casen
https://bugs.webkit.org/show_bug.cgi?id=30441
Change the case of MimeTypeRegistryChromium to match other platforms.
- WebCore.gypi:
- platform/chromium/MIMETypeRegistryChromium.cpp: Copied from WebCore/platform/chromium/MimeTypeRegistryChromium.cpp.
- platform/chromium/MimeTypeRegistryChromium.cpp: Removed.
- 10:35 AM Changeset in webkit [49685] by
-
- 2 edits in trunk/WebCore
2009-10-16 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Change EmptyPluginHalterClient in SVGImage to be non-static, to
match changes made http://trac.webkit.org/changeset/49385.
https://bugs.webkit.org/show_bug.cgi?id=30403
Run the following layout test sequence:
LayoutTests/svg/W3C-SVG-1.1/struct-image-01-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-03-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-04-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-05-b.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-06-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-08-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-09-t.svg
LayoutTests/svg/W3C-SVG-1.1/struct-image-10-t.svg
LayoutTests/svg/carto.net/scrollbar.svg
LayoutTests/svg/carto.net/selectionlist.svg
selectionlist.svg should not crash.
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): Made EmptyPluginHalterClient non-static.
- 10:27 AM Changeset in webkit [49684] by
-
- 2 edits in trunk/WebCore
2009-10-16 Victor Wang <victorw@chromium.org>
Reviewed by David Levin.
Add beforeload event support to V8DOMWrapper
LayoutTests/fast/dom/beforeload/frame-before-load.html
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventToV8Object):
- 9:41 AM Changeset in webkit [49683] by
-
- 1 edit in trunk/WebCore/ChangeLog
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
MimeTypeRegistryChromium is mis-casen
https://bugs.webkit.org/show_bug.cgi?id=30441
Change the case of MimeTypeRegistryChromium to match other platforms.
- WebCore.gypi:
- platform/chromium/MIMETypeRegistryChromium.cpp: Copied from WebCore/platform/chromium/MimeTypeRegistryChromium.cpp.
- platform/chromium/MimeTypeRegistryChromium.cpp: Removed.
- 9:20 AM Changeset in webkit [49682] by
-
- 2 edits in trunk/WebCore
2009-10-16 Adam Barth <abarth@webkit.org>
Reviewed by Mark Rowe.
Chrome doesn't set Content-Type for file upload when the file extension
is not recognized
https://bugs.webkit.org/show_bug.cgi?id=30433
Apparently, getMIMETypeForPath is supposed to return
application/octet-stream when it doesn't have a better MIME type.
- platform/chromium/MimeTypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForPath):
- 8:58 AM Changeset in webkit [49681] by
-
- 4 edits in trunk
Pull out r49676 as it caused build breakges on Symbian
- 8:53 AM Changeset in webkit [49680] by
-
- 1 edit5 adds in trunk/LayoutTests
[Qt] Add empty skipped lists for the platform-specific results
Reviewed by Ariya Hidayat.
- platform/qt-linux/Skipped:
- platform/qt-mac/Skipped:
- platform/qt-win/Skipped:
- 8:45 AM Changeset in webkit [49679] by
-
- 3 edits1 add in trunk/JavaScriptCore
2009-10-16 Laszlo Gombos <Laszlo Gombos>
Reviewed by Simon Hausmann.
[Qt] Implement ExecutableAllocator for Symbian
https://bugs.webkit.org/show_bug.cgi?id=29946
Tested with YARR JIT enabled for Symbian;
This patch does not (yet) enable YARR JIT by default.
- JavaScriptCore.pri:
- jit/ExecutableAllocator.h:
- jit/ExecutableAllocatorSymbian.cpp: Added. (JSC::ExecutableAllocator::intializePageSize): (JSC::ExecutablePool::systemAlloc): (JSC::ExecutablePool::systemRelease):
- 7:35 AM BuildingQtOnWindows edited by
- (diff)
- 6:26 AM Changeset in webkit [49678] by
-
- 2 edits in trunk/LayoutTests
[Qt] Update outdated platform dependent expected file.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-16
Reviewed by Tor Arne Vestbø.
- platform/qt/editing/execCommand/toggle-compound-styles-expected.txt:
- 6:26 AM Changeset in webkit [49677] by
-
- 1 edit in trunk/WebCore/ChangeLog
Crash fix when loading NPAPI plugins on Qt/Mac
Reviewed by Ariya Hidayat.
There's no guarantee that the plist will be valid even if we
ask the plugin to create it. Crash obverved with iGetter.
- plugins/mac/PluginPackageMac.cpp:
- 6:18 AM Changeset in webkit [49676] by
-
- 4 edits in trunk
2009-10-16 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Need a way to inform the application when a Netscape plugin is created or deleted
https://bugs.webkit.org/show_bug.cgi?id=30179
Inform the application when a plugin is created or destroyed, but only if the
application registered for these notifications.
- plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::platformStart): (WebCore::PluginView::platformDestroy):
2009-10-16 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Need a way to inform the application when a Netscape plugin is created or deleted
https://bugs.webkit.org/show_bug.cgi?id=30179
Added "c" style static methods for the application to hook up for
receiving notifications when a plugin is created or destroyed.
- Api/qwebpage.cpp:
- 5:47 AM Changeset in webkit [49675] by
-
- 3 edits2 adds in trunk
2009-10-16 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
Added test case for testing navigator.language.
https://bugs.webkit.org/show_bug.cgi?id=29653
Different browsers may not return the exact same result.
Some examples here:
Safari 4 WinXP: "en-US"
Safari 4 Mac: "en-us"
Firefox 3 Mac/WinXP: "en-US"
Opera 9.64: "en"
Epiphany 2 GTK: "en"
Chrome 3 WinXP: "en-US"
The test case checks if the first two letters are "en"
when system locale is set to "en_US.iso88591".
- fast/js/navigator-language-expected.txt: Added.
- fast/js/navigator-language.html: Added.
2009-10-16 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
Default language translation should be determined by locale settings,
e.g., "en-US".
https://bugs.webkit.org/show_bug.cgi?id=29653
Test: fast/js/navigator-language.html
- platform/qt/Localizations.cpp: (WebCore::defaultLanguage):
- 3:58 AM QtWebKitPlugins edited by
- (diff)
- 3:53 AM NetscapePluginsOnMacNotes created by
- 3:42 AM QtWebKitPlugins edited by
- (diff)
- 3:35 AM Changeset in webkit [49674] by
-
- 2 edits in trunk/WebCore
Crash fix when loading NPAPI plugins on Qt/Mac
Reviewed by Ariya Hidayat.
There's no guarantee that the plist will be valid even if we
ask the plugin to create it. Crash obverved with iGetter.
- plugins/mac/PluginPackageMac.cpp:
- 1:02 AM QtWebKitPlugins edited by
- (diff)
- 12:53 AM QtWebKitPlugins created by
Oct 15, 2009:
- 11:46 PM Changeset in webkit [49673] by
-
- 2 edits in trunk/WebCore
Fix for Chromium/skia's implementation of canvas's isPointInPath().
https://bugs.webkit.org/show_bug.cgi?id=30402
Reviewed by David Levin.
Covered by LayoutTests/fast/canvas/pointInPath.html.
- platform/graphics/skia/SkiaUtils.cpp:
(WebCore::SkPathContainsPoint):
- 11:42 PM Changeset in webkit [49672] by
-
- 1 edit36 adds in trunk/WebKitTools
2009-10-15 Yuzo Fujishima <yuzo@google.com>
Reviewed by David Levin.
Add mod_pywebsocket to test Web Sockets.
http://code.google.com/p/pywebsocket/
https://bugs.webkit.org/show_bug.cgi?id=27490
- pywebsocket/COPYING: Added.
- pywebsocket/MANIFEST.in: Added.
- pywebsocket/README: Added.
- pywebsocket/example/echo_client.py: Added.
- pywebsocket/example/echo_wsh.py: Added.
- pywebsocket/mod_pywebsocket/init.py: Added.
- pywebsocket/mod_pywebsocket/dispatch.py: Added.
- pywebsocket/mod_pywebsocket/handshake.py: Added.
- pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
- pywebsocket/mod_pywebsocket/msgutil.py: Added.
- pywebsocket/mod_pywebsocket/standalone.py: Added.
- pywebsocket/mod_pywebsocket/util.py: Added.
- pywebsocket/setup.py: Added.
- pywebsocket/test/config.py: Added.
- pywebsocket/test/mock.py: Added.
- pywebsocket/test/run_all.py: Added.
- pywebsocket/test/test_dispatch.py: Added.
- pywebsocket/test/test_handshake.py: Added.
- pywebsocket/test/test_mock.py: Added.
- pywebsocket/test/test_msgutil.py: Added.
- pywebsocket/test/test_util.py: Added.
- pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
- pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
- pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
- pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
- pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
- pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
- pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
- pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
- 10:32 PM Changeset in webkit [49671] by
-
- 12 edits2 adds in trunk/WebCore
2009-10-15 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Factor ResourceLoadNotifier out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30379
These methods have virtually no interaction with the rest of
FrameLoader.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- dom/Document.cpp: (WebCore::Document::resourceRetrievedByXMLHttpRequest):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): (WebCore::ResourceLoadNotifier::ResourceLoadNotifier): (WebCore::ResourceLoadNotifier::activeDocumentLoader): (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest): (WebCore::ResourceLoadNotifier::willSendRequest): (WebCore::ResourceLoadNotifier::didReceiveResponse): (WebCore::ResourceLoadNotifier::didReceiveData): (WebCore::ResourceLoadNotifier::didFailToLoad): (WebCore::ResourceLoadNotifier::didLoadResourceByXMLHttpRequest): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::requestFromDelegate): (WebCore::ResourceLoadNotifier::didFinishLoad): (WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge): (WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge): (WebCore::ResourceLoadNotifier::dispatchAssignIdentifierToInitialRequest): (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
- loader/FrameLoader.h: (WebCore::FrameLoader::notifier):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::receivedError):
- loader/ResourceLoadNotifier.cpp: Added. (WebCore::ResourceLoadNotifier::ResourceLoadNotifier): (WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge): (WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge): (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest): (WebCore::ResourceLoadNotifier::willSendRequest): (WebCore::ResourceLoadNotifier::didReceiveResponse): (WebCore::ResourceLoadNotifier::didReceiveData): (WebCore::ResourceLoadNotifier::didFinishLoad): (WebCore::ResourceLoadNotifier::didFailToLoad): (WebCore::ResourceLoadNotifier::didLoadResourceByXMLHttpRequest): (WebCore::ResourceLoadNotifier::dispatchAssignIdentifierToInitialRequest): (WebCore::ResourceLoadNotifier::dispatchWillSendRequest): (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse): (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength): (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading): (WebCore::ResourceLoadNotifier::activeDocumentLoader):
- loader/ResourceLoadNotifier.h: Added.
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::didFinishLoadingOnePart): (WebCore::ResourceLoader::didFail): (WebCore::ResourceLoader::didCancel): (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
- 10:19 PM Changeset in webkit [49670] by
-
- 2 edits in trunk/WebCore
2009-10-15 Roland Steiner <rolandsteiner@google.com>
Reviewed by Darin Fisher.
Bug 30427 - Remove unneeded methods in ChromiumDataObject
(https://bugs.webkit.org/show_bug.cgi?id=30427)
Remove no longer needed methods from ChromiumDataObject.
No new tests (no functional change)
- platform/chromium/ChromiumDataObject.h:
- 10:03 PM Changeset in webkit [49669] by
-
- 3 edits in trunk/WebKitTools
2009-10-15 James Robinson <jamesr@google.com>
Reviewed by David Levin.
Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
- Scripts/modules/cpp_style.py:
- Scripts/modules/cpp_style_unittest.py:
- 6:27 PM Changeset in webkit [49668] by
-
- 4 edits18 deletes in trunk
2009-10-15 Daniel Bates <dbates@webkit.org>
No review, rolling out r49644.
http://trac.webkit.org/changeset/49644
We need to think about this change some more. See bug #30418
for more details.
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::canSetBaseElementURL): (WebCore::XSSAuditor::findInRequest):
- page/XSSAuditor.h:
2009-10-15 Daniel Bates <dbates@webkit.org>
No review, rolling out r49644.
http://trac.webkit.org/changeset/49644
- http/tests/security/xssAuditor/base-href-comment-expected.txt: Removed.
- http/tests/security/xssAuditor/base-href-comment.html: Removed.
- http/tests/security/xssAuditor/iframe-javascript-url-comment-expected.txt: Removed.
- http/tests/security/xssAuditor/iframe-javascript-url-comment.html: Removed.
- http/tests/security/xssAuditor/img-onerror-HTML-comment-expected.txt: Removed.
- http/tests/security/xssAuditor/img-onerror-HTML-comment.html: Removed.
- http/tests/security/xssAuditor/img-onerror-comment-expected.txt: Removed.
- http/tests/security/xssAuditor/img-onerror-comment.html: Removed.
- http/tests/security/xssAuditor/object-tag-comment-expected.txt: Removed.
- http/tests/security/xssAuditor/object-tag-comment.html: Removed.
- http/tests/security/xssAuditor/resources/echo-before-image.pl: Removed.
- http/tests/security/xssAuditor/resources/echo-head-base-href-comment.pl: Removed.
- http/tests/security/xssAuditor/script-tag-comment-HTML-entity-expected.txt: Removed.
- http/tests/security/xssAuditor/script-tag-comment-HTML-entity.html: Removed.
- http/tests/security/xssAuditor/script-tag-comment-expected.txt: Removed.
- http/tests/security/xssAuditor/script-tag-comment.html: Removed.
- http/tests/security/xssAuditor/script-tag-with-source-comment-expected.txt: Removed.
- http/tests/security/xssAuditor/script-tag-with-source-comment.html: Removed.
- 4:44 PM Changeset in webkit [49667] by
-
- 1 edit2 adds in trunk/LayoutTests
Rubber-stamped by Adele Peterson.
Update Windows expected results after http://trac.webkit.org/changeset/49619.
- platform/win/fast/inline: Added.
- platform/win/fast/inline/dirtyLinesForInline-expected.txt: Added.
- 4:22 PM Changeset in webkit [49666] by
-
- 8 edits in trunk
Add SPI to determine whether a node is a halted plug-in.
Part of <rdar://problem/7273354> Halted plug-ins should restart on
mouseover
https://bugs.webkit.org/show_bug.cgi?id=30151
Reviewed by Darin Adler.
WebCore:
- plugins/PluginView.cpp:
(WebCore::PluginView::PluginView):
Initialize m_isHalted.
- plugins/PluginView.h:
(WebCore::PluginView::isHalted):
Return m_isHalted.
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::halt):
Set m_isHalted to true.
(WebCore::PluginView::restart):
clear m_isHalted.
WebKit/win:
- Interfaces/IWebViewPrivate.idl:
Add isNodehaltedPlugin().
- WebView.cpp:
(WebView::isNodeHaltedPlugin):
From the IDOMNode, query for the DOMNode. From the DOMNode, get the
WebCore::Node. Get the node's renderer, and check whether it is a
RenderWidget. If so, get its Widget, and check whether it's a
PluginView. If so, return the result of PluginView::isHalted().
- WebView.h:
Declare isNodeHaltedPlugin().
- 4:17 PM Changeset in webkit [49665] by
-
- 4 edits in trunk
2009-10-15 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[GTK] marshal stamp files are not cleaned after a distclean
https://bugs.webkit.org/show_bug.cgi?id=30156
Add stamp-po to CLEANFILES.
- GNUmakefile.am:
2009-10-15 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[GTK] marshal stamp files are not cleaned after a distclean
https://bugs.webkit.org/show_bug.cgi?id=30156
Add the stamp files directly to cleanfiles. Also rearrange the
variable declarations so we don't miss any files that need to be
cleaned up during the clean targets.
- GNUmakefile.am:
- 4:00 PM Changeset in webkit [49664] by
-
- 2 edits in trunk/WebKitTools
Fixes <http://webkit.org/b/30411>.
REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
Reviewed by Adam Roben.
Added a check for isChromium() in pdevenv, and pass /useenv if we are not
building Chromium.
- Scripts/pdevenv:
- 2:55 PM Changeset in webkit [49663] by
-
- 2 edits in trunk/LayoutTests
2009-10-15 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: skip inspector tests on windows until
incremental build catches frontend files.
- platform/win/Skipped:
- 2:54 PM Changeset in webkit [49662] by
-
- 2 edits in trunk/WebCore
2009-10-15 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Oliver Hunt.
Change JSC::HasNonDefaultMark to OverridesMarkChildren in createStructure function.
- bridge/qt/qt_runtime.h: (JSC::Bindings::QtRuntimeMethod::createStructure):
- 2:53 PM Changeset in webkit [49661] by
-
- 2 edits in trunk/LayoutTests
2009-10-15 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Darin Adler.
Fix media layout test file ordering so both branded and unbranded builds of Chromium will pass layout tests.
- media/media-file.js: Fixed file ordering.
- 2:51 PM Changeset in webkit [49660] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 2:50 PM Changeset in webkit [49659] by
-
- 1 copy in tags/Safari-6531.21.1
New tag.
- 2:39 PM Changeset in webkit [49658] by
-
- 2 edits in branches/safari-4-branch/JavaScriptCore
Merge r46777.
- 2:37 PM Changeset in webkit [49657] by
-
- 2 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Update the wxPython simple.py sample to match current wxWebKit API.
https://bugs.webkit.org/show_bug.cgi?id=30406
- 2:31 PM Changeset in webkit [49656] by
-
- 2 edits in trunk/LayoutTests
2009-10-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Prevent subsequent tests from failing upon inspector
test timeout.
- inspector/evaluate-in-frontend.js: (onload.setTimeout):
- 2:30 PM Changeset in webkit [49655] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 2:27 PM Changeset in webkit [49654] by
-
- 3 edits1 add in trunk/WebKitTools
Reviewed by Kevin Ollivier.
Add Mac package building scripts for wx.
https://bugs.webkit.org/show_bug.cgi?id=30405
- 2:11 PM Changeset in webkit [49653] by
-
- 2 edits in trunk/WebKit/mac
2009-10-15 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
<rdar://problem/7306052> Fullscreen max/min volume buttons non-functional
- WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindowController windowDidLoad]): Set volume buttons target and action. (-[WebVideoFullscreenHUDWindowController decrementVolume:]): New, decrement the volume by 10%. (-[WebVideoFullscreenHUDWindowController incrementVolume:]): New, increment the volume by 10%.
- 2:01 PM Changeset in webkit [49652] by
-
- 2 edits19 adds in trunk/LayoutTests
2009-10-15 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Eric Seidel.
[Gtk][Layout tests] Generate results for dom tests
https://bugs.webkit.org/show_bug.cgi?id=29893
Add results for dom tests and enable these tests in the Skipped.
- platform/gtk/Skipped:
- platform/gtk/dom/xhtml/level3/core/canonicalform08-expected.txt: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform08-expected.txt.
- platform/gtk/dom/xhtml/level3/core/canonicalform09-expected.txt: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform09-expected.txt.
- platform/gtk/dom/xhtml/level3/core/documentgetinputencoding03-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/entitygetinputencoding02-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/entitygetxmlversion02-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri05-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri07-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri09-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri10-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri11-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri15-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri17-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodegetbaseuri18-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.txt: Added.
- platform/gtk/dom/xhtml/level3/core/nodelookupprefix19-expected.txt: Added.
- 1:39 PM Changeset in webkit [49651] by
-
- 7 edits2 adds in trunk
2009-10-15 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=24731
And
rdar://problem/5015961
Implements support for DHTML drag-and-drop operations (i.e. ondragstart, ondragend)
in the Windows build so that it conforms to the Mac OS X build. Hence, dropEffect is
correctly set.
The WebView and WebDropSource drag-and-drop functions, as called by function
DoDragDrop in its event loop, neither used the drop effect as specified by
event.dataTransfer.dropEffect nor respected event.dataTransfer.effectsAllowed.
Instead, these functions defaulted to some hardcoded drop effect and set of
allowed drop effects, respectively.
Tests: fast/events/drag-and-drop.html
- WebCoreSupport/WebDragClient.cpp: (WebDragClient::startDrag):
- WebDropSource.cpp: (WebDropSource::QueryContinueDrag): Moved call to EventHandler::dragSourceEndedAt into method WebDragClient::startDrag.
- WebDropSource.h:
- WebView.cpp: (WebView::keyStateToDragOperation): Fixes <rdar://problem/5015961>. Determines appropriate drop effect from state of keyboard and allowed effects m_page->dragController()->sourceDragOperation(). (WebView::DragEnter): (WebView::DragOver): (WebView::Drop):
- WebView.h:
2009-10-15 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=24731
And
rdar://problem/5015961
Tests that DHTML drag-and-drop works correctly.
Note, this test fails when effectAllowed == "uninitialized" because
this effect has not been implemented yet (see bug #30291).
- fast/events/drag-and-drop-expected.txt: Added.
- fast/events/drag-and-drop.html: Added.
- 1:34 PM Changeset in webkit [49650] by
-
- 1 edit1 add in trunk/WebCore
2009-10-15 Pavel Feldman <pfeldman@chromium.org>
Not reviewed - build fix.
Web Inspector: add file missing in r49648
- inspector/front-end/TestController.js: Added. (WebInspector.TestController): (WebInspector.TestController.prototype.waitUntilDone): (WebInspector.TestController.prototype.notifyDone): (WebInspector.evaluateForTestInFrontend):
- 12:55 PM Changeset in webkit [49649] by
-
- 45 edits in trunk
Make typeinfo flags default to false
https://bugs.webkit.org/show_bug.cgi?id=30372
Reviewed by Darin Adler
Part 2 -- Reverse the TypeInfo HasDefaultMark flag to OverridesMarkChildren, etc
- 12:51 PM Changeset in webkit [49648] by
-
- 6 edits in trunk/WebCore
2009-10-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: introduce test controller with waitUntilDone
on frontend side.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/TestController.js: Added. (WebInspector.TestController): (WebInspector.TestController.prototype.waitUntilDone): (WebInspector.TestController.prototype.notifyDone): (WebInspector.evaluateForTestInFrontend):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
- 12:28 PM Changeset in webkit [49647] by
-
- 2 edits in trunk/WebKit/gtk
2009-10-15 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Protect WebSocket calls in case the feature is not compiled in.
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
- 12:28 PM Changeset in webkit [49646] by
-
- 4 edits in trunk/LayoutTests
2009-10-15 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
Rebaseline tests after changes made in r49405.
- platform/gtk/editing/execCommand/4916541-expected.txt: Rebaseline.
- platform/gtk/editing/execCommand/5138441-expected.txt: Ditto.
- platform/gtk/editing/execCommand/5481523-expected.txt: Ditto.
- 12:11 PM Changeset in webkit [49645] by
-
- 2 edits in trunk/LayoutTests
2009-10-15 Xan Lopez <xlopez@igalia.com>
Remove obsolete test from Skipped list.
- platform/gtk/Skipped:
- 12:04 PM Changeset in webkit [49644] by
-
- 4 edits18 adds in trunk
2009-10-15 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Fixes an issue in which injecting an inline event handler whose value ends in a single-line
JavaScript comment can bypass the XSSAuditor. Similarly fixes this issue with respect to
the HTML Base element, HTML Object element, inline and external script tags, and
JavaScript multi-line variants of all of these attacks.
Tests: http/tests/security/xssAuditor/base-href-comment.html
http/tests/security/xssAuditor/iframe-javascript-url-comment.html
http/tests/security/xssAuditor/img-onerror-HTML-comment.html
http/tests/security/xssAuditor/img-onerror-comment.html
http/tests/security/xssAuditor/object-tag-comment.html
http/tests/security/xssAuditor/script-tag-comment-HTML-entity.html
http/tests/security/xssAuditor/script-tag-comment.html
http/tests/security/xssAuditor/script-tag-with-source-comment.html
- page/XSSAuditor.cpp: Added constant minAttackLength. (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canEvaluateJavaScriptURL): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject): (WebCore::XSSAuditor::canSetBaseElementURL): (WebCore::XSSAuditor::findInRequest): Added parameter context. Only looks at up to minAttackLength of script code plus context (if any).
- page/XSSAuditor.h:
2009-10-15 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Tests that inline event handlers whose value ends in a single-line JavaScript
comment cannot bypass the XSSAuditor. Also tests that the XSSAuditor prevents
similar attack vectors with respect to the HTML Base element, HTML Object
element, and external JavaScripts.
- http/tests/security/xssAuditor/base-href-comment-expected.txt: Added.
- http/tests/security/xssAuditor/base-href-comment.html: Added.
- http/tests/security/xssAuditor/iframe-javascript-url-comment-expected.txt: Added.
- http/tests/security/xssAuditor/iframe-javascript-url-comment.html: Added.
- http/tests/security/xssAuditor/img-onerror-HTML-comment-expected.txt: Added.
- http/tests/security/xssAuditor/img-onerror-HTML-comment.html: Added.
- http/tests/security/xssAuditor/img-onerror-comment-expected.txt: Added.
- http/tests/security/xssAuditor/img-onerror-comment.html: Added.
- http/tests/security/xssAuditor/object-tag-comment-expected.txt: Added.
- http/tests/security/xssAuditor/object-tag-comment.html: Added.
- http/tests/security/xssAuditor/resources/echo-before-image.pl: Added.
- http/tests/security/xssAuditor/resources/echo-head-base-href-comment.pl: Added.
- http/tests/security/xssAuditor/script-tag-comment-HTML-entity-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-comment-HTML-entity.html: Added.
- http/tests/security/xssAuditor/script-tag-comment-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-comment.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-comment-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source-comment.html: Added.
- 11:42 AM Changeset in webkit [49643] by
-
- 5 edits in trunk
WebKit/gtk
2009-10-15 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
Add a settings to enable support for experimental Web Sockets.
Currently this comes in handy in layout tests.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
WebKitTools
2009-10-15 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha.
Enable Web Sockets support when running layout tests.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- 11:21 AM Changeset in webkit [49642] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Make QGLauncher's WebPage class constructor to get a QObject* as parent (not QWidget*).
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-15
Rubberstamped by Tor Arne.
- QGVLauncher/main.cpp:
(WebPage::WebPage):
- 11:16 AM Changeset in webkit [49641] by
-
- 12 edits in trunk/WebCore
2009-10-08 Adam Langley <agl@google.com>
Reviewed by Eric Seidel.
Currently, Skia clip paths are 1-bit. This patch makes our path
clipping anti-aliased for non-canvas drawing.
http://code.google.com/p/chromium/issues/detail?id=5927
https://bugs.webkit.org/show_bug.cgi?id=28820
http://www.imperialviolet.org/2009/09/02/anti-aliased-clipping.html
Already covered by layout tests. New baselines will be needed in the
Chromium tree.
(Reland. First landed in r49329, reverted in r49330 due to Windows
build break)
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::clip):
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::canvasClip): (WebCore::GraphicsContext::clipPath):
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::clipPathAntiAliased): (PlatformContextSkia::restore): (PlatformContextSkia::applyAntiAliasedClipPaths):
- platform/graphics/skia/PlatformContextSkia.h:
- platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::canvasClip):
- platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::canvasClip):
- 10:55 AM Changeset in webkit [49640] by
-
- 1 edit1 add in trunk/LayoutTests
Rubber-stamped by Adele Peterson.
Add click-focus-anchor expected results on Windows, to make up for
the wonky way Windows finds its expected results.
- platform/win/fast/events/click-focus-anchor-expected.txt: Added.
- 10:53 AM Changeset in webkit [49639] by
-
- 2 edits in trunk
2009-10-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Help text fix - Web Sockets default is no, not yes.
- configure.ac:
- 10:42 AM Changeset in webkit [49638] by
-
- 2 edits in trunk/WebKitTools
2009-10-15 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Need to initialize event.button.button, since in most cases a
button number is not passed as an argument.
- DumpRenderTree/gtk/EventSender.cpp: (mouseDownCallback): (mouseUpCallback):
- 10:33 AM Changeset in webkit [49637] by
-
- 1 edit4 adds in trunk/LayoutTests
2009-10-15 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Adam Treat.
[Qt] Add expected files for passing http tests.
- platform/qt/http/tests/local/file-url-sent-as-referer-expected.txt: Added.
- platform/qt/http/tests/uri/css-href-expected.txt: Added.
- 10:32 AM Changeset in webkit [49636] by
-
- 4 edits in trunk
2009-10-15 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7295738> No way to mute/unmute a movie in full screen video mode
- WebCore.Video.exp: Export muted and setMute.
2009-10-15 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7295738> No way to mute/unmute a movie in full screen video mode
- WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindowController setVolume:]): Unmute movie before changing volume.
- 10:26 AM Changeset in webkit [49635] by
-
- 1 edit7 adds in trunk/LayoutTests
2009-10-15 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Adam Treat.
[Qt] Add expected files for passing svg tests.
- platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt: Added.
- platform/qt/svg/custom/mask-with-default-value-expected.txt: Added.
- platform/qt/svg/filters/feComposite-expected.txt: Added.
- platform/qt/svg/filters/feGaussianBlur-expected.txt: Added.
- platform/qt/svg/filters/feMerge-wrong-input-expected.txt: Added.
- platform/qt/svg/filters/sourceAlpha-expected.txt: Added.
- platform/qt/svg/filters/subRegion-in-userSpace-expected.txt: Added.
- 10:14 AM Changeset in webkit [49634] by
-
- 3 edits in trunk/WebKit/qt
[Qt] QGLauncher crashes while closing a window
https://bugs.webkit.org/show_bug.cgi?id=30385
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-15
Reviewed by Tor Arne.
Set page's pageClient reference to '0' at QGWV deletion.
- Api/qgraphicswebview.cpp:
(QGraphicsWebView::~QGraphicsWebView):
- tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(WebPage::WebPage):
(WebPage::aborting):
(tst_QGraphicsWebView::crashOnViewlessWebPages):
- 9:52 AM Changeset in webkit [49633] by
-
- 7 edits3 adds in trunk
2009-10-15 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Transitions fail to run sometimes
https://bugs.webkit.org/show_bug.cgi?id=26770
Fix an issue where we could attempt to start accelerated animations or transitions on
GraphicsLayer that were not rooted (because of visibility:hidden), which would leave
the AnimationController's m_waitingForResponse flag in a state that killed subsequent
software transitions.
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::AnimationControllerPrivate): (WebCore::AnimationControllerPrivate::endAnimationUpdate): (WebCore::AnimationControllerPrivate::receivedStartTimeResponse): (WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList): (WebCore::AnimationControllerPrivate::startTimeResponse):
- page/animation/AnimationControllerPrivate.h: Make some methods non-inline for ease of debugging (these are not hot methods). Rename m_waitingForAResponse to m_waitingForResponse.
- platform/graphics/GraphicsLayer.h:
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::hasAncestor): New method to report whether the receiver has the given layer as an ancestor. Used for checking whether a layer is rooted.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation): (WebCore::RenderLayerBacking::startTransition): Don't try to start accelerated animations or transitions on non-rooted GraphicsLayers.
- 9:50 AM Changeset in webkit [49632] by
-
- 5 edits in trunk/WebCore
2009-10-15 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Refactor ProfilesPanel to support multiple profile types
Data describing different profile types are now stored in distinct objects.
https://bugs.webkit.org/show_bug.cgi?id=30332
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/ProfileView.js: (WebInspector.CPUProfileView.profileCallback): (WebInspector.CPUProfileView): (WebInspector.CPUProfileView.prototype._sortData): (WebInspector.CPUProfileType): (WebInspector.CPUProfileType.prototype.get buttonTooltip): (WebInspector.CPUProfileType.prototype.get buttonStyle): (WebInspector.CPUProfileType.prototype.buttonClicked): (WebInspector.CPUProfileType.prototype.setRecordingProfile): (WebInspector.CPUProfile): (WebInspector.CPUProfile.prototype.get title): (WebInspector.CPUProfile.prototype.get uid): (WebInspector.CPUProfile.prototype.get head): (WebInspector.CPUProfile.prototype.createView): (WebInspector.CPUProfile.prototype.viewForProfile):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfileType): (WebInspector.ProfileType.prototype.get buttonTooltip): (WebInspector.ProfileType.prototype.get buttonStyle): (WebInspector.ProfileType.prototype.get buttonCaption): (WebInspector.ProfileType.prototype.get id): (WebInspector.ProfileType.prototype.get name): (WebInspector.ProfileType.prototype.buttonClicked): (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.get statusBarItems.clickHandler): (WebInspector.ProfilesPanel.prototype.get statusBarItems): (WebInspector.ProfilesPanel.prototype.reset): (WebInspector.ProfilesPanel.prototype.registerProfileType): (WebInspector.ProfilesPanel.prototype._makeKey): (WebInspector.ProfilesPanel.prototype.addProfileHeader): (WebInspector.ProfilesPanel.prototype.showProfile): (WebInspector.ProfilesPanel.prototype.getProfileType): (WebInspector.ProfilesPanel.prototype.showProfileForURL): (WebInspector.ProfilesPanel.prototype.updateProfileTypeButtons): (WebInspector.ProfilesPanel.prototype.displayTitleForProfileLink): (WebInspector.ProfilesPanel.prototype.get searchableViews): (WebInspector.ProfilesPanel.prototype._updateInterface):
- inspector/front-end/inspector.js: (WebInspector._createPanels): (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector.addProfileHeader): (WebInspector.setRecordingProfile): (WebInspector.linkifyStringAsFragment): (WebInspector.showProfileForURL):
- 9:46 AM Changeset in webkit [49631] by
-
- 3 edits in trunk/LayoutTests
2009-10-15 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: remove timer-related logs from the previously
submitted test.
- inspector/console-tests-expected.txt:
- inspector/console-tests.html:
- 9:21 AM Changeset in webkit [49630] by
-
- 2 edits in trunk/WebKitTools
wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
the OS if none was explicitly set.
- 9:16 AM Changeset in webkit [49629] by
-
- 11 edits in trunk
2009-10-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Enable inspector layout tests.
WebCore:
- inspector/InspectorController.cpp: (WebCore::InspectorController::evaluateForTestInFrontend):
LayoutTests:
- inspector/elements-panel-structure-expected.txt:
- inspector/elements-panel-structure.html:
- inspector/evaluate-in-frontend.js: (evaluateInWebInspector): (window.didEvaluateForTestInFrontend):
- platform/mac-leopard/Skipped:
- platform/mac-snowleopard/Skipped:
- platform/mac-tiger/Skipped:
- platform/mac/Skipped:
- platform/win/Skipped:
- 8:31 AM Changeset in webkit [49628] by
-
- 2 edits in trunk/LayoutTests
2009-10-15 Xan Lopez <xlopez@igalia.com>
Skip new SVG tests without expected results for GTK+.
- platform/gtk/Skipped:
- 7:56 AM Changeset in webkit [49627] by
-
- 3 edits in trunk/WebKit/gtk
2009-10-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
page transition may crash webkit
https://bugs.webkit.org/show_bug.cgi?id=29890
There are actually cases in which a resource may be asked using
webkit_web_view_get_resource after a new load has already been
started, so protect ourselves from crashes in this case.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFinishLoading):
- webkit/webkitwebview.cpp: (webkit_web_view_get_resource):
- 7:46 AM Changeset in webkit [49626] by
-
- 2 edits in trunk/WebCore
2009-10-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
[GStreamer] READY state doesn't mean "enough data"
https://bugs.webkit.org/show_bug.cgi?id=30003
STATE_READY means MediaPlayer::HaveNothing
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::updateStates):
- 7:35 AM Changeset in webkit [49625] by
-
- 2 edits in trunk/LayoutTests
2009-10-15 Xan Lopez <xlopez@igalia.com>
Skip a couple of tests that need support for dumpEditingCallbacks.
- platform/gtk/Skipped:
- 7:31 AM Changeset in webkit [49624] by
-
- 2 edits in trunk/WebCore
2009-10-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
implement cancelLoad
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::cancelLoad):
- 7:16 AM Changeset in webkit [49623] by
-
- 2 edits in trunk/WebCore
2009-10-15 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Fix race condition, leading to a deadlock
- platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_timeout_func): (webkit_video_sink_render): (unlock_buffer_mutex): (webkit_video_sink_unlock): (webkit_video_sink_unlock_stop): (webkit_video_sink_stop): (webkit_video_sink_start): (webkit_video_sink_class_init): Fix race condition in unlock/render that would lead to deadlocks.
- 6:25 AM Changeset in webkit [49622] by
-
- 2 edits in trunk/WebCore
2009-10-15 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Check if caps are valid before parsing them
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::duration): Check if caps are valid before parsing them in ::naturalSize(). This prevents assertions if the natural size should be calculated before the video caps are negotiated.
- 6:09 AM Changeset in webkit [49621] by
-
- 3 edits in trunk/WebCore
2009-10-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=30006
[GStreamer] Unnecessary checks for Messages types in callbacks
refactored gst message callbacks into a single one
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): (WebCore::do_gst_init): (WebCore::MediaPlayerPrivate::duration):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- 5:58 AM Changeset in webkit [49620] by
-
- 1 edit in trunk/WebCore/plugins/mac/PluginViewMac.cpp
Fix the Qt build on Mac OS X
- 5:49 AM Changeset in webkit [49619] by
-
- 5 edits1 add in trunk
2009-10-15 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Adele Peterson.
Change behavior so that <a> element is always mouse-focusable.
- fast/events/click-focus-anchor-expected.txt:
- fast/events/click-focus-anchor.html:
2009-10-15 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Adele Peterson.
Anchor elements should be mouse focusable regardless isLink flag.
https://bugs.webkit.org/show_bug.cgi?id=26856
- html/HTMLAnchorElement.cpp:
- html/HTMLAnchorElement.h:
- 5:41 AM Changeset in webkit [49618] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Make context menu to work in QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=30336
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-13
Reviewed by Simon Hausmann.
- Api/qgraphicswebview.cpp:
(QGraphicsWebView::event):
- 5:32 AM Changeset in webkit [49617] by
-
- 2 edits in trunk/WebCore
Not reviewed. Sort XCode project file.
- 3:44 AM QtWebKitContrib edited by
- (diff)
- 3:41 AM QtWebKitContrib edited by
- (diff)
- 3:40 AM QtWebKitContrib edited by
- (diff)
- 3:35 AM BuildingQtOnLinux edited by
- merging install line into a single one and adding the required … (diff)
- 2:40 AM Changeset in webkit [49616] by
-
- 3 edits4 adds in trunk
2009-10-15 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Dave Hyatt.
Return correct shorthand property name for
background-repeat-x, background-repeat-y, background-position-x,
background-position-y, -webkit-mask-position-x, -webkit-mask-position-y,
-webkit-mask-repeat-x, -webkit-mask-repeat-y.
Test: fast/backgrounds/repeat/background-repeat-shorthand.html
WebCore
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
LayoutTests:
- fast/backgrounds/repeat/background-repeat-shorthand-expected.txt: Added.
- fast/backgrounds/repeat/background-repeat-shorthand.html: Added.
- fast/backgrounds/repeat/resources/background-repeat-shorthand.css: Added.
- fast/backgrounds/repeat/resources/background-repeat-shorthand.js: Added. (getShorthand):
- 2:31 AM Changeset in webkit [49615] by
-
- 14 edits in trunk/WebCore
2009-10-14 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Migrate profiles to the injected script-based schema.
- bindings/js/JSInspectorBackendCustom.cpp:
- bindings/v8/custom/V8CustomBinding.h:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getProfileHeaders): (WebCore::InspectorBackend::getProfile):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::getProfileHeaders): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::createProfileHeader):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addProfileHeader): (WebCore::InspectorFrontend::didGetProfileHeaders): (WebCore::InspectorFrontend::didGetProfile):
- inspector/InspectorFrontend.h:
- inspector/JavaScriptProfileNode.cpp: (WebCore::ProfileNodeClass):
- inspector/front-end/ProfileView.js: (WebInspector.ProfileView.profileCallback): (WebInspector.ProfileView): (WebInspector.ProfileView.prototype._mouseDownInDataGrid): (WebInspector.ProfileView.prototype._assignParentsInProfile):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfileHeader):
- inspector/front-end/inspector.js: (WebInspector.addProfileHeader):
- 2:15 AM Changeset in webkit [49614] by
-
- 2 edits in trunk/WebCore
2009-10-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Create and update frontend script objects only when
web inspector is visible.
- inspector/InspectorController.cpp: (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::pruneResources): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::mainResourceFiredDOMContentEvent): (WebCore::InspectorController::mainResourceFiredLoadEvent): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::didOpenDatabase): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::evaluateForTestInFrontend):
- 1:56 AM Changeset in webkit [49613] by
-
- 3 edits in trunk/WebKitTools
2009-10-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: enable developers extras within inspector layout tests.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector):
- 12:35 AM Changeset in webkit [49612] by
-
- 2 edits in trunk/WebKitTools
2009-10-14 José Millán Soto <jmillan@igalia.com>
Reviewed by Jan Alonzo.
GtkLauncher is using a deprecated signal
https://bugs.webkit.org/show_bug.cgi?id=30364
Modified GtkLauncher to use notify::title signal instead of
deprecated title-changed signal
- GtkLauncher/main.c: (notify_title_cb): (create_browser):
- 12:10 AM Changeset in webkit [49611] by
-
- 2 edits in trunk/WebCore
2009-10-15 Joseph Pecoraro <Joseph Pecoraro>
Fix Windows build.
- dom/Document.idl:
Oct 14, 2009:
- 11:41 PM Changeset in webkit [49610] by
-
- 3 edits3 adds in trunk
2009-10-14 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Adam Barth.
[HTML5] Add document.head
https://bugs.webkit.org/show_bug.cgi?id=30232
Test is fast/dom/document-head.html
- dom/Document.idl: added readonly attribute head
- 11:12 PM Changeset in webkit [49609] by
-
- 2 edits in trunk/WebCore
2009-10-14 Matt Mueller <mattm@chromium.org>
Reviewed by Darin Adler.
Check FNonNeg after the unit switch to avoid valgrind uninitialised conditional reference in WebCore::CSSParser::validUnit. See http://crbug.com/20939.
https://bugs.webkit.org/show_bug.cgi?id=30347
https://bugs.webkit.org/show_bug.cgi?id=22772
Covered by running LayoutTests/fast/css/invalid-percentage-property.html under valgrind.
- css/CSSParser.cpp: (WebCore::CSSParser::validUnit):
- 10:15 PM Changeset in webkit [49608] by
-
- 6 edits in trunk/WebCore
2009-10-14 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Move scrolling code from FrameLoader to FrameView
https://bugs.webkit.org/show_bug.cgi?id=30370
This code is about controlling the Frame's view, not about loading
stuff into the frame.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedParsing): (WebCore::FrameLoader::scrollToAnchor):
- page/FrameView.cpp: (WebCore::FrameView::scrollToFragment): (WebCore::FrameView::scrollToAnchor):
- page/FrameView.h:
- 8:24 PM Changeset in webkit [49607] by
-
- 44 edits in trunk
Make typeinfo flags default to false
https://bugs.webkit.org/show_bug.cgi?id=30372
Reviewed by Geoff Garen.
Part 1. Reverse the HasStandardGetOwnPropertySlot flag.
- 7:39 PM Changeset in webkit [49606] by
-
- 2 edits in trunk/WebKitSite
2009-10-14 Evan Martin <evan@chromium.org>
Reviewed by Darin Adler.
Document what state the build tree is expected to be in after a patch.
- coding/contributing.html:
- 7:14 PM Changeset in webkit [49605] by
-
- 3 edits4 adds in trunk
2009-10-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
[XSSAuditor] Add an exception for local files
https://bugs.webkit.org/show_bug.cgi?id=30352
Test that we allow sites to load scripts from their own domain as long
as they don't use query strings.
- http/tests/security/xssAuditor/script-tag-with-source-same-host-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-same-host.html: Added.
2009-10-14 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
[XSSAuditor] Add an exception for local files
https://bugs.webkit.org/show_bug.cgi?id=30352
Reduce XSS auditor false positives by always letting pages load scripts
from their own host. We don't actually know of any false positives
that this prevents, but it seems like a good idea.
One subtly is that we don't add this exception for scripts that have a
query string because (1) URLs with query strings are more apt to
confuse servers and (2) it is much less common to load scripts with a
query string.
Tests: http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query.html
http/tests/security/xssAuditor/script-tag-with-source-same-host.html
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
- 5:33 PM Changeset in webkit [49604] by
-
- 2 edits in trunk/WebKit/mac
Unbreak the world.
- Plugins/WebBaseNetscapePluginView.mm: (WebHaltablePlugin::restart):
- 5:14 PM Changeset in webkit [49603] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Anders Carlsson and Jon Honeycutt
<rdar://problem/7304295> snapshots of halted plug-ins are missing
- Plugins/WebBaseNetscapePluginView.mm: Move bodies of WebHaltablePlugin virtual functions from WebHaltablePlugin class definition. (WebHaltablePlugin::halt): Provide a substitute image to the RenderWidget for the plug-in view. (WebHaltablePlugin::restart): Clear the substitute image.
- 4:54 PM Changeset in webkit [49602] by
-
- 48 edits in trunk/WebCore
2009-10-14 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by George Staikos.
Kill virtual contextElement() method spread all over SVG code
https://bugs.webkit.org/show_bug.cgi?id=30183
Remove virtual contextElement() function from all SVG*Element classes, as all animated properties live in the
SVG*Element classes now instead of the SVGFitToViewBox / SVGURIReference / SVGExternalResourcesRequired
subclasses. This is a first step to working animVal support. More patches will follow that depend on this change.
Remove "This file is part of the KDE project" from several files, change my old mail adress wildfox -> zimmermann,
and remove vim modelines on all files I touched. No change in functionality, thus no new tests.
- svg/SVGAElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGAltGlyphElement.h: Remove virtual contextElement() method.
- svg/SVGAnimatedProperty.h: (WebCore::::synchronize): (WebCore::::startAnimation): (WebCore::::stopAnimation):
- svg/SVGAnimationElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGCircleElement.h: Ditto.
- svg/SVGClipPathElement.h: Ditto.
- svg/SVGCursorElement.h: Ditto.
- svg/SVGDefsElement.h: Ditto.
- svg/SVGEllipseElement.h: Ditto.
- svg/SVGExternalResourcesRequired.h: Remove pure-virtual contextElement() method.
- svg/SVGFEImageElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGFELightElement.h: Remove virtual contextElement() method.
- svg/SVGFEMergeNodeElement.h: Ditto.
- svg/SVGFilterElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGFilterPrimitiveStandardAttributes.h: Remove virtual contextElement() method.
- svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::parseViewBox): Add Document* parameter - we used to fetch the Document pointer from the context element. (WebCore::SVGFitToViewBox::parseMappedAttribute): Ditto.
- svg/SVGFitToViewBox.h: Remove pure-virtual contextElement() method.
- svg/SVGFontElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGForeignObjectElement.h: Ditto.
- svg/SVGGElement.h: Ditto.
- svg/SVGGradientElement.h: Ditto.
- svg/SVGImageElement.h: Ditto.
- svg/SVGLineElement.h: Ditto.
- svg/SVGMPathElement.h: Ditto. Fix license indention.
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
- svg/SVGMarkerElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGMaskElement.h: Ditto.
- svg/SVGPathElement.h: Ditto.
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
- svg/SVGPatternElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::updateAnimatedSVGAttribute): synchronizeProperty<...>() has been renamed to PropertySynchronizer<...>::synchronize().
- svg/SVGPolyElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGRectElement.h: Ditto.
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
- svg/SVGSVGElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGScriptElement.h: Ditto.
- svg/SVGSwitchElement.h: Ditto.
- svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
- svg/SVGSymbolElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGTRefElement.h: Remove virtual contextElement() method.
- svg/SVGTextContentElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGTextPathElement.h: Remove virtual contextElement() method.
- svg/SVGUseElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGViewElement.cpp: (WebCore::SVGViewElement::parseMappedAttribute): Pass document() to SVGFitToViewBox::parseMappedAttribute().
- svg/SVGViewElement.h: Remove virtual contextElement() method. Change OwnerType of ANIMATED_* macros to this class.
- svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::setViewBoxString): Pass document() to SVGFitToViewBox::parseMappedAttribute(). (WebCore::SVGViewSpec::parseViewSpec): Ditto.
- svg/SVGViewSpec.h: Devirtualize contextElement() method, it's the only place where contextElement() remains needed.
- 4:48 PM Changeset in webkit [49601] by
-
- 1 edit1 delete in trunk/LayoutTests
Fix a failure seen on buildbot after landing the fix for
https://bugs.webkit.org/show_bug.cgi?id=18994
Patch by Darin Adler <Darin Adler> on 2009-10-14
- platform/win/fast/css/large-number-round-trip-expected.txt: Removed.
- 4:29 PM Changeset in webkit [49600] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 4:27 PM Changeset in webkit [49599] by
-
- 1 copy in tags/Safari-6531.21
New tag.
- 4:21 PM Changeset in webkit [49598] by
-
- 3 edits4 adds in trunk
2009-10-14 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG Masking with wrong offset
https://bugs.webkit.org/show_bug.cgi?id=30325
SVGMaskElement moves the mask image graphics context to the wrong location.
In objectBoundingBoxMode the maskDestRect gets translated. This transformation
is not used in the later calculation. Fix by consistenly calculating the translation
offsets from the final mask destination rect.
Test: svg/custom/mask-with-default-value.svg
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
2009-10-14 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG Masking with wrong offset
https://bugs.webkit.org/show_bug.cgi?id=30325
SVGMaskElement moves the mask image graphics context to the wrong location.
In objectBoundingBoxMode the maskDestRect gets translated. This transformation
is not used in the later calculation. Fix by consistenly calculating the translation
offsets from the final mask destination rect.
Test: svg/custom/mask-with-default-value.svg
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
- 4:14 PM Changeset in webkit [49597] by
-
- 3 edits in trunk/WebCore
Rubberstamped by Jon Honeycutt.
Export a few more showSubstituteImage() related methods.
- WebCore.base.exp:
- WebCore.xcodeproj/project.pbxproj:
- 4:11 PM Changeset in webkit [49596] by
-
- 1 edit2 deletes in trunk/LayoutTests
Fix failures seen on buildbot after landing the fix for
https://bugs.webkit.org/show_bug.cgi?id=18994
Patch by Darin Adler <Darin Adler> on 2009-10-14
Reviewed by Mark Rowe.
Somehow I had the mac/fast/css/opacity-float-expected.txt
removed locally, and Subversion didn't check that in!
- platform/mac/fast/css/opacity-float-expected.txt: Removed.
- platform/win/fast/css/opacity-float-expected.txt: Removed.
- 4:04 PM Changeset in webkit [49595] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 4:00 PM Changeset in webkit [49594] by
-
- 2 edits in trunk/LayoutTests
Disable plugins/private-browsing-mode.html on Snow Leopard.
Reviewed by Sam Weinig.
- platform/mac-snowleopard/Skipped:
- 3:42 PM Changeset in webkit [49593] by
-
- 4 edits in branches/safari-4-branch/JavaScriptCore
Merge r47620.
- 3:38 PM Changeset in webkit [49592] by
-
- 11 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=30269
Use onload to detect iframe load, rather than setTimeout.
This will give more consistent test results and hopefully faster run times.
Patch by Julie Parent <jparent@chromium.org> on 2009-10-13
Reviewed by Darin Adler.
- editing/execCommand/paste-1.html:
- editing/execCommand/paste-2.html:
- editing/pasteboard/subframe-dragndrop-1.html:
- editing/selection/4776665.html:
- editing/selection/4975120.html:
- editing/selection/5136696.html:
- editing/selection/drag-to-contenteditable-iframe.html:
- platform/mac/editing/selection/5136696-expected.txt: Rebaselined because moving a script tag eliminated an empty text node.
- platform/qt/editing/selection/5136696-expected.txt: Rebaselined because moving a script tag eliminated an empty text node.
- platform/win/editing/selection/5136696-expected.txt: Rebaselined because moving a script tag eliminated an empty text node.
- 2:46 PM Changeset in webkit [49591] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48531.
- 2:46 PM Changeset in webkit [49590] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48529.
- 2:46 PM Changeset in webkit [49589] by
-
- 3 edits in branches/safari-4-branch/WebCore
Merge r48446.
- 2:46 PM Changeset in webkit [49588] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r48396.
- 2:46 PM Changeset in webkit [49587] by
-
- 3 edits in branches/safari-4-branch/WebCore
Merge r48375.
- 2:46 PM Changeset in webkit [49586] by
-
- 10 edits in branches/safari-4-branch/WebCore
Merge r48370.
- 2:45 PM Changeset in webkit [49585] by
-
- 10 edits in trunk
JavaScriptCore: Additions so fix for https://bugs.webkit.org/show_bug.cgi?id=18994
can build on Windows.
Patch by Darin Adler <Darin Adler> on 2009-10-14
- wtf/MathExtras.h: Added llround and llroundf for Windows.
WebCore: Stringify CSS units manually (without printf) to make the formatting
locale-insensitive and obey CSS spec with respect to large values.
Patch by Evan Martin <evan@chromium.org> on 2009-10-14
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=18994
- css/CSSPrimitiveValue.cpp:
(WebCore::appendCSSDouble):
(WebCore::formatWithUnits):
(WebCore::CSSPrimitiveValue::cssText):
LayoutTests: Float formatting changes affect three tests:
- large-number-round-trip now passes
- opacity-float now passes and has more test cases
- compound-2d-transforms output tweaked slightly
Patch by Evan Martin <evan@chromium.org> on 2009-10-14
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=18994
- fast/css/large-number-round-trip-expected.txt:
- fast/css/opacity-float-expected.txt:
- fast/css/opacity-float.html:
- platform/mac/fast/css/opacity-float-expected.txt: Removed.
- transforms/2d/compound-2d-transforms-expected.txt:
- transforms/2d/compound-2d-transforms.html:
- 2:41 PM Changeset in webkit [49584] by
-
- 2 edits in trunk/WebCore
2009-10-14 Mark Seaborn <mseaborn@google.com>
Reviewed by Darin Adler.
Check error return value in Perl build script
https://bugs.webkit.org/show_bug.cgi?id=30316
- css/makevalues.pl: Die if gperf fails.
- 1:39 PM Changeset in webkit [49583] by
-
- 2 edits in trunk/JavaScriptCore
Roll out r49580 as it is completely wrong and breaks the Mac builds.
- 1:30 PM Changeset in webkit [49582] by
-
- 12 edits4 adds in trunk
2009-10-14 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG wrong filterRegions for userSpaceOnUse and percentage values
https://bugs.webkit.org/show_bug.cgi?id=30330
Some clean-up of the SVG filter calculation code. This clean-up
also fixes the problem with percentage and userSpaceInUse mode.
Test: svg/filters/subRegion-in-userSpace.svg
- platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::FilterEffect):
- platform/graphics/filters/FilterEffect.h:
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::buildFilter): (WebCore::SVGFilterElement::canvasResource):
- svg/SVGFilterElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
- svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::SVGResourceFilter): (WebCore::SVGResourceFilter::~SVGResourceFilter): (WebCore::SVGResourceFilter::addFilterEffect): (WebCore::SVGResourceFilter::prepareFilter):
- svg/graphics/SVGResourceFilter.h: (WebCore::SVGResourceFilter::create):
- svg/graphics/filters/SVGFilter.cpp: (WebCore::SVGFilter::SVGFilter): (WebCore::SVGFilter::calculateEffectSubRegion): (WebCore::SVGFilter::create):
- svg/graphics/filters/SVGFilter.h:
Reviewed by Nikolas Zimmermann.
Check if the percentage of effect values takes user space as reference and
not the FilterRect.
- platform/mac/svg/filters/subRegion-in-userSpace-expected.checksum: Added.
- platform/mac/svg/filters/subRegion-in-userSpace-expected.png: Added.
- platform/mac/svg/filters/subRegion-in-userSpace-expected.txt: Added.
- svg/filters/subRegion-in-userSpace.svg: Added.
- 12:32 PM Changeset in webkit [49581] by
-
- 4 edits in trunk
WebKitTools: Don't set the history delegate on new windows that are opened during a test, as the history delegate:
1 - Disables WebHistory
2 - Doesn't make sense in that context anyway.
Reviewed by Sam Weinig.
- DumpRenderTree/win/DumpRenderTree.cpp:
(createWebViewAndOffscreenWindow):
LayoutTests: Un-skip a test that now passes.
Reviewed by Sam Weinig.
- platform/win/Skipped:
- 12:01 PM Changeset in webkit [49580] by
-
- 2 edits in trunk/JavaScriptCore
Mac build fix, use MIN_REQUIRED rather than MAX_ALLOWED to determine
compilation of code that requires 10.6.
- 11:51 AM Changeset in webkit [49579] by
-
- 3 edits in trunk/WebKitTools
wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
- 11:41 AM Changeset in webkit [49578] by
-
- 2 edits in trunk/WebCore
The last change fixed the problem, removing diagnostic printfs.
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):
- 11:34 AM BuildingOnWindows edited by
- Add (non-ideal) workaround for Visual Studio 2005 missing Crypt32.lib error (diff)
- 11:31 AM Changeset in webkit [49577] by
-
- 3 edits in trunk/WebCore
CURL build fix for versions < 7.18.
- 11:30 AM Changeset in webkit [49576] by
-
- 1 edit1 add in trunk/LayoutTests
2009-10-14 Nate Chapin <Nate Chapin>
Unreviewed, build fix.
When I landed r49569 for Victor, I failed to svn add one of the required files.
This should fix the redness on the Windows test bots.
- platform/win/editing/pasteboard/paste-xml-expected.txt: Added.
- 11:18 AM Changeset in webkit [49575] by
-
- 2 edits in trunk/WebCore
One more round of changes to figure out why the webgl
tests are crashing on the build bot. Here I am trying
to see if we can create a software renderer. I am also
printing the found pixel formats.
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):
- 10:42 AM Changeset in webkit [49574] by
-
- 8 edits7 adds in trunk/WebCore
Enabling NPAPI plugin support on Qt Webkit for S60 platform
https://bugs.webkit.org/show_bug.cgi?id=29302
Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-10-14
Reviewed by
Also implemented by Mahesh Kulkarni<mahesh.kulkarni@nokia.com>,
Rohini Ananth <rohini.ananth@nokia.com> and help from Norbert Lesr
<norbert.leser@nokia.com>
- 10:34 AM Changeset in webkit [49573] by
-
- 8 edits in trunk/LayoutTests
2009-10-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: skip inspector tests that were recently added
until harness is fixed in release mode.
- platform/gtk/Skipped:
- platform/mac-leopard/Skipped:
- platform/mac-snowleopard/Skipped:
- platform/mac-tiger/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 10:29 AM Changeset in webkit [49572] by
-
- 2 edits in trunk/LayoutTests
Skip my two new failures while I'm actively looking at them.
- platform/win/Skipped:
- 10:18 AM Changeset in webkit [49571] by
-
- 2 edits in trunk/WebCore
More changes to figure out why the webgl tests are crashing on the build bot.
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):
- 10:11 AM Changeset in webkit [49570] by
-
- 2 edits in trunk/JavaScriptCore
wx build fix. Set ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH for plugins while we're still building stubs.
- 10:02 AM Changeset in webkit [49569] by
-
- 2 edits in trunk/LayoutTests
2009-10-14 Victor Wang <victorw@chromium.org>
Reviewed by Darin Adler.
Add paste-xml test back for Win.
The result difference between Mac and Win is due to the
platform dependent implementation. The diff is expected
with current implementation.
See bug for more deails:
- platform/win/Skipped:
- platform/win/editing/pasteboard/paste-xml-expected.txt: Added.
- 9:39 AM Changeset in webkit [49568] by
-
- 1 edit7 adds in trunk/LayoutTests
2009-10-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add initial layout tests for web inspector.
- inspector/console-tests-expected.txt: Added.
- inspector/console-tests.html: Added.
- inspector/elements-panel-structure-expected.txt: Added.
- inspector/elements-panel-structure.html: Added.
- inspector/evaluate-in-frontend-expected.txt: Added.
- inspector/evaluate-in-frontend.html: Added.
- inspector/evaluate-in-frontend.js: Added.
- 9:26 AM Changeset in webkit [49567] by
-
- 16 edits2 adds in trunk
2009-10-14 Victor Wang <victorw@chromium.org>
Reviewed by David Hyatt.
Round non-integer line height values.
Change webkit to rounding non-integer line height values
instead of truncating them. This fixes a layout test
failure on Windows and matches the calculation in IE and Firefox.
- 9:23 AM Changeset in webkit [49566] by
-
- 2 edits in trunk/WebKit/win
Windows build fix
- WebKit.vcproj/Interfaces.vcproj: Exclude IWebHistoryDelegate and
IWebNavigationData from the build (they get #imported via WebKit.idl).
- 9:21 AM Changeset in webkit [49565] by
-
- 9 edits in trunk/WebCore
2009-10-13 Kelly Norton <knorton@google.com>
Reviewed by Pavel Feldman.
Removes the persistent setting for InspectorTimelineAgent and renames timeline related
interfaces to be more consistent with the JavaScript profiler.
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::startTimelineProfiler): (WebCore::InspectorBackend::stopTimelineProfiler): (WebCore::InspectorBackend::timelineProfilerEnabled):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::timelineProfilerEnabled):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::timelineProfilerWasStarted): (WebCore::InspectorFrontend::timelineProfilerWasStopped):
- inspector/InspectorFrontend.h:
- inspector/front-end/TimelineAgent.js: (WebInspector.timelineProfilerWasStarted): (WebInspector.timelineProfilerWasStopped):
- 9:03 AM Changeset in webkit [49564] by
-
- 20 edits6 adds in trunk
WebKit Win API should provide a delegate interface for global history.
https://bugs.webkit.org/show_bug.cgi?id=29905
Reviewed by Sam Weinig.
WebKit/win:
-Add IWebHistoryDelegate for clients to implement.
-Add (I)WebNavigationData for the history delegate's use.
-When it exists, call the history delegate instead of using WebHistory.
- Interfaces/IWebHistoryDelegate.idl: Added.
- Interfaces/IWebHistoryPrivate.idl:
- Interfaces/IWebNavigationData.idl: Added.
- Interfaces/IWebViewPrivate.idl:
- Interfaces/WebKit.idl:
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/WebKit.vcproj:
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::populateVisitedLinks):
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::updateGlobalHistory):
(WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
(WebFrameLoaderClient::setTitle):
- WebView.cpp:
(WebView::close):
(WebView::mainFrameURL):
(WebView::setHistoryDelegate):
(WebView::historyDelegate):
(WebView::addVisitedLinks):
- WebView.h:
- WebHistory.cpp:
(WebHistory::setVisitedLinkTrackingEnabled):
(WebHistory::removeAllVisitedLinks):
- WebHistory.h:
- WebNavigationData.cpp: Added.
(WebNavigationData::QueryInterface):
(WebNavigationData::AddRef):
(WebNavigationData::Release):
(WebNavigationData::WebNavigationData):
(WebNavigationData::~WebNavigationData):
(WebNavigationData::createInstance):
(WebNavigationData::url):
(WebNavigationData::title):
(WebNavigationData::originalRequest):
(WebNavigationData::response):
(WebNavigationData::hasSubstituteData):
(WebNavigationData::clientRedirectSource):
- WebNavigationData.h: Added.
WebKitTools:
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController::dumpHistoryDelegateCallbacks):
(LayoutTestController::setDumpHistoryDelegateCallbacks):
- DumpRenderTree/win/DumpRenderTree.cpp:
(shouldLogHistoryDelegates):
(runTest):
(createWebViewAndOffscreenWindow):
(main):
- DumpRenderTree/win/DumpRenderTree.vcproj:
Add the IWebHistoryDelegate to DRT Windows:
- DumpRenderTree/win/HistoryDelegate.cpp: Added.
(wstringFromBSTR):
(HistoryDelegate::HistoryDelegate):
(HistoryDelegate::~HistoryDelegate):
(HistoryDelegate::QueryInterface):
(HistoryDelegate::AddRef):
(HistoryDelegate::Release):
(HistoryDelegate::didNavigateWithNavigationData):
(HistoryDelegate::didPerformClientRedirectFromURL):
(HistoryDelegate::didPerformServerRedirectFromURL):
(HistoryDelegate::updateHistoryTitle):
(HistoryDelegate::populateVisitedLinksForWebView):
- DumpRenderTree/win/HistoryDelegate.h: Added.
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::removeAllVisitedLinks):
LayoutTests:
- platform/win/Skipped: Enable globalhistory tests.
- 9:02 AM Changeset in webkit [49563] by
-
- 4 edits in trunk/WebKitTools
2009-10-14 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Implement support for setPOSIXLocale on Qt.
https://bugs.webkit.org/show_bug.cgi?id=30268
- DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setPOSIXLocale):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 8:48 AM Changeset in webkit [49562] by
-
- 3 edits3 adds in trunk
2009-10-02 Yong Li <yong.li@torchmobile.com>
Reviewed by Adele Peterson.
Fixed crash when loading invalid image data.
Also added a test case that loads an invalid image to make sure
we don't crash in this situation.
https://bugs.webkit.org/show_bug.cgi?id=29980
WebCore:
- rendering/RenderImage.cpp: (WebCore::RenderImage::setImageSizeForAltText):
LayoutTests:
- fast/images/image-invalid-data-expected.txt: Added.
- fast/images/image-invalid-data.html: Added.
- fast/images/resources/invalid.jpg: Added.
- 8:40 AM QtWebKitPerformanceToolBackLog: edited by
- (diff)
- 8:30 AM QtBackLog edited by
- (diff)
- 8:02 AM Changeset in webkit [49561] by
-
- 3 edits2 adds in trunk
WebCore: Fix for NULL ptr deref in canvas's toDataURL().
https://bugs.webkit.org/show_bug.cgi?id=30254
Reviewed by Eric Seidel.
Test: fast/canvas/canvas-toDataURL-crash.html
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::toDataURL):
LayoutTests: New test for NULL ptr deref in canvas's toDataURL().
https://bugs.webkit.org/show_bug.cgi?id=30254
Reviewed by Eric Seidel.
- fast/canvas/canvas-toDataURL-crash-expected.txt: Added.
- fast/canvas/canvas-toDataURL-crash.html: Added.
- 7:54 AM Changeset in webkit [49560] by
-
- 14 edits in trunk/WebCore
2009-10-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed, reverting r49558 since it broke profiler tests.
- bindings/js/JSInspectorBackendCustom.cpp:
- bindings/v8/custom/V8CustomBinding.h:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getProfileHeaders): (WebCore::InspectorBackend::getProfile):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::getProfileHeaders): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::createProfileHeader):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addProfileHeader): (WebCore::InspectorFrontend::didGetProfileHeaders): (WebCore::InspectorFrontend::didGetProfile):
- inspector/InspectorFrontend.h:
- inspector/JavaScriptProfileNode.cpp: (WebCore::ProfileNodeClass):
- inspector/front-end/ProfileView.js: (WebInspector.ProfileView.profileCallback): (WebInspector.ProfileView): (WebInspector.ProfileView.prototype._mouseDownInDataGrid): (WebInspector.ProfileView.prototype._assignParentsInProfile):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfileHeader):
- inspector/front-end/inspector.js: (WebInspector.addProfileHeader):
- 7:10 AM Changeset in webkit [49559] by
-
- 3 edits in trunk/WebCore
ImageDecoderQt: Minor tweaks to the decoder
- Only cache the data when we start to use it.
- Start with a repetition count of none for normal images.
- Do not use canRead as this will trigger parsing of the full image
- Cope with a GIF failing to decode the first frame, do not set m_failed to true if decoding the first frame failed
- Inform the QImageReader about the format that was detected
- Always create a ImageDecoderQt when when we have more than four byte.
- 6:32 AM Changeset in webkit [49558] by
-
- 14 edits in trunk/WebCore
2009-10-14 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Migrate profiles to the injected script-based schema.
- bindings/js/JSInspectorBackendCustom.cpp:
- bindings/v8/custom/V8CustomBinding.h:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getProfileHeaders): (WebCore::InspectorBackend::getProfile):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::getProfileHeaders): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::createProfileHeader):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addProfileHeader): (WebCore::InspectorFrontend::didGetProfileHeaders): (WebCore::InspectorFrontend::didGetProfile):
- inspector/InspectorFrontend.h:
- inspector/JavaScriptProfileNode.cpp: (WebCore::ProfileNodeClass):
- inspector/front-end/ProfileView.js: (WebInspector.ProfileView.profileCallback): (WebInspector.ProfileView): (WebInspector.ProfileView.prototype._mouseDownInDataGrid): (WebInspector.ProfileView.prototype._assignParentsInProfile):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfileHeader):
- inspector/front-end/inspector.js: (WebInspector.addProfileHeader):
- 2:14 AM Changeset in webkit [49557] by
-
- 4 edits in trunk/WebCore
2009-10-13 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Don't collect call frame properties until they're needed for completion.
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions):
- inspector/front-end/InjectedScript.js: (InjectedScript.getCompletions): if call frame id is specified and the expression is empty collect frame properties. (InjectedScript.CallFrameProxy.prototype._wrapScopeChain): don't send call frame properties until they're needed.
- inspector/front-end/ScriptsPanel.js:
