Timeline
Oct 29, 2009:
- 11:51 PM Changeset in webkit [50319] by
-
- 4 edits in trunk/WebCore
2009-10-29 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[V8] Out-of-memory crash in isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=30906
We need to handle the fact that creating a V8:Context might fail. I
don't know how to test this change because creating a context usually
only fails when V8 decides it's using too much memory.
- bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::evaluateInNewContext):
- 11:29 PM QtBackLog edited by
- (diff)
- 11:26 PM QtBackLog edited by
- (diff)
- 11:12 PM Changeset in webkit [50318] by
-
- 4 edits in trunk/WebKitTools
Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
from the two scripts that define it but don’t use it to the script that uses it but doesn’t
define it.
Reviewed by Mark Rowe.
- Scripts/VCSUtils.pm:
- Scripts/svn-apply:
- Scripts/svn-unapply:
- 10:57 PM Changeset in webkit [50317] by
-
- 2 edits in trunk/WebKit/mac
Validate the stopSpeaking: selector so that is not always enabled when a WebView is first responder.
Reviewed by Oliver Hunt.
- WebView/WebHTMLView.mm:
(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
- 9:07 PM Changeset in webkit [50316] by
-
- 2 edits in trunk/WebKit/win
<http://webkit.org/b/30938> REGRESSION(r50233): Windows nightlies crash on launch due to changes
to IWebFramePrivate vtable ordering
Rubber-stamped by Dan Bernstein.
- Interfaces/IWebFramePrivate.idl: Move the newly-added method to the end of the interface so that
it doesn't affect the ordering of the vtable.
- 7:39 PM Changeset in webkit [50315] by
-
- 5 edits3 adds1 delete in trunk
2009-10-29 Erik Arvidsson <arv@chromium.org>
Reviewed by Eric Seidel.
Make links mouse focusable only on GTK and QT.
Links are now always mouse focusable on GTK and QT. On other platforms
the link needs a tabIndex or it needs to be contentEditable.
- fast/events/click-focus-anchor-expected.txt:
- fast/events/click-focus-anchor.html:
- platform/gtk/fast/events/click-focus-anchor-expected.txt: Added.
- platform/mac/fast/events/click-focus-anchor-expected.txt: Removed.
- platform/qt/fast/events/click-focus-anchor-expected.txt: Added.
2009-10-29 Erik Arvidsson <arv@chromium.org>
Reviewed by Eric Seidel.
Make links mouse focusable only on GTK and QT.
Links are now always mouse focusable on GTK and QT. On other platforms
the link needs a tabIndex or it needs to be contentEditable.
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isMouseFocusable):
- 7:30 PM Changeset in webkit [50314] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-10-29 Jonathan Dixon <joth@chromium.org>
Reviewed by Eric Seidel.
Add expected files for GTK and QT builds, for test text-input-webkit-radius.html
Expected fils collected from buildbot:
http://build.webkit.org/results/Qt%20Linux%20Release/r50286%20(3257)/fast/css/
http://build.webkit.org/results/GTK%20Linux%20Release/r50286%20(5308)/fast/css/
- platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt: Added.
- platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt: Added.
- 7:00 PM Changeset in webkit [50313] by
-
- 2 edits in trunk/LayoutTests
Updated Tiger-specific result now that Tiger matches current behavior. A Tiger-specific
result is still needed because of the difference in Thai fonts.
- platform/mac-tiger/fast/text/atsui-multiple-renderers-expected.txt:
- 5:49 PM Changeset in webkit [50312] by
-
- 6 edits3 deletes in trunk
WebCore: Complete the fix for hit-testing and selection highlighting in ligatures for the ATSUI
code path.
Reviewed by Sam Weinig.
- platform/graphics/mac/ComplexTextController.h: Added m_ltr member to ComplexTextRun.
- platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): Skip over deleted
glyphs, but update indexes and advances correctly.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Initialize m_ltr.
LayoutTests: Updated a test to account for font metric differences between Mac OS X versions. Removed
Leopard-specific results for another test now that Leopard matches current behavior.
Reviewed by Sam Weinig.
- platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.checksum: Removed.
- platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.png: Removed.
- platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.txt: Removed.
- platform/mac/fast/text/ligature-subdivision-expected.txt:
- platform/mac/fast/text/script-tests/ligature-subdivision.js:
- 5:26 PM Changeset in webkit [50311] by
-
- 2 edits in trunk
Updating Radar numbers
- 4:37 PM Changeset in webkit [50310] by
-
- 6 edits2 adds in trunk
REGRESSION(3.2.3 - 4.0.2): Message composing: when I undo a color change to text in Mail, undo/redo behaves strangely
<rdar://problem/7067033>
https://bugs.webkit.org/show_bug.cgi?id=30892
WebCore:
Patch by Enrica Casucci <enrica@apple.com> on 2009-10-29
Reviewed by Darin Adler.
This problem shows in any scenario where it is necessary to split a text
node to apply a style. SplitElementCommand and WrapContentsInDummySpanCommand both
have member variables initialized in the constructor to keep reference to elements
they need to operate upon. These reference are not updated when reapplying the command.
For this reason it is necessary to guarantee that unapply doesn not delete the references
and that these commands implement doReapply to correctly reuse the existing
elements.
Test: editing/undo/redo-style.html
- editing/SplitElementCommand.cpp:
(WebCore::SplitElementCommand::executeApply): Added.
(WebCore::SplitElementCommand::doApply): Modified to call executeApply.
(WebCore::SplitElementCommand::doUnapply): Doesn't release m_element1.
(WebCore::SplitElementCommand::doReapply): Added.
- editing/SplitElementCommand.h: Added doReapply and executeApply.
- editing/WrapContentsInDummySpanCommand.cpp:
(WebCore::WrapContentsInDummySpanCommand::executeApply): Added.
(WebCore::WrapContentsInDummySpanCommand::doApply): Modified to call executeApply.
(WebCore::WrapContentsInDummySpanCommand::doUnapply): Doesn't release m_dummySpan.
(WebCore::WrapContentsInDummySpanCommand::doReapply): Added.
- editing/WrapContentsInDummySpanCommand.h: Added doReapply and executeApply.
LayoutTests:
Patch by Enrica Casucci <enrica@apple.com> on 2009-10-29
- editing/undo/redo-style-expected.txt: Added.
- editing/undo/redo-style.html: Added.
- 4:22 PM Changeset in webkit [50309] by
-
- 3 edits in trunk/WebCore
2009-10-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
DOM Storage's condition variable needs to handle spurious wakeups
https://bugs.webkit.org/show_bug.cgi?id=30920
Add a boolean to keep track of whether it's been terminated. Clean
up the locking code a tiny bit to make it easier to read. There's
no way to reproduce this reliably in a LayoutTest.
- storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::LocalStorageThread): (WebCore::LocalStorageThread::terminate): (WebCore::LocalStorageThread::performTerminate):
- storage/LocalStorageThread.h:
- 4:22 PM Changeset in webkit [50308] by
-
- 2 edits in trunk/WebKit/mac
https://bugs.webkit.org/show_bug.cgi?id=30932
<rdar://problem/7350269>
Reviewed by Sam Weinig.
REGRESSION: Crash when turning on Private Browsing on site with flash.
Null check setValue.
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView privateBrowsingModeDidChange]):
- 3:49 PM Changeset in webkit [50307] by
-
- 4 edits in trunk
WebKitTools: Implement the Qt version of DRT dumpBackForwardList().
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Reviewed by Oliver Hunt.
- DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::dumpHistoryItem):
(WebCore::DumpRenderTree::dumpBackForwardList):
LayoutTests: Removed test that passes after implementing the Qt DRT version
of dumpBackForwardList().
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Reviewed by Oliver Hunt.
- platform/qt/Skipped:
- 3:43 PM Changeset in webkit [50306] by
-
- 2 edits in trunk/WebCore
2009-10-29 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[Chromium] Include ComplextTextController into Chromium Mac project.
- WebCore.gyp/WebCore.gyp: Added include rule for ComplextText* files.
- 3:32 PM Changeset in webkit [50305] by
-
- 2 edits in trunk/WebKit/mac
2009-10-29 Eric Carlson <eric.carlson@apple.com>
Reviewed by Kevin Decker.
Refactor some duplicate plug-in clean up code into shared functions.
- Plugins/WebPluginController.mm: (-[WebPluginController stopOnePlugin:]): New, stop a plug-in. (-[WebPluginController destroyOnePlugin:]): New, destroy plug-in. (-[WebPluginController stopAllPlugins]): Call stopOnePlugin. (-[WebPluginController destroyPlugin:]): Call stopOnePlugin and destroyOnePlugin. (-[WebPluginController destroyAllPlugins]): Call destroyOnePlugin.
- 3:32 PM Changeset in webkit [50304] by
-
- 2 edits1 add3 deletes in trunk/LayoutTests
2009-10-29 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
fast/css/counters/invalidate-cached-counter-node can be dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=30931
- fast/css/counters/invalidate-cached-counter-node-expected.txt: Added.
- fast/css/counters/invalidate-cached-counter-node.html:
- platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.checksum: Removed.
- platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.png: Removed.
- platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.txt: Removed.
- 2:59 PM Changeset in webkit [50303] by
-
- 2 edits in trunk/WebCore
Fix tabbing through element attributes in the Web Insector.
https://bugs.webkit.org/show_bug.cgi?id=30429
Reviewed by Pavel Feldman.
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted): Don't call _updateTitle,
it is called for us when removeAttribute succeeds in the back-end.
(WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted): Ditto except for nodeValue.
(WebInspector.ElementsTreeElement.prototype._editingCancelled): Don't call _updateTitle, editing code reverts.
(WebInspector.ElementsTreeElement.prototype._updateTitle): Return early if we are editing.
- 2:54 PM Changeset in webkit [50302] by
-
- 2 edits in trunk/LayoutTests
[Qt] Remove some tests that now pass.
Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-10-29
- platform/qt/Skipped:
- 2:25 PM Changeset in webkit [50301] by
-
- 4 edits1 copy4 adds in trunk
Problem editing or selecting text containing ligatures
https://bugs.webkit.org/show_bug.cgi?id=30025
Reviewed by Sam Weinig.
WebCore:
Test: platform/mac/fast/text/ligature-subdivision.html
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextController): Initialize
m_characterInCurrentGlyph.
(WebCore::ComplexTextController::offsetForPosition): If the hit glyph spans multiple
characters, compute the hit character based on dividing the glyph’s total advance into
a number of equal intervals equal to the number of characters and assigning the hit to the
character corresponding to the hit interval.
(WebCore::ComplexTextController::advance): If the final offset occurs mid-glyph, advance
by a fraction of the glyph’s total advance.
- platform/graphics/mac/ComplexTextController.h: Added m_characterInCurrentGlyph.
LayoutTests:
- platform/mac/fast/text/ligature-subdivision-expected.txt: Added.
- platform/mac/fast/text/ligature-subdivision.html: Added.
- platform/mac/fast/text/script-tests: Added.
- platform/mac/fast/text/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/js/script-tests/TEMPLATE.html.
- platform/mac/fast/text/script-tests/ligature-subdivision.js: Added.
- 2:25 PM Changeset in webkit [50300] by
-
- 2 edits in trunk/WebCore
Fixes <http://webkit.org/b/30918>.
Web Inspector: Datagrid Rows on Windows not properly aligned.
Reviewed by Timothy Hatcher.
Use line-height for the table rows to make sure the height
of our text and the height of the table rows are consistent.
- inspector/front-end/inspector.css:
- 1:33 PM Changeset in webkit [50299] by
-
- 3 edits in trunk/WebCore
2009-10-29 Adam Barth <abarth@webkit.org>
No review, rolling out r50296.
http://trac.webkit.org/changeset/50296
- bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::evaluateInNewContext):
- 1:25 PM Changeset in webkit [50298] by
-
- 2 edits in trunk/WebKitTools
2009-10-29 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Use the GTK+ main loop instead of rolling our own mini-version of
it.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (dump): (runTest): (webViewLoadFinished):
- 1:21 PM Changeset in webkit [50297] by
-
- 2 edits in trunk/LayoutTests
Rubberstamped by Adam Roben.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Remove two tests that pass on the buildbot.
- platform/qt/Skipped:
- 1:15 PM Changeset in webkit [50296] by
-
- 3 edits in trunk/WebCore
2009-10-29 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[V8] Out-of-memory crash in isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=30906
We need to handle the fact that creating a V8:Context might fail. I
don't know how to test this change because creating a context usually
only fails when V8 decides it's using too much memory.
- bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::evaluateInNewContext):
- 1:05 PM Changeset in webkit [50295] by
-
- 2 edits in trunk/WebCore
Reviewed by Xan Lopez.
Remove build warning introduced by r50284.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::duration):
- 1:05 PM Changeset in webkit [50294] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Qt buildbot fix.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Add some files to skipped that depend on phonon support,
which is disabled on the Qt buildbot for now.
- platform/qt/Skipped:
- 1:01 PM Changeset in webkit [50293] by
-
- 4 edits in trunk/WebCore
2009-10-29 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
[V8] Remove random crashes by removing retrieval of V8 context during garbage collection.
Unfortunately, I haven't been able to trigger this crash explicitly, so no test :(.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::jsWrapperForDOMObject): Added new "assume-it's-there" getter.
- bindings/v8/V8DOMWrapper.h: Added getter decl.
- bindings/v8/V8GCController.cpp: (WebCore::GCPrologueVisitor::visitDOMWrapper): Changed to use explicit getter.
- 12:43 PM Changeset in webkit [50292] by
-
- 2 edits in trunk/WebCore
2009-10-29 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
[Chromium] Adjust the project files to sync up with
http://trac.webkit.org/changeset/50259
- WebCore.gypi: Renamed and added files.
- 12:41 PM Changeset in webkit [50291] by
-
- 2 edits in trunk/LayoutTests
Updated expected result for Tiger
- platform/mac-tiger/fast/text/international/thai-line-breaks-expected.txt:
- 12:24 PM Changeset in webkit [50290] by
-
- 2 edits in trunk/LayoutTests
Rubberstamped by Adam Roben.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Remove tests that pass after the change introduced in r50289.
- platform/qt/Skipped:
- 12:06 PM Changeset in webkit [50289] by
-
- 4 edits in trunk/WebKitTools
Implement DRT functionality for Qt introduced in
r28690 and r28705.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Reviewed by Adam Roben.
- Implemented pathToLocalResource which exposes the functionality of
converting a given unix path to the correct location on Windows.
- Implemented a way to remove machine-dependent information from paths
in layout test results.
- DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::urlSuitableForTestResult):
(WebCore::WebPage::javaScriptConsoleMessage):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::pathToLocalResource):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 11:29 AM Changeset in webkit [50288] by
-
- 4 edits in trunk
2009-10-29 Laszlo Gombos <Laszlo Gombos>
Reviewed by Tor Arne Vestbø.
[Qt] Implement DELETE HTTP method for XmlHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=30894
No new tests as this functionality is already tested by the
xmlhttprequest LayoutTests. As this patch depends on an unreleased
version of the dependent QtNetwork library and the tests will be
enabled later once the dependent library is released (and the
buildbot is updated).
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::start):
2009-10-29 Laszlo Gombos <Laszlo Gombos>
Reviewed by Tor Arne Vestbø.
[Qt] Implement DELETE HTTP method for XmlHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=30894
No new tests as this functionality is already tested by the
xmlhttprequest LayoutTests. As this patch depends on an unreleased
version of the dependent QtNetwork library and the tests will be
enabled later once the dependent library is released (and the
buildbot is updated).
- Api/qwebframe.cpp: (QWebFrame::load):
- 11:15 AM Changeset in webkit [50287] by
-
- 3 edits in trunk/WebCore
Part of <http://webkit.org/b/30483>.
Web Inspector: Always show the Local and Session Storage Views.
Reviewed by Timothy Hatcher.
Even if the length of the DOM Storage entry array is 0, still
generate the Datagrid because users can add things storage items
through the UI, so we should allow them to even if there isn't
anything there currently.
- English.lproj/localizedStrings.js: Removed "This Storage is Empty".
- inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
- 10:58 AM Changeset in webkit [50286] by
-
- 3 edits in trunk/WebCore
2009-10-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Add TimelinePanel into the panels enum.
- inspector/InspectorController.cpp: (WebCore::InspectorController::specialPanelForJSName):
- inspector/InspectorController.h: (WebCore::InspectorController::):
- 10:53 AM Changeset in webkit [50285] by
-
- 2 edits in trunk/WebCore
2009-10-29 Xan Lopez <xlopez@igalia.com>
Reviewed by Oliver Hunt.
[GTK] Threading problems with some of the tests
https://bugs.webkit.org/show_bug.cgi?id=30814
Create strings shared among threads with crossThreadString
constructor method.
- storage/Database.cpp: (WebCore::Database::Database):
- 10:50 AM Changeset in webkit [50284] by
-
- 3 edits in trunk/WebCore
2009-10-29 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Add support for ARGB videos.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::paint): Create the Cairo image surface for ARGB32 or RGB24 depending on the buffer's caps.
- platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_timeout_func): (webkit_video_sink_render): Handle ARGB video and convert GStreamer's ARGB to Cairo's for displaying.
- 10:42 AM Changeset in webkit [50283] by
-
- 2 edits in trunk/WebCore
2009-10-29 Anton Muhin <antonm@chromium.org>
Reviewed by David Levin.
[chromium] expose a method to access memory usage information in ChromiumBridge
Declare a static method to be implemented by http://codereview.chromium.org/332010/
https://bugs.webkit.org/show_bug.cgi?id=30829
- platform/chromium/ChromiumBridge.h:
- 10:34 AM Changeset in webkit [50282] by
-
- 3 edits in trunk/WebCore
2009-10-29 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25679
[Gtk] Improve accessibility of focusable lists
Implements the AtkSelection interface and enables the corresponding
(and expected) object:selection-changed event.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (optionFromList): (optionFromSelection): (atk_selection_interface_init): (webkit_accessible_selection_add_selection): (webkit_accessible_selection_clear_selection): (webkit_accessible_selection_ref_selection): (webkit_accessible_selection_get_selection_count): (webkit_accessible_selection_is_child_selected): (webkit_accessible_selection_remove_selection): (webkit_accessible_selection_select_all_selection): (GetAtkInterfaceTypeFromWAIType):
- accessibility/gtk/AXObjectCacheAtk.cpp: (AXObjectCache::postPlatformNotification):
- 10:27 AM Changeset in webkit [50281] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to force a rebuild.
- 10:26 AM Changeset in webkit [50280] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Steve Falkenburg.
Windows Release bots are having problems in xmlhttprequest tests, Skipping them temporarily
to see if this eliminates the problem, and it is a test causing httpd problems.
- platform/win/Skipped:
- 10:18 AM Changeset in webkit [50279] by
-
- 2 edits in trunk/WebCore
Bug 30655 - Only plain text should be copied to clipboard for TextArea.
https://bugs.webkit.org/show_bug.cgi?id=30655
Reviewed by Darin Adler.
- editing/Editor.cpp:
(WebCore::nodeIsInTextFormControl):
(WebCore::Editor::cut):
(WebCore::Editor::copy):
- 9:58 AM Changeset in webkit [50278] by
-
- 2 edits in trunk/WebCore
2009-10-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: hide timeline for now - not yet ready.
- inspector/front-end/inspector.js: (WebInspector._createPanels):
- 9:46 AM Changeset in webkit [50277] by
-
- 2 edits in trunk/WebCore
2009-10-29 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: deploy Web Inspector's images in WebCore.gypi.
- WebCore.gypi:
- 9:36 AM Changeset in webkit [50276] by
-
- 7 edits in trunk/WebCore
2009-10-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: get rid of timelineProfilerEnabled method.
- inspector/InspectorBackend.cpp:
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible):
- inspector/InspectorController.h:
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
- 9:12 AM Changeset in webkit [50275] by
-
- 2 edits in trunk/WebCore
2009-10-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Darin Fisher.
Create stub methods for raw cookies access in ChromiumBridge.h
- platform/chromium/ChromiumBridge.h:
- 8:58 AM QtWebKitContrib edited by
- (diff)
- 8:55 AM QtWebKitContrib edited by
- (diff)
- 8:44 AM Changeset in webkit [50274] by
-
- 2 edits in trunk/WebCore
Allow custom memory allocation control for WebCore's RareData
https://bugs.webkit.org/show_bug.cgi?id=30858
Reviewed by Darin Adler.
Inherits RareData struct from Noncopyable because it is
instantiated by 'new' in WebCore/css/CSSSelector.h:259 and
it is no need to be copyable.
- css/CSSSelector.h:
- 8:41 AM Changeset in webkit [50273] by
-
- 2 edits in trunk/WebCore
Allow custom memory allocation control for WebCore's ShorthandScope
https://bugs.webkit.org/show_bug.cgi?id=30859
Reviewed by Darin Adler.
Inherits ShorthandScope class from FastAllocBase because it is
instantiated by 'new' in WebCore/css/CSSParser.cpp:902 and
it is no need to be copyable.
- css/CSSParser.h:
- 8:38 AM Changeset in webkit [50272] by
-
- 2 edits in trunk/WebCore
Allow custom memory allocation control for WebCore's AXObjectCache
https://bugs.webkit.org/show_bug.cgi?id=30848
Reviewed by Darin Adler.
Inherits AXObjectCache class from FastAllocBase because it is
instantiated by 'new' in WebCore/dom/Document.cpp:1537 and
it is no need to be copyable.
- accessibility/AXObjectCache.h:
- 8:18 AM Changeset in webkit [50271] by
-
- 3 edits2 adds in trunk
2009-10-29 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Don't run JavaScript URLs in view source mode
https://bugs.webkit.org/show_bug.cgi?id=30881
Test that we don't run JavaScript URLs in view source mode.
This test actually passes before this change. I don't know how to
actually run JavaScript URLs in view source frames using DRT, but it's
possible in an abitrary embedding of WebKit.
- http/tests/security/view-source-no-javascript-url-expected.txt: Added.
- http/tests/security/view-source-no-javascript-url.html: Added.
2009-10-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Don't run JavaScript URLs in view source mode
https://bugs.webkit.org/show_bug.cgi?id=30881
Just say no.
Test: http/tests/security/view-source-no-javascript-url.html
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
- 7:43 AM Changeset in webkit [50270] by
-
- 6 edits in trunk/WebKit/qt
Remove QWebView::guessUrlFromString() and replace its use
with the new QUrl::fromUserInput() if using Qt 4.6 or newer.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-29
Reviewed by Tor Arne Vestbø.
- Api/qwebview.cpp:
- Api/qwebview.h:
- QGVLauncher/main.cpp:
(urlFromUserInput):
(WebPage::applyProxy):
(MainWindow::load):
- QtLauncher/main.cpp:
(urlFromUserInput):
(MainWindow::MainWindow):
(MainWindow::changeLocation):
- tests/qwebview/tst_qwebview.cpp:
- 6:23 AM Changeset in webkit [50269] by
-
- 2 edits in trunk/WebKit/qt
Serialize directly to the stream, and not first to an QByteArray,
that is later serialized. That is slower and also uses more bytes.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-28
Reviewed by Tor Arne Vestbø.
- Api/qwebhistory.cpp:
(operator<<):
(operator>>):
- 5:48 AM Changeset in webkit [50268] by
-
- 2 edits in trunk/WebCore
Unreviewed. Fixes style problems pointed out by Evan Martin.
- 5:46 AM Changeset in webkit [50267] by
-
- 2 edits in trunk/WebKit/gtk
Unreviewed. Trivial fix - move public API declaration into the
public subsection of the doc.
- docs/webkitgtk-sections.txt:
- 2:21 AM Changeset in webkit [50266] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Mark Rowe.
64-bit Leopard build fix after r50259
- platform/graphics/mac/ComplexTextControllerATSUI.cpp:
Declared ATSUTextInserted in 64-bit.
(WebCore::fontHasMirroringInfo): Use %d format and cast to int.
(WebCore::disableLigatures): Ditto.
(WebCore::initializeATSUStyle): Ditto.
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Ditto.
- 12:32 AM Changeset in webkit [50265] by
-
- 2 edits in trunk/JavaScriptCore
Add cacheFlush support for Thumb-2 on Linux
https://bugs.webkit.org/show_bug.cgi?id=30865
Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-10-29
Reviewed by Gavin Barraclough.
- jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
- 12:23 AM Changeset in webkit [50264] by
-
- 3 edits in trunk/WebCore
Tiger build fix after r50259
- platform/graphics/mac/ComplexTextController.h:
- platform/graphics/mac/ComplexTextControllerATSUI.cpp:
- 12:12 AM Changeset in webkit [50263] by
-
- 2 edits in trunk/WebCore
Tiger build fix after r50259
- platform/graphics/mac/ComplexTextControllerATSUI.cpp:
Oct 28, 2009:
- 11:07 PM Changeset in webkit [50262] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix changelog
- 11:06 PM Changeset in webkit [50261] by
-
- 2 edits1 add in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=30899
WebKit fails to build release on 32-bit Windows systems
Reviewed by Mark Rowe.
- WebCore.vcproj/WebCore.vcproj: Excluded files from project.
- bindings/js/JSBindingsAllInOne.cpp: Added.
- 11:04 PM Changeset in webkit [50260] by
-
- 2 edits in trunk/WebCore
Fixed typos in color names.
Reviewed by Jon Honeycutt.
- inspector/front-end/Color.js:
- 10:35 PM Changeset in webkit [50259] by
-
- 3 edits1 copy3 moves1 add2 deletes in trunk
WebCore: Share code between the ATSUI- and Core Text-based Font implementations by doing the
following:
- Generalize CoreTextController as ComplexTextController, keeping the Core Text-specific parts in ComplexTextControllerCoreText.cpp.
- Generalize FontMacCoreText as FontComplexTextMac using ComplexTextController
- Implement ATSUI-specific parts of ComplexTextController in ComplexTextControllerATSUI.
- Remove FontMacATSUI.
Reviewed by Sam Weinig.
- WebCore.xcodeproj/project.pbxproj: Removed CoreTextController.{cpp,h}, FontMacATSUI.mm,
and FontMacCoreText.cpp, and added ComplexTextController.{cpp,h},
ComplexTextControllerATSUI.cpp, ComplexTextControllerCoreText.cpp, and
FontComplexTextMac.cpp.
- platform/graphics/mac/ComplexTextController.cpp: Copied from CoreTextController.cpp and
kept the non-Core Text-specific bits.
(WebCore::ComplexTextController::ComplexTextController): Updated for renames, including
its own.
(WebCore::ComplexTextController::offsetForPosition): Updated for renames and for
m_complexTextRuns holding references instead of objects.
(WebCore::ComplexTextController::collectComplexTextRuns): Updated for renames, including
its own.
(WebCore::ComplexTextController::advance): Updated for renames.
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Updated for renames and for
m_complexTextRuns holding references instead of objects, and changed to use the glyphs()
and advances() accessors.
- platform/graphics/mac/ComplexTextController.h: Copied from CoreTextController.h and
renamed CoreTextController to ComplexTextController and CoreTextRun to ComplexTextRun. Made
the latter RefCounted, added ATSUI-specific members to it, and made some other members
Core Text-specific. Renamed m_coreTextRuns to m_complexTextRuns and made it hold references
rather than objects.
(WebCore::ComplexTextController::ComplexTextRun::create):
(WebCore::ComplexTextController::ComplexTextRun::glyphs):
(WebCore::ComplexTextController::ComplexTextRun::advances):
- platform/graphics/mac/ComplexTextControllerATSUI.cpp: Added. Includes ATSUI-specific
parts of the ComplexTextController implementation.
(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): This ATSUI
callback populates the ComplexTextRun’s glyphs, advances and indices vectors. It is invoked
when the ComplexTextRun constructor calls ATSUGetGlyphBounds().
(WebCore::isArabicLamWithAlefLigature): Helper function, copied from FontMacATSUI.mm.
(WebCore::shapeArabic): Helper function, adapted from FontMacATSUI.mm.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Sets up the
ATSUTextLayout, substituting the text buffer if necessary for things like shaping Arabic,
mirroring glyphs or directionality overrides, then calls ATSUGetGlyphBounds() in order to
get the glyphs, advances and indices vectors populated.
(WebCore::fontHasMirroringInfo): Helper function, copied from FontMacATSUI.mm.
(WebCore::disableLigatures): Ditto.
(WebCore::initializeATSUStyle): Ditto, somewhat cleaned up and simplified.
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Constructs
ComplexTextRuns, either missing-glyphs ones or ATSUTextLayout-based ones.
- platform/graphics/mac/ComplexTextControllerCoreText.cpp: Copied from
CoreTextController.cpp and kept the Core Text-specific bits.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Updated for renames,
including its own, and moved the code to initialize m_glyphs and m_advances here. Previously
this was done in adjustGlyphsAndAdvances().
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Updated for renames,
including its own.
- platform/graphics/mac/CoreTextController.cpp: Removed.
- platform/graphics/mac/CoreTextController.h: Removed.
- platform/graphics/mac/FontComplexTextMac.cpp: Renamed FontMacCoreText.cpp to this.
(WebCore::Font::selectionRectForComplexText): Changed to use ComplexTextController instead
of CoreTextController.
(WebCore::Font::drawComplexText): Ditto.
(WebCore::Font::floatWidthForComplexText): Ditto.
(WebCore::Font::offsetForPositionForComplexText): Ditto.
- platform/graphics/mac/FontMacATSUI.mm: Removed.
- platform/graphics/mac/FontMacCoreText.cpp: Removed.
LayoutTests: Removed Leopard-specific result after changing ATSUI missing-glyph behavior to match the
Core Text and fast code paths' behavior.
- platform/mac-leopard/fast/text/international/khmer-selection-expected.txt: Removed.
- 10:23 PM Changeset in webkit [50258] by
-
- 2 edits in trunk/WebKitTools
2009-10-28 Roland Steiner <rolandsteiner@chromium.org>
Adding myself to the committers list.
- Scripts/modules/committers.py:
- 9:20 PM Changeset in webkit [50257] by
-
- 2 edits in trunk/WebKitTools
Adding myself to the committers list.
- 7:48 PM Changeset in webkit [50256] by
-
- 6 edits2 adds in trunk
WebCore: WAI-ARIA: add support for 'option' role
https://bugs.webkit.org/show_bug.cgi?id=30843
Reviewed by Darin Adler.
Test: accessibility/aria-option-role.html
- accessibility/AccessibilityListBoxOption.h:
(WebCore::AccessibilityListBoxOption::canHaveChildren):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::RoleEntry::):
(WebCore::AccessibilityRenderObject::canHaveChildren):
LayoutTests: Fix video-pause-immediately.html to avoid using setTimeout().
Patch by Andrew Scherkus <scherkus@chromium.org> on 2009-10-28
Reviewed by Eric Carlson.
This also addresses the flakiness on Windows, where 200ms was not enough time to advance the clock past zero.
https://bugs.webkit.org/show_bug.cgi?id=30889
- media/video-pause-immediately.html: Replace setTimeout() with timeupdate events.
- 6:40 PM Changeset in webkit [50255] by
-
- 5 edits in trunk/JavaScriptCore
JSC JIT on ARMv7 cannot link jumps >16Mb range
https://bugs.webkit.org/show_bug.cgi?id=30891
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-28
Reviewed by Oliver Hunt.
Start planing all relative jumps as move-32-bit-immediate-to-register-BX.
In the cases where the jump would fall within a relative jump range, use a relative jump.
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::~ARMv7Assembler):
(JSC::ARMv7Assembler::LinkRecord::LinkRecord):
(JSC::ARMv7Assembler::):
(JSC::ARMv7Assembler::executableCopy):
(JSC::ARMv7Assembler::linkJump):
(JSC::ARMv7Assembler::relinkJump):
(JSC::ARMv7Assembler::setInt32):
(JSC::ARMv7Assembler::isB):
(JSC::ARMv7Assembler::isBX):
(JSC::ARMv7Assembler::isMOV_imm_T3):
(JSC::ARMv7Assembler::isMOVT):
(JSC::ARMv7Assembler::isNOP_T1):
(JSC::ARMv7Assembler::isNOP_T2):
(JSC::ARMv7Assembler::linkJumpAbsolute):
(JSC::ARMv7Assembler::twoWordOp5i6Imm4Reg4EncodedImmFirst):
(JSC::ARMv7Assembler::twoWordOp5i6Imm4Reg4EncodedImmSecond):
(JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp5i6Imm4Reg4EncodedImm):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::makeJump):
(JSC::MacroAssemblerARMv7::makeBranch):
- jit/JIT.h:
- wtf/Platform.h:
- 6:25 PM Changeset in webkit [50254] by
-
- 15 edits in trunk/JavaScriptCore
Improve for..in enumeration performance
https://bugs.webkit.org/show_bug.cgi?id=30887
Reviewed by Geoff Garen.
Improve indexing of an object with a for..in iterator by
identifying cases where get_by_val is being used with a iterator
as the subscript and replace it with a new get_by_pname
bytecode. get_by_pname then optimizes lookups that directly access
the base object.
- 5:54 PM Changeset in webkit [50253] by
-
- 12 edits in trunk/WebCore
2009-10-28 Jens Alfke <snej@chromium.org>
Reviewed by Eric Seidel.
Fix GCC compiler warnings in WebCore, and enable -Wall and -Werror for Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=30716
- WebCore.gyp/WebCore.gyp: Enable "chromium_code" flag, just on Mac build for now.
- accessibility/AccessibilityRenderObject.cpp: (WebCore::createARIARoleMap): Fix struct visibiity warning.
- bindings/v8/ScriptCallStack.h: Fix out-of-order member initialization warning.
- bindings/v8/V8Collection.h: (WebCore::getV8Object): Function in header should not be 'static' (fixes unused-static warning.)
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertNewNodeToV8Object): Fix signed/unsigned comparison warning.
- bindings/v8/V8GCController.cpp: (WebCore::ObjectGrouperVisitor::applyGrouping): Fix unused-variable warning.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Enable ListButtonPart case to avoid
warning about missing cases in 'switch' statement.
- editing/EditorCommand.cpp: (WebCore::createCommandMap): Fix struct visibiity warning.
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::State::State): Fix out-of-order member initialization warning.
- rendering/RenderMediaControlsChromium.cpp: (WebCore::RenderMediaControlsChromium::shouldRenderMediaControlPart): Add empty 'default' case in
'switch' statement to avoid missing-case warning.
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Ditto.
- xml/XPathFunctions.cpp: (WebCore::XPath::createFunctionMap): Fix struct visibiity warning.
- 5:45 PM Changeset in webkit [50252] by
-
- 2 edits in trunk/LayoutTests
2009-10-28 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Carlson.
Fix video-pause-immediately.html to avoid using setTimeout().
This also addresses the flakiness on Windows, where 200ms was not enough time to advance the clock past zero.
- media/video-pause-immediately.html: Replace setTimeout() with timeupdate events.
- 5:22 PM Changeset in webkit [50251] by
-
- 2 edits in trunk/WebCore
2009-10-28 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
REGRESSION: crashes in WebCore::RedirectScheduler::timerFired(WebCore::Timer<WebCore::RedirectScheduler>*)
https://bugs.webkit.org/show_bug.cgi?id=30839
Added null check for the case when the frame is detached from the page.
- loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::timerFired):
- 5:12 PM Changeset in webkit [50250] by
-
- 2 edits in trunk/WebCore
2009-10-28 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=30817
Use parentObjectUnignored instead of parentObject in webkit_accessible_get_parent
Also removes the hack I had originally added to solve bug 25411, because
the fix here is what I should have done in the first place.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_parent):
- 5:08 PM Changeset in webkit [50249] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Ada Chan.
Add accessibility test to the list of Windows Skipped tests.
- platform/win/Skipped:
- 4:37 PM Changeset in webkit [50248] by
-
- 2 edits in trunk/JavaScriptCore
Not reviewed, attemp to fix Windows build.
Touch the cpp file to cause recompile.
- wtf/Threading.cpp:
(WTF::threadEntryPoint):
- 4:21 PM Changeset in webkit [50247] by
-
- 4 edits in trunk
JavaScriptCore: Add MessageQueue::removeIf(Predicate&) to remove certain tasks without pulling them from the queue.
Existing Database tests cover this since Database removes tasks when it is stopped.
https://bugs.webkit.org/show_bug.cgi?id=30805
Reviewed by David Levin.
- wtf/MessageQueue.h:
(WTF::::removeIf):
WebCore: Add MessageQueue::removeIf(Predicate&) to remove certain tasks without pulling them from the queue.
Existing Database tests cover this, no change in functionality.
https://bugs.webkit.org/show_bug.cgi?id=30805
Reviewed by David Levin.
- storage/DatabaseThread.cpp:
(WebCore::SameDatabasePredicate::SameDatabasePredicate): Added predicate that flags the tasks belonging to a specified database.
(WebCore::SameDatabasePredicate::operator()):
(WebCore::DatabaseThread::unscheduleDatabaseTasks): changed to use the new removeIf method.
- 4:19 PM Changeset in webkit [50246] by
-
- 4 edits in trunk/WebCore
2009-10-28 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Glue subsequent timeline records with same category
and title together. Enable Timeline Panel!!!
- English.lproj/localizedStrings.js:
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.addRecordToTimeline): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelineRecordTreeElement.prototype.onattach): (WebInspector.TimelineRecordTreeElement.prototype.refresh):
- 3:56 PM Changeset in webkit [50245] by
-
- 10 edits in trunk
LayoutTests
Reviewed by Jan Alonzo.
[GTK] API to start inspector for a WebView
https://bugs.webkit.org/show_bug.cgi?id=22551
Unskip inspector tests that we are now able to run.
- platform/gtk/Skipped:
WebKit/gtk
Reviewed by Jan Alonzo.
[GTK] API to start inspector for a WebView
https://bugs.webkit.org/show_bug.cgi?id=22551
Provide a simple, coordinates-based API to start the inspector.
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::createPage): Use files from the source tree when running from the top of the source directory. (WebKit::InspectorClient::localizedStringsURL): Ditto.
- webkit/webkitprivate.h:
- webkit/webkitwebinspector.cpp: (webkit_web_inspector_inspect_coordinates): (webkit_web_inspector_close): (webkit_web_inspector_execute_script):
- webkit/webkitwebinspector.h:
WebKitTools
Reviewed by Jan Alonzo.
[GTK] API to start inspector for a WebView
https://bugs.webkit.org/show_bug.cgi?id=22551
Use the new inspector API to implement the LayoutTestController
interfaces used to test the inspector.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (webInspectorInspectWebView): (createWebView):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector):
- 3:42 PM Changeset in webkit [50244] by
-
- 4 edits in trunk
LayoutTests
Reviewed by Xan Lopez.
[GTK] Fails new test fast/js/navigator-language.html
https://bugs.webkit.org/show_bug.cgi?id=30440
Unskip the test that now passes.
- platform/gtk/Skipped:
WebCore
Reviewed by Xan Lopez.
[GTK] Fails new test fast/js/navigator-language.html
https://bugs.webkit.org/show_bug.cgi?id=30440
Reimplement WebCore::defaultLanguage to account for changes in
locale done by setLocale.
Already existing test: fast/js/navigator-language.html
- platform/gtk/Language.cpp: (WebCore::defaultLanguage):
- 3:40 PM Changeset in webkit [50243] by
-
- 5 edits1 delete in trunk/WebKit/win
Should not generate/build COM DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=30880
Reviewed by Sam "Horatio" Weinig.
- Interfaces/WebKit.idl: Remove generated interfaces.
- WebKit.vcproj/InterfacesGenerated.vcproj: Removed.
- WebKit.vcproj/WebKit.sln: Remove InterfacesGenerated.vcproj.
- WebKit.vcproj/WebKit.submit.sln: Remove InterfacesGenerated.vcproj.
- WebKit.vcproj/WebKit.vcproj: Remove generated interfaces.
- 3:36 PM Changeset in webkit [50242] by
-
- 10 edits in trunk
2009-10-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7303145>
Can't exit full screen mode or restart movie after pressing command -R.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::removedFromDocument): (WebCore::HTMLMediaElement::documentWillBecomeInactive):
Exit from fullscreen if necessary.
- html/HTMLMediaElement.h:
2009-10-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7303145>
Can't exit full screen mode or restart movie after pressing command -R.
- WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController _requestExit]):
New, call media element's exitFullscreen method.
(-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
Call mediaElement->exitFullscreen() after a delay as it turns around and calls
WebVideoFullscreenController:exitFullscreen.
- WebView/WebVideoFullscreenHUDWindowController.h:
- WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
New, don't give up responder status.
(-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
New, block all command key events.
(-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
Remember when we are in the process of exiting fullscreen, don't allow recursion.
- WebView/WebView.mm: (-[WebView _exitFullscreen]):
Early return if fullscreen controller is nil.
- WebView/WebWindowAnimation.h:
Correct comment about _window retain status.
- WebView/WebWindowAnimation.m: (-[WebWindowScaleAnimation dealloc]):
Don't release _window, we never reatained it.
- 3:19 PM Changeset in webkit [50241] by
-
- 5 edits in trunk
2009-10-28 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
[Qt] WebFrame::counterValueForElementById must not be exposed
https://bugs.webkit.org/show_bug.cgi?id=30882
- Api/qwebframe.cpp: (qt_drt_counterValueForElementById):
- Api/qwebframe.h:
2009-10-28 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
[Qt] WebFrame::counterValueForElementById must not be exposed
https://bugs.webkit.org/show_bug.cgi?id=30882
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::counterValueForElementById):
- 2:45 PM Changeset in webkit [50240] by
-
- 2 edits in trunk/WebCore
Unreviewed - a trivial fix to get Windows bots running.
https://bugs.webkit.org/show_bug.cgi?id=30841
<rdar://problem/7342730> WebKit should not pass Referer header through a redirect to a non-secure site
- platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::setHeaderFields): Don't try to access empty vector's data.
- 2:44 PM Changeset in webkit [50239] by
-
- 2 edits in trunk/JavaScriptCore
2009-10-28 Afonso R. Costa Jr. <afonso.costa@openbossa.org>
Reviewed by Oliver Hunt.
[Qt] Enable YARR when YARR_JIT is enabled
https://bugs.webkit.org/show_bug.cgi?id=30730
When enabling or disabling JIT using JAVASCRIPTCORE_JIT, the ENABLE_YARR should
be toggled also.
- JavaScriptCore.pri:
- 2:36 PM Changeset in webkit [50238] by
-
- 2 edits in trunk/WebCore
2009-10-28 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25897
[Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
Remove the extraneous object of ROLE_PANEL.
- accessibility/gtk/AccessibilityObjectAtk.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
- 2:29 PM Changeset in webkit [50237] by
-
- 3 edits4 adds in trunk
2009-10-28 Jonathan Dixon <joth@chromium.org>
Reviewed by Eric Seidel.
Bug 30547: (Chromium) searchbox not rendered properly due to the css property -webkit-border-radius
https://bugs.webkit.org/show_bug.cgi?id=30547
- fast/css/text-input-with-webkit-border-radius-expected.checksum: Added.
- fast/css/text-input-with-webkit-border-radius-expected.png: Added.
- fast/css/text-input-with-webkit-border-radius-expected.txt: Added.
- fast/css/text-input-with-webkit-border-radius.html: Added.
2009-10-28 Jonathan Dixon <joth@chromium.org>
Reviewed by Eric Seidel.
Bug 30547: (Chromium) searchbox not rendered properly due to the css property -webkit-border-radius
https://bugs.webkit.org/show_bug.cgi?id=30547
Test: fast/css/text-input-with-webkit-border-radius.html
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): Implemented rounded border rendering in Chromium Windows theme renderer.
- 2:17 PM Changeset in webkit [50236] by
-
- 7 edits in trunk/WebCore
2009-10-28 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Pull items collections from resources panel and
timeline panel into AbstractTimelinePanel.
- inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel): (WebInspector.AbstractTimelinePanel.prototype.populateSidebar): (WebInspector.AbstractTimelinePanel.prototype.createItemTreeElement): (WebInspector.AbstractTimelinePanel.prototype.createItemGraph): (WebInspector.AbstractTimelinePanel.prototype._showCategory): (WebInspector.AbstractTimelinePanel.prototype._hideCategory): (WebInspector.AbstractTimelinePanel.prototype.filter): (WebInspector.AbstractTimelinePanel.prototype._createGraph): (WebInspector.AbstractTimelinePanel.prototype.updateMainViewWidth): (WebInspector.AbstractTimelinePanel.prototype.refresh): (WebInspector.AbstractTimelinePanel.prototype.reset): (WebInspector.AbstractTimelinePanel.prototype.get calculator): (WebInspector.AbstractTimelinePanel.prototype.set calculator): (WebInspector.AbstractTimelinePanel.prototype.addItem): (WebInspector.AbstractTimelinePanel.prototype.removeItem): (WebInspector.AbstractTimelinePanel.prototype.refreshItem): (WebInspector.AbstractTimelinePanel.prototype.revealAndSelectItem): (WebInspector.AbstractTimelinePanel.prototype.sortItems): (WebInspector.AbstractTimelinePanel.prototype.adjustScrollPosition): (WebInspector.AbstractTimelineCategory): (WebInspector.AbstractTimelineCategory.prototype.toString):
- inspector/front-end/ResourceCategory.js: (WebInspector.ResourceCategory):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.createItemTreeElement): (WebInspector.ResourcesPanel.prototype.createItemGraph): (WebInspector.ResourcesPanel.prototype.isCategoryVisible): (WebInspector.ResourcesPanel.prototype.populateSidebar): (WebInspector.ResourcesPanel.prototype.get searchableViews): (WebInspector.ResourcesPanel.prototype.get searchResultsSortFunction.sortFuction): (WebInspector.ResourcesPanel.prototype.get searchResultsSortFunction): (WebInspector.ResourcesPanel.prototype.searchMatchFound): (WebInspector.ResourcesPanel.prototype.searchCanceled): (WebInspector.ResourcesPanel.prototype.performSearch): (WebInspector.ResourcesPanel.prototype.refresh): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.removeResource): (WebInspector.ResourcesPanel.prototype.addMessageToResource): (WebInspector.ResourcesPanel.prototype.clearMessages): (WebInspector.ResourcesPanel.prototype.refreshResource): (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): (WebInspector.ResourcesPanel.prototype.showResource): (WebInspector.ResourcesPanel.prototype._sortResourcesIfNeeded): (WebInspector.ResourcesPanel.prototype._toggleLargerResources): (WebInspector.ResourcesPanel.prototype._toggleResourceTracking): (WebInspector.ResourcesPanel.prototype.get _resources): (WebInspector.ResourceTimeCalculator.prototype._upperBound):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get categories): (WebInspector.TimelinePanel.prototype.populateSidebar): (WebInspector.TimelinePanel.prototype.addRecordToTimeline): (WebInspector.TimelinePanel.prototype.createItemTreeElement): (WebInspector.TimelinePanel.prototype.createItemGraph): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelineCategory):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- 2:05 PM Changeset in webkit [50235] by
-
- 2 edits in trunk/WebKitTools
Rubberstamped by Oliver Hunt.
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-28
Fix the warning:
"warning: ignoring return value of 'char* getcwd(char*, size_t)',
declared with attribute warn_unused_result".
by actually checking the result. In the case it is null, an
error has occoured, so treat it as the other fatal errors.
- DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::initializeFonts):
- 1:45 PM Changeset in webkit [50234] by
-
- 4 edits in trunk/WebCore
2009-10-28 Kelly Norton <knorton@google.com>
Reviewed by Pavel Feldman.
Resets InspectorFrontend in InspectorTimelineAgent instead of removing it so
that it remains active on refreshs and page transitions.
https://bugs.webkit.org/show_bug.cgi?id=30874
- inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontendProxyObject):
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::resetFrontendProxyObject):
- inspector/InspectorTimelineAgent.h:
- 1:14 PM Changeset in webkit [50233] by
-
- 28 edits2 adds8 deletes in trunk
2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555
- Api/qwebframe.cpp: (QWebFrame::counterValueForElementById): (QWebHitTestResult::frame):
- Api/qwebframe.h:
2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp: (webkit_web_frame_counter_value_for_element_by_id):
2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555
- Interfaces/IWebFramePrivate.idl:
- WebFrame.cpp: (WebFrame::counterValueForElementById):
- WebFrame.h:
2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555
Add counterValueForElement in WebFrame to call WebCore::counterValueForElement.
- Misc/WebCoreStatistics.h:
- Misc/WebCoreStatistics.mm: (-[WebFrame counterValueForElement:]):
2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555
Expose WebCore::counterValueForElement as a WebCore API.
- WebCore.base.exp:
- rendering/RenderTreeAsText.cpp: (WebCore::writeCounterValuesFromChildren): (WebCore::counterValueForElement):
- rendering/RenderTreeAsText.h:
2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555
Convert two pixel tests to dumpAsText tests using counterValueForElementById.
- fast/css/counters/t1204-increment-00-c-o-expected.txt: Added.
- fast/css/counters/t1204-increment-00-c-o.html:
- fast/css/counters/t1204-increment-01-c-o-expected.txt: Added.
- fast/css/counters/t1204-increment-01-c-o.html:
- platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.checksum: Removed.
- platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.png: Removed.
- platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.txt: Removed.
- platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.checksum: Removed.
- platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.png: Removed.
- platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.txt: Removed.
- platform/qt/fast/css/counters/t1204-increment-00-c-o-expected.txt: Removed.
- platform/qt/fast/css/counters/t1204-increment-01-c-o-expected.txt: Removed.
2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555
Define layoutTestContoller.counterValueForElementById.
- DumpRenderTree/LayoutTestController.cpp: (counterValueForElementByIdCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::counterValueForElementById):
- 1:07 PM Changeset in webkit [50232] by
-
- 2 edits in trunk/JavaScriptCore
2009-10-24 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Oliver Hunt.
Fix strict aliasing warning by switching reinterpret_cast to bitwise_cast.
strict-aliasing warnings in JSFunction.h
https://bugs.webkit.org/show_bug.cgi?id=27869
- runtime/JSFunction.h: (JSC::JSFunction::nativeFunction): (JSC::JSFunction::scopeChain): (JSC::JSFunction::setScopeChain): (JSC::JSFunction::setNativeFunction):
- 12:57 PM Changeset in webkit [50231] by
-
- 2 edits in trunk/WebCore
2009-10-28 Nate Chapin <Nate Chapin>
Unreviewed, Chromium build fix for r50225.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::defaultObjectContentType):
- 12:52 PM Changeset in webkit [50230] by
-
- 8 edits in trunk/WebCore
2009-10-28 Eric Z. Ayers <zundel@google.com>
Reviewed by Pavel Feldman.
Adds InspectorTimelineAgent instrumentation for encountering a
<SCRIPT> tag when parsing an HTML document.
- bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::startLine): (WebCore::ScriptSourceCode::url):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution):
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willLoadXHR): (WebCore::InspectorTimelineAgent::willScriptTag): (WebCore::InspectorTimelineAgent::didScriptTag):
- inspector/InspectorTimelineAgent.h: (WebCore::):
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createScriptTagTimelineRecord):
- inspector/TimelineRecordFactory.h:
- inspector/front-end/TimelineAgent.js:
- 12:23 PM Changeset in webkit [50229] by
-
- 2 edits in trunk/WebCore
2009-10-28 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
Makes sure that Geolocation watch IDs remain positive on overflow.
https://bugs.webkit.org/show_bug.cgi?id=30122
No new tests possible.
- page/Geolocation.cpp: Modified. (WebCore::Geolocation::watchPosition): Modified. Reset the watch ID to 1 on overflow.
- 12:03 PM Changeset in webkit [50228] by
-
- 2 edits in trunk/WebCore
2009-10-28 George Staikos <george.staikos@torchmobile.com>
Attempt to fix the Mac debug build after 50225.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::defaultObjectContentType):
- 11:35 AM Changeset in webkit [50227] by
-
- 1 edit in trunk/WebKit/win/WebFrame.cpp
Windows build fix, add missing #include.
- 11:15 AM Changeset in webkit [50226] by
-
- 8 edits8 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=30841
<rdar://problem/7342730> WebKit should not pass Referer header through a redirect to a non-secure site
Tests: http/tests/ssl/referer-301.html
http/tests/ssl/referer-303.html
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Remove Referer header if redirecting from https to another protocol.
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::clearHTTPReferrer): Update request counterparts, as it is always done when changing or adding header fields. (WebCore::ResourceRequestBase::clearHTTPOrigin): Ditto.
- platform/network/ResourceRequestBase.h: clearHTTPReferrer() and clearHTTPOrigin() are no longer inline, since they have non-trivial implementations.
- platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Fixed to synchronize header field removals. (WebCore::ResourceRequest::doUpdateResourceRequest): Ditto.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest):
- platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::setHeaderFields): (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest): Match Mac changes.
- 11:12 AM Changeset in webkit [50225] by
-
- 7 edits in trunk
2009-10-28 Joe Mason <jmason@rim.com>
Reviewed by Adam Treat.
Add FrameLoader::defaultObjectContentType, containing common code for
implementing FrameLoaderClient::objectContentType. (Currently the gtk
and win ports have copied this code, and the qt port uses similar code
with a few extra clauses. Moving this to a utility function cuts down
on copied code.) This causes no behavioural change.
- 11:00 AM Changeset in webkit [50224] by
-
- 5 edits in trunk
[Qt] QWebHistory::saveState() is inconsistent with the Qt API
https://bugs.webkit.org/show_bug.cgi?id=30710
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-28
Reviewed by Tor Arne Vestbø.
WebCore:
Enforce the versioning, by ignoring any version different
from 1.
- history/qt/HistoryItemQt.cpp:
(WebCore::HistoryItem::restoreState):
(WebCore::HistoryItem::saveState):
WebKit/qt:
Make the versioning internal and enforce it in the WebCore
part. Adjust the comments, as well as remove now dead code.
- Api/qwebhistory.cpp:
(operator<<):
(operator>>):
- Api/qwebhistory.h:
- 10:10 AM Changeset in webkit [50223] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-10-28 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Eric Seidel.
Added special expected test result for Tiger to fix regression tests.
https://bugs.webkit.org/show_bug.cgi?id=30811
- platform/mac-tiger/fast/js/navigator-language-expected.txt: Added.
- 10:09 AM Changeset in webkit [50222] by
-
- 2 edits in trunk/WebCore
2009-10-28 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: follow up fix to InspectorControllerStub.
Define it after inspector.js due to namespace
- inspector/front-end/inspector.html:
- 10:03 AM Changeset in webkit [50221] by
-
- 5 edits1 add in trunk/WebCore
2009-10-28 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Add InspectorController stub in order to
support opening in standalone mode.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/InspectorControllerStub.js: Added. (.WebInspector.InspectorControllerStub):
- 10:02 AM Changeset in webkit [50220] by
-
- 9 edits in trunk/WebCore
2009-10-28 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25897
[Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
Expands upon the new funtionality which allows platforms to indicate
that a particular object should not be ignored, so that they can
specify that an object should be ignored or that it should be left up
to the default handling to decide.
- accessibility/AccessibilityObject.h:
- accessibility/chromium/AccessibilityObjectChromium.cpp:
- accessibility/gtk/AccessibilityObjectAtk.cpp:
- accessibility/mac/AccessibilityObjectMac.mm:
- accessibility/qt/AccessibilityObjectQt.cpp:
- accessibility/win/AccessibilityObjectWin.cpp:
- accessibility/wx/AccessibilityObjectWx.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
- accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::accessibilityIsIgnored):
- 9:53 AM Changeset in webkit [50219] by
-
- 2 edits in trunk/WebCore
2009-10-28 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25534
[GTK] Objects of ROLE_TABLE should implement the accessible table interface
Expose the table summary as the accessible description because there is no summary object.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_description):
- 9:14 AM Changeset in webkit [50218] by
-
- 2 edits in trunk/JavaScriptCore
Use JSVALUE64 on 64-bit Windows
Patch by Jan-Arve Sæther <jan-arve.saether@nokia.com> on 2009-10-28
Reviewed by Tor Arne Vestbø.
- wtf/Platform.h: Make sure WTF_USE_JSVALUE64 is defined
- 8:10 AM Changeset in webkit [50217] by
-
- 1 edit2 adds in trunk/WebKit/qt
Pushing missing WebKit/qt/tests/qwebframe/resources/ dir from bug 29248.
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-28
[Qt] [API] Make it possible to have 'invisible' loads
https://bugs.webkit.org/show_bug.cgi?id=29248
- tests/qwebframe/resources/image2.png: Copied from WebKit/qt/tests/qwebelement/image.png.
- 6:54 AM Changeset in webkit [50216] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Holger Freyther.
Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-10-28
[Qt] Remove http/tests/security tests from
skiplist, and add only now failing tests.
- platform/qt/Skipped:
- 6:54 AM Changeset in webkit [50215] by
-
- 7 edits in trunk/WebCore
Adds ScriptController::intializeThreading(), with both JSC and V8 implementations.
https://bugs.webkit.org/show_bug.cgi?id=30678
Reviewed by Eric Seidel.
This new method is used from common code, rather than calling JSC::initializeThreading() (or the V8 equivalent) directly.
Build fix, no new tests required.
- bindings/js/ScriptController.cpp: Modified.
(WebCore::ScriptController::initializeThreading): Added.
- bindings/js/ScriptController.h: Modified. Adds ScriptController::initializeThreading().
- bindings/v8/ScriptController.cpp: Modified.
(WebCore::ScriptController::initializeThreading): Added.
- bindings/v8/ScriptController.h: Modified. Adds ScriptController::initializeThreading().
- loader/icon/IconDatabase.cpp: Modified.
(WebCore::iconDatabase): Call ScriptController::initializeThreading(), rather than JSC::initializeThreading().
- storage/Database.cpp: Modified.
(WebCore::Database::Database): Call ScriptController::initializeThreading(), rather than JSC::initializeThreading().
- 6:18 AM Changeset in webkit [50214] by
-
- 4 edits in trunk/WebKit/qt
[Qt] QWebHistory::saveState() is inconsistent with the Qt API
https://bugs.webkit.org/show_bug.cgi?id=30710
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-28
Reviewed by Holger Freyther.
Remove the QWebHistory::saveState() and ::restoreState() as
they are inconsistent with the Qt API.
Update unittests to reflect the change.
- Api/qwebhistory.cpp:
(operator<<):
(operator>>):
- Api/qwebhistory.h:
- tests/qwebhistory/tst_qwebhistory.cpp:
(saveHistory):
(restoreHistory):
(tst_QWebHistory::saveAndRestore_crash_1):
(tst_QWebHistory::saveAndRestore_crash_2):
(tst_QWebHistory::saveAndRestore_crash_3):
(tst_QWebHistory::clear):
- 4:44 AM Changeset in webkit [50213] by
-
- 3 edits in trunk/WebCore
Document a feature of the m_liveDecodedResources list.
https://bugs.webkit.org/show_bug.cgi?id=30209
Reviewed by Darin Adler.
Document a feature of the m_liveDecodedResources list.
https://bugs.webkit.org/show_bug.cgi?id=30209
The code made the assumption that the list is sorted by
the m_lastDecodedAccessTime property of the CachedResource.
The above is not true when CachedResource::setDecodedSize
is called and the item is inserted the first time. In this
case the m_lastDecodedAccessTime is still zero and the
m_liveDecodedResources list becomes unsorted.
It is impossible that Cache::pruneLiveResources will
stop to process the list too early due this feature and
the alternatives of updating m_lastDecodedAccessTime in
CachedResource::setDecodedSize or changing the insert
to search the right position have a negative impact on
performance. The best solution for now is to document
this feature.
- loader/Cache.cpp:
(WebCore::Cache::pruneLiveResources):
- loader/CachedResource.cpp:
(WebCore::CachedResource::setDecodedSize):
- 4:24 AM Changeset in webkit [50212] by
-
- 2 edits in trunk/WebKit/win
Speculative build-fix for WebElementPropertyBag.cpp
- WebElementPropertyBag.cpp: Include RenderObject.h
- 4:06 AM Changeset in webkit [50211] by
-
- 2 edits in trunk/JavaScriptCore
- jit/JIT.h:
Reviewed by NOBODY (build fix!).
- 4:05 AM Changeset in webkit [50210] by
-
- 2 edits in trunk/LayoutTests
[Qt] Remove http/tests/misc tests from
skiplist, and add only now failing tests.
Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-10-28
- platform/qt/Skipped:
- 3:23 AM Changeset in webkit [50209] by
-
- 2 edits in trunk/WebKit/qt
Complementary fix to bug 30779.
Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-27
Reviewed by Holger Freyther.
By mistake I used QWeakPointer's toStrongRef() method which docs
explicitly say to not be used in this situation (when the tracked
pointer is devired from QObject). Instead QWeakPointer's data()
is recommended.
- Api/qwebpage.cpp:
(QWebPage::view):
- 3:18 AM Changeset in webkit [50208] by
-
- 4 edits in trunk
WebCore:
2009-10-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
[Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
https://bugs.webkit.org/show_bug.cgi?id=25897
Make text controls always implement the text interface, and the
editable text interface when they are not read only. This is what
ATK-users expect.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getInterfaceMaskFromObject):
WebKit/gtk:
2009-10-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
[Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
https://bugs.webkit.org/show_bug.cgi?id=25897
Update test to also check that entries implement the AtkText
interface.
- tests/testatk.c: (run_get_text_tests): (test_webkit_atk_get_text_at_offset_forms): (test_webkit_atk_get_text_at_offset): (main):
- 3:16 AM Changeset in webkit [50207] by
-
- 7 edits in trunk
Fix assertion in SVGRenderBase::mapLocalToContainer resulting from HitTestResult::boundinBox()
https://bugs.webkit.org/show_bug.cgi?id=27347
The current HitTestResult methods are not using the (3d)
transformation aware routines. This can lead to an assertion
SVGRenderBase::mapLocalToContainer method.
Remove HitTestResult::boundingBox() as it is only used in
two places and conceptually doesn't belong into a HitTest
which is operating on points. Update the Qt and Win code
to determine the rect themselves in a (3d) transformation
fashion.
Change HitTestResult::imageRect to use the (3d) transformation
aware RenderBox::absoluteContentQuad to avoid running into
an assertion with SVG content.
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::imageRect):
- rendering/HitTestResult.h:
- WebElementPropertyBag.cpp:
(WebElementPropertyBag::Read):
- Api/qwebframe.cpp:
(QWebHitTestResultPrivate::QWebHitTestResultPrivate):
- 3:16 AM Changeset in webkit [50206] by
-
- 2 edits in trunk/WebCore
[Qt] Custom Cursor doesn't use hotspot.
Cursors loaded from a QPixmap didn't specifiy the
hotspot. Take the hotspot values from the mac
implementation.
- platform/qt/CursorQt.cpp:
- 3:16 AM Changeset in webkit [50205] by
-
- 2 edits in trunk
Export fastMalloc, fastCalloc, fastRealloc and fastFree
Export the FastMalloc functions outside of the libwebkit library
to be able to instrument memory allocations. These are C++ symbols
but do not require the C++ runtime to be useful and should be of
no harm to plain C code.
- autotools/symbols.filter:
- 3:14 AM Changeset in webkit [50204] by
-
- 2 edits in trunk/JavaScriptCore
Export fastMalloc, fastCalloc, fastRealloc and fastFree on GCC/Unix
https://bugs.webkit.org/show_bug.cgi?id=30769
When using -fvisibility=hidden to hide all internal symbols by default
the malloc symbols will be hidden as well. For memory instrumentation
it is needed to provide an instrumented version of these symbols and
override the normal routines and by changing the visibility back to
default this becomes possible.
The only other solution would be to use system malloc instead of the
TCmalloc implementation but this will not allow to analyze memory
behavior with the default allocator.
- wtf/FastMalloc.h: Define WTF_FAST_MALLOC_EXPORT for GCC and !darwin
- 2:59 AM Changeset in webkit [50203] by
-
- 8 edits9 adds in trunk/WebCore
2009-10-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by NOBODY (OOPS!).
Web Inspector: Initial revision of the Timeline grid.
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.populateSidebar): (WebInspector.AbstractTimelinePanel.prototype.refresh): (WebInspector.AbstractTimelineCalculator):
- inspector/front-end/Images/timelineBarBlue.png: Added.
- inspector/front-end/Images/timelineBarGray.png: Added.
- inspector/front-end/Images/timelineBarGreen.png: Added.
- inspector/front-end/Images/timelineBarOrange.png: Added.
- inspector/front-end/Images/timelineBarPurple.png: Added.
- inspector/front-end/Images/timelineBarRed.png: Added.
- inspector/front-end/Images/timelineBarYellow.png: Added.
- inspector/front-end/Images/timelineCheckmarks.png: Added.
- inspector/front-end/Images/timelineDots.png: Added.
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceTimeCalculator): (WebInspector.ResourceTransferSizeCalculator):
- inspector/front-end/TimelineAgent.js:
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get statusBarItems): (WebInspector.TimelinePanel.prototype.get categories): (WebInspector.TimelinePanel.prototype.populateSidebar): (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype.addItemToTimeline): (WebInspector.TimelinePanel.prototype.refresh): (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClick): (WebInspector.TimelinePanel.prototype.reset): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype.showCategory): (WebInspector.TimelinePanel.prototype.hideCategory): (WebInspector.TimelineRecordTreeElement): (WebInspector.TimelineRecordTreeElement.prototype.onattach): (WebInspector.TimelineCalculator): (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages): (WebInspector.TimelineCalculator.prototype.computePercentageFromEventTime): (WebInspector.TimelineCalculator.prototype.computeBarGraphLabels): (WebInspector.TimelineCalculator.prototype.updateBoundaries): (WebInspector.TimelineCalculator.prototype.formatValue): (WebInspector.TimelineGraph): (WebInspector.TimelineGraph.prototype.get graphElement): (WebInspector.TimelineGraph.prototype.refreshLabelPositions): (WebInspector.TimelineGraph.prototype.refresh):
- inspector/front-end/inspector.css:
- 12:48 AM Changeset in webkit [50202] by
-
- 2 edits in trunk/LayoutTests
Put tests into skiplist added in r50168 and r50162 because
layoutTestController.showWebInspector() is unimplemented now.
Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-10-28
Reviewed by Holger Freyther.
- platform/qt/Skipped:
inspector/console-format-collections.html added
inspector/javascript-syntax-highlight.html added
- 12:13 AM Changeset in webkit [50201] by
-
- 4 edits in trunk/JavaScriptCore
Rubber Stamped by Samuel Q. Weinig.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-27
Make the asserts protecting the offsets in the JIT more descriptive.
- jit/JIT.h:
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
