Timeline
Nov 6, 2009:
- 6:02 PM Changeset in webkit [50613] by
-
- 9 edits1 delete in trunk/WebCore
Fixes <http://webkit.org/b/31177>.
Web Inspector: Bind backspace to delete cookies and DOM Storage.
Reviewed by Tim Hatcher.
Refactor editing code from DOMStorageDataGrid to DataGrid, so other
places in the inspector can use editing in DataGrid (added a FIXME for
some stuff that needs to be generalized).
Also added deleting functionality to DataGrid, and implemented it for
Cookies and DOM Storage. The reason this patch is so big is because of
the refactoring of editing code, which won't be used yet in a cross-datagrid
way, but should be able to.
Additionally, moved the callbacks members from DOMStorageDataGrid to
DOMStorageItemsView, which allowed us to delete DOMStorageDataGrid, to
make the architecture of DOM Storage look a lot more like the Cookies view.
Lastly, added a preventDefault call in ElementsTreeOutline to prevent the
inspector from beeping at you when you delete an element.
- WebCore.gypi: Removed DOMStorageDataGrid.
- WebCore.vcproj/WebCore.vcproj: Removed DOMStorageDataGrid.
- inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView.prototype.dataGridForCookies):
(WebInspector.CookieItemsView.prototype._deleteButtonClicked):
(WebInspector.CookieItemsView.prototype._deleteCookieCallback):
- inspector/front-end/DOMStorageDataGrid.js: Removed.
- inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
(WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
(WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
(WebInspector.DOMStorageItemsView.prototype._editingCallback):
(WebInspector.DOMStorageItemsView.prototype.deleteSelectedRow):
(WebInspector.DOMStorageItemsView.prototype._deleteCallback):
- inspector/front-end/DataGrid.js:
(WebInspector.DataGrid):
(WebInspector.DataGrid.prototype._ondblclick): Moved from DOMStorageDataGrid to DataGrid + Refactoring.
(WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode): Ditto.
(WebInspector.DataGrid.prototype._startEditing): Ditto.
(WebInspector.DataGrid.prototype._editingCommitted.moveToNextIfNeeded): Ditto.
(WebInspector.DataGrid.prototype._editingCommitted): Ditto.
(WebInspector.DataGrid.prototype._editingCancelled): Ditto.
(WebInspector.DataGrid.prototype.handleKeyEvent): Added case for delete/backspace.
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.handleKeyEvent): Added preventDefault call.
- inspector/front-end/WebKit.qrc: Removed DOMStorageDataGrid.
- inspector/front-end/inspector.html: Removed DOMStorageDataGrid.
- 4:05 PM Changeset in webkit [50612] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix: export some symbols.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-11-06
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 3:59 PM Changeset in webkit [50611] by
-
- 2 edits in trunk/WebCore
Qt build fix: added an ExecState parameter.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-11-06
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):
- 3:54 PM Changeset in webkit [50610] by
-
- 2 edits in trunk/JavaScriptCore
Build fix: updated export file.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-11-06
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 3:48 PM Changeset in webkit [50609] by
-
- 3 edits in trunk/JavaScriptCore
Build fix: added some #includes.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-11-06
- wtf/CurrentTime.h:
- wtf/DateMath.h:
- 3:33 PM Changeset in webkit [50608] by
-
- 27 edits1 add in trunk
Rolled back in r50590 with Windows build hopefully fixed.
- 3:00 PM Changeset in webkit [50607] by
-
- 9 edits4 adds in trunk
2009-11-06 Anantanarayanan G Iyengar <ananta@chromium.org>
Reviewed by Adam Barth.
Added layout tests to test document.open and window.open calls issued
by NPAPI plugins without a calling javascript context. The associated
webkit bug is https://bugs.webkit.org/show_bug.cgi?id=31067, which
affects Chromium.
- plugins/document-open-expected.txt: Added.
- plugins/document-open.html: Added.
- plugins/window-open-expected.txt: Added.
- plugins/window-open.html: Added.
2009-11-06 Anantanarayanan G Iyengar <ananta@chromium.org>
Reviewed by Adam Barth.
The associated webkit bug is https://bugs.webkit.org/show_bug.cgi?id=31067,
which affects Chromium only.
Changes to V8HTMLDocumentCustom.cpp are as below:-
- The HTMLDocumentOpen function would cause a crash in Chromium if there was no calling javascript context. We now check for this case and pass in NULL to the HTMLDocument::open function which can handle a NULL document parameter.
- The other functions like HTMLDocumentWrite, HTMLDocumentWriteln, etc had ASSERTS for a NULL caller frame, which was bogus as it would crash anyway. We now check for this case and return a failure.
Changes to V8DOMWindowCustom.cpp are as below:-
- Instead of failing the window.open call made by NPAPI for lack of a calling javascript context, we now use the entered context as the calling context.
Tests: plugins/document-open.html
plugins/window-open.html
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
2009-11-06 Anantanarayanan G Iyengar <ananta@chromium.org>
Reviewed by Adam Barth.
Added functionality to the layout test plugin to invoke document.open and
window.open with default arguments. The associated webkit bug is
https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
work in Chromium (V8) if there is no calling javascript context. To achieve this
effect we invoke these functions in the layout test plugin in the NPP_SetWindow
for the window.open test case and in NPP_DestroyStream for the document.open test case.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (testDocumentOpen): (testWindowOpen): (pluginAllocate):
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
- DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (NPP_SetWindow): (NPP_DestroyStream):
- DumpRenderTree/win/TestNetscapePlugin/main.cpp: (NPP_New): (NPP_SetWindow): (NPP_NewStream): (NPP_DestroyStream):
- 2:58 PM Changeset in webkit [50606] by
-
- 2 edits in trunk/WebKitSite
2009-11-06 Dirk Schulze <krit@webkit.org>
Rubber stamped by Eric Seidel.
Update SVG status page. We support feMorphology now.
Set lightning filters to unimplemented.
- projects/svg/status.xml:
- 1:36 PM Changeset in webkit [50605] by
-
- 22 edits in trunk
2009-11-06 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
Geolocation error code UNKNOWN_ERROR is deprecated.
https://bugs.webkit.org/show_bug.cgi?id=31184
Update test case of the value of the PositionError.UNKNOWN_ERROR constant in error.html.
Also remove redundant test cases of the value of all PositionError constants.
- fast/dom/Geolocation/resources/error.js: Modified. Update test of value of PositionError.UNKNOWN_ERROR constant.
- fast/dom/Geolocation/error-expected.txt: Modified. Expected result for above test.
- fast/dom/Geolocation/resources/permission-denied-already-error.js: Modified. Remove tests of the value of PositionError constants.
- fast/dom/Geolocation/permission-denied-already-error-expected.txt: Modified. Expected result for above test.
- fast/dom/Geolocation/resources/permission-denied-already-success.js: Modified. Remove tests of the value of PositionError constants.
- fast/dom/Geolocation/permission-denied-already-success-expected.txt: Modified. Expected result for above test.
- fast/dom/Geolocation/resources/permission-denied.js: Modified. Remove tests of the value of PositionError constants.
- fast/dom/Geolocation/permission-denied-expected.txt: Modified. Expected result for above test.
- fast/dom/Geolocation/resources/permission-denied-stops-watches.js: Modified. Remove tests of the value of PositionError constants.
- fast/dom/Geolocation/permission-denied-stops-watches-expected.txt: Modified. Expected result for above test.
- fast/dom/Geolocation/resources/reentrant-error.js: Modified. Remove tests of the value of PositionError constants.
- fast/dom/Geolocation/reentrant-error-expected.txt: Modified. Expected result for above test.
- fast/dom/Geolocation/resources/timeout-zero.js: Modified. Remove tests of the value of PositionError constants.
- fast/dom/Geolocation/timeout-zero-expected.txt: Modified. Expected result for above test.
- fast/dom/Geolocation/resources/watch.js: Modified. Remove tests of the value of PositionError constants.
- fast/dom/Geolocation/watch-expected.txt: Modified. Expected result for above test.
2009-11-06 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
Geolocation error code UNKNOWN_ERROR is deprecated.
https://bugs.webkit.org/show_bug.cgi?id=31184
Remove this error code from PositionError, both for use from C++ code and from the JS object.
Updated fast/dom/Geolocation/error.html to test this.
- page/PositionError.h: Modified. (WebCore::PositionError::): Remove ErrorCode::UNKNOWN_ERROR.
- page/PositionError.idl: Modified. Remove UNKNOWN_ERROR constant.
- page/Geolocation.cpp: Modified. (WebCore::Geolocation::startRequest): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
- platform/gtk/GeolocationServiceGtk.cpp: Modified. (WebCore::GeolocationServiceGtk::startUpdating): Replace UNKNOWN_ERROR with POSITION_UNAVAILABLE.
- 1:08 PM Changeset in webkit [50604] by
-
- 2 edits in trunk/WebCore
2009-11-06 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
feMorphology filter is not implemented
https://bugs.webkit.org/show_bug.cgi?id=5863
The Implementation of feMorphology.
Test: We have allready a test for feMorphology
svg/W3C-SVG-1.1/filters-morph-01-f.svg
- svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply):
- 12:01 PM Changeset in webkit [50603] by
-
- 2 edits in trunk/WebCore
2009-11-06 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
V8DOMWindowCustom.cpp is missing WEB_SOCKETS guard on include.
https://bugs.webkit.org/show_bug.cgi?id=31209
Build fix only. No new tests possible.
- bindings/v8/custom/V8DOMWindowCustom.cpp: Modified. Added WEB_SOCKETS guard on inclue of WebSockets.h.
- 11:53 AM Changeset in webkit [50602] by
-
- 2 edits in trunk/WebKitTools
2009-11-06 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool crashed with exception
https://bugs.webkit.org/show_bug.cgi?id=31092
- Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
- 10:32 AM Changeset in webkit [50601] by
-
- 2 edits in trunk/WebKitSite
2009-11-06 Jeff Schiller <codedread@gmail.com>
Reviewed by Darin Adler.
SVG Status page update
https://bugs.webkit.org/show_bug.cgi?id=31179
- projects/svg/status.xml:
- 8:18 AM Changeset in webkit [50600] by
-
- 2 edits in trunk/WebCore
2009-11-06 Drew Wilson <atwilson@chromium.org>
Reviewed by David Levin.
V8 bindings do not support SharedWorkers as event targets
https://bugs.webkit.org/show_bug.cgi?id=31199
No new tests because existing layout tests suffice (they currently
crash on Chromium)
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object): Added clause to create a DOM wrapper for SharedWorkers.
- 7:19 AM Changeset in webkit [50599] by
-
- 3 edits in trunk/JavaScriptCore
Unreviewed trivial buildfix after r50595.
Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-11-06
Rename the remaining rshiftPtr calls to rshift32
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_rshift):
- jit/JITInlineMethods.h:
(JSC::JIT::emitFastArithImmToInt):
- 5:49 AM Changeset in webkit [50598] by
-
- 2 edits in trunk/WebCore
2009-11-06 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
Do not unnecessarly synchronzie in weak reference callbacks.
https://bugs.webkit.org/show_bug.cgi?id=31191
- bindings/v8/DOMData.h: (WebCore::DOMData::handleWeakObject):
- 5:41 AM Changeset in webkit [50597] by
-
- 3 edits in trunk/WebCore
2009-11-06 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Fix resource content search.
https://bugs.webkit.org/show_bug.cgi?id=31202
- inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.refresh): (WebInspector.AbstractTimelinePanel.prototype.removeItem):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelineGraph.prototype.refresh):
- 5:33 AM WebKit Team edited by
- (diff)
- 5:28 AM WebKit Team edited by
- (diff)
- 5:27 AM WebKit Team edited by
- (diff)
- 5:25 AM WebKit Team edited by
- (diff)
- 1:35 AM Changeset in webkit [50596] by
-
- 3 edits in trunk/LayoutTests
2009-11-04 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
css2.1/t040304-c64-uri-00-a-g.html is failing
https://bugs.webkit.org/show_bug.cgi?id=23271
This test isn't failing now because this test was fixed in
http://trac.webkit.org/changeset/47884
- platform/mac/css2.1/t040304-c64-uri-00-a-g-expected.checksum:
- platform/mac/css2.1/t040304-c64-uri-00-a-g-expected.png:
- 1:35 AM Changeset in webkit [50595] by
-
- 7 edits in trunk/JavaScriptCore
Tidy up the shift methods on the macro-assembler interface.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-06
Reviewed by Oliver Hunt.
Currently behaviour of shifts of a magnitude > 0x1f is undefined.
Instead defined that all shifts are masked to this range. This makes a lot of
practical sense, both since having undefined behaviour is not particularly
desirable, and because this behaviour is commonly required (particularly since
it is required bt ECMA-262 for shifts).
Update the ARM assemblers to provide this behaviour. Remove (now) redundant
masks from JITArithmetic, and remove rshiftPtr (this was used in case that
could be rewritten in a simpler form using rshift32, only optimized JSVALUE32
on x86-64, which uses JSVALUE64!)
- assembler/MacroAssembler.h:
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::lshift32):
(JSC::MacroAssemblerARM::rshift32):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::lshift32):
(JSC::MacroAssemblerARMv7::rshift32):
- assembler/MacroAssemblerX86_64.h:
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emit_op_rshift):
- 12:47 AM Changeset in webkit [50594] by
-
- 4 edits in trunk/JavaScriptCore
Rubber Stamped by Oliver Hunt.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-05
Remove a magic number (1) from the JIT, instead compute the value with OBJECT_OFFSET.
- jit/JITInlineMethods.h:
(JSC::JIT::emitPutJITStubArg):
(JSC::JIT::emitPutJITStubArgConstant):
(JSC::JIT::emitGetJITStubArg):
(JSC::JIT::emitPutJITStubArgFromVirtualRegister):
- jit/JITStubCall.h:
(JSC::JITStubCall::JITStubCall):
(JSC::JITStubCall::getArgument):
- jit/JITStubs.h:
Nov 5, 2009:
- 11:28 PM Changeset in webkit [50593] by
-
- 3 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=31159
Fix branchDouble behaviour on ARM THUMB2 JIT.
Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2009-11-05
Reviewed by Gavin Barraclough.
The x86 branchDouble behaviour is reworked, and all JIT
ports should follow the x86 port. See bug 31104 and 31151
This patch contains a fix for the traditional ARM port
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::):
(JSC::ARMAssembler::fmrs_r):
(JSC::ARMAssembler::ftosid_r):
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::):
(JSC::MacroAssemblerARM::branchDouble):
(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):
- 11:26 PM Changeset in webkit [50592] by
-
- 2 edits in trunk/WebCore
2009-11-05 Yuta Kitamura <yutak@chromium.org>
Reviewed by Eric Seidel.
Fix ASSERT(currentStyle = renderStyle()).
https://bugs.webkit.org/show_bug.cgi?id=31152
- dom/Element.cpp: (WebCore::Element::pseudoStyleCacheIsInvalid): We should have used "==" instead of "=".
- 10:52 PM Maintenance and architecture list edited by
- Changeset 50583 removed the "this is part of the KDE project" code … (diff)
- 10:52 PM Changeset in webkit [50591] by
-
- 19 edits in trunk
Rolled out r50590 because it doesn't build on Windows.
- 10:26 PM Changeset in webkit [50590] by
-
- 19 edits in trunk
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=31197
Implemented a timezone cache not based on Mac OS X's notify_check API.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-11-05
Reviewed by Oliver Hunt.
If the VM calculates the local timezone offset from UTC, it caches the
result until the end of the current VM invocation. (We don't want to cache
forever, because the user's timezone may change over time.)
This removes notify_* overhead on Mac, and, more significantly, removes
OS time and date call overhead on non-Mac platforms.
~8% speedup on Date microbenchmark on Mac. SunSpider reports maybe a tiny
speedup on Mac. (Speedup on non-Mac platforms should be even more noticeable.)
- JavaScriptCore.exp:
- interpreter/CachedCall.h:
(JSC::CachedCall::CachedCall):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
- runtime/JSGlobalObject.h:
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Made the
DynamicGlobalObjectScope constructor responsible for checking whether a
dynamicGlobalObject has already been set. This eliminated some duplicate
client code, and allowed me to avoid adding even more duplicate client
code. Made DynamicGlobalObjectScope responsible for resetting the
local timezone cache upon first entry to the VM.
- runtime/DateConstructor.cpp:
(JSC::constructDate):
(JSC::callDate):
(JSC::dateParse):
(JSC::dateUTC):
- runtime/DateConversion.cpp:
(JSC::parseDate):
- runtime/DateConversion.h:
- runtime/DateInstance.cpp:
(JSC::DateInstance::gregorianDateTime):
- runtime/DateInstance.h:
- runtime/DateInstanceCache.h:
- runtime/DatePrototype.cpp:
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
- runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
- wtf/DateMath.cpp:
(WTF::getCurrentUTCTime):
(WTF::getCurrentUTCTimeWithMicroseconds):
(WTF::getLocalTime):
(JSC::getUTCOffset): Use the new cache. Also, see below.
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::initializeDates):
(JSC::parseDateFromNullTerminatedCharacters): Simplified the way this function
accounts for the local timezone offset, to accomodate our new caching API,
and a (possibly misguided) caller in WebCore. Also, see below.
- wtf/DateMath.h:
(JSC::GregorianDateTime::GregorianDateTime): Moved most of the code in
DateMath.* into the JSC namespace. The code needed to move so it could
naturally interact with ExecState and JSGlobalData to support caching.
Logically, it seemed right to move it, too, since this code is not really
as low-level as the WTF namespace might imply -- it implements a set of
date parsing and conversion quirks that are finely tuned to the JavaScript
language. Also removed the Mac OS X notify_* infrastructure.
WebCore: https://bugs.webkit.org/show_bug.cgi?id=31197
Implemented a timezone cache not based on Mac OS X's notify_check API.
Patch by Geoffrey Garen <ggaren@apple.com> on 2009-11-05
Updated for JavaScriptCore internal API change.
- platform/network/HTTPParsers.cpp:
(WebCore::parseDate): Pass 0 for ExecState, since we don't have one.
(This function probably shouldn't be using a JavaScript date parser
to begin with, but oh well.)
- 10:25 PM Changeset in webkit [50589] by
-
- 2 edits2 deletes in trunk/LayoutTests
2009-11-05 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
Removed obsolete test case which was included in the patch for bug #30107.
This test case is already covered by the test case fast/events/drag-and-drop.html,
which was included in the patch for bug #24731.
- fast/events/drag-and-drop-none-expected.txt: Removed.
- fast/events/drag-and-drop-none.html: Removed.
- platform/win/Skipped: Removed entry for drag-and-drop-none.html.
- 10:19 PM Changeset in webkit [50588] by
-
- 4 edits in trunk/WebCore
Revert 50562 because it broke Chromium. Not reviewed since this is a build fix and revert.
Patch by Alpha Lam <hclam@chromium.org> on 2009-11-05
- bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::gcEpilogue):
- bindings/v8/V8GCController.h:
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluate):
(WebCore::V8Proxy::runScript):
(WebCore::V8Proxy::callFunction):
- 10:05 PM Changeset in webkit [50587] by
-
- 3 edits4 adds in trunk
2009-11-05 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Cross-domain access to stylesheet text should not be allowed
https://bugs.webkit.org/show_bug.cgi?id=20527
Test that a script cannot read cross-origin cssRules.
- http/tests/security/cannot-read-cssrules-expected.txt: Added.
- http/tests/security/cannot-read-cssrules-redirect-expected.txt: Added.
- http/tests/security/cannot-read-cssrules-redirect.html: Added.
- http/tests/security/cannot-read-cssrules.html: Added.
2009-11-05 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Cross-domain access to stylesheet text should not be allowed
https://bugs.webkit.org/show_bug.cgi?id=20527
Check whether whether the current document can read the cssRules from
the style sheet. Firefox throws a security error here, but we return
null instead because that's what we usually do in these cases.
Test: http/tests/security/cannot-read-cssrules-redirect.html
http/tests/security/cannot-read-cssrules.html
- css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::cssRules):
- 7:27 PM Changeset in webkit [50586] by
-
- 1 edit in trunk/WebCore/WebCore.gyp
Rubber stamped by Mark Rowe.
Adds some GYP generated files to svn:ignore
https://bugs.webkit.org/show_bug.cgi?id=31194
*.vcproj
*.rules
*.mk
*.scons
SConstruct
- 6:46 PM Changeset in webkit [50585] by
-
- 2 edits in trunk/WebCore
2009-11-05 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
If the Geolocation service fails to start, invoke the error callback asynchronously.
https://bugs.webkit.org/show_bug.cgi?id=28276
All Geolocation callbacks must be invoked asynchronously.
See http://www.w3.org/TR/geolocation-API/#geolocation_interface
No new tests possible with current LayoutTestController.
- page/Geolocation.cpp: (WebCore::Geolocation::getCurrentPosition): Modified. Asserts that startRequest returned a notifier. (WebCore::Geolocation::watchPosition): Modified. Asserts that startRequest returned a notifier. (WebCore::Geolocation::startRequest): Modified. If the Geolocation service fails to start, set a fatal error on the notifier.
- 4:05 PM Changeset in webkit [50584] by
-
- 1 edit1 add in trunk/LayoutTests
Adding a resource that seems to be missing. Without it, several tests in
fast/dom/beforeload aren't really testing if the default event handling is
prevented, but instead are only testing if the beforeload event fires.
Rubber-stamped by Gavin Barraclough.
- fast/dom/beforeload/resources/fail.js: Added.
- 3:53 PM Changeset in webkit [50583] by
-
- 253 edits in trunk
2009-11-05 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Eric Seidel.
Removed the "this is part of the KDE project" comments from
all *.h, *.cpp, *.idl, and *.pm files.
The maintenance and architecture page in the project wiki lists
this as a task.
This change includes no changes or additions to test cases
since the change affects only comments.
- wtf/wince/FastMallocWince.h:
2009-11-05 Chris Jerdonek <chris.jerdonek@gmail.com>
Reviewed by Eric Seidel.
Removed the "this is part of the KDE project" comments from
all *.h, *.cpp, *.idl, and *.pm files.
The maintenance and architecture page in the project wiki lists
this as a task.
This change includes no changes or additions to test cases
since the change affects only comments.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/IDLParser.pm:
- bindings/scripts/IDLStructure.pm:
- css/CSSInheritedValue.cpp:
- css/CSSInitialValue.cpp:
- css/CSSMediaRule.cpp:
- css/CSSNamespace.h:
- css/CSSProperty.cpp:
- css/CSSProperty.h:
- css/CSSRuleList.cpp:
- css/CSSRuleList.h:
- css/CSSSelector.h:
- css/CSSValueList.cpp:
- css/FontValue.cpp:
- css/MediaFeatureNames.cpp:
- css/MediaFeatureNames.h:
- css/Pair.h:
- css/SVGCSSStyleSelector.cpp:
- css/ShadowValue.cpp:
- css/StyleSheet.cpp:
- css/StyleSheetList.cpp:
- css/maketokenizer:
- dom/BeforeUnloadEvent.cpp:
- dom/BeforeUnloadEvent.h:
- dom/CSSMappedAttributeDeclaration.cpp:
- dom/EventNames.cpp:
- dom/EventTarget.cpp:
- dom/MappedAttributeEntry.h:
- dom/MouseRelatedEvent.h:
- dom/RangeException.h:
- dom/StyleElement.h:
- dom/Tokenizer.h:
- html/HTMLHeadElement.h:
- html/HTMLHeadingElement.cpp:
- html/HTMLHeadingElement.h:
- html/HTMLHtmlElement.h:
- html/HTMLImageLoader.h:
- html/HTMLMetaElement.h:
- html/HTMLModElement.cpp:
- html/HTMLModElement.h:
- html/HTMLOptionsCollection.cpp:
- html/HTMLPlugInElement.cpp:
- html/HTMLPreElement.cpp:
- html/HTMLPreElement.h:
- html/HTMLTableCellElement.cpp:
- html/HTMLTableCellElement.h:
- html/HTMLTableColElement.cpp:
- html/HTMLTableColElement.h:
- html/HTMLTablePartElement.cpp:
- html/HTMLTablePartElement.h:
- html/HTMLTitleElement.h:
- page/MouseEventWithHitTestResults.h:
- platform/StaticConstructors.h:
- platform/text/AtomicStringImpl.h:
- platform/text/qt/TextBreakIteratorQt.cpp:
- rendering/AutoTableLayout.h:
- rendering/CounterNode.cpp:
- rendering/EllipsisBox.cpp:
- rendering/EllipsisBox.h:
- rendering/FixedTableLayout.cpp:
- rendering/FixedTableLayout.h:
- rendering/HitTestRequest.h:
- rendering/HitTestResult.h:
- rendering/InlineRunBox.h:
- rendering/PointerEventsHitRules.cpp:
- rendering/PointerEventsHitRules.h:
- rendering/RenderBR.cpp:
- rendering/RenderBR.h:
- rendering/RenderButton.cpp:
- rendering/RenderButton.h:
- rendering/RenderFieldset.cpp:
- rendering/RenderFrameSet.cpp:
- rendering/RenderListItem.cpp:
- rendering/RenderTableRow.cpp:
- rendering/RenderView.h:
- rendering/RootInlineBox.h:
- rendering/SVGInlineTextBox.cpp:
- rendering/SVGInlineTextBox.h:
- rendering/TableLayout.h:
- rendering/break_lines.h:
- rendering/style/SVGRenderStyle.cpp:
- rendering/style/SVGRenderStyle.h:
- rendering/style/SVGRenderStyleDefs.cpp:
- rendering/style/SVGRenderStyleDefs.h:
- svg/GradientAttributes.h:
- svg/LinearGradientAttributes.h:
- svg/PatternAttributes.h:
- svg/RadialGradientAttributes.h:
- svg/SVGAElement.cpp:
- svg/SVGAngle.idl:
- svg/SVGAnimateColorElement.cpp:
- svg/SVGAnimateColorElement.h:
- svg/SVGAnimateElement.cpp:
- svg/SVGAnimateElement.h:
- svg/SVGAnimateTransformElement.h:
- svg/SVGAnimatedPathData.cpp:
- svg/SVGAnimatedPathData.h:
- svg/SVGAnimatedPoints.cpp:
- svg/SVGAnimatedPoints.h:
- svg/SVGAnimationElement.cpp:
- svg/SVGCircleElement.cpp:
- svg/SVGClipPathElement.cpp:
- svg/SVGColor.cpp:
- svg/SVGColor.idl:
- svg/SVGComponentTransferFunctionElement.cpp:
- svg/SVGComponentTransferFunctionElement.h:
- svg/SVGCursorElement.cpp:
- svg/SVGDefsElement.cpp:
- svg/SVGDescElement.cpp:
- svg/SVGDescElement.h:
- svg/SVGDocument.idl:
- svg/SVGElement.idl:
- svg/SVGElementInstanceList.cpp:
- svg/SVGElementInstanceList.h:
- svg/SVGEllipseElement.cpp:
- svg/SVGExternalResourcesRequired.cpp:
- svg/SVGFEBlendElement.cpp:
- svg/SVGFEBlendElement.h:
- svg/SVGFEColorMatrixElement.cpp:
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFEComponentTransferElement.cpp:
- svg/SVGFEComponentTransferElement.h:
- svg/SVGFECompositeElement.cpp:
- svg/SVGFECompositeElement.h:
- svg/SVGFEFloodElement.cpp:
- svg/SVGFEFloodElement.h:
- svg/SVGFEFuncAElement.cpp:
- svg/SVGFEFuncAElement.h:
- svg/SVGFEFuncBElement.cpp:
- svg/SVGFEFuncBElement.h:
- svg/SVGFEFuncGElement.cpp:
- svg/SVGFEFuncGElement.h:
- svg/SVGFEFuncRElement.cpp:
- svg/SVGFEFuncRElement.h:
- svg/SVGFEGaussianBlurElement.cpp:
- svg/SVGFEGaussianBlurElement.h:
- svg/SVGFEImageElement.cpp:
- svg/SVGFEMergeElement.cpp:
- svg/SVGFEMergeElement.h:
- svg/SVGFEMergeNodeElement.cpp:
- svg/SVGFEOffsetElement.cpp:
- svg/SVGFEOffsetElement.h:
- svg/SVGFETileElement.cpp:
- svg/SVGFETileElement.h:
- svg/SVGFETurbulenceElement.cpp:
- svg/SVGFETurbulenceElement.h:
- svg/SVGFilterElement.cpp:
- svg/SVGGElement.cpp:
- svg/SVGGradientElement.cpp:
- svg/SVGHKernElement.idl:
- svg/SVGLangSpace.cpp:
- svg/SVGLangSpace.h:
- svg/SVGLength.cpp:
- svg/SVGLength.h:
- svg/SVGLength.idl:
- svg/SVGLengthList.cpp:
- svg/SVGLengthList.h:
- svg/SVGLineElement.cpp:
- svg/SVGLinearGradientElement.h:
- svg/SVGList.h:
- svg/SVGListTraits.h:
- svg/SVGLocatable.h:
- svg/SVGMaskElement.cpp:
- svg/SVGMatrix.idl:
- svg/SVGMetadataElement.cpp:
- svg/SVGMetadataElement.h:
- svg/SVGMetadataElement.idl:
- svg/SVGNumber.idl:
- svg/SVGNumberList.cpp:
- svg/SVGNumberList.h:
- svg/SVGPaint.cpp:
- svg/SVGPathElement.cpp:
- svg/SVGPathSeg.h:
- svg/SVGPathSegArc.cpp:
- svg/SVGPathSegArc.h:
- svg/SVGPathSegClosePath.cpp:
- svg/SVGPathSegClosePath.h:
- svg/SVGPathSegCurvetoCubic.cpp:
- svg/SVGPathSegCurvetoCubic.h:
- svg/SVGPathSegCurvetoCubicSmooth.cpp:
- svg/SVGPathSegCurvetoCubicSmooth.h:
- svg/SVGPathSegCurvetoQuadratic.cpp:
- svg/SVGPathSegCurvetoQuadratic.h:
- svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
- svg/SVGPathSegCurvetoQuadraticSmooth.h:
- svg/SVGPathSegLineto.cpp:
- svg/SVGPathSegLineto.h:
- svg/SVGPathSegLinetoHorizontal.cpp:
- svg/SVGPathSegLinetoHorizontal.h:
- svg/SVGPathSegLinetoVertical.cpp:
- svg/SVGPathSegLinetoVertical.h:
- svg/SVGPathSegMoveto.cpp:
- svg/SVGPathSegMoveto.h:
- svg/SVGPatternElement.cpp:
- svg/SVGPoint.idl:
- svg/SVGPointList.cpp:
- svg/SVGPointList.h:
- svg/SVGPolyElement.cpp:
- svg/SVGPolygonElement.cpp:
- svg/SVGPolygonElement.h:
- svg/SVGPolylineElement.cpp:
- svg/SVGPolylineElement.h:
- svg/SVGPreserveAspectRatio.cpp:
- svg/SVGPreserveAspectRatio.h:
- svg/SVGRadialGradientElement.h:
- svg/SVGRect.idl:
- svg/SVGRectElement.cpp:
- svg/SVGRenderingIntent.h:
- svg/SVGSVGElement.idl:
- svg/SVGScriptElement.cpp:
- svg/SVGSetElement.cpp:
- svg/SVGSetElement.h:
- svg/SVGStopElement.cpp:
- svg/SVGStringList.cpp:
- svg/SVGStringList.h:
- svg/SVGStylable.cpp:
- svg/SVGStylable.h:
- svg/SVGStyleElement.cpp:
- svg/SVGStyleElement.h:
- svg/SVGStyledElement.h:
- svg/SVGStyledLocatableElement.cpp:
- svg/SVGStyledLocatableElement.h:
- svg/SVGStyledTransformableElement.cpp:
- svg/SVGStyledTransformableElement.h:
- svg/SVGSwitchElement.cpp:
- svg/SVGSymbolElement.cpp:
- svg/SVGTRefElement.cpp:
- svg/SVGTSpanElement.cpp:
- svg/SVGTSpanElement.h:
- svg/SVGTests.h:
- svg/SVGTextElement.cpp:
- svg/SVGTextElement.h:
- svg/SVGTextPathElement.cpp:
- svg/SVGTextPositioningElement.cpp:
- svg/SVGTextPositioningElement.h:
- svg/SVGTitleElement.cpp:
- svg/SVGTitleElement.h:
- svg/SVGTransform.cpp:
- svg/SVGTransform.h:
- svg/SVGTransform.idl:
- svg/SVGTransformList.cpp:
- svg/SVGTransformList.h:
- svg/SVGTransformable.h:
- svg/SVGURIReference.h:
- svg/SVGUnitTypes.h:
- svg/SVGUseElement.cpp:
- svg/SVGViewElement.cpp:
- svg/SVGZoomAndPan.cpp:
- svg/SVGZoomAndPan.h:
- svg/SVGZoomEvent.cpp:
- 3:28 PM Changeset in webkit [50582] by
-
- 17 edits3 moves5 adds2 deletes in trunk/LayoutTests
2009-11-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: beautify layout tests.
- inspector/console-dir-expected.txt:
- inspector/console-dir.html:
- inspector/console-dirxml-expected.txt:
- inspector/console-dirxml.html:
- inspector/console-format-collections-expected.txt:
- inspector/console-format-collections.html:
- inspector/console-format-expected.txt:
- inspector/console-format.html:
- inspector/console-tests-expected.txt:
- inspector/console-tests.html:
- inspector/console-tests.js: Added. (dumpConsoleMessages.callback): (dumpConsoleMessages): (dumpConsoleMessagesWithClasses.callback): (dumpConsoleMessagesWithClasses): (frontendScript_dumpConsoleMessages):
- inspector/css-syntax-highlight.html: Removed.
- inspector/elements-panel-structure-expected.txt:
- inspector/elements-panel-structure.html:
- inspector/elements-tests.js: Added. (frontendScript_expandDOMSubtree.processChildren): (frontendScript_expandDOMSubtree):
- inspector/evaluate-in-frontend.html:
- inspector/evaluate-in-frontend.js: Removed.
- inspector/inspector-test.js: Added. (): (evaluateInWebInspector): (notifyDone): (output): (window.didEvaluateForTestInFrontend):
- inspector/javascript-syntax-highlight.html: Removed.
- inspector/styles-iframe.html:
- inspector/syntax-highlight-css-expected.txt: Renamed from LayoutTests/inspector/css-syntax-highlight-expected.txt.
- inspector/syntax-highlight-css.html: Added.
- inspector/syntax-highlight-javascript-expected.txt: Renamed from LayoutTests/inspector/javascript-syntax-highlight-expected.txt.
- inspector/syntax-highlight-javascript.html: Added.
- inspector/syntax-highlight.js: Added. (doit.callback): (doit): (frontendScript_dumpSyntaxHighlight):
- inspector/timeline-trivial.html:
- platform/qt/Skipped:
- 3:25 PM Changeset in webkit [50581] by
-
- 5 edits in trunk/WebCore
2009-11-05 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Dimitri Glazkov.
REGRESSION Clean up security origin usage in DOM Storage.
https://bugs.webkit.org/show_bug.cgi?id=31188
Clean up security origin usage in DOM Storage. This fixes a bug in my
refactoring here: https://bugs.webkit.org/show_bug.cgi?id=31149
Instead of having StorageAreaSync's constructor (which is called in the
constructor for StorageAreaImpl) calling a method on StoargeAreaImpl to get the
database identifier, simply have StorageAreaImpl pass the identifier into
StorageAreaSync.
No test because there's no change in externally observable behavior.
- storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::StorageAreaImpl):
- storage/StorageAreaImpl.h:
- storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::create): (WebCore::StorageAreaSync::StorageAreaSync):
- storage/StorageAreaSync.h:
- 3:08 PM Changeset in webkit [50580] by
-
- 3 edits in trunk/WebCore
2009-11-05 Scott Violet <sky@google.com>
Reviewed by Dimitri Glazkov.
Need notification of scrolling frame
https://bugs.webkit.org/show_bug.cgi?id=31145
Adds FrameLoaderClient::didChangeScrollOffset that is called when
the frame scrolls. This will be used to know when history state
needs to be updated.
- loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::didChangeScrollOffset):
- page/FrameView.cpp: (WebCore::FrameView::valueChanged):
- 2:46 PM Changeset in webkit [50579] by
-
- 2 edits in trunk/LayoutTests
2009-11-05 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Adele Peterson.
The number of selected lines in textarea after a shift-PageDown
may differ. The test case is modified so that it will not depend
on the exact number of lines selected. This should resolve regression
on platforms like Qt and GTK.
https://bugs.webkit.org/show_bug.cgi?id=31122
- editing/selection/shrink-selection-after-shift-pagedown.html:
- 2:17 PM Changeset in webkit [50578] by
-
- 4 edits in trunk/WebCore
2009-11-05 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
[V8] Update bindings to use new API for external arrays
https://bugs.webkit.org/show_bug.cgi?id=31181
No new tests; covered by existing WebGL tests.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::setIndexedPropertiesToExternalArray): (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::convertToV8Object):
- bindings/v8/V8DOMWrapper.h:
- bindings/v8/custom/V8CanvasArrayCustom.h: (WebCore::constructCanvasArray):
- 1:59 PM Changeset in webkit [50577] by
-
- 3 edits in trunk/WebCore
Not reviewed, Chromium build fix.
Patch by Alpha Lam <hclam@chromium.org> on 2009-11-05
50561 introduces a custom method for SVGMatrix, we need to implement
this in V8.
- bindings/v8/custom/V8CustomBinding.h:
Adding definition for V8SVGMatrixMultiply.
- bindings/v8/custom/V8SVGMatrixCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
Implement V8SVGMatrixMultiply according to the same method in JSC.
- 1:09 PM Changeset in webkit [50576] by
-
- 2 edits in trunk/LayoutTests
2009-11-05 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: empty line in expectations build fix.
- fast/events/event-listener-map-rehash-crash-expected.txt:
- 12:42 PM Changeset in webkit [50575] by
-
- 4 edits in trunk/WebCore
Revert 50569 since it broke QT. Build fix and just a revert, so no review.
Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-11-05
- page/DOMWindow.cpp:
(WebCore::DOMWindow::sessionStorage):
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setSessionStorageEnabled):
- page/Settings.h:
(WebCore::Settings::sessionStorageEnabled):
- 12:13 PM Changeset in webkit [50574] by
-
- 16 edits4 adds in trunk
2009-11-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
REGRESSION: Web Inspector doesn't show CSS rules properly for iframes
Test: inspector/styles-iframe.html
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode):
- inspector/front-end/InjectedScript.js: (InjectedScript.getStyles): (InjectedScript.getComputedStyle): (InjectedScript.addStyleSelector):
- inspector/front-end/TestController.js: (WebInspector.TestController.prototype.notifyDone): (WebInspector.TestController.prototype.runAfterPendingDispatches): (WebInspector.evaluateForTestInFrontend.invokeMethod): (WebInspector.evaluateForTestInFrontend):
- 12:09 PM Changeset in webkit [50573] by
-
- 6 edits2 adds in trunk
WebCore:
2009-11-05 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Geoffrey Garen and Dimitri Glazkov.
Rehashing of EventListenerMap leads to loss of EvenListenerList.
https://bugs.webkit.org/show_bug.cgi?id=31027
Tested by new fast/events/event-listener-map-rehash-crash.html.
EventListenerMap modified to store pointers to listener vectors:
- dom/EventTarget.cpp: (WebCore::EventTargetData::~EventTargetData): (WebCore::EventTarget::addEventListener): (WebCore::EventTarget::removeEventListener): (WebCore::EventTarget::fireEventListeners): (WebCore::EventTarget::getEventListeners): (WebCore::EventTarget::removeAllEventListeners):
- dom/EventTarget.h:
Usages updated after interface changes:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode):
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::transferEventListenersToShadowTree):
LayoutTests:
2009-11-05 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Geoffrey Garen.
Rehashing of EventListenerMap leads to loss of EvenListenerList.
https://bugs.webkit.org/show_bug.cgi?id=31027
- fast/events/event-listener-map-rehash-crash.html: Added.
- 12:05 PM Changeset in webkit [50572] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Adam Roben.
Add ruby tests and failing accessibility test to Windows Skipped list,
we should be able to re-add ruby tests, but not sure the correct course
of action yet.
- platform/win/Skipped:
- 11:57 AM Changeset in webkit [50571] by
-
- 2 edits in trunk/WebCore
2009-11-05 Dan Kegel <dank@chromium.org>
Reviewed by Dmitri Titov.
Add missing initialization for m_createdByParser.
https://bugs.webkit.org/show_bug.cgi?id=31089
Test: fast/dom/beforeload/pi-before-load.xhtml in Valgrind
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::ProcessingInstruction):
- 11:33 AM Changeset in webkit [50570] by
-
- 2 edits in trunk/WebKitTools
2009-11-04 Eric Seidel <eric@webkit.org>
No review, just add a line which got left out of the patch uploaded for commit.
commit-queue is crashing when trying to reject patches after unknown failures
https://bugs.webkit.org/show_bug.cgi?id=31091
- Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
- 11:27 AM Changeset in webkit [50569] by
-
- 4 edits in trunk/WebCore
2009-11-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
DOM Storage runtime flag changes
https://bugs.webkit.org/show_bug.cgi?id=30602
Part 2/2.
Revert my changes to Settings and instead implement DOM Storage enabling via
the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240
This stuff was (intentionally) never exposed to web pages or DRT, so there's no
LayoutTest visible changes and thus no tests.
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_RUNTIME_ENABLER):
- page/DOMWindow.cpp: (WebCore::DOMWindow::sessionStorage):
- page/DOMWindow.idl:
- page/Settings.cpp: (WebCore::Settings::Settings):
- page/Settings.h:
- storage/Storage.cpp: (WebCore::Storage::setLocalStorageAvailable): (WebCore::Storage::localStorageAvailable): (WebCore::Storage::setSessionStorageAvailable): (WebCore::Storage::sessionStorageAvailable):
- storage/Storage.h:
- 10:33 AM Changeset in webkit [50568] by
-
- 3 edits in trunk/WebCore
Bug 31108 - [V8] REGRESSION: Pause on exception is broken
https://bugs.webkit.org/show_bug.cgi?id=31108
Reviewed by Pavel Feldman.
- bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::invokeEventHandler):
- bindings/v8/V8Utilities.cpp:
(WebCore::reportException):
- 10:14 AM Changeset in webkit [50567] by
-
- 10 edits in trunk/WebKit/win
Make CFDictionaryPropertyBag::createInstance return a COMPtr
I also cleaned up CFDictionaryPropertyBag's class declaration a little
while I was at it.
Part of <http://webkit.org/b/25294> <rdar://problem/6803127> All
WebKit/win classes should return COMPtrs from their static constructor
members
Reviewed by Steve Falkenburg.
- CFDictionaryPropertyBag.cpp:
(CFDictionaryPropertyBag::CFDictionaryPropertyBag): Changed to
initialize m_refCount to 0. m_refCount gets increased to 1 by
createInstance.
(CFDictionaryPropertyBag::createInstance): Changed to return a COMPtr.
- CFDictionaryPropertyBag.h:
- Updated copyright years
- Fixed header guard to match current style
- Replaced #include of CoreFoundation.h with forward-declaration of CFMutableDictionaryRef
- Added #include of COMPtr.h
- Fixed opening brace placement in class declaration
- Made createInstance return a COMPtr
- Made constructor/destructor private
- Made QueryInterface and IPropertyBag functions private
- Removed unnecessary parameter names and MIDL comments
- WebCache.cpp:
(WebCache::statistics): Updated for change to
CFDictionaryPropertyBag::createInstance. Now uses releaseRef to place
the IPropertyBag pointers into the s array.
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidFailToStartPlugin):
- WebDatabaseManager.cpp:
(WebDatabaseManager::dispatchDidModifyDatabase):
- WebFrame.cpp:
(WebFrame::createJavaAppletWidget):
Updated for change to CFDictionaryPropertyBag::createInstance.
- WebHistory.cpp: Removed releaseUserInfo, which is no longer needed.
That function was also doing an unnecessary call to setDictionary(0).
(createUserInfoFromArray):
(createUserInfoFromHistoryItem):
Changed to return COMPtr.
(WebHistory::loadFromURL): Updated for change to
CFDictionaryPropertyBag::createInstance.
(WebHistory::removeAllItems): Updated for change to
CFDictionaryPropertyBag::createInstance, which fixed a leak! We had
forgotten to call releaseUserInfo here.
(WebHistory::removeItem):
(WebHistory::addItem):
(WebHistory::visitedURL):
- WebIconDatabase.cpp:
(postDidAddIconNotification):
Updated for change to CFDictionaryPropertyBag::createInstance.
- WebKitClassFactory.cpp:
(releaseRefFromCreateInstance): Added this overloaded function
template to abstract away the difference between createInstance
functions that return a ref'd pointer and createInstance functions
that return a COMPtr.
(WebKitClassFactory::CreateInstance): Changed to use
releaseRefFromCreateInstance.
- 9:59 AM Changeset in webkit [50566] by
-
- 4 edits2 adds in trunk
WebCore: We should not bubble up events if we drag something to an iframe that
has an invalid source.
https://bugs.webkit.org/show_bug.cgi?id=30469
Reviewed by Dmitri Titov.
Test: http/tests/misc/bubble-drag-events.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleDragAndDropForTarget):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::cancelDragAndDrop):
(WebCore::EventHandler::performDragAndDrop):
- page/EventHandler.h:
(WebCore::EventHandler::):
LayoutTests: Tests the drag event bubbling on different targets:
- iframe with invalid source
- iframe with valid source
- non-iframe droppable element
https://bugs.webkit.org/show_bug.cgi?id=30469
Reviewed by Dmitri Titov.
- http/tests/misc/bubble-drag-events-expected.txt: Added.
- http/tests/misc/bubble-drag-events.html: Added.
- 8:42 AM Changeset in webkit [50565] by
-
- 2 edits in trunk/WebKitTools
Remove bogus else clause in bugzilla-tool
Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
create-bug raises exception after entering bug description
Reviewed by David Kilzer.
- Scripts/bugzilla-tool:
(CreateBug): else clauses are only hit if no exception is raised, so
it makes no sense to try to re-raise the exception in an else clause.
The exception will automatically be re-raised if it doesn't match any
of the except clauses, so we don't have to do anything special here at
all to get the desired behavior.
- 7:58 AM Changeset in webkit [50564] by
-
- 2 edits in trunk/WebCore
2009-11-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: speed up Timelines Clear by a factor of thousands.
- inspector/front-end/utilities.js: (Element.prototype.removeChildren):
- 7:48 AM Changeset in webkit [50563] by
-
- 2 edits in trunk/WebKit/qt
2009-11-05 Shu Chang <Chang.Shu@nokia.com>
Reviewed by Tor Arne Vestbø.
Add support for Shift-PageUp and Shift-PageDown key events.
https://bugs.webkit.org/show_bug.cgi?id=31166
Test: LayoutTests/editing/selection/shrink-selection-after-shift-pagedown.html
- WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):
- 7:36 AM Changeset in webkit [50562] by
-
- 4 edits in trunk/WebCore
2009-11-05 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
If high memory usage is detected, hint to V8 that it might be due
to external objects retained by V8 objects.
https://bugs.webkit.org/show_bug.cgi?id=31051
- bindings/v8/V8GCController.cpp: (WebCore::GetMemoryUsageInMB): (WebCore::V8GCController::gcEpilogue): (WebCore::V8GCController::checkMemoryUsage):
- bindings/v8/V8GCController.h:
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluate): (WebCore::V8Proxy::runScript): (WebCore::V8Proxy::callFunction):
- 7:28 AM Changeset in webkit [50561] by
-
- 4 edits2 adds in trunk
2009-11-05 Jeff Schiller <codedread@gmail.com>
Reviewed by Simon Fraser.
Added test to ensure proper order of matrix multiplication with SVGMatrix.
https://bugs.webkit.org/show_bug.cgi?id=16062
- svg/dom/SVGMatrix-interface-expected.txt: Added.
- svg/dom/SVGMatrix-interface.xhtml: Added.
2009-11-05 Jeff Schiller <codedread@gmail.com>
Reviewed by Simon Fraser.
Correct order of matrix multiplication for SVGMatrix.
https://bugs.webkit.org/show_bug.cgi?id=16062
Test: svg/dom/SVGMatrix-interface.xhtml
- bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::multiply):
- svg/SVGMatrix.idl:
- 2:06 AM Changeset in webkit [50560] by
-
- 4 edits in trunk/WebCore
2009-11-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Make resource-related records in timeline
actually take some time.
- English.lproj/localizedStrings.js:
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype._getRecordDetails): (WebInspector.TimelinePanel.prototype.reset):
- 1:51 AM Changeset in webkit [50559] by
-
- 2 edits in trunk
2009-11-05 Priit Laes <plaes@plaes.org>
Reviewed by Jan Alonzo.
[Gtk] Build failure with --enable-introspection
https://bugs.webkit.org/show_bug.cgi?id=31102
Add search and include paths for JSCore-1.0.gir required by
gobject-introspection tools.
- GNUmakefile.am:
- 1:31 AM Changeset in webkit [50558] by
-
- 6 edits in trunk/WebCore
2009-11-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Simplify LocalStorageThread
https://bugs.webkit.org/show_bug.cgi?id=30935
This is a re-submit of 50519. LocalStorageTask should have never been ref
counted. I've removed that and switched a PassRefPtr over to a PassOwnPtr.
On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
of the method names a bit more clear. Assert proper thread usage. Join rather
than detaching the thread and doing an ad-hoc form of join. Avoid touching
variables on the background thread when simple to do so. Also create a generic
scheduleTask function rather than one for each task.
No behavior should have changed.
- storage/LocalStorageTask.h:
- storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::create): (WebCore::LocalStorageThread::LocalStorageThread): (WebCore::LocalStorageThread::~LocalStorageThread): (WebCore::LocalStorageThread::start): (WebCore::LocalStorageThread::threadEntryPointCallback): (WebCore::LocalStorageThread::threadEntryPoint): (WebCore::LocalStorageThread::scheduleTask): (WebCore::LocalStorageThread::terminate): (WebCore::LocalStorageThread::performTerminate):
- storage/LocalStorageThread.h:
- storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::StorageSyncManager): (WebCore::StorageSyncManager::~StorageSyncManager): (WebCore::StorageSyncManager::scheduleImport): (WebCore::StorageSyncManager::scheduleSync):
- storage/StorageSyncManager.h:
- 12:58 AM Changeset in webkit [50557] by
-
- 5 edits in trunk/WebCore
2009-11-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Calling databaseIdentifier on LocalStorage's background thread is not safe.
https://bugs.webkit.org/show_bug.cgi?id=31149
Calling SecurityOrigin::databaseIdentifier on LocalStorage's background thread
is not safe. databaseIdentifier does a bunch of string concatenation which
ref-counts StringImpls in some cases. This was caught by valgrind thread
sanitizer: http://code.google.com/p/chromium/issues/detail?id=25645
There's no way to test for such racyness, unfortunately.
- storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::StorageAreaSync): (WebCore::StorageAreaSync::performImport):
- storage/StorageAreaSync.h:
- storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::fullDatabaseFilename):
- storage/StorageSyncManager.h:
- 12:40 AM Changeset in webkit [50556] by
-
- 2 edits in trunk/WebKit/qt
Last Qt 4.5 build fix (*sigh*)
Patch by Simon Hausmann <Simon Hausmann> on 2009-11-05
- tests/qwebpage/tst_qwebpage.cpp:
(inputMethodHints): inputMethodHints() is only used for
Qt 4.6, so guard the whole function.
- 12:36 AM Changeset in webkit [50555] by
-
- 4 edits in trunk/WebCore
2009-11-03 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Clean up StorageAreaSync
https://bugs.webkit.org/show_bug.cgi?id=31100
Major fixes: Break the ref count cycle for StorageArea on the main
thread, not the background thread since the latter is not safe.
Length() needs to block on the import completing.
Small fixes: setItem needs to handle the copy on write case even if it
has an exception. setItem and removeItem should just bail from the
the function if the value hasn't changed rather than wrapping the end
in an if block. Clear should only send an event if it wasn't already
cleared. StorageAreaSync should assert that the final sync was
scheduled.
- storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::length): Forgot to block on the import. (WebCore::StorageAreaImpl::key): (WebCore::StorageAreaImpl::setItem): Handle the copy on write case even when there's an exception. (WebCore::StorageAreaImpl::removeItem): (WebCore::StorageAreaImpl::clear):
- storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::~StorageAreaSync): (WebCore::StorageAreaSync::scheduleFinalSync): (WebCore::StorageAreaSync::performImport): (WebCore::StorageAreaSync::markImported): (WebCore::StorageAreaSync::blockUntilImportComplete):
- storage/StorageAreaSync.h:
- 12:34 AM Web Inspector edited by
- Adding latest blog post (diff)
- 12:30 AM Changeset in webkit [50554] by
-
- 2 edits in trunk/WebKit/qt
Another prospective build fix against Qt 4.5 (build bot)
Patch by Simon Hausmann <Simon Hausmann> on 2009-11-05
Don't compile & run the QGraphicsWebView portion of the
input methods auto test with Qt 4.5.
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::inputMethods_data):
(inputMethodHints):
(inputMethodEnabled):
(tst_QWebPage::inputMethods):
- 12:28 AM Changeset in webkit [50553] by
-
- 3 edits in trunk/JavaScriptCore
Use ARMv7 specific encoding for immediate constants on ARMv7 target
https://bugs.webkit.org/show_bug.cgi?id=31060
Patch by Gabor Loki <loki@inf.u-szeged.hu> on 2009-11-05
Reviewed by Gavin Barraclough.
- assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::getOp2): Use INVALID_IMM
(JSC::ARMAssembler::getImm): Use encodeComplexImm for complex immediate
(JSC::ARMAssembler::moveImm): Ditto.
(JSC::ARMAssembler::encodeComplexImm): Encode a constant by one or two
instructions or a PC relative load.
- assembler/ARMAssembler.h: Use INVALID_IMM if a constant cannot be
encoded as an immediate constant.
(JSC::ARMAssembler::):
(JSC::ARMAssembler::movw_r): 16-bit immediate load
(JSC::ARMAssembler::movt_r): High halfword 16-bit immediate load
(JSC::ARMAssembler::getImm16Op2): Encode immediate constant for
movw_r and mowt_r
- 12:23 AM Changeset in webkit [50552] by
-
- 2 edits in trunk/WebKit/qt
Prospective build fix against Qt 4.5 (build bot)
Patch by Simon Hausmann <Simon Hausmann> on 2009-11-05
- Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::setInputMethodEnabled): Guard the
use of Qt 4.6 specific API with #ifdefs.
- 12:12 AM Changeset in webkit [50551] by
-
- 3 edits in trunk/WebKit/qt
[Qt] Fix enabling of input method support on QGraphicsWebView.
https://bugs.webkit.org/show_bug.cgi?id=30605
Patch by Simon Hausmann <Simon Hausmann> on 2009-11-01
Reviewed by Kenneth Christiansen.
Instead of setting the unsupported widget attribute on the
QGraphicsWidget in setInputMethodEnabled() set the
ItemAcceptsInputMethod GraphicsItem flag directly.
Changed the existing input method auto test to run once
on a QWebView and once on a QGraphicsWebView.
- Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::setInputMethodEnabled):
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::inputMethods_data):
(inputMethodHints):
(inputMethodEnabled):
(tst_QWebPage::inputMethods):
- 12:11 AM Changeset in webkit [50550] by
-
- 4 edits in trunk/WebKit/qt
Added QGraphicsWebView::modified property, for consistency
with QWebView.
Patch by Simon Hausmann <Simon Hausmann> on 2009-11-04
Reviewed by Kenneth Christiansen.
- Api/qgraphicswebview.cpp:
(QGraphicsWebView::isModified):
- Api/qgraphicswebview.h:
- tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::qgraphicswebview):
- 12:11 AM Changeset in webkit [50549] by
-
- 4 edits in trunk/WebKit/qt
Removed status and progress properties of QGraphicsWebView.
Added loadProgress and statusBarMessage signals instead,
after API review.
Patch by Simon Hausmann <Simon Hausmann> on 2009-11-04
Reviewed by Kenneth Christiansen.
- Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
(QGraphicsWebView::setPage):
- Api/qgraphicswebview.h:
- tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::qgraphicswebview):
Nov 4, 2009:
- 11:53 PM Changeset in webkit [50548] by
-
- 2 edits in trunk/WebCore
Allow custom memory allocation control for WebCore's CachedResource
https://bugs.webkit.org/show_bug.cgi?id=31114
Reviewed by Eric Seidel.
Inherits CachedResource class from Noncopyable because its (its child
class) CachedCSSStyleSheet instantiated by 'new' in WebCore/loader/Cache.cpp:75
and it is no need to be copyable.
- loader/CachedResource.h:
- 11:07 PM Changeset in webkit [50547] by
-
- 3 edits in trunk/WebKitTools
2009-11-04 Eric Seidel <eric@webkit.org>
Reviewed by David Kilzer.
svn-apply's fixChangeLogPatch function seems broken
https://bugs.webkit.org/show_bug.cgi?id=30683
Update fixChangeLogPatch to be able to handle patches which
don't start at line 1.
Add unit tests for svn-apply to scm_unittest.py.
- Scripts/VCSUtils.pm:
- Scripts/modules/scm_unittest.py:
- 10:52 PM Changeset in webkit [50546] by
-
- 4 edits in trunk
2009-11-04 Mark Mentovai <mark@chromium.org>
Reviewed by Mark Rowe.
Provide TARGETING_TIGER and TARGETING_LEOPARD as analogues to
BUILDING_ON_TIGER and BUILDING_ON_LEOPARD. The TARGETING_ macros
consider the deployment target; the BUILDING_ON_ macros consider the
headers being built against.
- wtf/Platform.h:
2009-11-04 Mark Mentovai <mark@chromium.org>
Reviewed by Mark Rowe.
Separate the difference between HAVE(CGINTERPOLATION_MEDIUM), which
is true when building on 10.6 or later, and USE(CGINTERPOLATION_MEDIUM)
which is true when targeting 10.6 or later.
HAVE(CGINTERPOLATION_MEDIUM) indicates that kCGInterpolationMedium
is present in the CGInterpolationQuality enum, and must be handled
by a switch that has cases for each enumerated value.
USE(CGINTERPOLATION_MEDIUM) indicates that the product will only run
on 10.6 or later, and that CoreGraphics will understand when
InterpolationMedium is mapped to kCGInterpolationMedium at runtime.
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setImageInterpolationQuality): (WebCore::GraphicsContext::imageInterpolationQuality):
- 10:39 PM Changeset in webkit [50545] by
-
- 2 edits in trunk/WebCore
2009-11-04 Dan Kegel <dank@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix buffer overrun in WebCore::Page::userStyleSheetLocationChanged()
https://bugs.webkit.org/show_bug.cgi?id=31138
Test: LayoutTests/platform/mac/fast/loader/user-stylesheet-fast-path.html in Valgrind
- page/Page.cpp: (WebCore::Page::userStyleSheetLocationChanged):
- 10:27 PM Changeset in webkit [50544] by
-
- 3 edits in trunk/WebCore
Update the Web Inspector Timeline panel to better match the mock-up.
https://bugs.webkit.org/show_bug.cgi?id=31150
Reviewed by Pavel Feldman.
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._getRecordDetails):
(WebInspector.TimelinePanel.prototype._dragWindow):
(WebInspector.TimelinePanel.prototype._resizeWindowLeft):
(WebInspector.TimelinePanel.prototype._resizeWindowRight):
(WebInspector.TimelineCategoryTreeElement.prototype.onattach):
(WebInspector.TimelineRecordTreeElement.prototype.onattach):
(WebInspector.TimelineRecordTreeElement.prototype.refresh):
(WebInspector.TimelineCategoryGraph):
- inspector/front-end/inspector.css:
- 9:33 PM Changeset in webkit [50543] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fixed typos.
- 9:25 PM Changeset in webkit [50542] by
-
- 6 edits6 adds in trunk
WebCore:
2009-11-02 Justin Garcia <justin.garcia@apple.com>
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=25439
Deleting when in front of a block image removes character from previous paragraph
Added editing/deleting/25439-{1,2,3}.html
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): Block images, tables and HRs cannot be made inline with other content. Instead of merging, just move the caret to just before the selection we deleted.
- editing/htmlediting.cpp: (WebCore::firstInSpecialElement): Added a FIXME. This function begins iterating up from pos.node(), which doesn't necessarily contain pos (suppose pos was [img, 0]). (WebCore::lastInSpecialElement): Ditto. (WebCore::isRenderedAsNonInlineTableImageOrHR): Moved from visible_units.cpp. Added a check for non-inline images.
- editing/htmlediting.h:
- editing/visible_units.cpp: (WebCore::startOfParagraph): Use moved/renamed function. Removed FIXME. The problem causing 5027702 is now squarely in first/lastInSpecialElement (WebCore::endOfParagraph): Ditto.
LayoutTests:
2009-11-03 Justin Garcia <justin.garcia@apple.com>
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=25439
Deleting when in front of a block image removes character from previous paragraph
- editing/deleting/delete-before-block-image-1-expected.txt: Added.
- editing/deleting/delete-before-block-image-1.html: Added.
- editing/deleting/delete-before-block-image-2-expected.txt: Added.
- editing/deleting/delete-before-block-image-2.html: Added.
- editing/deleting/delete-before-block-table-expected.txt: Added.
- editing/deleting/delete-before-block-table.html: Added.
- 9:02 PM Changeset in webkit [50541] by
-
- 2 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=31151
Fix branchDouble behaviour on ARM THUMB2 JIT.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-04
Reviewed by Oliver Hunt.
The ARMv7 JIT is currently using ARMv7Assembler::ConditionEQ to branch
for DoubleEqualOrUnordered, however this is incorrect – ConditionEQ won't
branch on unordered operands. Similarly, DoubleLessThanOrUnordered &
DoubleLessThanOrEqualOrUnordered use ARMv7Assembler::ConditionLO &
ARMv7Assembler::ConditionLS, whereas they should be using
ARMv7Assembler::ConditionLT & ARMv7Assembler::ConditionLE.
Fix these, and fill out the missing DoubleConditions.
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::):
(JSC::MacroAssemblerARMv7::branchDouble):
- 7:29 PM Changeset in webkit [50540] by
-
- 3 edits in trunk/JavaScriptCore
Rubber Stamped by Oliver Hunt.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-04
Enable native call optimizations on ARMv7. (Existing ARM_TRADITIONAL
implementation was generic, worked perfectly, just needed turning on).
- jit/JITOpcodes.cpp:
- wtf/Platform.h:
- 7:04 PM Changeset in webkit [50539] by
-
- 2 edits in trunk/JavaScriptCore
Rubber Stamped by Mark Rowe, Oliver Hunt, and Sam Weinig.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-04
Add a missing assert to the ARMv7 JIT.
- assembler/ARMv7Assembler.h:
(JSC::ARMThumbImmediate::ARMThumbImmediate):
- 6:22 PM Changeset in webkit [50538] by
-
- 2 edits in trunk/JavaScriptCore
Remove bogus op_ prefix on dumped version of three opcodes.
Rubber-stamped by Oliver Hunt.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
- 6:22 PM Changeset in webkit [50537] by
-
- 3 edits in trunk/JavaScriptCore
Fix dumping of constants in bytecode so that they aren't printed as large positive register numbers.
Reviewed by Sam Weinig.
We do this by having the registerName function return information about the constant if the register
number corresponds to a constant. This requires that registerName, and several functions that call it,
be converted to member functions of CodeBlock so that the constant value can be retrieved. The
ExecState also needs to be threaded down through these functions so that it can be passed on to
constantName when needed.
- bytecode/CodeBlock.cpp:
(JSC::constantName):
(JSC::CodeBlock::registerName):
(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::CodeBlock::dump):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::isConstantRegisterIndex):
- 5:42 PM Changeset in webkit [50536] by
-
- 4 edits2 adds in trunk
WebCore: Hang in Mail on attempting to change indent level.
<rdar://problem/7131805>
https://bugs.webkit.org/show_bug.cgi?id=31127
Reviewed by Adele Peterson.
The hang was caused by an infinite loop inside outdentRegion.
The code did not account for the fact that, when a list item
cointains multiple paragraphs, outdent moves all paragraphs at
once, invalidating some of the position we keep track of in the loop.
Some code refactoring has also been done to minimize duplicate code.
Test: editing/execCommand/outdent-multiparagraph-list.html
- editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::indentRegion): Moved code in common with
outdentRegion to doApply.
(WebCore::IndentOutdentCommand::outdentRegion): Fixed endless loop.
(WebCore::IndentOutdentCommand::doApply): Some code refactoring.
- editing/IndentOutdentCommand.h: Added VisiblePosition parameters to
indentRegion and outdentRegion.
LayoutTests: Hang in Mail on attempting to change indent level
<rdar://problem/7131805>
https://bugs.webkit.org/show_bug.cgi?id=31127
Reviewed by Adele Peterson.
Added test to cover all the different code paths.
- editing/execCommand/outdent-multiparagraph-list-expected.txt: Added.
- editing/execCommand/outdent-multiparagraph-list.html: Added.
- 4:50 PM Changeset in webkit [50535] by
-
- 2 edits in trunk/WebCore
2009-11-04 Alpha Lam <hclam@chromium.org>
Reviewed by Eric Carlson.
Volume slider doesn't have a thumb
https://bugs.webkit.org/show_bug.cgi?id=31135
Fixed an incorrect if statement that prevents volume slider
being updated.
The statement checks if the slider value equals to the current
volume value of the media control to avoid updating the volume
slider. Updating the volume slider control shouldn't be within
this condition because we explicitly set them to be equals
during creation of the controls and also when mouse events are
received on the volume control.
No new tests because existing code breaks:
LayoutTests/media/video-volume-slider.html
It should now start passing on Chromium.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlVolumeSliderElement::update): Update the volume slider regardless of the current volume value of the media control.
- 4:35 PM Changeset in webkit [50534] by
-
- 6 edits in trunk/WebCore
Need to properly disable applicationCache at runtime
https://bugs.webkit.org/show_bug.cgi?id=30417
Patch by Jenn Braithwaite <jennb@chromium.org> on 2009-11-04
Reviewed by David Levin.
Adding applicationCacheEnabled bit to V8 RuntimeEnabledFeatures.
No new exposed functionality, so no new tests.
- bindings/v8/RuntimeEnabledFeatures.cpp:
- bindings/v8/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setApplicationCacheEnabled):
(WebCore::RuntimeEnabledFeatures::applicationCacheEnabled):
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::ACCESSOR_RUNTIME_ENABLER):
- page/DOMWindow.idl:
- 4:12 PM Changeset in webkit [50533] by
-
- 2 edits in trunk/JavaScriptCore
2009-11-04 Pavel Heimlich <tropikhajma@gmail.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=30647
Solaris build failure due to strnstr.
- wtf/StringExtras.h: Enable strnstr on Solaris, too.
- 3:59 PM Changeset in webkit [50532] by
-
- 3 edits in trunk/LayoutTests
2009-11-04 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
Changed data format type from "text" to "text/plain" to pass Chrome tests.
- fast/events/drag-and-drop-dataTransfer-types-nocrash-expected.txt:
- fast/events/drag-and-drop-dataTransfer-types-nocrash.html:
- 3:59 PM Changeset in webkit [50531] by
-
- 6 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=31104
Refactor x86-specific behaviour out of the JIT.
Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-04
Reviewed by Oliver Hunt.
- Add explicit double branch conditions for ordered and unordered comparisons (presently the brehaviour is a mix).
- Refactor double to int conversion out into the MacroAssembler.
- Remove broken double to int conversion for !JSVALUE32_64 builds - this code was broken and slowing us down, fixing it showed it not to be an improvement.
- Remove exclusion of double to int conversion from (1 % X) cases in JSVALUE32_64 builds - if this was of benefit this is no longer the case; simplify.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::):
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::):
(JSC::MacroAssemblerX86Common::convertInt32ToDouble):
(JSC::MacroAssemblerX86Common::branchDouble):
(JSC::MacroAssemblerX86Common::branchConvertDoubleToInt32):
- jit/JITArithmetic.cpp:
(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_div):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emitSlow_op_jnlesseq):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jfalse):
- 3:48 PM Changeset in webkit [50530] by
-
- 2 edits in trunk/WebCore
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=31143
Assertion failure in CredentialStorage::set() when proxy credentials are being set
No test, cannot test proxy behavior.
- platform/network/CredentialStorage.cpp: (WebCore::CredentialStorage::set): Account for the possibility of null url. Release mode changes are likely inconsequential - e.g. we used to add ":" to origin set, which is weird, but safe.
- 2:21 PM Changeset in webkit [50529] by
-
- 2 edits in trunk/WebCore
2009-11-04 Patrick Mueller <Patrick_Mueller@us.ibm.com>
Reviewed by Timothy Hatcher.
Web Inspector: Leftover Breakpoints in the Sidebar Pane
https://bugs.webkit.org/show_bug.cgi?id=30659
No new tests.
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.addScript):
- 1:44 PM Changeset in webkit [50528] by
-
- 7 edits in trunk/WebCore
2009-11-04 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Timothy Hatcher.
WebInspector: Use a different method to identify the webkit port in
InspectorBackent::platform().
This corrects the inspector expected behavior with Qt on Windows.
https://bugs.webkit.org/show_bug.cgi?id=31116
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::platform): (WebCore::InspectorBackend::port):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/front-end/InspectorControllerStub.js: (.WebInspector.InspectorControllerStub.prototype.port):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.toolbarDragStart):
- 1:00 PM Changeset in webkit [50527] by
-
- 7 edits in trunk
2009-11-04 Benjamin Otte <otte@gnome.org>
Reviewed by Gustavo Noronha.
Update Cairo requirement to 1.6.
- configure.ac:
2009-11-04 Benjamin Otte <otte@gnome.org>
Reviewed by Gustavo Noronha.
Update Cairo requirement to 1.6.
Also remove all conditional code and workarounds for older versions of
Cairo.
In particular, gain image quality by removing the use of
CAIRO_FILTER_NEAREST when rendering images and use the default
bilinear filter instead.
https://bugs.webkit.org/show_bug.cgi?id=19266
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clipOut):
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw): (WebCore::BitmapImage::drawPattern):
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::isEmpty): (WebCore::Path::boundingRect):
- platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozWidget):
- 12:46 PM Changeset in webkit [50526] by
-
- 2 edits in trunk/WebCore
wx build fix. Restore removed string conversion after cleanup.
- 12:22 PM Changeset in webkit [50525] by
-
- 15 edits2 adds in trunk
2009-11-04 Chris Fleizach <Chris Fleizach>
Reviewed by Beth Dakin.
Need to implement ARIA role="combobox"
https://bugs.webkit.org/show_bug.cgi?id=31096
- accessibility/aria-combobox.html: Added.
- platform/gtk/Skipped:
- platform/mac/accessibility/aria-combobox-expected.txt: Added.
- platform/win/Skipped:
2009-11-04 Chris Fleizach <Chris Fleizach>
Reviewed by Beth Dakin.
Need to implement ARIA role="combobox"
https://bugs.webkit.org/show_bug.cgi?id=31096
Test: accessibility/aria-combobox.html
- accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::isComboBox): (WebCore::AccessibilityObject::isExpanded): (WebCore::AccessibilityObject::expandObject): (WebCore::AccessibilityObject::increment): (WebCore::AccessibilityObject::decrement):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::expandObject): (WebCore::AccessibilityRenderObject::isExpanded): (WebCore::createARIARoleMap):
- accessibility/AccessibilityRenderObject.h:
- accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper accessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]): (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
- html/HTMLAttributeNames.in:
2009-11-04 Chris Fleizach <Chris Fleizach>
Reviewed by Beth Dakin.
Need to implement ARIA role="combobox"
https://bugs.webkit.org/show_bug.cgi?id=31096
- DumpRenderTree/AccessibilityUIElement.cpp: (showMenuCallback): (getIsExpandedCallback): (AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::isExpanded): (AccessibilityUIElement::showMenu):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::isExpanded): (AccessibilityUIElement::showMenu):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::isSelected): (AccessibilityUIElement::isExpanded): (AccessibilityUIElement::showMenu):
- 12:12 PM Changeset in webkit [50524] by
-
- 4 edits in trunk/WebCore
2009-11-04 Kelly Norton <knorton@google.com>
Reviewed by Pavel Feldman.
Fixes naming inconsistencies in TimelineRecordFactory.
https://bugs.webkit.org/show_bug.cgi?id=31132
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::willChangeXHRReadyState): (WebCore::InspectorTimelineAgent::willLoadXHR): (WebCore::InspectorTimelineAgent::willEvaluateScript): (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::didReceiveResourceResponse): (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createXHRReadyStateChangeRecord): (WebCore::TimelineRecordFactory::createXHRLoadRecord): (WebCore::TimelineRecordFactory::createEvaluateScriptRecord): (WebCore::TimelineRecordFactory::createMarkTimelineRecord): (WebCore::TimelineRecordFactory::createResourceSendRequestRecord): (WebCore::TimelineRecordFactory::createResourceReceiveResponseRecord): (WebCore::TimelineRecordFactory::createResourceFinishRecord): (WebCore::TimelineRecordFactory::createPaintRecord):
- inspector/TimelineRecordFactory.h:
- 12:04 PM Changeset in webkit [50523] by
-
- 9 edits in trunk/WebCore
2009-11-04 Eric Z. Ayers <zundel@google.com>
Reviewed by Pavel Feldman.
Followon to bug 31080, which protects Timeline
instrumentation in the case where InspectorTimelineAgent
is enabled or disabled during an event dispatch.
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluate):
- dom/Document.cpp: (WebCore::Document::recalcStyle):
- dom/Node.cpp: (WebCore::Node::dispatchGenericEvent):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
- page/DOMWindow.cpp: (WebCore::DOMWindow::inspectorTimelineAgent): (WebCore::DOMWindow::dispatchEvent):
- page/DOMWindow.h:
- page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::paintContents):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener):
- 11:55 AM Changeset in webkit [50522] by
-
- 2 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Fix an assert on shutdown when wxWebView has captured the mouse,
and make sure wxWebView's right click handling is only active when
the WebCore popup menu is used.
https://bugs.webkit.org/show_bug.cgi?id=31131
- 11:35 AM Changeset in webkit [50521] by
-
- 5 edits in trunk/WebCore
Revert 50519 while I work out what went wrong.
Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-11-04
- storage/LocalStorageThread.cpp:
(WebCore::LocalStorageThread::create):
(WebCore::LocalStorageThread::LocalStorageThread):
(WebCore::LocalStorageThread::start):
(WebCore::LocalStorageThread::localStorageThreadStart):
(WebCore::LocalStorageThread::localStorageThread):
(WebCore::LocalStorageThread::scheduleImport):
(WebCore::LocalStorageThread::scheduleSync):
(WebCore::LocalStorageThread::terminate):
(WebCore::LocalStorageThread::performTerminate):
- storage/LocalStorageThread.h:
- storage/StorageSyncManager.cpp:
(WebCore::StorageSyncManager::StorageSyncManager):
(WebCore::StorageSyncManager::~StorageSyncManager):
(WebCore::StorageSyncManager::scheduleImport):
(WebCore::StorageSyncManager::scheduleSync):
- storage/StorageSyncManager.h:
- 11:32 AM Changeset in webkit [50520] by
-
- 4 edits in trunk/WebCore
2009-11-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Add basic support for resource events and marks.
Couple of drive-by fixes. Enabling the panel!
- English.lproj/localizedStrings.js:
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype._getRecordDetails): (WebInspector.TimelinePanel.prototype.reset): (WebInspector.TimelineCategoryTreeElement.prototype._onCheckboxClicked): (WebInspector.TimelineRecordTreeElement.prototype.onattach):
- inspector/front-end/inspector.js: (WebInspector._createPanels):
- 11:11 AM Changeset in webkit [50519] by
-
- 5 edits in trunk/WebCore
2009-11-03 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Simplify LocalStorageThread
https://bugs.webkit.org/show_bug.cgi?id=30935
On LocalStoragethread: Remove reference counting. Get rid of locking. Make some
of the method names a bit more clear. Assert proper thread usage. Join rather
than detaching the thread and doing an ad-hoc form of join. Avoid touching
variables on the background thread when simple to do so. Also create a generic
scheduleTask function rather than one for each task.
No behavior should have changed.
- storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::create): (WebCore::LocalStorageThread::LocalStorageThread): (WebCore::LocalStorageThread::~LocalStorageThread): (WebCore::LocalStorageThread::start): (WebCore::LocalStorageThread::threadEntryPointCallback): (WebCore::LocalStorageThread::threadEntryPoint): (WebCore::LocalStorageThread::scheduleTask): (WebCore::LocalStorageThread::terminate): (WebCore::LocalStorageThread::performTerminate):
- storage/LocalStorageThread.h:
- storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::StorageSyncManager): (WebCore::StorageSyncManager::~StorageSyncManager): (WebCore::StorageSyncManager::scheduleImport): (WebCore::StorageSyncManager::scheduleSync):
- storage/StorageSyncManager.h:
- 10:28 AM Changeset in webkit [50518] by
-
- 2 edits in trunk/WebKitTools
2009-11-04 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue is crashing when trying to reject patches after unknown failures
https://bugs.webkit.org/show_bug.cgi?id=31091
- Scripts/bugzilla-tool:
- patchid was a copy/paste mistake. This code has no 'patch' variable so we have to find out what the current patch is by asking bugzilla again.
- Discovered that this code was also leaking file descriptors, so fixed that.
- 10:21 AM Changeset in webkit [50517] by
-
- 2 edits in trunk/JavaScriptCore
2009-11-04 Mark Mentovai <mark@chromium.org>
Reviewed by Eric Seidel.
Remove BUILDING_ON_LEOPARD from JavaScriptCore.gyp. This is supposed
to be set as needed only in wtf/Platform.h.
- JavaScriptCore.gyp/JavaScriptCore.gyp:
- 10:13 AM Changeset in webkit [50516] by
-
- 4 edits in trunk
2009-11-04 Vadim Zeitlin <vadim@wxwidgets.org>
Reviewed by Eric Seidel.
[wx] Small cleanup: avoid unnecessary wxString::mb_str() calls.
- platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::computeHash):
2009-11-04 Vadim Zeitlin <vadim@wxwidgets.org>
Reviewed by Eric Seidel.
[wx] Small cleanup: avoid unnecessary wxString::mb_str() calls.
- WebFrame.cpp: (wxWebFrame::SetPageSource): (wxWebFrame::LoadURL):
- 9:17 AM Changeset in webkit [50515] by
-
- 7 edits in trunk/WebCore
2009-11-04 Kelly Norton <knorton@google.com>
Reviewed by Pavel Feldman.
Adds lightweight network resources to InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=31065
- inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::didReceiveResourceResponse): (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
- inspector/InspectorTimelineAgent.h: (WebCore::):
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createResourceSendRequestTimelineRecord): (WebCore::TimelineRecordFactory::createResourceReceiveResponseTimelineRecord): (WebCore::TimelineRecordFactory::createResourceFinishTimelineRecord):
- inspector/TimelineRecordFactory.h:
- inspector/front-end/TimelineAgent.js:
- 9:08 AM Changeset in webkit [50514] by
-
- 2 edits in trunk/WebCore
2009-11-04 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] ASSERT failure when receiving 401 HTTP Authentication response.
https://bugs.webkit.org/show_bug.cgi?id=31077
Allow sending the response body under the same conditions that we
allow it to finish without reporting an error.
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
- 8:58 AM Changeset in webkit [50513] by
-
- 2 edits in trunk/WebKitTools
Make run-webkit-tests work for the Debug_Internal Windows configuration
In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
suffix.
Fixes <http://webkit.org/b/31123>.
Reviewed by Sam Weinig.
- Scripts/run-webkit-tests: Don't add the _debug suffix in
Debug_Internal, either.
- 8:13 AM Changeset in webkit [50512] by
-
- 2 edits in trunk/WebCore
Sort WebCore.base.exp
Rubber-stamped by Dan Bernstein.
- WebCore.base.exp: Sorted.
- 4:12 AM Changeset in webkit [50511] by
-
- 2 edits in trunk/LayoutTests
Put test into skiplist added in r50489 because
layoutTestController.showWebInspector() is unimplemented now.
Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-11-04
- platform/qt/Skipped: inspector/timeline-trivial.html added.
- 3:27 AM Changeset in webkit [50510] by
-
- 6 edits1 add3 deletes in trunk
Unreviewed rollout.
Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-11-04
Revert r50496 because it broke all layout tests on QtBuildBot.
WebCore:
- WebCore.pro:
- platform/graphics/qt/FontCacheQt.cpp:
(WebCore::fontCache):
(WebCore::FontCache::FontCache):
(WebCore::FontCache::getTraitsInFamily):
(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
(WebCore::FontPlatformDataCacheKey::isHashTableDeletedValue):
(WebCore::FontPlatformDataCacheKey::):
(WebCore::FontPlatformDataCacheKey::operator==):
(WebCore::FontPlatformDataCacheKey::hash):
(WebCore::FontPlatformDataCacheKey::computeHash):
(WebCore::FontPlatformDataCacheKey::hashTableDeletedSize):
(WebCore::FontPlatformDataCacheKeyHash::hash):
(WebCore::FontPlatformDataCacheKeyHash::equal):
(WebCore::FontPlatformDataCacheKeyTraits::emptyValue):
(WebCore::FontPlatformDataCacheKeyTraits::constructDeletedValue):
(WebCore::FontPlatformDataCacheKeyTraits::isDeletedValue):
(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::getCachedFontData):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::releaseFontData):
(WebCore::FontCache::purgeInactiveFontData):
(WebCore::FontCache::addClient):
(WebCore::FontCache::removeClient):
(WebCore::FontCache::invalidate):
- platform/graphics/qt/FontFallbackListQt.cpp: Added.
(WebCore::FontFallbackList::FontFallbackList):
(WebCore::FontFallbackList::invalidate):
(WebCore::FontFallbackList::releaseFontData):
(WebCore::FontFallbackList::determinePitch):
(WebCore::FontFallbackList::fontDataAt):
(WebCore::FontFallbackList::fontDataForCharacters):
(WebCore::FontFallbackList::setPlatformFont):
- platform/graphics/qt/FontPlatformData.h:
(WebCore::FontPlatformData::pixelSize):
- platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):
LayoutTests:
- svg/text/resources: Removed.
- svg/text/resources/text-font-invalid.svg: Removed.
- svg/text/text-font-invalid-expected.txt: Removed.
- svg/text/text-font-invalid.html: Removed.
- 2:35 AM Changeset in webkit [50509] by
-
- 2 edits in trunk/WebCore
2009-11-04 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=31044
[Gtk] assertion when webkit_accessible_get_index_in_parent attempts to get parent of the web view
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkParentOfWebView): (webkit_accessible_get_index_in_parent): (webkit_accessible_get_parent):
- 2:28 AM Changeset in webkit [50508] by
-
- 5 edits2 adds in trunk/WebCore
2009-11-04 Dominik Röttsches <dominik.roettsches@access-company.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=15914
[GTK] Implement Unicode functionality using GLib
Initial version of this patch by Jürg Billeter and Naiem Shaik.
Patch 2/4 - Moving TextCodecs to GLib
Added probing for a hard-coded lists of text encodings.
The basis of this list is taken from the encodings supported by iconv,
then extended by e.g. tis-620, windows-1251, euc-kr, windows-1253 and
a number of Chinese ones.
Probing is necessary with the current design of text codecs
as iconv/GLib do not support enumerating available encodings.
- GNUmakefile.am:
- platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::ThreadGlobalData): (WebCore::ThreadGlobalData::~ThreadGlobalData):
- platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encode):
- platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): (WebCore::extendTextCodecMaps):
- platform/text/gtk/TextCodecGtk.cpp: Added. (WebCore::): (WebCore::newTextCodecGtk): (WebCore::TextCodecGtk::isEncodingAvailable): (WebCore::TextCodecGtk::registerEncodingNames): (WebCore::TextCodecGtk::registerCodecs): (WebCore::TextCodecGtk::registerBaseEncodingNames): (WebCore::TextCodecGtk::registerBaseCodecs): (WebCore::TextCodecGtk::registerExtendedEncodingNames): (WebCore::TextCodecGtk::registerExtendedCodecs): (WebCore::TextCodecGtk::TextCodecGtk): (WebCore::TextCodecGtk::~TextCodecGtk): (WebCore::TextCodecGtk::releaseIConv): (WebCore::TextCodecGtk::createIConvDecoder): (WebCore::TextCodecGtk::createIConvEncoder): (WebCore::TextCodecGtk::decode): (WebCore::TextCodecGtk::encode):
- platform/text/gtk/TextCodecGtk.h: Added.
- 2:19 AM Changeset in webkit [50507] by
-
- 9 edits in trunk
2009-11-04 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Jan Alonzo.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Unify redudant methods which will always return the same value.
- platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeSelection):
- platform/gtk/PasteboardHelper.h:
2009-11-04 Martin Robinson <martin.james.robinson@gmail.com>
Reviewed by Jan Alonzo.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Move handling of target list to PasteboardHelperGtk.
- WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::PasteboardHelperGtk::PasteboardHelperGtk): (WebKit::PasteboardHelperGtk::~PasteboardHelperGtk): (WebKit::PasteboardHelperGtk::fullTargetList):
- WebCoreSupport/PasteboardHelperGtk.h:
- webkit/webkitprivate.cpp: (WebKit::pasteboardHelperInstance): (webkit_init):
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp: (webkit_web_view_dispose): (webkit_web_view_init): (webkit_web_view_get_copy_target_list): (webkit_web_view_get_paste_target_list):
- 1:31 AM Changeset in webkit [50506] by
-
- 2 edits in trunk/WebCore
2009-11-04 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=31035
[GTK] some accessibility tests hitting assertion in debug builds
Removes the assertions in webkit_accessible_ref_child; adds sanity checks.
Any app or AT can attempt to ref a child at a bogus index.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_ref_child):
- 1:15 AM Changeset in webkit [50505] by
-
- 4 edits in trunk/WebKitTools
2009-11-04 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
committers.py needs a way to store non-bugzilla email addresses
https://bugs.webkit.org/show_bug.cgi?id=31037
Make Committer and Reviewer constructors take a single email or a list of emails.
Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
Expose reviewers(), used by validate-committer-lists on bug 30970.
- Scripts/modules/committers.py:
- Scripts/modules/committers_unittest.py: Added tests for the new code.
- 12:58 AM Changeset in webkit [50504] by
-
- 2 edits in trunk/WebCore
2009-11-04 Benjamin Otte <otte@gnome.org>
Reviewed by Jan Alonzo.
[gtk] Use gst_element_class_set_details_simple()
Cosmetic change, just code simplification
- platform/graphics/gtk/VideoSinkGStreamer.cpp:
- 12:50 AM Changeset in webkit [50503] by
-
- 3 edits in trunk/WebKit/qt
2009-11-04 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Simon Hausmann.
[Qt] REGRESSION: Allow applications to use their own QWidget bypassing QWebView.
https://bugs.webkit.org/show_bug.cgi?id=30979
Decouple QWebViewPrivate from QWebPageClient, and automatically create
QWebPageWidgetClient whenever the view is QWidget based.
- Api/qwebpage.cpp: (QWebPageWidgetClient::QWebPageWidgetClient): (QWebPageWidgetClient::scroll): (QWebPageWidgetClient::update): (QWebPageWidgetClient::setInputMethodEnabled): (QWebPageWidgetClient::setInputMethodHint): (QWebPageWidgetClient::cursor): (QWebPageWidgetClient::updateCursor): (QWebPageWidgetClient::palette): (QWebPageWidgetClient::screenNumber): (QWebPageWidgetClient::ownerWidget): (QWebPageWidgetClient::pluginParent): (QWebPage::setView):
- Api/qwebview.cpp: (QWebView::~QWebView): (QWebView::setPage): (QWebView::event):
- 12:42 AM Changeset in webkit [50502] by
-
- 6 edits in trunk/WebCore
2009-11-04 Kelly Norton <knorton@google.com>
Reviewed by Timothy Hatcher.
Adds paint rectangle information to TimelineAgent's didPaint callback.
https://bugs.webkit.org/show_bug.cgi?id=31087
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willPaint):
- inspector/InspectorTimelineAgent.h:
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createPaintTimelineRecord):
- inspector/TimelineRecordFactory.h:
- page/FrameView.cpp: (WebCore::FrameView::paintContents):
- 12:33 AM Changeset in webkit [50501] by
-
- 12 edits in trunk
2009-11-04 Jaime Yap <jaimeyap@google.com>
Reviewed by Timothy Hatcher.
This patch adds API to the console object for annotating the
inspector timeline. This allows developers to mark logical
checkpoints in their apps and have them overlaid in the event
record tree.
tests updated: LayoutTests/fast/dom/Window/window-properties.html
https://bugs.webkit.org/show_bug.cgi?id=31082
- inspector/InspectorController.cpp: (WebCore::InspectorController::markTimeline):
- inspector/InspectorController.h:
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didMarkTimeline):
- inspector/InspectorTimelineAgent.h: (WebCore::):
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createMarkTimelineRecord):
- inspector/TimelineRecordFactory.h:
- inspector/front-end/TimelineAgent.js:
- page/Console.cpp: (WebCore::Console::markTimeline):
- page/Console.h:
- page/Console.idl:
Nov 3, 2009:
- 11:50 PM Changeset in webkit [50500] by
-
- 2 edits in trunk/WebKitTools
2009-11-03 Yuzo Fujishima <yuzo@google.com>
Reviewed by David Levin.
Start/Stop Web Socket and Web Socket Secure servers for layout tests.
https://bugs.webkit.org/show_bug.cgi?id=27491
The test path determination logic is changed to handle websocket and websocket/ssl cases.
The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
Functions to start or stop Web Socket servers are added.
- Scripts/run-webkit-tests:
- 10:09 PM Changeset in webkit [50499] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix for WebInspector with Qt build.
Patch by Simon Hausmann <Simon Hausmann> on 2009-11-03
Simply re-generate the Qt resource file by running
WebKitTools/Scripts/generate-qt-inspector-resource
- inspector/front-end/WebKit.qrc:
- 9:52 PM Changeset in webkit [50498] by
-
- 2 edits in trunk/LayoutTests
(on IRC)
Reviewed by Mark Rowe.
add ruby layout tests to the Skipped list on mac, since they somehow cause
http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html to fail.
no new tests.
- platform/mac/Skipped:
- 8:29 PM Changeset in webkit [50497] by
-
- 190 edits in trunk/WebKitSite
Set the MIME type for all PNG files in this directory.
WebKitSite:
Patch by Darin Adler <Darin Adler> on 2009-11-03
- blog-files/3d-transforms/mighty-cubes.png: Added property svn:mime-type.
- blog-files/3d-transforms/poster-circle.png: Added property svn:mime-type.
- blog-files/InspectorDatabaseBrowser.png: Modified property svn:mime-type.
- blog-files/acid3-100.png: Modified property svn:mime-type.
- blog-files/acid3-full-rendering-pass.png: Modified property svn:mime-type.
- blog-files/acid3-rendering-reference.png: Modified property svn:mime-type.
- blog-files/acid3-screenshot.png: Modified property svn:mime-type.
- blog-files/acid3-timing-screenshot.png: Modified property svn:mime-type.
- blog-files/acid3-timing.png: Modified property svn:mime-type.
- blog-files/bounce.png: Added property svn:mime-type.
- blog-files/gebcnwebkitonly.png: Modified property svn:mime-type.
- blog-files/inspector-closure-scope.png: Added property svn:mime-type.
- blog-files/inspector-console-autocomplete.png: Added property svn:mime-type.
- blog-files/inspector-databases-panel-query-view.png: Added property svn:mime-type.
- blog-files/inspector-databases-panel.png: Added property svn:mime-type.
- blog-files/inspector-disabling-properties.png: Added property svn:mime-type.
- blog-files/inspector-elements-panel.png: Added property svn:mime-type.
- blog-files/inspector-event-scope.png: Added property svn:mime-type.
- blog-files/inspector-profiles-panel.png: Added property svn:mime-type.
- blog-files/inspector-resources-panel.png: Added property svn:mime-type.
- blog-files/inspector-scripts-panel.png: Added property svn:mime-type.
- blog-files/inspector-searching-elements.png: Added property svn:mime-type.
- blog-files/inspector-searching-profiles.png: Added property svn:mime-type.
- blog-files/inspector-status-bar-with-errors.png: Added property svn:mime-type.
- blog-files/inspector-toolbar.png: Added property svn:mime-type.
- blog-files/inspector-with-scope.png: Added property svn:mime-type.
- blog-files/inspector/breakpoints.png: Added property svn:mime-type.
- blog-files/inspector/colors.png: Added property svn:mime-type.
- blog-files/inspector/cookies.png: Added property svn:mime-type.
- blog-files/inspector/css_selectors.png: Added property svn:mime-type.
- blog-files/inspector/css_syntax_highlight.png: Added property svn:mime-type.
- blog-files/inspector/dom_storage.png: Added property svn:mime-type.
- blog-files/inspector/edit_attributes.png: Added property svn:mime-type.
- blog-files/inspector/enable.png: Added property svn:mime-type.
- blog-files/inspector/event_listeners.png: Added property svn:mime-type.
- blog-files/inspector/form_data.png: Added property svn:mime-type.
- blog-files/inspector/inline_highlight.png: Added property svn:mime-type.
- blog-files/inspector/inorder.png: Added property svn:mime-type.
- blog-files/inspector/inspect_inspector.png: Added property svn:mime-type.
- blog-files/inspector/inspect_inspector_small.png: Added property svn:mime-type.
- blog-files/inspector/load_lines.png: Added property svn:mime-type.
- blog-files/inspector/nodelist.png: Added property svn:mime-type.
- blog-files/inspector/scope_bar.png: Added property svn:mime-type.
- blog-files/inspector/watched_expression.png: Added property svn:mime-type.
- blog-files/kate-circle.png: Modified property svn:mime-type.
- blog-files/kate-gradient-rounded.png: Modified property svn:mime-type.
- blog-files/kate-gradient.png: Modified property svn:mime-type.
- blog-files/kate-reflected.png: Modified property svn:mime-type.
- blog-files/kate-vignette-mask.png: Modified property svn:mime-type.
- blog-files/kate.png: Modified property svn:mime-type.
- blog-files/leaves/images/apple-touch-icon.png: Added property svn:mime-type.
- blog-files/leaves/images/realLeaf1.png: Added property svn:mime-type.
- blog-files/leaves/images/realLeaf2.png: Added property svn:mime-type.
- blog-files/leaves/images/realLeaf3.png: Added property svn:mime-type.
- blog-files/leaves/images/realLeaf4.png: Added property svn:mime-type.
- blog-files/leaves/images/textBackground.png: Added property svn:mime-type.
- blog-files/maskspeedracer.png: Modified property svn:mime-type.
- blog-files/pulse.png: Added property svn:mime-type.
- blog-files/scrollbarpicture.png: Modified property svn:mime-type.
- blog-files/sfx-perf.png: Modified property svn:mime-type.
- blog-files/squirrelfish-webkit-graph.png: Modified property svn:mime-type.
- blog-files/squirrelfish.png: Modified property svn:mime-type.
- blog-files/vignette-mask.png: Modified property svn:mime-type.
- blog-files/webgl/resources/mars500x250.png: Modified property svn:mime-type.
- blog-files/wsj-nopreload.png: Modified property svn:mime-type.
- blog-files/wsj-preload.png: Modified property svn:mime-type.
- blog-files/wsj-vs.png: Modified property svn:mime-type.
- blog/wp-admin/images/align-center.png: Added property svn:mime-type.
- blog/wp-admin/images/align-left.png: Added property svn:mime-type.
- blog/wp-admin/images/align-none.png: Added property svn:mime-type.
- blog/wp-admin/images/align-right.png: Added property svn:mime-type.
- blog/wp-admin/images/archive-link.png: Added property svn:mime-type.
- blog/wp-admin/images/blue-grad.png: Added property svn:mime-type.
- blog/wp-admin/images/button-grad-active-vs.png: Added property svn:mime-type.
- blog/wp-admin/images/button-grad-active.png: Added property svn:mime-type.
- blog/wp-admin/images/button-grad-vs.png: Added property svn:mime-type.
- blog/wp-admin/images/button-grad.png: Added property svn:mime-type.
- blog/wp-admin/images/comment-grey-bubble.png: Added property svn:mime-type.
- blog/wp-admin/images/fade-butt.png: Modified property svn:mime-type.
- blog/wp-admin/images/fav-top.png: Added property svn:mime-type.
- blog/wp-admin/images/fav-vs.png: Added property svn:mime-type.
- blog/wp-admin/images/fav.png: Added property svn:mime-type.
- blog/wp-admin/images/generic.png: Added property svn:mime-type.
- blog/wp-admin/images/gray-grad.png: Added property svn:mime-type.
- blog/wp-admin/images/icons32-vs.png: Added property svn:mime-type.
- blog/wp-admin/images/icons32.png: Added property svn:mime-type.
- blog/wp-admin/images/list-vs.png: Added property svn:mime-type.
- blog/wp-admin/images/list.png: Added property svn:mime-type.
- blog/wp-admin/images/logo-ghost.png: Added property svn:mime-type.
- blog/wp-admin/images/marker.png: Added property svn:mime-type.
- blog/wp-admin/images/mask.png: Added property svn:mime-type.
- blog/wp-admin/images/menu-vs.png: Added property svn:mime-type.
- blog/wp-admin/images/menu.png: Added property svn:mime-type.
- blog/wp-admin/images/no.png: Added property svn:mime-type.
- blog/wp-admin/images/se.png: Added property svn:mime-type.
- blog/wp-admin/images/wheel.png: Added property svn:mime-type.
- blog/wp-admin/images/white-grad-active.png: Added property svn:mime-type.
- blog/wp-admin/images/white-grad.png: Added property svn:mime-type.
- blog/wp-admin/images/wordpress-logo.png: Modified property svn:mime-type.
- blog/wp-admin/images/yes.png: Added property svn:mime-type.
- blog/wp-content/Picture9.png: Modified property svn:mime-type.
- blog/wp-content/chucknorris.png: Modified property svn:mime-type.
- blog/wp-content/databaseexample.png: Modified property svn:mime-type.
- blog/wp-content/drosera.png: Modified property svn:mime-type.
- blog/wp-content/hitlist.png: Modified property svn:mime-type.
- blog/wp-content/rotate.png: Modified property svn:mime-type.
- blog/wp-content/svgtext.png: Modified property svn:mime-type.
- blog/wp-content/svgtextmini.png: Modified property svn:mime-type.
- blog/wp-content/svgtextmini_01.png: Modified property svn:mime-type.
- blog/wp-content/themes/classic/screenshot.png: Modified property svn:mime-type.
- blog/wp-content/themes/default/screenshot.png: Modified property svn:mime-type.
- blog/wp-content/uploads/2007/06/newinspector.png: Modified property svn:mime-type.
- blog/wp-content/webInspector.png: Modified property svn:mime-type.
- blog/wp-includes/images/crystal/archive.png: Added property svn:mime-type.
- blog/wp-includes/images/crystal/audio.png: Added property svn:mime-type.
- blog/wp-includes/images/crystal/code.png: Added property svn:mime-type.
- blog/wp-includes/images/crystal/default.png: Added property svn:mime-type.
- blog/wp-includes/images/crystal/document.png: Added property svn:mime-type.
- blog/wp-includes/images/crystal/interactive.png: Added property svn:mime-type.
- blog/wp-includes/images/crystal/spreadsheet.png: Added property svn:mime-type.
- blog/wp-includes/images/crystal/text.png: Added property svn:mime-type.
- blog/wp-includes/images/crystal/video.png: Added property svn:mime-type.
- blog/wp-includes/images/rss.png: Modified property svn:mime-type.
- blog/wp-includes/images/upload.png: Added property svn:mime-type.
- blog/wp-includes/images/wlw/wp-comments.png: Added property svn:mime-type.
- blog/wp-includes/images/wlw/wp-icon.png: Added property svn:mime-type.
- blog/wp-includes/images/wlw/wp-watermark.png: Added property svn:mime-type.
- blog/wp-includes/js/codepress/images/line-numbers.png: Added property svn:mime-type.
- blog/wp-includes/js/thickbox/macFFBgHack.png: Added property svn:mime-type.
- blog/wp-includes/js/thickbox/tb-close.png: Added property svn:mime-type.
- blog/wp-includes/js/tinymce/plugins/wpeditimage/img/delete.png: Added property svn:mime-type.
- blog/wp-includes/js/tinymce/plugins/wpeditimage/img/image.png: Added property svn:mime-type.
- blog/wp-includes/js/tinymce/plugins/wpgallery/img/delete.png: Added property svn:mime-type.
- blog/wp-includes/js/tinymce/plugins/wpgallery/img/edit.png: Added property svn:mime-type.
- blog/wp-includes/js/tinymce/plugins/wpgallery/img/gallery.png: Added property svn:mime-type.
- blog/wp-includes/js/tinymce/themes/advanced/img/gotmoxie.png: Added property svn:mime-type.
- blog/wp-includes/js/tinymce/themes/advanced/img/sflogo.png: Added property svn:mime-type.
- blog/wp-includes/js/tinymce/themes/advanced/skins/default/img/buttons.png: Added property svn:mime-type.
- blog/wp-includes/js/tinymce/themes/advanced/skins/o2k7/img/button_bg.png: Added property svn:mime-type.
- blog/wp-includes/js/tinymce/themes/advanced/skins/o2k7/img/button_bg_black.png: Added property svn:mime-type.
- blog/wp-includes/js/tinymce/themes/advanced/skins/o2k7/img/button_bg_silver.png: Added property svn:mime-type.
- blog/wp-includes/js/tinymce/themes/advanced/skins/wp_theme/img/butt2.png: Added property svn:mime-type.
- blog/wp-includes/js/tinymce/themes/advanced/skins/wp_theme/img/button_bg.png: Added property svn:mime-type.
- demos/calendar/Images/AirPort4.png: Modified property svn:mime-type.
- demos/calendar/Images/AirPortError.png: Modified property svn:mime-type.
- demos/calendar/Images/disclosureTriangleSmallDown.png: Modified property svn:mime-type.
- demos/calendar/Images/disclosureTriangleSmallRight.png: Modified property svn:mime-type.
- demos/calendar/Images/statusbarBackground.png: Modified property svn:mime-type.
- demos/calendar/Images/statusbarResizerVertical.png: Modified property svn:mime-type.
- demos/editingToolbar/FancyToolbarImages/button.png: Modified property svn:mime-type.
- demos/editingToolbar/FancyToolbarImages/buttonLeft.png: Modified property svn:mime-type.
- demos/editingToolbar/FancyToolbarImages/buttonMiddle.png: Modified property svn:mime-type.
- demos/editingToolbar/FancyToolbarImages/buttonPressed.png: Modified property svn:mime-type.
- demos/editingToolbar/FancyToolbarImages/buttonPressedLeft.png: Modified property svn:mime-type.
- demos/editingToolbar/FancyToolbarImages/buttonPressedMiddle.png: Modified property svn:mime-type.
- demos/editingToolbar/FancyToolbarImages/buttonPressedRight.png: Modified property svn:mime-type.
- demos/editingToolbar/FancyToolbarImages/buttonRight.png: Modified property svn:mime-type.
- demos/editingToolbar/FancyToolbarImages/camera.png: Modified property svn:mime-type.
- demos/editingToolbar/FancyToolbarImages/link.png: Modified property svn:mime-type.
- demos/editingToolbar/FancyToolbarImages/textAlign.png: Modified property svn:mime-type.
- demos/editingToolbar/FancyToolbarImages/toolbarOutline.png: Modified property svn:mime-type.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottom.png: Modified property svn:mime-type.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomLeft.png: Modified property svn:mime-type.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomRight.png: Modified property svn:mime-type.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineLeft.png: Modified property svn:mime-type.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineRight.png: Modified property svn:mime-type.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineTop.png: Modified property svn:mime-type.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopLeft.png: Modified property svn:mime-type.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopRight.png: Modified property svn:mime-type.
- demos/editingToolbar/images/safari.png: Modified property svn:mime-type.
- demos/sticky-notes/deleteButton.png: Added property svn:mime-type.
- demos/sticky-notes/deleteButtonPressed.png: Added property svn:mime-type.
- demos/transitions-and-transforms/Horsehead.png: Modified property svn:mime-type.
- demos/transitions-and-transforms/Spaces.png: Modified property svn:mime-type.
- demos/transitions-and-transforms/Stacks.png: Modified property svn:mime-type.
- images/DroseraPic.png: Modified property svn:mime-type.
- misc/drosera/drosera.png: Modified property svn:mime-type.
- perf/slickspeed/logo.png: Modified property svn:mime-type.
WebKitSite/specs/CSSVisualEffects:
Patch by Darin Adler <Darin Adler> on 2009-11-03
- css3-2d-transforms/compound_transform.png: Modified property svn:mime-type.
- css3-2d-transforms/transform1.png: Modified property svn:mime-type.
- css3-2d-transforms/transform2.png: Modified property svn:mime-type.
- css3-3d-transforms/compound_transform.png: Modified property svn:mime-type.
- css3-3d-transforms/transform1.png: Modified property svn:mime-type.
- css3-3d-transforms/transform2.png: Modified property svn:mime-type.
- css3-animations/animation1.png: Modified property svn:mime-type.
- css3-animations/sandwich.png: Modified property svn:mime-type.
- css3-transitions/TimingFunction.png: Modified property svn:mime-type.
- css3-transitions/transition1.png: Modified property svn:mime-type.
- 7:37 PM Changeset in webkit [50496] by
-
- 6 edits4 adds1 delete in trunk
WebCore: [Qt] Handle fonts like the other ports
Patch by Benjamin Poulain <benjamin.poulain@nokia.com> on 2009-11-02
Reviewed by Simon Hausmann.
Remove FontFallbackListQt and rely on the common FontFallbackList
to handle the fonts. FontCache and FontPlatformData have been
updated to work with the common FontFallbackList.
In the previous implementation, FontPlatformDataCacheKey
was a clone of FontPlatformData with the hashing
capabilities added in order to use it as a key in the cache's
hashmap. FontPlatformData has been modified to handle the hashing
function directly so the data are not copied twice in memory.
FontFallbackList::fontDataAt() from FontFallbackListQt was a copy of
code from FontCache::getFontData() and FontFallbackList::fontDataAt().
The behavior is similar except currFamily->family().length() was
not tested and the fallback fonts selector were not used.
https://bugs.webkit.org/show_bug.cgi?id=29856
Test: svg/text/text-font-invalid.html
- WebCore.pro:
- platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::platformInit):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::getTraitsInFamily):
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/qt/FontFallbackListQt.cpp:
Removed. We now use the implementation from FontFallbackList.cpp
- platform/graphics/qt/FontPlatformData.h:
Add hashing capabilities to be able to use the data with the FontCache.
This was previously done in FontCacheQt.cpp
(WebCore::FontPlatformData::FontPlatformData):
Added a boolean to identify deleted value in the hash table.
(WebCore::FontPlatformData::isHashTableDeletedValue):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):
- platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):
LayoutTests: Add a new test to reproduce 29856. The bug only happen
when the SVG file is used as an image.
https://bugs.webkit.org/show_bug.cgi?id=29856
Patch by Benjamin Poulain <benjamin.poulain@nokia.com> on 2009-11-02
Reviewed by Simon Hausmann.
- svg/text/text-font-invalid-expected.txt: Added.
- svg/text/resources/text-font-invalid.svg: Added.
- svg/text/text-font-invalid.html: Added.
- 7:26 PM Changeset in webkit [50495] by
-
- 1 edit65 adds in trunk/LayoutTests
Bug 28420 - Implement HTML5 <ruby> rendering
(https://bugs.webkit.org/show_bug.cgi?id=28420)
Reviewed by Dave Hyatt.
First rudimentary implementation of HTML5 ruby rendering support - layout tests.
New layout tests: basic rendering:
- fast/ruby/ruby-empty-rt.html: Added.
- fast/ruby/ruby-length.html: Added.
- fast/ruby/ruby-run-break.html: Added.
- fast/ruby/ruby-runs-spans.html: Added.
- fast/ruby/ruby-runs.html: Added.
- fast/ruby/ruby-simple-rp.html: Added.
- fast/ruby/ruby-simple.html: Added.
- fast/ruby/ruby-trailing.html: Added.
New layout tests: DOM manipulation within <ruby>
- fast/ruby/rubyDOM-insert-rt.html: Added.
- fast/ruby/rubyDOM-insert-text1.html: Added.
- fast/ruby/rubyDOM-insert-text2.html: Added.
- fast/ruby/rubyDOM-insert-text3.html: Added.
- fast/ruby/rubyDOM-remove-rt1.html: Added.
- fast/ruby/rubyDOM-remove-rt2.html: Added.
- fast/ruby/rubyDOM-remove-text1.html: Added.
- fast/ruby/rubyDOM-remove-text2.html: Added.
New layout tests results:
- platform/mac/fast/ruby: Added.
- platform/mac/fast/ruby/ruby-empty-rt-expected.checksum: Added.
- platform/mac/fast/ruby/ruby-empty-rt-expected.png: Added.
- platform/mac/fast/ruby/ruby-empty-rt-expected.txt: Added.
- platform/mac/fast/ruby/ruby-length-expected.checksum: Added.
- platform/mac/fast/ruby/ruby-length-expected.png: Added.
- platform/mac/fast/ruby/ruby-length-expected.txt: Added.
- platform/mac/fast/ruby/ruby-run-break-expected.checksum: Added.
- platform/mac/fast/ruby/ruby-run-break-expected.png: Added.
- platform/mac/fast/ruby/ruby-run-break-expected.txt: Added.
- platform/mac/fast/ruby/ruby-runs-expected.checksum: Added.
- platform/mac/fast/ruby/ruby-runs-expected.png: Added.
- platform/mac/fast/ruby/ruby-runs-expected.txt: Added.
- platform/mac/fast/ruby/ruby-runs-spans-expected.checksum: Added.
- platform/mac/fast/ruby/ruby-runs-spans-expected.png: Added.
- platform/mac/fast/ruby/ruby-runs-spans-expected.txt: Added.
- platform/mac/fast/ruby/ruby-simple-expected.checksum: Added.
- platform/mac/fast/ruby/ruby-simple-expected.png: Added.
- platform/mac/fast/ruby/ruby-simple-expected.txt: Added.
- platform/mac/fast/ruby/ruby-simple-rp-expected.checksum: Added.
- platform/mac/fast/ruby/ruby-simple-rp-expected.png: Added.
- platform/mac/fast/ruby/ruby-simple-rp-expected.txt: Added.
- platform/mac/fast/ruby/ruby-trailing-expected.checksum: Added.
- platform/mac/fast/ruby/ruby-trailing-expected.png: Added.
- platform/mac/fast/ruby/ruby-trailing-expected.txt: Added.
- platform/mac/fast/ruby/rubyDOM-insert-rt-expected.checksum: Added.
- platform/mac/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
- platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt: Added.
- platform/mac/fast/ruby/rubyDOM-insert-text1-expected.checksum: Added.
- platform/mac/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
- platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt: Added.
- platform/mac/fast/ruby/rubyDOM-insert-text2-expected.checksum: Added.
- platform/mac/fast/ruby/rubyDOM-insert-text2-expected.png: Added.
- platform/mac/fast/ruby/rubyDOM-insert-text2-expected.txt: Added.
- platform/mac/fast/ruby/rubyDOM-insert-text3-expected.checksum: Added.
- platform/mac/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
- platform/mac/fast/ruby/rubyDOM-insert-text3-expected.txt: Added.
- platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.checksum: Added.
- platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
- platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.txt: Added.
- platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.checksum: Added.
- platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.png: Added.
- platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.txt: Added.
- platform/mac/fast/ruby/rubyDOM-remove-text1-expected.checksum: Added.
- platform/mac/fast/ruby/rubyDOM-remove-text1-expected.png: Added.
- platform/mac/fast/ruby/rubyDOM-remove-text1-expected.txt: Added.
- platform/mac/fast/ruby/rubyDOM-remove-text2-expected.checksum: Added.
- platform/mac/fast/ruby/rubyDOM-remove-text2-expected.png: Added.
- platform/mac/fast/ruby/rubyDOM-remove-text2-expected.txt: Added.
- 6:18 PM Web Inspector Update.ja created by
- 6:09 PM Changeset in webkit [50494] by
-
- 1 edit19 adds in trunk/WebKitSite
2009-11-03 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Adding images for an upcoming blog post.
- blog-files/inspector/breakpoints.png: Added.
- blog-files/inspector/colors.png: Added.
- blog-files/inspector/cookies.png: Added.
- blog-files/inspector/css_selectors.png: Added.
- blog-files/inspector/css_syntax_highlight.png: Added.
- blog-files/inspector/dom_storage.png: Added.
- blog-files/inspector/edit_attributes.png: Added.
- blog-files/inspector/enable.png: Added.
- blog-files/inspector/event_listeners.png: Added.
- blog-files/inspector/form_data.png: Added.
- blog-files/inspector/inline_highlight.png: Added.
- blog-files/inspector/inorder.png: Added.
- blog-files/inspector/inspect_inspector.png: Added.
- blog-files/inspector/inspect_inspector_small.png: Added.
- blog-files/inspector/load_lines.png: Added.
- blog-files/inspector/nodelist.png: Added.
- blog-files/inspector/scope_bar.png: Added.
- blog-files/inspector/watched_expression.png: Added.
- 5:34 PM Changeset in webkit [50493] by
-
- 2 edits in trunk/WebCore
Leopard build fix
- platform/network/mac/AuthenticationMac.mm:
(WebCore::mac):
(WebCore::core):
- 5:25 PM Changeset in webkit [50492] by
-
- 6 edits1 move in trunk/LayoutTests
2009-11-03 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Add overridePreference call to all WebGL layout tests
https://bugs.webkit.org/show_bug.cgi?id=31088
- fast/canvas/webgl/array-unit-tests.html:
- fast/canvas/webgl/getActiveTest.html:
- fast/canvas/webgl/gl-get-calls.html:
- fast/canvas/webgl/incorrect-context-object-behaviour.html:
- fast/canvas/webgl/null-object-behaviour.html:
- fast/canvas/webgl/resources/shader-test.js: Removed.
- fast/canvas/webgl/resources/webgl-test.js: Copied from LayoutTests/fast/canvas/webgl/resources/shader-test.js.
- 5:11 PM Changeset in webkit [50491] by
-
- 2 edits in trunk/WebKit/win
WebActionModifierFlagsKey should return an unsigned, because
flags imply a bitmask, and that is what other classes expect from
it.
Reviewed by Steve Falkenburg.
- WebActionPropertyBag.cpp:
(WebActionPropertyBag::Read):
- 5:02 PM Changeset in webkit [50490] by
-
- 2 edits in trunk/WebCore
Fix an assertion failure in core(NSURLProtectionSpace *) by handling NTLM
authentication in AuthenticationMac
Reviewed by Alexey Proskuryakov.
- platform/network/mac/AuthenticationMac.mm:
- 4:00 PM Changeset in webkit [50489] by
-
- 5 edits2 adds in trunk
2009-11-03 Eric Z. Ayers <zundel@google.com>
Reviewed by Timothy Hatcher.
Adds a test for turning on the timeline profiler. This caused
a crash because profiling was enabled in the middle of processing
an event.
- inspector/timeline-trivial-expected.txt: Added.
- inspector/timeline-trivial.html: Added.
2009-11-03 Eric Z. Ayers <zundel@google.com>
Reviewed by Timothy Hatcher.
Fixes a problem where the timeline instrumentation crashes if
timeline profiling is enabled or disabled in the middle of an
event dispatch.
Test: inspector/timeline-trivial.html
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::processingUserGestureEvent):
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
- page/DOMTimer.cpp: (WebCore::DOMTimer::fired):
- 3:34 PM Changeset in webkit [50488] by
-
- 2 edits in trunk/WebKitTools
2009-11-03 Eric Seidel <eric@webkit.org>
No review, just changing wording of log message.
Change log string to say "failed" instead of "rejected"
when a commit fails due to an out of date checkout.
This makes grepping the commit-queue log for rejected patches easier.
- Scripts/bugzilla-tool:
- 2:14 PM Changeset in webkit [50487] by
-
- 2 edits in trunk/WebKitTools
2009-11-03 Eric Seidel <eric@webkit.org>
No review, adding commonly known committers missing from the file.
- Scripts/modules/committers.py: Add committers found by looking at SVN records.
- 2:07 PM Changeset in webkit [50486] by
-
- 4 edits in trunk/WebCore
Allow a frame to go back to copy-on-scroll when it ceases being overlapped
Reviewed by Dave Hyatt.
The code was not testing slow-scrolling frames for overlappedness, thinking the answer
would not matter. That is not the case if the only reason for the slow-scrolling is
being overlapped.
- page/FrameView.cpp:
(WebCore::FrameView::useSlowRepaintsIfNotOverlapped): Added. Returns whether there is any
reason besides being overlapped that the frame would need to fully repaint on scroll.
- page/FrameView.h:
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint): Use useSlowRepaintsIfNotOverlapped().
- 2:04 PM Changeset in webkit [50485] by
-
- 2 edits in trunk/WebKitTools
2009-11-03 Eric Seidel <eric@webkit.org>
No review, just sort-order cleanup.
- Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
- 2:04 PM Changeset in webkit [50484] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to try and fix Windows nightlies.
- 1:39 PM Changeset in webkit [50483] by
-
- 2 edits in trunk/WebCore
Not reviewed, Qt build fix.
Need to use right capitalization for include file.
- page/Navigator.cpp:
- 1:34 PM Changeset in webkit [50482] by
-
- 4 edits in trunk/WebCore
2009-11-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Migrate from top bar filters to check boxes in Timeline.
- inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.showCategory): (WebInspector.AbstractTimelinePanel.prototype.hideCategory): (WebInspector.AbstractTimelinePanel.prototype.filter):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelineCategoryTreeElement.prototype.onattach): (WebInspector.TimelineCategoryTreeElement.prototype._onCheckboxClick): (WebInspector.TimelineCategoryGraph.prototype.clearChunks): (WebInspector.TimelineCategoryGraph.prototype.set dimmed):
- inspector/front-end/inspector.css:
- 1:30 PM Changeset in webkit [50481] by
-
- 2 edits in trunk/WebCore
2009-11-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: clear overview on Clear action and panel reset.
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._getRecordDetails): (WebInspector.TimelinePanel.prototype.reset):
- 1:24 PM Changeset in webkit [50480] by
-
- 2 edits9 adds in trunk/WebCore
2009-11-03 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
Imported action and rules python files that WebCore.gyp depends on.
These files used to live in chromium.org and deal mostly with auto-generation
of code by wrapping existing webkit perl scripts.
- WebCore.gyp/WebCore.gyp: Fixed paths in actions and rules.
- WebCore.gyp/scripts/action_csspropertynames.py: Added.
- WebCore.gyp/scripts/action_cssvaluekeywords.py: Added.
- WebCore.gyp/scripts/action_makenames.py: Added.
- WebCore.gyp/scripts/action_maketokenizer.py: Added.
- WebCore.gyp/scripts/action_useragentstylesheets.py: Added.
- WebCore.gyp/scripts/rule_binding.py: Added.
- WebCore.gyp/scripts/rule_bison.py: Added.
- WebCore.gyp/scripts/rule_gperf.py: Added.
- 1:18 PM Changeset in webkit [50479] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 1:18 PM Changeset in webkit [50478] by
-
- 1 copy in tags/Safari-6531.21.9
New tag.
- 1:12 PM Changeset in webkit [50477] by
-
- 14 edits4 adds in trunk
WebCore: Implement window.navigator.registerProtocolHandler in webkit,
https://bugs.webkit.org/b/29651
Patch by Bradley Green <brg@chromium.org> on 2009-11-03
Reviewed by Dmitry Titov.
Also implemented its sister API window.navigator.registerContentHandler.
These methods are as described in the HTML5 specification which can be
found here,
http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registerprotocolhandler
http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registercontenthandler
As specified in the document, the behavior of the browser is determined
by the current registered handler. The state of a registered handler
can change at any time, with the user clearing a registered handler,
registering a different page as handler, or deferring the hander to the
OS. If webkit was to track the state of the currently registered
handlers, it would need more APIs and complexity to keep in sync with
user actions reported to webkit from the UA. For simplicity, the state
of protocol handlers should be kept isolated from webkit and webkit only
notifies the UA that a page has made the call. The UA is then
responsible for correctly handling the registerProtocolHandler call and
the redirects which result from registration.
We do however follow the specification in insuring that the reserved
schemes and mimeTypes are not passed to the UA as custom handler
registration tests. We also insure that the "%s" token is present as
required by the specification.
Updated test expectations for window.clientInformation and navigator
objects.
Tests: fast/dom/registerContentHandler.html
fast/dom/registerProtocolHandler.html
- page/Chrome.cpp:
(WebCore::Chrome::registerProtocolHandler):
(WebCore::Chrome::registerContentHandler):
- page/Chrome.h:
- page/ChromeClient.h:
(WebCore::ChromeClient::registerProtocolHandler):
(WebCore::ChromeClient::registerContentHandler):
- page/Navigator.cpp:
(WebCore::verifyCustomHandlerURL):
(WebCore::verifyProtocolHandlerScheme):
(WebCore::Navigator::registerProtocolHandler):
(WebCore::verifyProtocolHandlerMimeType):
(WebCore::Navigator::registerContentHandler):
- page/Navigator.h:
- page/Navigator.idl:
LayoutTests: Updating test expectations for implementation of
window.navigator.registerProtocolHandler and
window.navigator.registerContentHandler.
Patch by Bradley Green <brg@chromium.org> on 2009-11-03
Reviewed by Dmitry Titov.
There is a default implimentation for these APIs, hence all platforms
with the navigator-detached-no-crash-expect and
window-properties-expected tests needed to be updated. While
isolatedWorlds has a window-properties-expected test, it has no window
object and hence does not need to be updaetd.
We add two fast/dom tests to insure that the proper exceptions are
thrown when bad syntax or security violations are made by calling the
methods.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/navigator-detached-no-crash-expected.txt:
- fast/dom/navigator-detached-no-crash.html:
- fast/dom/registerContentHandler-expected.txt: Added.
- fast/dom/registerContentHandler.html: Added.
- fast/dom/registerProtocolHandler-expected.txt: Added.
- fast/dom/registerProtocolHandler.html: Added.
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt:
- platform/mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt:
- 1:06 PM Changeset in webkit [50476] by
-
- 8 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=31079 - Remove #include "Page.h" from Document.h
Reviewed by Darin Adler.
No new tests. (No change in functionality)
- dom/Document.cpp:
(WebCore::Document::inspectorTimelineAgent): Moved from Document.h
- dom/Document.h:
Include "Page.h" directly:
- html/HTMLVideoElement.cpp:
- loader/RedirectScheduler.cpp:
- page/History.cpp:
- rendering/MediaControlElements.cpp:
- storage/StorageAreaImpl.cpp:
- 12:59 PM Changeset in webkit [50475] by
-
- 2 edits in trunk/WebKitTools
(Unreviewed).
Add myself to committers.py.
- Scripts/modules/committers.py:
- 12:56 PM Changeset in webkit [50474] by
-
- 6 edits in branches/safari-4-branch
Merge r50443.
- 12:04 PM Changeset in webkit [50473] by
-
- 1 edit8 adds in trunk/WebKitTools
Reviewed by Kevin Ollviier.
Add packaging scripts for Debian-based Linux distros.
https://bugs.webkit.org/show_bug.cgi?id=31075
- 11:38 AM Changeset in webkit [50472] by
-
- 2 edits in trunk/WebCore
2009-11-03 Keishi Hattori <casey.hattori@gmail.com>
Reviewed by Timothy Hatcher.
Web Inspector: hover over JS "things" in source and see their values
https://bugs.webkit.org/show_bug.cgi?id=30913
- inspector/front-end/SourceFrame.js:
- 11:24 AM Changeset in webkit [50471] by
-
- 2 edits in trunk/WebCore
2009-11-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: update timeline content boundaries on timer.
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.refresh): (WebInspector.TimelinePanel.prototype._setWindowPosition):
- 11:07 AM Changeset in webkit [50470] by
-
- 10 edits4 adds in trunk
WebCore: https://bugs.webkit.org/show_bug.cgi?id=31070
Fix <rdar://problem/7194735> Crashes at RenderText::RenderText()
Fix <rdar://problem/6937089> Crashes at RenderWidget::destroy()
Reviewed by Anders Carlsson and Beth Dakin.
Tests: plugins/attach-during-destroy.html
plugins/destroy-reentry.html
These crashes were caused by plug-in code running during detach(),
causing re-entry into RenderWidget::destroy() in one case and a call
into attach() in the other. The fix is to prevent plug-in code from
being called at certain unsafe times (during attach(), detach(), and
recalcStyle()) by deferring changes to the widget hierarchy.
- dom/Document.cpp:
(WebCore::Document::recalcStyle): Suspend widget hierarchy updates
during style recalculation.
- dom/Element.cpp:
(WebCore::Element::attach): Suspend widget hierarchy updates during
attach().
(WebCore::Element::detach): Suspend widget hierarchy updates during
detach().
- rendering/RenderWidget.cpp:
(WebCore::widgetNewParentMap): Returns a static map of pending changes
to the widget hierarchy.
(WebCore::RenderWidget::suspendWidgetHierarchyUpdates): Increments the
suspend count.
(WebCore::RenderWidget::resumeWidgetHierarchyUpdates): Decrements the
suspend count. If the count is going to be zero, updates the widget
hierarchy by executing the pending changes stored in the map.
(WebCore::moveWidgetToParentSoon): Updates the widget hierarchy
immediately or makes or updates an entry in the map, depending on
whether updates are suspended.
(WebCore::RenderWidget::destroy): Removed earlier bandaid fix for
<rdar://problem/6937089>.
(WebCore::RenderWidget::setWidgetGeometry): Assert that widget updates
are not suspended, because this function updates the widget’s
bounds, which can result in arbitrary native and JavaScript code
execution. I think this assertion is true thanks to some deferred-
update mechanisms that have already been deployed in other places
in the code.
(WebCore::RenderWidget::setWidget): Call moveWidgetToParentSoon instead
of changing the widget hierarchy directly.
- rendering/RenderWidget.h: Declared suspendWidgetHierarchyUpdates()
and resumeWidgetHierarchyUpdates().
WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=31070
Reviewed by Anders Carlsson and Beth Dakin.
Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
destroyed, it executes the value of the 'ondestroy' parameter as a
script.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(pluginAllocate): Initialize onDestroy.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
onDestroy.
- DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
specified.
(NPP_Destroy): Execute the value of 'ondestroy' as a script.
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=31070
Test for <rdar://problem/7194735> Crashes at RenderText::RenderText()
Test for <rdar://problem/6937089> Crashes at RenderWidget::destroy()
Reviewed by Anders Carlsson and Beth Dakin.
- plugins/attach-during-destroy-expected.txt: Added.
- plugins/attach-during-destroy.html: Added.
- plugins/destroy-reentry-expected.txt: Added.
- plugins/destroy-reentry.html: Added.
- 11:06 AM Changeset in webkit [50469] by
-
- 2 edits in trunk/WebCore
2009-11-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: only show timeline records that contribute
to the current window.
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.refresh): (WebInspector.TimelineGraph): (WebInspector.TimelineGraph.prototype.refresh):
- 10:45 AM Changeset in webkit [50468] by
-
- 2 edits in trunk/WebCore
2009-11-03 Patrick Mueller <Patrick_Mueller@us.ibm.com>
Reviewed by Timothy Hatcher.
Watch expression editor should stay open after Add button was clicked
https://bugs.webkit.org/show_bug.cgi?id=31049
No new tests, was a regression, use existing manual test.
- inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update): (WebInspector.WatchExpressionsSection.prototype.addExpression):
- 10:37 AM Changeset in webkit [50467] by
-
- 3 edits2 adds in trunk
2009-11-03 Evan Martin <evan@chromium.org>
Reviewed by Darin Adler.
A test that reproduces a hard-to-trigger memory corruption in the
CSS lexer.
- fast/css/end-of-buffer-crash.html: Added.
2009-11-03 Evan Martin <evan@chromium.org>
Reviewed by Darin Adler.
Fix an off-by-one in the CSS lexer that causes memory corruption in
hard-to-trigger circumstances.
Test: fast/css/end-of-buffer-crash.html
- css/maketokenizer: Add comments, fix off-by-one.
- 10:23 AM Changeset in webkit [50466] by
-
- 4 edits2 adds in trunk
Crash due to double-destroy related to CSS run-in property
https://bugs.webkit.org/show_bug.cgi?id=31034
rdar://problem/7328458
Patch by Darin Adler <Darin Adler> on 2009-11-02
Reviewed by Dan Bernstein.
WebCore:
Test: fast/css/run-in-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::destroy): Reorder destruction so the
continuation is destroyed after anonymous children. See comment
in the code for more details of why this is right.
- rendering/RenderInline.cpp:
(WebCore::RenderInline::destroy): Ditto.
LayoutTests:
- fast/css/run-in-crash-expected.txt: Added.
- fast/css/run-in-crash.html: Added.
- 10:22 AM Changeset in webkit [50465] by
-
- 2 edits in trunk/WebCore
2009-11-03 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Fix exception in ElementsPanel.js when moving pointer out of crumbs and window
There might be no new node under mouse if the pointer is moved out of the window
in which case we get an exception.
https://bugs.webkit.org/show_bug.cgi?id=31061
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._mouseMovedOutOfCrumbs):
- 10:09 AM Changeset in webkit [50464] by
-
- 7 edits in trunk/WebCore
Allow custom memory allocation control for the dom directory of WebCore
https://bugs.webkit.org/show_bug.cgi?id=31053
Reviewed by Darin Adler.
Inherits the following classes from Noncopyable because these are
instantiated by 'new' and these are no need to be copyable:
class EventNames - 'new' call: WebCore/platform/ThreadGlobalData.cpp:73
struct PerformTaskContext - 'new' call: WebCore/dom/Document.cpp:4581
class EventData - 'new' call: WebCore/dom/MessagePortChannel.cpp:38
struct NodeListsNodeData - 'new' call: WebCore/dom/NodeRareData.h:51
struct EventTargetData - 'new' call: WebCore/dom/NodeRareData.h:100
class NodeRareData - 'new' call: WebCore/dom/Node.cpp:552
Inherits QualifiedName class from FastAllocBase because it is
instantiated by 'new' in WebCore/editing/markup.cpp:319
- dom/Document.cpp:
- dom/EventNames.h:
- dom/EventTarget.h:
- dom/MessagePortChannel.h:
- dom/NodeRareData.h:
- dom/QualifiedName.h:
- 9:59 AM Changeset in webkit [50463] by
-
- 3 edits in trunk/WebCore
2009-11-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Implement timeline summary panel.
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._createOverview): (WebInspector.TimelinePanel.prototype.refresh): (WebInspector.TimelineCategoryGraph): (WebInspector.TimelineCategoryGraph.prototype.get graphElement): (WebInspector.TimelineCategoryGraph.prototype.addChunk): (WebInspector.TimelineCategoryGraph.prototype.clearChunks): (WebInspector.TimelineGraph.prototype.refresh):
- inspector/front-end/inspector.css:
- 9:56 AM Changeset in webkit [50462] by
-
- 2 edits in trunk/WebCore
2009-11-03 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Toggle off 'Search for node' when the Inspector window is closing
Searching for node should be toggled off when the Inspector window is closed,
in a platform-independent manner.
https://bugs.webkit.org/show_bug.cgi?id=31059
- inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible):
- 9:49 AM Changeset in webkit [50461] by
-
- 1 edit2 deletes in trunk/LayoutTests
2009-11-03 Victor Wang <victorw@chromium.org>
Reviewed by Eric Seidel.
"http://trac.webkit.org/changeset/50315" makes links mouse
focusable only on GTK and QT, so win has same behavior as mac now
Remove the win specific expected results for tests failed
due to the patch.
- platform/win/fast/events/click-focus-anchor-expected.txt: Removed.
- platform/win/fast/inline: Removed.
- platform/win/fast/inline/dirtyLinesForInline-expected.txt: Removed.
- 9:47 AM Changeset in webkit [50460] by
-
- 5 edits in trunk/WebCore
2009-11-03 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Prepare for heap profiles upstreaming:
- pass profile type id from InspectorController;
- this makes WebInspector.CPUProfile redundant---removed;
- support multiple profile types when populating profiles.
- inspector/InspectorController.cpp: (WebCore::InspectorController::createProfileHeader):
- inspector/front-end/ProfileView.js: (WebInspector.CPUProfileView.profileCallback): (WebInspector.CPUProfileView): (WebInspector.CPUProfileView.prototype._sortData):
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfileHeader):
- inspector/front-end/inspector.js: (WebInspector.addProfileHeader):
- 9:26 AM Changeset in webkit [50459] by
-
- 2 edits in trunk/WebCore
2009-11-03 Dan Kegel <dank@chromium.org>
Reviewed by Dimitri Glazkov.
UMR in WebCore::AccessibilityRenderObject::children(); m_childrenDirty uninitialized in constructor
https://bugs.webkit.org/show_bug.cgi?id=31063
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
- 9:06 AM Changeset in webkit [50458] by
-
- 6 edits in trunk/WebCore
2009-11-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Implement Timeline Window, wire it to the bottom timeline.
- English.lproj/localizedStrings.js:
- inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.get items): (WebInspector.AbstractTimelinePanel.prototype.createInterface): (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded): (WebInspector.AbstractTimelinePanel.prototype._updateDividersLabelBarPosition): (WebInspector.AbstractTimelinePanel.prototype.invalidateAllItems): (WebInspector.AbstractTimelinePanel.prototype.refresh): (WebInspector.AbstractTimelinePanel.prototype.adjustScrollPosition): (WebInspector.AbstractTimelinePanel.prototype.addExtraDivider): (WebInspector.TimelineGrid): (WebInspector.TimelineGrid.prototype.get itemsGraphsElement): (WebInspector.TimelineGrid.prototype.updateDividers): (WebInspector.TimelineGrid.prototype.addExtraDivider): (WebInspector.TimelineGrid.prototype.setScrollAndDividerTop):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded): (WebInspector.ResourcesPanel.prototype.get _resources):
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get categories): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype.reset): (WebInspector.TimelinePanel.prototype._createOverview): (WebInspector.TimelinePanel.prototype.setSidebarWidth): (WebInspector.TimelinePanel.prototype.updateMainViewWidth): (WebInspector.TimelinePanel.prototype.updateGraphDividersIfNeeded): (WebInspector.TimelinePanel.prototype.refresh): (WebInspector.TimelinePanel.prototype._resizeWindow): (WebInspector.TimelinePanel.prototype._windowResizeDragging): (WebInspector.TimelinePanel.prototype._dragWindow): (WebInspector.TimelinePanel.prototype._windowDragging): (WebInspector.TimelinePanel.prototype._resizeWindowLeft): (WebInspector.TimelinePanel.prototype._resizeWindowRight): (WebInspector.TimelinePanel.prototype._setWindowPosition): (WebInspector.TimelinePanel.prototype._endWindowDragging): (WebInspector.TimelineCategoryTreeElement): (WebInspector.TimelineCategoryTreeElement.prototype.onattach): (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages): (WebInspector.TimelineCalculator.prototype.get minimumBoundary): (WebInspector.TimelineCalculator.prototype.get maximumBoundary): (WebInspector.TimelineCalculator.prototype.reset): (WebInspector.TimelineCalculator.prototype.updateBoundaries): (WebInspector.TimelineCalculator.prototype.formatValue):
- inspector/front-end/inspector.css:
- 8:13 AM Changeset in webkit [50457] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Fix build of unit-test after r50454.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-11-03
Reviewed by Simon Hausmann.
- tests/qwebpage/tst_qwebpage.cpp:
- 7:54 AM Changeset in webkit [50456] by
-
- 9 edits1 move in trunk
Make QWebPluginDatabase private API for now.
Patch by Simon Hausmann <Simon Hausmann> on 2009-11-03
Reviewed by Tor Arne Vestbø.
https://bugs.webkit.org/show_bug.cgi?id=30775
WebCore:
- WebCore.pro:
WebKit/qt:
- Api/headers.pri:
- Api/qwebplugindatabase.cpp:
- Api/qwebplugindatabase_p.h: Renamed from WebKit/qt/Api/qwebplugindatabase.h.
- Api/qwebsettings.cpp:
- Api/qwebsettings.h:
- QtLauncher/main.cpp:
(MainWindow::setupUI):
- tests/tests.pro:
- 7:06 AM Changeset in webkit [50455] by
-
- 2 edits in trunk/WebKit/qt
Rubber-stamped by Tor Arne Vestbø.
Patch by Simon Hausmann <Simon Hausmann> on 2009-11-03
Oops, also remove the API docs of the removed networkRequestStarted() signal.
- Api/qwebpage.cpp:
- 6:50 AM Changeset in webkit [50454] by
-
- 8 edits in trunk
WebCore: Extended the conversion of the WebCore ResourceRequest to the
QNetworkRequest with a mandatory originating object argument,
which is meant to be the QWebFrame the request belongs to.
Patch by Simon Hausmann <Simon Hausmann> on 2009-11-03
Reviewed by Tor Arne Vestbø.
https://bugs.webkit.org/show_bug.cgi?id=29975
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::start):
- platform/network/qt/ResourceRequest.h:
- platform/network/qt/ResourceRequestQt.cpp:
(WebCore::ResourceRequest::toNetworkRequest):
WebKit/qt: Replace the QWebPage::networkRequestStarted() signal with the originatingObject
property set to the QWebFrame that belongs to the request.
Patch by Simon Hausmann <Simon Hausmann> on 2009-11-03
Reviewed by Tor Arne Vestbø.
https://bugs.webkit.org/show_bug.cgi?id=29975
- Api/qwebpage.h:
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
(WebCore::FrameLoaderClientQt::startDownload):
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::loadFinished):
(TestNetworkManager::createRequest):
(tst_QWebPage::originatingObjectInNetworkRequests):
- 6:48 AM Changeset in webkit [50453] by
-
- 2 edits in trunk/WebCore
2009-11-03 Keishi Hattori <casey.hattori@gmail.com>
Reviewed by Pavel Feldman.
Web Inspector: monitorEvent should be monitorEvents
https://bugs.webkit.org/show_bug.cgi?id=31042
- inspector/front-end/InjectedScript.js: (InjectedScript._ensureCommandLineAPIInstalled):
- 5:04 AM Changeset in webkit [50452] by
-
- 1 edit in trunk/WebCore/plugins/PluginDatabase.cpp
[Qt] Windows CE build fix
- 4:32 AM Changeset in webkit [50451] by
-
- 2 edits in trunk/LayoutTests
Add files to skiplist depend on phonon support,
which is disabled on the Qt buildbot for now.
Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-11-03
- platform/qt/Skipped:
- 4:12 AM Changeset in webkit [50450] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Tor Arne Vestbø.
Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-11-03
Remove now passing tests from skiplist.
- platform/qt/Skipped:
- 3:56 AM Changeset in webkit [50449] by
-
- 2 edits in trunk/WebCore
[Qt] Build fix for Windows CE
Rubber-stamped by Antti Koivisto.
- plugins/PluginDatabase.cpp:
- 3:50 AM Changeset in webkit [50448] by
-
- 1 edit in trunk/WebKitTools/DumpRenderTree/qt/DumpRenderTree.pro
[Qt] Build fix for Mac OS X when building as framework
WTFReportAssertionFailure is not exported, so building DRT in debug
mode against QtWebKit built as a framework failes to link.
- 2:40 AM Changeset in webkit [50447] by
-
- 2 edits in trunk/LayoutTests
Put test into skiplist added in r50411 because
layoutTestController.showWebInspector() is unimplemented now.
Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2009-11-03
- platform/qt/Skipped: inspector/css-syntax-highlight.html added
- 2:00 AM Changeset in webkit [50446] by
-
- 2 edits in trunk/WebCore
2009-11-02 Chris Fleizach <Chris Fleizach>
Reviewed by David Levin.
fix accessibility webkit-style-check errors
https://bugs.webkit.org/show_bug.cgi?id=29672
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::getOrCreate): (WebCore::AXObjectCache::remove): (WebCore::AXObjectCache::platformGenerateAXID): (WebCore::AXObjectCache::removeAXID):
- accessibility/AXObjectCache.h: (WebCore::AXObjectCache::enableAccessibility): (WebCore::AXObjectCache::enableEnhancedUserInterfaceAccessibility): (WebCore::AXObjectCache::accessibilityEnabled): (WebCore::AXObjectCache::accessibilityEnhancedUserInterfaceEnabled): (WebCore::AXObjectCache::isIDinUse): (WebCore::AXObjectCache::objectFromAXID): (WebCore::AXObjectCache::): (WebCore::AXObjectCache::handleActiveDescendantChanged): (WebCore::AXObjectCache::handleAriaRoleChanged): (WebCore::AXObjectCache::detachWrapper): (WebCore::AXObjectCache::attachWrapper): (WebCore::AXObjectCache::selectedChildrenChanged): (WebCore::AXObjectCache::postNotification): (WebCore::AXObjectCache::postPlatformNotification): (WebCore::AXObjectCache::handleFocusedUIElementChanged): (WebCore::AXObjectCache::handleScrolledToAnchor):
- accessibility/AccessibilityARIAGrid.cpp: (WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
- accessibility/AccessibilityAllInOne.cpp:
- accessibility/AccessibilityImageMapLink.cpp:
- accessibility/AccessibilityList.h: (WebCore::AccessibilityList::isList):
- accessibility/AccessibilityListBox.cpp:
- accessibility/AccessibilityListBox.h: (WebCore::AccessibilityListBox::isListBox):
- accessibility/AccessibilityListBoxOption.cpp:
- accessibility/AccessibilityListBoxOption.h: (WebCore::AccessibilityListBoxOption::isListBoxOption):
- accessibility/AccessibilityMediaControls.h: (WebCore::AccessibilityMediaControl::~AccessibilityMediaControl): (WebCore::AccessibilityMediaTimeline::~AccessibilityMediaTimeline): (WebCore::AccessibilityMediaTimeline::isMediaTimeline): (WebCore::AccessibilityMediaControlsContainer::~AccessibilityMediaControlsContainer): (WebCore::AccessibilityMediaControlsContainer::roleValue): (WebCore::AccessibilityMediaControlsContainer::accessibilityIsIgnored): (WebCore::AccessibilityMediaTimeDisplay::~AccessibilityMediaTimeDisplay): (WebCore::AccessibilityMediaTimeDisplay::roleValue):
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::parentObjectUnignored): (WebCore::AccessibilityObject::rightLineVisiblePositionRange): (WebCore::replacedNodeNeedsCharacter): (WebCore::AccessibilityObject::stringForVisiblePositionRange): (WebCore::AccessibilityObject::lengthForVisiblePositionRange): (WebCore::AccessibilityObject::actionVerb):
- accessibility/AccessibilityObject.h: (WebCore::PlainTextRange::isNull): (WebCore::AccessibilityObject::isAccessibilityRenderObject): (WebCore::AccessibilityObject::isAnchor): (WebCore::AccessibilityObject::isAttachment): (WebCore::AccessibilityObject::isHeading): (WebCore::AccessibilityObject::isLink): (WebCore::AccessibilityObject::isImage): (WebCore::AccessibilityObject::isNativeImage): (WebCore::AccessibilityObject::isImageButton): (WebCore::AccessibilityObject::isPasswordField): (WebCore::AccessibilityObject::isTextControl): (WebCore::AccessibilityObject::isNativeTextControl): (WebCore::AccessibilityObject::isWebArea): (WebCore::AccessibilityObject::isCheckboxOrRadio): (WebCore::AccessibilityObject::isListBox): (WebCore::AccessibilityObject::isFileUploadButton): (WebCore::AccessibilityObject::isProgressIndicator): (WebCore::AccessibilityObject::isSlider): (WebCore::AccessibilityObject::isControl): (WebCore::AccessibilityObject::isList): (WebCore::AccessibilityObject::isDataTable): (WebCore::AccessibilityObject::isTableRow): (WebCore::AccessibilityObject::isTableColumn): (WebCore::AccessibilityObject::isTableCell): (WebCore::AccessibilityObject::isFieldset): (WebCore::AccessibilityObject::isGroup): (WebCore::AccessibilityObject::isChecked): (WebCore::AccessibilityObject::isEnabled): (WebCore::AccessibilityObject::isSelected): (WebCore::AccessibilityObject::isFocused): (WebCore::AccessibilityObject::isHovered): (WebCore::AccessibilityObject::isIndeterminate): (WebCore::AccessibilityObject::isLoaded): (WebCore::AccessibilityObject::isMultiSelect): (WebCore::AccessibilityObject::isOffScreen): (WebCore::AccessibilityObject::isPressed): (WebCore::AccessibilityObject::isReadOnly): (WebCore::AccessibilityObject::isVisited): (WebCore::AccessibilityObject::isRequired): (WebCore::AccessibilityObject::canSetFocusAttribute): (WebCore::AccessibilityObject::canSetTextRangeAttributes): (WebCore::AccessibilityObject::canSetValueAttribute): (WebCore::AccessibilityObject::hasIntValue): (WebCore::AccessibilityObject::accessibilityShouldUseUniqueId): (WebCore::AccessibilityObject::accessibilityIsIgnored):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::parentObjectIfExists): (WebCore::AccessibilityRenderObject::parentObject): (WebCore::AccessibilityRenderObject::isMenuRelated): (WebCore::AccessibilityRenderObject::accessibilityDescription): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): (WebCore::AccessibilityRenderObject::isFocused): (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine): (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange): (WebCore::AccessibilityRenderObject::doAXRangeForLine): (WebCore::AccessibilityRenderObject::doAXStringForRange): (WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest): (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute): (WebCore::AccessibilityRenderObject::determineAccessibilityRole): (WebCore::AccessibilityRenderObject::isPresentationalChildOfAriaRole): (WebCore::AccessibilityRenderObject::canSetFocusAttribute): (WebCore::AccessibilityRenderObject::canHaveChildren): (WebCore::AccessibilityRenderObject::actionVerb): (WebCore::shouldReturnTagNameAsRoleForMSAA):
- accessibility/AccessibilityRenderObject.h: (WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
- accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySlider::orientation):
- accessibility/AccessibilitySlider.h: (WebCore::AccessibilitySlider::~AccessibilitySlider): (WebCore::AccessibilitySlider::roleValue): (WebCore::AccessibilitySlider::accessibilityIsIgnored): (WebCore::AccessibilitySlider::isSlider): (WebCore::AccessibilitySlider::canSetValueAttribute): (WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb): (WebCore::AccessibilitySliderThumb::roleValue): (WebCore::AccessibilitySliderThumb::accessibilityIsIgnored): (WebCore::AccessibilitySliderThumb::setParentObject): (WebCore::AccessibilitySliderThumb::parentObject):
- accessibility/AccessibilityTable.cpp: (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
- accessibility/AccessibilityTableColumn.cpp:
- accessibility/AccessibilityTableHeaderContainer.cpp: (WebCore::AccessibilityTableHeaderContainer::addChildren):
- accessibility/AccessibilityTableRow.cpp:
- accessibility/mac/AccessibilityObjectWrapper.h:
- 1:44 AM CommitterTips edited by
- (diff)
- 12:52 AM CommitterTips edited by
- (diff)
- 12:50 AM CommitterTips created by
- 12:27 AM WikiStart edited by
- (diff)
Nov 2, 2009:
- 11:51 PM Changeset in webkit [50445] by
-
- 2 edits in trunk/WebKitTools
2009-11-02 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=31035
[GTK] some accessibility tests hitting assertion in debug builds
Get the correct Gtk+ object before attempting to turn it into an AtkObject.
- DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: (AccessibilityController::rootElement):
- 11:01 PM Changeset in webkit [50444] by
-
- 23 edits in trunk/WebCore
fix accessibility webkit-style-check errors
https://bugs.webkit.org/show_bug.cgi?id=29672
Reviewed by David Levin.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::platformGenerateAXID):
(WebCore::AXObjectCache::removeAXID):
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::enableAccessibility):
(WebCore::AXObjectCache::enableEnhancedUserInterfaceAccessibility):
(WebCore::AXObjectCache::accessibilityEnabled):
(WebCore::AXObjectCache::accessibilityEnhancedUserInterfaceEnabled):
(WebCore::AXObjectCache::isIDinUse):
(WebCore::AXObjectCache::objectFromAXID):
(WebCore::AXObjectCache::):
(WebCore::AXObjectCache::handleActiveDescendantChanged):
(WebCore::AXObjectCache::handleAriaRoleChanged):
(WebCore::AXObjectCache::detachWrapper):
(WebCore::AXObjectCache::attachWrapper):
(WebCore::AXObjectCache::selectedChildrenChanged):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
(WebCore::AXObjectCache::handleScrolledToAnchor):
- accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
- accessibility/AccessibilityAllInOne.cpp:
- accessibility/AccessibilityImageMapLink.cpp:
- accessibility/AccessibilityList.h:
(WebCore::AccessibilityList::isList):
- accessibility/AccessibilityListBox.cpp:
- accessibility/AccessibilityListBox.h:
(WebCore::AccessibilityListBox::isListBox):
- accessibility/AccessibilityListBoxOption.cpp:
- accessibility/AccessibilityListBoxOption.h:
(WebCore::AccessibilityListBoxOption::isListBoxOption):
- accessibility/AccessibilityMediaControls.h:
(WebCore::AccessibilityMediaControl::~AccessibilityMediaControl):
(WebCore::AccessibilityMediaTimeline::~AccessibilityMediaTimeline):
(WebCore::AccessibilityMediaTimeline::isMediaTimeline):
(WebCore::AccessibilityMediaControlsContainer::~AccessibilityMediaControlsContainer):
(WebCore::AccessibilityMediaControlsContainer::roleValue):
(WebCore::AccessibilityMediaControlsContainer::accessibilityIsIgnored):
(WebCore::AccessibilityMediaTimeDisplay::~AccessibilityMediaTimeDisplay):
(WebCore::AccessibilityMediaTimeDisplay::roleValue):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::parentObjectUnignored):
(WebCore::AccessibilityObject::rightLineVisiblePositionRange):
(WebCore::replacedNodeNeedsCharacter):
(WebCore::AccessibilityObject::stringForVisiblePositionRange):
(WebCore::AccessibilityObject::lengthForVisiblePositionRange):
(WebCore::AccessibilityObject::actionVerb):
- accessibility/AccessibilityObject.h:
(WebCore::PlainTextRange::isNull):
(WebCore::AccessibilityObject::isAccessibilityRenderObject):
(WebCore::AccessibilityObject::isAnchor):
(WebCore::AccessibilityObject::isAttachment):
(WebCore::AccessibilityObject::isHeading):
(WebCore::AccessibilityObject::isLink):
(WebCore::AccessibilityObject::isImage):
(WebCore::AccessibilityObject::isNativeImage):
(WebCore::AccessibilityObject::isImageButton):
(WebCore::AccessibilityObject::isPasswordField):
(WebCore::AccessibilityObject::isTextControl):
(WebCore::AccessibilityObject::isNativeTextControl):
(WebCore::AccessibilityObject::isWebArea):
(WebCore::AccessibilityObject::isCheckboxOrRadio):
(WebCore::AccessibilityObject::isListBox):
(WebCore::AccessibilityObject::isFileUploadButton):
(WebCore::AccessibilityObject::isProgressIndicator):
(WebCore::AccessibilityObject::isSlider):
(WebCore::AccessibilityObject::isControl):
(WebCore::AccessibilityObject::isList):
(WebCore::AccessibilityObject::isDataTable):
(WebCore::AccessibilityObject::isTableRow):
(WebCore::AccessibilityObject::isTableColumn):
(WebCore::AccessibilityObject::isTableCell):
(WebCore::AccessibilityObject::isFieldset):
(WebCore::AccessibilityObject::isGroup):
(WebCore::AccessibilityObject::isChecked):
(WebCore::AccessibilityObject::isEnabled):
(WebCore::AccessibilityObject::isSelected):
(WebCore::AccessibilityObject::isFocused):
(WebCore::AccessibilityObject::isHovered):
(WebCore::AccessibilityObject::isIndeterminate):
(WebCore::AccessibilityObject::isLoaded):
(WebCore::AccessibilityObject::isMultiSelect):
(WebCore::AccessibilityObject::isOffScreen):
(WebCore::AccessibilityObject::isPressed):
(WebCore::AccessibilityObject::isReadOnly):
(WebCore::AccessibilityObject::isVisited):
(WebCore::AccessibilityObject::isRequired):
(WebCore::AccessibilityObject::canSetFocusAttribute):
(WebCore::AccessibilityObject::canSetTextRangeAttributes):
(WebCore::AccessibilityObject::canSetValueAttribute):
(WebCore::AccessibilityObject::hasIntValue):
(WebCore::AccessibilityObject::accessibilityShouldUseUniqueId):
(WebCore::AccessibilityObject::accessibilityIsIgnored):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::parentObjectIfExists):
(WebCore::AccessibilityRenderObject::parentObject):
(WebCore::AccessibilityRenderObject::isMenuRelated):
(WebCore::AccessibilityRenderObject::accessibilityDescription):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::isFocused):
(WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
(WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange):
(WebCore::AccessibilityRenderObject::doAXRangeForLine):
(WebCore::AccessibilityRenderObject::doAXStringForRange):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::isPresentationalChildOfAriaRole):
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):
(WebCore::AccessibilityRenderObject::canHaveChildren):
(WebCore::AccessibilityRenderObject::actionVerb):
(WebCore::shouldReturnTagNameAsRoleForMSAA):
- accessibility/AccessibilityRenderObject.h:
(WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
- accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::orientation):
- accessibility/AccessibilitySlider.h:
(WebCore::AccessibilitySlider::~AccessibilitySlider):
(WebCore::AccessibilitySlider::roleValue):
(WebCore::AccessibilitySlider::accessibilityIsIgnored):
(WebCore::AccessibilitySlider::isSlider):
(WebCore::AccessibilitySlider::canSetValueAttribute):
(WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb):
(WebCore::AccessibilitySliderThumb::roleValue):
(WebCore::AccessibilitySliderThumb::accessibilityIsIgnored):
(WebCore::AccessibilitySliderThumb::setParentObject):
(WebCore::AccessibilitySliderThumb::parentObject):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
- accessibility/AccessibilityTableColumn.cpp:
- accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore::AccessibilityTableHeaderContainer::addChildren):
- accessibility/AccessibilityTableRow.cpp:
- accessibility/mac/AccessibilityObjectWrapper.h:
- 10:49 PM Changeset in webkit [50443] by
-
- 6 edits in trunk
REGRESSION (r48573): JSC may incorrectly cache chain lookups with a dictionary at the head of the chain
https://bugs.webkit.org/show_bug.cgi?id=31045
Reviewed by Gavin Barraclough.
Add guards to prevent caching of prototype chain lookups with dictionaries at the
head of the chain. Also add a few tighter assertions to cached prototype lookups
to catch this in future.
- 9:51 PM Changeset in webkit [50442] by
-
- 2 edits in trunk/WebCore
2009-11-02 Darin Fisher <darin@chromium.org>
Fixing JSC build bustage.
- bindings/js/ScriptController.cpp: Added missing #include
- 9:47 PM Changeset in webkit [50441] by
-
- 7 edits in trunk/WebCore
2009-10-30 Darin Fisher <darin@chromium.org>
Reviewed by Adam Barth.
Give the FrameLoaderClient the ability to override Settings::isJavaScriptEnabled.
https://bugs.webkit.org/show_bug.cgi?id=30967
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::isEnabled):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::isEnabled):
- bindings/v8/V8Proxy.cpp: Move implementation of isEnabled to ScriptController
- bindings/v8/V8Proxy.h: Ditto
- loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::allowJavaScript):
- platform/chromium/ChromiumBridge.h: Delete uiResourceProtocol function
- 8:40 PM Changeset in webkit [50440] by
-
- 2 edits in trunk/WebCore
Rubberstamped by Mark Rowe.
Fix a typo in Mark's last commit.
- loader/archive/ArchiveFactory.cpp:
(WebCore::archiveMIMETypes):
- 8:00 PM Changeset in webkit [50439] by
-
- 2 edits in trunk/WebCore
Re-enable support for web archives on Windows. It was mistakenly disabled in r50438.
Rubber-stamped by Brady Eidson.
- loader/archive/ArchiveFactory.cpp:
(WebCore::archiveMIMETypes):
- 7:24 PM Changeset in webkit [50438] by
-
- 10 edits in trunk
2009-11-02 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
PLATFORM(CF) should be set when building for Qt on Darwin
https://bugs.webkit.org/show_bug.cgi?id=23671
- wtf/Platform.h: Turn on CF support if both QT and DARWIN platforms are defined.
2009-11-02 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
PLATFORM(CF) should be set when building for Qt on Darwin
https://bugs.webkit.org/show_bug.cgi?id=23671
- WebCore.pro: Add SharedBufferCF.cpp and SmartReplaceCF.cpp to the Darwin build.
- loader/archive/ArchiveFactory.cpp: Change the support for legacy WebArchive from all CF platforms to Mac and Chromium CF platforms. (WebCore::archiveMIMETypes):
- platform/text/AtomicString.h: Remove PLATFORM(QT) && PLATFORM(DARWIN) test as it is redundant now.
- platform/text/PlatformString.h: Ditto.
- platform/text/StringImpl.h: Ditto.
- platform/text/cf/StringCF.cpp: Ditto.
- platform/text/cf/StringImplCF.cpp: Ditto.
- 6:35 PM Changeset in webkit [50437] by
-
- 5 edits1 add in trunk/WebCore
2009-11-02 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
[Chromium] Actually declare getPluginMimeTypeFromExtension in a header.
https://bugs.webkit.org/show_bug.cgi?id=30985
Our current code does not conform to our style guide.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/chromium/MIMETypeRegistryChromium.cpp:
- plugins/chromium/PluginDataChromium.cpp:
- plugins/chromium/PluginDataChromium.h: Added.
- 6:07 PM Changeset in webkit [50436] by
-
- 3 edits in trunk/WebCore
Fix for <rdar://problem/7038305> REGRESSION (Safari 4.0.2 - ToT): After navigating back to a known phishy page, the "Ignore warning" button appears highlighted (along with the "Go Back" button)
Reviewed by Darin Adler.
This bug is timing dependent, and not always reproducible. I could not think of a way to add a
layout test that would demonstrate the problem and fix.
- platform/mac/ThemeMac.mm:
(WebCore::checkbox): Update style.
(WebCore::paintCheckbox): ditto.
(WebCore::radio): ditto.
(WebCore::paintRadio): ditto.
(WebCore::setupButtonCell): Added convenience method.
(WebCore::button): Use a separate NSButtonCell for defaultButtons and regular buttons.
(WebCore::paintButton): Don't check for the key window here. Consider that when deciding if the button should have the default style in RenderTheme.
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::isDefault): Only consider a button to be default if the page is active. This fixes
a problem I noticed where the button would flicker crazily if the page with the default button was in the background.
- 5:44 PM Changeset in webkit [50435] by
-
- 3 edits in trunk/WebCore
Minor RenderWidget clean-up in preparation for deferring widget tree
mutation when it is not safe.
Reviewed by Anders Carlsson.
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::RenderWidget): Initialize m_refCount to 1
instead of calling ref().
(WebCore::RenderWidget::destroy): Call setWidget(0) instead of
repeating what it does.
(WebCore::RenderWidget::setWidgetGeometry): Now returns a boolean
indicating whether the bounds have changed.
(WebCore::RenderWidget::setWidget): Replaced all-encompassing if
statement with an early return.
(WebCore::RenderWidget::updateWidgetPosition): Call setWidgetGeometry().
- rendering/RenderWidget.h:
- 5:39 PM QtBackLog edited by
- Mention #31009 (diff)
- 5:38 PM Changeset in webkit [50434] by
-
- 1 edit6 adds in trunk/WebCore
Adding Chromium's DatabaseTracker and SQLTransactionClient
implementations.
Patch by Dumitru Daniliuc <dumi@chromium.org> on 2009-11-02
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=30701
- storage/chromium: Added.
- storage/chromium/DatabaseObserver.h: Added.
- storage/chromium/DatabaseTrackerChromium.cpp: Added.
- storage/chromium/QuotaTracker.cpp: Added.
- storage/chromium/QuotaTracker.h: Added.
- storage/chromium/SQLTransactionClientChromium.cpp: Added.
- 5:06 PM Changeset in webkit [50433] by
-
- 4 edits2 adds in trunk
Safari crashes when calling execCommand on formatted html in special case
<rdar://problem/7318656>
https://bugs.webkit.org/show_bug.cgi?id=31023
Reviewed by Adele Peterson and Dan Bernstein.
WebCore:
Test: editing/execCommand/align-in-span.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock): Modified comment on containingBlock returning NULL.
- rendering/RenderText.cpp:
(WebCore::RenderText::setSelectionState): Added check for NULL return from containingBlock,
since it is possible when dealing with orphaned trees.
LayoutTests:
- editing/execCommand/align-in-span-expected.txt: Added.
- editing/execCommand/align-in-span.html: Added.
- 4:04 PM Changeset in webkit [50432] by
-
- 8 edits in trunk
Exception checks were being too aggressive
https://bugs.webkit.org/show_bug.cgi?id=31005
Several calls in CanvasRenderingContext3D are allowed to
have a null value passed, which indicated that the
object is being unbound. Handle this case and the corresponding
null handling in GraphicsContext3DMac.
- 2:53 PM Changeset in webkit [50431] by
-
- 2 edits1 add in trunk/WebCore
2009-11-02 Patrick Mueller <Patrick_Mueller@us.ibm.com>
Reviewed by Timothy Hatcher.
Each JS execution in console adds extra item into "scripts" combo
https://bugs.webkit.org/show_bug.cgi?id=30212
Added manual test
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
- manual-tests/inspector/hidden-evals.html: Added.
- 2:26 PM Changeset in webkit [50430] by
-
- 2 edits in trunk
2009-11-02 Estêvão Samuel Procópio <tevaum@gmail.com>
Reviewed by Gustavo Noronha.
[Build] make install ignores --prefix option for gobject-introspection.
https://bugs.webkit.org/show_bug.cgi?id=31025
Make the build system use the --prefix path also when installing
gobject-introspection files.
- configure.ac: use --prefix path in GITDIR and GIRTYPELIBDIR
- 2:03 PM Changeset in webkit [50429] by
-
- 6 edits in trunk/WebKit
2009-11-02 Eric Carlson <eric.carlson@apple.com>
Reviewed by John Sullivan and Mark Rowe.
<rdar://problem/7356733> Voiceover does not read correct media controller time values
Fix localized strings for media controller time values.
- English.lproj/Localizable.strings:
2009-11-02 Eric Carlson <eric.carlson@apple.com>
Reviewed by John Sullivan and Mark Rowe.
<rdar://problem/7356733> Voiceover does not read correct media controller time values
- WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory localizedMediaTimeDescription:]):
2009-11-02 Eric Carlson <eric.carlson@apple.com>
Reviewed by John Sullivan and Mark Rowe.
<rdar://problem/7356733> Voiceover does not read correct media controller time values
- WebCoreLocalizedStrings.cpp: (WebCore::localizedMediaTimeDescription):
- 2:02 PM Changeset in webkit [50428] by
-
- 2 edits in trunk/WebCore
2009-11-02 Kelly Norton <knorton@google.com>
Reviewed by Timothy Hatcher.
Adds a missed case for InspectorTimeline, DOMWindow dispatch of DOM events.
https://bugs.webkit.org/show_bug.cgi?id=31030
- dom/Node.cpp: (WebCore::eventHasListeners): Checks DOMWindow for listeners. (WebCore::Node::dispatchGenericEvent):
- 1:31 PM Changeset in webkit [50427] by
-
- 29 edits in trunk
Remove threadsafe refcounting from tasks used with WTF::MessageQueue.
https://bugs.webkit.org/show_bug.cgi?id=30612
Reviewed by David Levin.
- wtf/MessageQueue.h:
(WTF::MessageQueue::alwaysTruePredicate):
(WTF::MessageQueue::~MessageQueue):
(WTF::MessageQueue::append):
(WTF::MessageQueue::appendAndCheckEmpty):
(WTF::MessageQueue::prepend):
(WTF::MessageQueue::waitForMessage):
(WTF::MessageQueue::waitForMessageFilteredWithTimeout):
(WTF::MessageQueue::tryGetMessage):
(WTF::MessageQueue::removeIf):
The MessageQueue is changed to act as a queue of OwnPtr<DataType>. It takes ownership
of posted tasks and passes it to the new owner (in another thread) when the task is fetched.
All methods have arguments of type PassOwnPtr<DataType> and return the same type.
- wtf/Threading.cpp:
(WTF::createThread):
Superficial change to trigger rebuild of JSC project on Windows,
workaround for https://bugs.webkit.org/show_bug.cgi?id=30890
WebCore:
No new tests since no new functionality. Storage, MessagePorts and Workers tests cover this.
There are a lot of files but most changes are simply replace RefPtr and PassRefPtr with
OwnPtr and PassOwnPtr when dealing with Tasks.
ScriptExecutionContext::Task, DatabaseTask and WorkerRunLoop::Task are no longer
threadsafe refcounted, but simply Noncopyable.
- dom/Document.cpp:
(WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
(WebCore::PerformTaskContext::PerformTaskContext):
(WebCore::Document::postTask):
- dom/Document.h:
- dom/ScriptExecutionContext.cpp:
(WebCore::ProcessMessagesSoonTask::create):
- dom/ScriptExecutionContext.h:
- dom/default/PlatformMessagePortChannel.cpp:
(WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
- dom/default/PlatformMessagePortChannel.h:
(WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
(WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty):
- loader/FrameLoader.cpp:
(WebCore::HashChangeEventTask::create):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::CallCacheListenerTask::create):
- storage/Database.cpp:
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::scheduleTransaction):
(WebCore::Database::scheduleTransactionStep):
(WebCore::Database::tableNames):
- storage/DatabaseTask.h:
(WebCore::DatabaseOpenTask::create):
(WebCore::DatabaseCloseTask::create):
(WebCore::DatabaseTransactionTask::create):
(WebCore::DatabaseTableNamesTask::create):
- storage/DatabaseThread.cpp:
(WebCore::DatabaseThread::databaseThread):
(WebCore::DatabaseThread::scheduleTask):
(WebCore::DatabaseThread::scheduleImmediateTask):
(WebCore::SameDatabasePredicate::operator()):
- storage/DatabaseThread.h:
- storage/LocalStorageTask.h:
(WebCore::LocalStorageTask::createImport):
(WebCore::LocalStorageTask::createSync):
(WebCore::LocalStorageTask::createTerminate):
- storage/LocalStorageThread.cpp:
(WebCore::LocalStorageThread::localStorageThread):
- storage/LocalStorageThread.h:
- websockets/WebSocket.cpp:
(WebCore::ProcessWebSocketEventTask::create):
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::postTaskToLoader):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerContext):
(WebCore::SharedWorkerConnectTask::create):
- workers/GenericWorkerTask.h:
(WebCore::GenericWorkerTask1::create):
(WebCore::GenericWorkerTask2::create):
(WebCore::GenericWorkerTask3::create):
(WebCore::GenericWorkerTask4::create):
(WebCore::GenericWorkerTask5::create):
(WebCore::GenericWorkerTask6::create):
(WebCore::GenericWorkerTask7::create):
(WebCore::GenericWorkerTask8::create):
(WebCore::createCallbackTask):
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::postTask):
- workers/WorkerContext.h:
- workers/WorkerLoaderProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::MessageWorkerContextTask::create):
(WebCore::MessageWorkerTask::create):
(WebCore::WorkerExceptionTask::create):
(WebCore::WorkerContextDestroyedTask::create):
(WebCore::WorkerTerminateTask::create):
(WebCore::WorkerThreadActivityReportTask::create):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::workerThreadCreated):
- workers/WorkerMessagingProxy.h:
- workers/WorkerRunLoop.cpp:
(WebCore::ModePredicate::operator()):
(WebCore::WorkerRunLoop::runInMode):
(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::create):
(WebCore::WorkerRunLoop::Task::performTask):
(WebCore::WorkerRunLoop::Task::Task):
- workers/WorkerRunLoop.h:
(WebCore::WorkerRunLoop::Task::~Task):
(WebCore::WorkerRunLoop::Task::mode):
- 1:14 PM Changeset in webkit [50426] by
-
- 3 edits in trunk/WebKit/mac
Made the remaining time display show negative zero at the end of the
video.
Reviewed by Anders Carlsson.
Made other cleanup.
- WebView/WebVideoFullscreenHUDWindowController.h: Reverted the types of
_timeline and _volumeSlider to the more generic NSControl.
- WebView/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): Cleaned
up style.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Added an
assertion that the cast to NSButton * is legal. Removed casts.
(-[WebVideoFullscreenHUDWindowController updateTime]): Use
-setValue:forKey: instead of an NSSlider method.
(timeToString): Changed to support only non-negative values and
simplified.
(-[WebVideoFullscreenHUDWindowController remainingTimeText]): Always
prepend a “-” to the time.
- 12:14 PM Changeset in webkit [50425] by
-
- 2 edits in trunk/LayoutTests
2009-11-02 Philippe Normand <pnormand@igalia.com>
Reviewed by Jan Alonzo.
[GTK] Failing media/video-played-reset.html
https://bugs.webkit.org/show_bug.cgi?id=30589
- platform/gtk/Skipped: Unskip fixed test.
- 11:34 AM Changeset in webkit [50424] by
-
- 3 edits in trunk/WebCore
2009-11-02 Philippe Normand <pnormand@igalia.com>
Reviewed by Jan Alonzo.
[GTK] Failing media/video-played-reset.html
https://bugs.webkit.org/show_bug.cgi?id=30589
new m_seekTime attribute to keep track of the seek position
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::currentTime): (WebCore::MediaPlayerPrivate::seek):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- 11:25 AM Changeset in webkit [50423] by
-
- 2 edits in trunk/WebCore
2009-11-02 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
[GTK] Remove Referer when redirecting to non-secure site
https://bugs.webkit.org/show_bug.cgi?id=31021
Remove referer from HTTP headers when redirecting to a non-secure
site.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):
- 11:10 AM Changeset in webkit [50422] by
-
- 2 edits in trunk
2009-11-02 Xan Lopez <xlopez@igalia.com>
Bump version before release (or post-release, depending on your
point of view) so that we can make applications depending on
unreleased APIs in WebKit svn fail at configure time when the
requirements are not met.
- configure.ac:
- 11:00 AM Changeset in webkit [50421] by
-
- 2 edits in trunk/WebCore
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=18539
multipart/form-data not being parsed correctly on server due to '+' in boundary string
No test - the characters that the boundary is made of are not deterministic.
- platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::generateUniqueBoundaryString): Don't ever put a '+' in boundary string, either. Removed a FIXME to bring '/' back once GMail is fixed - I don't think we'll ever want to allow non-alphanumeric characters, as they cause problems on many web sites.
- 10:52 AM Changeset in webkit [50420] by
-
- 2 edits in trunk/LayoutTests
2009-11-02 Andrew Scherkus <scherkus@chromium.org>
Reviewed by Eric Carlson.
Increase the timeout of media/video-currentTime-set.html from 800ms to 2000ms.
Also fix call to logResult() as parameters were reversed, resulting in
printing an error message of "false".
- media/video-currentTime-set.html: Timeout increased to 2000ms.
- 10:41 AM Changeset in webkit [50419] by
-
- 3 edits2 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=30969
A no-prefix XPath node test should not match no-namespace elements in HTML document
Test: fast/xpath/null-namespace-in-html.html
- xml/XPathStep.cpp: (WebCore::XPath::nodeMatchesBasicTest): Special case non-HTML elements in HTML documents (as these are the ones that can have null namespace).
- 10:32 AM Changeset in webkit [50418] by
-
- 2 edits in trunk/WebCore
2009-11-02 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: [REGRESSION] No timeline marks on resources panel.
- inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
- 10:26 AM Changeset in webkit [50417] by
-
- 2 edits in trunk/WebCore
Possible crash in RenderSlider::layout.
https://bugs.webkit.org/show_bug.cgi?id=31016
Patch by David Levin <levin@chromium.org> on 2009-11-02
Reviewed by Dan Bernstein.
Fix out of place line of code.
Test: scrollbars/overflow-scrollbar-combinations.html
This crash only seems to repro when WebKit draws the play controls,
so the crash repros in chromium running this test but not WebKit
nightlies which use QuickTime to draw the controls.
- rendering/RenderSlider.cpp:
(WebCore::RenderSlider::layout):
- 10:17 AM Changeset in webkit [50416] by
-
- 4 edits in trunk/WebCore
2009-11-02 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Fix Qt build on Windows.
https://bugs.webkit.org/show_bug.cgi?id=30905
- WebCore.pro:
- platform/graphics/BitmapImage.h:
- platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::create):
- 10:09 AM Changeset in webkit [50415] by
-
- 5 edits4 adds in trunk
2009-11-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Adam Barth.
QWebView crash fix.
The QWebView should not crash if the stop() method is called from
a function triggered by the loadProgress signal.
A null pointer protection was added in the ProgressTracker::incrementProgress.
New autotest was created.
- loader/ProgressTracker.cpp: (WebCore::ProgressTracker::incrementProgress):
2009-11-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Adam Barth.
QWebView crash fix.
The QWebView should not crash if the stop() method is called from
a function triggered by the loadProgress signal.
A null pointer protection was added in the ProgressTracker::incrementProgress.
New autotest was created.
- tests/qwebview/tst_qwebview.cpp: (WebViewCrashTest::WebViewCrashTest): (WebViewCrashTest::loading): (tst_QWebView::crashTests):
- 10:01 AM Changeset in webkit [50414] by
-
- 2 edits in trunk/WebCore
2009-11-02 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Fix a leftover from profiles panel generalization.
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.get searchableViews):
- 9:53 AM Changeset in webkit [50413] by
-
- 2 edits in trunk/WebCore
2009-11-02 Kai Koehne <kai.koehne@nokia.com>
Reviewed by Holger Freyther.
Remove implementation of ImageDecocerQt::clearFrameBufferCache.
The implementation was buggy, and will visually break repeating
animations anyway.
- platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::clearFrameBufferCache):
- 9:35 AM Changeset in webkit [50412] by
-
- 2 edits in trunk/WebCore
2009-11-02 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=30964
[Gtk] Implemment AtkDocument
Provides access to the reported content language.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_document_get_locale):
- 9:27 AM Changeset in webkit [50411] by
-
- 6 edits2 adds in trunk
2009-11-02 Keishi Hattori <casey.hattori@gmail.com>
Reviewed by Timothy Hatcher.
Web Inspector: Rewrite CSSSourceSyntaxHighlighter so it shares more code
https://bugs.webkit.org/show_bug.cgi?id=30907
- inspector/css-syntax-highlight-expected.txt: Added.
- inspector/css-syntax-highlight.html: Added.
- inspector/javascript-syntax-highlight-expected.txt:
2009-11-02 Keishi Hattori <casey.hattori@gmail.com>
Reviewed by Timothy Hatcher.
Web Inspector: Rewrite CSSSourceSyntaxHighlighter so it shares more code
https://bugs.webkit.org/show_bug.cgi?id=30907
Test: inspector/css-syntax-highlight.html
- inspector/front-end/ElementsTreeOutline.js:
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.syntaxHighlightCSS): (WebInspector.SourceSyntaxHighlighter): (WebInspector.SourceSyntaxHighlighter.prototype.process.processChunk): (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): (WebInspector.SourceSyntaxHighlighter.prototype.process): (WebInspector.SourceSyntaxHighlighter.prototype.lex): (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken): (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode): (WebInspector.CSSSourceSyntaxHighlighter):
- inspector/front-end/inspectorSyntaxHighlight.css:
- 9:03 AM Changeset in webkit [50410] by
-
- 7 edits in trunk
WebKit/mac: WebKit part of making the appearance of the full-screen video HUD match
QuickTime Player X’s HUD.
Reviewed by John Sullivan.
- WebView/WebVideoFullscreenHUDWindowController.h: Removed unnecessary
#import statements, cleaned up style, and changed _timeline,
_volumeSlider and _playButton to have more specific types.
- WebView/WebVideoFullscreenHUDWindowController.mm: Updated #import
statements.
(webkit_CGFloor): Added this helper function.
(-[WebVideoFullscreenHUDWindowController init]): Cleaned up style.
(createTimeTextField): Changed to use the bold system font.
(-[WebVideoFullscreenHUDWindowController windowDidLoad]): Changed the
subviews’ metrics and the text fields’ text alignment.
(-[WebVideoFullscreenHUDWindowController updateTime]): Avoid conversion
from double to float.
(stringToTimeTextAttributed): Removed this useless function that
returned an NSAttributedString masquerading as an NSString.
(-[WebVideoFullscreenHUDWindowController remainingTimeText]): Removed
call to stringToTimeTextAttributed().
(-[WebVideoFullscreenHUDWindowController elapsedTimeText]): Ditto.
WebKitLibraries: WebKitSystemInterface part of making the appearance of the full-screen video HUD match
QuickTime Player X’s HUD.
Reviewed by John Sullivan.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 8:57 AM Changeset in webkit [50409] by
-
- 21 edits4 adds in trunk
Support ARIA "tab" roles
https://bugs.webkit.org/show_bug.cgi?id=30842
Reviewed by Beth Dakin.
WebCore:
Implement support for ARIA "tab", "tabpanel" and "tablist".
As a consequence, we also needed to implement aria-selected
and aria-controls.
Tests: accessibility/aria-controls-with-tabs.html
accessibility/aria-tab-roles.html
- accessibility/AXObjectCache.cpp:
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
- accessibility/AccessibilityRenderObject.h:
- accessibility/mac/AccessibilityObjectWrapper.mm:
- html/HTMLAttributeNames.in:
WebKit:
Add a localizable string for tab panel.
- English.lproj/Localizable.strings:
- StringsNotToBeLocalized.txt:
WebKit/mac:
- WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory AXARIAContentGroupText:]):
WebKitTools:
- DumpRenderTree/AccessibilityUIElement.cpp:
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
LayoutTests:
- accessibility/aria-controls-with-tabs-expected.txt: Added.
- accessibility/aria-controls-with-tabs.html: Added.
- accessibility/aria-tab-roles.html: Added.
- platform/gtk/Skipped:
- platform/mac/accessibility/aria-tab-roles-expected.txt: Added.
- platform/win/Skipped:
- 7:27 AM Changeset in webkit [50408] by
-
- 2 edits in trunk/WebCore
This is the WebKit-side change needed to fix canvas.getImageData() for
Chromium. The unpremultiply code in Skia assumes that unpremultiplied
values should be rounded, while CG does not. In addition, the fixed
point inversion used by Skia introduces slight inaccuracies that make
us fail this test. This change brings Chromium in line with
the CG path.
https://bugs.webkit.org/show_bug.cgi?id=30825
Reviewed by Dmitry Titov.
Covered by LayoutTests/fast/canvas/canvas-getImageData.html
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
- 4:36 AM BuildingQtOnOSX edited by
- (diff)
- 1:37 AM Changeset in webkit [50407] by
-
- 10 edits in trunk/WebCore
2009-11-01 Kelly Norton <knorton@google.com>
Reviewed by Timothy Hatcher.
Adds window event dispatches to InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=31002
- English.lproj/localizedStrings.js:
- dom/Node.cpp: Updated call site to willDispatchEvent and didDispatchEvent. (WebCore::Node::dispatchGenericEvent):
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willDispatchEvent): Renamed. (WebCore::InspectorTimelineAgent::didDispatchEvent): Renamed.
- inspector/InspectorTimelineAgent.h: (WebCore::):
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createEventDispatchRecord): Renamed.
- inspector/TimelineRecordFactory.h:
- inspector/front-end/TimelineAgent.js:
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype._getRecordDetails):
- page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchEvent):
- 1:25 AM Surfin' Safari Translations edited by
- (diff)
- 1:25 AM Changeset in webkit [50406] by
-
- 10 edits in trunk/WebCore
2009-11-01 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Convert script tag event into a more generic
script eval event in timeline.
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluate):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
- inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willEvaluateScript): (WebCore::InspectorTimelineAgent::didEvaluateScript):
- inspector/InspectorTimelineAgent.h: (WebCore::):
- inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createEvaluateScriptTimelineRecord):
- inspector/TimelineRecordFactory.h:
- inspector/front-end/TimelineAgent.js:
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype._getRecordDetails):
- 1:22 AM Surfin' Safari Translations created by
