Timeline
Jan 28, 2010:
- 11:42 PM Changeset in webkit [54048] by
-
- 3 edits in trunk/WebCore
2010-01-28 Nicholas Young <nicholas.young@nokia.com>
Reviewed by Eric Carlson.
Prefer provided video element width/height properties to hard coded
defaults for intrinsic size when natural video size is unavailable.
https://bugs.webkit.org/show_bug.cgi?id=34302
No new tests needed.
- rendering/RenderVideo.cpp: Attempt to use width/height properties (WebCore::RenderVideo::RenderVideo):
- rendering/RenderVideo.h: More appropriate constructor signature
- 11:16 PM Changeset in webkit [54047] by
-
- 5 edits in trunk
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
MessageEvent.data should not be repeated deserialised
https://bugs.webkit.org/show_bug.cgi?id=34311
Add test to ensure we get the same value back when accessing event.data multiple times
- fast/dom/Window/window-postmessage-clone.html:
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
MessageEvent.data should not be repeated deserialised
https://bugs.webkit.org/show_bug.cgi?id=34311
Cache the result of deserialising the event data
- bindings/scripts/CodeGeneratorJS.pm:
- dom/MessageEvent.idl:
- 11:15 PM Changeset in webkit [54046] by
-
- 3 edits in trunk/WebKit/chromium
2010-01-28 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
StorageNamespaceProxy::copy() should be a no-op
https://bugs.webkit.org/show_bug.cgi?id=34298
The comment in the code should make clear why.
- public/WebViewClient.h:
- src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespaceProxy::copy):
- 11:01 PM Changeset in webkit [54045] by
-
- 5 edits3 adds in trunk
2010-01-28 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Change CSS 'page-break-inside' property from inherited one to non-inherited one because CSS specification defines so.
Note: Currently, the 'page-break-inside' property is used only when parsing the CSS. That property is not used when rendering.
- fast/css/getComputedStyle/computed-style-page-break-inside-expected.txt: Added.
- fast/css/getComputedStyle/computed-style-page-break-inside.html: Added.
- fast/css/getComputedStyle/script-tests/computed-style-page-break-inside.js: Added.
2010-01-28 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Change CSS 'page-break-inside' property from inherited one to non-inherited one because CSS specification defines so.
Note: Currently, the 'page-break-inside' property is used only when parsing the CSS. That property is not used when rendering.
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::NonInheritedFlags::operator==): (WebCore::InheritedFlags::setBitDefaults): (WebCore::InheritedFlags::pageBreakInside): (WebCore::InheritedFlags::setPageBreakInside):
- rendering/style/StyleInheritedData.cpp: (WebCore::StyleInheritedData::StyleInheritedData): (WebCore::StyleInheritedData::operator==):
- rendering/style/StyleInheritedData.h:
- 10:41 PM Changeset in webkit [54044] by
-
- 7 edits4 adds in trunk
2010-01-28 Michael Nordman <Michael Nordman>
Reviewed by Alexey Proskuryakov.
ApplicationCache events should be deferred until after Document onload has fired.
https://bugs.webkit.org/show_bug.cgi?id=29690
- http/tests/appcache/deferred-events-expected.txt: Added.
- http/tests/appcache/deferred-events.html: Added.
- http/tests/appcache/deferred-events-delete-while-raising-expected.txt: Added.
- http/tests/appcache/deferred-events-delete-while-raising.html: Added.
2010-01-28 Michael Nordman <Michael Nordman>
Reviewed by Alexey Proskuryakov.
ApplicationCache events should be deferred until after Document onload has fired.
https://bugs.webkit.org/show_bug.cgi?id=29690
Test: http/tests/appcache/deferred-events.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::handledOnloadEvents): Tells the ApplicationCacheHost to stop deferring events.
- loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::ApplicationCacheHost): Initialize m_isDeferringEvents to true. (WebCore::ApplicationCacheHost::notifyDOMApplicationCache): Depending, defer or raise the event. (WebCore::ApplicationCacheHost::stopDeferringEvents): Raise any deferred events and reset the flag.
- loader/appcache/ApplicationCacheHost.h: Declare new data members and method.
2010-01-28 Michael Nordman <Michael Nordman>
Reviewed by Alexey Proskuryakov.
ApplicationCache events should be deferred until after Document onload has fired.
https://bugs.webkit.org/show_bug.cgi?id=29690
- src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::ApplicationCacheHost): Initialize m_isDeferringEvents to true. (WebCore::ApplicationCacheHost::notifyDOMApplicationCache): Depending, defer or raise the event. (WebCore::ApplicationCacheHost::stopDeferringEvents): Raise any deferred events and reset the flag.
- 10:11 PM Changeset in webkit [54043] by
-
- 5 edits in trunk
[wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation
implements pthread_t in a way that makes it impossible to check its validity,
which is needed by ThreadingPthreads.cpp.
- 8:49 PM Changeset in webkit [54042] by
-
- 41 edits3 deletes in trunk/WebCore
2010-01-28 Kavita Kanetkar <kkanetkar@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Generate header declaration for custom constructor callbacks
https://bugs.webkit.org/show_bug.cgi?id=33680
Added handling of 'CanBeConstructed' and 'OmitConstructor' and a new extended attribute
CustomConstructor'.
Deleted implementation .cpp files for corresponding 'CanBeConstructed'
extended attributes. These are now generated via CodeGeneratorV8.pm
Treating 'OmitConstructor' and 'CustomConstructor' to be the same in
CodeGeneratorJS.pm
Cleaned idls that had 'CustomConstructor' and 'OmitConstructor' together, and
same with CustomConstructor and CanBeConstructed.
- Android.v8bindings.mk:
- WebCore.gypi: Removed deps for classes being generated.
- bindings/scripts/CodeGeneratorJS.pm: OmitConstructor and CustomConstructor have the same behavior in generator.
- bindings/scripts/CodeGeneratorV8.pm: Generating the callbacks for constructors.
- bindings/v8/V8DOMWrapper.cpp: Removed manual calls to SetCallHandler() for constructor callbacks. (WebCore::V8DOMWrapper::getTemplate):
- bindings/v8/custom/V8CustomBinding.h: Removed manual declarations of constructor callbacks.
- bindings/v8/custom/V8DOMParserConstructor.cpp:
- bindings/v8/custom/V8EventSourceConstructor.cpp: (WebCore::V8EventSource::constructorCallback):
- bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::V8MessageChannel::constructorCallback):
- bindings/v8/custom/V8SharedWorkerCustom.cpp: (WebCore::V8SharedWorker::constructorCallback):
- bindings/v8/custom/V8WebGLArrayBufferCustom.cpp: (WebCore::V8WebGLArrayBuffer::constructorCallback):
- bindings/v8/custom/V8WebGLByteArrayCustom.cpp: (WebCore::V8WebGLByteArray::constructorCallback):
- bindings/v8/custom/V8WebGLFloatArrayCustom.cpp: (WebCore::V8WebGLFloatArray::constructorCallback):
- bindings/v8/custom/V8WebGLIntArrayCustom.cpp: (WebCore::V8WebGLIntArray::constructorCallback):
- bindings/v8/custom/V8WebGLShortArrayCustom.cpp: (WebCore::V8WebGLShortArray::constructorCallback):
- bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp: (WebCore::V8WebGLUnsignedByteArray::constructorCallback):
- bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp: (WebCore::V8WebGLUnsignedIntArray::constructorCallback):
- bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp: (WebCore::V8WebGLUnsignedShortArray::constructorCallback):
- bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: (WebCore::V8WebKitCSSMatrix::constructorCallback):
- bindings/v8/custom/V8WebKitPointConstructor.cpp: (WebCore::V8WebKitPoint::constructorCallback):
- bindings/v8/custom/V8WebSocketCustom.cpp: (WebCore::V8WebSocket::constructorCallback):
- bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::V8Worker::constructorCallback):
- bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: (WebCore::V8XMLHttpRequest::constructorCallback):
- bindings/v8/custom/V8XMLSerializerConstructor.cpp:
- bindings/v8/custom/V8XPathEvaluatorConstructor.cpp: Deleted the file. Implementation now being generated.
- bindings/v8/custom/V8XSLTProcessorCustom.cpp: Deleted the file. Implementation now being generated. (WebCore::V8XSLTProcessor::constructorCallback): Deleted the file. Implementation now being generated.
- css/WebKitCSSMatrix.idl: Added CustomConstructor attribute.
- dom/MessageChannel.idl: Added CustomConstructor attribute.
- html/canvas/WebGLArrayBuffer.idl: Added CustomConstructor attribute.
- html/canvas/WebGLByteArray.idl: Added CustomConstructor attribute.
- html/canvas/WebGLFloatArray.idl: Added CustomConstructor attribute.
- html/canvas/WebGLIntArray.idl: Added CustomConstructor attribute.
- html/canvas/WebGLShortArray.idl: Added CustomConstructor attribute.
- html/canvas/WebGLUnsignedByteArray.idl: Added CustomConstructor attribute.
- html/canvas/WebGLUnsignedIntArray.idl: Added CustomConstructor attribute.
- 8:27 PM Changeset in webkit [54041] by
-
- 3 edits in trunk/WebCore
2010-01-28 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Add stub for AXObjectCache::contentChanged when HAVE(ACCESSIBILITY) is not defined
https://bugs.webkit.org/show_bug.cgi?id=34271
No new tests, build fix only.
- accessibility/AXObjectCache.cpp: Modified. Added HAVE(ACCESSIBILITY) guards around contentChanged
- accessibility/AXObjectCache.h: Modified. (WebCore::AXObjectCache::contentChanged): Added stub
- 8:00 PM Changeset in webkit [54040] by
-
- 4 edits in trunk
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
DOM Objects shouldn't all require custom mark functions
https://bugs.webkit.org/show_bug.cgi?id=34291
Make getAnonymousValue const-friendly
- runtime/JSObject.h: (JSC::JSObject::getAnonymousValue):
2010-01-28 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Use long long rather than int64 in V8Binding.h
https://bugs.webkit.org/show_bug.cgi?id=34270
No new tests, build fix only.
- bindings/v8/V8Binding.h: Modified. (WebCore::toInt64): Returns long long
- 7:47 PM WebKit Team edited by
- (diff)
- 7:40 PM Changeset in webkit [54039] by
-
- 2 edits in trunk/WebKitTools
Adding myself to the committer list. No review needed.
- Scripts/webkitpy/committers.py:
- 6:57 PM Changeset in webkit [54038] by
-
- 2 edits in trunk/WebCore
2010-01-28 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Use long long rather than int64 in V8Binding.h
https://bugs.webkit.org/show_bug.cgi?id=34270
No new tests, build fix only.
- bindings/v8/V8Binding.h: Modified. (WebCore::toInt64): Returns long long
- 6:41 PM Changeset in webkit [54037] by
-
- 2 edits in trunk/WebCore
2010-01-28 Avi Drissman <avi@chromium.org>
Reviewed by David Levin.
Unused variable in ThemeMac (followup to change 49103).
https://bugs.webkit.org/show_bug.cgi?id=34274
Covered by existing tests.
- platform/mac/ThemeMac.mm: (WebCore::setupButtonCell):
- 6:10 PM Changeset in webkit [54036] by
-
- 6 edits in trunk
Huge plain text pastes are slow
<rdar://problem/5195056>
https://bugs.webkit.org/show_bug.cgi?id=34237
Reviewed by Maciej Stachowiak.
WebCore:
No new tests. It is a performance improvement.
The performance of the plain text paste is now linear.
We treat as a special case, a fragment that has been
created from plain text. Finding VisiblePositions and
applying style is greatly simplified, given the nature of
the fragment.
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
- editing/markup.cpp:
(WebCore::isPlainTextMarkup):
- editing/markup.h:
WebKit/mac:
Mail is ignoring the fragment created from plain text or HTML that is
passed to the delegate function, that creates a new one.
This fix avoids creating the fragment twice.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
- 5:57 PM Changeset in webkit [54035] by
-
- 2 edits in trunk/WebCore
Initialize DOM Storage's quota's current length parameter when we clone it.
https://bugs.webkit.org/show_bug.cgi?id=34294
Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-28
Reviewed by Adam Barth.
- storage/StorageMap.cpp:
(WebCore::StorageMap::copy):
- 5:49 PM Changeset in webkit [54034] by
-
- 2 edits in trunk/WebKit/qt
2010-01-28 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Support kinetic scrolling on Maemo 5
Patch by Ralf Engels <ralf.engels@nokia.com> and
Robert Griebl <rgriebl@trolltech.com>
- Api/qwebview.cpp: (QWebViewKineticScroller::QWebViewKineticScroller): (QWebViewKineticScroller::eventFilter): (QWebViewKineticScroller::currentFrame): (QWebViewKineticScroller::scrollingFrameAt): (QWebViewKineticScroller::attachToWidget): (QWebViewKineticScroller::removeFromWidget): (QWebViewKineticScroller::positionRange): (QWebViewKineticScroller::position): (QWebViewKineticScroller::viewportSize): (QWebViewKineticScroller::setPosition): (QWebView::QWebView):
- 5:32 PM Changeset in webkit [54033] by
-
- 2 edits in trunk/WebKitTools
2010-01-28 Hayato Ito <hayato@chromium.org>
Reviewed by David Levin.
Remove NULL char from input JS file because 'grep' fails if the file contains NULL char.
- Scripts/make-script-test-wrappers:
- 5:28 PM Changeset in webkit [54032] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix after r53411 on WinCairo.
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::frameCount):
- 5:21 PM Changeset in webkit [54031] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 5:15 PM Changeset in webkit [54030] by
-
- 2 edits in trunk/WebCore
2010-01-28 Nayan Kumar K <nayankk@gmail.com>
Reviewed by Laszlo Gombos.
Fix for compilation error in WML enabled build introduced because of the changeset 53514.
- wml/WMLDocument.cpp: (WebCore::WMLDocument::WMLDocument):
- 4:57 PM Changeset in webkit [54029] by
-
- 8 edits in trunk
2010-01-28 Alex Milowski <alex@milowski.com>
Reviewed by Eric Seidel.
Updates from CSS change for mathml.css
- platform/mac/mathml/presentation/sub-expected.txt:
- platform/mac/mathml/presentation/sup-expected.txt:
- platform/mac/mathml/presentation/tables-expected.checksum:
- platform/mac/mathml/presentation/tables-expected.png:
- platform/mac/mathml/presentation/tables-expected.txt:
2010-01-28 Alex Milowski <alex@milowski.com>
Reviewed by Eric Seidel.
Update to CSS to remove unnecessary line-height settings
- css/mathml.css:
- 4:31 PM Changeset in webkit [54028] by
-
- 4 edits in trunk/WebCore
Add missing includes for HashMap/HashSet
https://bugs.webkit.org/show_bug.cgi?id=34276
Reviewed by David Levin.
No new tests, build fix only.
- platform/KURL.cpp: Modified. Include HashMap.h
- platform/network/CredentialStorage.cpp: Modified. Include HashMap.h and HashSet.h
- platform/network/ProtectionSpaceHash.h: Modified. Include HashTraits.h
- 4:20 PM Changeset in webkit [54027] by
-
- 1 edit in trunk/LayoutTests/http/tests/media/resources/setCookie.cgi
Add missing svn:executable property on LayoutTests/http/tests/media/resources/setCookie.cgi
- 3:56 PM Changeset in webkit [54026] by
-
- 5 edits4 adds in trunk
2010-01-28 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Pass cookies to the GStreamer HTTP source
https://bugs.webkit.org/show_bug.cgi?id=34003
Test: http/tests/media/video-cookie.html
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback): When using an appropiate GStreamer HTTP source element, pass the cookies for the media URI to it. This fixes playback of the YouTube HTML5 videos.
- 3:50 PM Changeset in webkit [54025] by
-
- 4 edits in trunk/WebCore
[Qt] Unreviewed buildfix after r54022.
- bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObjectImp::createStructure):
- bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapRuntimeObjectImp::createStructure):
- bridge/qt/qt_runtime.h:
(JSC::Bindings::QtRuntimeMethod::createStructure):
- 3:19 PM Changeset in webkit [54024] by
-
- 2 edits in trunk/LayoutTests
[Qt] Incorrect small caps vs. normal text handling
https://bugs.webkit.org/show_bug.cgi?id=34286
- platform/qt/Skipped: css2.1/t1505-c524-font-var-00-b.html skipped
- 3:03 PM Changeset in webkit [54023] by
-
- 2 edits in trunk/WebCore
Fix an assertion beneath SerializedScriptValue::deserialize on 32-bit builds (e.g., on Windows)
Passing a JSValue to toRef on 32-bit builds can perform an allocation,
so we need to make sure we hold a JSLock when that occurs.
Reviewed by Oliver Hunt.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValueData::serialize):
(WebCore::SerializedScriptValueData::deserialize):
Moved JSLocks from here...
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):
...to this higher level, from which toRef can be called.
- 2:51 PM Changeset in webkit [54022] by
-
- 49 edits in trunk
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Simplify anonymous slot implementation
https://bugs.webkit.org/show_bug.cgi?id=34282
A class must now specify the number of slots it needs at construction time
rather than later on with a transition. This makes many things simpler,
we no longer need to need an additional transition on object creation to
add the anonymous slots, and we remove the need for a number of transition
type checks.
- API/JSCallbackConstructor.h: (JSC::JSCallbackConstructor::createStructure):
- API/JSCallbackFunction.h: (JSC::JSCallbackFunction::createStructure):
- API/JSCallbackObject.h: (JSC::JSCallbackObject::createStructure):
- JavaScriptCore.exp:
- debugger/DebuggerActivation.h: (JSC::DebuggerActivation::createStructure):
- runtime/Arguments.h: (JSC::Arguments::createStructure):
- runtime/BooleanObject.h: (JSC::BooleanObject::createStructure):
- runtime/DateInstance.h: (JSC::DateInstance::createStructure):
- runtime/DatePrototype.h: (JSC::DatePrototype::createStructure):
- runtime/FunctionPrototype.h: (JSC::FunctionPrototype::createStructure):
- runtime/GetterSetter.h: (JSC::GetterSetter::createStructure):
- runtime/GlobalEvalFunction.h: (JSC::GlobalEvalFunction::createStructure):
- runtime/InternalFunction.h: (JSC::InternalFunction::createStructure):
- runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure):
- runtime/JSActivation.h: (JSC::JSActivation::createStructure):
- runtime/JSArray.h: (JSC::JSArray::createStructure):
- runtime/JSByteArray.cpp: (JSC::JSByteArray::createStructure):
- runtime/JSCell.h: (JSC::JSCell::createDummyStructure):
- runtime/JSFunction.h: (JSC::JSFunction::createStructure):
- runtime/JSGlobalObject.h: (JSC::JSGlobalObject::createStructure):
- runtime/JSNotAnObject.h: (JSC::JSNotAnObject::createStructure):
- runtime/JSONObject.h: (JSC::JSONObject::createStructure):
- runtime/JSObject.h: (JSC::JSObject::createStructure): (JSC::JSObject::putAnonymousValue): (JSC::JSObject::getAnonymousValue):
- runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::createStructure):
- runtime/JSStaticScopeObject.h: (JSC::JSStaticScopeObject::createStructure):
- runtime/JSString.h: (JSC::Fiber::createStructure):
- runtime/JSVariableObject.h: (JSC::JSVariableObject::createStructure):
- runtime/JSWrapperObject.h: (JSC::JSWrapperObject::createStructure): (JSC::JSWrapperObject::JSWrapperObject):
- runtime/MathObject.h: (JSC::MathObject::createStructure):
- runtime/NumberConstructor.h: (JSC::NumberConstructor::createStructure):
- runtime/NumberObject.h: (JSC::NumberObject::createStructure):
- runtime/RegExpConstructor.h: (JSC::RegExpConstructor::createStructure):
- runtime/RegExpObject.h: (JSC::RegExpObject::createStructure):
- runtime/StringObject.h: (JSC::StringObject::createStructure):
- runtime/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
- runtime/Structure.cpp: (JSC::Structure::~Structure): (JSC::Structure::materializePropertyMap):
- runtime/Structure.h: (JSC::Structure::create): (JSC::Structure::anonymousSlotCount):
- runtime/StructureTransitionTable.h:
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Simplify anonymous slot implementation
https://bugs.webkit.org/show_bug.cgi?id=34282
Update JSGlue Structure usage to pass the anonymous slot count.
- UserObjectImp.h: (UserObjectImp::createStructure):
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Simplify anonymous slot implementation
https://bugs.webkit.org/show_bug.cgi?id=34282
Update the WebCore JS DOM bindings to correctly pass and
propagate the anonymous slot count information.
- bindings/js/JSDOMBinding.h: (WebCore::DOMObjectWithGlobalPointer::createStructure): (WebCore::DOMConstructorObject::createStructure):
- bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::createStructure):
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/objc/objc_runtime.h: (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
- bridge/runtime_array.h: (JSC::RuntimeArray::createStructure):
- bridge/runtime_method.h: (JSC::RuntimeMethod::createStructure):
- bridge/runtime_object.h: (JSC::RuntimeObjectImp::createStructure):
- 2:37 PM QtWebKitBackportingFixes edited by
- (diff)
- 2:26 PM Changeset in webkit [54021] by
-
- 2 edits in trunk/WebKitTools
[wx] Build fix after removal of the zlib image decoder.
- 2:17 PM Changeset in webkit [54020] by
-
- 4 edits4 adds in trunk
2010-01-27 Evan Martin <evan@chromium.org>
Reviewed by David Levin.
[chromium] hebrew vowel marks incorrectly positioned
https://bugs.webkit.org/show_bug.cgi?id=34234
Add a layout test containing some Hebrew vowels.
- fast/text/international/hebrew-vowels.html: Added.
2010-01-27 Evan Martin <evan@chromium.org>
Reviewed by David Levin.
[chromium] hebrew vowel marks incorrectly positioned
https://bugs.webkit.org/show_bug.cgi?id=34234
Fix glyph metrics computation such that the glyph offsets
are correct, so we can now make use of them.
Test: fast/text/international/hebrew-vowels.html
- platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::createGlyphArrays): initialize per-glyph offset table. (WebCore::TextRunWalker::setGlyphXPositions): use per-glyph offsets.
- platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::getGlyphMetrics): fix metrics computation such that per-glyph offsets are computed correctly.
- 2:08 PM Changeset in webkit [54019] by
-
- 2 edits in trunk/WebCore
2010-01-28 Laszlo Gombos <Laszlo Gombos>
Unreviewed build fix.
[Qt] Build fix if websockets support is turned off after r53947.
- WebCore.pro:
- 1:47 PM Changeset in webkit [54018] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 1:46 PM Changeset in webkit [54017] by
-
- 1 copy in tags/Safari-6531.22.2
New tag.
- 1:44 PM Changeset in webkit [54016] by
-
- 19 edits in trunk/WebCore
2010-01-28 Dimitri Glazkov <Dimitri Glazkov>
No review, rolling out r54012.
http://trac.webkit.org/changeset/54012
https://bugs.webkit.org/show_bug.cgi?id=34266
Introduced 33 crashes in V8 traversal/ tests.
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState):
- bindings/js/ScriptController.h:
- bindings/js/ScriptState.cpp:
- bindings/js/ScriptState.h:
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState): (WebCore::ScriptController::currentScriptState): (WebCore::ScriptController::clearWindowShell):
- bindings/v8/ScriptController.h:
- bindings/v8/ScriptScope.cpp: (WebCore::ScriptScope::ScriptScope): (WebCore::ScriptScope::success):
- bindings/v8/ScriptScope.h:
- bindings/v8/ScriptState.cpp: (WebCore::ScriptState::ScriptState): (WebCore::scriptStateFromPage):
- bindings/v8/ScriptState.h: (WebCore::ScriptState::ScriptState): (WebCore::ScriptState::frame):
- bindings/v8/V8HiddenPropertyName.h:
- bindings/v8/V8IsolatedContext.cpp: (WebCore::V8IsolatedContext::scriptState):
- bindings/v8/V8IsolatedContext.h:
- bindings/v8/V8Utilities.cpp: (WebCore::getScriptExecutionContext): (WebCore::reportException):
- bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::V8NodeIterator::nextNodeCallback): (WebCore::V8NodeIterator::previousNodeCallback):
- bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::V8TreeWalker::parentNodeCallback): (WebCore::V8TreeWalker::firstChildCallback): (WebCore::V8TreeWalker::lastChildCallback): (WebCore::V8TreeWalker::nextNodeCallback): (WebCore::V8TreeWalker::previousNodeCallback): (WebCore::V8TreeWalker::nextSiblingCallback): (WebCore::V8TreeWalker::previousSiblingCallback):
- inspector/InspectorController.cpp: (WebCore::InspectorController::injectedScriptForNodeId):
- 1:36 PM Changeset in webkit [54015] by
-
- 12 edits in trunk
Reapply 54008: Expand the NotificationPresenter::checkPermission() interface
to send the full URL of the requesting context, as well as a pointer to the
document if that context was a document.
- 1:34 PM Changeset in webkit [54014] by
-
- 4 edits in trunk/WebCore
2010-01-28 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Fix missing forward-declarations and includes in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=34272
No new tests, build fix only.
- bindings/v8/ScriptController.h: Modified. Forward-declare NPObject
- bindings/v8/V8DOMWindowShell.cpp: Modified. Include CString.h and PlatformBridge.h
- bindings/v8/V8DOMWrapper.h: Modified. Forward-declare V8Proxy
- 1:24 PM Changeset in webkit [54013] by
-
- 3 edits in trunk/LayoutTests
2010-01-28 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, trivial baseline update.
Update baseline for "Animated scaling of background-image is too slow"
https://bugs.webkit.org/show_bug.cgi?id=33808
- platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum:
- platform/mac/fast/backgrounds/size/backgroundSize16-expected.png:
- 1:05 PM Changeset in webkit [54012] by
-
- 19 edits in trunk/WebCore
2010-01-28 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Adam Barth.
Remove ScriptState::frame which is only used for reporting exceptions
in some cases in a way that diverges from the regular exception reporting in
v8 bindings.
Cache ScriptState directly on v8::Context instead of providing
implementations specific for isolated worlds and ScriptController.
- bindings/js/ScriptController.cpp:
- bindings/js/ScriptController.h:
- bindings/js/ScriptState.cpp: (WebCore::mainWorldScriptState):
- bindings/js/ScriptState.h:
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell):
- bindings/v8/ScriptController.h:
- bindings/v8/ScriptScope.cpp: (WebCore::ScriptScope::ScriptScope): (WebCore::ScriptScope::success):
- bindings/v8/ScriptScope.h:
- bindings/v8/ScriptState.cpp: (WebCore::ScriptState::ScriptState): (WebCore::ScriptState::forContext): (WebCore::ScriptState::current): (WebCore::ScriptState::empty): (WebCore::ScriptState::weakReferenceCallback): (WebCore::mainWorldScriptState): (WebCore::scriptStateFromPage):
- bindings/v8/ScriptState.h:
- bindings/v8/V8HiddenPropertyName.h:
- bindings/v8/V8IsolatedContext.cpp:
- bindings/v8/V8IsolatedContext.h:
- bindings/v8/V8Utilities.cpp: (WebCore::getScriptExecutionContext): (WebCore::reportException):
- bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::V8NodeIterator::nextNodeCallback): (WebCore::V8NodeIterator::previousNodeCallback):
- bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::V8TreeWalker::parentNodeCallback): (WebCore::V8TreeWalker::firstChildCallback): (WebCore::V8TreeWalker::lastChildCallback): (WebCore::V8TreeWalker::nextNodeCallback): (WebCore::V8TreeWalker::previousNodeCallback): (WebCore::V8TreeWalker::nextSiblingCallback): (WebCore::V8TreeWalker::previousSiblingCallback):
- inspector/InspectorController.cpp: (WebCore::InspectorController::injectedScriptForNodeId):
- 12:38 PM Changeset in webkit [54011] by
-
- 12 edits in trunk
revert
- 12:34 PM Changeset in webkit [54010] by
-
- 3 edits3 adds in trunk
2010-01-28 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Remove XSSAuditor false positive for Google Translate
https://bugs.webkit.org/show_bug.cgi?id=34242
Add a test that we allow attackers to inject directly into the href
property of the base tag.
- http/tests/security/xssAuditor/base-href-direct-expected.txt: Added.
- http/tests/security/xssAuditor/base-href-direct.html: Added.
- http/tests/security/xssAuditor/resources/echo-head-base-href-direct.pl: Added.
2010-01-28 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Remove XSSAuditor false positive for Google Translate
https://bugs.webkit.org/show_bug.cgi?id=34242
Google translate takes a base URL as a parameter, causing a false
positive in the XSS filter. This patch removes the false positive by
allowing direct injections into the href property of the base tag.
Test: http/tests/security/xssAuditor/base-href-direct.html
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canSetBaseElementURL):
- 12:27 PM Changeset in webkit [54009] by
-
- 17 edits1 add in trunk/WebCore
2010-01-28 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Save additional memory in SVG*Element classes, by introducing SVGElementRareData
https://bugs.webkit.org/show_bug.cgi?id=34268
Introduce SVGElementRareData, to remove the need to store any members in SVGElement/SVGStyledElement.
This saves some additional MB for the svg-node-count-vs-scroll.xhtml testcase.
SVGElementRareData works just like NodeRareData. Unlike ElementRareData, we're not inheriting from
NodeRareData in SVG, as we don't need all the rare data stored there, unlike Element.
- GNUmakefile.am: Add SVGElementRareData.h to build.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- dom/Node.cpp: Use Nodes bitfield to keep track wheter a SVGElement has a SVGElementRareData object associated. (WebCore::Node::Node):
- dom/Node.h: Add m_hasRareSVGData flag, merged with the existing bitfield, 10 bits remaining now. (WebCore::Node::hasRareSVGData):
- svg/SVGAnimateMotionElement.cpp: SVGElement::instancesForElement() now returns a const-reference to the HashMap instead of copying. (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
- svg/SVGAnimateTransformElement.cpp: Ditto. (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
- svg/SVGAnimationElement.cpp: Ditto. (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
- svg/SVGElement.cpp: Move the element instances HashSet and two cursor-related pointers into SVGElementRareData. (WebCore::SVGElement::SVGElement): (WebCore::SVGElement::~SVGElement): (WebCore::SVGElement::rareSVGData): Modelled just like Node::rareData(). (WebCore::SVGElement::ensureRareSVGData): Dito. (WebCore::SVGElement::accessDocumentSVGExtensions): (WebCore::SVGElement::mapInstanceToElement): Route call through SVGElementRareData. (WebCore::SVGElement::removeInstanceMapping): Ditto. (WebCore::SVGElement::instancesForElement): Ditto. (WebCore::SVGElement::setCursorElement): Ditto. (WebCore::SVGElement::setCursorImageValue): Ditto.
- svg/SVGElement.h:
- svg/SVGElementInstance.cpp: Ditto. (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
- svg/SVGElementRareData.h: Added. Based on NodeRareData - works exactly the same. (WebCore::SVGElementRareData::SVGElementRareData): (WebCore::SVGElementRareData::rareDataMap): (WebCore::SVGElementRareData::rareDataFromMap): (WebCore::SVGElementRareData::elementInstances): (WebCore::SVGElementRareData::instanceUpdatesBlocked): (WebCore::SVGElementRareData::setInstanceUpdatesBlocked): (WebCore::SVGElementRareData::cursorElement): (WebCore::SVGElementRareData::setCursorElement): (WebCore::SVGElementRareData::cursorImageValue): (WebCore::SVGElementRareData::setCursorImageValue):
- svg/SVGStyledElement.cpp: Move m_instancesUpdatesBlocked into SVGElementRareData. (WebCore::SVGStyledElement::SVGStyledElement): (WebCore::SVGStyledElement::instanceUpdatesBlocked): (WebCore::SVGStyledElement::setInstanceUpdatesBlocked):
- svg/SVGStyledElement.h:
- svg/SVGUseElement.cpp: Adapt to element instances changes, now passed as const-reference. (WebCore::dumpInstanceTree):
- 11:24 AM Changeset in webkit [54008] by
-
- 13 edits in trunk
2010-01-28 Aaron Boodman <aa@chromium.org>
Reviewed by Darin Adler.
Expand the NotificationPresenter::checkPermission() interface to send the full
URL of the requesting context, as well as a pointer to the document if that
context was a document.
- notifications/Notification.cpp: (WebCore::Notification::Notification):
- notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::NotificationCenter): (WebCore::NotificationCenter::checkPermission): Pass the full URL and document from the requesting context when calling NotificationPresenter::checkPermission().
- notifications/NotificationPresenter.h: (WebCore::NotificationPresenter::): Expand interface.
2010-01-27 Aaron Boodman <aa@chromium.org>
Reviewed by Darin Adler.
Send full URL and application id of requesting context to Chromium
when checking notification permissions.
- public/WebDocument.h:
- src/WebDocument.cpp: (WebKit::WebDocument::applicationID): Implement applicationID() method.
- public/WebNotificationPresenter.h:
- src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission):
- src/NotificationPresenterImpl.h: Send applicationID and full URL through to Chromium.
2010-01-27 Aaron Boodman <aa@chromium.org>
Expand NotificationCenter::checkPermission() interface.
It now passes the full URL instead of just the origin.
- WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::checkPermission):
- WebCoreSupport/WebDesktopNotificationsDelegate.h:
- 10:34 AM Changeset in webkit [54007] by
-
- 2 edits in trunk/LayoutTests/fast/dom/Window
Unreviewed, trivial expectations update.
- 10:08 AM QtWebKitBackportingFixes edited by
- (diff)
- 10:07 AM Changeset in webkit [54006] by
-
- 6 edits4 adds in trunk
2010-01-28 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Video can overlap position:fixed element when scrolling
https://bugs.webkit.org/show_bug.cgi?id=32180
When the scroll position changes, and we're using overlap to decide what gets composited,
then we need to re-evaluate what gets compositing when scrolling in case fixed postion elements
overlap composited elements (e.g. video).
Test: compositing/geometry/video-fixed-scrolling.html
- page/FrameView.cpp: (WebCore::FrameView::updateCompositingLayers): (WebCore::FrameView::scrollPositionChanged): Annotate the calls to updateCompositingLayers() with the type of change that occurred.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded): Ditto.
- rendering/RenderLayerCompositor.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers): For scroll changes, check for hierarchy update if m_compositingConsultsOverlap is true, and do a geometry update. For other changes, always check for hierarchy updates.
- 9:47 AM Changeset in webkit [54005] by
-
- 7 edits2 adds in trunk
Fix for user stylesheet bugs where they get parsed using the wrong compatibility mode. This was a regression
caused from Safari 3 -> 4 by the Acid3 fixes to create a real DOCTYPE in the DOM.
Reviewed by Darin Adler.
This patch makes style selector creation lazy, so that the selector isn't built unless someone asks for it.
In order to avoid creating the style selector before the compatibility mode has been determined, document
style is now created without having a dependence on an instantiated style selector. The creation of the style
is now done as a static method on CSSStyleSelector called styleForDocument, and a couple of font-related
functions have been made static as well so that they can be used by this method.
m_styleSelector on Document is now an OwnPtr.
Added userscripts/mixed-case-stylesheet.html
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForDocument):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::checkForGenericFamilyChange):
(WebCore::CSSStyleSelector::setFontSize):
(WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
(WebCore::CSSStyleSelector::fontSizeForKeyword):
- css/CSSStyleSelector.h:
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::createStyleSelector):
(WebCore::Document::attach):
(WebCore::Document::setVisuallyOrdered):
(WebCore::Document::recalcStyleSelector):
- dom/Document.h:
(WebCore::Document::styleSelector):
(WebCore::Document::visuallyOrdered):
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::determineParseMode):
- loader/PlaceholderDocument.cpp:
(WebCore::PlaceholderDocument::attach):
- 9:03 AM Changeset in webkit [54004] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-01-28 Anton Muhin <antonm@google.com>
Reviewed by Alexey Proskuryakov.
Add layout tests to verify assignment to items of NodeList
https://bugs.webkit.org/show_bug.cgi?id=34213
- fast/dom/NodeList/nodelist-item-assignment-expected.txt: Added.
- fast/dom/NodeList/nodelist-item-assignment.html: Added.
- 8:47 AM Changeset in webkit [54003] by
-
- 9 edits2 moves in trunk/WebCore
2010-01-28 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Rename ISODateTime.{cpp,h} to DateComponents.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=34245
No functional changes.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/DateComponents.cpp: Copied from WebCore/html/ISODateTime.cpp. (WebCore::DateComponents::maxWeekNumberInYear): (WebCore::DateComponents::parseYear): (WebCore::DateComponents::addDay): (WebCore::DateComponents::addMinute): (WebCore::DateComponents::parseTimeZone): (WebCore::DateComponents::parseMonth): (WebCore::DateComponents::parseDate): (WebCore::DateComponents::parseWeek): (WebCore::DateComponents::parseTime): (WebCore::DateComponents::parseDateTimeLocal): (WebCore::DateComponents::parseDateTime): (WebCore::DateComponents::setMillisecondsSinceMidnightInternal): (WebCore::DateComponents::setMillisecondsSinceEpochForDateInternal): (WebCore::DateComponents::setMillisecondsSinceEpochForDate): (WebCore::DateComponents::setMillisecondsSinceEpochForDateTime): (WebCore::DateComponents::setMillisecondsSinceEpochForDateTimeLocal): (WebCore::DateComponents::setMillisecondsSinceEpochForMonth): (WebCore::DateComponents::setMillisecondsSinceMidnight): (WebCore::DateComponents::setMillisecondsSinceEpochForWeek): (WebCore::DateComponents::millisecondsSinceEpochForTime): (WebCore::DateComponents::millisecondsSinceEpoch): (WebCore::DateComponents::toStringForTime): (WebCore::DateComponents::toString):
- html/DateComponents.h: Copied from WebCore/html/ISODateTime.h. (WebCore::DateComponents::DateComponents):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseToDouble): (WebCore::HTMLInputElement::valueAsDate): (WebCore::HTMLInputElement::setValueAsDate): (WebCore::HTMLInputElement::setValueAsNumber): (WebCore::HTMLInputElement::formStringToDateComponents):
- html/HTMLInputElement.h:
- html/ISODateTime.cpp: Removed.
- html/ISODateTime.h: Removed.
- html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch):
- 8:44 AM Changeset in webkit [54002] by
-
- 5 edits in trunk/WebKitTools
[Qt] Unreviewed, roll out r54000.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::reset):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController::display):
- 8:28 AM Changeset in webkit [54001] by
-
- 9 edits in trunk/WebCore
2010-01-28 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Use platform-specific monospace fonts in the Web Inspector
Move the OS version detection code into the frontend,
add custom CSS monospace styles for known platforms.
https://bugs.webkit.org/show_bug.cgi?id=34040
- inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::platform):
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
- inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView):
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.releaseWrapperObjectGroup): (.WebInspector.InspectorBackendStub.prototype.setInjectedScriptSource):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createConditionElement):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.URLRegExp.i.get platform): (WebInspector._detectPlatform):
- 6:41 AM Changeset in webkit [54000] by
-
- 5 edits in trunk/WebKitTools
2010-01-28 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement the display() method of the layout test controller
https://bugs.webkit.org/show_bug.cgi?id=34258
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::showPage): (WebCore::DumpRenderTree::hidePage):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::display):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 5:39 AM Changeset in webkit [53999] by
-
- 2 edits in trunk/WebKit/qt
Do not set the combobox font on Maemo5 and S60; use the
default instead.
Reviewed by Simon Hausmann.
- WebCoreSupport/QtFallbackWebPopup.cpp:
(WebCore::QtFallbackWebPopup::populate):
- 5:22 AM Changeset in webkit [53998] by
-
- 3 edits in trunk/WebKitTools
Eliminated the filename parameter from functions in
check-webkit-style's cpp.py where it is no longer used.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=34249
- Scripts/webkitpy/style/processors/cpp.py:
- Reduced number of occurrences of "filename" variable from approximately 200 to 120.
- Scripts/webkitpy/style/processors/cpp_unittest.py:
- Refactored unit tests as necessary to accommodate changes to cpp.py.
- Fixed bug in CppStyleTestBase.perform_include_what_you_use() where the incorrect file extension was getting passed to cpp_style.check_language().
- 5:06 AM Changeset in webkit [53997] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Fix for endless print loop when printing web pages
Patch by Trond Kjernåsen <trond@trolltech.com> on 2010-01-28
Reviewed by Simon Hausmann.
- Api/qwebframe.cpp:
(QWebFrame::print):
- 4:34 AM Changeset in webkit [53996] by
-
- 4 edits in trunk/WebCore
2010-01-28 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Simplify views logic in Profiler panel, and fix the problem described in the issue.
Remove image from Welcome view.
Preserve border on status bar-like buttons in Welcome view on window deactivation.
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.show): (WebInspector.ProfilesPanel.prototype.reset): (WebInspector.ProfilesPanel.prototype.addProfileHeader): (WebInspector.ProfilesPanel.prototype.showView): (WebInspector.ProfilesPanel.prototype._updateInterface):
- inspector/front-end/WelcomeView.js: (WebInspector.WelcomeView):
- inspector/front-end/inspector.css:
- 3:54 AM Changeset in webkit [53995] by
-
- 2 edits in trunk/WebCore
[Qt] Speed up KURL to QUrl conversion
https://bugs.webkit.org/show_bug.cgi?id=33873
The WebCore::String::utf8 method will use the generic WebCore::TextCodec
and then call the encode method on it. In QtWebKit this class is implemented
around the QTextCodec class. Instead of going the generic codec way we treat
the WebCore::String as a QString (no copying) and then use the built-in
QString::toUtf8 to do the conversion.
- 3:00 AM Changeset in webkit [53994] by
-
- 12 edits in trunk
[Android] [Qt] Touch event page co-ordinates are incorrect when touch is received in an iframe.
https://bugs.webkit.org/show_bug.cgi?id=34162
Reviewed by Simon Hausmann.
WebCore:
The pageX/pageY co-ordinates of a touch event should be relative to the containing frame, not the main frame. This change implements that and also updates the existing touch-inside-iframe test to also examine the page co-ordinates.
- dom/Touch.cpp:
(WebCore::Touch::Touch): Remove dead code.
- dom/Touch.h: Remove dead code.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent): Rename framePoint to pagePoint, as it seems a clearer name. Also adjust the pagePoint to be relative to the touch target element's containing frame rather than the main frame.
- platform/PlatformTouchEvent.h: Rename Android specific constructor parameter to better reflect it's contents.
- platform/PlatformTouchPoint.h: Ditto.
- platform/android/PlatformTouchEventAndroid.cpp: Ditto.
- platform/android/PlatformTouchPointAndroid.cpp: Ditto.
LayoutTests:
Update the existing iframe touch event test to also examine the page co-ordinates of the touch that is received.
- fast/events/touch/resources/touch-inside-iframe2.html:
- fast/events/touch/touch-inside-iframe-expected.txt:
- fast/events/touch/touch-inside-iframe.html:
- 2:46 AM Changeset in webkit [53993] by
-
- 2 edits in trunk/WebCore
2010-01-28 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Simplify isActivation method.
Test: WebCore/manual-tests/inspector/debugger-scopes-inspection.html
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::isActivation):
- 1:20 AM Changeset in webkit [53992] by
-
- 2 edits in trunk/LayoutTests
2010-01-28 Xan Lopez <xlopez@igalia.com>
[GTK] Can DnD files to our filechooser widget (<input type="file">)
https://bugs.webkit.org/show_bug.cgi?id=34246
Skip failing test because of this missing feature.
- platform/gtk/Skipped:
- 1:10 AM Changeset in webkit [53991] by
-
- 9 edits1 delete in trunk/LayoutTests
2010-01-28 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
Remove tests for dates later than 275760-09-13T00:00Z.
https://bugs.webkit.org/show_bug.cgi?id=34240
Date.UTC() of V8 doesn't support such dates though Date.UTC() of
JavaScriptCore does.
- fast/forms/input-valueasnumber-date-expected.txt:
- fast/forms/input-valueasnumber-datetime-expected.txt:
- fast/forms/input-valueasnumber-datetimelocal-expected.txt:
- fast/forms/input-valueasnumber-month-expected.txt:
- fast/forms/script-tests/input-valueasnumber-date.js:
- fast/forms/script-tests/input-valueasnumber-datetime.js:
- fast/forms/script-tests/input-valueasnumber-datetimelocal.js:
- fast/forms/script-tests/input-valueasnumber-month.js:
- platform/win/fast/forms/input-valueasnumber-datetime-expected.txt: Removed.
- 12:45 AM Changeset in webkit [53990] by
-
- 5 edits in trunk/WebKitTools
2010-01-28 Chris Jerdonek <Chris Jerdonek>
Reviewed by Shinichiro Hamaji.
In check-webkit-style, eliminated the dependency of
processors/cpp_unittest.py on checker.py.
- Scripts/webkitpy/style/checker.py:
- Addressed FIXME by removing STYLE_CATEGORIES data.
- Added style_categories().
- Scripts/webkitpy/style/checker_unittest.py:
- Minor changes.
- Scripts/webkitpy/style/processors/cpp.py:
- Added categories attribute to CppProcessor class (data was originally checker.STYLE_CATEGORIES).
- Scripts/webkitpy/style/processors/cpp_unittest.py:
- Addressed FIXME by eliminating "import" from checker.py.
- 12:29 AM Changeset in webkit [53989] by
-
- 3 edits in trunk/WebKitTools
2010-01-28 Anton Muhin <antonm@chromium.org>
Reviewed by Shinichiro Hamaji.
Improve treatment of conditions and rest of the line for if, else, switch and alikes
https://bugs.webkit.org/show_bug.cgi?id=34173
- Scripts/webkitpy/style/cpp_style.py:
- Scripts/webkitpy/style/cpp_style_unittest.py:
- 12:14 AM Changeset in webkit [53988] by
-
- 10 edits2 adds in branches/safari-4-branch
Merge r53567.
- 12:14 AM Changeset in webkit [53987] by
-
- 5 edits2 adds in branches/safari-4-branch
Merge r53368.
- 12:14 AM Changeset in webkit [53986] by
-
- 30 edits1 copy7 adds in branches/safari-4-branch
Merge r53512.
- 12:13 AM Changeset in webkit [53985] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r53369.
- 12:13 AM Changeset in webkit [53984] by
-
- 10 edits2 adds in branches/safari-4-branch
Merge r53220.
- 12:13 AM Changeset in webkit [53983] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r53163.
- 12:13 AM Changeset in webkit [53982] by
-
- 6 edits2 adds in branches/safari-4-branch
Merge r52351.
- 12:13 AM Changeset in webkit [53981] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r52781.
- 12:13 AM Changeset in webkit [53980] by
-
- 14 edits2 adds in branches/safari-4-branch
Merge r52773.
- 12:13 AM Changeset in webkit [53979] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r52352.
- 12:13 AM Changeset in webkit [53978] by
-
- 7 edits2 adds in branches/safari-4-branch
Merge r52233.
- 12:13 AM Changeset in webkit [53977] by
-
- 4 edits2 adds in branches/safari-4-branch
Merge r50196.
- 12:12 AM Changeset in webkit [53976] by
-
- 2 edits in trunk/WebKitTools
2010-01-28 Joe Mason <jmason@rim.com>
Reviewed by Adam Barth.
Limit login retries to 5
https://bugs.webkit.org/show_bug.cgi?id=34193
- Scripts/webkitpy/bugzilla.py:
Jan 27, 2010:
- 11:29 PM Changeset in webkit [53975] by
-
- 4 edits6 adds in trunk
2010-01-27 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
rangeOverflow/rangeUnderflow support for type=date
https://bugs.webkit.org/show_bug.cgi?id=34209
- fast/forms/ValidityState-rangeOverflow-date-expected.txt: Added.
- fast/forms/ValidityState-rangeOverflow-date.html: Added.
- fast/forms/ValidityState-rangeUnderflow-date-expected.txt: Added.
- fast/forms/ValidityState-rangeUnderflow-date.html: Added.
- fast/forms/script-tests/ValidityState-rangeOverflow-date.js: Added.
- fast/forms/script-tests/ValidityState-rangeUnderflow-date.js: Added.
2010-01-27 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
rangeOverflow/rangeUnderflow support for type=date
https://bugs.webkit.org/show_bug.cgi?id=34209
Add DATE type support to rangeUnderflow(), rangeOverflow(),
minimum(), and maximum() of HTMLInputElement.
In order to unify parsing code for value, min, and max strings,
introduce parseToDouble() function and it is called by
valueAsDate() and valueAsNumber() too.
Tests: fast/forms/ValidityState-rangeOverflow-date.html
fast/forms/ValidityState-rangeUnderflow-date.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::rangeUnderflow): Support DATE type, and use parseToDouble(). (WebCore::HTMLInputElement::rangeOverflow): ditto. (WebCore::HTMLInputElement::minimum): ditto. (WebCore::HTMLInputElement::maximum): ditto. (WebCore::HTMLInputElement::doubleValueFor): Added. (WebCore::HTMLInputElement::valueAsDate): Use parseToDouble(). (WebCore::HTMLInputElement::valueAsNumber): Use parseToDouble().
- html/HTMLInputElement.h: Declare parseToDouble().
- 11:27 PM Changeset in webkit [53974] by
-
- 2 edits in trunk/WebCore
2010-01-27 Darin Fisher <darin@chromium.org>
Fix chromium build bustage (take 2).
- bindings/scripts/CodeGeneratorV8.pm: Really treat V8CustomGetter like CustomGetter in all cases.
- 11:18 PM Changeset in webkit [53973] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip test introduced in r53972 because of missing eventSender.beginDragWithFiles()
- platform/qt/Skipped: fast/dom/Window/window-postmessage-clone-frames.html skipped.
- 10:50 PM Changeset in webkit [53972] by
-
- 2 edits in trunk/WebCore
2010-01-27 Darin Fisher <darin@chromium.org>
Fix chromium build bustage.
- bindings/scripts/CodeGeneratorV8.pm: Treat V8CustomGetter like CustomGetter in all cases.
- 10:36 PM Changeset in webkit [53971] by
-
- 3 edits in trunk/WebKit/chromium
2010-01-27 Darin Fisher <darin@chromium.org>
Reviewed by Pavel Feldman.
Expose HistoryItem::documentSequenceNumber
https://bugs.webkit.org/show_bug.cgi?id=34243
- public/WebHistoryItem.h:
- src/WebHistoryItem.cpp: (WebKit::WebHistoryItem::documentSequenceNumber): (WebKit::WebHistoryItem::setDocumentSequenceNumber):
- 9:26 PM Changeset in webkit [53970] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- 8:47 PM Changeset in webkit [53969] by
-
- 12 edits3 adds in trunk
2010-01-27 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
MessageEvent.data should deserialize in the context of the MessageEvent's global object
https://bugs.webkit.org/show_bug.cgi?id=34227
Add logic to allow us to create an Object, Array, or Date instance
so we can create them in the context of a specific global object,
rather than just using the current lexical global object.
- JavaScriptCore.exp:
- runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance):
- runtime/DateInstance.h:
- runtime/JSGlobalObject.h: (JSC::constructEmptyObject): (JSC::constructEmptyArray):
2010-01-27 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
MessageEvent.data should deserialize in the context of the MessageEvent's global object
https://bugs.webkit.org/show_bug.cgi?id=34227
Test that the object returned from postMessage.data is created in the correct context
- fast/dom/Window/resources/window-postmessage-clone-frames-frame.html: Added.
- fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added.
- fast/dom/Window/window-postmessage-clone-frames.html: Added.
2010-01-27 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
MessageEvent.data should deserialize in the context of the MessageEvent's global object
https://bugs.webkit.org/show_bug.cgi?id=34227
Make ScriptValue deserialisation support the provision of a specific global
object to use when creating new objects. This then allows us to make
MessageEvent.data and PopStateEvent.state deserialize in the correct
context.
Test: fast/dom/Window/window-postmessage-clone-frames.html
- bindings/js/JSPopStateEventCustom.cpp: Remove custom implementation of state getter
- bindings/js/SerializedScriptValue.cpp: (WebCore::DeserializingTreeWalker::DeserializingTreeWalker): (WebCore::DeserializingTreeWalker::createOutputArray): (WebCore::DeserializingTreeWalker::createOutputObject): (WebCore::DeserializingTreeWalker::convertIfTerminal): (WebCore::SerializedScriptValueData::deserialize): (WebCore::SerializedScriptValue::deserialize):
- bindings/js/SerializedScriptValue.h: (WebCore::SerializedScriptValue::deserialize):
- bindings/scripts/CodeGeneratorJS.pm: Update bindings generation to pass the correct global object, and to treat "any" as synonymous with SerializedValue.
- dom/PopStateEvent.idl:
- 7:24 PM Changeset in webkit [53968] by
-
- 2 edits in trunk/WebKitTools
Adding myself to the committer list. No review necessary.
- Scripts/webkitpy/committers.py:
- 7:22 PM Changeset in webkit [53967] by
-
- 2 edits in trunk/WebKit/gtk
2010-01-27 Martin Robinson <Martin Robinson>
Reviewed by Gustavo Noronha Silva.
[GTK] Expose the IM context via the API
https://bugs.webkit.org/show_bug.cgi?id=33327
Expose the GtkIMMultiContext as a property of WebKitWebView. This will
allow embedders to generate the input method context menu entries and
make testing certain IM context behavior possible.
- webkit/webkitwebview.cpp: (webkit_web_view_get_property): (DNDContentsRequest::webkit_web_view_get_im_context): (DNDContentsRequest::webkit_web_view_class_init):
- 6:55 PM Changeset in webkit [53966] by
-
- 3 edits in trunk/WebCore
2010-01-27 Nicholas Young <nicholas.young@nokia.com>
Reviewed by Eric Carlson.
Make media controls fade in/out transition duration configurable on a theme level.
https://bugs.webkit.org/show_bug.cgi?id=34196
No new tests needed (I hope).
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): Removed constant from contructor - the initial value is meaningless. (WebCore::RenderMedia::updateControlVisibility): Get fade in/out duration from theme.
- rendering/RenderTheme.h: (WebCore::RenderTheme::mediaControlsFadeInDuration): New virtual method. (WebCore::RenderTheme::mediaControlsFadeOutDuration): New virtual method.
- 5:41 PM Changeset in webkit [53965] by
-
- 7 edits1 copy2 moves1 add in trunk
2010-01-27 John Abd-El-Malek <jam@chromium.org>
Reviewed by Dimitri Glazkov.
Tests that when a page removes an iframe that sleeps in its unload handler and
terminates its JS execution, the outer page's JS continues running.
- fast/dom/Window/slow-unload-handler-expected.txt: Copied from LayoutTests/fast/dom/Window/slow_unload_handler-expected.txt.
- fast/dom/Window/slow-unload-handler-only-frame-is-stopped.html: Added.
- fast/dom/Window/slow-unload-handler-only-frame-is-stopped-expected.txt: Added.
- fast/dom/Window/slow-unload-handler.html: Copied from LayoutTests/fast/dom/Window/slow_unload_handler.html.
- fast/dom/Window/slow_unload_handler-expected.txt: Removed.
- fast/dom/Window/slow_unload_handler.html: Removed.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
2010-01-27 John Abd-El-Malek <jam@chromium.org>
Reviewed by Dimitri Glazkov.
Tests that when a page removes an iframe that sleeps in its unload handler and
terminates its JS execution, the outer page's JS continues running.
Tests: fast/dom/Window/slow-unload-handler-only-frame-is-stopped.html
fast/dom/Window/slow-unload-handler.html
- bindings/v8/DateExtension.cpp: (WebCore::DateExtension::OnSleepDetected):
- 5:24 PM Changeset in webkit [53964] by
-
- 5 edits3 adds in trunk
2010-01-27 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Add valueAsNumber support for type=datetime-local.
https://bugs.webkit.org/show_bug.cgi?id=34200
The test data is equivalent to input-valueasnumber-datetime.html.
The expectation contains two FAIL lines because they check
unimplemented features.
- fast/forms/input-valueasnumber-datetimelocal-expected.txt: Added.
- fast/forms/input-valueasnumber-datetimelocal.html: Added.
- fast/forms/script-tests/input-valueasnumber-datetimelocal.js: Added.
2010-01-27 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Add valueAsNumber support for type=datetime-local.
https://bugs.webkit.org/show_bug.cgi?id=34200
Implement necessary methods of ISODateTime, and call them from
HTMLInputElement.
Test: fast/forms/input-valueasnumber-datetimelocal.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsNumber): (WebCore::HTMLInputElement::setValueAsNumber):
- html/ISODateTime.cpp: (WebCore::ISODateTime::setMillisecondsSinceEpochForDateTimeLocal): Implemented. Just call setMillisecondsSinceEpochForDateTime(). (WebCore::ISODateTime::millisecondsSinceEpochForTime): Accept to be called for m_type=DateTimeLocal. (WebCore::ISODateTime::toString): Add DateTimeLocal support.
- html/ISODateTime.h: Declare new methods.
- 5:11 PM Changeset in webkit [53963] by
-
- 2 edits1 add in branches/safari-4-branch/WebCore
Merge r53867.
- 5:05 PM Changeset in webkit [53962] by
-
- 2 edits in trunk/WebKitTools
2010-01-27 George Wright <gwright@rim.com>
Reviewed by Adam Treat.
Add missing include for wtf/Platform.h
- DumpRenderTree/AccessibilityController.h:
- 4:46 PM Changeset in webkit [53961] by
-
- 3 edits in trunk/WebCore
Windows Debug_All build fix.
- platform/graphics/win/WKCACFLayer.cpp:
- platform/graphics/win/WKCACFLayerRenderer.cpp:
- 4:28 PM Changeset in webkit [53960] by
-
- 3 edits in trunk/WebKit/win
Make it possible to instantiate WebSerializedJSValue using WebKitCreateInstance
Reviewed by Dave Hyatt.
- ForEachCoClass.h:
- WebKitClassFactory.cpp:
Added WebSerializedJSValue.
- 4:23 PM Changeset in webkit [53959] by
-
- 1 edit2 adds in trunk/LayoutTests
Rubber-stamped by Adam Roben.
Add platform specific failing Windows results for two recently
added tests. I will comment on their originating bugs saying that
failing results were landed for Windows.
<https://bugs.webkit.org/show_bug.cgi?id=29564>
<https://bugs.webkit.org/show_bug.cgi?id=32696>
- platform/win/fast/css/button-height-expected.txt: Added.
- platform/win/fast/forms/input-valueasnumber-datetime-expected.txt: Added.
- 4:16 PM Changeset in webkit [53958] by
-
- 3 edits in trunk/WebCore
2010-01-27 Evan Martin <evan@chromium.org>
Reviewed by David Levin.
[chromium] complex text draws newlines as bells
https://bugs.webkit.org/show_bug.cgi?id=34186
Revert r45496 -- once we've got a glyph array, it is too late to normalize
because we could have had multiple codepoints combine into one glyph. The
Uniscribe code it mentions it's duplicating uses the log cluster map to fix
this.
Instead, we just normalize the input text if it contains any non-ascii-space
whitespace.
This fixes fast/text/international/hindi-whitespace, which currently has an
incorrect baseline containing a square box glyph.
- platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::getTextRun): (WebCore::TextRunWalker::getNormalizedTextRun):
- platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::stringToGlyphs):
- 3:41 PM Changeset in webkit [53957] by
-
- 20 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=34150
WebKit needs a mechanism to catch stale HashMap entries
It is very difficult to catch stale pointers that are HashMap keys - since a pointer's hash
is just its value, it is very unlikely that any observable problem is reproducible.
This extends hash table consistency checks to check that pointers are referencing allocated
memory blocks, and makes it possible to invoke the checks explicitly (it is not feasible
to enable CHECK_HASHTABLE_CONSISTENCY by default, because that affects performance too much).
- wtf/HashMap.h: (WTF::::checkConsistency): Call through to HashTable implementation. We can add similar calls to HashSet and HashCountedSet, but I haven't seen hard to debug problems with those yet.
- wtf/HashSet.h: (WTF::::remove): The version of checkTableConsistency that's guarded by CHECK_HASHTABLE_CONSISTENCY is now called internalCheckTableConsistency().
- wtf/HashTable.h: (WTF::HashTable::internalCheckTableConsistency): (WTF::HashTable::internalCheckTableConsistencyExceptSize): (WTF::HashTable::checkTableConsistencyExceptSize): Expose checkTableConsistency() even if CHECK_HASHTABLE_CONSISTENCY is off. (WTF::::add): Updated for checkTableConsistency renaming. (WTF::::addPassingHashCode): Ditto. (WTF::::removeAndInvalidate): Ditto. (WTF::::remove): Ditto. (WTF::::rehash): Ditto. (WTF::::checkTableConsistency): The assertion for !shouldExpand() was not correct - this function returns true for tables with m_table == 0. (WTF::::checkTableConsistencyExceptSize): Call checkValueConsistency for key. Potentially, we could do the same for values.
- wtf/HashTraits.h: (WTF::GenericHashTraits::checkValueConsistency): An empty function that can be overridden to add checks. Currently, the only override is for pointer hashes.
- wtf/RefPtrHashMap.h: (WTF::::remove): Updated for checkTableConsistency renaming.
- 3:32 PM Changeset in webkit [53956] by
-
- 7 edits in trunk
2010-01-27 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT Provide worker thread ability to track counters
https://bugs.webkit.org/show_bug.cgi?id=34221
Implement workerThreadCount() in LayoutTestController of Qt DRT
Tests:
fast/workers/dedicated-worker-lifecycle.html
fast/workers/shared-worker-frame-lifecycle.html
fast/workers/shared-worker-lifecycle.html
fast/workers/worker-lifecycle.html
- platform/qt/Skipped:
2010-01-27 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT Provide worker thread ability to track counters
https://bugs.webkit.org/show_bug.cgi?id=34221
Implement workerThreadCount() in LayoutTestController of Qt DRT
Tests:
fast/workers/dedicated-worker-lifecycle.html
fast/workers/shared-worker-frame-lifecycle.html
fast/workers/shared-worker-lifecycle.html
fast/workers/worker-lifecycle.html
- Api/qwebpage.cpp: (qt_drt_workerThreadCount):
2010-01-27 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT Provide worker thread ability to track counters
https://bugs.webkit.org/show_bug.cgi?id=34221
Implement workerThreadCount() in LayoutTestController of Qt DRT
Tests:
fast/workers/dedicated-worker-lifecycle.html
fast/workers/shared-worker-frame-lifecycle.html
fast/workers/shared-worker-lifecycle.html
fast/workers/worker-lifecycle.html
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::workerThreadCount):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 3:16 PM Changeset in webkit [53955] by
-
- 4 edits in trunk/WebCore
2010-01-27 Brian Tarricone <brian@kakai.com>
Reviewed by Gustavo Noronha Silva.
[gtk] Add support for windowless NPAPI plugins
Much of this is a translation of how the Qt backend does this,
modified for Gtk.
No new tests; there is already a windowless test in the tree.
- plugins/PluginView.cpp: (WebCore::PluginView::handleEvent): (WebCore::PluginView::PluginView):
- plugins/PluginView.h:
- plugins/gtk/PluginViewGtk.cpp: (WebCore::getRootWindow): (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paint): (WebCore::PluginView::handleKeyboardEvent): (WebCore::inputEventState): (WebCore::PluginView::initXEvent): (WebCore::setXButtonEventSpecificFields): (WebCore::setXMotionEventSpecificFields): (WebCore::setXCrossingEventSpecificFields): (WebCore::PluginView::handleMouseEvent): (WebCore::PluginView::handleFocusInEvent): (WebCore::PluginView::handleFocusOutEvent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::setNPWindowIfNeeded): (WebCore::PluginView::getValueStatic): (WebCore::PluginView::invalidateRect): (WebCore::getPluginDisplay): (WebCore::plug_removed_cb): (WebCore::getVisualAndColormap): (WebCore::PluginView::platformStart): (WebCore::PluginView::platformDestroy):
- 2:59 PM Changeset in webkit [53954] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-27 Anton Muhin <antonm@chromium.org>
Reviewed by Darin Adler.
Remove trailing \ from inline function code
https://bugs.webkit.org/show_bug.cgi?id=34223
- assembler/ARMv7Assembler.h: (JSC::ARMThumbImmediate::countLeadingZerosPartial):
- 2:41 PM Changeset in webkit [53953] by
-
- 2 edits in trunk/WebCore
2010-01-27 Anton Muhin <antonm@chromium.org>
Reviewed by David Levin.
[v8] minor cosmetic fix in V8 bindings codegenerator
https://bugs.webkit.org/show_bug.cgi?id=34224
- bindings/scripts/CodeGeneratorV8.pm:
- 2:08 PM Changeset in webkit [53952] by
-
- 2 edits in trunk/WebKitTools
Rubberstamped by Simon Hausmann.
[Qt] QtLauncher refactoring:
Make the LauncherWindow depend less on the view, so that more
code can be shared in near future.
- QtLauncher/main.cpp:
(LauncherWindow::sendTouchEvent):
(LauncherWindow::loadFinished):
(LauncherWindow::zoomIn):
(LauncherWindow::zoomOut):
(LauncherWindow::resetZoom):
(LauncherWindow::toggleZoomTextOnly):
(LauncherWindow::dumpHtml):
(LauncherWindow::selectElements):
(LauncherWindow::setupUI):
- 1:36 PM Changeset in webkit [53951] by
-
- 2 edits in trunk/WebCore
2010-01-27 Darin Fisher <darin@chromium.org>
Fix Chromium build bustage.
- rendering/RenderBoxModelObject.cpp: Add wtf/CurrentTime.h include.
- 1:17 PM Changeset in webkit [53950] by
-
- 17 edits2 deletes in trunk
2010-01-26 Darin Fisher <darin@chromium.org>
Reviewed by Brady Eidson and David Levin.
Chains of history items representing same-document navigation need to
always remember that association
Replace HistoryItem's Document pointer with a DocumentSequenceNumber.
During session history traversal, if the current HistoryItem and the
target HistoryItem have the same DocumentSequenceNumber, then it means
that the current Document should remain.
NOTE: To support Chromium's serialization of HistoryItems, I generate
DocumentSequenceNumbers that are unique across application launches.
DocumentSequenceNumbers are generated using a counter initialized with
the time of day.
Test: fast/loader/stateobjects/document-destroyed-navigate-back.html
- dom/Document.cpp: (WebCore::Document::detach):
- dom/Document.h:
- history/BackForwardList.cpp: (WebCore::BackForwardList::pushStateItem):
- history/BackForwardListChromium.cpp: (WebCore::BackForwardList::pushStateItem):
- history/HistoryItem.cpp: (WebCore::generateDocumentSequenceNumber): (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::~HistoryItem): (WebCore::HistoryItem::setStateObject):
- history/HistoryItem.h: (WebCore::HistoryItem::setDocumentSequenceNumber): (WebCore::HistoryItem::documentSequenceNumber):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::navigateWithinDocument): (WebCore::FrameLoader::loadItem):
- loader/HistoryController.cpp: (WebCore::HistoryController::updateBackForwardListForFragmentScroll): (WebCore::HistoryController::pushState): (WebCore::HistoryController::replaceState):
- loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::scheduleHistoryNavigation):
- page/History.cpp: (WebCore::History::stateObjectAdded):
- page/Page.cpp: (WebCore::Page::goToItem):
- 1:14 PM Changeset in webkit [53949] by
-
- 6 edits in trunk/WebCore
2010-01-27 Oliver Hunt <oliver@apple.com>
Reviewed by Simon Fraser.
Animated scaling of background-image is too slow
https://bugs.webkit.org/show_bug.cgi?id=33808
Implement a version of the RenderImage animated scaling optimisation
for background images. Due to the possibility of arbitrary transforms
being applied to containing elements we explicitly check the current
CTM of the context for scaling or rotation.
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawTiledImage):
- platform/graphics/GraphicsContext.h:
- platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::isIdentityOrTranslation):
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelScaleData::RenderBoxModelScaleData): (WebCore::RenderBoxModelScaleData::~RenderBoxModelScaleData): (WebCore::RenderBoxModelScaleData::size): (WebCore::RenderBoxModelScaleData::time): (WebCore::RenderBoxModelScaleData::useLowQualityScale): (WebCore::RenderBoxModelScaleData::hiqhQualityRepaintTimer): (WebCore::RenderBoxModelScaleData::setSize): (WebCore::RenderBoxModelScaleData::setTime): (WebCore::RenderBoxModelScaleData::setUseLowQualityScale): (WebCore::RenderBoxModelScaleObserver::boxModelObjectDestroyed): (WebCore::RenderBoxModelScaleObserver::highQualityRepaintTimerFired): (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality): (WebCore::RenderBoxModelObject::highQualityRepaintTimerFired): (WebCore::RenderBoxModelObject::~RenderBoxModelObject): (WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderBoxModelObject.h:
- 12:40 PM Changeset in webkit [53948] by
-
- 3 edits2 adds in trunk/WebKitTools
Rubberstamped by Simon Hausmann.
[Qt] QtLauncher refactoring:
Move out code from the MainWindow (renamed to LauncherWindow)
that is not depending on the view, and add it to a new class
called MainWindow.
- QtLauncher/QtLauncher.pro:
- QtLauncher/main.cpp:
(LauncherWindow::LauncherWindow):
(LauncherWindow::eventFilter):
(LauncherWindow::loadStarted):
(LauncherWindow::loadFinished):
(LauncherWindow::newWindow):
(LauncherWindow::setupUI):
(WebPage::createWindow):
(main):
- QtLauncher/mainwindow.cpp: Added.
(MainWindow::MainWindow):
(MainWindow::buildUI):
(MainWindow::page):
(MainWindow::setAddressUrl):
(MainWindow::addCompleterEntry):
(MainWindow::load):
(MainWindow::changeLocation):
(MainWindow::openFile):
- QtLauncher/mainwindow.h: Added.
- 12:16 PM Changeset in webkit [53947] by
-
- 6 edits1 copy in trunk
2010-01-27 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Enable websockets support in QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=34180
Remove websockets tests from skiplist.
- platform/qt/Skipped:
2010-01-27 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Enable websockets support in QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=34180
Connected between SocketStreamHandle and QTcpSocket/QSslSocket
to enable support for websockets.
Proxy authentication is not yet supported.
SSL certificate errors are ignored while this is under development.
- WebCore.pro:
- platform/network/qt/SocketStreamHandle.h:
- platform/network/qt/SocketStreamHandlePrivate.h: Added.
- platform/network/qt/SocketStreamHandleQt.cpp: (WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate): (WebCore::SocketStreamHandlePrivate::~SocketStreamHandlePrivate): (WebCore::SocketStreamHandlePrivate::socketConnected): (WebCore::SocketStreamHandlePrivate::socketReadyRead): (WebCore::SocketStreamHandlePrivate::send): (WebCore::SocketStreamHandlePrivate::close): (WebCore::SocketStreamHandlePrivate::socketSentdata): (WebCore::SocketStreamHandlePrivate::socketClosed): (WebCore::SocketStreamHandlePrivate::socketError): (WebCore::SocketStreamHandlePrivate::socketClosedCallback): (WebCore::SocketStreamHandlePrivate::socketErrorCallback): (WebCore::SocketStreamHandlePrivate::socketSslErrors): (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::~SocketStreamHandle): (WebCore::SocketStreamHandle::platformSend): (WebCore::SocketStreamHandle::platformClose):
- 12:00 PM Changeset in webkit [53946] by
-
- 4 edits2 adds in trunk
2010-01-27 Mads Ager <ager@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Support getting integer-named properties using indexing notation on document object
https://bugs.webkit.org/show_bug.cgi?id=34211
- fast/dom/HTMLDocument/get-iframe-with-integer-name-expected.txt: Added.
- fast/dom/HTMLDocument/get-iframe-with-integer-name.html: Added.
2010-01-27 Mads Ager <ager@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Support getting integer-named properties using indexing notation on document object
https://bugs.webkit.org/show_bug.cgi?id=34211
Add indexed property getter to HTMLDocument to support getting
elements with integer names using indexing notation on document.
Test: fast/dom/HTMLDocument/get-iframe-with-integer-name.html
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::indexedPropertyGetter):
- 11:30 AM Changeset in webkit [53945] by
-
- 4 edits1 add in trunk/WebCore
2010-01-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Oliver Hunt.
Instead of relying on Object.prototype.toString result use JSObject::isActivationObject
to check if a scope node is a JSActivation. Object.prototype.toString for JSActivation
will call JSActivation::toThisObject whose result depends on the current call stack.
Test: WebCore/manual-tests/inspector/debugger-scopes-inspection.html
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::isActivation):
- inspector/InjectedScriptHost.idl:
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):
- manual-tests/inspector/debugger-scopes-inspection.html: Added.
- 11:18 AM Changeset in webkit [53944] by
-
- 10 edits in trunk/WebCore
2010-01-27 Anton Muhin <antonm@google.com>
Review by Adam Barth.
Implement Node map in intrusive way for better speed.
https://bugs.webkit.org/show_bug.cgi?id=33957
- bindings/v8/DOMData.h: (WebCore::DOMData::removeObjectsFromWrapperMap):
- bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::get): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::set): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::removeIfPresent): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::contains): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::visit): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clear): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::allocateTableEntry): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::freeTableEntry):
- bindings/v8/DOMDataStore.h: (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::IntrusiveDOMWrapperMap): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clearEntry): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clearEntries): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::visitEntries): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::TableChunk::TableChunk): (WebCore::DOMDataStore::domNodeMap):
- bindings/v8/StaticDOMDataStore.cpp: (WebCore::StaticDOMDataStore::StaticDOMDataStore):
- bindings/v8/StaticDOMDataStore.h:
- bindings/v8/V8DOMMap.cpp: (WebCore::getDOMNodeMap):
- bindings/v8/V8DOMMap.h: (WebCore::AbstractWeakReferenceMap::AbstractWeakReferenceMap): (WebCore::AbstractWeakReferenceMap::weakReferenceCallback): (WebCore::WeakReferenceMap::WeakReferenceMap): (WebCore::WeakReferenceMap::set): (WebCore::WeakReferenceMap::visit):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertDocumentToV8Object): (WebCore::getWrapper): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
- bindings/v8/V8DOMWrapper.h:
- 11:15 AM Changeset in webkit [53943] by
-
- 3 edits in trunk/WebKit/chromium
2010-01-26 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
Add methods to support running a nested modal loop outside of WebKit.
https://bugs.webkit.org/show_bug.cgi?id=34199
- public/WebView.h:
- src/WebViewImpl.cpp: (WebKit::WebView::willEnterModalLoop): Create PageGroupLoadDeferrer (WebKit::WebView::didExitModalLoop): Destroy PageGroupLoadDeferrer
- 11:01 AM Changeset in webkit [53942] by
-
- 7 edits in trunk
2010-01-27 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Eric Seidel.
Remove fast/events/keydown-numpad-keys.html from gtk's Skipped list.
https://bugs.webkit.org/show_bug.cgi?id=28247
- platform/gtk/Skipped:
2010-01-27 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Eric Seidel.
Add key event mappings for numpad keys for Gtk and Chromium/Gtk.
http://bugs.webkit.org/show_bug.cgi?id=28247
Test: fast/events/keydown-numpad-keys.html
- platform/chromium/KeyCodeConversionGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent):
- platform/gtk/KeyEventGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent):
2010-01-27 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Eric Seidel.
Correctly handle the KeyLocation argument that has been introduced
recently to test location-dependent key events in EventSender.keyDown.
http://bugs.webkit.org/show_bug.cgi?id=28247
Test: fast/events/keydown-numpad-keys.html
- DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
- 10:36 AM Changeset in webkit [53941] by
-
- 20 edits1 delete in trunk/WebCore
2010-01-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: migrate from SourceFrame to SourceFrame2.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- bindings/js/JSInspectorFrontendHostCustom.cpp:
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
- inspector/front-end/InspectorBackendStub.js:
- inspector/front-end/InspectorFrontendHostStub.js:
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._innerSelectContentTab):
- inspector/front-end/ResourcesPanel.js: (WebInspector.getResourceContent):
- inspector/front-end/ScriptView.js: (WebInspector.ScriptView): (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._sidebarResizeDrag):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.set executionLine): (WebInspector.SourceFrame.prototype.revealLine): (WebInspector.SourceFrame.prototype.addBreakpoint): (WebInspector.SourceFrame.prototype.removeBreakpoint): (WebInspector.SourceFrame.prototype.addMessage): (WebInspector.SourceFrame.prototype.clearMessages): (WebInspector.SourceFrame.prototype.sizeToFitContentHeight): (WebInspector.SourceFrame.prototype.setContent): (WebInspector.SourceFrame.prototype.findSearchMatches): (WebInspector.SourceFrame.prototype._collectRegexMatches): (WebInspector.SourceFrame.prototype.setSelection): (WebInspector.SourceFrame.prototype._incrementMessageRepeatCount): (WebInspector.SourceFrame.prototype._addExistingMessagesToSource): (WebInspector.SourceFrame.prototype._addMessageToSource): (WebInspector.SourceFrame.prototype._addExistingBreakpointsToSource): (WebInspector.SourceFrame.prototype._addBreakpointToSource): (WebInspector.SourceFrame.prototype._removeBreakpointFromSource): (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint): (WebInspector.SourceFrame.prototype._contextMenu): (WebInspector.SourceFrame.prototype._toggleBreakpoint): (WebInspector.SourceFrame.prototype._editBreakpointCondition.committed): (WebInspector.SourceFrame.prototype._editBreakpointCondition.dismissed): (WebInspector.SourceFrame.prototype._editBreakpointCondition): (WebInspector.SourceFrame.prototype._showBreakpointConditionPopup): (WebInspector.SourceFrame.prototype._createConditionElement): (WebInspector.SourceFrame.prototype._keyDown): (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame): (WebInspector.SourceFrame.prototype._breakpointChanged): (WebInspector.SourceFrame.prototype.resize): (WebInspector.BreakpointLineNumberDecorator): (WebInspector.BreakpointLineNumberDecorator.prototype.decorate): (WebInspector.BreakpointLineNumberDecorator.prototype._paintBreakpoint): (WebInspector.BreakpointLineNumberDecorator.prototype._paintProgramCounter): (WebInspector.BreakpointLineNumberDecorator.prototype.mouseDown): (WebInspector.BreakpointLineNumberDecorator.prototype.contextMenu): (WebInspector.ExecutionLineDecorator): (WebInspector.ExecutionLineDecorator.prototype.decorate):
- inspector/front-end/SourceFrame2.js: Removed.
- inspector/front-end/SourceView.js: (WebInspector.SourceView): (WebInspector.SourceView.prototype.show): (WebInspector.SourceView.prototype.resize): (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded): (WebInspector.SourceView.prototype._contentLoaded): (WebInspector.SourceView.prototype.performSearch.findSearchMatches): (WebInspector.SourceView.prototype.performSearch): (WebInspector.SourceView.prototype._jumpToSearchResult): (WebInspector.SourceView.prototype._sourceFrameSetupFinished):
- inspector/front-end/TextEditor.js: (WebInspector.TextEditor.prototype._mouseDown): (WebInspector.TextEditor.prototype._copy.delayCopy): (WebInspector.TextEditor.prototype._copy): (WebInspector.TextEditor.prototype._cut):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 10:19 AM Changeset in webkit [53940] by
-
- 2 edits in trunk/WebCore
2010-01-27 Dominik Röttsches <dominik.roettsches@access-company.com>
Reviewed by Xan Lopez.
[Gtk] For removing ICU, implement IDN support by means of libidn
https://bugs.webkit.org/show_bug.cgi?id=31470
In order to avoid a new dependency,
IDN support now based on GLib for the GLib unicode backend.
- platform/KURL.cpp: (WebCore::appendEncodedHostname):
- 9:55 AM Changeset in webkit [53939] by
-
- 3 edits1 add in trunk/WebKit/chromium
2010-01-27 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
Adding missing WebMutationEvent.cpp file to fix build bustage.
https://bugs.webkit.org/show_bug.cgi?id=33882
- public/WebMutationEvent.h: Remove unnecessary constructor.
- src/WebEvent.cpp: Remove unnecessary include of WebMutationEvent.h.
- src/WebMutationEvent.cpp: Added.
- 9:43 AM Changeset in webkit [53938] by
-
- 2 edits in trunk/WebKitTools
Rubberstamped by Simon Hausmann.
[Qt] QtLauncher, coding style fixes.
- QtLauncher/main.cpp:
(MainWindow::MainWindow):
(MainWindow::sendTouchEvent):
(MainWindow::eventFilter):
(MainWindow::loadURL):
(MainWindow::setupUI):
(WebPage::createPlugin):
- 9:41 AM BuildingOnWindows edited by
- (diff)
- 9:40 AM BuildingOnWindows edited by
- (diff)
- 9:02 AM Changeset in webkit [53937] by
-
- 4 edits2 copies in trunk/WebKitTools
Rubberstamped by Simon Hausmann.
[Qt] QtLauncher refactoring, separating the webview and
adding a QGraphicsWebView based version.
- QtLauncher/QtLauncher.pro:
- QtLauncher/main.cpp:
(MainWindow::MainWindow):
- QtLauncher/webpage.h:
- QtLauncher/webview.cpp: Added.
(createContextMenu):
(WebViewGraphicsBased::mousePressEvent):
(WebViewTraditional::mousePressEvent):
(WebViewGraphicsBased::contextMenuEvent):
(WebViewTraditional::contextMenuEvent):
- QtLauncher/webview.h: Added.
(WebViewGraphicsBased::WebViewGraphicsBased):
(WebViewTraditional::WebViewTraditional):
- 8:14 AM Changeset in webkit [53936] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Update the .def files with exported symbols
Reviewed by Laszlo Gombos.
- symbian/eabi/QtWebKitu.def: Add two mangled missing new symbols for arm eabi.
- 8:06 AM Changeset in webkit [53935] by
-
- 4 edits in trunk
.: [Qt] Don't build the tests in packages, only the launcher(s)
Reviewed by Kenneth Rohde Christiansen.
- WebKit.pro:
WebCore: [Qt] For package builds use the .def files on Symbian
Reviewed by Kenneth Rohde Christiansen.
- WebCore.pro:
- 7:15 AM Changeset in webkit [53934] by
-
- 6 edits9 adds in trunk/WebKit/chromium
2010-01-27 Jay Campan <jcampan@google.com>
Reviewed by Darin Fisher.
Adding EventListeners to the chromium API.
- WebKit.gyp:
- public/WebEvent.h: Added.
- public/WebEventListener.h: Added.
- public/WebMutationEvent.h: Added.
- public/WebNode.h:
- public/WebString.h: (WebKit::operator==): (WebKit::operator!=):
- src/EventListenerWrapper.cpp: Added.
- src/EventListenerWrapper.h: Added.
- src/WebEvent.cpp: Added.
- src/WebEventListener.cpp: Added.
- src/WebEventListenerPrivate.cpp: Added.
- src/WebEventListenerPrivate.h: Added.
- src/WebNode.cpp: (WebKit::WebNode::addEventListener): (WebKit::WebNode::removeEventListener):
- src/WebString.cpp: (WebKit::WebString::equals):
- 6:58 AM Changeset in webkit [53933] by
-
- 2 edits in trunk/WebCore
2010-01-27 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Avoid watch expressions duplication
https://bugs.webkit.org/show_bug.cgi?id=33996
- inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSidebarPane.prototype._settingsLoaded):
- 6:47 AM Changeset in webkit [53932] by
-
- 2 edits in trunk/WebKitTools
2010-01-27 Alexander Pavlov <apavlov@chromium.org>
Adding myself as committer. No review necessary.
- Scripts/webkitpy/committers.py:
- 6:41 AM Changeset in webkit [53931] by
-
- 12 edits2 adds in trunk/WebCore
2010-01-27 Marcus Bulach <bulach@chromium.org>
Reviewed by Dimitri Glazkov.
Adds EventSource bindings for V8
https://bugs.webkit.org/show_bug.cgi?id=33695
No new tests (existing layout tests for EventSource should pass).
- Android.v8bindings.mk:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8DOMWrapper.h:
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- bindings/v8/WorkerContextExecutionProxy.cpp:
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8EventSourceConstructor.cpp: Added.
- bindings/v8/custom/V8EventSourceCustom.cpp: Added.
- 6:25 AM Changeset in webkit [53930] by
-
- 5 edits in trunk
2010-01-27 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Meta-methods can't be introspected using ES5 API
https://bugs.webkit.org/show_bug.cgi?id=34087
Add getOwnPropertyDescriptor() and getOwnPropertyNames() reimplementations.
Tests are in WebKit/qt/tests/qwebframe
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyDescriptor): (JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyNames): (JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyDescriptor): (JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyNames):
- bridge/qt/qt_runtime.h:
2010-01-27 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Meta-methods can't be introspected using ES5 API
https://bugs.webkit.org/show_bug.cgi?id=34087
Test that Object.getOwnPropertyDescriptor and
Object.getOwnPropertyNames work with meta-methods.
- tests/qwebframe/tst_qwebframe.cpp:
- 6:21 AM Changeset in webkit [53929] by
-
- 3 edits2 adds in trunk/WebKitTools
Rubberstamped by Simon Hausmann
[Qt] QtLauncher refactoring, separating utility methods.
- QtLauncher/QtLauncher.pro:
- QtLauncher/main.cpp:
- QtLauncher/utils.cpp: Added.
(urlFromUserInput):
- QtLauncher/utils.h: Added.
- 6:07 AM Changeset in webkit [53928] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-27 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port WTF's randomNumber
https://bugs.webkit.org/show_bug.cgi?id=33566
Use GETRAND to generate 4 byte random byte sequence to implement
weakRandomNumber. Create a secure random number generator with
AEECLSID_RANDOM to implement randomNumber.
- wtf/RandomNumber.cpp: (WTF::weakRandomNumber): (WTF::randomNumber):
- 5:51 AM Changeset in webkit [53927] by
-
- 3 edits2 adds in trunk
2010-01-27 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
Fix a crash when trying to indent a block element that was contained
in a list. This was happening because enclosingBlock() in
htmlediting.cpp can return the current the same Node when a block
element (like an <hr> or a <table>) is passed in. This causes
the indent command to think that it is not in a list item.
Work around this by checking to see if enclosingBlock returned the
same Node.
- editing/execCommand/indent-block-in-list-expected.txt: Added.
- editing/execCommand/indent-block-in-list.html: Added.
2010-01-27 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
Fix a crash when trying to indent a block element that was contained
in a list. This was happening because enclosingBlock() in
htmlediting.cpp can return the current the same Node when a block
element (like an <hr> or a <table>) is passed in. This causes
the indent command to think that it is not in a list item.
Work around this by checking to see if enclosingBlock returned the
same Node.
Test: editing/execCommand/indent-block-in-list.html
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::tryIndentingAsListItem):
- 5:34 AM Changeset in webkit [53926] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-27 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port getCPUTime
https://bugs.webkit.org/show_bug.cgi?id=33572
Use GETUPTIMEMS which returns a continuously and
linearly increasing millisecond timer from the time the device
was powered on. This function is enough to implement getCPUTime.
- runtime/TimeoutChecker.cpp: (JSC::getCPUTime):
- 5:01 AM Changeset in webkit [53925] by
-
- 9 edits1 copy1 add in trunk/WebKitTools
2010-01-27 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
webkit-patch needs an open-bugs command
https://bugs.webkit.org/show_bug.cgi?id=30793
- Scripts/test-webkitpy: import OpenBugsTest
- Scripts/webkit-patch: import OpenBugs
- Scripts/webkitpy/commands/download_unittest.py: don't import unittest
- Scripts/webkitpy/commands/early_warning_system_unittest.py: ditto
- Scripts/webkitpy/commands/queries_unittest.py: ditto
- Scripts/webkitpy/commands/queues_unittest.py: ditto
- Scripts/webkitpy/commands/upload_unittest.py: ditto
- Scripts/webkitpy/mock_bugzillatool.py: log when user.open_url is called.
- 4:43 AM Changeset in webkit [53924] by
-
- 4 edits in trunk
[Qt] Add the "d" suffix to QtWebKit's dll on Windows.
Reviewed by Tor Arne Vestbø.
- WebKit.pri:
WebCore:
- WebCore.pro:
- 4:41 AM Changeset in webkit [53923] by
-
- 1 edit1 delete in trunk/LayoutTests
[Qt] Qt port doesn't need platform dependent expected file anymore
for editing/pasteboard/paste-noscript-xhtml.html from r53873.
- platform/qt/editing/pasteboard/paste-noscript-xhtml-expected.txt: Removed.
- 4:41 AM Changeset in webkit [53922] by
-
- 2 edits1 add in trunk/JavaScriptCore
2010-01-27 Kwang Yul Seo <skyul@company100.net>
Reviewed by Oliver Hunt.
[BREWMP] Add MarkStack fastMalloc implementation for platforms without VirtualAlloc or mmap.
https://bugs.webkit.org/show_bug.cgi?id=33582
Use fastMalloc and fastFree to implement MarkStack::allocateStack and
MarkStack::releaseStack for platforms without page level allocation.
- runtime/MarkStack.h: (JSC::MarkStack::MarkStackArray::shrinkAllocation):
- runtime/MarkStackNone.cpp: Added. (JSC::MarkStack::initializePagesize): (JSC::MarkStack::allocateStack): (JSC::MarkStack::releaseStack):
- 4:17 AM Changeset in webkit [53921] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-27 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Don't use time function
https://bugs.webkit.org/show_bug.cgi?id=33577
Calling time(0) in BREW devices causes a crash because time
is not properly ported in most devices. Cast currentTime() to
time_t to get the same result as time(0).
- wtf/DateMath.cpp: (WTF::calculateUTCOffset):
- 4:10 AM Changeset in webkit [53920] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/backgrounds/animated-svg-as-background.html make fast/backgrounds/svg-as-background-5.html crash.
https://bugs.webkit.org/show_bug.cgi?id=34202
- platform/qt/Skipped: fast/backgrounds/animated-svg-as-background.html enabled because bug rolled out by r53912.
- 3:56 AM Changeset in webkit [53919] by
-
- 4 edits in trunk/WebKitTools
Rubberstamped by Simon Hausmann
[Qt] Refactor the code in the QtLauncher dealing with HTTP proxy.
- QtLauncher/main.cpp:
(MainWindow::MainWindow):
- QtLauncher/webpage.cpp:
(WebPage::WebPage):
(WebPage::applyProxy):
- QtLauncher/webpage.h:
- 3:51 AM Changeset in webkit [53918] by
-
- 2 edits in trunk
[Qt] Build fix for windows when QTDIR contains release libraries.
Unreviewed build fix
- WebKit.pri: Use the <name>.lib syntax for linking instead of qmake's -l<name> emulation
- 3:43 AM Changeset in webkit [53917] by
-
- 3 edits6 adds in trunk
2010-01-27 Matt Perry <mpcomplete@chromium.org>
Reviewed by Eric Seidel.
Fix a bug where dispatchDocumentElementAvailable was fired for fragment parsing on XML documents.
https://bugs.webkit.org/show_bug.cgi?id=33920
- userscripts/resources: Added.
- userscripts/resources/blank.xhtml: Added.
- userscripts/script-not-run-for-fragments-expected.txt: Added.
- userscripts/script-not-run-for-fragments.html: Added.
- userscripts/script-run-at-start-expected.txt: Added.
- userscripts/script-run-at-start.html: Added.
2010-01-27 Matt Perry <mpcomplete@chromium.org>
Reviewed by Eric Seidel.
Fix a bug where dispatchDocumentElementAvailable was fired for fragment parsing on XML documents.
https://bugs.webkit.org/show_bug.cgi?id=33920
Tests: userscripts/script-not-run-for-fragments.html
userscripts/script-run-at-start.html
- dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::startElementNs):
- 3:18 AM Changeset in webkit [53916] by
-
- 3 edits in trunk/WebCore
2010-01-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Improve SourceHTMLTokenizer so that it treats script tag well.
- inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype._isAttribute): (WebInspector.SourceHTMLTokenizer.prototype._isAttributeValue): (WebInspector.SourceHTMLTokenizer.prototype._setAttributeValue): (WebInspector.SourceHTMLTokenizer.prototype._setAttribute): (WebInspector.SourceHTMLTokenizer.prototype._stringToken): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
- inspector/front-end/SourceHTMLTokenizer.re2js:
- 3:16 AM Changeset in webkit [53915] by
-
- 8 edits6 deletes in trunk/WebCore
2010-01-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: nuke quarantine wrappers.
- Android.jscbindings.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSInspectedObjectWrapper.cpp: Removed.
- bindings/js/JSInspectedObjectWrapper.h: Removed.
- bindings/js/JSInspectorCallbackWrapper.cpp: Removed.
- bindings/js/JSInspectorCallbackWrapper.h: Removed.
- bindings/js/JSQuarantinedObjectWrapper.cpp: Removed.
- bindings/js/JSQuarantinedObjectWrapper.h: Removed.
- 2:41 AM BuildingOnWindows edited by
- (diff)
- 1:49 AM Changeset in webkit [53914] by
-
- 2 edits in trunk/WebKitTools
[Qt] Corrects debug build of DumpRenderTree on Windows.
Reviewed by Tor Arne Vestbø.
- DumpRenderTree/qt/DumpRenderTree.pro:
- 1:09 AM Changeset in webkit [53913] by
-
- 2 edits in trunk
Fix a typo in ChangeLogs.
- 1:06 AM Changeset in webkit [53912] by
-
- 21 edits in trunk
Revert r53899 (HashMap<AtomicStringImpl*, Value> key checks) and subsequent bug fixes,
because they make SVG tests crash in release builds.
- 12:41 AM Changeset in webkit [53911] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/backgrounds/animated-svg-as-background.html make fast/backgrounds/svg-as-background-5.html crash.
https://bugs.webkit.org/show_bug.cgi?id=34202
- platform/qt/Skipped: fast/backgrounds/animated-svg-as-background.html skipped until fix.
- 12:36 AM Changeset in webkit [53910] by
-
- 3 edits in trunk/WebCore
2010-01-25 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
autobuffer value not forwarded media element to MediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=33889
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadResource): Forward autobuffer value to MediaPlayer instance.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load): Forward autobuffer and preservesPitch values to newly created platform media player instance.
- 12:24 AM Changeset in webkit [53909] by
-
- 5 edits in trunk
2010-01-25 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
[Gtk] media/video-reverse-play-duration.html fails on and off on Gtk buildbots
https://bugs.webkit.org/show_bug.cgi?id=34086
Cache media duration and fix didEnd() in case of reverse
playback. When EOS was reached but in case of reverse playback the
position is not always 0. So to not confuse the HTMLMediaElement
we synchronize position and duration values.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::duration): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::didEnd): (WebCore::MediaPlayerPrivate::durationChanged):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
2010-01-25 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
[Gtk] media/video-reverse-play-duration.html fails on and off on Gtk buildbots
https://bugs.webkit.org/show_bug.cgi?id=34086
- platform/gtk/Skipped: Unskip fixed test.
- 12:06 AM Changeset in webkit [53908] by
-
- 2 edits in trunk/WebCore
- WebCore.xcodeproj/project.pbxproj: Actually land the change to add ContainerNodeAlgorithms.h (it's "svn resolved", not "svn revert"!).
