Timeline
Jan 28, 2010:
- 11:42 PM Changeset in webkit [54048] by
-
- 3 edits in trunk/WebCore
2010-01-28 Nicholas Young <nicholas.young@nokia.com>
Reviewed by Eric Carlson.
Prefer provided video element width/height properties to hard coded
defaults for intrinsic size when natural video size is unavailable.
https://bugs.webkit.org/show_bug.cgi?id=34302
No new tests needed.
- rendering/RenderVideo.cpp: Attempt to use width/height properties (WebCore::RenderVideo::RenderVideo):
- rendering/RenderVideo.h: More appropriate constructor signature
- 11:16 PM Changeset in webkit [54047] by
-
- 5 edits in trunk
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
MessageEvent.data should not be repeated deserialised
https://bugs.webkit.org/show_bug.cgi?id=34311
Add test to ensure we get the same value back when accessing event.data multiple times
- fast/dom/Window/window-postmessage-clone.html:
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
MessageEvent.data should not be repeated deserialised
https://bugs.webkit.org/show_bug.cgi?id=34311
Cache the result of deserialising the event data
- bindings/scripts/CodeGeneratorJS.pm:
- dom/MessageEvent.idl:
- 11:15 PM Changeset in webkit [54046] by
-
- 3 edits in trunk/WebKit/chromium
2010-01-28 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
StorageNamespaceProxy::copy() should be a no-op
https://bugs.webkit.org/show_bug.cgi?id=34298
The comment in the code should make clear why.
- public/WebViewClient.h:
- src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespaceProxy::copy):
- 11:01 PM Changeset in webkit [54045] by
-
- 5 edits3 adds in trunk
2010-01-28 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Change CSS 'page-break-inside' property from inherited one to non-inherited one because CSS specification defines so.
Note: Currently, the 'page-break-inside' property is used only when parsing the CSS. That property is not used when rendering.
- fast/css/getComputedStyle/computed-style-page-break-inside-expected.txt: Added.
- fast/css/getComputedStyle/computed-style-page-break-inside.html: Added.
- fast/css/getComputedStyle/script-tests/computed-style-page-break-inside.js: Added.
2010-01-28 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Change CSS 'page-break-inside' property from inherited one to non-inherited one because CSS specification defines so.
Note: Currently, the 'page-break-inside' property is used only when parsing the CSS. That property is not used when rendering.
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::NonInheritedFlags::operator==): (WebCore::InheritedFlags::setBitDefaults): (WebCore::InheritedFlags::pageBreakInside): (WebCore::InheritedFlags::setPageBreakInside):
- rendering/style/StyleInheritedData.cpp: (WebCore::StyleInheritedData::StyleInheritedData): (WebCore::StyleInheritedData::operator==):
- rendering/style/StyleInheritedData.h:
- 10:41 PM Changeset in webkit [54044] by
-
- 7 edits4 adds in trunk
2010-01-28 Michael Nordman <Michael Nordman>
Reviewed by Alexey Proskuryakov.
ApplicationCache events should be deferred until after Document onload has fired.
https://bugs.webkit.org/show_bug.cgi?id=29690
- http/tests/appcache/deferred-events-expected.txt: Added.
- http/tests/appcache/deferred-events.html: Added.
- http/tests/appcache/deferred-events-delete-while-raising-expected.txt: Added.
- http/tests/appcache/deferred-events-delete-while-raising.html: Added.
2010-01-28 Michael Nordman <Michael Nordman>
Reviewed by Alexey Proskuryakov.
ApplicationCache events should be deferred until after Document onload has fired.
https://bugs.webkit.org/show_bug.cgi?id=29690
Test: http/tests/appcache/deferred-events.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::handledOnloadEvents): Tells the ApplicationCacheHost to stop deferring events.
- loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::ApplicationCacheHost): Initialize m_isDeferringEvents to true. (WebCore::ApplicationCacheHost::notifyDOMApplicationCache): Depending, defer or raise the event. (WebCore::ApplicationCacheHost::stopDeferringEvents): Raise any deferred events and reset the flag.
- loader/appcache/ApplicationCacheHost.h: Declare new data members and method.
2010-01-28 Michael Nordman <Michael Nordman>
Reviewed by Alexey Proskuryakov.
ApplicationCache events should be deferred until after Document onload has fired.
https://bugs.webkit.org/show_bug.cgi?id=29690
- src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::ApplicationCacheHost): Initialize m_isDeferringEvents to true. (WebCore::ApplicationCacheHost::notifyDOMApplicationCache): Depending, defer or raise the event. (WebCore::ApplicationCacheHost::stopDeferringEvents): Raise any deferred events and reset the flag.
- 10:11 PM Changeset in webkit [54043] by
-
- 5 edits in trunk
[wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation
implements pthread_t in a way that makes it impossible to check its validity,
which is needed by ThreadingPthreads.cpp.
- 8:49 PM Changeset in webkit [54042] by
-
- 41 edits3 deletes in trunk/WebCore
2010-01-28 Kavita Kanetkar <kkanetkar@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Generate header declaration for custom constructor callbacks
https://bugs.webkit.org/show_bug.cgi?id=33680
Added handling of 'CanBeConstructed' and 'OmitConstructor' and a new extended attribute
CustomConstructor'.
Deleted implementation .cpp files for corresponding 'CanBeConstructed'
extended attributes. These are now generated via CodeGeneratorV8.pm
Treating 'OmitConstructor' and 'CustomConstructor' to be the same in
CodeGeneratorJS.pm
Cleaned idls that had 'CustomConstructor' and 'OmitConstructor' together, and
same with CustomConstructor and CanBeConstructed.
- Android.v8bindings.mk:
- WebCore.gypi: Removed deps for classes being generated.
- bindings/scripts/CodeGeneratorJS.pm: OmitConstructor and CustomConstructor have the same behavior in generator.
- bindings/scripts/CodeGeneratorV8.pm: Generating the callbacks for constructors.
- bindings/v8/V8DOMWrapper.cpp: Removed manual calls to SetCallHandler() for constructor callbacks. (WebCore::V8DOMWrapper::getTemplate):
- bindings/v8/custom/V8CustomBinding.h: Removed manual declarations of constructor callbacks.
- bindings/v8/custom/V8DOMParserConstructor.cpp:
- bindings/v8/custom/V8EventSourceConstructor.cpp: (WebCore::V8EventSource::constructorCallback):
- bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::V8MessageChannel::constructorCallback):
- bindings/v8/custom/V8SharedWorkerCustom.cpp: (WebCore::V8SharedWorker::constructorCallback):
- bindings/v8/custom/V8WebGLArrayBufferCustom.cpp: (WebCore::V8WebGLArrayBuffer::constructorCallback):
- bindings/v8/custom/V8WebGLByteArrayCustom.cpp: (WebCore::V8WebGLByteArray::constructorCallback):
- bindings/v8/custom/V8WebGLFloatArrayCustom.cpp: (WebCore::V8WebGLFloatArray::constructorCallback):
- bindings/v8/custom/V8WebGLIntArrayCustom.cpp: (WebCore::V8WebGLIntArray::constructorCallback):
- bindings/v8/custom/V8WebGLShortArrayCustom.cpp: (WebCore::V8WebGLShortArray::constructorCallback):
- bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp: (WebCore::V8WebGLUnsignedByteArray::constructorCallback):
- bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp: (WebCore::V8WebGLUnsignedIntArray::constructorCallback):
- bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp: (WebCore::V8WebGLUnsignedShortArray::constructorCallback):
- bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: (WebCore::V8WebKitCSSMatrix::constructorCallback):
- bindings/v8/custom/V8WebKitPointConstructor.cpp: (WebCore::V8WebKitPoint::constructorCallback):
- bindings/v8/custom/V8WebSocketCustom.cpp: (WebCore::V8WebSocket::constructorCallback):
- bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::V8Worker::constructorCallback):
- bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: (WebCore::V8XMLHttpRequest::constructorCallback):
- bindings/v8/custom/V8XMLSerializerConstructor.cpp:
- bindings/v8/custom/V8XPathEvaluatorConstructor.cpp: Deleted the file. Implementation now being generated.
- bindings/v8/custom/V8XSLTProcessorCustom.cpp: Deleted the file. Implementation now being generated. (WebCore::V8XSLTProcessor::constructorCallback): Deleted the file. Implementation now being generated.
- css/WebKitCSSMatrix.idl: Added CustomConstructor attribute.
- dom/MessageChannel.idl: Added CustomConstructor attribute.
- html/canvas/WebGLArrayBuffer.idl: Added CustomConstructor attribute.
- html/canvas/WebGLByteArray.idl: Added CustomConstructor attribute.
- html/canvas/WebGLFloatArray.idl: Added CustomConstructor attribute.
- html/canvas/WebGLIntArray.idl: Added CustomConstructor attribute.
- html/canvas/WebGLShortArray.idl: Added CustomConstructor attribute.
- html/canvas/WebGLUnsignedByteArray.idl: Added CustomConstructor attribute.
- html/canvas/WebGLUnsignedIntArray.idl: Added CustomConstructor attribute.
- 8:27 PM Changeset in webkit [54041] by
-
- 3 edits in trunk/WebCore
2010-01-28 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Add stub for AXObjectCache::contentChanged when HAVE(ACCESSIBILITY) is not defined
https://bugs.webkit.org/show_bug.cgi?id=34271
No new tests, build fix only.
- accessibility/AXObjectCache.cpp: Modified. Added HAVE(ACCESSIBILITY) guards around contentChanged
- accessibility/AXObjectCache.h: Modified. (WebCore::AXObjectCache::contentChanged): Added stub
- 8:00 PM Changeset in webkit [54040] by
-
- 4 edits in trunk
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
DOM Objects shouldn't all require custom mark functions
https://bugs.webkit.org/show_bug.cgi?id=34291
Make getAnonymousValue const-friendly
- runtime/JSObject.h: (JSC::JSObject::getAnonymousValue):
2010-01-28 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Use long long rather than int64 in V8Binding.h
https://bugs.webkit.org/show_bug.cgi?id=34270
No new tests, build fix only.
- bindings/v8/V8Binding.h: Modified. (WebCore::toInt64): Returns long long
- 7:47 PM WebKit Team edited by
- (diff)
- 7:40 PM Changeset in webkit [54039] by
-
- 2 edits in trunk/WebKitTools
Adding myself to the committer list. No review needed.
- Scripts/webkitpy/committers.py:
- 6:57 PM Changeset in webkit [54038] by
-
- 2 edits in trunk/WebCore
2010-01-28 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Use long long rather than int64 in V8Binding.h
https://bugs.webkit.org/show_bug.cgi?id=34270
No new tests, build fix only.
- bindings/v8/V8Binding.h: Modified. (WebCore::toInt64): Returns long long
- 6:41 PM Changeset in webkit [54037] by
-
- 2 edits in trunk/WebCore
2010-01-28 Avi Drissman <avi@chromium.org>
Reviewed by David Levin.
Unused variable in ThemeMac (followup to change 49103).
https://bugs.webkit.org/show_bug.cgi?id=34274
Covered by existing tests.
- platform/mac/ThemeMac.mm: (WebCore::setupButtonCell):
- 6:10 PM Changeset in webkit [54036] by
-
- 6 edits in trunk
Huge plain text pastes are slow
<rdar://problem/5195056>
https://bugs.webkit.org/show_bug.cgi?id=34237
Reviewed by Maciej Stachowiak.
WebCore:
No new tests. It is a performance improvement.
The performance of the plain text paste is now linear.
We treat as a special case, a fragment that has been
created from plain text. Finding VisiblePositions and
applying style is greatly simplified, given the nature of
the fragment.
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
- editing/markup.cpp:
(WebCore::isPlainTextMarkup):
- editing/markup.h:
WebKit/mac:
Mail is ignoring the fragment created from plain text or HTML that is
passed to the delegate function, that creates a new one.
This fix avoids creating the fragment twice.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
- 5:57 PM Changeset in webkit [54035] by
-
- 2 edits in trunk/WebCore
Initialize DOM Storage's quota's current length parameter when we clone it.
https://bugs.webkit.org/show_bug.cgi?id=34294
Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-28
Reviewed by Adam Barth.
- storage/StorageMap.cpp:
(WebCore::StorageMap::copy):
- 5:49 PM Changeset in webkit [54034] by
-
- 2 edits in trunk/WebKit/qt
2010-01-28 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Support kinetic scrolling on Maemo 5
Patch by Ralf Engels <ralf.engels@nokia.com> and
Robert Griebl <rgriebl@trolltech.com>
- Api/qwebview.cpp: (QWebViewKineticScroller::QWebViewKineticScroller): (QWebViewKineticScroller::eventFilter): (QWebViewKineticScroller::currentFrame): (QWebViewKineticScroller::scrollingFrameAt): (QWebViewKineticScroller::attachToWidget): (QWebViewKineticScroller::removeFromWidget): (QWebViewKineticScroller::positionRange): (QWebViewKineticScroller::position): (QWebViewKineticScroller::viewportSize): (QWebViewKineticScroller::setPosition): (QWebView::QWebView):
- 5:32 PM Changeset in webkit [54033] by
-
- 2 edits in trunk/WebKitTools
2010-01-28 Hayato Ito <hayato@chromium.org>
Reviewed by David Levin.
Remove NULL char from input JS file because 'grep' fails if the file contains NULL char.
- Scripts/make-script-test-wrappers:
- 5:28 PM Changeset in webkit [54032] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix after r53411 on WinCairo.
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::frameCount):
- 5:21 PM Changeset in webkit [54031] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 5:15 PM Changeset in webkit [54030] by
-
- 2 edits in trunk/WebCore
2010-01-28 Nayan Kumar K <nayankk@gmail.com>
Reviewed by Laszlo Gombos.
Fix for compilation error in WML enabled build introduced because of the changeset 53514.
- wml/WMLDocument.cpp: (WebCore::WMLDocument::WMLDocument):
- 4:57 PM Changeset in webkit [54029] by
-
- 8 edits in trunk
2010-01-28 Alex Milowski <alex@milowski.com>
Reviewed by Eric Seidel.
Updates from CSS change for mathml.css
- platform/mac/mathml/presentation/sub-expected.txt:
- platform/mac/mathml/presentation/sup-expected.txt:
- platform/mac/mathml/presentation/tables-expected.checksum:
- platform/mac/mathml/presentation/tables-expected.png:
- platform/mac/mathml/presentation/tables-expected.txt:
2010-01-28 Alex Milowski <alex@milowski.com>
Reviewed by Eric Seidel.
Update to CSS to remove unnecessary line-height settings
- css/mathml.css:
- 4:31 PM Changeset in webkit [54028] by
-
- 4 edits in trunk/WebCore
Add missing includes for HashMap/HashSet
https://bugs.webkit.org/show_bug.cgi?id=34276
Reviewed by David Levin.
No new tests, build fix only.
- platform/KURL.cpp: Modified. Include HashMap.h
- platform/network/CredentialStorage.cpp: Modified. Include HashMap.h and HashSet.h
- platform/network/ProtectionSpaceHash.h: Modified. Include HashTraits.h
- 4:20 PM Changeset in webkit [54027] by
-
- 1 edit in trunk/LayoutTests/http/tests/media/resources/setCookie.cgi
Add missing svn:executable property on LayoutTests/http/tests/media/resources/setCookie.cgi
- 3:56 PM Changeset in webkit [54026] by
-
- 5 edits4 adds in trunk
2010-01-28 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Pass cookies to the GStreamer HTTP source
https://bugs.webkit.org/show_bug.cgi?id=34003
Test: http/tests/media/video-cookie.html
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback): When using an appropiate GStreamer HTTP source element, pass the cookies for the media URI to it. This fixes playback of the YouTube HTML5 videos.
- 3:50 PM Changeset in webkit [54025] by
-
- 4 edits in trunk/WebCore
[Qt] Unreviewed buildfix after r54022.
- bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObjectImp::createStructure):
- bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapRuntimeObjectImp::createStructure):
- bridge/qt/qt_runtime.h:
(JSC::Bindings::QtRuntimeMethod::createStructure):
- 3:19 PM Changeset in webkit [54024] by
-
- 2 edits in trunk/LayoutTests
[Qt] Incorrect small caps vs. normal text handling
https://bugs.webkit.org/show_bug.cgi?id=34286
- platform/qt/Skipped: css2.1/t1505-c524-font-var-00-b.html skipped
- 3:03 PM Changeset in webkit [54023] by
-
- 2 edits in trunk/WebCore
Fix an assertion beneath SerializedScriptValue::deserialize on 32-bit builds (e.g., on Windows)
Passing a JSValue to toRef on 32-bit builds can perform an allocation,
so we need to make sure we hold a JSLock when that occurs.
Reviewed by Oliver Hunt.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValueData::serialize):
(WebCore::SerializedScriptValueData::deserialize):
Moved JSLocks from here...
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):
...to this higher level, from which toRef can be called.
- 2:51 PM Changeset in webkit [54022] by
-
- 49 edits in trunk
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Simplify anonymous slot implementation
https://bugs.webkit.org/show_bug.cgi?id=34282
A class must now specify the number of slots it needs at construction time
rather than later on with a transition. This makes many things simpler,
we no longer need to need an additional transition on object creation to
add the anonymous slots, and we remove the need for a number of transition
type checks.
- API/JSCallbackConstructor.h: (JSC::JSCallbackConstructor::createStructure):
- API/JSCallbackFunction.h: (JSC::JSCallbackFunction::createStructure):
- API/JSCallbackObject.h: (JSC::JSCallbackObject::createStructure):
- JavaScriptCore.exp:
- debugger/DebuggerActivation.h: (JSC::DebuggerActivation::createStructure):
- runtime/Arguments.h: (JSC::Arguments::createStructure):
- runtime/BooleanObject.h: (JSC::BooleanObject::createStructure):
- runtime/DateInstance.h: (JSC::DateInstance::createStructure):
- runtime/DatePrototype.h: (JSC::DatePrototype::createStructure):
- runtime/FunctionPrototype.h: (JSC::FunctionPrototype::createStructure):
- runtime/GetterSetter.h: (JSC::GetterSetter::createStructure):
- runtime/GlobalEvalFunction.h: (JSC::GlobalEvalFunction::createStructure):
- runtime/InternalFunction.h: (JSC::InternalFunction::createStructure):
- runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure):
- runtime/JSActivation.h: (JSC::JSActivation::createStructure):
- runtime/JSArray.h: (JSC::JSArray::createStructure):
- runtime/JSByteArray.cpp: (JSC::JSByteArray::createStructure):
- runtime/JSCell.h: (JSC::JSCell::createDummyStructure):
- runtime/JSFunction.h: (JSC::JSFunction::createStructure):
- runtime/JSGlobalObject.h: (JSC::JSGlobalObject::createStructure):
- runtime/JSNotAnObject.h: (JSC::JSNotAnObject::createStructure):
- runtime/JSONObject.h: (JSC::JSONObject::createStructure):
- runtime/JSObject.h: (JSC::JSObject::createStructure): (JSC::JSObject::putAnonymousValue): (JSC::JSObject::getAnonymousValue):
- runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::createStructure):
- runtime/JSStaticScopeObject.h: (JSC::JSStaticScopeObject::createStructure):
- runtime/JSString.h: (JSC::Fiber::createStructure):
- runtime/JSVariableObject.h: (JSC::JSVariableObject::createStructure):
- runtime/JSWrapperObject.h: (JSC::JSWrapperObject::createStructure): (JSC::JSWrapperObject::JSWrapperObject):
- runtime/MathObject.h: (JSC::MathObject::createStructure):
- runtime/NumberConstructor.h: (JSC::NumberConstructor::createStructure):
- runtime/NumberObject.h: (JSC::NumberObject::createStructure):
- runtime/RegExpConstructor.h: (JSC::RegExpConstructor::createStructure):
- runtime/RegExpObject.h: (JSC::RegExpObject::createStructure):
- runtime/StringObject.h: (JSC::StringObject::createStructure):
- runtime/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
- runtime/Structure.cpp: (JSC::Structure::~Structure): (JSC::Structure::materializePropertyMap):
- runtime/Structure.h: (JSC::Structure::create): (JSC::Structure::anonymousSlotCount):
- runtime/StructureTransitionTable.h:
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Simplify anonymous slot implementation
https://bugs.webkit.org/show_bug.cgi?id=34282
Update JSGlue Structure usage to pass the anonymous slot count.
- UserObjectImp.h: (UserObjectImp::createStructure):
2010-01-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Simplify anonymous slot implementation
https://bugs.webkit.org/show_bug.cgi?id=34282
Update the WebCore JS DOM bindings to correctly pass and
propagate the anonymous slot count information.
- bindings/js/JSDOMBinding.h: (WebCore::DOMObjectWithGlobalPointer::createStructure): (WebCore::DOMConstructorObject::createStructure):
- bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::createStructure):
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/objc/objc_runtime.h: (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
- bridge/runtime_array.h: (JSC::RuntimeArray::createStructure):
- bridge/runtime_method.h: (JSC::RuntimeMethod::createStructure):
- bridge/runtime_object.h: (JSC::RuntimeObjectImp::createStructure):
- 2:37 PM QtWebKitBackportingFixes edited by
- (diff)
- 2:26 PM Changeset in webkit [54021] by
-
- 2 edits in trunk/WebKitTools
[wx] Build fix after removal of the zlib image decoder.
- 2:17 PM Changeset in webkit [54020] by
-
- 4 edits4 adds in trunk
2010-01-27 Evan Martin <evan@chromium.org>
Reviewed by David Levin.
[chromium] hebrew vowel marks incorrectly positioned
https://bugs.webkit.org/show_bug.cgi?id=34234
Add a layout test containing some Hebrew vowels.
- fast/text/international/hebrew-vowels.html: Added.
2010-01-27 Evan Martin <evan@chromium.org>
Reviewed by David Levin.
[chromium] hebrew vowel marks incorrectly positioned
https://bugs.webkit.org/show_bug.cgi?id=34234
Fix glyph metrics computation such that the glyph offsets
are correct, so we can now make use of them.
Test: fast/text/international/hebrew-vowels.html
- platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::createGlyphArrays): initialize per-glyph offset table. (WebCore::TextRunWalker::setGlyphXPositions): use per-glyph offsets.
- platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::getGlyphMetrics): fix metrics computation such that per-glyph offsets are computed correctly.
- 2:08 PM Changeset in webkit [54019] by
-
- 2 edits in trunk/WebCore
2010-01-28 Laszlo Gombos <Laszlo Gombos>
Unreviewed build fix.
[Qt] Build fix if websockets support is turned off after r53947.
- WebCore.pro:
- 1:47 PM Changeset in webkit [54018] by
-
- 4 edits in branches/safari-4-branch
Versioning.
- 1:46 PM Changeset in webkit [54017] by
-
- 1 copy in tags/Safari-6531.22.2
New tag.
- 1:44 PM Changeset in webkit [54016] by
-
- 19 edits in trunk/WebCore
2010-01-28 Dimitri Glazkov <Dimitri Glazkov>
No review, rolling out r54012.
http://trac.webkit.org/changeset/54012
https://bugs.webkit.org/show_bug.cgi?id=34266
Introduced 33 crashes in V8 traversal/ tests.
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState):
- bindings/js/ScriptController.h:
- bindings/js/ScriptState.cpp:
- bindings/js/ScriptState.h:
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState): (WebCore::ScriptController::currentScriptState): (WebCore::ScriptController::clearWindowShell):
- bindings/v8/ScriptController.h:
- bindings/v8/ScriptScope.cpp: (WebCore::ScriptScope::ScriptScope): (WebCore::ScriptScope::success):
- bindings/v8/ScriptScope.h:
- bindings/v8/ScriptState.cpp: (WebCore::ScriptState::ScriptState): (WebCore::scriptStateFromPage):
- bindings/v8/ScriptState.h: (WebCore::ScriptState::ScriptState): (WebCore::ScriptState::frame):
- bindings/v8/V8HiddenPropertyName.h:
- bindings/v8/V8IsolatedContext.cpp: (WebCore::V8IsolatedContext::scriptState):
- bindings/v8/V8IsolatedContext.h:
- bindings/v8/V8Utilities.cpp: (WebCore::getScriptExecutionContext): (WebCore::reportException):
- bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::V8NodeIterator::nextNodeCallback): (WebCore::V8NodeIterator::previousNodeCallback):
- bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::V8TreeWalker::parentNodeCallback): (WebCore::V8TreeWalker::firstChildCallback): (WebCore::V8TreeWalker::lastChildCallback): (WebCore::V8TreeWalker::nextNodeCallback): (WebCore::V8TreeWalker::previousNodeCallback): (WebCore::V8TreeWalker::nextSiblingCallback): (WebCore::V8TreeWalker::previousSiblingCallback):
- inspector/InspectorController.cpp: (WebCore::InspectorController::injectedScriptForNodeId):
- 1:36 PM Changeset in webkit [54015] by
-
- 12 edits in trunk
Reapply 54008: Expand the NotificationPresenter::checkPermission() interface
to send the full URL of the requesting context, as well as a pointer to the
document if that context was a document.
- 1:34 PM Changeset in webkit [54014] by
-
- 4 edits in trunk/WebCore
2010-01-28 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Fix missing forward-declarations and includes in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=34272
No new tests, build fix only.
- bindings/v8/ScriptController.h: Modified. Forward-declare NPObject
- bindings/v8/V8DOMWindowShell.cpp: Modified. Include CString.h and PlatformBridge.h
- bindings/v8/V8DOMWrapper.h: Modified. Forward-declare V8Proxy
- 1:24 PM Changeset in webkit [54013] by
-
- 3 edits in trunk/LayoutTests
2010-01-28 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, trivial baseline update.
Update baseline for "Animated scaling of background-image is too slow"
https://bugs.webkit.org/show_bug.cgi?id=33808
- platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum:
- platform/mac/fast/backgrounds/size/backgroundSize16-expected.png:
- 1:05 PM Changeset in webkit [54012] by
-
- 19 edits in trunk/WebCore
2010-01-28 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Adam Barth.
Remove ScriptState::frame which is only used for reporting exceptions
in some cases in a way that diverges from the regular exception reporting in
v8 bindings.
Cache ScriptState directly on v8::Context instead of providing
implementations specific for isolated worlds and ScriptController.
- bindings/js/ScriptController.cpp:
- bindings/js/ScriptController.h:
- bindings/js/ScriptState.cpp: (WebCore::mainWorldScriptState):
- bindings/js/ScriptState.h:
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell):
- bindings/v8/ScriptController.h:
- bindings/v8/ScriptScope.cpp: (WebCore::ScriptScope::ScriptScope): (WebCore::ScriptScope::success):
- bindings/v8/ScriptScope.h:
- bindings/v8/ScriptState.cpp: (WebCore::ScriptState::ScriptState): (WebCore::ScriptState::forContext): (WebCore::ScriptState::current): (WebCore::ScriptState::empty): (WebCore::ScriptState::weakReferenceCallback): (WebCore::mainWorldScriptState): (WebCore::scriptStateFromPage):
- bindings/v8/ScriptState.h:
- bindings/v8/V8HiddenPropertyName.h:
- bindings/v8/V8IsolatedContext.cpp:
- bindings/v8/V8IsolatedContext.h:
- bindings/v8/V8Utilities.cpp: (WebCore::getScriptExecutionContext): (WebCore::reportException):
- bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::V8NodeIterator::nextNodeCallback): (WebCore::V8NodeIterator::previousNodeCallback):
- bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::V8TreeWalker::parentNodeCallback): (WebCore::V8TreeWalker::firstChildCallback): (WebCore::V8TreeWalker::lastChildCallback): (WebCore::V8TreeWalker::nextNodeCallback): (WebCore::V8TreeWalker::previousNodeCallback): (WebCore::V8TreeWalker::nextSiblingCallback): (WebCore::V8TreeWalker::previousSiblingCallback):
- inspector/InspectorController.cpp: (WebCore::InspectorController::injectedScriptForNodeId):
- 12:38 PM Changeset in webkit [54011] by
-
- 12 edits in trunk
revert
- 12:34 PM Changeset in webkit [54010] by
-
- 3 edits3 adds in trunk
2010-01-28 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Remove XSSAuditor false positive for Google Translate
https://bugs.webkit.org/show_bug.cgi?id=34242
Add a test that we allow attackers to inject directly into the href
property of the base tag.
- http/tests/security/xssAuditor/base-href-direct-expected.txt: Added.
- http/tests/security/xssAuditor/base-href-direct.html: Added.
- http/tests/security/xssAuditor/resources/echo-head-base-href-direct.pl: Added.
2010-01-28 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
Remove XSSAuditor false positive for Google Translate
https://bugs.webkit.org/show_bug.cgi?id=34242
Google translate takes a base URL as a parameter, causing a false
positive in the XSS filter. This patch removes the false positive by
allowing direct injections into the href property of the base tag.
Test: http/tests/security/xssAuditor/base-href-direct.html
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canSetBaseElementURL):
- 12:27 PM Changeset in webkit [54009] by
-
- 17 edits1 add in trunk/WebCore
2010-01-28 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Save additional memory in SVG*Element classes, by introducing SVGElementRareData
https://bugs.webkit.org/show_bug.cgi?id=34268
Introduce SVGElementRareData, to remove the need to store any members in SVGElement/SVGStyledElement.
This saves some additional MB for the svg-node-count-vs-scroll.xhtml testcase.
SVGElementRareData works just like NodeRareData. Unlike ElementRareData, we're not inheriting from
NodeRareData in SVG, as we don't need all the rare data stored there, unlike Element.
- GNUmakefile.am: Add SVGElementRareData.h to build.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- dom/Node.cpp: Use Nodes bitfield to keep track wheter a SVGElement has a SVGElementRareData object associated. (WebCore::Node::Node):
- dom/Node.h: Add m_hasRareSVGData flag, merged with the existing bitfield, 10 bits remaining now. (WebCore::Node::hasRareSVGData):
- svg/SVGAnimateMotionElement.cpp: SVGElement::instancesForElement() now returns a const-reference to the HashMap instead of copying. (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
- svg/SVGAnimateTransformElement.cpp: Ditto. (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
- svg/SVGAnimationElement.cpp: Ditto. (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
- svg/SVGElement.cpp: Move the element instances HashSet and two cursor-related pointers into SVGElementRareData. (WebCore::SVGElement::SVGElement): (WebCore::SVGElement::~SVGElement): (WebCore::SVGElement::rareSVGData): Modelled just like Node::rareData(). (WebCore::SVGElement::ensureRareSVGData): Dito. (WebCore::SVGElement::accessDocumentSVGExtensions): (WebCore::SVGElement::mapInstanceToElement): Route call through SVGElementRareData. (WebCore::SVGElement::removeInstanceMapping): Ditto. (WebCore::SVGElement::instancesForElement): Ditto. (WebCore::SVGElement::setCursorElement): Ditto. (WebCore::SVGElement::setCursorImageValue): Ditto.
- svg/SVGElement.h:
- svg/SVGElementInstance.cpp: Ditto. (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
- svg/SVGElementRareData.h: Added. Based on NodeRareData - works exactly the same. (WebCore::SVGElementRareData::SVGElementRareData): (WebCore::SVGElementRareData::rareDataMap): (WebCore::SVGElementRareData::rareDataFromMap): (WebCore::SVGElementRareData::elementInstances): (WebCore::SVGElementRareData::instanceUpdatesBlocked): (WebCore::SVGElementRareData::setInstanceUpdatesBlocked): (WebCore::SVGElementRareData::cursorElement): (WebCore::SVGElementRareData::setCursorElement): (WebCore::SVGElementRareData::cursorImageValue): (WebCore::SVGElementRareData::setCursorImageValue):
- svg/SVGStyledElement.cpp: Move m_instancesUpdatesBlocked into SVGElementRareData. (WebCore::SVGStyledElement::SVGStyledElement): (WebCore::SVGStyledElement::instanceUpdatesBlocked): (WebCore::SVGStyledElement::setInstanceUpdatesBlocked):
- svg/SVGStyledElement.h:
- svg/SVGUseElement.cpp: Adapt to element instances changes, now passed as const-reference. (WebCore::dumpInstanceTree):
- 11:24 AM Changeset in webkit [54008] by
-
- 13 edits in trunk
2010-01-28 Aaron Boodman <aa@chromium.org>
Reviewed by Darin Adler.
Expand the NotificationPresenter::checkPermission() interface to send the full
URL of the requesting context, as well as a pointer to the document if that
context was a document.
- notifications/Notification.cpp: (WebCore::Notification::Notification):
- notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::NotificationCenter): (WebCore::NotificationCenter::checkPermission): Pass the full URL and document from the requesting context when calling NotificationPresenter::checkPermission().
- notifications/NotificationPresenter.h: (WebCore::NotificationPresenter::): Expand interface.
2010-01-27 Aaron Boodman <aa@chromium.org>
Reviewed by Darin Adler.
Send full URL and application id of requesting context to Chromium
when checking notification permissions.
- public/WebDocument.h:
- src/WebDocument.cpp: (WebKit::WebDocument::applicationID): Implement applicationID() method.
- public/WebNotificationPresenter.h:
- src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission):
- src/NotificationPresenterImpl.h: Send applicationID and full URL through to Chromium.
2010-01-27 Aaron Boodman <aa@chromium.org>
Expand NotificationCenter::checkPermission() interface.
It now passes the full URL instead of just the origin.
- WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::checkPermission):
- WebCoreSupport/WebDesktopNotificationsDelegate.h:
- 10:34 AM Changeset in webkit [54007] by
-
- 2 edits in trunk/LayoutTests/fast/dom/Window
Unreviewed, trivial expectations update.
- 10:08 AM QtWebKitBackportingFixes edited by
- (diff)
- 10:07 AM Changeset in webkit [54006] by
-
- 6 edits4 adds in trunk
2010-01-28 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Video can overlap position:fixed element when scrolling
https://bugs.webkit.org/show_bug.cgi?id=32180
When the scroll position changes, and we're using overlap to decide what gets composited,
then we need to re-evaluate what gets compositing when scrolling in case fixed postion elements
overlap composited elements (e.g. video).
Test: compositing/geometry/video-fixed-scrolling.html
- page/FrameView.cpp: (WebCore::FrameView::updateCompositingLayers): (WebCore::FrameView::scrollPositionChanged): Annotate the calls to updateCompositingLayers() with the type of change that occurred.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded): Ditto.
- rendering/RenderLayerCompositor.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers): For scroll changes, check for hierarchy update if m_compositingConsultsOverlap is true, and do a geometry update. For other changes, always check for hierarchy updates.
- 9:47 AM Changeset in webkit [54005] by
-
- 7 edits2 adds in trunk
Fix for user stylesheet bugs where they get parsed using the wrong compatibility mode. This was a regression
caused from Safari 3 -> 4 by the Acid3 fixes to create a real DOCTYPE in the DOM.
Reviewed by Darin Adler.
This patch makes style selector creation lazy, so that the selector isn't built unless someone asks for it.
In order to avoid creating the style selector before the compatibility mode has been determined, document
style is now created without having a dependence on an instantiated style selector. The creation of the style
is now done as a static method on CSSStyleSelector called styleForDocument, and a couple of font-related
functions have been made static as well so that they can be used by this method.
m_styleSelector on Document is now an OwnPtr.
Added userscripts/mixed-case-stylesheet.html
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForDocument):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::checkForGenericFamilyChange):
(WebCore::CSSStyleSelector::setFontSize):
(WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
(WebCore::CSSStyleSelector::fontSizeForKeyword):
- css/CSSStyleSelector.h:
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::createStyleSelector):
(WebCore::Document::attach):
(WebCore::Document::setVisuallyOrdered):
(WebCore::Document::recalcStyleSelector):
- dom/Document.h:
(WebCore::Document::styleSelector):
(WebCore::Document::visuallyOrdered):
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::determineParseMode):
- loader/PlaceholderDocument.cpp:
(WebCore::PlaceholderDocument::attach):
- 9:03 AM Changeset in webkit [54004] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-01-28 Anton Muhin <antonm@google.com>
Reviewed by Alexey Proskuryakov.
Add layout tests to verify assignment to items of NodeList
https://bugs.webkit.org/show_bug.cgi?id=34213
- fast/dom/NodeList/nodelist-item-assignment-expected.txt: Added.
- fast/dom/NodeList/nodelist-item-assignment.html: Added.
- 8:47 AM Changeset in webkit [54003] by
-
- 9 edits2 moves in trunk/WebCore
2010-01-28 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Rename ISODateTime.{cpp,h} to DateComponents.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=34245
No functional changes.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/DateComponents.cpp: Copied from WebCore/html/ISODateTime.cpp. (WebCore::DateComponents::maxWeekNumberInYear): (WebCore::DateComponents::parseYear): (WebCore::DateComponents::addDay): (WebCore::DateComponents::addMinute): (WebCore::DateComponents::parseTimeZone): (WebCore::DateComponents::parseMonth): (WebCore::DateComponents::parseDate): (WebCore::DateComponents::parseWeek): (WebCore::DateComponents::parseTime): (WebCore::DateComponents::parseDateTimeLocal): (WebCore::DateComponents::parseDateTime): (WebCore::DateComponents::setMillisecondsSinceMidnightInternal): (WebCore::DateComponents::setMillisecondsSinceEpochForDateInternal): (WebCore::DateComponents::setMillisecondsSinceEpochForDate): (WebCore::DateComponents::setMillisecondsSinceEpochForDateTime): (WebCore::DateComponents::setMillisecondsSinceEpochForDateTimeLocal): (WebCore::DateComponents::setMillisecondsSinceEpochForMonth): (WebCore::DateComponents::setMillisecondsSinceMidnight): (WebCore::DateComponents::setMillisecondsSinceEpochForWeek): (WebCore::DateComponents::millisecondsSinceEpochForTime): (WebCore::DateComponents::millisecondsSinceEpoch): (WebCore::DateComponents::toStringForTime): (WebCore::DateComponents::toString):
- html/DateComponents.h: Copied from WebCore/html/ISODateTime.h. (WebCore::DateComponents::DateComponents):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseToDouble): (WebCore::HTMLInputElement::valueAsDate): (WebCore::HTMLInputElement::setValueAsDate): (WebCore::HTMLInputElement::setValueAsNumber): (WebCore::HTMLInputElement::formStringToDateComponents):
- html/HTMLInputElement.h:
- html/ISODateTime.cpp: Removed.
- html/ISODateTime.h: Removed.
- html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch):
- 8:44 AM Changeset in webkit [54002] by
-
- 5 edits in trunk/WebKitTools
[Qt] Unreviewed, roll out r54000.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::reset):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController::display):
- 8:28 AM Changeset in webkit [54001] by
-
- 9 edits in trunk/WebCore
2010-01-28 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Use platform-specific monospace fonts in the Web Inspector
Move the OS version detection code into the frontend,
add custom CSS monospace styles for known platforms.
https://bugs.webkit.org/show_bug.cgi?id=34040
- inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::platform):
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
- inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView):
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.releaseWrapperObjectGroup): (.WebInspector.InspectorBackendStub.prototype.setInjectedScriptSource):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createConditionElement):
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.URLRegExp.i.get platform): (WebInspector._detectPlatform):
- 6:41 AM Changeset in webkit [54000] by
-
- 5 edits in trunk/WebKitTools
2010-01-28 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement the display() method of the layout test controller
https://bugs.webkit.org/show_bug.cgi?id=34258
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::showPage): (WebCore::DumpRenderTree::hidePage):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::display):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 5:39 AM Changeset in webkit [53999] by
-
- 2 edits in trunk/WebKit/qt
Do not set the combobox font on Maemo5 and S60; use the
default instead.
Reviewed by Simon Hausmann.
- WebCoreSupport/QtFallbackWebPopup.cpp:
(WebCore::QtFallbackWebPopup::populate):
- 5:22 AM Changeset in webkit [53998] by
-
- 3 edits in trunk/WebKitTools
Eliminated the filename parameter from functions in
check-webkit-style's cpp.py where it is no longer used.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=34249
- Scripts/webkitpy/style/processors/cpp.py:
- Reduced number of occurrences of "filename" variable from approximately 200 to 120.
- Scripts/webkitpy/style/processors/cpp_unittest.py:
- Refactored unit tests as necessary to accommodate changes to cpp.py.
- Fixed bug in CppStyleTestBase.perform_include_what_you_use() where the incorrect file extension was getting passed to cpp_style.check_language().
- 5:06 AM Changeset in webkit [53997] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Fix for endless print loop when printing web pages
Patch by Trond Kjernåsen <trond@trolltech.com> on 2010-01-28
Reviewed by Simon Hausmann.
- Api/qwebframe.cpp:
(QWebFrame::print):
- 4:34 AM Changeset in webkit [53996] by
-
- 4 edits in trunk/WebCore
2010-01-28 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Simplify views logic in Profiler panel, and fix the problem described in the issue.
Remove image from Welcome view.
Preserve border on status bar-like buttons in Welcome view on window deactivation.
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.show): (WebInspector.ProfilesPanel.prototype.reset): (WebInspector.ProfilesPanel.prototype.addProfileHeader): (WebInspector.ProfilesPanel.prototype.showView): (WebInspector.ProfilesPanel.prototype._updateInterface):
- inspector/front-end/WelcomeView.js: (WebInspector.WelcomeView):
- inspector/front-end/inspector.css:
- 3:54 AM Changeset in webkit [53995] by
-
- 2 edits in trunk/WebCore
[Qt] Speed up KURL to QUrl conversion
https://bugs.webkit.org/show_bug.cgi?id=33873
The WebCore::String::utf8 method will use the generic WebCore::TextCodec
and then call the encode method on it. In QtWebKit this class is implemented
around the QTextCodec class. Instead of going the generic codec way we treat
the WebCore::String as a QString (no copying) and then use the built-in
QString::toUtf8 to do the conversion.
- 3:00 AM Changeset in webkit [53994] by
-
- 12 edits in trunk
[Android] [Qt] Touch event page co-ordinates are incorrect when touch is received in an iframe.
https://bugs.webkit.org/show_bug.cgi?id=34162
Reviewed by Simon Hausmann.
WebCore:
The pageX/pageY co-ordinates of a touch event should be relative to the containing frame, not the main frame. This change implements that and also updates the existing touch-inside-iframe test to also examine the page co-ordinates.
- dom/Touch.cpp:
(WebCore::Touch::Touch): Remove dead code.
- dom/Touch.h: Remove dead code.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent): Rename framePoint to pagePoint, as it seems a clearer name. Also adjust the pagePoint to be relative to the touch target element's containing frame rather than the main frame.
- platform/PlatformTouchEvent.h: Rename Android specific constructor parameter to better reflect it's contents.
- platform/PlatformTouchPoint.h: Ditto.
- platform/android/PlatformTouchEventAndroid.cpp: Ditto.
- platform/android/PlatformTouchPointAndroid.cpp: Ditto.
LayoutTests:
Update the existing iframe touch event test to also examine the page co-ordinates of the touch that is received.
- fast/events/touch/resources/touch-inside-iframe2.html:
- fast/events/touch/touch-inside-iframe-expected.txt:
- fast/events/touch/touch-inside-iframe.html:
- 2:46 AM Changeset in webkit [53993] by
-
- 2 edits in trunk/WebCore
2010-01-28 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Simplify isActivation method.
Test: WebCore/manual-tests/inspector/debugger-scopes-inspection.html
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::isActivation):
- 1:20 AM Changeset in webkit [53992] by
-
- 2 edits in trunk/LayoutTests
2010-01-28 Xan Lopez <xlopez@igalia.com>
[GTK] Can DnD files to our filechooser widget (<input type="file">)
https://bugs.webkit.org/show_bug.cgi?id=34246
Skip failing test because of this missing feature.
- platform/gtk/Skipped:
- 1:10 AM Changeset in webkit [53991] by
-
- 9 edits1 delete in trunk/LayoutTests
2010-01-28 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
Remove tests for dates later than 275760-09-13T00:00Z.
https://bugs.webkit.org/show_bug.cgi?id=34240
Date.UTC() of V8 doesn't support such dates though Date.UTC() of
JavaScriptCore does.
- fast/forms/input-valueasnumber-date-expected.txt:
- fast/forms/input-valueasnumber-datetime-expected.txt:
- fast/forms/input-valueasnumber-datetimelocal-expected.txt:
- fast/forms/input-valueasnumber-month-expected.txt:
- fast/forms/script-tests/input-valueasnumber-date.js:
- fast/forms/script-tests/input-valueasnumber-datetime.js:
- fast/forms/script-tests/input-valueasnumber-datetimelocal.js:
- fast/forms/script-tests/input-valueasnumber-month.js:
- platform/win/fast/forms/input-valueasnumber-datetime-expected.txt: Removed.
- 12:45 AM Changeset in webkit [53990] by
-
- 5 edits in trunk/WebKitTools
2010-01-28 Chris Jerdonek <Chris Jerdonek>
Reviewed by Shinichiro Hamaji.
In check-webkit-style, eliminated the dependency of
processors/cpp_unittest.py on checker.py.
- Scripts/webkitpy/style/checker.py:
- Addressed FIXME by removing STYLE_CATEGORIES data.
- Added style_categories().
- Scripts/webkitpy/style/checker_unittest.py:
- Minor changes.
- Scripts/webkitpy/style/processors/cpp.py:
- Added categories attribute to CppProcessor class (data was originally checker.STYLE_CATEGORIES).
- Scripts/webkitpy/style/processors/cpp_unittest.py:
- Addressed FIXME by eliminating "import" from checker.py.
- 12:29 AM Changeset in webkit [53989] by
-
- 3 edits in trunk/WebKitTools
2010-01-28 Anton Muhin <antonm@chromium.org>
Reviewed by Shinichiro Hamaji.
Improve treatment of conditions and rest of the line for if, else, switch and alikes
https://bugs.webkit.org/show_bug.cgi?id=34173
- Scripts/webkitpy/style/cpp_style.py:
- Scripts/webkitpy/style/cpp_style_unittest.py:
- 12:14 AM Changeset in webkit [53988] by
-
- 10 edits2 adds in branches/safari-4-branch
Merge r53567.
- 12:14 AM Changeset in webkit [53987] by
-
- 5 edits2 adds in branches/safari-4-branch
Merge r53368.
- 12:14 AM Changeset in webkit [53986] by
-
- 30 edits1 copy7 adds in branches/safari-4-branch
Merge r53512.
- 12:13 AM Changeset in webkit [53985] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r53369.
- 12:13 AM Changeset in webkit [53984] by
-
- 10 edits2 adds in branches/safari-4-branch
Merge r53220.
- 12:13 AM Changeset in webkit [53983] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r53163.
- 12:13 AM Changeset in webkit [53982] by
-
- 6 edits2 adds in branches/safari-4-branch
Merge r52351.
- 12:13 AM Changeset in webkit [53981] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r52781.
- 12:13 AM Changeset in webkit [53980] by
-
- 14 edits2 adds in branches/safari-4-branch
Merge r52773.
- 12:13 AM Changeset in webkit [53979] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r52352.
- 12:13 AM Changeset in webkit [53978] by
-
- 7 edits2 adds in branches/safari-4-branch
Merge r52233.
- 12:13 AM Changeset in webkit [53977] by
-
- 4 edits2 adds in branches/safari-4-branch
Merge r50196.
- 12:12 AM Changeset in webkit [53976] by
-
- 2 edits in trunk/WebKitTools
2010-01-28 Joe Mason <jmason@rim.com>
Reviewed by Adam Barth.
Limit login retries to 5
https://bugs.webkit.org/show_bug.cgi?id=34193
- Scripts/webkitpy/bugzilla.py:
Jan 27, 2010:
- 11:29 PM Changeset in webkit [53975] by
-
- 4 edits6 adds in trunk
2010-01-27 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
rangeOverflow/rangeUnderflow support for type=date
https://bugs.webkit.org/show_bug.cgi?id=34209
- fast/forms/ValidityState-rangeOverflow-date-expected.txt: Added.
- fast/forms/ValidityState-rangeOverflow-date.html: Added.
- fast/forms/ValidityState-rangeUnderflow-date-expected.txt: Added.
- fast/forms/ValidityState-rangeUnderflow-date.html: Added.
- fast/forms/script-tests/ValidityState-rangeOverflow-date.js: Added.
- fast/forms/script-tests/ValidityState-rangeUnderflow-date.js: Added.
2010-01-27 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
rangeOverflow/rangeUnderflow support for type=date
https://bugs.webkit.org/show_bug.cgi?id=34209
Add DATE type support to rangeUnderflow(), rangeOverflow(),
minimum(), and maximum() of HTMLInputElement.
In order to unify parsing code for value, min, and max strings,
introduce parseToDouble() function and it is called by
valueAsDate() and valueAsNumber() too.
Tests: fast/forms/ValidityState-rangeOverflow-date.html
fast/forms/ValidityState-rangeUnderflow-date.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::rangeUnderflow): Support DATE type, and use parseToDouble(). (WebCore::HTMLInputElement::rangeOverflow): ditto. (WebCore::HTMLInputElement::minimum): ditto. (WebCore::HTMLInputElement::maximum): ditto. (WebCore::HTMLInputElement::doubleValueFor): Added. (WebCore::HTMLInputElement::valueAsDate): Use parseToDouble(). (WebCore::HTMLInputElement::valueAsNumber): Use parseToDouble().
- html/HTMLInputElement.h: Declare parseToDouble().
- 11:27 PM Changeset in webkit [53974] by
-
- 2 edits in trunk/WebCore
2010-01-27 Darin Fisher <darin@chromium.org>
Fix chromium build bustage (take 2).
- bindings/scripts/CodeGeneratorV8.pm: Really treat V8CustomGetter like CustomGetter in all cases.
- 11:18 PM Changeset in webkit [53973] by
-
- 2 edits in trunk/LayoutTests
[Qt] Skip test introduced in r53972 because of missing eventSender.beginDragWithFiles()
- platform/qt/Skipped: fast/dom/Window/window-postmessage-clone-frames.html skipped.
- 10:50 PM Changeset in webkit [53972] by
-
- 2 edits in trunk/WebCore
2010-01-27 Darin Fisher <darin@chromium.org>
Fix chromium build bustage.
- bindings/scripts/CodeGeneratorV8.pm: Treat V8CustomGetter like CustomGetter in all cases.
- 10:36 PM Changeset in webkit [53971] by
-
- 3 edits in trunk/WebKit/chromium
2010-01-27 Darin Fisher <darin@chromium.org>
Reviewed by Pavel Feldman.
Expose HistoryItem::documentSequenceNumber
https://bugs.webkit.org/show_bug.cgi?id=34243
- public/WebHistoryItem.h:
- src/WebHistoryItem.cpp: (WebKit::WebHistoryItem::documentSequenceNumber): (WebKit::WebHistoryItem::setDocumentSequenceNumber):
- 9:26 PM Changeset in webkit [53970] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- 8:47 PM Changeset in webkit [53969] by
-
- 12 edits3 adds in trunk
2010-01-27 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
MessageEvent.data should deserialize in the context of the MessageEvent's global object
https://bugs.webkit.org/show_bug.cgi?id=34227
Add logic to allow us to create an Object, Array, or Date instance
so we can create them in the context of a specific global object,
rather than just using the current lexical global object.
- JavaScriptCore.exp:
- runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance):
- runtime/DateInstance.h:
- runtime/JSGlobalObject.h: (JSC::constructEmptyObject): (JSC::constructEmptyArray):
2010-01-27 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
MessageEvent.data should deserialize in the context of the MessageEvent's global object
https://bugs.webkit.org/show_bug.cgi?id=34227
Test that the object returned from postMessage.data is created in the correct context
- fast/dom/Window/resources/window-postmessage-clone-frames-frame.html: Added.
- fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added.
- fast/dom/Window/window-postmessage-clone-frames.html: Added.
2010-01-27 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
MessageEvent.data should deserialize in the context of the MessageEvent's global object
https://bugs.webkit.org/show_bug.cgi?id=34227
Make ScriptValue deserialisation support the provision of a specific global
object to use when creating new objects. This then allows us to make
MessageEvent.data and PopStateEvent.state deserialize in the correct
context.
Test: fast/dom/Window/window-postmessage-clone-frames.html
- bindings/js/JSPopStateEventCustom.cpp: Remove custom implementation of state getter
- bindings/js/SerializedScriptValue.cpp: (WebCore::DeserializingTreeWalker::DeserializingTreeWalker): (WebCore::DeserializingTreeWalker::createOutputArray): (WebCore::DeserializingTreeWalker::createOutputObject): (WebCore::DeserializingTreeWalker::convertIfTerminal): (WebCore::SerializedScriptValueData::deserialize): (WebCore::SerializedScriptValue::deserialize):
- bindings/js/SerializedScriptValue.h: (WebCore::SerializedScriptValue::deserialize):
- bindings/scripts/CodeGeneratorJS.pm: Update bindings generation to pass the correct global object, and to treat "any" as synonymous with SerializedValue.
- dom/PopStateEvent.idl:
- 7:24 PM Changeset in webkit [53968] by
-
- 2 edits in trunk/WebKitTools
Adding myself to the committer list. No review necessary.
- Scripts/webkitpy/committers.py:
- 7:22 PM Changeset in webkit [53967] by
-
- 2 edits in trunk/WebKit/gtk
2010-01-27 Martin Robinson <Martin Robinson>
Reviewed by Gustavo Noronha Silva.
[GTK] Expose the IM context via the API
https://bugs.webkit.org/show_bug.cgi?id=33327
Expose the GtkIMMultiContext as a property of WebKitWebView. This will
allow embedders to generate the input method context menu entries and
make testing certain IM context behavior possible.
- webkit/webkitwebview.cpp: (webkit_web_view_get_property): (DNDContentsRequest::webkit_web_view_get_im_context): (DNDContentsRequest::webkit_web_view_class_init):
- 6:55 PM Changeset in webkit [53966] by
-
- 3 edits in trunk/WebCore
2010-01-27 Nicholas Young <nicholas.young@nokia.com>
Reviewed by Eric Carlson.
Make media controls fade in/out transition duration configurable on a theme level.
https://bugs.webkit.org/show_bug.cgi?id=34196
No new tests needed (I hope).
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): Removed constant from contructor - the initial value is meaningless. (WebCore::RenderMedia::updateControlVisibility): Get fade in/out duration from theme.
- rendering/RenderTheme.h: (WebCore::RenderTheme::mediaControlsFadeInDuration): New virtual method. (WebCore::RenderTheme::mediaControlsFadeOutDuration): New virtual method.
- 5:41 PM Changeset in webkit [53965] by
-
- 7 edits1 copy2 moves1 add in trunk
2010-01-27 John Abd-El-Malek <jam@chromium.org>
Reviewed by Dimitri Glazkov.
Tests that when a page removes an iframe that sleeps in its unload handler and
terminates its JS execution, the outer page's JS continues running.
- fast/dom/Window/slow-unload-handler-expected.txt: Copied from LayoutTests/fast/dom/Window/slow_unload_handler-expected.txt.
- fast/dom/Window/slow-unload-handler-only-frame-is-stopped.html: Added.
- fast/dom/Window/slow-unload-handler-only-frame-is-stopped-expected.txt: Added.
- fast/dom/Window/slow-unload-handler.html: Copied from LayoutTests/fast/dom/Window/slow_unload_handler.html.
- fast/dom/Window/slow_unload_handler-expected.txt: Removed.
- fast/dom/Window/slow_unload_handler.html: Removed.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
2010-01-27 John Abd-El-Malek <jam@chromium.org>
Reviewed by Dimitri Glazkov.
Tests that when a page removes an iframe that sleeps in its unload handler and
terminates its JS execution, the outer page's JS continues running.
Tests: fast/dom/Window/slow-unload-handler-only-frame-is-stopped.html
fast/dom/Window/slow-unload-handler.html
- bindings/v8/DateExtension.cpp: (WebCore::DateExtension::OnSleepDetected):
- 5:24 PM Changeset in webkit [53964] by
-
- 5 edits3 adds in trunk
2010-01-27 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Add valueAsNumber support for type=datetime-local.
https://bugs.webkit.org/show_bug.cgi?id=34200
The test data is equivalent to input-valueasnumber-datetime.html.
The expectation contains two FAIL lines because they check
unimplemented features.
- fast/forms/input-valueasnumber-datetimelocal-expected.txt: Added.
- fast/forms/input-valueasnumber-datetimelocal.html: Added.
- fast/forms/script-tests/input-valueasnumber-datetimelocal.js: Added.
2010-01-27 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Add valueAsNumber support for type=datetime-local.
https://bugs.webkit.org/show_bug.cgi?id=34200
Implement necessary methods of ISODateTime, and call them from
HTMLInputElement.
Test: fast/forms/input-valueasnumber-datetimelocal.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsNumber): (WebCore::HTMLInputElement::setValueAsNumber):
- html/ISODateTime.cpp: (WebCore::ISODateTime::setMillisecondsSinceEpochForDateTimeLocal): Implemented. Just call setMillisecondsSinceEpochForDateTime(). (WebCore::ISODateTime::millisecondsSinceEpochForTime): Accept to be called for m_type=DateTimeLocal. (WebCore::ISODateTime::toString): Add DateTimeLocal support.
- html/ISODateTime.h: Declare new methods.
- 5:11 PM Changeset in webkit [53963] by
-
- 2 edits1 add in branches/safari-4-branch/WebCore
Merge r53867.
- 5:05 PM Changeset in webkit [53962] by
-
- 2 edits in trunk/WebKitTools
2010-01-27 George Wright <gwright@rim.com>
Reviewed by Adam Treat.
Add missing include for wtf/Platform.h
- DumpRenderTree/AccessibilityController.h:
- 4:46 PM Changeset in webkit [53961] by
-
- 3 edits in trunk/WebCore
Windows Debug_All build fix.
- platform/graphics/win/WKCACFLayer.cpp:
- platform/graphics/win/WKCACFLayerRenderer.cpp:
- 4:28 PM Changeset in webkit [53960] by
-
- 3 edits in trunk/WebKit/win
Make it possible to instantiate WebSerializedJSValue using WebKitCreateInstance
Reviewed by Dave Hyatt.
- ForEachCoClass.h:
- WebKitClassFactory.cpp:
Added WebSerializedJSValue.
- 4:23 PM Changeset in webkit [53959] by
-
- 1 edit2 adds in trunk/LayoutTests
Rubber-stamped by Adam Roben.
Add platform specific failing Windows results for two recently
added tests. I will comment on their originating bugs saying that
failing results were landed for Windows.
<https://bugs.webkit.org/show_bug.cgi?id=29564>
<https://bugs.webkit.org/show_bug.cgi?id=32696>
- platform/win/fast/css/button-height-expected.txt: Added.
- platform/win/fast/forms/input-valueasnumber-datetime-expected.txt: Added.
- 4:16 PM Changeset in webkit [53958] by
-
- 3 edits in trunk/WebCore
2010-01-27 Evan Martin <evan@chromium.org>
Reviewed by David Levin.
[chromium] complex text draws newlines as bells
https://bugs.webkit.org/show_bug.cgi?id=34186
Revert r45496 -- once we've got a glyph array, it is too late to normalize
because we could have had multiple codepoints combine into one glyph. The
Uniscribe code it mentions it's duplicating uses the log cluster map to fix
this.
Instead, we just normalize the input text if it contains any non-ascii-space
whitespace.
This fixes fast/text/international/hindi-whitespace, which currently has an
incorrect baseline containing a square box glyph.
- platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::getTextRun): (WebCore::TextRunWalker::getNormalizedTextRun):
- platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::stringToGlyphs):
- 3:41 PM Changeset in webkit [53957] by
-
- 20 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=34150
WebKit needs a mechanism to catch stale HashMap entries
It is very difficult to catch stale pointers that are HashMap keys - since a pointer's hash
is just its value, it is very unlikely that any observable problem is reproducible.
This extends hash table consistency checks to check that pointers are referencing allocated
memory blocks, and makes it possible to invoke the checks explicitly (it is not feasible
to enable CHECK_HASHTABLE_CONSISTENCY by default, because that affects performance too much).
- wtf/HashMap.h: (WTF::::checkConsistency): Call through to HashTable implementation. We can add similar calls to HashSet and HashCountedSet, but I haven't seen hard to debug problems with those yet.
- wtf/HashSet.h: (WTF::::remove): The version of checkTableConsistency that's guarded by CHECK_HASHTABLE_CONSISTENCY is now called internalCheckTableConsistency().
- wtf/HashTable.h: (WTF::HashTable::internalCheckTableConsistency): (WTF::HashTable::internalCheckTableConsistencyExceptSize): (WTF::HashTable::checkTableConsistencyExceptSize): Expose checkTableConsistency() even if CHECK_HASHTABLE_CONSISTENCY is off. (WTF::::add): Updated for checkTableConsistency renaming. (WTF::::addPassingHashCode): Ditto. (WTF::::removeAndInvalidate): Ditto. (WTF::::remove): Ditto. (WTF::::rehash): Ditto. (WTF::::checkTableConsistency): The assertion for !shouldExpand() was not correct - this function returns true for tables with m_table == 0. (WTF::::checkTableConsistencyExceptSize): Call checkValueConsistency for key. Potentially, we could do the same for values.
- wtf/HashTraits.h: (WTF::GenericHashTraits::checkValueConsistency): An empty function that can be overridden to add checks. Currently, the only override is for pointer hashes.
- wtf/RefPtrHashMap.h: (WTF::::remove): Updated for checkTableConsistency renaming.
- 3:32 PM Changeset in webkit [53956] by
-
- 7 edits in trunk
2010-01-27 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT Provide worker thread ability to track counters
https://bugs.webkit.org/show_bug.cgi?id=34221
Implement workerThreadCount() in LayoutTestController of Qt DRT
Tests:
fast/workers/dedicated-worker-lifecycle.html
fast/workers/shared-worker-frame-lifecycle.html
fast/workers/shared-worker-lifecycle.html
fast/workers/worker-lifecycle.html
- platform/qt/Skipped:
2010-01-27 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT Provide worker thread ability to track counters
https://bugs.webkit.org/show_bug.cgi?id=34221
Implement workerThreadCount() in LayoutTestController of Qt DRT
Tests:
fast/workers/dedicated-worker-lifecycle.html
fast/workers/shared-worker-frame-lifecycle.html
fast/workers/shared-worker-lifecycle.html
fast/workers/worker-lifecycle.html
- Api/qwebpage.cpp: (qt_drt_workerThreadCount):
2010-01-27 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT Provide worker thread ability to track counters
https://bugs.webkit.org/show_bug.cgi?id=34221
Implement workerThreadCount() in LayoutTestController of Qt DRT
Tests:
fast/workers/dedicated-worker-lifecycle.html
fast/workers/shared-worker-frame-lifecycle.html
fast/workers/shared-worker-lifecycle.html
fast/workers/worker-lifecycle.html
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::workerThreadCount):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 3:16 PM Changeset in webkit [53955] by
-
- 4 edits in trunk/WebCore
2010-01-27 Brian Tarricone <brian@kakai.com>
Reviewed by Gustavo Noronha Silva.
[gtk] Add support for windowless NPAPI plugins
Much of this is a translation of how the Qt backend does this,
modified for Gtk.
No new tests; there is already a windowless test in the tree.
- plugins/PluginView.cpp: (WebCore::PluginView::handleEvent): (WebCore::PluginView::PluginView):
- plugins/PluginView.h:
- plugins/gtk/PluginViewGtk.cpp: (WebCore::getRootWindow): (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paint): (WebCore::PluginView::handleKeyboardEvent): (WebCore::inputEventState): (WebCore::PluginView::initXEvent): (WebCore::setXButtonEventSpecificFields): (WebCore::setXMotionEventSpecificFields): (WebCore::setXCrossingEventSpecificFields): (WebCore::PluginView::handleMouseEvent): (WebCore::PluginView::handleFocusInEvent): (WebCore::PluginView::handleFocusOutEvent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::setNPWindowIfNeeded): (WebCore::PluginView::getValueStatic): (WebCore::PluginView::invalidateRect): (WebCore::getPluginDisplay): (WebCore::plug_removed_cb): (WebCore::getVisualAndColormap): (WebCore::PluginView::platformStart): (WebCore::PluginView::platformDestroy):
- 2:59 PM Changeset in webkit [53954] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-27 Anton Muhin <antonm@chromium.org>
Reviewed by Darin Adler.
Remove trailing \ from inline function code
https://bugs.webkit.org/show_bug.cgi?id=34223
- assembler/ARMv7Assembler.h: (JSC::ARMThumbImmediate::countLeadingZerosPartial):
- 2:41 PM Changeset in webkit [53953] by
-
- 2 edits in trunk/WebCore
2010-01-27 Anton Muhin <antonm@chromium.org>
Reviewed by David Levin.
[v8] minor cosmetic fix in V8 bindings codegenerator
https://bugs.webkit.org/show_bug.cgi?id=34224
- bindings/scripts/CodeGeneratorV8.pm:
- 2:08 PM Changeset in webkit [53952] by
-
- 2 edits in trunk/WebKitTools
Rubberstamped by Simon Hausmann.
[Qt] QtLauncher refactoring:
Make the LauncherWindow depend less on the view, so that more
code can be shared in near future.
- QtLauncher/main.cpp:
(LauncherWindow::sendTouchEvent):
(LauncherWindow::loadFinished):
(LauncherWindow::zoomIn):
(LauncherWindow::zoomOut):
(LauncherWindow::resetZoom):
(LauncherWindow::toggleZoomTextOnly):
(LauncherWindow::dumpHtml):
(LauncherWindow::selectElements):
(LauncherWindow::setupUI):
- 1:36 PM Changeset in webkit [53951] by
-
- 2 edits in trunk/WebCore
2010-01-27 Darin Fisher <darin@chromium.org>
Fix Chromium build bustage.
- rendering/RenderBoxModelObject.cpp: Add wtf/CurrentTime.h include.
- 1:17 PM Changeset in webkit [53950] by
-
- 17 edits2 deletes in trunk
2010-01-26 Darin Fisher <darin@chromium.org>
Reviewed by Brady Eidson and David Levin.
Chains of history items representing same-document navigation need to
always remember that association
Replace HistoryItem's Document pointer with a DocumentSequenceNumber.
During session history traversal, if the current HistoryItem and the
target HistoryItem have the same DocumentSequenceNumber, then it means
that the current Document should remain.
NOTE: To support Chromium's serialization of HistoryItems, I generate
DocumentSequenceNumbers that are unique across application launches.
DocumentSequenceNumbers are generated using a counter initialized with
the time of day.
Test: fast/loader/stateobjects/document-destroyed-navigate-back.html
- dom/Document.cpp: (WebCore::Document::detach):
- dom/Document.h:
- history/BackForwardList.cpp: (WebCore::BackForwardList::pushStateItem):
- history/BackForwardListChromium.cpp: (WebCore::BackForwardList::pushStateItem):
- history/HistoryItem.cpp: (WebCore::generateDocumentSequenceNumber): (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::~HistoryItem): (WebCore::HistoryItem::setStateObject):
- history/HistoryItem.h: (WebCore::HistoryItem::setDocumentSequenceNumber): (WebCore::HistoryItem::documentSequenceNumber):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::navigateWithinDocument): (WebCore::FrameLoader::loadItem):
- loader/HistoryController.cpp: (WebCore::HistoryController::updateBackForwardListForFragmentScroll): (WebCore::HistoryController::pushState): (WebCore::HistoryController::replaceState):
- loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::scheduleHistoryNavigation):
- page/History.cpp: (WebCore::History::stateObjectAdded):
- page/Page.cpp: (WebCore::Page::goToItem):
- 1:14 PM Changeset in webkit [53949] by
-
- 6 edits in trunk/WebCore
2010-01-27 Oliver Hunt <oliver@apple.com>
Reviewed by Simon Fraser.
Animated scaling of background-image is too slow
https://bugs.webkit.org/show_bug.cgi?id=33808
Implement a version of the RenderImage animated scaling optimisation
for background images. Due to the possibility of arbitrary transforms
being applied to containing elements we explicitly check the current
CTM of the context for scaling or rotation.
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawTiledImage):
- platform/graphics/GraphicsContext.h:
- platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::isIdentityOrTranslation):
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelScaleData::RenderBoxModelScaleData): (WebCore::RenderBoxModelScaleData::~RenderBoxModelScaleData): (WebCore::RenderBoxModelScaleData::size): (WebCore::RenderBoxModelScaleData::time): (WebCore::RenderBoxModelScaleData::useLowQualityScale): (WebCore::RenderBoxModelScaleData::hiqhQualityRepaintTimer): (WebCore::RenderBoxModelScaleData::setSize): (WebCore::RenderBoxModelScaleData::setTime): (WebCore::RenderBoxModelScaleData::setUseLowQualityScale): (WebCore::RenderBoxModelScaleObserver::boxModelObjectDestroyed): (WebCore::RenderBoxModelScaleObserver::highQualityRepaintTimerFired): (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality): (WebCore::RenderBoxModelObject::highQualityRepaintTimerFired): (WebCore::RenderBoxModelObject::~RenderBoxModelObject): (WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderBoxModelObject.h:
- 12:40 PM Changeset in webkit [53948] by
-
- 3 edits2 adds in trunk/WebKitTools
Rubberstamped by Simon Hausmann.
[Qt] QtLauncher refactoring:
Move out code from the MainWindow (renamed to LauncherWindow)
that is not depending on the view, and add it to a new class
called MainWindow.
- QtLauncher/QtLauncher.pro:
- QtLauncher/main.cpp:
(LauncherWindow::LauncherWindow):
(LauncherWindow::eventFilter):
(LauncherWindow::loadStarted):
(LauncherWindow::loadFinished):
(LauncherWindow::newWindow):
(LauncherWindow::setupUI):
(WebPage::createWindow):
(main):
- QtLauncher/mainwindow.cpp: Added.
(MainWindow::MainWindow):
(MainWindow::buildUI):
(MainWindow::page):
(MainWindow::setAddressUrl):
(MainWindow::addCompleterEntry):
(MainWindow::load):
(MainWindow::changeLocation):
(MainWindow::openFile):
- QtLauncher/mainwindow.h: Added.
- 12:16 PM Changeset in webkit [53947] by
-
- 6 edits1 copy in trunk
2010-01-27 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Enable websockets support in QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=34180
Remove websockets tests from skiplist.
- platform/qt/Skipped:
2010-01-27 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Enable websockets support in QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=34180
Connected between SocketStreamHandle and QTcpSocket/QSslSocket
to enable support for websockets.
Proxy authentication is not yet supported.
SSL certificate errors are ignored while this is under development.
- WebCore.pro:
- platform/network/qt/SocketStreamHandle.h:
- platform/network/qt/SocketStreamHandlePrivate.h: Added.
- platform/network/qt/SocketStreamHandleQt.cpp: (WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate): (WebCore::SocketStreamHandlePrivate::~SocketStreamHandlePrivate): (WebCore::SocketStreamHandlePrivate::socketConnected): (WebCore::SocketStreamHandlePrivate::socketReadyRead): (WebCore::SocketStreamHandlePrivate::send): (WebCore::SocketStreamHandlePrivate::close): (WebCore::SocketStreamHandlePrivate::socketSentdata): (WebCore::SocketStreamHandlePrivate::socketClosed): (WebCore::SocketStreamHandlePrivate::socketError): (WebCore::SocketStreamHandlePrivate::socketClosedCallback): (WebCore::SocketStreamHandlePrivate::socketErrorCallback): (WebCore::SocketStreamHandlePrivate::socketSslErrors): (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::~SocketStreamHandle): (WebCore::SocketStreamHandle::platformSend): (WebCore::SocketStreamHandle::platformClose):
- 12:00 PM Changeset in webkit [53946] by
-
- 4 edits2 adds in trunk
2010-01-27 Mads Ager <ager@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Support getting integer-named properties using indexing notation on document object
https://bugs.webkit.org/show_bug.cgi?id=34211
- fast/dom/HTMLDocument/get-iframe-with-integer-name-expected.txt: Added.
- fast/dom/HTMLDocument/get-iframe-with-integer-name.html: Added.
2010-01-27 Mads Ager <ager@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Support getting integer-named properties using indexing notation on document object
https://bugs.webkit.org/show_bug.cgi?id=34211
Add indexed property getter to HTMLDocument to support getting
elements with integer names using indexing notation on document.
Test: fast/dom/HTMLDocument/get-iframe-with-integer-name.html
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::indexedPropertyGetter):
- 11:30 AM Changeset in webkit [53945] by
-
- 4 edits1 add in trunk/WebCore
2010-01-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Oliver Hunt.
Instead of relying on Object.prototype.toString result use JSObject::isActivationObject
to check if a scope node is a JSActivation. Object.prototype.toString for JSActivation
will call JSActivation::toThisObject whose result depends on the current call stack.
Test: WebCore/manual-tests/inspector/debugger-scopes-inspection.html
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::isActivation):
- inspector/InjectedScriptHost.idl:
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):
- manual-tests/inspector/debugger-scopes-inspection.html: Added.
- 11:18 AM Changeset in webkit [53944] by
-
- 10 edits in trunk/WebCore
2010-01-27 Anton Muhin <antonm@google.com>
Review by Adam Barth.
Implement Node map in intrusive way for better speed.
https://bugs.webkit.org/show_bug.cgi?id=33957
- bindings/v8/DOMData.h: (WebCore::DOMData::removeObjectsFromWrapperMap):
- bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::get): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::set): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::removeIfPresent): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::contains): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::visit): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clear): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::allocateTableEntry): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::freeTableEntry):
- bindings/v8/DOMDataStore.h: (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::IntrusiveDOMWrapperMap): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clearEntry): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clearEntries): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::visitEntries): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::TableChunk::TableChunk): (WebCore::DOMDataStore::domNodeMap):
- bindings/v8/StaticDOMDataStore.cpp: (WebCore::StaticDOMDataStore::StaticDOMDataStore):
- bindings/v8/StaticDOMDataStore.h:
- bindings/v8/V8DOMMap.cpp: (WebCore::getDOMNodeMap):
- bindings/v8/V8DOMMap.h: (WebCore::AbstractWeakReferenceMap::AbstractWeakReferenceMap): (WebCore::AbstractWeakReferenceMap::weakReferenceCallback): (WebCore::WeakReferenceMap::WeakReferenceMap): (WebCore::WeakReferenceMap::set): (WebCore::WeakReferenceMap::visit):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertDocumentToV8Object): (WebCore::getWrapper): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
- bindings/v8/V8DOMWrapper.h:
- 11:15 AM Changeset in webkit [53943] by
-
- 3 edits in trunk/WebKit/chromium
2010-01-26 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
Add methods to support running a nested modal loop outside of WebKit.
https://bugs.webkit.org/show_bug.cgi?id=34199
- public/WebView.h:
- src/WebViewImpl.cpp: (WebKit::WebView::willEnterModalLoop): Create PageGroupLoadDeferrer (WebKit::WebView::didExitModalLoop): Destroy PageGroupLoadDeferrer
- 11:01 AM Changeset in webkit [53942] by
-
- 7 edits in trunk
2010-01-27 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Eric Seidel.
Remove fast/events/keydown-numpad-keys.html from gtk's Skipped list.
https://bugs.webkit.org/show_bug.cgi?id=28247
- platform/gtk/Skipped:
2010-01-27 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Eric Seidel.
Add key event mappings for numpad keys for Gtk and Chromium/Gtk.
http://bugs.webkit.org/show_bug.cgi?id=28247
Test: fast/events/keydown-numpad-keys.html
- platform/chromium/KeyCodeConversionGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent):
- platform/gtk/KeyEventGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent):
2010-01-27 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Eric Seidel.
Correctly handle the KeyLocation argument that has been introduced
recently to test location-dependent key events in EventSender.keyDown.
http://bugs.webkit.org/show_bug.cgi?id=28247
Test: fast/events/keydown-numpad-keys.html
- DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
- 10:36 AM Changeset in webkit [53941] by
-
- 20 edits1 delete in trunk/WebCore
2010-01-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: migrate from SourceFrame to SourceFrame2.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- bindings/js/JSInspectorFrontendHostCustom.cpp:
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
- inspector/front-end/InspectorBackendStub.js:
- inspector/front-end/InspectorFrontendHostStub.js:
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._innerSelectContentTab):
- inspector/front-end/ResourcesPanel.js: (WebInspector.getResourceContent):
- inspector/front-end/ScriptView.js: (WebInspector.ScriptView): (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._sidebarResizeDrag):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.set executionLine): (WebInspector.SourceFrame.prototype.revealLine): (WebInspector.SourceFrame.prototype.addBreakpoint): (WebInspector.SourceFrame.prototype.removeBreakpoint): (WebInspector.SourceFrame.prototype.addMessage): (WebInspector.SourceFrame.prototype.clearMessages): (WebInspector.SourceFrame.prototype.sizeToFitContentHeight): (WebInspector.SourceFrame.prototype.setContent): (WebInspector.SourceFrame.prototype.findSearchMatches): (WebInspector.SourceFrame.prototype._collectRegexMatches): (WebInspector.SourceFrame.prototype.setSelection): (WebInspector.SourceFrame.prototype._incrementMessageRepeatCount): (WebInspector.SourceFrame.prototype._addExistingMessagesToSource): (WebInspector.SourceFrame.prototype._addMessageToSource): (WebInspector.SourceFrame.prototype._addExistingBreakpointsToSource): (WebInspector.SourceFrame.prototype._addBreakpointToSource): (WebInspector.SourceFrame.prototype._removeBreakpointFromSource): (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint): (WebInspector.SourceFrame.prototype._contextMenu): (WebInspector.SourceFrame.prototype._toggleBreakpoint): (WebInspector.SourceFrame.prototype._editBreakpointCondition.committed): (WebInspector.SourceFrame.prototype._editBreakpointCondition.dismissed): (WebInspector.SourceFrame.prototype._editBreakpointCondition): (WebInspector.SourceFrame.prototype._showBreakpointConditionPopup): (WebInspector.SourceFrame.prototype._createConditionElement): (WebInspector.SourceFrame.prototype._keyDown): (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame): (WebInspector.SourceFrame.prototype._breakpointChanged): (WebInspector.SourceFrame.prototype.resize): (WebInspector.BreakpointLineNumberDecorator): (WebInspector.BreakpointLineNumberDecorator.prototype.decorate): (WebInspector.BreakpointLineNumberDecorator.prototype._paintBreakpoint): (WebInspector.BreakpointLineNumberDecorator.prototype._paintProgramCounter): (WebInspector.BreakpointLineNumberDecorator.prototype.mouseDown): (WebInspector.BreakpointLineNumberDecorator.prototype.contextMenu): (WebInspector.ExecutionLineDecorator): (WebInspector.ExecutionLineDecorator.prototype.decorate):
- inspector/front-end/SourceFrame2.js: Removed.
- inspector/front-end/SourceView.js: (WebInspector.SourceView): (WebInspector.SourceView.prototype.show): (WebInspector.SourceView.prototype.resize): (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded): (WebInspector.SourceView.prototype._contentLoaded): (WebInspector.SourceView.prototype.performSearch.findSearchMatches): (WebInspector.SourceView.prototype.performSearch): (WebInspector.SourceView.prototype._jumpToSearchResult): (WebInspector.SourceView.prototype._sourceFrameSetupFinished):
- inspector/front-end/TextEditor.js: (WebInspector.TextEditor.prototype._mouseDown): (WebInspector.TextEditor.prototype._copy.delayCopy): (WebInspector.TextEditor.prototype._copy): (WebInspector.TextEditor.prototype._cut):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 10:19 AM Changeset in webkit [53940] by
-
- 2 edits in trunk/WebCore
2010-01-27 Dominik Röttsches <dominik.roettsches@access-company.com>
Reviewed by Xan Lopez.
[Gtk] For removing ICU, implement IDN support by means of libidn
https://bugs.webkit.org/show_bug.cgi?id=31470
In order to avoid a new dependency,
IDN support now based on GLib for the GLib unicode backend.
- platform/KURL.cpp: (WebCore::appendEncodedHostname):
- 9:55 AM Changeset in webkit [53939] by
-
- 3 edits1 add in trunk/WebKit/chromium
2010-01-27 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
Adding missing WebMutationEvent.cpp file to fix build bustage.
https://bugs.webkit.org/show_bug.cgi?id=33882
- public/WebMutationEvent.h: Remove unnecessary constructor.
- src/WebEvent.cpp: Remove unnecessary include of WebMutationEvent.h.
- src/WebMutationEvent.cpp: Added.
- 9:43 AM Changeset in webkit [53938] by
-
- 2 edits in trunk/WebKitTools
Rubberstamped by Simon Hausmann.
[Qt] QtLauncher, coding style fixes.
- QtLauncher/main.cpp:
(MainWindow::MainWindow):
(MainWindow::sendTouchEvent):
(MainWindow::eventFilter):
(MainWindow::loadURL):
(MainWindow::setupUI):
(WebPage::createPlugin):
- 9:41 AM BuildingOnWindows edited by
- (diff)
- 9:40 AM BuildingOnWindows edited by
- (diff)
- 9:02 AM Changeset in webkit [53937] by
-
- 4 edits2 copies in trunk/WebKitTools
Rubberstamped by Simon Hausmann.
[Qt] QtLauncher refactoring, separating the webview and
adding a QGraphicsWebView based version.
- QtLauncher/QtLauncher.pro:
- QtLauncher/main.cpp:
(MainWindow::MainWindow):
- QtLauncher/webpage.h:
- QtLauncher/webview.cpp: Added.
(createContextMenu):
(WebViewGraphicsBased::mousePressEvent):
(WebViewTraditional::mousePressEvent):
(WebViewGraphicsBased::contextMenuEvent):
(WebViewTraditional::contextMenuEvent):
- QtLauncher/webview.h: Added.
(WebViewGraphicsBased::WebViewGraphicsBased):
(WebViewTraditional::WebViewTraditional):
- 8:14 AM Changeset in webkit [53936] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Update the .def files with exported symbols
Reviewed by Laszlo Gombos.
- symbian/eabi/QtWebKitu.def: Add two mangled missing new symbols for arm eabi.
- 8:06 AM Changeset in webkit [53935] by
-
- 4 edits in trunk
.: [Qt] Don't build the tests in packages, only the launcher(s)
Reviewed by Kenneth Rohde Christiansen.
- WebKit.pro:
WebCore: [Qt] For package builds use the .def files on Symbian
Reviewed by Kenneth Rohde Christiansen.
- WebCore.pro:
- 7:15 AM Changeset in webkit [53934] by
-
- 6 edits9 adds in trunk/WebKit/chromium
2010-01-27 Jay Campan <jcampan@google.com>
Reviewed by Darin Fisher.
Adding EventListeners to the chromium API.
- WebKit.gyp:
- public/WebEvent.h: Added.
- public/WebEventListener.h: Added.
- public/WebMutationEvent.h: Added.
- public/WebNode.h:
- public/WebString.h: (WebKit::operator==): (WebKit::operator!=):
- src/EventListenerWrapper.cpp: Added.
- src/EventListenerWrapper.h: Added.
- src/WebEvent.cpp: Added.
- src/WebEventListener.cpp: Added.
- src/WebEventListenerPrivate.cpp: Added.
- src/WebEventListenerPrivate.h: Added.
- src/WebNode.cpp: (WebKit::WebNode::addEventListener): (WebKit::WebNode::removeEventListener):
- src/WebString.cpp: (WebKit::WebString::equals):
- 6:58 AM Changeset in webkit [53933] by
-
- 2 edits in trunk/WebCore
2010-01-27 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Avoid watch expressions duplication
https://bugs.webkit.org/show_bug.cgi?id=33996
- inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSidebarPane.prototype._settingsLoaded):
- 6:47 AM Changeset in webkit [53932] by
-
- 2 edits in trunk/WebKitTools
2010-01-27 Alexander Pavlov <apavlov@chromium.org>
Adding myself as committer. No review necessary.
- Scripts/webkitpy/committers.py:
- 6:41 AM Changeset in webkit [53931] by
-
- 12 edits2 adds in trunk/WebCore
2010-01-27 Marcus Bulach <bulach@chromium.org>
Reviewed by Dimitri Glazkov.
Adds EventSource bindings for V8
https://bugs.webkit.org/show_bug.cgi?id=33695
No new tests (existing layout tests for EventSource should pass).
- Android.v8bindings.mk:
- WebCore.gypi:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/DOMObjectsInclude.h:
- bindings/v8/DerivedSourcesAllInOne.cpp:
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8DOMWrapper.h:
- bindings/v8/V8Index.cpp:
- bindings/v8/V8Index.h:
- bindings/v8/WorkerContextExecutionProxy.cpp:
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8EventSourceConstructor.cpp: Added.
- bindings/v8/custom/V8EventSourceCustom.cpp: Added.
- 6:25 AM Changeset in webkit [53930] by
-
- 5 edits in trunk
2010-01-27 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Meta-methods can't be introspected using ES5 API
https://bugs.webkit.org/show_bug.cgi?id=34087
Add getOwnPropertyDescriptor() and getOwnPropertyNames() reimplementations.
Tests are in WebKit/qt/tests/qwebframe
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyDescriptor): (JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyNames): (JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyDescriptor): (JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyNames):
- bridge/qt/qt_runtime.h:
2010-01-27 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Meta-methods can't be introspected using ES5 API
https://bugs.webkit.org/show_bug.cgi?id=34087
Test that Object.getOwnPropertyDescriptor and
Object.getOwnPropertyNames work with meta-methods.
- tests/qwebframe/tst_qwebframe.cpp:
- 6:21 AM Changeset in webkit [53929] by
-
- 3 edits2 adds in trunk/WebKitTools
Rubberstamped by Simon Hausmann
[Qt] QtLauncher refactoring, separating utility methods.
- QtLauncher/QtLauncher.pro:
- QtLauncher/main.cpp:
- QtLauncher/utils.cpp: Added.
(urlFromUserInput):
- QtLauncher/utils.h: Added.
- 6:07 AM Changeset in webkit [53928] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-27 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port WTF's randomNumber
https://bugs.webkit.org/show_bug.cgi?id=33566
Use GETRAND to generate 4 byte random byte sequence to implement
weakRandomNumber. Create a secure random number generator with
AEECLSID_RANDOM to implement randomNumber.
- wtf/RandomNumber.cpp: (WTF::weakRandomNumber): (WTF::randomNumber):
- 5:51 AM Changeset in webkit [53927] by
-
- 3 edits2 adds in trunk
2010-01-27 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
Fix a crash when trying to indent a block element that was contained
in a list. This was happening because enclosingBlock() in
htmlediting.cpp can return the current the same Node when a block
element (like an <hr> or a <table>) is passed in. This causes
the indent command to think that it is not in a list item.
Work around this by checking to see if enclosingBlock returned the
same Node.
- editing/execCommand/indent-block-in-list-expected.txt: Added.
- editing/execCommand/indent-block-in-list.html: Added.
2010-01-27 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
Fix a crash when trying to indent a block element that was contained
in a list. This was happening because enclosingBlock() in
htmlediting.cpp can return the current the same Node when a block
element (like an <hr> or a <table>) is passed in. This causes
the indent command to think that it is not in a list item.
Work around this by checking to see if enclosingBlock returned the
same Node.
Test: editing/execCommand/indent-block-in-list.html
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::tryIndentingAsListItem):
- 5:34 AM Changeset in webkit [53926] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-27 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port getCPUTime
https://bugs.webkit.org/show_bug.cgi?id=33572
Use GETUPTIMEMS which returns a continuously and
linearly increasing millisecond timer from the time the device
was powered on. This function is enough to implement getCPUTime.
- runtime/TimeoutChecker.cpp: (JSC::getCPUTime):
- 5:01 AM Changeset in webkit [53925] by
-
- 9 edits1 copy1 add in trunk/WebKitTools
2010-01-27 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
webkit-patch needs an open-bugs command
https://bugs.webkit.org/show_bug.cgi?id=30793
- Scripts/test-webkitpy: import OpenBugsTest
- Scripts/webkit-patch: import OpenBugs
- Scripts/webkitpy/commands/download_unittest.py: don't import unittest
- Scripts/webkitpy/commands/early_warning_system_unittest.py: ditto
- Scripts/webkitpy/commands/queries_unittest.py: ditto
- Scripts/webkitpy/commands/queues_unittest.py: ditto
- Scripts/webkitpy/commands/upload_unittest.py: ditto
- Scripts/webkitpy/mock_bugzillatool.py: log when user.open_url is called.
- 4:43 AM Changeset in webkit [53924] by
-
- 4 edits in trunk
[Qt] Add the "d" suffix to QtWebKit's dll on Windows.
Reviewed by Tor Arne Vestbø.
- WebKit.pri:
WebCore:
- WebCore.pro:
- 4:41 AM Changeset in webkit [53923] by
-
- 1 edit1 delete in trunk/LayoutTests
[Qt] Qt port doesn't need platform dependent expected file anymore
for editing/pasteboard/paste-noscript-xhtml.html from r53873.
- platform/qt/editing/pasteboard/paste-noscript-xhtml-expected.txt: Removed.
- 4:41 AM Changeset in webkit [53922] by
-
- 2 edits1 add in trunk/JavaScriptCore
2010-01-27 Kwang Yul Seo <skyul@company100.net>
Reviewed by Oliver Hunt.
[BREWMP] Add MarkStack fastMalloc implementation for platforms without VirtualAlloc or mmap.
https://bugs.webkit.org/show_bug.cgi?id=33582
Use fastMalloc and fastFree to implement MarkStack::allocateStack and
MarkStack::releaseStack for platforms without page level allocation.
- runtime/MarkStack.h: (JSC::MarkStack::MarkStackArray::shrinkAllocation):
- runtime/MarkStackNone.cpp: Added. (JSC::MarkStack::initializePagesize): (JSC::MarkStack::allocateStack): (JSC::MarkStack::releaseStack):
- 4:17 AM Changeset in webkit [53921] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-27 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Don't use time function
https://bugs.webkit.org/show_bug.cgi?id=33577
Calling time(0) in BREW devices causes a crash because time
is not properly ported in most devices. Cast currentTime() to
time_t to get the same result as time(0).
- wtf/DateMath.cpp: (WTF::calculateUTCOffset):
- 4:10 AM Changeset in webkit [53920] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/backgrounds/animated-svg-as-background.html make fast/backgrounds/svg-as-background-5.html crash.
https://bugs.webkit.org/show_bug.cgi?id=34202
- platform/qt/Skipped: fast/backgrounds/animated-svg-as-background.html enabled because bug rolled out by r53912.
- 3:56 AM Changeset in webkit [53919] by
-
- 4 edits in trunk/WebKitTools
Rubberstamped by Simon Hausmann
[Qt] Refactor the code in the QtLauncher dealing with HTTP proxy.
- QtLauncher/main.cpp:
(MainWindow::MainWindow):
- QtLauncher/webpage.cpp:
(WebPage::WebPage):
(WebPage::applyProxy):
- QtLauncher/webpage.h:
- 3:51 AM Changeset in webkit [53918] by
-
- 2 edits in trunk
[Qt] Build fix for windows when QTDIR contains release libraries.
Unreviewed build fix
- WebKit.pri: Use the <name>.lib syntax for linking instead of qmake's -l<name> emulation
- 3:43 AM Changeset in webkit [53917] by
-
- 3 edits6 adds in trunk
2010-01-27 Matt Perry <mpcomplete@chromium.org>
Reviewed by Eric Seidel.
Fix a bug where dispatchDocumentElementAvailable was fired for fragment parsing on XML documents.
https://bugs.webkit.org/show_bug.cgi?id=33920
- userscripts/resources: Added.
- userscripts/resources/blank.xhtml: Added.
- userscripts/script-not-run-for-fragments-expected.txt: Added.
- userscripts/script-not-run-for-fragments.html: Added.
- userscripts/script-run-at-start-expected.txt: Added.
- userscripts/script-run-at-start.html: Added.
2010-01-27 Matt Perry <mpcomplete@chromium.org>
Reviewed by Eric Seidel.
Fix a bug where dispatchDocumentElementAvailable was fired for fragment parsing on XML documents.
https://bugs.webkit.org/show_bug.cgi?id=33920
Tests: userscripts/script-not-run-for-fragments.html
userscripts/script-run-at-start.html
- dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::startElementNs):
- 3:18 AM Changeset in webkit [53916] by
-
- 3 edits in trunk/WebCore
2010-01-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Improve SourceHTMLTokenizer so that it treats script tag well.
- inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype._isAttribute): (WebInspector.SourceHTMLTokenizer.prototype._isAttributeValue): (WebInspector.SourceHTMLTokenizer.prototype._setAttributeValue): (WebInspector.SourceHTMLTokenizer.prototype._setAttribute): (WebInspector.SourceHTMLTokenizer.prototype._stringToken): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
- inspector/front-end/SourceHTMLTokenizer.re2js:
- 3:16 AM Changeset in webkit [53915] by
-
- 8 edits6 deletes in trunk/WebCore
2010-01-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: nuke quarantine wrappers.
- Android.jscbindings.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSInspectedObjectWrapper.cpp: Removed.
- bindings/js/JSInspectedObjectWrapper.h: Removed.
- bindings/js/JSInspectorCallbackWrapper.cpp: Removed.
- bindings/js/JSInspectorCallbackWrapper.h: Removed.
- bindings/js/JSQuarantinedObjectWrapper.cpp: Removed.
- bindings/js/JSQuarantinedObjectWrapper.h: Removed.
- 2:41 AM BuildingOnWindows edited by
- (diff)
- 1:49 AM Changeset in webkit [53914] by
-
- 2 edits in trunk/WebKitTools
[Qt] Corrects debug build of DumpRenderTree on Windows.
Reviewed by Tor Arne Vestbø.
- DumpRenderTree/qt/DumpRenderTree.pro:
- 1:09 AM Changeset in webkit [53913] by
-
- 2 edits in trunk
Fix a typo in ChangeLogs.
- 1:06 AM Changeset in webkit [53912] by
-
- 21 edits in trunk
Revert r53899 (HashMap<AtomicStringImpl*, Value> key checks) and subsequent bug fixes,
because they make SVG tests crash in release builds.
- 12:41 AM Changeset in webkit [53911] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/backgrounds/animated-svg-as-background.html make fast/backgrounds/svg-as-background-5.html crash.
https://bugs.webkit.org/show_bug.cgi?id=34202
- platform/qt/Skipped: fast/backgrounds/animated-svg-as-background.html skipped until fix.
- 12:36 AM Changeset in webkit [53910] by
-
- 3 edits in trunk/WebCore
2010-01-25 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
autobuffer value not forwarded media element to MediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=33889
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadResource): Forward autobuffer value to MediaPlayer instance.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load): Forward autobuffer and preservesPitch values to newly created platform media player instance.
- 12:24 AM Changeset in webkit [53909] by
-
- 5 edits in trunk
2010-01-25 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
[Gtk] media/video-reverse-play-duration.html fails on and off on Gtk buildbots
https://bugs.webkit.org/show_bug.cgi?id=34086
Cache media duration and fix didEnd() in case of reverse
playback. When EOS was reached but in case of reverse playback the
position is not always 0. So to not confuse the HTMLMediaElement
we synchronize position and duration values.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::duration): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::didEnd): (WebCore::MediaPlayerPrivate::durationChanged):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
2010-01-25 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
[Gtk] media/video-reverse-play-duration.html fails on and off on Gtk buildbots
https://bugs.webkit.org/show_bug.cgi?id=34086
- platform/gtk/Skipped: Unskip fixed test.
- 12:06 AM Changeset in webkit [53908] by
-
- 2 edits in trunk/WebCore
- WebCore.xcodeproj/project.pbxproj: Actually land the change to add ContainerNodeAlgorithms.h (it's "svn resolved", not "svn revert"!).
Jan 26, 2010:
- 11:54 PM Changeset in webkit [53907] by
-
- 2 edits in trunk/LayoutTests
2010-01-26 Daniel Bates <dbates@webkit.org>
Unreviewed. Made a minor typo when I added the test case fast/css/button-height.html
to the GTK Skipped file. In changeset 53900, I added test "fast/css/button-height.htm"
to the GTK Skipped file instead of "fast/css/button-height.html". See bug #33936
for more details.
- platform/gtk/Skipped:
- 11:53 PM Changeset in webkit [53906] by
-
- 2 edits in trunk/LayoutTests
[Qt] Failing tests after r53895 skipped.
https://bugs.webkit.org/show_bug.cgi?id=34167
- platform/qt/Skipped:
- http/tests/history/redirect-301.pl
- http/tests/history/redirect-302.pl
- http/tests/history/redirect-303.pl
- http/tests/history/redirect-307.pl
- 11:46 PM Changeset in webkit [53905] by
-
- 2 edits in trunk/LayoutTests
Unreviewed trivial fix.
- platform/qt/editing/pasteboard/paste-noscript-xhtml-expected.txt: updated after r53873.
- 11:02 PM Changeset in webkit [53904] by
-
- 2 edits in trunk/WebKitLibraries
More Windows build fixing.
- win/tools/vsprops/common.vsprops: Disable warning C4180 (qualifier applied to function type has no meaning; ignored). This is a known bug - MSVC tries to compile a wrong specialization sometimes - but it's not instantiated, so it's harmless.
- 10:39 PM Changeset in webkit [53903] by
-
- 2 edits in trunk/JavaScriptCore
More Windows build fixing.
- wtf/HashTraits.h: _msize takes void*, remove const qualifier from type.
- 10:22 PM Changeset in webkit [53902] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- wtf/HashTraits.h: Include malloc.h for _msize().
- 10:19 PM Changeset in webkit [53901] by
-
- 2 edits in trunk/JavaScriptCore
Build fix.
- wtf/HashTable.h: (WTF::HashTable::checkTableConsistencyExceptSize): Remove const from a static (empty) version of this function.
- 10:07 PM Changeset in webkit [53900] by
-
- 3 edits in trunk/LayoutTests
2010-01-26 Daniel Bates <dbates@webkit.org>
Unreviewed. Updated expected failing results for table-percent-height.html
to reflect one pixel difference between the results generated by the Qt bot
and my machine. Added failing test fast/css/button-height.html to GTK Skipped
file as we need to look into this. See bug #33936 for more details.
- platform/gtk/Skipped: Added failing test fast/css/button-height.html.
- platform/qt/fast/replaced/table-percent-height-expected.txt: Updated result.
- 9:57 PM Changeset in webkit [53899] by
-
- 21 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=34150
WebKit needs a mechanism to catch stale HashMap entries
It is very difficult to catch stale pointers that are HashMap keys - since a pointer's hash
is just its value, it is very unlikely that any observable problem is reproducible.
This extends hash table consistency checks to check that pointers are referencing allocated
memory blocks, and makes it possible to invoke the checks explicitly (it is not feasible
to enable CHECK_HASHTABLE_CONSISTENCY by default, because that affects performance too much).
- wtf/HashMap.h: (WTF::::checkConsistency): Call through to HashTable implementation. We can add similar calls to HashSet and HashCountedSet, but I haven't seen hard to debug problems with those yet.
- wtf/HashSet.h: (WTF::::remove): The version of checkTableConsistency that's guarded by CHECK_HASHTABLE_CONSISTENCY is now called internalCheckTableConsistency().
- wtf/HashTable.h: (WTF::HashTable::internalCheckTableConsistency): (WTF::HashTable::internalCheckTableConsistencyExceptSize): (WTF::HashTable::checkTableConsistencyExceptSize): Expose checkTableConsistency() even if CHECK_HASHTABLE_CONSISTENCY is off. (WTF::::add): Updated for checkTableConsistency renaming. (WTF::::addPassingHashCode): Ditto. (WTF::::removeAndInvalidate): Ditto. (WTF::::remove): Ditto. (WTF::::rehash): Ditto. (WTF::::checkTableConsistency): The assertion for !shouldExpand() was not correct - this function returns true for tables with m_table == 0. (WTF::::checkTableConsistencyExceptSize): Call checkValueConsistency for key. Potentially, we could do the same for values.
- wtf/HashTraits.h: (WTF::GenericHashTraits::checkValueConsistency): An empty function that can be overridden to add checks. Currently, the only override is for pointer hashes.
- wtf/RefPtrHashMap.h: (WTF::::remove): Updated for checkTableConsistency renaming.
- 9:54 PM Changeset in webkit [53898] by
-
- 2 edits1 add in trunk/WebKit/chromium
2010-01-26 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Fisher.
Add KeyboardTest to WebKit API tests
https://bugs.webkit.org/show_bug.cgi?id=34178
- WebKit.gyp:
- tests/KeyboardTest.cpp: Added.
- 9:29 PM Changeset in webkit [53897] by
-
- 5 edits3 adds in trunk
2010-01-26 Daniel Bates <dbates@webkit.org>
Reviewed by Tor Arne Vestbø.
[Qt] Fixes an issue where the height of <button>- and
<input type="button">- elements are fixed to the height of the
button label font plus padding. That is, the CSS height property
is being ignored.
Instead, we should honor the user-specified height, if appropriate
for the platform and context. Notice, the Mac ports do not honor the
height for <input type="button"> elements unless a border and/or
background is also specified.
Test: fast/css/button-height.html
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::adjustButtonStyle):
2010-01-26 Daniel Bates <dbates@webkit.org>
Reviewed by Tor Arne Vestbø.
Tests that the user-specified height for <button>- and <input type="button">-
elements are honored, if appropriate for the platform and context.
- fast/css/button-height-expected.txt: Added.
- fast/css/button-height.html: Added.
- fast/replaced/table-percent-height-expected.txt: Added notice about failing tests in Windows ports.
- fast/replaced/table-percent-height.html: Ditto.
- platform/qt/fast/replaced/table-percent-height-expected.txt: Added.
- 9:26 PM Changeset in webkit [53896] by
-
- 4 edits in trunk/WebKitTools
2010-01-26 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Moves the try/catch for OSError exceptions in Executive.run_command
to Credentials.read_credentials() so that the unit test
webkitpy.scm_unittest.SCMClassTests.test_error_handlers can
assert that Executive.run_command throws an OSError exception.
- Scripts/webkitpy/credentials.py:
- Scripts/webkitpy/executive.py: Moved try/catch for OSError to method Credentials.read_credentials().
- Scripts/webkitpy/executive_unittest.py: Removed tests that no longer apply: test_run_command_with_bad_command_check_return_code and test_run_command_with_bad_command_check_calls_error_handler. Added new test to assert that run_command throws OSError exceptions.
- 9:21 PM Changeset in webkit [53895] by
-
- 5 edits in trunk
2010-01-26 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT WebHistory support
https://bugs.webkit.org/show_bug.cgi?id=34167
- platform/qt/Skipped:
2010-01-26 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] DRT WebHistory support
https://bugs.webkit.org/show_bug.cgi?id=34167
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::webHistoryItemCount): (LayoutTestController::keepWebHistory):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 9:04 PM Changeset in webkit [53894] by
-
- 2 edits in trunk/WebCore
2010-01-26 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Enable the Audits panel via a shortcut (Cmd/Ctrl+Alt+A)
https://bugs.webkit.org/show_bug.cgi?id=34158
- inspector/front-end/inspector.js: (WebInspector.documentKeyDown):
- 8:45 PM Changeset in webkit [53893] by
-
- 5 edits24 adds in trunk
2010-01-26 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsNumber support except type=datetime-local.
https://bugs.webkit.org/show_bug.cgi?id=32696
input-valueasnumber-datetime-expected.txt and
input-valueasnumber-time-expected.txt have FAIL lines because they
test unimplemented features.
- fast/forms/input-valueasnumber-date-expected.txt: Added.
- fast/forms/input-valueasnumber-date.html: Added.
- fast/forms/input-valueasnumber-datetime-expected.txt: Added.
- fast/forms/input-valueasnumber-datetime.html: Added.
- fast/forms/input-valueasnumber-month-expected.txt: Added.
- fast/forms/input-valueasnumber-month.html: Added.
- fast/forms/input-valueasnumber-number-expected.txt: Added.
- fast/forms/input-valueasnumber-number.html: Added.
- fast/forms/input-valueasnumber-range-expected.txt: Added.
- fast/forms/input-valueasnumber-range.html: Added.
- fast/forms/input-valueasnumber-time-expected.txt: Added.
- fast/forms/input-valueasnumber-time.html: Added.
- fast/forms/input-valueasnumber-unsupported-expected.txt: Added.
- fast/forms/input-valueasnumber-unsupported.html: Added.
- fast/forms/input-valueasnumber-week-expected.txt: Added.
- fast/forms/input-valueasnumber-week.html: Added.
- fast/forms/script-tests/input-valueasnumber-date.js: Added.
- fast/forms/script-tests/input-valueasnumber-datetime.js: Added.
- fast/forms/script-tests/input-valueasnumber-month.js: Added.
- fast/forms/script-tests/input-valueasnumber-number.js: Added.
- fast/forms/script-tests/input-valueasnumber-range.js: Added.
- fast/forms/script-tests/input-valueasnumber-time.js: Added.
- fast/forms/script-tests/input-valueasnumber-unsupported.js: Added.
- fast/forms/script-tests/input-valueasnumber-week.js: Added.
2010-01-26 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsNumber support except type=datetime-local.
https://bugs.webkit.org/show_bug.cgi?id=32696
Tests: fast/forms/input-valueasnumber-date.html
fast/forms/input-valueasnumber-datetime.html
fast/forms/input-valueasnumber-month.html
fast/forms/input-valueasnumber-number.html
fast/forms/input-valueasnumber-range.html
fast/forms/input-valueasnumber-time.html
fast/forms/input-valueasnumber-unsupported.html
fast/forms/input-valueasnumber-week.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsNumber): According to the specification, we should return NaN for invalid values. (WebCore::HTMLInputElement::setValueAsNumber): According to the specification, throws NOT_SUPPORTED_ERR for Infinitiy or NaN, and throws INVALID_STATE_ERR for unsupported types. (WebCore::HTMLInputElement::formStringToDouble): According to the step 14 of Real Number in the specification, we should round -0 to 0.
- html/HTMLInputElement.h: Declare valueAsNumber() and setValueAsNumber().
- html/HTMLInputElement.idl: Add valueAsNumber.
- 8:44 PM WebKit Team edited by
- add my nick (diff)
- 8:41 PM Changeset in webkit [53892] by
-
- 2 edits in trunk/WebCore
Make sure there is a lock on serialize in SerializedScriptValueData, since type errors can be created when
exceptions are thrown.
Reviewed by Oliver Hunt.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValueData::serialize):
- 8:20 PM Changeset in webkit [53891] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-26 Lyon Chen <liachen@rim.com>
Reviewed by Maciej Stachowiak.
Opcode.h use const void* for Opcode cause error #1211 for RVCT compiler
https://bugs.webkit.org/show_bug.cgi?id=33902
- bytecode/Opcode.h:
- 8:17 PM Changeset in webkit [53890] by
-
- 7 edits in trunk/WebCore
2010-01-26 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Add Date type support for Objective-C binding.
https://bugs.webkit.org/show_bug.cgi?id=32810
The Date type in IDLs is mapped to NSTimeInterval in Objective-C.
- bindings/objc/DOMInternal.h: Add kit() and core() for NSTimeInterval.
- bindings/scripts/CodeGenerator.pm: Make Date a primitive type.
- bindings/scripts/CodeGeneratorJS.pm: Move some code for the CodeGeenrator.pm change.
- bindings/scripts/CodeGeneratorObjC.pm:
- bindings/scripts/CodeGeneratorV8.pm: Move some code for the CodeGeenrator.pm change.
- html/HTMLInputElement.idl: Remove Objective-C exclusion for valueAsDate.
- 8:09 PM Changeset in webkit [53889] by
-
- 4 edits in trunk
2010-01-26 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
[Win] Add modifiers parameter support to Windows DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=34068
Remove listbox-deselect-scroll.html and listbox-selectio-2.html
from Skipped. We improved their portability and Windows DRT now
havs modifiers parameter of eventSender.mouseDown() and
eventSender.mouseUp().
- platform/win/Skipped:
2010-01-26 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
[Win] Add modifiers parameter support to Windows DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=34068
Add support for functional name modifiers; "addSelectionKey" and
"rangeSelectionKey", and modifiers parameter to eventSender.mouseDown()
and eventSender.mouseUp().
This change is similar to r53498 for Mac.
- DumpRenderTree/win/EventSender.cpp: (buildModifierFlags): New function to set MK_CONTROL or MK_SHIFT to WPARAM. (mouseDownCallback): Call buidlModifiersFlags(). (mouseUpCallback): ditto. (keyDownCallback): Add support for "addSelectionkey" and "rangeSelectionKey".
- 7:58 PM Changeset in webkit [53888] by
-
- 1 edit in trunk/WebKitTools/Scripts/webkitpy/autoinstall.py
No review: fixing broken autoinstall.py
- 7:04 PM Changeset in webkit [53887] by
-
- 2 edits in trunk/WebKitTools
2010-01-26 Chris Jerdonek <Chris Jerdonek>
Reviewed by Eric Seidel.
The Python autoinstall cache directory now only gets created
in the directory containing autoinstall.py.
- Scripts/webkitpy/autoinstall.py:
- Also added a README file to the cache directory saying where it came from.
- 6:56 PM Changeset in webkit [53886] by
-
- 2 edits in trunk/WebCore
Not reviewed, attempt to fix Tiger build.
- rendering/RenderTreeAsText.cpp:
(WebCore::write): Use UNUSED_PARAM macros to prevent compiler warning on targets without accelerated compositing.
- 6:54 PM Changeset in webkit [53885] by
-
- 2 edits in trunk/WebCore
Incorrect boolean expression in isMailBlockquote() (WebCore/htmlediting.cpp)
https://bugs.webkit.org/show_bug.cgi?id=34156
Reviewed by Darin Adler.
No new tests (minor code change).
- editing/htmlediting.cpp:
(WebCore::isMailBlockquote):
- 6:25 PM Changeset in webkit [53884] by
-
- 5 edits in trunk/WebCore
Handle broken images more correctly in the open-source image decoders.
https://bugs.webkit.org/show_bug.cgi?id=33747
Reviewed by David Levin.
No tests since Safari doesn't use these decoders and there's already a
broken-image test in the tree.
- platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::createFrameAtIndex): No need to check isSizeAvailable() since size() is now always safe.
- platform/image-decoders/ImageDecoder.h:
(WebCore::ImageDecoder::size): Don't assert that the bitmap is valid; we don't need a complete successful decode to be able to give info about the size.
- platform/image-decoders/qt/RGBA32BufferQt.cpp:
(WebCore::RGBA32Buffer::setSize): Don't set the frame to complete on failure, since it's not complete, but empty, and callers can better handle empty frames.
- platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::RGBA32Buffer::setSize): Don't set the frame to complete on failure, since it's not complete, but empty, and callers can better handle empty frames.
- 6:23 PM Changeset in webkit [53883] by
-
- 3 edits in trunk/WebCore
2010-01-26 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Synchronize Qt/Gtk build systems with Mac/Win, should fix Qt compilation. Gtk results still pending.
- GNUmakefile.am:
- WebCore.pro:
- 6:14 PM Changeset in webkit [53882] by
-
- 4 edits4 moves2 adds in trunk/WebKitTools
2010-01-26 Chris Jerdonek <Chris Jerdonek>
Reviewed by Eric Seidel.
Moved the check-webkit-style processors into a new
webkitpy/style/processors directory.
- Scripts/webkitpy/style/checker.py:
- Scripts/webkitpy/style/checker_unittest.py:
- Scripts/webkitpy/style/cpp_style.py: Removed.
- Scripts/webkitpy/style/cpp_style_unittest.py: Removed.
- Scripts/webkitpy/style/processors: Added.
- Scripts/webkitpy/style/processors/init.py: Added.
- Scripts/webkitpy/style/processors/cpp.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style.py.
- Scripts/webkitpy/style/processors/cpp_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py.
- Scripts/webkitpy/style/processors/text.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style.py.
- Scripts/webkitpy/style/processors/text_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style_unittest.py.
- Scripts/webkitpy/style/text_style.py: Removed.
- Scripts/webkitpy/style/text_style_unittest.py: Removed.
- Scripts/webkitpy/style/unittests.py:
- 6:02 PM Changeset in webkit [53881] by
-
- 2 edits in trunk/WebCore
2010-01-26 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Attempt to fix V8 - change SetterMethod function signatures, just like it has been done for JSSVGPODTypeWrapper.
- bindings/v8/V8SVGPODTypeWrapper.h:
- 5:53 PM Changeset in webkit [53880] by
-
- 2 edits in trunk/WebCore
2010-01-26 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewd. Revert Base.xcconfig changes, was not meant to be committed.
- Configurations/Base.xcconfig:
- 5:51 PM Changeset in webkit [53879] by
-
- 142 edits3 adds3 deletes in trunk/WebCore
2010-01-26 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Oliver Hunt.
SVG consumes way too much memory to store animated properties in the DOM
https://bugs.webkit.org/show_bug.cgi?id=34188
Shrink WebCore library size to 75% (measured in debug builds) and reduce SVG memory usage to <25%.
Adding Oliver testcase as manual-tests/svg-node-count-vs-scroll.xhtml, which creates an arbitary number of
rects (50.000 <rect> elements added to the DOM by default) - memory usage down to 111M from 503M (RPRVT).
The SVG DOM side is almost fine, still some optimizations possible, that will be implemented soon - next
target is the SVG render tree, there are plenty of possibilities to reduce memory usage there.
Redesign the way we store animated properties in the individual SVG*Element files. Short story: In order
to support SVG DOM through the bindings (e.g. JS) we need to associate SVGAnimatedProperty objects with
the SVGElement object that created it - we used to store this pointer directly in the SVGAnimatedProperty.
This means, every SVGAnimatedProperty stored in a SVGRectElement, stored a pointer to the SVGRectElement, resulting
in excessive memory usage. This is now properly implemented, without wasting tons of memory. Unfortunately this
requires touching all SVG*Element files.
Detailed list of changes:
- Remove template bloat by not specializing class templates for each attributeName/tagName combination. Instead SVGAnimatedProperty is a non-specialized template class now, only depending on the AnimatedType (ie. SVGLength for SVGAnimatedLength) -> This heavily reduces the generated code, thus shrinking WebCore size. I hope we can build windows again without SVGAllInOne.cpp
- Remove "exportStrings" / "exportString" handling from make_names.pl - SVG defined string literals for each QualifiedName, in order to use template specialization based on "const char*" parameters. All that bloat is gone, so there's no need for it anymore.
- Redesign SVGAnimatedProperty so it does not need any back-pointers to the SVGElement that created it
- Don't actually store the XML DOM attribute name associated with a SVG DOM property in SVGAnimatedProperty, move the associatedAttributeName() function inside the macro declaration and just return the passed macro parameter DOMAttribute there, storing is inefficient and useless.
- Remove SynchronizablePropertyController, which was living in SVGElement as member variable, keeping a HashMap<AttributeName, SVGAnimatedProperty>. It was needed before to lookup a SVGAnimatedProperty for a XML DOM attribute, in order to synchronize SVG <-> XML dom properties/attributes. Instead just add a "synchronizeProperty(const QualifiedName&)" method to all SVG*Element classes. As each SVG*Element class knows about its animated properties it can just ask them to synchronize themselves - no need for any dynamic lookups anymore.
- Remove SynchronizableTypeWrapper which added more complexity for the sake of SVG <-> XML DOM synchronization, all replaced by synchronizeProperty.
- Pass around any POD objects as const references, instead of copying them for no reason.
- Clean up SVGAnimatedProperty, splitting up into SVGAnimatedProperty/PropertySynchronizer/PropertyTraits.
- Remove baseValue/setBaseValue code from SVGDocumentExtensions, not needed anymore.
... and tons of changes to all SVG*Element classes, adapting to the new way of handling animated properties.
- GNUmakefile.am: Remove Synchronizable* from build, add new SVGAnimatedPropertySynchronizer/Traits files
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSSVGPODTypeWrapper.h: Change synchronization callback signatures, as we pass around const-references now.
- dom/Element.cpp: Let updateAnimatedSVGAttribute take a QualifiedName instead of pure Strings. (WebCore::Element::getAttribute): (WebCore::Element::hasAttributes):
- dom/Element.h: (WebCore::Element::updateAnimatedSVGAttribute): (WebCore::Element::attributes):
- dom/make_names.pl: Remove SVG specific "exportString" / "exportStrings" functionality, see above.
- html/HTMLAttributeNames.in: Remove "exportString" tag from "className" attribute.
- manual-tests/svg-node-count-vs-scroll.xhtml: Added. Can be used to verify memory consumption with a lot of DOM objects.
- mathml/mathattrs.in: MathML doesn't need "exportStrings" - remove it.
- mathml/mathtags.in: Ditto.
- svg/SVGAElement.cpp: (WebCore::SVGAElement::SVGAElement): (WebCore::SVGAElement::synchronizeProperty):
- svg/SVGAElement.h:
- svg/SVGAllInOne.cpp: Remove SynchronizablePropertyController.cpp
- svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::SVGAltGlyphElement): (WebCore::SVGAltGlyphElement::synchronizeProperty):
- svg/SVGAltGlyphElement.h:
- svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
- svg/SVGAnimatedProperty.h: Rewritten, see above for details. (WebCore::SVGAnimatedPropertyTearOff::create): (WebCore::SVGAnimatedPropertyTearOff::setBaseVal): (WebCore::SVGAnimatedPropertyTearOff::setAnimVal): (WebCore::SVGAnimatedPropertyTearOff::baseVal): (WebCore::SVGAnimatedPropertyTearOff::animVal): (WebCore::SVGAnimatedPropertyTearOff::associatedAttributeName): (WebCore::SVGAnimatedPropertyTearOff::SVGAnimatedPropertyTearOff): (WebCore::SVGAnimatedPropertyTearOff::~SVGAnimatedPropertyTearOff): (WebCore::SVGAnimatedProperty::~SVGAnimatedProperty): (WebCore::SVGAnimatedProperty::SVGAnimatedProperty): (WebCore::SVGAnimatedProperty::value): (WebCore::SVGAnimatedProperty::baseValue): (WebCore::SVGAnimatedProperty::setValue): (WebCore::SVGAnimatedProperty::setBaseValue): (WebCore::SVGAnimatedProperty::shouldSynchronize): (WebCore::SVGAnimatedProperty::setShouldSynchronize):
- svg/SVGAnimatedPropertySynchronizer.h: Added. (WebCore::):
- svg/SVGAnimatedPropertyTraits.h: Added. (WebCore::):
- svg/SVGAnimatedTemplate.h: Move SVGAnimatedPropertyTraits into its own file. (WebCore::SVGAnimatedTemplate::forgetWrapper): (WebCore::lookupOrCreateWrapper):
- svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::SVGAnimationElement): (WebCore::SVGAnimationElement::synchronizeProperty):
- svg/SVGAnimationElement.h:
- svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::SVGCircleElement): (WebCore::SVGCircleElement::synchronizeProperty):
- svg/SVGCircleElement.h:
- svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::SVGClipPathElement): (WebCore::SVGClipPathElement::synchronizeProperty):
- svg/SVGClipPathElement.h:
- svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): (WebCore::SVGComponentTransferFunctionElement::synchronizeProperty):
- svg/SVGComponentTransferFunctionElement.h:
- svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::SVGCursorElement): (WebCore::SVGCursorElement::synchronizeProperty):
- svg/SVGCursorElement.h:
- svg/SVGDefsElement.cpp: (WebCore::SVGDefsElement::SVGDefsElement): (WebCore::SVGDefsElement::synchronizeProperty):
- svg/SVGDefsElement.h:
- svg/SVGDocumentExtensions.h:
- svg/SVGElement.cpp: Adapt to synchronization changes: use synchronizeProperty() call, instead of SynchronizablePropertyController. (WebCore::SVGElement::updateAnimatedSVGAttribute):
- svg/SVGElement.h: Don't store SynchronizablePropertyController anymore, it's gone. (WebCore::SVGElement::synchronizeProperty): (WebCore::SVGElement::setSynchronizedSVGAttributes):
- svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::SVGEllipseElement): (WebCore::SVGEllipseElement::synchronizeProperty):
- svg/SVGEllipseElement.h:
- svg/SVGExternalResourcesRequired.cpp:
- svg/SVGExternalResourcesRequired.h:
- svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::SVGFEBlendElement): (WebCore::SVGFEBlendElement::synchronizeProperty):
- svg/SVGFEBlendElement.h:
- svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement): (WebCore::SVGFEColorMatrixElement::synchronizeProperty):
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement): (WebCore::SVGFEComponentTransferElement::synchronizeProperty):
- svg/SVGFEComponentTransferElement.h:
- svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::SVGFECompositeElement): (WebCore::SVGFECompositeElement::parseMappedAttribute): (WebCore::SVGFECompositeElement::synchronizeProperty):
- svg/SVGFECompositeElement.h:
- svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement): (WebCore::SVGFEDiffuseLightingElement::synchronizeProperty):
- svg/SVGFEDiffuseLightingElement.h:
- svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::SVGFEDisplacementMapElement): (WebCore::SVGFEDisplacementMapElement::synchronizeProperty):
- svg/SVGFEDisplacementMapElement.h:
- svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement): (WebCore::SVGFEGaussianBlurElement::synchronizeProperty):
- svg/SVGFEGaussianBlurElement.h:
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::SVGFEImageElement): (WebCore::SVGFEImageElement::synchronizeProperty):
- svg/SVGFEImageElement.h:
- svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::SVGFELightElement): (WebCore::SVGFELightElement::synchronizeProperty):
- svg/SVGFELightElement.h:
- svg/SVGFEMergeNodeElement.cpp: (WebCore::SVGFEMergeNodeElement::SVGFEMergeNodeElement): (WebCore::SVGFEMergeNodeElement::synchronizeProperty):
- svg/SVGFEMergeNodeElement.h:
- svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::SVGFEMorphologyElement): (WebCore::SVGFEMorphologyElement::synchronizeProperty):
- svg/SVGFEMorphologyElement.h:
- svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::SVGFEOffsetElement): (WebCore::SVGFEOffsetElement::synchronizeProperty):
- svg/SVGFEOffsetElement.h:
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::SVGFESpecularLightingElement): (WebCore::SVGFESpecularLightingElement::synchronizeProperty):
- svg/SVGFESpecularLightingElement.h:
- svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::SVGFETileElement): (WebCore::SVGFETileElement::synchronizeProperty):
- svg/SVGFETileElement.h:
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement): (WebCore::SVGFETurbulenceElement::synchronizeProperty):
- svg/SVGFETurbulenceElement.h:
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::SVGFilterElement): (WebCore::SVGFilterElement::synchronizeProperty):
- svg/SVGFilterElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::SVGFilterPrimitiveStandardAttributes): (WebCore::SVGFilterPrimitiveStandardAttributes::synchronizeProperty):
- svg/SVGFilterPrimitiveStandardAttributes.h:
- svg/SVGFitToViewBox.cpp:
- svg/SVGFitToViewBox.h:
- svg/SVGFontElement.cpp: (WebCore::SVGFontElement::SVGFontElement): (WebCore::SVGFontElement::synchronizeProperty):
- svg/SVGFontElement.h:
- svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::SVGForeignObjectElement): (WebCore::SVGForeignObjectElement::synchronizeProperty):
- svg/SVGForeignObjectElement.h:
- svg/SVGGElement.cpp: (WebCore::SVGGElement::SVGGElement): (WebCore::SVGGElement::synchronizeProperty):
- svg/SVGGElement.h:
- svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::synchronizeProperty):
- svg/SVGGradientElement.h:
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::SVGImageElement): (WebCore::SVGImageElement::synchronizeProperty):
- svg/SVGImageElement.h:
- svg/SVGLineElement.cpp: (WebCore::SVGLineElement::SVGLineElement): (WebCore::SVGLineElement::synchronizeProperty):
- svg/SVGLineElement.h:
- svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::SVGLinearGradientElement): (WebCore::SVGLinearGradientElement::synchronizeProperty):
- svg/SVGLinearGradientElement.h:
- svg/SVGList.h: Adapt to const-reference changes. (WebCore::SVGPODListItem::setValue):
- svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::SVGMPathElement): (WebCore::SVGMPathElement::synchronizeProperty):
- svg/SVGMPathElement.h:
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::synchronizeProperty):
- svg/SVGMarkerElement.h:
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::synchronizeProperty):
- svg/SVGMaskElement.h:
- svg/SVGPathElement.cpp: (WebCore::SVGPathElement::SVGPathElement): (WebCore::SVGPathElement::synchronizeProperty):
- svg/SVGPathElement.h:
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::synchronizeProperty):
- svg/SVGPatternElement.h:
- svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::SVGPolyElement): (WebCore::SVGPolyElement::svgAttributeChanged): (WebCore::SVGPolyElement::synchronizeProperty):
- svg/SVGPolyElement.h:
- svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::SVGRadialGradientElement): (WebCore::SVGRadialGradientElement::synchronizeProperty):
- svg/SVGRadialGradientElement.h:
- svg/SVGRectElement.cpp: (WebCore::SVGRectElement::SVGRectElement): (WebCore::SVGRectElement::synchronizeProperty):
- svg/SVGRectElement.h:
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement): (WebCore::SVGSVGElement::synchronizeProperty):
- svg/SVGSVGElement.h:
- svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::SVGScriptElement): (WebCore::SVGScriptElement::synchronizeProperty):
- svg/SVGScriptElement.h:
- svg/SVGStopElement.cpp: (WebCore::SVGStopElement::SVGStopElement): (WebCore::SVGStopElement::synchronizeProperty):
- svg/SVGStopElement.h:
- svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::SVGStyledElement): (WebCore::SVGStyledElement::parseMappedAttribute): (WebCore::SVGStyledElement::synchronizeProperty):
- svg/SVGStyledElement.h:
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement): (WebCore::SVGStyledTransformableElement::synchronizeProperty):
- svg/SVGStyledTransformableElement.h:
- svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::SVGSwitchElement): (WebCore::SVGSwitchElement::synchronizeProperty):
- svg/SVGSwitchElement.h:
- svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::SVGSymbolElement): (WebCore::SVGSymbolElement::synchronizeProperty):
- svg/SVGSymbolElement.h:
- svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::SVGTRefElement): (WebCore::SVGTRefElement::synchronizeProperty):
- svg/SVGTRefElement.h:
- svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::SVGTextContentElement): (WebCore::SVGTextContentElement::synchronizeProperty):
- svg/SVGTextContentElement.h:
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::SVGTextElement): (WebCore::SVGTextElement::synchronizeProperty):
- svg/SVGTextElement.h:
- svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::SVGTextPathElement): (WebCore::SVGTextPathElement::synchronizeProperty):
- svg/SVGTextPathElement.h:
- svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::SVGTextPositioningElement): (WebCore::SVGTextPositioningElement::synchronizeProperty):
- svg/SVGTextPositioningElement.h:
- svg/SVGURIReference.cpp:
- svg/SVGURIReference.h:
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::SVGUseElement): (WebCore::SVGUseElement::synchronizeProperty):
- svg/SVGUseElement.h:
- svg/SVGViewElement.cpp: (WebCore::SVGViewElement::SVGViewElement): (WebCore::SVGViewElement::synchronizeProperty):
- svg/SVGViewElement.h:
- svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::SVGViewSpec):
- svg/SVGViewSpec.h: (WebCore::SVGViewSpec::contextElement):
- svg/SynchronizablePropertyController.cpp: Removed.
- svg/SynchronizablePropertyController.h: Removed.
- svg/SynchronizableTypeWrapper.h: Removed.
- svg/svgattrs.in: Remove "exportStrings" tag.
- svg/svgtags.in: Ditto.
- svg/xlinkattrs.in:
- 5:35 PM Changeset in webkit [53878] by
-
- 5 edits2 adds in trunk
WebCore: Fix for <rdar://problem/7169464> REGRESSION (r47444): PLT is 1% slower due to implementation of :valid and :invalid CSS selectors
https://bugs.webkit.org/show_bug.cgi?id=34029
Reviewed by Darin Adler.
If we never hit the valid or invalid selectors for a particular document,
then we'll skip the validity checks when deciding about style sharing.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- dom/Document.cpp: (WebCore::Document::Document):
- dom/Document.h:
(WebCore::Document::considerValidity):
(WebCore::Document::setConsiderValidity):
LayoutTests: Test for <rdar://problem/7169464> REGRESSION (r47444): PLT is 1% slower due to implementation of :valid and :invalid CSS selectors
https://bugs.webkit.org/show_bug.cgi?id=34029
Reviewed by Darin Adler.
- fast/css/pseudo-valid-dynamic-expected.txt: Added.
- fast/css/pseudo-valid-dynamic.html: Added.
- 5:31 PM Changeset in webkit [53877] by
-
- 6 edits in trunk/WebCore
Revert 53797 as it seems to be causing crashes.
https://bugs.webkit.org/show_bug.cgi?id=34153
Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-26
Reviewed by Simon Fraser.
- page/FrameView.cpp:
(WebCore::FrameView::useSlowRepaints):
(WebCore::FrameView::useSlowRepaintsIfNotOverlapped):
- page/FrameView.h:
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
- platform/ScrollView.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::destroy):
- 5:20 PM Changeset in webkit [53876] by
-
- 2 edits in trunk/WebCore
DumpRenderTree silently crashes at the end of the run because geolocationControllerClient pointer is 0.
https://bugs.webkit.org/show_bug.cgi?id=34191
Reviewed by Steve Falkenburg.
- page/GeolocationController.cpp:
(WebCore::GeolocationController::~GeolocationController): Add check for m_client being 0.
(WebCore::GeolocationController::addObserver): Ditto.
(WebCore::GeolocationController::removeObserver): Ditto.
(WebCore::GeolocationController::lastPosition): Ditto.
- 5:09 PM Changeset in webkit [53875] by
-
- 2 edits in trunk/LayoutTests
2010-01-26 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix url used in websocket-event-target.html
https://bugs.webkit.org/show_bug.cgi?id=34066
- websocket/tests/script-tests/websocket-event-target.js:
- 5:08 PM Changeset in webkit [53874] by
-
- 8 edits in trunk/WebCore
2010-01-26 Simon Fraser <Simon Fraser>
Reviewed by Adele Peterson.
Enhance externalRepresentation() to make it more useful for layer debugging
https://bugs.webkit.org/show_bug.cgi?id=34143
Enhance externalRepresentation() to output additional information about layers when certain flags are passed.
The new flags allow you to show all layers (not just those that would paint), to the structure of the z-order
and normal flow lists, and to show which layers are composited.
- WebCore.base.exp: The signature of externalRepresentation() changed.
- platform/text/TextStream.h: Add operator<<(void*)
- platform/text/TextStream.cpp: Implement operator<<(void*)
- rendering/RenderLayer.h:
- rendering/RenderLayer.cpp: (showLayerTree): New method outside the WebCore namespace, for ease of calling from gdb.
- rendering/RenderTreeAsText.h: New behavior flags for externalRepresentation().
- rendering/RenderTreeAsText.cpp: (WebCore::write): Output compositing information if requested. Also clean up some -1/1 magic numbers with an enum. (WebCore::writeLayers): If requested, show layer nesting via the z-order and normal flow lists. (WebCore::externalRepresentation): New arguments
- 5:00 PM Changeset in webkit [53873] by
-
- 3 edits in trunk/LayoutTests
Fixing for failing test on qt.
https://bugs.webkit.org/show_bug.cgi?id=34148
Reviewed by Jon Honeycutt.
Changed url in anchor tag to avoid the additional trailing slash.
- editing/pasteboard/paste-noscript-xhtml-expected.txt:
- editing/resources/htmlcontent.html:
- 4:36 PM Changeset in webkit [53872] by
-
- 2 edits in trunk/WebCore
Fixed an off-by-one error.
Reviewed by Simon Fraser.
- rendering/break_lines.cpp:
(WebCore::shouldBreakAfter):
- 4:22 PM Changeset in webkit [53871] by
-
- 6 edits5 adds in trunk
Avoid reloading iframe on re-parenting between documents.
https://bugs.webkit.org/show_bug.cgi?id=32848
Reviewed by David Levin.
WebCore:
Achieved by setting a flag on iframe element when it is a target of document.adoptNode(node) operation.
The flag prevents unload/load cycle and is reset once element is attached to a new document.
If iframe is adopted but not actually inserted into the tree, it gets unloaded by async timer
once JS yields, to avoid having active content in non-attached iframe.
Test: fast/frames/iframe-reparenting.html
- dom/Document.cpp:
(WebCore::Document::adoptNode): If the adopted node is iframe, set a remainsAliveOnRemovalFromTree on it.
- html/HTMLFrameElementBase.h:
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
(WebCore::HTMLFrameElementBase::attach): Skip actual loading of the frame if it has remainsAliveOnRemovalFromTree flag. Reset the flag.
(WebCore::HTMLFrameElementBase::willRemove): Skip unloading the frame if it has remainsAliveOnRemovalFromTree flag set.
(WebCore::HTMLFrameElementBase::setRemainsAliveOnRemovalFromTree): Set the flag, start the async timer to check if the frame was actually attached.
(WebCore::HTMLFrameElementBase::checkAttachedTimerFired):
- html/HTMLFrameOwnerElement.h:
(WebCore::HTMLFrameOwnerElement::willRemove): Move from private to protected, since it is conditionally called in HTMLFrameElementBase::willRemove now.
LayoutTests:
- fast/frames/iframe-reparenting-expected.txt: Added.
- fast/frames/iframe-reparenting.html: Added.
- fast/frames/resources/iframe-reparenting-frame1.html: Added.
- fast/frames/resources/iframe-reparenting-frame2.html: Added.
- fast/frames/resources/iframe-reparenting-iframe-content.html: Added.
- 4:09 PM Changeset in webkit [53870] by
-
- 2 edits in trunk/WebKitTools
[wx] Build fix, make sure stub function returns a value.
- 2:59 PM Changeset in webkit [53869] by
-
- 15 edits in trunk
2010-01-26 Adam Roben <Adam Roben>
No review, rolling out r53861.
http://trac.webkit.org/changeset/53861
https://bugs.webkit.org/show_bug.cgi?id=33224
Caused 2 regression tests to fail.
- fast/loader/stateobjects/document-destroyed-navigate-back-expected.txt:
- fast/loader/stateobjects/document-destroyed-navigate-back.html:
2010-01-26 Adam Roben <Adam Roben>
No review, rolling out r53861.
http://trac.webkit.org/changeset/53861
https://bugs.webkit.org/show_bug.cgi?id=33224
Caused 2 regression tests to fail.
- dom/Document.cpp: (WebCore::Document::detach): (WebCore::Document::registerHistoryItem): (WebCore::Document::unregisterHistoryItem):
- dom/Document.h:
- history/BackForwardList.cpp: (WebCore::BackForwardList::pushStateItem):
- history/BackForwardListChromium.cpp: (WebCore::BackForwardList::pushStateItem):
- history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::~HistoryItem): (WebCore::HistoryItem::setStateObject): (WebCore::HistoryItem::setDocument): (WebCore::HistoryItem::documentDetached):
- history/HistoryItem.h: (WebCore::HistoryItem::document):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::navigateWithinDocument): (WebCore::FrameLoader::loadItem):
- loader/HistoryController.cpp: (WebCore::HistoryController::updateBackForwardListForFragmentScroll): (WebCore::HistoryController::pushState): (WebCore::HistoryController::replaceState):
- loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::scheduleHistoryNavigation):
- page/History.cpp: (WebCore::History::stateObjectAdded):
- page/Page.cpp: (WebCore::Page::goToItem):
- 2:48 PM Changeset in webkit [53868] by
-
- 3 edits4 adds in trunk
<rdar://problem/7576663> Crash caused by anonymous list item
https://bugs.webkit.org/show_bug.cgi?id=34183
Reviewed by Beth Dakin.
WebCore:
Test: fast/lists/anonymous-items.html
enclosingList() and previousListItem() were DOM-based, but in order to work with anonymous
list items, they need to work with rthe render tree.
- rendering/RenderListItem.cpp:
(WebCore::isList): Factored out.
(WebCore::enclosingList): Added this variant that takes a RenderObject.
(WebCore::previousListItem): Changed to travers the render tree.
(WebCore::RenderListItem::calcValue): Use the RenderObject version of enclosingList()
(WebCore::RenderListItem::setExplicitValue): Added an assertion.
(WebCore::RenderListItem::clearExplicitValue): Ditto.
LayoutTests:
- fast/lists/anonymous-items.html: Added.
- platform/mac/fast/lists/anonymous-items-expected.checksum: Added.
- platform/mac/fast/lists/anonymous-items-expected.png: Added.
- platform/mac/fast/lists/anonymous-items-expected.txt: Added.
- 2:45 PM Changeset in webkit [53867] by
-
- 2 edits1 add in trunk/WebCore
Crash in WebKit!WebCore::RenderMenuList::itemStyle
https://bugs.webkit.org/show_bug.cgi?id=34182
<rdar://7087757>
Reviewed by Jon Honeycutt.
Added bounds checks in RenderMenuList to make sure we are
not making an out of bounds check in a vector once an option
element has been deleted. If we are out of bounds, we fall back to
a default value and return early, and in the case of itemStyle, we use a
previous option's style, if it is available.
- manual-tests/select-delete-item.html: Added.
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemText): If out of bounds check, return early.
(WebCore::RenderMenuList::itemToolTip): Ditto.
(WebCore::RenderMenuList::itemIsEnabled): Ditto.
(WebCore::RenderMenuList::itemStyle): If out of bounds check, try using the 0th index
option style, then fall back to the select's style if that option doesn't exist.
(WebCore::RenderMenuList::itemBackgroundColor): If out of bounds check, return early.
(WebCore::RenderMenuList::itemIsSeparator): Ditto.
(WebCore::RenderMenuList::itemIsLabel): Ditto.
(WebCore::RenderMenuList::itemIsSelected): Ditto.
- 2:20 PM Changeset in webkit [53866] by
-
- 1 edit in trunk/WebCore/ChangeLog
Whoops, fixerate ChangeLog.
- 2:00 PM Changeset in webkit [53865] by
-
- 7 edits in trunk/WebCore
<<<<<<< .mine
- 1:14 PM Changeset in webkit [53864] by
-
- 14 edits in trunk
2010-01-26 Steve Falkenburg <sfalken@apple.com>
Reviewed by Oliver Hunt.
Windows build references non-existent include paths
https://bugs.webkit.org/show_bug.cgi?id=34175
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- JavaScriptCore.vcproj/testapi/testapi.vcproj:
- JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
2010-01-26 Steve Falkenburg <sfalken@apple.com>
Reviewed by Oliver Hunt.
Windows build references non-existent include paths
https://bugs.webkit.org/show_bug.cgi?id=34175
- WebKit.vcproj/WebKit.vcproj:
2010-01-26 Steve Falkenburg <sfalken@apple.com>
Reviewed by Oliver Hunt.
Windows build references non-existent include paths
https://bugs.webkit.org/show_bug.cgi?id=34175
- WebCore.vcproj/QTMovieWin.vcproj:
- WebCore.vcproj/WebCoreCommon.vsprops:
2010-01-26 Steve Falkenburg <sfalken@apple.com>
Reviewed by Oliver Hunt.
Windows build references non-existent include paths
https://bugs.webkit.org/show_bug.cgi?id=34175
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/ImageDiff.vcproj:
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
- 12:20 PM Changeset in webkit [53863] by
-
- 3 edits in trunk/LayoutTests
Another attempt to get this test to pass for GTK.
Add ability for image maps to be focused via tabbing
https://bugs.webkit.org/show_bug.cgi?id=17513
- fast/events/tab-imagemap-expected.txt:
- fast/events/tab-imagemap.html:
- 12:02 PM Changeset in webkit [53862] by
-
- 3 edits2 adds in trunk/WebKitTools
[Qt] Separating out the UrlLoader from the QtLauncher in it's
own implementation and header file.
Reviewed by Ariya Hidayat.
- QtLauncher/main.cpp:
(main):
- QtLauncher/urlloader.cpp: Added.
(UrlLoader::UrlLoader):
(UrlLoader::loadNext):
(UrlLoader::init):
(UrlLoader::getUrl):
- QtLauncher/urlloader.h: Added.
- 11:30 AM Changeset in webkit [53861] by
-
- 15 edits in trunk
2010-01-25 Darin Fisher <darin@chromium.org>
Reviewed by Brady Eidson.
Chains of history items representing same-document navigation need to
always remember that association
Replace HistoryItem's Document pointer with a DocumentSequenceNumber.
During session history traversal, if the current HistoryItem and the
target HistoryItem have the same DocumentSequenceNumber, then it means
that the current Document should remain.
NOTE: To support Chromium's serialization of HistoryItems, I generate
DocumentSequenceNumbers that are unique across application launches.
DocumentSequenceNumbers are generated using a counter initialized with
the time of day.
Test: fast/loader/stateobjects/document-destroyed-navigate-back.html
- dom/Document.cpp: (WebCore::Document::detach):
- dom/Document.h:
- history/BackForwardList.cpp: (WebCore::BackForwardList::pushStateItem):
- history/BackForwardListChromium.cpp: (WebCore::BackForwardList::pushStateItem):
- history/HistoryItem.cpp: (WebCore::generateDocumentSequenceNumber): (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::~HistoryItem): (WebCore::HistoryItem::setStateObject):
- history/HistoryItem.h: (WebCore::HistoryItem::setDocumentSequenceNumber): (WebCore::HistoryItem::documentSequenceNumber):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::navigateWithinDocument): (WebCore::FrameLoader::loadItem):
- loader/HistoryController.cpp: (WebCore::HistoryController::updateBackForwardListForFragmentScroll): (WebCore::HistoryController::pushState): (WebCore::HistoryController::replaceState):
- loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::scheduleHistoryNavigation):
- page/History.cpp: (WebCore::History::stateObjectAdded):
- page/Page.cpp: (WebCore::Page::goToItem):
- 11:22 AM Changeset in webkit [53860] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-26 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Using JavaScriptCore API with a webkit vended context can result in slow script dialog
https://bugs.webkit.org/show_bug.cgi?id=34172
Make the APIShim correctly increment and decrement the timeout
entry counter.
- API/APIShims.h: (JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock): (JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock): (JSC::APICallbackShim::APICallbackShim): (JSC::APICallbackShim::~APICallbackShim):
- 11:00 AM Changeset in webkit [53859] by
-
- 3 edits in trunk/LayoutTests
One more attempt to get GTK version to pass.
Add ability for image maps to be focused via tabbing
https://bugs.webkit.org/show_bug.cgi?id=17513
- fast/events/tab-imagemap-expected.txt:
- fast/events/tab-imagemap.html:
- 10:51 AM Changeset in webkit [53858] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
Attempt to make this test pass on GTK.
Add ability for image maps to be focused via tabbing
https://bugs.webkit.org/show_bug.cgi?id=17513
- fast/events/tab-imagemap.html:
- 10:06 AM Changeset in webkit [53857] by
-
- 25 edits2 adds in trunk
Add ability for image maps to be focused via tabbing
https://bugs.webkit.org/show_bug.cgi?id=17513
Reviewed by Darin Adler.
WebCore:
Test: fast/events/tab-imagemap.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedImageMapUIElement):
(WebCore::AXObjectCache::focusedUIElementForPage):
- accessibility/AXObjectCache.h:
- accessibility/AccessibilityImageMapLink.h:
(WebCore::AccessibilityImageMapLink::areaElement):
(WebCore::AccessibilityImageMapLink::mapElement):
(WebCore::AccessibilityImageMapLink::isImageMapLink):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isImageMapLink):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::getPath):
(WebCore::HTMLAreaElement::getRect):
(WebCore::HTMLAreaElement::imageElement):
(WebCore::HTMLAreaElement::isKeyboardFocusable):
(WebCore::HTMLAreaElement::isFocusable):
(WebCore::HTMLAreaElement::dispatchBlurEvent):
(WebCore::HTMLAreaElement::updateFocusAppearance):
(WebCore::HTMLAreaElement::supportsFocus):
- html/HTMLAreaElement.h:
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):
- html/HTMLMapElement.h:
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawFocusRing):
- platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::drawFocusRing):
- platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::drawFocusRingToContext):
(WebCore::GraphicsContext::drawFocusRing):
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawFocusRing):
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::drawFocusRing):
- platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::drawFocusRing):
- platform/graphics/wince/GraphicsContextWince.cpp:
(WebCore::GraphicsContext::drawFocusRing):
- platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::drawFocusRing):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paint):
(WebCore::RenderImage::paintFocusRings):
(WebCore::RenderImage::imageMap):
- rendering/RenderImage.h:
- rendering/RenderReplaced.h:
LayoutTests:
- fast/events/resources/tabindex-focus-blur-all.js:
(test):
(testProgrammaticFocus):
- fast/events/tab-imagemap-expected.txt: Added.
- fast/events/tab-imagemap.html: Added.
- fast/events/tabindex-focus-blur-all-expected.txt:
- 8:39 AM Changeset in webkit [53856] by
-
- 6 edits in trunk/WebCore
2010-01-26 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add support for breakpoints, messages and search into the SourceFrame2.
- inspector/front-end/SourceFrame2.js: (WebInspector.SourceFrame2): (WebInspector.SourceFrame2.prototype.get executionLine): (WebInspector.SourceFrame2.prototype.set executionLine): (WebInspector.SourceFrame2.prototype.revealLine): (WebInspector.SourceFrame2.prototype.addBreakpoint): (WebInspector.SourceFrame2.prototype.removeBreakpoint): (WebInspector.SourceFrame2.prototype.sizeToFitContentHeight): (WebInspector.SourceFrame2.prototype.setContent): (WebInspector.SourceFrame2.prototype.findSearchMatches): (WebInspector.SourceFrame2.prototype.setSelection): (WebInspector.SourceFrame2.prototype._addMessageToSource): (WebInspector.SourceFrame2.prototype._addExistingBreakpointsToSource): (WebInspector.SourceFrame2.prototype._addBreakpointToSource): (WebInspector.SourceFrame2.prototype._removeBreakpointFromSource): (WebInspector.SourceFrame2.prototype._contextMenu.addConditionalBreakpoint): (WebInspector.SourceFrame2.prototype._contextMenu): (WebInspector.SourceFrame2.prototype._toggleBreakpoint): (WebInspector.SourceFrame2.prototype._editBreakpointCondition.committed): (WebInspector.SourceFrame2.prototype._editBreakpointCondition.dismissed): (WebInspector.SourceFrame2.prototype._editBreakpointCondition): (WebInspector.SourceFrame2.prototype._showBreakpointConditionPopup): (WebInspector.SourceFrame2.prototype._createConditionElement): (WebInspector.SourceFrame2.prototype._keyDown): (WebInspector.SourceFrame2.prototype._evalSelectionInCallFrame): (WebInspector.SourceFrame2.prototype._breakpointChanged): (WebInspector.SourceFrame2.prototype.resize): (WebInspector.BreakpointLineNumberDecorator.prototype.decorate): (WebInspector.BreakpointLineNumberDecorator.prototype._paintBreakpoint): (WebInspector.BreakpointLineNumberDecorator.prototype.mouseDown): (WebInspector.BreakpointLineNumberDecorator.prototype.contextMenu): (WebInspector.ExecutionLineDecorator.prototype.decorate):
- inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype.set mimeType): (WebInspector.TextEditor.prototype.set readOnly): (WebInspector.TextEditor.prototype.setDivDecoration): (WebInspector.TextEditor.prototype.reveal): (WebInspector.TextEditor.prototype.packAndRepaintAll): (WebInspector.TextEditor.prototype._updateSize): (WebInspector.TextEditor.prototype.updateCanvasSize): (WebInspector.TextEditor.prototype.repaintAll): (WebInspector.TextEditor.prototype._paintLinesContinuation): (WebInspector.TextEditor.prototype._repaintOnScroll): (WebInspector.TextEditor.prototype._mouseDown): (WebInspector.TextEditor.prototype._contextMenu): (WebInspector.TextEditor.prototype._caretForMouseEvent): (WebInspector.TextEditor.prototype._columnForOffset): (WebInspector.TextEditor.prototype._handleNavigationKey): (WebInspector.TextEditor.prototype._positionDivDecoration): (WebInspector.TextEditor.prototype._replaceSelectionWith): (WebInspector.TextEditor.prototype.setCoalescingUpdate): (WebInspector.TextEditor.prototype._handleUndo): (WebInspector.TextEditor.prototype._handleRedo): (WebInspector.TextEditor.prototype._changeFont):
- inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.set mimeType):
- inspector/front-end/inspector.css:
- inspector/front-end/textEditor.css:
- 8:33 AM Changeset in webkit [53855] by
-
- 11 edits in trunk/WebCore
2010-01-26 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hather.
Web Inspector: add methods for getting resource content from within frontend.
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getResourceContent):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetResourceContent):
- inspector/InspectorFrontend.h:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.getResourceContent):
- inspector/front-end/InspectorFrontendHostStub.js:
- 7:18 AM QtWebKitBackportingFixes edited by
- (diff)
- 7:09 AM Changeset in webkit [53854] by
-
- 2 edits in trunk/JavaScriptCore
[Qt] Fix compilation of QtScript with non-gcc compilers
Variable length stack arrays are a gcc extension. Use QVarLengthArray
as a more portable solution that still tries to allocate on the stack
first.
- qt/api/qscriptvalue_p.h:
(QScriptValuePrivate::call):
- 6:13 AM Changeset in webkit [53853] by
-
- 2 edits in trunk/JavaScriptCore
[Qt] Fix the build on platforms without JIT support.
Reviewed by Tor Arne Vestbø.
The JIT support should be determined at compile-time via wtf/Platform.h
- qt/api/QtScript.pro:
- 6:02 AM Changeset in webkit [53852] by
-
- 2 edits in trunk/WebCore
2010-01-26 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: added null check into the timeline agent getter.
- inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::retrieve):
- 5:39 AM Changeset in webkit [53851] by
-
- 2 edits in trunk/WebKit/qt
2010-01-26 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Show comboboxes on Maemo 5
https://bugs.webkit.org/show_bug.cgi?id=34088
Don't try to show the combobox by simulating a mouse event from QCursor::pos() to
get the combobox position right. The position on Maemo 5 is independent from the mouse
and there's no QCursor::pos().
- WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::show):
- 5:00 AM Changeset in webkit [53850] by
-
- 5 edits21 adds in trunk
2010-01-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
First steps of the QtScript API.
Two new classes were created; QScriptEngine and QScriptValue.
The first should encapsulate a javascript context and the second a script
value.
This API is still in development, so it isn't compiled by default.
To trigger compilation, pass --qmakearg="CONFIG+=build-qtscript" to
build-webkit.
- WebKit.pro:
2010-01-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
First steps of the QtScript API.
Two new classes were created; QScriptEngine and QScriptValue.
The first should encapsulate a javascript context and the second a script
value.
This API is still in development, so it isn't compiled by default.
To trigger compilation, pass --qmakearg="CONFIG+=build-qtscript" to
build-webkit.
- qt/api/QtScript.pro: Added.
- qt/api/qscriptconverter_p.h: Added. (QScriptConverter::toString):
- qt/api/qscriptengine.cpp: Added. (QScriptEngine::QScriptEngine): (QScriptEngine::~QScriptEngine): (QScriptEngine::evaluate): (QScriptEngine::collectGarbage):
- qt/api/qscriptengine.h: Added.
- qt/api/qscriptengine_p.cpp: Added. (QScriptEnginePrivate::QScriptEnginePrivate): (QScriptEnginePrivate::~QScriptEnginePrivate): (QScriptEnginePrivate::evaluate):
- qt/api/qscriptengine_p.h: Added. (QScriptEnginePrivate::get): (QScriptEnginePrivate::collectGarbage): (QScriptEnginePrivate::makeJSValue): (QScriptEnginePrivate::context):
- qt/api/qscriptvalue.cpp: Added. (QScriptValue::QScriptValue): (QScriptValue::~QScriptValue): (QScriptValue::isValid): (QScriptValue::isBool): (QScriptValue::isBoolean): (QScriptValue::isNumber): (QScriptValue::isNull): (QScriptValue::isString): (QScriptValue::isUndefined): (QScriptValue::isError): (QScriptValue::isObject): (QScriptValue::isFunction): (QScriptValue::toString): (QScriptValue::toNumber): (QScriptValue::toBool): (QScriptValue::toBoolean): (QScriptValue::toInteger): (QScriptValue::toInt32): (QScriptValue::toUInt32): (QScriptValue::toUInt16): (QScriptValue::call): (QScriptValue::engine): (QScriptValue::operator=): (QScriptValue::equals): (QScriptValue::strictlyEquals):
- qt/api/qscriptvalue.h: Added. (QScriptValue::):
- qt/api/qscriptvalue_p.h: Added. (QScriptValuePrivate::): (QScriptValuePrivate::get): (QScriptValuePrivate::QScriptValuePrivate): (QScriptValuePrivate::isValid): (QScriptValuePrivate::isBool): (QScriptValuePrivate::isNumber): (QScriptValuePrivate::isNull): (QScriptValuePrivate::isString): (QScriptValuePrivate::isUndefined): (QScriptValuePrivate::isError): (QScriptValuePrivate::isObject): (QScriptValuePrivate::isFunction): (QScriptValuePrivate::toString): (QScriptValuePrivate::toNumber): (QScriptValuePrivate::toBool): (QScriptValuePrivate::toInteger): (QScriptValuePrivate::toInt32): (QScriptValuePrivate::toUInt32): (QScriptValuePrivate::toUInt16): (QScriptValuePrivate::equals): (QScriptValuePrivate::strictlyEquals): (QScriptValuePrivate::assignEngine): (QScriptValuePrivate::call): (QScriptValuePrivate::engine): (QScriptValuePrivate::context): (QScriptValuePrivate::value): (QScriptValuePrivate::object): (QScriptValuePrivate::inherits): (QScriptValuePrivate::isJSBased): (QScriptValuePrivate::isNumberBased): (QScriptValuePrivate::isStringBased):
- qt/api/qtscriptglobal.h: Added.
- qt/tests/qscriptengine/qscriptengine.pro: Added.
- qt/tests/qscriptengine/tst_qscriptengine.cpp: Added. (tst_QScriptEngine::tst_QScriptEngine): (tst_QScriptEngine::~tst_QScriptEngine): (tst_QScriptEngine::init): (tst_QScriptEngine::cleanup): (tst_QScriptEngine::collectGarbage): (tst_QScriptEngine::evaluate):
- qt/tests/qscriptvalue/qscriptvalue.pro: Added.
- qt/tests/qscriptvalue/tst_qscriptvalue.cpp: Added. (tst_QScriptValue::tst_QScriptValue): (tst_QScriptValue::~tst_QScriptValue): (tst_QScriptValue::init): (tst_QScriptValue::cleanup): (tst_QScriptValue::ctor): (tst_QScriptValue::toString_data): (tst_QScriptValue::toString): (tst_QScriptValue::copyConstructor_data): (tst_QScriptValue::copyConstructor): (tst_QScriptValue::assignOperator_data): (tst_QScriptValue::assignOperator): (tst_QScriptValue::dataSharing): (tst_QScriptValue::constructors_data): (tst_QScriptValue::constructors): (tst_QScriptValue::call):
- qt/tests/tests.pri: Added.
- qt/tests/tests.pro: Added.
2010-01-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
First steps of the QtScript API.
Two new classes were created; QScriptEngine and QScriptValue.
The first should encapsulate a javascript context and the second a script
value.
This API is still in development, so it isn't compiled by default.
To trigger compilation, pass --qmakearg="CONFIG+=build-qtscript" to
build-webkit.
- docs/qtwebkit.qdocconf:
- 4:05 AM Changeset in webkit [53849] by
-
- 9 edits1 copy1 add in trunk/WebCore
2010-01-26 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Moves JSC-specific classes from bridge/jni/JNIBridge to bridge/jni/jsc/JNIBridgeJSC
https://bugs.webkit.org/show_bug.cgi?id=33958
This allows bridge/jni/JNIBridge to be used with both JSC and V8.
A later change will add the V8 equivalent of these JSC-specific classes.
No new tests, refactoring only.
- Android.jscbindings.mk: Modified. Added JNIBridgeJSC.cpp
- GNUmakefile.am: Modified. Added JNIBridgeJSC.h
- WebCore.xcodeproj/project.pbxproj: Modified. Added JNIBridgeJSC.[cpp|h]
- bridge/jni/JNIBridge.cpp: Modified. Moved JavaField and JavaArray to JNIBridgeJSC.cpp (appendClassName): Modfied. Guard calls to JSLock (JavaMethod::signature): Modfied. Guard calls to JSLock
- bridge/jni/JNIBridge.h: Modified. Moved JavaField and JavaArray to JNIBridgeJSC.h
- bridge/jni/jsc/JNIBridgeJSC.cpp: Copied from WebCore/bridge/jni/JNIBridge.cpp.
- bridge/jni/jsc/JNIBridgeJSC.h: Copied from WebCore/bridge/jni/JNIBridge.h.
- bridge/jni/jsc/JNIUtilityPrivate.cpp: Modified. Include JNIBridgeJSC.h
- bridge/jni/jsc/JavaClassJSC.h: Modified. Include JNIBridgeJSC.h
- bridge/jni/jsc/JavaInstanceJSC.cpp: Modified. Include JNIBridgeJSC.h
- 3:06 AM Changeset in webkit [53848] by
-
- 3 edits in trunk/WebCore
Unreviewed build fix.
[Qt] Fix Windows build when sqlite is not available.
- WebCore.pri:
- WebCore.pro:
- 2:44 AM QtWebKitBackportingFixes edited by
- (diff)
- 2:40 AM Changeset in webkit [53847] by
-
- 4 edits1 delete in trunk
WebCore: [Qt] JavaScript prompt is currently broken.
https://bugs.webkit.org/show_bug.cgi?id=30914
Patch by Holger Hans Peter Freyther <zecke@selfish.org> on 2010-01-26
Reviewed by Simon Hausmann.
Remove the manual test case in favor of an automated
test case in WebKit/qt/tests/qwebpage.
- manual-tests/qt/java-script-prompt.html: Removed.
WebKit/qt: [Qt] JavaScript prompt is currently broken
https://bugs.webkit.org/show_bug.cgi?id=30914
Patch by Holger Hans Peter Freyther <zecke@selfish.org> on 2010-01-26
Reviewed by Simon Hausmann.
In r52152 a patch was landed to convert a null QString
to an empty WebCore::String in case the prompt was accepted
but the default implementation returned the null QString.
The patch tried to avoid assign to result twice and
was not checking the QString if it is null but the default
value. This lead to always returning an empty string on
successful prompts. Fix it by checking the variable 'x'
for isNull.
The manual test case used didn't cover the case of non
empty input, replace it with an automatic test case that
should cover all cases.
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::runJavaScriptPrompt): Fix the bug.
- tests/qwebpage/tst_qwebpage.cpp: Add automatic test case
(JSPromptPage::JSPromptPage):
(JSPromptPage::javaScriptPrompt):
(tst_QWebPage::testJSPrompt):
- 2:18 AM Changeset in webkit [53846] by
-
- 6 edits2 moves4 adds in trunk/WebCore
2010-01-26 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Implement HTML and CSS highlighters.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/JavaScriptTokenizer.js: Removed.
- inspector/front-end/JavaScriptTokenizer.re2js: Removed.
- inspector/front-end/SourceCSSTokenizer.js: Added. (WebInspector.SourceCSSTokenizer): (WebInspector.SourceCSSTokenizer.prototype._stringToken): (WebInspector.SourceCSSTokenizer.prototype._isPropertyValue): (WebInspector.SourceCSSTokenizer.prototype.nextToken):
- inspector/front-end/SourceCSSTokenizer.re2js: Added.
- inspector/front-end/SourceHTMLTokenizer.js: Added. (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype._stringToken): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
- inspector/front-end/SourceHTMLTokenizer.re2js: Added.
- inspector/front-end/SourceJavaScriptTokenizer.js: Added. (WebInspector.SourceJavaScriptTokenizer): (WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
- inspector/front-end/SourceJavaScriptTokenizer.re2js: Added.
- inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype._highlightLines): (WebInspector.TextEditorHighlighter.Tokenizer): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.set line): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.set condition): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.get condition): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.hasCondition): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.getLexCondition): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.setLexCondition): (WebInspector.TextEditorHighlighter.Tokenizer.prototype._charAt):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 2:04 AM Changeset in webkit [53845] by
-
- 3 edits1 add in trunk
REGRESSION(r53835): Fix editing/pasteboard/paste-noscript-xhtml.xhtml
https://bugs.webkit.org/show_bug.cgi?id=34157
Reviewed by Holger Freyther.
WebCore:
Pass the FragmentScriptingPermission correctly through to the DOM
and disallow scripting elements in parseEndElement(), similar to
the libxml tokenizer change in r53835.
- dom/XMLTokenizerQt.cpp:
(WebCore::handleElementNamespaces):
(WebCore::handleElementAttributes):
(WebCore::XMLTokenizer::parseStartElement):
(WebCore::XMLTokenizer::parseEndElement):
LayoutTests:
Add Qt specific result for this test that differs from the cross-platform
result in only one character: In htmlcontent.html the href attribute value
is http://www.cnn.com, which somehow becomes http://www.cnn.com/ in the cross
platform result. With the Qt xml parser that attribute is somehow preserved
and so our result does not have the trailing slash.
- platform/qt/editing/pasteboard/paste-noscript-xhtml-expected.txt: Added.
- 1:42 AM Changeset in webkit [53844] by
-
- 2 edits2 adds5 deletes in trunk/LayoutTests
2010-01-26 Kent Tamura <tkent@chromium.org>
Reviewed by Shinichiro Hamaji.
Convert textarea-rows-cols.html to dumpAsText()
https://bugs.webkit.org/show_bug.cgi?id=34074
- fast/forms/script-tests/textarea-rows-cols.js: Added.
- fast/forms/textarea-rows-cols-expected.txt: Added.
- fast/forms/textarea-rows-cols.html:
- platform/mac/fast/forms/textarea-rows-cols-expected.checksum: Removed.
- platform/mac/fast/forms/textarea-rows-cols-expected.png: Removed.
- platform/mac/fast/forms/textarea-rows-cols-expected.txt: Removed.
- platform/qt/fast/forms/textarea-rows-cols-expected.txt: Removed.
- platform/win/fast/forms/textarea-rows-cols-expected.txt: Removed.
- 1:40 AM Changeset in webkit [53843] by
-
- 2 edits in trunk/WebCore
2010-01-26 Garret Kelly <gdk@chromium.org>
Reviewed by Eric Seidel.
Add missing declaration for the feMorphology SVG element.
https://bugs.webkit.org/show_bug.cgi?id=34151
- bindings/v8/V8DOMWrapper.cpp:
- 12:30 AM Changeset in webkit [53842] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-26
[Qt] Build fix after API changes in r53835.
No new tests needed.
- dom/XMLTokenizerQt.cpp:
(WebCore::XMLTokenizer::XMLTokenizer):
(WebCore::parseXMLDocumentFragment):
Jan 25, 2010:
- 11:36 PM Changeset in webkit [53841] by
-
- 7 edits in trunk/WebKitTools
2010-01-25 Chris Jerdonek <Chris Jerdonek>
Reviewed by Shinichiro Hamaji.
Refactored check-webkit-style by removing the file path
parameter from the style error handler functions.
- Scripts/webkitpy/style/checker.py:
- Added _default_style_error_handler() to StyleChecker class.
- Moved handle_style_error() to inside _default_style_error_handler().
- Scripts/webkitpy/style/checker_unittest.py:
- Removed file path from calls to error handler.
- Scripts/webkitpy/style/cpp_style.py:
- Removed file path from calls to error handler.
- Scripts/webkitpy/style/cpp_style_unittest.py:
- Removed file path from calls to error handler.
- Scripts/webkitpy/style/text_style.py:
- Removed file path from calls to error handler.
- Scripts/webkitpy/style/text_style_unittest.py:
- Removed file path from calls to error handler.
- 10:23 PM Changeset in webkit [53840] by
-
- 17 edits1 copy21 adds23 deletes in trunk
2010-01-22 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
Make storage events match the spec.
https://bugs.webkit.org/show_bug.cgi?id=30546
Update the storageEvent algorithm to match the change in WebCore.
- src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::storageEvent):
2010-01-22 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
Make storage events match the spec.
https://bugs.webkit.org/show_bug.cgi?id=30546
This meat of the patch I just posted is very simple. It's just making events
asynchronous, not posting them to the frame that generated them, passing a null
for the key when issuing a clear storage event, and making the events
non-cancelable/non-bubbleable...all of which are clearly stated in the spec.
The asynchronous and not posting to the frame that generated them forced me to
re-write all the layout tests that dealt with storage events. There's a lot of
code there, but I tried to be fairly careful to ensure that test coverage did
not shrink in any area.
Tests: storage/domstorage/events/basic-body-attribute.html
storage/domstorage/events/basic-setattribute.html
storage/domstorage/events/basic.html
storage/domstorage/events/case-sensitive.html
storage/domstorage/events/documentURI.html
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::enqueueStorageEvent): (WebCore::Document::storageEventTimerFired):
- dom/Document.h:
- storage/StorageEvent.cpp: (WebCore::StorageEvent::StorageEvent):
- storage/StorageEvent.idl:
- storage/StorageEventDispatcher.cpp: (WebCore::StorageEventDispatcher::dispatch):
2010-01-22 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
Make storage events match the spec.
https://bugs.webkit.org/show_bug.cgi?id=30546
This meat of the patch I just posted is very simple. It's just making events
asynchronous, not posting them to the frame that generated them, passing a null
for the key when issuing a clear storage event, and making the events
non-cancelable/non-bubbleable...all of which are clearly stated in the spec.
The asynchronous and not posting to the frame that generated them forced me to
re-write all the layout tests that dealt with storage events. There's a lot of
code there, but I tried to be fairly careful to ensure that test coverage did
not shrink in any area.
- storage/domstorage/complex-values-expected.txt:
- storage/domstorage/documentURI-expected.txt: Removed.
- storage/domstorage/documentURI.html: Removed.
- storage/domstorage/events: Added.
- storage/domstorage/events/basic-body-attribute-expected.txt: Added.
- storage/domstorage/events/basic-body-attribute.html: Added.
- storage/domstorage/events/basic-expected.txt: Added.
- storage/domstorage/events/basic-setattribute-expected.txt: Added.
- storage/domstorage/events/basic-setattribute.html: Added.
- storage/domstorage/events/basic.html: Added.
- storage/domstorage/events/case-sensitive-expected.txt: Added.
- storage/domstorage/events/case-sensitive.html: Added.
- storage/domstorage/events/documentURI-expected.txt: Added.
- storage/domstorage/events/documentURI.html: Added.
- storage/domstorage/events/resources: Added.
- storage/domstorage/events/resources/body-event-handler.html: Added.
- storage/domstorage/events/resources/eventTestHarness.js: Added.
- storage/domstorage/events/resources/setattribute-event-handler.html: Added.
- storage/domstorage/events/script-tests: Added.
- storage/domstorage/events/script-tests/TEMPLATE.html: Copied from LayoutTests/storage/domstorage/script-tests/TEMPLATE.html.
- storage/domstorage/events/script-tests/basic-body-attribute.js: Added.
- storage/domstorage/events/script-tests/basic-setattribute.js: Added.
- storage/domstorage/events/script-tests/basic.js: Added.
- storage/domstorage/events/script-tests/case-sensitive.js: Added.
- storage/domstorage/events/script-tests/documentURI.js: Added.
- storage/domstorage/localstorage/iframe-events-expected.txt: Removed.
- storage/domstorage/localstorage/iframe-events.html: Removed.
- storage/domstorage/localstorage/index-get-and-set-expected.txt:
- storage/domstorage/localstorage/index-get-and-set.html:
- storage/domstorage/localstorage/onstorage-attribute-markup-expected.txt: Removed.
- storage/domstorage/localstorage/onstorage-attribute-markup.html: Removed.
- storage/domstorage/localstorage/onstorage-attribute-setattribute-expected.txt: Removed.
- storage/domstorage/localstorage/onstorage-attribute-setattribute.html: Removed.
- storage/domstorage/localstorage/onstorage-attribute-setwindow-expected.txt: Removed.
- storage/domstorage/localstorage/onstorage-attribute-setwindow.html: Removed.
- storage/domstorage/localstorage/simple-events-expected.txt: Removed.
- storage/domstorage/localstorage/simple-events.html: Removed.
- storage/domstorage/script-tests/complex-values.js:
- storage/domstorage/script-tests/documentURI.js: Removed.
- storage/domstorage/sessionstorage/iframe-events-expected.txt: Removed.
- storage/domstorage/sessionstorage/iframe-events.html: Removed.
- storage/domstorage/sessionstorage/index-get-and-set-expected.txt:
- storage/domstorage/sessionstorage/index-get-and-set.html:
- storage/domstorage/sessionstorage/onstorage-attribute-markup-expected.txt: Removed.
- storage/domstorage/sessionstorage/onstorage-attribute-markup.html: Removed.
- storage/domstorage/sessionstorage/onstorage-attribute-setattribute-expected.txt: Removed.
- storage/domstorage/sessionstorage/onstorage-attribute-setattribute.html: Removed.
- storage/domstorage/sessionstorage/onstorage-attribute-setwindow-expected.txt: Removed.
- storage/domstorage/sessionstorage/onstorage-attribute-setwindow.html: Removed.
- storage/domstorage/sessionstorage/simple-events-expected.txt: Removed.
- storage/domstorage/sessionstorage/simple-events.html: Removed.
- storage/domstorage/window-attributes-exist-expected.txt:
- storage/domstorage/window-attributes-exist.html:
- 10:00 PM Changeset in webkit [53839] by
-
- 6 edits3 adds in trunk
<rdar://problem/7573493> Error with line break inside ?» pair of characters.
https://bugs.webkit.org/show_bug.cgi?id=17475
Reviewed by Darin Adler.
WebCore:
Test: fast/text/line-break-after-question-mark.html
Instead of unconditionally allowing lines to break after a question mark, which was intended
to mimic Internet Explorer, apply the Unicode line breaking behavior after a question mark,
with one exception in the ASCII range to match IE, namely not allowing a line break between
a question mark and a vertical line.
- rendering/break_lines.cpp:
(WebCore::shouldBreakAfter): Added a next character parameter. Changed to consult a table
for the question mark case in order to keep it fast and not require a text break iterator in
the ASCII case.
(WebCore::nextBreakablePosition): Pass the next character to shouldBreakAfter.
LayoutTests:
- fast/text/line-break-after-question-mark-expected.txt: Added.
- fast/text/line-break-after-question-mark.html: Added.
- fast/text/script-tests/line-break-after-question-mark.js: Added.
():
- platform/mac/tables/mozilla/bugs/bug6674-expected.checksum: Updated.
- platform/mac/tables/mozilla/bugs/bug6674-expected.png: Updated.
- platform/mac/tables/mozilla/bugs/bug6674-expected.txt: Updated.
- 9:57 PM Changeset in webkit [53838] by
-
- 92 edits in trunk
WebCore: Mac scrollbar thumbs were drawn with the wrong size.
https://bugs.webkit.org/show_bug.cgi?id=34049
Reviewed by Dan Bernstein.
- platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::paint):
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
LayoutTests: Rebaseline pixel tests affected by changes in scrollbar thumb size.
https://bugs.webkit.org/show_bug.cgi?id=34049
Reviewed by Dan Bernstein.
- platform/mac/compositing/overflow/overflow-scroll-expected.checksum:
- platform/mac/compositing/overflow/overflow-scroll-expected.png:
- platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
- platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- platform/mac/fast/body-propagation/overflow/002-expected.checksum:
- platform/mac/fast/body-propagation/overflow/002-expected.png:
- platform/mac/fast/body-propagation/overflow/002-xhtml-expected.checksum:
- platform/mac/fast/body-propagation/overflow/002-xhtml-expected.png:
- platform/mac/fast/body-propagation/overflow/003-declarative-expected.checksum:
- platform/mac/fast/body-propagation/overflow/003-declarative-expected.png:
- platform/mac/fast/body-propagation/overflow/003-expected.checksum:
- platform/mac/fast/body-propagation/overflow/003-expected.png:
- platform/mac/fast/body-propagation/overflow/003-xhtml-expected.checksum:
- platform/mac/fast/body-propagation/overflow/003-xhtml-expected.png:
- platform/mac/fast/body-propagation/overflow/004-declarative-expected.checksum:
- platform/mac/fast/body-propagation/overflow/004-declarative-expected.png:
- platform/mac/fast/body-propagation/overflow/004-expected.checksum:
- platform/mac/fast/body-propagation/overflow/004-expected.png:
- platform/mac/fast/body-propagation/overflow/004-xhtml-expected.checksum:
- platform/mac/fast/body-propagation/overflow/004-xhtml-expected.png:
- platform/mac/fast/body-propagation/overflow/007-declarative-expected.checksum:
- platform/mac/fast/body-propagation/overflow/007-declarative-expected.png:
- platform/mac/fast/body-propagation/overflow/007-expected.checksum:
- platform/mac/fast/body-propagation/overflow/007-expected.png:
- platform/mac/fast/body-propagation/overflow/007-xhtml-expected.checksum:
- platform/mac/fast/body-propagation/overflow/007-xhtml-expected.png:
- platform/mac/fast/clip/014-expected.checksum:
- platform/mac/fast/clip/014-expected.png:
- platform/mac/fast/forms/basic-textareas-expected.checksum:
- platform/mac/fast/forms/basic-textareas-expected.png:
- platform/mac/fast/forms/form-element-geometry-expected.checksum:
- platform/mac/fast/forms/form-element-geometry-expected.png:
- platform/mac/fast/forms/listbox-hit-test-zoomed-expected.checksum:
- platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png:
- platform/mac/fast/forms/textarea-scroll-height-expected.checksum:
- platform/mac/fast/forms/textarea-scroll-height-expected.png:
- platform/mac/fast/inline-block/tricky-baseline-expected.checksum:
- platform/mac/fast/inline-block/tricky-baseline-expected.png:
- platform/mac/fast/layers/scroll-rect-to-visible-expected.checksum:
- platform/mac/fast/layers/scroll-rect-to-visible-expected.png:
- platform/mac/fast/overflow/002-expected.checksum:
- platform/mac/fast/overflow/002-expected.png:
- platform/mac/fast/overflow/003-expected.checksum:
- platform/mac/fast/overflow/003-expected.png:
- platform/mac/fast/overflow/005-expected.checksum:
- platform/mac/fast/overflow/005-expected.png:
- platform/mac/fast/overflow/007-expected.checksum:
- platform/mac/fast/overflow/007-expected.png:
- platform/mac/fast/overflow/008-expected.checksum:
- platform/mac/fast/overflow/008-expected.png:
- platform/mac/fast/overflow/childFocusRingClip-expected.checksum:
- platform/mac/fast/overflow/childFocusRingClip-expected.png:
- platform/mac/fast/overflow/float-in-relpositioned-expected.checksum:
- platform/mac/fast/overflow/float-in-relpositioned-expected.png:
- platform/mac/fast/overflow/image-selection-highlight-expected.checksum:
- platform/mac/fast/overflow/image-selection-highlight-expected.png:
- platform/mac/fast/overflow/overflow-auto-position-absolute-expected.checksum:
- platform/mac/fast/overflow/overflow-auto-position-absolute-expected.png:
- platform/mac/fast/overflow/overflow-rtl-expected.checksum:
- platform/mac/fast/overflow/overflow-rtl-expected.png:
- platform/mac/fast/overflow/overflow-stacking-expected.checksum:
- platform/mac/fast/overflow/overflow-stacking-expected.png:
- platform/mac/fast/overflow/overflow-text-hit-testing-expected.checksum:
- platform/mac/fast/overflow/overflow-text-hit-testing-expected.png:
- platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.checksum:
- platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.png:
- platform/mac/fast/overflow/overflow-x-y-expected.checksum:
- platform/mac/fast/overflow/overflow-x-y-expected.png:
- platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum:
- platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
- platform/mac/fast/overflow/scrollbar-position-update-expected.checksum:
- platform/mac/fast/overflow/scrollbar-position-update-expected.png:
- platform/mac/fast/overflow/table-overflow-float-expected.checksum:
- platform/mac/fast/overflow/table-overflow-float-expected.png:
- platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.checksum:
- platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.png:
- platform/mac/fast/repaint/layout-state-only-positioned-expected.checksum:
- platform/mac/fast/repaint/layout-state-only-positioned-expected.png:
- platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.checksum:
- platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.png:
- platform/mac/fast/table/edge-offsets-expected.checksum:
- platform/mac/fast/table/edge-offsets-expected.png:
- platform/mac/scrollbars/key-window-not-first-responder-expected.checksum:
- platform/mac/scrollbars/key-window-not-first-responder-expected.png:
- platform/mac/svg/custom/invisible-text-after-scrolling-expected.checksum:
- platform/mac/svg/custom/invisible-text-after-scrolling-expected.png:
- platform/mac/tables/mozilla/bugs/bug149275-1-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug149275-1-expected.png:
- 9:38 PM WebKit Team edited by
- (diff)
- 9:15 PM Changeset in webkit [53837] by
-
- 2 edits in trunk/WebKitTools
Adding myself as reviewer. No review necessary.
Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-25
- Scripts/webkitpy/committers.py:
- 6:17 PM Changeset in webkit [53836] by
-
- 8 edits in trunk/WebKit/mac
Featureless build fixes.
- Misc/WebCache.mm:
(+[WebCache empty]):
- WebCoreSupport/WebApplicationCache.mm:
- WebCoreSupport/WebChromeClient.h:
- WebView/WebDataSource.mm:
(-[WebDataSource _transferApplicationCache:]):
- WebView/WebFrame.mm:
(-[WebFrame _cacheabilityDictionary]):
- WebView/WebView.mm:
(WebKitInitializeApplicationCachePathIfNecessary):
(-[WebView _close]):
- WebView/WebViewData.mm:
(-[WebViewPrivate dealloc]):
(-[WebViewPrivate finalize]):
- 6:07 PM Changeset in webkit [53835] by
-
- 7 edits3 adds in trunk
WebCore: Cleanup unwanted tags after pasting.
https://bugs.webkit.org/show_bug.cgi?id=34148
Reviewed by Darin Adler.
Test: editing/pasteboard/paste-noscript-xhtml.xhtml
- dom/Element.cpp:
(WebCore::Element::setAttributeNS):
- dom/Element.h:
- dom/XMLTokenizer.h:
- dom/XMLTokenizerLibxml2.cpp:
(WebCore::XMLTokenizer::XMLTokenizer):
(WebCore::handleElementNamespaces):
(WebCore::handleElementAttributes):
(WebCore::XMLTokenizer::startElementNs):
(WebCore::XMLTokenizer::endElementNs):
(WebCore::parseXMLDocumentFragment):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::createContextualFragment):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=34148
Reviewed by Darin Adler.
- editing/pasteboard/paste-noscript-xhtml-expected.txt: Added.
- editing/pasteboard/paste-noscript-xhtml.xhtml: Added.
- editing/resources/htmlcontent.html: Added.
- 5:24 PM Changeset in webkit [53834] by
-
- 9 edits in trunk
2010-01-25 Steve Falkenburg <sfalken@apple.com>
Reviewed by Simon Fraser.
A WebGeolocationControllerClient is leaked for every WebView
https://bugs.webkit.org/show_bug.cgi?id=34145
- WebCoreSupport/WebGeolocationControllerClient.cpp: (WebGeolocationControllerClient::geolocationDestroyed): Added.
- WebCoreSupport/WebGeolocationControllerClient.h:
2010-01-25 Steve Falkenburg <sfalken@apple.com>
Reviewed by Simon Fraser.
A WebGeolocationControllerClient is leaked for every WebView
https://bugs.webkit.org/show_bug.cgi?id=34145
- WebCoreSupport/WebGeolocationControllerClient.h:
- WebCoreSupport/WebGeolocationControllerClient.mm: (WebGeolocationControllerClient::geolocationDestroyed):
2010-01-25 Steve Falkenburg <sfalken@apple.com>
Reviewed by Simon Fraser.
A WebGeolocationControllerClient is leaked for every WebView
https://bugs.webkit.org/show_bug.cgi?id=34145
- page/GeolocationController.cpp: (WebCore::GeolocationController::~GeolocationController):
- page/GeolocationControllerClient.h:
- 5:07 PM Changeset in webkit [53833] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r52527.
- 5:03 PM Changeset in webkit [53832] by
-
- 1 edit in branches/safari-4-branch/WebCore/plugins/PluginView.cpp
Merge r53581.
- 5:02 PM Changeset in webkit [53831] by
-
- 1 edit in branches/safari-4-branch/WebCore/ChangeLog
Merge r53581.
- 4:44 PM Changeset in webkit [53830] by
-
- 5 edits1 add in branches/safari-4-branch
Merge r46792.
- 4:36 PM Changeset in webkit [53829] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r50698.
- 4:33 PM Changeset in webkit [53828] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r52073.
- 4:28 PM Changeset in webkit [53827] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r48810.
- 4:09 PM Changeset in webkit [53826] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r51877.
- 4:06 PM Changeset in webkit [53825] by
-
- 5 edits in branches/safari-4-branch/WebKit/mac
Merge r53520.
- 4:00 PM Changeset in webkit [53824] by
-
- 4 edits in branches/safari-4-branch/WebKit
Merge r53195.
- 3:55 PM Changeset in webkit [53823] by
-
- 3 edits2 adds in branches/safari-4-branch
Merge r51727.
- 3:53 PM Changeset in webkit [53822] by
-
- 2 edits in branches/safari-4-branch/JavaScriptCore
Merge r53089.
- 3:53 PM Changeset in webkit [53821] by
-
- 2 edits in branches/safari-4-branch/WebCore
Merge r51881.
- 3:52 PM Changeset in webkit [53820] by
-
- 2 edits in trunk/LayoutTests
2010-01-25 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Improve portability of select-item-background-clip.html
https://bugs.webkit.org/show_bug.cgi?id=34072
- fast/forms/select-item-background-clip.html: Calculate the pixel height at runtime.
- 3:49 PM Changeset in webkit [53819] by
-
- 2 edits in branches/safari-4-branch/WebKit/mac
Merge r51616.
- 3:47 PM Changeset in webkit [53818] by
-
- 2 edits1 add in branches/safari-4-branch/WebCore
Merge r51205.
- 3:26 PM Changeset in webkit [53817] by
-
- 13 edits in branches/safari-4-branch
Merge r52749.
- 3:20 PM Changeset in webkit [53816] by
-
- 7 edits in trunk/LayoutTests
2010-01-25 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, trivial baseline updates.
-webkit-gradient slows down scrolling when page has horizontal scrollbar
https://bugs.webkit.org/show_bug.cgi?id=19650
Update pixel baselines. They changed slightly after http://trac.webkit.org/changeset/53318/
landed.
- platform/mac/fast/gradients/border-image-gradient-expected.checksum:
- platform/mac/fast/gradients/border-image-gradient-expected.png:
- platform/mac/fast/gradients/border-image-gradient-sides-and-corners-expected.checksum:
- platform/mac/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
- platform/mac/fast/gradients/simple-gradients-expected.checksum:
- platform/mac/fast/gradients/simple-gradients-expected.png:
- 3:12 PM Changeset in webkit [53815] by
-
- 2 edits in trunk/JavaScriptCore
Fix Chromium Linux tests: the pthread functions on Linux produce segfault if they receive 0 thread handle.
After r53714, we can have 0 thread handles passed to pthread_join and pthread_detach if corresponding threads
were already terminated and their threadMap entries cleared.
Add a 0 check.
Reviewed by David Levin.
- wtf/ThreadingPthreads.cpp:
(WTF::waitForThreadCompletion):
(WTF::detachThread):
- 3:07 PM Changeset in webkit [53814] by
-
- 2 edits in trunk/WebCore
Fixed bug in positioning of scroll layer within the
parent root layer.
https://bugs.webkit.org/show_bug.cgi?id=33847
- 1:55 PM WebKit Team edited by
- (diff)
- 1:47 PM WebKit Team edited by
- (diff)
- 12:54 PM WebKit Team edited by
- Added some (unsubstantiated) claims about what I know. (diff)
- 12:37 PM Changeset in webkit [53813] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=34076
An image remains accessible via form.property syntax after being removed from document.
Fix crashing regression tests (tables/mozilla/bugs/bug4527.html et al.)
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::insertedIntoTree): Remove incorrect assertions added in the previous patch - it's mot true that m_for is always a parent; table parsing can reparent the image element, but m_form still needs to be set.
- 12:07 PM Changeset in webkit [53812] by
-
- 4 edits4 adds in trunk
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=34076
An image remains accessible via form.property syntax after being removed from document.
Tests: fast/forms/removed-image-as-property.html
fast/forms/reparented-image-as-property.html
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::~HTMLImageElement): This is called during GC - not a good time to make observable changes to DOM. (WebCore::HTMLImageElement::insertedIntoTree): This is the right place to do any work that depends on connectedness to some ancestor. We still allow for m_form to be set via constructor, which happens during parsing. (WebCore::HTMLImageElement::removedFromTree): Ditto.
- html/HTMLImageElement.h: Added removedFromTree/insertedIntoTree, moved removedFromDocument and insertedIntoDocument to private section, as they shouldn't be called directly.
- 12:03 PM Changeset in webkit [53811] by
-
- 3 edits in trunk/WebCore
2010-01-25 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Fixes misspelled words in comments.
- accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::addChildren): (WebCore::AccessibilityListBox::doAccessibilityHitTest):
- accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper detach]): (AXAttributeStringSetElement):
- bindings/js/JSDOMBinding.cpp: (WebCore::completeURL):
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlot):
- bindings/js/JSSVGPODTypeWrapper.h:
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
- bridge/NP_jsobject.cpp: (_NPN_SetException):
- bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): (JObjectWrapper::JObjectWrapper):
- bridge/objc/objc_instance.mm: (ObjcInstance::setValueOfUndefinedField): (ObjcInstance::getValueOfUndefinedField):
- css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::sortMatchedRules): (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty):
- dom/Document.cpp: (WebCore::Document::updateLayoutIgnorePendingStylesheets): (WebCore::Document::detach):
- dom/Document.h:
- dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
- dom/Element.h:
- dom/MessagePortChannel.h:
- dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::receivedTarget):
- dom/Node.cpp: (WebCore::Node::isFocusable): (WebCore::Node::shadowAncestorNode):
- dom/Node.h:
- dom/Position.cpp: (WebCore::Position::upstream):
- dom/Position.h:
- dom/Range.cpp: (WebCore::Range::processContents):
- dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor):
- editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::reconcileTextDecorationProperties): (WebCore::StyleChange::extractTextStyles): (WebCore::prepareEditingStyleToApplyAt):
- editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd):
- editing/Editor.cpp: (WebCore::Editor::learnSpelling):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._format):
- loader/Cache.cpp: (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources):
- loader/Cache.h:
- loader/CachedResource.cpp: (WebCore::CachedResource::makePurgeable):
- loader/CachedResource.h:
- loader/CachedResourceHandle.h:
- loader/DocumentLoader.h:
- loader/FTPDirectoryParser.cpp: (WebCore::parseOneFTPLine):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::didExplicitOpen):
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didCancel):
- loader/WorkerThreadableLoader.h:
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::spaceNeeded):
- notifications/NotificationPresenter.h: (WebCore::NotificationPresenter::):
- page/animation/AnimationController.cpp: (WebCore::AnimationController::updateAnimations):
- platform/LinkHash.cpp: (WebCore::cleanPath):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::calculateDrawingMode):
- platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
- platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::offsetForPosition):
- platform/graphics/mac/GraphicsLayerCA.h:
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::ensureStructuralLayer):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::doSeek): (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible): (WebCore::MediaPlayerPrivate::hasAvailableVideoFrame):
- platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL):
- platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames):
- platform/text/TextEncodingDetectorICU.cpp: (WebCore::detectTextEncoding):
- rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollByRecursively): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer):
- rendering/RenderObject.cpp: (WebCore::RenderObject::destroy):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setInnerTextValue):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::stateChanged):
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::mapLocalToContainer):
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::buildTextChunks):
- rendering/TransformState.cpp: (WebCore::TransformState::flattenWithTransform):
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::dispatchBlurEvent): (WebCore::WMLInputElement::suggestedValue):
- 11:34 AM WebKit Team edited by
- (diff)
- 11:32 AM WebKit Team edited by
- (diff)
- 11:26 AM Changeset in webkit [53810] by
-
- 2 edits in trunk/LayoutTests
2010-01-25 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Add new inspector test added in r53807 to skip
list on qt platform.
- platform/qt/Skipped:
- 11:20 AM Changeset in webkit [53809] by
-
- 62 edits in trunk/WebCore
2010-01-25 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Barth.
Fixes misspelled words in comments.
- accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::addChildren): (WebCore::AccessibilityListBox::doAccessibilityHitTest):
- accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper detach]): (AXAttributeStringSetElement):
- bindings/js/JSDOMBinding.cpp: (WebCore::completeURL):
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlot):
- bindings/js/JSSVGPODTypeWrapper.h:
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
- bridge/NP_jsobject.cpp: (_NPN_SetException):
- bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): (JObjectWrapper::JObjectWrapper):
- bridge/objc/objc_instance.mm: (ObjcInstance::setValueOfUndefinedField): (ObjcInstance::getValueOfUndefinedField):
- css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::sortMatchedRules): (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty):
- dom/Document.cpp: (WebCore::Document::updateLayoutIgnorePendingStylesheets): (WebCore::Document::detach):
- dom/Document.h:
- dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
- dom/Element.h:
- dom/MessagePortChannel.h:
- dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::receivedTarget):
- dom/Node.cpp: (WebCore::Node::isFocusable): (WebCore::Node::shadowAncestorNode):
- dom/Node.h:
- dom/Position.cpp: (WebCore::Position::upstream):
- dom/Position.h:
- dom/Range.cpp: (WebCore::Range::processContents):
- dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor):
- editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::reconcileTextDecorationProperties): (WebCore::StyleChange::extractTextStyles): (WebCore::prepareEditingStyleToApplyAt):
- editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd):
- editing/Editor.cpp: (WebCore::Editor::learnSpelling):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._format):
- loader/Cache.cpp: (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources):
- loader/Cache.h:
- loader/CachedResource.cpp: (WebCore::CachedResource::makePurgeable):
- loader/CachedResource.h:
- loader/CachedResourceHandle.h:
- loader/DocumentLoader.h:
- loader/FTPDirectoryParser.cpp: (WebCore::parseOneFTPLine):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::didExplicitOpen):
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didCancel):
- loader/WorkerThreadableLoader.h:
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::spaceNeeded):
- notifications/NotificationPresenter.h: (WebCore::NotificationPresenter::):
- page/animation/AnimationController.cpp: (WebCore::AnimationController::updateAnimations):
- platform/LinkHash.cpp: (WebCore::cleanPath):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::calculateDrawingMode):
- platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
- platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::offsetForPosition):
- platform/graphics/mac/GraphicsLayerCA.h:
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::ensureStructuralLayer):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::doSeek): (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible): (WebCore::MediaPlayerPrivate::hasAvailableVideoFrame):
- platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL):
- platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames):
- platform/text/TextEncodingDetectorICU.cpp: (WebCore::detectTextEncoding):
- rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollByRecursively): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer):
- rendering/RenderObject.cpp: (WebCore::RenderObject::destroy):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setInnerTextValue):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::stateChanged):
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::mapLocalToContainer):
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::buildTextChunks):
- rendering/TransformState.cpp: (WebCore::TransformState::flattenWithTransform):
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::dispatchBlurEvent): (WebCore::WMLInputElement::suggestedValue):
- 10:58 AM Changeset in webkit [53808] by
-
- 2 edits in trunk/WebCore
Suggested by Darin Adler.
Fixed a spelling error, tightened up some grammar.
- bindings/js/JSDOMBinding.cpp:
(WebCore::forgetDOMObject):
(WebCore::forgetDOMNode):
- 10:57 AM Changeset in webkit [53807] by
-
- 3 edits2 adds in trunk
2010-01-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Timothy Hatcher.
Test that Web Inspector doesn't change methods declared by the inspected
page.
https://bugs.webkit.org/show_bug.cgi?id=34089
- inspector/inspected-objects-not-overriden-expected.txt: Added.
- inspector/inspected-objects-not-overriden.html: Added.
2010-01-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Timothy Hatcher.
Instead of adding inspector methods to the inspected global objects
use private implementation visible from inspector code only.
https://bugs.webkit.org/show_bug.cgi?id=34089
Test: inspector/inspected-objects-not-overriden.html
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- 8:37 AM QtWebKitBackportingFixes edited by
- (diff)
- 8:06 AM Changeset in webkit [53806] by
-
- 5 edits in trunk/WebCore
2010-01-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: don't show headers/content tabs in scripts view.
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype.set headersVisible): (WebInspector.ResourceView.prototype._selectContentTab): (WebInspector.ResourceView.prototype._innerSelectContentTab):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): (WebInspector.ResourcesPanel.prototype.showResource):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
- inspector/front-end/inspector.css:
- 7:37 AM Changeset in webkit [53805] by
-
- 2 edits in trunk/LayoutTests
2010-01-25 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
[Gtk] media/video-reverse-play-duration.html fails on and off on Gtk buildbots
https://bugs.webkit.org/show_bug.cgi?id=34086
- platform/gtk/Skipped: Skipping the test, requires investigation on the failure.
- 7:24 AM Changeset in webkit [53804] by
-
- 2 edits in trunk/WebCore
2010-01-25 Simon Hausmann <Simon Hausmann>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Reduce the size of the library when compiling for Maemo5
https://bugs.webkit.org/show_bug.cgi?id=34050
Exclude the Web Inspector's qrc file in the Maemo5 build, just
like we do for the Symbian build. Saves about ~900k.
- WebCore.pro:
- 7:08 AM Changeset in webkit [53803] by
-
- 5 edits in trunk/WebCore
2010-01-25 Simon Hausmann <Simon Hausmann>
Reviewed by Kenneth Rohde Christiansen.
[Qt] In the StyledPainter determine the style from the Render and Scrollbar theme instead of from the paint device
https://bugs.webkit.org/show_bug.cgi?id=34054
Getting the style from the painter's paint device is a hack that breaks when
the paint device's style is different than the style that is used when
calculating the metries earlier when there is no painter available.
This change moves us closer to always using the same style.
- platform/qt/RenderThemeQt.cpp: (WebCore::StylePainter::StylePainter): (WebCore::StylePainter::init): (WebCore::RenderThemeQt::paintButton): (WebCore::RenderThemeQt::paintTextField): (WebCore::RenderThemeQt::paintMenuList): (WebCore::RenderThemeQt::paintMenuListButton): (WebCore::RenderThemeQt::paintSliderTrack): (WebCore::RenderThemeQt::paintMediaMuteButton): (WebCore::RenderThemeQt::paintMediaPlayButton): (WebCore::RenderThemeQt::paintMediaSliderTrack): (WebCore::RenderThemeQt::paintMediaSliderThumb):
- platform/qt/RenderThemeQt.h:
- platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paint): (WebCore::ScrollbarThemeQt::hitTest): (WebCore::ScrollbarThemeQt::shouldCenterOnThumb): (WebCore::ScrollbarThemeQt::scrollbarThickness): (WebCore::ScrollbarThemeQt::thumbLength): (WebCore::ScrollbarThemeQt::trackPosition): (WebCore::ScrollbarThemeQt::trackLength): (WebCore::ScrollbarThemeQt::paintScrollCorner): (WebCore::ScrollbarThemeQt::style):
- platform/qt/ScrollbarThemeQt.h:
- 6:42 AM Changeset in webkit [53802] by
-
- 6 edits in trunk
2010-01-25 Simon Hausmann <Simon Hausmann>
Reviewed by Kenneth Rohde Christiansen.
[Qt] In RenderThemeQt determine the QStyle from the page client instead of the page's view
https://bugs.webkit.org/show_bug.cgi?id=34053
- platform/qt/QWebPageClient.h: Add function to return the style.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::qStyle): Determine the style from the page client instead of the page's view.
2010-01-25 Simon Hausmann <Simon Hausmann>
Reviewed by Kenneth Rohde Christiansen.
[Qt] In RenderThemeQt determine the QStyle from the page client instead of the page's view
https://bugs.webkit.org/show_bug.cgi?id=34053
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::style): Implement QWebPageClient::style() and return the graphics widget's style.
- Api/qwebpage.cpp: (QWebPageWidgetClient::style): Implement QWebPageClient::style() and return the widget's style.
- 6:20 AM Changeset in webkit [53801] by
-
- 3 edits in trunk/WebCore
[Qt] Clean up code to determine palette from page client in RenderThemeQt
https://bugs.webkit.org/show_bug.cgi?id=34052
Patch by Simon Hausmann <Simon Hausmann> on 2010-01-25
Reviewed by Kenneth Christiansen.
Use the RenderTheme's associated page instead of going through the
render tree and the document.
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQt::initializeCommonQStyleOptions):
- platform/qt/RenderThemeQt.h:
- 5:56 AM QtWebKitBackportingFixes edited by
- (diff)
- 5:53 AM QtWebKitBackportingFixes edited by
- (diff)
- 5:18 AM Changeset in webkit [53800] by
-
- 2 edits in trunk
[Qt] Fix the build on Maemo5.
Reviewed by Laszlo Gombos.
https://bugs.webkit.org/show_bug.cgi?id=34051
- WebKit.pri: Disable the use of uitools, just like it's done for Symbian.
- 5:14 AM Changeset in webkit [53799] by
-
- 3 edits1 add in trunk
2010-01-25 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Simon Hausmann.
[Qt] Phone backup support for QtWebkit for Symbian devices.
https://bugs.webkit.org/show_bug.cgi?id=34077
- WebCore.pro:
2010-01-25 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Simon Hausmann.
[Qt] Phone backup support for QtWebkit for Symbian devices.
https://bugs.webkit.org/show_bug.cgi?id=34077
- symbian/backup_registration.xml: Added.
- 5:13 AM Changeset in webkit [53798] by
-
- 2 edits3 copies2 adds in trunk/LayoutTests
2010-01-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Update inspector test expectations. Line number and source
name are present only in Chromium when console message is
logged before document load is completed.
- platform/chromium/inspector/console-log-before-inspector-open-expected.txt: Added.
- platform/gtk/inspector/console-log-before-inspector-open-expected.txt: Copied from LayoutTests/inspector/console-log-before-inspector-open-expected.txt.
- platform/mac/inspector/console-log-before-inspector-open-expected.txt: Copied from LayoutTests/inspector/console-log-before-inspector-open-expected.txt.
- platform/win/inspector/console-log-before-inspector-open-expected.txt: Renamed from LayoutTests/inspector/console-log-before-inspector-open-expected.txt.
- 4:57 AM QtWebKitBackportingFixes edited by
- (diff)
- 4:37 AM Changeset in webkit [53797] by
-
- 6 edits in trunk/WebCore
2010-01-25 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Antti Koivisto.
Do not render the full frame when there is some elements with fixed positioning
https://bugs.webkit.org/show_bug.cgi?id=33150
Do not render the full frame when there is some elements with fixed positioning
https://bugs.webkit.org/show_bug.cgi?id=33150
- page/FrameView.cpp: (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::useSlowRepaintsIfNotOverlapped): (WebCore::FrameView::registerFixedPositionedObject): (WebCore::FrameView::unregisterFixedPositionedObject): (WebCore::FrameView::scrollContentsFastPath):
- page/FrameView.h:
- platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::scrollContentsFastPath):
- platform/ScrollView.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange): (WebCore::RenderObject::destroy):
- 4:20 AM WebKit Team edited by
- Fixed mangled special character and added missing quote. (diff)
- 4:16 AM WebKit Team edited by
- Added introduction and key. (diff)
- 3:43 AM WebKit Team edited by
- Restored page outline. (diff)
- 3:18 AM Changeset in webkit [53796] by
-
- 2 edits in trunk/WebKitTools
2010-01-25 Chris Jerdonek <Chris Jerdonek>
Reviewed by Adam Barth.
Improved prepare-ChangeLog so that it preserves the relative
indentation of a git commit message.
- Scripts/prepare-ChangeLog:
- Also adjusted the script so that it does not add white space characters to empty lines.
- 2:58 AM Changeset in webkit [53795] by
-
- 9 edits1 add in trunk/WebCore
2010-01-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Add support for addMessage/clearMessages to SourceFrame2.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/SourceFrame2.js: (WebInspector.SourceFrame2): (WebInspector.SourceFrame2.prototype.addMessage): (WebInspector.SourceFrame2.prototype.clearMessages): (WebInspector.SourceFrame2.prototype._incrementMessageRepeatCount): (WebInspector.SourceFrame2.prototype._addExistingMessagesToSource): (WebInspector.SourceFrame2.prototype._addMessageToSource): (WebInspector.SourceFrame2.prototype.resize):
- inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype.setDivDecoration): (WebInspector.TextEditor.prototype._lineHeight): (WebInspector.TextEditor.prototype._highlightChanged): (WebInspector.TextEditor.prototype.packAndRepaintAll): (WebInspector.TextEditor.prototype._updateSize): (WebInspector.TextEditor.prototype._repaintAll): (WebInspector.TextEditor.prototype._paint): (WebInspector.TextEditor.prototype._paintLinesContinuation): (WebInspector.TextEditor.prototype._mouseOut): (WebInspector.TextEditor.prototype._updateDivDecorations): (WebInspector.TextEditor.prototype._positionDivDecoration): (WebInspector.TextEditor.prototype._paintSelection): (WebInspector.TextEditor.prototype._replaceSelectionWith):
- inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter.prototype.updateHighlight):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- inspector/front-end/textEditor.css: Added.
- 2:37 AM Changeset in webkit [53794] by
-
- 9 edits in trunk/WebCore
2010-01-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Replace split pane with tabbed pane in resource
contents view.
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype.attach): (WebInspector.ResourceView.prototype.show): (WebInspector.ResourceView.prototype._selectTab): (WebInspector.ResourceView.prototype._selectHeadersTab): (WebInspector.ResourceView.prototype._selectContentTab):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show):
- 1:43 AM QtWebKitBackportingFixes edited by
- (diff)
- 12:45 AM WebKit Team edited by
- (diff)
- 12:02 AM WebKit Team edited by
- (diff)
Jan 24, 2010:
- 11:04 PM Changeset in webkit [53793] by
-
- 17 edits in trunk/LayoutTests
build fix: rubber-stamped by Eric Seidel.
Fix expected baselines for ruby layout tests on Windows.
- platform/win/fast/ruby/ruby-empty-rt-expected.txt:
- platform/win/fast/ruby/ruby-length-expected.txt:
- platform/win/fast/ruby/ruby-run-break-expected.txt:
- platform/win/fast/ruby/ruby-runs-expected.txt:
- platform/win/fast/ruby/ruby-runs-spans-expected.txt:
- platform/win/fast/ruby/ruby-simple-expected.txt:
- platform/win/fast/ruby/ruby-simple-rp-expected.txt:
- platform/win/fast/ruby/ruby-trailing-expected.txt:
- platform/win/fast/ruby/rubyDOM-insert-rt-expected.txt:
- platform/win/fast/ruby/rubyDOM-insert-text1-expected.txt:
- platform/win/fast/ruby/rubyDOM-insert-text2-expected.txt:
- platform/win/fast/ruby/rubyDOM-insert-text3-expected.txt:
- platform/win/fast/ruby/rubyDOM-remove-rt1-expected.txt:
- platform/win/fast/ruby/rubyDOM-remove-rt2-expected.txt:
- platform/win/fast/ruby/rubyDOM-remove-text1-expected.txt:
- platform/win/fast/ruby/rubyDOM-remove-text2-expected.txt:
- 10:21 PM Changeset in webkit [53792] by
-
- 3 edits2 adds in trunk
2010-01-24 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
Media element duration changes to zero after playing in reverse
https://bugs.webkit.org/show_bug.cgi?id=34041
Test: media/video-reverse-play-duration.html
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::didEnd): QTKit's ended notification fires at time zero when playing in reverse, so don't reset duration in that case.
2010-01-24 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
Media element duration changes to zero after playing in reverse
https://bugs.webkit.org/show_bug.cgi?id=34041
- media/video-reverse-play-duration-expected.txt: Added.
- media/video-reverse-play-duration.html: Added.
- 10:05 PM WebKit Team edited by
- (diff)
- 10:00 PM WebKit Team edited by
- (diff)
- 9:55 PM WebKit Team edited by
- (diff)
- 9:50 PM Changeset in webkit [53791] by
-
- 2 edits in trunk/LayoutTests
Bug 28420 - Re-enable ruby Windows layout tests
(https://bugs.webkit.org/show_bug.cgi?id=28420, patch 5b)
Reviewed by Maciej Stachowiak.
After creating new Latin-character-only layout tests for ruby
(https://bugs.webkit.org/show_bug.cgi?id=31865) and resolving the issue
that caused layout tests to fail then due to the addition of the ruby
layout tests (cf. https://bugs.webkit.org/show_bug.cgi?id=31200, problem
not actually caused by ruby), the ruby layout tests should als be
un-skipped for the Windows platform.
- platform/win/Skipped:
- 9:50 PM WebKit Team edited by
- (diff)
- 9:43 PM WebKit Team edited by
- (diff)
- 9:31 PM WebKit Team edited by
- (diff)
- 9:25 PM WebKit Team edited by
- (diff)
- 9:17 PM WebKit Team edited by
- (diff)
- 8:11 PM Changeset in webkit [53790] by
-
- 3 edits2 adds in trunk
2010-01-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Content with heavily nested residual style is so slow, it seems like a hang
https://bugs.webkit.org/show_bug.cgi?id=34059
<rdar://problem/7292906>
Test cast: fast/parser/residual-style-hang.html
- html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Limit the number of iterations of the main loop to 5.
The reason this limit is necessary is that otherwise, N misnested open tags followed
by N misnested close tags will cause O(N2) of work due to cloning and attaching subtrees;
at a fixed limit, the cost is at worst O(N).
The code that was in the loop originally ran exactly once - the loop was added in
r21472 to fix <https://bugs.webkit.org/show_bug.cgi?id=13603>. I have verified that
with the iteration limit, the bug is still fixed, both with the original test case
and with the layout tests tht were added.
2010-01-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Content with heavily nested residual style is so slow, it seems like a hang
https://bugs.webkit.org/show_bug.cgi?id=34059
<rdar://problem/7292906>
Test case for the above bug fix.
- fast/parser/residual-style-hang-expected.txt: Added.
- fast/parser/residual-style-hang.html: Added.
- 7:53 PM Changeset in webkit [53789] by
-
- 2 edits in trunk/JavaScriptCore
2010-01-24 Laszlo Gombos <Laszlo Gombos>
Reviewed by Maciej Stachowiak.
Refactor JITStubs.cpp so that DEFINE_STUB_FUNCTION is only used once for each function
https://bugs.webkit.org/show_bug.cgi?id=33866
Place the guard USE(JSVALUE32_64) inside the body of the DEFINE_STUB_FUNCTION
macro for those functions that are always present.
- jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
- 7:26 PM Changeset in webkit [53788] by
-
- 2 edits2 adds3 deletes in trunk/LayoutTests
2010-01-24 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Improve portability of listbox-selection-2.html
https://bugs.webkit.org/show_bug.cgi?id=33994
- Convert to dumpAsText().
- Determine the height of an item at runtime
- fast/forms/listbox-selection-2-expected.txt: Added.
- fast/forms/listbox-selection-2.html:
- fast/forms/script-tests/listbox-selection-2.js
- platform/mac/fast/forms/listbox-selection-2-expected.checksum: Removed.
- platform/mac/fast/forms/listbox-selection-2-expected.png: Removed.
- platform/mac/fast/forms/listbox-selection-2-expected.txt: Removed.
- 6:15 PM Changeset in webkit [53787] by
-
- 7 edits in trunk
2010-01-24 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsDate setter support for type=week.
https://bugs.webkit.org/show_bug.cgi?id=33986
Add setter tests to input-valueasdate-datetime.js, and update the
expectation.
- fast/forms/input-valueasdate-week-expected.txt:
- fast/forms/script-tests/input-valueasdate-week.js:
2010-01-24 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
HTMLInputElement::valueAsDate setter support for type=week.
https://bugs.webkit.org/show_bug.cgi?id=33986
Introduce ISODateTime::setMillisecondsSinceEpochForWeek() and add
Week type support to ISODateTime::toString().
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsDate): Avoid default:. (WebCore::HTMLInputElement::setValueAsDate): Add WEEK type handling and avoid default:.
- html/ISODateTime.cpp: (WebCore::offsetTo1stWeekStart): (WebCore::ISODateTime::setMillisecondsSinceEpochForWeek): (WebCore::ISODateTime::millisecondsSinceEpoch): (WebCore::ISODateTime::toString): Add Week type support and avoid default:.
- html/ISODateTime.h:
- 4:41 PM WebKit Team edited by
- (diff)
- 4:15 PM WebKit Team edited by
- (diff)
- 2:54 PM Changeset in webkit [53786] by
-
- 2 edits in trunk/LayoutTests
2010-01-24 Eric Carlson <eric.carlson@apple.com>
No review, build fix.
Only log the first 'timeupdate' event from audio-delete-while-slider-thumb-clicked.html
as the number fired can vary according to how long it takes to run the test.
- media/audio-delete-while-slider-thumb-clicked.html:
- 2:54 PM Changeset in webkit [53785] by
-
- 6 edits in trunk/WebCore
2010-01-24 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
Object Serialization assumes deserialization will always occur in the context of a webpage
https://bugs.webkit.org/show_bug.cgi?id=34056
rdar://7573833
Added ClassInfo to JSDOMGlobalObject and make the window and worker class info
inherit from it. With this in place we're able to determine whether a given
global object is a DOMGlobalObject, and then use that information to avoid
attempting to deserialize types that require the presence of the DOM.
No test as all global objects in webkit inherit from JSDOMGlobalObject.
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::):
- bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::classInfo):
- bindings/js/JSDOMWindowBase.cpp: (WebCore::):
- bindings/js/JSWorkerContextBase.cpp: (WebCore::):
- bindings/js/SerializedScriptValue.cpp: (WebCore::DeserializingTreeWalker::DeserializingTreeWalker): (WebCore::DeserializingTreeWalker::convertIfTerminal):
- 2:30 PM Changeset in webkit [53784] by
-
- 2 edits in trunk/LayoutTests
2010-01-24 Eric Seidel <eric@webkit.org>
No review.
Middle clicking the primary scroll bars on Chromium Linux triggers a paste event
https://bugs.webkit.org/show_bug.cgi?id=33062
- platform/gtk/Skipped:
- This new test fails on Gtk for unknown reasons.
- Skipping for now to make the bots green, until a Gtk person can look.
- 2:15 PM Changeset in webkit [53783] by
-
- 3 edits in trunk/WebKitTools
2010-01-24 Eric Seidel <eric@webkit.org>
No review, rolling out r53763.
http://trac.webkit.org/changeset/53763
https://bugs.webkit.org/show_bug.cgi?id=33895
Broke 20+ tests on Windows.
- Scripts/run-webkit-tests:
- Scripts/webkitdirs.pm:
- 2:05 PM WebKit Team edited by
- (diff)
- 1:05 PM Changeset in webkit [53782] by
-
- 3 edits in trunk/WebKitSite
Added to contributing code page a pointer to the preferred
license text. Also added information about copyright lines.
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=34017
- coding/contributing.html:
- css/main.css:
- Added CSS class for books.
- 11:42 AM Changeset in webkit [53781] by
-
- 4 edits in trunk/LayoutTests
2010-01-24 Simon Fraser <Simon Fraser>
No review.
Fix incorrect layout test that I checked in earlier.
- platform/mac/compositing/reflections/load-video-in-reflection-expected.checksum:
- platform/mac/compositing/reflections/load-video-in-reflection-expected.png:
- platform/mac/compositing/reflections/load-video-in-reflection-expected.txt:
- 10:22 AM Changeset in webkit [53780] by
-
- 3 edits2 adds in trunk
2010-01-24 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=34047
<rdar://problem/7573699>
Media element "endedPlayback" logic doesn't match spec
Test: media/video-timeupdate-reverse-play.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::ended): The 'ended' attribute should only be true when playback rate is positive. (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Always schedule a 'timeupdate' event when the media engine signals a time discontinuity, scheduleTimeupdateEvent will only queue an event if one hasn't already been posted for the current movie time. (WebCore::HTMLMediaElement::endedPlayback): Update to match the spec logic.
2010-01-24 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=34047
<rdar://problem/7573699>
Media element "endedPlayback" logic doesn't match spec
- media/video-timeupdate-reverse-play-expected.txt: Added.
- media/video-timeupdate-reverse-play.html: Added.
- 9:47 AM Changeset in webkit [53779] by
-
- 4 edits4 adds in trunk
2010-01-23 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Video that loads inside reflection doesn't get reflected
https://bugs.webkit.org/show_bug.cgi?id=34046
ensureCloneLayers() made an incorrect assumption that if a clone of the primaryLayer
exists already, then the structural layer and content layer can just be returned.
However, this doesn't account for the situation where a content layer may have
been create after the clone tree was last updated.
Fix by always creating the structural and clone layers on demand.
Test: compositing/reflections/load-video-in-reflection.html
- platform/graphics/mac/GraphicsLayerCA.h: Added utility method, findOrMakeClone().
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::findOrMakeClone): Utility that efficiently finds or creates a layer in a LayerMap. (WebCore::GraphicsLayerCA::ensureCloneLayers): Always look for or clone the structural and content layers, rather than relying on whether there's a primary layer clone already.
- 4:25 AM Changeset in webkit [53778] by
-
- 2 edits in trunk/WebKitTools
Rubber stamped by Eric Seidel.
More pep8 compliance.
- Scripts/webkitpy/mock_bugzillatool.py:
- 4:16 AM Changeset in webkit [53777] by
-
- 3 edits in trunk/WebKitTools
Rubber stamped by Eric Seidel.
More pep8 compliance.
- Scripts/webkitpy/executive.py:
- Scripts/webkitpy/grammar.py:
- 3:57 AM Changeset in webkit [53776] by
-
- 4 edits in trunk/WebKitTools
Rubber stamped by Eric Seidel.
More pep8 compliance.
- Scripts/webkitpy/comments.py:
- Scripts/webkitpy/committers.py:
- Scripts/webkitpy/credentials.py:
- 3:48 AM Changeset in webkit [53775] by
-
- 2 edits in trunk/WebKitTools
Rubber stamped by Eric Seidel.
Make changelogs.py pass pep8.
- Scripts/webkitpy/changelogs.py:
