Timeline



Feb 1, 2010:

11:56 PM Changeset in webkit [54210] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

2010-02-01 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control for IconDatabaseClient class
​https://bugs.webkit.org/show_bug.cgi?id=33252

Inherits the following struct from Noncopyable because it is
instantiated by 'new' and no need to be copyable:

class name - instantiated at: WebCore/'location'
class IconDatabaseClient - loader/icon/IconDatabase.cpp:89

  • loader/icon/IconDatabaseClient.h:
11:51 PM Changeset in webkit [54209] by bweinstein@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Check in new expected results for a test that has been failing on Windows
since it was originally landed. This appears to be a font issue, but commenting
on bug <​https://bugs.webkit.org/show_bug.cgi?id=34234> to make sure.

  • platform/win/fast/text/international/hebrew-vowels-expected.txt: Added.
11:46 PM Changeset in webkit [54208] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-02-01 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port MIMETypeRegistry
​https://bugs.webkit.org/show_bug.cgi?id=34220

Port MIMETypeRegistry with an extension map as other ports do.

  • platform/brew: Added.
  • platform/brew/MIMETypeRegistryBrew.cpp: Added. (WebCore::): (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
10:53 PM Changeset in webkit [54207] by dimich@chromium.org
  • 6 edits
    7 deletes in trunk

Revert r54194 that fails new test on Qt and Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=34382

10:41 PM Changeset in webkit [54206] by Chris Jerdonek
  • 6 edits
    2 adds in trunk/WebKitTools

Addressed FIXME in check-webkit-style so that the carriage-return
check will work for patches.

Reviewed by Shinichiro Hamaji.

​https://bugs.webkit.org/show_bug.cgi?id=34260

Also added support for limiting the number of errors reported
per category, per file.

  • Scripts/webkitpy/style/checker.py:
    • Added new "whitespace/carriage_return" category from common.py.
    • Added MAX_REPORTS_PER_CATEGORY dictionary.
    • Added max_reports_per_category attribute to ProcessorOptions class.
    • Refactored StyleChecker._process_file().
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated ProcessorOptionsTest tests.
    • Added test to check MAX_REPORTS_PER_CATEGORY.
  • Scripts/webkitpy/style/error_handlers.py:
    • Added support for suppressing the display of errors after reaching a per-category maximum (from max_reports_per_category).
  • Scripts/webkitpy/style/error_handlers_unittest.py:
    • Added test for suppressing error display.
  • Scripts/webkitpy/style/processors/common.py: Added.
    • Moved carriage-return check to new file.
  • Scripts/webkitpy/style/processors/common_unittest.py: Added.
    • Added unit tests for carriage-return check.
  • Scripts/webkitpy/style/unittests.py:
    • Added reference to common_unittest.py.
10:28 PM Changeset in webkit [54205] by hamaji@chromium.org
  • 19 edits
    8 adds in trunk

2010-02-01 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

Provide a way to get page number with layoutTestController
​https://bugs.webkit.org/show_bug.cgi?id=33840

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • printing/page-break-always-expected.txt: Added.
  • printing/page-break-always.html: Added.
  • printing/pageNumerForElementById-expected.txt: Added.
  • printing/pageNumerForElementById.html: Added.
  • printing/script-tests/TEMPLATE.html: Added.
  • printing/script-tests/page-break-always.js: Added. (createParagraph):
  • printing/script-tests/pageNumerForElementById.js: Added. (createParagraph):

2010-02-01 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

Provide a way to get page number with layoutTestController
​https://bugs.webkit.org/show_bug.cgi?id=33840

Test: printing/page-break-always.html

  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • page/PrintContext.cpp: (WebCore::PrintContext::pageRect): Added a getter function. (WebCore::PrintContext::computePageRects): Move its logic into computePageRectsWithPageSize. (WebCore::PrintContext::computePageRectsWithPageSize): Factored out from computePageRects for pageNumberForElement. (WebCore::enclosingBoxModelObject): Added for pageNumberForElement. (WebCore::PrintContext::pageNumberForElement): Added for testing.
  • page/PrintContext.h:

2010-02-01 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

Provide a way to get page number with layoutTestController
​https://bugs.webkit.org/show_bug.cgi?id=33840

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (-[WebFrame pageNumberForElement:element:pageWidth:]):

2010-02-01 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

Provide a way to get page number with layoutTestController
​https://bugs.webkit.org/show_bug.cgi?id=33840

  • DumpRenderTree/LayoutTestController.cpp: (pageNumberForElementByIdCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pageNumberForElementById):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::pageNumberForElementById):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pageNumberForElementById):
10:19 PM Changeset in webkit [54204] by eric@webkit.org
  • 2 edits
    2 adds in trunk/WebCore

2010-02-01 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add conversions between IntSize and AEESize
​https://bugs.webkit.org/show_bug.cgi?id=34197

Make it easy to convert between IntSize and AEESize.

  • platform/graphics/IntSize.h:
  • platform/graphics/brew/IntSizeBrew.cpp: Added. (WebCore::IntSize::IntSize): (WebCore::IntSize::operator AEESize):
9:36 PM Changeset in webkit [54203] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-02-01 Stephen White <​senorblanco@chromium.org>

Reviewed by Eric Seidel.

Fix for Pattern transformations in Chromium/Skia. This required
reworking Pattern a bit to be more like the Gradient implementation.
In particular, it now holds an m_pattern reference to the
platform-specific implementation, and passes along changes to the
m_patternSpaceTransformation, in the same way that Gradient does for
m_gradientSpaceTransformation. This is necessary since Skia creates the
platform-specific pattern (SkShader) once, rather than recreating it
on each draw.
For platforms other than Skia, m_pattern is unused, they will
continue to use the static createPlatformPattern(), and the new
notification functions are stubbed out. Other platforms can switch to
the new implementation if they so choose.

​https://bugs.webkit.org/show_bug.cgi?id=24534

Covered by svg/custom/pattern-y-offset.svg,
svg/custom/pattern-cycle-detection.svg, and many more.

  • platform/graphics/Pattern.cpp: (WebCore::Pattern::Pattern): Initializer for m_pattern. (WebCore::Pattern::~Pattern): call platformDestroy(). (WebCore::Pattern::setPatternSpaceTransform): Pass along the transform via setPlatformPatternSpaceTransform(). (WebCore::Pattern::platformDestroy): (WebCore::Pattern::setPlatformPatternSpaceTransform): Stub implementations for non-skia platforms.
  • platform/graphics/Pattern.h:
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformFillPattern): (WebCore::GraphicsContext::setPlatformStrokePattern): Call platformPattern() instead of static version. Since Pattern now owns its SkShader, no need to unref here.
  • platform/graphics/skia/PatternSkia.cpp: (WebCore::Pattern::platformDestroy): Unref the SkShader on destroy. (WebCore::Pattern::platformPattern): Create the platform pattern (SkShader) once, and cache it. (WebCore::Pattern::setPlatformPatternSpaceTransform): Set the shader's local matrix from the m_patternSpaceTransformation.
9:13 PM Changeset in webkit [54202] by dbates@webkit.org
  • 8 edits
    22 adds in trunk

2010-02-01 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=27312

Implements support for full page blocking via the X-XSS-Protection header.

Tests: http/tests/security/xssAuditor/full-block-base-href.html

http/tests/security/xssAuditor/full-block-get-from-iframe.html
http/tests/security/xssAuditor/full-block-iframe-javascript-url.html
http/tests/security/xssAuditor/full-block-iframe-no-inherit.php
http/tests/security/xssAuditor/full-block-javascript-link.html
http/tests/security/xssAuditor/full-block-link-onclick.html
http/tests/security/xssAuditor/full-block-object-tag.html
http/tests/security/xssAuditor/full-block-post-from-iframe.html
http/tests/security/xssAuditor/full-block-script-tag-with-source.html
http/tests/security/xssAuditor/full-block-script-tag.html
http/tests/security/xssAuditor/malformed-xss-protection-header.html

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::shouldFullPageBlockForXSSProtectionHeader): Added. (WebCore::XSSAuditor::findInRequest): Modified to call method XSSAuditor::shouldFullPageBlockForXSSProtectionHeader.
  • page/XSSAuditor.h: Defined method shouldFullPageBlockForXSSProtectionHeader and fixed misspelled words in large comment block.

2010-02-01 Daniel Bates <​dbates@webkit.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=27312

Tests that the header "X-XSS-Protection: full-block" leads to a full page block
when an XSS attack is detected.

  • http/tests/security/xssAuditor/full-block-base-href-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-base-href.html: Added.
  • http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-get-from-iframe.html: Added.
  • http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-iframe-javascript-url.html: Added.
  • http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-iframe-no-inherit.php: Added.
  • http/tests/security/xssAuditor/full-block-javascript-link-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-javascript-link.html: Added.
  • http/tests/security/xssAuditor/full-block-link-onclick-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-link-onclick.html: Added.
  • http/tests/security/xssAuditor/full-block-object-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-object-tag.html: Added.
  • http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-post-from-iframe.html: Added.
  • http/tests/security/xssAuditor/full-block-script-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-script-tag-with-source.html: Added.
  • http/tests/security/xssAuditor/full-block-script-tag.html: Added.
  • http/tests/security/xssAuditor/malformed-xss-protection-header-expected.txt: Added.
  • http/tests/security/xssAuditor/malformed-xss-protection-header.html: Added.
  • http/tests/security/xssAuditor/resources/echo-head-base-href.pl: Modified to optionally enable full page blocking.
  • http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pl: Ditto.
  • http/tests/security/xssAuditor/resources/echo-intertag.pl: Ditto.
  • http/tests/security/xssAuditor/resources/utilities.js: (checkIfFrameLocationMatchesURLAndCallDone): Added. (sendRequestFromIFrame): Modified to optionally call callback function when done.
9:10 PM Changeset in webkit [54201] by hamaji@chromium.org
  • 3 edits in trunk/LayoutTests

2010-02-01 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Dmitry Titov.

Convert textarea-rows-cols.html to dumpAsText()
​https://bugs.webkit.org/show_bug.cgi?id=34074

Remove checks for the size of scrollbar as scrollbar doesn't
appear on Windows.

  • fast/forms/script-tests/textarea-rows-cols.js:
  • fast/forms/textarea-rows-cols-expected.txt:
9:01 PM Changeset in webkit [54200] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2010-02-01 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port SharedTimer with IShell_SetTimerEx.
​https://bugs.webkit.org/show_bug.cgi?id=33599

As fireTime passed in setSharedTimerFireTime is the absolute time,
we must calcalute the interval by subtracting currentTime() from
fireTime and pass the result to ISHELL_SetTimerEx.

  • platform/brew/SharedTimerBrew.cpp: Added. (WebCore::invokeCallback): (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
8:56 PM Changeset in webkit [54199] by tkent@chromium.org
  • 3 edits
    3 adds in trunk

2010-02-01 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Date.UTC() should apply TimeClip operation.
​https://bugs.webkit.org/show_bug.cgi?id=34461

ECMAScript 5 15.9.4.3:

9 Return TimeClip(MakeDate(MakeDay(yr, m, dt), MakeTime(h, min, s, milli))).

  • runtime/DateConstructor.cpp: (JSC::dateUTC): Calls WTF::timeClip().

2010-02-01 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Date.UTC() should apply TimeClip operation.
​https://bugs.webkit.org/show_bug.cgi?id=34461

Add tests for corner cases of Date.UTC().

  • fast/js/date-utc-timeclip-expected.txt: Added.
  • fast/js/date-utc-timeclip.html: Added.
  • fast/js/script-tests/date-utc-timeclip.js: Added.
8:48 PM Changeset in webkit [54198] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

2010-02-01 Kent Tamura <​tkent@chromium.org>

Unreviewed. Add two more test cases which I forgot to add in r54197.
​https://bugs.webkit.org/show_bug.cgi?id=34462

  • fast/js/math-expected.txt:
  • fast/js/script-tests/math.js:
8:42 PM Changeset in webkit [54197] by tkent@chromium.org
  • 5 edits in trunk

2010-02-01 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Fix a bug that Math.round() retunrs incorrect results for huge integers
​https://bugs.webkit.org/show_bug.cgi?id=34462

  • runtime/MathObject.cpp: (JSC::mathProtoFuncRound): Avoid "arg + 0.5".

2010-02-01 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Fix a bug that Math.round() retunrs incorrect results for huge integers
​https://bugs.webkit.org/show_bug.cgi?id=34462

  • fast/js/math-expected.txt:
  • fast/js/script-tests/math.js: Add test cases for Math.round() for huge numbers.
8:13 PM Changeset in webkit [54196] by hamaji@chromium.org
  • 4 edits in trunk/WebCore

2010-02-01 Shinichiro Hamaji <​hamaji@chromium.org>

[Chromium] Unreviewed attempt to fix the chromium build.

Corresponding change: ​http://trac.webkit.org/changeset/54182

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
  • bindings/v8/ScriptController.h:
7:19 PM Changeset in webkit [54195] by hamaji@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-02-01 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed attempt to fix the broken build.

This was introduced in ​http://trac.webkit.org/changeset/54182

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::performMediaPlayerAction):
7:14 PM Changeset in webkit [54194] by dimich@chromium.org
  • 6 edits
    8 adds in trunk

When a live iframe element is moved between pages, it still depends on the old page.
​https://bugs.webkit.org/show_bug.cgi?id=34382

Reviewed by David Levin.

WebCore:

Test: fast/frames/iframe-reparenting-new-page.html

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::setName):
Move the code setting the frame name into a separate function.

(WebCore::HTMLFrameElementBase::setNameAndOpenURL):
(WebCore::HTMLFrameElementBase::updateLiveFrame):
Update frame tree, reset page in the contentFrame and re-set the name.

(WebCore::HTMLFrameElementBase::insertedIntoDocument):

  • html/HTMLFrameElementBase.h:
  • page/Frame.cpp:

(WebCore::Frame::setPage):

  • page/Frame.h: Add setPage method. It is only currently used when iframe is

moved between pages (so the ASSERT(m_ownerElement).

LayoutTests:

  • fast/frames/iframe-reparenting-new-page-expected.txt: Added.
  • fast/frames/iframe-reparenting-new-page.html: Added.
  • fast/frames/resources/iframe-reparenting-new-page-1.html: Added.
  • fast/frames/resources/iframe-reparenting-new-page-2.html: Added.
  • fast/frames/resources/iframe-reparenting-new-page-iframe.html: Added.
7:06 PM Changeset in webkit [54193] by beidson@apple.com
  • 6 edits in trunk

WebCore: Add common IRC ports to port blocking.
<rdar://problem/7593895> and ​https://bugs.webkit.org/show_bug.cgi?id=34451

Reviewed by Tim Hatcher.

  • platform/KURL.cpp:

(WebCore::portAllowed):

LayoutTests: Add common IRC ports to port blocking.
<rdar://problem/7593895> and ​https://bugs.webkit.org/show_bug.cgi?id=34451

  • platform/mac-tiger/security/block-test-expected.txt:
  • platform/mac/security/block-test-expected.txt:
  • security/block-test.html:

Reviewed by Tim Hatcher.

6:45 PM Changeset in webkit [54192] by hamaji@chromium.org
  • 2 edits in trunk/WebKitTools

2010-02-01 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed fix for an invalid function call.

check-webkit-style: Remove filename parameter from all functions where no longer used
​https://bugs.webkit.org/show_bug.cgi?id=34249

  • Scripts/webkitpy/style/checker.py:
6:43 PM Changeset in webkit [54191] by jorlow@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-01-27 Matt Perry <​mpcomplete@chromium.org>

Reviewed by Eric Seidel.

Add support for addUserScript to chromium port.

  • public/WebView.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::addUserScript): (WebKit::WebViewImpl::removeAllUserContent):
  • src/WebViewImpl.h:
6:42 PM Changeset in webkit [54190] by jorlow@chromium.org
  • 3 edits in trunk/WebCore

2010-01-29 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

[V8] Add compile time guards for IndexedDB custom functions
​https://bugs.webkit.org/show_bug.cgi?id=34368

  • bindings/v8/custom/V8IDBRequestCustom.cpp:
  • bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp:
6:07 PM QtWebKitGraphics edited by noam.rosenthal@nokia.com
(diff)
6:06 PM cssAnimTestSuite.html attached to QtWebKitGraphics by noam.rosenthal@nokia.com
Comprehensive test suite for CSS animations
6:04 PM CssAnimationTestSuite edited by noam.rosenthal@nokia.com
(diff)
6:02 PM cssAnimTestSuite.html attached to CssAnimationTestSuite by noam.rosenthal@nokia.com
6:01 PM CssAnimationTestSuite created by noam.rosenthal@nokia.com
5:48 PM Changeset in webkit [54189] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/LayoutTests

Merge r53116.

5:48 PM Changeset in webkit [54188] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/LayoutTests

Merge r53115.

5:48 PM Changeset in webkit [54187] by mrowe@apple.com
  • 7 edits in branches/safari-4-branch

Merge r53114.

5:48 PM Changeset in webkit [54186] by mrowe@apple.com
  • 1 edit
    2 adds in branches/safari-4-branch/LayoutTests

Merge r53096.

5:47 PM Changeset in webkit [54185] by mrowe@apple.com
  • 1 edit
    1 add in branches/safari-4-branch/LayoutTests

Merge r53093.

5:47 PM Changeset in webkit [54184] by mrowe@apple.com
  • 3 edits
    4 adds in branches/safari-4-branch

Merge r53078.

5:33 PM Changeset in webkit [54183] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-02-01 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port WTF's currentTime
​https://bugs.webkit.org/show_bug.cgi?id=33567

Combine GETUTCSECONDS and GETTIMEMS to calculate the number
of milliseconds since 1970/01/01 00:00:00 UTC.

  • wtf/CurrentTime.cpp: (WTF::currentTime):
5:20 PM Changeset in webkit [54182] by barraclough@apple.com
  • 25 edits
    3 adds in trunk

Bug 34346 - With JSC bindings, make processingUserGesture work with events in Isolated Worlds

WebCore:

Reviewed by Sam Weinig + Oliver Hunt.

Change HTMLMediaElement methods that require checking whether the event is a user gesture to
be passed a boolean. This may be passed from the JSC bindings (where we have an exec state),
or read from the event. Add a Flag to the IDL to mark this information is required.

  • WebCore.Video.exp:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::processingUserGesture):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::domWindowAllowPopUp):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::showModalDialog):

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::setLocation):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::processingUserGesture):
(WebCore::ScriptController::processingUserGestureEvent):
(WebCore::ScriptController::anyPageIsProcessingUserGesture):

  • bindings/js/ScriptController.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Event.cpp:

(WebCore::Event::isUserEvent):

  • dom/Event.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::removedFromDocument):
(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::pause):
(WebCore::HTMLMediaElement::beginScrubbing):
(WebCore::HTMLMediaElement::documentDidBecomeActive):
(WebCore::HTMLMediaElement::webkitEnterFullScreen):

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::isProcessingUserGesture):

  • loader/MediaDocument.cpp:

(WebCore::MediaDocument::defaultEventHandler):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::allowPopUp):

  • rendering/MediaControlElements.cpp:

(WebCore::MediaControlSeekButtonElement::defaultEventHandler):

WebKit/mac:

Reviewed by Sam Weinig + Oliver Hunt.

Pass processeing user gensture flag to media play/pause methods.

  • WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController setPlaying:]):

WebKit/win:

Reviewed by Sam Weinig + Oliver Hunt.

Pass processeing user gensture flag to media play/pause methods.

  • FullscreenVideoController.cpp:

(FullscreenVideoController::play):
(FullscreenVideoController::pause):

LayoutTests:

Reviewed by Sam Weinig.

  • http/tests/security/isolatedWorld/resources/userGestureEvents-second-window.html: Added.
  • http/tests/security/isolatedWorld/userGestureEvents-expected.txt: Added.
  • http/tests/security/isolatedWorld/userGestureEvents.html: Added.
5:17 PM Changeset in webkit [54181] by mrowe@apple.com
  • 5 edits
    3 adds in branches/safari-4-branch

Merge r51976 and the parts of r50704 that it depended on.

5:16 PM Changeset in webkit [54180] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-02-01 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Use the fallback style on Maemo 5

​https://bugs.webkit.org/show_bug.cgi?id=34376

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::RenderThemeQt): (WebCore::RenderThemeQt::fallbackStyle): (WebCore::RenderThemeQt::qStyle): (WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
  • platform/qt/RenderThemeQt.h:
5:00 PM Changeset in webkit [54179] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-01 Kavita Kanetkar <​kkanetkar@chromium.org>

Reviewed by Nate Chapin.

[V8] Making V8 generated classes' GetTemplate() function public
​https://bugs.webkit.org/show_bug.cgi?id=34026

  • bindings/scripts/CodeGeneratorV8.pm: Generated code need not depend on V8CustomBinding.h, made GetTemplate() signature public.
4:56 PM Changeset in webkit [54178] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/7044385> Crash at NetscapePlugInStreamLoader::didReceiveResponse()

Reviewed by Anders Carlsson.

The crash was caused by having two streams with a streamID of 1.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Fixed a typo. Now
correctly increments m_currentURLRequestID to account for the manual stream.
(WebKit::NetscapePluginInstanceProxy::disconnectStream): If the stream is the manual stream,
null it out instead of trying to remove it from the map. Added an assertion.
(WebKit::NetscapePluginInstanceProxy::loadRequest): Added an assertion.

4:42 PM Changeset in webkit [54177] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r51704.

4:39 PM Changeset in webkit [54176] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-02-01 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

[Qt] WinCE buildfix after r52729 and fix for Q_BIG_ENDIAN typo.
​https://bugs.webkit.org/show_bug.cgi?id=34378

  • wtf/Platform.h:
4:35 PM Changeset in webkit [54175] by steveblock@google.com
  • 3 edits
    2 adds in trunk/WebCore

Adds V8-specific JNI bridge classes
​https://bugs.webkit.org/show_bug.cgi?id=34166

Reviewed by Ariya Hidayat.

This is the V8 equivalent of bridge/jni/jsc/JNIBridgeJSC.

No new tests, build fix only.

  • Android.v8bindings.mk: Modified. Added JNIBridge.cpp and JNIBridgeV8.cpp
  • bridge/Bridge.h: Modified. Added missing include for Noncopyable.h
  • bridge/jni/v8/JNIBridgeV8.cpp: Added.

(JavaField::JavaField):

  • bridge/jni/v8/JNIBridgeV8.h: Added.

(JSC::Bindings::JavaField::name):
(JSC::Bindings::JavaField::type):
(JSC::Bindings::JavaField::getJNIType):

4:34 PM Changeset in webkit [54174] by mrowe@apple.com
  • 5 edits
    3 adds in branches/safari-4-branch

Merge r51962.

4:34 PM Changeset in webkit [54173] by mrowe@apple.com
  • 6 edits
    4 adds in branches/safari-4-branch

Merge r50110.

4:34 PM Changeset in webkit [54172] by mrowe@apple.com
  • 5 edits in branches/safari-4-branch/WebCore

Merge r50017.

4:25 PM Changeset in webkit [54171] by steveblock@google.com
  • 2 edits
    2 adds in trunk/WebCore

Adds V8-specific JNI utility functions.
​https://bugs.webkit.org/show_bug.cgi?id=33901

Reviewed by Ariya Hidayat.

This is the V8 equivalent of bridge/jni/jsc/JNIUtilityPrivate.

No new tests, build fix only.

  • Android.v8bindings.mk: Modified. Add JNIUtilityPrivate.cpp
  • bridge/jni/v8/JNIUtilityPrivate.cpp: Added.

(JSC::Bindings::convertNPVariantToJValue):
(JSC::Bindings::convertJValueToNPVariant):

  • bridge/jni/v8/JNIUtilityPrivate.h: Added.
4:23 PM Changeset in webkit [54170] by mrowe@apple.com
  • 12 edits
    12 adds in branches/safari-4-branch

Merge r52784.

4:15 PM Changeset in webkit [54169] by steveblock@google.com
  • 2 edits
    2 adds in trunk/WebCore

Adds V8 version of JavaClass
​https://bugs.webkit.org/show_bug.cgi?id=33898

Reviewed by Ariya Hidayat.

This is the V8 equivalent of bridge/jni/jsc/JavaClassJSC

No new tests, build fix only.

  • Android.v8bindings.mk: Modified. Added JavaClassV8.cpp
  • bridge/jni/v8/JavaClassV8.cpp: Added.

(JavaClass::JavaClass):
(JavaClass::~JavaClass):
(JavaClass::methodsNamed):
(JavaClass::fieldNamed):

  • bridge/jni/v8/JavaClassV8.h: Added.
4:09 PM Changeset in webkit [54168] by mrowe@apple.com
  • 12 edits
    2 adds in branches/safari-4-branch

Merge r51645.

4:09 PM Changeset in webkit [54167] by mrowe@apple.com
  • 6 edits
    2 adds in branches/safari-4-branch

Merge r50310.

4:08 PM Changeset in webkit [54166] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-02-01 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

REGRESSION: editing/selection/doubleclick-beside-cr-span.html times out on Windows
​https://bugs.webkit.org/show_bug.cgi?id=34069

Make the sleep time shorter as this test timed out on Windows bot.

  • editing/selection/doubleclick-beside-cr-span.html:
4:03 PM Changeset in webkit [54165] by steveblock@google.com
  • 3 edits
    2 adds in trunk/WebCore

Adds V8 version of JavaInstance
​https://bugs.webkit.org/show_bug.cgi?id=33951

Reviewed by Ariya Hidayat.

This is the V8 equivalent of bridge/jni/jsc/JavaInstanceJSC.
Also fixes a typo in a comment in JavaInstanceJSC.cpp.

No new tests, build fix only.

  • Android.v8bindings.mk: Modified. Added JavaInstanceV8.cpp
  • bridge/jni/jsc/JavaInstanceJSC.cpp: Modified.

(JavaInstance::invokeMethod): Modified. Fixed comment

  • bridge/jni/v8/JavaInstanceV8.cpp: Added.

(JavaInstance::JavaInstance):
(JavaInstance::~JavaInstance):
(JavaInstance::getClass):
(JavaInstance::invokeMethod):
(JObjectWrapper::JObjectWrapper):
(JObjectWrapper::~JObjectWrapper):

  • bridge/jni/v8/JavaInstanceV8.h: Added.

(JSC::Bindings::JObjectWrapper::instance):
(JSC::Bindings::JObjectWrapper::setInstance):
(JSC::Bindings::JObjectWrapper::ref):
(JSC::Bindings::JObjectWrapper::deref):
(JSC::Bindings::JavaInstance::javaInstance):
(JSC::Bindings::JavaInstance::begin):
(JSC::Bindings::JavaInstance::end):
(JSC::Bindings::JavaInstance::virtualBegin):
(JSC::Bindings::JavaInstance::virtualEnd):

3:43 PM Changeset in webkit [54164] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r47726.

3:38 PM Changeset in webkit [54163] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r51659.

3:32 PM Changeset in webkit [54162] by dumi@chromium.org
  • 5 edits in trunk/WebCore

Making sure that all in-progress transactions are rolled back on
the database thread before they're destroyed. Otherwise,
SQLiteTransaction's destructor will try to do a rollback and that
would cause an assertion failure, if the object is not destroyed
on the DB thread.

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=34152

  • platform/sql/SQLiteTransaction.cpp:

(WebCore::SQLiteTransaction::stop):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::notifyDatabaseThreadIsShuttingDown):

  • storage/SQLTransaction.h:
  • storage/SQLTransactionCoordinator.cpp:

(WebCore::SQLTransactionCoordinator::shutdown):

3:32 PM Changeset in webkit [54161] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r53813.

3:32 PM Changeset in webkit [54160] by mrowe@apple.com
  • 4 edits
    4 adds in branches/safari-4-branch

Merge r53812.

3:26 PM Changeset in webkit [54159] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-4-branch

Merge r50466.

3:25 PM Changeset in webkit [54158] by mrowe@apple.com
  • 10 edits
    4 adds in branches/safari-4-branch

Merge r50470.

3:25 PM Changeset in webkit [54157] by mrowe@apple.com
  • 3 edits in branches/safari-4-branch/WebCore

Merge r50435.

3:23 PM Changeset in webkit [54156] by weinig@apple.com
  • 3 edits in trunk/WebCore

Fix EXPERIMENTAL_SINGLE_VIEW_MODE build.

Reviewed by Beth Dakin.

  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::currentNSEvent):
(WebCore::EventHandler::currentKeyboardEvent):
(WebCore::EventHandler::mouseDown):
(WebCore::EventHandler::mouseDragged):
(WebCore::EventHandler::mouseUp):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::wheelEvent):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):

3:19 PM Changeset in webkit [54155] by eric@webkit.org
  • 5 edits in trunk

2010-02-01 Diego Gonzalez <​diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT Provide global flag ability
​https://bugs.webkit.org/show_bug.cgi?id=34418

Add the globalFlag property to the Qt LayoutTestController to allow
cross-domain indications.

  • platform/qt/Skipped:

2010-02-01 Diego Gonzalez <​diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT Provide global flag ability
​https://bugs.webkit.org/show_bug.cgi?id=34418

Add the globalFlag property to the Qt LayoutTestController to allow
cross-domain indications.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):
  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::globalFlag): (LayoutTestController::setGlobalFlag):
3:11 PM Changeset in webkit [54154] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r50083.

2:39 PM Changeset in webkit [54153] by Nate Chapin
  • 1 edit
    13 adds in trunk/WebCore

2010-02-01 Nate Chapin <Nate Chapin>

Unreviewed, Chromium build fix.

Failed to properly add new files for ​http://trac.webkit.org/changeset/54150.

  • bindings/v8/custom/V8BarInfoCustom.cpp: Added.
  • bindings/v8/custom/V8CSSRuleCustom.cpp: Added.
  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Added.
  • bindings/v8/custom/V8CSSValueCustom.cpp: Added.
  • bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Added.
  • bindings/v8/custom/V8DOMSelectionCustom.cpp: Added.
  • bindings/v8/custom/V8HTMLElementCustom.cpp: Added.
  • bindings/v8/custom/V8SVGDocumentCustom.cpp: Added.
  • bindings/v8/custom/V8SVGElementCustom.cpp: Added.
  • bindings/v8/custom/V8SVGPathSegCustom.cpp: Added.
  • bindings/v8/custom/V8ScreenCustom.cpp: Added.
  • bindings/v8/custom/V8StyleSheetCustom.cpp: Added.
  • bindings/v8/custom/V8WebGLArrayCustom.cpp: Added.
2:29 PM Changeset in webkit [54152] by mpcomplete@chromium.org
  • 7 edits in trunk

Add support for addUserScript to chromium port.

2:20 PM Changeset in webkit [54151] by eric.carlson@apple.com
  • 3 edits in trunk/WebCore

2010-02-01 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=34448
<rdar://problem/7598130>

RenderVideo::intrinsicSizeChanged infinite recursion

  • rendering/RenderImage.h: (WebCore::RenderImage::intrinsicSizeChanged): Make protected instead of private so it can

be called by RenderVideo.

  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::intrinsicSizeChanged): Call RenderMedia::intrinsicSizeChanged, not

RenderVideo::intrinsicSizeChanged.

(WebCore::RenderVideo::imageChanged): Call RenderMedia::imageChanged instead of

RenderImage::imageChanged.

2:12 PM Changeset in webkit [54150] by Nate Chapin
  • 33 edits in trunk/WebCore

2010-02-01 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

[V8] Generate toV8() converter for most WebCore->V8 conversions,
and defined custom converters in their respective V8<class>Custom.cpp.

Old converters in V8DOMWrapper will be deleted in a later patch.

​https://bugs.webkit.org/show_bug.cgi?id=32563

  • Android.v8bindings.mk:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Collection.h:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8BarInfoCustom.cpp: Added.
  • bindings/v8/custom/V8CSSRuleCustom.cpp: Added.
  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Added.
  • bindings/v8/custom/V8CSSValueCustom.cpp: Added.
  • bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Added.
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
  • bindings/v8/custom/V8ConsoleCustom.cpp:
  • bindings/v8/custom/V8DOMSelectionCustom.cpp: Added.
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp:
  • bindings/v8/custom/V8ElementCustom.cpp:
  • bindings/v8/custom/V8EventCustom.cpp:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLElementCustom.cpp: Added.
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
  • bindings/v8/custom/V8HistoryCustom.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:
  • bindings/v8/custom/V8NavigatorCustom.cpp:
  • bindings/v8/custom/V8NodeCustom.cpp:
  • bindings/v8/custom/V8SVGDocumentCustom.cpp: Added.
  • bindings/v8/custom/V8SVGElementCustom.cpp: Added.
  • bindings/v8/custom/V8SVGPathSegCustom.cpp: Added.
  • bindings/v8/custom/V8ScreenCustom.cpp: Added.
  • bindings/v8/custom/V8StyleSheetCustom.cpp: Added.
  • bindings/v8/custom/V8TreeWalkerCustom.cpp:
  • bindings/v8/custom/V8WebGLArrayCustom.cpp: Added.
  • bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  • bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
  • dom/make_names.pl: Add options to generate wrapper factory for V8 bindings.
2:06 PM Changeset in webkit [54149] by bweinstein@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Rubber-stamped by Oliver Hunt.

Check in (failing) expected results for fast/dom/Window/window-postmessage-clone-frames.
This fails because of <rdar://problem/5230396> eventSender.beginDragWithFiles is unimplemented.

  • platform/win/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added.
2:03 PM WebKit Team edited by hamaji@chromium.org
minor fix for quotations (diff)
2:02 PM Changeset in webkit [54148] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-02-01 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: lazy-load textual resources to avoid UI hangup
​https://bugs.webkit.org/show_bug.cgi?id=34332

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._innerSelectContentTab):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.show): (WebInspector.SourceView.prototype.contentTabSelected):
1:53 PM Changeset in webkit [54147] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2010-02-01 Eric Carlson <​eric.carlson@apple.com>

No review, build fix.

​https://bugs.webkit.org/show_bug.cgi?id=34447
http/tests/media/video-referer.html fails on Windows

  • platform/win/Skipped:
1:35 PM Changeset in webkit [54146] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed trivial fix.
Platform dependent expected file updated after r54143.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
1:21 PM Changeset in webkit [54145] by beidson@apple.com
  • 11 edits
    2 adds in trunk

Crash in Safari opening new tabs to "same page"
<rdar://problem/7593857> and ​https://bugs.webkit.org/show_bug.cgi?id=34444

Reviewed by Adele Peterson.

WebCore:

Test: fast/loader/crash-copying-backforwardlist.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadItem): Null check currentItem().

  • page/Page.cpp:

(WebCore::Page::goToItem): Ditto.

WebKitTools:

Add a mode (Mac-only for now) that exercises the WebView SPI _loadBackForwardListFromOtherView:

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(setNewWindowsCopyBackForwardListCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::newWindowsCopyBackForwardList):
(LayoutTestController::setNewWindowsCopyBackForwardList):

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:createWebViewWithRequest:]):

LayoutTests:

  • fast/loader/crash-copying-backforwardlist-expected.txt: Added.
  • fast/loader/crash-copying-backforwardlist.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
1:09 PM Changeset in webkit [54144] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

[wx] Remove unused file that doesn't seem to belong to the port.

​https://bugs.webkit.org/show_bug.cgi?id=34445

12:48 PM Changeset in webkit [54143] by eric.carlson@apple.com
  • 12 edits in trunk

2010-02-01 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adele Peterson.

Fullscreen API should be on HTMLVideoElement
​https://bugs.webkit.org/show_bug.cgi?id=34438


Move fullscreen DOM APIs from HTMLMediaElement to HTMLVideoElement.

  • html/HTMLMediaElement.cpp:
  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::paint): Removed outdated FIXME. (WebCore::HTMLVideoElement::paintCurrentFrameInContext): Ditto. (WebCore::HTMLVideoElement::webkitEnterFullScreen): Moved from HTMLMediaElement. (WebCore::HTMLVideoElement::webkitExitFullScreen): Ditto. (WebCore::HTMLVideoElement::webkitSupportsFullscreen): Ditto. (WebCore::HTMLVideoElement::webkitDisplayingFullscreen): Ditto.
  • html/HTMLVideoElement.h:
  • html/HTMLVideoElement.idl:

2010-02-01 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adele Peterson.

Fullscreen API should be on HTMLVideoElement
​https://bugs.webkit.org/show_bug.cgi?id=34438

Update fullscreen tests now that <audio> doesn't have fullscreen API.

  • fast/dom/Window/window-properties-expected.txt:
  • media/media-fullscreen-inline-expected.txt:
  • media/media-fullscreen-not-in-document-expected.txt:
  • media/media-fullscreen.js: (buttonClickHandler): (canplaythrough):
12:05 PM Changeset in webkit [54142] by carol.szabo@nokia.com
  • 2 edits in trunk/WebKitTools

2010-02-01 Carol Szabo <​carol.szabo@nokia.com>

Unreviewed.

Add myself to list of committers.

  • Scripts/webkitpy/committers.py:
12:04 PM Changeset in webkit [54141] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-02-01 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Structure not accounting for anonymous slots when computing property storage size
​https://bugs.webkit.org/show_bug.cgi?id=34441

Previously any Structure with anonymous storage would have a property map, so we
were only including anonymous slot size if there was a property map. Given this
is no longer the case we should always include the anonymous slot count in the
property storage size.

  • runtime/Structure.h: (JSC::Structure::propertyStorageSize):
10:59 AM Changeset in webkit [54140] by Nate Chapin
  • 2 edits in trunk/WebKitTools

2010-02-01 Nate Chapin <Nate Chapin>

Rubber-stamped by David Levin.

Add myself to reviewer list.

  • Scripts/webkitpy/committers.py:
10:44 AM Changeset in webkit [54139] by pfeldman@chromium.org
  • 7 edits in trunk/WebCore

2010-02-01 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Syntax highlighting in source view of
Resources pane stops half-way.

There were two problems here: (1) styles for html highlighter were not
added into the css file (they used to be injected manually in the
SourceFrame before). (2) 'Tag' needed to be lexer's state, not parser's.
Otherwise unbalanced quotes in the text nodes were matching too match
into the string tokens.

​https://bugs.webkit.org/show_bug.cgi?id=34359

  • inspector/front-end/NativeTextViewer.js: (WebInspector.NativeTextViewer.prototype._createLineDivs): (WebInspector.NativeTextViewer.prototype._lineHeight): (WebInspector.NativeTextViewer.prototype.initFontMetrics):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createEditorIfNeeded):
  • inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
  • inspector/front-end/SourceHTMLTokenizer.re2js:
  • inspector/front-end/TextEditor.js: (WebInspector.TextEditor.prototype.initFontMetrics): (WebInspector.TextEditor.prototype._registerShortcuts):
  • inspector/front-end/inspectorSyntaxHighlight.css:
10:40 AM WebKit Team edited by Nate Chapin
(diff)
10:35 AM Changeset in webkit [54138] by benm@google.com
  • 6 edits
    3 deletes in trunk

ScriptCallFrame's do not get line numbers/source id's if the caller is unkown.
​https://bugs.webkit.org/show_bug.cgi?id=34335

Reviewed by Darin Adler.

WebCore:

  • bindings/js/ScriptCallStack.cpp:

(WebCore::ScriptCallStack::ScriptCallStack): If the caller is unknown, the line number and source information is still availble so pass it to the ScriptCallFrame being constructed.

LayoutTests:

Update layout tests that did not have source and line number information for their console messages, as this information is now available to the ScriptCallFrame and thus can be passed to the inspector, for example.

  • fast/js/console-non-string-values-expected.txt: Add console line number/source.
  • userscripts/script-not-run-for-fragments-expected.txt: ditto.
  • userscripts/script-run-at-start-expected.txt: ditto.
  • platform/gtk/inspector/console-log-before-inspector-open-expected.txt: Removed as platform workarounds no longer necessary.
  • platform/mac/inspector/console-log-before-inspector-open-expected.txt: ditto.
  • platform/win/inspector/console-log-before-inspector-open-expected.txt: ditto.
10:07 AM Changeset in webkit [54137] by krit@webkit.org
  • 32 edits
    2 adds in trunk/WebCore

2010-02-01 Dirk Schulze <​krit@webkit.org>

Reviewed by Simon Fraser.

Add back an AffineTransform class for use by SVG
​https://bugs.webkit.org/show_bug.cgi?id=33750

These are the first steps on reimplementing AffineTransform. Unlike
the old affine code, this one is platform independent like TransformationMatrix.
AffineTransform has the benefit, that it stores just 6 doubles instead of
16 in TransformationMatrix. The calculations of transformations are not that
complex and can improve the memory usage and speed of SVG.
AffineTransform can be used by HTML Canvas3D or SVG, since they are 2D related (at
least for the moment).
HTML Canvas is the first that makes use of the new AffineTransform. Next patches
will introduce the affine code to SVG.

No new tests. The new AffineTransformation code is tested by fast/canvas.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::isPointInPath): (WebCore::CanvasRenderingContext2D::willDraw):
  • html/canvas/CanvasRenderingContext2D.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Path.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::transform):
  • platform/graphics/cairo/TransformationMatrixCairo.cpp: (WebCore::AffineTransform::operator cairo_matrix_t):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/cg/PathCG.cpp: (WebCore::Path::transform):
  • platform/graphics/cg/TransformationMatrixCG.cpp: (WebCore::AffineTransform::operator CGAffineTransform):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/haiku/PathHaiku.cpp: (WebCore::Path::transform):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::transform):
  • platform/graphics/qt/TransformationMatrixQt.cpp: (WebCore::AffineTransform::operator QTransform):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/skia/PathSkia.cpp: (WebCore::Path::transform):
  • platform/graphics/skia/TransformationMatrixSkia.cpp: (WebCore::AffineTransform::operator SkMatrix):
  • platform/graphics/transforms/AffineTransform.cpp: Added. (WebCore::affineTransformDecompose): (WebCore::affineTransformCompose): (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::reset): (WebCore::AffineTransform::setMatrix): (WebCore::AffineTransform::isIdentity): (WebCore::AffineTransform::det): (WebCore::AffineTransform::isInvertible): (WebCore::AffineTransform::inverse): (WebCore::AffineTransform::multiply): (WebCore::AffineTransform::multLeft): (WebCore::AffineTransform::rotate): (WebCore::AffineTransform::scale): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::scaleNonUniform): (WebCore::AffineTransform::rotateFromVector): (WebCore::AffineTransform::flipX): (WebCore::AffineTransform::flipY): (WebCore::AffineTransform::shear): (WebCore::AffineTransform::skew): (WebCore::AffineTransform::skewX): (WebCore::AffineTransform::skewY): (WebCore::makeMapBetweenRects): (WebCore::AffineTransform::map): (WebCore::AffineTransform::mapPoint): (WebCore::AffineTransform::mapRect): (WebCore::AffineTransform::blend): (WebCore::AffineTransform::toTransformationMatrix):
  • platform/graphics/transforms/AffineTransform.h: Added. (WebCore::AffineTransform::a): (WebCore::AffineTransform::setA): (WebCore::AffineTransform::b): (WebCore::AffineTransform::setB): (WebCore::AffineTransform::c): (WebCore::AffineTransform::setC): (WebCore::AffineTransform::d): (WebCore::AffineTransform::setD): (WebCore::AffineTransform::e): (WebCore::AffineTransform::setE): (WebCore::AffineTransform::f): (WebCore::AffineTransform::setF): (WebCore::AffineTransform::operator== ): (WebCore::AffineTransform::operator!=): (WebCore::AffineTransform::operator*=): (WebCore::AffineTransform::operator*): (WebCore::AffineTransform::setMatrix):
  • platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/wx/PathWx.cpp: (WebCore::Path::transform):
  • platform/graphics/wx/TransformationMatrixWx.cpp: (WebCore::AffineTransform::operator wxGraphicsMatrix):
8:22 AM Changeset in webkit [54136] by Philippe Normand
  • 12 edits in trunk

2010-01-29 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] set playbin mute property depending on volume value
​https://bugs.webkit.org/show_bug.cgi?id=31586

New API in MediaPlayer for mute control. 3 new methods are
introduced:

  • bool supportsMuting() const;
  • bool muted() const;
  • void setMuted(bool);

Platform MediaPlayer implementations can support it easily if the
underlying sound daemon/API supports muting (eg. not only setting
volume to 0) like PulseAudio for instance on Linux. At the moment
the only player supporting this new API is the
MediaPlayerPrivateGStreamer.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setMuted): (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): (WebCore::HTMLMediaElement::mediaPlayerMuteChanged):
  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::supportsMuting): (WebCore::NullMediaPlayerPrivate::setMuted): (WebCore::MediaPlayer::MediaPlayer): (WebCore::MediaPlayer::muted): (WebCore::MediaPlayer::supportsMuting): (WebCore::MediaPlayer::setMuted): (WebCore::MediaPlayer::volumeChanged): (WebCore::MediaPlayer::muteChanged):
  • platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerMuteChanged):
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::supportsMuting): (WebCore::MediaPlayerPrivateInterface::setMuted):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateVolumeChangedCallback): (WebCore::notifyVolumeIdleCallback): (WebCore::mediaPlayerPrivateMuteChangedCallback): (WebCore::notifyMuteIdleCallback): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::volumeChangedCallback): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::supportsMuting): (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::muteChangedCallback): (WebCore::MediaPlayerPrivate::muteChanged): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

2010-01-29 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] set playbin mute property depending on volume value
​https://bugs.webkit.org/show_bug.cgi?id=31586

New API in MediaPlayer for mute control

  • public/WebMediaPlayerClient.h:
  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::volumeChanged): (WebKit::WebMediaPlayerClientImpl::muteChanged):
  • src/WebMediaPlayerClientImpl.h:
7:30 AM Changeset in webkit [54135] by Csaba Osztrogonác
  • 1 edit
    1 copy in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] Platform dependent expected file added for test introduced in r53868,
because this test passes. Compared to png file and Mac expected file.

  • platform/qt/fast/lists/anonymous-items-expected.txt: Added.
7:03 AM Changeset in webkit [54134] by Simon Hausmann
  • 3 edits in trunk/WebCore

[Qt] Build without SSL support is broken

Patch by Henry Haverinen <Henry Haverinen> on 2010-02-01
Reviewed by Simon Hausmann.

Added missing #ifdefs for OpenSSL support and one null-pointer
check for the socket.

​https://bugs.webkit.org/show_bug.cgi?id=34416

  • platform/network/qt/SocketStreamHandlePrivate.h:
  • platform/network/qt/SocketStreamHandleQt.cpp:

(WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate):
(WebCore::SocketStreamHandlePrivate::send):

6:05 AM Changeset in webkit [54133] by pfeldman@chromium.org
  • 7 edits in trunk/WebCore

2010-02-01 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Fix rest of the NativeTextViewer (line numbers,
conditional breakpoints, selection).

5:58 AM QtWebKitBackportingFixes edited by andreas.kling@nokia.com
(diff)
5:54 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
5:11 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
4:43 AM QtWebKitBackportingFixes edited by kenneth@webkit.org
(diff)
2:50 AM Changeset in webkit [54132] by steveblock@google.com
  • 2 edits
    2 adds in trunk/WebCore

Adds implementation of JavaString for V8.
​https://bugs.webkit.org/show_bug.cgi?id=33953

Reviewed by Ariya Hidayat.

No new tests, build fix only.

  • bridge/jni/JNIBridge.h: Modified. Include JavaStringV8.h for V8
  • bridge/jni/v8: Added.
  • bridge/jni/v8/JavaStringV8.h: Added.

(JSC::Bindings::JavaStringImpl::init):
(JSC::Bindings::JavaStringImpl::UTF8String):
(JSC::Bindings::JavaStringImpl::uchars):
(JSC::Bindings::JavaStringImpl::length):

2:05 AM Changeset in webkit [54131] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-02-01 Oliver Hunt <​oliver@apple.com>

Windows build fix, update exports file (again)

1:56 AM Changeset in webkit [54130] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-02-01 Oliver Hunt <​oliver@apple.com>

Windows build fix, update exports file

1:43 AM Changeset in webkit [54129] by oliver@apple.com
  • 5 edits
    2 adds in trunk

2010-01-31 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

JSC is failing to propagate anonymous slot count on some transitions
​https://bugs.webkit.org/show_bug.cgi?id=34321

Remove secondary Structure constructor, and make Structure store a copy
of the number of anonymous slots directly so saving an immediate allocation
of a property map for all structures with anonymous storage, which also
avoids the leaked property map on new property transition in the original
version of this patch.

We need to propagate the the anonymous slot count otherwise we can end up
with a structure recording incorrect information about the available and
needed space for property storage, or alternatively incorrectly reusing
some slots.

  • JavaScriptCore.exp:
  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::materializePropertyMap): (JSC::Structure::addPropertyTransition): (JSC::Structure::changePrototypeTransition): (JSC::Structure::despecifyFunctionTransition): (JSC::Structure::getterSetterTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::flattenDictionaryStructure): (JSC::Structure::copyPropertyTable): (JSC::Structure::put): (JSC::Structure::remove): (JSC::Structure::insertIntoPropertyMapHashTable): (JSC::Structure::createPropertyMapHashTable):
  • runtime/Structure.h: (JSC::Structure::create): (JSC::Structure::hasAnonymousSlots): (JSC::Structure::anonymousSlotCount):

2010-02-01 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

JSC is failing to propagate anonymous slot count on some transitions
​https://bugs.webkit.org/show_bug.cgi?id=34321

Add test case for modifying DOM objects with anonymous storage.

  • fast/dom/Window/anonymous-slot-with-changes-expected.txt: Added.
  • fast/dom/Window/anonymous-slot-with-changes.html: Added.
1:27 AM Changeset in webkit [54128] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-02-01 Alex Milowski <​alex@milowski.com>

Reviewed by Darin Adler.

Added compile time debug support for mathml layout (block boundary & baseline)

  • mathml/RenderMathMLBlock.cpp: (WebCore::RenderMathMLBlock::stretchToHeight): (WebCore::RenderMathMLBlock::paint):
  • mathml/RenderMathMLBlock.h:
12:50 AM Changeset in webkit [54127] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-02-01 Philippe Normand <​pnormand@igalia.com>

Rubber stamped by Xan Lopez.

Fixed compilation warning about unsigned vs signed comparison.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::paint):

Jan 31, 2010:

11:29 PM Applications using WebKit edited by wevah@derailer.org
Paparazzi! is a Universal Binary. Also dropped the "www." from its URL. (diff)
11:05 PM Changeset in webkit [54126] by Chris Jerdonek
  • 5 edits
    2 adds in trunk/WebKitTools

2010-01-31 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Moved style error handler code to their own classes, and
related refactoring. Increased unit test code coverage of
style error handling.

​https://bugs.webkit.org/show_bug.cgi?id=34379

  • Scripts/check-webkit-style:
    • Minor change: added error_count variable.
  • Scripts/webkitpy/style/checker.py:
    • Renamed ProcessorOptions.should_report_error() to is_reportable().
    • In the StyleChecker class--
      • Removed _default_style_error_handler().
      • Added _increment_error_count().
      • Refactored to use DefaultStyleErrorHandler and PatchStyleErrorHandler constructors.
  • Scripts/webkitpy/style/checker_unittest.py:
    • In the StyleStyleCheckerTest class--
      • Removed write_sample_error().
      • Removed test_default_style_error_handler().
  • Scripts/webkitpy/style/error_handlers.py: Added.
    • Added DefaultStyleErrorHandler class.
    • Added PatchStyleErrorHandler class.
  • Scripts/webkitpy/style/error_handlers_unittest.py: Added.
    • Added unit tests for DefaultStyleErrorHandler and PatchStyleErrorHandler.
  • Scripts/webkitpy/style/unittests.py:
    • Added error_handlers unit tests.
10:21 PM Changeset in webkit [54125] by tkent@chromium.org
  • 31 edits
    2 deletes in trunk/WebCore

2010-01-31 Kent Tamura <​tkent@chromium.org>

Unreviewed. Revert r54112 and r54124 because of Windows build error.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::isPointInPath): (WebCore::CanvasRenderingContext2D::willDraw):
  • html/canvas/CanvasRenderingContext2D.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Path.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  • platform/graphics/cairo/PathCairo.cpp:
  • platform/graphics/cairo/TransformationMatrixCairo.cpp:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
  • platform/graphics/cg/PathCG.cpp:
  • platform/graphics/cg/TransformationMatrixCG.cpp:
  • platform/graphics/haiku/GraphicsContextHaiku.cpp:
  • platform/graphics/haiku/PathHaiku.cpp:
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/graphics/qt/PathQt.cpp:
  • platform/graphics/qt/TransformationMatrixQt.cpp:
  • platform/graphics/skia/GraphicsContextSkia.cpp:
  • platform/graphics/skia/PathSkia.cpp:
  • platform/graphics/skia/TransformationMatrixSkia.cpp:
  • platform/graphics/transforms/AffineTransform.cpp: Removed.
  • platform/graphics/transforms/AffineTransform.h: Removed.
  • platform/graphics/wince/GraphicsContextWince.cpp:
  • platform/graphics/wx/GraphicsContextWx.cpp:
  • platform/graphics/wx/PathWx.cpp:
  • platform/graphics/wx/TransformationMatrixWx.cpp: (WebCore::TransformationMatrix::operator wxGraphicsMatrix):
9:04 PM Changeset in webkit [54124] by tkent@chromium.org
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj

Unreviewd. Windows build fix.

8:23 PM Changeset in webkit [54123] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-01-31 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

Buildfix for WinCE + style fixes (TLS_OUT_OF_INDEXES is not defined).
​https://bugs.webkit.org/show_bug.cgi?id=34380

  • wtf/ThreadSpecific.h:
6:37 PM Changeset in webkit [54122] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-31 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Darin Adler.

Limit the scope of packing alignment to avoid MSVC C4103 warning.
​https://bugs.webkit.org/show_bug.cgi?id=34390

Use pack(push, 16) and pack(pop) to limit the scope of packing
alignment change.

  • bindings/js/JSSVGPODTypeWrapper.h:
6:33 PM Changeset in webkit [54121] by tkent@chromium.org
  • 5 edits in trunk

2010-01-31 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

[Windows] Fix a bug of round() with huge integral numbers
​https://bugs.webkit.org/show_bug.cgi?id=34297

Fix a bug that round() for huge integral numbers returns incorrect
results. For example, round(8639999913600001) returns
8639999913600002 without this change though the double type can
represent 8639999913600001 precisely.

Math.round() of JavaScript has a similar problem. But this change
doesn't fix it because Math.round() doesn't use round() of
MathExtra.h.

  • wtf/MathExtras.h: (round): Avoid to do "num + 0.5" or "num - 0.5". (roundf): Fixed similarly. (llround): Calls round(). (llroundf): Calls roundf(). (lround): Calls round(). (lroundf): Calls roundf().

2010-01-31 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

[Win] Fix a bug of round() with huge integral numbers
​https://bugs.webkit.org/show_bug.cgi?id=34297

Add a test case to call round(8639999913600001).

  • fast/forms/input-valueasnumber-datetime-expected.txt:
  • fast/forms/script-tests/input-valueasnumber-datetime.js:
5:56 PM Changeset in webkit [54120] by tkent@chromium.org
  • 7 edits in trunk

2010-01-31 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Fix valueAsNumber calculation for type=month.
​https://bugs.webkit.org/show_bug.cgi?id=34304

valueAsNumber calculation for type=month which was checked in as
r53893 was the number of milliseconds since UNIX epoch, and it was
wrong. The correct way is the number months since UNIX epoch.

  • fast/forms/input-valueasnumber-month-expected.txt:
  • fast/forms/script-tests/input-valueasnumber-month.js:

2010-01-31 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Fix valueAsNumber calculation for type=month.
​https://bugs.webkit.org/show_bug.cgi?id=34304

valueAsNumber calculation for type=month which was checked in as
r53893 was the number of milliseconds since UNIX epoch, and it was
wrong. The correct way is the number months since UNIX epoch.

  • html/DateComponents.cpp: (WebCore::DateComponents::setMonthsSinceEpoch): (WebCore::DateComponents::monthsSinceEpoch):
  • html/DateComponents.h: Declare setMonthsSinceEpoch() and monthsSinceEpoch().
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseToDouble): Switch to monthsSinceEpoch() for type=MONTH. (WebCore::HTMLInputElement::valueAsDate): Add code with millisecondsSinceEpoch() for MONTH because parseToDouble() changed its behavior. (WebCore::HTMLInputElement::setValueAsNumber): Use setMonthsSinceEpoch() for MONTH.
5:43 PM Changeset in webkit [54119] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-01-31 Kent Tamura <​tkent@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Fix a bug that a selected word is not recognized as a
spell-check source.
​https://bugs.webkit.org/show_bug.cgi?id=33660

  • src/ContextMenuClientImpl.cpp: (WebKit::isASingleWord): Use wordBreakIterator(), and correctly check the return value of textBreakNext().
5:42 PM Changeset in webkit [54118] by mitz@apple.com
  • 2 edits in trunk/WebCore

Web Inspector: REGRESSION: Numbers in bubbles are vertically off-center
​https://bugs.webkit.org/show_bug.cgi?id=34398

Reviewed by Timothy Hatcher.

  • inspector/front-end/inspector.css: Specify line-height: normal for

".console-message .bubble" and ".sidebar-tree-item .status .bubble".

4:54 PM Changeset in webkit [54117] by ojan@chromium.org
  • 6 edits in trunk

2010-01-28 Ojan Vafai <​ojan@chromium.org>

Reviewed by Darin Adler.

Implement CSSOM Range.getClientRects for collapsed selections
​https://bugs.webkit.org/show_bug.cgi?id=34239

Adds two cases to getClientRects test.

  • fast/dom/Range/getClientRects-expected.txt:
  • fast/dom/Range/getClientRects.html:

2010-01-28 Ojan Vafai <​ojan@chromium.org>

Reviewed by Darin Adler.

Implement CSSOM Range.getClientRects for collapsed selections
​https://bugs.webkit.org/show_bug.cgi?id=34239

When getting the quads for a range on a text node, allow returning
zero width quads. This leaves the case of collapsed selections inside
elements still not fixed, but no worse.

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect):
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteQuadsForRange):
3:59 PM Changeset in webkit [54116] by mrowe@apple.com
  • 4 edits in trunk/WebCore

Roll r54095 out again without making a mess of the ChangeLog.

3:59 PM Changeset in webkit [54115] by mrowe@apple.com
  • 4 edits in trunk/WebCore

Revert r54114 since it made a mess of the ChangeLog.

3:43 PM Changeset in webkit [54114] by eric.carlson@apple.com
  • 4 edits in trunk/WebCore

2010-01-31 Eric Carlson <​eric.carlson@apple.com>

Revert r54095 because it caused many media tests to fail.

  • platform/graphics/win/GraphicsLayerCACF.cpp: (WebCore::GraphicsLayerCACF::setContentsToVideo): (WebCore::GraphicsLayerCACF::updateContentsVideo):
  • platform/graphics/win/GraphicsLayerCACF.h: (WebCore::GraphicsLayerCACF::):
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWinPrivate::task): (QTMovieWinPrivate::setSize):
3:01 PM Changeset in webkit [54113] by oliver@apple.com
  • 8 edits in trunk

2010-01-31 Oliver Hunt <​oliver@apple.com>

Reviewed by Simon Fraser.

Animated scaling of background-image is too slow
​https://bugs.webkit.org/show_bug.cgi?id=33808

Update checksum.

  • platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum:

2010-01-31 Oliver Hunt <​oliver@apple.com>

Reviewed by Simon Fraser.

Animated scaling of background-image is too slow
​https://bugs.webkit.org/show_bug.cgi?id=33808

Implement a version of the RenderImage animated scaling optimisation
for background images. Due to the possibility of arbitrary transforms
being applied to containing elements we explicitly check the current
CTM of the context for scaling or rotation.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawTiledImage):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::isIdentityOrTranslation):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelScaleData::RenderBoxModelScaleData): (WebCore::RenderBoxModelScaleData::~RenderBoxModelScaleData): (WebCore::RenderBoxModelScaleData::hiqhQualityRepaintTimer): (WebCore::RenderBoxModelScaleData::size): (WebCore::RenderBoxModelScaleData::setSize): (WebCore::RenderBoxModelScaleData::lastPaintTime): (WebCore::RenderBoxModelScaleData::setLastPaintTime): (WebCore::RenderBoxModelScaleData::useLowQualityScale): (WebCore::RenderBoxModelScaleData::transform): (WebCore::RenderBoxModelScaleData::setTransform): (WebCore::RenderBoxModelScaleData::setUseLowQualityScale): (WebCore::RenderBoxModelScaleObserver::boxModelObjectDestroyed): (WebCore::RenderBoxModelScaleObserver::highQualityRepaintTimerFired): (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality): (WebCore::RenderBoxModelObject::highQualityRepaintTimerFired): (WebCore::RenderBoxModelObject::~RenderBoxModelObject): (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • rendering/RenderBoxModelObject.h:
1:04 PM Changeset in webkit [54112] by krit@webkit.org
  • 31 edits
    2 adds in trunk/WebCore

2010-01-31 Dirk Schulze <​krit@webkit.org>

Reviewed by Simon Fraser.

Add back an AffineTransform class for use by SVG
​https://bugs.webkit.org/show_bug.cgi?id=33750

These are the first steps on reimplementing AffineTransform. Unlike
the old affine code, this one is platform independent like TransformationMatrix.
AffineTransform has the benefit, that it stores just 6 doubles instead of
16 in TransformationMatrix. The calculations of transformations are not that
complex and can improve the memory usage and speed of SVG.
AffineTransform can be used by HTML Canvas3D or SVG, since they are 2D related (at
least for the moment).
HTML Canvas is the first that makes use of the new AffineTransform. Next patches
will introduce the affine code to SVG.

No new tests. The new AffineTransformation code is tested by fast/canvas.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::isPointInPath): (WebCore::CanvasRenderingContext2D::willDraw):
  • html/canvas/CanvasRenderingContext2D.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Path.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::transform):
  • platform/graphics/cairo/TransformationMatrixCairo.cpp: (WebCore::AffineTransform::operator cairo_matrix_t):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/cg/PathCG.cpp: (WebCore::Path::transform):
  • platform/graphics/cg/TransformationMatrixCG.cpp: (WebCore::AffineTransform::operator CGAffineTransform):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/haiku/PathHaiku.cpp: (WebCore::Path::transform):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::transform):
  • platform/graphics/qt/TransformationMatrixQt.cpp: (WebCore::AffineTransform::operator QTransform):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/skia/PathSkia.cpp: (WebCore::Path::transform):
  • platform/graphics/skia/TransformationMatrixSkia.cpp: (WebCore::AffineTransform::operator SkMatrix):
  • platform/graphics/transforms/AffineTransform.cpp: Added. (WebCore::affineTransformDecompose): (WebCore::affineTransformCompose): (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::reset): (WebCore::AffineTransform::setMatrix): (WebCore::AffineTransform::isIdentity): (WebCore::AffineTransform::det): (WebCore::AffineTransform::isInvertible): (WebCore::AffineTransform::inverse): (WebCore::AffineTransform::multiply): (WebCore::AffineTransform::multLeft): (WebCore::AffineTransform::rotate): (WebCore::AffineTransform::scale): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::scaleNonUniform): (WebCore::AffineTransform::rotateFromVector): (WebCore::AffineTransform::flipX): (WebCore::AffineTransform::flipY): (WebCore::AffineTransform::shear): (WebCore::AffineTransform::skew): (WebCore::AffineTransform::skewX): (WebCore::AffineTransform::skewY): (WebCore::makeMapBetweenRects): (WebCore::AffineTransform::map): (WebCore::AffineTransform::mapPoint): (WebCore::AffineTransform::mapRect): (WebCore::AffineTransform::blend):
  • platform/graphics/transforms/AffineTransform.h: Added. (WebCore::AffineTransform::a): (WebCore::AffineTransform::setA): (WebCore::AffineTransform::b): (WebCore::AffineTransform::setB): (WebCore::AffineTransform::c): (WebCore::AffineTransform::setC): (WebCore::AffineTransform::d): (WebCore::AffineTransform::setD): (WebCore::AffineTransform::e): (WebCore::AffineTransform::setE): (WebCore::AffineTransform::f): (WebCore::AffineTransform::setF): (WebCore::AffineTransform::operator== ): (WebCore::AffineTransform::operator!=): (WebCore::AffineTransform::operator*=): (WebCore::AffineTransform::operator*): (WebCore::AffineTransform::setMatrix):
  • platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/wx/PathWx.cpp: (WebCore::Path::transform):
  • platform/graphics/wx/TransformationMatrixWx.cpp: (WebCore::AffineTransform::operator wxGraphicsMatrix):
9:55 AM Changeset in webkit [54111] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-31 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: [REGRESSION] Breakpoint source line is not displayed
in the breakpoint manager.

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._addBreakpointToSource):
8:36 AM Changeset in webkit [54110] by pfeldman@chromium.org
  • 11 edits
    1 add in trunk/WebCore

2010-01-31 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Introduce NativeTextViewer.

This change handles rendering highlighted text, using browser's
selection/drag/drop/click logic. Breakpoint decorations and
program counter is working.

Todo: line numbers are painted 'under' the text when scrolling
horizontally, search is not yet implemented.

​https://bugs.webkit.org/show_bug.cgi?id=34391

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DivBasedTextViewer.js: Added. (WebInspector.DivBasedTextViewer): (WebInspector.DivBasedTextViewer.prototype._textChanged): (WebInspector.DivBasedTextViewer.prototype._createLineDivs): (WebInspector.DivBasedTextViewer.prototype._updatePreferredSize): (WebInspector.DivBasedTextViewer.prototype._scroll): (WebInspector.DivBasedTextViewer.prototype._registerMouseListeners): (WebInspector.DivBasedTextViewer.prototype._registerKeyboardListeners): (WebInspector.DivBasedTextViewer.prototype._registerClipboardListeners): (WebInspector.DivBasedTextViewer.prototype._paintSelection): (WebInspector.DivBasedTextViewer.prototype._positionDivDecoration): (WebInspector.DivBasedTextViewer.prototype._mouseDown): (WebInspector.DivBasedTextViewer.prototype._contextMenu): (WebInspector.DivBasedTextViewer.prototype._caretForMouseEvent): (WebInspector.DivBasedTextViewer.prototype._paintLine): (WebInspector.DivBasedTextViewer.prototype._createSpan):
  • inspector/front-end/Settings.js:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.clearMessages): (WebInspector.SourceFrame.prototype.sizeToFitContentHeight): (WebInspector.SourceFrame.prototype._createEditorIfNeeded): (WebInspector.SourceFrame.prototype._addMessageToSource): (WebInspector.SourceFrame.prototype.resize):
  • inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype.setDivDecoration): (WebInspector.TextEditor.prototype._registerMouseListeners): (WebInspector.TextEditor.prototype._registerKeyboardListeners): (WebInspector.TextEditor.prototype._registerClipboardListeners): (WebInspector.TextEditor.prototype.reveal): (WebInspector.TextEditor.prototype._textChanged): (WebInspector.TextEditor.prototype.revalidateDecorationsAndPaint): (WebInspector.TextEditor.prototype._updatePreferredSize): (WebInspector.TextEditor.prototype.resize): (WebInspector.TextEditor.prototype._paintLinesContinuation): (WebInspector.TextEditor.prototype._paintLine): (WebInspector.TextEditor.prototype._contextMenu): (WebInspector.TextEditor.prototype._caretForMouseEvent): (WebInspector.TextEditor.prototype._changeFont):
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter.prototype._lex):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/textEditor.css:
7:42 AM Changeset in webkit [54109] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-31 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Eric Seidel.

[Qt] Enable FAST_MOBILE_SCROLLING on Qt embedded platforms
​https://bugs.webkit.org/show_bug.cgi?id=34168

Enable FAST_MOBILE_SCROLLING for Qt on Maemo 5, Linux embedded
and Symbian

  • WebCore.pro:

Jan 30, 2010:

11:38 PM Changeset in webkit [54108] by yurys@chromium.org
  • 3 edits in trunk/WebCore

2010-01-31 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Make ScriptState destructor protected since all non-empty
ScriptStates are managed by GC. Remove obsolete constructor.

​https://bugs.webkit.org/show_bug.cgi?id=34266

  • bindings/v8/ScriptState.cpp:
  • bindings/v8/ScriptState.h:
10:01 PM Changeset in webkit [54107] by Simon Fraser
  • 5 edits in trunk/WebCore

2010-01-30 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Use CGGradient on Leopard and later, since it's faster than CGShading
​https://bugs.webkit.org/show_bug.cgi?id=34384

Use CGGradient on Leopard and later, rather than CGShading, for
performance.

  • platform/graphics/Gradient.h:
  • platform/graphics/Gradient.cpp: (WebCore::Gradient::sortStopsIfNecessary): Utility method to sort stops. Did not call this from getColor() to avoid overhead of a function call.
  • platform/graphics/cg/GradientCG.cpp: (WebCore::Gradient::platformDestroy): Use CGGradientRelease() post-Tiger. (WebCore::Gradient::platformGradient): Create and return a CGGradientRef post-Tiger. (WebCore::Gradient::fill): Call new paint() method. (WebCore::Gradient::paint): New convenence method that avoids testing isRadial() in a bunch of other places.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillPath): Call the gradient's paint() method. (WebCore::GraphicsContext::strokePath): Ditto (WebCore::GraphicsContext::fillRect): Ditto (WebCore::GraphicsContext::strokeRect): Ditto
7:21 PM Changeset in webkit [54106] by Simon Fraser
  • 3 edits
    2 adds in trunk

2010-01-30 Simon Fraser <Simon Fraser>

Reviewed by Adele Peterson.

Do color animations on premultiplied colors
​https://bugs.webkit.org/show_bug.cgi?id=34383

Convert colors to premultiplied alpha before interpolating them,
then convert the result back to non-premultiplied. This gives better
results when animating from transparent colors.

Test: transitions/color-transition-premultiplied.html

  • page/animation/AnimationBase.cpp: (WebCore::blendFunc):
4:37 PM Changeset in webkit [54105] by kevino@webkit.org
  • 5 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Add a way to get the parse mode to wxWebKit API.

​https://bugs.webkit.org/show_bug.cgi?id=34341

1:42 PM Changeset in webkit [54104] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-01-30 Gustavo Noronha Silva <Gustavo Noronha Silva>

Build fixes needed for make distcheck.

  • GNUmakefile.am:

Jan 29, 2010:

9:37 PM Changeset in webkit [54103] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Stop copying an IDL file in to the framework wrapper.

  • WebCore.xcodeproj/project.pbxproj:
9:35 PM Changeset in webkit [54102] by mrowe@apple.com
  • 6 edits in trunk

Sort Xcode projects.

JavaScriptCore:

WebCore:

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

  • WebKit.xcodeproj/project.pbxproj:
9:32 PM Changeset in webkit [54101] by mrowe@apple.com
  • 3 edits
    3 copies in trunk

Roll over a few oversized ChangeLogs.

9:30 PM Changeset in webkit [54100] by mrowe@apple.com
  • 7 edits
    2 deletes in trunk

Roll out r54073 as it introduced many thousands of leaks.

9:21 PM Changeset in webkit [54099] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix run-leaks with newer versions of the leaks tool.

Rubber-stamped by Stephanie Lewis.

  • Scripts/run-leaks:
9:00 PM Changeset in webkit [54098] by mrowe@apple.com
  • 3 edits in trunk/WebKitLibraries

Keep the Windows feature defines in sync with FeatureDefines.xcconfig.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
8:51 PM Changeset in webkit [54097] by mrowe@apple.com
  • 6 edits in trunk

Fix the Mac build.

Disable ENABLE_INDEXED_DATABASE since it is "completely non-functional".

As the comment in FeatureDefines.xcconfig notes, the list of feature defines
needs to be kept in sync across the various files. The default values also
need to be kept in sync between these files and build-webkit.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
7:04 PM Changeset in webkit [54096] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2010-01-29 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin Adler.

Timeout for client-based Geolocation shouldn't start until user gives consent
​https://bugs.webkit.org/show_bug.cgi?id=34352

  • page/Geolocation.cpp: (WebCore::Geolocation::startRequest): Don't start timer if we're blocked on user consent. (WebCore::Geolocation::setIsAllowed): Start timer after user gives consent.
6:17 PM Changeset in webkit [54095] by cmarrin@apple.com
  • 4 edits in trunk/WebCore

Fixed changed virtual function in GraphicsLayerCACF and call order issues
​https://bugs.webkit.org/show_bug.cgi?id=34348


The correct virtual function in GraphicsLayerCACF is now being
called. We also fixed an issue in QTMovieWin where the size
of the movie was not being set correctly because the call order
was changed.

5:25 PM Changeset in webkit [54094] by dpranke@chromium.org
  • 1 edit
    4 adds in trunk/WebKitTools

2010-01-29 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Siedel.

Top-level test drivers for running the Chromium port of run-webkit-tests
and being able to rebaseline test results from the test bots. The
files in the Scripts directory are simply wrappers around the files
in webkitpy/layout_tests for convenience.


​https://bugs.webkit.org/show_bug.cgi?id=31498

  • Scripts/rebaseline-chromium-webkit-tests: Added.
  • Scripts/run-chromium-webkit-tests: Added.
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Added.
  • Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: Added.
5:17 PM Changeset in webkit [54093] by dpranke@chromium.org
  • 1 edit
    6 adds in trunk/WebKitTools

2010-01-29 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Siedel.

Add in the second block of python code for the Chromium port
of run-webkit-tests. These files execute different diffs to classify
the various types of failures from a test.

  • Scripts/webkitpy/layout_tests/test_types: Added.
  • Scripts/webkitpy/layout_tests/test_types/init.py: Added.
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Added.
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py: Added.
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Added.
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py: Added.
5:12 PM Changeset in webkit [54092] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

5:06 PM Changeset in webkit [54091] by dpranke@chromium.org
  • 1 edit
    21 adds in trunk/WebKitTools

2010-01-29 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Siedel.

Check in the first part of the Chromium Python port of the
run-webkit-tests test driver. The files under
layout_tests/layout_layout constitute most of the implementation;
they can be roughly divided into code that parses the
"test_expectations.txt" file that describes how we expect tests to
pass or fail, platform-specific hooks for the different Chromium
ports (in platform_utils*), code for parsing the output of the
tests and generating results files and HTML and JSON for the
dashboards, auxiliary scripts for starting and stopping HTTP and
Web Socket servers, and then one of the actual driver files
(test_shell_thread). Code for actually parsing test output for
failures and the top-level driver scripts will follow shortly.

​https://bugs.webkit.org/show_bug.cgi?id=31498

  • Scripts/webkitpy/layout_tests: Added.
  • Scripts/webkitpy/layout_tests/layout_package: Added.
  • Scripts/webkitpy/layout_tests/layout_package/init.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/http_server.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Added.
    • scripts to start and stop apache. Note that the apache file generates a conf file dynamically, and we should switch to using the same static conf file that the regular run-webkit-tests uses, and we can also use the same httpd2.pem file.
  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Added.
    • scripts to generate the JSON layout test dashboard and the flakiness dashboard
  • Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Added.
    • default configuration for LigHTTPd (used on Windows)
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Added.
    • utility class that implements progress bars on the console to be displayed while the tests are running
  • Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Added.
    • various routines for manipulating paths and URIs
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Added.
    • platform-specific aspects of the drivers (binary names, paths, process control, etc.)
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Added.
    • code for parsing the 'test_expectations.txt' file to determine which tests are expected to fail (and how) on which platforms
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Added.
    • code for handling different kinds of failures (generating output in the results, etc.)
  • Scripts/webkitpy/layout_tests/layout_package/test_files.py: Added.
    • code to gather the lists of tests
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Added.
    • code to actually execute tests via TestShell and process the output
  • Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Added.
    • scripts to start and stop the pywebsocket server
4:59 PM Changeset in webkit [54090] by bweinstein@apple.com
  • 4 edits in trunk/WebKit/win

Roll out r54088 because the functions were already in
IWebPreferencesPrivate, so they should stay there.

4:48 PM Changeset in webkit [54089] by jpetsovits@rim.com
  • 4 edits in trunk/WebCore

2010-01-29 Jakob Petsovits <​jpetsovits@rim.com>

Reviewed by Nikolas Zimmermann.

[OpenVG] Implement more graphics primitives
​https://bugs.webkit.org/show_bug.cgi?id=34339

Adds lines, arcs, ellipses, polygons and rounded
rectangles to PainterOpenVG and GraphicsContext.

Rounded rects support by Eli Fidler <​efidler@rim.com>.

  • platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::drawLineForText): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::strokeRect):
  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PainterOpenVG::drawRect): (WebCore::PainterOpenVG::drawRoundedRect): (WebCore::PainterOpenVG::drawLine): (WebCore::PainterOpenVG::drawArc): (WebCore::PainterOpenVG::drawEllipse): (WebCore::PainterOpenVG::drawPolygon):
  • platform/graphics/openvg/PainterOpenVG.h:
4:48 PM Changeset in webkit [54088] by bweinstein@apple.com
  • 4 edits in trunk/WebKit/win

Rubber-stamped by Adam Roben.

Move customDragCursorEnabled preference functions from
IWebPreferences to IWebPreferencesPrivate.

  • Interfaces/IWebPreferences.idl: Moved customDragFunctions from here...
  • Interfaces/IWebPreferencesPrivate.idl: To here.
  • Interfaces/WebKit.idl: Touched to make sure we rebuild.
4:34 PM Changeset in webkit [54087] by dpranke@chromium.org
  • 1 edit
    9 adds in trunk/WebKitTools

2010-01-29 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Check in a copy of the simplejson library; it will be used by
the Chromium port of run-webkit-tests.


​https://bugs.webkit.org/show_bug.cgi?id=31498

  • simplejson: Added.
  • simplejson/LICENSE.txt: Added.
  • simplejson/README.txt: Added.
  • simplejson/init.py: Added.
  • simplejson/_speedups.c: Added. (ascii_escape_char): (ascii_escape_unicode): (ascii_escape_str): (py_encode_basestring_ascii): (init_speedups):
  • simplejson/decoder.py: Added.
  • simplejson/encoder.py: Added.
  • simplejson/jsonfilter.py: Added.
  • simplejson/scanner.py: Added.
4:27 PM Changeset in webkit [54086] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-01-29 Dirk Pranke <​dpranke@chromium.org>

No review

Add myself to the committers list

  • Scripts/webkitpy/committers.py:
4:18 PM Changeset in webkit [54085] by jorlow@chromium.org
  • 23 edits
    12 adds in trunk

2010-01-29 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

A first step towards the Indexed Database API
​https://bugs.webkit.org/show_bug.cgi?id=34342

Add runtime enable support for Indexed Database API.

  • features.gypi:
  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableIndexedDatabase): (WebKit::WebRuntimeFeatures::isIndexedDatabaseEnabled):

2010-01-29 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

A first step towards the Indexed Database API
​https://bugs.webkit.org/show_bug.cgi?id=34342

Flesh out the first part of Indexed Database API.
Currently only compiles with v8 + chromium for now.
Completely non-functional, but it seems best to do
this in chunks.

No tests because nothing works yet.

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/RuntimeEnabledFeatures.cpp:
  • bindings/v8/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setIndexedDatabaseEnabled): (WebCore::RuntimeEnabledFeatures::indexedDatabaseEnabled):
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::IndexedDBEnabled):
  • bindings/v8/custom/V8IDBRequestCustom.cpp: Added. (WebCore::V8IDBRequest::resultAccessorGetter):
  • bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: Added. (WebCore::V8IndexedDatabaseRequest::openCallback):
  • dom/EventNames.h:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::indexedDB):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • storage/IDBDatabaseError.h: Added. (WebCore::IDBDatabaseError::create): (WebCore::IDBDatabaseError::~IDBDatabaseError): (WebCore::IDBDatabaseError::code): (WebCore::IDBDatabaseError::setCode): (WebCore::IDBDatabaseError::message): (WebCore::IDBDatabaseError::setMessage): (WebCore::IDBDatabaseError::IDBDatabaseError):
  • storage/IDBDatabaseError.idl: Added.
  • storage/IDBDatabaseException.h: Added. (WebCore::IDBDatabaseException::create): (WebCore::IDBDatabaseException::~IDBDatabaseException): (WebCore::IDBDatabaseException::code): (WebCore::IDBDatabaseException::setCode): (WebCore::IDBDatabaseException::message): (WebCore::IDBDatabaseException::setMessage): (WebCore::IDBDatabaseException::IDBDatabaseException):
  • storage/IDBDatabaseException.idl: Added.
  • storage/IDBRequest.cpp: Added. (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::~IDBRequest): (WebCore::IDBRequest::abort): (WebCore::IDBRequest::eventTargetData): (WebCore::IDBRequest::ensureEventTargetData):
  • storage/IDBRequest.h: Added. (WebCore::IDBRequest::create): (WebCore::IDBRequest::readyState): (WebCore::IDBRequest::error): (WebCore::IDBRequest::result): (WebCore::IDBRequest::scriptExecutionContext): (WebCore::IDBRequest::toIDBRequest): (WebCore::IDBRequest::refEventTarget): (WebCore::IDBRequest::derefEventTarget):
  • storage/IDBRequest.idl: Added.
  • storage/IndexedDatabaseRequest.cpp: Added. (WebCore::IndexedDatabaseRequest::IndexedDatabaseRequest): (WebCore::IndexedDatabaseRequest::~IndexedDatabaseRequest): (WebCore::IndexedDatabaseRequest::open):
  • storage/IndexedDatabaseRequest.h: Added. (WebCore::IndexedDatabaseRequest::create): (WebCore::IndexedDatabaseRequest::request):
  • storage/IndexedDatabaseRequest.idl: Added.

2010-01-29 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

A first step towards the Indexed Database API
​https://bugs.webkit.org/show_bug.cgi?id=34342

Add Indexed Database API

  • configure.ac:

2010-01-29 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

A first step towards the Indexed Database API
​https://bugs.webkit.org/show_bug.cgi?id=34342

Add indexed database API.

  • Scripts/build-webkit:
4:00 PM Changeset in webkit [54084] by abecsi@webkit.org
  • 2 edits in trunk/WebKitTools

Correct openHTTPD() to print requests to stdout if run-webkit-httpd is used.
This fixes a regression introduced in r53559.

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=34336

  • Scripts/webkitperl/httpd.pm:
4:00 PM Changeset in webkit [54083] by bweinstein@apple.com
  • 9 edits in trunk

WebCore: Drag and Drop: Windows uses "stop" sign as cursor when dragging
​https://bugs.webkit.org/show_bug.cgi?id=34305
<rdar://problem/7589672>

Reviewed by Adam Roben.

Add a FIXME for the code that needs to be changed to support full
custom cursors.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleDrag):

WebKit/win: Drag and Drop: Windows uses "stop" sign as cursor when dragging
​https://bugs.webkit.org/show_bug.cgi?id=34305
<rdar://problem/7589672>

Reviewed by Adam Roben.

Add a preference in WebKit (that defaults to false), for whether or not
we should show the custom cursors during drag and drop. However, this is
currently only used on Windows, and only used to hide the "drop not allowed"
icon inside the WebView is the preference is set to true.

This will be off by default, so no change in behavior.

  • Interfaces/IWebPreferencesPrivate.idl: Added new functions.
  • Interfaces/WebKit.idl: Touched to force Interfaces build.
  • WebDropSource.cpp:

(WebDropSource::GiveFeedback): Implementation of conditional showing cursor

logic.

  • WebPreferenceKeysPrivate.h: Added new preference key.
  • WebPreferences.cpp: Added new functions.

(WebPreferences::setCustomDragCursorsEnabled):
(WebPreferences::customDragCursorsEnabled):

  • WebPreferences.h: Added new functions.
3:39 PM Changeset in webkit [54082] by victorw@chromium.org
  • 4 edits
    2 adds in trunk
2:26 PM Changeset in webkit [54081] by ap@apple.com
  • 9 edits in trunk

Reviewed by Dan Bernstein.

<rdar://problem/7441982> REGRESSION (TOT): Adobe CS4: Installer alerts are displayed as
blank windows

We probably shouldn't be deferring loads below modal dialogs and alerts, because that's not
what being modal means. But making such a change for general Web content would require fixes
in other parts of code, which I'm not ready to implement right now, so making it application
specific.

WebCore:

  • page/Page.cpp: (WebCore::Page::setDefersLoading): Do nothing if load deferring is not enabled in page settings.
  • WebCore.base.exp:
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setLoadDeferringEnabled):
  • page/Settings.h: (WebCore::Settings::loadDeferringEnabled): Add the ability for client to disable page deferring (still enabled by default).
  • platform/mac/RuntimeApplicationChecks.h:
  • platform/mac/RuntimeApplicationChecks.mm: (WebCore::applicationIsAdobeInstaller): Added a bundle ID test for Adobe installer.

WebKit/mac:

  • WebView/WebView.mm: (shouldEnableLoadDeferring): Load deferring is enabled unless the application is Adobe Installer. (-[WebView _preferencesChangedNotification:]): Call setLoadDeferringEnabled().
2:16 PM Changeset in webkit [54080] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • page/Geolocation.cpp:

(WebCore::Geolocation::startUpdating):

2:08 PM Changeset in webkit [54079] by sfalken@apple.com
  • 3 edits in trunk/WebCore

2010-01-29 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin Adler.

Client-based Geolocation starts updating before getting consent from the user
​https://bugs.webkit.org/show_bug.cgi?id=34343

  • page/Geolocation.cpp: (WebCore::Geolocation::startRequest): Pass notifier instead of options to startUpdating. (WebCore::Geolocation::setIsAllowed): Add the observer or notify of error for deferred startUpdating. (WebCore::Geolocation::startUpdating): Pass notifier instead of options, since we may need to call it if we fail to get user consent. Defer adding the observer if we don't yet have user consent, since this could kick off server-based wifi Geolocation requests.
  • page/Geolocation.h:
1:55 PM Changeset in webkit [54078] by jhoneycutt@apple.com
  • 17 edits
    1 copy
    2 adds in trunk

MSAA: Crash when posting a notification for a detached object

​https://bugs.webkit.org/show_bug.cgi?id=34309
<rdar://problem/7409759>

Reviewed by Darin Adler.

WebCore:

Test: platform/win/accessibility/detached-object-notification-crash.html

  • accessibility/AccessibilityRenderObject.cpp:

(AccessibilityRenderObject::document):
Null check m_renderer. This is the bug fix; the other changes in the
patch are for the test.

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
Map AXValueChanged to EVENT_OBJECT_VALUECHANGED, so we'll post a
notification when AXValueChanged is posted. Receiving an event of this
type tells us that the test passed.

WebKit/win:

  • AccessibleBase.cpp:

(AccessibleBase::QueryService):
If an unrecognized service ID is passed, return early. Otherwise, return
the result of QueryInterface.
(AccessibleBase::QueryInterface):
Add static_casts. Check for new UUIDs.
(AccessibleBase::isSameObject):
Query the object for AccessibleBase. Return whether the pointers or the
wrapped objects match.

  • AccessibleBase.h:

Give the class a UUID so we can query for it in isSameObject(). Inherit
from IAccessibleComparable; inherit from IServiceProvider so clients can
use QueryService to query for a custom interface.

  • Interfaces/AccessibleComparable.idl: Added. Declares a function that

can be called to compare to accessible objects.

  • Interfaces/WebKit.idl:

Include the new IDL.

  • WebKit.vcproj/Interfaces.vcproj:

Add the new IDL to the project.

WebKitTools:

  • DumpRenderTree/AccessibilityController.h:

Declare new functions. Add new members to store the event hook and the
mapping of accessibility elements to their JS callbacks.

  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:

(AccessibilityController::notificationReceived):
Stubbed.
(AccessibilityController::addNotificationListener):
Stubbed.

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::notificationReceived):
Stubbed.
(AccessibilityController::addNotificationListener):
Stubbed.

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::AccessibilityController):
Initialize the event hook.
(AccessibilityController::~AccessibilityController):
Remove the event hook. Unprotect all of the JS functions that are stored
in the map.
(logEventProc):
Clean-up a variable.
(stringEvent):
Return a string description of the MSAA event code.
(notificationListenerProc):
Get the accessible object from the event, and query it for IAccessible.
Call the AccessibilityController's notificationReceived().
(comparableObject):
Use QueryService to obtain the IAccessibleComparable for the
IServiceProvider.
(AccessibilityController::notificationReceived):
Iterate the map of objects that have registered for notification
callbacks. Query each for IServiceProvider, then use comparableObject()
to get an IAccessibleComparable. If we find an object matching the
notified object, call its callback, passing the event that was received.
(AccessibilityController::addNotificationListener):
If we have not created the event hook, create it. Protect the JS
callback function object, and add the object and its callback to our
map.

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::addNotificationListener):
Call through to the AccessibilityController's addNotificationListener().

  • DumpRenderTree/win/DumpRenderTreeWin.h:

Add an extern declaration for the shared FrameLoadDelegate extern, so we
can access it from AccessibilityController.

  • DumpRenderTree/win/FrameLoadDelegate.h:

(FrameLoadDelegate::accessibilityController):
Return the AccessibilityController.

LayoutTests:

  • platform/win/accessibility/detached-object-notification-crash-expected.txt: Added.
  • platform/win/accessibility/detached-object-notification-crash.html: Added.
1:32 PM Changeset in webkit [54077] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

Rubberstamped by Simon Hausmann.

[Qt] Separate implementation from class definition.

  • QtLauncher/main.cpp:

(LauncherWindow::webView):
(LauncherWindow::LauncherWindow):
(LauncherWindow::~LauncherWindow):
(LauncherWindow::keyPressEvent):
(LauncherWindow::grabZoomKeys):
(LauncherWindow::sendTouchEvent):
(LauncherWindow::eventFilter):
(LauncherWindow::loadStarted):
(LauncherWindow::loadFinished):
(LauncherWindow::showLinkHover):
(LauncherWindow::zoomIn):
(LauncherWindow::zoomOut):
(LauncherWindow::resetZoom):
(LauncherWindow::toggleZoomTextOnly):
(LauncherWindow::print):
(LauncherWindow::screenshot):
(LauncherWindow::setEditable):
(LauncherWindow::dumpHtml):
(LauncherWindow::selectElements):
(LauncherWindow::setTouchMocking):
(LauncherWindow::newWindow):
(LauncherWindow::setupUI):

1:12 PM Changeset in webkit [54076] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-29 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

prepare-ChangeLog outputs useless messages for a nonexistent bug ID
​https://bugs.webkit.org/show_bug.cgi?id=34313

  • Scripts/prepare-ChangeLog:
12:21 PM Changeset in webkit [54075] by darin@chromium.org
  • 9 edits in trunk

2010-01-29 Darin Fisher <​darin@chromium.org>

Okayed by Oliver Hunt.

Rollout r53949, r53951 and r54013 due to a Chromium regression that it
causes. Somehow this code change is triggering an endless repaint loop.

​https://bugs.webkit.org/show_bug.cgi?id=33808

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawTiledImage):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::isIdentityOrTranslation):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::~RenderBoxModelObject): (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • rendering/RenderBoxModelObject.h:
11:47 AM Changeset in webkit [54074] by kenneth@webkit.org
  • 3 edits in trunk/WebKitTools

[Qt] On Maemo5, a click/touch in the location bar (when unfocused)
should result in all text selected.

Reviewed by Ariya Hidayat.

  • QtLauncher/locationedit.cpp:

(LocationEdit::focusInEvent):

  • QtLauncher/locationedit.h:
11:46 AM Changeset in webkit [54073] by oliver@apple.com
  • 7 edits
    2 adds in trunk

2010-01-29 Oliver Hunt <​oliver@apple.com>

Reviewed by Darin Adler.

JSC is failing to propagate anonymous slot count on some transitions
​https://bugs.webkit.org/show_bug.cgi?id=34321

Remove the unsafe two argument Structure::create method, and correct
the uses of it to propagate the anonymous slot count.

  • runtime/JSObject.h: (JSC::JSObject::setStructure):
  • runtime/Structure.cpp: (JSC::Structure::addPropertyTransition): (JSC::Structure::changePrototypeTransition): (JSC::Structure::despecifyFunctionTransition): (JSC::Structure::getterSetterTransition): (JSC::Structure::toDictionaryTransition):
  • runtime/Structure.h:

2010-01-29 Oliver Hunt <​oliver@apple.com>

Reviewed by Darin Adler.

JSC is failing to propagate anonymous slot count on some transitions
​https://bugs.webkit.org/show_bug.cgi?id=34321

Add a test for modification of a type with anonymous slots.

  • fast/dom/Window/anonymous-slot-with-changes-expected.txt: Added.
  • fast/dom/Window/anonymous-slot-with-changes.html: Added.

2010-01-29 Oliver Hunt <​oliver@apple.com>

Reviewed by Darin Adler.

JSC is failing to propagate anonymous slot count on some transitions
​https://bugs.webkit.org/show_bug.cgi?id=34321

Make code generator add assertions for anonymous slot count.

Test: fast/dom/Window/anonymous-slot-with-changes.html

  • bindings/scripts/CodeGeneratorJS.pm:
11:46 AM Changeset in webkit [54072] by kenneth@webkit.org
  • 3 edits in trunk/WebKitTools

[Qt] Show progress reaching 100% for loads.

Reviewed by Ariya Hidayat.

  • QtLauncher/locationedit.cpp:

(LocationEdit::LocationEdit):
(LocationEdit::setProgress):
(LocationEdit::reset):
(LocationEdit::paintEvent):

  • QtLauncher/locationedit.h:
10:32 AM Changeset in webkit [54071] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-01-29 Tony Chang <​tony@chromium.org>

Reviewed by Darin Adler.

Add gdb helper methods for Ranges like we have for VisibleSelections.
​https://bugs.webkit.org/show_bug.cgi?id=34308

No new tests, these are only for debugging.

  • dom/Position.cpp: (WebCore::Position::showTreeForThis):
  • dom/Range.cpp: (showTree):
  • dom/Range.h:
10:13 AM Changeset in webkit [54070] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-29 Drew Wilson <​atwilson@chromium.org>

Reviewed by Adam Barth.

V8 implementation of MessageEvent.initMessageEvent() does not set source correctly.
​https://bugs.webkit.org/show_bug.cgi?id=34292

Test: fast/events/init-events.html will pass in Chrome now.

  • bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::initMessageEventCallback): Now properly extracts the reference to the DOMWindow object from the passed-in window parameter.
9:56 AM Changeset in webkit [54069] by eric@webkit.org
  • 7 edits in trunk

2010-01-29 Ben Murdoch <​benm@google.com>

Reviewed by Dimitri Glazkov.

[Android] Android needs functionality in the ChromeClient to be informed when touch events are and are not needed by the webpage.
​https://bugs.webkit.org/show_bug.cgi?id=34215

Add a function on the ChromeClient that WebCore can use to inform the platform when it needs touch events. This way the platform can optimise by not forwarding the events if they are not required.

No new tests as the only implementation is specific to Android.

  • dom/Document.cpp: (WebCore::Document::detach): Check if this is the top level document and if so, stop forwarding touch events. (WebCore::Document::addListenerTypeIfNeeded): Inform the ChromeClient it should start forwarding touch events and guard touch event code properly.
  • history/CachedFrame.cpp: (WebCore::CachedFrameBase::restore): If the document uses touch events, inform the ChromeClient to start forwarding them. (WebCore::CachedFrame::CachedFrame): If the document uses touch events, inform the ChromeClient to stop forwarding them, as the document is being put into the page cache.
  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::needTouchEvents): Add an empty implementation.
  • page/ChromeClient.h: Add the needTouchEvents() function.

2010-01-29 Ben Murdoch <​benm@google.com>

Reviewed by Dimitri Glazkov.

[Android] Android needs functionality in the ChromeClient to be informed when touch events are and are not needed by the webpage.
​https://bugs.webkit.org/show_bug.cgi?id=34215

Add needTouchEvents() to the ChromeClient which is called when the page decides it needs or no longer needs to be informed of touch events.

  • WebCoreSupport/ChromeClientQt.h: (WebCore::ChromeClientQt::needTouchEvents): Add an empty implementation.
9:38 AM Changeset in webkit [54068] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-29 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Fix toolbar gradient to match the window's titlebar on Snow Leopard
​https://bugs.webkit.org/show_bug.cgi?id=34320

  • inspector/front-end/inspector.css:
9:22 AM Changeset in webkit [54067] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-29 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Fix MacOS X version detection

MacOS X version can have 2 or 3 segments.
​https://bugs.webkit.org/show_bug.cgi?id=34322

  • inspector/front-end/inspector.js: (WebInspector._detectPlatform):
9:06 AM Changeset in webkit [54066] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-29 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Disable the QtLauncher statusbar on Maemo

​https://bugs.webkit.org/show_bug.cgi?id=34330

  • QtLauncher/main.cpp: (LauncherWindow::showLinkHover): (LauncherWindow::selectElements):
8:49 AM Changeset in webkit [54065] by eric@webkit.org
  • 4 edits
    2 copies in trunk/WebKitTools

2010-01-29 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Display page loading progress inside the QtLauncher location bar

​https://bugs.webkit.org/show_bug.cgi?id=34210

  • QtLauncher/QtLauncher.pro:
  • QtLauncher/locationedit.cpp: Added. (LocationEdit::LocationEdit): (LocationEdit::setProgress): (LocationEdit::paintEvent):
  • QtLauncher/locationedit.h: Added.
  • QtLauncher/mainwindow.cpp: (MainWindow::buildUI):
  • QtLauncher/mainwindow.h:
8:25 AM Changeset in webkit [54064] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Disable auto-uppercase and predictive text on Maemo5, just like the
build-in MicroB Browser.

Reviewed by Simon Hausmann

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::setInputMethodState):

7:43 AM Changeset in webkit [54063] by jpetsovits@rim.com
  • 8 edits
    4 adds in trunk/WebCore

2010-01-29 Jakob Petsovits <​jpetsovits@rim.com>

Reviewed by Nikolas Zimmermann.

[OpenVG] Implement a basic GraphicsContext on top of a new PainterOpenVG class
​https://bugs.webkit.org/show_bug.cgi?id=33405

PainterOpenVG provides painter state management that works
on a single (EGL) context, and apart from painter state
implements a single drawing operation (for now), drawRect().

It is a generic painter class that cooperates with
SurfaceOpenVG to enable robust surface/context switching
(given that EGL doesn't notify us if somebody switches
the surface/context behind our backs), and provides
painting operations close to OpenVG's way of working
that GraphicsContext, Path, Image, Font and other WebKit
platform classes can use to draw on.

Initial code for state management and OpenVG scissoring by
Eli Fidler <​efidler@rim.com>. VGRect/VGMatrix and the bulk
of the transformations code by Adam Treat <​atreat@rim.com>.
Preliminary drawFocusRing() implementation by Yong Li <​yoli@rim.com>.

  • platform/graphics/FloatRect.h:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/openvg/GraphicsContextOpenVG.cpp: Added. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::platformContext): (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::drawLineForText): (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): (WebCore::GraphicsContext::roundToDevicePixels): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::clearPlatformShadow): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineDash): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::canvasClip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::scale): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::origin): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::clipToImageBuffer): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::setURLForRect): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeThickness): (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::setPlatformShouldAntialias): (WebCore::GraphicsContext::setImageInterpolationQuality): (WebCore::GraphicsContext::imageInterpolationQuality):
  • platform/graphics/openvg/PainterOpenVG.cpp: Added. (WebCore::isNonRotatedAffineTransformation): (WebCore::toVGCapStyle): (WebCore::toVGJoinStyle): (WebCore::toVGFillRule): (WebCore::colorToVGColor): (WebCore::setVGSolidColor): (WebCore::PlatformPainterState::PlatformPainterState): (WebCore::PlatformPainterState::copyPaintState): (WebCore::PlatformPainterState::applyState): (WebCore::PlatformPainterState::applyBlending): (WebCore::PlatformPainterState::applyTransformationMatrix): (WebCore::PlatformPainterState::applyScissorRect): (WebCore::PlatformPainterState::applyStrokeStyle): (WebCore::PlatformPainterState::strokeDisabled): (WebCore::PlatformPainterState::fillDisabled): (WebCore::PainterOpenVG::PainterOpenVG): (WebCore::PainterOpenVG::~PainterOpenVG): (WebCore::PainterOpenVG::begin): (WebCore::PainterOpenVG::end): (WebCore::PainterOpenVG::destroyPainterStates): (WebCore::PainterOpenVG::applyState): (WebCore::PainterOpenVG::blitToSurface): (WebCore::PainterOpenVG::transformationMatrix): (WebCore::PainterOpenVG::concatTransformationMatrix): (WebCore::PainterOpenVG::setTransformationMatrix): (WebCore::PainterOpenVG::compositeOperation): (WebCore::PainterOpenVG::setCompositeOperation): (WebCore::PainterOpenVG::opacity): (WebCore::PainterOpenVG::setOpacity): (WebCore::PainterOpenVG::strokeThickness): (WebCore::PainterOpenVG::setStrokeThickness): (WebCore::PainterOpenVG::strokeStyle): (WebCore::PainterOpenVG::setStrokeStyle): (WebCore::PainterOpenVG::setLineDash): (WebCore::PainterOpenVG::setLineCap): (WebCore::PainterOpenVG::setLineJoin): (WebCore::PainterOpenVG::setMiterLimit): (WebCore::PainterOpenVG::strokeColor): (WebCore::PainterOpenVG::setStrokeColor): (WebCore::PainterOpenVG::fillColor): (WebCore::PainterOpenVG::setFillColor): (WebCore::PainterOpenVG::antialiasingEnabled): (WebCore::PainterOpenVG::setAntialiasingEnabled): (WebCore::PainterOpenVG::scale): (WebCore::PainterOpenVG::rotate): (WebCore::PainterOpenVG::translate): (WebCore::PainterOpenVG::intersectScissorRect): (WebCore::PainterOpenVG::intersectClipRect): (WebCore::PainterOpenVG::drawRect): (WebCore::PainterOpenVG::save): (WebCore::PainterOpenVG::restore):
  • platform/graphics/openvg/PainterOpenVG.h: Added. (WebCore::PainterOpenVG::): (WebCore::PainterOpenVG::surface):
  • platform/graphics/openvg/SurfaceOpenVG.cpp: (WebCore::SurfaceOpenVG::SurfaceOpenVG): (WebCore::SurfaceOpenVG::~SurfaceOpenVG): (WebCore::SurfaceOpenVG::makeCurrent): (WebCore::SurfaceOpenVG::makeCompatibleCurrent): (WebCore::SurfaceOpenVG::setActivePainter): (WebCore::SurfaceOpenVG::activePainter):
  • platform/graphics/openvg/SurfaceOpenVG.h: (WebCore::SurfaceOpenVG::):
  • platform/graphics/openvg/VGUtils.cpp: Added. (WebCore::VGMatrix::VGMatrix): (WebCore::VGMatrix::operator TransformationMatrix): (WebCore::TransformationMatrix::operator VGMatrix): (WebCore::VGRect::VGRect): (WebCore::VGRect::operator FloatRect): (WebCore::FloatRect::operator VGRect):
  • platform/graphics/openvg/VGUtils.h: (WebCore::VGMatrix::toVGfloat): (WebCore::VGRect::toVGfloat):
  • platform/graphics/transforms/TransformationMatrix.h:
7:42 AM Changeset in webkit [54062] by Philippe Normand
  • 5 edits in trunk/LayoutTests

2010-01-29 Philippe Normand <​pnormand@igalia.com>

Unreviewed, build fix.

http/tests/media/video-referer.html fails on mac
​https://bugs.webkit.org/show_bug.cgi?id=34331

Skipping the failing test. Requires further investigation.

  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac/Skipped:
7:04 AM Changeset in webkit [54061] by Philippe Normand
  • 3 edits
    4 adds in trunk

2010-01-29 Philippe Normand <​pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] Vimeo HTML5 player doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=34327

Send Referer when requesting media over HTTP.

Test: http/tests/media/video-referer.html

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback):

2010-01-29 Philippe Normand <​pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] Vimeo HTML5 player doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=34327

Test for HTTP Referer checking when playing remote media.

  • http/tests/media/resources/setCookieAndReferer.cgi: Added.
  • http/tests/media/resources/video-referer-check-referer.php: Added.
  • http/tests/media/video-referer-expected.txt: Added.
  • http/tests/media/video-referer.html: Added.
6:33 AM Changeset in webkit [54060] by Simon Hausmann
  • 3 edits in trunk/WebCore

[Qt] Speed up the WebCore::String -> QString conversion

Patch by Oswald Buddenhagen <​oswald.buddenhagen@nokia.com> on 2010-01-29
Reviewed by Simon Hausmann.

Use QString(const QChar *, int len) constructor instead of QString::fromUtf16 to
avoid BOM checks and byteswapping.

  • bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fieldNamed):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

6:10 AM Changeset in webkit [54059] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-01-29 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Source view displays text using wrong fonts
​https://bugs.webkit.org/show_bug.cgi?id=34269

  • inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype._initFont):
  • inspector/front-end/inspector.js:
6:01 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
6:00 AM Changeset in webkit [54058] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-29 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add support for Maemo zoom keys in QtLauncher

​https://bugs.webkit.org/show_bug.cgi?id=34160

  • QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::~LauncherWindow): (LauncherWindow::keyPressEvent): (LauncherWindow::grabZoomKeys):
5:48 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
5:46 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
5:41 AM Changeset in webkit [54057] by yurys@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-01-29 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Add API methods for loading inspector utility scripts.

​https://bugs.webkit.org/show_bug.cgi?id=34326

  • public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::injectedScriptSource): (WebKit::WebDevToolsAgentClient::injectedScriptDispatcherSource):
5:36 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
5:32 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
5:29 AM Changeset in webkit [54056] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-29 Philippe Normand <​pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] Apple trailers don't play anymore
​https://bugs.webkit.org/show_bug.cgi?id=34316

Fake QuickTime when accessing movie trailers.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback):
5:02 AM Changeset in webkit [54055] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Remove disabled tests from Skiplist. The tests were disabled in r53701.

  • platform/qt/Skipped: -css2.1/t1204-increment-00-c-o.html -css2.1/t1204-increment-01-c-o.html -css2.1/t1204-increment-02-c-o.html -css2.1/t1204-reset-00-c-o.html -css2.1/t1204-reset-01-c-o.html -css2.1/t1204-reset-02-c-o.html
4:17 AM Changeset in webkit [54054] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-01-29 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement the display() method of the layout test controller
​https://bugs.webkit.org/show_bug.cgi?id=34258

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::showPage): (WebCore::DumpRenderTree::hidePage):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::display):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
3:04 AM Changeset in webkit [54053] by pfeldman@chromium.org
  • 19 edits
    2 adds
    3 deletes in trunk

2010-01-29 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: migrate to tokenizer-based highlighting in the Elements panel.

​https://bugs.webkit.org/show_bug.cgi?id=34273

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/CSSSourceSyntaxHighlighter.js: Removed.
  • inspector/front-end/DOMSyntaxHighlighter.js: Added. (WebInspector.DOMSyntaxHighlighter): (WebInspector.DOMSyntaxHighlighter.prototype.createSpan): (WebInspector.DOMSyntaxHighlighter.prototype.syntaxHighlightNode):
  • inspector/front-end/ElementsTreeOutline.js:
  • inspector/front-end/JavaScriptSourceSyntaxHighlighter.js: Removed.
  • inspector/front-end/SourceCSSTokenizer.js: (WebInspector.SourceCSSTokenizer): (WebInspector.SourceCSSTokenizer.prototype.nextToken):
  • inspector/front-end/SourceCSSTokenizer.re2js:
  • inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
  • inspector/front-end/SourceHTMLTokenizer.re2js:
  • inspector/front-end/SourceJavaScriptTokenizer.js: (WebInspector.SourceJavaScriptTokenizer): (WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
  • inspector/front-end/SourceJavaScriptTokenizer.re2js:
  • inspector/front-end/SourceSyntaxHighlighter.js: Removed.
  • inspector/front-end/SourceTokenizer.js: Added. (WebInspector.SourceTokenizer): (WebInspector.SourceTokenizer.prototype.set line): (WebInspector.SourceTokenizer.prototype.set condition): (WebInspector.SourceTokenizer.prototype.get condition): (WebInspector.SourceTokenizer.prototype.hasCondition): (WebInspector.SourceTokenizer.prototype.getLexCondition): (WebInspector.SourceTokenizer.prototype.setLexCondition): (WebInspector.SourceTokenizer.prototype._charAt): (WebInspector.SourceTokenizer.Registry): (WebInspector.SourceTokenizer.Registry.getInstance): (WebInspector.SourceTokenizer.Registry.prototype.getTokenizer):
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.set mimeType):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html: LayoutTests:
  • inspector/syntax-highlight-css-expected.txt:
  • inspector/syntax-highlight-css.html:
  • inspector/syntax-highlight-javascript-expected.txt:
  • inspector/syntax-highlight-javascript.html:
  • inspector/syntax-highlight.js: (frontend_dumpSyntaxHighlight):
3:02 AM QtWebKitBackportingFixes edited by andreas.kling@nokia.com
(diff)
2:38 AM Changeset in webkit [54052] by pfeldman@chromium.org
  • 8 edits in trunk/WebCore

2010-01-29 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: No need to render background sources
when performing search.

​https://bugs.webkit.org/show_bug.cgi?id=34263

1:41 AM Changeset in webkit [54051] by yurys@chromium.org
  • 19 edits in trunk/WebCore

2010-01-29 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Adam Barth.

Remove ScriptState::frame which is only used for reporting exceptions
in some cases in a way that diverges from the regular exception reporting in
v8 bindings.

Cache ScriptState directly on v8::Context instead of providing
implementations specific for isolated worlds and ScriptController.

​https://bugs.webkit.org/show_bug.cgi?id=34266

  • bindings/js/ScriptController.cpp:
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptState.cpp: (WebCore::mainWorldScriptState):
  • bindings/js/ScriptState.h:
  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate): (WebCore::ScriptController::clearWindowShell):
  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptScope.cpp: (WebCore::ScriptScope::ScriptScope): (WebCore::ScriptScope::success):
  • bindings/v8/ScriptScope.h:
  • bindings/v8/ScriptState.cpp: (WebCore::ScriptState::ScriptState): (WebCore::ScriptState::forContext): (WebCore::ScriptState::current): (WebCore::ScriptState::weakReferenceCallback): (WebCore::mainWorldScriptState): (WebCore::scriptStateFromPage):
  • bindings/v8/ScriptState.h: (WebCore::ScriptState::ScriptState): (WebCore::EmptyScriptState::EmptyScriptState): (WebCore::EmptyScriptState::~EmptyScriptState):
  • bindings/v8/V8HiddenPropertyName.h:
  • bindings/v8/V8IsolatedContext.cpp:
  • bindings/v8/V8IsolatedContext.h:
  • bindings/v8/V8Utilities.cpp: (WebCore::getScriptExecutionContext): (WebCore::reportException):
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::V8NodeIterator::nextNodeCallback): (WebCore::V8NodeIterator::previousNodeCallback):
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::V8TreeWalker::parentNodeCallback): (WebCore::V8TreeWalker::firstChildCallback): (WebCore::V8TreeWalker::lastChildCallback): (WebCore::V8TreeWalker::nextNodeCallback): (WebCore::V8TreeWalker::previousNodeCallback): (WebCore::V8TreeWalker::nextSiblingCallback): (WebCore::V8TreeWalker::previousSiblingCallback):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::injectedScriptForNodeId):
1:23 AM Changeset in webkit [54050] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Rubber-stamped by Maciej Stachowiak.

Fix the ARM build.

  • runtime/JSNumberCell.h:

(JSC::JSNumberCell::createStructure): Call the right Structure::create overload.

12:43 AM Changeset in webkit [54049] by darin@chromium.org
  • 13 edits in trunk

2010-01-29 Darin Fisher <​darin@chromium.org>

Reviewed by Adam Barth.

Add FrameLoaderClient::allowImages method to allow the client to
overrule image loading policy on a per frame basis.

​https://bugs.webkit.org/show_bug.cgi?id=34225

For completeness, this patch also adds Settings::areImagesEnabled.
This is different from loadsImagesAutomatically as is explained in
Settings.h.

  • loader/DocLoader.cpp: (WebCore::DocLoader::requestImage):
  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::allowImages):
  • loader/ImageDocument.cpp: (WebCore::ImageTokenizer::writeRawData):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setImagesEnabled):
  • page/Settings.h: (WebCore::Settings::areImagesEnabled):

Jan 28, 2010:

11:42 PM Changeset in webkit [54048] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-01-28 Nicholas Young <​nicholas.young@nokia.com>

Reviewed by Eric Carlson.

Prefer provided video element width/height properties to hard coded
defaults for intrinsic size when natural video size is unavailable.
​https://bugs.webkit.org/show_bug.cgi?id=34302

No new tests needed.

  • rendering/RenderVideo.cpp: Attempt to use width/height properties (WebCore::RenderVideo::RenderVideo):
  • rendering/RenderVideo.h: More appropriate constructor signature
11:16 PM Changeset in webkit [54047] by oliver@apple.com
  • 5 edits in trunk

2010-01-28 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

MessageEvent.data should not be repeated deserialised
​https://bugs.webkit.org/show_bug.cgi?id=34311

Add test to ensure we get the same value back when accessing event.data multiple times

  • fast/dom/Window/window-postmessage-clone.html:

2010-01-28 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

MessageEvent.data should not be repeated deserialised
​https://bugs.webkit.org/show_bug.cgi?id=34311

Cache the result of deserialising the event data

  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/MessageEvent.idl:
11:15 PM Changeset in webkit [54046] by jorlow@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-01-28 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

StorageNamespaceProxy::copy() should be a no-op
​https://bugs.webkit.org/show_bug.cgi?id=34298

The comment in the code should make clear why.

  • public/WebViewClient.h:
  • src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespaceProxy::copy):
11:01 PM Changeset in webkit [54045] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2010-01-28 Hayato Ito <​hayato@chromium.org>

Reviewed by Darin Adler.

Change CSS 'page-break-inside' property from inherited one to non-inherited one because CSS specification defines so.

Note: Currently, the 'page-break-inside' property is used only when parsing the CSS. That property is not used when rendering.

​https://bugs.webkit.org/show_bug.cgi?id=34195

  • fast/css/getComputedStyle/computed-style-page-break-inside-expected.txt: Added.
  • fast/css/getComputedStyle/computed-style-page-break-inside.html: Added.
  • fast/css/getComputedStyle/script-tests/computed-style-page-break-inside.js: Added.

2010-01-28 Hayato Ito <​hayato@chromium.org>

Reviewed by Darin Adler.

Change CSS 'page-break-inside' property from inherited one to non-inherited one because CSS specification defines so.

Note: Currently, the 'page-break-inside' property is used only when parsing the CSS. That property is not used when rendering.

​https://bugs.webkit.org/show_bug.cgi?id=34195

  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::NonInheritedFlags::operator==): (WebCore::InheritedFlags::setBitDefaults): (WebCore::InheritedFlags::pageBreakInside): (WebCore::InheritedFlags::setPageBreakInside):
  • rendering/style/StyleInheritedData.cpp: (WebCore::StyleInheritedData::StyleInheritedData): (WebCore::StyleInheritedData::operator==):
  • rendering/style/StyleInheritedData.h:
10:41 PM Changeset in webkit [54044] by eric@webkit.org
  • 7 edits
    4 adds in trunk

2010-01-28 Michael Nordman <Michael Nordman>

Reviewed by Alexey Proskuryakov.

ApplicationCache events should be deferred until after Document onload has fired.
​https://bugs.webkit.org/show_bug.cgi?id=29690

  • http/tests/appcache/deferred-events-expected.txt: Added.
  • http/tests/appcache/deferred-events.html: Added.
  • http/tests/appcache/deferred-events-delete-while-raising-expected.txt: Added.
  • http/tests/appcache/deferred-events-delete-while-raising.html: Added.

2010-01-28 Michael Nordman <Michael Nordman>

Reviewed by Alexey Proskuryakov.

ApplicationCache events should be deferred until after Document onload has fired.
​https://bugs.webkit.org/show_bug.cgi?id=29690

Test: http/tests/appcache/deferred-events.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::handledOnloadEvents): Tells the ApplicationCacheHost to stop deferring events.
  • loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::ApplicationCacheHost): Initialize m_isDeferringEvents to true. (WebCore::ApplicationCacheHost::notifyDOMApplicationCache): Depending, defer or raise the event. (WebCore::ApplicationCacheHost::stopDeferringEvents): Raise any deferred events and reset the flag.
  • loader/appcache/ApplicationCacheHost.h: Declare new data members and method.

2010-01-28 Michael Nordman <Michael Nordman>

Reviewed by Alexey Proskuryakov.

ApplicationCache events should be deferred until after Document onload has fired.
​https://bugs.webkit.org/show_bug.cgi?id=29690

  • src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::ApplicationCacheHost): Initialize m_isDeferringEvents to true. (WebCore::ApplicationCacheHost::notifyDOMApplicationCache): Depending, defer or raise the event. (WebCore::ApplicationCacheHost::stopDeferringEvents): Raise any deferred events and reset the flag.
10:11 PM Changeset in webkit [54043] by kevino@webkit.org
  • 5 edits in trunk

[wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation
implements pthread_t in a way that makes it impossible to check its validity,
which is needed by ThreadingPthreads.cpp.

8:49 PM Changeset in webkit [54042] by eric@webkit.org
  • 41 edits
    3 deletes in trunk/WebCore

2010-01-28 Kavita Kanetkar <​kkanetkar@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Generate header declaration for custom constructor callbacks
​https://bugs.webkit.org/show_bug.cgi?id=33680

Added handling of 'CanBeConstructed' and 'OmitConstructor' and a new extended attribute
CustomConstructor'.

Deleted implementation .cpp files for corresponding 'CanBeConstructed'
extended attributes. These are now generated via CodeGeneratorV8.pm
Treating 'OmitConstructor' and 'CustomConstructor' to be the same in
CodeGeneratorJS.pm
Cleaned idls that had 'CustomConstructor' and 'OmitConstructor' together, and
same with CustomConstructor and CanBeConstructed.

  • Android.v8bindings.mk:
  • WebCore.gypi: Removed deps for classes being generated.
  • bindings/scripts/CodeGeneratorJS.pm: OmitConstructor and CustomConstructor have the same behavior in generator.
  • bindings/scripts/CodeGeneratorV8.pm: Generating the callbacks for constructors.
  • bindings/v8/V8DOMWrapper.cpp: Removed manual calls to SetCallHandler() for constructor callbacks. (WebCore::V8DOMWrapper::getTemplate):
  • bindings/v8/custom/V8CustomBinding.h: Removed manual declarations of constructor callbacks.
  • bindings/v8/custom/V8DOMParserConstructor.cpp:
  • bindings/v8/custom/V8EventSourceConstructor.cpp: (WebCore::V8EventSource::constructorCallback):
  • bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::V8MessageChannel::constructorCallback):
  • bindings/v8/custom/V8SharedWorkerCustom.cpp: (WebCore::V8SharedWorker::constructorCallback):
  • bindings/v8/custom/V8WebGLArrayBufferCustom.cpp: (WebCore::V8WebGLArrayBuffer::constructorCallback):
  • bindings/v8/custom/V8WebGLByteArrayCustom.cpp: (WebCore::V8WebGLByteArray::constructorCallback):
  • bindings/v8/custom/V8WebGLFloatArrayCustom.cpp: (WebCore::V8WebGLFloatArray::constructorCallback):
  • bindings/v8/custom/V8WebGLIntArrayCustom.cpp: (WebCore::V8WebGLIntArray::constructorCallback):
  • bindings/v8/custom/V8WebGLShortArrayCustom.cpp: (WebCore::V8WebGLShortArray::constructorCallback):
  • bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp: (WebCore::V8WebGLUnsignedByteArray::constructorCallback):
  • bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp: (WebCore::V8WebGLUnsignedIntArray::constructorCallback):
  • bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp: (WebCore::V8WebGLUnsignedShortArray::constructorCallback):
  • bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: (WebCore::V8WebKitCSSMatrix::constructorCallback):
  • bindings/v8/custom/V8WebKitPointConstructor.cpp: (WebCore::V8WebKitPoint::constructorCallback):
  • bindings/v8/custom/V8WebSocketCustom.cpp: (WebCore::V8WebSocket::constructorCallback):
  • bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::V8Worker::constructorCallback):
  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: (WebCore::V8XMLHttpRequest::constructorCallback):
  • bindings/v8/custom/V8XMLSerializerConstructor.cpp:
  • bindings/v8/custom/V8XPathEvaluatorConstructor.cpp: Deleted the file. Implementation now being generated.
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp: Deleted the file. Implementation now being generated. (WebCore::V8XSLTProcessor::constructorCallback): Deleted the file. Implementation now being generated.
  • css/WebKitCSSMatrix.idl: Added CustomConstructor attribute.
  • dom/MessageChannel.idl: Added CustomConstructor attribute.
  • html/canvas/WebGLArrayBuffer.idl: Added CustomConstructor attribute.
  • html/canvas/WebGLByteArray.idl: Added CustomConstructor attribute.
  • html/canvas/WebGLFloatArray.idl: Added CustomConstructor attribute.
  • html/canvas/WebGLIntArray.idl: Added CustomConstructor attribute.
  • html/canvas/WebGLShortArray.idl: Added CustomConstructor attribute.
  • html/canvas/WebGLUnsignedByteArray.idl: Added CustomConstructor attribute.
  • html/canvas/WebGLUnsignedIntArray.idl: Added CustomConstructor attribute.
8:27 PM Changeset in webkit [54041] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-01-28 Steve Block <​steveblock@google.com>

Reviewed by David Levin.

Add stub for AXObjectCache::contentChanged when HAVE(ACCESSIBILITY) is not defined
​https://bugs.webkit.org/show_bug.cgi?id=34271

No new tests, build fix only.

  • accessibility/AXObjectCache.cpp: Modified. Added HAVE(ACCESSIBILITY) guards around contentChanged
  • accessibility/AXObjectCache.h: Modified. (WebCore::AXObjectCache::contentChanged): Added stub
8:00 PM Changeset in webkit [54040] by oliver@apple.com
  • 4 edits in trunk

2010-01-28 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

DOM Objects shouldn't all require custom mark functions
​https://bugs.webkit.org/show_bug.cgi?id=34291

Make getAnonymousValue const-friendly

  • runtime/JSObject.h: (JSC::JSObject::getAnonymousValue):

2010-01-28 Steve Block <​steveblock@google.com>

Reviewed by David Levin.

Use long long rather than int64 in V8Binding.h
​https://bugs.webkit.org/show_bug.cgi?id=34270

No new tests, build fix only.

  • bindings/v8/V8Binding.h: Modified. (WebCore::toInt64): Returns long long
7:47 PM WebKit Team edited by abecsi@webkit.org
(diff)
7:40 PM Changeset in webkit [54039] by abecsi@webkit.org
  • 2 edits in trunk/WebKitTools

Adding myself to the committer list. No review needed.

  • Scripts/webkitpy/committers.py:
6:57 PM Changeset in webkit [54038] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-28 Steve Block <​steveblock@google.com>

Reviewed by David Levin.

Use long long rather than int64 in V8Binding.h
​https://bugs.webkit.org/show_bug.cgi?id=34270

No new tests, build fix only.

  • bindings/v8/V8Binding.h: Modified. (WebCore::toInt64): Returns long long
6:41 PM Changeset in webkit [54037] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-28 Avi Drissman <​avi@chromium.org>

Reviewed by David Levin.

Unused variable in ThemeMac (followup to change 49103).
​https://bugs.webkit.org/show_bug.cgi?id=34274

Covered by existing tests.

  • platform/mac/ThemeMac.mm: (WebCore::setupButtonCell):
6:10 PM Changeset in webkit [54036] by enrica@apple.com
  • 6 edits in trunk

Huge plain text pastes are slow
<rdar://problem/5195056>
​https://bugs.webkit.org/show_bug.cgi?id=34237

Reviewed by Maciej Stachowiak.

WebCore:

No new tests. It is a performance improvement.

The performance of the plain text paste is now linear.
We treat as a special case, a fragment that has been
created from plain text. Finding VisiblePositions and
applying style is greatly simplified, given the nature of
the fragment.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply):

  • editing/markup.cpp:

(WebCore::isPlainTextMarkup):

  • editing/markup.h:

WebKit/mac:

Mail is ignoring the fragment created from plain text or HTML that is
passed to the delegate function, that creates a new one.
This fix avoids creating the fragment twice.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):

5:57 PM Changeset in webkit [54035] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

Initialize DOM Storage's quota's current length parameter when we clone it.
​https://bugs.webkit.org/show_bug.cgi?id=34294

Patch by Jeremy Orlow <​jorlow@chromium.org> on 2010-01-28
Reviewed by Adam Barth.

  • storage/StorageMap.cpp:

(WebCore::StorageMap::copy):

5:49 PM Changeset in webkit [54034] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-01-28 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Support kinetic scrolling on Maemo 5

​https://bugs.webkit.org/show_bug.cgi?id=34267

Patch by Ralf Engels <​ralf.engels@nokia.com> and
Robert Griebl <​rgriebl@trolltech.com>

  • Api/qwebview.cpp: (QWebViewKineticScroller::QWebViewKineticScroller): (QWebViewKineticScroller::eventFilter): (QWebViewKineticScroller::currentFrame): (QWebViewKineticScroller::scrollingFrameAt): (QWebViewKineticScroller::attachToWidget): (QWebViewKineticScroller::removeFromWidget): (QWebViewKineticScroller::positionRange): (QWebViewKineticScroller::position): (QWebViewKineticScroller::viewportSize): (QWebViewKineticScroller::setPosition): (QWebView::QWebView):
5:32 PM Changeset in webkit [54033] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-28 Hayato Ito <​hayato@chromium.org>

Reviewed by David Levin.

Remove NULL char from input JS file because 'grep' fails if the file contains NULL char.

​https://bugs.webkit.org/show_bug.cgi?id=34252

  • Scripts/make-script-test-wrappers:
5:28 PM Changeset in webkit [54032] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed build fix after r53411 on WinCairo.

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::frameCount):

5:21 PM Changeset in webkit [54031] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

5:15 PM Changeset in webkit [54030] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-28 Nayan Kumar K <​nayankk@gmail.com>

Reviewed by Laszlo Gombos.

Fix for compilation error in WML enabled build introduced because of the changeset 53514.

​https://bugs.webkit.org/show_bug.cgi?id=34254

  • wml/WMLDocument.cpp: (WebCore::WMLDocument::WMLDocument):
4:57 PM Changeset in webkit [54029] by eric@webkit.org
  • 8 edits in trunk

2010-01-28 Alex Milowski <​alex@milowski.com>

Reviewed by Eric Seidel.

Updates from CSS change for mathml.css

  • platform/mac/mathml/presentation/sub-expected.txt:
  • platform/mac/mathml/presentation/sup-expected.txt:
  • platform/mac/mathml/presentation/tables-expected.checksum:
  • platform/mac/mathml/presentation/tables-expected.png:
  • platform/mac/mathml/presentation/tables-expected.txt:

2010-01-28 Alex Milowski <​alex@milowski.com>

Reviewed by Eric Seidel.

Update to CSS to remove unnecessary line-height settings

  • css/mathml.css:
4:31 PM Changeset in webkit [54028] by steveblock@google.com
  • 4 edits in trunk/WebCore

Add missing includes for HashMap/HashSet
​https://bugs.webkit.org/show_bug.cgi?id=34276

Reviewed by David Levin.

No new tests, build fix only.

  • platform/KURL.cpp: Modified. Include HashMap.h
  • platform/network/CredentialStorage.cpp: Modified. Include HashMap.h and HashSet.h
  • platform/network/ProtectionSpaceHash.h: Modified. Include HashTraits.h
4:20 PM Changeset in webkit [54027] by kov@webkit.org
  • 1 edit in trunk/LayoutTests/http/tests/media/resources/setCookie.cgi

Add missing svn:executable property on LayoutTests/http/tests/media/resources/setCookie.cgi

3:56 PM Changeset in webkit [54026] by kov@webkit.org
  • 5 edits
    4 adds in trunk

2010-01-28 Sebastian Dröge <​sebastian.droege@collabora.co.uk>

Reviewed by Gustavo Noronha.

Pass cookies to the GStreamer HTTP source
​https://bugs.webkit.org/show_bug.cgi?id=34003

Test: http/tests/media/video-cookie.html

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback): When using an appropiate GStreamer HTTP source element, pass the cookies for the media URI to it. This fixes playback of the YouTube HTML5 videos.
3:50 PM Changeset in webkit [54025] by Csaba Osztrogonác
  • 4 edits in trunk/WebCore

[Qt] Unreviewed buildfix after r54022.

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtRuntimeObjectImp::createStructure):

  • bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::QtPixmapRuntimeObjectImp::createStructure):

  • bridge/qt/qt_runtime.h:

(JSC::Bindings::QtRuntimeMethod::createStructure):

3:19 PM Changeset in webkit [54024] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Incorrect small caps vs. normal text handling
​https://bugs.webkit.org/show_bug.cgi?id=34286

  • platform/qt/Skipped: css2.1/t1505-c524-font-var-00-b.html skipped
3:03 PM Changeset in webkit [54023] by Adam Roben
  • 2 edits in trunk/WebCore

Fix an assertion beneath SerializedScriptValue::deserialize on 32-bit builds (e.g., on Windows)

Passing a JSValue to toRef on 32-bit builds can perform an allocation,
so we need to make sure we hold a JSLock when that occurs.

Reviewed by Oliver Hunt.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValueData::serialize):
(WebCore::SerializedScriptValueData::deserialize):
Moved JSLocks from here...

(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):
...to this higher level, from which toRef can be called.

2:51 PM Changeset in webkit [54022] by oliver@apple.com
  • 49 edits in trunk

2010-01-28 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Simplify anonymous slot implementation
​https://bugs.webkit.org/show_bug.cgi?id=34282

A class must now specify the number of slots it needs at construction time
rather than later on with a transition. This makes many things simpler,
we no longer need to need an additional transition on object creation to
add the anonymous slots, and we remove the need for a number of transition
type checks.

  • API/JSCallbackConstructor.h: (JSC::JSCallbackConstructor::createStructure):
  • API/JSCallbackFunction.h: (JSC::JSCallbackFunction::createStructure):
  • API/JSCallbackObject.h: (JSC::JSCallbackObject::createStructure):
  • JavaScriptCore.exp:
  • debugger/DebuggerActivation.h: (JSC::DebuggerActivation::createStructure):
  • runtime/Arguments.h: (JSC::Arguments::createStructure):
  • runtime/BooleanObject.h: (JSC::BooleanObject::createStructure):
  • runtime/DateInstance.h: (JSC::DateInstance::createStructure):
  • runtime/DatePrototype.h: (JSC::DatePrototype::createStructure):
  • runtime/FunctionPrototype.h: (JSC::FunctionPrototype::createStructure):
  • runtime/GetterSetter.h: (JSC::GetterSetter::createStructure):
  • runtime/GlobalEvalFunction.h: (JSC::GlobalEvalFunction::createStructure):
  • runtime/InternalFunction.h: (JSC::InternalFunction::createStructure):
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure):
  • runtime/JSActivation.h: (JSC::JSActivation::createStructure):
  • runtime/JSArray.h: (JSC::JSArray::createStructure):
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::createStructure):
  • runtime/JSCell.h: (JSC::JSCell::createDummyStructure):
  • runtime/JSFunction.h: (JSC::JSFunction::createStructure):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::createStructure):
  • runtime/JSNotAnObject.h: (JSC::JSNotAnObject::createStructure):
  • runtime/JSONObject.h: (JSC::JSONObject::createStructure):
  • runtime/JSObject.h: (JSC::JSObject::createStructure): (JSC::JSObject::putAnonymousValue): (JSC::JSObject::getAnonymousValue):
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::createStructure):
  • runtime/JSStaticScopeObject.h: (JSC::JSStaticScopeObject::createStructure):
  • runtime/JSString.h: (JSC::Fiber::createStructure):
  • runtime/JSVariableObject.h: (JSC::JSVariableObject::createStructure):
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::createStructure): (JSC::JSWrapperObject::JSWrapperObject):
  • runtime/MathObject.h: (JSC::MathObject::createStructure):
  • runtime/NumberConstructor.h: (JSC::NumberConstructor::createStructure):
  • runtime/NumberObject.h: (JSC::NumberObject::createStructure):
  • runtime/RegExpConstructor.h: (JSC::RegExpConstructor::createStructure):
  • runtime/RegExpObject.h: (JSC::RegExpObject::createStructure):
  • runtime/StringObject.h: (JSC::StringObject::createStructure):
  • runtime/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
  • runtime/Structure.cpp: (JSC::Structure::~Structure): (JSC::Structure::materializePropertyMap):
  • runtime/Structure.h: (JSC::Structure::create): (JSC::Structure::anonymousSlotCount):
  • runtime/StructureTransitionTable.h:

2010-01-28 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Simplify anonymous slot implementation
​https://bugs.webkit.org/show_bug.cgi?id=34282

Update JSGlue Structure usage to pass the anonymous slot count.

  • UserObjectImp.h: (UserObjectImp::createStructure):

2010-01-28 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Simplify anonymous slot implementation
​https://bugs.webkit.org/show_bug.cgi?id=34282

Update the WebCore JS DOM bindings to correctly pass and
propagate the anonymous slot count information.

  • bindings/js/JSDOMBinding.h: (WebCore::DOMObjectWithGlobalPointer::createStructure): (WebCore::DOMConstructorObject::createStructure):
  • bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::createStructure):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/objc/objc_runtime.h: (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
  • bridge/runtime_array.h: (JSC::RuntimeArray::createStructure):
  • bridge/runtime_method.h: (JSC::RuntimeMethod::createStructure):
  • bridge/runtime_object.h: (JSC::RuntimeObjectImp::createStructure):
2:37 PM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
2:26 PM Changeset in webkit [54021] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

[wx] Build fix after removal of the zlib image decoder.

2:17 PM Changeset in webkit [54020] by evan@chromium.org
  • 4 edits
    4 adds in trunk

2010-01-27 Evan Martin <​evan@chromium.org>

Reviewed by David Levin.

[chromium] hebrew vowel marks incorrectly positioned
​https://bugs.webkit.org/show_bug.cgi?id=34234

Add a layout test containing some Hebrew vowels.

  • fast/text/international/hebrew-vowels.html: Added.

2010-01-27 Evan Martin <​evan@chromium.org>

Reviewed by David Levin.

[chromium] hebrew vowel marks incorrectly positioned
​https://bugs.webkit.org/show_bug.cgi?id=34234

Fix glyph metrics computation such that the glyph offsets
are correct, so we can now make use of them.

Test: fast/text/international/hebrew-vowels.html

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::createGlyphArrays): initialize per-glyph offset table. (WebCore::TextRunWalker::setGlyphXPositions): use per-glyph offsets.
  • platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::getGlyphMetrics): fix metrics computation such that per-glyph offsets are computed correctly.
2:08 PM Changeset in webkit [54019] by Laszlo Gombos
  • 2 edits in trunk/WebCore

2010-01-28 Laszlo Gombos <Laszlo Gombos>

Unreviewed build fix.

[Qt] Build fix if websockets support is turned off after r53947.

  • WebCore.pro:
1:47 PM Changeset in webkit [54018] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

1:46 PM Changeset in webkit [54017] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.22.2

New tag.

1:44 PM Changeset in webkit [54016] by Dimitri Glazkov
  • 19 edits in trunk/WebCore

2010-01-28 Dimitri Glazkov <Dimitri Glazkov>

No review, rolling out r54012.
​http://trac.webkit.org/changeset/54012
​https://bugs.webkit.org/show_bug.cgi?id=34266

Introduced 33 crashes in V8 traversal/ tests.

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptState.cpp:
  • bindings/js/ScriptState.h:
  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState): (WebCore::ScriptController::currentScriptState): (WebCore::ScriptController::clearWindowShell):
  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptScope.cpp: (WebCore::ScriptScope::ScriptScope): (WebCore::ScriptScope::success):
  • bindings/v8/ScriptScope.h:
  • bindings/v8/ScriptState.cpp: (WebCore::ScriptState::ScriptState): (WebCore::scriptStateFromPage):
  • bindings/v8/ScriptState.h: (WebCore::ScriptState::ScriptState): (WebCore::ScriptState::frame):
  • bindings/v8/V8HiddenPropertyName.h:
  • bindings/v8/V8IsolatedContext.cpp: (WebCore::V8IsolatedContext::scriptState):
  • bindings/v8/V8IsolatedContext.h:
  • bindings/v8/V8Utilities.cpp: (WebCore::getScriptExecutionContext): (WebCore::reportException):
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::V8NodeIterator::nextNodeCallback): (WebCore::V8NodeIterator::previousNodeCallback):
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::V8TreeWalker::parentNodeCallback): (WebCore::V8TreeWalker::firstChildCallback): (WebCore::V8TreeWalker::lastChildCallback): (WebCore::V8TreeWalker::nextNodeCallback): (WebCore::V8TreeWalker::previousNodeCallback): (WebCore::V8TreeWalker::nextSiblingCallback): (WebCore::V8TreeWalker::previousSiblingCallback):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::injectedScriptForNodeId):
1:36 PM Changeset in webkit [54015] by aa@chromium.org
  • 12 edits in trunk

Reapply 54008: Expand the NotificationPresenter::checkPermission() interface
to send the full URL of the requesting context, as well as a pointer to the
document if that context was a document.

1:34 PM Changeset in webkit [54014] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-01-28 Steve Block <​steveblock@google.com>

Reviewed by Adam Barth.

Fix missing forward-declarations and includes in V8 bindings
​https://bugs.webkit.org/show_bug.cgi?id=34272

No new tests, build fix only.

  • bindings/v8/ScriptController.h: Modified. Forward-declare NPObject
  • bindings/v8/V8DOMWindowShell.cpp: Modified. Include CString.h and PlatformBridge.h
  • bindings/v8/V8DOMWrapper.h: Modified. Forward-declare V8Proxy
1:24 PM Changeset in webkit [54013] by Dimitri Glazkov
  • 3 edits in trunk/LayoutTests

2010-01-28 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, trivial baseline update.

Update baseline for "Animated scaling of background-image is too slow"
​https://bugs.webkit.org/show_bug.cgi?id=33808

  • platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize16-expected.png:
1:05 PM Changeset in webkit [54012] by yurys@chromium.org
  • 19 edits in trunk/WebCore

2010-01-28 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Adam Barth.

Remove ScriptState::frame which is only used for reporting exceptions
in some cases in a way that diverges from the regular exception reporting in
v8 bindings.


Cache ScriptState directly on v8::Context instead of providing
implementations specific for isolated worlds and ScriptController.

​https://bugs.webkit.org/show_bug.cgi?id=34266

  • bindings/js/ScriptController.cpp:
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptState.cpp: (WebCore::mainWorldScriptState):
  • bindings/js/ScriptState.h:
  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell):
  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptScope.cpp: (WebCore::ScriptScope::ScriptScope): (WebCore::ScriptScope::success):
  • bindings/v8/ScriptScope.h:
  • bindings/v8/ScriptState.cpp: (WebCore::ScriptState::ScriptState): (WebCore::ScriptState::forContext): (WebCore::ScriptState::current): (WebCore::ScriptState::empty): (WebCore::ScriptState::weakReferenceCallback): (WebCore::mainWorldScriptState): (WebCore::scriptStateFromPage):
  • bindings/v8/ScriptState.h:
  • bindings/v8/V8HiddenPropertyName.h:
  • bindings/v8/V8IsolatedContext.cpp:
  • bindings/v8/V8IsolatedContext.h:
  • bindings/v8/V8Utilities.cpp: (WebCore::getScriptExecutionContext): (WebCore::reportException):
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::V8NodeIterator::nextNodeCallback): (WebCore::V8NodeIterator::previousNodeCallback):
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::V8TreeWalker::parentNodeCallback): (WebCore::V8TreeWalker::firstChildCallback): (WebCore::V8TreeWalker::lastChildCallback): (WebCore::V8TreeWalker::nextNodeCallback): (WebCore::V8TreeWalker::previousNodeCallback): (WebCore::V8TreeWalker::nextSiblingCallback): (WebCore::V8TreeWalker::previousSiblingCallback):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::injectedScriptForNodeId):
12:38 PM Changeset in webkit [54011] by aa@chromium.org
  • 12 edits in trunk

revert

12:34 PM Changeset in webkit [54010] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

2010-01-28 Adam Barth <​abarth@webkit.org>

Reviewed by David Levin.

Remove XSSAuditor false positive for Google Translate
​https://bugs.webkit.org/show_bug.cgi?id=34242

Add a test that we allow attackers to inject directly into the href
property of the base tag.

  • http/tests/security/xssAuditor/base-href-direct-expected.txt: Added.
  • http/tests/security/xssAuditor/base-href-direct.html: Added.
  • http/tests/security/xssAuditor/resources/echo-head-base-href-direct.pl: Added.

2010-01-28 Adam Barth <​abarth@webkit.org>

Reviewed by David Levin.

Remove XSSAuditor false positive for Google Translate
​https://bugs.webkit.org/show_bug.cgi?id=34242

Google translate takes a base URL as a parameter, causing a false
positive in the XSS filter. This patch removes the false positive by
allowing direct injections into the href property of the base tag.

Test: http/tests/security/xssAuditor/base-href-direct.html

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::canSetBaseElementURL):
12:27 PM Changeset in webkit [54009] by Nikolas Zimmermann
  • 17 edits
    1 add in trunk/WebCore

2010-01-28 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Save additional memory in SVG*Element classes, by introducing SVGElementRareData
​https://bugs.webkit.org/show_bug.cgi?id=34268

Introduce SVGElementRareData, to remove the need to store any members in SVGElement/SVGStyledElement.
This saves some additional MB for the svg-node-count-vs-scroll.xhtml testcase.

SVGElementRareData works just like NodeRareData. Unlike ElementRareData, we're not inheriting from
NodeRareData in SVG, as we don't need all the rare data stored there, unlike Element.

  • GNUmakefile.am: Add SVGElementRareData.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/Node.cpp: Use Nodes bitfield to keep track wheter a SVGElement has a SVGElementRareData object associated. (WebCore::Node::Node):
  • dom/Node.h: Add m_hasRareSVGData flag, merged with the existing bitfield, 10 bits remaining now. (WebCore::Node::hasRareSVGData):
  • svg/SVGAnimateMotionElement.cpp: SVGElement::instancesForElement() now returns a const-reference to the HashMap instead of copying. (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
  • svg/SVGAnimateTransformElement.cpp: Ditto. (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
  • svg/SVGAnimationElement.cpp: Ditto. (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
  • svg/SVGElement.cpp: Move the element instances HashSet and two cursor-related pointers into SVGElementRareData. (WebCore::SVGElement::SVGElement): (WebCore::SVGElement::~SVGElement): (WebCore::SVGElement::rareSVGData): Modelled just like Node::rareData(). (WebCore::SVGElement::ensureRareSVGData): Dito. (WebCore::SVGElement::accessDocumentSVGExtensions): (WebCore::SVGElement::mapInstanceToElement): Route call through SVGElementRareData. (WebCore::SVGElement::removeInstanceMapping): Ditto. (WebCore::SVGElement::instancesForElement): Ditto. (WebCore::SVGElement::setCursorElement): Ditto. (WebCore::SVGElement::setCursorImageValue): Ditto.
  • svg/SVGElement.h:
  • svg/SVGElementInstance.cpp: Ditto. (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
  • svg/SVGElementRareData.h: Added. Based on NodeRareData - works exactly the same. (WebCore::SVGElementRareData::SVGElementRareData): (WebCore::SVGElementRareData::rareDataMap): (WebCore::SVGElementRareData::rareDataFromMap): (WebCore::SVGElementRareData::elementInstances): (WebCore::SVGElementRareData::instanceUpdatesBlocked): (WebCore::SVGElementRareData::setInstanceUpdatesBlocked): (WebCore::SVGElementRareData::cursorElement): (WebCore::SVGElementRareData::setCursorElement): (WebCore::SVGElementRareData::cursorImageValue): (WebCore::SVGElementRareData::setCursorImageValue):
  • svg/SVGStyledElement.cpp: Move m_instancesUpdatesBlocked into SVGElementRareData. (WebCore::SVGStyledElement::SVGStyledElement): (WebCore::SVGStyledElement::instanceUpdatesBlocked): (WebCore::SVGStyledElement::setInstanceUpdatesBlocked):
  • svg/SVGStyledElement.h:
  • svg/SVGUseElement.cpp: Adapt to element instances changes, now passed as const-reference. (WebCore::dumpInstanceTree):
11:24 AM Changeset in webkit [54008] by aa@chromium.org
  • 13 edits in trunk

2010-01-28 Aaron Boodman <​aa@chromium.org>

Reviewed by Darin Adler.

Expand the NotificationPresenter::checkPermission() interface to send the full
URL of the requesting context, as well as a pointer to the document if that
context was a document.

​https://bugs.webkit.org/show_bug.cgi?id=34238

  • notifications/Notification.cpp: (WebCore::Notification::Notification):
  • notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::NotificationCenter): (WebCore::NotificationCenter::checkPermission): Pass the full URL and document from the requesting context when calling NotificationPresenter::checkPermission().
  • notifications/NotificationPresenter.h: (WebCore::NotificationPresenter::): Expand interface.

2010-01-27 Aaron Boodman <​aa@chromium.org>

Reviewed by Darin Adler.

Send full URL and application id of requesting context to Chromium
when checking notification permissions.

​https://bugs.webkit.org/show_bug.cgi?id=34238

  • public/WebDocument.h:
  • src/WebDocument.cpp: (WebKit::WebDocument::applicationID): Implement applicationID() method.
  • public/WebNotificationPresenter.h:
  • src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission):
  • src/NotificationPresenterImpl.h: Send applicationID and full URL through to Chromium.

2010-01-27 Aaron Boodman <​aa@chromium.org>

Expand NotificationCenter::checkPermission() interface.
It now passes the full URL instead of just the origin.

​https://bugs.webkit.org/show_bug.cgi?id=34238

  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::checkPermission):
  • WebCoreSupport/WebDesktopNotificationsDelegate.h:
10:34 AM Changeset in webkit [54007] by jam@chromium.org
  • 2 edits in trunk/LayoutTests/fast/dom/Window

Unreviewed, trivial expectations update.

10:08 AM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
10:07 AM Changeset in webkit [54006] by Simon Fraser
  • 6 edits
    4 adds in trunk

2010-01-28 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Video can overlap position:fixed element when scrolling
​https://bugs.webkit.org/show_bug.cgi?id=32180

When the scroll position changes, and we're using overlap to decide what gets composited,
then we need to re-evaluate what gets compositing when scrolling in case fixed postion elements
overlap composited elements (e.g. video).

Test: compositing/geometry/video-fixed-scrolling.html

  • page/FrameView.cpp: (WebCore::FrameView::updateCompositingLayers): (WebCore::FrameView::scrollPositionChanged): Annotate the calls to updateCompositingLayers() with the type of change that occurred.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded): Ditto.
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers): For scroll changes, check for hierarchy update if m_compositingConsultsOverlap is true, and do a geometry update. For other changes, always check for hierarchy updates.
9:47 AM Changeset in webkit [54005] by hyatt@apple.com
  • 7 edits
    2 adds in trunk

Fix for user stylesheet bugs where they get parsed using the wrong compatibility mode. This was a regression
caused from Safari 3 -> 4 by the Acid3 fixes to create a real DOCTYPE in the DOM.

Reviewed by Darin Adler.

This patch makes style selector creation lazy, so that the selector isn't built unless someone asks for it.

In order to avoid creating the style selector before the compatibility mode has been determined, document
style is now created without having a dependence on an instantiated style selector. The creation of the style
is now done as a static method on CSSStyleSelector called styleForDocument, and a couple of font-related
functions have been made static as well so that they can be used by this method.

m_styleSelector on Document is now an OwnPtr.

Added userscripts/mixed-case-stylesheet.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForDocument):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::checkForGenericFamilyChange):
(WebCore::CSSStyleSelector::setFontSize):
(WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
(WebCore::CSSStyleSelector::fontSizeForKeyword):

  • css/CSSStyleSelector.h:
  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::createStyleSelector):
(WebCore::Document::attach):
(WebCore::Document::setVisuallyOrdered):
(WebCore::Document::recalcStyleSelector):

  • dom/Document.h:

(WebCore::Document::styleSelector):
(WebCore::Document::visuallyOrdered):

  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::determineParseMode):

  • loader/PlaceholderDocument.cpp:

(WebCore::PlaceholderDocument::attach):

9:03 AM Changeset in webkit [54004] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-01-28 Anton Muhin <​antonm@google.com>

Reviewed by Alexey Proskuryakov.

Add layout tests to verify assignment to items of NodeList
​https://bugs.webkit.org/show_bug.cgi?id=34213

  • fast/dom/NodeList/nodelist-item-assignment-expected.txt: Added.
  • fast/dom/NodeList/nodelist-item-assignment.html: Added.
8:47 AM Changeset in webkit [54003] by eric@webkit.org
  • 9 edits
    2 moves in trunk/WebCore

2010-01-28 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Rename ISODateTime.{cpp,h} to DateComponents.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=34245

No functional changes.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/DateComponents.cpp: Copied from WebCore/html/ISODateTime.cpp. (WebCore::DateComponents::maxWeekNumberInYear): (WebCore::DateComponents::parseYear): (WebCore::DateComponents::addDay): (WebCore::DateComponents::addMinute): (WebCore::DateComponents::parseTimeZone): (WebCore::DateComponents::parseMonth): (WebCore::DateComponents::parseDate): (WebCore::DateComponents::parseWeek): (WebCore::DateComponents::parseTime): (WebCore::DateComponents::parseDateTimeLocal): (WebCore::DateComponents::parseDateTime): (WebCore::DateComponents::setMillisecondsSinceMidnightInternal): (WebCore::DateComponents::setMillisecondsSinceEpochForDateInternal): (WebCore::DateComponents::setMillisecondsSinceEpochForDate): (WebCore::DateComponents::setMillisecondsSinceEpochForDateTime): (WebCore::DateComponents::setMillisecondsSinceEpochForDateTimeLocal): (WebCore::DateComponents::setMillisecondsSinceEpochForMonth): (WebCore::DateComponents::setMillisecondsSinceMidnight): (WebCore::DateComponents::setMillisecondsSinceEpochForWeek): (WebCore::DateComponents::millisecondsSinceEpochForTime): (WebCore::DateComponents::millisecondsSinceEpoch): (WebCore::DateComponents::toStringForTime): (WebCore::DateComponents::toString):
  • html/DateComponents.h: Copied from WebCore/html/ISODateTime.h. (WebCore::DateComponents::DateComponents):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseToDouble): (WebCore::HTMLInputElement::valueAsDate): (WebCore::HTMLInputElement::setValueAsDate): (WebCore::HTMLInputElement::setValueAsNumber): (WebCore::HTMLInputElement::formStringToDateComponents):
  • html/HTMLInputElement.h:
  • html/ISODateTime.cpp: Removed.
  • html/ISODateTime.h: Removed.
  • html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch):
8:44 AM Changeset in webkit [54002] by Csaba Osztrogonác
  • 5 edits in trunk/WebKitTools

[Qt] Unreviewed, roll out r54000.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::DumpRenderTree):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::reset):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController::display):

8:28 AM Changeset in webkit [54001] by eric@webkit.org
  • 9 edits in trunk/WebCore

2010-01-28 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Use platform-specific monospace fonts in the Web Inspector

Move the OS version detection code into the frontend,
add custom CSS monospace styles for known platforms.
​https://bugs.webkit.org/show_bug.cgi?id=34040

  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::platform):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
  • inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView):
  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.releaseWrapperObjectGroup): (.WebInspector.InspectorBackendStub.prototype.setInjectedScriptSource):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createConditionElement):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.URLRegExp.i.get platform): (WebInspector._detectPlatform):
6:41 AM Changeset in webkit [54000] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-01-28 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement the display() method of the layout test controller
​https://bugs.webkit.org/show_bug.cgi?id=34258

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::showPage): (WebCore::DumpRenderTree::hidePage):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::display):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
5:39 AM Changeset in webkit [53999] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

Do not set the combobox font on Maemo5 and S60; use the
default instead.

Reviewed by Simon Hausmann.

  • WebCoreSupport/QtFallbackWebPopup.cpp:

(WebCore::QtFallbackWebPopup::populate):

5:22 AM Changeset in webkit [53998] by Chris Jerdonek
  • 3 edits in trunk/WebKitTools

Eliminated the filename parameter from functions in
check-webkit-style's cpp.py where it is no longer used.

Reviewed by Shinichiro Hamaji.

​https://bugs.webkit.org/show_bug.cgi?id=34249

  • Scripts/webkitpy/style/processors/cpp.py:
    • Reduced number of occurrences of "filename" variable from approximately 200 to 120.
  • Scripts/webkitpy/style/processors/cpp_unittest.py:
    • Refactored unit tests as necessary to accommodate changes to cpp.py.
    • Fixed bug in CppStyleTestBase.perform_include_what_you_use() where the incorrect file extension was getting passed to cpp_style.check_language().
5:06 AM Changeset in webkit [53997] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Fix for endless print loop when printing web pages

Patch by Trond Kjernåsen <​trond@trolltech.com> on 2010-01-28
Reviewed by Simon Hausmann.

  • Api/qwebframe.cpp:

(QWebFrame::print):

4:34 AM Changeset in webkit [53996] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-01-28 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Simplify views logic in Profiler panel, and fix the problem described in the issue.
Remove image from Welcome view.
Preserve border on status bar-like buttons in Welcome view on window deactivation.

​https://bugs.webkit.org/show_bug.cgi?id=34201

  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.show): (WebInspector.ProfilesPanel.prototype.reset): (WebInspector.ProfilesPanel.prototype.addProfileHeader): (WebInspector.ProfilesPanel.prototype.showView): (WebInspector.ProfilesPanel.prototype._updateInterface):
  • inspector/front-end/WelcomeView.js: (WebInspector.WelcomeView):
  • inspector/front-end/inspector.css:
3:54 AM Changeset in webkit [53995] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Speed up KURL to QUrl conversion

​https://bugs.webkit.org/show_bug.cgi?id=33873

The WebCore::String::utf8 method will use the generic WebCore::TextCodec
and then call the encode method on it. In QtWebKit this class is implemented
around the QTextCodec class. Instead of going the generic codec way we treat
the WebCore::String as a QString (no copying) and then use the built-in
QString::toUtf8 to do the conversion.

3:00 AM Changeset in webkit [53994] by benm@google.com
  • 12 edits in trunk

[Android] [Qt] Touch event page co-ordinates are incorrect when touch is received in an iframe.
​https://bugs.webkit.org/show_bug.cgi?id=34162

Reviewed by Simon Hausmann.

WebCore:

The pageX/pageY co-ordinates of a touch event should be relative to the containing frame, not the main frame. This change implements that and also updates the existing touch-inside-iframe test to also examine the page co-ordinates.

  • dom/Touch.cpp:

(WebCore::Touch::Touch): Remove dead code.

  • dom/Touch.h: Remove dead code.
  • page/EventHandler.cpp:

(WebCore::EventHandler::handleTouchEvent): Rename framePoint to pagePoint, as it seems a clearer name. Also adjust the pagePoint to be relative to the touch target element's containing frame rather than the main frame.

  • platform/PlatformTouchEvent.h: Rename Android specific constructor parameter to better reflect it's contents.
  • platform/PlatformTouchPoint.h: Ditto.
  • platform/android/PlatformTouchEventAndroid.cpp: Ditto.
  • platform/android/PlatformTouchPointAndroid.cpp: Ditto.

LayoutTests:

Update the existing iframe touch event test to also examine the page co-ordinates of the touch that is received.

  • fast/events/touch/resources/touch-inside-iframe2.html:
  • fast/events/touch/touch-inside-iframe-expected.txt:
  • fast/events/touch/touch-inside-iframe.html:
2:46 AM Changeset in webkit [53993] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-28 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Simplify isActivation method.

​https://bugs.webkit.org/show_bug.cgi?id=34161

Test: WebCore/manual-tests/inspector/debugger-scopes-inspection.html

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::isActivation):
1:20 AM Changeset in webkit [53992] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-28 Xan Lopez <​xlopez@igalia.com>

[GTK] Can DnD files to our filechooser widget (<input type="file">)
​https://bugs.webkit.org/show_bug.cgi?id=34246

Skip failing test because of this missing feature.

  • platform/gtk/Skipped:
1:10 AM Changeset in webkit [53991] by tkent@chromium.org
  • 9 edits
    1 delete in trunk/LayoutTests

2010-01-28 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Fisher.

Remove tests for dates later than 275760-09-13T00:00Z.
​https://bugs.webkit.org/show_bug.cgi?id=34240

Date.UTC() of V8 doesn't support such dates though Date.UTC() of
JavaScriptCore does.

  • fast/forms/input-valueasnumber-date-expected.txt:
  • fast/forms/input-valueasnumber-datetime-expected.txt:
  • fast/forms/input-valueasnumber-datetimelocal-expected.txt:
  • fast/forms/input-valueasnumber-month-expected.txt:
  • fast/forms/script-tests/input-valueasnumber-date.js:
  • fast/forms/script-tests/input-valueasnumber-datetime.js:
  • fast/forms/script-tests/input-valueasnumber-datetimelocal.js:
  • fast/forms/script-tests/input-valueasnumber-month.js:
  • platform/win/fast/forms/input-valueasnumber-datetime-expected.txt: Removed.
12:45 AM Changeset in webkit [53990] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-01-28 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

In check-webkit-style, eliminated the dependency of
processors/cpp_unittest.py on checker.py.

​https://bugs.webkit.org/show_bug.cgi?id=34205

  • Scripts/webkitpy/style/checker.py:
    • Addressed FIXME by removing STYLE_CATEGORIES data.
    • Added style_categories().
  • Scripts/webkitpy/style/checker_unittest.py:
    • Minor changes.
  • Scripts/webkitpy/style/processors/cpp.py:
    • Added categories attribute to CppProcessor class (data was originally checker.STYLE_CATEGORIES).
  • Scripts/webkitpy/style/processors/cpp_unittest.py:
    • Addressed FIXME by eliminating "import" from checker.py.
12:29 AM Changeset in webkit [53989] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-28 Anton Muhin <​antonm@chromium.org>

Reviewed by Shinichiro Hamaji.

Improve treatment of conditions and rest of the line for if, else, switch and alikes
​https://bugs.webkit.org/show_bug.cgi?id=34173

  • Scripts/webkitpy/style/cpp_style.py:
  • Scripts/webkitpy/style/cpp_style_unittest.py:
12:14 AM Changeset in webkit [53988] by mrowe@apple.com
  • 10 edits
    2 adds in branches/safari-4-branch

Merge r53567.

12:14 AM Changeset in webkit [53987] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-4-branch

Merge r53368.

12:14 AM Changeset in webkit [53986] by mrowe@apple.com
  • 30 edits
    1 copy
    7 adds in branches/safari-4-branch

Merge r53512.

12:13 AM Changeset in webkit [53985] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r53369.

12:13 AM Changeset in webkit [53984] by mrowe@apple.com
  • 10 edits
    2 adds in branches/safari-4-branch

Merge r53220.

12:13 AM Changeset in webkit [53983] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r53163.

12:13 AM Changeset in webkit [53982] by mrowe@apple.com
  • 6 edits
    2 adds in branches/safari-4-branch

Merge r52351.

12:13 AM Changeset in webkit [53981] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r52781.

12:13 AM Changeset in webkit [53980] by mrowe@apple.com
  • 14 edits
    2 adds in branches/safari-4-branch

Merge r52773.

12:13 AM Changeset in webkit [53979] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r52352.

12:13 AM Changeset in webkit [53978] by mrowe@apple.com
  • 7 edits
    2 adds in branches/safari-4-branch

Merge r52233.

12:13 AM Changeset in webkit [53977] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-4-branch

Merge r50196.

12:12 AM Changeset in webkit [53976] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-28 Joe Mason <​jmason@rim.com>

Reviewed by Adam Barth.

Limit login retries to 5
​https://bugs.webkit.org/show_bug.cgi?id=34193

  • Scripts/webkitpy/bugzilla.py:
Note: See TracTimeline for information about the timeline view.