Timeline
Feb 9, 2010:
- 11:44 PM WebKit Team edited by
- (diff)
- 8:48 PM Changeset in webkit [54586] by
-
- 7 edits1 copy3 adds in trunk/WebKit/chromium
2010-02-09 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Refactor AutocompletePopupMenuClient into a base class,
SuggestionsPopupMenuClient, and two derived classes,
AutocompletePopupMenuClient and AutoFillPopupMenuClient. Currently
the behavior of suggestions popups has not changed.
- WebKit.gyp:
- public/WebView.h:
- src/AutoFillPopupMenuClient.cpp: Added.
- src/AutoFillPopupMenuClient.h: Added.
- src/AutocompletePopupMenuClient.cpp: (WebKit::AutocompletePopupMenuClient::getSuggestionsCount): (WebKit::AutocompletePopupMenuClient::getSuggestion): (WebKit::AutocompletePopupMenuClient::removeSuggestionAtIndex): (WebKit::AutocompletePopupMenuClient::initialize): (WebKit::AutocompletePopupMenuClient::setSuggestions):
- src/AutocompletePopupMenuClient.h:
- src/SuggestionsPopupMenuClient.cpp: Added.
- src/SuggestionsPopupMenuClient.h: Added.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::autocompleteHandleKeyEvent): (WebKit::WebViewImpl::applyAutofillSuggestions): (WebKit::WebViewImpl::applyAutoFillSuggestions): (WebKit::WebViewImpl::applyAutocompleteSuggestions):
- src/WebViewImpl.h:
- 8:23 PM Changeset in webkit [54585] by
-
- 2 edits in trunk/WebCore
2010-02-09 Ariya Hidayat <ariya.hidayat@gmail.com>
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] Remove old, outdated unused code block.
- platform/graphics/qt/GraphicsContextQt.cpp:
- 8:13 PM BuildingQtOnLinux edited by
- (diff)
- 8:01 PM Changeset in webkit [54584] by
-
- 7 edits in trunk
2010-02-09 Chris Guillory <ctguil@google.com>
Reviewed by Darin Fisher.
[Chromium] Notify ChromeClientChromium of state change notifications.
- accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::toChromeClientChromium): (WebCore::AXObjectCache::postPlatformNotification):
- page/chromium/ChromeClientChromium.h:
2010-02-09 Chris Guillory <ctguil@google.com>
Reviewed by Darin Fisher.
[Chromium] Add function for accessibility object state change notifications.
- gyp_webkit:
- public/WebViewClient.h: (WebKit::WebViewClient::didChangeAccessibilityObjectState):
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::didChangeAccessibilityObjectState):
- src/ChromeClientImpl.h:
- 7:45 PM Changeset in webkit [54583] by
-
- 2 edits1 add in trunk/WebCore
2010-02-09 Kwang Yul Seo <skyul@company100.net>
Reviewed by Adam Barth.
[BREWMP] Port PlatformMouseEvent
https://bugs.webkit.org/show_bug.cgi?id=34600
Retrieve the event type, position, key modifiers, time stamp
and click count from AEEEvent.
- platform/PlatformMouseEvent.h:
- platform/brew/PlatformMouseEventBrew.cpp: Added. (WebCore::PlatformMouseEvent::PlatformMouseEvent):
- 7:25 PM Changeset in webkit [54582] by
-
- 2 edits in trunk/WebCore
2010-02-09 Avi Drissman <avi@chromium.org>
Reviewed by Timothy Hatcher.
[Chromium] RenderTheme does not draw focus rings on SL for checkboxes, radio buttons
https://bugs.webkit.org/show_bug.cgi?id=34544
Covered by layout tests when run on SL.
- platform/chromium/ThemeChromiumMac.mm: (-[TCMVisibleView _focusRingVisibleRect]): (-[TCMVisibleView _focusRingClipAncestor]): (FocusIndicationFix::currentOSHasSetFocusRingStyleInBitmapBug): (FocusIndicationFix::swizzleFocusView): (FocusIndicationFix::ScopedFixer::ScopedFixer): (FocusIndicationFix::ScopedFixer::~ScopedFixer): (+[NSView TCMInterposing_focusView]): (WebCore::paintCheckbox): (WebCore::paintRadio): (WebCore::paintButton):
- 7:09 PM Changeset in webkit [54581] by
-
- 4 edits in trunk/WebCore
2010-02-09 Anton Muhin <antonm@chromium.org>
Reviewed by Nate Chapin.
[v8] Check if returned wrapper is empty before operating on it.
https://bugs.webkit.org/show_bug.cgi?id=34746
- bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::toV8):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::toV8):
- bindings/v8/custom/V8SVGDocumentCustom.cpp: (WebCore::toV8):
- 6:53 PM Changeset in webkit [54580] by
-
- 4 edits in trunk/JavaScriptCore
2010-02-09 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
New functions nullValue() and undefinedValue().
[Qt] QScriptEngine should contain nullValue and undefinedValue methods
https://bugs.webkit.org/show_bug.cgi?id=34749
- qt/api/qscriptengine.cpp: (QScriptEngine::nullValue): (QScriptEngine::undefinedValue):
- qt/api/qscriptengine.h:
- qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::nullValue): (tst_QScriptEngine::undefinedValue):
- 6:36 PM Changeset in webkit [54579] by
-
- 4 edits in trunk/JavaScriptCore
2010-02-09 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Fixes for QScriptValue::toNumber().
Fix ECMA compliance in QScriptValue for values unbound
to a QScriptEngine.
[Qt] QScriptValue::toNumber() is broken
https://bugs.webkit.org/show_bug.cgi?id=34592
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::toNumber):
- qt/tests/qscriptvalue/tst_qscriptvalue.h:
- qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: (tst_QScriptValue::toNumber_initData): (tst_QScriptValue::toNumber_makeData): (tst_QScriptValue::toNumber_test):
- 6:29 PM Changeset in webkit [54578] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Unit test for window.runModalDialog
https://bugs.webkit.org/show_bug.cgi?id=34755
Reviewed by Adam Barth.
- tests/qwebpage/tst_qwebpage.cpp:
- 6:19 PM Changeset in webkit [54577] by
-
- 4 edits in trunk/JavaScriptCore
2010-02-09 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Fix QScriptValue::isNumber().
The isNumber() should return 'true' if the value is in the CNumber
state.
[Qt] QScriptValue::isNumber() returns an incorrect value
https://bugs.webkit.org/show_bug.cgi?id=34575
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::isNumber):
- qt/tests/qscriptvalue/tst_qscriptvalue.h:
- qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: (tst_QScriptValue::isNumber_initData): (tst_QScriptValue::isNumber_makeData): (tst_QScriptValue::isNumber_test):
- 6:02 PM Changeset in webkit [54576] by
-
- 12 edits in trunk
2010-02-09 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Continuing debugger and profiler unforking: narrow scope of JSC-specific ifdefs.
Also, enable JAVASCRIPT_DEBUGGER explicitly in features, it appears to be required
for really enabling it in V8 bindings generation.
- inspector/InjectedScriptHost.idl:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::currentCallFrame): (WebCore::InspectorBackend::getProfile):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::addProfile): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::pausedScript): (WebCore::InspectorFrontend::resumedScript): (WebCore::InspectorFrontend::profilerWasEnabled): (WebCore::InspectorFrontend::profilerWasDisabled): (WebCore::InspectorFrontend::didGetProfile):
- inspector/InspectorFrontend.h:
- page/Console.idl:
2010-02-09 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Continuing debugger and profiler unforking: narrow scope of JSC-specific ifdefs.
Also, enable JAVASCRIPT_DEBUGGER explicitly in features, it appears to be required
for really enabling it in V8 bindings generation.
- features.gypi:
- 5:43 PM Changeset in webkit [54575] by
-
- 2 edits in trunk/WebKit/qt
2010-02-09 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Sync with API changes in Maemo 5 kinetic scrolling
This is a forward-port of http://qt.gitorious.org/+qt-developers/qt/x11-maemo/commit/08497561
- Api/qwebview.cpp: (qt_sendSpontaneousEvent): (QWebViewKineticScroller::QWebViewKineticScroller): (QWebViewKineticScroller::setWidget): (QWebViewKineticScroller::eventFilter): (QWebViewKineticScroller::cancelLeftMouseButtonPress): (QWebViewKineticScroller::currentFrame): (QWebViewKineticScroller::scrollingFrameAt): (QWebViewKineticScroller::maximumScrollPosition): (QWebViewKineticScroller::scrollPosition): (QWebViewKineticScroller::viewportSize): (QWebViewKineticScroller::setScrollPosition): (QWebViewKineticScroller::sendEvent): (QWebView::QWebView):
- 4:28 PM Changeset in webkit [54574] by
-
- 3 edits in trunk/JavaScriptCore
Small refactoring to the small strings cache to allow it to be cleared
dynamically.
Reviewed by Oliver Hunt.
- runtime/SmallStrings.cpp:
(JSC::SmallStrings::SmallStrings):
(JSC::SmallStrings::clear):
- runtime/SmallStrings.h: Moved initialization code into a shared function,
and changed the constructor to call it.
- 4:14 PM Changeset in webkit [54573] by
-
- 5 edits in trunk
[Qt] Unreviewed. Roll-out r54543, because layout tests crash in debug mode.
https://bugs.webkit.org/show_bug.cgi?id=34713
WebKitTools:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
- DumpRenderTree/qt/main.cpp:
(main):
LayoutTests:
- platform/qt/Skipped:
- 3:28 PM Changeset in webkit [54572] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed trivial fix.
platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt updated
by r54560. Qt platform specific expected file should be updated too.
- platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt: Updated.
- 3:26 PM Changeset in webkit [54571] by
-
- 12 edits in trunk
Rubber Stamped by Geoff Garen.
Rename StringBuilder::release && JSStringBuilder::releaseJSString
to 'build()'.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
- runtime/Executable.cpp:
(JSC::FunctionExecutable::paramString):
- runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::decode):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape):
- runtime/JSONObject.cpp:
(JSC::Stringifier::stringify):
- runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::build):
- runtime/LiteralParser.cpp:
(JSC::LiteralParser::Lexer::lexString):
- runtime/NumberPrototype.cpp:
(JSC::integerPartNoExp):
(JSC::numberProtoFuncToFixed):
- runtime/StringBuilder.h:
(JSC::StringBuilder::build):
WebCore:
- bindings/js/ScriptString.h:
(WebCore::ScriptString::operator+=):
- 3:01 PM Changeset in webkit [54570] by
-
- 5 edits in branches/safari-4-branch/WebKit/mac
Merge r54447.
- 2:58 PM Changeset in webkit [54569] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/events/multiline-link-arrow-navigation.html introduced in r54566, but our
LayoutTestController::overridePreference() does not support the 'WebKitEnableCaretBrowsing' preference now.
- platform/qt/Skipped: fast/events/multiline-link-arrow-navigation.html skipped.
- 2:48 PM Changeset in webkit [54568] by
-
- 3 edits5 copies in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] window.showModalDialog implemented by r54550. Some tests pass now, so expected files updated.
(We need some new platform specific expected file, because this feature works only on Qt port now.)
https://bugs.webkit.org/show_bug.cgi?id=25585
- platform/qt/fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Copied from LayoutTests/fast/dom/Window/window-function-frame-getter-precedence-expected.txt.
- platform/qt/fast/dom/Window/window-function-name-getter-precedence-expected.txt: Copied from LayoutTests/fast/dom/Window/window-function-name-getter-precedence-expected.txt.
- platform/qt/fast/dom/Window/window-lookup-precedence-expected.txt: Copied from LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt.
- platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
- platform/qt/fast/dom/prototype-inheritance-expected.txt: Updated.
- platform/qt/http/tests/security/cross-frame-access-call-expected.txt: Copied from LayoutTests/http/tests/security/cross-frame-access-call-expected.txt.
- cross-frame-access-call-expected.txt might be a false expected file, it needs more investigation.
- platform/qt/http/tests/security/cross-frame-access-get-expected.txt: Copied from LayoutTests/http/tests/security/cross-frame-access-get-expected.txt.
- 2:23 PM Changeset in webkit [54567] by
-
- 4 edits4 adds in trunk
<rdar://problem/7400160> Netscape plug-ins are not instantiated on property access if there are pending stylesheets
https://bugs.webkit.org/show_bug.cgi?id=34776
Reviewed by Anders Carlsson.
WebCore:
Tests: plugins/instance-available-before-stylesheets-loaded-object.html
plugins/instance-available-before-stylesheets-loaded.html
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::renderWidgetForJSBindings): Call
updateLayoutIgnorePendingStylesheets() before checking for a renderer.
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::renderWidgetForJSBindings): Ditto.
LayoutTests:
- plugins/instance-available-before-stylesheets-loaded-expected.txt: Added.
- plugins/instance-available-before-stylesheets-loaded-object-expected.txt: Added.
- plugins/instance-available-before-stylesheets-loaded-object.html: Added.
- plugins/instance-available-before-stylesheets-loaded.html: Added.
- 12:51 PM Changeset in webkit [54566] by
-
- 3 edits2 adds in trunk
Problems navigating by caret in links whose text wraps onto
subsequent lines.
https://bugs.webkit.org/show_bug.cgi?id=25676
Reviewed by Darin Adler.
WebCore:
We should not search ahead if we are not in the last element.
- dom/Position.cpp:
LayoutTests:
Added tests showing the problem.
- fast/events/multiline-link-arrow-navigation.html
- fast/events/multiline-link-arrow-navigation-expected.txt
- 12:50 PM Changeset in webkit [54565] by
-
- 4 edits1 add in trunk/WebKit/chromium
[chromium] Add the chromium interface to support Blob.slice.
https://bugs.webkit.org/show_bug.cgi?id=34652
Reviewed by Darin Fisher.
- WebKit.gyp:
- public/WebFileInfo.h: Added.
- public/WebHTTPBody.h:
- src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendFile):
- 12:46 PM Changeset in webkit [54564] by
-
- 8 edits in trunk/WebCore
2010-02-09 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
More optimization for AffineTransform with SVG
https://bugs.webkit.org/show_bug.cgi?id=34774
Some optimizations to safe unnecessary summations and multiplications.
Optimize AffineTransform to handle an identity or translation matrix
more efficient.
Added translationRight to avoid multiplications of matrices as much as
possible.
No tests added, no change of functionality.
- platform/graphics/transforms/AffineTransform.cpp: (WebCore::AffineTransform::inverse): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::translateRight):
- platform/graphics/transforms/AffineTransform.h:
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::translationForAttributes): (WebCore::RenderForeignObject::localToParentTransform):
- rendering/RenderForeignObject.h:
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::localToBorderBoxTransform): (WebCore::RenderSVGRoot::localToRepaintContainerTransform): (WebCore::RenderSVGRoot::localToParentTransform):
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::localToParentTransform):
- rendering/SVGRootInlineBox.cpp: (WebCore::applyTextLengthCorrectionToTextChunk):
- 12:06 PM Changeset in webkit [54563] by
-
- 2 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=34772
Overzealous new assertion in URStringImpl::adopt()
Reviewed by Adam Barth.
- runtime/UStringImpl.h:
(JSC::UStringImpl::adopt):
Only assert that vector.data() is non-zero if vector.size() is non-zero.
- 12:05 PM Changeset in webkit [54562] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=34771
A stray mouse moved event is sent to plug-ins after mouse exit
- WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): A mouseout DOM event is dispatched while handling NSMouseMoved - but we shouldn't be sending a mouse moved event to plug-ins at this point.
- 10:48 AM Changeset in webkit [54561] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Set GtkAdjustments on our FrameView when loading a page in the PageCache
https://bugs.webkit.org/show_bug.cgi?id=34754
Test that lower, and upper bounds are kept when goibg back with
page cache enabled, and disabled. Page cache behaviour is still a
bit broken (see FIXME).
- tests/testwebview.c: (server_callback): (map_event_cb): (do_test_webkit_web_view_adjustments): (test_webkit_web_view_adjustments): (main):
- 10:33 AM Changeset in webkit [54560] by
-
- 23 edits12 adds in trunk
2010-02-09 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG patterns with some scale patternTransform are not displayed correctly for small elements
https://bugs.webkit.org/show_bug.cgi?id=25484
SVG Pattern size was clipped to the size of the target, if the pattern is bigger than the target. This
causes problems, if the patternTransform scales the pattern. This patch deletes the clipping.
Tests: svg/custom/pattern-excessive-malloc.svg
svg/custom/pattern-size-bigger-than-target-size.svg
svg/custom/pattern-skew-transformed.svg
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern):
2010-02-09 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG patterns with some scale patternTransform are not displayed correctly for small elements
https://bugs.webkit.org/show_bug.cgi?id=25484
The old DRT results gave back a pattern size of 1x1. That was not very useful.
The new reuslts are much more useful.
- platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
- platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
- platform/mac/svg/batik/paints/patternRegions-expected.txt:
- platform/mac/svg/custom/deep-dynamic-updates-expected.txt:
- platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.txt:
- platform/mac/svg/custom/js-late-pattern-creation-expected.txt:
- platform/mac/svg/custom/js-update-pattern-child-expected.txt:
- platform/mac/svg/custom/js-update-pattern-expected.txt:
- platform/mac/svg/custom/pattern-cycle-detection-expected.txt:
- platform/mac/svg/custom/pattern-deep-referencing-expected.txt:
- platform/mac/svg/custom/pattern-excessive-malloc-expected.checksum: Added.
- platform/mac/svg/custom/pattern-excessive-malloc-expected.png: Added.
- platform/mac/svg/custom/pattern-excessive-malloc-expected.txt: Added.
- platform/mac/svg/custom/pattern-in-defs-expected.txt:
- platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.checksum: Added.
- platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.png: Added.
- platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Added.
- platform/mac/svg/custom/pattern-skew-transformed-expected.checksum: Added.
- platform/mac/svg/custom/pattern-skew-transformed-expected.png: Added.
- platform/mac/svg/custom/pattern-skew-transformed-expected.txt: Added.
- platform/mac/svg/custom/pattern-with-transformation-expected.txt:
- platform/mac/svg/custom/pattern-y-offset-expected.txt:
- platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/mac/svg/custom/stroked-pattern-expected.txt:
- platform/mac/svg/custom/transformedMaskFails-expected.png:
- platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- svg/custom/pattern-excessive-malloc.svg: Added.
- svg/custom/pattern-size-bigger-than-target-size.svg: Added.
- svg/custom/pattern-skew-transformed.svg: Added.
- 10:22 AM Changeset in webkit [54559] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-09 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Set GtkAdjustments on our FrameView when loading a page in the PageCache
https://bugs.webkit.org/show_bug.cgi?id=34754
Set the Gtk Adjustments of the FrameViews when they are restored
from the PageCache too. Right we only do it for the newly created
FrameViews in transitionToCommittedForNewPage, but we it also
needs to be done in the equilavent transition method for cached
pages.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup): (WebKit::FrameLoaderClient::transitionToCommittedFromCachedFrame): (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
- 10:22 AM Changeset in webkit [54558] by
-
- 2 edits in trunk/LayoutTests
2010-02-09 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Update Qt specific DRT result after AffineTransform patch.
- platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- 10:21 AM Changeset in webkit [54557] by
-
- 2 edits in trunk/WebCore
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleDidChange): Fixed typo in comment.
- 8:53 AM Changeset in webkit [54556] by
-
- 21 edits4 adds in trunk
2010-02-09 MORITA Hajime <morrita@gmail.com>
Reviewed by Nikolas Zimmermann.
SVG selection text foreground colour does not respect user settings
https://bugs.webkit.org/show_bug.cgi?id=15997
Add two subphases SVGTextPaintSubphaseGlyphFillSelection and
SVGTextPaintSubphaseGlyphStrokeSelection for painting selected
text on SVG. Selected texts are painted with style from
getCachedPseudoStyle() instead of style().
Tests: svg/text/selection-styles.xhtml
- rendering/SVGCharacterLayoutInfo.h: (WebCore::SVGTextChunkWalker::SVGTextChunkWalker): (WebCore::SVGTextChunkWalker::setupFillSelection): (WebCore::SVGTextChunkWalker::setupStrokeSelection):
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::mayHaveSelection): (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupFillSelectionCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupStrokeSelectionCallback): (WebCore::SVGRootInlineBoxPaintWalker::activePaintServer): (WebCore::SVGRootInlineBox::paint): (WebCore::SVGRootInlineBox::walkTextChunks):
- rendering/SVGInlineTextBox.h: (WebCore::): Add callback hooks and its implementation for handle new subphases.
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::chunkSelectionStartEnd): (WebCore::SVGInlineTextBox::paintCharacters): Split box text into selected part and non-selected part, and use separate subphases to paint them.
- svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk): Relax ASSERT() condition to accept a part of text.
- svg/graphics/SVGPaintServer.cpp: (WebCore::applyStrokeStyleToContext): (WebCore::SVGPaintServer::setup):
- svg/graphics/SVGPaintServer.h:
- svg/graphics/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::setup):
- svg/graphics/SVGPaintServerGradient.h:
- svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setup):
- svg/graphics/SVGPaintServerPattern.h:
- svg/graphics/SVGPaintServerSolid.cpp: (WebCore::SVGPaintServerSolid::setup):
- svg/graphics/SVGPaintServerSolid.h: Change setup() signature to accept RenderStyle instead of always using RenderObject::style().
2010-02-09 MORITA Hajime <morrita@gmail.com>
Reviewed by Nikolas Zimmermann.
SVG selection text foreground colour does not respect user settings
https://bugs.webkit.org/show_bug.cgi?id=15997
Add two subphases SVGTextPaintSubphaseGlyphFillSelection and
SVGTextPaintSubphaseGlyphStrokeSelection for painting SVG text
selection. texts are painted with style from getCachedPseudoStyle() instead of style().
- platform/mac/svg/text/selection-styles-expected.checksum: Added.
- platform/mac/svg/text/selection-styles-expected.png: Added.
- platform/mac/svg/text/selection-styles-expected.txt: Added.
- platform/mac/svg/text/text-deco-01-b-expected.checksum: Updated pixel tests to account for marginal painting differences.
- platform/mac/svg/text/text-deco-01-b-expected.png: Ditto.
- platform/mac/svg/text/text-path-01-b-expected.checksum: Dito.
- platform/mac/svg/text/text-path-01-b-expected.png: Ditto.
- platform/mac/svg/text/text-text-03-b-expected.checksum: Ditto.
- platform/mac/svg/text/text-text-03-b-expected.png: Ditto.
- svg/text/selection-styles.xhtml: Added.
- 8:36 AM Changeset in webkit [54555] by
-
- 1 edit1 add in trunk/WebKit/chromium
2010-02-09 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Follow-up fix.
Add missing devTools.css file.
- src/js/devTools.css: Added.
- 8:34 AM Changeset in webkit [54554] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Try to fix build problem on SnowLeopard slaves to bring them back.
- API/JSClassRef.cpp: (tryCreateStringFromUTF8): Mark method as 'static inline' to suppress "warning: no previous prototype for ..."
- 8:27 AM Changeset in webkit [54553] by
-
- 2 edits in trunk/WebKitTools
Unreviewed; added myself to committers
- Scripts/webkitpy/committers.py:
- 8:27 AM Changeset in webkit [54552] by
-
- 2 edits11 adds in trunk/WebKit/chromium
2010-02-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Upstream DevTools Images and .css files.
- WebKit.gypi:
- src/js/DevTools.css: Added.
- src/js/Images/segmentChromium.png: Added.
- src/js/Images/segmentHoverChromium.png: Added.
- src/js/Images/segmentHoverEndChromium.png: Added.
- src/js/Images/segmentSelectedChromium.png: Added.
- src/js/Images/segmentSelectedEndChromium.png: Added.
- src/js/Images/statusbarBackgroundChromium.png: Added.
- src/js/Images/statusbarBottomBackgroundChromium.png: Added.
- src/js/Images/statusbarButtonsChromium.png: Added.
- src/js/Images/statusbarMenuButtonChromium.png: Added.
- src/js/Images/statusbarMenuButtonSelectedChromium.png: Added.
- 8:08 AM Changeset in webkit [54551] by
-
- 18 edits46 adds in trunk
2010-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
No scroll bars are displayed for standalone SVG image
https://bugs.webkit.org/show_bug.cgi?id=11225
Height and width defined for svg element are not honored
https://bugs.webkit.org/show_bug.cgi?id=24033
SVG file does not pan and has no scroll bars
https://bugs.webkit.org/show_bug.cgi?id=24448
Adapt to SVG 1.1 errata to change the overflow handling:
Replace "svg { overflow: hidden }" by "svg:not(:root) { overflow: hidden }" to allow standalone SVG documents to contain scrolllbars.
Agreed by SVG WG to make this the default behaviour, already implemented by Opera & FireFox (partial support).
Add new tests in svg/overflow covering all special SVG css overflow handling rules on inner/outer svg elements.
Tests: svg/overflow/overflow-on-inner-svg-element-defaults.svg
svg/overflow/overflow-on-inner-svg-element.svg
svg/overflow/overflow-on-outermost-svg-element-defaults.svg
svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1.svg
svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2.svg
svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3.svg
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible.xhtml
- css/svg.css: Change default <svg> overflow rule to only apply to inner <svg> elements.
- page/FrameView.cpp: (WebCore::FrameView::layout): Only apply overflow rules for non-standalone SVG documents.
- rendering/RenderSVGRoot.cpp: Remove all calls to isOverflowHidden - it's always the case for the outermost SVG element, see spec + errata. (WebCore::RenderSVGRoot::paint): Always clip to initial viewport size. (WebCore::RenderSVGRoot::computeRectForRepaint): Ditto. (WebCore::RenderSVGRoot::nodeAtPoint): Simplify.
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::applyViewportClip): Use isOverflowHidden() instead of a manual oveflow query and clip in float precision.
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::isOverflowHidden): Simplify implementation, assure the function is not called anymore for RenderSVGRoot objects.
- 7:55 AM Changeset in webkit [54550] by
-
- 6 edits in trunk
[Qt] Webkit in Qt does not have window.showModalDialog
https://bugs.webkit.org/show_bug.cgi?id=25585
Reviewed by Kenneth Rohde Christiansen.
WebKit/qt:
Create a new eventloop when runModal() is called.
Added comemnt in QWebPage::createWindow that the application is responsible
for setting the modality of the appropriate window.
- Api/qwebpage.cpp:
- WebCoreSupport/ChromeClientQt.cpp:
- WebCoreSupport/ChromeClientQt.h:
WebKitTools:
Set the modality flag when createWindow is called with window type WebWindowDialog.
- QtLauncher/main.cpp:
- 7:30 AM Changeset in webkit [54549] by
-
- 2 edits in trunk/WebKitTools
Unreviewed trivial warning fix.
- Scripts/build-webkit:
- 7:22 AM Changeset in webkit [54548] by
-
- 2 edits in trunk/WebKitTools
Add possibility of passing parameters to build-webkit by environment variable,
because the buildbot slaves can't control the arguments.
Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-02-09
Reviewed by Tor Arne Vestbø.
- Scripts/build-webkit:
- 7:15 AM Changeset in webkit [54547] by
-
- 1 edit11 adds in trunk/WebKit/chromium
2010-02-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Upstream JavaScript part of DevTools WebKit API implementation(now
with the added files).
- 7:13 AM QtWebKitBackportingFixes edited by
- (diff)
- 7:03 AM Changeset in webkit [54546] by
-
- 1 edit in trunk/WebKit/chromium/ChangeLog
2010-02-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Upstream JavaScript part of DevTools WebKit API implementation
- WebKit.gypi: Added.
- src/js/DebuggerAgent.js: Added. (devtools.DebuggerAgent): (devtools.DebuggerAgent.prototype.reset): (devtools.DebuggerAgent.prototype.initUI): (devtools.DebuggerAgent.prototype.resolveScriptSource.this.requestSeqToCallback_.cmd.getSequenceNumber): (devtools.DebuggerAgent.prototype.resolveScriptSource): (devtools.DebuggerAgent.prototype.pauseExecution): (devtools.DebuggerAgent.prototype.addBreakpoint): (devtools.DebuggerAgent.prototype.removeBreakpoint): (devtools.DebuggerAgent.prototype.updateBreakpoint): (devtools.DebuggerAgent.prototype.stepIntoStatement): (devtools.DebuggerAgent.prototype.stepOutOfFunction): (devtools.DebuggerAgent.prototype.stepOverStatement): (devtools.DebuggerAgent.prototype.resumeExecution): (devtools.DebuggerAgent.prototype.createExceptionMessage_): (devtools.DebuggerAgent.prototype.showPendingExceptionMessage_): (devtools.DebuggerAgent.prototype.clearExceptionMessage_): (devtools.DebuggerAgent.prototype.pauseOnExceptions): (devtools.DebuggerAgent.prototype.setPauseOnExceptions): (devtools.DebuggerAgent.prototype.requestEvaluate): (devtools.DebuggerAgent.prototype.resolveChildren): (devtools.DebuggerAgent.prototype.resolveScope.this.requestSeqToCallback_.cmd.getSequenceNumber): (devtools.DebuggerAgent.prototype.resolveScope): (devtools.DebuggerAgent.prototype.resolveFrameVariables_.scopeResponseHandler): (devtools.DebuggerAgent.prototype.resolveFrameVariables_): (devtools.DebuggerAgent.prototype.resolveCompletionsOnFrame): (devtools.DebuggerAgent.prototype.getScriptContextType): (devtools.DebuggerAgent.prototype.requestClearBreakpoint_): (devtools.DebuggerAgent.prototype.requestChangeBreakpoint_): (devtools.DebuggerAgent.prototype.requestBacktrace_): (devtools.DebuggerAgent.sendCommand_): (devtools.DebuggerAgent.prototype.stepCommand_): (devtools.DebuggerAgent.prototype.requestLookup_): (devtools.DebuggerAgent.prototype.setContextId_.this.requestSeqToCallback_.cmd.getSequenceNumber): (devtools.DebuggerAgent.prototype.setContextId_): (devtools.DebuggerAgent.prototype.handleDebuggerOutput_): (devtools.DebuggerAgent.prototype.handleBreakEvent_): (devtools.DebuggerAgent.prototype.handleExceptionEvent_): (devtools.DebuggerAgent.prototype.handleScriptsResponse_): (devtools.DebuggerAgent.prototype.isScriptFromInspectedContext_): (devtools.DebuggerAgent.prototype.handleSetBreakpointResponse_): (devtools.DebuggerAgent.prototype.handleAfterCompileEvent_): (devtools.DebuggerAgent.prototype.addScriptInfo_): (devtools.DebuggerAgent.prototype.handleClearBreakpointResponse_): (devtools.DebuggerAgent.prototype.handleBacktraceResponse_): (devtools.DebuggerAgent.prototype.doHandleBacktraceResponse_): (devtools.DebuggerAgent.prototype.evaluateInCallFrame): (devtools.DebuggerAgent.prototype.invokeCallbackForResponse_): (devtools.DebuggerAgent.prototype.formatCallFrame_): (devtools.DebuggerAgent.formatObjectProperties_): (devtools.DebuggerAgent.propertiesToProxies_): (devtools.DebuggerAgent.formatObjectProxy_): (devtools.DebuggerAgent.webkitToV8LineNumber_): (devtools.DebuggerAgent.v8ToWwebkitLineNumber_): (devtools.ScriptInfo): (devtools.ScriptInfo.prototype.getLineOffset): (devtools.ScriptInfo.prototype.getContextType): (devtools.ScriptInfo.prototype.getUrl): (devtools.ScriptInfo.prototype.isUnresolved): (devtools.ScriptInfo.prototype.getBreakpointInfo): (devtools.ScriptInfo.prototype.addBreakpointInfo): (devtools.ScriptInfo.prototype.removeBreakpointInfo): (devtools.BreakpointInfo): (devtools.BreakpointInfo.prototype.getLine): (devtools.BreakpointInfo.prototype.getV8Id): (devtools.BreakpointInfo.prototype.setV8Id): (devtools.BreakpointInfo.prototype.markAsRemoved): (devtools.BreakpointInfo.prototype.isRemoved): (devtools.CallFrame): (devtools.CallFrame.prototype.evaluate_): (devtools.DebugCommand): (devtools.DebugCommand.prototype.getSequenceNumber): (devtools.DebugCommand.prototype.toJSONProtocol): (devtools.DebuggerMessage): (devtools.DebuggerMessage.prototype.getType): (devtools.DebuggerMessage.prototype.getEvent): (devtools.DebuggerMessage.prototype.getCommand): (devtools.DebuggerMessage.prototype.getRequestSeq): (devtools.DebuggerMessage.prototype.isRunning): (devtools.DebuggerMessage.prototype.isSuccess): (devtools.DebuggerMessage.prototype.getMessage): (devtools.DebuggerMessage.prototype.getBody): (devtools.DebuggerMessage.prototype.lookup):
- src/js/DevTools.js: Added. (devtools.dispatch): (devtools.ToolsAgent): (devtools.ToolsAgent.prototype.reset): (devtools.ToolsAgent.prototype.evaluateJavaScript): (devtools.ToolsAgent.prototype.getDebuggerAgent): (devtools.ToolsAgent.prototype.getProfilerAgent): (devtools.ToolsAgent.prototype.frameNavigate_): (devtools.ToolsAgent.prototype.dispatchOnClient_): (devtools.ToolsAgent.prototype.evaluate): (WebInspector.setResourcesPanelEnabled): (debugPrint): (devtools): (WebInspector.loaded): (): (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded): (WebInspector.ScriptView.prototype.didResolveScriptSource_): (WebInspector.UnresolvedPropertyValue): (WebInspector.UIString): (WebInspector.resourceTrackingWasEnabled): (WebInspector.resourceTrackingWasDisabled): (WebInspector.TestController.prototype.runAfterPendingDispatches): (WebInspector.queuesAreEmpty): (WebInspector.pausedScript):
- src/js/DevToolsHostStub.js: Added. (.RemoteDebuggerAgentStub): (.RemoteDebuggerAgentStub.prototype.getContextId): (.RemoteProfilerAgentStub): (.RemoteProfilerAgentStub.prototype.getActiveProfilerModules): (.RemoteProfilerAgentStub.prototype.getLogLines): (.RemoteToolsAgentStub): (.RemoteToolsAgentStub.prototype.dispatchOnInjectedScript): (.RemoteToolsAgentStub.prototype.dispatchOnInspectorController): (.RemoteToolsAgentStub.prototype.executeVoidJavaScript): (.ProfilerStubHelper): (.ProfilerStubHelper.GetInstance): (.ProfilerStubHelper.prototype.StopProfiling): (.ProfilerStubHelper.prototype.StartProfiling): (.ProfilerStubHelper.prototype.getActiveProfilerModules): (.ProfilerStubHelper.prototype.getLogLines): (.RemoteDebuggerCommandExecutorStub): (.RemoteDebuggerCommandExecutorStub.prototype.DebuggerCommand): (.RemoteDebuggerCommandExecutorStub.prototype.DebuggerPauseScript): (.RemoteDebuggerCommandExecutorStub.prototype.sendResponse_): (.DevToolsHostStub): (.DevToolsHostStub.prototype.reset): (.DevToolsHostStub.prototype.setting): (.DevToolsHostStub.prototype.setSetting):
- src/js/HeapProfilerPanel.js: Added. (WebInspector.ProfilesPanel.prototype.addSnapshot): (WebInspector.HeapSnapshotView): (WebInspector.HeapSnapshotView.prototype.get statusBarItems): (WebInspector.HeapSnapshotView.prototype.get profile): (WebInspector.HeapSnapshotView.prototype.set profile): (WebInspector.HeapSnapshotView.prototype.show): (WebInspector.HeapSnapshotView.prototype.hide): (WebInspector.HeapSnapshotView.prototype.resize): (WebInspector.HeapSnapshotView.prototype.refresh): (WebInspector.HeapSnapshotView.prototype.refreshShowAsPercents): (WebInspector.HeapSnapshotView.prototype._deleteSearchMatchedFlags): (WebInspector.HeapSnapshotView.prototype.searchCanceled): (WebInspector.HeapSnapshotView.prototype.performSearch): (WebInspector.HeapSnapshotView.prototype.jumpToFirstSearchResult.WebInspector.CPUProfileView.prototype.jumpToFirstSearchResult.jumpToLastSearchResult.WebInspector.CPUProfileView.prototype.jumpToLastSearchResult.jumpToNextSearchResult.WebInspector.CPUProfileView.prototype.jumpToNextSearchResult.jumpToPreviousSearchResult.WebInspector.CPUProfileView.prototype.jumpToPreviousSearchResult.showingFirstSearchResult.WebInspector.CPUProfileView.prototype.showingFirstSearchResult.showingLastSearchResult.WebInspector.CPUProfileView.prototype.showingLastSearchResult._jumpToSearchResult.WebInspector.CPUProfileView.prototype._jumpToSearchResult.refreshVisibleData): (WebInspector.HeapSnapshotView.prototype._changeBase): (WebInspector.HeapSnapshotView.prototype._createSnapshotDataGridList): (WebInspector.HeapSnapshotView.prototype._mouseDownInDataGrid): (WebInspector.HeapSnapshotView.prototype.get _isShowingAsPercent): (WebInspector.HeapSnapshotView.prototype._percentClicked): (WebInspector.HeapSnapshotView.prototype._resetDataGridList): (WebInspector.HeapSnapshotView.prototype._sortData): (WebInspector.HeapSnapshotView.prototype._updateBaseOptions): (WebInspector.HeapSnapshotView.prototype._updatePercentButton): (WebInspector.HeapSnapshotView.prototype._updateSummaryGraph): (WebInspector.HeapSnapshotView.SearchHelper.operations.LESS): (WebInspector.HeapSnapshotView.SearchHelper.operations.LESS_OR_EQUAL): (WebInspector.HeapSnapshotView.SearchHelper.operations.EQUAL): (WebInspector.HeapSnapshotView.SearchHelper.operations.GREATER_OR_EQUAL): (WebInspector.HeapSnapshotView.SearchHelper.operations.GREATER): (WebInspector.HeapSnapshotView.SearchHelper.parseOperationAndNumber): (WebInspector.HeapSummaryCalculator): (WebInspector.HeapSummaryCalculator.prototype.computeSummaryValues): (WebInspector.HeapSummaryCalculator.prototype.formatValue): (WebInspector.HeapSummaryCalculator.prototype.get showAsPercent): (WebInspector.HeapSummaryCalculator.prototype.set showAsPercent): (WebInspector.HeapSummaryCountCalculator): (WebInspector.HeapSummaryCountCalculator.prototype._highFromLow): (WebInspector.HeapSummaryCountCalculator.prototype._valueToString): (WebInspector.HeapSummarySizeCalculator): (WebInspector.HeapSummarySizeCalculator.prototype._highFromLow): (WebInspector.HeapSnapshotSidebarTreeElement): (WebInspector.HeapSnapshotSidebarTreeElement.prototype.get mainTitle): (WebInspector.HeapSnapshotSidebarTreeElement.prototype.set mainTitle): (WebInspector.HeapSnapshotDataGridNodeWithRetainers): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get _hasRetainers): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get _parent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype._populate.if): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype._populate): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.produceDiff): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.sort): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.signForDelta): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.showDeltaAsPercent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.getTotalCount): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.getTotalSize): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get countPercent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get sizePercent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get countDeltaPercent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get sizeDeltaPercent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get data): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.createCell): (WebInspector.HeapSnapshotDataGridNode): (WebInspector.HeapSnapshotDataGridList): (WebInspector.HeapSnapshotDataGridList.prototype.appendChild): (WebInspector.HeapSnapshotDataGridList.prototype.insertChild): (WebInspector.HeapSnapshotDataGridList.prototype.removeChildren): (WebInspector.HeapSnapshotDataGridList.prototype.populateChildren): (WebInspector.HeapSnapshotDataGridList.propertyComparator.comparator): (WebInspector.HeapSnapshotDataGridList.propertyComparator): (WebInspector.HeapSnapshotDataGridRetainerNode): (WebInspector.HeapSnapshotDataGridRetainerNode.prototype.get sizePercent): (WebInspector.HeapSnapshotDataGridRetainerNode.prototype.get sizeDeltaPercent): (WebInspector.HeapSnapshotDataGridRetainerNode.prototype._calculateRetainers): (WebInspector.HeapSnapshotProfileType): (WebInspector.HeapSnapshotProfileType.prototype.get buttonTooltip): (WebInspector.HeapSnapshotProfileType.prototype.get buttonStyle): (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked): (WebInspector.HeapSnapshotProfileType.prototype.get welcomeMessage): (WebInspector.HeapSnapshotProfileType.prototype.createSidebarTreeElementForProfile): (WebInspector.HeapSnapshotProfileType.prototype.createView): ():
- src/js/InjectDispatch.js: Added. (InspectorControllerDispatcher.dispatch): (ApuAgentDispatcher.dispatchToApu): (dispatch): (devtools):
- src/js/InspectorControllerImpl.js: Added. (devtools.InspectorBackendImpl): (devtools.InspectorBackendImpl.prototype.toggleNodeSearch): (devtools.InspectorBackendImpl.prototype.debuggerEnabled): (devtools.InspectorBackendImpl.prototype.profilerEnabled): (devtools.InspectorBackendImpl.prototype.addBreakpoint): (devtools.InspectorBackendImpl.prototype.removeBreakpoint): (devtools.InspectorBackendImpl.prototype.updateBreakpoint): (devtools.InspectorBackendImpl.prototype.pauseInDebugger): (devtools.InspectorBackendImpl.prototype.resumeDebugger): (devtools.InspectorBackendImpl.prototype.stepIntoStatementInDebugger): (devtools.InspectorBackendImpl.prototype.stepOutOfFunctionInDebugger): (devtools.InspectorBackendImpl.prototype.stepOverStatementInDebugger): (devtools.InspectorBackendImpl.prototype.setPauseOnExceptionsState): (devtools.InspectorBackendImpl.prototype.pauseOnExceptionsState): (devtools.InspectorBackendImpl.prototype.pauseOnExceptions): (devtools.InspectorBackendImpl.prototype.setPauseOnExceptions): (devtools.InspectorBackendImpl.prototype.startProfiling): (devtools.InspectorBackendImpl.prototype.stopProfiling): (devtools.InspectorBackendImpl.prototype.getProfileHeaders): (devtools.InspectorBackendImpl.prototype.addFullProfile): (devtools.InspectorBackendImpl.prototype.getProfile): (devtools.InspectorBackendImpl.prototype.takeHeapSnapshot): (devtools.InspectorBackendImpl.prototype.dispatchOnInjectedScript): (devtools.InspectorBackendImpl.prototype.installInspectorControllerDelegate_): (devtools.InspectorBackendImpl.prototype.callInspectorController_):
- src/js/ProfilerAgent.js: Added. (devtools.ProfilerAgent): (devtools.ProfilerAgent.prototype.setupProfilerProcessorCallbacks): (devtools.ProfilerAgent.prototype.initializeProfiling): (devtools.ProfilerAgent.prototype.startProfiling): (devtools.ProfilerAgent.prototype.stopProfiling): (devtools.ProfilerAgent.prototype.didGetActiveProfilerModules_): (devtools.ProfilerAgent.prototype.didGetLogLines_):
- src/js/ProfilerProcessor.js: Added. (devtools.profiler.WebKitViewBuilder): (devtools.profiler.WebKitViewBuilder.prototype.createViewNode): (devtools.profiler.WebKitViewNode): (set get devtools.profiler.WebKitViewNode.prototype.initFuncInfo_): (devtools.profiler.JsProfile): (devtools.profiler.JsProfile.prototype.skipThisFunction): (devtools.profiler.Processor): (devtools.profiler.Processor.prototype.printError): (devtools.profiler.Processor.prototype.skipDispatch): (devtools.profiler.Processor.prototype.setCallbacks): (devtools.profiler.Processor.prototype.setNewProfileCallback): (devtools.profiler.Processor.prototype.processProfiler_.switch.break): (devtools.profiler.Processor.prototype.processProfiler_): (devtools.profiler.Processor.prototype.processCodeCreation_): (devtools.profiler.Processor.prototype.processCodeMove_): (devtools.profiler.Processor.prototype.processCodeDelete_): (devtools.profiler.Processor.prototype.processFunctionCreation_): (devtools.profiler.Processor.prototype.processFunctionMove_): (devtools.profiler.Processor.prototype.processFunctionDelete_): (devtools.profiler.Processor.prototype.processTick_): (devtools.profiler.Processor.prototype.processTickV2_): (devtools.profiler.Processor.prototype.processHeapSampleBegin_): (devtools.profiler.Processor.prototype.processHeapSampleStats_): (devtools.profiler.Processor.prototype.processHeapSampleItem_): (devtools.profiler.Processor.prototype.processHeapJsConsItem_): (devtools.profiler.Processor.prototype.processHeapJsRetItem_.mergeRetainers): (devtools.profiler.Processor.prototype.processHeapJsRetItem_): (devtools.profiler.Processor.prototype.processHeapSampleEnd_): (devtools.profiler.Processor.prototype.createProfileForView):
- src/js/Tests.js: Added. (.TestSuite): (.TestSuite.prototype.fail): (.TestSuite.prototype.assertEquals): (.TestSuite.prototype.assertTrue): (.TestSuite.prototype.assertContains): (.TestSuite.prototype.takeControl): (.TestSuite.prototype.releaseControl): (.TestSuite.prototype.reportOk_): (.TestSuite.prototype.reportFailure_): (.TestSuite.prototype.runTest): (.TestSuite.prototype.showPanel): (.TestSuite.prototype.addSniffer.receiver.methodName): (.TestSuite.prototype.addSniffer): (.TestSuite.prototype.testHostIsPresent): (.TestSuite.prototype.testElementsTreeRoot): (.TestSuite.prototype.testMainResource): (.TestSuite.prototype.testResourceContentLength.this.addSniffer.): (.TestSuite.prototype.testResourceHeaders): (.TestSuite.prototype.testCachedResourceMimeType.this.addSniffer.): (.TestSuite.prototype.testCachedResourceMimeType): (.TestSuite.prototype.testProfilerTab): (.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh.waitUntilScriptIsParsed): (.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh.checkScriptsPanel): (.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh): (.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.switchToElementsTab): (.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.switchToScriptsTab): (.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.checkScriptsPanel): (.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.checkNoDuplicates): (.TestSuite.prototype.testPauseOnException): (.TestSuite.prototype.testPauseWhenLoadingDevTools): (.TestSuite.prototype.testPauseWhenScriptIsRunning.testScriptPauseAfterDelay): (.TestSuite.prototype.testPauseWhenScriptIsRunning.testScriptPause): (.TestSuite.prototype.testPauseWhenScriptIsRunning): (.TestSuite.prototype.optionsToString_): (.TestSuite.prototype.evaluateInConsole_): (.TestSuite.prototype.waitForSetBreakpointResponse_): (.TestSuite.prototype.testEvalOnCallFrame.setBreakpointCallback): (.TestSuite.prototype.testEvalOnCallFrame.waitForBreakpointHit): (.TestSuite.prototype.testCompletionOnPause): (.TestSuite.prototype.testCompletionOnPause.testLocalsCompletion): (.TestSuite.prototype.testCompletionOnPause.testThisCompletion): (.TestSuite.prototype.testCompletionOnPause.testFieldCompletion): (.TestSuite.prototype.testCompletionOnPause.checkCompletions): (.TestSuite.prototype.testAutoContinueOnSyntaxError.checkScriptsList): (.TestSuite.prototype.testAutoContinueOnSyntaxError.waitForExceptionEvent.test): (.TestSuite.prototype.testAutoContinueOnSyntaxError.waitForExceptionEvent): (.TestSuite.prototype._checkExecutionLine): (.TestSuite.prototype._scriptsAreParsed): (.TestSuite.prototype._waitForScriptPause): (.TestSuite.prototype._checkSourceFrameWhenLoaded.checkExecLine): (.TestSuite.prototype._checkSourceFrameWhenLoaded): (.TestSuite.prototype._performSteps.doNextAction): (.TestSuite.prototype._performSteps): (.TestSuite.prototype._executeCodeWhenScriptsAreParsed.executeFunctionInInspectedPage): (.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts): (.TestSuite.prototype._waitUntilScriptsAreParsed): (.TestSuite.prototype._executeFunctionForStepTest): (.TestSuite.prototype.testStepOver): (.TestSuite.prototype.testStepOut): (.TestSuite.prototype.testStepIn): (.TestSuite.prototype._evaluateXpath): (.TestSuite.prototype._findNode): (.TestSuite.prototype._findText): (.TestSuite.prototype._nodeIterator): (.TestSuite.prototype._checkScopeSectionDiv): (.TestSuite.prototype._expandScopeSections.updateListener): (.TestSuite.prototype._expandScopeSections): (.TestSuite.prototype.testExpandScope): (.TestSuite.prototype.testExpandScope.examineScopes): (.TestSuite.prototype._findChildProperty): (.TestSuite.prototype._hookGetPropertiesCallback.accessor.getProperties): (.TestSuite.prototype._hookGetPropertiesCallback.try): (.TestSuite.prototype._hookGetPropertiesCallback): (.TestSuite.prototype.testDebugIntrinsicProperties.expandLocalScope): (.TestSuite.prototype.testDebugIntrinsicProperties): (.TestSuite.prototype.testDebugIntrinsicProperties.expandAndCheckNextProperty): (.TestSuite.prototype.testDebugIntrinsicProperties.checkProperty): (.TestSuite.createKeyEvent): (.TestSuite.prototype.testConsoleLog.assertNext): (.TestSuite.prototype.testConsoleLog): (.TestSuite.prototype.testEvalGlobal.initEval): (.TestSuite.prototype.testEvalGlobal): (.TestSuite.prototype.testShowStoragePanel.this.addSniffer.): (.TestSuite.prototype.testShowStoragePanel.this.addSniffer): (.uiTests.runAllTests): (.uiTests.runTest):
- 3:55 AM Changeset in webkit [54545] by
-
- 7 edits in trunk/JavaScriptCore
Three small string fixes:
(1) StringBuilder::release should CRASH if the buffer allocation failed.
(2) Remove weird, dead code from JSString::tryGetValue, replace with an ASSERT.
(3) Move UString::createFromUTF8 out to the API, as tryCreateStringFromUTF8.
This is only used from the API, and (now) unlike other UString::create
methods may return UString::null() to indicate failure cases. Better
handle these in the API.
Reviewed by Oliver Hunt.
- API/JSClassRef.cpp:
(tryCreateStringFromUTF8):
(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):
- runtime/JSString.h:
(JSC::Fiber::tryGetValue):
- runtime/StringBuilder.h:
(JSC::StringBuilder::release):
- runtime/UString.cpp:
(JSC::UString::UString):
(JSC::UString::from):
(JSC::UString::find):
- runtime/UString.h:
- 3:13 AM Changeset in webkit [54544] by
-
- 2 edits in trunk/LayoutTests
2010-02-09 Yuzo Fujishima <yuzo@google.com>
Unreviewed.
Fix build brekage introduced by r54536.
Add the following two to Skipped:
fast/css/inline-element-line-break.html and
fast/css/pseudo-element-line-break.html
- platform/gtk/Skipped:
- 2:40 AM Changeset in webkit [54543] by
-
- 5 edits in trunk
2010-02-09 Chang Shu <Chang.Shu@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Enable http/tests/appcache but skip the failed cases.
https://bugs.webkit.org/show_bug.cgi?id=34713
- platform/qt/Skipped:
2010-02-09 Chang Shu <Chang.Shu@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Enable appcache feature.
https://bugs.webkit.org/show_bug.cgi?id=34713
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage):
- DumpRenderTree/qt/main.cpp: (main):
- 2:24 AM Changeset in webkit [54542] by
-
- 1 edit1 add in trunk/WebCore
2010-02-09 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port KURL::fileSystemPath
https://bugs.webkit.org/show_bug.cgi?id=34516
Convert a file URL to a file path by prefixing
AEEFS_HOME_DIR to access files relative to the current
module directory in a case-sensitive manner.
As IWeb "file:" engine opens files in BREW's application-relative
file namespace, we follow the same policy here.
- platform/brew/KURLBrew.cpp: Added. (WebCore::KURL::fileSystemPath):
- 2:07 AM Changeset in webkit [54541] by
-
- 2 edits in trunk/WebCore
2010-02-09 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] the above website does not render properly when in compositing mode
https://bugs.webkit.org/show_bug.cgi?id=34681
http://media.24ways.org/2009/15/spinner-alt.html now renders correctly
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::MaskEffectQt::MaskEffectQt): implement mask as QGraphicsEffect (WebCore::MaskEffectQt::draw): reimp (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): init the effect (WebCore::GraphicsLayerQtImpl::paint): no need for drawContents (WebCore::GraphicsLayerQtImpl::flushChanges): make sure to update the mask layer, not just the actual children
- 2:01 AM Changeset in webkit [54540] by
-
- 2 edits in trunk/LayoutTests
2010-02-09 Eric Seidel <eric@webkit.org>
Reviewed by Shinichiro Hamaji.
storage/database-lock-after-reload.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=29154
- platform/mac/Skipped: Skip for now to keep the bots green until someone can take a look.
- 1:51 AM Changeset in webkit [54539] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-09 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Laszlo Gombos.
[Qt] use nanval() for Symbian as nonInlineNaN
https://bugs.webkit.org/show_bug.cgi?id=34170
numeric_limits<double>::quiet_NaN is broken in Symbian
causing NaN to be evaluated as a number.
- runtime/JSValue.cpp: (JSC::nonInlineNaN):
- 1:39 AM Changeset in webkit [54538] by
-
- 3 edits20 adds in trunk/LayoutTests
2010-02-09 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Add modified version of CSS2.1 test suite for paged media
https://bugs.webkit.org/show_bug.cgi?id=34695
Note that page-break-inside-000 is failing now.
- platform/qt/Skipped:
- platform/win/Skipped:
- printing/css2.1/README.txt: Added.
- printing/css2.1/page-break-after-000-expected.txt: Added.
- printing/css2.1/page-break-after-000.html: Added.
- printing/css2.1/page-break-after-001-expected.txt: Added.
- printing/css2.1/page-break-after-001.html: Added.
- printing/css2.1/page-break-after-002-expected.txt: Added.
- printing/css2.1/page-break-after-002.html: Added.
- printing/css2.1/page-break-after-004-expected.txt: Added.
- printing/css2.1/page-break-after-004.html: Added.
- printing/css2.1/page-break-before-000-expected.txt: Added.
- printing/css2.1/page-break-before-000.html: Added.
- printing/css2.1/page-break-before-001-expected.txt: Added.
- printing/css2.1/page-break-before-001.html: Added.
- printing/css2.1/page-break-before-002-expected.txt: Added.
- printing/css2.1/page-break-before-002.html: Added.
- printing/css2.1/page-break-inside-000-expected.txt: Added.
- printing/css2.1/page-break-inside-000.html: Added.
- printing/resources/paged-media-test-utils.js: Added. (pageNumberShouldBe):
- 1:35 AM Changeset in webkit [54537] by
-
- 2 edits in trunk/WebCore
2010-02-09 Kwang Yul Seo <skyul@company100.net>
Reviewed by Laszlo Gombos.
[BREWMP] Fix macro redefinition error in BREWMP simulator build.
https://bugs.webkit.org/show_bug.cgi?id=34738
Remove warning: 'FAR' macro redefinition.
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
- 1:16 AM Changeset in webkit [54536] by
-
- 12 edits8 adds in trunk
2010-02-07 Yuzo Fujishima <yuzo@google.com>
Reviewed by Dan Bernstein.
Fix the following bugs:
https://bugs.webkit.org/show_bug.cgi?id=18926 - dt:after generate a line break. Boost documentation page renders poorly
https://bugs.webkit.org/show_bug.cgi?id=7276 - Most W3C padding related tests fail
css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.html and css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.html have been rebaselined
because the original expected values are incorrect, judging from the test description and how IE 8.0, Firefox 3.6, and Opera 10.10 render the pages.
fast/dom/clone-node-dynamic-style-expected.html have been also rebaselined because the original expected values assumes a line break.
Expected values under platform/qt need not be updated because the tests are in the Skipped file for the platform.
- fast/css/inline-element-line-break.html: Added.
- fast/css/pseudo-element-line-break.html: Added.
- platform/mac/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.checksum:
- platform/mac/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.png:
- platform/mac/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.txt:
- platform/mac/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.checksum:
- platform/mac/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.png:
- platform/mac/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.txt:
- platform/mac/fast/css/inline-element-line-break-expected.checksum: Added.
- platform/mac/fast/css/inline-element-line-break-expected.png: Added.
- platform/mac/fast/css/inline-element-line-break-expected.txt: Added.
- platform/mac/fast/css/pseudo-element-line-break-expected.checksum: Added.
- platform/mac/fast/css/pseudo-element-line-break-expected.png: Added.
- platform/mac/fast/css/pseudo-element-line-break-expected.txt: Added.
- platform/mac/fast/dom/clone-node-dynamic-style-expected.checksum:
- platform/mac/fast/dom/clone-node-dynamic-style-expected.png:
- platform/mac/fast/dom/clone-node-dynamic-style-expected.txt:
2010-02-07 Yuzo Fujishima <yuzo@google.com>
Reviewed by Dan Bernstein.
Fix the following bugs:
https://bugs.webkit.org/show_bug.cgi?id=18926 - dt:after generate a line break. Boost documentation page renders poorly
https://bugs.webkit.org/show_bug.cgi?id=7276 - Most W3C padding related tests fail
Tests: fast/css/inline-element-line-break.html
fast/css/pseudo-element-line-break.html
findNextLineBreak() unconditionally allowed lines to break between elements when no other line breaking opportunity had been found,
but that was unnecessary and led to incorrect layout. Disallow that kind of line breaks.
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):
- 12:52 AM Changeset in webkit [54535] by
-
- 3 edits2 adds in trunk
2010-02-09 Avi Drissman <avi@chromium.org>
Reviewed by David Levin.
Chromium Mac: Control-A shouldn't select all/Control-C shouldn't copy
https://bugs.webkit.org/show_bug.cgi?id=34615
- fast/events/attempt-select-all-with-wrong-modifier-expected.txt: Added.
- fast/events/attempt-select-all-with-wrong-modifier.html: Added.
2010-02-09 Avi Drissman <avi@chromium.org>
Reviewed by David Levin.
Chromium Mac: Control-A shouldn't select all/Control-C shouldn't copy
https://bugs.webkit.org/show_bug.cgi?id=34615
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::keyEventDefault):
- 12:50 AM Changeset in webkit [54534] by
-
- 6 edits in trunk/JavaScriptCore
Add a soft modulo operation to ARM JIT using a trampoline function.
The performance progression is about ~1.8% on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=34424
Patch by Tamas Szirbucz <szirbucz@inf.u-szeged.hu> on 2010-02-09
Reviewed by Gavin Barraclough.
Developed in cooperation with Gabor Loki.
- jit/JIT.h:
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):
- jit/JITOpcodes.cpp:
(JSC::JIT::softModulo):
- jit/JITStubs.h:
(JSC::JITThunks::ctiSoftModulo):
- wtf/Platform.h:
- 12:32 AM Changeset in webkit [54533] by
-
- 17 edits3 adds in trunk
2010-02-09 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get total number of pages to be printed
https://bugs.webkit.org/show_bug.cgi?id=34699
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- printing/numberOfPages-expected.txt: Added.
- printing/numberOfPages.html: Added.
- printing/script-tests/numberOfPages.js: Added. (createParagraph):
2010-02-09 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get total number of pages to be printed
https://bugs.webkit.org/show_bug.cgi?id=34699
Test: printing/numberOfPages.html
- WebCore.base.exp:
- page/PrintContext.cpp: (WebCore::PrintContext::pageNumberForElement): (WebCore::PrintContext::numberOfPages):
- page/PrintContext.h: (WebCore::PrintContext::pageRects):
2010-02-09 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get total number of pages to be printed
https://bugs.webkit.org/show_bug.cgi?id=34699
- Misc/WebCoreStatistics.h:
- Misc/WebCoreStatistics.mm: (-[WebFrame numberOfPages:pageWidthInPixels:]):
2010-02-09 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get total number of pages to be printed
https://bugs.webkit.org/show_bug.cgi?id=34699
- DumpRenderTree/LayoutTestController.cpp: (parsePageParameters): (pageNumberForElementByIdCallback): (numberOfPagesCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::numberOfPages):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::numberOfPages):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::numberOfPages):
Feb 8, 2010:
- 11:53 PM Changeset in webkit [54532] by
-
- 3 edits in trunk/JavaScriptCore
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- runtime/StringPrototype.cpp:
Reviewed by NOBODY (SL/win build fixes).
- 11:40 PM Changeset in webkit [54531] by
-
- 5 edits in trunk/JavaScriptCore
Make String.replace throw an exception on out-of-memory, rather than
returning a null (err, empty-ish) string. Move String::replaceRange
and String::spliceSubstringsWithSeparators out to StringPrototype -
these were fairly specific use anyway, and we can better integrate
throwing the JS expcetion this way.
Reviewed by Oliver Hunt
Also removes redundant assignment operator from UString.
- JavaScriptCore.exp:
- runtime/StringPrototype.cpp:
(JSC::StringRange::StringRange):
(JSC::jsSpliceSubstringsWithSeparators):
(JSC::jsReplaceRange):
(JSC::stringProtoFuncReplace):
- runtime/UString.cpp:
- runtime/UString.h:
- 11:32 PM Changeset in webkit [54530] by
-
- 1 edit3 adds in trunk/LayoutTests
Add numerous parse-only tests.
https://bugs.webkit.org/show_bug.cgi?id=34019
Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2010-02-09
Reviewed by Oliver Hunt.
The input file contains a lot of strings, and tests whether they are
valid JavaScript code snippets or contains various syntax errors.
No semantic checks: even if a tests throws an exception, which is not
syntax error, it is considered successfull.
- fast/js/parser-syntax-check-expected.txt: Added.
- fast/js/parser-syntax-check.html: Added.
- fast/js/script-tests/parser-syntax-check.js: Added.
(runTest):
(valid):
(invalid):
- 11:15 PM Changeset in webkit [54529] by
-
- 2 edits in trunk/LayoutTests
2010-02-08 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed GTK+ test fix.
Web site is stuck loading forever
https://bugs.webkit.org/show_bug.cgi?id=31227
It seems the following bug is addressing this issue.
[GTK] Needs proper reporting of frame loader callbacks, in DRT
https://bugs.webkit.org/show_bug.cgi?id=32170
- platform/gtk/Skipped:
- 11:15 PM Changeset in webkit [54528] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-08 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Undefine WTF_OS_WINDOWS and WTF_PLATFORM_WIN
https://bugs.webkit.org/show_bug.cgi?id=34561
As the binary for simulator is built with MSVC 2005,
WTF_OS_WINDOWS and WTF_PLATFORM_WIN are defined.
Undefine them as we don't target Windows.
- wtf/Platform.h:
- 10:48 PM Changeset in webkit [54527] by
-
- 4 edits1 add in trunk/WebCore
2010-02-08 Dominic Cooney <dominicc@google.com>
Reviewed by Adam Barth.
[V8] Move Element custom methods into generic bindings
This patch moves the security checks in setAttribute,
setAttributeNode, setAttributeNS and setAttributeNodeNS from
V8ElementCustom into the generic bindings so that they can be
reused in other bindings. This is in a similar vein to
<https://bugs.webkit.org/attachment.cgi?id=45872>.
LayoutTests: None
- WebCore.gypi:
- bindings/generic/BindingElement.h: Added. (WebCore::::setAttribute): (WebCore::::setAttributeNode): (WebCore::::setAttributeNS): (WebCore::::setAttributeNodeNS):
- bindings/v8/V8Binding.h:
- bindings/v8/custom/V8ElementCustom.cpp: (WebCore::V8Element::setAttributeCallback): (WebCore::V8Element::setAttributeNodeCallback): (WebCore::V8Element::setAttributeNSCallback): (WebCore::V8Element::setAttributeNodeNSCallback):
- 10:17 PM Changeset in webkit [54526] by
-
- 3 edits4 adds in trunk
2010-02-08 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Schedule a loading request when there are many in-flight requests beyond
the limit to avoid forever page loading.
- http/tests/loading/load-javascript-after-many-xhrs-expected.txt: Added.
- http/tests/loading/load-javascript-after-many-xhrs.html: Added.
- http/tests/loading/resources/zero-length.js: Added.
- http/tests/loading/resources/zero-length.txt: Added.
2010-02-08 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Schedule a loading request when there are many in-flight requests beyond
the limit to avoid forever page loading.
Test: http/tests/loading/load-javascript-after-many-xhrs.html
- loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests):
- 9:19 PM Changeset in webkit [54525] by
-
- 4 edits in trunk/WebCore
REGRESSION (before r54472): Various tests in fast/workers are crashing on the buildbot.
https://bugs.webkit.org/show_bug.cgi?id=34728
Reviewed by Gavin Barraclough.
The core part of the fix is to change WebCoreJSClientData::m_normalWorld
from DOMWrapperWorld to RefPtr<DOMWrapperWorld> so that the DOMWrapperWorld
is really ref counted.
No new tests because current tests sufficiently cover this as evidenced as
the buildbot crashes.
- bindings/js/JSDOMBinding.cpp:
(WebCore::DOMWrapperWorld::~DOMWrapperWorld): Made this robust to m_globalData
being 0.
- bindings/js/JSDOMBinding.h:
(WebCore::DOMWrapperWorld::create): Made this class follow the standard
create pattern for RefCounted classes.
(WebCore::DOMWrapperWorld::detachFromGlobalData): Since this class can
now outlive JSGlobalData, this method tells it to stop using its JSGlobalData.
(WebCore::WebCoreJSClientData::WebCoreJSClientData): Adjusted due to
m_normalWorld being a RefPtr.
(WebCore::WebCoreJSClientData::~WebCoreJSClientData): Ditto (and added
asserts for the FIXME).
(WebCore::WebCoreJSClientData::normalWorld): Ditto.
- bindings/js/ScriptController.cpp:
(WebCore::IsolatedWorld::create): Made the constructor protected.
(WebCore::IsolatedWorld::IsolatedWorld): Made the constructor protected, so
that code would have to use the create method.
- 7:05 PM Changeset in webkit [54524] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-08 Evan Martin <evan@chromium.org>
dlopen() knows how to search the library search path, so just rely on
it. While I'm at it, print out the dlerror() error message on failure.
[chromium] webgl shouldn't hard code library search path
https://bugs.webkit.org/show_bug.cgi?id=34659
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GLConnection::GLConnection): (WebCore::GraphicsContext3DInternal::GLConnection::create):
- 6:48 PM Changeset in webkit [54523] by
-
- 3 edits in trunk/WebCore
2010-02-08 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Remove special utf-8 tag from Chromium cilpboard code because
we now have the corresponding code in generic clipboard framework
code in chromium (since it's needed by other places than in Web
page rendering) and no longer need the separate workaround code in
WebKit.
https://bugs.webkit.org/show_bug.cgi?id=34567
Test: (for regression) editing/pasteboard
- platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::writeRange):
- platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::documentFragment):
- 6:31 PM Changeset in webkit [54522] by
-
- 1 edit1 add in trunk/JavaScriptCore
2010-02-08 Chris Rogers <crogers@google.com>
Reviewed by Darin Adler.
audio engine: add Vector3 class
https://bugs.webkit.org/show_bug.cgi?id=34548
- wtf/Vector3.h: Added. (WebCore::Vector3::Vector3): (WebCore::Vector3::abs): (WebCore::Vector3::isZero): (WebCore::Vector3::normalize): (WebCore::Vector3::x): (WebCore::Vector3::y): (WebCore::Vector3::z): (WebCore::operator+): (WebCore::operator-): (WebCore::operator*): (WebCore::dot): (WebCore::cross): (WebCore::distance):
- 6:12 PM Changeset in webkit [54521] by
-
- 3 edits2 adds in trunk
Crash due to layout not done in case involving removal of absolute positioning
https://bugs.webkit.org/show_bug.cgi?id=34734
rdar://problem/7588280
Reviewed by Dan Bernstein.
WebCore:
Test: fast/dynamic/position-change-layout.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleDidChange): Call markContainingBlocksForLayout in
a case where the object already needs layout, but might have a new containing
block and so needs to mark the new containing block.
LayoutTests:
- fast/dynamic/position-change-layout-expected.txt: Added.
- fast/dynamic/position-change-layout.html: Added.
- 5:24 PM Changeset in webkit [54520] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-08 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Fix warning in clang++
- runtime/Structure.h: (JSC::Structure::propertyStorageSize):
- 4:32 PM Changeset in webkit [54519] by
-
- 5 edits2 adds in trunk
2010-02-08 Charlie Reis <creis@chromium.org>
Reviewed by Darin Adler.
onbeforeunload not called at window close + frame or iframe focused
https://bugs.webkit.org/show_bug.cgi?id=27481
Chromium and WebKit on Windows will now fire beforeunload handlers
even if an inner frame is focused.
Layout tests aren't able to test this bug, since it requires closing
the actual browser window, not calling window.close(). Instead,
test with WebCore/manual-tests/onbeforeunload-focused-iframe.html.
- manual-tests/onbeforeunload-focused-iframe.html: Added.
- manual-tests/resources/focused-iframe.html: Added.
2010-02-08 Charlie Reis <creis@chromium.org>
Reviewed by Darin Adler.
onbeforeunload not called at window close + frame or iframe focused
https://bugs.webkit.org/show_bug.cgi?id=27481
http://code.google.com/p/chromium/issues/detail?id=32615
http://code.google.com/p/chromium/issues/detail?id=17157
Chromium and WebKit on Windows will now fire beforeunload handlers
even if an inner frame is focused.
Layout tests aren't able to test this bug, since it requires closing
the actual browser window, not calling window.close(). Instead,
test with WebCore/manual-tests/onbeforeunload-focused-iframe.html.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::dispatchBeforeUnloadEvent):
2010-02-08 Charlie Reis <creis@chromium.org>
Reviewed by Darin Adler.
onbeforeunload not called at window close + frame or iframe focused
https://bugs.webkit.org/show_bug.cgi?id=27481
Chromium and WebKit on Windows will now fire beforeunload handlers
even if an inner frame is focused.
Layout tests aren't able to test this bug, since it requires closing
the actual browser window, not calling window.close(). Instead,
test with WebCore/manual-tests/onbeforeunload-focused-iframe.html.
- WebView.cpp: (WebView::shouldClose):
- 3:43 PM Changeset in webkit [54518] by
-
- 3 edits in trunk/JavaScriptCore
Make makeString CRASH if we fail to allocate a string.
Reviewed by Geoff Garen.
(tryMakeString or jsMakeNontrivialString can be used where we
expect allocation may fail and want to handle the error).
- runtime/JSStringBuilder.h:
(JSC::jsMakeNontrivialString):
- runtime/UString.h:
(JSC::tryMakeString):
(JSC::makeString):
- 3:28 PM Changeset in webkit [54517] by
-
- 2 edits in trunk/WebCore
Addressing review feedback.
- bridge/c/c_instance.h: Removed argument name.
- 3:27 PM Changeset in webkit [54516] by
-
- 10 edits2 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=34727
Assertion crashes and freezes when plug-in property access results in an exception
Test: plugins/netscape-plugin-property-access-exception.html
- 3:27 PM Changeset in webkit [54515] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by David Levin.
WebKit/chromium: Custom context menu does not work in inspector.
https://bugs.webkit.org/show_bug.cgi?id=34711
- src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::jsShowContextMenu):
- 3:13 PM Changeset in webkit [54514] by
-
- 2 edits in trunk/JavaScriptCore
Rubber Stamped by Oliver Hunt.
Remove a couple of unnecesary C-style casts spotted by Darin.
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::globalFuncEscape):
- 3:04 PM Changeset in webkit [54513] by
-
- 3 edits in trunk/JavaScriptCore
Switch some more StringBuilder/jsNontrivialString code to use
JSStringBuilder/jsMakeNontrivialString - these methods will
throw an exception if we hit out-of-memory, rather than just
CRASHing.
Reviewed by Geoff Garen.
- runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::decode):
(JSC::globalFuncEscape):
- 2:58 PM Changeset in webkit [54512] by
-
- 4 edits in trunk/WebKitTools
[Qt] Backport No'am Rosenthal's frame rate measurement
Reviewed by Ariya Hidayat.
- QtLauncher/main.cpp:
(LauncherWindow::LauncherWindow):
(LauncherApplication::handleUserOptions):
- QtLauncher/webview.cpp:
(WebViewGraphicsBased::WebViewGraphicsBased):
(WebViewGraphicsBased::enableFrameRateMeasurement):
(WebViewGraphicsBased::updateFrameRate):
(WebViewGraphicsBased::paintEvent):
- QtLauncher/webview.h:
- 2:43 PM Changeset in webkit [54511] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-08 Nate Chapin <Nate Chapin>
Reviewed by Darin Fisher.
Check that the index passed into BackForwardListClientImpl::itemAtIndex()
is valid, and return null if it isn't.
- src/BackForwardListClientImpl.cpp: (WebKit::BackForwardListClientImpl::itemAtIndex):
- 2:26 PM Changeset in webkit [54510] by
-
- 8 edits in trunk/JavaScriptCore
Use an empty identifier instead of a null identifier for parse
tokens without an identifier.
Reviewed by Sam Weinig.
This helps encapsulate the null UStringImpl within UString.
- parser/Grammar.y:
- parser/NodeConstructors.h:
(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ForInNode::ForInNode):
- runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::CommonIdentifiers):
- runtime/CommonIdentifiers.h:
- runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::FunctionPrototype):
- 1:55 PM Changeset in webkit [54509] by
-
- 4 edits in trunk/WebCore
2010-02-08 Dirk Schulze <krit@webkit.org>
Unreviewed build fix of ChromiumWin.
- platform/graphics/chromium/TransparencyWin.cpp: (WebCore::): (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer): (WebCore::TransparencyWin::setupTransformForKeepTransform):
- platform/graphics/chromium/TransparencyWin.h:
- rendering/RenderThemeChromiumWin.cpp: (WebCore::):
- 1:48 PM Changeset in webkit [54508] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-08 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Implement FrameLoaderClient::hasWebView
https://bugs.webkit.org/show_bug.cgi?id=34682
Used for sanity-check ASSERTS in the FrameLoader code.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::hasWebView):
- 1:35 PM Changeset in webkit [54507] by
-
- 2 edits in trunk/LayoutTests
Put the test back on skipped list - it needs a newer version of Safari to pass.
- platform/mac-snowleopard/Skipped:
- 1:20 PM Changeset in webkit [54506] by
-
- 7 edits in trunk
WebCore: Adding a way to get the set of all open database handles pointing
to a given database.
https://bugs.webkit.org/show_bug.cgi?id=34619
Reviewed by Jeremy Orlow.
Sometimes we need to be able to close all handles to a database as
soon as possible (to delete the DB file, for example).
- storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::getOpenDatabases):
- storage/DatabaseTracker.h:
- storage/chromium/DatabaseTrackerChromium.cpp:
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
WebKit/chromium: Adding a way to close all database handles pointing to a certain
database as soon as possible.
https://bugs.webkit.org/show_bug.cgi?id=34619
Reviewed by Jeremy Orlow.
- public/WebDatabase.h:
- src/WebDatabase.cpp:
(WebKit::WebDatabase::closeDatabaseImmediately):
- 12:55 PM Changeset in webkit [54505] by
-
- 2 edits in trunk/WebCore
2010-02-08 Dirk Schulze <krit@webkit.org>
Unreviewed windows build-fix.
- page/win/FrameCGWin.cpp: (WebCore::drawRectIntoContext):
- 12:53 PM Changeset in webkit [54504] by
-
- 8 edits in trunk
Reviewed by Anders Carlsson.
<rdar://problem/6530010> OOP: Support NPN_SetException
Tested by plugins/netscape-throw-exception.html (removed it from skipped list).
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCSetException):
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::globalExceptionString): (WebKit::NetscapePluginInstanceProxy::setGlobalException): (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
- Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invoke): (WebKit::ProxyInstance::getPropertyNames): (WebKit::ProxyInstance::fieldValue): (WebKit::ProxyInstance::setFieldValue):
- Plugins/Hosted/WebKitPluginClient.defs: Route exception string to a global that's checked after calling into plug-in (just like in in-process case).
- 12:30 PM Changeset in webkit [54503] by
-
- 154 edits in trunk
2010-02-08 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Add back an AffineTransform class for use by SVG
https://bugs.webkit.org/show_bug.cgi?id=33750
This adds back AffineTransform. This saves additional 4% memory consumption
on the 50k rects stress test: https://bugs.webkit.org/attachment.cgi?id=46721
It also makes it possible to optimize the calculations internally of
AffineTransform to the needs of 2D transformations (the second benefit for SVG,
which uses transformations relative often at the moment.
Everything that is 2D related (like images, patterns, gradients, fonts), uses
AffineTransform now.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::multiply): (WebCore::JSSVGMatrix::inverse): (WebCore::JSSVGMatrix::rotateFromVector):
- bindings/js/JSSVGPODTypeWrapper.h:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorObjC.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8Index.h:
- bindings/v8/custom/V8SVGMatrixCustom.cpp: (WebCore::V8SVGMatrix::multiplyCallback): (WebCore::V8SVGMatrix::inverseCallback): (WebCore::V8SVGMatrix::rotateFromVectorCallback):
- html/HTMLCanvasElement.cpp: Changed to AffineTransform now (WebCore::HTMLCanvasElement::baseTransform):
- html/HTMLCanvasElement.h:
- platform/graphics/FloatPoint.cpp: (WebCore::FloatPoint::matrixTransform):
- platform/graphics/FloatPoint.h:
- platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern):
- platform/graphics/GeneratedImage.h:
- platform/graphics/Gradient.cpp: (WebCore::Gradient::setGradientSpaceTransform): (WebCore::Gradient::setPlatformGradientSpaceTransform):
- platform/graphics/Gradient.h: (WebCore::Gradient::gradientSpaceTransform):
- platform/graphics/GraphicsContext.h:
- platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
- platform/graphics/Image.h:
- platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::baseTransform):
- platform/graphics/Path.h:
- platform/graphics/Pattern.cpp: (WebCore::Pattern::setPatternSpaceTransform):
- platform/graphics/Pattern.h: (WebCore::Pattern::create): (WebCore::Pattern::tileImage):
- platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::setPlatformFill): (WebCore::setPlatformStroke): (WebCore::GraphicsContext::getCTM):
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
- platform/graphics/cairo/PathCairo.cpp:
- platform/graphics/cairo/PatternCairo.cpp: (WebCore::Pattern::createPlatformPattern):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::getCTM):
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
- platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern):
- platform/graphics/cg/PathCG.cpp:
- platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
- platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::getCTM):
- platform/graphics/haiku/ImageHaiku.cpp: (WebCore::Image::drawPattern):
- platform/graphics/haiku/PathHaiku.cpp:
- platform/graphics/qt/FontQt.cpp: (WebCore::Font::drawComplexText):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect):
- platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern):
- platform/graphics/qt/PathQt.cpp:
- platform/graphics/qt/PatternQt.cpp: (WebCore::Pattern::createPlatformPattern):
- platform/graphics/skia/GradientSkia.cpp: (WebCore::Gradient::setPlatformGradientSpaceTransform):
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::getCTM):
- platform/graphics/skia/ImageSkia.cpp: (WebCore::Image::drawPattern):
- platform/graphics/skia/PathSkia.cpp:
- platform/graphics/skia/PatternSkia.cpp: (WebCore::Pattern::platformPattern):
- platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleTextDrawing):
- platform/graphics/transforms/AffineTransform.cpp: (WebCore::AffineTransform::makeIdentity): needed by some parts of WebCore (WebCore::AffineTransform::scale): Didn't scale the complete matrix (WebCore::AffineTransform::translate): Didn't respect other transformations (WebCore::AffineTransform::shear): direct calculation, no extra multiply of matrices (WebCore::AffineTransform::map): (WebCore::AffineTransform::mapPoint): (WebCore::AffineTransform::mapRect):
- platform/graphics/transforms/AffineTransform.h: (WebCore::AffineTransform::isIdentityOrTranslation):
- platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::toAffineTransform):
- platform/graphics/transforms/TransformationMatrix.h:
- platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs):
- platform/graphics/win/GraphicsContextCGWin.cpp:
- platform/graphics/win/GraphicsContextCairoWin.cpp:
- platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
- platform/graphics/wince/FontWince.cpp:
- platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContextPlatformPrivate::concatCTM): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::drawBitmapPattern):
- platform/graphics/wince/ImageBufferWince.cpp: (WebCore::): (WebCore::BufferedImage::drawPattern):
- platform/graphics/wince/PathWince.cpp: (WebCore::Path::transform):
- platform/graphics/wince/PlatformPathWince.cpp: (WebCore::drawPolygons): (WebCore::PathPolygon::transform): (WebCore::PlatformPathElement::transform): (WebCore::PlatformPath::strokePath): (WebCore::PlatformPath::fillPath): (WebCore::PlatformPath::transform):
- platform/graphics/wince/PlatformPathWince.h: (WebCore::):
- platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::getCTM):
- platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::drawPattern): (WebCore::Image::drawPattern):
- platform/graphics/wx/PathWx.cpp:
- platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozillaGtkWidget):
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::paintWindowedPluginIntoContext):
- rendering/RenderBox.cpp: (WebCore::RenderBox::localTransform):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelScaleData::RenderBoxModelScaleData): (WebCore::RenderBoxModelScaleData::transform): (WebCore::RenderBoxModelScaleData::setTransform): (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality): (WebCore::RenderBoxModelObject::paintBoxShadow):
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::translationForAttributes): (WebCore::RenderForeignObject::localToParentTransform):
- rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::localTransform):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
- rendering/RenderObject.cpp: (WebCore::RenderObject::localTransform): (WebCore::RenderObject::localToParentTransform): (WebCore::RenderObject::absoluteTransform):
- rendering/RenderObject.h:
- rendering/RenderPath.cpp: (WebCore::RenderPath::localToParentTransform): (WebCore::RenderPath::localTransform):
- rendering/RenderPath.h:
- rendering/RenderSVGHiddenContainer.h: (WebCore::RenderSVGHiddenContainer::absoluteTransform):
- rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::localToParentTransform): (WebCore::RenderSVGImage::localTransform):
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::localToBorderBoxTransform): (WebCore::RenderSVGRoot::localToRepaintContainerTransform): (WebCore::RenderSVGRoot::localToParentTransform): (WebCore::RenderSVGRoot::absoluteTransform): (WebCore::RenderSVGRoot::localTransform):
- rendering/RenderSVGRoot.h:
- rendering/RenderSVGText.h: (WebCore::RenderSVGText::localToParentTransform): (WebCore::RenderSVGText::localTransform):
- rendering/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::localToParentTransform): (WebCore::RenderSVGTransformableContainer::localTransform): (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
- rendering/RenderSVGTransformableContainer.h:
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::markerBoundaries): (WebCore::RenderSVGViewportContainer::markerContentTransformation): (WebCore::RenderSVGViewportContainer::viewportTransform): (WebCore::RenderSVGViewportContainer::localToParentTransform): (WebCore::RenderSVGViewportContainer::absoluteTransform):
- rendering/RenderSVGViewportContainer.h:
- rendering/SVGCharacterLayoutInfo.cpp: (WebCore::SVGChar::characterTransform):
- rendering/SVGCharacterLayoutInfo.h: (WebCore::SVGTextChunkWalker::operator()):
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::calculateGlyphBoundaries): (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback): (WebCore::SVGInlineTextBoxSelectionRectWalker::chunkPortionCallback): (WebCore::SVGInlineTextBox::paintCharacters): (WebCore::SVGInlineTextBox::paintDecoration):
- rendering/SVGMarkerLayoutInfo.h: (WebCore::MarkerLayout::MarkerLayout):
- rendering/SVGRenderSupport.cpp: (WebCore::applyTransformToPaintInfo):
- rendering/SVGRenderSupport.h:
- rendering/SVGRenderTreeAsText.cpp: (WebCore::operator<<):
- rendering/SVGRenderTreeAsText.h:
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback): (WebCore::applyTextLengthCorrectionToTextChunk): (WebCore::SVGRootInlineBox::buildLayoutInformation):
- rendering/TransformState.cpp: (WebCore::TransformState::applyTransform):
- rendering/TransformState.h:
- svg/GradientAttributes.h: (WebCore::GradientAttributes::gradientTransform): (WebCore::GradientAttributes::setGradientTransform):
- svg/PatternAttributes.h: (WebCore::PatternAttributes::patternTransform): (WebCore::PatternAttributes::setPatternTransform):
- svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::resetToBaseValue): (WebCore::SVGAnimateMotionElement::calculateAnimatedValue): (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
- svg/SVGAnimateMotionElement.h:
- svg/SVGAnimateTransformElement.cpp:
- svg/SVGAnimateTransformElement.h:
- svg/SVGElement.h: (WebCore::SVGElement::supplementalTransform):
- svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::viewBoxToViewTransform):
- svg/SVGFitToViewBox.h:
- svg/SVGLocatable.cpp: (WebCore::SVGLocatable::getCTM): (WebCore::SVGLocatable::getScreenCTM): (WebCore::SVGLocatable::getTransformToElement):
- svg/SVGLocatable.h:
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::viewBoxToViewTransform):
- svg/SVGMarkerElement.h:
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
- svg/SVGMatrix.idl:
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern):
- svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::getCTM):
- svg/SVGPreserveAspectRatio.h:
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::viewport): (WebCore::SVGSVGElement::createSVGMatrix): (WebCore::SVGSVGElement::createSVGTransformFromMatrix): (WebCore::SVGSVGElement::getCTM): (WebCore::SVGSVGElement::getScreenCTM): (WebCore::SVGSVGElement::viewBoxToViewTransform):
- svg/SVGSVGElement.h:
- svg/SVGStyledLocatableElement.cpp: (WebCore::SVGStyledLocatableElement::getCTM): (WebCore::SVGStyledLocatableElement::getScreenCTM):
- svg/SVGStyledLocatableElement.h:
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::getCTM): (WebCore::SVGStyledTransformableElement::getScreenCTM): (WebCore::SVGStyledTransformableElement::animatedLocalTransform): (WebCore::SVGStyledTransformableElement::supplementalTransform):
- svg/SVGStyledTransformableElement.h: (WebCore::SVGStyledTransformableElement::isStyledTransformable): (WebCore::SVGStyledTransformableElement::toPathData):
- svg/SVGTextContentElement.cpp: (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback):
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::getScreenCTM): (WebCore::SVGTextElement::getCTM): (WebCore::SVGTextElement::animatedLocalTransform): (WebCore::SVGTextElement::supplementalTransform):
- svg/SVGTextElement.h:
- svg/SVGTextPathElement.cpp:
- svg/SVGTransform.cpp: (SVGTransform::SVGTransform): (SVGTransform::matrix): (SVGTransform::setMatrix):
- svg/SVGTransform.h:
- svg/SVGTransformDistance.cpp: (WebCore::SVGTransformDistance::SVGTransformDistance): (WebCore::SVGTransformDistance::scaledDistance): (WebCore::SVGTransformDistance::isZero):
- svg/SVGTransformDistance.h:
- svg/SVGTransformList.cpp: (SVGTransformList::createSVGTransformFromMatrix): (SVGTransformList::concatenate): (SVGTransformList::valueAsString):
- svg/SVGTransformList.h:
- svg/SVGTransformable.cpp: (WebCore::SVGTransformable::getCTM): (WebCore::SVGTransformable::getScreenCTM): (WebCore::SVGTransformable::parseTransformValue):
- svg/SVGTransformable.h: (WebCore::SVGTransformable::):
- svg/graphics/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::gradientTransform): (WebCore::SVGPaintServerGradient::setGradientTransform): (WebCore::clipToTextMask): (WebCore::SVGPaintServerGradient::setup):
- svg/graphics/SVGPaintServerGradient.h:
- svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::patternTransform): (WebCore::SVGPaintServerPattern::setPatternTransform): (WebCore::SVGPaintServerPattern::setup):
- svg/graphics/SVGPaintServerPattern.h:
- svg/graphics/SVGResourceClipper.cpp: (WebCore::SVGResourceClipper::applyClip):
- svg/graphics/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::markerTransformation): (WebCore::SVGResourceMarker::draw):
- svg/graphics/SVGResourceMarker.h:
- svg/graphics/filters/SVGFEImage.cpp:
- svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):
2010-02-08 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Add back an AffineTransform class for use by SVG
https://bugs.webkit.org/show_bug.cgi?id=33750
Some negative zero problems fixed, but new one were added on other places. A seperate
patch should fix it all at once.
use-on-disallowed-foreign-object-3 and 4 had wrong results. The old SVG code
with TransformationMatrix used translateRight, that was wrong at this place and is
fixed now.
- platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt:
- platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
- platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
- svg/dom/SVGMatrix-interface-expected.txt:
- svg/dom/SVGMatrix-interface.xhtml:
2010-02-08 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Add back an AffineTransform class for use by SVG
https://bugs.webkit.org/show_bug.cgi?id=33750
Use AffineTransform instead of TransformationMatrix here.
- tests/TransparencyWinTest.cpp: (WebCore::TEST):
- 12:25 PM Changeset in webkit [54502] by
-
- 3 edits in trunk/WebCore
2010-02-08 Stephen White <senorblanco@chromium.org>
Reviewed by Dimitri Glazkov.
Make an inline function containing a static var out-of-line. This is
a workaround for Xcode 3.1 bug radar 7070016. We tripped on this in
deviceRGBColorSpaceRef on the Chromium canaries. This is a proactive
fix for the same problem in sRGBColorSpaceRef().
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::sRGBColorSpaceRef):
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
- 11:42 AM Changeset in webkit [54501] by
-
- 2 edits in trunk/WebKitTools
[Qt] Make overridePreference complain when it does not
support the preference given.
Reviewed by Tor Arne Vestbø.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::overridePreference):
- 11:40 AM Changeset in webkit [54500] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.21
Tagging 1.1.21.
- 11:32 AM Changeset in webkit [54499] by
-
- 8 edits in trunk/WebCore
2010-02-08 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Unify the WorkerContext V8 object wrapping code with
the standard V8 object wrapping code.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
- bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::handleEvent): (WebCore::V8WorkerContextEventListener::getReceiverObject):
- bindings/v8/WorkerContextExecutionProxy.cpp:
- bindings/v8/WorkerContextExecutionProxy.h:
- bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::V8NotificationCenter::createHTMLNotificationCallback): (WebCore::V8NotificationCenter::createNotificationCallback):
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::toV8):
- 11:18 AM Changeset in webkit [54498] by
-
- 4 edits in trunk
2010-02-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Bump version to 1.1.21, and adjust library versioning accordingly.
- configure.ac:
- 10:54 AM Changeset in webkit [54497] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
Build fix, add needed export
- 10:30 AM Changeset in webkit [54496] by
-
- 2 edits in trunk/WebKitTools
[Qt] Set stdout/stderr to binary mode for DRT on Windows
Reviewed by Kenneth Rohde Christiansen.
This makes sure we don't end up with lots of CRLFs in the
DRT output, which breaks tons of results. Matches what
the Windows DRT does.
- DumpRenderTree/qt/main.cpp:
- 10:21 AM Changeset in webkit [54495] by
-
- 8 edits in trunk/WebCore
2010-02-08 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Use fastStrDup instead of strdup
https://bugs.webkit.org/show_bug.cgi?id=33943
Replace strdup/free with fastStrDup/fastFree.
- bridge/IdentifierRep.h: (WebCore::IdentifierRep::IdentifierRep):
- bridge/jni/JNIBridge.cpp: (JavaMethod::~JavaMethod): (appendClassName): (JavaMethod::signature):
- bridge/jni/jsc/JavaClassJSC.cpp: (JavaClass::JavaClass): (JavaClass::~JavaClass):
- platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::~ResourceHandleManager): (WebCore::ResourceHandleManager::setCookieJarFileName): (WebCore::ResourceHandleManager::initializeHandle):
- plugins/PluginStream.cpp: (WebCore::PluginStream::~PluginStream): (WebCore::PluginStream::startStream):
- xml/XSLTProcessorLibxslt.cpp: (WebCore::xsltParamArrayFromParameterMap): (WebCore::freeXsltParamArray):
- 10:20 AM Changeset in webkit [54494] by
-
- 2 edits in trunk/WebKit/win
Include header position in World Transform used for plugin positioning.
https://bugs.webkit.org/show_bug.cgi?id=34709
Reviewed by Adam Roben.
- WebFrame.cpp:
(WebFrame::spoolPage): Correct WinCairo plugin print positioning to
account for header size. Existing code ignored this, causing
plugins to overlay other elements.
- 9:37 AM Changeset in webkit [54493] by
-
- 3 edits in trunk/WebKitTools
Build fix for Qt on Windows.
Reviewed by Kenneth Rohde Christiansen.
Don't use noreturn directly since it's a gcc attribute.
Instead use the NO_RETURN macro from AlwaysInline.h
- QtLauncher/QtLauncher.pro:
- QtLauncher/utils.h:
- 9:33 AM Changeset in webkit [54492] by
-
- 2 edits in trunk/LayoutTests
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fix last problematic SVG testcase, update coords-trans-01-b.svg win results, marking the end of the baseline regeneration for all platforms.
- platform/win/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
- 8:09 AM Changeset in webkit [54491] by
-
- 4 edits in trunk/LayoutTests
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Should turn Qt slave green again, all platform specific results updated.
- platform/qt/svg/filters/subRegion-one-effect-expected.txt:
- platform/qt/svg/filters/subRegion-two-effects-expected.txt:
- platform/qt/svg/text/selection-background-color-expected.txt:
- 8:06 AM Changeset in webkit [54490] by
-
- 2 edits1 move in trunk/WebCore
Fix Qt build on Windows.
Reviewed by Simon Hausmann.
nmake fails to pick the right cpp file, so we have to
rename the file to to a unique name.
- WebCore.pro:
- platform/graphics/qt/FontCustomPlatformDataQt.cpp: Renamed from WebCore/platform/graphics/qt/FontCustomPlatformData.cpp.
- 8:01 AM Changeset in webkit [54489] by
-
- 17 edits in trunk/LayoutTests
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Hopefully the last set of updates for Gtk/Qt/Win/Mac.
- platform/gtk/svg/custom/text-zoom-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
- platform/qt/svg/filters/feComposite-expected.txt:
- platform/qt/svg/filters/feGaussianBlur-expected.txt:
- platform/qt/svg/filters/feMerge-expected.txt:
- platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
- platform/qt/svg/filters/feOffset-expected.txt:
- platform/qt/svg/filters/feTile-expected.txt:
- platform/qt/svg/filters/filter-source-position-expected.txt:
- platform/qt/svg/filters/shadow-on-filter-expected.txt:
- platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
- platform/qt/svg/filters/sourceAlpha-expected.txt:
- platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
- platform/win/svg/custom/inline-svg-in-xhtml-expected.txt:
- platform/win/svg/hixie/mixed/003-expected.txt:
- 7:57 AM Changeset in webkit [54488] by
-
- 3 edits in trunk/WebKitTools
Notify user that run-webkit-tests has to be run under Cygwin
Reviewed by Simon Hausmann.
The script will bail out if run under Windows shell or Msys.
- Scripts/run-webkit-tests:
- Scripts/webkitdirs.pm:
- 7:39 AM Changeset in webkit [54487] by
-
- 6 edits in trunk/LayoutTests
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Attempt to fix all mac/win bots (expect for leopard which already passes)
- platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
- platform/mac/svg/custom/junk-data-expected.txt:
- platform/mac/svg/custom/missing-xlink-expected.txt:
- platform/mac/svg/hixie/error/012-expected.txt:
- platform/mac/svg/text/text-intro-05-t-expected.txt:
- 7:09 AM Changeset in webkit [54486] by
-
- 13 edits in trunk/LayoutTests
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Next set of Qt DRT result updates.
- platform/qt/svg/custom/js-update-image-and-display-expected.txt:
- platform/qt/svg/custom/js-update-image-and-display3-expected.txt:
- platform/qt/svg/custom/marker-opacity-expected.txt:
- platform/qt/svg/custom/marker-referencePoint-expected.txt:
- platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt:
- platform/qt/svg/custom/mask-with-default-value-expected.txt:
- platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
- platform/qt/svg/custom/relative-sized-shadow-tree-content-expected.txt:
- platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
- platform/qt/svg/custom/text-xy-updates-SVGList-expected.txt:
- platform/qt/svg/custom/transformedMaskFails-expected.txt:
- platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- 7:04 AM Changeset in webkit [54485] by
-
- 6 edits in trunk/LayoutTests
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Update mac-tiger specific SVG results.
- platform/mac-tiger/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
- platform/mac-tiger/svg/hixie/text/003-expected.txt:
- platform/mac-tiger/svg/hixie/text/003a-expected.txt:
- platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
- platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
- 6:59 AM Changeset in webkit [54484] by
-
- 11 edits4 adds in trunk/LayoutTests
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fixing first set of platform specific SVG results for the Qt port.
Unfortunately the bots exit after 20 test failures, so I can't fix the whole set of expected txt files in one go :(
- platform/qt/svg/css/arrow-with-shadow-expected.txt:
- platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
- platform/qt/svg/css/clippath-with-shadow-expected.txt:
- platform/qt/svg/css/mask-with-shadow-expected.txt:
- platform/qt/svg/css/path-with-shadow-expected.txt:
- platform/qt/svg/css/shadow-and-opacity-expected.txt: Added.
- platform/qt/svg/css/shadow-with-large-radius-expected.txt: Added.
- platform/qt/svg/css/shadow-with-negative-offset-expected.txt: Added.
- platform/qt/svg/css/stars-with-shadow-expected.txt:
- platform/qt/svg/custom/createImageElement-expected.txt:
- platform/qt/svg/custom/createImageElement2-expected.txt:
- platform/qt/svg/custom/empty-mask-expected.txt:
- platform/qt/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt: Added.
- platform/qt/svg/custom/js-update-image-and-display2-expected.txt:
- 6:26 AM Changeset in webkit [54483] by
-
- 747 edits in trunk
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
All SVG *-expected.txt files contain wrong results
https://bugs.webkit.org/show_bug.cgi?id=34703
Finally dump meaningful information for SVG layout tests.
Use 'absoluteClippedOverflowRect' which goes through the same code paths used
to actually calculate repaint rects etc - instead of the legacy CSS-unaware
code path that mapped 'repaintRectInLocalCoordinates' through 'absoluteTransform'.
Remove absoluteTransform() - a long standing TODO, finally not needed anymore.
Despite SVGRenderTreeAsText, SVGPaintServerGradient was also using absoluteTransform().
Rewrite the code in question, fixing svg/W3C-SVG-1.1/pserver-grad-08-b.svg alignment issues
when scaling/panning text using gradient on stroke/fill. Affects some other gradient tests as well.
As we're now dumping clipped overflow rects any problems with repaint rects will become
immediate visible - it turns out we're not supporting the overflow rules on the outermost <svg>
element properly (repaint rects and bounding boxes need to take special SVG overflow rules into account).
Fixing that magically gives pixel-perfect clipped overflow rects for all types of shapes/text/containers.
Note: This will break any overriden platform-specific SVG results, need to wait for build bots in order to update them.
- rendering/RenderObject.cpp: Remove absoluteTransform() method, centralize overflow query code in SVGRenderSupport::isOverflowHidden().
- rendering/RenderObject.h: Remove absoluteTransform() method.
- rendering/RenderSVGHiddenContainer.h: Ditto.
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode. (WebCore::RenderSVGRoot::computeRectForRepaint): Respect SVG overflow rules here: clip repaintRect against overflow rect _before_ passing
along to RenderBox. This is the key issue behind wrong absoluteClippedOverflowRect() values.
(WebCore::RenderSVGRoot::nodeAtPoint): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode.
- rendering/RenderSVGRoot.h: Remove absoluteTransform(). Don't expose viewportSize() anymore.
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox): Fix default stroke width to 1. This was the only wrong place -> fixes repaint rects for stroked text.
- rendering/RenderSVGViewportContainer.cpp: Remove absoluteTransform() method. (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode.
- rendering/RenderSVGViewportContainer.h: Remove absoluteTransform() method.
- rendering/SVGRenderSupport.cpp: Refactored overflow queries in one place, centralizing SVG specific assumptions about overflowX/Y. (WebCore::SVGRenderBase::isOverflowHidden):
- rendering/SVGRenderSupport.h:
- rendering/SVGRenderTreeAsText.cpp: Dump absoluteClippedOverflowRect() instead of absoluteTransform().mapRect(repaintRectInLocalCoordinates()). (WebCore::writePositionAndStyle): Affects all layout tests dumping render trees.
- svg/graphics/SVGPaintServerGradient.cpp: Rewrite Gradient on text fill/stroke support on Cg, to avoid using absoluteTransform(). (WebCore::absoluteTransformForRenderer): (WebCore::createMaskAndSwapContextForTextGradient): (WebCore::clipToTextMask): (WebCore::SVGPaintServerGradient::setup):
- 5:26 AM Changeset in webkit [54482] by
-
- 7 edits in trunk/WebKitTools
Suppressed check-webkit-style's underscore check in Qt's autotests.
Also made the path-specific filter check case-insensitive.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=34574
- Scripts/webkitpy/style/checker.py:
- Added a list element to _PATH_RULES_SPECIFIER for directories that should be excluded from the "readability/naming" category (the category that relates to underscores in identifiers, for example).
- Scripts/webkitpy/style/checker_unittest.py:
- Added an "end-to-end" test for "WebKit/qt/tests/".
- Scripts/webkitpy/style/filter.py:
- Altered FilterConfiguration's should_check() method to check for path substring matches case-insensitively.
- Scripts/webkitpy/style/filter_unittest.py:
- Added a test to check case-insensitive path substring matching.
- Scripts/webkitpy/style/processors/cpp.py:
- Removed the hard-coded "WebKit/gtk/webkit/" path reference since this is now taken care of by the _PATH_RULES_SPECIFIER configuration variable.
- Scripts/webkitpy/style/processors/cpp_unittest.py:
- Removed the unit test for the GTK directory since this is now taken care of by the checker._PATH_RULES_SPECIFIER end-to-end tests.
- 5:21 AM Changeset in webkit [54481] by
-
- 2 edits in trunk/JavaScriptCore
Build fix for make distcheck.
- 5:06 AM Changeset in webkit [54480] by
-
- 2 edits in trunk/LayoutTests
2010-02-08 Xan Lopez <xlopez@igalia.com>
Try to do some clean-up in our Skipped list.
- platform/gtk/Skipped:
- 4:47 AM Changeset in webkit [54479] by
-
- 2 edits in trunk/LayoutTests
2010-02-08 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Generate new results for this test.
- platform/gtk/editing/execCommand/indent-paragraphs-expected.txt:
- 3:04 AM Changeset in webkit [54478] by
-
- 2 edits1 add1 delete in trunk/LayoutTests
2010-02-08 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
Convert editing/execCommand/indent-paragraphs.html to use dumpAsText.
The test copies HTML to the text output, so it doesn't really need
to dump the render tree.
The test was added in r49985, but didn't include pixel results.
https://bugs.webkit.org/show_bug.cgi?id=34625
- platform/mac/editing/execCommand/indent-paragraphs-expected.txt: Modified.
- 2:48 AM Changeset in webkit [54477] by
-
- 2 edits in trunk/WebKitTools
2010-02-08 Leith Bade <leith@leithalweapon.geek.nz>
Reviewed by Darin Adler.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=34637
Corrects the newline inserted into WebKitOutputDir, and WebKitLibrariesDir Windows
environemnt variables when there is a space in the user's /home path.
- Scripts/webkitdirs.pm:
- Added missing quotes around $sourceDir in argument list of cygpath in determineWindowsSourceDir().
- 1:33 AM Changeset in webkit [54476] by
-
- 2 edits in trunk/JavaScriptCore
Unreviewed RVCT build fix.
Similar to r54391, don't import the cmath functions from std:: for RVCT.
- wtf/MathExtras.h:
Feb 7, 2010:
- 4:42 PM Changeset in webkit [54475] by
-
- 5 edits in trunk/LayoutTests
2010-02-07 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
Fix 2 pixel test baselines that are incorrect but passing
the fuzzy image diff.
editing/deleting/5390681.html should show a cursor, but doesn't.
In r42549, whitespace collapsing was changed but
editing/pasteboard/5387578.html's result wasn't updated to
reflect the collapsed whitespace.
https://bugs.webkit.org/show_bug.cgi?id=34632
- platform/mac/editing/deleting/5390681-2-expected.checksum:
- platform/mac/editing/deleting/5390681-2-expected.png:
- platform/mac/editing/pasteboard/5387578-expected.checksum:
- platform/mac/editing/pasteboard/5387578-expected.png:
- 2:26 PM Changeset in webkit [54474] by
-
- 1 edit1 add in trunk/LayoutTests
2010-02-07 Daniel Bates <dbates@webkit.org>
Unreviewed, fix Tiger layout test failure.
Adds expected layout test results for Tiger build.
- platform/mac-tiger/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
- 1:43 PM Changeset in webkit [54473] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-02-07 Daniel Bates <dbates@webkit.org>
Unreviewed, fix layout test bots.
Adds expected layout test results for Leopard, Windows, and Qt ports.
- platform/mac-leopard/fast/lists: Added.
- platform/mac-leopard/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
- platform/qt/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
- platform/win/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
- 1:08 PM Changeset in webkit [54472] by
-
- 9 edits2 adds in trunk
2010-02-07 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
Implements all of the numeric CSS3 list-style-types as per
section 4.3 of the CSS3 Lists module <http://www.w3.org/TR/css3-lists/#numeric>.
Test: fast/lists/w3-css3-list-styles-numeric.html
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSValueKeywords.in:
- inspector/front-end/SourceCSSTokenizer.re2js:
- platform/text/CharacterNames.h: Added constant hyphenMinus.
- rendering/RenderListMarker.cpp: (WebCore::): Defined enum SequenceType. (WebCore::toAlphabeticOrNumeric): Added. (WebCore::toAlphabetic): Modified to call WebCore::toAlphabeticOrNumeric. (WebCore::toNumeric): Added. (WebCore::listMarkerSuffix): (WebCore::listMarkerText): (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcPrefWidths): (WebCore::RenderListMarker::getRelativeMarkerRect):
- rendering/style/RenderStyle.h: (WebCore::):
- rendering/style/RenderStyleConstants.h: Added numeric list style types and fixed indent level for the enum values. (WebCore::):
2010-02-07 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
Tests that all of the numeric CSS3 list-style-types are supported.
- fast/lists/w3-css3-list-styles-numeric.html: Added.
- platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
- 12:47 PM Changeset in webkit [54471] by
-
- 2 edits in trunk/WebCore
2010-02-07 Ismail Donmez <ismail@namtrac.org>
Reviewed by Darin Adler.
Include wtf/StringExtras.h for strdup definition, which
is needed for WinCE.
- bridge/IdentifierRep.h:
- 4:52 AM Changeset in webkit [54470] by
-
- 6 edits in trunk
2010-02-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Fragment-held Elements Not Shown in Inspector.
- inspector/console-dirxml-expected.txt:
- inspector/console-dirxml.html:
2010-02-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Fragment-held Elements Not Shown in Inspector.
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::buildObjectForNode):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
- 4:35 AM Changeset in webkit [54469] by
-
- 7 edits in trunk
2010-02-07 Jian Li <jianli@chromium.org>
Reviewed by Darin Fisher.
[chromium] Change chromium interface to handle DownloadURL format.
https://bugs.webkit.org/show_bug.cgi?id=34655
- platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::clear): (WebCore::ChromiumDataObject::hasData): (WebCore::ChromiumDataObject::ChromiumDataObject):
- platform/chromium/ChromiumDataObject.h:
- platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::setData):
2010-02-07 Jian Li <jianli@chromium.org>
Reviewed by Darin Fisher.
[chromium] Change chromium interface to handle DownloadURL format.
https://bugs.webkit.org/show_bug.cgi?id=34655
- public/WebDragData.h:
- src/WebDragData.cpp: (WebKit::WebDragData::downloadMetadata): (WebKit::WebDragData::setDownloadMetadata):
- 3:42 AM Changeset in webkit [54468] by
-
- 2 edits2 adds in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] Missing fast/frames/flattening/resources/frameset-flattening-subframe-resize.html
https://bugs.webkit.org/show_bug.cgi?id=34662
Missing file added from the original bug: https://bugs.webkit.org/show_bug.cgi?id=32717
- fast/frames/flattening/resources: Added.
- fast/frames/flattening/resources/frameset-flattening-subframe-resize.html: Added.
- platform/qt/Skipped: frameset-flattening-subframe-resize.html unskipped.
- 3:28 AM Changeset in webkit [54467] by
-
- 211 moves in tags/old
Move aside some old tags.
Feb 6, 2010:
- 12:18 PM Changeset in webkit [54466] by
-
- 7 edits in trunk
2010-02-06 Dimitri Glazkov <Dimitri Glazkov>
No review, rolling out r54364.
http://trac.webkit.org/changeset/54364
https://bugs.webkit.org/show_bug.cgi?id=34464
Introduced asserts in layout tests, needs more testing
locally.
- accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification):
- page/chromium/ChromeClientChromium.h:
2010-02-06 Dimitri Glazkov <Dimitri Glazkov>
No review, rolling out r54364.
http://trac.webkit.org/changeset/54364
https://bugs.webkit.org/show_bug.cgi?id=34464
Introduced asserts in layout tests, needs more testing
locally.
- public/WebViewClient.h:
- src/ChromeClientImpl.cpp:
- src/ChromeClientImpl.h:
- 11:02 AM Changeset in webkit [54465] by
-
- 3 edits in trunk/WebCore
2010-02-06 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
Using inlines and function-level statics don't mix, according to gcc.
https://bugs.webkit.org/show_bug.cgi?id=34663
De-inline deviceRGBColorSpaceRef to avoid gcc-bug landmines.
It appears that the initialization check, generated by gcc doesn't account
for a possibility that the function may be inlined, resulting in lazy
initialization failure for more than one inlined instance of the function.
No behavior change, so no new tests.
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::deviceRGBColorSpaceRef):
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
- 12:55 AM Changeset in webkit [54464] by
-
- 15 edits in trunk/JavaScriptCore
Change UStringImpl::create to CRASH if the string cannot be allocated,
rather than returning a null string (which will behave like a zero-length
string if used).
Reviewed by Geoff Garen.
Also move createRep function from UString to become new overloaded
UStringImpl::create methods. In doing so, bring their behaviour closer to
being in line with WebCore::StringImpl, in removing the behaviour that they
can be used to produce null UStrings (ASSERT the char* provided is non-null).
This behaviour of converting null C-strings to null UStrings is inefficient
(cmompared to just using UString::null()), incompatible with WebCore::StringImpl's
behaviour, and may generate unexpected behaviour, since in many cases a null
UString can be used like an empty string.
With these changes UStringImpl need not have a concept of null impls, we can
start transitioning this to become an implementation detail of UString, that
internally it chooses to use a null-object rather than an actually zero impl
pointer.
- JavaScriptCore.exp:
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::calculatedFunctionName):
- parser/Parser.cpp:
(JSC::Parser::parse):
- profiler/Profile.cpp:
(JSC::Profile::Profile):
- profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::stopProfiling):
- runtime/Error.cpp:
(JSC::Error::create):
(JSC::throwError):
- runtime/ExceptionHelpers.cpp:
(JSC::createError):
- runtime/Identifier.cpp:
(JSC::Identifier::add):
- runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
- runtime/UString.cpp:
(JSC::initializeUString):
(JSC::UString::UString):
(JSC::UString::operator=):
- runtime/UString.h:
(JSC::UString::isNull):
(JSC::UString::null):
(JSC::UString::rep):
(JSC::UString::UString):
- runtime/UStringImpl.cpp:
(JSC::UStringImpl::create):
- runtime/UStringImpl.h:
Feb 5, 2010:
- 10:32 PM Changeset in webkit [54463] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=34670
TestNetscapePlugin should work with Firefox
- DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): Default to Carbon if browser doesn't tell what it supports.
- 10:17 PM Changeset in webkit [54462] by
-
- 10 edits in branches/safari-532-branch
JavaScriptCore: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch
Reviewed by Mark Rowe.
- Configurations/FeatureDefines.xcconfig:
WebCore: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch
Reviewed by Mark Rowe.
- Configurations/FeatureDefines.xcconfig:
WebKit/mac: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch
Reviewed by Mark Rowe.
- Configurations/FeatureDefines.xcconfig:
WebKitLibraries: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch
Reviewed by Mark Rowe.
- win/tools/vsprops/FeatureDefines.vsprops:
WebKitTools: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch
Reviewed by Mark Rowe.
- Scripts/build-webkit:
- 9:37 PM Changeset in webkit [54461] by
-
- 7 edits in trunk
2010-02-05 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Gustavo Noronha Silva.
[Gtk] Implement layoutTestController.pageNumberForElementById
https://bugs.webkit.org/show_bug.cgi?id=34572
- platform/gtk/Skipped:
2010-02-05 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Gustavo Noronha Silva.
[Gtk] Implement layoutTestController.pageNumberForElementById
https://bugs.webkit.org/show_bug.cgi?id=34572
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp: (webkit_web_frame_page_number_for_element_by_id):
2010-02-05 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Gustavo Noronha Silva.
[Gtk] Implement layoutTestController.pageNumberForElementById
https://bugs.webkit.org/show_bug.cgi?id=34572
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pageNumberForElementById):
- 8:25 PM Changeset in webkit [54460] by
-
- 3 edits in trunk/WebCore
Added an ASSERT to catch an implausible but theoretically possible leak.
Reviewed by Dan Bernstein.
In theory, if malloc allocated a UChar buffer directly after a StringImpl,
the StringImpl might incorrecly assume that the UChar buffer was inline,
and fail to delete it.
This ASSERT is somewhat academic, since we don't use the same allocator
in debug builds, but oh well.
- platform/text/StringImpl.cpp:
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::createUninitialized):
- platform/text/StringImpl.h: Separated the inline buffer StringImpl
constructor from the out-of-line buffer StringImpl constructor. Made
the former ASSERT that its buffer was indeed inline, and the latter ASSERT
that its buffer was indeed not inline.
- 6:50 PM Changeset in webkit [54459] by
-
- 1 edit1 delete in trunk/LayoutTests
Removed these special Windows expected results because they represented
incorrect behavior, fixed by a recent patch of mine.
Reviewed by Beth Dakin.
- platform/win/fast/events/mouse-drag-from-frame-to-other-frame-expected.txt: Removed.
- 6:44 PM Changeset in webkit [54458] by
-
- 6 edits in trunk/WebKit/chromium
2010-02-05 James Hawkins <jhawkins@chromium.org>
Reviewed by David Levin.
[Chromium] Rename autocomplete* to suggestions* to prepare for the
refactoring of AutocompletePopupMenuClient.
- public/WebView.h:
- src/AutocompletePopupMenuClient.cpp: (WebKit::AutocompletePopupMenuClient::popupDidHide):
- src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::textFieldDidEndEditing): (WebKit::EditorClientImpl::doAutofill):
- src/WebViewImpl.cpp: (WebKit::): (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::autocompleteHandleKeyEvent): (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::applyAutofillSuggestions): (WebKit::WebViewImpl::hideAutofillPopup): (WebKit::WebViewImpl::hideSuggestionsPopup): (WebKit::WebViewImpl::refreshSuggestionsPopup):
- src/WebViewImpl.h: (WebKit::WebViewImpl::suggestionsPopupDidHide):
- 6:28 PM Changeset in webkit [54457] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-05 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Define SYSTEM_MALLOC 1
https://bugs.webkit.org/show_bug.cgi?id=34640
Make BREWMP use system malloc because FastMalloc is not ported.
- wtf/Platform.h:
- 5:30 PM Changeset in webkit [54456] by
-
- 3 edits in trunk/LayoutTests
2010-02-05 Eric Carlson <eric.carlson@apple.com>
Unreviewed revert of r54454, until I can generate new results
- media/video-loop-expected.txt:
- media/video-loop.html:
- 5:10 PM Changeset in webkit [54455] by
-
- 4 edits in trunk/WebCore
Fixed changed virtual function in GraphicsLayerCACF and call order issues
https://bugs.webkit.org/show_bug.cgi?id=34348
The correct virtual function in GraphicsLayerCACF is now being
called. We also fixed an issue in QTMovieWin where the size
of the movie was not being set correctly because the call order
was changed.
I also changed the order of a couple of calls in QTMovieWin to account
for changed calling order from the logic above.
- 4:49 PM Changeset in webkit [54454] by
-
- 3 edits in trunk/LayoutTests
2010-02-05 Eric Carlson <eric.carlson@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=33671
[GTK] media/video-loop.html fails intermittently on Gtk Bots
Rewrite test to make it less timing dependent.
- media/video-loop-expected.txt:
- media/video-loop.html:
- 4:41 PM Changeset in webkit [54453] by
-
- 1 move in branches/old/WWDC-2009-branch
Move aside another old branch.
- 4:41 PM Changeset in webkit [54452] by
-
- 2 edits3 adds in trunk/WebKitTools
2010-02-03 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Add a simple test implementation and the WebKit Mac implementation
for the layout_tests/port package. Also add a simple test driver of
that interface.
- Scripts/webkitpy/layout_tests/driver_test.py: Added.
- Scripts/webkitpy/layout_tests/port/init.py:
- Scripts/webkitpy/layout_tests/port/mac.py: Added.
- Scripts/webkitpy/layout_tests/port/test.py: Added.
- 4:40 PM Changeset in webkit [54451] by
-
- 5 moves in branches/old
Move aside some old branches.
- 4:29 PM Changeset in webkit [54450] by
-
- 1 copy in branches/safari-532-branch
New branch.
- 4:01 PM Changeset in webkit [54449] by
-
- 22 edits2 adds1 delete in trunk/WebKitTools
2010-02-03 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Siedel.
Refactor the port package into an object-oriented style and merge
path_utils into it. We add a 'base' and a 'chromium' object to the
port package; this will allow us to easily add new ports (like
WebKit Mac).
- Scripts/rebaseline-chromium-webkit-tests:
- Scripts/run-chromium-webkit-tests:
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
- Scripts/webkitpy/layout_tests/layout_package/test_files.py:
- Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
- Scripts/webkitpy/layout_tests/port/init.py:
- Scripts/webkitpy/layout_tests/port/apache_http_server.py:
- Scripts/webkitpy/layout_tests/port/base.py: Added.
- Scripts/webkitpy/layout_tests/port/chromium.py: Added.
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/http_server.py:
- Scripts/webkitpy/layout_tests/port/http_server_base.py:
- Scripts/webkitpy/layout_tests/port/path_utils.py: Removed.
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
- Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
- Scripts/webkitpy/layout_tests/test_types/image_diff.py:
- Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
- Scripts/webkitpy/layout_tests/test_types/text_diff.py:
- 3:11 PM Changeset in webkit [54448] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-05 James Hawkins <jhawkins@chromium.org>
Reviewed by David Levin.
[Chromium] Remove an unused forward declaration in WebKitClient.h.
- public/WebKitClient.h:
- 2:53 PM Changeset in webkit [54447] by
-
- 5 edits in trunk/WebKit/mac
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=34661
<rdar://problem/7614067> REGRESSION (Safari 4.0-> Safari 4.0.4): NPP_SetWindow no longer sets a clipRect of (0,0,0,0) when it becomes hidden
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView updateAndSetWindow]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
- Plugins/WebBaseNetscapePluginView.h: Moved superviewsHaveSuperviews to the base class.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView superviewsHaveSuperviews]): Added to the base class; extracted from WebNetscapePluginView. (-[WebBaseNetscapePluginView shouldClipOutPlugin]): Added new method with code extracted from WebNetscapePluginView.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
- 2:40 PM Changeset in webkit [54446] by
-
- 2 edits2 adds in trunk/WebCore
Horizontal scrollbar works in reverse at milliondollarcu.be
<rdar://problem/7556121>
https://bugs.webkit.org/show_bug.cgi?id=33848
Reviewed by Simon Fraser.
Added a manual test.
- manual-tests/win: Added.
- manual-tests/win/horizontal-scroll-composited.html: Added.
- platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::setScrollFrame):
(WebCore::WKCACFLayerRenderer::setRootChildLayer):
- 2:24 PM Changeset in webkit [54445] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] Missing fast/frames/flattening/resources/frameset-flattening-subframe-resize.html
https://bugs.webkit.org/show_bug.cgi?id=34662
- platform/qt/Skipped: fast/frames/flattening/frameset-flattening-subframe-resize.html skipped until fix.
- 2:04 PM Changeset in webkit [54444] by
-
- 3 edits in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
Update expected results after r54441 to make buildbot happy.
- platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Updated.
- platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Updated.
- 1:58 PM Changeset in webkit [54443] by
-
- 3 edits in trunk/WebKit/chromium
2010-02-05 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
Implement WebInputElement::isActivatedSubmit().
- public/WebInputElement.h:
- src/WebInputElement.cpp: (WebKit::WebInputElement::isActivatedSubmit):
- 1:37 PM Changeset in webkit [54442] by
-
- 1 edit1 add in trunk/WebCore
2010-02-05 Ryan Leavengood <leavengood@gmail.com>
Reviewed by David Levin.
Implementation of GlyphPage::fill() for Haiku port.
https://bugs.webkit.org/show_bug.cgi?id=34527
Covered by existing tests.
- platform/graphics/haiku/GlyphPageTreeNodeHaiku.cpp
- 1:21 PM Changeset in webkit [54441] by
-
- 1 edit6 adds in trunk/LayoutTests
Unreviewed, missed in earlier commit.
Add expected frame flattening results for Qt.
- platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
- platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
- platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
- platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Added.
- platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.
- 12:47 PM Changeset in webkit [54440] by
-
- 18 edits6 adds in trunk
Implement flattening of framesets
https://bugs.webkit.org/show_bug.cgi?id=32717
Reviewed by Dave Hyatt.
WebCore:
The following patch, builds ontop of Antti Koivisto's frameset
flattening code from the iPhone source, which itself is based on
the old Nokia Series 60 source.
Layout tests have been added to test the functionality and the original
code which has then been fixed to make these pass, as well as support
frameset grids.
Tests: fast/frames/flattening/frameset-flattening-advanced.html
fast/frames/flattening/frameset-flattening-grid.html
fast/frames/flattening/frameset-flattening-simple.html
fast/frames/flattening/frameset-flattening-subframe-resize.html
fast/frames/flattening/frameset-flattening-subframesets.html
- page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleRelayout):
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setFrameSetFlatteningEnabled):
- page/Settings.h:
(WebCore::Settings::frameSetFlatteningEnabled):
- rendering/RenderFrame.cpp:
(WebCore::RenderFrame::layoutWithFlattening):
- rendering/RenderFrame.h:
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layout):
(WebCore::RenderFrameSet::positionFramesWithFlattening):
(WebCore::RenderFrameSet::flattenFrameSet):
(WebCore::RenderFrameSet::userResize):
- rendering/RenderFrameSet.h:
WebKit/qt:
Privately export the setFrameSetFlatteningEnabled setting for
use with the Qt DRT.
- Api/qwebpage.cpp:
(qt_drt_setFrameSetFlatteningEnabled):
(QWebPagePrivate::core):
- Api/qwebpage_p.h:
WebKitTools:
Add support for testing frame flattening with the Qt DRT
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setFrameSetFlatteningEnabled):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
LayoutTests:
Frameset flattening layout test, plus expected result for Qt.
- fast/frames/flattening/frameset-flattening-advanced.html: Added.
- fast/frames/flattening/frameset-flattening-grid.html: Added.
- fast/frames/flattening/frameset-flattening-simple.html: Added.
- fast/frames/flattening/frameset-flattening-subframe-resize.html: Added.
- fast/frames/flattening/frameset-flattening-subframesets.html: Added.
- fast/frames/flattening/resources/frameset-flattening-subframe-resize.html: Added.
- platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
- platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
- platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
- platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Added.
- platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.
- 12:44 PM Changeset in webkit [54439] by
-
- 9 edits in trunk/WebKitTools
Provided a way in check-webkit-style to specify filter rules
on a per file or folder basis, via a configuration variable.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=33684
- Scripts/webkitpy/style/checker.py:
- Added _PATH_RULES_SPECIFIER configuration variable.
- In ProcessorOptions class--
- Changed the CategoryFilter attribute to FilterConfiguration.
- Added path parameter to is_reportable().
- Renamed ArgumentDefaults filter_rules attribute to base_filter_rules.
- Updated ArgumentPrinter class.
- Added filter rule validation to ArgumentParser (instead of in CategoryFilter constructor).
- Scripts/webkitpy/style/checker_unittest.py:
- Updated unit tests as necessary.
- Added unit tests for PATH_RULES_SPECIFIER.
- Scripts/webkitpy/style/error_handlers.py:
- Updated DefaultStyleErrorHandler to use file path when calling is_reportable().
- Scripts/webkitpy/style/error_handlers_unittest.py:
- Updated unit tests as necessary.
- Scripts/webkitpy/style/filter.py:
- Marked CategoryFilter internal with an underscore.
- Removed argument validation from CategoryFilter.
- Added FilterConfiguration class.
- Scripts/webkitpy/style/filter_unittest.py:
- Updated CategoryFilterTest class.
- Added FilterConfigurationTest unit tests.
- Scripts/webkitpy/style/processors/cpp.py:
- Removed _is_test_filename() code.
- Removed hard-coded path checks from check_include_line().
- Scripts/webkitpy/style/processors/cpp_unittest.py:
- Removed three unit tests related to exempted files.
- 11:50 AM Changeset in webkit [54438] by
-
- 7 edits2 adds in trunk
2010-02-05 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Changing display type of parent of input on focus causes input field to not receive key events
https://bugs.webkit.org/show_bug.cgi?id=34620
<rdar://problem/7584572>
When layout affects a text input, the RenderTextControl gets destroyed and
recreated, which in turn makes a new innerTextElement. However, if the text field was
focused, the VisibleSelection is left pointing to the old innerTextElement, so text
input no longer works.
The fix is to call updateFocusAppearanceSoon() when attaching the input element,
which will update the selection if necessary.
Test: fast/forms/restore-selection-after-layout.html
- dom/Document.h: Add a paramter to updateFocusAppearanceSoon() and a member variable, m_updateFocusAppearanceRestoresSelection, to store its value until the timer fires.
- dom/Document.cpp: (WebCore::Document::Document): Initialize m_updateFocusAppearanceRestoresSelection (WebCore::Document::updateFocusAppearanceSoon): New restorePreviousSelection parameter. (WebCore::Document::updateFocusAppearanceTimerFired): Pass m_updateFocusAppearanceRestoresSelection down.
- dom/Element.cpp: (WebCore::Element::attach): Call updateFocusAppearanceSoon() with false.
- dom/Element.h: The updateFocusAppearanceSoonAfterAttach() was undefined.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::attach): Call document()->updateFocusAppearanceSoon() with true.
- 11:46 AM Changeset in webkit [54437] by
-
- 3 edits in trunk/WebKitTools
[Qt] Apply the command line options as settings to the graphics system.
Reviewed by Ariya Hidayat.
- QtLauncher/main.cpp:
(LauncherWindow::LauncherWindow):
(requiresGraphicsView):
(LauncherApplication::handleUserOptions):
- QtLauncher/webview.h:
(WebViewGraphicsBased::setItemCacheMode):
- 11:30 AM Changeset in webkit [54436] by
-
- 7 edits in trunk/WebCore
2010-02-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: simplify cookies view, introduce DataGrid::autoSizeColumns.
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.show): (WebInspector.CookieItemsView.prototype._update): (WebInspector.CookieItemsView.prototype._updateWithCookies): (WebInspector.CookieItemsView.prototype._filterCookiesForDomain): (WebInspector.CookieItemsView.prototype._createDataGrid): (WebInspector.CookieItemsView.prototype._populateDataGrid.expiresCompare): (WebInspector.CookieItemsView.prototype._populateDataGrid): (WebInspector.CookieItemsView.prototype._createSimpleDataGrid): (WebInspector.CookieItemsView.prototype._populateSimpleDataGrid): (WebInspector.CookieItemsView.prototype._deleteCookieCallback): (WebInspector.CookieItemsView.prototype._refreshButtonClicked):
- inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries): (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
- inspector/front-end/DataGrid.js: (WebInspector.DataGrid): (WebInspector.DataGrid.prototype.autoSizeColumns):
- inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._queryFinished):
- inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView.prototype._queryFinished):
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.dataGridForResult):
- 11:22 AM Changeset in webkit [54435] by
-
- 6 edits in trunk/WebCore
2010-02-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: group cookies by frame, show total
cookies size, allow sorting cookie table.
- English.lproj/localizedStrings.js:
- inspector/InspectorController.cpp: (WebCore::InspectorController::deleteCookie):
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype._updateWithCookies): (WebInspector.CookieItemsView.prototype._cookiesForDomain): (WebInspector.CookieItemsView.prototype.dataGridForCookies): (WebInspector.CookieItemsView.prototype._createNodes): (WebInspector.CookieItemsView.prototype._sortData.localeCompare): (WebInspector.CookieItemsView.prototype._sortData.numberCompare): (WebInspector.CookieItemsView.prototype._sortData.expiresCompare): (WebInspector.CookieItemsView.prototype._sortData):
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.showCookies): (WebInspector.CookieSidebarTreeElement): (WebInspector.CookieSidebarTreeElement.prototype.onselect): (WebInspector.CookieSidebarTreeElement.prototype.get subtitle): (WebInspector.CookieSidebarTreeElement.prototype.set subtitle):
- inspector/front-end/inspector.js: (WebInspector.updateResource):
- 11:08 AM Changeset in webkit [54434] by
-
- 2 edits in trunk/WebCore
2010-02-05 Maxime Simone <Maxime Simon>
Reviewed by David Levin.
More robust conversion from BString to String for Haiku port.
https://bugs.webkit.org/show_bug.cgi?id=34527
Covered by existing tests.
- platform/text/haiku/StringHaiku.cpp: Fixed include order, Improved coversion from BString.
- 10:44 AM Changeset in webkit [54433] by
-
- 2 edits in tags/Safari-533.0.2/WebCore
Merge r54430.
- 10:43 AM Changeset in webkit [54432] by
-
- 4 edits in tags/Safari-533.0.2
Versioning.
- 10:41 AM Changeset in webkit [54431] by
-
- 1 copy in tags/Safari-533.0.2
New tag.
- 10:35 AM Changeset in webkit [54430] by
-
- 2 edits in trunk/WebCore
Windows build fix.
Reviewed by Adam Roben.
- WebCore.vcproj/WebCore.make:
- 10:08 AM Changeset in webkit [54429] by
-
- 32 edits in trunk
Rubber-stamped by Kenneth Rohde Christiansen.
Reviewed by Dirk Schulze.
[Qt] Modifying SVG path dumping to equal to other ports
https://bugs.webkit.org/show_bug.cgi?id=33784
WebCore:
- platform/graphics/qt/PathQt.cpp:
(WebCore::Path::debugString): Path dumping style is aproached to Mac.
LayoutTests:
Expected files updated.
- platform/qt/svg/css/arrow-with-shadow-expected.txt:
- platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
- platform/qt/svg/css/clippath-with-shadow-expected.txt:
- platform/qt/svg/css/mask-with-shadow-expected.txt:
- platform/qt/svg/css/path-with-shadow-expected.txt:
- platform/qt/svg/css/stars-with-shadow-expected.txt:
- platform/qt/svg/custom/empty-mask-expected.txt:
- platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
- platform/qt/svg/custom/marker-opacity-expected.txt:
- platform/qt/svg/custom/marker-referencePoint-expected.txt:
- platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt:
- platform/qt/svg/custom/mask-with-default-value-expected.txt:
- platform/qt/svg/custom/relative-sized-content-expected.txt:
- platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
- platform/qt/svg/custom/relative-sized-shadow-tree-content-expected.txt:
- platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
- platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
- platform/qt/svg/custom/transformedMaskFails-expected.txt:
- platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- platform/qt/svg/filters/feComposite-expected.txt:
- platform/qt/svg/filters/feGaussianBlur-expected.txt:
- platform/qt/svg/filters/feMerge-expected.txt:
- platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
- platform/qt/svg/filters/feOffset-expected.txt:
- platform/qt/svg/filters/feTile-expected.txt:
- platform/qt/svg/filters/shadow-on-filter-expected.txt:
- platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
- platform/qt/svg/filters/subRegion-one-effect-expected.txt:
- platform/qt/svg/filters/subRegion-two-effects-expected.txt:
- 9:46 AM Changeset in webkit [54428] by
-
- 8 edits in trunk
2010-02-05 Kwang Yul Seo <skyul@company100.net>
Reviewed by Alexey Proskuryakov.
Don't call CRASH() in fastMalloc and fastCalloc when the requested memory size is 0
https://bugs.webkit.org/show_bug.cgi?id=34569
With USE_SYSTEM_MALLOC=1, fastMalloc and fastCalloc call CRASH()
if the return value of malloc and calloc is 0.
However, these functions can return 0 when the request size is 0.
Libc manual says, "If size is 0, then malloc() returns either NULL,
or a unique pointer value that can later be successfully passed to free()."
Though malloc returns a unique pointer in most systems,
0 can be returned in some systems. For instance, BREW's MALLOC returns 0
when size is 0.
If malloc or calloc returns 0 due to allocation size, increase the size
to 1 and try again.
- wtf/FastMalloc.cpp: (WTF::fastMalloc): (WTF::fastCalloc):
2010-02-05 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Add a GStreamer HTTP/HTTPS source, using WebKit infrastructure
https://bugs.webkit.org/show_bug.cgi?id=34317
- GNUmakefile.am:
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback): (WebCore::doGstInit):
- platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:
- platform/graphics/gtk/WebKitWebSourceGStreamer.h: Add a GStreamer HTTP/HTTPS source, using the WebKit infrastructure. This makes sure that referer, cookies, authentication information and all kinds of other context are passed to GStreamer for websites like Vimeo or YouTube.
- 9:24 AM Changeset in webkit [54427] by
-
- 5 edits2 adds in trunk
2010-02-05 Sebastian Dröge <sebastian.droege@collabora.co.uk>
Reviewed by Gustavo Noronha.
Add a GStreamer HTTP/HTTPS source, using WebKit infrastructure
https://bugs.webkit.org/show_bug.cgi?id=34317
- GNUmakefile.am:
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback): (WebCore::doGstInit):
- platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:
- platform/graphics/gtk/WebKitWebSourceGStreamer.h: Add a GStreamer HTTP/HTTPS source, using the WebKit infrastructure. This makes sure that referer, cookies, authentication information and all kinds of other context are passed to GStreamer for websites like Vimeo or YouTube.
- 8:41 AM Changeset in webkit [54426] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Fix build on Windows
Reviewed by Kenneth Rohde Christiansen.
DerivedSources for our API headers failed on Windows,
due to Windows not accepting ; as a command separator,
not needing quotes for echo, and needing < and > escaped.
We now detect Windows and set these quote markers and
escape markers accordingly, as well as use && for separating
individual commands.
- Api/DerivedSources.pro:
- 8:28 AM Changeset in webkit [54425] by
-
- 17 edits in trunk
2010-02-05 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Clean up code for getting a v8::FunctionTemplate.
- bindings/scripts/CodeGeneratorV8.pm: Making GetTemplate() public
- bindings/v8/V8Binding.cpp: (WebCore::configureTemplate):
- bindings/v8/V8DOMWrapper.cpp: Remove getTemplate(), use V8ClassIndex::getTemplate() instead. (WebCore::V8DOMWrapper::getConstructor): (WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::lookupDOMWrapper):
- bindings/v8/V8Index.cpp: Remove duplicate caching of FunctionTemplates. (WebCore::V8ClassIndex::getTemplate):
- bindings/v8/V8Index.h:
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::toV8):
- bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::v8HTMLAudioElementConstructorCallback): (WebCore::V8HTMLAudioElementConstructor::GetTemplate):
- bindings/v8/custom/V8HTMLAudioElementConstructor.h:
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::v8HTMLImageElementConstructorCallback): (WebCore::V8HTMLImageElementConstructor::GetTemplate):
- bindings/v8/custom/V8HTMLImageElementConstructor.h:
- bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::v8HTMLOptionElementConstructorCallback): (WebCore::V8HTMLOptionElementConstructor::GetTemplate):
- bindings/v8/custom/V8HTMLOptionElementConstructor.h:
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::createInjectedScriptHostV8Wrapper):
- 8:01 AM Changeset in webkit [54424] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Tor Arne Vestbø.
[Qt] fast/css/dashboard-regions-attr-crash.html skipped,
because ENABLE_DASHBOARD_SUPPORT=0 is the default option.
- platform/qt/Skipped:
- 7:09 AM Changeset in webkit [54423] by
-
- 1 edit1 add in trunk
2010-02-05 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Add .gitattributes file to tell git about files with Windows linefeeds
https://bugs.webkit.org/show_bug.cgi?id=34645
On Windows git defaults to "true" for core.autocrlf, meaning all text
files in the working directory are converted from CRLF to LF on checkin
time. Some files present in the repository have been checked in with
CRLF linefeeds and git should not try to convert them. The added
.gitattributes file tells git to not do any CRLF conversion.
- .gitattributes: Added.
- 6:10 AM Changeset in webkit [54422] by
-
- 2 edits in trunk/WebCore
[Qt] Build break in QtWebkit on Symbian
https://bugs.webkit.org/show_bug.cgi?id=34597
Patch by Siddharth Mathur <siddharth.mathur@nokia.com> on 2010-02-05
Reviewed by Ariya Hidayat.
- plugins/PluginView.h:
- 6:08 AM Changeset in webkit [54421] by
-
- 30 edits in trunk
2010-02-05 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
- Use SerializedScriptValue for passing data between injected script and inspector frontend.
- Remove custom JSON implementation from the instpector utility script.
- Make sure that only objects created in the same ScriptState can be values of ScriptObject/Array properties and arguments to ScriptFunctionCall. We don't want ScriptObjects to leak between contexts.
- Use ScriptState of the 'this' object in ScriptFunctionCall instead of passing it as additional parameter.
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::reportDidDispatchOnInjectedScript):
- bindings/js/ScriptArray.cpp: (WebCore::ScriptArray::set):
- bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::ScriptFunctionCall): (WebCore::ScriptFunctionCall::appendArgument):
- bindings/js/ScriptFunctionCall.h:
- bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::set):
- bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::serialize): (WebCore::ScriptValue::deserialize):
- bindings/js/ScriptValue.h:
- bindings/v8/ScriptArray.cpp: (WebCore::ScriptArray::set):
- bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::ScriptFunctionCall): (WebCore::ScriptFunctionCall::appendArgument):
- bindings/v8/ScriptFunctionCall.h:
- bindings/v8/ScriptObject.cpp: (WebCore::ScriptObject::set):
- bindings/v8/ScriptState.h:
- bindings/v8/ScriptValue.cpp: (WebCore::ScriptValue::serialize): (WebCore::deserialize):
- bindings/v8/ScriptValue.h:
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::reportDidDispatchOnInjectedScriptCallback):
- inspector/InjectedScript.cpp: (WebCore::InjectedScript::dispatch): (WebCore::InjectedScript::callFrames): (WebCore::InjectedScript::wrapForConsole): (WebCore::InjectedScript::releaseWrapperObjectGroup):
- inspector/InjectedScript.h:
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::reportDidDispatchOnInjectedScript):
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptHost.idl:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
- inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::didPause): (WebCore::InspectorController::didEvaluateForTestInFrontend):
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::InspectorFrontend): (WebCore::InspectorFrontend::newScriptArray): (WebCore::InspectorFrontend::newScriptObject): (WebCore::InspectorFrontend::populateFrontendSettings): (WebCore::InspectorFrontend::updateConsoleMessageExpiredCount): (WebCore::InspectorFrontend::addConsoleMessage): (WebCore::InspectorFrontend::updateConsoleMessageRepeatCount): (WebCore::InspectorFrontend::updateResource): (WebCore::InspectorFrontend::removeResource): (WebCore::InspectorFrontend::didGetResourceContent): (WebCore::InspectorFrontend::updateFocusedNode): (WebCore::InspectorFrontend::setAttachedWindow): (WebCore::InspectorFrontend::addRecordToTimeline): (WebCore::InspectorFrontend::parsedScriptSource): (WebCore::InspectorFrontend::failedToParseScriptSource): (WebCore::InspectorFrontend::addProfileHeader): (WebCore::InspectorFrontend::setRecordingProfile): (WebCore::InspectorFrontend::didGetProfileHeaders): (WebCore::InspectorFrontend::didGetProfile): (WebCore::InspectorFrontend::pausedScript): (WebCore::InspectorFrontend::setDocument): (WebCore::InspectorFrontend::setDetachedRoot): (WebCore::InspectorFrontend::setChildNodes): (WebCore::InspectorFrontend::childNodeCountUpdated): (WebCore::InspectorFrontend::childNodeInserted): (WebCore::InspectorFrontend::childNodeRemoved): (WebCore::InspectorFrontend::attributesUpdated): (WebCore::InspectorFrontend::didRemoveNode): (WebCore::InspectorFrontend::didGetChildNodes): (WebCore::InspectorFrontend::didApplyDomChange): (WebCore::InspectorFrontend::didGetEventListenersForNode): (WebCore::InspectorFrontend::didGetCookies): (WebCore::InspectorFrontend::didDispatchOnInjectedScript): (WebCore::InspectorFrontend::addDatabase): (WebCore::InspectorFrontend::selectDatabase): (WebCore::InspectorFrontend::didGetDatabaseTableNames): (WebCore::InspectorFrontend::addDOMStorage): (WebCore::InspectorFrontend::selectDOMStorage): (WebCore::InspectorFrontend::didGetDOMStorageEntries): (WebCore::InspectorFrontend::didSetDOMStorageItem): (WebCore::InspectorFrontend::didRemoveDOMStorageItem): (WebCore::InspectorFrontend::updateDOMStorage): (WebCore::InspectorFrontend::addNodesToSearchResult): (WebCore::InspectorFrontend::contextMenuItemSelected): (WebCore::InspectorFrontend::evaluateForTestInFrontend): (WebCore::InspectorFrontend::callSimpleFunction):
- inspector/InspectorFrontend.h: (WebCore::InspectorFrontend::scriptState):
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
- inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName.myCallback): (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName): (InjectedScriptAccess._installHandler):
- inspector/front-end/inspector.js: (WebInspector.pausedScript): (WebInspector.addConsoleMessage):
2010-02-05 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Remove unused inmport of ScriptFunctionCall.h
- Api/qwebelement.cpp:
- 6:00 AM WebKit Team edited by
- (diff)
- 5:23 AM Changeset in webkit [54420] by
-
- 7 edits1 add1 delete in trunk
[Qt] Generate convenience headers (QWebView, etc) using qmake
Reviewed by Simon Hausmann.
In Qt this is done using syncqt, but we use a pro-file instead
that generates makefile-rules for each of the extra headers.
These extra headers are installed alongside the normal headers.
WebCore:
- WebCore.pro: Use headers.pri based on DerivedSources instead
of the one previously checked in in the source tree.
WebKit/qt:
- Api/DerivedSources.pro: Added. List of headers + pro file magic
- Api/headers.pri: Removed, list of headers is now in the above file
WebKitTools:
- Scripts/webkitdirs.pm: Run qmake and make on new API-DerivedSources
- 4:27 AM Changeset in webkit [54419] by
-
- 2 edits in trunk/JavaScriptCore
Don't call CRASH() in fastMalloc and fastCalloc when the requested memory size is 0
https://bugs.webkit.org/show_bug.cgi?id=34569
Patch by Kwang Yul Seo <skyul@company100.net> on 2010-02-05
Reviewed by Alexey Proskuryakov.
With USE_SYSTEM_MALLOC=1, fastMalloc and fastCalloc call CRASH()
if the return value of malloc and calloc is 0.
However, these functions can return 0 when the request size is 0.
Libc manual says, "If size is 0, then malloc() returns either NULL,
or a unique pointer value that can later be successfully passed to free()."
Though malloc returns a unique pointer in most systems,
0 can be returned in some systems. For instance, BREW's MALLOC returns 0
when size is 0.
If malloc or calloc returns 0 due to allocation size, increase the size
to 1 and try again.
- wtf/FastMalloc.cpp:
(WTF::fastMalloc):
(WTF::fastCalloc):
- 4:20 AM Changeset in webkit [54418] by
-
- 2 edits in trunk/WebKitTools
2010-02-05 Andras Becsi <abecsi@webkit.org>
Unreviewed typo fix.
Fix wrong whitespace alignment introduced in r54342.
- 4:05 AM Changeset in webkit [54417] by
-
- 6 edits in trunk
2010-02-05 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Enable JAVASCRIPT_DEBUGGER in chromium port.
- page/Console.cpp:
- page/Console.h:
- page/Console.idl:
2010-02-05 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Enable JAVASCRIPT_DEBUGGER in chromium port.
- features.gypi:
- 3:45 AM Changeset in webkit [54416] by
-
- 4 edits in trunk/WebKitTools
Rubberstamped by Oliver Hunt.
[Qt] Make it possible to choose whether the launcher should
use the traditional QWidget based QWebView or the newer
QGraphics based QGraphicsWebView on a QGraphicsView.
- QtLauncher/main.cpp:
(LauncherWindow::LauncherWindow):
(LauncherWindow::eventFilter):
(LauncherWindow::loadStarted):
(LauncherWindow::print):
(LauncherWindow::screenshot):
(LauncherWindow::setEditable):
(LauncherWindow::setupUI):
(main):
- QtLauncher/webview.cpp:
(WebViewGraphicsBased::WebViewGraphicsBased):
(WebViewGraphicsBased::resizeEvent):
(GraphicsWebView::mousePressEvent):
(GraphicsWebView::contextMenuEvent):
- QtLauncher/webview.h:
(WebViewTraditional::WebViewTraditional):
(GraphicsWebView::GraphicsWebView):
(WebViewGraphicsBased::setPage):
- 2:50 AM Changeset in webkit [54415] by
-
- 3 edits in trunk/WebCore
2010-02-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Tab width for javascript source is 8, should be 4
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame):
- inspector/front-end/TextEditorModel.js: (WebInspector.TextEditorModel.prototype.set replaceTabsWithSpaces): (WebInspector.TextEditorModel.prototype._innerSetText): (WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded):
- 1:37 AM Changeset in webkit [54414] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-02-05 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
send() should return false, after frame that opened a WebSokcet is detached
https://bugs.webkit.org/show_bug.cgi?id=34630
- websocket/tests/send-after-close-on-unload-expected.txt: Added.
- websocket/tests/send-after-close-on-unload.html: Added.
- 1:23 AM Changeset in webkit [54413] by
-
- 6 edits2 adds in trunk
2010-02-05 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=24872
Add a test to make sure copying from a list and pasting into a list
keeps the list at the same indention level rather than nesting.
- editing/pasteboard/paste-list-002-expected.txt: Added.
- editing/pasteboard/paste-list-002.html: Added.
2010-02-05 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=24872
When pasting a list into another list should not indent another level.
If the cursor is at the beginning of the line, it should insert the
list items before the current list item. If the cursor is at the end
of the line, it should insert the list items after the current list item.
This matches Firefox and IE and makes the common activity of reordering a list
work as expected.
This also adds a small helper method (isListItem) to htmlediting.h.
Test: editing/pasteboard/paste-list-002.html
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::insertAsListItems):
- editing/ReplaceSelectionCommand.h:
- editing/htmlediting.cpp: (WebCore::isListItem): (WebCore::appendedSublist):
- editing/htmlediting.h:
