Timeline
Feb 11, 2010:
- 11:52 PM Changeset in webkit [54706] by
-
- 2 edits in trunk
2010-02-11 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Gustavo Noronha Silva.
Detect properly different versions of libpng out there.
- configure.ac:
- 11:36 PM Changeset in webkit [54705] by
-
- 2 edits in trunk/WebCore
2010-02-11 Ariya Hidayat <ariya.hidayat@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Use clipRegion instead of clipPath to save lots of CPU cycles.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect):
- 11:20 PM Changeset in webkit [54704] by
-
- 2 edits in trunk/WebKitTools
2010-02-11 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Dan Bernstein.
[Mac] Duplicated setXSSAuditorEnabled preference at Mac DRT
https://bugs.webkit.org/show_bug.cgi?id=34798
Remove duplicated setXSSAuditorEnabled preference at Mac DRT
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- 10:42 PM Changeset in webkit [54703] by
-
- 2 edits in trunk/WebCore
2010-02-11 Yuzo Fujishima <yuzo@google.com>
Reviewed by Shinichiro Hamaji.
Rename underscored identifiers in WebCore/css/CSSParser.cpp.
https://bugs.webkit.org/show_bug.cgi?id=34877
Also fix whitespace erros that surface due to the above fix.
This doesn't change the code logic. Hence no new tests are required.
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
- 9:14 PM Changeset in webkit [54702] by
-
- 2 edits in trunk/WebCore
2010-02-11 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: Focusing a resource in the inspector should default to content not header
https://bugs.webkit.org/show_bug.cgi?id=34861
- inspector/front-end/Settings.js: (WebInspector.Settings.prototype._load): changed initial default to content tab
- 9:01 PM Changeset in webkit [54701] by
-
- 3 edits in trunk/JavaScriptCore
2010-02-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt and Darin Adler.
The rest of the fix for
https://bugs.webkit.org/show_bug.cgi?id=34864 | <rdar://problem/7594198>
Many objects left uncollected after visiting mail.google.com and closing
window
Don't unconditionally hang onto small strings. Instead, hang onto all
small strings as long as any small string is still referenced.
SunSpider reports no change.
- runtime/Collector.cpp: (JSC::Heap::markRoots): Mark the small strings cache last, so it can check if anything else has kept any strings alive.
- runtime/SmallStrings.cpp: (JSC::isMarked): (JSC::SmallStrings::markChildren): Only keep our strings alive if some other reference to at least one of them exists, too.
- 8:59 PM Changeset in webkit [54700] by
-
- 2 edits in trunk/WebCore
2010-02-11 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: Editing Styles Cannot Tab Backwards from a New Style Item
https://bugs.webkit.org/show_bug.cgi?id=34872
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.update): triggers afterUpdate (WebInspector.StylePropertiesSection.prototype.afterUpdate): factored out _afterUpdate handling
- 7:51 PM Changeset in webkit [54699] by
-
- 2 edits in trunk/WebCore
2010-02-11 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Eric Seidel.
Add roundedIntSize() convenience method converting FloatSize to IntSize, just like roundedIntPoint() converting FloatPoint to IntPoint.
- platform/graphics/FloatSize.h: (WebCore::roundedIntSize):
- 7:13 PM Changeset in webkit [54698] by
-
- 2 edits in trunk/WebKitTools
2010-02-11 Eric Seidel <eric@webkit.org>
No review, build fix only.
webkitdirs.pm has a crazy amount of duplicated feature detection code
https://bugs.webkit.org/show_bug.cgi?id=34869
- Scripts/build-webkit: Fix typo which broke bots.
- 7:04 PM Changeset in webkit [54697] by
-
- 5 edits1 add4 deletes in trunk
2010-02-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkitdirs.pm has a crazy amount of duplicated feature detection code
https://bugs.webkit.org/show_bug.cgi?id=34869
In editing run-webkit-tests I found these tests were
skipped on all platforms. Removing them since no one is running them.
If we ever need them we can dig them out of SVN history.
- fast/wcss/marquee-dir.xhtml: Removed.
- fast/wcss/marquee-loop.xhtml: Removed.
- fast/wcss/marquee-speed.xhtml: Removed.
- fast/wcss/marquee-style.xhtml: Removed.
2010-02-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkitdirs.pm has a crazy amount of duplicated feature detection code
https://bugs.webkit.org/show_bug.cgi?id=34869
- Scripts/build-webkit: Use the new hotness.
- Scripts/run-webkit-tests: ditto
- Scripts/webkitdirs.pm: Remove a bunch of bad duplicate code.
- Scripts/webkitperl/features.pm: Added.
- Simplified the 10 methods in webkitdirs.pm into 2 exported methods in this new file.
- 6:51 PM Changeset in webkit [54696] by
-
- 4 edits in trunk/JavaScriptCore
2010-02-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin Barraclough.
Some progress toward fixing
https://bugs.webkit.org/show_bug.cgi?id=34864 | <rdar://problem/7594198>
Many objects left uncollected after visiting mail.google.com and closing
window
SunSpider reports no change.
Keep weak references, rather than protected references, to cached for-in
property name enumerators.
One problem with protected references is that a chain like
[ gc object 1 ] => [ non-gc object ] => [ gc object 2 ]
takes two GC passes to break, since the first pass collects [ gc object 1 ],
releasing [ non-gc object ] and unprotecting [ gc object 2 ], and only
then can a second pass collect [ gc object 2 ].
Another problem with protected references is that they can keep a bunch
of strings alive long after they're useful. In SunSpider and a few popular
websites, the size-speed tradeoff seems to favor weak references.
- runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::JSPropertyNameIterator): Moved this constructor into the .cpp file, since it's not used elsewhere.
(JSC::JSPropertyNameIterator::~JSPropertyNameIterator): Added a destructor
to support our weak reference.
- runtime/JSPropertyNameIterator.h: (JSC::Structure::setEnumerationCache): (JSC::Structure::clearEnumerationCache): (JSC::Structure::enumerationCache): Added a function for clearing a Structure's enumeration cache, used by our new destructor. Also fixed indentation to match the rest of the file.
- runtime/Structure.h: Changed from protected pointer to weak pointer.
- 6:37 PM Changeset in webkit [54695] by
-
- 9 edits in trunk
2010-02-11 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix two issues on maxLength.
https://bugs.webkit.org/show_bug.cgi?id=34783
- Add grapheme test cases
- Improve test result readability
- fast/forms/ValidityState-tooLong-input-expected.txt:
- fast/forms/ValidityState-tooLong-textarea-expected.txt:
- fast/forms/script-tests/ValidityState-tooLong-input.js:
- fast/forms/script-tests/ValidityState-tooLong-textarea.js:
2010-02-11 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix two issues on maxLength.
https://bugs.webkit.org/show_bug.cgi?id=34783
- ValidityState.tooLong behavior was inconsistent with UIs of <input> and <textarea>. tooLong checked Unicode code point length though the UIs checks grapheme cluster length.
- Setting HTMLTextAreaElement::value didn't update the dirty flag.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::tooLong): Use numGraphemeClusters() instead of length().
- html/HTMLTextAreaElement.cpp: Rename setValue() to setNonDirtyValue(), and introduce setValue() which calls setNonDirtyValue() and sets the dirty flag. (WebCore::HTMLTextAreaElement::childrenChanged): (WebCore::HTMLTextAreaElement::reset): (WebCore::HTMLTextAreaElement::setValue): (WebCore::HTMLTextAreaElement::setNonDirtyValue): (WebCore::HTMLTextAreaElement::setDefaultValue): (WebCore::HTMLTextAreaElement::tooLong): Use numGraphemeClusters() instead of length().
- html/HTMLTextAreaElement.h:
- 6:12 PM Changeset in webkit [54694] by
-
- 10 edits3 adds in trunk
2010-02-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket bufferedAmount should not be 0 when send after close.
https://bugs.webkit.org/show_bug.cgi?id=34633
- websocket/tests/bufferedAmount-after-close-expected.txt: Added.
- websocket/tests/bufferedAmount-after-close.html: Added.
- websocket/tests/script-tests/bufferedAmount-after-close.js: Added.
2010-02-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket bufferedAmount should not be 0 when send after close.
https://bugs.webkit.org/show_bug.cgi?id=34633
Test: websocket/tests/bufferedAmount-after-close.html
- websockets/ThreadableWebSocketChannelClientWrapper.h: (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
- websockets/WebSocket.cpp: (WebCore::WebSocket::WebSocket): (WebCore::WebSocket::send): (WebCore::WebSocket::close): (WebCore::WebSocket::bufferedAmount): (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didClose):
- websockets/WebSocket.h:
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::send): (WebCore::WebSocketChannel::bufferedAmount): (WebCore::WebSocketChannel::didClose):
- websockets/WebSocketChannel.h:
- websockets/WebSocketChannelClient.h: (WebCore::WebSocketChannelClient::didClose):
- websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::workerContextDidClose): (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
- websockets/WorkerThreadableWebSocketChannel.h:
- 5:59 PM Changeset in webkit [54693] by
-
- 7 edits1 add in trunk/WebKitTools
2010-02-11 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
Makes method User.prompt static and adds the parameter repeat
to prompt the user up to repeat times.
- Scripts/test-webkitpy:
- Scripts/webkitpy/bugzilla.py: Substituted method User.prompt for method raw_input.
- Scripts/webkitpy/commands/upload.py: Ditto
- Scripts/webkitpy/credentials.py: Ditto
- Scripts/mock_bugzillatool.py: Updated prototype of MockUser.prompt to match User.prompt.
- Scripts/webkitpy/user.py: Made method prompt static and added parameter repeat.
- Scripts/webkitpy/user_unittest.py: Added.
- 5:48 PM Changeset in webkit [54692] by
-
- 3 edits6 adds in trunk
2010-02-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket in Worker failed to close
https://bugs.webkit.org/show_bug.cgi?id=34785
- websocket/tests/workers/close-in-shared-worker-expected.txt: Added.
- websocket/tests/workers/close-in-shared-worker.html: Added.
- websocket/tests/workers/close-in-worker-expected.txt: Added.
- websocket/tests/workers/close-in-worker.html: Added.
- websocket/tests/workers/resources/close-in-worker.js: Added.
- websocket/tests/workers/resources/echo_wsh.py: Copied from LayoutTests/websocket/tests/echo_wsh.py.
2010-02-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket in Worker failed to close
https://bugs.webkit.org/show_bug.cgi?id=34785
Tests: websocket/tests/workers/close-in-shared-worker.html
websocket/tests/workers/close-in-worker.html
- websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::close):
- 5:39 PM Changeset in webkit [54691] by
-
- 1 edit37 deletes in trunk/WebKitTools
2010-02-10 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Allow underscored identifiers in CSSParser.cpp
Flex (http://flex.sourceforge.net/) uses identifiers named as yy_*.
WebCore/css/CSSParser.cpp needs to handle some such identifiers.
We should relax the style rule for the file to allow underscored identifiers.
- Scripts/webkitpy/style/checker.py:
- 5:29 PM Changeset in webkit [54690] by
-
- 2 edits in trunk/WebKitTools
2010-02-10 Yuzo Fujishima <yuzo@google.com>
Reviewed by Darin Adler.
Allow underscored identifiers in CSSParser.cpp
Flex (http://flex.sourceforge.net/) uses identifiers named as yy_*.
WebCore/css/CSSParser.cpp needs to handle some such identifiers.
We should relax the style rule for the file to allow underscored identifiers.
- Scripts/webkitpy/style/checker.py:
- 5:01 PM Changeset in webkit [54689] by
-
- 1 edit2 moves in trunk/LayoutTests
2010-02-11 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Oops, move mac-lepard results for mask-invalidation.svg into the correct folder.
- platform/mac-leopard/mask-invalidation-expected.checksum: Removed.
- platform/mac-leopard/mask-invalidation-expected.png: Removed.
- platform/mac-leopard/svg/custom/mask-invalidation-expected.checksum: Copied from platform/mac-leopard/mask-invalidation-expected.checksum.
- platform/mac-leopard/svg/custom/mask-invalidation-expected.png: Copied from platform/mac-leopard/mask-invalidation-expected.png.
- 4:57 PM Changeset in webkit [54688] by
-
- 5 edits1 copy in trunk/WebKitTools
2010-02-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Need a command to clear r+ on obsolete patches in the pending-commit queue.
https://bugs.webkit.org/show_bug.cgi?id=34863
Unfortunately our http://webkit.org/pending-commit bugzilla query is not
smart enough to ignore obsolete patches, so bugs show up there which are
still open, but do not have patches ready for landing on them.
This new command "clean-pending-commit" will remove r+ from obsolete patches
in the pending-commit list.
- Scripts/test-webkitpy: Add grammar_unittest
- Scripts/webkitpy/commands/upload.py: Add clean-pending-commit and make assign-to-committer ignore cq+'d patches.
- Scripts/webkitpy/grammar.py: Add join_with_separators
- Scripts/webkitpy/grammar_unittest.py: Added.
- 4:48 PM Changeset in webkit [54687] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-02-11 Nikolas Zimmermann <nzimmermann@rim.com>
Rubber-stamped by Dirk Schulze.
Add special mac-leopard pixel test results for svg/mask-invalidation.svg - has marginal 0.01% diff to snow leopard baseline.
- platform/mac-leopard/mask-invalidation-expected.checksum: Added.
- platform/mac-leopard/mask-invalidation-expected.png: Added.
- 4:38 PM Changeset in webkit [54686] by
-
- 2 edits in trunk/WebKitLibraries
Rubber-stamped by Eric Seidel.
Turn back on SVG Filters on Windows, as they were accidentally disabled and cause
test breakage.
- win/tools/vsprops/FeatureDefines.vsprops:
- 4:36 PM Changeset in webkit [54685] by
-
- 1 edit1 add in trunk/WebCore
2010-02-11 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add dummy Cursor
https://bugs.webkit.org/show_bug.cgi?id=34672
- platform/brew/CursorBrew.cpp: Added. (WebCore::Cursor::Cursor): (WebCore::Cursor::~Cursor): (WebCore::Cursor::operator=): (WebCore::dummyCursor): (WebCore::pointerCursor): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::moveCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor): (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::aliasCursor): (WebCore::noneCursor): (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor): (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor): (WebCore::grabCursor): (WebCore::grabbingCursor):
- 4:20 PM Changeset in webkit [54684] by
-
- 1 edit1 add in trunk/JavaScriptCore
2010-02-11 Chris Rogers <crogers@google.com>
Reviewed by David Levin.
audio engine: add Complex number class
https://bugs.webkit.org/show_bug.cgi?id=34538
- wtf/Complex.h: Added. (WebCore::complexFromMagnitudePhase):
- 3:38 PM Changeset in webkit [54683] by
-
- 2 edits in trunk/WebKitTools
2010-02-11 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
run-chromium-webkit-tests fails random pixel tests on Mac
https://bugs.webkit.org/show_bug.cgi?id=34862
This is due to the fact that the Mac port has an
invalid path to the image diff tool. Currently it points
to image_diff even though ImageDiff would be correct. We
can't change it to the right path yet without causing the
script to hang. ImageDiff expects to be long-running and
be passed image data over stdin. image_diff (chromium's fork)
expects to be passed command line arguments.
This fix works around the random failures by disabling pixel
tests on mac and logging if the user was trying to run with pixel
tests enabled.
- Scripts/webkitpy/layout_tests/port/mac.py:
- 3:23 PM Changeset in webkit [54682] by
-
- 2 edits in trunk
Touch prefix files to force a rebuild, also so anyone who updates will get a working build
- 3:15 PM Changeset in webkit [54681] by
-
- 2 edits in trunk
Add a missing semicolon to FeatureDefines.vsprops, so both ENABLE_RUBY and ENABLE_SHARED_WORKERS are parsed
- 2:26 PM Changeset in webkit [54680] by
-
- 4 edits in trunk/WebCore
2010-02-11 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Add back in a fast path for v8 object wrapping
when it's not possible we're in a WorkerContext (the fast
path is important for performance).
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8ObjectInWorkerContext): (WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/V8DOMWrapper.h:
- 2:23 PM Changeset in webkit [54679] by
-
- 1 edit in trunk/WebCore/bindings/js/JSDOMWindowCustom.cpp
Touch JSDOMWindowCustom.cpp to get it to build.
- 2:20 PM Changeset in webkit [54678] by
-
- 1 edit2 deletes in trunk/LayoutTests
2010-02-11 Gustavo Noronha Silva <Gustavo Noronha Silva>
Remove platform-specific expected results that only existed
because we diverged from other ports regarding enabling
GeoLocation (Apple ports now enable it).
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
- platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Removed.
- 2:12 PM Changeset in webkit [54677] by
-
- 3 edits in trunk/LayoutTests
2010-02-11 Gustavo Noronha Silva <Gustavo Noronha Silva>
Rebaseline test after 54646, and skip tests that need results
generated.
- platform/gtk/Skipped:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- 2:12 PM Changeset in webkit [54676] by
-
- 1 edit in trunk/WebCore/page/DOMWindow.idl
Touch DOMWindow.idl to force a rebuild of some of the DOM bindings
- 1:53 PM Changeset in webkit [54675] by
-
- 1 edit in trunk/WebKit/win/WebKitPrefix.h
Touch WebKitPrefix.h to force a WebKit rebuild
- 1:44 PM Changeset in webkit [54674] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
That wasn't a fix, rolling it out
- 1:34 PM Changeset in webkit [54673] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
Hopefully final build fix for Windows (I really mean it this time)
- 1:28 PM Changeset in webkit [54672] by
-
- 8 edits in trunk
JavaScriptCore: Added an SPI for asking about all the different live objects on the heap.
Useful for memory debugging.
Reviewed by Oliver Hunt.
- JavaScriptCore.exp: Export the new SPI.
- runtime/Collector.cpp:
(JSC::typeName): Use a little capitalization. Don't crash in the case of
a non-object cell, since it might just be an uninitialized cell.
(JSC::Heap::objectTypeCounts): The new SPI.
- runtime/Collector.h:
- runtime/CollectorHeapIterator.h:
(JSC::CollectorHeapIterator::advance):
(JSC::LiveObjectIterator::operator++):
(JSC::DeadObjectIterator::operator++):
(JSC::ObjectIterator::operator++): Made 2 tweaks to these iterators:
(1) Skip the last cell in the block, since it's a dummy sentinel, and
we don't want it to confuse the object count; (2) Fixed a logic error
in LiveObjectIterator that could cause it to iterate dead objects if
m_block were equal to m_heap.nextBlock and m_cell were less than
m_heap.nextCell. No test for this since I can't think of a way that this
could make WebKit behave badly.
WebKit/mac: Exported some new JavaScript heap introspection.
Reviewed by Oliver Hunt.
- Misc/WebCoreStatistics.h:
- Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics javaScriptObjectTypeCounts]): Just like
javaScriptProtectedObjectTypeCounts, except this function enumerates all
live objects, not just protected objects.
- 1:20 PM Changeset in webkit [54671] by
-
- 2 edits in trunk
Turn off 3D_CANVAS and touch WebCorePrefix.h to force a rebuild.
- 1:04 PM Changeset in webkit [54670] by
-
- 1 edit in trunk/WebKit/win/WebView.cpp
Build fix for Windows
- 12:59 PM Changeset in webkit [54669] by
-
- 2 edits in trunk/WebKitTools
2010-02-11 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Adam Roben.
Try to fix build breakage from r54665.
- Scripts/check-for-global-initializers:
- 12:53 PM Changeset in webkit [54668] by
-
- 8 edits in trunk/WebCore
2010-02-11 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Small cleanups in SVG render tree code.
Centralize calls to inflateShadow(), in SVGRenderSupport::computeRectForRepaint,
instead of spreading them around the subclasses. All classes should inherit
protected from SVGRenderBase, made it consistent.
Doesn't affect layout tests.
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::computeRectForRepaint):
- rendering/RenderSVGImage.h:
- rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::computeRectForRepaint):
- rendering/RenderSVGRoot.h:
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::computeRectForRepaint): (WebCore::RenderSVGText::layout):
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::computeRectForRepaint):
- rendering/SVGRootInlineBox.h:
- 12:44 PM Changeset in webkit [54667] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-11 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] Ignore subsequent requests of the same profiler log
chunks. This eliminates emission of several instances for the same
heap snapshot.
- src/js/ProfilerAgent.js: (devtools.ProfilerAgent): (devtools.ProfilerAgent.prototype.initializeProfiling): (devtools.ProfilerAgent.prototype._getNextLogLines): (devtools.ProfilerAgent.prototype.startProfiling): (devtools.ProfilerAgent.prototype._didGetActiveProfilerModules): (devtools.ProfilerAgent.prototype._didGetLogLines):
- 12:40 PM Changeset in webkit [54666] by
-
- 2 edits in trunk
2010-02-11 Xan Lopez <xlopez@igalia.com>
Try to fix GTK+ build.
- configure.ac:
- 12:05 PM Changeset in webkit [54665] by
-
- 8 edits3 adds in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=34857
Move InlineIterator and BidiRun into new files so subclasses can access them.
Reviewed by Dan Bernstein.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/BidiRun.cpp: Added.
(WebCore::BidiRun::destroy):
(WebCore::throw):
(WebCore::BidiRun::operator delete):
- rendering/BidiRun.h: Added.
(WebCore::BidiRun::BidiRun):
(WebCore::BidiRun::next):
- rendering/InlineIterator.h: Added.
(WebCore::InlineIterator::InlineIterator):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::bidiNext):
(WebCore::bidiFirst):
(WebCore::InlineIterator::increment):
(WebCore::InlineIterator::atEnd):
(WebCore::InlineIterator::current):
(WebCore::InlineIterator::direction):
(WebCore::InlineBidiResolver::increment):
(WebCore::InlineBidiResolver::appendRun):
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::appendRunsForObject):
(WebCore::RenderBlock::requiresLineBox):
- 12:03 PM Changeset in webkit [54664] by
-
- 1 edit in trunk/WebCore/platform/graphics/GraphicsContext3D.h
Add a PLATFORM(WIN) check for NO_ERROR, attempted build fix
- 12:01 PM Changeset in webkit [54663] by
-
- 7 edits in trunk/WebCore
Revert accidental commit
- 11:55 AM Changeset in webkit [54662] by
-
- 7 edits in trunk/WebCore
Attempt to fix the Windows build
- 11:43 AM Changeset in webkit [54661] by
-
- 1 edit in trunk/WebCore/WebCorePrefix.h
Touch WebCorePrefix.h to force a rebuild.
- 11:00 AM Changeset in webkit [54660] by
-
- 2 edits in trunk
2010-02-11 Antonio Gomes <tonikitoo@webkit.org>
Adjust gstreamer-plugins-base minimum version check (from 0.10 to 0.10.23).
Reviewed by Xan Lopez.
- configure.ac:
- 10:55 AM Changeset in webkit [54659] by
-
- 32 edits1 move5 adds in trunk/LayoutTests
2010-02-11 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Test that Web Inspector can inspect styles of elements in iframe from a domain
different from main frame domain.
inspector-tests.js moved to LayoutTests/http/tests/inspector because it can
be referenced by relative path from LayoutTests/inspector but not vice versa
(html files served from LayoutTests/http/tests cannot refer it because WebKit
tests httpd doesn't serve content not under LayoutTests/http).
- http/tests/inspector/inspect-iframe-from-different-domain-expected.txt: Added.
- http/tests/inspector/inspect-iframe-from-different-domain.html: Added.
- http/tests/inspector/inspector-test.js: Renamed from LayoutTests/inspector/inspector-test.js. (onload): (evaluateInWebInspector): (notifyDone): (output): (didEvaluateForTestInFrontend):
- http/tests/inspector/resources/iframe-from-different-domain-data.html: Added.
- inspector/console-clear.html:
- inspector/console-dir.html:
- inspector/console-dirxml.html:
- inspector/console-format-collections-expected.txt:
- inspector/console-format-collections.html:
- inspector/console-format.html:
- inspector/console-log-before-inspector-open.html:
- inspector/console-tests.html:
- inspector/cookie-resource-match.html:
- inspector/elements-img-tooltip.html:
- inspector/elements-panel-rewrite-href-expected.txt:
- inspector/elements-panel-rewrite-href.html:
- inspector/elements-panel-selection-on-refresh.html:
- inspector/elements-panel-structure.html:
- inspector/evaluate-in-frontend.html:
- inspector/inspected-objects-not-overriden.html:
- inspector/styles-iframe.html:
- inspector/syntax-highlight-css.html:
- inspector/syntax-highlight-javascript.html:
- inspector/timeline-enum-stability.html:
- inspector/timeline-event-dispatch.html:
- inspector/timeline-layout.html:
- inspector/timeline-mark-timeline.html:
- inspector/timeline-network-resource.html:
- inspector/timeline-paint.html:
- inspector/timeline-parse-html.html:
- inspector/timeline-recalculate-styles.html:
- inspector/timeline-script-tag-1.html:
- inspector/timeline-script-tag-2.html:
- inspector/timeline-trivial.html:
- platform/qt/Skipped:
- 10:27 AM Changeset in webkit [54658] by
-
- 2 edits in trunk/WebCore
Fixes CodeGeneratorV8.pm to include the header for the indexer type when using setCollectionIndexedGetter()
https://bugs.webkit.org/show_bug.cgi?id=34836
setCollectionIndexedGetter() uses getIndexedPropertyOfCollection(),
which in turn uses toV8() with the indexer type, which is declared in
the header for the indexer type.
- 9:16 AM Changeset in webkit [54657] by
-
- 11 edits2 adds3 deletes in trunk/WebCore
2010-02-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: split source code into chunks in order to improve text
viewer performance on large files.
This change brings back SourceFrame's canvas+style magic, restores line
wrapping and makes things a lot like they used to be.
It removes TextEditor for now and renames NativeTextViewer into TextViewer.
TextViewer is no longer derived from TextEditor.
This TextViewer is still based on TextEditorModel, no iframes are involved.
Instead of creating div per line, TextViewer splits source code into 50 line
chunks. Upon scroll event, visible chunks are sharded into lines and individual
lines are highlighted. Whenever highlighted region gets outside of the visible
area, highlight spans are thrown away and region is replaced with the original
plain text chunk.
Complex stuff:
- Whenever there is a need to manipulate individual lines (add message bubble / set breakpoint / reveal / etc.), individual chunks for such lines are created.
- There is also an implicit machinery that is maintaining selection when it goes beyond the visible area.
- Search occurrences are implemented as artificial spans interweaving highlighting markup.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/NativeTextViewer.js: Removed.
- inspector/front-end/ScriptView.js: (WebInspector.ScriptView):
- inspector/front-end/Settings.js:
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.set visible): (WebInspector.SourceFrame.prototype.set executionLine): (WebInspector.SourceFrame.prototype.revealLine): (WebInspector.SourceFrame.prototype.addBreakpoint): (WebInspector.SourceFrame.prototype.removeBreakpoint): (WebInspector.SourceFrame.prototype.addMessage): (WebInspector.SourceFrame.prototype.clearMessages): (WebInspector.SourceFrame.prototype.sizeToFitContentHeight): (WebInspector.SourceFrame.prototype.setContent): (WebInspector.SourceFrame.prototype.highlightLine): (WebInspector.SourceFrame.prototype._createViewerIfNeeded): (WebInspector.SourceFrame.prototype.markAndRevealRange): (WebInspector.SourceFrame.prototype.clearMarkedRange): (WebInspector.SourceFrame.prototype._breakpointChanged): (WebInspector.SourceFrame.prototype._updateExecutionLine): (WebInspector.SourceFrame.prototype._addMessageToSource): (WebInspector.SourceFrame.prototype._addExistingBreakpointsToSource): (WebInspector.SourceFrame.prototype._addBreakpointToSource): (WebInspector.SourceFrame.prototype._removeBreakpointFromSource): (WebInspector.SourceFrame.prototype._mouseDown): (WebInspector.SourceFrame.prototype._editBreakpointCondition.committed): (WebInspector.SourceFrame.prototype._editBreakpointCondition.dismissed): (WebInspector.SourceFrame.prototype._editBreakpointCondition): (WebInspector.SourceFrame.prototype._showBreakpointConditionPopup): (WebInspector.SourceFrame.prototype._createConditionElement): (WebInspector.SourceFrame.prototype._keyDown): (WebInspector.SourceFrame.prototype.resize): (WebInspector.SourceFrame.prototype._drawProgramCounterInContext): (WebInspector.SourceFrame.prototype._drawProgramCounterImageIfNeeded): (WebInspector.SourceFrame.prototype._drawBreakpointImagesIfNeeded.drawBreakpoint): (WebInspector.SourceFrame.prototype._drawBreakpointImagesIfNeeded):
- inspector/front-end/SourceView.js: (WebInspector.SourceView): (WebInspector.SourceView.prototype._removeBreakpoint): (WebInspector.SourceView.prototype.searchCanceled): (WebInspector.SourceView.prototype._jumpToSearchResult):
- inspector/front-end/TextEditor.js: Removed.
- inspector/front-end/TextViewer.js: Added. (WebInspector.TextViewer): (WebInspector.TextViewer.prototype.set mimeType): (WebInspector.TextViewer.prototype.get textModel): (WebInspector.TextViewer.prototype.revealLine): (WebInspector.TextViewer.prototype.addDecoration): (WebInspector.TextViewer.prototype.removeDecoration): (WebInspector.TextViewer.prototype.markAndRevealRange): (WebInspector.TextViewer.prototype.highlightLine): (WebInspector.TextViewer.prototype._textChanged): (WebInspector.TextViewer.prototype._createChunkRow): (WebInspector.TextViewer.prototype._makeLineAChunk): (WebInspector.TextViewer.prototype._indexChunks): (WebInspector.TextViewer.prototype._highlightChanged): (WebInspector.TextViewer.prototype._scroll): (WebInspector.TextViewer.prototype.setCoalescingUpdate): (WebInspector.TextViewer.prototype._repaintAll): (WebInspector.TextViewer.prototype._chunkForOffset): (WebInspector.TextViewer.prototype._chunkNumberForLine): (WebInspector.TextViewer.prototype._chunkStartLine): (WebInspector.TextViewer.prototype._restoreChunks): (WebInspector.TextViewer.prototype._repaint): (WebInspector.TextViewer.prototype._getSelection): (WebInspector.TextViewer.prototype._restoreSelection): (WebInspector.TextViewer.prototype._selectionToPosition): (WebInspector.TextViewer.prototype._createLineRow): (WebInspector.TextViewer.prototype._paintLine): (WebInspector.TextViewer.prototype._createSpan): (WebInspector.TextViewer.prototype._createLink): (WebInspector.TextViewer.prototype._rewriteHref): (WebInspector.TextViewer.prototype._markRange): (WebInspector.TextViewer.prototype._decimalDigits): (WebInspector.TextViewer.prototype.resize):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.html:
- inspector/front-end/textEditor.css: Removed.
- inspector/front-end/textViewer.css: Added.
- inspector/front-end/utilities.js: (Node.prototype.traverseNextTextNode): (Node.prototype.rangeBoundaryForOffset):
- 8:18 AM Changeset in webkit [54656] by
-
- 2 edits in trunk/WebCore
[Qt] ENABLE_RUBY flag was restored by r54649, but default value wasn't added for Qt port.
https://bugs.webkit.org/show_bug.cgi?id=34698
Reviewed by Tor Arne Vestbø.
- WebCore.pri: Add ENABLE_RUBY=1 as default setting.
- 8:03 AM Changeset in webkit [54655] by
-
- 2 edits in trunk/JavaScriptCore
Guard cmath using declarations in MathExtras.h on Android
https://bugs.webkit.org/show_bug.cgi?id=34840
- 7:44 AM Changeset in webkit [54654] by
-
- 2 edits in trunk/WebKitTools
Make it possible to toggle accelerated compositing from the menu
at run-time.
Reviewed by Tor Arne Vestbø.
- QtLauncher/main.cpp:
(LauncherWindow::toggleAcceleratedCompositing):
(LauncherWindow::setupUI):
- 7:37 AM QtWebKitTableOfFeatures46 edited by
- (diff)
- 7:33 AM QtWebKitTableOfFeatures46 edited by
- (diff)
- 5:29 AM Changeset in webkit [54653] by
-
- 2 edits in trunk/WebCore
2010-02-11 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Updates Android V8 Makefile to generate Notifications and WebSockets headers required by V8DOMWrapper.cpp
https://bugs.webkit.org/show_bug.cgi?id=34815
No new tests, build fix only.
- Android.derived.v8bindings.mk:
- 5:27 AM Changeset in webkit [54652] by
-
- 2 edits in trunk/WebCore
2010-02-11 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Updates Android V8 Makefile to generate XPath header required by V8Proxy.cpp
https://bugs.webkit.org/show_bug.cgi?id=34814
No new tests, build fix only.
- Android.derived.v8bindings.mk:
- 3:40 AM Changeset in webkit [54651] by
-
- 2 edits in trunk/WebCore
Update Android V8 Makefile to generate Inspector headers required by V8 ScriptObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=34806
- 3:27 AM Changeset in webkit [54650] by
-
- 5 edits in trunk/WebCore
Guards SVG code in V8 bindings with ENABLE(SVG)
https://bugs.webkit.org/show_bug.cgi?id=34812
Also updates Android V8 Makefile to generate required SVG headers.
No new tests, build fix only.
- 2:55 AM Changeset in webkit [54649] by
-
- 25 edits in trunk
2010-02-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698
- Configurations/FeatureDefines.xcconfig:
2010-02-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698
- win/tools/vsprops/FeatureDefines.vsprops:
2010-02-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698
- Configurations/FeatureDefines.xcconfig:
2010-02-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- GNUmakefile.am:
- html/HTMLTagNames.in: Make the ruby-related tag names conditional.
- rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): ifdef the code that would create ruby elements.
- rendering/RenderObject.h: ditto above
- rendering/RenderRuby.cpp: ifdef this whole file
- rendering/RenderRuby.h: ditto
- rendering/RenderRubyBase.cpp: ditto
- rendering/RenderRubyBase.h: ditto
- rendering/RenderRubyRun.cpp: ditto
- rendering/RenderRubyRun.h: ditto
- rendering/RenderRubyText.cpp: ditto
- rendering/RenderRubyText.h: ditto
2010-02-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698
- configure.ac:
2010-02-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698
- Scripts/build-webkit:
- 1:26 AM Changeset in webkit [54648] by
-
- 5 edits in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] Update expected results for the following tests after r54646 because of ImageData support.
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 12:34 AM Changeset in webkit [54647] by
-
- 11 edits6 adds in trunk
2010-02-11 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Step attribute support for date&time types.
https://bugs.webkit.org/show_bug.cgi?id=30847
Add tests for ValidityState.stepMismatch, stepUp() and stepDown()
for date, datetime, datetime-local, month, time, week types.
Update valueAsDate and valueAsNumber tests for a string representation
change.
- fast/forms/ValidityState-stepMismatch-expected.txt: Added.
- fast/forms/ValidityState-stepMismatch.html: Added.
- fast/forms/input-stepup-stepdown-expected.txt: Added.
- fast/forms/input-stepup-stepdown.html: Added.
- fast/forms/input-valueasdate-datetime-expected.txt:
- fast/forms/input-valueasdate-time-expected.txt:
- fast/forms/input-valueasnumber-datetime-expected.txt:
- fast/forms/input-valueasnumber-datetimelocal-expected.txt:
- fast/forms/input-valueasnumber-time-expected.txt:
- fast/forms/script-tests/ValidityState-stepMismatch.js: Added.
- fast/forms/script-tests/input-stepup-stepdown.js: Added.
- fast/forms/script-tests/input-valueasdate-datetime.js:
- fast/forms/script-tests/input-valueasnumber-datetime.js:
2010-02-11 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Step attribute support for date&time types.
https://bugs.webkit.org/show_bug.cgi?id=30847
- Add implementation for ValidityState.stepMismatch, stepUp() and stepDown() for date, datetime, datetime-local, month, time, week types.
- Fix string representation of DateComponents.
Tests: fast/forms/ValidityState-stepMismatch.html
fast/forms/input-stepup-stepdown.html
- html/HTMLInputElement.cpp:
- Change monthDefaultMaximum so that DateComponents::m_year doesn't overflow.
(WebCore::HTMLInputElement::stepBase):
(WebCore::HTMLInputElement::stepMismatch):
(WebCore::HTMLInputElement::getStepParameters):
(WebCore::HTMLInputElement::getAllowedValueStep):
(WebCore::HTMLInputElement::applyStep):
Renamed from applyStepForNumberOrRange(), and add support for other types.
(WebCore::HTMLInputElement::stepUp): Rename applyStepForNumberOrRange().
(WebCore::HTMLInputElement::stepDown): Rename applyStepForNumberOrRange().
(WebCore::HTMLInputElement::setValueAsDate): Use setDateValue().
(WebCore::HTMLInputElement::setDateValue):
A helper function to make the best representation of DateComponents.
(WebCore::HTMLInputElement::setValueAsNumber): Use setDateValue().
- html/HTMLInputElement.h:
- 12:30 AM Changeset in webkit [54646] by
-
- 13 edits in trunk
2010-02-10 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
postMessage does not send ImageData
https://bugs.webkit.org/show_bug.cgi?id=34825
Add test for postMessage passing ImageData
Update a few other tests to cover the fact that ImageData's constructor
is now available on the window object.
- fast/dom/Window/window-postmessage-clone-expected.txt:
- fast/dom/Window/window-postmessage-clone.html:
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/js/global-constructors-expected.txt:
2010-02-10 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
postMessage does not send ImageData
https://bugs.webkit.org/show_bug.cgi?id=34825
Implement serialisation of ImageData, and for testing reasons
expose the ImageData constructor (which should already have
been exposed).
- bindings/js/SerializedScriptValue.cpp: (WebCore::SerializedImageData::create): (WebCore::SerializedImageData::width): (WebCore::SerializedImageData::height): (WebCore::SerializedImageData::data): (WebCore::SerializedImageData::SerializedImageData): (WebCore::SerializedScriptValueData::SerializedScriptValueData): (WebCore::SharedSerializedData::asImageData): (WebCore::SerializingTreeWalker::convertIfTerminal): (WebCore::DeserializingTreeWalker::convertIfTerminal): (WebCore::TeardownTreeWalker::convertIfTerminal):
- bindings/js/SerializedScriptValue.h: (WebCore::SerializedScriptValueData::): (WebCore::SerializedScriptValueData::asImageData):
- html/canvas/CanvasPixelArray.h: (WebCore::CanvasPixelArray::data):
- page/DOMWindow.idl:
Feb 10, 2010:
- 11:32 PM Changeset in webkit [54645] by
-
- 12 edits in trunk/WebCore
2010-02-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Address last round of review comments on r53607
https://bugs.webkit.org/show_bug.cgi?id=33940
Mostly renaming and cleaning up.
- css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent):
- css/CSSStyleSheet.h: (WebCore::CSSStyleSheet::create): (WebCore::CSSStyleSheet::createInline):
- css/StyleBase.cpp: (WebCore::StyleBase::baseURL):
- css/StyleSheet.cpp: (WebCore::StyleSheet::StyleSheet):
- css/StyleSheet.h: (WebCore::StyleSheet::href): (WebCore::StyleSheet::setFinalURL): (WebCore::StyleSheet::finalURL):
- dom/Document.cpp: (WebCore::Document::updateBaseURL):
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
- xml/XSLImportRule.cpp: (WebCore::XSLImportRule::loadSheet):
- xml/XSLStyleSheet.h: (WebCore::XSLStyleSheet::create): (WebCore::XSLStyleSheet::createInline):
- xml/XSLStyleSheetLibxslt.cpp: (WebCore::XSLStyleSheet::XSLStyleSheet): (WebCore::XSLStyleSheet::parseString): (WebCore::XSLStyleSheet::loadChildSheets):
- xml/XSLStyleSheetQt.cpp: (WebCore::XSLStyleSheet::XSLStyleSheet):
- 11:14 PM Changeset in webkit [54644] by
-
- 2 edits in trunk/WebCore
2010-02-10 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] GraphicsLayer: somtimes the item flickers at the end of an animation
This is because we try to delete the animation when finished: that is
unnecessary. WebCore manages the animation's lifecycle and makes sure
to call the right function when the animation can be deleted.
No new tests.
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQt::addAnimation): No need to delete here (WebCore::GraphicsLayerQt::removeAnimationsForProperty): deleteLater
- 10:51 PM Changeset in webkit [54643] by
-
- 2 edits1 move in trunk/WebCore
[wx] Build fix for wxMac/Cocoa.
- 10:27 PM Changeset in webkit [54642] by
-
- 2 edits in trunk/WebCore
REGRESSION(24929): PDF page doesn't load in background tab
Reviewed by Dan Bernstein.
- plugins/PluginView.cpp:
(WebCore::PluginView::startOrAddToUnstartedList):
Only delay loading of the plug-in if we'll kick off our own load of the
plug-in data later, in start().
- 7:58 PM Changeset in webkit [54641] by
-
- 2 edits in trunk/WebCore
Crash in WebKit!WebCore::RenderTextControlSingleLine::createInnerTextStyle doing anything in Safari after sitting on a page with 3D site
<rdar://problem/7557201>
https://bugs.webkit.org/show_bug.cgi?id=34823
Reviewed by Simon Fraser.
No tests added because the code is exercised by the existing tests.
The root cause was the fact that we were not releasing a reference that was held by CA.
In debug builds we had an assert in the destructor of WKCACFLayer.
- platform/graphics/win/GraphicsLayerCACF.cpp:
(WebCore::GraphicsLayerCACF::~GraphicsLayerCACF):
- 7:47 PM Changeset in webkit [54640] by
-
- 5 edits in trunk/WebKit/chromium
2010-02-10 James Hawkins <jhawkins@chromium.org>
Reviewed by Eric Seidel.
[Chromium] Remove code from SuggestionsPopup that was removed in a
previous revision of AutocompletePopup and accidentally added back in
the refactoring.
- src/AutoFillPopupMenuClient.cpp:
- src/AutoFillPopupMenuClient.h: Added property svn:eol-style.
- src/SuggestionsPopupMenuClient.cpp: (WebKit::SuggestionsPopupMenuClient::popupDidHide): (WebKit::SuggestionsPopupMenuClient::setTextFromItem): (WebKit::SuggestionsPopupMenuClient::initialize):
- src/SuggestionsPopupMenuClient.h:
- 7:30 PM Changeset in webkit [54639] by
-
- 2 edits in trunk/WebCore
2010-02-10 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Typedef DragImageRef
https://bugs.webkit.org/show_bug.cgi?id=34791
Use IImage* as it is the BREW's image type.
- platform/DragImage.h:
- 7:04 PM Changeset in webkit [54638] by
-
- 6 edits4 adds in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=34185 REGRESSION:
Mask not invalidating
Reviewed by Simon Fraser and Darin Adler.
SVGMaskElement is the only class that keeps a HashMap of canvas
resources rather than just a pointer to a resource. This
patch makes SVGMaskElement invalidate all of its resources in the
HashMap instead of just one.
- svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::svgAttributeChanged):
(WebCore::SVGMaskElement::childrenChanged):
(WebCore::SVGMaskElement::invalidateCanvasResources):
- svg/SVGMaskElement.h:
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::invalidateResourcesInAncestorChain):
(WebCore::SVGStyledElement::invalidateCanvasResources):
- svg/SVGStyledElement.h:
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=34185 REGRESSION:
Mask not invalidating
Reviewed by Simon Fraser and Darin Adler.
- platform/mac/svg/custom/mask-invalidation-expected.checksum: Added.
- platform/mac/svg/custom/mask-invalidation-expected.png: Added.
- platform/mac/svg/custom/mask-invalidation-expected.txt: Added.
- svg/custom/mask-invalidation.svg: Added.
- 6:46 PM Changeset in webkit [54637] by
-
- 5 edits in trunk/WebCore
2010-02-10 Stephan Aßmus <superstippi@gmx.de>
Reviewed by David Levin.
Fixes to rect conversion and image rendering on Haiku
https://bugs.webkit.org/show_bug.cgi?id=34684
Covered by existing tests.
The changes to the rect conversions are indeed correct. In Haiku (to stay
compatibly with BeOS), a BRect specifies the left/top and bottom/right pixel
*indices*, even though the values are floating point. So a rectangle covering
just one pixel would be specified as BRect(0, 0, 0, 0). In WebCore and other
frame works, such rectangles would be expressed as 0, 0, 1, 1. In WebCore, the
width and height of rectangles refer to the distance between pixels, while on
Haiku, a one pixel rect has indeed a width and height of 0, as confusing as
that may be.
The part of the patch that affects
WebCore/platform/graphics/haiku/ImageHaiku.cpp also implements the drawing
methods more correctly. Image observers are notified, and pattern drawing takes
the "phase" into account which makes scrolled backgrounds render correctly.
Transformations are still not supported, since the Haiku drawing backend itself
does not yet support them.
Use OwnPtr when creating the BBitmap to avoid future leaks with early returns.
Convert the bitmap data to non pre-multiplied until Haiku supports drawing
pre-multiplied bitmaps.
- platform/graphics/haiku/FloatRectHaiku.cpp: Fixed conversion
- platform/graphics/haiku/ImageHaiku.cpp: (WebCore::BitmapImage::draw): Fixed placement, notify observers (WebCore::Image::drawPattern): Implemented using "phase" to fix scrolling, notify observers
- platform/graphics/haiku/IntRectHaiku.cpp: Fixed conversion
- platform/image-decoders/haiku/ImageDecoderHaiku.cpp: Fixed conversion
- 6:05 PM Changeset in webkit [54636] by
-
- 3 edits in trunk/WebCore
2010-02-10 Simon Fraser <Simon Fraser>
Reviewed by David Levin.
Clean up unused member var and initialization in Document
https://bugs.webkit.org/show_bug.cgi?id=34820
Remove unused m_secureForms member variable in Document.
- dom/Document.cpp: (WebCore::Document::Document):
- dom/Document.h:
- 5:50 PM Changeset in webkit [54635] by
-
- 9 edits in trunk/WebKitTools
2010-02-10 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Fix various minor bugs keeping run-chromium-webkit-tests from actually
working on the linux and win ports of Chromium.
- Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
- Scripts/webkitpy/layout_tests/port/init.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/http_server.py:
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- 5:24 PM Changeset in webkit [54634] by
-
- 4 edits1 add in trunk/WebKitTools
2010-02-10 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
run-chromium-webkit-tests --platform=mac-leopard crashes when using a custom build directory
https://bugs.webkit.org/show_bug.cgi?id=34817
This doesn't fix the root cause of us not
correctly failing when support binaries are missing.
This only causes the DumpRenderTree binary not to be
missing in the custom build directory case.
Later patches will make us correctly fail fast when
support binaries (like DumpRenderTree or ImageDiff) are missing.
- Scripts/webkit-build-directory: Added.
- Need a way to re-use the perl logic for finding build directories in non-perl scripts.
- Scripts/webkitpy/layout_tests/port/base.py: Add a FIXME.
- Scripts/webkitpy/layout_tests/port/mac.py:
- Call webkit-build-directory to find the build directory instead of assuming "WebKitBuild"
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Add FIXMEs.
- 5:22 PM Changeset in webkit [54633] by
-
- 16 edits in trunk
Reviewed by Kevin Ollivier.
[wx] Add Windows complex text support and Mac support for containsCharacters.
https://bugs.webkit.org/show_bug.cgi?id=34759
- 4:54 PM Changeset in webkit [54632] by
-
- 1 edit2 adds in trunk/WebCore
2010-02-10 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add dummy Frame::dragImageForSelection
https://bugs.webkit.org/show_bug.cgi?id=34792
Add FrameBrew.cpp which contains a dummy implementation of
Frame::dragImageForSelection.
- page/brew/FrameBrew.cpp: Added. (WebCore::Frame::dragImageForSelection):
- 4:24 PM Changeset in webkit [54631] by
-
- 5 edits in trunk
[wx] Build fixes. Move drawPattern implementation to the Image class like other platforms have it, and add a stub for a new LayoutTestController method.
- 4:11 PM Changeset in webkit [54630] by
-
- 5 edits in trunk/WebCore
Added CA_PRINT_TREE functionality to WKCACFLayer implementation
https://bugs.webkit.org/show_bug.cgi?id=34779
I've tried to duplicate the look of the output on Mac, but
it's not quite the same. It shows all the useful information though.
It is enabled by setting the environment variable CA_PRINT_TREE=1
- 4:08 PM Changeset in webkit [54629] by
-
- 14 edits in trunk
2010-02-10 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Change V8DOMWrapper::lookupDOMWrapper() and configureTemplate()
to not use V8ClassIndex.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8Binding.cpp:
- bindings/v8/V8Binding.h:
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8DOMWrapper.h:
- bindings/v8/V8Proxy.cpp:
- bindings/v8/WorkerContextExecutionProxy.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8LocationCustom.cpp:
- bindings/v8/custom/V8MessageEventCustom.cpp:
- 4:05 PM Changeset in webkit [54628] by
-
- 7 edits1 delete in trunk
Unreviewed. Roll out r54626, because it broke GTK and Win build.
https://bugs.webkit.org/show_bug.cgi?id=32717
WebKitTools:
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
LayoutTests:
- platform/mac/Skipped:
- platform/mac/fast/frames/flattening: Removed.
- platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Removed.
- platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.txt: Removed.
- platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.txt: Removed.
- platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Removed.
- platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Removed.
- 3:30 PM Changeset in webkit [54627] by
-
- 2 edits in trunk/WebCore
2010-02-10 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Handle the possibility that ScheduledAction::execute() may
retrieve a null V8Proxy* even if not in a WorkerContext (e.g., if
JS was disallowed).
- bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
- 3:23 PM Changeset in webkit [54626] by
-
- 7 edits6 adds in trunk
2010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Support frameset flattening
https://bugs.webkit.org/show_bug.cgi?id=32717
Add expected results of the FrameSet Flattening tests.
- platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
- platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
- platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
- platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Added.
- platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.
- platform/mac/Skipped:
2010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Support frameset flattening
https://bugs.webkit.org/show_bug.cgi?id=32717
Add FrameSet Flattening support to Mac DRT.
- DumpRenderTree/LayoutTestController.cpp: (setFrameSetFlatteningEnabledCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setFrameSetFlatteningEnabled):
- 3:04 PM Changeset in webkit [54625] by
-
- 8 edits2 adds in trunk
2010-02-10 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Remove automatic viewport resizing
https://bugs.webkit.org/show_bug.cgi?id=34766
Removed automatic viewport resizing per conclusions on the WebGL
mailing list. Added test verifying new behavior and updated a
couple of previous tests failing after this change.
- fast/canvas/webgl/gl-get-calls-expected.txt:
- fast/canvas/webgl/gl-get-calls.html:
- fast/canvas/webgl/texImage2DImageDataTest.html:
- fast/canvas/webgl/viewport-unchanged-upon-resize-expected.txt: Added.
- fast/canvas/webgl/viewport-unchanged-upon-resize.html: Added.
2010-02-10 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Remove automatic viewport resizing
https://bugs.webkit.org/show_bug.cgi?id=34766
Removed automatic viewport resizing per conclusions on the WebGL
mailing list. Added test verifying new behavior and updated a
couple of previous tests failing after this change.
Test: fast/canvas/webgl/viewport-unchanged-upon-resize.html
- platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::reshape):
2010-02-10 Kenneth Russell <kbr@google.com>
Reviewed by Oliver Hunt.
Remove automatic viewport resizing
https://bugs.webkit.org/show_bug.cgi?id=34766
Removed automatic viewport resizing per conclusions on the WebGL
mailing list. Added test verifying new behavior and updated a
couple of previous tests failing after this change.
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::reshape):
- 2:54 PM Changeset in webkit [54624] by
-
- 3 edits in branches/safari-4-branch/WebCore
MSAA: selected, selectable, extended selectable, and multiple
selectable states are not reported
https://bugs.webkit.org/show_bug.cgi?id=33574
<rdar://problem/7536826>
Follow-up fix to account for the fact that different function names
are used on the branch.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isMultiSelectable):
- accessibility/AccessibilityRenderObject.h:
- 2:37 PM Changeset in webkit [54623] by
-
- 2 edits in trunk/WebCore
2010-02-10 Ariya Hidayat <ariya.hidayat@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement image interpolation quality.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::setImageInterpolationQuality): (WebCore::GraphicsContext::imageInterpolationQuality):
- 2:01 PM Changeset in webkit [54622] by
-
- 2 edits in trunk/WebCore
2010-02-10 Eric Seidel <eric@webkit.org>
No review, Mac build fix.
Crash in Flash at http://www.cctv.com/
https://bugs.webkit.org/show_bug.cgi?id=34673
- plugins/PluginViewNone.cpp: (WebCore::PluginView::getValueStatic):
- 1:52 PM Changeset in webkit [54621] by
-
- 3 edits in branches/safari-4-branch/WebCore
Merge r54615.
- 1:26 PM Changeset in webkit [54620] by
-
- 9 edits6 adds in trunk
WebCore
2010-02-10 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Xan Lopez.
[GTK] Hits assertion on history back, with page cache enabled, in specific conditions
https://bugs.webkit.org/show_bug.cgi?id=34773
When unsetting the adjustments from a ScrollView, also disconnect
them from the Scrollbars.
Test: fast/frames/frame-crash-with-page-cache.html
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setGtkAdjustments):
- platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::~ScrollbarGtk): (ScrollbarGtk::detachAdjustment):
- platform/gtk/ScrollbarGtk.h:
LayoutTests
2010-02-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Hits assertion on history back, with page cache enabled, in specific conditions
https://bugs.webkit.org/show_bug.cgi?id=34773
- fast/frames/frame-crash-with-page-cache.html: Added.
- fast/frames/resources/cached-page-1.html: Added.
- fast/frames/resources/cached-page-2.html: Added.
- fast/frames/resources/cached-page-3.html: Added.
- fast/frames/resources/cached-page-iframe.html: Added.
WebKit/gtk
2010-02-09 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Xan Lopez.
[GTK] Hits assertion on history back, with page cache enabled, in specific conditions
https://bugs.webkit.org/show_bug.cgi?id=34773
Make sure cached frames have their scrollbars disconnected from
the WebView's adjustments.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::savePlatformDataToCachedFrame):
- 1:18 PM Changeset in webkit [54619] by
-
- 3 edits in trunk/JavaScriptCore
Addressing issues found by style bot.
- wtf/ValueCheck.h: Renamed header guard to match final file name.
- wtf/Vector.h: (WTF::::checkConsistency): Remove braces around a one-line clause.
- 1:14 PM Changeset in webkit [54618] by
-
- 14 edits6 adds in trunk
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=34490
WebCore::ImageEventSender::dispatchPendingEvents() crashes in certain conditions
Test: fast/images/destroyed-image-load-event.html
- ForwardingHeaders/wtf/ValueCheck.h: Added.
- loader/ImageLoader.cpp: (WTF::ValueCheck): Special case value check for ImageLoader - it's allocated inside elements, so check the owner instead. (WebCore::ImageEventSender::hasPendingEvents): Added a debugging aid for ImageLoader destructor. (WebCore::ImageLoader::~ImageLoader): Assert that we're not going to leave dangling pointers in ImageEventSender. (WebCore::ImageLoader::setImage): Cancel events that could be dispatched for the previous image. The only client using this method that I could find was DeleteButton, which doesn't care about load events for the new image, so I didn't add any code for firing those. (WebCore::ImageLoader::setLoadingImage): This method only existed to confuse readers - there wasn't any meaningful code shared (callers just undid most assignments made there). Merged the logic into callers. (WebCore::ImageLoader::updateFromElement): We're forgetting the old image, so forget its old events, too. (WebCore::ImageLoader::notifyFinished): This can be called from setImage(), in which case no one is going to dispatch the event "soon". So, don't queue it. (WebCore::ImageEventSender::dispatchPendingEvents): Call checkConsistency(). This didn't help catch this particuar bug, but seems like a useful check anyway.
- loader/ImageLoader.h: Removed setLoadingImage().
- 1:08 PM Changeset in webkit [54617] by
-
- 2 edits in trunk/WebCore
Mac build fix. Unreviewed.
- WebCore.xcodeproj/project.pbxproj:
Add PluginViewNone.cpp to the Mac project.
- 1:05 PM Changeset in webkit [54616] by
-
- 4 edits in trunk/WebCore
Optimize ImageBuffer::toDataURL's CG implementation
There was some unused code that could have been removed in r31830 when
this function was changed not to flip the CG image anymore.
Fixes <http://webkit.org/b/34808> ImageBuffer::toDataURL allocates
unnecessary memory under CoreGraphics
Reviewed by Sam Weinig.
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::toDataURL): Don't allocate an unused CGImageRef
and buffer, and switch to the new overload of base64Encode that
doesn't require us to copy all the image data into a Vector first.
- platform/text/Base64.cpp:
(WebCore::base64Encode):
- platform/text/Base64.h:
Added an overload that takes a raw data pointer and length, just like
we have for base64Decode. The overload that takes a Vector as input
just calls through to the new overload.
- 1:02 PM Changeset in webkit [54615] by
-
- 3 edits in trunk/WebCore
Complete the fix for <rdar://problem/7577604> Drag and Drop: background elements are bleeding through
https://bugs.webkit.org/show_bug.cgi?id=34546
Reviewed by Dave Hyatt.
- manual-tests/drag-image-table-part-decorations.html:
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paint): Don’t paint collapsed borders if this object shouldn’t
paint within the current painting root.
- 12:18 PM Changeset in webkit [54614] by
-
- 9 edits2 adds in trunk
<rdar://problem/7436875> Crash in Flash when visiting
http://www.cctv.com/default.shtml (WER ID 819298200) [watson 2502260]
Reviewed by Darin Adler.
WebCore:
Test: platform/win/plugins/plugin-delayed-destroy.html
- bridge/NP_jsobject.cpp:
(_NPN_Evaluate):
If Flash calls this to evaluate a script that destroys the PluginView,
we crash when returning to Flash code. Before evaluating the script,
call PluginView::keepAlive() to hold a ref to this instance (and release
it asynchronously).
- plugins/PluginView.cpp:
(WebCore::instanceMap):
Return a map from the NPP to the PluginView.
(WebCore::PluginView::~PluginView):
Assert that the keep alive timer is not running; remove ourselves from
the instance map.
(WebCore::PluginView::performRequest):
The parent Frame is now a RefPtr; use .get().
(WebCore::PluginView::status):
Ditto.
(WebCore::PluginView::didReceiveResponse):
Ditto.
(WebCore::PluginView::PluginView):
Add the view to the instance map.
(WebCore::PluginView::lifeSupportTimerFired):
Deref the PluginView.
(WebCore::PluginView::keepAlive):
Ref the PluginView, then start a time to release the reference
asynchronously.
(WebCore::PluginView::keepAlive):
Find the PluginView in the map, and call its keepAlive() function.
- plugins/PluginView.h:
Made m_parentFrame a RefPtr, so that it will remain valid when the
keep alive timer fires.
(WebCore::PluginView::parentFrame):
Use .get().
- plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::updatePluginWidget):
Use .get().
(WebCore::PluginView::handleKeyboardEvent):
Use .get().
(WebCore::PluginView::handleMouseEvent):
Use .get().
- plugins/PluginViewNone.cpp:
(WebCore::PluginView::keepAlive):
Stubbed.
WebKitTools:
- DumpRenderTree/win/TestNetscapePlugin/main.cpp:
(executeScript):
Moved to an earlier point in the file.
(NPP_New):
If the plug-in has an onDestroy attribute, store its value.
(NPP_Destroy):
If the plug-in has code to run on destruction, run it and free it.
LayoutTests:
- platform/win/plugins/plugin-delayed-destroy-expected.txt: Added.
- platform/win/plugins/plugin-delayed-destroy.html: Added.
- 11:44 AM Changeset in webkit [54613] by
-
- 7 edits in trunk
2010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Support frameset flattening
https://bugs.webkit.org/show_bug.cgi?id=32717
Add support for enabling/disabling FrameSet Flattening on the Mac port.
- WebCore.base.exp:
2010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Support frameset flattening
https://bugs.webkit.org/show_bug.cgi?id=32717
Add support for enabling/disabling FrameSet Flattening on the Mac port.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences isFrameSetFlatteningEnabled]): (-[WebPreferences setFrameSetFlatteningEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
- 11:26 AM Changeset in webkit [54612] by
-
- 7 edits in trunk
2010-02-10 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Implement pageNumberForElementById() method in Qt DRT LayoutTestController,
to make Qt DRT able to get page number.
LayoutTests:
printing/page-break-always.html
printing/pageNumerForElementById.html
printing/css2.1/page-break-before-000.html
printing/css2.1/page-break-after-000.html
printing/css2.1/page-break-after-004.html
printing/css2.1/page-break-before-001.html
printing/css2.1/page-break-after-001.html
printing/css2.1/page-break-after-002.html
printing/css2.1/page-break-before-002.html
printing/css2.1/page-break-inside-000.html
[Qt] Make possible Qt DRT get a page number for element by ID
https://bugs.webkit.org/show_bug.cgi?id=34777
- platform/qt/Skipped:
2010-02-10 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Implement pageNumberForElementById() method in Qt DRT LayoutTestController,
to make Qt DRT able to get page number.
LayoutTests:
printing/page-break-always.html
printing/pageNumerForElementById.html
printing/css2.1/page-break-before-000.html
printing/css2.1/page-break-after-000.html
printing/css2.1/page-break-after-004.html
printing/css2.1/page-break-before-001.html
printing/css2.1/page-break-after-001.html
printing/css2.1/page-break-after-002.html
printing/css2.1/page-break-before-002.html
printing/css2.1/page-break-inside-000.html
[Qt] Make possible Qt DRT get a page number for element by ID
https://bugs.webkit.org/show_bug.cgi?id=34777
- Api/qwebframe.cpp: (qt_drt_pageNumberForElementById):
2010-02-10 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Implement pageNumberForElementById() method in Qt DRT LayoutTestController,
to make Qt DRT able to get page number.
LayoutTests:
printing/page-break-always.html
printing/pageNumerForElementById.html
printing/css2.1/page-break-before-000.html
printing/css2.1/page-break-after-000.html
printing/css2.1/page-break-after-004.html
printing/css2.1/page-break-before-001.html
printing/css2.1/page-break-after-001.html
printing/css2.1/page-break-after-002.html
printing/css2.1/page-break-before-002.html
printing/css2.1/page-break-inside-000.html
[Qt] Make possible Qt DRT get a page number for element by ID
https://bugs.webkit.org/show_bug.cgi?id=34777
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::pageNumberForElementById):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 10:50 AM QtWebKitBackportingFixes edited by
- (diff)
- 10:48 AM Changeset in webkit [54611] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touch WebKit.idl to force a rebuild
- 10:47 AM Changeset in webkit [54610] by
-
- 1 edit in trunk/WebKit/win/Interfaces/IWebPreferences.idl
Committed the wrong file, had some local changes trying to fix the build
- 10:46 AM Changeset in webkit [54609] by
-
- 1 edit in trunk/WebKit/win/Interfaces/IWebPreferences.idl
Touch WebKit.idl to force a rebuild of Interfaces
- 10:37 AM Changeset in webkit [54608] by
-
- 2 edits in trunk
Add some details to the change log I just committed. (Sorry for not being more clear.)
- 10:29 AM Changeset in webkit [54607] by
-
- 7 edits2 deletes in trunk
Revert 54599
WebCore:
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype._insertChild):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.updateModifiedNodes):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode):
(WebInspector.ElementsTreeElement):
(WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
(WebInspector.ElementsTreeElement.prototype._updateChildren):
():
- inspector/front-end/inspector.css:
LayoutTests:
- inspector/elements-panel-limited-children-expected.txt: Removed.
- inspector/elements-panel-limited-children.html: Removed.
- platform/qt/Skipped:
- 10:11 AM Changeset in webkit [54606] by
-
- 6 edits in trunk/WebKit/win
2010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Support frameset flattening
https://bugs.webkit.org/show_bug.cgi?id=32717
Add support for enabling/disabling FrameSet Flattening on the Windows port.
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::isFrameSetFlatteningEnabled): (WebPreferences::setFrameSetFlatteningEnabled):
- WebPreferences.h:
- WebView.cpp: (WebView::notifyPreferencesChanged):
- 9:55 AM Changeset in webkit [54605] by
-
- 4 edits in trunk/JavaScriptCore
2010-02-10 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Fix QScriptValue::toBool.
Fix ECMA compliance in the QScriptValue for values like 0, NaN and
empty strings.
[Qt] QScriptValue::toBool problem
https://bugs.webkit.org/show_bug.cgi?id=34793
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::toBool):
- qt/tests/qscriptvalue/tst_qscriptvalue.h:
- qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: (tst_QScriptValue::toBool_initData): (tst_QScriptValue::toBool_makeData): (tst_QScriptValue::toBool_test): (tst_QScriptValue::toBoolean_initData): (tst_QScriptValue::toBoolean_makeData): (tst_QScriptValue::toBoolean_test):
- 8:51 AM Changeset in webkit [54604] by
-
- 2 edits in trunk/WebKit/win
Remove unnecessary #include of shfolder.h
shfolder.h has been deprecated in newer versions of the Windows SDK.
Fixes <http://webkit.org/b/34803> WebPreferences.cpp fails to compile
under VS2010 RC due to #include of shfolder.h.
Reviewed by Darin Adler.
- WebPreferences.cpp: Removed #include.
- 8:50 AM Changeset in webkit [54603] by
-
- 2 edits in trunk/WebCore
Fix bad paths in WebCore.vcproj
These were harmless in VS2005, but cause project conversion errors in
VS2010 RC.
Fixes <http://webkit.org/b/34801>.
Reviewed by Dan Bernstein.
- WebCore.vcproj/WebCore.vcproj: Removed leading "." from paths to
JSHTMLFrameSetElement.{cpp,h}.
- 8:36 AM Changeset in webkit [54602] by
-
- 2 edits in trunk/WebCore
Not reviewed (build fix).
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::getLastResortFallbackFont): Return a
SimpleFontData here.
- 8:28 AM Changeset in webkit [54601] by
-
- 14 edits in trunk/WebCore
Bug 23287 - Avoid using FontPlatformData outside the FontCache
Patch by Julien Chaffraix <jchaffraix@pleyo.com> on 2010-02-10
Reviewed by Eric Seidel.
No functional change, only refactored the code using FontPlatformData to use SimpleFontData.
This change leaves the class FontCached as it needs some thoughts and more refactoring.
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData): Call getCachedFontData with the 2 parameters directly.
- css/CSSFontSelector.cpp:
(WebCore::fontDataForGenericFamily): Ditto.
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::getCachedFontData): This method is meant to replace getCachedFontPlatformData
that was moved in the private section of the class. It calls getCachedFontPlatformData and cache
the returned FontPlatformData if it is not null.
(WebCore::FontCache::getFontData): Updated to use the new getCachedFontData.
- platform/graphics/FontCache.h: Updated several methods to return a SimpleFontData in lieu of a
FontPlatformData. Moved some method in the private sections.
- platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/gtk/FontCacheGtk.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/haiku/FontCacheHaiku.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
- platform/graphics/wince/FontCacheWince.cpp:
- platform/graphics/wx/FontCacheWx.cpp:
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
Updated all the previous platform methods to return a SimpleFontData.
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getSimilarFontPlatformData): Updated to return a SimpleFontData.
(WebCore::FontCache::getLastResortFallbackFont): Ditto. Also refactored the code
and moved a DEFINE_STATIC_LOCAL where it is needed.
- 8:06 AM Changeset in webkit [54600] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-02-10 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Add test to ensure that a call to history.forward() at the top of
a page doesn't prevent the page from loading when there is no
forward list.
- fast/history/forward-during-load-expected.txt: Added.
- fast/history/forward-during-load.html: Added.
- 7:45 AM Changeset in webkit [54599] by
-
- 7 edits2 adds in trunk
2010-02-10 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Elements Panel: Limit the number of initially loaded element children
https://bugs.webkit.org/show_bug.cgi?id=34421
Test: inspector/elements-panel-limited-children.html
WebCore:
- English.lproj/localizedStrings.js:
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype._insertChild):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.createTreeElementFor): (WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode): (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype.get expandedChildrenLimit): (WebInspector.ElementsTreeElement.prototype.set expandedChildrenLimit): (WebInspector.ElementsTreeElement.prototype.get expandedChildCount): (WebInspector.ElementsTreeElement.prototype.showChild): (WebInspector.ElementsTreeElement.prototype.insertChildElement): (WebInspector.ElementsTreeElement.prototype.moveChild): (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode): (WebInspector.ElementsTreeElement.prototype._updateChildren): (WebInspector.ElementsTreeElement.prototype.adjustCollapsedRange): (WebInspector.ElementsTreeElement.prototype.handleLoadAllChildren): ():
- inspector/front-end/inspector.css:
LayoutTests:
- inspector/elements-panel-limited-children-expected.txt: Added.
- inspector/elements-panel-limited-children.html: Added.
- platform/qt/Skipped:
- 7:22 AM Changeset in webkit [54598] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-10 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Chromium Win build fix. Add third_party/nss to the dependencies list on Windows.
- DEPS:
- 7:18 AM Changeset in webkit [54597] by
-
- 8 edits4 adds in trunk/WebCore
2010-02-10 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Remove several #if USE(JSC) branches. Introduce ScriptDebugServer class for
making JavaScriptDebugServer engine-agnostic.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/ScriptDebugServer.cpp: Added. (WebCore::ScriptDebugServer::recompileAllJSFunctions): (WebCore::ScriptDebugServer::recompileAllJSFunctionsSoon):
- bindings/js/ScriptDebugServer.h: Added.
- bindings/v8/ScriptDebugServer.cpp: Added. (WebCore::ScriptDebugServer::recompileAllJSFunctions): (WebCore::ScriptDebugServer::recompileAllJSFunctionsSoon):
- bindings/v8/ScriptDebugServer.h: Added.
- inspector/InspectorController.cpp: (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler):
- page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):
- 3:59 AM Changeset in webkit [54596] by
-
- 5 edits in trunk
Use derefIfNotNull() to work around WINSCW compiler forward declaration bug
Patch by Yongjun Zhang <yongjun.zhang@nokia.com> on 2009-10-06
Reviewed by Simon Hausmann.
The compiler bug is reported at
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812.
The change should be reverted when the above bug is fixed in WINSCW compiler.
JObjectWrapper::ref() and deref() made public accessible to derefIfNull().
https://bugs.webkit.org/show_bug.cgi?id=28054
- bridge/jni/jsc/JavaInstanceJSC.h:
- bridge/jni/v8/JavaInstanceV8.h:
- 3:58 AM Changeset in webkit [54595] by
-
- 2 edits in trunk/JavaScriptCore
Get rid of WINSCW hack for UnSpecifiedBoolType
Patch by Yongjun Zhang <yongjun.zhang@nokia.com> on 2009-10-06
Reviewed by Simon Hausmann.
Add parenthesis around (RefPtr::*UnspecifiedBoolType) to make the WINSCW
compiler work with the default UnSpecifiedBoolType() operator.
https://bugs.webkit.org/show_bug.cgi?id=28054
- wtf/RefPtr.h:
- 3:19 AM QtWebKitBackportingFixes edited by
- (diff)
- 3:14 AM Changeset in webkit [54594] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-10 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Rolling Chromium dependencies to match Chromium revision 38580.
- DEPS:
- 2:36 AM Changeset in webkit [54593] by
-
- 8 edits2 moves in trunk
2010-02-10 Yaar Schnitman <yaar@chromium.org>
Reviewed by Adam Barth.
Simplified RuntimeEnabledFeatures and corresponding v8 generated code
https://bugs.webkit.org/show_bug.cgi?id=34667
- WebCore.gypi:
- bindings/generic/RuntimeEnabledFeatures.cpp: Added. (WebCore::RuntimeEnabledFeatures::audioEnabled): (WebCore::RuntimeEnabledFeatures::htmlMediaElementEnabled): (WebCore::RuntimeEnabledFeatures::htmlAudioElementEnabled): (WebCore::RuntimeEnabledFeatures::htmlVideoElementEnabled): (WebCore::RuntimeEnabledFeatures::mediaErrorEnabled): (WebCore::RuntimeEnabledFeatures::sharedWorkerEnabled): (WebCore::RuntimeEnabledFeatures::webSocketEnabled): (WebCore::RuntimeEnabledFeatures::openDatabaseEnabled):
- bindings/generic/RuntimeEnabledFeatures.h: Added. (WebCore::RuntimeEnabledFeatures::setLocalStorageEnabled): (WebCore::RuntimeEnabledFeatures::localStorageEnabled): (WebCore::RuntimeEnabledFeatures::setSessionStorageEnabled): (WebCore::RuntimeEnabledFeatures::sessionStorageEnabled): (WebCore::RuntimeEnabledFeatures::setWebkitNotificationsEnabled): (WebCore::RuntimeEnabledFeatures::webkitNotificationsEnabled): (WebCore::RuntimeEnabledFeatures::setApplicationCacheEnabled): (WebCore::RuntimeEnabledFeatures::applicationCacheEnabled): (WebCore::RuntimeEnabledFeatures::setGeolocationEnabled): (WebCore::RuntimeEnabledFeatures::geolocationEnabled): (WebCore::RuntimeEnabledFeatures::setIndexedDBEnabled): (WebCore::RuntimeEnabledFeatures::indexedDBEnabled): (WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
- bindings/scripts/CodeGenerator.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/RuntimeEnabledFeatures.cpp: Removed.
- bindings/v8/RuntimeEnabledFeatures.h: Removed.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8NavigatorCustom.cpp:
- bindings/v8/custom/V8WorkerContextCustom.cpp:
- 2:25 AM Changeset in webkit [54592] by
-
- 12 edits in trunk/WebKit/chromium
2010-02-10 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Use v8::Debug::ProcessDebugMessages instead of executing an empty function
- src/DebuggerAgent.h:
- src/DebuggerAgentImpl.cpp: (WebKit::DebuggerAgentImpl::processDebugCommands):
- src/DebuggerAgentImpl.h:
- src/ToolsAgent.h:
- src/WebDevToolsAgentImpl.cpp:
- src/WebDevToolsAgentImpl.h:
- src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.addBreakpoint):
- src/js/DevToolsHostStub.js: (.RemoteDebuggerAgentStub.prototype.processDebugCommands):
- src/js/InjectDispatch.js: (dispatch):
- src/js/ProfilerAgent.js: (devtools.ProfilerAgent.prototype.startProfiling): (devtools.ProfilerAgent.prototype.stopProfiling):
- src/js/Tests.js:
- 1:56 AM Changeset in webkit [54591] by
-
- 9 edits2 adds in trunk/WebCore
2010-02-09 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Add two basic categories for the Audits panel
https://bugs.webkit.org/show_bug.cgi?id=32930
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/AuditCategories.js: Added. (WebInspector.AuditCategories.PagePerformance): (WebInspector.AuditCategories.PagePerformance.prototype.initialize): (WebInspector.AuditCategories.NetworkUtilization): (WebInspector.AuditCategories.NetworkUtilization.prototype.initialize):
- inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype.updateResourceTrackingState): (WebInspector.AuditLauncherView.prototype._createLauncherUI): (WebInspector.AuditLauncherView.prototype.show):
- inspector/front-end/AuditRules.js: Added. (WebInspector.AuditRules.arrayAsUL): (WebInspector.AuditRules.getDomainToResourcesMap): (WebInspector.AuditRules.evaluateInTargetWindow): (WebInspector.AuditRules.GzipRule): (WebInspector.AuditRules.GzipRule.prototype.doRun): (WebInspector.AuditRules.GzipRule.prototype._isCompressed): (WebInspector.AuditRules.GzipRule.prototype._shouldCompress): (WebInspector.AuditRules.CombineExternalResourcesRule): (WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun): (WebInspector.AuditRules.CombineJsResourcesRule): (WebInspector.AuditRules.CombineCssResourcesRule): (WebInspector.AuditRules.MinimizeDnsLookupsRule): (WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun): (WebInspector.AuditRules.ParallelizeDownloadRule): (WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun): (WebInspector.AuditRules.UnusedCssRule): (WebInspector.AuditRules.UnusedCssRule.prototype._getUnusedStylesheetRatioMessage): (WebInspector.AuditRules.UnusedCssRule.prototype._getUnusedTotalRatioMessage): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.routine): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun): (WebInspector.AuditRules.CacheControlRule): (WebInspector.AuditRules.CacheControlRule.prototype.InfoCheck.1.FailCheck.0.WarningCheck.1.SevereCheck.2.doRun): (WebInspector.AuditRules.CacheControlRule.prototype.handleNonCacheableResources): (WebInspector.AuditRules.CacheControlRule.prototype._cacheableAndNonCacheableResources): (WebInspector.AuditRules.CacheControlRule.prototype.execCheck): (WebInspector.AuditRules.CacheControlRule.prototype.freshnessLifetimeGreaterThan): (WebInspector.AuditRules.CacheControlRule.prototype.responseHeader): (WebInspector.AuditRules.CacheControlRule.prototype.hasResponseHeader): (WebInspector.AuditRules.CacheControlRule.prototype.isCompressible): (WebInspector.AuditRules.CacheControlRule.prototype.isPubliclyCacheable): (WebInspector.AuditRules.CacheControlRule.prototype.responseHeaderMatch): (WebInspector.AuditRules.CacheControlRule.prototype.hasExplicitExpiration): (WebInspector.AuditRules.CacheControlRule.prototype._isExplicitlyNonCacheable): (WebInspector.AuditRules.CacheControlRule.prototype.isCacheableResource): (WebInspector.AuditRules.BrowserCacheControlRule): (WebInspector.AuditRules.BrowserCacheControlRule.prototype.handleNonCacheableResources): (WebInspector.AuditRules.BrowserCacheControlRule.prototype.runChecks): (WebInspector.AuditRules.BrowserCacheControlRule.prototype._missingExpirationCheck): (WebInspector.AuditRules.BrowserCacheControlRule.prototype._varyCheck): (WebInspector.AuditRules.BrowserCacheControlRule.prototype._oneMonthExpirationCheck): (WebInspector.AuditRules.BrowserCacheControlRule.prototype._oneYearExpirationCheck): (WebInspector.AuditRules.ProxyCacheControlRule): (WebInspector.AuditRules.ProxyCacheControlRule.prototype.runChecks): (WebInspector.AuditRules.ProxyCacheControlRule.prototype._questionMarkCheck): (WebInspector.AuditRules.ProxyCacheControlRule.prototype._publicCachingCheck): (WebInspector.AuditRules.ProxyCacheControlRule.prototype._setCookieCacheableCheck): (WebInspector.AuditRules.ImageDimensionsRule): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.routine.hasDimension): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.routine.hasWidth): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.routine.hasHeight): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.routine): (WebInspector.AuditRules.CssInHeadRule): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.routine.allViews): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.routine): (WebInspector.AuditRules.StylesScriptsOrderRule): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.routine): (WebInspector.AuditRules.CookieRuleBase): (WebInspector.AuditRules.CookieRuleBase.prototype.doRun.resultCallback): (WebInspector.AuditRules.CookieRuleBase.prototype.doRun): (WebInspector.AuditRules.CookieRuleBase.prototype.mapResourceCookies): (WebInspector.AuditRules.CookieRuleBase.prototype._callbackForResourceCookiePairs): (WebInspector.AuditRules.CookieSizeRule): (WebInspector.AuditRules.CookieSizeRule.prototype._average): (WebInspector.AuditRules.CookieSizeRule.prototype._max): (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies): (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies.avgSizeSorter): (WebInspector.AuditRules.StaticCookielessRule): (WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies): (WebInspector.AuditRules.StaticCookielessRule.prototype._collectorCallback):
- inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._constructCategories): (WebInspector.AuditsPanel.prototype._reloadResources): (WebInspector.AuditsPanel.prototype.show): (WebInspector.AuditsPanel.prototype._updateLauncherViewControls): (WebInspector.AuditCategory): (WebInspector.AuditCategory.prototype.get id): (WebInspector.AuditCategory.prototype.get ruleCount): (WebInspector.AuditCategory.prototype.runRules): (WebInspector.AuditCategory.prototype._ensureInitialized): (WebInspector.AuditCategoryResult):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/audits.css:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.addPanelToolbarIcon): (WebInspector.documentKeyDown):
- 1:51 AM Changeset in webkit [54590] by
-
- 3 edits in trunk/WebKitTools
Make run-iexploder-tests work on Linux.
https://bugs.webkit.org/show_bug.cgi?id=34748
Reviewed by Adam Barth.
Extract the platform dependant Apache configuration checking code in httpd.pm to a separate function
called getHTTPDConfigPathForTestDirectory and use run-launcher instead of run-safari if run on Linux.
- Scripts/run-iexploder-tests:
- Scripts/webkitperl/httpd.pm:
- 1:33 AM QtWebKitBackportingFixes edited by
- (diff)
- 1:23 AM Changeset in webkit [54589] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-10 Tony Chang <tony@chromium.org>
Unreviewed, build fix for Chromium Mac take 2.
- src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::removeSuggestionAtIndex):
- 1:17 AM Changeset in webkit [54588] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-10 Tony Chang <tony@chromium.org>
Unreviewed, build fix for Chromium Mac.
- src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::removeSuggestionAtIndex):
- 12:36 AM Changeset in webkit [54587] by
-
- 11 edits in trunk
2010-02-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Freeze sandbox attributes on creation
https://bugs.webkit.org/show_bug.cgi?id=34184
Test that allow-forms is frozen on document creation.
- fast/frames/resources/sandboxed-iframe-form-dynamic-allowed.html: Added.
- fast/frames/resources/sandboxed-iframe-form-dynamic-disallowed.html: Added.
- fast/frames/sandboxed-iframe-forms-dynamic-expected.txt: Added.
- fast/frames/sandboxed-iframe-forms-dynamic.html: Added.
2010-02-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Freeze sandbox attributes on creation
https://bugs.webkit.org/show_bug.cgi?id=34184
This is how the spec works now.
Test: fast/frames/sandboxed-iframe-forms-dynamic.html
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::canExecuteScripts):
- bindings/generic/BindingDOMWindow.h: (WebCore::::createWindow):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow):
- dom/Document.cpp:
- dom/Document.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::requestObject): (WebCore::FrameLoader::shouldAllowNavigation): (WebCore::FrameLoader::updateSandboxFlags):
- page/SecurityOrigin.cpp:
- page/SecurityOrigin.h:
Feb 9, 2010:
- 11:44 PM WebKit Team edited by
- (diff)
- 8:48 PM Changeset in webkit [54586] by
-
- 7 edits1 copy3 adds in trunk/WebKit/chromium
2010-02-09 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Refactor AutocompletePopupMenuClient into a base class,
SuggestionsPopupMenuClient, and two derived classes,
AutocompletePopupMenuClient and AutoFillPopupMenuClient. Currently
the behavior of suggestions popups has not changed.
- WebKit.gyp:
- public/WebView.h:
- src/AutoFillPopupMenuClient.cpp: Added.
- src/AutoFillPopupMenuClient.h: Added.
- src/AutocompletePopupMenuClient.cpp: (WebKit::AutocompletePopupMenuClient::getSuggestionsCount): (WebKit::AutocompletePopupMenuClient::getSuggestion): (WebKit::AutocompletePopupMenuClient::removeSuggestionAtIndex): (WebKit::AutocompletePopupMenuClient::initialize): (WebKit::AutocompletePopupMenuClient::setSuggestions):
- src/AutocompletePopupMenuClient.h:
- src/SuggestionsPopupMenuClient.cpp: Added.
- src/SuggestionsPopupMenuClient.h: Added.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::autocompleteHandleKeyEvent): (WebKit::WebViewImpl::applyAutofillSuggestions): (WebKit::WebViewImpl::applyAutoFillSuggestions): (WebKit::WebViewImpl::applyAutocompleteSuggestions):
- src/WebViewImpl.h:
- 8:23 PM Changeset in webkit [54585] by
-
- 2 edits in trunk/WebCore
2010-02-09 Ariya Hidayat <ariya.hidayat@gmail.com>
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] Remove old, outdated unused code block.
- platform/graphics/qt/GraphicsContextQt.cpp:
- 8:13 PM BuildingQtOnLinux edited by
- (diff)
- 8:01 PM Changeset in webkit [54584] by
-
- 7 edits in trunk
2010-02-09 Chris Guillory <ctguil@google.com>
Reviewed by Darin Fisher.
[Chromium] Notify ChromeClientChromium of state change notifications.
- accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::toChromeClientChromium): (WebCore::AXObjectCache::postPlatformNotification):
- page/chromium/ChromeClientChromium.h:
2010-02-09 Chris Guillory <ctguil@google.com>
Reviewed by Darin Fisher.
[Chromium] Add function for accessibility object state change notifications.
- gyp_webkit:
- public/WebViewClient.h: (WebKit::WebViewClient::didChangeAccessibilityObjectState):
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::didChangeAccessibilityObjectState):
- src/ChromeClientImpl.h:
- 7:45 PM Changeset in webkit [54583] by
-
- 2 edits1 add in trunk/WebCore
2010-02-09 Kwang Yul Seo <skyul@company100.net>
Reviewed by Adam Barth.
[BREWMP] Port PlatformMouseEvent
https://bugs.webkit.org/show_bug.cgi?id=34600
Retrieve the event type, position, key modifiers, time stamp
and click count from AEEEvent.
- platform/PlatformMouseEvent.h:
- platform/brew/PlatformMouseEventBrew.cpp: Added. (WebCore::PlatformMouseEvent::PlatformMouseEvent):
- 7:25 PM Changeset in webkit [54582] by
-
- 2 edits in trunk/WebCore
2010-02-09 Avi Drissman <avi@chromium.org>
Reviewed by Timothy Hatcher.
[Chromium] RenderTheme does not draw focus rings on SL for checkboxes, radio buttons
https://bugs.webkit.org/show_bug.cgi?id=34544
Covered by layout tests when run on SL.
- platform/chromium/ThemeChromiumMac.mm: (-[TCMVisibleView _focusRingVisibleRect]): (-[TCMVisibleView _focusRingClipAncestor]): (FocusIndicationFix::currentOSHasSetFocusRingStyleInBitmapBug): (FocusIndicationFix::swizzleFocusView): (FocusIndicationFix::ScopedFixer::ScopedFixer): (FocusIndicationFix::ScopedFixer::~ScopedFixer): (+[NSView TCMInterposing_focusView]): (WebCore::paintCheckbox): (WebCore::paintRadio): (WebCore::paintButton):
- 7:09 PM Changeset in webkit [54581] by
-
- 4 edits in trunk/WebCore
2010-02-09 Anton Muhin <antonm@chromium.org>
Reviewed by Nate Chapin.
[v8] Check if returned wrapper is empty before operating on it.
https://bugs.webkit.org/show_bug.cgi?id=34746
- bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::toV8):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::toV8):
- bindings/v8/custom/V8SVGDocumentCustom.cpp: (WebCore::toV8):
- 6:53 PM Changeset in webkit [54580] by
-
- 4 edits in trunk/JavaScriptCore
2010-02-09 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
New functions nullValue() and undefinedValue().
[Qt] QScriptEngine should contain nullValue and undefinedValue methods
https://bugs.webkit.org/show_bug.cgi?id=34749
- qt/api/qscriptengine.cpp: (QScriptEngine::nullValue): (QScriptEngine::undefinedValue):
- qt/api/qscriptengine.h:
- qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::nullValue): (tst_QScriptEngine::undefinedValue):
- 6:36 PM Changeset in webkit [54579] by
-
- 4 edits in trunk/JavaScriptCore
2010-02-09 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Fixes for QScriptValue::toNumber().
Fix ECMA compliance in QScriptValue for values unbound
to a QScriptEngine.
[Qt] QScriptValue::toNumber() is broken
https://bugs.webkit.org/show_bug.cgi?id=34592
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::toNumber):
- qt/tests/qscriptvalue/tst_qscriptvalue.h:
- qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: (tst_QScriptValue::toNumber_initData): (tst_QScriptValue::toNumber_makeData): (tst_QScriptValue::toNumber_test):
- 6:29 PM Changeset in webkit [54578] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Unit test for window.runModalDialog
https://bugs.webkit.org/show_bug.cgi?id=34755
Reviewed by Adam Barth.
- tests/qwebpage/tst_qwebpage.cpp:
- 6:19 PM Changeset in webkit [54577] by
-
- 4 edits in trunk/JavaScriptCore
2010-02-09 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Simon Hausmann.
Fix QScriptValue::isNumber().
The isNumber() should return 'true' if the value is in the CNumber
state.
[Qt] QScriptValue::isNumber() returns an incorrect value
https://bugs.webkit.org/show_bug.cgi?id=34575
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::isNumber):
- qt/tests/qscriptvalue/tst_qscriptvalue.h:
- qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: (tst_QScriptValue::isNumber_initData): (tst_QScriptValue::isNumber_makeData): (tst_QScriptValue::isNumber_test):
- 6:02 PM Changeset in webkit [54576] by
-
- 12 edits in trunk
2010-02-09 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Continuing debugger and profiler unforking: narrow scope of JSC-specific ifdefs.
Also, enable JAVASCRIPT_DEBUGGER explicitly in features, it appears to be required
for really enabling it in V8 bindings generation.
- inspector/InjectedScriptHost.idl:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::currentCallFrame): (WebCore::InspectorBackend::getProfile):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::addProfile): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::pausedScript): (WebCore::InspectorFrontend::resumedScript): (WebCore::InspectorFrontend::profilerWasEnabled): (WebCore::InspectorFrontend::profilerWasDisabled): (WebCore::InspectorFrontend::didGetProfile):
- inspector/InspectorFrontend.h:
- page/Console.idl:
2010-02-09 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Continuing debugger and profiler unforking: narrow scope of JSC-specific ifdefs.
Also, enable JAVASCRIPT_DEBUGGER explicitly in features, it appears to be required
for really enabling it in V8 bindings generation.
- features.gypi:
- 5:43 PM Changeset in webkit [54575] by
-
- 2 edits in trunk/WebKit/qt
2010-02-09 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Sync with API changes in Maemo 5 kinetic scrolling
This is a forward-port of http://qt.gitorious.org/+qt-developers/qt/x11-maemo/commit/08497561
- Api/qwebview.cpp: (qt_sendSpontaneousEvent): (QWebViewKineticScroller::QWebViewKineticScroller): (QWebViewKineticScroller::setWidget): (QWebViewKineticScroller::eventFilter): (QWebViewKineticScroller::cancelLeftMouseButtonPress): (QWebViewKineticScroller::currentFrame): (QWebViewKineticScroller::scrollingFrameAt): (QWebViewKineticScroller::maximumScrollPosition): (QWebViewKineticScroller::scrollPosition): (QWebViewKineticScroller::viewportSize): (QWebViewKineticScroller::setScrollPosition): (QWebViewKineticScroller::sendEvent): (QWebView::QWebView):
- 4:28 PM Changeset in webkit [54574] by
-
- 3 edits in trunk/JavaScriptCore
Small refactoring to the small strings cache to allow it to be cleared
dynamically.
Reviewed by Oliver Hunt.
- runtime/SmallStrings.cpp:
(JSC::SmallStrings::SmallStrings):
(JSC::SmallStrings::clear):
- runtime/SmallStrings.h: Moved initialization code into a shared function,
and changed the constructor to call it.
- 4:14 PM Changeset in webkit [54573] by
-
- 5 edits in trunk
[Qt] Unreviewed. Roll-out r54543, because layout tests crash in debug mode.
https://bugs.webkit.org/show_bug.cgi?id=34713
WebKitTools:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
- DumpRenderTree/qt/main.cpp:
(main):
LayoutTests:
- platform/qt/Skipped:
- 3:28 PM Changeset in webkit [54572] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed trivial fix.
platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt updated
by r54560. Qt platform specific expected file should be updated too.
- platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt: Updated.
- 3:26 PM Changeset in webkit [54571] by
-
- 12 edits in trunk
Rubber Stamped by Geoff Garen.
Rename StringBuilder::release && JSStringBuilder::releaseJSString
to 'build()'.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
- runtime/Executable.cpp:
(JSC::FunctionExecutable::paramString):
- runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::decode):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape):
- runtime/JSONObject.cpp:
(JSC::Stringifier::stringify):
- runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::build):
- runtime/LiteralParser.cpp:
(JSC::LiteralParser::Lexer::lexString):
- runtime/NumberPrototype.cpp:
(JSC::integerPartNoExp):
(JSC::numberProtoFuncToFixed):
- runtime/StringBuilder.h:
(JSC::StringBuilder::build):
WebCore:
- bindings/js/ScriptString.h:
(WebCore::ScriptString::operator+=):
- 3:01 PM Changeset in webkit [54570] by
-
- 5 edits in branches/safari-4-branch/WebKit/mac
Merge r54447.
- 2:58 PM Changeset in webkit [54569] by
-
- 2 edits in trunk/LayoutTests
[Qt] fast/events/multiline-link-arrow-navigation.html introduced in r54566, but our
LayoutTestController::overridePreference() does not support the 'WebKitEnableCaretBrowsing' preference now.
- platform/qt/Skipped: fast/events/multiline-link-arrow-navigation.html skipped.
- 2:48 PM Changeset in webkit [54568] by
-
- 3 edits5 copies in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] window.showModalDialog implemented by r54550. Some tests pass now, so expected files updated.
(We need some new platform specific expected file, because this feature works only on Qt port now.)
https://bugs.webkit.org/show_bug.cgi?id=25585
- platform/qt/fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Copied from LayoutTests/fast/dom/Window/window-function-frame-getter-precedence-expected.txt.
- platform/qt/fast/dom/Window/window-function-name-getter-precedence-expected.txt: Copied from LayoutTests/fast/dom/Window/window-function-name-getter-precedence-expected.txt.
- platform/qt/fast/dom/Window/window-lookup-precedence-expected.txt: Copied from LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt.
- platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
- platform/qt/fast/dom/prototype-inheritance-expected.txt: Updated.
- platform/qt/http/tests/security/cross-frame-access-call-expected.txt: Copied from LayoutTests/http/tests/security/cross-frame-access-call-expected.txt.
- cross-frame-access-call-expected.txt might be a false expected file, it needs more investigation.
- platform/qt/http/tests/security/cross-frame-access-get-expected.txt: Copied from LayoutTests/http/tests/security/cross-frame-access-get-expected.txt.
- 2:23 PM Changeset in webkit [54567] by
-
- 4 edits4 adds in trunk
<rdar://problem/7400160> Netscape plug-ins are not instantiated on property access if there are pending stylesheets
https://bugs.webkit.org/show_bug.cgi?id=34776
Reviewed by Anders Carlsson.
WebCore:
Tests: plugins/instance-available-before-stylesheets-loaded-object.html
plugins/instance-available-before-stylesheets-loaded.html
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::renderWidgetForJSBindings): Call
updateLayoutIgnorePendingStylesheets() before checking for a renderer.
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::renderWidgetForJSBindings): Ditto.
LayoutTests:
- plugins/instance-available-before-stylesheets-loaded-expected.txt: Added.
- plugins/instance-available-before-stylesheets-loaded-object-expected.txt: Added.
- plugins/instance-available-before-stylesheets-loaded-object.html: Added.
- plugins/instance-available-before-stylesheets-loaded.html: Added.
- 12:51 PM Changeset in webkit [54566] by
-
- 3 edits2 adds in trunk
Problems navigating by caret in links whose text wraps onto
subsequent lines.
https://bugs.webkit.org/show_bug.cgi?id=25676
Reviewed by Darin Adler.
WebCore:
We should not search ahead if we are not in the last element.
- dom/Position.cpp:
LayoutTests:
Added tests showing the problem.
- fast/events/multiline-link-arrow-navigation.html
- fast/events/multiline-link-arrow-navigation-expected.txt
- 12:50 PM Changeset in webkit [54565] by
-
- 4 edits1 add in trunk/WebKit/chromium
[chromium] Add the chromium interface to support Blob.slice.
https://bugs.webkit.org/show_bug.cgi?id=34652
Reviewed by Darin Fisher.
- WebKit.gyp:
- public/WebFileInfo.h: Added.
- public/WebHTTPBody.h:
- src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendFile):
- 12:46 PM Changeset in webkit [54564] by
-
- 8 edits in trunk/WebCore
2010-02-09 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
More optimization for AffineTransform with SVG
https://bugs.webkit.org/show_bug.cgi?id=34774
Some optimizations to safe unnecessary summations and multiplications.
Optimize AffineTransform to handle an identity or translation matrix
more efficient.
Added translationRight to avoid multiplications of matrices as much as
possible.
No tests added, no change of functionality.
- platform/graphics/transforms/AffineTransform.cpp: (WebCore::AffineTransform::inverse): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::translateRight):
- platform/graphics/transforms/AffineTransform.h:
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::translationForAttributes): (WebCore::RenderForeignObject::localToParentTransform):
- rendering/RenderForeignObject.h:
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::localToBorderBoxTransform): (WebCore::RenderSVGRoot::localToRepaintContainerTransform): (WebCore::RenderSVGRoot::localToParentTransform):
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::localToParentTransform):
- rendering/SVGRootInlineBox.cpp: (WebCore::applyTextLengthCorrectionToTextChunk):
- 12:06 PM Changeset in webkit [54563] by
-
- 2 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=34772
Overzealous new assertion in URStringImpl::adopt()
Reviewed by Adam Barth.
- runtime/UStringImpl.h:
(JSC::UStringImpl::adopt):
Only assert that vector.data() is non-zero if vector.size() is non-zero.
- 12:05 PM Changeset in webkit [54562] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=34771
A stray mouse moved event is sent to plug-ins after mouse exit
- WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): A mouseout DOM event is dispatched while handling NSMouseMoved - but we shouldn't be sending a mouse moved event to plug-ins at this point.
- 10:48 AM Changeset in webkit [54561] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Set GtkAdjustments on our FrameView when loading a page in the PageCache
https://bugs.webkit.org/show_bug.cgi?id=34754
Test that lower, and upper bounds are kept when goibg back with
page cache enabled, and disabled. Page cache behaviour is still a
bit broken (see FIXME).
- tests/testwebview.c: (server_callback): (map_event_cb): (do_test_webkit_web_view_adjustments): (test_webkit_web_view_adjustments): (main):
- 10:33 AM Changeset in webkit [54560] by
-
- 23 edits12 adds in trunk
2010-02-09 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG patterns with some scale patternTransform are not displayed correctly for small elements
https://bugs.webkit.org/show_bug.cgi?id=25484
SVG Pattern size was clipped to the size of the target, if the pattern is bigger than the target. This
causes problems, if the patternTransform scales the pattern. This patch deletes the clipping.
Tests: svg/custom/pattern-excessive-malloc.svg
svg/custom/pattern-size-bigger-than-target-size.svg
svg/custom/pattern-skew-transformed.svg
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern):
2010-02-09 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG patterns with some scale patternTransform are not displayed correctly for small elements
https://bugs.webkit.org/show_bug.cgi?id=25484
The old DRT results gave back a pattern size of 1x1. That was not very useful.
The new reuslts are much more useful.
- platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
- platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
- platform/mac/svg/batik/paints/patternRegions-expected.txt:
- platform/mac/svg/custom/deep-dynamic-updates-expected.txt:
- platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.txt:
- platform/mac/svg/custom/js-late-pattern-creation-expected.txt:
- platform/mac/svg/custom/js-update-pattern-child-expected.txt:
- platform/mac/svg/custom/js-update-pattern-expected.txt:
- platform/mac/svg/custom/pattern-cycle-detection-expected.txt:
- platform/mac/svg/custom/pattern-deep-referencing-expected.txt:
- platform/mac/svg/custom/pattern-excessive-malloc-expected.checksum: Added.
- platform/mac/svg/custom/pattern-excessive-malloc-expected.png: Added.
- platform/mac/svg/custom/pattern-excessive-malloc-expected.txt: Added.
- platform/mac/svg/custom/pattern-in-defs-expected.txt:
- platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.checksum: Added.
- platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.png: Added.
- platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Added.
- platform/mac/svg/custom/pattern-skew-transformed-expected.checksum: Added.
- platform/mac/svg/custom/pattern-skew-transformed-expected.png: Added.
- platform/mac/svg/custom/pattern-skew-transformed-expected.txt: Added.
- platform/mac/svg/custom/pattern-with-transformation-expected.txt:
- platform/mac/svg/custom/pattern-y-offset-expected.txt:
- platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/mac/svg/custom/stroked-pattern-expected.txt:
- platform/mac/svg/custom/transformedMaskFails-expected.png:
- platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- svg/custom/pattern-excessive-malloc.svg: Added.
- svg/custom/pattern-size-bigger-than-target-size.svg: Added.
- svg/custom/pattern-skew-transformed.svg: Added.
- 10:22 AM Changeset in webkit [54559] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-09 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Set GtkAdjustments on our FrameView when loading a page in the PageCache
https://bugs.webkit.org/show_bug.cgi?id=34754
Set the Gtk Adjustments of the FrameViews when they are restored
from the PageCache too. Right we only do it for the newly created
FrameViews in transitionToCommittedForNewPage, but we it also
needs to be done in the equilavent transition method for cached
pages.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup): (WebKit::FrameLoaderClient::transitionToCommittedFromCachedFrame): (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
- 10:22 AM Changeset in webkit [54558] by
-
- 2 edits in trunk/LayoutTests
2010-02-09 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Update Qt specific DRT result after AffineTransform patch.
- platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- 10:21 AM Changeset in webkit [54557] by
-
- 2 edits in trunk/WebCore
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleDidChange): Fixed typo in comment.
- 8:53 AM Changeset in webkit [54556] by
-
- 21 edits4 adds in trunk
2010-02-09 MORITA Hajime <morrita@gmail.com>
Reviewed by Nikolas Zimmermann.
SVG selection text foreground colour does not respect user settings
https://bugs.webkit.org/show_bug.cgi?id=15997
Add two subphases SVGTextPaintSubphaseGlyphFillSelection and
SVGTextPaintSubphaseGlyphStrokeSelection for painting selected
text on SVG. Selected texts are painted with style from
getCachedPseudoStyle() instead of style().
Tests: svg/text/selection-styles.xhtml
- rendering/SVGCharacterLayoutInfo.h: (WebCore::SVGTextChunkWalker::SVGTextChunkWalker): (WebCore::SVGTextChunkWalker::setupFillSelection): (WebCore::SVGTextChunkWalker::setupStrokeSelection):
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::mayHaveSelection): (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupFillSelectionCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupStrokeSelectionCallback): (WebCore::SVGRootInlineBoxPaintWalker::activePaintServer): (WebCore::SVGRootInlineBox::paint): (WebCore::SVGRootInlineBox::walkTextChunks):
- rendering/SVGInlineTextBox.h: (WebCore::): Add callback hooks and its implementation for handle new subphases.
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::chunkSelectionStartEnd): (WebCore::SVGInlineTextBox::paintCharacters): Split box text into selected part and non-selected part, and use separate subphases to paint them.
- svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk): Relax ASSERT() condition to accept a part of text.
- svg/graphics/SVGPaintServer.cpp: (WebCore::applyStrokeStyleToContext): (WebCore::SVGPaintServer::setup):
- svg/graphics/SVGPaintServer.h:
- svg/graphics/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::setup):
- svg/graphics/SVGPaintServerGradient.h:
- svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setup):
- svg/graphics/SVGPaintServerPattern.h:
- svg/graphics/SVGPaintServerSolid.cpp: (WebCore::SVGPaintServerSolid::setup):
- svg/graphics/SVGPaintServerSolid.h: Change setup() signature to accept RenderStyle instead of always using RenderObject::style().
2010-02-09 MORITA Hajime <morrita@gmail.com>
Reviewed by Nikolas Zimmermann.
SVG selection text foreground colour does not respect user settings
https://bugs.webkit.org/show_bug.cgi?id=15997
Add two subphases SVGTextPaintSubphaseGlyphFillSelection and
SVGTextPaintSubphaseGlyphStrokeSelection for painting SVG text
selection. texts are painted with style from getCachedPseudoStyle() instead of style().
- platform/mac/svg/text/selection-styles-expected.checksum: Added.
- platform/mac/svg/text/selection-styles-expected.png: Added.
- platform/mac/svg/text/selection-styles-expected.txt: Added.
- platform/mac/svg/text/text-deco-01-b-expected.checksum: Updated pixel tests to account for marginal painting differences.
- platform/mac/svg/text/text-deco-01-b-expected.png: Ditto.
- platform/mac/svg/text/text-path-01-b-expected.checksum: Dito.
- platform/mac/svg/text/text-path-01-b-expected.png: Ditto.
- platform/mac/svg/text/text-text-03-b-expected.checksum: Ditto.
- platform/mac/svg/text/text-text-03-b-expected.png: Ditto.
- svg/text/selection-styles.xhtml: Added.
- 8:36 AM Changeset in webkit [54555] by
-
- 1 edit1 add in trunk/WebKit/chromium
2010-02-09 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Follow-up fix.
Add missing devTools.css file.
- src/js/devTools.css: Added.
- 8:34 AM Changeset in webkit [54554] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Try to fix build problem on SnowLeopard slaves to bring them back.
- API/JSClassRef.cpp: (tryCreateStringFromUTF8): Mark method as 'static inline' to suppress "warning: no previous prototype for ..."
- 8:27 AM Changeset in webkit [54553] by
-
- 2 edits in trunk/WebKitTools
Unreviewed; added myself to committers
- Scripts/webkitpy/committers.py:
- 8:27 AM Changeset in webkit [54552] by
-
- 2 edits11 adds in trunk/WebKit/chromium
2010-02-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Upstream DevTools Images and .css files.
- WebKit.gypi:
- src/js/DevTools.css: Added.
- src/js/Images/segmentChromium.png: Added.
- src/js/Images/segmentHoverChromium.png: Added.
- src/js/Images/segmentHoverEndChromium.png: Added.
- src/js/Images/segmentSelectedChromium.png: Added.
- src/js/Images/segmentSelectedEndChromium.png: Added.
- src/js/Images/statusbarBackgroundChromium.png: Added.
- src/js/Images/statusbarBottomBackgroundChromium.png: Added.
- src/js/Images/statusbarButtonsChromium.png: Added.
- src/js/Images/statusbarMenuButtonChromium.png: Added.
- src/js/Images/statusbarMenuButtonSelectedChromium.png: Added.
- 8:08 AM Changeset in webkit [54551] by
-
- 18 edits46 adds in trunk
2010-02-09 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
No scroll bars are displayed for standalone SVG image
https://bugs.webkit.org/show_bug.cgi?id=11225
Height and width defined for svg element are not honored
https://bugs.webkit.org/show_bug.cgi?id=24033
SVG file does not pan and has no scroll bars
https://bugs.webkit.org/show_bug.cgi?id=24448
Adapt to SVG 1.1 errata to change the overflow handling:
Replace "svg { overflow: hidden }" by "svg:not(:root) { overflow: hidden }" to allow standalone SVG documents to contain scrolllbars.
Agreed by SVG WG to make this the default behaviour, already implemented by Opera & FireFox (partial support).
Add new tests in svg/overflow covering all special SVG css overflow handling rules on inner/outer svg elements.
Tests: svg/overflow/overflow-on-inner-svg-element-defaults.svg
svg/overflow/overflow-on-inner-svg-element.svg
svg/overflow/overflow-on-outermost-svg-element-defaults.svg
svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1.svg
svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2.svg
svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3.svg
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll.xhtml
svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible.xhtml
- css/svg.css: Change default <svg> overflow rule to only apply to inner <svg> elements.
- page/FrameView.cpp: (WebCore::FrameView::layout): Only apply overflow rules for non-standalone SVG documents.
- rendering/RenderSVGRoot.cpp: Remove all calls to isOverflowHidden - it's always the case for the outermost SVG element, see spec + errata. (WebCore::RenderSVGRoot::paint): Always clip to initial viewport size. (WebCore::RenderSVGRoot::computeRectForRepaint): Ditto. (WebCore::RenderSVGRoot::nodeAtPoint): Simplify.
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::applyViewportClip): Use isOverflowHidden() instead of a manual oveflow query and clip in float precision.
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::isOverflowHidden): Simplify implementation, assure the function is not called anymore for RenderSVGRoot objects.
- 7:55 AM Changeset in webkit [54550] by
-
- 6 edits in trunk
[Qt] Webkit in Qt does not have window.showModalDialog
https://bugs.webkit.org/show_bug.cgi?id=25585
Reviewed by Kenneth Rohde Christiansen.
WebKit/qt:
Create a new eventloop when runModal() is called.
Added comemnt in QWebPage::createWindow that the application is responsible
for setting the modality of the appropriate window.
- Api/qwebpage.cpp:
- WebCoreSupport/ChromeClientQt.cpp:
- WebCoreSupport/ChromeClientQt.h:
WebKitTools:
Set the modality flag when createWindow is called with window type WebWindowDialog.
- QtLauncher/main.cpp:
- 7:30 AM Changeset in webkit [54549] by
-
- 2 edits in trunk/WebKitTools
Unreviewed trivial warning fix.
- Scripts/build-webkit:
- 7:22 AM Changeset in webkit [54548] by
-
- 2 edits in trunk/WebKitTools
Add possibility of passing parameters to build-webkit by environment variable,
because the buildbot slaves can't control the arguments.
Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-02-09
Reviewed by Tor Arne Vestbø.
- Scripts/build-webkit:
- 7:15 AM Changeset in webkit [54547] by
-
- 1 edit11 adds in trunk/WebKit/chromium
2010-02-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Upstream JavaScript part of DevTools WebKit API implementation(now
with the added files).
- 7:13 AM QtWebKitBackportingFixes edited by
- (diff)
- 7:03 AM Changeset in webkit [54546] by
-
- 1 edit in trunk/WebKit/chromium/ChangeLog
2010-02-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Upstream JavaScript part of DevTools WebKit API implementation
- WebKit.gypi: Added.
- src/js/DebuggerAgent.js: Added. (devtools.DebuggerAgent): (devtools.DebuggerAgent.prototype.reset): (devtools.DebuggerAgent.prototype.initUI): (devtools.DebuggerAgent.prototype.resolveScriptSource.this.requestSeqToCallback_.cmd.getSequenceNumber): (devtools.DebuggerAgent.prototype.resolveScriptSource): (devtools.DebuggerAgent.prototype.pauseExecution): (devtools.DebuggerAgent.prototype.addBreakpoint): (devtools.DebuggerAgent.prototype.removeBreakpoint): (devtools.DebuggerAgent.prototype.updateBreakpoint): (devtools.DebuggerAgent.prototype.stepIntoStatement): (devtools.DebuggerAgent.prototype.stepOutOfFunction): (devtools.DebuggerAgent.prototype.stepOverStatement): (devtools.DebuggerAgent.prototype.resumeExecution): (devtools.DebuggerAgent.prototype.createExceptionMessage_): (devtools.DebuggerAgent.prototype.showPendingExceptionMessage_): (devtools.DebuggerAgent.prototype.clearExceptionMessage_): (devtools.DebuggerAgent.prototype.pauseOnExceptions): (devtools.DebuggerAgent.prototype.setPauseOnExceptions): (devtools.DebuggerAgent.prototype.requestEvaluate): (devtools.DebuggerAgent.prototype.resolveChildren): (devtools.DebuggerAgent.prototype.resolveScope.this.requestSeqToCallback_.cmd.getSequenceNumber): (devtools.DebuggerAgent.prototype.resolveScope): (devtools.DebuggerAgent.prototype.resolveFrameVariables_.scopeResponseHandler): (devtools.DebuggerAgent.prototype.resolveFrameVariables_): (devtools.DebuggerAgent.prototype.resolveCompletionsOnFrame): (devtools.DebuggerAgent.prototype.getScriptContextType): (devtools.DebuggerAgent.prototype.requestClearBreakpoint_): (devtools.DebuggerAgent.prototype.requestChangeBreakpoint_): (devtools.DebuggerAgent.prototype.requestBacktrace_): (devtools.DebuggerAgent.sendCommand_): (devtools.DebuggerAgent.prototype.stepCommand_): (devtools.DebuggerAgent.prototype.requestLookup_): (devtools.DebuggerAgent.prototype.setContextId_.this.requestSeqToCallback_.cmd.getSequenceNumber): (devtools.DebuggerAgent.prototype.setContextId_): (devtools.DebuggerAgent.prototype.handleDebuggerOutput_): (devtools.DebuggerAgent.prototype.handleBreakEvent_): (devtools.DebuggerAgent.prototype.handleExceptionEvent_): (devtools.DebuggerAgent.prototype.handleScriptsResponse_): (devtools.DebuggerAgent.prototype.isScriptFromInspectedContext_): (devtools.DebuggerAgent.prototype.handleSetBreakpointResponse_): (devtools.DebuggerAgent.prototype.handleAfterCompileEvent_): (devtools.DebuggerAgent.prototype.addScriptInfo_): (devtools.DebuggerAgent.prototype.handleClearBreakpointResponse_): (devtools.DebuggerAgent.prototype.handleBacktraceResponse_): (devtools.DebuggerAgent.prototype.doHandleBacktraceResponse_): (devtools.DebuggerAgent.prototype.evaluateInCallFrame): (devtools.DebuggerAgent.prototype.invokeCallbackForResponse_): (devtools.DebuggerAgent.prototype.formatCallFrame_): (devtools.DebuggerAgent.formatObjectProperties_): (devtools.DebuggerAgent.propertiesToProxies_): (devtools.DebuggerAgent.formatObjectProxy_): (devtools.DebuggerAgent.webkitToV8LineNumber_): (devtools.DebuggerAgent.v8ToWwebkitLineNumber_): (devtools.ScriptInfo): (devtools.ScriptInfo.prototype.getLineOffset): (devtools.ScriptInfo.prototype.getContextType): (devtools.ScriptInfo.prototype.getUrl): (devtools.ScriptInfo.prototype.isUnresolved): (devtools.ScriptInfo.prototype.getBreakpointInfo): (devtools.ScriptInfo.prototype.addBreakpointInfo): (devtools.ScriptInfo.prototype.removeBreakpointInfo): (devtools.BreakpointInfo): (devtools.BreakpointInfo.prototype.getLine): (devtools.BreakpointInfo.prototype.getV8Id): (devtools.BreakpointInfo.prototype.setV8Id): (devtools.BreakpointInfo.prototype.markAsRemoved): (devtools.BreakpointInfo.prototype.isRemoved): (devtools.CallFrame): (devtools.CallFrame.prototype.evaluate_): (devtools.DebugCommand): (devtools.DebugCommand.prototype.getSequenceNumber): (devtools.DebugCommand.prototype.toJSONProtocol): (devtools.DebuggerMessage): (devtools.DebuggerMessage.prototype.getType): (devtools.DebuggerMessage.prototype.getEvent): (devtools.DebuggerMessage.prototype.getCommand): (devtools.DebuggerMessage.prototype.getRequestSeq): (devtools.DebuggerMessage.prototype.isRunning): (devtools.DebuggerMessage.prototype.isSuccess): (devtools.DebuggerMessage.prototype.getMessage): (devtools.DebuggerMessage.prototype.getBody): (devtools.DebuggerMessage.prototype.lookup):
- src/js/DevTools.js: Added. (devtools.dispatch): (devtools.ToolsAgent): (devtools.ToolsAgent.prototype.reset): (devtools.ToolsAgent.prototype.evaluateJavaScript): (devtools.ToolsAgent.prototype.getDebuggerAgent): (devtools.ToolsAgent.prototype.getProfilerAgent): (devtools.ToolsAgent.prototype.frameNavigate_): (devtools.ToolsAgent.prototype.dispatchOnClient_): (devtools.ToolsAgent.prototype.evaluate): (WebInspector.setResourcesPanelEnabled): (debugPrint): (devtools): (WebInspector.loaded): (): (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded): (WebInspector.ScriptView.prototype.didResolveScriptSource_): (WebInspector.UnresolvedPropertyValue): (WebInspector.UIString): (WebInspector.resourceTrackingWasEnabled): (WebInspector.resourceTrackingWasDisabled): (WebInspector.TestController.prototype.runAfterPendingDispatches): (WebInspector.queuesAreEmpty): (WebInspector.pausedScript):
- src/js/DevToolsHostStub.js: Added. (.RemoteDebuggerAgentStub): (.RemoteDebuggerAgentStub.prototype.getContextId): (.RemoteProfilerAgentStub): (.RemoteProfilerAgentStub.prototype.getActiveProfilerModules): (.RemoteProfilerAgentStub.prototype.getLogLines): (.RemoteToolsAgentStub): (.RemoteToolsAgentStub.prototype.dispatchOnInjectedScript): (.RemoteToolsAgentStub.prototype.dispatchOnInspectorController): (.RemoteToolsAgentStub.prototype.executeVoidJavaScript): (.ProfilerStubHelper): (.ProfilerStubHelper.GetInstance): (.ProfilerStubHelper.prototype.StopProfiling): (.ProfilerStubHelper.prototype.StartProfiling): (.ProfilerStubHelper.prototype.getActiveProfilerModules): (.ProfilerStubHelper.prototype.getLogLines): (.RemoteDebuggerCommandExecutorStub): (.RemoteDebuggerCommandExecutorStub.prototype.DebuggerCommand): (.RemoteDebuggerCommandExecutorStub.prototype.DebuggerPauseScript): (.RemoteDebuggerCommandExecutorStub.prototype.sendResponse_): (.DevToolsHostStub): (.DevToolsHostStub.prototype.reset): (.DevToolsHostStub.prototype.setting): (.DevToolsHostStub.prototype.setSetting):
- src/js/HeapProfilerPanel.js: Added. (WebInspector.ProfilesPanel.prototype.addSnapshot): (WebInspector.HeapSnapshotView): (WebInspector.HeapSnapshotView.prototype.get statusBarItems): (WebInspector.HeapSnapshotView.prototype.get profile): (WebInspector.HeapSnapshotView.prototype.set profile): (WebInspector.HeapSnapshotView.prototype.show): (WebInspector.HeapSnapshotView.prototype.hide): (WebInspector.HeapSnapshotView.prototype.resize): (WebInspector.HeapSnapshotView.prototype.refresh): (WebInspector.HeapSnapshotView.prototype.refreshShowAsPercents): (WebInspector.HeapSnapshotView.prototype._deleteSearchMatchedFlags): (WebInspector.HeapSnapshotView.prototype.searchCanceled): (WebInspector.HeapSnapshotView.prototype.performSearch): (WebInspector.HeapSnapshotView.prototype.jumpToFirstSearchResult.WebInspector.CPUProfileView.prototype.jumpToFirstSearchResult.jumpToLastSearchResult.WebInspector.CPUProfileView.prototype.jumpToLastSearchResult.jumpToNextSearchResult.WebInspector.CPUProfileView.prototype.jumpToNextSearchResult.jumpToPreviousSearchResult.WebInspector.CPUProfileView.prototype.jumpToPreviousSearchResult.showingFirstSearchResult.WebInspector.CPUProfileView.prototype.showingFirstSearchResult.showingLastSearchResult.WebInspector.CPUProfileView.prototype.showingLastSearchResult._jumpToSearchResult.WebInspector.CPUProfileView.prototype._jumpToSearchResult.refreshVisibleData): (WebInspector.HeapSnapshotView.prototype._changeBase): (WebInspector.HeapSnapshotView.prototype._createSnapshotDataGridList): (WebInspector.HeapSnapshotView.prototype._mouseDownInDataGrid): (WebInspector.HeapSnapshotView.prototype.get _isShowingAsPercent): (WebInspector.HeapSnapshotView.prototype._percentClicked): (WebInspector.HeapSnapshotView.prototype._resetDataGridList): (WebInspector.HeapSnapshotView.prototype._sortData): (WebInspector.HeapSnapshotView.prototype._updateBaseOptions): (WebInspector.HeapSnapshotView.prototype._updatePercentButton): (WebInspector.HeapSnapshotView.prototype._updateSummaryGraph): (WebInspector.HeapSnapshotView.SearchHelper.operations.LESS): (WebInspector.HeapSnapshotView.SearchHelper.operations.LESS_OR_EQUAL): (WebInspector.HeapSnapshotView.SearchHelper.operations.EQUAL): (WebInspector.HeapSnapshotView.SearchHelper.operations.GREATER_OR_EQUAL): (WebInspector.HeapSnapshotView.SearchHelper.operations.GREATER): (WebInspector.HeapSnapshotView.SearchHelper.parseOperationAndNumber): (WebInspector.HeapSummaryCalculator): (WebInspector.HeapSummaryCalculator.prototype.computeSummaryValues): (WebInspector.HeapSummaryCalculator.prototype.formatValue): (WebInspector.HeapSummaryCalculator.prototype.get showAsPercent): (WebInspector.HeapSummaryCalculator.prototype.set showAsPercent): (WebInspector.HeapSummaryCountCalculator): (WebInspector.HeapSummaryCountCalculator.prototype._highFromLow): (WebInspector.HeapSummaryCountCalculator.prototype._valueToString): (WebInspector.HeapSummarySizeCalculator): (WebInspector.HeapSummarySizeCalculator.prototype._highFromLow): (WebInspector.HeapSnapshotSidebarTreeElement): (WebInspector.HeapSnapshotSidebarTreeElement.prototype.get mainTitle): (WebInspector.HeapSnapshotSidebarTreeElement.prototype.set mainTitle): (WebInspector.HeapSnapshotDataGridNodeWithRetainers): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get _hasRetainers): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get _parent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype._populate.if): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype._populate): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.produceDiff): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.sort): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.signForDelta): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.showDeltaAsPercent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.getTotalCount): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.getTotalSize): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get countPercent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get sizePercent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get countDeltaPercent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get sizeDeltaPercent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get data): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.createCell): (WebInspector.HeapSnapshotDataGridNode): (WebInspector.HeapSnapshotDataGridList): (WebInspector.HeapSnapshotDataGridList.prototype.appendChild): (WebInspector.HeapSnapshotDataGridList.prototype.insertChild): (WebInspector.HeapSnapshotDataGridList.prototype.removeChildren): (WebInspector.HeapSnapshotDataGridList.prototype.populateChildren): (WebInspector.HeapSnapshotDataGridList.propertyComparator.comparator): (WebInspector.HeapSnapshotDataGridList.propertyComparator): (WebInspector.HeapSnapshotDataGridRetainerNode): (WebInspector.HeapSnapshotDataGridRetainerNode.prototype.get sizePercent): (WebInspector.HeapSnapshotDataGridRetainerNode.prototype.get sizeDeltaPercent): (WebInspector.HeapSnapshotDataGridRetainerNode.prototype._calculateRetainers): (WebInspector.HeapSnapshotProfileType): (WebInspector.HeapSnapshotProfileType.prototype.get buttonTooltip): (WebInspector.HeapSnapshotProfileType.prototype.get buttonStyle): (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked): (WebInspector.HeapSnapshotProfileType.prototype.get welcomeMessage): (WebInspector.HeapSnapshotProfileType.prototype.createSidebarTreeElementForProfile): (WebInspector.HeapSnapshotProfileType.prototype.createView): ():
- src/js/InjectDispatch.js: Added. (InspectorControllerDispatcher.dispatch): (ApuAgentDispatcher.dispatchToApu): (dispatch): (devtools):
- src/js/InspectorControllerImpl.js: Added. (devtools.InspectorBackendImpl): (devtools.InspectorBackendImpl.prototype.toggleNodeSearch): (devtools.InspectorBackendImpl.prototype.debuggerEnabled): (devtools.InspectorBackendImpl.prototype.profilerEnabled): (devtools.InspectorBackendImpl.prototype.addBreakpoint): (devtools.InspectorBackendImpl.prototype.removeBreakpoint): (devtools.InspectorBackendImpl.prototype.updateBreakpoint): (devtools.InspectorBackendImpl.prototype.pauseInDebugger): (devtools.InspectorBackendImpl.prototype.resumeDebugger): (devtools.InspectorBackendImpl.prototype.stepIntoStatementInDebugger): (devtools.InspectorBackendImpl.prototype.stepOutOfFunctionInDebugger): (devtools.InspectorBackendImpl.prototype.stepOverStatementInDebugger): (devtools.InspectorBackendImpl.prototype.setPauseOnExceptionsState): (devtools.InspectorBackendImpl.prototype.pauseOnExceptionsState): (devtools.InspectorBackendImpl.prototype.pauseOnExceptions): (devtools.InspectorBackendImpl.prototype.setPauseOnExceptions): (devtools.InspectorBackendImpl.prototype.startProfiling): (devtools.InspectorBackendImpl.prototype.stopProfiling): (devtools.InspectorBackendImpl.prototype.getProfileHeaders): (devtools.InspectorBackendImpl.prototype.addFullProfile): (devtools.InspectorBackendImpl.prototype.getProfile): (devtools.InspectorBackendImpl.prototype.takeHeapSnapshot): (devtools.InspectorBackendImpl.prototype.dispatchOnInjectedScript): (devtools.InspectorBackendImpl.prototype.installInspectorControllerDelegate_): (devtools.InspectorBackendImpl.prototype.callInspectorController_):
- src/js/ProfilerAgent.js: Added. (devtools.ProfilerAgent): (devtools.ProfilerAgent.prototype.setupProfilerProcessorCallbacks): (devtools.ProfilerAgent.prototype.initializeProfiling): (devtools.ProfilerAgent.prototype.startProfiling): (devtools.ProfilerAgent.prototype.stopProfiling): (devtools.ProfilerAgent.prototype.didGetActiveProfilerModules_): (devtools.ProfilerAgent.prototype.didGetLogLines_):
- src/js/ProfilerProcessor.js: Added. (devtools.profiler.WebKitViewBuilder): (devtools.profiler.WebKitViewBuilder.prototype.createViewNode): (devtools.profiler.WebKitViewNode): (set get devtools.profiler.WebKitViewNode.prototype.initFuncInfo_): (devtools.profiler.JsProfile): (devtools.profiler.JsProfile.prototype.skipThisFunction): (devtools.profiler.Processor): (devtools.profiler.Processor.prototype.printError): (devtools.profiler.Processor.prototype.skipDispatch): (devtools.profiler.Processor.prototype.setCallbacks): (devtools.profiler.Processor.prototype.setNewProfileCallback): (devtools.profiler.Processor.prototype.processProfiler_.switch.break): (devtools.profiler.Processor.prototype.processProfiler_): (devtools.profiler.Processor.prototype.processCodeCreation_): (devtools.profiler.Processor.prototype.processCodeMove_): (devtools.profiler.Processor.prototype.processCodeDelete_): (devtools.profiler.Processor.prototype.processFunctionCreation_): (devtools.profiler.Processor.prototype.processFunctionMove_): (devtools.profiler.Processor.prototype.processFunctionDelete_): (devtools.profiler.Processor.prototype.processTick_): (devtools.profiler.Processor.prototype.processTickV2_): (devtools.profiler.Processor.prototype.processHeapSampleBegin_): (devtools.profiler.Processor.prototype.processHeapSampleStats_): (devtools.profiler.Processor.prototype.processHeapSampleItem_): (devtools.profiler.Processor.prototype.processHeapJsConsItem_): (devtools.profiler.Processor.prototype.processHeapJsRetItem_.mergeRetainers): (devtools.profiler.Processor.prototype.processHeapJsRetItem_): (devtools.profiler.Processor.prototype.processHeapSampleEnd_): (devtools.profiler.Processor.prototype.createProfileForView):
- src/js/Tests.js: Added. (.TestSuite): (.TestSuite.prototype.fail): (.TestSuite.prototype.assertEquals): (.TestSuite.prototype.assertTrue): (.TestSuite.prototype.assertContains): (.TestSuite.prototype.takeControl): (.TestSuite.prototype.releaseControl): (.TestSuite.prototype.reportOk_): (.TestSuite.prototype.reportFailure_): (.TestSuite.prototype.runTest): (.TestSuite.prototype.showPanel): (.TestSuite.prototype.addSniffer.receiver.methodName): (.TestSuite.prototype.addSniffer): (.TestSuite.prototype.testHostIsPresent): (.TestSuite.prototype.testElementsTreeRoot): (.TestSuite.prototype.testMainResource): (.TestSuite.prototype.testResourceContentLength.this.addSniffer.): (.TestSuite.prototype.testResourceHeaders): (.TestSuite.prototype.testCachedResourceMimeType.this.addSniffer.): (.TestSuite.prototype.testCachedResourceMimeType): (.TestSuite.prototype.testProfilerTab): (.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh.waitUntilScriptIsParsed): (.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh.checkScriptsPanel): (.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh): (.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.switchToElementsTab): (.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.switchToScriptsTab): (.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.checkScriptsPanel): (.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.checkNoDuplicates): (.TestSuite.prototype.testPauseOnException): (.TestSuite.prototype.testPauseWhenLoadingDevTools): (.TestSuite.prototype.testPauseWhenScriptIsRunning.testScriptPauseAfterDelay): (.TestSuite.prototype.testPauseWhenScriptIsRunning.testScriptPause): (.TestSuite.prototype.testPauseWhenScriptIsRunning): (.TestSuite.prototype.optionsToString_): (.TestSuite.prototype.evaluateInConsole_): (.TestSuite.prototype.waitForSetBreakpointResponse_): (.TestSuite.prototype.testEvalOnCallFrame.setBreakpointCallback): (.TestSuite.prototype.testEvalOnCallFrame.waitForBreakpointHit): (.TestSuite.prototype.testCompletionOnPause): (.TestSuite.prototype.testCompletionOnPause.testLocalsCompletion): (.TestSuite.prototype.testCompletionOnPause.testThisCompletion): (.TestSuite.prototype.testCompletionOnPause.testFieldCompletion): (.TestSuite.prototype.testCompletionOnPause.checkCompletions): (.TestSuite.prototype.testAutoContinueOnSyntaxError.checkScriptsList): (.TestSuite.prototype.testAutoContinueOnSyntaxError.waitForExceptionEvent.test): (.TestSuite.prototype.testAutoContinueOnSyntaxError.waitForExceptionEvent): (.TestSuite.prototype._checkExecutionLine): (.TestSuite.prototype._scriptsAreParsed): (.TestSuite.prototype._waitForScriptPause): (.TestSuite.prototype._checkSourceFrameWhenLoaded.checkExecLine): (.TestSuite.prototype._checkSourceFrameWhenLoaded): (.TestSuite.prototype._performSteps.doNextAction): (.TestSuite.prototype._performSteps): (.TestSuite.prototype._executeCodeWhenScriptsAreParsed.executeFunctionInInspectedPage): (.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts): (.TestSuite.prototype._waitUntilScriptsAreParsed): (.TestSuite.prototype._executeFunctionForStepTest): (.TestSuite.prototype.testStepOver): (.TestSuite.prototype.testStepOut): (.TestSuite.prototype.testStepIn): (.TestSuite.prototype._evaluateXpath): (.TestSuite.prototype._findNode): (.TestSuite.prototype._findText): (.TestSuite.prototype._nodeIterator): (.TestSuite.prototype._checkScopeSectionDiv): (.TestSuite.prototype._expandScopeSections.updateListener): (.TestSuite.prototype._expandScopeSections): (.TestSuite.prototype.testExpandScope): (.TestSuite.prototype.testExpandScope.examineScopes): (.TestSuite.prototype._findChildProperty): (.TestSuite.prototype._hookGetPropertiesCallback.accessor.getProperties): (.TestSuite.prototype._hookGetPropertiesCallback.try): (.TestSuite.prototype._hookGetPropertiesCallback): (.TestSuite.prototype.testDebugIntrinsicProperties.expandLocalScope): (.TestSuite.prototype.testDebugIntrinsicProperties): (.TestSuite.prototype.testDebugIntrinsicProperties.expandAndCheckNextProperty): (.TestSuite.prototype.testDebugIntrinsicProperties.checkProperty): (.TestSuite.createKeyEvent): (.TestSuite.prototype.testConsoleLog.assertNext): (.TestSuite.prototype.testConsoleLog): (.TestSuite.prototype.testEvalGlobal.initEval): (.TestSuite.prototype.testEvalGlobal): (.TestSuite.prototype.testShowStoragePanel.this.addSniffer.): (.TestSuite.prototype.testShowStoragePanel.this.addSniffer): (.uiTests.runAllTests): (.uiTests.runTest):
- 3:55 AM Changeset in webkit [54545] by
-
- 7 edits in trunk/JavaScriptCore
Three small string fixes:
(1) StringBuilder::release should CRASH if the buffer allocation failed.
(2) Remove weird, dead code from JSString::tryGetValue, replace with an ASSERT.
(3) Move UString::createFromUTF8 out to the API, as tryCreateStringFromUTF8.
This is only used from the API, and (now) unlike other UString::create
methods may return UString::null() to indicate failure cases. Better
handle these in the API.
Reviewed by Oliver Hunt.
- API/JSClassRef.cpp:
(tryCreateStringFromUTF8):
(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):
- runtime/JSString.h:
(JSC::Fiber::tryGetValue):
- runtime/StringBuilder.h:
(JSC::StringBuilder::release):
- runtime/UString.cpp:
(JSC::UString::UString):
(JSC::UString::from):
(JSC::UString::find):
- runtime/UString.h:
- 3:13 AM Changeset in webkit [54544] by
-
- 2 edits in trunk/LayoutTests
2010-02-09 Yuzo Fujishima <yuzo@google.com>
Unreviewed.
Fix build brekage introduced by r54536.
Add the following two to Skipped:
fast/css/inline-element-line-break.html and
fast/css/pseudo-element-line-break.html
- platform/gtk/Skipped:
- 2:40 AM Changeset in webkit [54543] by
-
- 5 edits in trunk
2010-02-09 Chang Shu <Chang.Shu@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Enable http/tests/appcache but skip the failed cases.
https://bugs.webkit.org/show_bug.cgi?id=34713
- platform/qt/Skipped:
2010-02-09 Chang Shu <Chang.Shu@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Enable appcache feature.
https://bugs.webkit.org/show_bug.cgi?id=34713
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage):
- DumpRenderTree/qt/main.cpp: (main):
- 2:24 AM Changeset in webkit [54542] by
-
- 1 edit1 add in trunk/WebCore
2010-02-09 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port KURL::fileSystemPath
https://bugs.webkit.org/show_bug.cgi?id=34516
Convert a file URL to a file path by prefixing
AEEFS_HOME_DIR to access files relative to the current
module directory in a case-sensitive manner.
As IWeb "file:" engine opens files in BREW's application-relative
file namespace, we follow the same policy here.
- platform/brew/KURLBrew.cpp: Added. (WebCore::KURL::fileSystemPath):
- 2:07 AM Changeset in webkit [54541] by
-
- 2 edits in trunk/WebCore
2010-02-09 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] the above website does not render properly when in compositing mode
https://bugs.webkit.org/show_bug.cgi?id=34681
http://media.24ways.org/2009/15/spinner-alt.html now renders correctly
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::MaskEffectQt::MaskEffectQt): implement mask as QGraphicsEffect (WebCore::MaskEffectQt::draw): reimp (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): init the effect (WebCore::GraphicsLayerQtImpl::paint): no need for drawContents (WebCore::GraphicsLayerQtImpl::flushChanges): make sure to update the mask layer, not just the actual children
- 2:01 AM Changeset in webkit [54540] by
-
- 2 edits in trunk/LayoutTests
2010-02-09 Eric Seidel <eric@webkit.org>
Reviewed by Shinichiro Hamaji.
storage/database-lock-after-reload.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=29154
- platform/mac/Skipped: Skip for now to keep the bots green until someone can take a look.
- 1:51 AM Changeset in webkit [54539] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-09 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Laszlo Gombos.
[Qt] use nanval() for Symbian as nonInlineNaN
https://bugs.webkit.org/show_bug.cgi?id=34170
numeric_limits<double>::quiet_NaN is broken in Symbian
causing NaN to be evaluated as a number.
- runtime/JSValue.cpp: (JSC::nonInlineNaN):
- 1:39 AM Changeset in webkit [54538] by
-
- 3 edits20 adds in trunk/LayoutTests
2010-02-09 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Add modified version of CSS2.1 test suite for paged media
https://bugs.webkit.org/show_bug.cgi?id=34695
Note that page-break-inside-000 is failing now.
- platform/qt/Skipped:
- platform/win/Skipped:
- printing/css2.1/README.txt: Added.
- printing/css2.1/page-break-after-000-expected.txt: Added.
- printing/css2.1/page-break-after-000.html: Added.
- printing/css2.1/page-break-after-001-expected.txt: Added.
- printing/css2.1/page-break-after-001.html: Added.
- printing/css2.1/page-break-after-002-expected.txt: Added.
- printing/css2.1/page-break-after-002.html: Added.
- printing/css2.1/page-break-after-004-expected.txt: Added.
- printing/css2.1/page-break-after-004.html: Added.
- printing/css2.1/page-break-before-000-expected.txt: Added.
- printing/css2.1/page-break-before-000.html: Added.
- printing/css2.1/page-break-before-001-expected.txt: Added.
- printing/css2.1/page-break-before-001.html: Added.
- printing/css2.1/page-break-before-002-expected.txt: Added.
- printing/css2.1/page-break-before-002.html: Added.
- printing/css2.1/page-break-inside-000-expected.txt: Added.
- printing/css2.1/page-break-inside-000.html: Added.
- printing/resources/paged-media-test-utils.js: Added. (pageNumberShouldBe):
- 1:35 AM Changeset in webkit [54537] by
-
- 2 edits in trunk/WebCore
2010-02-09 Kwang Yul Seo <skyul@company100.net>
Reviewed by Laszlo Gombos.
[BREWMP] Fix macro redefinition error in BREWMP simulator build.
https://bugs.webkit.org/show_bug.cgi?id=34738
Remove warning: 'FAR' macro redefinition.
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
- 1:16 AM Changeset in webkit [54536] by
-
- 12 edits8 adds in trunk
2010-02-07 Yuzo Fujishima <yuzo@google.com>
Reviewed by Dan Bernstein.
Fix the following bugs:
https://bugs.webkit.org/show_bug.cgi?id=18926 - dt:after generate a line break. Boost documentation page renders poorly
https://bugs.webkit.org/show_bug.cgi?id=7276 - Most W3C padding related tests fail
css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.html and css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.html have been rebaselined
because the original expected values are incorrect, judging from the test description and how IE 8.0, Firefox 3.6, and Opera 10.10 render the pages.
fast/dom/clone-node-dynamic-style-expected.html have been also rebaselined because the original expected values assumes a line break.
Expected values under platform/qt need not be updated because the tests are in the Skipped file for the platform.
- fast/css/inline-element-line-break.html: Added.
- fast/css/pseudo-element-line-break.html: Added.
- platform/mac/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.checksum:
- platform/mac/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.png:
- platform/mac/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.txt:
- platform/mac/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.checksum:
- platform/mac/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.png:
- platform/mac/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.txt:
- platform/mac/fast/css/inline-element-line-break-expected.checksum: Added.
- platform/mac/fast/css/inline-element-line-break-expected.png: Added.
- platform/mac/fast/css/inline-element-line-break-expected.txt: Added.
- platform/mac/fast/css/pseudo-element-line-break-expected.checksum: Added.
- platform/mac/fast/css/pseudo-element-line-break-expected.png: Added.
- platform/mac/fast/css/pseudo-element-line-break-expected.txt: Added.
- platform/mac/fast/dom/clone-node-dynamic-style-expected.checksum:
- platform/mac/fast/dom/clone-node-dynamic-style-expected.png:
- platform/mac/fast/dom/clone-node-dynamic-style-expected.txt:
2010-02-07 Yuzo Fujishima <yuzo@google.com>
Reviewed by Dan Bernstein.
Fix the following bugs:
https://bugs.webkit.org/show_bug.cgi?id=18926 - dt:after generate a line break. Boost documentation page renders poorly
https://bugs.webkit.org/show_bug.cgi?id=7276 - Most W3C padding related tests fail
Tests: fast/css/inline-element-line-break.html
fast/css/pseudo-element-line-break.html
findNextLineBreak() unconditionally allowed lines to break between elements when no other line breaking opportunity had been found,
but that was unnecessary and led to incorrect layout. Disallow that kind of line breaks.
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):
- 12:52 AM Changeset in webkit [54535] by
-
- 3 edits2 adds in trunk
2010-02-09 Avi Drissman <avi@chromium.org>
Reviewed by David Levin.
Chromium Mac: Control-A shouldn't select all/Control-C shouldn't copy
https://bugs.webkit.org/show_bug.cgi?id=34615
- fast/events/attempt-select-all-with-wrong-modifier-expected.txt: Added.
- fast/events/attempt-select-all-with-wrong-modifier.html: Added.
2010-02-09 Avi Drissman <avi@chromium.org>
Reviewed by David Levin.
Chromium Mac: Control-A shouldn't select all/Control-C shouldn't copy
https://bugs.webkit.org/show_bug.cgi?id=34615
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::keyEventDefault):
- 12:50 AM Changeset in webkit [54534] by
-
- 6 edits in trunk/JavaScriptCore
Add a soft modulo operation to ARM JIT using a trampoline function.
The performance progression is about ~1.8% on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=34424
Patch by Tamas Szirbucz <szirbucz@inf.u-szeged.hu> on 2010-02-09
Reviewed by Gavin Barraclough.
Developed in cooperation with Gabor Loki.
- jit/JIT.h:
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):
- jit/JITOpcodes.cpp:
(JSC::JIT::softModulo):
- jit/JITStubs.h:
(JSC::JITThunks::ctiSoftModulo):
- wtf/Platform.h:
- 12:32 AM Changeset in webkit [54533] by
-
- 17 edits3 adds in trunk
2010-02-09 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get total number of pages to be printed
https://bugs.webkit.org/show_bug.cgi?id=34699
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- printing/numberOfPages-expected.txt: Added.
- printing/numberOfPages.html: Added.
- printing/script-tests/numberOfPages.js: Added. (createParagraph):
2010-02-09 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get total number of pages to be printed
https://bugs.webkit.org/show_bug.cgi?id=34699
Test: printing/numberOfPages.html
- WebCore.base.exp:
- page/PrintContext.cpp: (WebCore::PrintContext::pageNumberForElement): (WebCore::PrintContext::numberOfPages):
- page/PrintContext.h: (WebCore::PrintContext::pageRects):
2010-02-09 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get total number of pages to be printed
https://bugs.webkit.org/show_bug.cgi?id=34699
- Misc/WebCoreStatistics.h:
- Misc/WebCoreStatistics.mm: (-[WebFrame numberOfPages:pageWidthInPixels:]):
2010-02-09 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get total number of pages to be printed
https://bugs.webkit.org/show_bug.cgi?id=34699
- DumpRenderTree/LayoutTestController.cpp: (parsePageParameters): (pageNumberForElementByIdCallback): (numberOfPagesCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::numberOfPages):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::numberOfPages):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::numberOfPages):
Feb 8, 2010:
- 11:53 PM Changeset in webkit [54532] by
-
- 3 edits in trunk/JavaScriptCore
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- runtime/StringPrototype.cpp:
Reviewed by NOBODY (SL/win build fixes).
- 11:40 PM Changeset in webkit [54531] by
-
- 5 edits in trunk/JavaScriptCore
Make String.replace throw an exception on out-of-memory, rather than
returning a null (err, empty-ish) string. Move String::replaceRange
and String::spliceSubstringsWithSeparators out to StringPrototype -
these were fairly specific use anyway, and we can better integrate
throwing the JS expcetion this way.
Reviewed by Oliver Hunt
Also removes redundant assignment operator from UString.
- JavaScriptCore.exp:
- runtime/StringPrototype.cpp:
(JSC::StringRange::StringRange):
(JSC::jsSpliceSubstringsWithSeparators):
(JSC::jsReplaceRange):
(JSC::stringProtoFuncReplace):
- runtime/UString.cpp:
- runtime/UString.h:
- 11:32 PM Changeset in webkit [54530] by
-
- 1 edit3 adds in trunk/LayoutTests
Add numerous parse-only tests.
https://bugs.webkit.org/show_bug.cgi?id=34019
Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2010-02-09
Reviewed by Oliver Hunt.
The input file contains a lot of strings, and tests whether they are
valid JavaScript code snippets or contains various syntax errors.
No semantic checks: even if a tests throws an exception, which is not
syntax error, it is considered successfull.
- fast/js/parser-syntax-check-expected.txt: Added.
- fast/js/parser-syntax-check.html: Added.
- fast/js/script-tests/parser-syntax-check.js: Added.
(runTest):
(valid):
(invalid):
- 11:15 PM Changeset in webkit [54529] by
-
- 2 edits in trunk/LayoutTests
2010-02-08 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed GTK+ test fix.
Web site is stuck loading forever
https://bugs.webkit.org/show_bug.cgi?id=31227
It seems the following bug is addressing this issue.
[GTK] Needs proper reporting of frame loader callbacks, in DRT
https://bugs.webkit.org/show_bug.cgi?id=32170
- platform/gtk/Skipped:
- 11:15 PM Changeset in webkit [54528] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-08 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Undefine WTF_OS_WINDOWS and WTF_PLATFORM_WIN
https://bugs.webkit.org/show_bug.cgi?id=34561
As the binary for simulator is built with MSVC 2005,
WTF_OS_WINDOWS and WTF_PLATFORM_WIN are defined.
Undefine them as we don't target Windows.
- wtf/Platform.h:
- 10:48 PM Changeset in webkit [54527] by
-
- 4 edits1 add in trunk/WebCore
2010-02-08 Dominic Cooney <dominicc@google.com>
Reviewed by Adam Barth.
[V8] Move Element custom methods into generic bindings
This patch moves the security checks in setAttribute,
setAttributeNode, setAttributeNS and setAttributeNodeNS from
V8ElementCustom into the generic bindings so that they can be
reused in other bindings. This is in a similar vein to
<https://bugs.webkit.org/attachment.cgi?id=45872>.
LayoutTests: None
- WebCore.gypi:
- bindings/generic/BindingElement.h: Added. (WebCore::::setAttribute): (WebCore::::setAttributeNode): (WebCore::::setAttributeNS): (WebCore::::setAttributeNodeNS):
- bindings/v8/V8Binding.h:
- bindings/v8/custom/V8ElementCustom.cpp: (WebCore::V8Element::setAttributeCallback): (WebCore::V8Element::setAttributeNodeCallback): (WebCore::V8Element::setAttributeNSCallback): (WebCore::V8Element::setAttributeNodeNSCallback):
- 10:17 PM Changeset in webkit [54526] by
-
- 3 edits4 adds in trunk
2010-02-08 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Schedule a loading request when there are many in-flight requests beyond
the limit to avoid forever page loading.
- http/tests/loading/load-javascript-after-many-xhrs-expected.txt: Added.
- http/tests/loading/load-javascript-after-many-xhrs.html: Added.
- http/tests/loading/resources/zero-length.js: Added.
- http/tests/loading/resources/zero-length.txt: Added.
2010-02-08 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Schedule a loading request when there are many in-flight requests beyond
the limit to avoid forever page loading.
Test: http/tests/loading/load-javascript-after-many-xhrs.html
- loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests):
- 9:19 PM Changeset in webkit [54525] by
-
- 4 edits in trunk/WebCore
REGRESSION (before r54472): Various tests in fast/workers are crashing on the buildbot.
https://bugs.webkit.org/show_bug.cgi?id=34728
Reviewed by Gavin Barraclough.
The core part of the fix is to change WebCoreJSClientData::m_normalWorld
from DOMWrapperWorld to RefPtr<DOMWrapperWorld> so that the DOMWrapperWorld
is really ref counted.
No new tests because current tests sufficiently cover this as evidenced as
the buildbot crashes.
- bindings/js/JSDOMBinding.cpp:
(WebCore::DOMWrapperWorld::~DOMWrapperWorld): Made this robust to m_globalData
being 0.
- bindings/js/JSDOMBinding.h:
(WebCore::DOMWrapperWorld::create): Made this class follow the standard
create pattern for RefCounted classes.
(WebCore::DOMWrapperWorld::detachFromGlobalData): Since this class can
now outlive JSGlobalData, this method tells it to stop using its JSGlobalData.
(WebCore::WebCoreJSClientData::WebCoreJSClientData): Adjusted due to
m_normalWorld being a RefPtr.
(WebCore::WebCoreJSClientData::~WebCoreJSClientData): Ditto (and added
asserts for the FIXME).
(WebCore::WebCoreJSClientData::normalWorld): Ditto.
- bindings/js/ScriptController.cpp:
(WebCore::IsolatedWorld::create): Made the constructor protected.
(WebCore::IsolatedWorld::IsolatedWorld): Made the constructor protected, so
that code would have to use the create method.
- 7:05 PM Changeset in webkit [54524] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-08 Evan Martin <evan@chromium.org>
dlopen() knows how to search the library search path, so just rely on
it. While I'm at it, print out the dlerror() error message on failure.
[chromium] webgl shouldn't hard code library search path
https://bugs.webkit.org/show_bug.cgi?id=34659
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GLConnection::GLConnection): (WebCore::GraphicsContext3DInternal::GLConnection::create):
- 6:48 PM Changeset in webkit [54523] by
-
- 3 edits in trunk/WebCore
2010-02-08 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Remove special utf-8 tag from Chromium cilpboard code because
we now have the corresponding code in generic clipboard framework
code in chromium (since it's needed by other places than in Web
page rendering) and no longer need the separate workaround code in
WebKit.
https://bugs.webkit.org/show_bug.cgi?id=34567
Test: (for regression) editing/pasteboard
- platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::writeRange):
- platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::documentFragment):
- 6:31 PM Changeset in webkit [54522] by
-
- 1 edit1 add in trunk/JavaScriptCore
2010-02-08 Chris Rogers <crogers@google.com>
Reviewed by Darin Adler.
audio engine: add Vector3 class
https://bugs.webkit.org/show_bug.cgi?id=34548
- wtf/Vector3.h: Added. (WebCore::Vector3::Vector3): (WebCore::Vector3::abs): (WebCore::Vector3::isZero): (WebCore::Vector3::normalize): (WebCore::Vector3::x): (WebCore::Vector3::y): (WebCore::Vector3::z): (WebCore::operator+): (WebCore::operator-): (WebCore::operator*): (WebCore::dot): (WebCore::cross): (WebCore::distance):
- 6:12 PM Changeset in webkit [54521] by
-
- 3 edits2 adds in trunk
Crash due to layout not done in case involving removal of absolute positioning
https://bugs.webkit.org/show_bug.cgi?id=34734
rdar://problem/7588280
Reviewed by Dan Bernstein.
WebCore:
Test: fast/dynamic/position-change-layout.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleDidChange): Call markContainingBlocksForLayout in
a case where the object already needs layout, but might have a new containing
block and so needs to mark the new containing block.
LayoutTests:
- fast/dynamic/position-change-layout-expected.txt: Added.
- fast/dynamic/position-change-layout.html: Added.
- 5:24 PM Changeset in webkit [54520] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-08 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Fix warning in clang++
- runtime/Structure.h: (JSC::Structure::propertyStorageSize):
- 4:32 PM Changeset in webkit [54519] by
-
- 5 edits2 adds in trunk
2010-02-08 Charlie Reis <creis@chromium.org>
Reviewed by Darin Adler.
onbeforeunload not called at window close + frame or iframe focused
https://bugs.webkit.org/show_bug.cgi?id=27481
Chromium and WebKit on Windows will now fire beforeunload handlers
even if an inner frame is focused.
Layout tests aren't able to test this bug, since it requires closing
the actual browser window, not calling window.close(). Instead,
test with WebCore/manual-tests/onbeforeunload-focused-iframe.html.
- manual-tests/onbeforeunload-focused-iframe.html: Added.
- manual-tests/resources/focused-iframe.html: Added.
2010-02-08 Charlie Reis <creis@chromium.org>
Reviewed by Darin Adler.
onbeforeunload not called at window close + frame or iframe focused
https://bugs.webkit.org/show_bug.cgi?id=27481
http://code.google.com/p/chromium/issues/detail?id=32615
http://code.google.com/p/chromium/issues/detail?id=17157
Chromium and WebKit on Windows will now fire beforeunload handlers
even if an inner frame is focused.
Layout tests aren't able to test this bug, since it requires closing
the actual browser window, not calling window.close(). Instead,
test with WebCore/manual-tests/onbeforeunload-focused-iframe.html.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::dispatchBeforeUnloadEvent):
2010-02-08 Charlie Reis <creis@chromium.org>
Reviewed by Darin Adler.
onbeforeunload not called at window close + frame or iframe focused
https://bugs.webkit.org/show_bug.cgi?id=27481
Chromium and WebKit on Windows will now fire beforeunload handlers
even if an inner frame is focused.
Layout tests aren't able to test this bug, since it requires closing
the actual browser window, not calling window.close(). Instead,
test with WebCore/manual-tests/onbeforeunload-focused-iframe.html.
- WebView.cpp: (WebView::shouldClose):
- 3:43 PM Changeset in webkit [54518] by
-
- 3 edits in trunk/JavaScriptCore
Make makeString CRASH if we fail to allocate a string.
Reviewed by Geoff Garen.
(tryMakeString or jsMakeNontrivialString can be used where we
expect allocation may fail and want to handle the error).
- runtime/JSStringBuilder.h:
(JSC::jsMakeNontrivialString):
- runtime/UString.h:
(JSC::tryMakeString):
(JSC::makeString):
- 3:28 PM Changeset in webkit [54517] by
-
- 2 edits in trunk/WebCore
Addressing review feedback.
- bridge/c/c_instance.h: Removed argument name.
- 3:27 PM Changeset in webkit [54516] by
-
- 10 edits2 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=34727
Assertion crashes and freezes when plug-in property access results in an exception
Test: plugins/netscape-plugin-property-access-exception.html
- 3:27 PM Changeset in webkit [54515] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by David Levin.
WebKit/chromium: Custom context menu does not work in inspector.
https://bugs.webkit.org/show_bug.cgi?id=34711
- src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::jsShowContextMenu):
- 3:13 PM Changeset in webkit [54514] by
-
- 2 edits in trunk/JavaScriptCore
Rubber Stamped by Oliver Hunt.
Remove a couple of unnecesary C-style casts spotted by Darin.
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::globalFuncEscape):
- 3:04 PM Changeset in webkit [54513] by
-
- 3 edits in trunk/JavaScriptCore
Switch some more StringBuilder/jsNontrivialString code to use
JSStringBuilder/jsMakeNontrivialString - these methods will
throw an exception if we hit out-of-memory, rather than just
CRASHing.
Reviewed by Geoff Garen.
- runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::decode):
(JSC::globalFuncEscape):
- 2:58 PM Changeset in webkit [54512] by
-
- 4 edits in trunk/WebKitTools
[Qt] Backport No'am Rosenthal's frame rate measurement
Reviewed by Ariya Hidayat.
- QtLauncher/main.cpp:
(LauncherWindow::LauncherWindow):
(LauncherApplication::handleUserOptions):
- QtLauncher/webview.cpp:
(WebViewGraphicsBased::WebViewGraphicsBased):
(WebViewGraphicsBased::enableFrameRateMeasurement):
(WebViewGraphicsBased::updateFrameRate):
(WebViewGraphicsBased::paintEvent):
- QtLauncher/webview.h:
- 2:43 PM Changeset in webkit [54511] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-08 Nate Chapin <Nate Chapin>
Reviewed by Darin Fisher.
Check that the index passed into BackForwardListClientImpl::itemAtIndex()
is valid, and return null if it isn't.
- src/BackForwardListClientImpl.cpp: (WebKit::BackForwardListClientImpl::itemAtIndex):
- 2:26 PM Changeset in webkit [54510] by
-
- 8 edits in trunk/JavaScriptCore
Use an empty identifier instead of a null identifier for parse
tokens without an identifier.
Reviewed by Sam Weinig.
This helps encapsulate the null UStringImpl within UString.
- parser/Grammar.y:
- parser/NodeConstructors.h:
(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ForInNode::ForInNode):
- runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::CommonIdentifiers):
- runtime/CommonIdentifiers.h:
- runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::FunctionPrototype):
- 1:55 PM Changeset in webkit [54509] by
-
- 4 edits in trunk/WebCore
2010-02-08 Dirk Schulze <krit@webkit.org>
Unreviewed build fix of ChromiumWin.
- platform/graphics/chromium/TransparencyWin.cpp: (WebCore::): (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer): (WebCore::TransparencyWin::setupTransformForKeepTransform):
- platform/graphics/chromium/TransparencyWin.h:
- rendering/RenderThemeChromiumWin.cpp: (WebCore::):
- 1:48 PM Changeset in webkit [54508] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-08 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Implement FrameLoaderClient::hasWebView
https://bugs.webkit.org/show_bug.cgi?id=34682
Used for sanity-check ASSERTS in the FrameLoader code.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::hasWebView):
- 1:35 PM Changeset in webkit [54507] by
-
- 2 edits in trunk/LayoutTests
Put the test back on skipped list - it needs a newer version of Safari to pass.
- platform/mac-snowleopard/Skipped:
- 1:20 PM Changeset in webkit [54506] by
-
- 7 edits in trunk
WebCore: Adding a way to get the set of all open database handles pointing
to a given database.
https://bugs.webkit.org/show_bug.cgi?id=34619
Reviewed by Jeremy Orlow.
Sometimes we need to be able to close all handles to a database as
soon as possible (to delete the DB file, for example).
- storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::getOpenDatabases):
- storage/DatabaseTracker.h:
- storage/chromium/DatabaseTrackerChromium.cpp:
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
WebKit/chromium: Adding a way to close all database handles pointing to a certain
database as soon as possible.
https://bugs.webkit.org/show_bug.cgi?id=34619
Reviewed by Jeremy Orlow.
- public/WebDatabase.h:
- src/WebDatabase.cpp:
(WebKit::WebDatabase::closeDatabaseImmediately):
- 12:55 PM Changeset in webkit [54505] by
-
- 2 edits in trunk/WebCore
2010-02-08 Dirk Schulze <krit@webkit.org>
Unreviewed windows build-fix.
- page/win/FrameCGWin.cpp: (WebCore::drawRectIntoContext):
- 12:53 PM Changeset in webkit [54504] by
-
- 8 edits in trunk
Reviewed by Anders Carlsson.
<rdar://problem/6530010> OOP: Support NPN_SetException
Tested by plugins/netscape-throw-exception.html (removed it from skipped list).
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCSetException):
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::globalExceptionString): (WebKit::NetscapePluginInstanceProxy::setGlobalException): (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
- Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invoke): (WebKit::ProxyInstance::getPropertyNames): (WebKit::ProxyInstance::fieldValue): (WebKit::ProxyInstance::setFieldValue):
- Plugins/Hosted/WebKitPluginClient.defs: Route exception string to a global that's checked after calling into plug-in (just like in in-process case).
- 12:30 PM Changeset in webkit [54503] by
-
- 154 edits in trunk
2010-02-08 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Add back an AffineTransform class for use by SVG
https://bugs.webkit.org/show_bug.cgi?id=33750
This adds back AffineTransform. This saves additional 4% memory consumption
on the 50k rects stress test: https://bugs.webkit.org/attachment.cgi?id=46721
It also makes it possible to optimize the calculations internally of
AffineTransform to the needs of 2D transformations (the second benefit for SVG,
which uses transformations relative often at the moment.
Everything that is 2D related (like images, patterns, gradients, fonts), uses
AffineTransform now.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::multiply): (WebCore::JSSVGMatrix::inverse): (WebCore::JSSVGMatrix::rotateFromVector):
- bindings/js/JSSVGPODTypeWrapper.h:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorObjC.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8Index.h:
- bindings/v8/custom/V8SVGMatrixCustom.cpp: (WebCore::V8SVGMatrix::multiplyCallback): (WebCore::V8SVGMatrix::inverseCallback): (WebCore::V8SVGMatrix::rotateFromVectorCallback):
- html/HTMLCanvasElement.cpp: Changed to AffineTransform now (WebCore::HTMLCanvasElement::baseTransform):
- html/HTMLCanvasElement.h:
- platform/graphics/FloatPoint.cpp: (WebCore::FloatPoint::matrixTransform):
- platform/graphics/FloatPoint.h:
- platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern):
- platform/graphics/GeneratedImage.h:
- platform/graphics/Gradient.cpp: (WebCore::Gradient::setGradientSpaceTransform): (WebCore::Gradient::setPlatformGradientSpaceTransform):
- platform/graphics/Gradient.h: (WebCore::Gradient::gradientSpaceTransform):
- platform/graphics/GraphicsContext.h:
- platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
- platform/graphics/Image.h:
- platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::baseTransform):
- platform/graphics/Path.h:
- platform/graphics/Pattern.cpp: (WebCore::Pattern::setPatternSpaceTransform):
- platform/graphics/Pattern.h: (WebCore::Pattern::create): (WebCore::Pattern::tileImage):
- platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::setPlatformFill): (WebCore::setPlatformStroke): (WebCore::GraphicsContext::getCTM):
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
- platform/graphics/cairo/PathCairo.cpp:
- platform/graphics/cairo/PatternCairo.cpp: (WebCore::Pattern::createPlatformPattern):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::getCTM):
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
- platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern):
- platform/graphics/cg/PathCG.cpp:
- platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
- platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::getCTM):
- platform/graphics/haiku/ImageHaiku.cpp: (WebCore::Image::drawPattern):
- platform/graphics/haiku/PathHaiku.cpp:
- platform/graphics/qt/FontQt.cpp: (WebCore::Font::drawComplexText):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect):
- platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern):
- platform/graphics/qt/PathQt.cpp:
- platform/graphics/qt/PatternQt.cpp: (WebCore::Pattern::createPlatformPattern):
- platform/graphics/skia/GradientSkia.cpp: (WebCore::Gradient::setPlatformGradientSpaceTransform):
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::getCTM):
- platform/graphics/skia/ImageSkia.cpp: (WebCore::Image::drawPattern):
- platform/graphics/skia/PathSkia.cpp:
- platform/graphics/skia/PatternSkia.cpp: (WebCore::Pattern::platformPattern):
- platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleTextDrawing):
- platform/graphics/transforms/AffineTransform.cpp: (WebCore::AffineTransform::makeIdentity): needed by some parts of WebCore (WebCore::AffineTransform::scale): Didn't scale the complete matrix (WebCore::AffineTransform::translate): Didn't respect other transformations (WebCore::AffineTransform::shear): direct calculation, no extra multiply of matrices (WebCore::AffineTransform::map): (WebCore::AffineTransform::mapPoint): (WebCore::AffineTransform::mapRect):
- platform/graphics/transforms/AffineTransform.h: (WebCore::AffineTransform::isIdentityOrTranslation):
- platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::toAffineTransform):
- platform/graphics/transforms/TransformationMatrix.h:
- platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs):
- platform/graphics/win/GraphicsContextCGWin.cpp:
- platform/graphics/win/GraphicsContextCairoWin.cpp:
- platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
- platform/graphics/wince/FontWince.cpp:
- platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContextPlatformPrivate::concatCTM): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::drawBitmapPattern):
- platform/graphics/wince/ImageBufferWince.cpp: (WebCore::): (WebCore::BufferedImage::drawPattern):
- platform/graphics/wince/PathWince.cpp: (WebCore::Path::transform):
- platform/graphics/wince/PlatformPathWince.cpp: (WebCore::drawPolygons): (WebCore::PathPolygon::transform): (WebCore::PlatformPathElement::transform): (WebCore::PlatformPath::strokePath): (WebCore::PlatformPath::fillPath): (WebCore::PlatformPath::transform):
- platform/graphics/wince/PlatformPathWince.h: (WebCore::):
- platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::getCTM):
- platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::drawPattern): (WebCore::Image::drawPattern):
- platform/graphics/wx/PathWx.cpp:
- platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozillaGtkWidget):
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::paintWindowedPluginIntoContext):
- rendering/RenderBox.cpp: (WebCore::RenderBox::localTransform):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelScaleData::RenderBoxModelScaleData): (WebCore::RenderBoxModelScaleData::transform): (WebCore::RenderBoxModelScaleData::setTransform): (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality): (WebCore::RenderBoxModelObject::paintBoxShadow):
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::translationForAttributes): (WebCore::RenderForeignObject::localToParentTransform):
- rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::localTransform):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
- rendering/RenderObject.cpp: (WebCore::RenderObject::localTransform): (WebCore::RenderObject::localToParentTransform): (WebCore::RenderObject::absoluteTransform):
- rendering/RenderObject.h:
- rendering/RenderPath.cpp: (WebCore::RenderPath::localToParentTransform): (WebCore::RenderPath::localTransform):
- rendering/RenderPath.h:
- rendering/RenderSVGHiddenContainer.h: (WebCore::RenderSVGHiddenContainer::absoluteTransform):
- rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::localToParentTransform): (WebCore::RenderSVGImage::localTransform):
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::localToBorderBoxTransform): (WebCore::RenderSVGRoot::localToRepaintContainerTransform): (WebCore::RenderSVGRoot::localToParentTransform): (WebCore::RenderSVGRoot::absoluteTransform): (WebCore::RenderSVGRoot::localTransform):
- rendering/RenderSVGRoot.h:
- rendering/RenderSVGText.h: (WebCore::RenderSVGText::localToParentTransform): (WebCore::RenderSVGText::localTransform):
- rendering/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::localToParentTransform): (WebCore::RenderSVGTransformableContainer::localTransform): (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
- rendering/RenderSVGTransformableContainer.h:
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::markerBoundaries): (WebCore::RenderSVGViewportContainer::markerContentTransformation): (WebCore::RenderSVGViewportContainer::viewportTransform): (WebCore::RenderSVGViewportContainer::localToParentTransform): (WebCore::RenderSVGViewportContainer::absoluteTransform):
- rendering/RenderSVGViewportContainer.h:
- rendering/SVGCharacterLayoutInfo.cpp: (WebCore::SVGChar::characterTransform):
- rendering/SVGCharacterLayoutInfo.h: (WebCore::SVGTextChunkWalker::operator()):
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::calculateGlyphBoundaries): (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback): (WebCore::SVGInlineTextBoxSelectionRectWalker::chunkPortionCallback): (WebCore::SVGInlineTextBox::paintCharacters): (WebCore::SVGInlineTextBox::paintDecoration):
- rendering/SVGMarkerLayoutInfo.h: (WebCore::MarkerLayout::MarkerLayout):
- rendering/SVGRenderSupport.cpp: (WebCore::applyTransformToPaintInfo):
- rendering/SVGRenderSupport.h:
- rendering/SVGRenderTreeAsText.cpp: (WebCore::operator<<):
- rendering/SVGRenderTreeAsText.h:
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback): (WebCore::applyTextLengthCorrectionToTextChunk): (WebCore::SVGRootInlineBox::buildLayoutInformation):
- rendering/TransformState.cpp: (WebCore::TransformState::applyTransform):
- rendering/TransformState.h:
- svg/GradientAttributes.h: (WebCore::GradientAttributes::gradientTransform): (WebCore::GradientAttributes::setGradientTransform):
- svg/PatternAttributes.h: (WebCore::PatternAttributes::patternTransform): (WebCore::PatternAttributes::setPatternTransform):
- svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::resetToBaseValue): (WebCore::SVGAnimateMotionElement::calculateAnimatedValue): (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
- svg/SVGAnimateMotionElement.h:
- svg/SVGAnimateTransformElement.cpp:
- svg/SVGAnimateTransformElement.h:
- svg/SVGElement.h: (WebCore::SVGElement::supplementalTransform):
- svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::viewBoxToViewTransform):
- svg/SVGFitToViewBox.h:
- svg/SVGLocatable.cpp: (WebCore::SVGLocatable::getCTM): (WebCore::SVGLocatable::getScreenCTM): (WebCore::SVGLocatable::getTransformToElement):
- svg/SVGLocatable.h:
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::viewBoxToViewTransform):
- svg/SVGMarkerElement.h:
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
- svg/SVGMatrix.idl:
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern):
- svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::getCTM):
- svg/SVGPreserveAspectRatio.h:
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::viewport): (WebCore::SVGSVGElement::createSVGMatrix): (WebCore::SVGSVGElement::createSVGTransformFromMatrix): (WebCore::SVGSVGElement::getCTM): (WebCore::SVGSVGElement::getScreenCTM): (WebCore::SVGSVGElement::viewBoxToViewTransform):
- svg/SVGSVGElement.h:
- svg/SVGStyledLocatableElement.cpp: (WebCore::SVGStyledLocatableElement::getCTM): (WebCore::SVGStyledLocatableElement::getScreenCTM):
- svg/SVGStyledLocatableElement.h:
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::getCTM): (WebCore::SVGStyledTransformableElement::getScreenCTM): (WebCore::SVGStyledTransformableElement::animatedLocalTransform): (WebCore::SVGStyledTransformableElement::supplementalTransform):
- svg/SVGStyledTransformableElement.h: (WebCore::SVGStyledTransformableElement::isStyledTransformable): (WebCore::SVGStyledTransformableElement::toPathData):
- svg/SVGTextContentElement.cpp: (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback):
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::getScreenCTM): (WebCore::SVGTextElement::getCTM): (WebCore::SVGTextElement::animatedLocalTransform): (WebCore::SVGTextElement::supplementalTransform):
- svg/SVGTextElement.h:
- svg/SVGTextPathElement.cpp:
- svg/SVGTransform.cpp: (SVGTransform::SVGTransform): (SVGTransform::matrix): (SVGTransform::setMatrix):
- svg/SVGTransform.h:
- svg/SVGTransformDistance.cpp: (WebCore::SVGTransformDistance::SVGTransformDistance): (WebCore::SVGTransformDistance::scaledDistance): (WebCore::SVGTransformDistance::isZero):
- svg/SVGTransformDistance.h:
- svg/SVGTransformList.cpp: (SVGTransformList::createSVGTransformFromMatrix): (SVGTransformList::concatenate): (SVGTransformList::valueAsString):
- svg/SVGTransformList.h:
- svg/SVGTransformable.cpp: (WebCore::SVGTransformable::getCTM): (WebCore::SVGTransformable::getScreenCTM): (WebCore::SVGTransformable::parseTransformValue):
- svg/SVGTransformable.h: (WebCore::SVGTransformable::):
- svg/graphics/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::gradientTransform): (WebCore::SVGPaintServerGradient::setGradientTransform): (WebCore::clipToTextMask): (WebCore::SVGPaintServerGradient::setup):
- svg/graphics/SVGPaintServerGradient.h:
- svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::patternTransform): (WebCore::SVGPaintServerPattern::setPatternTransform): (WebCore::SVGPaintServerPattern::setup):
- svg/graphics/SVGPaintServerPattern.h:
- svg/graphics/SVGResourceClipper.cpp: (WebCore::SVGResourceClipper::applyClip):
- svg/graphics/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::markerTransformation): (WebCore::SVGResourceMarker::draw):
- svg/graphics/SVGResourceMarker.h:
- svg/graphics/filters/SVGFEImage.cpp:
- svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):
2010-02-08 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Add back an AffineTransform class for use by SVG
https://bugs.webkit.org/show_bug.cgi?id=33750
Some negative zero problems fixed, but new one were added on other places. A seperate
patch should fix it all at once.
use-on-disallowed-foreign-object-3 and 4 had wrong results. The old SVG code
with TransformationMatrix used translateRight, that was wrong at this place and is
fixed now.
- platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt:
- platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
- platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
- svg/dom/SVGMatrix-interface-expected.txt:
- svg/dom/SVGMatrix-interface.xhtml:
2010-02-08 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Add back an AffineTransform class for use by SVG
https://bugs.webkit.org/show_bug.cgi?id=33750
Use AffineTransform instead of TransformationMatrix here.
- tests/TransparencyWinTest.cpp: (WebCore::TEST):
- 12:25 PM Changeset in webkit [54502] by
-
- 3 edits in trunk/WebCore
2010-02-08 Stephen White <senorblanco@chromium.org>
Reviewed by Dimitri Glazkov.
Make an inline function containing a static var out-of-line. This is
a workaround for Xcode 3.1 bug radar 7070016. We tripped on this in
deviceRGBColorSpaceRef on the Chromium canaries. This is a proactive
fix for the same problem in sRGBColorSpaceRef().
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::sRGBColorSpaceRef):
- platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
- 11:42 AM Changeset in webkit [54501] by
-
- 2 edits in trunk/WebKitTools
[Qt] Make overridePreference complain when it does not
support the preference given.
Reviewed by Tor Arne Vestbø.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::overridePreference):
- 11:40 AM Changeset in webkit [54500] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.21
Tagging 1.1.21.
- 11:32 AM Changeset in webkit [54499] by
-
- 8 edits in trunk/WebCore
2010-02-08 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Unify the WorkerContext V8 object wrapping code with
the standard V8 object wrapping code.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
- bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::handleEvent): (WebCore::V8WorkerContextEventListener::getReceiverObject):
- bindings/v8/WorkerContextExecutionProxy.cpp:
- bindings/v8/WorkerContextExecutionProxy.h:
- bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::V8NotificationCenter::createHTMLNotificationCallback): (WebCore::V8NotificationCenter::createNotificationCallback):
- bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::toV8):
- 11:18 AM Changeset in webkit [54498] by
-
- 4 edits in trunk
2010-02-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Bump version to 1.1.21, and adjust library versioning accordingly.
- configure.ac:
- 10:54 AM Changeset in webkit [54497] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
Build fix, add needed export
- 10:30 AM Changeset in webkit [54496] by
-
- 2 edits in trunk/WebKitTools
[Qt] Set stdout/stderr to binary mode for DRT on Windows
Reviewed by Kenneth Rohde Christiansen.
This makes sure we don't end up with lots of CRLFs in the
DRT output, which breaks tons of results. Matches what
the Windows DRT does.
- DumpRenderTree/qt/main.cpp:
- 10:21 AM Changeset in webkit [54495] by
-
- 8 edits in trunk/WebCore
2010-02-08 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Use fastStrDup instead of strdup
https://bugs.webkit.org/show_bug.cgi?id=33943
Replace strdup/free with fastStrDup/fastFree.
- bridge/IdentifierRep.h: (WebCore::IdentifierRep::IdentifierRep):
- bridge/jni/JNIBridge.cpp: (JavaMethod::~JavaMethod): (appendClassName): (JavaMethod::signature):
- bridge/jni/jsc/JavaClassJSC.cpp: (JavaClass::JavaClass): (JavaClass::~JavaClass):
- platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::~ResourceHandleManager): (WebCore::ResourceHandleManager::setCookieJarFileName): (WebCore::ResourceHandleManager::initializeHandle):
- plugins/PluginStream.cpp: (WebCore::PluginStream::~PluginStream): (WebCore::PluginStream::startStream):
- xml/XSLTProcessorLibxslt.cpp: (WebCore::xsltParamArrayFromParameterMap): (WebCore::freeXsltParamArray):
- 10:20 AM Changeset in webkit [54494] by
-
- 2 edits in trunk/WebKit/win
Include header position in World Transform used for plugin positioning.
https://bugs.webkit.org/show_bug.cgi?id=34709
Reviewed by Adam Roben.
- WebFrame.cpp:
(WebFrame::spoolPage): Correct WinCairo plugin print positioning to
account for header size. Existing code ignored this, causing
plugins to overlay other elements.
- 9:37 AM Changeset in webkit [54493] by
-
- 3 edits in trunk/WebKitTools
Build fix for Qt on Windows.
Reviewed by Kenneth Rohde Christiansen.
Don't use noreturn directly since it's a gcc attribute.
Instead use the NO_RETURN macro from AlwaysInline.h
- QtLauncher/QtLauncher.pro:
- QtLauncher/utils.h:
- 9:33 AM Changeset in webkit [54492] by
-
- 2 edits in trunk/LayoutTests
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fix last problematic SVG testcase, update coords-trans-01-b.svg win results, marking the end of the baseline regeneration for all platforms.
- platform/win/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
- 8:09 AM Changeset in webkit [54491] by
-
- 4 edits in trunk/LayoutTests
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Should turn Qt slave green again, all platform specific results updated.
- platform/qt/svg/filters/subRegion-one-effect-expected.txt:
- platform/qt/svg/filters/subRegion-two-effects-expected.txt:
- platform/qt/svg/text/selection-background-color-expected.txt:
- 8:06 AM Changeset in webkit [54490] by
-
- 2 edits1 move in trunk/WebCore
Fix Qt build on Windows.
Reviewed by Simon Hausmann.
nmake fails to pick the right cpp file, so we have to
rename the file to to a unique name.
- WebCore.pro:
- platform/graphics/qt/FontCustomPlatformDataQt.cpp: Renamed from WebCore/platform/graphics/qt/FontCustomPlatformData.cpp.
- 8:01 AM Changeset in webkit [54489] by
-
- 17 edits in trunk/LayoutTests
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Hopefully the last set of updates for Gtk/Qt/Win/Mac.
- platform/gtk/svg/custom/text-zoom-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
- platform/qt/svg/filters/feComposite-expected.txt:
- platform/qt/svg/filters/feGaussianBlur-expected.txt:
- platform/qt/svg/filters/feMerge-expected.txt:
- platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
- platform/qt/svg/filters/feOffset-expected.txt:
- platform/qt/svg/filters/feTile-expected.txt:
- platform/qt/svg/filters/filter-source-position-expected.txt:
- platform/qt/svg/filters/shadow-on-filter-expected.txt:
- platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
- platform/qt/svg/filters/sourceAlpha-expected.txt:
- platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
- platform/win/svg/custom/inline-svg-in-xhtml-expected.txt:
- platform/win/svg/hixie/mixed/003-expected.txt:
- 7:57 AM Changeset in webkit [54488] by
-
- 3 edits in trunk/WebKitTools
Notify user that run-webkit-tests has to be run under Cygwin
Reviewed by Simon Hausmann.
The script will bail out if run under Windows shell or Msys.
- Scripts/run-webkit-tests:
- Scripts/webkitdirs.pm:
- 7:39 AM Changeset in webkit [54487] by
-
- 6 edits in trunk/LayoutTests
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Attempt to fix all mac/win bots (expect for leopard which already passes)
- platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
- platform/mac/svg/custom/junk-data-expected.txt:
- platform/mac/svg/custom/missing-xlink-expected.txt:
- platform/mac/svg/hixie/error/012-expected.txt:
- platform/mac/svg/text/text-intro-05-t-expected.txt:
- 7:09 AM Changeset in webkit [54486] by
-
- 13 edits in trunk/LayoutTests
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Next set of Qt DRT result updates.
- platform/qt/svg/custom/js-update-image-and-display-expected.txt:
- platform/qt/svg/custom/js-update-image-and-display3-expected.txt:
- platform/qt/svg/custom/marker-opacity-expected.txt:
- platform/qt/svg/custom/marker-referencePoint-expected.txt:
- platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt:
- platform/qt/svg/custom/mask-with-default-value-expected.txt:
- platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
- platform/qt/svg/custom/relative-sized-shadow-tree-content-expected.txt:
- platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
- platform/qt/svg/custom/text-xy-updates-SVGList-expected.txt:
- platform/qt/svg/custom/transformedMaskFails-expected.txt:
- platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- 7:04 AM Changeset in webkit [54485] by
-
- 6 edits in trunk/LayoutTests
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Update mac-tiger specific SVG results.
- platform/mac-tiger/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
- platform/mac-tiger/svg/hixie/text/003-expected.txt:
- platform/mac-tiger/svg/hixie/text/003a-expected.txt:
- platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
- platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
- 6:59 AM Changeset in webkit [54484] by
-
- 11 edits4 adds in trunk/LayoutTests
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fixing first set of platform specific SVG results for the Qt port.
Unfortunately the bots exit after 20 test failures, so I can't fix the whole set of expected txt files in one go :(
- platform/qt/svg/css/arrow-with-shadow-expected.txt:
- platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
- platform/qt/svg/css/clippath-with-shadow-expected.txt:
- platform/qt/svg/css/mask-with-shadow-expected.txt:
- platform/qt/svg/css/path-with-shadow-expected.txt:
- platform/qt/svg/css/shadow-and-opacity-expected.txt: Added.
- platform/qt/svg/css/shadow-with-large-radius-expected.txt: Added.
- platform/qt/svg/css/shadow-with-negative-offset-expected.txt: Added.
- platform/qt/svg/css/stars-with-shadow-expected.txt:
- platform/qt/svg/custom/createImageElement-expected.txt:
- platform/qt/svg/custom/createImageElement2-expected.txt:
- platform/qt/svg/custom/empty-mask-expected.txt:
- platform/qt/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt: Added.
- platform/qt/svg/custom/js-update-image-and-display2-expected.txt:
- 6:26 AM Changeset in webkit [54483] by
-
- 747 edits in trunk
2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
All SVG *-expected.txt files contain wrong results
https://bugs.webkit.org/show_bug.cgi?id=34703
Finally dump meaningful information for SVG layout tests.
Use 'absoluteClippedOverflowRect' which goes through the same code paths used
to actually calculate repaint rects etc - instead of the legacy CSS-unaware
code path that mapped 'repaintRectInLocalCoordinates' through 'absoluteTransform'.
Remove absoluteTransform() - a long standing TODO, finally not needed anymore.
Despite SVGRenderTreeAsText, SVGPaintServerGradient was also using absoluteTransform().
Rewrite the code in question, fixing svg/W3C-SVG-1.1/pserver-grad-08-b.svg alignment issues
when scaling/panning text using gradient on stroke/fill. Affects some other gradient tests as well.
As we're now dumping clipped overflow rects any problems with repaint rects will become
immediate visible - it turns out we're not supporting the overflow rules on the outermost <svg>
element properly (repaint rects and bounding boxes need to take special SVG overflow rules into account).
Fixing that magically gives pixel-perfect clipped overflow rects for all types of shapes/text/containers.
Note: This will break any overriden platform-specific SVG results, need to wait for build bots in order to update them.
- rendering/RenderObject.cpp: Remove absoluteTransform() method, centralize overflow query code in SVGRenderSupport::isOverflowHidden().
- rendering/RenderObject.h: Remove absoluteTransform() method.
- rendering/RenderSVGHiddenContainer.h: Ditto.
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode. (WebCore::RenderSVGRoot::computeRectForRepaint): Respect SVG overflow rules here: clip repaintRect against overflow rect _before_ passing
along to RenderBox. This is the key issue behind wrong absoluteClippedOverflowRect() values.
(WebCore::RenderSVGRoot::nodeAtPoint): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode.
- rendering/RenderSVGRoot.h: Remove absoluteTransform(). Don't expose viewportSize() anymore.
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox): Fix default stroke width to 1. This was the only wrong place -> fixes repaint rects for stroked text.
- rendering/RenderSVGViewportContainer.cpp: Remove absoluteTransform() method. (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode.
- rendering/RenderSVGViewportContainer.h: Remove absoluteTransform() method.
- rendering/SVGRenderSupport.cpp: Refactored overflow queries in one place, centralizing SVG specific assumptions about overflowX/Y. (WebCore::SVGRenderBase::isOverflowHidden):
- rendering/SVGRenderSupport.h:
- rendering/SVGRenderTreeAsText.cpp: Dump absoluteClippedOverflowRect() instead of absoluteTransform().mapRect(repaintRectInLocalCoordinates()). (WebCore::writePositionAndStyle): Affects all layout tests dumping render trees.
- svg/graphics/SVGPaintServerGradient.cpp: Rewrite Gradient on text fill/stroke support on Cg, to avoid using absoluteTransform(). (WebCore::absoluteTransformForRenderer): (WebCore::createMaskAndSwapContextForTextGradient): (WebCore::clipToTextMask): (WebCore::SVGPaintServerGradient::setup):
- 5:26 AM Changeset in webkit [54482] by
-
- 7 edits in trunk/WebKitTools
Suppressed check-webkit-style's underscore check in Qt's autotests.
Also made the path-specific filter check case-insensitive.
Reviewed by Shinichiro Hamaji.
https://bugs.webkit.org/show_bug.cgi?id=34574
- Scripts/webkitpy/style/checker.py:
- Added a list element to _PATH_RULES_SPECIFIER for directories that should be excluded from the "readability/naming" category (the category that relates to underscores in identifiers, for example).
- Scripts/webkitpy/style/checker_unittest.py:
- Added an "end-to-end" test for "WebKit/qt/tests/".
- Scripts/webkitpy/style/filter.py:
- Altered FilterConfiguration's should_check() method to check for path substring matches case-insensitively.
- Scripts/webkitpy/style/filter_unittest.py:
- Added a test to check case-insensitive path substring matching.
- Scripts/webkitpy/style/processors/cpp.py:
- Removed the hard-coded "WebKit/gtk/webkit/" path reference since this is now taken care of by the _PATH_RULES_SPECIFIER configuration variable.
- Scripts/webkitpy/style/processors/cpp_unittest.py:
- Removed the unit test for the GTK directory since this is now taken care of by the checker._PATH_RULES_SPECIFIER end-to-end tests.
- 5:21 AM Changeset in webkit [54481] by
-
- 2 edits in trunk/JavaScriptCore
Build fix for make distcheck.
- 5:06 AM Changeset in webkit [54480] by
-
- 2 edits in trunk/LayoutTests
2010-02-08 Xan Lopez <xlopez@igalia.com>
Try to do some clean-up in our Skipped list.
- platform/gtk/Skipped:
- 4:47 AM Changeset in webkit [54479] by
-
- 2 edits in trunk/LayoutTests
2010-02-08 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Generate new results for this test.
- platform/gtk/editing/execCommand/indent-paragraphs-expected.txt:
- 3:04 AM Changeset in webkit [54478] by
-
- 2 edits1 add1 delete in trunk/LayoutTests
2010-02-08 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
Convert editing/execCommand/indent-paragraphs.html to use dumpAsText.
The test copies HTML to the text output, so it doesn't really need
to dump the render tree.
The test was added in r49985, but didn't include pixel results.
https://bugs.webkit.org/show_bug.cgi?id=34625
- platform/mac/editing/execCommand/indent-paragraphs-expected.txt: Modified.
- 2:48 AM Changeset in webkit [54477] by
-
- 2 edits in trunk/WebKitTools
2010-02-08 Leith Bade <leith@leithalweapon.geek.nz>
Reviewed by Darin Adler.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=34637
Corrects the newline inserted into WebKitOutputDir, and WebKitLibrariesDir Windows
environemnt variables when there is a space in the user's /home path.
- Scripts/webkitdirs.pm:
- Added missing quotes around $sourceDir in argument list of cygpath in determineWindowsSourceDir().
- 1:33 AM Changeset in webkit [54476] by
-
- 2 edits in trunk/JavaScriptCore
Unreviewed RVCT build fix.
Similar to r54391, don't import the cmath functions from std:: for RVCT.
- wtf/MathExtras.h:
Feb 7, 2010:
- 4:42 PM Changeset in webkit [54475] by
-
- 5 edits in trunk/LayoutTests
2010-02-07 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
Fix 2 pixel test baselines that are incorrect but passing
the fuzzy image diff.
editing/deleting/5390681.html should show a cursor, but doesn't.
In r42549, whitespace collapsing was changed but
editing/pasteboard/5387578.html's result wasn't updated to
reflect the collapsed whitespace.
https://bugs.webkit.org/show_bug.cgi?id=34632
- platform/mac/editing/deleting/5390681-2-expected.checksum:
- platform/mac/editing/deleting/5390681-2-expected.png:
- platform/mac/editing/pasteboard/5387578-expected.checksum:
- platform/mac/editing/pasteboard/5387578-expected.png:
- 2:26 PM Changeset in webkit [54474] by
-
- 1 edit1 add in trunk/LayoutTests
2010-02-07 Daniel Bates <dbates@webkit.org>
Unreviewed, fix Tiger layout test failure.
Adds expected layout test results for Tiger build.
- platform/mac-tiger/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
- 1:43 PM Changeset in webkit [54473] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-02-07 Daniel Bates <dbates@webkit.org>
Unreviewed, fix layout test bots.
Adds expected layout test results for Leopard, Windows, and Qt ports.
- platform/mac-leopard/fast/lists: Added.
- platform/mac-leopard/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
- platform/qt/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
- platform/win/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
- 1:08 PM Changeset in webkit [54472] by
-
- 9 edits2 adds in trunk
2010-02-07 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
Implements all of the numeric CSS3 list-style-types as per
section 4.3 of the CSS3 Lists module <http://www.w3.org/TR/css3-lists/#numeric>.
Test: fast/lists/w3-css3-list-styles-numeric.html
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSValueKeywords.in:
- inspector/front-end/SourceCSSTokenizer.re2js:
- platform/text/CharacterNames.h: Added constant hyphenMinus.
- rendering/RenderListMarker.cpp: (WebCore::): Defined enum SequenceType. (WebCore::toAlphabeticOrNumeric): Added. (WebCore::toAlphabetic): Modified to call WebCore::toAlphabeticOrNumeric. (WebCore::toNumeric): Added. (WebCore::listMarkerSuffix): (WebCore::listMarkerText): (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcPrefWidths): (WebCore::RenderListMarker::getRelativeMarkerRect):
- rendering/style/RenderStyle.h: (WebCore::):
- rendering/style/RenderStyleConstants.h: Added numeric list style types and fixed indent level for the enum values. (WebCore::):
2010-02-07 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
Tests that all of the numeric CSS3 list-style-types are supported.
- fast/lists/w3-css3-list-styles-numeric.html: Added.
- platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
- 12:47 PM Changeset in webkit [54471] by
-
- 2 edits in trunk/WebCore
2010-02-07 Ismail Donmez <ismail@namtrac.org>
Reviewed by Darin Adler.
Include wtf/StringExtras.h for strdup definition, which
is needed for WinCE.
- bridge/IdentifierRep.h:
- 4:52 AM Changeset in webkit [54470] by
-
- 6 edits in trunk
2010-02-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Fragment-held Elements Not Shown in Inspector.
- inspector/console-dirxml-expected.txt:
- inspector/console-dirxml.html:
2010-02-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Fragment-held Elements Not Shown in Inspector.
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::buildObjectForNode):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
- 4:35 AM Changeset in webkit [54469] by
-
- 7 edits in trunk
2010-02-07 Jian Li <jianli@chromium.org>
Reviewed by Darin Fisher.
[chromium] Change chromium interface to handle DownloadURL format.
https://bugs.webkit.org/show_bug.cgi?id=34655
- platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::clear): (WebCore::ChromiumDataObject::hasData): (WebCore::ChromiumDataObject::ChromiumDataObject):
- platform/chromium/ChromiumDataObject.h:
- platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::setData):
2010-02-07 Jian Li <jianli@chromium.org>
Reviewed by Darin Fisher.
[chromium] Change chromium interface to handle DownloadURL format.
https://bugs.webkit.org/show_bug.cgi?id=34655
- public/WebDragData.h:
- src/WebDragData.cpp: (WebKit::WebDragData::downloadMetadata): (WebKit::WebDragData::setDownloadMetadata):
- 3:42 AM Changeset in webkit [54468] by
-
- 2 edits2 adds in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] Missing fast/frames/flattening/resources/frameset-flattening-subframe-resize.html
https://bugs.webkit.org/show_bug.cgi?id=34662
Missing file added from the original bug: https://bugs.webkit.org/show_bug.cgi?id=32717
- fast/frames/flattening/resources: Added.
- fast/frames/flattening/resources/frameset-flattening-subframe-resize.html: Added.
- platform/qt/Skipped: frameset-flattening-subframe-resize.html unskipped.
- 3:28 AM Changeset in webkit [54467] by
-
- 211 moves in tags/old
Move aside some old tags.
