Timeline
Feb 23, 2010:
- 11:40 PM Changeset in webkit [55183] by
-
- 2 edits1 add in trunk/LayoutTests
Rubber-stamped by Simon Hausmann.
[Qt] editing/execCommand/delete-image-in-anchor.html skipped
because of missing layoutTestController.execCommand()
Qt specific expected file added for editing/execCommand/insert-list-xml.xhtml
introduced in r55167, because of different font types.
- platform/qt/Skipped: editing/execCommand/delete-image-in-anchor.html skipped.
- platform/qt/editing/execCommand/insert-list-xml-expected.txt: Added.
- 11:14 PM Changeset in webkit [55182] by
-
- 3 edits in trunk/WebCore
2010-02-23 Geoff Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Simplify animation lifetime handling. Previously we manually
determined whether our base element was safe when we unregistered
our listener, now we simply ensure that the base element itself
registers and unregisters the animation listener.
- svg/animation/SVGSMILElement.cpp: (WebCore::ConditionEventListener::create): (WebCore::ConditionEventListener::disconnectAnimation): (WebCore::ConditionEventListener::ConditionEventListener): (WebCore::ConditionEventListener::operator==): (WebCore::ConditionEventListener::handleEvent): (WebCore::SVGSMILElement::eventBaseFor): (WebCore::SVGSMILElement::connectConditions): (WebCore::SVGSMILElement::disconnectConditions):
- svg/animation/SVGSMILElement.h:
- 8:27 PM Changeset in webkit [55181] by
-
- 5 edits in trunk
2010-02-23 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Web Inspector: Regression: r55027+: Inspector broken
https://bugs.webkit.org/show_bug.cgi?id=35253
op_get_by_id_getter_chain was not passing the correct this parameter.
The bug was caused by incorrect use of baseCell instead of baseValue,
baseValue contains the original object for the lookup (and hence the
correct this object), baseCell is clobbered as part of walking the
prototype chain.
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
2010-02-23 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Web Inspector: Regression: r55027+: Inspector broken
https://bugs.webkit.org/show_bug.cgi?id=35253
Add thorough testing of getter access to hit the various
possible caching scenarios.
- fast/js/pic/cached-getter-setter-expected.txt:
- fast/js/pic/cached-getter-setter.html:
- 7:43 PM Google Summer of Code 2010 edited by
- (diff)
- 6:05 PM Changeset in webkit [55180] by
-
- 3 edits in trunk/WebCore
Chromium: Use V8::TerminateExecution to actually terminate workers.
https://bugs.webkit.org/show_bug.cgi?id=35137
Reviewed by David Levin.
Test: existing fast/workers/stress-js-execution.html which is currently failing
on Mac and Linux bots for Chromium.
- bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::evaluate):
- bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::forbidExecution):
- 5:53 PM Changeset in webkit [55179] by
-
- 3 edits2 adds in trunk
REGRESSION: WebKit crashes when deleting images on blogger.com (34957)
<rdar://problem/7651935>
https://bugs.webkit.org/show_bug.cgi?id=34957
Reviewed by Simon Fraser.
WebCore:
Fixing a regression introduced with revision 53085. Anchor elements should not be considered
in editable content when calculating the position in the parent before the node.
Test: editing/execCommand/delete-image-in-anchor.html
- dom/Position.cpp:
(WebCore::Position::getInlineBoxAndOffset):
LayoutTests:
- editing/execCommand/delete-image-in-anchor-expected.txt: Added.
- editing/execCommand/delete-image-in-anchor.html: Added.
- 5:46 PM Changeset in webkit [55178] by
-
- 3 edits2 adds in trunk
2010-02-23 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=34634
Pasting a list into the middle of another list item should split the target
list item into two separate list items. This matches the behavior in other
browsers.
- editing/pasteboard/paste-list-004-expected.txt: Added.
- editing/pasteboard/paste-list-004.html: Added.
2010-02-23 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=34634
Pasting a list into the middle of another list item should split the target
list item into two separate list items. This matches the behavior in other
browsers.
Test: editing/pasteboard/paste-list-004.html
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::insertAsListItems):
- 5:22 PM Changeset in webkit [55177] by
-
- 7 edits7 adds4 deletes in trunk
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=22602
Enable Java in DumpRenderTree (on Mac)
LayoutTests:
- fast/dom/java-applet-calls-expected.txt: Removed.
- fast/dom/java-applet-calls.html: Removed.
- fast/dom/resources/TestApplet.class: Removed.
- fast/dom/resources/TestApplet.java: Removed. This test was added in a failing form, even though it never worked. The new tests cover everything it was meant to cover.
- java/SharedApplet.java: Added. This class will have methods for simple tests, but it's also possible to just add new source files.
- java/Makefile: Added. Compile all .java files in the directory.
- java: Added.
- java/argument-to-object-type-expected.txt: Added.
- java/argument-to-object-type.html: Added.
- java/array-return-expected.txt: Added.
- java/array-return.html: Added. Added tests for recently fixed bugs.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped: Java tests only work on Mac currently.
WebKitTools:
- DumpRenderTree/mac/DumpRenderTree.mm: (exitApplicationRunLoop): (dump): (runTest): DumpRenderTree now runs an NSApplication, not just an event loop. This way, the Java plug-in can start without freezing.
- Scripts/run-webkit-tests: Compile java sources in LayputTests/java.
- 4:56 PM Changeset in webkit [55176] by
-
- 1 edit1 add in trunk/LayoutTests
2010-02-23 Oliver Hunt <oliver@apple.com>
Add expected result
- svg/custom/animate-use-crash-expected.txt: Added.
- 4:49 PM Changeset in webkit [55175] by
-
- 1 edit1 add in trunk/LayoutTests
2010-02-23 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Add a testcase for an old bug to ensure it doesn't return.
- svg/custom/animate-use-crash.xhtml: Added.
- 3:34 PM Google Summer of Code 2010 edited by
- (diff)
- 3:01 PM Google Summer of Code 2010 created by
- GSoC 2010 page - in case we want to participate
- 2:59 PM Changeset in webkit [55174] by
-
- 3 edits in trunk
2010-02-23 James Choi <jchoi42@pha.jhu.edu>
Add Solaris definitions
https://bugs.webkit.org/show_bug.cgi?id=35214
- WebKit/chromium/src/WebViewImpl.cpp
- WebKit/chromium/src/WebFrameImpl.cpp
- 2:43 PM Changeset in webkit [55173] by
-
- 4 edits2 adds in trunk
2010-02-23 Arno Renevier <arno@renevier.net>
Reviewed by Gustavo Noronha Silva.
[Gtk]: testwebview does not work when called with absolute path
https://bugs.webkit.org/show_bug.cgi?id=34940
When testwebview is called as absolute path, chdir to executable
directory before searching resource files.
- GNUmakefile.am:
- 2:39 PM Changeset in webkit [55172] by
-
- 12 edits in trunk
Regression (r55107) - WebInspector docking is busted.
https://bugs.webkit.org/show_bug.cgi?id=35274
Reviewed by Tim Hatcher and Pavel Feldman.
WebCore:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::canAttachWindow): Use the minimum height for this calculation,
not the preferred height.
(WebCore::InspectorController::attachWindow): attachWindow() shouldn't decide the policy, as it is
often called partway through the show or dock procedure after some of the initial conditions have
changed. Let the front-end itself and the InspectorClient's make the policy decision at the start
of the show/dock operation.
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::canAttachWindow):
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
- inspector/front-end/inspector.js:
(WebInspector.toggleAttach): Before attaching, ask the front-end-host if attaching is allowed.
WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController showWindow:]): Swap the order of the "should attach?" check
to get the expected behavior.
WebKit/win:
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::showWindowWithoutNotifications): Swap the order of the "should attach?" check
to get the expected behavior.
LayoutTests:
- inspector/timeline-event-dispatch.html: Actually click in the right place now that the inspector isn't docked anymore.
- 2:17 PM Changeset in webkit [55171] by
-
- 3 edits in trunk/WebKit/chromium
2010-02-23 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Implement WebDocument::getElementsByTagName.
- public/WebDocument.h:
- src/WebDocument.cpp: (WebKit::WebDocument::getElementsByTagName):
- 2:03 PM Changeset in webkit [55170] by
-
- 2 edits in trunk/WebKitSite
2010-02-23 Jessie Berlin <jberlin@webkit.org>
Reviewed by Eric Seidel and Adam Roben.
Debugging WebKit on Windows should mention WebKit.sln as an alternative to running debug-safari.
https://bugs.webkit.org/show_bug.cgi?id=35098
- building/debug.html: Add instructions on how to build and run WebKit from within Visual Studio.
- 2:01 PM Changeset in webkit [55169] by
-
- 2 edits in trunk/WebCore
<http://webkit.org/b/35287> ImageSourceCG::frameIsCompleteAtIndex returns false for all frames until image has completed loading
Reviewed by Geoff Garen.
CGImageSourceGetStatusAtIndex claims that all frames of a multi-frame image are incomplete when we've not yet received the
complete data for an image that is using an incremental data source (<rdar://problem/7679174>). We work around this by
special-casing all frames except the last in an image and treating them as complete if they are present and reported as
being incomplete. We do this on the assumption that loading new data can only modify the existing last frame or append new
frames. The last frame is only treated as being complete if the image source reports it as such. This ensures that it is
truly the last frame of the image rather than just the last that we currently have data for.
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::frameIsCompleteAtIndex):
- 1:31 PM Changeset in webkit [55168] by
-
- 2 edits in trunk/WebKit/gtk/po
2010-02-23 Mario Blättermann <mariobl@freenet.de>
Reviewed by Gustavo Noronha.
German translation update.
- de.po:
- 1:31 PM Changeset in webkit [55167] by
-
- 6 edits2 adds in trunk
WebCore: Crash in createContextualFragment when inserting a list in a non HTML document.
<rdar://problem/7666670>
https://bugs.webkit.org/show_bug.cgi?id=35305
Reviewed by Darin Adler.
createFragmentFromMarkup did not handle correctly the case where documentElement is
not an HTMLElement. The static cast to HTMLElement was causing createContextualFragment to
crash.
Test: editing/execCommand/insert-list-xml.xhtml
- dom/Element.cpp:
(WebCore::Element::createContextualFragment): Added.
- dom/Element.h: Added createContextualFragment virtual function.
- editing/markup.cpp:
(WebCore::createFragmentFromMarkup): Removed static cast to HTMLElement.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::createContextualFragment): Modified to perform only checks
that are specific for an HTMLElement object. The rest of the logic has been moved to the
corresponding method in the Element class.
LayoutTests: Crash in createContextualFragment when inserting a list in a non HTML document.
<rdar://problem/7666670>
https://bugs.webkit.org/show_bug.cgi?id=35305
Reviewed by Darin Adler.
- editing/execCommand/insert-list-xml-expected.txt: Added.
- editing/execCommand/insert-list-xml.xhtml: Added.
- 1:25 PM Changeset in webkit [55166] by
-
- 2 edits in trunk/WebKit/gtk/po
2010-02-23 Daniel Nylander <po@danielnylander.se>
Reviewed by Gustavo Noronha.
Swedish translation update.
- sv.po:
- 1:20 PM Changeset in webkit [55165] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2010-02-23 Ankit Patel <ankit@redhat.com>
Reviewed by Gustavo Noronha.
Gujarati translation.
- gu.po: Added.
- 1:13 PM Changeset in webkit [55164] by
-
- 2 edits in trunk/WebKitTools
2010-02-23 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Need a final integration between QtLauncher and QGVLauncher
https://bugs.webkit.org/show_bug.cgi?id=35292
WebKit coding style fixes.
- QtLauncher/main.cpp: (LauncherWindow::resetZoom):
- 12:39 PM Changeset in webkit [55163] by
-
- 2 edits in trunk/WebKitTools
2010-02-23 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Need a final integration between QtLauncher and QGVLauncher
https://bugs.webkit.org/show_bug.cgi?id=35292
Add cloneWindow feature to QtLauncher, when running on QGraphicsView mode.
- QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::~LauncherWindow): (LauncherWindow::init): (LauncherWindow::cloneWindow): (LauncherWindow::setupUI):
- 12:07 PM Changeset in webkit [55162] by
-
- 2 edits in trunk/WebCore
2010-02-23 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
WebCore should stop throwing away the CGImageSourceRef on Windows to improve GIF performance
https://bugs.webkit.org/show_bug.cgi?id=35309
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::clear):
- 10:15 AM Changeset in webkit [55161] by
-
- 2 edits in trunk/WebKitTools
fix check_wdiff_install
- 10:07 AM Changeset in webkit [55160] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-23 Gustavo Noronha Silva <Gustavo Noronha Silva>
Rubber-stamped by Dimitri Glazkov.
Chromium build fix.
- JavaScriptCore.gyp/JavaScriptCore.gyp:
- 9:54 AM Changeset in webkit [55159] by
-
- 3 edits4 adds in trunk
WebKit/mac: <rdar://problem/7611158> Incomplete repaint of YouTube timeline thumb while scrolling
https://bugs.webkit.org/show_bug.cgi?id=34381
Reviewed by Simon Fraser.
Test: fast/repaint/repaint-during-scroll.html
NSClipView offsets any rects marked as needing display during scrolling
by the scroll offset. Compensate for this when -setNeedsDisplay: is called
during scrolling.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _frameOrBoundsChanged]): Set inScrollPositionChanged to YES
around to call to FrameView::scrollPositionChanged().
(-[WebHTMLView setNeedsDisplayInRect:]): When called beneath
scrollPositionChanged(), adjust the rect by the inverse of the scroll offset.
LayoutTests: Rubber-stamped by Simon Fraser.
<rdar://problem/7611158> Incomplete repaint of YouTube timeline thumb while scrolling
https://bugs.webkit.org/show_bug.cgi?id=34381
- fast/repaint/repaint-during-scroll.html: Added.
- platform/mac/fast/repaint/repaint-during-scroll-expected.checksum: Added.
- platform/mac/fast/repaint/repaint-during-scroll-expected.png: Added.
- platform/mac/fast/repaint/repaint-during-scroll-expected.txt: Added.
- 9:52 AM Changeset in webkit [55158] by
-
- 10 edits in trunk
2010-02-23 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Changes references of GOwnPtr to reflect their new place.
http://webkit.org/b/35084
- 9:41 AM Changeset in webkit [55157] by
-
- 9 edits5 adds in trunk
HTTP 307 after a 303 after a POST re-sends POST data from the original request.
<rdar://problem/7390251> and https://bugs.webkit.org/show_bug.cgi?id=31410
Reviewed by Alexey Proskuryakov.
WebCore:
Test: http/tests/loading/307-after-303-after-post.html
Remember the last HTTP method send out during a redirect chain for a resource handle:
- platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::lastHTTPMethod):
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
Refer to the last HTTP method used instead of the original method:
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willSendRequest):
(WebCore::ResourceHandle::willSendRequest):
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::willSendRequest):
(-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
LayoutTests:
- http/tests/loading/307-after-303-after-post.html: Added.
- http/tests/loading/resources/303-to-307-target.php: Added.
- http/tests/loading/resources/307-post-output-target.php: Added.
- http/tests/loading/resources/post-to-303-target.php: Added.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 9:27 AM Changeset in webkit [55156] by
-
- 2 edits in trunk/WebCore
2010-02-23 Crystal Zhang <haizhang@rim.com>
Unreviewed build fix.
Fix build error when enable plugin proxy: 'toRenderEmbeddedObject' identifier not found.
As RenderEmbeddedObject inherits RenderPartObject and 'toRenderEmbeddedObject' belongs
to former one.
- html/HTMLMediaElement.cpp:
- 8:53 AM Changeset in webkit [55155] by
-
- 3 edits in trunk/WebCore
2010-02-23 Evan Martin <evan@chromium.org>
Reviewed by Jeremy Orlow.
[chromium] fix previous SVG-disabling patch
https://bugs.webkit.org/show_bug.cgi?id=35298
- WebCore.gypi: rename variable
- WebCore.gyp/WebCore.gyp: actually use the variable
- 8:32 AM Changeset in webkit [55154] by
-
- 2 edits in trunk/WebCore
2010-02-23 Michael Lotz <mmlr@mlotz.ch>
Reviewed by David Levin.
[Haiku] Fix conversion from BString to String
https://bugs.webkit.org/show_bug.cgi?id=35082
The previous patch to this file was broken (sorry). First of all,
the conversion from UTF8 was accidentally removed. Second, for
empty strings, we need to point the implementation at StringImpl::empty().
Covered by existing tests.
- platform/text/haiku/StringHaiku.cpp: (WebCore::String::String):
- 8:00 AM Changeset in webkit [55153] by
-
- 2 edits in trunk/WebCore
[Qt] Prevent the media backend from handling non-audio or -video mime types
Reviewed by Eric Carlson.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp:
- 7:46 AM Changeset in webkit [55152] by
-
- 5 edits in trunk/WebCore
2010-02-23 Evan Martin <evan@chromium.org>
Reviewed by Jeremy Orlow.
[chromium] Allow building without SVG
https://bugs.webkit.org/show_bug.cgi?id=31522
- WebCore.gyp/WebCore.gyp, WebCore.gypi: test enable_svg flag.
- bindings/v8/custom/V8SVGDocumentCustom.cpp, bindings/v8/custom/V8SVGPathSegCustom.cpp: test ENABLE(SVG).
- 7:28 AM Changeset in webkit [55151] by
-
- 3 edits in trunk/WebKitTools
2010-02-23 Leandro Pereira <leandro@profusion.mobi>
Reviewed by NOBODY.
Fix false positives for 'delete *pointer' statements.
http://webkit.org/b/35235
- WebKitTools/Scripts/webkitpy/style/processors/cpp.py:
- 7:21 AM Changeset in webkit [55150] by
-
- 7 edits in trunk
2010-02-23 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Fixes references to GOwnPtr and GRefPtr so the GTK+ port builds
again.
http://webkit.org/b/35084
- 6:35 AM Companies and Organizations that have contributed to WebKit edited by
- (diff)
- 6:21 AM Changeset in webkit [55149] by
-
- 2 edits4 moves1 add in trunk/JavaScriptCore
2010-02-23 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Adding the EFL implementation of JavaScriptCore.
See https://bugs.webkit.org/show_bug.cgi?id=35084 for details.
- GNUmakefile.am: Updated to reflect the new location of GOwnPtr and
GRefPtr.
- wtf/efl/MainThreadEfl.cpp: Added.
- wtf/gobject/GOwnPtr.cpp: Moved from wtf/gtk.
- wtf/gobject/GOwnPtr.h: Moved from wtf/gtk.
- wtf/gobject/GRefPtr.cpp: Moved from wtf/gtk.
- wtf/gobject/GRefPtr.h: Moved from wtf/gtk.
- 6:17 AM Changeset in webkit [55148] by
-
- 2 edits in trunk/WebCore
2010-02-23 Ariya Hidayat <ariya.hidayat@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Faster cut-off for rectangle drawing without shadow.
https://bugs.webkit.org/show_bug.cgi?id=35267
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect):
- 6:05 AM Changeset in webkit [55147] by
-
- 7 edits in trunk
2010-02-23 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Removes redundant Settings::setGeolocationEnabled and Settings::geolocationEnabled
https://bugs.webkit.org/show_bug.cgi?id=35242
No new tests, removing dead code only.
- page/Settings.cpp:
- page/Settings.h:
2010-02-23 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Removes redundant Settings::setGeolocationEnabled and Settings::geolocationEnabled
https://bugs.webkit.org/show_bug.cgi?id=35242
This removes Chromium's WebSettings::setGeolocationEnabled
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
- src/WebSettingsImpl.h:
- 5:12 AM Changeset in webkit [55146] by
-
- 8 edits in trunk
2010-02-23 Ben Murdoch <benm@google.com>
Reviewed by Eric Seidel.
pageX/Y co-ordinates of TouchEvent should be 0,0
https://bugs.webkit.org/show_bug.cgi?id=35239
Update layout tests to reflect the WebCore changes in this bug.
- fast/events/touch/basic-multi-touch-events-expected.txt: Updated.
- fast/events/touch/basic-single-touch-events-expected.txt: Updated.
- fast/events/touch/script-tests/basic-multi-touch-events.js: (verifyTouchEvent): Add checking of TouchEvent.pageX/Y
- fast/events/touch/script-tests/basic-single-touch-events.js: (verifyTouchEvent): ditto.
2010-02-23 Ben Murdoch <benm@google.com>
Reviewed by Eric Seidel.
pageX/Y co-ordinates of TouchEvent should be 0,0
https://bugs.webkit.org/show_bug.cgi?id=35239
The co-ordinates attached to a touch event are not used for tracking touch motion, rather the co-ordinates attached to Touches within the touch event should be used. Set the co-ordinates on the event itself to 0 to avoid confusion and match observed iPhone behavior.
- page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent): Set the pageX/Y and screenX/Y co-ordinates attached to the touch event to 0,0 to match observed behavior on the iPhone.
- page/EventHandler.h: Remove now unused members m_firstTouchScreenPos and m_firstTouchPagePos.
- 4:53 AM Changeset in webkit [55145] by
-
- 2 edits in trunk/WebCore
2010-02-23 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
[Haiku] Various improvements to EventHandlerHaiku.
https://bugs.webkit.org/show_bug.cgi?id=34685
Covered by existing tests.
Fix the build by not including PlatformScrollBar.h.
- page/haiku/EventHandlerHaiku.cpp: (WebCore::isKeyboardOptionTab):
Use the correct keycode for tab keys.
(WebCore::EventHandler::focusDocumentView):
Use proper locking. In any case, Haiku doesn't append platform
widgets to WebCore widgets. But if it did, this implementation
would be correct.
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
Implemented.
(WebCore::EventHandler::eventActivatedView):
Removed notImplemented() and added note.
(WebCore::EventHandler::passMousePressEventToSubframe):
Implemented.
(WebCore::EventHandler::passMouseMoveEventToSubframe):
Implemented.
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
Implemented.
(WebCore::EventHandler::accessKeyModifiers):
Added note.
- 4:43 AM Changeset in webkit [55144] by
-
- 7 edits in trunk
2010-02-23 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
[Gtk] Implement layoutTestController.numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=35228
- platform/gtk/Skipped:
2010-02-23 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
[Gtk] Implement layoutTestController.numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=35228
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp: (webkit_web_frame_number_of_pages):
2010-02-23 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
[Gtk] Implement layoutTestController.numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=35228
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::numberOfPages):
- 4:27 AM Changeset in webkit [55143] by
-
- 3 edits2 deletes in trunk
2010-02-23 Tony Chang <tony@chromium.org>
Not reviewed.
Revert r55135 because the layout test is failing on all the bots.
https://bugs.webkit.org/show_bug.cgi?id=34634
- editing/pasteboard/paste-list-004-expected.txt: Removed.
- editing/pasteboard/paste-list-004.html: Removed.
2010-02-23 Tony Chang <tony@chromium.org>
Not reviewed.
Revert r55135 because the layout test is failing on all the bots.
https://bugs.webkit.org/show_bug.cgi?id=34634
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::insertAsListItems):
- 4:07 AM Changeset in webkit [55142] by
-
- 7 edits2 adds in trunk/WebCore
Adds cache to store Geolocation positions between browser sessions.
https://bugs.webkit.org/show_bug.cgi?id=34084
Reviewed by Ariya Hidayat.
This is required to fully implement the Geolocation maximumAge property.
See Bug 30676.
No new tests, will add tests for maximumAge once complete.
- Android.mk: Modified. Added GeolocationPositionCache.cpp
- GNUmakefile.am: Modified. Added GeolocationPositionCache.[cpp|h]
- WebCore.gypi: Modified. Added GeolocationPositionCache.[cpp|h]
- WebCore.pro: Modified. Added GeolocationPositionCache.[cpp|h]
- WebCore.vcproj/WebCore.vcproj: Modified. Added GeolocationPositionCache.[cpp|h]
- WebCore.xcodeproj/project.pbxproj: Modified. Added GeolocationPositionCache.[cpp|h]
- page/GeolocationPositionCache.cpp: Added.
(WebCore::GeolocationPositionCache::GeolocationPositionCache):
(WebCore::GeolocationPositionCache::~GeolocationPositionCache):
(WebCore::GeolocationPositionCache::setCachedPosition):
(WebCore::GeolocationPositionCache::cachedPosition):
(WebCore::GeolocationPositionCache::setDatabasePath):
(WebCore::GeolocationPositionCache::readFromDB):
(WebCore::GeolocationPositionCache::writeToDB):
- page/GeolocationPositionCache.h: Added.
- 4:04 AM Changeset in webkit [55141] by
-
- 3 edits2 adds in trunk
2010-02-23 Yuta Kitamura <yutak@chromium.org>
Reviewed by Dan Bernstein.
Fix alignment of vertical-align: text-bottom inside an inline-block.
This patch is based on a fix provided by Takahito Hirano.
display: inline-block + vertical-align: text-bottom causes misalignment.
https://bugs.webkit.org/show_bug.cgi?id=30846
- fast/inline-block/inline-block-vertical-align-2.html: Added.
- fast/inline-block/inline-block-vertical-align-2-expected.txt: Added.
2010-02-23 Yuta Kitamura <yutak@chromium.org>
Reviewed by Dan Bernstein.
Fix alignment of vertical-align: text-bottom inside an inline-block.
This patch is based on a fix provided by Takahito Hirano.
display: inline-block + vertical-align: text-bottom causes misalignment.
https://bugs.webkit.org/show_bug.cgi?id=30846
Test: fast/inline-block/inline-block-vertical-align-2.html
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::verticalPosition): Fixed vpos calculation. We cannot cut corners for inline blocks, since they may have their own text metrics.
- 3:43 AM Changeset in webkit [55140] by
-
- 3 edits in trunk/WebCore
Sets default values of V8 runtime enabler flags to match behavior with JSC
https://bugs.webkit.org/show_bug.cgi?id=35095
- 3:25 AM Changeset in webkit [55139] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-23 José Millán Soto <jmillan@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Server message not shown on http authentication
https://bugs.webkit.org/show_bug.cgi?id=34219
- webkit/webkitsoupauthdialog.c: (show_auth_dialog): Server message is displayed, messageLabel and message variables were renamed to avoid confusion.
- 3:09 AM Changeset in webkit [55138] by
-
- 2 edits in trunk/WebCore
2010-02-23 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
[Haiku] Fix various issues in keyboard event generation.
https://bugs.webkit.org/show_bug.cgi?id=34685
Covered by existing tests.
Fixed backspace keycode.
Fixed using the appropriate fields from the Haiku event for mapping
to the VK_* codes and added mapping a great deal more codes.
Added extraction of modifier key flags.
Completed implementation of disambiguateKeyDownEvent()
Implemented currentCapsLockState().
- platform/haiku/PlatformKeyboardEventHaiku.cpp: (WebCore::keyIdentifierForHaikuKeyCode): (WebCore::windowsKeyCodeForKeyEvent): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): (WebCore::PlatformKeyboardEvent::currentCapsLockState):
- 2:53 AM Changeset in webkit [55137] by
-
- 4 edits in trunk/WebKit/chromium
2010-02-23 Dmitriy Belenko <dbelenko@google.com>
Reviewed by Darin Fisher.
Chromium: Need to be able to get the bounds of selection
rectangle(s)
https://bugs.webkit.org/show_bug.cgi?id=34915
This change will enable about 30 test cases to pass in Chromium.
All of these test cases are related to selection rect boundaries.
This change will enable the test cases to retrieve the selection
rect boundary rectangle for the current selection.
- public/WebFrame.h:
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectionBoundsRect):
- src/WebFrameImpl.h:
- 2:35 AM Changeset in webkit [55136] by
-
- 20 edits in trunk
Adds Client::cancelGeolocationPermissionRequestForFrame and ChromeClient::cancelGeolocationPermissionRequestForFrame
https://bugs.webkit.org/show_bug.cgi?id=34962
These methods are required so that a Geolocation object can cancel an
asynchronous permission request. This allows the chrome client to cancel
any UI it is showing for the permission request.
- 2:19 AM Changeset in webkit [55135] by
-
- 3 edits2 adds in trunk
2010-02-23 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=34634
Pasting a list into the middle of another list item should split the target
list item into two separate list items. This matches the behavior in other
browsers.
- editing/pasteboard/paste-list-004-expected.txt: Added.
- editing/pasteboard/paste-list-004.html: Added.
2010-02-23 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=34634
Pasting a list into the middle of another list item should split the target
list item into two separate list items. This matches the behavior in other
browsers.
Test: editing/pasteboard/paste-list-004.html
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::insertAsListItems):
- 2:03 AM Changeset in webkit [55134] by
-
- 3 edits in trunk/WebKitTools
2010-02-23 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QtLauncher should not use internal JavaScriptCore and WebCore interfaces
https://bugs.webkit.org/show_bug.cgi?id=35248
- QtLauncher/QtLauncher.pro:
- QtLauncher/utils.h:
- 1:55 AM Changeset in webkit [55133] by
-
- 2 edits in trunk/WebCore
[Qt] Correct build problems while building QtWebKit inside Qt.
https://bugs.webkit.org/show_bug.cgi?id=34975
Reviewed by Laszlo Gombos.
- WebCore.pro: Change the condition !standalone_package to !QTDIR_build
- 1:47 AM Changeset in webkit [55132] by
-
- 5 edits in trunk/WebCore
2010-02-23 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Connect video with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=35276
MediaControlPrivate and GraphicsLayer are patched together via
a shared PlatformLayer (QGraphicsItem). This patch makes sure that the
QGraphicsVideoItem from MediaControl becomes part of the scene
associsated with GraphicsLayer
Test: http://double.co.nz/video_test/test1.html with AC turned on
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::): mediaLayer member (WebCore::GraphicsLayerQtImpl::opaqueArea): video is opaque (WebCore::GraphicsLayerQtImpl::paint): don't paint video (WebCore::GraphicsLayerQtImpl::flushChanges): flush mediaLayer (WebCore::GraphicsLayerQt::setContentsToMedia): notify
- platform/graphics/qt/GraphicsLayerQt.h: reimp setContentsToMedia
- platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): m_compositing (WebCore::MediaPlayerPrivate::paint): don't paint if compositing (WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged): reimp from MediaPlayerPrivateInterface to support AC (WebCore::MediaPlayerPrivate::platformLayer): ditto
- platform/graphics/qt/MediaPlayerPrivateQt.h: (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering): ditto
- 1:31 AM Changeset in webkit [55131] by
-
- 3 edits in trunk/WebKitTools
2010-02-23 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Prompts a person for their SVN username if not already cached (by Subversion).
Currently, webkit-patch is unable to commit to the SVN repo. unless the
WebKit SVN username is already cached (from of a prior commit by hand)
because "svn commit" (called by webkit-patch) defaults to using the system
login name unless the username is already cached or specified on the
command line.
- Scripts/webkitpy/scm.py: Added methods SVN.has_authorization_for_realm and modified SVN.commit_with_message to call it. Added optional username parameter to method SVN.commit_with_message.
- Scripts/webkitpy/scm_unittest.py: Added unit test methods: SVNTest.test_commit_with_username, SVNTest.test_has_authorization_for_realm, and SVNTest.test_not_have_authorization_for_realm.
- 1:14 AM Changeset in webkit [55130] by
-
- 2 edits in trunk/WebCore
2010-02-23 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
Fix various issues in PlatformWheelEventHaiku.
https://bugs.webkit.org/show_bug.cgi?id=34685
Covered by existing tests.
Fixed coding style violations.
Synced extracting the correct coordinates with Haiku WebKit implementation.
Added extracting modifier key flags.
- platform/haiku/PlatformWheelEventHaiku.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- 1:02 AM Changeset in webkit [55129] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-23 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Do not do unnecessary work during size_allocate.
FrameView::resize will already queue a layout, so there's no need
to force one ourselves. On top of that, the layout function
already adjusts the view size when needed, so there's no need to
do that manually either. No change in the layout tests or unit
tests after this.
- webkit/webkitwebview.cpp: (webkit_web_view_size_allocate):
- 12:58 AM Changeset in webkit [55128] by
-
- 4 edits in trunk/WebCore
2010-02-23 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
Build fix for PluginView
https://bugs.webkit.org/show_bug.cgi?id=35230
No new tests, build fix only.
- plugins/PluginView.cpp:
- plugins/PluginView.h:
- plugins/PluginViewNone.cpp:
- 12:42 AM Changeset in webkit [55127] by
-
- 2 edits in trunk
2010-02-23 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Eric Seidel.
[gtk] missing libsoup-2.4 package in gir generation
https://bugs.webkit.org/show_bug.cgi?id=35199
Include libsoup-2.4 package in gobject introspection .gir generation.
- GNUmakefile.am:
- 12:26 AM Changeset in webkit [55126] by
-
- 1 edit1 add in trunk/WebCore
2010-02-23 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Port ScriptController::createScriptInstanceForWidget
https://bugs.webkit.org/show_bug.cgi?id=34413
- bindings/js/ScriptControllerBrew.cpp: Added. (WebCore::ScriptController::createScriptInstanceForWidget):
- 12:19 AM Changeset in webkit [55125] by
-
- 3 edits in trunk/LayoutTests
2010-02-18 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
media/video-display-aspect-ratio.html fails
https://bugs.webkit.org/show_bug.cgi?id=34933
Original patch by Eric Carlson.
- media/content/test-par-16-9.mp4: Change the width of the video track from 426.666 to 426.
- platform/mac-leopard/Skipped: Unskip the test, it should pass now.
- 12:09 AM Changeset in webkit [55124] by
-
- 2 edits in trunk/WebCore
2010-02-23 José Millán Soto <jmillan@igalia.com>
Reviewed by Eric Seidel.
[Gtk] Webkit crashes when using orca
https://bugs.webkit.org/show_bug.cgi?id=35169
Made webkit_accessible_text_get_caret_offset check if end selection
node is null.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_caret_offset):
Feb 22, 2010:
- 11:53 PM Changeset in webkit [55123] by
-
- 7 edits in trunk/WebKitTools
2010-02-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Siedel.
Add more checking for missing binaries and packages to check_sys_deps()
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
- 11:37 PM Changeset in webkit [55122] by
-
- 3 edits in trunk/WebCore
2010-02-22 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
[Haiku] Implemented PopupMenu support.
https://bugs.webkit.org/show_bug.cgi?id=35078
Covered by existing tests.
The implementation is currently very simple: Added a PopupMenuHaiku
class that derives from a native BPopUpMenu. It attaches a BHandler
derivative to the BApplication (WebCore main thread) which receives
the item invokation and menu hidden events and informs the PopupMenuClient
accordingly.
- platform/PopupMenu.h:
Changed type of m_menu for Haiku.
- platform/haiku/PopupMenuHaiku.cpp: (WebCore::PopupMenuHandler::PopupMenuHandler): (WebCore::PopupMenuHandler::MessageReceived): (WebCore::PopupMenuHaiku::PopupMenuHaiku): (WebCore::PopupMenuHaiku::~PopupMenuHaiku): (WebCore::PopupMenuHaiku::show): (WebCore::PopupMenuHaiku::hide): (WebCore::PopupMenuHaiku::Hide): (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu):
Removed bogus code.
(WebCore::PopupMenu::show):
Implemented using new PopupMenuHaiku class.
(WebCore::PopupMenu::hide):
Implemented using new PopupMenuHaiku class.
(WebCore::PopupMenu::updateFromElement):
Implemented.
(WebCore::PopupMenu::itemWritingDirectionIsNatural):
Implemented according to Gtk port.
- 10:28 PM Changeset in webkit [55121] by
-
- 3 edits in trunk/WebKitTools
2010-02-22 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by David Levin.
[Gtk] check-webkit-style: GTK style should be allowed in WebKitTools/DumpRenderTree/gtk
https://bugs.webkit.org/show_bug.cgi?id=35229
- Scripts/webkitpy/style/checker.py:
- Scripts/webkitpy/style/checker_unittest.py:
- 9:03 PM Changeset in webkit [55120] by
-
- 8 edits in trunk/JavaScriptCore
Remove auto_ptr usage in JavaScriptCore.
https://bugs.webkit.org/show_bug.cgi?id=35221
Reviewed by Darin Adler.
- parser/Nodes.h: Removed now unneeded adopt method.
- parser/Parser.cpp: Removed <memory> include as it is not required anymore.
- wtf/OwnPtr.h: Removed the constructor from auto_ptr.
- wtf/VectorTraits.h: Removed a template specialization for auto_ptr.
- wtf/unicode/Collator.h: Made userDefault return a PassOwnPtr.
- wtf/unicode/CollatorDefault.cpp:
(WTF::Collator::userDefault): Changed the method to match the next signature.
- wtf/unicode/icu/CollatorICU.cpp:
(WTF::Collator::userDefault): Ditto.
- 8:50 PM Changeset in webkit [55119] by
-
- 2 edits in trunk/WebKitTools
2010-02-22 James Robinson <jamesr@chromium.org>
Unreviewed. Adding myself to committers list.
- Scripts/webkitpy/committers.py:
- 8:29 PM Changeset in webkit [55118] by
-
- 2 edits in trunk/WebKitTools
2010-02-22 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Remove DRT hack that turns off hardware acceleration with older QuickTimes
https://bugs.webkit.org/show_bug.cgi?id=35275
Now that WebKit does a version check to avoid a QuickTime-related
crash (r55100), DumpRenderTree does not need to.
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- 5:55 PM Changeset in webkit [55117] by
-
- 5 edits in trunk
2010-02-22 Huahui Wu <hwu@google.com>
Reviewed by Eric Seidel.
Add code that enables SquirrelFish Extreme (a.k.a JSCX, JSC JIT)
in Android. It's disabled by default, but is enabled when the
enveronment variable ENABLE_JSC_JIT is set to true.
https://bugs.webkit.org/show_bug.cgi?id=34855
- Android.mk:
2010-02-22 Huahui Wu <hwu@google.com>
Reviewed by Eric Seidel.
Add code that enables SquirrelFish Extreme (a.k.a JSCX, JSC JIT)
in Android. It's disabled by default, but is enabled when the
enveronment variable ENABLE_JSC_JIT is set to true.
https://bugs.webkit.org/show_bug.cgi?id=34855
- Android.mk:
- wtf/Platform.h:
- 5:29 PM Changeset in webkit [55116] by
-
- 2 edits in trunk/WebCore
2010-02-22 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
Fix various issues in PlatformMouseEventHaiku.
https://bugs.webkit.org/show_bug.cgi?id=34685
Covered by existing tests.
Mapping Haiku button constants (bit field) to WebCore buttons was broken.
Extracting event time was broken (supposed to be in seconds).
Wrong coordinate was being extracted, needs to be content local.
Added extracting modifier key flags.
- platform/haiku/PlatformMouseEventHaiku.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
- 5:12 PM Changeset in webkit [55115] by
-
- 3 edits in trunk/WebCore
2010-02-22 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
[Haiku] Implement creating and filling platform gradients.
https://bugs.webkit.org/show_bug.cgi?id=34683
Covered by existing tests.
- platform/graphics/Gradient.h:
Typedef PlatformGradient to BGradient
- platform/graphics/haiku/GradientHaiku.cpp: (WebCore::Gradient::platformDestroy):
Delete the cached BGradient object.
(WebCore::Gradient::platformGradient):
Create a BGradient object according to the type of Gradient.
Return the cached object.
(WebCore::Gradient::fill):
use BView API to fill with the platform gradient.
- 5:01 PM Changeset in webkit [55114] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-02-22 Chris Evans <cevans@chromium.org>
Reviewed by Darin Adler.
Add test for https://bugs.webkit.org/show_bug.cgi?id=32842
It has been fixed on trunk for a while, but we want to make sure we
do not regress.
- fast/text/find-layout-crash.html: Added.
- fast/text/find-layout-crash-expected.txt: Added.
- 4:55 PM Changeset in webkit [55113] by
-
- 2 edits in trunk/WebCore
2010-02-22 Stephan Aßmus <superstippi@gmx.de>
Reviewed by Eric Seidel.
Build fix for debug builds of GlyphPageTreeNode.cpp
https://bugs.webkit.org/show_bug.cgi?id=34528
Covered by existing tests.
- platform/graphics/GlyphPageTreeNode.cpp:
include <stdio.h> since printf() is used if NDEBUG is not defined.
- 4:45 PM Changeset in webkit [55112] by
-
- 6 edits in trunk/WebKit/win
WebKit on Windows should pick up system setting changes without requiring explicit API calls
https://bugs.webkit.org/show_bug.cgi?id=35269
Reviewed by Darin Adler.
- WebKit.vcproj/WebKit.def: Removed WebKitSystemParameterChanged.
- WebKit.vcproj/WebKit_debug.def: Removed WebKitSystemParameterChanged.
- WebKitGraphics.cpp: Removed WebKitSystemParameterChanged.
- WebKitGraphics.h: Removed WebKitSystemParameterChanged.
- WebView.cpp:
(systemParameterChanged): Call through to wkSystemFontSmoothingChanged for font changes.
(WebView::windowReceivedMessage): Pick up WM_SETTINGCHANGE from windowReceivedMessage.
- 4:12 PM Changeset in webkit [55111] by
-
- 2 edits in trunk/WebCore
2010-02-22 Nate Chapin <Nate Chapin>
Unreviewed, Chromium build fix.
Add special case in CodeGeneratorV8.pm for named getters for html plugin-related elements.
CodeGeneratorV8.pm was relying on HasOverridingNameGetter to hint
that a custom named getter was needed. That hint was removed in
http://trac.webkit.org/changeset/55104.
- bindings/scripts/CodeGeneratorV8.pm:
- 3:28 PM Changeset in webkit [55110] by
-
- 1 edit1 delete in trunk/LayoutTests
Rubber-stamped by Alexey Proskuryakov.
[Qt] fast/encoding/invalid-UTF-8-2.html fails
https://bugs.webkit.org/show_bug.cgi?id=35263
Qt Linux Release buildbot got the platform independent result for
fast/encoding/invalid-UTF-8-2.html instead of Qt specific one.
Qt specific expected file is removed to make buildbot green,
but it needs more investigation.
- platform/qt/fast/encoding/invalid-UTF-8-2-expected.txt: Removed.
- 3:27 PM Changeset in webkit [55109] by
-
- 21 edits in trunk
Rubber-stamped by Geoff Garen.
Rename RuntimeObjectImp to RuntimeObject.
- 3:23 PM Changeset in webkit [55108] by
-
- 3 edits3 adds in trunk
Avoid recursion when trying to get the size of a PNG; it's unnecessary
and in the worst case can lead to heap corruption.
https://bugs.webkit.org/show_bug.cgi?id=35167
Reviewed by Eric Seidel.
WebCore:
Test: fast/images/bad-png.html
- platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageReader::decode):
LayoutTests:
- fast/images/bad-png-expected.txt: Added.
- fast/images/bad-png.html: Added.
- fast/images/resources/bad-png.png: Added.
- 3:20 PM BuildingOnWindows edited by
- (diff)
- 3:10 PM Changeset in webkit [55107] by
-
- 8 edits in trunk
Disable WebView docking to views that are too small.
<rdar://problem/7248409> and https://bugs.webkit.org/show_bug.cgi?id=35254
Reviewed by Tim Hatcher.
WebCore:
- WebCore.base.exp:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::canAttachWindow): Provide a utility for WebKits to make a showWindow()
decision based on if attachment would be allowed or not.
(WebCore::InspectorController::attachWindow): Don't attach if the view is too small to attach to.
- inspector/InspectorController.h:
WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController showWindow:]): No matter the preference, don't open the inspector
window attached if WebCore says it shouldn't be attached.
WebKit/win:
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::showWindowWithoutNotifications): No matter the preference, don't open the inspector
window attached if WebCore says it shouldn't be attached.
- 2:32 PM Changeset in webkit [55106] by
-
- 2 edits in trunk/WebCore
Build fix.
- WebCore.base.exp: Export Instance::newRuntimeObject, it's virtual!
- 2:25 PM Changeset in webkit [55105] by
-
- 2 edits in trunk/WebCore
Undo a small part of the previous commit.
- bridge/runtime_method.cpp: (JSC::callRuntimeMethod): Let's keep the instance local variable as RefPtr for safety.
- 2:21 PM Changeset in webkit [55104] by
-
- 12 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=35260
Eliminate apple_runtime_object
No change in functionality, so no tests.
- WebCore.base.exp: Don't export Instance::newRuntimeObject, WebKit doesn't need it.
- bindings/js/JSHTMLAppletElementCustom.cpp:
- bindings/js/JSHTMLEmbedElementCustom.cpp:
- bindings/js/JSHTMLObjectElementCustom.cpp:
- html/HTMLAppletElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLObjectElement.idl: These objects no longer need overriding name getters, as they no longer intercept the apple_runtime_object property.
- bindings/js/JSPluginElementFunctions.cpp: (WebCore::pluginInstance): This is no longer static. It was used for callPlugin() in this file, and now it's also used elsewhere when calling plug-in methods. (WebCore::runtimeObjectGetter): Removed. This function was only used by the intercepting name getters.
- bindings/js/JSPluginElementFunctions.h: Export pluginInstance().
- bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
- bridge/runtime_method.cpp: (JSC::callRuntimeMethod): Take plug-in element's instance directly, without relying on fake attribute lookup. One change resulting from this is that RuntimeObjectImp may not be created in some cases - this code only needs an instance, but the old code had to pass the instance wrapped into RuntimeObjectImp.
- 2:17 PM Changeset in webkit [55103] by
-
- 5 edits3 adds in trunk/LayoutTests
2010-02-22 Robert Hogan <robert@roberthogan.net>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=32937
LayoutTests/fast/encoding/invalid-UTF-8.html fails on Qt.
The test was verifying two things: first, that U+FFFD is rendered by the browser, and second,
that ill-formed UTF-8 sequences are turned into U+FFFD. Some aspects of the latter are not
precisely defined by the Unicode specification, so different platforms may legitimately
have different results.
Split the test into two: one to test the rendering of invalid UTF-8 sequences, and the other
to protect against regressions in each platform's decoding behaviour.
- fast/encoding/invalid-UTF-8-2-expected.txt: Added.
- fast/encoding/invalid-UTF-8-2.html: Added.
- fast/encoding/invalid-UTF-8.html:
- platform/mac/fast/encoding/invalid-UTF-8-expected.checksum:
- platform/mac/fast/encoding/invalid-UTF-8-expected.png:
- platform/mac/fast/encoding/invalid-UTF-8-expected.txt:
- platform/qt/fast/encoding/invalid-UTF-8-2-expected.txt:
- 1:07 PM Changeset in webkit [55102] by
-
- 3 edits in trunk/LayoutTests
Bug 35186 - AX: AXFocused is not writable like it should be on nodes
https://bugs.webkit.org/show_bug.cgi?id=35186
Fixing layout test failure.
- 12:59 PM Changeset in webkit [55101] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=35256
HTMLSelectElement::setSelectedIndexByUser() can trigger unnecessary JS when there is no change to the selected index
Reviewed by Tim Hatcher.
No new tests because this code path is not used for JS-initiated changes.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setSelectedIndexByUser):
Bail out if the to-be-selected index matches the already-selected index.
- 12:51 PM Changeset in webkit [55100] by
-
- 2 edits in trunk/WebKit/mac
2010-02-22 Simon Fraser <Simon Fraser>
Reviewed by John Sullivan.
<rdar://problem/7285392>
On Leopard, we have to disable hardware acceleration if we detect that the
installed Core Video framework has bug <rdar://problem/7228836>.
- WebView/WebView.mm: (coreVideoHas7228836Fix): (-[WebView _preferencesChangedNotification:]):
- 12:18 PM Changeset in webkit [55099] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.22
Tagging 1.1.22.
- 12:05 PM Changeset in webkit [55098] by
-
- 3 edits2 adds in trunk
Reproducible crash in WebCore::nextLinePosition on Tweeteorites.com
<rdar://problem/7615758>
https://bugs.webkit.org/show_bug.cgi?id=35060
Reviewed by Dan Bernstein.
WebCore:
Test: editing/selection/extend-byline-withfloat.html
- editing/visible_units.cpp:
(WebCore::previousLinePosition): Skip elements with zero height.
(WebCore::nextLinePosition): Skip elements with zero height.
LayoutTests:
- editing/selection/extend-byline-withfloat-expected.txt: Added.
- editing/selection/extend-byline-withfloat.html: Added.
- 12:03 PM Changeset in webkit [55097] by
-
- 2 edits in trunk/WebCore
2010-02-22 Nate Chapin <Nate Chapin>
Unreviewed, Chromium build fix.
- bindings/scripts/CodeGeneratorV8.pm: Compile break due to bad patch merge.
- 11:53 AM Changeset in webkit [55096] by
-
- 27 edits5 deletes in trunk/WebCore
2010-02-22 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Streamline V8 event listener code. Merge all the variants of
V8DOMWrapper::getEventListner() into a single version and generate
addEventListener() and removeEventListener() bindings for all objects
except DOMWindow.
- 11:29 AM Changeset in webkit [55095] by
-
- 3 edits2 adds in trunk
AX: AXFocused is not writable like it should be on nodes
https://bugs.webkit.org/show_bug.cgi?id=35186
Reviewed by Beth Dakin.
WebCore:
Test: platform/mac/accessibility/element-focus.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):
LayoutTests:
- platform/mac/accessibility/element-focus-expected.txt: Added.
- platform/mac/accessibility/element-focus.html: Added.
- 11:24 AM Changeset in webkit [55094] by
-
- 2 edits in trunk/WebKit/qt
2010-02-22 Laszlo Gombos <Laszlo Gombos>
Unreviewed Symbian build fix.
[Qt] Updated the def file with new exports to enable
building DumpRenderTree.
- symbian/eabi/QtWebKitu.def:
- 11:12 AM Changeset in webkit [55093] by
-
- 5 edits in trunk/JavaScriptCore
JSStringBuilder should not CRASH if allocation fails, it should throw a JSException.
Reviewed by Oliver Hunt.
- runtime/JSGlobalObjectFunctions.cpp:
- runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::JSStringBuilder):
(JSC::JSStringBuilder::append):
(JSC::JSStringBuilder::build):
- runtime/StringBuilder.h:
(JSC::StringBuilder::build):
- wtf/Vector.h:
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::):
(WTF::VectorBuffer::tryAllocateBuffer):
(WTF::::tryExpandCapacity):
(WTF::::tryReserveCapacity):
(WTF::::tryAppend):
- 11:07 AM Changeset in webkit [55092] by
-
- 4 edits in trunk
2010-02-22 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Bump library versioning for 1.1.22 release.
- configure.ac:
WebKit/gtk:
2010-02-22 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Update for release.
- NEWS:
- 11:02 AM Changeset in webkit [55091] by
-
- 2 edits1 add in trunk/JavaScriptCore
2010-02-22 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Map FastMalloc to BREW memory allocator
https://bugs.webkit.org/show_bug.cgi?id=33570
Use MALLOC macro instead of the standard malloc function.
Although RVCT provides malloc, we can't use it in BREW
because the loader does not initialize the base address properly.
- wtf/FastMalloc.cpp:
- wtf/brew/SystemMallocBrew.h: Added. (mallocBrew): (callocBrew): (freeBrew): (reallocBrew):
- 10:48 AM Changeset in webkit [55090] by
-
- 11 edits in trunk/WebCore
2010-02-22 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein, Darin Adler.
Remove addScrolledContentOffset/subtractScrolledContentOffset
https://bugs.webkit.org/show_bug.cgi?id=35225
Remove RenderLayer's addScrolledContentOffset() and subtractScrolledContentOffset()
methods, and instead use the existing scrolledContentOffset(), and use
IntSize and IntPoint instead of lots of x, y variables.
Added new IntPoint toPoint(const IntSize&) method as a convenience to convert a size to a point,
which is needed in a few places.
- page/EventHandler.cpp: (WebCore::EventHandler::handleDrag): Use the new toPoint() convenience.
- platform/graphics/IntPoint.h: (WebCore::toPoint): New convenience method to convert an IntSize to an IntPoint.
- rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::selectionGapRectsForRepaint): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::offsetForContents):
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderInline.cpp: (WebCore::RenderInline::clippedOverflowRectForRepaint):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition):
- rendering/RenderLayer.h: (WebCore::RenderLayer::size):
- rendering/RenderObject.cpp: (WebCore::RenderObject::computeRectForRepaint):
- rendering/TextControlInnerElements.cpp: (WebCore::RenderTextControlInnerBlock::positionForPoint):
- 10:36 AM Changeset in webkit [55089] by
-
- 12 edits3 copies in trunk
2009-02-22 Adam Langley <agl@google.com>
Reviewed by Darin Fisher.
fontconfig on Linux can change the render preferences on a per strike
basis (a strike a combination of face and size). Because of this, we
need to query fontconfig each time a new FontPlatformData is created
for a new size.
This patch adds support for querying this via ChromiumBridge.
- platform/chromium/ChromiumBridge.h: add getRenderStyleForStrike
- platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::createFontPlatformData):
- platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::setupPaint): (WebCore::FontPlatformData::queryStyle): add code to query fontconfig via ChromiumBridge
- platform/graphics/chromium/FontPlatformDataLinux.h:
- 10:11 AM Changeset in webkit [55088] by
-
- 4 edits in trunk
Build fix for make distcheck.
- 9:25 AM Changeset in webkit [55087] by
-
- 2 edits in trunk/WebCore
2010-02-22 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
Fix compiler warning "suggest parentheses around"
https://bugs.webkit.org/show_bug.cgi?id=35197
No new tests as there is no new functionality.
- wml/WMLVariables.cpp: (WebCore::substituteVariableReferences):
- 9:01 AM Changeset in webkit [55086] by
-
- 8 edits in trunk
WebCore
2010-02-22 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[Soup] loses information related to message flags when converting from/to Resource{Request,Response}
https://bugs.webkit.org/show_bug.cgi?id=35093
Store message flags in WebCore objects, and set them on the
SoupMessage, when creating one from them.
No behaviour change.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
- platform/network/soup/ResourceRequest.h: (WebCore::ResourceRequest::soupMessageFlags): (WebCore::ResourceRequest::setSoupMessageFlags):
- platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):
- platform/network/soup/ResourceResponse.h: (WebCore::ResourceResponse::soupMessageFlags): (WebCore::ResourceResponse::setSoupMessageFlags):
- platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::toSoupMessage): (WebCore::ResourceResponse::updateFromSoupMessage):
WebKit/gtk
2010-02-22 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[Soup] loses information related to message flags when converting from/to Resource{Request,Response}
https://bugs.webkit.org/show_bug.cgi?id=35093
Update the flags that are stored in the request, when the response
is received.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
- 8:40 AM Changeset in webkit [55085] by
-
- 2 edits in trunk/WebKitTools
[Qt] Build the DRT in debug on Mac OS X
Reviewed by Kenneth Rohde Christiansen.
- DumpRenderTree/qt/DumpRenderTree.pro:
- 8:17 AM Changeset in webkit [55084] by
-
- 2 edits in trunk/WebCore
2010-02-22 Steve Block <steveblock@google.com>
Reviewed by Nate Chapin.
Shared worker types used in globalObjectPrototypeIsDOMWindow are not properly guarded
https://bugs.webkit.org/show_bug.cgi?id=35238
No new tests, build fix only.
- bindings/v8/V8DOMWrapper.cpp: (WebCore::globalObjectPrototypeIsDOMWindow):
- 7:16 AM Changeset in webkit [55083] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-22 Laszlo Gombos <Laszlo Gombos>
Unreviewed build fix.
[Qt] Build fix for RVCT.
Fix after r55024. The "-i" option is for perl not for the
script.
- DerivedSources.pro:
- 7:12 AM Changeset in webkit [55082] by
-
- 6 edits in trunk
2010-02-22 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add support for layout tests on Symbian
https://bugs.webkit.org/show_bug.cgi?id=31589
- WebKit.pro:
2010-02-22 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add support for layout tests on Symbian
https://bugs.webkit.org/show_bug.cgi?id=31589
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
- DumpRenderTree/qt/main.cpp: (main):
- 6:26 AM Changeset in webkit [55081] by
-
- 2 edits in trunk/WebCore
2010-02-22 Steve Block <steveblock@google.com>
Reviewed by Simon Fraser.
Simplifies calculation of the transform in RenderLayer::paintLayer
https://bugs.webkit.org/show_bug.cgi?id=35101
No new tests, optimization only.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
- 6:21 AM Changeset in webkit [55080] by
-
- 2 edits in trunk/BugsSite
2010-02-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Maciej Stachowiak.
Don't reset the assignee back to default on component change
There's a risk of reseting a valid assignee for example when
triaging a bug. All components in WebKit have the default
assignee set to webkit-unassigned@webkit.org so this should
not cause problems for people relying on this functionality.
- template/en/custom/bug/edit.html.tmpl:
- 5:42 AM Changeset in webkit [55079] by
-
- 6 edits2 adds in trunk/WebCore
[Qt] Switching from Phonon to QtMultimedia Backend for Qt 4.7
Patch by Nicholas Young <nicholas.young@nokia.com> on 2010-02-22
Reviewed by Tor Arne Vestbø.
https://bugs.webkit.org/show_bug.cgi?id=34631
No new tests. This patch only affects multimedia backend.
- WebCore.pro: Build depends on Qt version.
- css/mediaControlsQt.css: Updated media controls.
- platform/graphics/MediaPlayer.cpp: Different backend included depending on Qt version.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp: Added new QtMultimedia Backend.
(WebCore::MediaPlayerPrivate::create):
(WebCore::MediaPlayerPrivate::registerMediaEngine):
(WebCore::MediaPlayerPrivate::getSupportedTypes):
(WebCore::MediaPlayerPrivate::supportsType):
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::hasVideo):
(WebCore::MediaPlayerPrivate::hasAudio):
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::cancelLoad):
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::pause):
(WebCore::MediaPlayerPrivate::paused):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::seeking):
(WebCore::MediaPlayerPrivate::duration):
(WebCore::MediaPlayerPrivate::currentTime):
(WebCore::MediaPlayerPrivate::buffered):
(WebCore::MediaPlayerPrivate::maxTimeSeekable):
(WebCore::MediaPlayerPrivate::bytesLoaded):
(WebCore::MediaPlayerPrivate::totalBytes):
(WebCore::MediaPlayerPrivate::setRate):
(WebCore::MediaPlayerPrivate::setVolume):
(WebCore::MediaPlayerPrivate::supportsMuting):
(WebCore::MediaPlayerPrivate::setMuted):
(WebCore::MediaPlayerPrivate::networkState):
(WebCore::MediaPlayerPrivate::readyState):
(WebCore::MediaPlayerPrivate::setVisible):
(WebCore::MediaPlayerPrivate::mediaStatusChanged):
(WebCore::MediaPlayerPrivate::handleError):
(WebCore::MediaPlayerPrivate::stateChanged):
(WebCore::MediaPlayerPrivate::nativeSizeChanged):
(WebCore::MediaPlayerPrivate::queuedSeekTimeout):
(WebCore::MediaPlayerPrivate::seekTimeout):
(WebCore::MediaPlayerPrivate::positionChanged):
(WebCore::MediaPlayerPrivate::durationChanged):
(WebCore::MediaPlayerPrivate::volumeChanged):
(WebCore::MediaPlayerPrivate::mutedChanged):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::setSize):
(WebCore::MediaPlayerPrivate::naturalSize):
(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::repaint):
- platform/graphics/qt/MediaPlayerPrivateQt.h: Added new QtMultimedia Backend.
(WebCore::MediaPlayerPrivate::isAvailable):
(WebCore::MediaPlayerPrivate::supportsFullscreen):
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::mediaControlsBaselineOpacity): New method.
(WebCore::RenderThemeQt::paintMediaBackground): Background depends on baseline opacity.
(WebCore::RenderThemeQt::paintMediaMuteButton): Changed styling.
(WebCore::RenderThemeQt::paintMediaCurrentTime): Added current time display.
(WebCore::RenderThemeQt::formatMediaControlsCurrentTime): Added time formatting.
(WebCore::RenderThemeQt::formatMediaControlsRemainingTime): Added time formatting.
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack): Volume slider added.
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb): Volume slider added.
(WebCore::RenderThemeQt::paintMediaSliderTrack): Updated for QtMultimedia.
(WebCore::RenderThemeQt::paintMediaSliderThumb): Dropped an unnecessary check.
(WebCore::RenderThemeQt::adjustSliderThumbSize): Handle a missing case.
- platform/qt/RenderThemeQt.h: Reimplemented a few more methods.
- 5:02 AM Changeset in webkit [55078] by
-
- 2 edits in trunk/WebCore
2010-02-22 Alexander Pavlov <apavlov@chromium.org>
Not reviewed: mac build fix
- bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer):
- 4:14 AM Changeset in webkit [55077] by
-
- 15 edits2 adds in trunk
2010-02-22 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: there should be a way to "deactivate" or "skip" all breakpoints while debugging.
https://bugs.webkit.org/show_bug.cgi?id=33217
WebCore:
- English.lproj/localizedStrings.js:
- bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::hasBreakpoint): (WebCore::ScriptDebugServer::setBreakpointsActivated):
- bindings/js/ScriptDebugServer.h:
- bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::setBreakpointsActivated):
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::activateBreakpoints): (WebCore::InspectorBackend::deactivateBreakpoints):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/front-end/Images/deactivateBreakpointsButtonGlyph.png: Added.
- inspector/front-end/Images/deactivateBreakpointsDisabledButtonGlyph.png: Added.
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.activateBreakpoints): (.WebInspector.InspectorBackendStub.prototype.deactivateBreakpoints):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get breakpointsActivated): (WebInspector.ScriptsPanel.prototype.addBreakpoint): (WebInspector.ScriptsPanel.prototype._stepOutClicked): (WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
- inspector/front-end/inspector.css:
- inspector/front-end/textViewer.css:
WebKit/chromium:
- src/js/DebuggerAgent.js: (devtools.DebuggerAgent): (devtools.DebuggerAgent.prototype.setBreakpointsActivated): (devtools.DebuggerAgent.prototype.handleBreakEvent_): (devtools.DebuggerAgent.prototype.handleExceptionEvent_):
- src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl.prototype.activateBreakpoints): (devtools.InspectorBackendImpl.prototype.deactivateBreakpoints):
- 3:18 AM Changeset in webkit [55076] by
-
- 2 edits in trunk/WebCore
REGRESSION (r55039): Animation starts from near end when loaded over slow network
<http://webkit.org/b/35222> / <rdar://problem/7673523>
Rubber-stamped by Sam Weinig and Maciej Stachowiak.
Roll out r55039 (related to <http://webkit.org/b/35115>) as it causes animated GIFs
to skip intermediate frames when loading over a slower network.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::startAnimation):
- 2:31 AM Changeset in webkit [55075] by
-
- 12 edits1 delete in trunk/WebCore
Not reviewed, build fix.
Revert the previous change.
- 1:28 AM Changeset in webkit [55074] by
-
- 12 edits1 add in trunk/WebCore
2010-02-21 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
Cache JavaScript wrappers inline in DOM nodes
https://bugs.webkit.org/show_bug.cgi?id=35226
<rdar://problem/7664202>
8.8% speedup on Dromaeo DOM Core tests.
3.3% speedup on Hixie DOM Core tests.
- bindings/js/JSDOMBinding.cpp: (WebCore::forgetDOMNode): Clear wrapper pointer. (WebCore::cacheDOMNodeWrapper): Cache inline too if caching for normal world.
- bindings/js/JSDOMBinding.h: (WebCore::DOMObjectWrapperMapFor):
- bindings/js/JSDocumentCustom.cpp: (WebCore::toJS): Remove unneeded argument from getCachedDOMNodeWrapper.
- bindings/js/JSNodeCustom.cpp: (WebCore::createWrapperInline): Renamed version of original createWrapper. (WebCore::createWrapper): Call createWrapperInline. Out-of-line version. (WebCore::toJSNewlyCreated): Call createWrapperInline instead of createWrapper.
- bindings/js/JSNodeCustom.h: Added. (WebCore::getCachedDOMNodeWrapper): Moved here so it can be inlined. (WebCore::toJS): Moved here so it can be inlined.
- bindings/js/ScriptWrappable.h: (WebCore::ScriptWrappable::ScriptWrappable): Implement this in the obvious way for JavaScriptCore. (WebCore::ScriptWrappable::wrapper): (WebCore::ScriptWrappable::setWrapper): (WebCore::ScriptWrappable::clearWrapper):
- bindings/scripts/CodeGeneratorJS.pm: Include CustomHeader heaaders in the header, not just the impl file, so they can add inlining.
- dom/Node.idl: Add CustomHeader directive.
Add new files to build.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- 1:13 AM Changeset in webkit [55073] by
-
- 9 edits1 add in trunk/WebCore
2010-02-22 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: windows build fix.
- 12:08 AM Changeset in webkit [55072] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
Part 2 of Windows build fix.
Feb 21, 2010:
- 11:59 PM Changeset in webkit [55071] by
-
- 34 edits1 move2 deletes in trunk
2010-02-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: stop on inline breakpoints on reload.
- ScriptBreakpoint struct has been introduced and reused in InspectorController and debug server.
- JavaScriptDebugServer was moved to bindings/js and renamed to ScriptDebugServer
There were no changes to semantics, only some mechanical changes:
- addBreakpoint and updateBreakpoint were merged into setBreakpoint
- ScriptDebugServer now operates ScriptBreakpoint instances instead of BreakpointInfo.
- It no longer allocates maps and breakpoint info in heap - all done on stack.
- JavaScriptDebugListener is now ScriptDebugServer::Listener
- Listener methods no longer have ExecState (was unused).
- addListener/removeListener pair wuth no page argument removed (was unused).
- InspectorController now binds sourceID to url and maintains a map of 'sticky'
breakpoints. Whenever script is loaded and there is a sticky breakpoint url matching,
breakpoint is being 'restored' synchronously in debug server and pushed to frontend.
Front-end no longer stores map of sticky breakpoints.
- setBreakpoint/removeBreakpoint/didParseSource trio handle this logic.
- A bunch of if(USE_JSC/V8/other) forks removed.
- InspectorFrontend now operates primitive types only, got rid of USE_JSC as well.
- GNUmakefile.am:
- WebCore.base.exp:
- WebCore.gypi:
- WebCore.order:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::currentCallFrame): (WebCore::JSInjectedScriptHost::isActivation):
- bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::shared): (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::~ScriptDebugServer): (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::removeListener): (WebCore::ScriptDebugServer::pageCreated): (WebCore::ScriptDebugServer::hasListenersInterestedInPage): (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint): (WebCore::ScriptDebugServer::hasBreakpoint): (WebCore::ScriptDebugServer::clearBreakpoints): (WebCore::ScriptDebugServer::setPauseOnExceptionsState): (WebCore::ScriptDebugServer::pauseProgram): (WebCore::ScriptDebugServer::continueProgram): (WebCore::ScriptDebugServer::stepIntoStatement): (WebCore::ScriptDebugServer::stepOverStatement): (WebCore::ScriptDebugServer::stepOutOfFunction): (WebCore::ScriptDebugServer::currentCallFrame): (WebCore::ScriptDebugServer::currentCallFrameState): (WebCore::ScriptDebugServer::dispatchDidParseSource): (WebCore::ScriptDebugServer::dispatchFailedToParseSource): (WebCore::toPage): (WebCore::ScriptDebugServer::detach): (WebCore::ScriptDebugServer::sourceParsed): (WebCore::ScriptDebugServer::dispatchFunctionToListeners): (WebCore::ScriptDebugServer::setJavaScriptPaused): (WebCore::ScriptDebugServer::pauseIfNeeded): (WebCore::ScriptDebugServer::callEvent): (WebCore::ScriptDebugServer::atStatement): (WebCore::ScriptDebugServer::returnEvent): (WebCore::ScriptDebugServer::exception): (WebCore::ScriptDebugServer::willExecuteProgram): (WebCore::ScriptDebugServer::didExecuteProgram): (WebCore::ScriptDebugServer::didReachBreakpoint): (WebCore::ScriptDebugServer::recompileAllJSFunctionsSoon): (WebCore::ScriptDebugServer::recompileAllJSFunctions): (WebCore::ScriptDebugServer::didAddListener): (WebCore::ScriptDebugServer::didRemoveListener): (WebCore::ScriptDebugServer::didRemoveLastListener):
- bindings/js/ScriptDebugServer.h: (WebCore::ScriptDebugServer::Listener::~Listener): (WebCore::ScriptDebugServer::): (WebCore::ScriptDebugServer::pauseOnExceptionsState): (WebCore::ScriptDebugServer::hasListeners): (WebCore::ScriptDebugServer::hasGlobalListeners):
- bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::shared):
- bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::Listener::~Listener): (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::removeListener): (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint): (WebCore::ScriptDebugServer::clearBreakpoints): (WebCore::ScriptDebugServer::): (WebCore::ScriptDebugServer::pauseOnExceptionsState): (WebCore::ScriptDebugServer::setPauseOnExceptionsState): (WebCore::ScriptDebugServer::pauseProgram): (WebCore::ScriptDebugServer::continueProgram): (WebCore::ScriptDebugServer::stepIntoStatement): (WebCore::ScriptDebugServer::stepOverStatement): (WebCore::ScriptDebugServer::stepOutOfFunction): (WebCore::ScriptDebugServer::recompileAllJSFunctionsSoon): (WebCore::ScriptDebugServer::recompileAllJSFunctions): (WebCore::ScriptDebugServer::currentCallFrameState): (WebCore::ScriptDebugServer::pageCreated): (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::~ScriptDebugServer):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::currentCallFrameCallback): (WebCore::V8InjectedScriptHost::isActivationCallback):
- inspector/InjectedScriptHost.cpp:
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptHost.idl:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::setBreakpoint): (WebCore::InspectorBackend::removeBreakpoint): (WebCore::InspectorBackend::pauseInDebugger): (WebCore::InspectorBackend::stepOverStatementInDebugger): (WebCore::InspectorBackend::stepIntoStatementInDebugger): (WebCore::InspectorBackend::stepOutOfFunctionInDebugger): (WebCore::InspectorBackend::pauseOnExceptionsState): (WebCore::InspectorBackend::setPauseOnExceptionsState):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/ScriptBreakpoint.h: Added. (WebCore::InspectorBreakpoint::InspectorBreakpoint):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::close): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::addProfile): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::resumeDebugger): (WebCore::InspectorController::setBreakpoint): (WebCore::InspectorController::removeBreakpoint): (WebCore::InspectorController::didParseSource): (WebCore::InspectorController::failedToParseSource): (WebCore::InspectorController::didPause):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::parsedScriptSource): (WebCore::InspectorFrontend::restoredBreakpoint): (WebCore::InspectorFrontend::failedToParseScriptSource): (WebCore::InspectorFrontend::resumedScript):
- inspector/InspectorFrontend.h:
- inspector/JavaScriptDebugListener.h: Removed.
- inspector/JavaScriptDebugServer.cpp: Removed.
- inspector/JavaScriptDebugServer.h: Removed.
- inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint.prototype.set condition):
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
- inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.addBreakpoint):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.sourceFrameForResource):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.addScript): (WebInspector.ScriptsPanel.prototype.addBreakpoint): (WebInspector.ScriptsPanel.prototype.removeBreakpoint): (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
- inspector/front-end/inspector.js: (WebInspector.restoredBreakpoint):
- page/Page.cpp: (WebCore::Page::Page):
- platform/android/TemporaryLinkStubs.cpp:
- 11:56 PM Changeset in webkit [55070] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
Part 1 of Windows build fix.
- 10:50 PM Changeset in webkit [55069] by
-
- 7 edits in trunk
JavaScriptCore: Make UString::m_data be const, and make the UChar owned/ref-counted by CrossThreadRefCounted be const too.
Reviewed by Oliver Hunt.
- runtime/UStringImpl.cpp:
(JSC::UStringImpl::baseSharedBuffer):
(JSC::UStringImpl::~UStringImpl):
- runtime/UStringImpl.h:
(JSC::UStringImpl::create):
(JSC::UStringImpl::data):
(JSC::UStringImpl::UStringImpl):
- wtf/OwnFastMallocPtr.h:
(WTF::OwnFastMallocPtr::~OwnFastMallocPtr):
WebCore: Make the UChar owned/ref-counted by StringImpl::CrossThreadRefCounted be const.
Reviewed by Oliver Hunt.
- platform/text/StringImpl.cpp:
(WebCore::StringImpl::sharedBuffer):
- platform/text/StringImpl.h:
- 10:12 PM Changeset in webkit [55068] by
-
- 2 edits in trunk/JavaScriptCore
2010-02-21 Yuta Kitamura <yutak@chromium.org>
Reviewed by Darin Adler.
HashMapTranslatorAdapter::translate() needs to set the mapped value.
HTTPHeaderMap::add(const char*, const String&) does not work
https://bugs.webkit.org/show_bug.cgi?id=35227
- wtf/HashMap.h: (WTF::HashMapTranslatorAdapter::translate):
- 8:12 PM Changeset in webkit [55067] by
-
- 4 edits3 adds in trunk
2010-02-07 Yuzo Fujishima <yuzo@google.com>
Reviewed by Eric Seidel.
When page-break-{after,before} is set to always, force page breaks even for overflow-specified elements.
RenderBlock::inRootBlockContext() was introduced by Changeset 5611. Although it is a reasonable criteria for choosing an optional page break location, it is not for a mandatory page break as specified by http://dev.w3.org/csswg/css3-page/#forced-pg-brk. The method is removed because it is not used anywhere else.
Note: this patch makes page break work for overflow-specified elements. For tables and floated elements, more work is needed.
https://bugs.webkit.org/show_bug.cgi?id=9526
- printing/page-break-always-for-overflow-expected.txt: Added.
- printing/page-break-always-for-overflow.html: Added.
- printing/script-tests/page-break-always-for-overflow.js: Added.
2010-02-07 Yuzo Fujishima <yuzo@google.com>
Reviewed by Eric Seidel.
When page-break-{after,before} is set to always, force page breaks even for overflow-specified elements.
RenderBlock::inRootBlockContext() was introduced by Changeset 5611. Although it is a reasonable criteria for choosing an optional page break location, it is not for a mandatory page break as specified by http://dev.w3.org/csswg/css3-page/#forced-pg-brk. The method is removed because it is not used anywhere else.
Note: this patch makes page break work for overflow-specified elements. For tables and floated elements, more work is needed.
https://bugs.webkit.org/show_bug.cgi?id=9526
Test: printing/page-break-always-for-overflow.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren):
- rendering/RenderBlock.h:
- 3:40 PM Changeset in webkit [55066] by
-
- 19 edits in trunk/WebCore
Remove auto_ptr usage in WebCore.
https://bugs.webkit.org/show_bug.cgi?id=35157
Reviewed by Eric Seidel.
The changes consists of:
- Changing auto_ptr arguments or return types to PassOwnPtr.
- Replacing local auto_ptr by OwnPtr.
- Removing now unneeded <memory> inclusion.
- css/CSSParser.cpp:
(WebCore::CSSParser::addProperty):
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
(WebCore::workerContextDidReceiveResponse):
(WebCore::workerContextDidReceiveData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
(WebCore::workerContextDidReceiveAuthenticationCancellation):
- loader/WorkerThreadableLoader.h:
- loader/icon/IconLoader.cpp:
(WebCore::IconLoader::create):
- loader/icon/IconLoader.h:
- platform/ContextMenu.cpp:
(WebCore::separatorItem):
- platform/CrossThreadCopier.h:
(WebCore::):
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::copyData):
(WebCore::HTTPHeaderMap::adopt):
- platform/network/HTTPHeaderMap.h:
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::adopt):
(WebCore::ResourceRequestBase::copyData):
- platform/network/ResourceRequestBase.h:
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::copyData):
- platform/network/ResourceResponseBase.h:
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::removePendingResource):
- svg/SVGDocumentExtensions.h:
- svg/SVGElement.cpp:
(WebCore::SVGElement::insertedIntoDocument):
- workers/GenericWorkerTask.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::create):
- 1:47 PM Changeset in webkit [55065] by
-
- 4 edits in trunk/WebCore
2010-02-21 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=22215
Avoid calling absoluteClippedOverflowRect() so many times
RenderLayer::updateLayerPositions() computes the clipped overflow rect
and the outline bounds for repaint, and then calls repaintAfterLayoutIfNeeded()
which can compute the same rects all over again. Avoid this by passing
these two rects into repaintAfterLayoutIfNeeded() if known. This measurably
reduces the time spent in updateLayerPositions() for some content.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):
- rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
- rendering/RenderObject.h:
- 1:19 PM Changeset in webkit [55064] by
-
- 2 edits in trunk/WebKit/mac
False warnings about needing layout in
-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]
https://bugs.webkit.org/show_bug.cgi?id=35218
Reviewed by Darin Adler.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
Suppress the warning and the forced layout if the view is not being drawn
in this display operation.
- 12:20 PM Changeset in webkit [55063] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=35215
<rdar://problem/7673157>
The plugInViewWithArguments: API passes a dictionary of plugin arguments. One of the parameters
is WebPlugInBaseURLKey, which is a key that represents the base URL of the document containing
the plug-in's view. Instead of sending the base URL, code in WebFrameLoaderClient::createPlugin
would incorrectly pass the source URL of the plug-in resource.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): When building the plug-in arguments dictionary, pass the real base URL for the WebPlugInBaseURLKey key.
- 3:32 AM Changeset in webkit [55062] by
-
- 3 edits17 adds in trunk
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Rubber stamped by Adam Barth.
Add sunspider-0.9.1 to the site in preparation for announcing it.
https://bugs.webkit.org/show_bug.cgi?id=35206
- perf/sunspider-0.9.1: Added.
- perf/sunspider-0.9.1/json2.js: Added.
- perf/sunspider-0.9.1/sunspider-0.9: Added.
- perf/sunspider-0.9.1/sunspider-0.9.1: Added.
- perf/sunspider-0.9.1/sunspider-0.9.1/driver.html: Added.
- perf/sunspider-0.9.1/sunspider-0.9.1/results.html: Added.
- perf/sunspider-0.9.1/sunspider-0.9.1/sunspider-test-contents.js: Added.
- perf/sunspider-0.9.1/sunspider-0.9.1/sunspider-test-prefix.js: Added.
- perf/sunspider-0.9.1/sunspider-0.9/driver.html: Added.
- perf/sunspider-0.9.1/sunspider-0.9/results.html: Added.
- perf/sunspider-0.9.1/sunspider-0.9/sunspider-test-contents.js: Added.
- perf/sunspider-0.9.1/sunspider-0.9/sunspider-test-prefix.js: Added.
- perf/sunspider-0.9.1/sunspider-analyze-results.js: Added.
- perf/sunspider-0.9.1/sunspider-compare-results.js: Added.
- perf/sunspider-0.9.1/sunspider.css: Added.
- perf/sunspider-0.9.1/sunspider.html: Added.
- perf/sunspider-0.9.1/versions.html: Added.
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Add sunspider-0.9.1 to the site in preparation for announcing it.
https://bugs.webkit.org/show_bug.cgi?id=35206
- hosted/sunspider.css: Remove tabs, which I noticed where present while copying to the WebKitSite directory.
Feb 20, 2010:
- 10:44 PM Changeset in webkit [55061] by
-
- 13 edits in branches/safari-532-branch
<rdar://problem/7540432> Disable sandboxed iframes for branch
Reviewed by Dan Bernstein.
- Configurations/FeatureDefines.xcconfig:
WebCore:
- Configurations/FeatureDefines.xcconfig:
- WebCore.pri:
WebKit/chromium:
- features.gypi:
WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
WebKitTools:
- Scripts/build-webkit:
- 10:20 PM Changeset in webkit [55060] by
-
- 17 edits in branches/safari-532-branch
.: Merged from trunk:
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- configure.ac:
JavaScriptCore: Merged from trunk:
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- Configurations/FeatureDefines.xcconfig:
WebCore: Merged from trunk:
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
I made ENABLE(SANDBOX) only control the sandbox attribute itself;
I did not ifdef the infrastructure to make sandboxing
switchable. This is because the likely concerns about sandboxing
are not stability of the infrastructure code, but rather the fact
that the security model exposed to authors is still evolving.
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- WebCore.pri:
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseMappedAttribute):
WebKit/chromium: Merged from trunk:
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- features.gypi:
WebKit/mac: Merged from trunk:
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- Configurations/FeatureDefines.xcconfig:
WebKitLibraries: Merged from trunk:
2010-02-20 Maciej Stachowiak <mjs@apple.
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- win/tools/vsprops/FeatureDefines.vsprops:
WebKitTools: Merged from trunk:
2010-02-20 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- Scripts/build-webkit: Handle new flag.
- 10:01 PM Changeset in webkit [55059] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=35202
<rdar://problem/4856597> Calling Java method which accepts Object always passes a null argument
- bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue): Add cases for other JS types.
- 9:22 PM Changeset in webkit [55058] by
-
- 3 edits in trunk/WebCore
2010-02-20 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
Fix compiler warning "suggest parentheses around"
https://bugs.webkit.org/show_bug.cgi?id=35197
No new tests as there is no new functionality.
- html/DateComponents.cpp: (WebCore::beforeGregorianStartDate):
- plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::findPlugin):
- 12:44 PM Changeset in webkit [55057] by
-
- 2 edits1 move in trunk/WebKitTools
Moved simplejson into webkitpy/thirdparty directory.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=35196
- Scripts/run-chromium-webkit-tests:
- Added webkitpy/thirdparty to the script's search path.
- Scripts/webkitpy/thirdparty/simplejson: Copied from WebKitTools/simplejson.
- Copied simplejson directory.
- simplejson: Removed.
- simplejson/LICENSE.txt: Removed.
- simplejson/README.txt: Removed.
- simplejson/init.py: Removed.
- simplejson/_speedups.c: Removed.
- simplejson/decoder.py: Removed.
- simplejson/encoder.py: Removed.
- simplejson/jsonfilter.py: Removed.
- simplejson/scanner.py: Removed.
- 12:24 PM Changeset in webkit [55056] by
-
- 4 edits in trunk
2010-02-20 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] ENABLE_3D_RENDERING should be optional
https://bugs.webkit.org/show_bug.cgi?id=35100
- WebKit.pri: ENABLE_3D_RENDERING moved to a proper feature test
2010-02-20 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] ENABLE_3D_RENDERING should be optional
https://bugs.webkit.org/show_bug.cgi?id=35100
No new tests: this is a build fix.
- WebCore.pri: ENABLE_3D_RENDERING is now a proper feature test
- 11:36 AM Changeset in webkit [55055] by
-
- 6 edits1 move in trunk/WebKitTools
2010-02-20 Chris Jerdonek <Chris Jerdonek>
Reviewed by Adam Barth.
Moved BeautifulSoup to webkitpy/thirdparty directory.
- Scripts/webkitpy/BeautifulSoup.py: Removed.
- Moved to webkitpy/thirdparty.
- Scripts/webkitpy/bugzilla.py:
- Updated import statement.
- Scripts/webkitpy/bugzilla_unittest.py:
- Updated import statement.
- Scripts/webkitpy/buildbot.py:
- Updated import statement.
- Scripts/webkitpy/buildbot_unittest.py:
- Updated import statement.
- Scripts/webkitpy/statusserver.py:
- Updated import statement.
- Scripts/webkitpy/thirdparty/BeautifulSoup.py: Copied from WebKitTools/Scripts/webkitpy/BeautifulSoup.py.
- 10:22 AM Changeset in webkit [55054] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=23742
Applet methods can not return arrays to JS
- bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaArray::JavaArray): Don't accidentally zero out m_rootObject (that's how PassRefPtr works). Without m_rootObject, we crash quickly.
- bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): Do handle returned arrays. Also, added an ifdef around code that's only needed on Tiger, and removed a comment saying it can be removed when "new" plugin ships. I doubt that anyone can remember what "new" could refer to back then.
- 9:42 AM Changeset in webkit [55053] by
-
- 2 edits1 move2 adds in trunk/WebKitTools
2010-02-20 Chris Jerdonek <Chris Jerdonek>
Reviewed by Adam Barth.
Created a directory for third-party Python code, and moved
autoinstall.py into it.
- Scripts/webkitpy/init.py:
- Updated "import autoinstall" statement.
- Scripts/webkitpy/autoinstall.py: Removed.
- Moved to thirdparty/autoinstall.py.
- Scripts/webkitpy/thirdparty: Added.
- Scripts/webkitpy/thirdparty/init.py: Added.
- Scripts/webkitpy/thirdparty/autoinstall.py: Copied from WebKitTools/Scripts/webkitpy/autoinstall.py.
- 7:40 AM Changeset in webkit [55052] by
-
- 3 edits in trunk/WebCore
2010-02-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: re-creating view in ResourcesPanel confuses ScriptsPanel's visibleView logic.
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype.viewRecreated):
- 7:23 AM Changeset in webkit [55051] by
-
- 3 edits in trunk/WebCore
2010-02-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: need to highlight the evaluated expression used for popovers.
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._mouseMove): (WebInspector.SourceFrame.prototype._hidePopup): (WebInspector.SourceFrame.prototype._mouseHover): (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup): (WebInspector.SourceFrame.prototype._showPopup):
- inspector/front-end/inspector.css:
- 6:29 AM Changeset in webkit [55050] by
-
- 8 edits in trunk
Roll out 55047, since it causes regressions in layout and API tests.
- 6:29 AM Changeset in webkit [55049] by
-
- 2 edits in trunk/WebKitTools
Unreviewed, obvious fix for the python failure in our new buildbot step:
http://build.webkit.org/builders/GTK Linux 32-bit Release/builds/9075/steps/API tests/logs/err.text
- 6:13 AM Changeset in webkit [55048] by
-
- 2 edits in trunk/WebKit/gtk
2010-02-20 Gustavo Noronha Silva <Gustavo Noronha Silva>
Unreviewed. Trivial fix - unnecessary variable got added by
mistake.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
- 4:35 AM Changeset in webkit [55047] by
-
- 8 edits in trunk
WebCore
2010-02-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[Soup] loses information related to message flags when converting from/to Resource{Request,Response}
https://bugs.webkit.org/show_bug.cgi?id=35093
Store message flags in WebCore objects, and set them on the
SoupMessage, when creating one from them.
No behaviour change.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
- platform/network/soup/ResourceRequest.h: (WebCore::ResourceRequest::soupMessageFlags): (WebCore::ResourceRequest::setSoupMessageFlags):
- platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):
- platform/network/soup/ResourceResponse.h: (WebCore::ResourceResponse::soupMessageFlags): (WebCore::ResourceResponse::setSoupMessageFlags):
- platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::toSoupMessage): (WebCore::ResourceResponse::updateFromSoupMessage):
WebKit/gtk
2010-02-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[Soup] loses information related to message flags when converting from/to Resource{Request,Response}
https://bugs.webkit.org/show_bug.cgi?id=35093
Update the flags that are stored in the request, when the response
is received.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
- 4:25 AM Changeset in webkit [55046] by
-
- 3 edits in trunk/WebCore
2010-02-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[Soup] loses information related to message flags when converting from/to Resource{Request,Response}
https://bugs.webkit.org/show_bug.cgi?id=35093
Refactor updating of ResourceResponse objects from soup message
objects, to avoid code duplication.
No behaviour change.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
- platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::updateFromSoupMessage):
- 1:33 AM Changeset in webkit [55045] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=35190
Don't use system malloc in Java bindings
- bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): Switched to WTF::Vector.
- 12:24 AM Changeset in webkit [55044] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=9761
LiveConnect string conversion fails for java.lang.Object
Can't test Java in DRT (I wonder why).
- bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue): Added the necessary conversion. Also, removed CONVERT_NULL_TO_EMPTY_STRING dead code.
Feb 19, 2010:
- 7:06 PM Changeset in webkit [55043] by
-
- 17 edits in trunk
2010-02-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- Configurations/FeatureDefines.xcconfig:
2010-02-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- win/tools/vsprops/FeatureDefines.vsprops:
2010-02-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- features.gypi:
2010-02-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- Configurations/FeatureDefines.xcconfig:
2010-02-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
I made ENABLE(SANDBOX) only control the sandbox attribute itself;
I did not ifdef the infrastructure to make sandboxing
switchable. This is because the likely concerns about sandboxing
are not stability of the infrastructure code, but rather the fact
that the security model exposed to authors is still evolving.
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- WebCore.pri:
- html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::parseMappedAttribute):
2010-02-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- configure.ac:
2010-02-19 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147
- Scripts/build-webkit: Handle new flag.
- 6:08 PM Changeset in webkit [55042] by
-
- 3 edits in trunk/WebKitTools
2010-02-19 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Shinichiro Hamaji.
[style-queue] should not complain about identifier names with underscores under WebKit/efl/ewk/
https://bugs.webkit.org/show_bug.cgi?id=35091
White list unix_hacker_style names in WebKit/efl/ewk because these
are used in the EFL API.
- Scripts/webkitpy/style/checker.py:
- Filter out readability/naming on WebKit/efl/ewk.
- 5:23 PM Changeset in webkit [55041] by
-
- 7 edits in trunk
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=35132
<rdar://problem/7664353> Mouse cursor sometimes flickers over Flash content (35132)
WebCore:
- page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): Don't set mouse pointer when above a plug-in or applet to prevent flicker.
WebKit:
- Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::mouseMoved): Send adjustCursor events on every mouse move. This matches Firefox, and is actually required for plug-ins to manipulate cursor wihout resorting to techniques such as fast firing timers.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView handleMouseEntered:]): Some plug-ins handle mouse cursor internally, but those that don't just need to get an arrow cursor (matching Firefox). This means that e.g. a plugin inside <A> won't get a finger mouse pointer.
- Plugins/WebHostedNetscapePluginView.mm: (-[WebNetscapePluginView handleMouseEntered:]): (-[WebNetscapePluginView handleMouseExited:]): Implement this behavior here, too. Also, out of process code didn't reset mouse pointer on mouse exit, which it needed to do.
- WebView/WebHTMLView.mm: (needsCursorRectsSupportAtPoint): (setCursor): (resetCursorRects): Make sure that the same workaround we have for Web content also applies to Netscape plug-ins, as AppKit would reset the mouse pointer to arrow if given a chance. (+[WebHTMLViewPrivate initialize]): Renamed setCursorIMP on Leopard and higher to prevent confusion - the method we override is completely different. (-[WebHTMLView hitTest:]): Added a FIXME about a likely bug.
- 4:51 PM Changeset in webkit [55040] by
-
- 2 edits in trunk/LayoutTests
2010-02-19 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
fast/forms/search-event-delay.html failed on Snow Leopard Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33543
- platform/mac-snowleopard/Skipped:
- This test prints times and expects 0.1s precision even on Debug bots. That can't work. Skipping the test to make the bots green until this can be made non-flakey or until we have a layout test system which allows "failure" expectations.
- 4:45 PM Changeset in webkit [55039] by
-
- 2 edits in trunk/WebCore
Fix regression in calculating an animated image's start time.
https://bugs.webkit.org/show_bug.cgi?id=35115
Reviewed by Adam Barth.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::startAnimation):
- 4:44 PM Changeset in webkit [55038] by
-
- 2 edits in trunk/LayoutTests
2010-02-19 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
editing/pasteboard/4641033.html timed out on Tiger Bot
https://bugs.webkit.org/show_bug.cgi?id=33310
- platform/mac-tiger/Skipped:
- 4:41 PM Changeset in webkit [55037] by
-
- 4 edits in trunk/WebKit/chromium
2010-02-19 James Hawkins <jhawkins@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Call WebViewClient::didAcceptAutoFillSuggestion when the
user selects a suggestion from the AutoFill suggestions popup.
- public/WebViewClient.h: (WebKit::WebViewClient::didAcceptAutoFillSuggestion):
- src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::valueChanged):
- src/AutoFillPopupMenuClient.h:
- 3:44 PM Changeset in webkit [55036] by
-
- 13 edits in trunk/WebCore
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=35178
LiveConnect code uses hand-rolled fprintf logging
Changed to use LOG, LOG_ERROR and ASSERT.
- platform/Logging.cpp: (WebCore::getChannelFromName):
- platform/Logging.h:
- platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):
- platform/win/LoggingWin.cpp: (WebCore::InitializeLoggingChannelsIfNecessary): TextConversion channel was (almost) unused, renamed to LiveConnect.
- platform/text/gtk/TextCodecGtk.cpp: (WebCore::TextCodecGtk::registerEncodingNames): The only use of this channel was in platform specific code, commandeered it for cross-platform needs.
- bridge/jni/JNIBridge.cpp:
- bridge/jni/JNIUtility.cpp: (JSC::Bindings::getJavaVM): (JSC::Bindings::getJNIEnv): (JSC::Bindings::getJNIField):
- bridge/jni/JNIUtility.h: (JSC::Bindings::callJNIMethodV): (JSC::Bindings::callJNIStaticMethod):
- bridge/jni/jni_jsobject.mm: (completedJavaScriptAccess): (dispatchToJavaScriptThread): (performJavaScriptAccess): (JavaJSObject::invoke): (JavaJSObject::call): (JavaJSObject::eval): (JavaJSObject::getMember): (JavaJSObject::setMember): (JavaJSObject::removeMember): (JavaJSObject::getSlot): (JavaJSObject::setSlot): (JavaJSObject::toString): (JavaJSObject::createNative):
- bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::valueFromInstance): (JavaField::setValueToInstance):
- bridge/jni/jsc/JavaClassJSC.cpp: (JavaClass::JavaClass):
- bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): (JObjectWrapper::JObjectWrapper): (JObjectWrapper::~JObjectWrapper):
- 3:36 PM Changeset in webkit [55035] by
-
- 5 edits in trunk/JavaScriptCore
JSString::getIndex() calls value() to resolve the string value (is a rope)
to a UString, then passes the result to jsSingleCharacterSubstring without
checking for an exception. In case of out-of-memory the returned UString
is null(), which may result in an out-of-buounds substring being created.
This is bad.
Reviewed by Oliver Hunt.
Simple fix is to be able to get an index from a rope without resolving to
UString. This may be a useful optimization in some test cases.
The same bug exists in some other methods is JSString, these can be fixed
by changing them to call getIndex().
- runtime/JSString.cpp:
(JSC::JSString::resolveRope):
(JSC::JSString::getStringPropertyDescriptor):
- runtime/JSString.h:
(JSC::jsSingleCharacterSubstring):
(JSC::JSString::getIndex):
(JSC::jsSingleCharacterString):
(JSC::JSString::getStringPropertySlot):
- runtime/UStringImpl.cpp:
(JSC::singleCharacterSubstring):
- runtime/UStringImpl.h:
(JSC::UStringImpl::singleCharacterSubstring):
- 3:07 PM Changeset in webkit [55034] by
-
- 5 edits1 move in trunk/WebKitTools
2010-02-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Split out "prepare-rollout" from "rollout" and make --complete-rollout default
https://bugs.webkit.org/show_bug.cgi?id=33745
- Scripts/webkitpy/commands/download.py:
- Add a new AbstractRolloutPrepCommand to share code between PrepareRollout and Rollout
- Add PrepareRollout
- Scripts/webkitpy/commands/download_unittest.py: Test PrepareRollout, remove CompleteRollout tests.
- Scripts/webkitpy/steps/init.py: include ReopenBugAfterRollout step.
- Scripts/webkitpy/steps/completerollout.py: Removed.
- Scripts/webkitpy/steps/options.py: remove complete_rollout
- Scripts/webkitpy/steps/reopenbugafterrollout.py: Added.
- 3:06 PM Changeset in webkit [55033] by
-
- 2 edits in trunk/WebCore
2010-02-19 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
RenderSVGResourceMasker causes an Assert on Wind builds during DRT
https://bugs.webkit.org/show_bug.cgi?id=35182
We remove the Assert for now and return earlier, if the HashMap of the Masker
does not contain the RenderObject. The RenderObject is an identifiert to get
a already calculated mask.
A race condition during parsing can cause the invalidation call, before the mask
got calculated (only during DRT on Win build bots).
The real bug will be fixed with: https://bugs.webkit.org/show_bug.cgi?id=35181
- rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::invalidateClient):
- 2:50 PM Changeset in webkit [55032] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-19 James Hawkins <jhawkins@chromium.org>
Reviewed by Eric Seidel.
[Chromium] Use the m_suggestionsPopupClient pointer to refer to the
popup client, as the Autocomplete popup might not be the current
popup.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::autocompleteHandleKeyEvent): (WebKit::WebViewImpl::refreshSuggestionsPopup):
- 2:34 PM Changeset in webkit [55031] by
-
- 4 edits in trunk/WebKit/chromium
2010-02-19 James Hawkins <jhawkins@chromium.org>
Reviewed by Eric Seidel.
[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to
onAutocompleteSuggestionAccepted to better match the purpose of the
function.
- src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::onAutocompleteSuggestionAccepted):
- src/EditorClientImpl.h:
- src/SuggestionsPopupMenuClient.cpp: (WebKit::SuggestionsPopupMenuClient::valueChanged):
- 2:10 PM Changeset in webkit [55030] by
-
- 5 edits in trunk/WebKit/mac
2010-02-19 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
<rdar://problem/7535894> Page contents missing from snapshot on Newsweek.com article
Followup to avoid capturing compositing layers twice in snapshots. Add private
methods to WebView to specify whether drawing the WebView into an image will
include flattened compositing layers (the default behavior) or not.
- WebView/WebFrame.mm: (-[WebFrame _drawRect:contentsOnly:]): Consult the WebView flag to see if we want flattening.
- WebView/WebViewPrivate.h: New methods.
- WebView/WebView.mm: Ditto. (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:]): (-[WebView _includesFlattenedCompositingLayersWhenDrawingToBitmap]):
- WebView/WebViewData.h: New member variable.
- 1:44 PM Changeset in webkit [55029] by
-
- 11 edits in trunk
WebCore: Make Pasteboard::writeImage() safe against NULL cachedImages, and clean
up some code.
https://bugs.webkit.org/show_bug.cgi?id=35136
Reviewed by Darin Fisher.
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateRenderer): Shorten some code.
- page/DragController.cpp:
(WebCore::getImage): Shorten some code.
- platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
- platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
WebKit/chromium: Add an isImageBlocked bool to the WebContextMenuData struct.
https://bugs.webkit.org/show_bug.cgi?id=35136
Reviewed by Darin Fisher.
This lets us properly enable/disable the "Copy Image" context menu entry
(and, in the future, maybe add a "Load Image" function).
- public/WebContextMenuData.h:
- src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
- 1:30 PM Changeset in webkit [55028] by
-
- 2 edits in trunk/WebCore
Rubberstamped by Noam Rosenthal, who wrote the original code.
Make mouse wheel scrolling work when using the GraphicsLayer.
- platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
- 1:08 PM Changeset in webkit [55027] by
-
- 7 edits1 add in trunk/JavaScriptCore
2010-02-19 Oliver Hunt <oliver@apple.com>
RS = Gavin Barraclough.
Split the 32/64 version of JITPropertyAccess into a separate file.
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.pri:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- jit/JITPropertyAccess.cpp:
- jit/JITPropertyAccess32_64.cpp: Added. (JSC::JIT::emit_op_put_by_index): (JSC::JIT::emit_op_put_getter): (JSC::JIT::emit_op_put_setter): (JSC::JIT::emit_op_del_by_id): (JSC::JIT::emit_op_method_check): (JSC::JIT::emitSlow_op_method_check): (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emitSlow_op_put_by_val): (JSC::JIT::emit_op_get_by_id): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emitSlow_op_put_by_id): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutDirectOffset): (JSC::JIT::compileGetDirectOffset): (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchMethodCallProto): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::emit_op_get_by_pname): (JSC::JIT::emitSlow_op_get_by_pname):
- 12:30 PM Changeset in webkit [55026] by
-
- 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/config.json
2010-02-19 William Siegrist <wsiegrist@apple.com>
Add GTK Linux 64-bit Release bot. Rename GTK Linux Release to GTK Linux 32-bit Release.
- 11:47 AM Changeset in webkit [55025] by
-
- 4 edits in trunk/WebKitTools
2010-02-19 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Need a final integration between QtLauncher and QGVLauncher
https://bugs.webkit.org/show_bug.cgi?id=35161
Add animated flip support to QtLauncher when running on QGraphicsView mode.
- QtLauncher/main.cpp: (LauncherWindow::initializeView): (LauncherWindow::setupUI):
- QtLauncher/webview.cpp: (WebViewGraphicsBased::WebViewGraphicsBased): (WebViewGraphicsBased::animatedFlip): (WebViewGraphicsBased::animatedYFlip):
- QtLauncher/webview.h: (WebViewGraphicsBased::setYRotation): (WebViewGraphicsBased::yRotation):
- 11:30 AM Changeset in webkit [55024] by
-
- 2 edits1 move in trunk/JavaScriptCore
2010-02-19 Patrick Gansterer <paroga@paroga.com>
Reviewed by Laszlo Gombos.
Added additional parameter to create_rvct_stubs
for setting the regularexpression prefix.
Renamed it because it now works for other platforms too.
https://bugs.webkit.org/show_bug.cgi?id=34951
- DerivedSources.pro:
- create_jit_stubs: Copied from JavaScriptCore/create_rvct_stubs.
- create_rvct_stubs: Removed.
- 11:22 AM Changeset in webkit [55023] by
-
- 2 edits in trunk/WebCore
2010-02-19 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[V8] Fix Worker crash regression in r54972
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object): Properly unwrap global objects when inside a WorkerContext.
- 11:09 AM Changeset in webkit [55022] by
-
- 3 edits in trunk/WebCore
Not reviewed. Reverts r55020 which causes crashes in Chromium LayoutTests
- 10:59 AM Changeset in webkit [55021] by
-
- 5 edits in trunk
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=35165
plugins/set-status.html fails on Windows bot
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::status):
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView status:]): Match Windows port behavior (and also Firefox one, in a way) - pass null status messages as empty ones to chrome.
- 9:13 AM Changeset in webkit [55020] by
-
- 3 edits in trunk/WebCore
2010-02-19 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Sets default values of V8 runtime enabler flags to match behavior with JSC
https://bugs.webkit.org/show_bug.cgi?id=35095
No new tests, modifies a Chromium feature only.
- bindings/generic/RuntimeEnabledFeatures.cpp: Modified. Sets appcache and geolocation flag defaults to 'on'
- storage/Database.cpp: Modified. Sets database flag default to 'on'.
- 9:13 AM Changeset in webkit [55019] by
-
- 5 edits20 adds in trunk
[Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender, add results
for passing new tests and unskip the passing ones from the Skipped list.
https://bugs.webkit.org/show_bug.cgi?id=35159
Reviewed by Kenneth Rohde Christiansen.
WebKitTools:
- DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::textZoomIn):
(EventSender::textZoomOut):
- DumpRenderTree/qt/EventSenderQt.h:
LayoutTests:
- platform/qt/Skipped: unskip passing tests
- platform/qt/svg/custom/text-zoom-expected.txt: Added.
- platform/qt/svg/zoom: Added.
- platform/qt/svg/zoom/page: Added.
- platform/qt/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Added.
- platform/qt/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added.
- platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
- platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
- platform/qt/svg/zoom/text: Added.
- platform/qt/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Added.
- platform/qt/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Added.
- platform/qt/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Added.
- platform/qt/svg/zoom/text/zoom-foreignObject-expected.txt: Added.
- platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added.
- platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt: Added.
- platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added.
- platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.
- 8:57 AM Changeset in webkit [55018] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-19 Marcus Bulach <bulach@chromium.org>
Reviewed by Jeremy Orlow.
Fixes GeolocationServiceBridgeImpl::stopUpdating (it can be called multiple times).
- src/GeolocationServiceBridgeChromium.cpp: (WebKit::GeolocationServiceBridgeImpl::stopUpdating):
- 8:50 AM Changeset in webkit [55017] by
-
- 2 edits in trunk/LayoutTests
2010-02-19 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Gustavo Noronha Silva.
[GTK] fast/forms/restore-selection-after-layout.html fails on 32bits Debug build
https://bugs.webkit.org/show_bug.cgi?id=35158
- platform/gtk/Skipped: Skip failing test
- 7:16 AM Changeset in webkit [55016] by
-
- 9 edits2 adds in trunk
2010-02-19 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Elements panel: Correctly show empty elements' ending tags
for XML and HTML documents.
https://bugs.webkit.org/show_bug.cgi?id=26315
- inspector/console-dirxml-expected.txt:
- inspector/console-format-collections-expected.txt:
- inspector/console-format-expected.txt:
- inspector/elements-panel-limited-children-expected.txt:
- inspector/elements-panel-structure-expected.txt: Re-baselined due to closing tags and ellipses between opening and closing tags
- inspector/elements-panel-xhtml-structure-expected.txt: Added.
- inspector/elements-panel-xhtml-structure.xhtml: Added.
2010-02-19 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Elements panel: Correctly show empty elements' ending tags
for XML and HTML documents.
https://bugs.webkit.org/show_bug.cgi?id=26315
Test: inspector/elements-panel-xhtml-structure.xhtml
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode): (WebInspector.ElementsTreeOutline.prototype.get isXMLMimeType): (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired): (WebInspector.ElementsTreeElement.prototype.onexpand): (WebInspector.ElementsTreeElement.prototype.oncollapse): (WebInspector.ElementsTreeElement.prototype.updateTitle.callback): (WebInspector.ElementsTreeElement.prototype.updateTitle): (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
- 6:52 AM Changeset in webkit [55015] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Unreviewed Changelog typo fix.
- 6:45 AM Changeset in webkit [55014] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] plugins/set-status.html introduced in r5993 fails skipping it until fix.
https://bugs.webkit.org/show_bug.cgi?id=35144
- platform/qt/Skipped:
- 6:34 AM Changeset in webkit [55013] by
-
- 3 edits in trunk/WebKitTools
2010-02-19 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
[Qt] Clean-up the handling of HTML5 persistent data for LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=35004
DumpRenderTreeQt.cpp calls QWebSettings::enablePersistentStorage which sets up
and enables all HTML5 persistent data. All the other calls for setting the
persistent path or enabling the persistent feature are redundant.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): No need to enable AppCache again.
- DumpRenderTree/qt/main.cpp: (main): No need to setup and enable HTML5 LocalStorage again.
- 5:13 AM Changeset in webkit [55012] by
-
- 5 edits in trunk
2010-02-19 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Send the context menu event from contextClick() of EventSender
and do not show context menu in DRT.
LayoutTests:
fast/events/contextmenu-scrolled-page-with-frame.html
[Qt] DRT: Send context menu event from EventSender
https://bugs.webkit.org/show_bug.cgi?id=35131
- platform/qt/Skipped:
2010-02-19 Diego Gonzalez <diego.gonzalez@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Send the context menu event from contextClick() of EventSender
and do not show context menu in DRT.
LayoutTests:
fast/events/contextmenu-scrolled-page-with-frame.html
[Qt] DRT: Send context menu event from EventSender
https://bugs.webkit.org/show_bug.cgi?id=35131
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::contextClick):
- 5:01 AM Changeset in webkit [55011] by
-
- 5 edits in trunk
2010-02-19 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Chromium build fix: reverting r54997 and r54998.
This is a two-sided change that should be coordinated.
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::protocolAccessorSetter):
- platform/KURLGoogle.cpp: (WebCore::KURL::setProtocol): (WebCore::KURL::isHierarchical):
- 4:41 AM Changeset in webkit [55010] by
-
- 2 edits2 copies in trunk/LayoutTests
[Qt] editing tests fails after r54980
https://bugs.webkit.org/show_bug.cgi?id=35145
Reviewed by Kenneth Rohde Christiansen.
After r54980 two tests fail, skip them until fix.
Another two tests pass, they have same results as Win port.
- platform/qt/Skipped:
- editing/selection/extend-selection.html skipped.
- editing/selection/extend-after-mouse-selection.html skipped.
- platform/qt/editing/selection/click-in-margins-inside-editable-div-expected.txt: Copied from LayoutTests/platform/win/editing/selection/click-in-margins-inside-editable-div-expected.txt.
- platform/qt/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt: Copied from LayoutTests/platform/win/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt.
- 4:40 AM Changeset in webkit [55009] by
-
- 2 edits in trunk/WebKit/chromium
2010-02-19 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Chromium tests fix: update devtools code to match new
web inspector object proxy format.
- src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.formatCallFrame_): (devtools.DebuggerAgent.formatObjectProxy_):
- 4:06 AM Changeset in webkit [55008] by
-
- 2 edits in trunk/LayoutTests
2010-02-19 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
[GTK] plugins/set-status.html fails
https://bugs.webkit.org/show_bug.cgi?id=35144
- platform/gtk/Skipped: Skip failing test.
- 1:18 AM Changeset in webkit [55007] by
-
- 1 edit1 add in trunk/LayoutTests
2010-02-19 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
Adding a GTK layout test result for a new test
added in r54980.
- platform/gtk/editing/selection/extend-after-mouse-selection-expected.txt: Added.
- 1:18 AM Changeset in webkit [55006] by
-
- 1 edit1 add in trunk/LayoutTests
2010-02-19 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Xan Lopez.
Adding a GTK layout test result for a new test
added in r54982.
- platform/gtk/fast/repaint/selection-gap-overflow-scroll-2-expected.txt: Added.
- 12:30 AM Changeset in webkit [55005] by
-
- 2 edits1 add in trunk/WebCore
2010-02-17 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Seidel.
[GTK] RTP/RTSP streams playback support
https://bugs.webkit.org/show_bug.cgi?id=33662
Added live pipelines support in updateStates().
- manual-tests/video-rtsp.html: Added.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::updateStates):
