Context Navigation

← Previous Period
Next Period →

Timeline

Mar 24, 2010:

11:59 PM Changeset in webkit [56501] by abarth@webkit.org

12 edits
3 moves in trunk/WebKitTools

2010-03-24 Adam Barth <abarth@webkit.org>

Unreviewed. Move comments.py and multicommandtool.py to their new
home.

Scripts/webkitpy/comments.py: Removed.
Scripts/webkitpy/multicommandtool.py: Removed.
Scripts/webkitpy/multicommandtool_unittest.py: Removed.
Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
Scripts/webkitpy/tool/commands/download.py:
Scripts/webkitpy/tool/commands/openbugs.py:
Scripts/webkitpy/tool/commands/queries.py:
Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/tool/commands/upload.py:
Scripts/webkitpy/tool/comments.py: Copied from Scripts/webkitpy/comments.py.
Scripts/webkitpy/tool/main.py:
Scripts/webkitpy/tool/multicommandtool.py: Copied from Scripts/webkitpy/multicommandtool.py.
Scripts/webkitpy/tool/multicommandtool_unittest.py: Copied from Scripts/webkitpy/multicommandtool_unittest.py.
Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
Scripts/webkitpy/tool/steps/closepatch.py:
Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
Scripts/webkitpy/unittests.py:

11:47 PM Changeset in webkit [56500] by abarth@webkit.org

2 edits in trunk/WebKitTools

2010-03-24 Adam Barth <abarth@webkit.org>

Unreviewed. Fixup one import statement I didn't find because the .pyc
masked the error.

Scripts/webkitpy/stepsequence.py:

11:44 PM Changeset in webkit [56499] by abarth@webkit.org

4 edits
2 moves in trunk/WebKitTools

2010-03-24 Adam Barth <abarth@webkit.org>

Unreviewed. Move queueengine.py to its new home.

Scripts/webkitpy/queueengine.py: Removed.
Scripts/webkitpy/queueengine_unittest.py: Removed.
Scripts/webkitpy/tool/bot/queueengine.py: Copied from Scripts/webkitpy/queueengine.py.
Scripts/webkitpy/tool/bot/queueengine_unittest.py: Copied from Scripts/webkitpy/queueengine_unittest.py.
Scripts/webkitpy/tool/commands/early_warning_system.py:
Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/unittests.py:

11:40 PM Changeset in webkit [56498] by abarth@webkit.org

3 edits
2 moves
2 adds in trunk/WebKitTools

2010-03-24 Adam Barth <abarth@webkit.org>

Unreviewed. Move patchcollection.py to its new home.

Scripts/webkitpy/patchcollection.py: Removed.
Scripts/webkitpy/patchcollection_unittest.py: Removed.
Scripts/webkitpy/tool/bot: Added.
Scripts/webkitpy/tool/bot/init.py: Added.
Scripts/webkitpy/tool/bot/patchcollection.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection.py.
Scripts/webkitpy/tool/bot/patchcollection_unittest.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection_unittest.py.
Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/unittests.py:

11:27 PM Changeset in webkit [56497] by Chris Jerdonek

38 edits
2 moves in trunk/WebKitTools

In Scripts/webkitpy, moved steps_references.py and the steps
folder into webkitpy/patch.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36093

Scripts/webkitpy/steps: Removed.
Scripts/webkitpy/steps/init.py: Removed.
Scripts/webkitpy/steps/abstractstep.py: Removed.
Scripts/webkitpy/steps/applypatch.py: Removed.
Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Removed.
Scripts/webkitpy/steps/build.py: Removed.
Scripts/webkitpy/steps/checkstyle.py: Removed.
Scripts/webkitpy/steps/cleanworkingdirectory.py: Removed.
Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Removed.
Scripts/webkitpy/steps/closebug.py: Removed.
Scripts/webkitpy/steps/closebugforlanddiff.py: Removed.
Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Removed.
Scripts/webkitpy/steps/closepatch.py: Removed.
Scripts/webkitpy/steps/commit.py: Removed.
Scripts/webkitpy/steps/confirmdiff.py: Removed.
Scripts/webkitpy/steps/createbug.py: Removed.
Scripts/webkitpy/steps/editchangelog.py: Removed.
Scripts/webkitpy/steps/ensurebuildersaregreen.py: Removed.
Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Removed.
Scripts/webkitpy/steps/metastep.py: Removed.
Scripts/webkitpy/steps/obsoletepatches.py: Removed.
Scripts/webkitpy/steps/options.py: Removed.
Scripts/webkitpy/steps/postdiff.py: Removed.
Scripts/webkitpy/steps/postdiffforcommit.py: Removed.
Scripts/webkitpy/steps/postdiffforrevert.py: Removed.
Scripts/webkitpy/steps/preparechangelog.py: Removed.
Scripts/webkitpy/steps/preparechangelogforrevert.py: Removed.
Scripts/webkitpy/steps/promptforbugortitle.py: Removed.
Scripts/webkitpy/steps/reopenbugafterrollout.py: Removed.
Scripts/webkitpy/steps/revertrevision.py: Removed.
Scripts/webkitpy/steps/runtests.py: Removed.
Scripts/webkitpy/steps/steps_unittest.py: Removed.
Scripts/webkitpy/steps/update.py: Removed.
Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Removed.
Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Removed.
Scripts/webkitpy/steps/validatereviewer.py: Removed.
Scripts/webkitpy/steps_references.py: Removed.
Scripts/webkitpy/stepsequence.py:
Scripts/webkitpy/tool/commands/download.py:
Scripts/webkitpy/tool/commands/upload.py:
Scripts/webkitpy/tool/steps: Copied from WebKitTools/Scripts/webkitpy/steps.
Scripts/webkitpy/tool/steps/init.py:
Scripts/webkitpy/tool/steps/applypatch.py:
Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
Scripts/webkitpy/tool/steps/build.py:
Scripts/webkitpy/tool/steps/checkstyle.py:
Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
Scripts/webkitpy/tool/steps/cleanworkingdirectorywithlocalcommits.py:
Scripts/webkitpy/tool/steps/closebug.py:
Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
Scripts/webkitpy/tool/steps/closepatch.py:
Scripts/webkitpy/tool/steps/commit.py:
Scripts/webkitpy/tool/steps/confirmdiff.py:
Scripts/webkitpy/tool/steps/createbug.py:
Scripts/webkitpy/tool/steps/editchangelog.py:
Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
Scripts/webkitpy/tool/steps/metastep.py:
Scripts/webkitpy/tool/steps/obsoletepatches.py:
Scripts/webkitpy/tool/steps/postdiff.py:
Scripts/webkitpy/tool/steps/postdiffforcommit.py:
Scripts/webkitpy/tool/steps/postdiffforrevert.py:
Scripts/webkitpy/tool/steps/preparechangelog.py:
Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
Scripts/webkitpy/tool/steps/promptforbugortitle.py:
Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
Scripts/webkitpy/tool/steps/revertrevision.py:
Scripts/webkitpy/tool/steps/runtests.py:
Scripts/webkitpy/tool/steps/steps_unittest.py:
Scripts/webkitpy/tool/steps/update.py:
Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
Scripts/webkitpy/tool/steps/validatereviewer.py:
Scripts/webkitpy/tool/steps_references.py: Copied from WebKitTools/Scripts/webkitpy/steps_references.py.
Scripts/webkitpy/unittests.py:

11:22 PM Changeset in webkit [56496] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-03-24 Eric Seidel <eric@webkit.org>

Unreviewed, build fix only.

Abstract LayoutTestResults logic for easier reuse
https://bugs.webkit.org/show_bug.cgi?id=36579

Scripts/webkitpy/buildbot_unittest.py: Add a missing import.

11:15 PM Changeset in webkit [56495] by abarth@webkit.org

3 edits in trunk/WebKitTools

2010-03-24 Adam Barth <abarth@webkit.org>

Unreviewed. Fix a stray comma to test landing an patch without review.

Scripts/webkitpy/commitinfo.py:

11:10 PM Changeset in webkit [56494] by Chris Jerdonek

16 edits
2 moves in trunk/WebKitTools

In Scripts/webkitpy, moved commands_references.py and the commands
folder into webkitpy/patch.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36483

This is part of master bug 36093 to organize webkitpy.

Scripts/webkitpy/commands: Removed.
Scripts/webkitpy/commands/init.py: Removed.
Scripts/webkitpy/commands/abstractsequencedcommand.py: Removed.
Scripts/webkitpy/commands/commandtest.py: Removed.
Scripts/webkitpy/commands/download.py: Removed.
Scripts/webkitpy/commands/download_unittest.py: Removed.
Scripts/webkitpy/commands/early_warning_system.py: Removed.
Scripts/webkitpy/commands/early_warning_system_unittest.py: Removed.
Scripts/webkitpy/commands/openbugs.py: Removed.
Scripts/webkitpy/commands/openbugs_unittest.py: Removed.
Scripts/webkitpy/commands/queries.py: Removed.
Scripts/webkitpy/commands/queries_unittest.py: Removed.
Scripts/webkitpy/commands/queues.py: Removed.
Scripts/webkitpy/commands/queues_unittest.py: Removed.
Scripts/webkitpy/commands/queuestest.py: Removed.
Scripts/webkitpy/commands/sheriffbot.py: Removed.
Scripts/webkitpy/commands/sheriffbot_unittest.py: Removed.
Scripts/webkitpy/commands/upload.py: Removed.
Scripts/webkitpy/commands/upload_unittest.py: Removed.
Scripts/webkitpy/commands_references.py: Removed.
Scripts/webkitpy/tool/commands: Copied from WebKitTools/Scripts/webkitpy/commands.
Scripts/webkitpy/tool/commands/commandtest.py:
Scripts/webkitpy/tool/commands/download.py:
Scripts/webkitpy/tool/commands/download_unittest.py:
Scripts/webkitpy/tool/commands/early_warning_system.py:
Scripts/webkitpy/tool/commands/early_warning_system_unittest.py:
Scripts/webkitpy/tool/commands/openbugs_unittest.py:
Scripts/webkitpy/tool/commands/queries_unittest.py:
Scripts/webkitpy/tool/commands/queues_unittest.py:
Scripts/webkitpy/tool/commands/queuestest.py:
Scripts/webkitpy/tool/commands/sheriffbot.py:
Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
Scripts/webkitpy/tool/commands/upload.py:
Scripts/webkitpy/tool/commands/upload_unittest.py:
Scripts/webkitpy/tool/commands_references.py: Copied from WebKitTools/Scripts/webkitpy/commands_references.py.
Scripts/webkitpy/tool/main.py:
Scripts/webkitpy/unittests.py:

11:07 PM Changeset in webkit [56493] by mrowe@apple.com

2 edits in trunk/WebKit/mac

Build fix after r56474.

Plugins/Hosted/NetscapePluginHostProxy.mm:

(WKPCRunSyncOpenPanel):

11:07 PM Changeset in webkit [56492] by mrowe@apple.com

5 edits in trunk

Revert the portion of r56489 that dealt with port zero as it introduced some test failures.

WebCore:

platform/KURL.cpp:

(WebCore::KURL::port): Use the "ok" argument to charactersToUIntStrict to determine whether
it was able to successfully parse the string as an unsigned integer, rather than relying on
the fact it returned zero when it failed.

LayoutTests:

platform/mac/security/block-test-expected.txt:
security/block-test.html:

10:51 PM Changeset in webkit [56491] by abarth@webkit.org

2 edits
1 copy
1 move
1 delete in trunk/WebKitTools

2010-03-24 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename webkitpy.patch to webkitpy.tool
https://bugs.webkit.org/show_bug.cgi?id=36580

This is in preparation for the great webkitpy naming cleanup.

Scripts/webkit-patch:
Scripts/webkitpy/patch: Removed.
Scripts/webkitpy/patch/init.py: Removed.
Scripts/webkitpy/patch/patcher.py: Removed.
Scripts/webkitpy/tool: Copied from WebKitTools/Scripts/webkitpy/patch.
Scripts/webkitpy/tool/main.py: Copied from WebKitTools/Scripts/webkitpy/patch/patcher.py.
Scripts/webkitpy/tool/patcher.py: Removed.

10:36 PM Changeset in webkit [56490] by barraclough@apple.com

2 edits in trunk/WebCore

platform/text/String.cpp:

(WebCore::putUTF8Triple): Correct capitalization of function name.
(WebCore::String::utf8): Fix C-style casts.
(WebCore::String::fromUTF8): Remove unnecessary newline.
(WebCore::String::fromUTF8WithLatin1Fallback): Use early return.

Reviewed by Sam Weinig.

10:26 PM Changeset in webkit [56489] by mrowe@apple.com

6 edits in trunk

WebKit should treat port numbers outside the valid range as being blacklisted
<http://webkit.org/b/36571> / <rdar://problem/7790908>

Reviewed by Darin Adler.

WebCore:

platform/KURL.cpp:

(WebCore::KURL::port): Map invalid port numbers to invalidPortNumber.
(WebCore::portAllowed): Add invalidPortNumber to the blacklist.

platform/KURLGoogle.cpp: invalid port numbers to invalidPortNumber.

(WebCore::KURL::port): Add invalidPortNumber to the blacklist.
Also bring this in to sync with KURL. Having this identical code in two places is stupid.

LayoutTests:

platform/mac/security/block-test-expected.txt:
security/block-test.html: Add tests of a few invalid port numbers.

10:25 PM Changeset in webkit [56488] by eric@webkit.org

4 edits in trunk/WebKitTools

2010-03-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Abstract LayoutTestResults logic for easier reuse
https://bugs.webkit.org/show_bug.cgi?id=36579

Scripts/webkitpy/buildbot.py:
- Split out logic into new LayoutTestResults class.
Scripts/webkitpy/buildbot_unittest.py:
- Rename the testing class to match.
Scripts/webkitpy/commands/queries.py:
- Use the new LayoutTestResults class.

10:14 PM Changeset in webkit [56487] by eric@webkit.org

4 edits in trunk/WebKitTools

2010-03-24 Eric Seidel <eric@webkit.org>

Reviewed by Eric Seidel.

Move Bugzilla.prompt_for_component to User.prompt_with_list for re-use
https://bugs.webkit.org/show_bug.cgi?id=36577

Scripts/webkitpy/bugzilla.py:
- Move prompt_for_component to User
Scripts/webkitpy/commands/queries.py:
- Add a missing argument_names declaration.
Scripts/webkitpy/user.py:
- Add prompt_with_list
- Make staticmethods classmethods for easier mocking

9:58 PM Changeset in webkit [56486] by eric@webkit.org

3 edits in trunk/LayoutTests

2010-03-24 MORITA Hajime <morrita@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=36517
svg/dom/frame-related-api-during-load.html shoud be more self-descriptive.

svg/dom/frame-related-api-during-load-expected.txt:
svg/dom/frame-related-api-during-load.html:

9:28 PM Changeset in webkit [56485] by ddkilzer@apple.com

1 edit in trunk/WebKitTools/ChangeLog

Fix bug URL.

9:25 PM Changeset in webkit [56484] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

<htp://webkit.org/b/36572> commit-log-editor: thinks mergeChangeLogs.pl is a ChangeLog file

Reviewed by Eric Seidel.

Fixes the following error when committing a file with
"ChangeLog" in the name that isn't a ChangeLog (like
mergeChangeLogs.pl from r56471 and r56472):

$ git commit .
Can't open WebKitTools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLog at commit-log-editor line 132.
error: There was a problem with the editor 'commit-log-editor'.
Please supply the message using either -m or -F option.

Scripts/commit-log-editor: Added '$' to anchor "ChangeLog" to

the end of the file name when searching for ChangeLog files in a
commit.

9:15 PM Changeset in webkit [56483] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

<http://webkit.org/b/36570> resolve-ChangeLogs: fall back to git-merge-file if ChangeLog can't be merged

Reviewed by Eric Seidel.

Scripts/resolve-ChangeLogs: Switched to exec git-merge-file if

the merge attempt fails.

9:15 PM Changeset in webkit [56482] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

Switch String::latin1, String::utf8, String::fromUTF8 to
use WTF's Unicode conversion methods rather than TextEncoder.
These methods only perform simple conversion, and don't need
really require TextEncoder's full capability (to look up arbitrary
encodings by name), switching to only be dependent on WTF will
make it easier if we chose to move WebCore::String to WTF.

Reviewed by Sam Weinig.

JavaScriptCore.exp:

9:08 PM Changeset in webkit [56481] by scherkus@chromium.org

13 edits in trunk/LayoutTests

2010-03-24 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson, Eric Seidel and David Levin.

Update a few more media layout tests to choose test clips based on codec support.

https://bugs.webkit.org/show_bug.cgi?id=30435

media/audio-constructor-src.html: Switched to use findMediaFile().
media/audio-play-event-expected.txt: Updated results.
media/audio-play-event.html: Switched to use findMediaFile().
media/video-no-audio.html: Ditto.
media/video-source-add-src.html: Ditto.
media/video-src-change.html: Closed p tag.
platform/mac-leopard/media/video-no-audio-expected.checksum: New results due to changing source video.
platform/mac-leopard/media/video-no-audio-expected.png: Ditto.
platform/mac-leopard/media/video-no-audio-expected.txt: Ditto.
platform/mac/media/video-no-audio-expected.checksum: Ditto.
platform/mac/media/video-no-audio-expected.png: Ditto.
platform/mac/media/video-no-audio-expected.txt: Ditto.

9:07 PM Changeset in webkit [56480] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.

JavaScriptCore.exp:

8:56 PM Changeset in webkit [56479] by weinig@apple.com

2 edits in trunk/WebCore

Add some missing exports.

Reviewed by Mark Rowe.

WebCore.base.exp:

8:45 PM Changeset in webkit [56478] by abarth@webkit.org

7 edits
1 add in trunk/WebKitTools

2010-03-24 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch or pre-commit hook should validate reviewer lines before committing
https://bugs.webkit.org/show_bug.cgi?id=26927

Validate that patches have valid reivewers listed in their ChangeLogs
before landing. For patches without reviewers can be landed if their
ChangeLogs state that they are unreviewed.

Scripts/webkitpy/changelogs.py:
Scripts/webkitpy/commands/download.py:
Scripts/webkitpy/commitinfo.py:
Scripts/webkitpy/commitinfo_unittest.py:
Scripts/webkitpy/mock_bugzillatool.py:
Scripts/webkitpy/steps/init.py:
Scripts/webkitpy/steps/validatereviewer.py: Added.

8:43 PM Changeset in webkit [56477] by barraclough@apple.com

2 edits in trunk/WebCore

Reviewed by Sam Weinig.

platform/text/String.cpp:

(WebCore::String::latin1):
(WebCore::putUTF8triple):
(WebCore::String::utf8):
(WebCore::String::fromUTF8):

6:10 PM Changeset in webkit [56476] by eric@webkit.org

1 edit in trunk/WebCore/ChangeLog

Restore peace and justice to the universe.

6:06 PM Changeset in webkit [56475] by zecke@webkit.org

5 edits in trunk/WebKitTools

Undefined names reported by pyflakes in python scripts

ttps://bugs.webkit.org/show_bug.cgi?id=36403

Attempt to use names that exist or can exist in the lexical
scope instead of not being available at all.

Scripts/webkitpy/changelogs.py: Use self._content.
Scripts/webkitpy/layout_tests/port/base.py: Use os.stat
Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Use self._port
Scripts/webkitpy/style/processors/cpp_unittest.py: Use expected_message_re

5:52 PM Changeset in webkit [56474] by ap@apple.com

4 edits in trunk/WebKit/mac

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=36563
A plug-in makes Safari crash on http://www.itscodingtime.com/

Plugins/Hosted/NetscapePluginHostProxy.h: (WebKit::NetscapePluginHostProxy::port): Assert that the object is still alive. This isn't beautifully systemic, but helped catch a bug, and may help catch more. (WebKit::NetscapePluginHostProxy::clientPort): Ditto. (WebKit::NetscapePluginHostProxy::isProcessingRequests): Changed m_processingRequests to a static. This doesn't change behavior much, but helps avoid writing into deallocated memory.

Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Changed m_processingRequests to a static. (WebKit::NetscapePluginHostProxy::processRequests): Ditto. Changing m_processingRequests after destroying the object in pluginHostDied() was wrong, but reasonably harmless, as there wasn't much time for some other object to be allocated at this address. (WKPCEvaluate): Refetch host proxy, as it may have been destroyed. (WKPCInvoke): Ditto. (WKPCInvokeDefault): Ditto. (WKPCGetProperty): Ditto. (WKPCSetProperty): Ditto. (WKPCRemoveProperty): Ditto. (WKPCHasProperty): Ditto. (WKPCHasMethod): Ditto. (WKPCEnumerate): Ditto. (WKPCRunSyncOpenPanel): Ditto.

Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply): Bail out of the "event loop" if host proxy went away while processing a request.

5:02 PM Changeset in webkit [56473] by eric@webkit.org

3 edits in trunk/WebKit/qt

2010-03-24 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Add the FrameFlatteningEnabled WebAttribute to QWebSettings.

[Qt] Missing QWebSettings for Frame Flattening
https://bugs.webkit.org/show_bug.cgi?id=36553

Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
Api/qwebsettings.h:

4:50 PM Changeset in webkit [56472] by ddkilzer@apple.com

3 edits in trunk/WebKitTools

<http://webkit.org/b/36560> resolve-ChangeLogs: git-rebase fails when resolve-ChangeLogs can't merge

Reviewed by Eric Seidel.

When resolve-ChangeLogs fails to merge a patch while running as
a git merge driver, it deletes the original file, which causes
an internal failure and stops git mid-merge:

fatal: Failed to execute internal merge

The fix is to use the --force switch with patch so that it will
always attempt to apply the patch. (The change in
mergeChangeLogs() for the previous commit also fixed this, but
adding --force also prevents any potential user interaction that
patch may want to display.)

Scripts/VCSUtils.pm:

(mergeChangeLogs): Added --force switch to patch command. Also
changed to use the exit status from the patch command to
determine the return value for this method.

Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added

test to cover this bug.

4:50 PM Changeset in webkit [56471] by ddkilzer@apple.com

3 edits
1 add in trunk/WebKitTools

<http://webkit.org/b/36560> resolve-ChangeLogs: move mergeChanges() into VCSUtils package

Reviewed by Eric Seidel.

Scripts/VCSUtils.pm:

(mergeChangeLogs): Copied from mergeChanges() in
resolve-ChangeLogs and renamed. Added method documentation.
Fixed bug found by new tests where the original file to be
patched was deleted when cleaning up after a traditinal rejected
patch failed to apply.

Scripts/resolve-ChangeLogs: Switched to using

mergeChangeLogs().
(mergeChanges): Moved to VCSUtils.pm and renamed to
mergeChangeLogs().

Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added.

4:36 PM Changeset in webkit [56470] by eric@webkit.org

5 edits in trunk/WebKitTools

2010-03-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add support for qt's unassigned list to webkit-patch assign-to-committer
https://bugs.webkit.org/show_bug.cgi?id=36559

Scripts/webkitpy/bugzilla.py:
- Move Bugzilla.unassigned_email into Bug and make it a set.
Scripts/webkitpy/bugzilla_unittest.py:
- Test the new Bug.is_unassigned method
Scripts/webkitpy/commands/upload.py:
- Use the new Bug.is_unassigned method instead of an explicit ==
Scripts/webkitpy/mock_bugzillatool.py:
- Bugzilla.unassigned_email no longer needs mocking

4:30 PM Changeset in webkit [56469] by dimich@chromium.org

4 edits in trunk

2010-03-24 Dmitry Titov <dimich@chromium.org>

No review, rolling out r56453.
http://trac.webkit.org/changeset/56453
https://bugs.webkit.org/show_bug.cgi?id=36426

In Chromium port, it broke invalid-image-data-standalone.html
invalid-image-data.html multipart-wait-before-boundary.html
stop-crash.html win-boundary-crash.html

loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument):

2010-03-24 Dmitry Titov <dimich@chromium.org>

No review, rolling out r56453.
http://trac.webkit.org/changeset/56453
https://bugs.webkit.org/show_bug.cgi?id=36426

In Chromium port, it broke invalid-image-data-standalone.html
invalid-image-data.html multipart-wait-before-boundary.html
stop-crash.html win-boundary-crash.html

src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::ResourceHandleInternal): (WebCore::ResourceHandleInternal::start): (WebCore::ResourceHandleInternal::cancel): (WebCore::ResourceHandleInternal::didReceiveResponse): (WebCore::ResourceHandleInternal::didReceiveData): (WebCore::ResourceHandleInternal::didFinishLoading): (WebCore::ResourceHandleInternal::didFail):

4:21 PM Changeset in webkit [56468] by ap@apple.com

2 edits in trunk/JavaScriptCore

Reviewed by Geoff Garen.

wtf/FastMalloc.h: Added a using directive for fastMallocSize, like we do for all public WTF symbols. Also sorted the list alphabetically.

4:18 PM Changeset in webkit [56467] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-24 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Significant scroll speed degradation if Timeline has
an expanded record with significant number of children.
https://bugs.webkit.org/show_bug.cgi?id=36543

inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._updateBoundaries): (WebInspector.TimelinePanel.prototype._addToRecordsWindow): (WebInspector.TimelinePanel.prototype._filterRecords): (WebInspector.TimelinePanel.prototype._refreshRecords):

4:08 PM Changeset in webkit [56466] by kov@webkit.org

1 edit
1 add in trunk/WebKit/gtk/po

2010-03-24 Yuri Chornoivan <yurchor@ukr.net>

Reviewed by Gustavo Noronha.

Ukrainian translation.

uk.po: Added.

4:02 PM Changeset in webkit [56465] by kov@webkit.org

2 edits in trunk/WebCore

2010-03-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Eric Carlson.

[GStreamer] Fails to go to Loaded state because of floating point discrepancies
https://bugs.webkit.org/show_bug.cgi?id=35891

Use the m_fillStatus variable, which is more reliable, instead of
using the calculation, for the completed case.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::fillTimerFired):

4:00 PM Changeset in webkit [56464] by dimich@chromium.org

2 edits in trunk/WebCore

Unreviewed, Chromium test fix.

Recent r56445 added CustomEvent and a test but it didn't work on Chromium bots.
Test crashed due to infinte recursion because the compiler did not have the right definition of toV8(CustomEvent*)
and was substituting toV8(Event*).

Fixing test fast/events/custom-event.html

bindings/v8/custom/V8EventCustom.cpp:

3:45 PM Changeset in webkit [56463] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-24 MORITA Hajime <morrita@google.com>

Reviewed by Darin Adler.

Refactoring: HTMLFormControlElement should not have redundant null check
https://bugs.webkit.org/show_bug.cgi?id=36487

No new tests as there is no new functionality.

html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::dispatchFocusEvent): (WebCore::HTMLFormControlElement::dispatchBlurEvent):

3:22 PM Changeset in webkit [56462] by eric@webkit.org

4 edits in trunk

2010-03-24 Eric Uhrhane <ericu@chromium.org>

DOMCoreException needs NoStaticTables modifier
https://bugs.webkit.org/show_bug.cgi?id=36458

No new tests, but this shows up in tests of Database accesses from the
Worker thread that I'll be checking in soon. The symptom is that
DOMCoreException.toString() returns [object DOMException] instead of
something more helpful.

fast/workers/worker-context-multi-port-expected.txt: Adjusted expectation that was depending on the broken behavior.

2010-03-24 Eric Uhrhane <ericu@chromium.org>

Reviewed by Alexey Proskuryakov.

DOMCoreException needs NoStaticTables modifier
https://bugs.webkit.org/show_bug.cgi?id=36458

No new tests, but this shows up in tests of Database accesses from the
Worker thread that I'll be checking in soon. The symptom is that
DOMCoreException.toString() returns [object DOMException] instead of
something more helpful.

dom/DOMCoreException.idl: Added NoStaticTables.

3:05 PM Changeset in webkit [56461] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-24 Drew Wilson <atwilson@chromium.org>

Reviewed by Dmitry Titov.

Failed assertion in V8Proxy::setDOMException() if worker is shutting down.
https://bugs.webkit.org/show_bug.cgi?id=36514

Test: none (existing worker tests suffice)

bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException): Updated setDOMException() to check for an empty exception (due to no active context) and avoid throwing in that case.

2:37 PM Changeset in webkit [56460] by evan@chromium.org

7 edits in trunk

2010-03-23 Evan Martin <evan@chromium.org>

Reviewed by Dmitry Titov.

[chromium] use integral glyph widths
https://bugs.webkit.org/show_bug.cgi?id=36510

Extend a Linux Chromium layout test to also cover slight-hinted text.

platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle.html:

2010-03-23 Evan Martin <evan@chromium.org>

Reviewed by Dmitry Titov.

[chromium] use integral glyph widths
https://bugs.webkit.org/show_bug.cgi?id=36510

Despite WebKit (and Skia, to an extent) supporting non-integral
glyph widths, the font code path we hit in Skia only supports
integral glyph positions. This means that we would accumulate
offsets when drawing a sequence up non-integer-width glyphs
which would cause gaps when snapped to the pixel grid when drawing.

platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformWidthForGlyph): round glyph widths to integers.

2:16 PM Changeset in webkit [56459] by dino@apple.com

2 edits in trunk/WebCore

2010-03-24 Dean Jackson <dino@apple.com>

Reviewed by Kevin Decker.

<rdar://problem/7785305>
Fix regression caused by r55576. It turned out that ensuring
CoreAnimation always gets a correct fill parameter caused flashing
as non-filled animations ended (CA briefly showed the initial animation
value before the style system set the final value).

platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setupAnimation):

2:12 PM Changeset in webkit [56458] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-03-24 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Laszlo Gombos.

Auto-uppercase and predictive text need to be disabled for S60 (as for maemo)
https://bugs.webkit.org/show_bug.cgi?id=33176

WebCoreSupport/EditorClientQt.cpp:

2:08 PM Changeset in webkit [56457] by jam@chromium.org

5 edits
2 adds in trunk/WebKit/chromium

2010-03-24 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

[chromium]WebKit side of adding search support to Pepper.
https://bugs.webkit.org/show_bug.cgi?id=36434

WebKit.gyp:
public/WebDocument.h:
public/WebNode.h: (WebKit::WebNode::to): (WebKit::WebNode::toConst):
public/WebPluginDocument.h: Added. (WebKit::WebPluginDocument::WebPluginDocument): (WebKit::WebPluginDocument::operator=): (WebKit::WebPluginDocument::assign):
src/WebDocument.cpp: (WebKit::WebDocument::isPluginDocument):
src/WebPluginDocument.cpp: Added. (WebKit::WebPluginDocument::plugin): (WebKit::WebPluginDocument::WebPluginDocument): (WebKit::WebPluginDocument::operator=): (WebKit::WebPluginDocument::operator PassRefPtr<PluginDocument>):

1:55 PM Changeset in webkit [56456] by eric@webkit.org

5 edits in trunk

2010-03-24 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Rename QWebSettings::XSSAuditorEnabled to XSSAuditingEnabled
https://bugs.webkit.org/show_bug.cgi?id=36522

For consistency with other QWebSettings attributes.

Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
Api/qwebsettings.h:

2010-03-24 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Rename QWebSettings::XSSAuditorEnabled to XSSAuditingEnabled
https://bugs.webkit.org/show_bug.cgi?id=36522

DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setXSSAuditorEnabled): Use the new name.

1:50 PM Changeset in webkit [56455] by weinig@apple.com

2 edits in trunk/WebKitSite

Rubber-stamped by Anders Carlsson..

Update Security Group Members list.

security/security-group-members.html:

1:38 PM Changeset in webkit [56454] by eric@webkit.org

6 edits in trunk

2010-03-24 Hayato Ito <hayato@chromium.org>

Reviewed by NOBODY (Need!).

Refactor computePageRects so that Mac can make use of it.
https://bugs.webkit.org/show_bug.cgi?id=36159

Refactoring only, so no new tests.

WebCore.base.exp:
page/PrintContext.cpp: (WebCore::PrintContext::computePageRects): (WebCore::PrintContext::computePageRectsWithPageSize): (WebCore::PrintContext::computePageRectsWithPageSizeInternal): (WebCore::PrintContext::pageNumberForElement): (WebCore::PrintContext::numberOfPages):
page/PrintContext.h:

2010-03-24 Hayato Ito <hayato@chromium.org>

Reviewed by Shinichiro Hamaji.

Refactor computePageRects so that Mac can make use of it.
https://bugs.webkit.org/show_bug.cgi?id=36159

Refactoring only, so no new tests.

WebView/WebFrame.mm: (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]):

1:20 PM Changeset in webkit [56453] by eric@webkit.org

4 edits in trunk

2010-03-24 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Jeremy Orlow.

Add some diagnostics to try to track down cause of crash in ArchiveFactory::isArchiveMimeType().

https://bugs.webkit.org/show_bug.cgi?id=36426

No new tests as there is no new functionality.

loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument): Make copy of mimeType string to isolate crash.

2010-03-24 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Jeremy Orlow.

Add some diagnostics to try to track down cause of crash in ArchiveFactory::isArchiveMimeType().

https://bugs.webkit.org/show_bug.cgi?id=36426

src/ResourceHandle.cpp: Track state across ResourceHandle invocations. (WebCore::ResourceHandleInternal::ResourceHandleInternal): (WebCore::ResourceHandleInternal::): (WebCore::ResourceHandleInternal::start): (WebCore::ResourceHandleInternal::cancel): (WebCore::ResourceHandleInternal::didReceiveResponse): (WebCore::ResourceHandleInternal::didReceiveData): (WebCore::ResourceHandleInternal::didFinishLoading): (WebCore::ResourceHandleInternal::didFail):

1:02 PM Changeset in webkit [56452] by eric@webkit.org

4 edits in trunk/WebCore

2010-03-24 Anton Muhin <antonm@chromium.org>

Reviewed by Nate Chapin.

Use newly introduced SetPrototype method to deal with global objects.
https://bugs.webkit.org/show_bug.cgi?id=36497

No new tests, should be covered by the current test infrastructure.

bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::installDOMWindow):
bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructor):
bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):

12:23 PM Changeset in webkit [56451] by dimich@chromium.org

2 edits in trunk/WebCore

Unreviewed, Chromium build fix.

platform/chromium/PopupMenuChromium.cpp:

(WebCore::PopupContainer::PopupContainer): Fix order of initializers.
(WebCore::PopupContainer::layout): Remove unused variable.

12:05 PM Changeset in webkit [56450] by kenneth@webkit.org

7 edits in trunk

WebCore: Add a way to check if the page client is making use of
a QWidget.

Reviewed by Simon Hausmann.

platform/qt/QWebPageClient.h:

(QWebPageClient::isQWidgetClient):

WebKit/qt: Calling setView on a QWebPage being shown by a QGraphicsWebView,
would uninstall the page client, resulting in not expected
behaviour.

Reviewed by Simon Hausmann.

Api/qwebpage.cpp:

(QWebPageWidgetClient::QWebPageWidgetClient):
(QWebPageWidgetClient::isQWidgetClient):
(QWebPageWidgetClient::screenNumber):
(QWebPage::QWebPage):
(QWebPage::setView):

11:41 AM Changeset in webkit [56449] by eric@webkit.org

10 edits in trunk

2010-03-24 Jay Campan <jcampan@google.com>

Reviewed by Darin Fisher.

Making Chromium select popups not steal activation from the browser.
Select popups are now like autocomplete popups, shown in non-activated
windows.
https://bugs.webkit.org/show_bug.cgi?id=36062

page/chromium/ChromeClientChromium.h:
platform/chromium/PopupMenuChromium.cpp: (WebCore::): (WebCore::PopupListBox::setMaxHeight): (WebCore::PopupListBox::disconnectClient): (WebCore::PopupListBox::PopupListBox): (WebCore::PopupContainer::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::showExternal): (WebCore::PopupContainer::hidePopup): (WebCore::PopupContainer::layout): (WebCore::PopupContainer::chromeClientChromium): (WebCore::PopupListBox::hidePopup): (WebCore::PopupListBox::layout): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show):
platform/chromium/PopupMenuChromium.h: (WebCore::PopupItem::): (WebCore::PopupItem::PopupItem): (WebCore::PopupContainerSettings::): (WebCore::PopupContainer::): (WebCore::PopupContainer::listBox): (WebCore::PopupContainer::popupType):

2010-03-24 Jay Campan <jcampan@google.com>

Reviewed by Darin Fisher.

Making Chromium select popups not steal activation from the browser.
Select popups are now like autocomplete popups, shown in non-activated
windows.
https://bugs.webkit.org/show_bug.cgi?id=36062

public/WebViewClient.h: (WebKit::WebViewClient::createPopupMenu):
src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::popupOpened): (WebKit::ChromeClientImpl::popupClosed):
src/ChromeClientImpl.h:
src/WebViewImpl.cpp: (WebKit::): (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::selectPopupHandleKeyEvent): (WebKit::WebViewImpl::hideSelectPopup): (WebKit::WebViewImpl::popupOpened): (WebKit::WebViewImpl::popupClosed): (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::applyAutoFillSuggestions): (WebKit::WebViewImpl::applyAutocompleteSuggestions):
src/WebViewImpl.h:

11:11 AM Changeset in webkit [56448] by apavlov@chromium.org

2 edits in trunk/WebKit/chromium

2010-03-24 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Audits never complete
https://bugs.webkit.org/show_bug.cgi?id=36544

src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):

10:50 AM Changeset in webkit [56447] by levin@chromium.org

8 edits in trunk/WebCore

Need to move items that CanvasRenderingContext2D depends on into CanvasSurface.
https://bugs.webkit.org/show_bug.cgi?id=35453

Reviewed by Oliver Hunt.

Prepartory changes to allow for an OffscreenCanvas which may be used in a worker
or outside of the DOM.

No change in functionality, so new tests.

dom/CanvasSurface.cpp: Moved functionality that CanvasRenderingContext2D depends on

into this class (and removed dependencies on document/html element).
(WebCore::CanvasSurface::CanvasSurface):
(WebCore::CanvasSurface::~CanvasSurface): Put the desctructor in the cpp file
to avoid needing access to ~ImageBuffer in the header file.
(WebCore::CanvasSurface::setSurfaceSize): Does basic items needed
when the size changes. It is protected to force outside callers to go
through HTMLCanvasElement::setSize.
(WebCore::CanvasSurface::toDataURL): Just moved from HTMLCanvasElement and
made a note about a method to fix for worker usage.
(WebCore::CanvasSurface::willDraw): Made this virtual to allow an overide
which uses the renderbox and tracks a dirtyRect.
(WebCore::CanvasSurface::convertLogicalToDevice): Moved and changed to
rely on a member variable for page scale (to avoid using the document).
(WebCore::CanvasSurface::createImageBuffer):
(WebCore::CanvasSurface::drawingContext): Simple move from HTMLCanvasElement.
(WebCore::CanvasSurface::buffer): Ditto.
(WebCore::CanvasSurface::baseTransform): Ditto.

dom/CanvasSurface.h:

(WebCore::CanvasSurface::width): Simple move from HTMLCanvasElement.
(WebCore::CanvasSurface::height): Ditto.
(WebCore::CanvasSurface::size): Ditto.
(WebCore::CanvasSurface::setOriginTainted): Ditto.
(WebCore::CanvasSurface::originClean): Ditto.
(WebCore::CanvasSurface::hasCreatedImageBuffer): Ditto (with small name change).

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::HTMLCanvasElement): Pass in the scale factor to CanvasSurface
so it doesn't need the document.
(WebCore::HTMLCanvasElement::willDraw): Moved the relevant portion to CanvasSurface.
(WebCore::HTMLCanvasElement::reset): Small changes due to refactoring.
(WebCore::HTMLCanvasElement::paint): Ditto.

html/HTMLCanvasElement.h:

(WebCore::HTMLCanvasElement::setSize): Ditto.

platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding): Added assert
to verify that this is only called on the main thread.

platform/graphics/Image.cpp:

(WebCore::Image::nullImage): Ditto.

platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::utiFromMIMEType): Ditto.

10:21 AM Changeset in webkit [56446] by apavlov@chromium.org

6 edits in trunk

2010-03-24 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Inspector: XML Tags should not be converted to lowercase
https://bugs.webkit.org/show_bug.cgi?id=28600

LayoutTests:

inspector/elements-panel-xhtml-structure-expected.txt:
inspector/elements-panel-xhtml-structure.xhtml:

WebCore:

inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateBreadcrumb): (WebInspector.ElementsPanel.prototype.decorateNodeLabel):
inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.nodeNameToCorrectCase): (WebInspector.ElementsTreeElement.prototype._updateChildren): (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):

10:15 AM Changeset in webkit [56445] by kenneth@webkit.org

17 edits
5 adds in trunk

WebCore: Add support for DOM Level 3 Custom Event
http://www.w3.org/TR/DOM-Level-3-Events

Reviewed by Antti Koivisto.

Test: fast/events/custom-event.html

DerivedSources.cpp:
GNUmakefile.am:
WebCore.gypi:
WebCore.pri:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSEventCustom.cpp:

(WebCore::toJS):

bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/CodeGeneratorV8.pm:
dom/CustomEvent.cpp: Added.

(WebCore::CustomEvent::CustomEvent):
(WebCore::CustomEvent::initCustomEvent):
(WebCore::CustomEvent::isCustomEvent):

dom/CustomEvent.h: Added.

(WebCore::CustomEvent::create):
(WebCore::CustomEvent::detail):

dom/Document.cpp:

(WebCore::Document::createEvent):

dom/Event.cpp:

(WebCore::Event::isCustomEvent):

dom/Event.h:

LayoutTests: Layout test for DOM Level 3 Custom Event
http://www.w3.org/TR/DOM-Level-3-Events

Reviewed by Antti Koivisto.

fast/events/custom-event-expected.txt: Added.
fast/events/custom-event.html: Added.

9:56 AM Changeset in webkit [56444] by apavlov@chromium.org

4 edits in trunk/WebCore

2010-03-24 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Error when highlighting JavaScript with an invalid mime type
https://bugs.webkit.org/show_bug.cgi?id=36530

inspector/front-end/SourceTokenizer.js: (WebInspector.SourceTokenizer.Registry):
inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._contentLoaded): (WebInspector.SourceView.prototype._canonicalMimeType):
inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter):

9:33 AM QtWebKitBackportingFixes edited by Simon Hausmann

(diff)

9:28 AM QtWebKitRelease20 edited by Simon Hausmann

(diff)

9:25 AM Changeset in webkit [56443] by pfeldman@chromium.org

2 edits in trunk/WebCore

2010-03-24 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Chromium test fix: added a frameCount check to the
debugger function call.

bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::createUtilityContext):

8:47 AM Changeset in webkit [56442] by apavlov@chromium.org

2 edits in trunk/WebKit/chromium

2010-03-24 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Fix VKEY_F10, VKEY_F11 translation in WebInputEvent.cpp
https://bugs.webkit.org/show_bug.cgi?id=36524

src/WebInputEvent.cpp: (WebKit::staticKeyIdentifiers):

8:18 AM Porting Macros plan edited by efidler@rim.com

(diff)

7:11 AM Changeset in webkit [56441] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

Rubber-stamped by Simon Hausmann and Gustavo Noronha Silva.

[Qt][GTK] http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html fails after r56394
https://bugs.webkit.org/show_bug.cgi?id=36531

platform/gtk/Skipped: http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html skipped until fix.
platform/qt/Skipped: http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html skipped until fix.

6:25 AM QtWebKitBugs edited by vestbo@webkit.org

(diff)

6:21 AM ImprovingLifeOnWindows edited by Adam Roben

Removed section about detecting a missing Platform SDK. We now do this … (diff)

4:07 AM Changeset in webkit [56440] by Simon Hausmann

2 edits in trunk/WebCore

[Qt] Support for QT_LIBINFIX in Symbian builds

Patch by Miikka Heikkinen <miikka.heikkinen@digia.com> on 2010-03-19
Reviewed by Simon Hausmann.

Configuring Qt with -qtlibinfix parameter will enable installing
an alternate version of Qt on devices that already have it on ROM.
This patch provides support for infixed builds of Webkit.

WebCore.pro:

2:36 AM Changeset in webkit [56439] by tkent@chromium.org

36 edits in trunk

2010-03-24 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Make Icon::createIconForFiles() optional.
https://bugs.webkit.org/show_bug.cgi?id=35072

r54923 made Icon::createIconForFiles() deprecated. However moving
existing icon loading code to outside of WebCore is not good. So,
we assume:

ChromeClient::chooseIconForFiles(), renamed from iconForFiles(), is the primary API to load icons.
Icon::createIconForFiles() is an optional API to help implementing ChromeClient::iconForFiles().

This patch removes a call to Icon::createIconForFiles() from
FileChooser::loadIcon(), and ChromeClient::chooseIconForFiles() of
non-Chromium ports calls Icon::createIconForFiles().

WebCore.base.exp: Export FileChooser::iconLoaded(), Icon::createIconForFiles(), and Icon::~Icon().
WebCore.xcodeproj/project.pbxproj: Export Icon.h
loader/EmptyClient.h: Rename iconForFiles() to chooseIconForFiles().
page/Chrome.cpp: ditto.
page/Chrome.h: ditto.
page/ChromeClient.h: ditto.
platform/FileChooser.cpp: (WebCore::FileChooser::loadIcon):
platform/graphics/Icon.h: Remove a comment on createIconForFiles().
platform/graphics/chromium/IconChromiumLinux.cpp: Remove createIconForFiles().
platform/graphics/chromium/IconChromiumMac.cpp: ditto.
platform/graphics/chromium/IconChromiumWin.cpp: ditto.
rendering/RenderFileUploadControl.cpp: Rename iconForFiles() to chooseIconForFiles().
rendering/RenderFileUploadControl.h: ditto.

2010-03-24 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Make Icon::createIconForFiles() optional.
https://bugs.webkit.org/show_bug.cgi?id=35072

Rename iconForFiles() to chooseIconForFiles().
Call Icon::createIconForFiles() from chooseIconForFiles().

src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::chooseIconForFiles):
src/ChromeClientImpl.h:

2010-03-24 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Make Icon::createIconForFiles() optional.
https://bugs.webkit.org/show_bug.cgi?id=35072

Rename iconForFiles() to chooseIconForFiles().
Call Icon::createIconForFiles() from chooseIconForFiles().

WebCoreSupport/ChromeClientGtk.cpp:
WebCoreSupport/ChromeClientGtk.h:

2010-03-24 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Make Icon::createIconForFiles() optional.
https://bugs.webkit.org/show_bug.cgi?id=35072

Rename iconForFiles() to chooseIconForFiles().
Call Icon::createIconForFiles() from chooseIconForFiles().

WebCoreSupport/ChromeClientHaiku.cpp: (WebCore::ChromeClientHaiku::chooseIconForFiles):
WebCoreSupport/ChromeClientHaiku.h:

2010-03-24 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Make Icon::createIconForFiles() optional.
https://bugs.webkit.org/show_bug.cgi?id=35072

Rename iconForFiles() to chooseIconForFiles().
Call Icon::createIconForFiles() from chooseIconForFiles().

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm: (WebChromeClient::chooseIconForFiles):

2010-03-24 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Make Icon::createIconForFiles() optional.
https://bugs.webkit.org/show_bug.cgi?id=35072

Rename iconForFiles() to chooseIconForFiles().
Call Icon::createIconForFiles() from chooseIconForFiles().

WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::chooseIconForFiles):
WebCoreSupport/ChromeClientQt.h:

2010-03-24 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Make Icon::createIconForFiles() optional.
https://bugs.webkit.org/show_bug.cgi?id=35072

Rename iconForFiles() to chooseIconForFiles().
Call Icon::createIconForFiles() from chooseIconForFiles().

WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::chooseIconForFiles):
WebCoreSupport/WebChromeClient.h:

2010-03-24 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Make Icon::createIconForFiles() optional.
https://bugs.webkit.org/show_bug.cgi?id=35072

Rename iconForFiles() to chooseIconForFiles().
Call Icon::createIconForFiles() from chooseIconForFiles().

WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::chooseIconForFiles):
WebKitSupport/ChromeClientWx.h:

1:43 AM QtWebKitFeaturePlanning edited by Henry Haverinen

(diff)

1:36 AM QtWebKitFeaturePlanning created by Henry Haverinen

1:35 AM Changeset in webkit [56438] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

Bug 36519 - JSGlobalContextRelease is unnecessarily slow

Reviewed by Oliver Hunt.

Since [ http://trac.webkit.org/changeset/35917 ], calling
JSGlobalContextRelease always triggers a GC heap collection
(if not a full destroy). As per 35917's changelog "This is
only really necessary when the (JSGlobalObject's) last
reference is released, but there is no way to determine that,
and no harm in collecting slightly more often."

Well, we now know of cases of API clients who are harmed by
the performance penalty of collecting too often, so it's time
to add a way to determine whether a call to JSGlobalContextRelease
is removing the last protect from it's global object. If further
protects are retaining the global object (likely from other
JSGlobalContextRefs), then don't trigger a GC collection.

API/JSContextRef.cpp:
runtime/Collector.cpp:

(JSC::Heap::unprotect): return a boolean indicating that the value is now unprotected.

runtime/Collector.h:
wtf/HashCountedSet.h:

(WTF::::remove): return a boolean indicating whether the value was removed from the set.

12:50 AM Changeset in webkit [56437] by Chris Jerdonek

6 edits in trunk/WebKitTools

Added to check-webkit-style support for a --debug flag.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=36100

The --debug flag adjusts the logging level to DEBUG and
includes the logger name and level in each log message.

Scripts/check-webkit-style:
- Changed the code to check for the --debug flag and pass the result to the configure_logging() method.
Scripts/webkitpy/style/checker.py:
- Added an is_debug parameter to configure_logging().
- Refactored configure_logging() by adding calls to the following two methods: _create_log_handlers() and _create_debug_log_handlers().
Scripts/webkitpy/style/checker_unittest.py:
- Added unit tests for configure_logging() with is_debug True by splitting the ConfigureLoggingTest class into ConfigureLoggingTest and ConfigureLoggingTestBase, and adding ConfigureLoggingDebugTest.
Scripts/webkitpy/style/optparser.py:
- Updated the usage string.
- Added an is_debug data attribute to the CommandOptionValues class.
- Added support for the --debug flag to the ArgumentParser.parse() method.
- Also added extra error information to the parse() method in the case of an invalid flag.
Scripts/webkitpy/style/optparser_unittest.py:
- Updated the unit tests as necessary.
- Also fixed an issue with the CommandOptionValuesTest.test_eq() unit test.

12:46 AM Changeset in webkit [56436] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

Bug 36519 - JSGlobalContextRelease is unnecessarily slow

Reviewed by Oliver Hunt.

API/JSContextRef.cpp:
runtime/Collector.cpp:

(JSC::Heap::unprotect): return a boolean indicating that the value is now unprotected.

runtime/Collector.h:
wtf/HashCountedSet.h:

(WTF::::remove): return a boolean indicating whether the value was removed from the set.

12:42 AM QtWebKit edited by Henry Haverinen

(diff)

12:11 AM Changeset in webkit [56435] by barraclough@apple.com

5 edits in trunk/JavaScriptCore

Bug 36519 - JSGlobalContextRelease is unnecessarily slow

Reviewed by Oliver Hunt.

API/JSContextRef.cpp:
runtime/Collector.cpp:

(JSC::Heap::unprotect): return a boolean indicating that the value is now unprotected.

runtime/Collector.h:
wtf/HashCountedSet.h:

(WTF::::remove): return a boolean indicating whether the value was removed from the set.

Mar 23, 2010:

10:55 PM Changeset in webkit [56434] by tkent@chromium.org

1 edit
3 adds in trunk/WebKitTools

2010-03-23 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add TestNavigationController and TestWebWorker
https://bugs.webkit.org/show_bug.cgi?id=36489

Add TestNavigationController and TestWebWorker classes, which are
going to be used by DumpRenderTree Chromium port. These files are
based on:

src/webkit/tools/test_shell/test_navigation_controller.{cc,h}
src/webkit/tools/test_shell/test_web_worker.h of Chromium rev.40492.

TestNavigationController has non-style changes.

Change ContentState type: binary string -> WebHistoryItem
Remove TestShell dependency by introducing NavigationHost interface.

DumpRenderTree/chromium/TestNavigationController.cpp: Added.
DumpRenderTree/chromium/TestNavigationController.h: Added.
DumpRenderTree/chromium/TestWebWorker.h: Added.

9:27 PM Changeset in webkit [56433] by ap@apple.com

2 edits in trunk/LayoutTests

Skip plugins/destroy-plugin-from-callback.html, which has been failing on SL bots since it
was added in r56338.

platform/mac-snowleopard/Skipped:

8:17 PM Changeset in webkit [56432] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

Build fix.

runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncSplice): Some versions of GCC emit a warning about the implicit 64- to 32-bit truncation
that takes place here. An explicit cast is sufficient to silence it.

5:31 PM Changeset in webkit [56431] by mitz@apple.com

2 edits in trunk/WebKit/mac

Reverted accidental change from r56429.

WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::getCustomMenuFromDefaultItems):

5:29 PM Changeset in webkit [56430] by mitz@apple.com

2 edits in trunk/WebCore

Fixed typos.

manual-tests/plugin-visible-rect-change.html:

5:27 PM Changeset in webkit [56429] by mitz@apple.com

12 edits
1 add in trunk

WebCore: WebCore part of
<rdar://problem/7197736> Plug-in clip rect does not update when overflow
clip changes
https://bugs.webkit.org/show_bug.cgi?id=36479.

Reviewed by John Sullivan.

manual-tests/plugin-visible-rect-change.html: Added.
platform/mac/WidgetMac.mm:

(WebCore::WidgetPrivate::WidgetPrivate): Added previousVisibleRect.
(WebCore::Widget::setFrameRect): If the visible rect changed but the
frame rect did not, send a -visibleRectDidChange message to the view,
if it responds to it.
(WebCore::Widget::releasePlatformWidget): Reset previousVisibleRect.

rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setWidgetGeometry): Track changes to the clip rect
imposed by the enclosing layer. Call Widget::setFrameRect when it changes,
even if the frame rect did not.

rendering/RenderWidget.h:

(WebCore::RenderWidget::windowClipRect): Added this accessor.

WebKit/mac: WebKit part of
<rdar://problem/7197736> Plug-in clip rect does not update when overflow
clip changes
https://bugs.webkit.org/show_bug.cgi?id=36479.

Reviewed by John Sullivan.

Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView visibleRectDidChange]): Added. Calls
WKSyncSurfaceToView().

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView _windowClipRect]): Changed to use Widget::windowClipRect().
(-[WebBaseNetscapePluginView visibleRectDidChange]): Added. Invokes -renewGState.

WebKitLibraries: WebKitSystemInterface part of
<rdar://problem/7197736> Plug-in clip rect does not update when overflow
clip changes
https://bugs.webkit.org/show_bug.cgi?id=36479.

Reviewed by John Sullivan.

WebKitSystemInterface.h: Added WKSyncSurfaceToView().
libWebKitSystemInterfaceSnowLeopard.a: Updated

5:06 PM Changeset in webkit [56428] by Simon Fraser

3 edits
2 adds in trunk

2010-03-23 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Assertion ASSERTION FAILED: rootLayer == m_clipRectsRoot at hulu.com
https://bugs.webkit.org/show_bug.cgi?id=34065

Fix another cause of assertions related to the clip rects root. Embeds
with zero size caused the overlap testing to fail, yet we require them to work
for correct compositing, so when the composited bounds is empty, use a 1x1 rect
for overlap testing.

Test: compositing/geometry/empty-embed-rects.html

rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::addToOverlapMap): (WebCore::RenderLayerCompositor::computeCompositingRequirements):

4:31 PM Changeset in webkit [56427] by ap@apple.com

2 edits in trunk/JavaScriptCore

Build fix.

runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice): Fixed a typo - length doesn't need to be converted with toInteger().

4:28 PM Changeset in webkit [56426] by kbr@google.com

2 edits in trunk/WebKit/chromium

2010-03-23 Kenneth Russell <kbr@google.com>

Unreviewed build fix.

Add #include <stdio.h> to fix Chromium Linux build.

src/WebGraphicsContext3DDefaultImpl.cpp:

4:12 PM Changeset in webkit [56425] by ap@apple.com

3 edits
3 adds in trunk

Reviewed by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=36511
<rdar://problem/7753498> Safari freezes when using SPUTNIK JavaScript conformance check

Test: fast/js/sputnik-S15.4.4.12_A3_T3.html

runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice): We were incorrectly computing the start offset, and iterated over (almost) all integers. Note that this can be fixed without using doubles, but the code would be much more complicated, and there is no important reason to stick to integers here.

3:57 PM Changeset in webkit [56424] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-03-23 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

QGraphicsWebView crash when calling setView on the QWebPage...
https://bugs.webkit.org/show_bug.cgi?id=36436

Checking for pageClient existance before showing popups.

WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::show):

3:40 PM Changeset in webkit [56423] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-03-23 Anders Bakken <anders.bakken@nokia.com>, Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Check if q->scene() is available before actually using it
on QGraphicsWebViewPrivate.

QGraphicsWebView crash
https://bugs.webkit.org/show_bug.cgi?id=32670

Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::screenNumber): (QGraphicsWebViewPrivate::ownerWidget):

3:27 PM Changeset in webkit [56422] by levin@chromium.org

3 edits
2 adds in trunk

[chromium] XMLHttpRequest.send sends 'undefined' string when passed undefined value.
https://bugs.webkit.org/show_bug.cgi?id=36506

Reviewed by Nate Chapin.

WebCore:

Test: http/tests/xmlhttprequest/send-undefined-and-null.html

bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::isDocumentType): Unrelated style fix: fixed the casing of the method.
(WebCore::V8XMLHttpRequest::sendCallback): Added check for null/undefined to do the send.
This mirrors what is done in the JSC bindings. Previously, sending 'null' worked because
the last case, which did "toWebCoreStringWithNullCheck", resulted in sending an empty
request body.

LayoutTests:

Added a test to verify that sending either undefined and null both result in an empty request body.

http/tests/xmlhttprequest/send-undefined-and-null-expected.txt: Added.
http/tests/xmlhttprequest/send-undefined-and-null.html: Added.

3:24 PM Changeset in webkit [56421] by eric@webkit.org

5 edits in trunk/WebKitTools

2010-03-23 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add support for revision -> build lookup in buildbot.py and layout test result parsing
https://bugs.webkit.org/show_bug.cgi?id=36474

Scripts/webkitpy/bugzilla_unittest.py: Added a FIXME about sharing code.
Scripts/webkitpy/buildbot.py:
- Add support for looking up builds by revision number.
- Add support for fetching and parsing results.html files from buildbot.
- build_for_revision has an allow_failed_lookups option to work around the fact that our buildbot's xmlrpc calls return failure on old revision numbers.
- Add parsing support for twisted directory listings.
Scripts/webkitpy/buildbot_unittest.py:
- Unit test all the new code.
Scripts/webkitpy/commands/queries.py:
- Add a new results-for command which prints all the results for a given revision (very slow due to slow revision lookup)

3:07 PM Changeset in webkit [56420] by Dimitri Glazkov

3 edits
3 adds in trunk

WebCore: Fix hard-to-see crash due to incorrect libxml API usage.

Patch by Chris Evans <cevans@chromium.org> on 2010-03-23
Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36000

Test: fast/text/bad-encoding.html

dom/XMLTokenizerLibxml2.cpp:

(WebCore::XMLTokenizer::doEnd): Avoid operations on a closed context.

LayoutTests: Add test for crash due to calling into libxml in invalid state. Note
that it is unlikely that this will actually crash for you in the test
environment because it is highly intermittent. However, adding test in
order to exercise the code path and prevent related regression.
See https://bugs.webkit.org/show_bug.cgi?id=36000

Patch by Chris Evans <cevans@chromium.org> on 2010-03-23
Reviewed by Darin Adler.

fast/text/bad-encoding.html: Added.
fast/text/bad-encoding-expected.txt: Added.
fast/text/resources/bad-encoding.xml: Added.

2:47 PM Changeset in webkit [56419] by dbates@webkit.org

2 edits in trunk/WebKitTools

2010-03-23 Daniel Bates <dbates@rim.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=36048

Detect if the Windows Platform SDK is missing when building with
Visual C++ Express Edition and inform the user to download it.

Scripts/webkitdirs.pm:

2:38 PM Changeset in webkit [56418] by Nate Chapin

2 edits in trunk/LayoutTests

2010-03-23 Nate Chapin <Nate Chapin>

Unreviewed, Chromium test expectations update.

Mark fast/dom/error-to-string-stack-overflow.html as failing on
all Chromium platforms, and http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html
as failing on Windows.

platform/chromium/test_expectations.txt:

2:33 PM Changeset in webkit [56417] by Darin Adler

3 edits in trunk/WebKitTools

Tell Subversion about more directories that expect to have .pyc files.

Scripts/webkitpy: Modified property svn:ignore.
Scripts/webkitpy/irc: Added property svn:ignore.

2:24 PM Changeset in webkit [56416] by Nate Chapin

10 edits in trunk

2010-03-23 Nate Chapin <Nate Chapin>

Unreviewed, revert r56376.

This revision introduced a crash in a couple of layout tests
on Chromium Linux.

page/chromium/ChromeClientChromium.h:
platform/chromium/PopupMenuChromium.cpp: (WebCore::): (WebCore::PopupContainer::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::showExternal): (WebCore::PopupContainer::hidePopup): (WebCore::PopupMenu::show):
platform/chromium/PopupMenuChromium.h: (WebCore::PopupItem::): (WebCore::PopupItem::PopupItem): (WebCore::PopupContainerSettings::): (WebCore::PopupContainer::listBox):

2:15 PM Changeset in webkit [56415] by eric@webkit.org

5 edits in trunk/WebKit/chromium

2010-03-23 Sergey Ulanov <sergeyu@chromium.org>

Reviewed by Dmitry Titov.

Changes needed to implement Show/Hide Controls command for <video> in
chrome: (1) added Controls action in WebMediaPlayerAction that toggles
controls for media player, (2) added MediaHasVideo in
WebContextMenuData so that controls can be made toggleable only for
video player but not for audio.
https://bugs.webkit.org/show_bug.cgi?id=36460

public/WebContextMenuData.h: (WebKit::WebContextMenuData::):
public/WebMediaPlayerAction.h: (WebKit::WebMediaPlayerAction::):
src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
src/WebViewImpl.cpp: (WebKit::WebViewImpl::performMediaPlayerAction):

1:52 PM Changeset in webkit [56414] by hyatt@apple.com

3 edits
2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=36272, make sure nth-child can work when the portion with "n" is omitted.

Reviewed by Simon Fraser and Darin Adler.

Added fast/css/nth-child-implied-step.html

css/CSSGrammar.y:
css/tokenizer.flex:

1:51 PM Changeset in webkit [56413] by dbates@webkit.org

2 edits in trunk/WebKitTools

2010-03-23 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36149

Import the GNU readline interface to modify the behavior
of raw_input so as to provide line editing support. In
particular this will prevent "delete" characters from
appearing in the returned value for function raw_input.

Scripts/webkitpy/user.py:

1:48 PM Changeset in webkit [56412] by Darin Adler

10 edits in trunk/WebCore

2010-03-23 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Reduce and straighten internal use of DOMImplementation
https://bugs.webkit.org/show_bug.cgi?id=36501

WebCore.xcodeproj/project.pbxproj: Xcode decided to re-sort this file.

dom/Clipboard.cpp: Removed unneeded include of DOMImplementation.h.

dom/DOMImplementation.cpp: Removed unneeded createDocument and createHTMLDocument functions. These should be done directly instead of involving the DOMImplementation class.
dom/DOMImplementation.h: Ditto.

dom/DocumentType.cpp: Removed unneeded include of DOMImplementation.h.

html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createTokenizer): Don't allocate a DOMImplementation object just to use a class member function.

loader/CachedFont.cpp: Removed unneeded include of DOMImplementation.h.

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML): Use Document::create to create a new document instead of involving DOMImplementation.
xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): Ditto. And in the case where we do need to call DOMImplementation to interpret the MIME type, don't allocate a DOMImplementation object just to use a class member function.

1:06 PM Changeset in webkit [56411] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-23 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Maemo5 theme - all <select> elements should be rendered as menu lists.
https://bugs.webkit.org/show_bug.cgi?id=36367

Enabling NO_LISTBOX_RENDERING in WebCore.pri for Maemo5.

WebCore.pri:

12:39 PM Changeset in webkit [56410] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2010-03-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

When uncaught exception happens reveal Scripts panel only if reporting uncaught exceptions is on.

https://bugs.webkit.org/show_bug.cgi?id=36498

src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.handleExceptionEvent_):

12:37 PM Changeset in webkit [56409] by Joseph Pecoraro

1 edit in trunk/WebCore/ChangeLog

Revert accidental ChangeLog commit r56407.

12:23 PM Changeset in webkit [56408] by Joseph Pecoraro

3 edits in trunk/WebCore

2010-03-22 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Upstream iPhone KeyEvent platform code and share with Mac platform
https://bugs.webkit.org/show_bug.cgi?id=35870

platform/iphone/KeyEventCodesIPhone.h: Improper comment for #endif.
platform/iphone/KeyEventIPhone.mm: Fixed headers.

12:23 PM Changeset in webkit [56407] by Joseph Pecoraro

1 edit in trunk/WebCore/ChangeLog

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=36328

rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): Fix a find/repalce mistake from my earlier patch. Rename m_setShowsMissingPluginIndicator -> m_showsMissingPluginIndicator. (WebCore::RenderEmbeddedObject::updateWidget): Don't update the widget if we're showing the missing plug-in indicator. (WebCore::RenderEmbeddedObject::paint):Fix a find/repalce mistake from my earlier patch. Rename m_setShowsMissingPluginIndicator -> m_showsMissingPluginIndicator. (WebCore::RenderEmbeddedObject::paintReplaced): Ditto.
rendering/RenderEmbeddedObject.h: Ditto. (WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator): Ditto. (WebCore::RenderEmbeddedObject::showsMissingPluginIndicator): Ditto.

Plugins/WebNetscapePluginView.mm:
Plugins/WebNullPluginView.h: Removed.
Plugins/WebNullPluginView.mm: Removed.
Resources/nullplugin.tiff: Removed.
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Invoke the resource load delegate if the plug-in failed to load.

12:22 PM Changeset in webkit [56406] by eric@webkit.org

2 edits in trunk/WebKit/chromium

2010-03-23 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: TimelinePanel stays in the recording state after reopening WebInspector.
https://bugs.webkit.org/show_bug.cgi?id=36503

src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::detach):

11:51 AM Changeset in webkit [56405] by hyatt@apple.com

2 edits
2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=36277, make sure nth-child supports the positive unary prefix (+) as well as the negative
one (-).

Reviewed by Jeremy Orlow.

Added fast/css/nth-child-unary-prefix.html

css/tokenizer.flex:

11:49 AM Changeset in webkit [56404] by eric@webkit.org

15 edits in trunk/WebCore

2010-03-23 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Dmitry Titov.

Change notification sent to inspector frontend on workers creation / destruction
to be posted asynchronously to avoid JS reenterability problems. Also, renamed
willDestroyWorker to didDestroyWorker to reflect that it gets called later and got
rid of explicit IDs for workers (use addresses instead).
https://bugs.webkit.org/show_bug.cgi?id=36213

inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::didDestroyWorker):
inspector/InjectedScriptHost.h:
inspector/InjectedScriptHost.idl:
inspector/InspectorController.cpp: (WebCore::PostWorkerNotificationToFrontendTask::create): (WebCore::PostWorkerNotificationToFrontendTask::PostWorkerNotificationToFrontendTask): (WebCore::PostWorkerNotificationToFrontendTask::performTask): (WebCore::InspectorController::postWorkerNotificationToFrontend): (WebCore::InspectorController::didCreateWorker): (WebCore::InspectorController::didDestroyWorker):
inspector/InspectorController.h: (WebCore::InspectorController::):
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didDestroyWorker):
inspector/InspectorFrontend.h:
inspector/InspectorWorkerResource.h: (WebCore::InspectorWorkerResource::create): (WebCore::InspectorWorkerResource::id): (WebCore::InspectorWorkerResource::InspectorWorkerResource):
inspector/front-end/InjectedFakeWorker.js: (InjectedFakeWorker.FakeWorker.prototype.terminate):
inspector/front-end/WorkersSidebarPane.js: (WebInspector.didDestroyWorker):
workers/AbstractWorker.cpp: (WebCore::AbstractWorker::AbstractWorker): (WebCore::AbstractWorker::onDestroyWorker):
workers/AbstractWorker.h: (WebCore::AbstractWorker::asID):
workers/SharedWorker.cpp: (WebCore::SharedWorker::SharedWorker):
workers/Worker.cpp: (WebCore::Worker::Worker):

11:30 AM Changeset in webkit [56403] by eric@webkit.org

2 edits in trunk/JavaScriptCore

2010-03-23 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

Fix compilation on Itanium in 32-bit mode
https://bugs.webkit.org/show_bug.cgi?id=36494

wtf/Platform.h: Introduce CPU(IA64_32). Don't define WTF_USE_JSVALUE64 if the CPU is in 32-bit mode.

10:53 AM Changeset in webkit [56402] by hyatt@apple.com

15 edits
2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=36266, support DOM Level 3 focusin/focusout events. Add support for
IE onfocusin/onfocusout extensions to HTML. The old DOM level 2 names (DOMFocusIn/DOMFocusOut are still supported).

Reviewed by Sam Weinig.

Added fast/events/focusinout.html

dom/Document.cpp:

(WebCore::Document::setFocusedNode):

dom/Event.cpp:

(WebCore::Event::aliasedType):
(WebCore::Event::hasAliasedType):

dom/Event.h:
dom/EventNames.h:
dom/EventTarget.cpp:

(WebCore::EventTarget::fireEventListeners):

dom/EventTarget.h:
dom/Node.cpp:

(WebCore::Node::dispatchUIEvent):

html/HTMLAttributeNames.in:
html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::parseMappedAttribute):

html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):

html/HTMLFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::parseMappedAttribute):

html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::parseMappedAttribute):

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::parseMappedAttribute):

svg/SVGElement.cpp:

(WebCore::SVGElement::parseMappedAttribute):

10:36 AM QtWebKit edited by kenneth@webkit.org

(diff)

10:30 AM QtWebKitBackportingFixes edited by siddharth.mathur@nokia.com

Moved r56370 to Incoming list (diff)

10:10 AM Changeset in webkit [56401] by eric@webkit.org

3 edits
2 adds in trunk

2010-03-23 MORITA Hajime <morrita@google.com>

Reviewed by Alexey Proskuryakov.

WebCore::SelectionController::setSelection NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=31545

svg/dom/frame-related-api-during-load-expected.txt: Added.
svg/dom/frame-related-api-during-load.html: Added.

2010-03-23 MORITA Hajime <morrita@google.com>

Reviewed by Alexey Proskuryakov.

WebCore::SelectionController::setSelection NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=31545

Added missing NULL-check that other APIs have.

Test: svg/dom/frame-related-api-during-load.html

svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::deselectAll):

10:09 AM Changeset in webkit [56400] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

Interpreter fix for <rdar://problem/7728196> REGRESSION (r46701): -(-2147483648)
evaluates to -2147483648 on 32 bit (35842)

Reviewed by Mark Rowe.

interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute): Only take the fast negate path if
a bit other than bit 31 is set. If none of bits 0-30 are set, then the
value we're negating can only be 0 or -2147483648, and neither can be
negated in int space.

jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_negate):
(JSC::JIT::emitSlow_op_negate): Updated the JIT implementation to match
the interpreter, since it's slightly simpler.

9:52 AM Changeset in webkit [56399] by eric@webkit.org

2 edits in trunk/WebKit/qt

2010-03-23 David Leong <david.leong@nokia.com>

Reviewed by Laszlo Gombos.

Build fix for Symbian Def file.

symbian/eabi/QtWebKitu.def:

9:44 AM QtWebKitBackportingFixes edited by siddharth.mathur@nokia.com

added JSC collector memory improvement #34350 (diff)

9:34 AM Changeset in webkit [56398] by eric@webkit.org

5 edits
2 adds in trunk

2010-03-23 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Simon Hausmann.

Qt] LayoutTests/fast/canvas/fillrect_gradient.html failed
https://bugs.webkit.org/show_bug.cgi?id=36444

Enable LayoutTests/fast/canvas/fillrect_gradient.html

platform/qt/Skipped:
platform/qt/fast/canvas/fillrect_gradient-expected.checksum: Added.
platform/qt/fast/canvas/fillrect_gradient-expected.png: Added.
platform/qt/fast/canvas/fillrect_gradient-expected.txt:

2010-03-23 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Simon Hausmann.

[Qt] LayoutTests/fast/canvas/fillrect_gradient.html failed
https://bugs.webkit.org/show_bug.cgi?id=36444

Handle duplicated or unsorted colorStop at platformDestory

platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):

8:47 AM Changeset in webkit [56397] by jchaffraix@webkit.org

3 edits in trunk/WebCore

Unreviewed build fix.

Try to make the window buildbot happy.

xml/XMLHttpRequestProgressEventThrottle.cpp:
xml/XMLHttpRequestProgressEventThrottle.h: Move initialization of the

static const in the cpp file.

8:42 AM Changeset in webkit [56396] by pfeldman@chromium.org

2 edits in trunk/WebCore

2010-03-23 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: make gear menu appear on styles panel at all times.

https://bugs.webkit.org/show_bug.cgi?id=36490

inspector/front-end/inspector.css:

8:39 AM Changeset in webkit [56395] by pfeldman@chromium.org

6 edits in trunk/WebCore

2010-03-23 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: render nodes in inherited style bars as links.

https://bugs.webkit.org/show_bug.cgi?id=36486

English.lproj/localizedStrings.js:
inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked): (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._update.else.insertInheritedNodeSeparator): (WebInspector.StylesSidebarPane.prototype._update): (WebInspector.StylesSidebarPane.prototype._selectNode):
inspector/front-end/inspector.js:

8:33 AM Changeset in webkit [56394] by jchaffraix@webkit.org

10 edits
5 adds in trunk

[XHR] onProgress event needs to be dispatched according to what the specification states
https://bugs.webkit.org/show_bug.cgi?id=18654

Reviewed by Alexey Proskuryakov.

WebCore:

Test: http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html

Android.mk:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:

Added XMLHttpRequestProgressEventThrottle to the build systems.

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::XMLHttpRequest): Created the throttle.
(WebCore::XMLHttpRequest::callReadyStateChangeListener): The 'readyState' event are
dispatched using the XMLHttpRequestProgressEventThrottle now. For the DONE state, we
need to flush any pending progress event as we do not want it to be dispatched after
the DONE readyState event.
(WebCore::XMLHttpRequest::createRequest): Made this event use the
XMLHttpRequestProgressEventThrottle for event dispatching.
(WebCore::XMLHttpRequest::abort): Ditto.
(WebCore::XMLHttpRequest::networkError): Ditto.
(WebCore::XMLHttpRequest::abortError): Ditto.
(WebCore::XMLHttpRequest::didReceiveData): Ditto. Also fixed a potential warning.
(WebCore::XMLHttpRequest::suspend):
(WebCore::XMLHttpRequest::resume): Implemented the logic for suspend / resume.

xml/XMLHttpRequest.h:
xml/XMLHttpRequestProgressEventThrottle.cpp: Added.

(WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle):
(WebCore::XMLHttpRequestProgressEventThrottle::~XMLHttpRequestProgressEventThrottle):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent): Implemented the bulk
of the event throttling here: we use a timer to do so, as long as the timer is active it means
that events are coming faster than the throttling time and we coalesce them.
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchEvent): Generic method to dispatch an event.
(WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent): Called when we want to dispatch
any pending events and stopping any further dispatching.
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchPausedEvent): Used to dispatch the event
that was queued due to the object being suspended.
(WebCore::XMLHttpRequestProgressEventThrottle::fired): Used to dispatch any coalesced event.
(WebCore::XMLHttpRequestProgressEventThrottle::hasEventToDispatch): Used to check if we have
an event to dispatch.
(WebCore::XMLHttpRequestProgressEventThrottle::suspend): Marked the object as suspended.
(WebCore::XMLHttpRequestProgressEventThrottle::resume): Dispatched the event that was queued.

xml/XMLHttpRequestProgressEventThrottle.h: Added.

(WebCore::):
(WebCore::XMLHttpRequestProgressEventThrottle::suspended):

LayoutTests:

Add a test to check that progress events are really throttled.

http/tests/xmlhttprequest/resources/download-with-delay.php: Added.
http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch-expected.txt: Added.
http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html: Added.

8:14 AM Changeset in webkit [56393] by pfeldman@chromium.org

4 edits
2 adds in trunk

2010-03-23 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Element inspector search funtion: Error dispatching: performSearch.

https://bugs.webkit.org/show_bug.cgi?id=36488

Test: inspector/elements-panel-search.html

inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.performSearch): (WebInspector.ElementsPanel.prototype.addNodesToSearchResult):
inspector/front-end/InjectedScript.js: (injectedScriptConstructor.): (injectedScriptConstructor):

7:57 AM Changeset in webkit [56392] by Laszlo Gombos

2 edits in trunk

2010-03-23 Laszlo Gombos <Laszlo Gombos>

Unreviewed, fix the reviwer for r56391.

WebCore/ChangeLog
LayoutTests/ChangeLog

7:37 AM Changeset in webkit [56391] by Laszlo Gombos

6 edits
2 adds in trunk

2010-03-23 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] fast/canvas/patternfill-repeat.html failed.
https://bugs.webkit.org/show_bug.cgi?id=34477

Change Pattern to expose the repeatX and repeatY
at GraphicsContextQt to apply repeatX and repeatY

platform/graphics/Pattern.h: (WebCore::Pattern::repeatX): (WebCore::Pattern::repeatY):
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::rotate):

2010-03-23 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] fast/canvas/patternfill-repeat.html failed.
https://bugs.webkit.org/show_bug.cgi?id=34477

Enable LayoutTests/fast/canvas/patternfill-repeat.html.

platform/qt/Skipped:
platform/qt/fast/canvas/patternfill-repeat-expected.checksum: Added.
platform/qt/fast/canvas/patternfill-repeat-expected.png: Added.
platform/qt/fast/canvas/patternfill-repeat-expected.txt:

7:19 AM QtWebKitBugs edited by jocelyn.turcotte@nokia.com

minor (diff)

7:05 AM Changeset in webkit [56390] by eric@webkit.org

35 edits in trunk

2010-03-23 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Updated test results from removal of use of STIX fonts.

platform/mac/mathml/presentation/fractions-expected.checksum:
platform/mac/mathml/presentation/fractions-expected.png:
platform/mac/mathml/presentation/fractions-expected.txt:
platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
platform/mac/mathml/presentation/mo-expected.checksum:
platform/mac/mathml/presentation/mo-expected.png:
platform/mac/mathml/presentation/mo-expected.txt:
platform/mac/mathml/presentation/over-expected.checksum:
platform/mac/mathml/presentation/over-expected.png:
platform/mac/mathml/presentation/over-expected.txt:
platform/mac/mathml/presentation/row-expected.checksum:
platform/mac/mathml/presentation/row-expected.png:
platform/mac/mathml/presentation/row-expected.txt:
platform/mac/mathml/presentation/sub-expected.checksum:
platform/mac/mathml/presentation/sub-expected.png:
platform/mac/mathml/presentation/sub-expected.txt:
platform/mac/mathml/presentation/subsup-expected.checksum:
platform/mac/mathml/presentation/subsup-expected.png:
platform/mac/mathml/presentation/subsup-expected.txt:
platform/mac/mathml/presentation/sup-expected.checksum:
platform/mac/mathml/presentation/sup-expected.png:
platform/mac/mathml/presentation/tables-expected.checksum:
platform/mac/mathml/presentation/tables-expected.png:
platform/mac/mathml/presentation/tables-expected.txt:
platform/mac/mathml/presentation/under-expected.checksum:
platform/mac/mathml/presentation/under-expected.png:
platform/mac/mathml/presentation/under-expected.txt:
platform/mac/mathml/presentation/underover-expected.checksum:
platform/mac/mathml/presentation/underover-expected.png:
platform/mac/mathml/presentation/underover-expected.txt:

2010-03-23 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Removed the use of beta STIX fonts.

css/mathml.css:

6:34 AM Changeset in webkit [56389] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed.

[Qt] websocket/tests/long-invalid-header.html fails
https://bugs.webkit.org/show_bug.cgi?id=36492

platform/qt/Skipped: websocket/tests/long-invalid-header.html skipped until fix.

6:23 AM Changeset in webkit [56388] by kov@webkit.org

2 edits in trunk/LayoutTests

2010-03-23 Gustavo Noronha Silva <Gustavo Noronha Silva>

[GTK] Failing fast/css/zoom-body-scroll.html - sizes are off by one after zooming out
https://bugs.webkit.org/show_bug.cgi?id=36491

Skipping test that fails on 32 bits bots.

platform/gtk/Skipped:

6:23 AM Changeset in webkit [56387] by kov@webkit.org

11 edits
1 add in trunk

WebCore

2010-03-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

[GTK] Does not build with latest GTK+ development release
https://bugs.webkit.org/show_bug.cgi?id=36398

Fix building with newest GTK+ versions.

GNUmakefile.am:
platform/gtk/GtkPluginWidget.cpp: (WebCore::GtkPluginWidget::invalidateRect): (WebCore::GtkPluginWidget::paint):
platform/gtk/GtkVersioning.h: Added.
platform/gtk/PlatformScreenGtk.cpp: (WebCore::getVisual): (WebCore::screenRect): (WebCore::screenAvailableRect):
platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::paint):
plugins/gtk/gtk2xtbin.c: (gtk_xtbin_set_position): (gtk_xtbin_unrealize):

WebKit/gtk

2010-03-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

[GTK] Does not build with latest GTK+ development release
https://bugs.webkit.org/show_bug.cgi?id=36398

Fix building with newest GTK+ versions.

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::windowRect): (WebKit::ChromeClient::setWindowRect): (WebKit::ChromeClient::unfocus): (WebKit::ChromeClient::canTakeFocus): (WebKit::ChromeClient::contentsSizeChanged):
webkit/webkitprivate.cpp: (currentToplevelCallback):
webkit/webkitwebframe.cpp: (webkit_web_frame_print_full): (webkit_web_frame_print):
webkit/webkitwebview.cpp: (webkit_web_view_grab_focus): (webkit_web_view_focus_in_event): (webkit_web_view_script_dialog):

5:52 AM Changeset in webkit [56386] by eric@webkit.org

16 edits in trunk

2010-03-23 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt v4.4
https://bugs.webkit.org/show_bug.cgi?id=36389

No new tests as there is no new functionality.

WebCore.pri:
WebCore.pro:
platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::willLoadFromCache):
platform/qt/CookieJarQt.cpp: (WebCore::setCookies): (WebCore::cookies):
platform/qt/KURLQt.cpp: (WebCore::KURL::operator QUrl):
platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paintScrollCorner):
plugins/mac/PluginViewMac.cpp:

2010-03-23 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt v4.4
https://bugs.webkit.org/show_bug.cgi?id=36389

Api/qwebelement.cpp: (QWebElement::classes):
Api/qwebpage.cpp: (QWebPagePrivate::editorActionForKeyEvent): (QWebPage::userAgentForUrl):
WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):
tests/tests.pro:

2010-03-23 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt v4.4
https://bugs.webkit.org/show_bug.cgi?id=36389

DumpRenderTree/qt/main.cpp: (main):
QtLauncher/mainwindow.cpp: (MainWindow::MainWindow):

4:07 AM Changeset in webkit [56385] by tkent@chromium.org

8 edits in trunk/WebCore

2010-03-23 Kent Tamura <tkent@chromium.org>

Reviewed by Adam Barth.

Add checks if setNeedsWillValidateCheck() and
setNeedsValidityCheck() are called correctly.
https://bugs.webkit.org/show_bug.cgi?id=34924

Introduce HTMLFormControlElement::m_willValidate and
m_isValid. They are the caches of willValidate() and
isValidFormControlElement(). setNeedsWillValidateCheck() updates
m_willValidate and setNeedsValidityCheck() updates m_isValid.

willValidate() and isValidFormControlElement() have assertions to
check m_willvalidate or m_isValid has the correct state. If
setNeedsWillValidateCheck() or setNeedsValidityCheck() is needed
to be called and is not called, these assertions fail.

html/HTMLButtonElement.h: (WebCore::HTMLButtonElement::recalcWillValidate):
html/HTMLFieldSetElement.h: (WebCore::HTMLFieldSetElement::recalcWillValidate):
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::parseMappedAttribute): (WebCore::HTMLFormControlElement::recalcWillValidate): (WebCore::HTMLFormControlElement::willValidate): (WebCore::HTMLFormControlElement::setNeedsWillValidateCheck): (WebCore::HTMLFormControlElement::validationMessage): (WebCore::HTMLFormControlElement::isValidFormControlElement): (WebCore::HTMLFormControlElement::setNeedsValidityCheck):
html/HTMLFormControlElement.h:
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::recalcWillValidate):
html/HTMLInputElement.h:
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setNonDirtyValue):

1:18 AM Changeset in webkit [56384] by ukai@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, remove flaky tag in websocket tests.

flakiness in websocket tests (http://crbug.com/38397) introducted at
Chromium r41818 has been fixed at r42320.

platform/chromium/test_expectations.txt: remove BUG38397

12:07 AM Changeset in webkit [56383] by pfeldman@chromium.org

11 edits
2 adds in trunk

2010-03-22 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Dave Hyatt.

Web Inspector: display CSS selector source line in the styles sidebar pane.

https://bugs.webkit.org/show_bug.cgi?id=36414

This change adds a sourceLine field into the CSSStyleRule that is populated
from within the parser. CSSParser is now keeping track of the line numbers
and last selector line number that is being used while creating CSSStyleRules.

Test: inspector/styles-source-lines.html

css/CSSGrammar.y:
css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::lex): (WebCore::CSSParser::countLines): (WebCore::CSSParser::createStyleRule):
css/CSSParser.h: (WebCore::CSSParser::updateLastSelectorLine):
css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::CSSStyleRule):
css/CSSStyleRule.h: (WebCore::CSSStyleRule::create): (WebCore::CSSStyleRule::sourceLine):
css/tokenizer.flex:
inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForRule):
inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration.parseRule):
inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection):

Mar 22, 2010:

11:48 PM Changeset in webkit [56382] by eric@webkit.org

4 edits
3 adds in trunk

2010-03-22 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

Qt] Fix arc function in canvas
https://bugs.webkit.org/show_bug.cgi?id=36296

platform/qt/Skipped:
platform/qt/fast/canvas/arc360-expected.checksum: Added.
platform/qt/fast/canvas/arc360-expected.png: Added.
platform/qt/fast/canvas/arc360-expected.txt: Added.

2010-03-22 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix arc function in canvas
https://bugs.webkit.org/show_bug.cgi?id=36296

Based on HTLM5 spec (4.8.10.1.8 Complex shapes), arc function should draw a line to previous point, not only the arc.

platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):

11:30 PM Changeset in webkit [56381] by eric@webkit.org

4 edits
4 adds in trunk/WebKit/chromium

2010-03-22 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add GraphicsContext3D abstraction to WebKit API
https://bugs.webkit.org/show_bug.cgi?id=36262

Added WebGraphicsContext3D to the WebKit API and refactored Chromium's
GraphicsContext3D implementation to use it. All of the OpenGL calls have
been moved out of WebKit/chromium/src/GraphicsContext3D.cpp and into the
WebGraphicsContext3D implementation. GraphicsContext3D is still
responsible for the transfer of rendered output from the
WebGraphicsContext3D to the HTMLCanvasElement.

The GraphicsContext3DInternal class, which is a data member of
GraphicsContext3D for the Chromium port, remains. It is possible to
eliminate this class and thereby one level of delegation, but this is
being deferred.

The needed entry point for a Chrome implementation of
WebGraphicsContext3D has been added to WebKitClient, but it is not being
called yet by GraphicsContext3D. It will be once this patch lands and
Chromium is rolled forward to support this entry point.

This is a large patch, but the transformation is almost entirely
mechanical and there is no change in functionality. Nearly all of
GraphicsContext3D and GraphicsContext3DInternal has been moved to
WebGraphicsContext3DDefaultImpl. The only area where the splitting of
logic is less than mechanical is GraphicsContext3D::beginPaint() and its
callees.

Ran all WebGL layout tests and demos from Khronos site in Chromium
on Mac and Windows.

WebKit.gyp:
public/WebGraphicsContext3D.h: Added. (WebKit::WebGraphicsContext3D::Attributes::Attributes): (WebKit::WebGraphicsContext3D::~WebGraphicsContext3D):
public/WebKitClient.h: (WebKit::WebKitClient::createGraphicsContext3D):
src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D): (WebCore::GraphicsContext3DInternal::platformTexture): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::endPaint): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::bindAttribLocation): (WebCore::GraphicsContext3DInternal::bindTexture): (WebCore::GraphicsContext3DInternal::bufferData): (WebCore::GraphicsContext3DInternal::bufferSubData): (WebCore::GraphicsContext3DInternal::getActiveAttrib): (WebCore::GraphicsContext3DInternal::getActiveUniform): (WebCore::GraphicsContext3DInternal::getAttribLocation): (WebCore::GraphicsContext3DInternal::getContextAttributes): (WebCore::GraphicsContext3DInternal::getProgramInfoLog): (WebCore::GraphicsContext3DInternal::getShaderInfoLog): (WebCore::GraphicsContext3DInternal::getShaderSource): (WebCore::GraphicsContext3DInternal::getString): (WebCore::GraphicsContext3DInternal::getUniformLocation): (WebCore::GraphicsContext3DInternal::readPixels): (WebCore::GraphicsContext3DInternal::shaderSource): (WebCore::GraphicsContext3DInternal::texImage2D): (WebCore::GraphicsContext3DInternal::texSubImage2D): (WebCore::GraphicsContext3DInternal::uniform1fv): (WebCore::GraphicsContext3DInternal::uniform1iv): (WebCore::GraphicsContext3DInternal::uniform2fv): (WebCore::GraphicsContext3DInternal::uniform2iv): (WebCore::GraphicsContext3DInternal::uniform3fv): (WebCore::GraphicsContext3DInternal::uniform3iv): (WebCore::GraphicsContext3DInternal::uniform4fv): (WebCore::GraphicsContext3DInternal::uniform4iv): (WebCore::GraphicsContext3DInternal::uniformMatrix2fv): (WebCore::GraphicsContext3DInternal::uniformMatrix3fv): (WebCore::GraphicsContext3DInternal::uniformMatrix4fv): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D):
src/WebGraphicsContext3D.cpp: Added. (WebKit::WebGraphicsContext3D::createDefault):
src/WebGraphicsContext3DDefaultImpl.cpp: Added. (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::create): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::~GLConnection): (WebKit::WebGraphicsContext3DDefaultImpl::VertexAttribPointerState::VertexAttribPointerState): (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::makeContextCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::width): (WebKit::WebGraphicsContext3DDefaultImpl::height): (WebKit::WebGraphicsContext3DDefaultImpl::sizeInBytes): (WebKit::createTextureObject): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::flipVertically): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::activeTexture): (WebKit::WebGraphicsContext3DDefaultImpl::bindBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::bindFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::disableVertexAttribArray): (WebKit::WebGraphicsContext3DDefaultImpl::drawElements): (WebKit::WebGraphicsContext3DDefaultImpl::enableVertexAttribArray): (WebKit::WebGraphicsContext3DDefaultImpl::generateMipmap): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveAttrib): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveUniform): (WebKit::WebGraphicsContext3DDefaultImpl::getContextAttributes): (WebKit::WebGraphicsContext3DDefaultImpl::getError): (WebKit::WebGraphicsContext3DDefaultImpl::getProgramInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::getString): (WebKit::WebGraphicsContext3DDefaultImpl::getVertexAttribOffset): (WebKit::WebGraphicsContext3DDefaultImpl::releaseShaderCompiler): (WebKit::WebGraphicsContext3DDefaultImpl::shaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::vertexAttribPointer): (WebKit::WebGraphicsContext3DDefaultImpl::createBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createProgram): (WebKit::WebGraphicsContext3DDefaultImpl::createRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createTexture): (WebKit::WebGraphicsContext3DDefaultImpl::deleteBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteProgram): (WebKit::WebGraphicsContext3DDefaultImpl::deleteRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteShader): (WebKit::WebGraphicsContext3DDefaultImpl::deleteTexture): (WebKit::WebGraphicsContext3DDefaultImpl::synthesizeGLError):
src/WebGraphicsContext3DDefaultImpl.h: Added. (WebKit::WebGraphicsContext3DDefaultImpl::): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::chooseFBConfig): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createNewContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createPbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyPbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::makeCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::getCurrentContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::GLConnection):

11:08 PM Changeset in webkit [56380] by ukai@chromium.org

3 edits
4 adds in trunk

2010-03-19 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36339
This LayoutTest tests for webkit ability to process long invalid headers generated by misbehaving websockets servers.

websocket/tests/long-invalid-header-expected.txt: Added.
websocket/tests/long-invalid-header.html: Added.
websocket/tests/long-invalid-header_wsh.py: Added.
websocket/tests/script-tests/long-invalid-header.js: Added.

2010-03-19 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36339
Off-by-one memory corruption fix for long invalid websockets upgrade header

Test: websocket/tests/long-invalid-header.html

websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake):

10:51 PM Changeset in webkit [56379] by eric@webkit.org

2 edits in trunk/LayoutTests

2010-03-22 David Kilzer <ddkilzer@apple.com>

Remove http/tests/cookies/simple-cookies-expired.html from skip list after CFNetwork issue is resolved
<http://webkit.org/b/25861>
<rdar://problem/6901322>

Reviewed by Darin Adler.

platform/win/Skipped: Removed:
http/tests/cookies/simple-cookies-expired.html

10:32 PM Changeset in webkit [56378] by eric@webkit.org

1 edit
1 move in trunk/LayoutTests

2010-03-22 Eric Seidel <eric@webkit.org>

Rubber-stamped by Brady Eidson.

fast/loader/cancel-load-during-port-block-timer.html fails on Tiger bot
https://bugs.webkit.org/show_bug.cgi?id=36425

This test bleeds into the next test and causes failures. Unsure of the
cause. Brady suggests we disable it for now (to match the other disabled) api test.

fast/loader/api-test-go-to-current-back-forward-item.html-disabled: Renamed from LayoutTests/fast/loader/api-test-go-to-current-back-forward-item.html.

10:03 PM Changeset in webkit [56377] by ukai@chromium.org

2 edits in trunk/WebCore

2010-03-22 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed build fix for Chromim Mac at r56376

Fix initializer order of PopupContainer.

platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::PopupContainer):

8:01 PM Changeset in webkit [56376] by eric@webkit.org

10 edits in trunk

2010-03-22 Jay Campan <jcampan@google.com>

Reviewed by Darin Fisher.

Making Chromium select popups not steal activation from the browser.
Select popups are now like autocomplete popups, shown in non-activated
windows.
https://bugs.webkit.org/show_bug.cgi?id=36062

page/chromium/ChromeClientChromium.h:
platform/chromium/PopupMenuChromium.cpp: (WebCore::): (WebCore::PopupContainer::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::~PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::showExternal): (WebCore::PopupContainer::hidePopup): (WebCore::PopupMenu::show):
platform/chromium/PopupMenuChromium.h: (WebCore::PopupContainer::): (WebCore::PopupContainer::popupType):

2010-03-22 Jay Campan <jcampan@google.com>

Reviewed by Darin Fisher.

Making Chromium select popups not steal activation from the browser.
Select popups are now like autocomplete popups, shown in non-activated
windows.
https://bugs.webkit.org/show_bug.cgi?id=36062

public/WebViewClient.h: (WebKit::WebViewClient::createPopupMenu):
src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::popupOpened): (WebKit::ChromeClientImpl::popupClosed):
src/ChromeClientImpl.h:
src/WebViewImpl.cpp: (WebKit::): (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::selectPopupHandleKeyEvent): (WebKit::WebViewImpl::hideSelectPopup): (WebKit::WebViewImpl::popupOpened): (WebKit::WebViewImpl::popupClosed): (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::applyAutoFillSuggestions): (WebKit::WebViewImpl::applyAutocompleteSuggestions):
src/WebViewImpl.h:

7:21 PM Changeset in webkit [56375] by dimich@chromium.org

4 edits
2 adds in trunk

[v8] Crash if the worker is terminated before its initial script is executed.
https://bugs.webkit.org/show_bug.cgi?id=36336

Reviewed by Nate Chapin.

WebCore:

Test: fast/workers/termination-early.html

bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Check for 0 context. When terminated, the v8 heap initialization returns 0.
(WebCore::WorkerContextExecutionProxy::evaluate): Don't execute script if initialization failed.

bindings/v8/WorkerContextExecutionProxy.h:

LayoutTests:

fast/workers/termination-early-expected.txt: Added.
fast/workers/termination-early.html: Added.

7:11 PM Changeset in webkit [56374] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-22 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Support creation of fake workers before document is loaded by deferring
attaching of fake workers iframe until document is loaded and buffering all
messages addressed to worker.
https://bugs.webkit.org/show_bug.cgi?id=36445

inspector/front-end/InjectedFakeWorker.js: (InjectedFakeWorker.FakeWorker.prototype.postMessage): (InjectedFakeWorker.FakeWorker.prototype._buildWorker): (InjectedFakeWorker.FakeWorker.prototype._attachWorkerFrameToDocument): (InjectedFakeWorker.FakeWorker.prototype._onWorkerFrameLoaded):

6:31 PM Changeset in webkit [56373] by eric@webkit.org

4 edits in trunk/WebKit/qt

2010-03-22 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix qdoc warnings
https://bugs.webkit.org/show_bug.cgi?id=36447

Api/qgraphicswebview.cpp: Add missing ().
Api/qwebframe.cpp: Remove reference to non-existent parameter "url".
Api/qwebsettings.cpp: Document parameter "location".

6:13 PM Changeset in webkit [56372] by eric@webkit.org

3 edits in trunk/WebKitTools

2010-03-22 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Adam Barth.

Make build_webkit_command() pass MAKEFLAGS environment variable to make.
https://bugs.webkit.org/show_bug.cgi?id=36440

Scripts/webkitpy/webkitport.py:
Scripts/webkitpy/webkitport_unittest.py:

5:28 PM Changeset in webkit [56371] by mjs@apple.com

1 edit
1 add in trunk/WebKitSite

(Not reviewed.)

Add another example.

demos/accessible-ascii-art/butterfly-figure.html: Added.

5:28 PM Changeset in webkit [56370] by eric@webkit.org

4 edits
3 adds in trunk/JavaScriptCore

2010-03-22 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Symbian] More efficient aligned memory allocation for JSC Collector
https://bugs.webkit.org/show_bug.cgi?id=34350

JavaScriptCore.pri: Added 2 new Symbian source files and HAL linkage

runtime/Collector.cpp: Reduced port-specific code and added private data member (JSC::Heap::Heap): (JSC::Heap::~Heap): (JSC::Heap::destroy): (JSC::Heap::allocateBlock): (JSC::Heap::freeBlockPtr):

runtime/Collector.h: Added private data member

wtf/symbian: Added.
wtf/symbian/BlockAllocatorSymbian.cpp: Added. (WTF::AlignedBlockAllocator::AlignedBlockAllocator): Helper class to allocate aligned blocks more efficiently as required by Collector (WTF::AlignedBlockAllocator::alloc): (WTF::AlignedBlockAllocator::free): (WTF::AlignedBlockAllocator::destroy): (WTF::AlignedBlockAllocator::~AlignedBlockAllocator):
wtf/symbian/BlockAllocatorSymbian.h: Added.

4:51 PM Changeset in webkit [56369] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

Unreviewed, skip new failing test.

fast/loader/stateobjects/replacestate-in-iframe.html caused infinite loop.
https://bugs.webkit.org/show_bug.cgi?id=36467

platform/gtk/Skipped: fast/loader/stateobjects/replacestate-in-iframe.html skipped until fix.
platform/qt/Skipped: fast/loader/stateobjects/replacestate-in-iframe.html skipped until fix.

4:43 PM Changeset in webkit [56368] by mjs@apple.com

1 edit
2 adds in trunk/WebKitSite

(Not reviewed.)

Add example of accessible ASCII art for HTML WG.

demos/accessible-ascii-art: Added.
demos/accessible-ascii-art/butterfly.html: Added.

4:14 PM Changeset in webkit [56367] by Nate Chapin

5 edits
6 adds in trunk/LayoutTests

2010-03-22 Nate Chapin <Nate Chapin>

Unreviewed, Chromium test fixes.

platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.checksum:
platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.png:
platform/chromium-linux/plugins/embed-attributes-style-expected.checksum:
platform/chromium-linux/plugins/embed-attributes-style-expected.png:
platform/chromium-mac/svg/filters/feColorMatrix-values-expected.checksum: Added.
platform/chromium-mac/svg/filters/feColorMatrix-values-expected.png: Added.
platform/chromium-mac/svg/filters/feColorMatrix-values-expected.txt: Added.
platform/chromium-win/svg/filters/feColorMatrix-values-expected.checksum: Added.
platform/chromium-win/svg/filters/feColorMatrix-values-expected.png: Added.
platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt: Added.

4:04 PM Changeset in webkit [56366] by dpranke@chromium.org

4 edits in trunk/WebKitTools

2010-03-22 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Change baseline_path() to point to the upstream locations for the
Chromium ports. Also change the reabselining scripts to use the
correct functions to get the baseline directories, and fix the
script's sys.path to pull in simplejson correctly.

https://bugs.webkit.org/show_bug.cgi?id=36417

Scripts/rebaseline-chromium-webkit-tests:
- fix sys.path to pick up simplejson properly
Scripts/webkitpy/layout_tests/port/chromium.py:
- change baseline_path() to use webkit_baseline_path()
- error out correctly if we can't find the chromium base dir
Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- call baseline_path(), not chromium_baseline_path()

3:57 PM Changeset in webkit [56365] by darin@chromium.org

3 edits
2 adds in trunk

2010-03-22 Darin Fisher <darin@chromium.org>

Reviewed by Brady Eidson.

HistoryController::replaceState() should modify m_currentItem
instead of the current HistoryItem of the BackForwardList.

https://bugs.webkit.org/show_bug.cgi?id=36435

Test: fast/loader/stateobjects/replacestate-in-iframe.html

loader/HistoryController.cpp: (WebCore::HistoryController::replaceState):

3:54 PM Changeset in webkit [56364] by Simon Hausmann

1 edit in trunk/WebKitTools/ChangeLog

Oops, fix spurious angle brackets around name in patch I landed manually

3:31 PM Changeset in webkit [56363] by Joseph Pecoraro

5 edits in trunk/WebCore

2010-03-22 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Upstream Part of the iPhone Platform sharing code with the Mac Platform
https://bugs.webkit.org/show_bug.cgi?id=35870
<rdar://problem/7707283> and <rdar://problem/7707318>

Part 3 of 3: Shared code between iphone and mac. The shared code was
refactored to be usable by both platforms without platform specific
typing, meaning no NSEvent versus WebEvent special cases.

Shared code usable by either mac or iphone platforms.

platform/cocoa/KeyEventCocoa.h:
platform/cocoa/KeyEventCocoa.mm: (WebCore::keyIdentifierForCharCode): (WebCore::windowsKeyCodeForKeyCode): (WebCore::windowsKeyCodeForCharCode):

Make use of the shared code. Keep anything platform specific in the
original file before calling the shared code.

platform/iphone/KeyEventIPhone.mm: (WebCore::keyIdentifierForKeyEvent):
platform/mac/KeyEventMac.mm: (WebCore::keyIdentifierForKeyEvent): (WebCore::windowsKeyCodeForKeyEvent):

3:17 PM Rebaseline edited by Dimitri Glazkov

(diff)

3:15 PM Rebaseline edited by Dimitri Glazkov

Added title. (diff)

3:09 PM Rebaseline edited by Dimitri Glazkov

Clean up rebaseline doc. (diff)

3:05 PM Changeset in webkit [56362] by kdecker@apple.com

8 edits
3 deletes in trunk

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=36328

rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): Fix a find/repalce mistake from my earlier patch. Rename m_setShowsMissingPluginIndicator -> m_showsMissingPluginIndicator. (WebCore::RenderEmbeddedObject::updateWidget): Don't update the widget if we're showing the missing plug-in indicator. (WebCore::RenderEmbeddedObject::paint):Fix a find/repalce mistake from my earlier patch. Rename m_setShowsMissingPluginIndicator -> m_showsMissingPluginIndicator. (WebCore::RenderEmbeddedObject::paintReplaced): Ditto.
rendering/RenderEmbeddedObject.h: Ditto. (WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator): Ditto. (WebCore::RenderEmbeddedObject::showsMissingPluginIndicator): Ditto.

Plugins/WebNetscapePluginView.mm:
Plugins/WebNullPluginView.h: Removed.
Plugins/WebNullPluginView.mm: Removed.
Resources/nullplugin.tiff: Removed.
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Invoke the resource load delegate if the plug-in failed to load.

2:56 PM Changeset in webkit [56361] by Joseph Pecoraro

3 edits
1 copy
2 adds in trunk/WebCore

2010-03-22 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Upstream Part of the iPhone Platform sharing code with the Mac Platform
https://bugs.webkit.org/show_bug.cgi?id=35870
<rdar://problem/7707283>

Part 2 of 3: No changes other than moving code around.
Copied KeyEvent function from platform/mac to a platform/cocoa shared directory.

WebCore.xcodeproj/project.pbxproj: Added cocoa group and new files.
platform/cocoa/KeyEventCocoa.h: Added.
platform/cocoa/KeyEventCocoa.mm: Copied from WebCore/platform/mac/KeyEventMac.mm. (WebCore::keyIdentifierForKeyEvent): (WebCore::windowsKeyCodeForKeyEvent): Include the shared code.
platform/mac/KeyEventMac.mm:

2:24 PM Changeset in webkit [56360] by Joseph Pecoraro

3 edits
3 adds in trunk/WebCore

2010-03-22 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Part 1 of 3: Upstream iPhone KeyEvent platform code and share with Mac platform
https://bugs.webkit.org/show_bug.cgi?id=35870
<rdar://problem/7707283>

WebCore.xcodeproj/project.pbxproj: Added iphone group and new files.
platform/iphone: Added.
platform/iphone/KeyEventCodesIPhone.h: Added.
platform/iphone/KeyEventIPhone.mm: Added. Ensure PLATFORM(IPHONE)
platform/mac/KeyEventMac.mm: Ensure PLATFORM(MAC)

2:14 PM Changeset in webkit [56359] by kenneth@webkit.org

2 edits in trunk/LayoutTests

Unreviewed.

Skip editing test that fails

platform/qt/Skipped:

2:08 PM Changeset in webkit [56358] by krit@webkit.org

2 edits in trunk/LayoutTests

2010-03-22 Dirk Schulze <krit@webkit.org>

Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714

SVG Test has text in it. This caused a wrong DRT result on Mac.
The other result was created on Windows.

platform/mac/svg/filters/feColorMatrix-values-expected.txt:

1:38 PM Changeset in webkit [56357] by kdecker@apple.com

2 edits in trunk/WebCore

Attempt to fix the Leopard build.

rendering/RenderEmbeddedObject.cpp: Add ".f" to contants.

1:28 PM Changeset in webkit [56356] by krit@webkit.org

1 edit
1 add in trunk/LayoutTests

2010-03-22 Dirk Schulze <krit@webkit.org>

Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714

Add missing expected result.

platform/mac/svg/filters/feColorMatrix-values-expected.txt: Added.

1:24 PM QtWebKitBackportingFixes edited by Laszlo Gombos

(diff)

12:46 PM Changeset in webkit [56355] by krit@webkit.org

3 edits
7 adds in trunk

2010-03-22 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714

Prevents an invalid read when a valid values attribute is not
supplied for an feColorMatrix SVG filter. Also fixes general
handling of missing or invalid values attribute.

Tests: svg/filters/feColorMatrix-invalid-value.svg

svg/filters/feColorMatrix-values.svg

svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::build):

2010-03-22 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714

Prevents an invalid read when a valid values attribute is not
supplied for an feColorMatrix SVG filter. Also fixes general
handling of missing or invalid values attribute.

platform/win/svg/filters: Added.
platform/win/svg/filters/feColorMatrix-values-expected.checksum: Added.
platform/win/svg/filters/feColorMatrix-values-expected.png: Added.
platform/win/svg/filters/feColorMatrix-values-expected.txt: Added.
svg/filters/feColorMatrix-invalid-value-expected.txt: Added.
svg/filters/feColorMatrix-invalid-value.svg: Added.
svg/filters/feColorMatrix-values.svg: Added.

12:37 PM Changeset in webkit [56354] by Philippe Normand

4 edits
2 adds in trunk/WebCore

2010-03-22 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] Use ImageBuffer API to do painting
https://bugs.webkit.org/show_bug.cgi?id=35783

New ImageGStreamer class abstracting the conversion of GStreamer
buffers to cairo surfaces. Using this makes the painting code of
the player more generic.

GNUmakefile.am:
platform/graphics/gstreamer/ImageGStreamer.h: Added. (WebCore::ImageGStreamer::image):
platform/graphics/gstreamer/ImageGStreamerCairo.cpp: Added. (ImageGStreamer::createImage): (ImageGStreamer::ImageGStreamer): (ImageGStreamer::~ImageGStreamer):
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::paint):
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

12:36 PM Changeset in webkit [56353] by Beth Dakin

2 edits in trunk/WebCore

Fix for <rdar://problem/7766437> With Web Inspector opened, a crash
occurs at Webcore:getMatchedCSSRules() when navigating to a
previous page

Reviewed by Darin Adler.

defaultView() can legitimately by null (as it is in this case), so
it must be null-checked.

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getStyles):
(WebCore::InspectorDOMAgent::getComputedStyle):
(WebCore::InspectorDOMAgent::getMatchedCSSRules):

12:30 PM Changeset in webkit [56352] by kdecker@apple.com

5 edits in trunk/WebCore

Reviewed by Darin.

https://bugs.webkit.org/show_bug.cgi?id=36328

loader/FrameLoader.cpp: (WebCore::FrameLoader::loadPlugin): Call setShowsMissingPluginIndicator(true) in cases that fail to generate a widget.
rendering/RenderEmbeddedObject.cpp: Added new missing plug-in related static constants (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): Initialize newly boolean to false. (WebCore::RenderEmbeddedObject::paint): Added. (WebCore::RenderEmbeddedObject::paintReplaced): Added. Draws a subtle rounded rectangle containing the text "Missing Plug-in".
rendering/RenderEmbeddedObject.h: Added the following two methods below. (WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator): (WebCore::RenderEmbeddedObject::showsMissingPluginIndicator):
rendering/RenderWidget.h: Moved paint(PaintInfo&, int, int) from private to protected.

11:45 AM Changeset in webkit [56351] by ap@apple.com

4 edits in trunk/WebKit/mac

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=36455
Make WebKit more resistant against plug-in crashes

No tests, because crashing on build bots isn't good, even if it's only helper processes
that crash.

Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::waitForReply): Protect "this", because this function needs it after waiting for reply. Some callers used to do this, but not all, and we really shouldn't depend on callers here.

Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::wheelEvent): Don't protect the plug-in instance proxy, because this function doesn't use it after waiting for reply. (WebKit::NetscapePluginInstanceProxy::createBindingsInstance): Ditto.

Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invoke): Added an m_instanceProxy null check for another code path.

11:44 AM Changeset in webkit [56350] by Nate Chapin

2 edits in trunk/LayoutTests

2010-03-22 Nate Chapin <Nate Chapin>

Unreviewed, Chromium expectations tweak.

Add fast/dom/error-to-string-stack-overflow.html to expected
failures due to http://trac.webkit.org/changeset/56329.

platform/chromium/test_expectations.txt:

11:40 AM Changeset in webkit [56349] by jwieczorek@webkit.org

5 edits in trunk

2010-03-22 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Phonon media backend: expose supported MIME types to WebCore

https://bugs.webkit.org/show_bug.cgi?id=33453

List all skipped media tests individually and unskip two fixed by the patch.

platform/qt/Skipped:

2010-03-22 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Phonon media backend: expose supported MIME types to WebCore

https://bugs.webkit.org/show_bug.cgi?id=33453

MediaPlayerPrivate should expose the MIME types that are supported
by the underlying backend in Phonon.

platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivate::supportedTypesCache): (WebCore::MediaPlayerPrivate::getSupportedTypes): (WebCore::MediaPlayerPrivate::supportsType):
platform/graphics/qt/MediaPlayerPrivatePhonon.h:

11:33 AM Changeset in webkit [56348] by ggaren@apple.com

6 edits
2 adds in trunk

JavaScriptCore: Fixed <rdar://problem/7728196> REGRESSION (r46701): -(-2147483648)
evaluates to -2147483648 on 32 bit (35842)

Reviewed by Sam Weinig.

Two ways to fix the same bug:

Check for overflow when negating, since negating the largest negative

int causes overflow.

Constant-fold even when negating a negative, since, like they say in

high school, "math works."

assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::branchNeg32):

assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::branchNeg32): Added a branching version
of the negate operator.

jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_negate): Use the branching version of the negate
operator to check for overflow.

(JSC::JIT::emitSlow_op_negate): Link the check for overflow to a slow case.
(We could emit inline code for this, since we know what the result would
be, but that's probably just a waste of generated code.)

parser/Grammar.y: Constant fold even when negating a negative.

LayoutTests: Added a test for <rdar://problem/7728196> REGRESSION (r46701): -(-2147483648)
evaluates to -2147483648 on 32 bit (35842)

Reviewed by Sam Weinig.

fast/js/negate-overflow-expected.txt: Added.
fast/js/negate-overflow.html: Added.

11:18 AM Changeset in webkit [56347] by apavlov@chromium.org

3 edits in trunk/WebCore

2010-03-22 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: AuditRules still use getMatchedCSSRules as a part of the img-related audit.
https://bugs.webkit.org/show_bug.cgi?id=36424

inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.receivedImages): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.pushImageNodes):
inspector/front-end/InjectedScript.js: (injectedScriptConstructor):

11:17 AM Changeset in webkit [56346] by darin@chromium.org

3 edits
2 adds in trunk

2010-03-22 Darin Fisher <darin@chromium.org>

Reviewed by Nate Chapin.

[chromium] Renderer crashes when navigating to a reference fragment in
a frame that has no current HistoryItem.

https://bugs.webkit.org/show_bug.cgi?id=36443

Test: fast/loader/crash-replacing-location-before-load.html

src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):

10:51 AM Changeset in webkit [56345] by Darin Adler

2 edits in trunk/WebCore

2010-03-22 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

TextBreakIteratorICU.cpp is incompatible with new UBreakIterator type in ICU 4.4
https://bugs.webkit.org/show_bug.cgi?id=36381

platform/text/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Use reinterpret_cast instead of static_cast or relying on conversion to void*. (WebCore::textBreakFirst): Ditto. (WebCore::textBreakLast): Ditto. (WebCore::textBreakNext): Ditto. (WebCore::textBreakPrevious): Ditto. (WebCore::textBreakPreceding): Ditto. (WebCore::textBreakFollowing): Ditto. (WebCore::textBreakCurrent): Ditto. (WebCore::isTextBreak): Ditto. (WebCore::setUpIteratorWithRules): Ditto.

10:48 AM Changeset in webkit [56344] by eric.carlson@apple.com

8 edits in trunk/WebCore

2010-03-22 Eric Carlson <eric.carlson@apple.com>

Reviewed by Sam Weinig.

Typo in GPL license text
https://bugs.webkit.org/show_bug.cgi?id=36442

Fix typo - "aint with this library" -> "along with this library".

bindings/scripts/CodeGenerator.pm:
bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/CodeGeneratorObjC.pm:
bindings/scripts/CodeGeneratorV8.pm:
bindings/scripts/IDLParser.pm:
bindings/scripts/IDLStructure.pm:
bindings/scripts/generate-bindings.pl:

10:42 AM Changeset in webkit [56343] by jwieczorek@webkit.org

5 edits in trunk

2010-03-22 Jakub Wieczorek <jwieczorek@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Don't construct a QLineEdit every time when painting a text field
https://bugs.webkit.org/show_bug.cgi?id=36373

Instead, keep one instance per RenderTheme around.

platform/qt/RenderThemeQt.cpp: (WebCore::findFrameLineWidth):

2010-03-22 Jakub Wieczorek <jwieczorek@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Don't construct a QLineEdit every time when painting a text field
https://bugs.webkit.org/show_bug.cgi?id=36373

Add a simple benchmark covering this area.

tests/benchmarks/painting/tst_painting.cpp: (tst_Painting::textAreas):

10:39 AM Changeset in webkit [56342] by ddkilzer@apple.com

3 edits in trunk/JavaScriptCore

<http://webkit.org/b/36431> Clean up 'int' use in UString.cpp after r54789

Reviewed by Darin Adler.

runtime/UString.cpp:

(JSC::UString::from): Changed argument type from 'unsigned int'
to 'unsigned' to match WebKit coding style.
(JSC::UString::find): Changed static_cast<int>() to
static_cast<unsigned>() now that this method returns unsigned.
(JSC::UString::rfind): Ditto.

runtime/UString.h:

(JSC::UString::from): Changed argument type from 'unsigned int'
to 'unsigned' to match WebKit coding style.

10:38 AM Changeset in webkit [56341] by eric@webkit.org

3 edits in trunk/WebCore

2010-03-22 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Multiselect Popup - adjusting QtAbstractWebPopup
https://bugs.webkit.org/show_bug.cgi?id=36186

QtAbstractWebPopup must provide new methods to be used by its descendants that
wish to handle <select multiple> elements.

platform/qt/QtAbstractWebPopup.cpp: (WebCore::QtAbstractWebPopup::selectItem): (WebCore::QtAbstractWebPopup::multiple):
platform/qt/QtAbstractWebPopup.h:

10:20 AM Changeset in webkit [56340] by eric@webkit.org

4 edits
10 adds in trunk

2010-03-22 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Basic tests of mfrac (fractions)

mathml/presentation/fractions.xhtml: Added.
mathml/presentation/fractions-vertical-alignment.xhtml: Added
platform/mac/mathml/presentation/fractions-expected.checksum: Added.
platform/mac/mathml/presentation/fractions-expected.png: Added.
platform/mac/mathml/presentation/fractions-expected.txt: Added.
platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum: Added.
platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.

2010-03-22 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Added basic support for mfrac (fractions)

Test: mathml/presentation/fractions.xhtml

WebCore.xcodeproj/project.pbxproj:
mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::createRenderer):
mathml/RenderMathMLFraction.cpp: Added. (WebCore::RenderMathMLFraction::RenderMathMLFraction): (WebCore::RenderMathMLFraction::updateFromElement): (WebCore::RenderMathMLFraction::addChild):
mathml/RenderMathMLFraction.h: Added.

9:47 AM Changeset in webkit [56339] by Darin Adler

4 edits in trunk/WebKit

WebKit: * StringsNotToBeLocalized.txt: Updated for recent changes.

WebKit/win: * WebCoreLocalizedStrings.cpp:
(WebCore::missingPluginText): Fixed localization helper text to match the same
string from Mac WebKit.

9:46 AM Rebaseline created by Dimitri Glazkov

Ported rebaseline tool documentation from Chromium wiki

9:45 AM Changeset in webkit [56338] by ap@apple.com

1 edit
2 adds in trunk/LayoutTests

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=36400
Add a test for r15750 (Flash crashes after it replaces itself via a document.write())

plugins/destroy-plugin-from-callback-expected.txt: Added.
plugins/destroy-plugin-from-callback.html: Added.

9:29 AM Changeset in webkit [56337] by kdecker@apple.com

14 edits in trunk

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=36328

page/mac/WebCoreViewFactory.h: Added -missingPluginText method
platform/LocalizedStrings.h: Added missingPluginText()
platform/gtk/LocalizedStringsGtk.cpp: Likewise.
platform/mac/LocalizedStringsMac.mm: Same here.
platform/qt/Localizations.cpp: Ditto.
English.lproj/Localizable.strings: Added "Missing Plug-in" string.
src/LocalizedStrings.cpp: (WebCore::missingPluginText): Added
WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory missingPluginText]): Added.

9:24 AM Changeset in webkit [56336] by eric@webkit.org

2 edits in trunk/WebKitTools

2010-03-22 Chris Jerdonek <Chris Jerdonek>

Reviewed by Adam Barth.

Refactored the cpu_count() code in executive.py.

https://bugs.webkit.org/show_bug.cgi?id=36437

Scripts/webkitpy/executive.py:
- Moved the import of the multiprocessing module to the top of the file rather than importing from within a function.

8:24 AM Changeset in webkit [56335] by tonikitoo@webkit.org

3 edits in trunk/WebKitTools

Revert "2010-03-18 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>"

This reverts commit d76f355a659be5b3384f9c26bc6ad64f3256c9fb.

Conflicts:

WebKitTools/ChangeLog

8:09 AM Changeset in webkit [56334] by eric@webkit.org

3 edits in trunk/WebKit/qt

2010-03-22 Yi Shen <shenyi2006@gmail.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=35933
[Qt] [Symbian] Can not backward select (highlight) text using virtual keyboard
Make sure the selection start index is smaller than the selection end index.

Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):

7:37 AM Changeset in webkit [56333] by eric@webkit.org

7 edits
3 adds in trunk/JavaScriptCore

2010-03-22 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add support for syntax checking in the QtScript API.

New class was created; the QScriptSyntaxCheckResult which main
responsibility is to provide results of the ECMA Script code
syntax check. The class is not fully functional as the JSC C API
doesn't expose an error column number, but it is a good start point
for a future development.

[Qt] QtScript functionality should be extended by syntax checking.
https://bugs.webkit.org/show_bug.cgi?id=36123

qt/api/QtScript.pro:
qt/api/qscriptengine.cpp: (QScriptEngine::checkSyntax):
qt/api/qscriptengine.h:
qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::checkSyntax):
qt/api/qscriptengine_p.h:
qt/api/qscriptsyntaxcheckresult.cpp: Added. (QScriptSyntaxCheckResult::QScriptSyntaxCheckResult): (QScriptSyntaxCheckResult::~QScriptSyntaxCheckResult): (QScriptSyntaxCheckResult::operator=): (QScriptSyntaxCheckResult::state): (QScriptSyntaxCheckResult::errorLineNumber): (QScriptSyntaxCheckResult::errorColumnNumber): (QScriptSyntaxCheckResult::errorMessage):
qt/api/qscriptsyntaxcheckresult.h: Added.
qt/api/qscriptsyntaxcheckresult_p.cpp: Added. (QScriptSyntaxCheckResultPrivate::~QScriptSyntaxCheckResultPrivate): (QScriptSyntaxCheckResultPrivate::errorMessage): (QScriptSyntaxCheckResultPrivate::errorLineNumber):
qt/api/qscriptsyntaxcheckresult_p.h: Added. (QScriptSyntaxCheckResultPrivate::get): (QScriptSyntaxCheckResultPrivate::QScriptSyntaxCheckResultPrivate): (QScriptSyntaxCheckResultPrivate::state): (QScriptSyntaxCheckResultPrivate::errorColumnNumber):
qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::checkSyntax_data): (tst_QScriptEngine::checkSyntax):

6:26 AM Changeset in webkit [56332] by yurys@chromium.org

2 edits in trunk/WebKit/chromium

2010-03-22 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Fix inspected Page crash in destructor when Web Inspector is open.

https://bugs.webkit.org/show_bug.cgi?id=36441

src/js/InjectDispatch.js: (inspectedPageDestroyed): Added stub for missing method.

5:49 AM Changeset in webkit [56331] by Chris Jerdonek

2 edits
1 copy
1 add in trunk/WebKitTools

Created a function for getting a module-specific logging.logger
based on the file value of the module.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=35821

This function allows us to get the module-specific logger for
a module without having to hard-code the fully-qualified name
of the module in the module itself. The code can be the same
in every case: "_log = logutils.get_logger(file)".

Scripts/webkitpy/init/logutils.py: Added.
- Added a module with a get_logger() function to return a module-specific logger based on the module's file variable.

Scripts/webkitpy/init/logutils_unittest.py: Added.
- Added unit tests for logutils.py.

Scripts/webkitpy/init/unittests.py:
- Added logutils_unittest to the list of imports.

4:43 AM QtWebKitBackportingFixes edited by Simon Hausmann

(diff)

4:07 AM Changeset in webkit [56330] by eric@webkit.org

3 edits in trunk/WebKit/chromium

2010-03-22 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Added methods to WebSecurityOrigin for invoking
SecurityOrigin::canAccess and SecurityOrigin::Create
https://bugs.webkit.org/show_bug.cgi?id=36356

public/WebSecurityOrigin.h:
src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::create): (WebKit::WebSecurityOrigin::canAccess):

2:46 AM Changeset in webkit [56329] by yurys@chromium.org

8 edits
1 add in trunk

2010-03-22 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Handle worker exceptions in V8MessageHandler like it's done in regular documents. This way all worker exceptions will be logged in the console not only those which happen in event listeners.

https://bugs.webkit.org/show_bug.cgi?id=31171

bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler): Removed explicit call to reportException.
bindings/v8/V8Utilities.cpp: reportException function was removed since it's not used. (WebCore::getScriptExecutionContext):
bindings/v8/V8Utilities.h:
bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::v8MessageHandler): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Setup message handler when first worker context is created.

2010-03-22 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Test that uncaught exception thrown from setTimeout callback in a Worker is reported to the worker object.

https://bugs.webkit.org/show_bug.cgi?id=31171

fast/workers/resources/worker-exception-in-timeout-callback.js: Added.
fast/workers/worker-script-error-expected.txt:
fast/workers/worker-script-error.html:

2:43 AM Changeset in webkit [56328] by eric@webkit.org

4 edits in trunk

2010-03-22 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Hausmann.

[Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes
https://bugs.webkit.org/show_bug.cgi?id=36386

platform/qt/Skipped: unskip the test as it now passes.

2010-03-22 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Hausmann.

[Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes
https://bugs.webkit.org/show_bug.cgi?id=36386

Fix the regression by implementing a null printer for Qt DRT.

DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::NullPrinter::NullPaintEngine::begin): (WebCore::NullPrinter::NullPaintEngine::end): (WebCore::NullPrinter::NullPaintEngine::type): (WebCore::NullPrinter::NullPaintEngine::drawPixmap): (WebCore::NullPrinter::NullPaintEngine::updateState): (WebCore::NullPrinter::paintEngine): (WebCore::DumpRenderTree::dryRunPrint):

2:24 AM Changeset in webkit [56327] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Simon Hausmann.

Add EFL-specific code to page/EventHandler.cpp.
http://webkit.org/b/36306

page/EventHandler.cpp:

2:06 AM Changeset in webkit [56326] by eric@webkit.org

3 edits in trunk/WebCore

2010-03-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Simon Hausmann.

Add EFL-specific code to platform/DragImage.h and
platform/DragData.h.
http://webkit.org/b/36310

platform/DragImage.h:
platform/DragData.h:

1:45 AM Changeset in webkit [56325] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Simon Hausmann.

Add EFL-specific code to platform/FileSystem.h.
http://webkit.org/b/36313

platform/FileSystem.h:

1:26 AM Changeset in webkit [56324] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Simon Hausmann.

Add EFL-specific code to platform/Cursor.h.
http://webkit.org/b/36319

platform/Cursor.h:

1:05 AM Changeset in webkit [56323] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Simon Hausmann.

Add EFL-specific code to platform/NotImplemented.h.
http://webkit.org/b/36320

platform/NotImplemented.h:

Mar 21, 2010:

4:21 PM Changeset in webkit [56322] by eric@webkit.org

3 edits in trunk/WebKit/qt

2010-03-21 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Fixed updating the VKB display when inputting into QGraphicsWebView.
https://bugs.webkit.org/show_bug.cgi?id=36292

Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::_q_updateMicroFocus): (QGraphicsWebView::setPage):
Api/qgraphicswebview.h:

3:52 PM Changeset in webkit [56321] by eric@webkit.org

2 edits in trunk/WebCore

2010-03-21 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Simon Hausmann.

[Qt] GraphicsLayer: matrix interpolations in transform-animations don't behave correctly
https://bugs.webkit.org/show_bug.cgi?id=35520

The case where the list of source and target transform operations are
not the same but have the same size needs to be special-cased in
GraphicsLayerQt, as well as the case where the source or target
operation list is empty. The URLs listed here render correctly after
applying the patch.

Tests: https://bug-35520-attachments.webkit.org/attachment.cgi?id=49890

https://bug-35520-attachments.webkit.org/attachment.cgi?id=49889

platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::TransformAnimationQt::applyFrame):

3:30 PM Changeset in webkit [56320] by eric@webkit.org

7 edits
1 copy
2 adds in trunk/JavaScriptCore

2010-03-21 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

New class; QScriptProgram.

The class should be used to evaluate the same script multiple times
more efficiently.

[Qt] QtScript should have QScriptProgram class
https://bugs.webkit.org/show_bug.cgi?id=36008

qt/api/QtScript.pro:
qt/api/qscriptengine.cpp: (QScriptEngine::evaluate):
qt/api/qscriptengine.h:
qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::evaluate):
qt/api/qscriptengine_p.h: (QScriptEnginePrivate::evaluate):
qt/api/qscriptprogram.cpp: Added. (QScriptProgram::QScriptProgram): (QScriptProgram::~QScriptProgram): (QScriptProgram::operator=): (QScriptProgram::isNull): (QScriptProgram::sourceCode): (QScriptProgram::fileName): (QScriptProgram::firstLineNumber): (QScriptProgram::operator==): (QScriptProgram::operator!=):
qt/api/qscriptprogram.h: Added.
qt/api/qscriptprogram_p.h: Added. (QScriptProgramPrivate::get): (QScriptProgramPrivate::QScriptProgramPrivate): (QScriptProgramPrivate::~QScriptProgramPrivate): (QScriptProgramPrivate::isNull): (QScriptProgramPrivate::sourceCode): (QScriptProgramPrivate::fileName): (QScriptProgramPrivate::firstLineNumber): (QScriptProgramPrivate::operator==): (QScriptProgramPrivate::operator!=): (QScriptProgramPrivate::program): (QScriptProgramPrivate::file): (QScriptProgramPrivate::line):
qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::evaluateProgram):

3:19 PM Changeset in webkit [56319] by ddkilzer@apple.com

5 edits
2 adds in trunk

<http://webkit.org/b/14858> <col> width ignored when not tied to a single cell

Patch by Dmitry Gorbik <socket.h@gmail.com> on 2010-03-21
Reviewed by David Kilzer.

Fixed width calculation for cells with span when <col> is defined.

WebCore:

Test: fast/table/col-width-span-expand.html

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleOrColWidth): Added the calculation of cell width
in case of <col> defined and span > 1.

LayoutTests:

fast/table/col-width-span-expand-expected.txt: Added.
fast/table/col-width-span-expand.html: Added.

1:08 PM Changeset in webkit [56318] by ddkilzer@apple.com

3 edits in trunk/JavaScriptCore

Blind attempt #2 to fix the Windows build after r56314

API/tests/testapi.c: Include JSObjectRefPrivate.h for the new

methods instead of declaring them locally (and non-extern).

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Backed out previous change.

12:56 PM Changeset in webkit [56317] by ddkilzer@apple.com

2 edits in trunk/JavaScriptCore

Blind attempt to fix the Windows build after r56314

Try to fix the following errors on the Windows buildbot:

Linking...
testapi.obj : error LNK2001: unresolved external symbol "bool cdecl JSObjectSetPrivateProperty(struct OpaqueJSContext const *,struct OpaqueJSValue *,struct OpaqueJSString *,struct OpaqueJSValue const *)" (?JSObjectSetPrivateProperty@@YA_NPBUOpaqueJSContext@@PAUOpaqueJSValue@@PAUOpaqueJSString@@PBU2@@Z)
testapi.obj : error LNK2001: unresolved external symbol "struct OpaqueJSValue const * cdecl JSObjectGetPrivateProperty(struct OpaqueJSContext const *,struct OpaqueJSValue *,struct OpaqueJSString *)" (?JSObjectGetPrivateProperty@@YAPBUOpaqueJSValue@@PBUOpaqueJSContext@@PAU1@PAUOpaqueJSString@@@Z)
C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\bin\testapi.exe : fatal error LNK1120: 2 unresolved externals

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Added

missing symbols to be exported.

12:09 PM Changeset in webkit [56316] by Martin Robinson

4 edits in trunk

2010-03-20 Martin Robinson <Martin Robinson>

Reviewed by Xan Lopez

[GTK] eventSender.zoomPageOut() bug?
https://bugs.webkit.org/show_bug.cgi?id=30575

Unskip some tests that were failing because of the bug in DRT.

platform/gtk/Skipped:

2010-03-20 Martin Robinson <Martin Robinson>

Reviewed by Xan Lopez.

[GTK] eventSender.zoomPageOut() bug?
https://bugs.webkit.org/show_bug.cgi?id=30575

Make zoomPage{In/Out}Callback respect the 1.2f zoom factor that DRT should be using.

DumpRenderTree/gtk/EventSender.cpp: (zoomIn): Added. (zoomOut): Added. (textZoomInCallback): Use zoomIn helper function. (textZoomOutCallback): Use zoomOut helper function. (zoomPageInCallback): Use zoomIn helper function, which respects zoom factor. (zoomPageOutCallback): Use zoomOut helper function, which respects zoom factor.

5:22 AM QtWebKitPlugins edited by yael.aharon@nokia.com

(diff)

1:35 AM Changeset in webkit [56315] by oliver@apple.com

2 edits in trunk/JavaScriptCore

Documentation fix for previous patch.

Reviewed by Maciej Stachowiak.

API/JSObjectRefPrivate.h:

12:40 AM Changeset in webkit [56314] by oliver@apple.com

6 edits
1 add in trunk/JavaScriptCore

2010-03-20 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

JSC needs an API to allow custom objects to have aprivate GC-accessible properties
https://bugs.webkit.org/show_bug.cgi?id=36420

Add new API methods to support "private" properties on custom
objects.

API/JSCallbackObject.h: (JSC::JSCallbackObjectData::JSCallbackObjectData): (JSC::JSCallbackObjectData::~JSCallbackObjectData): (JSC::JSCallbackObjectData::getPrivateProperty): (JSC::JSCallbackObjectData::setPrivateProperty): (JSC::JSCallbackObjectData::deletePrivateProperty): (JSC::JSCallbackObjectData::markChildren): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::deletePrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::markChildren): (JSC::JSCallbackObject::getPrivateProperty): (JSC::JSCallbackObject::setPrivateProperty): (JSC::JSCallbackObject::deletePrivateProperty): (JSC::JSCallbackObject::markChildren):
API/JSObjectRef.cpp: (JSObjectGetPrivateProperty): (JSObjectSetPrivateProperty): (JSObjectDeletePrivateProperty):
API/JSObjectRefPrivate.h: Added.
API/tests/testapi.c: (main):
JavaScriptCore.exp:
JavaScriptCore.xcodeproj/project.pbxproj:

Mar 20, 2010:

7:45 PM Changeset in webkit [56313] by kevino@webkit.org

2 edits in trunk/WebKitTools

[wx] Build fix after recent database API change.

5:39 PM Changeset in webkit [56312] by eric@webkit.org

4 edits in trunk/WebKitTools

2010-03-20 Chris Jerdonek <Chris Jerdonek>

Reviewed by Adam Barth.

Renamed UnitTestLogStream to TestLogStream in webkitpy.

https://bugs.webkit.org/show_bug.cgi?id=36099

TestLogStream is more concise and more consistent with the name of
the module (logtesting rather than logunittesting) and its main
class (LogTesting rather than LogUnitTesting).

Scripts/webkitpy/init/logtesting.py:
- Renamings.

Scripts/webkitpy/style/checker_unittest.py:
- Renamings.

Scripts/webkitpy/style_references.py:
- Renamings.

3:20 PM Changeset in webkit [56311] by tonikitoo@webkit.org

3 edits in trunk/WebCore

Spatial Navigation: Code simplification in FocusController.cpp and SpatialNavigation.cpp (part I)
https://bugs.webkit.org/show_bug.cgi?id=36168

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

Make use of isNull and document methods introduced in FocusCandidate class by patch in bug 36167.
No functionalty change.

page/FocusController.cpp:

(WebCore::updateFocusCandidateIfCloser):

page/SpatialNavigation.cpp:

(WebCore::distanceInDirection):

2:00 PM Changeset in webkit [56310] by dpranke@chromium.org

1 edit in trunk/WebKitTools/ChangeLog

2010-03-20 Dirk Pranke <dpranke@chromium.org>

Unreviewed change.

Fix typo in Changelog.

WebKitTools/ChangeLog:

1:05 PM Changeset in webkit [56309] by kevino@webkit.org

15 edits in trunk

[wx] Build fixes after recent changes.

12:21 PM Changeset in webkit [56308] by Dimitri Glazkov

2 edits
1 delete in trunk/LayoutTests

Unreviewed, expectations tweak.

Remove expectations for chromium-mac editing/style/apply-through-end-of-document.html as it
now matches platform/mac.

platform/chromium-mac/editing/style/apply-through-end-of-document-expected.txt: Removed.
platform/chromium/test_expectations.txt: Adjusted expectations.

12:10 PM Changeset in webkit [56307] by Dimitri Glazkov

2 edits in trunk/WebKitTools

Unreviewed, tool fix.

Remove vestiges of downstream directory names to unbreak rebaselining tool.

Scripts/webkitpy/layout_tests/port/chromium.py: Changed paths to use WebKit repo.

10:21 AM Changeset in webkit [56306] by Dimitri Glazkov

2 edits in trunk/WebKitTools

2010-03-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Re-enable the downstream test_expectations overrides file that was
disabled in bug 36396 / r56287.

https://bugs.chromium.org/show_bug.cgi?id=36401

Scripts/webkitpy/layout_tests/port/chromium.py:

10:14 AM Changeset in webkit [56305] by Dimitri Glazkov

2 edits in trunk/LayoutTests

Unreviewed, expectations tweak.

Mark editing/style/apply-through-end-of-document.html as failing

platform/chromium/test_expectations.txt:

9:56 AM Changeset in webkit [56304] by Dimitri Glazkov

2 edits in trunk/LayoutTests

Unreviewed, expectations tweak.

Marked svg/filters/filterRes.svg as failing after
http://trac.webkit.org/changeset/56288/

platform/chromium/test_expectations.txt: Added expectations for svg/filters/filterRes.svg.

9:31 AM Changeset in webkit [56303] by Dimitri Glazkov

4 edits
4 deletes in trunk/WebKit/chromium

2010-03-20 Dimitri Glazkov <Dimitri Glazkov>

No review, rolling out r56294.
http://trac.webkit.org/changeset/56294
https://bugs.webkit.org/show_bug.cgi?id=36262

Broke compile on Chromium canaries.

WebKit.gyp:
public/WebGraphicsContext3D.h: Removed.
public/WebKitClient.h:
src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::): (WebCore::GraphicsContext3DInternal::GLConnection::chooseFBConfig): (WebCore::GraphicsContext3DInternal::GLConnection::createNewContext): (WebCore::GraphicsContext3DInternal::GLConnection::createPbuffer): (WebCore::GraphicsContext3DInternal::GLConnection::destroyPbuffer): (WebCore::GraphicsContext3DInternal::GLConnection::makeCurrent): (WebCore::GraphicsContext3DInternal::GLConnection::destroyContext): (WebCore::GraphicsContext3DInternal::GLConnection::getCurrentContext): (WebCore::GraphicsContext3DInternal::GLConnection::GLConnection): (WebCore::GraphicsContext3DInternal::GLConnection::create): (WebCore::GraphicsContext3DInternal::GLConnection::~GLConnection): (WebCore::GraphicsContext3DInternal::VertexAttribPointerState::VertexAttribPointerState): (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::makeContextCurrent): (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D): (WebCore::GraphicsContext3DInternal::platformTexture): (WebCore::createTextureObject): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::flipVertically): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::activeTexture): (WebCore::GraphicsContext3DInternal::bindBuffer): (WebCore::GraphicsContext3DInternal::bindFramebuffer): (WebCore::GraphicsContext3DInternal::bindTexture): (WebCore::GraphicsContext3DInternal::bufferDataImpl): (WebCore::GraphicsContext3DInternal::disableVertexAttribArray): (WebCore::GraphicsContext3DInternal::enableVertexAttribArray): (WebCore::GraphicsContext3DInternal::getError): (WebCore::GraphicsContext3DInternal::getContextAttributes): (WebCore::GraphicsContext3DInternal::vertexAttribPointer): (WebCore::GraphicsContext3DInternal::viewportImpl): (WebCore::GraphicsContext3DInternal::synthesizeGLError): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::makeContextCurrent): (WebCore::GraphicsContext3D::reshape): (WebCore::GraphicsContext3D::beginPaint): (WebCore::GraphicsContext3D::endPaint): (WebCore::GraphicsContext3D::sizeInBytes): (WebCore::GraphicsContext3D::createBuffer): (WebCore::GraphicsContext3D::createFramebuffer): (WebCore::GraphicsContext3D::createProgram): (WebCore::GraphicsContext3D::createRenderbuffer): (WebCore::GraphicsContext3D::createShader): (WebCore::GraphicsContext3D::createTexture): (WebCore::GraphicsContext3D::deleteBuffer): (WebCore::GraphicsContext3D::deleteFramebuffer): (WebCore::GraphicsContext3D::deleteProgram): (WebCore::GraphicsContext3D::deleteRenderbuffer): (WebCore::GraphicsContext3D::deleteShader): (WebCore::GraphicsContext3D::deleteTexture): (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData): (WebCore::GraphicsContext3D::checkFramebufferStatus): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::disableVertexAttribArray): (WebCore::GraphicsContext3D::drawArrays): (WebCore::GraphicsContext3D::drawElements): (WebCore::GraphicsContext3D::enableVertexAttribArray): (WebCore::GraphicsContext3D::generateMipmap): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::getBooleanv): (WebCore::GraphicsContext3D::getBufferParameteriv): (WebCore::GraphicsContext3D::getContextAttributes): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::getFloatv): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv): (WebCore::GraphicsContext3D::getIntegerv): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getRenderbufferParameteriv): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getShaderSource): (WebCore::GraphicsContext3D::getString): (WebCore::GraphicsContext3D::getTexParameterfv): (WebCore::GraphicsContext3D::getTexParameteriv): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation): (WebCore::GraphicsContext3D::getVertexAttribfv): (WebCore::GraphicsContext3D::getVertexAttribiv): (WebCore::GraphicsContext3D::getVertexAttribOffset): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isEnabled): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::pixelStorei): (WebCore::GraphicsContext3D::readPixels): (WebCore::GraphicsContext3D::releaseShaderCompiler): (WebCore::GraphicsContext3D::shaderSource): (WebCore::GraphicsContext3D::synthesizeGLError): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D): (WebCore::GraphicsContext3D::uniform1fv): (WebCore::GraphicsContext3D::uniform1iv): (WebCore::GraphicsContext3D::uniform2fv): (WebCore::GraphicsContext3D::uniform2iv): (WebCore::GraphicsContext3D::uniform3fv): (WebCore::GraphicsContext3D::uniform3iv): (WebCore::GraphicsContext3D::uniform4fv): (WebCore::GraphicsContext3D::uniform4iv): (WebCore::GraphicsContext3D::uniformMatrix2fv): (WebCore::GraphicsContext3D::uniformMatrix3fv): (WebCore::GraphicsContext3D::uniformMatrix4fv): (WebCore::GraphicsContext3D::vertexAttrib1fv): (WebCore::GraphicsContext3D::vertexAttrib2fv): (WebCore::GraphicsContext3D::vertexAttrib3fv): (WebCore::GraphicsContext3D::vertexAttrib4fv): (WebCore::GraphicsContext3D::vertexAttribPointer): (WebCore::GraphicsContext3D::viewport):
src/WebGraphicsContext3D.cpp: Removed.
src/WebGraphicsContext3DDefaultImpl.cpp: Removed.
src/WebGraphicsContext3DDefaultImpl.h: Removed.

2:07 AM Changeset in webkit [56302] by mjs@apple.com

4 edits in trunk/WebKitSite

2010-03-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

WebKit blog should be valid HTML5
https://bugs.webkit.org/show_bug.cgi?id=36410

blog/wp-content/themes/webkit/comments-popup.php:
blog/wp-content/themes/webkit/footer.php:
blog/wp-content/themes/webkit/header.php:

2:04 AM Changeset in webkit [56301] by Joseph Pecoraro

3 edits in trunk/WebCore

2010-03-20 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Assertion failure in media/video-controls-with-mutation-event-handler.html
https://bugs.webkit.org/show_bug.cgi?id=36376

Test: media/video-controls-with-mutation-event-handler.html

Break early (when not attached) in the defaultEventHandler before the
slider is completely set up.

rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::defaultEventHandler): (WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
rendering/RenderMedia.cpp: (WebCore::RenderMedia::createVolumeSlider):

1:12 AM Changeset in webkit [56300] by mjs@apple.com

24 edits in trunk/WebKitSite

2010-03-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

Fix a bunch of HTML5 validation errors on various pages.
https://bugs.webkit.org/show_bug.cgi?id=36409

building/build.html:
building/checkout.html:
building/debug.html:
building/run.html:
building/tools.html:
coding/coding-style.html:
coding/contributing.html:
coding/major-objects.html:
css/main.css: (.asciiart):
demos/index.html:
header.inc:
projects/compat/index.html:
projects/css/index.html:
projects/documentation/index.html:
projects/goals.html:
projects/index.html:
projects/mathml/index.html:
quality/bugpriorities.html:
quality/bugwriting.html:
quality/crashlogs.html:
quality/lifecycle.html:
quality/testing.html:
quality/testwriting.html:

12:24 AM Changeset in webkit [56299] by mjs@apple.com

6 edits in trunk/WebKitSite

2010-03-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

webkit.org should use the HTML5 doctype
https://bugs.webkit.org/show_bug.cgi?id=36407

header.inc:
misc/drosera/index.html:
perf/slickspeed/system/index.php:
perf/slickspeed/system/template.php:
specs/index.html:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed