Timeline
May 5, 2010:
- 11:54 PM Changeset in webkit [58867] by
-
- 14 edits4 adds in trunk
2010-05-05 Charles Wei <charles.wei@torchmobile.com.cn>
Reviewed by George Staikos
https://bugs.webkit.org/show_bug.cgi?id=37848
Add test cases for -wap-input-format and -wap-input-required of WCSS
- fast/wcss/wap-input-format-expected.txt: Added.
- fast/wcss/wap-input-format.xhtml: Added.
- fast/wcss/wap-input-required-expected.txt: Added.
- fast/wcss/wap-input-required.xhtml: Added.
2010-05-05 Charles Wei <charles.wei@torchmobile.com.cn>
Reviewed by George Staikos
https://bugs.webkit.org/show_bug.cgi?id=37848
This patch adds WCSS -wap-input-format and -wap-input-required support to WebKit
Tests: fast/wcss/wap-input-format.xhtml
fast/wcss/wap-input-required.xhtml
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseWCSSInputProperty):
- css/CSSParser.h:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- css/WCSSPropertyNames.in:
- dom/InputElement.cpp: (WebCore::InputElement::sanitizeValue): (WebCore::InputElement::handleBeforeTextInsertedEvent): (WebCore::InputElementData::InputElementData): (WebCore::formatCodes): (WebCore::cursorPositionToMaskIndex): (WebCore::InputElement::isConformToInputMask): (WebCore::InputElement::validateInputMask):
- dom/InputElement.h: (WebCore::InputElementData::inputFormatMask): (WebCore::InputElementData::setInputFormatMask): (WebCore::InputElementData::maxInputCharsAllowed): (WebCore::InputElementData::setMaxInputCharsAllowed):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setWapInputFormat):
- html/HTMLInputElement.h: (WebCore::HTMLInputElement::data):
- wml/WMLInputElement.h: (WebCore::WMLInputElement::data):
2010-05-05 Charles Wei <charles.wei@torchmobile.com.cn>
Reviewed by George Staikos
This patch adds WCSS -wap-input-format and -wap-input-required support to WebKit
Make the test cases in fast/wcss optionional only when WCSS is enabled.
- Scripts/old-run-webkit-tests:
- Scripts/webkitperl/features.pm:
- 11:23 PM Changeset in webkit [58866] by
-
- 2 edits in trunk/LayoutTests
2010-05-05 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
[GTK] Markup of copied non ASCII characters is broken
https://bugs.webkit.org/show_bug.cgi?id=37918
This test was fixed by http://trac.webkit.org/changeset/58468
- platform/gtk/Skipped:
- 11:06 PM Changeset in webkit [58865] by
-
- 2 edits in trunk/WebKit/mac
Fixed a crash when closing Top Sites after r58847.
Reviewed by Mark Rowe.
- WebView/WebFrameView.mm:
(-[WebFrameView webFrame]): Null-check _private.
- 11:02 PM Changeset in webkit [58864] by
-
- 6 edits in trunk/WebCore
2010-05-05 MORITA Hajime <morrita@google.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=38150
Refactoring: webkitEditableContentChangedEvent should be handled by the owner of appropriate the renderer.
Moved a part of code chunk in HTMLFormControlElementWithState::defaultEventHandler()
which accesses the renderer from foreign node,
to TextControlInnerTextElement::defaultEventHandler() which owns the renderer.
No new tests. No behavioral change.
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElementWithState::defaultEventHandler):
- html/HTMLFormControlElement.h:
- html/HTMLInputElement.h:
- html/HTMLTextAreaElement.h:
- rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerTextElement::defaultEventHandler):
- 10:47 PM Changeset in webkit [58863] by
-
- 2 edits in trunk/LayoutTests
[Qt] Enable Sputnik tests.
https://bugs.webkit.org/show_bug.cgi?id=38457
Rubber-stamped by Alexey Proskuryakov.
- platform/qt/Skipped: Only skip tests that fail.
- 10:40 PM Changeset in webkit [58862] by
-
- 3 edits in trunk/WebKitTools
2010-05-05 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
[DRT/Chromium] Remove InitWebCoreSystemInterface() call
https://bugs.webkit.org/show_bug.cgi?id=38624
Chromium r45167 <http://src.chromium.org/viewvc/chrome?view=rev&revision=45167>
added InitWebCoreSystemInterface() to webkit/support/platform_support_mac.mm.
So we don't need to call it from DumpRenderTree.cpp anymore.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/chromium/DumpRenderTree.cpp: (main): Remove InitWebCoreSystemInterface().
- 10:34 PM Changeset in webkit [58861] by
-
- 3 edits1 delete in trunk/LayoutTests
2010-05-05 Steven Lai <steven_lai@asia.apple.com>
Reviewed by Alexey Proskuryakov.
Remove platform specific test result
Don't print the formatted string of the z-index in the test case
since there's a risk that the output on different c stdlib implementations/platforms/locale could be different
https://bugs.webkit.org/show_bug.cgi?id=38617.
- fast/dom/clone-node-z-index-expected.txt:
- fast/dom/clone-node-z-index.html:
- platform/win/fast/dom/clone-node-z-index-expected.txt: Removed.
- 10:23 PM Changeset in webkit [58860] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-05-05 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Add a test of URL segmentation from a data URL base
https://bugs.webkit.org/show_bug.cgi?id=38606
As requested by Alexey. These tests find some interesting behavior in
both KURL and GURL. We'll need to go through them in more detail later
to understand what the right behavior is.
- fast/url/script-tests/segments-from-data-url.js: Added.
- fast/url/segments-from-data-url-expected.txt: Added.
- fast/url/segments-from-data-url.html: Added.
- 10:11 PM Changeset in webkit [58859] by
-
- 2 edits6 adds in trunk/LayoutTests
2010-05-05 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Add a test of URL segmentation
https://bugs.webkit.org/show_bug.cgi?id=38600
These tests are based on URLParser.Standard from
http://code.google.com/p/google-url/source/browse/trunk/src/url_parse_unittest.cc
- fast/url/resources/utilities.js:
(canonicalize):
- I changed this to use deterministic IDs because (theoretically) the old way was flaky in case the IDs collided.
(segments):
- Here we're using HTMLAnchorElement's attributes to infer the internal segmentation. Unforunately, there don't seem to be accessors for usernames and passwords of URLs.
- fast/url/script-tests/segments.js: Added.
- I'm not 100% sure all the test cases here represent the intent of the original test author. The tricky bit is we don't have a good way to test absolute URL parsing from the web platform, which means a bunch of these become tests of how we handle relative URLs. However, I'm not one to turn down more test cases.
- fast/url/script-tests/trivial-segments.js: Added.
- This is more of a test of the testing harness to make sure its working properly when running on other browsers.
- fast/url/segments-expected.txt: Added.
- fast/url/trivial-segments-expected.txt: Added.
- As usual, these have their "PASS" expectations set to the Chromium behavior but have their -expected.txt set to the normal WebKit behavior, letting us track differences between the two.
- fast/url/segments.html: Added.
- fast/url/trivial-segments.html: Added.
- 9:50 PM Changeset in webkit [58858] by
-
- 2 edits in trunk/JavaScriptCore
2010-05-05 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Adding comment with link to RefPtr documentation.
https://bugs.webkit.org/show_bug.cgi?id=38601
- wtf/RefPtr.h:
- 9:28 PM Changeset in webkit [58857] by
-
- 2 edits in trunk/WebCore
2010-05-05 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: Line Numbers should be Aligned with the Source Code Line
https://bugs.webkit.org/show_bug.cgi?id=38593
If there is a message bubble, such as an error message, in a source view
the line number should be in line with the source code line, not centered
between the source and bubble.
- inspector/front-end/textViewer.css: (.webkit-line-number): added vertical-align: top
- 8:16 PM Changeset in webkit [58856] by
-
- 2 edits in trunk/WebKit/mac
Fixed test crashes after r58847.
Rubber-stamped by Mark Rowe.
- WebView/WebHTMLView.mm:
(setNeedsDisplayInRect): Null-check the frame.
- 6:51 PM Changeset in webkit [58855] by
-
- 2 edits in trunk/LayoutTests
2010-05-05 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
- platform/chromium/test_expectations.txt:
- 6:36 PM Changeset in webkit [58854] by
-
- 3 edits in trunk/WebCore
Fix the decelerated compositing build.
- page/FrameView.cpp:
(WebCore::FrameView::isEnclosedInCompositingLayer):
- page/FrameView.h:
- 6:33 PM Changeset in webkit [58853] by
-
- 6 edits3 adds in trunk/WebKitTools
2010-05-05 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
new-run-webkit-tests: clean up newline handling in printing
The new printing module seems to handle newlines somewhat
inconsistently, especially in --verbose mode. This change cleans up
the code to make things more consistent and adds a bunch of unit tests.
- Scripts/webkitpy/common/array_stream.py: Added.
- Scripts/webkitpy/common/array_stream_unittest.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
- Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/printing.py:
- Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 6:12 PM Changeset in webkit [58852] by
-
- 3 edits in trunk/WebKitTools
2010-05-05 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Ban the single letter 'l' as an identifier name
http://trac.webkit.org/changeset/58844
Add a lint rule to ban the single letter 'l' as an identifier name
since it is very easy to confuse with the numeral '1', especially
in code like WebCore/css/CSSHelper.cpp.
See http://trac.webkit.org/changeset/58844 as an example of a bug
caused by confusing short variable names.
- Scripts/webkitpy/style/checkers/cpp.py:
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
- 6:08 PM Changeset in webkit [58851] by
-
- 9 edits in trunk
Bug 38604 - workers-gc2 crashing on Qt
Reviewed by Darin Adler.
This appears to be due to a couple of issues.
(1) When the atomic string table is deleted it does not clear the 'inTable' bit
on AtomicStrings - it implicitly assumes that all AtomicStrings have already
been deleted at this point (otherwise they will crash in their destructor when
they try to remove themselves from the atomic string table).
(2) We don't fix the ordering in which WTF::WTFThreadData and
WebCore::ThreadGlobalData are destructed.
We should make sure that ThreadGlobalData is cleaned up before worker threads
terminate and WTF::WTFThreadData is destroyed, and we should clear the inTable
bit of members on atomic string table destruction.
WTF changes (fix issue 1, above) - ensure inTable property is cleared when the
atomic string table is destroyed (also, rename InTable to IsAtomic, to make it
clear which table we are refering to!)
- wtf/text/AtomicString.cpp:
(WebCore::AtomicStringTable::destroy):
(WebCore::CStringTranslator::translate):
(WebCore::UCharBufferTranslator::translate):
(WebCore::HashAndCharactersTranslator::translate):
(WebCore::AtomicString::add):
- wtf/text/StringImpl.cpp:
(WebCore::StringImpl::~StringImpl):
- wtf/text/StringImpl.h:
(WebCore::StringImpl::isAtomic):
(WebCore::StringImpl::setIsAtomic):
- wtf/text/StringImplBase.h:
WebCore:
WTF changes (fix issue 2, above) - clean up the thread data on worker termination.
- platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::~ThreadGlobalData):
(WebCore::ThreadGlobalData::destroy):
- platform/ThreadGlobalData.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
- 6:05 PM Changeset in webkit [58850] by
-
- 1 edit1 add in trunk/LayoutTests
Add Windows-specific results for clone-node-z-index.html. The difference in results is harmless (the number is the same),
but the difference is being tracked by https://bugs.webkit.org/show_bug.cgi?id=38617.
Rubber-stamped by Mark Rowe.
- platform/win/fast/dom/clone-node-z-index-expected.txt: Added.
- 5:53 PM Changeset in webkit [58849] by
-
- 8 edits in branches/audio/WebCore/audio
Fix problems with node disconnection
- add notifyInputConnection() method to AudioNode
- 5:53 PM Changeset in webkit [58848] by
-
- 2 edits in branches/audio/WebCore/audio
Cleanup AudioContext - clarify memory management a little bit
- 5:37 PM Changeset in webkit [58847] by
-
- 10 edits1 move4 adds in trunk
<rdar://problem/7932072> Iframes in composited layers don’t repaint correctly (affects Yahoo! Mail with Flash Player 10.1)
https://bugs.webkit.org/show_bug.cgi?id=38427
Reviewed by Simon Fraser.
WebCore:
Test: compositing/iframes/iframe-in-composited-layer.html
- WebCore.base.exp: Export FrameView::isEnclosedInCompositingLayer().
- page/FrameView.cpp:
(WebCore::FrameView::isEnclosedInCompositingLayer): Added this predicate.
- page/FrameView.h:
WebKit:
- WebKit.xcodeproj/project.pbxproj: Renamed WebClipView.m to WebClipView.mm and changed it to
Objective-C++.
WebKit/mac:
- WebView/WebClipView.m: Renamed to WebClipView.mm.
- WebView/WebClipView.mm:
(-[WebClipView visibleRect]): Added this override, which for instances used for WebFrameViews in
composited layers, returns the clip view’s entire bounds. This prevents drawing from being clipped to
AppKit’s idea of what part of the view would be visible if it was drawn as part of the view hierarchy.
Since it is drawn into a compositing layer, that’s irrelevant, and we should not be clipping.
- WebView/WebHTMLView.mm:
(setCursor): Style tweak.
(setNeedsDisplayInRect): Added. Replaces the default implementation of -[NSView setNeedsDisplayInRect:],
so that if the receiver is a descendant of a WebFrameView that draws into a composited layer, the invalidation
is routed back through the WebCore FrameView, which propagates it to the layer.
(+[WebHTMLViewPrivate initialize]): Swizzle the setNeedsDisplayInRect: override in.
(-[WebHTMLView visibleRect]): Removed whitespace.
- WebView/WebView.mm:
(layerSyncRunLoopObserverCallBack): If we bailed out on syncing, due to pending layout, do an eager layout
in preparation for the displaying of compositing layers.
LayoutTests:
- compositing/iframes/iframe-in-composited-layer.html: Added.
- platform/mac/compositing/iframes/iframe-in-composited-layer-expected.checksum: Added.
- platform/mac/compositing/iframes/iframe-in-composited-layer-expected.png: Added.
- platform/mac/compositing/iframes/iframe-in-composited-layer-expected.txt: Added.
- 5:20 PM Changeset in webkit [58846] by
-
- 2 edits in trunk/WebKit/mac
<rdar://problem/7942606> Output appears in Console when exiting Safari with multiple windows opened
Reviewed by Mark Rowe.
- WebView/WebView.mm:
(+[WebView closeAllWebViews]):
Make copy of allWebViewsSet to avoid mutating it while iterating through it.
- 5:02 PM Changeset in webkit [58845] by
-
- 3 edits4 adds in trunk
2010-05-05 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Got composited iframes showing up on Mac again
https://bugs.webkit.org/show_bug.cgi?id=38565
This was broken by http://trac.webkit.org/changeset/58798. That
change connected iframes through the parent document to the root
of the layer tree. That is correct for Windows, but not for Mac.
So the places where the linkage is made were wrapped in
shouldPropagateCompositingToIFrameParent() calls, which is
always false for Mac.
Test: compositing/iframes/composited-iframe-alignment.html
- rendering/RenderLayerCompositor.cpp:Avoid doing composited iframe linkage on Mac (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): (WebCore::RenderLayerCompositor::didMoveOnscreen): (WebCore::RenderLayerCompositor::willMoveOffscreen): (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
- 4:24 PM Changeset in webkit [58844] by
-
- 3 edits2 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=38260
<rdar://problem/7917548> Fix whitespace removing in deprecatedParseURL().
Broken all the way since r4 (yes, that's a revision number).
Test: http/tests/security/xss-DENIED-javascript-with-spaces.html
- css/CSSHelper.cpp: (WebCore::deprecatedParseURL): Fixed loop conditions for remaining length.
- 4:12 PM Changeset in webkit [58843] by
-
- 5 edits2 adds in trunk
Many AXUnknown showing up in the hierarchy
https://bugs.webkit.org/show_bug.cgi?id=38607
Reviewed by Beth Dakin.
WebCore:
The RenderTableSection should not be an accessible element.
Test: platform/mac/accessibility/parent-of-table-row-is-table.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
LayoutTests:
- platform/mac-leopard/Skipped:
- platform/mac-tiger/Skipped:
- platform/mac/accessibility/parent-of-table-row-is-table-expected.txt: Added.
- platform/mac/accessibility/parent-of-table-row-is-table.html: Added.
- 3:59 PM Changeset in webkit [58842] by
-
- 2 edits in trunk/WebCore
[Qt]Disable Qt Multimedia backend for HTML 5 Audio and Video elements
Fall back to the Phonon backend until the release situation has been cleared up.
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=38612
Buildfix for QT_VERSION >= 0x040700 after r58810.
- platform/graphics/MediaPlayer.cpp:
- 3:42 PM Changeset in webkit [58841] by
-
- 9 edits3 adds in trunk
XMLHttpRequestUpload events do not fire when sending a raw file or FormData object.
https://bugs.webkit.org/show_bug.cgi?id=37771
Reviewed by David Levin.
WebCore:
Test: http/tests/local/formdata/upload-events.html
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
LayoutTests:
Add a layout test to test upload events firing.
- http/tests/local/formdata/resources/send-form-data-common.js:
(dumpResponse):
(sendFormData):
(testSendingFormData):
- http/tests/local/formdata/script-tests/send-form-data-with-sliced-file.js:
- http/tests/local/formdata/script-tests/send-form-data.js:
- http/tests/local/formdata/script-tests/upload-events.js: Added.
- http/tests/local/formdata/upload-events-expected.txt: Added.
- http/tests/local/formdata/upload-events.html: Added.
- platform/gtk/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in gtk platform.
- platform/qt/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in qt platform.
- platform/win/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in win platform.
- 3:28 PM Changeset in webkit [58840] by
-
- 2 edits in trunk/WebCore
[Qt] Qt port should use its own QUuid class to create UUID string.
https://bugs.webkit.org/show_bug.cgi?id=38581
Reviewed by Simon Hausmann.
- platform/UUID.cpp:
(WebCore::createCanonicalUUIDString): Added PLATFORM(QT) case.
- 2:51 PM Changeset in webkit [58839] by
-
- 11 edits in trunk/WebKit/chromium
2010-05-05 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] clear out deprecated methods that are no longer used
https://bugs.webkit.org/show_bug.cgi?id=38610
- public/WebFormElement.h:
- public/WebInputElement.h:
- public/WebKitClient.h:
- public/WebView.h:
- public/WebViewClient.h: (WebKit::WebViewClient::createPopupMenu):
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::popupOpened):
- src/WebFormElement.cpp:
- src/WebInputElement.cpp: (WebKit::WebInputElement::setSelectionRange):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::hideSuggestionsPopup):
- src/WebViewImpl.h:
- 2:16 PM QtWebKitTriageRoster edited by
- (diff)
- 1:16 PM Changeset in webkit [58838] by
-
- 2 edits in trunk/LayoutTests
2010-05-05 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations fix.
Update expectations with tests that are now passing (possibly flaky?).
- platform/chromium/test_expectations.txt:
- 1:06 PM Changeset in webkit [58837] by
-
- 2 edits in trunk/LayoutTests
2010-05-05 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations fix.
Mark svg/custom/mask-changes.svg and http/tests/loading/bad-scheme-subframe.html as failing on Chromium Linux until they can be triaged.
- platform/chromium/test_expectations.txt:
- 12:19 PM Changeset in webkit [58836] by
-
- 3 edits4 deletes in trunk
Roll out r58830 for breaking tests.
Was: https://bugs.webkit.org/show_bug.cgi?id=38546
Node.focus() fails to move focus from subframe properly
- 12:11 PM Changeset in webkit [58835] by
-
- 2 edits in branches/audio/WebCore/audio
Call to pull() must take return value into account for non-inplace case
- 12:11 PM Changeset in webkit [58834] by
-
- 1 edit in branches/audio/WebCore/audio/AudioBufferSourceNode.cpp
Audio buffer source node needs default number of channels
- 12:10 PM Changeset in webkit [58833] by
-
- 2 edits in branches/audio/WebCore/audio
Keep track of mixer input availability
- 11:52 AM Changeset in webkit [58832] by
-
- 12 edits2 adds in trunk/WebCore
Implement FileReader class.
https://bugs.webkit.org/show_bug.cgi?id=38157
Reviewed by Adam Barth.
This patch only contains the implementation of FileReader class as defined
in the File API spec: http://www.w3.org/TR/file-upload/#dfn-filereader.
New test will be added when a IDL is exposed and the FILE_READER is turned
on.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/EventNames.h:
- dom/EventTarget.cpp:
(WebCore::EventTarget::toFileReader):
- dom/EventTarget.h:
- html/FileError.h:
(WebCore::FileError::FileError):
- html/FileReader.cpp: Added.
- html/FileReader.h: Added.
- html/FileStream.cpp:
(WebCore::FileStream::FileStream):
(WebCore::FileStream::openForRead):
(WebCore::FileStream::close):
(WebCore::FileStream::read):
- html/FileStream.h:
- 11:35 AM Changeset in webkit [58831] by
-
- 2 edits in trunk/WebCore
2010-05-05 Steve Falkenburg <sfalken@apple.com>
Reviewed by Maciej Stachowiak.
REGRESSION(r57969) Image decoder is repeatedly destroyed/created in CoreGraphics-based Windows WebKit
https://bugs.webkit.org/show_bug.cgi?id=38595
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::setData):
- 11:26 AM Changeset in webkit [58830] by
-
- 3 edits4 adds in trunk
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=38546
Node.focus() fails to move focus from subframe properly
Test: fast/frames/take-focus-from-iframe.html
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setFocus): Don't clear focus if this frame doesn't have it. This can happen if page's and HTMLFrameElement's ideas of focused frame get out of sync temporarily.
- 11:24 AM How to CC yourself on (or make other changes to) many bugs at once created by
- Initial version
- 11:20 AM WikiStart edited by
- (diff)
- 11:17 AM Changeset in webkit [58829] by
-
- 2 edits1 add in trunk/WebCore
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=26824
<rdar://problem/7018610> EventHandler can operate on a wrong frame if focus changes during
keyboard event dispatch.
EventHandler object is tied to a frame, so it's wrong for it to continue processing a keyboard
event if focused frame changes between keydown and keypress.
- manual-tests/focus-change-between-key-events.html: Added.
- page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Bail out early if focused frame changes while dispatching keydown. Also made similar changes for Windows to maintain matching behavior, even though EventHandler was re-entered anyway due to WM_KEYDOWN and WM_CHAR being separate events.
- 11:14 AM Changeset in webkit [58828] by
-
- 3 edits in trunk/WebKit/chromium
2010-05-05 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
[chromium] Add quota parameter to WebStorageNamespace::createSessionStorageNamespace
https://bugs.webkit.org/show_bug.cgi?id=38589
- public/WebStorageNamespace.h: (WebKit::WebStorageNamespace::createSessionStorageNamespace):
- src/WebStorageNamespaceImpl.cpp: (WebKit::WebStorageNamespace::createSessionStorageNamespace):
- 10:53 AM Changeset in webkit [58827] by
-
- 2 edits in trunk/WebKitSite
2010-05-05 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Adam Barth.
Commit and Review policy should encourage unofficial reviews
https://bugs.webkit.org/show_bug.cgi?id=38517
- coding/commit-review-policy.html:
- 10:20 AM Changeset in webkit [58826] by
-
- 2 edits in trunk/WebCore
2010-05-05 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
MediaError.h is missing PassRefPtr.h include
https://bugs.webkit.org/show_bug.cgi?id=38575
No new tests, build fix only.
- html/MediaError.h:
- 10:06 AM Changeset in webkit [58825] by
-
- 2 edits in trunk/WebCore
2010-05-05 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Audits panel: Resource counters get reset when switching panels while reloading page
https://bugs.webkit.org/show_bug.cgi?id=38579
- inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype.updateResourceTrackingState): (WebInspector.AuditLauncherView.prototype._updateResourceProgress):
- 10:03 AM Changeset in webkit [58824] by
-
- 2 edits in trunk/JavaScriptCore
2010-05-05 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make Array.join specialised for actual arrays
https://bugs.webkit.org/show_bug.cgi?id=38592
Bring Array.join in line with the other array methods by specialising for
this === an array.
- runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncJoin):
- 9:48 AM Changeset in webkit [58823] by
-
- 2 edits in trunk/WebCore
2010-05-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: Doubleclick on line number should not trigger source editing.
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._handleDoubleClick):
- 9:30 AM Changeset in webkit [58822] by
-
- 2 edits in trunk/WebCore
2010-05-05 Martin Robinson <Martin Robinson>
Reviewed by Gustavo Noronha.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Add support in the PasteboardHelper for images, in preparation for drag-and-drop data.
No new tests as functionality has not changed.
- platform/gtk/PasteboardHelper.cpp: (WebCore::PasteboardHelper::fillSelectionData): Add support for images here. (WebCore::PasteboardHelper::targetListForDataObject): Add support for images here.
- 9:22 AM Changeset in webkit [58821] by
-
- 26 edits in trunk
2010-05-05 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Darin Fisher.
Add a "focused" parameter to Widget::setFocus, and updates Document
so that Widget is informed of focus loss as well as focus gain.
Changes all existing setFocus implementations so that they ignore
the 'false' case, so no behavior is changed until individual
platforms are updated to handle the new case (if they want to).
- dom/Document.cpp: (WebCore::Document::setFocusedNode):
- platform/Widget.h:
- platform/android/WidgetAndroid.cpp: (WebCore::Widget::setFocus):
- platform/chromium/WidgetChromium.cpp: (WebCore::Widget::setFocus):
- platform/efl/WidgetEfl.cpp: (WebCore::Widget::setFocus):
- platform/gtk/WidgetGtk.cpp: (WebCore::Widget::setFocus):
- platform/haiku/WidgetHaiku.cpp: (WebCore::Widget::setFocus):
- platform/mac/WidgetMac.mm: (WebCore::Widget::setFocus):
- platform/qt/WidgetQt.cpp: (WebCore::Widget::setFocus):
- platform/win/WidgetWin.cpp: (WebCore::Widget::setFocus):
- platform/wx/WidgetWx.cpp: (WebCore::Widget::setFocus):
- plugins/PluginView.h:
- plugins/PluginViewNone.cpp: (WebCore::PluginView::setFocus):
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setFocus):
- plugins/mac/PluginViewMac.cpp: (WebCore::PluginView::setFocus):
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setFocus):
- plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::setFocus):
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::setFocus):
2010-05-05 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Darin Fisher.
Update the plugin container's setFocus implementation to pass the new
boolean argument to the next layer.
- src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::setFocus):
- src/WebPluginContainerImpl.h:
2010-05-05 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Darin Fisher.
Update setFocus for the new boolean argument; no behavioral change.
- WebCoreSupport/EmbeddedWidget.cpp: (EmbeddedWidget::setFocus):
- WebCoreSupport/EmbeddedWidget.h:
- 9:01 AM Changeset in webkit [58820] by
-
- 2 edits in trunk/LayoutTests
2010-05-05 Jeremy Moskovich <jeremy@chromium.org>
Unreviewed, updated baselines.
skia r561 broke a bunch of chromium image baselines.
Update test_expectations to include remaining failures.
- platform/chromium/test_expectations.txt:
- 8:18 AM Changeset in webkit [58819] by
-
- 4 edits2 adds in trunk/LayoutTests
2010-05-05 Jeremy Moskovich <jeremy@chromium.org>
Unreviewed, updated baselines.
skia r561 broke a bunch of chromium image baselines.
Rebase a few tests that were missed by previous passes.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
- platform/chromium-linux/svg/custom/mask-changes-expected.checksum: Added.
- platform/chromium-linux/svg/custom/mask-changes-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 8:08 AM Changeset in webkit [58818] by
-
- 5 edits in trunk/WebCore
2010-05-05 Steve Block <steveblock@google.com>
Reviewed by Pavel Feldman.
Move V8 ScriptDebugServer::topStackFrame() to ScriptCallStack
https://bugs.webkit.org/show_bug.cgi?id=38531
ScriptCallStack::create() uses ScriptDebugServer::topStackFrame(), but ScriptDebugServer
is guarded with ENABLE(JAVASCRIPT_DEBUGGER). This prevents ScriptCallStack from being
built on platforms that do not define ENABLE(JAVASCRIPT_DEBUGGER).
No new tests, build fix only.
- bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::callLocation): (WebCore::ScriptCallStack::createUtilityContext): Helper for topStackFrame, moved from ScriptDebugServer (WebCore::ScriptCallStack::topStackFrame): Moved from ScriptDebugServer
- bindings/v8/ScriptCallStack.h: (WebCore::ScriptCallStack::utilityContext): Helper for topStackFrame, moved from ScriptDebugServer
- bindings/v8/ScriptDebugServer.cpp:
- bindings/v8/ScriptDebugServer.h:
- 7:42 AM Changeset in webkit [58817] by
-
- 7 edits1 delete in trunk/LayoutTests
2010-05-05 Jeremy Moskovich <jeremy@chromium.org>
Unreviewed, updated baselines - 6th and final batch.
skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>
- platform/chromium/test_expectations.txt:
- 7:18 AM Changeset in webkit [58816] by
-
- 671 edits10 adds62 deletes in trunk/LayoutTests
2010-05-05 Jeremy Moskovich <jeremy@chromium.org>
Unreviewed, updated baselines - 5th batch.
skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>
- platform/chromium/test_expectations.txt:
- 7:01 AM BuildingQtOnWindows edited by
- (diff)
- 6:52 AM Changeset in webkit [58815] by
-
- 852 edits4 adds41 deletes in trunk/LayoutTests
2010-05-05 Jeremy Moskovich <jeremy@chromium.org>
Unreviewed, updated baselines - 4th batch.
skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>
- platform/chromium/test_expectations.txt:
- 6:49 AM QtWebKitJournal edited by
- (diff)
- 6:31 AM Changeset in webkit [58814] by
-
- 820 edits2 adds69 deletes in trunk/LayoutTests
2010-05-05 Jeremy Moskovich <jeremy@chromium.org>
Unreviewed, updated baselines - 3rd batch.
skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>
- platform/chromium/test_expectations.txt:
- 5:57 AM Changeset in webkit [58813] by
-
- 2 edits in trunk/WebCore
[Qt] REGRESSION(r56869): WinCE build is broken
https://bugs.webkit.org/show_bug.cgi?id=36929
Rubber-stamped by Simon Hausmann.
- WebCore.pro: LIBS += -lOle32 added.
- 5:44 AM BuildingQtOnWindows edited by
- Added python as a dependency (diff)
- 5:36 AM Changeset in webkit [58812] by
-
- 1080 edits8 adds111 deletes in trunk/LayoutTests
Unreviewed, updated baselines - 2nd batch.
skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>
- platform/chromium/test_expectations.txt:
- 4:54 AM Changeset in webkit [58811] by
-
- 379 edits39 deletes in trunk/LayoutTests
Unreviewed, updated baselines - 1st batch.
skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>
- platform/chromium/test_expectations.txt:
- 4:30 AM Changeset in webkit [58810] by
-
- 2 edits in trunk/WebCore
[Qt] Disable Qt Multimedia backend for HTML 5 Audio and Video elements
Reviewed by Tor Arne Vestbø.
Fall back to the Phonon backend until the release situation has been cleared up.
- WebCore.pro:
- 4:30 AM Changeset in webkit [58809] by
-
- 2 edits in trunk/WebCore
2010-05-05 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Clickable links to resources should be used as 'details' part for the all suitable kinds of records.
https://bugs.webkit.org/show_bug.cgi?id=38542
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelineRecordListRow): (WebInspector.TimelineRecordListRow.prototype.update): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails): (WebInspector.TimelinePanel.PopupContentHelper): (WebInspector.TimelinePanel.PopupContentHelper.prototype._createCell): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendTextRow): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendElementRow): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
- 2:33 AM Changeset in webkit [58808] by
-
- 1 edit6 adds in trunk/WebCore
2010-05-05 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Add missing files generated by "run-bindings-test", after the DOMTestCallback.idl addition.
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: Added. (WebKit::kit): (webkit_dom_test_callback_callback_with_class1param): (webkit_dom_test_callback_callback_with_class2param): (webkit_dom_test_callback_callback_with_non_bool_return_type): (WebKit::wrapTestCallback): (WebKit::core): (webkit_dom_test_callback_finalize): (webkit_dom_test_callback_set_property): (webkit_dom_test_callback_get_property): (webkit_dom_test_callback_class_init): (webkit_dom_test_callback_init):
- bindings/scripts/test/GObject/WebKitDOMTestCallback.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h: Added.
- bindings/scripts/test/ObjC/DOMTestCallback.h: Added.
- bindings/scripts/test/ObjC/DOMTestCallback.mm: Added. (-[DOMTestCallback dealloc]): (-[DOMTestCallback finalize]): (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]): (core): (kit):
- bindings/scripts/test/ObjC/DOMTestCallbackInternal.h: Added.
- 1:00 AM Changeset in webkit [58807] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, expectations change.
recommit r58747 - Preparing for chromium skia roll incorporating changes up to r561.
Add expected failures so bots don't turn red while rolling.
- platform/chromium/test_expectations.txt:
- 12:57 AM Changeset in webkit [58806] by
-
- 2 edits in trunk/LayoutTests
2010-05-05 Xan Lopez <xlopez@igalia.com>
Skip flakey workers test.
- platform/gtk/Skipped:
- 12:57 AM Changeset in webkit [58805] by
-
- 2 edits in trunk/WebCore
2010-05-05 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
Web Inspector: FontView needs Cleanup
https://bugs.webkit.org/show_bug.cgi?id=38567
FontView was missing some of the newer practices for initialization
that other Resource Views had. Also its width calculations could
result in a single character wrapping. This is general cleanup.
- inspector/front-end/FontView.js: (WebInspector.FontView): move initialization into contentTabSelected (WebInspector.FontView.prototype.contentTabSelected): handle initialization like other Resource Views (WebInspector.FontView.prototype.updateFontPreviewSize): use a narrower width to prevent text from widowing
- 12:31 AM Changeset in webkit [58804] by
-
- 2 edits in trunk/WebCore
2010-05-05 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG hit testing is *way* too slow
https://bugs.webkit.org/show_bug.cgi?id=19312
Use the cached stroke and fill boundaries in RenderPath as a heuristik to
speed up SVG's hit testing.
No new tests added.
- rendering/RenderPath.cpp: (WebCore::RenderPath::fillContains): (WebCore::RenderPath::strokeContains):
May 4, 2010:
- 11:06 PM Changeset in webkit [58803] by
-
- 4 edits in trunk/WebKitTools
2010-05-04 Eric Seidel <eric@webkit.org>
Reviewed by Shinichiro Hamaji.
PrettyPatch.pretty_diff("") should not hang
https://bugs.webkit.org/show_bug.cgi?id=38552
Also found a bug in PrettyPatch.pretty_diff where it would
hang when passed "" as input.
I suspect there may be bugs in prettify.rb (or our use there-of)
where it can hang, which would then cause the testing thread to hang.
- Scripts/webkitpy/common/prettypatch.py:
- Don't hang when passed ""
- Scripts/webkitpy/common/prettypatch_unittest.py:
- Test that we don't hang when passed ""
- Scripts/webkitpy/layout_tests/port/base.py:
- Add a FIXME that we should share code with prettypatch.rb
- 10:09 PM Changeset in webkit [58802] by
-
- 2 edits in trunk/WebKit/mac
2010-05-04 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Improve check for drawing into the window that was added in r58623
https://bugs.webkit.org/show_bug.cgi?id=38562
Rather than assuming that any non-bitmap context is the window's context,
compare the current graphics context with -[NSWindow graphicsContext] to
determine that we're drawing into the window.
- WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
- 8:24 PM Changeset in webkit [58801] by
-
- 24 edits5 adds18 deletes in trunk/WebCore
Auto-generate all Database callbacks.
https://bugs.webkit.org/show_bug.cgi?id=38503
Reviewed by Adam Barth.
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSCustomSQLStatementCallback.cpp: Removed.
- bindings/js/JSCustomSQLStatementCallback.h: Removed.
- bindings/js/JSCustomSQLStatementErrorCallback.cpp:
(WebCore::JSSQLStatementErrorCallback::handleEvent):
- bindings/js/JSCustomSQLStatementErrorCallback.h: Removed.
- bindings/js/JSCustomSQLTransactionCallback.cpp: Removed.
- bindings/js/JSCustomSQLTransactionCallback.h: Removed.
- bindings/js/JSCustomSQLTransactionErrorCallback.cpp: Removed.
- bindings/js/JSCustomSQLTransactionErrorCallback.h: Removed.
- bindings/js/JSDatabaseCallback.cpp: Removed.
- bindings/js/JSDatabaseCallback.h: Removed.
- bindings/js/JSDatabaseCustom.cpp:
(WebCore::JSDatabase::changeVersion):
(WebCore::createTransaction):
- bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/test/JS/JSTestCallback.cpp:
- bindings/v8/custom/V8CustomSQLStatementCallback.cpp: Removed.
- bindings/v8/custom/V8CustomSQLStatementCallback.h: Removed.
- bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
(WebCore::V8SQLStatementErrorCallback::handleEvent):
- bindings/v8/custom/V8CustomSQLStatementErrorCallback.h: Removed.
- bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: Removed.
- bindings/v8/custom/V8CustomSQLTransactionCallback.h: Removed.
- bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: Removed.
- bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Removed.
- bindings/v8/custom/V8DatabaseCallback.cpp: Removed.
- bindings/v8/custom/V8DatabaseCallback.h: Removed.
- bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::V8Database::changeVersionCallback):
(WebCore::createTransaction):
- bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):
- storage/DatabaseCallback.h:
- storage/DatabaseCallback.idl: Added.
- storage/SQLStatement.cpp:
(WebCore::SQLStatement::performCallback):
- storage/SQLStatementCallback.h:
- storage/SQLStatementCallback.idl: Added.
- storage/SQLStatementErrorCallback.idl: Added.
- storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::deliverTransactionCallback):
- storage/SQLTransactionCallback.h:
- storage/SQLTransactionCallback.idl: Added.
- storage/SQLTransactionErrorCallback.h:
- storage/SQLTransactionErrorCallback.idl: Added.
- 8:06 PM Changeset in webkit [58800] by
-
- 1 add in trunk/LayoutTests/platform/mac/compositing/iframes/composited-parent-iframe-expected.txt
results for new test checked in with http://trac.webkit.org/changeset/58797
- 7:43 PM Changeset in webkit [58799] by
-
- 2 edits in trunk/LayoutTests
2010-05-04 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations fix.
Re-add the two expectations lines that got mistakenly deleted in
r58798.
- platform/chromium/test_expectations.txt:
- 7:05 PM Changeset in webkit [58798] by
-
- 2 edits in trunk/LayoutTests
2010-05-04 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Made composited iframes work on Windows
https://bugs.webkit.org/show_bug.cgi?id=32446
I've added one new test (composited-parent-iframe.html) which
shows both the parent iframe and the iframe contents document
with compositing. It also shows correct behavior with clipping,
borders, margins, padding and shadows. It also sets the iframe
size as a percent of the page to show correct resizing behavior.
The existing composited-iframe.html has been changed similarly
but without the page resizing. The existing preserve-3d-switching.html
test needed new results because of changes to the layer dumper.
- compositing/geometry/preserve-3d-switching-expected.txt:
- compositing/iframes/composited-iframe.html:
- compositing/iframes/composited-parent-iframe.html: Added.
- compositing/iframes/resources/composited-subframe.html:
- platform/win/compositing/iframes/composited-iframe-expected.txt:
- platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Added.
- 6:50 PM Changeset in webkit [58797] by
-
- 9 edits2 adds in trunk
Reviewed by Simon Fraser.
Made composited iframes work on Windows
https://bugs.webkit.org/show_bug.cgi?id=32446
This completes the work in http://trac.webkit.org/changeset/57919
to create compositing layers in the parent document when an iframe has
a compositing layer. The parent document has a layer for the iframe
element and builds a layer tree to the page root. The layer tree for the
iframe document is then parented to the iframe element's GraphicsLayer.
The RenderLayerCompositor for the iframe document (which owns the
root of the layer tree) now has a clippingLayer which is the
parent of the layer tree root so it can be clipped to the parent
iframe's bounds, taking into account borders, padding, etc. in
the parent iframe element.
I also got rid of a no longer used function: RenderLayerCompositor::parentInRootLayer
Test: compositing/iframes/composited-parent-iframe.html
- rendering/RenderLayerBacking.cpp:Make calls to RenderLayerCompositor to set the clipping bounds for iframe content
- rendering/RenderLayerCompositor.cpp:Hook the iframe content to the parent iframe element
- rendering/RenderLayerCompositor.h:
- 6:24 PM Changeset in webkit [58796] by
-
- 2 edits in trunk/LayoutTests
Not reviewed.
Updated test results - the test still passes.
- http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt:
- 6:22 PM Changeset in webkit [58795] by
-
- 2 edits in trunk/WebKitSite
Fix the sticky-notes demo.
https://bugs.webkit.org/show_bug.cgi?id=38550
Reviewed by Darin Adler.
- Exceptions thrown by openDatabase() should be treated as
failures.
- Do not allow users to create new notes when openDatabase()
failed.
- demos/sticky-notes/index.html:
- 6:11 PM Changeset in webkit [58794] by
-
- 9 edits in trunk/LayoutTests
AX: layout tests need to be updated to reflect what is being tested
https://bugs.webkit.org/show_bug.cgi?id=38556
Reviewed by Beth Dakin.
Many of the initial AX layout tests just dumped a lot of attributes and did not
have a focused test. This updates some of those tests (more to follow in the future).
- accessibility/image-map1.html:
- accessibility/img-aria-button-alt-tag-expected.txt:
- accessibility/img-aria-button-alt-tag.html:
- accessibility/input-image-alt-expected.txt:
- accessibility/input-image-alt.html:
- accessibility/placeholder-expected.txt:
- accessibility/placeholder.html:
- platform/mac/accessibility/image-map1-expected.txt:
- 6:08 PM Changeset in webkit [58793] by
-
- 5 edits in trunk/WebKit/chromium
2010-05-04 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Darin Fisher.
Provide an API for querying whether a WebWidget is using gpu accelerated compositing.
Also changed: isAcceleratedCompositing to: isAcceleratedCompositingActive.
https://bugs.webkit.org/show_bug.cgi?id=38220
- public/WebWidget.h:
- src/WebPopupMenuImpl.h: (WebKit::WebPopupMenuImpl::isAcceleratedCompositingActive):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::isAcceleratedCompositingActive): (WebKit::WebViewImpl::setRootGraphicsLayer): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::updateRootLayerContents):
- src/WebViewImpl.h:
- 5:57 PM Changeset in webkit [58792] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=38497
<rdar://problem/7759438> Make sure that http URLs always have a host in SecurityOrigin
This is a hardening fix, and behavior really depends on what an underlying networking layer
does. So, no test.
- page/SecurityOrigin.cpp: (WebCore::schemeRequiresAuthority): List schemes that need an authority for successful loading. (WebCore::SecurityOrigin::SecurityOrigin): Never let e.g. http origins with empty authorities have the same security origin.
- 5:49 PM Changeset in webkit [58791] by
-
- 2 edits in trunk/LayoutTests
2010-05-04 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Mark fast/forms/placeholder-pseudo-style.html as an IMAGE diff on
chromium-linux . This was mistaken deleted earlier today. Mark
fast/dom/clone-node-z-index.html as a TEXT diff on chromium-win; I
haven't looked at this yet but I need to roll past this to get the
new-run-webkit-tests change I checked in in r58789 downstream to
the Chromium bots.
- platform/chromium/test_expectations.txt:
- 5:30 PM Changeset in webkit [58790] by
-
- 15 edits in trunk
2010-05-04 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
getFramebufferAttachmentParameter should return the original WebGLTexture/WebGLRenderbuffer instead of creating new ones sharing names.
https://bugs.webkit.org/show_bug.cgi?id=38236
- fast/canvas/webgl/gl-object-get-calls-expected.txt: Check if getFramebufferAttachmentParameter return a texture/renderbuffer that matches the original one.
- fast/canvas/webgl/script-tests/gl-object-get-calls.js: Ditto.
2010-05-04 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
getFramebufferAttachmentParameter should return the original WebGLTexture/WebGLRenderbuffer instead of creating new ones sharing names.
https://bugs.webkit.org/show_bug.cgi?id=38236
- html/canvas/CanvasObject.h: Add type check functions. (WebCore::CanvasObject::isBuffer): (WebCore::CanvasObject::isFramebuffer): (WebCore::CanvasObject::isProgram): (WebCore::CanvasObject::isRenderbuffer): (WebCore::CanvasObject::isShader): (WebCore::CanvasObject::isTexture):
- html/canvas/WebGLBuffer.h: Add type check functions. (WebCore::WebGLBuffer::isBuffer):
- html/canvas/WebGLFramebuffer.h: Add type check functions. (WebCore::WebGLFramebuffer::isFramebuffer):
- html/canvas/WebGLProgram.h: Add type check functions. (WebCore::WebGLProgram::isProgram):
- html/canvas/WebGLRenderbuffer.cpp: remove constructor using existing name.
- html/canvas/WebGLRenderbuffer.h: Add type check functions; remove constructor using existing name. (WebCore::WebGLRenderbuffer::isRenderbuffer):
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Return original Texture/Renderbuffer instead of creating new ones. (WebCore::WebGLRenderingContext::findTexture): Find a WebGLTexture using a name. (WebCore::WebGLRenderingContext::findRenderbuffer): Find a WebGLRenderbuffer using a name.
- html/canvas/WebGLRenderingContext.h: Add find* functions.
- html/canvas/WebGLShader.h: Add type check functions. (WebCore::WebGLShader::isShader):
- html/canvas/WebGLTexture.cpp: remove constructor using existing name.
- html/canvas/WebGLTexture.h: Add type check functions; remove constructor using existing name. (WebCore::WebGLTexture::isTexture):
- 5:16 PM Changeset in webkit [58789] by
-
- 4 edits in trunk/WebKitTools
2010-05-04 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
new-run-webkit-tests: turn off threading on the Chromium Mac port until
we can stabilize the port more and figure out why it is hanging so
frequently.
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- override default_child_processes() and log a warning
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- fix a typo that caused us to print a method object instead of the value the method object returns in the case where there is only one child process.
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- Add unit tests for the output of run_webkit_tests - in this case, the handling of --child-processes and --print config
- 5:16 PM Changeset in webkit [58788] by
-
- 4 edits in trunk/WebCore
2010-05-04 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Simon Hausmann.
[Qt] QT_MOBILE_THEME compile time flag
https://bugs.webkit.org/show_bug.cgi?id=38439
Replacing preprocessor conditional used in RenderThemeQt from Q_WS_MAEMO_5 to
USE(QT_MOBILE_THEME).
- WebCore.pro:
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::RenderThemeQt): (WebCore::RenderThemeQt::qStyle): (WebCore::RenderThemeQt::extraDefaultStyleSheet): (WebCore::RenderThemeQt::adjustMenuListButtonStyle): (WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
- platform/qt/RenderThemeQt.h:
- 4:57 PM Changeset in webkit [58787] by
-
- 2 edits in trunk/WebKit/mac
https://bugs.webkit.org/show_bug.cgi?id=38555
Reviewed by David Kilzer.
Small code refactoring: move the logic to figure out the path to the
databases directory to another method.
- Storage/WebDatabaseManager.mm:
(databasesDirectoryPath):
(WebKitInitializeDatabasesIfNecessary):
- 4:17 PM Changeset in webkit [58786] by
-
- 2 edits in trunk/WebCore
2010-05-04 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Dan Bernstein.
SVG fonts trigger GlyphPage::fill with null font
https://bugs.webkit.org/show_bug.cgi?id=38530
SVG fonts do not use the glyph page cache. This change detects when
attempting to fill a GlyphPage with an SVG font and indicates that
the glyphs were not available.
- platform/graphics/GlyphPageTreeNode.cpp: (WebCore::fill): helper method which handles attempts to fill a GlyphPage with SVG or non-SVG fonts (WebCore::GlyphPageTreeNode::initializePage): use the helper where appropriate
- 3:59 PM Changeset in webkit [58785] by
-
- 1 edit in branches/audio/WebCore/bindings/v8/V8DOMWrapper.cpp
Fixes to V8DOMWrapper to handle CachedAudio
- 3:58 PM Changeset in webkit [58784] by
-
- 2 edits in branches/audio/WebCore
Initial changes to gyp files to build audio engine
- 3:58 PM Changeset in webkit [58783] by
-
- 2 adds in branches/audio/WebCore/audio
Add custom V8 bindings for AudioContext and AudioNode
- 3:46 PM Changeset in webkit [58782] by
-
- 3 edits in trunk/LayoutTests
Unreviewed tests skips for qt/gtk.
Add the recently added drag and drop tests to the
skipped lists for both gtk and qt to go along with
the other drag and drop tests that are skipped on
those platforms.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 3:24 PM Changeset in webkit [58781] by
-
- 5 edits in trunk/WebKit2
2010-05-04 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
[WebKit2] The web process doesn't need to paint when the web view is hidden.
https://bugs.webkit.org/show_bug.cgi?id=38549
- Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: (DrawingAreaMessage::): Add SuspendPainting/ResumePainting messages.
- UIProcess/DrawingAreaProxyUpdateChunk.cpp: (WebKit::DrawingAreaProxyUpdateChunk::setPageIsVisible): Suspend and resume painting accordingly.
- WebProcess/WebPage/DrawingAreaUpdateChunk.cpp: (WebKit::DrawingAreaUpdateChunk::DrawingAreaUpdateChunk): Initialize m_shouldPaint to true.
(WebKit::DrawingAreaUpdateChunk::display):
Return if m_shouldPaint is false.
(WebKit::DrawingAreaUpdateChunk::scheduleDisplay):
Ditto.
(WebKit::DrawingAreaUpdateChunk::setSize):
Assert that we should paint here.
(WebKit::DrawingAreaUpdateChunk::suspendPainting):
Set m_shouldPaint to false and stop the timer.
(WebKit::DrawingAreaUpdateChunk::resumePainting):
Set m_shouldPaint to true and paint if needed.
(WebKit::DrawingAreaUpdateChunk::didReceiveMessage):
handle SuspendPainting/ResumePainting messages.
- WebProcess/WebPage/DrawingAreaUpdateChunk.h:
- 3:04 PM Changeset in webkit [58780] by
-
- 3 edits2 adds in trunk
REGRESSION(r54368): Text drag-and-drop from input/textarea doesn't work
if the text is like a URL
https://bugs.webkit.org/show_bug.cgi?id=38374
Patch by Kent Tamura <tkent@chromium.org> on 2010-05-04
Reviewed by David Levin (and unofficially by Enrica Casucci).
WebCore:
Since r54368, documentFragmentFromDragData() creates an <a> element
with no anchor text for URL-like text dragged from input/textarea
element. If such text is dropped to input/textarea element, the text
is not inserted.
To fix this problem, use the original text or the URL as an anchor
text.
Test: editing/pasteboard/drag-drop-url-text.html
- page/DragController.cpp:
(WebCore::documentFragmentFromDragData):
LayoutTests:
- editing/pasteboard/drag-drop-url-text-expected.txt: Added.
- editing/pasteboard/drag-drop-url-text.html: Added.
- 3:01 PM Changeset in webkit [58779] by
-
- 2 edits in trunk/JavaScriptCore
2010-05-04 Yongjun Zhang <yongjun_zhang@apple.com>
Reviewed by Darin Adler.
WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
https://bugs.webkit.org/show_bug.cgi?id=38535
Don't call asFunction if callee is not a FunctionType to prevent assertion failure
in JSCell::isObject().
- debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::functionName): (JSC::DebuggerCallFrame::calculatedFunctionName):
- 2:50 PM Changeset in webkit [58778] by
-
- 1 edit in trunk/WebKit/ChangeLog
Remove ChangeLog from bad merge.
- 2:49 PM Changeset in webkit [58777] by
-
- 3 edits in trunk/WebKitTools
Fix the find command in extract-localizable-strings so skip
directories are correctly skipped and header files are searched.
https://bugs.webkit.org/show_bug.cgi?id=38545
rdar://problem/7941295
Reviewed by Darin Adler.
- Scripts/extract-localizable-strings: Append -o after each -prune
so -and isn't implied. Surround all the -name arguments so they get
an implied -print action. Removed check for "icu". Skip any header that
ends in LocalizableStrings.h, so SafariLocalizableStrings.h is skipped.
- Scripts/update-webkit-localizable-strings: Add the two icu directories
to the skip list.
- 2:49 PM Changeset in webkit [58776] by
-
- 1 edit in trunk/WebKit/ChangeLog
Updated the localizable strings to run without errors.
Rubber-stamped by John Sullivan.
- English.lproj/Localizable.strings: Updated.
- StringsNotToBeLocalized.txt: Updated.
- 2:13 PM Changeset in webkit [58775] by
-
- 4 edits in trunk/WebCore
JavaInstanceJSC.cpp and JNIUtilityPrivate.cpp need to include jni_jsobject.h for jlong_to_pt() and ptr_to_jlong()
https://bugs.webkit.org/show_bug.cgi?id=38525
Reviewed by Darin Adler.
No new tests, build fix only.
- bridge/jni/jni_jsobject.h: Guard Mac-specific code with PLATFORM(MAC)
- bridge/jni/jsc/JNIUtilityPrivate.cpp: Include jni_jsobject.h
- bridge/jni/jsc/JavaInstanceJSC.cpp: Include jni_jsobject.h
- 2:02 PM Changeset in webkit [58774] by
-
- 3 edits in trunk/WebCore
2010-05-04 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
New FileSystemPOSIX functions cause linker errors on Android
https://bugs.webkit.org/show_bug.cgi?id=38521
No new tests, build fix only.
- platform/android/FileSystemAndroid.cpp: Remove closeFile, which is provided in FileSystemPOSIX.cpp
- platform/posix/FileSystemPOSIX.cpp: Guard writeToFile with !PLATFORM(ANDROID)
- 1:49 PM Changeset in webkit [58773] by
-
- 2 edits in trunk/JavaScriptCore
Remove redundant exports to fix Windows build warnings.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 1:37 PM Changeset in webkit [58772] by
-
- 2 edits in trunk/WebKitTools
2010-05-04 Jesus Sanchez-Palencia <jesus@webkit.org>
Reviewed by Eric Seidel.
Wrong documentation on 'webkit-patch help land'.
https://bugs.webkit.org/show_bug.cgi?id=37871
Small fix on the help documentation for webkit-patch
land.
- Scripts/webkitpy/tool/commands/download.py:
- 1:16 PM Changeset in webkit [58771] by
-
- 2 edits in trunk/WebKit/mac
Fix for <rdar://problem/7818509> Crash occurs when exiting Safari
Reviewed by Mike Thole.
We can avoid this crash if we call [self _removeFromAllWebViewsSet]
even in the case when we are doing a fastDocumentTeardown. This is
a much safer approach.
- WebView/WebView.mm:
(-[WebView _close]):
- 1:13 PM Changeset in webkit [58770] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] http/tests/security/cross-frame-access-name-getter.html timed out
https://bugs.webkit.org/show_bug.cgi?id=38540
- platform/qt/Skipped: http/tests/security/cross-frame-access-name-getter.html skipped until bug fixed.
- 1:02 PM Changeset in webkit [58769] by
-
- 2 edits in trunk/LayoutTests
2010-05-04 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Remove a bunch of test failures that are no longer failing (likely fixed in r58762).
- platform/chromium/test_expectations.txt:
- 11:49 AM Changeset in webkit [58768] by
-
- 5 edits in trunk/WebCore
2010-05-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: restore main and sidebar scroller positions
when switching between panels.
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.elementsToRestoreScrollPositionsFor):
- inspector/front-end/Panel.js: (WebInspector.Panel.prototype.show): (WebInspector.Panel.prototype.hide): (WebInspector.Panel.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.Panel.prototype._storeScrollPositions): (WebInspector.Panel.prototype._restoreScrollPositions):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.elementsToRestoreScrollPositionsFor):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.elementsToRestoreScrollPositionsFor):
- 11:12 AM Changeset in webkit [58767] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, build fix for Qt skipping new notifications tests.
- 10:42 AM Changeset in webkit [58766] by
-
- 5 edits4 adds in trunk
2010-05-04 Steven Lai <steven_lai@asia.apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=37900
<rdar://problem/7806164> cloneNode() does not preserve z-index with more than six digits
- fast/dom/HTMLInputElement/clone-input-checked-expected.txt: Added.
- fast/dom/HTMLInputElement/clone-input-checked.html: Added.
- fast/dom/clone-node-z-index-expected.txt: Added.
- fast/dom/clone-node-z-index.html: Added.
2010-05-04 Steven Lai <steven_lai@asia.apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=37900
<rdar://problem/7806164> cloneNode() does not preserve z-index with more than six digits
Tests: fast/dom/HTMLInputElement/clone-input-checked.html
fast/dom/clone-node-z-index.html
- dom/Element.cpp: undid the order change of calling copyNonAttributeProperties() before setAttributes() (WebCore::Element::cloneElementWithoutChildren): uncheck the previous radio button in the same radio button group only when the checked radio box is appended to the dom tree
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateCheckedRadioButtons): (WebCore::HTMLInputElement::attach): (WebCore::HTMLInputElement::setChecked):
- html/HTMLInputElement.h:
- 10:20 AM Changeset in webkit [58765] by
-
- 8 edits4 adds in trunk
2010-04-29 John Gregg <johnnyg@google.com>
Reviewed by Dmitry Titov.
notifications should have dir and replaceId attributes
https://bugs.webkit.org/show_bug.cgi?id=38336
- public/WebNotification.h:
- src/WebNotification.cpp: (WebKit::WebNotification::dir): (WebKit::WebNotification::replaceId):
2010-04-29 John Gregg <johnnyg@google.com>
Reviewed by Dmitry Titov.
notifications should have dir and replaceId attributes.
Note that tests are only enabled in Chromium, skipped elsewhere
since notifications aren't implemented.
https://bugs.webkit.org/show_bug.cgi?id=38336
Tests: fast/notifications/notifications-replace.html
fast/notifications/notifications-rtl.html
- notifications/Notification.h: (WebCore::Notification::dir): (WebCore::Notification::setDir): (WebCore::Notification::replaceId): (WebCore::Notification::setReplaceId):
- notifications/Notification.idl:
2010-04-29 John Gregg <johnnyg@google.com>
Reviewed by Dmitry Titov.
notifications should have dir and replaceId attributes
Tests are disabled until the attributes are correctly handled
in Chromium test_shell.
https://bugs.webkit.org/show_bug.cgi?id=38336
- fast/notifications/notifications-replace-expected.txt: Added.
- fast/notifications/notifications-replace.html: Added.
- fast/notifications/notifications-rtl-expected.txt: Added.
- fast/notifications/notifications-rtl.html: Added.
- platform/chromium/test_expectations.txt:
- 9:31 AM Changeset in webkit [58764] by
-
- 5 edits in trunk
2010-05-04 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QWebPage viewMode property
https://bugs.webkit.org/show_bug.cgi?id=38119
Rename the property from wrt_viewMode to _q_viewMode.
- Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent):
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::viewModes):
2010-05-04 Laszlo Gombos <Laszlo Gombos>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QWebPage viewMode property
https://bugs.webkit.org/show_bug.cgi?id=38119
Rename the property from wrt_viewMode to _q_viewMode.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setViewModeMediaFeature):
- 9:24 AM Changeset in webkit [58763] by
-
- 2 edits in trunk/WebCore
2010-05-04 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Fixed error defining the float/double minimum in the object
properties, the smallest value of a float/double is
-G_MAXDOUBLE/-G_MAXFLOAT.
- bindings/scripts/CodeGeneratorGObject.pm:
- bindings/scripts/CodeGeneratorGObject.pm:
- 8:55 AM Changeset in webkit [58762] by
-
- 7 edits in trunk
2010-05-03 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Dan Bernstein.
REGRESSION: Text clipped in absolutely positioned search inputs
https://bugs.webkit.org/show_bug.cgi?id=38468
Update the test to include a second search field and show
the clipping of a search input is like a text input.
- fast/css/input-search-padding.html:
- platform/mac/fast/css/input-search-padding-expected.checksum:
- platform/mac/fast/css/input-search-padding-expected.png:
- platform/mac/fast/css/input-search-padding-expected.txt:
2010-05-03 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Dan Bernstein.
REGRESSION: Text clipped in absolutely positioned search inputs
https://bugs.webkit.org/show_bug.cgi?id=38468
Previously I incorrectly added x() and y() to the tx and ty positioning.
This clips a search input like a text input, respecting the vertically
centered text.
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout): only the Y changes, so change setLocation to setY (WebCore::RenderTextControlSingleLine::controlClipRect):
- 8:41 AM Changeset in webkit [58761] by
-
- 2 edits in trunk/WebCore
2010-05-04 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: REGRESSION: Up/Down, PgUp/PgDown keys do not change numeric style properties
https://bugs.webkit.org/show_bug.cgi?id=38516
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
- 8:30 AM Changeset in webkit [58760] by
-
- 3 edits4 adds in trunk
2010-05-04 Ben Murdoch <benm@google.com>
Reviewed by Simon Hausmann.
Crash in handleTouchEvent: using dangling node ptrs in hashmap
https://bugs.webkit.org/show_bug.cgi?id=38514
- fast/events/touch/resources/touch-stale-node-crash.js: Added.
- fast/events/touch/resources/send-touch-up.html: Added.
- fast/events/touch/touch-stale-node-crash-expected.txt: Added.
- fast/events/touch/touch-stale-node-crash.html: Added.
2010-05-04 Ben Murdoch <benm@google.com>
Reviewed by Simon Hausmann.
Crash in handleTouchEvent: using dangling node ptrs in hashmap
https://bugs.webkit.org/show_bug.cgi?id=38514
When navigating away from a page, if you have your finger still
pressed and then lift it on the new page we see a crash if the
node got deleted as we still have a dangling pointer in the
m_originatingTouchPointTargets hashmap and try to use it as the
receiver to dispatch a touchend event.
Test: fast/events/touch/touch-stale-node-crash.html
- page/EventHandler.cpp: (WebCore::EventHandler::clear): Clear the hashmap of touch targets.
- 7:54 AM QtWebKitPackaging edited by
- (diff)
- 7:53 AM QtWebKitPackaging edited by
- (diff)
- 7:52 AM QtWebKitPackaging edited by
- (diff)
- 7:29 AM Changeset in webkit [58759] by
-
- 2 edits in trunk/WebKitTools
2010-05-04 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
Fix typo in run_webkit_tests.py: s/_print\./_printer./
https://bugs.webkit.org/show_bug.cgi?id=38515
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 7:15 AM Changeset in webkit [58758] by
-
- 2 edits in trunk/WebCore
2010-05-04 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Pavel Feldman.
Web Inspector: Drawer Misbehaving when Docking / Undocking in Console Panel
https://bugs.webkit.org/show_bug.cgi?id=38510
- inspector/front-end/inspector.js: (WebInspector.set attached): resize the drawer after docking/undocking
- 7:04 AM Changeset in webkit [58757] by
-
- 2 edits in trunk/WebKit/chromium
2010-05-04 Jay Civelli <jcivelli@chromium.org>
Reviewed by David Levin.
[chromium] Make the select popup not close on right/middle clicks.
https://bugs.webkit.org/show_bug.cgi?id=38473
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::mouseDown):
- 7:04 AM Changeset in webkit [58756] by
-
- 2 edits in trunk
2010-05-04 Laszlo Gombos <Laszlo Gombos>
Unreviewed, build fix for Symbian.
[Symbian] Symbian builds does not support shadow builds
Revision r54715 broke the Symbian build. For Symbian
the include directory is generated in the root of the source tree.
This patch sets the INCLUDEPATH accordingly for Symbian.
- WebKit.pri:
- 6:53 AM Changeset in webkit [58755] by
-
- 2 edits in trunk/JavaScriptCore
2010-05-04 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Holger Freyther.
Fix a memory leak inside the QScriptValue.
QSciptValuePrivate::toString should release all temporary variables.
[Qt] QScriptValue::toString have a memory leak.
https://bugs.webkit.org/show_bug.cgi?id=38112
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::toString):
- 6:30 AM Changeset in webkit [58754] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Preserve binary compatibility with qtwebkit-2.0 branch
Rubber-stamped by Tor Arne Vestbø.
Moved the WebGL attribute in QWebSettings to the end of the enum,
to ensure that the numeric values of the enum values following it
are the same as in the release branch.
- Api/qwebsettings.h:
- 5:34 AM Changeset in webkit [58753] by
-
- 2 edits in trunk/JavaScriptCore
2010-05-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Darin Adler.
Does not work on SPARC because of alignment issues
https://bugs.webkit.org/show_bug.cgi?id=38455
Use AllocAlignmentInteger instead of void* on pageheap_memory to
avoid crashing at runtime in some architectures. Investigated by
Mike Hommey <mh@glandium.org>, change suggested by Darin Adler.
- wtf/FastMalloc.cpp:
- 5:31 AM Changeset in webkit [58752] by
-
- 3 edits in trunk/WebCore
2010-05-04 Laszlo Gombos <Laszlo Gombos>
Unreviewed, build fix for Symbian.
[Symbian] Build fix after r58598.
Use C99 integer types for the Symbian plugin
implementation.
No new tests, as there is no new functionality.
- plugins/symbian/PluginPackageSymbian.cpp: (WebCore::PluginPackage::NPVersion):
- plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::handlePostReadFile):
- 5:07 AM Changeset in webkit [58751] by
-
- 11 edits3 copies in trunk/WebCore
2010-05-04 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Split SVGCharacterLayoutInfo in smaller pieces
https://bugs.webkit.org/show_bug.cgi?id=38513
Split SVGCharacterLayoutInfo into SVGCharacterLayoutInfo/SVGCharacterData and SVGTextChunkLayoutInfo.
This is a preparation for more work in the text area.
- Android.mk: Add SVGCharacterData.(cpp|h) and SVGTextChunkLayoutInfo.h to build.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- rendering/SVGCharacterData.cpp: Copied from rendering/SVGCharacterLayoutInfo.cpp.
- rendering/SVGCharacterData.h: Copied from rendering/SVGCharacterLayoutInfo.h. (WebCore::SVGChar::SVGChar):
- rendering/SVGCharacterLayoutInfo.cpp: (WebCore::SVGCharacterLayoutInfo::isInitialLayout): Introduced new helper function to share code between addLayoutInformation/addStackContent. (WebCore::SVGCharacterLayoutInfo::addLayoutInformation): Use new helper function. (WebCore::SVGCharacterLayoutInfo::addStackContent): Ditto
- rendering/SVGCharacterLayoutInfo.h:
- rendering/SVGRootInlineBox.h: Include new files.
- rendering/SVGTextChunkLayoutInfo.h: Copied from rendering/SVGCharacterLayoutInfo.h.
- 4:49 AM BuildingQtOnOSX edited by
- (diff)
- 4:48 AM Changeset in webkit [58750] by
-
- 2 edits in trunk/LayoutTests
Revert r58747 - postponing Skia roll, at which time
we'll need to add these expected failures back.
https://bugs.webkit.org/show_bug.cgi?id=38512
- platform/chromium/test_expectations.txt:
- 4:16 AM Changeset in webkit [58749] by
-
- 2 edits in trunk/WebCore
2010-05-04 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590
Use helper functions from CodeGenerator.pm to figure out whether a
type is "fundamental" or not (basically whether it's anything
other than a string or a non-pointer type).
- bindings/scripts/CodeGeneratorGObject.pm:
- 3:25 AM Changeset in webkit [58748] by
-
- 10 edits2 adds in trunk/WebCore
2010-04-30 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: REGRESSION: Disabled style properties are absent in Styles sidebar after WebInspector is re-opened
https://bugs.webkit.org/show_bug.cgi?id=38255
Moved stylesheet-related mappings into a separate object stored
in InspectorController rather than InspectorDOMAgent (which gets reset
on every frontend [dis]connect).
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorCSSStore.cpp: Added. (WebCore::InspectorCSSStore::InspectorCSSStore): (WebCore::InspectorCSSStore::~InspectorCSSStore): (WebCore::InspectorCSSStore::reset):
- inspector/InspectorCSSStore.h: Added.
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setFrontend): (WebCore::InspectorController::didCommitLoad):
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::applyStyleText): (WebCore::InspectorDOMAgent::setStyleText): (WebCore::InspectorDOMAgent::setStyleProperty): (WebCore::InspectorDOMAgent::toggleStyleEnabled): (WebCore::InspectorDOMAgent::setRuleSelector): (WebCore::InspectorDOMAgent::addRule): (WebCore::InspectorDOMAgent::bindStyle): (WebCore::InspectorDOMAgent::bindRule): (WebCore::InspectorDOMAgent::buildObjectForStyle): (WebCore::InspectorDOMAgent::buildObjectForRule):
- inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create): (WebCore::InspectorDOMAgent::cssStore):
- 2:55 AM Changeset in webkit [58747] by
-
- 2 edits in trunk/LayoutTests
2010-05-04 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Pavel Feldman.
Preparing for chromium skia roll incorporating changes up to r561.
Add expected failures so bots don't turn red while rolling.
- platform/chromium/test_expectations.txt:
- 2:36 AM Changeset in webkit [58746] by
-
- 2 edits in trunk/LayoutTests
Unreviewed fix to make Qt bot happier.
r58712 made fast/workers/worker-gc2.html crash. It seems to be a DRT sideeffect,
skipping worker-event-listener.html solve the problem until we find a real fix.
https://bugs.webkit.org/show_bug.cgi?id=38502
- platform/qt/Skipped: fast/workers/worker-event-listener.html skipped.
- 2:25 AM Changeset in webkit [58745] by
-
- 4 edits in trunk/WebCore
2010-05-04 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Display "Recording..." item when recording an user-initiated CPU profile.
- English.lproj/localizedStrings.js:
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfileHeader): (WebInspector.ProfilesPanel.prototype.removeProfileHeader): (WebInspector.ProfilesPanel.prototype.showProfile):
- inspector/front-end/inspector.js: (WebInspector.setRecordingProfile):
- 2:15 AM Changeset in webkit [58744] by
-
- 3 edits1 add in trunk/WebCore
2010-05-04 Tucker Jay <jay.tucker@nokia.com>
Reviewed by Holger Freyther.
Animated GIF images does not animate 10x as expected by default.
https://bugs.webkit.org/show_bug.cgi?id=36818
Added test case to existing manual test to test the
fixed functionality.
- manual-tests/qt/qt-10loop-anim.gif: Added.
- manual-tests/qt/qt-gif-test.html:
- platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::repetitionCount):
- 1:27 AM Changeset in webkit [58743] by
-
- 2 edits in trunk/WebCore
2010-05-04 Dirk Schulze <krit@webkit.org>
Unreviewed sort of XCodes project file.
- WebCore.xcodeproj/project.pbxproj:
- 1:06 AM Changeset in webkit [58742] by
-
- 14 edits in trunk/WebKitTools
2010-05-04 Chris Jerdonek <Chris Jerdonek>
Reviewed by Eric Seidel.
This revision completes the terminology change from "processor" to
"checker" for the CarriageReturnProcessor, CppProcessor,
PythonProcessor, and TextProcessor classes, etc.
The word "processor" currently has two uses in our code. This
revision renames the lower-level use to "checker" and preserves the
word "processor" for higher-level, more general uses. This
revision also makes whatever other name changes that logically
followed from this change.
- Scripts/check-webkit-style:
- Updated references to PatchChecker.
- Scripts/webkitpy/style/checker.py:
- Renamed the StyleCheckerConfiguration class to StyleProcessorConfiguration.
- Renamed the ProcessorDispatcher class to CheckerDispatcher, and made similar changes for the class's method names.
- Renamed the PatchChecker class to PatchReader.
- Updated the file as necessary to accommodate the other class renames in this patch.
- Scripts/webkitpy/style/checker_unittest.py:
- Updated the unit test code as necessary.
- Scripts/webkitpy/style/checkers/common.py:
- Renamed the CarriageReturnProcessor class to CarriageReturnChecker, and changed its process() method to check().
- Scripts/webkitpy/style/checkers/common_unittest.py:
- Updated the unit test code as necessary.
- Scripts/webkitpy/style/checkers/cpp.py:
- Renamed the CppProcessor class to CppChecker, and renamed its process() method to check().
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
- Updated the unit test code as necessary.
- Scripts/webkitpy/style/checkers/python.py:
- Renamed the PythonProcessor class to PythonChecker, and renamed its process() method to check().
- Scripts/webkitpy/style/checkers/python_unittest.py:
- Updated the unit test code as necessary.
- Scripts/webkitpy/style/checkers/text.py:
- Renamed the TextProcessor class to TextChecker, and renamed its process() method to check().
- Scripts/webkitpy/style/checkers/text_unittest.py:
- Updated the unit test code as necessary.
- Scripts/webkitpy/style/error_handlers.py:
- Updated the code as necessary.
- Scripts/webkitpy/style/error_handlers_unittest.py:
- Updated the unit test code as necessary.
- 1:00 AM Changeset in webkit [58741] by
-
- 3 edits in trunk/WebKitTools
2010-05-04 Chris Jerdonek <Chris Jerdonek>
Reviewed by Eric Seidel.
Adjusted svn-apply and -unapply to accept git diffs generated
using the --no-prefix flag.
- Scripts/VCSUtils.pm:
- Loosened the regular expression for the "diff --git" line to match when the --no-prefix flag is used with "git diff".
- Also refactored the code parsing the first line so that the script exits with an error message if the first line cannot be parsed.
- Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
- Added a unit test case for the --no-prefix case.
- 12:57 AM Changeset in webkit [58740] by
-
- 1 edit4 adds in trunk/JavaScriptCore
2010-05-04 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Add first WTFURL file
https://bugs.webkit.org/show_bug.cgi?id=38470
This class represents a component of a URL, such as the scheme or path.
Essentially, the class is an index into a string buffer.
- wtf/url: Added.
- There was some discussion about where to put the URL library. There are a number of reasonable options, but putting the library in the WTF directory seems like a reasonable alternative. This location will make more sense once WTF is moved out of JavaScriptCore and into a top-level directory.
- wtf/url/src: Added.
- I've added this extra directory to the usual structure because we eventually want a "public" folder that defines the public interface to this library that clients outside of svn.webkit.org can rely upon, much like the various subfolders of the WebKit directory often define a public API.
- wtf/url/src/URLComponent.h: Added.
- I've added this somewhat trivial class to get the ball rolling.
(WTF::URLComponent::URLComponent):
(WTF::URLComponent::isValid):
(WTF::URLComponent::isNonempty):
(WTF::URLComponent::reset):
(WTF::URLComponent::operator==):
(WTF::URLComponent::begin):
(WTF::URLComponent::setBegin):
(WTF::URLComponent::length):
(WTF::URLComponent::setLength):
(WTF::URLComponent::end):
- wtf/url/wtfurl.gyp: Added.
- WTFURL will be an independently buildable library, hence the beginnings of a wtfurl.gyp file.
- 12:55 AM Changeset in webkit [58739] by
-
- 3 edits1 copy1 delete in trunk/WebKitTools
2010-05-04 Chris Jerdonek <Chris Jerdonek>
Reviewed by Daniel Bates.
Changed VCSUtils.pm's parseDiffHeader() to call the new
parseGitDiffHeader() method.
This revision makes more progress towards adding executable-bit
support to svn-apply and svn-unapply. It also makes more progress
towards refactoring the code into a more maintainable form.
- Scripts/VCSUtils.pm:
- Removed gitdiff2svndiff().
- Removed the Git-specific logic from parseDiffHeader() and renamed it parseSvnDiffHeader().
- Added a new parseDiffHeader() subroutine which calls parseSvnDiffHeader() or parseGitDiffHeader() depending on the format of the first header line.
- Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: Removed.
- Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
- Removed most of the test cases since these cases are now covered by the unit tests for parseSvnDiffHeader() and parseGitDiffHeader().
- Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl: Added.
- Copied the SVN unit tests from parseDiffHeader.pl and updated them as necessary.
- 12:22 AM Changeset in webkit [58738] by
-
- 2 edits in trunk/LayoutTests
2010-05-04 Alejandro G. Castro <alex@igalia.com>
Unreviewed, skip test.
Skipping inspector/timeline-parse-html.html
https://bugs.webkit.org/show_bug.cgi?id=38509
- platform/gtk/Skipped:
- 12:03 AM Changeset in webkit [58737] by
-
- 2 edits in trunk/WebKitTools
2010-05-03 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Builders should run the perl and python unit tests on every commit
https://bugs.webkit.org/show_bug.cgi?id=37976
The unit tests take a few seconds to run, so they should not
have any noticable effect on builder speed.
We're running the tests everywhere but Tiger as Tiger's
Python version is ancient.
I would have rather have detected the python version of the
slave but I couldn't find any API to do that, and I didn't want
to hack version detection into test-webkitpy (at least not yet).
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
