Timeline
Jun 4, 2010:
- 11:57 PM Changeset in webkit [60739] by
-
- 3 edits in trunk/WebCore
2010-06-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make HTML5Lexer go fast
https://bugs.webkit.org/show_bug.cgi?id=40048
This patch changes us from using a jump table for each character to
using absolute jumps between parser states. This appears to be about a
1% improvement on the parser bench mark (which is 1/10th of what we
need to catch the old parser).
I've kept the underlying logic as close to the old logic as possible.
This new form will make it easier to handle the input stream part of
the spec and to make further performance improvements.
- html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::reset): (WebCore::HTML5Lexer::nextToken): (WebCore::HTML5Lexer::emitCurrentToken):
- html/HTML5Lexer.h:
- 11:25 PM Changeset in webkit [60738] by
-
- 7 edits in trunk
2010-06-04 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
HTML5 parser should be within 1% of old parser performance
https://bugs.webkit.org/show_bug.cgi?id=40172
Fix cast in this operator= to allow for assignment between vectors with
different inline capacities (as clearly intended by its author).
- wtf/Vector.h: (WTF::::operator):
2010-06-04 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
HTML5 parser should be within 1% of old parser performance
https://bugs.webkit.org/show_bug.cgi?id=40172
Stop using adopt(). I think this function is cause us to do extra
mallocs that are hurting performance. Instead of caching AtomicString
on HTML5Token, just use the AtomicString on the old token. Also,
reserve inline capacity for 10 attributes.
- html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::isAppropriateEndTag):
- html/HTML5Lexer.h:
- html/HTML5Token.h: (WebCore::HTML5Token::beginStartTag): (WebCore::HTML5Token::beginEndTag): (WebCore::HTML5Token::beginCharacter): (WebCore::HTML5Token::beginComment): (WebCore::HTML5Token::beginDOCTYPE): (WebCore::HTML5Token::name): (WebCore::HTML5Token::characters): (WebCore::HTML5Token::comment):
- html/HTML5TreeBuilder.cpp: (WebCore::convertToOldStyle): (WebCore::HTML5TreeBuilder::passTokenToLegacyParser):
- 11:07 PM Changeset in webkit [60737] by
-
- 2 edits in trunk/WebCore
2010-06-04 Anders Bakken <agbakken@gmail.com>
Reviewed by Eric Seidel.
[Qt] ScrollbarThemeQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39764
- platform/qt/ScrollbarThemeQt.cpp: (WebCore::scPart): (WebCore::scrollbarPart): (WebCore::styleOptionSlider):
- 10:51 PM Changeset in webkit [60736] by
-
- 2 edits in trunk/WebCore
2010-06-04 Anders Bakken <agbakken@gmail.com>
Reviewed by Eric Seidel.
[Qt] SharedTimerQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39763
- platform/qt/SharedTimerQt.cpp:
- 10:39 PM Changeset in webkit [60735] by
-
- 2 edits in trunk/WebCore
2010-06-04 Anders Bakken <agbakken@gmail.com>
Reviewed by Eric Seidel.
WidgetQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39759
- platform/qt/WidgetQt.cpp:
- 10:27 PM Changeset in webkit [60734] by
-
- 2 edits in trunk/WebCore
2010-06-04 Anders Bakken <agbakken@gmail.com>
Reviewed by Eric Seidel.
TemporaryLinkStubsQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39761
- platform/qt/TemporaryLinkStubsQt.cpp:
- 10:14 PM Changeset in webkit [60733] by
-
- 2 edits in trunk/WebCore
2010-06-04 Anders Bakken <agbakken@gmail.com>
Reviewed by Eric Seidel.
[Qt] SoundQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39762
- platform/qt/SoundQt.cpp:
- 9:53 PM Changeset in webkit [60732] by
-
- 2 edits in trunk/WebKitTools
2010-06-04 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Ojan Vafai.
Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633.
https://bugs.webkit.org/show_bug.cgi?id=40183
- Scripts/webkitpy/tool/steps/preparechangelog.py:
- 9:41 PM Changeset in webkit [60731] by
-
- 5 edits in trunk
2010-06-04 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Dirk Schulze.
Canvas createPattern(img, repetition) shouldn't throw INVALID_STATE_ERR when !img.complete
https://bugs.webkit.org/show_bug.cgi?id=40166
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-createpattern
- http/tests/misc/canvas-pattern-from-incremental-image-expected.txt: Updated baseline.
- http/tests/misc/canvas-pattern-from-incremental-image.html: Fleshed out test.
2010-06-04 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Dirk Schulze.
Canvas createPattern(img, repetition) shouldn't throw INVALID_STATE_ERR when !img.complete
https://bugs.webkit.org/show_bug.cgi?id=40166
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-createpattern
Test: http/tests/misc/canvas-pattern-from-incremental-image.html (updated)
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
- 8:52 PM Changeset in webkit [60730] by
-
- 2 edits in trunk/WebCore
2010-06-04 Anders Bakken <agbakken@gmail.com>
Reviewed by David Levin.
[Qt] Localizations.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39773
- platform/qt/Localizations.cpp: (WebCore::localizedMediaTimeDescription):
- 8:40 PM Changeset in webkit [60729] by
-
- 2 edits in trunk/WebCore
2010-06-04 Lyon Chen <liachen@rim.com>
Reviewed by Darin Adler.
ApplicationCacheStorage::storeNewestCache() Crash WebKit when openDatabase(true) failed
https://bugs.webkit.org/show_bug.cgi?id=40074
Adding m_database.isOpen() check for every openDatabase(true) call, this is needed because
openDatabase(true) could still fail, for example when cacheStorage is full or no longer available.
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::store): (WebCore::ApplicationCacheStorage::storeNewestCache):
- 6:28 PM Changeset in webkit [60728] by
-
- 4 edits in trunk/WebCore
2010-06-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r60684.
http://trac.webkit.org/changeset/60684
https://bugs.webkit.org/show_bug.cgi?id=40196
This patch broke chromium reliability tests (Requested by
tonyg-cr on #webkit).
- bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::evaluate):
- bindings/v8/V8Proxy.h:
- 6:21 PM WebKit Team edited by
- (diff)
- 6:12 PM Changeset in webkit [60727] by
-
- 6 edits2 adds in trunk
AX: need an aria-help
https://bugs.webkit.org/show_bug.cgi?id=40010
Reviewed by David Kilzer.
WebCore:
Test: accessibility/aria-help.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::helpText):
- html/HTMLAttributeNames.in:
LayoutTests:
- accessibility/aria-help-expected.txt: Added.
- accessibility/aria-help.html: Added.
- platform/gtk/Skipped:
- platform/win/Skipped:
- 5:43 PM Changeset in webkit [60726] by
-
- 4 edits in trunk
2010-06-04 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Canvas arc() with zero radius should draw a line to the start point
https://bugs.webkit.org/show_bug.cgi?id=40164
Unskip canvas/philip/tests/2d.path.arc.zeroradius.html
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arc
- platform/qt/Skipped:
2010-06-04 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Canvas arc() with zero radius should draw a line to the start point
https://bugs.webkit.org/show_bug.cgi?id=40164
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arc
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):
- 5:23 PM Changeset in webkit [60725] by
-
- 6 edits in trunk/JavaScriptCore
2010-06-04 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
New QtScript API; QScriptValue::instanceOf.
New function create an easy way to check value's prototype hierarchy.
[Qt] QScriptValue should have an instanceOf method
https://bugs.webkit.org/show_bug.cgi?id=40120
- qt/api/qscriptvalue.cpp: (QScriptValue::instanceOf):
- qt/api/qscriptvalue.h:
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::instanceOf):
- qt/tests/qscriptvalue/tst_qscriptvalue.h:
- qt/tests/qscriptvalue/tst_qscriptvalue_generated_comparison.cpp: (tst_QScriptValue::instanceOf_initData): (tst_QScriptValue::instanceOf_makeData): (tst_QScriptValue::instanceOf_test):
- 5:12 PM Changeset in webkit [60724] by
-
- 2 edits in trunk/WebCore
2010-06-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] RenderThemeGtk leaks memory
https://bugs.webkit.org/show_bug.cgi?id=40168
Call gtk_widget_destroy in the RenderThemeGtk destructor. This cleans
up all widget resources when a theme is destroyed.
No new tests, because functionality has not changed.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::~RenderThemeGtk): Call gtk_widget_destroy on m_gtkWindow.
- 5:11 PM Changeset in webkit [60723] by
-
- 2 edits in trunk/WebCore
2010-06-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] RenderThemeGtk leaks memory
https://bugs.webkit.org/show_bug.cgi?id=40168
Remove the use of releaseRef to assign a value to a RefPtr. This results in
the original pointer taking an extra reference.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::initMediaStyling): Remove the use of releaseRef here.
- 5:10 PM Changeset in webkit [60722] by
-
- 8 edits in trunk/WebKit/win
WebFrame::paintDocumentRectToContextAtPoint doesn't paint scrollbars
https://bugs.webkit.org/show_bug.cgi?id=40034
<rdar://problem/7799848>
Reviewed by Jon Honeycutt.
- WebFrame.cpp:
(WebFrame::paintScrollViewRectToContextAtPoint): Renamed from paintDocumentRectToContextAtPoint.
Call paint() instead of paintContents(). Also move the dirtyRect to counteract the moving that happens in paint().
Just renaming changes:
- Interfaces/IWebFramePrivate.idl:
- Interfaces/IWebViewPrivate.idl:
- WebFrame.h:
- WebView.cpp:
(WebView::paintScrollViewRectToContextAtPoint):
- WebView.h:
- Interfaces/WebKit.idl: Touched for rebuild.
- 4:54 PM Changeset in webkit [60721] by
-
- 2 edits in trunk/WebKit2
Added a couple of symbols needed to start using WKFrameRefs in Mac clients.
Rubber-stamped by Ada Chan.
- mac/WebKit2.exp:
Added _WKFrameRelease and _WKFrameRetain.
- 4:38 PM Changeset in webkit [60720] by
-
- 2 edits in trunk/JavaScriptCore
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
Reviewed by NOBODY (interpreter build fix).
- 4:20 PM Changeset in webkit [60719] by
-
- 1 edit in trunk/WebCore/html/HTML5Lexer.cpp
Actually disable the correct warning.
- 4:11 PM Changeset in webkit [60718] by
-
- 2 edits in trunk/WebKitTools
2010-06-04 Martin Robinson <mrobinson@igalia.com>
Unreviewed.
Add my new email and IRC nick to committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 4:08 PM Changeset in webkit [60717] by
-
- 2 edits in trunk/WebCore
2010-06-04 Adam Barth <abarth@webkit.org>
Reviewed by Gavin Barraclough.
Try to fix the windows build
https://bugs.webkit.org/show_bug.cgi?id=40189
Suppress the "unreachable code" warning because we want to assert that
we don't reach certain code points.
- html/HTML5Lexer.cpp:
- 3:57 PM Changeset in webkit [60716] by
-
- 5 edits in trunk/JavaScriptCore
Silence some warnings seen on the build bot.
- JavaScriptCore.JSVALUE32_64only.exp: Add a trailing newline.
- JavaScriptCore.JSVALUE32only.exp: Ditto.
- JavaScriptCore.JSVALUE64only.exp: Ditto.
- JavaScriptCore.xcodeproj/project.pbxproj: Remove the .exp files from all targets so that Xcode doesn't
complain about not knowing how to compile them.
- 3:51 PM Changeset in webkit [60715] by
-
- 2 edits in trunk/LayoutTests
2010-06-04 Martin Robinson <mrobinson@igalia.com>
Unreviewed.
Skipping another test which shows 1-pixel differences between the
32-bit and 64-bit bot.
- platform/gtk/Skipped:
- 3:48 PM Changeset in webkit [60714] by
-
- 2 edits in trunk/WebKitTools
2010-06-04 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed.
Revert changes in json_results_generator.py's _get_svn_revision.
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- 3:19 PM Changeset in webkit [60713] by
-
- 2 edits in trunk/WebKitTools
2010-06-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] GtkLauncher should support relative file paths
https://bugs.webkit.org/show_bug.cgi?id=39944
Allow GtkLauncher to handle relative file paths passed via command-line arguments.
- GtkLauncher/main.c: (filename_to_url): Added. (main): Try to resolve arguments as relative file URLs first.
- 3:12 PM Changeset in webkit [60712] by
-
- 2 edits in trunk/WebCore
2010-06-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make HTML5Lexer go fast
https://bugs.webkit.org/show_bug.cgi?id=40048
A couple more cases like the previous patch that I missed.
- html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
- 2:56 PM Changeset in webkit [60711] by
-
- 2 edits in trunk/WebCore
2010-06-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make HTML5Lexer go fast
https://bugs.webkit.org/show_bug.cgi?id=40048
Make all the state transitions in the machine explicit. This allows us
to remove all the break statements, which won't work correctly after we
change the macro definitions.
Also, while I was looking at every line of code, I fixed a bunch of the
one-line-if style errors introduces in my previous patches.
- html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
- 2:56 PM Changeset in webkit [60710] by
-
- 1 edit20 adds in trunk/LayoutTests
2010-06-04 Martin Robinson <mrobinson@igalia.com>
Unreviewed.
Adding baselines for new tests. They all seem to be working fine.
- platform/gtk/editing/selection/range-between-block-and-inline-expected.txt: Added.
- platform/gtk/fast/css/font-face-in-shadow-DOM-expected.txt: Added.
- platform/gtk/fast/lists/alpha-boundary-values-expected.txt: Added.
- platform/gtk/fast/multicol/span/anonymous-style-inheritance-expected.txt: Added.
- platform/gtk/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Added.
- platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
- platform/gtk/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Added.
- platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
- platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
- platform/gtk/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Added.
- platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Added.
- platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
- platform/gtk/fast/multicol/span/span-margin-collapsing-expected.txt: Added.
- platform/gtk/fast/repaint/layout-state-scrolloffset-expected.txt: Added.
- platform/gtk/fast/repaint/layout-state-scrolloffset2-expected.txt: Added.
- platform/gtk/fast/repaint/layout-state-scrolloffset3-expected.txt: Added.
- platform/gtk/svg/filters/feLighting-crash-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/feLighting-crash-expected.txt.
- platform/gtk/svg/filters/parent-children-with-same-filter-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/parent-children-with-same-filter-expected.txt.
- 2:47 PM Changeset in webkit [60709] by
-
- 2 edits in trunk/WebKit/gtk
2010-06-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Drag gesture can take mouse grab indefinitely
https://bugs.webkit.org/show_bug.cgi?id=32840
Initiate drag events with the current GTK+ event instead of synthesizing
an event. Something about synthesized events is causing a drag freeze in
certain situations.
- WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag): Start the drag with the current GTK+ event.
- 2:38 PM Changeset in webkit [60708] by
-
- 45 edits in trunk
Bug 40187 - Change function signature of NativeConstructor to match NativeFunction
Reviewed by Oliver Hunt.
Mostly for consistency, but constructor & args arguments are redundant,
and this will help if we wish to be able to JIT calls to more constructors.
- API/JSCallbackConstructor.cpp:
(JSC::constructJSCallback):
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h:
(JSC::::construct):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::executeConstruct):
- interpreter/Interpreter.h:
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/ArrayConstructor.cpp:
(JSC::constructWithArrayConstructor):
- runtime/BooleanConstructor.cpp:
(JSC::constructWithBooleanConstructor):
- runtime/ConstructData.cpp:
(JSC::construct):
- runtime/ConstructData.h:
- runtime/DateConstructor.cpp:
(JSC::constructWithDateConstructor):
- runtime/Error.cpp:
(JSC::constructNativeError):
(JSC::Error::create):
- runtime/ErrorConstructor.cpp:
(JSC::constructWithErrorConstructor):
- runtime/FunctionConstructor.cpp:
(JSC::constructWithFunctionConstructor):
- runtime/NativeErrorConstructor.cpp:
(JSC::constructWithNativeErrorConstructor):
- runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::errorStructure):
- runtime/NumberConstructor.cpp:
(JSC::constructWithNumberConstructor):
- runtime/ObjectConstructor.cpp:
(JSC::constructWithObjectConstructor):
- runtime/RegExpConstructor.cpp:
(JSC::constructWithRegExpConstructor):
- runtime/StringConstructor.cpp:
(JSC::constructWithStringConstructor):
WebCore:
- bindings/js/JSArrayBufferConstructor.cpp:
(WebCore::constructCanvasArrayBuffer):
- bindings/js/JSAudioConstructor.cpp:
(WebCore::constructAudio):
- bindings/js/JSEventSourceConstructor.cpp:
(WebCore::constructEventSource):
- bindings/js/JSFloatArrayConstructor.cpp:
(WebCore::constructCanvasFloatArray):
- bindings/js/JSImageConstructor.cpp:
(WebCore::constructImage):
- bindings/js/JSInt16ArrayConstructor.cpp:
(WebCore::constructCanvasShortArray):
- bindings/js/JSInt32ArrayConstructor.cpp:
(WebCore::constructCanvasIntArray):
- bindings/js/JSInt8ArrayConstructor.cpp:
(WebCore::constructCanvasByteArray):
- bindings/js/JSMessageChannelConstructor.cpp:
(WebCore::JSMessageChannelConstructor::construct):
- bindings/js/JSMessageChannelConstructor.h:
- bindings/js/JSOptionConstructor.cpp:
(WebCore::constructHTMLOptionElement):
- bindings/js/JSSharedWorkerConstructor.cpp:
(WebCore::constructSharedWorker):
- bindings/js/JSUint16ArrayConstructor.cpp:
(WebCore::constructCanvasUnsignedShortArray):
- bindings/js/JSUint32ArrayConstructor.cpp:
(WebCore::constructCanvasUnsignedIntArray):
- bindings/js/JSUint8ArrayConstructor.cpp:
(WebCore::constructCanvasUnsignedByteArray):
- bindings/js/JSWebKitCSSMatrixConstructor.cpp:
(WebCore::constructWebKitCSSMatrix):
- bindings/js/JSWebKitPointConstructor.cpp:
(WebCore::constructWebKitPoint):
- bindings/js/JSWebSocketConstructor.cpp:
(WebCore::constructWebSocket):
- bindings/js/JSWorkerConstructor.cpp:
(WebCore::constructWorker):
- bindings/js/JSXMLHttpRequestConstructor.cpp:
(WebCore::constructXMLHttpRequest):
- bindings/js/JSXSLTProcessorConstructor.cpp:
(WebCore::constructXSLTProcessor):
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/runtime_object.cpp:
(JSC::Bindings::callRuntimeConstructor):
- 2:06 PM Changeset in webkit [60707] by
-
- 1 edit in branches/audio/WebCore/audio/RealtimeAnalyser.cpp
Don't crash if null array passed into real-time analyser
- 1:58 PM Changeset in webkit [60706] by
-
- 2 edits in trunk/LayoutTests
2010-06-04 Stephen White <senorblanco@chromium.org>
Unreviewed; expectations fix.
Fix chromium test expectations, post-r60693. We are still failing the test in the same way, but since there are now fallback results, our results are no longer MISSING, but TEXT.
- platform/chromium/test_expectations.txt:
- 1:54 PM Changeset in webkit [60705] by
-
- 4 edits in trunk/WebKit2
Reviewed by Anders Carlsson.
Need to close WebPageProxy when the WebView is destroyed.
Also, WebPageProxy shouldn't hold an OwnPtr to the PageClient, which is the WebView on Windows.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): (WebKit::WebPageProxy::setPageClient):
- UIProcess/WebPageProxy.h:
- UIProcess/win/WebView.cpp: (WebKit::WebView::close):
- 1:06 PM Changeset in webkit [60704] by
-
- 2 edits in trunk/WebCore
2010-06-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make HTML5Lexer go fast
https://bugs.webkit.org/show_bug.cgi?id=40048
Change the intent of the loop to match what it's going to be once we
remove the loop. This is a whitespace only change that will make the
final diff much, much smaller. Sorry for the transient ugly style.
- html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
- 1:00 PM Changeset in webkit [60703] by
-
- 2 edits in trunk/WebCore
2010-06-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make HTML5Lexer go fast
https://bugs.webkit.org/show_bug.cgi?id=40048
Introduce ADVANCE_TO macro. This is the last macro we need to
introduce.
- html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
- 12:54 PM Changeset in webkit [60702] by
-
- 2 edits in trunk/WebCore
2010-06-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make HTML5Lexer go fast
https://bugs.webkit.org/show_bug.cgi?id=40048
Fix the rest of the RECONSUME_IN cases that were missed by our script.
Also, reorder some assigment to prepare for the ADVANCE_TO patch.
- html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
- 12:44 PM Changeset in webkit [60701] by
-
- 2 edits in trunk/WebCore
2010-06-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make HTML5Lexer go fast
https://bugs.webkit.org/show_bug.cgi?id=40048
This patch handles the FLUSH_AND_ADVANCE_TO case. Again, this patch
introduces style errors that will be fixed shortly.
- html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
- 12:41 PM Changeset in webkit [60700] by
-
- 2 edits in trunk/WebKitTools
2010-06-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly
https://bugs.webkit.org/show_bug.cgi?id=40182
Instead of invoking signal handlers directly via g_signal_emit_by_name, call
gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit
without breaking DRT.
- DumpRenderTree/gtk/EventSender.cpp: (dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly. (keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event.
- 12:38 PM Changeset in webkit [60699] by
-
- 2 edits in trunk/WebCore
2010-06-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make HTML5Lexer go fast
https://bugs.webkit.org/show_bug.cgi?id=40048
This patch handles the FLUSH_EMIT_AND_RESUME_IN case. This patch
introduces some bad style w.r.t. one-line if statements, but we'll fix
them all automatically in cleanup patch when we're done.
- html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
- 12:37 PM Changeset in webkit [60698] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-06-04 Stephen White <senorblanco@chromium.org>
Unreviewed; build fix.
[CHROMIUM] Add new chromium test results for new layout test svg/filters/filter-on-filter-for-text.svg
- platform/chromium-linux/svg/filters/filter-on-filter-for-text-expected.checksum: Added.
- platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.checksum: Added.
- platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.png: Added.
- platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.txt: Added.
- 12:30 PM Changeset in webkit [60697] by
-
- 2 edits in trunk/WebCore
2010-06-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make HTML5Lexer go fast
https://bugs.webkit.org/show_bug.cgi?id=40048
More small steps. This patch deals with emitting tokens.
- html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
- 12:19 PM Changeset in webkit [60696] by
-
- 2 edits in trunk/WebCore
2010-06-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make HTML5Lexer go fast
https://bugs.webkit.org/show_bug.cgi?id=40048
The next step: using macros to delimit each state. Evetually, we're
going to change what these macros expand to.
- html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
- 12:13 PM Changeset in webkit [60695] by
-
- 2 edits in trunk/WebKit/chromium
2010-06-04 Jay Civelli <jcivelli@chromium.org>
Reviewed by Dimitri Glazkov.
Accessibility focus change notifications are now sent from
ChromeClientImpl::focusedNodeChanged().
https://bugs.webkit.org/show_bug.cgi?id=39792
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::focus): (WebKit::ChromeClientImpl::focusedNodeChanged):
- 12:06 PM Changeset in webkit [60694] by
-
- 2 edits in trunk/WebCore
2010-06-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make HTML5Lexer go fast
https://bugs.webkit.org/show_bug.cgi?id=40048
We're going to do this patch in small steps to make it easier to verify correctness.
- html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
- 12:03 PM Changeset in webkit [60693] by
-
- 4 edits1 add3 deletes in trunk
2010-06-04 Anders Carlsson <andersca@apple.com>
Reviewed by David Hyatt.
Make the editing/spelling/context-menu-suggestions.html test more robust
https://bugs.webkit.org/show_bug.cgi?id=40178
- editing/spelling/context-menu-suggestions-expected.txt: Added. Add new expected test result.
- editing/spelling/context-menu-suggestions.html: Instead of dumping the menu item titles, check the length and check that the number of items is greater when there are spell checker suggestions.
- platform/mac-leopard/editing/spelling/context-menu-suggestions-expected.txt: Removed.
- platform/mac-snowleopard/editing/spelling/context-menu-suggestions-expected.txt: Removed.
- platform/mac-tiger/editing/spelling/context-menu-suggestions-expected.txt: Removed. Remove platform specific versions.
2010-06-04 Anders Carlsson <andersca@apple.com>
Reviewed by David Hyatt.
Make the editing/spelling/context-menu-suggestions.html test more robust
https://bugs.webkit.org/show_bug.cgi?id=40178
Change the contextClick method to return an array of strings describing the context menu items.
- DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController contextClick]):
- 11:48 AM Changeset in webkit [60692] by
-
- 4 edits in trunk
2010-06-04 Jay Civelli <jcivelli@chromium.org>
Reviewed by David Levin.
[chromium] Adding support for the left and right Windows keys to the
NativeWebKeyboardEvent.
- platform/chromium/KeyCodeConversionGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent):
2010-06-04 Jay Civelli <jcivelli@chromium.org>
Reviewed by David Levin.
[chromium] Adding support for the left and right Windows keys to the
NativeWebKeyboardEvent.
- src/gtk/WebInputEventFactory.cpp: (WebKit::gdkEventToWindowsKeyCode):
- 11:25 AM Changeset in webkit [60691] by
-
- 5 edits in trunk/WebKit2
Reviewed by Adam Roben.
Need to remove the WebView from WindowMessageBroadcaster's listeners list when the WebView is destroyed.
- UIProcess/API/win/WKView.cpp: (WKViewSetHostWindow): Expose API to change the host window of a WKView. (WKViewWindowAncestryDidChange): Expose API to allow clients to notify WebKit when a WKView's window ancestry has changed.
- UIProcess/API/win/WKView.h:
- UIProcess/win/WebView.cpp: (WebKit::WebView::wndProc): Set the WebView's host window to 0 when it's destroyed. setHostWindow() will call windowAncestryDidChange(), which will remove this WebView from the WindowMessageBroadcaster's listeners list. (WebKit::WebView::WebView): Initialize m_isBeingDestroyed. (WebKit::WebView::setHostWindow): Update the window's parent window and call windowAncestryDidChange(). (WebKit::WebView::close): Set the host window to 0.
- UIProcess/win/WebView.h:
- 11:19 AM Changeset in webkit [60690] by
-
- 5 edits in trunk/WebKitTools
2010-06-03 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Shinichiro Hamaji.
Clean up chromium-specific code from json_results_generator.py.
https://bugs.webkit.org/show_bug.cgi?id=39665
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 11:02 AM Changeset in webkit [60689] by
-
- 5 edits4 adds in trunk
2010-06-04 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG filter on filter don't work
https://bugs.webkit.org/show_bug.cgi?id=32708
Any child of <text> was not allowed to use the same filter as the text root.
I couldn't found any reason in the SVG specification that legimitate this.
Only batik also doesn't allow the same filter on the text root as on it's childs,
while any other effect is still allowed.
I removed this limitation so that the result looks like the result on Firefox.
Test: svg/filters/filter-on-filter-for-text.svg
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent):
- rendering/SVGRenderSupport.h:
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker): (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback): (WebCore::SVGRootInlineBox::paint):
2010-06-04 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVG filter on filter don't work
https://bugs.webkit.org/show_bug.cgi?id=32708
Test that a filter can be used by the text root as well as on it's childs.
- platform/mac/svg/filters/filter-on-filter-for-text-expected.checksum: Added.
- platform/mac/svg/filters/filter-on-filter-for-text-expected.png: Added.
- platform/mac/svg/filters/filter-on-filter-for-text-expected.txt: Added.
- svg/filters/filter-on-filter-for-text.svg: Added.
- 10:41 AM Changeset in webkit [60688] by
-
- 7 edits in trunk/WebCore
2010-06-04 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Factor PageCache functionality out of FrameLoader and into
PageCache itself.
Refactor only, so no new tests.
- history/PageCache.cpp: (WebCore::pageCacheLogPrefix): (WebCore::pageCacheLog): (WebCore::logCanCacheFrameDecision): (WebCore::logCanCachePageDecision): (WebCore::PageCache::canCachePageContainingThisFrame): (WebCore::PageCache::canCache): (WebCore::PageCache::add): (WebCore::PageCache::get):
- history/PageCache.h:
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitIfReady):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::prepareForCachedPageRestore): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::loadProvisionalItemFromCachedPage): (WebCore::FrameLoader::navigateToDifferentDocument):
- loader/FrameLoader.h: (WebCore::FrameLoader::quickRedirectComing):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
- 10:23 AM Changeset in webkit [60687] by
-
- 3 edits in trunk/WebCore
2010-06-04 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Web Inspector: it would be better to push object properties to JSON string in order of insertion.
https://bugs.webkit.org/show_bug.cgi?id=40140
- inspector/InspectorValues.cpp: (WebCore::InspectorObject::writeJSON):
- inspector/InspectorValues.h: (WebCore::InspectorObject::setBool): (WebCore::InspectorObject::setNumber): (WebCore::InspectorObject::setString): (WebCore::InspectorObject::set):
- 10:07 AM Changeset in webkit [60686] by
-
- 2 edits in trunk/WebKit/qt
2010-06-04 Laszlo Gombos <Laszlo Gombos>
Symbian build fix.
[Qt] Updated the def file with recent new exports.
- symbian/eabi/QtWebKitu.def:
- 10:05 AM Changeset in webkit [60685] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
Unskip fast/dom/Window/window-properties-geolocation.html - a comment says it should be
enabled once bug 34025 is fixed, which happened long ago. The test passes for me.
- platform/mac/Skipped:
- 9:59 AM Changeset in webkit [60684] by
-
- 4 edits in trunk/WebCore
2010-06-04 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Persist V8's ScriptData to the memory cache.
https://bugs.webkit.org/show_bug.cgi?id=38661
This stores V8's ScriptData in the memory cache and also causes the
network platform layer to be notified of the available cacheable
metadata.
Chromium's morejs benchmark shows a 3-4% improvement on fast hardware.
No new tests because no new functionality.
- bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::cachedScript):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::precompileScript): (WebCore::V8Proxy::evaluate):
- bindings/v8/V8Proxy.h:
- 9:44 AM Changeset in webkit [60683] by
-
- 17 edits in trunk
2010-06-04 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Add a takeFirst() method to Deque and use it where appropriate.
https://bugs.webkit.org/show_bug.cgi?id=40089
- wtf/Deque.h: (WTF::::takeFirst):
- wtf/MainThread.cpp: (WTF::dispatchFunctionsFromMainThread):
- wtf/MessageQueue.h: (WTF::::tryGetMessage):
2010-06-04 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Utilize new takeFirst() method where appropriate.
https://bugs.webkit.org/show_bug.cgi?id=40089
No new tests because no new functionality.
- css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::addSubresourceStyleURLs):
- dom/XMLTokenizerLibxml2.cpp: (WebCore::PendingCallbacks::callAndRemoveFirstCallback):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::executeExternalScriptsIfReady):
- platform/text/SegmentedString.cpp: (WebCore::SegmentedString::advanceSubstring):
- storage/Database.cpp: (WebCore::Database::scheduleTransaction):
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::getNextStatement):
- storage/SQLTransactionCoordinator.cpp: (WebCore::SQLTransactionCoordinator::processPendingTransactions):
2010-06-04 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Utilize new takeFirst() method where appropriate.
https://bugs.webkit.org/show_bug.cgi?id=40089
- Platform/CoreIPC/ArgumentDecoder.cpp: (CoreIPC::ArgumentDecoder::removeAttachment):
2010-06-04 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Utilize new takeFirst() method where appropriate.
https://bugs.webkit.org/show_bug.cgi?id=40089
- DumpRenderTree/chromium/EventSender.cpp: (EventSender::replaySavedEvents):
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::WorkQueue::processWork): (LayoutTestController::WorkQueue::reset):
- 8:37 AM Changeset in webkit [60682] by
-
- 2 edits in trunk/WebCore
2010-06-04 Nikita Vasilyev <me@elv1s.ru>
Reviewed by Pavel Feldman.
Web Inspector: better Function.prototype.bind for the internal code.
In the "Event Listeners" pane show handler function instead of Function.prototype.bind.
- inspector/front-end/utilities.js: (Function.prototype.bind.bound): (Function.prototype.bind.bound.toString): (Function.prototype.bind):
- 8:01 AM Changeset in webkit [60681] by
-
- 4 edits in trunk/WebCore
2010-06-04 Alexander Pavlov <apavlov@chromium.org>
Unreviewed, fix Qt build.
Add references to a new file.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/WebKit.qrc:
- 7:17 AM Changeset in webkit [60680] by
-
- 4 edits1 add in trunk/WebCore
2010-06-04 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Eliminate direct dependency of StylesSidebarPane on InspectorBackend
https://bugs.webkit.org/show_bug.cgi?id=40069
No new tests are needed, as this is a refactoring.
- inspector/front-end/CSSStyleModel.js: Added. (WebInspector.CSSStyleModel): (WebInspector.CSSStyleModel.prototype.getStylesAsync): (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync): (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.addRule): (WebInspector.CSSStyleModel.prototype.toggleStyleEnabled): (WebInspector.CSSStyleModel.prototype.setCSSText): (WebInspector.CSSStyleModel.prototype.applyStyleText):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.stylesCallback): (WebInspector.StylesSidebarPane.prototype.update.computedStyleCallback): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._arrayContainsInheritedProperty): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback): (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype):
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.loaded):
- 7:06 AM Changeset in webkit [60679] by
-
- 3 edits in trunk/WebKit/chromium
2010-06-04 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Create resource for DebuggerScript.js.
https://bugs.webkit.org/show_bug.cgi?id=40122
- WebKit.grd:
- public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::debuggerScriptSource):
- 6:50 AM Changeset in webkit [60678] by
-
- 2 edits in trunk/WebKitTools
[Qt] QtTestLauncher should allow notifications by default.
https://bugs.webkit.org/show_bug.cgi?id=40078
Reviewed by Simon Hausmann.
- QtTestBrowser/main.cpp:
(NotificationsPermissionController::NotificationsPermissionController):
(NotificationsPermissionController::checkPermission):
(NotificationsPermissionController::requestPermission):
(LauncherWindow::LauncherWindow):
- 6:26 AM Changeset in webkit [60677] by
-
- 2 edits in trunk/WebCore
[Qt] Compilation fails when compiling against Qt 4.7 and Qt Mobility is installed
https://bugs.webkit.org/show_bug.cgi?id=40116
Reviewed by Tor Arne Vestbø.
CONFIG += mobility has the side-effect of pulling in mobility includes, which conflict
with Qt 4.7's bearer managenent includes and break the build.
- WebCore.pro:
- 5:05 AM Changeset in webkit [60676] by
-
- 2 edits in trunk/WebCore
2010-06-04 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Fix scrolling bug with pages using accelerated compositing.
https://bugs.webkit.org/show_bug.cgi?id=40037
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::drawLayers):
- 4:52 AM Changeset in webkit [60675] by
-
- 15 edits in trunk
2010-06-04 Matthew Delaney <mdelaney@apple.com>
Reviewed by Darin Adler.
CG implementation needed for compression quality in canvas.toDataURL
https://bugs.webkit.org/show_bug.cgi?id=38492
- platform/mac/Skipped:
2010-06-04 Matthew Delaney <mdelaney@apple.com>
Reviewed by Darin Adler.
CG implementation needed for compression quality in canvas.toDataURL
https://bugs.webkit.org/show_bug.cgi?id=38492
Took toDataURL.jpeg.quality.basic.html test off of Skipped list. Passes.
Went the route of avoiding in-band signaling to flag the use of a quality
parameter or not. So, instead of simply passing the quality down as a
double, instead I pass a reference to the quality parameter from where
it comes in just after the JS bindings. Thus, no need for any global
constants to signify when the quality is not specified. Updated the other
platforms to support this (qt was on the only one currently with any
implementation).
- bindings/js/JSHTMLCanvasElementCustom.cpp: Moved range check logic for quality parameter down lower. Updated call to toDataURL to use double* instead of just passing the quality directly. (WebCore::JSHTMLCanvasElement::toDataURL):
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Updated toDataURL call to pass double* (WebCore::V8HTMLCanvasElement::toDataURLCallback):
- dom/CanvasSurface.cpp: Updated method prototype. (WebCore::CanvasSurface::toDataURL):
- dom/CanvasSurface.h: Updated method prototype. (WebCore::CanvasSurface::toDataURL):
- platform/graphics/ImageBuffer.h: Updated method signature to use double* for quality param.
- platform/graphics/cairo/ImageBufferCairo.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL):
- platform/graphics/cg/ImageBufferCG.cpp: Implemented support for quality parametejr when jpeg MIME type used. (WebCore::jpegUTI): (WebCore::utiFromMIMEType): (WebCore::ImageBuffer::toDataURL):
- platform/graphics/haiku/ImageBufferHaiku.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL):
- platform/graphics/qt/ImageBufferQt.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL):
- platform/graphics/skia/ImageBufferSkia.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL):
- platform/graphics/wince/ImageBufferWince.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL):
- platform/graphics/wx/ImageBufferWx.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL):
- 4:06 AM Changeset in webkit [60674] by
-
- 2 edits in trunk/WebKit/chromium
Unreviewed. Rolling out r60671 because it caused a lot of test
failures on Chromium.
- 3:56 AM Changeset in webkit [60673] by
-
- 2 edits in trunk/WebCore
2010-06-04 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Leaks in listDirectory
https://bugs.webkit.org/show_bug.cgi?id=40008
Fixed both leaks.
- platform/gtk/FileSystemGtk.cpp: (WebCore::listDirectory):
- 3:44 AM Changeset in webkit [60672] by
-
- 2 edits in trunk/LayoutTests
Skip fast/dom/Geolocation/callback-to-remote-context2.html on GTK.
https://bugs.webkit.org/show_bug.cgi?id=40153
- platform/gtk/Skipped:
- 3:37 AM QtWebKitJournal edited by
- (diff)
- 3:24 AM Changeset in webkit [60671] by
-
- 2 edits in trunk/WebKit/chromium
2010-06-04 Victoria Kirst <vrk@google.com>
Reviewed by David Levin.
Modifying the WebMediaPlayer interface to be compatible with
a change in chrome.
This is a part 2 of 3 one-sided changes to chrome and WebKit. Chrome
has been updated, so this commit should NOT break chromium anymore.
https://bugs.webkit.org/show_bug.cgi?id=39445
- public/WebMediaPlayer.h: Changed buffered() to be non-const.
- 2:58 AM Changeset in webkit [60670] by
-
- 7 edits in trunk/WebCore
2010-06-04 Anton Muhin <antonm@chromium.org>
Reviewed by Nate Chapin.
[Chromium] get rid of named interceptor on HTMLDocument and introduce/remove accessors when named items get deleted/removed
https://bugs.webkit.org/show_bug.cgi?id=39877
This patch makes callbacks invoked on named items addition/removal
install API accessors and thus there is no more need in
named and indexed interceptors on HTMLDocument which
speeds up invocation of methods on document.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::checkDocumentWrapper): (WebCore::V8DOMWindowShell::updateDocumentWrapperCache): (WebCore::getter): (WebCore::V8DOMWindowShell::namedItemAdded): (WebCore::V8DOMWindowShell::namedItemRemoved):
- bindings/v8/V8DOMWindowShell.h:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::WrapInShadowObject): (WebCore::V8HTMLDocument::GetNamedProperty): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8):
- 2:56 AM Changeset in webkit [60669] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-06-04 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Geolocation needs more LayoutTests to test making callbacks to remote frames
https://bugs.webkit.org/show_bug.cgi?id=40146
This test is similar to callback-to-remote-context.html in that it test making a callback
from a Geolocation object to a remote frame. In callback-to-remote-context.html, the call
chain to the Geolocation method is started from the owning frame. In this test, however,
the call chain is started from the remote frame.
- fast/dom/Geolocation/callback-to-remote-context2-expected.txt: Added.
- fast/dom/Geolocation/callback-to-remote-context2.html: Added.
- fast/dom/Geolocation/script-tests/callback-to-remote-context2.js: Added.
- 2:42 AM QtWebKitJournal edited by
- (diff)
- 2:42 AM Changeset in webkit [60668] by
-
- 9 edits in trunk/WebCore
2010-06-04 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
Change filenameFromString to return CString
https://bugs.webkit.org/show_bug.cgi?id=39494
filenameFromString returns a newly allocated string and the caller must
free the string. GTK and EFL ports use g_free while all others ports use
fastFree. This is confusing because the same function behaves
differently with respect to ports. Change filenameFromString to return
CString.
- platform/FileSystem.cpp: (WebCore::filenameFromString):
- platform/FileSystem.h:
- platform/efl/FileSystemEfl.cpp: (WebCore::filenameFromString):
- platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth):
- platform/gtk/FileSystemGtk.cpp: (WebCore::filenameFromString): (WebCore::filenameForDisplay): (WebCore::fileExists): (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::makeAllDirectories): (WebCore::pathGetFileName): (WebCore::directoryName): (WebCore::listDirectory):
- platform/gtk/SharedBufferGtk.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp):
- platform/posix/SharedBufferPOSIX.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
- 2:32 AM Changeset in webkit [60667] by
-
- 19 edits in trunk/LayoutTests
2010-06-04 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Geolocation LayoutTests should make more careful use of LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=39994
Guards calls to LayoutTestController methods with 'if (window.layoutTestController)'
and adds test output to make it clear if the test can not pass without LayoutTestController.
Also removes superfluous calls to LayoutTestController.waitUntilDone(), which are now made
by js-test-post.js.
- fast/dom/Geolocation/callback-exception-expected.txt:
- fast/dom/Geolocation/script-tests/callback-exception.js:
- fast/dom/Geolocation/script-tests/error.js:
- fast/dom/Geolocation/script-tests/maximum-age.js:
- fast/dom/Geolocation/script-tests/notimer-after-unload.js:
- fast/dom/Geolocation/script-tests/permission-denied-already-clear-watch.js:
- fast/dom/Geolocation/script-tests/permission-denied-already-error.js:
- fast/dom/Geolocation/script-tests/permission-denied-already-success.js:
- fast/dom/Geolocation/script-tests/permission-denied-stops-watches.js:
- fast/dom/Geolocation/script-tests/permission-denied.js:
- fast/dom/Geolocation/script-tests/position-string.js:
- fast/dom/Geolocation/script-tests/reentrant-error.js:
- fast/dom/Geolocation/script-tests/reentrant-success.js:
- fast/dom/Geolocation/script-tests/success.js:
- fast/dom/Geolocation/script-tests/timeout-clear-watch.js:
- fast/dom/Geolocation/script-tests/timeout-zero.js:
- fast/dom/Geolocation/script-tests/timeout.js:
- fast/dom/Geolocation/script-tests/watch.js:
- 1:55 AM Changeset in webkit [60666] by
-
- 4 edits in trunk/WebKitTools
2010-06-04 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Detect whether the user's environment can open a browser.
https://bugs.webkit.org/show_bug.cgi?id=40136
Some environments like cygwin silently fail webbrowser.open() causing
webkit-patch upload not to display any diff. This detects environments
where webbrowser.open() would fail by testing if webbrowser.get()
raises an exception.
- Scripts/webkitpy/common/system/user.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/confirmdiff.py:
- 1:44 AM Changeset in webkit [60665] by
-
- 2 edits in trunk/WebCore
2010-06-04 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix compilation with QT_NO_FEATURE
https://bugs.webkit.org/show_bug.cgi?id=38324
The #ifdef QT_NO_GRAPHICSEFFECT was in the wrong place, would have
made AC not work at all.
No new tests.
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges):
- 1:32 AM Changeset in webkit [60664] by
-
- 4 edits in trunk
2010-06-04 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Failed at http://philip.html5.org/tests/canvas/suite/tests/2d.path.arcTo.ensuresubpath.1.html
https://bugs.webkit.org/show_bug.cgi?id=38645
Remove 2d.path.arcTo.ensuresubpath.1.html from Skipped.
- platform/qt/Skipped:
2010-06-04 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Failed at http://philip.html5.org/tests/canvas/suite/tests/2d.path.arcTo.ensuresubpath.1.html
https://bugs.webkit.org/show_bug.cgi?id=38645
Path arcto function need to ensure there is subpath before it.
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArcTo):
- 1:20 AM Changeset in webkit [60663] by
-
- 4 edits in trunk
2010-06-04 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] failed at http://philip.html5.org/tests/canvas/suite/tests/2d.path.arc.angle.3.html
https://bugs.webkit.org/show_bug.cgi?id=38537
Remove canvas/philip/tests/2d.path.arcTo.2d.path.arc.angle.3.html and
canvas/philip/tests/2d.path.arcTo.2d.path.arc.angle.5.html from Skipped.
- platform/qt/Skipped:
2010-06-04 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] failed at http://philip.html5.org/tests/canvas/suite/tests/2d.path.arc.angle.3.html
https://bugs.webkit.org/show_bug.cgi?id=38537
For path.arc function handle span > 2PI
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):
- 1:08 AM Changeset in webkit [60662] by
-
- 2 edits in trunk/JavaScriptCore
2010-06-04 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Remove a QEXPECT_FAIL flag from an autotest.
Test tst_QScriptEngine::globalObject pass after 36600 bug
fix have been applied.
[Qt] Expected fail in the tst_QScriptEngine::globalObject should be removed.
https://bugs.webkit.org/show_bug.cgi?id=40114
- qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::globalObject):
- 12:58 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 12:57 AM QtWebKitBackportingFixes edited by
- (diff)
- 12:54 AM Changeset in webkit [60661] by
-
- 5 edits in trunk/JavaScriptCore
2010-06-04 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Fix QScriptValue::equals.
Handling for a few edge cases were added. Now comparison between
NaN, an invalid objects should works as supposed.
[Qt] QScriptValue::equals problems
https://bugs.webkit.org/show_bug.cgi?id=40110
- qt/api/qscriptvalue.cpp: (QScriptValue::equals):
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::equals):
- qt/tests/qscriptvalue/tst_qscriptvalue.h:
- qt/tests/qscriptvalue/tst_qscriptvalue_generated_comparison.cpp: (tst_QScriptValue::equals_initData): (tst_QScriptValue::equals_makeData): (tst_QScriptValue::equals_test):
- 12:54 AM QtWebKitBackportingFixes edited by
- (diff)
- 12:48 AM QtWebKitTableOfFeatures20 edited by
- (diff)
- 12:42 AM Changeset in webkit [60660] by
-
- 5 edits in trunk
2010-06-04 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Set attributes.stencil to false by default at context creation
https://bugs.webkit.org/show_bug.cgi?id=40090
- fast/canvas/webgl/context-attributes-expected.txt: Check if the default attributes.stencil == false.
- fast/canvas/webgl/context-attributes.html: Ditto.
2010-06-04 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
Set attributes.stencil to false by default at context creation
https://bugs.webkit.org/show_bug.cgi?id=40090
- platform/graphics/GraphicsContext3D.h: Set default attributes.stencil to false. (WebCore::GraphicsContext3D::Attributes::Attributes):
- 12:07 AM Changeset in webkit [60659] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, test expectation update.
websocket/tests/reload-crash.html sometimes crash.
- platform/chromium/test_expectations.txt:
Jun 3, 2010:
- 11:35 PM Changeset in webkit [60658] by
-
- 5 edits in trunk/WebCore
2010-06-03 Abhishek Arya <inferno@chromium.org>
Reviewed by Eric Carlson.
Fix a crash when trying to use an invalid media src url by
moving the isValid url checks to a central location in
isSafeToLoadURL function. Also added an empty string check
in DocumentLoader::didTellClientAboutLoad.
Test: media/invalid-media-url-crash.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL): (WebCore::HTMLMediaElement::selectNextSourceChild): (WebCore::HTMLMediaElement::getPluginProxyParams):
- loader/DocumentLoader.h: (WebCore::DocumentLoader::didTellClientAboutLoad):
- 11:16 PM Changeset in webkit [60657] by
-
- 6 edits2 adds in trunk
2010-06-03 Abhishek Arya <inferno@chromium.org>
Reviewed by Eric Carlson.
Tests that invalid media src url does not result in crash.
- media/invalid-media-url-crash-expected.txt: Added.
- media/invalid-media-url-crash.html: Added.
- platform/gtk/Skipped:
- platform/qt/Skipped:
2010-06-03 Abhishek Arya <inferno@chromium.org>
Reviewed by Eric Carlson.
Fix a crash when trying to use an invalid media src url by
moving the isValid url checks to a central location in
isSafeToLoadURL function. Also added an empty string check
in DocumentLoader::didTellClientAboutLoad.
Test: media/invalid-media-url-crash.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL): (WebCore::HTMLMediaElement::selectNextSourceChild): (WebCore::HTMLMediaElement::getPluginProxyParams):
- loader/DocumentLoader.h: (WebCore::DocumentLoader::didTellClientAboutLoad):
- 11:09 PM Changeset in webkit [60656] by
-
- 3 edits in trunk/WebKitTools
2010-06-03 Tony Gentilcore <tonyg@chromium.org>
Reviewed by David Levin.
Add dependencies required to link with VS Express 2005.
https://bugs.webkit.org/show_bug.cgi?id=40038
Visual Studio implicitly links against these libs.
VC++ Express does not.
- WebKitAPITest/WebKitAPITestCommon.vsprops:
- WinLauncher/WinLauncher.vcproj:
- 10:57 PM Changeset in webkit [60655] by
-
- 2 edits in trunk/JavaScriptCore
2010-06-03 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
New states in QScriptValuePrivate.
The CSpecial state was divided into CNull and CUndefined. It simplify
the QScriptValue code by avoiding a few "cast" and "if".
Moreover the MSVS compiler didn't like casting between a double and an
enum which is avoided now.
[Qt] The QScriptValuePrivate::CSpecial is too generic.
https://bugs.webkit.org/show_bug.cgi?id=40067
- qt/api/qscriptvalue_p.h: (QScriptValuePrivate::): (QScriptValuePrivate::QScriptValuePrivate): (QScriptValuePrivate::isNull): (QScriptValuePrivate::isUndefined): (QScriptValuePrivate::toString): (QScriptValuePrivate::toNumber): (QScriptValuePrivate::toBool): (QScriptValuePrivate::toObject): (QScriptValuePrivate::assignEngine): (QScriptValuePrivate::isNumberBased):
- 10:14 PM Changeset in webkit [60654] by
-
- 2 edits in trunk/WebKitTools
2010-06-03 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
https://bugs.webkit.org/show_bug.cgi?id=40105
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- kill pywebsocket process when url is not alive and the process is not terminated, not to leave pywebsocket server running.
- fix codecs.open parameters.
- 9:28 PM Changeset in webkit [60653] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Test expectation fix.
Skip fast/dom/Geolocation/callback-to-remote-context.html on GTK.
https://bugs.webkit.org/show_bug.cgi?id=40153
- platform/gtk/Skipped:
- 9:22 PM Changeset in webkit [60652] by
-
- 5 edits in trunk
2010-06-03 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
https://bugs.webkit.org/show_bug.cgi?id=39058
- platform/mac-tiger/Skipped:
- remove websocket/tests from skipped list.
2010-06-03 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
https://bugs.webkit.org/show_bug.cgi?id=39058
- Scripts/ensure-valid-python:
- Perl 5.8 doesn't have File::Temp->newdir(). Use File::Temp->tempdir() instead.
- Add --check-only and --help option.
- --check-only option only checks python version and don't try to install Python 2.5.
- Set executable bit.
- Scripts/old-run-webkit-tests:
- Check if it can run the websocket tests by calling ensure-valid-python --check-only.
- 6:57 PM Changeset in webkit [60651] by
-
- 4 edits in trunk/WebKit/chromium
2010-05-26 MORITA Hajime <morrita@google.com>
Reviewed by Jian Li.
[Chromium] Dragging over an element with scrollbars should scroll the element when dragging near edges
https://bugs.webkit.org/show_bug.cgi?id=39725
Added WebViewImpl::scrollForDragging() to handle scroll-on-drag.
Note that this change handes both source and destination cases.
- public/WebView.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragSourceMovedTo): (WebKit::WebViewImpl::dragTargetDragEnterOrOver): (WebKit::WebViewImpl::scrollForDragging):
- src/WebViewImpl.h:
- 6:44 PM Changeset in webkit [60650] by
-
- 2 edits in trunk/JavaScriptCore
- wtf/Platform.h:
Reviewed by NOBODY (Qt build fix).
- 6:31 PM Changeset in webkit [60649] by
-
- 4 edits in trunk/WebCore
2010-06-03 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r60642.
http://trac.webkit.org/changeset/60642
https://bugs.webkit.org/show_bug.cgi?id=40151
Broke rendering of border images on rotated elements
(Requested by jamesr on #webkit).
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawTiledImage):
- platform/graphics/GraphicsContext.h:
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintNinePieceImage):
- 6:18 PM Changeset in webkit [60648] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Add exceptions for some newly-passing tests in Chromium.
- platform/chromium/test_expectations.txt:
- 5:45 PM Changeset in webkit [60647] by
-
- 3 edits in trunk/WebKit2
Reviewed by Anders Carlsson.
Add UIProcess\API\cpp to the list of additional include directories.
Allow WKViewRef to work with WKRetainPtr on Windows.
- UIProcess/API/cpp/WKRetainPtr.h:
- win/WebKit2.vcproj:
- 5:34 PM Changeset in webkit [60646] by
-
- 3 edits in trunk/JavaScriptCore
Bug 40150 - ENABLE_JIT_OPTIMIZE_NATIVE_CALL on all x86/x86_64 platforms
This was fixed in bug #40094.
Reviewed by Mark Rowe.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- wtf/Platform.h:
- 4:46 PM Changeset in webkit [60645] by
-
- 1 edit5 adds in trunk/LayoutTests
2010-06-03 Steve Block <steveblock@google.com>
Reviewed by Alexey Proskuryakov.
Geolocation needs LayoutTest to test making callbacks to remote frames
https://bugs.webkit.org/show_bug.cgi?id=40129
- fast/dom/Geolocation/callback-to-remote-context-expected.txt: Added.
- fast/dom/Geolocation/callback-to-remote-context.html: Added.
- fast/dom/Geolocation/resources: Added.
- fast/dom/Geolocation/resources/callback-to-remote-context-inner.html: Added.
- fast/dom/Geolocation/script-tests/callback-to-remote-context.js: Added.
- 4:39 PM Changeset in webkit [60644] by
-
- 1 edit18 adds in trunk/LayoutTests
2010-06-03 James Robinson <jamesr@chromium.org>
Unreviewed. Add chromium-specific baselines for new tests added by 60640
- platform/chromium-linux/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
- platform/chromium-linux/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
- platform/chromium-linux/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/layout-state-scrolloffset-expected.png: Added.
- platform/chromium-mac/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
- platform/chromium-mac/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
- platform/chromium-win/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
- platform/chromium-win/fast/repaint/layout-state-scrolloffset-expected.png: Added.
- platform/chromium-win/fast/repaint/layout-state-scrolloffset-expected.txt: Added.
- platform/chromium-win/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
- platform/chromium-win/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
- platform/chromium-win/fast/repaint/layout-state-scrolloffset2-expected.txt: Added.
- platform/chromium-win/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
- platform/chromium-win/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
- platform/chromium-win/fast/repaint/layout-state-scrolloffset3-expected.txt: Added.
- 4:19 PM Changeset in webkit [60643] by
-
- 3 edits in trunk/LayoutTests
2010-06-03 John Gregg <johnnyg@google.com>
Reviewed by David Levin.
notifications: in display+close layout test, don't close the notification
until the display event has been received asynchronously; also don't use
an invalid icon URL, since that should generate an error event.
https://bugs.webkit.org/show_bug.cgi?id=39782
- fast/notifications/notifications-display-close-events.html:
- 4:13 PM Changeset in webkit [60642] by
-
- 4 edits in trunk/WebCore
Reviewed by Beth Dakin.
Pixel cracks in border images when drawing with a scale factor > 1
<rdar://problem/7994266>pixel cracks in border images
https://bugs.webkit.org/show_bug.cgi?id=15720
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawTiledImage):
- platform/graphics/GraphicsContext.h: Added two new methods to support drawing using FloatRect. If the boolean flag roundToPixels is true, the pixels are adjusted with the pixel boundaries.
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintNinePieceImage):
- 3:49 PM Changeset in webkit [60641] by
-
- 3 edits in trunk/WebKit/gtk
2010-06-03 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r60632.
http://trac.webkit.org/changeset/60632
https://bugs.webkit.org/show_bug.cgi?id=40143
This change broke the 64-bit bots. (Requested by mrobinson on
#webkit).
- WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::DragClient): (WebKit::DragClient::startDrag):
- WebCoreSupport/DragClientGtk.h:
- 3:07 PM Changeset in webkit [60640] by
-
- 3 edits18 adds in trunk
2010-06-03 James Robinson <jamesr@chromium.org>
Reviewed by Dan Bernstein.
Take container's scroll offset and clip into account when initializing LayoutState
https://bugs.webkit.org/show_bug.cgi?id=38506
When doing a subtree layout, the initial LayoutState creation needs to
take the layout root container's offset and its scroll offset into account
to create the initial offset. Otherwise if a subtree layout occurs
for a layout root whose container has a non-zero scroll offset
the LayoutState's offset and clip are wrong, resulting in a mispaint.
See the test cases for examples.
Tests: fast/repaint/layout-state-scrolloffset.html
fast/repaint/layout-state-scrolloffset2.html
fast/repaint/layout-state-scrolloffset3.html
- rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState):
2010-06-03 James Robinson <jamesr@chromium.org>
Reviewed by Dan Bernstein.
Tests repainting a layout subtree with scroll offsets
https://bugs.webkit.org/show_bug.cgi?id=38506
Has to be run as a pixel test to be useful.
- layout-state-scrolloffset.html tests the layout root having a non-zero scroll offset.
- layout-state-scrolloffset2.html tests the layout root and its container having
non-zero scroll offsets.
- layout-state-scrolloffset3.html tests the layout root having non-zero a scroll offset
and clipping its descendants.
- fast/repaint/layout-state-scrolloffset.html: Added.
- fast/repaint/layout-state-scrolloffset2.html: Added.
- fast/repaint/layout-state-scrolloffset3.html: Added.
- platform/mac/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
- platform/mac/fast/repaint/layout-state-scrolloffset-expected.png: Added.
- platform/mac/fast/repaint/layout-state-scrolloffset-expected.txt: Added.
- platform/mac/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
- platform/mac/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
- platform/mac/fast/repaint/layout-state-scrolloffset2-expected.txt: Added.
- platform/mac/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
- platform/mac/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
- platform/mac/fast/repaint/layout-state-scrolloffset3-expected.txt: Added.
- platform/mac-leopard/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
- platform/mac-leopard/fast/repaint/layout-state-scrolloffset-expected.png: Added.
- platform/mac-leopard/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
- platform/mac-leopard/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
- platform/mac-leopard/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
- platform/mac-leopard/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
- 2:45 PM Changeset in webkit [60639] by
-
- 3 edits in trunk/WebCore
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::call):
Reviewed by NOBODY (speculative Qt build fix II).
- 2:36 PM Changeset in webkit [60638] by
-
- 2 edits in trunk/WebCore
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::call):
Reviewed by NOBODY (speculative Qt build fix).
- 2:29 PM Changeset in webkit [60637] by
-
- 5 edits in trunk/JavaScriptCore
- JavaScriptCore.JSVALUE32_64only.exp:
- JavaScriptCore.JSVALUE32only.exp:
- JavaScriptCore.JSVALUE64only.exp:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
Reviewed by NOBODY (Interpreter build fix).
- 2:10 PM Changeset in webkit [60636] by
-
- 2 edits in trunk/JavaScriptCore
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Reviewed by NOBODY (windows build fix II).
- 1:49 PM Changeset in webkit [60635] by
-
- 14 edits in trunk/WebKitTools
2010-05-14 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
add a RietveldUploadQueue to upload in-rietveld? patches to rietveld
https://bugs.webkit.org/show_bug.cgi?id=38918
Patches with in-rietveld? get uploaded to rietveld and get marked
in-rietveld+. If the upload fails, they are marked in-rietveld-
and an error is logged to the bug, like the commit-queue.
Also, get rid of --fancy-review and the ability to upload to rietveld
using webkit-patch upload/post.
- Scripts/webkitpy/common/net/bugzilla.py:
- Scripts/webkitpy/common/net/bugzilla_unittest.py:
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/download_unittest.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/commands/upload.py:
- Scripts/webkitpy/tool/commands/upload_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/options.py:
- Scripts/webkitpy/tool/steps/postcodereview.py:
- 1:48 PM Changeset in webkit [60634] by
-
- 2 edits in trunk/JavaScriptCore
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Reviewed by NOBODY (windows build fix).
- 1:20 PM Changeset in webkit [60633] by
-
- 3 edits in trunk/WebKitTools
2010-05-24 Ojan Vafai <ojan@chromium.org>
Reviewed by Chris Jerdonek.
many webkit-patch commands fail in a non-svn tracking git checkout
https://bugs.webkit.org/show_bug.cgi?id=38156
If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master).
If neither exists, then error out. This makes webkit-patch work
for anyone that follows the intructions at http://trac.webkit.org/wiki/UsingGitWithWebKit
to checkout webkit. The fallback to master is for people who don't
do the steps on that page for tracking svn.
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- 1:08 PM Changeset in webkit [60632] by
-
- 3 edits in trunk/WebKit/gtk
2010-06-03 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Drag gesture can take mouse grab indefinitely
https://bugs.webkit.org/show_bug.cgi?id=32840
Start GTK+ drags with the previous mouse button down event instead of
synthesizing the event. The synthesized event was not completely valid
and froze some drags indefinitely.
- WebCoreSupport/DragClientGtk.cpp: (WebKit::buttonPressEvent): Added. (WebKit::DragClient::DragClient): Connect to the 'button-press-event' signal of the WebView. (WebKit::DragClient::startDrag): Instead of synthesizing a button press event use the last real one.
- WebCoreSupport/DragClientGtk.h: (WebKit::DragClient::setLastButtonPressEvent): Added.
- 1:00 PM Changeset in webkit [60631] by
-
- 71 edits in trunk
Bug 40094 - The return type of NativeFunction should be EncodedJSValue
On Windows & Linux, using JSVALUE32_64, EncodedJSValue is returned in registers, but JSValue is not.
Reviewed by Oliver Hunt.
- API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::call):
- API/JSCallbackFunction.h:
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h:
(JSC::::call):
- JavaScriptCore.exp:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::executeCall):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
- jsc.cpp:
(functionPrint):
(functionDebug):
(functionGC):
(functionVersion):
(functionRun):
(functionLoad):
(functionCheckSyntax):
(functionSetSamplingFlags):
(functionClearSamplingFlags):
(functionReadline):
(functionQuit):
- runtime/ArrayConstructor.cpp:
(JSC::callArrayConstructor):
(JSC::arrayConstructorIsArray):
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):
- runtime/BooleanConstructor.cpp:
(JSC::callBooleanConstructor):
- runtime/BooleanPrototype.cpp:
(JSC::booleanProtoFuncToString):
(JSC::booleanProtoFuncValueOf):
- runtime/CallData.h:
- runtime/DateConstructor.cpp:
(JSC::callDate):
(JSC::dateParse):
(JSC::dateNow):
(JSC::dateUTC):
- runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncToLocaleString):
(JSC::dateProtoFuncToLocaleDateString):
(JSC::dateProtoFuncToLocaleTimeString):
(JSC::dateProtoFuncGetTime):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetMilliSeconds):
(JSC::dateProtoFuncGetUTCMilliseconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::dateProtoFuncSetTime):
(JSC::dateProtoFuncSetMilliSeconds):
(JSC::dateProtoFuncSetUTCMilliseconds):
(JSC::dateProtoFuncSetSeconds):
(JSC::dateProtoFuncSetUTCSeconds):
(JSC::dateProtoFuncSetMinutes):
(JSC::dateProtoFuncSetUTCMinutes):
(JSC::dateProtoFuncSetHours):
(JSC::dateProtoFuncSetUTCHours):
(JSC::dateProtoFuncSetDate):
(JSC::dateProtoFuncSetUTCDate):
(JSC::dateProtoFuncSetMonth):
(JSC::dateProtoFuncSetUTCMonth):
(JSC::dateProtoFuncSetFullYear):
(JSC::dateProtoFuncSetUTCFullYear):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear):
(JSC::dateProtoFuncToJSON):
- runtime/ErrorConstructor.cpp:
(JSC::callErrorConstructor):
- runtime/ErrorPrototype.cpp:
(JSC::errorProtoFuncToString):
- runtime/FunctionConstructor.cpp:
(JSC::callFunctionConstructor):
- runtime/FunctionPrototype.cpp:
(JSC::callFunctionPrototype):
(JSC::functionProtoFuncToString):
(JSC::functionProtoFuncApply):
(JSC::functionProtoFuncCall):
- runtime/JSCell.h:
(JSC::getCallData):
(JSC::getConstructData):
- runtime/JSFunction.cpp:
(JSC::callHostFunctionAsConstructor):
- runtime/JSFunction.h:
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
(JSC::globalFuncParseInt):
(JSC::globalFuncParseFloat):
(JSC::globalFuncIsNaN):
(JSC::globalFuncIsFinite):
(JSC::globalFuncDecodeURI):
(JSC::globalFuncDecodeURIComponent):
(JSC::globalFuncEncodeURI):
(JSC::globalFuncEncodeURIComponent):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape):
(JSC::globalFuncJSCPrint):
- runtime/JSGlobalObjectFunctions.h:
- runtime/JSONObject.cpp:
(JSC::JSONProtoFuncParse):
(JSC::JSONProtoFuncStringify):
- runtime/JSObject.cpp:
(JSC::callDefaultValueFunction):
- runtime/JSValue.h:
- runtime/MathObject.cpp:
(JSC::mathProtoFuncAbs):
(JSC::mathProtoFuncACos):
(JSC::mathProtoFuncASin):
(JSC::mathProtoFuncATan):
(JSC::mathProtoFuncATan2):
(JSC::mathProtoFuncCeil):
(JSC::mathProtoFuncCos):
(JSC::mathProtoFuncExp):
(JSC::mathProtoFuncFloor):
(JSC::mathProtoFuncLog):
(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):
(JSC::mathProtoFuncPow):
(JSC::mathProtoFuncRandom):
(JSC::mathProtoFuncRound):
(JSC::mathProtoFuncSin):
(JSC::mathProtoFuncSqrt):
(JSC::mathProtoFuncTan):
- runtime/NativeErrorConstructor.cpp:
(JSC::callNativeErrorConstructor):
- runtime/NumberConstructor.cpp:
(JSC::callNumberConstructor):
- runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToString):
(JSC::numberProtoFuncToLocaleString):
(JSC::numberProtoFuncValueOf):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToPrecision):
- runtime/ObjectConstructor.cpp:
(JSC::callObjectConstructor):
(JSC::objectConstructorGetPrototypeOf):
(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):
(JSC::toPropertyDescriptor):
(JSC::objectConstructorDefineProperty):
(JSC::objectConstructorDefineProperties):
(JSC::objectConstructorCreate):
- runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncValueOf):
(JSC::objectProtoFuncHasOwnProperty):
(JSC::objectProtoFuncIsPrototypeOf):
(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):
(JSC::objectProtoFuncPropertyIsEnumerable):
(JSC::objectProtoFuncToLocaleString):
(JSC::objectProtoFuncToString):
- runtime/ObjectPrototype.h:
- runtime/RegExpConstructor.cpp:
(JSC::callRegExpConstructor):
- runtime/RegExpObject.cpp:
(JSC::callRegExpObject):
- runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncTest):
(JSC::regExpProtoFuncExec):
(JSC::regExpProtoFuncCompile):
(JSC::regExpProtoFuncToString):
- runtime/StringConstructor.cpp:
(JSC::stringFromCharCode):
(JSC::callStringConstructor):
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncToString):
(JSC::stringProtoFuncCharAt):
(JSC::stringProtoFuncCharCodeAt):
(JSC::stringProtoFuncConcat):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncLastIndexOf):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
(JSC::stringProtoFuncSlice):
(JSC::stringProtoFuncSplit):
(JSC::stringProtoFuncSubstr):
(JSC::stringProtoFuncSubstring):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncLocaleCompare):
(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):
(JSC::stringProtoFuncLink):
(JSC::stringProtoFuncTrim):
(JSC::stringProtoFuncTrimLeft):
(JSC::stringProtoFuncTrimRight):
JavaScriptGlue:
- JSObject.cpp:
(nativeCallFunction):
WebCore:
- bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
- bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
- bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::callHTMLAllCollection):
- bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::callHTMLCollection):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::open):
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::createInjectedScript):
- bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::acceptNode):
- bindings/js/JSNodeListCustom.cpp:
(WebCore::callNodeList):
- bindings/js/JSPluginElementFunctions.cpp:
(WebCore::callPlugin):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
(WebCore::ScheduledAction::executeFunctionInContext):
- bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializingTreeWalker::convertIfTerminal):
- bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/NP_jsobject.cpp:
(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Construct):
- bridge/jni/jni_jsobject.mm:
(JavaJSObject::call):
- bridge/objc/objc_runtime.mm:
(JSC::Bindings::callObjCFallbackObject):
- bridge/runtime_method.cpp:
(JSC::callRuntimeMethod):
- bridge/runtime_object.cpp:
(JSC::Bindings::callRuntimeObject):
WebKit/mac:
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::invoke):
- 11:59 AM HackingGtk edited by
- (diff)
- 11:56 AM HackingGtk edited by
- (diff)
- 11:38 AM HackingGtk edited by
- Update source module locations and put the directory first (diff)
- 10:34 AM Changeset in webkit [60630] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Don't send notifications event after the page was navigated away
https://bugs.webkit.org/show_bug.cgi?id=40127
Reviewed by Laszlo Gombos.
Added a check before sending events to the notification and before logging.
- WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::sendEvent):
- 10:33 AM Changeset in webkit [60629] by
-
- 5 edits in branches/safari-533-branch
Versioning.
- 10:30 AM Changeset in webkit [60628] by
-
- 1 copy in tags/Safari-533.16
New tag.
- 10:30 AM Changeset in webkit [60627] by
-
- 2 edits in branches/safari-533-branch/WebCore
Merge r59498.
- 9:42 AM Changeset in webkit [60626] by
-
- 2 edits in trunk/LayoutTests
fast/events/transformaction removed from expectations,
because these tests were rolled-out by r60624.
Rubber-stamped by Simon Hausmann.
- platform/chromium/test_expectations.txt:
- 9:29 AM Changeset in webkit [60625] by
-
- 5 edits in trunk/LayoutTests
Unreviewed, rolling out r60617.
http://trac.webkit.org/changeset/60617
https://bugs.webkit.org/show_bug.cgi?id=40124
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-06-03
Followup patch for rolled-out r60614 (Requested by Ossy on
#webkit).
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 9:25 AM Changeset in webkit [60624] by
-
- 31 edits6 deletes in trunk
Unreviewed, rolling out r60614.
http://trac.webkit.org/changeset/60614
https://bugs.webkit.org/show_bug.cgi?id=40123
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-06-03
It made fast/dom/Window/window-postmessage-clone.html fail on
Mac bots (Requested by Ossy on #webkit).
WebCore:
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- Android.mk:
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- bindings/generic/RuntimeEnabledFeatures.cpp:
- bindings/generic/RuntimeEnabledFeatures.h:
- bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
- bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):
- dom/Document.cpp:
(WebCore::Document::createEvent):
(WebCore::Document::addListenerTypeIfNeeded):
- dom/Document.h:
(WebCore::Document::):
- dom/Document.idl:
- dom/Element.h:
- dom/Element.idl:
- dom/Event.cpp:
(WebCore::Event::fromUserGesture):
- dom/Event.h:
- dom/EventNames.h:
- dom/TransformActionEvent.cpp: Removed.
- dom/TransformActionEvent.h: Removed.
- dom/TransformActionEvent.idl: Removed.
- html/HTMLAttributeNames.in:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
- page/DOMWindow.h:
- page/DOMWindow.idl:
LayoutTests:
- fast/events/transformaction/create-transformaction-event-expected.txt: Removed.
- fast/events/transformaction/create-transformaction-event.html: Removed.
- fast/events/transformaction/resources/create-transformaction-event.js: Removed.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/win/Skipped:
- 9:03 AM Changeset in webkit [60623] by
-
- 4 edits in trunk
2010-06-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[v8] Web Inspector: show "Object" as description for values with anonymous constructor
https://bugs.webkit.org/show_bug.cgi?id=40121
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
2010-06-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[v8] Web Inspector: show "Object" as description for values with anonymous constructor
https://bugs.webkit.org/show_bug.cgi?id=40121
- src/js/DevTools.js: don't call DebuggerAgent methods if ScriptDebugServer is used.
- 8:56 AM Changeset in webkit [60622] by
-
- 2 edits in trunk/WebKit/chromium
[DRT/Chromium] Checking out lighttpd
https://bugs.webkit.org/show_bug.cgi?id=39948
Patch by Kent Tamura <tkent@chromium.org> on 2010-06-03
Reviewed by Dimitri Glazkov.
- Add lighttpd only on Windows. It is used by new-run-webkit-tests.
- Add libvpx.
- Remove pthreads-win32 from DEPS. It has not been used since Chromium r28642.
- Update Chromium revision to use Windows resource query code and webkit_glue dependency fix.
- DEPS:
- 6:38 AM Changeset in webkit [60621] by
-
- 4 edits1 move in trunk/WebCore
[Qt] Fix NPAPI support on Mac OS X/Cocoa-32
Reviewed by Simon Hausmann.
qt_mac_window_for() returns a NSWindow on Cocoa, so we were
passing in a NSWindow instead of a WindowRef as part of the
NP_CGContext.
https://bugs.webkit.org/show_bug.cgi?id=38762
- WebCore.gypi: Reflect rename
- WebCore.pro: Reflect rename
- plugins/mac/PluginViewMac.cpp: Renamed to PluginViewMac.mm
and fix bug by getting the Carbon windowRef from the NSWindow.
- wscript: Reflect rename
- 6:02 AM Changeset in webkit [60620] by
-
- 2 edits in trunk/WebKitTools
2010-06-03 Mike Fenton <mifenton@rim.com>
Unreviewed.
Reverse e-mail for myself in committers.py to correspond with bugzilla account.
- Scripts/webkitpy/common/config/committers.py:
- 4:11 AM Changeset in webkit [60619] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Test expectation update.
- platform/chromium/test_expectations.txt: Restore Mac expectation of fixed-move-after-keyboard-scroll.html.
- 3:04 AM Changeset in webkit [60618] by
-
- 6 edits in trunk
2010-06-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: a number of fixes that make InspectorController
happy with null redirects.
- inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
2010-06-03 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: a number of fixes that make InspectorController
happy with null redirects.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest):
- DumpRenderTree/mac/DumpRenderTree.mm: (runTest):
- DumpRenderTree/win/DumpRenderTree.cpp: (runTest):
- 2:58 AM Changeset in webkit [60617] by
-
- 5 edits in trunk/LayoutTests
Not reviewed: Add TransformActionEvent to the window object tests, after r60614.
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 2:37 AM Changeset in webkit [60616] by
-
- 3 edits in trunk/LayoutTests
Unreviewed. Test expectation update.
Rebaseline fixed-move-after-keyboard-scroll for Chromium-Linux
https://bugs.webkit.org/show_bug.cgi?id=40101
- platform/chromium-linux/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum:
- platform/chromium-linux/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
- 2:24 AM Changeset in webkit [60615] by
-
- 6 edits in trunk/LayoutTests
Unreviewed. Test expectation update.
Rebaseline fixed-move-after-keyboard-scroll, and add an entry for
fast/events/transformaction.
https://bugs.webkit.org/show_bug.cgi?id=40101
- platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum:
- platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
- platform/chromium-win/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum:
- platform/chromium-win/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
- platform/chromium/test_expectations.txt:
- 1:38 AM Changeset in webkit [60614] by
-
- 31 edits8 adds in trunk
Add TransformActionEvent support
https://bugs.webkit.org/show_bug.cgi?id=39757
Patch by Kim Grönholm <kim.1.gronholm@nokia.com> on 2010-06-03
Reviewed by Simon Hausmann.
WebCore:
Added only the necessary TransformAction event interfaces and not e.g.
any eventhandler hooks that generate and dispatch them.
Test: fast/events/transformaction/create-transformaction-event.html
More tests will be added with the machinery that generates and
dispatches these events.
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- Android.mk:
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- bindings/generic/RuntimeEnabledFeatures.cpp:
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::transformactionEnabled):
(WebCore::RuntimeEnabledFeatures::setTransformActionEnabled):
(WebCore::RuntimeEnabledFeatures::ontransformactionstartEnabled):
(WebCore::RuntimeEnabledFeatures::ontransformactionupdateEnabled):
(WebCore::RuntimeEnabledFeatures::ontransformactionendEnabled):
- bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
- bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):
- dom/Document.cpp:
(WebCore::Document::createEvent):
(WebCore::Document::addListenerTypeIfNeeded):
- dom/Document.h:
(WebCore::Document::):
- dom/Document.idl:
- dom/Element.h:
- dom/Element.idl:
- dom/Event.cpp:
(WebCore::Event::isTransformActionEvent):
(WebCore::Event::fromUserGesture):
- dom/Event.h:
- dom/EventNames.h:
- dom/TransformActionEvent.cpp: Added.
(WebCore::TransformActionEvent::TransformActionEvent):
(WebCore::TransformActionEvent::initTransformActionEvent):
- dom/TransformActionEvent.h: Added.
(WebCore::TransformActionEvent::create):
(WebCore::TransformActionEvent::translateX):
(WebCore::TransformActionEvent::translateY):
(WebCore::TransformActionEvent::translateSpeedX):
(WebCore::TransformActionEvent::translateSpeedY):
(WebCore::TransformActionEvent::scale):
(WebCore::TransformActionEvent::scaleSpeed):
(WebCore::TransformActionEvent::rotate):
(WebCore::TransformActionEvent::rotateSpeed):
(WebCore::TransformActionEvent::TransformActionEvent):
(WebCore::TransformActionEvent::isTransformActionEvent):
- dom/TransformActionEvent.idl: Added.
- html/HTMLAttributeNames.in:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
- page/DOMWindow.h:
- page/DOMWindow.idl:
LayoutTests:
- fast/events/transformaction/create-transformaction-event-expected.txt: Added.
- fast/events/transformaction/create-transformaction-event.html: Added.
- fast/events/transformaction/resources/create-transformaction-event.js: Added.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/win/Skipped:
- 1:21 AM Changeset in webkit [60613] by
-
- 19 edits in trunk/LayoutTests
2010-06-03 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: Rebaseline chromium tests as a follow up to r60611.
- platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.checksum:
- platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.png:
- platform/chromium-linux/fast/borders/svg-as-border-image-expected.checksum:
- platform/chromium-linux/scrollbars/listbox-scrollbar-combinations-expected.checksum:
- platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.checksum:
- platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.checksum:
- platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.png:
- platform/chromium-win/fast/borders/svg-as-border-image-expected.checksum:
- platform/chromium-win/fast/borders/svg-as-border-image-expected.png:
- platform/chromium-win/scrollbars/listbox-scrollbar-combinations-expected.checksum:
- platform/chromium-win/scrollbars/listbox-scrollbar-combinations-expected.png:
- platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.checksum:
- platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
- 12:52 AM Changeset in webkit [60612] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, test expectation update.
4 websocket tests don't fail now.
- platform/chromium/test_expectations.txt:
- remove websocket/tests/unicode.html, websocket/tests/send.html, websocket/tests/handshake-error.html and websocket/tests/long-invalid-header.html
- 12:22 AM Changeset in webkit [60611] by
-
- 2 edits in trunk/WebCore
2010-06-03 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Rolling out aggressive cache part of the r60391
described in the bug below. It was orthogonal to the rest of
the patch and caused regression.
- platform/graphics/skia/ImageSkia.cpp: (WebCore::drawResampledBitmap):
- 12:07 AM Changeset in webkit [60610] by
-
- 2 edits in trunk/WebKit/chromium
2010-06-02 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] refactor WebKit.gyp's DRT section so the conditions are less messy
https://bugs.webkit.org/show_bug.cgi?id=40104
- WebKit.gyp:
- 12:03 AM Changeset in webkit [60609] by
-
- 6 edits in trunk
2010-06-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>
Reviewed by Shinichiro Hamaji.
[Qt] Fix compilation with QT_NO_PROPERTIES
https://bugs.webkit.org/show_bug.cgi?id=38324
- Api/qwebpage.cpp: (QWebPage::event):
- Api/qwebpage_p.h:
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend):
2010-06-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>
Reviewed by Shinichiro Hamaji.
[Qt] Fix compilation with QT_NO_PROPERTIES
https://bugs.webkit.org/show_bug.cgi?id=38324
- QtTestBrowser/main.cpp: (LauncherWindow::init):
