Timeline



Jun 7, 2010:

11:36 PM Changeset in webkit [60823] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-07 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] roll chromium DEPS
​https://bugs.webkit.org/show_bug.cgi?id=40277

  • DEPS:
11:26 PM Changeset in webkit [60822] by morrita@google.com
  • 17 edits
    16 adds in trunk

2010-06-07 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

[Mac] <meter> elements should be rendered as level indicators.
​https://bugs.webkit.org/show_bug.cgi?id=40217

  • fast/dom/HTMLMeterElement/meter-appearances-capacity.html: Added.
  • fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy.html: Added.
  • fast/dom/HTMLMeterElement/meter-optimums.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped: removed <meter> related tests.
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt: Copied from LayoutTests/platform/qt/fast/dom/HTMLMeterElement/meter-element-expected.txt.
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
  • platform/win/Skipped:

2010-06-07 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

[Mac] <meter> elements should be rendered as level indicators.
​https://bugs.webkit.org/show_bug.cgi?id=40217

Implemented RenderThemeMac::paintMeter() using NSLevelIndicatorCell.

This change also added new -webkit-appearance values to select the
style of level indicators:

  • relevancy-level-indicator,
  • continuous-capacity-level-indicator,
  • discrete-capacity-level-indicator, and
  • rating-level-indicator.

The size of elements are adjusted based on the bounds of the indicator
to make room for painting whole indicator cells.

Tests: fast/dom/HTMLMeterElement/meter-appearances-capacity.html

fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy.html
fast/dom/HTMLMeterElement/meter-optimums.html

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  • css/CSSValueKeywords.in:
  • html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::gaugeRegion):
  • html/HTMLMeterElement.h: (WebCore::HTMLMeterElement::):
  • platform/ThemeTypes.h: (WebCore::):
  • rendering/RenderMeter.cpp: (WebCore::RenderMeter::calcWidth): (WebCore::RenderMeter::calcHeight):
  • rendering/RenderMeter.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations): (WebCore::RenderTheme::meterSizeForBounds):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::meterSizeForBounds): (WebCore::RenderThemeMac::paintMeter): (WebCore::RenderThemeMac::levelIndicatorStyleFor): (WebCore::RenderThemeMac::levelIndicatorFor):
10:23 PM Changeset in webkit [60821] by morrita@google.com
  • 4 edits in trunk

2010-06-06 MORITA Hajime <​morrita@google.com>

Unreviewd, follow up to r60820

​https://bugs.webkit.org/show_bug.cgi?id=40219
[Mac] ENABLE_METER_TAG should be enabled

Added ENABLE_METER_TAG.

  • Configurations/FeatureDefines.xcconfig:

2010-06-06 MORITA Hajime <​morrita@google.com>

Unreviewd, follow up to r60820

​https://bugs.webkit.org/show_bug.cgi?id=40219
[Mac] ENABLE_METER_TAG should be enabled

  • Configurations/FeatureDefines.xcconfig:
10:02 PM Changeset in webkit [60820] by morrita@google.com
  • 5 edits in trunk

2010-06-07 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

​https://bugs.webkit.org/show_bug.cgi?id=40219
[Mac] ENABLE_METER_TAG should be enabled

Added ENABLE_METER_TAG.

  • Configurations/FeatureDefines.xcconfig:

2010-06-07 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

[Mac] ENABLE_METER_TAG should be enabled.
​https://bugs.webkit.org/show_bug.cgi?id=40219

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.xcodeproj/project.pbxproj:
9:09 PM Changeset in webkit [60819] by tonikitoo@webkit.org
  • 28 edits
    2 deletes in trunk

Revert "Refactor platform dependent editing behavior code out of Settings"

This reverts commit r60816: Crashed all bots.

9:08 PM Changeset in webkit [60818] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

Revert "2010-06-07 Antonio Gomes <​tonikitoo@webkit.org>"

This reverts r60817: Unsuccessful attept to fix the bots.

9:00 PM Changeset in webkit [60817] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

2010-06-07 Antonio Gomes <​tonikitoo@webkit.org>

Unreviewed attempt to fix crashy bots (Mac,Win,Qt,Gtk) after r60816.

  • editing/Editor.cpp: (WebCore::Editor::behavior):
8:08 PM Changeset in webkit [60816] by tonikitoo@webkit.org
  • 28 edits
    2 adds in trunk

Refactor platform dependent editing behavior code out of Settings
​https://bugs.webkit.org/show_bug.cgi?id=39854

Reviewed by Ojan Vafai and Darin Adler.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

WebCore:

As per discussion in bug 36627, the following was suggested by Darin Adler: "before the addition of any
new EditingBehavior, I think we need to add functions to translate the overall behavior policy into specific
behaviors rather than directly saying 'behavior == Mac' or 'behavior == Windows'. Helper functions that
expression the different rules in plain language.".

Patch is a first step of an incremental approach to address this request. It does not yet replace all
direct use of Editing{Mac,Windows}Behaviors, but adds infra for that and replaces some of them.

No behavior change, so no new tests.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore/WebCore.gypi
  • WebCore/WebCore.vcproj/WebCore.vcproj
  • WebCore/WebCore.xcodeproj/project.pbxproj
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h: Moved out EditingBehavior enum to WebCore/editing/EditingBehaviorTypes.h,

and renamed to EditingBehaviorTypes.
(WebCore::Settings::setEditingBehaviorType): Renamed from setEditingBehavior.
(WebCore::Settings::editingBehaviorType): Renamed from editingBehavior.

  • editing/EditingBehavior.h: Added.

(WebCore::EditingBehavior::EditingBehavior): Class to work as a central point for
editing behavior that might have to be handled differently in the different platforms/ports.
Class should be not used or instantiated directly, but rather implicitly constructed
through the Editor class.
(WebCore::EditingBehavior::shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom):
(WebCore::EditingBehavior::shouldConsiderSelectionAsDirectional):
(WebCore::EditingBehavior::shouldCenterAlignWhenSelectionIsRevealed):

  • editing/EditingBehaviorTypes.h: Added.

(WebCore::):

  • editing/Editor.cpp:

(WebCore::Editor::behavior): Getter for EditingBehavior class.

  • editing/Editor.h:
  • editing/EditorCommand.cpp:

(WebCore::executeToggleStyle):
(WebCore::SelectionController::setIsDirectional):
(WebCore::SelectionController::positionForPlatform):
(WebCore::SelectionController::modify):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEventSingleClick):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionForPointWithInlineChildren):

  • Call sites will look like:

if (frame->editor()->behavior().shouldThisIfThat()))

do something

WebKit:

EditingBehavior enum was renamed to EditingBehaviorTypes and moved out from Settings.h to
EditingBehaviorTypes.h . Call sites in WebKit/ adjusted accordingly.

WebKit/chromium:

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setEditingBehavior):

WebKit/gtk:

  • webkit/webkitprivate.cpp:

(WebKit::core):

  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

WebKit/mac:

  • WebView/WebFrame.mm:

(core):

  • WebView/WebFrameInternal.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]):

WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setEditingBehavior):

WebKit/win:

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

7:33 PM Changeset in webkit [60815] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-07 Eric Seidel <​eric@webkit.org>

Unreviewed. Just commit an edit XCode keeps making automatically.

It appears someone hand-edited the file, XCode no-like.

  • WebCore.xcodeproj/project.pbxproj:
7:25 PM Changeset in webkit [60814] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

HTML5 Parser fails script-tests which use document.write
​https://bugs.webkit.org/show_bug.cgi?id=40276

We were leaving the TreeBuilder paused when executing the scripts
resulting in document.write() calls being ignored.

I don't see a good way to ASSERT this correct behavior, since
the HTML5ScriptRunner and the HTML5TreeBuilder do not know about
each other. We should never have document.write() called while
the HTML5TreeBuilder is paused, however both document.write and
the network call the same HTML5Tokenizer::write method. It's OK
to be paused when the network writes, but during document.write
(or any other script execution).

Tested by all of fast/url and numerous other tests.

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::notifyFinished):
    • Unpause the treebuilder before executing scripts.

(WebCore::HTML5Tokenizer::executeScriptsWaitingForStylesheets):

  • Unpause the treebuilder before executing scripts.
5:57 PM Changeset in webkit [60813] by eric@webkit.org
  • 9 edits in trunk/WebCore

2010-06-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

HTML5 Parser hits ASSERT in fast/events/stop-load-in-unload-handler-using-document-write.html
​https://bugs.webkit.org/show_bug.cgi?id=40268

Teach HTML5Tokenizer about m_parserStopped.

While tracking down how m_parserStopped was used, I found
several useless implementations of stopParsing() which I removed.

I also found a comment in HTMLTokenizer which still talks about the
"part" (an old class now split into Frame, Page, FrameLoader, etc.)
and an nearly empty FrameLoader::tokenizerProcessedData which I just
inlined into its one caller.

Tests:

fast/events/stop-load-in-unload-handler-using-document-write.html
http/tests/security/xssAuditor/full-block-base-href.html

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::pumpLexerIfPossible):
    • New method used instead of direct calls to pumpLexer for when callers would like to pump the lexer if possible, but don't want to check if the parser is stopped, etc.

(WebCore::HTML5Tokenizer::pumpLexer):

  • Added an ASSERT that the parser is not stopped.
  • Stop pumping if the parser is stopped.

(WebCore::HTML5Tokenizer::write):

  • Ignore the write if the parser is already stopped.

(WebCore::HTML5Tokenizer::end):
(WebCore::HTML5Tokenizer::attemptToEnd):

  • Move comment back to finish() which was incorrectly moved here.

(WebCore::HTML5Tokenizer::endIfDelayed):
(WebCore::HTML5Tokenizer::finish):

  • Move comment back here from attemptToEnd()

(WebCore::HTML5Tokenizer::resumeParsingAfterScriptExecution):

  • Remove a bogus ASSERT. The lexer will stop when it needs more data, which may not necessarily mean m_source.isEmpty().
  • html/HTML5Tokenizer.h:
    • Add pumpLexerIfPossible().
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::stopParsing):
    • Add a FIXME about if we really should call checkCompleted() here.
    • Inline FrameLoader::tokenizerProcessedData() since this was the only caller.
  • loader/FrameLoader.cpp:
    • Remove tokenizerProcessedData()
  • loader/FrameLoader.h:
    • Remove tokenizerProcessedData()
  • loader/MediaDocument.cpp:
    • Remove unneeded Tokenizer::stopParsing() override.
  • loader/PluginDocument.cpp:
    • Remove unneeded Tokenizer::stopParsing() override.
  • loader/SinkDocument.cpp:
    • Remove unneeded Tokenizer::stopParsing() override.
4:42 PM Changeset in webkit [60812] by crogers@google.com
  • 2 edits in branches/audio/WebCore/audio

Better support for HRIR composite generation

4:42 PM Changeset in webkit [60811] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/mac/AudioFileWriterMac.cpp

Fix audio file writer code to properly close the file

4:42 PM Changeset in webkit [60810] by crogers@google.com
  • 241 adds in branches/audio/WebCore/audio/AudioSpatialization/IRC_Composite

Add composite HRIR impulse responses

4:41 PM Changeset in webkit [60809] by crogers@google.com
  • 1 add in branches/audio/WebCore/audio/AudioFileWriter.h

Still need AudioFileWriter.h header

4:41 PM Changeset in webkit [60808] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/mac/FFTFrameMac.cpp

Fix order of initialization in FFTFrame copy constructor

4:41 PM Changeset in webkit [60807] by crogers@google.com
  • 1 move
    1 add
    1 delete in branches/audio/WebCore/audio

Move AudioFileWriter to mac/AudioFileWriterMac

  • for testing purposes only
  • simplify implementation
4:25 PM Changeset in webkit [60806] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-06-07 Anders Bakken <​agbakken@gmail.com>

Reviewed by David Levin.

[Qt] NotificationPresenterClientQt.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=40256

  • WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationPresenterClientQt::show):
3:45 PM Changeset in webkit [60805] by Martin Robinson
  • 5 edits
    5 adds in trunk

2010-06-07 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Oliver Hunt.

[GTK] HTML5 input type=range is not drawn
​https://bugs.webkit.org/show_bug.cgi?id=39561

Uncomment and add baselines for slider tests which are now passing. Group
remaining failing slider tests by their type of failure.

  • platform/gtk/Skipped:
  • platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt: Added.
  • platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt: Added.
  • platform/gtk/fast/forms/slider-thumb-stylability-expected.txt: Added.
  • platform/gtk/fast/forms/thumbslider-crash-expected.txt: Added.
  • platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt: Added.

2010-06-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Fix XFrameOptions and xssAuditor crashes in HTML5 parser
​https://bugs.webkit.org/show_bug.cgi?id=40265

We're not supposed to call end() while the tokenizer's write() method.
This causes a bunch of LayoutTests to crash. In particular, this patch
fixes crashes in the following tests:

Tests:

  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html
  • http/tests/security/xssAuditor/full-block-base-href.html
  • http/tests/security/xssAuditor/full-block-get-from-iframe.html
  • http/tests/security/xssAuditor/full-block-iframe-javascript-url.html
  • http/tests/security/xssAuditor/full-block-link-onclick.html
  • http/tests/security/xssAuditor/full-block-post-from-iframe.html
  • http/tests/security/xssAuditor/full-block-script-tag.html
  • http/tests/security/xssAuditor/xss-protection-parsing-01.html
  • html/HTML5Tokenizer.cpp: (WebCore::): (WebCore::HTML5Tokenizer::HTML5Tokenizer): (WebCore::HTML5Tokenizer::write): (WebCore::HTML5Tokenizer::attemptToEnd): (WebCore::HTML5Tokenizer::endIfDelayed): (WebCore::HTML5Tokenizer::finish): (WebCore::HTML5Tokenizer::resumeParsingAfterScriptExecution):
  • html/HTML5Tokenizer.h: (WebCore::HTML5Tokenizer::inWrite):
3:32 PM Changeset in webkit [60804] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-06-07 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

[GTK] r60803 broke media/controls-drag-timebar.html
​https://bugs.webkit.org/show_bug.cgi?id=40269

  • platform/gtk/Skipped: Skip test which is now failing.
3:13 PM Changeset in webkit [60803] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-06-07 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Oliver Hunt.

[GTK] Mouse movement should not trigger a replay of saved events in the event sender
​https://bugs.webkit.org/show_bug.cgi?id=40267

When a mouse button is down, automatically queue mouse motion events and
do not play them back until the mouse button is released. This matches the
behavior of other ports' EventSenders.

  • DumpRenderTree/gtk/EventSender.cpp: (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion. (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true.
2:53 PM Changeset in webkit [60802] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Fix XFrameOptions and xssAuditor crashes in HTML5 parser
​https://bugs.webkit.org/show_bug.cgi?id=40265

We're not supposed to call end() while the tokenizer's write() method.
This causes a bunch of LayoutTests to crash. In particular, this patch
fixes crashes in the following tests:

Tests:

  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html
  • http/tests/security/xssAuditor/full-block-base-href.html
  • http/tests/security/xssAuditor/full-block-get-from-iframe.html
  • http/tests/security/xssAuditor/full-block-iframe-javascript-url.html
  • http/tests/security/xssAuditor/full-block-link-onclick.html
  • http/tests/security/xssAuditor/full-block-post-from-iframe.html
  • http/tests/security/xssAuditor/full-block-script-tag.html
  • http/tests/security/xssAuditor/xss-protection-parsing-01.html
  • html/HTML5Tokenizer.cpp: (WebCore::): (WebCore::HTML5Tokenizer::HTML5Tokenizer): (WebCore::HTML5Tokenizer::write): (WebCore::HTML5Tokenizer::attemptToEnd): (WebCore::HTML5Tokenizer::endIfDelayed): (WebCore::HTML5Tokenizer::finish): (WebCore::HTML5Tokenizer::resumeParsingAfterScriptExecution):
  • html/HTML5Tokenizer.h: (WebCore::HTML5Tokenizer::inWrite):
2:40 PM Changeset in webkit [60801] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

HTML5 parser hits ASSERT in http/tests/misc/window-dot-stop.html
​https://bugs.webkit.org/show_bug.cgi?id=40264

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::executeScript):
2:13 PM Changeset in webkit [60800] by kinuko@chromium.org
  • 2 edits in trunk/WebCore

2010-06-07 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed.

Avoid "warning: no previous prototype for" in Snow Leopard compilation.

  • platform/BlobItem.cpp: Added static to getFileSnapshotModificationTime().
1:55 PM Changeset in webkit [60799] by kinuko@chromium.org
  • 24 edits
    2 adds in trunk

2010-06-07 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Jian Li.

Refactor FormData and Blob for better support of Blobs synthesized by BlobBuilder.
​https://bugs.webkit.org/show_bug.cgi?id=39083

Replace FormDataList::Item list with BlobItemList to get it compiled
with the refactoring in FormDataList.

  • src/WebSearchableFormData.cpp: (WebCore::HasSuitableTextElement):

2010-06-07 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Jian Li.

Refactor FormData and Blob for better support of Blobs synthesized by BlobBuilder.
​https://bugs.webkit.org/show_bug.cgi?id=39083

  • Introduces a new class BlobItem as a basic component of Blob and FormDataList.
  • File would become a special type of Blob that contains only one FileBlobItem.
  • Fix the dependency violation in FormData so that the files under platform/ do not include any html/ files.

The patch doesn't support the latest File API changes (e.g. type,
url and slice's type parameters) and should not change any of its
existing behaviors.

The existing tests should be able to be used for regression.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/Blob.cpp: (WebCore::Blob::Blob): (WebCore::Blob::size): (WebCore::Blob::path): (WebCore::Blob::append): (WebCore::Blob::slice):
  • html/Blob.h: (WebCore::Blob::create): (WebCore::Blob::type): (WebCore::Blob::items): (WebCore::Blob::Blob):
  • html/File.cpp: (WebCore::File::File): (WebCore::File::name):
  • html/File.h: (WebCore::File::fileName):
  • html/FileReader.cpp: (WebCore::FileReader::readAsBinaryString): (WebCore::FileReader::readAsText):
  • html/FileStream.cpp: (WebCore::FileStream::openForRead):
  • html/FormDataList.cpp: (WebCore::FormDataList::appendString): Moved the line ending fix logic to StringBlobItem::convertToCString. (WebCore::FormDataList::appendBlob):
  • html/FormDataList.h: (WebCore::FormDataList::items):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::createFormData):
  • html/HTMLProgressElement.cpp:
  • platform/BlobItem.cpp: Added.
  • platform/BlobItem.h: Added.
  • platform/network/FormData.cpp: (WebCore::FormDataElement::FormDataElement): (WebCore::FormData::create): (WebCore::FormData::createMultiPart): (WebCore::FormData::deepCopy): (WebCore::FormData::appendData): (WebCore::FormData::appendString): (WebCore::FormData::appendFile): (WebCore::FormData::appendFileRange): (WebCore::FormData::appendItems): (WebCore::FormData::appendItem): (WebCore::FormData::appendKeyValuePairItems):
  • platform/network/FormData.h: (WebCore::operator!=):
  • platform/network/mac/FormDataStreamMac.mm: (WebCore::closeCurrentStream): (WebCore::advanceCurrentStream): (WebCore::formCreate): (WebCore::formRead): (WebCore::setHTTPBody):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):
1:14 PM Changeset in webkit [60798] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-06-07 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Decoupled transform matrix update of composited layers from
drawing and interposed a sorting step so that the layers are now composited
back to front to get transparency working correctly. Also added missing code
for the preserves3D CSS property.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::setDrawTransform): (WebCore::LayerChromium::drawTransform): (WebCore::LayerChromium::setDrawOpacity): (WebCore::LayerChromium::drawOpacity): (WebCore::LayerChromium::preserves3D):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::compareLayerZ): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::updateLayersRecursive): (WebCore::LayerRendererChromium::drawLayer):
  • platform/graphics/chromium/LayerRendererChromium.h:
1:01 PM Changeset in webkit [60797] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-07 Anton Muhin <​antonm@chromium.org>

Reviewed by Nate Chapin.

[Chromium] convert a key to AtomicString in V8NodeList::namedPropertyGetter
​https://bugs.webkit.org/show_bug.cgi?id=40238

Comparison to "length" below could be performed faster in this (major) case
as it would only require direct pointer comparison (cf. to full text
comparison if key is converted to WebCore::String.)

  • bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::V8NodeList::namedPropertyGetter):
12:27 PM Changeset in webkit [60796] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-07 Ariya Hidayat <​ariya.hidayat@codeaurora.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix GraphicsContext::clipOut to take the transformation matrix into account.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipOut):
12:22 PM Changeset in webkit [60795] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-07 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed.

[gtk] web fonts not loaded properly in scribd html5 reader
​https://bugs.webkit.org/show_bug.cgi?id=38758

Also reset the expected result for the dynamic test for
backslash/yen sign.

  • platform/gtk/fast/text/backslash-to-yen-sign-dynamic-expected.txt:
12:08 PM Changeset in webkit [60794] by kov@webkit.org
  • 2 adds in trunk/WebCore/platform/graphics/cairo

Adding files I forgot last commit.

12:03 PM Changeset in webkit [60793] by kov@webkit.org
  • 5 edits in trunk

WebCore

2010-06-07 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[gtk] web fonts not loaded properly in scribd html5 reader
​https://bugs.webkit.org/show_bug.cgi?id=38758

Avoid always giving a positive reply in createFontPlatformData. We
do not want every non-existing family name to be considered a hit,
or weird usage of local sources in @font-face rules will make
WebKitGTK+ never consider the online fonts.

  • GNUmakefile.am:
  • platform/graphics/cairo/FontCacheCairo.cpp: (WebCore::isWellKnownFontName): (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/cairo/GOwnPtrCairo.cpp: Added. (WTF::FcPattern): (WTF::FcObjectSet): (WTF::FcFontSet):
  • platform/graphics/cairo/GOwnPtrCairo.h: Added.

LayoutTest

2010-06-07 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[gtk] web fonts not loaded properly in scribd html5 reader
​https://bugs.webkit.org/show_bug.cgi?id=38758

Reset expected result for test that uses fonts we do not really
support, and are not "web fonts".

  • platform/gtk/fast/text/backslash-to-yen-sign-expected.txt:
11:54 AM Changeset in webkit [60792] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/HTMLXAudioElement.cpp

More windows porting work - get rid of usleep() - courtesy Ian Lewis

11:51 AM Changeset in webkit [60791] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

"Fix" fast/dom/stripNullFromTextNodes.html in HTML5 parser
​https://bugs.webkit.org/show_bug.cgi?id=40200

The proper handling of null characters is to replace them with U+FFFD.
This patch "fixes" fast/dom/stripNullFromTextNodes.html in the sense
that it makes it give the proper output w.r.t. HTML5. However, that
doesn't match the behavior of the old parser, which just stripped the
nulls.

  • html/HTML5Lexer.h: (WebCore::HTML5Lexer::InputStreamPreprocessor::peek):
11:34 AM Changeset in webkit [60790] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5 parser should normalize line endings
​https://bugs.webkit.org/show_bug.cgi?id=40199

When reading characters from the source, we need to normalize line
endings, which means treating \r as \n and folding \r\n sequences into
a single \n. Doing this requires a slightly tighter pattern for
advancing the source (to make sure we update our state machine
correctly).

Fixes fast/css/first-child-pseudo-class.html and hundreds of other
LayoutTests in the HTML5 parser.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
  • html/HTML5Lexer.h: (WebCore::HTML5Lexer::InputStreamPreprocessor::LineEndingNormalizer):
    • Introduced InputStreamPreprocessor to keep track of our line endings state machine. This class will grow to eventually do all the input stream preprocessing required by the HTML5 spec.

(WebCore::HTML5Lexer::InputStreamPreprocessor::nextInputCharacter):

  • We need to be careful not to read *source more than once because we need to know whether we've transformed the character. Keeping the next input character in this state machine requires some careful coding, but seems advantageous.

(WebCore::HTML5Lexer::InputStreamPreprocessor::peek):
(WebCore::HTML5Lexer::InputStreamPreprocessor::advance):

10:53 AM Changeset in webkit [60789] by andreip@google.com
  • 4 edits in trunk/WebCore

2010-06-07 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

run-bindings-tests results broken by Changeset 60776
​https://bugs.webkit.org/show_bug.cgi?id=40230

The change to CodeGeneratorJS.pm in
​http://trac.webkit.org/changeset/60776/trunk/WebCore/bindings/scripts/CodeGeneratorJS.pm
added the possibility to use [CallWith=ScriptExecutionContext] in idl files.

Before the above change was submitted, CodeGeneratorJS.pm was modified so that native
functions return EncodedJSValue instead of JSValues. This was done in
​http://trac.webkit.org/changeset/60631/trunk/WebCore/bindings/scripts/CodeGeneratorJS.pm

This CL updates the CodeGeneratorJS.pm to correctly return an EncodedJSValue in the case
where the ScriptExecutionContext pointer is 0 at the time when the native function is invoked.

No new tests, just fixing run-bindings-tests.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContext):
  • bindings/scripts/test/JS/JSTestObj.h:
10:50 AM Changeset in webkit [60788] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-06-07 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add dummy SearchPopupMenu implementation
​https://bugs.webkit.org/show_bug.cgi?id=40224

Add dummy implementation of SearchPopupMenu.

  • platform/brew/SearchPopupMenuBrew.cpp: Added. (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches): (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::enabled):
10:34 AM Changeset in webkit [60787] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-06-07 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add more types to OwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=39667

Add ISSL and ISocket to the list of OwnPtr-ed type.

  • wtf/OwnPtrCommon.h:
  • wtf/brew/OwnPtrBrew.cpp: (WTF::deleteOwnedPtr):
8:26 AM Changeset in webkit [60786] by jchaffraix@webkit.org
  • 9 edits
    22 deletes in trunk

Unreviewed, reverting my HTML comment parsing change as it
breaks Gtk and Qt.

8:02 AM Changeset in webkit [60785] by Martin Robinson
  • 10 edits in trunk

2010-06-07 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] gtk_widget_get_window should replace widget->window
​https://bugs.webkit.org/show_bug.cgi?id=40180

Replace all uses of widget->window with gtk_widget_get_window. For older
GTK+ versions, #define gtk_widget_get_window in GtkVersioning.h.

No tests necessary as functionality has not changed.

  • platform/gtk/GtkPluginWidget.cpp: (WebCore::GtkPluginWidget::invalidateRect): Replace widget->window use.
  • platform/gtk/GtkVersioning.h: Add gtk_widget_get_window for old GTK+ versions.
  • platform/gtk/PlatformScreenGtk.cpp: (WebCore::getVisual): Replace widget->window use. (WebCore::screenRect): Ditto.
  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::show): Ditto.
  • platform/gtk/WidgetGtk.cpp: (WebCore::gdkDrawable): Ditto. (WebCore::Widget::setCursor): Ditto.

2010-06-07 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] gtk_widget_get_window should replace widget->window
​https://bugs.webkit.org/show_bug.cgi?id=40180

Replace uses of widget->window with gtk_widget_get_window.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::invalidateContentsAndWindow): Replace widget->window uses. (WebKit::ChromeClient::scroll): Ditto. (WebKit::widgetScreenPosition): Ditto.
  • WebCoreSupport/DragClientGtk.cpp: Move gtk_widget_get_window define to GtkVersioning.h.
  • webkit/webkitwebview.cpp: (webkit_web_view_popup_menu_handler): Replace widget->window uses. (webkit_web_view_button_press_event): Ditto.
7:47 AM Changeset in webkit [60784] by Nikolas Zimmermann
  • 21 edits
    23 adds in trunk

2010-06-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Sam Weinig.

Add CPP bindings generator
​https://bugs.webkit.org/show_bug.cgi?id=38279

Add CPP bindings generator used in Olympia platform.
We can succesfully generate cpp bindings for all IDLs except:

  • DOMWindow.idl / EventTarget.idl (filtered out in the IDL list in DerivedSources.make for non-jsc/v8 generators anyways, so no problem at all)
  • inspector/ (not needed for us at all)
  • svg/ (needs custom handling, related to animated attributes)

All generated files are free of style issues: "Total errors found: 0 in 510 files"
Not integrated in any build system so far, though I've successfully tested on Mac and inside Olympia, of course.

  • bindings/cpp: Added.
  • bindings/cpp/WebDOMCString.cpp: Added. (WebDOMCString::reset): (WebDOMCString::assign): (WebDOMCString::length): (WebDOMCString::data): (WebDOMCString::utf16): (WebDOMCString::fromUTF16): (WebDOMCString::WebDOMCString): (WebDOMCString::operator=): (WebDOMCString::operator WTF::CString):
  • bindings/cpp/WebDOMCString.h: Added. (WebDOMCString::~WebDOMCString): (WebDOMCString::WebDOMCString): (WebDOMCString::operator=): (WebDOMCString::isEmpty): (WebDOMCString::isNull):
  • bindings/cpp/WebDOMEventListenerCustom.cpp: Added. (WebDOMEventListener::handleEvent): (toWebKit):
  • bindings/cpp/WebDOMEventTarget.cpp: Added. (WebDOMEventTarget::WebDOMEventTargetPrivate::WebDOMEventTargetPrivate): (WebDOMEventTarget::WebDOMEventTarget): (WebDOMEventTarget::~WebDOMEventTarget): (WebDOMEventTarget::impl): (toWebCore): (toWebKit):
  • bindings/cpp/WebDOMEventTarget.h: Added.
  • bindings/cpp/WebDOMHTMLDocumentCustom.cpp: Added. (documentWrite): (WebDOMHTMLDocument::write): (WebDOMHTMLDocument::writeln):
  • bindings/cpp/WebDOMNodeCustom.cpp: Added. (WebDOMNode::insertBefore): (WebDOMNode::replaceChild): (WebDOMNode::removeChild): (WebDOMNode::appendChild): (WebDOMNode::addEventListener): (WebDOMNode::removeEventListener):
  • bindings/cpp/WebDOMObject.h: Added. (WebDOMObject::WebDOMObject): (WebDOMObject::~WebDOMObject):
  • bindings/cpp/WebDOMString.cpp: Added. (WebDOMString::reset): (WebDOMString::assign): (WebDOMString::length): (WebDOMString::data): (WebDOMString::utf8): (WebDOMString::fromUTF8): (WebDOMString::WebDOMString): (WebDOMString::operator=): (WebDOMString::operator WebCore::String): (WebDOMString::operator WebCore::AtomicString): (WebDOMString::equals):
  • bindings/cpp/WebDOMString.h: Added. (WebDOMString::~WebDOMString): (WebDOMString::WebDOMString): (WebDOMString::operator=): (WebDOMString::isEmpty): (WebDOMString::isNull):
  • bindings/cpp/WebExceptionHandler.cpp: Added. (globalExceptionHandler): (webInstallExceptionHandler): (webRaiseDOMException):
  • bindings/cpp/WebExceptionHandler.h: Added. (webDOMRaiseError):
  • bindings/cpp/WebNativeEventListener.cpp: Added. (WebNativeEventListener::WebNativeEventListener): (WebNativeEventListener::~WebNativeEventListener): (WebNativeEventListener::handleEvent): (WebNativeEventListener::reportError): (WebNativeEventListener::operator==):
  • bindings/cpp/WebNativeEventListener.h: Added. (WebNativeEventListener::create): (WebNativeEventListener::cast):
  • bindings/scripts/CodeGeneratorCPP.pm: Added.
  • bindings/scripts/test/CPP: Added.
  • bindings/scripts/test/CPP/WebDOMTestCallback.cpp: Added. (WebDOMTestCallback::WebDOMTestCallbackPrivate::WebDOMTestCallbackPrivate): (WebDOMTestCallback::WebDOMTestCallback): (WebDOMTestCallback::impl): (WebDOMTestCallback::~WebDOMTestCallback): (WebDOMTestCallback::callbackWithClass1Param): (WebDOMTestCallback::callbackWithClass2Param): (WebDOMTestCallback::callbackWithNonBoolReturnType): (toWebCore): (toWebKit):
  • bindings/scripts/test/CPP/WebDOMTestCallback.h: Added.
  • bindings/scripts/test/CPP/WebDOMTestInterface.cpp: Added. (WebDOMTestInterface::WebDOMTestInterfacePrivate::WebDOMTestInterfacePrivate): (WebDOMTestInterface::WebDOMTestInterface): (WebDOMTestInterface::impl): (WebDOMTestInterface::~WebDOMTestInterface): (toWebCore): (toWebKit):
  • bindings/scripts/test/CPP/WebDOMTestInterface.h: Added.
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: Added. (WebDOMTestObj::WebDOMTestObjPrivate::WebDOMTestObjPrivate): (WebDOMTestObj::WebDOMTestObj): (WebDOMTestObj::impl): (WebDOMTestObj::~WebDOMTestObj): (WebDOMTestObj::readOnlyIntAttr): (WebDOMTestObj::readOnlyStringAttr): (WebDOMTestObj::readOnlyTestObjAttr): (WebDOMTestObj::intAttr): (WebDOMTestObj::setIntAttr): (WebDOMTestObj::longLongAttr): (WebDOMTestObj::setLongLongAttr): (WebDOMTestObj::unsignedLongLongAttr): (WebDOMTestObj::setUnsignedLongLongAttr): (WebDOMTestObj::stringAttr): (WebDOMTestObj::setStringAttr): (WebDOMTestObj::testObjAttr): (WebDOMTestObj::setTestObjAttr): (WebDOMTestObj::attrWithException): (WebDOMTestObj::setAttrWithException): (WebDOMTestObj::attrWithSetterException): (WebDOMTestObj::setAttrWithSetterException): (WebDOMTestObj::attrWithGetterException): (WebDOMTestObj::setAttrWithGetterException): (WebDOMTestObj::scriptStringAttr): (WebDOMTestObj::voidMethod): (WebDOMTestObj::voidMethodWithArgs): (WebDOMTestObj::intMethod): (WebDOMTestObj::intMethodWithArgs): (WebDOMTestObj::objMethod): (WebDOMTestObj::objMethodWithArgs): (WebDOMTestObj::methodThatRequiresAllArgs): (WebDOMTestObj::methodThatRequiresAllArgsAndThrows): (WebDOMTestObj::serializedValue): (WebDOMTestObj::methodWithException): (WebDOMTestObj::addEventListener): (WebDOMTestObj::removeEventListener): (WebDOMTestObj::withDynamicFrame): (WebDOMTestObj::withDynamicFrameAndArg): (WebDOMTestObj::withDynamicFrameAndOptionalArg): (WebDOMTestObj::withScriptStateVoid): (WebDOMTestObj::withScriptStateObj): (WebDOMTestObj::withScriptStateVoidException): (WebDOMTestObj::withScriptStateObjException): (WebDOMTestObj::methodWithOptionalArg): (WebDOMTestObj::methodWithNonOptionalArgAndOptionalArg): (WebDOMTestObj::methodWithNonOptionalArgAndTwoOptionalArgs): (toWebCore): (toWebKit):
  • bindings/scripts/test/CPP/WebDOMTestObj.h: Added.
  • css/StyleSheet.idl: Export helper method isCSSStyleSheet() for cpp bindings only.
  • dom/CustomEvent.idl: Disabled for cpp bindings, needs arbitary input parameter handling support ('DOMObject' type).
  • dom/Document.idl: Ignore getCSSCanvasContext() for cpp bindings and export helper method isHTMLDocument() (cpp bindings only).
  • dom/Event.idl: Export isMutationEvent()/isMouseEvent()/isUIEvent() helpers for cpp bindings only.
  • dom/EventListener.h: Add CPPEventListenerType.
  • dom/Node.idl: addEventListener/removeEventListener need [Custom] flag for cpp bindings.
  • dom/PopStateEvent.idl: Disabled just like CustomEvent, for the same reason ("any" argument type handling).
  • html/HTMLCanvasElement.idl: Disable getContext() method for cpp bindings, as it's done for objc bindings.
  • html/HTMLDocument.idl: Add [NoCPPCustom] marker for open(), as we're just autogenerating it.
  • html/HTMLInputElement.idl: Disable valueAsDate() method for cpp bindings, as we're missing native 'Date' type support.
  • html/TextMetrics.h: Add missing PassRefPtr.h include.
  • html/canvas/CanvasRenderingContext2D.idl: Disable methods (setLineCap, etc..) for cpp bindings whose names clash with property setters.
  • page/AbstractView.idl: Rename 'Media' type to 'StyleMedia' - this should have been done before.
  • page/Location.idl: Disable several methods which would need a custom implementation for the cpp bindings.
  • page/WebKitPoint.h: Add missing PassRefPtr.h include.
  • storage/SQLResultSet.idl: Correct type from 'long' to 'long long', for cpp bindings only though as it wouldn't build on Chromium/V8.
  • workers/DedicatedWorkerContext.idl: Disable postMessage() for now when using cpp bindings, would need custom code for us.
  • workers/WorkerContext.idl: Hide constructors from cpp bindings.

2010-06-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Sam Weinig.

Add CPP bindings generator
​https://bugs.webkit.org/show_bug.cgi?id=38279

Integrate CPP bindings in run-bindings-tests.

  • Scripts/run-bindings-tests:
7:43 AM Changeset in webkit [60783] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebKitSite

2010-06-07 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Darin Adler.

Add documentation on the various assertion macros in WebKit.

​https://bugs.webkit.org/show_bug.cgi?id=39950

  • coding/assertion-guidelines.html: Added.
7:43 AM Changeset in webkit [60782] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-07 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Put some structure on the Qt Skipped file

​https://bugs.webkit.org/show_bug.cgi?id=38818

  • platform/qt/Skipped:
7:41 AM Changeset in webkit [60781] by jchaffraix@webkit.org
  • 9 edits
    22 adds in trunk

WebCore: Space should be allowed between -- and > in comment end
​https://bugs.webkit.org/show_bug.cgi?id=21945

Reviewed by Alexey Proskuryakov.

Implemented the HTML comment parsing algorithm so that we match HTML5 and
FF when parsing comments. Missing from this patch is
the parser errors, which will be added in a follow up patch.

Added tests cases for broken comments.

Tests: fast/parser/broken-comment-1.html

fast/parser/broken-comment-2.html
fast/parser/broken-comment-3.html
fast/parser/broken-comment-4.html
fast/parser/broken-comment-5.html
fast/parser/broken-comment-6.html
fast/parser/broken-comment-in-head-1.html
fast/parser/broken-comment-in-head-2.html
fast/parser/broken-comment-in-head-3.html
fast/parser/broken-comment-in-head-4.html
fast/parser/broken-comment-in-head-5.html

  • html/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::parseComment): Now we use a state machine
that matches the HTML5 specification.
(WebCore::HTMLTokenizer::emitCommentToken): This emits the comment token
and keep some of the original behavior as parseComment is called in wrong
context (inside a <title> for example). Added a more explicit comment about
this.
(WebCore::HTMLTokenizer::parseTag): Remove the handling of <!--> in quirks mode.
HTML5 specifies that we should accept this in strict mode too.

  • html/HTMLTokenizer.h:

(WebCore::HTMLTokenizer::): Added a new enum for the comment parsing state.

LayoutTests: Tests for:
Space should be allowed between -- and > in comment end
​https://bugs.webkit.org/show_bug.cgi?id=21945

Reviewed by Alexey Proskuryakov.

  • fast/css/word-space-extra.html: Tweaked the comment as -- > is now

a valid comment end.

  • fast/parser/broken-comment-1-expected.txt: Added.
  • fast/parser/broken-comment-1.html: Added.
  • fast/parser/broken-comment-2-expected.txt: Added.
  • fast/parser/broken-comment-2.html: Added.
  • fast/parser/broken-comment-3-expected.txt: Added.
  • fast/parser/broken-comment-3.html: Added.
  • fast/parser/broken-comment-4-expected.txt: Added.
  • fast/parser/broken-comment-4.html: Added.
  • fast/parser/broken-comment-5-expected.txt: Added.
  • fast/parser/broken-comment-5.html: Added.
  • fast/parser/broken-comment-6-expected.txt: Added.
  • fast/parser/broken-comment-6.html: Added.

Those test checks that broken comments in body are correctly parsed.

  • fast/parser/broken-comment-in-head-1-expected.txt: Added.
  • fast/parser/broken-comment-in-head-1.html: Added.
  • fast/parser/broken-comment-in-head-2-expected.txt: Added.
  • fast/parser/broken-comment-in-head-2.html: Added.
  • fast/parser/broken-comment-in-head-3-expected.txt: Added.
  • fast/parser/broken-comment-in-head-3.html: Added.
  • fast/parser/broken-comment-in-head-4-expected.txt: Added.
  • fast/parser/broken-comment-in-head-4.html: Added.
  • fast/parser/broken-comment-in-head-5-expected.txt: Added.
  • fast/parser/broken-comment-in-head-5.html: Added.

Those test checks that broken comments in head are correctly parsed.

  • fast/parser/broken-comments-vs-parsing-mode.html: Needed to wrap the broken comment

in a title as we match FF here and would not recover from it.

  • fast/parser/comments-expected.txt:
  • fast/parser/comments.html:

Added more tests for comment parsing. Made sure that we close empty comments
<!--> and <!---> as is specified in HTML5.

  • html5lib/runner-expected.txt: Removed the test that we now pass.
7:29 AM Changeset in webkit [60780] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-07 Mahesh Kulakrni <​mahesh.kulkarni@nokia.com>

Reviewed by Simon Hausmann.

[QT] QT_BEARER flag is not enabled on S60 properly
​https://bugs.webkit.org/show_bug.cgi?id=39357

enable QT_BEARER for all platform based on qtmobility +
bearer module availability or for qt 4.7+

  • WebCore.pri:
6:59 AM Changeset in webkit [60779] by andreip@google.com
  • 1 edit in trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py

Unreviewed, add Andrei Popescu to committers list.

6:56 AM Changeset in webkit [60778] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

Expose the editing behavior setting in DRT to test all editing code paths ​https://bugs.webkit.org/show_bug.cgi?id=39680

Patch by Antonio Gomes <​tonikitoo@webkit.org>, Laszlo Gombos <Laszlo Gombos> on 2010-06-06
Reviewed by Kenneth Christiansen, Eric Seidel.

Make setEditingBehavior() a no-operation if the editingBehavior
argument is not recognized to avoid using an uninitialized variable.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setEditingBehavior):

6:40 AM WebKit Team edited by andreip@google.com
Added myself to list of Committers. (diff)
5:32 AM Changeset in webkit [60777] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-07 Leon Clarke <​leonclarke@google.com>

Reviewed by Jeremy Orlow.

Fix indexeddb idls in android makefile
​https://bugs.webkit.org/show_bug.cgi?id=40169

No new tests. Android-specific build fix.

  • Android.derived.v8bindings.mk:
5:01 AM Changeset in webkit [60776] by andreip@google.com
  • 48 edits
    6 copies
    1 move in trunk

2010-06-07 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

[indexedDB] It is impossible to create object stores
​https://bugs.webkit.org/show_bug.cgi?id=40054

No new tests. Layout tests will be added separately.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_with_script_execution_context):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContext):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj withScriptExecutionContext]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::withScriptExecutionContextCallback): (WebCore::):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::clear): (WebCore::DOMWindow::indexedDB):
  • storage/IDBCallbacks.h:
  • storage/IDBDatabase.h:
  • storage/IDBDatabaseImpl.cpp: (WebCore::IDBDatabaseImpl::createObjectStore):
  • storage/IDBDatabaseImpl.h:
  • storage/IDBDatabaseRequest.cpp: (WebCore::IDBDatabaseRequest::IDBDatabaseRequest): (WebCore::IDBDatabaseRequest::createObjectStore):
  • storage/IDBDatabaseRequest.h:
  • storage/IDBDatabaseRequest.idl:
  • storage/IDBObjectStore.cpp: Removed.
  • storage/IDBObjectStore.h: (WebCore::IDBObjectStore::~IDBObjectStore):
  • storage/IDBObjectStoreImpl.cpp: Added. (WebCore::IDBObjectStoreImpl::~IDBObjectStoreImpl): (WebCore::IDBObjectStoreImpl::IDBObjectStoreImpl): (WebCore::IDBObjectStoreImpl::indexNames): (WebCore::IDBObjectStoreImpl::createIndex): (WebCore::IDBObjectStoreImpl::index): (WebCore::IDBObjectStoreImpl::removeIndex):
  • storage/IDBObjectStoreImpl.h: Added. (WebCore::IDBObjectStoreImpl::create): (WebCore::IDBObjectStoreImpl::name): (WebCore::IDBObjectStoreImpl::keyPath):
  • storage/IDBObjectStoreRequest.cpp: (WebCore::IDBObjectStoreRequest::IDBObjectStoreRequest):
  • storage/IDBObjectStoreRequest.h: (WebCore::IDBObjectStoreRequest::create):
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::onSuccess):
  • storage/IDBRequest.h:
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::IndexedDatabaseRequest): (WebCore::IndexedDatabaseRequest::open):
  • storage/IndexedDatabaseRequest.h: (WebCore::IndexedDatabaseRequest::create):
  • storage/IndexedDatabaseRequest.idl:

2010-06-07 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

[indexedDB] It is impossible to create object stores
​https://bugs.webkit.org/show_bug.cgi?id=40054

  • WebKit.gyp:
  • public/WebIDBCallbacks.h: (WebKit::WebIDBCallbacks::onSuccess):
  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::createObjectStore):
  • public/WebIDBObjectStore.h: Added. (WebKit::WebIDBObjectStore::~WebIDBObjectStore): (WebKit::WebIDBObjectStore::name): (WebKit::WebIDBObjectStore::keyPath):
  • src/IDBCallbacksProxy.cpp: (WebCore::IDBCallbacksProxy::onSuccess):
  • src/IDBCallbacksProxy.h:
  • src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::createObjectStore):
  • src/IDBDatabaseProxy.h:
  • src/IDBObjectStoreProxy.cpp: Added. (WebCore::IDBObjectStoreProxy::create): (WebCore::IDBObjectStoreProxy::IDBObjectStoreProxy): (WebCore::IDBObjectStoreProxy::~IDBObjectStoreProxy): (WebCore::IDBObjectStoreProxy::name): (WebCore::IDBObjectStoreProxy::keyPath): (WebCore::IDBObjectStoreProxy::indexNames): (WebCore::IDBObjectStoreProxy::createIndex): (WebCore::IDBObjectStoreProxy::index): (WebCore::IDBObjectStoreProxy::removeIndex):
  • src/IDBObjectStoreProxy.h: Added.
  • src/IndexedDatabaseProxy.cpp: (WebCore::IndexedDatabaseProxy::open):
  • src/WebIDBCallbacksImpl.cpp: (WebCore::WebIDBCallbacksImpl::onSuccess):
  • src/WebIDBCallbacksImpl.h:
  • src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::createObjectStore):
  • src/WebIDBDatabaseImpl.h:
  • src/WebIDBObjectStoreImpl.cpp: Added. (WebKit::WebIDBObjectStoreImpl::WebIDBObjectStoreImpl): (WebKit::WebIDBObjectStoreImpl::~WebIDBObjectStoreImpl): (WebKit::WebIDBObjectStoreImpl::name): (WebKit::WebIDBObjectStoreImpl::keyPath):
  • src/WebIDBObjectStoreImpl.h: Added.
  • src/WebIndexedDatabaseImpl.cpp: (WebKit::WebIndexedDatabaseImpl::open):
4:57 AM QtWebKitTodo edited by Simon Hausmann
(diff)
4:48 AM Changeset in webkit [60775] by Nikolas Zimmermann
  • 4 edits in trunk/WebCore

2010-06-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Updated run-bindings-tests results.

  • bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::JSTestInterfaceConstructor::constructTestInterface):
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionVoidMethod): (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionIntMethod): (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionObjMethod): (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs): (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows): (WebCore::jsTestObjPrototypeFunctionSerializedValue): (WebCore::jsTestObjPrototypeFunctionMethodWithException): (WebCore::jsTestObjPrototypeFunctionCustomMethod): (WebCore::jsTestObjPrototypeFunctionCustomMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException): (WebCore::jsTestObjPrototypeFunctionAddEventListener): (WebCore::jsTestObjPrototypeFunctionRemoveEventListener): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrame): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD): (WebCore::jsTestObjPrototypeFunctionWithScriptStateVoid): (WebCore::jsTestObjPrototypeFunctionWithScriptStateObj): (WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException): (WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException): (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg): (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod1): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod2): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod3): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod4): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
  • bindings/scripts/test/JS/JSTestObj.h:
4:45 AM QtWebKitTodo edited by Simon Hausmann
(diff)
4:40 AM QtWebKitTodo edited by Simon Hausmann
(diff)
4:33 AM Changeset in webkit [60774] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-06-07 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Implement JSON parsing for InspectorValue.
​https://bugs.webkit.org/show_bug.cgi?id=40064

  • inspector/InspectorValues.cpp: (WebCore::): (WebCore::InspectorValue::asBool): (WebCore::InspectorValue::asNumber): (WebCore::InspectorValue::asString): (WebCore::InspectorValue::asObject): (WebCore::InspectorValue::asArray): (WebCore::InspectorValue::readJSON): (WebCore::InspectorValue::writeJSON): (WebCore::InspectorBasicValue::asBool): (WebCore::InspectorBasicValue::asNumber): (WebCore::InspectorBasicValue::writeJSON): (WebCore::InspectorString::asString): (WebCore::InspectorObject::asObject): (WebCore::InspectorObject::getBool): (WebCore::InspectorObject::getNumber): (WebCore::InspectorObject::getString): (WebCore::InspectorObject::getObject): (WebCore::InspectorObject::getArray): (WebCore::InspectorObject::get): (WebCore::InspectorArray::asArray):
  • inspector/InspectorValues.h: (WebCore::InspectorObject::begin): (WebCore::InspectorObject::end):
4:24 AM Changeset in webkit [60773] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

[Qt] Crash when compiling on Snow Leopard and running on Leopard
​https://bugs.webkit.org/show_bug.cgi?id=31403

Patch by Benjamin Poulain <​benjamin.poulain@nokia.com> on 2010-06-07
Reviewed by Simon Hausmann.

Disable the use of pthread_setname_np and other symbols
when targetting Leopard.

Use the defines TARGETING_XX instead of BUILDING_ON_XX
for features that cannot be used before Snow Leopard.

  • wtf/Platform.h:
3:36 AM Changeset in webkit [60772] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebCore

[Qt] Fix text selection drawing.
​https://bugs.webkit.org/show_bug.cgi?id=40221

Reviewed by Simon Hausmann.

The regression was introduced in r60169.

  • platform/graphics/qt/FontQt.cpp:

(WebCore::drawTextCommon):

2:57 AM Changeset in webkit [60771] by yurys@chromium.org
  • 18 edits in trunk

2010-06-07 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: should be possible to distinguish extension scripts from main world scripts
​https://bugs.webkit.org/show_bug.cgi?id=40220

  • bindings/js/ScriptDebugServer.cpp: remove global listeners set which is not used anymore. (WebCore::ScriptDebugServer::dispatchDidParseSource): pass script wrold type to the listeners. (WebCore::currentWorldType): (WebCore::ScriptDebugServer::sourceParsed):
  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidParseSource):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::didParseSource):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::parsedScriptSource):
  • inspector/InspectorFrontend.h:
  • inspector/ScriptDebugListener.h: pass type of the isolated world where the script was compiled to didParseSource. (WebCore::):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
  • inspector/front-end/Script.js: (WebInspector.Script):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.addScript): (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): use different style to highlight content scripts.
  • inspector/front-end/inspector.css: (#scripts-files option.extension-script):
  • inspector/front-end/inspector.js: (WebInspector.parsedScriptSource):

2010-06-07 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: should be possible to distinguish extension scripts from main world scripts
​https://bugs.webkit.org/show_bug.cgi?id=40220

  • src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.initUI): (devtools.DebuggerAgent.prototype.addScriptInfo_): (devtools.DebuggerAgent.prototype.formatCallFrame_): (devtools.ScriptInfo.prototype.worldType):
  • src/js/DebuggerScript.js: (debuggerScriptConstructor.DebuggerScript.getScripts): use only context id without context type when filtering scripts so that extension scripts are also included. (debuggerScriptConstructor.DebuggerScript._formatScript):
  • src/js/devTools.css:
1:58 AM Changeset in webkit [60770] by loki@webkit.org
  • 2 edits in trunk/JavaScriptCore
  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):

Reviewed by NOBODY (JSVALUE32_64 build fix).

Jun 6, 2010:

9:53 PM Changeset in webkit [60769] by staikos@webkit.org
  • 1 edit in trunk/WebCore/platform/qt/WidgetQt.cpp

Unreviewed: Since 2006 I learned out to spell my name.

8:29 PM Changeset in webkit [60768] by morrita@google.com
  • 2 edits in trunk/WebCore

2010-06-06 MORITA Hajime <​morrita@google.com>

Unreviewd, Chromium windows build fix.

  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintProgressBar):
8:07 PM Changeset in webkit [60767] by morrita@google.com
  • 7 edits
    3 adds in trunk

2010-06-06 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

ASSERTION FAILED with -webkit-appearance:progress-bar for non-progress bar elements
​https://bugs.webkit.org/show_bug.cgi?id=40158

  • fast/css/invalid-appearance-progress-bar-meter-expected.txt: Added.
  • fast/css/invalid-appearance-progress-bar-meter.html: Added.
  • fast/css/script-tests/invalid-appearance-progress-bar-meter.js: Added.

2010-06-06 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

ASSERTION FAILED with -webkit-appearance:progress-bar for non <progress> elements
​https://bugs.webkit.org/show_bug.cgi?id=40158

paintProgressBar() and paintMeter() assumed given RenderObject is
RenderProgress or RenderMeter respectively, but arbitrary elements
can have -webkit-appearance: progress-bar and such elements
violates that assumption. So this change added type check before
downcasting the RenderObject.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintProgressBar):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::paintMeter):
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintProgressBar):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintProgressBar):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintProgressBar):
5:07 PM Changeset in webkit [60766] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (windows build fix pt 2).

4:54 PM Changeset in webkit [60765] by barraclough@apple.com
  • 3 edits in trunk/WebCore
  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::findMethodIndex):
(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::call):

Reviewed by NOBODY (Qt build fix pt 2).

4:50 PM Changeset in webkit [60764] by barraclough@apple.com
  • 2 edits in trunk/WebCore
  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::findMethodIndex):
(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::call):

Reviewed by NOBODY (Qt build fix).

4:46 PM Changeset in webkit [60763] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

Reviewed by NOBODY (windows build fix pt 1).

4:34 PM Changeset in webkit [60762] by barraclough@apple.com
  • 90 edits in trunk

Bug 40214 - Clean up error construction / throwing in JSC.

Reviewed by Sam Weinig.

The one egregious insanity here is that creating an error requires
a VM-entry-esqe-host call (the string argument is wrapped as a JS
object & pushed on the RegisterFile, then unwrapped back to a
UString). Changing this also means you only require a global
object, not an ExecState, to create an error.

The methods to create error objects are also parameterized
requiring a switch on the type, which can be made cleaner and
faster by moving to a separate method per error type. Code to add
divot information to error had been duplicated, and is coalesced
back into a single function.

Convenience methods added to create & throw type & syntax error
with a default error message, since this is a common case.

Also, errors are currently thrown either using
"throwError(exec, error)" or "exec->setException(error)" - unify
on the former, since this is more commonly used. Add
"throwVMError(exec, error)" equivalents, as a convenience for
cases where the result was being wrapped in "JSValue::encode(...)".

JavaScriptCore:

  • API/JSCallbackConstructor.cpp:

(JSC::constructJSCallback):

  • API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::call):

  • API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertySlot):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::construct):
(JSC::::hasInstance):
(JSC::::call):
(JSC::::toNumber):
(JSC::::toString):
(JSC::::staticValueGetter):
(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):

  • API/JSObjectRef.cpp:

(JSObjectMakeError):

(JSC::BytecodeGenerator::emitNewError):
(JSC::BytecodeGenerator::emitThrowExpressionTooDeepException):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::ThrowableExpressionData::emitThrowError):
(JSC::RegExpNode::emitBytecode):
(JSC::PostfixErrorNode::emitBytecode):
(JSC::PrefixErrorNode::emitBytecode):
(JSC::AssignErrorNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::LabelNode::emitBytecode):

  • interpreter/CallFrame.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jsc.cpp:

(functionRun):
(functionLoad):
(functionCheckSyntax):

  • parser/Nodes.h:
  • runtime/ArrayConstructor.cpp:

(JSC::constructArrayWithSizeQuirk):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):

  • runtime/BooleanPrototype.cpp:

(JSC::booleanProtoFuncToString):
(JSC::booleanProtoFuncValueOf):

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncToLocaleString):
(JSC::dateProtoFuncToLocaleDateString):
(JSC::dateProtoFuncToLocaleTimeString):
(JSC::dateProtoFuncGetTime):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetMilliSeconds):
(JSC::dateProtoFuncGetUTCMilliseconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::dateProtoFuncSetTime):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetMilliSeconds):
(JSC::dateProtoFuncSetUTCMilliseconds):
(JSC::dateProtoFuncSetSeconds):
(JSC::dateProtoFuncSetUTCSeconds):
(JSC::dateProtoFuncSetMinutes):
(JSC::dateProtoFuncSetUTCMinutes):
(JSC::dateProtoFuncSetHours):
(JSC::dateProtoFuncSetUTCHours):
(JSC::dateProtoFuncSetDate):
(JSC::dateProtoFuncSetUTCDate):
(JSC::dateProtoFuncSetMonth):
(JSC::dateProtoFuncSetUTCMonth):
(JSC::dateProtoFuncSetFullYear):
(JSC::dateProtoFuncSetUTCFullYear):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear):
(JSC::dateProtoFuncToJSON):

  • runtime/Error.cpp:

(JSC::createError):
(JSC::createEvalError):
(JSC::createRangeError):
(JSC::createReferenceError):
(JSC::createSyntaxError):
(JSC::createTypeError):
(JSC::createURIError):
(JSC::addErrorSourceInfo):
(JSC::addErrorDivotInfo):
(JSC::addErrorInfo):
(JSC::hasErrorInfo):
(JSC::throwError):
(JSC::throwTypeError):
(JSC::throwSyntaxError):

  • runtime/Error.h:

(JSC::throwVMError):
(JSC::throwVMTypeError):

  • runtime/ErrorConstructor.cpp:

(JSC::constructWithErrorConstructor):
(JSC::callErrorConstructor):

  • runtime/ErrorConstructor.h:
  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::ErrorInstance):
(JSC::ErrorInstance::create):

  • runtime/ErrorInstance.h:
  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::ErrorPrototype):

  • runtime/ExceptionHelpers.cpp:

(JSC::createStackOverflowError):
(JSC::createUndefinedVariableError):
(JSC::createInvalidParamError):
(JSC::createNotAConstructorError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):
(JSC::throwOutOfMemoryError):

  • runtime/ExceptionHelpers.h:
  • runtime/Executable.cpp:

(JSC::EvalExecutable::compile):
(JSC::ProgramExecutable::checkSyntax):
(JSC::ProgramExecutable::compile):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunction):

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncToString):
(JSC::functionProtoFuncApply):
(JSC::functionProtoFuncCall):

  • runtime/Identifier.cpp:

(JSC::Identifier::from):

  • runtime/Identifier.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::put):

  • runtime/JSFunction.cpp:

(JSC::callHostFunctionAsConstructor):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::decode):
(JSC::globalFuncEval):

  • runtime/JSONObject.cpp:

(JSC::Stringifier::appendStringifiedValue):
(JSC::Walker::walk):
(JSC::JSONProtoFuncParse):
(JSC::JSONProtoFuncStringify):

  • runtime/JSObject.cpp:

(JSC::throwSetterError):
(JSC::JSObject::put):
(JSC::JSObject::putWithAttributes):
(JSC::JSObject::defaultValue):
(JSC::JSObject::hasInstance):
(JSC::JSObject::defineOwnProperty):

  • runtime/JSObject.h:
  • runtime/JSValue.cpp:

(JSC::JSValue::toObjectSlowCase):
(JSC::JSValue::synthesizeObject):
(JSC::JSValue::synthesizePrototype):

  • runtime/NativeErrorConstructor.cpp:

(JSC::constructWithNativeErrorConstructor):
(JSC::callNativeErrorConstructor):

  • runtime/NativeErrorConstructor.h:
  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToString):
(JSC::numberProtoFuncToLocaleString):
(JSC::numberProtoFuncValueOf):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToPrecision):

  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetPrototypeOf):
(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):
(JSC::toPropertyDescriptor):
(JSC::objectConstructorDefineProperty):
(JSC::objectConstructorDefineProperties):
(JSC::objectConstructorCreate):

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):

  • runtime/RegExpConstructor.cpp:

(JSC::constructRegExp):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::match):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncTest):
(JSC::regExpProtoFuncExec):
(JSC::regExpProtoFuncCompile):
(JSC::regExpProtoFuncToString):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncToString):

WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSArrayBufferConstructor.h:

(WebCore::construct):

  • bindings/js/JSArrayBufferViewHelper.h:

(WebCore::setWebGLArrayHelper):

  • bindings/js/JSAudioConstructor.cpp:

(WebCore::constructAudio):

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::JSCanvasRenderingContext2D::setFillColor):
(WebCore::JSCanvasRenderingContext2D::setStrokeColor):
(WebCore::JSCanvasRenderingContext2D::drawImage):
(WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
(WebCore::JSCanvasRenderingContext2D::setShadow):
(WebCore::JSCanvasRenderingContext2D::createPattern):
(WebCore::JSCanvasRenderingContext2D::fillText):
(WebCore::JSCanvasRenderingContext2D::strokeText):

  • bindings/js/JSClipboardCustom.cpp:

(WebCore::JSClipboard::clearData):
(WebCore::JSClipboard::getData):
(WebCore::JSClipboard::setDragImage):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::setDOMException):
(WebCore::toJSSequence):

  • bindings/js/JSDOMWrapper.cpp:

(WebCore::DOMObject::defineOwnProperty):

  • bindings/js/JSDesktopNotificationsCustom.cpp:

(WebCore::JSNotificationCenter::requestPermission):

  • bindings/js/JSEventSourceConstructor.cpp:

(WebCore::constructEventSource):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::open):

  • bindings/js/JSHTMLInputElementCustom.cpp:

(WebCore::JSHTMLInputElement::selectionStart):
(WebCore::JSHTMLInputElement::setSelectionStart):
(WebCore::JSHTMLInputElement::selectionEnd):
(WebCore::JSHTMLInputElement::setSelectionEnd):
(WebCore::JSHTMLInputElement::setSelectionRange):

  • bindings/js/JSImageConstructor.cpp:

(WebCore::constructImage):

  • bindings/js/JSJavaScriptCallFrameCustom.cpp:

(WebCore::JSJavaScriptCallFrame::evaluate):

  • bindings/js/JSMessageChannelConstructor.cpp:

(WebCore::JSMessageChannelConstructor::construct):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::fillMessagePortArray):

  • bindings/js/JSOptionConstructor.cpp:

(WebCore::constructHTMLOptionElement):

  • bindings/js/JSSVGMatrixCustom.cpp:

(WebCore::JSSVGMatrix::multiply):

  • bindings/js/JSSharedWorkerConstructor.cpp:

(WebCore::constructSharedWorker):

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::JSWebGLRenderingContext::bufferData):
(WebCore::JSWebGLRenderingContext::bufferSubData):
(WebCore::getObjectParameter):
(WebCore::JSWebGLRenderingContext::getFramebufferAttachmentParameter):
(WebCore::JSWebGLRenderingContext::getParameter):
(WebCore::JSWebGLRenderingContext::getProgramParameter):
(WebCore::JSWebGLRenderingContext::getShaderParameter):
(WebCore::JSWebGLRenderingContext::getUniform):
(WebCore::JSWebGLRenderingContext::texImage2D):
(WebCore::JSWebGLRenderingContext::texSubImage2D):
(WebCore::dataFunctionf):
(WebCore::dataFunctioni):
(WebCore::dataFunctionMatrix):

  • bindings/js/JSWebSocketConstructor.cpp:

(WebCore::constructWebSocket):

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::send):

  • bindings/js/JSWorkerConstructor.cpp:

(WebCore::constructWorker):

  • bindings/js/JSXMLHttpRequestConstructor.cpp:

(WebCore::constructXMLHttpRequest):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::open):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::BaseWalker::throwStackOverflow):
(WebCore::BaseWalker::throwInterruptedException):
(WebCore::SerializingTreeWalker::startArray):
(WebCore::SerializingTreeWalker::startObject):

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::setException):

  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/c/c_instance.cpp:

(JSC::Bindings::CInstance::moveGlobalExceptionToExecState):
(JSC::Bindings::CInstance::invokeMethod):
(JSC::Bindings::CInstance::invokeDefaultMethod):
(JSC::Bindings::CInstance::invokeConstruct):

  • bridge/jni/jsc/JNIBridgeJSC.cpp:

(JavaField::dispatchValueFromInstance):
(JavaField::dispatchSetValueToInstance):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaInstance::invokeMethod):

  • bridge/objc/objc_instance.mm:

(ObjcInstance::moveGlobalExceptionToExecState):
(ObjcInstance::invokeMethod):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcField::valueFromInstance):
(JSC::Bindings::ObjcField::setValueToInstance):
(JSC::Bindings::ObjcArray::setValueAt):
(JSC::Bindings::ObjcArray::valueAt):
(JSC::Bindings::callObjCFallbackObject):

  • bridge/objc/objc_utility.h:
  • bridge/objc/objc_utility.mm:

(JSC::Bindings::throwError):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::put):

  • bridge/runtime_method.cpp:

(JSC::callRuntimeMethod):

  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::throwInvalidAccessError):

WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::invokeMethod):

5:26 AM Changeset in webkit [60761] by krit@webkit.org
  • 18 edits
    3 adds in trunk

2010-06-06 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

hit testing does not respect clip paths
​https://bugs.webkit.org/show_bug.cgi?id=15162

Test: svg/dynamic-updates/SVGClipPath-influences-hitTesting.html


Added a check, if a float point is not only in the shape/object boundaries
but also is not in the clipped away area of a clipPath.

  • rendering/HitTestRequest.h: (WebCore::HitTestRequest::): (WebCore::HitTestRequest::svgClipContent):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::fillContains): (WebCore::RenderPath::nodeAtFloatPoint):
  • rendering/RenderPath.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::nodeAtFloatPoint):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::nodeAtFloatPoint):
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::hitTestClipContent):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::nodeAtFloatPoint):
  • rendering/SVGRenderSupport.cpp: (WebCore::pointInClippingArea):
  • rendering/SVGRenderSupport.h:

2010-06-06 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

hit testing does not respect clip paths
​https://bugs.webkit.org/show_bug.cgi?id=15162


Two tests were incorrect, because of the assumption, that clipPath doesn't
influence hit testing. They needed an update.
The new test checks, that clipped areas don't throw a hit.

  • svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.txt: Added.
  • svg/dynamic-updates/SVGClipPath-influences-hitTesting.html: Added.
  • svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.txt:
  • svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.txt:
  • svg/dynamic-updates/script-tests/SVGClipPath-influences-hitTesting.js: Added. (executeBackgroundTest): (executeTest):
  • svg/dynamic-updates/script-tests/SVGClipPathElement-dom-clipPathUnits-attr.js: (shouldBeEqualToString.executeTest):
  • svg/dynamic-updates/script-tests/SVGClipPathElement-svgdom-clipPathUnits-prop.js: (executeTest):
4:35 AM Changeset in webkit [60760] by krit@webkit.org
  • 7 edits in trunk/WebCore

2010-06-06 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Pattern/Gradient clean-up
​https://bugs.webkit.org/show_bug.cgi?id=40205

Transformations of SVG Patterns and Gradients can be bundeled.
This calculation also needs just to be calculated once. It's not a great speed-up for most platforms,
but a clean-up and preparation for new features like vectorEffects and others.
Now, that we don't recalucluate the gradient and its transformations, it was necessary to add a way
to transform alreday existing gradients on Cairo. This is done in the same way like Skia transforms
gradients after they were created.


This patch doesn't change functionality, so no new tests added.

  • platform/graphics/Gradient.cpp:
  • platform/graphics/cairo/GradientCairo.cpp: (WebCore::Gradient::setPlatformGradientSpaceTransform):
  • rendering/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::applyResource):
  • rendering/RenderSVGResourceGradient.h:
  • rendering/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::applyResource): (WebCore::RenderSVGResourcePattern::createTileImage): (WebCore::RenderSVGResourcePattern::buildPattern):
  • rendering/RenderSVGResourcePattern.h:
1:04 AM Changeset in webkit [60759] by tkent@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed, test expectation fix.

Add image results of tests added by r60752 for Chromium.

  • platform/chromium-linux/svg/custom/fill-opacity-hsl-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/fill-opacity-hsl-expected.png: Added.
  • platform/chromium-linux/svg/custom/fill-opacity-rgba-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/fill-opacity-rgba-expected.png: Added.
12:40 AM Changeset in webkit [60758] by tkent@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed, test expectation fix.

Add image results of tests added by r60752 for Chromium.

  • platform/chromium-win/svg/custom/fill-opacity-hsl-expected.checksum: Added.
  • platform/chromium-win/svg/custom/fill-opacity-hsl-expected.png: Added.
  • platform/chromium-win/svg/custom/fill-opacity-rgba-expected.checksum: Added.
  • platform/chromium-win/svg/custom/fill-opacity-rgba-expected.png: Added.

Jun 5, 2010:

11:53 PM Changeset in webkit [60757] by tkent@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed, test expectation fix.

Add image results of tests added by r60752 for Chromium.

  • platform/chromium-mac/svg/custom/fill-opacity-hsl-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/fill-opacity-hsl-expected.png: Added.
  • platform/chromium-mac/svg/custom/fill-opacity-rgba-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/fill-opacity-rgba-expected.png: Added.
9:27 PM Changeset in webkit [60756] by mrowe@apple.com
  • 2 edits in trunk/WebKit2

<rdar://problem/8063622> Failure to launch WebProcess.app when framework is outside of the build directory

Rubber-stamped by Dan Bernstein.

  • Configurations/WebProcess.xcconfig:
1:35 PM Changeset in webkit [60755] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, typo/build fix.

  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:

(WebCore::V8SQLStatementErrorCallback::handleEvent):

1:19 PM Changeset in webkit [60754] by dumi@chromium.org
  • 4 edits in trunk/WebCore

Do not pass empty handles to v8.
​https://bugs.webkit.org/show_bug.cgi?id=39896

Reviewed by Adam Barth.

Passing an empty handle to v8 results in a crash with a stack
trace that doesn't give us much information about the cause of the
crash. Instead, if we check the handles we pass to v8 and crash
when they are empty, we do not make things worse, and should get a
more informative stack trace.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/V8/V8TestCallback.cpp:

(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):

  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:

(WebCore::V8SQLStatementErrorCallback::handleEvent):

8:21 AM Changeset in webkit [60753] by tonikitoo@webkit.org
  • 20 edits in trunk/WebCore

2010-05-30 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Darin Adler.

Add a convenient helper getter for Frame* to RenderObject
​https://bugs.webkit.org/show_bug.cgi?id=39928

document()->frame() is being called enough from RenderObject derivated classes
that it worth adding a helper Frame getter as a shortcut.

No behavior change, so no new tests.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isOffScreen): (WebCore::AccessibilityRenderObject::stringValue): (WebCore::AccessibilityRenderObject::selection): (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange):
  • page/EventHandler.cpp: (WebCore::canAutoscroll):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintCustomHighlight): (WebCore::InlineTextBox::paintTextMatchMarker):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintCustomHighlight):
  • rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::isActive):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::flattenFrameSet):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintFocusRings):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::addDashboardRegions):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::panScrollFromPoint): (WebCore::RenderLayer::scrollByRecursively): (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::autoscroll): (WebCore::RenderLayer::isActive): (showLayerTree):
  • rendering/RenderLayerBacking.cpp: (WebCore::inspectorTimelineAgent):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): (WebCore::RenderListBox::paintItemBackground): (WebCore::RenderListBox::panScroll): (WebCore::RenderListBox::autoscroll): (WebCore::RenderListBox::isActive):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::~RenderObject): (WebCore::RenderObject::selectionBackgroundColor): (WebCore::RenderObject::selectionForegroundColor): (WebCore::RenderObject::destroy): (WebCore::RenderObject::addDashboardRegions): (WebCore::RenderObject::animation):
  • rendering/RenderObject.h: (WebCore::RenderObject::document): (WebCore::RenderObject::frame):
7:29 AM Changeset in webkit [60752] by eric@webkit.org
  • 6 edits
    8 adds in trunk

2010-06-05 Jonathan Kliegman <​kliegs@chromium.org>

Reviewed by Dirk Schulze.

SVG doesn't support rgba colors
​https://bugs.webkit.org/show_bug.cgi?id=16183

Enabled processing of rgba, hsl and hsla color specifications
for SVG files. SVG spec calls for CSS2 but common usage and
other browsers suppor CSS3 colors being used in SVG files

  • platform/mac/svg/custom/fill-opacity-hsl-expected.checksum: Added.
  • platform/mac/svg/custom/fill-opacity-hsl-expected.png: Added.
  • platform/mac/svg/custom/fill-opacity-hsl-expected.txt: Added.
  • platform/mac/svg/custom/fill-opacity-rgba-expected.checksum: Added.
  • platform/mac/svg/custom/fill-opacity-rgba-expected.png: Added.
  • platform/mac/svg/custom/fill-opacity-rgba-expected.txt: Added.
  • svg/custom/fill-opacity-hsl.svg: Added.
  • svg/custom/fill-opacity-rgba.svg: Added.

2010-06-05 Jonathan Kliegman <​kliegs@chromium.org>

Reviewed by Dirk Schulze.

SVG doesn't support rgba colors
​https://bugs.webkit.org/show_bug.cgi?id=16183

Enabled processing of rgba, hsl and hsla color specifications
for SVG files. SVG spec calls for CSS2 but common usage and
other browsers suppor CSS3 colors being used in SVG files

Removed unused svg paramater from CSSParser::parseColorFromValue

Tests: svg/custom/fill-opacity-hsl.svg

svg/custom/fill-opacity-rgba.svg

  • css/CSSParser.cpp: (WebCore::CSSParser::parseColorFromValue):
  • css/CSSParser.h:
  • css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue): (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
  • svg/SVGColor.cpp: (WebCore::SVGColor::colorFromRGBColorString):
5:15 AM Changeset in webkit [60751] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-05 Anders Bakken <​agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] ContextMenuItemQt.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=39780

  • platform/qt/ContextMenuItemQt.cpp:
5:03 AM Changeset in webkit [60750] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-05 Anders Bakken <​agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] ContextMenuQt.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=39779

  • platform/qt/ContextMenuQt.cpp:
4:50 AM Changeset in webkit [60749] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-05 Anders Bakken <​agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] DragDataQt.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=39777

  • platform/qt/DragDataQt.cpp:
4:04 AM Changeset in webkit [60748] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-05 Anders Bakken <​agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] FileChooserQt.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=39776

  • platform/qt/FileChooserQt.cpp:
3:52 AM Changeset in webkit [60747] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-05 Anders Bakken <​agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] FileSystemQt.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=39775

  • platform/qt/FileSystemQt.cpp:
3:27 AM Changeset in webkit [60746] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-05 Anders Bakken <​agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] KURLQt.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=39774

  • platform/qt/KURLQt.cpp:
3:12 AM Changeset in webkit [60745] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-05 Anders Bakken <​agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] LoggingQt.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=39772

  • platform/qt/LoggingQt.cpp:
3:00 AM Changeset in webkit [60744] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-05 Anders Bakken <​agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] PlatformKeyboardEventQt.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=39770

  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyIdentifierForQtKeyCode): (WebCore::windowsKeyCodeForKeyEvent): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
2:00 AM Changeset in webkit [60743] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-05 Anders Bakken <​agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] PlatformScreenQt.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=39768

  • platform/qt/PlatformMouseEventQt.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
1:28 AM Changeset in webkit [60742] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-05 Anders Bakken <​agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] RenderThemeQt.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=39767

  • platform/qt/RenderThemeQt.cpp:
12:52 AM Changeset in webkit [60741] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-05 Anders Bakken <​agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] ScrollbarQt.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=39765

  • platform/qt/ScrollbarQt.cpp:
12:40 AM Changeset in webkit [60740] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-05 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add PLATFORM(BREWMP) guard for using std::xxx
​https://bugs.webkit.org/show_bug.cgi?id=39710

Build fix for BREW MP.

  • wtf/MathExtras.h:

Jun 4, 2010:

11:57 PM Changeset in webkit [60739] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5Lexer go fast
​https://bugs.webkit.org/show_bug.cgi?id=40048

This patch changes us from using a jump table for each character to
using absolute jumps between parser states. This appears to be about a
1% improvement on the parser bench mark (which is 1/10th of what we
need to catch the old parser).

I've kept the underlying logic as close to the old logic as possible.
This new form will make it easier to handle the input stream part of
the spec and to make further performance improvements.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::reset): (WebCore::HTML5Lexer::nextToken): (WebCore::HTML5Lexer::emitCurrentToken):
  • html/HTML5Lexer.h:
11:25 PM Changeset in webkit [60738] by abarth@webkit.org
  • 7 edits in trunk

2010-06-04 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

HTML5 parser should be within 1% of old parser performance
​https://bugs.webkit.org/show_bug.cgi?id=40172

Fix cast in this operator= to allow for assignment between vectors with
different inline capacities (as clearly intended by its author).

  • wtf/Vector.h: (WTF::::operator):

2010-06-04 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

HTML5 parser should be within 1% of old parser performance
​https://bugs.webkit.org/show_bug.cgi?id=40172

Stop using adopt(). I think this function is cause us to do extra
mallocs that are hurting performance. Instead of caching AtomicString
on HTML5Token, just use the AtomicString on the old token. Also,
reserve inline capacity for 10 attributes.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::isAppropriateEndTag):
  • html/HTML5Lexer.h:
  • html/HTML5Token.h: (WebCore::HTML5Token::beginStartTag): (WebCore::HTML5Token::beginEndTag): (WebCore::HTML5Token::beginCharacter): (WebCore::HTML5Token::beginComment): (WebCore::HTML5Token::beginDOCTYPE): (WebCore::HTML5Token::name): (WebCore::HTML5Token::characters): (WebCore::HTML5Token::comment):
  • html/HTML5TreeBuilder.cpp: (WebCore::convertToOldStyle): (WebCore::HTML5TreeBuilder::passTokenToLegacyParser):
11:07 PM Changeset in webkit [60737] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Anders Bakken <​agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] ScrollbarThemeQt.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=39764

  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::scPart): (WebCore::scrollbarPart): (WebCore::styleOptionSlider):
10:51 PM Changeset in webkit [60736] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Anders Bakken <​agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] SharedTimerQt.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=39763

  • platform/qt/SharedTimerQt.cpp:
10:39 PM Changeset in webkit [60735] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Anders Bakken <​agbakken@gmail.com>

Reviewed by Eric Seidel.

WidgetQt.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=39759

  • platform/qt/WidgetQt.cpp:
10:27 PM Changeset in webkit [60734] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Anders Bakken <​agbakken@gmail.com>

Reviewed by Eric Seidel.

TemporaryLinkStubsQt.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=39761

  • platform/qt/TemporaryLinkStubsQt.cpp:
10:14 PM Changeset in webkit [60733] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Anders Bakken <​agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] SoundQt.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=39762

  • platform/qt/SoundQt.cpp:
9:53 PM Changeset in webkit [60732] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-04 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Ojan Vafai.

Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633.
​https://bugs.webkit.org/show_bug.cgi?id=40183

  • Scripts/webkitpy/tool/steps/preparechangelog.py:
9:41 PM Changeset in webkit [60731] by eric@webkit.org
  • 5 edits in trunk

2010-06-04 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Dirk Schulze.

Canvas createPattern(img, repetition) shouldn't throw INVALID_STATE_ERR when !img.complete
​https://bugs.webkit.org/show_bug.cgi?id=40166

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-createpattern

  • http/tests/misc/canvas-pattern-from-incremental-image-expected.txt: Updated baseline.
  • http/tests/misc/canvas-pattern-from-incremental-image.html: Fleshed out test.

2010-06-04 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Dirk Schulze.

Canvas createPattern(img, repetition) shouldn't throw INVALID_STATE_ERR when !img.complete
​https://bugs.webkit.org/show_bug.cgi?id=40166

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-createpattern

Test: http/tests/misc/canvas-pattern-from-incremental-image.html (updated)

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
8:52 PM Changeset in webkit [60730] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Anders Bakken <​agbakken@gmail.com>

Reviewed by David Levin.

[Qt] Localizations.cpp has coding-style errors
​https://bugs.webkit.org/show_bug.cgi?id=39773

  • platform/qt/Localizations.cpp: (WebCore::localizedMediaTimeDescription):
8:40 PM Changeset in webkit [60729] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Lyon Chen <​liachen@rim.com>

Reviewed by Darin Adler.

ApplicationCacheStorage::storeNewestCache() Crash WebKit when openDatabase(true) failed
​https://bugs.webkit.org/show_bug.cgi?id=40074

Adding m_database.isOpen() check for every openDatabase(true) call, this is needed because
openDatabase(true) could still fail, for example when cacheStorage is full or no longer available.

  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::store): (WebCore::ApplicationCacheStorage::storeNewestCache):
6:28 PM Changeset in webkit [60728] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-06-04 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r60684.
​http://trac.webkit.org/changeset/60684
​https://bugs.webkit.org/show_bug.cgi?id=40196

This patch broke chromium reliability tests (Requested by
tonyg-cr on #webkit).

  • bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::evaluate):
  • bindings/v8/V8Proxy.h:
6:21 PM WebKit Team edited by dumi@chromium.org
(diff)
6:12 PM Changeset in webkit [60727] by Chris Fleizach
  • 6 edits
    2 adds in trunk

AX: need an aria-help
​https://bugs.webkit.org/show_bug.cgi?id=40010

Reviewed by David Kilzer.

WebCore:

Test: accessibility/aria-help.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::helpText):

  • html/HTMLAttributeNames.in:

LayoutTests:

  • accessibility/aria-help-expected.txt: Added.
  • accessibility/aria-help.html: Added.
  • platform/gtk/Skipped:
  • platform/win/Skipped:
5:43 PM Changeset in webkit [60726] by eric@webkit.org
  • 4 edits in trunk

2010-06-04 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Canvas arc() with zero radius should draw a line to the start point
​https://bugs.webkit.org/show_bug.cgi?id=40164

Unskip canvas/philip/tests/2d.path.arc.zeroradius.html

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arc

  • platform/qt/Skipped:

2010-06-04 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Canvas arc() with zero radius should draw a line to the start point
​https://bugs.webkit.org/show_bug.cgi?id=40164

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arc

  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):
5:23 PM Changeset in webkit [60725] by eric@webkit.org
  • 6 edits in trunk/JavaScriptCore

2010-06-04 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

New QtScript API; QScriptValue::instanceOf.

New function create an easy way to check value's prototype hierarchy.

[Qt] QScriptValue should have an instanceOf method
​https://bugs.webkit.org/show_bug.cgi?id=40120

  • qt/api/qscriptvalue.cpp: (QScriptValue::instanceOf):
  • qt/api/qscriptvalue.h:
  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::instanceOf):
  • qt/tests/qscriptvalue/tst_qscriptvalue.h:
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated_comparison.cpp: (tst_QScriptValue::instanceOf_initData): (tst_QScriptValue::instanceOf_makeData): (tst_QScriptValue::instanceOf_test):
5:12 PM Changeset in webkit [60724] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-06-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] RenderThemeGtk leaks memory
​https://bugs.webkit.org/show_bug.cgi?id=40168

Call gtk_widget_destroy in the RenderThemeGtk destructor. This cleans
up all widget resources when a theme is destroyed.

No new tests, because functionality has not changed.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::~RenderThemeGtk): Call gtk_widget_destroy on m_gtkWindow.
5:11 PM Changeset in webkit [60723] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-06-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] RenderThemeGtk leaks memory
​https://bugs.webkit.org/show_bug.cgi?id=40168

Remove the use of releaseRef to assign a value to a RefPtr. This results in
the original pointer taking an extra reference.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::initMediaStyling): Remove the use of releaseRef here.
5:10 PM Changeset in webkit [60722] by alice.liu@apple.com
  • 8 edits in trunk/WebKit/win

WebFrame::paintDocumentRectToContextAtPoint doesn't paint scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=40034
<rdar://problem/7799848>

Reviewed by Jon Honeycutt.

  • WebFrame.cpp:

(WebFrame::paintScrollViewRectToContextAtPoint): Renamed from paintDocumentRectToContextAtPoint.
Call paint() instead of paintContents(). Also move the dirtyRect to counteract the moving that happens in paint().

Just renaming changes:

  • Interfaces/IWebFramePrivate.idl:
  • Interfaces/IWebViewPrivate.idl:
  • WebFrame.h:
  • WebView.cpp:

(WebView::paintScrollViewRectToContextAtPoint):

  • WebView.h:
  • Interfaces/WebKit.idl: Touched for rebuild.
4:54 PM Changeset in webkit [60721] by sullivan@apple.com
  • 2 edits in trunk/WebKit2

Added a couple of symbols needed to start using WKFrameRefs in Mac clients.

Rubber-stamped by Ada Chan.

  • mac/WebKit2.exp:

Added _WKFrameRelease and _WKFrameRetain.

4:38 PM Changeset in webkit [60720] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

Reviewed by NOBODY (interpreter build fix).

4:20 PM Changeset in webkit [60719] by abarth@webkit.org
  • 1 edit in trunk/WebCore/html/HTML5Lexer.cpp

Actually disable the correct warning.

4:11 PM Changeset in webkit [60718] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-06-04 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Add my new email and IRC nick to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
4:08 PM Changeset in webkit [60717] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Adam Barth <​abarth@webkit.org>

Reviewed by Gavin Barraclough.

Try to fix the windows build
​https://bugs.webkit.org/show_bug.cgi?id=40189

Suppress the "unreachable code" warning because we want to assert that
we don't reach certain code points.

  • html/HTML5Lexer.cpp:
3:57 PM Changeset in webkit [60716] by mrowe@apple.com
  • 5 edits in trunk/JavaScriptCore

Silence some warnings seen on the build bot.

complain about not knowing how to compile them.

3:51 PM Changeset in webkit [60715] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-06-04 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Skipping another test which shows 1-pixel differences between the
32-bit and 64-bit bot.

  • platform/gtk/Skipped:
3:48 PM Changeset in webkit [60714] by kinuko@chromium.org
  • 2 edits in trunk/WebKitTools

2010-06-04 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed.

Revert changes in json_results_generator.py's _get_svn_revision.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3:19 PM Changeset in webkit [60713] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-06-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] GtkLauncher should support relative file paths
​https://bugs.webkit.org/show_bug.cgi?id=39944

Allow GtkLauncher to handle relative file paths passed via command-line arguments.

  • GtkLauncher/main.c: (filename_to_url): Added. (main): Try to resolve arguments as relative file URLs first.
3:12 PM Changeset in webkit [60712] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5Lexer go fast
​https://bugs.webkit.org/show_bug.cgi?id=40048

A couple more cases like the previous patch that I missed.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
2:56 PM Changeset in webkit [60711] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5Lexer go fast
​https://bugs.webkit.org/show_bug.cgi?id=40048

Make all the state transitions in the machine explicit. This allows us
to remove all the break statements, which won't work correctly after we
change the macro definitions.

Also, while I was looking at every line of code, I fixed a bunch of the
one-line-if style errors introduces in my previous patches.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
2:56 PM Changeset in webkit [60710] by Martin Robinson
  • 1 edit
    20 adds in trunk/LayoutTests

2010-06-04 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Adding baselines for new tests. They all seem to be working fine.

  • platform/gtk/editing/selection/range-between-block-and-inline-expected.txt: Added.
  • platform/gtk/fast/css/font-face-in-shadow-DOM-expected.txt: Added.
  • platform/gtk/fast/lists/alpha-boundary-values-expected.txt: Added.
  • platform/gtk/fast/multicol/span/anonymous-style-inheritance-expected.txt: Added.
  • platform/gtk/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Added.
  • platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
  • platform/gtk/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Added.
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Added.
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Added.
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
  • platform/gtk/fast/multicol/span/span-margin-collapsing-expected.txt: Added.
  • platform/gtk/fast/repaint/layout-state-scrolloffset-expected.txt: Added.
  • platform/gtk/fast/repaint/layout-state-scrolloffset2-expected.txt: Added.
  • platform/gtk/fast/repaint/layout-state-scrolloffset3-expected.txt: Added.
  • platform/gtk/svg/filters/feLighting-crash-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/feLighting-crash-expected.txt.
  • platform/gtk/svg/filters/parent-children-with-same-filter-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/parent-children-with-same-filter-expected.txt.
2:47 PM Changeset in webkit [60709] by Martin Robinson
  • 2 edits in trunk/WebKit/gtk

2010-06-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Drag gesture can take mouse grab indefinitely
​https://bugs.webkit.org/show_bug.cgi?id=32840

Initiate drag events with the current GTK+ event instead of synthesizing
an event. Something about synthesized events is causing a drag freeze in
certain situations.

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag): Start the drag with the current GTK+ event.
2:38 PM Changeset in webkit [60708] by barraclough@apple.com
  • 45 edits in trunk

Bug 40187 - Change function signature of NativeConstructor to match NativeFunction

Reviewed by Oliver Hunt.

Mostly for consistency, but constructor & args arguments are redundant,
and this will help if we wish to be able to JIT calls to more constructors.

JavaScriptCore:

  • API/JSCallbackConstructor.cpp:

(JSC::constructJSCallback):

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::construct):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::executeConstruct):

  • interpreter/Interpreter.h:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ArrayConstructor.cpp:

(JSC::constructWithArrayConstructor):

  • runtime/BooleanConstructor.cpp:

(JSC::constructWithBooleanConstructor):

  • runtime/ConstructData.cpp:

(JSC::construct):

  • runtime/ConstructData.h:
  • runtime/DateConstructor.cpp:

(JSC::constructWithDateConstructor):

  • runtime/Error.cpp:

(JSC::constructNativeError):
(JSC::Error::create):

  • runtime/ErrorConstructor.cpp:

(JSC::constructWithErrorConstructor):

  • runtime/FunctionConstructor.cpp:

(JSC::constructWithFunctionConstructor):

  • runtime/NativeErrorConstructor.cpp:

(JSC::constructWithNativeErrorConstructor):

  • runtime/NativeErrorConstructor.h:

(JSC::NativeErrorConstructor::errorStructure):

  • runtime/NumberConstructor.cpp:

(JSC::constructWithNumberConstructor):

  • runtime/ObjectConstructor.cpp:

(JSC::constructWithObjectConstructor):

  • runtime/RegExpConstructor.cpp:

(JSC::constructWithRegExpConstructor):

  • runtime/StringConstructor.cpp:

(JSC::constructWithStringConstructor):

WebCore:

  • bindings/js/JSArrayBufferConstructor.cpp:

(WebCore::constructCanvasArrayBuffer):

  • bindings/js/JSAudioConstructor.cpp:

(WebCore::constructAudio):

  • bindings/js/JSEventSourceConstructor.cpp:

(WebCore::constructEventSource):

  • bindings/js/JSFloatArrayConstructor.cpp:

(WebCore::constructCanvasFloatArray):

  • bindings/js/JSImageConstructor.cpp:

(WebCore::constructImage):

  • bindings/js/JSInt16ArrayConstructor.cpp:

(WebCore::constructCanvasShortArray):

  • bindings/js/JSInt32ArrayConstructor.cpp:

(WebCore::constructCanvasIntArray):

  • bindings/js/JSInt8ArrayConstructor.cpp:

(WebCore::constructCanvasByteArray):

  • bindings/js/JSMessageChannelConstructor.cpp:

(WebCore::JSMessageChannelConstructor::construct):

  • bindings/js/JSMessageChannelConstructor.h:
  • bindings/js/JSOptionConstructor.cpp:

(WebCore::constructHTMLOptionElement):

  • bindings/js/JSSharedWorkerConstructor.cpp:

(WebCore::constructSharedWorker):

  • bindings/js/JSUint16ArrayConstructor.cpp:

(WebCore::constructCanvasUnsignedShortArray):

  • bindings/js/JSUint32ArrayConstructor.cpp:

(WebCore::constructCanvasUnsignedIntArray):

  • bindings/js/JSUint8ArrayConstructor.cpp:

(WebCore::constructCanvasUnsignedByteArray):

  • bindings/js/JSWebKitCSSMatrixConstructor.cpp:

(WebCore::constructWebKitCSSMatrix):

  • bindings/js/JSWebKitPointConstructor.cpp:

(WebCore::constructWebKitPoint):

  • bindings/js/JSWebSocketConstructor.cpp:

(WebCore::constructWebSocket):

  • bindings/js/JSWorkerConstructor.cpp:

(WebCore::constructWorker):

  • bindings/js/JSXMLHttpRequestConstructor.cpp:

(WebCore::constructXMLHttpRequest):

  • bindings/js/JSXSLTProcessorConstructor.cpp:

(WebCore::constructXSLTProcessor):

  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/runtime_object.cpp:

(JSC::Bindings::callRuntimeConstructor):

2:06 PM Changeset in webkit [60707] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/RealtimeAnalyser.cpp

Don't crash if null array passed into real-time analyser

1:58 PM Changeset in webkit [60706] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-04 Stephen White <​senorblanco@chromium.org>

Unreviewed; expectations fix.

Fix chromium test expectations, post-r60693. We are still failing the test in the same way, but since there are now fallback results, our results are no longer MISSING, but TEXT.

  • platform/chromium/test_expectations.txt:
1:54 PM Changeset in webkit [60705] by adachan@apple.com
  • 4 edits in trunk/WebKit2

Reviewed by Anders Carlsson.

​http://bugs.webkit.org/show_bug.cgi?id=40186


Need to close WebPageProxy when the WebView is destroyed.
Also, WebPageProxy shouldn't hold an OwnPtr to the PageClient, which is the WebView on Windows.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): (WebKit::WebPageProxy::setPageClient):
  • UIProcess/WebPageProxy.h:
  • UIProcess/win/WebView.cpp: (WebKit::WebView::close):
1:06 PM Changeset in webkit [60704] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5Lexer go fast
​https://bugs.webkit.org/show_bug.cgi?id=40048

Change the intent of the loop to match what it's going to be once we
remove the loop. This is a whitespace only change that will make the
final diff much, much smaller. Sorry for the transient ugly style.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
1:00 PM Changeset in webkit [60703] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5Lexer go fast
​https://bugs.webkit.org/show_bug.cgi?id=40048

Introduce ADVANCE_TO macro. This is the last macro we need to
introduce.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
12:54 PM Changeset in webkit [60702] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5Lexer go fast
​https://bugs.webkit.org/show_bug.cgi?id=40048

Fix the rest of the RECONSUME_IN cases that were missed by our script.
Also, reorder some assigment to prepare for the ADVANCE_TO patch.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
12:44 PM Changeset in webkit [60701] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5Lexer go fast
​https://bugs.webkit.org/show_bug.cgi?id=40048

This patch handles the FLUSH_AND_ADVANCE_TO case. Again, this patch
introduces style errors that will be fixed shortly.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
12:41 PM Changeset in webkit [60700] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-06-04 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly
​https://bugs.webkit.org/show_bug.cgi?id=40182

Instead of invoking signal handlers directly via g_signal_emit_by_name, call
gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit
without breaking DRT.

  • DumpRenderTree/gtk/EventSender.cpp: (dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly. (keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event.
12:38 PM Changeset in webkit [60699] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5Lexer go fast
​https://bugs.webkit.org/show_bug.cgi?id=40048

This patch handles the FLUSH_EMIT_AND_RESUME_IN case. This patch
introduces some bad style w.r.t. one-line if statements, but we'll fix
them all automatically in cleanup patch when we're done.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
12:37 PM Changeset in webkit [60698] by senorblanco@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-06-04 Stephen White <​senorblanco@chromium.org>

Unreviewed; build fix.

[CHROMIUM] Add new chromium test results for new layout test svg/filters/filter-on-filter-for-text.svg

  • platform/chromium-linux/svg/filters/filter-on-filter-for-text-expected.checksum: Added.
  • platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.checksum: Added.
  • platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.png: Added.
  • platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.txt: Added.
12:30 PM Changeset in webkit [60697] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5Lexer go fast
​https://bugs.webkit.org/show_bug.cgi?id=40048

More small steps. This patch deals with emitting tokens.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
12:19 PM Changeset in webkit [60696] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5Lexer go fast
​https://bugs.webkit.org/show_bug.cgi?id=40048

The next step: using macros to delimit each state. Evetually, we're
going to change what these macros expand to.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
12:13 PM Changeset in webkit [60695] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-06-04 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

Accessibility focus change notifications are now sent from
ChromeClientImpl::focusedNodeChanged().
​https://bugs.webkit.org/show_bug.cgi?id=39792

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::focus): (WebKit::ChromeClientImpl::focusedNodeChanged):
12:06 PM Changeset in webkit [60694] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5Lexer go fast
​https://bugs.webkit.org/show_bug.cgi?id=40048

We're going to do this patch in small steps to make it easier to verify correctness.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
12:03 PM Changeset in webkit [60693] by andersca@apple.com
  • 4 edits
    1 add
    3 deletes in trunk

2010-06-04 Anders Carlsson <​andersca@apple.com>

Reviewed by David Hyatt.

Make the editing/spelling/context-menu-suggestions.html test more robust
​https://bugs.webkit.org/show_bug.cgi?id=40178

  • editing/spelling/context-menu-suggestions-expected.txt: Added. Add new expected test result.


  • editing/spelling/context-menu-suggestions.html: Instead of dumping the menu item titles, check the length and check that the number of items is greater when there are spell checker suggestions.
  • platform/mac-leopard/editing/spelling/context-menu-suggestions-expected.txt: Removed.
  • platform/mac-snowleopard/editing/spelling/context-menu-suggestions-expected.txt: Removed.
  • platform/mac-tiger/editing/spelling/context-menu-suggestions-expected.txt: Removed. Remove platform specific versions.

2010-06-04 Anders Carlsson <​andersca@apple.com>

Reviewed by David Hyatt.

Make the editing/spelling/context-menu-suggestions.html test more robust
​https://bugs.webkit.org/show_bug.cgi?id=40178

Change the contextClick method to return an array of strings describing the context menu items.

  • DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController contextClick]):
11:48 AM Changeset in webkit [60692] by eric@webkit.org
  • 4 edits in trunk

2010-06-04 Jay Civelli <​jcivelli@chromium.org>

Reviewed by David Levin.

[chromium] Adding support for the left and right Windows keys to the

NativeWebKeyboardEvent.

​https://bugs.webkit.org/show_bug.cgi?id=39752

  • platform/chromium/KeyCodeConversionGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent):

2010-06-04 Jay Civelli <​jcivelli@chromium.org>

Reviewed by David Levin.

[chromium] Adding support for the left and right Windows keys to the

NativeWebKeyboardEvent.

​https://bugs.webkit.org/show_bug.cgi?id=39752

  • src/gtk/WebInputEventFactory.cpp: (WebKit::gdkEventToWindowsKeyCode):
11:25 AM Changeset in webkit [60691] by adachan@apple.com
  • 5 edits in trunk/WebKit2

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=40152


Need to remove the WebView from WindowMessageBroadcaster's listeners list when the WebView is destroyed.

  • UIProcess/API/win/WKView.cpp: (WKViewSetHostWindow): Expose API to change the host window of a WKView. (WKViewWindowAncestryDidChange): Expose API to allow clients to notify WebKit when a WKView's window ancestry has changed.
  • UIProcess/API/win/WKView.h:
  • UIProcess/win/WebView.cpp: (WebKit::WebView::wndProc): Set the WebView's host window to 0 when it's destroyed. setHostWindow() will call windowAncestryDidChange(), which will remove this WebView from the WindowMessageBroadcaster's listeners list. (WebKit::WebView::WebView): Initialize m_isBeingDestroyed. (WebKit::WebView::setHostWindow): Update the window's parent window and call windowAncestryDidChange(). (WebKit::WebView::close): Set the host window to 0.
  • UIProcess/win/WebView.h:
11:19 AM Changeset in webkit [60690] by kinuko@chromium.org
  • 5 edits in trunk/WebKitTools

2010-06-03 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Shinichiro Hamaji.

Clean up chromium-specific code from json_results_generator.py.
​https://bugs.webkit.org/show_bug.cgi?id=39665

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
11:02 AM Changeset in webkit [60689] by krit@webkit.org
  • 5 edits
    4 adds in trunk

2010-06-04 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG filter on filter don't work
​https://bugs.webkit.org/show_bug.cgi?id=32708


Any child of <text> was not allowed to use the same filter as the text root.
I couldn't found any reason in the SVG specification that legimitate this.
Only batik also doesn't allow the same filter on the text root as on it's childs,
while any other effect is still allowed.
I removed this limitation so that the result looks like the result on Firefox.

Test: svg/filters/filter-on-filter-for-text.svg

  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker): (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback): (WebCore::SVGRootInlineBox::paint):

2010-06-04 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG filter on filter don't work
​https://bugs.webkit.org/show_bug.cgi?id=32708


Test that a filter can be used by the text root as well as on it's childs.

  • platform/mac/svg/filters/filter-on-filter-for-text-expected.checksum: Added.
  • platform/mac/svg/filters/filter-on-filter-for-text-expected.png: Added.
  • platform/mac/svg/filters/filter-on-filter-for-text-expected.txt: Added.
  • svg/filters/filter-on-filter-for-text.svg: Added.
10:41 AM Changeset in webkit [60688] by Nate Chapin
  • 7 edits in trunk/WebCore

2010-06-04 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Factor PageCache functionality out of FrameLoader and into
PageCache itself.

​https://bugs.webkit.org/show_bug.cgi?id=39382

Refactor only, so no new tests.

  • history/PageCache.cpp: (WebCore::pageCacheLogPrefix): (WebCore::pageCacheLog): (WebCore::logCanCacheFrameDecision): (WebCore::logCanCachePageDecision): (WebCore::PageCache::canCachePageContainingThisFrame): (WebCore::PageCache::canCache): (WebCore::PageCache::add): (WebCore::PageCache::get):
  • history/PageCache.h:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitIfReady):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::prepareForCachedPageRestore): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::loadProvisionalItemFromCachedPage): (WebCore::FrameLoader::navigateToDifferentDocument):
  • loader/FrameLoader.h: (WebCore::FrameLoader::quickRedirectComing):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
10:23 AM Changeset in webkit [60687] by loislo@chromium.org
  • 3 edits in trunk/WebCore

2010-06-04 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Web Inspector: it would be better to push object properties to JSON string in order of insertion.
​https://bugs.webkit.org/show_bug.cgi?id=40140

  • inspector/InspectorValues.cpp: (WebCore::InspectorObject::writeJSON):
  • inspector/InspectorValues.h: (WebCore::InspectorObject::setBool): (WebCore::InspectorObject::setNumber): (WebCore::InspectorObject::setString): (WebCore::InspectorObject::set):
10:07 AM Changeset in webkit [60686] by Laszlo Gombos
  • 2 edits in trunk/WebKit/qt

2010-06-04 Laszlo Gombos <Laszlo Gombos>

Symbian build fix.

[Qt] Updated the def file with recent new exports.

  • symbian/eabi/QtWebKitu.def:
10:05 AM Changeset in webkit [60685] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed.

Unskip fast/dom/Window/window-properties-geolocation.html - a comment says it should be
enabled once bug 34025 is fixed, which happened long ago. The test passes for me.

  • platform/mac/Skipped:
9:59 AM Changeset in webkit [60684] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-06-04 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Persist V8's ScriptData to the memory cache.
​https://bugs.webkit.org/show_bug.cgi?id=38661

This stores V8's ScriptData in the memory cache and also causes the
network platform layer to be notified of the available cacheable
metadata.

Chromium's morejs benchmark shows a 3-4% improvement on fast hardware.

No new tests because no new functionality.

  • bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::cachedScript):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::precompileScript): (WebCore::V8Proxy::evaluate):
  • bindings/v8/V8Proxy.h:
9:44 AM Changeset in webkit [60683] by eric@webkit.org
  • 17 edits in trunk

2010-06-04 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Add a takeFirst() method to Deque and use it where appropriate.
​https://bugs.webkit.org/show_bug.cgi?id=40089

  • wtf/Deque.h: (WTF::::takeFirst):
  • wtf/MainThread.cpp: (WTF::dispatchFunctionsFromMainThread):
  • wtf/MessageQueue.h: (WTF::::tryGetMessage):

2010-06-04 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Utilize new takeFirst() method where appropriate.
​https://bugs.webkit.org/show_bug.cgi?id=40089

No new tests because no new functionality.

  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::addSubresourceStyleURLs):
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::PendingCallbacks::callAndRemoveFirstCallback):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::executeExternalScriptsIfReady):
  • platform/text/SegmentedString.cpp: (WebCore::SegmentedString::advanceSubstring):
  • storage/Database.cpp: (WebCore::Database::scheduleTransaction):
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::getNextStatement):
  • storage/SQLTransactionCoordinator.cpp: (WebCore::SQLTransactionCoordinator::processPendingTransactions):

2010-06-04 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Utilize new takeFirst() method where appropriate.
​https://bugs.webkit.org/show_bug.cgi?id=40089

  • Platform/CoreIPC/ArgumentDecoder.cpp: (CoreIPC::ArgumentDecoder::removeAttachment):

2010-06-04 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Utilize new takeFirst() method where appropriate.
​https://bugs.webkit.org/show_bug.cgi?id=40089

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::replaySavedEvents):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::WorkQueue::processWork): (LayoutTestController::WorkQueue::reset):
8:37 AM Changeset in webkit [60682] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Nikita Vasilyev <​me@elv1s.ru>

Reviewed by Pavel Feldman.

Web Inspector: better Function.prototype.bind for the internal code.

In the "Event Listeners" pane show handler function instead of Function.prototype.bind.

​https://bugs.webkit.org/show_bug.cgi?id=40080

  • inspector/front-end/utilities.js: (Function.prototype.bind.bound): (Function.prototype.bind.bound.toString): (Function.prototype.bind):
8:01 AM Changeset in webkit [60681] by apavlov@chromium.org
  • 4 edits in trunk/WebCore

2010-06-04 Alexander Pavlov <​apavlov@chromium.org>

Unreviewed, fix Qt build.

Add references to a new file.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/WebKit.qrc:
7:17 AM Changeset in webkit [60680] by apavlov@chromium.org
  • 4 edits
    1 add in trunk/WebCore

2010-06-04 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Eliminate direct dependency of StylesSidebarPane on InspectorBackend
​https://bugs.webkit.org/show_bug.cgi?id=40069

No new tests are needed, as this is a refactoring.

  • inspector/front-end/CSSStyleModel.js: Added. (WebInspector.CSSStyleModel): (WebInspector.CSSStyleModel.prototype.getStylesAsync): (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync): (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.addRule): (WebInspector.CSSStyleModel.prototype.toggleStyleEnabled): (WebInspector.CSSStyleModel.prototype.setCSSText): (WebInspector.CSSStyleModel.prototype.applyStyleText):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.stylesCallback): (WebInspector.StylesSidebarPane.prototype.update.computedStyleCallback): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._arrayContainsInheritedProperty): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback): (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.loaded):
7:06 AM Changeset in webkit [60679] by yurys@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-06-04 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Create resource for DebuggerScript.js.
​https://bugs.webkit.org/show_bug.cgi?id=40122

  • WebKit.grd:
  • public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::debuggerScriptSource):
6:50 AM Changeset in webkit [60678] by yael.aharon@nokia.com
  • 2 edits in trunk/WebKitTools

[Qt] QtTestLauncher should allow notifications by default.
​https://bugs.webkit.org/show_bug.cgi?id=40078

Reviewed by Simon Hausmann.

  • QtTestBrowser/main.cpp:

(NotificationsPermissionController::NotificationsPermissionController):
(NotificationsPermissionController::checkPermission):
(NotificationsPermissionController::requestPermission):
(LauncherWindow::LauncherWindow):

6:26 AM Changeset in webkit [60677] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Compilation fails when compiling against Qt 4.7 and Qt Mobility is installed
​https://bugs.webkit.org/show_bug.cgi?id=40116

Reviewed by Tor Arne Vestbø.

CONFIG += mobility has the side-effect of pulling in mobility includes, which conflict
with Qt 4.7's bearer managenent includes and break the build.

  • WebCore.pro:
5:05 AM Changeset in webkit [60676] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Fix scrolling bug with pages using accelerated compositing.
​https://bugs.webkit.org/show_bug.cgi?id=40037

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::drawLayers):
4:52 AM Changeset in webkit [60675] by eric@webkit.org
  • 15 edits in trunk

2010-06-04 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Darin Adler.

CG implementation needed for compression quality in canvas.toDataURL
​https://bugs.webkit.org/show_bug.cgi?id=38492

  • platform/mac/Skipped:

2010-06-04 Matthew Delaney <​mdelaney@apple.com>

Reviewed by Darin Adler.

CG implementation needed for compression quality in canvas.toDataURL
​https://bugs.webkit.org/show_bug.cgi?id=38492

Took toDataURL.jpeg.quality.basic.html test off of Skipped list. Passes.

Went the route of avoiding in-band signaling to flag the use of a quality
parameter or not. So, instead of simply passing the quality down as a
double, instead I pass a reference to the quality parameter from where
it comes in just after the JS bindings. Thus, no need for any global
constants to signify when the quality is not specified. Updated the other
platforms to support this (qt was on the only one currently with any
implementation).

  • bindings/js/JSHTMLCanvasElementCustom.cpp: Moved range check logic for quality parameter down lower. Updated call to toDataURL to use double* instead of just passing the quality directly. (WebCore::JSHTMLCanvasElement::toDataURL):
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Updated toDataURL call to pass double* (WebCore::V8HTMLCanvasElement::toDataURLCallback):
  • dom/CanvasSurface.cpp: Updated method prototype. (WebCore::CanvasSurface::toDataURL):
  • dom/CanvasSurface.h: Updated method prototype. (WebCore::CanvasSurface::toDataURL):
  • platform/graphics/ImageBuffer.h: Updated method signature to use double* for quality param.
  • platform/graphics/cairo/ImageBufferCairo.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/cg/ImageBufferCG.cpp: Implemented support for quality parametejr when jpeg MIME type used. (WebCore::jpegUTI): (WebCore::utiFromMIMEType): (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/haiku/ImageBufferHaiku.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/qt/ImageBufferQt.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/skia/ImageBufferSkia.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/wince/ImageBufferWince.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/wx/ImageBufferWx.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL):
4:06 AM Changeset in webkit [60674] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

Unreviewed. Rolling out r60671 because it caused a lot of test
failures on Chromium.

3:56 AM Changeset in webkit [60673] by alex
  • 2 edits in trunk/WebCore

2010-06-04 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

Leaks in listDirectory
​https://bugs.webkit.org/show_bug.cgi?id=40008

Fixed both leaks.

  • platform/gtk/FileSystemGtk.cpp: (WebCore::listDirectory):
3:44 AM Changeset in webkit [60672] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Skip fast/dom/Geolocation/callback-to-remote-context2.html on GTK.
​https://bugs.webkit.org/show_bug.cgi?id=40153

  • platform/gtk/Skipped:
3:37 AM QtWebKitJournal edited by Simon Hausmann
(diff)
3:24 AM Changeset in webkit [60671] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-06-04 Victoria Kirst <​vrk@google.com>

Reviewed by David Levin.

Modifying the WebMediaPlayer interface to be compatible with
a change in chrome.
This is a part 2 of 3 one-sided changes to chrome and WebKit. Chrome
has been updated, so this commit should NOT break chromium anymore.
​https://bugs.webkit.org/show_bug.cgi?id=39445

  • public/WebMediaPlayer.h: Changed buffered() to be non-const.
2:58 AM Changeset in webkit [60670] by eric@webkit.org
  • 7 edits in trunk/WebCore

2010-06-04 Anton Muhin <​antonm@chromium.org>

Reviewed by Nate Chapin.

[Chromium] get rid of named interceptor on HTMLDocument and introduce/remove accessors when named items get deleted/removed
​https://bugs.webkit.org/show_bug.cgi?id=39877

This patch makes callbacks invoked on named items addition/removal
install API accessors and thus there is no more need in
named and indexed interceptors on HTMLDocument which
speeds up invocation of methods on document.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::checkDocumentWrapper): (WebCore::V8DOMWindowShell::updateDocumentWrapperCache): (WebCore::getter): (WebCore::V8DOMWindowShell::namedItemAdded): (WebCore::V8DOMWindowShell::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::WrapInShadowObject): (WebCore::V8HTMLDocument::GetNamedProperty): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8):
2:56 AM Changeset in webkit [60669] by steveblock@google.com
  • 1 edit
    3 adds in trunk/LayoutTests

2010-06-04 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Geolocation needs more LayoutTests to test making callbacks to remote frames
​https://bugs.webkit.org/show_bug.cgi?id=40146

This test is similar to callback-to-remote-context.html in that it test making a callback
from a Geolocation object to a remote frame. In callback-to-remote-context.html, the call
chain to the Geolocation method is started from the owning frame. In this test, however,
the call chain is started from the remote frame.

  • fast/dom/Geolocation/callback-to-remote-context2-expected.txt: Added.
  • fast/dom/Geolocation/callback-to-remote-context2.html: Added.
  • fast/dom/Geolocation/script-tests/callback-to-remote-context2.js: Added.
2:42 AM QtWebKitJournal edited by Simon Hausmann
(diff)
2:42 AM Changeset in webkit [60668] by eric@webkit.org
  • 9 edits in trunk/WebCore

2010-06-04 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kent Tamura.

Change filenameFromString to return CString
​https://bugs.webkit.org/show_bug.cgi?id=39494

filenameFromString returns a newly allocated string and the caller must
free the string. GTK and EFL ports use g_free while all others ports use
fastFree. This is confusing because the same function behaves
differently with respect to ports. Change filenameFromString to return
CString.

  • platform/FileSystem.cpp: (WebCore::filenameFromString):
  • platform/FileSystem.h:
  • platform/efl/FileSystemEfl.cpp: (WebCore::filenameFromString):
  • platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth):
  • platform/gtk/FileSystemGtk.cpp: (WebCore::filenameFromString): (WebCore::filenameForDisplay): (WebCore::fileExists): (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::makeAllDirectories): (WebCore::pathGetFileName): (WebCore::directoryName): (WebCore::listDirectory):
  • platform/gtk/SharedBufferGtk.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp):
  • platform/posix/SharedBufferPOSIX.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
2:32 AM Changeset in webkit [60667] by steveblock@google.com
  • 19 edits in trunk/LayoutTests

2010-06-04 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Geolocation LayoutTests should make more careful use of LayoutTestController
​https://bugs.webkit.org/show_bug.cgi?id=39994

Guards calls to LayoutTestController methods with 'if (window.layoutTestController)'
and adds test output to make it clear if the test can not pass without LayoutTestController.
Also removes superfluous calls to LayoutTestController.waitUntilDone(), which are now made
by js-test-post.js.

  • fast/dom/Geolocation/callback-exception-expected.txt:
  • fast/dom/Geolocation/script-tests/callback-exception.js:
  • fast/dom/Geolocation/script-tests/error.js:
  • fast/dom/Geolocation/script-tests/maximum-age.js:
  • fast/dom/Geolocation/script-tests/notimer-after-unload.js:
  • fast/dom/Geolocation/script-tests/permission-denied-already-clear-watch.js:
  • fast/dom/Geolocation/script-tests/permission-denied-already-error.js:
  • fast/dom/Geolocation/script-tests/permission-denied-already-success.js:
  • fast/dom/Geolocation/script-tests/permission-denied-stops-watches.js:
  • fast/dom/Geolocation/script-tests/permission-denied.js:
  • fast/dom/Geolocation/script-tests/position-string.js:
  • fast/dom/Geolocation/script-tests/reentrant-error.js:
  • fast/dom/Geolocation/script-tests/reentrant-success.js:
  • fast/dom/Geolocation/script-tests/success.js:
  • fast/dom/Geolocation/script-tests/timeout-clear-watch.js:
  • fast/dom/Geolocation/script-tests/timeout-zero.js:
  • fast/dom/Geolocation/script-tests/timeout.js:
  • fast/dom/Geolocation/script-tests/watch.js:
1:55 AM Changeset in webkit [60666] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-06-04 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Detect whether the user's environment can open a browser.
​https://bugs.webkit.org/show_bug.cgi?id=40136

Some environments like cygwin silently fail webbrowser.open() causing
webkit-patch upload not to display any diff. This detects environments
where webbrowser.open() would fail by testing if webbrowser.get()
raises an exception.

  • Scripts/webkitpy/common/system/user.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/confirmdiff.py:
1:44 AM Changeset in webkit [60665] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix compilation with QT_NO_FEATURE
​https://bugs.webkit.org/show_bug.cgi?id=38324

The #ifdef QT_NO_GRAPHICSEFFECT was in the wrong place, would have
made AC not work at all.

No new tests.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges):
1:32 AM Changeset in webkit [60664] by eric@webkit.org
  • 4 edits in trunk

2010-06-04 Qi Zhang <​qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Failed at ​http://philip.html5.org/tests/canvas/suite/tests/2d.path.arcTo.ensuresubpath.1.html
​https://bugs.webkit.org/show_bug.cgi?id=38645

Remove 2d.path.arcTo.ensuresubpath.1.html from Skipped.

  • platform/qt/Skipped:

2010-06-04 Qi Zhang <​qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Failed at ​http://philip.html5.org/tests/canvas/suite/tests/2d.path.arcTo.ensuresubpath.1.html
​https://bugs.webkit.org/show_bug.cgi?id=38645

Path arcto function need to ensure there is subpath before it.

  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArcTo):
1:20 AM Changeset in webkit [60663] by eric@webkit.org
  • 4 edits in trunk

2010-06-04 Qi Zhang <​qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] failed at ​http://philip.html5.org/tests/canvas/suite/tests/2d.path.arc.angle.3.html
​https://bugs.webkit.org/show_bug.cgi?id=38537

Remove canvas/philip/tests/2d.path.arcTo.2d.path.arc.angle.3.html and
canvas/philip/tests/2d.path.arcTo.2d.path.arc.angle.5.html from Skipped.

  • platform/qt/Skipped:

2010-06-04 Qi Zhang <​qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] failed at ​http://philip.html5.org/tests/canvas/suite/tests/2d.path.arc.angle.3.html
​https://bugs.webkit.org/show_bug.cgi?id=38537

For path.arc function handle span > 2PI

  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):
1:08 AM Changeset in webkit [60662] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-04 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Remove a QEXPECT_FAIL flag from an autotest.

Test tst_QScriptEngine::globalObject pass after 36600 bug
fix have been applied.

[Qt] Expected fail in the tst_QScriptEngine::globalObject should be removed.
​https://bugs.webkit.org/show_bug.cgi?id=40114

  • qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::globalObject):
12:58 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
12:57 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
12:54 AM Changeset in webkit [60661] by eric@webkit.org
  • 5 edits in trunk/JavaScriptCore

2010-06-04 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix QScriptValue::equals.

Handling for a few edge cases were added. Now comparison between
NaN, an invalid objects should works as supposed.

[Qt] QScriptValue::equals problems
​https://bugs.webkit.org/show_bug.cgi?id=40110

  • qt/api/qscriptvalue.cpp: (QScriptValue::equals):
  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::equals):
  • qt/tests/qscriptvalue/tst_qscriptvalue.h:
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated_comparison.cpp: (tst_QScriptValue::equals_initData): (tst_QScriptValue::equals_makeData): (tst_QScriptValue::equals_test):
12:54 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
12:48 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
12:42 AM Changeset in webkit [60660] by eric@webkit.org
  • 5 edits in trunk

2010-06-04 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Set attributes.stencil to false by default at context creation
​https://bugs.webkit.org/show_bug.cgi?id=40090

  • fast/canvas/webgl/context-attributes-expected.txt: Check if the default attributes.stencil == false.
  • fast/canvas/webgl/context-attributes.html: Ditto.

2010-06-04 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Set attributes.stencil to false by default at context creation
​https://bugs.webkit.org/show_bug.cgi?id=40090

  • platform/graphics/GraphicsContext3D.h: Set default attributes.stencil to false. (WebCore::GraphicsContext3D::Attributes::Attributes):
12:07 AM Changeset in webkit [60659] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, test expectation update.

websocket/tests/reload-crash.html sometimes crash.

  • platform/chromium/test_expectations.txt:

Jun 3, 2010:

11:35 PM Changeset in webkit [60658] by morrita@google.com
  • 5 edits in trunk/WebCore

2010-06-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Eric Carlson.

Fix a crash when trying to use an invalid media src url by
moving the isValid url checks to a central location in
isSafeToLoadURL function. Also added an empty string check
in DocumentLoader::didTellClientAboutLoad.

Test: media/invalid-media-url-crash.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL): (WebCore::HTMLMediaElement::selectNextSourceChild): (WebCore::HTMLMediaElement::getPluginProxyParams):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::didTellClientAboutLoad):
11:16 PM Changeset in webkit [60657] by tkent@chromium.org
  • 6 edits
    2 adds in trunk

2010-06-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Eric Carlson.

Tests that invalid media src url does not result in crash.

  • media/invalid-media-url-crash-expected.txt: Added.
  • media/invalid-media-url-crash.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2010-06-03 Abhishek Arya <​inferno@chromium.org>

Reviewed by Eric Carlson.

Fix a crash when trying to use an invalid media src url by
moving the isValid url checks to a central location in
isSafeToLoadURL function. Also added an empty string check
in DocumentLoader::didTellClientAboutLoad.

Test: media/invalid-media-url-crash.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL): (WebCore::HTMLMediaElement::selectNextSourceChild): (WebCore::HTMLMediaElement::getPluginProxyParams):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::didTellClientAboutLoad):
11:09 PM Changeset in webkit [60656] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-06-03 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by David Levin.

Add dependencies required to link with VS Express 2005.
​https://bugs.webkit.org/show_bug.cgi?id=40038

Visual Studio implicitly links against these libs.
VC++ Express does not.

  • WebKitAPITest/WebKitAPITestCommon.vsprops:
  • WinLauncher/WinLauncher.vcproj:
10:57 PM Changeset in webkit [60655] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-03 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

New states in QScriptValuePrivate.

The CSpecial state was divided into CNull and CUndefined. It simplify
the QScriptValue code by avoiding a few "cast" and "if".
Moreover the MSVS compiler didn't like casting between a double and an
enum which is avoided now.

[Qt] The QScriptValuePrivate::CSpecial is too generic.
​https://bugs.webkit.org/show_bug.cgi?id=40067

  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::): (QScriptValuePrivate::QScriptValuePrivate): (QScriptValuePrivate::isNull): (QScriptValuePrivate::isUndefined): (QScriptValuePrivate::toString): (QScriptValuePrivate::toNumber): (QScriptValuePrivate::toBool): (QScriptValuePrivate::toObject): (QScriptValuePrivate::assignEngine): (QScriptValuePrivate::isNumberBased):
10:14 PM Changeset in webkit [60654] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

2010-06-03 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by David Levin.

bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
​https://bugs.webkit.org/show_bug.cgi?id=40105

  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • kill pywebsocket process when url is not alive and the process is not terminated, not to leave pywebsocket server running.
  • fix codecs.open parameters.
9:28 PM Changeset in webkit [60653] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Test expectation fix.

Skip fast/dom/Geolocation/callback-to-remote-context.html on GTK.
​https://bugs.webkit.org/show_bug.cgi?id=40153

  • platform/gtk/Skipped:
9:22 PM Changeset in webkit [60652] by ukai@chromium.org
  • 5 edits in trunk

2010-06-03 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
​https://bugs.webkit.org/show_bug.cgi?id=39058

  • platform/mac-tiger/Skipped:
  • remove websocket/tests from skipped list.

2010-06-03 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
​https://bugs.webkit.org/show_bug.cgi?id=39058

  • Scripts/ensure-valid-python:
    • Perl 5.8 doesn't have File::Temp->newdir(). Use File::Temp->tempdir() instead.
    • Add --check-only and --help option.
    • --check-only option only checks python version and don't try to install Python 2.5.
    • Set executable bit.
  • Scripts/old-run-webkit-tests:
    • Check if it can run the websocket tests by calling ensure-valid-python --check-only.
6:57 PM Changeset in webkit [60651] by morrita@google.com
  • 4 edits in trunk/WebKit/chromium

2010-05-26 MORITA Hajime <​morrita@google.com>

Reviewed by Jian Li.

[Chromium] Dragging over an element with scrollbars should scroll the element when dragging near edges
​https://bugs.webkit.org/show_bug.cgi?id=39725

Added WebViewImpl::scrollForDragging() to handle scroll-on-drag.
Note that this change handes both source and destination cases.

  • public/WebView.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragSourceMovedTo): (WebKit::WebViewImpl::dragTargetDragEnterOrOver): (WebKit::WebViewImpl::scrollForDragging):
  • src/WebViewImpl.h:
6:44 PM Changeset in webkit [60650] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore
  • wtf/Platform.h:

Reviewed by NOBODY (Qt build fix).

6:31 PM Changeset in webkit [60649] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-06-03 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r60642.
​http://trac.webkit.org/changeset/60642
​https://bugs.webkit.org/show_bug.cgi?id=40151

Broke rendering of border images on rotated elements
(Requested by jamesr on #webkit).

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawTiledImage):
  • platform/graphics/GraphicsContext.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintNinePieceImage):
6:18 PM Changeset in webkit [60648] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Add exceptions for some newly-passing tests in Chromium.

  • platform/chromium/test_expectations.txt:
5:45 PM Changeset in webkit [60647] by adachan@apple.com
  • 3 edits in trunk/WebKit2

Reviewed by Anders Carlsson.

Add UIProcess\API\cpp to the list of additional include directories.
Allow WKViewRef to work with WKRetainPtr on Windows.

  • UIProcess/API/cpp/WKRetainPtr.h:
  • win/WebKit2.vcproj:
5:34 PM Changeset in webkit [60646] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

Bug 40150 - ENABLE_JIT_OPTIMIZE_NATIVE_CALL on all x86/x86_64 platforms
This was fixed in bug #40094.

Reviewed by Mark Rowe.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/Platform.h:
4:46 PM Changeset in webkit [60645] by steveblock@google.com
  • 1 edit
    5 adds in trunk/LayoutTests

2010-06-03 Steve Block <​steveblock@google.com>

Reviewed by Alexey Proskuryakov.

Geolocation needs LayoutTest to test making callbacks to remote frames
​https://bugs.webkit.org/show_bug.cgi?id=40129

  • fast/dom/Geolocation/callback-to-remote-context-expected.txt: Added.
  • fast/dom/Geolocation/callback-to-remote-context.html: Added.
  • fast/dom/Geolocation/resources: Added.
  • fast/dom/Geolocation/resources/callback-to-remote-context-inner.html: Added.
  • fast/dom/Geolocation/script-tests/callback-to-remote-context.js: Added.
4:39 PM Changeset in webkit [60644] by jamesr@google.com
  • 1 edit
    18 adds in trunk/LayoutTests

2010-06-03 James Robinson <​jamesr@chromium.org>

Unreviewed. Add chromium-specific baselines for new tests added by 60640

  • platform/chromium-linux/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/layout-state-scrolloffset-expected.png: Added.
  • platform/chromium-mac/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
  • platform/chromium-mac/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset-expected.png: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset-expected.txt: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset2-expected.txt: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset3-expected.txt: Added.
4:19 PM Changeset in webkit [60643] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-06-03 John Gregg <​johnnyg@google.com>

Reviewed by David Levin.

notifications: in display+close layout test, don't close the notification
until the display event has been received asynchronously; also don't use
an invalid icon URL, since that should generate an error event.
​https://bugs.webkit.org/show_bug.cgi?id=39782

  • fast/notifications/notifications-display-close-events.html:
4:13 PM Changeset in webkit [60642] by kdecker@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Beth Dakin.

Pixel cracks in border images when drawing with a scale factor > 1
<rdar://problem/7994266>pixel cracks in border images
​https://bugs.webkit.org/show_bug.cgi?id=15720


  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawTiledImage):
  • platform/graphics/GraphicsContext.h: Added two new methods to support drawing using FloatRect. If the boolean flag roundToPixels is true, the pixels are adjusted with the pixel boundaries.
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintNinePieceImage):
3:49 PM Changeset in webkit [60641] by Martin Robinson
  • 3 edits in trunk/WebKit/gtk

2010-06-03 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r60632.
​http://trac.webkit.org/changeset/60632
​https://bugs.webkit.org/show_bug.cgi?id=40143

This change broke the 64-bit bots. (Requested by mrobinson on
#webkit).

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::DragClient): (WebKit::DragClient::startDrag):
  • WebCoreSupport/DragClientGtk.h:
3:07 PM Changeset in webkit [60640] by jamesr@google.com
  • 3 edits
    18 adds in trunk

2010-06-03 James Robinson <​jamesr@chromium.org>

Reviewed by Dan Bernstein.

Take container's scroll offset and clip into account when initializing LayoutState
​https://bugs.webkit.org/show_bug.cgi?id=38506

When doing a subtree layout, the initial LayoutState creation needs to
take the layout root container's offset and its scroll offset into account
to create the initial offset. Otherwise if a subtree layout occurs
for a layout root whose container has a non-zero scroll offset
the LayoutState's offset and clip are wrong, resulting in a mispaint.
See the test cases for examples.

Tests: fast/repaint/layout-state-scrolloffset.html

fast/repaint/layout-state-scrolloffset2.html
fast/repaint/layout-state-scrolloffset3.html

  • rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState):

2010-06-03 James Robinson <​jamesr@chromium.org>

Reviewed by Dan Bernstein.


Tests repainting a layout subtree with scroll offsets
​https://bugs.webkit.org/show_bug.cgi?id=38506


Has to be run as a pixel test to be useful.

  • layout-state-scrolloffset.html tests the layout root having a non-zero scroll offset.
  • layout-state-scrolloffset2.html tests the layout root and its container having

non-zero scroll offsets.

  • layout-state-scrolloffset3.html tests the layout root having non-zero a scroll offset

and clipping its descendants.

  • fast/repaint/layout-state-scrolloffset.html: Added.
  • fast/repaint/layout-state-scrolloffset2.html: Added.
  • fast/repaint/layout-state-scrolloffset3.html: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset-expected.png: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset-expected.txt: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset2-expected.txt: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset3-expected.txt: Added.
  • platform/mac-leopard/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/layout-state-scrolloffset-expected.png: Added.
  • platform/mac-leopard/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
  • platform/mac-leopard/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
2:45 PM Changeset in webkit [60639] by barraclough@apple.com
  • 3 edits in trunk/WebCore
  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::call):

Reviewed by NOBODY (speculative Qt build fix II).

2:36 PM Changeset in webkit [60638] by barraclough@apple.com
  • 2 edits in trunk/WebCore
  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::call):

Reviewed by NOBODY (speculative Qt build fix).

2:29 PM Changeset in webkit [60637] by barraclough@apple.com
  • 5 edits in trunk/JavaScriptCore

(JSC::Interpreter::privateExecute):

Reviewed by NOBODY (Interpreter build fix).

2:10 PM Changeset in webkit [60636] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (windows build fix II).

1:49 PM Changeset in webkit [60635] by ojan@chromium.org
  • 14 edits in trunk/WebKitTools

2010-05-14 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

add a RietveldUploadQueue to upload in-rietveld? patches to rietveld
​https://bugs.webkit.org/show_bug.cgi?id=38918

Patches with in-rietveld? get uploaded to rietveld and get marked
in-rietveld+. If the upload fails, they are marked in-rietveld-
and an error is logged to the bug, like the commit-queue.

Also, get rid of --fancy-review and the ability to upload to rietveld
using webkit-patch upload/post.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/options.py:
  • Scripts/webkitpy/tool/steps/postcodereview.py:
1:48 PM Changeset in webkit [60634] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (windows build fix).

1:20 PM Changeset in webkit [60633] by ojan@chromium.org
  • 3 edits in trunk/WebKitTools

2010-05-24 Ojan Vafai <​ojan@chromium.org>

Reviewed by Chris Jerdonek.

many webkit-patch commands fail in a non-svn tracking git checkout
​https://bugs.webkit.org/show_bug.cgi?id=38156

If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master).
If neither exists, then error out. This makes webkit-patch work
for anyone that follows the intructions at ​http://trac.webkit.org/wiki/UsingGitWithWebKit
to checkout webkit. The fallback to master is for people who don't
do the steps on that page for tracking svn.

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
1:08 PM Changeset in webkit [60632] by Martin Robinson
  • 3 edits in trunk/WebKit/gtk

2010-06-03 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Drag gesture can take mouse grab indefinitely
​https://bugs.webkit.org/show_bug.cgi?id=32840

Start GTK+ drags with the previous mouse button down event instead of
synthesizing the event. The synthesized event was not completely valid
and froze some drags indefinitely.

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::buttonPressEvent): Added. (WebKit::DragClient::DragClient): Connect to the 'button-press-event' signal of the WebView. (WebKit::DragClient::startDrag): Instead of synthesizing a button press event use the last real one.
  • WebCoreSupport/DragClientGtk.h: (WebKit::DragClient::setLastButtonPressEvent): Added.
1:00 PM Changeset in webkit [60631] by barraclough@apple.com
  • 71 edits in trunk

Bug 40094 - The return type of NativeFunction should be EncodedJSValue
On Windows & Linux, using JSVALUE32_64, EncodedJSValue is returned in registers, but JSValue is not.

Reviewed by Oliver Hunt.

JavaScriptCore:

  • API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::call):

  • API/JSCallbackFunction.h:
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::call):

(JSC::Interpreter::executeCall):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:
  • jsc.cpp:

(functionPrint):
(functionDebug):
(functionGC):
(functionVersion):
(functionRun):
(functionLoad):
(functionCheckSyntax):
(functionSetSamplingFlags):
(functionClearSamplingFlags):
(functionReadline):
(functionQuit):

  • runtime/ArrayConstructor.cpp:

(JSC::callArrayConstructor):
(JSC::arrayConstructorIsArray):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):

  • runtime/BooleanConstructor.cpp:

(JSC::callBooleanConstructor):

  • runtime/BooleanPrototype.cpp:

(JSC::booleanProtoFuncToString):
(JSC::booleanProtoFuncValueOf):

  • runtime/CallData.h:
  • runtime/DateConstructor.cpp:

(JSC::callDate):
(JSC::dateParse):
(JSC::dateNow):
(JSC::dateUTC):

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncToLocaleString):
(JSC::dateProtoFuncToLocaleDateString):
(JSC::dateProtoFuncToLocaleTimeString):
(JSC::dateProtoFuncGetTime):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetMilliSeconds):
(JSC::dateProtoFuncGetUTCMilliseconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::dateProtoFuncSetTime):
(JSC::dateProtoFuncSetMilliSeconds):
(JSC::dateProtoFuncSetUTCMilliseconds):
(JSC::dateProtoFuncSetSeconds):
(JSC::dateProtoFuncSetUTCSeconds):
(JSC::dateProtoFuncSetMinutes):
(JSC::dateProtoFuncSetUTCMinutes):
(JSC::dateProtoFuncSetHours):
(JSC::dateProtoFuncSetUTCHours):
(JSC::dateProtoFuncSetDate):
(JSC::dateProtoFuncSetUTCDate):
(JSC::dateProtoFuncSetMonth):
(JSC::dateProtoFuncSetUTCMonth):
(JSC::dateProtoFuncSetFullYear):
(JSC::dateProtoFuncSetUTCFullYear):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear):
(JSC::dateProtoFuncToJSON):

  • runtime/ErrorConstructor.cpp:

(JSC::callErrorConstructor):

  • runtime/ErrorPrototype.cpp:

(JSC::errorProtoFuncToString):

  • runtime/FunctionConstructor.cpp:

(JSC::callFunctionConstructor):

  • runtime/FunctionPrototype.cpp:

(JSC::callFunctionPrototype):
(JSC::functionProtoFuncToString):
(JSC::functionProtoFuncApply):
(JSC::functionProtoFuncCall):

  • runtime/JSCell.h:

(JSC::getCallData):
(JSC::getConstructData):

  • runtime/JSFunction.cpp:

(JSC::callHostFunctionAsConstructor):

  • runtime/JSFunction.h:
  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):
(JSC::globalFuncParseInt):
(JSC::globalFuncParseFloat):
(JSC::globalFuncIsNaN):
(JSC::globalFuncIsFinite):
(JSC::globalFuncDecodeURI):
(JSC::globalFuncDecodeURIComponent):
(JSC::globalFuncEncodeURI):
(JSC::globalFuncEncodeURIComponent):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape):
(JSC::globalFuncJSCPrint):

  • runtime/JSGlobalObjectFunctions.h:
  • runtime/JSONObject.cpp:

(JSC::JSONProtoFuncParse):
(JSC::JSONProtoFuncStringify):

  • runtime/JSObject.cpp:

(JSC::callDefaultValueFunction):

  • runtime/JSValue.h:
  • runtime/MathObject.cpp:

(JSC::mathProtoFuncAbs):
(JSC::mathProtoFuncACos):
(JSC::mathProtoFuncASin):
(JSC::mathProtoFuncATan):
(JSC::mathProtoFuncATan2):
(JSC::mathProtoFuncCeil):
(JSC::mathProtoFuncCos):
(JSC::mathProtoFuncExp):
(JSC::mathProtoFuncFloor):
(JSC::mathProtoFuncLog):
(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):
(JSC::mathProtoFuncPow):
(JSC::mathProtoFuncRandom):
(JSC::mathProtoFuncRound):
(JSC::mathProtoFuncSin):
(JSC::mathProtoFuncSqrt):
(JSC::mathProtoFuncTan):

  • runtime/NativeErrorConstructor.cpp:

(JSC::callNativeErrorConstructor):

  • runtime/NumberConstructor.cpp:

(JSC::callNumberConstructor):

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToString):
(JSC::numberProtoFuncToLocaleString):
(JSC::numberProtoFuncValueOf):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToPrecision):

  • runtime/ObjectConstructor.cpp:

(JSC::callObjectConstructor):
(JSC::objectConstructorGetPrototypeOf):
(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):
(JSC::toPropertyDescriptor):
(JSC::objectConstructorDefineProperty):
(JSC::objectConstructorDefineProperties):
(JSC::objectConstructorCreate):

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncValueOf):
(JSC::objectProtoFuncHasOwnProperty):
(JSC::objectProtoFuncIsPrototypeOf):
(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):
(JSC::objectProtoFuncPropertyIsEnumerable):
(JSC::objectProtoFuncToLocaleString):
(JSC::objectProtoFuncToString):

  • runtime/ObjectPrototype.h:
  • runtime/RegExpConstructor.cpp:

(JSC::callRegExpConstructor):

  • runtime/RegExpObject.cpp:

(JSC::callRegExpObject):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncTest):
(JSC::regExpProtoFuncExec):
(JSC::regExpProtoFuncCompile):
(JSC::regExpProtoFuncToString):

  • runtime/StringConstructor.cpp:

(JSC::stringFromCharCode):
(JSC::callStringConstructor):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncToString):
(JSC::stringProtoFuncCharAt):
(JSC::stringProtoFuncCharCodeAt):
(JSC::stringProtoFuncConcat):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncLastIndexOf):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
(JSC::stringProtoFuncSlice):
(JSC::stringProtoFuncSplit):
(JSC::stringProtoFuncSubstr):
(JSC::stringProtoFuncSubstring):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncLocaleCompare):
(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):
(JSC::stringProtoFuncLink):
(JSC::stringProtoFuncTrim):
(JSC::stringProtoFuncTrimLeft):
(JSC::stringProtoFuncTrimRight):

JavaScriptGlue:

  • JSObject.cpp:

(nativeCallFunction):

WebCore:

  • bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::callHTMLCollection):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::open):

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::InjectedScriptHost::createInjectedScript):

  • bindings/js/JSNodeFilterCondition.cpp:

(WebCore::JSNodeFilterCondition::acceptNode):

  • bindings/js/JSNodeListCustom.cpp:

(WebCore::callNodeList):

  • bindings/js/JSPluginElementFunctions.cpp:

(WebCore::callPlugin):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create):
(WebCore::ScheduledAction::executeFunctionInContext):

  • bindings/js/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::call):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializingTreeWalker::convertIfTerminal):

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject callWebScriptMethod:withArguments:]):

  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/NP_jsobject.cpp:

(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Construct):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::call):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::callObjCFallbackObject):

  • bridge/runtime_method.cpp:

(JSC::callRuntimeMethod):

  • bridge/runtime_object.cpp:

(JSC::Bindings::callRuntimeObject):

WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invoke):

11:59 AM HackingGtk edited by Martin Robinson
(diff)
11:56 AM HackingGtk edited by Martin Robinson
(diff)
11:38 AM HackingGtk edited by Martin Robinson
Update source module locations and put the directory first (diff)
10:34 AM Changeset in webkit [60630] by yael.aharon@nokia.com
  • 2 edits in trunk/WebKit/qt

[Qt] Don't send notifications event after the page was navigated away
​https://bugs.webkit.org/show_bug.cgi?id=40127

Reviewed by Laszlo Gombos.

Added a check before sending events to the notification and before logging.

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::sendEvent):

10:33 AM Changeset in webkit [60629] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch

Versioning.

10:30 AM Changeset in webkit [60628] by mrowe@apple.com
  • 1 copy in tags/Safari-533.16

New tag.

10:30 AM Changeset in webkit [60627] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59498.

9:42 AM Changeset in webkit [60626] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

fast/events/transformaction removed from expectations,
because these tests were rolled-out by r60624.

Rubber-stamped by Simon Hausmann.

  • platform/chromium/test_expectations.txt:
9:29 AM Changeset in webkit [60625] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

Unreviewed, rolling out r60617.
​http://trac.webkit.org/changeset/60617
​https://bugs.webkit.org/show_bug.cgi?id=40124

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2010-06-03
Followup patch for rolled-out r60614 (Requested by Ossy on
#webkit).

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
9:25 AM Changeset in webkit [60624] by Csaba Osztrogonác
  • 31 edits
    6 deletes in trunk

Unreviewed, rolling out r60614.
​http://trac.webkit.org/changeset/60614
​https://bugs.webkit.org/show_bug.cgi?id=40123

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2010-06-03
It made fast/dom/Window/window-postmessage-clone.html fail on
Mac bots (Requested by Ossy on #webkit).

WebCore:

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • bindings/js/JSEventCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::toV8):

  • dom/Document.cpp:

(WebCore::Document::createEvent):
(WebCore::Document::addListenerTypeIfNeeded):

  • dom/Document.h:

(WebCore::Document::):

  • dom/Document.idl:
  • dom/Element.h:
  • dom/Element.idl:
  • dom/Event.cpp:

(WebCore::Event::fromUserGesture):

  • dom/Event.h:
  • dom/EventNames.h:
  • dom/TransformActionEvent.cpp: Removed.
  • dom/TransformActionEvent.h: Removed.
  • dom/TransformActionEvent.idl: Removed.
  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

  • fast/events/transformaction/create-transformaction-event-expected.txt: Removed.
  • fast/events/transformaction/create-transformaction-event.html: Removed.
  • fast/events/transformaction/resources/create-transformaction-event.js: Removed.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
9:03 AM Changeset in webkit [60623] by yurys@chromium.org
  • 4 edits in trunk

2010-06-03 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: show "Object" as description for values with anonymous constructor
​https://bugs.webkit.org/show_bug.cgi?id=40121

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):

2010-06-03 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: show "Object" as description for values with anonymous constructor
​https://bugs.webkit.org/show_bug.cgi?id=40121

  • src/js/DevTools.js: don't call DebuggerAgent methods if ScriptDebugServer is used.
8:56 AM Changeset in webkit [60622] by Dimitri Glazkov
  • 2 edits in trunk/WebKit/chromium

[DRT/Chromium] Checking out lighttpd
​https://bugs.webkit.org/show_bug.cgi?id=39948

Patch by Kent Tamura <​tkent@chromium.org> on 2010-06-03
Reviewed by Dimitri Glazkov.

  • Add lighttpd only on Windows. It is used by new-run-webkit-tests.
  • Add libvpx.
  • Remove pthreads-win32 from DEPS. It has not been used since Chromium r28642.
  • Update Chromium revision to use Windows resource query code and webkit_glue dependency fix.
  • DEPS:
6:38 AM Changeset in webkit [60621] by vestbo@webkit.org
  • 4 edits
    1 move in trunk/WebCore

[Qt] Fix NPAPI support on Mac OS X/Cocoa-32

Reviewed by Simon Hausmann.

qt_mac_window_for() returns a NSWindow on Cocoa, so we were
passing in a NSWindow instead of a WindowRef as part of the
NP_CGContext.

​https://bugs.webkit.org/show_bug.cgi?id=38762

  • WebCore.gypi: Reflect rename
  • WebCore.pro: Reflect rename
  • plugins/mac/PluginViewMac.cpp: Renamed to PluginViewMac.mm

and fix bug by getting the Carbon windowRef from the NSWindow.

  • wscript: Reflect rename
6:02 AM Changeset in webkit [60620] by mike.fenton@torchmobile.com
  • 2 edits in trunk/WebKitTools

2010-06-03 Mike Fenton <​mifenton@rim.com>

Unreviewed.

Reverse e-mail for myself in committers.py to correspond with bugzilla account.

  • Scripts/webkitpy/common/config/committers.py:
4:11 AM Changeset in webkit [60619] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Test expectation update.

  • platform/chromium/test_expectations.txt: Restore Mac expectation of fixed-move-after-keyboard-scroll.html.
3:04 AM Changeset in webkit [60618] by pfeldman@chromium.org
  • 6 edits in trunk

2010-06-03 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: a number of fixes that make InspectorController
happy with null redirects.

​https://bugs.webkit.org/show_bug.cgi?id=40109

  • inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):

2010-06-03 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: a number of fixes that make InspectorController
happy with null redirects.

​https://bugs.webkit.org/show_bug.cgi?id=40109

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest):
  • DumpRenderTree/mac/DumpRenderTree.mm: (runTest):
  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest):
2:58 AM Changeset in webkit [60617] by Simon Hausmann
  • 5 edits in trunk/LayoutTests

Not reviewed: Add TransformActionEvent to the window object tests, after r60614.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
2:37 AM Changeset in webkit [60616] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed. Test expectation update.

Rebaseline fixed-move-after-keyboard-scroll for Chromium-Linux
​https://bugs.webkit.org/show_bug.cgi?id=40101

  • platform/chromium-linux/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum:
  • platform/chromium-linux/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
2:24 AM Changeset in webkit [60615] by tkent@chromium.org
  • 6 edits in trunk/LayoutTests

Unreviewed. Test expectation update.

Rebaseline fixed-move-after-keyboard-scroll, and add an entry for
fast/events/transformaction.
​https://bugs.webkit.org/show_bug.cgi?id=40101

  • platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum:
  • platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
  • platform/chromium-win/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum:
  • platform/chromium-win/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
  • platform/chromium/test_expectations.txt:
1:38 AM Changeset in webkit [60614] by Simon Hausmann
  • 31 edits
    8 adds in trunk

Add TransformActionEvent support
​https://bugs.webkit.org/show_bug.cgi?id=39757

Patch by Kim Grönholm <​kim.1.gronholm@nokia.com> on 2010-06-03
Reviewed by Simon Hausmann.

WebCore:

Added only the necessary TransformAction event interfaces and not e.g.
any eventhandler hooks that generate and dispatch them.

Test: fast/events/transformaction/create-transformaction-event.html
More tests will be added with the machinery that generates and
dispatches these events.

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::transformactionEnabled):
(WebCore::RuntimeEnabledFeatures::setTransformActionEnabled):
(WebCore::RuntimeEnabledFeatures::ontransformactionstartEnabled):
(WebCore::RuntimeEnabledFeatures::ontransformactionupdateEnabled):
(WebCore::RuntimeEnabledFeatures::ontransformactionendEnabled):

  • bindings/js/JSEventCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::toV8):

  • dom/Document.cpp:

(WebCore::Document::createEvent):
(WebCore::Document::addListenerTypeIfNeeded):

  • dom/Document.h:

(WebCore::Document::):

  • dom/Document.idl:
  • dom/Element.h:
  • dom/Element.idl:
  • dom/Event.cpp:

(WebCore::Event::isTransformActionEvent):
(WebCore::Event::fromUserGesture):

  • dom/Event.h:
  • dom/EventNames.h:
  • dom/TransformActionEvent.cpp: Added.

(WebCore::TransformActionEvent::TransformActionEvent):
(WebCore::TransformActionEvent::initTransformActionEvent):

  • dom/TransformActionEvent.h: Added.

(WebCore::TransformActionEvent::create):
(WebCore::TransformActionEvent::translateX):
(WebCore::TransformActionEvent::translateY):
(WebCore::TransformActionEvent::translateSpeedX):
(WebCore::TransformActionEvent::translateSpeedY):
(WebCore::TransformActionEvent::scale):
(WebCore::TransformActionEvent::scaleSpeed):
(WebCore::TransformActionEvent::rotate):
(WebCore::TransformActionEvent::rotateSpeed):
(WebCore::TransformActionEvent::TransformActionEvent):
(WebCore::TransformActionEvent::isTransformActionEvent):

  • dom/TransformActionEvent.idl: Added.
  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

  • fast/events/transformaction/create-transformaction-event-expected.txt: Added.
  • fast/events/transformaction/create-transformaction-event.html: Added.
  • fast/events/transformaction/resources/create-transformaction-event.js: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
1:21 AM Changeset in webkit [60613] by pfeldman@chromium.org
  • 19 edits in trunk/LayoutTests

2010-06-03 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: Rebaseline chromium tests as a follow up to r60611.

​https://bugs.webkit.org/show_bug.cgi?id=37364

  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-linux/fast/borders/svg-as-border-image-expected.checksum:
  • platform/chromium-linux/scrollbars/listbox-scrollbar-combinations-expected.checksum:
  • platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.checksum:
  • platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.checksum:
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.png:
  • platform/chromium-win/scrollbars/listbox-scrollbar-combinations-expected.checksum:
  • platform/chromium-win/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.checksum:
  • platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
12:52 AM Changeset in webkit [60612] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, test expectation update.

4 websocket tests don't fail now.

  • platform/chromium/test_expectations.txt:
  • remove websocket/tests/unicode.html, websocket/tests/send.html, websocket/tests/handshake-error.html and websocket/tests/long-invalid-header.html
12:22 AM Changeset in webkit [60611] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-06-03 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Rolling out aggressive cache part of the r60391
described in the bug below. It was orthogonal to the rest of
the patch and caused regression.

​https://bugs.webkit.org/show_bug.cgi?id=37364

  • platform/graphics/skia/ImageSkia.cpp: (WebCore::drawResampledBitmap):
12:07 AM Changeset in webkit [60610] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-02 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] refactor WebKit.gyp's DRT section so the conditions are less messy
​https://bugs.webkit.org/show_bug.cgi?id=40104

  • WebKit.gyp:
12:03 AM Changeset in webkit [60609] by eric@webkit.org
  • 6 edits in trunk

2010-06-02 Tasuku Suzuki <​tasuku.suzuki@nokia.com>

Reviewed by Shinichiro Hamaji.

[Qt] Fix compilation with QT_NO_PROPERTIES
​https://bugs.webkit.org/show_bug.cgi?id=38324

  • Api/qwebpage.cpp: (QWebPage::event):
  • Api/qwebpage_p.h:
  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend):

2010-06-02 Tasuku Suzuki <​tasuku.suzuki@nokia.com>

Reviewed by Shinichiro Hamaji.

[Qt] Fix compilation with QT_NO_PROPERTIES
​https://bugs.webkit.org/show_bug.cgi?id=38324

  • QtTestBrowser/main.cpp: (LauncherWindow::init):
Note: See TracTimeline for information about the timeline view.