Timeline



Jul 5, 2010:

11:48 PM Changeset in webkit [62529] by hamaji@chromium.org
  • 11 edits in trunk/WebCore

2010-07-05 Yuta Kitamura <yutak@chromium.org>

Reviewed by Pavel Feldman.

Add WebSocket resource type to Web Inspector.

When a new WebSocket connection is established, a line for that connection
will appear in Web Inspector's Resources tab. If the resource name is
clicked, the details of handshake request and response will be shown.

Web Inspector: WebSocket in Resources tab
https://bugs.webkit.org/show_bug.cgi?id=40768

  • inspector/InspectorController.cpp: (WebCore::InspectorController::addResource): WebSocket resource does not have an associated loader, thus frame might be null. Need to check it. (WebCore::InspectorController::removeResource): Ditto. (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: Add null checks of m_loader and m_frame, because WebSocket does not have a loader and we need to allow null for these variables. (WebCore::createReadableStringFromBinary): (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::create): Factory function of regular (non-WebSocket) resources. (WebCore::InspectorResource::createWebSocket): Factory function of WebSocket resources. (WebCore::InspectorResource::updateWebSocketRequest): (WebCore::InspectorResource::updateWebSocketResponse): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::cachedResource): (WebCore::InspectorResource::type): (WebCore::InspectorResource::resourceData):
  • inspector/InspectorResource.h: (WebCore::InspectorResource::): (WebCore::InspectorResource::markWebSocket):
  • inspector/front-end/Resource.js: (WebInspector.Resource.Type.toString): (WebInspector.Resource.prototype.set type): (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshRequestHeaders): (WebInspector.ResourceView.prototype._refreshResponseHeaders): (WebInspector.ResourceView.prototype._refreshHeaders):
  • inspector/front-end/inspector.css: (.resources-category-websockets, .resources-category-other): (.resources-category-websockets .resources-graph-bar): (.resources-category-websockets.resource-cached .resources-graph-bar):
  • inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.updateResource):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::processBuffer): (WebCore::WebSocketChannel::identifier):
  • websockets/WebSocketChannel.h:
11:43 PM Changeset in webkit [62528] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-07-05 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix Chromium build.

  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::fillResourceList): (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
11:29 PM Changeset in webkit [62527] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-07-05 Adam Barth <abarth@webkit.org>

Unreviewed.

Move processStartTagForInBody to its own function.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTag):
  • html/HTMLTreeBuilder.cpp.orig: Added.
  • html/HTMLTreeBuilder.h:
11:29 PM Changeset in webkit [62526] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

2010-07-05 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Eric Seidel.

REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup temporary directory
https://bugs.webkit.org/show_bug.cgi?id=41612

  • Scripts/ensure-valid-python: File::Temp::tempdir call fixed.
11:14 PM Changeset in webkit [62525] by eric@webkit.org
  • 4 edits in trunk

2010-07-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fix one more notImplemented in h1-h6 start tag handling
https://bugs.webkit.org/show_bug.cgi?id=41654

  • html5lib/runner-expected-html5.txt:
    • Fix two sub-tests!

2010-07-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fix one more notImplemented in h1-h6 start tag handling
https://bugs.webkit.org/show_bug.cgi?id=41654

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
11:05 PM Changeset in webkit [62524] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-07-05 Eric Seidel <eric@webkit.org>

Unreviewed. Just fixing proess to process.
Clearly Adam and I can't spell. Thankfully MikeSmith can.

Add <isindex> support, per HTML5
https://bugs.webkit.org/show_bug.cgi?id=41650

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processFakeStartTag): (WebCore::HTMLTreeBuilder::processFakeEndTag): (WebCore::HTMLTreeBuilder::processIsindexStartTagForBody): (WebCore::HTMLTreeBuilder::processStartTag):
  • html/HTMLTreeBuilder.h:
11:01 PM Changeset in webkit [62523] by eric@webkit.org
  • 9 edits
    1 add in trunk

2010-07-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add <isindex> support, per HTML5
https://bugs.webkit.org/show_bug.cgi?id=41650

  • html5lib/resources/tests2.dat:
    • Make the expected wording match the HTML5 spec. Not sure why the wording in this test diverged.
  • html5lib/resources/isindex.dat:
    • Cover more isindex cases.
  • html5lib/runner.html:

2010-07-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add <isindex> support, per HTML5
https://bugs.webkit.org/show_bug.cgi?id=41650

Covered by html5lib/runner.html including a new
isindex.dat test suite.

  • html/HTMLToken.h: (WebCore::AtomicHTMLToken::AtomicHTMLToken):
    • Support passing attributes to the constructor.

(WebCore::AtomicHTMLToken::name):
(WebCore::AtomicHTMLToken::setName):
(WebCore::AtomicHTMLToken::getAttributeItem):
(WebCore::AtomicHTMLToken::attributes):
(WebCore::AtomicHTMLToken::takeAtributes):

  • Reduces ref-churn, and makes it possible for callers to modify attributes w/o affecting future uses of the attributes.

(WebCore::AtomicHTMLToken::usesName):

  • Used by ASSERTS.

(WebCore::AtomicHTMLToken::usesAttributes):

  • Used by ASSERTS.
  • html/HTMLTreeBuilder.cpp: (WebCore::convertToOldStyle):
    • Can't be const, now that we use takeAttributes()

(WebCore::HTMLTreeBuilder::insertHTMLStartTagBeforeHTML):
(WebCore::HTMLTreeBuilder::proesssFakeStartTag):

  • New function. I'm not sure this is the perfect design (I'd kinda like AtomicHTMLToken to be copyable so we can have create functions for it), but this makes the callsites using fake tokens much more readable.

(WebCore::HTMLTreeBuilder::proesssFakeEndTag):
(WebCore::HTMLTreeBuilder::processFakeCharacters):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
(WebCore::HTMLTreeBuilder::processIsindexStartTagForBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::insertScriptElement):

  • Use takeAttributes() for less ref-churn.

(WebCore::HTMLTreeBuilder::createElement): ditto
(WebCore::HTMLTreeBuilder::finished):

  • Remove bogus use of AtomicHTMLToken constructor which wasn't even being used now that we support emitting EOF tokens from the Tokenizer directly.
  • html/HTMLTreeBuilder.h:
10:38 PM Changeset in webkit [62522] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-07-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

ASSERT that we're processing the correct type of token
https://bugs.webkit.org/show_bug.cgi?id=41647

Making these asserts work required a small (non-observable) tweak to
some old code.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processDoctypeToken): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processBodyEndTagForInBody): (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processComment): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile): (WebCore::HTMLTreeBuilder::processStartTagForInHead):
10:31 PM Changeset in webkit [62521] by abarth@webkit.org
  • 6 edits in trunk

2010-07-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement in select in table
https://bugs.webkit.org/show_bug.cgi?id=41646

Add some tests for this mode. We fail all these tests currently
because there's no way to get into this mode. :(

  • html5lib/resources/tables01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:

2010-07-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement in select in table
https://bugs.webkit.org/show_bug.cgi?id=41646

This mode is mostly a fall-through to the InSelectMode.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
10:14 PM Changeset in webkit [62520] by abarth@webkit.org
  • 9 edits in trunk

2010-07-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement basic text node coalescing
https://bugs.webkit.org/show_bug.cgi?id=41623

  • html5lib/resources/webkit01.dat:
    • This test had incorrect expected results according to the spec and to Minefield.
  • html5lib/runner-expected-html5.txt:
    • Update expected results to show test progression. In some cases, we continue to fail tests, but in new (also wrong) ways. I think that's ok though.
  • html5lib/runner-expected.txt:
    • Update expected results w.r.t. new webkit01.dat baseline.
  • html5lib/webkit-resumer-expected.txt:
    • Update expected results w.r.t. new webkit01.dat baseline.

2010-07-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement basic text node coalescing
https://bugs.webkit.org/show_bug.cgi?id=41623

This patch isn't the end-all, be-all of text node coalescing, but it's
a good start.

  • dom/CharacterData.cpp: (WebCore::CharacterData::parserAppendData): (WebCore::CharacterData::appendData):
  • dom/CharacterData.h:
    • Added a new method to dance around mutation events.
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::insertTextNode):
9:58 PM Changeset in webkit [62519] by abarth@webkit.org
  • 4 edits in trunk

2010-07-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement InSelectMode
https://bugs.webkit.org/show_bug.cgi?id=41627

Massive test progression.

  • html5lib/runner-expected-html5.txt:

2010-07-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement InSelectMode
https://bugs.webkit.org/show_bug.cgi?id=41627

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
9:57 PM Changeset in webkit [62518] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-07-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

We should be able to specify a bug to block for webkit-patch upload
https://bugs.webkit.org/show_bug.cgi?id=41648

This will be useful for working on the HTML5 parser.

  • Scripts/webkitpy/tool/steps/createbug.py:
  • Scripts/webkitpy/tool/steps/options.py:
9:21 PM Changeset in webkit [62517] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-07-05 Yuzo Fujishima <yuzo@google.com>

Unreviewed test expectation update.

Fix: On Leopard run-webkit-tests complains: Skipped list contained
'compositing/iframes/composited-iframe.html', but no file of that name
could be found

  • platform/mac-leopard/Skipped: Removed the above test.
8:34 PM Changeset in webkit [62516] by abarth@webkit.org
  • 5 edits in trunk/LayoutTests

2010-07-05 Adam Barth <abarth@webkit.org>

Unreviewed.

We were discussing this test case, so I figured I might as well add it
to the suite.

  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/webkit-resumer-expected.txt:
8:11 PM Changeset in webkit [62515] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit

2010-07-05 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Implement downloadURL in ContextMenuClientEfl
When user selects a download menu from context menu, send the download
request to application.
https://bugs.webkit.org/show_bug.cgi?id=41149

  • efl/WebCoreSupport/ContextMenuClientEfl.cpp: (WebCore::ContextMenuClientEfl::downloadURL): Get url for downloading file and Send it to application.
  • efl/WebCoreSupport/ContextMenuClientEfl.h:
7:03 PM Changeset in webkit [62514] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-07-05 Fady Samuel <fsamuel@chromium.org>

Reviewed by Darin Adler.

Fixed a svg crash when setting class of an svg ellipse object.

Altering the CSS class of an attached SVG element causes WebKit to crash
https://bugs.webkit.org/show_bug.cgi?id=40857

  • platform/chromium-linux/svg/css/svg-ellipse-render-crash-expected.txt: Added.
  • svg/css/svg-ellipse-render-crash.html: Added.

2010-07-05 Fady Samuel <fsamuel@chromium.org>

Reviewed by Darin Adler.

Fixed a svg crash when setting class of an svg ellipse object.

Altering the CSS class of an attached SVG element causes WebKit to crash
https://bugs.webkit.org/show_bug.cgi?id=40857

Test: svg/css/svg-ellipse-render-crash.html

  • dom/StyledElement.cpp: (WebCore::StyledElement::classAttributeChanged):
6:06 PM Changeset in webkit [62513] by mitz@apple.com
  • 4 edits
    2 adds in trunk

Reproducible crash with Optimize Legibility extension
https://bugs.webkit.org/show_bug.cgi?id=41585

Reviewed by Sam Weinig.

WebCore:

Test: fast/css/text-rendering-priority.html

Moved the text-rendering CSS property to the “high priority” group, because applying it
during style selection invalidates the font.

  • css/CSSPropertyNames.in: Moved text-rendering to the “high priority” section at the top.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclarations): Updated compile-time assertion.

LayoutTests:

  • fast/css/text-rendering-priority-expected.txt: Added.
  • fast/css/text-rendering-priority.html: Added.
5:53 PM Changeset in webkit [62512] by alice.liu@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Crash reading past end of block in UniscribeController::shapeAndPlaceItem
https://bugs.webkit.org/show_bug.cgi?id=41554

Reviewed by Dan Bernstein.

  • platform/win/fast/text/uniscribe-item-boundary-crash-expected.txt: Added.
  • platform/win/fast/text/uniscribe-item-boundary-crash.html: Added.
5:51 PM Applications using WebKit edited by onny_silvester@yahoo.com
(diff)
5:22 PM Changeset in webkit [62511] by barraclough@apple.com
  • 7 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=41641

Reviewed by Sam Weinig.

Update compile flags to allow use of ExecutableAllocatorFixedVMPool on platforms
other than x86-64 (this may be useful on 32-bit platforms, too).

Simplify ifdefs by dividing into thwo broad allocation strategies
(ENABLE_EXECUTABLE_ALLOCATOR_FIXED & ENABLE_EXECUTABLE_ALLOCATOR_DEMAND).

Rename constant used in the code to have names descriptive of their purpose,
rather than their specific value on a given platform.

  • jit/ExecutableAllocator.cpp:

(JSC::ExecutableAllocator::reprotectRegion):
(JSC::ExecutableAllocator::cacheFlush):

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::free):
(JSC::ExecutablePool::systemAlloc):

  • jit/ExecutableAllocatorPosix.cpp:
  • jit/ExecutableAllocatorSymbian.cpp:
  • jit/ExecutableAllocatorWin.cpp:
  • wtf/Platform.h:
5:11 PM Changeset in webkit [62510] by mitz@apple.com
  • 2 edits in trunk/WebCore

optimizeLegibility doesn't play nice with fonts that do not have a space glyph
https://bugs.webkit.org/show_bug.cgi?id=41599

Reviewed by Sam Weinig.

No test because none of the fonts available to DumpRenderTree are missing a space glyph.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::findNextLineBreak): When the font does not map the space character
to a glyph, a fallback font is used for space. Therefore, wordTrailingSpaceWidth must be
initialized with the width of a space as measured by the Font rather than with the cached
space width.

2:39 PM Changeset in webkit [62509] by abarth@webkit.org
  • 5 edits in trunk

2010-07-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Implement HTML5's "reset insertion mode appropriately"
https://bugs.webkit.org/show_bug.cgi?id=41628

This has some minimal testing. One from my previous
</table> patch, and a few from the main suite.

Mostly resetInsertionModeAppropriately isn't used yet
but we're about to add a bunch of states which do use it
and our test coverage will expand further as we do.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::setInsertionModeAndEnd): (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
  • html/HTMLTreeBuilder.h:

2010-07-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Implement HTML5's "reset insertion mode appropriately"
https://bugs.webkit.org/show_bug.cgi?id=41628

Fixes a bunch of subtests!

  • html5lib/runner-expected-html5.txt:
2:34 PM Changeset in webkit [62508] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-07-05 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed build fix for r62503.

Chromium missing method. Filed bug 41632 to track.

  • loader/appcache/ApplicationCacheHost.h: (WebCore::ApplicationCacheHost::applicationCache):
2:25 PM Changeset in webkit [62507] by abarth@webkit.org
  • 7 edits in trunk

2010-07-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add </table> support for "in table" insertion mode
https://bugs.webkit.org/show_bug.cgi?id=41591

resetInsertionModeAppropriately isn't implemented yet, however
I've added a test for the usage I added.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately): (WebCore::HTMLTreeBuilder::processEndTag):
  • html/HTMLTreeBuilder.h:

2010-07-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add </table> support for "in table" insertion mode
https://bugs.webkit.org/show_bug.cgi?id=41591

Add tests for </table> in "in table" mode, and
one for ignored close tags.

  • html5lib/resources/tables01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
2:08 PM Changeset in webkit [62506] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-07-05 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed build fix for r62503.

Missed GTK's build file.

  • GNUmakefile.am:
2:00 PM Changeset in webkit [62505] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-07-05 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed build fix for r62503.

Pass a blank ResourceResponse instead of passing 0.

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::createResourceHandle):
1:47 PM Changeset in webkit [62504] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-07-05 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed build fix for r62503.

Forward declare ApplicationCache for Chromium.

  • loader/appcache/ApplicationCacheHost.h:
1:32 PM Changeset in webkit [62503] by Joseph Pecoraro
  • 16 edits in trunk/WebCore

2010-07-05 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

WebInspector: HTML5 Offline Web Applications Support (ApplicationCache)
https://bugs.webkit.org/show_bug.cgi?id=24529

Parts of this patch were written by Kavita Kanetkar <kkanetkar@chromium.org>.

Part 2: Pulling ApplicationCache Resources to Display in the Inspector.

The InspectorApplicationCacheAgent gathers the information it
needs and forwards it on to the inspector.

  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::fillResourceList): get information about the resources. (WebCore::InspectorApplicationCacheAgent::getApplicationCaches): gathers all the information from the ApplicationCacheHost. (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache): (WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources): (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):
  • inspector/InspectorApplicationCacheAgent.h: defines structures to hold information about caches and resources. (WebCore::InspectorApplicationCacheAgent::ApplicationCacheInfo::ApplicationCacheInfo): (WebCore::InspectorApplicationCacheAgent::ResourceInfo::ResourceInfo): (WebCore::InspectorApplicationCacheAgent::~InspectorApplicationCacheAgent):
  • loader/appcache/ApplicationCacheHost.h: (WebCore::ApplicationCacheHost::applicationCacheForInspector): new convention, public cache accessor for the inspector. (WebCore::ApplicationCacheHost::documentLoader): added const.

The User Interface uses a DataGrid, like Cookies.

  • inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView.prototype._update): (WebInspector.ApplicationCacheItemsView.prototype._updateCallback): (WebInspector.ApplicationCacheItemsView.prototype._createDataGrid): (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid.numberCompare): (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid.localeCompare): (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):

The usual frontend pull workflow, except this goes through
InspectorApplicationCacheAgent instead of InspectorController.

  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getApplicationCaches): (WebCore::InspectorBackend::inspectorApplicationCacheAgent):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetApplicationCaches):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype.hasChildNodes): style fix. (WebInspector.DOMAgent.prototype.nodeForId): style fix. (WebInspector.ApplicationCache.getApplicationCachesAsync): pull. (WebInspector.Cookies.getCookiesAsync):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.updateManifest): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.onselect):
  • inspector/front-end/inspector.js: (WebInspector.updateResource): (WebInspector._addAppCacheDomain): (WebInspector.reset):

Miscellaneous. Localized Strings and fixes.

  • English.lproj/localizedStrings.js: "Type", "%s (%s)"
  • inspector/InspectorController.cpp: (WebCore::InspectorController::deleteCookie):
  • inspector/InspectorController.h:
1:32 PM Changeset in webkit [62502] by Joseph Pecoraro
  • 19 edits
    4 adds in trunk/WebCore

2010-07-04 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

WebInspector: HTML5 Offline Web Applications Support (ApplicationCache)
https://bugs.webkit.org/show_bug.cgi?id=24529

Part 1: Backend -> Frontend Messages. ApplicationCache Status and Connectivity Status.

This patch adds an InspectorApplicationCacheAgent to monitor application
cache changes, starts a UI in the Storage panel, handles the boilerplate
of adding new files.

Added an agent to encapsulate and handle the application cache logic.
This is similar to the timeline agent.

  • inspector/InspectorApplicationCacheAgent.cpp: Added. (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent): (WebCore::InspectorApplicationCacheAgent::~InspectorApplicationCacheAgent): (WebCore::InspectorApplicationCacheAgent::didReceiveManifestResponse): (WebCore::InspectorApplicationCacheAgent::updateApplicationCacheStatus): (WebCore::InspectorApplicationCacheAgent::updateNetworkState):
  • inspector/InspectorApplicationCacheAgent.h: Added.

InspectorController owns an InspectorApplicationCacheAgent. This
handles its lifetime management.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): create the agent with a frontend. (WebCore::InspectorController::disconnectFrontend): remove the agent when closing. (WebCore::InspectorController::releaseFrontendLifetimeAgents):
  • inspector/InspectorController.h:

User Interface for ApplicationCache in the StoragePanel. This follows
very closely to Cookies, it will have a sortable table of items. The
status bar contains connectivity and application cache status
indicators which update when backend messages are received. There
are some stubs which the next part will implement.

  • inspector/front-end/ApplicationCacheItemsView.js: Added. (WebInspector.ApplicationCacheItemsView): (WebInspector.ApplicationCacheItemsView.prototype.get statusBarItems): refresh, delete, connectivity, application cache status. (WebInspector.ApplicationCacheItemsView.prototype.show): (WebInspector.ApplicationCacheItemsView.prototype.hide): (WebInspector.ApplicationCacheItemsView.prototype.updateStatus): this is the application cache status indicator. (WebInspector.ApplicationCacheItemsView.prototype.updateNetworkState): this is the online/offline connectivity indicator. (WebInspector.ApplicationCacheItemsView.prototype._update): (WebInspector.ApplicationCacheItemsView.prototype._updateCallback): (WebInspector.ApplicationCacheItemsView.prototype._createDataGrid): (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid): (WebInspector.ApplicationCacheItemsView.prototype.resize): (WebInspector.ApplicationCacheItemsView.prototype._deleteButtonClicked): (WebInspector.ApplicationCacheItemsView.prototype._deleteCallback): (WebInspector.ApplicationCacheItemsView.prototype._refreshButtonClicked):

The usual dispatch flow from the backend, to the frontend, to the
panel, and then to the visible view. Some slight refactoring to
eliminate duplicated code.

  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::updateDOMStorage): (WebCore::InspectorFrontend::didGetApplicationCaches): (WebCore::InspectorFrontend::updateApplicationCacheStatus):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addApplicationCache): (WebInspector.StoragePanel.prototype.showDatabase): (WebInspector.StoragePanel.prototype.showDOMStorage): (WebInspector.StoragePanel.prototype.showCookies): (WebInspector.StoragePanel.prototype.showApplicationCache): (WebInspector.StoragePanel.prototype._genericViewSetup): (WebInspector.StoragePanel.prototype.updateApplicationCacheStatus): (WebInspector.StoragePanel.prototype.updateNetworkState): (WebInspector.CookieSidebarTreeElement.prototype.set subtitle): (WebInspector.ApplicationCacheSidebarTreeElement): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.onselect): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.get mainTitle): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.set mainTitle): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.get subtitle): (WebInspector.ApplicationCacheSidebarTreeElement.prototype.set subtitle):
  • inspector/front-end/inspector.js: (WebInspector.dispatch.delayDispatch): (WebInspector.dispatch): (WebInspector._addAppCacheDomain): (WebInspector.addDOMStorage): (WebInspector.updateDOMStorage):

Notify the InspectorApplicationCacheAgent on application cache changes
or specifics. Notify the InspectorController on generic resource events.
That is because ApplicationCacheController is a ResourceClient and needs
to trigger the resource events normally handled by ResourceLoader.

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::inspectorUpdateApplicationCacheStatus): helper method to prevent duplicated code. (WebCore::ApplicationCacheGroup::setNewestCache): status change. (WebCore::ApplicationCacheGroup::makeObsolete): status change. (WebCore::ApplicationCacheGroup::update): status change. (WebCore::ApplicationCacheGroup::createResourceHandle): resource event. (WebCore::ApplicationCacheGroup::willSendRequest): resource event. (WebCore::ApplicationCacheGroup::didReceiveResponse): resource event. (WebCore::ApplicationCacheGroup::didReceiveData): resource event. (WebCore::ApplicationCacheGroup::didFinishLoading): resource event. (WebCore::ApplicationCacheGroup::didFail): resource event. (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): resource event. (WebCore::ApplicationCacheGroup::manifestNotFound): status change. (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): status change. (WebCore::ApplicationCacheGroup::setUpdateStatus): single access point for status changes.
  • loader/appcache/ApplicationCacheGroup.h:
  • page/Page.cpp: (WebCore::networkStateChanged): connectivity status change.

Final inspector details to add the new file, style new elements,
images, and localized strings.

  • inspector/front-end/inspector.css: (.application-cache-sidebar-tree-item .icon): (.timeline-records-counter, .storage-application-cache-status, .storage-application-cache-connectivity): (.storage-application-cache-status-icon, .storage-application-cache-connectivity-icon): (.status-bar-divider): (.storage-application-cache-status, .storage-application-cache-connectivity):
  • inspector/front-end/inspector.html:
  • inspector/front-end/Images/applicationCache.png: Added.
  • English.lproj/localizedStrings.js: "APPLICATION CACHE", "No Application Cache information available.", "Online", "Offline"

Updated build files.

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/front-end/WebKit.qrc:
1:17 PM Changeset in webkit [62501] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit2

2010-07-05 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] WebKit2 triple click
https://bugs.webkit.org/show_bug.cgi?id=41629

QtWebkit2 triple click implementation.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::mousePressEvent): (QWKPagePrivate::mouseDoubleClickEvent): (QWKPage::timerEvent):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:
1:03 PM Changeset in webkit [62500] by abarth@webkit.org
  • 6 edits in trunk

2010-07-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add basic <col> support to the treebuilder
https://bugs.webkit.org/show_bug.cgi?id=41590

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):

2010-07-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add basic <col> support to the treebuilder
https://bugs.webkit.org/show_bug.cgi?id=41590

Test the new <col> support. Turns out the old treebuilder doesn't
handle <table><col> correctly.

  • html5lib/resources/tables01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
1:02 PM Changeset in webkit [62499] by abarth@webkit.org
  • 8 edits
    1 add in trunk

2010-07-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add basic "in row" mode to support <td> and <th> insertion
https://bugs.webkit.org/show_bug.cgi?id=41588

Also fixed <td> or <th> as a direct child of <table>.

Most of this was covered by html5lib/runner.html tests,
but I had to add a new tables01.dat to cover the <th> cases.

  • html/HTMLElementStack.cpp: (WebCore::HTMLNames::isTableRowScopeMarker): (WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
  • html/HTMLElementStack.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):

2010-07-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add basic "in row" mode to support <td> insertion
https://bugs.webkit.org/show_bug.cgi?id=41588

Added tables01.dat to test a previously untested
<table><th> case. I expect we'll add many more table
tests there as we complete our implementation.

  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:
  • html5lib/resources/tables01.dat: Added.
12:42 PM Changeset in webkit [62498] by eric@webkit.org
  • 7 edits
    1 add in trunk

2010-07-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Finish implementing "any other end tag" for "in body" mode
https://bugs.webkit.org/show_bug.cgi?id=41582

  • html5lib/resources/inbody01.dat: Added.
  • html5lib/runner-expected-html5.txt:
    • Update the one result which was affected by this. That test would pass if we had text node coalescing.
  • html5lib/runner-expected.txt:
    • Update to add the extra test suite.
  • html5lib/runner.html:

2010-07-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Finish implementing "any other end tag" for "in body" mode
https://bugs.webkit.org/show_bug.cgi?id=41582

I believe I found a "bug" in the HTML5 spec when writing this:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=10080

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): (WebCore::HTMLTreeBuilder::processEndTag):
  • html/HTMLTreeBuilder.h:
11:32 AM Changeset in webkit [62497] by mrobinson@webkit.org
  • 2 edits in trunk/WebCore

2010-07-05 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Add a missing slash to the list of generated sources. This
was missing from a previous build fix.

  • GNUmakefile.am:
11:04 AM Changeset in webkit [62496] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2010-07-05 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: preserve scroll positions in source frame when switching between panes.

https://bugs.webkit.org/show_bug.cgi?id=41620

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.hide):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.set visible):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.hide):
10:57 AM Changeset in webkit [62495] by yurys@chromium.org
  • 1 edit
    17 adds in trunk/LayoutTests

2010-07-05 Yury Semikhatsky <yury@yurys-imac.local>

Unreviewed. Provide Chromium specific expectations for new svg tests.

  • platform/chromium-linux/svg/custom/clone-element-with-animated-svg-properties-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/relative-sized-inner-svg-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum: Added.
  • platform/chromium-linux/svg/filters/filter-width-update-expected.checksum: Added.
  • platform/chromium-mac/svg/filters/filter-width-update-expected.checksum: Added.
  • platform/chromium-win/svg/custom/clone-element-with-animated-svg-properties-expected.checksum: Added.
  • platform/chromium-win/svg/custom/clone-element-with-animated-svg-properties-expected.png: Added.
  • platform/chromium-win/svg/custom/clone-element-with-animated-svg-properties-expected.txt: Added.
  • platform/chromium-win/svg/custom/relative-sized-inner-svg-expected.checksum: Added.
  • platform/chromium-win/svg/custom/relative-sized-inner-svg-expected.png: Added.
  • platform/chromium-win/svg/custom/relative-sized-inner-svg-expected.txt: Added.
  • platform/chromium-win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum: Added.
  • platform/chromium-win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png: Added.
  • platform/chromium-win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt: Added.
  • platform/chromium-win/svg/filters/filter-width-update-expected.checksum: Added.
  • platform/chromium-win/svg/filters/filter-width-update-expected.png: Added.
  • platform/chromium-win/svg/filters/filter-width-update-expected.txt: Added.
10:50 AM Changeset in webkit [62494] by commit-queue@webkit.org
  • 2 edits
    2 copies
    2 adds in trunk/WebKit2

2010-07-05 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Antti Koivisto.

[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Add stubs

  • UIProcess/Plugins/qt/PluginInfoStoreQt.cpp: Copied from WebKit2/UIProcess/Plugins/win/PluginInfoStoreWin.cpp. (WebKit::PluginInfoStore::pluginDirectories): (WebKit::PluginInfoStore::pluginPathsInDirectory): (WebKit::PluginInfoStore::getPluginInfo): (WebKit::PluginInfoStore::shouldUsePlugin):
  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp: Added. (WebKit::InjectedBundle::load):
10:10 AM Changeset in webkit [62493] by steveblock@google.com
  • 2 edits in trunk/JavaScriptCore

2010-07-05 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

ThreadingPthreads.cpp should use JNIUtility.h on Android, not outdated jni_utility.h
https://bugs.webkit.org/show_bug.cgi?id=41594

  • wtf/ThreadingPthreads.cpp:
10:01 AM Changeset in webkit [62492] by rwlbuis@webkit.org
  • 7 edits
    3 adds in trunk

2010-07-05 Rob Buis <rwlbuis@gmail.com>

Reviewed by Dirk Schulze.

IE SVG test fails
https://bugs.webkit.org/show_bug.cgi?id=41619

Make SVGSVGElement.createSVGTransform create a SVGTransform with the
right type, thereby fixing the IE test.

Test: svg/custom/svg-createsvgtransform-type.html

  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::createSVGTransform):
9:54 AM Changeset in webkit [62491] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/WebKit2

2010-07-05 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Antti Koivisto.

[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Add WebErrorsQt

  • WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: Added. (WebKit::): (WebKit::cancelledError): (WebKit::blockedError): (WebKit::cannotShowURLError): (WebKit::interruptForPolicyChangeError): (WebKit::cannotShowMIMETypeError): (WebKit::fileDoesNotExistError):
8:29 AM Changeset in webkit [62490] by mrobinson@webkit.org
  • 3 edits in trunk/WebKitTools

2010-07-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Oliver Hunt.

The style checker exempts gtk2drawing.h when it should exempt gtkdrawing.h
https://bugs.webkit.org/show_bug.cgi?id=41017

  • Scripts/webkitpy/style/checker.py: Exempt gtkdrawing.h instead of gtk2drawing.h
  • Scripts/webkitpy/style/checker_unittest.py: Update the unit test to reflect the change.
8:12 AM Changeset in webkit [62489] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-07-05 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: computed style pane is not updated when styles pane is collapsed.

https://bugs.webkit.org/show_bug.cgi?id=41615

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateStyles):
7:32 AM Changeset in webkit [62488] by Nikolas Zimmermann
  • 44 edits
    12 adds in trunk

2010-07-05 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Logic to track whether elements are using relative lengths is incomplete
https://bugs.webkit.org/show_bug.cgi?id=41566

Add logic to all SVG elements which create renderes to expose a method
"bool selfHasRelativeLengths()", that returns whether the element uses relative
lengths (eg. <rect x="50%"...). This will be used soon to avoid relayouts of
container children, when the bounds have not changed.

A new method SVGStyledElement::updateRelativeLengthsInformation() is added,
which is called from the various svgAttributeChanged() methods and insertedIntoDocument/removedFromDocument.
It will be implemented in a follow-up patch. This patch does not affect any test behaviour related
to relayouting. As SVGFilterElement finally got a proper svgAttributeChanged() method, it now
properly invalidates clients on attribute changes - covered by a new test.

Tests: svg/custom/relative-sized-inner-svg.xhtml

svg/custom/relative-sized-use-without-attributes-on-symbol.xhtml
svg/filters/filter-width-update.svg


  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout): Rename hasRelativeValues to hasRelativeLengths.
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): Ditto. (WebCore::RenderSVGRoot::calcViewport): Ditto.
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::calcViewport): Ditto
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::layoutChildren): Ditto.
  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::svgAttributeChanged): Call updateRelativeLengthsInformation() if any attribute which may contain relative lengths changes. (WebCore::SVGCircleElement::selfHasRelativeLengths): Ditto. Same for all other SVG*Elements below.
  • svg/SVGCircleElement.h:
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::svgAttributeChanged): (WebCore::SVGEllipseElement::selfHasRelativeLengths):
  • svg/SVGEllipseElement.h:
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::svgAttributeChanged): (WebCore::SVGFilterElement::selfHasRelativeLengths):
  • svg/SVGFilterElement.h:
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::svgAttributeChanged): (WebCore::SVGForeignObjectElement::selfHasRelativeLengths):
  • svg/SVGForeignObjectElement.h:
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::svgAttributeChanged): (WebCore::SVGImageElement::selfHasRelativeLengths):
  • svg/SVGImageElement.h:
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::svgAttributeChanged): (WebCore::SVGLineElement::selfHasRelativeLengths):
  • svg/SVGLineElement.h:
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::svgAttributeChanged): (WebCore::SVGLinearGradientElement::selfHasRelativeLengths):
  • svg/SVGLinearGradientElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::svgAttributeChanged): (WebCore::SVGMarkerElement::selfHasRelativeLengths):
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::svgAttributeChanged): (WebCore::SVGMaskElement::selfHasRelativeLengths):
  • svg/SVGMaskElement.h:
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::svgAttributeChanged): (WebCore::SVGPatternElement::selfHasRelativeLengths):
  • svg/SVGPatternElement.h:
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::svgAttributeChanged): (WebCore::SVGRadialGradientElement::selfHasRelativeLengths):
  • svg/SVGRadialGradientElement.h:
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::svgAttributeChanged): (WebCore::SVGRectElement::selfHasRelativeLengths):
  • svg/SVGRectElement.h:
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::svgAttributeChanged): (WebCore::SVGSVGElement::selfHasRelativeLengths):
  • svg/SVGSVGElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::insertedIntoDocument): Call updateRelativeLengthsInformation(). (WebCore::SVGStyledElement::removedFromDocument): Ditto. (WebCore::SVGStyledElement::updateRelativeLengthsInformation): Not implemented so far. Will land in a follow-up patch, together with the render tree changes.
  • svg/SVGStyledElement.h: (WebCore::SVGStyledElement::hasRelativeLengths): Devirtualized. For now, just call selfHasRelativeLengths() - this will change in a follow-up patch. (WebCore::SVGStyledElement::updateRelativeLengthsInformation): (WebCore::SVGStyledElement::selfHasRelativeLengths): Renamed from hasRelativeValues().
  • svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::svgAttributeChanged): (WebCore::SVGSymbolElement::selfHasRelativeLengths):
  • svg/SVGSymbolElement.h:
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::selfHasRelativeLengths):
  • svg/SVGTextContentElement.h:
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::svgAttributeChanged): (WebCore::SVGTextPathElement::insertedIntoDocument): Call right base class' method. Skipped one in the hierachy before. (WebCore::SVGTextPathElement::selfHasRelativeLengths):
  • svg/SVGTextPathElement.h:
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::svgAttributeChanged): (WebCore::listContainsRelativeValue): New helper funtion that checks wheter a SVGLengthList contains relative lengths. (WebCore::SVGTextPositioningElement::selfHasRelativeLengths):
  • svg/SVGTextPositioningElement.h:
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::insertedIntoDocument): Call right base class' method. Skipped on in the hierachy before. (WebCore::SVGUseElement::removedFromDocument): Ditto. (WebCore::SVGUseElement::svgAttributeChanged): (WebCore::SVGUseElement::buildShadowAndInstanceTree): Call updateRelativeLengthsInformation() after building the shadow tree. (WebCore::SVGUseElement::selfHasRelativeLengths): Same as all other methods, except that it includes the shadow tree root element.
  • svg/SVGUseElement.h:

2010-07-05 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Logic to track whether elements are using relative lengths is incomplete
https://bugs.webkit.org/show_bug.cgi?id=41566

Add two new relative-sized-*.svg tests that would break, when relative sized kids aren't layout correctly.
Add new test covering that filters update their clients, if any attribute changes.

  • platform/mac/svg/custom/relative-sized-inner-svg-expected.checksum: Added.
  • platform/mac/svg/custom/relative-sized-inner-svg-expected.png: Added.
  • platform/mac/svg/custom/relative-sized-inner-svg-expected.txt: Added.
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum: Added.
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png: Added.
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt: Added.
  • platform/mac/svg/filters/filter-width-update-expected.checksum: Added.
  • platform/mac/svg/filters/filter-width-update-expected.png: Added.
  • platform/mac/svg/filters/filter-width-update-expected.txt: Added.
  • svg/custom/relative-sized-inner-svg.xhtml: Added.
  • svg/custom/relative-sized-use-without-attributes-on-symbol.xhtml: Added.
  • svg/filters/filter-width-update.svg: Added.
7:23 AM Changeset in webkit [62487] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-07-05 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Problem with copying a code from Scripts panel.

https://bugs.webkit.org/show_bug.cgi?id=40432

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._getSelection): (WebInspector.TextViewer.prototype._selectionToPosition):
7:07 AM Changeset in webkit [62486] by commit-queue@webkit.org
  • 1 edit
    5 adds in trunk/WebKit2

2010-07-05 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Antti Koivisto.

[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Add Qt C API integration.

  • UIProcess/API/cpp/qt/WKStringQt.cpp: Added. (WKStringCreateWithQString): (WKStringCopyQString):
  • UIProcess/API/cpp/qt/WKStringQt.h: Added.
  • UIProcess/API/cpp/qt/WKURLQt.cpp: Added. (WKURLCreateWithQUrl): (WKURLCopyQUrl):
  • UIProcess/API/cpp/qt/WKURLQt.h: Added.
6:41 AM Changeset in webkit [62485] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/WebKit2

2010-07-05 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Antti Koivisto.

[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Add the Qt process launcher.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Added. (WebKit::ProcessLauncher::launchProcess): (WebKit::ProcessLauncher::terminateProcess): (WebKit::webThreadBody): (WebKit::ProcessLauncher::createWebThread): (webProcessMain):
5:48 AM Changeset in webkit [62484] by Nikolas Zimmermann
  • 3 edits
    4 adds in trunk

2010-07-05 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze / Darin Adler.

Node.cloneNode does not work on SVG nodes
https://bugs.webkit.org/show_bug.cgi?id=41421

Be sure to synchronize animated SVG properties before checking whether NamedNodeMap exists.
When creating a SVG element from JS, and setting all attributes via SVG DOM, and not using setAttribute
the NamedNodeMap does not exist. When cloning such an element, be sure to synchronize SVG <-> XML DOM
attributes before attempting to clone, otherwhise the SVG animated properties are lost while cloning.

Test: svg/custom/clone-element-with-animated-svg-properties.html

  • dom/Element.cpp: (WebCore::Element::cloneElementWithoutChildren):
5:31 AM Changeset in webkit [62483] by antti.j.koivisto@nokia.com
  • 5 edits in trunk

Revert unplanned project file change.

.:

  • WebKit.pro:

WebCore:

  • WebCore.pri:
  • WebCore.pro:
5:27 AM Changeset in webkit [62482] by Nikolas Zimmermann
  • 3 edits
    4 adds in trunk

2010-07-05 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Darin Adler.

Memory corruption with SVG <use> element
https://bugs.webkit.org/show_bug.cgi?id=40994

Fix race condition in svgAttributeChanged. Never call svgAttributeChanged() from attributeChanged()
when we're synchronizing SVG attributes. It leads to either unnecessary extra work being done or
crashes. Especially together with <polyline>/<polygon> which always synchronize the SVGAnimatedPoints
datastructure with the points attribute, no matter if there are changes are not. This should be
furhter optimized, but this fix is sane and fixes the root of the evil races.

Test: svg/custom/use-property-synchronization-crash.svg

  • svg/SVGElement.cpp: (WebCore::SVGElement::attributeChanged):
5:26 AM Changeset in webkit [62481] by antti.j.koivisto@nokia.com
  • 5 edits
    4 adds in trunk

[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Implement ChunkedUpdateDrawingArea + Proxy for Qt. Not built yet.

  • UIProcess/ChunkedUpdateDrawingAreaProxy.h:
  • UIProcess/qt: Added.
  • UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp: Added.

(WebKit::ChunkedUpdateDrawingAreaProxy::page):
(WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore):
(WebKit::ChunkedUpdateDrawingAreaProxy::invalidateBackingStore):
(WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):
(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):

  • WebProcess/WebPage/qt: Added.
  • WebProcess/WebPage/qt/ChunkedUpdateDrawingAreaQt.cpp: Added.

(WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):

3:50 AM Changeset in webkit [62480] by morrita@google.com
  • 3 edits in trunk/WebKitTools

2010-07-04 MORITA Hajime <morrita@google.com>

rebaseline-chromium-webkit-tests: UnicodeDecodeError
https://bugs.webkit.org/show_bug.cgi?id=41589

  • run() method can result non-utf-8 bytes, that causes utf-8 decoding fail. Fixed to disable decoding.
  • Fixed Git.find_checkout_root() to make a test pass.
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
3:05 AM Changeset in webkit [62479] by yurys@chromium.org
  • 4 edits in trunk

2010-07-05 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: remove v8-specific code dealing with getOwnPropertyNames from InjectedScript.js
https://bugs.webkit.org/show_bug.cgi?id=41595

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):

2010-07-05 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: remove v8-specific code dealing with getOwnPropertyNames from InjectedScript.js
https://bugs.webkit.org/show_bug.cgi?id=41595

  • src/js/DebuggerScript.js:
3:03 AM Changeset in webkit [62478] by rwlbuis@webkit.org
  • 7 edits
    3 adds in trunk

2010-07-04 Rob Buis <rwlbuis@gmail.com>

Reviewed by Dirk Schulze.

SVG polygons should draw polygons up to the first parsing error
https://bugs.webkit.org/show_bug.cgi?id=41140

Render polygons up until the first parsing error.

Test: svg/custom/poly-parsing-error.html

  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::parseMappedAttribute):
2:49 AM QtWebKitTriageRoster edited by Simon Hausmann
(diff)
12:32 AM Changeset in webkit [62477] by alice.liu@apple.com
  • 2 edits in trunk/WebCore

Crash reading past end of block in UniscribeController::shapeAndPlaceItem
https://bugs.webkit.org/show_bug.cgi?id=41554

Reviewed by Dan Bernstein.

Test: platform/win/fast/text/uniscribe-item-boundary-crash.html

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::shapeAndPlaceItem):
Don't look one past the end of str. Instead look to the next item, if applicable.

12:18 AM Changeset in webkit [62476] by Philippe Normand
  • 4 edits in trunk/WebKit/mac

2010-06-23 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] on Mac OS use a runloop observer to process the glib context iterations
https://bugs.webkit.org/show_bug.cgi?id=35747

If VIDEO and GSTREAMER are enabled, make the WebView start a
runloop observer that will trigger the glib main context
iterations. Those are needed by the GStreamer player only at the
moment but could later be used for other GLib-dependant components
if required.

  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _close]): (-[WebView _clearGlibLoopObserver]): (glibContextIterationCallback): (-[WebView _scheduleGlibContextIterations]):
  • WebView/WebViewData.h:
  • WebView/WebViewInternal.h:

Jul 4, 2010:

11:56 PM Changeset in webkit [62475] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-04 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Mark fast/js/function-apply-many-args.html as
having wrong output in debug mode.

  • platform/chromium/test_expectations.txt:
9:45 PM Changeset in webkit [62474] by eric@webkit.org
  • 6 edits in trunk

2010-07-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add basic "in table body" mode to support <tr> insertion
https://bugs.webkit.org/show_bug.cgi?id=41587

  • html5lib/runner-expected-html5.txt:
    • <tr> tags now show up, imagine that.

2010-07-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add basic "in table body" mode to support <tr> insertion
https://bugs.webkit.org/show_bug.cgi?id=41587

This also adds a (currently untestable?)
popUntilTableBodyScopeMarker code path.
Any tags which would be between a tbody a <tr> would end up
foster parented outside the <table>. I think the spec was
just being over-cautious with popUntilTableBodyScopeMarker.

  • html/HTMLElementStack.cpp: (WebCore::HTMLNames::isTableScopeMarker): (WebCore::HTMLNames::isTableBodyScopeMarker): (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
  • html/HTMLElementStack.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
7:37 PM Changeset in webkit [62473] by pkasting@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-win/html5lib/runner-expected.txt:
  • platform/chromium/test_expectations.txt:
4:27 PM Changeset in webkit [62472] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix Windows build.

  • WebCore.vcproj/WebCore.vcproj:
4:15 PM Changeset in webkit [62471] by andersca@apple.com
  • 5 edits
    2 adds in trunk/WebKit2

Add simple command line parser and pass mode argument to the web process
https://bugs.webkit.org/show_bug.cgi?id=41586

Reviewed by Dan Bernstein.

  • Shared/CommandLine.h:

(WebKit::CommandLine::operator[]):
Add CommandLine class.

  • Shared/mac/CommandLineMac.cpp:

(WebKit::CommandLine::parse):
Implement Mac version of CommandLine::parse.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):
Add "legacywebprocess" mode to the posix_spawn call.

  • WebKit2.xcodeproj/project.pbxproj:

Add CommandLine to the xcode project.

  • WebProcess/Launching/mac/WebProcessMain.mm:

(webProcessMain):
(main):
Parse the command line and check the mode.

3:06 PM Changeset in webkit [62470] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-07-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTMLTreeBuilder needs an adoption agency
https://bugs.webkit.org/show_bug.cgi?id=41453

Fix Qt Minimal build. SVGNames.h should always
be generated, even when SVG is off, however that's
not how things currently work.

  • html/HTMLTreeBuilder.cpp:
2:54 PM Changeset in webkit [62469] by eric@webkit.org
  • 9 edits in trunk

2010-07-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add a very basic InTable insertion mode
https://bugs.webkit.org/show_bug.cgi?id=41581

  • html5lib/runner-expected-html5.txt:
    • Update expectations now that we pass 6 more tests.

2010-07-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add a very basic InTable insertion mode
https://bugs.webkit.org/show_bug.cgi?id=41581

There is still a bunch of low-hanging fruit left for this
mode, but even this most-basic support lets us pass 6 more tests. :)

It's a progression, ship it! :)

  • html/HTMLElementStack.cpp: (WebCore::HTMLNames::isScopeMarker): (WebCore::HTMLNames::isListItemScopeMarker): (WebCore::HTMLNames::isTableScopeMarker): (WebCore::HTMLElementStack::popUntilTableScopeMarker):
  • html/HTMLElementStack.h:
  • html/HTMLFormattingElementList.cpp: (WebCore::HTMLFormattingElementList::appendMarker):
  • html/HTMLFormattingElementList.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
  • html/HTMLTreeBuilder.h:
2:15 PM Changeset in webkit [62468] by eric@webkit.org
  • 13 edits
    1 add in trunk

2010-07-02 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTMLTreeBuilder needs an adoption agency
https://bugs.webkit.org/show_bug.cgi?id=41453

Added new adoption01 suite for testing adoption agency
bugs. Right now only the simplest adoption test passes.
I'll be adding more in future commits.

  • html5lib/resources/adoption01.dat: Added.
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:

2010-07-01 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTMLTreeBuilder needs an adoption agency
https://bugs.webkit.org/show_bug.cgi?id=41453

This changes some test results, but only makes the simplest
adoption agency cases pass. I think the code is likely
very close, but further iteration to make this change larger
seems counter-productive. I recommend we check in this
progression and work from here.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::addChildCommon):
    • Make sure callers don't assume this will reparent.

(WebCore::ContainerNode::parserAddChild):

  • Update comment to document lack of reparenting behavior.
  • html/HTMLElementStack.cpp: (WebCore::HTMLElementStack::ElementRecord::ElementRecord): (WebCore::HTMLElementStack::ElementRecord::~ElementRecord): (WebCore::HTMLElementStack::ElementRecord::replaceElement): (WebCore::HTMLElementStack::ElementRecord::isAbove):
    • Added for debugging.

(WebCore::HTMLElementStack::pushHTMLHtmlElement):
(WebCore::HTMLElementStack::insertAbove):

  • Needed for the adoption agency.

(WebCore::HTMLElementStack::topRecord):
(WebCore::HTMLElementStack::bottom):
(WebCore::HTMLElementStack::removeHTMLHeadElement):
(WebCore::HTMLElementStack::remove):
(WebCore::HTMLElementStack::find):
(WebCore::HTMLElementStack::topmost):
(WebCore::HTMLElementStack::contains):
(WebCore::HTMLElementStack::htmlElement):
(WebCore::HTMLElementStack::headElement):
(WebCore::HTMLElementStack::bodyElement):
(WebCore::HTMLElementStack::pushCommon):
(WebCore::HTMLElementStack::removeNonTopCommon):

  • Fix the name to match top/bottom.
  • html/HTMLElementStack.h: (WebCore::HTMLElementStack::ElementRecord::element): (WebCore::HTMLElementStack::ElementRecord::next): (WebCore::HTMLElementStack::ElementRecord::releaseNext): (WebCore::HTMLElementStack::ElementRecord::setNext):
  • html/HTMLFormattingElementList.cpp: (WebCore::HTMLFormattingElementList::closestElementInScopeWithName): (WebCore::HTMLFormattingElementList::contains): (WebCore::HTMLFormattingElementList::find): (WebCore::HTMLFormattingElementList::remove):
  • html/HTMLFormattingElementList.h: (WebCore::HTMLFormattingElementList::isEmpty): (WebCore::HTMLFormattingElementList::size):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::furthestBlockForFormattingElement):
    • Part of the Adoption Agency algorithm.

(WebCore::HTMLTreeBuilder::findFosterParentFor):

  • Used to move mis-nested content out of tables. This doesn't seem to work quite right yet.

(WebCore::HTMLTreeBuilder::reparentChildren):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

  • The ridiculously long/complicated adoption agency algorithm from HTML5.

(WebCore::HTMLTreeBuilder::processEndTag):

  • html/HTMLTreeBuilder.h:
10:44 AM Changeset in webkit [62467] by jschuh@chromium.org
  • 2 edits in trunk/WebCore

2010-07-04 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

Remove custom src bindings for HTMLFrameElement and HTMLIFrameElement
https://bugs.webkit.org/show_bug.cgi?id=41578

Remove bindings obsoleted by: http://trac.webkit.org/changeset/59866
No new tests because behavior is not changed.

  • Android.jscbindings.mk:
  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSHTMLFrameElementCustom.cpp:
  • bindings/js/JSHTMLIFrameElementCustom.cpp: Removed.
  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
  • bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Removed.
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
9:22 AM Changeset in webkit [62466] by jschuh@chromium.org
  • 14 edits
    2 deletes in trunk/WebCore

2010-07-04 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

Remove custom src bindings for HTMLFrameElement and HTMLIFrameElement
https://bugs.webkit.org/show_bug.cgi?id=41578

Remove bindings obsoleted by: http://trac.webkit.org/changeset/59866
No new tests because behavior is not changed.

  • Android.jscbindings.mk:
  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSHTMLFrameElementCustom.cpp:
  • bindings/js/JSHTMLIFrameElementCustom.cpp: Removed.
  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
  • bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Removed.
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
9:06 AM UpdatingBugzilla edited by ddkilzer@webkit.org
(diff)
9:04 AM UpdatingBugzilla edited by ddkilzer@webkit.org
(diff)
6:38 AM Changeset in webkit [62465] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2010-07-04 Robert Hogan <robert@webkit.org>

[Qt] Triage failing HTTP tests in Qt Skipped list

Unreviewed, sorting tests and adding comments to skipped list.

  • platform/qt/Skipped:
4:48 AM Changeset in webkit [62464] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix after r62456.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute): Be slightly more consistent in using uint32_t to prevent
warnings about comparisons between signed and unsigned types, and attempts to call an overload
of std::min that doesn't exist.

3:38 AM Changeset in webkit [62463] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

Unreviewed, accidental omission from r61505

https://bugs.webkit.org/show_bug.cgi?id=36702

Forgot to unskip plugins/reentrant-update-widget-positions.html
as part of http://trac.webkit.org/changeset/61505

3:16 AM Changeset in webkit [62462] by yurys@chromium.org
  • 3 edits
    4 adds in trunk/LayoutTests

2010-07-04 Yury Semikhatsky <yury@yurys-imac.local>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/fast/js/function-apply-expected.txt: Added.
  • platform/chromium-mac/fast/js/function-apply-many-args-expected.txt: Added.
  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-win/fast/js/function-apply-expected.txt: Added.
  • platform/chromium-win/fast/js/function-apply-many-args-expected.txt: Added.
  • platform/chromium-win/html5lib/runner-expected.txt:
2:41 AM Changeset in webkit [62461] by mjs@apple.com
  • 2 edits in trunk/WebKit2

2010-07-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

WebProcess crashes in release for simple layout tests
https://bugs.webkit.org/show_bug.cgi?id=41575

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageCopyRenderTreeExternalRepresentation): ref external representation StringImpl* before taking it out of its parent String, to avoid returning freed memory.

Jul 3, 2010:

10:09 PM Changeset in webkit [62460] by abarth@webkit.org
  • 7 edits in trunk

2010-07-03 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Implement AfterAfterFramesetMode
https://bugs.webkit.org/show_bug.cgi?id=41561

Test coverage of this mode was a bit ... lacking, shall we say? This
patch adds a test for it.

  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/webkit-resumer-expected.txt:

2010-07-03 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Implement AfterAfterFramesetMode
https://bugs.webkit.org/show_bug.cgi?id=41561

This mode is almost unobservable. The main way to observe it seems to
be seeing where comment nodes get attached to the DOM.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processComment): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
9:53 PM Changeset in webkit [62459] by mjs@apple.com
  • 2 edits in trunk/WebKit2

Add stdint.h include to fix WebKitTestRunner build.

Rubber stamped by Anders Carlsson.

  • UIProcess/API/C/WKPage.h:
6:33 PM Changeset in webkit [62458] by zmo@google.com
  • 5 edits in trunk

2010-07-03 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

WebGLRenderingContext::vertexAttrib* leads to possible out-of-range vector member visit
https://bugs.webkit.org/show_bug.cgi?id=41572

  • platform/mac-leopard/Skipped: Adding back the program-test.html test since the failure cause is fixed in this patch.

2010-07-03 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

WebGLRenderingContext::vertexAttrib* leads to possible out-of-range vector member visit
https://bugs.webkit.org/show_bug.cgi?id=41572

  • html/canvas/WebGLRenderingContext.cpp: Fix the out-of-range vector member visit, also refactor the code. (WebCore::WebGLRenderingContext::vertexAttrib1f): (WebCore::WebGLRenderingContext::vertexAttrib1fv): (WebCore::WebGLRenderingContext::vertexAttrib2f): (WebCore::WebGLRenderingContext::vertexAttrib2fv): (WebCore::WebGLRenderingContext::vertexAttrib3f): (WebCore::WebGLRenderingContext::vertexAttrib3fv): (WebCore::WebGLRenderingContext::vertexAttrib4f): (WebCore::WebGLRenderingContext::vertexAttrib4fv): (WebCore::WebGLRenderingContext::vertexAttribfImpl): (WebCore::WebGLRenderingContext::vertexAttribfvImpl):
  • html/canvas/WebGLRenderingContext.h: Helper function declaration.
5:11 PM Changeset in webkit [62457] by weinig@apple.com
  • 4 edits in trunk/JavaScriptCore

Patch for https://bugs.webkit.org/show_bug.cgi?id=41553
Make StringExtras.h versions of snprintf and vsnprintf match the unix versions.

Reviewed by Darin Adler.

  • MSVC does not ensure the buffers are null terminated as the unix versions do.
  • runtime/JSGlobalObjectFunctions.cpp: Cleanup includes.
  • runtime/UString.cpp: Clean up includes.

(JSC::UString::from): Don't pass sizeof(buf) - 1, that is wrong.

  • wtf/StringExtras.h:

(snprintf): Ensure null termination of buffer.
(vsnprintf): Ditto.

4:49 PM Changeset in webkit [62456] by Darin Adler
  • 5 edits in trunk

2010-07-03 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

Make Arguments::MaxArguments clamping work for numbers >= 0x80000000 in
the interpreter as well as the JIT.

https://bugs.webkit.org/show_bug.cgi?id=41351
rdar://problem/8142141

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): Fix signed integer overflow problem in op_load_varargs handling. 0xFFFFFFFF was read as -1.

2010-07-03 Darin Adler <Darin Adler>

Added test cases for edge cases in apply function on arrays.
https://bugs.webkit.org/show_bug.cgi?id=41351

  • fast/js/function-apply-expected.txt: Updated to expect success.
  • fast/js/script-tests/function-apply.js: Added test cases.
4:02 PM Changeset in webkit [62455] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

Ugh. Have to put the destructor in the .h file since the .ccp isn't compiled yet.

  • storage/IDBKey.h:

(WebCore::IDBKey::~IDBKey):

4:00 PM Changeset in webkit [62454] by commit-queue@webkit.org
  • 3 edits in trunk/WebKitTools

2010-07-03 Patrick Gansterer <paroga@paroga.com>

Reviewed by Simon Hausmann.

[Qt] Fix DumpRenderTree userStyleSheet handling.
https://bugs.webkit.org/show_bug.cgi?id=41570

DumpRenderTree did only set the userStyleSheet at
layoutTestController.setUserStyleSheetEnabled().

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::setUserStyleSheetEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
3:48 PM UpdatingBugzilla edited by ddkilzer@webkit.org
(diff)
3:48 PM Changeset in webkit [62453] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

Build fix. Forgot destructor.

  • storage/IDBKey.cpp:

(WebCore::IDBKey::~IDBKey):

3:46 PM UpdatingBugzilla edited by ddkilzer@webkit.org
(diff)
3:45 PM UpdatingBugzilla edited by ddkilzer@webkit.org
Updated Update section for bzr (diff)
3:37 PM UpdatingBugzilla edited by ddkilzer@webkit.org
Switched from CVS to bzr for upstream Bugzilla repository. (diff)
3:18 PM Changeset in webkit [62452] by jorlow@chromium.org
  • 20 edits
    6 copies
    5 adds in trunk

2010-06-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dumitru Daniliuc.

Support for keys and in-memory storage for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=41252

Set the role to Private.

2010-06-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dumitru Daniliuc.

Support for keys and in-memory storage for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=41252

It'll take some time to get data persistence working for IndexedDB,
so until then, we'll just store everything in an in memory tree.
The tree uses WTF::AVLTree and is a template so that it can be used by
object stores (IDBKey -> SerializedScriptValue) and indexes (IDBKey ->
IDBKey). This class will be used in a subsequent patch.

Also add an IDBKey type that represents one of these keys. We use a
custom toJS function in a way similar to IDBAny to convert from WebCore
to a JS value. For converting the other way, we have to teach the code
generators what to do (unfortunately). This is done in a way similar
to serialized script value. Unlike serialized script value, IDBKey is
in WebCore and only a helper function is JS engine specific.

This code is not accessable from layout tests. (Will fix in
https://bugs.webkit.org/show_bug.cgi?id=41250) The bindings tests
show us that the generated bindings are what we expect.

  • ForwardingHeaders/wtf/AVLTree.h: Added.
  • bindings/js/IDBBindingUtilities.cpp: Added. (WebCore::createIDBKeyFromValue):
  • bindings/js/IDBBindingUtilities.h: Added.
  • bindings/js/JSIDBKeyCustom.cpp: Added. (WebCore::toJS):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: (WebDOMTestObj::idbKey):
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_idb_key):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjPrototypeFunctionIdbKey):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj idbKey:]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::idbKeyCallback): (WebCore::):
  • bindings/v8/IDBBindingUtilities.cpp: Added. (WebCore::createIDBKeyFromValue):
  • bindings/v8/IDBBindingUtilities.h: Added.
  • bindings/v8/custom/V8IDBKeyCustom.cpp: Added. (WebCore::toV8):
  • storage/IDBCallbacks.h:
  • storage/IDBKey.cpp: Added. (WebCore::IDBKey::IDBKey): (WebCore::IDBKey::~IDBKey):
  • storage/IDBKey.h: Added. (WebCore::IDBKey::create): (WebCore::IDBKey::): (WebCore::IDBKey::type): (WebCore::IDBKey::string): (WebCore::IDBKey::number):
  • storage/IDBKey.idl: Added.
  • storage/IDBKeyTree.h: Added. (WebCore::IDBKeyTree::create): (WebCore::IDBKeyTree::AVLTreeAbstractor::get_less): (WebCore::IDBKeyTree::AVLTreeAbstractor::set_less): (WebCore::IDBKeyTree::AVLTreeAbstractor::get_greater): (WebCore::IDBKeyTree::AVLTreeAbstractor::set_greater): (WebCore::IDBKeyTree::AVLTreeAbstractor::get_balance_factor): (WebCore::IDBKeyTree::AVLTreeAbstractor::set_balance_factor): (WebCore::IDBKeyTree::AVLTreeAbstractor::null): (WebCore::IDBKeyTree::AVLTreeAbstractor::compare_key_node): (WebCore::IDBKeyTree::AVLTreeAbstractor::compare_node_node): (WebCore::::IDBKeyTree): (WebCore::::~IDBKeyTree): (WebCore::::AVLTreeAbstractor::compare_key_key): (WebCore::::get): (WebCore::::insert): (WebCore::::remove):
2:57 PM Changeset in webkit [62451] by jhoneycutt@apple.com
  • 14 edits in trunk

The missing plug-in indicator should be clickable

https://bugs.webkit.org/show_bug.cgi?id=41550
<rdar://problem/8132162>

From an original patch by Kevin Decker.

Reviewed by Darin Adler.

WebCore:

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::defaultEventHandler):
If the renderer is a RenderEmbeddedWidget showing the missing plug-in
indicator, and the event is a click even, call the ChromeClient's
missingPluginButtonClicked() function.

  • page/ChromeClient.h:

(WebCore::ChromeClient::missingPluginButtonClicked):
Declare missingPluginButtonClicked(), and stub the default
implementation.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
Initialize m_showsMissingPluginIndicator.
(WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator):
Assert that we're not currently showing any replacement text. Set
m_showsMissingPluginIndicator after setting the replacement text.
(WebCore::RenderEmbeddedObject::setShowsCrashedPluginIndicator):
Add the same assert as above.

  • rendering/RenderEmbeddedObject.h:

(WebCore::RenderEmbeddedObject::showsMissingPluginIndicator):
Getter for m_showsMissingPluginIndicator.

WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:

Declare an override of missingPluginButtonClicked().

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::missingPluginButtonClicked):
Call the UIDelegate's method.

  • WebView/WebUIDelegatePrivate.h:

Declare didPressMissingPluginButton.

WebKit/win:

  • Interfaces/IWebUIDelegatePrivate.idl:

Added a new delegate interface, and declare a function
didPressMissingPluginButton().

  • Interfaces/WebKit.idl:

Touch this file to force interfaces to be rebuilt.

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::missingPluginButtonClicked):
Get the UI delegate, and query it for IWebUIDelegatePrivate3. Call its
didPressMissingPluginButton() function.

  • WebCoreSupport/WebChromeClient.h:

Declare an override of missingPluginButtonClicked().

2:36 PM Changeset in webkit [62450] by robert@webkit.org
  • 4 edits in trunk

2010-07-03 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Return usable property names from DRT's computedStyleIncludingVisitedInfo()

Unskip fast/history/self-is-visited.html

https://bugs.webkit.org/show_bug.cgi?id=40445

  • platform/qt/Skipped:

2010-07-03 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Return usable property names from DRT's computedStyleIncludingVisitedInfo()

Object property names such as 'background-color' need to be returned in camel
case, i.e. backgroundColor so that JS can reference them. Add support for this
to DumpRenderTreeSupportQt.

https://bugs.webkit.org/show_bug.cgi?id=40445

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (convertToPropertyName): (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
1:30 PM Changeset in webkit [62449] by oliver@apple.com
  • 9 edits in trunk

Move BOM handling out of the lexer and parser
https://bugs.webkit.org/show_bug.cgi?id=41539

Reviewed by Geoffrey Garen.

JavaScriptCore:

Doing the BOM stripping in the lexer meant that we could
end up having to strip the BOMs from a source multiple times.
To deal with this we now require all strings provided by
a SourceProvider to already have had the BOMs stripped.
This also simplifies some of the lexer logic.

  • parser/Lexer.cpp:

(JSC::Lexer::setCode):
(JSC::Lexer::sourceCode):

  • parser/SourceProvider.h:

(JSC::SourceProvider::SourceProvider):
(JSC::UStringSourceProvider::create):
(JSC::UStringSourceProvider::getRange):
(JSC::UStringSourceProvider::UStringSourceProvider):

  • wtf/text/StringImpl.h:

(WebCore::StringImpl::copyStringWithoutBOMs):

WebCore:

Update WebCore to ensure that SourceProviders don't
produce strings with BOMs in them.

  • bindings/js/ScriptSourceProvider.h:

(WebCore::ScriptSourceProvider::ScriptSourceProvider):

  • bindings/js/StringSourceProvider.h:

(WebCore::StringSourceProvider::StringSourceProvider):

  • loader/CachedScript.cpp:

(WebCore::CachedScript::CachedScript):
(WebCore::CachedScript::script):

  • loader/CachedScript.h:

(WebCore::CachedScript::):

CachedScript now stores decoded data with the BOMs stripped,
and caches the presence of BOMs across memory purges.

12:20 PM Changeset in webkit [62448] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-07-03 Xan Lopez <xlopez@igalia.com>

Include DerivedSources/WebCore before DerivedSources/

Recently DerivedSources generation was changed, with some files no
longer being generated in the toplevel DerivedSources
directory. Since that directory is first in the -I flags the build
can be broken in some cases by including old files unless a 'make
clean' is done. Change the -I order to fix the build in the 32 bit
Release bot.

  • GNUmakefile.am:
7:08 AM Changeset in webkit [62447] by arv@chromium.org
  • 7 edits
    1 add in trunk

2010-07-03 Erik Arvidsson <arv@chromium.org>

Reviewed by Ojan Vafai.

Fix issue where a contextmenu event was reporting the wrong target if
the context menu was shown due to pressing the context menu key
(or Shift+F10).

Split sendContextMenuForEvent into one case for keyboard events and use
that when the contextmenu event should be dispatched due to a keypress.

For the keboard case we now use the focused node as the target for the
event and use the clipped rect to determine the position of the menu.

https://bugs.webkit.org/show_bug.cgi?id=38129

Use manual test since DRT does not handle context menu keys.

  • manual-tests/win/contextmenu-key.html: Added.
  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): (WebCore::EventHandler::sendContextMenuEventForKey):
  • page/EventHandler.h:

2010-07-03 Erik Arvidsson <arv@chromium.org>

Reviewed by Ojan Vafai.

Fix issue where a contextmenu event was reporting the wrong target
if the context menu was shown due to pressing the context menu key
(or Shift+F10).

https://bugs.webkit.org/show_bug.cgi?id=38129

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::sendContextMenuEvent):

2010-07-03 Erik Arvidsson <arv@chromium.org>

Reviewed by Ojan Vafai.

Fix issue where a contextmenu event was reporting the wrong target
if the context menu was shown due to pressing the context menu key
(or Shift+F10).

  • WebView.cpp: (WebView::handleContextMenuEvent):
5:03 AM Changeset in webkit [62446] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-07-03 Dirk Schulze <krit@webkit.org>

Unreviewed sort of XCode project file.

  • WebCore.xcodeproj/project.pbxproj:
3:42 AM Changeset in webkit [62445] by robert@webkit.org
  • 10 edits in trunk/LayoutTests

2010-07-03 Robert Hogan <robert@webkit.org>

[Qt] Update Qt expected results after r62444

Unreviewed, update test results.

http://trac.webkit.org/changeset/62444
https://bugs.webkit.org/show_bug.cgi?id=41088

Qt expected results for various fast/ tests updated to reflect
support for dumpChildFrameScrollPositions(). Checked against Mac results
and they are all good.

I have not updated the .png and .checksum files for the tests. This is
because I suspect I will not get the same pixel results as the Qt build
bot.

  • platform/qt/fast/dynamic/anchor-lock-expected.txt:
  • platform/qt/fast/overflow/position-fixed-transform-clipping-expected.txt:
  • platform/qt/fast/repaint/fixed-child-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-tranformed-expected.txt:
  • platform/qt/fast/repaint/repaint-during-scroll-expected.txt:
  • platform/qt/transforms/2d/transform-fixed-container-expected.txt:
3:00 AM Changeset in webkit [62444] by robert@webkit.org
  • 7 edits in trunk

2010-07-03 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] support dumpChildFrameScrollPositions

https://bugs.webkit.org/show_bug.cgi?id=41088

Unskip:

http/tests/navigation/anchor-subframeload.html
http/tests/navigation/relativeanchor-frames.html

  • platform/qt/Skipped:

2010-07-03 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] support dumpChildFrameScrollPositions

https://bugs.webkit.org/show_bug.cgi?id=41088

Unskip:

http/tests/navigation/anchor-subframeload.html
http/tests/navigation/relativeanchor-frames.html

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dumpFrameScrollPosition): (WebCore::DumpRenderTree::dump):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):
  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::shouldDumpChildFrameScrollPositions): (LayoutTestController::dumpChildFrameScrollPositions):
1:45 AM Changeset in webkit [62443] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2010-07-03 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Port Widget
https://bugs.webkit.org/show_bug.cgi?id=41538

Make Widget a dummy class. WebKit Brew MP uses the full screen mode
and does not use the window system introduced in Brew MP.

  • platform/Widget.h:
  • platform/brew/WidgetBrew.cpp: Added. (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect): (WebCore::Widget::setFocus): (WebCore::Widget::setCursor): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::paint): (WebCore::Widget::setIsSelected):
1:30 AM Changeset in webkit [62442] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-07-03 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kent Tamura.

[WINCE] Implement Unicode::isAlphanumeric and Unicode::isArabicChar.
https://bugs.webkit.org/show_bug.cgi?id=41411

  • wtf/unicode/wince/UnicodeWince.cpp: (WTF::Unicode::isAlphanumeric):
  • wtf/unicode/wince/UnicodeWince.h: (WTF::Unicode::isArabicChar):
1:17 AM Changeset in webkit [62441] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-07-03 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Change the CRASH() macro to print "WebKit CRASH" log.
https://bugs.webkit.org/show_bug.cgi?id=41524

Print "WebKit CRASH" before crashing.

  • wtf/Assertions.h:
12:17 AM Changeset in webkit [62440] by abarth@webkit.org
  • 4 edits in trunk

2010-07-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement AfterFramesetMode
https://bugs.webkit.org/show_bug.cgi?id=41560

It's somewhat hard to observe this state, so I'm not surprised that the
diff to the expected results are small. We still fail this test
because we don't handle whitespace correctly.

  • html5lib/runner-expected-html5.txt:

2010-07-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement AfterFramesetMode
https://bugs.webkit.org/show_bug.cgi?id=41560

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
12:03 AM Changeset in webkit [62439] by abarth@webkit.org
  • 4 edits in trunk

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement InFramesetMode
https://bugs.webkit.org/show_bug.cgi?id=41559

And the tests keep progressing.

  • html5lib/runner-expected-html5.txt:

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement InFramesetMode
https://bugs.webkit.org/show_bug.cgi?id=41559

Pretty straighforward. We still don't handle character tokens
correctly.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):

Jul 2, 2010:

11:47 PM Changeset in webkit [62438] by abarth@webkit.org
  • 6 edits in trunk

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Handle <frameset> InBody
https://bugs.webkit.org/show_bug.cgi?id=41558

Yay test progression.

  • html5lib/runner-expected-html5.txt:

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Handle <frameset> InBody
https://bugs.webkit.org/show_bug.cgi?id=41558

Handling the <frameset> tag in the InBody mode is somewhat delicate.

  • html/HTMLElementStack.cpp: (WebCore::HTMLElementStack::popHTMLBodyElement): (WebCore::HTMLElementStack::popUntil): (WebCore::HTMLElementStack::popCommon):
  • html/HTMLElementStack.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
11:45 PM Changeset in webkit [62437] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 41565 - Repatching in ARMv7Assembler::repatchLoadPtrToLEA is broken

Reviewed by Oliver Hunt.

This method tried to repatch a LDR (T2) into an ADD (T3) - but it only
repatches the first instruction word. The layout of the fields in the
second word is different, and also needs repatching.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::repatchLoadPtrToLEA):

11:32 PM Changeset in webkit [62436] by abarth@webkit.org
  • 7 edits in trunk

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Special handling of <rp> and <rt> tags
https://bugs.webkit.org/show_bug.cgi?id=41557

There didn't seem to be test coverage of these cases in the suite, so I
added a couple tests.

  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/webkit-resumer-expected.txt:

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Special handling of <rp> and <rt> tags
https://bugs.webkit.org/show_bug.cgi?id=41557

So sayeth the spec.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
11:20 PM Changeset in webkit [62435] by abarth@webkit.org
  • 4 edits in trunk

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement special optgroup processing
https://bugs.webkit.org/show_bug.cgi?id=41556

  • html5lib/runner-expected-html5.txt:

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement special optgroup processing
https://bugs.webkit.org/show_bug.cgi?id=41556

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
11:07 PM Changeset in webkit [62434] by abarth@webkit.org
  • 5 edits in trunk

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Handle <image> in new parser
https://bugs.webkit.org/show_bug.cgi?id=41555

Test progression.

  • html5lib/runner-expected-html5.txt:

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Handle <image> in new parser
https://bugs.webkit.org/show_bug.cgi?id=41555

This patch is kind of goofy but apparently how the world works.

  • html/HTMLToken.h: (WebCore::AtomicHTMLToken::setName):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
10:42 PM Changeset in webkit [62433] by oliver@apple.com
  • 2 edits in trunk/LayoutTests

Fix test to account for the arg count clamping we do with function.apply

9:52 PM Changeset in webkit [62432] by oliver@apple.com
  • 6 edits
    3 adds in trunk

Clamp the number of arguments supported by function.apply
https://bugs.webkit.org/show_bug.cgi?id=41351
<rdar://problem/8142141>

Reviewed by Gavin Barraclough.

JavaScriptCore:

Add clamping logic to function.apply similar to that
enforced by firefox. We have a smaller clamp than
firefox as our calling convention means that stack
usage is proportional to argument count -- the firefox
limit is larger than you could actually call.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Arguments.h:

(JSC::Arguments::):

LayoutTests:

Testcases.

  • fast/js/function-apply-many-args-expected.txt: Added.
  • fast/js/function-apply-many-args.html: Added.
  • fast/js/script-tests/function-apply-many-args.js: Added.
9:23 PM Changeset in webkit [62431] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Alexey Proskuryakov.

Remove extra semicolon at the end of HTMLTreeBuilder::attach
https://bugs.webkit.org/show_bug.cgi?id=41546

This is not critical, but the extra semicolon at the end of HTMLTreeBuilder::attach
causes a warning in RVCT.

  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::attach):
9:07 PM Changeset in webkit [62430] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit2

2010-07-02 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Wrong method name in file Connection.h
https://bugs.webkit.org/show_bug.cgi?id=41536

Method openConnectionHandler was spelled as openConnection in class Connection.

  • Platform/CoreIPC/Connection.h:
8:53 PM Changeset in webkit [62429] by tonyg@chromium.org
  • 2 edits in trunk/WebCore

2010-07-02 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Adler.

Performance::disconnectFrame() needs to disconnect its children
https://bugs.webkit.org/show_bug.cgi?id=41533

No new tests because no new functionality.

  • page/Performance.cpp: (WebCore::Performance::disconnectFrame):
8:39 PM Changeset in webkit [62428] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit2

2010-07-02 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Sam Weinig.

Adding notification and touch events methods to WebChromeClient
https://bugs.webkit.org/show_bug.cgi?id=41527

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::notificationPresenter): (WebKit::WebChromeClient::needTouchEvents):
  • WebProcess/WebCoreSupport/WebChromeClient.h:
8:08 PM Changeset in webkit [62427] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-02 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Sam Weinig.

Checking if WTF_USE_JSC is defined before redefining it in config.h
https://bugs.webkit.org/show_bug.cgi?id=41530

  • config.h:
8:05 PM Changeset in webkit [62426] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, test expectation update.

Mark a newly added test as crashing.

  • platform/chromium/test_expectations.txt:
7:46 PM Changeset in webkit [62425] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit2

2010-07-02 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Sam Weinig.

Removing CoreFoundation.h include from WKFrame.h
https://bugs.webkit.org/show_bug.cgi?id=41528

  • UIProcess/API/C/WKFrame.h:
7:18 PM Changeset in webkit [62424] by tonyg@chromium.org
  • 4 edits in trunk/WebCore

2010-07-02 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Add vendor prefix to window.performance
https://bugs.webkit.org/show_bug.cgi?id=41525

No new tests because window.performance tests not landed yet.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::webkitPerformance):
  • page/DOMWindow.h: (WebCore::DOMWindow::optionalWebkitPerformance):
  • page/DOMWindow.idl:
7:02 PM Changeset in webkit [62423] by zherczeg@webkit.org
  • 2 edits in trunk/WebCore

2010-07-02 Zoltan Herczeg <zherczeg@webkit.org>

Reviewed by Oliver Hunt.

Minor fix: Diffuse constant is float (not integer)
https://bugs.webkit.org/show_bug.cgi?id=10412

  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
6:49 PM Changeset in webkit [62422] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-07-02 Chao-ying Fu <fu@mips.com>

Reviewed by Oliver Hunt.

Re-enable JIT_OPTIMIZE_NATIVE_CALL on MIPS
https://bugs.webkit.org/show_bug.cgi?id=40179

Add the MIPS part to re-enable JIT_OPTIMIZE_NATIVE_CALL.

  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTINativeCall):
  • wtf/Platform.h:
6:20 PM Changeset in webkit [62421] by crogers@google.com
  • 2 edits in branches/audio/WebCore

Fixes to build for audio branch

6:20 PM Changeset in webkit [62420] by crogers@google.com
  • 1 edit in branches/audio/WebCore/WebCore.gypi

Generate bindings for AudioGainNode

5:28 PM Changeset in webkit [62419] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

Bug 41552 - Clean up ARMv7 vfp code generation
Emit separate opcode individually, remove magic numbers.

Reviewed by Oliver Hunt.

Also remove invalid assert from JSImmediate (number cells are not CELL_MASK aligned).

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::):
(JSC::ARMv7Assembler::vadd_F64):
(JSC::ARMv7Assembler::vcmp_F64):
(JSC::ARMv7Assembler::vcvt_F64_S32):
(JSC::ARMv7Assembler::vcvtr_S32_F64):
(JSC::ARMv7Assembler::vdiv_F64):
(JSC::ARMv7Assembler::vldr):
(JSC::ARMv7Assembler::vmov_F64_0):
(JSC::ARMv7Assembler::vmov):
(JSC::ARMv7Assembler::vmrs):
(JSC::ARMv7Assembler::vmul_F64):
(JSC::ARMv7Assembler::vstr):
(JSC::ARMv7Assembler::vsub_F64):
(JSC::ARMv7Assembler::VFPOperand::VFPOperand):
(JSC::ARMv7Assembler::VFPOperand::bits1):
(JSC::ARMv7Assembler::VFPOperand::bits4):
(JSC::ARMv7Assembler::vcvtOp):
(JSC::ARMv7Assembler::ARMInstructionFormatter::vfpOp):
(JSC::ARMv7Assembler::ARMInstructionFormatter::vfpMemOp):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::branchDouble):

  • runtime/JSImmediate.h:

(JSC::JSValue::isCell):

5:11 PM Changeset in webkit [62418] by mrobinson@webkit.org
  • 2 edits in trunk/WebCore

2010-07-02 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Build fix for GTK+. Try to force a rebuild of the HTMLNames.h
file first by touching HTMLTagNames.in.

  • html/HTMLTagNames.in:
5:08 PM Changeset in webkit [62417] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

2010-07-02 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Oliver Hunt.

Add test to verify proper clamping of RGB values.
https://bugs.webkit.org/show_bug.cgi?id=39482

Also unskip 3 canvas/philip tests that now pass.

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#colors

  • fast/canvas/canvas-color-clamping-expected.txt: Added.
  • fast/canvas/canvas-color-clamping.html: Added.
  • fast/canvas/script-tests/canvas-color-clamping.js: Added.
  • platform/mac/Skipped:
  • platform/qt/Skipped:

2010-07-02 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Oliver Hunt.

RGB colors should be clamped to the 0-255 range
https://bugs.webkit.org/show_bug.cgi?id=39482

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#colors

Test: fast/canvas/canvas-color-clamping.html

  • css/CSSParser.cpp: (WebCore::parseColorInt): (WebCore::CSSParser::parseColor): (WebCore::parseColorIntFromValue): (WebCore::CSSParser::parseColorParameters):
4:49 PM Changeset in webkit [62416] by commit-queue@webkit.org
  • 9 edits in trunk

2010-07-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62410.
http://trac.webkit.org/changeset/62410
https://bugs.webkit.org/show_bug.cgi?id=41549

accursed last minute changes (Requested by olliej on #webkit).

  • parser/Lexer.cpp: (JSC::Lexer::setCode): (JSC::Lexer::copyCodeWithoutBOMs): (JSC::Lexer::sourceCode):
  • parser/SourceProvider.h: (JSC::): (JSC::SourceProvider::SourceProvider): (JSC::SourceProvider::hasBOMs): (JSC::UStringSourceProvider::create): (JSC::UStringSourceProvider::getRange): (JSC::UStringSourceProvider::UStringSourceProvider):
  • wtf/text/StringImpl.h:

2010-07-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62410.
http://trac.webkit.org/changeset/62410
https://bugs.webkit.org/show_bug.cgi?id=41549

accursed last minute changes (Requested by olliej on #webkit).

  • bindings/js/ScriptSourceProvider.h: (WebCore::ScriptSourceProvider::ScriptSourceProvider):
  • bindings/js/StringSourceProvider.h: (WebCore::StringSourceProvider::StringSourceProvider):
  • loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript): (WebCore::CachedScript::script):
  • loader/CachedScript.h:
4:46 PM Changeset in webkit [62415] by weinig@apple.com
  • 1 edit
    2 moves in trunk/WebKitTools

Rename new scripts so that they don't make autocompleting run-webkit-tests annoying.

Reviewed by Anders Carlsson.

  • Scripts/debug-test-runner: Copied from Scripts/debug-webkittestrunner.
  • Scripts/debug-webkittestrunner: Removed.
  • Scripts/run-test-runner: Copied from Scripts/run-webkittestrunner.
  • Scripts/run-webkittestrunner: Removed.
4:26 PM Changeset in webkit [62414] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

Patch for https://bugs.webkit.org/show_bug.cgi?id=41548
Use snprintf instead of sprintf everywhere in JavaScriptCore

Reviewed by Geoffrey Garen.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::globalFuncEscape):

  • runtime/UString.cpp:

(JSC::UString::from):

4:15 PM Changeset in webkit [62413] by mrobinson@webkit.org
  • 2 edits in trunk/WebCore

2010-07-02 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Further Build fix for GTK+. Also include HTMLElementFactory.h in
the list of dependencies.

  • GNUmakefile.am:
4:11 PM Changeset in webkit [62412] by mrobinson@webkit.org
  • 2 edits in trunk/WebCore

2010-07-02 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Build fix for GTK+. *Names.{cpp,h} targets should now include the
header files. Also adds the header files to the generated sources list.

  • GNUmakefile.am:
3:50 PM Changeset in webkit [62411] by dumi@chromium.org
  • 12 edits in trunk

WebCore: DB clean up.
https://bugs.webkit.org/show_bug.cgi?id=41404

Reviewed by Darin Fisher.

  1. Made all DatabaseTasks internal classes of Database and made the Database methods called by those tasks private.
  2. Removed the Database::stop{ed}() methods.
  3. Removed the code that kept track of open databases from ScriptExecutionContext (no longer needed).
  4. Made minor changes to Database::closeImmediately() to make it possible for DatabaseThread to call that method instead of close().
  5. Minor fix to DatabaseTracker: addOpenDatabase() should call OriginQuotaManager::addDatabase() if the origin quota manager is not tracking this origin.
  6. Removed Database::performPolicyChecks(). We already update the DB size after each transaction, and we enforce a max size for the DB at the beginning of each transaction.
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::stopDatabases):

  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::hasOpenDatabases):

  • storage/Database.cpp:

(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::close):
(WebCore::Database::closeImmediately):

  • storage/Database.h:
  • storage/DatabaseTask.cpp:

(WebCore::DatabaseTask::performTask):
(WebCore::Database::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::Database::DatabaseOpenTask::doPerformTask):
(WebCore::Database::DatabaseOpenTask::debugTaskName):
(WebCore::Database::DatabaseCloseTask::DatabaseCloseTask):
(WebCore::Database::DatabaseCloseTask::doPerformTask):
(WebCore::Database::DatabaseCloseTask::debugTaskName):
(WebCore::Database::DatabaseTransactionTask::DatabaseTransactionTask):
(WebCore::Database::DatabaseTransactionTask::doPerformTask):
(WebCore::Database::DatabaseTransactionTask::debugTaskName):
(WebCore::Database::DatabaseTableNamesTask::DatabaseTableNamesTask):
(WebCore::Database::DatabaseTableNamesTask::doPerformTask):
(WebCore::Database::DatabaseTableNamesTask::debugTaskName):

  • storage/DatabaseTask.h:

(WebCore::Database::DatabaseOpenTask::create):
(WebCore::Database::DatabaseCloseTask::create):
(WebCore::Database::DatabaseTransactionTask::create):
(WebCore::Database::DatabaseTableNamesTask::create):

  • storage/DatabaseThread.cpp:

(WebCore::DatabaseThread::databaseThread):

  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::addOpenDatabase):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::executeSQL):
(WebCore::SQLTransaction::checkAndHandleClosedDatabase):

LayoutTests: Minor change to a DB test to make it run correctly with run-webkit-tests --iterations N.
https://bugs.webkit.org/show_bug.cgi?id=41404

Reviewed by Darin Fisher.

  • storage/open-database-creation-callback.html:
3:31 PM Changeset in webkit [62410] by oliver@apple.com
  • 9 edits in trunk

2010-07-02 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Move BOM handling out of the lexer and parser
https://bugs.webkit.org/show_bug.cgi?id=41539

Doing the BOM stripping in the lexer meant that we could
end up having to strip the BOMs from a source multiple times.
To deal with this we now require all strings provided by
a SourceProvider to already have had the BOMs stripped.
This also simplifies some of the lexer logic.

  • parser/Lexer.cpp: (JSC::Lexer::setCode): (JSC::Lexer::sourceCode):
  • parser/SourceProvider.h: (JSC::SourceProvider::SourceProvider): (JSC::UStringSourceProvider::create): (JSC::UStringSourceProvider::getRange): (JSC::UStringSourceProvider::UStringSourceProvider):
  • wtf/text/StringImpl.h: (WebCore::StringImpl::copyStringWithoutBOMs):

2010-07-02 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Move BOM handling out of the lexer and parser
https://bugs.webkit.org/show_bug.cgi?id=41539

Update WebCore to ensure that SourceProviders don't
produce strings with BOMs in them.

  • bindings/js/ScriptSourceProvider.h: (WebCore::ScriptSourceProvider::ScriptSourceProvider):
  • bindings/js/StringSourceProvider.h: (WebCore::StringSourceProvider::StringSourceProvider):
  • loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript): (WebCore::CachedScript::script):
  • loader/CachedScript.h: (WebCore::CachedScript::): CachedScript now stores decoded data with the BOMs stripped, and caches the presence of BOMs across memory purges.
3:18 PM Changeset in webkit [62409] by Dimitri Glazkov
  • 3 edits
    3 adds in trunk/LayoutTests

2010-07-02 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Provide new expectations for ports that don't handle "Enter-on-select" in the same way as Safari.
https://bugs.webkit.org/show_bug.cgi?id=39532

  • platform/chromium-win/fast/forms/implicit-submission-expected.txt: Added.
  • platform/gtk/Skipped: Unskipped the test.
  • platform/gtk/fast/forms/implicit-submission-expected.txt: Added.
  • platform/qt/Skipped: Unskipped the test.
  • platform/qt/fast/forms/implicit-submission-expected.txt: Added.
3:03 PM Changeset in webkit [62408] by zmo@google.com
  • 2 edits in trunk/LayoutTests

Reviewed by David Levin.

fast/canvas/webgl/program-test.html failed on leopard bot
https://bugs/webkit.org/show_bug.cgi?id=41542

  • platform/mac-leopard/Skipped: Skip the failing test for now.
2:58 PM Changeset in webkit [62407] by weinig@apple.com
  • 2 edits in trunk/WebCore

Add missing symbol to exports file.

  • WebCore.base.exp:
2:54 PM Changeset in webkit [62406] by weinig@apple.com
  • 6 edits in trunk/WebKit2

Patch for https://bugs.webkit.org/show_bug.cgi?id=41540
WebKit2: Add InjectedCode API to get a list of subframes

Reviewed by Oliver Hunt.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCopyChildFrames):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::childFrameRef):
(WebKit::childFrameDeref):
(WebKit::WebFrame::childFrames):

  • WebProcess/WebPage/WebFrame.h:
  • mac/WebKit2.exp:
2:34 PM Changeset in webkit [62405] by ggaren@apple.com
  • 5 edits in trunk/JavaScriptCore

[ Updated after rollout. ]

Patch by Renata Hodovan <reni@inf.u-szeged.hu> on 2010-07-02
Reviewed by Oliver Hunt.

Merged RegExp constructor and RegExp::create methods.
Both functions are called with three parameters and check whether
flags (the third param) is given or not.
Avoid extra hash lookups in RegExpCache::create by passing a pre-computed
iterator parameter.
https://bugs.webkit.org/show_bug.cgi?id=41055

  • runtime/RegExp.cpp:

(JSC::RegExp::RegExp):

  • runtime/RegExp.h:
  • runtime/RegExpCache.cpp:

(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::create):

  • runtime/RegExpCache.h:
2:31 PM Changeset in webkit [62404] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

2:29 PM Changeset in webkit [62403] by mrowe@apple.com
  • 1 copy in tags/Safari-534.2

New tag.

2:11 PM Changeset in webkit [62402] by bweinstein@apple.com
  • 5 edits in trunk/LayoutTests

Update some Windows layout test results after r62215 - adding the .dataset
DOM property.

Rubber-stamped by Anders Carlsson.

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
1:43 PM Changeset in webkit [62401] by Dimitri Glazkov
  • 3 edits in trunk/LayoutTests

2010-07-02 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Add fast/forms/implicit-submission.html to Gtk and Qt Skipped list,
because their behaviors are platform-specific and don't match
expected results.
https://bugs.webkit.org/show_bug.cgi?id=39532

  • platform/gtk/Skipped: Added fast/forms/implicit-submission.html.
  • platform/qt/Skipped: Ditto.
1:39 PM Changeset in webkit [62400] by bweinstein@apple.com
  • 2 edits in trunk/WebKitTools

Some http tests fail on Windows with Cygwin 1.7
https://bugs.webkit.org/show_bug.cgi?id=41537

Reviewed by Steve Falkenburg.

With Cygwin 1.7, the registry key at SOFTWARE
Cygnus Solutions
Cygwin
mounts v2
/
doesn't exist anymore, because the mount points are stored in /etc/fstab. However, we
just need root mount point, which is defined in SOFTWARE
Cygwin
setup.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(resolveCygwinPath): Fall back to SOFTWARE
Cygwin
setup if

SOFTWARE
Cygnus Solutions
Cygwin
mounts v2
/ doesn't work.

12:51 PM Changeset in webkit [62399] by jschuh@chromium.org
  • 5 edits
    2 adds in trunk

2010-07-02 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Fisher.

Remove the extra setFailed() call in JPEG decoder to prevent
re-using an already freed object.
https://bugs.webkit.org/show_bug.cgi?id=41487

Test: fast/images/large-size-image-crash.html

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode):

2010-07-02 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Fisher.

Tests that images with large width and height values do not result in crash.
Skip layout test for mac and win since it needs to be fixed at image decoder layer for Safari.
https://bugs.webkit.org/show_bug.cgi?id=41487

  • fast/images/large-size-image-crash-expected.txt: Added.
  • fast/images/large-size-image-crash.html: Added.
  • fast/images/resources/large-size-image-crash.jpeg: Added.
  • platform/mac/Skipped:
  • platform/win/Skipped:
12:45 PM Changeset in webkit [62398] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk

2010-07-02 Peter Beverloo <peter@lvp-media.com>

Reviewed by Maciej Stachowiak.

Add the HTML5 <mark> element. Text content of the element will have
a yellow background color and black text.

Tests for <p> closing, phrasing child content and residual style.

  • fast/html/mark-element-expected.txt: Added.
  • fast/html/mark-element.html: Added.
  • fast/html/script-tests/mark-element.js: Added.

2010-07-02 Peter Beverloo <peter@lvp-media.com>

Reviewed by Maciej Stachowiak.

Add the HTML5 <mark> element. Text content of the element will have
a yellow background color and black text.

Test: fast/html/mark-element.html
Tests for <p> closing, phrasing child content and residual style.

  • css/html.css: (mark):
  • html/HTMLElement.cpp: (WebCore::inlineTagList):
  • html/HTMLTagNames.in:
  • html/LegacyHTMLTreeBuilder.cpp: (WebCore::LegacyHTMLTreeBuilder::getNode): (WebCore::LegacyHTMLTreeBuilder::isInline): (WebCore::LegacyHTMLTreeBuilder::isResidualStyleTag):
12:24 PM Changeset in webkit [62397] by zmo@google.com
  • 9 edits
    1 add in trunk

2010-07-02 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Fix issues in boundary situations for WebGLRenderingContext::drawArrays/drawElements
https://bugs.webkit.org/show_bug.cgi?id=41473

  • fast/canvas/webgl/draw-arrays-out-of-bounds-expected.txt: Test against overflow, size-0 buffer, and count==0 situations.
  • fast/canvas/webgl/draw-arrays-out-of-bounds.html: Ditto.
  • fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt: Ditto.
  • fast/canvas/webgl/draw-elements-out-of-bounds.html: Ditto.

2010-07-02 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Fix issues in boundary situations for WebGLRenderingContext::drawArrays/drawElements
https://bugs.webkit.org/show_bug.cgi?id=41473

  • WebCore.gypi: Add CheckedInt.h.
  • WebCore.xcodeproj/project.pbxproj: Add CheckedInt.h.
  • html/canvas/CheckedInt.h: Added support of safe integer operations. (mozilla::CheckedInt_internal::integer_type_manually_recorded_info::): (mozilla::CheckedInt_internal::is_unsupported_type::): (mozilla::CheckedInt_internal::): (mozilla::CheckedInt_internal::integer_traits::): (mozilla::CheckedInt_internal::integer_traits::min): (mozilla::CheckedInt_internal::integer_traits::max): (mozilla::CheckedInt_internal::has_sign_bit): (mozilla::CheckedInt_internal::binary_complement): (mozilla::CheckedInt_internal::is_in_range): (mozilla::CheckedInt_internal::is_add_valid): (mozilla::CheckedInt_internal::is_sub_valid): (mozilla::CheckedInt_internal::is_mul_valid): (mozilla::CheckedInt_internal::is_div_valid): (mozilla::CheckedInt::CheckedInt): (mozilla::CheckedInt::value): (mozilla::CheckedInt::valid): (mozilla::CheckedInt::operator -): (mozilla::CheckedInt::operator ==): (mozilla::CheckedInt::operator !=): (mozilla::operator /): (mozilla::cast_to_CheckedInt_impl::run): (mozilla::): (mozilla::cast_to_CheckedInt): (mozilla::operator ==):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateIndexArrayConservative): Fix a bug against 0-size buffer situation. (WebCore::WebGLRenderingContext::drawArrays): Deal with overflows and count==0 situation. (WebCore::WebGLRenderingContext::drawElements): Deal with count==0 situation.
12:06 PM Changeset in webkit [62396] by zmo@google.com
  • 7 edits
    2 adds in trunk

2010-07-02 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

linkProgram should fail when vertex/fragment shaders are not both present
https://bugs.webkit.org/show_bug.cgi?id=41380

  • fast/canvas/webgl/program-test-expected.txt: Added.
  • fast/canvas/webgl/program-test.html: Added.

2010-07-02 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

linkProgram should fail when vertex/fragment shaders are not both present
https://bugs.webkit.org/show_bug.cgi?id=41380

Test: fast/canvas/webgl/program-test.html

  • html/canvas/WebGLProgram.cpp: Add flag for link failure due to missing shaders. (WebCore::WebGLProgram::WebGLProgram):
  • html/canvas/WebGLProgram.h: Add interface for linkFailure flag. (WebCore::WebGLProgram::isLinkFailureFlagSet): (WebCore::WebGLProgram::setLinkFailureFlag):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getProgramParameter): Intercept when linkFailureFlag is set. (WebCore::WebGLRenderingContext::linkProgram): Check if there are missing shaders and don't link if yes.
  • html/canvas/WebGLShader.cpp: Cache shader type. (WebCore::WebGLShader::WebGLShader):
  • html/canvas/WebGLShader.h: Ditto. (WebCore::WebGLShader::getType):
12:00 PM Changeset in webkit [62395] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Turn off the Objective-C garbage collection for the WebProcess.

Reviewed by Anders Carlsson.

  • Configurations/WebProcess.xcconfig:
  • WebProcess/Launching/mac/WebProcessMain.mm:

(main): Assert that GC is off.

11:54 AM CodeReview created by ojan@chromium.org
11:47 AM Changeset in webkit [62394] by commit-queue@webkit.org
  • 6 edits in trunk

2010-07-02 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Failed on http://philip.html5.org/tests/canvas/suite/tests/2d.drawImage.negativesource.html

Remove the following test case from Skipped:
canvas/philip/tests/2d.drawImage.negativedest.html
canvas/philip/tests/2d.drawImage.negativedir.html
canvas/philip/tests/2d.drawImage.negativesource.html

  • platform/qt/Skipped:

2010-07-02 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Failed on http://philip.html5.org/tests/canvas/suite/tests/2d.drawImage.negativesource.html

Support negative width and height in canvas image draw

  • platform/graphics/FloatRect.h:
  • platform/graphics/qt/FloatRectQt.cpp: (WebCore::FloatRect::normalized):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
11:43 AM Changeset in webkit [62393] by weinig@apple.com
  • 2 edits in trunk/WebKit2

There is no longer a reason to check that the process is valid when posting
a message to the bundle, the process code will take care of that for us.

Reviewed by Anders Carlsson.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::postMessageToInjectedBundle):

11:42 AM WikiStart edited by ojan@chromium.org
(diff)
11:42 AM Changeset in webkit [62392] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Use send instead of connection()->send(), now that connections() are created
asynchronously it can be null at this point and the message needs to be queued.

Reviewed by Anders Carlsson.

  • UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::WebProcessProxy::setUpAcceleratedCompositing):

11:06 AM Changeset in webkit [62391] by Dimitri Glazkov
  • 7 edits in trunk

2010-06-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Alexey Proskuryakov.

REGRESSION: Enter does not trigger submit of forms when focus is on select.
https://bugs.webkit.org/show_bug.cgi?id=39532

  • fast/forms/implicit-submission-expected.txt: Updated.
  • fast/forms/implicit-submission.html: Added more test coverage for selects.

2010-06-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Alexey Proskuryakov.

REGRESSION: Enter does not trigger submit of forms when focus is on select.
https://bugs.webkit.org/show_bug.cgi?id=39532

Restore behavior where hitting "Enter" on a select element attempts to submit
form implicitly.

  • dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler): Added htmlForm argument,

and attempting to submit implicitly.

(WebCore::SelectElement::listBoxDefaultEventHandler): Ditto.
(WebCore::SelectElement::defaultEventHandler): Plumbed through htmlForm argument.

  • dom/SelectElement.h: Added htmlForm argument to method declaration.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::defaultEventHandler): Changed to provide submitting form

as the argument.

10:30 AM Changeset in webkit [62390] by tkent@chromium.org
  • 5 edits in trunk

2010-07-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Support indeterminate checkbox for Linux, and a small fix for Windows
https://bugs.webkit.org/show_bug.cgi?id=41508

  • platform/chromium/test_expectations.txt: fast/forms/indeterminate.html fails temporarily.

2010-07-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Support indeterminate checkbox for Linux, and a small fix for Windows
https://bugs.webkit.org/show_bug.cgi?id=41508

  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintCheckbox): Use dedicated images for indeterminate states.
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::determineClassicState): Do not use DFCS_CHECKED in a case of indeterminate state in order to have consistent appearance of indeterminate checkbox.
10:21 AM Changeset in webkit [62389] by mrobinson@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-07-02 Martin Robinson <mrobinson@igalia.com>

Unreviewed. Build fix for GTK+.

Build Lexer.lut.h with the rest of the .lut.h files. Later these should
all probably be moved to DerivedSources.

  • GNUmakefile.am:
10:14 AM Changeset in webkit [62388] by bfulgham@webkit.org
  • 3 edits
    1 add in trunk/WebCore

Fixes https://bugs.webkit.org/show_bug.cgi?id=41323.
Provides an implementation of the 'squiggle' used for
bad grammar or spelling, based on the Pango logic used
by the GTK builds.

Reviewed by Gustavo Noronha Silva.

No new tests. Covered by LayoutTests/editing/spelling

  • WebCore.vcproj/WebCore.vcproj: Add new file holding underline

implementation, set to build only for WinCairo port.

  • platform/graphics/cairo/DrawErrorUnderline.cpp: Added.

(drawErrorUnderline): New file containing the squiggle drawing
logic based on the Pango implementation. Placed in its own file
to isolate licenses.

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
Have WinCairo build call new 'drawErrorUnderline' implementation.

9:53 AM Changeset in webkit [62387] by mrobinson@webkit.org
  • 10 edits in trunk

2010-06-23 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Separate DerivedSources per-project
https://bugs.webkit.org/show_bug.cgi?id=41109

Separate WebKitGTK+ DerivedSources into per-project subdirectories to prepare
for properly building WebKit2.

  • GNUmakefile.am:

2010-06-23 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Separate DerivedSources per-project
https://bugs.webkit.org/show_bug.cgi?id=41109

Generate JavaScriptCore derived sources in <builddir>/DerivedSources/JavaScriptCore.

  • GNUmakefile.am:

2010-06-23 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Separate DerivedSources per-project
https://bugs.webkit.org/show_bug.cgi?id=41109

Generate WebCore derived sources in <builddir>/DerivedSources/WebCore.

  • GNUmakefile.am:

2010-06-23 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Separate DerivedSources per-project
https://bugs.webkit.org/show_bug.cgi?id=41109

Separate WebKitGTK+ DerivedSources into per-project subdirectories to prepare
for properly building WebKit2.

  • webkitmarshal.list: Touch this file to force a rebuild of the marshaling code.

2010-06-23 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Separate DerivedSources per-project
https://bugs.webkit.org/show_bug.cgi?id=41109

The JavaScriptCore cppflags used to include the top-level DerivedSources directory
allowing the tools to build as a side-effect. Now that the top-level directory
is no longer in the list of JavaScriptCore includes, include it explicitly.

  • GNUmakefile.am:
9:45 AM Changeset in webkit [62386] by ddkilzer@apple.com
  • 3 edits
    3 adds in trunk

2010-07-02 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

The alternativeFrameLocation value is wrong in the emitDisjunction function in
case of PatternTerm::TypeParentheticalAssertion. This value needs to be
computed from term.frameLocation instead of term.inputPosition. This mistake caused glibc
memory corruption in some cases.
Layout test added for checking of TypeParentheticalAssertion case.
https://bugs.webkit.org/show_bug.cgi?id=41458

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::ByteCompiler::emitDisjunction):

2010-07-02 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

The alternativeFrameLocation value is wrong in the emitDisjunction function in
case of PatternTerm::TypeParentheticalAssertion. This value needs to be
computed from term.frameLocation instead of term.inputPosition. This mistake caused glibc
memory corruption in some cases.
Layout test added for checking of TypeParentheticalAssertion case.
https://bugs.webkit.org/show_bug.cgi?id=41458

  • fast/js/regexp-look-ahead-expected.txt: Added.
  • fast/js/regexp-look-ahead.html: Added.
  • fast/js/script-tests/regexp-look-ahead.js: Added.
9:35 AM Changeset in webkit [62385] by zmo@google.com
  • 6 edits
    4 adds in trunk

2010-07-02 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Implement OpenGL ES 2.0 semantics for vertex attribute 0
https://bugs.webkit.org/show_bug.cgi?id=41300

  • fast/canvas/webgl/gl-bind-attrib-location-test-expected.txt: Added.
  • fast/canvas/webgl/gl-bind-attrib-location-test.html: Added.
  • fast/canvas/webgl/gl-vertex-attrib-expected.txt: Added.
  • fast/canvas/webgl/gl-vertex-attrib.html: Added.

2010-07-02 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Implement OpenGL ES 2.0 semantics for vertex attribute 0
https://bugs.webkit.org/show_bug.cgi?id=41300

Test: fast/canvas/webgl/gl-bind-attrib-location-test.html

fast/canvas/webgl/gl-vertex-attrib.html

  • html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::numActiveAttribLocations): const. (WebCore::WebGLProgram::getActiveAttribLocation): const. (WebCore::WebGLProgram::isUsingVertexAttrib0): Determine whether vertex attrib 0 is used by the program.
  • html/canvas/WebGLProgram.h: Declare isUsingVertexAttrib0.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Deal with vertex attrib 0. (WebCore::WebGLRenderingContext::disableVertexAttribArray): Ditto. (WebCore::WebGLRenderingContext::drawArrays): Ditto. (WebCore::WebGLRenderingContext::drawElements): Ditto. (WebCore::WebGLRenderingContext::getVertexAttrib): Use cached value instead of calling glGetVertexAtrtrib. (WebCore::WebGLRenderingContext::vertexAttrib1f): Validate input, deal with vertex attrib 0. (WebCore::WebGLRenderingContext::vertexAttrib1fv): Ditto. (WebCore::WebGLRenderingContext::vertexAttrib2f): Ditto. (WebCore::WebGLRenderingContext::vertexAttrib2fv): Ditto. (WebCore::WebGLRenderingContext::vertexAttrib3f): Ditto. (WebCore::WebGLRenderingContext::vertexAttrib3fv): Ditto. (WebCore::WebGLRenderingContext::vertexAttrib4f): Ditto. (WebCore::WebGLRenderingContext::vertexAttrib4fv): Ditto. (WebCore::WebGLRenderingContext::vertexAttribPointer): Ditto. (WebCore::WebGLRenderingContext::handleNPOTTextures): Move isGLES2Compliant() to caller. (WebCore::WebGLRenderingContext::vertexAttribImpl): Helper for vertexAttribNfv. (WebCore::WebGLRenderingContext::initVertexAttrib0): Initialize vertex attrib 0. (WebCore::WebGLRenderingContext::simulateVertexAttrib0): Simulate vertex attrib 0. (WebCore::WebGLRenderingContext::restoreStatesAfterVertexAttrib0Simulation): Restore states after simulating vertex attrib 0.
  • html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::VertexAttribState::VertexAttribState): Tracking full vertex attrib states. (WebCore::WebGLRenderingContext::VertexAttribState::initValue): Init value to [0,0,0,1].
9:20 AM Changeset in webkit [62384] by zmo@google.com
  • 8 edits in trunk

2010-07-02 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Need to validate the size of the incoming arrays for uniform* functions
https://bugs.webkit.org/show_bug.cgi?id=41383

  • fast/canvas/webgl/gl-uniform-arrays-expected.txt: Test against invalid array size.
  • fast/canvas/webgl/gl-uniform-arrays.html: Ditto.
  • fast/canvas/webgl/gl-uniformmatrix4fv-expected.txt: Ditto.
  • fast/canvas/webgl/gl-uniformmatrix4fv.html: Ditto.

2010-07-02 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Need to validate the size of the incoming arrays for uniform* functions
https://bugs.webkit.org/show_bug.cgi?id=41383

  • html/canvas/WebGLRenderingContext.cpp: Validate input array size. (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv): (WebCore::WebGLRenderingContext::validateUniformParameters): (WebCore::WebGLRenderingContext::validateUniformMatrixParameters):
  • html/canvas/WebGLRenderingContext.h: Add helper functions.
8:15 AM Changeset in webkit [62383] by vestbo@webkit.org
  • 4 edits in trunk

[Qt] Canvas arcTo() should draw straight line to p1 if p0, p1 and p2 are collinear

Reviewed by Simon Hausmann.

The implementation of PathQt's addArcTo() was not float-safe and also had
a case where it drew an 'infinite' line, which is not part of the spec.

http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arcto

We now use qFuzzyCompare() in both cases. The method isPointOnPathBorder()
also had the same problem, and was refactored a bit in the process of fixing
the bug.

Initial patch by Andreas Kling.

https://bugs.webkit.org/show_bug.cgi?id=41412

7:11 AM Changeset in webkit [62382] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore/qt

2010-07-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Compilation fix.

QScriptEnginePrivate::newArray can't be const because it can
throw an exception.

[Qt] QScriptEnginePrivate compilation fix
https://bugs.webkit.org/show_bug.cgi?id=41520

  • api/qscriptengine_p.cpp: (QScriptEnginePrivate::newArray):
  • api/qscriptengine_p.h:
6:56 AM Changeset in webkit [62381] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-02 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rebaseline html5lib/runner.html on Chromium Mac.

  • platform/chromium-mac/html5lib/runner-expected.txt:
4:43 AM Changeset in webkit [62380] by yurys@chromium.org
  • 10 edits
    4 adds in trunk

2010-07-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: inspected page crashes on attempt to change iframe's src attribute
https://bugs.webkit.org/show_bug.cgi?id=41511

  • fast/events/popup-blocked-from-fake-user-gesture-expected.txt: Added.
  • fast/events/popup-blocked-from-fake-user-gesture.html: Added.
  • http/tests/inspector/change-iframe-src-expected.txt: Added.
  • http/tests/inspector/change-iframe-src.html: Added.

2010-07-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: inspected page crashes on attempt to change iframe's src attribute
https://bugs.webkit.org/show_bug.cgi?id=41511

Tests: fast/events/popup-blocked-from-fake-user-gesture.html

http/tests/inspector/change-iframe-src.html

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): use V8Proxy from the ScriptController instead of one from the call stack. Get event directly from hidden property to avoid unnecessary checks.
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler):
  • bindings/v8/V8HiddenPropertyName.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::eventAccessorGetter): (WebCore::V8DOMWindow::eventAccessorSetter):

2010-07-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: inspected page crashes on attempt to change iframe's src attribute
https://bugs.webkit.org/show_bug.cgi?id=41511

  • src/WebBindings.cpp: (WebKit::getEvent):
4:36 AM Changeset in webkit [62379] by yurys@chromium.org
  • 3 edits in trunk/LayoutTests

2010-07-02 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rebaseline html5lib/runner.html

  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-win/html5lib/runner-expected.txt:
3:47 AM QtWebKitBugs edited by Simon Hausmann
(diff)
3:43 AM QtWebKitTriageRoster edited by Simon Hausmann
(diff)
3:38 AM Changeset in webkit [62378] by abarth@webkit.org
  • 6 edits in trunk

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix tokenization of <!----->
https://bugs.webkit.org/show_bug.cgi?id=41505

Test progression plus reduced test case.

  • html5lib/resources/comments01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix tokenization of <!----->
https://bugs.webkit.org/show_bug.cgi?id=41505

I noticed this error when browsing through the HTML5lib failures.
We're adding an extra character to the comment token, contrary to what
the spec says to do.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken):
3:37 AM Changeset in webkit [62377] by Simon Hausmann
  • 6 edits
    1 add in trunk/JavaScriptCore/qt

Implement exception reporting in the QtScript API.

Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2010-06-28
Reviewed by Simon Hausmann.

The exception should be accessible through the API by the uncaughtException
function. Functions; hasUncaughtException, clearExceptions, uncaughtExceptionLineNumber,
uncaughtExceptionBacktrace were added to facilitate error checking and debugging.

[Qt] QtScript API should be exceptions aware.
https://bugs.webkit.org/show_bug.cgi?id=41199

  • api/qscriptengine.cpp:

(QScriptEngine::hasUncaughtException):
(QScriptEngine::uncaughtException):
(QScriptEngine::clearExceptions):
(QScriptEngine::uncaughtExceptionLineNumber):
(QScriptEngine::uncaughtExceptionBacktrace):

  • api/qscriptengine.h:
  • api/qscriptengine_p.cpp:

(QScriptEnginePrivate::QScriptEnginePrivate):
(QScriptEnginePrivate::~QScriptEnginePrivate):
(QScriptEnginePrivate::uncaughtException):

  • api/qscriptengine_p.h:

(QScriptEnginePrivate::):
(QScriptEnginePrivate::evaluate):
(QScriptEnginePrivate::hasUncaughtException):
(QScriptEnginePrivate::clearExceptions):
(QScriptEnginePrivate::setException):
(QScriptEnginePrivate::uncaughtExceptionLineNumber):
(QScriptEnginePrivate::uncaughtExceptionBacktrace):

  • api/qscriptvalue_p.h:

(QScriptValuePrivate::toString):
(QScriptValuePrivate::toNumber):
(QScriptValuePrivate::toObject):
(QScriptValuePrivate::equals):
(QScriptValuePrivate::instanceOf):
(QScriptValuePrivate::call):
(QScriptValuePrivate::inherits):

  • tests/qscriptengine/tst_qscriptengine.cpp:

(tst_QScriptEngine::uncaughtException):

3:26 AM Changeset in webkit [62376] by abarth@webkit.org
  • 5 edits in trunk

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement processFakePEndTagIfPInScope
https://bugs.webkit.org/show_bug.cgi?id=41503

See test progression.

  • html5lib/runner-expected-html5.txt:

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement processFakePEndTagIfPInScope
https://bugs.webkit.org/show_bug.cgi?id=41503

This is a common idiom because <p> likes to close itself.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processFakePEndTagIfPInScope): (WebCore::HTMLTreeBuilder::processStartTag):
  • html/HTMLTreeBuilder.h:
3:14 AM Changeset in webkit [62375] by abarth@webkit.org
  • 7 edits in trunk

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement AfterAfterBodyMode
https://bugs.webkit.org/show_bug.cgi?id=41501

The AfterAfterBodyMode doesn't seem to be well-covered by the existing
HTML5lib tests, so I added a few more tests to cover it. It's somewhat
hard to observe. The only way I can figure out to observe it is where
the comment elements get attached to the DOM.

  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/webkit-resumer-expected.txt:

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement AfterAfterBodyMode
https://bugs.webkit.org/show_bug.cgi?id=41501

In implementing this mode, I noticed a bug in the character processing
of the AfterBodyMode, which I fixed by adding a break statement. Also,
to get one of the new tests to pass, I needed to implement one
notImplemented() in the InBody insertion mode. Yay for testing.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processComment): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
3:02 AM Changeset in webkit [62374] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62371.
http://trac.webkit.org/changeset/62371
https://bugs.webkit.org/show_bug.cgi?id=41515

"Breaks media/controls-drag-timebar.html on 32-Bit Release"
(Requested by philn-tp on #webkit).

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::maxTimeSeekable): (WebCore::MediaPlayerPrivateGStreamer::updateStates):
2:51 AM QtWebKitWeeklyBuilds edited by Simon Hausmann
(diff)
2:49 AM QtWebKitWeeklyBuilds edited by Simon Hausmann
(diff)
2:42 AM QtWebKitJournal edited by Simon Hausmann
(diff)
2:42 AM QtWebKitWeeklyBuilds created by Simon Hausmann
2:42 AM QtWebKitJournal edited by Simon Hausmann
(diff)
2:36 AM Changeset in webkit [62373] by yurys@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

2010-07-02 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Remove accidentally added expectations on Chromium Linux - they should be derived from Windows ones.

  • platform/chromium-linux/html5lib/runner-expected.txt: Removed.
2:29 AM Changeset in webkit [62372] by yurys@chromium.org
  • 3 edits
    1 copy
    1 add in trunk/LayoutTests

2010-07-02 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-linux/html5lib/runner-expected.txt: Added.
  • platform/chromium-win/html5lib/runner-expected.txt:
  • platform/chromium/test_expectations.txt:
1:48 AM Changeset in webkit [62371] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-06-28 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GStreamer] can't seek past maxTimeLoaded value
https://bugs.webkit.org/show_bug.cgi?id=40526

Extended the seekable range to the whole media. This allows video
played with progressive download to be seeked past the current
buffered position.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::maxTimeSeekable): (WebCore::MediaPlayerPrivateGStreamer::updateStates):
1:29 AM Changeset in webkit [62370] by abarth@webkit.org
  • 8 edits in trunk

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement AfterBodyMode for HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=41500

Update expected results to show test progression. Also, add some test
cases to cover how attributes on </br> tags are handled.

  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/webkit-resumer-expected.txt:

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement AfterBodyMode for HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=41500

In the coarse of implementing this state, I ran into an ASSERT in how
</br> tags where handled, which I fixed. Technically, that could be a
separate patch, but it seemed harmless to include it here (with tests).

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processComment): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile): (WebCore::HTMLTreeBuilder::insertCommentOnHTMLHtmlElement):
  • html/HTMLTreeBuilder.h:
1:14 AM Changeset in webkit [62369] by abarth@webkit.org
  • 4 edits in trunk

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Handle <base> and friends in AfterHeadMode
https://bugs.webkit.org/show_bug.cgi?id=41502

See test progression. Fun game.

  • html5lib/runner-expected-html5.txt:

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Handle <base> and friends in AfterHeadMode
https://bugs.webkit.org/show_bug.cgi?id=41502

Implement notImplemented() per spec.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):

Jul 1, 2010:

11:47 PM Changeset in webkit [62368] by oliver@apple.com
  • 2 edits in trunk/WebCore

Chromium build fix.

11:31 PM Changeset in webkit [62367] by oliver@apple.com
  • 18 edits
    3 adds in trunk

2010-07-01 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Add a FixedArray template to encapsulate fixed length arrays
https://bugs.webkit.org/show_bug.cgi?id=41506

This new type is used in place of fixed length C arrays so
that debug builds can guard against attempts to go beyond
the end of the array.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/Opcode.cpp: (JSC::OpcodeStats::~OpcodeStats):
  • pcre/pcre_compile.cpp: (calculateCompiledPatternLength):
  • runtime/Collector.cpp: (JSC::Heap::allocateBlock): (JSC::Heap::allocate):
  • runtime/Collector.h: (JSC::CollectorBitmap::clearAll):
  • runtime/CollectorHeapIterator.h: (JSC::CollectorHeapIterator::operator*):
  • runtime/DateInstanceCache.h:
  • runtime/JSString.cpp: (JSC::JSString::replaceCharacter):
  • runtime/JSString.h: (JSC::RopeBuilder::JSStringFinalizerStruct::):
  • runtime/NumericStrings.h:
  • runtime/RegExpCache.h:
  • runtime/SmallStrings.h: (JSC::SmallStrings::singleCharacterStrings):
  • wtf/AVLTree.h:
  • wtf/FixedArray.h: Added. (WTF::FixedArray::operator[]): (WTF::FixedArray::data):

2010-07-01 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Add a FixedArray template to encapsulate fixed length arrays
https://bugs.webkit.org/show_bug.cgi?id=41506

Add forwarding header.

  • ForwardingHeaders/wtf/FixedArray.h: Added.

2010-07-01 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Add a FixedArray template to encapsulate fixed length arrays
https://bugs.webkit.org/show_bug.cgi?id=41506

Add forwarding header, and replace a few fixed length arrays
with the new FixedArray type.

  • ForwardingHeaders/wtf/FixedArray.h: Added.
  • dom/Document.h:
  • platform/graphics/GlyphMetricsMap.h:
11:17 PM Changeset in webkit [62366] by zherczeg@webkit.org
  • 2 edits in trunk/JavaScriptCore

Improve the main lexer switch by mapping input characters to their type
https://bugs.webkit.org/show_bug.cgi?id=41459

Reviewed by Oliver Hunt.

Sunsipder: no change (from 532.9ms to 531.5ms)
SunSpider --parse-only: 1.025x as fast (from 33.1ms to 32.3ms)

  • parser/Lexer.cpp:

(JSC::):
(JSC::Lexer::lex):

11:04 PM Changeset in webkit [62365] by sfalken@apple.com
  • 7 edits in trunk/WebKit/win

Provide a WebView preference to disable DNS prefetching on Windows
https://bugs.webkit.org/show_bug.cgi?id=41504
<rdar://problem/8151939>

Reviewed by Adele Peterson.

  • Interfaces/IWebPreferencesPrivate.idl: Added isDNSPrefetchingEnabled, setDNSPrefetchingEnabled.
  • Interfaces/WebKit.idl: Touched to force IDL build.
  • WebPreferenceKeysPrivate.h: Added WebKitDNSPrefetchingEnabledPreferenceKey.
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings): Default prefetch to true.
(WebPreferences::setDNSPrefetchingEnabled): Added.
(WebPreferences::isDNSPrefetchingEnabled): Added.

  • WebPreferences.h: Added isDNSPrefetchingEnabled, setDNSPrefetchingEnabled.
  • WebView.cpp:

(WebView::notifyPreferencesChanged): Propagate prefetch pref into settings.

10:16 PM Changeset in webkit [62364] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-07-01 Simon Fraser <Simon Fraser>

No review.

Fix a link warning in 32-bit by not explicitly exporting WebCore::GraphicsLayer::syncCompositingStateForThisLayerOnly().

  • WebCore.AcceleratedCompositing.exp:
10:06 PM Changeset in webkit [62363] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Even more Windows build fixing.
Removed bogus post-build event commands.
Removed unnecessary link libraries.

  • win/WebKit2.vcproj:
9:58 PM Changeset in webkit [62362] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Fix Windows while not breaking Qt (didn't realize this was building for Qt).

  • WebProcess/WebProcess.cpp:
9:54 PM Changeset in webkit [62361] by Simon Fraser
  • 4 edits in trunk/WebKitLibraries

2010-07-01 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

<rdar://problem/8154047>

Update WebKitSystemInterface, making some functions used by
WebKit2 available in 32-bit (for reals this time).

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
9:52 PM Changeset in webkit [62360] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix.

  • win/WebKit2Generated.make:
9:31 PM Changeset in webkit [62359] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix.

  • WebProcess/WebProcess.cpp:
9:21 PM Changeset in webkit [62358] by weinig@apple.com
  • 8 edits in trunk/WebKit2

Make WebKit2 compile (though not work) on Leopard.

Reviewed by Jon Honeycutt.

  • Platform/WorkQueue.h:
  • Platform/mac/WorkQueueMac.cpp:

(WorkQueue::EventSource::EventSource):
(WorkQueue::scheduleWork):
(WorkQueue::registerMachPortEventHandler):
(WorkQueue::unregisterMachPortEventHandler):
(WorkQueue::platformInitialize):
(WorkQueue::platformInvalidate):

  • UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:

(WebKit::LayerBackedDrawingAreaProxy::attachCompositingContext):

  • UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::WebProcessProxy::setUpAcceleratedCompositing):

  • WebProcess/WebPage/LayerBackedDrawingArea.cpp:

(WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea):
(WebKit::LayerBackedDrawingArea::setNeedsDisplay):

  • WebProcess/WebPage/LayerBackedDrawingArea.h:
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:

(WebKit::LayerBackedDrawingArea::platformClear):
(WebKit::LayerBackedDrawingArea::attachCompositingContext):

9:18 PM Changeset in webkit [62357] by tonyg@chromium.org
  • 14 edits
    3 copies
    3 moves in trunk/WebCore

2010-07-01 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Add window.performance.navigation namespace
https://bugs.webkit.org/show_bug.cgi?id=41442

Adds window.performance.navigation namespace consisting of ".type"
and ".redirectCount". As part of this change, I renmaed "NavigationTiming"
to just "Timing" to avoid confusion.

No new tests because tests will be added in a subsequent patch when
functionality is added.

  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Navigation.cpp: Added. (WebCore::Navigation::Navigation): (WebCore::Navigation::frame): (WebCore::Navigation::disconnectFrame): (WebCore::Navigation::type): (WebCore::Navigation::redirectCount):
  • page/Navigation.h: Added. (WebCore::Navigation::create):
  • page/Navigation.idl: Added.
  • page/NavigationTiming.cpp: Removed.
  • page/NavigationTiming.h: Removed.
  • page/NavigationTiming.idl: Removed.
  • page/Performance.cpp: (WebCore::Performance::navigation): (WebCore::Performance::timing):
  • page/Performance.h:
  • page/Performance.idl:
  • page/Timing.cpp: Added. (WebCore::Timing::Timing): (WebCore::Timing::frame): (WebCore::Timing::disconnectFrame): (WebCore::Timing::navigationStart):
  • page/Timing.h: Added. (WebCore::Timing::create):
  • page/Timing.idl: Added.
9:16 PM Changeset in webkit [62356] by Simon Fraser
  • 5 edits in trunk/WebKitLibraries

2010-07-01 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

<rdar://problem/8154047>

Update WebKitSystemInterface, making some functions used by
WebKit2 available in 32-bit.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
9:15 PM Changeset in webkit [62355] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Define HAVE_HOSTED_CORE_ANIMATION on Snow Leopard.

Rubber-stamped by Ander Carlsson.

  • wtf/Platform.h:
9:02 PM Changeset in webkit [62354] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-01 Daniel Cheng <dcheng@chromium.org>

Reviewed by Jian Li.

[chromium] Dragging a link triggers an assert when accessing event.dataTransfer.types
https://bugs.webkit.org/show_bug.cgi?id=41493

ClipboardChromium::writeURL violates ClipboardChromium's assumption that uriList will always
be non-empty if url is valid.

No new tests.

  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::writeURL):
8:51 PM Changeset in webkit [62353] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Clamp color stops passed to QGradient to 1.0
[https://bugs.webkit.org/show_bug.cgi?id=41484

Fixes an issue where color stops would be silently dropped from radial gradients.

  • platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):
8:15 PM Changeset in webkit [62352] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-07-01 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTMLTokenizer should ASSERT that it never emits a null character
https://bugs.webkit.org/show_bug.cgi?id=41448

No functional change, thus no tests. These ASSERTs would have
caught the coding error which caused the trouble in bug 41436
(which was fixed by bug 41439).

  • html/HTMLToken.h: (WebCore::HTMLToken::beginStartTag): (WebCore::HTMLToken::beginCharacter): (WebCore::HTMLToken::beginDOCTYPE): (WebCore::HTMLToken::appendToName): (WebCore::HTMLToken::appendToComment): (WebCore::HTMLToken::appendToAttributeName): (WebCore::HTMLToken::appendToAttributeValue): (WebCore::HTMLToken::appendToPublicIdentifier): (WebCore::HTMLToken::appendToSystemIdentifier):
8:12 PM Changeset in webkit [62351] by levin@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62349.
http://trac.webkit.org/changeset/62349
https://bugs.webkit.org/show_bug.cgi?id=41499

It broke the chromium Linux build. (Requested by dave_levin on
#webkit).

  • public/WebNode.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::registerPasswordListener): (WebKit::WebFrameImpl::notifiyPasswordListenerOfAutocomplete):
8:03 PM Changeset in webkit [62350] by commit-queue@webkit.org
  • 5 edits in trunk

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

Canvas: Don't paint with empty radial gradients
https://bugs.webkit.org/show_bug.cgi?id=41190

Unskip canvas/philip/tests/2d.gradient.radial.equal.html for Qt.

  • platform/qt/Skipped:

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

Canvas: Don't paint with empty radial gradients
https://bugs.webkit.org/show_bug.cgi?id=41190

If a radial gradient has x0==x1 && y0==y1 && r0==r1, don't paint with it.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fillRect):
  • platform/graphics/Gradient.h: (WebCore::Gradient::isZeroSize):
7:50 PM Changeset in webkit [62349] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-07-01 David Holloway <dhollowa@chromium.org>

Reviewed by Darin Fisher.

[chromium] Exposes WebNode::unwrap() and WebNode::constUnwrap() for
use by other code in WebKit/chromium/src.

Specific use of these methods is made in WebFrameImpl.cpp. This is
preferred to the cast operator call that was happening prior to this
change.

https://bugs.webkit.org/show_bug.cgi?id=41477

  • public/WebNode.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::registerPasswordListener): (WebKit::WebFrameImpl::notifiyPasswordListenerOfAutocomplete):
7:22 PM Changeset in webkit [62348] by tonyg@chromium.org
  • 8 edits
    1 add in trunk/WebCore

2010-07-01 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Add interface for network platform to pass up timing information
https://bugs.webkit.org/show_bug.cgi?id=41437

The Web Timing feature requires the network platform to expose detailed
timing information for the main resource. This patch adds that data to
the ResourceResponseBase. Since the 82 bytes of information is only
needed for the main resource, it is a RefPtr to avoid using the memory
for other resource types.

No new tests because no new functionality.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/ResourceLoadTiming.h: Added. (WebCore::ResourceLoadTiming::create): (WebCore::ResourceLoadTiming::deepCopy): (WebCore::ResourceLoadTiming::operator==): (WebCore::ResourceLoadTiming::operator!=): (WebCore::ResourceLoadTiming::ResourceLoadTiming):
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::adopt): (WebCore::ResourceResponseBase::copyData): (WebCore::ResourceResponseBase::resourceLoadTiming): (WebCore::ResourceResponseBase::setResourceLoadTiming): (WebCore::ResourceResponseBase::compare):
  • platform/network/ResourceResponseBase.h:
7:17 PM Changeset in webkit [62347] by mrowe@apple.com
  • 5 edits in branches/safari-533.17-branch

Versioning.

7:16 PM Changeset in webkit [62346] by mrowe@apple.com
  • 1 copy in tags/Safari-533.17.1

New tag.

6:59 PM Changeset in webkit [62345] by mrowe@apple.com
  • 1 edit in branches/safari-533.17-branch/WebCore/html/HTMLInputElement.cpp

Build fix.

6:14 PM Changeset in webkit [62344] by levin@chromium.org
  • 2 edits in trunk/LayoutTests
  • platform/chromium/test_expectations.txt: Removed a test that is passing and added a test that is now failing.

Reviewed by NOBODY (trivial test_expectations change).

5:58 PM Changeset in webkit [62343] by levin@chromium.org
  • 2 edits in trunk/LayoutTests
  • platform/chromium/test_expectations.txt: Upstreamed two test expectation issues for flaky tests.

Reviewed by NOBODY (trivial test expectation changes).

5:41 PM Changeset in webkit [62342] by mrowe@apple.com
  • 6 edits
    22 adds in branches/safari-533.17-branch

Merge r61667.

5:38 PM Changeset in webkit [62341] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.17-branch

Merge r61044.

5:36 PM Changeset in webkit [62340] by mrowe@apple.com
  • 4 edits
    1 add in branches/safari-533.17-branch

Merge r61050.

5:34 PM Changeset in webkit [62339] by mrowe@apple.com
  • 7 edits
    3 adds in branches/safari-533.17-branch

Merge r62279.

5:29 PM Changeset in webkit [62338] by mrowe@apple.com
  • 5 edits in branches/safari-533.17-branch

Merge r61654.

5:21 PM Changeset in webkit [62337] by mrowe@apple.com
  • 4 edits in branches/safari-533.17-branch/JavaScriptCore

Merge r62148.

5:21 PM Changeset in webkit [62336] by mrowe@apple.com
  • 12 edits
    3 adds in branches/safari-533.17-branch/JavaScriptCore

Merge r61623.

5:19 PM Changeset in webkit [62335] by dumi@chromium.org
  • 12 edits in trunk

2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62321.
http://trac.webkit.org/changeset/62321
https://bugs.webkit.org/show_bug.cgi?id=41494

Broke the non-win builds. (Requested by dumi on #webkit).

  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::addOpenDatabase): (WebCore::ScriptExecutionContext::removeOpenDatabase): (WebCore::ScriptExecutionContext::stopDatabases):
  • dom/ScriptExecutionContext.h:
  • storage/Database.cpp: (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::markAsDeletedAndClose): (WebCore::ContextRemoveOpenDatabaseTask::create): (WebCore::ContextRemoveOpenDatabaseTask::performTask): (WebCore::ContextRemoveOpenDatabaseTask::isCleanupTask): (WebCore::ContextRemoveOpenDatabaseTask::ContextRemoveOpenDatabaseTask): (WebCore::Database::close): (WebCore::Database::closeImmediately): (WebCore::Database::stop): (WebCore::Database::performPolicyChecks):
  • storage/Database.h: (WebCore::Database::): (WebCore::Database::stopped):
  • storage/DatabaseTask.cpp: (WebCore::DatabaseTask::performTask): (WebCore::DatabaseOpenTask::DatabaseOpenTask): (WebCore::DatabaseOpenTask::doPerformTask): (WebCore::DatabaseOpenTask::debugTaskName): (WebCore::DatabaseCloseTask::DatabaseCloseTask): (WebCore::DatabaseCloseTask::doPerformTask): (WebCore::DatabaseCloseTask::debugTaskName): (WebCore::DatabaseTransactionTask::DatabaseTransactionTask): (WebCore::DatabaseTransactionTask::~DatabaseTransactionTask): (WebCore::DatabaseTransactionTask::doPerformTask): (WebCore::DatabaseTransactionTask::debugTaskName): (WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask): (WebCore::DatabaseTableNamesTask::doPerformTask): (WebCore::DatabaseTableNamesTask::debugTaskName):
  • storage/DatabaseTask.h: (WebCore::DatabaseOpenTask::create): (WebCore::DatabaseCloseTask::create): (WebCore::DatabaseTransactionTask::create): (WebCore::DatabaseTableNamesTask::create):
  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::databaseThread):
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::addOpenDatabase):
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::executeSQL): (WebCore::SQLTransaction::checkAndHandleClosedDatabase):

2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62321.
http://trac.webkit.org/changeset/62321
https://bugs.webkit.org/show_bug.cgi?id=41494

Broke the non-win builds. (Requested by dumi on #webkit).

  • storage/open-database-creation-callback.html:
4:58 PM Changeset in webkit [62334] by mrowe@apple.com
  • 4 edits in branches/safari-533.17-branch

Merge r60882.

4:57 PM Changeset in webkit [62333] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebCore

Merge r62135.

4:55 PM Changeset in webkit [62332] by mrowe@apple.com
  • 4 edits
    8 adds in branches/safari-533.17-branch

Merge r62134.

4:53 PM Changeset in webkit [62331] by mrowe@apple.com
  • 3 edits
    4 adds in branches/safari-533.17-branch

Merge r61921.

4:52 PM Changeset in webkit [62330] by mrowe@apple.com
  • 14 edits
    1 copy
    2 adds in branches/safari-533.17-branch

Merge r59396.

4:52 PM Changeset in webkit [62329] by xan@webkit.org
  • 10 edits in trunk

WebCore:

2010-07-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Stop using GdkRegion in 3.x mode
https://bugs.webkit.org/show_bug.cgi?id=41463

Make us compile without using GdkRegion, since it's gone from GTK+
3.x.

  • platform/graphics/IntRect.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • platform/graphics/gtk/FontGtk.cpp: (WebCore::cairo_region_shrink): (WebCore::Font::drawComplexText):
  • platform/gtk/GtkPluginWidget.cpp: (WebCore::GtkPluginWidget::paint):
  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::paint):

WebKit/gtk:

2010-07-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Stop using GdkRegion in 3.x mode
https://bugs.webkit.org/show_bug.cgi?id=41463

Make us compile without using GdkRegion, since it's gone from GTK+
3.x.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::scroll):
  • webkit/webkitwebview.cpp: (webkit_web_view_expose_event):
4:50 PM Changeset in webkit [62328] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebCore

Merge r61435.

4:49 PM Changeset in webkit [62327] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebCore

Merge r61296.

4:48 PM Changeset in webkit [62326] by mrowe@apple.com
  • 3 edits
    19 adds in branches/safari-533.17-branch

Merge r60640.

4:45 PM Changeset in webkit [62325] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.17-branch

Merge r61070.

4:43 PM Changeset in webkit [62324] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.17-branch

Merge r61200.

4:42 PM Changeset in webkit [62323] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.17-branch

Merge r61189.

4:37 PM Changeset in webkit [62322] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebCore

Merge r60908.

4:33 PM Changeset in webkit [62321] by dumi@chromium.org
  • 12 edits in trunk

WebCore: DB clean up.
https://bugs.webkit.org/show_bug.cgi?id=41404

Reviewed by Darin Fisher.

  1. Made all DatabaseTasks internal classes of Database and made the Database methods called by those tasks private.
  2. Removed the Database::stop{ed}() methods.
  3. Removed the code that kept track of open databases from ScriptExecutionContext (no longer needed).
  4. Made minor changes to Database::closeImmediately() to make it possible for DatabaseThread to call that method instead of close().
  5. Minor fix to DatabaseTracker: addOpenDatabase() should call OriginQuotaManager::addDatabase() if the origin quota manager is not tracking this origin.
  6. Removed Database::performPolicyChecks(). We already update the DB size after each transaction, and we enforce a max size for the DB at the beginning of each transaction.
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::stopDatabases):

  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::hasOpenDatabases):

  • storage/Database.cpp:

(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::close):
(WebCore::Database::closeImmediately):

  • storage/Database.h:
  • storage/DatabaseTask.cpp:

(WebCore::DatabaseTask::performTask):
(WebCore::Database::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::Database::DatabaseOpenTask::doPerformTask):
(WebCore::Database::DatabaseOpenTask::debugTaskName):
(WebCore::Database::DatabaseCloseTask::DatabaseCloseTask):
(WebCore::Database::DatabaseCloseTask::doPerformTask):
(WebCore::Database::DatabaseCloseTask::debugTaskName):
(WebCore::Database::DatabaseTransactionTask::DatabaseTransactionTask):
(WebCore::Database::DatabaseTransactionTask::doPerformTask):
(WebCore::Database::DatabaseTransactionTask::debugTaskName):
(WebCore::Database::DatabaseTableNamesTask::DatabaseTableNamesTask):
(WebCore::Database::DatabaseTableNamesTask::doPerformTask):
(WebCore::Database::DatabaseTableNamesTask::debugTaskName):

  • storage/DatabaseTask.h:

(WebCore::Database::DatabaseOpenTask::create):
(WebCore::Database::DatabaseCloseTask::create):
(WebCore::Database::DatabaseTransactionTask::create):
(WebCore::Database::DatabaseTableNamesTask::create):

  • storage/DatabaseThread.cpp:

(WebCore::DatabaseThread::databaseThread):

  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::addOpenDatabase):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::executeSQL):
(WebCore::SQLTransaction::checkAndHandleClosedDatabase):

LayoutTests: Minor change to a DB test to make it run correctly with run-webkit-tests --iterations N.
https://bugs.webkit.org/show_bug.cgi?id=41404

Reviewed by Darin Fisher.

  • storage/open-database-creation-callback.html:
4:26 PM Changeset in webkit [62320] by Simon Fraser
  • 13 edits
    1 copy in trunk/WebKit2

2010-07-01 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Get accelerated compositing working with webkit2
https://bugs.webkit.org/show_bug.cgi?id=41084

Start up the CA render server in the UI process (currently, at launch time), and
pass the server port over to the web process for use by the layer-backed drawing area.

Fix some style issues pointed out by Dan Bernstein.

Implement the WebChromeClient methods that pass the attach/detach calls through
to the drawing area.

  • Shared/CoreIPCSupport/WebProcessMessageKinds.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView _startAcceleratedCompositing:]):
  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::WebProcessProxy): (WebKit::WebProcessProxy::setUpAcceleratedCompositing):
  • UIProcess/WebProcessProxy.h:
  • UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:
  • UIProcess/mac/WebProcessProxyMac.mm: Added. (WebKit::WebProcessProxy::setUpAcceleratedCompositing):
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::attachRootGraphicsLayer): (WebKit::WebChromeClient::scheduleCompositingLayerSync):
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::attachCompositingContext):
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): (WebKit::WebProcess::didReceiveMessage):
  • WebProcess/WebProcess.h: (WebKit::WebProcess::compositingRenderServerPort):
4:25 PM Changeset in webkit [62319] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533.17-branch

Merge r61060.

4:23 PM Changeset in webkit [62318] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.17-branch

Merge r60984.

4:21 PM Changeset in webkit [62317] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.17-branch

Merge r60459.

4:19 PM Changeset in webkit [62316] by mrowe@apple.com
  • 5 edits
    4 adds in branches/safari-533.17-branch

Merge r61068.

4:18 PM Changeset in webkit [62315] by levin@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests
  • platform/chromium/fast/dom/domListEnumeration-expected.txt: Added. Results differ due to a lack of a v8 binding implementation of dataset.
  • platform/chromium/test_expectations.txt: Marked the dataset tests as failing and referred the corresponding bug for them.

Reviewed by NOBODY (test fix).

4:16 PM Changeset in webkit [62314] by mrowe@apple.com
  • 6 edits
    2 adds in branches/safari-533.17-branch

Merge r60727.

4:13 PM Changeset in webkit [62313] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-07-01 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Support indeterminate checkbox for Windows
https://bugs.webkit.org/show_bug.cgi?id=41444

  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::determineState): Check isIndeterminate() and set an appropriate flag value.
4:12 PM Changeset in webkit [62312] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.17-branch

Merge r61132.

4:11 PM Changeset in webkit [62311] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebKit/mac

Merge r61204.

4:09 PM Changeset in webkit [62310] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebCore

Merge r61231.

4:09 PM Changeset in webkit [62309] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebCore

Merge r61171.

4:09 PM Changeset in webkit [62308] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebCore

Merge r61365.

3:57 PM Changeset in webkit [62307] by weinig@apple.com
  • 10 edits
    8 adds in trunk/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=41491
Add first stab at back/forward list API.

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKBackForwardList.cpp: Added.
  • UIProcess/API/C/WKBackForwardList.h: Added.
  • UIProcess/API/C/WKBackForwardListItem.cpp: Added.
  • UIProcess/API/C/WKBackForwardListItem.h: Added.
  • UIProcess/API/C/WKBase.h:
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WebKit2.h:
  • UIProcess/WebBackForwardListItem.cpp: Added.
  • UIProcess/WebBackForwardListItem.h: Added.
  • UIProcess/WebBackForwardListProxy.cpp: Added.
  • UIProcess/WebBackForwardListProxy.h: Added.
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
3:56 PM Changeset in webkit [62306] by barraclough@apple.com
  • 7 edits in trunk/JavaScriptCore

Bug 41490 - Add missing operations to MacroAssemblerARMv7
Also, make single, double, quad register numbers in ARMv7Assembler distinct & strongly typed.

Reviewed by Oliver Hunt.

  • assembler/ARMv7Assembler.h:

(JSC::ARMRegisters::):
(JSC::ARMRegisters::asSingle):
(JSC::ARMRegisters::asDouble):
(JSC::VFPImmediate::VFPImmediate):
(JSC::VFPImmediate::isValid):
(JSC::VFPImmediate::value):
(JSC::ARMv7Assembler::singleRegisterMask):
(JSC::ARMv7Assembler::doubleRegisterMask):
(JSC::ARMv7Assembler::):
(JSC::ARMv7Assembler::add_S):
(JSC::ARMv7Assembler::neg):
(JSC::ARMv7Assembler::orr_S):
(JSC::ARMv7Assembler::sub):
(JSC::ARMv7Assembler::sub_S):
(JSC::ARMv7Assembler::vadd_F64):
(JSC::ARMv7Assembler::vcmp_F64):
(JSC::ARMv7Assembler::vcvt_F64_S32):
(JSC::ARMv7Assembler::vcvtr_S32_F64):
(JSC::ARMv7Assembler::vdiv_F64):
(JSC::ARMv7Assembler::vldr):
(JSC::ARMv7Assembler::vmov_F64_0):
(JSC::ARMv7Assembler::vmov):
(JSC::ARMv7Assembler::vmul_F64):
(JSC::ARMv7Assembler::vstr):
(JSC::ARMv7Assembler::vsub_F64):
(JSC::ARMv7Assembler::vcvt):
(JSC::ARMv7Assembler::vmem):

  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssemblerARM.h:
  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::fpTempRegisterAsSingle):
(JSC::MacroAssemblerARMv7::neg32):
(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::divDouble):
(JSC::MacroAssemblerARMv7::convertInt32ToDouble):
(JSC::MacroAssemblerARMv7::branchConvertDoubleToInt32):
(JSC::MacroAssemblerARMv7::zeroDouble):
(JSC::MacroAssemblerARMv7::branchOr32):
(JSC::MacroAssemblerARMv7::set32):
(JSC::MacroAssemblerARMv7::set8):

  • assembler/MacroAssemblerMIPS.h:
  • assembler/MacroAssemblerX86Common.h:
3:36 PM Changeset in webkit [62305] by andersca@apple.com
  • 7 edits
    1 copy
    3 moves in trunk/WebKit2

Make process launching asynchronous
https://bugs.webkit.org/show_bug.cgi?id=41489

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.h:

Make OutgoingMessage public.

  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::paint):
Don't wait for a paint reply when the process is starting up.

  • UIProcess/Launcher/ProcessLauncher.cpp: Added.

Add new ProcessLauncher class.

(WebKit::processLauncherWorkQueue):
Returns the work queue where process launching will happen.

(WebKit::ProcessLauncher::ProcessLauncher):
Schedule launching the process.

(WebKit::ProcessLauncher::didFinishLaunchingProcess):
Call the client method.

(WebKit::ProcessLauncher::invalidate):
Set the client to 0.

  • UIProcess/Launcher/ProcessLauncher.h: Added.
  • UIProcess/Launcher/WebProcessLauncher.h: Removed.

Rename WebProcessLauncher.h -> ProcessLauncher.h

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm: Added.
  • UIProcess/Launcher/mac/WebProcessLauncher.mm: Removed.

Rename WebProcessLauncher.mm -> ProcessLauncherMac.mm, update for ProcessLauncher changes.

  • UIProcess/Launcher/win/ProcessLauncherWin.cpp: Added.
  • UIProcess/Launcher/win/WebProcessLauncher.cpp: Removed.

Rename WebProcessLauncher.cpp -> ProcessLauncherWin.cpp, update for ProcessLauncher changes.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::~WebProcessProxy):
Delete any unsent messages.

(WebKit::WebProcessProxy::connect):
Use the new ProcessLauncher.

(WebKit::WebProcessProxy::sendMessage):
If we're waiting for the process to launch, the messages need to be enqueued.

(WebKit::WebProcessProxy::didFinishLaunching):
Send the outgoing messages.

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Update for renames.

3:25 PM Changeset in webkit [62304] by ap@apple.com
  • 3 edits
    3 moves in trunk

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=41488
<rdar://problem/7487420> Crash in SubresourceLoader::create when load is initiated from plug-in destructor

Test: plugins/js-from-destroy.html

  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Null check active document loader.
3:23 PM Changeset in webkit [62303] by Simon Fraser
  • 10 edits
    1 copy
    5 adds in trunk/WebKit2

2010-07-01 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Get accelerated compositing working with webkit2
https://bugs.webkit.org/show_bug.cgi?id=41084

Add a new kind of DrawingArea, which is a LayerBackedDrawingArea, which will be used
when the page goes into accelerated compositing mode. It is not wired up yet.

  • Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: New 'attach' and 'detach' messages related to accelerated compositing.
  • UIProcess/API/mac/WKView.mm: (-[WKView _startAcceleratedCompositing:]): (-[WKView _stopAcceleratedCompositing]):
  • UIProcess/API/mac/WKViewInternal.h: Add a subview of the WKView which has layer-backing enabled, and put the drawing area's layer inside of that.
  • UIProcess/ChunkedUpdateDrawingAreaProxy.h: (WebKit::ChunkedUpdateDrawingAreaProxy::attachCompositingContext): (WebKit::ChunkedUpdateDrawingAreaProxy::detachCompositingContext): These methods will never be called on the ChunkedUpdateDrawingArea. Stub them out.
  • UIProcess/DrawingAreaProxy.h: Add attachCompositingContext() and detachCompositingContext() methods, and a new drawing area type to the enum.
  • UIProcess/LayerBackedDrawingAreaProxy.cpp: Added.
  • UIProcess/LayerBackedDrawingAreaProxy.h: Added.
  • UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm: Added.
  • WebKit2.xcodeproj/project.pbxproj: Add LayerBackedDrawingArea files.
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h: Add virtual methods stubs.
  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create): Create a LayerBackedDrawingArea if asked.
  • WebProcess/WebPage/DrawingArea.h: New LayerBackedDrawingAreaType type, and new virtual methods related to accelerated compositing.
  • WebProcess/WebPage/LayerBackedDrawingArea.cpp: Added.
  • WebProcess/WebPage/LayerBackedDrawingArea.h: Added.
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: Added.
3:17 PM Changeset in webkit [62302] by aestes@apple.com
  • 3 edits
    2 adds in trunk

2010-07-01 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

<rdar://problem/8113003> Correctly fire beforeload events for images
added to the DOM using .innerHTML.
https://bugs.webkit.org/show_bug.cgi?id=40919

Test: fast/dom/beforeload/image-before-load-innerHTML.html

  • html/LegacyHTMLDocumentParser.cpp: (WebCore::LegacyHTMLDocumentParser::write): Do not fire synchronous image beforeload events immediately after parsing a document fragment. Let the events fire later, giving the fragment time to potentially be inserted into the document.

2010-07-01 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.


<rdar://problem/8113003> Test that beforeload fires correctly on images
inserted into the DOM using .innerHTML.
https://bugs.webkit.org/show_bug.cgi?id=40919

  • fast/dom/beforeload/image-before-load-innerHTML-expected.txt: Added.
  • fast/dom/beforeload/image-before-load-innerHTML.html: Added.
3:02 PM Changeset in webkit [62301] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Improve reentrancy logic in polymorphic cache stubs
<https://bugs.webkit.org/show_bug.cgi?id=41482>
<rdar://problem/8094380>

Reviewed by Geoff Garen.

JavaScriptCore:

Make the polymorphic cache stubs handle reentrancy
better.

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC::getPolymorphicAccessStructureListSlot):

LayoutTests:

Test cases for cache reentry in the cache code.

  • fast/js/reentrant-caching-expected.txt: Added.
  • fast/js/reentrant-caching.html: Added.
  • fast/js/script-tests/reentrant-caching.js: Added.
2:56 PM Changeset in webkit [62300] by commit-queue@webkit.org
  • 9 edits in trunk

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

Canvas: bezierCurveTo() and quadraticCurveTo() must ensure subpaths
https://bugs.webkit.org/show_bug.cgi?id=41192

Unskipped two tests:

  • canvas/philip/tests/2d.path.bezierCurveTo.ensuresubpath.2.html
  • canvas/philip/tests/2d.path.quadraticCurveTo.ensuresubpath.2.html

fast/canvas/canvas-modify-emptyPath.html was updated to expect the new behavior.

Spec links:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-beziercurveto
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-quadraticcurveto

  • canvas/philip/tests/2d.path.bezierCurveTo.ensuresubpath.2-expected.txt:
  • canvas/philip/tests/2d.path.quadraticCurveTo.ensuresubpath.2-expected.txt:
  • fast/canvas/canvas-modify-emptyPath-expected.txt:
  • fast/canvas/script-tests/canvas-modify-emptyPath.js:
  • platform/mac/Skipped:
  • platform/qt/Skipped:

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

Canvas: bezierCurveTo() and quadraticCurveTo() must ensure subpaths
https://bugs.webkit.org/show_bug.cgi?id=41192

If the current path is empty, bezierCurveTo() and quadraticCurveTo() will now
move to the (first) control point before adding the curve.

Spec links:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-beziercurveto
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-quadraticcurveto

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::quadraticCurveTo): (WebCore::CanvasRenderingContext2D::bezierCurveTo):
2:44 PM Changeset in webkit [62299] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Add test for checking that canvas elements can't have a negative width or height.
https://bugs.webkit.org/show_bug.cgi?id=39149

Unskipped 2 canvas/philip/ tests that now pass.

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#attr-canvas-width

  • canvas/philip/tests/size.attributes.parse.minus-expected.txt:
  • canvas/philip/tests/size.attributes.setAttribute.minus-expected.txt:
  • fast/canvas/canvas-negative-size-expected.txt: Added.
  • fast/canvas/canvas-negative-size.html: Added.
  • fast/canvas/script-tests/canvas-negative-size.js: Added. (createFromMarkup): (trySettingWidth): (trySettingHeight): (trySettingWidthAttribute): (trySettingHeightAttribute): (tryCreatingCanvasWithWidth): (tryCreatingCanvasWithHeight): (tryWidth): (tryHeight): (checkDefaultWidth): (checkDefaultHeight):
  • platform/mac/Skipped:
  • platform/qt/Skipped:

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Canvas element cannot have negative width or height (HTML5 spec 4.8.11)
https://bugs.webkit.org/show_bug.cgi?id=39149

If assigned a negative value, it should default to 300 for width and 150 for height.

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#attr-canvas-width

Test: fast/canvas/canvas-negative-size.html

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::reset):
2:02 PM Changeset in webkit [62298] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

[Qt] Make context menus show up in the right place in QTestBrowser

Reviewed by Kenneth Rohde Christiansen.

Context menus were shown at scene-relative coordinates for
QGraphicsWebView while QMenu expects them to be global. The
change to the QWidget case was to get rid of the mapToGlobal.

  • QtTestBrowser/webview.cpp:
1:53 PM Changeset in webkit [62297] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKit2

Export symbols on Linux with GCC, like JSC does.

Rubberstamped by Sam Weinig.
Patch by Kenneth Christiansen <kenneth@webkit.org>

  • UIProcess/API/C/WKBase.h:
  • WebProcess/InjectedBundle/API/c/WKBundleBase.h:
1:53 PM Changeset in webkit [62296] by robert@webkit.org
  • 7 edits in trunk

2010-07-01 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] dump frames in ascending alphabetical order of title

https://bugs.webkit.org/show_bug.cgi?id=41261

Unskip:
http/tests/navigation/metaredirect-frames.html
http/tests/navigation/redirect302-frames.html
http/tests/navigation/redirect302-subframeload.html
http/tests/navigation/timerredirect-frames.html

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::getChildHistoryItems):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::dumpHistoryItem):
  • platform/qt/Skipped:
1:44 PM Changeset in webkit [62295] by tonikitoo@webkit.org
  • 2 edits
    2 adds in trunk/WebKit2

Initial WebKit2 implementation https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Antti Koivisto.
Patch by Kenneth Christiansen <kenneth@webkit.org>

Add implementation of the UI and loader client for Qt.

  • UIProcess/API/qt/qwkpage.cpp:
  • UIProcess/API/qt/ClientImpl.cpp: Added.

(toQWKPage):
(qt_wk_didStartProvisionalLoadForFrame):
(qt_wk_didReceiveServerRedirectForProvisionalLoadForFrame):
(qt_wk_didFailProvisionalLoadWithErrorForFrame):
(qt_wk_didCommitLoadForFrame):
(qt_wk_didFinishLoadForFrame):
(qt_wk_didFailLoadWithErrorForFrame):
(qt_wk_didReceiveTitleForFrame):
(qt_wk_didFirstLayoutForFrame):
(qt_wk_didFirstVisuallyNonEmptyLayoutForFrame):
(qt_wk_didStartProgress):
(qt_wk_didChangeProgress):
(qt_wk_didFinishProgress):
(qt_wk_didBecomeUnresponsive):
(qt_wk_didBecomeResponsive):
(qt_wk_createNewPage):
(qt_wk_showPage):
(qt_wk_close):
(qt_wk_runJavaScriptAlert):

  • UIProcess/API/qt/ClientImpl.h: Added.
1:37 PM Changeset in webkit [62294] by tonikitoo@webkit.org
  • 1 edit in trunk/WebKit2/ChangeLog

Unreviewed more ChangeLog mess up fix caused by bad resolve-ChangeLogs merges.

1:21 PM Changeset in webkit [62293] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-01 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed. Update chromium tests expectations for flaky tests.

  • platform/chromium/test_expectations.txt:
1:13 PM Changeset in webkit [62292] by tonikitoo@webkit.org
  • 1 edit in trunk/WebKit2/ChangeLog

Unreviewed ChangeLog mess up fix cause by bad resolve-ChangeLogs merges.

1:10 PM Changeset in webkit [62291] by Darin Adler
  • 3 edits in trunk/WebCore

Turn on adoptRef assertion for TreeShared.

Reviewed by Steve Falkenburg.

  • platform/TreeShared.h: Remove LOOSE_TREE_SHARED and all the ifdefs.

Actually, I used LOOSE_REF_COUNTED by accident in a few places, but
removing them all now.

  • rendering/ShadowElement.cpp:

(WebCore::ShadowBlockElement::create): Added adoptRef. This was a
storage leak before, probably recently introduced r61324.
(WebCore::ShadowInputElement::create): Ditto.

1:04 PM Changeset in webkit [62290] by andersca@apple.com
  • 6 edits in trunk/WebKit2

2010-07-01 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Change the CoreIPC connection identifier to be a HANDLE on Windows
https://bugs.webkit.org/show_bug.cgi?id=41479

  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/win/ConnectionWin.cpp: (CoreIPC::Connection::createServerAndClientIdentifiers): New function that creates a server and client HANDLE.

(CoreIPC::Connection::platformInitialize):
Don't open the connections here.

(CoreIPC::Connection::readEventHandler):
(CoreIPC::Connection::open):

  • UIProcess/Launcher/win/WebProcessLauncher.cpp: (WebKit::webThreadBody): Get the handle from the thread.

(WebKit::launchWebProcess):
Mark the client identifier as inheritable and pass it along to the web process.

  • WebProcess/win/WebProcessMain.cpp: (WebKit::CommandLine::CommandLine): (WebKit::CommandLine::parse): (WebKit::CommandLine::operator[]): Add simple command line parser.

(WebKit::WebProcessMain):
Get the handle identifier from the command line.

  • WebProcess/win/WebProcessMain.h:
  • WebKit.pri:
1:00 PM Changeset in webkit [62289] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Doc improvements for QDeclarativeWebView

Patch by Bea Lam <bea.lam@nokia.com> on 2010-07-01
Reviewed by Simon Hausmann.

  • declarative/qdeclarativewebview.cpp:
12:44 PM Changeset in webkit [62288] by kbr@google.com
  • 4 edits in trunk/WebKit/chromium

2010-07-01 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Stop linking against opengl32.lib in Windows Chromium port
https://bugs.webkit.org/show_bug.cgi?id=41424

  • WebKit.gyp:
  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::makeContextCurrent):
  • src/WebGraphicsContext3DDefaultImpl.h:
12:44 PM Changeset in webkit [62287] by tonikitoo@webkit.org
  • 1 edit
    7 adds in trunk/WebKit2

Initial WebKit2 implementation https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Antti Koivisto.
Patch by Kenneth Christiansen <kenneth@webkit.org>

Add initial Qt API for WebKit2

  • UIProcess/API/qt/WKView.h: Added.
  • UIProcess/API/qt/qgraphicswkview.cpp: Added.

(QGraphicsWKViewPrivate::pageRef):
(QGraphicsWKView::QGraphicsWKView):
(QGraphicsWKView::~QGraphicsWKView):
(QGraphicsWKView::page):
(QGraphicsWKView::paint):
(QGraphicsWKView::setGeometry):
(QGraphicsWKView::load):
(QGraphicsWKView::setUrl):
(QGraphicsWKView::url):
(QGraphicsWKView::title):
(QGraphicsWKView::triggerPageAction):
(QGraphicsWKView::back):
(QGraphicsWKView::forward):
(QGraphicsWKView::reload):
(QGraphicsWKView::stop):
(QGraphicsWKView::itemChange):
(QGraphicsWKView::event):
(QGraphicsWKView::sizeHint):
(QGraphicsWKView::inputMethodQuery):
(QGraphicsWKView::keyPressEvent):
(QGraphicsWKView::keyReleaseEvent):
(QGraphicsWKView::hoverMoveEvent):
(QGraphicsWKView::mouseMoveEvent):
(QGraphicsWKView::mousePressEvent):
(QGraphicsWKView::mouseReleaseEvent):
(QGraphicsWKView::mouseDoubleClickEvent):
(QGraphicsWKView::wheelEvent):
(QGraphicsWKViewPrivate::QGraphicsWKViewPrivate):
(QGraphicsWKView::visibleRect):

  • UIProcess/API/qt/qgraphicswkview.h: Added.
  • UIProcess/API/qt/qwkpage.cpp: Added.

(QWKPagePrivate::QWKPagePrivate):
(QWKPagePrivate::~QWKPagePrivate):
(QWKPagePrivate::init):
(QWKPagePrivate::toolTipChanged):
(QWKPagePrivate::paint):
(QWKPagePrivate::keyPressEvent):
(QWKPagePrivate::keyReleaseEvent):
(QWKPagePrivate::mouseMoveEvent):
(QWKPagePrivate::mousePressEvent):
(QWKPagePrivate::mouseReleaseEvent):
(QWKPagePrivate::mouseDoubleClickEvent):
(QWKPagePrivate::wheelEvent):
(QWKPagePrivate::updateAction):
(QWKPagePrivate::updateNavigationActions):
(QWKPagePrivate::_q_webActionTriggered):
(QWKPage::QWKPage):
(QWKPage::~QWKPage):
(QWKPage::pageRef):
(QWKPage::setCreateNewPageFunction):
(QWKPage::load):
(QWKPage::setUrl):
(QWKPage::url):
(QWKPage::title):
(QWKPage::setViewportSize):
(QWKPage::requestZoomRect):
(QWKPage::triggerAction):
(QWKPage::action):

  • UIProcess/API/qt/qwkpage.h: Added.
  • UIProcess/API/qt/qwkpage_p.h: Added.

(QWKPagePrivate::get):
(QWKPagePrivate::processDidExit):
(QWKPagePrivate::processDidRevive):
(QWKPagePrivate::takeFocus):

12:38 PM Changeset in webkit [62286] by Simon Fraser
  • 5 edits in trunk/WebCore

2010-07-01 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Get accelerated compositing working with webkit2
https://bugs.webkit.org/show_bug.cgi?id=41084

Step 2: add a method, syncCompositingStateForThisLayerOnly(), to GraphicsLayer to commit
batched changes non-recursively. This allows us to use GraphicsLayer in places where we
don't want to kick off a recursive commit of the entire tree.

  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::syncCompositingStateForThisLayerOnly):
  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::syncCompositingStateForThisLayerOnly):
  • WebCore.AcceleratedCompositing.exp: Export the new method for use in WebKit2.
12:34 PM Changeset in webkit [62285] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-07-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Only include the geolocation IDL in the GObject DOM bindings set
if geolocation is enabled.

  • GNUmakefile.am:
12:32 PM Changeset in webkit [62284] by timothy@apple.com
  • 10 edits in trunk

Provide a WebView preference to disable DNS prefetching.

https://bugs.webkit.org/show_bug.cgi?id=28825
rdar://problem/7181249

Reviewed by Darin Adler.

WebCore:

  • WebCore.base.exp: Added Settings::setDNSPrefetchingEnabled.
  • dom/Document.cpp:

(WebCore::Document::initDNSPrefetch): Check settings->dnsPrefetchingEnabled().

  • page/Settings.cpp:

(WebCore::Settings::Settings): Set m_dnsPrefetchingEnabled to true.
(WebCore::Settings::setDNSPrefetchingEnabled): Added. Set m_dnsPrefetchingEnabled.

  • page/Settings.h:

(WebCore::Settings::dnsPrefetchingEnabled): Added. Return m_dnsPrefetchingEnabled.

WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h: Added WebKitDNSPrefetchingEnabledPreferenceKey.
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Set WebKitDNSPrefetchingEnabledPreferenceKey to YES.
(-[WebPreferences isDNSPrefetchingEnabled]): Added. Return WebKitDNSPrefetchingEnabledPreferenceKey's value.
(-[WebPreferences setDNSPrefetchingEnabled:]): Added. Set WebKitDNSPrefetchingEnabledPreferenceKey's value.

  • WebView/WebPreferencesPrivate.h: Added isDNSPrefetchingEnabled and setDNSPrefetchingEnabled:.
  • WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]): Call WebCore::Settings::setDNSPrefetchingEnabled.

12:30 PM Changeset in webkit [62283] by Simon Fraser
  • 4 edits
    1 add in trunk/WebCore

2010-07-01 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Get accelerated compositing working with webkit2
https://bugs.webkit.org/show_bug.cgi?id=41084

Step 1: add a new .exp file for WebCore, which exports symbols only when USE(ACCELERATED_COMPOSITING)
is defined.

Also export WebCore::FloatSize::FloatSize(WebCore::IntSize const&) from WebCore.

  • DerivedSources.make:
  • WebCore.AcceleratedCompositing.exp: Added.
  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
12:23 PM Changeset in webkit [62282] by mrobinson@webkit.org
  • 2 edits in trunk/WebKitTools

2010-07-01 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Fix the GTK+ build after r62278.

  • Scripts/webkitdirs.pm: If the make arguments have already been specified, let them override the automatic CPU detection for autotools builds.
12:14 PM Changeset in webkit [62281] by sullivan@apple.com
  • 2 edits in trunk/WebKit2
  • mac/WebKit2.exp:

Added _WKFramePolicyListenerDownload and _WKFramePolicyListenerIgnore.

Rubber-stamped by Anders Carlsson.

12:12 PM Changeset in webkit [62280] by mrobinson@webkit.org
  • 2 edits in trunk/WebKitTools

2010-07-01 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Fix the Windows build after r62278.

  • Scripts/num-cpus: Use FindBin to add the Scripts directory to the list of library directories.
11:47 AM Changeset in webkit [62279] by ap@apple.com
  • 7 edits
    3 adds in trunk

WebCore:

Reviewed by Darin Adler.

<rdar://problem/8148656> <https://bugs.webkit.org/show_bug.cgi?id=41431>
REGRESSION (r49411): Various crashes due to JavaScript execution during plug-in destruction

Test: plugins/write-xssauditor-from-destroy.html

Fix specific known cases that also crash in same process case. I don't know if there is
any rule for when documentLoader should be checked for being null, it looks like a mess.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::referrer):
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::findInRequest):

WebKit:

<rdar://problem/8148656> <https://bugs.webkit.org/show_bug.cgi?id=41431>
REGRESSION (r49411): Various crashes due to JavaScript execution during plug-in destruction

Strengthen m_inDestroy "swipe under the carpet" fix.

  • Plugins/Hosted/NetscapePluginInstanceProxy.h: Added a long comment about m_inDestroy, and changed it to static.
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): m_inDestroy is now static, so we don't initialize it in constructor. (WebKit::NetscapePluginInstanceProxy::destroy): Assert that we aren't already destroying some plug-in. (WebKit::NetscapePluginInstanceProxy::evaluate): This function accidentally lacked an m_inDestroy check in r42789.
11:42 AM Changeset in webkit [62278] by mrobinson@webkit.org
  • 3 edits in trunk/WebKitTools

2010-07-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] build-webkit does not detect the number of CPUs
https://bugs.webkit.org/show_bug.cgi?id=41469

Pass the appropriate -j<#> flag to make when building autotools builds.
This causes make to spawn that many number of child processes for doing
parallel builds.

  • Scripts/num-cpus: Use the newly abstracted numberOfCPUs to return the number of CPUs. This makes the script work across more platforms.
  • Scripts/webkitdirs.pm: Create a numberOfCPUs/determineNumberOfCPUs to determine the number of CPUs across several platforms. Use this new function to determine the appropriate arguments to pass to make for doing parallel builds with autotools build files.
11:42 AM Changeset in webkit [62277] by commit-queue@webkit.org
  • 7 edits in trunk

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

The HTML5 canvas 2d.drawImage.zerocanvas test does not pass
https://bugs.webkit.org/show_bug.cgi?id=40271

Unskipped canvas/philip/tests/2d.drawImage.zerocanvas.html

  • canvas/philip/tests/2d.drawImage.zerocanvas-expected.txt:
  • platform/mac/Skipped:
  • platform/qt/Skipped:

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

The HTML5 canvas 2d.drawImage.zerocanvas test does not pass
https://bugs.webkit.org/show_bug.cgi?id=40271

Throw INVALID_STATE_ERR when attempting to draw a canvas with zero width or height.

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-drawimage

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::drawImage): Call setDOMException after drawImage(canvas, x, y)
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):
11:28 AM Changeset in webkit [62276] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Oliver Hunt.

[Qt] Canvas: clip() should use non-zero winding rule
https://bugs.webkit.org/show_bug.cgi?id=41466

Use non-zero winding number rule when clipping a GraphicsContext from canvas.
Fixes appearance of the "pill" in the web inspector.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::canvasClip):
10:45 AM Changeset in webkit [62275] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-01 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations for svg/W3C-SVG-1.1/filters-conv-01-f.svg
which is timing out on Linux and Windows.

  • platform/chromium/test_expectations.txt:
10:40 AM Changeset in webkit [62274] by yurys@chromium.org
  • 8 edits
    4 deletes in trunk

2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62246.
http://trac.webkit.org/changeset/62246
https://bugs.webkit.org/show_bug.cgi?id=41470

"Worker tests are broken in Chromium" (Requested by yurys on
#webkit).

  • fast/events/popup-blocked-from-fake-user-gesture-expected.txt: Removed.
  • fast/events/popup-blocked-from-fake-user-gesture.html: Removed.
  • http/tests/inspector/change-iframe-src-expected.txt: Removed.
  • http/tests/inspector/change-iframe-src.html: Removed.

2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62246.
http://trac.webkit.org/changeset/62246
https://bugs.webkit.org/show_bug.cgi?id=41470

"Worker tests are broken in Chromium" (Requested by yurys on
#webkit).

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler):
  • bindings/v8/V8HiddenPropertyName.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::eventAccessorGetter): (WebCore::V8DOMWindow::eventAccessorSetter):

2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62246.
http://trac.webkit.org/changeset/62246
https://bugs.webkit.org/show_bug.cgi?id=41470

"Worker tests are broken in Chromium" (Requested by yurys on
#webkit).

  • src/WebBindings.cpp: (WebKit::getEvent):
10:29 AM Changeset in webkit [62273] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

Canvas: Exception erroneously thrown for drawImage() when image.complete=false
https://bugs.webkit.org/show_bug.cgi?id=33968

Added a test to verify that CRC2D does nothing when calling drawImage()
with an incomplete image or video.

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-drawimage

  • fast/canvas/canvas-drawImage-incomplete-expected.txt: Added.
  • fast/canvas/canvas-drawImage-incomplete.html: Added.
  • fast/canvas/script-tests/canvas-drawImage-incomplete.js: Added.

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

Canvas: Exception erroneously thrown for drawImage() when image.complete=false
https://bugs.webkit.org/show_bug.cgi?id=33968

Do nothing in drawImage() if called with an image whose 'complete'
attribute is false, or a video whose readyState is either HAVE_NOTHING
or HAVE_METADATA.

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-drawimage

Test: fast/canvas/canvas-drawImage-incomplete.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):
10:14 AM Changeset in webkit [62272] by commit-queue@webkit.org
  • 11 edits
    4 deletes in trunk/WebKit/chromium

2010-07-01 David Holloway <dhollowa@chromium.org>

Reviewed by Darin Fisher.

[chromium] Consolidates AutoFill and Autocomplete popup menus into a single popup menu.

This change combines SuggestionsPopupMenuClient, AutoFillPopupMenuClient, and
AutocompletePopupMenuClient classes into a single consolidated AutoFillPopupMenuClient class.
Prior to this change the contents of the AutoFill popup menu only included AutoFill
suggestions and similarly the Autocomplete popup menu only included Autocomplete
suggestions. With this consolidation, both AutoFill and Autocomplete suggestions can
now be displayed in a single menu.

https://bugs.webkit.org/show_bug.cgi?id=41236

  • WebKit.gyp:
  • public/WebFrame.h:
  • public/WebView.h:
  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::AutoFillPopupMenuClient): (WebKit::AutoFillPopupMenuClient::~AutoFillPopupMenuClient): (WebKit::AutoFillPopupMenuClient::valueChanged): (WebKit::AutoFillPopupMenuClient::selectionCleared): (WebKit::AutoFillPopupMenuClient::itemText): (WebKit::AutoFillPopupMenuClient::itemStyle): (WebKit::AutoFillPopupMenuClient::menuStyle): (WebKit::AutoFillPopupMenuClient::clientPaddingLeft): (WebKit::AutoFillPopupMenuClient::clientPaddingRight): (WebKit::AutoFillPopupMenuClient::popupDidHide): (WebKit::AutoFillPopupMenuClient::setTextFromItem): (WebKit::AutoFillPopupMenuClient::fontSelector): (WebKit::AutoFillPopupMenuClient::hostWindow): (WebKit::AutoFillPopupMenuClient::createScrollbar): (WebKit::AutoFillPopupMenuClient::initialize): (WebKit::AutoFillPopupMenuClient::getWebView): (WebKit::AutoFillPopupMenuClient::textFieldStyle):
  • src/AutoFillPopupMenuClient.h: (WebKit::AutoFillPopupMenuClient::itemToolTip): (WebKit::AutoFillPopupMenuClient::itemAccessibilityText): (WebKit::AutoFillPopupMenuClient::itemIsEnabled): (WebKit::AutoFillPopupMenuClient::clientInsetLeft): (WebKit::AutoFillPopupMenuClient::clientInsetRight): (WebKit::AutoFillPopupMenuClient::listSize): (WebKit::AutoFillPopupMenuClient::selectedIndex): (WebKit::AutoFillPopupMenuClient::itemIsLabel): (WebKit::AutoFillPopupMenuClient::itemIsSelected): (WebKit::AutoFillPopupMenuClient::shouldPopOver): (WebKit::AutoFillPopupMenuClient::valueShouldChangeOnHotTrack): (WebKit::AutoFillPopupMenuClient::setAutocompleteMode): (WebKit::AutoFillPopupMenuClient::getTextField): (WebKit::AutoFillPopupMenuClient::getSelectedIndex): (WebKit::AutoFillPopupMenuClient::setSelectedIndex):
  • src/AutocompletePopupMenuClient.cpp: Removed.
  • src/AutocompletePopupMenuClient.h: Removed.
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::textFieldDidEndEditing): (WebKit::EditorClientImpl::doAutofill): (WebKit::EditorClientImpl::onAutocompleteSuggestionAccepted):
  • src/SuggestionsPopupMenuClient.cpp: Removed.
  • src/SuggestionsPopupMenuClient.h: Removed.
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::currentHistoryItem): (WebKit::WebFrameImpl::notifiyPasswordListenerOfAutocomplete):
  • src/WebFrameImpl.h:
  • src/WebViewImpl.cpp: (WebKit::): (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::mouseUp): (WebKit::WebViewImpl::selectPopupHandleKeyEvent): (WebKit::WebViewImpl::autocompleteHandleKeyEvent): (WebKit::WebViewImpl::hideAutoFillPopup): (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::applyAutoFillSuggestions): (WebKit::WebViewImpl::applyAutocompleteSuggestions): (WebKit::WebViewImpl::hidePopups): (WebKit::WebViewImpl::refreshAutoFillPopup):
  • src/WebViewImpl.h: (WebKit::WebViewImpl::autoFillPopupDidHide):
9:55 AM Changeset in webkit [62271] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2010-07-01 Justin Schuh <jschuh@chromium.org>

Reviewed by Dan Bernstein.

Prevent crash on counter destruction
https://bugs.webkit.org/show_bug.cgi?id=40032

Added counter destruction to RenderWidget::destroy()

Test: fast/css/counters/destroy-counter-crash.html

  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):

2010-07-01 Justin Schuh <jschuh@chromium.org>

Reviewed by Dan Bernstein.

Prevent crash on counter destruction
https://bugs.webkit.org/show_bug.cgi?id=40032

  • fast/css/counters/destroy-counter-crash-expected.txt: Added.
  • fast/css/counters/destroy-counter-crash.html: Added.
9:41 AM Changeset in webkit [62270] by weinig@apple.com
  • 3 edits in trunk/WebKit2

2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62267.
http://trac.webkit.org/changeset/62267
https://bugs.webkit.org/show_bug.cgi?id=41468

broke stuff (Requested by weinig on #webkit).

  • UIProcess/API/C/WKBase.h:
  • WebProcess/InjectedBundle/API/c/WKBundleBase.h:
9:26 AM Changeset in webkit [62269] by leandro@webkit.org
  • 2 edits in trunk/WebCore

2010-07-01 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Unreviewed build fix after r62215.

No new functionality, so no new tests.

  • CMakeLists.txt: Add missing files and re-sort.
9:25 AM Changeset in webkit [62268] by sullivan@apple.com
  • 2 edits in trunk/WebKit2
  • mac/WebKit2.exp:

Added _WKFramePolicyListenerRelease and _WKFramePolicyListenerRetain.

Rubber-stamped by Sam Weinig.

9:16 AM Changeset in webkit [62267] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit2

2010-07-01 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Antti Koivisto.

Export symbols on Linux with GCC

  • UIProcess/API/C/WKBase.h:
  • WebProcess/InjectedBundle/API/c/WKBundleBase.h:
9:10 AM Changeset in webkit [62266] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk

[Qt] Fix a comment in WebKit.pri.

Reviewed by Simon Hausmann.

  • WebKit.pri:
9:09 AM Changeset in webkit [62265] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebCore

[Qt] Remove an unneeded assert.

Reviewed by Kenneth Rohde Christiansen.

This assert is triggered for example while showing the falling leaves demo.
GraphicsLayerQtImpl::toGraphicsLayerQtImpl asserts that its input
pointer is null. Looking at the uses of this method it seems like
it is expected to return null if a null pointer is given to it.

  • platform/graphics/qt/GraphicsLayerQt.cpp:

(WebCore::toGraphicsLayerQtImpl):

9:08 AM Changeset in webkit [62264] by jocelyn.turcotte@nokia.com
  • 4 edits in trunk

[Qt] Fix qmake vcproj generation for QtWebKit.

Reviewed by Simon Hausmann.

qmake use TARGET=/LIBS+= -lTARGET to create dependencies
between projects in a subdir template.

Since when compiling outside of Qt we hijack the target name of
QtWebKit to add the configuration and version suffix to the binary
filename, qmake can't establish the WebCore project as a dependency
to QtTestBrowser.

This patch makes sure that the target is not hijacked on the
first of the three passes where the dependencies are determined.

.:

  • WebKit.pri:

WebCore:

  • WebCore.pro:
9:04 AM Changeset in webkit [62263] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/WebKit2

2010-07-01 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Antti Koivisto.

[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Add our event factory for converting Qt events to something WebKit2
understands.

  • Shared/qt/WebEventFactoryQt.cpp: Added. (WebKit::mouseButtonForEvent): (WebKit::webEventTypeForEvent): (WebKit::modifiersForEvent): (WebKit::WebEventFactory::createWebMouseEvent): (WebKit::WebEventFactory::createWebWheelEvent): (WebKit::WebEventFactory::createWebKeyboardEvent):
  • Shared/qt/WebEventFactoryQt.h: Added.
9:03 AM Changeset in webkit [62262] by mrobinson@webkit.org
  • 4 edits in trunk/WebKit/gtk

2010-07-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Convert WebKitWebView's private draggingDataObjects member to a pointer
https://bugs.webkit.org/show_bug.cgi?id=40333

Convert draggingDataObjects to a pointer. The constructor and destructor of the
HashMap should be called explicitly. GObject memory allocation does not do this.

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_dispose): (webkit_web_view_drag_end): (webkit_web_view_drag_data_get): (webkit_web_view_init):
8:27 AM Changeset in webkit [62261] by antti.j.koivisto@nokia.com
  • 1 edit
    3 adds in trunk/WebKit2

[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Add UpdateChunk. This one is mmap based, using Qt abstractions.

  • Shared/qt: Added.
  • Shared/qt/UpdateChunk.cpp: Added.

(WebKit::MappedMemory::markUsed):
(WebKit::MappedMemory::markFree):
(WebKit::MappedMemory::isFree):
(WebKit::mapMemory):
(WebKit::mapFile):
(WebKit::UpdateChunk::UpdateChunk):
(WebKit::UpdateChunk::~UpdateChunk):
(WebKit::UpdateChunk::data):
(WebKit::UpdateChunk::encode):
(WebKit::UpdateChunk::decode):
(WebKit::UpdateChunk::createImage):

  • Shared/qt/UpdateChunk.h: Added.

(WebKit::UpdateChunk::rect):
(WebKit::UpdateChunk::size):

8:05 AM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
CONFIG-=def_files and --no-depend-generate could be default (diff)
7:36 AM Changeset in webkit [62260] by antti.j.koivisto@nokia.com
  • 6 edits in trunk/WebKit2

[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Include some stdlib headers to fix linux build.

  • Platform/CoreIPC/ArgumentDecoder.cpp:
  • Platform/CoreIPC/ArgumentEncoder.cpp:
  • UIProcess/WebLoaderClient.cpp:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebUIClient.cpp:
7:25 AM Changeset in webkit [62259] by Nikolas Zimmermann
  • 4 edits in trunk/WebCore

2010-07-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGRenderStyle::diff() is missing
https://bugs.webkit.org/show_bug.cgi?id=41455

Don't just return StyleDifferenceLayout when two SVGRenderStyle objects differ.
Figure out when to repaint, and as last resort do a relayout.

Lively Kernel doesn't do any relayouts anymore, same for lots of demos in the IE9 testcenter.

  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff):
  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff):
  • rendering/style/SVGRenderStyle.h:
7:16 AM Changeset in webkit [62258] by yurys@chromium.org
  • 3 edits
    2 adds in trunk/LayoutTests

2010-07-01 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Added.
  • platform/chromium/test_expectations.txt:
6:49 AM Changeset in webkit [62257] by antti.j.koivisto@nokia.com
  • 3 edits
    2 adds in trunk/WebKit2

[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Implement CoreIPC::Connection and PlatformProcessIdentifier for Qt. Not built yet.

  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/qt: Added.
  • Platform/CoreIPC/qt/ConnectionQt.cpp: Added.

(CoreIPC::Connection::platformInitialize):
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::newConnectionHandler):
(CoreIPC::Connection::readyReadHandler):
(CoreIPC::Connection::openConnection):
(CoreIPC::Connection::open):
(CoreIPC::Connection::sendOutgoingMessage):

  • Platform/PlatformProcessIdentifier.h:
6:18 AM Changeset in webkit [62256] by antti.j.koivisto@nokia.com
  • 2 edits
    1 add in trunk/WebKit2

[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Implement WorkQueue for Qt. Not built yet.

  • Platform/WorkQueue.h:
  • Platform/qt/WorkQueueQt.cpp: Added.

(WorkQueue::WorkItemQt::WorkItemQt):
(WorkQueue::WorkItemQt::~WorkItemQt):
(WorkQueue::WorkItemQt::execute):
(WorkQueue::WorkItemQt::timerEvent):
(WorkQueue::connectSignal):
(WorkQueue::disconnectSignal):
(WorkQueue::platformInitialize):
(WorkQueue::platformInvalidate):
(WorkQueue::scheduleWork):

6:10 AM Changeset in webkit [62255] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-01 Satish Sampath <satish@chromium.org>

Reviewed by Yury Semikhatsky.

Fix wrong style comment in chromium test expectations file.
https://bugs.webkit.org/show_bug.cgi?id=41460

  • platform/chromium/test_expectations.txt:
5:49 AM Changeset in webkit [62254] by antti.j.koivisto@nokia.com
  • 4 edits in trunk

Revert accidental commit.

JavaScriptCore:

  • runtime/Collector.cpp:

(JSC::Heap::allocateBlock):

WebCore:

  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest):

5:42 AM Changeset in webkit [62253] by antti.j.koivisto@nokia.com
  • 4 edits
    2 adds in trunk

[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Implement RunLoop for Qt. Not built yet.

  • Platform/RunLoop.h:
  • Platform/qt: Added.
  • Platform/qt/RunLoopQt.cpp: Added.

(RunLoop::TimerObject::TimerObject):
(RunLoop::TimerObject::performWork):
(RunLoop::TimerObject::wakeUp):
(RunLoop::TimerObject::timerEvent):
(RunLoop::run):
(RunLoop::stop):
(RunLoop::RunLoop):
(RunLoop::~RunLoop):
(RunLoop::wakeUp):
(RunLoop::TimerBase::timerFired):
(RunLoop::TimerBase::TimerBase):
(RunLoop::TimerBase::~TimerBase):
(RunLoop::TimerBase::start):
(RunLoop::TimerBase::stop):
(RunLoop::TimerBase::isActive):

5:28 AM Changeset in webkit [62252] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-01 Patrick Gansterer <paroga@paroga.com>

Reviewed by Dirk Schulze.

Buildfix for !ENABLE(FILTERS) after r62238.
https://bugs.webkit.org/show_bug.cgi?id=41456

  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::prepareToRenderSVGContent):
5:17 AM Changeset in webkit [62251] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/WebKit/qt

2010-07-01 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Create QComboBoxes when clicked and destroy on hide.
https://bugs.webkit.org/show_bug.cgi?id=41451

Currently a QComboBox is created for each RenderMenuList and
it gets destroyed either when the RenderMenuList or the
QWebView (its Qt parent) is destroyed. This cause a crash
when the QWebView is destroyed before the render tree (which
is kept in cache).

This patch aim to destroy the QComboBox as soon as its popup
gets hidden, and likewise, create it only when the popup is
requested to be shown.
It also removes the unneeded reference to the QGraphicsProxyWidget,
destroying the QComboBox automatically destroys its bound
proxywidget.

  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopupCombo::hidePopup): (WebCore::QtFallbackWebPopup::QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::~QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::show): (WebCore::QtFallbackWebPopup::hide): (WebCore::QtFallbackWebPopup::destroyPopup): (WebCore::QtFallbackWebPopup::populate):
  • WebCoreSupport/QtFallbackWebPopup.h:
4:39 AM Changeset in webkit [62250] by morrita@google.com
  • 5 edits in trunk/WebCore

2010-07-01 MORITA Hajime <morrita@google.com>

Unreviewed build fix.

  • rendering/RenderInputSpeech.cpp: (WebCore::RenderInputSpeech::paintInputFieldSpeechButton):
  • rendering/RenderInputSpeech.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::paintInputFieldSpeechButton):
  • rendering/RenderTheme.h:
4:11 AM Changeset in webkit [62249] by commit-queue@webkit.org
  • 20 edits
    16 adds in trunk

2010-07-01 Satish Sampath <satish@chromium.org>

Reviewed by Kent Tamura.

Rendering the speech button in input elements.
https://bugs.webkit.org/show_bug.cgi?id=40984

input-appearance-speechbutton.html checks the appearances of various sizes of speech buttons.
input-appearance-searchandspeech.html checks input type='search' field with speech button.
input-appearance-numberandspeech.html checks input type='number' field with speech button.

  • fast/forms/input-appearance-numberandspeech-expected.txt: Added.
  • fast/forms/input-appearance-numberandspeech.html: Added.
  • fast/forms/input-appearance-searchandspeech-expected.txt: Added.
  • fast/forms/input-appearance-searchandspeech.html: Added.
  • fast/forms/input-appearance-speechbutton-expected.txt: Added.
  • fast/forms/input-appearance-speechbutton.html: Added.
  • platform/chromium/test_expectations.txt: Skipped all these new tests as the speech input feature is disabled by default.
  • platform/gtk/Skipped:
  • platform/mac/fast/forms/input-appearance-numberandspeech-expected.checksum: Added.
  • platform/mac/fast/forms/input-appearance-numberandspeech-expected.png: Added.
  • platform/mac/fast/forms/input-appearance-searchandspeech-expected.checksum: Added.
  • platform/mac/fast/forms/input-appearance-searchandspeech-expected.png: Added.
  • platform/mac/fast/forms/input-appearance-speechbutton-expected.checksum: Added.
  • platform/mac/fast/forms/input-appearance-speechbutton-expected.png: Added.
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-07-01 Satish Sampath <satish@chromium.org>

Reviewed by Kent Tamura.

Rendering the speech button in input elements.
https://bugs.webkit.org/show_bug.cgi?id=40984

The button currently has only one state and rendered as an image on all platforms. Subsequent
patches will add user input handling and more states + rendering code to the button. The
button's appearance can be customized by individual ports in their RenderTheme implementation
if required.

Tests: platform/mac/fast/forms/input-appearance-numberandspeech.html

platform/mac/fast/forms/input-appearance-searchandspeech.html
platform/mac/fast/forms/input-appearance-speechbutton.html

  • GNUmakefile.am:
  • Resources/inputSpeech.png: Added.
  • Resources/inputSpeech.tiff: Added. Used by the Mac implementation.
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.qrc:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/qt/ImageQt.cpp: (loadResourcePixmap): Load the speech button images for Qt port.
  • rendering/RenderInputSpeech.cpp: Added. (WebCore::RenderInputSpeech::adjustInputFieldSpeechButtonStyle): Sets the button's dimensions. (WebCore::RenderInputSpeech::paintInputFieldSpeechButton):
  • rendering/RenderInputSpeech.h: Added.
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::forwardEvent): (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded): Create the speech button. (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::adjustInputFieldSpeechButtonStyle): (WebCore::RenderTheme::paintInputFieldSpeechButton):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSearchFieldCancelButton): Get cancel button to render to the left of speech button when enabled.

2010-07-01 Satish Sampath <satish@chromium.org>

Reviewed by Kent Tamura.

Rendering the speech button in input elements.
https://bugs.webkit.org/show_bug.cgi?id=40984

  • Api/qwebsettings.cpp: (graphics):
  • Api/qwebsettings.h:
3:50 AM Changeset in webkit [62248] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[GTK] Extra nullcheck needed at SelectionControllerGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=41447

Extra null check added.

  • editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
3:39 AM Changeset in webkit [62247] by Simon Hausmann
  • 4 edits in trunk

[Qt][Symbian] Bumped up the maximum heap size to 96MB

Rubber-stamped by Laszlo Gombos.

.:

  • WebKit.pri:

WebKitTools:

  • QtTestBrowser/QtTestBrowser.pro: Removed explicit heap size declaration

and use the one from WebKit.pri instead.

3:05 AM Changeset in webkit [62246] by yurys@chromium.org
  • 8 edits
    4 adds in trunk

2010-07-01 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

[v8] Web Inspector: inspected page crashes on attempt to change iframe's src attribute
https://bugs.webkit.org/show_bug.cgi?id=41350

  • fast/events/popup-blocked-from-fake-user-gesture-expected.txt: Added.
  • fast/events/popup-blocked-from-fake-user-gesture.html: Added.
  • http/tests/inspector/change-iframe-src-expected.txt: Added.
  • http/tests/inspector/change-iframe-src.html: Added.

2010-07-01 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

[v8] Web Inspector: inspected page crashes on attempt to change iframe's src attribute
https://bugs.webkit.org/show_bug.cgi?id=41350

Tests: fast/events/popup-blocked-from-fake-user-gesture.html

http/tests/inspector/change-iframe-src.html

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): use V8Proxy from the ScriptController instead of one from the call stack. Get event directly from hidden property to avoid unnecessary checks.
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler):
  • bindings/v8/V8HiddenPropertyName.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::eventAccessorGetter): (WebCore::V8DOMWindow::eventAccessorSetter):

2010-07-01 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

[v8] Web Inspector: inspected page crashes on attempt to change iframe's src attribute
https://bugs.webkit.org/show_bug.cgi?id=41350

  • src/WebBindings.cpp: (WebKit::getEvent):
2:55 AM Changeset in webkit [62245] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-07-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Promote webkit-patch land-safely to main help
https://bugs.webkit.org/show_bug.cgi?id=41446

I've been using this command a bunch and recommending it to folks. We
should show it in main help as it's past the experimental phase.

  • Scripts/webkitpy/tool/commands/upload.py:
2:47 AM Changeset in webkit [62244] by Nikolas Zimmermann
  • 6 edits in trunk/WebCore

2010-07-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

RenderSVGContainer/RenderSVGRoot report wrong strokeBoundingBox()
https://bugs.webkit.org/show_bug.cgi?id=41450

strokeBoundingBox() was reporting the repaintRectInLocalCoordinates() for children of a container,
instead of the actual strokeBoundingBox(). Only visible in WebInspector when looking at a container
which has a resource applied and contains a children which also has a resource applied.

Doesn't affect any test results.

  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::objectBoundingBox): (WebCore::RenderSVGContainer::strokeBoundingBox): (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::objectBoundingBox): Deinlined this functions, it's virtual so there's no gain. (WebCore::RenderSVGRoot::strokeBoundingBox): Ditto. (WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
  • rendering/RenderSVGRoot.h:
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::computeContainerBoundingBox):
  • rendering/SVGRenderSupport.h: Add enum controlling the mode of container bounding box mode calculation.
2:45 AM Changeset in webkit [62243] by zherczeg@webkit.org
  • 7 edits in trunk

WebCore: Implementing feConvolveMatrix svg filter
https://bugs.webkit.org/show_bug.cgi?id=5861

Reviewed by Nikolas Zimmermann.

The implementation is optimized for speed, and uses
multiple algorithms for different parts of the image.
See SVGFEConvolveMatrixElement.cpp for a detailed
description.

  • svg/SVGFEConvolveMatrixElement.cpp:

(WebCore::SVGFEConvolveMatrixElement::build):

  • svg/graphics/filters/SVGFEConvolveMatrix.cpp:

(WebCore::clampRGBAValue):
(WebCore::FEConvolveMatrix::fastSetInteriorPixels):
(WebCore::FEConvolveMatrix::getPixelValue):
(WebCore::FEConvolveMatrix::fastSetOuterPixels):
(WebCore::FEConvolveMatrix::setInteriorPixels):
(WebCore::FEConvolveMatrix::setOuterPixels):
(WebCore::FEConvolveMatrix::apply):

  • svg/graphics/filters/SVGFEConvolveMatrix.h:

(WebCore::FEConvolveMatrix::uniteChildEffectSubregions):

LayoutTests: Updating expected values for feConvolveMatrix
https://bugs.webkit.org/show_bug.cgi?id=5861

Reviewed by Nikolas Zimmermann.

  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
2:41 AM Changeset in webkit [62242] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-07-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Abstract 'a'-'z' checks into a function
https://bugs.webkit.org/show_bug.cgi?id=41438

Hopefully this version is more readable.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken):
2:29 AM Changeset in webkit [62241] by abarth@webkit.org
  • 4 edits in trunk

2010-07-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Parameter names in frame src URLs parsed incorrectly if resembles HTML entity code followed by underscore
https://bugs.webkit.org/show_bug.cgi?id=41345

Add some more HTML entity test coverage for when the trailing semicolon
character is required.

  • html5lib/resources/entities02.dat:

2010-07-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Parameter names in frame src URLs parsed incorrectly if resembles HTML entity code followed by underscore
https://bugs.webkit.org/show_bug.cgi?id=41345

Apparently whether an HTML entity requires a trailing semicolon varies
depending on the entity. The full table is in the spec:

http://www.whatwg.org/specs/web-apps/current-work/multipage/named-character-references.html#named-character-references

I believe branch added in this patch is accurate. At some point, I'll
add a full test suite for all the named entities.

  • html/HTMLEntityParser.cpp: (WebCore::consumeHTMLEntity):
2:06 AM Changeset in webkit [62240] by yurys@chromium.org
  • 3 edits in trunk/LayoutTests

2010-07-01 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-win/html5lib/runner-expected.txt:
1:36 AM Changeset in webkit [62239] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-07-01 Eric Seidel <eric@webkit.org>

Unreviewed. Fix paste-o in Gtk build file.

Split out HTMLFormattingElementList into its own file
https://bugs.webkit.org/show_bug.cgi?id=41440

  • GNUmakefile.am:
1:33 AM Changeset in webkit [62238] by Nikolas Zimmermann
  • 9 edits in trunk/WebCore

2010-07-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Eric Seidel & Dirk Schulze.

Performance regression for setting content of <text> in SVG
https://bugs.webkit.org/show_bug.cgi?id=36564

Dramatically reducing the number of repaintRectInLocalCoordinates() calls needed while painting.
Do not pass the repaintRect to prepareToRenderSVGContent, only calculate it if opacity < 1 or -webkit-svg-shadow is set.
Most noticeable is that RenderSVGRoot had to visit all children, before actually painting, just to calculate the repaint rect.
And as RenderSVGRoot never carries shadow or opacity it was completly useless.

RenderSVGContainer also called repaintRectInLocalCoordinates, but the result is only needed when painting outlines, which is a rare case.
These modifications fix the performance regression and the number of repaintRectInLocalCoordinate calls for the complex example in
the bug report with 500 runs shrinks from 1.7 million calls to less than 105.000.

50 runs without the patch: ~ 520.8ms
50 runs with the patch : ~ 501.8ms

The test calls setTimeout(0) 50 times, that already accounts for the 500ms. So setting the content of a <text>
element withs clippers applied, is very cheap now.

Also remove the need to pass in a filter argument to prepareToRenderSVGContent/finishRenderSVGContent, it can easily be grabbed
of the cache - just like all other resources are handled, simplifying the code.

  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint):
  • rendering/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::paint):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::prepareToRenderSVGContent): (WebCore::SVGRenderSupport::finishRenderSVGContent):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::paint):
1:20 AM Changeset in webkit [62237] by eric@webkit.org
  • 4 edits in trunk/LayoutTests

2010-07-01 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make html5lib/runner dump failure details by default
https://bugs.webkit.org/show_bug.cgi?id=41436

This makes it much easier to see our result changes
in patch reviews. Especially when we change behavior
but don't necessarily fix entire subtests.

This patch was previously rolled out due to a bogus comment
in tests1.dat causing a EOF (null) to be emitted in the
results, causing diff to treat the file as binary (and thus
make it impossible to see differences).

The EOF/NULL bug was resolved by bug 41439, so relanding.

  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:
1:14 AM Changeset in webkit [62236] by morrita@google.com
  • 4 edits in trunk/WebKitTools

2010-06-28 MORITA Hajime <morrita@google.com>

Reviewed by Shinichiro Hamaji.

rebaseline-chromium-webkit-tests doesn't do diffs right with a Git checkout of WebKit
https://bugs.webkit.org/show_bug.cgi?id=38775

  • Introduced SCM.show_head() and SCM.diff_for_file().
  • Replaced direct svn invocations with newly implement SCM methods.
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1:07 AM Changeset in webkit [62235] by eric@webkit.org
  • 10 edits
    2 adds in trunk/WebCore

2010-07-01 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Split out HTMLFormattingElementList into its own file
https://bugs.webkit.org/show_bug.cgi?id=41440

No functional changes, thus no tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::indexOfFirstUnopenFormattingElement): (WebCore::HTMLTreeBuilder::reconstructTheActiveFormattingElements):
  • html/HTMLTreeBuilder.h:
12:53 AM Changeset in webkit [62234] by aa@chromium.org
  • 4 edits in trunk/WebKit/chromium

2010-07-01 Aaron Boodman <aa@chromium.org>

Reviewed by Darin Fisher.

Make the user script API static. This makes it more convenient to use
if you don't have a WebView instance yet.

Added static versions of the three methods and re-route current ones
temporarily through the static versions. Will remove the non-static
versions once Chromium has been updated.

Also, expose the URLPattern configuration for user stylesheets, since
they were not before.

https://bugs.webkit.org/show_bug.cgi?id=41385

  • public/WebView.h: (WebKit::WebView::addUserScript): (WebKit::WebView::addUserStyleSheet):
  • src/WebViewImpl.cpp: (WebKit::WebView::addUserScript): (WebKit::WebView::addUserStyleSheet): (WebKit::WebView::removeAllUserContent):
12:39 AM Changeset in webkit [62233] by abarth@webkit.org
  • 6 edits in trunk

2010-07-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

BogusCommentState should come in from the cold
https://bugs.webkit.org/show_bug.cgi?id=41439

Test progression => :)

  • html5lib/runner-expected.txt:
  • html5lib/webkit-resumer-expected.txt:

2010-07-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

BogusCommentState should come in from the cold
https://bugs.webkit.org/show_bug.cgi?id=41439

The BogusCommentState has always been wrong. The proximate issue is
that it didn't handle resuming correctly when parsing a partial input
stream. Now that we have EOF working properly, we can actually
implement this state correctly.

We need to distinguish when we enter this state from when we continue
in this state. We could do that with a branch for each character, but
it seemed easier to split the state in two, even though that leaves us
with one more state in our tokenizer than we have in the HTML5 spec.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken):
  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::):
12:12 AM Changeset in webkit [62232] by eric@webkit.org
  • 4 edits in trunk/LayoutTests

2010-07-01 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r62231.
http://trac.webkit.org/changeset/62231
https://bugs.webkit.org/show_bug.cgi?id=41436

diff thinks runner-expected.txt is binary which makes the
results impossible to read

  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:
Note: See TracTimeline for information about the timeline view.