Timeline
Jul 25, 2010:
- 11:57 PM Changeset in webkit [64033] by
-
- 5 edits in trunk
2010-07-25 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
https://bugs.webkit.org/show_bug.cgi?id=42326
- platform/mac-wk2/Skipped: Removed all the tests from the list that were there only because they called dumpSelectionRect. Most of them pass now.
2010-07-25 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
https://bugs.webkit.org/show_bug.cgi?id=42326
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpSelectionRect.
- WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::dumpSelectionRect): Added. For now, this does nothing because its purpose is to change pixel test output and we do not have pixel tests implemented yet.
- 11:40 PM Changeset in webkit [64032] by
-
- 4 edits in trunk
2010-07-23 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GTK] media/media-can-play-mpeg-audio.html fails
https://bugs.webkit.org/show_bug.cgi?id=42895
Fixed advertizing of mp3, mpeg and mp4 mime-types in the player.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):
LayoutTests:
2010-07-23 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GTK] media/media-can-play-mpeg-audio.html fails
https://bugs.webkit.org/show_bug.cgi?id=42895
- platform/gtk/Skipped: Unskip fixed test.
- 11:35 PM Changeset in webkit [64031] by
-
- 4 edits in trunk
2010-07-23 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
LayoutTests/media/media-document-audio-size.html failure
https://bugs.webkit.org/show_bug.cgi?id=38376
Advertize audio/x-wav along with audio/wav when appropriate,
otherwise WebKit attempts to use a plugin to play the media.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):
LayoutTests:
2010-07-23 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
LayoutTests/media/media-document-audio-size.html failure
https://bugs.webkit.org/show_bug.cgi?id=38376
- platform/gtk/Skipped: Unskip fixed test on GTK port.
- 11:13 PM Changeset in webkit [64030] by
-
- 2 edits in trunk/LayoutTests
2010-07-25 Darin Adler <Darin Adler>
Reviewed by Maciej Stachowiak.
Need to support unsafe access console messages in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=42320
- platform/mac-wk2/Skipped: Since unsafe access console messages are working properly, moved the failing tests listed under this bug to other sections in the file based on the reason they are failing. Removed the tests that are passing.
- 11:03 PM Changeset in webkit [64029] by
-
- 30 edits in trunk
2010-07-25 Darin Adler <Darin Adler>
Reviewed by Maciej Stachowiak.
WebKitTestRunner needs to support layoutTestController.keepWebHistory
https://bugs.webkit.org/show_bug.cgi?id=42323
- platform/mac-wk2/Skipped: Removed the tests that needed only keepWebHistory and computedStyleIncludingVisitedInfo. Moved the other tests in the keepWebHistory section of the file into the other appropriate lists.
2010-07-25 Darin Adler <Darin Adler>
Reviewed by Maciej Stachowiak.
WebKitTestRunner needs to support layoutTestController.keepWebHistory
https://bugs.webkit.org/show_bug.cgi?id=42323
Added keepWebHistory and computedStyleIncludingVisitedInfo.
Also fixed misspellings of the word "receive".
Also tweaked the names of some of the LayoutTestController members.
- WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added support for a type named "object" that is passed and returns as a JSValueRef.
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added keepWebHistory and computedStyleIncludingVisitedInfo. Also put setAcceptsEditing up nearer the top.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::_didReceiveMessage): Fixed mispellings of receive. (WTR::InjectedBundle::initialize): Ditto. (WTR::InjectedBundle::didReceiveMessage): Ditto. (WTR::InjectedBundle::reset): Reset the state of visited links between tests. Also eliminated the unused argument to the LayoutTestController create function. (WTR::InjectedBundle::setShouldTrackVisitedLinks): Added.
- WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::shouldBeginEditing): Call shouldAllowEditing instead of acceptsEditing. (WTR::InjectedBundlePage::shouldEndEditing): Ditto. (WTR::InjectedBundlePage::shouldInsertNode): Ditto. (WTR::InjectedBundlePage::shouldInsertText): Ditto. (WTR::InjectedBundlePage::shouldDeleteRange): Ditto. (WTR::InjectedBundlePage::shouldChangeSelectedRange): Ditto. (WTR::InjectedBundlePage::shouldApplyStyle): Ditto.
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::create): Removed uneeded argument. (WTR::LayoutTestController::LayoutTestController): Removed unneeded argument. Updated for rename of m_acceptsEditing to m_shouldAllowEditing. (WTR::LayoutTestController::numberOfActiveAnimations): Added some FIXMEs about the fact that this works on the main frame. (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto. (WTR::LayoutTestController::keepWebHistory): Added. (WTR::LayoutTestController::computedStyleIncludingVisitedInfo): Added. (WTR::JSObjectSetProperty): Added. Helper to make the function below cleaner. (WTR::LayoutTestController::makeWindowObject): Changed to use the overload of JSObjectSetProperty above.
- WebKitTestRunner/InjectedBundle/LayoutTestController.h: Changes to match above.
- WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Fixed mispellings of receive. (WTR::TestController::_didReceiveMessageFromInjectedBundle): Ditto. (WTR::TestController::didReceiveMessageFromInjectedBundle): Ditto.
- WebKitTestRunner/TestController.h: Ditto.
- WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Ditto.
- WebKitTestRunner/TestInvocation.h: Ditto.
2010-07-25 Darin Adler <Darin Adler>
Reviewed by Maciej Stachowiak.
WebKitTestRunner needs to support layoutTestController.keepWebHistory
https://bugs.webkit.org/show_bug.cgi?id=42323
Added WKBundleSetShouldTrackVisitedLinks, WKBundleRemoveAllVisitedLinks,
and WKBundleFrameGetComputedStyleIncludingVisitedInfo.
Also fixed misspellings of the word "receive".
- WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetShouldTrackVisitedLinks): Added. (WKBundleRemoveAllVisitedLinks): Added.
- WebProcess/InjectedBundle/API/c/WKBundle.h: Added functions and fixed mispellings of receive.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameGetJavaScriptContext): Moved the code from here into WebFrame, to be consistent with the rest of the functions in this file. (WKBundleFrameGetComputedStyleIncludingVisitedInfo): Added.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Added WKBundleFrameGetComputedStyleIncludingVisitedInfo and tried to rearrange the file to be more logically ordered and grouped.
- WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setShouldTrackVisitedLinks): Added. (WebKit::InjectedBundle::removeAllVisitedLinks): Added. (WebKit::InjectedBundle::didReceiveMessage): Fixed mispellings of receive.
- WebProcess/InjectedBundle/InjectedBundle.h: Ditto.
- WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::jsContext): Added. Contains the code that used to be in WKBundleFrameGetJavaScriptContext. (WebKit::WebFrame::computedStyleIncludingVisitedInfo): Added.
- WebProcess/WebPage/WebFrame.h: Ditto.
- UIProcess/API/C/WKContext.h: Fixed misspellings of receive.
- UIProcess/WebContext.cpp: (WebKit::WebContext::didReceiveMessageFromInjectedBundle): Ditto.
- UIProcess/WebContext.h: Ditto.
- UIProcess/WebContextInjectedBundleClient.cpp: (WebKit::WebContextInjectedBundleClient::didReceiveMessageFromInjectedBundle): Ditto.
- UIProcess/WebContextInjectedBundleClient.h: Ditto.
- UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::forwardMessageToWebContext): Ditto.
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::forwardMessageToInjectedBundle): Ditto.
- 9:10 PM Changeset in webkit [64028] by
-
- 3 edits in trunk/WebCore
splitTextAt*IfNeed and splitTextElementAt*IfNeed need to be cleaned up
https://bugs.webkit.org/show_bug.cgi?id=42937
Reviewed by Kent Tamura.
Isolated the code to decide whether or not text node should be split into isValidCaretPositionInTextNode.
Moved the condition check out of *IfNeeded methods to applyRelativeFontStyleChange and applyInlineStyle.
No new tests added since this is a clean up.
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Uses isValidCaretPositionInTextNode.
(WebCore::ApplyStyleCommand::applyInlineStyle): Uses isValidCaretPositionInTextNode.
(WebCore::ApplyStyleCommand::splitTextAtStart): Renamed from splitTextAtStartIfNeeded.
(WebCore::ApplyStyleCommand::splitTextAtEnd): Renamed from splitTextAtEndIfNeeded.
(WebCore::ApplyStyleCommand::splitTextElementAtStart): Renamed from splitTextElementAtStartIfNeeded.
(WebCore::ApplyStyleCommand::splitTextElementAtEnd): Renamed from splitTextElementAtEndIfNeeded.
(WebCore::ApplyStyleCommand::isValidCaretPositionInTextNode): Returns true if the position lies within a text node.
- editing/ApplyStyleCommand.h:
- 9:01 PM Changeset in webkit [64027] by
-
- 2 edits in trunk/JavaScriptCore
2010-07-25 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kent Tamura.
[WINCE] Buildfix for JSC in release mode
https://bugs.webkit.org/show_bug.cgi?id=42934
- jsc.cpp: Don't use try on WinCE.
- 8:48 PM Changeset in webkit [64026] by
-
- 2 edits in trunk/WebCore
2010-07-25 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kent Tamura.
[WINCE] Buildfix for ImageBufferWince
https://bugs.webkit.org/show_bug.cgi?id=42928
- platform/graphics/wince/ImageBufferWince.cpp: (WebCore::): (WebCore::BufferedImage::draw): Pass through ColorSpace parameter. (WebCore::BufferedImage::drawPattern): Ditto. (WebCore::ImageBuffer::platformTransformColorSpace): Added.
- 8:33 PM Changeset in webkit [64025] by
-
- 2 edits in trunk/WebCore
2010-07-25 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kent Tamura.
[WINCE] Buildfix for PopupMenuWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=42932
Add #if !OS(WINCE) around unsupported window messages.
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): (WebCore::PopupMenu::wndProc):
- 2:51 PM Changeset in webkit [64024] by
-
- 5 edits in trunk
2010-07-25 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement adjustMathMLAttributes
https://bugs.webkit.org/show_bug.cgi?id=42952
Yay test progression.
- html5lib/runner-expected-html5.txt:
2010-07-25 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement adjustMathMLAttributes
https://bugs.webkit.org/show_bug.cgi?id=42952
This is kind of mechanical overkill for adjusting one attribute name,
but it's nice to use the same machinery as SVG.
- html/HTMLTreeBuilder.cpp:
- mathml/mathattrs.in:
- 2:36 PM Changeset in webkit [64023] by
-
- 3 edits in trunk/WebCore
2010-07-25 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Functions supporting the legacy tree builder are confusing
https://bugs.webkit.org/show_bug.cgi?id=42951
This patch just inlines these functions into their one call site and
removes the notImplemented() calls. We thought we were going to grow
these to support the new tree builder, but we took a different path.
Previous to this patch, these functions were confusing because they
looked like part of the new tree builder.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::passTokenToLegacyParser):
- html/HTMLTreeBuilder.h:
- 1:05 PM Changeset in webkit [64022] by
-
- 2 edits in trunk/WebCore
2010-07-25 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Recent HTML5 TreeBuilder Regression? All canvas tests ASSERT
https://bugs.webkit.org/show_bug.cgi?id=42948
Remove ASSERT and replace with correct branch. I put this ASSERT in
to make sure we had test coverage for this branch. I guess we do. :)
- html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach):
- 8:46 AM Changeset in webkit [64021] by
-
- 2 edits in trunk/WebCore
2010-07-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: check of jQuery object type prior to treating it as an array.
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- 12:56 AM Changeset in webkit [64020] by
-
- 12 edits in trunk
2010-07-25 Alexey Proskuryakov <ap@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=42193
Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
Step 2 - add the rest of editing delegates.
- platform/mac-wk2/Skipped: Changed the bug tracking why the tests are skipped - the delegates are now implemented, but one of them isn't called for some reason.
2010-07-25 Alexey Proskuryakov <ap@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=42193
Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
Step 2 - add the rest of editing delegates.
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
- WebProcess/InjectedBundle/API/c/WKBundleBase.h: Added enums for EditorInsertAction and EAffinity. Also added a dummy type for CSSStyleDeclaration - neither DumpRenderTree not WebKitTestRunner actually use that.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp: (WebKit::InjectedBundlePageEditorClient::shouldBeginEditing): (WebKit::InjectedBundlePageEditorClient::shouldEndEditing): (WebKit::InjectedBundlePageEditorClient::shouldInsertNode): (WebKit::InjectedBundlePageEditorClient::shouldInsertText): (WebKit::InjectedBundlePageEditorClient::shouldDeleteRange): (WebKit::InjectedBundlePageEditorClient::shouldChangeSelectedRange): (WebKit::InjectedBundlePageEditorClient::shouldApplyStyle): (WebKit::InjectedBundlePageEditorClient::didBeginEditing): (WebKit::InjectedBundlePageEditorClient::didEndEditing): (WebKit::InjectedBundlePageEditorClient::didChange): (WebKit::InjectedBundlePageEditorClient::didChangeSelection):
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
- WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::shouldDeleteRange): (WebKit::WebEditorClient::shouldEndEditing): (WebKit::WebEditorClient::shouldInsertNode): (WebKit::WebEditorClient::shouldInsertText): (WebKit::WebEditorClient::shouldChangeSelectedRange): (WebKit::WebEditorClient::shouldApplyStyle): (WebKit::WebEditorClient::didBeginEditing): (WebKit::WebEditorClient::respondToChangedContents): (WebKit::WebEditorClient::respondToChangedSelection): (WebKit::WebEditorClient::didEndEditing): Added remaining delagates that are needed for WebKitTestRunner.
2010-07-25 Alexey Proskuryakov <ap@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=42193
Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
Step 2 - add the rest of editing delegates.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::operator<<): Fixed to not crash when range is null. (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::_shouldEndEditing): (WTR::InjectedBundlePage::_shouldInsertNode): (WTR::InjectedBundlePage::_shouldInsertText): (WTR::InjectedBundlePage::_shouldDeleteRange): (WTR::InjectedBundlePage::_shouldChangeSelectedRange): (WTR::InjectedBundlePage::_shouldApplyStyle): (WTR::InjectedBundlePage::_didBeginEditing): (WTR::InjectedBundlePage::_didEndEditing): (WTR::InjectedBundlePage::_didChange): (WTR::InjectedBundlePage::_didChangeSelection): (WTR::InjectedBundlePage::shouldEndEditing): (WTR::InjectedBundlePage::shouldInsertNode): (WTR::InjectedBundlePage::shouldInsertText): (WTR::InjectedBundlePage::shouldDeleteRange): (WTR::InjectedBundlePage::shouldChangeSelectedRange): (WTR::InjectedBundlePage::shouldApplyStyle): (WTR::InjectedBundlePage::didBeginEditing): (WTR::InjectedBundlePage::didEndEditing): (WTR::InjectedBundlePage::didChange): (WTR::InjectedBundlePage::didChangeSelection):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
Jul 24, 2010:
- 10:24 PM Changeset in webkit [64019] by
-
- 2 edits in trunk/WebCore
2010-07-24 Daniel Bates <dbates@rim.com>
Unreviewed, build fix when building with WML support.
PageCache.cpp compile error when WML is enabled
https://bugs.webkit.org/show_bug.cgi?id=40765
Remove extraneous semicolon.
Note, building with WML support enabled is broken
even with this fix. See Bug #42943 for more details.
- history/PageCache.cpp: (WebCore::PageCache::canCachePageContainingThisFrame):
- 6:24 PM WikiStart edited by
- (diff)
- 6:22 PM WinCE created by
- 6:03 PM Changeset in webkit [64018] by
-
- 4 edits in trunk/WebCore
2010-07-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Atomize strings used by the HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=42875
This is about a 1% improvement to the parsing benchmark.
- html/HTMLTagNames.in:
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTagForInBody): (WebCore::HTMLTreeBuilder::processStartTagForInHead):
- 5:40 PM Changeset in webkit [64017] by
-
- 2 edits in trunk/JavaScriptCore
2010-07-24 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
[MSVC] Ensure 4 byte alignment on ARM
https://bugs.webkit.org/show_bug.cgi?id=42935
- jit/JITStubs.h: Added #pragma pack(4) around JITStackFrame.
- 5:08 PM Changeset in webkit [64016] by
-
- 2 edits in trunk/JavaScriptCore
2010-07-24 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
[WINCE] Cleanup defines in Platform.h
https://bugs.webkit.org/show_bug.cgi?id=42933
- wtf/Platform.h:
- 4:33 PM Changeset in webkit [64015] by
-
- 5 edits in trunk/WebCore
2010-07-24 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
Buildfix for !ENABLE(INSPECTOR) after r63891.
https://bugs.webkit.org/show_bug.cgi?id=42925
- bindings/js/ScriptValue.cpp: Added property svn:eol-style.
- bindings/js/ScriptValue.h: Added property svn:eol-style.
- inspector/ConsoleMessage.cpp: Added property svn:eol-style.
- inspector/ConsoleMessage.h: Added property svn:eol-style.
- 3:36 PM Changeset in webkit [64014] by
-
- 7 edits2 adds in trunk
AX: need a layout test testing misspelled words in attributed strings
https://bugs.webkit.org/show_bug.cgi?id=42899
Reviewed by David Kilzer.
WebKitTools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(attributedStringForRangeCallback):
(attributedStringRangeIsMisspelledCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::attributedStringRangeIsMisspelled):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::attributedStringRangeIsMisspelled):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::attributedStringRangeIsMisspelled):
LayoutTests:
- platform/mac/accessibility/misspelled-attributed-string-expected.txt: Added.
- platform/mac/accessibility/misspelled-attributed-string.html: Added.
- 3:17 PM Changeset in webkit [64013] by
-
- 4 edits1 add8 deletes in trunk/LayoutTests
editing/execCommand/hilitecolor.html and editing/style/remove-underline-from-stylesheet.html should be dumpAsMarkup tests
https://bugs.webkit.org/show_bug.cgi?id=42793
Reviewed by Darin Adler.
Converted the tests and removed the platform specific expected results.
- editing/execCommand/hilitecolor-expected.txt: Added.
- editing/execCommand/hilitecolor.html: Converted.
- editing/style/remove-underline-from-stylesheet-expected.txt: Converted.
- editing/style/remove-underline-from-stylesheet.html: Converted.
- platform/chromium-linux/editing/execCommand/hilitecolor-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/hilitecolor-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/hilitecolor-expected.png: Removed.
- platform/chromium-win/editing/execCommand/hilitecolor-expected.txt: Removed.
- platform/mac/editing/execCommand/hilitecolor-expected.checksum: Removed.
- platform/mac/editing/execCommand/hilitecolor-expected.png: Removed.
- platform/mac/editing/execCommand/hilitecolor-expected.txt: Removed.
- platform/qt/editing/execCommand/hilitecolor-expected.txt: Removed.
- 1:02 PM Changeset in webkit [64012] by
-
- 2 edits in trunk/WebCore
2010-07-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Re-order whitespace checks in the tokenizer
https://bugs.webkit.org/show_bug.cgi?id=42923
This saves about 0.5% on the parsing benchmark.
- html/HTMLTokenizer.cpp:
- 11:48 AM Changeset in webkit [64011] by
-
- 2 edits in trunk/WebCore
2010-07-24 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] tst_QWebFrame::callQtInvokable() fails
https://bugs.webkit.org/show_bug.cgi?id=41065
Converting JS objects to QVariantMaps was broken.
This is a partial revert of <http://trac.webkit.org/changeset/61478>
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant): Remove erroneous crash guard around JSObject::getPropertyNames()
- 10:33 AM Changeset in webkit [64010] by
-
- 3 edits in trunk/WebCore
2010-07-24 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Save a per-character branch in the HTML parser
https://bugs.webkit.org/show_bug.cgi?id=42921
The parsing benchmark claims this is a wash, but it makes me feel
better.
- html/HTMLToken.h: (WebCore::HTMLToken::clear): (WebCore::HTMLToken::beginStartTag): (WebCore::HTMLToken::beginEndTag): (WebCore::HTMLToken::ensureIsCharacterToken): (WebCore::HTMLToken::beginComment): (WebCore::HTMLToken::beginDOCTYPE):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::bufferCharacter):
- 8:06 AM Changeset in webkit [64009] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-24 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium build fix.
- src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::fillResourceList):
- 5:54 AM Changeset in webkit [64008] by
-
- 2 edits in trunk
2010-07-24 Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Reviewed by Xan Lopez.
[GTK] Enable jit compilation on arm
https://bugs.webkit.org/show_bug.cgi?id=42856
Add missing bits to configure.ac to build the arm jit.
Compile and tested on debian sid armel on a qemu vm.
- configure.ac:
Jul 23, 2010:
- 9:17 PM Changeset in webkit [64007] by
-
- 2 edits in trunk/WebCore
2010-07-23 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
Buildfix for !ENABLE(FILTERS) after r63531.
https://bugs.webkit.org/show_bug.cgi?id=42914
- rendering/RenderSVGContainer.cpp: Add missing header.
- 8:35 PM Changeset in webkit [64006] by
-
- 8 edits in trunk
2010-07-23 Kavita Kanetkar <kkanetkar@chromium.org>
Reviewed by Joseph Pecoraro.
Implement remaining Inspector support for chrome's appcache
https://bugs.webkit.org/show_bug.cgi?id=42426
- inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::getApplicationCaches): (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache): (WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources): (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):
- inspector/InspectorApplicationCacheAgent.h: (WebCore::InspectorController::connectFrontend):
- loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::fillResourceList): (WebCore::ApplicationCacheHost::applicationCacheInfo):
- loader/appcache/ApplicationCacheHost.h: Changed creation + update times to double and moved appcache info here from InspectorApplicationCacheAgent.h (WebCore::ApplicationCacheHost::CacheInfo::CacheInfo): (WebCore::ApplicationCacheHost::ResourceInfo::ResourceInfo):
2010-07-23 Kavita Kanetkar <kkanetkar@chromium.org>
Reviewed by Joseph Pecoraro.
Implement remaining Inspector support for chrome's appcache
https://bugs.webkit.org/show_bug.cgi?id=42426
- src/ApplicationCacheHost.cpp: Plugging in chrome's appcache info. (WebCore::ApplicationCacheHost::applicationCacheInfo): (WebCore::ApplicationCacheHost::fillResourceList):
- src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
- 6:48 PM Changeset in webkit [64005] by
-
- 13 edits1 add in trunk
2010-07-23 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Cleanup glib support (make it optional)
https://bugs.webkit.org/show_bug.cgi?id=42480
Fixing support for compiling EFL port without glib.
- cmake/FindGthread.cmake: Added.
- cmake/OptionsEfl.cmake:
2010-07-23 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Cleanup glib support (make it optional)
https://bugs.webkit.org/show_bug.cgi?id=42480
Remove gobject/GRefPtr.cpp if not using soup/glib.
- wtf/CMakeListsEfl.txt:
2010-07-23 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Cleanup glib support (make it optional)
https://bugs.webkit.org/show_bug.cgi?id=42480
No new tests, no new features added.
Just add flags and directories for glib if necessary.
Put some ifdefs on glib calls.
- CMakeListsEfl.txt:
- platform/graphics/cairo/FontPlatformDataCairo.cpp: (WebCore::FontPlatformData::FontPlatformData):
2010-07-23 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Cleanup glib support (make it optional)
https://bugs.webkit.org/show_bug.cgi?id=42480
Just add glib flags and directories if necessary.
- CMakeListsEfl.txt:
2010-07-23 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Cleanup glib support (make it optional)
https://bugs.webkit.org/show_bug.cgi?id=42480
Put some ifdefs on glib calls.
- ewk/ewk_main.cpp: (ewk_init):
- 5:09 PM Changeset in webkit [64004] by
-
- 3 edits in trunk/WebCore
2010-07-23 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
CanvasRenderingContext2D has lots of style errors
https://bugs.webkit.org/show_bug.cgi?id=42918
CanvasRenderingContext2D.h and .cpp have lots of style errors. I'm planning to post patches
to both of these files soon, so to minimize merge conflicts and additional style violations
it seems best to fix all of these errors in bulk before posting any functional changes. In
particular the header file is incorrectly indented so any correctly formatted addition will
be out of place.
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): (WebCore::CanvasRenderingContext2D::setFillStyle): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::arcTo): (WebCore::CanvasRenderingContext2D::arc): (WebCore::validateRectForCanvas): (WebCore::CanvasRenderingContext2D::strokeRect): (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::createRadialGradient): (WebCore::CanvasRenderingContext2D::createPattern): (WebCore::CanvasRenderingContext2D::willDraw): (WebCore::CanvasRenderingContext2D::createImageData): (WebCore::CanvasRenderingContext2D::putImageData): (WebCore::CanvasRenderingContext2D::setFont): (WebCore::CanvasRenderingContext2D::drawTextInternal):
- html/canvas/CanvasRenderingContext2D.h: (WebCore::CanvasRenderingContext2D::is2d): (WebCore::CanvasRenderingContext2D::getLineCap): (WebCore::CanvasRenderingContext2D::getLineJoin): (WebCore::CanvasRenderingContext2D::state): (WebCore::CanvasRenderingContext2D::):
- 5:07 PM Changeset in webkit [64003] by
-
- 5 edits in trunk
Versioning.
- 5:05 PM Changeset in webkit [64002] by
-
- 1 copy in tags/Safari-534.3
New tag.
- 5:03 PM Changeset in webkit [64001] by
-
- 2 edits in trunk/WebCore
2010-07-23 Adam Barth <abarth@webkit.org>
Remove FIXME that we already fixed.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processCharacter):
- 3:34 PM Changeset in webkit [64000] by
-
- 5 edits7 adds in trunk/LayoutTests
2010-07-23 James Robinson <jamesr@chromium.org>
Unreviewed. Add chromium expectations for new tests.
- platform/chromium-mac/tables/layering/paint-test-layering-1-expected.checksum:
- platform/chromium-mac/tables/layering/paint-test-layering-1-expected.png:
- platform/chromium-mac/tables/layering/paint-test-layering-2-expected.checksum:
- platform/chromium-mac/tables/layering/paint-test-layering-2-expected.png:
- platform/chromium-win/tables/layering: Added.
- platform/chromium-win/tables/layering/paint-test-layering-1-expected.checksum: Added.
- platform/chromium-win/tables/layering/paint-test-layering-1-expected.png: Added.
- platform/chromium-win/tables/layering/paint-test-layering-1-expected.txt: Added.
- platform/chromium-win/tables/layering/paint-test-layering-2-expected.checksum: Added.
- platform/chromium-win/tables/layering/paint-test-layering-2-expected.png: Added.
- platform/chromium-win/tables/layering/paint-test-layering-2-expected.txt: Added.
- 3:17 PM Changeset in webkit [63999] by
-
- 10 edits in trunk/WebCore
2010-06-24 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Kent Tamura.
Move more form submission logic into FormSubmission.
https://bugs.webkit.org/show_bug.cgi?id=41110
Two major moves:
- Fold HTMLFormElement::prepareFormSubmission into FormSubmission::create
- Move non-static (non-FormData-building) methods of FormDataBuilder
to FormSubmission::Attributes.
Mechanical moving, no change in behavior, so no new tests.
- WebCore.xcodeproj/project.pbxproj: Gave FormDataBuilder.h "project" and
FormSubmission.h "private" visibility.
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Changed to use FormSubmission::create. (WebCore::HTMLFormElement::parseMappedAttribute): Changed to use m_attributes.
- html/HTMLFormElement.h: (WebCore::HTMLFormElement::enctype): Ditto. (WebCore::HTMLFormElement::encoding): Ditto. (WebCore::HTMLFormElement::acceptCharset): Ditto.
- loader/FormSubmission.cpp: (WebCore::generateFormDataIdentifier): Moved from HTMLFormElement. (WebCore::appendMailtoPostFormDataToURL): Ditto. (WebCore::FormSubmission::Attributes::parseAction): Moved from FormDataBuilder. (WebCore::FormSubmission::Attributes::parseEncodingType): Ditto. (WebCore::FormSubmission::Attributes::parseMethodType): Ditto. (WebCore::FormSubmission::FormSubmission): Made inline. (WebCore::FormSubmission::create): Added logic that used to be in
HTMLFormElement::prepareFormSubmission.
- loader/FormSubmission.h: (WebCore::FormSubmission::): (WebCore::FormSubmission::Attributes::Attributes): Added new class. (WebCore::FormSubmission::Attributes::method): Moved from FormDataBuilder. (WebCore::FormSubmission::Attributes::isMultiPartForm): Ditto. (WebCore::FormSubmission::Attributes::action): Ditto. (WebCore::FormSubmission::Attributes::target): Ditto. (WebCore::FormSubmission::Attributes::setTarget): Ditto. (WebCore::FormSubmission::Attributes::encodingType): Ditto. (WebCore::FormSubmission::Attributes::acceptCharset): Ditto. (WebCore::FormSubmission::Attributes::setAcceptCharset): Ditto. (WebCore::FormSubmission::target): Ditto. (WebCore::FormSubmission::contentType): Const-ified return type. (WebCore::FormSubmission::boundary): Ditto.
- platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::encodingFromAcceptCharset): Renamed method for clarity,
made it use param instead of a class member.
- platform/network/FormDataBuilder.h: (WebCore::FormDataBuilder::FormDataBuilder): Made constructor private.
- wml/WMLGoElement.cpp: Changed to use FormSubmision::Attributes.
- wml/WMLGoElement.h: Ditto.
- 3:14 PM Changeset in webkit [63998] by
-
- 13 edits2 adds in trunk
2010-07-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTML5 Parser: document.write in a asynchronous script which is specified to load before page finish blows away document
https://bugs.webkit.org/show_bug.cgi?id=42365
- http/tests/misc/write-from-dom-script-expected.txt: Added.
- http/tests/misc/write-from-dom-script.html: Added.
- Test the scenario where a script added to the DOM asynchronously while the nesting level is >0. It's supposed to have its calls to document.write blocked.
- http/tests/misc/write-while-waiting.html:
- Writes are only prevented from scripts that are added to the DOM. Scripts that run via setTimeout do not have their writes blocked.
2010-07-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTML5 Parser: document.write in a asynchronous script which is specified to load before page finish blows away document
https://bugs.webkit.org/show_bug.cgi?id=42365
This patch implements the changes Ian made to HTML5 to address these
issues. Let's try it and see how well it works.
Test: http/tests/misc/write-from-dom-script.html
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::write):
- dom/Document.h: (WebCore::Document::writeDisabled): (WebCore::Document::setWriteDisabled):
- dom/DocumentParser.h: (WebCore::DocumentParser::hasInsertionPoint):
- dom/ScriptElement.cpp: (WebCore::ScriptElement::insertedIntoDocument): (WebCore::ScriptElementData::ScriptElementData): (WebCore::ScriptElementData::evaluateScript):
- dom/ScriptElement.h: (WebCore::ScriptElementData::writeDisabled): (WebCore::ScriptElementData::setWriteDisabled):
- html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::hasInsertionPoint): (WebCore::HTMLDocumentParser::insert):
- html/HTMLDocumentParser.h:
- 2:59 PM Changeset in webkit [63997] by
-
- 3 edits in trunk/WebKitTools
<http://webkit.org/b/42911> Update ruby tools to work with shallow framework bundles
Reviewed by Mark Rowe.
- Scripts/check-for-inappropriate-files-in-framework: Added
check for the SHALLOW_BUNDLE environment variable so that the
script will work with iOS WebKit builds.
- Scripts/check-for-webkit-framework-include-consistency: Ditto.
- 2:46 PM Changeset in webkit [63996] by
-
- 2 edits in trunk/WebCore
2010-07-23 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
[WINCE] Buildfix for PopupMenuWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=42906
Use correct API for BitmapInfo landed in r63944.
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
- 2:30 PM Applications using WebKit edited by
- (diff)
- 2:29 PM Applications using WebKit edited by
- (diff)
- 1:29 PM Changeset in webkit [63995] by
-
- 1 edit1 add in trunk/LayoutTests
2010-07-23 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed. Land the expectation for win.
Backslash isn't transcoded in <input>
https://bugs.webkit.org/show_bug.cgi?id=42878
- platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.
- 1:22 PM Changeset in webkit [63994] by
-
- 9 edits32 adds in trunk
2010-07-23 fsamuel@chromium.org <fsamuel@chromium.org>
Reviewed by David Hyatt.
Updated table painting to draw cell layers in the correct order.
Table Cell Layering
https://bugs.webkit.org/show_bug.cgi?id=40775
Tests: tables/layering/paint-test-layering-1.html
tables/layering/paint-test-layering-2.html
- accessibility/AccessibilityTable.cpp: (WebCore::AccessibilityTable::isTableExposableThroughAccessibility): (WebCore::AccessibilityTable::addChildren): (WebCore::AccessibilityTable::cellForColumnAndRow):
- accessibility/AccessibilityTableCell.cpp: (WebCore::AccessibilityTableCell::titleUIElement):
- accessibility/AccessibilityTableColumn.cpp: (WebCore::AccessibilityTableColumn::headerObjectForSection):
- rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn):
- rendering/RenderTable.cpp: (WebCore::RenderTable::splitColumn): (WebCore::RenderTable::calcBorderLeft): (WebCore::RenderTable::calcBorderRight): (WebCore::RenderTable::cellAbove): (WebCore::RenderTable::cellBelow): (WebCore::RenderTable::cellBefore): (WebCore::RenderTable::cellAfter):
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::RenderTableSection): (WebCore::RenderTableSection::ensureRows): (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::setCellWidths): (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::calcOuterBorderTop): (WebCore::RenderTableSection::calcOuterBorderBottom): (WebCore::RenderTableSection::calcOuterBorderLeft): (WebCore::RenderTableSection::calcOuterBorderRight): (WebCore::RenderTableSection::firstLineBoxBaseline): (WebCore::compareCellPositions): (WebCore::RenderTableSection::paintCell): (WebCore::RenderTableSection::paintObject): (WebCore::RenderTableSection::numColumns): (WebCore::RenderTableSection::appendColumn): (WebCore::RenderTableSection::splitColumn): (WebCore::RenderTableSection::nodeAtPoint):
- rendering/RenderTableSection.h: (WebCore::RenderTableSection::CellStruct::CellStruct): (WebCore::RenderTableSection::CellStruct::primaryCell): (WebCore::RenderTableSection::CellStruct::hasCells): (WebCore::RenderTableSection::primaryCellAt):
2010-07-23 fsamuel@chromium.org <fsamuel@chromium.org>
Reviewed by David Hyatt.
Updated table painting to draw cell layers in the correct order.
Table Cell Layering
https://bugs.webkit.org/show_bug.cgi?id=40775
- platform/chromium-linux/tables/layering/paint-test-layering-1-expected.checksum: Added.
- platform/chromium-linux/tables/layering/paint-test-layering-1-expected.png: Added.
- platform/chromium-linux/tables/layering/paint-test-layering-1-expected.txt: Added.
- platform/chromium-linux/tables/layering/paint-test-layering-2-expected.checksum: Added.
- platform/chromium-linux/tables/layering/paint-test-layering-2-expected.png: Added.
- platform/chromium-linux/tables/layering/paint-test-layering-2-expected.txt: Added.
- platform/chromium-mac/tables/layering/paint-test-layering-1-expected.checksum: Added.
- platform/chromium-mac/tables/layering/paint-test-layering-1-expected.png: Added.
- platform/chromium-mac/tables/layering/paint-test-layering-1-expected.txt: Added.
- platform/chromium-mac/tables/layering/paint-test-layering-2-expected.checksum: Added.
- platform/chromium-mac/tables/layering/paint-test-layering-2-expected.png: Added.
- platform/chromium-mac/tables/layering/paint-test-layering-2-expected.txt: Added.
- platform/gtk/tables/layering/paint-test-layering-1-expected.checksum: Added.
- platform/gtk/tables/layering/paint-test-layering-1-expected.png: Added.
- platform/gtk/tables/layering/paint-test-layering-1-expected.txt: Added.
- platform/gtk/tables/layering/paint-test-layering-2-expected.checksum: Added.
- platform/gtk/tables/layering/paint-test-layering-2-expected.png: Added.
- platform/gtk/tables/layering/paint-test-layering-2-expected.txt: Added.
- platform/mac/tables/layering/paint-test-layering-1-expected.checksum: Added.
- platform/mac/tables/layering/paint-test-layering-1-expected.png: Added.
- platform/mac/tables/layering/paint-test-layering-1-expected.txt: Added.
- platform/mac/tables/layering/paint-test-layering-2-expected.checksum: Added.
- platform/mac/tables/layering/paint-test-layering-2-expected.png: Added.
- platform/mac/tables/layering/paint-test-layering-2-expected.txt: Added.
- tables/layering/paint-test-layering-1.html: Added.
- tables/layering/paint-test-layering-2.html: Added.
- 1:16 PM Changeset in webkit [63993] by
-
- 2 edits in trunk/WebCore
2010-07-23 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
[WINCE] Buildfix for Path.h
https://bugs.webkit.org/show_bug.cgi?id=42904
- platform/graphics/Path.h: Add missing typedef PlatformPath.
- 12:51 PM Changeset in webkit [63992] by
-
- 2 edits3 adds in trunk/LayoutTests
2010-07-23 Stephen White <senorblanco@chromium.org>
Unreviewed; chromium test expectations fix.
- platform/chromium-win/fast/borders/different-color-borders-expected.checksum: Added.
- platform/chromium-win/fast/borders/different-color-borders-expected.png: Added.
- platform/chromium-win/fast/borders/different-color-borders-expected.txt: Added. New baseline for new test.
- platform/chromium/test_expectations.txt: Remove passing tests from expectations.
- 12:08 PM Changeset in webkit [63991] by
-
- 2 edits in trunk/WebCore
2010-07-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Reserve capacity for attributes
https://bugs.webkit.org/show_bug.cgi?id=42877
This is about a 1.7% improvement to the parsing benchmark.
- html/HTMLToken.h: (WebCore::AtomicHTMLToken::AtomicHTMLToken):
- 11:54 AM Changeset in webkit [63990] by
-
- 3 edits in trunk/WebCore
2010-07-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Inline HTMLElementStack::top
https://bugs.webkit.org/show_bug.cgi?id=42879
According to sampling, HTMLElementStack::top is the hotest function in
the treebuilder. Inlining it is about a 0.3% improvement to the
parsing benchmark. This squares with how often it occurs in samples.
- html/HTMLElementStack.cpp:
- html/HTMLElementStack.h: (WebCore::HTMLElementStack::top):
- 11:38 AM Changeset in webkit [63989] by
-
- 3 edits in trunk/WebCore
2010-07-23 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
[WINCE] Buildfix for GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=42888
Use AffineTransform insted of TransformationMatrix and
add ColorSpace parameter to the drawBitmap methods.
- platform/graphics/GraphicsContext.h:
- platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::affineTransform): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::drawBitmap): (WebCore::GraphicsContext::drawBitmapPattern):
- 11:17 AM Changeset in webkit [63988] by
-
- 11 edits in trunk
2010-07-23 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Add support for using libcurl network backend.
https://bugs.webkit.org/show_bug.cgi?id=42286
Instead of just libsoup, the EFL port now can use libcurl backend.
This is a step in the direction of removing dependency on glib. Just
need to pass the option -DNETWORK_BACKEND=curl to cmake in order to
enable it.
- cmake/OptionsEfl.cmake:
2010-07-23 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Add support for using libcurl network backend.
https://bugs.webkit.org/show_bug.cgi?id=42286
Add files and flags for soup/curl specific backend being
used.
Put some ifdefs around soup/glib calls.
No new tests, no new features implemented.
- CMakeListsEfl.txt:
- platform/efl/FileSystemEfl.cpp: (WebCore::fileSystemRepresentation):
2010-07-23 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Add support for using libcurl network backend.
https://bugs.webkit.org/show_bug.cgi?id=42286
Just add soup/curl directories and flags for the specific
backend being used.
- CMakeLists.txt:
- CMakeListsEfl.txt:
2010-07-23 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Add support for using libcurl network backend.
https://bugs.webkit.org/show_bug.cgi?id=42286
Put some ifdefs around soup calls.
- ewk/ewk_cookies.cpp: (ewk_cookies_file_set): (ewk_cookies_clear): (ewk_cookies_get_all): (ewk_cookies_cookie_del): (ewk_cookies_cookie_free): (ewk_cookies_policy_set): (ewk_cookies_policy_get):
- ewk/ewk_main.cpp: (ewk_init):
- 10:47 AM Changeset in webkit [63987] by
-
- 2 edits in trunk/WebCore
2010-07-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add fast-reject path for InputStreamPreprocessor::peek
https://bugs.webkit.org/show_bug.cgi?id=42881
This is about a 2.5% speedup on the parsing benchmark.
- html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::InputStreamPreprocessor::peek):
- 10:27 AM Changeset in webkit [63986] by
-
- 3 edits in trunk/LayoutTests
2010-07-23 Hans Wennborg <hans@chromium.org>
Reviewed by Ojan Vafai.
Rebaseline fast/dom/prototype-inheritance.html for chromium
https://bugs.webkit.org/show_bug.cgi?id=42824
Since Chromium revision 53317, ENABLE_DEVICE_ORIENTATION is enabled,
which means window.DeviceOrientationEvent will show up
in this layout test.
- platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt:
- platform/chromium-win/fast/dom/prototype-inheritance-expected.txt:
- 10:11 AM Changeset in webkit [63985] by
-
- 2 edits in trunk/WebCore
2010-07-23 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
[WINCE] Merge PasteboardWince.cpp into PasteboardWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=42885
Make PasteboardWin more portable and remove the global namespace prefix
from GlobalLock/GlobalUnlock, since they are only macros on WinCE.
- platform/win/PasteboardWin.cpp: (WebCore::PasteboardOwnerWndProc): (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):
- 9:41 AM Changeset in webkit [63984] by
-
- 3 edits2 deletes in trunk
2010-07-23 Justin Schuh <jschuh@chromium.org>
Unreviewed, rolling out r63925.
http://trac.webkit.org/changeset/63925
https://bugs.webkit.org/show_bug.cgi?id=42858
Introduced a regression in history state.
- page/History.cpp: (WebCore::History::urlForState):
2010-07-23 Justin Schuh <jschuh@chromium.org>
Unreviewed, rolling out r63925.
http://trac.webkit.org/changeset/63925
https://bugs.webkit.org/show_bug.cgi?id=42858
Introduced a regression in history state.
- fast/history/history-replace-illegal-expected.txt: Removed.
- fast/history/history-replace-illegal.html: Removed.
- 9:26 AM Changeset in webkit [63983] by
-
- 2 edits in trunk/WebCore
2010-07-23 Martin Robinson <mrobinson@igalia.com>
Unreviewed build fix.
Fix make dist by aligning the source list with currently used headers.
- GNUmakefile.am:
- 9:25 AM Changeset in webkit [63982] by
-
- 1 edit2 deletes in trunk/LayoutTests
2010-07-23 Justin Schuh <jschuh@chromium.org>
Unreviewed, rolling out r63959.
http://trac.webkit.org/changeset/63959
https://bugs.webkit.org/show_bug.cgi?id=42884
63925 introduced a regression and is being reverted.
- platform/chromium-mac/fast/history/history-replace-illegal-expected.txt: Removed.
- platform/chromium-win/fast/history/history-replace-illegal-expected.txt: Removed.
- 9:24 AM Changeset in webkit [63981] by
-
- 2 edits in trunk/JavaScriptCore
2010-07-23 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
[WINCE] Implement TCSpinLock.
https://bugs.webkit.org/show_bug.cgi?id=41792
Implement the SpinLock with InterlockedExchange from the Windows API.
- wtf/TCSpinLock.h: (TCMalloc_SpinLock::Lock): (TCMalloc_SpinLock::Unlock): (TCMalloc_SpinLock::IsHeld): (TCMalloc_SpinLock::Init): (TCMalloc_SlowLock):
- 9:10 AM Changeset in webkit [63980] by
-
- 2 edits in trunk/JavaScriptCore/qt
2010-07-23 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
QScriptValue::equals benchmark crash fix.
Patch changes QScriptValue::equals implementation to cover
more edge cases.
Problem exposes an issue in our autotests (all values got
bound to an engine too fast - bug 42366).
[Qt] QScriptValue::equals asserts
https://bugs.webkit.org/show_bug.cgi?id=42363
- api/qscriptvalue_p.h: (QScriptValuePrivate::equals):
- 8:57 AM Changeset in webkit [63979] by
-
- 2 edits in trunk/WebCore
2010-07-23 Alex Milowski <alex@milowski.com>
Reviewed by Darin Adler.
Moved the 'mathml' group back to where it belongs as
siblings of the other major folders.
- WebCore.xcodeproj/project.pbxproj:
- 8:44 AM Changeset in webkit [63978] by
-
- 5 edits in trunk/WebKit/efl
2010-07-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Notify browser when window shall be closed.
This is used for window.close() events Javascript, though it would be
triggered for any event on WebCore that might ask for the window to be
closed.
- WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::closeWindowSoon): call new function and moves its previous functionality there.
- ewk/ewk_private.h:
- ewk/ewk_view.cpp: (ewk_view_window_close): stop all loaders as was being done previously and notify browser afterwards.
- ewk/ewk_view.h: declare new virtual method.
- 8:41 AM Changeset in webkit [63977] by
-
- 1 edit1 copy1 add in trunk/LayoutTests
Unreviewed.
Process link elements immediately if there are no beforeload listeners.
https://bugs.webkit.org/show_bug.cgi?id=42859
Add Qt specific expected result after r63924.
- platform/qt/http/tests/security/mixedContent: Added.
- platform/qt/http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt: Copied from LayoutTests/http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt and updated.
- 8:30 AM Changeset in webkit [63976] by
-
- 3 edits in trunk/WebCore
2010-07-23 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
Buildfix for WinCE graphics after r56015.
https://bugs.webkit.org/show_bug.cgi?id=41354
Use fabs() insetead of abs().
- platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::fillRect):
- platform/graphics/wince/PlatformPathWince.cpp: (WebCore::PlatformPath::addArcTo):
- 7:50 AM Changeset in webkit [63975] by
-
- 2 edits in trunk/WebCore
2010-07-23 ryuan choi <ryuan.choi@samsung.com>
Reviewed by Antonio Gomes.
[EFL]build break because of r63927
https://bugs.webkit.org/show_bug.cgi?id=42864
- CMakeLists.txt:
- 7:48 AM Changeset in webkit [63974] by
-
- 2 edits in trunk/WebKit/qt
Doc: Fixed incorrect QML property type.
Patch by David Boddie <dboddie@trolltech.com> on 2010-07-23
Reviewed by Simon Hausmann.
- declarative/qdeclarativewebview.cpp:
- 7:36 AM Changeset in webkit [63973] by
-
- 2 edits in trunk
2010-07-23 Andras Becsi <abecsi@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Enable the build of MiniBrowser.
- WebKit.pro: add MiniBrowser.pro to SUBDIRS.
- 7:34 AM Changeset in webkit [63972] by
-
- 4 edits in trunk/WebKit/efl
2010-07-23 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Set proxy address for Soup
https://bugs.webkit.org/show_bug.cgi?id=42721
Sets the given proxy URI for libsoup network backend. This method will
support libcurl network backend later.
- EWebLauncher/main.c: (main): Invoke proxy set method
- ewk/ewk_settings.cpp: (ewk_settings_proxy_uri_set): Sets proxy URI.
- ewk/ewk_settings.h:
- 7:27 AM Changeset in webkit [63971] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Build fix for Qt apps
Add webkit to QT_CONFIG. qconfig.pri will read qt_webkit_version.pri and
that's how it will pick up webkit in QT_CONFIG.
- qt_webkit_version.pri:
- 7:19 AM Changeset in webkit [63970] by
-
- 2 edits in trunk/WebCore
2010-07-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Inline HTMLTokenizer::InputStreamPreprocessor::peek
https://bugs.webkit.org/show_bug.cgi?id=42880
According to sampling HTMLTokenizer::InputStreamPreprocessor::peek is
the hotest function in the tokenizer. Inlining this function is about
a 2.2% speedup on the parser benchmark. Turns out the tokenizer is
much hotter than the tree builder. :)
- html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::InputStreamPreprocessor::peek):
- 7:04 AM Changeset in webkit [63969] by
-
- 2 edits in trunk/WebCore
2010-07-23 Andras Becsi <abecsi@webkit.org>
Unreviewed build fix.
[Qt] Fix WebKit2 linkage.
No new tests needed.
- WebCore.pro: add InjectedBundlePageEditorClient.cpp to WK2 sources
- 6:39 AM Changeset in webkit [63968] by
-
- 6 edits5 adds in trunk
2010-07-23 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Setup the QtWebProcess
- WebCore.pro: Added WebProcessMainQt.cpp to SOURCES.
2010-07-23 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Setup the QtWebProcess
- WebKit.pro: Add WebKit2.pro to the build guarded by webkit2 config variable.
2010-07-19 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Setup the QtWebProcess
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Remove the framework entry point from here to WebProcess/qt/WebProcessMainQt.cpp to match with with the mac and the win port.
- WebKit2.pro: Added.
- WebProcess/qt/WebProcessMainQt.cpp: Added. (WebKit::WebProcessMainQt): Framework entry point for Qt.
- qt/MainQt.cpp: Added. (main):
- 6:19 AM Changeset in webkit [63967] by
-
- 2 edits in trunk/WebCore
2010-07-23 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: Chromium tests fix.
- inspector/CodeGeneratorInspector.pm:
- 5:54 AM Changeset in webkit [63966] by
-
- 2 edits in trunk/WebCore
2010-07-23 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
[WINCE] Buildfix for PluginDatabaseWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=41887
Define KEY_ENUMERATE_SUB_KEYS only if not defined.
- plugins/win/PluginDatabaseWin.cpp:
- 5:46 AM Changeset in webkit [63965] by
-
- 10 edits in trunk
2010-07-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium DevTools: migrate from utility context-based injected
script dispatch to upstream schema.
- bindings/v8/ScriptProfile.cpp: (WebCore::ScriptProfile::title):
- inspector/InspectorController.cpp: (WebCore::InspectorController::getProfile):
- inspector/front-end/InjectedScriptAccess.js:
2010-07-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Reviewed by Yury Semikhatsky.
Chromium DevTools: migrate from utility context-based injected
script dispatch to upstream schema.
- src/ToolsAgent.h:
- src/WebDevToolsAgentImpl.cpp:
- src/WebDevToolsAgentImpl.h:
- src/js/DevToolsHostStub.js:
- src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
- 5:20 AM Changeset in webkit [63964] by
-
- 10 edits in trunk
2010-07-23 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: rolling out r63963.
- bindings/v8/ScriptProfile.cpp: (WebCore::ScriptProfile::title):
- inspector/InspectorController.cpp: (WebCore::InspectorController::getProfile):
- inspector/front-end/InjectedScriptAccess.js:
- 5:12 AM Changeset in webkit [63963] by
-
- 10 edits in trunk
2010-07-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium DevTools: migrate from utility context-based injected
script dispatch to upstream schema.
- bindings/v8/ScriptProfile.cpp: (WebCore::ScriptProfile::title):
- inspector/InspectorController.cpp: (WebCore::InspectorController::getProfile):
- inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess.get if): (InjectedScriptAccess):
2010-07-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Reviewed by Yury Semikhatsky.
Chromium DevTools: migrate from utility context-based injected
script dispatch to upstream schema.
- src/ToolsAgent.h:
- src/WebDevToolsAgentImpl.cpp:
- src/WebDevToolsAgentImpl.h:
- src/js/DevToolsHostStub.js:
- src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
- 4:58 AM Changeset in webkit [63962] by
-
- 2 edits in trunk/WebCore
2010-07-23 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: error info propagation in InspectorBackendDispatch should be improved
https://bugs.webkit.org/show_bug.cgi?id=42873
- inspector/CodeGeneratorInspector.pm: report wrong parameter count and wrong parametere type errror to the dispatch method caller
- 4:42 AM Changeset in webkit [63961] by
-
- 2 edits in trunk/WebCore
2010-07-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: injectedScriptId is missing in the stack frame wrappers.
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- 4:24 AM Changeset in webkit [63960] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] Search input field doesn't have cancel button
https://bugs.webkit.org/show_bug.cgi?id=42887
- platform/qt/Skipped: fast/forms/search-cancel-button-events.html skipped until fix.
- 3:02 AM Changeset in webkit [63959] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-07-23 Marcus Bulach <bulach@chromium.org>
Unreviewed. Adds expectations for chromium.
[chromium] Updates baselines following changes in history (http://trac.webkit.org/changeset/63925)
https://bugs.webkit.org/show_bug.cgi?id=42884
- platform/chromium-mac/fast/history/history-replace-illegal-expected.txt: Added.
- platform/chromium-win/fast/history/history-replace-illegal-expected.txt: Added.
- 2:02 AM Changeset in webkit [63958] by
-
- 49 edits12 adds13 deletes in trunk/LayoutTests
2010-07-22 Marcus Bulach <bulach@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Updates baselines following changes in border drawing code (http://trac.webkit.org/changeset/63864).
https://bugs.webkit.org/show_bug.cgi?id=42822
- platform/chromium-linux/fast/borders/different-color-borders-expected.checksum: Added.
- platform/chromium-linux/fast/borders/different-color-borders-expected.png: Added.
- platform/chromium-linux/fast/borders/different-color-borders-expected.txt: Added.
- platform/chromium-mac/fast/borders/border-radius-constraints-expected.checksum:
- platform/chromium-mac/fast/borders/border-radius-constraints-expected.png:
- platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.checksum:
- platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.png:
- platform/chromium-mac/fast/borders/border-radius-split-inline-expected.checksum:
- platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum:
- platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.checksum: Removed.
- platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusDashed01-expected.checksum:
- platform/chromium-mac/fast/borders/borderRadiusDashed01-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusDashed04-expected.checksum:
- platform/chromium-mac/fast/borders/borderRadiusDashed04-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusDotted06-expected.checksum:
- platform/chromium-mac/fast/borders/borderRadiusDotted06-expected.png: Added.
- platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.checksum: Removed.
- platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.checksum: Removed.
- platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
- platform/chromium-mac/fast/borders/borderRadiusGroove01-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
- platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusInset01-expected.checksum: Removed.
- platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusInvalidColor-expected.checksum:
- platform/chromium-mac/fast/borders/borderRadiusInvalidColor-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusOutset01-expected.checksum: Removed.
- platform/chromium-mac/fast/borders/borderRadiusOutset01-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
- platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusSolid01-expected.checksum: Removed.
- platform/chromium-mac/fast/borders/borderRadiusSolid01-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusSolid02-expected.checksum: Removed.
- platform/chromium-mac/fast/borders/borderRadiusSolid02-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusSolid03-expected.checksum: Removed.
- platform/chromium-mac/fast/borders/borderRadiusSolid03-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusSolid04-expected.checksum: Removed.
- platform/chromium-mac/fast/borders/borderRadiusSolid04-expected.png:
- platform/chromium-mac/fast/borders/different-color-borders-expected.checksum: Added.
- platform/chromium-mac/fast/borders/different-color-borders-expected.png: Added.
- platform/chromium-mac/fast/borders/fieldsetBorderRadius-expected.checksum: Removed.
- platform/chromium-mac/fast/borders/fieldsetBorderRadius-expected.png:
- platform/chromium-mac/fast/css/nested-rounded-corners-expected.checksum: Added.
- platform/chromium-mac/fast/css/nested-rounded-corners-expected.png: Added.
- platform/chromium-mac/fast/forms/basic-selects-expected.checksum:
- platform/chromium-mac/fast/forms/basic-selects-expected.png:
- platform/chromium-mac/fast/forms/menulist-clip-expected.checksum:
- platform/chromium-mac/fast/forms/menulist-clip-expected.png:
- platform/chromium-mac/fast/forms/menulist-narrow-width-expected.checksum:
- platform/chromium-mac/fast/forms/menulist-narrow-width-expected.png:
- platform/chromium-mac/fast/forms/menulist-option-wrap-expected.checksum:
- platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png:
- platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.checksum:
- platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.png:
- platform/chromium-mac/fast/forms/menulist-separator-painting-expected.checksum:
- platform/chromium-mac/fast/forms/menulist-separator-painting-expected.png:
- platform/chromium-mac/fast/forms/menulist-style-color-expected.checksum:
- platform/chromium-mac/fast/forms/menulist-style-color-expected.png:
- platform/chromium-mac/fast/forms/select-baseline-expected.checksum:
- platform/chromium-mac/fast/forms/select-baseline-expected.png:
- platform/chromium-mac/fast/overflow/border-radius-clipping-expected.checksum:
- platform/chromium-mac/fast/overflow/border-radius-clipping-expected.png:
- platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.checksum:
- platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
- platform/chromium-win-xp/fast/css/nested-rounded-corners-expected.png: Added.
- platform/chromium-win/fast/css/nested-rounded-corners-expected.checksum: Added.
- platform/chromium-win/fast/css/nested-rounded-corners-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 1:37 AM Changeset in webkit [63957] by
-
- 7 edits in trunk
2010-07-23 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Kent Tamura.
Backslash isn't transcoded in <input>
https://bugs.webkit.org/show_bug.cgi?id=42878
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
2010-07-23 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Kent Tamura.
Backslash isn't transcoded in <input>
https://bugs.webkit.org/show_bug.cgi?id=42878
- editing/selection/find-yensign-and-backslash-expected.txt:
- platform/mac/fast/text/backslash-to-yen-sign-euc-expected.checksum:
- platform/mac/fast/text/backslash-to-yen-sign-euc-expected.png:
- platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt:
- 12:28 AM Changeset in webkit [63956] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-23 Kent Tamura <tkent@chromium.org>
Reviewed by Shinichiro Hamaji.
Roll Chromium revision
https://bugs.webkit.org/show_bug.cgi?id=42876
- 12:17 AM Changeset in webkit [63955] by
-
- 2 edits in trunk/LayoutTests
2010-07-23 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed. Put a failing result for now.
Backslash is transcoded into yen sign even when non japanese font is specified
https://bugs.webkit.org/show_bug.cgi?id=39654
- editing/selection/find-yensign-and-backslash-expected.txt:
- 12:03 AM Changeset in webkit [63954] by
-
- 3 edits in trunk/JavaScriptCore
Unreviewed rolling out r63947 and r63948, because they broke Qt Windows build.
- jit/JITStubs.cpp:
- jit/JITStubs.h:
Jul 22, 2010:
- 11:47 PM Changeset in webkit [63953] by
-
- 3 edits in trunk/LayoutTests
2010-07-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
media/video-duration-known-after-eos.html test is slow
https://bugs.webkit.org/show_bug.cgi?id=42809
Seek near the end of the media to speed the test up.
- media/video-duration-known-after-eos-expected.txt:
- media/video-duration-known-after-eos.html:
- 11:39 PM Changeset in webkit [63952] by
-
- 18 edits in trunk
2010-07-22 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: CodeGeneratorInspector was extended and now it can
generate InspectorBackedDispatcher's code. This dispatcher will
validate and dispatch incoming inspector commands only by native
code without using javaScript. That is necessary step for
RemoteDebugging support.
https://bugs.webkit.org/show_bug.cgi?id=42588
- GNUmakefile.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/CodeGeneratorInspector.pm:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController):
- inspector/InspectorController.h: (WebCore::InspectorController::inspectorBackendDispatcher):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.setDocument):
2010-07-22 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: CodeGeneratorInspector was extended and now it can
generate InspectorBackedDispatcher's code. This dispatcher will
validate and dispatch incoming inspector commands only by native
code without using javaScript. That is necessary step for
RemoteDebugging support.
https://bugs.webkit.org/show_bug.cgi?id=42588
- src/ToolsAgent.h:
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::dispatchOnInspectorController):
- src/WebDevToolsAgentImpl.h:
- src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl.prototype.callInspectorController_):
- 11:26 PM Changeset in webkit [63951] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-07-22 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed. Add expectations for Qt and Gtk.
Backslash is transcoded into yen sign even when non japanese font is specified
https://bugs.webkit.org/show_bug.cgi?id=39654
- platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.
- platform/qt/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.
- 10:39 PM Changeset in webkit [63950] by
-
- 10 edits4 adds in trunk
2010-07-22 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Kent Tamura.
Backslash is transcoded into yen sign even when non japanese font is specified
https://bugs.webkit.org/show_bug.cgi?id=39654
- fast/text/backslash-to-yen-sign-euc.html: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/text/backslash-to-yen-sign-euc-expected.checksum: Added.
- platform/mac/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
- platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.
2010-07-22 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Kent Tamura.
Backslash is transcoded into yen sign even when non japanese font is specified
https://bugs.webkit.org/show_bug.cgi?id=39654
Test: fast/text/backslash-to-yen-sign-euc.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Call FontDescriptor::setIsSpecifiedFont.
- platform/graphics/Font.cpp: (WebCore::Font::Font):
- platform/graphics/FontDescription.h: Added m_isSpecifiedFont and its accessors. (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::isSpecifiedFont): (WebCore::FontDescription::setIsSpecifiedFont): (WebCore::FontDescription::operator==):
- platform/text/transcoder/FontTranscoder.cpp: (WebCore::FontTranscoder::converterType): Don't transcode backslashes if a font family is explicitly specified. (WebCore::FontTranscoder::convert): (WebCore::FontTranscoder::needsTranscoding):
- platform/text/transcoder/FontTranscoder.h: Change the arguments from AtomicString fontFamily to Font.
- rendering/RenderText.cpp: (WebCore::RenderText::updateNeedsTranscoding): (WebCore::RenderText::setTextInternal):
- 8:46 PM Changeset in webkit [63949] by
-
- 7 edits in trunk
Eliminate unneeded WKBundleFrameCopyInnerText function from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42847
Reviewed by Sam Weinig.
WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: Removed WKBundleFrameCopyInnerText.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Ditto.
- WebProcess/WebPage/WebFrame.cpp: Removed innerText.
- WebProcess/WebPage/WebFrame.h: Ditto.
WebKitTools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::operator<<): Replaced the WKStringToUTF8 function with
a set of overloaded stream operators.
(WTR::dumpPath): Changed to use ostringstream and return a string.
(WTR::propertyValue): Added.
(WTR::propertyObject): Added.
(WTR::propertyString): Added.
(WTR::numericWindowPropertyValue): Changed to call propertyValue.
(WTR::dumpFrameScrollPosition): Removed now unneeded WKStringToUTF8 sequence
since we now have suitable streaming functions.
(WTR::dumpFrameText): Use propertyObject and propertyString instead of
WKBundleFrameCopyInnerText.
(WTR::dumpDescendantFramesText): Removed now unneeded WKStringToUTF8 sequence
since we now have suitable streaming functions.
(WTR::InjectedBundlePage::dump): Ditto.
(WTR::InjectedBundlePage::willAddMessageToConsole): Ditto.
(WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
- 8:43 PM Changeset in webkit [63948] by
-
- 2 edits in trunk/JavaScriptCore
Eeeep! r63947 hosed all non-x86 builds!
- jit/JITStubs.h:
- 8:28 PM Changeset in webkit [63947] by
-
- 3 edits in trunk/JavaScriptCore
Bug 42818 - [Qt] REGRESSION(63348): jsc is broken
Speculative fix, need fastcall conventions on Qt/Win.
Reviewed by Oliver Hunt.
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- 8:24 PM Changeset in webkit [63946] by
-
- 2 edits in trunk/JavaScriptCore
2010-07-22 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Do more constant folding
https://bugs.webkit.org/show_bug.cgi?id=42867
Constant fold a few more operations. SunSpider says this is
a win but I suspect that's just code motion at play.
- parser/ASTBuilder.h: (JSC::ASTBuilder::makeModNode): (JSC::ASTBuilder::makeURightShiftNode): (JSC::ASTBuilder::makeBitOrNode): (JSC::ASTBuilder::makeBitAndNode): (JSC::ASTBuilder::makeBitXOrNode): (JSC::ASTBuilder::makeBinaryNode):
- 8:20 PM Changeset in webkit [63945] by
-
- 2 edits in trunk/WebCore
Windows build fix.
Commit some changes missed by the commit-queue in r63944.
- platform/win/BitmapInfo.h:
(WebCore::BitmapInfo::is16bit):
(WebCore::BitmapInfo::is32bit):
(WebCore::BitmapInfo::width):
(WebCore::BitmapInfo::height):
(WebCore::BitmapInfo::size):
(WebCore::BitmapInfo::paddedWidth):
(WebCore::BitmapInfo::numPixels):
(WebCore::BitmapInfo::paddedBytesPerLine):
(WebCore::BitmapInfo::bytesPerLine):
- 7:55 PM Changeset in webkit [63944] by
-
- 2 edits in trunk/WebCore
2010-07-22 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
[WINCE] Add additonal methods to BitmapInfo.
https://bugs.webkit.org/show_bug.cgi?id=42071
Added a parameter to create 16bit BitmapInfo and
some additional accessors for the WinCE port.
Set bmiHeader.biSize only at constructor.
- platform/win/BitmapInfo.cpp: Added property svn:eol-style. (WebCore::bitmapInfoForSize): (WebCore::BitmapInfo::create): (WebCore::BitmapInfo::createBottomUp):
- platform/win/BitmapInfo.h: Added property svn:eol-style. (WebCore::BitmapInfo::is16bit): (WebCore::BitmapInfo::is32bit): (WebCore::BitmapInfo::width): (WebCore::BitmapInfo::height): (WebCore::BitmapInfo::size): (WebCore::BitmapInfo::paddedWidth): (WebCore::BitmapInfo::numPixels): (WebCore::BitmapInfo::paddedBytesPerLine): (WebCore::BitmapInfo::bytesPerLine):
- 7:36 PM Changeset in webkit [63943] by
-
- 2 edits1 add in trunk/WebCore
2010-07-22 MORITA Hajime <morrita@google.com>
Reviewed by Ojan Vafai.
Autoscroll on selection should take scrollbars into account as outside of the content.
https://bugs.webkit.org/show_bug.cgi?id=40403
ScrollView's scroll-bar was considered as a part of content rect,
that prevents autoscroll to happen when the pointer is over the
scroll-bar. This change excluded scroll-bar region from scrolling
delta calculation.
Test: WebCore/manual-tests/autoscroll-over-scrollbar.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible):
- 7:29 PM Changeset in webkit [63942] by
-
- 7 edits3 adds in trunk
maxLength should not be applied to non-text types
https://bugs.webkit.org/show_bug.cgi?id=42814
Reviewed by Darin Adler.
WebCore:
According to the HTML5 specification, maxLength attribute should
be applied to text, search, url, tel, email, and password types.
Test: fast/forms/input-maxlength-unsupported.html
- dom/InputElement.cpp:
(WebCore::InputElement::handleBeforeTextInsertedEvent):
Apply maxLength() only if supportsMaxLength() is true.
- dom/InputElement.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::patternMismatch):
Code cleanup by isTextType().
(WebCore::HTMLInputElement::tooLong):
ditto.
(WebCore::HTMLInputElement::isTextType):
Added. This returns true for types with maxLength/pattern/placeholder.
- html/HTMLInputElement.h:
(WebCore::HTMLInputElement::supportsMaxLength):
Added. Just calls isTextType().
(WebCore::HTMLInputElement::supportsPlaceholder):
Code cleanup by isTextType().
- wml/WMLInputElement.h:
(WebCore::WMLInputElement::supportsMaxLength):
Added. Always returns true.
LayoutTests:
- fast/forms/input-maxlength-unsupported-expected.txt: Added.
- fast/forms/input-maxlength-unsupported.html: Added.
- fast/forms/script-tests/input-maxlength-unsupported.js: Added.
- 7:26 PM Changeset in webkit [63941] by
-
- 2 edits in trunk/WebCore
[cleanup] logic to extract adjacent lists and list children in listifyParagraph and unlistifyParagraph should be isolated
https://bugs.webkit.org/show_bug.cgi?id=42841
Reviewed by Kent Tamura.
Added enclosingListChild that takes the list node containing the node for the second argument
to ensure that it only returns the enclosing list child of the specified list node.
Added adjacentEnclosingList that finds adjacent lists of the specified position.
It takes the current position, the adjacent position that may or may not have a list, and the list type,
and avoids a list that belongs to a different table cell or an outer list that contains the current position.
No new tests needed.
- editing/InsertListCommand.cpp:
(WebCore::enclosingListChild): Added. See above.
(WebCore::InsertListCommand::unlistifyParagraph): Uses enclosingListChild.
(WebCore::adjacentEnclosingList): Added. See above.
(WebCore::InsertListCommand::listifyParagraph): Uses adjacentEnclosingList.
- 7:15 PM Changeset in webkit [63940] by
-
- 2 edits in trunk/WebCore
2010-07-22 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
[WIN] Correct DeleteObject usage in PasteboardWin
https://bugs.webkit.org/show_bug.cgi?id=41956
Call DeleteObject() if OpenClipboard() fails and don't
call DeleteObject() on objects returned from SelectObject().
- platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
- 7:02 PM Changeset in webkit [63939] by
-
- 2 edits in trunk/WebCore
2010-07-22 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Log function is incorrectly used.
r63804 used LOG function, but it should receive one more parameter.
Used LOG_ERROR instead, since this is an error message.
https://bugs.webkit.org/show_bug.cgi?id=42842
- platform/efl/WidgetEfl.cpp: (WebCore::Widget::applyFallbackCursor): use LOG_ERROR in place of LOG
- 6:56 PM Changeset in webkit [63938] by
-
- 2 edits in trunk/WebKit2
More Windows build fixing.
- win/WebKit2Generated.make: Copy the new public headers to $(WEBKITOUTPUTDIR)\include\WebKit2.
- 6:30 PM Changeset in webkit [63937] by
-
- 2 edits in trunk/WebKit2
Windows build fix.
- win/WebKit2.vcproj: Added new files.
- 6:24 PM Changeset in webkit [63936] by
-
- 5 edits in branches/safari-533.17-branch
Versioning.
- 6:24 PM Changeset in webkit [63935] by
-
- 2 edits in trunk/LayoutTests
2010-07-22 Cosmin Truta <ctruta@chromium.org>
Reviewed by Darin Adler.
SVG: Temporarily disable the layout test for the bug 41175 on Leopard.
https://bugs.webkit.org/show_bug.cgi?id=42802
- platform/mac-leopard/Skipped: svg/filters/filter-empty-g.svg skipped until fix.
- 6:23 PM Changeset in webkit [63934] by
-
- 1 copy in tags/Safari-533.17.8
New tag.
- 6:11 PM Changeset in webkit [63933] by
-
- 6 edits in trunk/WebKit
2010-07-22 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Implement input method notification
https://bugs.webkit.org/show_bug.cgi?id=42640
Notify browser when keyboard should be shown/hidden. Input method
hints are updated before sending the signal. Client should be able to
determine the input type by calling ewk_view_imh_get().
- efl/EWebLauncher/main.c: (on_inputmethod_changed): example implementation that just prints to stdout if keyboard should be shown or hidden and the imh flags. (browserCreate): listen to signal about input method changing its state.
- efl/WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::setInputMethodState): call new function responsible for implementing this notification.
- efl/ewk/ewk_private.h: ewk_view_input_method_state_set() is called only from inside WebKit.
- efl/ewk/ewk_view.cpp: implement setters and getters (ewk_view_imh_get): (ewk_view_input_method_state_set):
- efl/ewk/ewk_view.h: introduce Ewk_Imh enum which contains the possible input types. (_Ewk_View_Smart_Class::):
- 5:59 PM Changeset in webkit [63932] by
-
- 2 edits in trunk/LayoutTests
2010-07-22 John Gregg <johnnyg@google.com>
Unreviewed; chromium test expectation change.
fast/forms/input-file-directory-upload.html passes on windows after r63914
https://bugs.webkit.org/show_bug.cgi?id=42768
- platform/chromium/test_expectations.txt:
- 5:53 PM Changeset in webkit [63931] by
-
- 14 edits2 adds in branches/safari-533.17-branch
Merge r63927.
- 5:49 PM Changeset in webkit [63930] by
-
- 15 edits6 adds in trunk
Reviewed by Sam Weinig and Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=42193
Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
Step 1: Add the method, and implement one actual delegate call as proof of concept. No tests
fixed, but this makes difference one line smaller on many editing tests.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
- WebProcess/InjectedBundle/API/c/WKBundleBase.h:
- WebProcess/InjectedBundle/API/c/WKBundleNode.cpp: Added. (WKBundleNodeCopyNodeName): (WKBundleNodeGetParent):
- WebProcess/InjectedBundle/API/c/WKBundleNode.h: Added.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageSetEditorClient):
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/API/c/WKBundleRange.cpp: Added. (WKBundleRangeGetStartOffset): (WKBundleRangeGetStartContainer): (WKBundleRangeGetEndOffset): (WKBundleRangeGetEndContainer):
- WebProcess/InjectedBundle/API/c/WKBundleRange.h: Added. Added WKBundleRangeRef and WKBundleNodeRef types for injected bundles. These are just pointers to respective WebCore objects, without any WebKit2 wrappers.
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp: Added. (WebKit::InjectedBundlePageEditorClient::InjectedBundlePageEditorClient): (WebKit::InjectedBundlePageEditorClient::initialize): (WebKit::InjectedBundlePageEditorClient::shouldBeginEditing):
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h: Added.
- WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::shouldBeginEditing):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::initializeInjectedBundleEditorClient):
- WebProcess/WebPage/WebPage.h: (WebKit::WebPage::injectedBundleEditorClient): Added the plumbing for invoking injected bundle code for editor client. There is no real API for editor client yet.
WebKitTools:
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpEditingCallbacks() and setAcceptsEditing().
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::dumpPath): Dump path to a node in a format that's compatible with DumpRenderTree. (WTR::operator<<): Print a range. (WTR::InjectedBundlePage::InjectedBundlePage): Set editor client in addition to existing clients. (WTR::InjectedBundlePage::_shouldBeginEditing): The only client method implemented so far. (WTR::InjectedBundlePage::shouldBeginEditing): Ditto.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added a section for editor client calls.
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::dumpEditingCallbacks): (WTR::LayoutTestController::setAcceptsEditing): (WTR::LayoutTestController::acceptsEditing): (WTR::LayoutTestController::shouldDumpEditingCallbacks): Store m_acceptsEditing and m_dumpEditingCallbacks.
- 5:43 PM Changeset in webkit [63929] by
-
- 3 edits3 adds in trunk
2010-07-22 Kent Tamura <tkent@chromium.org>
Reviewed by Ojan Vafai.
Cancel button of search input field should fire input/change events
https://bugs.webkit.org/show_bug.cgi?id=34393
- fast/forms/script-tests/search-cancel-button-events.js: Added.
- fast/forms/search-cancel-button-events-expected.txt: Added.
- fast/forms/search-cancel-button-events.html: Added.
2010-07-22 Kent Tamura <tkent@chromium.org>
Reviewed by Ojan Vafai.
Cancel button of search input field should fire input/change events
https://bugs.webkit.org/show_bug.cgi?id=34393
Test: fast/forms/search-cancel-button-events.html
- rendering/TextControlInnerElements.cpp: (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
- 5:37 PM Changeset in webkit [63928] by
-
- 2 edits in branches/safari-533.17-branch/WebCore
Merge r63924.
- 5:37 PM Changeset in webkit [63927] by
-
- 14 edits2 copies in trunk
Fix for <rdar://problem/8222626>
Send textDidChangeInTextField delegate callback only in response to typing or other forms of user text input.
Reviewed by Maciej Stachowiak.
WebCore:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Update project files.
- dom/UserTypingGestureIndicator.cpp: Copied from dom/UserGestureIndicator.cpp.
(WebCore::UserTypingGestureIndicator::processingUserTypingGesture):
(WebCore::focusedNode):
(WebCore::UserTypingGestureIndicator::focusedElementAtGestureStart):
(WebCore::UserTypingGestureIndicator::UserTypingGestureIndicator):
(WebCore::UserTypingGestureIndicator::~UserTypingGestureIndicator):
- dom/UserTypingGestureIndicator.h: Copied from dom/UserGestureIndicator.h.
Version of UserGestureIndicator that just tracks keyboard gestures and the focused
node they were targeting.
- editing/Editor.cpp:
(WebCore::Editor::confirmComposition):
(WebCore::Editor::setComposition):
- page/EventHandler.cpp:
(WebCore::EventHandler::keyEvent):
Put UserTypingGestureIndicator on the stack for user generated keyboard events.
WebKit/mac:
The function name no longer perfectly matches the behavior, but I didn't want to break any existing clients. Maybe we
should migrate to a new function name eventually
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::textDidChangeInTextField):
WebKit/win:
The function name no longer perfectly matches the behavior, but I didn't want to break any existing clients. Maybe we
should migrate to a new function name eventually
- WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::textDidChangeInTextField):
- 5:32 PM Changeset in webkit [63926] by
-
- 7 edits3 adds in trunk
2010-07-22 Kent Tamura <tkent@chromium.org>
Reviewed by Ojan Vafai.
<input type=number> stepper buttons should dispatch input/change events
https://bugs.webkit.org/show_bug.cgi?id=42440
- fast/forms/input-number-events-expected.txt: Added.
- fast/forms/input-number-events.html: Added.
- fast/forms/script-tests/input-number-events.js: Added.
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
2010-07-22 Kent Tamura <tkent@chromium.org>
Reviewed by Ojan Vafai.
<input type=number> stepper buttons should dispatch input/change events
https://bugs.webkit.org/show_bug.cgi?id=42440
Test: fast/forms/input-number-events.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepUpFromRenderer): Sets a flag to dispatch 'change' event and dispatches 'input' event if the value is changed.
- 5:29 PM Changeset in webkit [63925] by
-
- 3 edits2 adds in trunk
2010-07-22 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
Make history state methods validate against document URL
https://bugs.webkit.org/show_bug.cgi?id=42858
Test: fast/history/history-replace-illegal.html
- page/History.cpp: (WebCore::History::urlForState):
2010-07-22 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
Make history state methods validate against document URL
https://bugs.webkit.org/show_bug.cgi?id=42858
- fast/history/history-replace-illegal-expected.txt: Added.
- fast/history/history-replace-illegal.html: Added.
- 5:25 PM Changeset in webkit [63924] by
-
- 2 edits in trunk/WebCore
When there are no beforeload listeners on a document,
HTMLLinkElement::process() should be called immediately when the node is
inserted into the document, rather than waiting until after attach is
performed.
<https://bugs.webkit.org/show_bug.cgi?id=42859>
<rdar://problem/8194528>
Reviewed by Maciej Stachowiak.
No new tests.
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::insertedIntoDocument): If there are no
beforeload listeners, call process() immediately. Otherwise, add it as
a post-attach callback.
- 5:18 PM Changeset in webkit [63923] by
-
- 2 edits in trunk/WebCore
2010-07-22 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
REGRESSION: box shadows on WebGL canvas elements repainted every frame
https://bugs.webkit.org/show_bug.cgi?id=42852
Avoid calling HTMLCanvasElement::willDraw() every time a WebGL canvas'
contents update. This call is only needed in the non-compositing
rendering path.
Covered by fast/canvas/webgl/canvas-test.html
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::markContextChanged): (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
- 5:05 PM Changeset in webkit [63922] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-07-22 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: test that inspector will log syntax error in console without crashing
https://bugs.webkit.org/show_bug.cgi?id=42831
- inspector/console-log-syntax-error-expected.txt: Added.
- inspector/console-log-syntax-error.html: Added.
- inspector/resources/syntax-error.js: Added.
- platform/chromium/inspector/console-log-syntax-error-expected.txt: Added.
- 4:52 PM Changeset in webkit [63921] by
-
- 17 edits4 adds in trunk
2010-07-22 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] QtWebKit needs public API for Notifications.
https://bugs.webkit.org/show_bug.cgi?id=41413
Add a DRT API to set a flag so that notification requests are ignored,
and add a test for cancelling a pending notification request.
New API and test are disabled for Chromium port.
- fast/notifications/notifications-cancel-request-permission-expected.txt: Added.
- fast/notifications/notifications-cancel-request-permission.html: Added.
- fast/notifications/resources: Added.
- fast/notifications/resources/notifications-cancel-request-permission.html: Added.
- platform/chromium/test_expectations.txt:
2010-07-22 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] QtWebKit needs public API for Notifications.
https://bugs.webkit.org/show_bug.cgi?id=41413
Remove DumpRenderTree private API and introduce new API.
Also add support for informing the UI when a notification request is cancelled.
- Api/qwebpage.cpp: (QWebPage::setUserPermission):
- Api/qwebpage.h:
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- WebCoreSupport/DumpRenderTreeSupportQt.h:
- WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationPresenterClientQt::requestPermission): (WebCore::NotificationPresenterClientQt::checkPermission): (WebCore::NotificationPresenterClientQt::cancelRequestsForPermission): (WebCore::NotificationPresenterClientQt::allowNotificationForFrame): (WebCore::NotificationPresenterClientQt::toPage): (WebCore::NotificationPresenterClientQt::toFrame):
- WebCoreSupport/NotificationPresenterClientQt.h:
2010-07-22 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] QtWebKit needs public API for Notifications.
https://bugs.webkit.org/show_bug.cgi?id=41413
Update DumpRenderTree and QtTestBrowser to use the new API.
Add new DRT API to flag that notifications permission requests should be ignored.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::requestPermission): (WebCore::WebPage::checkPermission): (WebCore::WebPage::cancelRequestsForPermission):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::ignoreDesktopNotificationPermissionRequests): (LayoutTestController::checkDesktopNotificationPermission):
- DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::ignoreReqestForPermission):
- QtTestBrowser/main.cpp: (LauncherWindow::LauncherWindow):
- QtTestBrowser/webpage.cpp: (WebPage::WebPage): (WebPage::requestPermission): (WebPage::checkPermission): (WebPage::cancelRequestsForPermission):
- QtTestBrowser/webpage.h:
- 4:32 PM Changeset in webkit [63920] by
-
- 2 edits in trunk/WebKit2
Adapt sandbox for new WebProcess bootstrap service naming scheme.
<rdar://problem/8225000>
Patch by Ivan Krstić <ike@apple.com> on 2010-07-22
Reviewed by Anders Carlsson.
- WebProcess/com.apple.WebProcess.sb:
- 4:16 PM Changeset in webkit [63919] by
-
- 2 edits2 deletes in trunk/WebCore
2010-07-22 Patrick Gansterer <paroga@paroga.com>
Reviewed by Ojan Vafai.
Remove useless PlatformScrollBar
https://bugs.webkit.org/show_bug.cgi?id=41911
- WebCore.gypi:
- platform/win/PlatformScrollBar.h: Removed.
- platform/win/PlatformScrollBarWin.cpp: Removed.
- 3:55 PM Changeset in webkit [63918] by
-
- 4 edits2 adds in trunk
[Windows] Home hey doesn't work in first DIV inside a TABLE
https://bugs.webkit.org/show_bug.cgi?id=42767
Reviewed by Ojan Vafai.
WebCore:
The bug was caused by positionAvoidingFirstPositionInTable moving outside of the editing region.
Added a check so that it avoids the first position in the table only if the table is editable.
Test: editing/selection/home-inside-noneditable-table.html
- editing/visible_units.cpp:
(WebCore::positionAvoidingFirstPositionInTable):
LayoutTests:
Added a test to move caret backwards to the line boundary inside a content-editable div
inside a non-editable table.
- editing/selection/home-inside-noneditable-table-expected.txt: Added.
- editing/selection/home-inside-noneditable-table.html: Added.
- resources/dump-as-markup.js: Modified to support multiple calls to dump
(Markup.dump.get if):
(Markup.dump):
(Markup.notifyDone):
- 3:18 PM Changeset in webkit [63917] by
-
- 3 edits in trunk/WebKit2
It should be possible to attach to the WebProcess in gdb during startup
https://bugs.webkit.org/show_bug.cgi?id=42853
Reviewed by Adam Roben.
Create an unique bootstrap service name and pass it to the web process, instead of registering a per process
name (which was incorrect anyway). This lets us get rid of the requirement that the UI process always should be
the parent process of the web process, something which is false when running under the debugger.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
- WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):
- 2:58 PM Changeset in webkit [63916] by
-
- 2 edits in trunk/WebKit2
Don't assert when Connection::invalidate is called before Connection::dispatchConnectionDidClose
https://bugs.webkit.org/show_bug.cgi?id=42851
Reviewed by Sam Weinig.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::dispatchConnectionDidClose):
Just return early if m_client is 0.
- 2:34 PM Changeset in webkit [63915] by
-
- 2 edits in trunk/WebCore
Fix build warning for missing parentheses.
Reviewed by Laszlo Gombos.
Patch by Antonio Gomes <tonikitoo@webkit.org>
WebCore/html/HTMLInputElement.cpp:113: warning: suggest parentheses around '&&' within ' ' - html/HTMLInputElement.cpp:
(WebCore::isNumberCharacter):
- 2:26 PM Changeset in webkit [63914] by
-
- 2 edits in trunk/WebCore
2010-07-22 John Gregg <johnnyg@google.com>
Reviewed by Kent Tamura.
[chromium] fast/forms/input-file-directory-upload.html fails on win after r63454
https://bugs.webkit.org/show_bug.cgi?id=42768
Normalize path separators for the script API by convering \'s to /'s.
Covered by input-file-directory-upload.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setFileListFromRenderer):
- 2:25 PM Changeset in webkit [63913] by
-
- 2 edits in trunk/WebKit2
Use ::MessageBox instead of ::DebugBreak to make the web process wait for a debugger
While ::DebugBreak can make it easier to attach a debugger (because it
brings up the Just-in-Time debugger window), using ::MessageBox has
two advantages:
1) It explains to the user what's going on, so it's harder to
mistake this debugging aid for a bug.
2) It allows you to debug the UI process and the web process using
the same debugger, if desired.
Special thanks to John Sullivan for help with the text that's shown in
the alert.
Fixes <http://webkit.org/b/42848> WebKit2's wait-for-debugger
debugging aid should explain to the user what's happening
Reviewed by John Sullivan and Anders Carlsson.
- WebProcess/WebKitMain.cpp:
(WebKitMain): Use a ::MessageBox instead of a ::DebugBreak to wait for
the debugger. The alert explains to the user what's going on.
- 2:25 PM Changeset in webkit [63912] by
-
- 2 edits in trunk/WebKit2
Make WorkQueue aware of potential errors with ::WaitForMultipleObjects
Fixes <http://webkit.org/b/42846> WorkQueue should detect
::WaitForMultipleObject failures
Reviewed by Anders Carlsson.
- Platform/win/WorkQueueWin.cpp:
(WorkQueue::workQueueThreadBody): Added some assertions about the
various things that can fail with ::WaitForMultipleObjects,
specifically:
- Passing too many objects
- Timeouts (which shouldn't happen since we pass a timeout interval of INFINITE)
- Abandoned mutexes (which shouldn't happen since we don't wait on any mutexes currently)
- Miscellaneous failures
- 2:06 PM Changeset in webkit [63911] by
-
- 2 edits in trunk/WebCore
Rubberstamped by Simon Fraser.
- platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::PlatformStrategies): Add initialization of m_localizationStrategy.
- 1:56 PM Changeset in webkit [63910] by
-
- 11 edits in trunk
WebCore: Make db.changeVersion()'s third parameter optional, as required by the spec.
https://bugs.webkit.org/show_bug.cgi?id=42787
Reviewed by Ojan Vafai.
- bindings/js/JSDatabaseCustom.cpp:
(WebCore::JSDatabase::changeVersion):
- bindings/js/JSDatabaseSyncCustom.cpp:
(WebCore::JSDatabaseSync::changeVersion):
- bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::V8Database::changeVersionCallback):
- bindings/v8/custom/V8DatabaseSyncCustom.cpp:
(WebCore::V8DatabaseSync::changeVersionCallback):
- storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::deliverTransactionCallback):
- storage/SQLTransactionSync.cpp:
(WebCore::SQLTransactionSync::execute):
LayoutTests: Simplify some tests, and make sure db.changeVersion()'s third parameter is optional.
https://bugs.webkit.org/show_bug.cgi?id=42787
Reviewed by Ojan Vafai.
- fast/workers/storage/resources/change-version-sync-1.js:
- fast/workers/storage/resources/change-version-sync-2.js:
- storage/change-version.html:
- 1:43 PM Changeset in webkit [63909] by
-
- 2 edits in trunk/LayoutTests
2010-07-22 Stephen White <senorblanco@chromium.org>
Unreviewed; test expectations fix.
- platform/chromium/test_expectations.txt: Updated expectations to match reality on the bots.
- 1:33 PM Changeset in webkit [63908] by
-
- 9 edits in trunk/WebCore
2010-07-20 Jessie Berlin <jberlin@apple.com>
Reviewed by Darin Adler.
Code Generator: Allow negative and string constants.
Also add tests for hexadecimal numbers.
- bindings/scripts/CodeGeneratorJS.pm: If it is a string, do not try to cast it to an int.
- bindings/scripts/IDLStructure.pm: Add a regex just for constant values that allows strings, hexadecimal numbers, and integral numbers.
- bindings/scripts/test/CPP/WebDOMTestObj.h: Update the tests.
- bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
- bindings/scripts/test/JS/JSTestObj.h: Ditto.
- bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
- bindings/scripts/test/TestObj.idl: Add tests for negative numbers, strings, and hexadecimal numbers.
- bindings/scripts/test/V8/V8TestObj.cpp: Update the tests.
- 1:17 PM Changeset in webkit [63907] by
-
- 4 edits in trunk/WebCore
2010-07-22 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Composited layers don't scroll in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42771
More prep work: make a single scrollPositionChanged() bottleneck method, and use it to
send the scroll event, repaint fixed elements, and update compositing layers.
- page/FrameView.cpp: (WebCore::FrameView::scrollPositionChangedViaPlatformWidget): (WebCore::FrameView::scrollPositionChanged): (WebCore::FrameView::repaintFixedElementsAfterScrolling): (WebCore::FrameView::valueChanged):
- page/FrameView.h:
- platform/ScrollView.cpp: (WebCore::ScrollView::valueChanged):
- 1:00 PM Changeset in webkit [63906] by
-
- 8 edits in trunk
2010-07-22 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
WebKitTestRunner needs to support layoutTestController.dumpChildFramesAsText
https://bugs.webkit.org/show_bug.cgi?id=42325
- platform/mac-wk2/Skipped: Removed a duplicate and sorted lists of tests. Added some tests to the pasteboard list. Removed the tests from the dumpChildFramesAsText list that now pass, and moved others to other lists.
2010-07-22 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
WebKitTestRunner needs to support layoutTestController.dumpChildFramesAsText
https://bugs.webkit.org/show_bug.cgi?id=42325
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpChildFramesAsText.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::dumpFrameText): Added. (WTR::dumpDescendantFramesText): Added. (WTR::InjectedBundlePage::dumpAllFramesText): Added. (WTR::InjectedBundlePage::dump): Changed to use the new whatToDump function instead of the shouldDumpAsText function, and added a case for AllFramesText.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added dumpAllFramesText.
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController): Replaced m_dumpAsText with m_whatToDump.
- WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added dumpChildFramesAsText. Removed shouldDumpAsText, shouldDumpDOMAsWebArchive, and shouldDumpSourceAsWebArchive. Added whatToDump.
- 12:24 PM CodeReview edited by
- (diff)
- 11:39 AM Changeset in webkit [63905] by
-
- 3 edits in trunk/WebKit/chromium
2010-07-22 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
[Chromium] Propagate return value of EventHandler::handleMouseWheelEvent
to caller of WebViewImpl::handleInputEvent.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::mouseWheel): (WebKit::WebViewImpl::handleInputEvent):
- src/WebViewImpl.h:
- 11:18 AM Changeset in webkit [63904] by
-
- 14 edits1 add in trunk
Patch for https://bugs.webkit.org/show_bug.cgi?id=42836
Add localized strings stubs for WebKit2.
Reviewed by Anders Carlsson.
WebCore:
- Convert WebKit (mac) to use a LocalizationStrategy rather than the WebCoreViewFactory for localized strings.
Gets us below 200 tests failing in WebKitTestRunner.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- page/mac/WebCoreViewFactory.h:
- platform/LocalizationStrategy.h: Added.
(WebCore::LocalizationStrategy::~LocalizationStrategy):
- platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::pluginStrategy):
(WebCore::PlatformStrategies::localizationStrategy):
(WebCore::PlatformStrategies::PlatformStrategies):
(WebCore::PlatformStrategies::~PlatformStrategies):
- platform/mac/LocalizedStringsMac.mm:
WebKit/mac:
- Convert WebKit (mac) to use a LocalizationStrategy rather than the WebCoreViewFactory for localized strings.
Gets us below 200 tests failing in WebKitTestRunner.
- WebCoreSupport/WebContextMenuClient.mm:
(fixMenusReceivedFromOldClients): Use LocalizedStrings rather than the factory.
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
- WebCoreSupport/WebViewFactory.mm:
WebKit2:
Gets us below 200 tests failing in WebKitTestRunner.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- 11:08 AM Changeset in webkit [63903] by
-
- 3 edits in trunk/WebKit2
Unreviewed trivial build fix.
[Qt] Mend remaining issues to fix the WebKit2 build.
- Shared/qt/UpdateChunk.h: add missing function
(WebKit::UpdateChunk::isEmpty):
- UIProcess/API/qt/qwkpage_p.h: Add stub implementation
(QWKPagePrivate::pageDidEnterAcceleratedCompositing):
(QWKPagePrivate::pageDidLeaveAcceleratedCompositing):
- 11:01 AM Changeset in webkit [63902] by
-
- 4 edits1 add in trunk
2010-07-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Implement WebContext::applicationCacheDirectory() for the Qt port of WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=42830
No new tests needed.
- WebCore.pri: add ApplicationCacheStorage.h to wk2 headers
- WebCore.pro: add WebContextQt.cpp to sources
2010-07-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Implement WebContext::applicationCacheDirectory() for the Qt port of WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=42830
- UIProcess/qt/WebContextQt.cpp: Added. (WebKit::WebContext::applicationCacheDirectory):
- 10:48 AM Changeset in webkit [63901] by
-
- 2 edits in trunk/WebCore
2010-07-22 Joone Hur <joone.hur@samsung.com>
Reviewed by Antonio Gomes.
[EFL] add support for logging
https://bugs.webkit.org/show_bug.cgi?id=40807
Enable to turn log channels on for EFL port
- platform/efl/LoggingEfl.cpp: (WebCore::InitializeLoggingChannelsIfNecessary):
- 10:04 AM Changeset in webkit [63900] by
-
- 1 edit21 copies in trunk/LayoutTests
Unreviewed.
[Qt] Add platform specific expected results for tests introduced in r62200.
- platform/qt/fast/borders/border-radius-circle-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-circle-expected.txt.
- platform/qt/fast/borders/border-radius-groove-01-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-groove-01-expected.txt.
- platform/qt/fast/borders/border-radius-groove-02-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-groove-02-expected.txt.
- platform/qt/fast/borders/border-radius-groove-03-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-groove-03-expected.txt.
- platform/qt/fast/borders/border-radius-wide-border-01-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-wide-border-01-expected.txt.
- platform/qt/fast/borders/border-radius-wide-border-02-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-wide-border-02-expected.txt.
- platform/qt/fast/borders/border-radius-wide-border-03-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-wide-border-03-expected.txt.
- platform/qt/fast/borders/border-radius-wide-border-04-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-wide-border-04-expected.txt.
- platform/qt/fast/borders/borderRadiusDashed04-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDashed04-expected.txt.
- platform/qt/fast/borders/borderRadiusDashed05-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDashed05-expected.txt.
- platform/qt/fast/borders/borderRadiusDashed06-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDashed06-expected.txt.
- platform/qt/fast/borders/borderRadiusDotted04-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDotted04-expected.txt.
- platform/qt/fast/borders/borderRadiusDotted05-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDotted05-expected.txt.
- platform/qt/fast/borders/borderRadiusDotted06-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDotted06-expected.txt.
- platform/qt/fast/borders/borderRadiusDouble04-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble04-expected.txt.
- platform/qt/fast/borders/borderRadiusDouble05-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble05-expected.txt.
- platform/qt/fast/borders/borderRadiusDouble06-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble06-expected.txt.
- platform/qt/fast/borders/borderRadiusDouble07-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble07-expected.txt.
- platform/qt/fast/borders/borderRadiusDouble08-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble08-expected.txt.
- platform/qt/fast/borders/borderRadiusDouble09-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble09-expected.txt.
- platform/qt/fast/borders/different-color-borders-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/different-color-borders-expected.txt and updated.
- 10:02 AM Changeset in webkit [63899] by
-
- 2 edits in trunk/WebKit/qt
2010-07-22 Jamey Hicks <jamey.hicks@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Enable binding of QObjects to JavaScript environment for inspector frontend
This patch enables QObjects to be bound to global variables in the
javascript environment of the inspector frontend. This is useful
for writing alternate inspector frontends in javascript which need
additional native functionality. It's a lighter-weight alternative
than using an NPAPI plugin.
The code which instantiates QWebInspector uses this by setting the
dynamic property "q_inspectorJavaScriptWindowObjects" on the
QWebInspector. The value of this property should be a
QMap<QString,QVariant> mapping global variable name to QObject.
I have used this to add support for eclipse/chrome remote
debugging in QtTestBrowser.
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientWebPage::InspectorClientWebPage): (WebCore::InspectorClientWebPage::javaScriptWindowObjectCleared): (WebCore::InspectorClientQt::openInspectorFrontend):
- 10:00 AM Changeset in webkit [63898] by
-
- 4 edits in trunk
WebCore: Ureviewed build fix.
Patch by Balazs Kelemen <kb@inf.u-szeged.hu> on 2010-07-22
[Qt] Fix WebKit2 build
https://bugs.webkit.org/show_bug.cgi?id=42638
- WebCore.pri:
- WebCore.pro:
WebKit2: Unreviewed build fix.
Patch by Balazs Kelemen <kb@inf.u-szeged.hu> on 2010-07-22
[Qt] Fix WebKit2 build
https://bugs.webkit.org/show_bug.cgi?id=42638
- UIProcess/API/qt/qwkpage_p.h:
(QWKPagePrivate::setCursor): Added empty implementation.
- 9:42 AM Changeset in webkit [63897] by
-
- 3 edits in trunk/WebKit/chromium
2010-07-22 Darin Fisher <darin@chromium.org>
Reviewed by Kent Tamura.
https://bugs.webkit.org/show_bug.cgi?id=42808
Pass context menu events through WebInputEvent to WebPlugin::handleInputEvent.
The DOM treats a context menu event as a type of mouse event. We therefore
do the same here, and reuse the WebMouseEvent subclass. This makes sense
since a context menu event has (x,y)-coordinates.
- public/WebInputEvent.h: (WebKit::WebInputEvent::): (WebKit::WebInputEvent::isMouseEventType):
- src/WebInputEventConversion.cpp: (WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
- 9:39 AM Changeset in webkit [63896] by
-
- 4 edits in trunk
2010-07-22 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Stop granting universal access to inspector front-end page.
https://bugs.webkit.org/show_bug.cgi?id=42817
- inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::windowObjectCleared):
2010-07-22 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Stop granting universal access to inspector front-end page.
https://bugs.webkit.org/show_bug.cgi?id=42817
- src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::frontendLoaded):
- 9:04 AM Applications using WebKit edited by
- (diff)
- 9:03 AM Changeset in webkit [63895] by
-
- 2 edits in trunk/WebCore
2010-07-22 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix inspector console tests crashes.
- bindings/v8/ScriptValue.cpp: (WebCore::v8ToInspectorValue): (WebCore::ScriptValue::toInspectorValue): enter v8 context before calling GetPropertyNames
- 9:02 AM Applications using WebKit edited by
- Changed Name of TomBrowser to XtremeBrowser added features (diff)
- 8:19 AM Changeset in webkit [63894] by
-
- 2 edits in trunk/WebCore
2010-07-22 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Unreviewed build fix.
[EFL] Build break for SVN r63881
https://bugs.webkit.org/show_bug.cgi?id=42813
- CMakeLists.txt: Add platform/SchemeRegistry.cpp
- 8:03 AM Changeset in webkit [63893] by
-
- 4 edits in trunk/WebKit2
2010-07-22 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Antonio Gomes.
Lazy cursor creation should be guarded by #if USE(LAZY_NATIVE_CURSOR) in WebKit2
- Shared/WebCoreArgumentCoders.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage):
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::setCursor):
- 7:43 AM Changeset in webkit [63892] by
-
- 3 edits in trunk/WebCore
2010-07-22 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Refactor CSSSelector's destructor and make it inline.
Refactor with no behavior change, thus no new tests.
- css/CSSSelector.cpp: (WebCore::CSSSelectorBag::~CSSSelectorBag): Make sure the bag is empty. (WebCore::CSSSelectorBag::add): Renamed from append(). (WebCore::CSSSelector::releaseOwnedSelectorsToBag): (WebCore::CSSSelector::deleteReachableSelectors):
- css/CSSSelector.h: (WebCore::CSSSelector::~CSSSelector):
- 7:33 AM Changeset in webkit [63891] by
-
- 16 edits in trunk/WebCore
2010-07-22 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: should be possible to convert console message arguments to InspectorValues
https://bugs.webkit.org/show_bug.cgi?id=42457
Now it is possible to convert simple JavaScript objects to
InspectorValues.
- bindings/js/ScriptValue.cpp: (WebCore::jsToInspectorValue): (WebCore::ScriptValue::toInspectorValue):
- bindings/js/ScriptValue.h:
- bindings/v8/ScriptValue.cpp: (WebCore::v8ToInspectorValue): (WebCore::ScriptValue::toInspectorValue):
- bindings/v8/ScriptValue.h:
- inspector/ConsoleMessage.cpp: console notifications are pushed to RemoteInspectorFrontend instead of InspectorFrontend. (WebCore::ConsoleMessage::CallFrame::buildInspectorObject): (WebCore::ConsoleMessage::addToFrontend): (WebCore::ConsoleMessage::updateRepeatCountInConsole):
- inspector/ConsoleMessage.h:
- inspector/InjectedScript.cpp: (WebCore::InjectedScript::wrapForConsole): return InspectorValue instead of SerializedScriptValue
- inspector/InjectedScript.h:
- inspector/Inspector.idl:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::clearConsoleMessages): send response directly from the backend (WebCore::InspectorBackend::remoteFrontend):
- inspector/InspectorBackend.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::clearConsoleMessages): don't send notification to the front end, it will be send either from InspectorBackend.cpp if it was a user request or reset message will be send to the front end if the messages are cleared due to page navigation. (WebCore::InspectorController::populateScriptObjects):
- inspector/front-end/ConsoleView.js:
- inspector/front-end/inspector.js:
- 7:26 AM Changeset in webkit [63890] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] REGRESSION(63862): animations/play-state.html fails intermittently
https://bugs.webkit.org/show_bug.cgi?id=42821
- platform/qt/Skipped: animations/play-state.html skipped until fix.
- 7:23 AM Changeset in webkit [63889] by
-
- 2 edits in trunk/WebCore
2010-07-22 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Modifying settings actually modifies defaultValues
https://bugs.webkit.org/show_bug.cgi?id=42816
Avoid using live modifiable objects as property default values.
- inspector/front-end/Settings.js: (WebInspector.Settings): (WebInspector.Settings.prototype.reset): (WebInspector.Settings.prototype._load): (WebInspector.Settings.prototype.installSetting): (WebInspector.Settings.prototype._get):
- 7:07 AM Changeset in webkit [63888] by
-
- 6 edits in trunk/WebCore
2010-07-22 Ben Murdoch <benm@google.com>
Reviewed by Simon Fraser.
Touch events do not affect the :active CSS state
https://bugs.webkit.org/show_bug.cgi?id=39493
Clean the code up by using a typedef based on comments
post landing of the original patch.
No change in functionality so no new tests.
- rendering/HitTestRequest.h: Typedef the HitTestRequestType to unsigned.
- WebCore.exp.in: Update export signature.
- WebCore.order: Ditto.
- page/EventHandler.cpp: use the new typedef.
- page/EventHandler.h: ditto.
- 6:47 AM QtWebKitReleases edited by
- (diff)
- 6:36 AM Changeset in webkit [63887] by
-
- 3 edits in trunk/WebKit/qt
[Qt] Library versioning.
2.1 is branched, trunk will become 2.2.
- Api/qwebkitglobal.h:
- qt_webkit_version.pri:
- 6:29 AM QtWebKitRelease21 created by
- 6:28 AM QtWebKitBackportingFixes edited by
- (diff)
- 6:26 AM Changeset in webkit [63886] by
-
- 14 edits in trunk
2010-07-22 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Rename method for CSS rule source range retrieval and fix return object format
https://bugs.webkit.org/show_bug.cgi?id=42379
WebCore:
- inspector/Inspector.idl:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getRuleRanges):
- inspector/InspectorBackend.h:
- inspector/InspectorBackend.idl:
- inspector/InspectorCSSStore.cpp: (WebCore::InspectorCSSStore::getRuleRanges):
- inspector/InspectorCSSStore.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getRuleRanges):
- inspector/InspectorDOMAgent.h:
- inspector/front-end/DOMAgent.js:
WebKit/chromium:
- src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
LayoutTests:
- inspector/styles-source-offsets.html:
- 6:25 AM QtWebKit edited by
- (diff)
- 6:01 AM Changeset in webkit [63885] by
-
- 3 edits in trunk/WebKitTools
Windows build fix
Inspired by r63881.
- MiniBrowser/MiniBrowser.vcproj:
- WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
Removed pre- and post-build events so they will be inherited from the
vsprops files.
- 5:52 AM Changeset in webkit [63884] by
-
- 7 edits in trunk
2010-07-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium Dev Tools: Separators are missing in the context menu.
- bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::showContextMenu):
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
- platform/ContextMenuItem.h: (WebCore::):
2010-07-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium Dev Tools: Separators are missing in the context menu.
- src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::populateCustomMenuItems):
- 5:41 AM Changeset in webkit [63883] by
-
- 4 edits50 adds in trunk
SVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes change
https://bugs.webkit.org/show_bug.cgi?id=42244
Reviewed by Nikolas Zimmermann.
WebCore:
Implementing svgAttributeChanged and childrenChanged for the base class of all filters,
called SVGFilterPrimitiveStandardAttributes.
Tests: svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop.html
- svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::childrenChanged):
- svg/SVGFilterPrimitiveStandardAttributes.h:
(WebCore::SVGFilterPrimitiveStandardAttributes::invalidateFilter):
LayoutTests:
- platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png: Added.
- svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr.html: Added.
- svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr.html: Added.
- svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr.html: Added.
- svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr.html: Added.
- svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr.html: Added.
- svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop.html: Added.
- svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop.html: Added.
- svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop.html: Added.
- svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop.html: Added.
- svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop.html: Added.
- svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-height-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-result-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-width-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-x-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-y-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop.js: Added.
(executeTest):
- 5:08 AM Changeset in webkit [63882] by
-
- 6 edits in trunk
2010-07-22 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Kent Tamura.
Error properties of the Global Object are missing the DontEnum attribute
https://bugs.webkit.org/show_bug.cgi?id=28771
Add the attributes to become spec compliant.
- runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
2010-07-22 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Kent Tamura.
Error properties of the Global Object are missing the DontEnum attribute
https://bugs.webkit.org/show_bug.cgi?id=28771
Update expected results for tests that now pass.
- fast/js/sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.5_Global_Object/S10.1.5_A2.1_T3-expected.txt:
- fast/js/sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.5_Global_Object/S10.1.5_A2.2_T3-expected.txt:
- fast/js/sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.5_Global_Object/S10.1.5_A2.3_T3-expected.txt:
- 2:36 AM Changeset in webkit [63881] by
-
- 2 edits in trunk/WebKit2
Build fix. Unreviewed.
- win/WebKit2WebProcess.vcproj:
Remove the pre- and post-build events, so that they will use the value
inherited from the vsprops.
- 1:52 AM Changeset in webkit [63880] by
-
- 9 edits in trunk/LayoutTests
2010-07-22 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Sam Weinig.
Improve coverage of fast/dom/prototype-inheritance test
https://bugs.webkit.org/show_bug.cgi?id=42354
Use Object.getOwnPropertyNames rather than for..in to enumerate
the window object's properties, so that non-enumerable (ECMA)
properties are covered as well.
- fast/dom/prototype-inheritance-expected.txt:
- fast/dom/script-tests/prototype-inheritance.js: (propertiesOnObject):
- platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt:
- platform/chromium-win/fast/dom/prototype-inheritance-expected.txt:
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/win/fast/dom/prototype-inheritance-expected.txt:
- 1:20 AM Changeset in webkit [63879] by
-
- 4 edits in trunk/WebCore
2010-07-22 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Small refactoring for input value sanitization
https://bugs.webkit.org/show_bug.cgi?id=42807
Rename some functions to clarify their roles.
- dom/InputElement.cpp: (WebCore::replaceEOLAndLimitLength): Renamed from sanitizeUserInputValue(). (WebCore::InputElement::sanitizeValueForTextField): Renamed from sanitizeValue(), and call replaceEOLAndLimitLength() instead of sanitizeUserInputValue(). (WebCore::InputElement::sanitizeUserInputValue): Just call replaceEOLAndLimitLength(). (WebCore::InputElement::updateValueIfNeeded): Use non-static sanitizeValue() for consistency.
- dom/InputElement.h:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): Revert the change of r63876. It is not needed because of the updateValueIfNeeded() change. (WebCore::HTMLInputElement::sanitizeValue): Apply the sanitizeValue() renaming.
- 12:40 AM Changeset in webkit [63878] by
-
- 5 edits in trunk/WebCore
2010-07-22 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Fisher.
webkitPerformance.timing.responseEnd should not include document parse time
https://bugs.webkit.org/show_bug.cgi?id=42797
No new tests because timing based test would be flaky.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoading): finishedLoading() is called by the platform at the right time, but didReceiveData() synchronously invokes parsing without returning to the event loop prior to this. So by the time the didFinishLoading() method is executed, parsing is finished. The solution is to move this time to didReceiveData() prior to parsing.
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveData): Update the time each time didReceiveData() is called. (WebCore::MainResourceLoader::didFinishLoading): When finished, and after parsing, set responseEnd appropriately.
- loader/MainResourceLoader.h:
- page/Timing.cpp: (WebCore::Timing::resourceLoadTimeRelativeToAbsolute): Now that responseEnd is set correctly, it can be much shorter for very fast loads (like local files). This exposed the fact that this skew check was not tight enough. We need to make sure that the whole range of values from the ResourceLoadTiming API fit within fetchStart-responseEnd, not just that requestTime fits in this range.
Jul 21, 2010:
- 11:52 PM Changeset in webkit [63877] by
-
- 13 edits in trunk
2010-07-21 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
https://bugs.webkit.org/show_bug.cgi?id=42548
- platform/mac-wk2/Skipped: Moved some tests into the correct section now that dumpChildFrameScrollPositions is no longer the reason they fail. Removed now-passing test. Resorted some of the tests.
2010-07-21 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
https://bugs.webkit.org/show_bug.cgi?id=42548
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::numericWindowPropertyValue): Renamed this and moved it up higher in the file. (WTR::dumpFrameScrollPosition): Added argument telling whether to dump the frame name. Changed to a file-internal function instead of a member function. (WTR::dumpDescendantFrameScrollPositions): Added. (WTR::InjectedBundlePage::dumpAllFrameScrollPositions): Added. (WTR::InjectedBundlePage::dump): Changed to call dumpAllFrameScrollPositions when appropriate. Also streamlined all the WKStringToUTF8 call sites. (WTR::InjectedBundlePage::willAddMessageToConsole): Streamlined use of WKStringToUTF8. (WTR::InjectedBundlePage::willSetStatusbarText): Ditto. (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto. (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto. (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for above changes.
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController): Initialize m_shouldDumpAllFrameScrollPositions. (WTR::LayoutTestController::shouldDumpMainFrameScrollPosition): Renamed from shouldDumpFrameScrollPositions.
- WebKitTestRunner/InjectedBundle/LayoutTestController.h: Reorganized the file a bit, added dumpChildFrameScrollPositions and shouldDumpAllFrameScrollPositions, and renamed shouldDumpFrameScrollPositions to shouldDumpMainFrameScrollPosition.
2010-07-21 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
https://bugs.webkit.org/show_bug.cgi?id=42548
Added WKBundleFrameCopyName.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameCopyName): Added.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Ditto.
- WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::name): Added.
- WebProcess/WebPage/WebFrame.h: Ditto.
- 8:08 PM Changeset in webkit [63876] by
-
- 3 edits3 adds in trunk
2010-07-21 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Assertion failure by changing the type of an input element with a
non-number value to 'range'.
https://bugs.webkit.org/show_bug.cgi?id=42643
- fast/forms/input-value-sanitization-expected.txt: Added.
- fast/forms/input-value-sanitization.html: Added.
- fast/forms/script-tests/input-value-sanitization.js: Added.
2010-07-21 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Assertion failure by changing the type of an input element with a
non-number value to 'range'.
https://bugs.webkit.org/show_bug.cgi?id=42643
Test: fast/forms/input-value-sanitization.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): Update the value by HTMLInputElement::sanitizeValue() in a case that storesValueSeparateFromAttribute() state is not changed.
- 7:12 PM Changeset in webkit [63875] by
-
- 1 edit1 add in trunk/LayoutTests
2010-07-21 Justin Schuh <jschuh@chromium.org>
Unreviewed. Build fix.
Added platform test to account for qt's xml parser
- platform/qt/svg/custom/use-invalid-html-expected.txt: Added.
- 6:54 PM Changeset in webkit [63874] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-21 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Copy the test plugin into DumpRenderTree.app/
https://bugs.webkit.org/show_bug.cgi?id=42733
This was dropped in plugin copy refactoring.
- WebKit.gyp:
- 6:27 PM Changeset in webkit [63873] by
-
- 4 edits2 adds18 deletes in trunk/LayoutTests
dumpAsMarkup test conversion: create-list-from-range-selection.html and insert-list-empty-div.html
https://bugs.webkit.org/show_bug.cgi?id=42608
Reviewed by Ojan Vafai.
Converted the tests and removed the platform specific expected results.
- editing/execCommand/create-list-from-range-selection-expected.txt: Added.
- editing/execCommand/create-list-from-range-selection.html: Use dumpAsMarkup
- editing/execCommand/insert-list-empty-div-expected.txt: Added.
- editing/execCommand/insert-list-empty-div.html: Use dumpAsMarkup
- platform/chromium-linux/editing/execCommand/create-list-from-range-selection-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/create-list-from-range-selection-expected.png: Removed.
- platform/chromium-linux/editing/execCommand/insert-list-empty-div-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/create-list-from-range-selection-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/create-list-from-range-selection-expected.png: Removed.
- platform/chromium-win/editing/execCommand/create-list-from-range-selection-expected.txt: Removed.
- platform/chromium-win/editing/execCommand/insert-list-empty-div-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/insert-list-empty-div-expected.png: Removed.
- platform/chromium-win/editing/execCommand/insert-list-empty-div-expected.txt: Removed.
- platform/gtk/editing/execCommand/insert-list-empty-div-expected.txt: Removed.
- platform/mac/editing/execCommand/create-list-from-range-selection-expected.checksum: Removed.
- platform/mac/editing/execCommand/create-list-from-range-selection-expected.png: Removed.
- platform/mac/editing/execCommand/create-list-from-range-selection-expected.txt: Removed.
- platform/mac/editing/execCommand/insert-list-empty-div-expected.checksum: Removed.
- platform/mac/editing/execCommand/insert-list-empty-div-expected.png: Removed.
- platform/mac/editing/execCommand/insert-list-empty-div-expected.txt: Removed.
- platform/qt/editing/execCommand/create-list-from-range-selection-expected.txt: Removed.
- platform/qt/editing/execCommand/insert-list-empty-div-expected.txt: Removed.
- resources/dump-as-markup.js: Added setNodeToDump.
(Markup.setNodeToDump):
- 6:10 PM Changeset in webkit [63872] by
-
- 4 edits1 add in trunk/LayoutTests
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
incorrect tabindex parsing
https://bugs.webkit.org/show_bug.cgi?id=21076
Add a test showing that our parsing of unquoted attributes in
self-closing tags complies with the spec.
- html5lib/resources/webkit02.dat: Added.
- html5lib/runner-expected-html5.txt:
- html5lib/runner-expected.txt:
- html5lib/runner.html:
- 6:08 PM Changeset in webkit [63871] by
-
- 4 edits in trunk/LayoutTests
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Let's pass the doctype01.dat tests again, please
https://bugs.webkit.org/show_bug.cgi?id=42794
The upstream results check the publicId and the systemId, so we need to
make dom2string smarter and print them.
- html5lib/resources/dom2string.js: (dom2string):
- html5lib/runner-expected-html5.txt:
- html5lib/runner-expected.txt:
- 6:04 PM Changeset in webkit [63870] by
-
- 4 edits in trunk
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement spec changes for basefont and bgsound
https://bugs.webkit.org/show_bug.cgi?id=42792
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processStartTagForInHead):
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement spec changes for basefont and bgsound
https://bugs.webkit.org/show_bug.cgi?id=42792
- html5lib/runner-expected-html5.txt:
- 6:03 PM Changeset in webkit [63869] by
-
- 4 edits in trunk
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update a list of tags to match changes in the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=42791
We need to atomize these strings at some point.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody):
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Update a list of tags to match changes in the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=42791
Testing makes perfect.
- html5lib/runner-expected-html5.txt:
- 6:00 PM Changeset in webkit [63868] by
-
- 7 edits in trunk
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTMLTreeBuilder needs to update to match new spec behavior for <button>
https://bugs.webkit.org/show_bug.cgi?id=42233
The spec has some typos in this area, but this is my best guess for
what Ian means. I've filed bugs against the spec for each typo.
- html/HTMLElementStack.cpp: (WebCore::HTMLNames::isScopeMarker): (WebCore::HTMLNames::isButtonScopeMarker): (WebCore::HTMLElementStack::inButtonScope):
- html/HTMLElementStack.h:
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processFakePEndTagIfPInButtonScope): (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag): (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processEndTagForInBody):
- html/HTMLTreeBuilder.h:
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTMLTreeBuilder needs to update to match new spec behavior for <button>
https://bugs.webkit.org/show_bug.cgi?id=42233
Test progression. There's one regression mixed in here. I'll
investigate in the next patch.
- html5lib/runner-expected-html5.txt:
- 5:58 PM Changeset in webkit [63867] by
-
- 3 edits in trunk/LayoutTests
2010-07-21 Justin Schuh <jschuh@chromium.org>
Unreviewed. Build fix.
Removed comment element for test added with:
http://trac.webkit.org/changeset/63865
- svg/custom/use-invalid-html-expected.txt:
- svg/custom/use-invalid-html.xhtml:
- 5:46 PM Changeset in webkit [63866] by
-
- 17 edits in trunk
2010-07-21 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
WebKitTestRunner needs to support dumping of scroll position
https://bugs.webkit.org/show_bug.cgi?id=42514
- platform/mac-wk2/Skipped: Removed now-passing tests from skipped list and moved one miscategorized test.
2010-07-21 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
WebKitTestRunner needs to support dumping of scroll position
https://bugs.webkit.org/show_bug.cgi?id=42514
- MiniBrowser/mac/WebBundle/WebBundleMain.m: (_didClearWindowForFrame): Use JSGlobalContextRef instead of JSContextRef.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::_didClearWindowForFrame): Use JSGlobalContextRef instead of JSContextRef. (WTR::InjectedBundlePage::dump): Call dumpFrameScrollPosition when appropriate. (WTR::numericWindowProperty): Added. Helper for dumpFrameScrollPosition. (WTR::InjectedBundlePage::dumpFrameScrollPosition): Added. (WTR::InjectedBundlePage::didClearWindowForFrame): Use JSGlobalContextRef instead of JSContextRef.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Removed names from arguments that simply repeat the argument type. Added dumpFrameScrollPosition.
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::shouldDumpDOMAsWebArchive): Added. Currently returns false. (WTR::LayoutTestController::shouldDumpSourceAsWebArchive): Added. Currently returns false. (WTR::LayoutTestController::shouldDumpFrameScrollPositions): Added. Matches the logic in DumpRenderTree.
- WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for above changes.
- WebKitTestRunner/WebKitTestRunner.xcodeproj: Added property svn:ignore.
2010-07-21 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
WebKitTestRunner needs to support dumping of scroll position
https://bugs.webkit.org/show_bug.cgi?id=42514
Added WKBundleFrameGetJavaScriptContext function.
- WebKit2.xcodeproj: Added property svn:ignore.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameGetJavaScriptContext): Added.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Ditto.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp: (WebKit::InjectedBundlePageLoaderClient::didClearWindowObjectForFrame):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld): Use JSGlobalContextRef instead of JSContextRef and context instead of ct.
- 5:36 PM Changeset in webkit [63865] by
-
- 3 edits2 adds in trunk
2010-07-21 Justin Schuh <jschuh@chromium.org>
Reviewed by Oliver Hunt.
Prevent DeleteButtonController enable state from changing when not editing
https://bugs.webkit.org/show_bug.cgi?id=42659
Test: svg/custom/use-invalid-html.xhtml
- dom/ContainerNode.cpp: (WebCore::ContainerNode::cloneChildNodes):
2010-07-21 Justin Schuh <jschuh@chromium.org>
Reviewed by Oliver Hunt.
Prevent DeleteButtonController enable state from changing when not editing
https://bugs.webkit.org/show_bug.cgi?id=42659
- svg/custom/use-invalid-html-expected.txt: Added.
- svg/custom/use-invalid-html.xhtml: Added.
- 4:53 PM Changeset in webkit [63864] by
-
- 84 edits4 adds in trunk
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=42605 New border-
radius path-based drawing code has some issues with corner-joins
Reviewed by Dan Bernstein.
GraphicsContext::clipConvexPolygon() now takes a boolean parameter
indicating whether or not the clip should be antialiased.
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
- platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
- platform/graphics/wince/GraphicsContextWince.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
- platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
Compute 4 booleans determining if each edge is a "matching" edge of
not. Send the two appropriate values to clipBorderSidePolygon() so
we can decide there whether or not to antialias the clip based on
matchy-ness.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder):
If both edges are matching, don't antialias. If neither edge
matches, never antialias. If one edge matches and one does not,
apply two clips to get the appropriate antialiasing in each corner.
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):
- rendering/RenderBoxModelObject.h:
LayoutTests: Some of these layout tests are updated results from the fix for
https://bugs.webkit.org/show_bug.cgi?id=42605 New border-
radius path-based drawing code has some issues with corner-joins.
The others have been in need of an update since
https://bugs.webkit.org/show_bug.cgi?id=9197 , but since the
differences were only detectable visually and with a pixel-text
tolerance of 0 (not the default), they slipped under the rug until
now.
Reviewed by Dan Bernstein.
New test:
- fast/borders/different-color-borders.html: Added.
- platform/mac/fast/borders/border-radius-circle-expected.checksum:
- platform/mac/fast/borders/border-radius-circle-expected.png:
- platform/mac/fast/borders/border-radius-constraints-expected.checksum:
- platform/mac/fast/borders/border-radius-constraints-expected.png:
- platform/mac/fast/borders/border-radius-groove-01-expected.checksum:
- platform/mac/fast/borders/border-radius-groove-01-expected.png:
- platform/mac/fast/borders/border-radius-groove-02-expected.checksum:
- platform/mac/fast/borders/border-radius-groove-02-expected.png:
- platform/mac/fast/borders/border-radius-groove-03-expected.checksum:
- platform/mac/fast/borders/border-radius-groove-03-expected.png:
- platform/mac/fast/borders/border-radius-huge-assert-expected.checksum:
- platform/mac/fast/borders/border-radius-huge-assert-expected.png:
- platform/mac/fast/borders/border-radius-wide-border-02-expected.checksum:
- platform/mac/fast/borders/border-radius-wide-border-02-expected.png:
- platform/mac/fast/borders/border-radius-wide-border-03-expected.checksum:
- platform/mac/fast/borders/border-radius-wide-border-03-expected.png:
- platform/mac/fast/borders/border-radius-wide-border-04-expected.checksum:
- platform/mac/fast/borders/border-radius-wide-border-04-expected.png:
- platform/mac/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum:
- platform/mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
- platform/mac/fast/borders/borderRadiusArcs01-expected.checksum:
- platform/mac/fast/borders/borderRadiusArcs01-expected.png:
- platform/mac/fast/borders/borderRadiusDashed01-expected.checksum:
- platform/mac/fast/borders/borderRadiusDashed01-expected.png:
- platform/mac/fast/borders/borderRadiusDashed02-expected.checksum:
- platform/mac/fast/borders/borderRadiusDashed02-expected.png:
- platform/mac/fast/borders/borderRadiusDashed03-expected.checksum:
- platform/mac/fast/borders/borderRadiusDashed03-expected.png:
- platform/mac/fast/borders/borderRadiusDashed04-expected.checksum:
- platform/mac/fast/borders/borderRadiusDashed04-expected.png:
- platform/mac/fast/borders/borderRadiusDotted02-expected.checksum:
- platform/mac/fast/borders/borderRadiusDotted02-expected.png:
- platform/mac/fast/borders/borderRadiusDotted03-expected.checksum:
- platform/mac/fast/borders/borderRadiusDotted03-expected.png:
- platform/mac/fast/borders/borderRadiusDotted04-expected.checksum:
- platform/mac/fast/borders/borderRadiusDotted04-expected.png:
- platform/mac/fast/borders/borderRadiusDotted06-expected.checksum:
- platform/mac/fast/borders/borderRadiusDotted06-expected.png:
- platform/mac/fast/borders/borderRadiusDouble01-expected.checksum:
- platform/mac/fast/borders/borderRadiusDouble01-expected.png:
- platform/mac/fast/borders/borderRadiusDouble02-expected.checksum:
- platform/mac/fast/borders/borderRadiusDouble02-expected.png:
- platform/mac/fast/borders/borderRadiusDouble03-expected.checksum:
- platform/mac/fast/borders/borderRadiusDouble03-expected.png:
- platform/mac/fast/borders/borderRadiusDouble05-expected.checksum:
- platform/mac/fast/borders/borderRadiusDouble05-expected.png:
- platform/mac/fast/borders/borderRadiusDouble06-expected.checksum:
- platform/mac/fast/borders/borderRadiusDouble06-expected.png:
- platform/mac/fast/borders/borderRadiusDouble08-expected.checksum:
- platform/mac/fast/borders/borderRadiusDouble08-expected.png:
- platform/mac/fast/borders/borderRadiusGroove01-expected.checksum:
- platform/mac/fast/borders/borderRadiusGroove01-expected.png:
- platform/mac/fast/borders/borderRadiusGroove02-expected.checksum:
- platform/mac/fast/borders/borderRadiusGroove02-expected.png:
- platform/mac/fast/borders/borderRadiusInset01-expected.checksum:
- platform/mac/fast/borders/borderRadiusInset01-expected.png:
- platform/mac/fast/borders/borderRadiusInvalidColor-expected.checksum:
- platform/mac/fast/borders/borderRadiusInvalidColor-expected.png:
- platform/mac/fast/borders/borderRadiusOutset01-expected.checksum:
- platform/mac/fast/borders/borderRadiusOutset01-expected.png:
- platform/mac/fast/borders/borderRadiusRidge01-expected.checksum:
- platform/mac/fast/borders/borderRadiusRidge01-expected.png:
- platform/mac/fast/borders/borderRadiusSolid01-expected.checksum:
- platform/mac/fast/borders/borderRadiusSolid01-expected.png:
- platform/mac/fast/borders/borderRadiusSolid02-expected.checksum:
- platform/mac/fast/borders/borderRadiusSolid02-expected.png:
- platform/mac/fast/borders/borderRadiusSolid03-expected.checksum:
- platform/mac/fast/borders/borderRadiusSolid03-expected.png:
- platform/mac/fast/borders/borderRadiusSolid04-expected.checksum:
- platform/mac/fast/borders/borderRadiusSolid04-expected.png:
- platform/mac/fast/borders/different-color-borders-expected.checksum: Added.
- platform/mac/fast/borders/different-color-borders-expected.png: Added.
- platform/mac/fast/borders/different-color-borders-expected.txt: Added.
- platform/mac/fast/borders/fieldsetBorderRadius-expected.checksum:
- platform/mac/fast/borders/fieldsetBorderRadius-expected.png:
- 4:19 PM Changeset in webkit [63863] by
-
- 19 edits2 adds in trunk
2010-07-21 Brady Eidson <beidson@apple.com>
Reviewed by Geoffrey Garen.
Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=42783
- src/WebSecurityPolicy.cpp: (WebKit::WebSecurityPolicy::registerURLSchemeAsLocal): (WebKit::WebSecurityPolicy::registerURLSchemeAsNoAccess): (WebKit::WebSecurityPolicy::registerURLSchemeAsSecure):
2010-07-21 Brady Eidson <beidson@apple.com>
Reviewed by Geoffrey Garen.
Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=42783
- Api/qwebpage.cpp: (QWebPage::acceptNavigationRequest):
- Api/qwebsecurityorigin.cpp: (QWebSecurityOrigin::addLocalScheme): (QWebSecurityOrigin::removeLocalScheme): (QWebSecurityOrigin::localSchemes):
2010-07-21 Brady Eidson <beidson@apple.com>
Reviewed by Geoffrey Garen.
Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=42783
- WebView.cpp: (WebView::registerURLSchemeAsLocal): (WebView::registerURLSchemeAsSecure):
2010-07-21 Brady Eidson <beidson@apple.com>
Reviewed by Geoffrey Garen.
Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=42783
- WebView/WebView.mm: (+[WebView _registerURLSchemeAsSecure:]): (+[WebView registerURLSchemeAsLocal:]):
2010-07-21 Brady Eidson <beidson@apple.com>
Reviewed by Geoffrey Garen.
Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=42783
No new tests. (No change in behavior)
- GNUmakefile.am:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::isMixedContent): (WebCore::FrameLoader::loadFrameRequest):
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canLoad): (WebCore::SecurityOrigin::isLocal):
- page/SecurityOrigin.h:
- platform/SchemeRegistry.cpp: Added. (WebCore::localSchemes): (WebCore::secureSchemes): (WebCore::schemesWithUniqueOrigins): (WebCore::SchemeRegistry::registerURLSchemeAsLocal): (WebCore::SchemeRegistry::removeURLSchemeRegisteredAsLocal): (WebCore::SchemeRegistry::localURLSchemes): (WebCore::SchemeRegistry::shouldTreatURLAsLocal): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal): (WebCore::SchemeRegistry::registerURLSchemeAsNoAccess): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsNoAccess): (WebCore::SchemeRegistry::registerURLSchemeAsSecure): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsSecure):
- platform/SchemeRegistry.h: Added.
- 4:16 PM Changeset in webkit [63862] by
-
- 3 edits in trunk/WebCore
2010-07-21 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Assertion failure in AnimationBase::updateStateMachine() coming out of paused state
https://bugs.webkit.org/show_bug.cgi?id=37993
Added logic to properly handle pausing and resuming when in the
AnimationStateStartWaitStyleAvailable state. This was causing an
assert when going out of the pause state because the paused flag
was not set.
The fix is a straightforward implementation, going into a new
AnimationStatePausedWaitStyleAvailable state and setting the paused
flag (actually setting the m_pauseTime variable to something other
than -1). Also added handling of the new state, both when the
"style available" callback comes in while in this state and when
unpausing while in this state.
For now a LayoutTest is not possible since there's no way to go in
and out of the pause state. I've opened https://bugs.webkit.org/show_bug.cgi?id=42790
to track this.
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine):
- page/animation/AnimationBase.h: (WebCore::AnimationBase::):
- 3:59 PM Changeset in webkit [63861] by
-
- 7 edits in trunk/LayoutTests
2010-07-21 Peter Beverloo <peter@lvp-media.com>
Reviewed by Darin Adler.
Updated six more layout tests from -khtml to -webkit
https://bugs.webkit.org/show_bug.cgi?id=42788
- css3/khtml-background-size-0x0-bmp.html:
- editing/deleting/delete-3959464-fix.html:
- editing/deleting/delete-and-undo.html:
- editing/deleting/delete-at-paragraph-boundaries-001.html:
- editing/deleting/delete-at-paragraph-boundaries-002.html:
- editing/deleting/delete-at-paragraph-boundaries-003.html:
- 3:46 PM Changeset in webkit [63860] by
-
- 3 edits in trunk/LayoutTests
2010-07-21 Adam Barth <abarth@webkit.org>
Skip html5lib/runner.html on these platforms because the
<keygen> element creates a different DOM. I need to
investigate why they're getting a different DOM, but I don't
have time to do that right now.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 3:12 PM Changeset in webkit [63859] by
-
- 6 edits2 adds in trunk
2010-07-21 Bo Liu <boliu@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Add chromium WebMediaPlayer to PlatformMedia
https://bugs.webkit.org/show_bug.cgi?id=41295
- platform/graphics/MediaPlayer.h: (WebCore::PlatformMedia::):
2010-07-21 Bo Liu <boliu@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Add chromium WebMediaPlayer to PlatformMedia
https://bugs.webkit.org/show_bug.cgi?id=41295
- WebKit.gyp:
- public/WebMediaElement.h: Added.
- src/WebMediaElement.cpp: Added. (WebKit::WebMediaElement::player): (WebKit::WebMediaElement::WebMediaElement): (WebKit::WebMediaElement::operator=): (WebKit::WebMediaElement::operator PassRefPtr<HTMLMediaElement>):
- src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::fromMediaElement): (WebKit::WebMediaPlayerClientImpl::mediaPlayer): (WebKit::WebMediaPlayerClientImpl::platformLayer): (WebKit::WebMediaPlayerClientImpl::platformMedia):
- src/WebMediaPlayerClientImpl.h:
- 2:41 PM Changeset in webkit [63858] by
-
- 11 edits7 adds in trunk/LayoutTests
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Pull HTML5lib test suite from upstream
https://bugs.webkit.org/show_bug.cgi?id=42776
Grab a bunch of new tests from html5lib upstream. Also, upstream
tweaked some of our tests, so I've updated our tests to match the
upstream tweaks.
- html5lib/resources/adoption01.dat:
- html5lib/resources/doctype01.dat:
- html5lib/resources/scripted/adoption01.dat: Added.
- html5lib/resources/scripted/webkit01.dat: Added.
- html5lib/resources/tests1.dat:
- html5lib/resources/tests17.dat: Added.
- html5lib/resources/tests18.dat: Added.
- html5lib/resources/tests19.dat: Added.
- html5lib/resources/tests2.dat:
- html5lib/resources/tests20.dat: Added.
- html5lib/resources/tricky01.dat:
- html5lib/resources/webkit01.dat:
- html5lib/runner-expected-html5.txt:
- html5lib/runner-expected.txt:
- html5lib/runner.html:
- html5lib/webkit-resumer-expected.txt:
- 2:16 PM Changeset in webkit [63857] by
-
- 15 edits in trunk/LayoutTests
2010-07-21 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
convert more layout tests from -khtml to -webkit
https://bugs.webkit.org/show_bug.cgi?id=42786
This is a follow up to r63854.
- fast/backgrounds/size/backgroundSize02.html:
- fast/backgrounds/size/backgroundSize03.html:
- fast/backgrounds/size/backgroundSize04.html:
- fast/backgrounds/size/backgroundSize05.html:
- fast/backgrounds/size/backgroundSize06.html:
- fast/backgrounds/size/backgroundSize07.html:
- fast/backgrounds/size/backgroundSize08.html:
- fast/backgrounds/size/backgroundSize09.html:
- fast/backgrounds/size/backgroundSize10.html:
- fast/backgrounds/size/backgroundSize11.html:
- fast/backgrounds/size/backgroundSize12.html:
- fast/backgrounds/size/backgroundSize13.html:
- fast/backgrounds/size/backgroundSize14.html:
- fast/backgrounds/size/backgroundSize15.html:
- 2:07 PM Changeset in webkit [63856] by
-
- 6 edits in trunk
2010-07-21 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson.
Composited layers don't scroll in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42771
Prep work: FrameView::scrollPositionChanged() sounds like a generic "did scroll" bottleneck,
but this is deceiving. It's only every called on one platform (Mac) when the NSScrollView gets
scrolled, so rename it to FrameView::scrollPositionChangedViaPlatformWidget().
- WebCore.exp.in:
- page/FrameView.cpp: (WebCore::FrameView::scrollPositionChangedViaPlatformWidget):
- page/FrameView.h:
- 1:54 PM Changeset in webkit [63855] by
-
- 2 edits in trunk/WebKit2
Handle broken pipes in more places in CoreIPC
Fixes <http://webkit.org/b/42784> Assertion failure in
Connection::readEventHandler when WebKitTestRunner exits
Reviewed by Anders Carlsson.
- Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::readEventHandler): Check for a broken pipe
whenever we call ::PeekNamedPipe.
- 1:39 PM Changeset in webkit [63854] by
-
- 38 edits2 adds in trunk
2010-07-21 Peter Beverloo <peter@lvp-media.com>
Reviewed by Eric Carlson.
Removed support for the -khtml CSS vendor prefix and limit the
-apple prefix to two properties (dashboard-region and line-clamp).
Listed properties in these updated have been changed to -webkit.
- fast/block/positioning/height-change.html: -apple-box
- fast/block/positioning/resources/window-height-change-frame-flex.html: -apple-box
- fast/borders/border-image-omit-right-slice.html: -khtml-border-image
- fast/css/apple-prefix.html: -khtml-box-orient
- fast/css/legacy-opacity-styles-expected.txt: -*-opacity
- fast/css/legacy-opacity-styles.html: -*-opacity
- fast/css/limited-vendor-prefix-behavior-expected.txt: Added.
- fast/css/limited-vendor-prefix-behavior.html: Added.
- fast/flexbox/001.html: -khtml-box-flex
- fast/flexbox/002.html: -khtml-box, -khtml-box-align, -khtml-box-orient
- fast/flexbox/003.html: -khtml-box, -khtml-box-align, -khtml-box-orient
- fast/flexbox/004.html: -khtml-box
- fast/flexbox/005.html: -khtml-box
- fast/flexbox/006.html: -khtml-box
- fast/flexbox/007.html: -khtml-box
- fast/flexbox/008.html: -khtml-box
- fast/flexbox/009.html: -khtml-box
- fast/flexbox/010.html: -khtml-box
- fast/flexbox/011.html: -khtml-box, -khtml-box-flex
- fast/flexbox/012.html: -khtml-box, -khtml-box-orient, -khtml-box-align
- fast/flexbox/013.html: -khtml-box, -khtml-box-flex
- fast/flexbox/014.html: -khtml-box, -khtml-box-orient, -khtml-box-flex
- fast/flexbox/015.html: -khtml-box, -khtml-box-flex, -khtml-box-flex
- fast/flexbox/016.html: -khtml-box-flex, -khtml-box, -khtml-box-orient
- fast/flexbox/017.html: -khtml-box, -khtml-box-orient, -webkit-box-pack, -khtml-box-direction
- fast/flexbox/018.html: -khtml-box, -khtml-box-orient, -khtml-box-pack
- fast/flexbox/019.html: -khtml-box, -khtml-box-pack, -khtml-box-orient
- fast/flexbox/020.html: -khtml-box, -khtml-box-flex-group, -khtml-box-flex
- fast/flexbox/021.html: -khtml-box, -khtml-box-flex
- fast/flexbox/022.html: -khtml-box, -khtml-box-flex
- fast/flexbox/023.html: -khtml-box
- fast/flexbox/024.html: -khtml-box, -khtml-box-orient
- fast/flexbox/025.html: -khtml-box, -khtml-box-flex
- fast/flexbox/026.html: -khtml-box, -khtml-box-flex
- fast/flexbox/child-flexing.html: -khtml-box, -khtml-box-align, -khtml-box-orient
- fast/repaint/flexible-box-overflow-horizontal.html: -khtml-box, -khtml-box-align, -khtml-box-orient
- fast/repaint/flexible-box-overflow.html: -khtml-box, -khtml-box-align, -khtml-box-orient
2010-07-21 Peter Beverloo <peter@lvp-media.com>
Reviewed by Eric Carlson.
Removed support for the -khtml CSS vendor prefix and limit the
-apple prefix to two properties (dashboard-region and line-clamp).
Test: fast/css/limited-vendor-prefix-behavior.html
- css/CSSParser.cpp: (WebCore::cssPropertyID):
- 1:30 PM Changeset in webkit [63853] by
-
- 2 edits in trunk/WebKitTools
[wx] Build fix, adding the WebCore/bindings/generic dir to the list of build dirs.
- 1:25 PM Changeset in webkit [63852] by
-
- 2 edits in trunk/WebKit2
Teach CoreIPC how to handle messages that are larger than the pipe's buffer
::GetOverlappedResult and ::ReadFile can fail with ERROR_MORE_DATA
when there is more data available on the pipe than was requested in
the read operation. In those cases, the appropriate response is to
perform another read operation to read the extra data. We now do this.
Also, MSDN says that, because we are doing asynchronous read
operations, we should not pass a pointer to ::ReadFile to find out how
many bytes were read. Instead we should always call
::GetOverlappedResult to find this out. I've changed
Connection::readEventHandler to have a single loop that calls
::GetOverlappedResult and ::ReadFile in alternation, rather than
sometimes calling ::ReadFile multiple times in a row, to satisfy this
requirement.
In order to simplify the logic in this function, I've made us request
only a single byte from the pipe when there are no messages already in
the pipe. (Previously we were requesting 4096 bytes in this case.)
This allows us not to have to consider the case where the received
message is smaller than our read buffer. If we decide that this has a
negative impact on performance, we can of course change it. I've
mitigated this somewhat by using ::PeekNamedMessage to find out the
size of the next message in the pipe (if any), so that we can read it
all in one read operation.
Fixes <http://webkit.org/b/42710> <rdar://problem/8197571> Assertion
in Connection::readEventHandler when launching WebKitTestRunner
Reviewed by Anders Carlsson.
- Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::readEventHandler): Put the call to
::GetOverlappedResult in the same loop as ::ReadFile so that we will
call them alternately. If ::GetOverlappedResult fails with
ERROR_MORE_DATA, use ::PeekNamedPipe to determine the size of the rest
of the message, then read it from the pipe. After dispatching the
message, use ::PeekNamedPipe to find out the size of the next message
in the pipe so we can read it all in one operation. If there's no
message in the pipe, we'll request just a single byte of the next
message that becomes available, and Windows will tell us when the rest
of the message is ready. If ::ReadFile fails with ERROR_MORE_DATA it
means there is data available now even though we didn't think there
was any. We go back to the top of the loop in this case and call
::GetOverlappedResult again to retrieve the available data.
- 1:23 PM Changeset in webkit [63851] by
-
- 4 edits in trunk/WebCore
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Fix the last tree HTML5 tree builder crashes
https://bugs.webkit.org/show_bug.cgi?id=42773
This patch changes the internal representation of a bookmark to handle
the case where one of the adjecent entries in the list of active
formatting elements is actually a marker.
After this patch, the bookmarking mechanism isn't as general, but it
works for the cases we need in the adoption agency.
Also, after this patch, there aren't any more known crashers in the
HTML5 tree builder. :)
- html/HTMLFormattingElementList.cpp: (WebCore::HTMLFormattingElementList::bookmarkFor): (WebCore::HTMLFormattingElementList::swapTo):
- html/HTMLFormattingElementList.h: (WebCore::HTMLFormattingElementList::Bookmark::Bookmark): (WebCore::HTMLFormattingElementList::Bookmark::moveToAfter): (WebCore::HTMLFormattingElementList::Bookmark::hasBeenMoved): (WebCore::HTMLFormattingElementList::Bookmark::mark): (WebCore::HTMLFormattingElementList::first):
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
- 1:10 PM Changeset in webkit [63850] by
-
- 10 edits in trunk
Patch for https://bugs.webkit.org/show_bug.cgi?id=42539
WebKitTestRunner needs to support printing ALERT, PROMPT and CONFIRM messages
Reviewed by Anders Carlsson.
WebKit2:
- Convert injected bundle UIClient functions to will-style, at least until we establish more concrete use cases for them past the TestRunner.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::willAddMessageToConsole):
(WebKit::InjectedBundlePageUIClient::willSetStatusbarText):
(WebKit::InjectedBundlePageUIClient::willRunJavaScriptAlert):
(WebKit::InjectedBundlePageUIClient::willRunJavaScriptConfirm):
(WebKit::InjectedBundlePageUIClient::willRunJavaScriptPrompt):
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::addMessageToConsole):
(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):
(WebKit::WebChromeClient::setStatusbarText):
WebKitTools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::_willAddMessageToConsole):
(WTR::InjectedBundlePage::_willSetStatusbarText):
(WTR::InjectedBundlePage::_willRunJavaScriptAlert):
(WTR::InjectedBundlePage::_willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::_willRunJavaScriptPrompt):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::willSetStatusbarText):
(WTR::InjectedBundlePage::willRunJavaScriptAlert):
(WTR::InjectedBundlePage::willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::willRunJavaScriptPrompt):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
LayoutTests:
- platform/mac-wk2/Skipped:
- 12:38 PM Changeset in webkit [63849] by
-
- 2 edits in trunk/WebCore
2010-07-21 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Disable overzealous ASSERT
https://bugs.webkit.org/show_bug.cgi?id=42775
No new tests because no changed functionality.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading):
- 12:27 PM Changeset in webkit [63848] by
-
- 3 edits in trunk/WebKit2
2010-07-21 Simon Fraser <Simon Fraser>
Windows build fix.
Need to supply implementations of PageClient::pageDidEnterAcceleratedCompositing()
and pageDidLeaveAcceleratedCompositing() for WebView on Windows.
- UIProcess/win/WebView.cpp: (WebKit::WebView::pageDidEnterAcceleratedCompositing): (WebKit::WebView::pageDidLeaveAcceleratedCompositing):
- UIProcess/win/WebView.h:
- 11:38 AM Changeset in webkit [63847] by
-
- 5 edits in trunk/WebCore
2010-07-21 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
Crash in Notification::disconnectFrame() triggered by Frame::lifeSupportTimerFired()
https://bugs.webkit.org/show_bug.cgi?id=42534
Call NotificationsCenter::disconnectFrame() when the frame is disconnected from the page.
Calling it from the destructor of Frame is too late and sometimes causes access violation.
I was not able to reproduce this crash, so did not add new tests.
This patch is based on the error reported in
http://code.google.com/p/chromium/issues/detail?id=49323.
- page/DOMWindow.cpp: (WebCore::DOMWindow::pageDestroyed):
- page/DOMWindow.h:
- page/Frame.cpp: (WebCore::Frame::pageDestroyed):
- 11:16 AM Changeset in webkit [63846] by
-
- 5 edits in trunk
Don't assert when clicking on a plug-in in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42762
Reviewed by Sam Weinig.
WebCore:
Remove a now invalid assert and return false instead.
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMouseDownEventToWidget):
WebKit2:
Add stub for PluginView::handleEvent.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::handleEvent):
- WebProcess/Plugins/PluginView.h:
- 11:14 AM Changeset in webkit [63845] by
-
- 7 edits in trunk/WebCore
2010-07-21 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] Revert r60670 as it introduced a regression: in some cases named children couldn't be retrieved.
https://bugs.webkit.org/show_bug.cgi?id=42766
See http://code.google.com/p/chromium/issues/detail?id=48804 for more details.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
- bindings/v8/V8DOMWindowShell.h:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::namedPropertyDeleter): (WebCore::V8HTMLDocument::namedPropertyGetter): (WebCore::V8HTMLDocument::indexedPropertyGetter): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8):
- 10:53 AM Changeset in webkit [63844] by
-
- 16 edits in trunk
2010-07-21 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Update plug-in proxy backed <video> and <audio> elements.
https://bugs.webkit.org/show_bug.cgi?id=42770
<rdar://problem/7963467>
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged): Only call m_player->setControls when the 'controls' attribute changes. (WebCore::HTMLMediaElement::createRenderer): (WebCore::HTMLMediaElement::attach): If we have a proxy widget, call the WebFrameLoaderClient's 'hide' and 'show' methods for the media proxy plug-in to make sure we remove and re-add the plug-in's view to the global list of plugin views. (WebCore::HTMLMediaElement::createMediaPlayerProxy): Bail if m_proxyWidget is non-NULL
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::hideMediaPlayerProxyPlugin): Empty stub method. (WebCore::EmptyFrameLoaderClient::showMediaPlayerProxyPlugin): Ditto.
- loader/FrameLoader.cpp:
- loader/FrameLoaderClient.h:
- loader/SubframeLoader.cpp: (WebCore::FrameLoader::loadMediaPlayerProxyPlugin): Always set m_containsPlugIns in loadMediaPlayerProxyPlugin(), even when we don't have a renderer. (WebCore::FrameLoader::hideMediaPlayerProxyPlugin): New, call hideMediaPlayerProxyPlugin. (WebCore::FrameLoader::showMediaPlayerProxyPlugin): New, call showMediaPlayerProxyPlugin.
- platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::setControls): (WebCore::MediaPlayer::setControls): New, pass through to media engine. (WebCore::MediaPlayer::enterFullscreen): Ditto. (WebCore::MediaPlayer::exitFullscreen): Ditto.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setControls): (WebCore::MediaPlayerPrivateInterface::enterFullscreen): (WebCore::MediaPlayerPrivateInterface::exitFullscreen):
2010-07-21 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Update plug-in proxy backed <video> and <audio> elements.
https://bugs.webkit.org/show_bug.cgi?id=42770
<rdar://problem/7963467>
- Plugins/WebPluginController.h:
- Plugins/WebPluginController.mm: (-[WebPluginController dealloc]): Release _viewsNotInDocument. (-[WebPluginController stopAllPlugins]): Stop plug-ins not in the document. (-[WebPluginController pluginViewCreated:]): New, add a View (plug-in) to _viewsNotInDocument. (+[WebPluginController pluginViewHidden:]): New, remove the view (plug-in) from pluginViews. (-[WebPluginController addPlugin:]): Remove the new plug-in from _viewsNotInDocument.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Remove PLUGIN_PROXY_FOR_VIDEO code, the media player proxy plug-in should never be allocated by this method. (WebFrameLoaderClient::createMediaPlayerProxyPlugin): New, allocate a media player proxy.
- WebView/WebView.mm: (-[WebView _videoProxyPluginForMIMEType:]): New. Identical to _pluginForMIMEType except it doesn't consider the arePlugInsEnabled preference.
- WebView/WebViewInternal.h:
- 10:51 AM Changeset in webkit [63843] by
-
- 25 edits in trunk/WebKit2
2010-07-21 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson.
Get accelerated compositing working with webkit2
https://bugs.webkit.org/show_bug.cgi?id=41084
Hook up dynamic DrawingArea switching, so that when the WebProcess hits a page
that requires accelerated compositing, we switch to the LayerBackedDrawingArea.
- Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: (DrawingAreaProxyMessage::):
- Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: (WebPageProxyMessage::):
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::pageDidEnterAcceleratedCompositing): (WebKit::PageClientImpl::pageDidLeaveAcceleratedCompositing):
- UIProcess/API/mac/WKView.mm: (-[WKView _startAcceleratedCompositing:]): (-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaProxy::]): (-[WKView _pageDidEnterAcceleratedCompositing]): (-[WKView _pageDidLeaveAcceleratedCompositing]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::didReceiveSyncMessage):
- UIProcess/ChunkedUpdateDrawingAreaProxy.h:
- UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::): (WebKit::DrawingAreaProxy::type):
- UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::didSetSize): (WebKit::LayerBackedDrawingAreaProxy::didReceiveMessage): (WebKit::LayerBackedDrawingAreaProxy::didReceiveSyncMessage):
- UIProcess/LayerBackedDrawingAreaProxy.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setDrawingArea): (WebKit::WebPageProxy::didReceiveSyncMessage): (WebKit::WebPageProxy::didEnterAcceleratedCompositing): (WebKit::WebPageProxy::didLeaveAcceleratedCompositing):
- UIProcess/WebPageProxy.h:
- UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm: (WebKit::LayerBackedDrawingAreaProxy::attachCompositingContext):
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::attachRootGraphicsLayer):
- WebProcess/WebPage/ChunkedUpdateDrawingArea.h: (WebKit::ChunkedUpdateDrawingArea::attachCompositingContext): (WebKit::ChunkedUpdateDrawingArea::setRootCompositingLayer):
- WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create):
- WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::): (WebKit::DrawingArea::type):
- WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea): (WebKit::LayerBackedDrawingArea::setNeedsDisplay): (WebKit::LayerBackedDrawingArea::setSize): (WebKit::LayerBackedDrawingArea::didUpdate): (WebKit::LayerBackedDrawingArea::setRootCompositingLayer):
- WebProcess/WebPage/LayerBackedDrawingArea.h:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::changeAcceleratedCompositingMode): (WebKit::WebPage::enterAcceleratedCompositingMode): (WebKit::WebPage::exitAcceleratedCompositingMode):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::platformInit): (WebKit::LayerBackedDrawingArea::attachCompositingContext): (WebKit::LayerBackedDrawingArea::detachCompositingContext): (WebKit::LayerBackedDrawingArea::setRootCompositingLayer):
- 10:46 AM Changeset in webkit [63842] by
-
- 2 edits in trunk/WebCore
2010-07-21 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Make more members of CSSStyleSelector private.
https://bugs.webkit.org/show_bug.cgi?id=42757
No change in behavior, so no new tests.
- css/CSSStyleSelector.h: Made a publicly-unused methods private.
- 10:44 AM Changeset in webkit [63841] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-21 Finnur Thorarinsson <finnur.webkit@gmail.com>
Reviewed by Dimitri Glazkov.
Avoid crashing during find-in-page when |view| is NULL.
https://bugs.webkit.org/show_bug.cgi?id=42760
There are no layout tests because we don't have a repro case
to work with, so this is a speculative fix based on crash dump
diagnosis. See bug for details.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::shouldScopeMatches):
- 10:36 AM Changeset in webkit [63840] by
-
- 2 edits in trunk/LayoutTests
2010-07-21 Tony Chang <tony@chromium.org>
Not reviewed, updating chromium test expectations.
Remove expectations for tests that were moved to platform/mac in r63616.
- platform/chromium/test_expectations.txt:
- 10:32 AM Changeset in webkit [63839] by
-
- 2 edits in trunk/LayoutTests
2010-07-21 Tony Chang <tony@chromium.org>
Not reviewed, updating chromiumg test expectations.
- platform/chromium/test_expectations.txt: Marking remember-bad-password.html and
401-logout.php as failing.
- 10:30 AM Changeset in webkit [63838] by
-
- 2 edits4 adds in trunk/WebKitSite
2010-07-21 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Add a diagram explaining how a DOM element is attached to the site.
https://bugs.webkit.org/show_bug.cgi?id=42763
- coding/dom-element-attach.html: Added.
- coding/images/dom-element-attach-large.png: Added.
- coding/images/dom-element-attach-small.png: Added.
- coding/images/dom-element-attach.graffle: Added.
- coding/technical-articles.html: Added a link to the page with the diragram.
- 10:26 AM Changeset in webkit [63837] by
-
- 2 edits in trunk/WebCore
2010-07-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: consider jQuery object to be of array nature.
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- 10:20 AM Changeset in webkit [63836] by
-
- 5 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=42717
<rdar://problem/7062824> A wrong password entered for site or proxy auth remains in WebCore
credential storage, and is sent with subsequent requests
WebCore:
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Don't use that direct a copy/paste, oops!
LayoutTests:
- platform/gtk/Skipped:
- platform/qt/Skipped: Skip the new tests, they don't pass.
- 9:55 AM Changeset in webkit [63835] by
-
- 6 edits in trunk/WebCore
2010-07-21 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
When GraphicsLayer::contentsOrientation() is CompositingCoordinatesBottomUp, need to flip repaint rects
https://bugs.webkit.org/show_bug.cgi?id=42662
If the contentsOrientation() on a GraphicsLayer is CompositingCoordinatesBottomUp, then we
need to flip the rects passed to setNeedsDisplayInRect:.
Avoid writing this code twice by making a bare function to share code
between WebLayer and WebTiledLayer. Convert the existing +drawContents:ofLayer:intoContext:
class method into a bare function, because the Obj-C calling overhead doesn't buy us anything.
Take out an assertion in GraphicsLayerCA::updateContentsTransform() that is not
correct.
No new tests because no layers use bottom-up contents at present.
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::updateContentsTransform):
- platform/graphics/mac/WebLayer.h:
- platform/graphics/mac/WebLayer.mm: (drawLayerContents): (setLayerNeedsDisplayInRect): (-[WebLayer setNeedsDisplayInRect:]): (-[WebLayer drawInContext:]):
- platform/graphics/mac/WebTiledLayer.mm: (-[WebTiledLayer setNeedsDisplayInRect:]): (-[WebTiledLayer drawInContext:]):
- 9:42 AM Changeset in webkit [63834] by
-
- 6 edits7 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=42717
<rdar://problem/7062824> A wrong password entered for site or proxy auth remains in WebCore
credential storage, and is sent with subsequent requests
Tests: http/tests/security/401-logout/401-logout.php
http/tests/xmlhttprequest/remember-bad-password.html
- platform/network/CredentialStorage.cpp: (WebCore::CredentialStorage::remove):
- platform/network/CredentialStorage.h: Added a way to remove stored credentials for a given protection space.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Remove stored credentials if they didn't work the first time.
- 9:39 AM Changeset in webkit [63833] by
-
- 13 edits in trunk
JavaScriptCore: WebKit on Windows should build optionally with an unversioned ICU DLL
https://bugs.webkit.org/show_bug.cgi?id=42722
<rdar://problem/8211743> JavaScriptCore needs to link against unversioned ICU
Reviewed by Adam Roben.
Dynamically create a new header, ICUVersion.h, as part of build-generated-files.sh.
Header contains a preprocessor define (U_DISABLE_RENAMING) indicating to ICU whether the ICU API
should be namespaced with the current ICU version number. Proper value is determined
by checking for the presence of libicuuc.lib, the unversioned copy of ICU.
To get the proper value for U_DISABLE_RENAMING into all source files, we force
the include of ICUVersion.h (our generated header) via the compiler options.
Since the versioned and unversioned ICU have different filenames (libicuuc.lib vs icuuc.lib)
we copy the ICU lib to an intermediate location under obj with a common name. This
allows us to link properly with either without adding a new build configuration.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
Copy ICU libs into a common location with a common name.
Add additional library search path to pick up icu lib.
Change ICU library filename specified to linker.
Add forced include of ICUVersion.h.
- JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Generate ICUVersion.h
- JavaScriptCore.vcproj/WTF/WTFCommon.vsprops: Add forced include of ICUVersion.h.
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
Copy ICU libs into a common location with a common name.
Add additional library search path to pick up icu lib.
Change ICU library filename specified to linker.
Add forced include of ICUVersion.h.
- JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
Copy ICU libs into a common location with a common name.
Add additional library search path to pick up icu lib.
Change ICU library filename specified to linker.
Add forced include of ICUVersion.h.
WebCore: WebKit on Windows should build optionally with an unversioned ICU DLL
https://bugs.webkit.org/show_bug.cgi?id=42722
<rdar://problem/8211767> WebKit needs to link against unversioned ICU
Reviewed by Adam Roben.
To get the proper value for U_DISABLE_RENAMING into all source files, we force
the include of ICUVersion.h (our generated header) via the compiler options.
- WebCore.vcproj/WebCore.vcproj:
Add forced include of ICUVersion.h.
- WebCore.vcproj/WebCoreCommon.vsprops: Add forced include of ICUVersion.h.
WebKit/win: WebKit on Windows should build optionally with an unversioned ICU DLL
https://bugs.webkit.org/show_bug.cgi?id=42722
<rdar://problem/8211767> WebKit needs to link against unversioned ICU
Reviewed by Adam Roben.
To get the proper value for U_DISABLE_RENAMING into all source files, we force
the include of ICUVersion.h (our generated header) via the compiler options.
- WebKit.vcproj/WebKit.vcproj: Add forced include of ICUVersion.h.
WebKit2: WebKit on Windows should build optionally with an unversioned ICU DLL
https://bugs.webkit.org/show_bug.cgi?id=42722
<rdar://problem/8211767> WebKit needs to link against unversioned ICU
Reviewed by Adam Roben.
To get the proper value for U_DISABLE_RENAMING into all source files, we force
the include of ICUVersion.h (our generated header) via the compiler options.
Since the versioned and unversioned ICU have different filenames (libicuuc.lib vs icuuc.lib)
we copy the ICU lib to an intermediate location under obj with a common name. This
allows us to link properly with either without adding a new build configuration.
- win/WebKit2Common.vsprops:
Copy ICU libs into a common location with a common name.
Add additional library search path to pick up icu lib.
Change ICU library filename specified to linker.
Add forced include of ICUVersion.h.
- 9:31 AM Changeset in webkit [63832] by
-
- 2 edits in trunk/WebKit2
Windows build fix
- Shared/win/UpdateChunk.h:
(WebKit::UpdateChunk::isEmpty): Added to match the Mac definition.
- 9:04 AM Changeset in webkit [63831] by
-
- 1 edit1 add in trunk/WebKit2
Land file I forgot to add.
- WebProcess/com.apple.WebProcess.sb: Added.
- 9:01 AM Changeset in webkit [63830] by
-
- 2 edits1 add in trunk/WebKit2
Move WebKit2WebProcess's settings to a vsprops file
Fixes <http://webkit.org/b/42751> WebKit2WebProcess should use vsprops
files
Reviewed by Darin Adler.
- win/WebKit2WebProcess.vcproj: Moved settings from here...
- win/WebKit2WebProcessCommon.vsprops: ...to here.
- 9:01 AM Changeset in webkit [63829] by
-
- 5 edits in trunk
Give InjectedBundle our standard set of configurations (minus the *_Cairo variants)
InjectedBundle's Debug_All configuration was the same as is Debug
configuration, and it was missing a Debug_Internal configuration.
Fixes <http://webkit.org/b/42749> InjectedBundle's build
configurations are screwy
Reviewed by Darin Adler.
WebKit/win:
Update WebKit.sln for InjectedBundle's Debug_Internal configuration
- WebKit.vcproj/WebKit.sln: Build the Debug_Internal variant of
InjectedBundle when we're using the Debug_Internal solution
configuration.
WebKitTools:
- WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added
debug_internal.vsprops and debug_all.vsprops to the Debug_All
configuration. Added a Debug_Internal configuration.
- WebKitTestRunner/WebKitTestRunner.sln: Build the Debug_Internal
variant of InjectedBundle when we're using the Debug_Internal solution
configuration.
- 9:01 AM Changeset in webkit [63828] by
-
- 2 edits1 add in trunk/WebKitTools
Move InjectedBundle's settings to a vsprops file
This will make it easier to change settings for all configurations,
and to add new configurations.
Fixes <http://webkit.org/b/42748> InjectedBundle should use vsprops
files
Reviewed by Darin Adler.
- WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added.
Moved settings here...
- WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: ...from
here.
- 9:00 AM Changeset in webkit [63827] by
-
- 2 edits in trunk/WebKit/win
Add MiniBrowser to WebKit.sln
It is the last project to build.
Fixes <http://webkit.org/b/42747> build-webkit should build
MiniBrowser
Reviewed by Darin Adler.
- WebKit.vcproj/WebKit.sln: Added MiniBrowser, and made it depend on
WebKitTestRunner.
- 8:53 AM Changeset in webkit [63826] by
-
- 2 edits in trunk/WebKitTools
Give MiniBrowser our standard set of configurations (minus the *_Cairo variants)
MiniBrowser already had a configuration called "Release", but it was
using mostly the same settings as Debug. And its Debug configuration
was using the settings that Debug_Internal should be using.
Fixes <http://webkit.org/b/42746> MiniBrowser's build configurations
are screwy
Reviewed by Darin Adler.
- MiniBrowser/MiniBrowser.vcproj: Removed debug_internal.vsprops from
the Debug configuration. Remove debug.vsprops and
debug_internal.vsprops from the Release configuration and replace them
with release.vsprops. Added Debug_Internal and Debug_All
configurations.
- 8:53 AM Changeset in webkit [63825] by
-
- 9 edits in trunk/WebKit2
Reviewed and tweaked by Anders Carlsson and Sam Weinig.
Patch by Ivan Krstić <ike@apple.com> on 2010-07-20
Put WebProcess in a sandbox. All of the following changes are
Mac-only.
<rdar://problem/7865269>
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
Send Sandbox extension for injected bundle to WebProcess.
- WebKit2.xcodeproj/project.pbxproj:
Add Sandbox profile to Resources for WebProcess.
- WebProcess/InjectedBundle/InjectedBundle.h:
New function InjectedBundle::setSandboxToken.
- WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
(WebKit::InjectedBundle::load):
Consume Sandbox token for the bundle if present.
(WebKit::InjectedBundle::setSandboxToken):
Set Sandbox token for the bundle.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::loadInjectedBundle):
Extra function parameter for Sandbox token.
(WebKit::WebProcess::didReceiveMessage):
Pass Sandbox token to loadInjectedBundle().
- WebProcess/WebProcess.h:
Extra function parameter for Sandbox token in loadInjectedBundle().
- WebProcess/com.apple.WebProcess.sb: Added.
Sandbox profile for WebProcess.
- WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):
Initialize Sandbox, exit on failure.
- 8:53 AM Changeset in webkit [63824] by
-
- 2 edits1 add in trunk/WebKitTools
Move MiniBrowser's settings to a vsprops file
This will make it easier to change settings for all configurations,
and to add new configurations.
MiniBrowser should use vsprops files
https://bugs.webkit.org/show_bug.cgi?id=42745
Reviewed by Darin Adler.
- MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added. Moved
settings here...
- MiniBrowser/MiniBrowser.vcproj: ...from here.
- 8:53 AM Changeset in webkit [63823] by
-
- 3 edits in trunk/WebKitTools
Fix compiler warnings when building MiniBrowser
Also cleaned up the .vcproj a bit.
Fixes <http://webkit.org/b/42743>.
Reviewed by Darin Adler.
- MiniBrowser/MiniBrowser.vcproj: Removed all settings that are
already defined in .vsprops files. This also fixes a warning about
/EDITANDCONTINUE being incompatible with /SAFESEH.
- MiniBrowser/win/MiniBrowser.rc: Replaced afxres.h with winresrc.h so
that we stop getting warnings about ID_FILE_OPEN and ID_FILE_CLOSE
being redefined. (I think this will also get us closer to building
with VC++ Express.)
- 8:51 AM Changeset in webkit [63822] by
-
- 2 edits in trunk/WebCore
2010-07-21 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Serialization to JSON in InspectorValue works incorrect
if comma is assigned as decimal separator. Windows with Russian locale.
https://bugs.webkit.org/show_bug.cgi?id=42755
- inspector/InspectorValues.cpp: (WebCore::InspectorBasicValue::writeJSON):
- 8:43 AM Changeset in webkit [63821] by
-
- 7 edits in trunk/WebKit2
Handle WKView visibility changes
<rdar://problem/7891077>
Reviewed by Dan Bernstein.
- Shared/mac/UpdateChunk.h:
(WebKit::UpdateChunk::isEmpty):
Add convenience getter.
- UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
Reorder the calls to _updateActiveState and _updateVisibility based on whether the view is moved to
a window or away from a window.
- UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
(WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy):
Initialize m_forceRepaintWhenResumingPainting to false.
(WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible):
Pass the m_forceRepaintWhenResumingPainting along to the DrawingAreaMessage::ResumePainting message.
(WebKit::ChunkedUpdateDrawingAreaProxy::didSetSize):
Don't try to paint empty update chunks.
(WebKit::ChunkedUpdateDrawingAreaProxy::update):
Don't paint the update chunk if we're not visible. Instead, make sure that the entire page is being redrawn
when its shown again.
- UIProcess/ChunkedUpdateDrawingAreaProxy.h:
- WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
(WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea):
(WebKit::ChunkedUpdateDrawingArea::display):
(WebKit::ChunkedUpdateDrawingArea::suspendPainting):
Rename m_shouldPaint to m_isPaintingSuspended and invert its logic.
(WebKit::ChunkedUpdateDrawingArea::scheduleDisplay):
Don't schedule a display timer if the dirty rect is empty.
(WebKit::ChunkedUpdateDrawingArea::setSize):
If painting is suspended, just send back an empty update chunk in the DidSetSize message.
(WebKit::ChunkedUpdateDrawingArea::resumePainting):
If forceRepaint is true, repaint the entire drawing area.
- 8:14 AM Changeset in webkit [63820] by
-
- 3 edits4 adds in trunk
2010-07-20 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
CSS rotation transform can cause elements with certain styles to vanish during rotation.
https://bugs.webkit.org/show_bug.cgi?id=42579
Remove some untested, broken code that, as far as I can tell, could never get hit.
Use the correct rect for the PaintInfo so that zero-sized elements with overflow:hidden
but a border paint correctly.
Test: compositing/overflow/zero-size-overflow.html
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer):
- 8:12 AM Changeset in webkit [63819] by
-
- 2 edits in trunk/WebCore
2010-07-21 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
Reviewed by Laszlo Gombos.
[QT] Leak and few more fixes to qt port of geolocation
https://bugs.webkit.org/show_bug.cgi?id=42753
Fixes memory leak and default values set to attributes.
Memory leak fix no new test case added.
- platform/qt/GeolocationServiceQt.cpp: Added. (WebCore::GeolocationServiceQt::~GeolocationServiceQt): (WebCore::GeolocationServiceQt::positionUpdated):
- 8:10 AM Changeset in webkit [63818] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] DRT sideeffect revealed by r63657
https://bugs.webkit.org/show_bug.cgi?id=42578
- platform/qt/Skipped: Unskip tests.
- 6:56 AM Changeset in webkit [63817] by
-
- 2 edits in trunk/WebCore
2010-07-21 Kristian Amlie <kristian.amlie@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Added automatic sqlite extraction for Symbian to QtWebKit.
Also added sqlite detection in case sqlite is not present in the SDK.
This is possible if WebKit is compiled standalone.
The inclusion part is a consequence of commit c578c6c1d6d in the Qt
repository. It will not work on Qt versions < 4.7.1, but that is ok,
since the only build system it will affect is marked as experimental
in the whole 4.7 series.
- WebCore.pro:
- 6:48 AM Changeset in webkit [63816] by
-
- 1 add in trunk/WebKit/efl/ChangeLog
2010-07-21 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
Creating ChangeLog for the EFL port.
- efl/ChangeLog: Added.
- 5:53 AM Changeset in webkit [63815] by
-
- 4 edits in trunk/WebCore
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Associate elements with the active form
https://bugs.webkit.org/show_bug.cgi?id=42728
This patch fixes fast/forms/formmove3.html. The test still doesn't
pass due to some render tree differences, but it works as intended now.
To fix this test, I needed to deviate from the spec slight. Minefield
seems to have the same deviation:
- html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::takeForm): (WebCore::HTMLConstructionSite::setForm): (WebCore::HTMLConstructionSite::createHTMLElement):
- html/HTMLConstructionSite.h: (WebCore::HTMLConstructionSite::form):
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody):
- 5:38 AM Changeset in webkit [63814] by
-
- 3 edits in trunk/WebCore
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
The adoption agency doesn't properly attach()
https://bugs.webkit.org/show_bug.cgi?id=42727
The adoption agency is transliterated rather directly from the spec,
but it misses some of the WebKit-specific machinations, such as
attaching to the render tree.
The algorithm, as written, is a minor layer violation. I've added to
the problem by calling attach() from HTMLTreeBuilder (even though
that's the job of the HTMLConstructionSite). We'll need to clean up
the layering a bit at some point.
This patch half fixes fast/forms/formmove3.html. Hopefully I'll finish
fixing it in the next patch.
- html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
- 5:22 AM Changeset in webkit [63813] by
-
- 4 edits in trunk
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
<input> elements with no type attribute should be foster parented
https://bugs.webkit.org/show_bug.cgi?id=42725
Test progression.
- html5lib/runner-expected-html5.txt:
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
<input> elements with no type attribute should be foster parented
https://bugs.webkit.org/show_bug.cgi?id=42725
Fix spec transcription error.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInTable):
- 5:05 AM Changeset in webkit [63812] by
-
- 4 edits in trunk/WebCore
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Fix fast/css/last-child-style-sharing.html
https://bugs.webkit.org/show_bug.cgi?id=42731
Prior to this patch, we weren't calling finishParsingChildren on the
body element. We need a more systematic way of catching these bugs.
- html/HTMLElementStack.cpp: (WebCore::HTMLElementStack::popAll):
- html/HTMLElementStack.h:
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):
- 4:18 AM Changeset in webkit [63811] by
-
- 3 edits in trunk/LayoutTests
2010-07-21 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: inspector/debugger-pause-in-eval-script.html fails on Chromium Win
https://bugs.webkit.org/show_bug.cgi?id=42735
- inspector/debugger-pause-in-eval-script.html:
- platform/chromium/test_expectations.txt:
- 3:42 AM Changeset in webkit [63810] by
-
- 10 edits in trunk
2010-07-21 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
Runtime feature switch for device orientation
https://bugs.webkit.org/show_bug.cgi?id=42265
Add a runtime feature switch that decides whether device orientation
events are available or not. Defaults to true.
- WebCore.vcproj/WebCoreCommon.vsprops: Add bindings/generic to include path.
- bindings/generic/RuntimeEnabledFeatures.cpp:
- bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setDeviceOrientationEnabled): (WebCore::RuntimeEnabledFeatures::deviceOrientationEnabled): (WebCore::RuntimeEnabledFeatures::deviceOrientationEventEnabled): (WebCore::RuntimeEnabledFeatures::ondeviceorientationEnabled):
- page/DOMWindow.cpp: (WebCore::DOMWindow::addEventListener): (WebCore::DOMWindow::removeEventListener): (WebCore::DOMWindow::removeAllEventListeners):
- page/DOMWindow.idl:
- page/Page.cpp: (WebCore::Page::Page):
2010-07-21 Hans Wennborg <hans@chromium.org>
Reviewed by Steve Block.
Runtime feature switch for device orientation
https://bugs.webkit.org/show_bug.cgi?id=42265
Add a runtime feature switch that decides whether device orientation
events are available or not. Defaults to true.
- public/WebRuntimeFeatures.h:
- src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableDeviceOrientation): (WebKit::WebRuntimeFeatures::isDeviceOrientationEnabled):
- 2:57 AM Changeset in webkit [63809] by
-
- 4 edits80 adds in trunk
WebCore: Reviewed Nikolas Zimmermann.
SVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes change
https://bugs.webkit.org/show_bug.cgi?id=42244
The implementation was done by Nikolas Zimmermann before, but
there was no tests for it. The patch also implements the simple
setFilterRes method.
Tests: svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr.html
svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr.html
svg/dynamic-updates/SVGFilterElement-dom-height-attr.html
svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr.html
svg/dynamic-updates/SVGFilterElement-dom-width-attr.html
svg/dynamic-updates/SVGFilterElement-dom-x-attr.html
svg/dynamic-updates/SVGFilterElement-dom-y-attr.html
svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call.html
svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop.html
svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop.html
svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop.html
svg/dynamic-updates/SVGFilterElement-svgdom-height-prop.html
svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop.html
svg/dynamic-updates/SVGFilterElement-svgdom-width-prop.html
svg/dynamic-updates/SVGFilterElement-svgdom-x-prop.html
svg/dynamic-updates/SVGFilterElement-svgdom-y-prop.html
- svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::setFilterRes):
(WebCore::SVGFilterElement::svgAttributeChanged):
(WebCore::SVGFilterElement::childrenChanged):
- svg/SVGFilterElement.h:
LayoutTests: SVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes change
https://bugs.webkit.org/show_bug.cgi?id=42244
Reviewed by Nikolas Zimmermann.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png: Added.
- svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr.html: Added.
- svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr.html: Added.
- svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-dom-height-attr.html: Added.
- svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr.html: Added.
- svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-dom-width-attr.html: Added.
- svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-dom-x-attr.html: Added.
- svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-dom-y-attr.html: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call.html: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop.html: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop.html: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop.html: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-height-prop.html: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop.html: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-width-prop.html: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-x-prop.html: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFilterElement-svgdom-y-prop.html: Added.
- svg/dynamic-updates/script-tests/SVGFilterElement-dom-filterRes-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-dom-filterUnits-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-dom-height-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-dom-primitiveUnits-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-dom-width-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-dom-x-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-dom-y-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterRes-call.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterResX-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterResY-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterUnits-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-height-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-primitiveUnits-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-width-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-x-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-y-prop.js: Added.
(executeTest):
- 2:38 AM Changeset in webkit [63808] by
-
- 2 edits in trunk/WebCore
Unreviewed, build fix.
Forgot to update the role of HitTestRequest.h in
the xcode project after landing patch from
https://bugs.webkit.org/show_bug.cgi?id=39493
- WebCore.xcodeproj/project.pbxproj: Make HitTestRequest.h
private so it can be included in WebKit by EventHandler.h
which is already private..
- 2:19 AM Changeset in webkit [63807] by
-
- 6 edits2 adds in trunk
Touch events do not affect the :active CSS state
https://bugs.webkit.org/show_bug.cgi?id=39493
Reviewed by Steve Block.
WebCore:
Test: fast/events/touch/touch-active-state.html
- WebCore.exp.in: Update exports for new signature of
hitTestResultAtPoint.
- WebCore.order: ditto.
- page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::hitTestResultAtPoint): Pass the type
of the hit test to perform as a parameter with a default
value rather than harcoding it in the function body.
(WebCore::EventHandler::handleMouseMoveEvent): Do not modiify
the active element during a mouse move if the user is
touching the screen.
(WebCore::EventHandler::handleTouchEvent): Set the correct
type of hit test to perform depending on the type of the
touch event we are handling.
- page/EventHandler.h: Update the signature of hitTestResultAtPoint.
LayoutTests:
- fast/events/touch/touch-active-state-expected.txt: Added.
- fast/events/touch/touch-active-state.html: Added.
- 2:02 AM Changeset in webkit [63806] by
-
- 2 edits in trunk/WebKit/chromium
2010-07-21 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: should be possible to debug inspector
https://bugs.webkit.org/show_bug.cgi?id=42730
- src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
