Context Navigation

In this initial implementation I've made Symbian fall back to use malloc/free for non-executable memory.
I think this will match current behaviour for the next client we will want to port across (RegisterFile &
Collector).

CMakeListsEfl.txt:
GNUmakefile.am:
JavaScriptCore.gypi:
JavaScriptCore.pro:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
jit/ExecutableAllocator.cpp:

(JSC::ExecutableAllocator::intializePageSize):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
(JSC::ExecutableAllocator::isValid):

jit/ExecutableAllocator.h:

(JSC::ExecutablePool::ExecutablePool):
(JSC::ExecutablePool::poolAllocate):

jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolAllocator::release):
(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::isValid):
(JSC::FixedVMPoolAllocator::isWithinVMPool):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):

jit/ExecutableAllocatorPosix.cpp: Removed.
jit/ExecutableAllocatorSymbian.cpp: Removed.
jit/ExecutableAllocatorWin.cpp: Removed.
wscript:
wtf/PageAllocator.cpp: Added.

(WTF::protection):
(WTF::PageAllocation::commit):
(WTF::PageAllocation::decommit):
(WTF::PageAllocator::allocate):
(WTF::PageAllocator::reserve):
(WTF::PageAllocator::deallocate):
(WTF::PageAllocator::pagesize):

wtf/PageAllocator.h: Added.

(WTF::PageAllocation::PageAllocation):
(WTF::PageAllocation::base):
(WTF::PageAllocation::size):
(WTF::PageAllocation::chunk):
(WTF::PageAllocation::operator!):
(WTF::PageAllocator::):

JavaScriptGlue:

ForwardingHeaders/wtf/PageAllocation.h: Added.

WebCore:

ForwardingHeaders/wtf/PageAllocation.h: Added.

9:51 PM Changeset in webkit [64104] by commit-queue@webkit.org

11 edits in trunk/WebCore

2010-07-26 Yuta Kitamura <yutak@chromium.org>

Reviewed by Pavel Feldman.

Add WebSocket resource type to Web Inspector.

When a new WebSocket connection is established, a line for that connection
will appear in Web Inspector's Resources tab. If the resource name is
clicked, the details of handshake request and response will be shown.

Web Inspector: WebSocket in Resources tab
https://bugs.webkit.org/show_bug.cgi?id=40768

inspector/InspectorController.cpp: (WebCore::InspectorController::addResource): WebSocket resource does not have an associated loader, thus frame might be null. Need to check it. (WebCore::InspectorController::removeResource): Ditto. (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket):
inspector/InspectorController.h:
inspector/InspectorResource.cpp: Add null checks of m_loader and m_frame, because WebSocket does not have a loader and we need to allow null for these variables. (WebCore::createReadableStringFromBinary): (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::create): Factory function of regular (non-WebSocket) resources. (WebCore::InspectorResource::createWebSocket): Factory function of WebSocket resources. (WebCore::InspectorResource::updateWebSocketRequest): (WebCore::InspectorResource::updateWebSocketResponse): (WebCore::InspectorResource::updateScriptObject): m_frame->document() becomes available when Frame::setDocument() is called. We cannot obtain documentURL during the constructor or updateRequest() function, because m_frame->document() is not available yet at that point and documentURL will contain a wrong URL. As far as I know, updateScriptObject() is the only place where we can safely obtain documentURL. (WebCore::InspectorResource::cachedResource): (WebCore::InspectorResource::type): (WebCore::InspectorResource::resourceData):
inspector/InspectorResource.h: (WebCore::InspectorResource::): (WebCore::InspectorResource::markWebSocket):
inspector/front-end/Resource.js: (WebInspector.Resource.Type.toString): (WebInspector.Resource.prototype.set type): (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshRequestHeaders): (WebInspector.ResourceView.prototype._refreshResponseHeaders): (WebInspector.ResourceView.prototype._refreshHeaders):
inspector/front-end/inspector.css: (.resources-category-websockets, .resources-category-other): (.resources-category-websockets .resources-graph-bar): (.resources-category-websockets.resource-cached .resources-graph-bar):
inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.updateResource):
websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::processBuffer): (WebCore::WebSocketChannel::identifier):
websockets/WebSocketChannel.h:

9:34 PM Changeset in webkit [64103] by commit-queue@webkit.org

4 edits in trunk

2010-07-26 Cosmin Truta <ctruta@chromium.org>

Reviewed by Eric Seidel.

Some SVGs with empty <g> elements crash Chromium on Linux
https://bugs.webkit.org/show_bug.cgi?id=41175

Remove the suppression of this bug's test on Chromium. The new fix in WebKit no longer requires
an update in Chromium, making this test safe to expose.

platform/chromium/test_expectations.txt:

2010-07-26 Cosmin Truta <ctruta@chromium.org>

Reviewed by Eric Seidel.

Some SVGs with empty <g> elements crash Chromium on Linux
https://bugs.webkit.org/show_bug.cgi?id=41175

Redo the old fix using a different approach, to avoid regressing
svg/batik/filters/filterRegions.svg with Chromium on Linux.
Specifically, handle empty SkBitmap objects by exiting early upon
encountering unconfigured (i.e. empty) bitmaps.

No new tests. This bug's old test (svg/filters/filter-empty-g.svg)
and the above-mentioned regressed test are expected to pass.

WebCore/platform/graphics/skia/ImageBufferSkia.cpp: (ImageBuffer::ImageBuffer): Undo the old fix. (getImageData): The new fix.

8:43 PM Changeset in webkit [64102] by Simon Fraser

3 edits in trunk/LayoutTests

2010-07-26 Simon Fraser <Simon Fraser>

Fix a couple of test results after r64095.

compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:

7:53 PM Changeset in webkit [64101] by barraclough@apple.com

11 edits
3 adds
2 deletes in trunk/JavaScriptCore

Rolling out r64097:64100, oops, more b0rked than I relized by my last changes, sorry!

CMakeListsEfl.txt:
GNUmakefile.am:
JavaScriptCore.gypi:
JavaScriptCore.pro:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
jit/ExecutableAllocator.cpp:

(JSC::ExecutableAllocator::reprotectRegion):
(JSC::ExecutableAllocator::cacheFlush):

jit/ExecutableAllocator.h:

(JSC::ExecutablePool::ExecutablePool):
(JSC::ExecutablePool::poolAllocate):

jit/ExecutableAllocatorFixedVMPool.cpp:

jit/ExecutableAllocatorPosix.cpp: Added.

(JSC::ExecutableAllocator::intializePageSize):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
(JSC::ExecutableAllocator::isValid):

jit/ExecutableAllocatorSymbian.cpp: Added.

(JSC::ExecutableAllocator::intializePageSize):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
(JSC::ExecutableAllocator::isValid):

jit/ExecutableAllocatorWin.cpp: Added.

(JSC::ExecutableAllocator::intializePageSize):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
(JSC::ExecutableAllocator::isValid):

wscript:
wtf/PageAllocation.cpp: Removed.
wtf/PageAllocation.h: Removed.

7:39 PM Changeset in webkit [64100] by barraclough@apple.com

3 edits in trunk/JavaScriptCore

Speculative !debug build fix II.

wtf/PageAllocation.h:

(WTF::PageAllocation::PageAllocation):

7:37 PM Changeset in webkit [64099] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

Speculative !debug build fix.

wtf/PageAllocation.h:

(WTF::PageAllocation::PageAllocation):

7:12 PM Changeset in webkit [64098] by barraclough@apple.com

11 edits
2 adds
3 deletes in trunk/JavaScriptCore

Bug 43009 - Abstract out page allocation from executable allocators

Reviewed by Oliver Hunt.

It would be great to have a single platform abstraction for block allocation, rather than copy/paste code.

CMakeListsEfl.txt:
GNUmakefile.am:
JavaScriptCore.gypi:
JavaScriptCore.pro:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
jit/ExecutableAllocator.cpp:

(JSC::ExecutableAllocator::intializePageSize):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
(JSC::ExecutableAllocator::isValid):

jit/ExecutableAllocator.h:

(JSC::ExecutablePool::ExecutablePool):
(JSC::ExecutablePool::poolAllocate):

jit/ExecutableAllocatorFixedVMPool.cpp:

jit/ExecutableAllocatorPosix.cpp: Removed.
jit/ExecutableAllocatorSymbian.cpp: Removed.
jit/ExecutableAllocatorWin.cpp: Removed.
wscript:
wtf/PageAllocator.cpp: Added.

wtf/PageAllocator.h: Added.

(WTF::PageAllocation::PageAllocation):
(WTF::PageAllocation::base):
(WTF::PageAllocation::size):
(WTF::PageAllocation::chunk):
(WTF::PageAllocation::operator!):
(WTF::PageAllocator::):

7:10 PM Changeset in webkit [64097] by commit-queue@webkit.org

3 edits
1 move in trunk/WebKit

2010-07-26 Rafael Antognolli <antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Move CMakeListsEfl.txt to WebKit/efl/
https://bugs.webkit.org/show_bug.cgi?id=43002

This should reduce the noise in WebKit/ChangeLog that comes from EFL
port. Most of the changes on EFL port should be logged in
WebKit/efl/ChangeLog.

CMakeLists.txt: Just change the path from where to include the file.

2010-07-26 Rafael Antognolli <antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Move CMakeListsEfl.txt to WebKit/efl/
https://bugs.webkit.org/show_bug.cgi?id=43002

This should reduce the noise in WebKit/ChangeLog that comes from EFL
port. Most of the changes on EFL port should be logged in
WebKit/efl/ChangeLog.

CMakeListsEfl.txt: Renamed from WebKit/CMakeListsEfl.txt.

6:17 PM Changeset in webkit [64096] by Darin Adler

15 edits in trunk

WebKitTestRunner needs to support layoutTestController.counterValueForElementById
https://bugs.webkit.org/show_bug.cgi?id=42537

Reviewed by Sam Weinig.

WebKitTestRunner needs layoutTestController.markerTextForListItem
https://bugs.webkit.org/show_bug.cgi?id=42549

WebKit2:

UIProcess/API/C/WKString.cpp:

(WKStringIsEmpty): Added.

UIProcess/API/C/WKString.h: Added WKStringIsEmpty.

WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(copiedString): Added. Helper for functions that return a
WKStringRef that follows the copy rule.
(WKBundleFrameCopyName): Use copiedString.
(WKBundleFrameCopyCounterValue): Added. Calls counterValue.
(WKBundleFrameCopyMarkerText): Added. Calls markerText.

WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:

Added WKBundleFrameCopyCounterValue and WKBundleFrameCopyMarkerText.

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::computedStyleIncludingVisitedInfo):
Renamed argument to streamline function a bit.
(WebKit::WebFrame::counterValue): Added.
(WebKit::WebFrame::markerText): Added.

WebProcess/WebPage/WebFrame.h: Added counterValue and markerText.

WebKitTools:

WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:

Fixed _paramterExpression typo. Improved support for string type as a
return value, so we don't try to include DOMString.h and we can convert
the string to a JSValue by calling JSValueMakeStringOrNull.

WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:

Added JSValueMakeStringOrNull, used by the code generator.

WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:

Added counterValueForElementById and markerTextForListItem.

WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

Moved constant to the top of the file.
(WTR::toCF): Added. Converts strings to CFStringRef.
(WTR::toWK): Added. Converts strings to WKStringRef.
(WTR::toJS): Added. Converts strings to JSStringRef.
(WTR::setProperty): Moved this function to the top of the file
rather than having it down where it's used inside the class. Also
renamed it so it's a separate function rather than an overload of
JSObjectSetProperty.
(WTR::propertyValue): Copied this here from InjectedBundlePage.cpp.
Should move it somewhere we can share it.
(WTR::propertyObject): Ditto.
(WTR::getElementById): Added. Calls getElementById through the magic
of JavaScript.
(WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
Chagned to use toWK instead of four local variables.
(WTR::LayoutTestController::counterValueForElementById): Added.
Calls WKBundleFrameCopyCounterValue.
(WTR::LayoutTestController::markerTextForListItem): Added.
Calls WKBundleFrameCopyMarkerText.

WebKitTestRunner/InjectedBundle/LayoutTestController.h:

Added counterValueForElementById and markerTextForListItem.

LayoutTests:

platform/mac-wk2/Skipped: Removed tests that were failing due to one of the above.

5:21 PM Changeset in webkit [64095] by Simon Fraser

3 edits
2 adds in trunk

2010-07-26 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Google image search results broken on pages with Flash
https://bugs.webkit.org/show_bug.cgi?id=43014

The test for overflow added in r63452 is wrong in that it ignores the effects
of positioning on overflow.

The correct approach is to start by using RenderView's layoutOverflowRect as the largest bounds,
then getting the oveflow rect via backgroundClipRect() relative to the root layer.

Test: compositing/geometry/limit-layer-bounds-overflow-root.html

rendering/RenderLayerBacking.cpp: (WebCore::layerOrAncestorIsTransformed): (WebCore::RenderLayerBacking::updateCompositedBounds):

5:19 PM Changeset in webkit [64094] by crogers@google.com

1 edit in branches/audio/WebCore/DerivedSources.make

Get rid of AudioMixer and AudioMixerNode in derived sources

5:09 PM Changeset in webkit [64093] by andersca@apple.com

11 edits in trunk/WebCore

Plug-in views should be able to return JSObjects directly
https://bugs.webkit.org/show_bug.cgi?id=43019

Reviewed by Sam Weinig.

bindings/js/JSHTMLAppletElementCustom.cpp:

(WebCore::JSHTMLAppletElement::putDelegate):
(WebCore::JSHTMLAppletElement::getCallData):

bindings/js/JSHTMLEmbedElementCustom.cpp:

(WebCore::JSHTMLEmbedElement::putDelegate):
(WebCore::JSHTMLEmbedElement::getCallData):

bindings/js/JSHTMLObjectElementCustom.cpp:

(WebCore::JSHTMLObjectElement::putDelegate):
(WebCore::JSHTMLObjectElement::getCallData):
runtimeObjectCustomPut and runtimeObjectGetCallData now take a JSHTMLElement instead of a HTMLElement.

bindings/js/JSPluginElementFunctions.cpp:

(WebCore::pluginScriptObject):
First, ask the PluginViewBase for a JSObject and fall back to getting the JSObject from the instance.

(WebCore::runtimeObjectPropertyGetter):
(WebCore::runtimeObjectCustomGetOwnPropertySlot):
(WebCore::runtimeObjectCustomGetOwnPropertyDescriptor):
Call pluginScriptObject.

(WebCore::runtimeObjectCustomPut):
Change to take a JSHTMLElement. Call pluginScriptObject.

(WebCore::runtimeObjectGetCallData):
Change to take a JSHTMLElement.

bridge/jsc/BridgeJSC.cpp:
bridge/jsc/BridgeJSC.h:

(JSC::Bindings::Instance::createRuntimeObject):
Change this to return a JSObject.

html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::getInstance):
Call pluginWidget.

(WebCore::HTMLPlugInElement::pluginWidget):
Return the plug-in widget for this element.

html/HTMLPlugInElement.h:
plugins/PluginViewBase.h:

(WebCore::PluginViewBase::scriptObject):
Add default implementation of scriptObject.

5:01 PM Changeset in webkit [64092] by commit-queue@webkit.org

4 edits
1 copy
1 add in trunk/WebKit/chromium

2010-07-26 Dominic Mazzoni <dmazzoni@google.com>

Reviewed by Chris Fleizach.

Add accessor to get the doctype of a WebDocument, needed to
implement Windows accessibility.

https://bugs.webkit.org/show_bug.cgi?id=43003

WebKit.gyp:
public/WebDocument.h:
public/WebDocumentType.h: Added. (WebKit::WebDocumentType::WebDocumentType): (WebKit::WebDocumentType::operator=): (WebKit::WebDocumentType::assign):
src/WebDocument.cpp: (WebKit::WebDocument::doctype):
src/WebDocumentType.cpp: Added. (WebKit::WebDocumentType::name): (WebKit::WebDocumentType::WebDocumentType): (WebKit::WebDocumentType::operator=): (WebKit::WebDocumentType::operator PassRefPtr<DocumentType>):

5:00 PM Changeset in webkit [64091] by weinig@apple.com

3 edits in trunk/WebKit2

Part 2 of https://bugs.webkit.org/show_bug.cgi?id=43013
<rdar://problem/8152434>
Add support for scrolling using the keyboard in WebKit2

Reviewed by Anders Carlsson.

Add support for scrolling with the space bar and ensure that we don't scroll
if WebCore is handling the event in another way.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::keyEvent):
(WebKit::getScrollMapping):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

WebProcess/WebPage/WebPage.h:

4:54 PM Changeset in webkit [64090] by crogers@google.com

5 edits in branches/audio/WebCore/audio

Get rid of explicit ownership (part 2)

now that it is unused/ignored, completely get rid of optional "owner" argument in AudioContext create methods

4:54 PM Changeset in webkit [64089] by crogers@google.com

5 edits
6 deletes in branches/audio/WebCore

Remove obsolete AudioMixerNode and AudioMixerInputNode classes

they have been replaced with AudioGainNode and unity-gain summing junctions in AudioNodeInput

4:33 PM Changeset in webkit [64088] by Chris Fleizach

7 edits
2 adds in trunk

AX: Safari does not support ARIA mixed checkboxes
https://bugs.webkit.org/show_bug.cgi?id=43016

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/accessibility/mixed-checkbox.html

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::checkboxOrRadioValue):

accessibility/AccessibilityObject.h:
accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
(WebCore::AccessibilityRenderObject::checkboxOrRadioValue):

accessibility/AccessibilityRenderObject.h:
accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

platform/mac/accessibility/mixed-checkbox-expected.txt: Added.
platform/mac/accessibility/mixed-checkbox.html: Added.

4:11 PM Changeset in webkit [64087] by commit-queue@webkit.org

2 edits
6 adds in trunk

2010-07-26 Shimeng (Simon) Wang <swang@google.com>

Reviewed by Darin Adler.

Add android specific expected test results for auto hyphenation
tests.

platform/android: Added.
platform/android/fast: Added.
platform/android/fast/text: Added.
platform/android/fast/text/hyphenate-character-expected.txt: Added.
platform/android/fast/text/hyphens-expected.txt: Added.

2010-07-26 Shimeng (Simon) Wang <swang@google.com>

Reviewed by Darin Adler.

Add auto hyphenation support for Android.
https://bugs.webkit.org/show_bug.cgi?id=42800

platform/text/android/HyphenationAndroid.cpp: Added. (WebCore::loadHyphenationDictionary): (WebCore::lastHyphenLocation):

4:06 PM Changeset in webkit [64086] by weinig@apple.com

6 edits in trunk

Patch for https://bugs.webkit.org/show_bug.cgi?id=43013
Part of <rdar://problem/8152434>
Add support for scrolling using the keyboard in WebKit2

Reviewed by Anders Carlsson.

WebCore:

Add a new export and make WindowsKeyboardCodes private.

WebCore.exp.in:
WebCore.xcodeproj/project.pbxproj:

WebKit2:

WebProcess/WebPage/WebPage.cpp:

(WebKit::getScrollMapping):
(WebKit::WebPage::keyEvent):
Scroll the page in response to keyDown.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/mac/WebPageMac.mm:

Use WindowsKeyboardCodes.h instead of redefining the constants.

3:58 PM Changeset in webkit [64085] by Darin Adler

18 edits in trunk

2010-07-26 Darin Adler <Darin Adler>

Reviewed by Eric Carlson.

Don't handle empty URL attributes specially in reflection, even in cases such as <img src="">
https://bugs.webkit.org/show_bug.cgi?id=42087

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::insertedIntoDocument): Check if the src attribute is empty by calling getAttribute instead of calling the src function. This keeps the behavior correct with the reflection change, and has a side benefit of being more efficient as well since there is no reason to resolve the URL. (WebCore::HTMLMediaElement::loadResource): Call getNonEmptyURLAttribute directly here instead of using the poster function. (WebCore::HTMLMediaElement::getPluginProxyParams): Ditto.

html/HTMLMediaElement.h: Removed the poster virtual function. The code that gets the poster attribute is already video-specific and uses generic attribute fetching code, so we no longer need a virtual function. Removed the src function. Since this would give a different result from the JavaScript reflected src attribute, it's safer not to have it, and it was easy to convert all the callers.

html/HTMLMediaElement.idl: Removed the NonEmpty extended attribute from the src attribute.

html/HTMLSourceElement.cpp: Removed the src function for the same reason as above.
html/HTMLSourceElement.h: Ditto.

html/HTMLSourceElement.idl: Removed the NonEmpty extended attribute from the src attribute.

html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::parseMappedAttribute): Removed code to update m_posterURL, which is no longer needed. Changed call site that used the poster() function to instead use getNonEmptyURLAttribute. (WebCore::HTMLVideoElement::updatePosterImage): Check if the poster attribute is empty by calling getAttribute instead of calling the poster function. This keeps the behavior correct with the reflection change, and has a side benefit of being more efficient as well since there is no reason to resolve the URL.

html/HTMLVideoElement.h: Removed the poster function for the same reason we removed the src function above. Also removed now-unneeded m_posterURL data member.

html/HTMLVideoElement.idl: Removed the NonEmpty extended attribute from the poster attribute.

2010-07-26 Darin Adler <Darin Adler>

Reviewed by Eric Carlson.

Don’t handle empty URL attributes specially in reflection, even in cases such as <img src="">
https://bugs.webkit.org/show_bug.cgi?id=42087

fast/dom/URL-attribute-reflection-expected.txt: Updated.
fast/dom/script-tests/URL-attribute-reflection.js: Updated test expectations so that even for URLs where "" is invalid, we reflect the empty string resolved to the base URL.

media/video-poster-expected.txt: Updated.
media/video-poster.html: Updated to expect poster="" to reflect as the base URL.
media/video-source-error-no-candidate-expected.txt: Updated.
media/video-src-none-expected.txt: Updated.
media/video-src-none.html: Updated to expect src="" to reflect as the base URL.

3:49 PM Changeset in webkit [64084] by Chris Fleizach

6 edits in trunk/WebCore

AX: remove intValue() hasIntValue() from AccessibilityObject
https://bugs.webkit.org/show_bug.cgi?id=43006

Reviewed by Darin Adler.

These methods are very Mac centric. The mac centric code should be moved into the Mac wrapper.

No new tests, existing tests cover changes to logic.

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::checkboxOrRadioValue):

accessibility/AccessibilityObject.h:

(WebCore::):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::selectedRadioButton):
(WebCore::AccessibilityRenderObject::selectedTabItem):
(WebCore::AccessibilityRenderObject::checkboxOrRadioValue):

accessibility/AccessibilityRenderObject.h:
accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

3:47 PM Changeset in webkit [64083] by rniwa@webkit.org

7 edits
2 adds in trunk

Applying inline style to a text node whose parent is an inline editable root causes crash
https://bugs.webkit.org/show_bug.cgi?id=39989

Reviewed by Darin Adler.

WebCore:

The crash was caused by splitTextElementAtStart and splitTextElementAtEnd assuming that the parent
and the grandparent of the specified text node is editable.

Modified splitTextElementAtStart and splitTextElementAtEnd so that they call splitTextAtStart
and splitTextAtEnd respectively when the grandparent is not editable.

Also modified SplitTextNodeContainingElement to exit early if the grandparent of m_text is not editable.

Test: editing/style/style-text-node-without-editable-parent.html

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::splitTextElementAtStart):
(WebCore::ApplyStyleCommand::splitTextElementAtEnd):

editing/SplitTextNodeContainingElementCommand.cpp:

(WebCore::SplitTextNodeContainingElementCommand::doApply):

LayoutTests:

Added a test to apply inline styles to a text node which is a editable root's child.
The test should not crash.

Two tests require rebaseline for the editing delegates. However, the final selection is kept same.

editing/execCommand/hilitecolor-expected.txt:
editing/style/remove-underline-from-stylesheet-expected.txt:
editing/style/style-text-node-without-editable-parent-expected.txt: Added.
editing/style/style-text-node-without-editable-parent.html: Added.
resources/dump-as-markup.js:

3:34 PM Changeset in webkit [64082] by Martin Robinson

6 edits
9 adds
1 delete in trunk

2010-07-26 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] The EventSender should support simulating drop events
https://bugs.webkit.org/show_bug.cgi?id=39844

Unskip tests that are now passing and add baselines for new tests. Re-organize
remaining failures so they can be unskipped more easily in the future.

platform/gtk/Skipped:
platform/gtk/editing/pasteboard/dataTransfer-setData-getData-expected.txt: Added.
platform/gtk/editing/pasteboard/drag-drop-dead-frame-expected.txt: Added.
platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt: Added.
platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt: Added.
platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt: Added.
platform/gtk/editing/selection/drag-select-1-expected.txt: Added.
platform/gtk/editing/selection/drag-text-delay-expected.txt: Added.
platform/gtk/fast/events/bogus-dropEffect-effectAllowed-expected.txt: Removed.
platform/gtk/fast/forms/input-text-drag-down-expected.txt: Added.
platform/gtk/fast/lists/drag-into-marker-expected.txt: Added.

2010-07-26 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] The EventSender should support simulating drop events
https://bugs.webkit.org/show_bug.cgi?id=39844

Add initial dropping support to the GTK+ EventSender.

DumpRenderTree/gtk/DumpRenderTree.cpp: (createWebView): Listen for some new drag-and-drop signals.
DumpRenderTree/gtk/EventSender.cpp: Add currentDragSourceContext. (dispatchEvent): Detect situations where a drag is either starting or ending and massage GTK+ into sending the appropriate signals to the WebView. (replaySavedEvents): Remove comment. (makeEventSender): Clear the currentDragSourceContext when creating a new EventSender. (dragBeginCallback): Capture the new currentDragSourceContext when a drag begins. (dragEndCallback): Clear the currentDragSourceContext when a drag ends. (dragFailedCallback): Disable the GTK+ drag failed animation.
DumpRenderTree/gtk/EventSender.h: Add declarations for new signal callbacks.

3:23 PM Changeset in webkit [64081] by victorw@chromium.org

2 edits in trunk/LayoutTests

2010-07-26 Victor Wang <victorw@chromium.org>

Unreviewed. Update chromium test expectations for flaky test on linux:
tables/mozilla_expected_failures/bugs/bug89315.html

platform/chromium/test_expectations.txt:

3:11 PM Changeset in webkit [64080] by Simon Fraser

1 edit
6 deletes in trunk/LayoutTests

2010-07-26 Simon Fraser <Simon Fraser>

Fix tests on Leopard.

No need for these Leopard-specific results any more.

platform/mac-leopard/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Removed.
platform/mac-leopard/compositing/iframes/connect-compositing-iframe3-expected.txt: Removed.
platform/mac-leopard/compositing/iframes/iframe-resize-expected.txt: Removed.
platform/mac-leopard/compositing/iframes/iframe-size-from-zero-expected.txt: Removed.
platform/mac-leopard/compositing/iframes/overlapped-iframe-expected.txt: Removed.
platform/mac-leopard/compositing/iframes/scrolling-iframe-expected.txt: Removed.

3:03 PM Changeset in webkit [64079] by adachan@apple.com

2 edits in trunk/WebKit2

Fix Windows build.

win/WebKit2Generated.make:

2:41 PM Changeset in webkit [64078] by Simon Fraser

3 edits
5 adds in trunk

2010-07-26 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Gmail compose is upside-down after r64054
https://bugs.webkit.org/show_bug.cgi?id=43000

We need to call setGeometryOrientation() whenever the iframe compositing layer attachment changes,
not just when requiresScrollLayer() returns false. This ensures that the orientation is updated
correctly.

Test: compositing/iframes/iframe-content-flipping.html

rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):

2:36 PM Changeset in webkit [64077] by jschuh@chromium.org

3 edits
5 adds in trunk

2010-07-26 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Fisher.

Check history state against origin before setting
https://bugs.webkit.org/show_bug.cgi?id=42858

Tests: fast/loader/stateobjects/replacestate-base-illegal.html

fast/loader/stateobjects/replacestate-base-legal.html

page/History.cpp: (WebCore::History::urlForState): (WebCore::History::stateObjectAdded):

2010-07-26 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Fisher.

Check history state when base URL is changed
https://bugs.webkit.org/show_bug.cgi?id=42858

fast/loader/stateobjects/replacestate-base-illegal-expected.txt: Added.
fast/loader/stateobjects/replacestate-base-illegal.html: Added.
fast/loader/stateobjects/replacestate-base-legal-expected.txt: Added.
fast/loader/stateobjects/replacestate-base-legal.html: Added.
fast/loader/stateobjects/resources/replacestate-base-pass.html: Added.

2:33 PM Changeset in webkit [64076] by andersca@apple.com

2 edits in trunk/WebKit2

Fix Windows build.

WebProcess/Plugins/Netscape/NetscapePlugin.h:

(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):

2:32 PM Changeset in webkit [64075] by Martin Robinson

4 edits in trunk

2010-07-26 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Get rid of libgdom
https://bugs.webkit.org/show_bug.cgi?id=42378

Remove the need to build the libgdom intermediate library.

GNUmakefile.am: Move the source list for the GObject DOM bindings to the top-level GNUmakefile.am, since they are logically part of WebKit, instead of WebCore. List all auto-generated files statically and remove no-longer- used variables. Fix an issue where some places expected webkitenumtypes.cpp to be generated in different directories.

2010-07-26 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Get rid of libgdom
https://bugs.webkit.org/show_bug.cgi?id=42378

Remove all build steps for building GObject DOM bindings.

GNUmakefile.am: Remove GObject DOM bindings build.

2:28 PM WikiStart edited by rniwa@webkit.org

Added a link "Writing DumpAsMarkup Tests" page to "WikiStart" (diff)

2:26 PM Writing DumpAsMarkup Tests created by rniwa@webkit.org

Added "Writing DumpAsMarkup Tests" page

2:20 PM Changeset in webkit [64074] by mrowe@apple.com

1 edit
1 move in trunk/LayoutTests

Disable a test that was added to verify the vendor prefix change that I rolled out in r64071.
It can be reenabled when the vendor prefix change is reintroduced in a more limited fashion.

fast/css/limited-vendor-prefix-behavior.html-disabled: Renamed from LayoutTests/fast/css/limited-vendor-prefix-behavior.html.

2:15 PM Changeset in webkit [64073] by andersca@apple.com

7 edits in trunk/WebKit2

Handle mouseenter/mouseleave + focus events
https://bugs.webkit.org/show_bug.cgi?id=42997

Reviewed by Sam Weinig.

WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::handleMouseEnterEvent):
Call platformHandleMouseEnterEvent.

(WebKit::NetscapePlugin::handleMouseLeaveEvent):
Call platformHandleMouseExitEvent.

(WebKit::NetscapePlugin::setFocus):
Call platformSetFocus.

WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::fillInCocoaEventFromMouseEvent):
Factor out code that fills in an NPCocoaEvent from a WebMouseEvent.

(WebKit::initializeMouseEvent):
Call fillInCocoaEventFromMouseEvent.

(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
Send an NPCocoaEventMouseEntered event.

(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
Send an NPCocoaEventMouseExited event.

(WebKit::NetscapePlugin::platformSetFocus):
Send an NPCocoaEventFocusChanged.

WebProcess/Plugins/Plugin.h:
WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::handleEvent):
Dispatch mouse enter and mouse leave events. Call focusPluginElement on mousedown.

(WebKit::PluginView::focusPluginElement):
Focus the plug-in's containing frame and its element.

(WebKit::PluginView::setFocus):
Call Plugin::setFocus.

1:58 PM Changeset in webkit [64072] by dbates@webkit.org

2 edits in trunk/WebKitTools

2010-07-26 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

svn-unapply warns of uninitialized variable when unapplying
a patch that describes an svn move operation
https://bugs.webkit.org/show_bug.cgi?id=42036

Fixes Perl uninitialized variable warnings when un-applying
a patch that moves a file.

Scripts/svn-unapply:
- Modified patch() so that it initializes $patch to the empty string when we don't have svnConvertedText (such as when reversing a diff that represents a svn copy/move operation).

1:53 PM Changeset in webkit [64071] by mrowe@apple.com

2 edits in trunk/WebCore

<http://webkit.org/b/42990> REGRESSION (r63854): Safari RSS layout is broken due to changes in vendor prefix handling

Reviewed by Dan Bernstein.

In r63854 support for properties with the -khtml vendor prefix was removed. This breaks the layout of
Safari's RSS interface, several Dashboard widgets that are included with Mac OS X, and at least one
popular third-party Mac OS X application. This change will need to be revisited in a manner that has
a clearer backwards-compatibility strategy. <http://webkit.org/b/42093> will be reopened to track that.

css/CSSParser.cpp:

(WebCore::cssPropertyID): Revert the WebCore change from r63854.

1:37 PM Changeset in webkit [64070] by beidson@apple.com

13 edits in trunk

2010-07-26 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

Add ability for WK2 to register a scheme to always be displayed as an empty document
https://bugs.webkit.org/show_bug.cgi?id=42995

No new tests. (Currently not possible to test in WebKit1 DRT, can be testing in future WK2 tester)

WebCore.exp.in:

loader/MainResourceLoader.cpp: (WebCore::shouldLoadAsEmptyDocument):

platform/SchemeRegistry.cpp: (WebCore::emptyDocumentSchemes): (WebCore::SchemeRegistry::registerURLSchemeAsEmptyDocument): (WebCore::SchemeRegistry::shouldLoadURLSchemeAsEmptyDocument):
platform/SchemeRegistry.h:

2010-07-26 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

Add ability for WK2 to register a scheme to always be displayed as an empty document
https://bugs.webkit.org/show_bug.cgi?id=42995

Shared/CoreIPCSupport/WebProcessMessageKinds.h: (WebProcessMessage::):

UIProcess/API/C/WKContext.cpp: (_WKContextRegisterURLSchemeAsEmptyDocument):
UIProcess/API/C/WKContextPrivate.h:

UIProcess/WebContext.cpp: (WebKit::WebContext::registerURLSchemeAsEmptyDocument):
UIProcess/WebContext.h:

WebProcess/WebProcess.cpp: (WebKit::WebProcess::registerURLSchemeAsEmptyDocument): (WebKit::WebProcess::didReceiveMessage):
WebProcess/WebProcess.h:

1:16 PM Changeset in webkit [64069] by victorw@chromium.org

2 edits in trunk/LayoutTests

2010-07-26 Simon Fraser <Simon Fraser>

Fix compositing iframe tests on Leopard.

Add Leopard-specific results where geometry flipping causes a different test output.

platform/mac-leopard/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
platform/mac-leopard/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
platform/mac-leopard/compositing/iframes/iframe-resize-expected.txt: Added.
platform/mac-leopard/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
platform/mac-leopard/compositing/iframes/overlapped-iframe-expected.txt: Added.
platform/mac-leopard/compositing/iframes/scrolling-iframe-expected.txt: Added.

1:16 PM Changeset in webkit [64068] by andersca@apple.com

3 edits
2 deletes in trunk/WebKit2

Get rid of the dummy plug-in.

Reviewed by Adam Roben.

WebKit2.xcodeproj/project.pbxproj:
WebProcess/Plugins/DummyPlugin.cpp: Removed.
WebProcess/Plugins/DummyPlugin.h: Removed.
win/WebKit2.vcproj:

1:09 PM Changeset in webkit [64067] by weinig@apple.com

10 edits
2 copies in trunk

Move some non-APIish functions into private headers.

Reviewed by Anders Carlsson.

WebKit2:

WebKit2.xcodeproj/project.pbxproj:
WebProcess/InjectedBundle/API/c/WKBundle.cpp:
WebProcess/InjectedBundle/API/c/WKBundle.h:
WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h: Copied from WebProcess/InjectedBundle/API/c/WKBundleFrame.h.
WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Copied from WebProcess/InjectedBundle/API/c/WKBundle.h.
win/WebKit2.vcproj:

WebKitTools:

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

12:57 PM Changeset in webkit [64066] by Simon Fraser

1 edit
6 adds in trunk/LayoutTests

2010-07-26 Simon Fraser <Simon Fraser>

Fix compositing iframe tests on Leopard.

Add Leopard-specific results where geometry flipping causes a different test output.

platform/mac-leopard/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
platform/mac-leopard/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
platform/mac-leopard/compositing/iframes/iframe-resize-expected.txt: Added.
platform/mac-leopard/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
platform/mac-leopard/compositing/iframes/overlapped-iframe-expected.txt: Added.
platform/mac-leopard/compositing/iframes/scrolling-iframe-expected.txt: Added.

12:57 PM Changeset in webkit [64065] by weinig@apple.com

12 edits in trunk

Fix for https://bugs.webkit.org/show_bug.cgi?id=42986
Add prompt and confirm client functions to WebKit2

Reviewed by Anders Carlsson.

WebKit2:

Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:

(WebPageProxyMessage::):

UIProcess/API/C/WKPage.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveSyncMessage):
(WebKit::WebPageProxy::runJavaScriptAlert):
(WebKit::WebPageProxy::runJavaScriptConfirm):
(WebKit::WebPageProxy::runJavaScriptPrompt):

UIProcess/WebPageProxy.h:
UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::runJavaScriptAlert):
(WebKit::WebUIClient::runJavaScriptConfirm):
(WebKit::WebUIClient::runJavaScriptPrompt):

UIProcess/WebUIClient.h:
WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):

WebKitTools:

MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

12:48 PM Changeset in webkit [64064] by crogers@google.com

20 edits in branches/audio

Get rid of explicit ownership (part 1)

implement the complex type of ref-counting necessary to deal with nodes which keep playing without JS references
AudioNodeInput now keeps track of "active" connections, as well as disabled connections
still need to address some thread safety issues, but code generally runs well
still need to get rid of "owner" argument (since it's now totally ignored)

12:41 PM Changeset in webkit [64063] by andersca@apple.com

13 edits
1 add
1 delete in trunk/WebKit2

Deliver mouse and wheel events to plug-ins
https://bugs.webkit.org/show_bug.cgi?id=42988

Reviewed by Sam Weinig.

Shared/WebEvent.h:

(WebKit::WebMouseEvent::WebMouseEvent):
(WebKit::WebMouseEvent::deltaX):
(WebKit::WebMouseEvent::deltaY):
(WebKit::WebMouseEvent::deltaZ):

Shared/mac/WebEventFactory.mm:

(WebKit::WebEventFactory::createWebMouseEvent):
Add deltaX, deltaY and deltaZ member variables to WebMosueEvent.

WebKit2.xcodeproj/project.pbxproj:

Rename NetscapePluginMac.cpp to NetscapePluginMac.mm.

WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NPP_HandleEvent):
Add NPP_ wrapper.

(WebKit::NetscapePlugin::handleMouseEvent):
(WebKit::NetscapePlugin::handleWheelEvent):
Call the platform variants.

WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: Added.

(WebKit::modifierFlags):
(WebKit::buttonNumber):
(WebKit::initializeMouseEvent):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
Create an NPCocoaEvent and send it to the plug-in.

(WebKit::NetscapePlugin::platformHandleWheelEvent):
Ditto.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::handleEvent):
Get the current WebEvent and send it to the plug-in if necessary.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::currentEvent):
(WebKit::CurrentEvent::CurrentEvent):
(WebKit::CurrentEvent::~CurrentEvent):
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::wheelEvent):
(WebKit::WebPage::keyEvent):

WebProcess/WebPage/WebPage.h:

Add RAII object for keeping track of the current event.

12:30 PM Changeset in webkit [64062] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-07-26 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kent Tamura.

[WINCE] Port ClipboardUtilities to WinCE
https://bugs.webkit.org/show_bug.cgi?id=42929

Make ClipboardUtilitiesWin more portable and remove the global namespace prefix
from GlobalLock/GlobalUnlock, since they are only macros on WinCE.

platform/win/ClipboardUtilitiesWin.cpp: (WebCore::urlFromPath): (WebCore::getWebLocData): (WebCore::createGlobalData): (WebCore::getURL): (WebCore::getPlainText): (WebCore::fragmentFromHTML):

12:22 PM Changeset in webkit [64061] by victorw@chromium.org

2 edits in trunk/LayoutTests

2010-07-26 Victor Wang <victorw@chromium.org>

Unreviewed. Update chromium test expectations fro flaky test.

https://bugs.webkit.org/show_bug.cgi?id=42989

platform/chromium/test_expectations.txt:

12:10 PM Changeset in webkit [64060] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-07-26 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Buildfix for BitmapImage.h
https://bugs.webkit.org/show_bug.cgi?id=42931

Use AffineTransform insted of TransformationMatrix.

platform/graphics/BitmapImage.h:

11:57 AM Changeset in webkit [64059] by Adam Roben

6 edits in trunk

Windows build fix

WebKit2:

win/WebKit2.vcproj:
win/WebKit2WebProcess.vcproj:

Removed empty attributes so the values will be picked up from the
vsprops files. (Also removed a couple of attributes that accidentally
duplicated values from the vsprops files.)

WebKitTools:

MiniBrowser/MiniBrowser.vcproj:
WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:

Removed empty attributes so the values will be picked up from the
vsprops files. (Also removed a couple of attributes that accidentally
duplicated values from the vsprops files.)

11:41 AM Changeset in webkit [64058] by krit@webkit.org

2 edits in trunk/WebCore

2010-07-26 Dirk Schulze <krit@webkit.org>

Unreviewed sort of XCode project file.

WebCore.xcodeproj/project.pbxproj:

11:32 AM Changeset in webkit [64057] by ddkilzer@apple.com

2 edits in trunk/WebCore

<http://webkit.org/b/42982> Streamline Inspector Source build phase script should use CONFIGURATION not BUILD_STYLE
<rdar://problem/6341764>

Reviewed by Mark Rowe.

WebCore.xcodeproj/project.pbxproj: Switched Streamline

Inspector Source build phase script to use CONFIGURATION instead
of BUILD_STYLE.

11:28 AM Changeset in webkit [64056] by ojan@chromium.org

3 edits
2 adds in trunk

2010-07-23 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

crash in insertParagraph in a contentEditable list
https://bugs.webkit.org/show_bug.cgi?id=42919

editing/execCommand/crash-on-enter-in-contentEditable-list-expected.txt: Added.
editing/execCommand/crash-on-enter-in-contentEditable-list.html: Added.

2010-07-23 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

crash in insertParagraph in a contentEditable list
https://bugs.webkit.org/show_bug.cgi?id=42919

Don't try to break out of a list item if the list it's in
is the rootEditableElement.

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):

11:15 AM Changeset in webkit [64055] by bulach@chromium.org

7 edits in trunk/WebCore

2010-07-26 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Moves IDBKeyRange to use IDBKey rather than SerializedScriptValue / IDBAny.
https://bugs.webkit.org/show_bug.cgi?id=42583

Tests: existing storage/indexeddb/idb-keyrange.html must pass.

storage/IDBKeyRange.cpp: (WebCore::IDBKeyRange::IDBKeyRange):
storage/IDBKeyRange.h: (WebCore::IDBKeyRange::create): (WebCore::IDBKeyRange::left): (WebCore::IDBKeyRange::right):
storage/IDBKeyRange.idl:
storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::makeSingleKeyRange): (WebCore::IndexedDatabaseRequest::makeLeftBoundKeyRange): (WebCore::IndexedDatabaseRequest::makeRightBoundKeyRange): (WebCore::IndexedDatabaseRequest::makeBoundKeyRange):
storage/IndexedDatabaseRequest.h:
storage/IndexedDatabaseRequest.idl:

10:48 AM Changeset in webkit [64054] by Simon Fraser

8 edits in trunk

2010-07-26 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Composited layers don't scroll in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42771

Rename two methods on RenderLayerCompositor to make their use more clear, and call them
when the FrameView gets resized and scrolled.

page/FrameView.h:
page/FrameView.cpp: (WebCore::FrameView::setFrameRect): override so we know when the size of the FrameView changes, so that the RenderLayerCompositor can update its clipping layer. (WebCore::FrameView::scrollPositionChanged): Call compositor()->frameViewDidScroll().

rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterWidgetResize): updateContentLayerOffset() was renamed.

rendering/RenderLayerCompositor.h:
rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::frameViewDidChangeSize): Renamed from updateContentLayerOffset(). (WebCore::RenderLayerCompositor::frameViewDidScroll): Renamed from updateContentLayerScrollPosition(). (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame): Propagate compositing on Mac for any FrameView that doesn't have a native widget, which is the case with WebKit2. (WebCore::RenderLayerCompositor::requiresScrollLayer): New method to tell us whether we need to handle scrolling (and clipping) ourselves. (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Do geometry flipping on the root platform layer only if we're not doing our own scrolling, and use the new requiresScrollLayer() method. (WebCore::RenderLayerCompositor::attachRootPlatformLayer): Send out the rootPlatformLayer(), so that it returns the clipping layer if we have one.

10:37 AM Changeset in webkit [64053] by jorlow@chromium.org

2 edits
12 moves in trunk/LayoutTests

2010-07-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Ojan Vafai.

Rename indexedDB tests to match new scheme
https://bugs.webkit.org/show_bug.cgi?id=42375

No changes to the tests themselves.

storage/indexeddb/script-tests/basics.js: Added. (openCallback): (test):
storage/indexeddb/script-tests/database-basics.js: Added. (openSuccess): (test):
storage/indexeddb/script-tests/idb-database-request.js: Removed.
storage/indexeddb/script-tests/idb-objectstore-request.js: Removed.
storage/indexeddb/script-tests/indexed-database-request.js: Removed.
storage/indexeddb/script-tests/keyrange.js: Renamed from LayoutTests/storage/indexeddb/script-tests/idb-keyrange.js. (checkSingleKeyRange): (checkLeftBoundKeyRange): ():
storage/indexeddb/script-tests/objectstore-basics.js: Added. (test): (openSuccess): (createSuccess): (addSuccess): (getSuccess): (removeSuccess):

10:19 AM WebKit Team edited by Simon Fraser

(diff)

10:11 AM Changeset in webkit [64052] by bweinstein@apple.com

2 edits in trunk/WebKitTools

Touch MiniBrowser's stdafx to fix the build.

Rubber-stamped by Adam Roben.

MiniBrowser/win/stdafx.h:

10:03 AM Changeset in webkit [64051] by tonyg@chromium.org

10 edits
1 add in trunk/WebCore

2010-07-26 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Fisher.

Move DocumentLoadTiming struct to a new file
https://bugs.webkit.org/show_bug.cgi?id=42917

Also makes DocumentLoadTiming Noncopyable.

No new tests because no new functionality.

GNUmakefile.am:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
loader/DocumentLoadTiming.h: Added. (WebCore::DocumentLoadTiming::DocumentLoadTiming):
loader/DocumentLoader.h:
loader/FrameLoader.cpp:
loader/FrameLoaderTypes.h:
loader/MainResourceLoader.cpp:
page/Timing.cpp:

10:03 AM Changeset in webkit [64050] by andersca@apple.com

3 edits in trunk/WebKit2

Clean up event handling functions
https://bugs.webkit.org/show_bug.cgi?id=42977

Reviewed by Sam Weinig.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::wheelEvent):
(WebKit::WebPage::keyEvent):
(WebKit::WebPage::didReceiveMessage):

WebProcess/WebPage/WebPage.h:

9:24 AM Changeset in webkit [64049] by mrowe@apple.com

2 edits in trunk/WebCore

Fix an #if in WebCore.exp.in to correctly detect whether SVG filters are enabled.

WebCore.exp.in:

9:01 AM Changeset in webkit [64048] by steveblock@google.com

3 edits in trunk/WebCore

2010-07-26 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

DeviceOrientation event listeners should never be called synchronously from addEventListener()
https://bugs.webkit.org/show_bug.cgi?id=42304

No new tests as there are currently no implementations to test. Tests will be
added once LayoutTestController methods for providing a mock implementation are
in place, see Bug 39589.

dom/DeviceOrientationController.cpp: (WebCore::DeviceOrientationController::DeviceOrientationController): (WebCore::DeviceOrientationController::timerFired): (WebCore::DeviceOrientationController::addListener): (WebCore::DeviceOrientationController::removeListener): (WebCore::DeviceOrientationController::removeAllListeners):
dom/DeviceOrientationController.h:

8:56 AM Changeset in webkit [64047] by andreas.kling@nokia.com

2 edits in trunk/WebCore

2010-07-26 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Canvas: Optimize GraphicsContext::addPath()

Avoid "deep concatenating" the canvas path onto the GC path
if the GC path has no elements.

platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::addPath):

8:43 AM Changeset in webkit [64046] by senorblanco@chromium.org

2 edits
4 adds in trunk/WebCore

2010-07-23 Stephen White <senorblanco@chromium.org>

Reviewed by Darin Fisher.

Implement OpenGLES2 helper classes.
https://bugs.webkit.org/show_bug.cgi?id=42905

GLES2Canvas and GLES2Texture are some simple OpenGLES2 helper classes
for managing state, samplers and textures.

When this is hooked up, it will be covered by many layout tests.

WebCore.gypi: Add new files to chromium build (contents are protected by #if's for now).
platform/graphics/chromium/GLES2Canvas.cpp: Added. (WebCore::affineTo3x3): (WebCore::GLES2Canvas::State::State): (WebCore::GLES2Canvas::GLES2Canvas): (WebCore::GLES2Canvas::~GLES2Canvas): (WebCore::GLES2Canvas::clearRect): (WebCore::GLES2Canvas::fillRect): (WebCore::GLES2Canvas::setFillColor): (WebCore::GLES2Canvas::setAlpha): (WebCore::GLES2Canvas::translate): (WebCore::GLES2Canvas::rotate): (WebCore::GLES2Canvas::scale): (WebCore::GLES2Canvas::concatCTM): (WebCore::GLES2Canvas::save): (WebCore::GLES2Canvas::restore): (WebCore::GLES2Canvas::drawTexturedRect): (WebCore::GLES2Canvas::setCompositeOperation): (WebCore::GLES2Canvas::applyCompositeOperator): (WebCore::GLES2Canvas::getQuadVertices): (WebCore::GLES2Canvas::getQuadIndices): (WebCore::loadShader): (WebCore::GLES2Canvas::getSimpleProgram): (WebCore::GLES2Canvas::getTexProgram): (WebCore::GLES2Canvas::createTexture): (WebCore::GLES2Canvas::getTexture): (WebCore::GLES2Canvas::checkGLError):
platform/graphics/chromium/GLES2Canvas.h: Added. (WebCore::GLES2Canvas::gles2Context):
platform/graphics/chromium/GLES2Texture.cpp: Added. (WebCore::GLES2Texture::GLES2Texture): (WebCore::GLES2Texture::~GLES2Texture): (WebCore::GLES2Texture::create): (WebCore::convertFormat): (WebCore::GLES2Texture::load): (WebCore::GLES2Texture::bind):
platform/graphics/chromium/GLES2Texture.h: Added. (WebCore::GLES2Texture::): (WebCore::GLES2Texture::format): (WebCore::GLES2Texture::width): (WebCore::GLES2Texture::height):

7:52 AM EFLWebKit edited by antognolli@profusion.mobi

(diff)

7:49 AM Changeset in webkit [64045] by jorlow@chromium.org

2 edits in trunk/WebCore

2010-07-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Fix IndexedDB release build on mac
https://bugs.webkit.org/show_bug.cgi?id=42377

storage/IDBDatabaseImpl.cpp: (WebCore::IDBDatabaseImpl::objectStore):

7:43 AM EFLWebKit edited by antognolli@profusion.mobi

(diff)

7:42 AM EFLWebKit edited by antognolli@profusion.mobi

(diff)

6:47 AM Changeset in webkit [64044] by commit-queue@webkit.org

1 edit
1 add in trunk/WebKitTools

2010-07-26 Hayato Ito <hayato@chromium.org>

Reviewed by Shinichiro Hamaji.

Add pretty printer of WTF::Vector for GDB 7.

https://bugs.webkit.org/show_bug.cgi?id=40909

gdb/wtf.py: Added.

5:04 AM Changeset in webkit [64043] by bulach@chromium.org

2 edits in trunk/LayoutTests

2010-07-26 Marcus Bulach <bulach@chromium.org>

Unreviewed. Add chromium expectations for failing tests.

tables/mozilla/other/slashlogo.html fails after r63994
https://bugs.webkit.org/show_bug.cgi?id=42964

Adds a suppression for chromium.

platform/chromium/test_expectations.txt:

4:52 AM Changeset in webkit [64042] by commit-queue@webkit.org

13 edits
3 copies
1 add in trunk

2010-07-26 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Add WebKit plumbing to connect speech requests and callbacks between WebCore and the embedder.
https://bugs.webkit.org/show_bug.cgi?id=42367

No new tests, the relevant LayoutTestController bindings will be added in the next patch.

page/SpeechInput.cpp: renamed a method.
page/SpeechInput.h: renamed a method.
page/SpeechInputClient.h: added an extra method to optionally let users stop recording once they have spoken.
page/SpeechInputClientListener.h: renamed a method.
page/SpeechInputListener.h: renamed a method.

2010-07-26 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Add WebKit plumbing to connect speech requests and callbacks between WebCore and the embedder.
https://bugs.webkit.org/show_bug.cgi?id=42367

No new tests, the relevant LayoutTestController bindings and tests will be added in the next patch.

public/WebSpeechInputController.h: Added new interface, implemented by embedder and called by WebKit (WebKit::WebSpeechInputController::~WebSpeechInputController):
public/WebSpeechInputListener.h: Added new interface, implemented by WebKit and called by embedder. (WebKit::WebSpeechInputListener::~WebSpeechInputListener):
public/WebViewClient.h: (WebKit::WebViewClient::createSpeechInputClient): New method to get the embedder's speech input client interface.
src/SpeechInputClientImpl.cpp: Added new class, implementation of a two way connector between WebCore and the embedder for requests and responses. (WebKit::SpeechInputClientImpl::SpeechInputClientImpl): (WebKit::SpeechInputClientImpl::~SpeechInputClientImpl): (WebKit::SpeechInputClientImpl::startRecognition): (WebKit::SpeechInputClientImpl::stopRecording): (WebKit::SpeechInputClientImpl::didCompleteRecording): (WebKit::SpeechInputClientImpl::setRecognitionResult): (WebKit::SpeechInputClientImpl::didCompleteRecognition):
src/SpeechInputClientImpl.h: Added.
src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): Pass on the above mentioned speech input connector to WebCore.
src/WebViewImpl.h:

4:51 AM Changeset in webkit [64041] by andreas.kling@nokia.com

2 edits in trunk/WebCore

2010-07-26 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] getImageData(): Single-pass RGB->BGR and un-premultiplication
https://bugs.webkit.org/show_bug.cgi?id=42945

Combine the two operations into a single loop over the pixel data.
Yields a considerable FPS gain on http://www.semantix.gr/statue.html

platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData):

4:21 AM Changeset in webkit [64040] by pfeldman@chromium.org

2 edits in trunk/WebCore

2010-07-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Shinichiro Hamaji.

Web Inspector: make sure proxy objects are JSON-stringifiable.

https://bugs.webkit.org/show_bug.cgi?id=42961

inspector/front-end/InjectedScript.js: (injectedScriptConstructor):

4:12 AM Changeset in webkit [64039] by vestbo@webkit.org

2 edits in trunk/WebKitTools

[Qt] Fix feature detection regexp

Reviewed by Simon Hausmann.

We were missing the last feature

Scripts/webkitdirs.pm:

2:52 AM Changeset in webkit [64038] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed.

[Qt] DRT sideeffect revealed by r63657
https://bugs.webkit.org/show_bug.cgi?id=42578

platform/qt/Skipped: Add tests to the Skipped list until fix.
- http/tests/xmlhttprequest/authorization-header.html
- http/tests/xmlhttprequest/null-auth.php

2:37 AM Changeset in webkit [64037] by apavlov@chromium.org

3 edits in trunk/WebCore

2010-07-26 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Joseph Pecoraro.

Inspector should remember resources sorting set by the user
https://bugs.webkit.org/show_bug.cgi?id=19208

Sorting options both for time and size graphs are memorized in a single property,
which makes them possible to retrieve in a single message (e.g. useful for remote debugging).

inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.populateSidebar): (WebInspector.ResourcesPanel.prototype._settingsLoaded): (WebInspector.ResourcesPanel.prototype._loadSortOptions): (WebInspector.ResourcesPanel.prototype._loadSortOptionForGraph): (WebInspector.ResourcesPanel.prototype._graphSelected): (WebInspector.ResourcesPanel.prototype._changeSortingFunction): (WebInspector.ResourcesPanel.prototype._selectedOptionNameForGraph): (WebInspector.ResourcesPanel.prototype._doChangeSortingFunction):
inspector/front-end/Settings.js: (WebInspector.populateApplicationSettings):

1:53 AM Changeset in webkit [64036] by Simon Hausmann

6 edits in trunk

[Qt] Use the default timeout interval for JS as the HTML tokenizer delay for setHtml()

Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2009-10-30
Reviewed by Kenneth Rohde Christiansen.

This ensures that long-running JavaScript (for example due to a modal alert() dialog),
will not trigger a deferred load after only 500ms (the default tokenizer delay) while
still giving a reasonable timeout (10 seconds) to prevent deadlock.

https://bugs.webkit.org/show_bug.cgi?id=29381

JavaScriptCore:

runtime/TimeoutChecker.h: Add getter for the timeout interval

WebKit/qt:

Api/qwebframe.cpp: Document the behaviour
WebCoreSupport/FrameLoaderClientQt.cpp: set the custom tokenizer delay for substitute loads
tests/qwebframe/tst_qwebframe.cpp: Add test

1:29 AM Changeset in webkit [64035] by loislo@chromium.org

3 edits in trunk/WebKit/chromium

2010-07-26 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Chromium DevTools: refactor query params, add basic
support for WebSocket-based backend.

https://bugs.webkit.org/show_bug.cgi?id=42893

src/js/DevTools.js: (devtools.ToolsAgent.prototype.dispatchOnClient_): (WebInspector.loaded): (WebInspector.doLoadedDone): (devtools.domContentLoaded):
src/js/InspectorControllerImpl.js:

1:19 AM Changeset in webkit [64034] by rniwa@webkit.org

4 edits
4 adds in trunk

WebCore: Redo fails after text node is split by SplitTextNodeCommand
https://bugs.webkit.org/show_bug.cgi?id=42941

Reviewed by Darin Adler.

The bug was caused by SplitTextNodeCommand not implementing doReapply.
Implemented doReapply and added insertText1AndTrimText2 to share the code between doApply and doReapply.

Test: editing/undo/redo-split-text-node.html

editing/undo/redo-split-text-node-with-removal.html

editing/SplitTextNodeCommand.cpp:

(WebCore::SplitTextNodeCommand::doApply): Calls executeApply.
(WebCore::SplitTextNodeCommand::doUnapply): Don't delete m_text1, which is later used in doReapply.
(WebCore::SplitTextNodeCommand::doReapply): Added.
(WebCore::SplitTextNodeCommand::insertText1AndTrimText2): Added.

editing/SplitTextNodeCommand.h:

LayoutTests: Added a test that splits a text node by inserting a paragraph and applies inline style.
The test then ensures that the style is preserved after undos and redos.

Reviewed by Darin Adler.

Also added a test in which the text node is removed by the script after undo.

Redo fails after text node is split by SplitTextNodeCommand
https://bugs.webkit.org/show_bug.cgi?id=42941

editing/undo/redo-split-text-node-expected.txt: Added.
editing/undo/redo-split-text-node.html: Added.
editing/undo/redo-split-text-with-removal-expected.txt: Added.
editing/undo/redo-split-text-with-removal.html: Added.

Jul 25, 2010:

11:57 PM Changeset in webkit [64033] by Darin Adler

5 edits in trunk

2010-07-25 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
https://bugs.webkit.org/show_bug.cgi?id=42326

platform/mac-wk2/Skipped: Removed all the tests from the list that were there only because they called dumpSelectionRect. Most of them pass now.

2010-07-25 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
https://bugs.webkit.org/show_bug.cgi?id=42326

WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpSelectionRect.

WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::dumpSelectionRect): Added. For now, this does nothing because its purpose is to change pixel test output and we do not have pixel tests implemented yet.

11:40 PM Changeset in webkit [64032] by Philippe Normand

4 edits in trunk

2010-07-23 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] media/media-can-play-mpeg-audio.html fails
https://bugs.webkit.org/show_bug.cgi?id=42895

Fixed advertizing of mp3, mpeg and mp4 mime-types in the player.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):

LayoutTests:

2010-07-23 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] media/media-can-play-mpeg-audio.html fails
https://bugs.webkit.org/show_bug.cgi?id=42895

platform/gtk/Skipped: Unskip fixed test.

11:35 PM Changeset in webkit [64031] by Philippe Normand

4 edits in trunk

2010-07-23 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

LayoutTests/media/media-document-audio-size.html failure
https://bugs.webkit.org/show_bug.cgi?id=38376

Advertize audio/x-wav along with audio/wav when appropriate,
otherwise WebKit attempts to use a plugin to play the media.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):

LayoutTests:

2010-07-23 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

LayoutTests/media/media-document-audio-size.html failure
https://bugs.webkit.org/show_bug.cgi?id=38376

platform/gtk/Skipped: Unskip fixed test on GTK port.

11:13 PM Changeset in webkit [64030] by Darin Adler

2 edits in trunk/LayoutTests

2010-07-25 Darin Adler <Darin Adler>

Reviewed by Maciej Stachowiak.

Need to support unsafe access console messages in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=42320

platform/mac-wk2/Skipped: Since unsafe access console messages are working properly, moved the failing tests listed under this bug to other sections in the file based on the reason they are failing. Removed the tests that are passing.

11:03 PM Changeset in webkit [64029] by Darin Adler

30 edits in trunk

2010-07-25 Darin Adler <Darin Adler>

Reviewed by Maciej Stachowiak.

WebKitTestRunner needs to support layoutTestController.keepWebHistory
https://bugs.webkit.org/show_bug.cgi?id=42323

platform/mac-wk2/Skipped: Removed the tests that needed only keepWebHistory and computedStyleIncludingVisitedInfo. Moved the other tests in the keepWebHistory section of the file into the other appropriate lists.

2010-07-25 Darin Adler <Darin Adler>

Reviewed by Maciej Stachowiak.

WebKitTestRunner needs to support layoutTestController.keepWebHistory
https://bugs.webkit.org/show_bug.cgi?id=42323

Added keepWebHistory and computedStyleIncludingVisitedInfo.

Also fixed misspellings of the word "receive".

Also tweaked the names of some of the LayoutTestController members.

WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added support for a type named "object" that is passed and returns as a JSValueRef.

WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added keepWebHistory and computedStyleIncludingVisitedInfo. Also put setAcceptsEditing up nearer the top.

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::_didReceiveMessage): Fixed mispellings of receive. (WTR::InjectedBundle::initialize): Ditto. (WTR::InjectedBundle::didReceiveMessage): Ditto. (WTR::InjectedBundle::reset): Reset the state of visited links between tests. Also eliminated the unused argument to the LayoutTestController create function. (WTR::InjectedBundle::setShouldTrackVisitedLinks): Added.
WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::shouldBeginEditing): Call shouldAllowEditing instead of acceptsEditing. (WTR::InjectedBundlePage::shouldEndEditing): Ditto. (WTR::InjectedBundlePage::shouldInsertNode): Ditto. (WTR::InjectedBundlePage::shouldInsertText): Ditto. (WTR::InjectedBundlePage::shouldDeleteRange): Ditto. (WTR::InjectedBundlePage::shouldChangeSelectedRange): Ditto. (WTR::InjectedBundlePage::shouldApplyStyle): Ditto.

WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::create): Removed uneeded argument. (WTR::LayoutTestController::LayoutTestController): Removed unneeded argument. Updated for rename of m_acceptsEditing to m_shouldAllowEditing. (WTR::LayoutTestController::numberOfActiveAnimations): Added some FIXMEs about the fact that this works on the main frame. (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto. (WTR::LayoutTestController::keepWebHistory): Added. (WTR::LayoutTestController::computedStyleIncludingVisitedInfo): Added. (WTR::JSObjectSetProperty): Added. Helper to make the function below cleaner. (WTR::LayoutTestController::makeWindowObject): Changed to use the overload of JSObjectSetProperty above.

WebKitTestRunner/InjectedBundle/LayoutTestController.h: Changes to match above.

WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Fixed mispellings of receive. (WTR::TestController::_didReceiveMessageFromInjectedBundle): Ditto. (WTR::TestController::didReceiveMessageFromInjectedBundle): Ditto.
WebKitTestRunner/TestController.h: Ditto.
WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Ditto.
WebKitTestRunner/TestInvocation.h: Ditto.

2010-07-25 Darin Adler <Darin Adler>

Reviewed by Maciej Stachowiak.

WebKitTestRunner needs to support layoutTestController.keepWebHistory
https://bugs.webkit.org/show_bug.cgi?id=42323

Added WKBundleSetShouldTrackVisitedLinks, WKBundleRemoveAllVisitedLinks,
and WKBundleFrameGetComputedStyleIncludingVisitedInfo.

Also fixed misspellings of the word "receive".

WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetShouldTrackVisitedLinks): Added. (WKBundleRemoveAllVisitedLinks): Added.
WebProcess/InjectedBundle/API/c/WKBundle.h: Added functions and fixed mispellings of receive.

WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameGetJavaScriptContext): Moved the code from here into WebFrame, to be consistent with the rest of the functions in this file. (WKBundleFrameGetComputedStyleIncludingVisitedInfo): Added.
WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Added WKBundleFrameGetComputedStyleIncludingVisitedInfo and tried to rearrange the file to be more logically ordered and grouped.

WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setShouldTrackVisitedLinks): Added. (WebKit::InjectedBundle::removeAllVisitedLinks): Added. (WebKit::InjectedBundle::didReceiveMessage): Fixed mispellings of receive.
WebProcess/InjectedBundle/InjectedBundle.h: Ditto.

WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::jsContext): Added. Contains the code that used to be in WKBundleFrameGetJavaScriptContext. (WebKit::WebFrame::computedStyleIncludingVisitedInfo): Added.
WebProcess/WebPage/WebFrame.h: Ditto.

UIProcess/API/C/WKContext.h: Fixed misspellings of receive.
UIProcess/WebContext.cpp: (WebKit::WebContext::didReceiveMessageFromInjectedBundle): Ditto.
UIProcess/WebContext.h: Ditto.
UIProcess/WebContextInjectedBundleClient.cpp: (WebKit::WebContextInjectedBundleClient::didReceiveMessageFromInjectedBundle): Ditto.
UIProcess/WebContextInjectedBundleClient.h: Ditto.
UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::forwardMessageToWebContext): Ditto.
WebProcess/WebProcess.cpp: (WebKit::WebProcess::forwardMessageToInjectedBundle): Ditto.

9:10 PM Changeset in webkit [64028] by rniwa@webkit.org

3 edits in trunk/WebCore

splitTextAt*IfNeed and splitTextElementAt*IfNeed need to be cleaned up
https://bugs.webkit.org/show_bug.cgi?id=42937

Reviewed by Kent Tamura.

Isolated the code to decide whether or not text node should be split into isValidCaretPositionInTextNode.
Moved the condition check out of *IfNeeded methods to applyRelativeFontStyleChange and applyInlineStyle.

No new tests added since this is a clean up.

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Uses isValidCaretPositionInTextNode.
(WebCore::ApplyStyleCommand::applyInlineStyle): Uses isValidCaretPositionInTextNode.
(WebCore::ApplyStyleCommand::splitTextAtStart): Renamed from splitTextAtStartIfNeeded.
(WebCore::ApplyStyleCommand::splitTextAtEnd): Renamed from splitTextAtEndIfNeeded.
(WebCore::ApplyStyleCommand::splitTextElementAtStart): Renamed from splitTextElementAtStartIfNeeded.
(WebCore::ApplyStyleCommand::splitTextElementAtEnd): Renamed from splitTextElementAtEndIfNeeded.
(WebCore::ApplyStyleCommand::isValidCaretPositionInTextNode): Returns true if the position lies within a text node.

editing/ApplyStyleCommand.h:

9:01 PM Changeset in webkit [64027] by commit-queue@webkit.org

2 edits in trunk/JavaScriptCore

2010-07-25 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kent Tamura.

[WINCE] Buildfix for JSC in release mode
https://bugs.webkit.org/show_bug.cgi?id=42934

jsc.cpp: Don't use try on WinCE.

8:48 PM Changeset in webkit [64026] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-07-25 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kent Tamura.

[WINCE] Buildfix for ImageBufferWince
https://bugs.webkit.org/show_bug.cgi?id=42928

platform/graphics/wince/ImageBufferWince.cpp: (WebCore::): (WebCore::BufferedImage::draw): Pass through ColorSpace parameter. (WebCore::BufferedImage::drawPattern): Ditto. (WebCore::ImageBuffer::platformTransformColorSpace): Added.

8:33 PM Changeset in webkit [64025] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-07-25 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kent Tamura.

[WINCE] Buildfix for PopupMenuWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=42932

Add #if !OS(WINCE) around unsupported window messages.

platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): (WebCore::PopupMenu::wndProc):

2:51 PM Changeset in webkit [64024] by abarth@webkit.org

5 edits in trunk

2010-07-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement adjustMathMLAttributes
https://bugs.webkit.org/show_bug.cgi?id=42952

Yay test progression.

html5lib/runner-expected-html5.txt:

2010-07-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement adjustMathMLAttributes
https://bugs.webkit.org/show_bug.cgi?id=42952

This is kind of mechanical overkill for adjusting one attribute name,
but it's nice to use the same machinery as SVG.

html/HTMLTreeBuilder.cpp:
mathml/mathattrs.in:

2:36 PM Changeset in webkit [64023] by abarth@webkit.org

3 edits in trunk/WebCore

2010-07-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Functions supporting the legacy tree builder are confusing
https://bugs.webkit.org/show_bug.cgi?id=42951

This patch just inlines these functions into their one call site and
removes the notImplemented() calls. We thought we were going to grow
these to support the new tree builder, but we took a different path.
Previous to this patch, these functions were confusing because they
looked like part of the new tree builder.

html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::passTokenToLegacyParser):
html/HTMLTreeBuilder.h:

1:05 PM Changeset in webkit [64022] by abarth@webkit.org

2 edits in trunk/WebCore

2010-07-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Recent HTML5 TreeBuilder Regression? All canvas tests ASSERT
https://bugs.webkit.org/show_bug.cgi?id=42948

Remove ASSERT and replace with correct branch. I put this ASSERT in
to make sure we had test coverage for this branch. I guess we do. :)

html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach):

8:46 AM Changeset in webkit [64021] by pfeldman@chromium.org

2 edits in trunk/WebCore

2010-07-25 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: check of jQuery object type prior to treating it as an array.

https://bugs.webkit.org/show_bug.cgi?id=42946

inspector/front-end/InjectedScript.js: (injectedScriptConstructor):

12:56 AM Changeset in webkit [64020] by ap@apple.com

12 edits in trunk

2010-07-25 Alexey Proskuryakov <ap@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=42193
Support layoutTestController.dumpEditingDelegates in WebKitTestRunner

Step 2 - add the rest of editing delegates.

platform/mac-wk2/Skipped: Changed the bug tracking why the tests are skipped - the delegates are now implemented, but one of them isn't called for some reason.

2010-07-25 Alexey Proskuryakov <ap@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=42193
Support layoutTestController.dumpEditingDelegates in WebKitTestRunner

Step 2 - add the rest of editing delegates.

WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
WebProcess/InjectedBundle/API/c/WKBundleBase.h: Added enums for EditorInsertAction and EAffinity. Also added a dummy type for CSSStyleDeclaration - neither DumpRenderTree not WebKitTestRunner actually use that.

WebProcess/InjectedBundle/API/c/WKBundlePage.h:
WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp: (WebKit::InjectedBundlePageEditorClient::shouldBeginEditing): (WebKit::InjectedBundlePageEditorClient::shouldEndEditing): (WebKit::InjectedBundlePageEditorClient::shouldInsertNode): (WebKit::InjectedBundlePageEditorClient::shouldInsertText): (WebKit::InjectedBundlePageEditorClient::shouldDeleteRange): (WebKit::InjectedBundlePageEditorClient::shouldChangeSelectedRange): (WebKit::InjectedBundlePageEditorClient::shouldApplyStyle): (WebKit::InjectedBundlePageEditorClient::didBeginEditing): (WebKit::InjectedBundlePageEditorClient::didEndEditing): (WebKit::InjectedBundlePageEditorClient::didChange): (WebKit::InjectedBundlePageEditorClient::didChangeSelection):
WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::shouldDeleteRange): (WebKit::WebEditorClient::shouldEndEditing): (WebKit::WebEditorClient::shouldInsertNode): (WebKit::WebEditorClient::shouldInsertText): (WebKit::WebEditorClient::shouldChangeSelectedRange): (WebKit::WebEditorClient::shouldApplyStyle): (WebKit::WebEditorClient::didBeginEditing): (WebKit::WebEditorClient::respondToChangedContents): (WebKit::WebEditorClient::respondToChangedSelection): (WebKit::WebEditorClient::didEndEditing): Added remaining delagates that are needed for WebKitTestRunner.

2010-07-25 Alexey Proskuryakov <ap@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=42193
Support layoutTestController.dumpEditingDelegates in WebKitTestRunner

Step 2 - add the rest of editing delegates.

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::operator<<): Fixed to not crash when range is null. (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::_shouldEndEditing): (WTR::InjectedBundlePage::_shouldInsertNode): (WTR::InjectedBundlePage::_shouldInsertText): (WTR::InjectedBundlePage::_shouldDeleteRange): (WTR::InjectedBundlePage::_shouldChangeSelectedRange): (WTR::InjectedBundlePage::_shouldApplyStyle): (WTR::InjectedBundlePage::_didBeginEditing): (WTR::InjectedBundlePage::_didEndEditing): (WTR::InjectedBundlePage::_didChange): (WTR::InjectedBundlePage::_didChangeSelection): (WTR::InjectedBundlePage::shouldEndEditing): (WTR::InjectedBundlePage::shouldInsertNode): (WTR::InjectedBundlePage::shouldInsertText): (WTR::InjectedBundlePage::shouldDeleteRange): (WTR::InjectedBundlePage::shouldChangeSelectedRange): (WTR::InjectedBundlePage::shouldApplyStyle): (WTR::InjectedBundlePage::didBeginEditing): (WTR::InjectedBundlePage::didEndEditing): (WTR::InjectedBundlePage::didChange): (WTR::InjectedBundlePage::didChangeSelection):
WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed