Timeline



Jul 27, 2010:

10:59 PM Changeset in webkit [64190] by Martin Robinson
  • 2 edits in trunk

2010-07-27 Martin Robinson <​mrobinson@igalia.com>

Unreviewed build fix.

Add missing webkitdomdefines.h header to the sources list.

  • GNUmakefile.am: Add missing header to the sources list.
10:16 PM Changeset in webkit [64189] by kinuko@chromium.org
  • 17 edits in trunk

2010-07-27 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Ojan Vafai.

Add FILE_SYSTEM build flag for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=42915

  • Configurations/FeatureDefines.xcconfig:

2010-07-27 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Ojan Vafai.

Add FILE_SYSTEM build flag for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=42915

  • features.gypi:

2010-07-27 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Ojan Vafai.

Add FILE_SYSTEM build flag for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=42915

  • Configurations/FeatureDefines.xcconfig:

2010-07-27 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Ojan Vafai.

Add FILE_SYSTEM build flag for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=42915

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

2010-07-27 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Ojan Vafai.

Add FILE_SYSTEM build flag for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=42915

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pri:

2010-07-27 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Ojan Vafai.

Add FILE_SYSTEM build flag for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=42915

  • configure.ac:

2010-07-27 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Ojan Vafai.

Add FILE_SYSTEM build flag for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=42915

  • Scripts/build-webkit:
9:09 PM Changeset in webkit [64188] by dbates@webkit.org
  • 1 edit
    7 deletes in trunk/LayoutTests

2010-07-27 Daniel Bates <​dbates@rim.com>

Unreviewed; remove platform-specific expected results.
​https://bugs.webkit.org/show_bug.cgi?id=42803

We no longer need the Qt an GTK platform-specific render tree dumps
as we now dump text.

  • platform/gtk/fast/lists/alpha-boundary-values-expected.txt: Removed.
  • platform/gtk/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Removed.
  • platform/qt/fast/lists/alpha-boundary-values-expected.checksum: Removed.
  • platform/qt/fast/lists/alpha-boundary-values-expected.png: Removed.
  • platform/qt/fast/lists/alpha-boundary-values-expected.txt: Removed.
  • platform/qt/fast/lists/w3-css3-list-styles-numeric-expected.txt: Removed.
  • platform/qt/fast/lists/w3-list-styles-expected.txt: Removed.
8:48 PM Changeset in webkit [64187] by yuzo@google.com
  • 5 edits in trunk

2010-07-26 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Shinichiro Hamaji.

@page rules in media queries should be tested.
Added tests for such rules.
​https://bugs.webkit.org/show_bug.cgi?id=42971

  • printing/page-rule-selection-expected.txt:
  • printing/page-rule-selection.html:

2010-07-26 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Shinichiro Hamaji.

@page rules in media queries should be tested.
​https://bugs.webkit.org/show_bug.cgi?id=42971

  • page/PrintContext.cpp: (WebCore::PrintContext::pageProperty): Fixed to properly begin printing. Added support for size property.
8:44 PM Changeset in webkit [64186] by dbates@webkit.org
  • 10 edits
    8 adds
    25 deletes in trunk/LayoutTests

2010-07-27 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

Convert DRT list tests from pixel-tests/render tree dumps to text
​https://bugs.webkit.org/show_bug.cgi?id=42803

With the passing of Bug #37929 and Bug #37930, convert a subset of the
DRT tests for lists from pixel-tests to text-based tests now that we
can retrieve the list item marker text in both the Mac and Windows ports.

  • fast/lists/alpha-boundary-values-expected.txt: Added.
  • fast/lists/alpha-boundary-values.html: Modified to dump as text.
  • fast/lists/alpha-list-wrap-expected.txt: Added.
  • fast/lists/alpha-list-wrap.html: Modified to dump as text.
  • fast/lists/decimal-leading-zero-expected.txt: Added.
  • fast/lists/decimal-leading-zero.html: Modified to dump as text.
  • fast/lists/li-values-expected.txt: Added.
  • fast/lists/li-values.html: Modified to dump as text.
  • fast/lists/list-style-type-dynamic-change-expected.txt: Added.
  • fast/lists/list-style-type-dynamic-change.html: Modified to dump as text.
  • fast/lists/resources/dump-list.js: (dumpList): Modified to call processList. (filterListsWithReplacement): Added. (processList): Added. (dumpListItemAsHTML): Added. (printPassedIfEmptyString): Added. (printFailedIfListItemMarkerNotEqualListItemText): Added.
  • fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Added.
  • fast/lists/w3-css3-list-styles-alphabetic.html: Modified to dump as text.
  • fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
  • fast/lists/w3-css3-list-styles-numeric.html: Modified to dump as text. Also, fix typos in the binary list-style-type results.
  • fast/lists/w3-list-styles-expected.txt: Added.
  • fast/lists/w3-list-styles.html: Modified to dump as text.
  • platform/mac/fast/lists/alpha-boundary-values-expected.checksum: Removed.
  • platform/mac/fast/lists/alpha-boundary-values-expected.png: Removed.
  • platform/mac/fast/lists/alpha-boundary-values-expected.txt: Removed.
  • platform/mac/fast/lists/alpha-list-wrap-expected.checksum: Removed.
  • platform/mac/fast/lists/alpha-list-wrap-expected.png: Removed.
  • platform/mac/fast/lists/alpha-list-wrap-expected.txt: Removed.
  • platform/mac/fast/lists/decimal-leading-zero-expected.checksum: Removed.
  • platform/mac/fast/lists/decimal-leading-zero-expected.png: Removed.
  • platform/mac/fast/lists/decimal-leading-zero-expected.txt: Removed.
  • platform/mac/fast/lists/li-values-expected.checksum: Removed.
  • platform/mac/fast/lists/li-values-expected.png: Removed.
  • platform/mac/fast/lists/li-values-expected.txt: Removed.
  • platform/mac/fast/lists/list-style-type-dynamic-change-expected.checksum: Removed.
  • platform/mac/fast/lists/list-style-type-dynamic-change-expected.png: Removed.
  • platform/mac/fast/lists/list-style-type-dynamic-change-expected.txt: Removed.
  • platform/mac/fast/lists/w3-css3-list-styles-alphabetic-expected.checksum: Removed.
  • platform/mac/fast/lists/w3-css3-list-styles-alphabetic-expected.png: Removed.
  • platform/mac/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Removed.
  • platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.checksum: Removed.
  • platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.png: Removed.
  • platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.txt: Removed.
  • platform/mac/fast/lists/w3-list-styles-expected.checksum: Removed.
  • platform/mac/fast/lists/w3-list-styles-expected.png: Removed.
  • platform/mac/fast/lists/w3-list-styles-expected.txt: Removed.
  • platform/win/fast/lists: Removed.
  • platform/win/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Removed.
  • platform/win/fast/lists/w3-css3-list-styles-numeric-expected.txt: Removed.
6:50 PM Changeset in webkit [64185] by Martin Robinson
  • 3 edits in trunk/WebKitTools

2010-07-27 Martin Robinson <​mrobinson@igalia.com>

Reviewed by David Levin.

Stylebot should not complain about NULL usage in calls to gdk_pixbuf_save_to
​https://bugs.webkit.org/show_bug.cgi?id=43090

  • Scripts/webkitpy/style/checkers/cpp.py: Add exemption for some GdkPixbuf methods.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for this behavior.
5:36 PM Changeset in webkit [64184] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

Temporarily rolling out ​http://trac.webkit.org/changeset/64177,
this seems to give QT ARM/Win a headache (specifically, looks
like structure layour differs, objects get too large -
"..\..\..\JavaScriptCore\runtime\ArrayPrototype.cpp:41:"
"error: size of array 'dummyclass_fits_in_cell' is negative").

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):

  • runtime/JSArray.cpp:

(JSC::increasedVectorLength):
(JSC::JSArray::JSArray):
(JSC::JSArray::~JSArray):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::putSlowCase):
(JSC::JSArray::deleteProperty):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::sortNumeric):
(JSC::JSArray::sort):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToRegisters):
(JSC::JSArray::compactForSorting):
(JSC::JSArray::subclassData):
(JSC::JSArray::setSubclassData):
(JSC::JSArray::checkConsistency):

  • runtime/JSArray.h:

(JSC::JSArray::length):
(JSC::JSArray::canGetIndex):
(JSC::JSArray::getIndex):
(JSC::JSArray::setIndex):
(JSC::JSArray::uncheckedSetIndex):
(JSC::JSArray::markChildrenDirect):

5:30 PM Changeset in webkit [64183] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Speculative build fix for Chromium/Win

  • wtf/Platform.h:
5:04 PM Changeset in webkit [64182] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Oh! that makes more sense! Maybe C++-style comments are bringing teh bad mojo.

  • wtf/Platform.h:
5:00 PM Changeset in webkit [64181] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix Windows build.

  • WebProcess/Plugins/JSNPObject.cpp:

(WebKit::JSNPObject::propertyGetter):
Remove unreachable code.

4:57 PM Changeset in webkit [64180] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Speculative build fix for GTK/64 ... seems to be barfing on a comment o_O

  • wtf/Platform.h:
4:41 PM Changeset in webkit [64179] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-27 Andrew Scherkus <​scherkus@chromium.org>

Unreviewed.

Marking media/controls-drag-timebar.html as flaky due to new seek behaviour.

  • platform/chromium/test_expectations.txt:
4:38 PM Changeset in webkit [64178] by jhawkins@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-07-27 James Hawkins <​jhawkins@chromium.org>

Unreviewed Build Fix.

Add a missing itemIcon() method to TestPopupMenuClient.

  • tests/PopupMenuTest.cpp: (WebKit::TestPopupMenuClient::itemIcon):
4:26 PM Changeset in webkit [64177] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

Changed the handling for removing and adding elements at the front
of an array. The code now keeps a bias that indicates the amount of
JSValue sized holes are prior to the ArrayStorage block. This means
that shift operations are now memmove's of the header part of
the ArrayStorage and unshift operations are similar, but may require a
realloc first to create the space. Similar operations are performed
for special cases of splice and slice.
Also optimized the new Array(size) case so that we don't allocate and
initialize array elements until the JS code starts using elements.
The array growth code is slightly more aggressive for initial growth
based on size growth of any previous array.

Patch by Michael Saboff <​msaboff@apple.com> on 2010-07-27
Reviewed by Gavin Barraclough.

  • Configurations/JavaScriptCore.xcconfig:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::privateCompilePatchGetArrayLength):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):

  • runtime/JSArray.cpp:

(JSC::JSArray::JSArray):
(JSC::JSArray::~JSArray):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::putSlowCase):
(JSC::JSArray::deleteProperty):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::getNewVectorLength):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::increaseVectorPrefixLength):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::shiftCount):
(JSC::JSArray::unshiftCount):
(JSC::JSArray::sortNumeric):
(JSC::JSArray::sort):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToRegisters):
(JSC::JSArray::compactForSorting):
(JSC::JSArray::subclassData):
(JSC::JSArray::setSubclassData):
(JSC::JSArray::checkConsistency):

  • runtime/JSArray.h:

(JSC::JSArray::length):
(JSC::JSArray::canGetIndex):
(JSC::JSArray::getIndex):
(JSC::JSArray::setIndex):
(JSC::JSArray::uncheckedSetIndex):
(JSC::JSArray::arrayStorage):
(JSC::JSArray::setArrayStorage):
(JSC::JSArray::markChildrenDirect):

4:19 PM Changeset in webkit [64176] by barraclough@apple.com
  • 8 edits in trunk/JavaScriptCore

Bug 43089 - Cleanup JIT related switched in Platform.h

Reviewed by Oliver Hunt.

The code the enable to JIT checks every permutation of platform & OS individually, but
now the JIT is enabled on the majority much all x86/x86-64/ARM/MIPS systems. It should
be cleaner to just enable by default on these platforms, and explicitly disable on configs
that don't aren't supported.

Also, rename ENABLE_JIT_OPTIMIZE_MOD to ENABLE_JIT_USE_SOFT_MODULO. I always find this
confusing since enabling this "optimization" would be possible, but would be a regression
on x86/x86-64 systems! I think it's clearer to reserve "JIT_OPTIMIZE" for compiler
technologies applicable to all platforms, and make a more optional behaviour like this a
"USE".

  • jit/ExecutableAllocator.h:

(JSC::ExecutableAllocator::cacheFlush):

  • jit/JIT.h:
  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • wtf/Platform.h:
4:16 PM Changeset in webkit [64175] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-07-27 Kent Tamura <​tkent@chromium.org>

Unreviewed, trivial typo fix.

  • Scripts/webkitpy/layout_tests/port/chromium.py: Fix a wrong method name committed by r64109.
4:15 PM Changeset in webkit [64174] by andersca@apple.com
  • 6 edits in trunk

Implement JSNPObject::propertyGetter
​https://bugs.webkit.org/show_bug.cgi?id=43091

Reviewed by Sam Weinig.

WebKit2:

  • WebProcess/Plugins/JSNPObject.cpp:

(WebKit::JSNPObject::propertyGetter):
Ask the NPObject for its property.

  • WebProcess/Plugins/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::jsNPObjectDestroyed):
Add a stub.

(WebKit::NPRuntimeObjectMap::convertNPVariantToValue):
Implement this for everything except objects.

LayoutTests:

  • platform/mac-wk2/Skipped:

Add a test I forgot to add, and remove plugins/npruntime/embed-property.html because it passes now.

4:02 PM Changeset in webkit [64173] by jhawkins@chromium.org
  • 13 edits in trunk

2010-07-27 James Hawkins <​jhawkins@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add the ability to show right-aligned icons in the AutoFill popup.
​https://bugs.webkit.org/show_bug.cgi?id=43076

  • public/WebView.h:
  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::getIcon): (WebKit::AutoFillPopupMenuClient::removeSuggestionAtIndex): (WebKit::AutoFillPopupMenuClient::itemIcon): (WebKit::AutoFillPopupMenuClient::initialize): (WebKit::AutoFillPopupMenuClient::setSuggestions):
  • src/AutoFillPopupMenuClient.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::applyAutoFillSuggestions): (WebKit::WebViewImpl::applyAutocompleteSuggestions):
  • src/WebViewImpl.h:

2010-07-27 James Hawkins <​jhawkins@chromium.org>

Reviewed by Darin Fisher.

Add itemIcon() method to the PopupMenuClient, used by Chrome AutoFill
to display right-aligned credit card icons in the suggestions popup.
​https://bugs.webkit.org/show_bug.cgi?id=43076

No new tests as this is only used by the Chromium WebKit API.

  • platform/PopupMenuClient.h:
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::paintRow):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::itemIcon):
  • rendering/RenderMenuList.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::itemIcon):
  • rendering/RenderTextControlSingleLine.h:
3:47 PM Changeset in webkit [64172] by weinig@apple.com
  • 17 edits in trunk

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=43087
Clean up handling of strings at the WebKit2 API layer.

Reviewed by Anders Carlsson.

WebKit2:

  • Always use the "copy" rule for functions that return WKStringRefs or WKURLRefs.
  • Never return a null WKStringRef or WKURLRef.
  • UIProcess/API/C/WKAPICast.h:

(toRef):
(toURLRef):
(toCopiedRef):
(toCopiedURLRef):

  • UIProcess/API/C/WKBackForwardListItem.cpp:

(WKBackForwardListItemCopyOriginalURL):
(WKBackForwardListItemCopyURL):
(WKBackForwardListItemCopyTitle):

  • UIProcess/API/C/WKBackForwardListItem.h:
  • UIProcess/API/C/WKFrame.cpp:

(WKFrameIsMainFrame):
(WKFrameCopyProvisionalURL):
(WKFrameCopyURL):
(WKFrameGetPage):
(WKFrameRetain):
(WKFrameRelease):

  • UIProcess/API/C/WKFrame.h:
  • UIProcess/API/C/WKNavigationData.cpp:

(WKNavigationDataCopyTitle):
(WKNavigationDataCopyURL):

  • UIProcess/API/C/WKNavigationData.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageCopyTitle):

  • UIProcess/API/C/WKPage.h:
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCopyURL):
(WKBundleFrameCopyName):
(WKBundleFrameCopyCounterValue):
(WKBundleFrameCopyMarkerText):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/InjectedBundle/API/c/WKBundleNode.cpp:

(WKBundleNodeCopyNodeName):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCopyRenderTreeExternalRepresentation):

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(runJavaScriptAlert):
(runJavaScriptConfirm):
(runJavaScriptPrompt):
(didNavigateWithNavigationData):
(-[BrowserWindowController updateProvisionalURLForFrame:]):

  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(_didClearWindowForFrame):

3:46 PM Changeset in webkit [64171] by Martin Robinson
  • 2 edits
    1 add in trunk/LayoutTests

2010-07-27 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Unskip a test that is passing and add expected results to another.

  • platform/gtk/Skipped: Unskip passing test.
  • platform/gtk/fast/canvas/set-colors-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/canvas/set-colors-expected.txt.
3:41 PM Changeset in webkit [64170] by jamesr@google.com
  • 2 edits in trunk/JavaScriptCore

2010-07-27 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Fisher.

[chromium] Make PLATFORM(CHROMIUM) and not OS(MAC) turn USE(GLES2_RENDERING) on
​https://bugs.webkit.org/show_bug.cgi?id=43084

This turns USE(GLES2_RENDERING) on for chromium on windows/linux. This causes no
change in behavior, that's all controlled by ENABLE() macros that are currently off.

  • wtf/Platform.h:
3:36 PM Changeset in webkit [64169] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Explicitly list all skipped tests in plugins/ so we can start removing passing tests.

Reviewed by Sam Weinig.

  • platform/mac-wk2/Skipped:
3:23 PM Changeset in webkit [64168] by Joseph Pecoraro
  • 1 edit
    1 add in trunk/BugsSite

2010-07-27 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Provide a Helpful Link for Web Inspector Bugs in Bugzilla
​https://bugs.webkit.org/show_bug.cgi?id=43065

  • template/en/custom/global/choose-product.html.tmpl: Added. Explicitly added a link for the Web Inspector.
3:20 PM Changeset in webkit [64167] by andersca@apple.com
  • 7 edits
    2 copies in trunk/WebKit2

Add JSNPObject, a JSObject that wraps an NPObject
​https://bugs.webkit.org/show_bug.cgi?id=43079

Reviewed by Sam Weinig.

  • WebKit2.xcodeproj/project.pbxproj:

Add JSNPObject.cpp and JSNPObject.h

  • WebProcess/Plugins/JSNPObject.cpp: Added.

(WebKit::npIdentifierFromIdentifier):
(WebKit::JSNPObject::JSNPObject):
(WebKit::JSNPObject::~JSNPObject):
(WebKit::JSNPObject::getOwnPropertySlot):
Check if the NPObject has the given property.

(WebKit::JSNPObject::propertyGetter):
(WebKit::JSNPObject::throwInvalidAccessError):

  • WebProcess/Plugins/JSNPObject.h: Added.

(WebKit::JSNPObject::createStructure):

  • WebProcess/Plugins/NPJSObject.h:
  • win/WebKit2.vcproj:

Add JSNPObject.cpp and JSNPObject.h

3:16 PM Changeset in webkit [64166] by victorw@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-27 Victor Wang <​victorw@chromium.org>

Unreviewed. Update chromium test expectations for failed test:
fast/canvas/canvas-ImageData-behaviour.html

  • platform/chromium/test_expectations.txt:
3:16 PM Changeset in webkit [64165] by commit-queue@webkit.org
  • 7 edits in trunk/JavaScriptCore/qt

2010-07-27 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Update the QScriptValue autotests suite.

QScriptValue generated files were updated, changes are:

  • More tested values (for example QSE::newObject() and QSE::newArray())
  • Tested values are recreated before each test and are not reused. The change implies better code coverage and some expected result changes.
  • A new test to check copy and assign functions.
  • Tests are using standard QTestLib interface, without any custom macros.

[Qt] Improve test coverage for the QScriptValue
​https://bugs.webkit.org/show_bug.cgi?id=42366

  • tests/qscriptvalue/tst_qscriptvalue.cpp: (tst_QScriptValue::tst_QScriptValue): (tst_QScriptValue::~tst_QScriptValue): (tst_QScriptValue::assignAndCopyConstruct_data): (tst_QScriptValue::assignAndCopyConstruct):
  • tests/qscriptvalue/tst_qscriptvalue.h:
  • tests/qscriptvalue/tst_qscriptvalue_generated_comparison.cpp: (tst_QScriptValue::equals_data): (tst_QScriptValue::equals): (tst_QScriptValue::strictlyEquals_data): (tst_QScriptValue::strictlyEquals): (tst_QScriptValue::instanceOf_data): (tst_QScriptValue::instanceOf):
  • tests/qscriptvalue/tst_qscriptvalue_generated_init.cpp: (tst_QScriptValue::initScriptValues):
  • tests/qscriptvalue/tst_qscriptvalue_generated_istype.cpp: (tst_QScriptValue::isValid_data): (tst_QScriptValue::isValid): (tst_QScriptValue::isBool_data): (tst_QScriptValue::isBool): (tst_QScriptValue::isBoolean_data): (tst_QScriptValue::isBoolean): (tst_QScriptValue::isNumber_data): (tst_QScriptValue::isNumber): (tst_QScriptValue::isFunction_data): (tst_QScriptValue::isFunction): (tst_QScriptValue::isNull_data): (tst_QScriptValue::isNull): (tst_QScriptValue::isString_data): (tst_QScriptValue::isString): (tst_QScriptValue::isUndefined_data): (tst_QScriptValue::isUndefined): (tst_QScriptValue::isObject_data): (tst_QScriptValue::isObject): (tst_QScriptValue::isArray_data): (tst_QScriptValue::isArray): (tst_QScriptValue::isError_data): (tst_QScriptValue::isError):
  • tests/qscriptvalue/tst_qscriptvalue_generated_totype.cpp: (tst_QScriptValue::toString_data): (tst_QScriptValue::toString): (tst_QScriptValue::toNumber_data): (tst_QScriptValue::toNumber): (tst_QScriptValue::toBool_data): (tst_QScriptValue::toBool): (tst_QScriptValue::toBoolean_data): (tst_QScriptValue::toBoolean): (tst_QScriptValue::toInteger_data): (tst_QScriptValue::toInteger): (tst_QScriptValue::toInt32_data): (tst_QScriptValue::toInt32): (tst_QScriptValue::toUInt32_data): (tst_QScriptValue::toUInt32): (tst_QScriptValue::toUInt16_data): (tst_QScriptValue::toUInt16):
3:07 PM Changeset in webkit [64164] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-07-27 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] putImageData(): Fast premultiply() if alpha == 255

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::premultiply): Do nothing for opaque pixels.
2:52 PM Changeset in webkit [64163] by rniwa@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

REGRESSION: editing/style/remove-underline-from-stylesheet.html fails on Qt platform after r64083
​https://bugs.webkit.org/show_bug.cgi?id=43061

Reviewed by Justin Garcia.

Added a qt-specific test result because the final range and the generated DOM is same.

  • platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt: Added.
2:42 PM Changeset in webkit [64162] by jianli@chromium.org
  • 2 edits in trunk/WebCore

Enhance FileThreadTask to support return type.
​https://bugs.webkit.org/show_bug.cgi?id=43078

Reviewed by David Levin.

This is needed to support synchronous calls of FileStream methods in
addition to asynchronous calls via FileThreadTask.

  • html/FileThreadTask.h:

(WebCore::createFileThreadTask):

2:37 PM Changeset in webkit [64161] by jamesr@google.com
  • 5 edits in trunk/WebCore

2010-07-27 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Fisher.

[chromium] Let PlatformContextSkia draw to a GLES2Canvas in addition to an SkCanvas
​https://bugs.webkit.org/show_bug.cgi?id=43070

This adds a GLES2Canvas as drawing surface to PlatformContextSkia and lets callers
issue draw commands to either. The PlatformContextSkia keeps track of where
rendering results are being accumulated and can blend the hardware and software
backing stores into each other when necessary.

Still just plumbing, no functionality change.

  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::GLES2Canvas):
  • platform/graphics/chromium/GLES2Canvas.h:
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::PlatformContextSkia): (PlatformContextSkia::setGLES2Context): (PlatformContextSkia::preSoftwareDraw): (PlatformContextSkia::preHardwareDraw): (PlatformContextSkia::forceToSoftware): (PlatformContextSkia::uploadSoftwareToHardware): (PlatformContextSkia::readbackHardwareToSoftware):
  • platform/graphics/skia/PlatformContextSkia.h: (PlatformContextSkia::useGPU): (PlatformContextSkia::gpuCanvas): (PlatformContextSkia::preSoftwareDraw): (PlatformContextSkia::preHardwareDraw): (PlatformContextSkia::forceToSoftware): (PlatformContextSkia::):
2:30 PM Changeset in webkit [64160] by brettw@chromium.org
  • 3 edits
    9 adds in trunk/WebKit/chromium

2010-07-27 Brett Wilson <​brettw@chromium.org>

Reviewed by Darin Fisher.

Add the ability to select fonts and do basic text drawing to the
Chromium WebKit API.
​https://bugs.webkit.org/show_bug.cgi?id=42999

  • WebKit.gyp:
  • public/WebFloatPoint.h: Added. (WebKit::WebFloatPoint::WebFloatPoint): (WebKit::WebFloatPoint::operator=): (WebKit::WebFloatPoint::operator WebCore::FloatPoint): (WebKit::operator==): (WebKit::operator!=):
  • public/WebFloatRect.h: Added. (WebKit::WebFloatRect::isEmpty): (WebKit::WebFloatRect::WebFloatRect): (WebKit::WebFloatRect::operator=): (WebKit::WebFloatRect::operator WebCore::FloatRect): (WebKit::operator==): (WebKit::operator!=):
  • public/WebFont.h: Added.
  • public/WebFontDescription.h: Added. (WebKit::WebFontDescription::): (WebKit::WebFontDescription::WebFontDescription):
  • public/WebTextRun.h: Added. (WebKit::WebTextRun::WebTextRun):
  • src/AssertMatchingEnums.cpp:
  • src/WebFontDescription.cpp: Added. (WebKit::WebFontDescription::WebFontDescription): (WebKit::WebFontDescription::operator WebCore::FontDescription):
  • src/WebFontImpl.cpp: Added. (WebKit::WebFont::Create): (WebKit::WebFontImpl::WebFontImpl): (WebKit::WebFontImpl::fontDescription): (WebKit::WebFontImpl::ascent): (WebKit::WebFontImpl::descent): (WebKit::WebFontImpl::height): (WebKit::WebFontImpl::lineSpacing): (WebKit::WebFontImpl::xHeight): (WebKit::WebFontImpl::drawText): (WebKit::WebFontImpl::computeWidth): (WebKit::WebFontImpl::offsetForPosition): (WebKit::WebFontImpl::selectionRectForText):
  • src/WebFontImpl.h: Added.
  • src/WebTextRun.cpp: Added. (WebKit::WebTextRun::operator WebCore::TextRun):
2:23 PM Changeset in webkit [64159] by victorw@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-27 Victor Wang <​victorw@chromium.org>

Unreviewed. Update chromium test expectations for failed test on mac:
fast/dom/prototype-inheritance.html

  • platform/chromium/test_expectations.txt:
2:18 PM Changeset in webkit [64158] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-07-27 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Incomplete repaint of some Safari extension content which falls into a composited iframe
<rdar://problem/8235044>

syncCompositingStateRecursive() bails if it thinks that a layout is pending, because
the layout may update layers and make this sync obsolete. However, it only checked for an
active layout timer. This ignores other sources of pending style changes and layouts, like
the document's style recalc timer. So use needsLayout(), which does check this.

Unable to create a test because it depends on Safari extension behavior.

  • page/FrameView.cpp: (WebCore::FrameView::syncCompositingStateRecursive):
2:17 PM Changeset in webkit [64157] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-07-27 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] putImageData() optimizations
​https://bugs.webkit.org/show_bug.cgi?id=43059

  • Single-pass premultiplication and BGR->RGB conversion
  • Use ARGB32PM for the temporary image so Qt calls the fast Source composition function
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::premultiply): Added (static inline) (WebCore::putImageData):
2:11 PM Changeset in webkit [64156] by andreas.kling@nokia.com
  • 10 edits in trunk

2010-07-23 Helder Correia <​heldercorreia@codeaurora.org>

Reviewed by Darin Adler.

Canvas tests 2d.imageData.object.round and 2d.imageData.object.wrap are
failing. For canvas image data manipulation, the values passed should
be truncated and wrapped. Also fix the canvas-ImageData-behaviour test
to expect wrapping rather than clamping, and add some new checkings.
​https://bugs.webkit.org/show_bug.cgi?id=40272

  • runtime/JSByteArray.h: (JSC::JSByteArray::setIndex): (JSC::JSByteArray::JSByteArray):

2010-07-23 Helder Correia <​heldercorreia@codeaurora.org>

Reviewed by Darin Adler.

Canvas tests 2d.imageData.object.round and 2d.imageData.object.wrap are
failing. For canvas image data manipulation, the values passed should
be truncated and wrapped. Also fix the canvas-ImageData-behaviour test
to expect wrapping rather than clamping, and add some new checkings.
​https://bugs.webkit.org/show_bug.cgi?id=40272

  • canvas/philip/tests/2d.imageData.object.round-expected.txt:
  • canvas/philip/tests/2d.imageData.object.round.html:
  • canvas/philip/tests/2d.imageData.object.wrap-expected.txt:
  • fast/canvas/canvas-ImageData-behaviour-expected.txt:
  • fast/canvas/canvas-ImageData-behaviour.js:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
2:06 PM Changeset in webkit [64155] by Adam Roben
  • 4 edits in trunk/WebKit2

Fix PageClient ownership in WebPageProxy

WKView now owns the PageClient, similar to how things work on Windows
(where the WebView is the PageClient).

Fixes <​http://webkit.org/b/40185> WebPageProxy should keep a weak
reference to the PageClient

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:pageNamespaceRef:]): Store the PageClientImpl
on our WKViewData object and pass it to the WebPageProxy.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setPageClient):

  • UIProcess/WebPageProxy.h:

Removed Mac-specific code that put the PageClient in an OwnPtr. We now
store it in a bare pointer just like on Windows.

1:55 PM Changeset in webkit [64154] by andersca@apple.com
  • 10 edits in trunk

Expose interface for returning the plug-in script JSObject
​https://bugs.webkit.org/show_bug.cgi?id=43074

Reviewed by Sam Weinig.

WebCore:

PluginViewBase::scriptObject should be a virtual function.

  • plugins/PluginViewBase.h:

(WebCore::PluginViewBase::scriptObject):

WebKit2:

  • WebProcess/Plugins/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::getOrCreateJSObject):
Add empty stub.

  • WebProcess/Plugins/NPRuntimeObjectMap.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::pluginScriptableNPObject):
Ask the plug-in for it's scriptable NPObject.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Plugin.h:

Add pluginScritableNPObject.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
Call PluginViewBase constructor.

(WebKit::PluginView::scriptObject):
Ask the plug-in for its scriptable object and wrap it.

  • WebProcess/Plugins/PluginView.h:

PluginView now inherits from PluginViewBase.

1:23 PM Changeset in webkit [64153] by ojan@chromium.org
  • 3 edits in trunk/WebKitTools

2010-07-27 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

webkit-patch post-commits is broken: AttributeError: Values instance has no attribute 'no_squash'
​https://bugs.webkit.org/show_bug.cgi?id=42984

squash and no_squash have been intentionally erroring for a couple weeks now.
But post-commits was just broken. Just remove squash/no_squash.

  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/options.py:
1:18 PM Changeset in webkit [64152] by jianli@chromium.org
  • 53 edits in trunk/WebCore

Add ScriptExecutionContext argument to File/Blob constructors.
​https://bugs.webkit.org/show_bug.cgi?id=40587

Reviewed by David Levin.

Remove DragData::createClipboard and add Clipboard::create for it to be
called directly in DragController. This is because we need to pass
Frame pointer to Clipboard class and use it to get ScriptExecutionContext
in order to construct File objects in Clipboard::files().

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::DeserializingTreeWalker::convertIfTerminal):

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::ZigZag::Reader::readBlob):
(WebCore::ZigZag::Reader::readFile):
(WebCore::ZigZag::Reader::readFileList):

  • dom/Clipboard.h:
  • editing/Editor.cpp:

(WebCore::Editor::dispatchCPPEvent):

  • editing/Editor.h:
  • editing/android/EditorAndroid.cpp:

(WebCore::Editor::newGeneralClipboard):

  • editing/brew/EditorBrew.cpp:

(WebCore::Editor::newGeneralClipboard):

  • editing/chromium/EditorChromium.cpp:

(WebCore::Editor::newGeneralClipboard):

  • editing/haiku/EditorHaiku.cpp:

(WebCore::Editor::newGeneralClipboard):

  • editing/mac/EditorMac.mm:

(WebCore::Editor::newGeneralClipboard):

  • editing/qt/EditorQt.cpp:

(WebCore::Editor::newGeneralClipboard):

  • editing/wx/EditorWx.cpp:

(WebCore::Editor::newGeneralClipboard):

  • html/Blob.cpp:

(WebCore::Blob::Blob):
(WebCore::Blob::slice):

  • html/Blob.h:

(WebCore::Blob::create):

  • html/Blob.idl:
  • html/BlobBuilder.cpp:

(WebCore::BlobBuilder::getBlob):

  • html/BlobBuilder.h:
  • html/BlobBuilder.idl:
  • html/File.cpp:

(WebCore::File::File):

  • html/File.h:

(WebCore::File::create):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::appendFormData):
(WebCore::HTMLInputElement::setFileListFromRenderer):

  • page/DragController.cpp:

(WebCore::DragController::dragExited):
(WebCore::DragController::performDrag):
(WebCore::DragController::tryDHTMLDrag):

  • page/chromium/EventHandlerChromium.cpp:

(WebCore::EventHandler::createDraggingClipboard):

  • page/gtk/EventHandlerGtk.cpp:

(WebCore::EventHandler::createDraggingClipboard):

  • page/win/EventHandlerWin.cpp:

(WebCore::EventHandler::createDraggingClipboard):

  • platform/DragData.h:
  • platform/android/ClipboardAndroid.cpp:

(WebCore::Clipboard::create):

  • platform/android/DragDataAndroid.cpp:
  • platform/brew/ClipboardBrew.cpp:

(WebCore::Clipboard::create):

  • platform/brew/DragDataBrew.cpp:
  • platform/chromium/ClipboardChromium.cpp:

(WebCore::Clipboard::create):
(WebCore::ClipboardChromium::ClipboardChromium):
(WebCore::ClipboardChromium::create):
(WebCore::ClipboardChromium::files):

  • platform/chromium/ClipboardChromium.h:
  • platform/chromium/DragDataChromium.cpp:
  • platform/efl/ClipboardEfl.cpp:

(WebCore::Editor::newGeneralClipboard):
(WebCore::Clipboard::create):

  • platform/efl/DragDataEfl.cpp:
  • platform/gtk/ClipboardGtk.cpp:

(WebCore::Editor::newGeneralClipboard):
(WebCore::Clipboard::create):
(WebCore::ClipboardGtk::ClipboardGtk):
(WebCore::ClipboardGtk::files):

  • platform/gtk/ClipboardGtk.h:

(WebCore::ClipboardGtk::create):

  • platform/gtk/DragDataGtk.cpp:
  • platform/haiku/ClipboardHaiku.cpp:

(WebCore::Clipboard::create):

  • platform/haiku/DragDataHaiku.cpp:
  • platform/mac/ClipboardMac.mm:

(WebCore::Clipboard::create):
(WebCore::ClipboardMac::files):

  • platform/mac/DragDataMac.mm:
  • platform/qt/ClipboardQt.cpp:

(WebCore::Clipboard::create):

  • platform/qt/DragDataQt.cpp:
  • platform/win/ClipboardWin.cpp:

(WebCore::Clipboard::create):
(WebCore::ClipboardWin::ClipboardWin):
(WebCore::ClipboardWin::files):

  • platform/win/ClipboardWin.h:

(WebCore::ClipboardWin::create):

  • platform/win/DragDataWin.cpp:
  • platform/win/EditorWin.cpp:

(WebCore::Editor::newGeneralClipboard):

  • platform/wince/DragDataWince.cpp:
  • platform/wince/EditorWince.cpp:

(WebCore::Editor::newGeneralClipboard):

  • platform/wx/ClipboardWx.cpp:

(WebCore::Clipboard::create):

  • platform/wx/DragDataWx.cpp:
1:07 PM Changeset in webkit [64151] by dumi@chromium.org
  • 14 edits in trunk

Move all WebSQLDatabases-specific code behind #if ENABLE(DATABASE).
​https://bugs.webkit.org/show_bug.cgi?id=43035

Reviewed by David Levin.

WebCore:

Make Chromium compile with ENABLE_DATABASE=0. The #ifdefs in
DatabaseAuthorizer and ChromiumBridge are removed, because they're
used by non-HTML5 DBs too (the classes in WebCore/platform/sql/),
which are used by other features too. So they need to be compiled
in even if HTML5 DBs are disabled.

  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • page/DOMWindow.idl:
  • platform/chromium/ChromiumBridge.h:
  • storage/DatabaseAuthorizer.cpp:
  • storage/chromium/DatabaseObserver.h:
  • storage/chromium/DatabaseTrackerChromium.cpp:
  • storage/chromium/QuotaTracker.cpp:
  • storage/chromium/QuotaTracker.h:
  • storage/chromium/SQLTransactionClientChromium.cpp:

WebKit/chromium:

Make Chromium compile with ENABLE_DATABASE=0.

  • src/ChromiumBridge.cpp:

(WebCore::ChromiumBridge::databaseGetFileSize):

  • src/DatabaseObserver.cpp:
  • src/WebDatabase.cpp:

(WebCore::AbstractDatabase::stringIdentifier):
(WebCore::AbstractDatabase::displayName):
(WebCore::AbstractDatabase::estimatedSize):
(WebCore::AbstractDatabase::securityOrigin):
(WebKit::WebDatabase::updateDatabaseSize):
(WebKit::WebDatabase::closeDatabaseImmediately):

12:48 PM Changeset in webkit [64150] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

[wx] Build fix after introduction of EXECUTABLE_ALLOCATOR_DEMAND.

12:38 PM Changeset in webkit [64149] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: Misspellings not shown in AXAttributedStringForTextMarkerRange when selection is on word
​https://bugs.webkit.org/show_bug.cgi?id=41817

Reviewed by David Kilzer.

WebCore:

Change how misspelled words are identified for accessibility. No longer rely on the
cached markers in Document. Calculate on the fly, which is more accurate in a variety of
circumstances (like when selection has not moved across words, of if the cursor is in the middle
of a misspelled word).

Test: platform/mac/accessibility/attributed-string-includes-misspelled-with-selection.html

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(AXAttributeStringSetSpelling):
(AXAttributedStringAppendText):
(-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):

LayoutTests:

  • platform/mac/accessibility/attributed-string-includes-misspelled-with-selection-expected.txt: Added.
  • platform/mac/accessibility/attributed-string-includes-misspelled-with-selection.html: Added.
12:34 PM Changeset in webkit [64148] by victorw@chromium.org
  • 3 edits in trunk/LayoutTests

2010-07-27 Victor Wang <​victorw@chromium.org>

Unreviewed. Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
  • storage/indexeddb/keyrange-expected.txt:
12:29 PM Changeset in webkit [64147] by andersca@apple.com
  • 5 edits
    2 copies in trunk/WebKit2

Move NPJSObject out into separate files
​https://bugs.webkit.org/show_bug.cgi?id=43068

Reviewed by Adam Roben.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Plugins/NPJSObject.cpp: Added.

(WebKit::NPJSObject::create):
(WebKit::NPJSObject::NPJSObject):
(WebKit::NPJSObject::~NPJSObject):
(WebKit::NPJSObject::isNPJSObject):
(WebKit::NPJSObject::initialize):
(WebKit::identifierFromIdentifierRep):
(WebKit::NPJSObject::hasProperty):
(WebKit::NPJSObject::getProperty):
(WebKit::NPJSObject::npClass):
(WebKit::NPJSObject::NP_Allocate):
(WebKit::NPJSObject::NP_Deallocate):
(WebKit::NPJSObject::NP_HasProperty):
(WebKit::NPJSObject::NP_GetProperty):

  • WebProcess/Plugins/NPJSObject.h: Added.

(WebKit::NPJSObject::jsObject):
(WebKit::NPJSObject::toNPJSObject):

  • WebProcess/Plugins/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::npJSObjectDestroyed):
(WebKit::NPRuntimeObjectMap::globalExec):

  • WebProcess/Plugins/NPRuntimeObjectMap.h:
  • win/WebKit2.vcproj:
12:14 PM Changeset in webkit [64146] by barraclough@apple.com
  • 8 edits
    3 adds in trunk

Bug 42621 - Add a bump allocator for the YARR interpreter

Reviewed by Oliver Hunt.

The regex engine requires lifo allocation, however currently uses the general purpose
malloc/free memory allocation. A simple bump pointer allocator should provide a lower
overhead allocation solution.

JavaScriptCore:

When using YARR interpreter, 15% progression on v8-regex.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/JSGlobalData.h:
  • runtime/RegExp.cpp:

(JSC::RegExp::compile):

  • wtf/BumpPointerAllocator.h: Added.

(WTF::BumpPointerPool::ensureCapacity):
(WTF::BumpPointerPool::alloc):
(WTF::BumpPointerPool::dealloc):
(WTF::BumpPointerPool::operator new):
(WTF::BumpPointerPool::BumpPointerPool):
(WTF::BumpPointerPool::create):
(WTF::BumpPointerPool::shrink):
(WTF::BumpPointerPool::destroy):
(WTF::BumpPointerPool::ensureCapacityCrossPool):
(WTF::BumpPointerPool::deallocCrossPool):
(WTF::BumpPointerAllocator::BumpPointerAllocator):
(WTF::BumpPointerAllocator::~BumpPointerAllocator):
(WTF::BumpPointerAllocator::startAllocator):
(WTF::BumpPointerAllocator::stopAllocator):

  • yarr/RegexInterpreter.cpp:

(JSC::Yarr::Interpreter::allocDisjunctionContext):
(JSC::Yarr::Interpreter::freeDisjunctionContext):
(JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext):
(JSC::Yarr::Interpreter::interpret):
(JSC::Yarr::Interpreter::Interpreter):
(JSC::Yarr::ByteCompiler::compile):
(JSC::Yarr::byteCompileRegex):

  • yarr/RegexInterpreter.h:

(JSC::Yarr::BytecodePattern::BytecodePattern):

JavaScriptGlue:

  • ForwardingHeaders/wtf/BumpPointerAllocator.h: Added.

WebCore:

  • ForwardingHeaders/wtf/BumpPointerAllocator.h: Added.
12:04 PM Changeset in webkit [64145] by andersca@apple.com
  • 5 edits
    2 moves in trunk/WebKit2

Rename NPJSObjectMap to NPRuntimeObjectMap
​https://bugs.webkit.org/show_bug.cgi?id=43066

Reviewed by Adam Roben.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Plugins/NPJSObjectMap.cpp: Removed.
  • WebProcess/Plugins/NPJSObjectMap.h: Removed.
  • WebProcess/Plugins/NPRuntimeObjectMap.cpp: Added.

(WebKit::NPJSObject::NPJSObject):
(WebKit::NPJSObject::~NPJSObject):
(WebKit::NPJSObject::toNPJSObject):
(WebKit::NPJSObject::create):
(WebKit::NPJSObject::isNPJSObject):
(WebKit::NPJSObject::initialize):
(WebKit::identifierFromIdentifierRep):
(WebKit::NPJSObject::hasProperty):
(WebKit::NPJSObject::getProperty):
(WebKit::NPJSObject::npClass):
(WebKit::NPJSObject::NP_Allocate):
(WebKit::NPJSObject::NP_Deallocate):
(WebKit::NPJSObject::NP_HasProperty):
(WebKit::NPJSObject::NP_GetProperty):
(WebKit::NPRuntimeObjectMap::NPRuntimeObjectMap):
(WebKit::NPRuntimeObjectMap::getOrCreateNPObject):
(WebKit::NPRuntimeObjectMap::invalidate):

  • WebProcess/Plugins/NPRuntimeObjectMap.h: Added.
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
(WebKit::PluginView::~PluginView):
(WebKit::PluginView::windowScriptNPObject):
(WebKit::PluginView::pluginElementNPObject):

  • WebProcess/Plugins/PluginView.h:
  • win/WebKit2.vcproj:
11:32 AM Changeset in webkit [64144] by pfeldman@chromium.org
  • 5 edits in trunk/WebCore

2010-07-27 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: render network timing as gant chart in popover.

​https://bugs.webkit.org/show_bug.cgi?id=43051

  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::buildObjectForTiming):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._showPopover):
  • inspector/front-end/inspector.css: (.resource-timing-row): (.resource-timing-bar): (.resource-timing-bar-title):
  • inspector/front-end/utilities.js:
11:16 AM Changeset in webkit [64143] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Add inspector/debugger-breakpoints-not-activated-on-reload.html (introduced in r64133) to the Skipped list.

  • platform/qt/Skipped: inspector/debugger-breakpoints-not-activated-on-reload.html skipped.
11:14 AM Changeset in webkit [64142] by victorw@chromium.org
  • 11 edits in trunk/WebCore

2010-07-27 Victor Wang <​victorw@chromium.org>

Unreviewed, rolling out r64104.
​http://trac.webkit.org/changeset/64104
​https://bugs.webkit.org/show_bug.cgi?id=40768

The patch causes chromium webkit socket laytest crashes on
windows randomly

  • inspector/InspectorController.cpp: (WebCore::InspectorController::addResource): (WebCore::InspectorController::removeResource):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::cachedResource): (WebCore::InspectorResource::type): (WebCore::InspectorResource::resourceData):
  • inspector/InspectorResource.h: (WebCore::InspectorResource::): (WebCore::InspectorResource::create):
  • inspector/front-end/Resource.js: (WebInspector.Resource.Type.toString): (WebInspector.Resource.prototype.set type): (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshRequestHeaders): (WebInspector.ResourceView.prototype._refreshResponseHeaders): (WebInspector.ResourceView.prototype._refreshHeaders):
  • inspector/front-end/inspector.css: (.resources-category-scripts, .resources-category-xhr, .resources-category-fonts, .resources-category-other):
  • inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.updateResource):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::processBuffer):
  • websockets/WebSocketChannel.h:
11:04 AM Changeset in webkit [64141] by andreip@google.com
  • 12 edits in trunk

2010-07-27 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

[IndexedDB] Key range methods belong to the IDBKeyRange interface
​https://bugs.webkit.org/show_bug.cgi?id=43052

  • storage/indexeddb/script-tests/keyrange.js: (checkSingleKeyRange): (checkLeftBoundKeyRange): ():

2010-07-27 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

[IndexedDB] Key range methods belong to the IDBKeyRange interface
​https://bugs.webkit.org/show_bug.cgi?id=43052

Move the key range methods from the IndexedDatabaseRequest interface
to the IDBKeyRange interface. Also add a global IDBKeyRange object
that can be used to access the IDBKeyRange constants and factory methods.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::clear): (WebCore::DOMWindow::iDBKeyRange):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • storage/IDBKeyRange.cpp: (WebCore::IDBKeyRange::only): (WebCore::IDBKeyRange::leftBound): (WebCore::IDBKeyRange::rightBound): (WebCore::IDBKeyRange::bound):
  • storage/IDBKeyRange.h:
  • storage/IDBKeyRange.idl:
  • storage/IndexedDatabaseRequest.cpp:
  • storage/IndexedDatabaseRequest.h:
  • storage/IndexedDatabaseRequest.idl:
10:45 AM QtScript edited by kent.hansen@nokia.com
(diff)
10:42 AM QtScript edited by kent.hansen@nokia.com
(diff)
10:39 AM BugAdvice created by ojan@chromium.org
10:17 AM Changeset in webkit [64140] by Adam Roben
  • 2 edits in trunk/WebKit2

Make preferences APIs robust against web process crashes

Fixes <​http://webkit.org/b/43049> Crash in
WebPageNamespace::preferencesDidChange if preferences are changed
after the web process crashes

Reviewed by Anders Carlsson.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::preferencesDidChange): Bail out if we don't have
a web process. The new preference values will get propogated to the
web process if and when it launches.

10:14 AM Changeset in webkit [64139] by Chris Fleizach
  • 3 edits in trunk/WebCore

AX: consolidate parentObjectIfExists() and parentObject() code
​https://bugs.webkit.org/show_bug.cgi?id=42981

Reviewed by Darin Adler.

Consolidate duplicate code in parentObject and parentObjectIfExists

No tests. No functionality changed.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::renderParentObject):
(WebCore::AccessibilityRenderObject::parentObjectIfExists):
(WebCore::AccessibilityRenderObject::parentObject):

  • accessibility/AccessibilityRenderObject.h:
9:56 AM WikiStart edited by ojan@chromium.org
(diff)
9:44 AM Changeset in webkit [64138] by leandro@webkit.org
  • 2 edits in trunk

2010-07-26 ryuan choi <​ryuan.choi@samsung.com>

Unreviewed build fix.

[EFL]REGRESSION(r63952): build break because of InspectorBackendDispatcher.cpp
​https://bugs.webkit.org/show_bug.cgi?id=43021

Modify cmake script to fix build break as adding InspectorBackendDispatcher.

  • cmake/WebKitGenerators.cmake:
9:33 AM Changeset in webkit [64137] by Chris Fleizach
  • 2 edits in trunk/WebCore

AX: replace m_renderer->document->axObjectCache() with just axObjectCache()
​https://bugs.webkit.org/show_bug.cgi?id=42979

Reviewed by Adam Barth.

No new tests. Code cleanup only.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::firstChild):
(WebCore::AccessibilityRenderObject::lastChild):
(WebCore::AccessibilityRenderObject::previousSibling):
(WebCore::AccessibilityRenderObject::nextSibling):
(WebCore::AccessibilityRenderObject::parentObjectIfExists):
(WebCore::AccessibilityRenderObject::parentObject):
(WebCore::AccessibilityRenderObject::menuForMenuButton):
(WebCore::AccessibilityRenderObject::menuButtonForMenu):
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
(WebCore::AccessibilityRenderObject::axObjectCache):
(WebCore::AccessibilityRenderObject::contentChanged):
(WebCore::AccessibilityRenderObject::addChildren):

9:30 AM Changeset in webkit [64136] by commit-queue@webkit.org
  • 2 edits in trunk

2010-07-27 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Changing library names (appending suffix "_efl")
​https://bugs.webkit.org/show_bug.cgi?id=42902

Instead of having libwebcore.so, we will have libwebcore_efl.so.
Same for javascriptcore and wtf when compiled as shared, and for jsc.

  • cmake/OptionsEfl.cmake:
9:19 AM Changeset in webkit [64135] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-07-27 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Remove some mistakenly skipped tests from the skipped list as well as
a couple tests that no longer exist.

  • platform/gtk/Skipped: Fix some errors in the skipped list.
9:18 AM Changeset in webkit [64134] by Adam Roben
  • 2 edits in trunk/WebKitTools

Mac build fix

  • MiniBrowser/mac/BrowserWindowController.m:

(processDidExit):
(-[BrowserWindowController awakeFromNib]):
Added processDidExit support.

9:12 AM Changeset in webkit [64133] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

2010-07-27 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: do not activate all breakpoints on page reload
​https://bugs.webkit.org/show_bug.cgi?id=41461

  • http/tests/inspector/debugger-test.js: (frontend_scriptsAreParsed): (frontend_waitUntilScriptsAreParsed.waitForAllScripts): (frontend_waitUntilScriptsAreParsed): (frontend_ensureSourceFrameLoaded): (frontend_showScriptSource):
  • inspector/debugger-breakpoints-not-activated-on-reload-expected.txt: Added.
  • inspector/debugger-breakpoints-not-activated-on-reload.html: Added.
  • platform/gtk/Skipped: skip the test on GTK due to JSC debugger issue

2010-07-27 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: do not activate all breakpoints on page reload
​https://bugs.webkit.org/show_bug.cgi?id=41461

Test: inspector/debugger-breakpoints-not-activated-on-reload.html

  • inspector/front-end/ScriptView.js: (WebInspector.ScriptView.prototype._addBreakpoint):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._breakpointAdded): (WebInspector.ScriptsPanel.prototype.toggleBreakpointsClicked):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._addBreakpoint):

2010-07-27 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: if breakpoints were deactivated, add new breakpoints as disabled.
​https://bugs.webkit.org/show_bug.cgi?id=41461

  • src/js/DebuggerScript.js: ():
9:06 AM Changeset in webkit [64132] by Adam Roben
  • 5 edits in trunk/WebKit2

Add a ProcessDidExit callback to the WKPageLoaderClient

Fixes <​http://webkit.org/b/43048> UI process needs a way to find out
when the web process crashes

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKPage.h: Added WKPageProcessDidExitCallback, and a

processDidExit member of that type to WKPageLoaderClient.

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::processDidExit): Added. Calls through to the
WKPageLoaderClient.

  • UIProcess/WebLoaderClient.h: Added processDidExit.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processDidExit): Tell the loader client the
process exited.

8:54 AM Changeset in webkit [64131] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKitTools

2010-07-26 Antonio Gomes <​tonikitoo@webkit.org>

Rubber-stamped by Simon Hausmann.

[Qt] Reorder some items in Developers' menu so QGraphicsView one is easier accessible.

Move some less useful menu items on Developers menu from the top to the bottom, so
QGraphicsView menu goes to the top, and becomes more quickly accessible.

  • QtTestBrowser/main.cpp: (LauncherWindow::createChrome):
8:37 AM Changeset in webkit [64130] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk/JavaScriptCore/qt

2010-07-27 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement QScriptEngine::newFunction() parts that doesn't depend on QScriptContext
​https://bugs.webkit.org/show_bug.cgi?id=42174

Since our function can be called in Javascript both as a function
and as a constructor, we couldn't use the existing
JSObjectMakeFunctionWithCallback() and JSObjectMakeConstructor().

Instead, a JSClassRef was created, implementing the needed
callbacks (the callAsConstructor is not there yet because its
behaviour depends on QScriptContext).

For the moment, QScriptContext is defined as a void type, since we
still don't use it.

The variant of newFunction() that also takes an external argument
was also implemented. The details of implementation were added to
the qscriptfunction{.c,_p.h} files.

This commit also adds tests, some of them from Qt's upstream.

  • api/QtScript.pro:
  • api/qscriptengine.cpp: (QScriptEngine::newFunction):
  • api/qscriptengine.h:
  • api/qscriptengine_p.cpp: (QScriptEnginePrivate::QScriptEnginePrivate): (QScriptEnginePrivate::~QScriptEnginePrivate): (QScriptEnginePrivate::newFunction):
  • api/qscriptengine_p.h:
  • api/qscriptfunction.cpp: Added. (qt_NativeFunction_finalize): (qt_NativeFunction_callAsFunction): (qt_NativeFunctionWithArg_finalize): (qt_NativeFunctionWithArg_callAsFunction):
  • api/qscriptfunction_p.h: Added. (QNativeFunctionData::QNativeFunctionData): (QNativeFunctionWithArgData::QNativeFunctionWithArgData):
  • api/qscriptoriginalglobalobject_p.h: (QScriptOriginalGlobalObject::QScriptOriginalGlobalObject): (QScriptOriginalGlobalObject::~QScriptOriginalGlobalObject): (QScriptOriginalGlobalObject::functionPrototype):
  • tests/qscriptengine/tst_qscriptengine.cpp: (myFunction): (myFunctionWithArg): (myFunctionThatReturns): (myFunctionThatReturnsWithoutEngine): (myFunctionThatReturnsWrongEngine): (tst_QScriptEngine::newFunction):
8:29 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
8:25 AM QtScript created by kent.hansen@nokia.com
8:25 AM Changeset in webkit [64129] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix the path to InjectedBundle.dll in Debug_Internal builds

Fixes <​http://webkit.org/b/42994> WebKitTestRunner fails to load
InjectedBundle.dll in the Debug_Internal configuration

Reviewed by Anders Carlsson.

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::initializeInjectedBundlePath): Add the _debug
suffix only in Debug_All builds.

8:06 AM Changeset in webkit [64128] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-27 Pranav Kedia <​pranavk@chromium.org>

Reviewed by Adam Barth.

Chrome browser Bug: Pause button stays when <audio> hits end
​https://bugs.webkit.org/show_bug.cgi?id=42677

The change is just in chromium media. Tested using media part of
WebKit layout tests. The following test that was failing is passing.
media/video-duration-known-after-eos.html -> unexpected pass

  • rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaPlayButton): Using mediaElement->canPlay() instead of mediaElement->paused() to paint the play/pause button.
8:01 AM Changeset in webkit [64127] by abecsi@webkit.org
  • 2 edits in trunk/WebKit2

2010-07-27 Andras Becsi <​abecsi@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] WebEventFactory::createWebMouseEvent should follow WebKit2 API changes
​https://bugs.webkit.org/show_bug.cgi?id=43042

  • Shared/qt/WebEventFactoryQt.cpp: (WebKit::WebEventFactory::createWebMouseEvent): Set deltaX, deltaY and deltaZ arguments.
7:12 AM Changeset in webkit [64126] by steveblock@google.com
  • 9 edits in trunk

2010-07-27 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Client-based Geolocation does not pass enableHighAccuracy option to controller and client
​https://bugs.webkit.org/show_bug.cgi?id=40374

This change passes the enableHighAccuracy request option to the GeolocationController.
The GeolocationController tracks whether this should be used by the client.

No new tests possible as the mock provider doesn't support this feature.

  • page/Geolocation.cpp: (WebCore::Geolocation::setIsAllowed): (WebCore::Geolocation::startUpdating):
  • page/GeolocationController.cpp: (WebCore::GeolocationController::addObserver): (WebCore::GeolocationController::removeObserver):
  • page/GeolocationController.h:
  • page/GeolocationControllerClient.h:

2010-07-27 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

Client-based Geolocation does not pass enableHighAccuracy option to controller and client
​https://bugs.webkit.org/show_bug.cgi?id=40374

Stub out setEnableHighAccuracy method for the Mac port.

  • WebCoreSupport/WebGeolocationControllerClient.h: (WebGeolocationControllerClient::setEnableHighAccuracy):

2010-07-27 Steve Block <​steveblock@google.com>

Reviewed by Alexey Proskuryakov.

Client-based Geolocation does not pass enableHighAccuracy option to controller and client
​https://bugs.webkit.org/show_bug.cgi?id=40374

Stub out setEnableHighAccuracy method for the Win port.

  • WebCoreSupport/WebGeolocationControllerClient.h: (WebGeolocationControllerClient::setEnableHighAccuracy):
6:55 AM Changeset in webkit [64125] by steveblock@google.com
  • 3 edits
    1 copy
    4 adds in trunk/LayoutTests

2010-07-27 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

LayoutTests/fast/dom/DeviceOrientation/window-property.html assumes use of V8
​https://bugs.webkit.org/show_bug.cgi?id=43025

This change modifies window-property.html and its expected result to work with JSC.
A V8-specific expected result is added for Android.

  • fast/dom/DeviceOrientation/script-tests/window-property.js:
  • fast/dom/DeviceOrientation/window-property-expected.txt:
  • platform/android-v8: Added.
  • platform/android-v8/fast: Added.
  • platform/android-v8/fast/dom: Added.
  • platform/android-v8/fast/dom/DeviceOrientation: Added.
  • platform/android-v8/fast/dom/DeviceOrientation/window-property-expected.txt: Added.
6:44 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
6:41 AM Changeset in webkit [64124] by loislo@chromium.org
  • 30 edits
    2 deletes in trunk

2010-07-27 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Current implementation of message based inspector
transport generated by CodeGeneratorInspector should be upstreamed
from WebKit/chromium to WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=42983

  • Android.derived.v8bindings.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptObject.cpp:
  • bindings/js/ScriptObject.h:
  • bindings/v8/ScriptObject.cpp:
  • bindings/v8/ScriptObject.h:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorBackend.idl: Removed.
  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::windowObjectCleared): (WebCore::InspectorFrontendClientLocal::sendMessageToBackend):
  • inspector/InspectorFrontendClientLocal.h:
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::sendMessageToBackend):
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub): (.WebInspector.InspectorBackendStub.prototype._registerDelegate): (.WebInspector.InspectorBackendStub.prototype.sendMessageToBackend):

2010-07-27 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Current implementation of message based inspector
transport generated by CodeGeneratorInspector should be upstreamed
from WebKit/chromium to WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=42983

  • WebKit.gypi:
  • src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::sendMessageToBackend):
  • src/InspectorFrontendClientImpl.h:
  • src/ToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::dispatchOnInspectorController): (WebKit::WebDevToolsAgentImpl::initDevToolsAgentHost):
  • src/WebDevToolsAgentImpl.h:
  • src/js/InspectorControllerImpl.js: Removed.
6:10 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
6:01 AM Changeset in webkit [64123] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKitTools

2010-07-25 Mahesh Kulkarni <​mahesh.kulkarni@nokia.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=42947
Check for WEBKIT_TESTFONTS for qt, gtk and windows port and throw
error. Without which dumpRenderTree crashes.

  • Scripts/old-run-webkit-tests:
5:56 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
5:49 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
5:43 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
5:27 AM Changeset in webkit [64122] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit2

2010-07-27 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] WebKit::PageClient implementation needs a dedicated class

​https://bugs.webkit.org/show_bug.cgi?id=42974

  • UIProcess/API/qt/qwkpage.cpp: (PageClientImpl::PageClientImpl): Added. (PageClientImpl::pageDidEnterAcceleratedCompositing): Moved from QWKPagePrivate. (PageClientImpl::pageDidLeaveAcceleratedCompositing): Ditto. (PageClientImpl::processDidExit): Ditto. (PageClientImpl::processDidRevive): Ditto. (PageClientImpl::setCursor): Ditto. (PageClientImpl::takeFocus): Ditto. (PageClientImpl::toolTipChanged): Ditto. (QWKPagePrivate::QWKPagePrivate): Set a new instance of the PageClientImpl as PageClient rather than 'this'.
  • UIProcess/API/qt/qwkpage_p.h: Removed PageClient implementation methods from QWKPagePrivate.
5:08 AM Changeset in webkit [64121] by antonm@chromium.org
  • 3 edits in trunk/LayoutTests

2010-07-27 Anton Muhin <​antonm@chromium.org>

Reviewed by Darin Adler.

Extend a test checking access to nested elements on the document to cover recent regression in Chromium
​https://bugs.webkit.org/show_bug.cgi?id=42980

See ​http://code.google.com/p/chromium/issues/detail?id=48804 for more details.

  • fast/dom/HTMLDocument/document-special-properties-expected.txt:
  • fast/dom/HTMLDocument/document-special-properties.html:
4:56 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
4:56 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
3:55 AM Changeset in webkit [64120] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

[Qt] Incorrect input method hints
​https://bugs.webkit.org/show_bug.cgi?id=43037

Reviewed by Tor Arne Vestbø.

Properly set or reset all input method hints when
activating input fields.

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::setInputMethodState):

  • tests/qwebview/tst_qwebview.cpp:

(tst_QWebView::focusInputTypes): Extended unit test to verify that we
reset hints.

3:05 AM Changeset in webkit [64119] by vestbo@webkit.org
  • 3 edits in trunk/LayoutTests/platform/qt

[Qt] Fix failing layout-tests after r64114

3:04 AM Companies and Organizations that have contributed to WebKit edited by zherczeg@webkit.org
(diff)
2:51 AM Changeset in webkit [64118] by kim.1.gronholm@nokia.com
  • 5 edits in trunk/WebKit/qt

2010-07-27 Kim Grönholm <​kim.1.gronholm@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Decouple QTouchEvent's accepted flag from JS prevent default
​https://bugs.webkit.org/show_bug.cgi?id=42892

We need to always accept the QTouchEvents in order to get TouchUpdate and
TouchEnd events. QWebPage::event() return value is used to indicate
whether the default action was prevented for the touch events.

  • Api/qgraphicswebview.cpp: (QGraphicsWebView::sceneEvent):
  • Api/qwebpage.cpp: (QWebPagePrivate::touchEvent): (QWebPage::event):
  • Api/qwebpage_p.h:
  • Api/qwebview.cpp: (QWebView::event):
2:36 AM Changeset in webkit [64117] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Trivial test fix.

  • fast/forms/script-tests/input-number-events.js: Adjust pixel values in order to work on Windows.
2:29 AM Changeset in webkit [64116] by vestbo@webkit.org
  • 2 edits in trunk/LayoutTests

Update expected result as well to match r64115.

Reviewed by NOBODY.

  • fast/events/spatial-navigation/snav-clipped-overflowed-content-expected.txt:
2:12 AM Changeset in webkit [64115] by vestbo@webkit.org
  • 3 edits in trunk/LayoutTests

Fix GTK layout-test break after r64114

Reviewed by NOBODY.

Skipping the test for Qt until we can find a non-fragile way to write
the test.

  • fast/events/spatial-navigation/snav-clipped-overflowed-content.html:
  • platform/qt/Skipped:
1:38 AM Changeset in webkit [64114] by vestbo@webkit.org
  • 780 edits in trunk

[Qt] Change default font from sans-serif to serif

Reviewed by Simon Hausmann.

This matches what other ports and browser engines do.

We now also use QFont's defaultFontFamily() to resolve the
correct fonts for each platform. For Qt >= 4.7 we can take
advantage of the new enums for generic font families.

The spatial-navigation test had to be changed due to the
fragile nature of the down-action. By changing the font we
hit the case where the two down actions were not enough to
scroll the link into view.

1:33 AM Changeset in webkit [64113] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-07-27 Dominic Mazzoni <​dmazzoni@google.com>

Reviewed by Chris Fleizach.

Add accessors for node and document to WebAccessibilityObject,
needed to support some Windows screenreader functionality.

​https://bugs.webkit.org/show_bug.cgi?id=43001

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::node): (WebKit::WebAccessibilityObject::document):
1:07 AM Changeset in webkit [64112] by commit-queue@webkit.org
  • 4 edits
    4 copies in trunk/WebKit/chromium

2010-07-27 Dominic Mazzoni <​dmazzoni@google.com>

Reviewed by Chris Fleizach.

For Windows accessibility, have WebElement provide access
to its attributes.

​https://bugs.webkit.org/show_bug.cgi?id=43004

  • WebKit.gyp:
  • public/WebAttribute.h: Added. (WebKit::WebAttribute::~WebAttribute): (WebKit::WebAttribute::WebAttribute): (WebKit::WebAttribute::operator=):
  • public/WebElement.h:
  • public/WebNamedNodeMap.h: Added. (WebKit::WebNamedNodeMap::~WebNamedNodeMap): (WebKit::WebNamedNodeMap::WebNamedNodeMap): (WebKit::WebNamedNodeMap::operator=):
  • src/WebAttribute.cpp: Added. (WebKit::WebAttribute::reset): (WebKit::WebAttribute::assign): (WebKit::WebAttribute::WebAttribute): (WebKit::WebAttribute::localName): (WebKit::WebAttribute::value):
  • src/WebElement.cpp: (WebKit::WebElement::attributes):
  • src/WebNamedNodeMap.cpp: Added. (WebKit::WebNamedNodeMap::reset): (WebKit::WebNamedNodeMap::assign): (WebKit::WebNamedNodeMap::WebNamedNodeMap): (WebKit::WebNamedNodeMap::length): (WebKit::WebNamedNodeMap::attributeItem):
12:50 AM Changeset in webkit [64111] by commit-queue@webkit.org
  • 17 edits
    1 delete in trunk

2010-07-27 Satish Sampath <​satish@chromium.org>

Reviewed by Kent Tamura.

Simplify speech input plumbing in webcore and webkit
​https://bugs.webkit.org/show_bug.cgi?id=43008

No new tests as functionality is not changed.

  • GNUmakefile.am: Removed a header file.
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Page.cpp: (WebCore::Page::speechInput): Creates and returns SpeechInput when needed.
  • page/Page.h:
  • page/SpeechInput.cpp: Added methods to proxy and callbacks between input elements and WebKit (WebCore::SpeechInput::SpeechInput): (WebCore::SpeechInput::didCompleteRecording): (WebCore::SpeechInput::didCompleteRecognition): (WebCore::SpeechInput::setRecognitionResult): (WebCore::SpeechInput::startRecognition): (WebCore::SpeechInput::stopRecording):
  • page/SpeechInput.h:
  • page/SpeechInputClient.h:
  • page/SpeechInputClientListener.h: Removed.
  • page/SpeechInputListener.h:
  • rendering/TextControlInnerElements.cpp: Added one more callback. (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::speechInput): (WebCore::InputFieldSpeechButtonElement::didCompleteRecognition):
  • rendering/TextControlInnerElements.h:

2010-07-27 Satish Sampath <​satish@chromium.org>

Reviewed by Kent Tamura.

Simplify speech input plumbing in webcore and webkit
​https://bugs.webkit.org/show_bug.cgi?id=43008

  • src/SpeechInputClientImpl.cpp: Move functionality to WebCore::SpeechInput and make this a dummy proxy. (WebKit::SpeechInputClientImpl::startRecognition): (WebKit::SpeechInputClientImpl::cancelRecognition): (WebKit::SpeechInputClientImpl::didCompleteRecording): (WebKit::SpeechInputClientImpl::didCompleteRecognition): (WebKit::SpeechInputClientImpl::setRecognitionResult):
  • src/SpeechInputClientImpl.h:
12:31 AM Changeset in webkit [64110] by tkent@chromium.org
  • 10 edits
    4 deletes in trunk

Add a runtime setting for interactive form validation.
​https://bugs.webkit.org/show_bug.cgi?id=40520

Reviewed by Ojan Vafai.

WebCore:

The interactive validation feature was disabled for non-strict
modes by r61059 to avoid a compatibility issue. This removes the
mode checking and introduce a runtime setting to enable/disable
the feature instead.
The default value is 'disable' and we'll remove the setting when
the compatibility issue is resolved and interactive validation
implementation is completed.

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setInteractiveFormValidationEnabled):
(WebCore::Settings::interactiveFormValidationEnabled):

LayoutTests:

Remove the mode-specific tests and skip tests which don't work
without the interactive validation feature.

  • fast/forms/interactive-validation-compat-mode-expected.txt: Removed.
  • fast/forms/interactive-validation-compat-mode.html: Removed.
  • fast/forms/interactive-validation-html4-expected.txt: Removed.
  • fast/forms/interactive-validation-html4.html: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
12:05 AM Changeset in webkit [64109] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-07-27 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=42956
[DRT/Chromium] Fix "out of sync" assertion error

Fix an assertion error on Windows like the following:
100721 20:16:46 chromium.py:386 CRITICAL Test got out of sync:
|​file:///c:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
|​file:///C:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|

  • Scripts/webkitpy/layout_tests/port/chromium.py: If the url matches with "​file:///[a-z]:", does case-ignore comparison. GURL capitalize the driver letter of a file: URL.

Jul 26, 2010:

11:04 PM Changeset in webkit [64108] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix from Chromium/GTK build fix!

  • wtf/PageAllocation.cpp:
10:51 PM Changeset in webkit [64107] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Chromium/GTK build fix

  • wtf/PageAllocation.cpp:
10:23 PM Changeset in webkit [64106] by barraclough@apple.com
  • 7 edits in trunk/JavaScriptCore

Build fix for !Mac platforms.

10:02 PM Changeset in webkit [64105] by barraclough@apple.com
  • 13 edits
    4 adds
    3 deletes in trunk

Bug 43009 - Abstract out page allocation from executable allocators

Reviewed by Oliver Hunt.

JavaScriptCore:

It would be great to have a single platform abstraction for block allocation, rather than copy/paste code.

In this initial implementation I've made Symbian fall back to use malloc/free for non-executable memory.
I think this will match current behaviour for the next client we will want to port across (RegisterFile &
Collector).

(JSC::ExecutableAllocator::intializePageSize):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
(JSC::ExecutableAllocator::isValid):

  • jit/ExecutableAllocator.h:

(JSC::ExecutablePool::ExecutablePool):
(JSC::ExecutablePool::poolAllocate):

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolAllocator::release):
(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::isValid):
(JSC::FixedVMPoolAllocator::isWithinVMPool):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):

  • jit/ExecutableAllocatorPosix.cpp: Removed.
  • jit/ExecutableAllocatorSymbian.cpp: Removed.
  • jit/ExecutableAllocatorWin.cpp: Removed.
  • wscript:
  • wtf/PageAllocator.cpp: Added.

(WTF::protection):
(WTF::PageAllocation::commit):
(WTF::PageAllocation::decommit):
(WTF::PageAllocator::allocate):
(WTF::PageAllocator::reserve):
(WTF::PageAllocator::deallocate):
(WTF::PageAllocator::pagesize):

  • wtf/PageAllocator.h: Added.

(WTF::PageAllocation::PageAllocation):
(WTF::PageAllocation::base):
(WTF::PageAllocation::size):
(WTF::PageAllocation::chunk):
(WTF::PageAllocation::operator!):
(WTF::PageAllocator::):

JavaScriptGlue:

  • ForwardingHeaders/wtf/PageAllocation.h: Added.

WebCore:

  • ForwardingHeaders/wtf/PageAllocation.h: Added.
9:51 PM Changeset in webkit [64104] by commit-queue@webkit.org
  • 11 edits in trunk/WebCore

2010-07-26 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Pavel Feldman.

Add WebSocket resource type to Web Inspector.

When a new WebSocket connection is established, a line for that connection
will appear in Web Inspector's Resources tab. If the resource name is
clicked, the details of handshake request and response will be shown.

Web Inspector: WebSocket in Resources tab
​https://bugs.webkit.org/show_bug.cgi?id=40768

  • inspector/InspectorController.cpp: (WebCore::InspectorController::addResource): WebSocket resource does not have an associated loader, thus frame might be null. Need to check it. (WebCore::InspectorController::removeResource): Ditto. (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: Add null checks of m_loader and m_frame, because WebSocket does not have a loader and we need to allow null for these variables. (WebCore::createReadableStringFromBinary): (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::create): Factory function of regular (non-WebSocket) resources. (WebCore::InspectorResource::createWebSocket): Factory function of WebSocket resources. (WebCore::InspectorResource::updateWebSocketRequest): (WebCore::InspectorResource::updateWebSocketResponse): (WebCore::InspectorResource::updateScriptObject): m_frame->document() becomes available when Frame::setDocument() is called. We cannot obtain documentURL during the constructor or updateRequest() function, because m_frame->document() is not available yet at that point and documentURL will contain a wrong URL. As far as I know, updateScriptObject() is the only place where we can safely obtain documentURL. (WebCore::InspectorResource::cachedResource): (WebCore::InspectorResource::type): (WebCore::InspectorResource::resourceData):
  • inspector/InspectorResource.h: (WebCore::InspectorResource::): (WebCore::InspectorResource::markWebSocket):
  • inspector/front-end/Resource.js: (WebInspector.Resource.Type.toString): (WebInspector.Resource.prototype.set type): (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshRequestHeaders): (WebInspector.ResourceView.prototype._refreshResponseHeaders): (WebInspector.ResourceView.prototype._refreshHeaders):
  • inspector/front-end/inspector.css: (.resources-category-websockets, .resources-category-other): (.resources-category-websockets .resources-graph-bar): (.resources-category-websockets.resource-cached .resources-graph-bar):
  • inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.updateResource):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::processBuffer): (WebCore::WebSocketChannel::identifier):
  • websockets/WebSocketChannel.h:
9:34 PM Changeset in webkit [64103] by commit-queue@webkit.org
  • 4 edits in trunk

2010-07-26 Cosmin Truta <​ctruta@chromium.org>

Reviewed by Eric Seidel.

Some SVGs with empty <g> elements crash Chromium on Linux
​https://bugs.webkit.org/show_bug.cgi?id=41175

Remove the suppression of this bug's test on Chromium. The new fix in WebKit no longer requires
an update in Chromium, making this test safe to expose.

  • platform/chromium/test_expectations.txt:

2010-07-26 Cosmin Truta <​ctruta@chromium.org>

Reviewed by Eric Seidel.

Some SVGs with empty <g> elements crash Chromium on Linux
​https://bugs.webkit.org/show_bug.cgi?id=41175

Redo the old fix using a different approach, to avoid regressing
svg/batik/filters/filterRegions.svg with Chromium on Linux.
Specifically, handle empty SkBitmap objects by exiting early upon
encountering unconfigured (i.e. empty) bitmaps.

No new tests. This bug's old test (svg/filters/filter-empty-g.svg)
and the above-mentioned regressed test are expected to pass.

  • WebCore/platform/graphics/skia/ImageBufferSkia.cpp: (ImageBuffer::ImageBuffer): Undo the old fix. (getImageData): The new fix.
8:43 PM Changeset in webkit [64102] by Simon Fraser
  • 3 edits in trunk/LayoutTests

2010-07-26 Simon Fraser <Simon Fraser>

Fix a couple of test results after r64095.

  • compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
7:53 PM Changeset in webkit [64101] by barraclough@apple.com
  • 11 edits
    3 adds
    2 deletes in trunk/JavaScriptCore

Rolling out r64097:64100, oops, more b0rked than I relized by my last changes, sorry!

(JSC::ExecutableAllocator::reprotectRegion):
(JSC::ExecutableAllocator::cacheFlush):

  • jit/ExecutableAllocator.h:

(JSC::ExecutablePool::ExecutablePool):
(JSC::ExecutablePool::poolAllocate):

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolAllocator::release):
(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::isValid):
(JSC::FixedVMPoolAllocator::isWithinVMPool):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):

  • jit/ExecutableAllocatorPosix.cpp: Added.

(JSC::ExecutableAllocator::intializePageSize):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
(JSC::ExecutableAllocator::isValid):

  • jit/ExecutableAllocatorSymbian.cpp: Added.

(JSC::ExecutableAllocator::intializePageSize):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
(JSC::ExecutableAllocator::isValid):

  • jit/ExecutableAllocatorWin.cpp: Added.

(JSC::ExecutableAllocator::intializePageSize):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
(JSC::ExecutableAllocator::isValid):

  • wscript:
  • wtf/PageAllocation.cpp: Removed.
  • wtf/PageAllocation.h: Removed.
7:39 PM Changeset in webkit [64100] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

Speculative !debug build fix II.

  • wtf/PageAllocation.h:

(WTF::PageAllocation::PageAllocation):

7:37 PM Changeset in webkit [64099] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Speculative !debug build fix.

  • wtf/PageAllocation.h:

(WTF::PageAllocation::PageAllocation):

7:12 PM Changeset in webkit [64098] by barraclough@apple.com
  • 11 edits
    2 adds
    3 deletes in trunk/JavaScriptCore

Bug 43009 - Abstract out page allocation from executable allocators

Reviewed by Oliver Hunt.

It would be great to have a single platform abstraction for block allocation, rather than copy/paste code.

In this initial implementation I've made Symbian fall back to use malloc/free for non-executable memory.
I think this will match current behaviour for the next client we will want to port across (RegisterFile &
Collector).

(JSC::ExecutableAllocator::intializePageSize):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):
(JSC::ExecutableAllocator::isValid):

  • jit/ExecutableAllocator.h:

(JSC::ExecutablePool::ExecutablePool):
(JSC::ExecutablePool::poolAllocate):

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolAllocator::release):
(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::isValid):
(JSC::FixedVMPoolAllocator::isWithinVMPool):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):

  • jit/ExecutableAllocatorPosix.cpp: Removed.
  • jit/ExecutableAllocatorSymbian.cpp: Removed.
  • jit/ExecutableAllocatorWin.cpp: Removed.
  • wscript:
  • wtf/PageAllocator.cpp: Added.

(WTF::protection):
(WTF::PageAllocation::commit):
(WTF::PageAllocation::decommit):
(WTF::PageAllocator::allocate):
(WTF::PageAllocator::reserve):
(WTF::PageAllocator::deallocate):
(WTF::PageAllocator::pagesize):

  • wtf/PageAllocator.h: Added.

(WTF::PageAllocation::PageAllocation):
(WTF::PageAllocation::base):
(WTF::PageAllocation::size):
(WTF::PageAllocation::chunk):
(WTF::PageAllocation::operator!):
(WTF::PageAllocator::):

7:10 PM Changeset in webkit [64097] by commit-queue@webkit.org
  • 3 edits
    1 move in trunk/WebKit

2010-07-26 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Move CMakeListsEfl.txt to WebKit/efl/
​https://bugs.webkit.org/show_bug.cgi?id=43002

This should reduce the noise in WebKit/ChangeLog that comes from EFL
port. Most of the changes on EFL port should be logged in
WebKit/efl/ChangeLog.

  • CMakeLists.txt: Just change the path from where to include the file.

2010-07-26 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Move CMakeListsEfl.txt to WebKit/efl/
​https://bugs.webkit.org/show_bug.cgi?id=43002

This should reduce the noise in WebKit/ChangeLog that comes from EFL
port. Most of the changes on EFL port should be logged in
WebKit/efl/ChangeLog.

  • CMakeListsEfl.txt: Renamed from WebKit/CMakeListsEfl.txt.
6:17 PM Changeset in webkit [64096] by Darin Adler
  • 15 edits in trunk

WebKitTestRunner needs to support layoutTestController.counterValueForElementById
​https://bugs.webkit.org/show_bug.cgi?id=42537

Reviewed by Sam Weinig.

WebKitTestRunner needs layoutTestController.markerTextForListItem
​https://bugs.webkit.org/show_bug.cgi?id=42549

WebKit2:

  • UIProcess/API/C/WKString.cpp:

(WKStringIsEmpty): Added.

  • UIProcess/API/C/WKString.h: Added WKStringIsEmpty.
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(copiedString): Added. Helper for functions that return a
WKStringRef that follows the copy rule.
(WKBundleFrameCopyName): Use copiedString.
(WKBundleFrameCopyCounterValue): Added. Calls counterValue.
(WKBundleFrameCopyMarkerText): Added. Calls markerText.

  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:

Added WKBundleFrameCopyCounterValue and WKBundleFrameCopyMarkerText.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::computedStyleIncludingVisitedInfo):
Renamed argument to streamline function a bit.
(WebKit::WebFrame::counterValue): Added.
(WebKit::WebFrame::markerText): Added.

  • WebProcess/WebPage/WebFrame.h: Added counterValue and markerText.

WebKitTools:

  • WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:

Fixed _paramterExpression typo. Improved support for string type as a
return value, so we don't try to include DOMString.h and we can convert
the string to a JSValue by calling JSValueMakeStringOrNull.

  • WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:

Added JSValueMakeStringOrNull, used by the code generator.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:

Added counterValueForElementById and markerTextForListItem.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

Moved constant to the top of the file.
(WTR::toCF): Added. Converts strings to CFStringRef.
(WTR::toWK): Added. Converts strings to WKStringRef.
(WTR::toJS): Added. Converts strings to JSStringRef.
(WTR::setProperty): Moved this function to the top of the file
rather than having it down where it's used inside the class. Also
renamed it so it's a separate function rather than an overload of
JSObjectSetProperty.
(WTR::propertyValue): Copied this here from InjectedBundlePage.cpp.
Should move it somewhere we can share it.
(WTR::propertyObject): Ditto.
(WTR::getElementById): Added. Calls getElementById through the magic
of JavaScript.
(WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
Chagned to use toWK instead of four local variables.
(WTR::LayoutTestController::counterValueForElementById): Added.
Calls WKBundleFrameCopyCounterValue.
(WTR::LayoutTestController::markerTextForListItem): Added.
Calls WKBundleFrameCopyMarkerText.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

Added counterValueForElementById and markerTextForListItem.

LayoutTests:

  • platform/mac-wk2/Skipped: Removed tests that were failing due to one of the above.
5:21 PM Changeset in webkit [64095] by Simon Fraser
  • 3 edits
    2 adds in trunk

2010-07-26 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Google image search results broken on pages with Flash
​https://bugs.webkit.org/show_bug.cgi?id=43014

The test for overflow added in r63452 is wrong in that it ignores the effects
of positioning on overflow.

The correct approach is to start by using RenderView's layoutOverflowRect as the largest bounds,
then getting the oveflow rect via backgroundClipRect() relative to the root layer.

Test: compositing/geometry/limit-layer-bounds-overflow-root.html

  • rendering/RenderLayerBacking.cpp: (WebCore::layerOrAncestorIsTransformed): (WebCore::RenderLayerBacking::updateCompositedBounds):
5:19 PM Changeset in webkit [64094] by crogers@google.com
  • 1 edit in branches/audio/WebCore/DerivedSources.make

Get rid of AudioMixer and AudioMixerNode in derived sources

5:09 PM Changeset in webkit [64093] by andersca@apple.com
  • 11 edits in trunk/WebCore

Plug-in views should be able to return JSObjects directly
​https://bugs.webkit.org/show_bug.cgi?id=43019

Reviewed by Sam Weinig.

  • bindings/js/JSHTMLAppletElementCustom.cpp:

(WebCore::JSHTMLAppletElement::putDelegate):
(WebCore::JSHTMLAppletElement::getCallData):

  • bindings/js/JSHTMLEmbedElementCustom.cpp:

(WebCore::JSHTMLEmbedElement::putDelegate):
(WebCore::JSHTMLEmbedElement::getCallData):

  • bindings/js/JSHTMLObjectElementCustom.cpp:

(WebCore::JSHTMLObjectElement::putDelegate):
(WebCore::JSHTMLObjectElement::getCallData):
runtimeObjectCustomPut and runtimeObjectGetCallData now take a JSHTMLElement instead of a HTMLElement.

  • bindings/js/JSPluginElementFunctions.cpp:

(WebCore::pluginScriptObject):
First, ask the PluginViewBase for a JSObject and fall back to getting the JSObject from the instance.

(WebCore::runtimeObjectPropertyGetter):
(WebCore::runtimeObjectCustomGetOwnPropertySlot):
(WebCore::runtimeObjectCustomGetOwnPropertyDescriptor):
Call pluginScriptObject.

(WebCore::runtimeObjectCustomPut):
Change to take a JSHTMLElement. Call pluginScriptObject.

(WebCore::runtimeObjectGetCallData):
Change to take a JSHTMLElement.

  • bridge/jsc/BridgeJSC.cpp:
  • bridge/jsc/BridgeJSC.h:

(JSC::Bindings::Instance::createRuntimeObject):
Change this to return a JSObject.

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::getInstance):
Call pluginWidget.

(WebCore::HTMLPlugInElement::pluginWidget):
Return the plug-in widget for this element.

  • html/HTMLPlugInElement.h:
  • plugins/PluginViewBase.h:

(WebCore::PluginViewBase::scriptObject):
Add default implementation of scriptObject.

5:01 PM Changeset in webkit [64092] by commit-queue@webkit.org
  • 4 edits
    1 copy
    1 add in trunk/WebKit/chromium

2010-07-26 Dominic Mazzoni <​dmazzoni@google.com>

Reviewed by Chris Fleizach.

Add accessor to get the doctype of a WebDocument, needed to
implement Windows accessibility.

​https://bugs.webkit.org/show_bug.cgi?id=43003

  • WebKit.gyp:
  • public/WebDocument.h:
  • public/WebDocumentType.h: Added. (WebKit::WebDocumentType::WebDocumentType): (WebKit::WebDocumentType::operator=): (WebKit::WebDocumentType::assign):
  • src/WebDocument.cpp: (WebKit::WebDocument::doctype):
  • src/WebDocumentType.cpp: Added. (WebKit::WebDocumentType::name): (WebKit::WebDocumentType::WebDocumentType): (WebKit::WebDocumentType::operator=): (WebKit::WebDocumentType::operator PassRefPtr<DocumentType>):
5:00 PM Changeset in webkit [64091] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Part 2 of ​https://bugs.webkit.org/show_bug.cgi?id=43013
<rdar://problem/8152434>
Add support for scrolling using the keyboard in WebKit2

Reviewed by Anders Carlsson.

Add support for scrolling with the space bar and ensure that we don't scroll
if WebCore is handling the event in another way.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::keyEvent):
(WebKit::getScrollMapping):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

  • WebProcess/WebPage/WebPage.h:
4:54 PM Changeset in webkit [64090] by crogers@google.com
  • 5 edits in branches/audio/WebCore/audio

Get rid of explicit ownership (part 2)

  • now that it is unused/ignored, completely get rid of optional "owner" argument in AudioContext create methods
4:54 PM Changeset in webkit [64089] by crogers@google.com
  • 5 edits
    6 deletes in branches/audio/WebCore

Remove obsolete AudioMixerNode and AudioMixerInputNode classes

  • they have been replaced with AudioGainNode and unity-gain summing junctions in AudioNodeInput
4:33 PM Changeset in webkit [64088] by Chris Fleizach
  • 7 edits
    2 adds in trunk

AX: Safari does not support ARIA mixed checkboxes
​https://bugs.webkit.org/show_bug.cgi?id=43016

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/accessibility/mixed-checkbox.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::checkboxOrRadioValue):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
(WebCore::AccessibilityRenderObject::checkboxOrRadioValue):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

  • platform/mac/accessibility/mixed-checkbox-expected.txt: Added.
  • platform/mac/accessibility/mixed-checkbox.html: Added.
4:11 PM Changeset in webkit [64087] by commit-queue@webkit.org
  • 2 edits
    6 adds in trunk

2010-07-26 Shimeng (Simon) Wang <​swang@google.com>

Reviewed by Darin Adler.

Add android specific expected test results for auto hyphenation
tests.

  • platform/android: Added.
  • platform/android/fast: Added.
  • platform/android/fast/text: Added.
  • platform/android/fast/text/hyphenate-character-expected.txt: Added.
  • platform/android/fast/text/hyphens-expected.txt: Added.

2010-07-26 Shimeng (Simon) Wang <​swang@google.com>

Reviewed by Darin Adler.

Add auto hyphenation support for Android.
​https://bugs.webkit.org/show_bug.cgi?id=42800

  • platform/text/android/HyphenationAndroid.cpp: Added. (WebCore::loadHyphenationDictionary): (WebCore::lastHyphenLocation):
4:06 PM Changeset in webkit [64086] by weinig@apple.com
  • 6 edits in trunk

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=43013
Part of <rdar://problem/8152434>
Add support for scrolling using the keyboard in WebKit2

Reviewed by Anders Carlsson.

WebCore:

Add a new export and make WindowsKeyboardCodes private.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:

WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::getScrollMapping):
(WebKit::WebPage::keyEvent):
Scroll the page in response to keyDown.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/WebPageMac.mm:

Use WindowsKeyboardCodes.h instead of redefining the constants.

3:58 PM Changeset in webkit [64085] by Darin Adler
  • 18 edits in trunk

2010-07-26 Darin Adler <Darin Adler>

Reviewed by Eric Carlson.

Don't handle empty URL attributes specially in reflection, even in cases such as <img src="">
​https://bugs.webkit.org/show_bug.cgi?id=42087

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::insertedIntoDocument): Check if the src attribute is empty by calling getAttribute instead of calling the src function. This keeps the behavior correct with the reflection change, and has a side benefit of being more efficient as well since there is no reason to resolve the URL. (WebCore::HTMLMediaElement::loadResource): Call getNonEmptyURLAttribute directly here instead of using the poster function. (WebCore::HTMLMediaElement::getPluginProxyParams): Ditto.
  • html/HTMLMediaElement.h: Removed the poster virtual function. The code that gets the poster attribute is already video-specific and uses generic attribute fetching code, so we no longer need a virtual function. Removed the src function. Since this would give a different result from the JavaScript reflected src attribute, it's safer not to have it, and it was easy to convert all the callers.
  • html/HTMLMediaElement.idl: Removed the NonEmpty extended attribute from the src attribute.
  • html/HTMLSourceElement.cpp: Removed the src function for the same reason as above.
  • html/HTMLSourceElement.h: Ditto.
  • html/HTMLSourceElement.idl: Removed the NonEmpty extended attribute from the src attribute.
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::parseMappedAttribute): Removed code to update m_posterURL, which is no longer needed. Changed call site that used the poster() function to instead use getNonEmptyURLAttribute. (WebCore::HTMLVideoElement::updatePosterImage): Check if the poster attribute is empty by calling getAttribute instead of calling the poster function. This keeps the behavior correct with the reflection change, and has a side benefit of being more efficient as well since there is no reason to resolve the URL.
  • html/HTMLVideoElement.h: Removed the poster function for the same reason we removed the src function above. Also removed now-unneeded m_posterURL data member.
  • html/HTMLVideoElement.idl: Removed the NonEmpty extended attribute from the poster attribute.

2010-07-26 Darin Adler <Darin Adler>

Reviewed by Eric Carlson.

Don’t handle empty URL attributes specially in reflection, even in cases such as <img src="">
​https://bugs.webkit.org/show_bug.cgi?id=42087

  • fast/dom/URL-attribute-reflection-expected.txt: Updated.
  • fast/dom/script-tests/URL-attribute-reflection.js: Updated test expectations so that even for URLs where "" is invalid, we reflect the empty string resolved to the base URL.
  • media/video-poster-expected.txt: Updated.
  • media/video-poster.html: Updated to expect poster="" to reflect as the base URL.
  • media/video-source-error-no-candidate-expected.txt: Updated.
  • media/video-src-none-expected.txt: Updated.
  • media/video-src-none.html: Updated to expect src="" to reflect as the base URL.
3:49 PM Changeset in webkit [64084] by Chris Fleizach
  • 6 edits in trunk/WebCore

AX: remove intValue() hasIntValue() from AccessibilityObject
​https://bugs.webkit.org/show_bug.cgi?id=43006

Reviewed by Darin Adler.

These methods are very Mac centric. The mac centric code should be moved into the Mac wrapper.

No new tests, existing tests cover changes to logic.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::checkboxOrRadioValue):

  • accessibility/AccessibilityObject.h:

(WebCore::):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::selectedRadioButton):
(WebCore::AccessibilityRenderObject::selectedTabItem):
(WebCore::AccessibilityRenderObject::checkboxOrRadioValue):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

3:47 PM Changeset in webkit [64083] by rniwa@webkit.org
  • 7 edits
    2 adds in trunk

Applying inline style to a text node whose parent is an inline editable root causes crash
​https://bugs.webkit.org/show_bug.cgi?id=39989

Reviewed by Darin Adler.

WebCore:

The crash was caused by splitTextElementAtStart and splitTextElementAtEnd assuming that the parent
and the grandparent of the specified text node is editable.

Modified splitTextElementAtStart and splitTextElementAtEnd so that they call splitTextAtStart
and splitTextAtEnd respectively when the grandparent is not editable.

Also modified SplitTextNodeContainingElement to exit early if the grandparent of m_text is not editable.

Test: editing/style/style-text-node-without-editable-parent.html

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::splitTextElementAtStart):
(WebCore::ApplyStyleCommand::splitTextElementAtEnd):

  • editing/SplitTextNodeContainingElementCommand.cpp:

(WebCore::SplitTextNodeContainingElementCommand::doApply):

LayoutTests:

Added a test to apply inline styles to a text node which is a editable root's child.
The test should not crash.

Two tests require rebaseline for the editing delegates. However, the final selection is kept same.

  • editing/execCommand/hilitecolor-expected.txt:
  • editing/style/remove-underline-from-stylesheet-expected.txt:
  • editing/style/style-text-node-without-editable-parent-expected.txt: Added.
  • editing/style/style-text-node-without-editable-parent.html: Added.
  • resources/dump-as-markup.js:
3:34 PM Changeset in webkit [64082] by Martin Robinson
  • 6 edits
    9 adds
    1 delete in trunk

2010-07-26 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] The EventSender should support simulating drop events
​https://bugs.webkit.org/show_bug.cgi?id=39844

Unskip tests that are now passing and add baselines for new tests. Re-organize
remaining failures so they can be unskipped more easily in the future.

  • platform/gtk/Skipped:
  • platform/gtk/editing/pasteboard/dataTransfer-setData-getData-expected.txt: Added.
  • platform/gtk/editing/pasteboard/drag-drop-dead-frame-expected.txt: Added.
  • platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt: Added.
  • platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt: Added.
  • platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt: Added.
  • platform/gtk/editing/selection/drag-select-1-expected.txt: Added.
  • platform/gtk/editing/selection/drag-text-delay-expected.txt: Added.
  • platform/gtk/fast/events/bogus-dropEffect-effectAllowed-expected.txt: Removed.
  • platform/gtk/fast/forms/input-text-drag-down-expected.txt: Added.
  • platform/gtk/fast/lists/drag-into-marker-expected.txt: Added.

2010-07-26 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] The EventSender should support simulating drop events
​https://bugs.webkit.org/show_bug.cgi?id=39844

Add initial dropping support to the GTK+ EventSender.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (createWebView): Listen for some new drag-and-drop signals.
  • DumpRenderTree/gtk/EventSender.cpp: Add currentDragSourceContext. (dispatchEvent): Detect situations where a drag is either starting or ending and massage GTK+ into sending the appropriate signals to the WebView. (replaySavedEvents): Remove comment. (makeEventSender): Clear the currentDragSourceContext when creating a new EventSender. (dragBeginCallback): Capture the new currentDragSourceContext when a drag begins. (dragEndCallback): Clear the currentDragSourceContext when a drag ends. (dragFailedCallback): Disable the GTK+ drag failed animation.
  • DumpRenderTree/gtk/EventSender.h: Add declarations for new signal callbacks.
3:23 PM Changeset in webkit [64081] by victorw@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-26 Victor Wang <​victorw@chromium.org>

Unreviewed. Update chromium test expectations for flaky test on linux:
tables/mozilla_expected_failures/bugs/bug89315.html

  • platform/chromium/test_expectations.txt:
3:11 PM Changeset in webkit [64080] by Simon Fraser
  • 1 edit
    6 deletes in trunk/LayoutTests

2010-07-26 Simon Fraser <Simon Fraser>

Fix tests on Leopard.

No need for these Leopard-specific results any more.

  • platform/mac-leopard/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Removed.
  • platform/mac-leopard/compositing/iframes/connect-compositing-iframe3-expected.txt: Removed.
  • platform/mac-leopard/compositing/iframes/iframe-resize-expected.txt: Removed.
  • platform/mac-leopard/compositing/iframes/iframe-size-from-zero-expected.txt: Removed.
  • platform/mac-leopard/compositing/iframes/overlapped-iframe-expected.txt: Removed.
  • platform/mac-leopard/compositing/iframes/scrolling-iframe-expected.txt: Removed.
3:03 PM Changeset in webkit [64079] by adachan@apple.com
  • 2 edits in trunk/WebKit2

Fix Windows build.

  • win/WebKit2Generated.make:
2:41 PM Changeset in webkit [64078] by Simon Fraser
  • 3 edits
    5 adds in trunk

2010-07-26 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Gmail compose is upside-down after r64054
​https://bugs.webkit.org/show_bug.cgi?id=43000

We need to call setGeometryOrientation() whenever the iframe compositing layer attachment changes,
not just when requiresScrollLayer() returns false. This ensures that the orientation is updated
correctly.

Test: compositing/iframes/iframe-content-flipping.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
2:36 PM Changeset in webkit [64077] by jschuh@chromium.org
  • 3 edits
    5 adds in trunk

2010-07-26 Justin Schuh <​jschuh@chromium.org>

Reviewed by Darin Fisher.

Check history state against origin before setting
​https://bugs.webkit.org/show_bug.cgi?id=42858

Tests: fast/loader/stateobjects/replacestate-base-illegal.html

fast/loader/stateobjects/replacestate-base-legal.html

  • page/History.cpp: (WebCore::History::urlForState): (WebCore::History::stateObjectAdded):

2010-07-26 Justin Schuh <​jschuh@chromium.org>

Reviewed by Darin Fisher.

Check history state when base URL is changed
​https://bugs.webkit.org/show_bug.cgi?id=42858

  • fast/loader/stateobjects/replacestate-base-illegal-expected.txt: Added.
  • fast/loader/stateobjects/replacestate-base-illegal.html: Added.
  • fast/loader/stateobjects/replacestate-base-legal-expected.txt: Added.
  • fast/loader/stateobjects/replacestate-base-legal.html: Added.
  • fast/loader/stateobjects/resources/replacestate-base-pass.html: Added.
2:33 PM Changeset in webkit [64076] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix Windows build.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):

2:32 PM Changeset in webkit [64075] by Martin Robinson
  • 4 edits in trunk

2010-07-26 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Get rid of libgdom
​https://bugs.webkit.org/show_bug.cgi?id=42378

Remove the need to build the libgdom intermediate library.

  • GNUmakefile.am: Move the source list for the GObject DOM bindings to the top-level GNUmakefile.am, since they are logically part of WebKit, instead of WebCore. List all auto-generated files statically and remove no-longer- used variables. Fix an issue where some places expected webkitenumtypes.cpp to be generated in different directories.

2010-07-26 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Get rid of libgdom
​https://bugs.webkit.org/show_bug.cgi?id=42378

Remove all build steps for building GObject DOM bindings.

  • GNUmakefile.am: Remove GObject DOM bindings build.
2:28 PM WikiStart edited by rniwa@webkit.org
Added a link "Writing DumpAsMarkup Tests" page to "WikiStart" (diff)
2:26 PM Writing DumpAsMarkup Tests created by rniwa@webkit.org
Added "Writing DumpAsMarkup Tests" page
2:20 PM Changeset in webkit [64074] by mrowe@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

Disable a test that was added to verify the vendor prefix change that I rolled out in r64071.
It can be reenabled when the vendor prefix change is reintroduced in a more limited fashion.

  • fast/css/limited-vendor-prefix-behavior.html-disabled: Renamed from LayoutTests/fast/css/limited-vendor-prefix-behavior.html.
2:15 PM Changeset in webkit [64073] by andersca@apple.com
  • 7 edits in trunk/WebKit2

Handle mouseenter/mouseleave + focus events
​https://bugs.webkit.org/show_bug.cgi?id=42997

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::handleMouseEnterEvent):
Call platformHandleMouseEnterEvent.

(WebKit::NetscapePlugin::handleMouseLeaveEvent):
Call platformHandleMouseExitEvent.

(WebKit::NetscapePlugin::setFocus):
Call platformSetFocus.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::fillInCocoaEventFromMouseEvent):
Factor out code that fills in an NPCocoaEvent from a WebMouseEvent.

(WebKit::initializeMouseEvent):
Call fillInCocoaEventFromMouseEvent.

(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
Send an NPCocoaEventMouseEntered event.

(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
Send an NPCocoaEventMouseExited event.

(WebKit::NetscapePlugin::platformSetFocus):
Send an NPCocoaEventFocusChanged.

  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::handleEvent):
Dispatch mouse enter and mouse leave events. Call focusPluginElement on mousedown.

(WebKit::PluginView::focusPluginElement):
Focus the plug-in's containing frame and its element.

(WebKit::PluginView::setFocus):
Call Plugin::setFocus.

1:58 PM Changeset in webkit [64072] by dbates@webkit.org
  • 2 edits in trunk/WebKitTools

2010-07-26 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

svn-unapply warns of uninitialized variable when unapplying
a patch that describes an svn move operation
​https://bugs.webkit.org/show_bug.cgi?id=42036

Fixes Perl uninitialized variable warnings when un-applying
a patch that moves a file.

  • Scripts/svn-unapply:
    • Modified patch() so that it initializes $patch to the empty string when we don't have svnConvertedText (such as when reversing a diff that represents a svn copy/move operation).
1:53 PM Changeset in webkit [64071] by mrowe@apple.com
  • 2 edits in trunk/WebCore

<​http://webkit.org/b/42990> REGRESSION (r63854): Safari RSS layout is broken due to changes in vendor prefix handling

Reviewed by Dan Bernstein.

In r63854 support for properties with the -khtml vendor prefix was removed. This breaks the layout of
Safari's RSS interface, several Dashboard widgets that are included with Mac OS X, and at least one
popular third-party Mac OS X application. This change will need to be revisited in a manner that has
a clearer backwards-compatibility strategy. <​http://webkit.org/b/42093> will be reopened to track that.

  • css/CSSParser.cpp:

(WebCore::cssPropertyID): Revert the WebCore change from r63854.

1:37 PM Changeset in webkit [64070] by beidson@apple.com
  • 13 edits in trunk

2010-07-26 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig.

Add ability for WK2 to register a scheme to always be displayed as an empty document
​https://bugs.webkit.org/show_bug.cgi?id=42995

No new tests. (Currently not possible to test in WebKit1 DRT, can be testing in future WK2 tester)

  • WebCore.exp.in:


  • loader/MainResourceLoader.cpp: (WebCore::shouldLoadAsEmptyDocument):


  • platform/SchemeRegistry.cpp: (WebCore::emptyDocumentSchemes): (WebCore::SchemeRegistry::registerURLSchemeAsEmptyDocument): (WebCore::SchemeRegistry::shouldLoadURLSchemeAsEmptyDocument):
  • platform/SchemeRegistry.h:

2010-07-26 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig.

Add ability for WK2 to register a scheme to always be displayed as an empty document
​https://bugs.webkit.org/show_bug.cgi?id=42995

  • Shared/CoreIPCSupport/WebProcessMessageKinds.h: (WebProcessMessage::):


  • UIProcess/API/C/WKContext.cpp: (_WKContextRegisterURLSchemeAsEmptyDocument):
  • UIProcess/API/C/WKContextPrivate.h:


  • UIProcess/WebContext.cpp: (WebKit::WebContext::registerURLSchemeAsEmptyDocument):
  • UIProcess/WebContext.h:


  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::registerURLSchemeAsEmptyDocument): (WebKit::WebProcess::didReceiveMessage):
  • WebProcess/WebProcess.h:
1:16 PM Changeset in webkit [64069] by victorw@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-26 Simon Fraser <Simon Fraser>

Fix compositing iframe tests on Leopard.

Add Leopard-specific results where geometry flipping causes a different test output.

  • platform/mac-leopard/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
  • platform/mac-leopard/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
  • platform/mac-leopard/compositing/iframes/iframe-resize-expected.txt: Added.
  • platform/mac-leopard/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
  • platform/mac-leopard/compositing/iframes/overlapped-iframe-expected.txt: Added.
  • platform/mac-leopard/compositing/iframes/scrolling-iframe-expected.txt: Added.
1:16 PM Changeset in webkit [64068] by andersca@apple.com
  • 3 edits
    2 deletes in trunk/WebKit2

Get rid of the dummy plug-in.

Reviewed by Adam Roben.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Plugins/DummyPlugin.cpp: Removed.
  • WebProcess/Plugins/DummyPlugin.h: Removed.
  • win/WebKit2.vcproj:
1:09 PM Changeset in webkit [64067] by weinig@apple.com
  • 10 edits
    2 copies in trunk

Move some non-APIish functions into private headers.

Reviewed by Anders Carlsson.

WebKit2:

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundle.h:
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h: Copied from WebProcess/InjectedBundle/API/c/WKBundleFrame.h.
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Copied from WebProcess/InjectedBundle/API/c/WKBundle.h.
  • win/WebKit2.vcproj:

WebKitTools:

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
12:57 PM Changeset in webkit [64066] by Simon Fraser
  • 1 edit
    6 adds in trunk/LayoutTests

2010-07-26 Simon Fraser <Simon Fraser>

Fix compositing iframe tests on Leopard.

Add Leopard-specific results where geometry flipping causes a different test output.

  • platform/mac-leopard/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
  • platform/mac-leopard/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
  • platform/mac-leopard/compositing/iframes/iframe-resize-expected.txt: Added.
  • platform/mac-leopard/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
  • platform/mac-leopard/compositing/iframes/overlapped-iframe-expected.txt: Added.
  • platform/mac-leopard/compositing/iframes/scrolling-iframe-expected.txt: Added.
12:57 PM Changeset in webkit [64065] by weinig@apple.com
  • 12 edits in trunk

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=42986
Add prompt and confirm client functions to WebKit2

Reviewed by Anders Carlsson.

WebKit2:

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:

(WebPageProxyMessage::):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveSyncMessage):
(WebKit::WebPageProxy::runJavaScriptAlert):
(WebKit::WebPageProxy::runJavaScriptConfirm):
(WebKit::WebPageProxy::runJavaScriptPrompt):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::runJavaScriptAlert):
(WebKit::WebUIClient::runJavaScriptConfirm):
(WebKit::WebUIClient::runJavaScriptPrompt):

  • UIProcess/WebUIClient.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

12:48 PM Changeset in webkit [64064] by crogers@google.com
  • 20 edits in branches/audio

Get rid of explicit ownership (part 1)

  • implement the complex type of ref-counting necessary to deal with nodes which keep playing without JS references
  • AudioNodeInput now keeps track of "active" connections, as well as disabled connections
  • still need to address some thread safety issues, but code generally runs well
  • still need to get rid of "owner" argument (since it's now totally ignored)
12:41 PM Changeset in webkit [64063] by andersca@apple.com
  • 13 edits
    1 add
    1 delete in trunk/WebKit2

Deliver mouse and wheel events to plug-ins
​https://bugs.webkit.org/show_bug.cgi?id=42988

Reviewed by Sam Weinig.

  • Shared/WebEvent.h:

(WebKit::WebMouseEvent::WebMouseEvent):
(WebKit::WebMouseEvent::deltaX):
(WebKit::WebMouseEvent::deltaY):
(WebKit::WebMouseEvent::deltaZ):

  • Shared/mac/WebEventFactory.mm:

(WebKit::WebEventFactory::createWebMouseEvent):
Add deltaX, deltaY and deltaZ member variables to WebMosueEvent.

  • WebKit2.xcodeproj/project.pbxproj:

Rename NetscapePluginMac.cpp to NetscapePluginMac.mm.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NPP_HandleEvent):
Add NPP_ wrapper.

(WebKit::NetscapePlugin::handleMouseEvent):
(WebKit::NetscapePlugin::handleWheelEvent):
Call the platform variants.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: Added.

(WebKit::modifierFlags):
(WebKit::buttonNumber):
(WebKit::initializeMouseEvent):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
Create an NPCocoaEvent and send it to the plug-in.

(WebKit::NetscapePlugin::platformHandleWheelEvent):
Ditto.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::handleEvent):
Get the current WebEvent and send it to the plug-in if necessary.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::currentEvent):
(WebKit::CurrentEvent::CurrentEvent):
(WebKit::CurrentEvent::~CurrentEvent):
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::wheelEvent):
(WebKit::WebPage::keyEvent):

  • WebProcess/WebPage/WebPage.h:

Add RAII object for keeping track of the current event.

12:30 PM Changeset in webkit [64062] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-26 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Kent Tamura.

[WINCE] Port ClipboardUtilities to WinCE
​https://bugs.webkit.org/show_bug.cgi?id=42929

Make ClipboardUtilitiesWin more portable and remove the global namespace prefix
from GlobalLock/GlobalUnlock, since they are only macros on WinCE.

  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::urlFromPath): (WebCore::getWebLocData): (WebCore::createGlobalData): (WebCore::getURL): (WebCore::getPlainText): (WebCore::fragmentFromHTML):
12:22 PM Changeset in webkit [64061] by victorw@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-26 Victor Wang <​victorw@chromium.org>

Unreviewed. Update chromium test expectations fro flaky test.

​https://bugs.webkit.org/show_bug.cgi?id=42989

  • platform/chromium/test_expectations.txt:
12:10 PM Changeset in webkit [64060] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-26 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Buildfix for BitmapImage.h
​https://bugs.webkit.org/show_bug.cgi?id=42931

Use AffineTransform insted of TransformationMatrix.

  • platform/graphics/BitmapImage.h:
11:57 AM Changeset in webkit [64059] by Adam Roben
  • 6 edits in trunk

Windows build fix

WebKit2:

  • win/WebKit2.vcproj:
  • win/WebKit2WebProcess.vcproj:

Removed empty attributes so the values will be picked up from the
vsprops files. (Also removed a couple of attributes that accidentally
duplicated values from the vsprops files.)

WebKitTools:

  • MiniBrowser/MiniBrowser.vcproj:
  • WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:

Removed empty attributes so the values will be picked up from the
vsprops files. (Also removed a couple of attributes that accidentally
duplicated values from the vsprops files.)

11:41 AM Changeset in webkit [64058] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-07-26 Dirk Schulze <​krit@webkit.org>

Unreviewed sort of XCode project file.

  • WebCore.xcodeproj/project.pbxproj:
11:32 AM Changeset in webkit [64057] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

<​http://webkit.org/b/42982> Streamline Inspector Source build phase script should use CONFIGURATION not BUILD_STYLE
<rdar://problem/6341764>

Reviewed by Mark Rowe.

  • WebCore.xcodeproj/project.pbxproj: Switched Streamline

Inspector Source build phase script to use CONFIGURATION instead
of BUILD_STYLE.

11:28 AM Changeset in webkit [64056] by ojan@chromium.org
  • 3 edits
    2 adds in trunk

2010-07-23 Ojan Vafai <​ojan@chromium.org>

Reviewed by Darin Adler.

crash in insertParagraph in a contentEditable list
​https://bugs.webkit.org/show_bug.cgi?id=42919

  • editing/execCommand/crash-on-enter-in-contentEditable-list-expected.txt: Added.
  • editing/execCommand/crash-on-enter-in-contentEditable-list.html: Added.

2010-07-23 Ojan Vafai <​ojan@chromium.org>

Reviewed by Darin Adler.

crash in insertParagraph in a contentEditable list
​https://bugs.webkit.org/show_bug.cgi?id=42919

Don't try to break out of a list item if the list it's in
is the rootEditableElement.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
11:15 AM Changeset in webkit [64055] by bulach@chromium.org
  • 7 edits in trunk/WebCore

2010-07-26 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Moves IDBKeyRange to use IDBKey rather than SerializedScriptValue / IDBAny.
​https://bugs.webkit.org/show_bug.cgi?id=42583

Tests: existing storage/indexeddb/idb-keyrange.html must pass.

  • storage/IDBKeyRange.cpp: (WebCore::IDBKeyRange::IDBKeyRange):
  • storage/IDBKeyRange.h: (WebCore::IDBKeyRange::create): (WebCore::IDBKeyRange::left): (WebCore::IDBKeyRange::right):
  • storage/IDBKeyRange.idl:
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::makeSingleKeyRange): (WebCore::IndexedDatabaseRequest::makeLeftBoundKeyRange): (WebCore::IndexedDatabaseRequest::makeRightBoundKeyRange): (WebCore::IndexedDatabaseRequest::makeBoundKeyRange):
  • storage/IndexedDatabaseRequest.h:
  • storage/IndexedDatabaseRequest.idl:
10:48 AM Changeset in webkit [64054] by Simon Fraser
  • 8 edits in trunk

2010-07-26 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Composited layers don't scroll in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=42771

Rename two methods on RenderLayerCompositor to make their use more clear, and call them
when the FrameView gets resized and scrolled.

  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameView::setFrameRect): override so we know when the size of the FrameView changes, so that the RenderLayerCompositor can update its clipping layer. (WebCore::FrameView::scrollPositionChanged): Call compositor()->frameViewDidScroll().
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterWidgetResize): updateContentLayerOffset() was renamed.
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::frameViewDidChangeSize): Renamed from updateContentLayerOffset(). (WebCore::RenderLayerCompositor::frameViewDidScroll): Renamed from updateContentLayerScrollPosition(). (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame): Propagate compositing on Mac for any FrameView that doesn't have a native widget, which is the case with WebKit2. (WebCore::RenderLayerCompositor::requiresScrollLayer): New method to tell us whether we need to handle scrolling (and clipping) ourselves. (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Do geometry flipping on the root platform layer only if we're not doing our own scrolling, and use the new requiresScrollLayer() method. (WebCore::RenderLayerCompositor::attachRootPlatformLayer): Send out the rootPlatformLayer(), so that it returns the clipping layer if we have one.
10:37 AM Changeset in webkit [64053] by jorlow@chromium.org
  • 2 edits
    12 moves in trunk/LayoutTests

2010-07-26 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Ojan Vafai.

Rename indexedDB tests to match new scheme
​https://bugs.webkit.org/show_bug.cgi?id=42375

No changes to the tests themselves.

  • storage/indexeddb/script-tests/basics.js: Added. (openCallback): (test):
  • storage/indexeddb/script-tests/database-basics.js: Added. (openSuccess): (test):
  • storage/indexeddb/script-tests/idb-database-request.js: Removed.
  • storage/indexeddb/script-tests/idb-objectstore-request.js: Removed.
  • storage/indexeddb/script-tests/indexed-database-request.js: Removed.
  • storage/indexeddb/script-tests/keyrange.js: Renamed from LayoutTests/storage/indexeddb/script-tests/idb-keyrange.js. (checkSingleKeyRange): (checkLeftBoundKeyRange): ():
  • storage/indexeddb/script-tests/objectstore-basics.js: Added. (test): (openSuccess): (createSuccess): (addSuccess): (getSuccess): (removeSuccess):
10:19 AM WebKit Team edited by Simon Fraser
(diff)
10:11 AM Changeset in webkit [64052] by bweinstein@apple.com
  • 2 edits in trunk/WebKitTools

Touch MiniBrowser's stdafx to fix the build.

Rubber-stamped by Adam Roben.

  • MiniBrowser/win/stdafx.h:
10:03 AM Changeset in webkit [64051] by tonyg@chromium.org
  • 10 edits
    1 add in trunk/WebCore

2010-07-26 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Darin Fisher.

Move DocumentLoadTiming struct to a new file
​https://bugs.webkit.org/show_bug.cgi?id=42917

Also makes DocumentLoadTiming Noncopyable.

No new tests because no new functionality.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/DocumentLoadTiming.h: Added. (WebCore::DocumentLoadTiming::DocumentLoadTiming):
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp:
  • loader/FrameLoaderTypes.h:
  • loader/MainResourceLoader.cpp:
  • page/Timing.cpp:
10:03 AM Changeset in webkit [64050] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Clean up event handling functions
​https://bugs.webkit.org/show_bug.cgi?id=42977

Reviewed by Sam Weinig.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::wheelEvent):
(WebKit::WebPage::keyEvent):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h:
9:24 AM Changeset in webkit [64049] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix an #if in WebCore.exp.in to correctly detect whether SVG filters are enabled.

  • WebCore.exp.in:
9:01 AM Changeset in webkit [64048] by steveblock@google.com
  • 3 edits in trunk/WebCore

2010-07-26 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

DeviceOrientation event listeners should never be called synchronously from addEventListener()
​https://bugs.webkit.org/show_bug.cgi?id=42304

No new tests as there are currently no implementations to test. Tests will be
added once LayoutTestController methods for providing a mock implementation are
in place, see Bug 39589.

  • dom/DeviceOrientationController.cpp: (WebCore::DeviceOrientationController::DeviceOrientationController): (WebCore::DeviceOrientationController::timerFired): (WebCore::DeviceOrientationController::addListener): (WebCore::DeviceOrientationController::removeListener): (WebCore::DeviceOrientationController::removeAllListeners):
  • dom/DeviceOrientationController.h:
8:56 AM Changeset in webkit [64047] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-07-26 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Canvas: Optimize GraphicsContext::addPath()

Avoid "deep concatenating" the canvas path onto the GC path
if the GC path has no elements.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::addPath):
8:43 AM Changeset in webkit [64046] by senorblanco@chromium.org
  • 2 edits
    4 adds in trunk/WebCore

2010-07-23 Stephen White <​senorblanco@chromium.org>

Reviewed by Darin Fisher.

Implement OpenGLES2 helper classes.
​https://bugs.webkit.org/show_bug.cgi?id=42905

GLES2Canvas and GLES2Texture are some simple OpenGLES2 helper classes
for managing state, samplers and textures.

When this is hooked up, it will be covered by many layout tests.

  • WebCore.gypi: Add new files to chromium build (contents are protected by #if's for now).
  • platform/graphics/chromium/GLES2Canvas.cpp: Added. (WebCore::affineTo3x3): (WebCore::GLES2Canvas::State::State): (WebCore::GLES2Canvas::GLES2Canvas): (WebCore::GLES2Canvas::~GLES2Canvas): (WebCore::GLES2Canvas::clearRect): (WebCore::GLES2Canvas::fillRect): (WebCore::GLES2Canvas::setFillColor): (WebCore::GLES2Canvas::setAlpha): (WebCore::GLES2Canvas::translate): (WebCore::GLES2Canvas::rotate): (WebCore::GLES2Canvas::scale): (WebCore::GLES2Canvas::concatCTM): (WebCore::GLES2Canvas::save): (WebCore::GLES2Canvas::restore): (WebCore::GLES2Canvas::drawTexturedRect): (WebCore::GLES2Canvas::setCompositeOperation): (WebCore::GLES2Canvas::applyCompositeOperator): (WebCore::GLES2Canvas::getQuadVertices): (WebCore::GLES2Canvas::getQuadIndices): (WebCore::loadShader): (WebCore::GLES2Canvas::getSimpleProgram): (WebCore::GLES2Canvas::getTexProgram): (WebCore::GLES2Canvas::createTexture): (WebCore::GLES2Canvas::getTexture): (WebCore::GLES2Canvas::checkGLError):
  • platform/graphics/chromium/GLES2Canvas.h: Added. (WebCore::GLES2Canvas::gles2Context):
  • platform/graphics/chromium/GLES2Texture.cpp: Added. (WebCore::GLES2Texture::GLES2Texture): (WebCore::GLES2Texture::~GLES2Texture): (WebCore::GLES2Texture::create): (WebCore::convertFormat): (WebCore::GLES2Texture::load): (WebCore::GLES2Texture::bind):
  • platform/graphics/chromium/GLES2Texture.h: Added. (WebCore::GLES2Texture::): (WebCore::GLES2Texture::format): (WebCore::GLES2Texture::width): (WebCore::GLES2Texture::height):
7:52 AM EFLWebKit edited by antognolli@profusion.mobi
(diff)
7:49 AM Changeset in webkit [64045] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

2010-07-26 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Fix IndexedDB release build on mac
​https://bugs.webkit.org/show_bug.cgi?id=42377

  • storage/IDBDatabaseImpl.cpp: (WebCore::IDBDatabaseImpl::objectStore):
7:43 AM EFLWebKit edited by antognolli@profusion.mobi
(diff)
7:42 AM EFLWebKit edited by antognolli@profusion.mobi
(diff)
6:47 AM Changeset in webkit [64044] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/WebKitTools

2010-07-26 Hayato Ito <​hayato@chromium.org>

Reviewed by Shinichiro Hamaji.

Add pretty printer of WTF::Vector for GDB 7.

​https://bugs.webkit.org/show_bug.cgi?id=40909

  • gdb/wtf.py: Added.
5:04 AM Changeset in webkit [64043] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-26 Marcus Bulach <​bulach@chromium.org>

Unreviewed. Add chromium expectations for failing tests.

tables/mozilla/other/slashlogo.html fails after r63994
​https://bugs.webkit.org/show_bug.cgi?id=42964

Adds a suppression for chromium.

  • platform/chromium/test_expectations.txt:
4:52 AM Changeset in webkit [64042] by commit-queue@webkit.org
  • 13 edits
    3 copies
    1 add in trunk

2010-07-26 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Add WebKit plumbing to connect speech requests and callbacks between WebCore and the embedder.
​https://bugs.webkit.org/show_bug.cgi?id=42367

No new tests, the relevant LayoutTestController bindings will be added in the next patch.

  • page/SpeechInput.cpp: renamed a method.
  • page/SpeechInput.h: renamed a method.
  • page/SpeechInputClient.h: added an extra method to optionally let users stop recording once they have spoken.
  • page/SpeechInputClientListener.h: renamed a method.
  • page/SpeechInputListener.h: renamed a method.

2010-07-26 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Add WebKit plumbing to connect speech requests and callbacks between WebCore and the embedder.
​https://bugs.webkit.org/show_bug.cgi?id=42367

No new tests, the relevant LayoutTestController bindings and tests will be added in the next patch.

  • public/WebSpeechInputController.h: Added new interface, implemented by embedder and called by WebKit (WebKit::WebSpeechInputController::~WebSpeechInputController):
  • public/WebSpeechInputListener.h: Added new interface, implemented by WebKit and called by embedder. (WebKit::WebSpeechInputListener::~WebSpeechInputListener):
  • public/WebViewClient.h: (WebKit::WebViewClient::createSpeechInputClient): New method to get the embedder's speech input client interface.
  • src/SpeechInputClientImpl.cpp: Added new class, implementation of a two way connector between WebCore and the embedder for requests and responses. (WebKit::SpeechInputClientImpl::SpeechInputClientImpl): (WebKit::SpeechInputClientImpl::~SpeechInputClientImpl): (WebKit::SpeechInputClientImpl::startRecognition): (WebKit::SpeechInputClientImpl::stopRecording): (WebKit::SpeechInputClientImpl::didCompleteRecording): (WebKit::SpeechInputClientImpl::setRecognitionResult): (WebKit::SpeechInputClientImpl::didCompleteRecognition):
  • src/SpeechInputClientImpl.h: Added.
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): Pass on the above mentioned speech input connector to WebCore.
  • src/WebViewImpl.h:
4:51 AM Changeset in webkit [64041] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-07-26 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] getImageData(): Single-pass RGB->BGR and un-premultiplication
​https://bugs.webkit.org/show_bug.cgi?id=42945

Combine the two operations into a single loop over the pixel data.
Yields a considerable FPS gain on ​http://www.semantix.gr/statue.html

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData):
4:21 AM Changeset in webkit [64040] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-07-26 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Shinichiro Hamaji.

Web Inspector: make sure proxy objects are JSON-stringifiable.

​https://bugs.webkit.org/show_bug.cgi?id=42961

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
4:12 AM Changeset in webkit [64039] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

[Qt] Fix feature detection regexp

Reviewed by Simon Hausmann.

We were missing the last feature

  • Scripts/webkitdirs.pm:
2:52 AM Changeset in webkit [64038] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] DRT sideeffect revealed by r63657
​https://bugs.webkit.org/show_bug.cgi?id=42578

  • platform/qt/Skipped: Add tests to the Skipped list until fix.
    • http/tests/xmlhttprequest/authorization-header.html
    • http/tests/xmlhttprequest/null-auth.php
2:37 AM Changeset in webkit [64037] by apavlov@chromium.org
  • 3 edits in trunk/WebCore

2010-07-26 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Joseph Pecoraro.

Inspector should remember resources sorting set by the user
​https://bugs.webkit.org/show_bug.cgi?id=19208

Sorting options both for time and size graphs are memorized in a single property,
which makes them possible to retrieve in a single message (e.g. useful for remote debugging).

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.populateSidebar): (WebInspector.ResourcesPanel.prototype._settingsLoaded): (WebInspector.ResourcesPanel.prototype._loadSortOptions): (WebInspector.ResourcesPanel.prototype._loadSortOptionForGraph): (WebInspector.ResourcesPanel.prototype._graphSelected): (WebInspector.ResourcesPanel.prototype._changeSortingFunction): (WebInspector.ResourcesPanel.prototype._selectedOptionNameForGraph): (WebInspector.ResourcesPanel.prototype._doChangeSortingFunction):
  • inspector/front-end/Settings.js: (WebInspector.populateApplicationSettings):
1:53 AM Changeset in webkit [64036] by Simon Hausmann
  • 6 edits in trunk

[Qt] Use the default timeout interval for JS as the HTML tokenizer delay for setHtml()

Patch by Tor Arne Vestbø <​tor.arne.vestbo@nokia.com> on 2009-10-30
Reviewed by Kenneth Rohde Christiansen.

This ensures that long-running JavaScript (for example due to a modal alert() dialog),
will not trigger a deferred load after only 500ms (the default tokenizer delay) while
still giving a reasonable timeout (10 seconds) to prevent deadlock.

​https://bugs.webkit.org/show_bug.cgi?id=29381

JavaScriptCore:

  • runtime/TimeoutChecker.h: Add getter for the timeout interval

WebKit/qt:

  • Api/qwebframe.cpp: Document the behaviour
  • WebCoreSupport/FrameLoaderClientQt.cpp: set the custom tokenizer delay for substitute loads
  • tests/qwebframe/tst_qwebframe.cpp: Add test
1:29 AM Changeset in webkit [64035] by loislo@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-07-26 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Chromium DevTools: refactor query params, add basic
support for WebSocket-based backend.

​https://bugs.webkit.org/show_bug.cgi?id=42893

  • src/js/DevTools.js: (devtools.ToolsAgent.prototype.dispatchOnClient_): (WebInspector.loaded): (WebInspector.doLoadedDone): (devtools.domContentLoaded):
  • src/js/InspectorControllerImpl.js:
1:19 AM Changeset in webkit [64034] by rniwa@webkit.org
  • 4 edits
    4 adds in trunk

WebCore: Redo fails after text node is split by SplitTextNodeCommand
​https://bugs.webkit.org/show_bug.cgi?id=42941

Reviewed by Darin Adler.

The bug was caused by SplitTextNodeCommand not implementing doReapply.
Implemented doReapply and added insertText1AndTrimText2 to share the code between doApply and doReapply.

Test: editing/undo/redo-split-text-node.html

editing/undo/redo-split-text-node-with-removal.html

  • editing/SplitTextNodeCommand.cpp:

(WebCore::SplitTextNodeCommand::doApply): Calls executeApply.
(WebCore::SplitTextNodeCommand::doUnapply): Don't delete m_text1, which is later used in doReapply.
(WebCore::SplitTextNodeCommand::doReapply): Added.
(WebCore::SplitTextNodeCommand::insertText1AndTrimText2): Added.

  • editing/SplitTextNodeCommand.h:

LayoutTests: Added a test that splits a text node by inserting a paragraph and applies inline style.
The test then ensures that the style is preserved after undos and redos.

Reviewed by Darin Adler.

Also added a test in which the text node is removed by the script after undo.

Redo fails after text node is split by SplitTextNodeCommand
​https://bugs.webkit.org/show_bug.cgi?id=42941

  • editing/undo/redo-split-text-node-expected.txt: Added.
  • editing/undo/redo-split-text-node.html: Added.
  • editing/undo/redo-split-text-with-removal-expected.txt: Added.
  • editing/undo/redo-split-text-with-removal.html: Added.

Jul 25, 2010:

11:57 PM Changeset in webkit [64033] by Darin Adler
  • 5 edits in trunk

2010-07-25 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
​https://bugs.webkit.org/show_bug.cgi?id=42326

  • platform/mac-wk2/Skipped: Removed all the tests from the list that were there only because they called dumpSelectionRect. Most of them pass now.

2010-07-25 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
​https://bugs.webkit.org/show_bug.cgi?id=42326

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpSelectionRect.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::dumpSelectionRect): Added. For now, this does nothing because its purpose is to change pixel test output and we do not have pixel tests implemented yet.
11:40 PM Changeset in webkit [64032] by Philippe Normand
  • 4 edits in trunk

2010-07-23 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] media/media-can-play-mpeg-audio.html fails
​https://bugs.webkit.org/show_bug.cgi?id=42895

Fixed advertizing of mp3, mpeg and mp4 mime-types in the player.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):

LayoutTests:

2010-07-23 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] media/media-can-play-mpeg-audio.html fails
​https://bugs.webkit.org/show_bug.cgi?id=42895

  • platform/gtk/Skipped: Unskip fixed test.
11:35 PM Changeset in webkit [64031] by Philippe Normand
  • 4 edits in trunk

2010-07-23 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

LayoutTests/media/media-document-audio-size.html failure
​https://bugs.webkit.org/show_bug.cgi?id=38376

Advertize audio/x-wav along with audio/wav when appropriate,
otherwise WebKit attempts to use a plugin to play the media.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):

LayoutTests:

2010-07-23 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

LayoutTests/media/media-document-audio-size.html failure
​https://bugs.webkit.org/show_bug.cgi?id=38376

  • platform/gtk/Skipped: Unskip fixed test on GTK port.
11:13 PM Changeset in webkit [64030] by Darin Adler
  • 2 edits in trunk/LayoutTests

2010-07-25 Darin Adler <Darin Adler>

Reviewed by Maciej Stachowiak.

Need to support unsafe access console messages in WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=42320

  • platform/mac-wk2/Skipped: Since unsafe access console messages are working properly, moved the failing tests listed under this bug to other sections in the file based on the reason they are failing. Removed the tests that are passing.
11:03 PM Changeset in webkit [64029] by Darin Adler
  • 30 edits in trunk

2010-07-25 Darin Adler <Darin Adler>

Reviewed by Maciej Stachowiak.

WebKitTestRunner needs to support layoutTestController.keepWebHistory
​https://bugs.webkit.org/show_bug.cgi?id=42323

  • platform/mac-wk2/Skipped: Removed the tests that needed only keepWebHistory and computedStyleIncludingVisitedInfo. Moved the other tests in the keepWebHistory section of the file into the other appropriate lists.

2010-07-25 Darin Adler <Darin Adler>

Reviewed by Maciej Stachowiak.

WebKitTestRunner needs to support layoutTestController.keepWebHistory
​https://bugs.webkit.org/show_bug.cgi?id=42323

Added keepWebHistory and computedStyleIncludingVisitedInfo.

Also fixed misspellings of the word "receive".

Also tweaked the names of some of the LayoutTestController members.

  • WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added support for a type named "object" that is passed and returns as a JSValueRef.
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added keepWebHistory and computedStyleIncludingVisitedInfo. Also put setAcceptsEditing up nearer the top.
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::_didReceiveMessage): Fixed mispellings of receive. (WTR::InjectedBundle::initialize): Ditto. (WTR::InjectedBundle::didReceiveMessage): Ditto. (WTR::InjectedBundle::reset): Reset the state of visited links between tests. Also eliminated the unused argument to the LayoutTestController create function. (WTR::InjectedBundle::setShouldTrackVisitedLinks): Added.
  • WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::shouldBeginEditing): Call shouldAllowEditing instead of acceptsEditing. (WTR::InjectedBundlePage::shouldEndEditing): Ditto. (WTR::InjectedBundlePage::shouldInsertNode): Ditto. (WTR::InjectedBundlePage::shouldInsertText): Ditto. (WTR::InjectedBundlePage::shouldDeleteRange): Ditto. (WTR::InjectedBundlePage::shouldChangeSelectedRange): Ditto. (WTR::InjectedBundlePage::shouldApplyStyle): Ditto.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::create): Removed uneeded argument. (WTR::LayoutTestController::LayoutTestController): Removed unneeded argument. Updated for rename of m_acceptsEditing to m_shouldAllowEditing. (WTR::LayoutTestController::numberOfActiveAnimations): Added some FIXMEs about the fact that this works on the main frame. (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto. (WTR::LayoutTestController::keepWebHistory): Added. (WTR::LayoutTestController::computedStyleIncludingVisitedInfo): Added. (WTR::JSObjectSetProperty): Added. Helper to make the function below cleaner. (WTR::LayoutTestController::makeWindowObject): Changed to use the overload of JSObjectSetProperty above.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: Changes to match above.
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Fixed mispellings of receive. (WTR::TestController::_didReceiveMessageFromInjectedBundle): Ditto. (WTR::TestController::didReceiveMessageFromInjectedBundle): Ditto.
  • WebKitTestRunner/TestController.h: Ditto.
  • WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Ditto.
  • WebKitTestRunner/TestInvocation.h: Ditto.

2010-07-25 Darin Adler <Darin Adler>

Reviewed by Maciej Stachowiak.

WebKitTestRunner needs to support layoutTestController.keepWebHistory
​https://bugs.webkit.org/show_bug.cgi?id=42323

Added WKBundleSetShouldTrackVisitedLinks, WKBundleRemoveAllVisitedLinks,
and WKBundleFrameGetComputedStyleIncludingVisitedInfo.

Also fixed misspellings of the word "receive".

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetShouldTrackVisitedLinks): Added. (WKBundleRemoveAllVisitedLinks): Added.
  • WebProcess/InjectedBundle/API/c/WKBundle.h: Added functions and fixed mispellings of receive.
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameGetJavaScriptContext): Moved the code from here into WebFrame, to be consistent with the rest of the functions in this file. (WKBundleFrameGetComputedStyleIncludingVisitedInfo): Added.
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Added WKBundleFrameGetComputedStyleIncludingVisitedInfo and tried to rearrange the file to be more logically ordered and grouped.
  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setShouldTrackVisitedLinks): Added. (WebKit::InjectedBundle::removeAllVisitedLinks): Added. (WebKit::InjectedBundle::didReceiveMessage): Fixed mispellings of receive.
  • WebProcess/InjectedBundle/InjectedBundle.h: Ditto.
  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::jsContext): Added. Contains the code that used to be in WKBundleFrameGetJavaScriptContext. (WebKit::WebFrame::computedStyleIncludingVisitedInfo): Added.
  • WebProcess/WebPage/WebFrame.h: Ditto.
  • UIProcess/API/C/WKContext.h: Fixed misspellings of receive.
  • UIProcess/WebContext.cpp: (WebKit::WebContext::didReceiveMessageFromInjectedBundle): Ditto.
  • UIProcess/WebContext.h: Ditto.
  • UIProcess/WebContextInjectedBundleClient.cpp: (WebKit::WebContextInjectedBundleClient::didReceiveMessageFromInjectedBundle): Ditto.
  • UIProcess/WebContextInjectedBundleClient.h: Ditto.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::forwardMessageToWebContext): Ditto.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::forwardMessageToInjectedBundle): Ditto.
9:10 PM Changeset in webkit [64028] by rniwa@webkit.org
  • 3 edits in trunk/WebCore

splitTextAt*IfNeed and splitTextElementAt*IfNeed need to be cleaned up
​https://bugs.webkit.org/show_bug.cgi?id=42937

Reviewed by Kent Tamura.

Isolated the code to decide whether or not text node should be split into isValidCaretPositionInTextNode.
Moved the condition check out of *IfNeeded methods to applyRelativeFontStyleChange and applyInlineStyle.

No new tests added since this is a clean up.

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Uses isValidCaretPositionInTextNode.
(WebCore::ApplyStyleCommand::applyInlineStyle): Uses isValidCaretPositionInTextNode.
(WebCore::ApplyStyleCommand::splitTextAtStart): Renamed from splitTextAtStartIfNeeded.
(WebCore::ApplyStyleCommand::splitTextAtEnd): Renamed from splitTextAtEndIfNeeded.
(WebCore::ApplyStyleCommand::splitTextElementAtStart): Renamed from splitTextElementAtStartIfNeeded.
(WebCore::ApplyStyleCommand::splitTextElementAtEnd): Renamed from splitTextElementAtEndIfNeeded.
(WebCore::ApplyStyleCommand::isValidCaretPositionInTextNode): Returns true if the position lies within a text node.

  • editing/ApplyStyleCommand.h:
9:01 PM Changeset in webkit [64027] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-07-25 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Kent Tamura.

[WINCE] Buildfix for JSC in release mode
​https://bugs.webkit.org/show_bug.cgi?id=42934

  • jsc.cpp: Don't use try on WinCE.
8:48 PM Changeset in webkit [64026] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-25 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Kent Tamura.

[WINCE] Buildfix for ImageBufferWince
​https://bugs.webkit.org/show_bug.cgi?id=42928

  • platform/graphics/wince/ImageBufferWince.cpp: (WebCore::): (WebCore::BufferedImage::draw): Pass through ColorSpace parameter. (WebCore::BufferedImage::drawPattern): Ditto. (WebCore::ImageBuffer::platformTransformColorSpace): Added.
8:33 PM Changeset in webkit [64025] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-25 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Kent Tamura.

[WINCE] Buildfix for PopupMenuWin.cpp
​https://bugs.webkit.org/show_bug.cgi?id=42932

Add #if !OS(WINCE) around unsupported window messages.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): (WebCore::PopupMenu::wndProc):
2:51 PM Changeset in webkit [64024] by abarth@webkit.org
  • 5 edits in trunk

2010-07-25 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement adjustMathMLAttributes
​https://bugs.webkit.org/show_bug.cgi?id=42952

Yay test progression.

  • html5lib/runner-expected-html5.txt:

2010-07-25 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement adjustMathMLAttributes
​https://bugs.webkit.org/show_bug.cgi?id=42952

This is kind of mechanical overkill for adjusting one attribute name,
but it's nice to use the same machinery as SVG.

  • html/HTMLTreeBuilder.cpp:
  • mathml/mathattrs.in:
2:36 PM Changeset in webkit [64023] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-07-25 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Functions supporting the legacy tree builder are confusing
​https://bugs.webkit.org/show_bug.cgi?id=42951

This patch just inlines these functions into their one call site and
removes the notImplemented() calls. We thought we were going to grow
these to support the new tree builder, but we took a different path.
Previous to this patch, these functions were confusing because they
looked like part of the new tree builder.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::passTokenToLegacyParser):
  • html/HTMLTreeBuilder.h:
1:05 PM Changeset in webkit [64022] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-07-25 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Recent HTML5 TreeBuilder Regression? All canvas tests ASSERT
​https://bugs.webkit.org/show_bug.cgi?id=42948

Remove ASSERT and replace with correct branch. I put this ASSERT in
to make sure we had test coverage for this branch. I guess we do. :)

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach):
8:46 AM Changeset in webkit [64021] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-07-25 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: check of jQuery object type prior to treating it as an array.

​https://bugs.webkit.org/show_bug.cgi?id=42946

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
12:56 AM Changeset in webkit [64020] by ap@apple.com
  • 12 edits in trunk

2010-07-25 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=42193
Support layoutTestController.dumpEditingDelegates in WebKitTestRunner

Step 2 - add the rest of editing delegates.

  • platform/mac-wk2/Skipped: Changed the bug tracking why the tests are skipped - the delegates are now implemented, but one of them isn't called for some reason.

2010-07-25 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=42193
Support layoutTestController.dumpEditingDelegates in WebKitTestRunner

Step 2 - add the rest of editing delegates.

  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
  • WebProcess/InjectedBundle/API/c/WKBundleBase.h: Added enums for EditorInsertAction and EAffinity. Also added a dummy type for CSSStyleDeclaration - neither DumpRenderTree not WebKitTestRunner actually use that.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp: (WebKit::InjectedBundlePageEditorClient::shouldBeginEditing): (WebKit::InjectedBundlePageEditorClient::shouldEndEditing): (WebKit::InjectedBundlePageEditorClient::shouldInsertNode): (WebKit::InjectedBundlePageEditorClient::shouldInsertText): (WebKit::InjectedBundlePageEditorClient::shouldDeleteRange): (WebKit::InjectedBundlePageEditorClient::shouldChangeSelectedRange): (WebKit::InjectedBundlePageEditorClient::shouldApplyStyle): (WebKit::InjectedBundlePageEditorClient::didBeginEditing): (WebKit::InjectedBundlePageEditorClient::didEndEditing): (WebKit::InjectedBundlePageEditorClient::didChange): (WebKit::InjectedBundlePageEditorClient::didChangeSelection):
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::shouldDeleteRange): (WebKit::WebEditorClient::shouldEndEditing): (WebKit::WebEditorClient::shouldInsertNode): (WebKit::WebEditorClient::shouldInsertText): (WebKit::WebEditorClient::shouldChangeSelectedRange): (WebKit::WebEditorClient::shouldApplyStyle): (WebKit::WebEditorClient::didBeginEditing): (WebKit::WebEditorClient::respondToChangedContents): (WebKit::WebEditorClient::respondToChangedSelection): (WebKit::WebEditorClient::didEndEditing): Added remaining delagates that are needed for WebKitTestRunner.

2010-07-25 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=42193
Support layoutTestController.dumpEditingDelegates in WebKitTestRunner

Step 2 - add the rest of editing delegates.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::operator<<): Fixed to not crash when range is null. (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::_shouldEndEditing): (WTR::InjectedBundlePage::_shouldInsertNode): (WTR::InjectedBundlePage::_shouldInsertText): (WTR::InjectedBundlePage::_shouldDeleteRange): (WTR::InjectedBundlePage::_shouldChangeSelectedRange): (WTR::InjectedBundlePage::_shouldApplyStyle): (WTR::InjectedBundlePage::_didBeginEditing): (WTR::InjectedBundlePage::_didEndEditing): (WTR::InjectedBundlePage::_didChange): (WTR::InjectedBundlePage::_didChangeSelection): (WTR::InjectedBundlePage::shouldEndEditing): (WTR::InjectedBundlePage::shouldInsertNode): (WTR::InjectedBundlePage::shouldInsertText): (WTR::InjectedBundlePage::shouldDeleteRange): (WTR::InjectedBundlePage::shouldChangeSelectedRange): (WTR::InjectedBundlePage::shouldApplyStyle): (WTR::InjectedBundlePage::didBeginEditing): (WTR::InjectedBundlePage::didEndEditing): (WTR::InjectedBundlePage::didChange): (WTR::InjectedBundlePage::didChangeSelection):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

Jul 24, 2010:

10:24 PM Changeset in webkit [64019] by dbates@webkit.org
  • 2 edits in trunk/WebCore

2010-07-24 Daniel Bates <​dbates@rim.com>

Unreviewed, build fix when building with WML support.

PageCache.cpp compile error when WML is enabled
​https://bugs.webkit.org/show_bug.cgi?id=40765

Remove extraneous semicolon.

Note, building with WML support enabled is broken
even with this fix. See Bug #42943 for more details.

  • history/PageCache.cpp: (WebCore::PageCache::canCachePageContainingThisFrame):
6:24 PM WikiStart edited by paroga@paroga.com
(diff)
6:22 PM WinCE created by paroga@paroga.com
6:03 PM Changeset in webkit [64018] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-07-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Atomize strings used by the HTML5 tree builder
​https://bugs.webkit.org/show_bug.cgi?id=42875

This is about a 1% improvement to the parsing benchmark.

  • html/HTMLTagNames.in:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTagForInBody): (WebCore::HTMLTreeBuilder::processStartTagForInHead):
5:40 PM Changeset in webkit [64017] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-07-24 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

[MSVC] Ensure 4 byte alignment on ARM
​https://bugs.webkit.org/show_bug.cgi?id=42935

  • jit/JITStubs.h: Added #pragma pack(4) around JITStackFrame.
5:08 PM Changeset in webkit [64016] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-07-24 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

[WINCE] Cleanup defines in Platform.h
​https://bugs.webkit.org/show_bug.cgi?id=42933

  • wtf/Platform.h:
4:33 PM Changeset in webkit [64015] by commit-queue@webkit.org
  • 5 edits in trunk/WebCore

2010-07-24 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

Buildfix for !ENABLE(INSPECTOR) after r63891.
​https://bugs.webkit.org/show_bug.cgi?id=42925

  • bindings/js/ScriptValue.cpp: Added property svn:eol-style.
  • bindings/js/ScriptValue.h: Added property svn:eol-style.
  • inspector/ConsoleMessage.cpp: Added property svn:eol-style.
  • inspector/ConsoleMessage.h: Added property svn:eol-style.
3:36 PM Changeset in webkit [64014] by Chris Fleizach
  • 7 edits
    2 adds in trunk

AX: need a layout test testing misspelled words in attributed strings
​https://bugs.webkit.org/show_bug.cgi?id=42899

Reviewed by David Kilzer.

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(attributedStringForRangeCallback):
(attributedStringRangeIsMisspelledCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::attributedStringRangeIsMisspelled):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::attributedStringRangeIsMisspelled):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::attributedStringRangeIsMisspelled):

LayoutTests:

  • platform/mac/accessibility/misspelled-attributed-string-expected.txt: Added.
  • platform/mac/accessibility/misspelled-attributed-string.html: Added.
3:17 PM Changeset in webkit [64013] by rniwa@webkit.org
  • 4 edits
    1 add
    8 deletes in trunk/LayoutTests

editing/execCommand/hilitecolor.html and editing/style/remove-underline-from-stylesheet.html should be dumpAsMarkup tests
​https://bugs.webkit.org/show_bug.cgi?id=42793

Reviewed by Darin Adler.

Converted the tests and removed the platform specific expected results.

  • editing/execCommand/hilitecolor-expected.txt: Added.
  • editing/execCommand/hilitecolor.html: Converted.
  • editing/style/remove-underline-from-stylesheet-expected.txt: Converted.
  • editing/style/remove-underline-from-stylesheet.html: Converted.
  • platform/chromium-linux/editing/execCommand/hilitecolor-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/hilitecolor-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/hilitecolor-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/hilitecolor-expected.txt: Removed.
  • platform/mac/editing/execCommand/hilitecolor-expected.checksum: Removed.
  • platform/mac/editing/execCommand/hilitecolor-expected.png: Removed.
  • platform/mac/editing/execCommand/hilitecolor-expected.txt: Removed.
  • platform/qt/editing/execCommand/hilitecolor-expected.txt: Removed.
1:02 PM Changeset in webkit [64012] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-07-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Re-order whitespace checks in the tokenizer
​https://bugs.webkit.org/show_bug.cgi?id=42923

This saves about 0.5% on the parsing benchmark.

  • html/HTMLTokenizer.cpp:
11:48 AM Changeset in webkit [64011] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-07-24 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] tst_QWebFrame::callQtInvokable() fails
​https://bugs.webkit.org/show_bug.cgi?id=41065

Converting JS objects to QVariantMaps was broken.
This is a partial revert of <​http://trac.webkit.org/changeset/61478>

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant): Remove erroneous crash guard around JSObject::getPropertyNames()
10:33 AM Changeset in webkit [64010] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-07-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Save a per-character branch in the HTML parser
​https://bugs.webkit.org/show_bug.cgi?id=42921

The parsing benchmark claims this is a wash, but it makes me feel
better.

  • html/HTMLToken.h: (WebCore::HTMLToken::clear): (WebCore::HTMLToken::beginStartTag): (WebCore::HTMLToken::beginEndTag): (WebCore::HTMLToken::ensureIsCharacterToken): (WebCore::HTMLToken::beginComment): (WebCore::HTMLToken::beginDOCTYPE):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::bufferCharacter):
8:06 AM Changeset in webkit [64009] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-07-24 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: chromium build fix.

  • src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::fillResourceList):
5:54 AM Changeset in webkit [64008] by commit-queue@webkit.org
  • 2 edits in trunk

2010-07-24 Riccardo Magliocchetti <​riccardo.magliocchetti@gmail.com>

Reviewed by Xan Lopez.

[GTK] Enable jit compilation on arm
​https://bugs.webkit.org/show_bug.cgi?id=42856

Add missing bits to configure.ac to build the arm jit.
Compile and tested on debian sid armel on a qemu vm.

  • configure.ac:

Jul 23, 2010:

9:17 PM Changeset in webkit [64007] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-23 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

Buildfix for !ENABLE(FILTERS) after r63531.
​https://bugs.webkit.org/show_bug.cgi?id=42914

  • rendering/RenderSVGContainer.cpp: Add missing header.
8:35 PM Changeset in webkit [64006] by commit-queue@webkit.org
  • 8 edits in trunk

2010-07-23 Kavita Kanetkar <​kkanetkar@chromium.org>

Reviewed by Joseph Pecoraro.

Implement remaining Inspector support for chrome's appcache
​https://bugs.webkit.org/show_bug.cgi?id=42426

  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::getApplicationCaches): (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache): (WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources): (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):
  • inspector/InspectorApplicationCacheAgent.h: (WebCore::InspectorController::connectFrontend):
  • loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::fillResourceList): (WebCore::ApplicationCacheHost::applicationCacheInfo):
  • loader/appcache/ApplicationCacheHost.h: Changed creation + update times to double and moved appcache info here from InspectorApplicationCacheAgent.h (WebCore::ApplicationCacheHost::CacheInfo::CacheInfo): (WebCore::ApplicationCacheHost::ResourceInfo::ResourceInfo):

2010-07-23 Kavita Kanetkar <​kkanetkar@chromium.org>

Reviewed by Joseph Pecoraro.

Implement remaining Inspector support for chrome's appcache
​https://bugs.webkit.org/show_bug.cgi?id=42426

  • src/ApplicationCacheHost.cpp: Plugging in chrome's appcache info. (WebCore::ApplicationCacheHost::applicationCacheInfo): (WebCore::ApplicationCacheHost::fillResourceList):
  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
6:48 PM Changeset in webkit [64005] by commit-queue@webkit.org
  • 13 edits
    1 add in trunk

2010-07-23 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Cleanup glib support (make it optional)
​https://bugs.webkit.org/show_bug.cgi?id=42480

Fixing support for compiling EFL port without glib.

  • cmake/FindGthread.cmake: Added.
  • cmake/OptionsEfl.cmake:

2010-07-23 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Cleanup glib support (make it optional)
​https://bugs.webkit.org/show_bug.cgi?id=42480

Remove gobject/GRefPtr.cpp if not using soup/glib.

  • wtf/CMakeListsEfl.txt:

2010-07-23 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Cleanup glib support (make it optional)
​https://bugs.webkit.org/show_bug.cgi?id=42480

No new tests, no new features added.
Just add flags and directories for glib if necessary.
Put some ifdefs on glib calls.

  • CMakeListsEfl.txt:
  • platform/graphics/cairo/FontPlatformDataCairo.cpp: (WebCore::FontPlatformData::FontPlatformData):

2010-07-23 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Cleanup glib support (make it optional)
​https://bugs.webkit.org/show_bug.cgi?id=42480

Just add glib flags and directories if necessary.

  • CMakeListsEfl.txt:

2010-07-23 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Cleanup glib support (make it optional)
​https://bugs.webkit.org/show_bug.cgi?id=42480

Put some ifdefs on glib calls.

  • ewk/ewk_main.cpp: (ewk_init):
5:09 PM Changeset in webkit [64004] by jamesr@google.com
  • 3 edits in trunk/WebCore

2010-07-23 James Robinson <​jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

CanvasRenderingContext2D has lots of style errors
​https://bugs.webkit.org/show_bug.cgi?id=42918

CanvasRenderingContext2D.h and .cpp have lots of style errors. I'm planning to post patches
to both of these files soon, so to minimize merge conflicts and additional style violations
it seems best to fix all of these errors in bulk before posting any functional changes. In
particular the header file is incorrectly indented so any correctly formatted addition will
be out of place.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): (WebCore::CanvasRenderingContext2D::setFillStyle): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::arcTo): (WebCore::CanvasRenderingContext2D::arc): (WebCore::validateRectForCanvas): (WebCore::CanvasRenderingContext2D::strokeRect): (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::createRadialGradient): (WebCore::CanvasRenderingContext2D::createPattern): (WebCore::CanvasRenderingContext2D::willDraw): (WebCore::CanvasRenderingContext2D::createImageData): (WebCore::CanvasRenderingContext2D::putImageData): (WebCore::CanvasRenderingContext2D::setFont): (WebCore::CanvasRenderingContext2D::drawTextInternal):
  • html/canvas/CanvasRenderingContext2D.h: (WebCore::CanvasRenderingContext2D::is2d): (WebCore::CanvasRenderingContext2D::getLineCap): (WebCore::CanvasRenderingContext2D::getLineJoin): (WebCore::CanvasRenderingContext2D::state): (WebCore::CanvasRenderingContext2D::):
5:07 PM Changeset in webkit [64003] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

5:05 PM Changeset in webkit [64002] by mrowe@apple.com
  • 1 copy in tags/Safari-534.3

New tag.

5:03 PM Changeset in webkit [64001] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-07-23 Adam Barth <​abarth@webkit.org>

Remove FIXME that we already fixed.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processCharacter):
3:34 PM Changeset in webkit [64000] by jamesr@google.com
  • 5 edits
    7 adds in trunk/LayoutTests

2010-07-23 James Robinson <​jamesr@chromium.org>

Unreviewed. Add chromium expectations for new tests.

  • platform/chromium-mac/tables/layering/paint-test-layering-1-expected.checksum:
  • platform/chromium-mac/tables/layering/paint-test-layering-1-expected.png:
  • platform/chromium-mac/tables/layering/paint-test-layering-2-expected.checksum:
  • platform/chromium-mac/tables/layering/paint-test-layering-2-expected.png:
  • platform/chromium-win/tables/layering: Added.
  • platform/chromium-win/tables/layering/paint-test-layering-1-expected.checksum: Added.
  • platform/chromium-win/tables/layering/paint-test-layering-1-expected.png: Added.
  • platform/chromium-win/tables/layering/paint-test-layering-1-expected.txt: Added.
  • platform/chromium-win/tables/layering/paint-test-layering-2-expected.checksum: Added.
  • platform/chromium-win/tables/layering/paint-test-layering-2-expected.png: Added.
  • platform/chromium-win/tables/layering/paint-test-layering-2-expected.txt: Added.
3:17 PM Changeset in webkit [63999] by Dimitri Glazkov
  • 10 edits in trunk/WebCore

2010-06-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

Move more form submission logic into FormSubmission.
​https://bugs.webkit.org/show_bug.cgi?id=41110

Two major moves:

  • Fold HTMLFormElement::prepareFormSubmission into FormSubmission::create
  • Move non-static (non-FormData-building) methods of FormDataBuilder

to FormSubmission::Attributes.

Mechanical moving, no change in behavior, so no new tests.

  • WebCore.xcodeproj/project.pbxproj: Gave FormDataBuilder.h "project" and

FormSubmission.h "private" visibility.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Changed to use FormSubmission::create. (WebCore::HTMLFormElement::parseMappedAttribute): Changed to use m_attributes.
  • html/HTMLFormElement.h: (WebCore::HTMLFormElement::enctype): Ditto. (WebCore::HTMLFormElement::encoding): Ditto. (WebCore::HTMLFormElement::acceptCharset): Ditto.
  • loader/FormSubmission.cpp: (WebCore::generateFormDataIdentifier): Moved from HTMLFormElement. (WebCore::appendMailtoPostFormDataToURL): Ditto. (WebCore::FormSubmission::Attributes::parseAction): Moved from FormDataBuilder. (WebCore::FormSubmission::Attributes::parseEncodingType): Ditto. (WebCore::FormSubmission::Attributes::parseMethodType): Ditto. (WebCore::FormSubmission::FormSubmission): Made inline. (WebCore::FormSubmission::create): Added logic that used to be in

HTMLFormElement::prepareFormSubmission.

  • loader/FormSubmission.h: (WebCore::FormSubmission::): (WebCore::FormSubmission::Attributes::Attributes): Added new class. (WebCore::FormSubmission::Attributes::method): Moved from FormDataBuilder. (WebCore::FormSubmission::Attributes::isMultiPartForm): Ditto. (WebCore::FormSubmission::Attributes::action): Ditto. (WebCore::FormSubmission::Attributes::target): Ditto. (WebCore::FormSubmission::Attributes::setTarget): Ditto. (WebCore::FormSubmission::Attributes::encodingType): Ditto. (WebCore::FormSubmission::Attributes::acceptCharset): Ditto. (WebCore::FormSubmission::Attributes::setAcceptCharset): Ditto. (WebCore::FormSubmission::target): Ditto. (WebCore::FormSubmission::contentType): Const-ified return type. (WebCore::FormSubmission::boundary): Ditto.
  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::encodingFromAcceptCharset): Renamed method for clarity,

made it use param instead of a class member.

  • platform/network/FormDataBuilder.h: (WebCore::FormDataBuilder::FormDataBuilder): Made constructor private.
  • wml/WMLGoElement.cpp: Changed to use FormSubmision::Attributes.
  • wml/WMLGoElement.h: Ditto.
3:14 PM Changeset in webkit [63998] by abarth@webkit.org
  • 13 edits
    2 adds in trunk

2010-07-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5 Parser: document.write in a asynchronous script which is specified to load before page finish blows away document
​https://bugs.webkit.org/show_bug.cgi?id=42365

  • http/tests/misc/write-from-dom-script-expected.txt: Added.
  • http/tests/misc/write-from-dom-script.html: Added.
    • Test the scenario where a script added to the DOM asynchronously while the nesting level is >0. It's supposed to have its calls to document.write blocked.
  • http/tests/misc/write-while-waiting.html:
    • Writes are only prevented from scripts that are added to the DOM. Scripts that run via setTimeout do not have their writes blocked.

2010-07-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5 Parser: document.write in a asynchronous script which is specified to load before page finish blows away document
​https://bugs.webkit.org/show_bug.cgi?id=42365

This patch implements the changes Ian made to HTML5 to address these
issues. Let's try it and see how well it works.

Test: http/tests/misc/write-from-dom-script.html

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::write):
  • dom/Document.h: (WebCore::Document::writeDisabled): (WebCore::Document::setWriteDisabled):
  • dom/DocumentParser.h: (WebCore::DocumentParser::hasInsertionPoint):
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::insertedIntoDocument): (WebCore::ScriptElementData::ScriptElementData): (WebCore::ScriptElementData::evaluateScript):
  • dom/ScriptElement.h: (WebCore::ScriptElementData::writeDisabled): (WebCore::ScriptElementData::setWriteDisabled):
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::hasInsertionPoint): (WebCore::HTMLDocumentParser::insert):
  • html/HTMLDocumentParser.h:
2:59 PM Changeset in webkit [63997] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

<​http://webkit.org/b/42911> Update ruby tools to work with shallow framework bundles

Reviewed by Mark Rowe.

  • Scripts/check-for-inappropriate-files-in-framework: Added

check for the SHALLOW_BUNDLE environment variable so that the
script will work with iOS WebKit builds.

  • Scripts/check-for-webkit-framework-include-consistency: Ditto.
2:46 PM Changeset in webkit [63996] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-23 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Buildfix for PopupMenuWin.cpp
​https://bugs.webkit.org/show_bug.cgi?id=42906

Use correct API for BitmapInfo landed in r63944.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
2:30 PM Applications using WebKit edited by onlineservices@thinkingcode.ca
(diff)
2:29 PM Applications using WebKit edited by onlineservices@thinkingcode.ca
(diff)
1:29 PM Changeset in webkit [63995] by hamaji@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-07-23 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed. Land the expectation for win.

Backslash isn't transcoded in <input>
​https://bugs.webkit.org/show_bug.cgi?id=42878

  • platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.
1:22 PM Changeset in webkit [63994] by jamesr@google.com
  • 9 edits
    32 adds in trunk

2010-07-23 ​fsamuel@chromium.org <​fsamuel@chromium.org>

Reviewed by David Hyatt.

Updated table painting to draw cell layers in the correct order.

Table Cell Layering
​https://bugs.webkit.org/show_bug.cgi?id=40775

Tests: tables/layering/paint-test-layering-1.html

tables/layering/paint-test-layering-2.html

  • accessibility/AccessibilityTable.cpp: (WebCore::AccessibilityTable::isTableExposableThroughAccessibility): (WebCore::AccessibilityTable::addChildren): (WebCore::AccessibilityTable::cellForColumnAndRow):
  • accessibility/AccessibilityTableCell.cpp: (WebCore::AccessibilityTableCell::titleUIElement):
  • accessibility/AccessibilityTableColumn.cpp: (WebCore::AccessibilityTableColumn::headerObjectForSection):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::splitColumn): (WebCore::RenderTable::calcBorderLeft): (WebCore::RenderTable::calcBorderRight): (WebCore::RenderTable::cellAbove): (WebCore::RenderTable::cellBelow): (WebCore::RenderTable::cellBefore): (WebCore::RenderTable::cellAfter):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::RenderTableSection): (WebCore::RenderTableSection::ensureRows): (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::setCellWidths): (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::calcOuterBorderTop): (WebCore::RenderTableSection::calcOuterBorderBottom): (WebCore::RenderTableSection::calcOuterBorderLeft): (WebCore::RenderTableSection::calcOuterBorderRight): (WebCore::RenderTableSection::firstLineBoxBaseline): (WebCore::compareCellPositions): (WebCore::RenderTableSection::paintCell): (WebCore::RenderTableSection::paintObject): (WebCore::RenderTableSection::numColumns): (WebCore::RenderTableSection::appendColumn): (WebCore::RenderTableSection::splitColumn): (WebCore::RenderTableSection::nodeAtPoint):
  • rendering/RenderTableSection.h: (WebCore::RenderTableSection::CellStruct::CellStruct): (WebCore::RenderTableSection::CellStruct::primaryCell): (WebCore::RenderTableSection::CellStruct::hasCells): (WebCore::RenderTableSection::primaryCellAt):

2010-07-23 ​fsamuel@chromium.org <​fsamuel@chromium.org>

Reviewed by David Hyatt.

Updated table painting to draw cell layers in the correct order.

Table Cell Layering
​https://bugs.webkit.org/show_bug.cgi?id=40775

  • platform/chromium-linux/tables/layering/paint-test-layering-1-expected.checksum: Added.
  • platform/chromium-linux/tables/layering/paint-test-layering-1-expected.png: Added.
  • platform/chromium-linux/tables/layering/paint-test-layering-1-expected.txt: Added.
  • platform/chromium-linux/tables/layering/paint-test-layering-2-expected.checksum: Added.
  • platform/chromium-linux/tables/layering/paint-test-layering-2-expected.png: Added.
  • platform/chromium-linux/tables/layering/paint-test-layering-2-expected.txt: Added.
  • platform/chromium-mac/tables/layering/paint-test-layering-1-expected.checksum: Added.
  • platform/chromium-mac/tables/layering/paint-test-layering-1-expected.png: Added.
  • platform/chromium-mac/tables/layering/paint-test-layering-1-expected.txt: Added.
  • platform/chromium-mac/tables/layering/paint-test-layering-2-expected.checksum: Added.
  • platform/chromium-mac/tables/layering/paint-test-layering-2-expected.png: Added.
  • platform/chromium-mac/tables/layering/paint-test-layering-2-expected.txt: Added.
  • platform/gtk/tables/layering/paint-test-layering-1-expected.checksum: Added.
  • platform/gtk/tables/layering/paint-test-layering-1-expected.png: Added.
  • platform/gtk/tables/layering/paint-test-layering-1-expected.txt: Added.
  • platform/gtk/tables/layering/paint-test-layering-2-expected.checksum: Added.
  • platform/gtk/tables/layering/paint-test-layering-2-expected.png: Added.
  • platform/gtk/tables/layering/paint-test-layering-2-expected.txt: Added.
  • platform/mac/tables/layering/paint-test-layering-1-expected.checksum: Added.
  • platform/mac/tables/layering/paint-test-layering-1-expected.png: Added.
  • platform/mac/tables/layering/paint-test-layering-1-expected.txt: Added.
  • platform/mac/tables/layering/paint-test-layering-2-expected.checksum: Added.
  • platform/mac/tables/layering/paint-test-layering-2-expected.png: Added.
  • platform/mac/tables/layering/paint-test-layering-2-expected.txt: Added.
  • tables/layering/paint-test-layering-1.html: Added.
  • tables/layering/paint-test-layering-2.html: Added.
1:16 PM Changeset in webkit [63993] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-23 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Buildfix for Path.h
​https://bugs.webkit.org/show_bug.cgi?id=42904

  • platform/graphics/Path.h: Add missing typedef PlatformPath.
12:51 PM Changeset in webkit [63992] by senorblanco@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2010-07-23 Stephen White <​senorblanco@chromium.org>

Unreviewed; chromium test expectations fix.

  • platform/chromium-win/fast/borders/different-color-borders-expected.checksum: Added.
  • platform/chromium-win/fast/borders/different-color-borders-expected.png: Added.
  • platform/chromium-win/fast/borders/different-color-borders-expected.txt: Added. New baseline for new test.
  • platform/chromium/test_expectations.txt: Remove passing tests from expectations.
12:08 PM Changeset in webkit [63991] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-07-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Reserve capacity for attributes
​https://bugs.webkit.org/show_bug.cgi?id=42877

This is about a 1.7% improvement to the parsing benchmark.

  • html/HTMLToken.h: (WebCore::AtomicHTMLToken::AtomicHTMLToken):
11:54 AM Changeset in webkit [63990] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-07-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Inline HTMLElementStack::top
​https://bugs.webkit.org/show_bug.cgi?id=42879

According to sampling, HTMLElementStack::top is the hotest function in
the treebuilder. Inlining it is about a 0.3% improvement to the
parsing benchmark. This squares with how often it occurs in samples.

  • html/HTMLElementStack.cpp:
  • html/HTMLElementStack.h: (WebCore::HTMLElementStack::top):
11:38 AM Changeset in webkit [63989] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-07-23 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Buildfix for GraphicsContext
​https://bugs.webkit.org/show_bug.cgi?id=42888

Use AffineTransform insted of TransformationMatrix and
add ColorSpace parameter to the drawBitmap methods.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::affineTransform): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::drawBitmap): (WebCore::GraphicsContext::drawBitmapPattern):
11:17 AM Changeset in webkit [63988] by commit-queue@webkit.org
  • 11 edits in trunk

2010-07-23 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Add support for using libcurl network backend.
​https://bugs.webkit.org/show_bug.cgi?id=42286

Instead of just libsoup, the EFL port now can use libcurl backend.
This is a step in the direction of removing dependency on glib. Just
need to pass the option -DNETWORK_BACKEND=curl to cmake in order to
enable it.

  • cmake/OptionsEfl.cmake:

2010-07-23 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Add support for using libcurl network backend.
​https://bugs.webkit.org/show_bug.cgi?id=42286

Add files and flags for soup/curl specific backend being
used.
Put some ifdefs around soup/glib calls.

No new tests, no new features implemented.

  • CMakeListsEfl.txt:
  • platform/efl/FileSystemEfl.cpp: (WebCore::fileSystemRepresentation):

2010-07-23 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Add support for using libcurl network backend.
​https://bugs.webkit.org/show_bug.cgi?id=42286

Just add soup/curl directories and flags for the specific
backend being used.

  • CMakeLists.txt:
  • CMakeListsEfl.txt:

2010-07-23 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Add support for using libcurl network backend.
​https://bugs.webkit.org/show_bug.cgi?id=42286

Put some ifdefs around soup calls.

  • ewk/ewk_cookies.cpp: (ewk_cookies_file_set): (ewk_cookies_clear): (ewk_cookies_get_all): (ewk_cookies_cookie_del): (ewk_cookies_cookie_free): (ewk_cookies_policy_set): (ewk_cookies_policy_get):
  • ewk/ewk_main.cpp: (ewk_init):
10:47 AM Changeset in webkit [63987] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-07-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add fast-reject path for InputStreamPreprocessor::peek
​https://bugs.webkit.org/show_bug.cgi?id=42881

This is about a 2.5% speedup on the parsing benchmark.

  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::InputStreamPreprocessor::peek):
10:27 AM Changeset in webkit [63986] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

2010-07-23 Hans Wennborg <​hans@chromium.org>

Reviewed by Ojan Vafai.

Rebaseline fast/dom/prototype-inheritance.html for chromium
​https://bugs.webkit.org/show_bug.cgi?id=42824

Since Chromium revision 53317, ENABLE_DEVICE_ORIENTATION is enabled,
which means window.DeviceOrientationEvent will show up
in this layout test.

  • platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt:
  • platform/chromium-win/fast/dom/prototype-inheritance-expected.txt:
10:11 AM Changeset in webkit [63985] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-23 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Merge PasteboardWince.cpp into PasteboardWin.cpp
​https://bugs.webkit.org/show_bug.cgi?id=42885

Make PasteboardWin more portable and remove the global namespace prefix
from GlobalLock/GlobalUnlock, since they are only macros on WinCE.

  • platform/win/PasteboardWin.cpp: (WebCore::PasteboardOwnerWndProc): (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):
9:41 AM Changeset in webkit [63984] by jschuh@chromium.org
  • 3 edits
    2 deletes in trunk

2010-07-23 Justin Schuh <​jschuh@chromium.org>

Unreviewed, rolling out r63925.
​http://trac.webkit.org/changeset/63925
​https://bugs.webkit.org/show_bug.cgi?id=42858

Introduced a regression in history state.

  • page/History.cpp: (WebCore::History::urlForState):

2010-07-23 Justin Schuh <​jschuh@chromium.org>

Unreviewed, rolling out r63925.
​http://trac.webkit.org/changeset/63925
​https://bugs.webkit.org/show_bug.cgi?id=42858

Introduced a regression in history state.

  • fast/history/history-replace-illegal-expected.txt: Removed.
  • fast/history/history-replace-illegal.html: Removed.
9:26 AM Changeset in webkit [63983] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-07-23 Martin Robinson <​mrobinson@igalia.com>

Unreviewed build fix.

Fix make dist by aligning the source list with currently used headers.

  • GNUmakefile.am:
9:25 AM Changeset in webkit [63982] by jschuh@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2010-07-23 Justin Schuh <​jschuh@chromium.org>

Unreviewed, rolling out r63959.
​http://trac.webkit.org/changeset/63959
​https://bugs.webkit.org/show_bug.cgi?id=42884

63925 introduced a regression and is being reverted.

  • platform/chromium-mac/fast/history/history-replace-illegal-expected.txt: Removed.
  • platform/chromium-win/fast/history/history-replace-illegal-expected.txt: Removed.
9:24 AM Changeset in webkit [63981] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-07-23 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Implement TCSpinLock.
​https://bugs.webkit.org/show_bug.cgi?id=41792

Implement the SpinLock with InterlockedExchange from the Windows API.

  • wtf/TCSpinLock.h: (TCMalloc_SpinLock::Lock): (TCMalloc_SpinLock::Unlock): (TCMalloc_SpinLock::IsHeld): (TCMalloc_SpinLock::Init): (TCMalloc_SlowLock):
9:10 AM Changeset in webkit [63980] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore/qt

2010-07-23 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

QScriptValue::equals benchmark crash fix.

Patch changes QScriptValue::equals implementation to cover
more edge cases.

Problem exposes an issue in our autotests (all values got
bound to an engine too fast - bug 42366).

[Qt] QScriptValue::equals asserts
​https://bugs.webkit.org/show_bug.cgi?id=42363

  • api/qscriptvalue_p.h: (QScriptValuePrivate::equals):
8:57 AM Changeset in webkit [63979] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-23 Alex Milowski <​alex@milowski.com>

Reviewed by Darin Adler.

Moved the 'mathml' group back to where it belongs as
siblings of the other major folders.

  • WebCore.xcodeproj/project.pbxproj:
8:44 AM Changeset in webkit [63978] by commit-queue@webkit.org
  • 5 edits in trunk/WebKit/efl

2010-07-23 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Notify browser when window shall be closed.

This is used for window.close() events Javascript, though it would be
triggered for any event on WebCore that might ask for the window to be
closed.

​https://bugs.webkit.org/show_bug.cgi?id=42890

  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::closeWindowSoon): call new function and moves its previous functionality there.
  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp: (ewk_view_window_close): stop all loaders as was being done previously and notify browser afterwards.
  • ewk/ewk_view.h: declare new virtual method.
8:41 AM Changeset in webkit [63977] by Csaba Osztrogonác
  • 1 edit
    1 copy
    1 add in trunk/LayoutTests

Unreviewed.

Process link elements immediately if there are no beforeload listeners.
​https://bugs.webkit.org/show_bug.cgi?id=42859

Add Qt specific expected result after r63924.

  • platform/qt/http/tests/security/mixedContent: Added.
  • platform/qt/http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt: Copied from LayoutTests/http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt and updated.
8:30 AM Changeset in webkit [63976] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-07-23 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

Buildfix for WinCE graphics after r56015.
​https://bugs.webkit.org/show_bug.cgi?id=41354

Use fabs() insetead of abs().

  • platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::fillRect):
  • platform/graphics/wince/PlatformPathWince.cpp: (WebCore::PlatformPath::addArcTo):
7:50 AM Changeset in webkit [63975] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-23 ryuan choi <​ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL]build break because of r63927
​https://bugs.webkit.org/show_bug.cgi?id=42864

  • CMakeLists.txt:
7:48 AM Changeset in webkit [63974] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Doc: Fixed incorrect QML property type.

Patch by David Boddie <​dboddie@trolltech.com> on 2010-07-23
Reviewed by Simon Hausmann.

  • declarative/qdeclarativewebview.cpp:
7:36 AM Changeset in webkit [63973] by abecsi@webkit.org
  • 2 edits in trunk

2010-07-23 Andras Becsi <​abecsi@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable the build of MiniBrowser.

  • WebKit.pro: add MiniBrowser.pro to SUBDIRS.
7:34 AM Changeset in webkit [63972] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/efl

2010-07-23 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Set proxy address for Soup
​https://bugs.webkit.org/show_bug.cgi?id=42721

Sets the given proxy URI for libsoup network backend. This method will
support libcurl network backend later.

  • EWebLauncher/main.c: (main): Invoke proxy set method
  • ewk/ewk_settings.cpp: (ewk_settings_proxy_uri_set): Sets proxy URI.
  • ewk/ewk_settings.h:
7:27 AM Changeset in webkit [63971] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Build fix for Qt apps

Add webkit to QT_CONFIG. qconfig.pri will read qt_webkit_version.pri and
that's how it will pick up webkit in QT_CONFIG.

  • qt_webkit_version.pri:
7:19 AM Changeset in webkit [63970] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-07-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Inline HTMLTokenizer::InputStreamPreprocessor::peek
​https://bugs.webkit.org/show_bug.cgi?id=42880

According to sampling HTMLTokenizer::InputStreamPreprocessor::peek is
the hotest function in the tokenizer. Inlining this function is about
a 2.2% speedup on the parser benchmark. Turns out the tokenizer is
much hotter than the tree builder. :)

  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::InputStreamPreprocessor::peek):
7:04 AM Changeset in webkit [63969] by abecsi@webkit.org
  • 2 edits in trunk/WebCore

2010-07-23 Andras Becsi <​abecsi@webkit.org>

Unreviewed build fix.

[Qt] Fix WebKit2 linkage.

No new tests needed.

  • WebCore.pro: add InjectedBundlePageEditorClient.cpp to WK2 sources
6:39 AM Changeset in webkit [63968] by abecsi@webkit.org
  • 6 edits
    5 adds in trunk

2010-07-23 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Setup the QtWebProcess

​https://bugs.webkit.org/show_bug.cgi?id=42623

  • WebCore.pro: Added WebProcessMainQt.cpp to SOURCES.

2010-07-23 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Setup the QtWebProcess

​https://bugs.webkit.org/show_bug.cgi?id=42623

  • WebKit.pro: Add WebKit2.pro to the build guarded by webkit2 config variable.

2010-07-19 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Setup the QtWebProcess

​https://bugs.webkit.org/show_bug.cgi?id=42623

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Remove the framework entry point from here to WebProcess/qt/WebProcessMainQt.cpp to match with with the mac and the win port.
  • WebKit2.pro: Added.
  • WebProcess/qt/WebProcessMainQt.cpp: Added. (WebKit::WebProcessMainQt): Framework entry point for Qt.
  • qt/MainQt.cpp: Added. (main):
6:19 AM Changeset in webkit [63967] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-07-23 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: Chromium tests fix.

  • inspector/CodeGeneratorInspector.pm:
5:54 AM Changeset in webkit [63966] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-23 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Buildfix for PluginDatabaseWin.cpp
​https://bugs.webkit.org/show_bug.cgi?id=41887

Define KEY_ENUMERATE_SUB_KEYS only if not defined.

  • plugins/win/PluginDatabaseWin.cpp:
5:46 AM Changeset in webkit [63965] by pfeldman@chromium.org
  • 10 edits in trunk

2010-07-23 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium DevTools: migrate from utility context-based injected
script dispatch to upstream schema.

​https://bugs.webkit.org/show_bug.cgi?id=42883

  • bindings/v8/ScriptProfile.cpp: (WebCore::ScriptProfile::title):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::getProfile):
  • inspector/front-end/InjectedScriptAccess.js:

2010-07-23 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Reviewed by Yury Semikhatsky.

Chromium DevTools: migrate from utility context-based injected
script dispatch to upstream schema.

​https://bugs.webkit.org/show_bug.cgi?id=42883

  • src/ToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDevToolsAgentImpl.h:
  • src/js/DevToolsHostStub.js:
  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
5:20 AM Changeset in webkit [63964] by pfeldman@chromium.org
  • 10 edits in trunk

2010-07-23 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: rolling out r63963.

  • bindings/v8/ScriptProfile.cpp: (WebCore::ScriptProfile::title):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::getProfile):
  • inspector/front-end/InjectedScriptAccess.js:
5:12 AM Changeset in webkit [63963] by pfeldman@chromium.org
  • 10 edits in trunk

2010-07-23 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium DevTools: migrate from utility context-based injected
script dispatch to upstream schema.

​https://bugs.webkit.org/show_bug.cgi?id=42883

  • bindings/v8/ScriptProfile.cpp: (WebCore::ScriptProfile::title):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::getProfile):
  • inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess.get if): (InjectedScriptAccess):

2010-07-23 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Reviewed by Yury Semikhatsky.

Chromium DevTools: migrate from utility context-based injected
script dispatch to upstream schema.

​https://bugs.webkit.org/show_bug.cgi?id=42883

  • src/ToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDevToolsAgentImpl.h:
  • src/js/DevToolsHostStub.js:
  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
4:58 AM Changeset in webkit [63962] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-07-23 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: error info propagation in InspectorBackendDispatch should be improved
​https://bugs.webkit.org/show_bug.cgi?id=42873

  • inspector/CodeGeneratorInspector.pm: report wrong parameter count and wrong parametere type errror to the dispatch method caller
4:42 AM Changeset in webkit [63961] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-07-23 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: injectedScriptId is missing in the stack frame wrappers.

​https://bugs.webkit.org/show_bug.cgi?id=42889

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
4:24 AM Changeset in webkit [63960] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Search input field doesn't have cancel button
​https://bugs.webkit.org/show_bug.cgi?id=42887

  • platform/qt/Skipped: fast/forms/search-cancel-button-events.html skipped until fix.
3:02 AM Changeset in webkit [63959] by bulach@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-07-23 Marcus Bulach <​bulach@chromium.org>

Unreviewed. Adds expectations for chromium.

[chromium] Updates baselines following changes in history (​http://trac.webkit.org/changeset/63925)
​https://bugs.webkit.org/show_bug.cgi?id=42884

  • platform/chromium-mac/fast/history/history-replace-illegal-expected.txt: Added.
  • platform/chromium-win/fast/history/history-replace-illegal-expected.txt: Added.
2:02 AM Changeset in webkit [63958] by bulach@chromium.org
  • 49 edits
    12 adds
    13 deletes in trunk/LayoutTests

2010-07-22 Marcus Bulach <​bulach@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Updates baselines following changes in border drawing code (​http://trac.webkit.org/changeset/63864).
​https://bugs.webkit.org/show_bug.cgi?id=42822

  • platform/chromium-linux/fast/borders/different-color-borders-expected.checksum: Added.
  • platform/chromium-linux/fast/borders/different-color-borders-expected.png: Added.
  • platform/chromium-linux/fast/borders/different-color-borders-expected.txt: Added.
  • platform/chromium-mac/fast/borders/border-radius-constraints-expected.checksum:
  • platform/chromium-mac/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.checksum:
  • platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-split-inline-expected.checksum:
  • platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum:
  • platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.checksum: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusDashed01-expected.checksum:
  • platform/chromium-mac/fast/borders/borderRadiusDashed01-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusDashed04-expected.checksum:
  • platform/chromium-mac/fast/borders/borderRadiusDashed04-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDotted06-expected.checksum:
  • platform/chromium-mac/fast/borders/borderRadiusDotted06-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.checksum: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.checksum: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusInset01-expected.checksum: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusInvalidColor-expected.checksum:
  • platform/chromium-mac/fast/borders/borderRadiusInvalidColor-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusOutset01-expected.checksum: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusSolid01-expected.checksum: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusSolid01-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusSolid02-expected.checksum: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusSolid02-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusSolid03-expected.checksum: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusSolid03-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusSolid04-expected.checksum: Removed.
  • platform/chromium-mac/fast/borders/borderRadiusSolid04-expected.png:
  • platform/chromium-mac/fast/borders/different-color-borders-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/different-color-borders-expected.png: Added.
  • platform/chromium-mac/fast/borders/fieldsetBorderRadius-expected.checksum: Removed.
  • platform/chromium-mac/fast/borders/fieldsetBorderRadius-expected.png:
  • platform/chromium-mac/fast/css/nested-rounded-corners-expected.checksum: Added.
  • platform/chromium-mac/fast/css/nested-rounded-corners-expected.png: Added.
  • platform/chromium-mac/fast/forms/basic-selects-expected.checksum:
  • platform/chromium-mac/fast/forms/basic-selects-expected.png:
  • platform/chromium-mac/fast/forms/menulist-clip-expected.checksum:
  • platform/chromium-mac/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac/fast/forms/menulist-narrow-width-expected.checksum:
  • platform/chromium-mac/fast/forms/menulist-narrow-width-expected.png:
  • platform/chromium-mac/fast/forms/menulist-option-wrap-expected.checksum:
  • platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png:
  • platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.checksum:
  • platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/chromium-mac/fast/forms/menulist-separator-painting-expected.checksum:
  • platform/chromium-mac/fast/forms/menulist-separator-painting-expected.png:
  • platform/chromium-mac/fast/forms/menulist-style-color-expected.checksum:
  • platform/chromium-mac/fast/forms/menulist-style-color-expected.png:
  • platform/chromium-mac/fast/forms/select-baseline-expected.checksum:
  • platform/chromium-mac/fast/forms/select-baseline-expected.png:
  • platform/chromium-mac/fast/overflow/border-radius-clipping-expected.checksum:
  • platform/chromium-mac/fast/overflow/border-radius-clipping-expected.png:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win-xp/fast/css/nested-rounded-corners-expected.png: Added.
  • platform/chromium-win/fast/css/nested-rounded-corners-expected.checksum: Added.
  • platform/chromium-win/fast/css/nested-rounded-corners-expected.png: Added.
  • platform/chromium/test_expectations.txt:
1:37 AM Changeset in webkit [63957] by hamaji@chromium.org
  • 7 edits in trunk

2010-07-23 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Kent Tamura.

Backslash isn't transcoded in <input>
​https://bugs.webkit.org/show_bug.cgi?id=42878

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):

2010-07-23 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Kent Tamura.

Backslash isn't transcoded in <input>
​https://bugs.webkit.org/show_bug.cgi?id=42878

  • editing/selection/find-yensign-and-backslash-expected.txt:
  • platform/mac/fast/text/backslash-to-yen-sign-euc-expected.checksum:
  • platform/mac/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt:
12:28 AM Changeset in webkit [63956] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-07-23 Kent Tamura <​tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

Roll Chromium revision
​https://bugs.webkit.org/show_bug.cgi?id=42876

  • DEPS: Roll Chromium revision to r53434 in order to have the logger initialization change (r53303)
12:17 AM Changeset in webkit [63955] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-23 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed. Put a failing result for now.

Backslash is transcoded into yen sign even when non japanese font is specified
​https://bugs.webkit.org/show_bug.cgi?id=39654

  • editing/selection/find-yensign-and-backslash-expected.txt:
12:03 AM Changeset in webkit [63954] by Csaba Osztrogonác
  • 3 edits in trunk/JavaScriptCore

Unreviewed rolling out r63947 and r63948, because they broke Qt Windows build.

  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
Note: See TracTimeline for information about the timeline view.