Timeline
Aug 12, 2010:
- 11:58 PM Changeset in webkit [65304] by
-
- 10 edits in trunk
2010-08-12 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: allow interrupting long running JS to execute inspector command
https://bugs.webkit.org/show_bug.cgi?id=43900
- bindings/v8/ScriptDebugServer.cpp: (WebCore::): (WebCore::ScriptDebugServer::pause): (WebCore::ScriptDebugServer::interruptAndRun): (WebCore::ScriptDebugServer::runPendingTasks): (WebCore::ScriptDebugServer::handleV8DebugEvent):
- bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::Task::~Task):
2010-08-12 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: allow interrupting long running JS to execute inspector command
https://bugs.webkit.org/show_bug.cgi?id=43900
- public/WebDevToolsAgent.h: (WebKit::WebDevToolsAgent::MessageDescriptor::~MessageDescriptor):
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgent::interruptAndDispatch): (WebKit::WebDevToolsAgent::shouldInterruptForMessage): (WebKit::WebDevToolsAgent::processPendingMessages):
- src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
- src/WebDevToolsFrontendImpl.h:
- src/js/DevTools.js:
- 11:49 PM Changeset in webkit [65303] by
-
- 3 edits in trunk/JavaScriptCore
Refactoring the fpu code generator for the ARM port
https://bugs.webkit.org/show_bug.cgi?id=43842
Reviewed by Gavin Barraclough.
Support up to 32 double precision registers, and the
recent VFP instruction formats. This patch is mainly
a style change which keeps the current functionality.
- assembler/ARMAssembler.h:
(JSC::ARMRegisters::):
(JSC::ARMAssembler::):
(JSC::ARMAssembler::emitInst):
(JSC::ARMAssembler::emitDoublePrecisionInst):
(JSC::ARMAssembler::emitSinglePrecisionInst):
(JSC::ARMAssembler::vadd_f64_r):
(JSC::ARMAssembler::vdiv_f64_r):
(JSC::ARMAssembler::vsub_f64_r):
(JSC::ARMAssembler::vmul_f64_r):
(JSC::ARMAssembler::vcmp_f64_r):
(JSC::ARMAssembler::vsqrt_f64_r):
(JSC::ARMAssembler::vmov_vfp_r):
(JSC::ARMAssembler::vmov_arm_r):
(JSC::ARMAssembler::vcvt_f64_s32_r):
(JSC::ARMAssembler::vcvt_s32_f64_r):
(JSC::ARMAssembler::vmrs_apsr):
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::addDouble):
(JSC::MacroAssemblerARM::divDouble):
(JSC::MacroAssemblerARM::subDouble):
(JSC::MacroAssemblerARM::mulDouble):
(JSC::MacroAssemblerARM::sqrtDouble):
(JSC::MacroAssemblerARM::convertInt32ToDouble):
(JSC::MacroAssemblerARM::branchDouble):
(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):
- 11:42 PM Changeset in webkit [65302] by
-
- 41 edits in trunk
2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65295.
http://trac.webkit.org/changeset/65295
https://bugs.webkit.org/show_bug.cgi?id=43950
It broke 4 sputnik tests (Requested by Ossy on #webkit).
- JavaScriptCore.exp:
- bytecode/CodeBlock.cpp: (JSC::constantName): (JSC::idName): (JSC::CodeBlock::registerName): (JSC::regexpName): (JSC::printGlobalResolveInfo): (JSC::printStructureStubInfo): (JSC::CodeBlock::printStructure): (JSC::CodeBlock::printStructures):
- jsc.cpp: (functionPrint): (functionDebug): (runInteractive): (fillBufferWithContentsOfFile):
- pcre/pcre_exec.cpp: (Histogram::~Histogram):
- profiler/CallIdentifier.h: (JSC::CallIdentifier::c_str):
- profiler/Profile.cpp: (JSC::Profile::debugPrintDataSampleStyle):
- profiler/ProfileGenerator.cpp: (JSC::ProfileGenerator::willExecute): (JSC::ProfileGenerator::didExecute):
- profiler/ProfileNode.cpp: (JSC::ProfileNode::debugPrintData): (JSC::ProfileNode::debugPrintDataSampleStyle):
- runtime/Arguments.cpp: (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::getOwnPropertyDescriptor): (JSC::Arguments::put): (JSC::Arguments::deleteProperty):
- runtime/DateConversion.cpp: (JSC::parseDate):
- runtime/Identifier.h: (JSC::Identifier::Identifier): (JSC::Identifier::toArrayIndex):
- runtime/JSArray.cpp: (JSC::JSArray::getOwnPropertySlot): (JSC::JSArray::getOwnPropertyDescriptor): (JSC::JSArray::put): (JSC::JSArray::deleteProperty):
- runtime/JSArray.h:
- runtime/JSGlobalObjectFunctions.cpp: (JSC::encode): (JSC::parseInt): (JSC::globalFuncJSCPrint):
- runtime/JSString.h: (JSC::RopeBuilder::JSString):
- runtime/UString.cpp: (JSC::UString::toDouble): (JSC::UString::UTF8String):
- runtime/UString.h: (JSC::UString::isNull): (JSC::UString::isEmpty): (JSC::UString::impl): (JSC::UString::cost): (JSC::UString::~UString): (JSC::UString::toArrayIndex):
- wtf/text/WTFString.cpp: (WTF::String::utf8):
- wtf/text/WTFString.h: (WTF::String::String): (WTF::String::isHashTableDeletedValue): (WTF::String::length): (WTF::String::operator[]): (WTF::String::isNull): (WTF::String::isEmpty): (WTF::String::impl):
2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65295.
http://trac.webkit.org/changeset/65295
https://bugs.webkit.org/show_bug.cgi?id=43950
It broke 4 sputnik tests (Requested by Ossy on #webkit).
- WebFrame.cpp: (wxWebFrame::RunScript):
2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65295.
http://trac.webkit.org/changeset/65295
https://bugs.webkit.org/show_bug.cgi?id=43950
It broke 4 sputnik tests (Requested by Ossy on #webkit).
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::enumerate):
2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65295.
http://trac.webkit.org/changeset/65295
https://bugs.webkit.org/show_bug.cgi?id=43950
It broke 4 sputnik tests (Requested by Ossy on #webkit).
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlot): (WebCore::JSDOMWindow::getOwnPropertyDescriptor):
- bridge/NP_jsobject.cpp: (_NPN_Enumerate):
- bridge/c/c_utility.cpp: (JSC::Bindings::convertValueToNPVariant):
- bridge/jni/JNIBridge.cpp: (JavaParameter::JavaParameter): (JavaMethod::JavaMethod): (JavaMethod::signature): (JavaMethod::methodID):
- bridge/jni/JNIBridge.h: (JSC::Bindings::JavaString::UTF8String): (JSC::Bindings::JavaParameter::type): (JSC::Bindings::JavaMethod::returnType):
- bridge/jni/jni_jsobject.mm: (JavaJSObject::call): (JavaJSObject::eval): (JavaJSObject::getMember): (JavaJSObject::setMember): (JavaJSObject::removeMember): (JavaJSObject::convertJObjectToValue):
- bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::JavaField): (JavaField::valueFromInstance): (JavaField::setValueToInstance):
- bridge/jni/jsc/JNIBridgeJSC.h: (JSC::Bindings::JavaField::type):
- bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod):
- bridge/jni/jsc/JavaStringJSC.h: (JSC::Bindings::JavaStringImpl::UTF8String):
- bridge/runtime_array.cpp: (JSC::RuntimeArray::getOwnPropertySlot): (JSC::RuntimeArray::getOwnPropertyDescriptor): (JSC::RuntimeArray::put):
2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65295.
http://trac.webkit.org/changeset/65295
https://bugs.webkit.org/show_bug.cgi?id=43950
It broke 4 sputnik tests (Requested by Ossy on #webkit).
- WebProcess/Plugins/JSNPObject.cpp: (WebKit::npIdentifierFromIdentifier):
- WebProcess/Plugins/NPJSObject.cpp: (WebKit::NPJSObject::enumerate):
- WebProcess/Plugins/NPRuntimeObjectMap.cpp: (WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):
- 11:35 PM Changeset in webkit [65301] by
-
- 2 edits in trunk/WebCore
2010-08-12 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Fixed typo in inspector js.
Follow up to r65300.
- inspector/front-end/inspector.js: (WebInspector.log.isLogAvailable):
- 11:31 PM Changeset in webkit [65300] by
-
- 6 edits in trunk/WebCore
2010-08-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Make getPrototypes return objects, not names.
https://bugs.webkit.org/show_bug.cgi?id=43934
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
- inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback):
- inspector/front-end/inspector.js: (WebInspector.log):
- 10:43 PM Changeset in webkit [65299] by
-
- 8 edits in trunk/WebCore
2010-08-12 James Robinson <jamesr@chromium.org>
Unreviewed, rolling out r65284 and r65288. Broke chromium compile.
https://bugs.webkit.org/show_bug.cgi?id=43725
http://trac.webkit.org/changeset/65284
http://trac.webkit.org/changeset/65288
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
- bindings/v8/V8DOMWindowShell.h:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::namedPropertyDeleter): (WebCore::V8HTMLDocument::namedPropertyGetter): (WebCore::V8HTMLDocument::indexedPropertyGetter): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8):
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::removeItemFromMap):
- 9:33 PM Changeset in webkit [65298] by
-
- 2 edits in trunk/LayoutTests
Add more files to the WebKit2 skipped list.
Reviewed by Gavin Barraclough.
- platform/mac-wk2/Skipped:
- 9:27 PM Changeset in webkit [65297] by
-
- 2 edits in trunk/LayoutTests
2010-08-12 James Robinson <jamesr@chromium.org>
Unreviewed. Mark play-state.html and isindex-with-no-form.html as flaky because they are.
- platform/chromium/test_expectations.txt:
- 9:09 PM Changeset in webkit [65296] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 8:58 PM Changeset in webkit [65295] by
-
- 41 edits in trunk
Unify UString::UTF8String() & String::utf8() methods,
remove UString::cost() & make atArrayIndex a free function.
Reviewed by Sam Weinig
- JavaScriptCore.exp:
- bytecode/CodeBlock.cpp:
(JSC::constantName):
(JSC::idName):
(JSC::CodeBlock::registerName):
(JSC::regexpName):
(JSC::printGlobalResolveInfo):
(JSC::printStructureStubInfo):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
- jsc.cpp:
(functionPrint):
(functionDebug):
(runInteractive):
(fillBufferWithContentsOfFile):
- pcre/pcre_exec.cpp:
(Histogram::~Histogram):
- profiler/CallIdentifier.h:
(JSC::CallIdentifier::c_str):
- profiler/Profile.cpp:
(JSC::Profile::debugPrintDataSampleStyle):
- profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):
- profiler/ProfileNode.cpp:
(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):
- runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyDescriptor):
(JSC::Arguments::put):
(JSC::Arguments::deleteProperty):
- runtime/DateConversion.cpp:
(JSC::parseDate):
- runtime/Identifier.h:
(JSC::Identifier::toStrictUInt32):
- runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::deleteProperty):
- runtime/JSArray.h:
(JSC::toArrayIndex):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::parseInt):
(JSC::globalFuncJSCPrint):
- runtime/JSString.h:
(JSC::RopeBuilder::JSString):
- runtime/UString.cpp:
(JSC::UString::toDouble):
(JSC::putUTF8Triple):
(JSC::UString::utf8):
- runtime/UString.h:
(JSC::UString::~UString):
(JSC::UString::isNull):
(JSC::UString::isEmpty):
(JSC::UString::impl):
- wtf/text/WTFString.cpp:
(WTF::String::utf8):
- wtf/text/WTFString.h:
(WTF::String::~String):
(WTF::String::swap):
(WTF::String::isNull):
(WTF::String::isEmpty):
(WTF::String::impl):
(WTF::String::length):
(WTF::String::String):
(WTF::String::isHashTableDeletedValue):
WebCore:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
- bridge/NP_jsobject.cpp:
(_NPN_Enumerate):
- bridge/c/c_utility.cpp:
(JSC::Bindings::convertValueToNPVariant):
- bridge/jni/JNIBridge.cpp:
(JavaParameter::JavaParameter):
(JavaMethod::JavaMethod):
(JavaMethod::signature):
(JavaMethod::methodID):
- bridge/jni/JNIBridge.h:
(JSC::Bindings::JavaString::utf8):
(JSC::Bindings::JavaParameter::type):
(JSC::Bindings::JavaMethod::returnType):
- bridge/jni/jni_jsobject.mm:
(JavaJSObject::call):
(JavaJSObject::eval):
(JavaJSObject::getMember):
(JavaJSObject::setMember):
(JavaJSObject::removeMember):
(JavaJSObject::convertJObjectToValue):
- bridge/jni/jsc/JNIBridgeJSC.cpp:
(JavaField::JavaField):
(JavaField::valueFromInstance):
(JavaField::setValueToInstance):
- bridge/jni/jsc/JNIBridgeJSC.h:
(JSC::Bindings::JavaField::type):
- bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::invokeMethod):
- bridge/jni/jsc/JavaStringJSC.h:
(JSC::Bindings::JavaStringImpl::utf8):
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertyDescriptor):
(JSC::RuntimeArray::put):
WebKit/mac:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::enumerate):
WebKit/wx:
- WebFrame.cpp:
(wxWebFrame::RunScript):
WebKit2:
- WebProcess/Plugins/JSNPObject.cpp:
(WebKit::npIdentifierFromIdentifier):
- WebProcess/Plugins/NPJSObject.cpp:
(WebKit::NPJSObject::enumerate):
- WebProcess/Plugins/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):
- 8:47 PM Changeset in webkit [65294] by
-
- 3 edits in trunk/WebKitTools
WebKitTestRunner does not correctly resize WebView for W3C SVG tests
https://bugs.webkit.org/show_bug.cgi?id=43945
Reviewed by Sam Weinig.
- WebKitTestRunner/TestInvocation.cpp:
(WTR::sizeWebViewForCurrentTest):
Allow for a Windows-style path.
- WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::resizeTo):
Call SetWindowPos to resize the view window.
- 8:46 PM Changeset in webkit [65293] by
-
- 2 edits in trunk/WebKit2
WebKit2 needs to initialize SafariTheme
https://bugs.webkit.org/show_bug.cgi?id=43901
Reviewed by Sam Weinig.
- WebProcess/win/WebProcessMainWin.cpp:
(WebKit::initializeSafariTheme):
Copied from old WebKit.
(WebKit::WebProcessMain):
If we're using SafariTheme, initialize it.
- 8:21 PM Changeset in webkit [65292] by
-
- 4 edits in trunk/WebKit2
2010-08-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
WebKit2 crashes when WebFrame outlives WebPage
https://bugs.webkit.org/show_bug.cgi?id=43939
- WebProcess/WebCoreSupport/WebChromeClient.h: (WebKit::WebChromeClient::page): Add this method, to allow WebFrame to retrieve its WebPage following WebCore pointers.
- WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::WebFrame): Do not initialize m_page (it's gone). (WebKit::WebFrame::page): Don't use the data member, get it from WebCore. (WebKit::WebFrame::invalidate): Use method to get page() and null check. (WebKit::WebFrame::isMainFrame): ditto
- WebProcess/WebPage/WebFrame.h:
- 8:11 PM Changeset in webkit [65291] by
-
- 2 edits in trunk/LayoutTests
2010-08-12 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed, fixing the previous commit.
Added PASS CRASH expectation for editing/pasteboard/smart-paste-004.html.
- platform/chromium/test_expectations.txt:
- 8:05 PM Changeset in webkit [65290] by
-
- 2 edits in trunk/LayoutTests
2010-08-12 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed.
Added PASS CRASH expectation for editing/pasteboard/smart-paste-003.html and
editing/pasteboard/smart-paste-004.html reported by japhet.
- platform/chromium/test_expectations.txt:
- 7:29 PM Changeset in webkit [65289] by
-
- 4 edits in trunk/JavaScriptCore
Eeerk! - revert accidentally committed changes in UString!
- JavaScriptCore.exp:
- runtime/UString.cpp:
(JSC::UString::UString):
- runtime/UString.h:
- 7:29 PM Changeset in webkit [65288] by
-
- 2 edits in trunk/WebCore
Speculative build fix for chromium bindings (someone added the old include style!).
- bindings/v8/V8DOMWindowShell.h:
- 6:44 PM Changeset in webkit [65287] by
-
- 4 edits in trunk/WebCore
2010-08-12 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
[Refactoring] TextEvent class has to many flags
https://bugs.webkit.org/show_bug.cgi?id=43893
Turned TextEvent::m_isLineBreak, TextEvent::m_isBacktab, TextEvent::m_isPaste
into single TextEvent::m_inputType enumeration.
No functional change. No new tests.
- dom/TextEvent.cpp: (WebCore::TextEvent::selectInputType): (WebCore::TextEvent::create): (WebCore::TextEvent::createForPlainTextPaste): (WebCore::TextEvent::createForFragmentPaste): (WebCore::TextEvent::TextEvent):
- dom/TextEvent.h: (WebCore::TextEvent::): (WebCore::TextEvent::isLineBreak): (WebCore::TextEvent::isBackTab): (WebCore::TextEvent::isPaste):
- page/EventHandler.cpp: (WebCore::EventHandler::handleTextInputEvent):
- 6:05 PM Changeset in webkit [65286] by
-
- 9 edits in trunk/JavaScriptCore
Change UString constructors to match those in WTF::String.
This changes behaviour of UString((char*)0) to create null
strings, akin to UString() rather than UString::empty().
(This matches String). Remove unused constructors from
UString, and add null-terminated UTF-16 constructor, to
match String. Move String's constructor into the .cpp to
match UString.
Reviewed by Sam Weinig
- JavaScriptCore.exp:
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::calculatedFunctionName):
- runtime/RegExpKey.h:
(JSC::RegExpKey::RegExpKey):
- runtime/SmallStrings.cpp:
(JSC::SmallStrings::createSingleCharacterString):
- runtime/UString.cpp:
(JSC::UString::UString):
- runtime/UString.h:
(JSC::UString::UString):
(JSC::UString::swap):
(JSC::UString::adopt):
(JSC::UString::operator[]):
- wtf/text/WTFString.h:
(WTF::String::String):
(WTF::String::adopt):
(WTF::String::operator[]):
- 5:12 PM Changeset in webkit [65285] by
-
- 5 edits4 deletes in trunk/WebCore
2010-08-12 Kenneth Russell <kbr@google.com>
Reviewed by David Levin.
Delete obsolete CanvasNumberArray
https://bugs.webkit.org/show_bug.cgi?id=38619
Deleted unreferenced code. Built WebKit and Chromium to test.
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- Android.jscbindings.mk:
- Android.mk:
- bindings/js/JSCanvasNumberArrayCustom.cpp: Removed.
- html/canvas/CanvasNumberArray.cpp: Removed.
- html/canvas/CanvasNumberArray.h: Removed.
- html/canvas/CanvasNumberArray.idl: Removed.
- 4:57 PM Changeset in webkit [65284] by
-
- 8 edits in trunk/WebCore
2010-08-12 Anton Muhin <antonm@chromium.org>
Reviewed by Nate Chapin.
[v8] Create callbacks for named access of elements from document object on fly.
https://bugs.webkit.org/show_bug.cgi?id=43725
That should speed up access to methods on document as there is no need to
consult with interceptor before invoking the method.
This reapplies http://trac.webkit.org/changeset/60670 reverted with
http://trac.webkit.org/changeset/63845. The main difference is in treatment
of removed named elements: we don't remove an accessor any more, but leave it.
Therefore any accessor should be able to treat the case when there is no
expando property.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::checkDocumentWrapper): (WebCore::V8DOMWindowShell::updateDocumentWrapperCache): (WebCore::getter): (WebCore::V8DOMWindowShell::namedItemAdded): (WebCore::V8DOMWindowShell::namedItemRemoved):
- bindings/v8/V8DOMWindowShell.h:
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::WrapInShadowObject): (WebCore::V8HTMLDocument::GetNamedProperty): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8):
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::removeItemFromMap):
- 4:30 PM Changeset in webkit [65283] by
-
- 1 edit27 adds in trunk/LayoutTests
2010-08-12 Tony Chang <tony@chromium.org>
Unreviewed, landing google-chrome linux 64 test results.
- platform/google-chrome-linux64/fast/borders/borderRadiusGroove01-expected.checksum: Added.
- platform/google-chrome-linux64/fast/borders/borderRadiusGroove01-expected.png: Added.
- platform/google-chrome-linux64/fast/borders/borderRadiusGroove02-expected.checksum: Added.
- platform/google-chrome-linux64/fast/borders/borderRadiusGroove02-expected.png: Added.
- platform/google-chrome-linux64/fast/borders/borderRadiusRidge01-expected.checksum: Added.
- platform/google-chrome-linux64/fast/borders/borderRadiusRidge01-expected.png: Added.
- platform/google-chrome-linux64/svg/W3C-SVG-1.1/paths-data-12-t-expected.checksum: Added.
- platform/google-chrome-linux64/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
- platform/google-chrome-linux64/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Added.
- platform/google-chrome-linux64/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum: Added.
- platform/google-chrome-linux64/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
- platform/google-chrome-linux64/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
- platform/google-chrome-linux64/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
- platform/google-chrome-linux64/svg/hixie/perf/001-expected.txt: Added.
- platform/google-chrome-linux64/svg/hixie/perf/002-expected.txt: Added.
- platform/google-chrome-linux64/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum: Added.
- platform/google-chrome-linux64/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
- 4:26 PM Changeset in webkit [65282] by
-
- 2 edits in trunk
2010-08-12 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by David Levin.
Add more Chromium-related dependency directories to .gitignore.
https://bugs.webkit.org/show_bug.cgi?id=43940
- .gitignore: Added all existing that are created by update-webkit --chromium.
- 4:23 PM Changeset in webkit [65281] by
-
- 4 edits in trunk/WebCore
2010-08-12 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
Ensure that parser doesn't attach children that have been removed by JavaScript event handlers.
https://bugs.webkit.org/show_bug.cgi?id=43813
This patch re-fixes bug 40742 in a way that keeps allowing HTMLLinkElement
to lazy-attach.
- html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach): Added parent check.
- html/HTMLLinkElement.cpp: Basically undoes changes introduced by r61424.
- html/HTMLLinkElement.h: Ditto.
- 4:18 PM Changeset in webkit [65280] by
-
- 4 edits in trunk
2010-08-12 Justin Schuh <jschuh@chromium.org>
Reviewed by Dumitru Daniliuc.
Clear PluginData's page pointer on page refresh
https://bugs.webkit.org/show_bug.cgi?id=43888
Test: plugins/access-after-page-destroyed.html
- page/Page.cpp: (WebCore::Page::refreshPlugins):
2010-08-12 Justin Schuh <jschuh@chromium.org>
Reviewed by Dumitru Daniliuc.
Clear PluginData's page pointer on page refresh
https://bugs.webkit.org/show_bug.cgi?id=43888
- plugins/access-after-page-destroyed.html:
- 4:14 PM Changeset in webkit [65279] by
-
- 5 edits in trunk
2010-08-12 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
getParameter(STENCIL_VALUE_MASK) (and others) returns the wrong value
https://bugs.webkit.org/show_bug.cgi?id=31842
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getUnsignedLongParameter): Casting from int to unsigned long correctly.
2010-08-12 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
getParameter(STENCIL_VALUE_MASK) (and others) returns the wrong value
https://bugs.webkit.org/show_bug.cgi?id=31842
- fast/canvas/webgl/gl-get-calls-expected.txt: Bring back the commented out STENCIL tests.
- fast/canvas/webgl/gl-get-calls.html: Ditto.
- 4:11 PM MathML 3 testsuite results edited by
- (diff)
- 4:06 PM Changeset in webkit [65278] by
-
- 2 edits in trunk/WebCore
2010-08-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: mimic FireBug's array detection.
https://bugs.webkit.org/show_bug.cgi?id=30974
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- 3:59 PM Changeset in webkit [65277] by
-
- 5 edits in trunk
2010-08-12 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
regression in generateMipmap
https://bugs.webkit.org/show_bug.cgi?id=43873
- html/canvas/WebGLTexture.cpp: (WebCore::WebGLTexture::generateMipmapLevelInfo): should set m_needToUseBlackTexture to false if generateMipmapLevelInfo runs through successfully.
2010-08-12 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
regression in generateMipmap
https://bugs.webkit.org/show_bug.cgi?id=43873
- fast/canvas/webgl/texture-npot-expected.txt: Add more test cases on NPOT/POT texture behaviors.
- fast/canvas/webgl/texture-npot.html: Ditto.
- 3:57 PM Changeset in webkit [65276] by
-
- 3 edits1 add in trunk/WebCore
2010-08-12 Ariya Hidayat <ariya@sencha.com>
Reviewed by David Hyatt.
[Qt] Split TransparencyLayer into its own header file.
https://bugs.webkit.org/show_bug.cgi?id=43935
- WebCore.pro: Include TransparencyLayer.h.
- platform/graphics/qt/GraphicsContextQt.cpp:
- platform/graphics/qt/TransparencyLayer.h: Added. (WebCore::TransparencyLayer::TransparencyLayer): (WebCore::TransparencyLayer::operator=):
- 3:53 PM Changeset in webkit [65275] by
-
- 24 edits in trunk
2010-08-12 François Sausset <François Sausset>
Reviewed by Beth Dakin.
Update the tests to take into account padding changes for the mrow element.
https://bugs.webkit.org/show_bug.cgi?id=43908
- platform/mac/mathml/presentation/fractions-expected.checksum:
- platform/mac/mathml/presentation/fractions-expected.png:
- platform/mac/mathml/presentation/fractions-expected.txt:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/mac/mathml/presentation/roots-expected.checksum:
- platform/mac/mathml/presentation/roots-expected.png:
- platform/mac/mathml/presentation/roots-expected.txt:
- platform/mac/mathml/presentation/row-alignment-expected.checksum:
- platform/mac/mathml/presentation/row-alignment-expected.png:
- platform/mac/mathml/presentation/row-alignment-expected.txt:
- platform/mac/mathml/presentation/row-expected.checksum:
- platform/mac/mathml/presentation/row-expected.png:
- platform/mac/mathml/presentation/row-expected.txt:
- platform/mac/mathml/presentation/subsup-expected.checksum:
- platform/mac/mathml/presentation/subsup-expected.png:
- platform/mac/mathml/presentation/subsup-expected.txt:
- platform/mac/mathml/presentation/underover-expected.checksum:
- platform/mac/mathml/presentation/underover-expected.png:
- platform/mac/mathml/presentation/underover-expected.txt:
2010-08-12 François Sausset <François Sausset>
Reviewed by Beth Dakin.
Horizontal padding should be 0 on mrow elements.
https://bugs.webkit.org/show_bug.cgi?id=43908
Updated tests in /mathml
- css/mathml.css: (mrow, mfenced): (mfenced):
- 3:42 PM Changeset in webkit [65274] by
-
- 2 edits in trunk/WebKitTools
Build break fix.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues): Removed usage
of a variable that doesn't exist in the class.
- 3:40 PM Changeset in webkit [65273] by
-
- 9 edits in trunk
2010-08-12 Aaron Boodman <aa@chromium.org>
Reviewed by David Hyatt.
Make the cascade level of "user" styles configurable
https://bugs.webkit.org/show_bug.cgi?id=43457
- WebCore.exp.in:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector):
- dom/Document.cpp: (WebCore::Document::pageGroupUserSheets):
- page/PageGroup.cpp: (WebCore::PageGroup::addUserStyleSheetToWorld):
- page/PageGroup.h:
- page/UserStyleSheet.h: (WebCore::UserStyleSheet::): (WebCore::UserStyleSheet::UserStyleSheet): (WebCore::UserStyleSheet::level):
2010-08-12 Aaron Boodman <aa@chromium.org>
Reviewed by David Hyatt.
Make the cascade level of "user" styles configurable
https://bugs.webkit.org/show_bug.cgi?id=43457
- src/WebViewImpl.cpp: (WebKit::WebView::addUserStyleSheet):
- 3:32 PM Changeset in webkit [65272] by
-
- 2 edits in trunk/WebCore
Fix qt build break.
- html/ThreadableBlobRegistry.cpp:
(WebCore::postTaskToMainThread):
- 3:16 PM Changeset in webkit [65271] by
-
- 13 edits2 adds in trunk/WebCore
Add ThreadableBlobRegistry to support calling BlobRegistry methods in
main thread.
https://bugs.webkit.org/show_bug.cgi?id=43874
Reviewed by David Levin.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::addBlob):
(WebCore::ScriptExecutionContext::removeBlob):
(WebCore::ScriptExecutionContext::createPublicBlobURL):
(WebCore::ScriptExecutionContext::revokePublicBlobURL):
- dom/ScriptExecutionContext.h:
- html/Blob.cpp:
(WebCore::Blob::Blob):
(WebCore::Blob::~Blob):
(WebCore::Blob::contextDestroyed):
- html/Blob.h:
- html/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::registerBlobURL):
(WebCore::BlobRegistryImpl::unregisterBlobURL):
(WebCore::BlobRegistryImpl::getBlobDataFromURL):
- html/ThreadableBlobRegistry.cpp: Added.
- html/ThreadableBlobRegistry.h: Added.
- 3:03 PM Changeset in webkit [65270] by
-
- 14 edits2 copies1 add in trunk
WebKitTestRunner needs to run tests without using native controls
https://bugs.webkit.org/show_bug.cgi?id=43772
Reviewed by Sam Weinig.
WebKit2:
- Shared/CoreIPCSupport/WebProcessMessageKinds.h:
(WebProcessMessage::):
Add a new message.
- UIProcess/API/C/win/WKContextPrivateWin.h: Added.
Declare WKContextSetShouldPaintNativeControls().
- UIProcess/API/C/win/WKContextWin.cpp: Added.
(WKContextSetShouldPaintNativeControls):
Call the WebContext's setShouldPaintNativeControls().
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
Initialize m_shouldPaintNativeControls.
(WebKit::WebContext::ensureWebProcess):
If we created a web process, call platformSetUpWebProcess().
- UIProcess/WebContext.h:
Declare new functions and a member to store whether we should paint
native controls.
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformSetUpWebProcess):
Stubbed.
- UIProcess/win/WebContextWin.cpp:
(WebKit::WebContext::setShouldPaintNativeControls):
Set m_shouldPaintNativeControls. If we have a valid web process, send a
SetShouldPaintNativeControls message.
(WebKit::WebContext::platformSetUpWebProcess):
Send a SetShouldPaintNativeControls message.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage):
If this is a SetShouldPaintNativeControls message, decode the argument,
and call Settings::setShouldPaintNativeControls().
- win/WebKit2.vcproj:
Add WKContextPrivateWin.h and WKContextWin.cpp to project.
- win/WebKit2Generated.make:
Copy WKContextPrivateWin.h.
WebKitTools:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
Call platformInitializeContext().
- WebKitTestRunner/TestController.h:
Declare platformInitializeContext().
- WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::platformInitializeContext):
Stubbed.
- WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::platformInitializeContext):
Call WKContextSetShouldPaintNativeControls() to disable native control
drawing.
- 2:55 PM Changeset in webkit [65269] by
-
- 2 edits in trunk/WebCore
2010-08-12 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Darin Adler.
generate-bindings.pl should generate warning free code
https://bugs.webkit.org/show_bug.cgi?id=43353
bindings/scripts/CodeGeneratorJS.pm: Suggested parentheses added around && within - 2:49 PM Changeset in webkit [65268] by
-
- 2 edits in trunk/JavaScriptCore
- runtime/UString.h: Removed unneccessary #include.
Reviewed by NOBODY (build fix).
- 2:28 PM Changeset in webkit [65267] by
-
- 14 edits2 deletes in trunk/WebKitTools
WebKitTestRunner should be more aggressive about ensuring consistent state between tests
https://bugs.webkit.org/show_bug.cgi?id=43653
Reviewed by Alexey Proskuryakov.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::InjectedBundle):
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::beginTesting):
(WTR::InjectedBundle::done):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::isTestRunning):
(WTR::InjectedBundle::):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::stopLoading):
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didClearWindowForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::willSetStatusbarText):
(WTR::InjectedBundlePage::willRunJavaScriptAlert):
(WTR::InjectedBundlePage::willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
(WTR::InjectedBundlePage::didBeginEditing):
(WTR::InjectedBundlePage::didEndEditing):
(WTR::InjectedBundlePage::didChange):
(WTR::InjectedBundlePage::didChangeSelection):
Don't do any work if we are not currently running a test.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- WebKitTestRunner/StringFunctions.h:
(WTR::toCF):
Add conversion function for WKURLRef -> CFURLRef
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::runTest):
(WTR::TestController::didFinishLoadForFrame):
- WebKitTestRunner/TestController.h:
(WTR::TestController::):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
- WebKitTestRunner/TestInvocation.h:
Move resetting code to TestController.
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::runUntil):
- WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
- WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::runUntil):
- WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
- WebKitTestRunner/win/WebKitTestRunner.vcproj:
Move runUntil to TestController.
- 2:20 PM Changeset in webkit [65266] by
-
- 3 edits in trunk/JavaScriptCore
Revert changes to ALWAYS_INLINEness of a couple of functions in UString.
This appears to have degraded performance.
Reviewed by Sam Weinig
- runtime/UString.cpp:
(JSC::UString::ascii):
- runtime/UString.h:
(JSC::UString::length):
(JSC::UString::isEmpty):
(JSC::UString::~UString):
- 2:06 PM Changeset in webkit [65265] by
-
- 2 edits in trunk/WebCore
2010-08-11 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
merge MarkupAccumulator and MarkupAccumulatorWrapper
https://bugs.webkit.org/show_bug.cgi?id=43834
Removed MarkupAccumulator and added serializeNodesWithNamespaces to use MarkupAccumulatorWrapper
in both versions of createMarkup. Accumulation of nodes done manually in serializeNodes is
now done by MarkupAccumulatorWrapper as done in the original MarkupAccumulator.
No new tests added since this is a cleanup.
- editing/markup.cpp: (WebCore::MarkupAccumulatorWrapper::MarkupAccumulatorWrapper): Takes vector of nodes and set it to m_nodes. (WebCore::MarkupAccumulatorWrapper::insertOpenTag): Adds node to m_nodes. (WebCore::MarkupAccumulatorWrapper::wrapWithNode): Adds node to m_nodes. (WebCore::serializeNodes): Adding node to nodes is moved into MarkupAccumulatorWrapper. (WebCore::createMarkup): Instantiates MarkupAccumulatorWrapper. (WebCore::serializeNodesWithNamespaces): Renamed from MarkupAccumulator::appendMarkup.
- 1:28 PM Changeset in webkit [65264] by
-
- 2 edits in trunk/JavaScriptCore
2010-08-12 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Antonio Gomes.
[Qt] Fix warnings: unknown conversion type character 'l' in format
https://bugs.webkit.org/show_bug.cgi?id=43359
Qt port doesn't call any printf in String::format(...), consequently
using attribute((format(printf,m,n))) is incorrect and causes
false positive warnings on Windows if you build with MinGW.
Qt port calls QString::vsprintf(...) , which is platform
independent, and handles %lli, %llu and %llx on all platforms.
(http://trac.webkit.org/changeset/35712)
- wtf/text/WTFString.h:
- 1:05 PM Changeset in webkit [65263] by
-
- 17 edits in trunk/LayoutTests
Rebaselining the test results for media controls on Mac to fix
a regression.
Submitted for Victoria Kirst (vrk@google.com).
Reviewed by David Levin.
- platform/chromium-mac/media/audio-controls-rendering-expected.checksum:
- platform/chromium-mac/media/audio-controls-rendering-expected.png:
- platform/chromium-mac/media/controls-after-reload-expected.checksum:
- platform/chromium-mac/media/controls-after-reload-expected.png:
- platform/chromium-mac/media/controls-strict-expected.checksum:
- platform/chromium-mac/media/controls-strict-expected.png:
- platform/chromium-mac/media/video-controls-rendering-expected.checksum:
- platform/chromium-mac/media/video-controls-rendering-expected.png:
- platform/chromium-mac/media/video-display-toggle-expected.checksum:
- platform/chromium-mac/media/video-display-toggle-expected.png:
- platform/chromium-mac/media/video-no-audio-expected.checksum:
- platform/chromium-mac/media/video-no-audio-expected.png:
- platform/chromium-mac/media/video-volume-slider-expected.checksum:
- platform/chromium-mac/media/video-volume-slider-expected.png:
- platform/chromium-mac/media/video-volume-slider-expected.txt:
- platform/chromium/test_expectations.txt:
- 12:43 PM BuildingQtOnLinux edited by
- install dependencies on fedora (diff)
- 12:16 PM Changeset in webkit [65262] by
-
- 53 edits4 adds2 deletes in trunk/WebKit/efl
2010-08-11 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Adding new theme for widgets.
https://bugs.webkit.org/show_bug.cgi?id=43860
Original theme was there for a long time. This is a new
fresh one.
- DefaultTheme/default.edc:
- DefaultTheme/widget/button/button.edc:
- DefaultTheme/widget/button/img_button_focus.png:
- DefaultTheme/widget/button/img_button_hover.png:
- DefaultTheme/widget/button/img_button_normal.png:
- DefaultTheme/widget/button/img_button_press.png:
- DefaultTheme/widget/check/check.edc:
- DefaultTheme/widget/check/img_check_off.png:
- DefaultTheme/widget/check/img_check_off_focus.png:
- DefaultTheme/widget/check/img_check_off_hover.png:
- DefaultTheme/widget/check/img_check_on.png:
- DefaultTheme/widget/check/img_check_on_focus.png:
- DefaultTheme/widget/check/img_check_on_hover.png:
- DefaultTheme/widget/combo/combo.edc:
- DefaultTheme/widget/combo/combo_focus.png:
- DefaultTheme/widget/combo/combo_focus_button.png:
- DefaultTheme/widget/combo/combo_hover.png:
- DefaultTheme/widget/combo/combo_hover_button.png:
- DefaultTheme/widget/combo/combo_normal.png:
- DefaultTheme/widget/combo/combo_normal_button.png:
- DefaultTheme/widget/combo/combo_press.png:
- DefaultTheme/widget/combo/combo_press_button.png:
- DefaultTheme/widget/combo/icon.png:
- DefaultTheme/widget/entry/img_focused.png:
- DefaultTheme/widget/entry/img_hovered.png:
- DefaultTheme/widget/entry/img_normal.png:
- DefaultTheme/widget/file/file_focus.png:
- DefaultTheme/widget/file/file_hover.png:
- DefaultTheme/widget/file/file_normal.png:
- DefaultTheme/widget/file/file_press.png:
- DefaultTheme/widget/radio/img_radio_off.png:
- DefaultTheme/widget/radio/img_radio_off_focus.png:
- DefaultTheme/widget/radio/img_radio_off_hover.png:
- DefaultTheme/widget/radio/img_radio_on.png:
- DefaultTheme/widget/radio/img_radio_on_focus.png:
- DefaultTheme/widget/radio/img_radio_on_hover.png:
- DefaultTheme/widget/radio/radio.edc:
- DefaultTheme/widget/scrollbar/scrollbar.edc:
- DefaultTheme/widget/scrollbar/scrollbar_h.png:
- DefaultTheme/widget/scrollbar/scrollbar_hilight.png: Removed.
- DefaultTheme/widget/scrollbar/scrollbar_knob_h.png:
- DefaultTheme/widget/scrollbar/scrollbar_knob_v.png:
- DefaultTheme/widget/scrollbar/scrollbar_v.png:
- DefaultTheme/widget/search/cancel/cancel_normal_button2.png:
- DefaultTheme/widget/search/decoration/decoration_normal_button.png:
- DefaultTheme/widget/search/field/field_focused.png:
- DefaultTheme/widget/search/field/field_hovered.png:
- DefaultTheme/widget/search/field/field_normal.png:
- DefaultTheme/widget/slider/slider.edc:
- DefaultTheme/widget/slider/slider_fill_h.png: Added.
- DefaultTheme/widget/slider/slider_fill_v.png: Added.
- DefaultTheme/widget/slider/slider_h.png:
- DefaultTheme/widget/slider/slider_hilight.png: Removed.
- DefaultTheme/widget/slider/slider_knob_h.png:
- DefaultTheme/widget/slider/slider_knob_press_h.png: Added.
- DefaultTheme/widget/slider/slider_knob_press_v.png: Added.
- DefaultTheme/widget/slider/slider_knob_v.png:
- DefaultTheme/widget/slider/slider_v.png:
- 12:13 PM Changeset in webkit [65261] by
-
- 2 edits in trunk/WebCore
2010-08-12 Dirk Schulze <krit@webkit.org>
Unreviewed sort of XCode project file.
- WebCore.xcodeproj/project.pbxproj:
- 11:22 AM Changeset in webkit [65260] by
-
- 2 edits in trunk/JavaScriptCore
2010-08-12 Gabor Loki <loki@webkit.org>
Reviewed by Geoffrey Garen.
Fix the array subscript is above array bounds warning in ByteArray on ARM.
https://bugs.webkit.org/show_bug.cgi?id=43358
The warning is very similar to this one: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37861
- wtf/ByteArray.cpp: (WTF::ByteArray::create):
- 11:04 AM Changeset in webkit [65259] by
-
- 2 edits in trunk/LayoutTests
2010-08-12 Nate Chapin <Nate Chapin>
Unreviewed, Chromium expectations tweak.
Remove a duplicate linux debug expectation.
- platform/chromium/test_expectations.txt:
- 10:51 AM Changeset in webkit [65258] by
-
- 2 edits in trunk/WebCore
2010-08-12 Ben Murdoch <benm@google.com>
Reviewed by Pavel Feldman.
InspectorController.h missing InspectorObject forward declaration
https://bugs.webkit.org/show_bug.cgi?id=43913
Build fix so no new tests.
- inspector/InspectorController.h: Adds the necessary forward declaration.
- 10:47 AM Changeset in webkit [65257] by
-
- 1 edit1 add in trunk/WebKit/gtk
Add file I forgot to add in r65255.
- 10:39 AM Changeset in webkit [65256] by
-
- 2 edits in trunk/WebKitTools
2010-08-12 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed.
Adding myself to the committers list.
- Scripts/webkitpy/common/config/committers.py:
- 10:33 AM Changeset in webkit [65255] by
-
- 10 edits in trunk
2010-08-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Use GSettings to save/restore Web Inspector settings
https://bugs.webkit.org/show_bug.cgi?id=43512
- GNUmakefile.am: GSettings rules.
- configure.ac: GSettings infrastructure, and check if we should use it by looking for an appropriate version of GIO.
2010-08-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Use GSettings to save/restore Web Inspector settings
https://bugs.webkit.org/show_bug.cgi?id=43512
- wtf/gobject/GRefPtr.cpp: Added support for GVariant, used by our GSettings support. (WTF::refGPtr): (WTF::derefGPtr):
- wtf/gobject/GRefPtr.h:
WebKit/gtk
2010-08-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Use GSettings to save/restore Web Inspector settings
https://bugs.webkit.org/show_bug.cgi?id=43512
Use GSettings to save/restore settings used by the Web Inspector.
A few helper functions were added to have settings that use
boolean values be actual booleans, and also to conform with the
GSettings naming requirements for keys.
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::toGSettingName): (WebKit::truthStringFromVariant): (WebKit::variantFromTruthString): (WebKit::InspectorClient::populateSetting): (WebKit::InspectorClient::storeSetting):
- org.webkit.gtk.gschema.xml: Added.
- webkit/webkitprivate.cpp: (inspectorGSettings): (webkit_init):
- webkit/webkitprivate.h:
- 10:32 AM Changeset in webkit [65254] by
-
- 2 edits1 copy1 delete in trunk/WebKitTools
2010-08-12 Hayato Ito <hayato@chromium.org>
Reviewed by Tony Chang.
Merge pretty printers for gdb.
https://bugs.webkit.org/show_bug.cgi?id=43850
We need to update webcore.py because basic string classes have moved to WTF from WebCore.
It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
webcore.py is left for backward compatibility.
- gdb/webcore.py:
- gdb/webkit.py: Added.
- gdb/wtf.py: Removed.
- 10:16 AM Changeset in webkit [65253] by
-
- 4 edits in trunk
2010-08-12 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Making CMake keep track of theme dependencies.
https://bugs.webkit.org/show_bug.cgi?id=43862
Removing unused macro GENERATE_EDJ.
- cmake/WebKitEfl.cmake:
2010-08-12 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Making CMake keep track of theme dependencies.
https://bugs.webkit.org/show_bug.cgi?id=43862
Adding theme source files and images as dependencies of the theme.
- CMakeListsEfl.txt:
- 10:11 AM QtWebKitTriageRoster edited by
- (diff)
- 10:10 AM MathML Goals edited by
- (diff)
- 10:10 AM MathML Goals edited by
- (diff)
- 10:03 AM Changeset in webkit [65252] by
-
- 2 edits in trunk/LayoutTests
2010-08-12 Nate Chapin <Nate Chapin>
Unreviewed, Chromium expectations tweak.
Comment out svg/hittest/svg-rect-hit.html, as the test
was not landed with the relevant patch.
- platform/chromium/test_expectations.txt:
- 10:02 AM MathML edited by
- (diff)
- 10:00 AM MathML Status edited by
- (diff)
- 9:59 AM Changeset in webkit [65251] by
-
- 3 edits in trunk/WebKit/chromium
2010-08-12 John Gregg <johnnyg@google.com>
Reviewed by Kent Tamura.
[chromium] Add Notification::detachPresenter to the WebKit API.
https://bugs.webkit.org/show_bug.cgi?id=43659
- public/WebNotification.h:
- src/WebNotification.cpp: (WebKit::WebNotification::detachPresenter):
- 9:38 AM MathML edited by
- (diff)
- 9:35 AM MathML edited by
- (diff)
- 9:33 AM Changeset in webkit [65250] by
-
- 4 edits2 adds in trunk/WebKitTools
2010-08-11 Tony Chang <tony@chromium.org>
Reviewed by David Levin.
[chromium] add google-chrome layout test result directories
https://bugs.webkit.org/show_bug.cgi?id=43889
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/factory.py:
- Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
- Scripts/webkitpy/layout_tests/test_types/image_diff.py:
- 9:32 AM MathML Status created by
- 9:20 AM MathML edited by
- (diff)
- 9:19 AM MathML edited by
- (diff)
- 8:58 AM Changeset in webkit [65249] by
-
- 2 edits in trunk/WebCore
2010-08-12 Hui Huang <hui.2.huang@nokia.com>
Reviewed by Eric Seidel.
m_windowRect is not updated because parent of PluginView is not
set when updatePluginWidget is called. plugin gets wrong window
size on setwindow.
https://bugs.webkit.org/show_bug.cgi?id=43635
- plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::setParent):
- 8:37 AM Changeset in webkit [65248] by
-
- 27 edits1 add1 delete in trunk
2010-08-12 Pavel Feldman <pfeldman@chromium.org>
Not reviewed, re-apply r65241 and 65243.
Web Inspector: brush up object proxies, introduce remote object model.
https://bugs.webkit.org/show_bug.cgi?id=43847
- 8:26 AM Changeset in webkit [65247] by
-
- 8 edits in trunk
2010-08-11 Stephen White <senorblanco@chromium.org>
Reviewed by David Levin.
Add support for BGRA pixel format to GraphicsContext3D.
https://bugs.webkit.org/show_bug.cgi?id=43858
Although this has been standard in desktop GL since 1.2, it's an
extension in GL ES 2.0, so a query function is provided to check
for support. The DefaultImpl returns false, since it does not yet
implement the TexImage2D internalFormat quirks.
- public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::supportsBGRA):
- src/GraphicsContext3D.cpp:
- src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::supportsBGRA):
- src/WebGraphicsContext3DDefaultImpl.h:
2010-08-11 Stephen White <senorblanco@chromium.org>
Reviewed by David Levin.
Add support for BGRA pixel format to GraphicsContext3D.
https://bugs.webkit.org/show_bug.cgi?id=43858
Although this has been standard in desktop GL since 1.2, it's an
extension in GL ES 2.0, so a query function is provided to check
for support. Since they differ on semantics (GL ES 2.0 requires
TexImage2D()'s format and internalFormat to match, while desktop GL
will not accept BGRA as an internalFormat), the stub implementation
returns false until these quirks have been implemented and tested on
each port.
- platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::supportsBGRA): Add implementation for non-chromium platforms which returns false.
- platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::): Add query function (supportsBGRA()) and the BGRA_EXT token.
- 8:11 AM Changeset in webkit [65246] by
-
- 3 edits in trunk
2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65225.
http://trac.webkit.org/changeset/65225
https://bugs.webkit.org/show_bug.cgi?id=43918
Broke EFL port build (Requested by acidx on #webkit).
- cmake/WebKitGenerators.cmake:
- cmake/WebKitMacros.cmake:
- 8:04 AM Changeset in webkit [65245] by
-
- 26 edits1 add1 delete in trunk
2010-08-12 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Rolling out r65241 and 65243 for breaking inspector tests.
- 7:38 AM MathML 3 testsuite results edited by
- (diff)
- 7:20 AM MathML 3 testsuite results edited by
- (diff)
- 7:11 AM MathML 3 testsuite results edited by
- (diff)
- 7:01 AM MathML 3 testsuite results edited by
- (diff)
- 6:40 AM Changeset in webkit [65244] by
-
- 2 edits3 adds in trunk/LayoutTests
2010-08-12 Nate Chapin <Nate Chapin>
Update chromium's test_expectations.txt and provide new baselines for
http://trac.webkit.org/changeset/65229.
(Text-only baseline for win/linux because there are real regressions in the
image results. See https://bugs.webkit.org/show_bug.cgi?id=43912)
- platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
- platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
- platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 6:38 AM Changeset in webkit [65243] by
-
- 1 edit1 add in trunk/WebCore
2010-08-12 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Adding the file missing in r65241.
- inspector/front-end/RemoteObject.js: Added. (WebInspector.RemoteObjectId): (WebInspector.RemoteObject): (WebInspector.RemoteObject.fromPrimitiveValue): (WebInspector.RemoteObject.fromNode): (WebInspector.RemoteObject.fromPayload): (WebInspector.RemoteObject.type): (WebInspector.RemoteObject.prototype.get objectId): (WebInspector.RemoteObject.prototype.get type): (WebInspector.RemoteObject.prototype.get description): (WebInspector.RemoteObject.prototype.get hasChildren): (WebInspector.RemoteObject.prototype.isError): (WebInspector.RemoteObject.prototype.getPropertyValueDescriptions): (WebInspector.RemoteObject.prototype.getOwnProperties):
- 6:37 AM Changeset in webkit [65242] by
-
- 2 edits in trunk/JavaScriptCore
The scratch register should be saved in YARR with ARM JIT
https://bugs.webkit.org/show_bug.cgi?id=43910
Reviewed by Simon Hausmann.
Reported by Jocelyn Turcotte.
- yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::generateEnter):
(JSC::Yarr::RegexGenerator::generateReturn):
- 6:31 AM Changeset in webkit [65241] by
-
- 26 edits1 delete in trunk
2010-08-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: brush up object proxies, introduce remote object model.
https://bugs.webkit.org/show_bug.cgi?id=43847
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.CssInHeadRule.prototype.doRun): (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.doEvalInWindow): (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult): (WebInspector.ConsoleView.prototype._enterKeyPressed): (WebInspector.ConsoleView.prototype._format): (WebInspector.ConsoleView.prototype._formatnode): (WebInspector.ConsoleView.prototype._formatarray): (WebInspector.ConsoleView.prototype._formatAsArrayEntry): (WebInspector.ConsoleMessage.prototype._format): (WebInspector.ConsoleCommandResult):
- inspector/front-end/DOMAgent.js: (WebInspector.DOMNode):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
- inspector/front-end/EventListenersSidebarPane.js:
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.update): (WebInspector.ObjectPropertiesSection.prototype.updateProperties): (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): (WebInspector.ObjectPropertyTreeElement.prototype.update): (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
- inspector/front-end/ObjectProxy.js: Removed.
- inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback):
- inspector/front-end/RemoteObject.js: Added. (WebInspector.RemoteObjectId): (WebInspector.RemoteObject): (WebInspector.RemoteObject.fromPrimitiveValue): (WebInspector.RemoteObject.fromErrorMessage): (WebInspector.RemoteObject.fromNode): (WebInspector.RemoteObject.fromPayload): (WebInspector.RemoteObject.type): (WebInspector.RemoteObject.prototype.get objectId): (WebInspector.RemoteObject.prototype.get type): (WebInspector.RemoteObject.prototype.get description): (WebInspector.RemoteObject.prototype.get hasChildren): (WebInspector.RemoteObject.prototype.isError): (WebInspector.RemoteObject.prototype.getPropertyValueDescriptions): (WebInspector.RemoteObject.prototype.getOwnProperties): (WebInspector.RemoteObject.prototype.getProperties.remoteObjectBinder): (WebInspector.RemoteObjectProperty):
- inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper): (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup.evaluateCallback): (WebInspector.SourceFrame.prototype._showPopup): (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
- inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update): (WebInspector.WatchExpressionTreeElement.prototype.update):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.log.logMessage): (WebInspector.log):
- inspector/front-end/utilities.js:
2010-08-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: brush up object proxies, introduce remote object model.
https://bugs.webkit.org/show_bug.cgi?id=43847
- inspector/console-dir-expected.txt:
- inspector/console-dir-global.html:
- inspector/console-dir.html:
- inspector/console-format-collections-expected.txt:
- inspector/console-format-expected.txt:
- 6:30 AM MathML 3 testsuite results edited by
- (diff)
- 6:27 AM Changeset in webkit [65240] by
-
- 2 edits in trunk/WebCore
2010-08-12 Ben Murdoch <benm@google.com>
Reviewed by Steve Block.
V8 code generator does not add V8BindingMacros.h include in all places it is needed
https://bugs.webkit.org/show_bug.cgi?id=43907
Adds the V8BindingMacros.h header before using the STRING_TO_V8PARAMETER_EXCEPTION_BLOCK
macro.
Build fix so no new tests.
- bindings/scripts/CodeGeneratorV8.pm: include the header at the right time.
- 6:23 AM MathML 3 testsuite results edited by
- (diff)
- 6:09 AM Changeset in webkit [65239] by
-
- 1 edit1 add in trunk/LayoutTests
2010-08-12 Philippe Normand <pnormand@igalia.com>
Unreviewed.
Media test baseline forgotten in r65224.
- platform/gtk/media/audio-no-installed-engines-expected.txt: Added.
- 6:04 AM MathML 3 testsuite results edited by
- (diff)
- 5:47 AM MathML 3 testsuite results edited by
- (diff)
- 5:37 AM MathML 3 testsuite results edited by
- (diff)
- 5:36 AM Changeset in webkit [65238] by
-
- 3 edits in trunk/WebKit/chromium
2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65181.
http://trac.webkit.org/changeset/65181
https://bugs.webkit.org/show_bug.cgi?id=43909
It broke 35 layout tests fail on chromium-win (Requested by
hamaji on #webkit).
- public/WebFrameClient.h:
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
- 5:31 AM MathML 3 testsuite results edited by
- (diff)
- 5:04 AM Changeset in webkit [65237] by
-
- 2 edits in trunk/LayoutTests
2010-08-12 Shinichiro Hamaji <hamaji@chromium.org>
Update chromium's test_expectations.txt
- platform/chromium/test_expectations.txt: Two failing video related tests.
- 5:00 AM Changeset in webkit [65236] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] animations/suspend-resume-animation.html fails
https://bugs.webkit.org/show_bug.cgi?id=43905
- platform/qt/Skipped: animations/suspend-resume-animation.html skipped until fix.
- 4:52 AM Changeset in webkit [65235] by
-
- 2 edits in trunk/LayoutTests
2010-08-12 Shinichiro Hamaji <hamaji@chromium.org>
Update chromium's test_expectations.txt
- platform/chromium/test_expectations.txt: animations/play-state is flaky on Mac
- 4:44 AM MathML 3 testsuite results edited by
- (diff)
- 4:37 AM MathML 3 testsuite results edited by
- (diff)
- 4:10 AM Changeset in webkit [65234] by
-
- 19 edits2 deletes in trunk
2010-08-12 Jeremy Orlow <jorlow@chromium.org>
Revert for now
https://bugs.webkit.org/show_bug.cgi?id=43794
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- page/GroupSettings.cpp: Removed.
- page/GroupSettings.h: Removed.
- page/PageGroup.cpp: (WebCore::PageGroup::PageGroup): (WebCore::PageGroup::localStorage):
- page/PageGroup.h:
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setLocalStorageQuota): (WebCore::Settings::setLocalStorageDatabasePath):
- page/Settings.h: (WebCore::Settings::localStorageQuota): (WebCore::Settings::localStorageDatabasePath):
2010-08-12 Jeremy Orlow <jorlow@chromium.org>
Revert for now
https://bugs.webkit.org/show_bug.cgi?id=43794
- WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _preferencesChangedNotification:]):
2010-08-12 Jeremy Orlow <jorlow@chromium.org>
Revert for now
https://bugs.webkit.org/show_bug.cgi?id=43794
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
2010-08-12 Jeremy Orlow <jorlow@chromium.org>
Revert for now
https://bugs.webkit.org/show_bug.cgi?id=43794
- WebView.cpp: (WebView::initWithFrame):
- 3:37 AM Changeset in webkit [65233] by
-
- 1 edit1 delete in trunk/LayoutTests
2010-08-12 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Delete a test that slipped in by accident.
- svg/zoom/page/zoom-mask.svg: Removed.
- 3:30 AM Changeset in webkit [65232] by
-
- 5 edits in trunk/WebCore
2010-08-12 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Follow up to Jeremys fix, just remove the context parameter, it's not needed anymore.
- rendering/RenderSVGResourceGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient):
- rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyResource):
- rendering/SVGImageBufferTools.cpp: (WebCore::SVGImageBufferTools::createImageBuffer):
- rendering/SVGImageBufferTools.h:
- 3:27 AM Changeset in webkit [65231] by
-
- 2 edits in trunk/WebCore
2010-08-12 Jeremy Orlow <jorlow@chromium.org>
Build fix.
- rendering/SVGImageBufferTools.cpp: (WebCore::SVGImageBufferTools::createImageBuffer):
- 3:21 AM Changeset in webkit [65230] by
-
- 2 edits in trunk/WebKit/win
2010-08-12 Jeremy Orlow <jorlow@chromium.org>
Build fix. Matches solutions in qt and mac ports for
https://bugs.webkit.org/show_bug.cgi?id=43794
- WebView.cpp: (WebView::initWithFrame):
- 3:11 AM Changeset in webkit [65229] by
-
- 18 edits7 adds in trunk
2010-08-12 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
SVG masking performance very slow
https://bugs.webkit.org/show_bug.cgi?id=43622
Create ImageBuffers only as large as the final rendered size on screen. Only gradient on text on CG handled this correctly so far.
Refactored the code into a new SVGImageBufferTools class, and use the code from RenderSVGResourceMasker -> makes the IE9 demo SVG dice usable.
Clippers, Patterns and Filters remain to be converted.
Test: svg/zoom/page/zoom-mask-with-percentages.svg
- Android.mk: Add SVGImageBufferTools.* to build.
- CMakeLists.txt: Ditto.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- rendering/RenderSVGAllInOne.cpp: Ditto.
- rendering/RenderSVGResourceGradient.cpp: Refactored CG gradient specific "create image buffer in absolute coordinates" code into SVGImageBufferTools class. (WebCore::createMaskAndSwapContextForTextGradient): (WebCore::clipToTextMask): (WebCore::RenderSVGResourceGradient::applyResource):
- rendering/RenderSVGResourceMasker.cpp: Use new SVGImageBufferTools class, to avoid pixelation when zooming and to create image buffers as big as the final rendered size on screen, not more. (WebCore::RenderSVGResourceMasker::invalidateClients): (WebCore::RenderSVGResourceMasker::applyResource): (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage): (WebCore::RenderSVGResourceMasker::calculateMaskContentRepaintRect): (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
- rendering/RenderSVGResourceMasker.h:
- rendering/SVGImageBufferTools.cpp: Added. (WebCore::SVGImageBufferTools::absoluteTransformFromContext): (WebCore::SVGImageBufferTools::createImageBuffer): (WebCore::SVGImageBufferTools::clipToImageBuffer):
- rendering/SVGImageBufferTools.h: Added. (WebCore::SVGImageBufferTools::SVGImageBufferTools): (WebCore::SVGImageBufferTools::~SVGImageBufferTools):
2010-08-12 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
SVG masking performance very slow
https://bugs.webkit.org/show_bug.cgi?id=43622
Update mask results, now that mask image buffers are as big as the finaled rendered size on screen.
Add new test covering zooming into masks, to show that it doesn't pixelate anymore.
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
- platform/mac/svg/batik/masking/maskRegions-expected.checksum:
- platform/mac/svg/batik/masking/maskRegions-expected.png:
- platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
- platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
- platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
- platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
- platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
- svg/zoom/page/zoom-mask-with-percentages.svg: Added.
- 3:03 AM Changeset in webkit [65228] by
-
- 17 edits2 adds in trunk
2010-08-10 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
Some settings are linked to the PageGroup not the Page. Create a new class for those.
https://bugs.webkit.org/show_bug.cgi?id=43794
Since persistient storage is shared between pages, there's no way to modify
some settings related to it on a per page basis. As such, it's not technically
correct for these settings to be on the Page's settings. Create a new class
called GroupSettings, move the 2 group-wide local storage settings there, and
add a new setting for IndexedDB's path (which is prompting this change).
No behavior has changed, so no tests.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- page/PageGroup.cpp: (WebCore::PageGroup::PageGroup): (WebCore::PageGroup::localStorage):
- page/PageGroup.h: (WebCore::PageGroup::groupSettings):
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setSessionStorageQuota):
- page/Settings.h:
2010-08-10 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
Some settings are linked to the PageGroup not the Page. Create a new class for those.
https://bugs.webkit.org/show_bug.cgi?id=43794
Change WebView to use the new GroupSettings class rather than Settings for the
settings that moved. This is sub-optimal since the settings aren't really
per-view, but we can't really change the API at this point.
- WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _preferencesChangedNotification:]):
2010-08-11 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
Some settings are linked to the PageGroup not the Page. Create a new class for those.
https://bugs.webkit.org/show_bug.cgi?id=43794
Change WebSettings to use the new GroupSettings class rather than Settings for the
settings that moved. This is sub-optimal since the settings aren't really
per-view, but I don't see how we can change the API at this point.
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
- 2:43 AM Changeset in webkit [65227] by
-
- 2 edits in trunk/WebCore
[Qt] Decode images directly to QPixmap
https://bugs.webkit.org/show_bug.cgi?id=40797
Patch by Benjamin Poulain <benjamin.poulain@nokia.com> on 2010-08-12
Reviewed by Simon Hausmann.
Use the new API of Qt 4.7 to decode data from the image
reader directly to QPixmap.
This allow us to use JDCT_IFAST when decoding jpeg images
to pixmap, and to decode animated GIF images, while still
using in-place conversion of color space.
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::internalHandleCurrentImage):
- 2:41 AM Changeset in webkit [65226] by
-
- 12 edits in trunk
2010-07-14 Marcus Bulach <bulach@chromium.org>
Reviewed by Darin Adler.
Removes DontCheckEnums from some IDLs and fixes the corresponding enums.
https://bugs.webkit.org/show_bug.cgi?id=42278
This is a follow-up to https://bugs.webkit.org/show_bug.cgi?id=42250: it fixes some IDL/.h and enables generating compile-time checks for enums.
- fast/events/init-events-expected.txt:
- fast/events/script-tests/init-events.js: (createEventHelper): splits event creation so that we can test without init. (testInitEvent): adds test for OverflowEvent creation.
2010-07-14 Marcus Bulach <bulach@chromium.org>
Reviewed by Darin Adler.
Removes DontCheckEnums from some IDLs and fixes the corresponding enums.
https://bugs.webkit.org/show_bug.cgi?id=42278
This is a follow-up to https://bugs.webkit.org/show_bug.cgi?id=42250: it fixes some IDL/.h and enables generating compile-time checks for enums.
Tests: idls should generate valid code.
- dom/Node.h: (WebCore::Node::):
- dom/Node.idl:
- dom/OverflowEvent.h: (WebCore::OverflowEvent::):
- dom/OverflowEvent.idl:
- html/FileReader.cpp: (WebCore::FileReader::readyState):
- html/FileReader.h: (WebCore::FileReader::):
- html/FileReader.idl:
- 1:50 AM Changeset in webkit [65225] by
-
- 3 edits in trunk
2010-08-12 Patrick Gansterer <paroga@paroga.com>
Reviewed by Nikolas Zimmermann.
[CMake] Cleanup generator code.
https://bugs.webkit.org/show_bug.cgi?id=39164
- cmake/WebKitGenerators.cmake:
- cmake/WebKitMacros.cmake:
- 1:24 AM Changeset in webkit [65224] by
-
- 2 edits8 adds in trunk/LayoutTests
2010-08-12 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] new media tests baselines needed
https://bugs.webkit.org/show_bug.cgi?id=42444
Visually check those tests, they seemed fine to me so I added
their baselines.
- platform/gtk/Skipped:
- platform/gtk/media/audio-controls-rendering-expected.txt: Added.
- platform/gtk/media/video-display-toggle-expected.txt: Added.
- platform/gtk/media/video-empty-source-expected.txt: Added.
- platform/gtk/media/video-layer-crash-expected.txt: Added.
- platform/gtk/media/video-no-audio-expected.txt: Added.
- platform/gtk/media/video-transformed-expected.txt: Added.
- platform/gtk/media/video-zoom-controls-expected.txt: Added.
- platform/gtk/media/video-zoom-expected.txt: Added.
- 1:06 AM Changeset in webkit [65223] by
-
- 2 edits in trunk/WebCore
2010-08-12 Alejandro G. Castro <alex@igalia.com>
Reviewed by David Levin.
The #if clause enabling a feature should avoid the all includes of
the feature
https://bugs.webkit.org/show_bug.cgi?id=43866
Modified the position of the guard to avoid including all the
headers if the feature controlling the guard is not enabled.
- dom/make_names.pl:
- 12:18 AM Changeset in webkit [65222] by
-
- 8 edits in trunk
2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65221.
http://trac.webkit.org/changeset/65221
https://bugs.webkit.org/show_bug.cgi?id=43896
Broke snow leopard build. (Requested by dave_levin on
#webkit).
- platform/graphics/GraphicsContext3D.cpp:
- platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::):
2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65221.
http://trac.webkit.org/changeset/65221
https://bugs.webkit.org/show_bug.cgi?id=43896
Broke snow leopard build. (Requested by dave_levin on
#webkit).
- public/WebGraphicsContext3D.h:
- src/GraphicsContext3D.cpp:
- src/WebGraphicsContext3DDefaultImpl.cpp:
- src/WebGraphicsContext3DDefaultImpl.h:
- 12:00 AM Changeset in webkit [65221] by
-
- 8 edits in trunk
2010-08-11 Stephen White <senorblanco@chromium.org>
Reviewed by David Levin.
Add support for BGRA pixel format to GraphicsContext3D.
https://bugs.webkit.org/show_bug.cgi?id=43858
Although this has been standard in desktop GL since 1.2, it's an
extension in GL ES 2.0, so a query function is provided to check
for support. Since they differ on semantics (GL ES 2.0 requires
TexImage2D()'s format and internalFormat to match, while desktop GL
will not accept BGRA as an internalFormat), the stub implementation
returns false until these quirks have been implemented and tested on
each port.
- platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::supportsBGRA): Add implementation for non-chromium platforms which returns false.
- platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::): Add query function (supportsBGRA()) and the BGRA_EXT token.
2010-08-11 Stephen White <senorblanco@chromium.org>
Reviewed by David Levin.
Add support for BGRA pixel format to GraphicsContext3D.
https://bugs.webkit.org/show_bug.cgi?id=43858
Although this has been standard in desktop GL since 1.2, it's an
extension in GL ES 2.0, so a query function is provided to check
for support. The DefaultImpl returns false, since it does not yet
implement the TexImage2D internalFormat quirks.
- public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::supportsBGRA):
- src/GraphicsContext3D.cpp:
- src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::supportsBGRA):
- src/WebGraphicsContext3DDefaultImpl.h:
Aug 11, 2010:
- 11:42 PM Changeset in webkit [65220] by
-
- 4 edits in trunk/WebCore
2010-08-11 Satish Sampath <satish@chromium.org>
Reviewed by Kent Tamura.
Handle clicks and recognition events for the speech input button
https://bugs.webkit.org/show_bug.cgi?id=43857
- rendering/RenderInputSpeech.cpp: (WebCore::RenderInputSpeech::paintInputFieldSpeechButton): Selects the image based on current state.
- rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::set_state): Switch to a new state and update the UI. (WebCore::InputFieldSpeechButtonElement::didCompleteRecording): (WebCore::InputFieldSpeechButtonElement::didCompleteRecognition):
- rendering/TextControlInnerElements.h: (WebCore::InputFieldSpeechButtonElement::): (WebCore::InputFieldSpeechButtonElement::state):
- 11:31 PM Changeset in webkit [65219] by
-
- 2 edits in trunk/WebCore
2010-08-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
REGRESSION(65135): format specifier warnings
https://bugs.webkit.org/show_bug.cgi?id=43876
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::appendToBuffer): cast size_t to unsigned long for %lu. (WebCore::WebSocketChannel::processBuffer): cast size_t to unsigned long for %lu.
- 11:02 PM Changeset in webkit [65218] by
-
- 2 edits in trunk/WebCore
[wx] Build fix, don't generate WebDOMEventTarget.h/.cpp as we use the ones in bindings/cpp.
- 10:50 PM Changeset in webkit [65217] by
-
- 2 edits in trunk/WebCore
2010-08-11 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Make PendingScript copyable so that it can be stored in containers
https://bugs.webkit.org/show_bug.cgi?id=43875
This will be useful for storing PendingScripts in a Vector or Deque for
async and defer scripts.
No new tests because no functional changes.
- dom/PendingScript.h: (WebCore::PendingScript::PendingScript): (WebCore::PendingScript::operator=):
- 9:35 PM Changeset in webkit [65216] by
-
- 2 edits in trunk/WebKitTools
2010-08-11 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Disable accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=43894
Disable accelerated compositing because DRT is not ready for
it. This change fixes hundreds of test crashes on Windows and
Linux.
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings):
- 8:56 PM Changeset in webkit [65215] by
-
- 4 edits in trunk
2010-08-11 Victoria Kirst <vrk@google.com>
Reviewed by David Levin.
Fixing a regression in the UI for Mac default audio/video controls.
https://bugs.webkit.org/show_bug.cgi?id=43750
- rendering/RenderThemeChromiumMac.h:
- rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderContainer): (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb): (WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton):
- 8:53 PM Changeset in webkit [65214] by
-
- 2 edits in trunk/LayoutTests
Add more files to the WebKit2 skipped list.
Rubber-stamped by Jon Honeycutt.
- platform/mac-wk2/Skipped:
- 8:13 PM Changeset in webkit [65213] by
-
- 5 edits in trunk
2010-08-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTML TreeBuilder hits ASSERT in fragment case with insertAdjacentHTML and colgroup
https://bugs.webkit.org/show_bug.cgi?id=43758
- html5lib/runner-expected-html5.txt:
2010-08-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
HTML TreeBuilder hits ASSERT in fragment case with insertAdjacentHTML and colgroup
https://bugs.webkit.org/show_bug.cgi?id=43758
This patch conditionalizes some LegacyHTMLTreeBuilder-specific code in
HTMLElement::createContextualFragment that interferes with the new
HTMLTreeBuilder. Doing that exposes the above ASSERT, which I've fixed
in this patch too. Fixing that ASSERT involved a small refactoring in
ExternalCharacterTokenBuffer.
- html/HTMLElement.cpp: (WebCore::HTMLElement::createContextualFragment):
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeadingWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingNonWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeading): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeading): (WebCore::HTMLTreeBuilder::processCharacterBuffer):
- 7:55 PM Changeset in webkit [65212] by
-
- 4 edits in trunk
2010-08-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Conditionalize wrong fragment parsing code to pass more HTML5lib tests
https://bugs.webkit.org/show_bug.cgi?id=43877
Test progression.
- html5lib/runner-expected-html5.txt:
2010-08-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Conditionalize wrong fragment parsing code to pass more HTML5lib tests
https://bugs.webkit.org/show_bug.cgi?id=43877
This code exists to support the LegacyHTMLTreeBuilder. Unfortunately,
it causes problems for the new HTMLTreeBuilder (which is more
self-contained).
- dom/Element.cpp: (WebCore::Element::createContextualFragment):
- 7:37 PM Changeset in webkit [65211] by
-
- 4 edits in trunk/LayoutTests
2010-08-11 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
fast/encoding/japanese-encoding-mix.html fails on Tiger after enabling HTML5 Lexer
https://bugs.webkit.org/show_bug.cgi?id=40725
Qt and Tiger seem to have encoding problems that swallow the --
characters that terminate the comment. We can avoid those problems by
inserting a space before the -->. We're losing coverage of these
issues, but I'm not sure we should be in the business of debugging
these encoders unless there's a security problem.
Thanks to ap for investigating and finding this workaround.
- fast/encoding/japanese-encoding-mix.html:
- platform/mac-tiger/Skipped:
- platform/qt/Skipped:
- 7:36 PM Changeset in webkit [65210] by
-
- 4 edits in trunk/WebKit2
Add SPI to stop loading from the InjectedBundle.
Reviewed by Gavin Barraclough.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageStopLoading):
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
- WebProcess/WebPage/WebPage.h:
- 7:09 PM Changeset in webkit [65209] by
-
- 4 edits in trunk/WebKit/gtk
2010-08-11 Joone Hur <joone@kldp.org>
Reviewed by Martin Robinson.
[GTK] Last Hangul letter is typed again when a composition is finished with mouse press
https://bugs.webkit.org/show_bug.cgi?id=40518
When a mouse press fires during a IME composition, the current composition character
can be entered twice at the previous editing position and a new editing position.
Because the IME commit signal is emitted after the mouse press event.
This patch allows to prevent the commit signal during a composition when a mouse press fires.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::imContextCommitted): (WebKit::EditorClient::handleInputMethodKeydown): Allow to accept the next composition commit. (WebKit::EditorClient::handleInputMethodMousePress): Added for handling IME when a mouse press fires. (WebKit::EditorClient::EditorClient): Initialize m_preventNextCompositionCommit
- WebCoreSupport/EditorClientGtk.h: (WebKit::EditorClient::preventNextCompositionCommit): Added for checking whether skipping a commit.
- webkit/webkitwebview.cpp: (webkit_web_view_button_press_event): Call handleInputMethodMousePress()
- 7:05 PM Changeset in webkit [65208] by
-
- 8 edits3 adds in trunk
2010-08-11 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
Can't unbold text in div in font-weight span
https://bugs.webkit.org/show_bug.cgi?id=26871
The bug was caused by removeInlineStyle not being able to include styled inline nodes around the start.
Solved this problem by pushing down all inline styles instead of just text-decorations.
This approach allows removeInlineStyle to remove styled ancestors properly and generates compact markups.
Test: editing/style/push-down-inline-styles.html
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeCSSStyle): No longer removes attributes or node when mode == RemoveNone. (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): Calls shouldRemoveInlineStyleFromElement to determine the highest ancestor whose style needs to be pushed down. (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Renamed from extractTextDecorationStyle. Extracts all inline CSS properties specified instead of just text decorations. (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Renamed from applyTextDecorationStyle. Applies inline styles using addInlineStyleIfNeeded or adds inline CSS values. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Renamed from pushDownTextDecorationStyleAroundNode. (WebCore::ApplyStyleCommand::removeInlineStyle): Calls pushDownTextDecorationStyleAroundNode.
- editing/ApplyStyleCommand.h:
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): Prevents moveParagraph from preserving the style of an empty paragraph when merged with the previous paragraph because we don't use that style anyways.
2010-08-11 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
Can't unbold text in div in font-weight span
https://bugs.webkit.org/show_bug.cgi?id=26871
Added a test to push down inline styles to the leaves of DOM tree.
- editing/deleting/delete-br-011-expected.txt: Removed redundant style spans.
- editing/execCommand/empty-span-removal-expected.txt: Removed a span without any attributes.
- editing/style/push-down-inline-styles-expected.txt: Added.
- editing/style/push-down-inline-styles.html: Added.
- editing/style/script-tests/push-down-inline-styles.js: Added. (testSingleToggle):
- 6:56 PM Changeset in webkit [65207] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix.
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/Forward.h:
- 6:50 PM Changeset in webkit [65206] by
-
- 2 edits in trunk/LayoutTests
2010-08-11 Shinichiro Hamaji <hamaji@chromium.org>
Chromium test_expectations update.
- platform/chromium/test_expectations.txt: http/tests/storage/callbacks-are-called-in-correct-context.html is SLOW, not PASS TIMEOUT
- 6:27 PM Changeset in webkit [65205] by
-
- 2 edits in trunk/WebCore
2010-08-11 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Ariya Hidayat.
Remove dead code in CSSStyleSelector.
https://bugs.webkit.org/show_bug.cgi?id=43805
- css/CSSStyleSelector.cpp: Remove some debugging code that was compiled out.
- 6:24 PM Changeset in webkit [65204] by
-
- 5 edits2 adds in trunk
AX: isNativeCheckbox does not work as advertised
https://bugs.webkit.org/show_bug.cgi?id=43872
Reviewed by Beth Dakin.
WebCore:
Test: platform/mac/accessibility/native-vs-nonnative-checkboxes.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isInputImage):
Only say it's an input image if its role has not been overriden
(WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
- dom/InputElement.h:
Add methods to query if it's a checkbox or radio button type element.
- html/HTMLInputElement.h:
(WebCore::HTMLInputElement::isCheckbox):
LayoutTests:
- platform/mac/accessibility/native-vs-nonnative-checkboxes-expected.txt: Added.
- platform/mac/accessibility/native-vs-nonnative-checkboxes.html: Added.
- 5:45 PM Changeset in webkit [65203] by
-
- 2 edits in trunk/LayoutTests
2010-08-11 Shinichiro Hamaji <hamaji@chromium.org>
Chromium test_expectations update.
- platform/chromium/test_expectations.txt: Mark http/tests/storage/callbacks-are-called-in-correct-context.html as flaky.
- 5:39 PM Changeset in webkit [65202] by
-
- 2 edits in trunk/WebKit2
WKPageStopLoading always asserts
Reviewed by Gavin Barraclough.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage): Switch break to return, break made us
hit the ASSERT_NOT_REACHED at the end of the function.
- 5:31 PM Changeset in webkit [65201] by
-
- 5 edits in trunk
2010-08-11 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Geoffrey Garen.
Date("") should be an invalid date. For IE, Firefox and Chrome, Date("") is invalid date,
which means isNaN(new Date("")) should return true.
https://bugs.webkit.org/show_bug.cgi?id=43793
Tests: fast/js/date-constructor.html
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::resetDateCache):
2010-08-11 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Geoffrey Garen.
Add isNaN(new Date("")) test to fast/js/script-tests/date-constructor.js.
https://bugs.webkit.org/show_bug.cgi?id=43793
- fast/js/date-constructor-expected.txt:
- fast/js/script-tests/date-constructor.js:
- 5:12 PM Changeset in webkit [65200] by
-
- 38 edits in trunk
2010-08-11 Kenneth Russell <kbr@google.com>
Reviewed by David Levin.
Remove obsolete WebGLArray type names
https://bugs.webkit.org/show_bug.cgi?id=43885
Deleted aliases to obsolete WebGLArray type names. Updated
affected layout tests, synchronizing them with the versions in the
Khronos repository where appropriate. Ran all layout tests.
- bindings/js/JSDOMWindowCustom.cpp:
- page/DOMWindow.idl:
2010-08-11 Kenneth Russell <kbr@google.com>
Reviewed by David Levin.
Remove obsolete WebGLArray type names
https://bugs.webkit.org/show_bug.cgi?id=43885
Deleted aliases to obsolete WebGLArray type names. Updated
affected layout tests, synchronizing them with the versions in the
Khronos repository where appropriate. Ran all layout tests.
- compositing/webgl/webgl-reflection.html:
- fast/canvas/webgl/array-get-and-set-method-removal.html:
- fast/canvas/webgl/array-get-out-of-bounds.html:
- fast/canvas/webgl/array-set-out-of-bounds-expected.txt:
- fast/canvas/webgl/array-set-out-of-bounds.html:
- fast/canvas/webgl/array-setters-expected.txt:
- fast/canvas/webgl/array-setters.html:
- fast/canvas/webgl/array-unit-tests-expected.txt:
- fast/canvas/webgl/array-unit-tests.html:
- fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:
- fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html:
- fast/canvas/webgl/null-uniform-location.html:
- fast/canvas/webgl/point-size.html:
- fast/canvas/webgl/resources/webgl-test-utils.js: (WebGLTestUtils): (WebGLTestUtils.):
- fast/canvas/webgl/script-tests/texImageTest.js:
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view-expected.txt:
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view.html:
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-expected.txt:
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data.html:
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-expected.txt:
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html:
- fast/canvas/webgl/tex-image-with-format-and-type.html:
- fast/canvas/webgl/tex-input-validation.html:
- fast/canvas/webgl/tex-sub-image-2d-expected.txt:
- fast/canvas/webgl/tex-sub-image-2d.html:
- fast/canvas/webgl/texImage2DImageDataTest.html:
- fast/canvas/webgl/viewport-unchanged-upon-resize.html:
- fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt:
- fast/canvas/webgl/webgl-array-invalid-ranges.html:
- fast/dom/Window/script-tests/window-property-descriptors.js:
- fast/dom/Window/window-properties.html:
- fast/dom/script-tests/prototype-inheritance.js:
- fast/js/script-tests/global-constructors.js:
- 4:46 PM Changeset in webkit [65199] by
-
- 4 edits in trunk/WebCore
2010-08-11 Steve Block <steveblock@google.com>
Reviewed by David Levin.
[chromium] Geolocation breaks the compile if ENABLE_GEOLOCATION is set to 0
https://bugs.webkit.org/show_bug.cgi?id=43753
This change guards the entire contents of the V8 custom bindings files
with ENABLE(GEOLOCATION) to match JSC.
No new tests, build fix only.
- bindings/v8/custom/V8CustomPositionCallback.cpp:
- bindings/v8/custom/V8CustomPositionErrorCallback.cpp:
- bindings/v8/custom/V8GeolocationCustom.cpp:
- 4:35 PM Changeset in webkit [65198] by
-
- 2 edits in trunk/WebKitTools
2010-08-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Adding my Collabora personality to the list.
- Scripts/webkitpy/common/config/committers.py:
- 4:30 PM Changeset in webkit [65197] by
-
- 2 edits in trunk/WebCore
2010-08-11 Kwang Yul Seo <skyul@company100.net>
Reviewed by David Levin.
Include <wtf/UnusedParam.h> in GraphicsContextSkia.cpp
https://bugs.webkit.org/show_bug.cgi?id=43843
wtf/UnusedParam.h must be included because UNUSED_PARAM macro is used.
- platform/graphics/skia/GraphicsContextSkia.cpp:
- 4:25 PM Changeset in webkit [65196] by
-
- 2 edits in trunk/WebKit/gtk
2010-08-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Martin Robinson.
Small improvement to the documentation of the geolocation-policy-decision-requested
signal, stating more clearly what is expected from the handler.
- webkit/webkitwebview.cpp: (webkit_web_view_class_init):
- 4:25 PM Changeset in webkit [65195] by
-
- 2 edits in trunk/WebKit/gtk
2010-08-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Geolocation policy decision object leaking
https://bugs.webkit.org/show_bug.cgi?id=43884
Use GRefPtr on the policy decision object to fix the leak.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::requestGeolocationPermissionForFrame):
- 4:14 PM Changeset in webkit [65194] by
-
- 4 edits in trunk/WebCore
2010-08-11 Nico Weber <thakis@chromium.org>
Reviewed by David Levin.
[chromium/mac]: Fix colors in compositing mode
https://bugs.webkit.org/show_bug.cgi?id=43823
The textures are drawn by opengl, which doesn't do any color space
correction -- it assumes everything is in the device color space
already. Hence, when drawing into the memory that will be uploaded
as opengl texture, use the device color space.
- platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateTextureContents):
- platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::updateTextureContents):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::setRootLayerCanvasSize):
- 3:54 PM Changeset in webkit [65193] by
-
- 9 edits in trunk
2010-08-11 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Remove obsolete texImage2D and texSubImage2D entry points
https://bugs.webkit.org/show_bug.cgi?id=40320
No new tests; covered by existing WebGL tests.
- html/canvas/WebGLRenderingContext.cpp:
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebGLRenderingContext.idl:
2010-08-11 James Hawkins <jhawkins@chromium.org>
Reviewed by Dmitry Titov.
[Chromium] Notify the WebFrameClient when the frame is detached from
the view. This is used to clear the cached frame in the FormManager.
Eventually this will be removed once handling forms is moved into
WebCore.
https://bugs.webkit.org/show_bug.cgi?id=43648
- public/WebFrameClient.h: (WebKit::WebFrameClient::frameDetached):
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
- 3:44 PM Changeset in webkit [65192] by
-
- 4 edits in trunk/WebCore
2010-08-11 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Remove obsolete texImage2D and texSubImage2D entry points
https://bugs.webkit.org/show_bug.cgi?id=40320
No new tests; covered by existing WebGL tests.
- html/canvas/WebGLRenderingContext.cpp:
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebGLRenderingContext.idl:
- 3:28 PM Changeset in webkit [65191] by
-
- 2 edits in trunk/WebKitTools
2010-08-11 Martin Robinson <mrobinson@igalia.com>
Adding myself as a reviewer.
- Scripts/webkitpy/common/config/committers.py:
- 3:16 PM Changeset in webkit [65190] by
-
- 2 edits in trunk/WebCore
Windows build fix.
- platform/win/BString.cpp:
(WebCore::BString::BString):
- 3:02 PM Changeset in webkit [65189] by
-
- 2 edits in trunk/WebCore
Qt build fix II.
- WebCore.xcodeproj/project.pbxproj:
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):
- 2:52 PM Changeset in webkit [65188] by
-
- 4 edits in trunk/JavaScriptCore
Windows & !JIT build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/RegExp.cpp:
(JSC::RegExp::match):
- 2:48 PM Changeset in webkit [65187] by
-
- 3 edits in trunk/WebCore
Qt build fix.
- WebCore.xcodeproj/project.pbxproj:
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):
- 2:45 PM Changeset in webkit [65186] by
-
- 2 edits in trunk/JavaScriptCore
Rubber stamp by sam weinig
Touch a file to stop the bot rolling a bit change out!
- runtime/UString.cpp:
(JSC::UString::ascii):
- 2:35 PM Changeset in webkit [65185] by
-
- 3 edits in trunk/WebCore
2010-08-11 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Need EmptyDeviceOrientationClient and EmptyDeviceMotionClient for use with SVGImage
https://bugs.webkit.org/show_bug.cgi?id=43848
Tested by existing DeviceOrientation tests.
- loader/EmptyClients.h: (WebCore::EmptyDeviceMotionClient::setController): (WebCore::EmptyDeviceMotionClient::startUpdating): (WebCore::EmptyDeviceMotionClient::stopUpdating): (WebCore::EmptyDeviceMotionClient::currentDeviceMotion): (WebCore::EmptyDeviceOrientationClient::setController): (WebCore::EmptyDeviceOrientationClient::startUpdating): (WebCore::EmptyDeviceOrientationClient::stopUpdating): (WebCore::EmptyDeviceOrientationClient::lastOrientation):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
- 2:23 PM Changeset in webkit [65184] by
-
- 2 edits in trunk/LayoutTests
2010-08-11 Nate Chapin <Nate Chapin>
Unreviewed, Chromium expectations tweak.
Mark websocket/tests/frame-length-overflow.html as flaky.
- platform/chromium/test_expectations.txt:
- 1:38 PM Changeset in webkit [65183] by
-
- 9 edits in trunk
2010-08-10 Aaron Boodman <aa@chromium.org>
Reviewed by David Hyatt.
Make the cascade level of "user" styles configurable
https://bugs.webkit.org/show_bug.cgi?id=43457
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): Handle the case where user styles might have author level. Minor refactor.
- dom/Document.cpp: (WebCore::Document::pageGroupUserSheets): Set isUserStyle on created stylesheet objects appropriately.
- page/PageGroup.cpp: (WebCore::PageGroup::addUserStyleSheetToWorld): Add new optional "level" argument.
- page/PageGroup.h: Ditto.
- page/UserStyleSheet.h: Add level property. (WebCore::UserStyleSheet::): (WebCore::UserStyleSheet::UserStyleSheet): (WebCore::UserStyleSheet::setLevel): (WebCore::UserStyleSheet::level):
2010-08-10 Aaron Boodman <aa@chromium.org>
Reviewed by David Hyatt.
Make the cascade level of "user" styles configurable
https://bugs.webkit.org/show_bug.cgi?id=43457
- src/WebViewImpl.cpp: (WebKit::WebView::addUserStyleSheet): Send "author" for the css level of user styles.
- 1:24 PM Changeset in webkit [65182] by
-
- 2 edits in trunk/WebCore
2010-08-11 Rob Buis <rwlbuis@gmail.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=42042
An empty value for xml:lang isn't considered
Revert last line change of my patch ; it happens to
behave correctly and same as before, but makes the
use case of empty values unneededly slower.
No new tests. (No change in behavior)
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- 1:10 PM Changeset in webkit [65181] by
-
- 3 edits in trunk/WebKit/chromium
2010-08-11 James Hawkins <jhawkins@chromium.org>
Reviewed by Dmitry Titov.
[Chromium] Notify the WebFrameClient when the frame is detached from
the view. This is used to clear the cached frame in the FormManager.
Eventually this will be removed once handling forms is moved into
WebCore.
https://bugs.webkit.org/show_bug.cgi?id=43648
- public/WebFrameClient.h: (WebKit::WebFrameClient::frameDetached):
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
- 1:09 PM Changeset in webkit [65180] by
-
- 13 edits2 adds in trunk
[wx, WebDOM] Build fix. Fix handling of callbacks and WebCore::String -> WTF::String fixes.
- 12:55 PM Changeset in webkit [65179] by
-
- 2 edits in trunk/WebKitTools
2010-08-11 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Perl warnings when running commit-log-editor
https://bugs.webkit.org/show_bug.cgi?id=43856
Fixes Perl warnings introduced by the patch for Bug #40548.
Perl doesn't have symbolic names for True/False. Instead, we
should use boolean values. Moreover, the variable installedEditorApplication
is not be used and should be renamed builtEditorApplication so that it
uses the existing machinery to set the commit log editor application.
- Scripts/commit-log-editor:
- 12:53 PM Changeset in webkit [65178] by
-
- 2 edits in trunk/LayoutTests
2010-08-11 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
[Chromium] Remove consistently passing tests
from test_expectations.txt.
- platform/chromium/test_expectations.txt:
- 12:52 PM Changeset in webkit [65177] by
-
- 58 edits1 copy in trunk
Rubber stamps by Darin Adler & Sam Weinig.
Bug 43867 - Some UString cleanup
Change JSC::UString data(), size(), and from(), to characters(), length(), and number() to match WTF::String.
Move string concatenation methods to a new header to simplify down UString.h. Remove is8Bit().
- API/JSClassRef.cpp:
(OpaqueJSClass::~OpaqueJSClass):
(OpaqueJSClass::className):
- API/OpaqueJSString.cpp:
(OpaqueJSString::create):
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::constantName):
(JSC::idName):
(JSC::CodeBlock::registerName):
(JSC::regexpName):
- bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::get):
- bytecompiler/NodesCodegen.cpp:
(JSC::ResolveNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::processClauseList):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createRegex):
- parser/ParserArena.h:
(JSC::IdentifierArena::makeNumericIdentifier):
- parser/SourceProvider.h:
(JSC::UStringSourceProvider::data):
(JSC::UStringSourceProvider::length):
- profiler/Profiler.cpp:
- runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyNames):
(JSC::Arguments::put):
(JSC::Arguments::deleteProperty):
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
- runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
- runtime/ExceptionHelpers.cpp:
- runtime/FunctionConstructor.cpp:
- runtime/FunctionPrototype.cpp:
(JSC::insertSemicolonIfNeeded):
- runtime/Identifier.h:
(JSC::Identifier::characters):
(JSC::Identifier::length):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::decode):
(JSC::parseInt):
(JSC::parseFloat):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape):
- runtime/JSNumberCell.cpp:
(JSC::JSNumberCell::toString):
- runtime/JSONObject.cpp:
(JSC::gap):
(JSC::Stringifier::appendQuotedString):
(JSC::Stringifier::appendStringifiedValue):
(JSC::Stringifier::indent):
(JSC::Stringifier::unindent):
(JSC::Walker::walk):
- runtime/JSString.cpp:
(JSC::JSString::replaceCharacter):
(JSC::JSString::getIndexSlowCase):
- runtime/JSString.h:
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::RopeBuilder::fiberCount):
(JSC::jsSingleCharacterSubstring):
(JSC::jsNontrivialString):
(JSC::JSString::getIndex):
(JSC::jsString):
(JSC::jsStringWithFinalizer):
(JSC::jsSubstring):
(JSC::jsOwnedString):
- runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::append):
- runtime/LiteralParser.h:
(JSC::LiteralParser::Lexer::Lexer):
- runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToString):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToPrecision):
- runtime/NumericStrings.h:
(JSC::NumericStrings::add):
(JSC::NumericStrings::lookupSmallString):
- runtime/Operations.h:
(JSC::jsString):
- runtime/RegExp.cpp:
(JSC::RegExp::match):
- runtime/RegExpCache.cpp:
(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::create):
- runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getRightContext):
- runtime/RegExpObject.cpp:
(JSC::RegExpObject::match):
- runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncToString):
- runtime/StringBuilder.h:
(JSC::StringBuilder::append):
- runtime/StringConcatenate.h: Copied from JavaScriptCore/runtime/UString.h.
(JSC::):
(JSC::sumWithOverflow):
(JSC::tryMakeString):
(JSC::makeString):
- runtime/StringObject.cpp:
(JSC::StringObject::getOwnPropertyNames):
- runtime/StringPrototype.cpp:
(JSC::substituteBackreferencesSlow):
(JSC::localeCompare):
(JSC::jsSpliceSubstringsWithSeparators):
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncCharAt):
(JSC::stringProtoFuncCharCodeAt):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncLastIndexOf):
(JSC::stringProtoFuncSlice):
(JSC::stringProtoFuncSplit):
(JSC::stringProtoFuncSubstr):
(JSC::stringProtoFuncSubstring):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncLink):
(JSC::trimString):
- runtime/UString.cpp:
(JSC::UString::number):
(JSC::UString::ascii):
(JSC::UString::operator[]):
(JSC::UString::toDouble):
(JSC::UString::find):
(JSC::UString::rfind):
(JSC::UString::substr):
(JSC::operator==):
(JSC::operator<):
(JSC::operator>):
(JSC::UString::UTF8String):
- runtime/UString.h:
(JSC::UString::UString):
(JSC::UString::adopt):
(JSC::UString::length):
(JSC::UString::characters):
(JSC::UString::isNull):
(JSC::UString::isEmpty):
(JSC::UString::impl):
(JSC::UString::cost):
(JSC::operator==):
(JSC::operator!=):
(JSC::codePointCompare):
(JSC::UString::toArrayIndex):
(JSC::IdentifierRepHash::hash):
(WTF::):
- yarr/RegexJIT.cpp:
(JSC::Yarr::jitCompileRegex):
- yarr/RegexParser.h:
(JSC::Yarr::Parser::Parser):
JavaScriptGlue:
- JSUtils.cpp:
(UStringToCFString):
(KJSValueToCFTypeInternal):
- JavaScriptGlue.xcodeproj/project.pbxproj:
WebCore:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::hasCSSPropertyNamePrefix):
(WebCore::cssPropertyName):
- bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::setPort):
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::dispatchDidParseSource):
- bindings/js/ScriptString.h:
(WebCore::ScriptString::size):
- bindings/js/ScriptValue.cpp:
(WebCore::jsToInspectorValue):
- bindings/objc/WebScriptObject.mm:
(+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
- bridge/jni/jni_jsobject.mm:
(JavaJSObject::convertValueToJObject):
- bridge/jni/jsc/JNIUtilityPrivate.cpp:
(JSC::Bindings::convertArrayInstanceToJavaArray):
(JSC::Bindings::convertValueToJValue):
- bridge/objc/objc_runtime.mm:
(JSC::Bindings::callObjCFallbackObject):
WebKit/mac:
- WebView/WebScriptDebugger.mm:
(toNSString):
- 12:49 PM Changeset in webkit [65176] by
-
- 3 edits in trunk/WebKitTools
2010-08-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Trying waiting for httpd lock in the EWS
https://bugs.webkit.org/show_bug.cgi?id=43833
If this works, we can probably run the tests on the mac-ews, which
would be very exciting. :)
- Scripts/webkitpy/tool/steps/runtests.py:
- 12:48 PM Changeset in webkit [65175] by
-
- 10 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=43806, add ability to paginate screen content.
Reviewed by Dan Bernstein.
WebCore:
Add a new boolean to Document to indicate that content should be paginated. This is checked when doing page breaks
and in a couple of other cases.
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
(WebCore::Document::paginatedForScreen):
(WebCore::Document::setPaginatedForScreen):
(WebCore::Document::paginated):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::calcColumnWidth):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::calcHeight):
- rendering/RenderView.cpp:
(WebCore::RenderView::paint):
WebKit/mac:
Add SPI for entering and exiting screen pagination mode. This is similar to printing mode but it can be done for on-screen
content.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _web_setPrintingModeRecursive]):
(-[WebHTMLView _web_clearPrintingModeRecursive]):
(-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
(-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
(-[WebHTMLView _endPrintMode]):
(-[WebHTMLView _isInScreenPaginationMode]):
(-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
(-[WebHTMLView _endScreenPaginationMode]):
(-[WebHTMLView reapplyStyles]):
(-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
(-[WebHTMLView setPageWidthForPrinting:]):
- WebView/WebHTMLViewPrivate.h:
- 12:39 PM Changeset in webkit [65174] by
-
- 2 edits in branches/audio/WebCore/audio
Add AudioNode memory leak instrumentation
- 12:38 PM Changeset in webkit [65173] by
-
- 2 edits in branches/audio/WebCore/audio
Make AudioContext be an ActiveDOMObject
- 12:33 PM Changeset in webkit [65172] by
-
- 2 edits2 adds in trunk/LayoutTests
2010-08-11 Fady Samuel <fsamuel@chromium.org>
Reviewed by Nikolas Zimmermann.
RenderSVGRoot::nodeAtPoint truncates translated mouse coordinates
https://bugs.webkit.org/show_bug.cgi?id=41968
New layout test checks for proper hit region.
- platform/chromium-mac/svg/hittest/svg-rect-hit-expected.txt:
- platform/chromium/test_expectations.txt:
- svg/hittest/svg-rect-hit.html: Added.
- 11:59 AM Changeset in webkit [65171] by
-
- 2 edits in trunk/WebCore
2010-08-11 Adam Barth <abarth@webkit.org>
Windows build fix. Turns out we need to unconditionally include
HTMLEntityNames.cpp now that LegacyHTMLDocumentParser doesn't exist.
- html/HTMLEntityParser.cpp:
- 11:56 AM Changeset in webkit [65170] by
-
- 10 edits2 adds in trunk
2010-08-11 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
Inserting a <source> element should immediately set networkState to NETWORK_NO_SOURCE.
https://bugs.webkit.org/show_bug.cgi?id=42897
A <source> element inserted as a child of a media element with a networkState of NETWORK_EMPTY
should cause the networkState to immediately change to NETWORK_NO_SOURCE.
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Remove unused variable m_processingLoad. (WebCore::HTMLMediaElement::prepareForLoad): Set m_networkState to NETWORK_NO_SOURCE. (WebCore::HTMLMediaElement::loadInternal): Remove unused variable m_processingLoad. (WebCore::HTMLMediaElement::selectMediaResource): No need to change m_networkState, it was done in prepareForLoad.
- html/HTMLMediaElement.h:
- html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::insertedIntoTree): Renamed from insertedIntoDocument because we want to do this setup whether or not the parent media element is in the document.
- html/HTMLSourceElement.h:
2010-08-11 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
Inserting a <source> element should immediately set networkState to NETWORK_NO_SOURCE.
https://bugs.webkit.org/show_bug.cgi?id=42897
- media/remove-from-document-no-load-expected.txt:
- media/remove-from-document-no-load.html:
- media/video-pause-empty-events-expected.txt:
- media/video-pause-empty-events.html:
- media/video-source-inserted-expected.txt: Added.
- media/video-source-inserted.html: Added.
- 11:49 AM Changeset in webkit [65169] by
-
- 3 edits in trunk/WebKit/efl
2010-08-11 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Add setting for enabling spatial navigation.
https://bugs.webkit.org/show_bug.cgi?id=43569
Adding api for enabling/disabling spatial navigation.
- ewk/ewk_view.cpp: Both functions below added. (ewk_view_setting_spatial_navigation_get): (ewk_view_setting_spatial_navigation_set):
- ewk/ewk_view.h: same as ewk_view.cpp.
- 11:48 AM Changeset in webkit [65168] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-11 Dimitri Glazkov <Dimitri Glazkov>
Build fix, turn off yet-unbaked DEVICE_ORIENTATION stuff.
- features.gypi: Turned it off.
- 11:31 AM Changeset in webkit [65167] by
-
- 27 edits4 deletes in trunk/WebCore
2010-08-11 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Delete LegacyHTMLDocumentParser and LegacyPreloadScanner
https://bugs.webkit.org/show_bug.cgi?id=43836
These classes are bit-rotting disturbingly quickly. We removed the
last dependencies on these classes and so we can remove them.
We might need to preserve some of their particular quirks to handle
some legacy applications, but our current thinking is to do that with
individual settings that affect the new parser.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
- dom/DocumentFragment.cpp: (WebCore::DocumentFragment::parseHTML):
- dom/DocumentParser.h:
- dom/XMLDocumentParserLibxml2.cpp:
- dom/XMLDocumentParserQt.cpp:
- html/HTMLConstructionSite.cpp:
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::createParser):
- html/HTMLEntityParser.cpp: (WebCore::decodeNamedEntity):
- html/HTMLEntityParser.h:
- html/HTMLFormControlElement.cpp:
- html/HTMLTreeBuilder.cpp:
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createParser):
- html/LegacyHTMLDocumentParser.cpp: Removed.
- html/LegacyHTMLDocumentParser.h: Removed.
- html/LegacyHTMLTreeBuilder.cpp:
- html/LegacyPreloadScanner.cpp: Removed.
- html/LegacyPreloadScanner.h: Removed.
- loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryDocumentParser::FTPDirectoryDocumentParser): (WebCore::FTPDirectoryDocumentParser::appendEntry): (WebCore::FTPDirectoryDocumentParser::createTDForFilename): (WebCore::processFilesizeString): (WebCore::wasLastDayOfMonth): (WebCore::processFileDateString): (WebCore::FTPDirectoryDocumentParser::parseAndAppendOneLine): (WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate): (WebCore::FTPDirectoryDocumentParser::createBasicDocument): (WebCore::FTPDirectoryDocumentParser::append): (WebCore::FTPDirectoryDocumentParser::finish):
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::decodeHTMLEntities):
- page/XSSAuditor.h:
- platform/text/SegmentedString.cpp: (WebCore::SegmentedString::prepend):
- 11:31 AM Changeset in webkit [65166] by
-
- 1 edit3 adds in trunk/WebKitTools
2010-08-11 Marcus Bulach <bulach@chromium.org>
Reviewed by Eric Seidel.
Check in a script to list redundant test outputs.
https://bugs.webkit.org/show_bug.cgi?id=37630
If e.g. platform/mac-leopard is missing an expected test output, we
fall back on platform/mac. This means it's possible to grow redundant
test outputs, where we have the same expected data in both a platform
directory and another platform it falls back on.
(original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398)
- Scripts/deduplicate-tests: Added.
- Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
- Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
- 11:01 AM Changeset in webkit [65165] by
-
- 3 edits in trunk/WebKitTools
2010-08-11 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Ariya Hidayat.
[Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
https://bugs.webkit.org/show_bug.cgi?id=43853
LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
to slots at all.
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): (LauncherWindow::animatedFlip): (LauncherWindow::animatedYFlip):
- QtTestBrowser/launcherwindow.h:
- 10:40 AM Changeset in webkit [65164] by
-
- 5 edits in trunk/WebCore
2010-08-11 Chris Jerdonek <Chris Jerdonek>
Reviewed by Adam Barth.
Refactored FrameLoader::createWindow() out of the FrameLoader class
since FrameLoader should not be responsible for creating windows.
No new functionality, so no new tests.
- bindings/generic/BindingDOMWindow.h:
(WebCore::::createWindow):
- Updated the call to FrameLoader's createWindow().
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::createWindow):
- Updated the call to FrameLoader's createWindow().
- loader/FrameLoader.cpp:
(WebCore::createWindowFromFrameLoader):
- Made FrameLoader::createWindow() non-member, non-friend and changed it to accept Frame* parameters instead of FrameLoader*.
- loader/FrameLoader.h:
- Updated the header file to reflect the above change to FrameLoader.cpp.
- 10:14 AM Changeset in webkit [65163] by
-
- 5 edits in trunk/WebKit/efl
2010-08-11 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Antonio Gomes.
Implementation dispatchDecidePolicyForNavigationAction
https://bugs.webkit.org/show_bug.cgi?id=43544
Add ewk_view_navigation_policy_decision to decide whether url which
user clicked will be loaded or not.
- WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
- ewk/ewk_private.h:
- ewk/ewk_view.cpp: (ewk_view_navigation_policy_decision):
- ewk/ewk_view.h:
- 9:55 AM Changeset in webkit [65162] by
-
- 4 edits1 add1 delete in trunk/LayoutTests
2010-08-11 Nate Chapin <Nate Chapin>
Unreviewed, Chromium rebaseline.
Tweak win pixel results for svg/batik/text/textFeatures.svg.
- platform/chromium-win-vista/svg/batik/text/textFeatures-expected.checksum:
- platform/chromium-win-vista/svg/batik/text/textFeatures-expected.png:
- platform/chromium-win-vista/svg/batik/text/textFeatures-expected.txt: Removed.
- platform/chromium-win-xp/svg/batik/text/textFeatures-expected.checksum:
- platform/chromium-win-xp/svg/batik/text/textFeatures-expected.png: Added.
- 9:31 AM Changeset in webkit [65161] by
-
- 4 edits in trunk/LayoutTests
2010-08-11 Alejandro G. Castro <alex@igalia.com>
Unreviewed.
New baselines for the mathml tests.
- platform/gtk/mathml/presentation/sub-expected.txt:
- platform/gtk/mathml/presentation/sup-expected.txt:
- platform/gtk/mathml/presentation/tables-expected.txt:
- 8:57 AM Changeset in webkit [65160] by
-
- 3 edits in trunk/WebKitTools
2010-08-11 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Simon Hausmann.
[Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
https://bugs.webkit.org/show_bug.cgi?id=43851
All window options data (including the bool holding if the view is either QWebView or
QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
getting broken.
Patch addresses this issue.
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): (LauncherWindow::toggleWebView): (LauncherWindow::toggleAcceleratedCompositing):
- 8:56 AM Changeset in webkit [65159] by
-
- 3 edits in trunk/WebKitTools
2010-08-10 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Ariya Hidayat.
[Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
https://bugs.webkit.org/show_bug.cgi?id=43831
Only instantiate QStateMachine and friends associated to the YRotation action on demand.
- QtTestBrowser/webview.cpp: (WebViewGraphicsBased::WebViewGraphicsBased): (WebViewGraphicsBased::animatedYFlip):
- 8:33 AM Changeset in webkit [65158] by
-
- 4 edits1 add in trunk/WebKit2
2010-08-11 Balazs Kelemen <kb@inf.u-szeged.hu>
Unreviewed build fix.
[Qt] Update WebKit2 build environment, add stub implementation of SharedMemory.
- DerivedSources.pro:
- Platform/qt/SharedMemoryQt.cpp: Added. (WebKit::SharedMemory::Handle::Handle): (WebKit::SharedMemory::Handle::~Handle): (WebKit::SharedMemory::Handle::encode): (WebKit::SharedMemory::Handle::decode): (WebKit::SharedMemory::create): (WebKit::SharedMemory::~SharedMemory): (WebKit::SharedMemory::createHandle): (WebKit::SharedMemory::systemPageSize):
- WebKit2.pro:
- WebKit2Prefix.h:
- 8:08 AM Changeset in webkit [65157] by
-
- 44 edits2 adds3 deletes in trunk/LayoutTests
2010-08-11 Nate Chapin <Nate Chapin>
Unreviewed, Chromium rebaseline.
New results and expectations tweak for http://trac.webkit.org/changeset/65138.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
- platform/chromium-linux/svg/batik/text/textEffect-expected.checksum:
- platform/chromium-linux/svg/batik/text/textEffect-expected.png:
- platform/chromium-linux/svg/batik/text/textEffect3-expected.checksum:
- platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
- platform/chromium-linux/svg/batik/text/textFeatures-expected.checksum:
- platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
- platform/chromium-linux/svg/batik/text/textProperties-expected.checksum:
- platform/chromium-linux/svg/batik/text/textProperties-expected.png:
- platform/chromium-linux/svg/custom/non-opaque-filters-expected.checksum:
- platform/chromium-linux/svg/custom/non-opaque-filters-expected.png:
- platform/chromium-linux/svg/custom/recursive-filter-expected.checksum:
- platform/chromium-linux/svg/custom/recursive-filter-expected.png:
- platform/chromium-linux/svg/custom/text-filter-expected.checksum:
- platform/chromium-linux/svg/custom/text-filter-expected.png: Added.
- platform/chromium-linux/svg/filters/feGaussianBlur-expected.checksum: Removed.
- platform/chromium-linux/svg/filters/filter-on-filter-for-text-expected.checksum:
- platform/chromium-linux/svg/filters/filter-on-filter-for-text-expected.png: Added.
- platform/chromium-linux/svg/filters/shadow-on-filter-expected.checksum: Removed.
- platform/chromium-linux/svg/filters/shadow-on-filter-expected.png: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
- platform/chromium-win/svg/batik/text/textEffect-expected.checksum:
- platform/chromium-win/svg/batik/text/textEffect-expected.png:
- platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
- platform/chromium-win/svg/batik/text/textEffect3-expected.png:
- platform/chromium-win/svg/batik/text/textFeatures-expected.checksum:
- platform/chromium-win/svg/batik/text/textFeatures-expected.png:
- platform/chromium-win/svg/batik/text/textProperties-expected.checksum:
- platform/chromium-win/svg/batik/text/textProperties-expected.png:
- platform/chromium-win/svg/custom/non-opaque-filters-expected.checksum:
- platform/chromium-win/svg/custom/non-opaque-filters-expected.png:
- platform/chromium-win/svg/custom/recursive-filter-expected.checksum:
- platform/chromium-win/svg/custom/recursive-filter-expected.png:
- platform/chromium-win/svg/custom/text-filter-expected.checksum:
- platform/chromium-win/svg/custom/text-filter-expected.png:
- platform/chromium-win/svg/filters/feGaussianBlur-expected.checksum:
- platform/chromium-win/svg/filters/feGaussianBlur-expected.png:
- platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.checksum:
- platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.png:
- platform/chromium-win/svg/filters/shadow-on-filter-expected.checksum:
- platform/chromium-win/svg/filters/shadow-on-filter-expected.png:
- platform/chromium/test_expectations.txt:
- 7:56 AM Changeset in webkit [65156] by
-
- 2 edits in trunk/WebCore
2010-08-11 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: small refactoring for CodeGeneratorInspector.
all "notify" methods are generating in InspectorFrontend
the other methods are generating in InspectorBackend.
https://bugs.webkit.org/show_bug.cgi?id=43849
- inspector/CodeGeneratorInspector.pm:
- 7:43 AM Changeset in webkit [65155] by
-
- 5 edits1 add in trunk/WebCore
2010-08-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Misc improvements to the scrolling code
https://bugs.webkit.org/show_bug.cgi?id=41926
Refactor code that uses deprecated ways of dealing with the
adjustments to use the GtkVersioning infrastructure.
- GNUmakefile.am:
- platform/gtk/GtkVersioning.cpp: Added.
- platform/gtk/GtkVersioning.h:
- platform/gtk/ScrollViewGtk.cpp:
- platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::detachAdjustment): (ScrollbarGtk::updateThumbPosition): (ScrollbarGtk::updateThumbProportion):
- 7:37 AM Changeset in webkit [65154] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Update the Symbian def files
Re-freeze with various QGraphicsWebView and DRT updates.
The uppper part of the diff is just whitespace, so
diff -w will show the real diff.
- symbian/eabi/QtWebKitu.def:
- 6:51 AM Changeset in webkit [65153] by
-
- 2 edits in trunk/WebCore
2010-08-11 Nate Chapin <Nate Chapin>
Chromium mac build fix (variables weren't being initialized).
- platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::apply): Initalize dxLeft, dxRight, dyLeft, dyRight.
- 6:45 AM Changeset in webkit [65152] by
-
- 3 edits1 add in trunk/WebKit/chromium
2010-08-11 Evan Stade <estade@chromium.org>
Reviewed by David Levin.
[chromium] linux chromium sends double clicks too often
https://bugs.webkit.org/show_bug.cgi?id=43096
- WebKit.gyp: add the test
- src/gtk/WebInputEventFactory.cpp: (WebKit::WebInputEventFactory::mouseEvent): check the x/y coordinates of the potential double click event
- tests/WebInputEventFactoryTestGtk.cpp: Added.
- 6:27 AM Changeset in webkit [65151] by
-
- 2 edits in trunk/LayoutTests
2010-08-11 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Rebaseline Chromium test.
- platform/chromium-win/http/tests/loading/bad-scheme-subframe-expected.txt:
- 6:27 AM Changeset in webkit [65150] by
-
- 3 edits in trunk/JavaScriptCore
2010-08-11 Gabor Loki <loki@webkit.org>
Qt build fix (ARMv7).
Fix invalid conversion from int to Condition.
Add ARMv7Assembler.cpp to JavaScriptCore.pro.
- 6:12 AM Changeset in webkit [65149] by
-
- 3 edits in trunk/WebCore
2010-08-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: apply correct fix to storage panel status bar buttons.
- inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView.prototype.get statusBarItems):
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype._genericViewSetup):
- 5:54 AM Changeset in webkit [65148] by
-
- 3 edits in trunk/WebKitTools
2010-08-11 Darin Adler <Darin Adler>
Reviewed by John Sullivan.
Improved editor options for prepare-ChangeLog and commit-log-editor
https://bugs.webkit.org/show_bug.cgi?id=40548
- Scripts/commit-log-editor: Split editor strings on spaces so EDITOR values like "xed --launch --wait" work properly.
- Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can use a command line tool with the $openChangeLogs feature.
- 5:30 AM Changeset in webkit [65147] by
-
- 10 edits in trunk/WebCore
2010-08-11 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Adam Barth.
Override operator= for C++ DOM binding classes with private structs
and update C++ DOM bindings test results.
https://bugs.webkit.org/show_bug.cgi?id=43735
- bindings/cpp/WebDOMEventTarget.cpp: (WebDOMEventTarget::operator=):
- bindings/cpp/WebDOMEventTarget.h:
- bindings/scripts/CodeGeneratorCPP.pm:
- bindings/scripts/test/CPP/WebDOMTestCallback.cpp: (WebDOMTestCallback::operator=):
- bindings/scripts/test/CPP/WebDOMTestCallback.h:
- bindings/scripts/test/CPP/WebDOMTestInterface.cpp: (WebDOMTestInterface::operator=):
- bindings/scripts/test/CPP/WebDOMTestInterface.h:
- bindings/scripts/test/CPP/WebDOMTestObj.cpp: (WebDOMTestObj::operator=):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- 5:14 AM Changeset in webkit [65146] by
-
- 4 edits in trunk/JavaScriptCore
2010-08-11 Nathan Lawrence <nlawrence@apple.com>
Reviewed by Geoffrey Garen.
At collection time, we frequently want to mark a cell, while checking
whether it was originally checked. Previously, this was a get
operation follwed by a set operation. Fusing the two saves
computation and gives a 0.5% sunspider speedup.
- runtime/Collector.h: (JSC::CollectorBitmap::getset): (JSC::Heap::checkMarkCell):
- runtime/JSArray.h: (JSC::MarkStack::drain):
- runtime/JSCell.h: (JSC::MarkStack::append):
- 4:09 AM Changeset in webkit [65145] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-11 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Fisher.
[chromium] Inform a plugin about the zoom level when it's created
https://bugs.webkit.org/show_bug.cgi?id=42268
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::createPlugin):
- 3:30 AM Changeset in webkit [65144] by
-
- 5 edits2 adds in trunk
2010-08-11 Julie Parent <jparent@chromium.org>
Reviewed by Justin Garcia.
Crash in replaceSelectionCommand with RTL text.
https://bugs.webkit.org/show_bug.cgi?id=41485
Adds tests for 4 cases: latin text plus space in RTL region and LTR region,
and hebrew text plus space in RTL region and LTR region. Currently, the
latin text in RTL region case crashes. Added all combinations of test since
earlier patch crashed with hebrew text in LTR region.
- editing/execCommand/insert-image-on-top-of-directional-text-expected.txt: Added.
- editing/execCommand/insert-image-on-top-of-directional-text.html: Added.
2010-08-11 Julie Parent <jparent@chromium.org>
Reviewed by Justin Garcia.
Crash in replaceSelectionCommand with RTL text.
https://bugs.webkit.org/show_bug.cgi?id=41485
For text with mixed directionality, sort the text boxes before
computing gaps, since that code assumes the boxes are in order.
Test: editing/execCommand/insert-image-on-top-of-directional-text.html
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteInsignificantText): Sort boxes like we do in TextIterator before computing gaps.
- editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode): Use new compareByStart rather than compareBoxStart. No functional change.
- rendering/InlineTextBox.h: (WebCore::InlineTextBox::compareByStart): Moved compareBoxStart from TextIterator here so it can be used in multiple places.
- 2:41 AM Changeset in webkit [65143] by
-
- 2 edits in trunk/JavaScriptCore
2010-08-11 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Improve vsprops copying for Windows build
https://bugs.webkit.org/show_bug.cgi?id=41982
When we detect a new SDK, always copy a new set of vsprops files.
Previously, if someone updated their SDK after updating their sources,
they could end up with out-of-date vsprops files.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
- 2:20 AM Changeset in webkit [65142] by
-
- 5 edits in trunk/WebKit2
Build fix. Update references to StringHash.h.
- Shared/CommandLine.h:
- UIProcess/WebContext.h:
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/win/WebProcessMainWin.cpp:
- 2:15 AM Changeset in webkit [65141] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-11 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix Chromium compilation.
- DEPS:
- 1:46 AM Changeset in webkit [65140] by
-
- 2 edits in trunk/WebCore
2010-08-11 Fumitoshi Ukai <ukai@chromium.org>
Unreviewed build fix of Leopard Intel Debug (Build)
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::processBuffer): use %lu, instead of %ul
- 1:43 AM Changeset in webkit [65139] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-11 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Chromium build fix.
- DEPS: bump up Chromium revision.
- 1:43 AM Changeset in webkit [65138] by
-
- 50 edits in trunk
2010-08-11 Alejandro G. Castro <alex@igalia.com>
Reviewed by Dirk Schulze.
Fixes to the gaussian blur algorithm
https://bugs.webkit.org/show_bug.cgi?id=41605
Added the recomendations of SVG regarding the kernel size
calculation for the approximation of the gaussian
blur. http://www.w3.org/TR/SVG/filters.html#feGaussianBlurElement.
Modified also some variable names to clarify algorithm, reviewed
the situation where both standard deviations are 0.
- platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::FEGaussianBlur): (WebCore::FEGaussianBlur::stdDeviationX): (WebCore::FEGaussianBlur::setStdDeviationX): (WebCore::FEGaussianBlur::stdDeviationY): (WebCore::FEGaussianBlur::setStdDeviationY): (WebCore::boxBlur): (WebCore::FEGaussianBlur::kernelPosition): Added the SVG kernel position recomendation. (WebCore::FEGaussianBlur::apply): (WebCore::FEGaussianBlur::externalRepresentation):
- platform/graphics/filters/FEGaussianBlur.h:
2010-08-11 Alejandro G. Castro <alex@igalia.com>
Reviewed by Dirk Schulze.
Fixes to the gaussian blur algorithm
https://bugs.webkit.org/show_bug.cgi?id=41605
Unskipped test and generated results.
- platform/gtk/Skipped:
- platform/gtk/svg/filters/feGaussianBlur-expected.txt: Added.
Updated pixel tests.
- platform/mac-leopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
- platform/mac-leopard/svg/batik/text/textProperties-expected.checksum:
- platform/mac-leopard/svg/batik/text/textProperties-expected.png:
- platform/mac-leopard/svg/custom/mask-colorspace-expected.png:
- platform/mac-leopard/svg/filters/feGaussianBlur-expected.checksum:
- platform/mac-leopard/svg/filters/feGaussianBlur-expected.png:
- platform/mac-leopard/svg/filters/shadow-on-filter-expected.checksum:
- platform/mac-leopard/svg/filters/shadow-on-filter-expected.png:
- platform/mac-leopard/svg/filters/shadow-on-rect-with-filter-expected.checksum:
- platform/mac-leopard/svg/filters/shadow-on-rect-with-filter-expected.png:
- platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
- platform/mac/svg/batik/text/textEffect-expected.checksum:
- platform/mac/svg/batik/text/textEffect-expected.png:
- platform/mac/svg/batik/text/textEffect3-expected.checksum:
- platform/mac/svg/batik/text/textEffect3-expected.png:
- platform/mac/svg/batik/text/textFeatures-expected.checksum:
- platform/mac/svg/batik/text/textFeatures-expected.png:
- platform/mac/svg/custom/non-opaque-filters-expected.checksum:
- platform/mac/svg/custom/non-opaque-filters-expected.png:
- platform/mac/svg/custom/recursive-filter-expected.checksum:
- platform/mac/svg/custom/recursive-filter-expected.png:
- platform/mac/svg/custom/resource-invalidate-on-target-update-expected.checksum:
- platform/mac/svg/custom/resource-invalidate-on-target-update-expected.png:
- platform/mac/svg/custom/text-filter-expected.checksum:
- platform/mac/svg/custom/text-filter-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png:
- platform/mac/svg/filters/filter-on-filter-for-text-expected.checksum:
- platform/mac/svg/filters/filter-on-filter-for-text-expected.png:
- 1:35 AM Changeset in webkit [65137] by
-
- 2 edits in trunk/WebCore
2010-08-11 Kristian Monsen <kristianm@google.com>
Reviewed by Steve Block.
Compile fix for Android, added include for <wtf/text/Cstring.h, this
did not get included in Android.
https://bugs.webkit.org/show_bug.cgi?id=41517
Build fix only, no new tests.
- page/PrintContext.cpp:
- 1:32 AM Changeset in webkit [65136] by
-
- 5 edits1 delete in trunk
2010-08-11 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove InjectDispatch.js
https://bugs.webkit.org/show_bug.cgi?id=43835
- WebKit.grd:
- src/js/InjectDispatch.js: Removed.
2010-08-11 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove InjectDispatch.js
https://bugs.webkit.org/show_bug.cgi?id=43835
- DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
- DumpRenderTree/chromium/DRTDevToolsAgent.h:
- 1:23 AM Changeset in webkit [65135] by
-
- 4 edits3 adds in trunk
2010-08-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix length calculation to be more robust.
https://bugs.webkit.org/show_bug.cgi?id=43777
- websocket/tests/frame-length-overflow-expected.txt: Added.
- websocket/tests/frame-length-overflow.html: Added.
- websocket/tests/frame-length-overflow_wsh.py: Added.
2010-08-11 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix length calculation to be more robust.
https://bugs.webkit.org/show_bug.cgi?id=43777
Test: websocket/tests/frame-length-overflow.html
- websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::appendToBuffer): len is size_t.
- add sanity check for integer wraps.
(WebCore::WebSocketChannel::skipBuffer): len is size_t.
(WebCore::WebSocketChannel::processBuffer): length is size_t.
- add sanity check for integer wraps.
- websockets/WebSocketChannel.h: change m_bufferSize and len to size_t.
- 12:51 AM Changeset in webkit [65134] by
-
- 6 edits5 adds in trunk
2010-08-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix three ASSERTs hit with the HTML5 TreeBuilder in fragment mode
https://bugs.webkit.org/show_bug.cgi?id=43762
In fixing the insertAdjacentHTML I had to make small changes to
the error logic, which ended up bringing us closer to HTML5.
Test: fast/dom/HTMLElement/insertAdjacentHTML-errors.html
- html/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::attach):
- This ASSERT was just wrong, the child should not be attached in the case the parent is not attached.
- html/HTMLElement.cpp:
(WebCore::contextElementForInsertion):
- This is part of HTML5, needed to know what to call the HTML or XML parsers with. The previous code always passed "this" which is wrong in the case of beforeBegin or afterEnd insertion.
(WebCore::HTMLElement::insertAdjacentHTML):
- Use the right contextElement now that we know how to compute it.
- html/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
- This ASSERT is direct from the spec, but it's wrong, so I've filed a spec bug.
2010-08-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix three ASSERTs hit with the HTML5 TreeBuilder in fragment mode
https://bugs.webkit.org/show_bug.cgi?id=43762
In order to fix the insertAdjacentHTML I had to some behavior.
The behavior I changed brings us closer to the HTML5 spec,
but since it was not previously tested, I added tests.
- fast/dom/HTMLElement/insertAdjacentHTML-errors-expected.txt: Added.
- fast/dom/HTMLElement/insertAdjacentHTML-errors.html: Added.
- 12:40 AM Changeset in webkit [65133] by
-
- 2 edits in trunk/WebCore
2010-08-11 Adam Barth <abarth@webkit.org>
Attempt to fix Windows build.
- platform/win/COMPtr.h: (WTF::):
- 12:30 AM Changeset in webkit [65132] by
-
- 12 edits2 adds in trunk/WebCore
2010-08-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Port view-source to new parser
https://bugs.webkit.org/show_bug.cgi?id=43746
This patch switches the view-source mode for frames over to using the
new HTML parsing infrastructure. This patch is an architectural change
to how we parser view source documents.
Previously, the LegacyHTMLDocumentParser would output a "guide string"
that consided of the inter-attribute whitespace and various "control"
characters. The HTMLViewSourceDocument would then interpret this guide
string to approximately reconstruct the source of the original document
and colorize various syntatic constructs.
Unfortunately, that approach is inherently low-fidelity. It's not
really feasible to reconstruct the input document from the token
stream. The old view source mode also had a number of hacks in the old
parser (e.g., to turn of decoding of HTML entities).
Instead of trying to reconstruct the original document from the token
stream, we use the segmentation information given by the tokens to
colorize the input document itself. Each token now caries information
about where in the input stream it came from and where various
subcomponents (e.g., attribute names and values) are located. This
approach is higher fidelity because we use this segmentation
information to colorize the original input instead of attempting to
reconstruct the original input.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLDocumentParser.cpp:
- html/HTMLToken.h: (WebCore::HTMLToken::clear): (WebCore::HTMLToken::startIndex): (WebCore::HTMLToken::length): (WebCore::HTMLToken::end):
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createParser): (WebCore::HTMLViewSourceDocument::addSource): (WebCore::HTMLViewSourceDocument::processDoctypeToken): (WebCore::HTMLViewSourceDocument::processTagToken): (WebCore::HTMLViewSourceDocument::processCommentToken): (WebCore::HTMLViewSourceDocument::processCharacterToken): (WebCore::HTMLViewSourceDocument::addRange):
- html/HTMLViewSourceDocument.h:
- html/HTMLViewSourceParser.cpp: Added. (WebCore::HTMLViewSourceParser::~HTMLViewSourceParser): (WebCore::HTMLViewSourceParser::insert): (WebCore::HTMLViewSourceParser::pumpTokenizer): (WebCore::HTMLViewSourceParser::append): (WebCore::HTMLViewSourceParser::sourceForToken): (WebCore::HTMLViewSourceParser::updateTokenizerState): (WebCore::HTMLViewSourceParser::finish): (WebCore::HTMLViewSourceParser::finishWasCalled):
- html/HTMLViewSourceParser.h: Added. (WebCore::HTMLViewSourceParser::HTMLViewSourceParser): (WebCore::HTMLViewSourceParser::document):
- html/LegacyHTMLDocumentParser.cpp: (WebCore::LegacyHTMLDocumentParser::processToken): (WebCore::LegacyHTMLDocumentParser::processDoctypeToken):
- 12:13 AM WebKit Team edited by
- my new employer (diff)
- 12:13 AM Changeset in webkit [65131] by
-
- 4 edits2 adds in trunk
2010-08-11 Yoshiki Hayashi <yhayashi@google.com>
Reviewed by Shinichiro Hamaji.
Make form controls, textarea, legend and datagrid treat width:
auto as specified in stretching vertical flexbox. Otherwise it's
treated as intrinsic as before.
https://bugs.webkit.org/show_bug.cgi?id=17918
- fast/flexbox/vertical-box-form-controls-expected.txt: Added.
- fast/flexbox/vertical-box-form-controls.html: Added.
2010-08-11 Yoshiki Hayashi <yhayashi@google.com>
Reviewed by Shinichiro Hamaji.
Make form controls, textarea, legend and datagrid treat width:
auto as specified in stretching vertical flexbox. Otherwise it's
treated as intrinsic as before.
https://bugs.webkit.org/show_bug.cgi?id=17918
Test: fast/flexbox/vertical-box-form-controls.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
- rendering/RenderBox.cpp: (WebCore::RenderBox::sizesToIntrinsicWidth):
- 12:08 AM Changeset in webkit [65130] by
-
- 9 edits in trunk
2010-08-10 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Add leakRef and clear to all RefPtr variants
https://bugs.webkit.org/show_bug.cgi?id=42389
- API/JSRetainPtr.h: Changed all uses of "template <...>" to instead do "template<...>". We should probably put this in the style guide and do it consitently. Fixed other minor style issues. Defined many of the inlined functions outside the class definition, to avoid style checker warnings about multiple statements on a single line and for slightly better clarity of the class definition itself. Renamed releaseRef to leakRef. Added a releaseRef that calls leakRef so we don't have to rename all callers oat once. Added a clear function.
- wtf/PassRefPtr.h: Changed all uses of releaseRef to leakRef.
- wtf/RefPtr.h: Changed all uses of "template <...>" to instead do "template<...>". Tidied up declarations and comments a bit. Changed all uses of releaseRef to leakRef.
- wtf/RetainPtr.h: Changed all uses of "template <...>" to instead do "template<...>". Defined many of the inlined functions outside the class definition, to avoid style checker warnings about multiple statements on a single line and for slightly better clarity of the class definition itself. Renamed releaseRef to leakRef. Added a releaseRef that calls leakRef so we don't have to rename all callers at once. Added a clear function.
2010-08-10 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Add leakRef and clear to all RefPtr variants
https://bugs.webkit.org/show_bug.cgi?id=42389
- platform/win/COMPtr.h: Changed all uses of "template <...>" to instead do "template<...>". Defined many of the inlined functions outside the class definition, to avoid style checker warnings about multiple statements on a single line and for slightly better clarity of the class definition itself. Renamed releaseRef to leakRef. Added a releaseRef that calls leakRef so we don't have to rename all callers at once. Added a clear function. Changed the hash table code so it doesn't need to call releaseRef, and so it uses the hash table deleted value hooks already present within the class.
2010-08-10 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Add leakRef and clear to all RefPtr variants
https://bugs.webkit.org/show_bug.cgi?id=42389
- UIProcess/API/cpp/WKRetainPtr.h: Changed all uses of "template <...>" to "template<...>". Defined many of the inlined functions outside the class definition, to avoid style checker warnings about multiple statements on a single line and for slightly better clarity of the class definition itself. Renamed releaseRef to leakRef. Added a releaseRef that calls leakRef so we don't have to rename all callers at once. Added a clear function.
Aug 10, 2010:
- 11:53 PM WebKit Team edited by
- (diff)
- 11:31 PM Changeset in webkit [65129] by
-
- 2 edits in trunk/LayoutTests
2010-08-10 Shinichiro Hamaji <hamaji@chromium.org>
Add a suppression of animations/suspend-resume-animation.html for chromium.
- platform/chromium/test_expectations.txt:
- 11:24 PM Changeset in webkit [65128] by
-
- 2 edits in trunk/WebCore
2010-08-10 Ariya Hidayat <ariya@sencha.com>
[Qt] Fix build warning: remove reference to html/BlobRegistryImp.h
- WebCore.pro:
- 11:20 PM Changeset in webkit [65127] by
-
- 3 edits2 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=43803
<rdar://problem/6988023> Only the last Korean character can be shown if font style is enabled while typing (43803)
Test: platform/mac/editing/input/bold-node.html
- editing/Editor.cpp: (WebCore::Editor::setComposition): It is not clear to me what the "baseNode == extentNode" check is about in this function , but let's try to make it more likely that it passes.
- 11:19 PM Changeset in webkit [65126] by
-
- 2 edits in trunk/WebKitTools
2010-08-10 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
webkit-patch should refuse to run under Win32 Python
https://bugs.webkit.org/show_bug.cgi?id=40962
Given that there are lots of places in webkit-patch's code that
assume unix-style filenames (forward slashes), webkit-patch fails
with weird file-not-found errors when run under a native windows
Python. It would be nice if we just trapped this and errored out
at the beginning, rather than producing unpredictable errors.
- Scripts/webkit-patch:
- 11:00 PM Changeset in webkit [65125] by
-
- 2 edits in trunk/JavaScriptCore
Unreviewed, reverting an unintentional change to a file submitted in r65108.
- bytecode/CodeBlock.h:
(JSC::binaryChop):
- 10:39 PM Changeset in webkit [65124] by
-
- 3 edits in trunk/WebKit/qt
2010-08-10 Anders Bakken <agbakken@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Don't connect to microFocusChanged() if _q_updateMicroFocus is a noop.
https://bugs.webkit.org/show_bug.cgi?id=40580
_q_updateMicroFocus() is a noop unless this ifdef evaluates to true:
#if !defined(QT_NO_IM) && (defined(Q_WS_X11) defined(Q_WS_QWS) defined(Q_OS_SYMBIAN)) In such cases there's no need to carry the overhead of the extra
signal/slot connection.
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::_q_updateMicroFocus): (QGraphicsWebView::setPage):
- 10:20 PM Changeset in webkit [65123] by
-
- 3 edits in trunk/WebCore
2010-08-10 Hayato Ito <hayato@chromium.org>
Reviewed by Kent Tamura.
Make CSSSelector::specificity() non-recursive.
https://bugs.webkit.org/show_bug.cgi?id=43784
This change is one of the required changes to fix the following master bug:
https://bugs.webkit.org/show_bug.cgi?id=42806
No functional change, thus no tests.
- css/CSSSelector.cpp: (WebCore::CSSSelector::specificity): (WebCore::CSSSelector::specificityForOneSelector): (WebCore::CSSSelector::specificityForPage):
- css/CSSSelector.h:
- 10:02 PM Changeset in webkit [65122] by
-
- 3 edits in trunk/WebKit/efl
2010-08-10 Ryuan Choi <ryuan.choi@samsung.com>
Unreviewed build fix.
[EFL]REGRESSION(65021) need to fix build break
https://bugs.webkit.org/show_bug.cgi?id=43767
Remove AtomicStringWTF and change namespace TextCaseInsensitive.
- ewk/ewk_frame.cpp: (ewk_frame_plugin_create):
- ewk/ewk_view.cpp: (ewk_view_text_search): (ewk_view_text_matches_mark): (ewk_view_setting_font_cursive_set):
- 9:47 PM Changeset in webkit [65121] by
-
- 4 edits in trunk
2010-08-10 Kent Tamura <tkent@chromium.org>
Unreviewed, build fix.
Chromium build fix for r65107.
- src/WebAnimationControllerImpl.cpp: (WebKit::WebAnimationControllerImpl::suspendAnimations): (WebKit::WebAnimationControllerImpl::resumeAnimations):
2010-08-10 Kent Tamura <tkent@chromium.org>
Unreviewed, build fix.
Chromium build fix for r65107.
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations):
- 8:40 PM Changeset in webkit [65120] by
-
- 3 edits in trunk/WebKit/chromium
another try at fixing Chromium build broken by http://trac.webkit.org/changeset/65107
- 8:30 PM Changeset in webkit [65119] by
-
- 1 edit in trunk/WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp
Another try at fixing Chromium build
- 8:10 PM Changeset in webkit [65118] by
-
- 4 edits in trunk
2010-08-10 Matthew Delaney <mdelaney@apple.com>
Reviewed by Darin Adler.
2d.path.clip.empty.html test is failing
https://bugs.webkit.org/show_bug.cgi?id=43161
- platform/mac/Skipped: Unskipping now passing path.clip.empty
2010-08-10 Matthew Delaney <mdelaney@apple.com>
Reviewed by Darin Adler.
2d.path.clip.empty.html test is failing
https://bugs.webkit.org/show_bug.cgi?id=43161
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::clip): Catching the empty path case from being sent directly to CGContextClip - which would ignore it. Instead, using CGContextClip with a CGRectZero to achieve the desired behavior of reducing the clipping region to nothing.
- 7:53 PM Changeset in webkit [65117] by
-
- 4 edits in trunk/WebCore
2010-08-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Add video files to enable video in WebKit EFL
https://bugs.webkit.org/show_bug.cgi?id=43790
Add files regarding html5 video to CMakeList.txt for WebKit Efl.
But, this patch is not run html5 video on WebKit EFL yet.
- CMakeLists.txt: Add files related to html5video.
- platform/efl/LocalizedStringsEfl.cpp: Add functions for html5 video. (WebCore::localizedMediaControlElementString): (WebCore::localizedMediaControlElementHelpText): (WebCore::localizedMediaTimeDescription):
- platform/graphics/MediaPlayer.cpp: (WebCore::installedMediaEngines): Disable MediaPlayerPrivate::r
egisterMediaEngine for WebKit EFL.
- 7:34 PM Changeset in webkit [65116] by
-
- 6 edits in trunk/WebCore
2010-08-10 Patrick Gansterer <paroga@paroga.com>
Reviewed by Nikolas Zimmermann.
Add a toRenderSVGImage function
https://bugs.webkit.org/show_bug.cgi?id=43789
Add a function for casting to RenderSVGImage and use it.
- rendering/RenderSVGImage.h: (WebCore::toRenderSVGImage):
- rendering/RenderTreeAsText.cpp: (WebCore::write):
- rendering/SVGRenderTreeAsText.cpp: (WebCore::writeSVGImage):
- rendering/SVGRenderTreeAsText.h:
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::attach):
- 7:33 PM Changeset in webkit [65115] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
Touching WebKit.idl to get IWebFramePrivate.idl to get rebuilt
- 7:21 PM Changeset in webkit [65114] by
-
- 2 edits in trunk/WebKitTools/DumpRenderTree
Fix for Chromium and gtk builds, broken by http://trac.webkit.org/changeset/65107
- 7:15 PM Changeset in webkit [65113] by
-
- 4 edits in trunk
2010-08-10 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Xan Lopez.
[GTK] http/tests/media/video-cookie.html fails
https://bugs.webkit.org/show_bug.cgi?id=42240
- platform/gtk/Skipped: unskipped test
2010-08-10 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Xan Lopez.
[GTK] http/tests/media/video-cookie.html fails
https://bugs.webkit.org/show_bug.cgi?id=42240
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAlwaysAcceptCookies): create the SoupCookieJar if it does not exist. Otherwise the accept policy won't be set.
- 7:14 PM Changeset in webkit [65112] by
-
- 1 edit in trunk/WebKit/win/WebFrame.cpp
Fix for Windows build, broken by http://trac.webkit.org/changeset/65107
- 7:13 PM Changeset in webkit [65111] by
-
- 7 edits in trunk/WebKit
Build fix (update more includes)
WebKit/mac:
- Plugins/Hosted/NetscapePluginHostManager.h:
WebKit/win:
- WebKitDLL.h:
- WebLocalizableStrings.cpp:
- WebNotificationCenter.cpp:
- WebPreferences.cpp:
- 6:55 PM Changeset in webkit [65110] by
-
- 3 edits in trunk/WebCore
2010-08-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Clients of HTMLTokenizer should be able to see where characters went in the token
https://bugs.webkit.org/show_bug.cgi?id=43766
When viewing the source of a document, we want to colorize different
parts of the input depending on how they were tokenized. In this
patch, we expose the internal segmentation of a token by recording the
start and end offsets for each attribute name and each attribute value.
- html/HTMLToken.h: (WebCore::HTMLToken::addNewAttribute): (WebCore::HTMLToken::beginAttributeName): (WebCore::HTMLToken::endAttributeName): (WebCore::HTMLToken::beginAttributeValue): (WebCore::HTMLToken::endAttributeValue): (WebCore::HTMLToken::appendToAttributeName): (WebCore::HTMLToken::appendToAttributeValue): (WebCore::AtomicHTMLToken::AtomicHTMLToken):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken):
- 6:28 PM Changeset in webkit [65109] by
-
- 2 edits in trunk/LayoutTests
2010-08-10 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Adler.
fast/dom/Window/window-properties.html is pretty slow
https://bugs.webkit.org/show_bug.cgi?id=43755
window-properties.html would take 5.9 seconds to run on my Mac Pro.
- Changing the order of checks in logValue to have more early returns before we get value and valueType brings this down to 3.66 seconds
- Changing logBuffer to be a string that we append to instead of an array that we push() to brings this to 0.7 seconds (string appends are faster than array push()-es followed by a join() in all browsers except IE per http://closure-library.googlecode.com/svn/docs/closure_goog_string_stringbuffer.js.source.html
- fast/dom/Window/window-properties.html:
- 6:19 PM Changeset in webkit [65108] by
-
- 9 edits in trunk
Do not post a sync task to the DB thread if it's terminating.
https://bugs.webkit.org/show_bug.cgi?id=43676
Reviewed by David Levin.
- bindings/generic/ActiveDOMCallback.cpp: The context can
sometimes be NULL. Check if it's NULL instead of asserting that
it's not.
(WebCore::ActiveDOMCallback::ActiveDOMCallback):
- dom/ActiveDOMObject.cpp:
(WebCore::ActiveDOMObject::ActiveDOMObject):
- storage/Database.cpp: Do not post a sync task to the DB thread
if the DB thread is terminating. Also, when a task is destroyed,
ASSERT that it was completed, or that it had no synchronizer.
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::tableNames):
- storage/DatabaseTask.cpp:
(WebCore::DatabaseTaskSynchronizer::DatabaseTaskSynchronizer):
(WebCore::DatabaseTask::~DatabaseTask):
(WebCore::DatabaseTask::performTask):
- storage/DatabaseTask.h:
(WebCore::DatabaseTaskSynchronizer::hasCheckedForTermination):
(WebCore::DatabaseTaskSynchronizer::setHasCheckedForTermination):
(WebCore::DatabaseTask::hasSynchronizer):
(WebCore::DatabaseTask::hasCheckedForTermination):
- storage/DatabaseThread.cpp:
(WebCore::DatabaseThread::terminationRequested):
(WebCore::DatabaseThread::scheduleTask):
(WebCore::DatabaseThread::scheduleImmediateTask):
- storage/DatabaseThread.h:
- 6:03 PM Changeset in webkit [65107] by
-
- 26 edits2 adds in trunk
2010-08-10 Chris Marrin <cmarrin@apple.com>
Reviewed by Oliver Hunt.
Add suspendAnimations/resumeAnimation API to DRT
https://bugs.webkit.org/show_bug.cgi?id=43733
Qt specific API. Missing symbian symbol defines in:
WebKit/qt/symbian/bwins/QtWebKitu.def
WebKit/qt/symbian/eabi/QtWebKitu.def
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::suspendAnimations): (DumpRenderTreeSupportQt::resumeAnimations):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
2010-08-10 Chris Marrin <cmarrin@apple.com>
Reviewed by Oliver Hunt.
Add suspendAnimations/resumeAnimation API to DRT
https://bugs.webkit.org/show_bug.cgi?id=43733
Gtk specific API.
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp: (webkit_web_frame_suspend_animations): (webkit_web_frame_resume_animations):
2010-08-10 Chris Marrin <cmarrin@apple.com>
Reviewed by Oliver Hunt.
Add suspendAnimations/resumeAnimation API to DRT
https://bugs.webkit.org/show_bug.cgi?id=43733
Win specific API
- Interfaces/IWebFramePrivate.idl:
- WebFrame.cpp: (WebFrame::suspendAnimations): (WebFrame::resumeAnimations):
- WebFrame.h:
2010-08-10 Chris Marrin <cmarrin@apple.com>
Reviewed by Oliver Hunt.
Add suspendAnimations/resumeAnimation API to DRT
https://bugs.webkit.org/show_bug.cgi?id=43733
Mac specific API. Plumbs suspendAnimations/resumeAnimations down to WebCore.
- WebView/WebFrame.mm: (-[WebFrame _suspendAnimations]): (-[WebFrame _resumeAnimations]):
- WebView/WebFramePrivate.h:
2010-08-10 Chris Marrin <cmarrin@apple.com>
Reviewed by Oliver Hunt.
Add suspendAnimations/resumeAnimation API to DRT
https://bugs.webkit.org/show_bug.cgi?id=43733
This tests suspend and resume of animations. Transitions are currently broken
due to https://bugs.webkit.org/show_bug.cgi?id=43792. I will add transition
tests and tests of transition and animation interaction with that fix.
- animations/animation-test-helpers.js: (matrixStringToArray):
- animations/suspend-resume-animation-expected.txt: Added.
- animations/suspend-resume-animation.html: Added.
2010-08-10 Chris Marrin <cmarrin@apple.com>
Reviewed by Oliver Hunt.
Add suspendAnimations/resumeAnimation API to DRT
https://bugs.webkit.org/show_bug.cgi?id=43733
Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
Calls functions with the same names on AnimationController for the
mainFrame.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/LayoutTestController.cpp: (suspendAnimationsCallback): (resumeAnimationsCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations):
- DumpRenderTree/chromium/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::suspendAnimations): (LayoutTestController::resumeAnimations):
- 5:54 PM Changeset in webkit [65106] by
-
- 2 edits in trunk/WebCore
Qt build fix.
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):
- 5:29 PM Changeset in webkit [65105] by
-
- 5 edits in trunk/WebCore
Fix more build break.
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::ZigZag::Reader::readBlob):
(WebCore::ZigZag::Reader::readFile):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::revokeBlobURL):
- dom/ScriptExecutionContext.h:
- html/Blob.cpp:
(WebCore::Blob::slice):
- 5:16 PM Changeset in webkit [65104] by
-
- 58 edits in trunk
Bug 43817 - Remove UString::Rep
UString::Rep has for a long time been replaced by UStringImpl (Rep
remaining as a typedef). UStringImpl has since been removed too
(unified with StringImpl). Remove Rep, rename rep() to impl() and
m_rep to m_impl. Also add impl() method to Identifier, and rename
its UString member from _ustring to m_string.
Rubber stamped by Sam Weinig
- API/JSCallbackObject.h:
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty):
(JSC::JSCallbackObjectData::JSPrivatePropertyMap::deletePrivateProperty):
- API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertySlot):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::getOwnPropertyNames):
(JSC::::staticValueGetter):
(JSC::::staticFunctionGetter):
- API/JSClassRef.cpp:
(tryCreateStringFromUTF8):
(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClass::~OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):
- API/JSClassRef.h:
- API/OpaqueJSString.cpp:
(OpaqueJSString::ustring):
- bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::get):
- bytecode/JumpTable.h:
(JSC::StringJumpTable::offsetForValue):
(JSC::StringJumpTable::ctiForValue):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addVar):
(JSC::BytecodeGenerator::addGlobalVar):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::addParameter):
(JSC::BytecodeGenerator::registerFor):
(JSC::BytecodeGenerator::willResolveToArguments):
(JSC::BytecodeGenerator::uncheckedRegisterForArguments):
(JSC::BytecodeGenerator::constRegisterFor):
(JSC::BytecodeGenerator::isLocal):
(JSC::BytecodeGenerator::isLocalConstant):
(JSC::BytecodeGenerator::addConstant):
(JSC::BytecodeGenerator::emitLoad):
(JSC::BytecodeGenerator::findScopedProperty):
(JSC::keyForCharacterSwitch):
(JSC::prepareJumpTableForStringSwitch):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::processClauseList):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- parser/JSParser.cpp:
(JSC::JSParser::parseStrictObjectLiteral):
- pcre/pcre_exec.cpp:
(Histogram::add):
- profiler/CallIdentifier.h:
(JSC::CallIdentifier::Hash::hash):
- profiler/Profile.cpp:
- profiler/ProfileNode.cpp:
(JSC::ProfileNode::debugPrintDataSampleStyle):
- profiler/ProfileNode.h:
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
- runtime/Identifier.cpp:
(JSC::Identifier::equal):
(JSC::IdentifierCStringTranslator::hash):
(JSC::IdentifierCStringTranslator::equal):
(JSC::IdentifierCStringTranslator::translate):
(JSC::Identifier::add):
(JSC::IdentifierUCharBufferTranslator::hash):
(JSC::IdentifierUCharBufferTranslator::equal):
(JSC::IdentifierUCharBufferTranslator::translate):
(JSC::Identifier::addSlowCase):
- runtime/Identifier.h:
(JSC::Identifier::Identifier):
(JSC::Identifier::ustring):
(JSC::Identifier::impl):
(JSC::Identifier::data):
(JSC::Identifier::size):
(JSC::Identifier::ascii):
(JSC::Identifier::isNull):
(JSC::Identifier::isEmpty):
(JSC::Identifier::toUInt32):
(JSC::Identifier::toStrictUInt32):
(JSC::Identifier::toArrayIndex):
(JSC::Identifier::toDouble):
(JSC::Identifier::equal):
(JSC::Identifier::add):
- runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
- runtime/InternalFunction.cpp:
(JSC::InternalFunction::displayName):
- runtime/JSFunction.cpp:
(JSC::JSFunction::displayName):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::addStaticGlobals):
- runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::JSStaticScopeObject):
- runtime/JSString.h:
(JSC::):
(JSC::RopeBuilder::appendStringInConstruct):
(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::jsSingleCharacterSubstring):
(JSC::jsSubstring):
- runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::deleteProperty):
(JSC::JSVariableObject::symbolTableGet):
- runtime/JSVariableObject.h:
(JSC::JSVariableObject::symbolTableGet):
(JSC::JSVariableObject::symbolTablePut):
(JSC::JSVariableObject::symbolTablePutWithAttributes):
- runtime/Lookup.cpp:
(JSC::HashTable::createTable):
(JSC::HashTable::deleteTable):
- runtime/Lookup.h:
(JSC::HashEntry::initialize):
(JSC::HashEntry::setKey):
(JSC::HashEntry::key):
(JSC::HashTable::entry):
- runtime/PropertyMapHashTable.h:
(JSC::PropertyMapEntry::PropertyMapEntry):
- runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
- runtime/PropertyNameArray.h:
(JSC::PropertyNameArray::add):
(JSC::PropertyNameArray::addKnownUnique):
- runtime/RegExp.cpp:
(JSC::RegExp::match):
- runtime/RegExpCache.cpp:
(JSC::RegExpCache::create):
- runtime/RegExpKey.h:
(JSC::RegExpKey::RegExpKey):
- runtime/SmallStrings.cpp:
(JSC::SmallStringsStorage::rep):
(JSC::SmallStrings::singleCharacterStringRep):
- runtime/SmallStrings.h:
- runtime/StringPrototype.cpp:
(JSC::jsSpliceSubstringsWithSeparators):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
- runtime/Structure.cpp:
(JSC::Structure::~Structure):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::put):
(JSC::Structure::hasTransition):
(JSC::Structure::remove):
(JSC::Structure::checkConsistency):
- runtime/Structure.h:
(JSC::Structure::get):
(JSC::Structure::hasTransition):
- runtime/StructureTransitionTable.h:
- runtime/SymbolTable.h:
- runtime/UString.cpp:
(JSC::UString::UString):
(JSC::UString::toStrictUInt32):
(JSC::UString::substr):
- runtime/UString.h:
(JSC::UString::UString):
(JSC::UString::adopt):
(JSC::UString::data):
(JSC::UString::size):
(JSC::UString::isNull):
(JSC::UString::isEmpty):
(JSC::UString::impl):
(JSC::UString::cost):
(JSC::operator==):
(JSC::codePointCompare):
(JSC::IdentifierRepHash::hash):
(WTF::):
WebCore:
- bindings/js/JSDOMBinding.cpp:
(WebCore::findAtomicString):
- bindings/js/JSDOMBinding.h:
(WebCore::ustringToString):
(WebCore::identifierToString):
(WebCore::ustringToAtomicString):
(WebCore::identifierToAtomicString):
- bindings/js/SerializedScriptValue.h:
(WebCore::SerializedScriptValueData::SerializedScriptValueData):
- bridge/IdentifierRep.cpp:
(WebCore::IdentifierRep::get):
- bridge/c/c_class.cpp:
(JSC::Bindings::CClass::methodsNamed):
(JSC::Bindings::CClass::fieldNamed):
- bridge/jni/jsc/JavaClassJSC.cpp:
(JavaClass::JavaClass):
(JavaClass::methodsNamed):
(JavaClass::fieldNamed):
- bridge/jni/jsc/JavaStringJSC.h:
(JSC::Bindings::JavaStringImpl::~JavaStringImpl):
(JSC::Bindings::JavaStringImpl::init):
(JSC::Bindings::JavaStringImpl::UTF8String):
(JSC::Bindings::JavaStringImpl::uchars):
(JSC::Bindings::JavaStringImpl::length):
(JSC::Bindings::JavaStringImpl::uString):
- bridge/jsc/BridgeJSC.h:
WebKit/mac:
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::methodsNamed):
(WebKit::ProxyInstance::fieldNamed):
- 5:14 PM Changeset in webkit [65103] by
-
- 6 edits in trunk/WebCore
Fix qt build break.
- html/BlobRegistryImpl.cpp:
- html/BlobRegistryImpl.h:
- html/BlobURL.cpp:
- html/BlobURL.h:
- platform/BlobRegistry.h:
- 5:03 PM Changeset in webkit [65102] by
-
- 16 edits4 copies4 adds in trunk/WebCore
Add the support to register the blob data.
https://bugs.webkit.org/show_bug.cgi?id=43600
Reviewed by David Levin.
This is the first step towards adding Blob URL support. The blob has
an internal URL (used by FileReader) and public URLs (used by Blob.url).
The URL and its associated data are managed by BlobRegistry interface.
This patch does not remove the usage of BlobItem. It will be removed
when all the blob data support is hooked up and the new tests will be
added then.
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedBlob::create):
(WebCore::SerializedBlob::url):
(WebCore::SerializedBlob::type):
(WebCore::SerializedBlob::size):
(WebCore::SerializedBlob::SerializedBlob):
(WebCore::SerializedFile::create):
(WebCore::SerializedFile::path):
(WebCore::SerializedFile::url):
(WebCore::SerializedFile::type):
(WebCore::SerializedFile::SerializedFile):
(WebCore::SerializedFileList::item):
(WebCore::SerializedFileList::SerializedFileList):
(WebCore::SerializedScriptValueData::SerializedScriptValueData):
(WebCore::SharedSerializedData::asBlob):
(WebCore::SharedSerializedData::asFile):
(WebCore::SerializingTreeWalker::convertIfTerminal):
(WebCore::DeserializingTreeWalker::convertIfTerminal):
(WebCore::TeardownTreeWalker::convertIfTerminal):
- bindings/js/SerializedScriptValue.h:
(WebCore::SerializedScriptValueData::):
(WebCore::SerializedScriptValueData::asString):
(WebCore::SerializedScriptValueData::asBlob):
(WebCore::SerializedScriptValueData::asFile):
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::ZigZag::Writer::writeBlob):
(WebCore::ZigZag::Writer::writeFile):
(WebCore::ZigZag::Writer::writeFileList):
(WebCore::ZigZag::Writer::doWriteUintHelper):
(WebCore::ZigZag::Writer::doWriteUint32):
(WebCore::ZigZag::Writer::doWriteUint64):
(WebCore::ZigZag::Serializer::writeBlob):
(WebCore::ZigZag::Serializer::writeFile):
(WebCore::ZigZag::Reader::readBlob):
(WebCore::ZigZag::Reader::readFile):
(WebCore::ZigZag::Reader::readFileList):
(WebCore::ZigZag::Reader::doReadUintHelper):
(WebCore::ZigZag::Reader::doReadUint32):
(WebCore::ZigZag::Reader::doReadUint64):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::trackBlobURL):
(WebCore::ScriptExecutionContext::revokeBlobURL):
- dom/ScriptExecutionContext.h:
- html/Blob.cpp:
(WebCore::Blob::Blob):
(WebCore::Blob::~Blob):
(WebCore::Blob::createPublicURL):
- html/Blob.h:
(WebCore::Blob::create):
(WebCore::Blob::url):
- html/BlobRegistryImpl.cpp: Added.
- html/BlobRegistryImpl.h: Added.
- html/BlobStorageData.h: Added.
- html/BlobURL.cpp: Added.
- html/BlobURL.h: Added.
- html/File.cpp:
(WebCore::File::File):
- html/File.h:
(WebCore::File::create):
- platform/BlobData.cpp: Added.
- platform/BlobData.h: Added.
- platform/BlobRegistry.h: Added.
- 4:52 PM Changeset in webkit [65101] by
-
- 6 edits in trunk/LayoutTests
2010-08-10 Stephen White <senorblanco@chromium.org>
Unreviewed; test expectations fix.
Rebaselines a test for win & linux, removes it from test_expectations.
- platform/chromium-linux/fast/canvas/image-object-in-canvas-expected.checksum:
- platform/chromium-linux/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium-win/fast/canvas/image-object-in-canvas-expected.checksum:
- platform/chromium-win/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium/test_expectations.txt:
- 4:46 PM Changeset in webkit [65100] by
-
- 3 edits in trunk/WebCore
2010-08-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
SegmentedString should keep track of how many characters it consumes
https://bugs.webkit.org/show_bug.cgi?id=43765
The easiest way to keep track of how many characters we've consumed
would be to increment a counter every time we advance, but that's too
slow. Instead, we keep track lazily and update our summary durning the
slow case of advance (which is sufficiently rare).
There's some subtly to how this works w.r.t. "unconsuming" characters
by pushing them back on the front of the segmented string. This isn't
really a "right answer" here because the notion of unconsuming input
isn't present in the API. This patch makes some assumptions about how
clients of this class use its API. In a future patch, we might want to
rename some of the method names to make this more explicit.
- platform/text/SegmentedString.cpp: (WebCore::SegmentedString::operator=): (WebCore::SegmentedString::append): (WebCore::SegmentedString::prepend): (WebCore::SegmentedString::advanceSubstring):
- platform/text/SegmentedString.h: (WebCore::SegmentedSubstring::numberOfCharactersConsumed): (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::numberOfCharactersConsumed):
- 3:32 PM Changeset in webkit [65099] by
-
- 16 edits1 delete in trunk
Bug 43816 - Remove UStringImpl
The class was actually removed a long time ago, replaced by StringImpl.
UStringImpl is just a typedef onto StringImpl. Remove this.
- API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass):
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/JSString.cpp:
(JSC::JSString::resolveRope):
(JSC::JSString::replaceCharacter):
- runtime/JSString.h:
(JSC::RopeBuilder::RopeIterator::operator*):
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::appendStringInConstruct):
(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::jsSingleCharacterSubstring):
(JSC::jsSubstring):
- runtime/JSStringBuilder.h:
(JSC::jsMakeNontrivialString):
- runtime/RopeImpl.cpp:
(JSC::RopeImpl::derefFibersNonRecursive):
- runtime/RopeImpl.h:
(JSC::RopeImpl::deref):
- runtime/SmallStrings.cpp:
(JSC::SmallStringsStorage::SmallStringsStorage):
- runtime/StringConstructor.cpp:
(JSC::stringFromCharCodeSlowCase):
- runtime/StringPrototype.cpp:
(JSC::jsSpliceSubstringsWithSeparators):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncLink):
- runtime/UString.cpp:
(JSC::initializeUString):
- runtime/UString.h:
(JSC::UString::adopt):
(JSC::tryMakeString):
(JSC::makeString):
- runtime/UStringImpl.h: Removed.
WebCore:
Rubber stamped by Sam Weinig.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMBinding.cpp:
(WebCore::findAtomicString):
- 3:24 PM Changeset in webkit [65098] by
-
- 2 edits in trunk/WebKitTools
2010-08-10 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Ojan Vafai.
[Chromium/DRT] Enable saving layout test results.
https://bugs.webkit.org/show_bug.cgi?id=43796
- BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more
parameters to the new-run-webkit-tests, including the name
of the test results server.
- 3:02 PM Changeset in webkit [65097] by
-
- 5 edits in trunk
2010-08-09 Stephen White <senorblanco@chromium.org>
Reviewed by David Levin.
Prefer the medium-quality (bilinear) image resampling for 2D canvas on
Chromium.
https://bugs.webkit.org/show_bug.cgi?id=43646
This is what the accelerated path is going to do,
so do it in the software path as well.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer):
- platform/graphics/GraphicsContext.h:
2010-08-09 Stephen White <senorblanco@chromium.org>
Reviewed by David Levin.
Temporarily mark html/canvas/image-object-in-canvas.html as failing.
https://bugs.webkit.org/show_bug.cgi?id=43646
- platform/chromium/test_expectations.txt:
- 2:50 PM Changeset in webkit [65096] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-10 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Roll forward Chromium DEPS to r55584
https://bugs.webkit.org/show_bug.cgi?id=43811
- DEPS:
- 2:35 PM Changeset in webkit [65095] by
-
- 3 edits2 adds in trunk
Removing an element from an anonymous block causes crash
https://bugs.webkit.org/show_bug.cgi?id=42309
Reviewed by Dave Hyatt.
WebCore:
There was a case where a continuation was added as a child, but if you asked
that child who is your parent, it would return the wrong answer.
The specific scenario was when a sibling of an element who was the start of a
continuation was present. Retrieving the parent object had then follow the sibling
chain and then follow the originating continuation chain.
Test: accessibility/removed-anonymous-block-child-causes-crash.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::nextSibling):
Fix erroneous comment
(WebCore::nextContinuation):
(WebCore::AccessibilityRenderObject::renderParentObject):
Handle unhandled continuation case.
(WebCore::AccessibilityRenderObject::addChildren):
ASSERT that the parentObject() is the same when adding a new child.
LayoutTests:
- accessibility/removed-anonymous-block-child-causes-crash-expected.txt: Added.
- accessibility/removed-anonymous-block-child-causes-crash.html: Added.
- 2:35 PM Changeset in webkit [65094] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-10 Kavita Kanetkar <kkanetkar@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: Support appcache status change for Chrome
https://bugs.webkit.org/show_bug.cgi?id=43531
- src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::notifyDOMApplicationCache):
- 2:27 PM Changeset in webkit [65093] by
-
- 5 edits in trunk/WebKit/chromium
2010-08-10 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Use Chromium OpenGL bindings rather than GLEW in WebGraphicsContextDefaultImpl
https://bugs.webkit.org/show_bug.cgi?id=43754
Deleted per-platform OpenGL context management code, now
abstracted via GLContext. Built and tested in Chromium with
--in-process-webgl flag.
- WebKit.gyp:
- src/GraphicsContext3D.cpp:
- src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes): (WebKit::WebGraphicsContext3DDefaultImpl::makeContextCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::copyTexImage2D): (WebKit::WebGraphicsContext3DDefaultImpl::copyTexSubImage2D): (WebKit::WebGraphicsContext3DDefaultImpl::readPixels): (WebKit::WebGraphicsContext3DDefaultImpl::createBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteBuffer):
- src/WebGraphicsContext3DDefaultImpl.h:
- 1:56 PM Changeset in webkit [65092] by
-
- 3 edits in trunk/WebKitTools
More chromium build fix.
- DumpRenderTree/chromium/MockSpellCheck.cpp:
(MockSpellCheck::spellCheckWord):
(MockSpellCheck::initializeIfNeeded):
- DumpRenderTree/chromium/NotificationPresenter.cpp:
(NotificationPresenter::grantPermission):
(NotificationPresenter::show):
(NotificationPresenter::checkPermission):
- 1:47 PM Changeset in webkit [65091] by
-
- 2 edits in trunk/JavaScriptCore
2010-08-10 Patrick Gansterer <paroga@paroga.com>
Reviewed by Eric Seidel.
Make FastMalloc more portable.
https://bugs.webkit.org/show_bug.cgi?id=41790
- wtf/FastMalloc.cpp: (WTF::TCMalloc_Central_FreeList::Populate): (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
- 1:46 PM Changeset in webkit [65090] by
-
- 3 edits2 adds in trunk
2010-08-10 Abhishek Arya <inferno@chromium.org>
Reviewed by David Hyatt.
Take checks for ruby base existence out of the ASSERTs.
https://bugs.webkit.org/show_bug.cgi?id=43795
Test: fast/ruby/ruby-remove-no-base.html
- rendering/RenderRubyRun.cpp: (WebCore::RenderRubyRun::addChild): (WebCore::RenderRubyRun::removeChild):
2010-08-10 Abhishek Arya <inferno@chromium.org>
Reviewed by David Hyatt.
Tests that removing a ruby child which causes merging of ruby base withe
a non existant base of the right sibling run does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=43795
- fast/ruby/ruby-remove-no-base-expected.txt: Added.
- fast/ruby/ruby-remove-no-base.html: Added.
- 1:44 PM Changeset in webkit [65089] by
-
- 8 edits in trunk
2010-08-06 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
texture functions should gen INVALID_OPERATION if no texture is bound
https://bugs.webkit.org/show_bug.cgi?id=42907
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexImage2D): Check if a texture is bound to target. (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto. (WebCore::WebGLRenderingContext::generateMipmap): Ditto. (WebCore::WebGLRenderingContext::getTexParameter): Ditto. (WebCore::WebGLRenderingContext::texImage2DBase): Ditto. (WebCore::WebGLRenderingContext::texParameter): Ditto. (WebCore::WebGLRenderingContext::texSubImage2DBase): Ditto. (WebCore::WebGLRenderingContext::validateTextureBinding): Check if target is valid and if a texture is bound to it.
- html/canvas/WebGLRenderingContext.h: Declare validateTextureBinding().
2010-08-06 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
texture functions should gen INVALID_OPERATION if no texture is bound
https://bugs.webkit.org/show_bug.cgi?id=42907
- fast/canvas/webgl/gl-enum-tests-expected.txt: Need to bind a texture before testing tex-functions.
- fast/canvas/webgl/gl-enum-tests.html: Ditto.
- fast/canvas/webgl/null-object-behaviour-expected.txt: Test tex-functions when no texture is bound.
- fast/canvas/webgl/null-object-behaviour.html: Ditto.
- 1:38 PM Changeset in webkit [65088] by
-
- 3 edits in trunk/WebKitTools
Chromium build fix.
- DumpRenderTree/chromium/MockSpellCheck.cpp:
- DumpRenderTree/chromium/NotificationPresenter.cpp:
- 1:29 PM Changeset in webkit [65087] by
-
- 2 edits in trunk/WebCore
2010-08-10 Patrick Gansterer <paroga@paroga.com>
Reviewed by Sam Weinig.
[WINCE] Implement Path::currentPoint()
https://bugs.webkit.org/show_bug.cgi?id=42927
- platform/graphics/wince/PathWince.cpp: (WebCore::Path::currentPoint):
- 1:13 PM Changeset in webkit [65086] by
-
- 2 edits in trunk/WebCore
2010-08-10 Ariya Hidayat <ariya@sencha.com>
[Qt] Warning fix, remove reference to platform/text/StringImpl.h
- WebCore.pro:
- 12:59 PM Changeset in webkit [65085] by
-
- 2 edits in trunk/WebKit/chromium
Another chromium build fix.
- src/AssertMatchingEnums.cpp:
- 12:52 PM Changeset in webkit [65084] by
-
- 2 edits in trunk/WebCore
Chromium build fix attempt. not reviewed
- platform/text/TextBoundaries.cpp: use correct stringimplh include
- 12:06 PM Changeset in webkit [65083] by
-
- 3 edits in trunk/WebCore
Chromium build fix.
- platform/graphics/chromium/FontPlatformDataChromiumWin.h:
- platform/graphics/chromium/FontPlatformDataLinux.cpp:
- 11:57 AM Changeset in webkit [65082] by
-
- 16 edits2 adds in trunk
2010-08-10 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
Change the ScriptController::processingUserGesture to static method
and use dynamic(JSC binding)/entered(V8 binding) frame to check the user gesture.
https://bugs.webkit.org/show_bug.cgi?id=42827.
Test: fast/events/popup-blocked-from-iframe-script.html
- WebCore.order:
- bindings/js/JSDOMBinding.cpp: (WebCore::processingUserGesture):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::createWindow): (WebCore::domWindowAllowPopUp): (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog):
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
- bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::JSLocation::reload):
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
- bindings/js/ScriptController.h:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::ScriptController::anyPageIsProcessingUserGesture):
- bindings/v8/ScriptController.h:
- bindings/v8/specialization/V8BindingState.cpp: (WebCore::::processingUserGesture):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::isProcessingUserGesture):
2010-08-10 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
Change the ScriptController::processingUserGesture to static method
and use dynamic(JSC binding)/entered(V8 binding) frame to check the user gesture.
https://bugs.webkit.org/show_bug.cgi?id=42827
- fast/events/popup-blocked-from-iframe-script-expected.txt: Added.
- fast/events/popup-blocked-from-iframe-script.html: Added.
- 11:50 AM Changeset in webkit [65081] by
-
- 2 edits in trunk/JavaScriptCore
2010-08-10 Patrick Gansterer <paroga@paroga.com>
Reviewed by David Levin.
[WINCE] Buildfix for CE 6.0
https://bugs.webkit.org/show_bug.cgi?id=43027
CE 6.0 doesn't define localtime in the system include files.
- wtf/Platform.h: Include ce_time.h on all OS(WINCE).
- 11:39 AM Changeset in webkit [65080] by
-
- 3 edits in trunk/WebKitTools
2010-08-10 Victor Wang <victorw@chromium.org>
Reviewed by Ojan Vafai.
Update test results server merge logic so the aggregated
results and times are updated for tests that are
in aggragated json but not in incremental json.
Also update unittest to test this case.
- TestResultServer/model/jsonresults.py:
- TestResultServer/model/jsonresults_unittest.py:
- 11:22 AM Changeset in webkit [65079] by
-
- 2 edits in trunk/WebCore
Chromium build fix
- platform/graphics/chromium/FontPlatformDataLinux.h:
- 11:22 AM Changeset in webkit [65078] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
Skipping editing/selection/selection-modify-crash.html (added by r65061) on gtk
because it has been crashing on gtk since r65061 and it doesn't crash on other platforms.
- platform/gtk/Skipped:
- 10:45 AM Changeset in webkit [65077] by
-
- 228 edits1 move1 add4 deletes in trunk
Bug 43786 - Move AtomicStringHash from WebCore to WTF
Also remove deprecated string headers from WebCore/platform/text.
Rubber stamped by Sam Weinig.
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/text/AtomicString.h:
- wtf/text/AtomicStringHash.h: Copied from WebCore/platform/text/AtomicStringHash.h.
WebCore:
- ForwardingHeaders/wtf/text/AtomicStringHash.h: Added.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
- bindings/cpp/WebDOMHTMLCollectionCustom.cpp:
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
- bindings/js/JSClipboardCustom.cpp:
- bindings/js/JSDOMApplicationCacheCustom.cpp:
- bindings/js/JSDOMMimeTypeArrayCustom.cpp:
- bindings/js/JSDOMPluginArrayCustom.cpp:
- bindings/js/JSDOMPluginCustom.cpp:
- bindings/js/JSDOMStringMapCustom.cpp:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSDataGridColumnListCustom.cpp:
- bindings/js/JSHTMLAllCollectionCustom.cpp:
- bindings/js/JSHTMLCollectionCustom.cpp:
- bindings/js/JSMessagePortCustom.cpp:
- bindings/js/JSNodeListCustom.cpp:
- bindings/scripts/CodeGeneratorCPP.pm:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
- bindings/scripts/test/V8/V8TestInterface.h:
- bindings/scripts/test/V8/V8TestObj.h:
- bindings/v8/ScriptDebugServer.h:
- bindings/v8/V8Binding.cpp:
- bindings/v8/V8Binding.h:
- bridge/jni/v8/JavaClassV8.h:
- css/CSSFontFaceSource.h:
- css/CSSFontSelector.cpp:
- css/CSSFontSelector.h:
- css/CSSNamespace.h:
- css/CSSParser.cpp:
- css/CSSParser.h:
- css/CSSParserValues.h:
- css/CSSStyleSelector.h:
- css/CSSVariablesDeclaration.h:
- css/MediaFeatureNames.h:
- css/MediaQueryExp.h:
- css/WebKitCSSKeyframesRule.h:
- dom/CustomEvent.h:
- dom/Document.cpp:
- dom/Event.cpp:
- dom/Event.h:
- dom/EventNames.h:
- dom/EventTarget.h:
- dom/InputElement.h:
- dom/MessagePort.cpp:
- dom/MessagePort.h:
- dom/NameNodeList.h:
- dom/NodeRareData.h:
- dom/QualifiedName.h:
- dom/ScriptElement.cpp:
- dom/SpaceSplitString.h:
- dom/TagNodeList.h:
- dom/XMLDocumentParser.h:
- editing/EditorCommand.cpp:
- history/mac/HistoryItemMac.mm:
- html/BlobBuilder.cpp:
- html/DataGridColumn.h:
- html/DataGridColumnList.cpp:
- html/HTMLDocument.h:
- html/HTMLInputElement.cpp:
- html/HTMLTokenizer.cpp:
- html/HTMLTokenizer.h:
- html/LegacyPreloadScanner.cpp:
- html/LegacyPreloadScanner.h:
- inspector/InspectorCSSStore.h:
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorValues.h:
- loader/Cache.h:
- loader/CrossOriginAccessControl.cpp:
- loader/CrossOriginPreflightResultCache.h:
- loader/DocLoader.h:
- loader/ImageLoader.h:
- loader/appcache/ApplicationCache.h:
- loader/appcache/ApplicationCacheStorage.h:
- loader/appcache/DOMApplicationCache.h:
- loader/icon/IconDatabase.h:
- loader/icon/IconRecord.h:
- loader/loader.h:
- notifications/Notification.h:
- page/FrameTree.h:
- page/Page.cpp:
- page/PageGroup.h:
- page/SecurityOrigin.h:
- page/Settings.h:
- page/WindowFeatures.cpp:
- page/animation/AnimationBase.h:
- page/animation/AnimationControllerPrivate.h:
- page/animation/CompositeAnimation.h:
- platform/Cookie.h:
- platform/KURL.cpp:
- platform/KURLGoogle.cpp:
- platform/KURLHash.h:
- platform/Length.cpp:
- platform/LinkHash.cpp:
- platform/LinkHash.h:
- platform/MIMETypeRegistry.cpp:
- platform/MIMETypeRegistry.h:
- platform/SchemeRegistry.h:
- platform/ThreadGlobalData.cpp:
- platform/ThreadGlobalData.h:
- platform/cf/BinaryPropertyList.cpp:
- platform/chromium/SearchPopupMenuChromium.cpp:
- platform/efl/ClipboardEfl.cpp:
- platform/efl/CookieJarEfl.cpp:
- platform/efl/PlatformKeyboardEventEfl.cpp:
- platform/graphics/FontCache.cpp:
- platform/graphics/FontFamily.h:
- platform/graphics/MediaPlayer.h:
- platform/graphics/cg/ImageSourceCGWin.cpp:
- platform/graphics/chromium/FontCacheChromiumWin.cpp:
- platform/graphics/chromium/FontCacheLinux.cpp:
- platform/graphics/chromium/FontUtilsChromiumWin.cpp:
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/filters/Filter.h:
- platform/graphics/mac/FontPlatformData.h:
- platform/graphics/mac/GraphicsLayerCA.h:
- platform/graphics/qt/FontCacheQt.cpp:
- platform/graphics/win/FontCacheWin.cpp:
- platform/graphics/win/FontPlatformDataCGWin.cpp:
- platform/graphics/win/FontPlatformDataCairoWin.cpp:
- platform/graphics/win/FontPlatformDataWin.cpp:
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
- platform/graphics/win/WKCACFLayer.h:
- platform/graphics/wince/FontPlatformData.cpp:
- platform/graphics/wx/FontPlatformData.h:
- platform/gtk/ClipboardGtk.cpp:
- platform/gtk/DataObjectGtk.h:
- platform/haiku/ClipboardHaiku.cpp:
- platform/haiku/CookieJarHaiku.cpp:
- platform/haiku/SearchPopupMenuHaiku.cpp:
- platform/mac/SearchPopupMenuMac.mm:
- platform/mac/ThreadCheck.mm:
- platform/network/CredentialStorage.cpp:
- platform/network/HTTPHeaderMap.h:
- platform/network/cf/DNSCFNet.cpp:
- platform/network/curl/CookieJarCurl.cpp:
- platform/qt/ClipboardQt.cpp:
- platform/text/AtomicString.h: Removed.
- platform/text/AtomicStringHash.h: Removed.
- platform/text/AtomicStringImpl.h: Removed.
- platform/text/AtomicStringKeyedMRUCache.h:
- platform/text/StringBuilder.cpp:
- platform/text/StringHash.h: Removed.
- platform/text/StringImpl.h: Removed.
- platform/text/TextCodecLatin1.cpp:
- platform/text/TextCodecUTF16.cpp:
- platform/text/TextCodecUserDefined.cpp:
- platform/text/cf/HyphenationCF.cpp:
- platform/text/cf/StringImplCF.cpp:
- platform/text/mac/HyphenationMac.mm:
- platform/text/mac/StringImplMac.mm:
- platform/text/transcoder/FontTranscoder.h:
- platform/text/wince/TextCodecWinCE.cpp:
- platform/win/BString.cpp:
- platform/win/ClipboardWin.cpp:
- platform/win/SearchPopupMenuWin.cpp:
- platform/wince/SearchPopupMenuWince.cpp:
- platform/wx/ClipboardWx.cpp:
- plugins/DOMMimeTypeArray.cpp:
- plugins/DOMPlugin.cpp:
- plugins/DOMPluginArray.cpp:
- plugins/PluginDatabase.h:
- plugins/PluginPackage.h:
- plugins/PluginStream.h:
- rendering/RenderApplet.h:
- rendering/RenderText.cpp:
- rendering/style/BindingURI.h:
- rendering/style/ContentData.cpp:
- rendering/style/CounterContent.h:
- rendering/style/CounterDirectives.h:
- rendering/style/KeyframeList.h:
- rendering/style/StyleRareInheritedData.h:
- storage/AbstractDatabase.cpp:
- storage/DatabaseAuthorizer.h:
- storage/DatabaseTracker.h:
- storage/IDBDatabaseBackendImpl.h:
- storage/IDBFactoryBackendImpl.h:
- storage/IDBObjectStoreBackendImpl.h:
- storage/OriginQuotaManager.h:
- storage/OriginUsageRecord.h:
- storage/SQLTransactionCoordinator.h:
- storage/StorageAreaSync.h:
- storage/StorageMap.h:
- storage/StorageNamespaceImpl.cpp:
- storage/chromium/QuotaTracker.h:
- svg/SVGAltGlyphElement.h:
- svg/SVGDocumentExtensions.cpp:
- svg/SVGDocumentExtensions.h:
- svg/SVGFitToViewBox.cpp:
- svg/SVGLangSpace.h:
- svg/animation/SMILTimeContainer.h:
- svg/graphics/filters/SVGFilterBuilder.h:
- websockets/WebSocket.h:
- websockets/WebSocketChannel.cpp:
- websockets/WebSocketHandshake.cpp:
- websockets/WebSocketHandshakeResponse.cpp:
- wml/WMLPageState.h:
- workers/AbstractWorker.h:
- workers/DefaultSharedWorkerRepository.h:
- workers/Worker.h:
- workers/WorkerContext.h:
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequestUpload.cpp:
- xml/XMLHttpRequestUpload.h:
- xml/XPathExpressionNode.h:
- xml/XPathNamespace.h:
- xml/XPathParser.cpp:
- xml/XSLTProcessor.h:
WebKit/chromium:
- src/WebKit.cpp:
- src/WebPageSerializerImpl.h:
- src/WebString.cpp:
WebKit/gtk:
- gdom/ConvertToGCharPrivate.h:
WebKit/wx:
- WebEdit.cpp:
- 10:34 AM Changeset in webkit [65076] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-10 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Feature defines are out of sync between features.gypi and downstream feature_overrides.gypi
https://bugs.webkit.org/show_bug.cgi?id=43756
This synchronizes the feature defines to what's currently downstream (at r55468).
The difference between the build.webkit.org bots and the chromium bots has
caused strange compilation failures lately.
- features.gypi:
- 9:50 AM Changeset in webkit [65075] by
-
- 3 edits in trunk/WebCore
2010-08-10 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Adding changes that escaped from r65072.
Web Inspector: move database processing to native layer.
https://bugs.webkit.org/show_bug.cgi?id=43788
- inspector/front-end/InspectorBackendStub.js: (WebInspector.InspectorBackendStub):
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype._genericViewSetup):
- 9:43 AM Changeset in webkit [65074] by
-
- 2 edits in trunk/WebCore
2010-08-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Inputs of type 'search' have weird looking checkboxes instead of search/clear icons
https://bugs.webkit.org/show_bug.cgi?id=43760
Draw appropriate GTK+ stock images for search/clear icons in search entries.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintSearchFieldResultsButton): (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): (WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
- 9:31 AM Changeset in webkit [65073] by
-
- 2 edits in trunk/WebCore
2010-08-10 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Qt build fix, follow up for r65072.
- inspector/InspectorController.cpp: (WebCore::InspectorController::releaseFrontendLifetimeAgents):
- 9:06 AM Changeset in webkit [65072] by
-
- 26 edits1 copy1 add in trunk/WebCore
2010-08-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move database processing to native layer.
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- bindings/js/JSInjectedScriptHostCustom.cpp:
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
- inspector/CodeGeneratorInspector.pm:
- inspector/InjectedScript.cpp: (WebCore::InjectedScript::dispatch):
- inspector/InjectedScript.h:
- inspector/InjectedScriptHost.cpp:
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptHost.idl:
- inspector/Inspector.idl:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript): (WebCore::InspectorBackend::executeSQL):
- inspector/InspectorBackend.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents):
- inspector/InspectorController.h:
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorStorageAgent.cpp: Added. (WebCore::): (WebCore::InspectorStorageAgent::InspectorStorageAgent): (WebCore::InspectorStorageAgent::~InspectorStorageAgent): (WebCore::InspectorStorageAgent::executeSQL): (WebCore::InspectorStorageAgent::clearFrontend):
- inspector/InspectorStorageAgent.h: Added. (WebCore::InspectorStorageAgent::create): (WebCore::InspectorStorageAgent::frontend):
- inspector/front-end/Database.js: (WebInspector.Database.prototype.executeSql): (WebInspector.sqlTransactionSucceeded): (WebInspector.sqlTransactionFailed):
- inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._queryFinished): (WebInspector.DatabaseQueryView.prototype._queryError):
- inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView.prototype._queryFinished):
- inspector/front-end/InjectedScript.js:
- inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName): (InjectedScriptAccess._installHandler):
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.dataGridForResult):
- 7:14 AM Changeset in webkit [65071] by
-
- 2 edits in trunk/WebCore
2010-08-10 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
[V8] DeviceMotionEvent can not be used from JavaScript
https://bugs.webkit.org/show_bug.cgi?id=43785
This is tested by the existing tests fast/dom/DeviceMotion/create-event.html
and fast/dom/DeviceMotion/optional-event-properties.html.
- bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
- 6:52 AM Changeset in webkit [65070] by
-
- 7 edits3 adds in trunk
2010-08-10 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Antonio Gomes.
[Qt] Build WebKit2 into a static lib
Just build changes so no new tests.
- WebCore.pri: Moved feature detection logic into features.pri since we need this in WebKit2.pro as well.
- WebCore.pro: Moved the specification of the WebKit2 build to WebKit2.pro. Link against the static lib.
- features.pri: Added.
2010-08-10 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Antonio Gomes.
[Qt] Build WebKit2 into a static lib
- WebKit.pro: Moved WebKit2 into the subdirs before WebCore since WebCore links against the WebKit2 lib.
2010-08-10 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Antonio Gomes.
[Qt] Build WebKit2 into a static lib
- WebKit2.pri: Added. Defined addWebKit2Lib function that defines how to link against the static lib.
- WebKit2.pro: Build specification for the WebKit2 framework.
- WebProcess.pro: Copied from WebKit2/WebKit2.pro. Build specification for the WebProcess binary.
- 6:23 AM Changeset in webkit [65069] by
-
- 6 edits in trunk/WebKit/chromium
2010-08-10 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: get rid of utility context
https://bugs.webkit.org/show_bug.cgi?id=43787
- public/WebDevToolsAgentClient.h:
- src/DebuggerAgentImpl.cpp:
- src/DebuggerAgentImpl.h:
- src/WebDevToolsAgentImpl.cpp: (WebKit::): (WebKit::WebDevToolsAgentImpl::~WebDevToolsAgentImpl): (WebKit::WebDevToolsAgentImpl::attach): (WebKit::WebDevToolsAgentImpl::detach): (WebKit::WebDevToolsAgentImpl::frontendLoaded): (WebKit::WebDevToolsAgentImpl::setRuntimeFeatureEnabled): (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled):
- src/WebDevToolsAgentImpl.h:
- 5:42 AM Changeset in webkit [65068] by
-
- 8 edits in trunk
2010-08-10 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector, Chromium: reloading of inspected page hits assert in InspectorController::enableDebuggerFromFrontend()
https://bugs.webkit.org/show_bug.cgi?id=43780
- inspector/CodeGeneratorInspector.pm:
- inspector/InspectorController.cpp: (WebCore::InspectorController::enableDebuggerFromFrontend):
- inspector/InspectorController.h: (WebCore::InspectorController::hasFrontend):
- inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::create): (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState): (WebCore::InspectorDebuggerAgent::didParseSource): (WebCore::InspectorDebuggerAgent::failedToParseSource): (WebCore::InspectorDebuggerAgent::didPause): (WebCore::InspectorDebuggerAgent::didContinue):
- inspector/InspectorDebuggerAgent.h:
2010-08-10 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector, Chromium: reloading of inspected page hits assert in InspectorController::enableDebuggerFromFrontend()
https://bugs.webkit.org/show_bug.cgi?id=43780
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setRuntimeFeatureEnabled):
- 4:34 AM Changeset in webkit [65067] by
-
- 2 edits in trunk/WebCore
Make sure NPAPI plugins get an initial setNPWindow on Mac
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=43782
- plugins/mac/PluginViewMac.mm:
- 4:20 AM Changeset in webkit [65066] by
-
- 3 edits2 adds in trunk/LayoutTests
2010-08-09 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Accelerometer tests need V8 results
https://bugs.webkit.org/show_bug.cgi?id=43443
This patch adds V8-specific results for Android for the existing window-property.html test.
- fast/dom/DeviceMotion/script-tests/window-property.js:
- fast/dom/DeviceMotion/window-property-expected.txt:
- platform/android-v8/fast/dom/DeviceMotion: Added.
- platform/android-v8/fast/dom/DeviceMotion/window-property-expected.txt: Added.
- 4:12 AM Changeset in webkit [65065] by
-
- 17 edits in trunk/WebCore
2010-08-10 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Use SVGPathParser to create SVG paths and to perform path animations
https://bugs.webkit.org/show_bug.cgi?id=43696
Removed toString() functions in all SVGPathSeg* objects as well as toPath() in SVGPathSegList.
These hacks were used to create a SVG path data string or a platform path from a SVGPathSegList.
Use the new SVGPathParser instead.
Doesn't affect any tests.
- svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::applyResultsToTarget):
- svg/SVGPathElement.cpp: (WebCore::SVGPathElement::toPathData):
- svg/SVGPathParserFactory.cpp: (WebCore::SVGPathParserFactory::buildPathFromSVGPathSegList): (WebCore::SVGPathParserFactory::buildStringFromByteStream): (WebCore::SVGPathParserFactory::buildStringFromSVGPathSegList):
- svg/SVGPathParserFactory.h:
- svg/SVGPathSeg.cpp:
- svg/SVGPathSeg.h:
- svg/SVGPathSegArc.cpp:
- svg/SVGPathSegArc.h:
- svg/SVGPathSegClosePath.h: (WebCore::SVGPathSegClosePath::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoCubic.h:
- svg/SVGPathSegCurvetoCubicSmooth.h:
- svg/SVGPathSegCurvetoQuadratic.h:
- svg/SVGPathSegLinetoHorizontal.h:
- svg/SVGPathSegLinetoVertical.h:
- svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::getPathSegAtLength):
- svg/SVGPathSegList.h:
- 3:49 AM Changeset in webkit [65064] by
-
- 5 edits2 deletes in trunk
2010-08-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65056.
http://trac.webkit.org/changeset/65056
https://bugs.webkit.org/show_bug.cgi?id=43773
"Clearly I missed something. I'm too tired to try and fix
now. Will re-land in the morning." (Requested by eseidel on
#webkit).
- html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attach):
- html/HTMLElement.cpp: (WebCore::HTMLElement::insertAdjacentHTML):
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInCell):
2010-08-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65056.
http://trac.webkit.org/changeset/65056
https://bugs.webkit.org/show_bug.cgi?id=43773
"Clearly I missed something. I'm too tired to try and fix
now. Will re-land in the morning." (Requested by eseidel on
#webkit).
- fast/dom/HTMLElement/insertAdjacentHTML-errors-expected.txt: Removed.
- fast/dom/HTMLElement/insertAdjacentHTML-errors.html: Removed.
- 3:13 AM Changeset in webkit [65063] by
-
- 5 edits9 adds in trunk/WebKit/chromium
2010-08-10 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
Implement chromium WebDeviceOrientationClient wrapper and have WebViewImpl get it from WebViewClient.
https://bugs.webkit.org/show_bug.cgi?id=43258
Provide a DeviceOrientationClient to Page by means of a
DeviceOrientationClientProxy that proxies calls to
a WebDeviceOrientationClient, an interface that can be implemented
in the WebKit or Chromium layer. An implementation to be used for
layout tests, wrapping DeviceOrientationClientMock, is provided.
- WebKit.gyp:
- public/WebDeviceOrientation.h: Added. (WebKit::WebDeviceOrientation::WebDeviceOrientation):
- public/WebDeviceOrientationClient.h: Added. (WebKit::WebDeviceOrientationClient::~WebDeviceOrientationClient):
- public/WebDeviceOrientationClientMock.h: Added. (WebKit::WebDeviceOrientationClientMock::WebDeviceOrientationClientMock): (WebKit::WebDeviceOrientationClientMock::~WebDeviceOrientationClientMock):
- public/WebDeviceOrientationController.h: Added. (WebKit::WebDeviceOrientationController::WebDeviceOrientationController):
- public/WebViewClient.h: (WebKit::WebViewClient::deviceOrientationClient):
- src/DeviceOrientationClientProxy.cpp: Added. (WebKit::DeviceOrientationClientProxy::setController): (WebKit::DeviceOrientationClientProxy::startUpdating): (WebKit::DeviceOrientationClientProxy::stopUpdating): (WebKit::DeviceOrientationClientProxy::lastOrientation):
- src/DeviceOrientationClientProxy.h: Added. (WebKit::DeviceOrientationClientProxy::DeviceOrientationClientProxy):
- src/WebDeviceOrientation.cpp: Added. (WebKit::WebDeviceOrientation::WebDeviceOrientation): (WebKit::WebDeviceOrientation::operator=): (WebKit::WebDeviceOrientation::operator PassRefPtr<WebCore::DeviceOrientation>):
- src/WebDeviceOrientationClientMock.cpp: Added. (WebKit::WebDeviceOrientationClientMock::setController): (WebKit::WebDeviceOrientationClientMock::startUpdating): (WebKit::WebDeviceOrientationClientMock::stopUpdating): (WebKit::WebDeviceOrientationClientMock::lastOrientation): (WebKit::WebDeviceOrientationClientMock::setOrientation): (WebKit::WebDeviceOrientationClientMock::initialize): (WebKit::WebDeviceOrientationClientMock::reset):
- src/WebDeviceOrientationController.cpp: Added. (WebKit::WebDeviceOrientationController::didChangeDeviceOrientation): (WebKit::WebDeviceOrientationController::controller):
- src/WebViewImpl.cpp: (WebKit::WebView::create): (WebKit::WebViewImpl::WebViewImpl):
- src/WebViewImpl.h:
- 3:08 AM Changeset in webkit [65062] by
-
- 5 edits2 adds in trunk
2010-08-10 Yoshiki Hayashi <yhayashi@google.com>
Reviewed by Kent Tamura.
Iterate over :first-letter so that it will be included in innerText.
https://bugs.webkit.org/show_bug.cgi?id=39863
Test: fast/dom/inner-text-first-letter.html
- editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): (WebCore::TextIterator::advance): (WebCore::TextIterator::handleTextNode): (WebCore::TextIterator::handleTextBox): (WebCore::TextIterator::emitText):
- editing/TextIterator.h:
2010-08-10 Yoshiki Hayashi <yhayashi@google.com>
Reviewed by Kent Tamura.
Iterate over :first-letter so that it will be included in innerText.
https://bugs.webkit.org/show_bug.cgi?id=39863
- fast/dom/inner-text-first-letter-expected.txt: Added.
- fast/dom/inner-text-first-letter.html: Added.
- 2:26 AM Changeset in webkit [65061] by
-
- 3 edits2 adds in trunk
Fix crashes by SelectionController::modify().
https://bugs.webkit.org/show_bug.cgi?id=43032
Reviewed by Darin Adler.
WebCore:
Test: editing/selection/selection-modify-crash.html
- editing/visible_units.cpp:
(WebCore::endOfDocument): Add NULL-check for document()->documentElement().
LayoutTests:
- editing/selection/selection-modify-crash-expected.txt: Added.
- editing/selection/selection-modify-crash.html: Added.
- 2:05 AM Changeset in webkit [65060] by
-
- 3 edits in trunk/WebKit/chromium
2010-08-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64988.
http://trac.webkit.org/changeset/64988
https://bugs.webkit.org/show_bug.cgi?id=43775
"It seems to break chromium's ui_tests" (Requested by hamaji
on #webkit).
- public/WebFrameClient.h:
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
- 1:47 AM Changeset in webkit [65059] by
-
- 15 edits2 adds in trunk/WebCore
2010-08-10 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Add missing SVGPathSegList source for SVGPathParser
https://bugs.webkit.org/show_bug.cgi?id=43691
Added SVGPathSegListSource to parse normalized or unaltered SVGPathSegLists and transform
them to either a SVG path string, or a SVGPathByteStream. This will be needed to synchronize
all SVGPathSegLists and the SVG path string of the 'd' attribute.
Refactored SVGPathSource code, to read concrete path segments instead of type/flag/coordinates
from the data sources. This is a further abstraction and seperates the reading of content from
the parsing and interpreting.
Doesn't affect any tests.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- svg/SVGAllInOne.cpp:
- svg/SVGPathByteStreamSource.cpp: (WebCore::SVGPathByteStreamSource::parseSVGSegmentType): (WebCore::SVGPathByteStreamSource::nextCommand): (WebCore::SVGPathByteStreamSource::parseMoveToSegment): (WebCore::SVGPathByteStreamSource::parseLineToSegment): (WebCore::SVGPathByteStreamSource::parseLineToHorizontalSegment): (WebCore::SVGPathByteStreamSource::parseLineToVerticalSegment): (WebCore::SVGPathByteStreamSource::parseCurveToCubicSegment): (WebCore::SVGPathByteStreamSource::parseCurveToCubicSmoothSegment): (WebCore::SVGPathByteStreamSource::parseCurveToQuadraticSegment): (WebCore::SVGPathByteStreamSource::parseCurveToQuadraticSmoothSegment): (WebCore::SVGPathByteStreamSource::parseArcToSegment):
- svg/SVGPathByteStreamSource.h: (WebCore::SVGPathByteStreamSource::moveToNextToken):
- svg/SVGPathParser.cpp: (WebCore::SVGPathParser::parseMoveToSegment): (WebCore::SVGPathParser::parseLineToSegment): (WebCore::SVGPathParser::parseLineToHorizontalSegment): (WebCore::SVGPathParser::parseLineToVerticalSegment): (WebCore::SVGPathParser::parseCurveToCubicSegment): (WebCore::SVGPathParser::parseCurveToCubicSmoothSegment): (WebCore::SVGPathParser::parseCurveToQuadraticSegment): (WebCore::SVGPathParser::parseCurveToQuadraticSmoothSegment): (WebCore::SVGPathParser::parseArcToSegment):
- svg/SVGPathSegListSource.cpp: Added. (WebCore::SVGPathSegListSource::SVGPathSegListSource): (WebCore::SVGPathSegListSource::~SVGPathSegListSource): (WebCore::SVGPathSegListSource::hasMoreData): (WebCore::SVGPathSegListSource::parseSVGSegmentType): (WebCore::SVGPathSegListSource::nextCommand): (WebCore::SVGPathSegListSource::parseMoveToSegment): (WebCore::SVGPathSegListSource::parseLineToSegment): (WebCore::SVGPathSegListSource::parseLineToHorizontalSegment): (WebCore::SVGPathSegListSource::parseLineToVerticalSegment): (WebCore::SVGPathSegListSource::parseCurveToCubicSegment): (WebCore::SVGPathSegListSource::parseCurveToCubicSmoothSegment): (WebCore::SVGPathSegListSource::parseCurveToQuadraticSegment): (WebCore::SVGPathSegListSource::parseCurveToQuadraticSmoothSegment): (WebCore::SVGPathSegListSource::parseArcToSegment):
- svg/SVGPathSegListSource.h: Added. (WebCore::SVGPathSegListSource::create): (WebCore::SVGPathSegListSource::moveToNextToken):
- svg/SVGPathSource.h:
- svg/SVGPathStringSource.cpp: (WebCore::SVGPathStringSource::parseMoveToSegment): (WebCore::SVGPathStringSource::parseLineToSegment): (WebCore::SVGPathStringSource::parseLineToHorizontalSegment): (WebCore::SVGPathStringSource::parseLineToVerticalSegment): (WebCore::SVGPathStringSource::parseCurveToCubicSegment): (WebCore::SVGPathStringSource::parseCurveToCubicSmoothSegment): (WebCore::SVGPathStringSource::parseCurveToQuadraticSegment): (WebCore::SVGPathStringSource::parseCurveToQuadraticSmoothSegment): (WebCore::SVGPathStringSource::parseArcToSegment):
- svg/SVGPathStringSource.h:
- 1:41 AM Changeset in webkit [65058] by
-
- 2 edits in trunk/WebCore
2010-08-09 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: small refactoring for CodeGeneratorInspector.
A number of push calls were replaced by embedded text.
Just for improve code readability.
https://bugs.webkit.org/show_bug.cgi?id=43770
- inspector/CodeGeneratorInspector.pm:
- 12:49 AM Changeset in webkit [65057] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-10 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Remove references to deleted header InspectorFrontend.h
- src/WebDevToolsAgentImpl.cpp:
- 12:29 AM Changeset in webkit [65056] by
-
- 5 edits2 adds in trunk
2010-08-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix three ASSERTs hit with the HTML5 TreeBuilder in fragment mode
https://bugs.webkit.org/show_bug.cgi?id=43762
In order to fix the insertAdjacentHTML I had to change behavior.
The behavior I changed brings us closer to the HTML5 spec,
but since it was not previously tested, I added tests.
- fast/dom/HTMLElement/insertAdjacentHTML-errors-expected.txt: Added.
- fast/dom/HTMLElement/insertAdjacentHTML-errors.html: Added.
2010-08-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix three ASSERTs hit with the HTML5 TreeBuilder in fragment mode
https://bugs.webkit.org/show_bug.cgi?id=43762
In fixing the insertAdjacentHTML I had to make small changes to
the error logic, which ended up bringing us closer to HTML5.
Test: fast/dom/HTMLElement/insertAdjacentHTML-errors.html
- html/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::attach):
- This ASSERT was just wrong, the child should not be attached in the case the parent is not attached.
- html/HTMLElement.cpp:
(WebCore::contextElementForInsertion):
- This is part of HTML5, needed to know what to call the HTML or XML parsers with. The previous code always passed "this" which is wrong in the case of beforeBegin or afterEnd insertion.
(WebCore::HTMLElement::insertAdjacentHTML):
- Use the right contextElement now that we know how to compute it.
- html/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
- This ASSERT is direct from the spec, but it's wrong, so I've filed a spec bug.
- 12:25 AM Changeset in webkit [65055] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-10 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix Chromium compilation.
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::frontendLoaded):
- 12:12 AM Changeset in webkit [65054] by
-
- 3 edits in trunk/LayoutTests
2010-08-10 MORITA Hajime <morrita@google.com>
Unreviewed test fix.
https://bugs.webkit.org/show_bug.cgi?id=43771
[Chromium] Test: editing/selection/doubleclick-inline-first-last-contenteditable fails on win
Set platform selectTrailingWhitespaceEnabled false, which is true only on windows.
- editing/selection/script-tests/doubleclick-inline-first-last-contenteditable.js:
- platform/chromium/test_expectations.txt:
Aug 9, 2010:
- 11:59 PM Changeset in webkit [65053] by
-
- 13 edits2 deletes in trunk
2010-08-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove InspectorFrontend class and use RemoteInspectorFrontend instead.
https://bugs.webkit.org/show_bug.cgi?id=43726
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::close): (WebCore::InspectorController::disconnectFrontend):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: Removed.
- inspector/InspectorFrontend.h: Removed.
2010-08-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove InspectorFrontend class and use RemoteInspectorFrontend instead.
https://bugs.webkit.org/show_bug.cgi?id=43726
- http/tests/inspector/inspector-test.js: (notifyDone):
- 10:50 PM Changeset in webkit [65052] by
-
- 15 edits in trunk/WebCore
2010-08-09 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Remove obsolete JS wrappers for did* methods.
https://bugs.webkit.org/show_bug.cgi?id=43738
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- inspector/front-end/BreakpointManager.js:
- inspector/front-end/Callback.js:
- inspector/front-end/ConsoleView.js:
- inspector/front-end/DOMAgent.js:
- inspector/front-end/DOMStorage.js:
- inspector/front-end/Database.js:
- inspector/front-end/InjectedScriptAccess.js:
- inspector/front-end/ProfilesPanel.js:
- inspector/front-end/ResourcesPanel.js:
- inspector/front-end/ScriptView.js:
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/inspector.js: (WebInspector.reportProtocolError):
- 10:13 PM Changeset in webkit [65051] by
-
- 3 edits in trunk/JavaScriptCore
Fix Qt/ARM again, this time including the other changed file.
- 9:00 PM Changeset in webkit [65050] by
-
- 3 edits in trunk/WebKitTools
2010-08-09 Antonio Gomes <tonikitoo@webkit.org>
eviewed by Ariya Hidayat.
[Qt] QtTestBrowser: proper set scene rect
When resizesToContents is ON scene's rect is set to the boundary of
the mainFrame. However, navigating to other web page should keep resizing
scene's rect according to the new document loaded. Patch addresses this issue.
Now resizesToContents and scrolling properly work on QtTestBrowser.
- QtTestBrowser/webview.cpp: (WebViewGraphicsBased::setPage): (WebViewGraphicsBased::contentsSizeChanged): (WebViewGraphicsBased::setResizesToContents): (WebViewGraphicsBased::resizeEvent):
- QtTestBrowser/webview.h:
- 8:59 PM Changeset in webkit [65049] by
-
- 2 edits in trunk/WebKitTools
2010-08-09 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Ariya Hidayat.
[Qt] QtTestBrowser: Clean up LauncherWindow code.
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init(). (LauncherWindow::init): Fixed comments. (LauncherWindow::applyPrefs): Move the method around. (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
- 8:58 PM Changeset in webkit [65048] by
-
- 2 edits in trunk/WebKitTools
2010-08-09 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Ariya Hidayat.
[Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
It gets control+0 the same visual effect as control++ or control-.
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::toggleZoomTextOnly):
- 8:57 PM Changeset in webkit [65047] by
-
- 3 edits in trunk/WebKitTools
2010-08-09 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Ariya Hidayat.
- [Qt] QtTestBrowser
- make m_zoomLevels a static member.
Not all instances of LauncherWindow need its own m_zoomLevel.
- QtTestBrowser/launcherwindow.cpp:
- QtTestBrowser/launcherwindow.h:
- 8:43 PM Changeset in webkit [65046] by
-
- 2 edits in trunk/WebCore
Qt build fix attempt VIII.
- dom/QualifiedName.cpp:
(WebCore::QualifiedName::toString):
- dom/XMLDocumentParserQt.cpp:
(WebCore::handleElementNamespaces):
- 8:34 PM Changeset in webkit [65045] by
-
- 2 edits in trunk/WebCore
Qt build fix attempt VII.
- dom/QualifiedName.cpp:
(WebCore::QualifiedName::toString):
- dom/XMLDocumentParserQt.cpp:
(WebCore::handleElementNamespaces):
- 8:29 PM Changeset in webkit [65044] by
-
- 2 edits in trunk/JavaScriptCore
Fix Qt/ARM
C++ overload resolution I stab at thee
- jit/JITInlineMethods.h:
(JSC::JIT::beginUninterruptedSequence):
(JSC::JIT::endUninterruptedSequence):
- 8:27 PM Changeset in webkit [65043] by
-
- 2 edits in trunk/WebCore
Qt build fix attempt VI.
- dom/QualifiedName.cpp:
(WebCore::QualifiedName::toString):
- dom/XMLDocumentParserQt.cpp:
(WebCore::handleElementNamespaces):
- 8:19 PM Changeset in webkit [65042] by
-
- 19 edits1 add in trunk/JavaScriptCore
2010-08-09 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Allow an assembler/macroassembler to compact branches to more concise forms when linking
https://bugs.webkit.org/show_bug.cgi?id=43745
This patch makes it possible for an assembler to convert jumps into a different
(presumably more efficient) form at link time. Currently implemented in the
ARMv7 JIT as that already had logic to delay linking of jumps until the end of
compilation already. The ARMv7 JIT chooses between either a 4 byte short jump
or a full 32-bit offset (and rewrites ITTT instructions as appropriate), so does
not yet produce the most compact form possible. The general design of the linker
should make it relatively simple to introduce new branch types with little effort,
as the linker has no knowledge of the exact form of any of the branches.
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/ARMv7Assembler.cpp: Added. (JSC::): Record jump sizes
- assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::LinkRecord::LinkRecord): (JSC::ARMv7Assembler::LinkRecord::from): (JSC::ARMv7Assembler::LinkRecord::setFrom): (JSC::ARMv7Assembler::LinkRecord::to): (JSC::ARMv7Assembler::LinkRecord::type): (JSC::ARMv7Assembler::LinkRecord::linkType): (JSC::ARMv7Assembler::LinkRecord::setLinkType): Encapsulate LinkRecord fields so we can compress the values somewhat
(JSC::ARMv7Assembler::JmpSrc::JmpSrc):
Need to record the jump type now
(JSC::ARMv7Assembler::b):
(JSC::ARMv7Assembler::blx):
(JSC::ARMv7Assembler::bx):
Need to pass the jump types
(JSC::ARMv7Assembler::executableOffsetFor):
(JSC::ARMv7Assembler::jumpSizeDelta):
(JSC::ARMv7Assembler::linkRecordSourceComparator):
(JSC::ARMv7Assembler::computeJumpType):
(JSC::ARMv7Assembler::convertJumpTo):
(JSC::ARMv7Assembler::recordLinkOffsets):
(JSC::ARMv7Assembler::jumpsToLink):
(JSC::ARMv7Assembler::link):
(JSC::ARMv7Assembler::unlinkedCode):
Helper functions for the linker
(JSC::ARMv7Assembler::linkJump):
(JSC::ARMv7Assembler::canBeShortJump):
(JSC::ARMv7Assembler::linkLongJump):
(JSC::ARMv7Assembler::linkShortJump):
(JSC::ARMv7Assembler::linkJumpAbsolute):
Moving code around for the various jump linking functions
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::beginUninterruptedSequence): (JSC::AbstractMacroAssembler::endUninterruptedSequence): We have to track uninterrupted sequences in any assembler that compacts branches as that's not something we're allowed to do in such sequences. AbstractMacroAssembler has a nop version of these functions as it makes the code elsewhere nicer.
- assembler/LinkBuffer.h: (JSC::LinkBuffer::LinkBuffer): (JSC::LinkBuffer::link): (JSC::LinkBuffer::patch): (JSC::LinkBuffer::locationOf): (JSC::LinkBuffer::locationOfNearCall): (JSC::LinkBuffer::returnAddressOffset): (JSC::LinkBuffer::trampolineAt): Updated these functions to adjust for any changed offsets in the linked code
(JSC::LinkBuffer::applyOffset):
A helper function to deal with the now potentially moved labels
(JSC::LinkBuffer::linkCode):
The new and mighty linker function
- assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::MacroAssemblerARMv7): (JSC::MacroAssemblerARMv7::beginUninterruptedSequence): (JSC::MacroAssemblerARMv7::endUninterruptedSequence): (JSC::MacroAssemblerARMv7::jumpsToLink): (JSC::MacroAssemblerARMv7::unlinkedCode): (JSC::MacroAssemblerARMv7::computeJumpType): (JSC::MacroAssemblerARMv7::convertJumpTo): (JSC::MacroAssemblerARMv7::recordLinkOffsets): (JSC::MacroAssemblerARMv7::jumpSizeDelta): (JSC::MacroAssemblerARMv7::link): (JSC::MacroAssemblerARMv7::jump): (JSC::MacroAssemblerARMv7::branchMul32): (JSC::MacroAssemblerARMv7::breakpoint): (JSC::MacroAssemblerARMv7::nearCall): (JSC::MacroAssemblerARMv7::call): (JSC::MacroAssemblerARMv7::ret): (JSC::MacroAssemblerARMv7::tailRecursiveCall): (JSC::MacroAssemblerARMv7::executableOffsetFor): (JSC::MacroAssemblerARMv7::inUninterruptedSequence): (JSC::MacroAssemblerARMv7::makeJump): (JSC::MacroAssemblerARMv7::makeBranch):
All branches need to pass on their type now
- jit/ExecutableAllocator.h: (JSC::ExecutablePool::returnLastBytes):
We can't know ahead of time how much space will be necessary to
hold the linked code if we're compacting branches, this new
function allows us to return the unused bytes at the end of linking
- jit/JIT.cpp: (JSC::JIT::JIT): (JSC::JIT::privateCompile):
- jit/JIT.h: (JSC::JIT::compile):
The JIT class now needs to take a linker offset so that recompilation
can generate the same jumps when using branch compaction.
- jit/JITArithmetic32_64.cpp: (JSC::JIT::emitSlow_op_mod):
- jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::privateCompileCTINativeCall): Update for new trampolineAt changes
- wtf/FastMalloc.cpp: (WTF::TCMallocStats::):
- wtf/Platform.h:
- 8:18 PM Changeset in webkit [65041] by
-
- 3 edits in trunk/WebCore
Qt build fix attempt V.
- dom/QualifiedName.cpp:
(WebCore::QualifiedName::toString):
- dom/XMLDocumentParserQt.cpp:
(WebCore::handleElementNamespaces):
- 8:10 PM Changeset in webkit [65040] by
-
- 4 edits in trunk/WebCore
Qt build fix attempt IV.
- css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText):
- dom/QualifiedName.cpp:
(WebCore::QualifiedName::toString):
- dom/XMLDocumentParserQt.cpp:
(WebCore::handleElementNamespaces):
- 7:58 PM Changeset in webkit [65039] by
-
- 2 edits in trunk/WebCore
Speculative chromium build fix.
- platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::charactersAreAllASCII):
- 7:41 PM Changeset in webkit [65038] by
-
- 5 edits in branches/safari-533.18-branch
Versioning.
- 7:40 PM Changeset in webkit [65037] by
-
- 1 copy in tags/Safari-533.18.1
New tag.
- 7:35 PM Changeset in webkit [65036] by
-
- 5 edits in branches/safari-533.18-branch
Versioning.
- 7:24 PM Changeset in webkit [65035] by
-
- 4 edits2 adds in branches/safari-533.18-branch
Merge r63772.
- 7:13 PM Changeset in webkit [65034] by
-
- 2 edits in trunk/WebKit/chromium
Speculative chromium build fix V.
- tests/KURLTest.cpp:
(ComponentCase::TEST):
- 7:06 PM Changeset in webkit [65033] by
-
- 2 edits in trunk/WebKit/chromium
Speculative chromium build fix IV.
- src/WebPageSerializerImpl.h:
- 6:59 PM Changeset in webkit [65032] by
-
- 4 edits in trunk
Qt build fix III.
- wtf/text/WTFString.h:
WebCore:
- css/CSSSelector.cpp:
- 6:47 PM Changeset in webkit [65031] by
-
- 4 edits in trunk/WebCore
2010-08-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove error-prone external SegementedSubstring contructor
https://bugs.webkit.org/show_bug.cgi?id=43752
There's a lot of code that assumes that SegmentedString takes ownership
of its substrings. For example, when the HTML parser pauses and
resumes asynchronously, it could explode if SegmentedString didn't own
its substrings.
Prior to this patch, there was a constructor that let
SegmentedSubstring use an external string buffer. It turns out it was
only used in a handful of places, but I'd rather pay the memcpy of
these small strings than risk having them used after free.
- bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::documentWrite):
- html/LegacyHTMLDocumentParser.cpp: (WebCore::LegacyHTMLDocumentParser::parseNonHTMLText): (WebCore::LegacyHTMLDocumentParser::scriptHandler): (WebCore::LegacyHTMLDocumentParser::parseComment):
- platform/text/SegmentedString.h: (WebCore::SegmentedString::SegmentedString):
- 6:43 PM Changeset in webkit [65030] by
-
- 2 edits in trunk/WebCore
Speculative Qt build fix.
- css/CSSSelector.cpp:
- 6:43 PM Changeset in webkit [65029] by
-
- 13 edits in trunk
Add zoom support for injected bundle
https://bugs.webkit.org/show_bug.cgi?id=43759
Reviewed by Geoffrey Garen.
WebKit2:
Add SPI to change the zoom factor for a page.
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
(toZoomMode):
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageGetZoomFactor):
(WKBundlePageSetZoomFactor):
(WKBundlePageSetZoomMode):
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::zoomFactor):
(WebKit::WebPage::setZoomFactor):
(WebKit::WebPage::setZoomMode):
- WebProcess/WebPage/WebPage.h:
WebKitTools:
Use zoom factor SPI to implement zoom related eventSender functions.
- WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::textZoomIn):
(WTR::EventSendingController::textZoomOut):
(WTR::EventSendingController::zoomPageIn):
(WTR::EventSendingController::zoomPageOut):
- WebKitTestRunner/InjectedBundle/EventSendingController.h:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
LayoutTests:
- platform/mac-wk2/Skipped: Remove now passing tests.
- 6:42 PM Changeset in webkit [65028] by
-
- 4 edits in trunk/WebKitTools
Speculative chromium build fix III.
- DumpRenderTree/chromium/MockSpellCheck.h:
- DumpRenderTree/chromium/NotificationPresenter.h:
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost::addClearHeader):
(WebViewHost::clearHeaders):
- 6:37 PM Changeset in webkit [65027] by
-
- 2 edits in trunk/WebKit/chromium
Speculative chromium build fix II.
- src/AssertMatchingEnums.cpp:
- 6:32 PM Changeset in webkit [65026] by
-
- 2 edits in trunk/WebKitTools
2010-08-09 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
increase the number of test results that we save
https://bugs.webkit.org/show_bug.cgi?id=43763
Now that we do incremental uploads, we can increase the number of
results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- 6:28 PM Changeset in webkit [65025] by
-
- 2 edits in trunk/WebCore
Speculative gtk build fix.
- plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::handlePostReadFile):
- 6:24 PM Changeset in webkit [65024] by
-
- 1 edit in branches/safari-533.18-branch/WebCore/rendering/RenderLayerBacking.cpp
Build fix. Remove a static function that is no longer called.
- 6:22 PM Changeset in webkit [65023] by
-
- 2 edits in trunk/WebKit/chromium
Speculative chromium build fix.
- public/WebCString.h:
- 5:55 PM Changeset in webkit [65022] by
-
- 2 edits in trunk/JavaScriptCore
Qt build fix.
- wtf/qt/StringQt.cpp:
- 5:38 PM Changeset in webkit [65021] by
-
- 504 edits in trunk
Bug 43594 - Add string forwards to Forward.h
This allows us to remove forward declarations for these classes from
WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).
Rubber stamped by Sam Weinig
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/Forward.h:
WebCore:
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AXObjectCache.h:
- accessibility/AccessibilityARIAGrid.h:
- accessibility/AccessibilityListBoxOption.h:
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilityTable.h:
- bindings/cpp/WebDOMCString.h:
- bindings/cpp/WebDOMString.h:
- bindings/gobject/ConvertToUTF8String.h:
- bindings/js/DOMWrapperWorld.h:
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSMessagePortCustom.h:
- bindings/js/JavaScriptCallFrame.h:
- bindings/js/ScriptController.h:
- bindings/js/ScriptProfile.h:
- bindings/js/ScriptSourceProvider.h:
- bindings/js/ScriptString.h:
- bindings/js/WorkerScriptController.h:
- bindings/objc/DOMImplementationFront.h:
- bindings/v8/ScheduledAction.h:
- bindings/v8/ScriptController.h:
- bindings/v8/V8DOMWindowShell.h:
- bindings/v8/V8Proxy.h:
- bindings/v8/V8Utilities.h:
- bindings/v8/custom/V8CustomXPathNSResolver.h:
- bridge/c/c_utility.h:
- css/CSSFontSelector.h:
- css/CSSHelper.h:
- css/CSSOMUtils.h:
- css/CSSPrimitiveValue.h:
- css/MediaList.h:
- css/StyleBase.h:
- css/StyleSheetList.h:
- css/WebKitCSSKeyframesRule.h:
- dom/CheckedRadioButtons.h:
- dom/DOMImplementation.h:
- dom/DocumentMarker.h:
- dom/DynamicNodeList.h:
- dom/EventTarget.h:
- dom/MessagePort.h:
- dom/MessagePortChannel.h:
- dom/NameNodeList.h:
- dom/Node.h:
- dom/NodeList.h:
- dom/OptionGroupElement.h:
- dom/ScriptExecutionContext.h:
- dom/SelectElement.h:
- dom/ViewportArguments.h:
- dom/make_names.pl:
- editing/HTMLInterchange.h:
- editing/htmlediting.h:
- editing/markup.h:
- html/CollectionCache.h:
- html/DOMFormData.h:
- html/DataGridColumnList.h:
- html/DateComponents.h:
- html/FileStream.h:
- html/FileStreamProxy.h:
- html/FormDataList.h:
(WebCore::FormDataList::appendData):
- html/HTMLCollection.h:
- html/HTMLElementStack.h:
- html/HTMLFormattingElementList.h:
- html/HTMLParserQuirks.h:
- html/HTMLQuoteElement.h:
- html/HTMLScriptRunnerHost.h:
- html/StepRange.h:
- html/canvas/CanvasGradient.h:
- html/canvas/CanvasNumberArray.h:
- html/canvas/CanvasPattern.h:
- inspector/InjectedScript.h:
- inspector/InspectorCSSStore.h:
- inspector/InspectorClient.h:
- inspector/InspectorFrontendClient.h:
- inspector/InspectorValues.h:
- inspector/ScriptDebugListener.h:
- loader/CachedResourceClient.h:
- loader/CrossOriginAccessControl.h:
- loader/DocumentThreadableLoader.h:
- loader/FrameLoaderClient.h:
- loader/RedirectScheduler.h:
- loader/SubframeLoader.h:
- loader/appcache/DOMApplicationCache.h:
- loader/archive/ArchiveFactory.h:
- loader/icon/IconDatabaseClient.h:
- notifications/NotificationPresenter.h:
- page/Chrome.h:
- page/ChromeClient.h:
- page/Console.h:
- page/ContextMenuClient.h:
- page/DOMSelection.h:
- page/EditorClient.h:
- page/EventHandler.h:
- page/FrameView.h:
- page/GeolocationPositionCache.h:
- page/History.h:
- page/Location.h:
- page/Navigator.h:
- page/NavigatorBase.h:
- page/PluginHalterClient.h:
- page/PrintContext.h:
- page/SpeechInput.h:
- page/SpeechInputListener.h:
- page/animation/AnimationController.h:
- platform/CookieJar.h:
- platform/CrossThreadCopier.h:
- platform/DragImage.h:
- platform/FileSystem.h:
- platform/Language.h:
- platform/Length.h:
- platform/LinkHash.h:
- platform/LocalizationStrategy.h:
- platform/LocalizedStrings.h:
- platform/Logging.h:
- platform/Pasteboard.h:
- platform/PopupMenuClient.h:
- platform/SearchPopupMenu.h:
- platform/Widget.h:
- platform/cf/BinaryPropertyList.h:
- platform/chromium/ChromiumBridge.h:
- platform/chromium/ClipboardUtilitiesChromium.h:
- platform/cocoa/KeyEventCocoa.h:
- platform/graphics/Color.h:
- platform/graphics/FontCache.h:
- platform/graphics/FontData.h:
- platform/graphics/FontSelector.h:
- platform/graphics/GraphicsTypes.h:
- platform/graphics/Icon.h:
- platform/graphics/ImageBuffer.h:
- platform/graphics/ImageSource.h:
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
- platform/graphics/Path.h:
- platform/graphics/StringTruncator.h:
- platform/graphics/cairo/FontCustomPlatformData.h:
- platform/graphics/cairo/FontPlatformData.h:
- platform/graphics/cg/FontPlatformData.h:
- platform/graphics/cg/ImageSourceCG.h:
- platform/graphics/chromium/FontCustomPlatformData.h:
- platform/graphics/chromium/FontPlatformDataChromiumWin.h:
- platform/graphics/chromium/FontPlatformDataLinux.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- platform/graphics/haiku/FontCustomPlatformData.h:
- platform/graphics/mac/FontCustomPlatformData.h:
- platform/graphics/mac/FontPlatformData.h:
- platform/graphics/qt/FontCustomPlatformData.h:
- platform/graphics/qt/FontPlatformData.h:
- platform/graphics/win/FontCustomPlatformData.h:
- platform/graphics/win/FontCustomPlatformDataCairo.h:
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
- platform/graphics/wince/FontPlatformData.h:
- platform/graphics/wince/MediaPlayerPrivateWince.h:
- platform/graphics/wince/MediaPlayerProxy.h:
- platform/graphics/wx/FontCustomPlatformData.h:
- platform/graphics/wx/FontPlatformData.h:
- platform/mac/PasteboardHelper.h:
- platform/network/DNS.h:
- platform/network/FormData.h:
- platform/network/FormDataBuilder.h:
- platform/network/HTTPParsers.h:
- platform/text/Hyphenation.h:
- platform/text/LineEnding.h:
- platform/text/TextCodec.h:
- platform/text/TextEncoding.h:
- platform/text/TextStream.h:
- platform/win/BString.h:
- platform/win/ClipboardUtilitiesWin.h:
- platform/win/WCDataObject.h:
- platform/win/WebCoreTextRenderer.h:
- plugins/DOMMimeType.h:
- plugins/DOMMimeTypeArray.h:
- plugins/DOMPlugin.h:
- plugins/DOMPluginArray.h:
- rendering/CounterNode.h:
- rendering/HitTestResult.h:
- rendering/RenderObjectChildList.h:
- rendering/RenderText.h:
- rendering/RenderTreeAsText.h:
- rendering/TextControlInnerElements.h:
- rendering/style/ContentData.h:
- rendering/style/RenderStyle.h:
- storage/DatabaseAuthorizer.h:
- storage/DatabaseTrackerClient.h:
- storage/SQLTransaction.h:
- storage/SQLTransactionSync.h:
- storage/Storage.h:
- storage/chromium/DatabaseObserver.h:
- svg/SVGAnimatedTemplate.h:
- svg/SVGDocumentExtensions.h:
- svg/SVGGlyphElement.h:
- svg/SVGHKernElement.h:
- svg/SVGNumberList.h:
- svg/SVGPointList.h:
- svg/SVGPreserveAspectRatio.h:
- svg/SVGStylable.h:
- svg/SVGTests.h:
- svg/SVGTransformList.h:
- svg/SVGTransformable.h:
- svg/SVGVKernElement.h:
- websockets/ThreadableWebSocketChannel.h:
- websockets/ThreadableWebSocketChannelClientWrapper.h:
- websockets/WebSocket.h:
- websockets/WebSocketChannel.h:
- websockets/WebSocketHandshakeResponse.h:
- wml/WMLErrorHandling.h:
- wml/WMLPageState.h:
- wml/WMLVariables.h:
- workers/DefaultSharedWorkerRepository.h:
- workers/SharedWorkerRepository.h:
- workers/Worker.h:
- workers/WorkerContextProxy.h:
- workers/WorkerLoaderProxy.h:
- workers/WorkerLocation.h:
- workers/WorkerMessagingProxy.h:
- workers/WorkerReportingProxy.h:
- workers/WorkerThread.h:
- xml/DOMParser.h:
- xml/XMLHttpRequestUpload.h:
- xml/XPathEvaluator.h:
- xml/XPathExpression.h:
- xml/XPathNSResolver.h:
- xml/XPathResult.h:
- xml/XPathUtil.h:
WebKit:
- WebKit.xcodeproj/project.pbxproj:
WebKit/chromium:
- public/WebCString.h:
- public/WebString.h:
- src/DOMUtilitiesPrivate.h:
- src/DebuggerAgentImpl.h:
- src/DebuggerAgentManager.h:
- src/WebDevToolsAgentImpl.h:
- src/WebDevToolsFrontendImpl.h:
- src/WebPageSerializerImpl.h:
WebKit/efl:
- WebCoreSupport/InspectorClientEfl.h:
WebKit/gtk:
- WebCoreSupport/InspectorClientGtk.h:
WebKit/haiku:
- WebCoreSupport/FrameLoaderClientHaiku.h:
- WebCoreSupport/InspectorClientHaiku.h:
WebKit/mac:
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/WebBaseNetscapePluginView.h:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebIconDatabaseClient.h:
- WebCoreSupport/WebPluginHalterClient.h:
- WebView/WebViewInternal.h:
WebKit/qt:
- WebCoreSupport/FrameLoaderClientQt.h:
- WebCoreSupport/InspectorClientQt.h:
WebKit/win:
- COMVariantSetter.h:
- MarshallingHelpers.h:
- WebCoreSupport/WebContextMenuClient.h:
- WebCoreSupport/WebPluginHalterClient.h:
- WebHistory.h:
WebKit/wx:
- WebKitSupport/FrameLoaderClientWx.h:
- WebKitSupport/InspectorClientWx.h:
WebKit2:
- UIProcess/PageClient.h:
- UIProcess/VisitedLinkProvider.h:
- UIProcess/WebContextInjectedBundleClient.h:
- UIProcess/WebFrameProxy.h:
- UIProcess/WebHistoryClient.h:
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPolicyClient.h:
- UIProcess/WebProcessProxy.h:
- UIProcess/WebUIClient.h:
- UIProcess/win/WebView.h:
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
- WebProcess/Plugins/NPRuntimeObjectMap.h:
- WebProcess/Plugins/Netscape/NetscapePluginStream.h:
- WebProcess/Plugins/PluginController.h:
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebProcess.h:
- 5:25 PM Changeset in webkit [65020] by
-
- 2 edits in trunk/WebCore
2010-08-09 Nat Duca <nduca@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Blue line visible at the right hand side of the window with accelerated compositor
https://bugs.webkit.org/show_bug.cgi?id=43748
Correct the ortho projection matrix for the root layer, which was
too large by 0.5px in both width and height. For even view sizes,
this would cause the viewport to appear 1 pixel too small.
Fixing this requires removal of several 0.5 correction factors
that were previously added to compensate for the too-large viewport.
Finally, compute the translation for the root layer quad using
floating point rather than integer arithmetic. This avoids us losing
a key half-pixel of translation when the width of the window is odd.
To test, size window to even/odd dimensions. No blue line should be visible.
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
- 5:24 PM Changeset in webkit [65019] by
-
- 3 edits2 adds in trunk
2010-08-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Justin Garcia.
fontColorChangesComputedStyle, fontSizeChangesComputedStyle, and fontFaceChangesComputedStyle should be removed
https://bugs.webkit.org/show_bug.cgi?id=43465
Removed fontColorChangesComputedStyle, fontSizeChangesComputedStyle, and fontFaceChangesComputedStyle
because StyleChange's applyFontColor, applyFontFace, and applyFontSize all return false
if there was no difference between the new font color, font size, font face and that of the computed style.
Also added a work-around for the bug 28282 in getPropertiesNotInComputedStyle with a test so that
the above change will not add a redundant font or span element.
Test: editing/style/fore-color-by-name.html
- editing/ApplyStyleCommand.cpp: (WebCore::getRGBAFontColor): Added. (WebCore::StyleChange::extractTextStyles): Calls getRGBAFontColor. (WebCore::getPropertiesNotInComputedStyle): Removes color property manually by checking the RGBA values. (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): See above.
2010-08-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Justin Garcia.
fontColorChangesComputedStyle, fontSizeChangesComputedStyle, and fontFaceChangesComputedStyle should be removed
https://bugs.webkit.org/show_bug.cgi?id=43465
Added a test for applying execCommand('foreColor') by color name. Because of the bug 28282, we have to manually
process color property in getPropertiesNotInComputedStyle to avoid adding a redundant font or span element.
- editing/style/fore-color-by-name-expected.txt: Added.
- editing/style/fore-color-by-name.html: Added.
- 5:06 PM Changeset in webkit [65018] by
-
- 3 edits in trunk/WebCore
2010-08-09 Kenneth Russell <kbr@google.com>
Reviewed by David Levin.
Fix compilation of VideoLayerChromium on Mac OS X with compositor
https://bugs.webkit.org/show_bug.cgi?id=43757
No new tests; build fix only (associated functionality not implemented yet).
- platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::VideoLayerChromium): (WebCore::VideoLayerChromium::updateTextureContents): (WebCore::VideoLayerChromium::createTextureRect): (WebCore::VideoLayerChromium::updateTextureRect):
- platform/graphics/chromium/VideoLayerChromium.h:
- 5:00 PM Changeset in webkit [65017] by
-
- 3 edits in trunk/WebCore
2010-08-09 Ariya Hidayat <ariya@sencha.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Need to implement GraphicsContextQt::clipConvexPolygon()
https://bugs.webkit.org/show_bug.cgi?id=41310
Based on the prototype code by Simon Hausmann.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipConvexPolygon):
- rendering/RenderObject.h:
- 4:45 PM Changeset in webkit [65016] by
-
- 8 edits in trunk
AX: Placeholder value for text fields not exposed like it should be
https://bugs.webkit.org/show_bug.cgi?id=43598
Reviewed by David Kilzer.
WebCore:
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::placeholderValue):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::title):
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
LayoutTests:
- accessibility/placeholder-expected.txt:
- accessibility/placeholder.html:
- 4:29 PM Changeset in webkit [65015] by
-
- 2 edits in trunk/WebKitTools
2010-08-09 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[chromium] DRT error print statement incorrectly tries to print a FILE*
https://bugs.webkit.org/show_bug.cgi?id=43747
- DumpRenderTree/chromium/ImageDiff.cpp: (writeFile): pass the correct pointer.
- 4:25 PM Changeset in webkit [65014] by
-
- 8 edits2 adds in trunk
2010-08-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Justin Garcia.
Undo fails in RemoveCSSPropertyCommand when the corresponding style attribute is removed
https://bugs.webkit.org/show_bug.cgi?id=43639
The bug was caused when RemoveCSSPropertyCommand is called with CSSMutableStyleDeclaration of some styled element,
and the style attribute of the element is removed subsequently. When the attribute removal is undone, new instance of
CSSMutableStyleDeclaration is created and RemoveCSSPropertyCommand's m_style became detached from the element.
Modified RemoveCSSPropertyCommand to store the styled element directly instead of its CSSMutableStyleDeclaration.
Test: editing/undo/remove-css-property-and-remove-style.html
- WebCore.order:
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeCSSStyle): Calls removeCSSProperty. (WebCore::ApplyStyleCommand::extractTextDecorationStyle): Calls removeCSSProperty.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeCSSProperty): Takes StyledElement instead of CSSMutableStyleDeclaration.
- editing/CompositeEditCommand.h:
- editing/RemoveCSSPropertyCommand.cpp: (WebCore::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand): Takes StyledElement instead of CSSMutableStyleDeclaration. (WebCore::RemoveCSSPropertyCommand::doApply): See above. (WebCore::RemoveCSSPropertyCommand::doUnapply): See above.
- editing/RemoveCSSPropertyCommand.h: (WebCore::RemoveCSSPropertyCommand::create): See above.
2010-08-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Justin Garcia.
Undo fails in RemoveCSSPropertyCommand when the corresponding style attribute is removed
https://bugs.webkit.org/show_bug.cgi?id=43639
Added a test to remove style attribute after removing a CSS property from the style.
Undo should restore both style attribute and the removed CSS property.
- editing/undo/remove-css-property-and-remove-style-expected.txt: Added.
- editing/undo/remove-css-property-and-remove-style.html: Added.
- 4:18 PM Changeset in webkit [65013] by
-
- 3 edits in trunk/WebCore
2010-08-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
Use getIdentifierValue to obtain direction and unicode-bidi properties in ApplyStyleCommand
https://bugs.webkit.org/show_bug.cgi?id=43699
Deployed getIdentifierValue in various parts of ApplyStyleCommand where
direction and unicode-bidi properties were obtained manually.
No new tests since this is a cleanup.
- editing/ApplyStyleCommand.cpp: (WebCore::getIdentifierValue): Takes CSSStyleDeclaration instead of CSSMutableStyleDeclaration. (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Calls getIdentifierValue. (WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Calls getIdentifierValue. (WebCore::ApplyStyleCommand::applyInlineStyle): Calls getIdentifierValue.
- editing/ApplyStyleCommand.h:
- 4:06 PM Changeset in webkit [65012] by
-
- 2 edits in trunk/WebCore
2010-08-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove trailing whitespace in HTMLViewSourceDocument.cpp
https://bugs.webkit.org/show_bug.cgi?id=43741
No behavior change. The whitespace was distracting me while porting
this class to the new parser.
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable): (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addLine): (WebCore::HTMLViewSourceDocument::addText): (WebCore::HTMLViewSourceDocument::addLink):
- 3:11 PM Changeset in webkit [65011] by
-
- 2 edits in trunk/WebKitTools
2010-08-09 Victor Wang <victorw@chromium.org>
Reviewed by Ojan Vafai.
Upload incremental test results json to server by default.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 3:06 PM Changeset in webkit [65010] by
-
- 4 edits3 adds in branches/safari-533.18-branch
Merge r64706.
- 2:59 PM Changeset in webkit [65009] by
-
- 7 edits in branches/safari-533.18-branch
Merge r64110.
- 2:59 PM Changeset in webkit [65008] by
-
- 4 edits in branches/safari-533.18-branch/WebKit/mac
Merge r62872.
- 2:59 PM Changeset in webkit [65007] by
-
- 3 edits2 adds in branches/safari-533.18-branch
Merge r64095.
- 2:52 PM Changeset in webkit [65006] by
-
- 18 edits in trunk
2010-08-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Use the HTML5 TreeBuilder for Fragment Parsing
https://bugs.webkit.org/show_bug.cgi?id=43586
- html5lib/runner-expected.txt:
- We pass 2 more tests now that the tokenizer is set to the right state before fragment parsing.
- html5lib/runner-expected-html5.txt:
- We pass 4 more tests now that HTML5 fragment parsing is (partially) implemented behind the --html5-treebuilder flag.
2010-08-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Use the HTML5 TreeBuilder for Fragment Parsing
https://bugs.webkit.org/show_bug.cgi?id=43586
The bulk of this change is just a transcription of the HTML5 spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-end.html#fragment-case
DocumentParser() now sets the right tokenizer state before handling
fragments. Since default code path uses the HTML5 tokenizer with the
legacy tree builder, this fixes 2 tokenizer-state tests for the html5lib.
This fixes 2 more tree-builder tests when the html5 treebuilder is enabled too.
- dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::parseHTML):
- HTML5 implementation of fragment parsing requires the context element (parent) pointer. The legacy implementation handles all parsing branches which require the context element outside of the parser itself, which likely produces "wrong" results. We'll remove those branches when we turn on the HMTL5 fragment parser.
(WebCore::DocumentFragment::parseXML):
- Rename "parent" to "contextElement" to match the HTML path (and the HTML5 spec).
- dom/DocumentFragment.h:
- dom/Element.cpp:
(WebCore::Element::createContextualFragment):
- Pass the contextElement (this).
- html/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::setForm):
- Needed by for the fragment case.
(WebCore::HTMLConstructionSite::insertHTMLBodyStartTagInBody):
- I'm not sure this method should exist, it only has one caller. but for now, I've moved the fragment case FIXME out to the one caller and implemented it.
- html/HTMLConstructionSite.h:
- html/HTMLDocumentParser.cpp:
(WebCore::HTMLNames::tokenizerStateForContextElement):
- Part of the fragment case handling for the HTML5 parser.
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
- Set the Tokenizer state based on the contextElement.
(WebCore::HTMLDocumentParser::parseDocumentFragment):
- Take a contextElement argument.
- html/HTMLDocumentParser.h:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::setInnerHTML):
- Added a FIXME before the branches the old parser used to avoid ever needing to pass a context element when parsing HTML fragments.
(WebCore::HTMLElement::insertAdjacentHTML):
- Pass the context element.
- html/HTMLTokenizer.h:
- html/HTMLTreeBuilder.cpp:
- I added a new helper class FragmentParsingContext to simplify the two HTMLTreeBuilder constructors and hide the existence of m_dummyDocumentForFragmentParse.
- I also removed m_isParsingFragment and replaced it with an isParsingFragment() function.
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::document):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::~FragmentParsingContext):
(WebCore::HTMLTreeBuilder::passTokenToLegacyParser):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
- I had to implement two notImplemented() states in order to get most of the layout tests to pass when using the HTML5 parser fragment case.
(WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processCaptionEndTagForInCaption):
(WebCore::HTMLTreeBuilder::processTrEndTagForInRow):
(WebCore::HTMLTreeBuilder::processTableEndTagForInTable):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::finished):
- The HTML5 parsing algorithm fragment case uses a dummy document to handle all the parsing and then moves all the children from the dummy document over into a DocumentFragment when the parse is done. We could avoid this adopt step by making the TreeBuilder a bit more complicated, but I'm not sure that's necessary (yet).
- html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::isParsingFragment): (WebCore::HTMLTreeBuilder::FragmentParsingContext::fragment): (WebCore::HTMLTreeBuilder::FragmentParsingContext::contextElement): (WebCore::HTMLTreeBuilder::FragmentParsingContext::scriptingPermission):
- xml/XSLTProcessor.cpp: (WebCore::createFragmentFromSource):
- 2:36 PM Changeset in webkit [65005] by
-
- 34 edits4 deletes in trunk
WebCore: Auto-generate most HTML5 DB bindings.
https://bugs.webkit.org/show_bug.cgi?id=43382
Reviewed by Adam Barth.
- Android.jscbindings.mk: Remove {JS|V8}Database{Sync}Custom.cpp
and the custom implementations of openDatabase{Sync}().
- Android.v8bindings.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSDatabaseCustom.cpp: Removed.
- bindings/js/JSDatabaseSyncCustom.cpp: Removed.
- bindings/js/JSWorkerContextCustom.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8DatabaseCustom.cpp: Removed.
- bindings/v8/custom/V8DatabaseSyncCustom.cpp: Removed.
- bindings/v8/custom/V8WorkerContextCustom.cpp:
- bindings/scripts/CodeGeneratorGObject.pm: Change the code generators
to check that each value can be converted to the respective
argument type.
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::~JSTestCallback):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::voidMethodWithArgsCallback):
(WebCore::TestObjInternal::intMethodWithArgsCallback):
(WebCore::TestObjInternal::objMethodWithArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjInternal::idbKeyCallback):
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
(WebCore::TestObjInternal::withDynamicFrameAndArgCallback):
(WebCore::TestObjInternal::withDynamicFrameAndOptionalArgCallback):
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureCallback):
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureASADCallback):
(WebCore::TestObjInternal::methodWithOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjInternal::methodWithCallbackAndOptionalArgCallback):
(WebCore::TestObjInternal::overloadedMethod1Callback):
(WebCore::TestObjInternal::overloadedMethod2Callback):
(WebCore::TestObjInternal::overloadedMethod3Callback):
(WebCore::TestObjInternal::overloadedMethod4Callback):
(WebCore::):
(WebCore::ConfigureV8TestObjTemplate):
- bindings/v8/custom/V8BindingMacros.h:
- bindings/v8/V8Binding.h: Minor changes required to support the
auto-generated bindings.
(WebCore::V8Parameter::V8Parameter):
- bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):
- bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
- page/DOMWindow.idl:
- storage/Database.cpp:
(WebCore::Database::transaction):
(WebCore::Database::readTransaction):
(WebCore::Database::runTransaction):
- storage/Database.h:
- storage/Database.idl:
- storage/DatabaseSync.cpp:
(WebCore::DatabaseSync::transaction):
(WebCore::DatabaseSync::readTransaction):
(WebCore::DatabaseSync::runTransaction):
- storage/DatabaseSync.h:
- storage/DatabaseSync.idl:
- workers/WorkerContext.idl:
LayoutTests: Changing the expected error message for a test.
https://bugs.webkit.org/show_bug.cgi?id=43382
Reviewed by Adam Barth.
- fast/workers/storage/open-database-inputs-sync-expected.txt:
- 2:32 PM Changeset in webkit [65004] by
-
- 2 edits in trunk/WebCore
2010-08-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move HTMLViewSourceDocument from legacyParserAddChild to parserAddChild
https://bugs.webkit.org/show_bug.cgi?id=43740
This removes the DTD checks, which aren't needed for view source
documents.
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable): (WebCore::HTMLViewSourceDocument::addSpanWithClassName): (WebCore::HTMLViewSourceDocument::addLine): (WebCore::HTMLViewSourceDocument::addText): (WebCore::HTMLViewSourceDocument::addLink):
- 2:29 PM Changeset in webkit [65003] by
-
- 2 edits in trunk/WebCore
Fixed an uninitialized member variable in the Color(CGColorRef) constructor.
Reviewed by Simon Fraser.
- platform/graphics/cg/ColorCG.cpp:
(WebCore::Color::Color): Initialize m_valid to true if the color is not 0.
- 2:12 PM Changeset in webkit [65002] by
-
- 2 edits in trunk/WebCore
2010-08-09 James Robinson <jamesr@chromium.org>
Chromium compile fix, unreviewed.
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::~PlatformContextSkia): (WebCore::PlatformContextSkia::setGraphicsContext3D):
- 1:54 PM Changeset in webkit [65001] by
-
- 4 edits in trunk/WebCore
2010-08-09 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Add a PrepareTextureCallback to the chromium canvas layer compositor to upload mixed-mode results before compositing
https://bugs.webkit.org/show_bug.cgi?id=43656
When compositing an accelerated canvas that is using both hardware and software drawing,
we need a callback before compositing the layer to make sure that we upload any software
drawn results to the texture. This will go away as soon as implement all draw calls
in hardware.
To test, run any canvas demo that runs in mixed mode and verifies that the software results
always show up.
- platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::updateTextureContents):
- platform/graphics/chromium/CanvasLayerChromium.h: (WebCore::CanvasLayerChromium::setPrepareTextureCallback):
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PrepareTextureCallbackImpl::create): (WebCore::PrepareTextureCallbackImpl::willPrepareTexture): (WebCore::PrepareTextureCallbackImpl::PrepareTextureCallbackImpl): (WebCore::PlatformContextSkia::setGraphicsContext3D):
- 1:44 PM Changeset in webkit [65000] by
-
- 5 edits in branches/safari-533.18-branch
Versioning.
- 1:41 PM Changeset in webkit [64999] by
-
- 1 copy in branches/safari-533.18-branch
New branch.
- 1:36 PM Changeset in webkit [64998] by
-
- 8 edits in trunk
2010-08-09 Zhenyao Mo <zmo@google.com>
Reviewed by David Levin.
sizeInBytes should be removed
https://bugs.webkit.org/show_bug.cgi?id=43693
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::sizeInBytes): Don't generate GL errors. Generate them in the callers instead. (WebCore::WebGLRenderingContext::vertexAttribPointer): Generate GL error if sizeInBytes fails.
- html/canvas/WebGLRenderingContext.h: Make sizeInBytes private helper.
- html/canvas/WebGLRenderingContext.idl: Remove sizeInBytes.
2010-08-09 Zhenyao Mo <zmo@google.com>
Reviewed by David Levin.
sizeInBytes should be removed
https://bugs.webkit.org/show_bug.cgi?id=43693
- fast/canvas/webgl/gl-object-get-calls-expected.txt: Define sizeInBytes and don't use the WebGL one (it's been removed).
- fast/canvas/webgl/gl-object-get-calls.html: Ditto.
- fast/canvas/webgl/index-validation.html: Ditto.
- 1:29 PM Changeset in webkit [64997] by
-
- 10 edits in trunk
2010-08-09 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=43702
<video> element does not resize correctly
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): RenderVideo::videoSizeChanged is gone, just use updateFromElement instead. (WebCore::HTMLMediaElement::mediaPlayerDurationChanged): Ditto. (WebCore::HTMLMediaElement::mediaPlayerSizeChanged): Ditto.
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::parseMappedAttribute): Clear the image loader and cached image when the 'poster' attribute is changed and we aren't displaying a poster.
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::RenderVideo): (WebCore::RenderVideo::intrinsicSizeChanged): videoSizeChanged -> updateIntrinsicSize. (WebCore::RenderVideo::updateIntrinsicSize): Renamed from videoSizeChanged, calculate initial intrinsic size with calculateIntrinsicSize (WebCore::RenderVideo::calculateIntrinsicSize): New, calculate size according to current spec. (WebCore::RenderVideo::imageChanged): Reset intrinsic size to default when poster fails to load. (WebCore::RenderVideo::updatePlayer): Call updateIntrinsicSize.
- rendering/RenderVideo.h: Renamed videoSizeChanged to updateIntrinsicSize and make private.
2010-08-09 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=43702
<video> element does not resize correctly
- media/video-poster-expected.txt:
- media/video-poster.html:
- media/video-size-expected.txt:
- media/video-size.html:
- 11:44 AM Changeset in webkit [64996] by
-
- 4 edits in trunk/WebCore
2010-08-09 Marcus Bulach <bulach@chromium.org>
Reviewed by Jeremy Orlow.
Fixes custom JS bindings for IDBCursor after r64828.
https://bugs.webkit.org/show_bug.cgi?id=43729
Build fix, no tests.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSIDBAnyCustom.cpp: (WebCore::toJS):
- storage/IDBObjectStore.h:
- 11:33 AM Changeset in webkit [64995] by
-
- 3 edits in trunk/WebKitTools
2010-08-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
EWS bots wait 2 minutes between patches
https://bugs.webkit.org/show_bug.cgi?id=43731
- Scripts/webkitpy/tool/bot/queueengine.py:
- Don't sleep after failures. This was a hold-over from an earlier design.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- EWS bots were not properly reporting true/false from process_work_item. They were always returning None, thus false, thus always logging as a failure and sleeping 2 minutes after each patch.
- 11:22 AM Changeset in webkit [64994] by
-
- 4 edits in trunk/WebCore
2010-08-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64993.
http://trac.webkit.org/changeset/64993
https://bugs.webkit.org/show_bug.cgi?id=43734
broke chromium compile (Requested by jamesr on #webkit).
- platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::updateTextureContents):
- platform/graphics/chromium/CanvasLayerChromium.h:
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::~PlatformContextSkia): (WebCore::PlatformContextSkia::setGraphicsContext3D):
- 11:05 AM Changeset in webkit [64993] by
-
- 4 edits in trunk/WebCore
2010-08-09 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Add a PrepareTextureCallback to the chromium canvas layer compositor to upload mixed-mode results before compositing
https://bugs.webkit.org/show_bug.cgi?id=43656
When compositing an accelerated canvas that is using both hardware and software drawing,
we need a callback before compositing the layer to make sure that we upload any software
drawn results to the texture. This will go away as soon as implement all draw calls
in hardware.
To test, run any canvas demo that runs in mixed mode and verifies that the software results
always show up.
- platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::updateTextureContents):
- platform/graphics/chromium/CanvasLayerChromium.h: (WebCore::CanvasLayerChromium::setPrepareTextureCallback):
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PrepareTextureCallbackImpl::create): (WebCore::PrepareTextureCallbackImpl::willPrepareTexture): (WebCore::PrepareTextureCallbackImpl::PrepareTextureCallbackImpl): (WebCore::PlatformContextSkia::setGraphicsContext3D):
- 11:01 AM Changeset in webkit [64992] by
-
- 3 edits in trunk/WebKit2
2010-08-09 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
[Qt] No need for PageClientImpl
Remove PageClientImpl, take the implementation of WebKit::PageClient into QWKPagePrivate.
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPagePrivate::toolTipChanged):
- UIProcess/API/qt/qwkpage_p.h: (QWKPagePrivate::pageDidEnterAcceleratedCompositing): (QWKPagePrivate::pageDidLeaveAcceleratedCompositing): (QWKPagePrivate::processDidExit): (QWKPagePrivate::processDidRevive): (QWKPagePrivate::setCursor): (QWKPagePrivate::takeFocus):
- 10:50 AM Changeset in webkit [64991] by
-
- 9 edits in trunk/WebCore
2010-08-09 Dominic Cooney <dominicc@google.com>
Reviewed by Adam Barth.
Moves window.open logic into the generic bindings.
This patch moves window.open logic from V8 into the generic
bindings so it could be shared with JSC. JSC sharing is not in
this patch. This patch is of the same flavor/intent as 33201.
- bindings/generic/BindingDOMWindow.h: (WebCore::::createWindow): (WebCore::::open): (WebCore::::completeURL):
- bindings/generic/BindingSecurity.h: (WebCore::::allowPopUp): (WebCore::::shouldAllowNavigation):
- bindings/v8/V8Binding.h: (WebCore::V8Binding::emptyScriptValue):
- bindings/v8/V8Utilities.cpp: (WebCore::transferHiddenDependency): (WebCore::processingUserGesture): (WebCore::shouldAllowNavigation): (WebCore::completeURL):
- bindings/v8/custom/V8ArrayBufferCustom.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::showModalDialogCallback): (WebCore::V8DOMWindow::openCallback):
- bindings/v8/specialization/V8BindingState.cpp: (WebCore::::getActiveFrame): (WebCore::::getFirstFrame): (WebCore::::processingUserGesture):
- bindings/v8/specialization/V8BindingState.h: (WebCore::):
- 10:39 AM Changeset in webkit [64990] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-09 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Dimitri Glazkov.
Skip the slow software rendering path of GraphicsContext3D if accelerated
compositing is active. This fixes an issue with WebGL and the compositor
in which the software rendering of WebGL would cause the current GL context
to change while the compositor was processing layers. Tested by running
several WebGL samples both with the compositor enabled and disabled.
https://bugs.webkit.org/show_bug.cgi?id=43644
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::beginPaint):
- 10:36 AM Changeset in webkit [64989] by
-
- 2 edits2 adds in trunk/LayoutTests
Update chromium test results.
- platform/chromium-mac/editing/selection/5076323-1-expected.checksum: Added.
- platform/chromium-mac/editing/selection/5076323-1-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 10:05 AM Changeset in webkit [64988] by
-
- 3 edits in trunk/WebKit/chromium
2010-08-06 James Hawkins <jhawkins@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Notify the WebFrameClient when the frame is detached from
the view. This is used to clear the cached frame in the FormManager.
Eventually this will be removed once handling forms is moved into
WebCore.
https://bugs.webkit.org/show_bug.cgi?id=43648
- public/WebFrameClient.h: (WebKit::WebFrameClient::frameDetached):
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
- 9:39 AM Changeset in webkit [64987] by
-
- 2 edits in trunk/WebCore
2010-08-09 Marcus Bulach <bulach@chromium.org>
Reviewed by Darin Adler.
Fixes xcode project issues after r64828:
https://bugs.webkit.org/show_bug.cgi?id=43638
Build fix, no tests (sort-Xcode-project-file should not throw any warnings).
- WebCore.xcodeproj/project.pbxproj: fixed IDBCursor and related IndexedDB files, and re-ran sort-Xcode-project-file.
- 9:11 AM Changeset in webkit [64986] by
-
- 12 edits in trunk/WebCore
2010-08-09 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Remove callId argument from all backend agents' methods.
https://bugs.webkit.org/show_bug.cgi?id=43723
- inspector/CodeGeneratorInspector.pm:
- inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
- inspector/InspectorApplicationCacheAgent.h:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getProfilerLogLines): (WebCore::InspectorBackend::clearConsoleMessages): (WebCore::InspectorBackend::getDatabaseTableNames):
- inspector/InspectorBackend.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::getCookies): (WebCore::InspectorController::getDOMStorageEntries): (WebCore::InspectorController::setDOMStorageItem): (WebCore::InspectorController::removeDOMStorageItem): (WebCore::InspectorController::getProfileHeaders): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::getResourceContent):
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getChildNodes): (WebCore::InspectorDOMAgent::setAttribute): (WebCore::InspectorDOMAgent::removeAttribute): (WebCore::InspectorDOMAgent::removeNode): (WebCore::InspectorDOMAgent::changeTagName): (WebCore::InspectorDOMAgent::getOuterHTML): (WebCore::InspectorDOMAgent::setOuterHTML): (WebCore::InspectorDOMAgent::setTextNodeValue): (WebCore::InspectorDOMAgent::getEventListenersForNode): (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::getAllStyles): (WebCore::InspectorDOMAgent::getStyleSheet): (WebCore::InspectorDOMAgent::getRuleRanges): (WebCore::InspectorDOMAgent::getInlineStyle): (WebCore::InspectorDOMAgent::getComputedStyle): (WebCore::InspectorDOMAgent::applyStyleText): (WebCore::InspectorDOMAgent::setStyleText): (WebCore::InspectorDOMAgent::setStyleProperty): (WebCore::InspectorDOMAgent::toggleStyleEnabled): (WebCore::InspectorDOMAgent::setRuleSelector): (WebCore::InspectorDOMAgent::addRule): (WebCore::InspectorDOMAgent::pushNodeByPathToFrontend):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setBreakpoint): (WebCore::InspectorDebuggerAgent::editScriptSource): (WebCore::InspectorDebuggerAgent::getScriptSource):
- inspector/InspectorDebuggerAgent.h:
- 8:55 AM Changeset in webkit [64985] by
-
- 11 edits3 adds in trunk
Stub out EventSender for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=43703
WebKitTools:
Reviewed by Anders Carlsson.
- WebKitTestRunner/DerivedSources.make:
- WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
Add ability to pass javascript arguments to the wrapped object.
- WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
(WTR::EventSendingController::create):
(WTR::EventSendingController::EventSendingController):
(WTR::EventSendingController::~EventSendingController):
(WTR::EventSendingController::wrapperClass):
(WTR::setExceptionForString):
(WTR::EventSendingController::mouseDown):
(WTR::EventSendingController::mouseUp):
(WTR::EventSendingController::mouseMoveTo):
(WTR::EventSendingController::keyDown):
(WTR::EventSendingController::contextClick):
(WTR::EventSendingController::leapForward):
(WTR::EventSendingController::textZoomIn):
(WTR::EventSendingController::textZoomOut):
(WTR::EventSendingController::zoomPageIn):
(WTR::EventSendingController::zoomPageOut):
(WTR::EventSendingController::makeWindowObject):
- WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::reset):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::eventSendingController):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didClearWindowForFrame):
Add stubbed out EventSenderController.
- WebKitTestRunner/InjectedBundle/GCController.h:
Remove incorrect comment.
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/win/InjectedBundle.vcproj:
Add new files.
LayoutTests:
Reviewed by Anders Carlsson
- platform/mac-wk2/Skipped: Update.
- 8:52 AM Changeset in webkit [64984] by
-
- 7 edits in trunk
2010-08-09 François Sausset <François Sausset>
Reviewed by Kenneth Rohde Christiansen.
Add a test for mroot color handling.
https://bugs.webkit.org/show_bug.cgi?id=43628
- mathml/presentation/roots.xhtml:
- platform/mac/mathml/presentation/roots-expected.checksum:
- platform/mac/mathml/presentation/roots-expected.png:
- platform/mac/mathml/presentation/roots-expected.txt:
2010-08-09 François Sausset <François Sausset>
Reviewed by Kenneth Rohde Christiansen.
Take into account style color to draw MathML mroot radical.
https://bugs.webkit.org/show_bug.cgi?id=43628
Test: mathml/presentation/roots.xhtml
- mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::paint):
- 8:50 AM Changeset in webkit [64983] by
-
- 2 edits in trunk/WebKit/gtk
2010-08-09 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[gtk] gtk_im_context_focus_in() should only be called when an input-able element has focus
https://bugs.webkit.org/show_bug.cgi?id=43602
Only call gtk_im_context_focus_in() when we focus a frame which is currently in
an editable node.
- webkit/webkitwebview.cpp: (webkit_web_view_focus_in_event): Conditionalize call to gtk_im_context_focus_in().
- 8:40 AM Changeset in webkit [64982] by
-
- 8 edits in trunk
2010-08-09 François Sausset <François Sausset>
Reviewed by Kenneth Rohde Christiansen.
Add test for some deprecated MathML style attributes
https://bugs.webkit.org/show_bug.cgi?id=43503
- mathml/presentation/attributes.xhtml:
- platform/mac/mathml/presentation/attributes-expected.checksum:
- platform/mac/mathml/presentation/attributes-expected.png:
- platform/mac/mathml/presentation/attributes-expected.txt:
2010-08-09 François Sausset <François Sausset>
Reviewed by Kenneth Rohde Christiansen.
Implement MathML deprecated style attributes
https://bugs.webkit.org/show_bug.cgi?id=43503
Test: mathml/presentation/attributes.xhtml
- mathml/MathMLElement.cpp: (WebCore::MathMLElement::mapToEntry): (WebCore::MathMLElement::parseMappedAttribute):
- mathml/mathattrs.in:
- 7:59 AM Changeset in webkit [64981] by
-
- 2 edits in trunk/WebCore
2010-08-09 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: remove unnecessary did* methods from RemoteInspectorFrontend.
https://bugs.webkit.org/show_bug.cgi?id=43721
- inspector/CodeGeneratorInspector.pm:
- 6:56 AM Changeset in webkit [64980] by
-
- 4 edits in trunk/WebCore
2010-08-09 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Antonio Gomes.
Canvas: Fast-path for setting the already set color with setStrokeColor() and setFillColor()
https://bugs.webkit.org/show_bug.cgi?id=43718
Avoid creating CanvasStyle objects when setting the same fill or stroke color using
the WebKit-specific setters of CanvasRenderingContext2D.
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setStrokeColor): (WebCore::CanvasRenderingContext2D::setFillColor):
- html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::isEquivalentColor):
- html/canvas/CanvasStyle.h: Added CanvasStyle::isEquivalentColor() overloads for RGBA and CMYKA channel values.
- 6:34 AM Changeset in webkit [64979] by
-
- 2 edits in trunk/LayoutTests
2010-08-09 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Chromium expectations update.
- platform/chromium/test_expectations.txt:
- 6:00 AM Changeset in webkit [64978] by
-
- 4 edits in trunk
2010-08-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: restore original last panel restore logic.
- inspector/front-end/inspector.js: (WebInspector.showPanel):
- 5:23 AM Changeset in webkit [64977] by
-
- 5 edits in trunk
2010-08-09 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: Chromium tests fix.
Chromium: provisional interactive ui tests fix.
- src/js/Tests.js: (.TestSuite.prototype.testShowStoragePanel.this): (.TestSuite.prototype.testShowStoragePanel):
2010-08-09 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: Chromium tests fix.
Chromium: provisional interactive ui tests fix.
- http/tests/inspector/inspector-test.js: (frontend_setupTestEnvironment):
- inspector/elements-panel-limited-children.html:
- 4:57 AM Changeset in webkit [64976] by
-
- 5 edits in trunk/WebCore
Unreviewed, fixing the builds after r64967.
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- 4:48 AM Changeset in webkit [64975] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-09 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Chromium tests fix.
Disable runtime switch for device motion in chromium.
https://bugs.webkit.org/show_bug.cgi?id=43717
- src/WebViewImpl.cpp: (WebKit::WebView::create):
- 4:40 AM Changeset in webkit [64974] by
-
- 7 edits3 adds in trunk
2010-05-20 MORITA Hajime <morrita@google.com>
Reviewed by Ojan Vafai.
<http://webkit.org/b/36360>
Double clicking page's first editable inline element cannot select a word.
<http://webkit.org/b/36359>
Double clicking page's last editable inline element causes assertion failure.
- editing/selection/doubleclick-inline-first-last-contenteditable-expected.txt: Added.
- editing/selection/doubleclick-inline-first-last-contenteditable.html: Added.
- editing/selection/script-tests/doubleclick-inline-first-last-contenteditable.js: Added.
2010-05-27 MORITA Hajime <morrita@google.com>
Reviewed by Ojan Vafai.
<http://webkit.org/b/36359>
Double clicking page's last editable inline element causes assertion failure.
<http://webkit.org/b/36360>
Double clicking page's first editable inline element cannot select a word.
nextBoundary() and previousBoundary() assumed that editable
boundaries are on block-level elements, But it can appear on
inline-level elements. So we start boundary look-up from the given
node, instead of the containingBlock of the given node.
Also, added TextIteratorEndsAtEditingBoundary to
BackwardsCharacterIterator, otherwise, the VisiblePosition
returned by BackwardsCharacterIterator might cross an editing
boundary.
Test: editing/selection/doubleclick-inline-first-last-contenteditable.html
- dom/Position.cpp: (WebCore::Position::parentEditingBoundary): Added.
- dom/Position.h:
- editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): (WebCore::SimplifiedBackwardsTextIterator::advance): (WebCore::SimplifiedBackwardsTextIterator::crossesEditingBoundary): Added. (WebCore::SimplifiedBackwardsTextIterator::setCurrentNode): Added. (WebCore::SimplifiedBackwardsTextIterator::clearCurrentNode): Added. (WebCore::BackwardsCharacterIterator::BackwardsCharacterIterator):
- editing/TextIterator.h: (WebCore::):
- editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::nextBoundary):
- 4:26 AM Changeset in webkit [64973] by
-
- 19 edits in trunk
2010-08-09 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: Current implementation of showPanel is a bit complicated.
It is using internal enum for all the panels and this is the problem because
we should change a lot of code for a new panel.
https://bugs.webkit.org/show_bug.cgi?id=43711
- WebCore.exp.in:
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::storeLastActivePanel): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::showPanel): (WebCore::InspectorController::disconnectFrontend):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp:
- inspector/InspectorFrontend.h:
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.selectOnMouseDown):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
- inspector/front-end/inspector.js: (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector.toggleSearchingForNode): (WebInspector.showPanel): (WebInspector.selectDatabase): (WebInspector.selectDOMStorage): (WebInspector.showProfileForURL):
2010-08-09 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: Current implementation of showPanel is a bit complicated.
It is using internal enum for all the panels and this is the problem because
we should change a lot of code for a new panel.
https://bugs.webkit.org/show_bug.cgi?id=43711
- inspector/debugger-breakpoints-not-activated-on-reload.html:
- inspector/debugger-cyclic-ref.html:
- inspector/debugger-eval-while-paused.html:
- inspector/debugger-no-nested-pause.html:
- inspector/debugger-pause-in-eval-script.html:
- inspector/debugger-pause-on-debugger-statement.html:
- inspector/debugger-proto-property.html:
- inspector/elements-panel-limited-children.html:
- 3:50 AM MathML 3 testsuite results edited by
- (diff)
- 3:24 AM MathML 3 testsuite results edited by
- (diff)
- 3:17 AM MathML 3 testsuite results edited by
- (diff)
- 2:48 AM Changeset in webkit [64972] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium: Remove temporary device motion fix.
- src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableDeviceOrientation):
- 2:36 AM Changeset in webkit [64971] by
-
- 2 edits in trunk/WebCore
2010-08-09 Ariya Hidayat <ariya@sencha.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsContext::clipOut(IntRect) ignores the transformation matrix.
https://bugs.webkit.org/show_bug.cgi?id=43705
Just like clipOut(Path), which is taken care in r60796 already,
clipOut(IntRect) must transform the window bounding box properly.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipOut):
- 2:18 AM Changeset in webkit [64970] by
-
- 2 edits in trunk/LayoutTests
2010-08-09 Shinichiro Hamaji <hamaji@chromium.org>
Update chromium's expectation.
- platform/chromium/test_expectations.txt: Drop SLOW as SLOW and TIMEOUT isn't allowed.
- 2:14 AM Changeset in webkit [64969] by
-
- 2 edits in trunk/LayoutTests
2010-08-09 Shinichiro Hamaji <hamaji@chromium.org>
Update chromium's expectation.
- platform/chromium/test_expectations.txt: Mark http/tests/misc/bad-charset-alias as a slow test.
- 1:49 AM Changeset in webkit [64968] by
-
- 2 edits in trunk/LayoutTests
2010-08-09 Shinichiro Hamaji <hamaji@chromium.org>
Update chromium's expectation.
- platform/chromium/test_expectations.txt: Mark fast/parser/residual-style-hang as a slow test.
- 1:33 AM QtWebKitMediaElementSupport edited by
- (diff)
- 12:53 AM Changeset in webkit [64967] by
-
- 20 edits6 adds in trunk
2010-08-09 François Sausset <François Sausset>
Reviewed by Kenneth Rohde Christiansen.
Add a test for the mfenced MathML element and update tests with stretched parenthesis/brackets/operators
https://bugs.webkit.org/show_bug.cgi?id=42472
- mathml/presentation/fenced.xhtml: Added.
- mathml/presentation/row.xhtml:
- platform/mac/mathml/presentation/fenced-expected.checksum: Added.
- platform/mac/mathml/presentation/fenced-expected.png: Added.
- platform/mac/mathml/presentation/fenced-expected.txt: Added.
- platform/mac/mathml/presentation/mo-expected.checksum:
- platform/mac/mathml/presentation/mo-expected.png:
- platform/mac/mathml/presentation/mo-expected.txt:
- platform/mac/mathml/presentation/over-expected.checksum:
- platform/mac/mathml/presentation/over-expected.png:
- platform/mac/mathml/presentation/over-expected.txt:
- platform/mac/mathml/presentation/row-alignment-expected.checksum:
- platform/mac/mathml/presentation/row-alignment-expected.png:
- platform/mac/mathml/presentation/row-alignment-expected.txt:
- platform/mac/mathml/presentation/row-expected.checksum:
- platform/mac/mathml/presentation/row-expected.png:
- platform/mac/mathml/presentation/row-expected.txt:
- platform/mac/mathml/presentation/tables-expected.checksum:
- platform/mac/mathml/presentation/tables-expected.png:
2010-08-09 François Sausset <François Sausset>
Reviewed by Kenneth Rohde Christiansen.
Implement mfenced MathML element
Update stretchy operator code to take into account new brackets and to tune layout parameters
https://bugs.webkit.org/show_bug.cgi?id=42472
Test: mathml/presentation/fenced.xhtml
- WebCore.xcodeproj/project.pbxproj:
- mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::MathMLInlineContainerElement): (WebCore::MathMLInlineContainerElement::createRenderer):
- mathml/RenderMathMLFenced.cpp: Added. (WebCore::RenderMathMLFenced::RenderMathMLFenced): (WebCore::RenderMathMLFenced::updateFromElement): (WebCore::RenderMathMLFenced::makeOperatorStyle): (WebCore::RenderMathMLFenced::makeFences): (WebCore::RenderMathMLFenced::addChild): (WebCore::RenderMathMLFenced::layout):
- mathml/RenderMathMLFenced.h: Added.
- mathml/RenderMathMLOperator.cpp: (WebCore::RenderMathMLOperator::RenderMathMLOperator): (WebCore::RenderMathMLOperator::stretchToHeight): (WebCore::): (WebCore::RenderMathMLOperator::updateFromElement): (WebCore::RenderMathMLOperator::createStackableStyle): (WebCore::RenderMathMLOperator::createGlyph):
Aug 8, 2010:
- 11:56 PM Changeset in webkit [64966] by
-
- 2 edits in trunk/WebCore
2010-08-08 ryuan choi <ryuan.choi@samsung.com>
Reviewed by Darin Adler.
REGRESSION(64898,64949) build break because of wrong filename
https://bugs.webkit.org/show_bug.cgi?id=43701
add SVGPathStringSource.cpp and modify SVGPathSourceString.cpp to
SVGPathStringSource.cpp
simple fixing build break, so No new tests.
- CMakeLists.txt:
- 10:47 PM Changeset in webkit [64965] by
-
- 15 edits in trunk
2010-08-08 Ariya Hidayat <ariya@sencha.com>
Reviewed by Antonio Gomes.
Inconsistent Qt version checks
https://bugs.webkit.org/show_bug.cgi?id=43695
Use QT_VERSION_CHECK macro instead of encoded hex.
- Api/qgraphicswebview.cpp: (QGraphicsWebView::QGraphicsWebView): (QGraphicsWebViewPrivate::detachCurrentPage):
- Api/qwebframe.cpp: (QWebFrame::load):
- Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): (QWebPagePrivate::inputMethodEvent): (QWebPage::inputMethodQuery): (QWebPage::view):
- Api/qwebview.cpp: (QWebViewPrivate::detachCurrentPage):
- WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
- WebCoreSupport/PageClientQt.cpp:
- WebCoreSupport/PageClientQt.h:
- 10:43 PM Changeset in webkit [64964] by
-
- 2 edits in trunk/WebCore
2010-08-08 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Antonio Gomes.
Web Inspector: Fix warning in WebCore/inspector/InspectorDebuggerAgent.cpp
https://bugs.webkit.org/show_bug.cgi?id=43698
- inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::editScriptSource): Add suggested parentheses.
- 10:26 PM Changeset in webkit [64963] by
-
- 10 edits3 adds in trunk
2010-08-04 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
Pasting should fire textInput event.
https://bugs.webkit.org/show_bug.cgi?id=42958
- editing/pasteboard/paste-text-events-expected.txt: Added.
- editing/pasteboard/paste-text-events.html: Added.
- editing/pasteboard/script-tests/paste-text-events.js: Added.
2010-08-05 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
Pasting should fire textInput event.
https://bugs.webkit.org/show_bug.cgi?id=42958
- Extended TextEvents to hold paste-specific parameters
- Did fire TextEvents at where we originally did immediate pastes.
- Factored out TextEvent handling from EventHandler::defaultTextInputEventHandler() to Editor::handleTextEvent() because it's solely done by the editor.
- move actual pasting logic to Editor::handleTextEvent()
Test: editing/pasteboard/paste-text-events.html
- WebCore.exp.in:
- dom/TextEvent.cpp: (WebCore::TextEvent::create): (WebCore::TextEvent::createForPlainTextPaste): (WebCore::TextEvent::createForFragmentPaste): (WebCore::TextEvent::TextEvent):
- dom/TextEvent.h: (WebCore::TextEvent::isPaste): (WebCore::TextEvent::shouldSmartReplace): (WebCore::TextEvent::shouldMatchStyle): (WebCore::TextEvent::pastingFragment):
- editing/Editor.cpp: (WebCore::Editor::handleTextEvent): (WebCore::Editor::pasteAsPlainText): (WebCore::Editor::pasteAsFragment): (WebCore::Editor::pasteAsPlainTextWithPasteboard): (WebCore::Editor::pasteWithPasteboard): (WebCore::Editor::dispatchCPPEvent): (WebCore::Editor::findEventTargetFromSelection):
- editing/Editor.h:
- page/EventHandler.cpp: (WebCore::EventHandler::defaultTextInputEventHandler):
2010-08-04 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
Pasting should fire textInput event.
https://bugs.webkit.org/show_bug.cgi?id=42958
On paste, invoke Editor instead of direct command invocation,
which allows dispatching events before actual paste.
- WebView/WebHTMLView.mm: (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
- 9:29 PM Changeset in webkit [64962] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-08-05 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
Should have test: textInput should not fired when preceding key events are cancelled.
https://bugs.webkit.org/show_bug.cgi?id=43601
- fast/events/inputText-never-fired-on-keydown-cancel-expected.txt: Added.
- fast/events/inputText-never-fired-on-keydown-cancel.html: Added.
- fast/events/script-tests/inputText-never-fired-on-keydown-cancel.js: Added. (handleTextInput): (mayCancel): (setup): (test):
- 9:05 PM Changeset in webkit [64961] by
-
- 2 edits in trunk/WebKitTools
2010-08-08 Kent Tamura <tkent@chromium.org>
Unreviewed, trivial fix.
Fix "WindowsError: [Error 32] The process cannot access the file
because it is being used by another process" introduced by r64959.
- BuildSlaveSupport/test-result-archive:
- 7:16 PM Changeset in webkit [64960] by
-
- 3 edits in trunk/LayoutTests
2010-08-08 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
- 6:26 PM Changeset in webkit [64959] by
-
- 2 edits in trunk/WebKitTools
Chromium buildbot: Avoid "zip" command dependency
https://bugs.webkit.org/show_bug.cgi?id=43470
Reviewed by Tony Chang.
- BuildSlaveSupport/test-result-archive: For Chromium port, creates a zip archive with zipfile package of Python instead of external "zip" command. We'd like to avoid additional command installation.
- 6:12 PM Changeset in webkit [64958] by
-
- 2 edits in trunk/WebCore
[wx] Build fix, add member needed to compile Mac-specific font code.
- 3:27 PM Changeset in webkit [64957] by
-
- 2 edits in trunk/WebCore
2010-08-08 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Eric Seidel.
[Qt] Fix warnings in WebCore/platform/WindowsKeyboardCodes.h
https://bugs.webkit.org/show_bug.cgi?id=43360
- platform/WindowsKeyboardCodes.h: Undef macros which are also defined in MinGW/include/winuser.h to aviod gcc redefinition warning
- 1:30 PM Changeset in webkit [64956] by
-
- 9 edits in trunk/LayoutTests
2010-08-08 James Robinson <jamesr@chromium.org>
Unreviewed. Rebaseline chromium results for r64954.
- platform/chromium-linux/fast/forms/formmove3-expected.txt:
- platform/chromium-win/fast/forms/formmove3-expected.txt:
- platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/chromium-win/fast/invalid/003-expected.txt:
- platform/chromium-win/fast/invalid/019-expected.txt:
- platform/chromium-win/tables/mozilla/bugs/bug647-expected.txt:
- platform/chromium-win/tables/mozilla/other/wa_table_tr_align-expected.txt:
- platform/chromium/test_expectations.txt:
- 1:24 PM Changeset in webkit [64955] by
-
- 2 edits in trunk/LayoutTests
Add more items to WebKit2 skipped list.
Rubber stamped by Sam Weinig.
- platform/mac-wk2/Skipped:
- 12:29 PM Changeset in webkit [64954] by
-
- 11 edits in trunk
2010-08-08 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Set the shouldLazyAttach flag to true in the tree builder's adoption agency algorithm
https://bugs.webkit.org/show_bug.cgi?id=43610
Sets the shouldLazyAttach flag to true for appendChild() calls inside the HTML tree
builder's adoption agency flag. This is a speedup assuming that nodes subjected
to the adoption agency are likely to be frequently reparented, and thus it is better
to delay creating the render tree until later (when hopefully the DOM is finalized).
On my mac pro this speeds up fast/parser/residual-style-hang.html by 2.6X.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
2010-08-08 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Set the shouldLazyAttach flag to true in the tree builder's adoption agency algorithm
https://bugs.webkit.org/show_bug.cgi?id=43610
New baselines for tests where the render tree depends on 0x0 render objects being
created/destroyed during adoption agency fixups.
- platform/mac/fast/forms/formmove3-expected.txt:
- platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/mac/fast/invalid/003-expected.txt:
- platform/mac/fast/invalid/019-expected.txt:
- platform/mac/tables/mozilla/bugs/bug647-expected.txt:
- platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:
- 10:56 AM Changeset in webkit [64953] by
-
- 3 edits in trunk/LayoutTests
2010-08-08 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
fast/events/onunload-back-to-page-cache.html does not pass with GTK DRT
https://bugs.webkit.org/show_bug.cgi?id=43692
Update onunload-back-to-page-cache.html to set the frame name later,
so that the onunload handler console message doesn't have it. Also
include a message about what exactly we're testing.
- fast/events/onunload-back-to-page-cache-expected.txt:
- fast/events/script-tests/onunload-back-to-page-cache.js: (onpageshow):
- 10:45 AM Changeset in webkit [64952] by
-
- 2 edits in trunk/WebCore
2010-08-08 Nikita Vasilyev <me@elv1s.ru>
Reviewed by Pavel Feldman.
Web Inspector: speed-up Element.prototype.removeChildren
https://bugs.webkit.org/show_bug.cgi?id=43687
- inspector/front-end/utilities.js: (Element.prototype.removeChildren):
- 9:47 AM Changeset in webkit [64951] by
-
- 11 edits in trunk/WebCore
2010-08-08 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: remove hand written InspectorFrontend from almost all places.
https://bugs.webkit.org/show_bug.cgi?id=43630
- inspector/ConsoleMessage.cpp:
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::pushNodePathToFrontend):
- inspector/InjectedScriptHost.h:
- inspector/Inspector.idl:
- inspector/InspectorBackend.cpp:
- inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::inspect): (WebCore::InspectorController::focusNode): (WebCore::InspectorController::windowVisible): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::setSearchingForNode): (WebCore::InspectorController::setMonitoringXHR): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::show): (WebCore::InspectorController::showPanel): (WebCore::InspectorController::close): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableResourceTracking): (WebCore::InspectorController::disableResourceTracking): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::postWorkerNotificationToFrontend): (WebCore::InspectorController::didCreateWorker): (WebCore::InspectorController::didDestroyWorker): (WebCore::InspectorController::toggleRecordButton): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::evaluateForTestInFrontend):
- inspector/InspectorFrontend.cpp:
- inspector/InspectorFrontend.h:
- inspector/InspectorFrontendClientLocal.cpp:
- inspector/TimelineRecordFactory.cpp:
- 9:41 AM Changeset in webkit [64950] by
-
- 2 edits in trunk/WebCore
Try to fix the Chromium Mac build after r64915.
- platform/graphics/chromium/FontPlatformDataChromiumMac.mm:
(WebCore::FontPlatformData::ctFont): Copied from mac/FontPlatformDataMac.mm.
- 9:10 AM Changeset in webkit [64949] by
-
- 18 edits2 adds in trunk/WebCore
2010-08-08 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Add missing String builder for SVGPathParser
https://bugs.webkit.org/show_bug.cgi?id=43682
Introduces SVGPathStringBuilder. SVGPathParser clients, like normalized and unaltered
SVGPathSegLists or SVGPathByteStreams, can be parsed and transformed to a string.
StringBuilder can create a string of individual strings, seperated by spaces now.
Share more code in SVGPathParserFactory and use a common general concept to manage SVG path
data parsing.
Doesn't affect any tests.
- Android.mk:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/text/StringBuilder.cpp: (WebCore::StringBuilder::toString): Added possibility to use a space between individual strings.
- platform/text/StringBuilder.h: Cleanup according to WebKit style. (WebCore::): (WebCore::StringBuilder::StringBuilder): (WebCore::StringBuilder::setNonNull): (WebCore::StringBuilder::isNull):
- svg/SVGAllInOne.cpp:
- svg/SVGPathBuilder.h: (WebCore::SVGPathBuilder::cleanup): Clear all references.
- svg/SVGPathByteStreamBuilder.h: (WebCore::SVGPathByteStreamBuilder::cleanup): dito.
- svg/SVGPathConsumer.h:
- svg/SVGPathParser.cpp: (WebCore::SVGPathParser::cleanup): dito.
- svg/SVGPathParser.h:
- svg/SVGPathParserFactory.cpp: Cleanup of factory. More code get shared. (WebCore::globalSVGPathBuilder): (WebCore::globalSVGPathSegListBuilder): (WebCore::globalSVGPathByteStreamBuilder): (WebCore::globalSVGPathStringBuilder): (WebCore::globalSVGPathParser): (WebCore::SVGPathParserFactory::buildPathFromString): (WebCore::SVGPathParserFactory::buildPathFromByteStream): (WebCore::SVGPathParserFactory::buildSVGPathSegListFromString): (WebCore::SVGPathParserFactory::buildSVGPathSegListFromByteStream): (WebCore::SVGPathParserFactory::buildStringFromByteStream): (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString):
- svg/SVGPathParserFactory.h:
- svg/SVGPathSegListBuilder.h: (WebCore::SVGPathSegListBuilder::cleanup):
- svg/SVGPathStringBuilder.cpp: Added. Build string from parsed SVG data. (WebCore::SVGPathStringBuilder::SVGPathStringBuilder): (WebCore::SVGPathStringBuilder::moveTo): (WebCore::SVGPathStringBuilder::lineTo): (WebCore::SVGPathStringBuilder::lineToHorizontal): (WebCore::SVGPathStringBuilder::lineToVertical): (WebCore::SVGPathStringBuilder::curveToCubic): (WebCore::SVGPathStringBuilder::curveToCubicSmooth): (WebCore::SVGPathStringBuilder::curveToQuadratic): (WebCore::SVGPathStringBuilder::curveToQuadraticSmooth): (WebCore::SVGPathStringBuilder::arcTo): (WebCore::SVGPathStringBuilder::closePath):
- svg/SVGPathStringBuilder.h: Added. (WebCore::SVGPathStringBuilder::cleanup): (WebCore::SVGPathStringBuilder::result):
- 1:32 AM Changeset in webkit [64948] by
-
- 3 edits in trunk/WebKitTools
WebKitTestRunner should add the QuickTime dir to the PATH environment
variable
https://bugs.webkit.org/show_bug.cgi?id=43686
Reviewed by Dan Bernstein.
- WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::addQTDirToPATH):
Copied from DRT.
(WTR::TestController::platformInitialize):
Call addQTDirToPath().
- WebKitTestRunner/win/WebKitTestRunner.vcproj:
Link to shlwapi.lib for SHGetValue.
- 1:07 AM Changeset in webkit [64947] by
-
- 2 edits in trunk/WebCore
2010-08-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
cross_fuzz WebCore::SelectionController::isFocusedAndActive ReadAV@NULL (9e865de49b1800ec790dcc35d8ebd069)
https://bugs.webkit.org/show_bug.cgi?id=43040
The pointer from Document to Frame can be null. See http://webkit.org/coding/major-objects.html.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- 12:55 AM Changeset in webkit [64946] by
-
- 2 edits in trunk/WebCore
2010-08-08 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
frame()->selection() can't be null
https://bugs.webkit.org/show_bug.cgi?id=43681
SelectionController is a component of Frame. If frame is non-null, it
can't possibly be null.
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::setActive):
- 12:45 AM Changeset in webkit [64945] by
-
- 3 edits2 adds in trunk
2010-08-08 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
SVGLength uses ASSERTs to validate user input
https://bugs.webkit.org/show_bug.cgi?id=43680
Send invalid input to trigger old ASSERTs.
- svg/dom/svg-length-units-expected.txt: Added.
- svg/dom/svg-length-units.html: Added.
2010-08-08 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
SVGLength uses ASSERTs to validate user input
https://bugs.webkit.org/show_bug.cgi?id=43680
ASSERTs aren't in release builds, so we can't use them to validate user
input! We've seen a bunch of examples of this in SVG code. It might
be worth auditing all the code to remove this misguided pattern.
Test: svg/dom/svg-length-units.html
- svg/SVGLength.cpp: (WebCore::SVGLength::newValueSpecifiedUnits): (WebCore::SVGLength::convertToSpecifiedUnits):
- 12:33 AM Changeset in webkit [64944] by
-
- 5 edits in trunk/LayoutTests
2010-08-08 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Chromium: isindex tests timeout after r64712
https://bugs.webkit.org/show_bug.cgi?id=43543
Update isindex tests/expectactions after r64712 so that even though they
stil fail, they fail immediately instead of timing out.
- http/tests/misc/isindex-formdata-expected.txt:
- http/tests/misc/isindex-formdata.html:
- http/tests/misc/isindex-with-no-form-base-href-expected.txt:
- http/tests/misc/resources/isindex-with-no-form-base-href.html:
- 12:22 AM Changeset in webkit [64943] by
-
- 21 edits1 delete in trunk/JavaScriptCore
2010-08-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64938.
http://trac.webkit.org/changeset/64938
https://bugs.webkit.org/show_bug.cgi?id=43685
Did not compile on several ports (Requested by abarth on
#webkit).
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/AbstractMacroAssembler.h:
- assembler/MacroAssembler.h:
- assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::load32): (JSC::MacroAssemblerX86::store32):
- assembler/X86Assembler.h: (JSC::X86Assembler::movl_rm): (JSC::X86Assembler::movl_mr):
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::markAggregate):
- bytecode/Instruction.h: (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::): (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set): (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
- bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::deref):
- bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::initGetByIdProto): (JSC::StructureStubInfo::initGetByIdChain): (JSC::StructureStubInfo::):
- jit/JIT.h:
- jit/JITMarkObjects.cpp: Removed.
- jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetDirectOffset): (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITPropertyAccess32_64.cpp: (JSC::JIT::compileGetDirectOffset): (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITStubs.cpp: (JSC::setupPolymorphicProtoList):
- wtf/Platform.h:
