Timeline



Sep 7, 2010:

10:56 PM Changeset in webkit [66954] by weinig@apple.com
  • 5 edits
    3 adds in trunk

DatasetDOMStringMap does not have the right memory model
https://bugs.webkit.org/show_bug.cgi?id=45358

Reviewed by Dan Bernstein.

WebCore:

Test: fast/dom/dataset-gc.html

  • bindings/js/JSElementCustom.cpp:

(WebCore::JSElement::markChildren):
Mark the dataset if it exists.

  • dom/Element.cpp:

(WebCore::Element::optionalDataset):

  • dom/Element.h:

Expose a way to get the dataset or null (depending on if anyone thing
has forced its creation yet).

LayoutTests:

Test that the dataset persists gc.

  • fast/dom/dataset-gc-expected.txt: Added.
  • fast/dom/dataset-gc.html: Added.
  • fast/dom/script-tests/dataset-gc.js: Added.
10:54 PM Changeset in webkit [66953] by kinuko@chromium.org
  • 3 edits in trunk/WebKitTools

2010-09-07 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Ojan Vafai.

Enable incremental results.json generation for non-layout tests.
https://bugs.webkit.org/show_bug.cgi?id=45315

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.) Also add a code to upload results json files to the app-engine server. Need a chromium change to actually start the uploading.
  • TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.
10:30 PM Changeset in webkit [66952] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

10:28 PM Changeset in webkit [66951] by mrowe@apple.com
  • 1 copy in tags/Safari-534.7

New tag.

9:58 PM Changeset in webkit [66950] by kinuko@chromium.org
  • 2 edits in trunk/WebKit2

2010-09-07 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed, another Qt release build fix attempt.

  • UIProcess/API/cpp/qt/WKURLQt.cpp:
9:52 PM Changeset in webkit [66949] by kinuko@chromium.org
  • 2 edits in trunk/WebKit2

2010-09-07 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed, attempt to fix Qt release build.

  • UIProcess/API/cpp/qt/WKStringQt.cpp:
9:02 PM Changeset in webkit [66948] by commit-queue@webkit.org
  • 5 edits
    3 adds
    1 delete in trunk

2010-09-07 Jan E Hanssen <jhanssen@sencha.com>

Reviewed by Andreas Kling.

[Qt] Added test case for Path::length()
https://bugs.webkit.org/show_bug.cgi?id=45331

Also removed test case for Path::pointAtLength() that is now passing

  • platform/qt/svg/dom/path-pointAtLength-expected.txt: Removed.
  • svg/dom/path-totalLength-expected.txt: Added.
  • svg/dom/path-totalLength.html: Added.
  • svg/dom/script-tests/path-totalLength.js: Added. (getTotalLength):

2010-09-07 Jan E Hanssen <jhanssen@sencha.com>

Reviewed by Andreas Kling.

[Qt] Add a separate Path::closeCanvasSubpath() function for canvas paths
https://bugs.webkit.org/show_bug.cgi?id=45331

This is needed due to an adverse effect of the fix in 44061 that causes
certain paths not to be closed. This is not important for canvas paths
but it is for SVG paths, so splitting up the code in a generic (SVG)
case and one specialized for canvas.

Test: svg/dom/path-totalLength.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::closePath):
  • platform/graphics/Path.h: (WebCore::Path::closeCanvasSubpath):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::closeSubpath): (WebCore::Path::closeCanvasSubpath):
8:01 PM Changeset in webkit [66947] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-07 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix

Missed one test in mac_unittest.py in previous change; for some
reason the method is listed twice. I will fix both for now, but will
figure this out in a later, not-time-sensitive patch.

https://bugs.webkit.org/show_bug.cgi?id=45357

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
7:56 PM Changeset in webkit [66946] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-07 Kent Tamura <tkent@chromium.org>

Reviewed by Tony Chang.

test-webkitpy: Fix load error of
webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short

  • Scripts/webkitpy/layout_tests/port/server_process.py: Avoid to import fcntl on win32. Win32 Python doesn't have fcntl and we don't use server_process.py on Win32 Python. However unittest.py tries to load everything in a module.
7:23 PM Changeset in webkit [66945] by dpranke@chromium.org
  • 4 edits in trunk/WebKitTools

2010-09-07 Dirk Pranke <dpranke@chromium.org>

Reviewed by Kent Tamura.

Fix regression introduced in previous change to new-run-webkit-tests
(bug 45090) to not try to run unittests for the Mac implementation
of the Port interface if we aren't running on a Mac.

Also fix the overrides implementation mock in the chromium unittests
to fix the case where there are overrides checked in that cause
problems.

https://bugs.webkit.org/show_bug.cgi?id=45357

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
6:26 PM Changeset in webkit [66944] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-07 Ojan Vafai <ojan@chromium.org>

Reviewed by Kent Tamura.

Markup.waitUntilDone does not call Markup.noAutoDump without LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=45123

  • resources/dump-as-markup.js: (Markup.waitUntilDone):
6:15 PM Changeset in webkit [66943] by jamesr@google.com
  • 2 edits in trunk/JavaScriptCore

2010-09-07 James Robinson <jamesr@chromium.org>

Compile fix attempt for windows.

6:10 PM Changeset in webkit [66942] by Simon Fraser
  • 2 edits
    1 add in trunk/WebCore

2010-09-07 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Transform animations always run in software now
https://bugs.webkit.org/show_bug.cgi?id=45341

After r66339 we always fell into software animation, because we
failed to detect transform or opacity properties in the keyframes,
so would send an empty list of values to the GraphicsLayer.

Fixed by using CSSProperty values, rather than GraphicsLayer
values, when detecting the presence of properties in the keyframes.

Test: manual-tests/transition-accelerated.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation):
6:02 PM Changeset in webkit [66941] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-09-07 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

audio engine: add FFTFrame files
https://bugs.webkit.org/show_bug.cgi?id=34827

No new tests since audio API is not yet implemented.

  • platform/audio/FFTFrame.cpp: Added. (WebCore::FFTFrame::doPaddedFFT): (WebCore::FFTFrame::createInterpolatedFrame): (WebCore::FFTFrame::interpolateFrequencyComponents): (WebCore::FFTFrame::extractAverageGroupDelay): (WebCore::FFTFrame::addConstantGroupDelay): (WebCore::FFTFrame::print):
  • platform/audio/FFTFrame.h: Added. (WebCore::FFTFrame::fftSize): (WebCore::FFTFrame::log2FFTSize): (WebCore::FFTFrame::dspSplitComplex):
  • platform/audio/mac/FFTFrameMac.cpp: Added. (WebCore::FFTFrame::FFTFrame): (WebCore::FFTFrame::~FFTFrame): (WebCore::FFTFrame::multiply): (WebCore::FFTFrame::doFFT): (WebCore::FFTFrame::doInverseFFT): (WebCore::FFTFrame::fftSetupForSize): (WebCore::FFTFrame::cleanup): (WebCore::FFTFrame::realData): (WebCore::FFTFrame::imagData):
5:54 PM Changeset in webkit [66940] by jamesr@google.com
  • 2 edits in trunk/JavaScriptCore

2010-09-07 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

Fix Windows build after r66936
https://bugs.webkit.org/show_bug.cgi?id=45348

Add symbol names that were missing from r66936.

5:50 PM Changeset in webkit [66939] by bfulgham@webkit.org
  • 5 edits in trunk

WebCore: Build fix, no review.

Provide stubs to allow WebKit.dll to build
for the WinCairo port.

  • platform/network/curl/ResourceRequest.h:

(WebCore::ResourceRequest::ResourceRequest):

  • platform/network/curl/ResourceResponse.h:

(WebCore::ResourceResponse::cfURLResponse):

WebKit2: Build correction, no review.

  • win/WebKit2.vcproj: Disable two unused files for

the WinCairo target.

5:48 PM Changeset in webkit [66938] by crogers@google.com
  • 1 edit
    1 add in trunk/WebCore

2010-09-07 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioArray.h
https://bugs.webkit.org/show_bug.cgi?id=45204

No new tests since audio API is not yet implemented.

  • platform/audio/AudioArray.h: Added. (WebCore::AudioArray::AudioArray): (WebCore::AudioArray::zero): (WebCore::AudioArray::zeroRange): (WebCore::AudioArray::copyToRange):
5:46 PM Changeset in webkit [66937] by dpranke@chromium.org
  • 14 edits
    2 copies
    14 adds in trunk/WebKitTools

2010-09-01 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: still more unit tests

Clean up and remove unnecessary code. Biggest notable change is
moving the chromium-specific imagediff code from port/base to
port/chromium.

Add more unit tests for run_webkit_tests.py, port/base.py,
port/factory.py, port/dryrun.py, and
layout_package/dump_render_tree_thread.py

This covers almost all of the generic and test code paths except for
a few error paths involving invalid or port-specific command line
arguments, and the code path for uploading results files to the
buildbots.

https://bugs.webkit.org/show_bug.cgi?id=45090

  • Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
  • Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
  • Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
  • Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
  • Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
  • Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
  • Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
  • Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
5:33 PM Changeset in webkit [66936] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

2010-09-07 Mihai Parparita <mihaip@chromium.org>

Reviewed by Oliver Hunt.

pushState and replaceState do not clone RegExp objects correctly
https://bugs.webkit.org/show_bug.cgi?id=44718

Move internal representation of JSC::RegExp (which depends on wether
YARR and YARR_JIT is enabled) into RegExpRepresentation which can live
in the implementation only. This makes it feasible to use RegExp in
WebCore without bringing in all of YARR.

  • JavaScriptCore.exp: Export RegExp and RegExpObject functions that are needed inside WebCore's JSC bindings.
  • runtime/RegExp.cpp: (JSC::RegExpRepresentation::~RegExpRepresentation): (JSC::RegExp::RegExp): (JSC::RegExp::~RegExp): (JSC::RegExp::compile): (JSC::RegExp::match):
  • runtime/RegExp.h:

2010-09-07 Mihai Parparita <mihaip@chromium.org>

Reviewed by Oliver Hunt.

pushState and replaceState do not clone RegExp objects correctly
https://bugs.webkit.org/show_bug.cgi?id=44718

Make RegExp test of pushstate-object-types.html actually test a RegExp
value with flags.

Also adds ImageData since it can be serialized as of r54646.

  • fast/loader/stateobjects/pushstate-object-types-expected.txt:
  • fast/loader/stateobjects/pushstate-object-types.html:

2010-09-07 Mihai Parparita <mihaip@chromium.org>

Reviewed by Oliver Hunt.

pushState and replaceState do not clone RegExp objects correctly
https://bugs.webkit.org/show_bug.cgi?id=44718

Add RegExp support to the JSC implementation of SerializedScriptValue
(it stores the pattern and flags read from a RegExpObject, and creates
a new one on deserialization).

Tests: fast/loader/stateobjects/pushstate-object-types.html

  • ForwardingHeaders/runtime/RegExp.h: Added.
  • ForwardingHeaders/runtime/RegExpObject.h: Added.
  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::dumpIfTerminal): (WebCore::CloneDeserializer::readTerminal):
5:32 PM Changeset in webkit [66935] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

Fix clang++ build.

Reviewed by Oliver Hunt.

  • Misc/WebLocalizableStrings.h:

Fix a struct/tag mismatch.

  • WebView/WebDeviceOrientationProviderMock.mm:

(-[WebDeviceOrientationProviderMock init]):
Remove stray semicolon.

  • WebView/WebViewData.h:

Remove unused class forward declaration.

4:56 PM Changeset in webkit [66934] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2010-09-07 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Fix OpenGL error reporting in WebGL layout test utilities
https://bugs.webkit.org/show_bug.cgi?id=45336

  • fast/canvas/webgl/resources/webgl-test.js: (getGLErrorAsString):
4:51 PM Changeset in webkit [66933] by andersca@apple.com
  • 4 edits in trunk/WebKit2

Fix clang++ build.

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKAPICast.h:

Move all functions into the WebKit namespace.

  • UIProcess/API/C/cf/WKStringCF.cpp:

Add using namespace WebKit.

  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

Move all functions into the WebKit namespace.

4:43 PM Changeset in webkit [66932] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-07 Tony Chang <tony@chromium.org>

Unreviewed, updating chromium linux test expectations.

  • platform/chromium/drt_expectations.txt: Adding back a test removed in r66924 that is still failing.
4:40 PM WebKit Team edited by jamesr@google.com
(diff)
4:37 PM Changeset in webkit [66931] by jamesr@google.com
  • 3 edits in trunk/WebCore

2010-09-07 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

Fix compile errors in DrawingBuffer if USE(ACCELERATED_COMPOSITING) is not set
https://bugs.webkit.org/show_bug.cgi?id=45324

Adds appropriate #if guards around code that has to deal directly with the compositor.
DrawingBuffer can still be used without the compositor as an off-screen rendering
region.

To test, compile without USE(ACCELERATED_COMPOSITING).

  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::~DrawingBuffer): (WebCore::DrawingBuffer::reset):
  • platform/graphics/gpu/DrawingBuffer.h:
4:34 PM Changeset in webkit [66930] by Joseph Pecoraro
  • 3 edits
    2 adds in trunk

2010-09-07 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Provide a way to trigger a <select multiple> onchange event on changes
https://bugs.webkit.org/show_bug.cgi?id=45192

Testing the DOMHTMLSelectElement interface for selecting an
index in a <select> and triggering a "change" event. This also
tests for allowing multiple selections.

  • platform/mac/fast/objc/dom-html-select-activate-expected.txt: Added.
  • platform/mac/fast/objc/dom-html-select-activate.html: Added.

2010-09-07 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Provide a way to trigger a <select multiple> onchange event on changes
https://bugs.webkit.org/show_bug.cgi?id=45192

Adds a selector on ObjCController for testing
-[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
its different uses.

  • DumpRenderTree/mac/ObjCController.m: (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):
4:33 PM Changeset in webkit [66929] by Joseph Pecoraro
  • 7 edits in trunk/WebCore

2010-09-03 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Provide a way to trigger a <select multiple> onchange event on changes
https://bugs.webkit.org/show_bug.cgi?id=45192

Test: LayoutTests/platform/mac/fast/objc/dom-html-select-activate.html

This provides a way for a WebKit client using the Obj-C DOM bindings to
trigger the "change" on a listbox select (<select multiple> or <select>
with size > 1). This is because when a select is rendered as a listbox
"change" events are triggered by mouse down events.

This adds -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:]
to allow for handling multiple selections if the select element is a
multi-select.

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:]):
  • bindings/objc/DOMPrivate.h: unified the Category name. Was "FormsAutocomplete" now all are "FormAutocomplete".
  • dom/SelectElement.h:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndexByUser): listboxs need to be treated specially to fire their "change" event.
  • html/HTMLSelectElement.h:
  • wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::setSelectedIndexByUser):
4:28 PM Changeset in webkit [66928] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-09-07 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Minor WKCACFLayerRenderer cleanup
https://bugs.webkit.org/show_bug.cgi?id=45201

Call initD3DGeometry() from createRenderer, rather than duplicating the code.

No behavior changes.

  • platform/graphics/win/WKCACFLayerRenderer.cpp: (WebCore::WKCACFLayerRenderer::createRenderer):
4:27 PM Changeset in webkit [66927] by jamesr@google.com
  • 2 edits in trunk/WebKitTools

2010-09-07 James Robinson <jamesr@chromium.org>

Rubber-stamped by Dimitri Glazkov.

Move myself from the committer to the reviewer list.

  • Scripts/webkitpy/common/config/committers.py:
4:26 PM Changeset in webkit [66926] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-07 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] removing tests that pass after switch the bot back to hardy
https://bugs.webkit.org/show_bug.cgi?id=45327

  • platform/chromium/drt_expectations.txt:
4:19 PM Changeset in webkit [66925] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-09-07 Dimitri Glazkov <Dimitri Glazkov>

[Chromium/DRT] Remove now-passing tests.

  • platform/chromium/drt_expectations.txt: A few more tests now pass, yay!
4:10 PM Changeset in webkit [66924] by tony@chromium.org
  • 4 edits in trunk/LayoutTests

2010-09-07 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

turn off php output buffering in multipart tests
https://bugs.webkit.org/show_bug.cgi?id=45232

This was causing hanging multipart resources to not output anything.
On Lucid, the output buffer is enabled by default, but it's not enabled on Hardy.
http://www.php.net/manual/en/function.ob-end-flush.php

  • http/tests/multipart/resources/multipart-wait-before-boundary.php:
  • http/tests/multipart/resources/multipart.php:
  • platform/chromium/drt_expectations.txt:
4:05 PM Changeset in webkit [66923] by vangelis@chromium.org
  • 2 edits in trunk/WebCore

2010-09-07 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Darin Fisher.

[chromium] Reset the owner of PlatformLayer's once the GraphicsLayer they are associated with
gets destroyed.
https://bugs.webkit.org/show_bug.cgi?id=45329

Test: Fixes UI test failures downstream for all the Media tests when run on the buildbots (machines without GPUs).

  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
4:03 PM Changeset in webkit [66922] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-07 Zhenyao Mo <zmo@google.com>

Unreviewed.

Add fast/canvas/webgl/gl-teximage.html (failing on chromium mac bot) to chromium/test_expectations.

  • platform/chromium/test_expectations.txt:
3:46 PM Changeset in webkit [66921] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-09-07 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, trivial expectations update.

[Chromium/DRT] Remove expectation of crash for
fast/js/date-preserve-milliseconds.html. It's now passing.

  • platform/chromium/drt_expectations.txt: Remove now-passing test.
3:43 PM Changeset in webkit [66920] by crogers@google.com
  • 21 edits in branches/audio/WebCore

audio branch: more code cleanup in preparation for landing in trunk

3:43 PM Changeset in webkit [66919] by crogers@google.com
  • 28 edits in branches/audio/WebCore

audio branch: massive munge to use adoptPtr() instead of naked operator new

3:42 PM Changeset in webkit [66918] by abarth@webkit.org
  • 3 edits in trunk/BugsSite

2010-09-07 Adam Barth <abarth@webkit.org>

Minor tweaks to the reviewtool UI.

Rename Cancel to Discard to make it more clear what the button does.
Also, move the style declaration for the focus ring later in the sheet
so it works.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
3:37 PM Changeset in webkit [66917] by Dimitri Glazkov
  • 3 edits
    2 deletes in trunk/LayoutTests

2010-09-07 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, trivial test move.

[Chromium/DRT] Correct a mistake made eons ago (probably by me)
and make the test expectations agnostic to the flavor of Windows.

  • platform/chromium-win-xp/fast/multicol/client-rects-expected.checksum: Removed.
  • platform/chromium-win-xp/fast/multicol/client-rects-expected.png: Removed.
  • platform/chromium-win/fast/multicol/client-rects-expected.checksum: Updated.
  • platform/chromium-win/fast/multicol/client-rects-expected.png: Updated.
3:35 PM Changeset in webkit [66916] by andersca@apple.com
  • 10 edits in trunk

<rdar://problem/8381749> -Wcast-align warning emitted when building with clang

Reviewed by Darin Adler.

JavaScriptCore:

Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.

  • Configurations/Base.xcconfig:

JavaScriptGlue:

Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.

  • Configurations/Base.xcconfig:

WebCore:

Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.

  • Configurations/Base.xcconfig:

WebKit/mac:

Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.

  • Configurations/Base.xcconfig:

WebKit2:

Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.

  • Configurations/Base.xcconfig:
3:21 PM Changeset in webkit [66915] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-07 Zhenyao Mo <zmo@google.com>

Unreviewed.

Remove passing tests from chromium/test_expectations.

  • platform/chromium/test_expectations.txt:
3:21 PM Changeset in webkit [66914] by tony@chromium.org
  • 5 edits in trunk

2010-09-07 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] Make a public flag for how DRT generates bitmaps on Linux
https://bugs.webkit.org/show_bug.cgi?id=45133

This is so it's possible for me to fix
http://code.google.com/p/chromium/issues/detail?id=21386 .

  • public/WebKit.h: Add areLayoutTestImagesOpaque()
  • src/WebKit.cpp: (WebKit::areLayoutTestImagesOpaque):

2010-09-07 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] Make a public flag for how DRT generates bitmaps on Linux
https://bugs.webkit.org/show_bug.cgi?id=45133

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::dumpImage):
3:08 PM Changeset in webkit [66913] by Dimitri Glazkov
  • 1 copy in branches/chromium/517

Create branch for Chromium 517.

3:07 PM Changeset in webkit [66912] by Dimitri Glazkov
  • 1 add in branches/chromium

Create a directory for Chromium branches

2:57 PM Changeset in webkit [66911] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-09-07 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Adler.

Remove redundant bounds check in originalText(). Add bounds check
to previousCharacter(). No need of start() > 0 check since m_start
is unsigned and we already do start() null check inside function.
https://bugs.webkit.org/show_bug.cgi?id=45303

Test: fast/text/one-letter-transform-crash.html

  • rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::originalText): (WebCore::RenderTextFragment::previousCharacter):

2010-09-07 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Adler.

Tests that we dont hit assert i < m_length when trying to read
previousCharacter for text fragments.
https://bugs.webkit.org/show_bug.cgi?id=45303

  • fast/text/one-letter-transform-crash-expected.txt: Added.
  • fast/text/one-letter-transform-crash.html: Added.
2:53 PM Changeset in webkit [66910] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-07 Zhenyao Mo <zmo@google.com>

Unreviewed.

Remove passing tests from chromium/test_expectations.

  • platform/chromium/test_expectations.txt:
2:50 PM Changeset in webkit [66909] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-09-07 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Levin.

Remove flakiness expectation for tests, fixed by r66861.
https://bugs.webkit.org/show_bug.cgi?id=45311

  • platform/chromium/drt_expectations.txt: Removed tests.
2:24 PM Changeset in webkit [66908] by kbr@google.com
  • 5 edits
    1 add in trunk

2010-09-07 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Regression in JPEG texture uploads on Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=45316

Fixed regression introduced in
https://bugs.webkit.org/show_bug.cgi?id=44566 . Added regression
test covering this case to gl-teximage.html in Khronos repository
and synced test with WebKit's version.

  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):

2010-09-07 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Regression in JPEG texture uploads on Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=45316

Fixed regression introduced in
https://bugs.webkit.org/show_bug.cgi?id=44566 . Added regression
test covering this case to gl-teximage.html in Khronos repository
and synced test with WebKit's version.

  • fast/canvas/webgl/gl-teximage-expected.txt:
  • fast/canvas/webgl/gl-teximage.html:
  • fast/canvas/webgl/resources/blue-1x1.jpg: Added.
2:07 PM Changeset in webkit [66907] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Another windows fix.

  • UIProcess/win/WebView.cpp:
2:00 PM Changeset in webkit [66906] by tkent@chromium.org
  • 6 edits in trunk/WebKitTools

2010-09-07 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Implement --check-layout-test-sys-deps
https://bugs.webkit.org/show_bug.cgi?id=45283

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main): Check --check-layout-test-sys-deps and call checkLayoutTestSystemDependencies().
  • DumpRenderTree/chromium/TestShell.h: Declare checkLayoutTestSystemDependencies().
  • DumpRenderTree/chromium/TestShellGtk.cpp: (checkLayoutTestSystemDependencies): Add an empty implementation.
  • DumpRenderTree/chromium/TestShellMac.mm: (checkLayoutTestSystemDependencies): Add an empty implementation.
  • DumpRenderTree/chromium/TestShellWin.cpp: (checkLayoutTestSystemDependencies): Port similar function of test_shell.
1:59 PM Changeset in webkit [66905] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Try and fix windows.

  • UIProcess/WebEditCommandProxy.h:
1:18 PM Changeset in webkit [66904] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-09-07 Martin Robinson <mrobinson@igalia.com>

Add rendering/ColumnInfo.h to the sources list.

  • GNUmakefile.am:
1:07 PM BuildBot edited by tony@chromium.org
(diff)
12:59 PM Changeset in webkit [66903] by hyatt@apple.com
  • 5 edits
    1 add in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=45317, encapsulate multi-column rectangle information.

Reviewed by Beth Dakin.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/ColumnInfo.h: Added.

(WebCore::ColumnInfo::ColumnInfo):
(WebCore::ColumnInfo::desiredColumnWidth):
(WebCore::ColumnInfo::setDesiredColumnWidth):
(WebCore::ColumnInfo::desiredColumnCount):
(WebCore::ColumnInfo::setDesiredColumnCount):
(WebCore::ColumnInfo::columnCount):
(WebCore::ColumnInfo::columnRectAt):
(WebCore::ColumnInfo::clearColumns):
(WebCore::ColumnInfo::addColumnRect):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::lowestPosition):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::RenderBlock::setDesiredColumnCountAndWidth):
(WebCore::RenderBlock::desiredColumnWidth):
(WebCore::RenderBlock::desiredColumnCount):
(WebCore::RenderBlock::columnInfo):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::adjustForColumns):

  • rendering/RenderBlock.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintChildLayerIntoColumns):
(WebCore::RenderLayer::hitTestChildLayerColumns):

12:56 PM Changeset in webkit [66902] by bfulgham@webkit.org
  • 3 edits in trunk/WebKit/win

2010-09-07 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Clean up a potential resource leak.
https://bugs.webkit.org/show_bug.cgi?id=45198

Several bitmap device context were being created and used,
and destroyed without returning the context to its original
state. This showed up as bitmap leaks in BoundsChecker.

  • FullscreenVideoController.cpp:
  • WebView.cpp: (WebView::scrollBackingStore): (WebView::paint):
12:44 PM BuildBot edited by tony@chromium.org
(diff)
12:41 PM Changeset in webkit [66901] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix incorrect parameter name.

Reviewed by Darin Adler.

  • UIProcess/API/mac/PageClientImpl.mm:
12:40 PM Changeset in webkit [66900] by mitz@apple.com
  • 4 edits
    2 adds in trunk

<rdar://problem/7794761> Floats inside of multicol fail to hit test
https://bugs.webkit.org/show_bug.cgi?id=44730

Reviewed by Dave Hyatt.

WebCore:

Test: fast/multicol/hit-test-float.html

Factored float hit-testing out of nodeAtPoint so that hitTestColumns could
call it with column-adjusted coordinates.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::hitTestColumns):

  • rendering/RenderBlock.h:

LayoutTests:

  • fast/multicol/hit-test-float-expected.txt: Added.
  • fast/multicol/hit-test-float.html: Added.
12:31 PM Changeset in webkit [66899] by commit-queue@webkit.org
  • 7 edits in trunk

2010-09-07 François Sausset <François Sausset>

Reviewed by Beth Dakin.

Update to test the display attribute on the math element.
https://bugs.webkit.org/show_bug.cgi?id=44206

  • mathml/presentation/attributes.xhtml:
  • platform/mac/mathml/presentation/attributes-expected.checksum:
  • platform/mac/mathml/presentation/attributes-expected.png:
  • platform/mac/mathml/presentation/attributes-expected.txt:

2010-09-07 François Sausset <François Sausset>

Reviewed by Beth Dakin.

<math> element should be centered when display attribute set to block.
https://bugs.webkit.org/show_bug.cgi?id=44206

Test: mathml/presentation/attributes.xhtml

  • css/mathml.css: (math[display="block"]):
12:21 PM Changeset in webkit [66898] by jberlin@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-07 Jessie Berlin <jberlin@apple.com>

Unreviewed. Mac build fix.

  • MiniBrowser/mac/WebBundle/WebBundleMain.m: (didClearWindowObjectForFrame):
12:18 PM Changeset in webkit [66897] by weinig@apple.com
  • 18 edits
    4 adds in trunk/WebKit2

Add support for Undo/Redo
<rdar://problem/7660519>
https://bugs.webkit.org/show_bug.cgi?id=42781

Reviewed by Darin Adler.

Adds platform independent parts of Undo/Redo support and the mac
platform support.

To work around the common assumption made by platforms, that a redo
item will be added synchronously while an undo is in progress, we
ignore the calls from WebCore to add redo items, and instead add add
them after telling WebCore to unapply the EditCommand. We similarly
need to ignore undos, that take place during a redo, and force the
addition ourselves.

  • Shared/CoreIPCSupport/WebPageMessageKinds.h:
  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:

Add new messages.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(-[WebEditCommandObjC initWithWebEditCommandProxy:WebKit::]):
(-[WebEditCommandObjC WebKit::]):
(-[WebEditorUndoTargetObjC undoEditing:]):
(-[WebEditorUndoTargetObjC redoEditing:]):
(WebKit::PageClientImpl::PageClientImpl):
(WebKit::nameForEditAction):
(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::clearAllEditCommands):

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::registerEditCommand):
(QWKPagePrivate::clearAllEditCommands):

  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::registerEditCommand):
(WebKit::WebView::clearAllEditCommands):

  • UIProcess/win/WebView.h:

Add platform specific hooks for undo/redo.

  • UIProcess/WebEditCommandProxy.cpp: Added.

(WebKit::WebEditCommandProxy::WebEditCommandProxy):
(WebKit::WebEditCommandProxy::~WebEditCommandProxy):
(WebKit::WebEditCommandProxy::unapply):
(WebKit::WebEditCommandProxy::reapply):

  • UIProcess/WebEditCommandProxy.h: Added.

(WebKit::WebEditCommandProxy::create):
(WebKit::WebEditCommandProxy::commandID):
(WebKit::WebEditCommandProxy::editAction):
(WebKit::WebEditCommandProxy::invalidate):
A proxy for the WebEditCommands in the WebProcess. These are owned
by the platform back/forward list, with a weak reference back to the
WebPageProxy (which holds a weakset of live WebEditCommandProxys).

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::registerEditCommandForUndo):
(WebKit::WebPageProxy::clearAllEditCommands):
(WebKit::WebPageProxy::registerEditCommandForRedo):
(WebKit::WebPageProxy::addEditCommand):
(WebKit::WebPageProxy::removeEditCommand):
(WebKit::WebPageProxy::processDidExit):

  • UIProcess/WebPageProxy.h:

Forward messages.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::registerCommandForUndo):
(WebKit::WebEditorClient::registerCommandForRedo):
(WebKit::WebEditorClient::clearUndoRedoOperations):
Send undo/redo registration and clearing to the UIProcess.

  • WebProcess/WebPage/WebEditCommand.cpp: Added.

(WebKit::generateCommandID):
(WebKit::WebEditCommand::WebEditCommand):

  • WebProcess/WebPage/WebEditCommand.h: Added.

(WebKit::WebEditCommand::create):
(WebKit::WebEditCommand::command):
(WebKit::WebEditCommand::commandID):
Wrapper for WebCore::EditCommand, with an added unique ID.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::webEditCommand):
(WebKit::WebPage::addWebEditCommand):
(WebKit::WebPage::removeWebEditCommand):
(WebKit::WebPage::unapplyEditCommand):
(WebKit::WebPage::reapplyEditCommand):
(WebKit::WebPage::didRemoveEditCommand):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::isInRedo):
Forward messages.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add new files.

11:46 AM Changeset in webkit [66896] by Simon Fraser
  • 17 edits in trunk/LayoutTests

2010-09-07 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Avoid use of CA plugin in compositing tests so that they work on Windows
https://bugs.webkit.org/show_bug.cgi?id=45312

Convert tests to use <video> rather than a plugin, so that they have similar
compositing behavior on Windows.

  • compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
  • compositing/geometry/limit-layer-bounds-clipping-ancestor.html:
  • compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-fixed-positioned.html:
  • compositing/geometry/limit-layer-bounds-overflow-repaint.html:
  • compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • compositing/geometry/limit-layer-bounds-overflow-root.html:
  • compositing/geometry/limit-layer-bounds-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-transition.html:
  • compositing/geometry/limit-layer-bounds-positioned.html:
  • compositing/geometry/limit-layer-bounds-transformed-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-overflow.html:
  • compositing/geometry/limit-layer-bounds-transformed.html:
  • platform/mac/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt:
11:29 AM Changeset in webkit [66895] by eric.carlson@apple.com
  • 3 edits in trunk/WebCore

2010-09-07 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Media elements should derive from ActiveDOMObjects
https://bugs.webkit.org/show_bug.cgi?id=45306
<rdar://problem/7929062>

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize ActiveDOMObject (WebCore::HTMLMediaElement::stop): Call suspend, we want to do the same thing in both cases. (WebCore::HTMLMediaElement::suspend): Rename from documentWillBecomeInactive. (WebCore::HTMLMediaElement::resume): Rename from documentDidBecomeActive. (WebCore::HTMLMediaElement::hasPendingActivity): Return true if the event queue is not empty so the element can't be collected before they are sent.
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::canSuspend):
11:14 AM ImprovingLifeOnWindows edited by Adam Roben
Removed the item about copying to %TMP%, since we don't do that anymore. (diff)
11:09 AM Changeset in webkit [66894] by jberlin@webkit.org
  • 8 edits in trunk

2010-09-07 Jessie Berlin <jberlin@apple.com>

Reviewed by Darin Adler.

Indicate which one of the ScriptWorlds for a Frame the Window Object has been cleared for
https://bugs.webkit.org/show_bug.cgi?id=45217

WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp: (WebKit::InjectedBundlePageLoaderClient::didClearWindowObjectForFrame):
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):

WebKitTools:

Make WebKitTestRunner work with this change.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame): Make sure the ScriptWorld here is the normal world, since that is no longer being done in WebFrameLoaderClient.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
11:02 AM Changeset in webkit [66893] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-07 Zhenyao Mo <zmo@google.com>

Unreviewed.

Add fast/text/atsui-spacing-features.html to test_expectations (failing on LINUX).

  • platform/chromium/test_expectations.txt:
10:38 AM Changeset in webkit [66892] by Dimitri Glazkov
  • 7 edits in trunk

2010-09-07 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r66886.
http://trac.webkit.org/changeset/66886
https://bugs.webkit.org/show_bug.cgi?id=45112

Made

  • platform/chromium/GeolocationServiceChromium.cpp:
  • platform/chromium/GeolocationServiceChromium.h:

2010-09-07 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r66886.
http://trac.webkit.org/changeset/66886
https://bugs.webkit.org/show_bug.cgi?id=45112

Made

  • public/WebGeolocationService.h:
  • src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::~WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::startUpdating): (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating): (WebKit::WebGeolocationServiceBridgeImpl::suspend): (WebKit::WebGeolocationServiceBridgeImpl::resume): (WebKit::WebGeolocationServiceBridgeImpl::attachBridgeIfNeeded): (WebKit::WebGeolocationServiceBridgeImpl::setIsAllowed): (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition): (WebKit::WebGeolocationServiceBridgeImpl::setLastError): (WebKit::WebGeolocationServiceBridgeImpl::getWebViewClient): (WebKit::WebGeolocationServiceBridgeImpl::onWebGeolocationServiceDestroyed):
  • src/WebGeolocationServiceMock.cpp:
10:22 AM Changeset in webkit [66891] by zmo@google.com
  • 1 edit
    24 adds in trunk/LayoutTests

2010-09-07 Zhenyao Mo <zmo@google.com>

Unreviewed.

Rebaseline WIN LINUX for a few svg/dynamic-updates tests.

  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png: Added.
10:13 AM Changeset in webkit [66890] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-09-07 Martin Robinson <mrobinson@igalia.com>

Small build fix. Remove libWebCoreJS from CLEAN_FILES, as it
is no longer built.

  • GNUmakefile.am: Remove reference to libWebCoreJS.
10:10 AM Changeset in webkit [66889] by Martin Robinson
  • 1 edit in trunk/WebCore/ChangeLog

2010-09-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [REGRESSION] r66848 caused a crash in testwebview
https://bugs.webkit.org/show_bug.cgi?id=45298

No new tests as this fixes a test failure.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setGtkAdjustments): Don't actually attach the scrollbar adjustments unless this is a main frame ScrollView. If we do Scrollbars will be cast incorrectly to MainFrameScrollbarGtk, causing a segfault.
9:44 AM Changeset in webkit [66888] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-07 Kristian Monsen <kristianm@google.com>

Reviewed by Steve Block.

Compile fix for Android.
https://bugs.webkit.org/show_bug.cgi?id=45292
Explicitly add needed header for
STRING_TO_V8PARAMETER_EXCEPTION_BLOCK as they do not get
included through other headers on Android.

No new tests, just a compile fix.

  • bindings/scripts/CodeGeneratorV8.pm:
9:40 AM Changeset in webkit [66887] by Martin Robinson
  • 23 edits in trunk

2010-09-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix some feature guards
https://bugs.webkit.org/show_bug.cgi?id=45302

No new tests as this is just a build change.

  • platform/graphics/gstreamer/DataSourceGStreamer.cpp: Guard with #if ENABLE(VIDEO)
  • platform/graphics/gstreamer/DataSourceGStreamer.h: Ditto.
  • platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: Ditto.
  • platform/graphics/gstreamer/GOwnPtrGStreamer.h: Ditto.
  • platform/graphics/gstreamer/GStreamerGWorld.cpp: Ditto.
  • platform/graphics/gstreamer/GStreamerGWorld.h: Ditto.
  • platform/graphics/gstreamer/ImageGStreamer.h: Ditto.
  • platform/graphics/gstreamer/ImageGStreamerCG.mm: Ditto.
  • platform/graphics/gstreamer/ImageGStreamerCairo.cpp: Ditto.
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Ditto.
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Ditto.
  • platform/graphics/gstreamer/PlatformVideoWindow.h: Ditto.
  • platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp: Ditto.
  • platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp: Ditto.
  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp: Ditto.
  • platform/graphics/gstreamer/VideoSinkGStreamer.h: Ditto.
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: Ditto.
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.h: Ditto.
  • platform/gtk/GeolocationServiceGtk.cpp: Guard with ENABLE(GEOLOCATION)
  • platform/gtk/GeolocationServiceGtk.h: Ditto.

2010-09-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix some feature guards
https://bugs.webkit.org/show_bug.cgi?id=45302

  • webkit/webkitprivate.h: Add ENABLE(VIDEO) guards for video specific members.
9:02 AM Changeset in webkit [66886] by jorlow@chromium.org
  • 7 edits in trunk

2010-09-07 Jonathan Dixon <joth@chromium.org>

Reviewed by Jeremy Orlow.

Access to out-of-scope WebGeolocationServiceBridgeImpl
https://bugs.webkit.org/show_bug.cgi?id=45112

Add missing virtual destructor to the abstract base class.

  • platform/chromium/GeolocationServiceChromium.cpp: (WebCore::GeolocationServiceBridge::~GeolocationServiceBridge):
  • platform/chromium/GeolocationServiceChromium.h:

2010-09-07 Jonathan Dixon <joth@chromium.org>

Reviewed by Jeremy Orlow.

Access to out-of-scope WebGeolocationServiceBridgeImpl
https://bugs.webkit.org/show_bug.cgi?id=45112

Keep the WebGeolocationService pointer for lifetime of the bridge, to
ensure it can be detached reliably

  • public/WebGeolocationServiceBridge.h: (WebKit::WebGeolocationServiceBridge::~WebGeolocationServiceBridge):
  • src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::~WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::startUpdating): (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating): (WebKit::WebGeolocationServiceBridgeImpl::suspend): (WebKit::WebGeolocationServiceBridgeImpl::resume): (WebKit::WebGeolocationServiceBridgeImpl::attachBridgeIfNeeded):
8:55 AM Changeset in webkit [66885] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-09-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [REGRESSION] r66848 caused a crash in testwebview
https://bugs.webkit.org/show_bug.cgi?id=45298

No new tests as this fixes a test failure.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setGtkAdjustments): Don't actually attach the scrollbar adjustments unless this is a main frame ScrollView. If we do Scrollbars will be cast incorrectly to MainFrameScrollbarGtk, causing a segfault.
8:55 AM Changeset in webkit [66884] by satish@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-07 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Disable a timing out speech input test for generated clicks.
https://bugs.webkit.org/show_bug.cgi?id=45297

  • platform/chromium/test_expectations.txt:
8:15 AM Changeset in webkit [66883] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-07 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Darin Adler.

REGRESSION(66741): Undefined pthread macros
https://bugs.webkit.org/show_bug.cgi?id=45246

PTHREAD_MUTEX_NORMAL and PTHREAD_MUTEX_DEFAULT (introduced in r60487) are not defined on Linux,
but used in a statement. Add an additional check to test this.

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::initializeScavenger):
7:53 AM Changeset in webkit [66882] by agl@chromium.org
  • 3 edits in trunk

2010-09-07 Adam Langley <agl@chromium.org>

Reviewed by Tony Chang.

[chromium] Fix complex text word spacing on Linux.

I broke complex text word spacing with r66689. I misnamed a
variable in the original code |glyphIndex| when it was
actually indexing code points. That meant that I compared it
against the wrong limit when working around Harfbuzz issues
and neatly disabled word spacing.

https://bugs.webkit.org/show_bug.cgi?id=45191

Test: fast/text/atsui-spacing-features.html

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::setGlyphXPositions):
7:07 AM Changeset in webkit [66881] by commit-queue@webkit.org
  • 1 edit
    30 adds in trunk/LayoutTests

2010-09-07 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

SVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=42244

Adding layout tests for fePointLight dynamic changes.
feSpotLight svgAttributeChanged covered the pointLight case as well so we don't need new C++ code.

  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr.html: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr.html: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr.html: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop.html: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop.html: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFEPointLightElement-dom-x-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEPointLightElement-dom-y-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEPointLightElement-dom-z-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEPointLightElement-svgdom-x-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEPointLightElement-svgdom-y-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEPointLightElement-svgdom-z-prop.js: Added. (executeTest):
6:44 AM Changeset in webkit [66880] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

2010-09-07 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: disable debugger tests on qt
https://bugs.webkit.org/show_bug.cgi?id=45290

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
6:27 AM Changeset in webkit [66879] by satish@chromium.org
  • 4 edits
    1 delete in trunk

2010-09-07 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Fix speech button's hit test logic for RTL rendering.
https://bugs.webkit.org/show_bug.cgi?id=45288

  • fast/speech/input-text-speechbutton.html: Added RTL test case and merged JS code.
  • fast/speech/script-tests/input-text-speechbutton.js: Removed.

2010-09-07 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Fix speech button's hit test logic for RTL rendering.
https://bugs.webkit.org/show_bug.cgi?id=45288

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::forwardEvent):
5:47 AM Changeset in webkit [66878] by satish@chromium.org
  • 3 edits
    2 adds in trunk

2010-09-07 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Ignore programmatic clicks on speech input button for security reasons.
https://bugs.webkit.org/show_bug.cgi?id=45181

  • fast/speech/speech-button-ignore-generated-events-expected.txt: Added.
  • fast/speech/speech-button-ignore-generated-events.html: Added.

2010-09-07 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Ignore programmatic clicks on speech input button for security reasons.
https://bugs.webkit.org/show_bug.cgi?id=45181

Test: fast/speech/speech-button-ignore-generated-events.html

  • rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
5:28 AM Changeset in webkit [66877] by commit-queue@webkit.org
  • 3 edits
    5 adds in trunk

2010-09-07 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: upstream two debugger tests
https://bugs.webkit.org/show_bug.cgi?id=45262

  • inspector/debugger-pause-on-breakpoint-expected.txt: Added.
  • inspector/debugger-pause-on-breakpoint.html: Added.
  • inspector/debugger-pause-on-exception-expected.txt: Added.
  • inspector/debugger-pause-on-exception.html: Added.
  • platform/chromium/inspector/debugger-pause-on-exception-expected.txt: Added.

2010-09-07 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: upstream two debugger tests
https://bugs.webkit.org/show_bug.cgi?id=45262

  • src/js/Tests.js:
5:11 AM Changeset in webkit [66876] by steveblock@google.com
  • 5 edits
    15 adds in trunk/LayoutTests

2010-09-07 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Provide DeviceOrientation LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=39590

Adds several new DeviceOrientation tests. Also fixes some style in existing tests.

  • fast/dom/DeviceOrientation/add-listener-from-callback.html: Added.
  • fast/dom/DeviceOrientation/script-tests/add-listener-from-callback.js: Added.
  • fast/dom/DeviceOrientation/add-listener-from-callback-expected.txt: Added.
  • fast/dom/DeviceOrientation/multiple-frames.html: Added.
  • fast/dom/DeviceOrientation/script-tests/multiple-frames.js: Added.
  • fast/dom/DeviceOrientation/multiple-frames-expected.txt: Added.
  • fast/dom/DeviceOrientation/no-synchronous-events.html: Added.
  • fast/dom/DeviceOrientation/script-tests/no-synchronous-events.js: Added.
  • fast/dom/DeviceOrientation/no-synchronous-events-expected.txt: Added.
  • fast/dom/DeviceOrientation/null-values.html: Added.
  • fast/dom/DeviceOrientation/script-tests/null-values.js: Added.
  • fast/dom/DeviceOrientation/null-values-expected.txt: Added.
  • fast/dom/DeviceOrientation/updates.html: Added.
  • fast/dom/DeviceOrientation/script-tests/updates.js: Added.
  • fast/dom/DeviceOrientation/updates-expected.txt: Added.
  • fast/dom/DeviceOrientation/script-tests/basic-operation.js:
  • fast/dom/DeviceOrientation/script-tests/create-event.js:
  • fast/dom/DeviceOrientation/script-tests/optional-event-properties.js:
  • fast/dom/DeviceOrientation/script-tests/window-property.js:
4:14 AM Changeset in webkit [66875] by kent.hansen@nokia.com
  • 2 edits in trunk/WebCore

2010-09-07 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::connectAndDisconnect() fails on WebKit trunk because qt_sender is never set
https://bugs.webkit.org/show_bug.cgi?id=44697

When the signal handler is a JS function, qt_sender is stuffed into a temporary
object that's pushed onto the function's scope before the function is invoked, and
popped again afterwards.

We were pushing this new scope object _after_ calling JSFunction::getCallData(),
and relying on JSC::call() to use the fresh scope chain from the function object.
However, this is no longer the case; JSC::call() uses the scope chain passed in
the CallData argument. Hence, we need to set up the scope before the function's
CallData is queried.

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtConnectionObject::execute):
3:22 AM Changeset in webkit [66874] by Csaba Osztrogonác
  • 1 edit
    78 adds in trunk/LayoutTests

[Qt] Add platform specific expected results for new passing tests.
Compared to Mac png files and Mac expected files.

  • platform/qt/fast/css/percent-top-relative-container-height-unspecified-expected.checksum: Added.
  • platform/qt/fast/css/percent-top-relative-container-height-unspecified-expected.png: Added.
  • platform/qt/fast/css/percent-top-relative-container-height-unspecified-expected.txt: Added.
  • platform/qt/fast/forms/placeholder-stripped-expected.checksum: Added.
  • platform/qt/fast/forms/placeholder-stripped-expected.png: Added.
  • platform/qt/fast/forms/placeholder-stripped-expected.txt: Added.
  • platform/qt/fast/gradients/radial-centered-expected.checksum: Added.
  • platform/qt/fast/gradients/radial-centered-expected.png: Added.
  • platform/qt/fast/gradients/radial-centered-expected.txt: Added.
  • platform/qt/fast/multicol/float-paginate-expected.checksum: Added.
  • platform/qt/fast/multicol/float-paginate-expected.png: Added.
  • platform/qt/fast/multicol/float-paginate-expected.txt: Added.
  • platform/qt/fast/multicol/paginate-block-replaced-expected.checksum: Added.
  • platform/qt/fast/multicol/paginate-block-replaced-expected.png: Added.
  • platform/qt/fast/multicol/paginate-block-replaced-expected.txt: Added.
  • platform/qt/fast/repaint/multicol-repaint-expected.checksum: Added.
  • platform/qt/fast/repaint/multicol-repaint-expected.png: Added.
  • platform/qt/fast/repaint/multicol-repaint-expected.txt: Added.
  • platform/qt/fast/repaint/view-background-from-body-1-expected.checksum: Copied from LayoutTests/platform/mac/fast/repaint/view-background-from-body-1-expected.checksum.
  • platform/qt/fast/repaint/view-background-from-body-1-expected.png: Copied from LayoutTests/platform/qt/svg/custom/use-property-synchronization-crash-expected.png.
  • platform/qt/fast/repaint/view-background-from-body-1-expected.txt: Copied from LayoutTests/platform/gtk/fast/repaint/view-background-from-body-1-expected.txt.
  • platform/qt/fast/repaint/view-background-from-body-2-expected.checksum: Copied from LayoutTests/platform/mac/fast/repaint/view-background-from-body-2-expected.checksum.
  • platform/qt/fast/repaint/view-background-from-body-2-expected.png: Added.
  • platform/qt/fast/repaint/view-background-from-body-2-expected.txt: Copied from LayoutTests/platform/gtk/fast/repaint/view-background-from-body-2-expected.txt.
  • platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.checksum: Added.
  • platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.png: Added.
  • platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
  • platform/qt/svg/css/composite-shadow-text-expected.checksum: Added.
  • platform/qt/svg/css/composite-shadow-text-expected.png: Added.
  • platform/qt/svg/css/composite-shadow-text-expected.txt: Added.
  • platform/qt/svg/custom/bug45331-expected.checksum: Added.
  • platform/qt/svg/custom/bug45331-expected.png: Added.
  • platform/qt/svg/custom/bug45331-expected.txt: Added.
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.checksum: Added.
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.png: Added.
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt: Added.
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.checksum: Added.
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png: Added.
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt: Added.
  • platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.checksum: Added.
  • platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Added.
  • platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt: Added.
  • platform/qt/svg/custom/marker-empty-path-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/marker-empty-path-expected.checksum.
  • platform/qt/svg/custom/marker-empty-path-expected.png: Added.
  • platform/qt/svg/custom/marker-empty-path-expected.txt: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-container-expected.checksum: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-container-expected.png: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-container-expected.txt: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-root-expected.checksum: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-root-expected.png: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added.
  • platform/qt/svg/custom/non-scaling-stroke-markers-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/non-scaling-stroke-markers-expected.checksum.
  • platform/qt/svg/custom/non-scaling-stroke-markers-expected.png: Added.
  • platform/qt/svg/custom/non-scaling-stroke-markers-expected.txt: Added.
  • platform/qt/svg/custom/pattern-incorrect-tiling-expected.checksum: Added.
  • platform/qt/svg/custom/pattern-incorrect-tiling-expected.png: Added.
  • platform/qt/svg/custom/pattern-incorrect-tiling-expected.txt: Added.
  • platform/qt/svg/custom/pattern-no-pixelation-expected.checksum: Added.
  • platform/qt/svg/custom/pattern-no-pixelation-expected.png: Added.
  • platform/qt/svg/custom/pattern-no-pixelation-expected.txt: Added.
  • platform/qt/svg/custom/use-font-face-crash-expected.checksum: Added.
  • platform/qt/svg/custom/use-font-face-crash-expected.png: Added.
  • platform/qt/svg/custom/use-font-face-crash-expected.txt: Added.
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.checksum: Added.
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
  • platform/qt/transitions/svg-text-shadow-transition-expected.checksum: Added.
  • platform/qt/transitions/svg-text-shadow-transition-expected.png: Added.
  • platform/qt/transitions/svg-text-shadow-transition-expected.txt: Added.
3:12 AM Changeset in webkit [66873] by Philippe Normand
  • 2 edits in trunk/WebKitTools

2010-09-07 Philippe Normand <pnormand@igalia.com>

Unreviewed, build fix.

webkit-patch command to find the ports covering a specific layout test
https://bugs.webkit.org/show_bug.cgi?id=42832

  • Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the tests are present when building the expectations. This is needed for the unittests.
2:53 AM Changeset in webkit [66872] by Philippe Normand
  • 14 edits in trunk/WebKitTools

2010-09-06 Philippe Normand <pnormand@igalia.com>

Reviewed by Adam Barth.

webkit-patch command to find the ports covering a specific layout test
https://bugs.webkit.org/show_bug.cgi?id=42832

To use it: webkit-patch skipped-ports some/layout/test.html

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/queries_unittest.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/mocktool.py:
2:20 AM Changeset in webkit [66871] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-07 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Remove a duplicated entry.
2:12 AM Changeset in webkit [66870] by commit-queue@webkit.org
  • 2 edits in trunk

2010-09-07 Arno Renevier <arno@renevier.net>

Reviewed by Holger Freyther.

gitignore *~ files and gtk *.pot files
https://bugs.webkit.org/show_bug.cgi?id=45129

  • .gitignore:
1:51 AM Changeset in webkit [66869] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-07 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

Add ENABLE(INSPECTOR) guard in InspectorController::inspectorControllerForNode
https://bugs.webkit.org/show_bug.cgi?id=45272

Build fix.

  • inspector/InspectorController.h: (WebCore::InspectorController::inspectorControllerForNode):
1:50 AM Changeset in webkit [66868] by ukai@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed. Build fix.

Update test expectations for Chromium.

  • platform/chromium-linux/svg/custom/use-invalid-pattern-expected.txt: Added.
  • platform/chromium-mac/svg/custom/use-invalid-pattern-expected.txt: Added.
  • platform/chromium-win/svg/custom/use-invalid-pattern-expected.txt: Added.
1:38 AM Changeset in webkit [66867] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

2010-09-07 Kent Tamura <tkent@chromium.org>

Reviewed by Ojan Vafai.

Fix wrong position calculation of fast/forms/listbox-selection.html
https://bugs.webkit.org/show_bug.cgi?id=45285

  • fast/forms/script-tests/listbox-selection.js: (mouseDownOnSelect): Refer window.pageYOffset after sl.focus() call because focus() might scroll the page.
  • platform/chromium/test_expectations.txt:
1:35 AM Changeset in webkit [66866] by tkent@chromium.org
  • 4 edits in trunk/LayoutTests

2010-09-07 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Update DRT/Chromium expectations, and skip meter-percent-size.html
for platforms without <meter> support.

  • platform/chromium/drt_expectations.txt:
  • platform/gtk/Skipped:
  • platform/win/Skipped:
1:28 AM Changeset in webkit [66865] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-07 Joerg Bornemann <joerg.bornemann@nokia.com>

Reviewed by Ariya Hidayat.

Fix QtWebKit linker error on Windows CE 6.
https://bugs.webkit.org/show_bug.cgi?id=43442

Doesn't affect any tests.

  • WebCore.pro:
1:12 AM Changeset in webkit [66864] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2010-09-07 James Kozianski <koz@chromium.org>

Reviewed by Kent Tamura.

Adds tests for percent-based attributes on the <meter> element.

  • fast/dom/HTMLMeterElement/meter-percent-size-expected.txt: Added.
  • fast/dom/HTMLMeterElement/meter-percent-size.html: Added.

2010-09-07 James Kozianski <koz@chromium.org>

Reviewed by Kent Tamura.

Crash rendering <meter/> with percent padding
https://bugs.webkit.org/show_bug.cgi?id=45081

Avoids a crash caused by RenderMeter checking its own dimensions to
determine whether it needs layout. The crash is avoided by removing
the check and always calling setNeedsLayout(true).

Test: fast/dom/HTMLMeterElement/meter-percent-size.html

  • rendering/RenderIndicator.cpp: (WebCore::RenderIndicator::updateFromElement):
  • rendering/RenderIndicator.h:
12:30 AM Changeset in webkit [66863] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-07 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>

Reviewed by Eric Seidel.

[NRWT] Add temp directory to all running drivers.
https://bugs.webkit.org/show_bug.cgi?id=45261

  • Scripts/webkitpy/layout_tests/port/webkit.py:

Sep 6, 2010:

9:06 PM Changeset in webkit [66862] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2010-09-06 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

OOB read with svg polyline
https://bugs.webkit.org/show_bug.cgi?id=45279

In principle, attributeChanged can do anything. If we supported more
DOM mutation events, it could even run JavaScript. That means we need
to be prepared for the attribute map to change when running
attributeChanged. This patch makes this loop resilient to the
attribute map changing by storing the list of changed attributes on the
stack.

Test: fast/parser/changing-attrbutes-crash.html

  • dom/Element.cpp: (WebCore::Element::setAttributeMap):

2010-09-06 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

OOB read with svg polyline
https://bugs.webkit.org/show_bug.cgi?id=45279

Test what happens when SVG changes the attribute map out from under us.

  • fast/parser/changing-attrbutes-crash-expected.txt: Added.
  • fast/parser/changing-attrbutes-crash.html: Added.
8:13 PM Changeset in webkit [66861] by Dimitri Glazkov
  • 2 edits in trunk/WebKitTools

2010-09-06 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

[Chromium/DRT] Empty out user stylesheet after each test run.
https://bugs.webkit.org/show_bug.cgi?id=45282

This should significantly cut down on the number of the mysterious flaky tests
whose diffs looked like the page was blown up to a very lage size. This
was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
which set the base body font to 100px.

Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
the same thread failed.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings): Set user stylesheet to an empty URL.
8:05 PM Changeset in webkit [66860] by tkent@chromium.org
  • 4 edits in trunk

2010-09-06 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Do not generate pixel results for text/plain resources
https://bugs.webkit.org/show_bug.cgi?id=45253

  • platform/chromium/drt_expectations.txt: Remove slow-utf8-text.pl failure.

2010-09-06 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Do not generate pixel results for text/plain resources
https://bugs.webkit.org/show_bug.cgi?id=45253

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain.
7:09 PM UsingGitWithWebKit edited by ojan@chromium.org
(diff)
7:05 PM Changeset in webkit [66859] by ojan@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-06 Ojan Vafai <ojan@chromium.org>

Reviewed by Kent Tamura.

print out correct error when a DRT thread dies in NRWT
https://bugs.webkit.org/show_bug.cgi?id=45281

Not sure why, but with the parens, python 2.6.5 on Linux
gives an error that raise takes 5 arguments and 0 were given.
Didn't test other platforms or python versions, but putting it
all on one line fixes it and correctly prints the exception
from the DRT thread.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
5:31 PM Changeset in webkit [66858] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-06 Eric Seidel <eric@webkit.org>

Unreviewed, just adding some emails from lists.webkit.org.

Update committers.py to include emails from lists.webkit.org
as found by the validate-committer-lists script.

  • Scripts/webkitpy/common/config/committers.py:
4:46 PM Changeset in webkit [66857] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-09-06 Adam Barth <abarth@webkit.org>

Small UI tweak to the reviewtool. Make the Ok/Cancel buttons a bit
bigger.

  • PrettyPatch/PrettyPatch.rb:
4:44 PM Changeset in webkit [66856] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix

4:39 PM Changeset in webkit [66855] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-09-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[reviewtool] Add a quick animation for opening/closing comment boxes
https://bugs.webkit.org/show_bug.cgi?id=45278

The 200ms animation slides in and out the line-by-line comment box.

  • code-review.js:
4:31 PM Changeset in webkit [66854] by oliver@apple.com
  • 2 edits in trunk/WebCore

Windows build fix

4:00 PM Changeset in webkit [66853] by diegohcg@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-09-06 Diego Gonzalez <diegohcg@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Update NetworkAccessManager in Qt FrameNetworkingContext
https://bugs.webkit.org/show_bug.cgi?id=45231

Make possible to get the current QNAM when NetwokingContext request it.

  • WebCoreSupport/FrameNetworkingContextQt.cpp: (WebCore::FrameNetworkingContextQt::networkAccessManager):
3:53 PM Changeset in webkit [66852] by oliver@apple.com
  • 2 edits in trunk/WebCore

Windows build fix

3:35 PM Changeset in webkit [66851] by jschuh@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-09-06 Justin Schuh <jschuh@chromium.org>

Unreviewed. Build fix.

Update test expectations for Leopard.

  • platform/mac-leopard/svg/custom/use-invalid-pattern-expected.txt: Added.
2:29 PM Changeset in webkit [66850] by oliver@apple.com
  • 10 edits in trunk

2010-09-05 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

SerializedScriptValue needs to use a flat storage mechanism
https://bugs.webkit.org/show_bug.cgi?id=45244

Export JSArray::put

2010-09-05 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

SerializedScriptValue needs to use a flat storage mechanism
https://bugs.webkit.org/show_bug.cgi?id=45244

Add a few more test cases to cover the new branches in the
rewritten serialization logic.

  • fast/dom/Window/window-postmessage-clone-expected.txt:
  • fast/dom/Window/window-postmessage-clone.html:

2010-09-05 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

SerializedScriptValue needs to use a flat storage mechanism
https://bugs.webkit.org/show_bug.cgi?id=45244

Rewrite the old tree to tree serialization logic to use
flat storage. Unfortunately this basically required a
complete rewrite.

  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneBase::CloneBase): (WebCore::CloneBase::shouldTerminate): (WebCore::CloneBase::ticksUntilNextCheck): (WebCore::CloneBase::didTimeOut): (WebCore::CloneBase::throwStackOverflow): (WebCore::CloneBase::throwInterruptedException): (WebCore::CloneBase::fail): (WebCore::CloneSerializer::serialize): (WebCore::CloneSerializer::CloneSerializer): (WebCore::CloneSerializer::isArray): (WebCore::CloneSerializer::startObject): (WebCore::CloneSerializer::startArray): (WebCore::CloneSerializer::endObject): (WebCore::CloneSerializer::getSparseIndex): (WebCore::CloneSerializer::getProperty): (WebCore::CloneSerializer::dumpImmediate): (WebCore::CloneSerializer::dumpString): (WebCore::CloneSerializer::dumpIfTerminal): (WebCore::CloneSerializer::write): (WebCore::CloneSerializer::writeLittleEndian): (WebCore::CloneSerializer::writeStringIndex): (WebCore::CloneDeserializer::deserializeString): (WebCore::CloneDeserializer::deserialize): (WebCore::CloneDeserializer::CloneDeserializer): (WebCore::CloneDeserializer::throwValidationError): (WebCore::CloneDeserializer::isValid): (WebCore::CloneDeserializer::readLittleEndian): (WebCore::CloneDeserializer::read): (WebCore::CloneDeserializer::readStringIndex): (WebCore::CloneDeserializer::readString): (WebCore::CloneDeserializer::readStringData): (WebCore::CloneDeserializer::readTag): (WebCore::CloneDeserializer::putProperty): (WebCore::CloneDeserializer::readFile): (WebCore::CloneDeserializer::readTerminal): (WebCore::SerializedScriptValue::~SerializedScriptValue): (WebCore::SerializedScriptValue::SerializedScriptValue): (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::toString): (WebCore::SerializedScriptValue::deserialize): (WebCore::SerializedScriptValue::nullValue):
  • bindings/js/SerializedScriptValue.h:
  • dom/MessagePortChannel.cpp: (WebCore::MessagePortChannel::EventData::EventData):
  • workers/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::MessageWorkerContextTask): (WebCore::MessageWorkerTask::MessageWorkerTask):
2:09 PM Changeset in webkit [66849] by abarth@webkit.org
  • 3 edits in trunk/BugsSite

2010-09-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[reviewtool] Add a field for overall comments
https://bugs.webkit.org/show_bug.cgi?id=45273

This patch does a couple logically separate things that could be
separated into smaller patches:

1) This patch adds an "overall comments" field where you can enter

overall comments about the patch. These comments appear at the top
of the bugzilla posting. Currently, these aren't redisplayed when
viewing the patch, but I plan to add that in a future patch.

2) This patch renames some of the CSS classes to more consistently

follow the camelCase style that PrettyPatch uses.

3) This patch moves the "prepare comments" button to the left of the

toolbar and renames is to "publish comments". This makes more sense
when you scroll to the bottom of the page and enter in some overall
comments.

4) When you attempt to add a comment to a line that already has a

"frozen" comment, we now unfreeze the comment instead of doing
nothing. The old behavior was kind of frustrating if you didn't
know that you could unfreeze a comment by clicking on it.

  • PrettyPatch/PrettyPatch.rb:
    • Update CSS.
  • code-review.js:
2:04 PM Changeset in webkit [66848] by Martin Robinson
  • 5 edits
    2 adds
    2 deletes in trunk/WebCore

2010-09-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] ScrollbarThemeGtk should be enabled for interior frame scrollbars
https://bugs.webkit.org/show_bug.cgi?id=45046

Make interior frame scrollbars "fully-fake," which means they do not rely
at all on GTK+ for painting or behavior, but instead are typical WebCore
scrollbars drawn according to the GTK+ theme. Move ScrollbarGtk to
MainFrameScrollbarGtk and remove all logic in that file dealing with interior
frame scrollbars.

No new tests, as this is already covered by pixel tests for scrollbars,
which were added in r66605.

  • GNUmakefile.am: Update sources list.
  • platform/ScrollView.h: Change the adjustment members to be smart pointers.
  • platform/Scrollbar.cpp: Enable THUMB_POSITION_AFFECTS_BUTTONS for GTK+ as well.
  • platform/gtk/MainFrameScrollbarGtk.cpp: Added. (MainFrameScrollbarGtk::create): Create a MainFrameScrollbarGtk instead of ScrollbarGtk. (MainFrameScrollbarGtk::MainFrameScrollbarGtk): (MainFrameScrollbarGtk::~MainFrameScrollbarGtk): (MainFrameScrollbarGtk::attachAdjustment): (MainFrameScrollbarGtk::detachAdjustment): (MainFrameScrollbarGtk::updateThumbPosition): (MainFrameScrollbarGtk::updateThumbProportion): (MainFrameScrollbarGtk::gtkValueChanged): (MainFrameScrollbarGtk::paint):
  • platform/gtk/MainFrameScrollbarGtk.h: Added.
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformInit): Remove unnecessary initialization because of smart pointer change. (WebCore::ScrollView::createScrollbar): Instead of creating ScrollbarGtk for interior frame scrollbars, create a normal WebCore scrollbar. (WebCore::ScrollView::setGtkAdjustments): Added an extra assert which ensures that this method is never called with a non-null adjustment on an interior frame scrollbar. (WebCore::ScrollView::platformAddChild): Remove logic for interior frame scrollbars. (WebCore::ScrollView::platformRemoveChild): Remove logic for interior frame scrollbars. (WebCore::ScrollView::visibleContentRect): Use a more accurate guard for detecting transitionary states when accessing parent widgets. Explcitly guard against interior frame ScrollView's trying to determine size based on parent widgets. (WebCore::ScrollView::setScrollbarModes): This method was out of sync with the one it copy-and-pasted from. Update it and change the logic to do the right thing for interior frame scrollbars.
  • platform/gtk/ScrollbarGtk.cpp: Removed.
  • platform/gtk/ScrollbarGtk.h: Removed.
2:00 PM Changeset in webkit [66847] by jschuh@chromium.org
  • 6 edits
    4 adds in trunk

2010-09-06 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Make SVG PendingResources use RefPtr
https://bugs.webkit.org/show_bug.cgi?id=43587

Convert SVGDocumentExtensions::m_pendingResources to use a RefPtr for
pending elements instead of a raw pointer so that pending elements can't
be freed prematurely.

Test: svg/custom/use-invalid-pattern.svg

  • rendering/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::registerResource):
  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::addPendingResource): (WebCore::SVGDocumentExtensions::removePendingResource):
  • svg/SVGDocumentExtensions.h:
  • svg/SVGElement.cpp: (WebCore::SVGElement::insertedIntoDocument):

2010-09-06 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Test that an invalid pending resource pattern doesn't crash
https://bugs.webkit.org/show_bug.cgi?id=43587

  • platform/mac-snowleopard/svg: Added.
  • platform/mac-snowleopard/svg/custom: Added.
  • platform/mac-snowleopard/svg/custom/use-invalid-pattern-expected.txt: Added.
  • svg/custom/use-invalid-pattern.svg: Added.
1:29 PM Changeset in webkit [66846] by commit-queue@webkit.org
  • 9 edits in trunk/JavaScriptCore

2010-09-06 Chao-ying Fu <fu@mips.com>

Reviewed by Oliver Hunt.

Support JSVALUE32_64 on MIPS
https://bugs.webkit.org/show_bug.cgi?id=43999

Add missing functions to support JSVALUE32_64 on MIPS.
Remove JSVALUE32 as the default for MIPS.

  • assembler/MIPSAssembler.h: (JSC::MIPSAssembler::divd): (JSC::MIPSAssembler::mthc1): (JSC::MIPSAssembler::cvtwd):
  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::neg32): (JSC::MacroAssemblerMIPS::branchOr32): (JSC::MacroAssemblerMIPS::set8): (JSC::MacroAssemblerMIPS::loadDouble): (JSC::MacroAssemblerMIPS::divDouble): (JSC::MacroAssemblerMIPS::convertInt32ToDouble): (JSC::MacroAssemblerMIPS::branchDouble): (JSC::MacroAssemblerMIPS::branchConvertDoubleToInt32): (JSC::MacroAssemblerMIPS::zeroDouble):
  • jit/JIT.h:
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTINativeCall):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::privateCompilePutByIdTransition):
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
  • jit/JITStubs.h:
  • wtf/Platform.h:
12:49 PM Changeset in webkit [66845] by Martin Robinson
  • 5 edits in trunk/WebCore

2010-09-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] ScrollbarThemeGtk should support secondary steppers
https://bugs.webkit.org/show_bug.cgi?id=44791

Add support to ScrollbarThemeGtk for drawing alternate steppers. Adjust
the algorithms for calculating forward and back button rects, if they
are active in the theme. Expose this information via GtkScrollbarMetrics.

  • platform/gtk/ScrollbarThemeGtk.cpp: (WebCore::ScrollbarThemeGtk::updateThemeProperties): Access the secondary stepper properties of GtkScrollbarMetrics when updating the style cache. (WebCore::ScrollbarThemeGtk::backButtonRect): Account for alternate steppers. (WebCore::ScrollbarThemeGtk::forwardButtonRect): Ditto. (WebCore::ScrollbarThemeGtk::trackRect): Ditto. (WebCore::ScrollbarThemeGtk::paintButton): Ditto.
  • platform/gtk/ScrollbarThemeGtk.h:
  • platform/gtk/gtk2drawing.c: Expose whether or not the style uses alternate steppers via GtkScrollbarMetrics.
  • platform/gtk/gtkdrawing.h: Added fields to GtkScrollbarMetrics.
12:38 PM Changeset in webkit [66844] by robert@webkit.org
  • 2 edits in trunk/JavaScriptCore

Fix compile failure in r66843

Revert to original patch in bugzilla. Leave bug open for
discussion on potential removal of double utf8 conversion.

https://bugs.webkit.org/show_bug.cgi?id=45240

12:11 PM Changeset in webkit [66843] by robert@webkit.org
  • 4 edits in trunk

2010-09-06 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] utf8 encoding of console() messages

Unskip:
http/tests/security/xssAuditor/embed-tag-null-char.html
http/tests/security/xssAuditor/object-embed-tag-null-char.html

Both tests failed because Qt's implementation of String::format()
is casting a utf8 result to String, which assumes latin1 in
its constructor. So instead of casting a QString to a String, use
StringImpl::create() instead. Unfortunately, this involves a lot
of extra casts but the end result is correct.

https://bugs.webkit.org/show_bug.cgi?id=45240

  • wtf/text/WTFString.cpp: (WTF::String::format):

2010-09-06 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] utf8 encoding of console() messages

Unskip:
http/tests/security/xssAuditor/embed-tag-null-char.html
http/tests/security/xssAuditor/object-embed-tag-null-char.html

Both tests failed because Qt's implementation of String::format()
is casting a utf8 result to String, which assumes latin1 in
its constructor. So instead of casting a QString to a String, use
StringImpl::create() instead. Unfortunately, this involves a lot
of extra casts but the end result is correct.

https://bugs.webkit.org/show_bug.cgi?id=45240

  • platform/qt/Skipped:
11:52 AM Changeset in webkit [66842] by jschuh@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-09-06 Justin Schuh <jschuh@chromium.org>

Unreviewed. Build fix.

Update test expectations for Chromium Mac.

  • platform/chromium-mac/svg/custom/use-invalid-style-expected.txt: Added.
11:32 AM Changeset in webkit [66841] by tonyg@chromium.org
  • 9 edits
    2 adds in trunk

2010-09-06 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Implement HTML5 definition of document.readyState
https://bugs.webkit.org/show_bug.cgi?id=45119

  • fast/dom/Document/readystate-expected.txt: Added.
  • fast/dom/Document/readystate.html: Added. Reads readyState inline script, external script, deferred script, DOMContentLoaded, onload, and dynamic post-onload script.

2010-09-06 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Implement HTML5 definition of document.readyState
https://bugs.webkit.org/show_bug.cgi?id=45119

The legacy behavior was "loading" -> "loaded" -> "complete". The new
HTML5 behavior is "loading" -> "interactive" -> "complete". There is
some potential for this to cause compat problems if for instance a
page expects readyState to be "loaded" during the DOMContentLoaded event.

Test: fast/dom/Document/readystate.html

  • dom/Document.cpp: (WebCore::Document::Document): Initial value is Complete because according to http://www.whatwg.org/specs/web-apps/current-work/#dom-document-readystate, when a Document is created the initial value is "complete" unless it has a parser associated with it, in which case it is "loading". So the ctor starts it Complete, and when the parser is created it is flipped to Loading. (WebCore::Document::readyState): (WebCore::Document::setReadyState): (WebCore::Document::implicitOpen): (WebCore::Document::finishedParsing): Ensure that XML and HTML parser have transition to Stopping state.
  • dom/Document.h:
  • dom/DocumentParser.cpp: (WebCore::DocumentParser::prepareToStopParsing): Previously this was being called when parsing had stopped. It is better to ensure it is only called while parsing.
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::end): Transition to stopping before calling document finishedParsiong().
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::prepareToStopParsing): Set state to interactive before running deferred scripts. This method is also called when parsing fragments, so we need to ensure it isn't done in that case. (WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd): Added. Break out this part s that notifyFinished doesn't go through the additional steps of pumping tokenizer, setting the state, etc. (WebCore::HTMLDocumentParser::notifyFinished): Now that prepareToStopParsing is split up, we must protect. It also makes sense to add a couple of ASSERTs.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): It looks like an aborted load should never transition to "complete" according the HTML5. I've left the legacy behavior for now though. (WebCore::FrameLoader::checkCompleted): The FrameLoader now sets the state on the Document instead of the Document polling the FrameLoader.
10:46 AM Changeset in webkit [66840] by antonm@chromium.org
  • 7 edits in trunk/WebCore

2010-09-06 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Inline hot methods for V8 to WebCore and back conversions
https://bugs.webkit.org/show_bug.cgi?id=45270

Inline fast paths of hot functions performing conversions from V8 wrappers
to WebCore native objects and back.
That slightly increases the size of binary (within 0.1% for both Ubuntu
and Windows, but those builds are slightly different from official ones),
but gives performance boost (3--5% on Windows, up to 8% on Ubuntu).

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::initContextIfNeeded):
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getWrapperSlow):
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::getWrapper):
  • bindings/v8/custom/V8NodeCustom.cpp: (WebCore::toV8Slow):
10:30 AM Changeset in webkit [66839] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/WebKit/efl

2010-09-06 Ryuan Choi <ryuan.choi@samsung.com>

Unreviewed build fix.

[EFL] REGRESSION(66794) Need to fix build break.
https://bugs.webkit.org/show_bug.cgi?id=45241

Add dummy class(FrameNetworkingContextEfl) like GTK+ port and implement
as EFL style.

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::createNetworkingContext):
  • WebCoreSupport/FrameNetworkingContextEfl.h: Added. (WebCore::FrameNetworkingContextEfl::create): (WebCore::FrameNetworkingContextEfl::coreFrame): (WebCore::FrameNetworkingContextEfl::FrameNetworkingContextEfl):
10:19 AM Changeset in webkit [66838] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-09-06 Adam Barth <abarth@webkit.org>

[reviewtool] Tweak the ok button to cancel the comment if the comment
is empty. Previously we would get into a bad state where a line had a
comment but there was no longer any way to access it.

  • code-review.js:
10:09 AM Changeset in webkit [66837] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-09-06 Jonathan Dixon <joth@chromium.org>

Reviewed by Jeremy Orlow.

Add new interface and empty impl. as precursor to bug 45112
https://bugs.webkit.org/show_bug.cgi?id=45257

  • public/WebGeolocationServiceBridge.h: (WebKit::WebGeolocationServiceBridge::~WebGeolocationServiceBridge):
  • src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::onWebGeolocationServiceDestroyed):
9:51 AM Changeset in webkit [66836] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-09-06 Shane Stephens <shanestephens@google.com>

Reviewed by Dimitri Glazkov.

[Crash] <animateMotion> element directly inside <symbol> element causes crash when referenced by <use>
https://bugs.webkit.org/show_bug.cgi?id=44750

Added test case to demonstrate crash bug.

  • svg/dom/symbol-embeddedAnimation-expected.txt: Added.
  • svg/dom/symbol-embeddedAnimation.svg: Added.

2010-09-06 Shane Stephens <shanestephens@google.com>

Reviewed by Dimitri Glazkov.

[Crash] <animateMotion> element directly inside <symbol> element causes crash when referenced by <use>
https://bugs.webkit.org/show_bug.cgi?id=44750

Fixes crash by checking for null transforms and skipping update step
when appropriate.

Test: svg/dom/symbol-embeddedAnimation.svg

  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
9:42 AM Changeset in webkit [66835] by Csaba Osztrogonác
  • 2 edits in trunk/WebKit/qt

2010-09-06 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Antonio Gomes.

Web Inspector: Tests crash on Qt bots revealed by r66720
https://bugs.webkit.org/show_bug.cgi?id=45256

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::InspectorClientQt): m_frontendClient must be initialized by constructor
9:14 AM Changeset in webkit [66834] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-09-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Small code cleanup in DumpRenderTreeGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=45213

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): Made this function do nothing for non-X11 platforms, so we don't have to surround the invocation with #ifdefs. (useLongRunningServerMode): Added. (runTestingServerLoop): Added. (initializeGlobalsFromCommandLineOptions): Added. (runTest): Removed ifdefs. (main): Use new helper functions.
9:12 AM Changeset in webkit [66833] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-09-06 Martin Robinson <mrobinson@igalia.com>

Unskip a couple of plugin tests which are now passing.

  • platform/gtk/Skipped:
8:38 AM Changeset in webkit [66832] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-06 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix.

  • inspector/report-API-errors.html:
8:29 AM Changeset in webkit [66831] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-09-06 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Tor Arne Vestbø.

WebCore already generates a focus-{out,in} events on its setFocus
method, there's no need to duplicate it here. Previously this was
needed because we were not catching all possible names of focus
events in PluginView::handleEvent and were missing the ones
WebCore does, but this has been fixed in r66827.

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setFocus):
8:01 AM Changeset in webkit [66830] by Csaba Osztrogonác
  • 19 edits
    2 deletes in trunk

Unreviewed, rolling out r66823.
http://trac.webkit.org/changeset/66823
https://bugs.webkit.org/show_bug.cgi?id=45266

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-09-06
Windows build fails with unknown reason (Requested by zherczeg
on #webkit).

WebCore:

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderObject.h:
  • rendering/RenderSVGResourceFilterPrimitive.cpp: Removed.
  • rendering/RenderSVGResourceFilterPrimitive.h: Removed.
  • rendering/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGContainer):

  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged):

  • svg/SVGFELightElement.cpp:

(WebCore::SVGFELightElement::svgAttributeChanged):
(WebCore::SVGFELightElement::childrenChanged):

  • svg/SVGFEOffsetElement.cpp:

(WebCore::SVGFEOffsetElement::svgAttributeChanged):

  • svg/SVGFilterElement.h:

(WebCore::SVGFilterElement::invalidateFilter):

  • svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::childrenChanged):

  • svg/SVGFilterPrimitiveStandardAttributes.h:

(WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):

LayoutTests:

  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
7:44 AM Changeset in webkit [66829] by Martin Robinson
  • 4 edits in trunk

2010-09-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] EventSender should support modifier keys with mouseDown and mouseUp events
https://bugs.webkit.org/show_bug.cgi?id=45235

  • platform/gtk/Skipped: Unskip a test which is now passing.

2010-09-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] EventSender should support modifier keys with mouseDown and mouseUp events
https://bugs.webkit.org/show_bug.cgi?id=45235

Add support for interpreting the modifier key arguments to the mouseDown and mouseUp
methods of the EventSender.

  • DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Allow passing in a modifier bitmask, which will be OR'd with the current modifiers. (contextClickCallback): Always send no modifiers when preparing the mouse event. (gdkModifersFromJSValue): Added, converts a JSValue array into a GDK modifier bitmask. (mouseDownCallback): Send in the requested modifiers to prepareMouseButtonEvent. (mouseUpCallback): Ditto.
7:42 AM Changeset in webkit [66828] by Martin Robinson
  • 3 edits
    1 delete in trunk/LayoutTests

2010-09-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Antonio Gomes.

Convert editing/selection/shift-click.html to use setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=45233

  • editing/selection/script-tests/shift-click.js: (shiftClick): Take only one expected string. (assertSelectionString): Take only one expected string. (runShiftClickTest): Added. Runs the test with a particular editing behavior.
  • editing/selection/shift-click-expected.txt: Updated to reflect new results.
  • platform/win/editing/selection/shift-click-expected.txt: Removed.
7:38 AM Changeset in webkit [66827] by xan@webkit.org
  • 5 edits in trunk

WebCore:

2010-09-06 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Provide Keyboard Events to Windowless plugins
https://bugs.webkit.org/show_bug.cgi?id=44613

Fix keyboard event delivery for windowless plugins.

Based on a patch by Bharathwaaj.

  • plugins/PluginView.cpp: (WebCore::PluginView::handleEvent): also take into account focused{in,out} events
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::handleKeyboardEvent): we want the keyval here, not the hardware keycode (WebCore::PluginView::handleMouseEvent): focus the pluginview on mouse events

LayoutTests:

2010-09-06 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Provide Keyboard Events to Windowless plugins
https://bugs.webkit.org/show_bug.cgi?id=44613

Unskip passing test.

  • platform/gtk/Skipped:
7:31 AM Changeset in webkit [66826] by loislo@chromium.org
  • 4 edits in trunk

2010-09-06 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: it'd be nice to be able to pass undefined argument as a callback to InspectorBackend functions.

There are some places where callback is passing via some wrapper. In that case sendMessageToBackend
will be called with additional argument for callback but with undefined value.

https://bugs.webkit.org/show_bug.cgi?id=45265

  • inspector/CodeGeneratorInspector.pm:
6:36 AM Changeset in webkit [66825] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-09-06 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix chromium devtools tests
https://bugs.webkit.org/show_bug.cgi?id=45258

  • src/js/Tests.js: (.TestSuite.prototype._waitForScriptPause):
6:29 AM Changeset in webkit [66824] by yurys@chromium.org
  • 3 edits in trunk/WebKit/qt

2010-09-06 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Attempt to fix random test crashes after r66720.

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorFrontendClientQt::~InspectorFrontendClientQt):
  • WebCoreSupport/InspectorClientQt.h:
6:26 AM Changeset in webkit [66823] by zherczeg@webkit.org
  • 19 edits
    2 adds in trunk

An individual renderer should be assigned to each SVGFE*Element class
https://bugs.webkit.org/show_bug.cgi?id=43954

Reviewed by Dirk Schulze.

WebCore:

RenderSVGResourceFilterPrimitive renderer is added to
the project, and assigned to each object, which class is
derived from SVGFilterPrimitiveStandardAttributes. The patch
mainly contains build system changes, and it fixes one layout
test in svg/dynamic-updates.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderObject.h:

(WebCore::RenderObject::isSVGResourceFilterPrimitive):

  • rendering/RenderSVGResourceFilterPrimitive.cpp: Added.

(WebCore::RenderSVGResourceFilterPrimitive::RenderSVGResourceFilterPrimitive):

  • rendering/RenderSVGResourceFilterPrimitive.h: Added.

(WebCore::RenderSVGResourceFilterPrimitive::isSVGResourceFilterPrimitive):

  • rendering/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGContainer):

  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged):

  • svg/SVGFELightElement.cpp:

(WebCore::SVGFELightElement::svgAttributeChanged):
(WebCore::SVGFELightElement::childrenChanged):

  • svg/SVGFEOffsetElement.cpp:

(WebCore::SVGFEOffsetElement::svgAttributeChanged):

  • svg/SVGFilterElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::childrenChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::createRenderer):

  • svg/SVGFilterPrimitiveStandardAttributes.h:

(WebCore::SVGFilterPrimitiveStandardAttributes::invalidate):

LayoutTests:

The layout test below is fixed by this patch.

  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
6:20 AM Changeset in webkit [66822] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Dirk Schulze.

[WML] Use RenderImageResource in WMLImageElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=44952

The hasImage() and setCachedImage() were moved to RenderImageResource class.
So, WML also should use the functions from RenderImageResource.

  • wml/WMLImageElement.cpp: (WebCore::WMLImageElement::attach):
6:19 AM MathML 3 testsuite results edited by François Sausset
(diff)
5:59 AM Changeset in webkit [66821] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-09-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[reviewtool] Add an "ok" button that collapses review comments
https://bugs.webkit.org/show_bug.cgi?id=45255

Many folks (including myself) are too trigger-happy with the "delete"
button that we end up deleting perfectly good review comments. This
patch adds an "ok" button to absorb these clicks (and renames "delete"
to "cancel"). When you click the ok button, the comment becomes
non-editable and the box shrinks to fit the text. You can click the
text to get back to the editable version.

  • code-review.js:
3:33 AM Changeset in webkit [66820] by jorlow@chromium.org
  • 16 edits in trunk

2010-08-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add index insertion support to IndexedDB.
https://bugs.webkit.org/show_bug.cgi?id=44695

  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/script-tests/objectstore-basics.js: (createSuccess): (addIndexSuccess): (getSuccess):

2010-08-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add index insertion support to IndexedDB.
https://bugs.webkit.org/show_bug.cgi?id=44695

Whenever you insert an item into an ObjectStore, it should use all
indexes' key paths to insert corresponding entries into each index.
Also data should be deleted out of the index when it goes away.

Not much testing yet since there's no way to directly observe indexes.
More will be in next patch.

  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::removeObjectStore):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables):
  • storage/IDBIndex.idl:
  • storage/IDBIndexBackendImpl.cpp: (WebCore::whereClause): (WebCore::bindWhereClause): (WebCore::IDBIndexBackendImpl::addingKeyAllowed):
  • storage/IDBIndexBackendImpl.h: (WebCore::IDBIndexBackendImpl::id):
  • storage/IDBKey.cpp: (WebCore::IDBKey::whereSyntax): (WebCore::IDBKey::bind): (WebCore::IDBKey::bindWithNulls):
  • storage/IDBKey.h:
  • storage/IDBObjectStore.idl:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::whereClause): (WebCore::bindWhereClause): (WebCore::IDBObjectStoreBackendImpl::get): (WebCore::fetchKeyFromKeyPath): (WebCore::putObjectStoreData): (WebCore::putIndexData): (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::remove): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::doDelete): (WebCore::IDBObjectStoreBackendImpl::removeIndex): (WebCore::IDBObjectStoreBackendImpl::openCursor):
  • storage/IDBObjectStoreBackendImpl.h:

2010-08-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add index insertion support to IndexedDB.
https://bugs.webkit.org/show_bug.cgi?id=44695

Add asserts on the [] operator.

  • public/WebVector.h: (WebKit::WebVector::operator[]):
3:19 AM MathML 3 testsuite results edited by François Sausset
(diff)
3:09 AM MathML 3 testsuite results edited by François Sausset
(diff)
2:56 AM Changeset in webkit [66819] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitSite

2010-09-06 Robin Qiu <robin.qiu@torchmobile.com.cn>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=43982
This js file seems to be a popular script for detecting mobile WebKit but
it has a flaw that makes it fail on Android and BlackBerry.

The issue is that it looks for "Mobile/" but Android and BlackBerry
use "Mobile" with no numbering after it.
Changed RegExp pattern " Mobile/" to " Mobile
b".

  • misc/WebKitDetect.js: (WebKitDetect.isMobile):
1:31 AM Changeset in webkit [66818] by antonm@chromium.org
  • 5 edits in trunk

2010-09-06 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] bypass caches when query memory usage from post GC and in crash handler.
https://bugs.webkit.org/show_bug.cgi?id=45036

Add Chromium-specific API to query actual memory usage which bypasses any caches.

  • platform/chromium/ChromiumBridge.h:

2010-09-06 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] bypass caches when query memory usage from post GC and in crash handler.
https://bugs.webkit.org/show_bug.cgi?id=45036

Add Chromium-specific API to query actual memory usage which bypasses any caches.

  • public/WebKitClient.h: (WebKit::WebKitClient::actualMemoryUsageMB):
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::actualMemoryUsageMB):
1:31 AM Changeset in webkit [66817] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-09-06 Philippe Normand <pnormand@igalia.com>

Unreviewed, skipping a crashing media test.

[GStreamer] multiple <video> elements + PulseAudio are crash-prone
https://bugs.webkit.org/show_bug.cgi?id=44235

  • platform/gtk/Skipped: Skip media/controls-styling.html
1:14 AM Changeset in webkit [66816] by rolandsteiner@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-06 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: upstream Chromium SVG test_expectations

  • platform/chromium/test_expectations.txt:
12:59 AM Changeset in webkit [66815] by abarth@webkit.org
  • 21 edits in trunk

2010-09-06 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Rename SecurityOrigin::canLoad to canDisplay
https://bugs.webkit.org/show_bug.cgi?id=45214

canLoad is a pretty opaque name. This function is really about whether
you can display the contents of the URL in an iframe, an image, or a
plugin.

  • WebCore.exp.in:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL):
  • loader/Cache.cpp: (WebCore::Cache::requestResource):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadFrameRequest):
  • loader/PingLoader.cpp: (WebCore::PingLoader::loadImage):
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin): (WebCore::SubframeLoader::createJavaAppletWidget): (WebCore::SubframeLoader::loadSubframe): (WebCore::SubframeLoader::loadPlugin):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canDisplay):
  • page/SecurityOrigin.h:
  • plugins/PluginView.cpp: (WebCore::PluginView::load):

2010-09-06 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Rename SecurityOrigin::canLoad to canDisplay
https://bugs.webkit.org/show_bug.cgi?id=45214

Propagate name change.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::loadRequest):
  • Plugins/WebNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
  • Plugins/WebPluginContainerCheck.mm: (-[WebPluginContainerCheck _isForbiddenFileLoad]):
  • WebView/WebFrame.mm: (-[WebFrame _allowsFollowingLink:]):

2010-09-06 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Rename SecurityOrigin::canLoad to canDisplay
https://bugs.webkit.org/show_bug.cgi?id=45214

Propagate name change.

  • WebFrame.cpp: (WebFrame::allowsFollowingLink):

2010-09-06 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Rename SecurityOrigin::canLoad to canDisplay
https://bugs.webkit.org/show_bug.cgi?id=45214

Propagate name change.

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::performFrameLoadURLRequest):
12:24 AM Changeset in webkit [66814] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-06 Adam Barth <abarth@webkit.org>

Update expected results to match change in test. Qt's behavior is
unchanged. It's just the redundant expectations in the test that are
changing.

  • platform/qt/fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt:
12:12 AM Changeset in webkit [66813] by yurys@chromium.org
  • 3 edits
    2 adds in trunk

2010-08-31 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: browser crashes on attempt to evaluate "alert(1)" while staying on a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=44943

Test: inspector/debugger-suspend-active-dom-objects.html

  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):

2010-08-31 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: browser crashes on attempt to evaluate "alert(1)" while staying on a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=44943

  • inspector/debugger-suspend-active-dom-objects-expected.txt: Added.
  • inspector/debugger-suspend-active-dom-objects.html: Added.

Sep 5, 2010:

11:50 PM Changeset in webkit [66812] by commit-queue@webkit.org
  • 7 edits
    1 delete in trunk

2010-09-05 Peter Kasting <pkasting@google.com>

Reviewed by Adam Barth.

Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
https://bugs.webkit.org/show_bug.cgi?id=45155

  • fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt:
  • fast/events/continuous-platform-wheelevent-in-scrolling-div.html:
  • platform/chromium/fast/events: Removed.
  • platform/chromium/fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt: Removed.

2010-09-05 Peter Kasting <pkasting@google.com>

Reviewed by Adam Barth.

Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
https://bugs.webkit.org/show_bug.cgi?id=45155

  • src/mac/WebInputEventFactory.mm: (WebKit::WebInputEventFactory::mouseWheelEvent):

2010-09-05 Peter Kasting <pkasting@google.com>

Reviewed by Adam Barth.

Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
https://bugs.webkit.org/show_bug.cgi?id=45155

  • DumpRenderTree/chromium/EventSender.cpp: Modify Chromium DRT mousewheel event generation to match new behavior on Mac. (EventSender::handleMouseWheel):
11:14 PM Changeset in webkit [66811] by yurys@chromium.org
  • 8 edits in trunk

2010-09-05 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
https://bugs.webkit.org/show_bug.cgi?id=45179

  • public/WebDevToolsAgentClient.h:
  • src/DebuggerAgentImpl.cpp: (WebKit::DebuggerAgentImpl::debuggerOutput):
  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDevToolsAgentImpl.h:

2010-09-05 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
https://bugs.webkit.org/show_bug.cgi?id=45179

  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
10:39 PM Changeset in webkit [66810] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-05 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Fix a duplication with test_expectations.txt in Chromium tree.
9:53 PM Changeset in webkit [66809] by kbr@google.com
  • 2 edits
    1 add in trunk/WebKit/chromium

2010-09-05 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add unit tests for interval tree
https://bugs.webkit.org/show_bug.cgi?id=45161

  • WebKit.gyp:
  • tests/PODIntervalTreeTest.cpp: Added. (WebCore::valueToString): (WebCore::TEST): (WebCore::UserData1::valueToString): (WebCore::EndpointType1::valueToString):
9:38 PM Changeset in webkit [66808] by kbr@google.com
  • 7 edits
    4 adds in trunk

2010-09-05 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add unit tests for red-black tree and (POD) arena
https://bugs.webkit.org/show_bug.cgi?id=45060

  • WebKit.gyp:
  • tests/PODArenaTest.cpp: Added. (WebCore::TestClass1::TestClass2::TestClass2): (WebCore::TEST_F):
  • tests/PODRedBlackTreeTest.cpp: Added. (WebCore::TEST):
  • tests/TreeTestHelpers.cpp: Added. (WebCore::TreeTestHelpers::generateSeed): (WebCore::TreeTestHelpers::initRandom): (WebCore::TreeTestHelpers::nextRandom):
  • tests/TreeTestHelpers.h: Added.

2010-09-05 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add unit tests for red-black tree and (POD) arena
https://bugs.webkit.org/show_bug.cgi?id=45060

  • platform/graphics/gpu/PODArena.h: Made DefaultChunkSize public so unit tests can access it. Fixed copyright header.
  • platform/graphics/gpu/PODInterval.h: Fixed copyright header.
  • platform/graphics/gpu/PODIntervalTree.h: Fixed copyright header.
  • platform/graphics/gpu/PODRedBlackTree.h: Fixed copyright header.
7:29 PM Changeset in webkit [66807] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-05 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Apply recent failures.
6:55 PM Changeset in webkit [66806] by tkent@chromium.org
  • 2 edits
    726 adds in trunk/LayoutTests

2010-09-05 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Add svg/dynamic-update/ image results for Chromium-win and Chromium-linux.

  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.png: Added.
  • platform/chromium/drt_expectations.txt:
6:39 PM Changeset in webkit [66805] by tkent@chromium.org
  • 3 edits
    5 adds in trunk/LayoutTests

2010-09-05 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Update Chromium-mac results for dynamic-updates.

  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.checksum: Added.
  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:
4:26 PM WebKit Team edited by andreas.kling@nokia.com
(diff)
4:20 PM Changeset in webkit [66804] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKitTools

2010-09-05 Andreas Kling <andreas.kling@nokia.com>

Rubber-stamped by Daniel Bates.

Adding myself as reviewer.

  • Scripts/webkitpy/common/config/committers.py:
9:30 AM Changeset in webkit [66803] by commit-queue@webkit.org
  • 4 edits in trunk

2010-09-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66801.
http://trac.webkit.org/changeset/66801
https://bugs.webkit.org/show_bug.cgi?id=45242

'breaks editing/pasteboard/onpaste-text-html.html' (Requested
by mwenge4 on #webkit).

  • platform/qt/Skipped:

2010-09-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66801.
http://trac.webkit.org/changeset/66801
https://bugs.webkit.org/show_bug.cgi?id=45242

'breaks editing/pasteboard/onpaste-text-html.html' (Requested
by mwenge4 on #webkit).

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::addMessageToConsole):
8:08 AM Changeset in webkit [66802] by jorlow@chromium.org
  • 22 edits
    2 adds in trunk

2010-09-05 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add IndexedDB objects' constructors to window
https://bugs.webkit.org/show_bug.cgi?id=44599

Beef up keyRange test to verify we're actualy operating
on the interface rather than an instance.

Add a test to verify the constants.

  • storage/indexeddb/constants.html:
  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/script-tests/keyrange.js: ():

2010-09-05 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Add the concept of class methods to bindings (for IndexedDB's IDBKeyRange).
https://bugs.webkit.org/show_bug.cgi?id=45044

IndexedDB's IDBKeyRange has what, in other languages, are called class
methods. In javaScript terms, these are methods only accessible from their
constructor and not instances. This change adds such support to V8. There
are already other features required for IndexedDB that JSC doesn't yet
support, so I'll add this to the list of todo items in the master bug
for that.

The bindings tests cover this. My next patch will change WebCore to use
this and it'll have associated layout tests.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: (WebDOMTestObj::classMethod): (WebDOMTestObj::classMethodWithOptional):
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_class_method): (webkit_dom_test_obj_class_method_with_optional):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionStaticMethod): (WebCore::jsTestObjPrototypeFunctionStaticMethodWithOptional):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj classMethod]): (-[DOMTestObj classMethodWithOptional:]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::classMethodCallback): (WebCore::TestObjInternal::classMethodWithOptionalCallback): (WebCore::ConfigureV8TestObjTemplate):
  • storage/IDBKeyRange.idl:
7:28 AM Changeset in webkit [66801] by robert@webkit.org
  • 4 edits in trunk

2010-09-05 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] utf8 encoding of console() messages

Unskip:
http/tests/security/xssAuditor/embed-tag-null-char.html
http/tests/security/xssAuditor/object-embed-tag-null-char.html

https://bugs.webkit.org/show_bug.cgi?id=45240

  • platform/qt/Skipped:

2010-09-05 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] utf8 encoding of console() messages

http/tests/security/xssAuditor/embed-tag-null-char.html
http/tests/security/xssAuditor/object-embed-tag-null-char.html

both fail because ChromeClientQt::addMessageToConsole() is
casting String to QString rather than String::utf8().data()

https://bugs.webkit.org/show_bug.cgi?id=45240

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::addMessageToConsole):

Sep 4, 2010:

6:12 PM Changeset in webkit [66800] by dbates@webkit.org
  • 5 edits in trunk/WebKitTools

2010-09-04 Daniel Bates <dbates@rim.com>

Reviewed by Martin Robinson.

Teach svn-apply/unapply about svn:mergeinfo
https://bugs.webkit.org/show_bug.cgi?id=45236

Recognize the svn:mergeinfo property and ignore it for now.

Currently, svn-apply/unapply recognize only '+' and '-'
property changes within a diff. We should add support
to recognize "Merged" and "Reverse-merged" changes as well.
Because svn:mergeinfo is metadata that is used only by SVN
and tends to be error-prone and/or nuisance (*), we will ignore
it for now.
(*) See "Parting Thoughts" of <http://www.collab.net/community/subversion/articles/merge-info.html>.

  • Scripts/VCSUtils.pm:
    • Modified parseSvnProperty() to recognize "Merged" and "Reverse-merged" as the start of a property value.
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
    • Added the following unit tests: "simple: add svn:mergeinfo" "simple: delete svn:mergeinfo" "simple: modified svn:mergeinfo"
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
    • Added the following unit tests: "simple: add svn:mergeinfo" "simple: delete svn:mergeinfo" "simple: modified svn:mergeinfo" "simple: modified svn:mergeinfo using SVN 1.4 syntax" "'Merged' change followed by 'Merged' change" "'Reverse-merged' change followed by 'Reverse-merged' change"
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
    • Added the following unit tests: "'Merged' change" "'Reverse-merged' change" "'Reverse-merged' change followed by 'Merge' change" "'Merged' change followed by 'Merge' change" "'Reverse-merged' change followed by 'Reverse-merged' change" "'Reverse-merged' change followed by 'Reverse-merged' change followed by 'Merged' change"
5:19 PM Changeset in webkit [66799] by weinig@apple.com
  • 8 edits in trunk/WebKit2

Allow passing null to postMessage API functions
https://bugs.webkit.org/show_bug.cgi?id=45234

Reviewed by Anders Carlsson.

  • Shared/APIObject.h: Add TypeNull to enum. This is only used

for serialization purposes, and does not represent a concrete subclass
of APIObject.

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Remove WillSubmitFormWithUserData

now that it is not needed.

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
Add explicit encoding/decoding of null for user messages.

  • UIProcess/WebContextUserMessageCoders.h:

(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):

  • WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:

(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::decode):
Update UserMessageCoders subclasses to call the base class in the correct
way to work with null messages. This means moving the encoding/decoding
of the type down to the base class, which is a nice cleanup.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
Remove now redundant WillSubmitFormWithUserData implementation.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
Ditto.

4:28 PM Changeset in webkit [66798] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

2010-09-04 Steve Block <steveblock@google.com>

Reviewed by Martin Robinson.

GTK Skipped list should allow a directory to be listed when a feature is not supported
https://bugs.webkit.org/show_bug.cgi?id=45229

This change updates the comment in the GTK Skipped list to make this
clear and applies the new policy for the DeviceOrientation and
DeviceMotion tests.

  • platform/gtk/Skipped:
3:04 PM Changeset in webkit [66797] by commit-queue@webkit.org
  • 5 edits
    1 move
    2 adds in trunk

2010-09-04 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Move test browser to WebKitTools directory
https://bugs.webkit.org/show_bug.cgi?id=45212

Follow other ports like QT and GTK which moved the test browser to
WebKitTools directory.

  • CMakeLists.txt: Include test browser if port defines one.

2010-09-04 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Move test browser to WebKitTools directory
https://bugs.webkit.org/show_bug.cgi?id=45212

Follow other ports like QT and GTK which moved the test browser to
WebKitTools directory.

  • CMakeListsEfl.txt: Remove build for test browser.
  • EWebLauncher/main.c: Removed.

2010-09-04 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Move test browser to WebKitTools directory
https://bugs.webkit.org/show_bug.cgi?id=45212

Follow other ports like QT and GTK which moved the test browser to
WebKitTools directory.

  • CMakeListsEfl.txt: Added.
  • EWebLauncher/main.c: Added. (print_history): (zoom_level_set): (on_ecore_evas_resize): (title_set): (viewport_set): (on_title_changed): (on_progress): (on_load_finished): (on_toolbars_visible_set): (on_toolbars_visible_get): (on_statusbar_visible_set): (on_statusbar_visible_get): (on_scrollbars_visible_set): (on_scrollbars_visible_get): (on_menubar_visible_set): (on_menubar_visible_get): (on_tooltip_text_set): (on_inputmethod_changed): (on_viewport_changed): (on_mouse_down): (on_focus_out): (on_focus_in): (on_resized): (on_key_down): (on_browser_del): (on_closeWindow): (quit): (browserCreate): (browserDestroy): (closeWindow): (main_signal_exit): (findThemePath): (main):
9:24 AM Changeset in webkit [66796] by jschuh@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-09-04 Justin Schuh <jschuh@chromium.org>

Unreviewed. Build fix.

Updated platform test to account for xml parser differences

  • platform/mac-leopard/svg/custom/use-invalid-style-expected.txt: Added.
  • platform/qt/svg/custom/use-invalid-style-expected.txt: Added.
  • svg/custom/use-invalid-style-expected.txt:
8:45 AM Changeset in webkit [66795] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2010-09-04 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Prevent premature deletion of svg use shadow tree
https://bugs.webkit.org/show_bug.cgi?id=43260

Test: svg/custom/use-invalid-style.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::insertedIntoDocument): (WebCore::SVGUseElement::removedFromDocument): (WebCore::SVGUseElement::detach):

2010-09-04 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Check for premature deletion of svg use shadow style element
https://bugs.webkit.org/show_bug.cgi?id=43260

  • svg/custom/use-invalid-style-expected.txt: Added.
  • svg/custom/use-invalid-style.svg: Added.
7:48 AM Changeset in webkit [66794] by diegohcg@webkit.org
  • 34 edits
    3 copies
    1 add in trunk

Add NetworkingContext to avoid layer violations
https://bugs.webkit.org/show_bug.cgi?id=42292

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2010-09-03
Reviewed by Darin Adler.

WebCore:

Create and provide access to NetworkingContext in FrameLoader.

In the WebKit layer we added specific implementations of FrameNetworkingContext
so each port's FrameLoaderClient can add any port specific information to NetworkingContext
The NetworkingContext is, therefore, created by a FrameLoaderClient and stored
in the FrameLoader for each frame created. People must always use it
by calling FrameLoader::networkingContext() and never through their FrameLoaderClient.
The lifetime cycle of NetworkingContext is kept by a RefPtr, so the object is RefCounted.

It is still a preparation to NetworkingContext to be activated and
work for all ports.

  • WebCore.exp.in:
  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::createNetworkingContext):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::~FrameLoader):
(WebCore::FrameLoader::init):
(WebCore::FrameLoader::networkingContext):

  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:

WebKit/chromium:

Add Chromium's implementation of NetworkingContext.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::createNetworkingContext):

  • src/FrameLoaderClientImpl.h:

WebKit/efl:

Add createNetworkingContext to EFL's FrameLoaderClient.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::createNetworkingContext):

  • WebCoreSupport/FrameLoaderClientEfl.h:

WebKit/gtk:

Add GTK's specific implementation of FrameNetworkingContext.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::createNetworkingContext):

  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

Add Mac's specific implementation of FrameNetworkingContext.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebCoreSupport/WebFrameNetworkingContext.mm:

(WebFrameNetworkingContext::needsSiteSpecificQuirks):
(WebFrameNetworkingContext::localFileContentSniffingEnabled):
(WebFrameNetworkingContext::scheduledRunLoopPairs):
(WebFrameNetworkingContext::blockedError):

WebKit/qt:

Add Qt's specific implementation of NetworkingContext.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::setFrame):
(WebCore::FrameLoaderClientQt::createNetworkingContext):

  • WebCoreSupport/FrameLoaderClientQt.h:
  • WebCoreSupport/FrameNetworkingContextQt.cpp:

(WebCore::FrameNetworkingContextQt::FrameNetworkingContextQt):
(WebCore::FrameNetworkingContextQt::create):
(WebCore::FrameNetworkingContextQt::originatingObject):
(WebCore::FrameNetworkingContextQt::networkAccessManager):

WebKit/win:

Add Win's specific implementation of NetworkingContext.

  • WebCoreSupport/WebFrameNetworkingContext.cpp:

(WebFrameNetworkingContext::create):
(WebFrameNetworkingContext::userAgent):
(WebFrameNetworkingContext::referrer):

  • WebFrame.cpp:

(WebFrame::createNetworkingContext):

  • WebFrame.h:

WebKit2:

Add FrameNetworkingContext implementation.

  • WebKit2.pro:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createNetworkingContext):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::needsSiteSpecificQuirks):
(WebKit::WebFrameNetworkingContext::localFileContentSniffingEnabled):
(WebKit::WebFrameNetworkingContext::scheduledRunLoopPairs):
(WebKit::WebFrameNetworkingContext::blockedError):

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp: Added.

(WebCore::WebFrameNetworkingContext::WebFrameNetworkingContext):
(WebCore::WebFrameNetworkingContext::create):
(WebCore::WebFrameNetworkingContext::originatingObject):
(WebCore::WebFrameNetworkingContext::networkAccessManager):

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h: Added.
  • WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.cpp: Added.
  • WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.h: Added.

(WebFrameNetworkingContext::create):
(WebFrameNetworkingContext::WebFrameNetworkingContext):

  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:
5:31 AM Changeset in webkit [66793] by steveblock@google.com
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed.

Remove platform/android/Skipped which was erroneously added in
http://trac.webkit.org/changeset/66251. Android does not use a Skipped list.

  • platform/android/Skipped: Removed.

Sep 3, 2010:

11:25 PM Changeset in webkit [66792] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-03 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed.

Cleanup outdated entries in test_expectations.

BUGWK44996 WIN : inspector/report-API-errors.html = TEXT
BUGWK44996 WIN : inspector/report-protocol-errors.html = TEXT
BUGWK45184 WIN : inspector/elements-panel-xhtml-structure.xhtml = TIMEOUT

  • platform/chromium/test_expectations.txt:
9:25 PM Changeset in webkit [66791] by kinuko@chromium.org
  • 6 edits in trunk/WebCore

2010-09-03 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Darin Adler.

V8/JS bindings should not perform type checks if the parameter has Callback attribute
https://bugs.webkit.org/show_bug.cgi?id=45143

No new tests, should not affect existing idls.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionOverloadedMethod5): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::overloadedMethod5Callback): (WebCore::TestObjInternal::overloadedMethodCallback):
8:26 PM Changeset in webkit [66790] by weinig@apple.com
  • 1 edit in trunk/WebKit2/ChangeLog

Fix reviewer.

8:24 PM Changeset in webkit [66789] by weinig@apple.com
  • 12 edits in trunk/WebKit2

Add ability to send UserData to willSubmitForm
https://bugs.webkit.org/show_bug.cgi?id=45222

Reviewed by Adam Barth.

  • Adds a willSubmitForm callback to the BundlePageFormClient with an out parameter WKTypeRef* parameter.
  • That out parameter gets serialized and then passed to the PageFormClient's willSubmitForm, which now has WKTypeRef parameter.
  • Temporarily adds a new WillSubmitFormWithUserData message kind. This will be replaced by the ability to explicitly serialize null as a UserMessage.
  • Platform/CoreIPC/Arguments.h:

(CoreIPC::Arguments6::Arguments6):
(CoreIPC::Arguments6::encode):
(CoreIPC::Arguments6::decode):
(CoreIPC::In):
(CoreIPC::Out):

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebFormClient.cpp:

(WebKit::WebFormClient::willSubmitForm):

  • UIProcess/WebFormClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::willSubmitForm):

  • UIProcess/WebPageProxy.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:

(WebKit::InjectedBundlePageFormClient::textFieldDidBeginEditing):
(WebKit::InjectedBundlePageFormClient::textFieldDidEndEditing):
(WebKit::InjectedBundlePageFormClient::textDidChangeInTextField):
(WebKit::InjectedBundlePageFormClient::textDidChangeInTextArea):
(WebKit::InjectedBundlePageFormClient::willSubmitForm):

  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):

7:54 PM Changeset in webkit [66788] by kbr@google.com
  • 2 edits in trunk/WebCore

2010-09-03 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium build fix. Fix breakage on Windows after
r66787 / https://bugs.webkit.org/show_bug.cgi?id=45223 .

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs):
7:31 PM Changeset in webkit [66787] by jamesr@google.com
  • 3 edits in trunk/WebCore

2010-09-03 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Text sometimes fails to display in accelerated 2d canvases
https://bugs.webkit.org/show_bug.cgi?id=45223

Calls PlatformContextSkia::prepareForSoftwareDraw() before drawing glyphs
using skia to ensure that the backing store state is consistent.

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::drawGlyphs):
6:40 PM Changeset in webkit [66786] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, attempted layout test fix.

Report correct (unzoomed) image sizes for zoomed images.
https://bugs.webkit.org/show_bug.cgi?id=42089

  • fast/images/resources/oval.png: Tweak to try to avoid cryptic ImageIO errors.
6:24 PM Changeset in webkit [66785] by jamesr@google.com
  • 5 edits in trunk/WebCore

2010-09-03 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add thirdparty directory and incorporate GLU tessellator
https://bugs.webkit.org/show_bug.cgi?id=44707

This directory is intended to contain copies of third-party libraries used
by WebCore, in particular those which may require some modification in
order to incorporate.

No tests at this time; these sources are being added in preparation for
incorporating other code which uses them, at which point the code will be
exercised and testable.

  • thirdparty: Added.
  • thirdparty/README.txt: Added.
  • thirdparty/glu: Added.
  • thirdparty/glu/LICENSE.txt: Added.
  • thirdparty/glu/README.webkit: Added.
  • thirdparty/glu/gluos.h: Added.
  • thirdparty/glu/internal_glu.h: Added.
  • thirdparty/glu/libtess: Added.
  • thirdparty/glu/libtess/GNUmakefile: Added.
  • thirdparty/glu/libtess/Imakefile: Added.
  • thirdparty/glu/libtess/README: Added.
  • thirdparty/glu/libtess/alg-outline: Added.
  • thirdparty/glu/libtess/dict-list.h: Added.
  • thirdparty/glu/libtess/dict.c: Added.
  • thirdparty/glu/libtess/dict.h: Added.
  • thirdparty/glu/libtess/geom.c: Added.
  • thirdparty/glu/libtess/geom.h: Added.
  • thirdparty/glu/libtess/memalloc.c: Added.
  • thirdparty/glu/libtess/memalloc.h: Added.
  • thirdparty/glu/libtess/mesh.c: Added.
  • thirdparty/glu/libtess/mesh.h: Added.
  • thirdparty/glu/libtess/normal.c: Added.
  • thirdparty/glu/libtess/normal.h: Added.
  • thirdparty/glu/libtess/priorityq-heap.c: Added.
  • thirdparty/glu/libtess/priorityq-heap.h: Added.
  • thirdparty/glu/libtess/priorityq-sort.h: Added.
  • thirdparty/glu/libtess/priorityq.c: Added.
  • thirdparty/glu/libtess/priorityq.h: Added.
  • thirdparty/glu/libtess/render.c: Added.
  • thirdparty/glu/libtess/render.h: Added.
  • thirdparty/glu/libtess/sweep.c: Added.
  • thirdparty/glu/libtess/sweep.h: Added.
  • thirdparty/glu/libtess/tess.c: Added.
  • thirdparty/glu/libtess/tess.h: Added.
  • thirdparty/glu/libtess/tessmono.c: Added.
  • thirdparty/glu/libtess/tessmono.h: Added.
6:19 PM Changeset in webkit [66784] by kbr@google.com
  • 1 edit
    36 adds in trunk/WebCore

2010-09-03 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add thirdparty directory and incorporate GLU tessellator
https://bugs.webkit.org/show_bug.cgi?id=44707

This directory is intended to contain copies of third-party libraries used
by WebCore, in particular those which may require some modification in
order to incorporate.

No tests at this time; these sources are being added in preparation for
incorporating other code which uses them, at which point the code will be
exercised and testable.

  • thirdparty: Added.
  • thirdparty/README.txt: Added.
  • thirdparty/glu: Added.
  • thirdparty/glu/LICENSE.txt: Added.
  • thirdparty/glu/README.webkit: Added.
  • thirdparty/glu/gluos.h: Added.
  • thirdparty/glu/internal_glu.h: Added.
  • thirdparty/glu/libtess: Added.
  • thirdparty/glu/libtess/GNUmakefile: Added.
  • thirdparty/glu/libtess/Imakefile: Added.
  • thirdparty/glu/libtess/README: Added.
  • thirdparty/glu/libtess/alg-outline: Added.
  • thirdparty/glu/libtess/dict-list.h: Added.
  • thirdparty/glu/libtess/dict.c: Added.
  • thirdparty/glu/libtess/dict.h: Added.
  • thirdparty/glu/libtess/geom.c: Added.
  • thirdparty/glu/libtess/geom.h: Added.
  • thirdparty/glu/libtess/memalloc.c: Added.
  • thirdparty/glu/libtess/memalloc.h: Added.
  • thirdparty/glu/libtess/mesh.c: Added.
  • thirdparty/glu/libtess/mesh.h: Added.
  • thirdparty/glu/libtess/normal.c: Added.
  • thirdparty/glu/libtess/normal.h: Added.
  • thirdparty/glu/libtess/priorityq-heap.c: Added.
  • thirdparty/glu/libtess/priorityq-heap.h: Added.
  • thirdparty/glu/libtess/priorityq-sort.h: Added.
  • thirdparty/glu/libtess/priorityq.c: Added.
  • thirdparty/glu/libtess/priorityq.h: Added.
  • thirdparty/glu/libtess/render.c: Added.
  • thirdparty/glu/libtess/render.h: Added.
  • thirdparty/glu/libtess/sweep.c: Added.
  • thirdparty/glu/libtess/sweep.h: Added.
  • thirdparty/glu/libtess/tess.c: Added.
  • thirdparty/glu/libtess/tess.h: Added.
  • thirdparty/glu/libtess/tessmono.c: Added.
  • thirdparty/glu/libtess/tessmono.h: Added.
6:15 PM Changeset in webkit [66783] by jamesr@google.com
  • 7 edits
    1 delete in trunk/WebCore

2010-09-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66781.
http://trac.webkit.org/changeset/66781
https://bugs.webkit.org/show_bug.cgi?id=45220

Breaks the build. Adds a mac-specific file to
platform/graphics without #if PLATFORM() guards and changes
the GraphicsContext3D interface without updating all
implementations (Requested by jamesr on #webkit).

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/WebGLObject.cpp: (WebCore::WebGLObject::deleteObject):
  • platform/graphics/ANGLEWebKitBridge.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/GraphicsContext3DOpenGL.cpp: Removed.
  • platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::validateAttributes): (WebCore::GraphicsContext3D::makeContextCurrent): (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): (WebCore::GraphicsContext3D::reshape): (WebCore::ensureContext): (WebCore::GraphicsContext3D::prepareTexture): (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::attachShader): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::bindRenderbuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::blendColor): (WebCore::GraphicsContext3D::blendEquation): (WebCore::GraphicsContext3D::blendEquationSeparate): (WebCore::GraphicsContext3D::blendFunc): (WebCore::GraphicsContext3D::blendFuncSeparate): (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData): (WebCore::GraphicsContext3D::checkFramebufferStatus): (WebCore::GraphicsContext3D::clearColor): (WebCore::GraphicsContext3D::clear): (WebCore::GraphicsContext3D::clearDepth): (WebCore::GraphicsContext3D::clearStencil): (WebCore::GraphicsContext3D::colorMask): (WebCore::GraphicsContext3D::compileShader): (WebCore::GraphicsContext3D::copyTexImage2D): (WebCore::GraphicsContext3D::copyTexSubImage2D): (WebCore::GraphicsContext3D::cullFace): (WebCore::GraphicsContext3D::depthFunc): (WebCore::GraphicsContext3D::depthMask): (WebCore::GraphicsContext3D::depthRange): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::disable): (WebCore::GraphicsContext3D::disableVertexAttribArray): (WebCore::GraphicsContext3D::drawArrays): (WebCore::GraphicsContext3D::drawElements): (WebCore::GraphicsContext3D::enable): (WebCore::GraphicsContext3D::enableVertexAttribArray): (WebCore::GraphicsContext3D::finish): (WebCore::GraphicsContext3D::flush): (WebCore::GraphicsContext3D::framebufferRenderbuffer): (WebCore::GraphicsContext3D::framebufferTexture2D): (WebCore::GraphicsContext3D::frontFace): (WebCore::GraphicsContext3D::generateMipmap): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttachedShaders): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::getContextAttributes): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::getString): (WebCore::GraphicsContext3D::hint): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isEnabled): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::lineWidth): (WebCore::GraphicsContext3D::linkProgram): (WebCore::GraphicsContext3D::pixelStorei): (WebCore::GraphicsContext3D::polygonOffset): (WebCore::GraphicsContext3D::readPixels): (WebCore::GraphicsContext3D::releaseShaderCompiler): (WebCore::GraphicsContext3D::renderbufferStorage): (WebCore::GraphicsContext3D::sampleCoverage): (WebCore::GraphicsContext3D::scissor): (WebCore::GraphicsContext3D::shaderSource): (WebCore::GraphicsContext3D::stencilFunc): (WebCore::GraphicsContext3D::stencilFuncSeparate): (WebCore::GraphicsContext3D::stencilMask): (WebCore::GraphicsContext3D::stencilMaskSeparate): (WebCore::GraphicsContext3D::stencilOp): (WebCore::GraphicsContext3D::stencilOpSeparate): (WebCore::GraphicsContext3D::texParameterf): (WebCore::GraphicsContext3D::texParameteri): (WebCore::GraphicsContext3D::uniform1f): (WebCore::GraphicsContext3D::uniform1fv): (WebCore::GraphicsContext3D::uniform2f): (WebCore::GraphicsContext3D::uniform2fv): (WebCore::GraphicsContext3D::uniform3f): (WebCore::GraphicsContext3D::uniform3fv): (WebCore::GraphicsContext3D::uniform4f): (WebCore::GraphicsContext3D::uniform4fv): (WebCore::GraphicsContext3D::uniform1i): (WebCore::GraphicsContext3D::uniform1iv): (WebCore::GraphicsContext3D::uniform2i): (WebCore::GraphicsContext3D::uniform2iv): (WebCore::GraphicsContext3D::uniform3i): (WebCore::GraphicsContext3D::uniform3iv): (WebCore::GraphicsContext3D::uniform4i): (WebCore::GraphicsContext3D::uniform4iv): (WebCore::GraphicsContext3D::uniformMatrix2fv): (WebCore::GraphicsContext3D::uniformMatrix3fv): (WebCore::GraphicsContext3D::uniformMatrix4fv): (WebCore::GraphicsContext3D::useProgram): (WebCore::GraphicsContext3D::validateProgram): (WebCore::GraphicsContext3D::vertexAttrib1f): (WebCore::GraphicsContext3D::vertexAttrib1fv): (WebCore::GraphicsContext3D::vertexAttrib2f): (WebCore::GraphicsContext3D::vertexAttrib2fv): (WebCore::GraphicsContext3D::vertexAttrib3f): (WebCore::GraphicsContext3D::vertexAttrib3fv): (WebCore::GraphicsContext3D::vertexAttrib4f): (WebCore::GraphicsContext3D::vertexAttrib4fv): (WebCore::GraphicsContext3D::vertexAttribPointer): (WebCore::GraphicsContext3D::viewport): (WebCore::GraphicsContext3D::getBooleanv): (WebCore::GraphicsContext3D::getBufferParameteriv): (WebCore::GraphicsContext3D::getFloatv): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv): (WebCore::GraphicsContext3D::getIntegerv): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getRenderbufferParameteriv): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getShaderSource): (WebCore::GraphicsContext3D::getTexParameterfv): (WebCore::GraphicsContext3D::getTexParameteriv): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation): (WebCore::GraphicsContext3D::getVertexAttribfv): (WebCore::GraphicsContext3D::getVertexAttribiv): (WebCore::GraphicsContext3D::getVertexAttribOffset): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D): (WebCore::GraphicsContext3D::createBuffer): (WebCore::GraphicsContext3D::createFramebuffer): (WebCore::GraphicsContext3D::createProgram): (WebCore::GraphicsContext3D::createRenderbuffer): (WebCore::GraphicsContext3D::createShader): (WebCore::GraphicsContext3D::createTexture): (WebCore::GraphicsContext3D::deleteBuffer): (WebCore::GraphicsContext3D::deleteFramebuffer): (WebCore::GraphicsContext3D::deleteProgram): (WebCore::GraphicsContext3D::deleteRenderbuffer): (WebCore::GraphicsContext3D::deleteShader): (WebCore::GraphicsContext3D::deleteTexture): (WebCore::GraphicsContext3D::sizeInBytes): (WebCore::GraphicsContext3D::synthesizeGLError):
5:58 PM Changeset in webkit [66782] by jamesr@google.com
  • 3 edits in trunk/WebCore

2010-09-03 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

Force 2d canvases to be rendered in software when the composite operation isn't source-over
https://bugs.webkit.org/show_bug.cgi?id=45216

The current accelerated 2d canvas implementation is very slow for composite operations other
than the default. This patch forces a canvas to be rendered in software if any other operation
is set until we accelerate the rest.

Tested by any of the fast/canvas tests that use a non-default globalCompositeOperation.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
5:49 PM Changeset in webkit [66781] by cmarrin@apple.com
  • 7 edits
    1 copy in trunk/WebCore

2010-09-03 Paul Sawaya <psawaya@apple.com>

Reviewed by Chris Marrin.

Refactored out Mac specific code for platform/graphics/mac/GraphicsContext3D.mm file.
Left general OpenGL code in platform/graphics/GraphicsContext3DOpenGL.cpp.
https://bugs.webkit.org/show_bug.cgi?id=30625

5:36 PM Changeset in webkit [66780] by commit-queue@webkit.org
  • 4 edits in trunk/WebCore

2010-09-03 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Null out Canvas2DLayerChromium's back reference to DrawingBuffer on destruction
https://bugs.webkit.org/show_bug.cgi?id=45187

Canvas2DLayerChromium keeps a back reference to a DrawingBuffer. This has to be a raw pointer
because the DrawingBuffer holds a RefPtr to the Canvas2DLayerChromium. Since the layer can
outlive the buffer, this back reference has to be explicitly cleared when the DrawingBuffer
is destroyed.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::setDrawingBuffer):
  • platform/graphics/chromium/Canvas2DLayerChromium.h:
  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::~DrawingBuffer):
5:24 PM Changeset in webkit [66779] by kbr@google.com
  • 2 edits
    2 adds in trunk/WebCore

2010-09-03 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add interval tree capable of holding plain old data (POD)
https://bugs.webkit.org/show_bug.cgi?id=45160

Adding an interval tree currently capable of holding types which
do not require their destructors to be called. POD is a slight
misnomer which will be corrected soon, hopefully by removing this
restriction.

This class is based on the augmentable property of the red/black
tree integrated under bug 45059.

Unit tests for the PODIntervalTree will be integrated separately
under bug 45161.

  • WebCore.gypi:
  • platform/graphics/gpu/PODInterval.h: Added. (WebCore::PODInterval::PODInterval): (WebCore::PODInterval::low): (WebCore::PODInterval::high): (WebCore::PODInterval::data): (WebCore::PODInterval::overlaps): (WebCore::PODInterval::operator<): (WebCore::PODInterval::operator==): (WebCore::PODInterval::maxHigh): (WebCore::PODInterval::setMaxHigh): (WebCore::PODInterval::toString):
  • platform/graphics/gpu/PODIntervalTree.h: Added. (WebCore::PODIntervalTree::PODIntervalTree): (WebCore::PODIntervalTree::allOverlaps): (WebCore::PODIntervalTree::createInterval): (WebCore::PODIntervalTree::checkInvariants): (WebCore::PODIntervalTree::init): (WebCore::PODIntervalTree::searchForOverlapsFrom): (WebCore::PODIntervalTree::updateNode): (WebCore::PODIntervalTree::checkInvariantsFromNode): (WebCore::valueToString):
4:40 PM Changeset in webkit [66778] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-09-03 Simon Fraser <Simon Fraser>

Reviewed by Adam Roben.

Set project dependencies so that they build serially. This fixes
issues when running run-webkit-tests if DRT is not built yet.

  • DumpRenderTree/DumpRenderTree.sln:
4:24 PM Changeset in webkit [66777] by vangelis@chromium.org
  • 7 edits in trunk

2010-09-02 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Darin Fisher.

[chromium] Revert to software compositing if the accelerated
compositor fails to initialize. If we tried to initialize the compositor
for this WebView and failed, next time the associated chrome client is
asked whether it can do accelerated compositing it will return false.
https://bugs.webkit.org/show_bug.cgi?id=45124


  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::allowsAcceleratedCompositing):
  • src/ChromeClientImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::allowsAcceleratedCompositing): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::getOnscreenGLES2Context):
  • src/WebViewImpl.h:

2010-09-02 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Darin Fisher.

[chromium] Gracefully switch over to software compositing if the accelerated
compositor fails to initialize. LayerRendererChromium::create() will now return 0
if the GLES2Context passed to it is NULL or the LayerRendererChromium failed to initialize
hardware rendering.
https://bugs.webkit.org/show_bug.cgi?id=45124


Tested by forcing the creation of the gles2 context to fail and loading pages that normally trigger
the compositor.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::makeContextCurrent):
4:04 PM Changeset in webkit [66776] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk

2010-09-03 Peter Kasting <pkasting@google.com>

Reviewed by Simon Fraser.

Report correct (unzoomed) image sizes for zoomed images.
https://bugs.webkit.org/show_bug.cgi?id=42089

  • fast/images/resources/oval.png: Added.
  • fast/images/zoomed-img-size-expected.txt: Added.
  • fast/images/zoomed-img-size.html: Added.

2010-09-03 Peter Kasting <pkasting@google.com>

Reviewed by Simon Fraser.

Report correct (unzoomed) image sizes for zoomed images.
https://bugs.webkit.org/show_bug.cgi?id=42089

Test: fast/images/zoomed-img-size.html

  • css/CSSPrimitiveValue.cpp: Factor rounding code out to a templatized function so it can be shared. (WebCore::CSSPrimitiveValue::computeLengthInt): (WebCore::CSSPrimitiveValue::computeLengthIntForLength): (WebCore::CSSPrimitiveValue::computeLengthShort):
  • css/CSSPrimitiveValue.h: Factor rounding code out to a templatized function so it can be shared. (WebCore::roundForImpreciseConversion):
  • html/HTMLImageElement.cpp: Report unzoomed size to script that queries an image's width or height. (WebCore::HTMLImageElement::width): (WebCore::HTMLImageElement::height):
  • loader/ImageDocument.cpp: Report unzoomed size in the page title when viewing a standalone image. (WebCore::ImageDocumentParser::finish):
  • rendering/RenderObject.h: Use shared rounding code from CSSPrimitiveValue to compensate for inexactness in zoomed sizes. (WebCore::adjustForAbsoluteZoom):
3:56 PM Changeset in webkit [66775] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-03 Zhenyao Mo <zmo@google.com>

Unreviewed.

Add flaky test inspector/dom-breakpoints.html to test_expectations.

  • platform/chromium/test_expectations.txt:
3:46 PM Changeset in webkit [66774] by abarth@webkit.org
  • 16 edits
    4 deletes in trunk/WebCore

2010-09-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66770.
http://trac.webkit.org/changeset/66770
https://bugs.webkit.org/show_bug.cgi?id=45200

Broke Windows in a way I can't figure out now to fix
(Requested by abarth on #webkit).

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/BindingDOMWindow.h: (WebCore::::completeURL):
  • bindings/generic/BindingFrame.h: Removed.
  • bindings/generic/BindingLocation.h: Removed.
  • bindings/generic/GenericBinding.h:
  • bindings/js/JSBinding.h: Removed.
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMBinding.cpp: (WebCore::shouldAllowNavigation): (WebCore::toLexicalFrame): (WebCore::toDynamicFrame): (WebCore::processingUserGesture): (WebCore::completeURL):
  • bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::JSLocation::replace):
  • bindings/js/specialization/JSBindingState.cpp: Removed.
  • bindings/js/specialization/JSBindingState.h: Removed.
  • bindings/v8/V8Binding.h:
  • bindings/v8/V8Utilities.cpp: (WebCore::completeURL): (WebCore::navigateIfAllowed):
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::replaceCallback):
  • bindings/v8/specialization/V8BindingState.cpp:
  • bindings/v8/specialization/V8BindingState.h:
2:59 PM Changeset in webkit [66773] by jianli@chromium.org
  • 7 edits in trunk

REGRESSION (r66452): Sending of multipart forms with files is broken.
https://bugs.webkit.org/show_bug.cgi?id=45159

Reviewed by Darin Adler.

WebCore:

  • platform/network/FormData.cpp:

(WebCore::FormData::appendKeyValuePairItems):

LayoutTests:

Updated related tests to include dumping content type.

  • http/tests/local/formdata/send-form-data-expected.txt:
  • http/tests/local/formdata/send-form-data-with-sliced-file-expected.txt:
  • http/tests/local/formdata/upload-events-expected.txt:
  • http/tests/xmlhttprequest/resources/multipart-post-echo.php:
2:54 PM Changeset in webkit [66772] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-03 Zhenyao Mo <zmo@google.com>

Unreviewed.

Clean up the outdated entries in test_expectations.

  • platform/chromium/test_expectations.txt:
2:25 PM Changeset in webkit [66771] by crogers@google.com
  • 36 edits
    1 copy
    3 deletes in branches/audio/WebCore

audio branch: commit recent changes made to land patches in trunk

  • general cleanup
  • remove AudioConfig.h
  • rename AudioFloatBuffer.h to AudioBuffer.h and add more methods
  • FFTFrame cleanup: make FFTFrame.h expose the interface correctly (get rid of FFTFrameMac.h)
  • HRTF classes general cleanup
  • AudioPannerNode, Panner, PassThroughPanner, EqualPowerPanner cleanup
2:11 PM Changeset in webkit [66770] by commit-queue@webkit.org
  • 16 edits
    5 copies
    1 add in trunk/WebCore

2010-09-03 Dominic Cooney <dominicc@google.com>

Reviewed by Adam Barth.

Moves location.replace bindings logic into bindings/generic and
instantiates it for JSC and V8.

https://bugs.webkit.org/show_bug.cgi?id=44891

Covered by existing location.replace tests.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/BindingDOMWindow.h: (WebCore::::createWindow): (WebCore::::open):
  • bindings/generic/BindingFrame.h: Added. (WebCore::::navigateIfAllowed):
  • bindings/generic/BindingLocation.h: Added. (WebCore::::replace):
  • bindings/generic/GenericBinding.h: (WebCore::completeURL):
  • bindings/js/JSBinding.h: Added.
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMBinding.cpp: (WebCore::shouldAllowNavigation): (WebCore::toLexicalFrame): (WebCore::toDynamicFrame): (WebCore::processingUserGesture): (WebCore::completeURL):
  • bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::JSLocation::replace):
  • bindings/js/specialization/JSBindingState.cpp: Added. (WebCore::::getActiveFrame): (WebCore::::getFirstFrame): (WebCore::::processingUserGesture): (WebCore::::allowsAccessFromFrame):
  • bindings/js/specialization/JSBindingState.h: Added.
  • bindings/v8/V8Binding.h:
  • bindings/v8/V8Utilities.cpp: (WebCore::completeURL): (WebCore::navigateIfAllowed):
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::replaceCallback):
  • bindings/v8/specialization/V8BindingState.cpp: (WebCore::::allowsAccessFromFrame):
  • bindings/v8/specialization/V8BindingState.h:
1:53 PM Changeset in webkit [66769] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Change WKDictionaryIsMutable to take a WKDictionaryRef instead of a WKMutableDictionaryRef.
If the type is already states it is mutable, there would be no reason for the check.

Reviewed by Gavin Barraclough.

  • UIProcess/API/C/WKMutableDictionary.cpp:

(WKDictionaryIsMutable):

  • UIProcess/API/C/WKMutableDictionary.h:
1:43 PM Changeset in webkit [66768] by Dimitri Glazkov
  • 4 edits in trunk

2010-09-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Tony Chang.

[Chromium] Make sure that the width of the menu list is always constant under layout tests.
https://bugs.webkit.org/show_bug.cgi?id=45196

  • platform/chromium/drt_expectations.txt: Remove now-passing tests.

2010-09-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Tony Chang.

[Chromium] Make sure that the width of the menu list is always constant under layout tests.
https://bugs.webkit.org/show_bug.cgi?id=45196

  • rendering/RenderThemeChromiumWin.cpp: (WebCore::menuListButtonWidth): Added. (WebCore::RenderThemeChromiumWin::paintMenuList): Use menuListButtonWidth instead of always querying system metrics.
1:39 PM Changeset in webkit [66767] by Adam Roben
  • 2 edits in trunk/WebKit/win

Attempt to fixing Windows nightlies again

The fix in r66438 should be sufficient, but we have to touch
WebKit.idl to force that change to be picked up by the build.

  • Interfaces/WebKit.idl: Touched this file to force a build.
1:28 PM Changeset in webkit [66766] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-03 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed.

Added new expected result that wasn't committed in r66764.

  • editing/style/push-down-implicit-styles-around-list-expected.txt:
1:22 PM Changeset in webkit [66765] by commit-queue@webkit.org
  • 7 edits in trunk/WebCore

2010-09-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66732.
http://trac.webkit.org/changeset/66732
https://bugs.webkit.org/show_bug.cgi?id=45195

the patch is not matched with general publish/subscribe scheme
implemented in the Inspector API (Requested by loislo on
#webkit).

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::getChildNodes):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.getChildNodesAsync.mycallback): (WebInspector.DOMAgent.prototype.getChildNodesAsync):
  • inspector/front-end/WorkersSidebarPane.js: (WebInspector.WorkersSidebarPane.prototype.reset):
1:08 PM Changeset in webkit [66764] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-03 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

Fixed a test committed in r66743.

  • editing/style/script-tests/push-down-implicit-styles-around-list.js: (selectLastWord):
1:04 PM Changeset in webkit [66763] by jamesr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-09-03 James Robinson <jamesr@chromium.org>

[chromium] Add one more include to fix the mac compile.

  • src/GraphicsContext3D.cpp:
12:48 PM Changeset in webkit [66762] by jamesr@google.com
  • 4 edits in trunk

2010-09-03 James Robinson <jamesr@chromium.org>

[chromium] Compile fixes for 66746

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::texImage2D): (WebCore::SharedGraphicsContext3D::texSubImage2D):

2010-09-03 James Robinson <jamesr@chromium.org>

[chromium] Compile fixes for 66746.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
12:44 PM Changeset in webkit [66761] by Dimitri Glazkov
  • 2 edits in trunk/WebKitTools

2010-09-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Fix reading configuraiton in NWRT to work on Windows.
https://bugs.webkit.org/show_bug.cgi?id=45180

  • Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do

with the file otherwise.

12:33 PM Changeset in webkit [66760] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

[Qt] fast/text/decomposed-after-stacked-diacritics.html fails on Qt Linux
https://bugs.webkit.org/show_bug.cgi?id=45194

Rubber-stamped by Anders Carlsson.

  • platform/qt/Skipped: Skip fast/text/decomposed-after-stacked-diacritics.html
12:26 PM WebKit Team edited by zmo@google.com
(diff)
12:24 PM Changeset in webkit [66759] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-09-03 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioParam files
https://bugs.webkit.org/show_bug.cgi?id=44995

No new tests since audio API is not yet implemented.

  • webaudio: Added.
  • webaudio/AudioParam.h: Added. (WebCore::AudioParam::create): (WebCore::AudioParam::AudioParam): (WebCore::AudioParam::value): (WebCore::AudioParam::setValue): (WebCore::AudioParam::name): (WebCore::AudioParam::minValue): (WebCore::AudioParam::maxValue): (WebCore::AudioParam::defaultValue): (WebCore::AudioParam::units): (WebCore::AudioParam::smoothedValue): (WebCore::AudioParam::smooth): (WebCore::AudioParam::resetSmoothedValue): (WebCore::AudioParam::setSmoothingConstant):
  • webaudio/AudioParam.idl: Added.
12:19 PM Changeset in webkit [66758] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-09-03 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

audio engine: add AudioChannel files
https://bugs.webkit.org/show_bug.cgi?id=44921

No new tests since audio API is not yet implemented.

  • platform/audio/AudioChannel.cpp: Added. (WebCore::AudioChannel::scale): (WebCore::AudioChannel::copyFrom): (WebCore::AudioChannel::copyFromRange): (WebCore::AudioChannel::sumFrom): (WebCore::AudioChannel::maxAbsValue):
  • platform/audio/AudioChannel.h: Added. (WebCore::AudioChannel::AudioChannel): (WebCore::AudioChannel::set): (WebCore::AudioChannel::length): (WebCore::AudioChannel::data): (WebCore::AudioChannel::zero):
12:16 PM Changeset in webkit [66757] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-03 Zhenyao Mo <zmo@google.com>

Unreviewed.

Add failing test (in Chromium Linux) fast/text/decomposed-after-stacked-diacritics.html to test_expectations.

  • platform/chromium/test_expectations.txt:
12:14 PM Changeset in webkit [66756] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-03 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Remove usage of ce_textcodecs.h
https://bugs.webkit.org/show_bug.cgi?id=45169

ce_textcodecs.h was a non public header for (not required)
additonal codecs in the original Torch Mobile port.

  • platform/text/wince/TextCodecWinCE.cpp: (WebCore::LanguageManager::LanguageManager): (WebCore::decode):
12:10 PM Changeset in webkit [66755] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-09-03 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Initial patch for audio engine: AudioBus and helper classes
https://bugs.webkit.org/show_bug.cgi?id=34452

No new tests since audio API is not yet implemented.

  • platform/audio/AudioBus.cpp: Added. (WebCore::AudioBus::AudioBus): (WebCore::AudioBus::setChannelMemory): (WebCore::AudioBus::zero): (WebCore::AudioBus::channelByType): (WebCore::AudioBus::topologyMatches): (WebCore::AudioBus::createBufferFromRange): (WebCore::AudioBus::maxAbsValue): (WebCore::AudioBus::normalize): (WebCore::AudioBus::scale): (WebCore::AudioBus::copyFrom): (WebCore::AudioBus::sumFrom): (WebCore::AudioBus::processWithGainFromMonoStereo): (WebCore::AudioBus::processWithGainFrom): (WebCore::AudioBus::copyWithGainFrom): (WebCore::AudioBus::sumWithGainFrom):
  • platform/audio/AudioBus.h: Added. (WebCore::AudioBus::numberOfChannels): (WebCore::AudioBus::channel): (WebCore::AudioBus::length): (WebCore::AudioBus::sampleRate): (WebCore::AudioBus::setSampleRate): (WebCore::AudioBus::setGain): (WebCore::AudioBus::gain): (WebCore::AudioBus::reset): (WebCore::AudioBus::AudioBus):
  • platform/audio/AudioSourceProvider.h: Added. (WebCore::AudioSourceProvider::~AudioSourceProvider):
12:07 PM Changeset in webkit [66754] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-03 Zhenyao Mo <zmo@google.com>

Unreviewed.

Add failing test (chromium linux) editing/style/push-down-implicit-styles-around-list.html to test_expectations.

  • platform/chromium/test_expectations.txt:
12:04 PM Changeset in webkit [66753] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-09-03 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add Panner files
https://bugs.webkit.org/show_bug.cgi?id=45076

No new tests since audio API is not yet implemented.

  • platform/audio/Panner.cpp: Added. (WebCore::Panner::create):
  • platform/audio/Panner.h: Added. (WebCore::Panner::~Panner): (WebCore::Panner::panningModel): (WebCore::Panner::Panner):
12:03 PM Changeset in webkit [66752] by tony@chromium.org
  • 12 edits in trunk/WebKit/chromium

2010-09-03 Tony Chang <tony@chromium.org>

Unreviewed, remove svn:executable flag from images and css files.

  • src/js/Images/segmentChromium.png: Removed property svn:executable.
  • src/js/Images/segmentHoverChromium.png: Removed property svn:executable.
  • src/js/Images/segmentHoverEndChromium.png: Removed property svn:executable.
  • src/js/Images/segmentSelectedChromium.png: Removed property svn:executable.
  • src/js/Images/segmentSelectedEndChromium.png: Removed property svn:executable.
  • src/js/Images/statusbarBackgroundChromium.png: Removed property svn:executable.
  • src/js/Images/statusbarBottomBackgroundChromium.png: Removed property svn:executable.
  • src/js/Images/statusbarButtonsChromium.png: Removed property svn:executable.
  • src/js/Images/statusbarMenuButtonChromium.png: Removed property svn:executable.
  • src/js/Images/statusbarMenuButtonSelectedChromium.png: Removed property svn:executable.
  • src/js/devTools.css: Removed property svn:executable.
11:57 AM Changeset in webkit [66751] by crogers@google.com
  • 2 edits in trunk/WebKitTools

2010-09-03 Chris Rogers <crogers@google.com>

Unreviewed

Add myself to the committers list
https://bugs.webkit.org/show_bug.cgi?id=45189

  • Scripts/webkitpy/common/config/committers.py:
11:51 AM Changeset in webkit [66750] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-09-03 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioListener files
https://bugs.webkit.org/show_bug.cgi?id=45006

No new tests since audio API is not yet implemented.

  • webaudio: Added.
  • webaudio/AudioListener.cpp: Added. (WebCore::AudioListener::AudioListener):
  • webaudio/AudioListener.h: Added. (WebCore::AudioListener::create): (WebCore::AudioListener::setPosition): (WebCore::AudioListener::position): (WebCore::AudioListener::setOrientation): (WebCore::AudioListener::orientation): (WebCore::AudioListener::setUpVector): (WebCore::AudioListener::upVector): (WebCore::AudioListener::setVelocity): (WebCore::AudioListener::velocity): (WebCore::AudioListener::setDopplerFactor): (WebCore::AudioListener::dopplerFactor): (WebCore::AudioListener::setSpeedOfSound): (WebCore::AudioListener::speedOfSound):
  • webaudio/AudioListener.idl: Added.
11:50 AM Changeset in webkit [66749] by caseq@chromium.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Unreviewed. Updated LayoutTests/ChangeLog to include more detailed description for r66735.

11:46 AM Changeset in webkit [66748] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-09-03 Chris Rogers <crogers@google.com>

Unreviewed

Add WebCore/webaudio and WebCore/platform/audio/mac directories in preparation for landing reviewed patches
https://bugs.webkit.org/show_bug.cgi?id=45185

  • platform/audio/mac: Added.
  • webaudio: Added.
11:46 AM Changeset in webkit [66747] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-03 Zhenyao Mo <zmo@google.com>

Uneviewed.

Add TIMEOUT test inspector/elements-panel-xhtml-structure.xhtml to chromium test_expectations.

  • platform/chromium/test_expectations.txt:
11:38 AM Changeset in webkit [66746] by jamesr@google.com
  • 31 edits
    3 copies
    6 adds in trunk

2010-09-03 James Robinson <jamesr@chromium.org>

Reviewed by Chris Marrin.

Multiple accelerated 2D canvases should be able to use the same GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=44926

This allows many accelerated 2d canvases to render using a single underlying GraphicsContext3D.
It introduces a new class SharedGraphicsContext3D that manages several callers. This class could
also cache the current state to avoid issuing redundant calls, although in this first cut it doesn't.
The SharedGraphicsContext3D is provided through the ChromeClient so that its lifetime can be tied to that
of the platform-specific compositor infrastructure.

Accelerated 2d canvases maintain a reference to a SharedGraphicsContext3D and have ownership of a CanvasFramebuffer,
which represents the canvas's rendering target. The compositing layer for an accelerated 2d canvas is
aware only of the canvas's CanvasFramebuffer. This means that WebGL and 2d canvases are no longer treated
as the same time of layer by the compositor.

Covered by existing canvas tests.

  • WebCore.gypi:
  • html/canvas/CanvasRenderingContext.cpp:
  • html/canvas/CanvasRenderingContext.h: (WebCore::CanvasRenderingContext::paintsIntoCanvasBuffer): (WebCore::CanvasRenderingContext::platformLayer):
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): (WebCore::CanvasRenderingContext2D::paintsIntoCanvasBuffer): (WebCore::CanvasRenderingContext2D::reset): (WebCore::CanvasRenderingContext2D::didDraw): (WebCore::CanvasRenderingContext2D::platformLayer):
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::paintsIntoCanvasBuffer):
  • html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::graphicsContext3D): (WebCore::WebGLRenderingContext::platformLayer):
  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::attachRootGraphicsLayer): (WebCore::EmptyChromeClient::setNeedsOneShotDrawingSynchronization): (WebCore::EmptyChromeClient::scheduleCompositingLayerSync):
  • page/ChromeClient.h: (WebCore::ChromeClient::getSharedGraphicsContext3D):
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setSharedGraphicsContext3D): (WebCore::GraphicsContext::syncSoftwareCanvas):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/chromium/Canvas2DLayerChromium.cpp: Added. (WebCore::Canvas2DLayerChromium::create): (WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium): (WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium): (WebCore::Canvas2DLayerChromium::updateContents): (WebCore::Canvas2DLayerChromium::setTextureChanged): (WebCore::Canvas2DLayerChromium::textureId):
  • platform/graphics/chromium/Canvas2DLayerChromium.h: Added. (WebCore::Canvas2DLayerChromium::drawsContent):
  • platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::CanvasLayerChromium): (WebCore::CanvasLayerChromium::~CanvasLayerChromium): (WebCore::CanvasLayerChromium::draw):
  • platform/graphics/chromium/CanvasLayerChromium.h:
  • platform/graphics/chromium/DrawingBufferChromium.cpp: Added. (WebCore::generateColorTexture): (WebCore::DrawingBuffer::DrawingBuffer): (WebCore::DrawingBuffer::~DrawingBuffer): (WebCore::DrawingBuffer::publishToPlatformLayer): (WebCore::DrawingBuffer::reset): (WebCore::DrawingBuffer::platformLayer):
  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::GLES2Canvas): (WebCore::GLES2Canvas::~GLES2Canvas): (WebCore::GLES2Canvas::bindFramebuffer): (WebCore::GLES2Canvas::clearRect): (WebCore::GLES2Canvas::fillRect): (WebCore::GLES2Canvas::drawTexturedRect): (WebCore::GLES2Canvas::drawTexturedRectTile): (WebCore::GLES2Canvas::drawQuad): (WebCore::GLES2Canvas::createTexture): (WebCore::GLES2Canvas::getTexture):
  • platform/graphics/chromium/GLES2Canvas.h: (WebCore::GLES2Canvas::context): (WebCore::GLES2Canvas::drawingBuffer):
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setContentsToCanvas):
  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp: Added. (WebCore::WebGLLayerChromium::create): (WebCore::WebGLLayerChromium::WebGLLayerChromium): (WebCore::WebGLLayerChromium::updateContents): (WebCore::WebGLLayerChromium::setContext):
  • platform/graphics/chromium/WebGLLayerChromium.h: Added. (WebCore::WebGLLayerChromium::drawsContent):
  • platform/graphics/gpu/DrawingBuffer.cpp: Added. (WebCore::DrawingBuffer::create): (WebCore::DrawingBuffer::bind): (WebCore::DrawingBuffer::setWillPublishCallback):
  • platform/graphics/gpu/DrawingBuffer.h: Added. (WebCore::DrawingBuffer::size):
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: Added. (WebCore::SharedGraphicsContext3D::create): (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::makeContextCurrent): (WebCore::SharedGraphicsContext3D::scissor): (WebCore::SharedGraphicsContext3D::enable): (WebCore::SharedGraphicsContext3D::disable): (WebCore::SharedGraphicsContext3D::clearColor): (WebCore::SharedGraphicsContext3D::clear): (WebCore::SharedGraphicsContext3D::drawArrays): (WebCore::SharedGraphicsContext3D::getError): (WebCore::SharedGraphicsContext3D::getIntegerv): (WebCore::SharedGraphicsContext3D::createFramebuffer): (WebCore::SharedGraphicsContext3D::createTexture): (WebCore::SharedGraphicsContext3D::deleteFramebuffer): (WebCore::SharedGraphicsContext3D::deleteTexture): (WebCore::SharedGraphicsContext3D::framebufferTexture2D): (WebCore::SharedGraphicsContext3D::texParameteri): (WebCore::SharedGraphicsContext3D::texImage2D): (WebCore::SharedGraphicsContext3D::texSubImage2D): (WebCore::SharedGraphicsContext3D::readPixels): (WebCore::SharedGraphicsContext3D::supportsBGRA): (WebCore::SharedGraphicsContext3D::getTexture): (WebCore::SharedGraphicsContext3D::applyCompositeOperator): (WebCore::SharedGraphicsContext3D::useQuadVertices): (WebCore::SharedGraphicsContext3D::setActiveTexture): (WebCore::SharedGraphicsContext3D::bindTexture): (WebCore::SharedGraphicsContext3D::useFillSolidProgram): (WebCore::SharedGraphicsContext3D::useTextureProgram): (WebCore::SharedGraphicsContext3D::bindFramebuffer): (WebCore::SharedGraphicsContext3D::setViewport): (WebCore::SharedGraphicsContext3D::paintsIntoCanvasBuffer):
  • platform/graphics/gpu/SharedGraphicsContext3D.h: Added.
  • platform/graphics/gpu/Texture.cpp:
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::syncSoftwareCanvas): (WebCore::GraphicsContext::setSharedGraphicsContext3D):
  • platform/graphics/skia/ImageSkia.cpp:
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::~PlatformContextSkia): (WebCore::WillPublishCallbackImpl::create): (WebCore::WillPublishCallbackImpl::willPublish): (WebCore::WillPublishCallbackImpl::WillPublishCallbackImpl): (WebCore::PlatformContextSkia::setSharedGraphicsContext3D): (WebCore::PlatformContextSkia::uploadSoftwareToHardware): (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
  • platform/graphics/skia/PlatformContextSkia.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):

2010-09-03 James Robinson <jamesr@chromium.org>

Reviewed by Chris Marrin.

Multiple accelerated 2D canvases should be able to use the same GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=44926

Adds a SharedContext3D to WebViewImpl. The SharedContext3D has to live on WebViewImpl to be
tied to the lifetime of the compositor context.

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::getSharedGraphicsContext3D):
  • src/ChromeClientImpl.h:
  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::platformLayer): (WebCore::GraphicsContext3D::platformLayer):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::getSharedGraphicsContext3D):
  • src/WebViewImpl.h:
11:32 AM Changeset in webkit [66745] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-09-03 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add audio distance effect files
https://bugs.webkit.org/show_bug.cgi?id=44705

No new tests since audio API is not yet implemented.

  • platform/audio/Distance.cpp: Added. (WebCore::DistanceEffect::DistanceEffect): (WebCore::DistanceEffect::gain): (WebCore::DistanceEffect::linearGain): (WebCore::DistanceEffect::inverseGain): (WebCore::DistanceEffect::exponentialGain):
  • platform/audio/Distance.h: Added. (WebCore::DistanceEffect::model): (WebCore::DistanceEffect::setModel): (WebCore::DistanceEffect::setRefDistance): (WebCore::DistanceEffect::setMaxDistance): (WebCore::DistanceEffect::setRolloffFactor): (WebCore::DistanceEffect::refDistance): (WebCore::DistanceEffect::maxDistance): (WebCore::DistanceEffect::rolloffFactor):
11:31 AM Changeset in webkit [66744] by zmo@google.com
  • 1 edit
    20 adds in trunk/LayoutTests

2010-09-03 Zhenyao Mo <zmo@google.com>

Unreviewed.

Rebaseline after r66731.

  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.txt: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.checksum: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.png: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.txt: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.checksum: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.png: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added.
11:21 AM Changeset in webkit [66743] by rniwa@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-09-03 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Can't unbold bolded list item when list is surrounded by <b> tag
https://bugs.webkit.org/show_bug.cgi?id=25086

Added a regression test for the bug because the bug has been fixed by http://trac.webkit.org/changeset/66324.
The test ensures WebKit removes implicitly styled element such as b around list element
when style is toggled inside the list.

  • editing/style/push-down-implicit-styles-around-list-expected.txt: Added.
  • editing/style/push-down-implicit-styles-around-list.html: Added.
  • editing/style/script-tests/push-down-implicit-styles-around-list.js: Added. (testSingleToggle): (selectAll): (selectTest): (selectFirstWord): (selectSecondWord): (selectLastTwoWords):
11:21 AM Changeset in webkit [66742] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-03 Johnny Ding <jnd@chromium.org>

Reviewed by Adam Barth.

Save the gesture state to track the user gesture state across async form submission.
https://bugs.webkit.org/show_bug.cgi?id=44969

fast/events/popup-blocked-to-post-blank.html can cover the test in WebKit.
A UI test will be added in chromium to address chromium's bug.

  • loader/RedirectScheduler.cpp: (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): (WebCore::ScheduledFormSubmission::fire): (WebCore::RedirectScheduler::scheduleFormSubmission):
11:02 AM Changeset in webkit [66741] by ap@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-09-03 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=45135
<rdar://problem/7823714> TCMalloc_PageHeap doesn't hold a mutex while manipulating shared data

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::initializeScavenger): Make sure to create a non-recursive mutex regardless of platform default, so that we can assert that it's held (this is for platforms that don't have libdispatch). (WTF::TCMalloc_PageHeap::signalScavenger): Assert that the mutex is held, so we can look at m_scavengeThreadActive. For platforms that have libdispatch, assert that pageheap_lock is held. (WTF::TCMalloc_PageHeap::periodicScavenge): Make sure that pageheap_lock is held before manipulating m_scavengeThreadActive. Otherwise, there is an obvious race condition, and we can make unbalanced calls to dispatch_resume().
10:56 AM Changeset in webkit [66740] by mitz@apple.com
  • 3 edits
    2 adds in trunk

2010-09-03 Dan Bernstein <mitz@apple.com>

Reviewed by Anders Carlsson.

<rdar://problem/8392655> REGRESSION (r57215): Decomposed diacritics render incorrectly when preceded by stacked diacritics
https://bugs.webkit.org/show_bug.cgi?id=45182

Test: fast/text/decomposed-after-stacked-diacritics.html

  • platform/graphics/Font.cpp: (WebCore::Font::codePath): Do not bail out if the run contains stacked diacritics, since it may also contain characters that require the complex text code path.

2010-09-03 Dan Bernstein <mitz@apple.com>

Reviewed by Anders Carlsson.

<rdar://problem/8392655> REGRESSION (r57215): Decomposed diacritics render incorrectly when preceded by stacked diacritics
https://bugs.webkit.org/show_bug.cgi?id=45182

  • fast/text/decomposed-after-stacked-diacritics-expected.txt: Added.
  • fast/text/decomposed-after-stacked-diacritics.html: Added.
10:42 AM Changeset in webkit [66739] by mnaganov@chromium.org
  • 6 edits
    1 add in trunk/WebCore

2010-09-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Cleanup after r66117 - extract heap snapshot
view styles into a dedicated .css

https://bugs.webkit.org/show_bug.cgi?id=45178

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/heapProfiler.css: Added. (.heap-snapshot-sidebar-tree-item .icon): (.heap-snapshot-sidebar-tree-item.small .icon): (.heap-snapshot-view): (.heap-snapshot-view.visible): (.heap-snapshot-view .data-grid): (.heap-snapshot-view .data-grid th.count-column): (.heap-snapshot-view .data-grid td.count-column): (.heap-snapshot-view .data-grid th.size-column): (.heap-snapshot-view .data-grid td.size-column): (.heap-snapshot-view .data-grid th.countDelta-column): (.heap-snapshot-view .data-grid td.countDelta-column): (.heap-snapshot-view .data-grid th.sizeDelta-column): (.heap-snapshot-view .data-grid td.sizeDelta-column): (#heap-snapshot-summary-container): (.heap-snapshot-summary): (.heap-snapshot-summary canvas.summary-graph): (.heap-snapshot-summary-label):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
10:07 AM Changeset in webkit [66738] by demarchi@webkit.org
  • 7 edits
    1 move in trunk

2010-09-03 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Martin Robinson.

[EFL] Regression (66531) Build break with Glib Support
https://bugs.webkit.org/show_bug.cgi?id=45011

Move GtkTypedefs.h to GTypedefs.h and let it inside gobject directory
since when glib is enabled, EFL port needs it, too.

  • CMakeListsEfl.txt: Include gobject directory to find new header file.
  • GNUmakefile.am: Ditto.
  • wtf/CMakeListsEfl.txt: Ditto.
  • wtf/Platform.h: Include header if port is EFL and glib support is enabled.
  • wtf/gtk/GtkTypedefs.h: Removed.
  • wtf/gobject/GTypedefs.h: Added. Sections specific to GTK are now guarded by PLATFORM(GTK).

2010-09-03 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Martin Robinson.

[EFL] Regression (66531) Build break with Glib Support
https://bugs.webkit.org/show_bug.cgi?id=45011

Move GtkTypedefs.h to GTypedefs.h and let it inside gobject directory
since when glib is enabled, EFL port needs it, too.

  • CMakeListsEfl.txt: Include gobject directory to find new header file.
9:56 AM Changeset in webkit [66737] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

2010-09-03 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

play-state.html and suspend-resume-animaton.html now pass on Chromium
https://bugs.webkit.org/show_bug.cgi?id=45158

Two animation tests now pass reliably with both test_shell and Chromium
DRT due to r66641 and http://crrev.com/58369.

  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:
9:15 AM Changeset in webkit [66736] by jchaffraix@webkit.org
  • 2 edits in trunk/WebCore

[GTK] compilation issue with JSTimeRanges when video turned off
https://bugs.webkit.org/show_bug.cgi?id=44249

Patch by Zaheer Ahmad <zaheer.mot@gmail.com> on 2010-09-03
Reviewed by Darin Adler.

Move the JSTimeRanges outside ENABLE_VIDEO in GNUMakefile.am

  • WebCore/GNUMakefile.am
9:00 AM Changeset in webkit [66735] by caseq@chromium.org
  • 10 edits
    1 add
    3 deletes in trunk

2010-09-03 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
Changed MIME type for .js to application/x-javascript for consistency with apache used on other platforms.
https://bugs.webkit.org/show_bug.cgi?id=45137

  • Scripts/webkitpy/layout_tests/port/lighttpd.conf:

2010-09-03 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
Use CGI as target for POST request to prevent HTTP 405 on certain platforms.
Changed MIME type for .js to application/x-javascript in lighttpd.conf for
consistency with apache used on other platforms.
https://bugs.webkit.org/show_bug.cgi?id=45137

  • http/tests/inspector/console-xhr-logging-expected.txt:
  • http/tests/inspector/console-xhr-logging.html:
  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-parameters-expected.txt:
  • http/tests/inspector/resource-parameters.html:
  • http/tests/inspector/resources/post-target.cgi: Added.
  • platform/chromium-win/http/tests/inspector/resource-parameters-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/win/http/tests/inspector/console-xhr-logging-expected.txt: Removed.
  • platform/win/http/tests/inspector/resource-parameters-expected.txt: Removed.
8:56 AM Changeset in webkit [66734] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-09-03 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Install default theme
https://bugs.webkit.org/show_bug.cgi?id=45154

Since a theme is needed in order to create a new browser, install the
default one to serve as example and fall-back.

  • CMakeListsEfl.txt:
8:29 AM Changeset in webkit [66733] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

https://bugs.webkit.org/show_bug.cgi?id=45175
[WebView unmarkAllTextMatches] will crash if the webview is already closed

Reviewed by Dan Bernstein.

Made this and related methods robust against being called when the WebView is closed.

  • WebView/WebView.mm:

(-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
Bail out if the WebView is closed.
(-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]):
Ditto.
(-[WebView unmarkAllTextMatches]):
Ditto.
(-[WebView rectsForTextMatches]):
Ditto.

8:17 AM Changeset in webkit [66732] by loislo@chromium.org
  • 7 edits in trunk/WebCore

2010-09-03 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: cleanup inspector api. getChildNodes should return array of child nodes as an output value.

The current implementation of the inspector api has some unnecessary complexity.
As example WebInspector is requesting child nodes of a node by getChildNodes
but DOM agent is actually pushing the child nodes via setChildNodes event call and
send back an empty response message.

https://bugs.webkit.org/show_bug.cgi?id=45172

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getChildNodesArray): (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::getChildNodes):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.getChildNodesAsync.mycallback): (WebInspector.DOMAgent.prototype.getChildNodesAsync):
  • inspector/front-end/WorkersSidebarPane.js: (WebInspector.WorkersSidebarPane.prototype.reset):
7:26 AM Changeset in webkit [66731] by Nikolas Zimmermann
  • 3 edits
    16 adds in trunk

2010-09-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVG atlas map slider doesn't work properly
https://bugs.webkit.org/show_bug.cgi?id=45107

SVG 1.1 2nd edition relaxes hit testing rules. The outermost <svg> should react
to mouse events, in standalone and compound documents, if the mouse location is
within the intrinsic boundaries of the <svg> element.

Tests: svg/custom/mouse-move-on-svg-container-standalone.svg

svg/custom/mouse-move-on-svg-container.xhtml
svg/custom/mouse-move-on-svg-root-standalone.svg
svg/custom/mouse-move-on-svg-root.xhtml

  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::nodeAtPoint):

2010-09-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVG atlas map slider doesn't work properly
https://bugs.webkit.org/show_bug.cgi?id=45107

  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.checksum: Added.
  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.png: Added.
  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.txt: Added.
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: Added.
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added.
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.checksum: Added.
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.png: Added.
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum: Added.
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Added.
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added.
  • svg/custom/mouse-move-on-svg-container-standalone.svg: Added.
  • svg/custom/mouse-move-on-svg-container.xhtml: Added.
  • svg/custom/mouse-move-on-svg-root-standalone.svg: Added.
  • svg/custom/mouse-move-on-svg-root.xhtml: Added.
7:01 AM Changeset in webkit [66730] by commit-queue@webkit.org
  • 16 edits in trunk

2010-09-03 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: provide more information to front-end when breaking on DOM event
https://bugs.webkit.org/show_bug.cgi?id=44679

  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest._pausedScript):

2010-09-03 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: provide more information to front-end when breaking on DOM event
https://bugs.webkit.org/show_bug.cgi?id=44679

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::parserInsertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::parserAddChild): (WebCore::notifyChildInserted): (WebCore::dispatchChildRemovalEvents):
  • dom/Element.cpp: (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute):
  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::willInsertDOMNodeImpl): (WebCore::InspectorController::didInsertDOMNodeImpl): (WebCore::InspectorController::willRemoveDOMNodeImpl): (WebCore::InspectorController::didRemoveDOMNodeImpl): (WebCore::InspectorController::willModifyDOMAttrImpl): (WebCore::InspectorController::didModifyDOMAttrImpl):
  • inspector/InspectorController.h: (WebCore::InspectorController::willInsertDOMNode): (WebCore::InspectorController::didInsertDOMNode): (WebCore::InspectorController::willRemoveDOMNode): (WebCore::InspectorController::willModifyDOMAttr): (WebCore::InspectorController::didModifyDOMAttr): (WebCore::InspectorController::inspectorControllerForNode):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::~InspectorDOMAgent): (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion): (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval): (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::didModifyDOMAttr): (WebCore::InspectorDOMAgent::createBreakpoint):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::didPause): (WebCore::InspectorDebuggerAgent::breakProgram):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorValues.h: (WebCore::InspectorValue::isNull):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointItem): (WebInspector.BreakpointItem.prototype._enableChanged):
  • inspector/front-end/Script.js: (WebInspector.Script.prototype.get linesCount):
  • inspector/front-end/inspector.js: (WebInspector.pausedScript):
6:57 AM Changeset in webkit [66729] by Csaba Osztrogonác
  • 2 edits in trunk/JavaScriptCore

2010-09-03 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Simon Hausmann.

Fix warning in wtf/ByteArray.h
https://bugs.webkit.org/show_bug.cgi?id=44672

  • wtf/ByteArray.h: Use maximal sized array for MSVC and unsized array for other compilers.
6:15 AM Changeset in webkit [66728] by jorlow@chromium.org
  • 3 edits in trunk/LayoutTests

2010-09-03 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Fix and beef up IndexedDB layout test
https://bugs.webkit.org/show_bug.cgi?id=45035

Implement some fixmes and such.

  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/script-tests/database-basics.js: (openSuccess): (setVersionAgain): (createObjectStore): (checkObjectStore):
6:00 AM Changeset in webkit [66727] by abecsi@webkit.org
  • 4 edits
    1 add in trunk/WebKitTools

2010-09-03 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>

Reviewed by Eric Seidel.

Add feature detection support to NRWT.
https://bugs.webkit.org/show_bug.cgi?id=41842

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
5:53 AM Changeset in webkit [66726] by jorlow@chromium.org
  • 13 edits in trunk

2010-08-31 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

IDBCursor.continue() should reuse the .openCursor's IDBRequest object
https://bugs.webkit.org/show_bug.cgi?id=44953

  • storage/indexeddb/objectstore-cursor.html:

2010-08-31 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

IDBCursor.continue() should reuse the .openCursor's IDBRequest object
https://bugs.webkit.org/show_bug.cgi?id=44953

This is to match the spec. This requires a modification to IDBRequest so
that multiple events can be queued up.

Note that the initial state for IDBRequest was removed from the spec.

Test: modified existing test to verify new behavior.

  • storage/IDBAny.cpp: (WebCore::IDBAny::createInvalid): (WebCore::IDBAny::createNull): (WebCore::IDBAny::setNull):
  • storage/IDBAny.h: (WebCore::IDBAny::create):
  • storage/IDBCursor.cpp: (WebCore::IDBCursor::IDBCursor): (WebCore::IDBCursor::continueFunction):
  • storage/IDBCursor.h: (WebCore::IDBCursor::create):
  • storage/IDBCursor.idl:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::~IDBRequest): (WebCore::IDBRequest::resetReadyState): (WebCore::IDBRequest::onError): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::abort): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::scheduleEvent):
  • storage/IDBRequest.h:
  • storage/IDBRequest.idl:

2010-08-31 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

IDBCursor.continue() should reuse the .openCursor's IDBRequest object
https://bugs.webkit.org/show_bug.cgi?id=44953

  • src/WebIDBCallbacksImpl.cpp: (WebCore::WebIDBCallbacksImpl::onError): (WebCore::WebIDBCallbacksImpl::onSuccess):
5:42 AM Changeset in webkit [66725] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-09-03 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Dialog separators are gone in GTK+ 3.x.

  • webkit/webkitsoupauthdialog.c: (show_auth_dialog):
5:39 AM Changeset in webkit [66724] by antonm@chromium.org
  • 3 edits in trunk/LayoutTests

2010-09-03 Anton Muhin <antonm@chromium.org>

Unreviewed fix, updating Chromium's exectations.

  • platform/chromium-linux/plugins/embed-attributes-style-expected.checksum:
  • platform/chromium-linux/plugins/embed-attributes-style-expected.png:
5:12 AM Changeset in webkit [66723] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-03 Bharathwaaj Srinivasan <bharathwaaj.s@gmail.com>

Reviewed by Xan Lopez.

Initialize keyboard events before passing plugins.
https://bugs.webkit.org/show_bug.cgi?id=44771

No new tests needed since this is a trivial fix.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::handleKeyboardEvent):
4:48 AM Changeset in webkit [66722] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-09-03 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix Qt compilation.

  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parametersForPlugin):
3:36 AM Changeset in webkit [66721] by commit-queue@webkit.org
  • 12 edits
    4 adds in trunk

2010-09-03 Hironori Bono <hbono@chromium.org>

Reviewed by Kent Tamura.

Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
and implements it for Mac.
https://bugs.webkit.org/show_bug.cgi?id=41832

  • editing/spelling/spelling-contenteditable-expected.txt: Added the expected result for spelling-contenteditable.html.
  • editing/spelling/spelling-contenteditable.html: Added a text test of spellcheker APIs for contenteditable <div> elements.
  • editing/spelling/spelling-textarea-expected.txt: Added the expected result for spelling-textarea.html.
  • editing/spelling/spelling-textarea.html: Added a text test of spellchecker APIs for <textarea> elements.
  • platform/chromium/test_expectations.txt: Skipped the new tests because textInputController.hasSpelingMarker() is not implemented.
  • platform/gtk/Skipped: ditto.
  • platform/qt/Skipped: ditto.
  • platform/win/Skipped: ditto.

2010-09-03 Hironori Bono <hbono@chromium.org>

Reviewed by Kent Tamura.

Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
and implements it for Mac.
https://bugs.webkit.org/show_bug.cgi?id=41832

Tests: editing/spelling/spelling-contenteditable.html

editing/spelling/spelling-textarea.html

  • WebCore.exp.in: Exported symbols used by [WebFrame hasSpellingMarker:length:].

2010-09-03 Hironori Bono <hbono@chromium.org>

Reviewed by Kent Tamura.

Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
and implements it for Mac.
https://bugs.webkit.org/show_bug.cgi?id=41832

  • WebView/WebFrame.mm: Implemented [WebFrame hasSpellingMarker:length:]. (spellingNode): (-[WebFrame hasSpellingMarker:length:]):
  • WebView/WebFramePrivate.h: Added [WebFrame hasSpellingMarker:length:] so TextInputController can use it.

2010-09-03 Hironori Bono <hbono@chromium.org>

Reviewed by Kent Tamura.

Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
and implements it for Mac.
https://bugs.webkit.org/show_bug.cgi?id=41832

  • DumpRenderTree/mac/TextInputController.m: Added [TextInputController hasSpellingMarker:length:] and bind it so we can call it from JavaScript. (+[TextInputController isSelectorExcludedFromWebScript:]): (+[TextInputController webScriptNameForSelector:]): (-[TextInputController hasSpellingMarker:length:]):
3:09 AM Changeset in webkit [66720] by yurys@chromium.org
  • 24 edits in trunk

2010-09-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
https://bugs.webkit.org/show_bug.cgi?id=44230

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::close):
  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::disconnectFromBackend): don't try to notify InspectorController that frontend closes if InspectorController triggered the action.
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.disconnectFromBackend):
  • inspector/front-end/inspector.js: (WebInspector.disconnectFromBackend):

2010-09-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
https://bugs.webkit.org/show_bug.cgi?id=44230

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm: (WebInspectorFrontendClient::closeWindow): (WebInspectorFrontendClient::disconnectFromBackend): (-[WebInspectorWindowController windowShouldClose:]): (-[WebInspectorWindowController destroyInspectorView:]):
2:50 AM Changeset in webkit [66719] by Girish Ramakrishnan
  • 2 edits in trunk/WebCore

Passing a 32-bit depth X pixmap to NPAPI windowless plugins is too inefficient.
Instead, pass a X Pixmap that has same depth as the screen depth since graphics
operations are optimized for this depth.

https://bugs.webkit.org/show_bug.cgi?id=45167

Reviewed by Simon Hausmann.

  • plugins/PluginPackage.cpp:

(WebCore::PluginPackage::determineQuirks):

12:44 AM Changeset in webkit [66718] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-09-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, updated GTK baselines of a mathml test.

Use correct minus glyphs in MathML operators
https://bugs.webkit.org/show_bug.cgi?id=43629

  • platform/gtk/mathml/presentation/mo-expected.txt:
12:03 AM Changeset in webkit [66717] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

Add ENABLE(DATABASE) guard to DatabaseAuthorizer.cpp
https://bugs.webkit.org/show_bug.cgi?id=45152

DatabaseAuthorizer is used only with ENABLE(DATABASE).

  • storage/DatabaseAuthorizer.cpp:
Note: See TracTimeline for information about the timeline view.