Timeline
Sep 19, 2010:
- 11:16 PM Changeset in webkit [67839] by
-
- 2 edits in trunk/BugsSite
2010-09-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[reviewtool] Publish button should actually publish the review comments
https://bugs.webkit.org/show_bug.cgi?id=46074
Instead of showing the confirmation lightbox, the Publish button now
publishes the comments directly. If there's demand for a "Preview"
button, we can find a way to add that feature.
- code-review.js:
- 10:29 PM Changeset in webkit [67838] by
-
- 2 edits in trunk/WebKit2
Fix windows build.
- UIProcess/API/C/WKPage.h:
- 10:23 PM Changeset in webkit [67837] by
-
- 2 edits in trunk/WebKit2
Attempt to fix Qt build.
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::doTextFieldCommandFromEvent):
- 10:20 PM Changeset in webkit [67836] by
-
- 5 edits in trunk/WebKit2
Add WebKit2 equivalent of the WebFormDelegate's doCommandBySelector
<rdar://problem/8377088>
https://bugs.webkit.org/show_bug.cgi?id=46073
Reviewed by Anders Carlsson.
Add bundle client to match the behavior of:
- (BOOL)textField:(DOMHTMLInputElement *)element doCommandBySelector:(SEL)commandSelector inFrame:(WebFrame *)frame;
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
(WebKit::InjectedBundlePageFormClient::shouldPerformActionInTextField):
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::getActionTypeForKeyEvent):
(WebKit::WebEditorClient::doTextFieldCommandFromEvent):
(WebKit::WebEditorClient::textWillBeDeletedInTextField):
- 9:26 PM Changeset in webkit [67835] by
-
- 3 edits in trunk/BugsSite
2010-09-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move reviewtool to action=review
https://bugs.webkit.org/show_bug.cgi?id=46071
This patch removes the old Review Patch screen and moves the new
reviewtool from Pretty Diff to Review Patch.
- attachment.cgi:
- code-review.js:
- 9:06 PM Changeset in webkit [67834] by
-
- 10 edits in trunk
WebKit2 decidePolicyForNavigationAction should include mouse button information
<rdar://problem/8413165>
https://bugs.webkit.org/show_bug.cgi?id=46060
Reviewed by Anders Carlsson.
WebKit2:
- UIProcess/API/C/WKAPICast.h:
(WebKit::toRef):
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPolicyClient.cpp:
(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
- UIProcess/WebPolicyClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::findMouseEvent):
(WebKit::mouseButtonForNavigationAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
WebKitTools:
- MiniBrowser/mac/BrowserWindowController.m:
(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):
- 8:05 PM Changeset in webkit [67833] by
-
- 2 edits in trunk/BugsSite
2010-09-19 Adam Barth <abarth@webkit.org>
Review tool UI tweak. This patch lengthens the status bubbles so all
the bubble fit (even when they have numbers inside).
- PrettyPatch/PrettyPatch.rb:
- 7:41 PM Changeset in webkit [67832] by
-
- 2 edits in trunk/WebKitTools
2010-09-19 Daniel Bates <dbates@rim.com>
Reviewed by Martin Robinson.
Add unit tests for diffs that delete or modify a change log entry
or describe changes that are far apart
https://bugs.webkit.org/show_bug.cgi?id=46046
Add additional unit tests to test change log diffs that contain
deletions or changes that are far apart from each other in the
ChangeLog file.
- Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
- Added the following unit tests: "fixChangeLogPatch: [no change] In-place change." "fixChangeLogPatch: [no change] Remove first entry." "fixChangeLogPatch: [no change] Remove entry in the middle." "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
- 7:27 PM Changeset in webkit [67831] by
-
- 12 edits in trunk
2010-09-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67749.
http://trac.webkit.org/changeset/67749
https://bugs.webkit.org/show_bug.cgi?id=46068
breaking ToT chromium canary build (Requested by shans on
#webkit).
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::registeredExtensionWithV8): (WebCore::V8Proxy::registerExtension):
- bindings/v8/V8Proxy.h:
- loader/EmptyClients.h:
- loader/FrameLoaderClient.h:
2010-09-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67749.
http://trac.webkit.org/changeset/67749
https://bugs.webkit.org/show_bug.cgi?id=46068
breaking ToT chromium canary build (Requested by shans on
#webkit).
- public/WebFrameClient.h:
- public/WebScriptController.h:
- src/FrameLoaderClientImpl.cpp:
- src/FrameLoaderClientImpl.h:
- src/WebScriptController.cpp: (WebKit::WebScriptController::registerExtension):
- 7:00 PM Changeset in webkit [67830] by
-
- 1 edit16 moves in trunk/LayoutTests
2010-09-19 Dimitri Glazkov <Dimitri Glazkov>
Move win-xp-specific baselines to their proper places.
- platform/chromium-win-xp/fast/forms/search-styled-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/forms/search-styled-expected.txt.
- platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/backslash-to-yen-sign-expected.checksum.
- platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/backslash-to-yen-sign-expected.png.
- platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/backslash-to-yen-sign-expected.txt.
- platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.checksum.
- platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.png.
- platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.txt.
- platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-whitespace-expected.checksum.
- platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-whitespace-expected.png.
- platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-whitespace-expected.txt.
- platform/chromium-win-xp/fast/text/international/plane2-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/international/plane2-expected.checksum.
- platform/chromium-win-xp/fast/text/international/plane2-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/international/plane2-expected.png.
- platform/chromium-win-xp/fast/text/international/plane2-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/international/plane2-expected.txt.
- platform/chromium-win-xp/svg/text/text-intro-05-t-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/text/text-intro-05-t-expected.checksum.
- platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png: Renamed from LayoutTests/platform/chromium-win/svg/text/text-intro-05-t-expected.png.
- platform/chromium-win-xp/svg/text/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/chromium-win/svg/text/text-intro-05-t-expected.txt.
- 6:59 PM Changeset in webkit [67829] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix pt 2.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 6:52 PM Changeset in webkit [67828] by
-
- 3 edits2 deletes in trunk/LayoutTests
2010-09-19 Mihai Parparita <mihaip@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] userscripts/user-script-top-frame-only.html has incorrect expectations
https://bugs.webkit.org/show_bug.cgi?id=46064
r62958 added incorrect expectations for this test. Chromium DRT actually
gets this test right if we let it use the base expectations file. Mark
the test as failing with test_shell only.
- platform/chromium-mac/userscripts/user-script-top-frame-only-expected.txt: Removed.
- platform/chromium-win/userscripts/user-script-top-frame-only-expected.txt: Removed.
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
- 6:43 PM Changeset in webkit [67827] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix pt 1.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 6:35 PM Changeset in webkit [67826] by
-
- 2 edits in trunk/JavaScriptCore
Build fix - implicit double-to-int conversion invalid on 32-bit.
- runtime/DatePrototype.cpp:
(JSC::fillStructuresUsingDateArgs):
(JSC::dateProtoFuncSetYear):
- 6:23 PM Changeset in webkit [67825] by
-
- 12 edits3 adds in trunk
Bug 46065 - Unify implementation of ToInt32 and ToUInt32, don't use fmod.
Reviewed by Oliver Hunt.
These methods implement the same conversion (see discussion in the notes
of sections of 9.5 and 9.6 of the spec), only differing in how the result
is interpretted.
Date prototype is incorrectly using toInt32, and this is causing us to
provide an output value indicating whether the input to ToInt32 was finite
(the corresponding methods on Date are actually spec'ed to use ToInteger,
not ToInt32). This patch partially fixes this in order to remove this
bogus output value, hoewever more work will be require to bring Date
fully up to spec compliance (the constructor is still performing ToInt32
conversions).
- JavaScriptCore.exp:
- runtime/DatePrototype.cpp:
(JSC::fillStructuresUsingTimeArgs):
(JSC::fillStructuresUsingDateArgs):
(JSC::dateProtoFuncSetYear):
- runtime/JSValue.cpp:
(JSC::toInt32):
- runtime/JSValue.h:
(JSC::toUInt32):
(JSC::JSValue::toInt32):
(JSC::JSValue::toUInt32):
WebCore:
Removing JSValue::toInt32 (since this has weird, non-spec function).
A couple of places in the binding are using this method, so adding
finiteInt32Value to the bindings to maintain current behaviour.
Test: fast/js/toInt32UInt32.html
- bindings/js/JSDOMBinding.h:
(WebCore::finiteInt32Value):
- bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::JSHTMLOptionsCollection::add):
- bindings/js/JSSQLResultSetRowListCustom.cpp:
(WebCore::JSSQLResultSetRowList::item):
- bindings/js/JSSVGPODListCustom.h:
(WebCore::JSSVGPODListCustom::getItem):
(WebCore::JSSVGPODListCustom::insertItemBefore):
(WebCore::JSSVGPODListCustom::replaceItem):
(WebCore::JSSVGPODListCustom::removeItem):
- bindings/js/JSSVGPathSegListCustom.cpp:
(WebCore::JSSVGPathSegList::getItem):
(WebCore::JSSVGPathSegList::insertItemBefore):
(WebCore::JSSVGPathSegList::replaceItem):
(WebCore::JSSVGPathSegList::removeItem):
LayoutTests:
Add test cases for ToInt32 / ToUInt32 functionality.
- fast/js/script-tests/toInt32UInt32.js: Added.
- fast/js/toInt32UInt32-expected.txt: Added.
- fast/js/toInt32UInt32.html: Added.
- 4:45 PM Changeset in webkit [67824] by
-
- 1 edit2 moves2 deletes in trunk/LayoutTests
2010-09-19 Dimitri Glazkov <Dimitri Glazkov>
Fix up expectation sadness I introduced in http://trac.webkit.org/changeset/67822, because no sadness is allowed.
- platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.checksum: Renamed from LayoutTests/platform/chromium-win-vista/css2.1/t1202-counter-09-b-checksum.png.
- platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.checksum: Renamed from LayoutTests/platform/chromium-win-vista/css2.1/t1202-counters-09-b-checksum.png.
- platform/chromium-win-xp/svg/batik/text/textFeatures-expected.checksum: Removed.
- platform/chromium-win-xp/svg/batik/text/textFeatures-expected.png: Removed.
- 3:46 PM Changeset in webkit [67823] by
-
- 3 edits1 add in trunk/LayoutTests
2010-09-19 Dimitri Glazkov <Dimitri Glazkov>
Create one more text baseline for win-vista.
- platform/chromium-win-vista/fast/forms/search-styled-expected.txt: Added.
- platform/chromium/drt_expectations.txt: Removed search-styled as it's now passing.
- platform/chromium/test_expectations.txt: Removed an errant line break.
- 3:31 PM Changeset in webkit [67822] by
-
- 6 edits20 adds2 deletes in trunk/LayoutTests
2010-09-19 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
Update win-vista baselines for Chromium to make a few more tests pass.
https://bugs.webkit.org/show_bug.cgi?id=46056
- platform/chromium-win-vista/css2.1/t1202-counter-09-b-checksum.png: Added.
- platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.png: Added.
- platform/chromium-win-vista/css2.1/t1202-counters-09-b-checksum.png: Added.
- platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.png: Added.
- platform/chromium-win-vista/fast/text/atsui-spacing-features-expected.checksum:
- platform/chromium-win-vista/fast/text/atsui-spacing-features-expected.png:
- platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.checksum: Added.
- platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.png: Added.
- platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.txt: Added.
- platform/chromium-win-vista/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
- platform/chromium-win-vista/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
- platform/chromium-win-vista/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
- platform/chromium-win-vista/fast/text/international/hindi-spacing-expected.checksum: Added.
- platform/chromium-win-vista/fast/text/international/hindi-spacing-expected.png: Added.
- platform/chromium-win-vista/fast/text/international/hindi-whitespace-expected.checksum: Added.
- platform/chromium-win-vista/fast/text/international/hindi-whitespace-expected.png: Added.
- platform/chromium-win-vista/fast/text/international/plane2-expected.checksum: Added.
- platform/chromium-win-vista/fast/text/international/plane2-expected.png: Added.
- platform/chromium-win-vista/fast/text/international/plane2-expected.txt: Added.
- platform/chromium-win-vista/svg/batik/text/textFeatures-expected.checksum: Removed.
- platform/chromium-win-vista/svg/batik/text/textFeatures-expected.png: Removed.
- platform/chromium-win-vista/svg/batik/text/verticalText-expected.checksum:
- platform/chromium-win-vista/svg/batik/text/verticalText-expected.png:
- platform/chromium-win-vista/svg/text/text-intro-05-t-expected.checksum: Added.
- platform/chromium-win-vista/svg/text/text-intro-05-t-expected.png: Added.
- platform/chromium/drt_expectations.txt: Removed expectations of failure, also added more info on remaining Windows failures.
- 3:09 PM Changeset in webkit [67821] by
-
- 2 edits in trunk/LayoutTests
2010-09-19 Adam Barth <abarth@webkit.org>
Turns out these still fail.
- platform/chromium/test_expectations.txt:
- 2:57 PM Changeset in webkit [67820] by
-
- 2 edits in trunk/LayoutTests
2010-09-19 Adam Barth <abarth@webkit.org>
These tests now pass. Go team.
- platform/chromium/test_expectations.txt:
- 2:14 PM Changeset in webkit [67819] by
-
- 2 edits in trunk/WebCore
2010-09-19 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] clipBoundingRect() should return rect relevant to current layer
https://bugs.webkit.org/show_bug.cgi?id=46059
r65791 inadvertently changed clipBoundingRect() to always use the GC painter
without checking the TransparencyLayer stack first.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::p): (WebCore::GraphicsContextPlatformPrivate::clipBoundingRect):
- 2:10 PM Changeset in webkit [67818] by
-
- 3 edits in trunk/WebCore
Replace WKBundleRangeRef with WKBundleRangeHandleRef.
https://bugs.webkit.org/show_bug.cgi?id=46054
Reviewed by Anders Carlsson.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- 2:08 PM Changeset in webkit [67817] by
-
- 3 edits in trunk/LayoutTests
2010-09-19 Adam Barth <abarth@webkit.org>
Also update mac-leopard and mac-tiger.
See https://bugs.webkit.org/show_bug.cgi?id=46042
- platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
- platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
- 12:54 PM Changeset in webkit [67816] by
-
- 3 edits in trunk/WebCore
2010-09-19 Patrick Gansterer <paroga@paroga.com>
Unreviewed.
[WINCE] Buildfix for Gradient after r67801.
- platform/graphics/Gradient.h:
- platform/graphics/wince/GradientWinCE.cpp: (WebCore::Gradient::getStops):
- 11:25 AM Changeset in webkit [67815] by
-
- 2 edits in trunk/WebKit2
[Qt] Unreviewed buildfix after r67813.
Replace WKBundleRangeRef with WKBundleRangeHandleRef.
https://bugs.webkit.org/show_bug.cgi?id=46054
- DerivedSources.pro: Add WebCore/generated/JSRange.h to WEBCORE_GENERATED_HEADERS_FOR_WEBKIT2
- 10:47 AM Changeset in webkit [67814] by
-
- 2 edits in trunk/WebKit2
[Qt] Unreviewed buildfix after r67802.
WebKit2: Improve/unify the PageLoadClient interfaces.
https://bugs.webkit.org/show_bug.cgi?id=46043
- UIProcess/API/qt/ClientImpl.h:
- 10:40 AM Changeset in webkit [67813] by
-
- 19 edits4 adds2 deletes in trunk
Replace WKBundleRangeRef with WKBundleRangeHandleRef.
https://bugs.webkit.org/show_bug.cgi?id=46054
Reviewed by Anders Carlsson.
The new one acts like WKBundleNodeHandleRef and allows for getting a
wrapper in a specific world for the handle.
WebKit2:
- Shared/APIObject.h:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
- WebProcess/InjectedBundle/API/c/WKBundleBase.h:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameGetJavaScriptWrapperForRangeForWorld):
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/API/c/WKBundleRange.cpp: Removed.
- WebProcess/InjectedBundle/API/c/WKBundleRange.h: Removed.
- WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp: Added.
(WKBundleRangeHandleGetTypeID):
- WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.h: Added.
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::getOrCreate):
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp: Added.
(WebKit::domHandleCache):
(WebKit::InjectedBundleRangeHandle::getOrCreate):
(WebKit::InjectedBundleRangeHandle::create):
(WebKit::InjectedBundleRangeHandle::InjectedBundleRangeHandle):
(WebKit::InjectedBundleRangeHandle::~InjectedBundleRangeHandle):
(WebKit::InjectedBundleRangeHandle::coreRange):
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h: Added.
(WebKit::InjectedBundleRangeHandle::type):
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
(WebKit::InjectedBundlePageEditorClient::shouldBeginEditing):
(WebKit::InjectedBundlePageEditorClient::shouldEndEditing):
(WebKit::InjectedBundlePageEditorClient::shouldInsertNode):
(WebKit::InjectedBundlePageEditorClient::shouldInsertText):
(WebKit::InjectedBundlePageEditorClient::shouldDeleteRange):
(WebKit::InjectedBundlePageEditorClient::shouldChangeSelectedRange):
(WebKit::InjectedBundlePageEditorClient::shouldApplyStyle):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::jsWrapperForWorld):
- WebProcess/WebPage/WebFrame.h:
- win/WebKit2.vcproj:
- win/WebKit2Generated.make:
WebKitTools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::propertyValue):
(WTR::propertyValueDouble):
(WTR::propertyValueInt):
(WTR::numericWindowPropertyValue):
(WTR::toStr):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- 10:37 AM Changeset in webkit [67812] by
-
- 2 edits in trunk/BugsSite
Fixed a typo.
Reviewed by Anders Carlsson.
- code-review.js: Changed the label of the OK button from Ok to OK.
- 6:31 AM Changeset in webkit [67811] by
-
- 5 edits in trunk
2010-09-19 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Add is<input type>() functions to WebInputElement
https://bugs.webkit.org/show_bug.cgi?id=46035
- html/HTMLInputElement.h: (WebCore::HTMLInputElement::isText): Added. It is used by WebKit/chromium.
2010-09-19 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Add is<input type>() functions to WebInputElement
https://bugs.webkit.org/show_bug.cgi?id=46035
We're going to stop exposing HTMLInputElemnt::InputType. So, add
isFoo() functions in order to remove WebInputElement::InputType.
- public/WebInputElement.h:
- src/WebInputElement.cpp: (WebKit::WebInputElement::isTextField): (WebKit::WebInputElement::isText): (WebKit::WebInputElement::isPasswordField): (WebKit::WebInputElement::isImageButton):
- 6:30 AM Changeset in webkit [67810] by
-
- 2 edits in trunk/WebKitTools
2010-09-19 Kent Tamura <tkent@chromium.org>
Unreviewed. Fix WebGL test regressions by r67809.
- DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
- 5:55 AM Changeset in webkit [67809] by
-
- 7 edits2 adds in trunk
2010-09-19 Kent Tamura <tkent@chromium.org>
Reviewed by Adam Barth.
[DRT/Chromium] Fix a WebSettings handling bug
https://bugs.webkit.org/show_bug.cgi?id=45945
- platform/chromium/drt_expectations.txt: Remove link-opens-new-window.html, which is fixed by this revision.
2010-09-19 Kent Tamura <tkent@chromium.org>
Reviewed by Adam Barth.
[DRT/Chromium] Fix a WebSettings handling bug
https://bugs.webkit.org/show_bug.cgi?id=45945
Before this change, Chromium DRT reset WebSettings for every new
window. It was wrong.
If new window is not the first one, we have to apply the same
settings as the first window. So, we introduce WebPreference to
store the current settings, and apply it to new windows. It's same
as test_shell's behavior.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/LayoutTestController.cpp: Use WebPreferences instead of WebSettings. (LayoutTestController::setUserStyleSheetEnabled): (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::setAuthorAndUserStylesEnabled): (LayoutTestController::setPopupBlockingEnabled): (LayoutTestController::disableImageLoading): (LayoutTestController::setJavaScriptCanAccessClipboard): (LayoutTestController::setXSSAuditorEnabled): (LayoutTestController::setAllowUniversalAccessFromFileURLs): (LayoutTestController::setAllowFileAccessFromFileURLs): (LayoutTestController::overridePreference): (LayoutTestController::setEditingBehavior):
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings): Use WebPreferences. (TestShell::runFileTest): ditto. (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
- DumpRenderTree/chromium/TestShell.h: (TestShell::preferences): (TestShell::applyPreferences):
- DumpRenderTree/chromium/WebPreferences.cpp: Added.
- DumpRenderTree/chromium/WebPreferences.h: Added.
Sep 18, 2010:
- 8:12 PM Changeset in webkit [67808] by
-
- 3 edits in trunk/WebCore
2010-09-18 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Antonio Gomes.
[Qt] Path: Remove unused member variable
https://bugs.webkit.org/show_bug.cgi?id=46048
Path::m_lastMoveToIndex is not used for anything, so remove it.
- platform/graphics/Path.h:
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::Path): (WebCore::Path::operator=): (WebCore::Path::moveTo):
- 8:01 PM Changeset in webkit [67807] by
-
- 3 edits in trunk/WebCore
2010-09-18 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
Use AtomicString insted of String in XMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=45990
Create AtomicString as early as possible.
This can avoid unnecessary memcpy of String content.
- dom/XMLDocumentParser.h:
- dom/XMLDocumentParserLibxml2.cpp: (WebCore::toAtomicString): (WebCore::handleElementNamespaces): (WebCore::handleElementAttributes): (WebCore::XMLDocumentParser::startElementNs):
- 6:21 PM Changeset in webkit [67806] by
-
- 2 edits in trunk/WebKitTools
2010-09-18 Prasad Tammana <prasadt@chromium.org>
Reviewed by David Levin.
update-webkit --chromium spitting out a spurious error
https://bugs.webkit.org/show_bug.cgi?id=45868
- Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
- 6:05 PM Changeset in webkit [67805] by
-
- 7 edits in trunk
2010-09-18 Erik Arvidsson <arv@chromium.org>
Reviewed by Nate Chapin.
[Chromium] fast/dom/dataset-gc.html is failing
https://bugs.webkit.org/show_bug.cgi?id=45426
- platform/chromium/test_expectations.txt:
2010-09-18 Erik Arvidsson <arv@chromium.org>
Reviewed by Nate Chapin.
[Chromium] fast/dom/dataset-gc.html is failing
https://bugs.webkit.org/show_bug.cgi?id=45426
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/custom/V8DOMStringMapCustom.cpp: (WebCore::toV8):
- dom/DOMStringMap.h:
- dom/DatasetDOMStringMap.h: (WebCore::DatasetDOMStringMap::element):
- 5:52 PM Changeset in webkit [67804] by
-
- 2 edits in trunk/WebCore
2010-09-18 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Oliver Hunt.
Gradient: Fast-path for the ideal case in sortStopsIfNecessary()
https://bugs.webkit.org/show_bug.cgi?id=46045
Avoid calling std::stable_sort for 2-stop gradients that are already in order.
- platform/graphics/Gradient.cpp: (WebCore::Gradient::sortStopsIfNecessary):
- 5:46 PM Changeset in webkit [67803] by
-
- 2 edits in trunk/WebCore
2010-09-18 Kwang Yul Seo <skyul@company100.net>
Reviewed by Andreas Kling.
[BREWMP] Fix a typo in key code name
https://bugs.webkit.org/show_bug.cgi?id=46003
AVK_CLR is the right Brew MP key code name for VK_BACK.
- platform/brew/PlatformKeyboardEventBrew.cpp: (WebCore::windowsKeyCodeForKeyEvent):
- 5:30 PM Changeset in webkit [67802] by
-
- 17 edits in trunk
WebKit2: Improve/unify the PageLoadClient interfaces.
https://bugs.webkit.org/show_bug.cgi?id=46043
Reviewed by Dan Bernstein.
- Ensure that all the PageLoadClient functions (that are load related) have bundle API equivalents (this meant adding didFirstLayoutForFrame and didFirstVisuallyNonEmptyLayoutForFrame to the BundlePageLoadClient).
- Add a userData out parameters to all the now paired BundlePageLoadClient functions, and a matching userData parameter to the PageLoadClient ones.
- UIProcess/API/C/WKPage.h:
- UIProcess/API/qt/ClientImpl.cpp:
(qt_wk_didStartProvisionalLoadForFrame):
(qt_wk_didReceiveServerRedirectForProvisionalLoadForFrame):
(qt_wk_didFailProvisionalLoadWithErrorForFrame):
(qt_wk_didCommitLoadForFrame):
(qt_wk_didFinishDocumentLoadForFrame):
(qt_wk_didFinishLoadForFrame):
(qt_wk_didFailLoadWithErrorForFrame):
(qt_wk_didReceiveTitleForFrame):
(qt_wk_didFirstLayoutForFrame):
(qt_wk_didFirstVisuallyNonEmptyLayoutForFrame):
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didStartProvisionalLoadForFrame):
(WebKit::WebLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::WebLoaderClient::didCommitLoadForFrame):
(WebKit::WebLoaderClient::didFinishDocumentLoadForFrame):
(WebKit::WebLoaderClient::didFinishLoadForFrame):
(WebKit::WebLoaderClient::didFailLoadWithErrorForFrame):
(WebKit::WebLoaderClient::didReceiveTitleForFrame):
(WebKit::WebLoaderClient::didFirstLayoutForFrame):
(WebKit::WebLoaderClient::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::WebLoaderClient::didStartProgress):
(WebKit::WebLoaderClient::didChangeProgress):
(WebKit::WebLoaderClient::didFinishProgress):
(WebKit::WebLoaderClient::didBecomeUnresponsive):
(WebKit::WebLoaderClient::didBecomeResponsive):
(WebKit::WebLoaderClient::processDidExit):
(WebKit::WebLoaderClient::didChangeBackForwardList):
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::didFinishDocumentLoadForFrame):
(WebKit::WebPageProxy::didFinishLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
(WebKit::WebPageProxy::didReceiveTitleForFrame):
(WebKit::WebPageProxy::didFirstLayoutForFrame):
(WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame):
- UIProcess/WebPageProxy.h:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didStartProvisionalLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didCommitLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishDocumentLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFailLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didReceiveTitleForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFirstLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didClearWindowObjectForFrame):
(WebKit::InjectedBundlePageLoaderClient::didCancelClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::willPerformClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::didChangeLocationWithinPageForFrame):
(WebKit::InjectedBundlePageLoaderClient::didHandleOnloadEventsForFrame):
(WebKit::InjectedBundlePageLoaderClient::didDisplayInsecureContentForFrame):
(WebKit::InjectedBundlePageLoaderClient::didRunInsecureContentForFrame):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle):
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout):
(WebKit::WebFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
WebKitTools: Improve/unify the PageLoadClient interfaces
https://bugs.webkit.org/show_bug.cgi?id=46043
Reviewed by Dan Bernstein.
- MiniBrowser/mac/BrowserWindowController.m:
(didStartProvisionalLoadForFrame):
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didCommitLoadForFrame):
(didFinishDocumentLoadForFrame):
(didFinishLoadForFrame):
(didFailLoadWithErrorForFrame):
(didReceiveTitleForFrame):
(didFirstLayoutForFrame):
(didFirstVisuallyNonEmptyLayoutForFrame):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didCommitLoadForFrame):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveMessageFromInjectedBundle):
(WTR::TestController::didFinishLoadForFrame):
- WebKitTestRunner/TestController.h:
- 5:23 PM Changeset in webkit [67801] by
-
- 2 edits in trunk/WebCore
2010-09-18 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Oliver Hunt.
Gradient: Pre-reserve space for 2 color stops
https://bugs.webkit.org/show_bug.cgi?id=46044
Most gradients have only 2 color stops, pre-reserve space for these in m_stops
to avoid growing the vector dynamically in the common case.
- platform/graphics/Gradient.h:
- 4:54 PM Changeset in webkit [67800] by
-
- 2 edits in trunk/LayoutTests
2010-09-18 Adam Barth <abarth@webkit.org>
Also update the snow-leopard result.
- platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
- 4:48 PM Changeset in webkit [67799] by
-
- 4 edits4 deletes in trunk
2010-09-18 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, rolling out r67792.
http://trac.webkit.org/changeset/67792
https://bugs.webkit.org/show_bug.cgi?id=45976
Broke over a hundred SVG tests.
- canvas/philip/tests/2d.drawImage.negativeOneDest-expected.txt: Removed.
- canvas/philip/tests/2d.drawImage.negativeOneDest.html: Removed.
- canvas/philip/tests/2d.drawImage.negativeOneSource-expected.txt: Removed.
- canvas/philip/tests/2d.drawImage.negativeOneSource.html: Removed.
2010-09-18 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, rolling out r67792.
http://trac.webkit.org/changeset/67792
https://bugs.webkit.org/show_bug.cgi?id=45976
Broke over a hundred SVG tests.
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawImageBuffer):
- platform/graphics/GraphicsContext.h:
- 4:28 PM Changeset in webkit [67798] by
-
- 3 edits in trunk/LayoutTests
2010-09-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
file-url-mimetypes-2.html fails on my Snow Leopard box
https://bugs.webkit.org/show_bug.cgi?id=46042
This line of this test seems to depend on something besides WebKit. It
fails on my Snow Leopard box because it reports text/plain instead of
postscript. This is blocking me from running a commit-cluster machine
on my box.
- platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
- platform/mac/fast/loader/file-url-mimetypes-2.html:
- 4:02 PM Changeset in webkit [67797] by
-
- 3 edits2 adds in trunk
2010-09-18 Mihai Parparita <mihaip@chromium.org>
Reviewed by Simon Fraser.
webkitAnimationEnd event doesn't fire when skipping over final iteration
https://bugs.webkit.org/show_bug.cgi?id=46010
Add a test with a short enough animation interval (0.001s) that we
appear to always skip the second iteration.
- animations/animation-end-event-short-iterations-expected.txt: Added.
- animations/animation-end-event-short-iterations.html: Added.
2010-09-18 Mihai Parparita <mihaip@chromium.org>
Reviewed by Simon Fraser.
webkitAnimationEnd event doesn't fire when skipping over final iteration
https://bugs.webkit.org/show_bug.cgi?id=46010
It's possible for AnimationBase::fireAnimationEventsIfNeeded to decide
that the animation is ended while we're in the looping state, if the
animation timer never fires during an iteration. That then fails the
assert in AnimationBase::updateStateMachine (we don't expect
AnimationStateInputEndTimerFired while in the looping state). Jump the
state to AnimationStateEnding, which is more accurate.
Test: animations/animation-end-event-short-iterations.html
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
- 4:02 PM Changeset in webkit [67796] by
-
- 2 edits in trunk/JavaScriptCore
First step in fixing Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Removed incorrect symbol. The build will probably still fail,
but the failure will tell us what symbol to add.
- 3:52 PM Changeset in webkit [67795] by
-
- 2 edits in trunk
[wx] Build fix, fix use of wrong case in name.
- 3:48 PM Changeset in webkit [67794] by
-
- 2 edits in trunk/WebCore
2010-09-18 Kwang Yul Seo <skyul@company100.net>
Reviewed by Andreas Kling.
[BREWMP] Wrong key code type in keyIdentifierForBrewKeyCode
https://bugs.webkit.org/show_bug.cgi?id=46005
The type of key code in Brew MP is uint16. Take uint16 instead of int16 in keyIdentifierForBrewKeyCode.
- platform/brew/PlatformKeyboardEventBrew.cpp: (WebCore::keyIdentifierForBrewKeyCode):
- 3:43 PM Changeset in webkit [67793] by
-
- 2 edits in trunk/LayoutTests
2010-09-17 Mihai Parparita <mihaip@chromium.org>
Reviewed by James Robinson.
Remove passing animation tests from Chromium's test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=45996
Update Chromium test_expectations.txt to remove tests that now pass:
animations/animation-shorthand-removed.html, animations/
animation-shorthand.html, and transitions/inherit-other-props.html were
fixed by http://trac.webkit.org/changeset/67634.
transforms/2d/transform-value-types.html has not failed in the last
1,500 runs.
animations/animation-drt-api.html was most likely fixed by 66641 (it
hasn't failed in the last 1,500 runs either).
- platform/chromium/test_expectations.txt:
- 2:47 PM Changeset in webkit [67792] by
-
- 4 edits4 adds in trunk
2010-09-18 Matthew Delaney <mdelaney@apple.com>
Reviewed by Oliver Hunt.
Canvas drawImage with source or destination widths/heights of -1 renders incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=45976
- canvas/philip/tests/2d.drawImage.negativeOneDest-expected.txt: Added.
- canvas/philip/tests/2d.drawImage.negativeOneDest.html: Added. Tests that using -1 for the destination width/height renders correctly.
- canvas/philip/tests/2d.drawImage.negativeOneSource-expected.txt: Added.
- canvas/philip/tests/2d.drawImage.negativeOneSource.html: Added. Tests that using -1 for the source width/height renders correctly.
2010-09-18 Matthew Delaney <mdelaney@apple.com>
Reviewed by Oliver Hunt.
Canvas drawImage with source or destination widths/heights of -1 renders incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=45976
Specifying a -1 width or height for either the source or destination rectangle in drawImage
get improperly drawn with -1 replaced as the corresponding image width or height. This was because
the value -1 was being passed around to signal non-specified widths and heights and thus was
interpreted lower down in the drawImage implementation which disallowed any calls that actually
wanted to use -1 as the widths or heights. Fixed this by moving the default logic up and not using
-1 in-band signaling to denote default behavior.
Tests: canvas/philip/tests/2d.drawImage.negativeOneDest.html
canvas/philip/tests/2d.drawImage.negativeOneSource.html
- platform/graphics/GraphicsContext.cpp: Removed -1 in-band signals and replaced cascased calls to have the desired replaces for unspecified widths and heights earlier on.
- platform/graphics/GraphicsContext.h: Removed faulty default value.
- 2:30 PM Changeset in webkit [67791] by
-
- 1 edit1 add in trunk/WebKitTools
2010-09-17 Eric Seidel <eric@webkit.org>
Unreviewed. Adding a shell script I use to run the
commit-queue. Now that multiple machines run the cq,
it makes sense to share the script between them.
- EWSTools/start-commit-queue.sh: Added.
- 2:04 PM Changeset in webkit [67790] by
-
- 5 edits3 adds in trunk
2010-09-18 Michael Saboff <msaboff@apple.com>
Reviewed by Gavin Barraclough.
Added code to unroll regular expressions containing .
Alternatives that begin with are tagged during parsing
and rolled up in containing sub expression structs.
After parsing, a regular expression flagged as containing
a (a.k.a. BOL) is processed further in optimizeBOL().
A copy of the disjunction is made excluding alternatives that
are rooted with BOL. The original alternatives are flagged
to only be executed once. The copy of the other alternatives are
added to the original expression.
In the case that all original alternatives are flagged, there
won't be any looping alternatives.
The JIT generator will emit code accordingly, executing the
original alternatives once and then looping over the
alternatives that aren't anchored with a BOL (if any).
https://bugs.webkit.org/show_bug.cgi?id=45787
- yarr/RegexCompiler.cpp: (JSC::Yarr::RegexPatternConstructor::assertionBOL): (JSC::Yarr::RegexPatternConstructor::atomParenthesesEnd): (JSC::Yarr::RegexPatternConstructor::copyDisjunction): (JSC::Yarr::RegexPatternConstructor::copyTerm): (JSC::Yarr::RegexPatternConstructor::optimizeBOL): (JSC::Yarr::compileRegex):
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateDisjunction):
- yarr/RegexPattern.h: (JSC::Yarr::PatternAlternative::PatternAlternative): (JSC::Yarr::PatternAlternative::setOnceThrough): (JSC::Yarr::PatternAlternative::onceThrough): (JSC::Yarr::PatternDisjunction::PatternDisjunction): (JSC::Yarr::RegexPattern::RegexPattern): (JSC::Yarr::RegexPattern::reset):
2010-09-18 Michael Saboff <msaboff@apple.com>
Reviewed by Gavin Barraclough.
Added new tests to check for proper handling of in multiline
regular expressions. Added as part of
https://bugs.webkit.org/show_bug.cgi?id=45787
- fast/js/regexp-bol-with-multiline-expected.txt: Added.
- fast/js/regexp-bol-with-multiline.html: Added.
- fast/js/script-tests/regexp-bol-with-multiline.js: Added.
- 1:52 PM Changeset in webkit [67789] by
-
- 1 edit4 deletes in trunk/LayoutTests
2010-09-18 Dimitri Glazkov <Dimitri Glazkov>
Remove duplicate expectations from platform/chromium-win-xp.
- platform/chromium-win-xp/css2.1/t1202-counter-09-b-expected.checksum: Removed.
- platform/chromium-win-xp/css2.1/t1202-counter-09-b-expected.png: Removed.
- platform/chromium-win-xp/css2.1/t1202-counters-09-b-expected.checksum: Removed.
- platform/chromium-win-xp/css2.1/t1202-counters-09-b-expected.png: Removed.
- 1:41 PM Changeset in webkit [67788] by
-
- 4 edits38 moves in trunk
2010-09-18 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
Rename Wince files to WinCE
https://bugs.webkit.org/show_bug.cgi?id=37287
- wtf/unicode/Unicode.h:
- wtf/unicode/wince/UnicodeWinCE.cpp: Copied from JavaScriptCore/wtf/unicode/wince/UnicodeWince.cpp.
- wtf/unicode/wince/UnicodeWinCE.h: Copied from JavaScriptCore/wtf/unicode/wince/UnicodeWince.h.
- wtf/unicode/wince/UnicodeWince.cpp: Removed.
- wtf/unicode/wince/UnicodeWince.h: Removed.
- wtf/wince/FastMallocWinCE.h: Copied from JavaScriptCore/wtf/wince/FastMallocWince.h.
- wtf/wince/FastMallocWince.h: Removed.
2010-09-18 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Kenneth Rohde Christiansen.
Enable Platform Strategies on Qt
[Qt] Turn on PLATFORM_STRATEGIES
https://bugs.webkit.org/show_bug.cgi?id=45831
- WebCore.pro: Adding/removing implementation files
- platform/qt/Language.cpp: Added, WebCore::defaultLanguage() was moved from platform/qt/Localizations.cpp (WebCore::defaultLanguage): Moved from Localizations.cpp
- platform/qt/Localizations.cpp: Removed (code is now inside WebCoreSupport/WebPlatformStrategies.cpp)
- plugins/qt/PluginDataQt.cpp: Removed (idem)
- 1:15 PM Changeset in webkit [67787] by
-
- 8 edits1 move2 adds1 delete in trunk
2010-09-18 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Kenneth Rohde Christiansen.
Enable Platform Strategies on Qt
[Qt] Turn on PLATFORM_STRATEGIES
https://bugs.webkit.org/show_bug.cgi?id=45831
- wtf/Platform.h: Enable Platform Strategies when building QtWebkit
2010-09-18 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Kenneth Rohde Christiansen.
Enable Platform Strategies on Qt
[Qt] Turn on PLATFORM_STRATEGIES
https://bugs.webkit.org/show_bug.cgi?id=45831
- WebCore.pro: Adding/removing implementation files
- platform/qt/Language.cpp: Added, WebCore::defaultLanguage() was moved from platform/qt/Localizations.cpp (WebCore::defaultLanguage): Moved from Localizations.cpp
- platform/qt/Localizations.cpp: Removed (code is now inside WebCoreSupport/WebPlatformStrategies.cpp)
- plugins/qt/PluginDataQt.cpp: Removed (idem)
2010-09-18 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Kenneth Rohde Christiansen.
Enable Platform Strategies on Qt
[Qt] Turn on PLATFORM_STRATEGIES
https://bugs.webkit.org/show_bug.cgi?id=45831
- Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): Initialize the PlatformStrategy singleton.
- WebCoreSupport/WebPlatformStrategies.cpp: Added, code was moved from platform/qt/Localizations.cpp and plugins/qt/PluginDataQt.cpp (WebPlatformStrategies::initialize): create the singleton, following the same "pattern" used by Mac and Win ports. (WebPlatformStrategies::WebPlatformStrategies): (WebPlatformStrategies::createPluginStrategy): (WebPlatformStrategies::createLocalizationStrategy): (WebPlatformStrategies::createVisitedLinkStrategy): (WebPlatformStrategies::refreshPlugins): (WebPlatformStrategies::getPluginInfo): (WebPlatformStrategies::inputElementAltText): (WebPlatformStrategies::resetButtonDefaultLabel): (WebPlatformStrategies::searchableIndexIntroduction): (WebPlatformStrategies::submitButtonDefaultLabel): (WebPlatformStrategies::fileButtonChooseFileLabel): (WebPlatformStrategies::fileButtonNoFileSelectedLabel): (WebPlatformStrategies::contextMenuItemTagOpenLinkInNewWindow): (WebPlatformStrategies::contextMenuItemTagDownloadLinkToDisk): (WebPlatformStrategies::contextMenuItemTagCopyLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagOpenImageInNewWindow): (WebPlatformStrategies::contextMenuItemTagDownloadImageToDisk): (WebPlatformStrategies::contextMenuItemTagCopyImageToClipboard): (WebPlatformStrategies::contextMenuItemTagOpenFrameInNewWindow): (WebPlatformStrategies::contextMenuItemTagCopy): (WebPlatformStrategies::contextMenuItemTagGoBack): (WebPlatformStrategies::contextMenuItemTagGoForward): (WebPlatformStrategies::contextMenuItemTagStop): (WebPlatformStrategies::contextMenuItemTagReload): (WebPlatformStrategies::contextMenuItemTagCut): (WebPlatformStrategies::contextMenuItemTagPaste): (WebPlatformStrategies::contextMenuItemTagNoGuessesFound): (WebPlatformStrategies::contextMenuItemTagIgnoreSpelling): (WebPlatformStrategies::contextMenuItemTagLearnSpelling): (WebPlatformStrategies::contextMenuItemTagSearchWeb): (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): (WebPlatformStrategies::contextMenuItemTagOpenLink): (WebPlatformStrategies::contextMenuItemTagIgnoreGrammar): (WebPlatformStrategies::contextMenuItemTagSpellingMenu): (WebPlatformStrategies::contextMenuItemTagShowSpellingPanel): (WebPlatformStrategies::contextMenuItemTagCheckSpelling): (WebPlatformStrategies::contextMenuItemTagCheckSpellingWhileTyping): (WebPlatformStrategies::contextMenuItemTagCheckGrammarWithSpelling): (WebPlatformStrategies::contextMenuItemTagFontMenu): (WebPlatformStrategies::contextMenuItemTagBold): (WebPlatformStrategies::contextMenuItemTagItalic): (WebPlatformStrategies::contextMenuItemTagUnderline): (WebPlatformStrategies::contextMenuItemTagOutline): (WebPlatformStrategies::contextMenuItemTagWritingDirectionMenu): (WebPlatformStrategies::contextMenuItemTagTextDirectionMenu): (WebPlatformStrategies::contextMenuItemTagDefaultDirection): (WebPlatformStrategies::contextMenuItemTagLeftToRight): (WebPlatformStrategies::contextMenuItemTagRightToLeft): (WebPlatformStrategies::contextMenuItemTagInspectElement): (WebPlatformStrategies::searchMenuNoRecentSearchesText): (WebPlatformStrategies::searchMenuRecentSearchesText): (WebPlatformStrategies::searchMenuClearRecentSearchesText): (WebPlatformStrategies::AXWebAreaText): (WebPlatformStrategies::AXLinkText): (WebPlatformStrategies::AXListMarkerText): (WebPlatformStrategies::AXImageMapText): (WebPlatformStrategies::AXHeadingText): (WebPlatformStrategies::AXDefinitionListTermText): (WebPlatformStrategies::AXDefinitionListDefinitionText): (WebPlatformStrategies::AXButtonActionVerb): (WebPlatformStrategies::AXRadioButtonActionVerb): (WebPlatformStrategies::AXTextFieldActionVerb): (WebPlatformStrategies::AXCheckedCheckBoxActionVerb): (WebPlatformStrategies::AXUncheckedCheckBoxActionVerb): (WebPlatformStrategies::AXMenuListActionVerb): (WebPlatformStrategies::AXMenuListPopupActionVerb): (WebPlatformStrategies::AXLinkActionVerb): (WebPlatformStrategies::missingPluginText): (WebPlatformStrategies::crashedPluginText): (WebPlatformStrategies::multipleFileUploadText): (WebPlatformStrategies::unknownFileSizeText): (WebPlatformStrategies::imageTitle): (WebPlatformStrategies::mediaElementLoadingStateText): (WebPlatformStrategies::mediaElementLiveBroadcastStateText): (WebPlatformStrategies::localizedMediaControlElementString): (WebPlatformStrategies::localizedMediaControlElementHelpText): (WebPlatformStrategies::localizedMediaTimeDescription): (WebPlatformStrategies::validationMessageValueMissingText): (WebPlatformStrategies::validationMessageTypeMismatchText): (WebPlatformStrategies::validationMessagePatternMismatchText): (WebPlatformStrategies::validationMessageTooLongText): (WebPlatformStrategies::validationMessageRangeUnderflowText): (WebPlatformStrategies::validationMessageRangeOverflowText): (WebPlatformStrategies::validationMessageStepMismatchText): (WebPlatformStrategies::isLinkVisited): (WebPlatformStrategies::addVisitedLink):
- WebCoreSupport/WebPlatformStrategies.h: Added, based on Mac and Win versions.
2010-09-18 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Kenneth Rohde Christiansen.
Enable Platform Strategies on Qt
[Qt] Turn on PLATFORM_STRATEGIES
https://bugs.webkit.org/show_bug.cgi?id=45831
- WebKit2.pro: Added Added WebPlatformStrategies.{cpp,h}
- 12:33 PM Changeset in webkit [67786] by
-
- 2 edits in trunk/LayoutTests
2010-09-18 Mike Lawther <mikelawther@chromium.org>
Reviewed by Nate Chapin.
Remove passing tests from chromium test_expectations
https://bugs.webkit.org/show_bug.cgi?id=45948
Removes tests the flakiness dashboard shows as having passed for a couple of weeks
- 12:21 PM Changeset in webkit [67785] by
-
- 3 edits in trunk/WebCore
2010-09-18 Patrick Gansterer <paroga@paroga.com>
Reviewed by Eric Seidel.
Move Plugin*None.cpp from CMakeLists.txt into CMakeListsEfl.txt
https://bugs.webkit.org/show_bug.cgi?id=45900
PluginDataNone.cpp and PluginViewNone.cpp are not used by all port.
Move them into plaform sepcific build system.
- CMakeLists.txt:
- CMakeListsEfl.txt:
- 12:03 PM Changeset in webkit [67784] by
-
- 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css
2010-09-18 William Siegrist <wsiegrist@apple.com>
Increase alternating row contract in result viewer.
- 11:16 AM Changeset in webkit [67783] by
-
- 2 edits in trunk/LayoutTests
2010-09-18 Daniel Bates <dbates@rim.com>
Rubber-stamped by Sam Weinig.
REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863
Fix some minor, non-visual typos that do not affect the test result.
- fast/css/preserve-user-specified-zoom-level-on-reload.html:
- 10:44 AM Changeset in webkit [67782] by
-
- 2 edits in trunk/LayoutTests
2010-09-18 Mihai Parparita <mihaip@chromium.org>
Reviewed by Dirk Schulze.
fast/css/preserve-user-specified-zoom-level-on-reload.html does not clean up after itself
https://bugs.webkit.org/show_bug.cgi?id=46040
Delete the sessionStorage property that this test adds once it's complete.
Otherwise it fails when run with --iterations=2 and also causes a diff in
in fast/dom/prototype-inheritance-2.html (which runs after it).
- fast/css/preserve-user-specified-zoom-level-on-reload.html:
- 9:37 AM Changeset in webkit [67781] by
-
- 2 edits in trunk/WebKit/qt
2010-09-18 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Antonio Gomes.
[Qt] V8 port: Add FrameLoaderClientQt::allowScriptExtension()
https://bugs.webkit.org/show_bug.cgi?id=46034
r67749 added FrameLoaderClient::allowScriptExtension() (V8-specific)
Add a stub implementation that simply returns false for now.
- WebCoreSupport/FrameLoaderClientQt.h: (WebCore::FrameLoaderClientQt::allowScriptExtension):
- 8:23 AM Changeset in webkit [67780] by
-
- 2 edits in trunk/WebCore
2010-09-18 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Don't copy clip path to TransparencyLayer
https://bugs.webkit.org/show_bug.cgi?id=45965
We don't need to copy the GC's clip path to the TransparencyLayer since it will
clip anyway when ending the layer.
- platform/graphics/qt/TransparencyLayer.h: (WebCore::TransparencyLayer::TransparencyLayer):
- 6:55 AM Changeset in webkit [67779] by
-
- 2 edits in trunk/WebCore
2010-09-18 Patrick Gansterer <paroga@paroga.com>
Unreviewed.
[WINCE] Buildfix for FrameWince.cpp after r51353, r67762 and r67771.
- page/wince/FrameWince.cpp: (WebCore::computePageRectsForFrame): (WebCore::imageFromSelection):
- 5:19 AM Changeset in webkit [67778] by
-
- 2 edits in trunk/WebCore
2010-09-18 Kent Tamura <tkent@chromium.org>
Unreviewed, a trivial change.
Run sort-Xcode-project-file.
- WebCore.xcodeproj/project.pbxproj:
- 3:04 AM Changeset in webkit [67777] by
-
- 2 edits in trunk/WebCore
REGRESSION (r67762): Over 160 layout tests failing due to incorrect zoom factors in subframes
https://bugs.webkit.org/show_bug.cgi?id=46031
Reviewed by Eric Seidel.
- page/Frame.cpp:
(WebCore::parentPageZoomFactor): Return the zoom factor of the parent frame.
(WebCore::parentTextZoomFactor): Ditto.
Sep 17, 2010:
- 11:16 PM Changeset in webkit [67776] by
-
- 10 edits in trunk
Need a way to load data (as plain text) in a WKPage
<rdar://problem/8424239>
Reviewed by Jon Honeycutt.
WebCore:
- WebCore.exp.in:
WebKit2:
- Shared/CoreIPCSupport/WebPageMessageKinds.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageLoadHTMLString):
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadHTMLString):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadHTMLString):
(WebKit::WebPage::didReceiveMessage):
- WebProcess/WebPage/WebPage.h:
- 10:34 PM Changeset in webkit [67775] by
-
- 60 edits in trunk/WebKit2
Replace all uses of WTF::String and WTF::AtomicString with
String and AtomicString.
Rubber-stamped by Anders Carlsson.
- Platform/Module.h:
- Shared/CommandLine.h:
(WebKit::CommandLine::operator[]):
- Shared/WebCoreArgumentCoders.h:
- Shared/WebEvent.h:
(WebKit::WebKeyboardEvent::WebKeyboardEvent):
(WebKit::WebKeyboardEvent::text):
(WebKit::WebKeyboardEvent::unmodifiedText):
(WebKit::WebKeyboardEvent::keyIdentifier):
(WebKit::WebKeyboardEvent::decode):
- Shared/WebNavigationDataStore.h:
- Shared/WebPreferencesStore.h:
- Shared/WebString.h:
(WebKit::WebString::create):
(WebKit::WebString::string):
(WebKit::WebString::WebString):
- Shared/WebURL.h:
(WebKit::WebURL::create):
(WebKit::WebURL::string):
(WebKit::WebURL::WebURL):
- UIProcess/API/C/WKAPICast.h:
(WebKit::toRef):
(WebKit::toURLRef):
(WebKit::toCopiedRef):
(WebKit::toCopiedURLRef):
(WebKit::toWTFString):
- UIProcess/API/C/WKContext.cpp:
(WKContextCreate):
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::nsStringFromWebCoreString):
- UIProcess/PageClient.h:
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::setAdditionalPluginsDirectories):
- UIProcess/Plugins/PluginInfoStore.h:
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::getPluginInfo):
(WebKit::PluginInfoStore::getMIMETypeForExtension):
- UIProcess/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::create):
(WebKit::WebBackForwardListItem::setOriginalURL):
(WebKit::WebBackForwardListItem::originalURL):
(WebKit::WebBackForwardListItem::setURL):
(WebKit::WebBackForwardListItem::url):
(WebKit::WebBackForwardListItem::setTitle):
(WebKit::WebBackForwardListItem::title):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::setAdditionalPluginsDirectory):
- UIProcess/WebContext.h:
(WebKit::WebContext::injectedBundlePath):
- UIProcess/WebContextInjectedBundleClient.h:
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didReceiveTitle):
- UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::url):
(WebKit::WebFrameProxy::provisionalURL):
- UIProcess/WebHistoryClient.h:
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didReceiveTitleForFrame):
- UIProcess/WebLoaderClient.h:
- UIProcess/WebNavigationData.h:
(WebKit::WebNavigationData::title):
(WebKit::WebNavigationData::url):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::pageTitle):
(WebKit::WebPageProxy::toolTip):
(WebKit::WebPageProxy::urlAtProcessExit):
- UIProcess/WebPolicyClient.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getPluginHostConnection):
- UIProcess/WebProcessProxy.h:
- UIProcess/WebUIClient.h:
- WebProcess/InjectedBundle/InjectedBundle.h:
(WebKit::InjectedBundle::create):
(WebKit::InjectedBundle::setSandboxToken):
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::willPerformClientRedirectForFrame):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
- WebProcess/Plugins/NPRuntimeObjectMap.h:
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/NetscapePluginModule.h:
- WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
(WebKit::NetscapePluginStream::start):
- WebProcess/Plugins/Netscape/NetscapePluginStream.h:
- WebProcess/Plugins/Plugin.h:
- WebProcess/Plugins/PluginController.h:
- WebProcess/Plugins/PluginView.h:
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebCoreSupport/WebContextMenuClient.h:
- WebProcess/WebCoreSupport/WebDragClient.h:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::showCorrectionPanel):
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebCoreSupport/WebInspectorClient.h:
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:
(WebKit::WebSearchPopupMenu::saveRecentSearches):
(WebKit::WebSearchPopupMenu::loadRecentSearches):
- WebProcess/WebCoreSupport/WebSearchPopupMenu.h:
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::runJavaScriptInMainFrame):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::registerURLSchemeAsEmptyDocument):
- WebProcess/WebProcess.h:
- 9:09 PM Changeset in webkit [67774] by
-
- 3 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=46027, image on gamespot.com paginates without bringing its enclosing border along.
Reviewed by Sam Weinig.
Make sure that unsplittable objects like replaced elements propagate their pagination strut outward to the parent block
when appropriate. An image on a line did this, but a block-level image did not.
Added fast/multicol/image-inside-nested-blocks-with-border.html
WebCore:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChild):
LayoutTests:
- fast/multicol/image-inside-nested-blocks-with-border-expected.txt: Added.
- fast/multicol/image-inside-nested-blocks-with-border.html: Added.
- 8:38 PM Changeset in webkit [67773] by
-
- 2 edits in trunk/LayoutTests
2010-09-17 Dimitri Glazkov <Dimitri Glazkov>
Remove passing tests from expectations.
- platform/chromium/drt_expectations.txt: Removed tests that are now
consistently passing on Chromium Windows DRT.
- 7:59 PM Changeset in webkit [67772] by
-
- 2 edits in trunk/WebCore
2010-09-17 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
Move calls from frameView->pageZoomFactor() to frame->pageZoomFactor().
- page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent): Removed a helper function,
added direct calls to frame->pageZoomFactor().
- 7:13 PM Changeset in webkit [67771] by
-
- 17 edits2 deletes in trunk
https://bugs.webkit.org/show_bug.cgi?id=45993, convert printing to the new pagination model.
Reviewed by Simon Fraser.
WebCore:
Make printing store the page height in the RenderView and push that into the layout state to
use the new pagination model. The old pagination model is retained because it is still used
for embedded WebViews.
- page/FrameView.cpp:
(WebCore::FrameView::reset):
(WebCore::FrameView::layout):
(WebCore::FrameView::forceLayout):
(WebCore::FrameView::forceLayoutForPagination):
(WebCore::FrameView::adjustPageHeight):
- page/FrameView.h:
- page/PrintContext.cpp:
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintChildren):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::calcHeight):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::paint):
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::paintReplaced):
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):
(WebCore::RenderView::paint):
(WebCore::RenderView::setBestTruncatedAt):
- rendering/RenderView.h:
(WebCore::RenderView::popLayoutState):
(WebCore::RenderView::pageHeight):
(WebCore::RenderView::setPageHeight):
(WebCore::RenderView::bestTruncatedAt):
(WebCore::RenderView::truncatedAt):
(WebCore::RenderView::setTruncatedAt):
(WebCore::RenderView::printRect):
(WebCore::RenderView::setPrintRect):
(WebCore::RenderView::pushLayoutState):
(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):
(WebCore::LayoutStateMaintainer::pop):
WebKit/mac:
Make printing store the page height in the RenderView and push that into the layout state to
use the new pagination model. The old pagination model is retained because it is still used
for embedded WebViews.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
LayoutTests:
Remove the overflow test, since the new model treats overflow:auto/scroll as unsplittable.
- printing/page-break-always-for-overflow-expected.txt: Removed.
- printing/page-break-always-for-overflow.html: Removed.
- 7:09 PM Changeset in webkit [67770] by
-
- 11 edits in trunk
Canvas sizing ignores intrinsic size
https://bugs.webkit.org/show_bug.cgi?id=46024
Reviewed by Simon Fraser.
WebCore:
Updated fast/replaced/table-percent-height.html
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::RenderEmbeddedObject): If this is used as a proxy
for <video>, behave like it has an intrinsic size (e.g. preserve aspect ratio when
width is auto and height is specified).
- rendering/RenderImage.cpp:
(WebCore::RenderImage::calcAspectRatioWidth): Changed to explicitly invoke
RenderBox::calcReplacedHeight(), now that RenderReplaced has its own implementation
which we don’t want.
(WebCore::RenderImage::calcAspectRatioHeight): Similarly with calcReplacedWidth().
- rendering/RenderImage.h:
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::RenderReplaced): Initialize m_hasIntrinsicSize.
(WebCore::lengthIsSpecified): Added this helper function, based on RenderImage’s
is{Width,Height}Specified().
(WebCore::RenderReplaced::calcReplacedWidth): Moved from RenderVideo all the way
up here so other replaced objects could use this logic.
(WebCore::RenderReplaced::calcReplacedHeight): Ditto.
(WebCore::RenderReplaced::calcAspectRatioWidth): Ditto.
(WebCore::RenderReplaced::calcAspectRatioHeight): Ditto.
(WebCore::RenderReplaced::calcPrefWidths): Replaced with the RenderImage version
of the logic.
(WebCore::RenderReplaced::setIntrinsicSize): Added an assertion.
- rendering/RenderReplaced.h:
(WebCore::RenderReplaced::minimumReplacedHeight): Promoted from private to protected
to allow RenderVideo to call through.
(WebCore::RenderReplaced::setHasIntrinsicSize): Added this setter.
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::updateIntrinsicSize): Factor zoom into the intrinsic size,
the way other RenderReplaced objects do.
(WebCore::RenderVideo::calcReplacedWidth): Invoke the RenderReplaced implementation,
which matches what used to be here, skipping over the RenderImage implementation.
(WebCore::RenderVideo::calcReplacedHeight): Ditto.
(WebCore::RenderVideo::minimumReplacedHeight): Ditto.
- rendering/RenderVideo.h:
LayoutTests:
- fast/replaced/table-percent-height-expected.txt: Updated.
- fast/replaced/table-percent-height.html: Changed to expect canvas to maintain
its intrinsic ratio.
- 6:06 PM Changeset in webkit [67769] by
-
- 7 edits in trunk/JavaScriptCore
2010-09-17 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Imprecise tracking of variable capture leads to overly pessimistic creation of activations
https://bugs.webkit.org/show_bug.cgi?id=46020
The old logic for track free and captured variables would cause us
to decide we needed an activation in every function along the scope
chain between a variable capture and its declaration. We now track
captured variables precisely which requires a bit of additional work
The most substantial change is that the parsing routine needs to
be passed the list of function parameters when reparsing a function
as when reparsing we don't parse the function declaration itself only
its body.
- JavaScriptCore.exp:
- parser/JSParser.cpp: (JSC::JSParser::Scope::Scope): (JSC::JSParser::Scope::needsFullActivation):
We need to distinguish between use of a feature that requires
an activation and eval so we now get this additional flag.
(JSC::JSParser::Scope::collectFreeVariables):
(JSC::JSParser::Scope::getCapturedVariables):
We can't simply return the list of "capturedVariables" now as
is insufficiently precise, so we compute them instead.
(JSC::JSParser::popScope):
(JSC::jsParse):
(JSC::JSParser::JSParser):
(JSC::JSParser::parseProgram):
(JSC::JSParser::parseWithStatement):
(JSC::JSParser::parseTryStatement):
(JSC::JSParser::parseFunctionInfo):
(JSC::JSParser::parseFunctionDeclaration):
(JSC::JSParser::parseProperty):
(JSC::JSParser::parseMemberExpression):
- parser/JSParser.h:
- parser/Parser.cpp: (JSC::Parser::parse):
- parser/Parser.h: (JSC::Parser::parse):
- runtime/Executable.cpp: (JSC::EvalExecutable::compileInternal): (JSC::ProgramExecutable::checkSyntax): (JSC::ProgramExecutable::compileInternal): (JSC::FunctionExecutable::compileForCallInternal): (JSC::FunctionExecutable::compileForConstructInternal): (JSC::FunctionExecutable::reparseExceptionInfo): (JSC::EvalExecutable::reparseExceptionInfo): (JSC::FunctionExecutable::fromGlobalCode):
Pass function parameters (if available) to the parser.
- 6:01 PM Changeset in webkit [67768] by
-
- 2 edits in trunk/WebKitTools
The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
slightly harder to read, so this reverts the previous background colors for various
states, making it easier to read.
Reviewed by Jon Honeycutt.
- BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
(.success):
(.failure):
(.warnings):
(.exception):
(.start,.running,td.building):
(.offline,td.offline):
- 6:00 PM Changeset in webkit [67767] by
-
- 2 edits in trunk/WebCore
Build fix for platforms that compile Touch.
- dom/Touch.cpp:
(WebCore::contentsX):
(WebCore::contentsY):
Get zoom factor from Frame rather than FrameView.
- 5:57 PM Changeset in webkit [67766] by
-
- 1 edit5 deletes in trunk/LayoutTests
2010-09-17 Adam Barth <abarth@webkit.org>
Remove Leopard specific expected results because these now match Snow
Leopard.
- platform/mac-leopard/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Removed.
- platform/mac-leopard/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Removed.
- platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Removed.
- platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Removed.
- platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Removed.
- 5:40 PM Changeset in webkit [67765] by
-
- 3 edits in trunk/JavaScriptCore
Add IsFloatingPoint and IsArithmetic type traits
https://bugs.webkit.org/show_bug.cgi?id=46018
Reviewed by Sam Weinig.
- wtf/TypeTraits.h:
- wtf/TypeTraits.cpp:
- 5:38 PM Changeset in webkit [67764] by
-
- 4 edits in trunk/WebKitTools
2010-09-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67692.
http://trac.webkit.org/changeset/67692
https://bugs.webkit.org/show_bug.cgi?id=46011
broke layout test dashboard (Requested by johnny_g on
#webkit).
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 5:34 PM Changeset in webkit [67763] by
-
- 3 edits in trunk/WebKit2
Fix Windows and Qt builds.
- Shared/qt/PlatformCertificateInfo.h:
(WebKit::PlatformCertificateInfo::decode):
- Shared/win/PlatformCertificateInfo.h:
(WebKit::PlatformCertificateInfo::decode):
- 5:32 PM Changeset in webkit [67762] by
-
- 34 edits4 adds in trunk
2010-09-17 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::createPlugin):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::setZoomLevel): Call functions on Frame instead of FrameView.
2010-09-17 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863
- Api/qwebframe.cpp: (QWebFrame::setTextSizeMultiplier): (QWebFrame::textSizeMultiplier): (QWebFrame::setZoomFactor): (QWebFrame::zoomFactor): Call functions on Frame instead of FrameView.
2010-09-17 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863
- webkit/webkitwebview.cpp: (webkit_web_view_get_zoom_level): (webkit_web_view_apply_zoom_level): (webkit_web_view_set_full_content_zoom): Call functions on Frame instead of FrameView.
2010-09-17 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863
- WebView.cpp: (WebView::setZoomMultiplier): Call functions on Frame instead of FrameView.
2010-09-17 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863
- WebFrame.cpp: (wxWebFrame::IncreaseTextSize): (wxWebFrame::DecreaseTextSize): (wxWebFrame::ResetTextSize): Call functions on Frame instead of FrameView.
2010-09-17 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863
- WebView/WebView.mm: (-[WebView _setZoomMultiplier:isTextOnly:]): Call functions on Frame instead of FrameView.
2010-09-17 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863
- ewk/ewk_frame.cpp: (ewk_frame_zoom_get): (ewk_frame_zoom_set): (ewk_frame_zoom_text_only_set): Call functions on Frame instead of FrameView.
2010-09-17 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863
Moved zoom level back from FrameView to Frame.
I had forgotten that FrameView's lifetime is much shorter than
Frame's, and until that is fixed it's best to leave this on Frame.
- WebCore.exp.in: Updated.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForDocument): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
- dom/Document.cpp: (WebCore::Document::nodesFromRect): (WebCore::Document::elementFromPoint): (WebCore::Document::caretRangeFromPoint):
- dom/MouseRelatedEvent.cpp: (WebCore::contentsX): (WebCore::contentsY): (WebCore::pageZoomFactor):
- dom/Node.cpp: (WebCore::Node::dispatchMouseEvent): (WebCore::Node::dispatchWheelEvent):
- html/HTMLBodyElement.cpp: (WebCore::adjustForZoom): (WebCore::HTMLBodyElement::scrollLeft): (WebCore::HTMLBodyElement::setScrollLeft): (WebCore::HTMLBodyElement::scrollTop): (WebCore::HTMLBodyElement::setScrollTop): (WebCore::HTMLBodyElement::scrollHeight): (WebCore::HTMLBodyElement::scrollWidth):
- html/ImageDocument.cpp: (WebCore::pageZoomFactor): (WebCore::ImageDocument::scale): (WebCore::ImageDocument::imageFitsInWindow):
- page/DOMWindow.cpp: (WebCore::DOMWindow::innerHeight): (WebCore::DOMWindow::innerWidth): (WebCore::DOMWindow::scrollX): (WebCore::DOMWindow::scrollY): (WebCore::DOMWindow::scrollTo):
- page/DragController.cpp: (WebCore::elementUnderMouse):
- rendering/RenderView.cpp: (WebCore::RenderView::zoomFactor):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentScale): (WebCore::SVGSVGElement::setCurrentScale): Get zoom factor from Frame rather than FrameView.
- page/Frame.cpp: (WebCore::parentPageZoomFactor): Moved back here from FrameView. (WebCore::parentTextZoomFactor): Ditto. (WebCore::Frame::Frame): Ditto. (WebCore::Frame::setPageZoomFactor): Ditto. (WebCore::Frame::setTextZoomFactor): Ditto. (WebCore::Frame::setPageAndTextZoomFactors): Ditto.
- page/Frame.h: Moved functions and data for zooming back here from FrameView.
- page/FrameView.cpp: (WebCore::FrameView::FrameView):
- page/FrameView.h: Removed code from here.
2010-09-17 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863
- fast/css/preserve-user-specified-zoom-level-on-reload.html: Added.
- platform/mac/fast/css/preserve-user-specified-zoom-level-on-reload-expected.checksum: Added.
- platform/mac/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png: Added.
- platform/mac/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.
2010-09-17 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::textZoomFactor): (WebKit::WebPage::setTextZoomFactor): (WebKit::WebPage::pageZoomFactor): (WebKit::WebPage::setPageZoomFactor): (WebKit::WebPage::setPageAndTextZoomFactors): Call functions on Frame instead of FrameView.
- 5:23 PM Changeset in webkit [67761] by
-
- 4 edits in trunk/WebKit2
Resize corner jiggles when resizing slowly in WebKit2
<rdar://problem/7897425>
https://bugs.webkit.org/show_bug.cgi?id=45601
Reviewed by Anders Carlsson.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::windowResizerRect):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowResizerRect):
- WebProcess/WebPage/WebPage.h:
Move resize corner logic to WebPage and use the FrameView's size instead of the WebPages
stored size, which doesn't get updated at the right time. This is in line with all other
scrollbar metrics which are in terms of the FrameView's size.
- 5:20 PM Changeset in webkit [67760] by
-
- 16 edits9 adds in trunk/WebKit2
Make certificate data available to the WKFrameRef after it is committed
Part of <rdar://problem/8350189>
https://bugs.webkit.org/show_bug.cgi?id=45998
Reviewed by Anders Carlsson.
- Shared/APIObject.h:
Add new type.
- Shared/WebCertificateInfo.h: Added.
(WebKit::WebCertificateInfo::create):
(WebKit::WebCertificateInfo::platformCertificateInfo):
(WebKit::WebCertificateInfo::WebCertificateInfo):
(WebKit::WebCertificateInfo::type):
Add API type for vending.
- Shared/mac/PlatformCertificateInfo.h: Added.
(WebKit::PlatformCertificateInfo::peerCertificates):
- Shared/mac/PlatformCertificateInfo.mm: Added.
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
(WebKit::PlatformCertificateInfo::dump):
- Shared/qt/PlatformCertificateInfo.h: Added.
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
- Shared/win/PlatformCertificateInfo.h: Added.
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
Add platform specific holder for certificate data and encode/decode functions
to send it over the wire. Right now, this only implemented for the mac.
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKBase.h:
- UIProcess/API/C/WKCertificateInfo.cpp: Added.
(WKCertificateInfoGetTypeID):
- UIProcess/API/C/WKCertificateInfo.h: Added.
Add wrapper for WebCertificateInfo.
- UIProcess/API/C/WKFrame.cpp:
(WKFrameGetCertificateInfo):
- UIProcess/API/C/WKFrame.h:
Add getter for a WKCertificateInfo.
- UIProcess/API/C/mac/WKCertificateInfoMac.h: Added.
- UIProcess/API/C/mac/WKCertificateInfoMac.mm: Added.
(WKCertificateInfoGetPeerCertificates):
Add mac specific getters for the platform specific certificate
data.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::setCertificateInfo):
- UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::certificateInfo):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didCommitLoadForFrame):
- UIProcess/WebPageProxy.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
Pipe the certificate info through to the WebFrameProxy on
commit.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- win/WebKit2Generated.make:
Add new files.
- 5:09 PM Changeset in webkit [67759] by
-
- 34 edits in trunk/LayoutTests
2010-09-17 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] 16 more chromium linux baselines (scrollbars change)
https://bugs.webkit.org/show_bug.cgi?id=46009
- platform/chromium-linux/tables/mozilla/bugs/bug137388-2-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug137388-2-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug2479-1-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug2479-1-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug29314-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug29314-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug2997-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug2997-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug32205-2-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug32205-2-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug3977-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug3977-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug43854-1-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug43854-1-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug650-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug650-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.checksum:
- platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png:
- platform/chromium-linux/tables/mozilla/core/captions-expected.checksum:
- platform/chromium-linux/tables/mozilla/core/captions-expected.png:
- platform/chromium-linux/tables/mozilla/core/cell_heights-expected.checksum:
- platform/chromium-linux/tables/mozilla/core/cell_heights-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-expected.checksum:
- platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-expected.checksum:
- platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.checksum:
- platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
- platform/chromium-linux/tables/mozilla/other/nestedTables-expected.checksum:
- platform/chromium-linux/tables/mozilla/other/nestedTables-expected.png:
- platform/chromium-linux/tables/mozilla/other/test3-expected.checksum:
- platform/chromium-linux/tables/mozilla/other/test3-expected.png:
- platform/chromium/test_expectations.txt:
- 4:23 PM Changeset in webkit [67758] by
-
- 12 edits in trunk
2010-09-17 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362
Reduced the minimum allowed DOMTimer interval to 4ms. This has us matching Chrome,
which hasn't had any problem with 4ms in the past 2 years, as well as increasing our
performance on perf tests that have tight frequent loops such as canvas "animation"
performance tests.
No new tests added. Can't reliably instrument a test in javascript to verify that
the minimum clamped interval time is in fact 4ms.
- WebCore.exp.in:
- page/DOMTimer.cpp: Removed old comments.
- page/DOMTimer.h: Removed old comments.
- page/Settings.cpp: Exposted new method to set minimum DOMTimer interval.
- page/Settings.h:
2010-09-17 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362
- WebView/WebView.mm: Added in a call to set the mimimum allowed DOMTimer to 4ms.
2010-09-17 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362
- WebView.cpp: Added in a call to set the mimimum allowed DOMTimer to 4ms.
2010-09-17 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362
- WebProcess/WebPage/WebPage.cpp: Added in a call to set the mimimum allowed DOMTimer to 4ms.
- 4:12 PM Changeset in webkit [67757] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-17 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
[chromium] Roll forward Chromium DEPS to pick up Mesa DRT changes
https://bugs.webkit.org/show_bug.cgi?id=46006
- DEPS:
- 3:50 PM Changeset in webkit [67756] by
-
- 5 edits in trunk
Versioning.
- 3:49 PM Changeset in webkit [67755] by
-
- 1 copy in tags/Safari-534.8
New tag.
- 3:48 PM Changeset in webkit [67754] by
-
- 3 edits in trunk/WebKit2
CoreIPC argument coder improvements
https://bugs.webkit.org/show_bug.cgi?id=45999
Reviewed by Sam Weinig.
- Platform/CoreIPC/ArgumentCoders.h:
Add explicit specialization for a vector of bytes.
- Platform/CoreIPC/Arguments.h:
(CoreIPC::Arguments1::decode):
(CoreIPC::Arguments2::decode):
(CoreIPC::Arguments3::decode):
(CoreIPC::Arguments4::decode):
(CoreIPC::Arguments5::decode):
(CoreIPC::Arguments6::decode):
Use the injected class name for less typing.
(CoreIPC::Arguments7::Arguments7):
(CoreIPC::Arguments7::encode):
(CoreIPC::Arguments7::decode):
(CoreIPC::In):
(CoreIPC::Out):
Add Arguments7 class.
- 3:43 PM Changeset in webkit [67753] by
-
- 24 edits in trunk/LayoutTests
2010-09-17 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] rebaseline tests that are only scrollbar differences on Linux
https://bugs.webkit.org/show_bug.cgi?id=46000
- platform/chromium-linux/css1/basic/containment-expected.checksum:
- platform/chromium-linux/css1/basic/containment-expected.png:
- platform/chromium-linux/css1/box_properties/padding_right-expected.checksum:
- platform/chromium-linux/css1/box_properties/padding_right-expected.png:
- platform/chromium-linux/css1/font_properties/font_size-expected.checksum:
- platform/chromium-linux/css1/font_properties/font_size-expected.png:
- platform/chromium-linux/fast/block/float/nested-clearance-expected.checksum:
- platform/chromium-linux/fast/block/float/nested-clearance-expected.png:
- platform/chromium-linux/fast/block/positioning/051-expected.checksum:
- platform/chromium-linux/fast/block/positioning/051-expected.png:
- platform/chromium-linux/fast/block/positioning/055-expected.checksum:
- platform/chromium-linux/fast/block/positioning/055-expected.png:
- platform/chromium-linux/fast/forms/select-change-listbox-size-expected.checksum:
- platform/chromium-linux/fast/forms/select-change-listbox-size-expected.png:
- platform/chromium-linux/fast/frames/iframe-scrolling-attribute-expected.checksum:
- platform/chromium-linux/fast/frames/iframe-scrolling-attribute-expected.png:
- platform/chromium-linux/fast/multicol/positioned-with-constrained-height-expected.checksum:
- platform/chromium-linux/fast/multicol/positioned-with-constrained-height-expected.png:
- platform/chromium-linux/fast/repaint/overflow-scroll-delete-expected.checksum:
- platform/chromium-linux/fast/repaint/overflow-scroll-delete-expected.png:
- platform/chromium-linux/http/tests/navigation/error404-frames-expected.checksum:
- platform/chromium-linux/http/tests/navigation/error404-frames-expected.png:
- platform/chromium/test_expectations.txt:
- 3:36 PM Changeset in webkit [67752] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-17 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
[chromium] Add mesa as DumpRenderTree dependency
https://bugs.webkit.org/show_bug.cgi?id=46001
- WebKit.gyp:
- 3:23 PM Changeset in webkit [67751] by
-
- 2 edits in trunk/WebCore
2010-09-17 Marc-Antoine Ruel <maruel@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Split webcore_platform off webcore_remaining
Further reduce webcore_remaining size by moving platform/ code in its
own static libary.
https://bugs.webkit.org/show_bug.cgi?id=45915
- WebCore.gyp/WebCore.gyp:
- 2:59 PM Changeset in webkit [67750] by
-
- 2 edits in trunk/LayoutTests
2010-09-17 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
http/tests/security/xss-DENIED-mime-type-execute-as-html.html fails
https://bugs.webkit.org/show_bug.cgi?id=37540
- platform/gtk/Skipped: test works fine after the fix for https://bugs.webkit.org/show_bug.cgi?id=45377
- 2:57 PM Changeset in webkit [67749] by
-
- 12 edits in trunk
2010-09-13 Matt Perry <mpcomplete@chromium.org>
Reviewed by Darin Fisher.
Have V8DOMWindowShell ask the embedder whether to run a V8 extension
in a particular script context.
https://bugs.webkit.org/show_bug.cgi?id=45721
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::registeredExtensionWithV8): (WebCore::V8Proxy::registerExtension):
- bindings/v8/V8Proxy.h:
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::allowScriptExtension):
- loader/FrameLoaderClient.h:
- 2:50 PM Changeset in webkit [67748] by
-
- 2 edits in trunk/WebKit2
2010-09-17 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
<rdar://problem/8440903> WK2: REGRESSION (r66156): Web sites using
AppleConnect fail to log in: "HTTP Status 404 - /ssowebapp/scriptFrame"
https://bugs.webkit.org/show_bug.cgi?id=45960
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createPlugin):
- 2:47 PM Changeset in webkit [67747] by
-
- 6 edits2 adds7 deletes in trunk/LayoutTests
2010-09-17 Mihai Parparita <mihaip@chromium.org>
Reviewed by Dimitri Glazkov.
http/tests/navigation/post-goback1.html should not be a pixel test
https://bugs.webkit.org/show_bug.cgi?id=45834
Convert post-goback1.html to be a simpler dumpAsText test. It can use
the form-target.pl that was added r67466 with some small modifications.
To be extra safe, clear the back forward list for all the tests that
were converted to use dumpAsText.
- http/tests/navigation/post-basic.html:
- http/tests/navigation/post-frames.html:
- http/tests/navigation/post-goback1-expected.txt: Added.
- http/tests/navigation/post-goback1.html:
- http/tests/navigation/resources/form-target.pl:
- http/tests/navigation/resources/go-back.html: Added.
- platform/chromium-linux/http/tests/navigation/post-goback1-expected.checksum: Removed.
- platform/chromium-linux/http/tests/navigation/post-goback1-expected.png: Removed.
- platform/chromium-win/http/tests/navigation/post-goback1-expected.checksum: Removed.
- platform/chromium-win/http/tests/navigation/post-goback1-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- platform/mac/http/tests/navigation/post-goback1-expected.checksum: Removed.
- platform/mac/http/tests/navigation/post-goback1-expected.png: Removed.
- platform/mac/http/tests/navigation/post-goback1-expected.txt: Removed.
- 2:29 PM Changeset in webkit [67746] by
-
- 2 edits in trunk/WebCore
REGRESSION (r66711): Plug-in replacement text is never shown
https://bugs.webkit.org/show_bug.cgi?id=45997
<rdar://problem/8446766>
Reviewed by Sam Weinig.
Don't return when the plug-in has replacement text.
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintReplaced):
- 2:27 PM Changeset in webkit [67745] by
-
- 2 edits in trunk/LayoutTests
2010-09-17 Eric Carlson <eric.carlson@apple.com>
Rubber-stamped by Simon Fraser.
- platform/win/Skipped: Skip media-can-play-mpeg4-video.html.
- 1:42 PM Changeset in webkit [67744] by
-
- 2 edits in trunk/LayoutTests
2010-09-17 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Unskip the canvas philip suite
https://bugs.webkit.org/show_bug.cgi?id=45991
- platform/chromium/test_expectations.txt:
- 1:27 PM Changeset in webkit [67743] by
-
- 4 edits in trunk/WebKitLibraries
Reviewed, tweaked, and landed by Anders Carlsson.
Patch by Sam Weinig <sam@webkit.org> on 2010-09-17
Add WKCopyNSURLResponsePeerCertificates.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 1:17 PM Changeset in webkit [67742] by
-
- 2 edits2 copies in branches/chromium/517
Merge 67734 - createBlobURL with no argument causes crash.
https://bugs.webkit.org/show_bug.cgi?id=45880
Reviewed by Dmitry Titov.
WebCore:
The fix is to check if the passing blob argument is NULL or not.
Test: fast/files/create-blob-url-crash.html
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::createPublicBlobURL):
- page/DOMWindow.idl: Add attribute to convert null string to undefined.
LayoutTests:
- fast/files/create-blob-url-crash-expected.txt: Added.
- fast/files/create-blob-url-crash.html: Added.
BUG=45880
TEST=create-blob-url-crash.html
TBR=jianli@chromium.org
Review URL: http://codereview.chromium.org/3444009
- 1:11 PM Changeset in webkit [67741] by
-
- 4 edits in trunk/WebKit2
Make WebNumbers immutable matching CF.
Reviewed by Anders Carlsson.
- Shared/WebNumber.h:
(WebKit::WebNumber::value):
(WebKit::WebNumber::WebNumber):
- UIProcess/API/C/WKNumber.cpp:
(WKUInt64GetValue):
- UIProcess/API/C/WKNumber.h:
- 1:04 PM Changeset in webkit [67740] by
-
- 2 edits in trunk/WebKit/chromium
Remove unimplemented destructor declaration to fix Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=45987
Patch by Eric Uhrhane <ericu@chromium.org> on 2010-09-17
Reviewed by David Levin.
- src/AsyncFileWriterChromium.h:
- 1:01 PM Changeset in webkit [67739] by
-
- 2 edits in trunk/WebKit
<http://webkit.org/b/45989> Add WebArchiveInternal.h to Xcode project
Reviewed by Joseph Pecoraro.
- WebKit.xcodeproj/project.pbxproj: Added missing
WebArchiveInternal.h header file to the project. It has been
missing since r31281!
- 12:35 PM Changeset in webkit [67738] by
-
- 7 edits in trunk/WebKit2
Add bool wrapper for WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=45985
Reviewed by John Sullivan.
- Shared/APIObject.h:
- Shared/WebNumber.h:
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKBase.h:
- UIProcess/API/C/WKNumber.cpp:
(WKBooleanGetTypeID):
(WKBooleanCreate):
(WKBooleanGetValue):
(WKBooleanSetValue):
- UIProcess/API/C/WKNumber.h:
- 12:25 PM Changeset in webkit [67737] by
-
- 5 edits in trunk/LayoutTests
Skip the new test fast/files/create-blob-url-crash.html in unsupported
platforms.
- platform/gtk/Skipped:
- platform/mac-wk2/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 12:07 PM Changeset in webkit [67736] by
-
- 2 edits in trunk/WebCore
2010-09-17 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed, build fix. Add files missed in r67704.
- CMakeLists.txt:
- 12:00 PM Changeset in webkit [67735] by
-
- 11 edits in trunk
2010-09-17 Simon Fraser <Simon Fraser>
Reviewed by Chris Marrin.
Remove scroll and clip layers for WKCACFLayerRenderer
https://bugs.webkit.org/show_bug.cgi?id=45922
WKCACFLayerRenderer no longer needs its own layers for managing scrolling
and clipping, because RenderLayerCompositor provides this functionality.
- platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp: (WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer): Remove call to setScrollFrame(). (WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): Ditto.
- platform/graphics/win/WKCACFLayerRenderer.cpp: Remove references to scroll and clip layers (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): (WebCore::WKCACFLayerRenderer::setRootChildLayer): (WebCore::WKCACFLayerRenderer::destroyRenderer): (WebCore::WKCACFLayerRenderer::resize):
- platform/graphics/win/WKCACFLayerRenderer.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::layerTreeAsText): Dump the layers from the root platform layer. (WebCore::RenderLayerCompositor::requiresScrollLayer): On Windows, always say yes.
2010-09-17 Simon Fraser <Simon Fraser>
Reviewed by Chris Marrin.
Remove scroll and clip layers for WKCACFLayerRenderer
https://bugs.webkit.org/show_bug.cgi?id=45922
WKCACFLayerRenderer no longer needs its own layers for managing scrolling
and clipping, because RenderLayerCompositor provides this functionality.
- WebView.cpp: (WebView::sizeChanged): Moved code that handles the WM_SIZE message into this method. Use it to resize the layer renderer. (WebView::WebViewWndProc): Call sizeChanged(). (WebView::updateRootLayerContents): No need to call setScrollFrame() any more. (WebView::layerRendererBecameVisible): Move this from the header (no need to be inline).
- WebView.h:
- 11:59 AM Changeset in webkit [67734] by
-
- 4 edits2 adds in trunk
createBlobURL with no argument causes crash.
https://bugs.webkit.org/show_bug.cgi?id=45880
Reviewed by Dmitry Titov.
WebCore:
The fix is to check if the passing blob argument is NULL or not.
Test: fast/files/create-blob-url-crash.html
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::createPublicBlobURL):
- page/DOMWindow.idl: Add attribute to convert null string to undefined.
LayoutTests:
- fast/files/create-blob-url-crash-expected.txt: Added.
- fast/files/create-blob-url-crash.html: Added.
- 11:48 AM Changeset in webkit [67733] by
-
- 3 edits2 copies in branches/chromium/517
Merge 67627 - 2010-09-16 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions
https://bugs.webkit.org/show_bug.cgi?id=45833
- fast/parser/x-frame-options-detached-document-crash-expected.txt: Added.
- fast/parser/x-frame-options-detached-document-crash.html: Added. Crashes before this patch.
2010-09-16 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions
https://bugs.webkit.org/show_bug.cgi?id=45833
Test: fast/parser/x-frame-options-detached-document-crash.html
- dom/Document.cpp: (WebCore::Document::processHttpEquiv): Other branches in this method already test for a null frame. So it seems to make sense to test that here as well.
BUG=55598
TBR=tonyg@chromium.org
Review URL: http://codereview.chromium.org/3394006
- 11:39 AM Changeset in webkit [67732] by
-
- 8 edits2 copies in branches/chromium/517
Merge 67292 - 2010-09-11 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
URIs in styles created via innerHTML are not resolved against the document's base URI
https://bugs.webkit.org/show_bug.cgi?id=45565
Add test to read back the background image URL from an element that was
created via innerHTML (reduction of http://crbug.com/55023).
- fast/innerHTML/innerHTML-uri-resolution-expected.txt: Added.
- fast/innerHTML/innerHTML-uri-resolution.html: Added.
2010-09-11 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
URIs in styles created via innerHTML are not resolved against the document's base URI
https://bugs.webkit.org/show_bug.cgi?id=45565
The dummy document used for fragment parsing created by
FragmentParsingContext should use the base URI of the fragment's
document. Since (HTML)Document doesn't expose a setter for the base URI
(and shouldn't), we allow it to be set by the constructor/create
function.
Also remove some obsolete code that references the legacy tree builder
from HTMLElement that I happened to notice.
Test: fast/innerHTML/innerHTML-uri-resolution.html
- dom/Document.cpp: (WebCore::Document::Document):
- dom/Document.h:
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument):
- html/HTMLDocument.h: (WebCore::HTMLDocument::create):
- html/HTMLElement.cpp: (WebCore::createFragmentFromSource): (WebCore::HTMLElement::setInnerHTML):
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
BUG=56034
TBR=mihaip@chromium.org
Review URL: http://codereview.chromium.org/3400014
- 11:35 AM Changeset in webkit [67731] by
-
- 7 edits in trunk
2010-09-17 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Add WebKitAccelerated2dCanvasEnabled flag to WebKit for Mac
https://bugs.webkit.org/show_bug.cgi?id=45911
- 11:34 AM Changeset in webkit [67730] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Fix the bug number in the ChangeLog.
- 11:32 AM Changeset in webkit [67729] by
-
- 2 edits in trunk/LayoutTests
Skip some userscripts tests that are flaky on Windows (but pass on Mac),
this needs investigation, and is being tracked by <http://webkit.org/b/44199>.
Rubber-stamped by Adam Roben.
- platform/win/Skipped:
- 11:04 AM Changeset in webkit [67728] by
-
- 2 edits in trunk/WebCore
2010-09-17 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
ASSERTION FAILED: m_loadEventDelayCount
https://bugs.webkit.org/show_bug.cgi?id=45790
- dom/AsyncScriptRunner.cpp: (WebCore::AsyncScriptRunner::timerFired): Protect document before we go running scripts.
- 11:01 AM Changeset in webkit [67727] by
-
- 3 edits in trunk/WebCore
2010-09-17 Stephen White <senorblanco@chromium.org>
Reviewed by Kenneth Russell.
[CHROMIUM] GPU-accelerated canvas should work in test_shell.
https://bugs.webkit.org/show_bug.cgi?id=45968
In order for the shaders in GPU-accelerated canvas to work in both the
GraphicsContext3D / GLES2 path as well as chromium's test_shell (which
passes them to the Mesa backend unmodified), the precision specifiers
in the fragment shader have to be wrapped in #if GL_ES.
Soon to be covered by many layout tests.
- platform/graphics/gpu/SolidFillShader.cpp: (WebCore::SolidFillShader::create):
- platform/graphics/gpu/TexShader.cpp: (WebCore::TexShader::create):
- 11:00 AM Changeset in webkit [67726] by
-
- 2 edits in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config
2010-09-17 William Siegrist <wsiegrist@apple.com>
Replaces branches option with ChangeFilter since branches is now deprecated.
- 10:47 AM Changeset in webkit [67725] by
-
- 2 edits in trunk/WebCore
2010-09-17 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] [REGRESSION] Listbox rendering is incorrect
https://bugs.webkit.org/show_bug.cgi?id=45941
Only apply the shadow tiling optimization to a layer if the GraphicsContext
has a shadow.
This is covered by manual-tests/select-element-type-select.html.
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawBorderlessRectShadow): Before applying the tiled shadow optimization first check to see if the context has a shadow at all.
- 10:42 AM Changeset in webkit [67724] by
-
- 13 edits in trunk
2010-09-17 Martin Robinson <mrobinson@igalia.com>
Reviewed by Oliver Hunt.
[GTK] FontPlatformDataFreeType should use smart pointers to hold its members
https://bugs.webkit.org/show_bug.cgi?id=45917
Added support to PlatformRefPtr for handling HashTableDeletedValue.
- wtf/PlatformRefPtr.h: (WTF::PlatformRefPtr::PlatformRefPtr): Added a constructor that takes HashTableDeletedValue. (WTF::PlatformRefPtr::isHashTableDeletedValue): Added.
2010-09-17 Martin Robinson <mrobinson@igalia.com>
Reviewed by Oliver Hunt.
[GTK] FontPlatformDataFreeType should use smart pointers to hold its members
https://bugs.webkit.org/show_bug.cgi?id=45917
Have FontPlatformDataFreeType use smart pointers to hold its reference-counted
members. Also move the FcPattern specialization from OwnPtrCairo to PlatformRefPtrCairo
as this type is reference-counted.
No new tests as this should not introduce any functionality changes.
- platform/graphics/cairo/FontCacheFreeType.cpp: (WebCore::FontCache::getFontDataForCharacters): Updated to reflect smart pointer changes. (WebCore::FontCache::createFontPlatformData): Ditto.
- platform/graphics/cairo/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::FontPlatformData): Ditto. (WebCore::FontPlatformData::operator=): Ditto. (WebCore::FontPlatformData::~FontPlatformData): Ditto. (WebCore::FontPlatformData::isFixedPitch): Ditto. (WebCore::FontPlatformData::operator==): Ditto.
- platform/graphics/cairo/FontPlatformDataFreeType.h: (WebCore::FontPlatformData::FontPlatformData): Ditto. (WebCore::FontPlatformData::scaledFont): Ditto. (WebCore::FontPlatformData::hash): Ditto. (WebCore::FontPlatformData::isHashTableDeletedValue): Ditto.
- platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp: (WebCore::GlyphPage::fill): Ditto.
- platform/graphics/cairo/OwnPtrCairo.cpp: Removed FcPattern specialization.
- platform/graphics/cairo/OwnPtrCairo.h: Ditto.
- platform/graphics/cairo/PlatformRefPtrCairo.cpp: Added FcPattern and cairo_scaled_font_t specializations. (WTF::refPlatformPtr): Ditto. (WTF::derefPlatformPtr): Ditto.
- platform/graphics/cairo/PlatformRefPtrCairo.h: Ditto.
- platform/graphics/cairo/SimpleFontDataCairo.cpp: (WebCore::SimpleFontData::platformInit): Updated to reflect smart pointer changes. (WebCore::SimpleFontData::containsCharacters): Ditto. (WebCore::SimpleFontData::platformWidthForGlyph): Ditto.
- platform/graphics/gtk/FontGtk.cpp: (WebCore::setPangoAttributes): Ditto.
- 10:40 AM Changeset in webkit [67723] by
-
- 2 edits in trunk/LayoutTests
Land new Windows results for fast/forms/file-input-disabled.html
This corresponds to the changes made in r64712.
Rubber-stamped by John Sullivan.
- platform/win/fast/forms/file-input-disabled-expected.txt:
- 10:20 AM Changeset in webkit [67722] by
-
- 3 edits in trunk/WebKitTools
2010-09-17 Martin Robinson <mrobinson@igalia.com>
Reviewed by Oliver Hunt.
Style bot complains about cairo forward declaration naming
https://bugs.webkit.org/show_bug.cgi?id=45867
Exclude Cairo forward declarations from indentifiers with underscores checks.
- Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
- Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
- 10:16 AM Changeset in webkit [67721] by
-
- 14 edits in trunk
2010-09-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: show status message below call stack when debugger is paused on DOM breakpoint
https://bugs.webkit.org/show_bug.cgi?id=45114
- English.lproj/localizedStrings.js:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::performSearch): (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion): (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval): (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification): (WebCore::InspectorDOMAgent::descriptionForDOMEvent):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::didPause):
- inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype.updateStatus.formatters.s): (WebInspector.CallStackSidebarPane.prototype.updateStatus.append): (WebInspector.CallStackSidebarPane.prototype.updateStatus):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.linkifyNodeById):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.debuggerPaused):
- inspector/front-end/inspector.css: (.pane > .body .placard + .info):
- inspector/front-end/inspector.js: (WebInspector.pausedScript): (WebInspector.formatLocalized):
2010-09-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: show status message below call stack when debugger is paused on DOM breakpoint
https://bugs.webkit.org/show_bug.cgi?id=45114
- http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.evaluateInPageWithTimeout):
- 10:02 AM Changeset in webkit [67720] by
-
- 1 edit2 adds in trunk/WebKitSite
2010-09-16 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Adding a timeline screenshot for blocking and defer scripts
https://bugs.webkit.org/show_bug.cgi?id=45933
- blog-files/timeline-blocking-script.png: Added.
- blog-files/timeline-defer-script.png: Added.
- 9:56 AM Changeset in webkit [67719] by
-
- 2 edits4 copies in branches/chromium/517
Merge 67281
Review URL: http://codereview.chromium.org/3419009
- 9:47 AM Changeset in webkit [67718] by
-
- 1 edit3 copies in branches/chromium/517
Merge 67509
Review URL: http://codereview.chromium.org/3452011
- 9:38 AM Changeset in webkit [67717] by
-
- 3 edits in branches/chromium/517
Merge 67240
Review URL: http://codereview.chromium.org/3464001
- 9:36 AM Changeset in webkit [67716] by
-
- 3 edits2 adds in trunk
2010-09-17 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
Stop history reload navigation to bypass WebKit's popup blocker.
Now history reload can only navigate the page in self frame, no matter
what target frame is defined in <base> and no new window can be created.
https://bugs.webkit.org/show_bug.cgi?id=45369
Test: fast/events/popup-blocked-from-history-reload.html
- loader/RedirectScheduler.cpp: (WebCore::ScheduledNavigation::ScheduledNavigation): (WebCore::ScheduledNavigation::wasUserGesture): Move the m_wasUserGesture to base class ScheduledNavigation. Then all asynchronous navigation situations can restore the correct gesture state during the real navigation process. (WebCore::ScheduledURLNavigation::ScheduledURLNavigation): (WebCore::ScheduledURLNavigation::fire): (WebCore::ScheduledURLNavigation::referrer): (WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation): (WebCore::ScheduledHistoryNavigation::fire): (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): (WebCore::ScheduledFormSubmission::fire): (WebCore::RedirectScheduler::scheduleHistoryNavigation):
2010-09-17 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
Stop history reload navigation to bypass WebKit's popup blocker.
https://bugs.webkit.org/show_bug.cgi?id=45369
- fast/events/popup-blocked-from-history-reload-expected.txt: Added.
- fast/events/popup-blocked-from-history-reload.html: Added.
- 9:30 AM Changeset in webkit [67715] by
-
- 2 edits in trunk/LayoutTests
2010-09-17 Zhenyao Mo <zmo@google.com>
Unreviewed.
Add failing WebGL tests in drt_expectations.txt.
- platform/chromium/drt_expectations.txt:
- 9:27 AM Changeset in webkit [67714] by
-
- 2 edits in trunk/WebCore
2010-09-16 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by James Robinson.
[chromium] Clip the update region of an ImageLayerChromium to actual size
of the image bitmap to prevent uninitialized memory access when uploading
the dirty region to the texture.
https://bugs.webkit.org/show_bug.cgi?id=45937
- platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
- 9:25 AM Changeset in webkit [67713] by
-
- 2 edits2 copies in branches/chromium/517
Merge 67236
TBR=jschuh@chromium.org
Review URL: http://codereview.chromium.org/3419008
- 9:20 AM Changeset in webkit [67712] by
-
- 3 edits in branches/chromium/517
Merge 67356
TBR=abarth@webkit.org
Review URL: http://codereview.chromium.org/3402012
- 9:15 AM Changeset in webkit [67711] by
-
- 8 edits in branches/chromium/517
Merge 67357
Review URL: http://codereview.chromium.org/3403012
- 9:13 AM Changeset in webkit [67710] by
-
- 2 edits in trunk/WebCore
2010-09-17 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by David Hyatt.
Remove extraneous RenderObject traversal.
https://bugs.webkit.org/show_bug.cgi?id=45821
This code always exits in the first iteration of the loop,
because in the context of this call, node->renderer()->node() != 0
is always true.
No behavior change, covered by existing tests.
- page/EventHandler.cpp: (WebCore::EventHandler::canMouseDownStartSelect): Removed the loop. (WebCore::EventHandler::canMouseDragExtendSelect): Ditto.
- 9:02 AM Changeset in webkit [67709] by
-
- 6 edits in trunk/WebCore
2010-09-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: FrameLoader::loadedResourceFromMemoryCache reports
resource as not cached to InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=45961
There is one path in control flow that leads to resources being
reported as not cached. Patch to follow.
- inspector/InspectorController.cpp: (WebCore::InspectorController::markResourceAsCached):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::markAsCached): (WebCore::InspectorResource::updateResponse):
- inspector/InspectorResource.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadedResourceFromMemoryCache):
- 8:52 AM Changeset in webkit [67708] by
-
- 2 edits in trunk/LayoutTests
Land new Windows results for html5lib/runner.html
This corresponds to the changes made in r67233 and r67356.
Rubber-stamped by Anders Carlsson.
- platform/win/html5lib/runner-expected.txt:
- 8:38 AM Changeset in webkit [67707] by
-
- 2 edits in trunk/LayoutTests
Add some tests failing due to unimplemented DRT APIs to the Windows Skipped file
- platform/win/Skipped: Added two tests which fail due to
already-known limitations of Windows DRT.
- 8:11 AM Changeset in webkit [67706] by
-
- 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css
2010-09-17 William Siegrist <wsiegrist@apple.com>
Remove centering on results directory listing.
- 8:00 AM Changeset in webkit [67705] by
-
- 2 edits2 adds in trunk/WebCore
2010-09-17 Alexander Pavlov <apavlov@chromium.org>
Unreviewed, build fix. Add files missed in the previous commit.
- GNUmakefile.am:
- css/CSSPropertySourceData.cpp: Added. (WebCore::SourceRange::SourceRange): (WebCore::SourceRange::operator=): (WebCore::CSSPropertySourceData::CSSPropertySourceData): (WebCore::CSSPropertySourceData::operator=): (WebCore::CSSPropertySourceData::toString): (WebCore::CSSPropertySourceData::hash): (WebCore::CSSPropertySourceData::init):
- css/CSSPropertySourceData.h: Added. (WebCore::CSSPropertySourceData::~CSSPropertySourceData): (WebCore::CSSStyleSourceData::create):
- 7:37 AM Changeset in webkit [67704] by
-
- 20 edits in trunk
2010-09-15 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Provide source-based properties for style declarations to CSSParser clients
This change:
- Enables InspectorCSSStore to extract CSS stylesheet text for all source-based stylesheets, even with the resource tracking turned off.
- Adds to CSSParser a capability of source-related style declaration data extraction:
- Start/end source offsets for a declaration, relative to the parent stylesheet start or the "style" attribute value.
- Start/end source offsets for CSS properties, relative to the declaration start.
- CSS property data: name, value, priority, WebCore parsability (i.e. if the property is understood by WebCore).
- Provides the extracted data to the WebInspector frontend via InspectorDOMAgent::getStyleSourceData(). https://bugs.webkit.org/show_bug.cgi?id=44949
WebCore:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSGrammar.y:
- css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::node):
- css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseSheet): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::createStyleRule): (WebCore::CSSParser::markRuleBodyStart): (WebCore::CSSParser::markPropertyStart): (WebCore::CSSParser::markPropertyEnd):
- css/CSSParser.h: (WebCore::CSSParser::resetPropertyMarks):
- css/CSSPropertySourceData.cpp: Added. (WebCore::SourceRange::SourceRange): (WebCore::SourceRange::operator=): (WebCore::CSSPropertySourceData::CSSPropertySourceData): (WebCore::CSSPropertySourceData::operator=): (WebCore::CSSPropertySourceData::toString): (WebCore::CSSPropertySourceData::hash): (WebCore::CSSPropertySourceData::init):
- css/CSSPropertySourceData.h: Added. (WebCore::CSSPropertySourceData::~CSSPropertySourceData): (WebCore::CSSStyleSourceData::create):
- inspector/Inspector.idl:
- inspector/InspectorCSSStore.cpp: (WebCore::InspectorCSSStore::reset): (WebCore::InspectorCSSStore::styleSheetText): (WebCore::InspectorCSSStore::resourceStyleSheetText): (WebCore::InspectorCSSStore::inlineStyleSheetText): (WebCore::InspectorCSSStore::getStyleSourceData): (WebCore::InspectorCSSStore::extractRanges): (WebCore::InspectorCSSStore::getStyleAttributeRanges): (WebCore::InspectorCSSStore::getParentStyleSheet): (WebCore::InspectorCSSStore::inlineStyleElement):
- inspector/InspectorCSSStore.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::resourceContentForURL):
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyleSourceData): (WebCore::InspectorDOMAgent::buildObjectForStyle):
- inspector/InspectorDOMAgent.h:
LayoutTests:
- inspector/resources/styles-source-offsets.css: (body): (/* comment before selector */body.main1/* comment after selector */): (body.main2):
- inspector/styles-source-offsets-expected.txt:
- inspector/styles-source-offsets.html:
- 6:36 AM Changeset in webkit [67703] by
-
- 3 edits in trunk/WebCore
2010-09-17 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Show node description in inspector highlight
https://bugs.webkit.org/show_bug.cgi?id=20930
- inspector/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight): (WebCore::InspectorController::drawElementTitle):
- inspector/InspectorController.h:
- 6:06 AM Changeset in webkit [67702] by
-
- 3 edits in trunk/LayoutTests
2010-09-17 Alejandro G. Castro <alex@igalia.com>
Unreviewed, GTK+ rebaselines.
- platform/gtk/fast/repaint/multicol-repaint-expected.txt:
- platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
- 4:09 AM Changeset in webkit [67701] by
-
- 7 edits3 copies in trunk/LayoutTests/platform
2010-09-17 Satish Sampath <satish@chromium.org>
Unreviewed, updated chromium baselines and disabled a failing test.
- platform/chromium-linux/fast/css/getComputedStyle/computed-style-expected.txt
- platform/chromium-linux/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
- platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
- platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt
- platform/chromium/test_expectations.txt
- 1:15 AM Changeset in webkit [67700] by
-
- 1 edit in branches/chromium/517/WebCore/inspector/InspectorController.cpp
Merge 67651 - 2010-09-16 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: quick fix for crash in InspectorController::loadBreakpoints caused by empty main resource
https://bugs.webkit.org/show_bug.cgi?id=45901
- inspector/InspectorController.cpp: (WebCore::InspectorController::breakpointsSettingKey):
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/3380012
- 1:13 AM Changeset in webkit [67699] by
-
- 1 edit in branches/chromium/517/WebCore/inspector/front-end/ResourcesPanel.js
Merge 67629 - 2010-09-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: prevent resource timing popover from having scrollers.
https://bugs.webkit.org/show_bug.cgi?id=45883
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._showPopover):
TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/3442005
- 1:10 AM Changeset in webkit [67698] by
-
- 4 edits in branches/chromium/517
Merge 67623 - 2010-09-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] Scripts disappear from scripts panel after navigation
https://bugs.webkit.org/show_bug.cgi?id=45890
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::restoreDebugger): (WebCore::InspectorController::restoreProfiler):
- inspector/InspectorController.h:
2010-09-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] Scripts disappear from scripts panel after navigation
https://bugs.webkit.org/show_bug.cgi?id=45890
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setRuntimeProperty): make sure debugger and profiler are initialized when inspected page navigation leads to renderer process change.
TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/3389017
- 1:07 AM Changeset in webkit [67697] by
-
- 2 edits in branches/chromium/517/WebCore/inspector/front-end
Merge 67601 - 2010-09-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: console.group(object) does not allow object to be expanded.
https://bugs.webkit.org/show_bug.cgi?id=45806
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleGroup.prototype.addMessage):
- inspector/front-end/treeoutline.js: (TreeElement.treeElementToggled):
TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/3429016
- 12:20 AM Changeset in webkit [67696] by
-
- 2 edits in trunk/WebKit/mac
WebKit should use system wide spell checking preference when application specific one isn't set.
https://bugs.webkit.org/show_bug.cgi?id=45789
<rdar://problem/8416041>
Patch by Jia Pu <jpu@apple.com> on 2010-09-17
Reviewed by Dan Bernstein.
- WebView/WebView.mm:
(+[WebView initialize]): Use system wide autocorrection and text substitution preferences
when the application level preferences are not set.
Sep 16, 2010:
- 11:20 PM Changeset in webkit [67695] by
-
- 3 edits in trunk/WebCore
2010-09-16 takano takumi <takano1@asia.apple.com>
Reviewed by Kent Tamura.
https://bugs.webkit.org/show_bug.cgi?id=45020
Support "block-flow" and "writing-mode": interpret properties into RenderStyle
Fixed a regression in SVG test introduced by my previous change.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::operator EWritingMode):
- css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
- 10:26 PM Changeset in webkit [67694] by
-
- 3 edits in trunk/WebKit/chromium
2010-09-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67693.
http://trac.webkit.org/changeset/67693
https://bugs.webkit.org/show_bug.cgi?id=45946
"Need to pick up a chromium change first" (Requested by dumi
on #webkit).
- public/WebHTTPBody.h:
- src/WebHTTPBody.cpp: (WebKit::WebHTTPBody::elementAt): (WebKit::WebHTTPBody::appendFileRange):
- 9:56 PM Changeset in webkit [67693] by
-
- 3 edits in trunk/WebKit/chromium
Remove WebHTTPBody::appendFileRange(..., const WebFileInfo&).
Reviewed by Darin Fisher.
- public/WebHTTPBody.h:
- src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
- 9:30 PM Changeset in webkit [67692] by
-
- 4 edits in trunk/WebKitTools
2010-09-16 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Ojan Vafai.
Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
https://bugs.webkit.org/show_bug.cgi?id=45408
This change also tries to remove duplicated upload_results_json methods
in run_webkit_tests.py and json_results_generator.py.
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 9:05 PM Changeset in webkit [67691] by
-
- 2 edits in trunk/WebKit/mac
<rdar://problem/8395558>
https://bugs.webkit.org/show_bug.cgi?id=45938
_web_makePluginViewsPerformSelector:: mutates subviews array while iterating it
Reviewed by Darin Adler.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
Converted from -[NSArray _web_makePluginViewsPerformSelector:withObject:]. The old method
was only ever called on the result of -[WebHTMLView subviews]. By moving that knowledge into
this helper method, it can't be used incorrectly. Now it makes a copy of [WebHTMLView subviews]
before enumerating it, to ensure that the selector can't mutate the array being enumerated.
(-[WebHTMLView viewWillMoveToHostWindow:]):
Updated for _web_makePluginSubviewsPerformSelector:: signature change.
(-[WebHTMLView viewDidMoveToHostWindow]):
Ditto.
- 6:53 PM Changeset in webkit [67690] by
-
- 8 edits in trunk
2010-09-16 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Add entry points to GraphicsContext3D needed for Chromium compositor port
https://bugs.webkit.org/show_bug.cgi?id=45939
Added entry points for two Chromium-specific extensions, and added
a flag to the GraphicsContext3D constructor, currently unsupported
by all ports (including Chromium), indicating whether the context
should render directly to the passed HostWindow or off-screen per
the current semantics. The switch to use GraphicsContext3D in
Chromium's compositor will follow in a subsequent patch.
No new tests; functionality is unchanged. Built and tested
Chromium and WebKit on Mac OS X.
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::create):
- src/GraphicsContext3DInternal.h:
2010-09-16 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Add entry points to GraphicsContext3D needed for Chromium compositor port
https://bugs.webkit.org/show_bug.cgi?id=45939
Added entry points for two Chromium-specific extensions, and added
a flag to the GraphicsContext3D constructor, currently unsupported
by all ports (including Chromium), indicating whether the context
should render directly to the passed HostWindow or off-screen per
the current semantics. The switch to use GraphicsContext3D in
Chromium's compositor will follow in a subsequent patch.
No new tests; functionality is unchanged. Built and tested
Chromium and WebKit on Mac OS X.
- platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::supportsMapSubCHROMIUM): (WebCore::GraphicsContext3D::mapBufferSubDataCHROMIUM): (WebCore::GraphicsContext3D::unmapBufferSubDataCHROMIUM): (WebCore::GraphicsContext3D::mapTexSubImage2DCHROMIUM): (WebCore::GraphicsContext3D::unmapTexSubImage2DCHROMIUM): (WebCore::GraphicsContext3D::supportsCopyTextureToParentTextureCHROMIUM): (WebCore::GraphicsContext3D::copyTextureToParentTextureCHROMIUM):
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D):
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D):
- 6:34 PM Changeset in webkit [67689] by
-
- 4 edits in trunk/WebKitTools
2010-09-16 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Andreas Kling.
[Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
all page specific stuff to the UI.
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::initializeView):
- QtTestBrowser/mainwindow.cpp: (MainWindow::MainWindow): (MainWindow::buildUI): (MainWindow::setPage):
- QtTestBrowser/mainwindow.h:
- 6:33 PM Changeset in webkit [67688] by
-
- 3 edits in trunk/WebKitTools
2010-09-12 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Andreas Kling.
Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
object will move to the qgraphicsscene instead of the qgraphicsview.
- QtTestBrowser/webview.cpp: (WebViewGraphicsBased::setPage): (WebViewGraphicsBased::setResizesToContents): (WebViewGraphicsBased::resizeEvent): (WebViewGraphicsBased::animatedFlip):
- QtTestBrowser/webview.h: (WebViewGraphicsBased::setItemCacheMode): (WebViewGraphicsBased::itemCacheMode):
- 6:32 PM Changeset in webkit [67687] by
-
- 2 edits in trunk/WebKitTools
2010-09-12 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Andreas Kling.
Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
We usually separate methods whose body are larger the a few lines from the class definition.
- QtTestBrowser/webview.h: (WebViewGraphicsBased::yRotation): (WebViewGraphicsBased::setYRotation):
- 6:32 PM Changeset in webkit [67686] by
-
- 2 edits in trunk/WebKitTools
2010-09-12 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Andreas Kling.
Make initializeView method of LauncherWindow private.
No one else needs to be able to call it but LauncherWindow.
Also moving the declation of isGraphicsBased method down in the same file, in order
to better group related methods.
- QtTestBrowser/launcherwindow.h:
- QtTestBrowser/launcherwindow.h:
- 6:31 PM Changeset in webkit [67685] by
-
- 3 edits in trunk/WebKitTools
2010-09-12 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Andreas Kling.
Make the getter 'page' method of MainWindow const.
- QtTestBrowser/mainwindow.cpp: (MainWindow::page):
- QtTestBrowser/mainwindow.h:
- 6:31 PM Changeset in webkit [67684] by
-
- 3 edits in trunk/WebKitTools
2010-09-12 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Andreas Kling.
Remove useless parameter from MainWindow class' constructor.
The parameter defaults to an empty URL and is not being used by any caller. Apart from that
and is also not referred in the constructor body and does not make much sense.
- QtTestBrowser/mainwindow.cpp: (MainWindow::MainWindow):
- QtTestBrowser/mainwindow.h:
- 6:18 PM Changeset in webkit [67683] by
-
- 5 edits in trunk/JavaScriptCore
2010-09-16 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Crash due to timer triggered GC on one heap while another heap is active
https://bugs.webkit.org/show_bug.cgi?id=45932
<rdar://problem/8318446>
The GC timer may trigger for one heap while another heap is active. This
is safe, but requires us to ensure that we have temporarily associated the
thread's identifierTable with the heap we're collecting on. Otherwise we
may end up with the identifier tables in an inconsistent state leading to
an eventual crash.
- runtime/Collector.cpp: (JSC::Heap::allocate): (JSC::Heap::reset): (JSC::Heap::collectAllGarbage):
Add assertions to ensure we have the correct identifierTable active
while collecting.
- runtime/GCActivityCallbackCF.cpp: (JSC::DefaultGCActivityCallbackPlatformData::trigger):
Temporarily make the expected IdentifierTable active
- wtf/WTFThreadData.h: (JSC::IdentifierTable::remove):
Make it possible to see when IdentifierTable::remove has succeeded
- wtf/text/StringImpl.cpp: (WTF::StringImpl::~StringImpl):
CRASH if an StringImpl is an Identifier but isn't present in the
active IdentifierTable. If we get to this state something has
gone wrong and we should just crash immediately.
- 6:04 PM Changeset in webkit [67682] by
-
- 35 edits in trunk
2010-09-16 Simon Fraser <Simon Fraser>
Reviewed by James Robinson.
In layerTreeAsText output, avoid printing properties which have their default values
https://bugs.webkit.org/show_bug.cgi?id=45931
Don't dump properties that have their default values to simplify output.
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::dumpProperties):
- 5:55 PM Changeset in webkit [67681] by
-
- 96 edits98 adds4 deletes in trunk/LayoutTests
2010-09-16 John Gregg <johnnyg@google.com>
Unreviewed, chromium rebaselines.
[chromium] Rebaseline multicol tests
https://bugs.webkit.org/show_bug.cgi?id=45936
- platform/chromium-linux/fast/multicol/border-padding-pagination-expected.checksum: Added.
- platform/chromium-linux/fast/multicol/border-padding-pagination-expected.txt: Added.
- platform/chromium-linux/fast/multicol/client-rects-expected.checksum:
- platform/chromium-linux/fast/multicol/client-rects-expected.png:
- platform/chromium-linux/fast/multicol/client-rects-expected.txt: Added.
- platform/chromium-linux/fast/multicol/column-break-with-balancing-expected.checksum: Added.
- platform/chromium-linux/fast/multicol/column-break-with-balancing-expected.png: Added.
- platform/chromium-linux/fast/multicol/column-break-with-balancing-expected.txt: Added.
- platform/chromium-linux/fast/multicol/column-count-with-rules-expected.checksum:
- platform/chromium-linux/fast/multicol/column-count-with-rules-expected.png:
- platform/chromium-linux/fast/multicol/column-rules-expected.checksum:
- platform/chromium-linux/fast/multicol/column-rules-expected.png:
- platform/chromium-linux/fast/multicol/column-rules-expected.txt: Added.
- platform/chromium-linux/fast/multicol/float-avoidance-expected.checksum:
- platform/chromium-linux/fast/multicol/float-avoidance-expected.png:
- platform/chromium-linux/fast/multicol/float-avoidance-expected.txt: Added.
- platform/chromium-linux/fast/multicol/float-multicol-expected.checksum:
- platform/chromium-linux/fast/multicol/float-multicol-expected.png:
- platform/chromium-linux/fast/multicol/float-multicol-expected.txt: Added.
- platform/chromium-linux/fast/multicol/float-paginate-complex-expected.checksum: Added.
- platform/chromium-linux/fast/multicol/float-paginate-complex-expected.png: Added.
- platform/chromium-linux/fast/multicol/float-paginate-complex-expected.txt: Added.
- platform/chromium-linux/fast/multicol/float-paginate-expected.txt:
- platform/chromium-linux/fast/multicol/layers-in-multicol-expected.checksum:
- platform/chromium-linux/fast/multicol/layers-in-multicol-expected.png:
- platform/chromium-linux/fast/multicol/layers-in-multicol-expected.txt: Added.
- platform/chromium-linux/fast/multicol/margin-collapse-expected.checksum: Added.
- platform/chromium-linux/fast/multicol/margin-collapse-expected.txt: Added.
- platform/chromium-linux/fast/multicol/max-height-columns-block-expected.checksum: Added.
- platform/chromium-linux/fast/multicol/max-height-columns-block-expected.png: Added.
- platform/chromium-linux/fast/multicol/max-height-columns-block-expected.txt: Added.
- platform/chromium-linux/fast/multicol/nested-columns-expected.checksum:
- platform/chromium-linux/fast/multicol/nested-columns-expected.png:
- platform/chromium-linux/fast/multicol/nested-columns-expected.txt: Added.
- platform/chromium-linux/fast/multicol/paginate-block-replaced-expected.txt:
- platform/chromium-linux/fast/multicol/positioned-split-expected.checksum: Added.
- platform/chromium-linux/fast/multicol/positioned-split-expected.png: Added.
- platform/chromium-linux/fast/multicol/positioned-split-expected.txt: Added.
- platform/chromium-linux/fast/multicol/shadow-breaking-expected.checksum: Added.
- platform/chromium-linux/fast/multicol/shadow-breaking-expected.txt: Added.
- platform/chromium-linux/fast/multicol/single-line-expected.checksum:
- platform/chromium-linux/fast/multicol/single-line-expected.png:
- platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.checksum:
- platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
- platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Added.
- platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
- platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
- platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
- platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
- platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
- platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Added.
- platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.checksum:
- platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
- platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
- platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
- platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
- platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
- platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Added.
- platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
- platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
- platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Added.
- platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
- platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.png:
- platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
- platform/chromium-linux/fast/multicol/table-margin-collapse-expected.checksum: Added.
- platform/chromium-linux/fast/multicol/table-margin-collapse-expected.png: Added.
- platform/chromium-linux/fast/multicol/table-margin-collapse-expected.txt: Added.
- platform/chromium-linux/fast/multicol/table-vertical-align-expected.checksum: Added.
- platform/chromium-linux/fast/multicol/table-vertical-align-expected.png: Added.
- platform/chromium-linux/fast/multicol/table-vertical-align-expected.txt: Added.
- platform/chromium-linux/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
- platform/chromium-linux/fast/multicol/unsplittable-inline-block-expected.png: Added.
- platform/chromium-linux/fast/multicol/unsplittable-inline-block-expected.txt: Added.
- platform/chromium-linux/fast/repaint/multicol-repaint-expected.txt:
- platform/chromium-mac/fast/multicol/client-rects-expected.checksum:
- platform/chromium-mac/fast/multicol/client-rects-expected.png: Removed.
- platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.checksum: Added.
- platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.png: Added.
- platform/chromium-mac/fast/multicol/column-rules-expected.checksum: Added.
- platform/chromium-mac/fast/multicol/column-rules-expected.png: Added.
- platform/chromium-mac/fast/multicol/float-avoidance-expected.checksum:
- platform/chromium-mac/fast/multicol/float-multicol-expected.checksum: Added.
- platform/chromium-mac/fast/multicol/float-multicol-expected.png: Added.
- platform/chromium-mac/fast/multicol/float-paginate-complex-expected.checksum: Added.
- platform/chromium-mac/fast/multicol/float-paginate-complex-expected.png: Added.
- platform/chromium-mac/fast/multicol/float-paginate-expected.checksum: Added.
- platform/chromium-mac/fast/multicol/float-paginate-expected.png: Added.
- platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum:
- platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Added.
- platform/chromium-mac/fast/multicol/margin-collapse-expected.checksum: Added.
- platform/chromium-mac/fast/multicol/max-height-columns-block-expected.checksum: Added.
- platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Added.
- platform/chromium-mac/fast/multicol/paginate-block-replaced-expected.checksum: Added.
- platform/chromium-mac/fast/multicol/positioned-split-expected.checksum: Added.
- platform/chromium-mac/fast/multicol/shadow-breaking-expected.checksum: Added.
- platform/chromium-mac/fast/multicol/single-line-expected.checksum: Added.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
- platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
- platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
- platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
- platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Added.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.checksum:
- platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.png: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
- platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Added.
- platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
- platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
- platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
- platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
- platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.txt: Removed.
- platform/chromium-mac/fast/multicol/table-margin-collapse-expected.checksum: Added.
- platform/chromium-mac/fast/multicol/table-vertical-align-expected.checksum: Added.
- platform/chromium-mac/fast/multicol/table-vertical-align-expected.png: Added.
- platform/chromium-mac/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/multicol-repaint-expected.checksum:
- platform/chromium-mac/fast/repaint/multicol-repaint-expected.png:
- platform/chromium-win/fast/multicol/border-padding-pagination-expected.checksum: Added.
- platform/chromium-win/fast/multicol/border-padding-pagination-expected.png: Added.
- platform/chromium-win/fast/multicol/border-padding-pagination-expected.txt: Added.
- platform/chromium-win/fast/multicol/client-rects-expected.checksum:
- platform/chromium-win/fast/multicol/client-rects-expected.png:
- platform/chromium-win/fast/multicol/client-rects-expected.txt:
- platform/chromium-win/fast/multicol/column-break-with-balancing-expected.checksum: Added.
- platform/chromium-win/fast/multicol/column-break-with-balancing-expected.png: Added.
- platform/chromium-win/fast/multicol/column-break-with-balancing-expected.txt: Added.
- platform/chromium-win/fast/multicol/column-count-with-rules-expected.checksum:
- platform/chromium-win/fast/multicol/column-count-with-rules-expected.png:
- platform/chromium-win/fast/multicol/column-rules-expected.checksum:
- platform/chromium-win/fast/multicol/column-rules-expected.png:
- platform/chromium-win/fast/multicol/column-rules-expected.txt:
- platform/chromium-win/fast/multicol/float-avoidance-expected.checksum:
- platform/chromium-win/fast/multicol/float-avoidance-expected.png:
- platform/chromium-win/fast/multicol/float-avoidance-expected.txt:
- platform/chromium-win/fast/multicol/float-multicol-expected.checksum:
- platform/chromium-win/fast/multicol/float-multicol-expected.png:
- platform/chromium-win/fast/multicol/float-multicol-expected.txt:
- platform/chromium-win/fast/multicol/float-paginate-complex-expected.checksum: Added.
- platform/chromium-win/fast/multicol/float-paginate-complex-expected.png: Added.
- platform/chromium-win/fast/multicol/float-paginate-complex-expected.txt: Added.
- platform/chromium-win/fast/multicol/float-paginate-expected.txt:
- platform/chromium-win/fast/multicol/layers-in-multicol-expected.checksum:
- platform/chromium-win/fast/multicol/layers-in-multicol-expected.png:
- platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt:
- platform/chromium-win/fast/multicol/margin-collapse-expected.checksum: Added.
- platform/chromium-win/fast/multicol/margin-collapse-expected.png: Added.
- platform/chromium-win/fast/multicol/margin-collapse-expected.txt: Added.
- platform/chromium-win/fast/multicol/max-height-columns-block-expected.checksum: Added.
- platform/chromium-win/fast/multicol/max-height-columns-block-expected.png: Added.
- platform/chromium-win/fast/multicol/max-height-columns-block-expected.txt: Added.
- platform/chromium-win/fast/multicol/nested-columns-expected.checksum:
- platform/chromium-win/fast/multicol/nested-columns-expected.png:
- platform/chromium-win/fast/multicol/nested-columns-expected.txt:
- platform/chromium-win/fast/multicol/paginate-block-replaced-expected.txt:
- platform/chromium-win/fast/multicol/positioned-split-expected.checksum: Added.
- platform/chromium-win/fast/multicol/positioned-split-expected.png: Added.
- platform/chromium-win/fast/multicol/positioned-split-expected.txt: Added.
- platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum: Added.
- platform/chromium-win/fast/multicol/shadow-breaking-expected.png: Added.
- platform/chromium-win/fast/multicol/shadow-breaking-expected.txt: Added.
- platform/chromium-win/fast/multicol/single-line-expected.checksum:
- platform/chromium-win/fast/multicol/single-line-expected.png:
- platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.checksum:
- platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
- platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
- platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
- platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
- platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
- platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
- platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
- platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
- platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
- platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
- platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
- platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
- platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
- platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
- platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
- platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
- platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
- platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.png:
- platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.txt:
- platform/chromium-win/fast/multicol/table-margin-collapse-expected.checksum: Added.
- platform/chromium-win/fast/multicol/table-margin-collapse-expected.png: Added.
- platform/chromium-win/fast/multicol/table-margin-collapse-expected.txt: Added.
- platform/chromium-win/fast/multicol/table-vertical-align-expected.checksum: Added.
- platform/chromium-win/fast/multicol/table-vertical-align-expected.png: Added.
- platform/chromium-win/fast/multicol/table-vertical-align-expected.txt: Added.
- platform/chromium-win/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
- platform/chromium-win/fast/multicol/unsplittable-inline-block-expected.png: Added.
- platform/chromium-win/fast/multicol/unsplittable-inline-block-expected.txt: Added.
- platform/chromium-win/fast/repaint/multicol-repaint-expected.checksum:
- platform/chromium-win/fast/repaint/multicol-repaint-expected.png:
- platform/chromium-win/fast/repaint/multicol-repaint-expected.txt:
- 5:35 PM Changeset in webkit [67680] by
-
- 3 edits in trunk/LayoutTests
Update Windows-specific results to getComputedStyle tests after r67667.
Rubber-stamped by Jon Honeycutt.
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 4:34 PM Changeset in webkit [67679] by
-
- 2 edits in trunk/WebCore
2010-09-16 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] GraphicsContext: Remove unused variable
GraphicsContextPlatformPrivate::redirect wasn't used for anything.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::p): (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
- 4:15 PM Changeset in webkit [67678] by
-
- 3 edits1 add8 deletes in trunk/LayoutTests
2010-09-16 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
convert fast/events/5056619.html to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=45907
- fast/events/5056619.html:
- platform/chromium-linux/fast/events/5056619-expected.checksum: Removed.
- platform/chromium-linux/fast/events/5056619-expected.png: Removed.
- platform/chromium-win/fast/events/5056619-expected.checksum: Removed.
- platform/chromium-win/fast/events/5056619-expected.png: Removed.
- platform/chromium-win/fast/events/5056619-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/events/5056619-expected.checksum: Removed.
- platform/mac/fast/events/5056619-expected.png: Removed.
- platform/mac/fast/events/5056619-expected.txt: Removed.
- 4:03 PM Changeset in webkit [67677] by
-
- 4 edits in trunk/WebKit/chromium
2010-09-16 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
[chromium] Add needed entry points to WebGraphicsContext3D for compositor
https://bugs.webkit.org/show_bug.cgi?id=45921
- public/WebGraphicsContext3D.h:
- src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::supportsMapSubCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::mapBufferSubDataCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::unmapBufferSubDataCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::mapTexSubImage2DCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::unmapTexSubImage2DCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::supportsCopyTextureToParentTextureCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::copyTextureToParentTextureCHROMIUM):
- src/WebGraphicsContext3DDefaultImpl.h:
- 3:45 PM Changeset in webkit [67676] by
-
- 10 edits in trunk
2010-09-15 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
https://bugs.webkit.org/show_bug.cgi?id=42151
- platform/chromium/test_expectations.txt:
2010-09-15 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
https://bugs.webkit.org/show_bug.cgi?id=42151
- public/WebDataSource.h:
- src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::applicationCacheHost): (WebKit::WebDataSourceImpl::setDeferMainResourceDataLoad): Added so DRT can set this flag before a load.
- src/WebDataSourceImpl.h:
2010-09-15 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
https://bugs.webkit.org/show_bug.cgi?id=42151
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (WorkItemLoadHTMLString::WorkItemLoadHTMLString): (WorkItemLoadHTMLString::run): (LayoutTestController::queueLoadHTMLString): (LayoutTestController::reset): (LayoutTestController::setDeferMainResourceDataLoad):
- DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::deferMainResourceDataLoad):
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didCreateDataSource):
- 3:35 PM Changeset in webkit [67675] by
-
- 2 edits in trunk/WebCore
2010-09-16 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Remove unnecessary QPainter::clipPath() call in TransparencyLayer()
https://bugs.webkit.org/show_bug.cgi?id=45923
QPainter::clipPath() can be very expensive, so use QPainter::hasClipping()
instead of QPainter::clipPath().isEmpty().
- platform/graphics/qt/TransparencyLayer.h: (WebCore::TransparencyLayer::TransparencyLayer):
- 3:30 PM Changeset in webkit [67674] by
-
- 3 edits in trunk/SunSpider
https://bugs.webkit.org/show_bug.cgi?id=45924
Reviewed by Mark Rowe.
Modify the SunSpider harness to allow a path to be passed to the --suite
argument, supress the normal prepend-"tests/" behaviour for suite names
containing a '/'.
Also wrap the code in an anonymous function to move variables out of global
scope (currently the harness cannot handle running tests the overwrite the
variable 'j').
- resources/sunspider-standalone-driver.js:
- sunspider:
- 3:18 PM Changeset in webkit [67673] by
-
- 2 edits in trunk/WebCore
Fix for regression from my previous check-in. Make sure not to move the LayoutRepainter line
below the setHeight(0) call. This meant it snagged the wrong rectangle and we ended up repainting
the world.
Reviewed by Eric Seidel.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
- 2:58 PM Changeset in webkit [67672] by
-
- 2 edits in trunk/LayoutTests
2010-09-16 Zhenyao Mo <zmo@google.com>
Unreviewed.
Remove passing WebGL tests from platform/chromium/test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=45905
Remove passing tests; also, put webgl tests in one place.
- platform/chromium/test_expectations.txt:
- 2:53 PM Changeset in webkit [67671] by
-
- 1 edit in trunk/WebCore/rendering/ColumnInfo.h
Fix Windows build. Yay for the style review bot telling me to do something that breaks Windows.
- 2:51 PM Changeset in webkit [67670] by
-
- 2 edits1 add in trunk/LayoutTests
2010-09-16 Eric Seidel <eric@webkit.org>
Unreviewed. Just changing the path to the PNG file.
fast/css/font-face-svg-decoding-error.html can cause later CSS tests to fail
https://bugs.webkit.org/show_bug.cgi?id=45919
Fixing the underlying issue in a separate bug. For now
give this test its own png so to unblock the commit-queue.
- fast/css/font-face-svg-decoding-error.html:
- fast/css/resources/invalidfont.png: Copied from LayoutTests/fast/css-generated-content/resources/greenbox.png.
- 2:44 PM Changeset in webkit [67669] by
-
- 1 edit3 adds in trunk/WebKitTools
2010-09-16 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Add script to synchronize WebKit and Khronos WebGL tests
https://bugs.webkit.org/show_bug.cgi?id=42336
- Scripts/update-webgl-conformance-tests: Added.
- Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
- Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
- 2:39 PM Changeset in webkit [67668] by
-
- 11 edits38 adds in trunk/LayoutTests
2010-09-16 Martin Robinson <mrobinson@igalia.com>
Update baselines for GTK+ and unskip a test which is passing.
- platform/gtk/Skipped: Update baselines for GTK+.
- platform/gtk/fast/css/percent-top-relative-container-height-unspecified-expected.txt: Added.
- platform/gtk/fast/images/gif-large-checkerboard-expected.txt: Added.
- platform/gtk/fast/multicol/border-padding-pagination-expected.txt: Added.
- platform/gtk/fast/multicol/client-rects-expected.txt: Added.
- platform/gtk/fast/multicol/column-break-with-balancing-expected.txt: Added.
- platform/gtk/fast/multicol/column-rules-expected.txt: Added.
- platform/gtk/fast/multicol/column-rules-stacking-expected.txt: Added.
- platform/gtk/fast/multicol/columns-shorthand-parsing-expected.txt: Added.
- platform/gtk/fast/multicol/float-avoidance-expected.txt: Added.
- platform/gtk/fast/multicol/float-multicol-expected.txt: Added.
- platform/gtk/fast/multicol/float-paginate-complex-expected.txt: Added.
- platform/gtk/fast/multicol/float-paginate-expected.txt: Added.
- platform/gtk/fast/multicol/layers-in-multicol-expected.txt:
- platform/gtk/fast/multicol/margin-collapse-expected.txt: Added.
- platform/gtk/fast/multicol/max-height-columns-block-expected.txt: Added.
- platform/gtk/fast/multicol/nested-columns-expected.txt:
- platform/gtk/fast/multicol/paginate-block-replaced-expected.txt: Added.
- platform/gtk/fast/multicol/positioned-split-expected.txt: Added.
- platform/gtk/fast/multicol/positioned-with-constrained-height-expected.txt: Added.
- platform/gtk/fast/multicol/shadow-breaking-expected.txt: Added.
- platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
- platform/gtk/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
- platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
- platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
- platform/gtk/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
- platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
- platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt:
- platform/gtk/fast/multicol/table-margin-collapse-expected.txt: Added.
- platform/gtk/fast/multicol/table-vertical-align-expected.txt: Added.
- platform/gtk/fast/multicol/unsplittable-inline-block-expected.txt: Added.
- platform/gtk/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Added.
- platform/gtk/fast/repaint/block-layout-inline-children-replaced-expected.txt: Added.
- platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
- platform/gtk/svg/css/composite-shadow-with-opacity-expected.txt: Added.
- platform/gtk/svg/css/shadow-changes-expected.txt: Added.
- platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt: Added.
- platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt: Added.
- platform/gtk/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt: Added.
- platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt: Added.
- platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added.
- platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
- platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added.
- platform/gtk/svg/custom/non-scaling-stroke-markers-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/non-scaling-stroke-markers-expected.txt.
- platform/gtk/svg/custom/use-invalid-pattern-expected.txt: Copied from LayoutTests/platform/mac-snowleopard/svg/custom/use-invalid-pattern-expected.txt.
- platform/gtk/svg/repaint/filter-repaint-expected.txt: Added.
- platform/gtk/transitions/svg-text-shadow-transition-expected.txt: Added.
- 2:37 PM Changeset in webkit [67667] by
-
- 17 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=45020
Support "block-flow" and "writing-mode": interpret properties into RenderStyle
Patch by takano takumi <takano1@asia.apple.com> on 2010-09-16
Reviewed by Dave Hyatt.
Added code that interprets "block-flow" property and "writing-mode" property settings
into a RenderStyle object.
WebCore:
Test: fast/text/international/block-flow-parser-test.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EBlockFlowDirection):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
- css/CSSValueKeywords.in:
- css/SVGCSSValueKeywords.in:
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setBitDefaults):
(WebCore::InheritedFlags::blockFlow):
(WebCore::InheritedFlags::setBlockFlow):
(WebCore::InheritedFlags::initialBlockFlow):
- rendering/style/RenderStyleConstants.h:
LayoutTests:
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/text/international/block-flow-parser-test-expected.txt: Added.
- fast/text/international/block-flow-parser-test.html: Added.
- svg/css/getComputedStyle-basic-expected.txt:
- 2:04 PM Changeset in webkit [67666] by
-
- 15 edits in trunk
Add support for sending synchronous messages from the InjectedBundle to the WKContext
<rdar://problem/8365320>
https://bugs.webkit.org/show_bug.cgi?id=44785
Reviewed by Anders Carlsson.
WebKit2:
- Shared/CoreIPCSupport/WebContextMessageKinds.h:
- UIProcess/API/C/WKContext.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::didReceiveSynchronousMessageFromInjectedBundle):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
- UIProcess/WebContext.h:
- UIProcess/WebContextInjectedBundleClient.cpp:
(WebKit::WebContextInjectedBundleClient::didReceiveSynchronousMessageFromInjectedBundle):
- UIProcess/WebContextInjectedBundleClient.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveSyncMessage):
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundlePostSynchronousMessage):
- WebProcess/InjectedBundle/API/c/WKBundle.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::postSynchronousMessage):
- WebProcess/InjectedBundle/InjectedBundle.h:
WebKitTools:
- MiniBrowser/mac/AppDelegate.m:
(didReceiveSynchronousMessageFromInjectedBundle):
(-[BrowserAppDelegate init]):
- MiniBrowser/mac/WebBundle/WebBundleMain.m:
(didCreatePage):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
- 1:55 PM Changeset in webkit [67665] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-16 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Roll forward Chromium DEPS to r59706
https://bugs.webkit.org/show_bug.cgi?id=45916
- DEPS:
- 1:51 PM Changeset in webkit [67664] by
-
- 10 edits in trunk
2010-09-16 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Implement dissolveDragImageToFraction
https://bugs.webkit.org/show_bug.cgi?id=45826
- wtf/gobject/GTypedefs.h: Added forward declarations for GtkWindow and GdkEventExpose.
2010-09-16 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Implement dissolveDragImageToFraction
https://bugs.webkit.org/show_bug.cgi?id=45826
Convert the drag image from a GdkPixbuf to a Cairo surface. Not only
might this allow code to be shared between Cairo ports it prevents a
full data copy when the image is not resized and makes the implementation
of dissolveDragImageToFraction more straight-forward.
This feature is covered by manual-tests/drag-image.html.
- page/gtk/DragControllerGtk.cpp: (WebCore::DragController::maxDragImageSize): Make the maximum size of the drag image a little smaller.
- platform/DragImage.h: Changed the drag image type to be a cairo_surface_t*.
- platform/gtk/DragImageGtk.cpp: (WebCore::dragImageSize): Reimplemented to reflect new drag image type. (WebCore::deleteDragImage): Ditto. (WebCore::scaleDragImage): Ditto. (WebCore::dissolveDragImageToFraction): Filled the stub of this function. (WebCore::createDragImageFromImage): Reimplemented to reflect new drag image type.
- platform/gtk/GtkVersioning.h: Added definition for gtk_widget_get_realized for older GTK+s.
2010-09-16 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Implement dissolveDragImageToFraction
https://bugs.webkit.org/show_bug.cgi?id=45826
To support full alpha in the drag icon, changed the drag icon to be a
GtkWindow with an RGBA colormap. Added logic to support painting the drag
image to this window during the expose event.
- WebCoreSupport/DragClientGtk.cpp: (WebKit::dragIconWindowExposeEventCallback): Added. (WebKit::DragClient::DragClient): Initialize the new drag icon window. (WebKit::DragClient::~DragClient): Disconnect the expose event signal. (WebKit::DragClient::startDrag): Resize the drag icon window the appropriate size and if necessary, set its colormap. (WebKit::DragClient::dragIconWindowExposeEvent): Added.
- WebCoreSupport/DragClientGtk.h: Added new member and method declarations.
- 1:42 PM Changeset in webkit [67663] by
-
- 2 edits in branches/chromium/517
Merge 67017 - Fix a problem in createCanonicalUUIDString that causes the last digit
missing on Linux.
https://bugs.webkit.org/show_bug.cgi?id=45412
BUG=45412
TEST=none
Reviewed by Darin Adler.
WebCore:
This is caused by not including the final null character into the count
that is provided to fgets.
This is covered by the existing test: send-form-data-with-sliced-file.html.
- platform/UUID.cpp:
(WebCore::createCanonicalUUIDString):
LayoutTests:
Remove the test that is now passing on Linux for chromium.
- platform/chromium/test_expectations.txt:
TBR=jianli@chromium.org
Review URL: http://codereview.chromium.org/3389014
- 1:31 PM Changeset in webkit [67662] by
-
- 2 edits in trunk/WebKitTools
2010-09-16 Leonid Ebril <leonid.ebril@nokia.com>
Reviewed by Andreas Kling.
[Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
https://bugs.webkit.org/show_bug.cgi?id=45885
Avoid creation of an additional window for screenshot to prevent overlapping with original window.
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::screenshot):
- 1:26 PM Changeset in webkit [67661] by
-
- 2 edits in branches/chromium/517
Merge 67646 - BlobData should be copied for it to be used cross-thread in ThreadableBlobRegistry.
https://bugs.webkit.org/show_bug.cgi?id=45909
BUG=55910
TEST=none
Reviewed by David Levin.
WebCore:
- fileapi/ThreadableBlobRegistry.cpp:
(WebCore::BlobRegistryContext::BlobRegistryContext):
LayoutTests:
Also fix a test issue that we do not calculate the right position to move
mouse to on some platform.
- fast/files/apply-blob-url-to-img.html:
TBR=jianli@chromium.org
Review URL: http://codereview.chromium.org/3449009
- 1:20 PM Changeset in webkit [67660] by
-
- 74 edits42 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=38402, paginate columns at layout time rather than at paint time.
Reviewed by Darin Adler.
WebCore:
This patch adds support for column breaking at layout time rather than at paint time. New variables have been
added to LayoutState and to ColumnInfo to track column information while laying out.
The basic idea behind this patch is to retain the columns' paint-time hackery of transforming one long vertical strip
into multiple columns. Now, however, layout is aware of the columns and will move objects up and down vertically in order
to ensure they don't intersect a break.
Many new tests added in fast/multicol and new results added for existing fast/multicol tests.
- rendering/ColumnInfo.h:
(WebCore::ColumnInfo::ColumnInfo):
(WebCore::ColumnInfo::columnCount):
(WebCore::ColumnInfo::columnHeight):
(WebCore::ColumnInfo::setColumnCountAndHeight):
(WebCore::ColumnInfo::setColumnHeight):
(WebCore::ColumnInfo::updateMinimumColumnHeight):
(WebCore::ColumnInfo::minimumColumnHeight):
(WebCore::ColumnInfo::forcedBreaks):
(WebCore::ColumnInfo::forcedBreakOffset):
(WebCore::ColumnInfo::maximumDistanceBetweenForcedBreaks):
(WebCore::ColumnInfo::clearForcedBreaks):
(WebCore::ColumnInfo::addForcedBreak):
- rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::clearPaginationInformation):
(WebCore::LayoutState::pageY):
(WebCore::LayoutState::addForcedColumnBreak):
- rendering/LayoutState.h:
(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::paginatingColumns):
(WebCore::LayoutState::paginated):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::estimateVerticalPosition):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObjects):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::positionNewFloatOnLine):
(WebCore::RenderBlock::lowestPosition):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
(WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
(WebCore::RenderBlock::markDescendantBlocksAndLinesForLayout):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::RenderBlock::setDesiredColumnCountAndWidth):
(WebCore::RenderBlock::columnCount):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::adjustForColumns):
(WebCore::RenderBlock::setMaxTopMargins):
(WebCore::RenderBlock::setMaxBottomMargins):
(WebCore::RenderBlock::setPaginationStrut):
(WebCore::RenderBlock::setPageY):
(WebCore::RenderBlock::nextPageTop):
(WebCore::inNormalFlow):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::paginationStrut):
(WebCore::RenderBlock::pageY):
(WebCore::RenderBlock::maxTopPosMargin):
(WebCore::RenderBlock::maxTopNegMargin):
(WebCore::RenderBlock::maxBottomPosMargin):
(WebCore::RenderBlock::maxBottomNegMargin):
(WebCore::RenderBlock::initMaxMarginValues):
(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::FloatingObject::type):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::findNextLineBreak):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::markDescendantBlocksAndLinesForLayout):
- rendering/RenderBox.h:
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):
- rendering/RenderFlexibleBox.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::mapLocalToContainer):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updatePagination):
(WebCore::RenderLayer::paintChildLayerIntoColumns):
(WebCore::RenderLayer::hitTestChildLayerColumns):
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::paint):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::layout):
- rendering/RenderTable.h:
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::layout):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::pushLayoutState):
- rendering/RenderView.h:
(WebCore::RenderView::setTruncatedAt):
(WebCore::RenderView::pushLayoutState):
(WebCore::RenderView::popLayoutState):
(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):
- rendering/RootInlineBox.h:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::paginationStrut):
(WebCore::RootInlineBox::setPaginationStrut):
LayoutTests:
Add many new multicol layout tests that demonstrate new pagination features.
- fast/multicol/border-padding-pagination.html: Added.
- fast/multicol/client-rects-expected.checksum:
- fast/multicol/client-rects-expected.png:
- fast/multicol/client-rects-expected.txt:
- fast/multicol/column-break-with-balancing.html: Added.
- fast/multicol/float-paginate-complex.html: Added.
- fast/multicol/float-paginate.html:
- fast/multicol/float-truncation.html:
- fast/multicol/margin-collapse.html: Added.
- fast/multicol/max-height-columns-block.html: Added.
- fast/multicol/positioned-split.html: Added.
- fast/multicol/shadow-breaking.html: Added.
- fast/multicol/single-line-expected.checksum:
- fast/multicol/single-line-expected.png:
- fast/multicol/table-margin-collapse.html: Added.
- fast/multicol/table-vertical-align.html: Added.
- fast/multicol/unsplittable-inline-block.html: Added.
- platform/mac/fast/multicol/border-padding-pagination-expected.checksum: Added.
- platform/mac/fast/multicol/border-padding-pagination-expected.png: Added.
- platform/mac/fast/multicol/border-padding-pagination-expected.txt: Added.
- platform/mac/fast/multicol/column-break-with-balancing-expected.checksum: Added.
- platform/mac/fast/multicol/column-break-with-balancing-expected.png: Added.
- platform/mac/fast/multicol/column-break-with-balancing-expected.txt: Added.
- platform/mac/fast/multicol/column-count-with-rules-expected.checksum: Added.
- platform/mac/fast/multicol/column-count-with-rules-expected.png: Added.
- platform/mac/fast/multicol/column-count-with-rules-expected.txt:
- platform/mac/fast/multicol/column-rules-expected.checksum:
- platform/mac/fast/multicol/column-rules-expected.png:
- platform/mac/fast/multicol/column-rules-expected.txt:
- platform/mac/fast/multicol/column-rules-stacking-expected.checksum:
- platform/mac/fast/multicol/column-rules-stacking-expected.png:
- platform/mac/fast/multicol/columns-shorthand-parsing-expected.checksum:
- platform/mac/fast/multicol/columns-shorthand-parsing-expected.png:
- platform/mac/fast/multicol/float-avoidance-expected.checksum:
- platform/mac/fast/multicol/float-avoidance-expected.png:
- platform/mac/fast/multicol/float-avoidance-expected.txt:
- platform/mac/fast/multicol/float-multicol-expected.checksum:
- platform/mac/fast/multicol/float-multicol-expected.png:
- platform/mac/fast/multicol/float-multicol-expected.txt:
- platform/mac/fast/multicol/float-paginate-complex-expected.checksum: Added.
- platform/mac/fast/multicol/float-paginate-complex-expected.png: Added.
- platform/mac/fast/multicol/float-paginate-complex-expected.txt: Added.
- platform/mac/fast/multicol/float-paginate-expected.txt:
- platform/mac/fast/multicol/layers-in-multicol-expected.checksum:
- platform/mac/fast/multicol/layers-in-multicol-expected.png:
- platform/mac/fast/multicol/layers-in-multicol-expected.txt:
- platform/mac/fast/multicol/margin-collapse-expected.checksum: Added.
- platform/mac/fast/multicol/margin-collapse-expected.png: Added.
- platform/mac/fast/multicol/margin-collapse-expected.txt: Added.
- platform/mac/fast/multicol/max-height-columns-block-expected.checksum: Added.
- platform/mac/fast/multicol/max-height-columns-block-expected.png: Added.
- platform/mac/fast/multicol/max-height-columns-block-expected.txt: Added.
- platform/mac/fast/multicol/nested-columns-expected.checksum:
- platform/mac/fast/multicol/nested-columns-expected.png:
- platform/mac/fast/multicol/nested-columns-expected.txt:
- platform/mac/fast/multicol/paginate-block-replaced-expected.txt:
- platform/mac/fast/multicol/positioned-split-expected.checksum: Added.
- platform/mac/fast/multicol/positioned-split-expected.png: Added.
- platform/mac/fast/multicol/positioned-split-expected.txt: Added.
- platform/mac/fast/multicol/positioned-with-constrained-height-expected.checksum:
- platform/mac/fast/multicol/positioned-with-constrained-height-expected.png:
- platform/mac/fast/multicol/positioned-with-constrained-height-expected.txt:
- platform/mac/fast/multicol/shadow-breaking-expected.checksum: Added.
- platform/mac/fast/multicol/shadow-breaking-expected.png: Added.
- platform/mac/fast/multicol/shadow-breaking-expected.txt: Added.
- platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
- platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
- platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
- platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
- platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
- platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
- platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.checksum:
- platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
- platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
- platform/mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
- platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
- platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
- platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
- platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
- platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
- platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
- platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
- platform/mac/fast/multicol/table-margin-collapse-expected.checksum: Added.
- platform/mac/fast/multicol/table-margin-collapse-expected.png: Added.
- platform/mac/fast/multicol/table-margin-collapse-expected.txt: Added.
- platform/mac/fast/multicol/table-vertical-align-expected.checksum: Added.
- platform/mac/fast/multicol/table-vertical-align-expected.png: Added.
- platform/mac/fast/multicol/table-vertical-align-expected.txt: Added.
- platform/mac/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
- platform/mac/fast/multicol/unsplittable-inline-block-expected.png: Added.
- platform/mac/fast/multicol/unsplittable-inline-block-expected.txt: Added.
- 1:18 PM Changeset in webkit [67659] by
-
- 2 edits in trunk/WebCore
2010-09-16 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Dimitri Glazkov.
Fix debug crash in HTMLFrameOwnerElement caused by content frame being used after destruction.
https://bugs.webkit.org/show_bug.cgi?id=45737
Test: fast/frames/frame-limit.html
- html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::willRemove):
- 1:15 PM Changeset in webkit [67658] by
-
- 2 edits in trunk/WebKitTools
Fix clang++ build.
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController zoomIn:]):
(-[BrowserWindowController zoomOut:]):
(-[BrowserWindowController resetZoom:]):
Remove trailing semicolons.
- 1:05 PM Changeset in webkit [67657] by
-
- 2 edits in trunk/WebCore
2010-09-16 Thomas Zander <t.zander@nokia.com>
Reviewed by Andreas Kling.
[Qt] Fixed incorrect Symbian scoping.
The missing install functionality is only true for mmp based systems.
- WebCore.pro: limit functionality to mmp systems.
- 1:00 PM Changeset in webkit [67656] by
-
- 2 edits in trunk/WebCore
Fix clang build.
- page/animation/AnimationBase.h:
Fix struct/class mismatch.
- 12:48 PM Changeset in webkit [67655] by
-
- 4 edits in trunk/WebKit
Fix build.
WebKit/efl:
- ewk/ewk_view.cpp:
(ewk_view_input_method_state_set): Updated for change
in name of isUrlField to isURLField.
WebKit/qt:
- WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::setInputMethodState): Updated for change
in name of isUrlField to isURLField.
- 12:44 PM Changeset in webkit [67654] by
-
- 1 edit in branches/chromium/517/WebCore/page/chromium/FrameChromium.cpp
Merge 67645 - 2010-09-16 Daniel Cheng <dcheng@chromium.org>
Reviewed by Simon Fraser.
[chromium] Fix incorrect drag node/selection painting.
https://bugs.webkit.org/show_bug.cgi?id=45573
Drag selections were being incorrectly clipped when dragging a selection
near the bottom of a page that was taller than the viewport. To fix
this, we use paintContents() instead of paint().
- page/chromium/FrameChromium.cpp: (WebCore::Frame::nodeImage): (WebCore::Frame::dragImageForSelection):
TBR=dcheng@chromium.org
Review URL: http://codereview.chromium.org/3422008
- 12:40 PM Changeset in webkit [67653] by
-
- 21 edits in trunk
2010-09-16 Darin Adler <Darin Adler>
Reviewed by Andreas Kling.
Reduce use of HTMLInputElement::inputType so we can remove it later
https://bugs.webkit.org/show_bug.cgi?id=45903
- src/DOMUtilitiesPrivate.cpp: (WebKit::elementHasLegalLinkAttribute): Use isImageButton.
- src/WebPasswordFormUtils.cpp: (WebKit::findPasswordFormFields): Use isPasswordField.
- src/WebSearchableFormData.cpp: (WebCore::IsInDefaultState): Use isCheckbox and isRadioButton. (WebCore::HasSuitableTextElement): Use isFileUpload and isPasswordField.
2010-09-16 Darin Adler <Darin Adler>
Reviewed by Andreas Kling.
Reduce use of HTMLInputElement::inputType so we can remove it later
https://bugs.webkit.org/show_bug.cgi?id=45903
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId): Use isPasswordField.
2010-09-16 Darin Adler <Darin Adler>
Reviewed by Andreas Kling.
Reduce use of HTMLInputElement::inputType so we can remove it later
https://bugs.webkit.org/show_bug.cgi?id=45903
- WebFrame.cpp: (WebFrame::elementDoesAutoComplete): Use isPasswordField. (WebFrame::elementIsPassword): Use isPasswordField.
2010-09-16 Darin Adler <Darin Adler>
Reviewed by Andreas Kling.
Reduce use of HTMLInputElement::inputType so we can remove it later
https://bugs.webkit.org/show_bug.cgi?id=45903
- WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation elementDoesAutoComplete:]): Use isPasswordField. (-[WebHTMLRepresentation elementIsPassword:]): Use isPasswordField.
2010-09-16 Darin Adler <Darin Adler>
Reviewed by Andreas Kling.
Reduce use of HTMLInputElement::inputType so we can remove it later
https://bugs.webkit.org/show_bug.cgi?id=45903
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isFileUploadButton): Use isFileUpload. (WebCore::AccessibilityRenderObject::isInputImage): Use isImageButton. (WebCore::AccessibilityRenderObject::determineAccessibilityRole): Use isCheckbox and isRadioButton.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Use isImageButton.
- editing/Editor.cpp: (WebCore::Editor::setBaseWritingDirection): Use isTextField.
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Use isPasswordField.
- editing/SelectionController.cpp: (WebCore::SelectionController::isInPasswordField): Use isPasswordField.
- html/HTMLInputElement.h: Added isFileUpload, isImageButton, and isSubmitButton.
- page/Chrome.cpp: (WebCore::Chrome::setToolTip): Use isSubmitButton and isFileUpload.
- page/DragController.cpp: (WebCore::asFileInput): Use isFileUpload.
- page/EventHandler.cpp: (WebCore::isSubmitImage): Use isImageButton.
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::updateFromElement): Use isFileUpload.
- 12:33 PM Changeset in webkit [67652] by
-
- 1 edit3 adds in trunk/LayoutTests
Mac results for recently-added test.
- platform/mac/fast/images/gif-large-checkerboard-expected.checksum: Added.
- platform/mac/fast/images/gif-large-checkerboard-expected.png: Added.
- platform/mac/fast/images/gif-large-checkerboard-expected.txt: Added.
- 12:31 PM Changeset in webkit [67651] by
-
- 2 edits in trunk/WebCore
2010-09-16 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: quick fix for crash in InspectorController::loadBreakpoints caused by empty main resource
https://bugs.webkit.org/show_bug.cgi?id=45901
- inspector/InspectorController.cpp: (WebCore::InspectorController::breakpointsSettingKey):
- 12:31 PM Changeset in webkit [67650] by
-
- 3 edits1 add in trunk/WebKit/chromium
2010-09-16 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
[chromium] Expose separate GraphicsContext3DInternal.h
https://bugs.webkit.org/show_bug.cgi?id=45914
- WebKit.gyp:
- src/GraphicsContext3D.cpp:
- src/GraphicsContext3DInternal.h: Added.
- 12:26 PM Changeset in webkit [67649] by
-
- 4 edits in trunk/WebKit/chromium
2010-09-16 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
[chromium] Add WebGraphicsContext3D accessor to WebView
https://bugs.webkit.org/show_bug.cgi?id=45913
- public/WebView.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::graphicsContext3D):
- src/WebViewImpl.h:
- 12:17 PM Changeset in webkit [67648] by
-
- 2 edits in trunk/WebCore
2010-09-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Prevent responseReceivedTime from being > endTime in case mixture of WebCore and Network stack info is used.
https://bugs.webkit.org/show_bug.cgi?id=45892
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::endTiming):
- 12:13 PM Changeset in webkit [67647] by
-
- 16 edits in trunk
2010-09-16 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move resourceTracking flag under control of BackendSettings.
Four Inspector API methods about resourceTracking flag were removed.
Actual state of the flag is transfered as the response of setResourceTracking request.
Initial state of the flag on the frontend side is obtained from settings.backend.
WebCore:
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::getBackendSettings): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::setResourceTracking):
- inspector/InspectorController.h:
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
- inspector/front-end/Settings.js: (WebInspector.Settings.initialize.populateBackendSettings): (WebInspector.Settings.initialize):
- inspector/front-end/inspector.js:
WebKit/chromium:
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setRuntimeProperty): (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled):
LayoutTests:
- http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.enableResourceTracking): (initialize_InspectorTest.InspectorTest.disableResourceTracking):
- http/tests/inspector/resource-parameters.html:
- inspector/audits-panel-functional.html:
- inspector/report-API-errors-expected.txt:
- inspector/report-API-errors.html:
- inspector/styles-source-offsets.html:
- 12:09 PM Changeset in webkit [67646] by
-
- 4 edits in trunk
BlobData should be copied for it to be used cross-thread in ThreadableBlobRegistry.
https://bugs.webkit.org/show_bug.cgi?id=45909
Reviewed by David Levin.
WebCore:
- fileapi/ThreadableBlobRegistry.cpp:
(WebCore::BlobRegistryContext::BlobRegistryContext):
LayoutTests:
Also fix a test issue that we do not calculate the right position to move
mouse to on some platform.
- fast/files/apply-blob-url-to-img.html:
- 12:05 PM Changeset in webkit [67645] by
-
- 2 edits in trunk/WebCore
2010-09-16 Daniel Cheng <dcheng@chromium.org>
Reviewed by Simon Fraser.
[chromium] Fix incorrect drag node/selection painting.
https://bugs.webkit.org/show_bug.cgi?id=45573
Drag selections were being incorrectly clipped when dragging a selection
near the bottom of a page that was taller than the viewport. To fix
this, we use paintContents() instead of paint().
- page/chromium/FrameChromium.cpp: (WebCore::Frame::nodeImage): (WebCore::Frame::dragImageForSelection):
- 11:55 AM Changeset in webkit [67644] by
-
- 1 edit1 copy in branches/chromium/517/WebCore
Merge 67641 - 2010-09-16 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
Fix incorrect usage of dissolveDragImageToFraction().
https://bugs.webkit.org/show_bug.cgi?id=45835
createDragImageForSelection() was ignoring the return value of
dissolveDragImageToFraction(). This didn't happen to crash on most
platforms, since most implementations simply modified the image that was
passed in. However, Chromium Mac's implementation actually creates a new
image and returns that instead. This caused us to crash when copying the
image from the renderer to the browser process, since the memory had
already been freed.
- manual-tests/selection-drag-crash.html: Added.
- platform/DragImage.cpp: (WebCore::createDragImageForSelection):
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/3452007
- 11:36 AM Changeset in webkit [67643] by
-
- 2 edits in trunk/LayoutTests
2010-09-16 Zhenyao Mo <zmo@google.com>
Unreviewed, TAG fix for two webgl tests in Linux/Win.
- platform/chromium/test_expectations.txt:
- 11:19 AM Changeset in webkit [67642] by
-
- 5 edits in trunk
2010-09-16 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
[Mac] Always use a valid string when setting WebKitUserStyleSheetLocationPreferenceKey.
https://bugs.webkit.org/show_bug.cgi?id=41510
- platform/mac/fast/loader/user-stylesheet-fast-path-expected.txt:
- platform/mac/fast/loader/user-stylesheet-fast-path.html:
2010-09-16 Patrick Gansterer <paroga@paroga.com>
Reviewed by Darin Adler.
Always use a valid string when setting WebKitUserStyleSheetLocationPreferenceKey.
https://bugs.webkit.org/show_bug.cgi?id=41510
This prevents usage of nil value, which would cause an uncaught exception.
- WebView/WebPreferences.mm: (-[WebPreferences setUserStyleSheetLocation:]):
- 11:06 AM Changeset in webkit [67641] by
-
- 2 edits1 add in trunk/WebCore
2010-09-16 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
Fix incorrect usage of dissolveDragImageToFraction().
https://bugs.webkit.org/show_bug.cgi?id=45835
createDragImageForSelection() was ignoring the return value of
dissolveDragImageToFraction(). This didn't happen to crash on most
platforms, since most implementations simply modified the image that was
passed in. However, Chromium Mac's implementation actually creates a new
image and returns that instead. This caused us to crash when copying the
image from the renderer to the browser process, since the memory had
already been freed.
- manual-tests/selection-drag-crash.html: Added.
- platform/DragImage.cpp: (WebCore::createDragImageForSelection):
- 10:59 AM Changeset in webkit [67640] by
-
- 2 edits in trunk/LayoutTests
2010-09-16 Zhenyao Mo <zmo@google.com>
Unreviewed, test TAG fix.
- platform/chromium/test_expectations.txt: should be IMAGE+TEXT, not TEXT+IMAGE.
- 10:52 AM Changeset in webkit [67639] by
-
- 5 edits in trunk/WebKit
Reverted the previous change because r67628 has been reverted.
WebKit:
- English.lproj/Localizable.strings:
WebKit/mac:
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
- 10:39 AM Changeset in webkit [67638] by
-
- 5 edits in trunk/WebKit
WebKit: Updated localizable strings.
- English.lproj/Localizable.strings:
WebKit/mac: Build fix after r67628. Added context menu item localizable strings for the items
added in r67628, following equivalent menu items in Mac OS X when possible. However,
this set of menu items does not make much sense for Mac OS X, and this should be
addressed separately.
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::contextMenuItemTagOpenMediaInNewWindow):
(WebPlatformStrategies::contextMenuItemTagCopyMediaLinkToClipboard):
(WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
(WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
(WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
(WebPlatformStrategies::contextMenuItemTagMediaPlay):
(WebPlatformStrategies::contextMenuItemTagMediaPause):
(WebPlatformStrategies::contextMenuItemTagMediaMute):
(WebPlatformStrategies::contextMenuItemTagMediaUnMute):
- 10:37 AM Changeset in webkit [67637] by
-
- 2 edits in trunk/WebKit2
2010-09-16 Balazs Kelemen <kbalazs@webkit.org>
Unreviewed trivial typo fix.
Remove old debug helper code inside |#if 0| from ConnectionQt.cpp
- Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::Connection::readyReadHandler):
- 10:33 AM Changeset in webkit [67636] by
-
- 2 edits1 add in trunk/LayoutTests
2010-09-16 Martin Robinson <mrobinson@igalia.com>
Unskip some tests that are now passing after libxml fixes in r66336.
- platform/gtk/Skipped: Unskip passing tests.
- platform/gtk/svg/custom/js-update-stop-linked-gradient-expected.txt: Added.
- 10:32 AM Changeset in webkit [67635] by
-
- 22 edits2 deletes in trunk
2010-09-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67628.
http://trac.webkit.org/changeset/67628
https://bugs.webkit.org/show_bug.cgi?id=45904
broke the build (Requested by eric_carlson on #webkit).
- media/context-menu-actions-expected.txt: Removed.
- media/context-menu-actions.html: Removed.
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
2010-09-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67628.
http://trac.webkit.org/changeset/67628
https://bugs.webkit.org/show_bug.cgi?id=45904
broke the build (Requested by eric_carlson on #webkit).
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
- platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):
- platform/ContextMenuItem.h:
- platform/LocalizationStrategy.h:
- platform/LocalizedStrings.cpp:
- platform/LocalizedStrings.h:
- platform/android/LocalizedStringsAndroid.cpp:
- platform/brew/LocalizedStringsBrew.cpp:
- platform/efl/LocalizedStringsEfl.cpp:
- platform/gtk/ContextMenuItemGtk.cpp: (WebCore::gtkStockIDFromContextMenuAction):
- platform/gtk/LocalizedStringsGtk.cpp:
- platform/haiku/LocalizedStringsHaiku.cpp:
- platform/wx/LocalizedStringsWx.cpp:
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteMediaURL):
- rendering/HitTestResult.h:
2010-09-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67628.
http://trac.webkit.org/changeset/67628
https://bugs.webkit.org/show_bug.cgi?id=45904
broke the build (Requested by eric_carlson on #webkit).
- DumpRenderTree/gtk/EventSender.cpp: (contextClickCallback):
- 10:21 AM Changeset in webkit [67634] by
-
- 2 edits in trunk/WebCore
2010-09-16 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Fraser.
CSS: Fix crash in getTimingFunctionValue()
https://bugs.webkit.org/show_bug.cgi?id=45896
Use a RefPtr to avoid deleting the TimingFunction prematurely.
This is covered by existing tests, e.g transitions/inherit-other-props.html
but will only actually crash on picky platforms (or in valgrind.)
- css/CSSComputedStyleDeclaration.cpp: (WebCore::getTimingFunctionValue):
- 10:15 AM Changeset in webkit [67633] by
-
- 2 edits in trunk/LayoutTests
2010-09-16 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Turn on WebGL layout tests for Chromium win/linux
https://bugs.webkit.org/show_bug.cgi?id=45859
- platform/chromium/test_expectations.txt: Re-enabling WebGL tests.
- 10:04 AM Changeset in webkit [67632] by
-
- 2 edits in trunk/LayoutTests
2010-09-16 John Gregg <johnnyg@google.com>
Unreviewed; chromium test expectations.
editing/selection/context-menu-on-text.html fails on chromium
https://bugs.webkit.org/show_bug.cgi?id=45898
- platform/chromium/test_expectations.txt:
- 9:28 AM Changeset in webkit [67631] by
-
- 8 edits in trunk/WebKit2
Pasteboard doesn't work in WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=42317
<rdar://problem/7660537>
Reviewed by Sam Weinig.
Initial work to support cut, copy, paste and selectAll in WebKit2.
It still does not support RTF and RTFD format for Mac and the selective
enabling of the editing menu entries.
- Shared/CoreIPCSupport/WebPageMessageKinds.h: Added messages to support the
new editing commands.
- UIProcess/API/mac/WKView.mm:
(-[WKView validateUserInterfaceItem:]): Added.
(-[WKView copy:]): Added.
(-[WKView cut:]): Added.
(-[WKView paste:]): Addded.
(-[WKView selectAll:]): Added.
- UIProcess/WebPageProxy.cpp: Added all the proxy methods.
(WebKit::WebPageProxy::selectAll):
(WebKit::WebPageProxy::copy):
(WebKit::WebPageProxy::cut):
(WebKit::WebPageProxy::paste):
- UIProcess/WebPageProxy.h:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::documentFragmentFromAttributedString): Added but not
implemented. This is needed to support RTF and RTFD.
(WebKit::WebEditorClient::setInsertionPasteboard): Added but not implemented.
This is needed only to support Mail on the Mac.
- WebProcess/WebPage/WebPage.cpp: Added all the stub methods.
(WebKit::WebPage::selectAll):
(WebKit::WebPage::copy):
(WebKit::WebPage::cut):
(WebKit::WebPage::paste):
(WebKit::WebPage::didReceiveMessage): Modified to handle the new messages from
the UI process.
- WebProcess/WebPage/WebPage.h:
- 9:27 AM Changeset in webkit [67630] by
-
- 2 edits in trunk/WebKitTools
2010-09-16 Balazs Kelemen <kbalazs@webkit.org>
Unreviewed.
Adding myself as a comitter.
- Scripts/webkitpy/common/config/committers.py:
- 9:24 AM Changeset in webkit [67629] by
-
- 2 edits in trunk/WebCore
2010-09-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: prevent resource timing popover from having scrollers.
https://bugs.webkit.org/show_bug.cgi?id=45883
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._showPopover):
- 9:21 AM Changeset in webkit [67628] by
-
- 22 edits2 adds in trunk
2010-09-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021
New items in the media Element context menu:
- play/pause
- mute/unmute
- controls display control
- switch to fullscreen (for video only)
- loop playback control
- copy media url to clipboard
- open in new window
Test: media/context-menu-actions.html
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
- platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):
- platform/ContextMenuItem.h:
- platform/LocalizationStrategy.h:
- platform/LocalizedStrings.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
- platform/LocalizedStrings.h:
- platform/android/LocalizedStringsAndroid.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
- platform/brew/LocalizedStringsBrew.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
- platform/efl/LocalizedStringsEfl.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
- platform/gtk/ContextMenuItemGtk.cpp: (WebCore::gtkStockIDFromContextMenuAction):
- platform/gtk/LocalizedStringsGtk.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
- platform/haiku/LocalizedStringsHaiku.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
- platform/wx/LocalizedStringsWx.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteMediaURL): (WebCore::HitTestResult::mediaSupportsFullscreen): (WebCore::HitTestResult::mediaElement): (WebCore::HitTestResult::toggleMediaControlsDisplay): (WebCore::HitTestResult::toggleMediaLoopPlayback): (WebCore::HitTestResult::enterFullscreenForVideo): (WebCore::HitTestResult::mediaControlsEnabled): (WebCore::HitTestResult::mediaLoopEnabled): (WebCore::HitTestResult::mediaPlaying): (WebCore::HitTestResult::toggleMediaPlayState): (WebCore::HitTestResult::mediaHasAudio): (WebCore::HitTestResult::mediaMuted): (WebCore::HitTestResult::toggleMediaMuteState):
- rendering/HitTestResult.h:
WebKitTools:
Reviewed by Eric Carlson.
[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021
EventSender::contextClick() now returns an array of js
objects. Each object has a title property and a click() method.
- DumpRenderTree/gtk/EventSender.cpp: (getMenuItemTitleCallback): (setMenuItemTitleCallback): (menuItemClickCallback): (getMenuItemClass): (contextClickCallback):
LayoutTests:
Reviewed by Eric Carlson.
[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021
New test checking the actions that can be triggered by activating
the contex-menu of the media element. Skipped on mac, qt and win
because of lack of DRT support.
- media/context-menu-actions-expected.txt: Added.
- media/context-menu-actions.html: Added.
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 9:12 AM Changeset in webkit [67627] by
-
- 3 edits2 adds in trunk
2010-09-16 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions
https://bugs.webkit.org/show_bug.cgi?id=45833
- fast/parser/x-frame-options-detached-document-crash-expected.txt: Added.
- fast/parser/x-frame-options-detached-document-crash.html: Added. Crashes before this patch.
2010-09-16 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions
https://bugs.webkit.org/show_bug.cgi?id=45833
Test: fast/parser/x-frame-options-detached-document-crash.html
- dom/Document.cpp: (WebCore::Document::processHttpEquiv): Other branches in this method already test for a null frame. So it seems to make sense to test that here as well.
- 9:06 AM Changeset in webkit [67626] by
-
- 8 edits2 adds in trunk
2010-09-14 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson and Martin Robinson.
[GTK] eventSender.contextClick() should return the contents of the context menu
https://bugs.webkit.org/show_bug.cgi?id=39102
Make the eventSender use the new private WebKitGtk+ API to
retrieve the context-menu item titles and store them in an array.
- DumpRenderTree/gtk/EventSender.cpp: (contextClickCallback):
WebKit/gtk:
Reviewed by Eric Carlson and Martin Robinson.
[GTK] eventSender.contextClick() should return the contents of the context menu
https://bugs.webkit.org/show_bug.cgi?id=39102
New private WebView API to retrieve the context-menu widget. This
is used by DRT only.
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp: (webkit_web_view_get_context_menu):
LayoutTests:
Reviewed by Eric Carlson and Martin Robinson.
[GTK] eventSender.contextClick() should return the contents of the context menu
https://bugs.webkit.org/show_bug.cgi?id=39102
New test checking the return value of eventSender.contextClick()
on a non-editable element. Skipped on qt and win.
- editing/selection/context-menu-on-text-expected.txt: Added.
- editing/selection/context-menu-on-text.html: Added.
- platform/qt/Skipped:
- platform/win/Skipped:
- 8:58 AM Changeset in webkit [67625] by
-
- 4 edits in trunk/WebCore
2010-09-16 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Darin Fisher.
[chromium] ImageLayerChromium needs to keep a ref to the Image it uses
so that it never tries to access an already destroyed Image.
https://bugs.webkit.org/show_bug.cgi?id=45869
- platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setContentsToImage):
- platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::setContents): (WebCore::ImageLayerChromium::updateContents):
- platform/graphics/chromium/ImageLayerChromium.h:
- 8:57 AM Changeset in webkit [67624] by
-
- 1 edit1 add in trunk/WebCore
2010-09-16 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
[WINCE] Add platform-specific Image methods
https://bugs.webkit.org/show_bug.cgi?id=28272
- platform/graphics/wince/ImageWinCE.cpp: Added. (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::FrameData::clear): (WebCore::BitmapImage::getHBITMAPOfSize): (WebCore::BitmapImage::drawFrameMatchingSourceSize): (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern): (WebCore::BitmapImage::drawPattern): (WebCore::BitmapImage::checkForSolidColor):
- 8:37 AM Changeset in webkit [67623] by
-
- 6 edits in trunk
2010-09-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] Scripts disappear from scripts panel after navigation
https://bugs.webkit.org/show_bug.cgi?id=45890
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::restoreDebugger): (WebCore::InspectorController::restoreProfiler):
- inspector/InspectorController.h:
2010-09-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] Scripts disappear from scripts panel after navigation
https://bugs.webkit.org/show_bug.cgi?id=45890
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setRuntimeProperty): make sure debugger and profiler are initialized when inspected page navigation leads to renderer process change.
- 8:33 AM Changeset in webkit [67622] by
-
- 2 edits in trunk/WebCore
2010-09-16 Satish Sampath <satish@chromium.org>
Unreviewed, fixing a build break with VS 2008.
Fix build break, add the namespace in a friend declaration to get MSVC recognize it properly.
https://bugs.webkit.org/show_bug.cgi?id=45893
- fileapi/FileWriter.h:
- 8:30 AM Changeset in webkit [67621] by
-
- 2 edits in trunk/WebCore
2010-09-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GStreamer] XOverlay API changes break the build
https://bugs.webkit.org/show_bug.cgi?id=45810
Cope with the GStreamer XOverlay API change for the upcoming
0.10.31 version.
No new tests, build fix only.
- platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::setWindowOverlay):
- 8:24 AM Changeset in webkit [67620] by
-
- 3 edits in trunk/WebKit/wince
2010-09-16 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
[WINCE] Add missing FrameNetworkingContextWinCE::blockedError
https://bugs.webkit.org/show_bug.cgi?id=45680
- WebCoreSupport/FrameNetworkingContextWinCE.cpp: (WebKit::FrameNetworkingContextWinCE::blockedError):
- WebCoreSupport/FrameNetworkingContextWinCE.h:
- 8:17 AM Changeset in webkit [67619] by
-
- 11 edits in trunk/WebCore
2010-09-16 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] V8 port: Fix debug build
Add missing inclusion of <wtf/text/CString.h> where necessary for debug builds.
- history/PageCache.cpp:
- html/HTMLElement.cpp:
- html/HTMLMediaElement.cpp:
- loader/DocumentLoader.cpp:
- loader/icon/IconDatabase.cpp:
- loader/icon/IconLoader.cpp:
- storage/AbstractDatabase.cpp:
- storage/Database.cpp:
- storage/DatabaseSync.cpp:
- storage/DatabaseTracker.cpp:
- 8:05 AM Changeset in webkit [67618] by
-
- 4 edits2 adds in trunk
2010-09-16 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=45852
Range::selectNode and selectNodeContents misbehave when argument is in another document
- fast/dom/Range/select-node-different-document-expected.txt: Added.
- fast/dom/Range/select-node-different-document.html: Added.
2010-09-16 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=45852
Range::selectNode and selectNodeContents misbehave when argument is in another document
Test: fast/dom/Range/select-node-different-document.html
There is nothing in DOM Traversal spec that says this shouldn't work, and it does work in
Firefox.
- dom/Range.cpp: (WebCore::Range::setDocument): (WebCore::Range::selectNode): (WebCore::Range::selectNodeContents):
- dom/Range.h:
- 7:44 AM Changeset in webkit [67617] by
-
- 1 edit1 move1 add in trunk/LayoutTests
2010-09-16 Satish Sampath <satish@chromium.org>
Unreviewed, build fix after checking in the wrong location.
Moving a test expectation which should have been under the chromium platform.
- platform/chromium/fast/images/gif-large-checkerboard-expected.txt: Renamed from LayoutTests/fast/images/gif-large-checkerboard-expected.txt.
- 7:08 AM Changeset in webkit [67616] by
-
- 1 edit7 adds in trunk/LayoutTests
2010-09-16 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Add chromium baselines for a recently added layout test.
https://bugs.webkit.org/show_bug.cgi?id=45886
- fast/images/gif-large-checkerboard-expected.txt: Added.
- platform/chromium-linux/fast/images/gif-large-checkerboard-expected.checksum: Added.
- platform/chromium-linux/fast/images/gif-large-checkerboard-expected.png: Added.
- platform/chromium-mac/fast/images/gif-large-checkerboard-expected.checksum: Added.
- platform/chromium-mac/fast/images/gif-large-checkerboard-expected.png: Added.
- platform/chromium-win/fast/images/gif-large-checkerboard-expected.checksum: Added.
- platform/chromium-win/fast/images/gif-large-checkerboard-expected.png: Added.
- 6:56 AM Changeset in webkit [67615] by
-
- 6 edits in trunk/WebCore
2010-09-16 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
Added support to export HAR to file from Resources panel (conditional on Preferences)
Added support for HARLog (a higher-level aggregate than HAREntry)
https://bugs.webkit.org/show_bug.cgi?id=45663
- English.lproj/localizedStrings.js:
- inspector/front-end/HAREntry.js: (WebInspector.HAREntry.prototype.build): (WebInspector.HAREntry.prototype._buildTimings): (WebInspector.HAREntry._toMilliseconds): (WebInspector.HARLog): (WebInspector.HARLog.prototype.build): (WebInspector.HARLog.prototype._buildPages): (WebInspector.HARLog.prototype._buildMainResourceTimings): (WebInspector.HARLog.prototype._convertResource):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.hide): (WebInspector.ResourcesPanel.prototype._contextMenu): (WebInspector.ResourcesPanel.prototype._exportAll): (WebInspector.ResourcesPanel.prototype._exportResource):
- inspector/front-end/Settings.js:
- inspector/front-end/utilities.js:
- 6:45 AM Changeset in webkit [67614] by
-
- 49 edits in trunk
2010-09-16 Eric Uhrhane <ericu@chromium.org>
Reviewed by Jian Li.
Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798
- configure.ac:
2010-09-16 Eric Uhrhane <ericu@chromium.org>
Reviewed by Jian Li.
Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798
- Configurations/FeatureDefines.xcconfig:
2010-09-16 Eric Uhrhane <ericu@chromium.org>
Reviewed by Jian Li.
Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- WebCore.pro:
- dom/EventTarget.cpp:
- dom/EventTarget.h:
- dom/ExceptionCode.h:
- dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
- dom/ScriptExecutionContext.h:
- fileapi/AsyncFileWriter.h:
- fileapi/FileEntry.cpp:
- fileapi/FileEntry.h:
- fileapi/FileEntry.idl:
- fileapi/FileError.h:
- fileapi/FileError.idl:
- fileapi/FileException.h:
- fileapi/FileException.idl:
- fileapi/FileStreamProxy.cpp:
- fileapi/FileStreamProxy.h:
- fileapi/FileThread.cpp:
- fileapi/FileThread.h:
- fileapi/FileWriter.cpp:
- fileapi/FileWriter.h:
- fileapi/FileWriter.idl:
- fileapi/FileWriterCallback.h:
- fileapi/FileWriterCallback.idl:
- fileapi/FileWriterClient.h:
- page/DOMWindow.idl:
- platform/AsyncFileStream.h:
- platform/FileStream.cpp:
- platform/FileStream.h:
- platform/FileStreamClient.h:
2010-09-16 Eric Uhrhane <ericu@chromium.org>
Reviewed by Jian Li.
Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798
- src/AsyncFileWriterChromium.h:
- src/AsyncFileWriterChromium.cpp:
2010-09-16 Eric Uhrhane <ericu@chromium.org>
Reviewed by Jian Li.
Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798
- Configurations/FeatureDefines.xcconfig:
2010-09-16 Eric Uhrhane <ericu@chromium.org>
Reviewed by Jian Li.
Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798
- Configurations/FeatureDefines.xcconfig:
2010-09-16 Eric Uhrhane <ericu@chromium.org>
Reviewed by Jian Li.
Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
2010-09-16 Eric Uhrhane <ericu@chromium.org>
Reviewed by Jian Li.
Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798
- Scripts/build-webkit:
- 6:19 AM Changeset in webkit [67613] by
-
- 1 edit1 move in trunk/LayoutTests
Rename an image file to all lower case matching how it is used in the layout test. The original patch and layout test is at https://bugs.webkit.org/show_bug.cgi?id=45322
- 6:15 AM Changeset in webkit [67612] by
-
- 13 edits in trunk
2010-09-16 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Support globalhistory tests
https://bugs.webkit.org/show_bug.cgi?id=45774
- platform/qt/Skipped:
2010-09-16 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Support globalhistory tests
https://bugs.webkit.org/show_bug.cgi?id=45774
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::populateVisitedLinks):
- WebCoreSupport/ChromeClientQt.h:
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::dumpHistoryCallbacks): (DumpRenderTreeSupportQt::dumpVisitedLinksCallbacks):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::setTitle): (WebCore::FrameLoaderClientQt::updateGlobalHistory): (WebCore::FrameLoaderClientQt::updateGlobalHistoryRedirectLinks):
- WebCoreSupport/FrameLoaderClientQt.h:
2010-09-16 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Support globalhistory tests
https://bugs.webkit.org/show_bug.cgi?id=45774
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::isGlobalHistoryTest): (WebCore::DumpRenderTree::open):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::dumpHistoryCallbacks): (LayoutTestController::removeAllVisitedLinks):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 6:03 AM Changeset in webkit [67611] by
-
- 3 edits in trunk/WebCore
2010-09-16 Marc-Antoine Ruel <maruel@chromium.org>
Reviewed by Dimitri Glazkov.
Convert WebCore.gyp to use regexp to excludes files instead of listing them in sources!.
This is necessary because sources! is processed before sources/. This makes
applying broader pattern in sources/ more difficult since it overrides the files
listed in sources!. Having all them in sources/ permits controlling the ordering
of the regexp, thus the final list of included files.
Fix Harfbuzz and VDMX source files includes in WebCore.gypi and WebCore.gyp
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- 5:51 AM Changeset in webkit [67610] by
-
- 5 edits in trunk
2010-09-16 Nat Duca <nduca@chromium.org>
Reviewed by Darin Fisher.
[chromium] Make compositor obey finish flag
https://bugs.webkit.org/show_bug.cgi?id=45552
The compositor should obey the finish flag on doComposite. This
flag causes the compositor to finish rendering before returning,
which is needed when resizing the window to avoid flashes of green.
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::finish):
- platform/graphics/chromium/LayerRendererChromium.h:
2010-09-16 Nat Duca <nduca@chromium.org>
Reviewed by Darin Fisher.
[chromium] Make compositor obey finish flag
https://bugs.webkit.org/show_bug.cgi?id=45552
The compositor should obey the finish flag on doComposite. This
flag causes the compositor to finish rendering before returning,
which is needed when resizing the window to avoid flashes of green.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite):
- 5:47 AM Changeset in webkit [67609] by
-
- 5 edits in trunk
2010-09-16 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
GTK+ 3.x. updates, gtk_widget_size_request is deprecated and
"activate-slider" style property for scrollbars is gone.
- platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::show):
- platform/gtk/gtk2drawing.c: (moz_gtk_scrollbar_thumb_paint): (moz_gtk_combo_box_paint):
2010-09-16 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
GTK+ 3.x. updates, gtk_widget_size_request is deprecated and
"activate-slider" style property for scrollbars is gone.
- webkit/webkitwebview.cpp: (PopupMenuPositionFunc):
- 5:38 AM Changeset in webkit [67608] by
-
- 8 edits in trunk
2010-09-16 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove FrameLoaderClientQt::webFrame() to use NetworkingContext to get the WebFrame to avoid layering violations
https://bugs.webkit.org/show_bug.cgi?id=42293
- platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivate::commitLoad):
2010-09-16 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove FrameLoaderClientQt::webFrame() to use NetworkingContext to get the WebFrame to avoid layering violations
https://bugs.webkit.org/show_bug.cgi?id=42293
- Api/qwebframe.cpp: (QWebFrame::childFrames): (QWebFramePrivate::kit):
- Api/qwebpage.cpp: (QWebPage::currentFrame):
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runJavaScriptAlert): (WebCore::ChromeClientQt::runJavaScriptConfirm): (WebCore::ChromeClientQt::runJavaScriptPrompt): (WebCore::ChromeClientQt::contentsSizeChanged):
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::chooseFile):
- WebCoreSupport/FrameLoaderClientQt.h:
- 5:07 AM Changeset in webkit [67607] by
-
- 2 edits in trunk/WebCore
2010-09-16 Ryuan Choi <ryuan.choi@samsung.com>
Unreviewed build fix for EFL
[EFL] REGRESSION(67567) FontCacheCairo was removed
https://bugs.webkit.org/show_bug.cgi?id=45858
- CMakeListsEfl.txt:
- 4:47 AM Changeset in webkit [67606] by
-
- 1 edit4 adds in trunk/WebCore
2010-09-16 Yong Li <yoli@rim.com>
Reviewed by George Staikos.
Add platform-independent JPEG/PNG image encoders that
work with big endian RGBA source data.
There's no layout test because this patch does't make
any port start using the encoders.
- platform/image-encoders/JPEGImageEncoder.cpp: Added.
- platform/image-encoders/JPEGImageEncoder.h: Added.
- platform/image-encoders/PNGImageEncoder.cpp: Added.
- platform/image-encoders/PNGImageEncoder.h: Added.
- 4:27 AM Changeset in webkit [67605] by
-
- 11 edits in trunk
2010-09-15 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Allow the embedder to specify the base path for IndexedDB.
https://bugs.webkit.org/show_bug.cgi?id=45815
Existing tests provide coverage. Use the indexedDBPath parameter that's
already on the group settings object. Pass this parameter into the backend
which will use it rather than a hard coded tmp directory location. If
nothing is specified, assume it should be an in-memory temporary database.
(This is useful for bringup and Chromium's incognito mode.)
- storage/IDBFactory.cpp: (WebCore::IDBFactory::open):
- storage/IDBFactoryBackendImpl.cpp: (WebCore::openSQLiteDatabase): (WebCore::createTables): (WebCore::IDBFactoryBackendImpl::open):
- storage/IDBFactoryBackendImpl.h:
- storage/IDBFactoryBackendInterface.h:
2010-09-15 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Allow the embedder to specify the base path for IndexedDB.
https://bugs.webkit.org/show_bug.cgi?id=45815
Need to add the extra .open() parameter to make this all work.
- public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
- src/IDBFactoryBackendProxy.cpp: (WebCore::IDBFactoryBackendProxy::open):
- src/IDBFactoryBackendProxy.h:
- src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::open):
- src/WebIDBFactoryImpl.h:
- 4:16 AM Changeset in webkit [67604] by
-
- 3 edits2 adds in trunk
2010-09-16 Yong Li <yoli@rim.com>
Reviewed by George Staikos.
Add a test for GIF down sampling.
GIF image down sampling can miss some lines
https://bugs.webkit.org/show_bug.cgi?id=45322
- fast/images/gif-large-checkerboard.html: Added.
- fast/images/resources/large-gif-checkerboard.GIF: Added.
2010-09-16 Yong Li <yoli@rim.com>
Reviewed by George Staikos.
Fix the bug that GIF image down sampling can miss some lines.
https://bugs.webkit.org/show_bug.cgi?id=45322
Test: fast/images/gif-large-checkerboard.html
- platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::haveDecodedRow):
- 4:13 AM Changeset in webkit [67603] by
-
- 2 edits in trunk/WebKit/chromium
2010-09-16 Jeremy Orlow <jorlow@chromium.org>
Speculative build fix.
- src/IDBIndexBackendProxy.cpp:
- 3:50 AM Changeset in webkit [67602] by
-
- 2 edits in trunk/WebCore
2010-09-16 Philippe Normand <pnormand@igalia.com>
Reviewed by Andreas Kling.
[GStreamer] un-needed header includes in MediaPlayerPrivate
https://bugs.webkit.org/show_bug.cgi?id=45877
Include only the headers we need.
No new tests, #includes cleanup only.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
- 3:41 AM Changeset in webkit [67601] by
-
- 3 edits in trunk/WebCore
2010-09-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: console.group(object) does not allow object to be expanded.
https://bugs.webkit.org/show_bug.cgi?id=45806
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleGroup.prototype.addMessage):
- inspector/front-end/treeoutline.js: (TreeElement.treeElementToggled):
- 3:23 AM Changeset in webkit [67600] by
-
- 34 edits4 adds in trunk
2010-09-08 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Complete index support for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=45386
- storage/indexeddb/index-basics-expected.txt: Added.
- storage/indexeddb/index-basics.html: Added.
- storage/indexeddb/index-cursor-expected.txt: Added.
- storage/indexeddb/index-cursor.html: Added.
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
- storage/indexeddb/script-tests/objectstore-basics.js: Removed.
2010-09-08 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Complete index support for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=45386
Add the rest of the index related API for IndexedDB. This
includes cursor suport. A bunch of code was also refactored
since it is shared between indexes and objectStores.
Tests: storage/indexeddb/index-basics.html
storage/indexeddb/index-cursor.html
+ additions to others.
- storage/IDBAny.cpp: (WebCore::IDBAny::set):
- storage/IDBCursor.cpp: (WebCore::IDBCursor::value):
- storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::value): (WebCore::IDBCursorBackendImpl::update): (WebCore::IDBCursorBackendImpl::continueFunction): (WebCore::IDBCursorBackendImpl::remove): (WebCore::IDBCursorBackendImpl::loadCurrentRow): (WebCore::IDBCursorBackendImpl::database):
- storage/IDBCursorBackendImpl.h: (WebCore::IDBCursorBackendImpl::create):
- storage/IDBCursorBackendInterface.h:
- storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables):
- storage/IDBIndex.cpp: (WebCore::IDBIndex::openObjectCursor): (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::getObject): (WebCore::IDBIndex::get):
- storage/IDBIndex.h: (WebCore::IDBIndex::storeName):
- storage/IDBIndex.idl:
- storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::storeName): (WebCore::openCursorInternal): (WebCore::IDBIndexBackendImpl::openObjectCursor): (WebCore::IDBIndexBackendImpl::openCursor): (WebCore::getInternal): (WebCore::IDBIndexBackendImpl::getObject): (WebCore::IDBIndexBackendImpl::get):
- storage/IDBIndexBackendImpl.h: (WebCore::IDBIndexBackendImpl::objectStore):
- storage/IDBIndexBackendInterface.h:
- storage/IDBKey.cpp: (WebCore::IDBKey::fromQuery): (WebCore::IDBKey::whereSyntax): (WebCore::IDBKey::leftCursorWhereFragment): (WebCore::IDBKey::rightCursorWhereFragment):
- storage/IDBKey.h:
- storage/IDBKeyRange.cpp: (WebCore::IDBKeyRange::leftWhereClauseComparisonOperator): (WebCore::IDBKeyRange::rightWhereClauseComparisonOperator):
- storage/IDBKeyRange.h:
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::openCursor):
- storage/IDBRequest.cpp: (WebCore::IDBRequest::timerFired):
2010-09-08 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Complete index support for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=45386
- public/WebIDBCursor.h: (WebKit::WebIDBCursor::direction): (WebKit::WebIDBCursor::key): (WebKit::WebIDBCursor::value): (WebKit::WebIDBCursor::update): (WebKit::WebIDBCursor::continueFunction): (WebKit::WebIDBCursor::remove):
- public/WebIDBIndex.h: (WebKit::WebIDBIndex::storeName): (WebKit::WebIDBIndex::openObjectCursor): (WebKit::WebIDBIndex::openCursor): (WebKit::WebIDBIndex::getObject): (WebKit::WebIDBIndex::get):
- public/WebIDBKey.h:
- src/IDBCursorBackendProxy.cpp: (WebCore::IDBCursorBackendProxy::value):
- src/IDBCursorBackendProxy.h:
- src/IDBIndexBackendProxy.cpp: (WebCore::IDBIndexBackendProxy::storeName): (WebCore::IDBIndexBackendProxy::openObjectCursor): (WebCore::IDBIndexBackendProxy::openCursor): (WebCore::IDBIndexBackendProxy::getObject): (WebCore::IDBIndexBackendProxy::get):
- src/IDBIndexBackendProxy.h:
- src/WebIDBCursorImpl.cpp: (WebKit::WebIDBCursorImpl::value):
- src/WebIDBCursorImpl.h:
- src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::storeName): (WebKit::WebIDBIndexImpl::openCursor): (WebKit::WebIDBIndexImpl::openObjectCursor): (WebKit::WebIDBIndexImpl::getObject): (WebKit::WebIDBIndexImpl::get):
- src/WebIDBIndexImpl.h:
- 2:07 AM Changeset in webkit [67599] by
-
- 1 edit in trunk/ChangeLog
2010-09-15 Commit Queue <commit-queue@webkit.org>
Unreviewed. Test commit for commit-queue@webkit.org.
Sep 15, 2010:
- 10:47 PM Changeset in webkit [67598] by
-
- 3 edits in trunk/WebKit/chromium
Overload WebHTTPBody::appendFileRange() to take a double modification time argument.
https://bugs.webkit.org/show_bug.cgi?id=45829
Reviewed by Darin Fisher.
The plan is to change all callers of
WebHTTPBody::appendFileRange(..., const WebFileInfo&) to use the
new method, and then remove it.
- public/WebHTTPBody.h:
- src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendFileRange):
- 7:45 PM Changeset in webkit [67597] by
-
- 2 edits in trunk/WebKit2
2010-09-15 Jessie Berlin <jberlin@apple.com>
Reviewed by Sam Weinig.
WebKit2 should be able to encode and decode objects of type APIObject::TypeURL.
https://bugs.webkit.org/show_bug.cgi?id=45819
- Shared/UserMessageCoders.h: Add the ability to encode and decode the URL type. (WebKit::UserMessageEncoder::baseEncode): (WebKit::UserMessageDecoder::baseDecode):
- 7:18 PM Changeset in webkit [67596] by
-
- 2 edits in trunk/WebKit/gtk
2010-09-15 Martin Robinson <mrobinson@igalia.com>
Reviewed by David Levin.
[GTK] [REGRESSION] r67591 broke the testwebbackforwardlist API test and introduced a memory leak
https://bugs.webkit.org/show_bug.cgi?id=45865
When initializing the backForwardList private member of the WebView, do
so with adoptPlatformRef to prevent a memory leak.
- webkit/webkitwebview.cpp: (webkit_web_view_init): Initialize member with adoptPlatformRef.
- 7:15 PM Changeset in webkit [67595] by
-
- 2 edits in trunk/WebKit2
Add user message coding for WebUInt64 type.
Reviewed by Jon Honeycutt.
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
- 6:52 PM Changeset in webkit [67594] by
-
- 2 edits in trunk/BugsSite
2010-09-15 Adam Barth <abarth@webkit.org>
Unreviewed.
Only show the review-in-context link if there are contextual comments.
- code-review.js:
- 6:50 PM Changeset in webkit [67593] by
-
- 3 edits in trunk/WebKit2
2010-09-15 Jessie Berlin <jberlin@apple.com>
Reviewed by Jon Honeycutt.
We should save messages that can't be sent when postMessageToInjectedBundle is called and
send them in ensureWebProcess.
https://bugs.webkit.org/show_bug.cgi?id=45822
- UIProcess/WebContext.cpp: (WebKit::WebContext::ensureWebProcess): Post any messages to the Injected Bundle that couldn't be sent earlier because the WebProcess hadn't been initialized yet. (WebKit::WebContext::postMessageToInjectedBundle):
- UIProcess/WebContext.h:
- 6:48 PM Changeset in webkit [67592] by
-
- 3 edits in trunk/BugsSite
2010-09-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[reviewtool] Show the status bubbles on the toolbar
https://bugs.webkit.org/show_bug.cgi?id=45861
- PrettyPatch/PrettyPatch.rb:
- code-review.js:
- 6:34 PM Changeset in webkit [67591] by
-
- 7 edits in trunk/WebKit/gtk
2010-09-15 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[Gtk] Use GOwnPtr for code that needs it
https://bugs.webkit.org/show_bug.cgi?id=21594
Convert as reference counted private members of WebKitWebView to
smart pointers as possible. This removes a lot of unecessary manual
memory management. Also convert some pointer members away from pointer
types, now that we are sure their destructors are called.
- WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::inputMethodsMenuItem): Updated to reflect PlatformRefPtr changes.
- WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag): Ditto.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::setInputMethodState): Ditto. (WebKit::EditorClient::respondToChangedSelection): Ditto. (WebKit::EditorClient::handleInputMethodKeydown): Ditto. (WebKit::EditorClient::handleInputMethodMousePress): Ditto. (WebKit::EditorClient::EditorClient): Ditto. (WebKit::EditorClient::~EditorClient): Ditto.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup): Ditto.
- webkit/webkitprivate.h: Ditto.
- webkit/webkitwebview.cpp: Ditto. (destroy_menu_cb): Ditto. (webkit_web_view_forward_context_menu_event): Ditto. (webkit_web_view_key_release_event): Ditto. (webkit_web_view_button_press_event): Ditto. (webkit_web_view_button_release_event): Ditto. (webkit_web_view_focus_in_event): Ditto. (webkit_web_view_focus_out_event): Ditto. (webkit_web_view_realize): Ditto. (webkit_web_view_set_scroll_adjustments): Ditto. (webkit_web_view_dispose): Changed all g_object_unref calls to PlatformRefPtr.clear(). Although this will also be done by the manual call to the WebKitWebViewPrivate destructor, the order that these fields are zero'd in is still very sensitive. (webkit_web_view_finalize): Updated to reflect PlatformRefPtr changes. (webViewGetDPI): Ditto. (webkit_web_view_screen_changed): Ditto. (webkit_web_view_drag_end): Ditto. (webkit_web_view_drag_data_get): Ditto. (doDragLeaveLater): Ditto. (webkit_web_view_drag_leave): Ditto. (webkit_web_view_drag_motion): Ditto. (webkit_web_view_drag_data_received): Ditto. (webkit_web_view_drag_drop): Ditto. (webkit_web_view_get_im_context): Ditto. (webkit_web_view_update_settings): Ditto. (webkit_web_view_init): Ditto. (webkit_web_view_set_settings): Ditto. (webkit_web_view_get_settings): Ditto. (webkit_web_view_get_inspector): Ditto. (webkit_web_view_set_window_features): Ditto. (webkit_web_view_get_window_features): Ditto. (webkit_web_view_get_back_forward_list): Ditto. (webkit_web_view_zoom_in): Ditto. (webkit_web_view_zoom_out): Ditto. (webkit_web_view_add_resource): Ditto. (webkit_web_view_get_resource): Ditto. (webkit_web_view_get_main_resource): Ditto. (webkit_web_view_clear_resources): Ditto. (webkit_web_view_get_subresources): Ditto.
- 6:19 PM Changeset in webkit [67590] by
-
- 3 edits in trunk/BugsSite
2010-09-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[reviewtool] Allow setting review and commit-queue flags from main review screen
https://bugs.webkit.org/show_bug.cgi?id=45860
This patch adds drop down menus for adjusting the review and
commit-queue flags from the main review screen. These controls don't
appear immediately because we need to read the state of the flags off
the details page.
It's a slight sadness that bugzilla doesn't have a clean way of
identifying which select control is associated with a given flag. The
flags seem to have some sort of id, but it's unclear to me how to map
that id back to a notion of "review" or "commit-queue". Instead, we
look for some magic strings in the title. I'm sure this will come back
to bit us at some point, but I'm not sure what to do that's better.
(The webkitpy solution to this problem is to assume that the flags are
in a given order, but this seems better.)
- PrettyPatch/PrettyPatch.rb:
- Bump version number to bust throuh caches.
- code-review.js:
- 6:13 PM Changeset in webkit [67589] by
-
- 2 edits in trunk/WebKit2
2010-09-15 Simon Fraser <Simon Fraser>
Reviewed by Sam Weinig.
<rdar://problem/8214099> Mousewheel scrolling in WebKit2 is wonky
Use floats so that fractional scrollwheel deltas don't get lost.
- Shared/mac/WebEventFactory.mm: (WebKit::WebEventFactory::createWebWheelEvent):
- 5:40 PM Changeset in webkit [67588] by
-
- 3 edits in trunk/WebKitTools
2010-09-10 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
deduplicate-tests should be runnable from any WebKit directory
https://bugs.webkit.org/show_bug.cgi?id=44709
- Scripts/webkitpy/layout_tests/deduplicate_tests.py:
- Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
- 5:30 PM Changeset in webkit [67587] by
-
- 1 edit2 deletes in trunk/LayoutTests
2010-09-15 John Gregg <johnnyg@google.com>
Unreviewed, build fix after incomplete revert.
Remove layout test added in 67570 that wasn't reverted in 67574.
https://bugs.webkit.org/show_bug.cgi?id=45854
- fast/css/test-setting-canvas-color-expected.txt: Removed.
- fast/css/test-setting-canvas-color.html: Removed.
- 5:29 PM Changeset in webkit [67586] by
-
- 1 edit in trunk/ChangeLog
2010-09-15 Eric Seidel <eric@webkit.org>
Unreviewed. Test commit for commit-queue@webkit.org.
- 5:09 PM Changeset in webkit [67585] by
-
- 4 edits in trunk/WebKitTools
2010-09-15 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] sort testing methods in DRT
https://bugs.webkit.org/show_bug.cgi?id=45850
- DumpRenderTree/chromium/EventSender.cpp: (EventSender::EventSender):
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController):
- DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::TextInputController):
- 5:05 PM Changeset in webkit [67584] by
-
- 3 edits2 adds in trunk/WebKitTools
2010-09-15 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
CQ status shows items out of order
https://bugs.webkit.org/show_bug.cgi?id=45846
Only group consecutive status items with the same patch ID into the same
group, so that overall item ordering is preserved.
Also don't indent status items that only have a single item in their
group.
- QueueStatusServer/handlers/queuestatus.py:
- QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
- QueueStatusServer/templates/queuestatus.html:
- 5:05 PM Changeset in webkit [67583] by
-
- 10 edits in trunk/JavaScriptCore
2010-09-15 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Use free variable analysis to improve activation performance
https://bugs.webkit.org/show_bug.cgi?id=45837
Adds free and captured variable tracking to the JS parser. This
allows us to avoid construction of an activation object in some
cases. Future patches will make more use of this information to
improve those cases where activations are still needed.
- parser/ASTBuilder.h:
- parser/JSParser.cpp: (JSC::JSParser::Scope::Scope): (JSC::JSParser::Scope::declareVariable): (JSC::JSParser::Scope::useVariable): (JSC::JSParser::Scope::collectFreeVariables): (JSC::JSParser::Scope::capturedVariables): (JSC::JSParser::ScopeRef::ScopeRef): (JSC::JSParser::ScopeRef::operator->): (JSC::JSParser::ScopeRef::index): (JSC::JSParser::currentScope): (JSC::JSParser::pushScope): (JSC::JSParser::popScope): (JSC::JSParser::parseProgram): (JSC::JSParser::parseVarDeclarationList): (JSC::JSParser::parseConstDeclarationList): (JSC::JSParser::parseTryStatement): (JSC::JSParser::parseFormalParameters): (JSC::JSParser::parseFunctionInfo): (JSC::JSParser::parseFunctionDeclaration): (JSC::JSParser::parsePrimaryExpression):
- parser/Nodes.cpp: (JSC::ScopeNodeData::ScopeNodeData): (JSC::ScopeNode::ScopeNode): (JSC::ProgramNode::ProgramNode): (JSC::ProgramNode::create): (JSC::EvalNode::EvalNode): (JSC::EvalNode::create): (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::create):
- parser/Nodes.h: (JSC::ScopeNode::needsActivation): (JSC::ScopeNode::hasCapturedVariables):
- parser/Parser.cpp: (JSC::Parser::didFinishParsing):
- parser/Parser.h: (JSC::Parser::parse):
- parser/SyntaxChecker.h:
- runtime/Executable.cpp: (JSC::EvalExecutable::compileInternal): (JSC::ProgramExecutable::compileInternal): (JSC::FunctionExecutable::compileForCallInternal): (JSC::FunctionExecutable::compileForConstructInternal):
- runtime/Executable.h: (JSC::ScriptExecutable::needsActivation): (JSC::ScriptExecutable::recordParse):
- 5:04 PM Changeset in webkit [67582] by
-
- 8 edits in trunk/WebKitTools
2010-09-15 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add queue start/stop messages
https://bugs.webkit.org/show_bug.cgi?id=45853
I ended up needing to clean up a bunch of our unit testing
in order to test this new code path nicely.
There are also a few PEP8 changes needed to pass check-webkit-style.
- Scripts/webkitpy/tool/bot/queueengine.py:
- Scripts/webkitpy/tool/bot/queueengine_unittest.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/commands/queuestest.py:
- Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
- 4:56 PM Changeset in webkit [67581] by
-
- 7 edits in trunk/WebKit2
Add WKUInt64Ref wrapper for sending uint64_ts.
Reviewed by Jon Honeycutt.
- Shared/APIObject.h:
- Shared/WebNumber.h:
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKBase.h:
- UIProcess/API/C/WKNumber.cpp:
(WKUInt64GetTypeID):
(WKUInt64Create):
(WKUInt64GetValue):
(WKUInt64SetValue):
- UIProcess/API/C/WKNumber.h:
- 4:51 PM Changeset in webkit [67580] by
-
- 2 edits in trunk/WebKitTools
2010-09-15 Simon Fraser <Simon Fraser>
https://bugs.webkit.org/show_bug.cgi?id=45849
WKURLCreateWithCFURL crashes with null url
Fix MiniBrowser crash when the url is not parseable.
- MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController fetch:]):
- 4:43 PM Changeset in webkit [67579] by
-
- 2 edits in trunk/WebCore
2010-09-15 Simon Fraser <Simon Fraser>
Fix chromium build.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
- 4:30 PM Changeset in webkit [67578] by
-
- 28 edits1 add in branches/audio/WebCore
audio branch: lots of changes in preparation for moving to trunk
- more HRTF cleanup (added HRTFUtilities.cpp file)
- general cleanup AudioDestinationMac, AudioFileReaderMac, AudioResourcesMac
- added locking mechanism to AudioContext which is used by AudioNode
- removed some unnecessary method argument names in header files
- 4:29 PM Changeset in webkit [67577] by
-
- 2 edits in trunk/WebKitTools
2010-09-15 Patrick Gansterer <paroga@paroga.com>
Unreviewed.
Adding myself to the committers list.
- Scripts/webkitpy/common/config/committers.py:
- 4:27 PM Changeset in webkit [67576] by
-
- 18 edits in trunk
2010-09-15 Simon Fraser <Simon Fraser>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=44715
maps.google.com flips upside down when zooming map using trackpad in WebKit2 on Mac
Remove the concept of geometry flipping from GraphicsLayer; geometry flipping will
be taken care of in platform code without the need to complicate the GraphicsLayer API.
RenderLayerCompositor no longer sets the geometry orientation for the root
platform layer; platform-specific code does this instead.
This fixes flipped layers in WebKit2, since WebKit2 was already flipping
geometry, and then RenderLayerCompositor was doing an additional flip.
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::GraphicsLayer):
- platform/graphics/GraphicsLayer.h:
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
- platform/graphics/chromium/GraphicsLayerChromium.h:
- platform/graphics/mac/GraphicsLayerCA.h:
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): (WebCore::GraphicsLayerCA::defaultContentsOrientation):
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges):
- platform/graphics/qt/GraphicsLayerQt.h:
- platform/graphics/win/GraphicsLayerCACF.cpp: (WebCore::GraphicsLayerCACF::swapFromOrToTiledLayer):
- platform/graphics/win/GraphicsLayerCACF.h:
- platform/graphics/win/WKCACFLayerRenderer.cpp: (WebCore::WKCACFLayerRenderer::setRootChildLayer):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
- 4:25 PM Changeset in webkit [67575] by
-
- 2 edits in trunk/BugsSite
2010-09-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[reviewtool] Comments should quote previous comments on the same line
https://bugs.webkit.org/show_bug.cgi?id=45847
Now when you reply to a previous comment, the tool will quote the
previous comment in the bugs.webkit.org post. This makes it eaiser for
folks following along in email to understand the discussion.
While I was editing this code, I also cleaned up some of the whitespace
handling in comments.
- code-review.js:
- 4:01 PM WebKit Team edited by
- (diff)
- 3:57 PM Changeset in webkit [67574] by
-
- 9 edits in trunk
Unreviewed.
Reverting my changes as it is breaking several tests on Gtk and Qt.
- 3:55 PM Changeset in webkit [67573] by
-
- 2 edits in trunk
[wx] Build fixes for wxMSW.
- 3:43 PM Changeset in webkit [67572] by
-
- 7 edits1 copy in trunk/WebKitTools
2010-09-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make it possible to run more than one commit-queue instance
https://bugs.webkit.org/show_bug.cgi?id=45786
Mostly we need to make sure the two (or more) instances get
different patches to work on. To do this, I re-worked
the code responsible for getting the next work item to
round trip through the status server. The status server only
vends patches from the work items list, only if those patches
have not had status reported for them in the last hour.
This is another step towards making all queues go through the
status server, thus making it possible to run more than one
instance of various EWS bots (as requested in bug 44292).
The webkitpy changes are already covered by existing unit tests.
The QueueStatusSever sadly has no testing infrastructure yet. :(
- QueueStatusServer/handlers/nextpatch.py: Added.
- QueueStatusServer/index.yaml:
- QueueStatusServer/main.py:
- Scripts/webkitpy/tool/commands/queues.py:
- 3:43 PM Changeset in webkit [67571] by
-
- 2 edits in trunk/LayoutTests
2010-09-15 Erik Arvidsson <arv@chromium.org>
Reviewed by Adam Barth.
Fix regression from bug 32230. The test needed to be updated to reflect the zoom adjusted font-size.
https://bugs.webkit.org/show_bug.cgi?id=45841
- editing/pasteboard/page-zoom.html:
- 3:31 PM Changeset in webkit [67570] by
-
- 9 edits2 adds in trunk
WebCore: Parse system colors in the HTML5 canvas context.
https://bugs.webkit.org/show_bug.cgi?id=39168
Reviewed by Andreas Kling.
Test: fast/css/test-setting-canvas-color.html
Based on previous work by Jan Erik Hanssen <jhanssen@codeaurora.org>
- css/CSSParser.cpp:
(WebCore::CSSParser::parseColor): Changed the function to better match our
early return policy. Also we now return false when we don't parse the color.
This is needed for createFromString to fallback to using parseSystemColor.
(WebCore::CSSParser::parseSystemColor): Made use of the RenderTheme to get
the system colors.
- css/CSSParser.h: Added the new parseSystemColor method.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setStrokeColor): Pass the document to createFromString.
(WebCore::CanvasRenderingContext2D::setFillColor): Ditto.
- html/canvas/CanvasStyle.cpp:
(WebCore::CanvasStyle::createFromString): Try to parse the color using CSSParser::parseColor
and fall back to parseSystemColor if it did not work.
- html/canvas/CanvasStyle.h: Added the new Document* parameter to createFromString.
LayoutTests: Test for: Parse system colors in the HTML5 canvas context.
https://bugs.webkit.org/show_bug.cgi?id=39168
Reviewed by Andreas Kling.
This tests that svg color, deprecated system color and different
type of colors and invalid inputs are still parsed as such.
- fast/css/test-setting-canvas-color-expected.txt: Added.
- fast/css/test-setting-canvas-color.html: Added.
- platform/mac/Skipped:
- platform/qt/Skipped:
- 3:10 PM Changeset in webkit [67569] by
-
- 2 edits in trunk/BugsSite
2010-09-15 Adam Barth <abarth@webkit.org>
Minor UI tweak to the review tool. We want to display newlines in
previous and frozen comments instead of collapsing them.
- PrettyPatch/PrettyPatch.rb:
- 2:23 PM Changeset in webkit [67568] by
-
- 7 edits3 adds in trunk
2010-09-14 Erik Arvidsson <arv@chromium.org>
Reviewed by Darin Adler.
getComputedStyle() returns different values for different zoom levels
https://bugs.webkit.org/show_bug.cgi?id=32230
Test: fast/css/getComputedStyle/computed-style-with-zoom.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::zoomAdjustedPixelValue): (WebCore::zoomAdjustedNumberValue): (WebCore::valueForReflection): (WebCore::getPositionOffsetValue): (WebCore::getBorderRadiusCornerValue): (WebCore::computedTransform): (WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword): (WebCore::CSSComputedStyleDeclaration::valueForShadow): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSComputedStyleDeclaration.h:
- css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
- rendering/RenderObject.h: (WebCore::adjustForAbsoluteZoom):
- rendering/style/RenderStyle.h: (WebCore::adjustForAbsoluteZoom):
- 12:52 PM Changeset in webkit [67567] by
-
- 4 edits2 moves4 adds in trunk/WebCore
2010-09-14 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fully separate Pango and FreeType font backends
https://bugs.webkit.org/show_bug.cgi?id=27442
Split FontPlatformData.h into separate versions for Pango, FreeType and WinCairo.
Include the correct file via #ifdef'd includes, like the Chromium port. Also split
FontCacheCairo.cpp into Pango and FreeType versions, as they had almost no code in
common. Finally, rename FontPlatformDataCairo to FontPlatformDataFreeType, as this
compilation unit is used only by the FreeType backend. This change is important to
prevent upcoming fixes to the FreeType backend from affecting other backends.
No new tests as functionality has not changed.
- CMakeListsEfl.txt: Update source lists.
- GNUmakefile.am: Update source lists.
- platform/graphics/cairo/FontCacheCairo.cpp: Removed.
- platform/graphics/cairo/FontCacheFreeType.cpp: Added. (WebCore::FontCache::platformInit): (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::getTraitsInFamily): (WebCore::isWellKnownFontName): (WebCore::FontCache::createFontPlatformData):
- platform/graphics/cairo/FontPlatformData.h:
- platform/graphics/cairo/FontPlatformDataFreeType.cpp: Renamed from WebCore/platform/graphics/cairo/FontPlatformDataCairo.cpp. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::init): (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::isFixedPitch): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::description):
- platform/graphics/cairo/FontPlatformDataFreeType.h: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::setSize): (WebCore::FontPlatformData::syntheticBold): (WebCore::FontPlatformData::syntheticOblique): (WebCore::FontPlatformData::scaledFont): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::hashTableDeletedFontValue):
- platform/graphics/gtk/FontCachePango.cpp: Added. (WebCore::FontCache::platformInit): (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::getTraitsInFamily): (WebCore::FontCache::createFontPlatformData):
- platform/graphics/gtk/FontPlatformDataPango.h: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::setSize): (WebCore::FontPlatformData::syntheticBold): (WebCore::FontPlatformData::syntheticOblique): (WebCore::FontPlatformData::scaledFont): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::hashTableDeletedFontValue):
- platform/graphics/win/FontPlatformDataCairoWin.h: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::hfont): (WebCore::FontPlatformData::useGDI): (WebCore::FontPlatformData::fontFace): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::setSize): (WebCore::FontPlatformData::syntheticBold): (WebCore::FontPlatformData::syntheticOblique): (WebCore::FontPlatformData::scaledFont): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::isHashTableDeletedValue):
- 12:19 PM Changeset in webkit [67566] by
-
- 2 edits in trunk/WebKit/gtk
2010-09-14 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] fast/events/keydown-numpad-keys.html produces many GLib warnings
https://bugs.webkit.org/show_bug.cgi?id=45775
Handle the toggle-overwrite signal on the GtkTextView used for generating editing
commands. Ignore this signals, as the default handler assumes that the GtkTextView
has a layout and this one does not.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::toggleOverwriteCallback): Added. Cancels the default handler. (WebKit::EditorClient::EditorClient): Attach a handler for toggle-overwrite.
- 12:16 PM Changeset in webkit [67565] by
-
- 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css
2010-09-15 William Siegrist <wsiegrist@apple.com>
Allow for narrow columns in waterfall.
- 12:10 PM Changeset in webkit [67564] by
-
- 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css
2010-09-15 William Siegrist <wsiegrist@apple.com>
Darken and improve contrast for success and failure boxes.
- 10:51 AM Changeset in webkit [67563] by
-
- 2 edits in trunk/LayoutTests
AX: when text is auto-truncated, accessibility bounds are wrong
https://bugs.webkit.org/show_bug.cgi?id=45793
Adding ellipsis-text.html to the skip list for GTK until the reason for its failure
is determined.
- platform/gtk/Skipped:
- 10:34 AM Changeset in webkit [67562] by
-
- 2 edits in trunk/LayoutTests
2010-09-15 Tony Chang <tony@chromium.org>
Unreviewed, remove test that is now passing in test_shell and DRT.
- platform/chromium/test_expectations.txt:
- 10:07 AM Changeset in webkit [67561] by
-
- 5 edits2 adds in trunk
AX: when text is auto-truncated, accessibility bounds are wrong
https://bugs.webkit.org/show_bug.cgi?id=45793
Reviewed by Simon Fraser.
WebCore:
Allow accessibility to retrieve the absoluteQuads of a text node that
clips to the ellipsis.
Test: accessibility/ellipsis-text.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::boundingBoxRect):
- rendering/RenderText.cpp:
(WebCore::ellipsisRectForBox):
Make a common method to retrieve the ellipsis rect.
(WebCore::RenderText::absoluteQuads):
Default into the absoluteQuads method that allows for ellipsis clipping.
(WebCore::RenderText::selectionRectForRepaint):
Use the common method for retrieving the ellipsis.
- rendering/RenderText.h:
LayoutTests:
- accessibility/ellipsis-text-expected.txt: Added.
- accessibility/ellipsis-text.html: Added.
- 10:05 AM Changeset in webkit [67560] by
-
- 3 edits in trunk/WebKitTools
2010-09-15 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
https://bugs.webkit.org/show_bug.cgi?id=45791
Force filenames to be raw bytes before running difflib.unified_diff.
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- 9:44 AM Changeset in webkit [67559] by
-
- 5 edits in trunk
2010-09-15 Ariya Hidayat <ariya@sencha.com>
[Qt] Improve the speed of blur shadow
https://bugs.webkit.org/show_bug.cgi?id=44222
Update pixel test result.
- platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
- platform/qt/fast/box-shadow/basic-shadows-expected.png:
2010-09-15 Ariya Hidayat <ariya@sencha.com>
[Qt] Improve the speed of blur shadow
https://bugs.webkit.org/show_bug.cgi?id=44222
Rewrite the shadow blur function with loop unrolls and sliding step
unification for both horizontal and vertical directions.
This gives significant performance improvement on most cases.
- platform/graphics/qt/ContextShadow.cpp: (WebCore::shadowBlur):
- 9:06 AM Changeset in webkit [67558] by
-
- 3 adds1 delete in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config
2010-09-15 William Siegrist <wsiegrist@apple.com>
Sync buildbot files after upgrade to v0.8.1
- 8:52 AM Changeset in webkit [67557] by
-
- 3 edits in trunk/LayoutTests
2010-09-15 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
fast/dom/DeviceOrientation/add-listener-from-callback flaky
https://bugs.webkit.org/show_bug.cgi?id=45814
When we call addEventListener(), an event is sent to all registered
event listeners on that page. So in the existing test, both the calls
to setMockDeviceOrientation() and addEventListener() will trigger events
to fire asynchronously on both listeners (both will be registered by the
time the event fires), giving a total of five events. A race condition
exists as to whether the test finishes after the third event, before
the fourth event fires.
This patch fixes the problem by expecting the correct number of events
to fire. We also remove the call to setMockDeviceOrientation() as this
adds extra complication and is tested in update.html.
- fast/dom/DeviceOrientation/add-listener-from-callback-expected.txt:
- fast/dom/DeviceOrientation/script-tests/add-listener-from-callback.js: (checkOrientation): (firstListener):
- 8:35 AM Changeset in webkit [67556] by
-
- 2 edits in trunk/PlanetWebKit
Use Qt Labs' WebKit category feed instead of filtering on "webkit"
Looks like the URL of the WebKit category feed changed since this blog
was first added to Planet WebKit.
Rubber-stamped by David Kilzer.
- config.ini:
- 8:20 AM Changeset in webkit [67555] by
-
- 2 edits in trunk/PlanetWebKit
Only include Qt Labs posts that mention WebKit
All other feeds are either WebKit-specific or are filtered on
"webkit". This makes Qt Labs match all the others. This should help
keep off-topic posts off of Planet WebKit.
Fixes <http://webkit.org/b/45818> Planet WebKit contains many
off-topic posts from Qt Labs
Reviewed by David Kilzer.
- config.ini: Filter the Qt Labs feed on "webkit" like we do for all
other non-WebKit-specific feeds.
- 6:32 AM Changeset in webkit [67554] by
-
- 3 edits in trunk/WebKitTools
[Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
https://bugs.webkit.org/show_bug.cgi?id=35247
Reviewed by Tor Arne Vestbø.
The main issue when changing the views is that the plugins and any other components that
depend on view specific attributes such as the native window id are not teared down.
Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
we decided to work around this in QtTestBrowser by making toggling between QWebView
and QGraphicsWebView also re-create the page.
- QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::initializeView):
- QtTestBrowser/mainwindow.h:
- 6:25 AM Changeset in webkit [67553] by
-
- 38 edits in trunk
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
- inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::endTiming):
- inspector/InspectorResource.h:
- loader/PingLoader.h: (WebCore::PingLoader::didFinishLoading):
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didFinishLoading):
- loader/ResourceLoader.h:
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFinishLoading):
- loader/appcache/ApplicationCacheGroup.h:
- loader/icon/IconFetcher.cpp: (WebCore::IconFetcher::didFinishLoading):
- loader/icon/IconFetcher.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (StreamingClient::didFinishLoading):
- platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::notifyFinish):
- platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didFinishLoading):
- platform/network/ResourceLoadTiming.h: (WebCore::ResourceLoadTiming::deepCopy): (WebCore::ResourceLoadTiming::operator==): (WebCore::ResourceLoadTiming::ResourceLoadTiming):
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFinishLoading):
- platform/network/curl/ResourceHandleCurl.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::parseDataUrl):
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (WebCoreSynchronousLoaderClient::didFinishLoading):
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::finish):
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail):
- platform/network/win/ResourceHandleWin.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
- public/WebURLLoadTiming.h:
- public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::didFinishLoading):
- src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didFinishLoading):
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::didFinishLoading):
- src/WebURLLoadTiming.cpp: (WebKit::WebURLLoadTiming::receiveHeadersStart): (WebKit::WebURLLoadTiming::setReceiveHeadersStart):
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
- webkit/webkitdownload.cpp: (DownloadClient::didFinishLoading):
- 5:56 AM Changeset in webkit [67552] by
-
- 37 edits in trunk
2010-09-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67551.
http://trac.webkit.org/changeset/67551
https://bugs.webkit.org/show_bug.cgi?id=45816
"Plugin tests fail" (Requested by yurys on #webkit).
- inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::didCloseWebSocket):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::endTiming):
- inspector/InspectorResource.h:
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::didFinishLoading):
- loader/MainResourceLoader.h:
- loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
- loader/PingLoader.h: (WebCore::PingLoader::didFinishLoading):
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::didFinishLoad): (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading): (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
- loader/ResourceLoadNotifier.h:
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didFinishLoading): (WebCore::ResourceLoader::didFinishLoadingOnePart):
- loader/ResourceLoader.h:
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didFinishLoading):
- loader/SubresourceLoader.h:
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFinishLoading):
- loader/appcache/ApplicationCacheGroup.h:
- loader/icon/IconFetcher.cpp: (WebCore::IconFetcher::didFinishLoading):
- loader/icon/IconFetcher.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (StreamingClient::didFinishLoading):
- platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::notifyFinish):
- platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didFinishLoading):
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFinishLoading): (WebCore::WebCoreSynchronousLoaderClient::didFinishLoading):
- platform/network/curl/ResourceHandleCurl.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::parseDataUrl):
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (WebCoreSynchronousLoaderClient::didFinishLoading):
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::finish):
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail): (WebCore::finishedCallback): (WebCore::parseDataUrl):
- platform/network/win/ResourceHandleWin.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):
2010-09-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67551.
http://trac.webkit.org/changeset/67551
https://bugs.webkit.org/show_bug.cgi?id=45816
"Plugin tests fail" (Requested by yurys on #webkit).
- public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::didFinishLoading):
- src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didFinishLoading):
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::didFinishLoading):
2010-09-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r67551.
http://trac.webkit.org/changeset/67551
https://bugs.webkit.org/show_bug.cgi?id=45816
"Plugin tests fail" (Requested by yurys on #webkit).
- webkit/webkitdownload.cpp: (DownloadClient::didFinishLoading):
- 5:04 AM Changeset in webkit [67551] by
-
- 37 edits in trunk
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
- inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::endTiming):
- inspector/InspectorResource.h:
- loader/PingLoader.h: (WebCore::PingLoader::didFinishLoading):
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didFinishLoading):
- loader/ResourceLoader.h:
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFinishLoading):
- loader/appcache/ApplicationCacheGroup.h:
- loader/icon/IconFetcher.cpp: (WebCore::IconFetcher::didFinishLoading):
- loader/icon/IconFetcher.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (StreamingClient::didFinishLoading):
- platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::notifyFinish):
- platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didFinishLoading):
- platform/network/ResourceLoadTiming.h: (WebCore::ResourceLoadTiming::deepCopy): (WebCore::ResourceLoadTiming::operator==): (WebCore::ResourceLoadTiming::ResourceLoadTiming):
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFinishLoading):
- platform/network/curl/ResourceHandleCurl.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::parseDataUrl):
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (WebCoreSynchronousLoaderClient::didFinishLoading):
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::finish):
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail):
- platform/network/win/ResourceHandleWin.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
- public/WebURLLoadTiming.h:
- public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::didFinishLoading):
- src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didFinishLoading):
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::didFinishLoading):
- src/WebURLLoadTiming.cpp: (WebKit::WebURLLoadTiming::receiveHeadersStart): (WebKit::WebURLLoadTiming::setReceiveHeadersStart):
2010-09-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Provide network-based load timing.
Before this change, inspector used timers taken from
within WebCore notifications (that are by definition
synchronous and serialized). As a result, timing was
affected by the routines running on the main thread
(JavaScript and such).
https://bugs.webkit.org/show_bug.cgi?id=45664
- webkit/webkitdownload.cpp: (DownloadClient::didFinishLoading):
- 4:45 AM Changeset in webkit [67550] by
-
- 1 edit40 adds in trunk/LayoutTests
2010-09-15 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
[Chromium] rebaseline 10 new svg tests added in 67544
https://bugs.webkit.org/show_bug.cgi?id=45813
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
- 4:34 AM Changeset in webkit [67549] by
-
- 2 edits in trunk/WebKit/qt
[Qt] Update the Symbian def files
Re-freeze with the viewport meta tag updates.
- symbian/eabi/QtWebKitu.def:
- 4:34 AM Changeset in webkit [67548] by
-
- 2 edits in trunk/LayoutTests
2010-09-15 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
[Chromium] mark new viewport tests as failing rather then skip them
https://bugs.webkit.org/show_bug.cgi?id=45652
- platform/chromium/test_expectations.txt:
- 4:17 AM Changeset in webkit [67547] by
-
- 10 edits in trunk
2010-09-14 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: small refactoring for monitorXHR backend property.
Our Inspector API is quite big and can be simplified a bit.
As example for single backend property like monitoringXHR we
have 4 functions in the API. Two functions for frontend
enableMonitoringXHR/disableMonitoringXHR and
two functions for backend monitoringXHRWasEnabled and
monitoringXHRWasDisabled. These functions can be replaced by
one setMonitoringXHR with one 'in' and one 'out' argument.
The initial state of the flag can be gathered from backend
with help of getSettings call where additional section was
added for backend state information.
- inspector/Inspector.idl:
- inspector/InspectorController.cpp:
- inspector/InspectorController.h:
- inspector/front-end/ConsoleView.js:
- inspector/front-end/Settings.js:
- inspector/front-end/inspector.js:
2010-09-14 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: small refactoring for monitorXHR backend property.
Our Inspector API is quite big and can be simplified a bit.
As example for single backend property like monitoringXHR we
have 4 functions in the API. Two functions for frontend
enableMonitoringXHR/disableMonitoringXHR and
two functions for backend monitoringXHRWasEnabled and
monitoringXHRWasDisabled. These functions can be replaced by
one setMonitoringXHR with one 'in' and one 'out' argument.
The initial state of the flag can be gathered from backend
with help of getSettings call where additional section was
added for backend state information.
- inspector/Inspector.idl:
- inspector/InspectorController.cpp:
- inspector/InspectorController.h:
- inspector/front-end/ConsoleView.js:
- inspector/front-end/Settings.js:
- inspector/front-end/inspector.js:
- 3:05 AM Changeset in webkit [67546] by
-
- 2 edits in trunk/LayoutTests
2010-09-15 Steve Block <steveblock@google.com>
Reviewed by Kent Tamura.
LayoutTest fast/dom/Geolocation/clear-watch-invalid-id-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=45783
This test synchronously navigates the page to a new URL from its main script file.
This navigation causes WebView.onPageFinished() to be called for the test page.
The problem is that this may occur before js-test-post.js, which is included by the
test and calls layoutTestController.waitUntilDone(), is loaded and parsed. As a
result, the test is incorrectly deemed to have finished as soon as the navigation
is started and the output will therefore be incorrect.
This patch fixes the problem by initiating the page navigation from
the onload handler, which is not fired until all resources have been
loaded and parsed. This guarantees that WebView.onPageFinished() is
not called until after layoutTestController.waitUntilDone() has been
called.
- fast/dom/Geolocation/script-tests/clear-watch-invalid-id-crash.js:
- 2:44 AM Changeset in webkit [67545] by
-
- 2 edits in trunk/WebCore
2010-09-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Multiline console does not work on Windows / Linux.
https://bugs.webkit.org/show_bug.cgi?id=45807
- inspector/front-end/ConsoleView.js:
- 2:13 AM Changeset in webkit [67544] by
-
- 4 edits50 adds in trunk
2010-09-15 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Dirk Schulze.
SVGFETurbulenceElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=45809
Adding layout tests for feTurbulence dynamic changes.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop.html: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop.html: Added.
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-dom-baseFrequency-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-dom-numOctaves-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-dom-seed-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-dom-stitchTiles-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-dom-type-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-baseFrequency-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-numOctaves-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-seed-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-stitchTiles-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-type-prop.js: Added. (executeTest):
2010-09-15 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Dirk Schulze.
SVGFETurbulenceElement doesn't support dynamic invalidation, when attributes change.
A typo (noStich instead of nostitch) is also fixed in this patch.
https://bugs.webkit.org/show_bug.cgi?id=45809
Tests: svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr.html
svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr.html
svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr.html
svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr.html
svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr.html
svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html
svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop.html
svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop.html
svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop.html
svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop.html
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::parseMappedAttribute): (WebCore::SVGFETurbulenceElement::svgAttributeChanged):
- svg/SVGFETurbulenceElement.h:
- 1:58 AM Changeset in webkit [67543] by
-
- 1 edit in branches/chromium/517/WebCore/inspector/InspectorController.cpp
Merge 67185 - 2010-09-09 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Joseph Pecoraro.
WebInspector: Selecting 'inspect element' always shows body in inspector instead of clicked element.
- Open any page
- Right-click on any element, select "Inspect Element"
- Web Inspector is opened but the <body> element (for HTML) is focused rather than the selected element
- Inspect the Web Inspector. An error message is logged in the console.
The regression was introduced in http://trac.webkit.org/changeset/66012 - focusNode() is invoked in
InspectorController::populateScriptObjects() before the main document is set for the InspectorDOMAgent
instance (which makes focusNode() bail out prematurely).
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):
TBR=loislo@chromium.org
Review URL: http://codereview.chromium.org/3385005
- 1:55 AM Changeset in webkit [67542] by
-
- 1 edit2 copies in branches/chromium/517
Merge 66813 - 2010-08-31 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: browser crashes on attempt to evaluate "alert(1)" while staying on a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=44943
Test: inspector/debugger-suspend-active-dom-objects.html
- page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
2010-08-31 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: browser crashes on attempt to evaluate "alert(1)" while staying on a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=44943
- inspector/debugger-suspend-active-dom-objects-expected.txt: Added.
- inspector/debugger-suspend-active-dom-objects.html: Added.
TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/3446004
- 1:46 AM Changeset in webkit [67541] by
-
- 2 edits in trunk/WebCore
2010-09-15 Patrick Gansterer <paroga@paroga.com>
Reviewed by Kenneth Rohde Christiansen.
[WINCE] Avoid memcpy in TextCodecWinCE::encode
https://bugs.webkit.org/show_bug.cgi?id=45468
- platform/text/wince/TextCodecWinCE.cpp: (WebCore::TextCodecWinCE::encode):
- 1:29 AM Changeset in webkit [67540] by
-
- 2 edits in trunk/LayoutTests
2010-09-15 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
[Web Inspector] mark two debugger tests as slow on win debug chromium
https://bugs.webkit.org/show_bug.cgi?id=45742
- platform/chromium/test_expectations.txt:
- 12:20 AM Changeset in webkit [67539] by
-
- 2 edits in trunk/WebKit/mac
Roll out r67533 to fix the build.
