Timeline



Oct 3, 2010:

11:22 PM Changeset in webkit [69001] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-10-03 Simon Fraser <Simon Fraser>

Make sure to enter all tests when creating the database
for the first time.

When migrating to a new version of the suite, be sure to
sync up the database and testinfo.data by removing old
tests, and inserting new ones.

  • CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.openDatabase.creation): (TestSuite.prototype.databaseCreated): (TestSuite.prototype.populateDatabaseFromTestInfoData): (TestSuite.prototype.insertTest):
11:22 PM Changeset in webkit [69000] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-10-03 Simon Fraser <Simon Fraser>

More work on treating HTML4 and XHTML1 independently; when
changing the format, rebuild the test list, and update the
numbers in the chapter popup.

  • CSSTestSuiteHarness/harness/harness.js: (Test): (Test.prototype.runForFormat): (Test.prototype.completedForFormat): (ChapterSection): (ChapterSection.prototype.countTests): (Chapter): (Chapter.prototype.description): (Chapter.prototype.countTests): (Chapter.prototype.testCount): (Chapter.prototype.untestedCount): (TestSuite.prototype.buildChapters): (TestSuite.prototype.loadCurrentTest): (TestSuite.prototype.updateProgressLabel): (TestSuite.prototype.processFlags): (TestSuite.prototype.formatChanged):
11:21 PM Changeset in webkit [68999] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-10-03 Simon Fraser <Simon Fraser>

Update test suite version 20101001.

Handle database migration, and delete tests from the db that are
not present in testinfo.data.

Load about:blank into the test frame before the test url, to make
missing tests more obvious.

  • CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.loadTest): (TestSuite.prototype.openDatabase.creation): (TestSuite.prototype.openDatabase.migration1_0To1_1): (TestSuite.prototype.openDatabase.if.return): (TestSuite.prototype.databaseReady): (TestSuite.prototype.populateDatabaseFromTestInfoData): (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction): (TestSuite.prototype.syncDatabaseWithTestInfoData):
11:20 PM Changeset in webkit [68998] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitLibraries

Unreviewed build fix.

WinCairo also needs access to the <inttypes.h> header requirement
introduced by Bug 46357.

  • win/tools/vsprops/WinCairo.vsprops:
11:14 PM Changeset in webkit [68997] by tkent@chromium.org
  • 5 edits in trunk/WebCore

2010-10-03 Kent Tamura <​tkent@chromium.org>

Unreviewed, build fix for r68996.

  • html/BaseDateAndTimeInputType.cpp: Includes <wtf/MathExtras.h> for isfinite().
  • html/MonthInputType.cpp: ditto.
  • html/NumberInputType.cpp: ditto.
  • html/RangeInputType.cpp: ditto.
10:59 PM Changeset in webkit [68996] by tkent@chromium.org
  • 28 edits
    2 copies in trunk/WebCore

2010-10-03 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Refactor HTMLInputElement: Move parseToDouble() and
parseToDateComponents() to InputType.
​https://bugs.webkit.org/show_bug.cgi?id=46965

Introduce BaseDateAndTimeInputType, which is a super class of
date, datetime, datetime-local, month, time, and week types.

No new tests. Just a refactoring.

  • Android.mk: Add BaseDateAndTimeInputType.
  • CMakeLists.txt: ditto.
  • GNUmakefile.am: ditto.
  • WebCore.gypi: ditto.
  • WebCore.pro: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • html/BaseDateAndTimeInputType.cpp: Added. (WebCore::BaseDateAndTimeInputType::parseToDouble): (WebCore::BaseDateAndTimeInputType::parseToDateComponents):
  • html/BaseDateAndTimeInputType.h: Added. (WebCore::BaseDateAndTimeInputType::BaseDateAndTimeInputType):
  • html/DateInputType.cpp: (WebCore::DateInputType::parseToDateComponentsInternal):
  • html/DateInputType.h: (WebCore::DateInputType::DateInputType):
  • html/DateTimeInputType.cpp: (WebCore::DateTimeInputType::parseToDateComponentsInternal):
  • html/DateTimeInputType.h: (WebCore::DateTimeInputType::DateTimeInputType):
  • html/DateTimeLocalInputType.cpp: (WebCore::DateTimeLocalInputType::parseToDateComponentsInternal):
  • html/DateTimeLocalInputType.h: (WebCore::DateTimeLocalInputType::DateTimeLocalInputType):
  • html/HTMLInputElement.cpp: Replace parseToD* calls with m_inputType->parseToD*. (WebCore::HTMLInputElement::typeMismatch): (WebCore::HTMLInputElement::rangeUnderflow): (WebCore::HTMLInputElement::rangeOverflow): (WebCore::HTMLInputElement::minimum): (WebCore::HTMLInputElement::maximum): (WebCore::HTMLInputElement::stepBase): (WebCore::HTMLInputElement::stepMismatch): (WebCore::HTMLInputElement::applyStep): (WebCore::HTMLInputElement::valueAsDate): (WebCore::HTMLInputElement::valueAsNumber): (WebCore::HTMLInputElement::handleKeyEventForRange): (WebCore::HTMLInputElement::stepUpFromRenderer):
  • html/HTMLInputElement.h:
  • html/InputType.cpp: (WebCore::InputType::parseToDouble): (WebCore::InputType::parseToDateComponents):
  • html/InputType.h:
  • html/MonthInputType.cpp: (WebCore::MonthInputType::parseToDouble): (WebCore::MonthInputType::parseToDateComponentsInternal):
  • html/MonthInputType.h: (WebCore::MonthInputType::MonthInputType):
  • html/NumberInputType.cpp: (WebCore::NumberInputType::parseToDouble):
  • html/NumberInputType.h:
  • html/RangeInputType.cpp: (WebCore::RangeInputType::parseToDouble):
  • html/RangeInputType.h:
  • html/TimeInputType.cpp: (WebCore::TimeInputType::parseToDateComponentsInternal):
  • html/TimeInputType.h: (WebCore::TimeInputType::TimeInputType):
  • html/WeekInputType.cpp: (WebCore::WeekInputType::parseToDateComponentsInternal):
  • html/WeekInputType.h: (WebCore::WeekInputType::WeekInputType):
10:44 PM Changeset in webkit [68995] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, remove redundant expectations.

  • platform/chromium/test_expectations.txt:
8:53 PM Changeset in webkit [68994] by morrita@google.com
  • 245 edits
    227 adds in trunk/LayoutTests

2010-10-03 MORITA Hajime <​morrita@google.com>

Unrevied, added test expectations for because of the massive SVG change in r68976.
This chanage is for svg/W3C-SVG-1.1/*.

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/color-prof-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/color-prop-02-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/color-prop-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-coord-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-coord-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-events-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-order-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-order-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/linking-a-07-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-fill-05-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-10-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-13-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-14-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-15-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-elems-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-elems-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-elems-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/script-handle-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/script-handle-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/script-handle-04-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-group-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-group-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-05-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-06-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-08-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-09-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-10-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/styling-css-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-align-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-align-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-align-04-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-07-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-08-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-tref-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-ws-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-ws-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/color-prop-02-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-coord-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-coord-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-order-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-order-03-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-a-07-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-fill-05-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-10-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-13-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-14-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-15-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-elems-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-elems-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-elems-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-group-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-group-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-05-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-06-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-08-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-09-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-10-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-07-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-08-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt:
  • platform/chromium/test_expectations.txt:
8:38 PM Changeset in webkit [68993] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-03 Kent Tamura <​tkent@chromium.org>

Unreviewed, upstreaming test expectations in Chromium tree.

  • platform/chromium/test_expectations.txt:
7:37 PM Changeset in webkit [68992] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-03 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update for r68976.

  • platform/chromium/test_expectations.txt:
7:29 PM Changeset in webkit [68991] by Dimitri Glazkov
  • 2 edits
    1 delete in trunk/LayoutTests

2010-10-03 Dimitri Glazkov <Dimitri Glazkov>

Move chromium-win-xp-specific result to its proper place.

  • platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.txt: Removed.
6:22 PM Changeset in webkit [68990] by Dimitri Glazkov
  • 64 edits
    27 copies
    19 adds in trunk/LayoutTests

2010-10-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Nikolas Zimmermann.

[Chromium] Rebaseline svg/custom tests due to ​http://trac.webkit.org/changeset/68976.
​https://bugs.webkit.org/show_bug.cgi?id=47061

  • platform/chromium-linux/svg/custom/alignment-baseline-modes-expected.checksum:
  • platform/chromium-linux/svg/custom/alignment-baseline-modes-expected.png:
  • platform/chromium-linux/svg/custom/alignment-baseline-modes-expected.txt: Added.
  • platform/chromium-linux/svg/custom/altglyph-expected.checksum:
  • platform/chromium-linux/svg/custom/altglyph-expected.png:
  • platform/chromium-linux/svg/custom/altglyph-expected.txt: Added.
  • platform/chromium-linux/svg/custom/broken-internal-references-expected.txt:
  • platform/chromium-linux/svg/custom/container-opacity-clip-viewBox-expected.txt: Added.
  • platform/chromium-linux/svg/custom/dominant-baseline-modes-expected.checksum:
  • platform/chromium-linux/svg/custom/dominant-baseline-modes-expected.png:
  • platform/chromium-linux/svg/custom/dominant-baseline-modes-expected.txt: Added.
  • platform/chromium-linux/svg/custom/glyph-transformation-with-hkern-expected.checksum:
  • platform/chromium-linux/svg/custom/glyph-transformation-with-hkern-expected.png:
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.checksum:
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.txt: Added.
  • platform/chromium-linux/svg/custom/invalid-fill-expected.txt: Added.
  • platform/chromium-linux/svg/custom/invalid-fill-hex-expected.txt: Added.
  • platform/chromium-linux/svg/custom/js-late-clipPath-and-object-creation-expected.txt: Added.
  • platform/chromium-linux/svg/custom/js-late-clipPath-creation-expected.txt: Added.
  • platform/chromium-linux/svg/custom/js-late-gradient-and-object-creation-expected.txt: Added.
  • platform/chromium-linux/svg/custom/js-late-gradient-creation-expected.txt: Added.
  • platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.txt:
  • platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.txt: Added.
  • platform/chromium-linux/svg/custom/pattern-rotate-expected.txt: Added.
  • platform/chromium-linux/svg/custom/pattern-with-transformation-expected.txt: Added.
  • platform/chromium-linux/svg/custom/pointer-events-text-expected.txt: Added.
  • platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Added.
  • platform/chromium-linux/svg/custom/stroke-width-large-expected.txt:
  • platform/chromium-linux/svg/custom/struct-use-09-b-expected.txt:
  • platform/chromium-linux/svg/custom/style-attribute-font-size-expected.txt: Added.
  • platform/chromium-linux/svg/custom/text-clip-expected.txt: Added.
  • platform/chromium-linux/svg/custom/text-dom-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/custom/text-filter-expected.checksum:
  • platform/chromium-linux/svg/custom/text-filter-expected.png:
  • platform/chromium-linux/svg/custom/text-filter-expected.txt: Added.
  • platform/chromium-linux/svg/custom/text-letter-spacing-expected.txt: Added.
  • platform/chromium-linux/svg/custom/text-linking-expected.txt: Added.
  • platform/chromium-linux/svg/custom/text-repaint-including-stroke-expected.txt: Added.
  • platform/chromium-linux/svg/custom/text-rotation-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/text-rotation-expected.png: Added.
  • platform/chromium-linux/svg/custom/text-rotation-expected.txt: Added.
  • platform/chromium-linux/svg/custom/text-whitespace-handling-expected.txt: Added.
  • platform/chromium-linux/svg/custom/text-x-dx-lists-expected.txt: Added.
  • platform/chromium-linux/svg/custom/text-x-dy-lists-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/text-x-dy-lists-expected.png: Added.
  • platform/chromium-linux/svg/custom/text-x-dy-lists-expected.txt: Added.
  • platform/chromium-linux/svg/custom/text-x-override-in-tspan-child-expected.checksum:
  • platform/chromium-linux/svg/custom/text-x-override-in-tspan-child-expected.png:
  • platform/chromium-linux/svg/custom/text-x-override-in-tspan-child-expected.txt: Added.
  • platform/chromium-linux/svg/custom/use-on-text-expected.txt: Added.
  • platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.txt: Added.
  • platform/chromium-mac/svg/custom/altglyph-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/altglyph-expected.png: Added.
  • platform/chromium-win/svg/custom/alignment-baseline-modes-expected.checksum:
  • platform/chromium-win/svg/custom/alignment-baseline-modes-expected.png:
  • platform/chromium-win/svg/custom/alignment-baseline-modes-expected.txt:
  • platform/chromium-win/svg/custom/altglyph-expected.checksum:
  • platform/chromium-win/svg/custom/altglyph-expected.png:
  • platform/chromium-win/svg/custom/altglyph-expected.txt:
  • platform/chromium-win/svg/custom/broken-internal-references-expected.txt:
  • platform/chromium-win/svg/custom/container-opacity-clip-viewBox-expected.txt:
  • platform/chromium-win/svg/custom/dominant-baseline-modes-expected.checksum:
  • platform/chromium-win/svg/custom/dominant-baseline-modes-expected.png:
  • platform/chromium-win/svg/custom/dominant-baseline-modes-expected.txt:
  • platform/chromium-win/svg/custom/glyph-transformation-with-hkern-expected.checksum:
  • platform/chromium-win/svg/custom/glyph-transformation-with-hkern-expected.png:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.checksum:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.txt:
  • platform/chromium-win/svg/custom/invalid-fill-expected.txt:
  • platform/chromium-win/svg/custom/invalid-fill-hex-expected.txt:
  • platform/chromium-win/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-clipPath-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-gradient-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.txt: Added.
  • platform/chromium-win/svg/custom/js-late-pattern-creation-expected.txt:
  • platform/chromium-win/svg/custom/pattern-rotate-expected.txt:
  • platform/chromium-win/svg/custom/pattern-with-transformation-expected.txt:
  • platform/chromium-win/svg/custom/pointer-events-text-expected.txt:
  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/chromium-win/svg/custom/stroke-width-large-expected.txt:
  • platform/chromium-win/svg/custom/struct-use-09-b-expected.checksum: Added.
  • platform/chromium-win/svg/custom/struct-use-09-b-expected.png: Added.
  • platform/chromium-win/svg/custom/struct-use-09-b-expected.txt: Added.
  • platform/chromium-win/svg/custom/style-attribute-font-size-expected.txt:
  • platform/chromium-win/svg/custom/text-clip-expected.txt:
  • platform/chromium-win/svg/custom/text-dom-01-f-expected.txt:
  • platform/chromium-win/svg/custom/text-filter-expected.checksum:
  • platform/chromium-win/svg/custom/text-filter-expected.png:
  • platform/chromium-win/svg/custom/text-filter-expected.txt:
  • platform/chromium-win/svg/custom/text-letter-spacing-expected.txt:
  • platform/chromium-win/svg/custom/text-linking-expected.txt:
  • platform/chromium-win/svg/custom/text-repaint-including-stroke-expected.txt:
  • platform/chromium-win/svg/custom/text-rotation-expected.checksum: Added.
  • platform/chromium-win/svg/custom/text-rotation-expected.png: Added.
  • platform/chromium-win/svg/custom/text-rotation-expected.txt: Added.
  • platform/chromium-win/svg/custom/text-whitespace-handling-expected.txt:
  • platform/chromium-win/svg/custom/text-x-dx-lists-expected.txt:
  • platform/chromium-win/svg/custom/text-x-dy-lists-expected.checksum: Added.
  • platform/chromium-win/svg/custom/text-x-dy-lists-expected.png: Added.
  • platform/chromium-win/svg/custom/text-x-dy-lists-expected.txt: Added.
  • platform/chromium-win/svg/custom/text-x-override-in-tspan-child-expected.checksum:
  • platform/chromium-win/svg/custom/text-x-override-in-tspan-child-expected.png:
  • platform/chromium-win/svg/custom/text-x-override-in-tspan-child-expected.txt:
  • platform/chromium-win/svg/custom/use-on-text-expected.txt:
  • platform/chromium-win/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
  • platform/chromium/test_expectations.txt:
2:50 PM Changeset in webkit [68989] by andersca@apple.com
  • 14 edits in trunk/WebKit2

Implement newly added Plugin/PluginController member functions for out of process plug-ins
​https://bugs.webkit.org/show_bug.cgi?id=47065
<rdar://problem/8507194>

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Arguments.h:

Add typedefs.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):
Add new handleMessage overload.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::create):
Add an isPrivateBrowsingEnabled boolean.

(WebKit::PluginControllerProxy::PluginControllerProxy):
Add an isPrivateBrowsingEnabled boolean.

(WebKit::PluginControllerProxy::proxiesForURL):
(WebKit::PluginControllerProxy::cookiesForURL):
(WebKit::PluginControllerProxy::setCookiesForURL):
Send messages to the web process.

(WebKit::PluginControllerProxy::isPrivateBrowsingEnabled):
Return whether private browsing is enabled or not.

(WebKit::PluginControllerProxy::handleKeyboardEvent):
Call Plugin::handleKeyboardEvent.

(WebKit::PluginControllerProxy::privateBrowsingStateChanged):
Call Plugin::privateBrowsingStateChanged.

  • PluginProcess/PluginControllerProxy.messages.in:

Add new messages.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::createPlugin):
Pass the isPrivateBrowsingEnabled flag.

  • PluginProcess/WebProcessConnection.h:
  • PluginProcess/WebProcessConnection.messages.in:

Update CreatePlugin message parameters.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::didReceiveMessage):
(WebKit::PluginProcessConnection::didReceiveSyncMessage):
It's OK for a plug-in to not get a sync message.

  • WebProcess/Plugins/PluginProcessConnection.h:
  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::handleKeyboardEvent):
(WebKit::PluginProxy::privateBrowsingStateChanged):
Send messages.

(WebKit::PluginProxy::proxiesForURL):
(WebKit::PluginProxy::cookiesForURL):
(WebKit::PluginProxy::setCookiesForURL):
Call the plug-in controller.

  • WebProcess/Plugins/PluginProxy.messages.in:

Add new messages.

2:02 PM Changeset in webkit [68988] by andersca@apple.com
  • 8 edits in trunk/WebKit2

Send keyboard events to plug-ins
​https://bugs.webkit.org/show_bug.cgi?id=47064
<rdar://problem/8507148>

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::handleKeyboardEvent):
Call platformHandleKeyboardEvent.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::modifierFlags):
Return the modifier flags given a WebKeyboardEvent.

(WebKit::initializeKeyboardEvent):
Initialize an NPCocoaEvent from a WebKeyboardEvent.

(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Initialize the event and dispatch it using NPP_HandleEvent.

  • WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:

(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Add stub.

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Add stub.

  • WebProcess/Plugins/Plugin.h:

Add handleKeyboardEvent.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::handleEvent):
Call Plugin::handleKeyboardEvent if we see a keydown or keyup event.

8:35 AM Changeset in webkit [68987] by Dimitri Glazkov
  • 2 edits in trunk

2010-10-03 Dimitri Glazkov <Dimitri Glazkov>

Add Chromium depot_tools to files that git should ignore.

  • .gitignore: Added WebKit/chromium/depot_tools.
2:22 AM Changeset in webkit [68986] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-10-03 Adam Barth <​abarth@webkit.org>

Reviewed by Holger Freyther.

ASSERT(m_state = Open); is bad news bears
​https://bugs.webkit.org/show_bug.cgi?id=47057

Added by ap (review by darin) in ​http://trac.webkit.org/changeset/50951
Too bad the compiler doesn't catch these errors. I don't believe this
is possible to test.

  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::writeStreamCallback):
2:00 AM Changeset in webkit [68985] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-10-03 Adam Barth <​abarth@webkit.org>

Reviewed by Holger Freyther.

All the WebSocket tests crash
​https://bugs.webkit.org/show_bug.cgi?id=47056

More code that tries to hold onto temporaries with references.

  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didOpen):
1:19 AM Changeset in webkit [68984] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-10-03 Adam Barth <​abarth@webkit.org>

Reviewed by Holger Freyther.

All the WebSocket tests crash
​https://bugs.webkit.org/show_bug.cgi?id=47055

This code attempts to hold onto temporary objects using references.
That doesn't work in C++. Instead, we need to actually store the
objects somewhere.

  • bindings/js/JSWebSocketCustom.cpp: (WebCore::JSWebSocketConstructor::constructJSWebSocket):

Oct 2, 2010:

10:32 PM Changeset in webkit [68983] by Simon Fraser
  • 3 edits in trunk/WebKitTools

2010-10-02 Simon Fraser <Simon Fraser>

Add the ability to jump to a specific test.

  • CSSTestSuiteHarness/harness/harness.html:
  • CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.goToTestByName): (TestSuite.prototype.switchToFormat):
9:24 PM Changeset in webkit [68982] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-10-02 Simon Fraser <Simon Fraser>

For a ref test, load the ref in the same format (HTML4 vs XHTML1)
as the test.

  • CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.loadRef):
9:24 PM Changeset in webkit [68981] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-10-02 Simon Fraser <Simon Fraser>

Update the UI to reflect the fact that each test needs to be tested
in both HTML4 and XHTML1 format.

  • CSSTestSuiteHarness/harness/harness.js: (Test): (Chapter.prototype.description): (Chapter.prototype.untestedCount): (TestSuite.prototype.fillChapterPopup): (TestSuite.prototype.updateChapterPopup): (TestSuite.prototype.fillTestList): (TestSuite.prototype.updateTestList): (TestSuite.prototype.goToNextIncompleteTest): (TestSuite.prototype.firstIncompleteTestIndex): (TestSuite.prototype.recordResult): (TestSuite.prototype.formatChanged): (TestSuite.prototype.markTestCompleted): (TestSuite.prototype.resetTestStatus):
2:44 PM Changeset in webkit [68980] by hclam@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Build fix. Not reviewed.

Remove LayoutTests/websocket and the dummy file.

  • websocket/tests/workers/README: Removed.
2:18 PM Changeset in webkit [68979] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Build fix. Not reviewed.

Add test expectations because of the massive SVG change in r68976.

  • platform/chromium/test_expectations.txt:
2:16 PM Changeset in webkit [68978] by diegohcg@webkit.org
  • 4 edits
    4 adds in trunk

[Qt] Provide Qt support for DeviceMotion/Orientation clients
​https://bugs.webkit.org/show_bug.cgi?id=47051

Reviewed by Kenneth Rohde Christiansen.

WebCore:

Add Qt DeviceMotion/Orientation dummy clients in build system.

  • WebCore.pro:

WebKit/qt:

Dummy implementation of DeviceMotion/Orientation client classes
to make possible to hook up motion/orientation data
in further implementations.

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/DeviceMotionClientQt.cpp: Added.

(WebCore::DeviceMotionClientQt::DeviceMotionClientQt):
(WebCore::DeviceMotionClientQt::setController):
(WebCore::DeviceMotionClientQt::startUpdating):
(WebCore::DeviceMotionClientQt::stopUpdating):
(WebCore::DeviceMotionClientQt::currentDeviceMotion):
(WebCore::DeviceMotionClientQt::deviceMotionControllerDestroyed):

  • WebCoreSupport/DeviceMotionClientQt.h: Added.

(WebCore::DeviceMotionClientQt::~DeviceMotionClientQt):

  • WebCoreSupport/DeviceOrientationClientQt.cpp: Added.

(WebCore::DeviceOrientationClientQt::DeviceOrientationClientQt):
(WebCore::DeviceOrientationClientQt::setController):
(WebCore::DeviceOrientationClientQt::startUpdating):
(WebCore::DeviceOrientationClientQt::stopUpdating):
(WebCore::DeviceOrientationClientQt::lastOrientation):
(WebCore::DeviceOrientationClientQt::deviceOrientationControllerDestroyed):

  • WebCoreSupport/DeviceOrientationClientQt.h: Added.

(WebCore::DeviceOrientationClientQt::~DeviceOrientationClientQt):

2:26 AM Changeset in webkit [68977] by Nikolas Zimmermann
  • 67 edits in trunk/LayoutTests

2010-10-02 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

Rewrite SVG text layout code
​https://bugs.webkit.org/show_bug.cgi?id=45532

Rebaseline gtk / qt / win specific SVG text results.

  • platform/gtk/svg/batik/text/textDecoration-expected.txt:
  • platform/gtk/svg/css/composite-shadow-text-expected.txt:
  • platform/gtk/svg/css/shadow-changes-expected.txt:
  • platform/gtk/svg/css/text-shadow-multiple-expected.txt:
  • platform/gtk/svg/custom/broken-internal-references-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
  • platform/gtk/svg/custom/stroke-width-large-expected.txt:
  • platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/gtk/svg/filters/filter-on-tspan-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/gtk/svg/text/select-x-list-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-4-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/gtk/svg/text/text-hkern-expected.txt:
  • platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/gtk/svg/text/text-vkern-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/qt/svg/batik/text/textDecoration-expected.txt:
  • platform/qt/svg/custom/broken-internal-references-expected.txt:
  • platform/qt/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/qt/svg/filters/filter-on-tspan-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/qt/svg/text/select-x-list-1-expected.txt:
  • platform/qt/svg/text/select-x-list-2-expected.txt:
  • platform/qt/svg/text/select-x-list-3-expected.txt:
  • platform/qt/svg/text/select-x-list-4-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/qt/svg/text/text-hkern-expected.txt:
  • platform/qt/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/qt/svg/text/text-vkern-expected.txt:
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/win/svg/custom/broken-internal-references-expected.txt:
1:08 AM Changeset in webkit [68976] by Nikolas Zimmermann
  • 331 edits
    12 adds
    8 deletes in trunk

2010-10-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Rewrite SVG text layout code
​https://bugs.webkit.org/show_bug.cgi?id=45532

Modernize SVG text layout engine, split the layout process into three phases, so that each results can be cached (which will be done in a follow-up patch).

Phase #1) - SVGTextLayoutAttributesBuilder
------------------------------------------

Parse x/y/dx/dy/rotate values of the <text> subtree (<text x="30 40">A<tspan>B<tspan x="50">C</tspan></tspan></text>)
This is done by SVGTextLayoutAttributesBuilder. It builds a SVGTextLayoutAttributes object for each RenderSVGInlineText renderer, and stores it there.
Phase #1 is started from RenderSVGText::layout(), before RenderBlockLineLayout is laying out the inline children, and thus before the InlineBox tree is created.

Now we know which character has an associated absolute x or y position, denoting the start of a new text chunk. Whenever we encounter a new text chunk
RenderBlockLineLayout should create a new SVGInlineTextBox. This is very important, as BiDi reordering shouldn't happen across text chunks, as well as ligature detection.

The text chunk concept is now merged right into the InlineBox tree, so we don't need to hack around the lack of that, as done for the previous years.

Phase #2) - SVGTextLayoutEngine
------------------------------------------

RenderSVGText::layout() calls RenderBlock::layoutInlineChildren() right after phase #1 ends. The InlineBox tree is created. During that process findNextLineBreak()
decides how to split up the text into InlineTextBoxes. It has already been patched, to ask RenderSVGInlineText::characterStartsNewTextChunk(int position), whether the
current character should go in a new SVGInlineTextBox or not. This requires that phase #1 already stored these information in the RenderSVGInlineText objects.

For each <text> object a SVGRootInlineBox is created (in constructLine()) and all child boxes are added. After that SVGRootInlineBox::computePerCharacterLayoutInformation()
is called (unlike HTML text, which splits the vertical & horizontal layout in two phases, it's just one single phase for SVG). This function invokes SVGTextLayoutEngine
and starts phase #2 of the layout process.

SVGTextLayoutEngine lays out the content of each SVGInlineTextBox either on a line or a path. It contains all the logic handling, alignment-baseline, dominant-baseline,
letter-spacing, word-spacing, kerning, glyph-orientation-(horizontal|vertical), rotation, etc. etc.

As result it generates a set of SVGTextFragment objects which are stored in each SVGInlineTextBox. Each SVGTextFragment is a portion of text that can be rendered/measured
at once. Some examples to illustrate what's going on:

<text x="20">ABCD</text>:

  • SVGInlineTextBox
    • SVGTextFragment, start 0 length 4, "ABCD" (x=20)

<text x="20 100">ABCD</text>:

  • SVGInlineTextBox
    • SVGTextFragment, start 0 length 1, "A" (x=20)
  • SVGInlineTextBox
    • SVGTextFragment, start 0 length 1, "B" (x=100)
    • SVGTextFragment, start 1 length 2, "CD" (x=100 + advance_of_last)

<text><textPath xlink:href="#somePath">ABCD</textPath></text>:

  • SVGInlineTextBox
    • SVGTextFragment, start 0 length 1, "A" (rotated!)
    • SVGTextFragment, start 1 length 1, "B" (rotated!)
    • SVGTextFragment, start 2 length 1, "C" (rotated!)
    • SVGTextFragment, start 3 length 1, "D" (rotated!)

<text x="0 50 100">A<tspan>B</tspan>C</text>

  • SVGInlineTextBox
    • SVGTextFragment, start 0 length 1, "A" (x=0)
  • SVGInlineFlowBox
    • SVGInlineTextBox
      • SVGTextFragment, start 0 length 1, "B" (x=50)
  • SVGInlineTextBox
    • SVGTextFragment, start 0 length 1, "C" (x=100)

When painting text SVGInlineTextBox just walks its fragments and paints them. Text selection works the same.
All text measurements (width/height etc.) have already been done in phase #2 and aren't required anymore while painting/selecting.
This is one of the main benefits of the new text layout engine, painting & selection is cheap now, compared to the layout process.

We're now doing phase #1 everytime RenderSVGText::layout() is called. This is not necessary, we only have to recompute these information
if the x/y/dx/dy or rotate list of an element in the <text> subtree changes or the text content itself -> this will be done in a follow-up patch.
It's likely that we'll also find ways to skip phase #2 in certain situations.

Phase #3) - SVGTextChunkBuilder
------------------------------------------

After phase #2 finished, we can post-process the text fragments. Certain operations have to be applied on a "per chunk" basis.
text-anchor should be applied to individual text chunks, as well as textLength corrections (lengthAdjust="spacing" / lengthAdjust="spacingAndGlyphs").

SVGTextChunkBuilder just walks the SVGInlineTextBox, and collects all boxes belonging to a certain chunk. For each of the chunks all fragments
are post-processed. For instance for text-anchor="middle", all x positions of all fragments are shifted by -fragmentWidth/2 (for horizonal text).

After phase #1 - #3 finished, SVGRootInlineBox::computePerCharacterLayoutInformation() utilizies the stored SVGTextFragments to lay out all child
boxes in the InlineBox tree (setWidth/Height, etc.), the size and position of the SVGRootInlineBox and it's parent RenderSVGText object.

This should give interessted readers a good summary of how the new text layout engine works.
See LayoutTests/ChangeLog for more details on test progression.

Tests: svg/custom/text-rotation.svg

svg/custom/text-x-dy-lists.svg

  • Android.mk: Add SVGTextLayoutEngine.* / SVGTextChunkBuilder.* to build. Remove SVGCharacterData.* / SVGTextChunkLayoutInfo.* / SVGTextLayoutUtilities.* from build.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/InlineBox.h: (WebCore::InlineBox::isSVGInlineFlowBox): Add helper function to identify SVGInlineFlowBoxes. The variants for SVGInlineTextBox etc. already exist.
  • rendering/InlineTextBox.h: Devirtualize selectionStartEnd, SVG is no longer overriding it.
  • rendering/RenderSVGAllInOne.cpp: removes
  • rendering/RenderText.cpp: (WebCore::RenderText::setTextInternal): Remove SVG specific hacks, moved to RenderSVGInlineText.
  • rendering/SVGCharacterData.cpp: Removed.
  • rendering/SVGCharacterData.h: Removed.
  • rendering/SVGCharacterLayoutInfo.cpp: Removed.
  • rendering/SVGCharacterLayoutInfo.h: Removed.
  • rendering/SVGRenderTreeAsText.cpp: Hack DRT output to be somewhat compatible with the current output, the plan is to change it completly after this patch. (WebCore::writeRenderSVGTextBox): (WebCore::writeSVGInlineTextBox):
  • rendering/SVGTextChunkLayoutInfo.cpp: Removed.
  • rendering/SVGTextChunkLayoutInfo.h: Removed.
  • rendering/SVGTextLayoutUtilities.cpp: Removed.
  • rendering/SVGTextLayoutUtilities.h: Removed.
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff): Only return immediately if SVGRenderStyle::diff produced StyleDifferenceLayout, it it's sth. else be sure to ask RenderStyle itself what to do.
  • rendering/style/SVGRenderStyle.h: (WebCore::SVGRenderStyle::isVerticalWritingMode): New helper method, moved from SVGTextLayoutUtilities.
  • rendering/svg/RenderSVGInlineText.cpp: (WebCore::applySVGWhitespaceRules): Moved from RenderText into a SVG specific place. (WebCore::RenderSVGInlineText::RenderSVGInlineText): Use applySVGWhitespaceRules on the incoming text. (WebCore::RenderSVGInlineText::styleDidChange): Only apply SVG white space rules, when using xml:space="preserve", otherwhise the constructor already handled it. (WebCore::RenderSVGInlineText::characterStartsNewTextChunk): Create text chunks for absolute y values as well, SVG 1.1 2nd Edition demands that. (WebCore::RenderSVGInlineText::positionForPoint): New function operating on all SVGInlineTextBoxes and their SVGTextFragments.
  • rendering/svg/RenderSVGInlineText.h: (WebCore::RenderSVGInlineText::layoutAttributes): Stores the layout attributes generated by SVGTextLayoutAttributesBuilder. (WebCore::toRenderSVGInlineText): New helper methods for casting.
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::layout): Add comment, that SVGTextLayoutAttributesBuilder is just phase one of the layout process. (WebCore::RenderSVGText::positionForPoint): Simplified implementation for SVGs needs.
  • rendering/svg/RenderSVGText.h:
  • rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::paintSelectionBackground): Seperated selection background drawing from actual text rendering, to make sure selection is always in background for SVG. (WebCore::SVGInlineFlowBox::paint): Call computetextMatchMarkerRectForRenderer, before painting. (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer): New method.
  • rendering/svg/SVGInlineFlowBox.h: (WebCore::SVGInlineFlowBox::isSVGInlineFlowBox):
  • rendering/svg/SVGInlineTextBox.cpp: Completly rewritten, operates on SVGTextFragments, produced by the SVGTextLayoutEngine. Whole new concept, compared to the old hack.
  • rendering/svg/SVGInlineTextBox.h: (WebCore::SVGInlineTextBox::clearTextFragments): Only used by SVGTextLayoutEngine, to clean up previously computed fragments. (WebCore::SVGInlineTextBox::textFragments): Offers access to the fragments in the box. (WebCore::SVGInlineTextBox::startsNewTextChunk): Does this box start a new text chunk? (WebCore::SVGInlineTextBox::setStartsNewTextChunk): SVGTextLayoutEngine marks this box, if it starts a new text chunk.
  • rendering/svg/SVGRootInlineBox.cpp: Remove old code regarding text chunk parts. (WebCore::SVGRootInlineBox::paint): Selection is now painted before text, to assure it's really in the background. (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): Use new SVGTextLayoutEngine. (WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes): Feed SVGTextLayoutEngine with SVGInlineTextBoxes, detect the begin/end of path layouts. (WebCore::SVGRootInlineBox::layoutChildBoxes): Use new isSVGInlineTextBox() helper method. (WebCore::SVGRootInlineBox::closestLeafChildForPosition): Simplified version for SVG.
  • rendering/svg/SVGRootInlineBox.h: Remove access to text chunks, they're now longer stored in the SVGRootInlineBox.
  • rendering/svg/SVGTextChunk.cpp: s/SVGTextChunkNew/SVGTextChunk/
  • rendering/svg/SVGTextChunk.h:
  • rendering/svg/SVGTextChunkBuilder.cpp: Added.
  • rendering/svg/SVGTextChunkBuilder.h: Added.
  • rendering/svg/SVGTextLayoutAttributes.cpp: Constify dump() method.
  • rendering/svg/SVGTextLayoutAttributes.h: (WebCore::SVGTextLayoutAttributes::textMetricsValues):
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp: Rewritten, consume less memory, while building the layout attributes.
  • rendering/svg/SVGTextLayoutAttributesBuilder.h:
  • rendering/svg/SVGTextLayoutEngine.cpp: Added.
  • rendering/svg/SVGTextLayoutEngine.h: Added.
  • rendering/svg/SVGTextQuery.cpp: Rewritten to deal with the new SVGTextFragment/SVGTextLayoutAttributes logic.
  • rendering/svg/SVGTextQuery.h:

2010-10-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Rewrite SVG text layout code
​https://bugs.webkit.org/show_bug.cgi?id=45532

Rebaseline most SVGs containing text. The underlying concept has changed, I tried hard to maintain
a somewhat compatible DRT output, so it doesn't require rebaselines of _all_ tests.
The dump looks awkward now, it will always report "chunk 1", as it's hardcoded in SVGRenderTreeAsText.
Follow up patches will change the output of text dumps completly.

  • platform/mac-leopard/svg/W3C-SVG-1.1/text-text-05-t-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
  • platform/mac-leopard/svg/batik/text/textOnPath-expected.checksum:
  • platform/mac-leopard/svg/batik/text/textOnPath-expected.png: baseline-shift adjustments now match Opera.
  • platform/mac-leopard/svg/batik/text/verticalTextOnPath-expected.checksum:
  • platform/mac-leopard/svg/batik/text/verticalTextOnPath-expected.png: Ditto.
  • platform/mac-leopard/svg/batik/text/xmlSpace-expected.checksum:
  • platform/mac-leopard/svg/batik/text/xmlSpace-expected.png:
  • platform/mac-leopard/svg/custom/altglyph-expected.checksum:
  • platform/mac-leopard/svg/custom/altglyph-expected.png:
  • platform/mac-leopard/svg/text/multichar-glyph-expected.checksum:
  • platform/mac-leopard/svg/text/multichar-glyph-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: No more blurry edges, size calculations fixed.
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-02-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/text-align-02-b-expected.png: baseline-shift looks slightly different, now matches Opera.
  • platform/mac/svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-05-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/text-align-05-b-expected.png: Vertical text now starts at correct origin, and is centered correctly.
  • platform/mac/svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-06-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/text-align-06-b-expected.png: Ditto + baseline-shift differences.
  • platform/mac/svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
  • platform/mac/svg/batik/text/longTextOnPath-expected.txt:
  • platform/mac/svg/batik/text/textAnchor-expected.txt:
  • platform/mac/svg/batik/text/textAnchor2-expected.checksum:
  • platform/mac/svg/batik/text/textAnchor2-expected.png: y-position adjustments start new text chunks since SVG 1.1 2nd edition (in contrary to SVG 1.2 Tiny). Left the test as is.
  • platform/mac/svg/batik/text/textAnchor2-expected.txt:
  • platform/mac/svg/batik/text/textAnchor3-expected.txt:
  • platform/mac/svg/batik/text/textDecoration-expected.checksum:
  • platform/mac/svg/batik/text/textDecoration-expected.png: text-decoration defined on <text> paints with the paint sever defined on the <tspan>, test finally works!
  • platform/mac/svg/batik/text/textDecoration-expected.txt:
  • platform/mac/svg/batik/text/textDecoration2-expected.checksum:
  • platform/mac/svg/batik/text/textDecoration2-expected.png: Ditto.
  • platform/mac/svg/batik/text/textDecoration2-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.checksum:
  • platform/mac/svg/batik/text/textEffect-expected.png: Just like pservers-grad-08-b.svg, no more blurry edges.
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect2-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.checksum:
  • platform/mac/svg/batik/text/textEffect3-expected.png: Ditto.
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/textFeatures-expected.checksum:
  • platform/mac/svg/batik/text/textFeatures-expected.png: baseline-shift differences.
  • platform/mac/svg/batik/text/textFeatures-expected.txt:
  • platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.checksum:
  • platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Completly fixed, now aligns properly with path, matches Opera & Batik.
  • platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/mac/svg/batik/text/textLayout-expected.txt:
  • platform/mac/svg/batik/text/textLayout2-expected.checksum:
  • platform/mac/svg/batik/text/textLayout2-expected.png: baseline-shift differences.
  • platform/mac/svg/batik/text/textLayout2-expected.txt:
  • platform/mac/svg/batik/text/textLength-expected.txt:
  • platform/mac/svg/batik/text/textOnPath-expected.txt:
  • platform/mac/svg/batik/text/textOnPath2-expected.txt:
  • platform/mac/svg/batik/text/textOnPath3-expected.txt:
  • platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/mac/svg/batik/text/textPCDATA-expected.txt:
  • platform/mac/svg/batik/text/textPosition-expected.txt:
  • platform/mac/svg/batik/text/textPosition2-expected.txt:
  • platform/mac/svg/batik/text/textProperties-expected.txt:
  • platform/mac/svg/batik/text/textProperties2-expected.txt:
  • platform/mac/svg/batik/text/verticalText-expected.checksum:
  • platform/mac/svg/batik/text/verticalText-expected.png:
  • platform/mac/svg/batik/text/verticalText-expected.txt:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/mac/svg/batik/text/xmlSpace-expected.txt:
  • platform/mac/svg/carto.net/button-expected.txt:
  • platform/mac/svg/carto.net/colourpicker-expected.txt:
  • platform/mac/svg/carto.net/combobox-expected.txt:
  • platform/mac/svg/carto.net/selectionlist-expected.txt:
  • platform/mac/svg/carto.net/tabgroup-expected.txt:
  • platform/mac/svg/carto.net/textbox-expected.txt:
  • platform/mac/svg/carto.net/window-expected.txt:
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt:
  • platform/mac/svg/css/text-shadow-multiple-expected.txt:
  • platform/mac/svg/custom/alignment-baseline-modes-expected.checksum:
  • platform/mac/svg/custom/alignment-baseline-modes-expected.png: central baseline now works as expected.
  • platform/mac/svg/custom/alignment-baseline-modes-expected.txt:
  • platform/mac/svg/custom/altglyph-expected.txt:
  • platform/mac/svg/custom/broken-internal-references-expected.txt:
  • platform/mac/svg/custom/container-opacity-clip-viewBox-expected.txt:
  • platform/mac/svg/custom/dominant-baseline-modes-expected.checksum:
  • platform/mac/svg/custom/dominant-baseline-modes-expected.png: ditto.
  • platform/mac/svg/custom/dominant-baseline-modes-expected.txt:
  • platform/mac/svg/custom/glyph-selection-lang-attribute-expected.txt:
  • platform/mac/svg/custom/glyph-transformation-with-hkern-expected.checksum:
  • platform/mac/svg/custom/glyph-transformation-with-hkern-expected.png: Kerning is now properly respected.
  • platform/mac/svg/custom/image-small-width-height-expected.txt:
  • platform/mac/svg/custom/invalid-fill-expected.txt:
  • platform/mac/svg/custom/invalid-fill-hex-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
  • platform/mac/svg/custom/pattern-rotate-expected.txt:
  • platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/mac/svg/custom/style-attribute-font-size-expected.txt:
  • platform/mac/svg/custom/text-dom-01-f-expected.txt:
  • platform/mac/svg/custom/text-letter-spacing-expected.txt:
  • platform/mac/svg/custom/text-linking-expected.txt:
  • platform/mac/svg/custom/text-rotation-expected.checksum: Added.
  • platform/mac/svg/custom/text-rotation-expected.png: Added.
  • platform/mac/svg/custom/text-rotation-expected.txt: Added.
  • platform/mac/svg/custom/text-whitespace-handling-expected.txt:
  • platform/mac/svg/custom/text-x-dx-lists-expected.txt:
  • platform/mac/svg/custom/text-x-dy-lists-expected.checksum: Added.
  • platform/mac/svg/custom/text-x-dy-lists-expected.png: Added.
  • platform/mac/svg/custom/text-x-dy-lists-expected.txt: Added.
  • platform/mac/svg/custom/text-x-override-in-tspan-child-expected.checksum:
  • platform/mac/svg/custom/text-x-override-in-tspan-child-expected.png:
  • platform/mac/svg/custom/text-x-override-in-tspan-child-expected.txt:
  • platform/mac/svg/custom/use-detach-expected.txt:
  • platform/mac/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/mac/svg/filters/filter-on-tspan-expected.txt:
  • platform/mac/svg/text/kerning-expected.txt:
  • platform/mac/svg/text/multichar-glyph-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-1-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-3-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-4-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-4-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-stretch-1-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-stretch-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-stretch-2-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-stretch-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-stretch-3-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-stretch-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-stretch-4-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.checksum:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/mac/svg/text/select-x-list-1-expected.checksum:
  • platform/mac/svg/text/select-x-list-1-expected.png:
  • platform/mac/svg/text/select-x-list-1-expected.txt:
  • platform/mac/svg/text/select-x-list-2-expected.checksum:
  • platform/mac/svg/text/select-x-list-2-expected.png:
  • platform/mac/svg/text/select-x-list-2-expected.txt:
  • platform/mac/svg/text/select-x-list-3-expected.checksum:
  • platform/mac/svg/text/select-x-list-3-expected.png:
  • platform/mac/svg/text/select-x-list-3-expected.txt:
  • platform/mac/svg/text/select-x-list-4-expected.checksum:
  • platform/mac/svg/text/select-x-list-4-expected.png:
  • platform/mac/svg/text/select-x-list-4-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-1-expected.checksum:
  • platform/mac/svg/text/select-x-list-with-tspans-1-expected.png:
  • platform/mac/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-2-expected.checksum:
  • platform/mac/svg/text/select-x-list-with-tspans-2-expected.png:
  • platform/mac/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-3-expected.checksum:
  • platform/mac/svg/text/select-x-list-with-tspans-3-expected.png:
  • platform/mac/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-4-expected.checksum:
  • platform/mac/svg/text/select-x-list-with-tspans-4-expected.png:
  • platform/mac/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/mac/svg/text/text-align-02-b-expected.checksum:
  • platform/mac/svg/text/text-align-02-b-expected.png:
  • platform/mac/svg/text/text-align-02-b-expected.txt:
  • platform/mac/svg/text/text-align-03-b-expected.txt:
  • platform/mac/svg/text/text-align-04-b-expected.checksum:
  • platform/mac/svg/text/text-align-04-b-expected.png:
  • platform/mac/svg/text/text-align-04-b-expected.txt:
  • platform/mac/svg/text/text-align-05-b-expected.checksum:
  • platform/mac/svg/text/text-align-05-b-expected.png:
  • platform/mac/svg/text/text-align-05-b-expected.txt:
  • platform/mac/svg/text/text-align-06-b-expected.checksum:
  • platform/mac/svg/text/text-align-06-b-expected.png:
  • platform/mac/svg/text/text-align-06-b-expected.txt:
  • platform/mac/svg/text/text-altglyph-01-b-expected.txt:
  • platform/mac/svg/text/text-deco-01-b-expected.checksum:
  • platform/mac/svg/text/text-deco-01-b-expected.png:
  • platform/mac/svg/text/text-deco-01-b-expected.txt:
  • platform/mac/svg/text/text-hkern-expected.checksum:
  • platform/mac/svg/text/text-hkern-expected.png: Kerning now respects text chunk boundaries.
  • platform/mac/svg/text/text-hkern-expected.txt:
  • platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/mac/svg/text/text-path-01-b-expected.checksum:
  • platform/mac/svg/text/text-path-01-b-expected.png:
  • platform/mac/svg/text/text-path-01-b-expected.txt:
  • platform/mac/svg/text/text-spacing-01-b-expected.checksum:
  • platform/mac/svg/text/text-spacing-01-b-expected.png:
  • platform/mac/svg/text/text-spacing-01-b-expected.txt:
  • platform/mac/svg/text/text-text-01-b-expected.checksum:
  • platform/mac/svg/text/text-text-01-b-expected.png:
  • platform/mac/svg/text/text-text-01-b-expected.txt:
  • platform/mac/svg/text/text-text-04-t-expected.checksum:
  • platform/mac/svg/text/text-text-04-t-expected.png:
  • platform/mac/svg/text/text-text-04-t-expected.txt:
  • platform/mac/svg/text/text-text-05-t-expected.checksum:
  • platform/mac/svg/text/text-text-05-t-expected.png: y positions now also start text chunks, finally a progression on this test!
  • platform/mac/svg/text/text-text-05-t-expected.txt:
  • platform/mac/svg/text/text-text-06-t-expected.txt:
  • platform/mac/svg/text/text-text-07-t-expected.checksum:
  • platform/mac/svg/text/text-text-07-t-expected.png:
  • platform/mac/svg/text/text-text-07-t-expected.txt:
  • platform/mac/svg/text/text-text-08-b-expected.checksum:
  • platform/mac/svg/text/text-text-08-b-expected.png: Opacity doesn't affect selection anymore, matches all other browsers.
  • platform/mac/svg/text/text-tselect-01-b-expected.txt:
  • platform/mac/svg/text/text-tselect-02-f-expected.txt:
  • platform/mac/svg/text/text-tspan-01-b-expected.txt:
  • platform/mac/svg/text/text-vkern-expected.checksum:
  • platform/mac/svg/text/text-vkern-expected.png: Kerning now respects text chunk boundaries.
  • platform/mac/svg/text/text-vkern-expected.txt:
  • platform/mac/svg/text/textPathBoundsBug-expected.txt:
  • platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
  • svg/batik/text/xmlSpace.svg: Fixed wrong test, now the embedded SVG Font is actually used.
  • svg/custom/altglyph.svg: Fixed wrong test, xlink namespace was wrong, xlink:href for altGlyph had no effect.
  • svg/custom/glyph-setting-d-attribute-expected.txt:
  • svg/custom/glyph-transformation-with-hkern-expected.txt:
  • svg/custom/text-rotation.svg: Added.
  • svg/custom/text-x-dy-lists.svg: Added.
  • svg/custom/text-x-override-in-tspan-child.svg: Fixed wrong test, depending on a previous bug - now matches Opera.
  • svg/text/multichar-glyph.svg: Also dump end positions of characters.
  • svg/text/resources/SelectionTestCase.js: Modify the selection test cases, to draw green lines marking the computed start & end postions of the selected characters. (selectRange):
12:57 AM Changeset in webkit [68975] by hclam@chromium.org
  • 2 edits in trunk/WebCore

Build fix. Not reviewed.

An adhoc fix for a crash found by reliability bot. This will make the
reliability bot happy. A proper fix is pending commit.

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::~VideoLayerChromium):

12:26 AM Changeset in webkit [68974] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Build fix.

Add test expectations for Chromium.

  • platform/chromium/test_expectations.txt:

Oct 1, 2010:

11:01 PM Changeset in webkit [68973] by Simon Fraser
  • 4 edits in trunk/WebKitTools

2010-10-01 Simon Fraser <Simon Fraser>

Add the ability to remove results for re-testing, and
to import results.

  • CSSTestSuiteHarness/harness/harness.css: (.custom button): (#overlay): (#overlay.visible): (.overlay-contents): (.overlay-contents textarea): (.overlay-contents .buttons): (.overlay-contents .note): (.overlay-contents .buttons button):
  • CSSTestSuiteHarness/harness/harness.html:
  • CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.importResults): (TestSuite.prototype.clearResults): (TestSuite.prototype.markTestCompleted): (TestSuite.prototype.resetTestStatus): (TestSuite.prototype.storeTestResult): (TestSuite.prototype.importTestResults): (TestSuite.prototype.clearTestResults):
9:49 PM Changeset in webkit [68972] by rniwa@webkit.org
  • 13 edits
    2 adds in trunk/WebCore

2010-10-01 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

FormatBlockCommand and IndentOutdentCommand should use the same code to iterate paragraphs
​https://bugs.webkit.org/show_bug.cgi?id=46840

Added ApplyBlockElementCommand, which is an abstract class inherited by FormatBlockCommand
and IndentOutdentCommand. It is intended to be inherited by InsertListCommand as well.

ApplyBlockElementCommand's doApply verifies the current selection and exits early
if it's invalid or orphaned or if the current selection is outside editable region.
It then calls formatSelection to apply the block element after which doApply restores the selection.
formatSelection iterates through paragraphs and calls formatParagraph, a pure virtual function
implemented by FormatBlockCommand and IndentOutdentCommand, on each paragraph.

No new tests are added since this is a refactoring.

  • Android.mk: Added ApplyBlockElementCommand.cpp.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Added ApplyBlockElementCommand.cpp and ApplyBlockElementCommand.h.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • editing/ApplyBlockElementCommand.cpp: Added. (WebCore::countParagraphs): Moved from IndentOutdentCommand.cpp (WebCore::ApplyBlockElementCommand::ApplyBlockElementCommand): Added. (WebCore::ApplyBlockElementCommand::doApply): Moved from IndentOutdentCommand::doApply. (WebCore::ApplyBlockElementCommand::formatSelection): Moved from IndentOutdentCommand::indentRegion. (WebCore::ApplyBlockElementCommand::createBlockElement): Added. (WebCore::ApplyBlockElementCommand::splitTextNodes): Moved from IndentOutdentCommand::splitTextNodes.
  • editing/ApplyBlockElementCommand.h: Added.
  • editing/EditingAllInOne.cpp:
  • editing/EditorCommand.cpp: (WebCore::executeFormatBlock):
  • editing/FormatBlockCommand.cpp: Removed doApply. (WebCore::FormatBlockCommand::FormatBlockCommand): Calls ApplyBlockElementCommand's constructor. (WebCore::FormatBlockCommand::formatParagraph): Renamed from doApplyForSingleParagraph.
  • editing/FormatBlockCommand.h: FormatBlockCommand inherits from ApplyBlockElementCommand. (WebCore::FormatBlockCommand::create): Uses QualifiedName for the tag name instead of AtomicString.
  • editing/IndentOutdentCommand.cpp: Removed doApply, indentIntoBlockquote, and splitTextNodes. (WebCore::IndentOutdentCommand::IndentOutdentCommand): Calls ApplyBlockElementCommand's constructor. (WebCore::IndentOutdentCommand::indentIntoBlockquote): The code to nullify targetBlockquote when the next paragraph is in a different table cell is moved to ApplyBlockElementCommand::formatSelection. (WebCore::IndentOutdentCommand::formatSelection): Added. Calls outdentRegion when outdenting. (WebCore::IndentOutdentCommand::formatParagraph): Added. Calls tryIndentingAsListItem and indentIntoBlockquote.
  • editing/IndentOutdentCommand.h: IndentOutdentCommand inherits from ApplyBlockElementCommand.
9:01 PM Changeset in webkit [68971] by mrowe@apple.com
  • 13 edits in trunk

Build fix.

Clear the executable bit from a number of source files.

WebCore:

  • page/Frame.cpp:
  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
  • platform/graphics/win/WKCACFLayerRenderer.cpp:
  • platform/graphics/win/WKCACFLayerRenderer.h:
  • platform/network/ResourceRawHeaders.h:
  • rendering/RenderLayerCompositor.cpp:
  • rendering/RenderLayerCompositor.h:

WebKit/win:

  • WebView.cpp:
  • WebView.h:

WebKit2:

  • WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.h:
8:22 PM Changeset in webkit [68970] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-10-01 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Adam Barth.

[GTK] r68923 broke some plugin tests
​https://bugs.webkit.org/show_bug.cgi?id=47040

No longer pass focus and blur events to plugins when the "old" DOM Level
2 DOMFocusIn/DOMFocusOut events occur. r68923 made a change which means
that the DOM Level 3 version is always fired for this event.

No new tests, as this should cause the failing tests to pass.

  • plugins/PluginView.cpp: (WebCore::PluginView::handleEvent): No longer pass focus and blur events to plugins when DOMFocusIn / DOMFocusOut events occur.
7:17 PM Changeset in webkit [68969] by Martin Robinson
  • 2 edits
    1 delete in trunk/LayoutTests

2010-10-01 Martin Robinson <​mrobinson@igalia.com>

Removed an expected result for a previously skipped test. This test
is skipped because it fails on 1 (out of 4) GTK+ bots. It had
started failing again after the WebSocket tests were relocated and
the skipped list was no longer up to date.

  • platform/gtk/Skipped: Update skipped list to reflect new test location.
  • platform/gtk/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt: Removed.
7:08 PM Changeset in webkit [68968] by tony@chromium.org
  • 2 edits
    1 move in trunk/LayoutTests

2010-10-01 Tony Chang <​tony@chromium.org>

Unreviewed. Turns out Safari Win matches Safari Mac so move the
expectation to chromium-win.

  • platform/chromium-win/editing/selection/5354455-1-expected.txt: Renamed from LayoutTests/platform/win/editing/selection/5354455-1-expected.txt.
  • platform/win/Skipped:
7:01 PM Changeset in webkit [68967] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

2010-10-01 Tony Chang <​tony@chromium.org>

Unreviewed. Updating layout test (editing/selection/5354455-1.html) after r68948.
Will fix soon.

  • platform/chromium/test_expectations.txt:
  • platform/win/Skipped:
6:54 PM Changeset in webkit [68966] by weinig@apple.com
  • 5 edits in trunk/WebKitTools

Deploy the new WKString functions to remove most uses of CF from
the WebKitTestRunner.

Reviewed by Jon Honeycutt.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::done):

  • WebKitTestRunner/StringFunctions.h:

(WTR::toWK):
(WTR::toJS):
(WTR::toSTD):
(WTR::operator<<):
(WTR::copyURLString):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::didFinishLoadForFrame):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

6:46 PM Changeset in webkit [68965] by mrowe@apple.com
  • 5 edits in branches/safari-533.19-branch

Versioning.

6:42 PM Changeset in webkit [68964] by mrowe@apple.com
  • 1 copy in tags/Safari-533.19.1

New tag.

6:17 PM Changeset in webkit [68963] by mihaip@chromium.org
  • 2 edits in trunk/WebKitTools

2010-10-01 Mihai Parparita <​mihaip@chromium.org>

Unreviewed TestResultsServer change.

Add files introduced by ​http://crrev.com/61273 to the list of dashboard
files to update.

  • TestResultServer/handlers/dashboardhandler.py:
5:45 PM Changeset in webkit [68962] by andersca@apple.com
  • 11 edits in trunk

WebCore: Plug-ins should have access to the private browsing state.
​https://bugs.webkit.org/show_bug.cgi?id=47031
<rdar://problem/8505405>

Reviewed by Sam Weinig.

  • page/Page.cpp:

(WebCore::Page::privateBrowsingStateChanged):
When iterating over all widgets, also look for PluginViewBase classes and invoke their
privateBrowsingStateChange member function.

  • plugins/PluginViewBase.h:

(WebCore::PluginViewBase::privateBrowsingStateChanged):
Add function.

WebKit2: Plug-ins should have access to the private browsing state.
​https://bugs.webkit.org/show_bug.cgi?id=47031
<rdar://problem/8505405>

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):
Handle NPNVprivateModeBool.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::isPrivateBrowsingEnabled):
Call PluginController::isPrivateBrowsingEnabled.

(WebKit::NetscapePlugin::NPP_SetValue):
Add NPP_SetValue wrapper.

(WebKit::NetscapePlugin::privateBrowsingStateChanged):
Call NPP_SetValue with the updated state.

  • WebProcess/Plugins/Plugin.h:

Add privateBrowsingStateChanged pure virtual member function.

  • WebProcess/Plugins/PluginController.h:

Add isPrivateBrowsingEnabled pure virtual member function.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::privateBrowsingStateChanged):
Call Plugin::privateBrowsingStateChanged.

5:40 PM Changeset in webkit [68961] by weinig@apple.com
  • 10 edits
    2 adds in trunk

WebKit2: Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.

Reviewed by Anders Carlsson.

API Test: WebKit2/WKStringJSString

  • Shared/API/c/WKString.cpp:

(WKStringCreateWithJSString):
(WKStringCopyJSString):

  • Shared/API/c/WKStringPrivate.h: Added.
  • Shared/WebString.h:

(WebKit::WebString::create):
(WebKit::WebString::createJSString):

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

WebKitTools: Build Fix for Windows.

Patch by Brian Weinstein <​bweinstein@apple.com> on 2010-10-01

  • WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from

WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
ForwardingHeaders to the include path.

5:27 PM Changeset in webkit [68960] by bweinstein@apple.com
  • 5 edits in trunk

Build Fix for Windows.

WebCore:

  • WebCore.vcproj/WebCore.vcproj: Don't have an empty post-build step, use

WebCoreCommon.vsprops to handle post-build step.

  • WebCore.vcproj/WebCoreCommon.vsprops: Set the post-build step to delete

$(WebKitOutputDir)/buildfailed.

WebKitTools:

  • WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from

WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
ForwardingHeaders to the include path.

5:24 PM Changeset in webkit [68959] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-01 Ragner Magalhaes <​ragner.magalhaes@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Segmentation fault during zoom out
​https://bugs.webkit.org/show_bug.cgi?id=46984

  • platform/qt/QtMobileWebStyle.cpp: (QtMobileWebStyle::drawChecker): Adjust checkerSize to be greater than or equals to middle.
5:17 PM Changeset in webkit [68958] by andersca@apple.com
  • 2 edits in trunk/WebCore

Another Qt build fix attempt.

  • WebCore.pro:
5:13 PM Changeset in webkit [68957] by hyatt@apple.com
  • 4 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=47021

Reviewed by Dan Bernstein.

Patch the floatBottom function and its friends. Rename them and consolidate them to be block-flow-aware.

Nothing testable yet, since most of the float code is still unpatched.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::newLine):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::getClearDelta):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalBottomForFloat):
(WebCore::RenderBlock::hasOverhangingFloats):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::fitBelowFloats):

5:11 PM Changeset in webkit [68956] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fix Snow Leopard build.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::getProxy):

4:51 PM Changeset in webkit [68955] by mrowe@apple.com
  • 1 edit in branches/safari-533.19-branch/WebCore/editing/SelectionController.cpp

Build fix.

4:49 PM Changeset in webkit [68954] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix typo.

  • platform/network/qt/ProxyServerQt.cpp:

(WebCore::proxyServersForURL):

4:45 PM Changeset in webkit [68953] by andersca@apple.com
  • 2 edits
    1 add in trunk/WebCore

Add Qt ProxyServer stub.

  • WebCore.pro:
  • platform/network/qt/ProxyServerQt.cpp: Added.

(WebCore::proxyServersForURL):

4:42 PM Changeset in webkit [68952] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Implement proxiesForURL, cookiesForURL and setCookiesForURL
​https://bugs.webkit.org/show_bug.cgi?id=47029

Reviewed by Sam Weinig.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::proxiesForURL):
(WebKit::PluginView::cookiesForURL):
(WebKit::PluginView::setCookiesForURL):

4:28 PM Changeset in webkit [68951] by andersca@apple.com
  • 9 edits
    3 adds in trunk

Add proxy server query function proxyServersForURL and change the Mac plug-in code to use it
​https://bugs.webkit.org/show_bug.cgi?id=47022
<rdar://problem/8504712>

Reviewed by Dan Bernstein.

WebCore:

  • WebCore.exp.in:

Export proxyServersForURL and toString.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Add new files.

  • platform/network/ProxyServer.cpp: Added.

(WebCore::appendProxyServerString):
(WebCore::toString):
New function that converts a vector of ProxyServers into a PAC style string.

  • platform/network/ProxyServer.h: Added.

(WebCore::ProxyServer::ProxyServer):
(WebCore::ProxyServer::type):
(WebCore::ProxyServer::hostName):
(WebCore::ProxyServer::port):
Add ProxyServer class.

  • platform/network/cf/ProxyServerCFNet.cpp: Added.

(WebCore::proxyServersForURL):
(WebCore::addProxyServersForURL):
Query CFNetwork for the proxy servers given a URL.

WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::getProxy):

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView getVariable:forURL:value:length:]):

4:25 PM Changeset in webkit [68950] by mrowe@apple.com
  • 25 edits in branches/safari-533.19-branch

Merge r60541.

4:25 PM Changeset in webkit [68949] by mrowe@apple.com
  • 26 edits in branches/safari-533.19-branch

Merge r59081.

4:21 PM Changeset in webkit [68948] by tony@chromium.org
  • 5 edits
    1 add
    9 deletes in trunk/LayoutTests

2010-10-01 Evan Martin <​evan@chromium.org>

Reviewed by Tony Chang.

editing/selection/5354455-1 has incorrect description text
​https://bugs.webkit.org/show_bug.cgi?id=44990

This test includes descriptive text that describes an OS X-specific behavior.
I almost checked in an incorrect baseline because I believed the text.
This change amends the text to describe expected behavior on Mac/Win/Linux.

Rather than requiring new baselines on all platforms, I took this opportunity
to also convert the test to a markup dump. We'll then end up with just one
Mac baseline and one non-Mac baseline.

  • editing/selection/5354455-1.html:
  • platform/chromium-linux/editing/selection/5354455-1-expected.checksum: Removed.
  • platform/chromium-linux/editing/selection/5354455-1-expected.png: Removed.
  • platform/chromium-win/editing/selection/5354455-1-expected.checksum: Removed.
  • platform/chromium-win/editing/selection/5354455-1-expected.png: Removed.
  • platform/chromium-win/editing/selection/5354455-1-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/editing/selection/5354455-1-expected.txt: Removed.
  • platform/mac-leopard/editing/selection/5354455-1-expected.checksum: Removed.
  • platform/mac-leopard/editing/selection/5354455-1-expected.png: Removed.
  • platform/mac/editing/selection/5354455-1-expected.checksum: Removed.
  • platform/mac/editing/selection/5354455-1-expected.png: Removed.
  • platform/mac/editing/selection/5354455-1-expected.txt: Updated.
  • platform/win/editing/selection/5354455-1-expected.txt: Added.
4:19 PM Changeset in webkit [68947] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/WebCore

Merge r66269.

4:19 PM Changeset in webkit [68946] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/WebCore

Merge r65934.

4:19 PM Changeset in webkit [68945] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/WebCore

Merge r65683.

4:19 PM Changeset in webkit [68944] by mrowe@apple.com
  • 17 edits in branches/safari-533.19-branch/WebCore

Merge r65681.

4:17 PM Changeset in webkit [68943] by hclam@chromium.org
  • 2 edits
    34 adds in trunk/LayoutTests

Build fix. Not reviewed.

Add test expectations for Chromium.

  • platform/chromium-linux/fast/blockflow/block-level-images-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/block-level-images-expected.png: Added.
  • platform/chromium-linux/fast/css/rtl-to-viewport-expected.checksum: Added.
  • platform/chromium-linux/fast/css/rtl-to-viewport-expected.png: Added.
  • platform/chromium-linux/fast/css/rtl-to-viewport-expected.txt: Added.
  • platform/chromium-linux/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt: Copied from LayoutTests/platform/chromium-linux/websocket/tests/bad-sub-protocol-control-chars-expected.txt.
  • platform/chromium-linux/http/tests/websocket/tests/url-parsing-expected.txt: Added.
  • platform/chromium-mac/fast/blockflow/block-level-images-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/block-level-images-expected.png: Added.
  • platform/chromium-mac/fast/css/rtl-to-viewport-expected.checksum: Added.
  • platform/chromium-mac/fast/css/rtl-to-viewport-expected.png: Added.
  • platform/chromium-mac/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt: Copied from LayoutTests/platform/chromium-linux/websocket/tests/bad-sub-protocol-control-chars-expected.txt.
  • platform/chromium-mac/http/tests/websocket/tests/url-parsing-expected.txt: Added.
  • platform/chromium-win-xp/fast/blockflow/block-level-images-expected.png: Added.
  • platform/chromium-win-xp/fast/css/rtl-to-viewport-expected.png: Added.
  • platform/chromium-win/fast/blockflow/block-level-images-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/block-level-images-expected.png: Added.
  • platform/chromium-win/fast/css/rtl-to-viewport-expected.checksum: Added.
  • platform/chromium-win/fast/css/rtl-to-viewport-expected.png: Added.
  • platform/chromium-win/fast/css/rtl-to-viewport-expected.txt: Added.
  • platform/chromium-win/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt: Copied from LayoutTests/platform/chromium-win/websocket/tests/bad-sub-protocol-control-chars-expected.txt.
  • platform/chromium-win/http/tests/websocket/tests/url-parsing-expected.txt: Added.
  • platform/chromium-win/platform/win/plugins/get-value-netscape-window-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:09 PM Changeset in webkit [68942] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fixed a typo

4:09 PM Changeset in webkit [68941] by mrowe@apple.com
  • 5 edits
    6 adds in branches/safari-533.19-branch

Merge r67183, r67184, r67255 and r67281.

4:08 PM Changeset in webkit [68940] by zmo@google.com
  • 7 edits
    1 add in trunk

2010-09-30 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

texImage2D fails on 16-bit-per-channel images
​https://bugs.webkit.org/show_bug.cgi?id=46947

  • platform/graphics/GraphicsContext3D.cpp: Handling 16-bit-per-channel source formats. (WebCore::convertColor16To8): (WebCore::doPacking):
  • platform/graphics/GraphicsContext3D.h: Ditto.
  • platform/graphics/cg/GraphicsContext3DCG.cpp: Ditto. (WebCore::GraphicsContext3D::getImageData):

2010-09-30 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

texImage2D fails on 16-bit-per-channel images
​https://bugs.webkit.org/show_bug.cgi?id=46947

  • fast/canvas/webgl/gl-teximage-expected.txt: Add a test case for loading 16-bit-per-channel images as textures.
  • fast/canvas/webgl/gl-teximage.html: Ditto.
  • fast/canvas/webgl/resources/green-2x2-16bit.png: Added.
4:01 PM Changeset in webkit [68939] by mrowe@apple.com
  • 2 adds in branches/safari-533.19-branch/LayoutTests

Add two files that were missed in the previous commit.

3:59 PM Changeset in webkit [68938] by mrowe@apple.com
  • 6 edits in branches/safari-533.19-branch

Merge r63048.

3:56 PM Changeset in webkit [68937] by dpranke@chromium.org
  • 8 edits in branches/chromium/517

Merge 66992 - 2010-09-08 Andy Estes <​aestes@apple.com>

TBR=​abarth@google.com
TBR=​dglazkov@google.com
BUG=55954
TEST=LayoutTests/fast/replaced/object-with-embed-url-param.html

Review URL: ​http://codereview.chromium.org/3551010

3:54 PM Changeset in webkit [68936] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/JavaScriptCore

Merge r68812.

3:51 PM Changeset in webkit [68935] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/WebCore

Merge r68705.

3:49 PM Changeset in webkit [68934] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/WebCore

Merge r68727.

3:42 PM Changeset in webkit [68933] by commit-queue@webkit.org
  • 10 edits
    3 copies in branches/chromium/517

Merge 68630 - 2010-09-28 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=41292
Some windowed plugins did not handle events through EventHandler, so we
never set right gesture state for those events.
This change is to set right allowPopupsFromPlugin flag to current
execution frame, so WeKit can always get right gesture state on Mac.
From Mac Snow Leopard, the plugin is run under "WebKitPluginHost,app"
process, that process passes the allowPopupsFromPlugin flag to
WKPCEvaluate(in NetscapePluginHostProxy.mm), then flag is set in
NetscapePluginInstanceProxy::evaluate.

  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]):

2010-09-28 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=41292
Pass the right popupAllowed flag to current execution frame,
so WebKit can get right gesture status for popups initiated
from plugins.
This also makes v8 binding's ScriptController::processingUserGesture
match what jsc version.

Test: plugins/plugin-initiate-popup-window.html

  • bindings/v8/NPV8Object.cpp: (_NPN_EvaluateHelper):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::processingUserGesture):
  • bindings/v8/ScriptController.h: (WebCore::ScriptController::setAllowPopupsFromPlugin): (WebCore::ScriptController::allowPopupsFromPlugin):

2010-09-28 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=41292.
Add a test to initiate popup windows from plugin during plugin is
handling mouse/keyboard event.
Disable this test on gtk/qt/win since the test plugin in those platforms
didn't implement NPP_HandleEvent.

  • platform/chromium-win/plugins/plugin-initiate-popup-window-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • plugins/plugin-initiate-popup-window-expected.txt: Added.
  • plugins/plugin-initiate-popup-window.html: Added.

2010-09-28 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=41292
Add a new parameter to the test plugin to allow specifying a script
and a mouse/keyboard event. The specified script will be evaluated
in the browser when the specified event is received by the plugin.

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (pluginAllocate):
  • DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): (handleEventCarbon): (handleEventCocoa):

TBR=​commit-queue@webkit.org

3:30 PM Changeset in webkit [68932] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Build fix. Not reviewed.

Add test expectations for Chromium.

  • platform/chromium/test_expectations.txt:
3:09 PM Changeset in webkit [68931] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-01 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Nate Chapin.

Add v8 binding helpers to make FileWriter be an EventTarget.
​https://bugs.webkit.org/show_bug.cgi?id=46910

No new tests; still waiting for the first complete implementation.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
3:00 PM Changeset in webkit [68930] by weinig@apple.com
  • 7 edits
    1 add in trunk

Add additional WKString API
​https://bugs.webkit.org/show_bug.cgi?id=46958

Reviewed by Kenneth Rohde Christiansen.

WebKit2:

API Test: WebKit2/WKString

  • Shared/API/c/WKString.cpp:

(WKStringCreateWithUTF8CString):
(WKStringGetMaximumUTF8CStringSize):
(WKStringGetUTF8CString):
(WKStringIsEqual):
(WKStringIsEqualToUTF8CString):

  • Shared/API/c/WKString.h:
  • Shared/WebString.h:

(WebKit::WebString::createFromUTF8String):
(WebKit::WebString::maximumUTF8CStringSize):
(WebKit::WebString::getUTF8CString):
(WebKit::WebString::equal):
(WebKit::WebString::equalToUTF8String):

WebKitTools:

Add basic WKStringRef tests.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
2:57 PM Changeset in webkit [68929] by mihaip@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-10-01 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Nate Chapin.

[Chromium] Remove WebURLLoaderClient::didFinishLoading(WebURLLoader*)
​https://bugs.webkit.org/show_bug.cgi?id=47008

Now that WebURLLoaderClient::didFinishLoading(WebURLLoader*) has no
more callers, it can be removed (requires a Chromium roll to
​http://crrev.com/61206, which actually removed the last usage).

  • DEPS:
  • public/WebURLLoaderClient.h:
2:43 PM Changeset in webkit [68928] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitSite

2010-10-01 Alex Mathews <​possessedpenguinbob@gmail.com>

Reviewed by Simon Fraser.

Bug 47013 - Main Web Inspector link on webkit.org links to old wiki page
​https://bugs.webkit.org/show_bug.cgi?id=47013

  • nav.inc: Removed the space from the web inspector wiki link.
2:30 PM Changeset in webkit [68927] by Adam Roben
  • 2 edits
    1 copy in trunk/LayoutTests

Land post-XP results for fast/text/backslash-to-yen-sign-euc.html

The fonts this test uses must have changed after Windows XP

  • platform/win-xp/fast/text/backslash-to-yen-sign-euc-expected.txt:

Copied from LayoutTests/platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt.

  • platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt:

Updated for post-XP.

2:25 PM Changeset in webkit [68926] by hyatt@apple.com
  • 4 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=47015

Reviewed by Sam Weinig.

Change FloatingObject to store its dimensions as a rect.
This will make it easier for logical access for block-flow later on if
top/bottom is no different from left/width. This change also simplifies
calling code a bit in places.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::fillSelectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::positionNewFloatOnLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::nextFloatBottomBelow):
(WebCore::RenderBlock::floatBottom):
(WebCore::RenderBlock::lowestPosition):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
(WebCore::RenderBlock::leftBottom):
(WebCore::RenderBlock::rightBottom):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::FloatingObject::left):
(WebCore::RenderBlock::FloatingObject::right):
(WebCore::RenderBlock::FloatingObject::top):
(WebCore::RenderBlock::FloatingObject::bottom):
(WebCore::RenderBlock::FloatingObject::width):
(WebCore::RenderBlock::FloatingObject::height):
(WebCore::RenderBlock::FloatingObject::setLeft):
(WebCore::RenderBlock::FloatingObject::setTop):
(WebCore::RenderBlock::FloatingObject::setWidth):
(WebCore::RenderBlock::FloatingObject::setHeight):
(WebCore::RenderBlock::FloatingObject::frameRect):
(WebCore::RenderBlock::FloatingObject::setFrameRect):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::matchedEndLine):

2:18 PM Changeset in webkit [68925] by abarth@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-10-01 Adam Barth <​abarth@webkit.org>

Add a Gtk-specific baseline for a WebSocket test.

  • platform/gtk/http/tests/websocket: Added.
  • platform/gtk/http/tests/websocket/tests: Added.
  • platform/gtk/http/tests/websocket/tests/bad-sub-protocol-control-chars-expected.txt: Added.
2:07 PM Changeset in webkit [68924] by hclam@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Build fix. Not reviewed.

Add the dummy README file to solve build breakages in Chromium.
It should be removed once the breakage is resolved.

  • websocket/tests/workers/README: Added.
1:50 PM Changeset in webkit [68923] by enrica@apple.com
  • 7 edits in trunk

DOMFocusIn/DOMFocusOut return focusin/focusout Event.type
​https://bugs.webkit.org/show_bug.cgi?id=42580
<rdar://problem/8107311>

Reviewed by Darin Adler.

WebCore:

This change removes the aliased type machinery from the Event class.
We now fire the event with the new name and the oldname.

Tests: Modified fast/events/focusinout.html to check the event
type.

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode):

  • dom/Event.cpp: Removed aliasedType and hasAliasedType.
  • dom/Event.h: Removed aliasedType and hasAliasedType.
  • dom/EventTarget.cpp:

(WebCore::EventTarget::fireEventListeners): Removed aliasedType related code.

LayoutTests:

  • fast/events/focusinout.html: Modified to check the event type.
1:44 PM Changeset in webkit [68922] by weinig@apple.com
  • 2 edits
    1 add in trunk/WebKitTools

Add makefile for TestWebKitAPI and call it from the base makefile.

Reviewed by Dan Bernstein.

  • Makefile:
  • TestWebKitAPI/Makefile: Added.
1:42 PM Changeset in webkit [68921] by Adam Roben
  • 1 edit
    3 adds in trunk/LayoutTests

Land new Windows results for fast/text/international/bidi-mirror-he-ar.html

Fixes <​http://webkit.org/b/47001> <rdar://problem/8503550>
fast/text/international/bidi-mirror-he-ar.html fails on Windows

Recommended by Dan Bernstein.

  • platform/win/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
  • platform/win/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
  • platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
1:29 PM Changeset in webkit [68920] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-10-01 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Remove check for InitLayoutCompleted on fixed_layout_size_set.
​https://bugs.webkit.org/show_bug.cgi?id=47006

This check isn't needed and isn't done on the other ports. The fixed
layout property can be set before we have the first layout.

  • ewk/ewk_view.cpp: (ewk_view_fixed_layout_size_set):
1:25 PM Changeset in webkit [68919] by weinig@apple.com
  • 3 edits
    2 deletes in trunk/WebKitTools

Remove unnecessary ForwardingHeaders from test runners.
​https://bugs.webkit.org/show_bug.cgi?id=47010

Reviewed by Adam Roben.

  • TestWebKitAPI/Configurations/Base.xcconfig:
  • TestWebKitAPI/ForwardingHeaders: Removed.
  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/ForwardingHeaders: Removed.
1:05 PM Changeset in webkit [68918] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/efl

2010-10-01 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Call contents_resize when the main frame gets resized.
​https://bugs.webkit.org/show_bug.cgi?id=47004

The previous implementation was just calling contents_resize when the
viewport size had changed. That's not enough, and contents_resize
shouldn't be called if the contents size didn't change.

Now the contents_size_changed function is called directly from the
ChromeClientEfl.

  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::contentsSizeChanged):
  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp: (_ewk_view_smart_calculate): (ewk_view_fixed_layout_size_set): (ewk_view_contents_size_changed):
12:59 PM Changeset in webkit [68917] by hyatt@apple.com
  • 12 edits
    7 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=46642, make replaced elements work with block-flow. This patch changes
all of the computeReplacedLogicalWidth and comuteReplacedLogicalHeight functions (and their helpers) to use logical width
and logical height instead.

Reviewed by Darin Adler.

Added fast/blockflow/block-level-images.html

WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

  • rendering/RenderBox.h:

(WebCore::RenderBox::intrinsicLogicalWidth):
(WebCore::RenderBox::intrinsicLogicalHeight):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::isLogicalWidthSpecified):
(WebCore::RenderImage::isLogicalHeightSpecified):
(WebCore::RenderImage::computeReplacedLogicalWidth):
(WebCore::RenderImage::computeReplacedLogicalHeight):
(WebCore::RenderImage::calcAspectRatioLogicalWidth):
(WebCore::RenderImage::calcAspectRatioLogicalHeight):

  • rendering/RenderImage.h:
  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::layout):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):
(WebCore::RenderReplaced::calcAspectRatioLogicalWidth):
(WebCore::RenderReplaced::calcAspectRatioLogicalHeight):
(WebCore::RenderReplaced::computePreferredLogicalWidths):

  • rendering/RenderReplaced.h:
  • rendering/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computePreferredLogicalWidths):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

  • rendering/RenderSVGRoot.h:
  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::computeReplacedLogicalWidth):
(WebCore::RenderVideo::computeReplacedLogicalHeight):

  • rendering/RenderVideo.h:

LayoutTests:

  • fast/blockflow/block-level-images.html: Added.
  • fast/blockflow/resources: Added.
  • fast/blockflow/resources/circle.svg: Added.
  • fast/blockflow/resources/oval.png: Added.
  • platform/mac/fast/blockflow/block-level-images-expected.checksum: Added.
  • platform/mac/fast/blockflow/block-level-images-expected.png: Added.
  • platform/mac/fast/blockflow/block-level-images-expected.txt: Added.
12:52 PM Changeset in webkit [68916] by Nate Chapin
  • 2 edits in trunk/WebCore

2010-10-01 Nate Chapin <Nate Chapin>

Reviewed by Darin Adler.

Remove unused Request::buffer() and Request::m_buffer.

​https://bugs.webkit.org/show_bug.cgi?id=47003

  • loader/Request.h:
12:46 PM WebDevelopers edited by possessedpenguinbob@gmail.com
Minor update to Web Inspector link to avoid having to click through on … (diff)
12:40 PM Changeset in webkit [68915] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-10-01 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Minor naming cleanup in WebDragData
​https://bugs.webkit.org/show_bug.cgi?id=46937

This is a two-part patch--one to add the new methods with normalized
names that follow general WebKit convention, and a followup patch to
remove the original methods once Chromium is updated.

  • public/WebDragData.h:
  • src/WebDragData.cpp: (WebKit::WebDragData::hasFileNames): renamed to containsFilenames (WebKit::WebDragData::fileNames): renamed to filenames (WebKit::WebDragData::setFileNames): renamed to setFilenames (WebKit::WebDragData::appendToFileNames): renamed to appendToFilenames (WebKit::WebDragData::containsFilenames): (WebKit::WebDragData::filenames): (WebKit::WebDragData::setFilenames): (WebKit::WebDragData::appendToFilenames): (WebKit::WebDragData::fileContentFileName): renamed to fileContentFilename (WebKit::WebDragData::setFileContentFileName): renamed to setFileContentFilename (WebKit::WebDragData::fileContentFilename): (WebKit::WebDragData::setFileContentFilename):
12:40 PM Changeset in webkit [68914] by abarth@webkit.org
  • 57 edits
    1 move in trunk

2010-09-30 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebSocket tests are flaky
​https://bugs.webkit.org/show_bug.cgi?id=46956

Hosting the WebSocket tests using the Python HTTP server causes the
tests to time out occationally. This patch moves the tests to be
hosted by the usual Apache server.

This patch doesn't completely eliminate the flakiness. However,
testing on my local machine shows that it reduces it by a large factor.
I suspect there's more flakiness hiding in the Python server, but this
patch makes some amount of progress on the issue.

  • http/tests/websocket: Copied from LayoutTests/websocket.
  • http/tests/websocket/tests/alert-in-event-handler.html:
  • http/tests/websocket/tests/bad-handshake-crash.html:
  • http/tests/websocket/tests/bad-sub-protocol-control-chars.html:
  • http/tests/websocket/tests/bad-sub-protocol-empty.html:
  • http/tests/websocket/tests/bad-sub-protocol-non-ascii.html:
  • http/tests/websocket/tests/bufferedAmount-after-close.html:
  • http/tests/websocket/tests/close-on-navigate-new-location.html:
  • http/tests/websocket/tests/close-on-unload-and-force-gc.html:
  • http/tests/websocket/tests/close-on-unload-reference-in-parent.html:
  • http/tests/websocket/tests/close-on-unload.html:
  • http/tests/websocket/tests/cross-origin-expected.txt:
  • http/tests/websocket/tests/cross-origin.html:
  • http/tests/websocket/tests/error-detect.html:
  • http/tests/websocket/tests/frame-length-longer-than-buffer.html:
  • http/tests/websocket/tests/frame-length-overflow.html:
  • http/tests/websocket/tests/frame-length-skip.html:
  • http/tests/websocket/tests/handshake-challenge-randomness.html:
  • http/tests/websocket/tests/handshake-error.html:
  • http/tests/websocket/tests/handshake-fail-by-cross-origin-expected.txt:
  • http/tests/websocket/tests/handshake-fail-by-cross-origin.html:
  • http/tests/websocket/tests/handshake-fail-by-no-cr.html:
  • http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html:
  • http/tests/websocket/tests/httponly-cookie.pl:
  • http/tests/websocket/tests/long-invalid-header.html:
  • http/tests/websocket/tests/null-character.html:
  • http/tests/websocket/tests/reload-crash.html:
  • http/tests/websocket/tests/resources/close-on-unload-iframe-reference-in-parent.html:
  • http/tests/websocket/tests/resources/close-on-unload-iframe.html:
  • http/tests/websocket/tests/resources/js-test-post-function.js: Copied from LayoutTests/fast/js/resources/js-test-post-function.js.
  • http/tests/websocket/tests/resources/js-test-pre.js: Copied from LayoutTests/fast/js/resources/js-test-pre.js.
  • http/tests/websocket/tests/resources/js-test-style.css: Copied from LayoutTests/fast/js/resources/js-test-style.css.
  • http/tests/websocket/tests/resources/reload-crash-iframe.html:
  • http/tests/websocket/tests/script-tests/TEMPLATE.html:
  • http/tests/websocket/tests/script-tests/cross-origin.js: (endTest):
  • http/tests/websocket/tests/send-after-close-on-unload.html:
  • http/tests/websocket/tests/send-throw.html:
  • http/tests/websocket/tests/send.html:
  • http/tests/websocket/tests/simple.html:
  • http/tests/websocket/tests/sub-protocol-with-space.html:
  • http/tests/websocket/tests/sub-protocol.html:
  • http/tests/websocket/tests/unicode.html:
  • http/tests/websocket/tests/url-no-trailing-slash.html:
  • http/tests/websocket/tests/url-parsing-expected.txt:
  • http/tests/websocket/tests/url-parsing.html:
  • http/tests/websocket/tests/url-with-credential.html:
  • http/tests/websocket/tests/url-with-empty-query.html:
  • http/tests/websocket/tests/url-with-query-for-no-query.html:
  • http/tests/websocket/tests/url-with-query.html:
  • http/tests/websocket/tests/websocket-event-target.html:
  • http/tests/websocket/tests/websocket-protocol-ignored.html:
  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/win/Skipped:
  • websocket: Removed.
  • websocket/resources: Removed.
  • websocket/resources/server-failed-to-start.html: Removed.
  • websocket/tests: Removed.
  • websocket/tests/alert-in-event-handler-expected.txt: Removed.
  • websocket/tests/alert-in-event-handler.html: Removed.
  • websocket/tests/bad-handshake-crash-expected.txt: Removed.
  • websocket/tests/bad-handshake-crash.html: Removed.
  • websocket/tests/bad-handshake-crash_wsh.py: Removed.
  • websocket/tests/bad-sub-protocol-control-chars-expected.txt: Removed.
  • websocket/tests/bad-sub-protocol-control-chars.html: Removed.
  • websocket/tests/bad-sub-protocol-empty-expected.txt: Removed.
  • websocket/tests/bad-sub-protocol-empty.html: Removed.
  • websocket/tests/bad-sub-protocol-non-ascii-expected.txt: Removed.
  • websocket/tests/bad-sub-protocol-non-ascii.html: Removed.
  • websocket/tests/bufferedAmount-after-close-expected.txt: Removed.
  • websocket/tests/bufferedAmount-after-close.html: Removed.
  • websocket/tests/close-on-navigate-new-location-expected.txt: Removed.
  • websocket/tests/close-on-navigate-new-location.html: Removed.
  • websocket/tests/close-on-unload-and-force-gc-expected.txt: Removed.
  • websocket/tests/close-on-unload-and-force-gc.html: Removed.
  • websocket/tests/close-on-unload-expected.txt: Removed.
  • websocket/tests/close-on-unload-reference-in-parent-expected.txt: Removed.
  • websocket/tests/close-on-unload-reference-in-parent.html: Removed.
  • websocket/tests/close-on-unload.html: Removed.
  • websocket/tests/close-on-unload_wsh.py: Removed.
  • websocket/tests/cross-origin-expected.txt: Removed.
  • websocket/tests/cross-origin.html: Removed.
  • websocket/tests/echo-challenge_wsh.py: Removed.
  • websocket/tests/echo-cookie_wsh.py: Removed.
  • websocket/tests/echo-location_wsh.py: Removed.
  • websocket/tests/echo_wsh.py: Removed.
  • websocket/tests/error-detect-expected.txt: Removed.
  • websocket/tests/error-detect.html: Removed.
  • websocket/tests/fixed-origin_wsh.py: Removed.
  • websocket/tests/frame-length-longer-than-buffer-expected.txt: Removed.
  • websocket/tests/frame-length-longer-than-buffer.html: Removed.
  • websocket/tests/frame-length-longer-than-buffer_wsh.py: Removed.
  • websocket/tests/frame-length-overflow-expected.txt: Removed.
  • websocket/tests/frame-length-overflow.html: Removed.
  • websocket/tests/frame-length-overflow_wsh.py: Removed.
  • websocket/tests/frame-length-skip-expected.txt: Removed.
  • websocket/tests/frame-length-skip.html: Removed.
  • websocket/tests/frame-length-skip_wsh.py: Removed.
  • websocket/tests/frame-lengths-expected.txt: Removed.
  • websocket/tests/frame-lengths.html: Removed.
  • websocket/tests/handler_map.txt: Removed.
  • websocket/tests/handshake-challenge-randomness-expected.txt: Removed.
  • websocket/tests/handshake-challenge-randomness.html: Removed.
  • websocket/tests/handshake-error-expected.txt: Removed.
  • websocket/tests/handshake-error.html: Removed.
  • websocket/tests/handshake-error_wsh.py: Removed.
  • websocket/tests/handshake-fail-by-cross-origin-expected.txt: Removed.
  • websocket/tests/handshake-fail-by-cross-origin.html: Removed.
  • websocket/tests/handshake-fail-by-no-cr-expected.txt: Removed.
  • websocket/tests/handshake-fail-by-no-cr.html: Removed.
  • websocket/tests/handshake-fail-by-no-cr_wsh.py: Removed.
  • websocket/tests/handshake-fail-by-sub-protocol-mismatch-expected.txt: Removed.
  • websocket/tests/handshake-fail-by-sub-protocol-mismatch.html: Removed.
  • websocket/tests/httponly-cookie-expected.txt: Removed.
  • websocket/tests/httponly-cookie.pl: Removed.
  • websocket/tests/long-invalid-header-expected.txt: Removed.
  • websocket/tests/long-invalid-header.html: Removed.
  • websocket/tests/long-invalid-header_wsh.py: Removed.
  • websocket/tests/multiple-connections-expected.txt: Removed.
  • websocket/tests/multiple-connections.html: Removed.
  • websocket/tests/no-query_wsh.py: Removed.
  • websocket/tests/null-character-expected.txt: Removed.
  • websocket/tests/null-character.html: Removed.
  • websocket/tests/origin-test_wsh.py: Removed.
  • websocket/tests/protocol-test_wsh.py: Removed.
  • websocket/tests/reload-crash-expected.txt: Removed.
  • websocket/tests/reload-crash.html: Removed.
  • websocket/tests/resources: Removed.
  • websocket/tests/resources/close-on-unload-iframe-reference-in-parent.html: Removed.
  • websocket/tests/resources/close-on-unload-iframe.html: Removed.
  • websocket/tests/resources/reload-crash-iframe.html: Removed.
  • websocket/tests/script-tests: Removed.
  • websocket/tests/script-tests/TEMPLATE.html: Removed.
  • websocket/tests/script-tests/alert-in-event-handler.js: Removed.
  • websocket/tests/script-tests/bad-handshake-crash.js: Removed.
  • websocket/tests/script-tests/bad-sub-protocol-control-chars.js: Removed.
  • websocket/tests/script-tests/bad-sub-protocol-empty.js: Removed.
  • websocket/tests/script-tests/bad-sub-protocol-non-ascii.js: Removed.
  • websocket/tests/script-tests/bufferedAmount-after-close.js: Removed.
  • websocket/tests/script-tests/cross-origin.js: Removed.
  • websocket/tests/script-tests/error-detect.js: Removed.
  • websocket/tests/script-tests/frame-length-longer-than-buffer.js: Removed.
  • websocket/tests/script-tests/frame-length-skip.js: Removed.
  • websocket/tests/script-tests/handshake-challenge-randomness.js: Removed.
  • websocket/tests/script-tests/handshake-error.js: Removed.
  • websocket/tests/script-tests/handshake-fail-by-cross-origin.js: Removed.
  • websocket/tests/script-tests/handshake-fail-by-no-cr.js: Removed.
  • websocket/tests/script-tests/handshake-fail-by-sub-protocol-mismatch.js: Removed.
  • websocket/tests/script-tests/long-invalid-header.js: Removed.
  • websocket/tests/script-tests/null-character.js: Removed.
  • websocket/tests/script-tests/send-throw.js: Removed.
  • websocket/tests/script-tests/send.js: Removed.
  • websocket/tests/script-tests/simple.js: Removed.
  • websocket/tests/script-tests/sub-protocol-with-space.js: Removed.
  • websocket/tests/script-tests/sub-protocol.js: Removed.
  • websocket/tests/script-tests/unicode.js: Removed.
  • websocket/tests/script-tests/url-no-trailing-slash.js: Removed.
  • websocket/tests/script-tests/url-parsing.js: Removed.
  • websocket/tests/script-tests/url-with-credential.js: Removed.
  • websocket/tests/script-tests/url-with-empty-query.js: Removed.
  • websocket/tests/script-tests/url-with-query-for-no-query.js: Removed.
  • websocket/tests/script-tests/url-with-query.js: Removed.
  • websocket/tests/script-tests/websocket-event-target.js: Removed.
  • websocket/tests/script-tests/websocket-protocol-ignored.js: Removed.
  • websocket/tests/send-after-close-on-unload-expected.txt: Removed.
  • websocket/tests/send-after-close-on-unload.html: Removed.
  • websocket/tests/send-expected.txt: Removed.
  • websocket/tests/send-throw-expected.txt: Removed.
  • websocket/tests/send-throw.html: Removed.
  • websocket/tests/send.html: Removed.
  • websocket/tests/send2_wsh.py: Removed.
  • websocket/tests/send_wsh.py: Removed.
  • websocket/tests/simple-expected.txt: Removed.
  • websocket/tests/simple-stress-expected.txt: Removed.
  • websocket/tests/simple-stress.html: Removed.
  • websocket/tests/simple.html: Removed.
  • websocket/tests/simple_wsh.py: Removed.
  • websocket/tests/sub-protocol-expected.txt: Removed.
  • websocket/tests/sub-protocol-with-space-expected.txt: Removed.
  • websocket/tests/sub-protocol-with-space.html: Removed.
  • websocket/tests/sub-protocol.html: Removed.
  • websocket/tests/unicode-expected.txt: Removed.
  • websocket/tests/unicode.html: Removed.
  • websocket/tests/unicode_wsh.py: Removed.
  • websocket/tests/unknown-frame-type_wsh.py: Removed.
  • websocket/tests/url-no-trailing-slash-expected.txt: Removed.
  • websocket/tests/url-no-trailing-slash.html: Removed.
  • websocket/tests/url-parsing-expected.txt: Removed.
  • websocket/tests/url-parsing.html: Removed.
  • websocket/tests/url-with-credential-expected.txt: Removed.
  • websocket/tests/url-with-credential.html: Removed.
  • websocket/tests/url-with-empty-query-expected.txt: Removed.
  • websocket/tests/url-with-empty-query.html: Removed.
  • websocket/tests/url-with-query-expected.txt: Removed.
  • websocket/tests/url-with-query-for-no-query-expected.txt: Removed.
  • websocket/tests/url-with-query-for-no-query.html: Removed.
  • websocket/tests/url-with-query.html: Removed.
  • websocket/tests/websocket-event-target-expected.txt: Removed.
  • websocket/tests/websocket-event-target.html: Removed.
  • websocket/tests/websocket-pending-activity-expected.txt: Removed.
  • websocket/tests/websocket-pending-activity.html: Removed.
  • websocket/tests/websocket-protocol-ignored-expected.txt: Removed.
  • websocket/tests/websocket-protocol-ignored.html: Removed.
  • websocket/tests/workers: Removed.
  • websocket/tests/workers/close-in-onmessage-crash-expected.txt: Removed.
  • websocket/tests/workers/close-in-onmessage-crash.html: Removed.
  • websocket/tests/workers/close-in-shared-worker-expected.txt: Removed.
  • websocket/tests/workers/close-in-shared-worker.html: Removed.
  • websocket/tests/workers/close-in-worker-expected.txt: Removed.
  • websocket/tests/workers/close-in-worker.html: Removed.
  • websocket/tests/workers/resources: Removed.
  • websocket/tests/workers/resources/close-in-onmessage-crash.js: Removed.
  • websocket/tests/workers/resources/close-in-worker.js: Removed.
  • websocket/tests/workers/resources/echo-challenge_wsh.py: Removed.
  • websocket/tests/workers/resources/echo_wsh.py: Removed.
  • websocket/tests/workers/resources/simple_wsh.py: Removed.
  • websocket/tests/workers/resources/worker-handshake-challenge-randomness.js: Removed.
  • websocket/tests/workers/resources/worker-simple.js: Removed.
  • websocket/tests/workers/shared-worker-simple-expected.txt: Removed.
  • websocket/tests/workers/shared-worker-simple.html: Removed.
  • websocket/tests/workers/worker-handshake-challenge-randomness-expected.txt: Removed.
  • websocket/tests/workers/worker-handshake-challenge-randomness.html: Removed.
  • websocket/tests/workers/worker-simple-expected.txt: Removed.
  • websocket/tests/workers/worker-simple.html: Removed.

2010-09-30 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebSocket tests are flaky
​https://bugs.webkit.org/show_bug.cgi?id=46956

Update these tools to understand how to run the WebSocket tests off the
Apache server.

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
12:38 PM Changeset in webkit [68913] by Adam Roben
  • 2 edits in trunk/WebKitTools

Encode Executive command arguments using UTF-8 on Cygwin

Cygwin's Python's os.execv doesn't support unicode command arguments.
Cygwin's execv expects arguments to be encoded using the current code
page. But code pages are limited in what characters they can handle,
and our tests include characters that the English code page can't
handle. So for now we'll just encode everything in UTF-8 on Cygwin,
which can handle all characters but might confuse some commands, for
expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
good enough, but we can deal with that when the problem arises.

Reviewed by Adam Barth.

Fixes <​http://webkit.org/b/46892> <rdar://problem/8496639>
webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
fails on Windows

  • Scripts/webkitpy/common/system/executive.py:

(Executive._run_command_with_teed_output):
(Executive.run_command):
On Cygwin, encode arguments using UTF-8.

12:25 PM Changeset in webkit [68912] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Build fix.

Adjust test expectations for Chromium.

  • platform/chromium/test_expectations.txt:
12:16 PM Changeset in webkit [68911] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/7563219> Null dereference when dragging an element with generated content
​https://bugs.webkit.org/show_bug.cgi?id=47005

Reviewed by Adele Peterson.

WebCore:

Test: fast/css-generated-content/drag-state.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::updateDragState): Null-check node().

LayoutTests:

  • fast/css-generated-content/drag-state-expected.txt: Added.
  • fast/css-generated-content/drag-state.html: Added.
12:07 PM Changeset in webkit [68910] by weinig@apple.com
  • 1 edit
    52 adds in trunk/WebKitTools

Add simple API tester for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=46953

Reviewed by Adam Roben.

This adds a very simple testing infrastructure for testing APIs exposed
through the WebKit project. It consists of two parts: 1) a project that
builds the all the tests 2) a script that searches the tests directory and
calls the tester once for each test.

This adds the infrastructure and two tests:

  • Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
  • Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.

This currently only works on the mac, but is designed to be easily ported
to any platform.

  • Scripts/run-api-tests: Added.
  • Scripts/build-api-tests: Added.

Scripts to build/run the tests.

  • TestWebKitAPI: Added.
  • TestWebKitAPI/Configurations: Added.
  • TestWebKitAPI/Configurations/Base.xcconfig: Added.
  • TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
  • TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
  • TestWebKitAPI/ForwardingHeaders: Added.
  • TestWebKitAPI/ForwardingHeaders/wtf: Added.
  • TestWebKitAPI/PlatformUtilities.h: Added.
  • TestWebKitAPI/PlatformWebView.h: Added.

(TestWebKitAPI::PlatformWebView::platformView):

  • TestWebKitAPI/StringFunctions.h: Added.
  • TestWebKitAPI/Test.h: Added.

(TestWebKitAPI::Test::~Test):
(TestWebKitAPI::Test::name):
(TestWebKitAPI::Test::Register::Register):
(TestWebKitAPI::Test::Register::create):
(TestWebKitAPI::Test::Test):

  • TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
  • TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
  • TestWebKitAPI/TestsController.cpp: Added.

(TestWebKitAPI::TestsController::shared):
(TestWebKitAPI::TestsController::TestsController):
(TestWebKitAPI::TestsController::runTestNamed):
(TestWebKitAPI::TestsController::testFailed):
(TestWebKitAPI::TestsController::registerCreateTestFunction):

  • TestWebKitAPI/TestsController.h: Added.
  • TestWebKitAPI/mac: Added.
  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.

(TestWebKitAPI::Util::run):
(TestWebKitAPI::Util::createURLForResource):

  • TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.

(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::page):
(TestWebKitAPI::PlatformWebView::focus):

  • TestWebKitAPI/mac/main.mm: Added.

Infrastructure.

  • TestWebKitAPI/Tests: Added.
  • TestWebKitAPI/Tests/WTF: Added.
  • TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
  • TestWebKitAPI/Tests/WebKit2: Added.
  • TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.

(TestWebKitAPI::State::State):

  • TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.

Proof of concept tests.

12:03 PM Changeset in webkit [68909] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Build fix.

Change test expectations for Chromium.

  • platform/chromium/test_expectations.txt:
11:58 AM Changeset in webkit [68908] by Adam Roben
  • 2 edits in trunk/LayoutTests

Remove a test I just fixed from the Skipped file

  • platform/win/Skipped:
11:56 AM Changeset in webkit [68907] by Adam Roben
  • 2 edits in trunk/WebKitTools

Don't assume AccessibleObjectFromEvent succeeds

Fixes <​http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
DumpRenderTree!notificationListenerProc when running
plugins/access-after-page-destroyed.html

Reviewed by Sam Weinig.

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(notificationListenerProc): Check both the return value of
AccessibleObjectFromEvent and the object it returns, as MSDN
recommends.

11:40 AM Changeset in webkit [68906] by robert@webkit.org
  • 4 edits in trunk

2010-10-01 Robert Hogan <​robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Fix http/tests/loading/redirect-methods.html

​https://bugs.webkit.org/show_bug.cgi?id=41571

Unskip http/tests/loading/redirect-methods.html

  • platform/qt/Skipped:

2010-10-01 Robert Hogan <​robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Fix http/tests/loading/redirect-methods.html

Document our redirection behaviour too.

​https://bugs.webkit.org/show_bug.cgi?id=41571

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  • platform/network/qt/QNetworkReplyHandler.h:
11:31 AM Changeset in webkit [68905] by Adam Roben
  • 3 edits in trunk/WebCore

Copy forwarding headers and Inspector JS files as part of WebCoreGenerated.vcproj

WebCoreGenerated.vcproj runs on every build, while WebCore.vcproj only
runs when a .h or .cpp file changes. By moving the copying to
WebCoreGenerated, it will happen even when someone only changes a JS
file (as happened in r68887).

Fixes <​http://webkit.org/b/46988> <rdar://problem/8502489> REGRESSION
(r68887): Web Inspector: inspector/extensions*.html are failing on
Windows

Reviewed by Anders Carlsson.

  • WebCore.vcproj/WebCore.vcproj: Moved invocation of

copyForwardingHeaders and copyInspectorFiles from here...

  • WebCore.vcproj/WebCoreGenerated.vcproj: ...to here.
11:25 AM Changeset in webkit [68904] by rniwa@webkit.org
  • 6 edits in trunk

2010-09-30 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Implement queryCommandState('justifyFull')
​https://bugs.webkit.org/show_bug.cgi?id=46954

Implemented queryCommandState('justifyFull').
New tests are added to editing/style/inline-style-container.html

  • editing/ApplyStyleCommand.cpp: (WebCore::getTextAlignment): Added support for CSSValueJustify.
  • editing/EditorCommand.cpp: (WebCore::stateJustifyFull): Added. (WebCore::createCommandMap): Added stateJustifyFull.

2010-09-30 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Implement queryCommandState('justifyFull')
​https://bugs.webkit.org/show_bug.cgi?id=46954

Added tests for queryCommandState('justifyFull') to editing/execCommand/query-text-alignment.html

  • editing/execCommand/query-text-alignment-expected.txt:
  • editing/execCommand/script-tests/query-text-alignment.js: (queryTextAlignment): (runRangeTests):
11:17 AM Changeset in webkit [68903] by Csaba Osztrogonác
  • 3 edits in trunk/WebKitTools

2010-10-01 Gabor Rapcsanyi <​rgabor@inf.u-szeged.hu>

Reviewed by Tony Chang.

[NRWT] Put the http and websocket tests first in the test list.
​https://bugs.webkit.org/show_bug.cgi?id=46453

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
11:11 AM Changeset in webkit [68902] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-01 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

Autocorrection shouldn't prompt the same correction after user has edited previous correction.
​https://bugs.webkit.org/show_bug.cgi?id=46839
<rdar://problem/8476963>

  • editing/Editor.cpp: (WebCore::Editor::respondToChangedSelection): Remove "CorrectionIndicator" marker instead of "Replacement" marker. Since the former controls whether we draw autocorrection underline, and the latter is used to prevent autocorrection from being applied again on already auto- corrected word. So the "Replacement" shouldn't be removed.
11:05 AM Changeset in webkit [68901] by Patrick Gansterer
  • 3 edits in trunk/WebCore

2010-10-01 Patrick Gansterer <Patrick Gansterer>

Reviewed by Anders Carlsson.

[CMake] Add handling for ENABLE(NETSCAPE_PLUGIN_API)
​https://bugs.webkit.org/show_bug.cgi?id=46309

  • CMakeLists.txt:
  • CMakeListsEfl.txt:
10:55 AM Changeset in webkit [68900] by hyatt@apple.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46996, patch the functions dealing with the bottom of the block to
be block-flow-aware.

Reviewed by Darin Adler.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::setCollapsedBottomMargin):
(WebCore::RenderBlock::handleAfterSideOfBlock):

10:50 AM Changeset in webkit [68899] by commit-queue@webkit.org
  • 7 edits in trunk

2010-10-01 Pratik Solanki <​psolanki@apple.com>

Reviewed by Geoffrey Garen.
Specify ALWAYS_INLINE at function declaration not function definition
​https://bugs.webkit.org/show_bug.cgi?id=46960

For functions defined with ALWAYS_INLINE, add the attribute to the declaration as well.

  • bytecompiler/BytecodeGenerator.h:
  • wtf/FastMalloc.cpp:

2010-10-01 Pratik Solanki <​psolanki@apple.com>

Reviewed by Geoffrey Garen.
Specify ALWAYS_INLINE at function declaration not function definition
​https://bugs.webkit.org/show_bug.cgi?id=46960

For functions defined with ALWAYS_INLINE, add the attribute to the declaration as well.

  • css/CSSStyleSelector.h:
  • rendering/InlineIterator.h:
  • rendering/style/RenderStyle.h:
10:46 AM Changeset in webkit [68898] by andersca@apple.com
  • 7 edits in trunk/WebKit2

Implement NPN_GetValueForURL/NPN_SetValueForURL and stub out PluginController functions
​https://bugs.webkit.org/show_bug.cgi?id=46992

Reviewed by Dan Bernstein.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::copyCString):
Helper function for allocating a string using NPN_MemAlloc.

(WebKit::NPN_GetValueForURL):
Ask the plug-in for either the proxy or the cookies given an URL.

(WebKit::NPN_SetValueForURL):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

Tell the plug-in to set the cookies for the given URL.

(WebKit::NetscapePlugin::proxiesForURL):
(WebKit::NetscapePlugin::cookiesForURL):
(WebKit::NetscapePlugin::setCookiesForURL):
Call the corresponding PluginController functions.

  • WebProcess/Plugins/PluginController.h:

Add new pure virtual member functions.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::proxiesForURL):
(WebKit::PluginView::cookiesForURL):
(WebKit::PluginView::setCookiesForURL):
Add stubbed out implementations of the new PluginController functions.

  • WebProcess/Plugins/PluginView.h:
10:43 AM Changeset in webkit [68897] by hyatt@apple.com
  • 4 edits
    4 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=46995, make direction propagate up to the viewport from the root element.

Reviewed by Dan Bernstein.

WebCore:

Added fast/css/rtl-to-viewport.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForDocument):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):

LayoutTests:

  • fast/css/rtl-to-viewport.html: Added.
  • platform/mac/fast/css/rtl-to-viewport-expected.checksum: Added.
  • platform/mac/fast/css/rtl-to-viewport-expected.png: Added.
  • platform/mac/fast/css/rtl-to-viewport-expected.txt: Added.
10:29 AM Changeset in webkit [68896] by ap@apple.com
  • 3 edits
    4 adds in trunk

Reviewed by Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=44406
<rdar://problem/8310921> Application Cache crash when a fallback document has a manifest URL

Test: http/tests/appcache/foreign-fallback.html

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): Changed ApplicationCacheResource lookup to find fallback resources correctly.
10:20 AM Changeset in webkit [68895] by kseo@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed, Brew MP build fix.

  • platform/brew/ClipboardBrew.cpp:

(WebCore::ClipboardBrew::ClipboardBrew):

10:01 AM Changeset in webkit [68894] by fsamuel@chromium.org
  • 2 edits in trunk/WebKitTools

Updated stuff.

9:54 AM Changeset in webkit [68893] by kseo@webkit.org
  • 2 edits in trunk/JavaScriptCore

Unreviewed.

[BREWMP] Change Collector BLOCK_SIZE to 64KB
​https://bugs.webkit.org/show_bug.cgi?id=46436

Lower BLOCK_SIZE to 64KB because Brew MP runs on low end devices.

  • runtime/Collector.h:
9:32 AM Changeset in webkit [68892] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-01 Rafael Antognolli <​antognolli@profusion.mobi>

Unreviewed build fix.

[CMAKE] Build fix for r68878
​https://bugs.webkit.org/show_bug.cgi?id=46985

Fix name of files added to CMakeLists.txt:
SVGTextLayoutBaseline.cpp -> SVGTextLayoutEngineBaseline.cpp
SVGTextLayoutSpacing.cpp -> SVGTextLayoutEngineSpacing.cpp

No features added, so no new tests.

  • CMakeLists.txt:
9:16 AM Changeset in webkit [68891] by Adam Roben
  • 9 edits
    3 adds in trunk

Implement NPN_GetValue(NPNVnetscapeWindow)

Fixes <​http://webkit.org/b/46726> <rdar://problem/8486319>
Right-clicking on windowless Flash plugin in WebKit2 makes a context
menu appear in the bottom-right corner of the screen

Test: platform/win/plugins/get-value-netscape-window.html

Reviewed by Anders Carlsson.

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue): Added case for NPNVnetscapeWindow that calls
through to NetscapePlugin::containingWindow.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h: Added containingWindow

on Windows.

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::containingWindow): Added. Calls through to
the PluginController.
(WebKit::NetscapePlugin::platformPostInitialize): Changed to use
containingWindow.

WebKitTools:

Test NPN_GetValue(NPNVnetscapeWindow)

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::NPN_GetValue): Added. Calls through to the browser.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.
  • DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.

(GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
(GetValueNetscapeWindow::NPP_SetWindow): Test that
NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
isn't our HWND.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:

Added GetValueNetscapeWindow.

LayoutTests:

Support for testing NPN_GetValue(NPNVnetscapeWindow)

  • platform/win/plugins/get-value-netscape-window-expected.txt: Added.
  • platform/win/plugins/get-value-netscape-window.html: Added.
7:56 AM Changeset in webkit [68890] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-01 Viatcheslav Ostapenko <​ostapenko.viatcheslav@nokia.com>

Reviewed by Andreas Kling.

[Qt] Stack overflow on symbian platform.
​https://bugs.webkit.org/show_bug.cgi?id=40598

Move big allocation in arrayProtoFuncToString from stack to heap.
JSC::arrayProtoFuncToString function can be called recursivly and
1K allocation on stack cahse stack overflow.
Can be useful for other platforms with limited stack size.

  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncToString):
6:52 AM Changeset in webkit [68889] by andreas.kling@nokia.com
  • 4 edits
    2 moves in trunk/WebCore

2010-10-01 Ragner Magalhaes <​ragner.magalhaes@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] New buttons style for Qt Mobile theme
​https://bugs.webkit.org/show_bug.cgi?id=46920

Rename Maemo5Webstyle to QtMobileWebStyle since it implements the style for all Qt mobile platform.
Adjust new Qt mobile style for buttons, radios, checks and combos.

  • WebCore.pro:
  • css/themeQtMobile.css: Adjust gradient color for buttons and combos. (select): (select:active):
  • platform/qt/QtMobileWebStyle.cpp: Renamed from platform/qt/Maemo5Webstyle.cpp to match name scheme. (QtMobileWebStyle::QtMobileWebStyle): (drawRectangularControlBackground): (QtMobileWebStyle::drawChecker): (QtMobileWebStyle::findChecker): (QtMobileWebStyle::drawRadio): Adjust gradient color for RadioButton. (QtMobileWebStyle::findRadio): (QtMobileWebStyle::drawControl): Adjust gradient color for CheckBox. (QtMobileWebStyle::drawMultipleComboButton): (QtMobileWebStyle::drawSimpleComboButton): Adjust ComboBox arrow. (QtMobileWebStyle::getButtonImageSize): (QtMobileWebStyle::findComboButton): (QtMobileWebStyle::drawComplexControl):
  • platform/qt/QtMobileWebStyle.h: Renamed from platform/qt/Maemo5Webstyle.h to match name scheme.
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::RenderThemeQt):
6:49 AM Changeset in webkit [68888] by Adam Roben
  • 1 edit
    4 adds in trunk/LayoutTests

Add expected Windows results for scrollbars/custom-scrollbar-with-incomplete-style.html

This test was added in r66372 without any expected results.

  • platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
  • platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
  • platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
6:43 AM Changeset in webkit [68887] by caseq@chromium.org
  • 8 edits in trunk

2010-10-01 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] expose page load events timings
Added webInspector.resources.getPageTimings()
​https://bugs.webkit.org/show_bug.cgi?id=45954

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.Resources.prototype): (WebInspector.injectedExtensionAPI.Resources.prototype.getPageTimings):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._onGetPageTimings):
  • inspector/front-end/HAREntry.js: Return page event timings as -1 if start or event time unknown. (WebInspector.HARLog.prototype._buildPages): (WebInspector.HARLog.prototype.buildMainResourceTimings): (WebInspector.HARLog.prototype._convertResource): (WebInspector.HARLog.prototype._pageEventTime):

2010-10-01 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] expose page load events timings
Added webInspector.resources.getPageTimings()
​https://bugs.webkit.org/show_bug.cgi?id=45954

  • inspector/extensions-api-expected.txt:
  • inspector/extensions-resources-expected.txt:
  • inspector/extensions-resources.html:
6:37 AM Changeset in webkit [68886] by Adam Roben
  • 2 edits in trunk/LayoutTests

Remove the fixed test from the Skipped file, too

  • platform/win/Skipped:
6:35 AM Changeset in webkit [68885] by Adam Roben
  • 1 edit
    1 delete in trunk/LayoutTests

Remove bogus Windows results for clip-path-referencing-use2.svg

Fixes <​http://webkit.org/b/46919> <rdar://problem/8497626> REGRESSION?
(r65617?): svg/custom/clip-path-referencing-use2.svg fails on Windows

Rubber-stamped by Nikolas Zimmermann.

  • platform/win/svg/custom/clip-path-referencing-use2-expected.txt: Removed.
6:30 AM Changeset in webkit [68884] by Adam Roben
  • 4 edits in trunk/LayoutTests

Make regression tests pass on machines with 16-bit displays

I made these tests require 24-bit displays in r68808 and r68809,
thinking that we didn't have any testers that had 16-bit displays. But
apparently I was wrong; at least one Windows tester has a 16-bit
display.

Fixes <​http://webkit.org/b/46980>
fast/media/color-does-not-include-alpha.html failing on Windows

Reviewed by Nikolas Zimmermann.

  • fast/dom/Window/window-screen-properties-expected.txt: Updated

results.

  • fast/dom/Window/window-screen-properties.html: Changed to allow

either 16 or 24 bits.

  • fast/media/color-does-not-include-alpha.html: Changed to allow

either 5 or 8 bits per channel.

6:09 AM Changeset in webkit [68883] by Patrick Gansterer
  • 1 edit
    2 adds in trunk/WebCore

2010-10-01 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WIN] Add GDIExtras
​https://bugs.webkit.org/show_bug.cgi?id=46974

Some, but not all WinCE environments have support for AlphaBlend().
Add this files to check for AlphaBlend (and SoftLink) on WinCE.
On WinNT alphaBlendIfSupported() inlines AlphaBlend and returns true.

  • platform/graphics/win/GDIExtras.cpp: Added. (WebCore::AlphaBlendPointer):
  • platform/graphics/win/GDIExtras.h: Added. (WebCore::hasAlphaBlendSupport): (WebCore::alphaBlendIfSupported):
6:04 AM Changeset in webkit [68882] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-10-01 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WINCE] Use alphaBlendIfSupported in GraphicsContext
​https://bugs.webkit.org/show_bug.cgi?id=46979

  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContextPlatformPrivate::paintBackTransparentLayerBitmap):
5:58 AM Changeset in webkit [68881] by Csaba Osztrogonác
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed rolling out r68633, because we don't need Qt specific expected results any more.

  • platform/qt/canvas: Removed.
  • platform/qt/canvas/philip: Removed.
  • platform/qt/canvas/philip/tests: Removed.
  • platform/qt/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.line.cap.closed-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.line.join.parallel-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.shadow.gradient.alpha-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.shadow.gradient.basic-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.shadow.gradient.transparent.2-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Removed.
  • platform/qt/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Removed.
5:24 AM Changeset in webkit [68880] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKitTools

2010-10-01 Andreas Kling <​andreas.kling@nokia.com>

Unreviewed, adding my webkit.org identity to reviewer list.

  • Scripts/webkitpy/common/config/committers.py:
5:03 AM Changeset in webkit [68879] by Adam Roben
  • 2 edits in trunk/LayoutTests

Add some more failing tests to the Windows Skipped file

  • platform/win/Skipped:
4:38 AM Changeset in webkit [68878] by Nikolas Zimmermann
  • 8 edits
    4 adds in trunk/WebCore

2010-10-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Add two new helper files for the new SVGTextLayoutEngine
​https://bugs.webkit.org/show_bug.cgi?id=46972

Refactor code from SVGTextLayoutUtilities into two seperated classes.
SVGTextLayoutUtilities will be removed, as soon as the main clss SVGTextLayoutEngine lands and gets used.

Doesn't affect any functionality yet, as the new classes are not used so far.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/svg/SVGTextFragment.h:
  • rendering/svg/SVGTextLayoutEngineBaseline.cpp: Added. (WebCore::SVGTextLayoutEngineBaseline::SVGTextLayoutEngineBaseline): (WebCore::SVGTextLayoutEngineBaseline::calculateBaselineShift): (WebCore::SVGTextLayoutEngineBaseline::dominantBaselineToAlignmentBaseline): (WebCore::SVGTextLayoutEngineBaseline::calculateAlignmentBaselineShift): (WebCore::SVGTextLayoutEngineBaseline::calculateGlyphOrientationAngle): (WebCore::glyphOrientationIsMultiplyOf180Degrees): (WebCore::SVGTextLayoutEngineBaseline::calculateGlyphAdvanceAndOrientation):
  • rendering/svg/SVGTextLayoutEngineBaseline.h: Added.
  • rendering/svg/SVGTextLayoutEngineSpacing.cpp: Added. (WebCore::SVGTextLayoutEngineSpacing::SVGTextLayoutEngineSpacing): (WebCore::SVGTextLayoutEngineSpacing::calculateSVGKerning): (WebCore::SVGTextLayoutEngineSpacing::calculateCSSKerningAndSpacing):
  • rendering/svg/SVGTextLayoutEngineSpacing.h: Added.
3:50 AM Changeset in webkit [68877] by morrita@google.com
  • 2 edits
    2 adds in trunk/LayoutTests

2010-10-01 MORITA Hajime <​morrita@google.com>

Unreviewed, added a expectation.

  • platform/chromium-mac/fast/repaint/canvas-putImageData-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/canvas-putImageData-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:45 AM Changeset in webkit [68876] by Nikolas Zimmermann
  • 9 edits
    2 moves in trunk/WebCore

2010-10-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Andreas Kling.

Rename SVGTextLayoutBuilder to SVGTextLayoutAttributesBuilder
​https://bugs.webkit.org/show_bug.cgi?id=46971

Doesn't affect any functionality, just moves files around.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::layout): Adopt to renaming.
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp: Copied from rendering/svg/SVGTextLayoutBuilder.cpp.
  • rendering/svg/SVGTextLayoutAttributesBuilder.h: Copied from rendering/svg/SVGTextLayoutBuilder.h.
  • rendering/svg/SVGTextLayoutBuilder.cpp: Removed.
  • rendering/svg/SVGTextLayoutBuilder.h: Removed.
3:41 AM Changeset in webkit [68875] by morrita@google.com
  • 2 edits in trunk/WebCore

2010-10-01 MORITA Hajime <​morrita@google.com>

Unreviewed build fix.

  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::PlatformContextSkia):
3:19 AM Changeset in webkit [68874] by Nikolas Zimmermann
  • 9 edits
    18 moves in trunk/WebCore

2010-10-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Andreas Kling.

Move SVG text related renderers into rendering/svg/
​https://bugs.webkit.org/show_bug.cgi?id=46969

Doesn't affect any functionality, just moves files around.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderSVGAllInOne.cpp:
  • rendering/RenderSVGInline.cpp: Removed.
  • rendering/RenderSVGInline.h: Removed.
  • rendering/RenderSVGInlineText.cpp: Removed.
  • rendering/RenderSVGInlineText.h: Removed.
  • rendering/RenderSVGTSpan.cpp: Removed.
  • rendering/RenderSVGTSpan.h: Removed.
  • rendering/RenderSVGText.cpp: Removed.
  • rendering/RenderSVGText.h: Removed.
  • rendering/RenderSVGTextPath.cpp: Removed.
  • rendering/RenderSVGTextPath.h: Removed.
  • rendering/SVGInlineFlowBox.cpp: Removed.
  • rendering/SVGInlineFlowBox.h: Removed.
  • rendering/SVGInlineTextBox.cpp: Removed.
  • rendering/SVGInlineTextBox.h: Removed.
  • rendering/SVGRootInlineBox.cpp: Removed.
  • rendering/SVGRootInlineBox.h: Removed.
  • rendering/SVGTextQuery.cpp: Removed.
  • rendering/SVGTextQuery.h: Removed.
  • rendering/svg/RenderSVGInline.cpp: Copied from rendering/RenderSVGInline.cpp.
  • rendering/svg/RenderSVGInline.h: Copied from rendering/RenderSVGInline.h.
  • rendering/svg/RenderSVGInlineText.cpp: Copied from rendering/RenderSVGInlineText.cpp.
  • rendering/svg/RenderSVGInlineText.h: Copied from rendering/RenderSVGInlineText.h.
  • rendering/svg/RenderSVGTSpan.cpp: Copied from rendering/RenderSVGTSpan.cpp.
  • rendering/svg/RenderSVGTSpan.h: Copied from rendering/RenderSVGTSpan.h.
  • rendering/svg/RenderSVGText.cpp: Copied from rendering/RenderSVGText.cpp.
  • rendering/svg/RenderSVGText.h: Copied from rendering/RenderSVGText.h.
  • rendering/svg/RenderSVGTextPath.cpp: Copied from rendering/RenderSVGTextPath.cpp.
  • rendering/svg/RenderSVGTextPath.h: Copied from rendering/RenderSVGTextPath.h.
  • rendering/svg/SVGInlineFlowBox.cpp: Copied from rendering/SVGInlineFlowBox.cpp.
  • rendering/svg/SVGInlineFlowBox.h: Copied from rendering/SVGInlineFlowBox.h.
  • rendering/svg/SVGInlineTextBox.cpp: Copied from rendering/SVGInlineTextBox.cpp.
  • rendering/svg/SVGInlineTextBox.h: Copied from rendering/SVGInlineTextBox.h.
  • rendering/svg/SVGRootInlineBox.cpp: Copied from rendering/SVGRootInlineBox.cpp.
  • rendering/svg/SVGRootInlineBox.h: Copied from rendering/SVGRootInlineBox.h.
  • rendering/svg/SVGTextQuery.cpp: Copied from rendering/SVGTextQuery.cpp.
  • rendering/svg/SVGTextQuery.h: Copied from rendering/SVGTextQuery.h.
2:11 AM Changeset in webkit [68873] by Nikolas Zimmermann
  • 8 edits
    5 adds in trunk/WebCore

2010-10-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Add SVGTextMetrics/SVGTextFragment/SVGTextChunk primitives used by the new layout engine
​https://bugs.webkit.org/show_bug.cgi?id=46964

The new SVG text layout engine will use these new classes.
1) SVGTextMetrics is used to measure either single glyphs (which may span multiple characters, when ligatures are defined) or a range of characters.


-> In "single glyph" mode, it returns the width/height of the glyph, the length of the glyph (> 1, when ligatures are used) and a "Glyph" object

describing the glyph (name of glyph, when used together with SVG Fonts and the unicode string the glyph describes).

-> In "range of characters" mode, it returns the width/height of the range, and its length.

All measurements are done using the regular Font::floatWidth() methods, this class just encapsulates its usage for the SVG text layout engine.

2) SVGTextFragment describes a fragment of text, living in a SVGInlineTextBox, which can be measured/rendered in one shot.

It contains all necessary information to render the fragment (x/y/width/height, offset into characters() buffer for the first char of the fragment,
length, and an arbitary transformation, holding information about rotations/scale/glyph-orientation etc.)

In future the SVGTextLayoutEngine will generate SVGTextFragment objects for each SVGInlineTextBox. When painting no more measurements have to
be performed as SVGTextFragment contains all necessary information to render text / select text etc.

3) SVGTextChunk describes a SVG text chunk, which may span multiple text boxes (and in turn text fragments).

Quotes from SVG spec:
Each absolute position adjustment defines a new "text chunk". Absolute position adjustments impact text layout in the following ways:

  • Ligatures only occur when a set of characters which might map to a ligature are all in the same text chunk.
  • Each text chunk represents a separate block of text for alignment due to "text-anchor" property values.
  • Reordering of characters due to bidirectionality only occurs within a text chunk. Reordering does not happen across text chunks.

An absolute position adjustment occurs in the following circumstances:

  • At the start of a <text> element
  • At the start of each <textPath> element
  • For each character within a <text>, <tspan>, <tref> and <altGlyph> element which has an "x" or "y" attribute value assigned to it explicitly

After the line-layout finishes, each "text chunk" is altered according to the textLength and text-anchor processing rules
(eg. for text-anchor="middle" moving the whole text chunk by -fragmentWidth/2, for horizontal text).

SVGTextChunk is just a simple helper class, that encapsulates measuring/altering a text chunk.

Doesn't affect any tests, as these classes aren't used so far.

  • Android.mk: Add SVGTextMetrics.*, SVGTextFragment.h, SVGTextChunk.* to build.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/svg/SVGTextChunk.cpp: Added.
  • rendering/svg/SVGTextChunk.h: Added.
  • rendering/svg/SVGTextFragment.h: Added.
  • rendering/svg/SVGTextMetrics.cpp: Added.
  • rendering/svg/SVGTextMetrics.h: Added.
1:21 AM Changeset in webkit [68872] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] fast/media/color-does-not-include-alpha.html fails
​https://bugs.webkit.org/show_bug.cgi?id=46966

  • platform/qt/Skipped: fast/media/color-does-not-include-alpha.html added until fix.
1:06 AM Changeset in webkit [68871] by jochen@chromium.org
  • 4 edits in trunk/WebKit/chromium

2010-10-01 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Darin Fisher.

[chromium] add an identifier method to WebFrame. The identifier can be used to identify
a given frame of a view over time. Using a pointer to the WebFrame object is fragile,
since a new frame might have been allocated at the same address as an old, deleted frame.
​https://bugs.webkit.org/show_bug.cgi?id=46884

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::generateFrameIdentifier): (WebKit::WebFrameImpl::identifier): (WebKit::WebFrameImpl::WebFrameImpl):
  • src/WebFrameImpl.h:
12:52 AM Changeset in webkit [68870] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-01 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

http/tests/navigation/ping-same-origin.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=46961

This test fails by forgetting to print out the REQUEST_METHOD:

​http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r68727%20(18470)/http/tests/navigation/ping-same-origin-pretty-diff.html

The only way this makes sense is if the file isn't finished writing by
the time it gets read. This can happen because the reader is polling
the file for existence (!) to decide whether to read it.

This patch writes to a temporary location and then moves the finished
bytes into the well-known location atomically. I haven't verified that
it fixes the flakiness, but it seems like a good bet.

  • http/tests/navigation/resources/save-ping.php:
12:32 AM Changeset in webkit [68869] by jam@chromium.org
  • 10 edits in trunk/WebKit/chromium

2010-09-29 John Abd-El-Malek <​jam@chromium.org>

Reviewed by NOBODY (OOPS!).

[chromium] Changes to consolidate plugin zoom
​https://bugs.webkit.org/show_bug.cgi?id=46550

  • public/WebPlugin.h: (WebKit::WebPlugin::setZoomLevel):
  • public/WebPluginContainer.h:
  • public/WebView.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::zoomLimitsChanged): (WebKit::WebViewClient::zoomLevelChanged):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::createPlugin):
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::loadFrameRequest): (WebKit::WebPluginContainerImpl::zoomChanged): (WebKit::WebPluginContainerImpl::zoomLimitsChanged):
  • src/WebPluginContainerImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::zoomLevel): (WebKit::WebViewImpl::setZoomLevel): (WebKit::WebViewImpl::zoomLimitsChanged): (WebKit::WebViewImpl::fullFramePluginZoomLevelChanged): (WebKit::WebView::zoomLevelToZoomFactor): (WebKit::WebView::zoomFactorToZoomLevel):
  • src/WebViewImpl.h:
12:28 AM Changeset in webkit [68868] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

2010-10-01 Vincent Scheib <​scheib@chromium.org>

Reviewed by James Robinson.

REGRESSION: Lots of fast canvas updates fail to completely render
​https://bugs.webkit.org/show_bug.cgi?id=46319

  • fast/repaint/canvas-putImageData-expected.txt: Added.
  • fast/repaint/canvas-putImageData.html: Added.
  • platform/chromium-win/fast/repaint/canvas-putImageData-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/canvas-putImageData-expected.png: Added.
  • platform/chromium/test_expectations.txt:

2010-10-01 Vincent Scheib <​scheib@chromium.org>

Reviewed by James Robinson.

REGRESSION: Lots of fast canvas updates fail to completely render
​https://bugs.webkit.org/show_bug.cgi?id=46319

Test: fast/repaint/canvas-putImageData.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::putImageData):
12:16 AM Changeset in webkit [68867] by Nikolas Zimmermann
  • 5 edits in trunk/WebCore

2010-10-01 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Add helper methods to cast between renderers & SVGTextContent/PositioningElement
​https://bugs.webkit.org/show_bug.cgi?id=46963

Doesn't affect any tests.

  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::elementFromRenderer):
  • svg/SVGTextContentElement.h:
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::elementFromRenderer):
  • svg/SVGTextPositioningElement.h:

Sep 30, 2010:

11:41 PM Changeset in webkit [68866] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-30 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

The WebSocket server should flush its logs
​https://bugs.webkit.org/show_bug.cgi?id=46946

The WebSocket server logs are truncated because the driver just
terminates the child. It should run Python without buffering so we can
see the end of the log.

  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
10:58 PM Changeset in webkit [68865] by morrita@google.com
  • 6 edits in trunk

2010-09-30 MORITA Hajime <​morrita@google.com>

Reviewed by James Robinson.

[Chromium] build fails unless ACCELERATED_2D_CANVAS defined
​https://bugs.webkit.org/show_bug.cgi?id=46955

Added ifdef guard around SharedGraphicsContext3D.

No new tests. just a build fix.

  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::~PlatformContextSkia): (WebCore::PlatformContextSkia::setSharedGraphicsContext3D): (WebCore::PlatformContextSkia::uploadSoftwareToHardware): (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
  • platform/graphics/skia/PlatformContextSkia.h: (WebCore::PlatformContextSkia::gpuCanvas):

2010-09-30 MORITA Hajime <​morrita@google.com>

Reviewed by James Robinson.

[Chromium] build fails unless ACCELERATED_2D_CANVAS defined
​https://bugs.webkit.org/show_bug.cgi?id=46955

Added ifdef guard around SharedGraphicsContext3D.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::getSharedGraphicsContext3D):
  • src/WebViewImpl.h:
10:33 PM WebCoreRendering edited by luxtella@company100.net
(diff)
10:09 PM Changeset in webkit [68864] by tkent@chromium.org
  • 3 edits in trunk/WebCore

2010-09-30 Kent Tamura <​tkent@chromium.org>

Reviewed by Chris Fleizach.

[Windows] Implement <input type=number> UI
​https://bugs.webkit.org/show_bug.cgi?id=38381

Implement theme drawing for inner-spin-button.
No new tests. Existing tests for type=number will cover this change.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::RenderThemeWin): Handle m_spinButtonTheme. (WebCore::RenderThemeWin::spinButtonTheme): ditto. (WebCore::RenderThemeWin::close): ditto. (WebCore::RenderThemeWin::determineClassicState): Add ControlSubPart parameter, and add support for InnerSpinButtonPart. (WebCore::RenderThemeWin::determineSpinButtonState): Added. (WebCore::RenderThemeWin::getClassicThemeData): Add ControlSubPart parameter, and handle InnerSpinButtonPart. (WebCore::RenderThemeWin::getThemeData): ditto. (WebCore::RenderThemeWin::adjustInnerSpinButtonStyle): Set SM_CXVSCROLL value to the width. (WebCore::RenderThemeWin::paintInnerSpinButton): Call drawControl() for the upper part and the lower part.
  • rendering/RenderThemeWin.h:
10:05 PM Changeset in webkit [68863] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-30 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Add recent failures.
9:51 PM Changeset in webkit [68862] by tkent@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, Windows build fix for r68854

  • WebCore.vcproj/copyForwardingHeaders.cmd: Copy WebCore/html/parser/*.h.
8:55 PM Changeset in webkit [68861] by Simon Fraser
  • 4 edits in trunk/WebKitTools

2010-09-30 Simon Fraser <Simon Fraser>

Add a button to jump to the next untested test.

  • CSSTestSuiteHarness/harness/harness.css: (.test-type): (.name > button):
  • CSSTestSuiteHarness/harness/harness.html:
  • CSSTestSuiteHarness/harness/harness.js: (Chapter.prototype.description): (Chapter.prototype.untestedCount): (TestSuite.prototype.testInfoDataLoaded): (TestSuite.prototype.fillChapterPopup): (TestSuite.prototype.updateChapterPopup): (TestSuite.prototype.buildTestListForChapter): (TestSuite.prototype.goToNextIncompleteTest): (TestSuite.prototype.firstIncompleteTestIndex): (TestSuite.prototype.testCompletionStateChanged):
8:25 PM Changeset in webkit [68860] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-09-30 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dan Bernstein.

While updating :before and :after content, make sure that the generated
container is allowed to add the child type.
​https://bugs.webkit.org/show_bug.cgi?id=46106

Test: fast/css-generated-content/text-before-table-col-crash.html

  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent):

2010-09-30 Abhishek Arya <​inferno@chromium.org>

Reviewed by Dan Bernstein.

Tests that adding text to a :before container that is styled as a
table column group does not result in crash.
​https://bugs.webkit.org/show_bug.cgi?id=46106

  • fast/css-generated-content/text-before-table-col-crash-expected.txt: Added.
  • fast/css-generated-content/text-before-table-col-crash.html: Added.
6:35 PM Changeset in webkit [68859] by hclam@chromium.org
  • 2 edits
    41 adds in trunk/LayoutTests

Not reviewed. Build fix.

Adjust test expectations for Chromium.

  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
6:24 PM Changeset in webkit [68858] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-30 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Daniel Bates.

[GTK] Crash on testatk.c unittest because of a call to ASSERT_NOT_REACHED
​https://bugs.webkit.org/show_bug.cgi?id=46886

Removed call to ASSERT_NOT_REACHED() from listMarkerSuffix().

So far, this assertion made sense because it was not possible that
a call to listMarkerSuffix() happened when the style of the list
item was one of the following: Asterisks, Circle, Discm Footnotes,
NoneListStyle or Square (it's easy to figure this out by checking
the functions where listMarkerSuffix() was called).

However, since revision 68415 (about bug 45381), there's a new
place where listMarkerSuffix() is being called (the suffix()
public method), regardless of the style of the item being or not
one of those pointed out, so the aforementioned assertion in
listMarkerSuffix() would no longer be correct, as now it's ok to
reach those cases in the switch statement.

  • rendering/RenderListMarker.cpp: (WebCore::listMarkerSuffix): Removed call to ASSERT_NOT_REACHED().
6:22 PM Changeset in webkit [68857] by mrowe@apple.com
  • 5 edits in branches/safari-533.19-branch

Build fixes.

6:13 PM Changeset in webkit [68856] by Beth Dakin
  • 3 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=46948 Crash with all-
whitespace separators for mfenced

Reviewed by Adele Peterson.

WebCore:

Check the size of characters instead of separators in case all the
separators were whitespace.

  • mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::updateFromElement):

LayoutTests:

  • mathml/fenced-whitespace-separators-crash-expected.txt: Added.
  • mathml/fenced-whitespace-separators-crash.html: Added.
5:39 PM Changeset in webkit [68855] by Simon Fraser
  • 4 edits in trunk/LayoutTests

2010-09-30 Simon Fraser <Simon Fraser>

Reviewed by Jon Honeycutt.

REGRESSION (r65681): Crash in AccessibilityUIElement::addSelection when running platform/win/accessibility/selection-and-focus.html
​https://bugs.webkit.org/show_bug.cgi?id=46913

REGRESSION (r65681): platform/win/accessibility/img-alt-attribute.html failing on Windows
​https://bugs.webkit.org/show_bug.cgi?id=46914

<rdar://problem/8497332&8497393>

Fix two layout tests that made incorrect assumptions about the structure of the
accessibility tree.

  • platform/win/Skipped:
  • platform/win/accessibility/img-alt-attribute.html:
  • platform/win/accessibility/selection-and-focus.html:
5:04 PM Changeset in webkit [68854] by Darin Adler
  • 75 edits
    2 moves
    1 delete in trunk

2010-09-30 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Remove remaining calls to deprecatedParseURL
​https://bugs.webkit.org/show_bug.cgi?id=26599

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidFailToStartPlugin): Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.

2010-09-30 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Remove remaining calls to deprecatedParseURL
​https://bugs.webkit.org/show_bug.cgi?id=26599

  • DOM/WebDOMOperations.mm: (-[DOMDocument URLWithAttributeString:]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.

2010-09-30 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Remove remaining calls to deprecatedParseURL
​https://bugs.webkit.org/show_bug.cgi?id=26599

Test: fast/replaced/object-param-spaces.html

  • css/CSSHelper.cpp: Removed.
  • css/CSSHelper.h: Removed deprecatedParseURL.
  • html/parser/HTMLParserIdioms.cpp: (WebCore::stripLeadingAndTrailingHTMLSpaces): Fixed bug where the function would turn the null string into the empty string. Fixed bug where the function would not strip all trailing spaces.
  • html/parser/CSSPreloadScanner.cpp: (WebCore::CSSPreloadScanner::CSSPreloadScanner): Initialize m_state instead of calling the reset function. (WebCore::CSSPreloadScanner::scan): Tweaked coding style. (WebCore::CSSPreloadScanner::tokenize): Use isHTMLSpace instead of an identical local function named isWhitespace. (WebCore::parseCSSStringOrURL): Added. This function does what deprecatedParseURL did before, and this is the only place in WebKit that needs it. The code implements the rules for a string or URL token. The real CSS parser does this with flex and the code to hook flex up to yacc, so the function is not needed there. (WebCore::CSSPreloadScanner::emitRule): Streamlined the code a bit and mae it call parseCSSStringOrURL.
  • bindings/generic/BindingSecurity.h: (WebCore::::allowSettingFrameSrcToJavascriptUrl):
  • bindings/js/JSDOMBinding.cpp: (WebCore::allowSettingSrcToJavascriptURL):
  • bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::allowSettingJavascriptURL):
  • bindings/objc/DOM.mm: (-[DOMElement _getURLAttribute:]):
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
  • dom/Document.cpp: (WebCore::Document::processBaseElement):
  • dom/Element.cpp: (WebCore::isAttributeToRemove): (WebCore::Element::getURLAttribute): (WebCore::Element::getNonEmptyURLAttribute):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::parseMappedAttribute): (WebCore::HTMLAnchorElement::href):
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parseMappedAttribute):
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::parseMappedAttribute):
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute):
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::sourceURI):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::parseMappedAttribute):
  • html/HTMLMediaElement.cpp:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::parametersForPlugin):
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute):
  • html/HTMLTablePartElement.cpp: (WebCore::HTMLTablePartElement::parseMappedAttribute):
  • html/parser/HTMLPreloadScanner.cpp: (WebCore::HTMLNames::PreloadTask::setUrlToLoad):
  • loader/FormSubmission.cpp: (WebCore::FormSubmission::Attributes::parseAction):
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::declareAndWriteDragImage):
  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeImage):
  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::declareAndWriteDragImage):
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::declareAndWriteDragImage):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteImageURL): (WebCore::HitTestResult::absoluteMediaURL): (WebCore::HitTestResult::absoluteLinkURL):
  • svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
  • svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::sourceURI):
  • wml/WMLAElement.cpp: (WebCore::WMLAElement::defaultEventHandler):
  • wml/WMLImageLoader.cpp: (WebCore::WMLImageLoader::sourceURI): Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
  • WebCore.exp.in: Updated.
  • Android.mk: Removed CSSHelper.cpp.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSAttrCustom.cpp:
  • bindings/js/JSElementCustom.cpp:
  • bindings/v8/custom/V8ElementCustom.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
  • css/CSSParser.cpp:
  • html/HTMLMediaElement.cpp:
  • html/HTMLVideoElement.cpp:
  • loader/ImageLoader.cpp:
  • rendering/style/RenderStyle.h: Removed unneeded include of CSSHelper.h.

2010-09-30 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Remove remaining calls to deprecatedParseURL
​https://bugs.webkit.org/show_bug.cgi?id=26599

  • fast/replaced/object-param-spaces-expected.txt: Copied from LayoutTests/fast/replaced/object-param-url-control-char-expected.txt.
  • fast/replaced/object-param-spaces.html: Copied from LayoutTests/fast/replaced/object-param-url-control-char.html.
  • fast/replaced/object-param-url-control-char-expected.txt: Removed.
  • fast/replaced/object-param-url-control-char.html: Removed. Changed this test to expect HTML standard space trimming, but not the WebKit-only control character stripping we had historically.
  • fast/url/query-expected.txt: Updated to expect the test to pass.
  • fast/url/script-tests/segments-from-data-url.js: Changed expected result to not expect stripping of newline characters.
  • fast/url/script-tests/segments.js: Ditto.
  • fast/url/segments-expected.txt: Updated results.
  • fast/url/segments-from-data-url-expected.txt: Ditto.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: These tests had multiple test cases with embedded control characters. These URLs no longer qualify as javascript URLs, so there are no longer any unsafe JavaScript log messages for them. The test cases themselves need not be changed at this time.
  • http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt: Updated expected results to reflect the fact that the control character is no longer stripped from the URL in these cases. The test is still valid, but these are not as interesting test cases any more since control characters do not have special handling.
4:41 PM Changeset in webkit [68853] by Martin Robinson
  • 3 edits
    2 adds in trunk/LayoutTests

2010-09-30 Martin Robinson <​mrobinson@igalia.com>

Unskip some tests that are passing and rebaseline a couple others.

  • platform/gtk/Skipped: Unskip tests and do a little reorganization.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt: Rebaselined.
  • platform/gtk/fast/overflow/line-clamp-expected.txt: Added.
4:25 PM Changeset in webkit [68852] by hclam@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Build fix. Not reviewed.

Remove a test expectation since the problem was fixed.

  • platform/chromium-win/editing/execCommand/toggle-compound-styles-expected.txt: Removed.
4:18 PM Changeset in webkit [68851] by Simon Fraser
  • 3 edits in trunk/WebKit2

2010-09-30 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Background doesn't draw when entering accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=45848

LayerBackedDrawingArea::setSize() is normally called in response
to a message from the UI process, so this can come some time after
LayerBackedDrawingArea creation. Depending on the timing, we could
end up being at size 0x0 for the first invalidate and paint, resulting
in missing content.

The fix is to size the backing layer on creation, using the WebView's size.

Also changed various calls to syncCompositingStateForThisLayerOnly()
to do lazy updates via scheduleCompositingLayerSync().

Also add the fix for ​https://bugs.webkit.org/show_bug.cgi?id=46226 (r68028)
to the WebKit2 code, in scheduleUpdateLayoutRunLoopObserver().

  • WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea): (WebKit::LayerBackedDrawingArea::setNeedsDisplay): (WebKit::LayerBackedDrawingArea::setSize):
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::platformInit): (WebKit::LayerBackedDrawingArea::attachCompositingContext): (WebKit::LayerBackedDrawingArea::detachCompositingContext): (WebKit::LayerBackedDrawingArea::setRootCompositingLayer): (WebKit::LayerBackedDrawingArea::syncCompositingLayers): (WebKit::LayerBackedDrawingArea::scheduleUpdateLayoutRunLoopObserver):
4:17 PM Changeset in webkit [68850] by commit-queue@webkit.org
  • 6 edits in trunk

2010-09-30 Alexey Marinichev <​amarinichev@chromium.org>

Reviewed by Chris Marrin.

Add GetGraphicsResetStatusARB entry point from ARB_robustness
extension to GraphicsContext3D
​https://bugs.webkit.org/show_bug.cgi?id=46850

Added stubs for GraphicsContext3D::getGraphicsResetStatusARB for
Mac and QT.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::getGraphicsResetStatusARB):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getGraphicsResetStatusARB):

2010-09-30 Alexey Marinichev <​amarinichev@chromium.org>

Reviewed by Chris Marrin.

Add GetGraphicsResetStatusARB entry point from ARB_robustness
extension to GraphicsContext3D
​https://bugs.webkit.org/show_bug.cgi?id=46850

Added a stub for GraphicsContext3D::getGraphicsResetStatusARB.

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3D::getGraphicsResetStatusARB):
4:17 PM Changeset in webkit [68849] by jhoneycutt@apple.com
  • 4 edits in trunk

WebKit2 on Windows should use Windows fonts for the various standard
font families
​https://bugs.webkit.org/show_bug.cgi?id=43499
<rdar://problem/8272758>

Reviewed by Adam Roben.

WebKit2:

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::WebPreferencesStore):
Use Windows fonts on Windows.

WebKitTools:

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
Use the Mac fonts for running tests. This matches DRT behavior.

4:08 PM Changeset in webkit [68848] by hclam@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Build fix. Not reviewed.

Add test expectations for Chromium.

  • platform/chromium-win/editing/execCommand/toggle-compound-styles-expected.txt: Added.
4:04 PM Changeset in webkit [68847] by hclam@chromium.org
  • 3 edits in trunk/LayoutTests

Build fix. Not reviewed.

Update test expectations for Chromium.

  • platform/chromium-linux/fast/text/international/thai-baht-space-expected.checksum:
  • platform/chromium-linux/fast/text/international/thai-baht-space-expected.png:
3:57 PM Changeset in webkit [68846] by mrowe@apple.com
  • 2 edits in tags/Safari-534.9.1/WebKit/mac

Merge r68266.

3:57 PM Changeset in webkit [68845] by mrowe@apple.com
  • 5 edits in tags/Safari-534.9.1

Versioning.

3:41 PM Changeset in webkit [68844] by beidson@apple.com
  • 3 edits in trunk/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=46774 - Add WKStringIsEqual API

Reviewed by Sam Weinig.

  • Shared/API/c/WKString.cpp:

(WKStringIsEqual):

  • Shared/API/c/WKString.h:
3:35 PM Changeset in webkit [68843] by mrowe@apple.com
  • 1 copy in tags/Safari-534.9.1

New tag.

3:24 PM Changeset in webkit [68842] by hyatt@apple.com
  • 10 edits
    4 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=46938

Reviewed by Sam Weinig.

Rewrite margin collapsing to be block-flow-aware. Eliminate a bunch of the margin functions on RenderBox in favor of a single
master function for grabbing all the margin values for a child: marginValuesForChild on RenderBlock. Introduce a new
MarginValues struct to make returning the collection of 4 margin values easy.

fast/blockflow/inline-direction-positioning.html progresses to have the correct results.
Added fast/blockflow/margin-collapse.html

WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::setCollapsedBottomMargin):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::setMaxMarginBeforeValues):
(WebCore::RenderBlock::setMaxMarginAfterValues):
(WebCore::RenderBlock::marginValuesForChild):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::MarginValues::MarginValues):
(WebCore::RenderBlock::MarginValues::positiveMarginBefore):
(WebCore::RenderBlock::MarginValues::negativeMarginBefore):
(WebCore::RenderBlock::MarginValues::positiveMarginAfter):
(WebCore::RenderBlock::MarginValues::negativeMarginAfter):
(WebCore::RenderBlock::MarginValues::setPositiveMarginBefore):
(WebCore::RenderBlock::MarginValues::setNegativeMarginBefore):
(WebCore::RenderBlock::MarginValues::setPositiveMarginAfter):
(WebCore::RenderBlock::MarginValues::setNegativeMarginAfter):
(WebCore::RenderBlock::maxPositiveMarginBefore):
(WebCore::RenderBlock::maxNegativeMarginBefore):
(WebCore::RenderBlock::maxPositiveMarginAfter):
(WebCore::RenderBlock::maxNegativeMarginAfter):
(WebCore::RenderBlock::initMaxMarginValues):
(WebCore::RenderBlock::collapsedMarginBefore):
(WebCore::RenderBlock::collapsedMarginAfter):
(WebCore::RenderBlock::MarginInfo::clearMargin):
(WebCore::RenderBlock::MarginInfo::setPositiveMargin):
(WebCore::RenderBlock::MarginInfo::setNegativeMargin):
(WebCore::RenderBlock::MarginInfo::setPositiveMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setNegativeMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setMargin):
(WebCore::RenderBlock::MarginInfo::positiveMargin):
(WebCore::RenderBlock::MarginInfo::negativeMargin):
(WebCore::RenderBlock::MarginInfo::margin):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginBeforeDefault):
(WebCore::RenderBlock::RenderBlockRareData::negativeMarginBeforeDefault):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginAfterDefault):
(WebCore::RenderBlock::RenderBlockRareData::negativeMarginAfterDefault):

  • rendering/RenderBox.h:

(WebCore::RenderBox::collapsedMarginBefore):
(WebCore::RenderBox::collapsedMarginAfter):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

LayoutTests:

  • fast/blockflow/margin-collapse.html: Added.
  • platform/mac/fast/blockflow/inline-direction-positioning-expected.checksum:
  • platform/mac/fast/blockflow/inline-direction-positioning-expected.png:
  • platform/mac/fast/blockflow/inline-direction-positioning-expected.txt:
  • platform/mac/fast/blockflow/margin-collapse-expected.checksum: Added.
  • platform/mac/fast/blockflow/margin-collapse-expected.png: Added.
  • platform/mac/fast/blockflow/margin-collapse-expected.txt: Added.
3:19 PM Changeset in webkit [68841] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-09-30 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WINCE] Fix InternetGetCookie in CookieJarWin.cpp
​https://bugs.webkit.org/show_bug.cgi?id=46929

If the InternetGetCookie fails the output size won't be set.
Set the default size to 0, so we always get the correct size
and check the return value of InternetGetCookie.

  • platform/network/win/CookieJarWin.cpp: (WebCore::cookies):
3:11 PM Changeset in webkit [68840] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2010-09-30 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed rebaseline for Qt and Windows platforms required by r68830.

  • platform/qt/editing/execCommand/toggle-compound-styles-expected.txt: Merged b elements.
  • platform/win/editing/execCommand/toggle-compound-styles-expected.txt: Ditto.
3:08 PM Changeset in webkit [68839] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-09-30 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WINCE] Use OwnPtr for HBRUSH and HPEN in GraphicsContext
​https://bugs.webkit.org/show_bug.cgi?id=46881

Also add some missing SelectObject calls.

  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::createPen): (WebCore::createBrush): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath):
3:06 PM Changeset in webkit [68838] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Build fix. Not reviewed.

Update test expectations for chromium.

  • platform/chromium/test_expectations.txt:
3:03 PM Changeset in webkit [68837] by andersca@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Add radar number to ChangeLog.

3:00 PM Changeset in webkit [68836] by andersca@apple.com
  • 3 edits in trunk/WebCore

WebCore uses the main thread to process sleep notifications
​https://bugs.webkit.org/show_bug.cgi?id=46935

Reviewed by Dan Bernstein and Darin Adler.

Rewrite the old WebCorePowerNotifier to use IOKit directly.

On Snow Leopard, set up power notifications to arrive on a dispatch queue,
so that we can handle them quickly even if the main thread is hung.

(Tiger and Leopard will still get the old behavior).

  • WebCore.xcodeproj/project.pbxproj:

Link with IOKit.

  • platform/mac/SharedTimerMac.mm:

(WebCore::PowerObserver::PowerObserver):
Initialize the IOKit machinery.

(WebCore::PowerObserver::~PowerObserver):
Tear down the IOKit notifications.

(WebCore::PowerObserver::didReceiveSystemPowerNotification):
Acknowledge the event immediately and then call the shared timer functions. On Snow Leopard, we
make sure to call the shared timer functions on the main thread.

2:55 PM Changeset in webkit [68835] by commit-queue@webkit.org
  • 5 edits in trunk

2010-09-30 James Simonsen <​simonjam@chromium.org>

Reviewed by Adam Barth.

[Web Timing] Make requestEnd equal to start of response
​https://bugs.webkit.org/show_bug.cgi?id=46302

  • fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
  • fast/dom/webtiming-expected.txt:

2010-09-30 James Simonsen <​simonjam@chromium.org>

Reviewed by Adam Barth.

[Web Timing] Make requestEnd equal to start of response
​https://bugs.webkit.org/show_bug.cgi?id=46302

  • page/Timing.cpp: (WebCore::Timing::requestEnd):
2:54 PM Changeset in webkit [68834] by xji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-30 Xiaomei Ji <​xji@chromium.org>

Unreviewed, updated test_expectations.txt

  • platform/chromium/test_expectations.txt:
2:48 PM Changeset in webkit [68833] by zmo@google.com
  • 4 edits in trunk

2010-09-30 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

fast/canvas/webgl/draw-elements-out-of-bounds.html is crashing on Snow Leopard
​https://bugs.webkit.org/show_bug.cgi?id=46870

  • platform/graphics/ANGLEWebKitBridge.cpp: (WebCore::ANGLEWebKitBridge::~ANGLEWebKitBridge): Remove ShFinalize().

2010-09-30 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

fast/canvas/webgl/draw-elements-out-of-bounds.html is crashing on Snow Leopard
​https://bugs.webkit.org/show_bug.cgi?id=46870

  • platform/mac-snowleopard/Skipped: Re-enable the test.
2:47 PM Changeset in webkit [68832] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-30 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Add a factory function which returns an instance wrapped in PlatformRefPtr.
​https://bugs.webkit.org/show_bug.cgi?id=46373

A Brew MP instance has reference count 1 when it is created, so call adoptPlatformRef
to wrap the instance in PlatformRefPtr.

  • wtf/brew/ShellBrew.h: (WTF::createRefPtrInstance):
2:43 PM Changeset in webkit [68831] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

-[DOMDocument _documentRange] throws an exception if there is no document element
​https://bugs.webkit.org/show_bug.cgi?id=46934
<rdar://problem/8169260>

Reviewed by Darin Adler.

If there is no document element, just return an empty range. Otherwise we'll try to call
Range::selectNode with a null Node which will throw a NOT_FOUND exception.

  • DOM/WebDOMOperations.mm:

(-[DOMDocument _documentRange]):

2:37 PM Changeset in webkit [68830] by rniwa@webkit.org
  • 12 edits
    3 adds in trunk

2010-09-30 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

WebKit nests font element when applying different font styles
​https://bugs.webkit.org/show_bug.cgi?id=45568

The bug was caused by fixRangeAndApplyInlineStyle's not including fully selected ancestors,
and addInlineStyleIfNeeded's always surrounding the contents by new elements as supposed to
adding font attributes or style attribute.

Fixed the bug by extending the node range in fixRangeAndApplyInlineStyle and finding
the appropriate container node to add attributes in addInlineStyleIfNeeded.
addInlineStyleIfNeeded now tires to add font and style attributes to the inner most font and
span elements respectively.

Also added an early exit check to removeStyleFromRunBeforeApplyingStyle so that WebKit does not
modify the contents when the entire contents already have the desired style.

Test: editing/style/inline-style-container.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):

2010-09-30 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

WebKit nests font element when applying different font styles
​https://bugs.webkit.org/show_bug.cgi?id=45568

Added a test to ensure WebKit does not add extra font elements when the content already has an enclosing font element.
The test also ensures WebKit tries to add style attribute to the inner most span.

  • editing/execCommand/createLink-expected.txt: The ordering of anchor and span changed.
  • editing/execCommand/unlink-expected.txt: Ditto.
  • editing/execCommand/query-font-size-expected.txt: Merged font elements.
  • editing/execCommand/script-tests/toggle-style-2.js: The ordering of s and u elements changed.
  • editing/execCommand/toggle-style-2-expected.txt: Ditto.
  • editing/style/inline-style-container-expected.txt: Added.
  • editing/style/inline-style-container.html: Added.
  • editing/style/make-text-writing-direction-inline-expected.txt: Removed some extraneous spans added by the bug 44359.
  • editing/style/script-tests/inline-style-container.js: Added. (testSingleToggle):
  • editing/style/style-3690704-fix-expected.txt: Merged two b elements.
  • fast/events/event-input-contentEditable-expected.txt: Merged anchor elements.
  • fast/events/script-tests/event-input-contentEditable-expected.txt: Ditto.
2:34 PM Changeset in webkit [68829] by hclam@chromium.org
  • 1 edit
    14 deletes in trunk/LayoutTests

Build fix. Not reviewed.

Remove expectation files in wrong place.

  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-actual.png: Removed.
2:33 PM Changeset in webkit [68828] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/JavaScriptCore

2010-09-30 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Port PlatformRefPtr
​https://bugs.webkit.org/show_bug.cgi?id=46370

Implement refPlatformPtr and derefPlatformPtr to use PlatformRefPtr in Brew MP.

  • wtf/brew/RefPtrBrew.h: Added. (WTF::refPlatformPtr): (WTF::derefPlatformPtr):
2:29 PM Changeset in webkit [68827] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-30 Adam Barth <​abarth@webkit.org>

Third attempt. We need a better integration test environment.

  • Scripts/webkitpy/common/net/failuremap.py:
  • Scripts/webkitpy/common/net/failuremap_unittest.py:
2:25 PM Changeset in webkit [68826] by hclam@chromium.org
  • 1 edit
    42 moves
    14 adds in trunk/LayoutTests

Build fix. Not reviewed.

Rename test expectations last submitted.

  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-actual.png.
2:22 PM Changeset in webkit [68825] by robert@webkit.org
  • 9 edits
    2 adds in trunk

2010-09-30 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Support for PlainTextController

Unskip editing/text-iterator/basic-iteration.html

​https://bugs.webkit.org/show_bug.cgi?id=38805

  • platform/qt/Skipped:

2010-09-30 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Support for PlainTextController

Unskip editing/text-iterator/basic-iteration.html

​https://bugs.webkit.org/show_bug.cgi?id=38805

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::plainText):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-09-30 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Support for PlainTextController

Unskip editing/text-iterator/basic-iteration.html

​https://bugs.webkit.org/show_bug.cgi?id=38805

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::initJSObjects):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/PlainTextControllerQt.cpp: Added. (PlainTextController::PlainTextController): (PlainTextController::plainText):
  • DumpRenderTree/qt/PlainTextControllerQt.h: Added.
2:20 PM Changeset in webkit [68824] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-30 Jarred Nicholls <​jarred@sencha.com>

Reviewed by Darin Adler.

Removed unnecessary calls to ceil() on an int
Removing the call fixes MSVC build errors
​https://bugs.webkit.org/show_bug.cgi?id=46931

  • platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::calculateLayerBoundingRect):
2:17 PM Changeset in webkit [68823] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-30 Adam Barth <​abarth@webkit.org>

Unreviewed. Second attempt to fix sheriffbot.

  • Scripts/webkitpy/common/net/buildbot.py:
2:12 PM Changeset in webkit [68822] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-30 Adam Barth <​abarth@webkit.org>

Unreviewed.

This patch should stop the sheriffbot from throwing an exception.

  • Scripts/webkitpy/common/net/buildbot.py:
1:48 PM Changeset in webkit [68821] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-09-30 Martin Robinson <​mrobinson@igalia.com>

Unskip websocket tests for GTK+, as the bots should be running
a version of the Linux kernel which has support for SOCK_CLOEXEC.

  • platform/gtk/Skipped: Unskip websocket tests.
1:37 PM Changeset in webkit [68820] by hyatt@apple.com
  • 3 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=46932

Reviewed by Beth Dakin.

Get fast/blockflow/root-lr-basic.html results to be correct by patching a few more
height() calls to be logicalHeight().

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::handleAfterSideOfBlock):

1:31 PM Changeset in webkit [68819] by jschuh@chromium.org
  • 5 edits
    2 adds in trunk

2010-09-30 Cris Neckar <​cdn@chromium.org>

Reviewed by Darin Adler.

Added check to test for removed counter node when calling findPlaceForCounter() in updateCounters().
Added refcounting to counternodes in countermaps.
​https://bugs.webkit.org/show_bug.cgi?id=46387

Test: fast/css/counters/counter-traverse-table-cell.html

  • rendering/CounterNode.cpp: (WebCore::CounterNode::create):
  • rendering/CounterNode.h:
  • rendering/RenderCounter.cpp: (WebCore::makeCounterNode): (WebCore::destroyCounterNodeWithoutMapRemoval): (WebCore::RenderCounter::destroyCounterNodes): (WebCore::RenderCounter::destroyCounterNode): (WebCore::updateCounters):

2010-09-30 Cris Neckar <​cdn@chromium.org>

Reviewed by Darin Adler.

Tests for crash in counter nodes when traversing table cells.
​https://bugs.webkit.org/show_bug.cgi?id=46387

  • fast/css/counters/counter-traverse-table-cell-expected.txt: Added.
  • fast/css/counters/counter-traverse-table-cell.html: Added.
1:01 PM Changeset in webkit [68818] by dumi@chromium.org
  • 3 edits in trunk/WebKit/chromium

Remove WebHTTPBody::appendFileRange(..., const WebFileInfo&).

Reviewed by Darin Fisher.

  • public/WebHTTPBody.h:
  • src/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::elementAt):

1:01 PM Changeset in webkit [68817] by hyatt@apple.com
  • 36 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46928

Reviewed by Beth Dakin.

Add isLeftToRightDirection() to RenderStyle and change callers that did direction() == LTR and direction() == RTL to use this instead.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::isLeftPage):
(WebCore::CSSStyleSelector::applyProperty):

  • editing/Editor.cpp:

(WebCore::Editor::hasBidiSelection):

  • editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
(WebCore::VisiblePosition::rightVisuallyDistinctCandidate):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal):

  • rendering/InlineBox.h:

(WebCore::InlineBox::isLeftToRightDirection):
(WebCore::InlineBox::caretLeftmostOffset):
(WebCore::InlineBox::caretRightmostOffset):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
(WebCore::InlineFlowBox::paintTextDecorations):

  • rendering/InlineIterator.h:

(WebCore::InlineIterator::direction):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::placeEllipsisBox):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::textPos):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::getHorizontalSelectionGapInfo):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::layoutColumns):
(WebCore::getBorderPaddingMargin):
(WebCore::RenderBlock::localCaretRect):
(WebCore::RenderBlock::marginStartForChild):
(WebCore::RenderBlock::marginEndForChild):
(WebCore::RenderBlock::setMarginStartForChild):
(WebCore::RenderBlock::setMarginEndForChild):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::getBorderPaddingMargin):
(WebCore::RenderBlock::constructLine):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::skipTrailingWhitespace):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::findNextLineBreak):
(WebCore::RenderBlock::checkLinesForTextOverflow):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginEnd):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::containingBlockWidthForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::localCaretRect):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::relativePositionOffsetX):

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::layoutLegend):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::FlexBoxIterator::FlexBoxIterator):
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::computeScrollDimensions):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintItemForeground):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::positionListMarker):
(WebCore::RenderListItem::markerTextWithSuffix):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::paint):
(WebCore::RenderListMarker::updateMargins):
(WebCore::RenderListMarker::suffix):

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::computePosition):

  • rendering/RenderMeter.cpp:

(WebCore::RenderMeter::valuePartRect):

  • rendering/RenderProgress.cpp:

(WebCore::RenderProgress::valuePartRect):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::calcBorderLeft):
(WebCore::RenderTable::calcBorderRight):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::borderHalfLeft):
(WebCore::RenderTableCell::borderHalfRight):
(WebCore::RenderTableCell::collectBorderStyles):
(WebCore::RenderTableCell::paintCollapsedBorder):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::recalcOuterBorder):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::nodeAtPoint):

  • rendering/RenderText.cpp:

(WebCore::RenderText::localCaretRect):
(WebCore::RenderText::positionLineBox):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::forwardEvent):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::levelIndicatorFor):
(WebCore::RenderThemeMac::paintProgressBar):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeTextRun):

  • rendering/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::measureCharacter):
(WebCore::SVGInlineTextBox::buildLayoutInformation):

  • rendering/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGInlineTextBox):

  • rendering/SVGTextLayoutUtilities.cpp:

(WebCore::svgTextRunForInlineTextBox):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::borderStartWidth):
(WebCore::RenderStyle::borderEndWidth):
(WebCore::RenderStyle::marginStart):
(WebCore::RenderStyle::marginEnd):
(WebCore::RenderStyle::marginStartUsing):
(WebCore::RenderStyle::marginEndUsing):
(WebCore::RenderStyle::paddingStart):
(WebCore::RenderStyle::paddingEnd):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::isLeftToRightDirection):

  • wml/WMLTableElement.cpp:

(WebCore::WMLTableElement::alignCells):

12:35 PM Changeset in webkit [68816] by hclam@chromium.org
  • 1 edit
    56 adds in trunk/LayoutTests

done

12:27 PM Changeset in webkit [68815] by bweinstein@apple.com
  • 2 edits in trunk/WebKitTools

The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
​https://bugs.webkit.org/show_bug.cgi?id=46926

Reviewed by Adam Roben.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows

Release Tests, and two bots running Windows Debug Tests, instead of four running both.

11:54 AM Changeset in webkit [68814] by hyatt@apple.com
  • 4 edits
    4 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=46923

Reviewed by Simon Fraser.

Make determineLogicalLeftPositionForChild block-flow-aware. Rewrite the function so that there aren't
completely separate LTR/RTL cases.

Added fast/blockflow/inline-direction-positioning.html

WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::setLogicalLeftForChild):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalWidthForChild):
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):

LayoutTests:

  • fast/blockflow/inline-direction-positioning.html: Added.
  • platform/mac/fast/blockflow/inline-direction-positioning-expected.checksum: Added.
  • platform/mac/fast/blockflow/inline-direction-positioning-expected.png: Added.
  • platform/mac/fast/blockflow/inline-direction-positioning-expected.txt: Added.
11:50 AM Changeset in webkit [68813] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-30 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch find-flaky-tests should print results URLs
​https://bugs.webkit.org/show_bug.cgi?id=46917

Printing out the results URL makes find-flaky-tests more actionable
because you can see what happens when a test fails. The output from
the script is still pretty noisy, but it seems useful.

  • Scripts/webkitpy/tool/commands/queries.py:
11:50 AM Changeset in webkit [68812] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Add additional checks to StringBuffer.
<rdar://problem/7756381>

Reviewed by Darin Adler.

  • wtf/text/StringBuffer.h:

(WTF::StringBuffer::StringBuffer):
(WTF::StringBuffer::resize):

11:42 AM Changeset in webkit [68811] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Forward declare structs with 'struct' in the message headers
​https://bugs.webkit.org/show_bug.cgi?id=46925
<rdar://problem/8497940>

Reviewed by Adam Roben.

  • Scripts/webkit2/messages.py:

(struct_or_class): New function which given a type and a namespace returns the correct
forward declaration syntax (struct or class).

  • Scripts/webkit2/messages_unittest.py:

Update expected results.

11:32 AM Changeset in webkit [68810] by thakis@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-30 Nico Weber <​thakis@chromium.org>

Reviewed by Adam Barth.

[chromium] Fix clang error in KURLTest.cpp
​https://bugs.webkit.org/show_bug.cgi?id=46861

  • tests/KURLTest.cpp: (WTF::operator<<):
11:28 AM Changeset in webkit [68809] by Adam Roben
  • 3 edits
    2 adds in trunk

Fix color media queries on Windows

Fixes <​http://webkit.org/b/42973> <rdar://problem/8234072> (color:8)
media query does not evaluate to true for 32bpp displays on Windows

Test: fast/media/color-does-not-include-alpha.html

Reviewed by Darin Adler.

WebCore:

  • platform/win/PlatformScreenWin.cpp:

(WebCore::screenDepthPerComponent): Use screenDepth instead of trying
to interpret DEVMODE directly, since screenDepth knows how to correct
for video drivers that return 32 instead of 24.

LayoutTests:

Add test for color:8 media queries

  • fast/media/color-does-not-include-alpha-expected.txt: Added.
  • fast/media/color-does-not-include-alpha.html: Added.
11:27 AM Changeset in webkit [68808] by Adam Roben
  • 5 edits in trunk

Make sure screen.colorDepth/screen.pixelDepth don't include the bits used for alpha

Fixes <​http://webkit.org/b/42972> <rdar://problem/8234071>
screen.colorDepth and screen.pixelDepth return 32 on Windows, but
should return 24 (according to CSSOM View and Firefox)

Reviewed by Darin Adler.

WebCore:

  • platform/win/PlatformScreenWin.cpp:

(WebCore::screenDepth): If Windows says there are 32 bits per pixel,
return 24 instead, as 32 includes the alpha component but this
function is supposed to ignore the alpha component.

LayoutTests:

Update screen.colorDepth/screen.pixelDepth test to not allow values
that contain bits for alpha

  • fast/dom/Window/window-screen-properties-expected.txt: Updated

results.

  • fast/dom/Window/window-screen-properties.html: Changed only to

expect 16 or 24.

11:20 AM Changeset in webkit [68807] by commit-queue@webkit.org
  • 15 edits in trunk

2010-09-30 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Refactor ChromiumDataObject to use getters/setters.
​https://bugs.webkit.org/show_bug.cgi?id=46559

This is an intermediate step to converting ChromiumDataObject to use
callbacks to the browser to retrieve data.

This is covered by existing tests.

  • editing/chromium/EditorChromium.cpp: (WebCore::Editor::newGeneralClipboard):
  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::clearData): (WebCore::ChromiumDataObject::clearAll): (WebCore::ChromiumDataObject::clearAllExceptFiles): (WebCore::ChromiumDataObject::hasData): (WebCore::ChromiumDataObject::types): (WebCore::ChromiumDataObject::getData): (WebCore::ChromiumDataObject::setData): (WebCore::ChromiumDataObject::ChromiumDataObject):
  • platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::create): (WebCore::ChromiumDataObject::urlTitle): (WebCore::ChromiumDataObject::setUrlTitle): (WebCore::ChromiumDataObject::htmlBaseUrl): (WebCore::ChromiumDataObject::setHtmlBaseUrl): (WebCore::ChromiumDataObject::containsFilenames): (WebCore::ChromiumDataObject::filenames): (WebCore::ChromiumDataObject::setFilenames): (WebCore::ChromiumDataObject::fileExtension): (WebCore::ChromiumDataObject::setFileExtension): (WebCore::ChromiumDataObject::fileContentFilename): (WebCore::ChromiumDataObject::setFileContentFilename): (WebCore::ChromiumDataObject::fileContent): (WebCore::ChromiumDataObject::setFileContent):
  • platform/chromium/ClipboardChromium.cpp: (WebCore::normalizeType): (WebCore::ClipboardChromium::clearData): (WebCore::ClipboardChromium::clearAllData): (WebCore::ClipboardChromium::getData): (WebCore::ClipboardChromium::setData): (WebCore::ClipboardChromium::types): (WebCore::ClipboardChromium::files): (WebCore::writeImageToDataObject): (WebCore::ClipboardChromium::declareAndWriteDragImage): (WebCore::ClipboardChromium::writeURL): (WebCore::ClipboardChromium::writeRange): (WebCore::ClipboardChromium::writePlainText):
  • platform/chromium/ClipboardChromiumWin.cpp: (WebCore::ClipboardChromium::validateFileName):
  • platform/chromium/ClipboardMimeTypes.cpp:
  • platform/chromium/ClipboardMimeTypes.h:
  • platform/chromium/DragDataChromium.cpp: (WebCore::containsHTML): (WebCore::DragData::containsURL): (WebCore::DragData::asURL): (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::canSmartReplace): (WebCore::DragData::asFragment):
  • platform/chromium/ReadableDataObject.cpp: (WebCore::ReadableDataObject::getURL): (WebCore::ReadableDataObject::getHTML):
  • platform/chromium/WritableDataObject.cpp: (WebCore::WritableDataObject::clearData): (WebCore::WritableDataObject::setData): (WebCore::WritableDataObject::setURL): (WebCore::WritableDataObject::setHTML):

2010-09-30 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Refactor ChromiumDataObject to use getters/setters.
​https://bugs.webkit.org/show_bug.cgi?id=46559

This is an intermediate step to converting ChromiumDataObject to use
callbacks to the browser to retrieve data.

  • public/WebDragData.h:
  • src/WebDragData.cpp: (WebKit::WebDragData::initialize): (WebKit::WebDragData::url): (WebKit::WebDragData::setURL): (WebKit::WebDragData::urlTitle): (WebKit::WebDragData::setURLTitle): (WebKit::WebDragData::downloadMetadata): (WebKit::WebDragData::setDownloadMetadata): (WebKit::WebDragData::fileExtension): (WebKit::WebDragData::setFileExtension): (WebKit::WebDragData::hasFileNames): (WebKit::WebDragData::fileNames): (WebKit::WebDragData::setFileNames): (WebKit::WebDragData::appendToFileNames): (WebKit::WebDragData::plainText): (WebKit::WebDragData::setPlainText): (WebKit::WebDragData::htmlText): (WebKit::WebDragData::setHTMLText): (WebKit::WebDragData::htmlBaseURL): (WebKit::WebDragData::setHTMLBaseURL): (WebKit::WebDragData::fileContentFileName): (WebKit::WebDragData::setFileContentFileName): (WebKit::WebDragData::fileContent): (WebKit::WebDragData::setFileContent):
11:12 AM Changeset in webkit [68806] by zmo@google.com
  • 5 edits
    81 adds in trunk

2010-09-29 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

glsl-conformance.html on khronos will crash chromium --in-process-webgl
​https://bugs.webkit.org/show_bug.cgi?id=46863

  • src/WebGraphicsContext3DDefaultImpl.cpp: Make ShaderSourceMap as <ShaderID, ShaderSourceEntry*>, so map resizing will be efficient and we don't need to worry about pointer copying. (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::compileShader): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderiv): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::shaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::createShader): (WebKit::WebGraphicsContext3DDefaultImpl::deleteShader):
  • src/WebGraphicsContext3DDefaultImpl.h: Ditto. (WebKit::WebGraphicsContext3DDefaultImpl::ShaderSourceEntry::ShaderSourceEntry):

2010-09-29 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

glsl-conformance.html on khronos will crash chromium --in-process-webgl
​https://bugs.webkit.org/show_bug.cgi?id=46863

  • fast/canvas/webgl/glsl-conformance-expected.txt: Added.
  • fast/canvas/webgl/glsl-conformance.html: Added.
  • fast/canvas/webgl/resources/webgl-test-utils.js: Add a function to turn off console output. (WebGLTestUtils.): (WebGLTestUtils):
  • fast/canvas/webgl/shaders: Added.
  • fast/canvas/webgl/shaders/00_shaders.txt: Added.
  • fast/canvas/webgl/shaders/implicit: Added.
  • fast/canvas/webgl/shaders/implicit/00_shaders.txt: Added.
  • fast/canvas/webgl/shaders/implicit/add_int_float.vert: Added.
  • fast/canvas/webgl/shaders/implicit/add_int_mat2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/add_int_mat3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/add_int_mat4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/add_int_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/add_int_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/add_int_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/add_ivec2_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/add_ivec3_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/add_ivec4_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/assign_int_to_float.vert: Added.
  • fast/canvas/webgl/shaders/implicit/assign_ivec2_to_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/assign_ivec3_to_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/assign_ivec4_to_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/construct_struct.vert: Added.
  • fast/canvas/webgl/shaders/implicit/divide_int_float.vert: Added.
  • fast/canvas/webgl/shaders/implicit/divide_int_mat2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/divide_int_mat3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/divide_int_mat4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/divide_int_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/divide_int_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/divide_int_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/divide_ivec2_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/divide_ivec3_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/divide_ivec4_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/equal_int_float.vert: Added.
  • fast/canvas/webgl/shaders/implicit/equal_ivec2_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/equal_ivec3_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/equal_ivec4_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/function_int_float.vert: Added.
  • fast/canvas/webgl/shaders/implicit/function_ivec2_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/function_ivec3_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/function_ivec4_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/greater_than.vert: Added.
  • fast/canvas/webgl/shaders/implicit/greater_than_equal.vert: Added.
  • fast/canvas/webgl/shaders/implicit/less_than.vert: Added.
  • fast/canvas/webgl/shaders/implicit/less_than_equal.vert: Added.
  • fast/canvas/webgl/shaders/implicit/multiply_int_float.vert: Added.
  • fast/canvas/webgl/shaders/implicit/multiply_int_mat2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/multiply_int_mat3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/multiply_int_mat4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/multiply_int_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/multiply_int_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/multiply_int_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/multiply_ivec2_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/multiply_ivec3_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/multiply_ivec4_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/not_equal_int_float.vert: Added.
  • fast/canvas/webgl/shaders/implicit/not_equal_ivec2_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/not_equal_ivec3_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/not_equal_ivec4_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/subtract_int_float.vert: Added.
  • fast/canvas/webgl/shaders/implicit/subtract_int_mat2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/subtract_int_mat3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/subtract_int_mat4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/subtract_int_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/subtract_int_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/subtract_int_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/subtract_ivec2_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/subtract_ivec3_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/subtract_ivec4_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/ternary_int_float.vert: Added.
  • fast/canvas/webgl/shaders/implicit/ternary_ivec2_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/ternary_ivec3_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/ternary_ivec4_vec4.vert: Added.
  • fast/canvas/webgl/shaders/reserved: Added.
  • fast/canvas/webgl/shaders/reserved/00_shaders.txt: Added.
  • fast/canvas/webgl/shaders/reserved/_webgl_field.vert: Added.
  • fast/canvas/webgl/shaders/reserved/_webgl_function.vert: Added.
  • fast/canvas/webgl/shaders/reserved/_webgl_struct.vert: Added.
  • fast/canvas/webgl/shaders/reserved/_webgl_variable.vert: Added.
  • fast/canvas/webgl/shaders/reserved/webgl_field.vert: Added.
  • fast/canvas/webgl/shaders/reserved/webgl_function.vert: Added.
  • fast/canvas/webgl/shaders/reserved/webgl_struct.vert: Added.
  • fast/canvas/webgl/shaders/reserved/webgl_variable.vert: Added.
11:04 AM Changeset in webkit [68805] by Adam Roben
  • 2 edits in trunk/LayoutTests

Add some tests to the Windows Skipped list

These all have bugs filed about them.

  • platform/win/Skipped:
10:59 AM Changeset in webkit [68804] by cmarrin@apple.com
  • 1 edit in trunk/WebCore/platform/graphics/gpu/DrawingBuffer.h

Fixed chrome build issue in DrawingBuffer.h

10:57 AM Changeset in webkit [68803] by andreip@google.com
  • 3 edits in trunk/WebKit/chromium

2010-09-30 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

[Chromium] WebIDBDatabase and WebIDBObjectStore are missing methods called from Chromium land.
​https://bugs.webkit.org/show_bug.cgi?id=46922

The missing functions were removed in r68795.

  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::createObjectStore): (WebKit::WebIDBDatabase::removeObjectStore):
  • public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::createIndex): (WebKit::WebIDBObjectStore::removeIndex):
10:43 AM Changeset in webkit [68802] by cmarrin@apple.com
  • 21 edits
    2 adds in trunk

2010-09-30 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

Make 2D accelerated canvas rendering build on Mac
​https://bugs.webkit.org/show_bug.cgi?id=46007

Add accelerated 2D rendering files to Mac build, fix build errors,
add ifdefs to compile only when the ACCELERATED_2D_CANVAS flag is
enabled, and add a skeleton of the mac specific file so it builds.

DrawingBufferMac.mm, the Mac specific file does nothing right now
other than initialize and create a layer. The rest will be added
when I do the actual implementation.

The most significant change was to SharedGraphicsContext3D, which
had a static local OwnPtr in one of the methods. This was causing
the exit time destructor warning. Getting rid of the OwnPtr fixed
the problem. Since the pointer that was being wrapped was to a
static object that would never get destroyed, the OwnPtr was not
necessary.

I also added the ACCELERATED_2D_CANVAS flag to build-webkit
and FeatureDefines.xcconfig for WebCore, WebKit and JavaScriptCore.
But right now the flag is off by default.

10:36 AM Changeset in webkit [68801] by kbr@google.com
  • 11 edits in trunk

2010-09-29 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

[chromium] Add accelerated compositing support to DumpRenderTree and test_shell
​https://bugs.webkit.org/show_bug.cgi?id=46849

Added offscreen code path for WebGraphicsContext3DDefaultImpl which
works with the compositor integration in both DumpRenderTree and
test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
and thereby trigger the compositor's readback code path. Added support
for --enable-accelerated-compositing to DumpRenderTree.

Tested in both test_shell and DumpRenderTree on Linux, the latter by
modifying a compositing layout test, dumping the pixels and verifying
that they matched the output when the compositor was active.

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::resolveMultisampledFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::getPlatformTextureId): (WebKit::WebGraphicsContext3DDefaultImpl::prepareTexture): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::copyTexImage2D): (WebKit::WebGraphicsContext3DDefaultImpl::copyTexSubImage2D): (WebKit::WebGraphicsContext3DDefaultImpl::readPixels):
  • src/WebGraphicsContext3DDefaultImpl.h:

2010-09-29 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

[chromium] Add accelerated compositing support to DumpRenderTree and test_shell
​https://bugs.webkit.org/show_bug.cgi?id=46849

Added offscreen code path for WebGraphicsContext3DDefaultImpl which
works with the compositor integration in both DumpRenderTree and
test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
and thereby trigger the compositor's readback code path. Added support
for --enable-accelerated-compositing to DumpRenderTree.

Tested in both test_shell and DumpRenderTree on Linux, the latter by
modifying a compositing layout test, dumping the pixels and verifying
that they matched the output when the compositor was active.

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::resetWebSettings):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::setAcceleratedCompositingEnabled):
  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo):
  • DumpRenderTree/chromium/WebPreferences.h:
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::scheduleComposite):
  • DumpRenderTree/chromium/WebViewHost.h:
10:35 AM Changeset in webkit [68800] by kevino@webkit.org
  • 2 edits in trunk

[wx] Fix typo in build script.

10:35 AM Changeset in webkit [68799] by kevino@webkit.org
  • 2 edits in trunk/JavaScriptCore

[wx] wxMSW build fix. Make sure we copy the compiler flags and remove exception handling from
the copy so as not to alter global settings.

10:23 AM Changeset in webkit [68798] by Adam Roben
  • 3 edits in trunk/LayoutTests

Make Windows match the Mac fallback font for the hyphen character in two tests

Fixes <​http://webkit.org/b/46909> <rdar://problem/8497214> REGRESSION
(r68551): fast/text/midword-break-after-breakable-char.html and
fast/text/basic/014.html are failing on Windows

Rubber-stamped by Dan Bernstein.

  • fast/text/basic/014.html:
  • fast/text/midword-break-after-breakable-char.html:

Added a little @font-face magic to force the font for the hyphen
character.

10:21 AM Changeset in webkit [68797] by commit-queue@webkit.org
  • 4 edits
    70 adds in trunk

2010-09-30 Renata Hodovan <​reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

SVGFECompositeElement doesn't support dynamic invalidation, when attributes change.
​https://bugs.webkit.org/show_bug.cgi?id=46902

Adding layout tests for feComposite dynamic changes.

  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-in-attr.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-in-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-in2-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-k1-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-k2-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-k3-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-k4-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-operator-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-in-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-in2-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-k1-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-k2-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-k3-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-k4-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-operator-prop.js: Added. (executeTest):

2010-09-30 Renata Hodovan <​reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

SVGFECompositeElement doesn't support dynamic invalidation, when attributes change.
​https://bugs.webkit.org/show_bug.cgi?id=46902

Tests: svg/dynamic-updates/SVGFECompositeElement-dom-in-attr.html

svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop.html

  • svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::svgAttributeChanged):
  • svg/SVGFECompositeElement.h:
10:16 AM Changeset in webkit [68796] by mitz@apple.com
  • 3 edits in trunk/WebKit/mac

Add printing SPI allowing full control over shrink-to-fit
​https://bugs.webkit.org/show_bug.cgi?id=46877

Reviewed by John Sullivan.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): Added.

  • WebView/WebHTMLViewPrivate.h:
9:55 AM Changeset in webkit [68795] by jorlow@chromium.org
  • 79 edits in trunk

2010-09-29 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Finished IDBTransaction for IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=46823

A bit of cleanup + use setVersion transactions for all of our work.

  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/transaction-basics.html:

2010-09-29 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Finished IDBTransaction for IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=46823

Switch the rest of IndexedDB to use transactions.
Implement most of setVersion.
Add IDBTransactions to IDBAny, IDBCursor, IDBRequest, etc.
Switch to using the standard cross thread task stuff.
Make everything threadsafe so it works with cross thread copy

(will be useful in the future).

Fix some subtle bugs in transactions.

Various bits of clean up (when I couldn't resist).

  • bindings/js/JSIDBAnyCustom.cpp: (WebCore::toJS):
  • bindings/v8/IDBBindingUtilities.cpp: (WebCore::LocalContext::LocalContext): (WebCore::LocalContext::~LocalContext): (WebCore::createIDBKeyFromSerializedValueAndKeyPath):
  • bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::release): (WebCore::SerializedScriptValue::SerializedScriptValue):
  • bindings/v8/SerializedScriptValue.h:
  • bindings/v8/custom/V8IDBAnyCustom.cpp: (WebCore::toV8):
  • platform/CrossThreadCopier.cpp:
  • storage/IDBAny.cpp: (WebCore::IDBAny::idbFactory): (WebCore::IDBAny::idbTransaction): (WebCore::IDBAny::set):
  • storage/IDBAny.h:
  • storage/IDBCallbacks.h:
  • storage/IDBCursor.cpp: (WebCore::IDBCursor::IDBCursor): (WebCore::IDBCursor::update): (WebCore::IDBCursor::continueFunction): (WebCore::IDBCursor::remove):
  • storage/IDBCursor.h: (WebCore::IDBCursor::create):
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::update): (WebCore::IDBCursorBackendImpl::updateInternal): (WebCore::IDBCursorBackendImpl::continueFunction): (WebCore::IDBCursorBackendImpl::continueFunctionInternal): (WebCore::IDBCursorBackendImpl::remove): (WebCore::IDBCursorBackendImpl::removeInternal):
  • storage/IDBCursorBackendImpl.h: (WebCore::IDBCursorBackendImpl::create):
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setSetVersionTransaction): (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::removeObjectStore): (WebCore::IDBDatabase::setVersion): (WebCore::IDBDatabase::close):
  • storage/IDBDatabase.h:
  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal): (WebCore::IDBDatabaseBackendImpl::removeObjectStore): (WebCore::IDBDatabaseBackendImpl::removeObjectStoreInternal): (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::setVersionInternal): (WebCore::IDBDatabaseBackendImpl::close):
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBFactory.cpp: (WebCore::IDBFactory::open):
  • storage/IDBIndex.cpp: (WebCore::IDBIndex::IDBIndex): (WebCore::IDBIndex::openObjectCursor): (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::getObject): (WebCore::IDBIndex::get):
  • storage/IDBIndex.h: (WebCore::IDBIndex::create):
  • storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::openCursorInternal): (WebCore::IDBIndexBackendImpl::openObjectCursor): (WebCore::IDBIndexBackendImpl::openCursor): (WebCore::IDBIndexBackendImpl::getInternal): (WebCore::IDBIndexBackendImpl::getObject): (WebCore::IDBIndexBackendImpl::get):
  • storage/IDBIndexBackendImpl.h:
  • storage/IDBIndexBackendInterface.h:
  • storage/IDBKey.cpp: (WebCore::IDBKey::IDBKey):
  • storage/IDBKey.h:
  • storage/IDBKeyRange.h:
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::IDBObjectStore): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::remove): (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::index): (WebCore::IDBObjectStore::removeIndex): (WebCore::IDBObjectStore::openCursor):
  • storage/IDBObjectStore.idl:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::get): (WebCore::IDBObjectStoreBackendImpl::getInternal): (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::putInternal): (WebCore::IDBObjectStoreBackendImpl::remove): (WebCore::IDBObjectStoreBackendImpl::removeInternal): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::createIndexInternal): (WebCore::IDBObjectStoreBackendImpl::removeIndex): (WebCore::IDBObjectStoreBackendImpl::removeIndexInternal): (WebCore::IDBObjectStoreBackendImpl::openCursor): (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
  • storage/IDBObjectStoreBackendImpl.h:
  • storage/IDBObjectStoreBackendInterface.h:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::resetReadyState): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::timerFired):
  • storage/IDBRequest.h: (WebCore::IDBRequest::create):
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl): (WebCore::IDBTransactionBackendImpl::scheduleTask): (WebCore::IDBTransactionBackendImpl::didCompleteTaskEvents): (WebCore::IDBTransactionBackendImpl::run): (WebCore::IDBTransactionBackendImpl::start): (WebCore::IDBTransactionBackendImpl::commit): (WebCore::IDBTransactionBackendImpl::timerFired):
  • storage/IDBTransactionBackendImpl.h:

2010-09-29 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Steve Block.

Finished IDBTransaction for IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=46823

Plumbing.

  • public/WebIDBCallbacks.h: (WebKit::WebIDBCallbacks::onSuccess):
  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::createObjectStore): (WebKit::WebIDBDatabase::removeObjectStore): (WebKit::WebIDBDatabase::close):
  • public/WebIDBIndex.h: (WebKit::WebIDBIndex::openObjectCursor): (WebKit::WebIDBIndex::openCursor): (WebKit::WebIDBIndex::getObject): (WebKit::WebIDBIndex::get):
  • public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::get): (WebKit::WebIDBObjectStore::put): (WebKit::WebIDBObjectStore::remove): (WebKit::WebIDBObjectStore::createIndex): (WebKit::WebIDBObjectStore::removeIndex): (WebKit::WebIDBObjectStore::openCursor):
  • public/WebIDBTransaction.h: (WebKit::WebIDBTransaction::id): (WebKit::WebIDBTransaction::getIDBTransactionBackendInterface):
  • src/IDBCallbacksProxy.cpp: (WebCore::IDBCallbacksProxy::onSuccess):
  • src/IDBCallbacksProxy.h:
  • src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::createObjectStore): (WebCore::IDBDatabaseProxy::removeObjectStore): (WebCore::IDBDatabaseProxy::close):
  • src/IDBDatabaseProxy.h:
  • src/IDBIndexBackendProxy.cpp: (WebCore::IDBIndexBackendProxy::openObjectCursor): (WebCore::IDBIndexBackendProxy::openCursor): (WebCore::IDBIndexBackendProxy::getObject): (WebCore::IDBIndexBackendProxy::get):
  • src/IDBIndexBackendProxy.h:
  • src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::put): (WebCore::IDBObjectStoreProxy::remove): (WebCore::IDBObjectStoreProxy::createIndex): (WebCore::IDBObjectStoreProxy::removeIndex): (WebCore::IDBObjectStoreProxy::openCursor):
  • src/IDBObjectStoreProxy.h:
  • src/IDBTransactionBackendProxy.cpp: (WebCore::IDBTransactionBackendProxy::IDBTransactionBackendProxy):
  • src/WebIDBCallbacksImpl.cpp: (WebCore::WebIDBCallbacksImpl::onSuccess):
  • src/WebIDBCallbacksImpl.h:
  • src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::createObjectStore): (WebKit::WebIDBDatabaseImpl::removeObjectStore): (WebKit::WebIDBDatabaseImpl::close):
  • src/WebIDBDatabaseImpl.h:
  • src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::openCursor): (WebKit::WebIDBIndexImpl::openObjectCursor): (WebKit::WebIDBIndexImpl::getObject): (WebKit::WebIDBIndexImpl::get):
  • src/WebIDBIndexImpl.h:
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::put): (WebKit::WebIDBObjectStoreImpl::remove): (WebKit::WebIDBObjectStoreImpl::createIndex): (WebKit::WebIDBObjectStoreImpl::removeIndex): (WebKit::WebIDBObjectStoreImpl::openCursor):
  • src/WebIDBObjectStoreImpl.h:
9:46 AM Changeset in webkit [68794] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a crashing test on Windows

  • platform/win/Skipped: Skip

fast/frames/iframe-reparenting-adopt-node.html. There's already a bug
filed about the issue.

9:40 AM Changeset in webkit [68793] by Adam Roben
  • 3 edits in trunk/WebKitTools

Ensure that QueueEngine cleans up its log files when its delegate tells it to stop processing work

Reviewed by Adam Barth.

Fixes <​http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
Windows

  • Scripts/webkitpy/tool/bot/queueengine.py:

(QueueEngine.run): Stop ourselves normally (including cleaning up log
files) when the delegate tells us to stop processing work.

  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:

(LoggingDelegate.init): Moved code here from
RaisingDelegate.init.
(LoggingDelegate.expeced_callbacks): Added the stop_work_queue
callback.
(LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
(RaisingDelegate.init): Removed code that LoggingDelegate takes
care of for us now.
(QueueEngineTest.test_trivial): Make sure we got the expected stop
message.
(QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
remove the callbacks that are related to processing a single work
item, rather than removing all callbacks after a certain point, as
there are now more callbacks we expect to receive at the end.

9:39 AM Changeset in webkit [68792] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix path -> URL conversion on Cygwin

Reviewed by Adam Barth.

Fixes <​http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
assuming paths already have a leading slash.

9:31 AM Changeset in webkit [68791] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/config.json

2010-09-30 William Siegrist <​wsiegrist@apple.com>

Fix syntax error in r68744.

9:30 AM Changeset in webkit [68790] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg

2010-09-30 William Siegrist <​wsiegrist@apple.com>

Set cache values for master.

9:16 AM Changeset in webkit [68789] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a test that fails on Windows due to lack of SSL support

  • platform/win/Skipped: Added

http/tests/navigation/ping-cross-origin-from-https.html.

9:11 AM Changeset in webkit [68788] by kenneth@webkit.org
  • 2 edits in trunk/WebKit2

Original patch by Zalan Bujtas.

Patch by Kenneth Rohde Christiansen <​kenneth@webkit.org> on 2010-09-30
Reviewed by Antti Koivisto.

The m_readBuffer might be smaller than the incoming message size and
thus result in memory corruption. Do a similar fix as the win port,
resizing the m_readBuffer to have room for the message.

  • Platform/CoreIPC/qt/ConnectionQt.cpp:

(CoreIPC::Connection::readyReadHandler):

8:45 AM Changeset in webkit [68787] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

2010-09-30 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Martin Robinson.

[Gtk] build still broken since r68521
​https://bugs.webkit.org/show_bug.cgi?id=46795

makevalues.pl and makeprop.pl generate 3 files in one run.
Double or triple target is incorrect, because on a multicore
machine make processes targets in parallel.

Setting a->b->c dependencies for 3 generated files guarantees
that make doesn't execute the recipe of the rule more than one.

  • GNUmakefile.am: Dependencies and missing headers added.
8:39 AM Changeset in webkit [68786] by Adam Roben
  • 2 edits in trunk/LayoutTests

Rebaseline fast/layers/video-layer.html on Windows

Fixes <​http://webkit.org/b/46903> <rdar://problem/8496933> REGRESSION
(r67251): fast/layers/video-layer.html failing on Windows

  • platform/win/fast/layers/video-layer-expected.txt:
8:18 AM Changeset in webkit [68785] by Adam Roben
  • 2 edits in trunk/WebKitTools

Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can be called more than once

The NPP_SetWindow call made when the plugin is torn down was confusing
us, and was causing us to spew an error into the next test.

Fixes <​http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
(r68520): plugins/access-after-page-destroyed.html failing on Windows

Reviewed by Anders Carlsson.

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:

(WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
Initialize member.
(WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
this isn't the first time this is called.

7:55 AM Changeset in webkit [68784] by Adam Roben
  • 8 edits in trunk/LayoutTests

Rebaseline Windows results for recent-ish changes

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
  • platform/win/html5lib/runner-expected.txt:
6:50 AM Changeset in webkit [68783] by caseq@chromium.org
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fixup for the previous commit that accidently only had ChangeLog.

6:44 AM Changeset in webkit [68782] by caseq@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

2010-09-30 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed build fix (marked ResourceRawHeaders.h as private).

  • WebCore.xcodeproj/project.pbxproj:
5:53 AM Changeset in webkit [68781] by caseq@chromium.org
  • 19 edits
    2 copies
    1 add in trunk

2010-09-29 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: display headers actually used by network stack in Resources tab
​https://bugs.webkit.org/show_bug.cgi?id=46092

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): enable raw headers reporting if front-end is visible.
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateResponse):
  • platform/network/ResourceRawHeaders.h: Added.
  • platform/network/ResourceRequestBase.h: Added flag to enable raw headers reporting. (WebCore::ResourceRequestBase::reportRawHeaders): (WebCore::ResourceRequestBase::setReportRawHeaders): (WebCore::ResourceRequestBase::ResourceRequestBase):
  • platform/network/ResourceResponseBase.cpp: Added support for raw headers. (WebCore::ResourceResponseBase::resourceRawHeaders): (WebCore::ResourceResponseBase::setResourceRawHeaders):
  • platform/network/ResourceResponseBase.h:

2010-09-29 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: display headers actually used by network stack in Resources tab
Added plumbing for raw headers flag and response field between chromium and WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=46092

  • WebKit.gyp:
  • public/WebResourceRawHeaders.h: Added.
  • public/WebURLRequest.h:
  • public/WebURLResponse.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::willSendRequest):
  • src/WebResourceRawHeaders.cpp: Added. (WebKit::WebResourceRawHeaders::WebResourceRawHeaders): (WebKit::WebResourceRawHeaders::~WebResourceRawHeaders): (WebKit::WebResourceRawHeaders::operator WTF::PassRefPtr<WebCore::ResourceRawHeaders>): (WebKit::addHeader): (WebKit::WebResourceRawHeaders::addRequestHeader): (WebKit::WebResourceRawHeaders::addResponseHeader):
  • src/WebURLRequest.cpp: (WebKit::WebURLRequest::setReportRawHeaders): (WebKit::WebURLRequest::reportRawHeaders):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::resourceRawHeaders): (WebKit::WebURLResponse::setResourceRawHeaders):
  • src/WebURLResponsePrivate.h:
5:47 AM Changeset in webkit [68780] by andreas.kling@nokia.com
  • 4 edits in trunk

2010-09-30 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] V8 port: Unbreak build

Add missing <wtf/text/CString.h> include.

  • WebCoreSupport/InspectorServerQt.cpp:

2010-09-30 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] V8 port: Unbreak build

Add missing <wtf/text/CString.h> include.

  • loader/PingLoader.cpp:
5:45 AM Changeset in webkit [68779] by loislo@chromium.org
  • 4 edits in trunk/WebCore

2010-09-29 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: assign the resource loading finish time which was obtained from the network stack
as the end time for the corresponding event in Timeline.
See related change for Resources panel ​https://bugs.webkit.org/show_bug.cgi?id=45664

​https://bugs.webkit.org/show_bug.cgi?id=46789

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
  • inspector/InspectorTimelineAgent.h:
5:42 AM Changeset in webkit [68778] by pfeldman@chromium.org
  • 10 edits in trunk/WebCore

2010-09-29 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: implement sorting by timeline in network panel + filtering.
​https://bugs.webkit.org/show_bug.cgi?id=45657

A number of drive-by fixes, sorting by timeline added,
0-based timeline for duration added, filters added,
more love for detailed view + nice headers.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid): (WebInspector.DataGrid.prototype.markColumnAsSortedBy): (WebInspector.DataGrid.prototype.headerTableHeader):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype.get statusBarItems): (WebInspector.NetworkPanel.prototype._createTable): (WebInspector.NetworkPanel.prototype._makeHeaderInnerHTML): (WebInspector.NetworkPanel.prototype._createSortingFunctions): (WebInspector.NetworkPanel.prototype._sortByTimeline): (WebInspector.NetworkPanel.prototype._sortItems): (WebInspector.NetworkPanel.prototype._createFilterPanel): (WebInspector.NetworkPanel.prototype._showCategory): (WebInspector.NetworkPanel.prototype._hideCategory): (WebInspector.NetworkPanel.prototype._updateFilter): (WebInspector.NetworkPanel.prototype._filter): (WebInspector.NetworkPanel.prototype._updateDividersIfNeeded): (WebInspector.NetworkPanel.prototype.reset): (WebInspector.NetworkPanel.prototype._setLargerResources): (WebInspector.NetworkDataGridNode.prototype.createCells): (WebInspector.NetworkDataGridNode.prototype._createDivInTD): (WebInspector.NetworkDataGridNode.prototype._refreshURLCell): (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell): (WebInspector.NetworkDataGridNode.prototype._appendSubtitle): (WebInspector.NetworkDataGridNode.SizeComparator): (WebInspector.NetworkDataGridNode.ResourcePropertyComparator):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel):
  • inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.updateDividers):
  • inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane): (WebInspector.TimelineOverviewPane.prototype.updateMainViewWidth):
  • inspector/front-end/inspector.css: (.data-grid th.sort-ascending > div::after): (.data-grid th.sort-descending > div::after): (.status-bar-items):
  • inspector/front-end/networkPanel.css: (.network.panel .data-grid td): (.network.panel .data-grid th): (.network.panel .data-grid.small th): (.network.panel .data-grid .data-container): (.network.panel .data-grid.small .data-container): (.network.panel .data-grid select): (.network.panel .data-grid td.time-column): (.network-cell-subtitle): (.network-header-subtitle): (.network-event-divider): (.network.panel .network-timeline-grid.small .network-event-divider): (.network.panel .resources-dividers-label-bar): (.network.panel .network-timeline-grid.small .resources-dividers-label-bar): (.network.panel .resources-divider-label): (.network.panel .resources-dividers-label-bar .resources-divider): (.network.panel .network-timeline-grid.small .resources-dividers-label-bar .resources-divider): (.network.panel .resources-divider.first .resources-divider-label): (.network.panel .resources-dividers-label-bar .resources-divider.first): (#network-filter): (.data-grid table.data tr.revealed.network-category-websockets, .data-grid table.data tr.revealed.network-category-other): (.data-grid.filter-all table.data tr.revealed.network-category-other, .data-grid.filter-other table.data tr.revealed.network-category-other):
5:29 AM Changeset in webkit [68777] by vestbo@webkit.org
  • 3 edits in trunk/WebCore

[Qt] Ensure we always report a valid size for the video

Reviewed by Simon Hausmann.

Some QtMultimedia-backends require a paint before even giving us
a size, so we start out by using the default video size, and then
update it once QtMultimedia starts feeding us valid sizes.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:

(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::nativeSizeChanged):
(WebCore::MediaPlayerPrivateQt::setSize):
(WebCore::MediaPlayerPrivateQt::naturalSize):

  • platform/graphics/qt/MediaPlayerPrivateQt.h:
5:04 AM Changeset in webkit [68776] by Nikolas Zimmermann
  • 1 edit in trunk/WebCore/ChangeLog

Correct reviewer, Andreas was faster!

5:03 AM Changeset in webkit [68775] by Nikolas Zimmermann
  • 3 edits in trunk/WebCore

2010-09-30 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

RenderSVGTextPath lacks isSVGTextPath() method
​https://bugs.webkit.org/show_bug.cgi?id=46888

Make RenderSVGTextPath objects easily detectable, using a isSVGTextPath() method, like all other SVG renderers have.

  • rendering/RenderObject.h: (WebCore::RenderObject::isSVGTextPath): Return false.
  • rendering/RenderSVGTextPath.h: Changed indentation of whole file. (WebCore::RenderSVGTextPath::isSVGTextPath): Return true. (WebCore::RenderSVGTextPath::renderName): (WebCore::toRenderSVGTextPath): Add helper casting methods.
5:00 AM Changeset in webkit [68774] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Ensure that the media player backend does not leave any resources around

Reviewed by Simon Hausmann.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:

(WebCore::MediaPlayerPrivateQt::~MediaPlayerPrivateQt):

4:51 AM Changeset in webkit [68773] by Nikolas Zimmermann
  • 3 edits in trunk/WebCore

2010-09-30 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

AffineTransform should expose methods calculating the x/y scale factors
​https://bugs.webkit.org/show_bug.cgi?id=46887

Expose methods calculating the x/y scale factors for an AffineTransform.

  • platform/graphics/transforms/AffineTransform.cpp: (WebCore::affineTransformDecompose): Move xScale / yScale calculations in their own functions. (WebCore::AffineTransform::xScale): (WebCore::AffineTransform::yScale):
  • platform/graphics/transforms/AffineTransform.h:
4:50 AM Changeset in webkit [68772] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

Minor cleanup of MediaPlayerPrivateQt

Reviewed by Simon Hausmann.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:

(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::currentTime):
(WebCore::MediaPlayerPrivateQt::positionChanged):
(WebCore::MediaPlayerPrivateQt::paint):

4:44 AM Changeset in webkit [68771] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-30 Peter Varga <​pvarga@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

The case-insensitivity backreference checking isn't working with YARR
Interpreter
​https://bugs.webkit.org/show_bug.cgi?id=46882

Add ignorecase checking to the Interpreter::tryConsumeBackReference() function.

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::tryConsumeBackReference):
3:29 AM Changeset in webkit [68770] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-30 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Andreas Kling.

[BREWMP] Leave initializeRandomNumberGenerator empty.
​https://bugs.webkit.org/show_bug.cgi?id=46851

On Brew MP, AEECLSID_RANDOM initializes itself.

  • wtf/RandomNumberSeed.h: (WTF::initializeRandomNumberGenerator):
2:36 AM Changeset in webkit [68769] by jochen@chromium.org
  • 3 edits in trunk/WebCore

2010-09-30 Jochen Eisinger <​jochen@chromium.org>

Reviewed by Jeremy Orlow.

Mark unused parameters as such.
​https://bugs.webkit.org/show_bug.cgi?id=46880

  • inspector/InspectorDOMAgent.cpp:
  • page/Geolocation.cpp: (WebCore::Geolocation::clearWatch):
2:26 AM Changeset in webkit [68768] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-30 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch upload warns that I'm using Xcode when I'm not
​https://bugs.webkit.org/show_bug.cgi?id=46869

String.find returns -1 when not found, so switched to "in".

  • Scripts/webkitpy/common/system/user.py:
  • Scripts/webkitpy/common/system/user_unittest.py:
2:15 AM Changeset in webkit [68767] by podivilov@chromium.org
  • 15 edits
    2 adds in trunk/WebCore

2010-09-29 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract Inspector Instrumentation API as a class.
​https://bugs.webkit.org/show_bug.cgi?id=46614

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::sendCallback):
  • dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent):
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::parserInsertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::parserAddChild): (WebCore::notifyChildInserted): (WebCore::dispatchChildRemovalEvents):
  • dom/Element.cpp: (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::instrumentWillSendXMLHttpRequest):
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: Added. (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::characterDataModifiedImpl): (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequestImpl):
  • inspector/InspectorInstrumentation.h: Added. (WebCore::InspectorInstrumentation::frontendCreated): (WebCore::InspectorInstrumentation::frontendDeleted): (WebCore::InspectorInstrumentation::hasFrontends): (WebCore::InspectorInstrumentation::willInsertDOMNode): (WebCore::InspectorInstrumentation::didInsertDOMNode): (WebCore::InspectorInstrumentation::willRemoveDOMNode): (WebCore::InspectorInstrumentation::willModifyDOMAttr): (WebCore::InspectorInstrumentation::didModifyDOMAttr): (WebCore::InspectorInstrumentation::characterDataModified): (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequest): (WebCore::InspectorInstrumentation::inspectorControllerForScriptExecutionContext): (WebCore::InspectorInstrumentation::inspectorControllerForDocument): (WebCore::InspectorInstrumentation::inspectorControllerForPage):
  • workers/SharedWorker.cpp:
2:12 AM Changeset in webkit [68766] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-09-30 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch failure-reason dies if non-trunk commits are in the blame range
​https://bugs.webkit.org/show_bug.cgi?id=46866

I also made failure-reason use RegressionWindow in a cleaner way.

  • Scripts/webkitpy/tool/commands/queries.py:
1:50 AM Changeset in webkit [68765] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-09-30 Avi Drissman <​avi@google.com>

Reviewed by Kenneth Russell.

[Chromium] Tabbing into page doesn't always select the first element
​https://bugs.webkit.org/show_bug.cgi?id=46856

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setInitialFocus):
1:37 AM Changeset in webkit [68764] by loki@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-30 Gabor Loki <​loki@webkit.org>

Reviewed by Csaba Osztrogonác.

Remove unnecessary cacheFlush calls from Thumb-2
​https://bugs.webkit.org/show_bug.cgi?id=46702

  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::relinkCall): (JSC::ARMv7Assembler::repatchInt32): (JSC::ARMv7Assembler::repatchPointer):
1:22 AM Changeset in webkit [68763] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-30 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Darin Adler.

Build fix: Add ENABLE(INSPECTOR) guard
​https://bugs.webkit.org/show_bug.cgi?id=46852

Page does not have inspectorController() when ENABLE(INSPECTOR) is 0.

  • inspector/InspectorController.h: (WebCore::InspectorController::inspectorControllerForDocument):
12:48 AM Changeset in webkit [68762] by commit-queue@webkit.org
  • 22 edits
    1 copy in trunk/WebCore

2010-09-30 Michael Nordman <Michael Nordman>

Reviewed by David Levin.

Make it possible to copy platform specific data members of ResourceRequest and ResourceResponse
across threads and to compare platform specific data members of ResourceRequest.

  • Added two instance methods to the platform specific subclasses: doPlatformAdopt and doPlatformCopyData.
  • Also added a "shadowable" static method for platformCompare to ResourceRequestBase, a similar method is already present on ResourceResponseBase.
  • Converted the cross thread structs defined in ResourceRequest/ResponseBase.h to base classes and extended those base classes in the platform specific headers to provide a place to hold additional fields.
  • Used this mechanism to have the chromium port's data members make the hop. ​https://bugs.webkit.org/show_bug.cgi?id=46430

No new tests. Just plumbing.

  • WebCore.exp.in: removed the symbol for the now inlined == operator
  • WebCore.gypi: added chromium/ResourceResponse.cpp
  • platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::adopt): (WebCore::ResourceRequestBase::copyData): (WebCore::ResourceRequestBase::compare):
  • platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::platformCompare): (WebCore::operator==): (WebCore::operator!=):
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::asResourceResponse): (WebCore::ResourceResponseBase::adopt): (WebCore::ResourceResponseBase::copyData):
  • platform/network/ResourceResponseBase.h:
  • platform/network/android/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
  • platform/network/android/ResourceResponse.h: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/cf/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
  • platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/chromium/ResourceRequest.cpp: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
  • platform/network/chromium/ResourceRequest.h:
  • platform/network/chromium/ResourceResponse.cpp: Added. (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/chromium/ResourceResponse.h:
  • platform/network/curl/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
  • platform/network/curl/ResourceResponse.h: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/mac/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
  • platform/network/mac/ResourceResponse.h: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/qt/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
  • platform/network/qt/ResourceResponse.h: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/soup/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
  • platform/network/soup/ResourceResponse.h: (WebCore::ResourceResponse::doUpdateResourceResponse): (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
12:22 AM Changeset in webkit [68761] by benjamin.poulain@nokia.com
  • 4 edits in trunk/WebKit/qt

2010-09-30 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] Crash if an scene with accelerated compositing layout during the paint event
​https://bugs.webkit.org/show_bug.cgi?id=46812

Delay the deletion of the overlay after the current event is processed.

Removing the overlay can sometimes be done inside the rendering code of
the overlay itself. When the rendering code is using the reference after
the deletion of the overlay, WebKit crashes.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::overlay):
  • WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::createOrDeleteOverlay):
  • WebCoreSupport/PageClientQt.h: (WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):
12:10 AM Changeset in webkit [68760] by benjamin.poulain@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-09-30 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] Fix tst_QWebPage::geolocationRequestJS()
​https://bugs.webkit.org/show_bug.cgi?id=46814

Disable the test. This test cannot pass with a
standard build of WebKit, it is disabled until the API is finilized.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::geolocationRequestJS):
12:08 AM Changeset in webkit [68759] by commit-queue@webkit.org
  • 2 edits
    1 move in trunk/WebKit/chromium

2010-09-30 Alexey Marinichev <​amarinichev@chromium.org>

Reviewed by Kenneth Russell.

Rename chromium's GraphicsContext3D.cpp to match others.
​https://bugs.webkit.org/show_bug.cgi?id=46771

  • WebKit.gyp:
  • src/GraphicsContext3DChromium.cpp: Renamed from WebKit/chromium/src/GraphicsContext3D.cpp.

Sep 29, 2010:

11:52 PM Changeset in webkit [68758] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-09-29 W. James MacLean <​wjmaclean@chromium.org>

Reviewed by James Robinson.

Rebaseline image-rescale.svg results for chromium-win
​https://bugs.webkit.org/show_bug.cgi?id=46818

  • platform/chromium-win/svg/custom/image-rescale-expected.checksum: Copied from LayoutTests/platform/chromium-linux/svg/custom/image-rescale-expected.checksum.
  • platform/chromium-win/svg/custom/image-rescale-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/custom/image-rescale-expected.png.
  • platform/chromium/test_expectations.txt:
11:49 PM Changeset in webkit [68757] by crogers@google.com
  • 3 edits in trunk/WebCore

2010-09-29 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Put default initialize() and uninitialize() methods in AudioNode
​https://bugs.webkit.org/show_bug.cgi?id=46767

No new tests since audio API is not yet implemented.

  • webaudio/AudioNode.cpp: (WebCore::AudioNode::initialize): (WebCore::AudioNode::uninitialize):
  • webaudio/AudioNode.h:
11:34 PM Changeset in webkit [68756] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-29 Adam Barth <​abarth@webkit.org>

Unreviewed. See comments in the Skipped file.

  • platform/mac/Skipped:
11:29 PM Changeset in webkit [68755] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-29 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch find-flaky-tests
​https://bugs.webkit.org/show_bug.cgi?id=46876

This command helps us find flaky tests so we can squash them.

  • Scripts/webkitpy/tool/commands/queries.py:
11:26 PM Changeset in webkit [68754] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Skip plugins/plugin-document-load-prevented-userscript.html on Qt, because it doesn't
support window.layoutTestController.addUserScript yet.

Rubber-stamped by Adam Barth.

  • platform/qt/Skipped:
11:24 PM Changeset in webkit [68753] by alex
  • 2 edits in trunk/LayoutTests

2010-09-29 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, LayoutTestController::addUserScript not supported in
GTK+, skip plugin-document-load-prevented-userscript.html.

  • platform/gtk/Skipped:
10:56 PM Changeset in webkit [68752] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-29 MORITA Hajime <​morrita@google.com>

Unreviewed, updated test_expectations.txt

  • platform/chromium/test_expectations.txt:
10:27 PM Changeset in webkit [68751] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-09-29 Simon Fraser <Simon Fraser>

Fix export to use '?' instead of 'null' for
tests with no results.

  • CSSTestSuiteHarness/harness/harness.js:
9:41 PM Changeset in webkit [68750] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-29 MORITA Hajime <​morrita@google.com>

Unreviewed, updated test_expectations.txt

  • platform/chromium/test_expectations.txt:
9:22 PM Changeset in webkit [68749] by tkent@chromium.org
  • 6 edits in trunk

2010-09-29 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Refactor HTMLInputElement: Make DeprecatedInputType private.
​https://bugs.webkit.org/show_bug.cgi?id=46791

No new tests because this doesn't change any behavior.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::createTypeMap):
  • html/HTMLInputElement.h: Move DeprecatedInputType, deprecatedInputType() and parseToDateComponents() to the private section, make createTypeMap() a member function of HTMLInputElement. (WebCore::HTMLInputElement::deprecatedInputType):

2010-09-29 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Refactor HTMLInputElement: Make DeprecatedInputType private.
​https://bugs.webkit.org/show_bug.cgi?id=46791

  • src/WebPasswordFormUtils.cpp: (WebKit::findPasswordFormFields): Accept any text field types as a username field.
  • src/WebSearchableFormData.cpp: (WebCore::HasSuitableTextElement): Accept any text field types as a search query field.
9:14 PM Changeset in webkit [68748] by Simon Fraser
  • 4 edits in trunk/WebKitTools

2010-09-29 Simon Fraser <Simon Fraser>

Add a warning when a test requires special steps.
Add a Print Preview button for 'paged' tests that
brings up the print dialog, allowing the user to
judge paged media tests.

  • CSSTestSuiteHarness/harness/harness.css:
  • CSSTestSuiteHarness/harness/harness.html:
  • CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.loadTest): (TestSuite.prototype.processFlags):
9:07 PM Changeset in webkit [68747] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-09-29 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove revisions_casuing_failures
​https://bugs.webkit.org/show_bug.cgi?id=46872

This function exists only to be unit tested.

  • Scripts/webkitpy/common/net/failuremap.py:
  • Scripts/webkitpy/common/net/failuremap_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
8:57 PM Changeset in webkit [68746] by abarth@webkit.org
  • 12 edits in trunk/WebKitTools

2010-09-29 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

SheriffBot should post the list of failing tests to bugs
​https://bugs.webkit.org/show_bug.cgi?id=46871

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/failuremap.py:
  • Scripts/webkitpy/common/net/regressionwindow.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
8:42 PM Changeset in webkit [68745] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-29 Eric Seidel <​eric@webkit.org>

Unreviewed. Skipping crashing test to green the tree.
This crash started when I skipped some canvas tests
as part of rolling out r68568.

fast/canvas/webgl/draw-elements-out-of-bounds.html is crashing on Snow Leopard
​https://bugs.webkit.org/show_bug.cgi?id=46870

  • platform/mac-snowleopard/Skipped:
8:33 PM Changeset in webkit [68744] by bfulgham@webkit.org
  • 5 edits in trunk/WebKitTools

[WinCairo] Adds a build slave.
​https://bugs.webkit.org/show_bug.cgi?id=46360

Patch by Brent Fulgham <​bfulgham@webkit.org> on 2010-09-29
Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Add

entries for a debug build of the WinCairo port.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Add

platform flag to configuration for wincairo (like gtk, chromium, etc.)

  • Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
  • Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
8:27 PM Changeset in webkit [68743] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-29 MORITA Hajime <​morrita@google.com>

Unreviewed, updated test_expectations.txt

  • platform/chromium/test_expectations.txt:
8:06 PM Changeset in webkit [68742] by mihaip@chromium.org
  • 5 edits
    4 adds in trunk

2010-09-29 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Darin Fisher.

REGRESSION: page reload on back button after history.pushState with appearing/disappearing iframes
​https://bugs.webkit.org/show_bug.cgi?id=46324

Add test which uses pushState to generate history entries while also
changing the frames that are present in the document between history
states. Add a similar test that uses fragment changes.

  • fast/history/same-document-iframes-changing-fragment-expected.txt: Added.
  • fast/history/same-document-iframes-changing-fragment.html: Added.
  • fast/history/same-document-iframes-changing-pushstate-expected.txt: Added.
  • fast/history/same-document-iframes-changing-pushstate.html: Added.

2010-09-29 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Darin Fisher.

REGRESSION: page reload on back button after history.pushState with appearing/disappearing iframes
​https://bugs.webkit.org/show_bug.cgi?id=46324

Revert same document check to the way it was before r66238 for history
entries created by pushState or fragment changes. Logic fror determining
if same document navigation should be used is moved to HistoryItem.

Tests: fast/history/same-document-iframes-changing-fragment.html

fast/history/same-document-iframes-changing-pushstate.html

  • history/HistoryItem.cpp: (WebCore::HistoryItem::shouldDoSameDocumentNavigationTo): (WebCore::HistoryItem::hasSameDocumentTree): (WebCore::HistoryItem::hasSameFrames):
  • history/HistoryItem.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem):
8:01 PM Changeset in webkit [68741] by kinuko@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-29 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Dumitru Daniliuc.

Add removeRecursively to WebKit WebFileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=46842

  • public/WebFileSystem.h: (WebKit::WebFileSystem::removeRecursively): Added.
7:53 PM Changeset in webkit [68740] by abarth@webkit.org
  • 7 edits
    1 add in trunk/WebKitTools

2010-09-29 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move more SheriffBot smarts into FailureMap
​https://bugs.webkit.org/show_bug.cgi?id=46703

This patch pushes the FailureMap model object further into the
SheriffBot machine. In addition, it moves a couple operations on this
object from SheriffBot itself to the model.

Eventually, FailureMap will be the canonical context object for
SheriffBot operations. FailureMap represents a map of the current
failures on the bots that might require remediation.

  • Scripts/webkitpy/common/net/failuremap.py:
  • Scripts/webkitpy/common/net/regressionwindow.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/mocktool.py:
7:49 PM Changeset in webkit [68739] by abarth@webkit.org
  • 1 edit
    1 copy
    1 move in trunk/LayoutTests

2010-09-29 Adam Barth <​abarth@webkit.org>

This test result seems to be platform specific.

  • platform/mac-leopard/plugins/plugin-initiate-popup-window-expected.txt: Renamed from LayoutTests/plugins/plugin-initiate-popup-window-expected.txt.
  • platform/mac/plugins/plugin-initiate-popup-window-expected.txt: Added.
7:34 PM Changeset in webkit [68738] by morrita@google.com
  • 2 edits in trunk/WebCore

2010-09-29 MORITA Hajime <​morrita@google.com>

Unreviewed build fix.

WebCore::ESpeak causes missing symbol with no ENABLE_SVG
​https://bugs.webkit.org/show_bug.cgi?id=46865

Moves ESpeak related function definitions outside ENABLE_SVG block.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator ESpeak): (WebCore::CSSPrimitiveValue::operator EVectorEffect):
7:24 PM Changeset in webkit [68737] by eric@webkit.org
  • 71 edits in trunk/LayoutTests

2010-09-29 Eric Seidel <​eric@webkit.org>

Unreviewed, rolling out r68568.
​http://trac.webkit.org/changeset/68568
​https://bugs.webkit.org/show_bug.cgi?id=46439

Failing tests on both Leopard and Snow Leopard

  • canvas/philip/tests/2d.composite.operation.darker-expected.txt:
  • canvas/philip/tests/2d.composite.operation.highlight-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.fill.copy-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.fill.destination-atop-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.fill.destination-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.fill.source-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.fill.source-out-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.copy-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.destination-atop-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.destination-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.source-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.source-out-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.pattern.copy-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.pattern.destination-atop-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.pattern.destination-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.pattern.source-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.pattern.source-out-expected.txt:
  • canvas/philip/tests/2d.drawImage.incomplete-expected.txt:
  • canvas/philip/tests/2d.drawImage.null-expected.txt:
  • canvas/philip/tests/2d.fillStyle.parse.current.basic-expected.txt:
  • canvas/philip/tests/2d.fillStyle.parse.current.changed-expected.txt:
  • canvas/philip/tests/2d.fillStyle.parse.current.removed-expected.txt:
  • canvas/philip/tests/2d.fillStyle.parse.system-expected.txt:
  • canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt:
  • canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt:
  • canvas/philip/tests/2d.gradient.radial.inside2-expected.txt:
  • canvas/philip/tests/2d.gradient.radial.inside3-expected.txt:
  • canvas/philip/tests/2d.gradient.radial.negative-expected.txt:
  • canvas/philip/tests/2d.gradient.radial.outside1-expected.txt:
  • canvas/philip/tests/2d.imageData.create1.type-expected.txt:
  • canvas/philip/tests/2d.imageData.create2.type-expected.txt:
  • canvas/philip/tests/2d.imageData.get.source.negative-expected.txt:
  • canvas/philip/tests/2d.imageData.get.type-expected.txt:
  • canvas/philip/tests/2d.line.cap.closed-expected.txt:
  • canvas/philip/tests/2d.line.join.parallel-expected.txt:
  • canvas/philip/tests/2d.line.miter.lineedge-expected.txt:
  • canvas/philip/tests/2d.missingargs-expected.txt:
  • canvas/philip/tests/2d.path.rect.winding-expected.txt:
  • canvas/philip/tests/2d.pattern.image.broken-expected.txt:
  • canvas/philip/tests/2d.pattern.image.incomplete-expected.txt:
  • canvas/philip/tests/2d.pattern.image.null-expected.txt:
  • canvas/philip/tests/2d.pattern.image.undefined-expected.txt:
  • canvas/philip/tests/2d.shadow.enable.blur-expected.txt:
  • canvas/philip/tests/2d.shadow.enable.x-expected.txt:
  • canvas/philip/tests/2d.shadow.enable.y-expected.txt:
  • canvas/philip/tests/2d.shadow.gradient.alpha-expected.txt:
  • canvas/philip/tests/2d.shadow.gradient.basic-expected.txt:
  • canvas/philip/tests/2d.shadow.gradient.transparent.2-expected.txt:
  • canvas/philip/tests/2d.strokeRect.zero.4-expected.txt:
  • canvas/philip/tests/2d.text.draw.baseline.bottom-expected.txt:
  • canvas/philip/tests/2d.text.draw.baseline.hanging-expected.txt:
  • canvas/philip/tests/2d.text.draw.baseline.ideographic-expected.txt:
  • canvas/philip/tests/2d.text.draw.baseline.middle-expected.txt:
  • canvas/philip/tests/2d.text.draw.baseline.top-expected.txt:
  • canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt:
  • canvas/philip/tests/2d.text.draw.space.collapse.end-expected.txt:
  • canvas/philip/tests/2d.text.draw.space.collapse.nonspace-expected.txt:
  • canvas/philip/tests/2d.text.draw.space.collapse.other-expected.txt:
  • canvas/philip/tests/2d.text.draw.space.collapse.space-expected.txt:
  • canvas/philip/tests/2d.text.draw.space.collapse.start-expected.txt:
  • canvas/philip/tests/2d.text.font.parse.basic-expected.txt:
  • canvas/philip/tests/2d.text.font.parse.complex-expected.txt:
  • canvas/philip/tests/2d.text.font.parse.invalid-expected.txt:
  • canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt:
  • canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt:
  • canvas/philip/tests/2d.text.font.parse.system-expected.txt:
  • canvas/philip/tests/2d.text.measure.width.space-expected.txt:
  • canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt:
  • canvas/philip/tests/type.prototype-expected.txt:
  • platform/mac/Skipped:
6:27 PM Changeset in webkit [68736] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-09-29 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioChannelSplitter files
​https://bugs.webkit.org/show_bug.cgi?id=46290

No new tests since audio API is not yet implemented.

  • webaudio/AudioChannelSplitter.cpp: Added. (WebCore::AudioChannelSplitter::AudioChannelSplitter): (WebCore::AudioChannelSplitter::process): (WebCore::AudioChannelSplitter::reset):
  • webaudio/AudioChannelSplitter.h: Added. (WebCore::AudioChannelSplitter::create):
  • webaudio/AudioChannelSplitter.idl: Added.
6:16 PM Changeset in webkit [68735] by kinuko@chromium.org
  • 15 edits
    5 adds in trunk

2010-09-29 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Fix DirectoryReader's behavior to trigger only one EntriesCallback per readEntries
​https://bugs.webkit.org/show_bug.cgi?id=46563

  • src/WebFileSystemCallbacksImpl.cpp: (WebKit::WebFileSystemCallbacksImpl::didReadDirectory):

2010-09-29 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Fix DirectoryReader's behavior to trigger only one EntriesCallback per readEntries
​https://bugs.webkit.org/show_bug.cgi?id=46563

Test: fast/filesystem/read-directory.html

  • fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::readDirectory): Changed to take DirectoryReader as a parameter.
  • fileapi/DOMFileSystem.h: (WebCore::DOMFileSystem::scheduleCallback): Added.
  • fileapi/DirectoryReader.cpp: (WebCore::DirectoryReader::DirectoryReader): Added initializer for m_hasMore flag. (WebCore::DirectoryReader::readEntries): Changed to schedule EntriesCallback with an empty array if m_hasMore flag is set false.
  • fileapi/DirectoryReader.h: (WebCore::DirectoryReader::filesystem): Added. (WebCore::DirectoryReader::setHasMore): Added.
  • fileapi/FileSystemCallbacks.cpp: (WebCore::EntriesCallbacks::create): (WebCore::EntriesCallbacks::EntriesCallbacks): Changed to take DirectoryReader as a parameter. (WebCore::EntriesCallbacks::didReadDirectoryEntry): (WebCore::EntriesCallbacks::didReadDirectoryEntries): Changed 1) not to trigger the second callback when hasMore is false, and 2) to update the DirectoryReader's m_hasMore flag.
  • fileapi/FileSystemCallbacks.h:

2010-09-29 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Fix DirectoryReader's behavior to trigger only one EntriesCallback per readEntries
​https://bugs.webkit.org/show_bug.cgi?id=46563

  • fast/filesystem/flags-passing.html: Updated to make it match with the updated TEMPLATE.html.
  • fast/filesystem/flags-passing-expected.txt: Updated.
  • fast/filesystem/read-directory.html: Added.
  • fast/filesystem/read-directory-expected.txt: Added.
  • fast/filesystem/resources/fs-test-util.js: Added for common test utilities.
  • fast/filesystem/script-tests/TEMPLATE.html: Updated to include fs-test-util.js.
  • fast/filesystem/script-tests/flags-passing.js: Updated to use jsTestIsAsync and finishJSTest (so that all the tests look alike).
  • fast/filesystem/script-tests/read-directory.js: Added.
6:12 PM Changeset in webkit [68734] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-09-29 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioGainNode files
​https://bugs.webkit.org/show_bug.cgi?id=46286

No new tests since audio API is not yet implemented.

  • webaudio/AudioGainNode.cpp: Added. (WebCore::AudioGainNode::AudioGainNode): (WebCore::AudioGainNode::process): (WebCore::AudioGainNode::reset): (WebCore::AudioGainNode::checkNumberOfChannelsForInput):
  • webaudio/AudioGainNode.h: Added. (WebCore::AudioGainNode::create): (WebCore::AudioGainNode::gain):
  • webaudio/AudioGainNode.idl: Added.
6:07 PM Changeset in webkit [68733] by morrita@google.com
  • 3 edits in trunk/LayoutTests

2010-09-29 MORITA Hajime <​morrita@google.com>

Unreviewed, updated expectations.

  • platform/chromium-mac/plugins/netscape-plugin-property-access-exception-expected.txt:
  • platform/chromium-win/plugins/netscape-plugin-property-access-exception-expected.txt:
5:55 PM Changeset in webkit [68732] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-09-29 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioChannelMerger files
​https://bugs.webkit.org/show_bug.cgi?id=46291

No new tests since audio API is not yet implemented.

  • webaudio/AudioChannelMerger.cpp: Added. (WebCore::AudioChannelMerger::AudioChannelMerger): (WebCore::AudioChannelMerger::process): (WebCore::AudioChannelMerger::reset):
  • webaudio/AudioChannelMerger.h: Added. (WebCore::AudioChannelMerger::create):
  • webaudio/AudioChannelMerger.idl: Added.
5:45 PM Changeset in webkit [68731] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Calling Connection::send/sendSync from Connection::Client::didClose should always fail
​https://bugs.webkit.org/show_bug.cgi?id=46859
<rdar://problem/8212583>

Reviewed by Simon Fraser.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::dispatchConnectionDidClose):

5:31 PM Changeset in webkit [68730] by Chris Fleizach
  • 2 edits in trunk/WebCore

No review. Missed file for patch.

AX: implement CSS3 Speech "speak"
​https://bugs.webkit.org/show_bug.cgi?id=46827

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

5:30 PM Changeset in webkit [68729] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r68340.

5:14 PM Changeset in webkit [68728] by Chris Fleizach
  • 4 edits in trunk/LayoutTests

No review. Update layout tests after new CSS property.

AX: implement CSS3 Speech "speak"
​https://bugs.webkit.org/show_bug.cgi?id=46827

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
5:11 PM Changeset in webkit [68727] by enrica@apple.com
  • 2 edits in trunk/WebCore

Crash at lineBreakExistsAtPosition + 125
<rdar://problem/7028809>
​https://bugs.webkit.org/show_bug.cgi?id=46770

Reviewed by Darin Adler.

lineBreakExistsAtPosition is called from InsertTextCommand::input,
where we compute the downstream position of the endingSelection().
Downstream can return the original position, that comes from a VisibleSelection
but there is no guarantee that its renderer is still there. Everywhere we dereference
a renderer we check if it's null.

There is no regression test.

  • editing/htmlediting.cpp:

(WebCore::lineBreakExistsAtPosition): Added check that the renderer is not null
before dereferencing it.

5:10 PM Changeset in webkit [68726] by Simon Fraser
  • 2 edits in trunk/WebKit2

2010-09-29 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Assertion then crash closing WebKit2 window with accelerated compositing in
​https://bugs.webkit.org/show_bug.cgi?id=46857

Fix two issues when closing a WebKit2 window using accelerated
compositing.

The first is that the response to the sync DidChangeAcceleratedCompositing message
sent by changeAcceleratedCompositingMode() may be empty, because the corresponding
page may have been destroyed already in the UI process. In that case newDrawingAreaInfo
is not filled in, so we get a DrawingArea::Type of None. Don't attempt to make a new
drawing area in that case.

We then have to null-check the drawing area in WebPage::didReceiveMessage(),
in the case where the UI process is calling back with a SuspendPainting message,
before our page has gone away.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::changeAcceleratedCompositingMode): (WebKit::WebPage::didReceiveMessage):
5:10 PM Changeset in webkit [68725] by mrowe@apple.com
  • 6 edits
    2 adds in branches/safari-533.19-branch

Merge r66028.

5:08 PM Changeset in webkit [68724] by mrowe@apple.com
  • 3 edits in branches/safari-533.19-branch/WebCore

Merge r67288.

5:08 PM Changeset in webkit [68723] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/WebCore

Merge r67286.

5:08 PM Changeset in webkit [68722] by mrowe@apple.com
  • 9 edits
    2 adds in branches/safari-533.19-branch

Merge r67285.

5:00 PM Changeset in webkit [68721] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/WebCore

Merge r68278.

4:59 PM Changeset in webkit [68720] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r68158.

4:57 PM Changeset in webkit [68719] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r68485.

4:55 PM Changeset in webkit [68718] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.19-branch

Merge r68408.

4:52 PM Changeset in webkit [68717] by mrowe@apple.com
  • 6 edits
    3 adds in branches/safari-533.19-branch

Merge r64780.

4:52 PM Changeset in webkit [68716] by andersca@apple.com
  • 5 edits in trunk

plugins/npruntime/invoke-failure.html fails in WebKit2 due to slightly different exception being thrown
​https://bugs.webkit.org/show_bug.cgi?id=46715
<rdar://problem/8485909>

Reviewed by Darin Adler.

WebCore:

Remove exclamation points from exceptions.

  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):

  • bridge/c/c_instance.cpp:

(JSC::Bindings::CInstance::invokeMethod):
(JSC::Bindings::CInstance::invokeDefaultMethod):
(JSC::Bindings::CInstance::invokeConstruct):

LayoutTests:

Remove exclamation point.

  • plugins/npruntime/invoke-failure-expected.txt:
4:51 PM Changeset in webkit [68715] by weinig@apple.com
  • 4 edits in trunk/WebCore

Add additional checks to StringBuilder.
<rdar://problem/7761248>

Reviewed by Darin Adler.

  • platform/text/StringBuilder.cpp:

(WebCore::checkAppend):
(WebCore::StringBuilder::append):
(WebCore::StringBuilder::toString):
(WebCore::StringBuilder::clear):
(WebCore::StringBuilder::length):

  • platform/text/StringBuilder.h:

(WebCore::StringBuilder::StringBuilder):
(WebCore::StringBuilder::setNonNull):
(WebCore::StringBuilder::isNull):

4:51 PM Changeset in webkit [68714] by Chris Fleizach
  • 2 edits in trunk/LayoutTests

Unreviewed. Update test results.

AX: implement CSS3 Speech "speak"
​https://bugs.webkit.org/show_bug.cgi?id=46827

Rebaseline GTK test after CSS change.

  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
4:42 PM Changeset in webkit [68713] by mrowe@apple.com
  • 4 edits
    4 adds in branches/safari-533.19-branch

Merge r65900.

4:31 PM Changeset in webkit [68712] by mrowe@apple.com
  • 6 edits
    2 adds in branches/safari-533.19-branch

Merge r68096.

4:22 PM Changeset in webkit [68711] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r61709.

4:20 PM Changeset in webkit [68710] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r62873.

4:19 PM Changeset in webkit [68709] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r67967.

4:13 PM Changeset in webkit [68708] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.19-branch

Merge r68461.

4:09 PM Changeset in webkit [68707] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r67407.

4:07 PM Changeset in webkit [68706] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533.19-branch

Merge r61622.

4:05 PM Changeset in webkit [68705] by andersca@apple.com
  • 2 edits in trunk/WebCore

Add additional check to Text::wholeText.
<rdar://problem/8304795>

Reviewed by Darin Adler.

  • dom/Text.cpp:

(WebCore::Text::wholeText):

4:05 PM Changeset in webkit [68704] by mrowe@apple.com
  • 3 edits in branches/safari-533.19-branch/WebCore

Merge r65313.

4:04 PM Changeset in webkit [68703] by mrowe@apple.com
  • 4 edits
    3 adds in branches/safari-533.19-branch

Merge r65135.

3:59 PM Changeset in webkit [68702] by bweinstein@apple.com
  • 6 edits
    4 adds in trunk

REGRESSION (r66129): Loading full-frame .swf file crashes with flash blocker extension enabled
<​https://bugs.webkit.org/show_bug.cgi?id=46773>
<rdar://problem/8390975>

Reviewed by Brady Eidson.

WebCore:

After r66129, start scripts were run on plugin documents, and cancelling the load of a plugin
document could cause Safari to crash.

If a plugin load on an initial document is cancelled, we cancel the main resource load (where the
main resource is the plugin), and if the load is restarted and allowed, we don't go through the manual
loading path like we do on the initial load of a plugin in a plugin document.

Tests: plugins/plugin-document-load-prevented-userscript.html

plugins/plugin-document-willSendRequest-null.html

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget): If the plugin load was cancelled, and this is in a

plugin document, call a function on PluginDocument that cancels the main resource load, and
sets a plugin document flag.

  • html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::appendBytes): Null check the widget's renderer, because it could be

null if the load was cancelled.

(WebCore::PluginDocument::PluginDocument): Initialize the new variable.
(WebCore::PluginDocument::cancelManualPluginLoad): Cancel the main resource load of the plugin document

(which is a plugin in the case of a plugin document).

  • html/PluginDocument.h:

(WebCore::PluginDocument::shouldLoadPluginManually): Returns whether or not we should load the plugin

manually.

(WebCore::PluginDocument::setShouldLoadPluginManually): Set whether or not we should load the plugin

manually.

(WebCore::toPluginDocument):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadPlugin): Check if we should load the plugin manually according to the plugin

document.

LayoutTests:

Add tests testing how plugin documents behave when the loading of their plugins are cancelled.

  • plugins/plugin-document-load-prevented-userscript-expected.txt: Added.
  • plugins/plugin-document-load-prevented-userscript.html: Added. Tests cancelling the load of a

plugin in a plugin document using beforeload and preventDefault.

  • plugins/plugin-document-willSendRequest-null-expected.txt: Added.
  • plugins/plugin-document-willSendRequest-null.html: Added. Tests cancelling the load of a plugin

in a plugin document by having willSendRequest return null.

3:58 PM Changeset in webkit [68701] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r63138.

3:53 PM Changeset in webkit [68700] by tony@chromium.org
  • 8 edits in trunk

2010-09-29 Tony Chang <​tony@chromium.org>

Reviewed by James Robinson.

[chromium] enable -Werror for DRT and webkit_unit_tests on Linux
​https://bugs.webkit.org/show_bug.cgi?id=46829

  • WebKit.gyp:
  • tests/ArenaTestHelpers.h: (WebCore::ArenaTestHelpers::TrackedAllocator::free):
  • tests/IDBKeyPathTest.cpp: (WebCore::checkKeyPath):

2010-09-29 Tony Chang <​tony@chromium.org>

Reviewed by James Robinson.

[chromium] enable -Werror for DRT and webkit_unit_tests on Linux
​https://bugs.webkit.org/show_bug.cgi?id=46829

  • DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::DRTDevToolsClient):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::postAccessibilityNotification): (WebViewHost::WebViewHost):
3:52 PM Changeset in webkit [68699] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/WebCore

Merge r63836.

3:52 PM Changeset in webkit [68698] by mrowe@apple.com
  • 6 edits
    7 adds in branches/safari-533.19-branch

Merge r63834.

3:51 PM Changeset in webkit [68697] by mrowe@apple.com
  • 4 edits
    8 adds in branches/safari-533.19-branch

Merge r59185.

3:22 PM Changeset in webkit [68696] by hyatt@apple.com
  • 3 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46844, make estimateLogicalTopPosition
block-flow-aware.

Reviewed by Sam Weinig.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::collapsedMarginBeforeForChild):
(WebCore::RenderBlock::collapsedMarginAfterForChild):

  • rendering/RenderBlock.h:
3:22 PM Changeset in webkit [68695] by crogers@google.com
  • 5 edits in branches/audio/WebCore

audio branch: fixes for landing in trunk

  • AudioContext fix to avoid deleting very large number of AudioNodes all at once
  • HRTFPanner and DelayDSPKernel cleanup
3:11 PM Changeset in webkit [68694] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/JavaScriptCore

Merge r66119.

3:08 PM Changeset in webkit [68693] by mrowe@apple.com
  • 6 edits
    1 add in branches/safari-533.19-branch

Merge r65947.

3:06 PM Changeset in webkit [68692] by crogers@google.com
  • 2 edits in trunk/WebCore

2010-09-29 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Minor cleanup to AudioContext
​https://bugs.webkit.org/show_bug.cgi?id=46843

No new tests since audio API is not yet implemented

  • webaudio/AudioContext.cpp: (WebCore::AudioContext::lock): (WebCore::AudioContext::handleDeferredFinishDerefs):
3:06 PM Changeset in webkit [68691] by tony@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-09-29 Tony Chang <​tony@chromium.org>

Reviewed by James Robinson.

[chromium] enable -Werror on chromium linux webkit
​https://bugs.webkit.org/show_bug.cgi?id=46821

  • WebKit.gyp:
  • src/gtk/WebInputEventFactory.cpp:
3:02 PM Changeset in webkit [68690] by senorblanco@chromium.org
  • 3 edits in trunk

2010-09-29 MORITA Hajime <​morrita@google.com>

Reviewed by Eric Seidel.

Assertion failed when accessing -webkit-margin-top-collapse via computed style.
​https://bugs.webkit.org/show_bug.cgi?id=46798


There was a switch statement which missed enum entries in getPropertyCSSValue().
This change added these entries to prevent the leak.
It also added extra case statements to encourage the compiler's help.

Test: fast/css/getComputedStyle/margin-top-bottom-collapse-alias.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

2010-09-29 MORITA Hajime <​morrita@google.com>

Reviewed by Eric Seidel.

Assertion failed when accessing -webkit-margin-top-collapse via computed style.
​https://bugs.webkit.org/show_bug.cgi?id=46798

  • fast/css/getComputedStyle/margin-top-bottom-collapse-alias-expected.txt: Added.
  • fast/css/getComputedStyle/margin-top-bottom-collapse-alias.html: Added.
  • fast/css/getComputedStyle/script-tests/margin-top-bottom-collapse-alias.js: Added.
2:56 PM Changeset in webkit [68689] by crogers@google.com
  • 2 edits in trunk/WebCore

2010-09-29 Chris Rogers <​crogers@google.com>

Reviewed by Kenneth Russell.

Limit number of AudioNode deletions per render quantum in AudioContext
​https://bugs.webkit.org/show_bug.cgi?id=46834

No new tests since audio API is not yet implemented.

  • webaudio/AudioContext.cpp: (WebCore::AudioContext::handlePostRenderTasks): (WebCore::AudioContext::deleteMarkedNodes):
2:46 PM Changeset in webkit [68688] by mihaip@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-29 Mihai Parparita <​mihaip@chromium.org>

Unreviewed removal of unused #define from WebHistory.h.
Chromium usage of WEBKIT_BUG_40451_IS_FIXED was removed with
​http://crrev.com/50642.

  • public/WebHistoryItem.h:
2:45 PM Changeset in webkit [68687] by hyatt@apple.com
  • 5 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46838

Reviewed by Simon Fraser.

Get rid of the marginXXXUsing/setMarginXXXUsing methods on RenderBox. I'm inverting the way these are called
and putting the methods on RenderBlock instead. The methods can be named better this way and the getters
can operate on RenderBoxModelObjects instead of just RenderBoxes.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::marginBeforeForChild):
(WebCore::RenderBlock::marginAfterForChild):
(WebCore::RenderBlock::marginStartForChild):
(WebCore::RenderBlock::marginEndForChild):
(WebCore::RenderBlock::setMarginStartForChild):
(WebCore::RenderBlock::setMarginEndForChild):
(WebCore::RenderBlock::setMarginBeforeForChild):
(WebCore::RenderBlock::setMarginAfterForChild):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalHeightForChild):
(WebCore::RenderBlock::logicalTopForChild):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::marginBefore):
(WebCore::RenderBox::marginAfter):
(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginEnd):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::setMarginBefore):
(WebCore::RenderBox::setMarginAfter):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeBlockDirectionMargins):

  • rendering/RenderBox.h:

(WebCore::RenderBox::setMarginTop):
(WebCore::RenderBox::setMarginBottom):
(WebCore::RenderBox::setMarginLeft):
(WebCore::RenderBox::setMarginRight):

2:39 PM Changeset in webkit [68686] by andersca@apple.com
  • 14 edits
    2 adds in trunk/WebKit2

Implement more of PluginProxy and PLuginControllerProxy.

Reviewed by Sam Weinig.

  • Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::ArgumentDecoder::decodeBytes):

  • Platform/CoreIPC/ArgumentDecoder.h:

Add new overload that takes a DataReference. Wrap the debug function in #ifndef NDEBUG.

  • Platform/CoreIPC/ArgumentEncoder.cpp:
  • Platform/CoreIPC/ArgumentEncoder.h:

Wrap the debug function in #ifndef NDEBUG.

  • Platform/CoreIPC/Arguments.h:

Add new typedefs.

  • Platform/CoreIPC/DataReference.cpp:
  • Platform/CoreIPC/DataReference.h:

Add a DataReference class.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):
Add new overload.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::didEvaluateJavaScript):
(WebKit::PluginControllerProxy::streamDidReceiveResponse):
(WebKit::PluginControllerProxy::streamDidReceiveData):
(WebKit::PluginControllerProxy::streamDidFinishLoading):
(WebKit::PluginControllerProxy::streamDidFail):
call Plugin member functions.

  • PluginProcess/PluginControllerProxy.messages.in:

Add new messages.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add DataReference.cpp and DataReference.h

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::didEvaluateJavaScript):
(WebKit::PluginProxy::streamDidReceiveResponse):
(WebKit::PluginProxy::streamDidReceiveData):
(WebKit::PluginProxy::streamDidFinishLoading):
(WebKit::PluginProxy::streamDidFail):
Send messages.

2:21 PM Changeset in webkit [68685] by senorblanco@chromium.org
  • 10 edits in trunk/LayoutTests

2010-09-29 Stephen White <​senorblanco@chromium.org>

Unreviewed; updated test results.

[CHROMIUM] New test results after r68680.

  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
2:12 PM Changeset in webkit [68684] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Update expected results.

  • Scripts/webkit2/messages_unittest.py:
2:12 PM Changeset in webkit [68683] by mitz@apple.com
  • 3 edits in trunk/WebCore

Removed input type site-specific quirk for mail.google.com
​https://bugs.webkit.org/show_bug.cgi?id=46836

Reviewed by Sam Weinig.

  • bindings/js/JSHTMLInputElementCustom.cpp:

(WebCore::needsGmailQuirk): Removed.
(WebCore::JSHTMLInputElement::type): Removed this custom getter.

  • html/HTMLInputElement.idl: Removed the JSCCustomGetter custom attribute

from the type attribute.

1:56 PM Changeset in webkit [68682] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-09-29 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Simon Fraser.

CRASH at WebCore::HTMLSourceElement::scheduleErrorEvent
​https://bugs.webkit.org/show_bug.cgi?id=46777

It should not be possible to get to be in the LoadingFromSourceElement
state with a null current source node. This was a possible scenario
where the current source node was cleared but the load state was not
cleared as well. Tried and could not create a test case for this.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::userCancelledLoad): clear the load state because we also clear the current source node.
1:12 PM Changeset in webkit [68681] by hyatt@apple.com
  • 9 edits in trunk

WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=46835, patch a few more height/logicalHeights. Rename stretchesToViewHeight.

Reviewed by Dan Bernstein.

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeight):

  • rendering/RenderBox.h:

(WebCore::RenderBox::stretchesToViewport):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::relativePositionOffsetY):

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=46835, patch a few more height/logicalHeights.

Reviewed by Dan Bernstein.

  • platform/mac/fast/blockflow/root-lr-basic-expected.txt:
12:59 PM Changeset in webkit [68680] by Chris Fleizach
  • 19 edits
    2 adds in trunk

AX: implement CSS3 Speech "speak"
​https://bugs.webkit.org/show_bug.cgi?id=46827

Reviewed by Darin Adler.

WebCore:

Support the "speak" style as defined in
​http://www.w3.org/TR/css3-speech/#speak

This puts all the pieces in place for a platform to support this ability, but there's no platform implementation yet.

Test: platform/mac/accessibility/css-speech-speak.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::speakProperty):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::speakProperty):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ESpeak):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::speak):
(WebCore::InheritedFlags::setSpeak):
(WebCore::InheritedFlags::initialSpeak):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(speakCallback):
(AccessibilityUIElement::speak):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::speak):

LayoutTests:

  • platform/mac/accessibility/css-speech-speak-expected.txt: Added.
  • platform/mac/accessibility/css-speech-speak.html: Added.
12:33 PM Changeset in webkit [68679] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-09-29 João Paulo Rechi Vita <​jprvita@profusion.mobi>

Reviewed by Antonio Gomes.

[Curl] Fix unused and unitialized warnings.
​https://bugs.webkit.org/show_bug.cgi?id=46831

No new tests since no new funcionality has been added.

  • platform/network/curl/ResourceHandleCurl.cpp: (WebCore::allowsAnyHTTPSCertificateHosts):
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::handleLocalReceiveResponse): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::initializeHandle):
12:32 PM Changeset in webkit [68678] by hyatt@apple.com
  • 6 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=46824

Reviewed by Sam Weinig.

Convert layoutBlockChild (but not the functions it calls) to be block-flow-aware.

fast/blockflow/root-lr.html progresses as a result of this change.

WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::setLogicalTopForChild):
(WebCore::RenderBlock::layoutBlockChild):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalHeightForChild):
(WebCore::RenderBlock::logicalTopForChild):

  • rendering/RenderBox.h:

LayoutTests:

  • platform/mac/fast/blockflow/root-lr-basic-expected.txt:
12:17 PM Changeset in webkit [68677] by andersca@apple.com
  • 11 edits in trunk/WebKit2

Implement LoadURL
​https://bugs.webkit.org/show_bug.cgi?id=46826

Reviewed by Sam Weinig.

  • Platform/CoreIPC/ArgumentCoders.h:

Move String argument coder here from WebCoreArgumentCoders.h. Add
argument coder for AtomicString.

  • Platform/CoreIPC/Arguments.h:

Add typedefs for Arguments7.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):
Add handleMessage overload that takes 7 parameters.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::loadURL):
Send the LoadURL message.

  • Scripts/webkit2/messages.py:

(parse_parameter_string): Use rsplit in case the type name contains spaces.
(argument_coder_headers_for_type): Special case Vector.

  • Scripts/webkit2/messages_unittest.py:

Update results.

  • Shared/WebCoreArgumentCoders.h:

Add argument coder for HTTPHeaderMap.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::loadURL):
Ask the plug-in controller to load the URL.

  • WebProcess/Plugins/PluginProxy.messages.in:

Add LoadURL message.

12:12 PM Changeset in webkit [68676] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-29 Stephen White <​senorblanco@chromium.org>

Unreviewed; test expectations fix.

[CHROMIUM] Update test_expectations to better reflect the state of the
build.

  • platform/chromium/test_expectations.txt:
12:08 PM Changeset in webkit [68675] by kinuko@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-29 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed, adding one more missing change from the last patch.
​https://bugs.webkit.org/show_bug.cgi?id=46524

  • WebKit.gyp:
12:08 PM Changeset in webkit [68674] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk/po

2010-09-29 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

Avoid touching the po files automatically during the build
process. The maintainers still have the option of forcing an
update with make update-po.

  • GNUmakefile.am:
12:07 PM Changeset in webkit [68673] by mihaip@chromium.org
  • 11 edits
    1 copy in trunk/WebKitTools

2010-09-29 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Adam Barth.

Record bot ID when updating queue status
​https://bugs.webkit.org/show_bug.cgi?id=46764

Since we now have multiple bots handling patches from the commit queue,
we need to differentiate status updates from them, so that we can group
the queue status page in a less confusing way.

  • QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
  • QueueStatusServer/model/queuestatus.py: Add bot_id property
  • QueueStatusServer/templates/updatestatus.html: Add bot_id input
  • Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
  • Scripts/webkitpy/common/net/statusserver.py: Add bot_id
  • Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
  • Scripts/webkitpy/tool/main.py: Add --bot-id
  • Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
12:04 PM Changeset in webkit [68672] by kinuko@chromium.org
  • 1 edit
    2 adds in trunk/WebKit/chromium

2010-09-29 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed, adding the new files that were supposed to be added
but I missed to include in my previous patch.
​https://bugs.webkit.org/show_bug.cgi?id=46524

  • src/WorkerAsyncFileSystemChromium.cpp: Added.
  • src/WorkerAsyncFileSystemChromium.h: Added.
11:47 AM Changeset in webkit [68671] by rniwa@webkit.org
  • 2 edits in trunk

Fixed reviewer names.

11:44 AM Changeset in webkit [68670] by rniwa@webkit.org
  • 5 edits
    3 adds in trunk

2010-09-29 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

queryCommandValue "formatBlock" always returns false
​https://bugs.webkit.org/show_bug.cgi?id=21305

Implemented queryCommandValue('formatBlock'). We match the Firefox's behavior exactly
because Firefox and Internet Explorer support the same set of elements
(address, h1, h2, h3, h4, h5, h6, and p) and Firefox's behavior is more compatible with Opera.
See the bug for the detailed discussion.

WebKit's implementation returns the local name of the lowest common ancestor
of the selection with the tag name address, h1, h2, h3, h4, h5, h6, or p.
It returns "" when there is no such an ancestor or there is no selection.

Test: editing/execCommand/query-format-block.html

  • editing/Editor.cpp: (WebCore::isElementForFormatBlockCommand): (WebCore::Editor::elementForFormatBlockCommand):
  • editing/Editor.h:
  • editing/EditorCommand.cpp: (WebCore::valueFormatBlock): (WebCore::createCommandMap):

2010-09-29 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

queryCommandValue "formatBlock" always returns false
​https://bugs.webkit.org/show_bug.cgi?id=21305

Added a test for queryCommandValue('formatBlock').

  • editing/execCommand/query-format-block-expected.txt: Added.
  • editing/execCommand/query-format-block.html: Added.
  • editing/execCommand/script-tests/query-format-block.js: Added. (queryFormatBlock): (selectFirstPosition): (selectMiddleOfHelloWorld):
11:12 AM Changeset in webkit [68669] by kinuko@chromium.org
  • 9 edits in trunk/WebKit/chromium

2010-09-29 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Bridge all FileSystem operations on Workers to the MainThread
​https://bugs.webkit.org/show_bug.cgi?id=46524

  • src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::requestFileSystem): Changed the worker case code to create WebFileSystemCallbacksImpl with the current ScriptExecutionContext (WorkerContext).
  • src/WebFileSystemCallbacksImpl.cpp: (WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl): Added a new constructor that takes ScriptExecutionContext (WorkerContext) for workers. (WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem): Added the code for workers that creates WorkerAsyncFileSystemChromium.
  • src/WebFileSystemCallbacksImpl.h:
  • src/WorkerAsyncFileSystemChromium.cpp: Added.
  • src/WorkerAsyncFileSystemChromium.h: Added.
  • src/WorkerFileSystemCallbacksBridge.cpp: Added methods for regular file system operations to proxy them to the main thread. (WebKit::WorkerFileSystemCallbacksBridge::createForOpenFileSystem): (WebKit::WorkerFileSystemCallbacksBridge::createForMove): (WebKit::WorkerFileSystemCallbacksBridge::createForCopy): (WebKit::WorkerFileSystemCallbacksBridge::createForRemove): (WebKit::WorkerFileSystemCallbacksBridge::createForReadMetadata): (WebKit::WorkerFileSystemCallbacksBridge::createForCreateFile): (WebKit::WorkerFileSystemCallbacksBridge::createForCreateDirectory): (WebKit::WorkerFileSystemCallbacksBridge::createForFileExists): (WebKit::WorkerFileSystemCallbacksBridge::createForDirectoryExists): (WebKit::WorkerFileSystemCallbacksBridge::createForReadDirectory): (WebKit::MainThreadFileSystemCallbacks::didSucceed): (WebKit::MainThreadFileSystemCallbacks::didReadMetadata): (WebKit::MainThreadFileSystemCallbacks::didReadDirectory): (WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::moveOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::copyOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::removeOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::readMetadataOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::createFileOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::createDirectoryOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::fileExistsOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::directoryExistsOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::readDirectoryOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didSucceedOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didReadMetadataOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didReadDirectoryOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didSucceedOnWorkerThread): (WebKit::WorkerFileSystemCallbacksBridge::didReadMetadataOnWorkerThread): (WebKit::WorkerFileSystemCallbacksBridge::didReadDirectoryOnWorkerThread): (WebKit::WorkerFileSystemCallbacksBridge::derefIfWorkerIsStopped):
  • src/WorkerFileSystemCallbacksBridge.h:
11:08 AM Changeset in webkit [68668] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/gtk/po

2010-09-29 Miloš Popović <​gpopac@gmail.com>

Reviewed by Gustavo Noronha Silva.

Serbian translations update.

11:01 AM Changeset in webkit [68667] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/517

Merge 68485

BUG=56621
Review URL: ​http://codereview.chromium.org/3520007

11:01 AM Changeset in webkit [68666] by mpcomplete@chromium.org
  • 7 edits in trunk

2010-09-29 Matt Perry <​mpcomplete@chromium.org>

Reviewed by Darin Fisher.

Remove obsolete registerExtension variants from chromium port.
​https://bugs.webkit.org/show_bug.cgi?id=46683

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::registeredExtensionWithV8): (WebCore::V8Proxy::registerExtension):
  • bindings/v8/V8Proxy.h:

2010-09-29 Matt Perry <​mpcomplete@chromium.org>

Reviewed by Darin Fisher.

Remove obsolete registerExtension variants from chromium port.
​https://bugs.webkit.org/show_bug.cgi?id=46683

  • public/WebScriptController.h:
  • src/WebScriptController.cpp:
10:58 AM Changeset in webkit [68665] by Martin Robinson
  • 5 edits in trunk

2010-09-29 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Chris Fleizach.

[GTK] editing/selection/selection-modify-crash.html crashes when run in Xvfb
​https://bugs.webkit.org/show_bug.cgi?id=46822

  • platform/gtk/Skipped: Unskip a test which is no longer crashing.

2010-09-29 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Chris Fleizach.

[GTK] editing/selection/selection-modify-crash.html crashes when run in Xvfb
​https://bugs.webkit.org/show_bug.cgi?id=46822

When parentObjectUnignored returns null in objectAndOffsetUnignored consider that
a failure case. Handle this failure appropriately at all call sites.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_caret_offset): Handle the failure of objectAndOffsetUnignored. (objectAndOffsetUnignored): Always check the return value of parentObjectUnignored and return 0 to indicate failure when that happens.
  • editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange): Handle the failure case of objectAndOffsetUnignored.
10:56 AM Changeset in webkit [68664] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/517

Merge 68408

BUG=56692
Review URL: ​http://codereview.chromium.org/3559003

10:52 AM Changeset in webkit [68663] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/517

Merge 68340

BUG=56796
Review URL: ​http://codereview.chromium.org/3521003

10:46 AM Changeset in webkit [68662] by andersca@apple.com
  • 12 edits in trunk/WebKit2

Handle getting the user agent in the plug-in process
​https://bugs.webkit.org/show_bug.cgi?id=46819

Reviewed by Sam Weinig.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):
Add new handleMessage overload.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::create):
(WebKit::PluginControllerProxy::PluginControllerProxy):
Pass the user agent to the plug-in controller proxy.

(WebKit::PluginControllerProxy::userAgent):
Return the user agent.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::createPlugin):
Pass the user agent when creating the plug-in controller proxy.

  • PluginProcess/WebProcessConnection.messages.in:

Add userAgent.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::userAgent):

  • WebProcess/Plugins/PluginController.h:

Remove the URL parameter to userAgent.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::initialize):
Pass the user agent to WebProcessConnection::CreatePlugin.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::userAgent):
Remove url parameter.

10:46 AM Changeset in webkit [68661] by commit-queue@webkit.org
  • 14 edits
    2 deletes in trunk/WebCore

2010-09-29 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r68657.
​http://trac.webkit.org/changeset/68657
​https://bugs.webkit.org/show_bug.cgi?id=46820

reason "Breaks win debug build" (Requested by podivilov on
#webkit).

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::sendCallback):
  • dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent):
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::parserInsertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::parserAddChild): (WebCore::notifyChildInserted): (WebCore::dispatchChildRemovalEvents):
  • dom/Element.cpp: (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::willInsertDOMNodeImpl): (WebCore::InspectorController::didInsertDOMNodeImpl): (WebCore::InspectorController::willRemoveDOMNodeImpl): (WebCore::InspectorController::didRemoveDOMNodeImpl): (WebCore::InspectorController::willModifyDOMAttrImpl): (WebCore::InspectorController::didModifyDOMAttrImpl): (WebCore::InspectorController::characterDataModifiedImpl): (WebCore::InspectorController::instrumentWillSendXMLHttpRequestImpl):
  • inspector/InspectorController.h: (WebCore::InspectorController::willInsertDOMNode): (WebCore::InspectorController::didInsertDOMNode): (WebCore::InspectorController::willRemoveDOMNode): (WebCore::InspectorController::willModifyDOMAttr): (WebCore::InspectorController::didModifyDOMAttr): (WebCore::InspectorController::characterDataModified): (WebCore::InspectorController::instrumentWillSendXMLHttpRequest): (WebCore::InspectorController::inspectorControllerForScriptExecutionContext): (WebCore::InspectorController::inspectorControllerForNode): (WebCore::InspectorController::inspectorControllerForDocument):
  • inspector/InspectorInstrumentation.cpp: Removed.
  • inspector/InspectorInstrumentation.h: Removed.
  • workers/SharedWorker.cpp:
10:32 AM Changeset in webkit [68660] by xji@chromium.org
  • 2 edits in trunk/WebCore

2010-09-29 Xiaomei Ji <​xji@chromium.org>

Reviewed by David Levin.

Performance improvement for FontLinux.
​https://bugs.webkit.org/show_bug.cgi?id=46374

Reduce new/delete operations by storing the maximum capacity of the glyph
array and use that value in subsequent HB_ShapeItem calls. (Note that a
call to HB_ShapeItem may reduce the value of m_item.num_glyphs below the
capacity.)

Also be consistent with zero'ing the glyph arrays before calling
HB_ShapeItem.

There is no functionality changes so no new tests are added.

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::createGlyphArrays): (WebCore::TextRunWalker::resetGlyphArrays): (WebCore::TextRunWalker::shapeGlyphs):
10:23 AM Changeset in webkit [68659] by andersca@apple.com
  • 9 edits in trunk

Implement more PluginProxy member functions
​https://bugs.webkit.org/show_bug.cgi?id=46815

Reviewed by Sam Weinig.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::handleMouseEvent):
(WebKit::PluginControllerProxy::handleWheelEvent):
(WebKit::PluginControllerProxy::handleMouseEnterEvent):
(WebKit::PluginControllerProxy::handleMouseLeaveEvent):
(WebKit::PluginControllerProxy::setFocus):
(WebKit::PluginControllerProxy::windowFocusChanged):
(WebKit::PluginControllerProxy::windowFrameChanged):
(WebKit::PluginControllerProxy::windowVisibilityChanged):
Call the appropriate Plugin member functions.

  • PluginProcess/PluginControllerProxy.messages.in:

Add new messages.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::didReceiveMessage):
It's OK to get a message for a plug-in controller proxy that has gone away.

(WebKit::WebProcessConnection::didReceiveSyncMessage):
Forward the message to the PluginControllerProxy handler.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::handleMouseEvent):
(WebKit::PluginProxy::handleWheelEvent):
(WebKit::PluginProxy::handleMouseEnterEvent):
(WebKit::PluginProxy::handleMouseLeaveEvent):
(WebKit::PluginProxy::setFocus):
(WebKit::PluginProxy::windowFocusChanged):
(WebKit::PluginProxy::windowFrameChanged):
(WebKit::PluginProxy::windowVisibilityChanged):
Send messages to the plug-in process.

(WebKit::PluginProxy::controller):
Return the plug-in controller.

10:19 AM Changeset in webkit [68658] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-09-29 Chris Guillory <​chris.guillory@google.com>

Reviewed by Dimitri Glazkov.

Add method which checks if a WebAccessibilityObject is in the cache.
​https://bugs.webkit.org/show_bug.cgi?id=46605

  • public/WebAccessibilityCache.h:
  • src/WebAccessibilityCacheImpl.cpp: (WebKit::WebAccessibilityCacheImpl::isCached):
  • src/WebAccessibilityCacheImpl.h:
10:19 AM Changeset in webkit [68657] by podivilov@chromium.org
  • 14 edits
    2 adds in trunk/WebCore

2010-09-29 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract Inspector Instrumentation API as a class.
​https://bugs.webkit.org/show_bug.cgi?id=46614

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::sendCallback):
  • dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent):
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::parserInsertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::parserAddChild): (WebCore::notifyChildInserted): (WebCore::dispatchChildRemovalEvents):
  • dom/Element.cpp: (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::instrumentWillSendXMLHttpRequest):
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: Added. (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::characterDataModifiedImpl): (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequestImpl):
  • inspector/InspectorInstrumentation.h: Added. (WebCore::InspectorInstrumentation::frontendCreated): (WebCore::InspectorInstrumentation::frontendDeleted): (WebCore::InspectorInstrumentation::hasFrontends): (WebCore::InspectorInstrumentation::willInsertDOMNode): (WebCore::InspectorInstrumentation::didInsertDOMNode): (WebCore::InspectorInstrumentation::willRemoveDOMNode): (WebCore::InspectorInstrumentation::willModifyDOMAttr): (WebCore::InspectorInstrumentation::didModifyDOMAttr): (WebCore::InspectorInstrumentation::characterDataModified): (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequest): (WebCore::InspectorInstrumentation::inspectorControllerForScriptExecutionContext): (WebCore::InspectorInstrumentation::inspectorControllerForDocument): (WebCore::InspectorInstrumentation::inspectorControllerForPage):
10:15 AM Changeset in webkit [68656] by commit-queue@webkit.org
  • 7 edits in trunk

2010-09-29 Anantanarayanan G Iyengar <​ananta@chromium.org>

Reviewed by Darin Fisher.

[chromium] Honor z-index specified by a plugin
​https://bugs.webkit.org/show_bug.cgi?id=46223

The Chromium plugin code which implements the iframe shim technique
for overlaying a windowed plugin with content on the page should
honor the z-index specified on the plugin widget. If the z-index
here is greater than the enclosing iframe shim then the plugin
should be displayed over the iframe. Updated the layout test to test
for this case. Skipped the plugins/iframe-shims.html layout test on
platforms which don't support it.

  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • plugins/iframe-shims.html:

2010-09-29 Anantanarayanan G Iyengar <​ananta@chromium.org>

Reviewed by Darin Fisher.

[chromium] Honor z-index specified by a plugin
​https://bugs.webkit.org/show_bug.cgi?id=46223

The Chromium plugin code which implements the iframe shim technique
for overlaying a windowed plugin with content on the page should
honor the z-index specified on the plugin widget. If the z-index
here is greater than the enclosing iframe shim then the plugin
should be displayed over the iframe. Updated the layout test to test
for this case. Skipped the plugins/iframe-shims.html layout test on
platforms which don't support it.

  • src/WebPluginContainerImpl.cpp:
10:10 AM Changeset in webkit [68655] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-09-29 Simon Fraser <Simon Fraser>

No review.

References always refert to a file in .xht format, even
for HTML tests, so fix their loading.

  • CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.loadRef):
10:00 AM Changeset in webkit [68654] by hyatt@apple.com
  • 4 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=46786, convert layoutBlockChild (but not any functions it calls)
to be block-flow-aware.

Reviewed by Sam Weinig.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::handleAfterSideOfBlock):
(WebCore::RenderBlock::layoutBlockChildren):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.h:

(WebCore::RenderBox::scrollbarLogicalHeight):

9:46 AM Changeset in webkit [68653] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-09-29 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Don't keep local reference to QGraphicsItemOverlay in QGWVPrivate
​https://bugs.webkit.org/show_bug.cgi?id=46812

Get the QGraphicsItemOverlay* via the QWebPageClient (d->page->d->client)
instead of keeping a local pointer to it.

This is cleanup for a follow-up patch.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::overlay): (QGraphicsWebView::paint): (QGraphicsWebView::setPage): (QGraphicsWebView::updateGeometry): (QGraphicsWebView::setGeometry):
9:43 AM Changeset in webkit [68652] by commit-queue@webkit.org
  • 4 edits in trunk

2010-09-29 João Paulo Rechi Vita <​jprvita@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] General small fixes.
​https://bugs.webkit.org/show_bug.cgi?id=46813

This commit spots a comparison between signed and unsigned integer
expressions, a missing return and a never-called function.

No new tests since no new funcionality has been added.

  • platform/efl/SharedBufferEfl.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):

2010-09-29 João Paulo Rechi Vita <​jprvita@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] General small fixes.
​https://bugs.webkit.org/show_bug.cgi?id=46813

This commit spots a comparison between signed and unsigned integer
expressions, a missing return and a never-called function.

  • WebCoreSupport/FullscreenVideoControllerEfl.cpp: (FullscreenVideoController::canPlay):
9:31 AM Changeset in webkit [68651] by commit-queue@webkit.org
  • 10 edits in trunk/JavaScriptCore/qt

2010-09-29 Caio Marcelo de Oliveira Filho <​caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] QScriptEngine should have an API for creating Date objects
​https://bugs.webkit.org/show_bug.cgi?id=41667

Implement newDate(), isDate() and toDateTime() functions. Use the
QDateTime::{to,set}MSecsSinceEpoch() functions to do the
calculations.

  • api/qscriptengine.cpp: (QScriptEngine::newDate):
  • api/qscriptengine.h:
  • api/qscriptengine_p.cpp: (QScriptEnginePrivate::newDate):
  • api/qscriptengine_p.h: (QScriptEnginePrivate::isDate):
  • api/qscriptoriginalglobalobject_p.h: (QScriptOriginalGlobalObject::QScriptOriginalGlobalObject): need to keep track of Date Constructor and Prototype. (QScriptOriginalGlobalObject::~QScriptOriginalGlobalObject): ditto. (QScriptOriginalGlobalObject::isDate): use the Date Constructor and Prototype to identify Date values.
  • api/qscriptvalue.cpp: (QScriptValue::isDate): (QScriptValue::toDateTime):
  • api/qscriptvalue.h:
  • api/qscriptvalue_p.h: (QScriptValuePrivate::isDate): (QScriptValuePrivate::toDateTime):
  • tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::newDate):
9:06 AM Changeset in webkit [68650] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-09-29 Philippe Normand <​pnormand@igalia.com>

Unreviewed, updated baselines of
svg/css/getComputedStyle-basic.xhtml after the css properties
were renamed in r68561.

  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
8:55 AM Changeset in webkit [68649] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-09-29 Patrick Gansterer <Patrick Gansterer>

Unreviewed.

Next try to fix cygwin build.

  • wtf/Assertions.cpp:
8:44 AM Changeset in webkit [68648] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-09-29 Patrick Gansterer <Patrick Gansterer>

Unreviewed.

Build fix for cygwin #2. Oops, it's OS(WINDOWS), not OS(WIN).

  • wtf/Assertions.cpp:
8:35 AM Changeset in webkit [68647] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-09-29 Patrick Gansterer <Patrick Gansterer>

Unreviewed.

Build fix for cygwin.

  • wtf/Assertions.cpp:
8:34 AM Changeset in webkit [68646] by Adam Roben
  • 2 edits in trunk/WebKit2

Look for WebKit.dll (not WebKit_debug.dll) when launching the web process in Debug builds

Fixes <​http://webkit.org/b/46809> <rdar://problem/8491809> REGRESSION
(r67979): All tests crashing on Windows WebKit2 test bot

Reviewed by Sam Weinig.

  • UIProcess/Launcher/win/ProcessLauncherWin.cpp: WebKit_debug.dll is

only used in Debug_All builds (but WebKit2WebProcess_debug.exe is used
in all non-Debug_Internal debug-style builds).

8:11 AM Changeset in webkit [68645] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-09-29 Philippe Normand <​pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

build still broken since r68521
​https://bugs.webkit.org/show_bug.cgi?id=46795

Call make-values.pl once only. It seems calling it multiple times
in the same build produces a wrong CSSValueKeywordsHash.h which
has a duplicate declaration of its valueList variable. The double
call is triggered by the double targets in the Makefile rules and
makevalues.pl generates one of them, which screws up the build. A
more proper fix should be done with the advices on
​http://www.cmcrossroads.com/cm-basics/12905-rules-with-multiple-outputs-in-gnu-make

  • GNUmakefile.am:
8:06 AM Changeset in webkit [68644] by Patrick Gansterer
  • 3 edits in trunk/JavaScriptCore

2010-09-29 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WINCE] Buildfix for Assertions.cpp after r68511.
​https://bugs.webkit.org/show_bug.cgi?id=46807

Some, but not all WinCE environments have support for IsDebuggerPresent().
Add HAVE(ISDEBUGGERPRESENT) to make this a build option.
HAVE(ISDEBUGGERPRESENT) will be 1 for all OS(WIN) by default.

  • wtf/Assertions.cpp:
  • wtf/Platform.h:
7:46 AM Changeset in webkit [68643] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-29 João Paulo Rechi Vita <​jprvita@profusion.mobi>

Unreviewed build fix.

Fix CMake build for ENABLE_PROGRESS_TAG.
​https://bugs.webkit.org/show_bug.cgi?id=46808

No new tests since it's a build fix.

  • CMakeLists.txt:
6:56 AM Changeset in webkit [68642] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk/po

2010-09-29 Reinout van Schouwen <​reinouts@gnome.org>

Reviewed by Gustavo Noronha.

[GTK] Updated Dutch translation
​https://bugs.webkit.org/show_bug.cgi?id=46050

  • nl.po:
6:46 AM Changeset in webkit [68641] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-09-29 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Use generic mechanism to report exceptions in V8CustomVoidCallback
​https://bugs.webkit.org/show_bug.cgi?id=46803

No new tests. It's covered by existing tests under LayoutTests/storage

  • bindings/v8/custom/V8CustomVoidCallback.cpp: (WebCore::invokeCallback):
6:45 AM Changeset in webkit [68640] by satish@chromium.org
  • 14 edits in trunk

2010-09-29 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Rename the input element's @speech attribute to @webkitspeech since it is still experimental.
​https://bugs.webkit.org/show_bug.cgi?id=46799

  • fast/speech/input-appearance-numberandspeech.html:
  • fast/speech/input-appearance-searchandspeech.html:
  • fast/speech/input-appearance-speechbutton.html:
  • fast/speech/input-text-speechbutton.html:
  • fast/speech/speech-button-ignore-generated-events.html:

2010-09-29 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Rename the input element's @speech attribute to @webkitspeech since it is still experimental.
​https://bugs.webkit.org/show_bug.cgi?id=46799

  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::webkitspeechEnabled): Rename the runtime feature flag getter.
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  • css/CSSValueKeywords.in: Rename the css style name.
  • css/html.css: Rename the css style name. (input::-webkit-input-speech-button):
  • html/HTMLAttributeNames.in: Rename the @speech attribute.
  • html/HTMLInputElement.cpp: Update code using the attribute. (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::isSpeechEnabled):
  • html/HTMLInputElement.idl: Rename the @speech attribute.
5:45 AM Changeset in webkit [68639] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-29 Peter Varga <​pvarga@inf.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

JSC compile fails on 32bit platform when Regexp Tracing is enabled
​https://bugs.webkit.org/show_bug.cgi?id=46713

Fix the cast of pointer in regexp tracing to avoid the warning.

  • runtime/RegExp.cpp: (JSC::RegExp::match):
5:17 AM Changeset in webkit [68638] by morrita@google.com
  • 3 edits
    1 add in trunk/WebCore

2010-09-29 MORITA Hajime <​morrita@google.com>

[Chromium] failed to build without ACCELERATED_COMPOSITING
​https://bugs.webkit.org/show_bug.cgi?id=46793

Moved constant definitions from inside ACCELERATED_COMPOSITING to
outside of the condition.

  • WebCore.gypi:
  • platform/graphics/chromium/VideoFrameChromium.cpp: Added just for defining constants.
  • platform/graphics/chromium/VideoLayerChromium.cpp:
3:35 AM Changeset in webkit [68637] by Simon Hausmann
  • 2 edits in trunk

[Qt] Fix the build on non-x86 platforms with gcc

Reviewed by Csaba Osztrogonác.

Don't disable -Werror on arm, that doesn't work when QT_ARCH is
for example armv6. Instead change the condition as the comment says,
enable -Werror on x86/gcc where we know it passes. On other platforms
gcc produces difference warnings, and when they're fixed we can add
them to the whitelist of -Werror-supported architectures.

  • WebKit.pri:
2:14 AM Changeset in webkit [68636] by pfeldman@chromium.org
  • 10 edits
    3 adds in trunk/WebCore

2010-09-28 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: [Resources panel] Need more visible "at a glance".
​https://bugs.webkit.org/show_bug.cgi?id=45657

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid): (WebInspector.DataGrid.prototype.updateWidths): (WebInspector.DataGrid.prototype.sortNodes): (WebInspector.DataGrid.prototype._resizerDragging): (WebInspector.DataGrid.prototype._endResizerDragging): (WebInspector.DataGridNode.prototype.selectable.true.get element): (WebInspector.DataGridNode.prototype.createCells): (WebInspector.DataGridNode.prototype.refresh):
  • inspector/front-end/Images/networkIcon.png: Copied from WebCore/inspector/front-end/Images/resourcesIcon.png.
  • inspector/front-end/NetworkPanel.js: Added.
  • inspector/front-end/Settings.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.toolbar-item.network .toolbar-icon): (.data-grid .data-container):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels): (WebInspector.updateResource):
  • inspector/front-end/networkPanel.css: Added.
12:59 AM Changeset in webkit [68635] by loislo@chromium.org
  • 7 edits in trunk/WebCore

2010-09-28 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move pauseOnExceptionState under control of InspectorState
It is Inspector Protocol cleanup activity.
The actual state of this flag can be obtained as a return value of setPauseOnExceptionState command
or as a value in InspectorState object.

​https://bugs.webkit.org/show_bug.cgi?id=46724

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::getInspectorState): (WebCore::InspectorController::populateScriptObjects):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState): (WebCore::InspectorDebuggerAgent::pauseOnExceptionsState):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
  • inspector/front-end/inspector.js: (WebInspector.doLoadedDone.populateInspectorState): (WebInspector.doLoadedDone): (WebInspector.reportProtocolError):
12:09 AM Changeset in webkit [68634] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-29 James Kozianski <​koz@chromium.org>

Reviewed by James Robinson.

Update test_expectations.txt from the flakiness dashboard.
​https://bugs.webkit.org/show_bug.cgi?id=46787

Updates some canvas/philip tests in test_expectations.txt that have
started passing on the flakiness dashboard.

  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.