Timeline
Oct 31, 2010:
- 11:35 PM Changeset in webkit [71009] by
-
- 10 edits2 adds in trunk/WebCore
2010-10-26 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
Refactoring: Spellchecking related static functions could form a class
https://bugs.webkit.org/show_bug.cgi?id=48287
Extracted spellcheck related static functions to TextCheckingHelper class,
which has EditorClient and Range as its member.
No new tests. Just a refactoring.
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- editing/EditingAllInOne.cpp
- editing/Editor.cpp: (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::Editor::markMisspellingsOrBadGrammar): (WebCore::Editor::markMisspellings): (WebCore::Editor::markBadGrammar): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::changeBackToReplacedString):
- editing/Editor.h:
- editing/TextCheckingHelper.cpp: Added. (WebCore::TextCheckingHelper::TextCheckingHelper): (WebCore::TextCheckingHelper::~TextCheckingHelper): (WebCore::TextCheckingHelper::paragraphAlignedRange): (WebCore::TextCheckingHelper::findFirstMisspelling): (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): (WebCore::TextCheckingHelper::findFirstGrammarDetail): (WebCore::TextCheckingHelper::findFirstBadGrammar): (WebCore::TextCheckingHelper::isUngrammatical): (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): (WebCore::TextCheckingHelper::markAllMisspellings): (WebCore::TextCheckingHelper::markAllBadGrammar):
- editing/TextCheckingHelper.h: Added.
- 9:21 PM Changeset in webkit [71008] by
-
- 2 edits in trunk/WebCore
2010-10-31 Xan Lopez <xlopez@igalia.com>
Try to fix the GTK+ build.
Do not use broken/deprecated functions that won't be available
with G_DISABLE_DEPRECATED (used in debug builds).
- plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo):
- 7:54 PM Changeset in webkit [71007] by
-
- 2 edits in trunk/WebCore
2010-10-31 Kenichi Ishibashi <bashi@google.com>
Reviewed by Adam Barth.
V8 binding for DOMSettableTokenList
https://bugs.webkit.org/show_bug.cgi?id=47812
Tests for this change will be included in the change for supporting
the <output> element.
See https://bugs.webkit.org/show_bug.cgi?id=29363.
- bindings/v8/custom/V8DOMSettableTokenListCustom.cpp: Implemented. (WebCore::V8DOMSettableTokenList::indexedPropertyGetter): Just calls DOMSettableTokenList::item(index).
- 7:48 PM Changeset in webkit [71006] by
-
- 5 edits in trunk
2010-10-31 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] [Gtk] Plug-ins having upper case in mime type are failing to load
Qt and Gtk are case-sensitive when storing the declared mime-type
of plugins. Since plugin mime-types are lowercased prior to searching
for them in the plugin database, ensure they are loaded with the
mime-type in lower case too.
- plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo):
- plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::setMIMEDescription):
2010-10-31 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] [Gtk] Plug-ins having upper case in mime type are failing to load
Qt and Gtk are case-sensitive when storing the declared mime-type
of plugins. Since plugin mime-types are lowercased prior to searching
for them in the plugin database, ensure they are loaded with the
mime-type in lower case too.
Change the test netscape plugin to declare its mimetype in sentence
case so that the correct behaviour is enforced.
- DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (NP_GetMIMEDescription):
- 7:37 PM Changeset in webkit [71005] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-10-31 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Ojan Vafai.
Add layout test to make sure we don't regress truncation of an rtl block.
- fast/block/basic/truncation-rtl.html: Added.
- platform/mac/fast/block/basic/truncation-rtl-expected.checksum: Added.
- platform/mac/fast/block/basic/truncation-rtl-expected.png: Added.
- platform/mac/fast/block/basic/truncation-rtl-expected.txt: Added.
- 7:30 PM Changeset in webkit [71004] by
-
- 10 edits in trunk
2010-10-31 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Support nodesFromRect in DRT
Unskip fast/dom/nodesFromRect-basic.html
- platform/qt/Skipped:
2010-10-31 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Support nodesFromRect in DRT
Pass a Document object as a QWebElement.
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant):
2010-10-31 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Support nodesFromRect in DRT
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::nodesFromRect):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
2010-10-31 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Support nodesFromRect in DRT
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::nodesFromRect):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 7:20 PM Changeset in webkit [71003] by
-
- 2 edits in trunk/LayoutTests
2010-10-31 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Antonio Gomes.
[GTK] Add bug ID for skipped <meter> tests
https://bugs.webkit.org/show_bug.cgi?id=48714
- platform/gtk/Skipped:
- 7:17 PM Changeset in webkit [71002] by
-
- 5 edits in trunk/LayoutTests
2010-10-31 Mike Lawther <mikelawther@chromium.org>
Reviewed by Andreas Kling.
unskip canvas/philip/tests/2d.imageData.get.source.negative on all ports
https://bugs.webkit.org/show_bug.cgi?id=48702
- platform/chromium-gpu/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac-leopard/Skipped:
- platform/qt/Skipped:
- 7:04 PM Changeset in webkit [71001] by
-
- 3 edits6 adds in trunk
2010-10-31 Peter Kasting <pkasting@google.com>
Reviewed by Adam Barth.
Treat GIFs with no loop count as "loop once".
https://bugs.webkit.org/show_bug.cgi?id=47302
- fast/images/gif-loop-count-expected.checksum: Added.
- fast/images/gif-loop-count-expected.png: Added.
- fast/images/gif-loop-count-expected.txt: Added.
- fast/images/gif-loop-count.html: Added.
- fast/images/resources/gif-loop-count.gif: Added.
- fast/images/resources/gif-loop-count.png: Added.
2010-10-31 Peter Kasting <pkasting@google.com>
Reviewed by Adam Barth.
Treat GIFs with no loop count as "loop once".
https://bugs.webkit.org/show_bug.cgi?id=47302
Test: fast/images/gif-loop-count.html
- platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::repetitionCount): (WebCore::GIFImageDecoder::gifComplete):
- 6:39 PM Changeset in webkit [71000] by
-
- 2 edits in trunk/WebCore
2010-10-31 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Andreas Kling.
[Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070
Build fix for X11.
No new tests; build fix.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::invalidateRect): (WebCore::PluginView::platformStart):
- 1:42 PM Changeset in webkit [70999] by
-
- 2 edits in trunk/WebKit/qt
2010-10-31 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Short-circuit QWebPage::selectedText() if frame has no selection
https://bugs.webkit.org/show_bug.cgi?id=48736
Do an early return if the selection is empty.
No new tests, this is covered by tst_QWebPage::findText().
- Api/qwebpage.cpp: (QWebPage::selectedText):
- 1:33 PM Changeset in webkit [70998] by
-
- 2 edits1 add in trunk/LayoutTests
2010-10-31 James Simonsen <simonjam@chromium.org>
Reviewed by Andreas Kling.
Rebaseline a fast/dynamic LayoutTest for Chromium Linux
fast/dynamic/positioned-movement-with-positioned-children.html exposes
a change to the defult button style on Linux.
Prior to bug 26030, buttons were always drawn as #dddddd, regardless of
what the style said. The default style had been #c0c0c0. With the fix,
buttons now honor the style sheet, but in order to maintain
consistency, the default style for Linux was changed to #dddddd.
This patch updates the test to reflect the newer Linux button style.
- platform/chromium-linux/fast/dynamic/positioned-movement-with-positioned-children-expected.txt: Added.
- platform/chromium/test_expectations.txt: Removed rebaselined test.
- 1:20 PM Changeset in webkit [70997] by
-
- 4 edits in trunk/WebKit2
2010-10-31 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Visited links not populated correctly in new web processes after the first
https://bugs.webkit.org/show_bug.cgi?id=48735
rdar://problem/8442177
- UIProcess/VisitedLinkProvider.cpp: (WebKit::VisitedLinkProvider::VisitedLinkProvider): Initialize m_webProcessHasVisitedLinkState. (WebKit::VisitedLinkProvider::processDidFinishLaunching): Renamed from populateVisitedLinksIfNeeded. Set m_webProcessHasVisitedLinkState to false, since this is a new process, and also start the timer so the visited links messages will be sent. (WebKit::VisitedLinkProvider::processDidClose): Renamed from stopVisitedLinksTimer. (WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired): Added logic so we send SetVisitedLinkTable and AllVisitedLinkStateChanged once to each new process and to set m_webProcessHasVisitedLinkState to true once that is done.
- UIProcess/VisitedLinkProvider.h: Updated for above changes.
- UIProcess/WebContext.cpp: (WebKit::WebContext::processDidFinishLaunching): Called VisitedLinkProvider function under its new name. Also used ASSERT_UNUSED rather than ASSERT since the argument is used only for the assertion. (WebKit::WebContext::processDidClose): Ditto.
- 12:32 PM Changeset in webkit [70996] by
-
- 10 edits in trunk/WebCore
2010-10-31 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
Remove the unused GraphicsContext::clipOutEllipseInRect(IntRect)
https://bugs.webkit.org/show_bug.cgi?id=48727
This function was added in <http://trac.webkit.org/changeset/18654> for CSS3 box-shadows.
All use of the function was removed in <http://trac.webkit.org/changeset/21601>
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
- platform/graphics/cg/GraphicsContextCG.cpp:
- platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::clipOut):
- platform/graphics/openvg/GraphicsContextOpenVG.cpp:
- platform/graphics/qt/GraphicsContextQt.cpp:
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clipOut):
- platform/graphics/wince/GraphicsContextWinCE.cpp:
- platform/graphics/wx/GraphicsContextWx.cpp:
- 12:30 PM Changeset in webkit [70995] by
-
- 2 edits in trunk/WebCore
2010-10-31 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
[Qt] Respect the "antialiased" argument in clipConvexPolygon()
https://bugs.webkit.org/show_bug.cgi?id=48734
Set (or unset) the QPainter::Antialiased render hint for antialiased
clipping based on the "antialiased" argument.
No test since Qt doesn't have pixel tests yet.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipConvexPolygon):
- 12:02 PM Changeset in webkit [70994] by
-
- 3 edits in trunk/WebCore
2010-10-31 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
Remove the unused GraphicsContext::strokeRect(FloatRect)
https://bugs.webkit.org/show_bug.cgi?id=48726
This function was only implemented by GraphicsContextOpenVG and not
called from anywhere.
- platform/graphics/GraphicsContext.h:
- platform/graphics/openvg/GraphicsContextOpenVG.cpp:
- 11:59 AM Changeset in webkit [70993] by
-
- 7 edits in trunk/WebCore
2010-10-31 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
Remove the unused GraphicsContext::origin()
https://bugs.webkit.org/show_bug.cgi?id=48732
This method was not called from anywhere.
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
- platform/graphics/haiku/GraphicsContextHaiku.cpp:
- platform/graphics/openvg/GraphicsContextOpenVG.cpp:
- platform/graphics/qt/GraphicsContextQt.cpp:
- platform/graphics/wince/GraphicsContextWinCE.cpp:
- 11:57 AM Changeset in webkit [70992] by
-
- 4 edits in trunk/WebCore
2010-10-31 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
[Qt] Remove GraphicsContext::pen()
https://bugs.webkit.org/show_bug.cgi?id=48733
Have PathQt obtain the pen() through the platformContext() instead.
- platform/graphics/GraphicsContext.h:
- platform/graphics/qt/GraphicsContextQt.cpp:
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeContains): (WebCore::Path::strokeBoundingRect):
- 10:33 AM Changeset in webkit [70991] by
-
- 25 edits4 deletes in trunk
2010-10-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r70959.
http://trac.webkit.org/changeset/70959
https://bugs.webkit.org/show_bug.cgi?id=48731
It broke fast/events/spatial-navigation tests (Requested by
Ossy on #webkit).
- WebCore.xcodeproj/project.pbxproj:
- rendering/InlineBox.cpp: (WebCore::InlineBox::adjustForFlippedBlocksWritingMode):
- rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::bottomLayoutOverflow): (WebCore::InlineFlowBox::rightLayoutOverflow): (WebCore::InlineFlowBox::bottomVisualOverflow): (WebCore::InlineFlowBox::rightVisualOverflow):
- rendering/RenderBox.cpp:
- rendering/RenderBox.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::linesBoundingBox): (WebCore::RenderInline::linesVisibleOverflowBoundingBox): (WebCore::RenderInline::clippedOverflowRectForRepaint):
- rendering/RenderText.cpp: (WebCore::RenderText::linesBoundingBox):
2010-10-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r70959.
http://trac.webkit.org/changeset/70959
https://bugs.webkit.org/show_bug.cgi?id=48731
It broke fast/events/spatial-navigation tests (Requested by
Ossy on #webkit).
- fast/repaint/inline-vertical-rl-overflow.html: Removed.
- platform/mac/fast/blockflow/background-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/background-vertical-rl-expected.txt:
- platform/mac/fast/blockflow/basic-vertical-line-expected.txt:
- platform/mac/fast/blockflow/border-image-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/border-image-vertical-rl-expected.txt:
- platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
- platform/mac/fast/blockflow/border-vertical-lr-expected.png:
- platform/mac/fast/blockflow/border-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.txt:
- platform/mac/fast/blockflow/english-lr-text-expected.txt:
- platform/mac/fast/blockflow/english-rl-text-expected.txt:
- platform/mac/fast/blockflow/japanese-lr-text-expected.txt:
- platform/mac/fast/blockflow/japanese-rl-text-expected.txt:
- platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum: Removed.
- platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.png: Removed.
- platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.txt: Removed.
- platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt:
- 9:04 AM Changeset in webkit [70990] by
-
- 1 edit1 add in trunk/LayoutTests
2010-10-31 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48686
Forgot to land SVGAnimatedNumber.js, fails on all bots. Thanks Darin for noticing.
- svg/dom/script-tests/SVGAnimatedNumber.js: Added.
Oct 30, 2010:
- 11:43 PM Changeset in webkit [70989] by
-
- 6 edits in trunk/WebCore
2010-10-30 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: new resources and network panel usability improvements.
https://bugs.webkit.org/show_bug.cgi?id=48680
By default, navigation clears network log, added 'preserve log' button,
that prevents log from being cleared.
Storing expanded state of all group items, restoring last selected item,
fall back to main frame's main resource by default.
Do not list XHRs and redirects in resources.
- English.lproj/localizedStrings.js:
- inspector/InspectorController.cpp: (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest):
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.get statusBarItems): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._updateFilter): (WebInspector.NetworkPanel.prototype._createStatusbarButtons): (WebInspector.NetworkPanel.prototype._onPreserveLogClicked): (WebInspector.NetworkPanel.prototype.reset): (WebInspector.NetworkPanel.prototype.refreshResource):
- inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.identifierForInitialRequest): (WebInspector.ResourceManager.prototype.willSendRequest): (WebInspector.ResourceManager.prototype.didLoadResourceFromMemoryCache): (WebInspector.ResourceManager.prototype.setOverrideContent): (WebInspector.ResourceManager.prototype.didCreateWebSocket):
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.show): (WebInspector.StoragePanel.prototype._initDefaultSelection): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addResourceToFrame): (WebInspector.StoragePanel.prototype.refreshResource): (WebInspector.StoragePanel.prototype.showDatabase): (WebInspector.BaseStorageTreeElement.prototype.onselect): (WebInspector.StorageCategoryTreeElement): (WebInspector.StorageCategoryTreeElement.prototype.get itemURL): (WebInspector.StorageCategoryTreeElement.prototype.onselect): (WebInspector.StorageCategoryTreeElement.prototype.onattach): (WebInspector.StorageCategoryTreeElement.prototype.onexpand): (WebInspector.StorageCategoryTreeElement.prototype.oncollapse): (WebInspector.FrameTreeElement.prototype.get itemURL): (WebInspector.FrameTreeElement.prototype.onselect): (WebInspector.FrameResourceTreeElement.prototype.get itemURL): (WebInspector.FrameResourceTreeElement.prototype.onselect): (WebInspector.DatabaseTreeElement.prototype.get itemURL): (WebInspector.DatabaseTreeElement.prototype.onselect): (WebInspector.DatabaseTableTreeElement.prototype.get itemURL): (WebInspector.DatabaseTableTreeElement.prototype.onselect): (WebInspector.DOMStorageTreeElement.prototype.get itemURL): (WebInspector.DOMStorageTreeElement.prototype.onselect): (WebInspector.CookieTreeElement.prototype.get itemURL): (WebInspector.CookieTreeElement.prototype.onselect): (WebInspector.ApplicationCacheTreeElement.prototype.get itemURL): (WebInspector.ApplicationCacheTreeElement.prototype.onselect):
- 4:08 PM Changeset in webkit [70988] by
-
- 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl
2010-10-30 Antonio Gomes <agomes@rim.com>
Unreviewed Windows bots build fix (take I).
Touching WebKit.idl to try forcing a clean build.
- Interfaces/WebKit.idl:
- 2:00 PM Changeset in webkit [70987] by
-
- 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/config.json
William Siegrist <wsiegrist@apple.com>
Change trigger name to match builder name change in r70871.
- 12:31 PM Changeset in webkit [70986] by
-
- 4 edits in trunk
2010-10-30 Patrick Gansterer <Patrick Gansterer>
Unreviewed, build fix after r70846.
- platform/graphics/wince/ImageWinCE.cpp: (WebCore::RGBA32Buffer::asNewNativeImage):
2010-10-30 Patrick Gansterer <Patrick Gansterer>
Unreviewed, build fix after r70574.
- WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::transferLoadingResourceFromPage):
- 11:48 AM Changeset in webkit [70985] by
-
- 19 edits4 deletes in trunk
2010-10-30 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, rolling out r70984.
http://trac.webkit.org/changeset/70984
https://bugs.webkit.org/show_bug.cgi?id=46015
Made media/audio-delete-while-slider-thumb-clicked.html crash.
- fast/events/shadow-boundary-crossing.html:
2010-10-30 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, rolling out r70984.
http://trac.webkit.org/changeset/70984
https://bugs.webkit.org/show_bug.cgi?id=46015
Made media/audio-delete-while-slider-thumb-clicked.html crash.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- dom/ContainerNode.cpp: (WebCore::notifyChildInserted):
- dom/EventContext.cpp: Removed.
- dom/EventContext.h: Removed.
- dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): (WebCore::Node::createRendererIfNeeded): (WebCore::Node::eventParentNode): (WebCore::Node::enclosingLinkEventParentOrSelf): (WebCore::eventTargetAsSVGElementInstance): (WebCore::eventTargetRespectingSVGTargetRules): (WebCore::Node::eventAncestors): (WebCore::Node::dispatchGenericEvent):
- dom/Node.h:
- dom/Text.cpp: (WebCore::Text::createRenderer):
- dom/WindowEventContext.cpp: Removed.
- dom/WindowEventContext.h: Removed.
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode):
- inspector/InspectorInstrumentation.cpp: (WebCore::eventHasListeners): (WebCore::InspectorInstrumentation::willDispatchEventImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willDispatchEvent):
- page/EventHandler.cpp: (WebCore::EventHandler::updateMouseEventTargetNode):
- svg/SVGElement.cpp: (WebCore::SVGElement::eventParentNode):
- svg/SVGElement.h:
- 10:32 AM Changeset in webkit [70984] by
-
- 19 edits4 adds in trunk
2010-10-30 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
https://bugs.webkit.org/show_bug.cgi?id=46015
Tuned the test to better reflect its point: the event should indeed fire (it used to be swallowed),
but its target should be a non-shadow node.
- fast/events/shadow-boundary-crossing.html: Modified the test.
2010-10-30 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
https://bugs.webkit.org/show_bug.cgi?id=46015
This patch adds the notion of EventContext (and a very similar-acting WindowEventContext, specifically
for DOMWindow), an abstraction that carries information around dispatching an event for any given Node.
This abstraction is necessary to ensure that events, fired from shadow DOM nodes are properly retargeted to
appear as if they are coming from their host, thus never exposing the shadow DOM nodes to the world outside.
- Android.mk: Added EventContext, WindowEventContext files.
- CMakeLists.txt: Ditto.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- dom/ContainerNode.cpp: (WebCore::notifyChildInserted): Changed to be shadow DOM-aware.
- dom/EventContext.cpp: Added.
- dom/EventContext.h: Added.
- dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Changed to be shadow DOM-aware. (WebCore::Node::createRendererIfNeeded): Ditto. (WebCore::Node::parentOrHostNode): Added new helper method. (WebCore::Node::enclosingLinkEventParentOrSelf): Changed to be shadow DOM-aware. (WebCore::eventTargetRespectingSVGTargetRules): Collapsed two helper methods into one. (WebCore::Node::eventAncestors): Refactored to collect a vector of EventContexts. (WebCore::Node::topEventContext): Added. (WebCore::eventHasListeners): Changed to use EventContexts. (WebCore::Node::dispatchGenericEvent): Ditto.
- dom/Node.h: Removed eventParentNode that's no longer needed, added parentOrHostNode decl,
and changed signature of eventAncestors to use EventContexts.
- dom/Text.cpp: (WebCore::Text::createRenderer): Changed to be shadow DOM-aware.
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode): Changed to use EventContexts.
- page/EventHandler.cpp: (WebCore::EventHandler::updateMouseEventTargetNode): Removed code that's no longer necessary.
- svg/SVGElement.cpp: Removed eventParentNode that's no longer needed.
- svg/SVGElement.h: Ditto.
- dom/WindowEventContext.cpp: Added.
- dom/WindowEventContext.h: Added.
- 8:17 AM Changeset in webkit [70983] by
-
- 2 edits in trunk/WebKit/gtk
2010-10-30 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Use new width for height APIs in GTK+ 3.x
https://bugs.webkit.org/show_bug.cgi?id=48709
Use the new width for height APIs in GTK+ 3.x, since size-request
is deprecated.
For now we just return the same value for preferred and minimum
width/height, which should match the 2.x behavior. Probably we
could do something smarter for the minimum values.
- webkit/webkitwebview.cpp: (webkit_web_view_get_preferred_width): return our preferred width. (webkit_web_view_get_preferred_height): return our preferred height. (webkit_web_view_class_init): hook the new default handlers.
- 7:51 AM Changeset in webkit [70982] by
-
- 2 edits in trunk/WebKit/qt
2010-10-30 Andreas Kling <kling@webkit.org>
Reviewed by Antonio Gomes.
[Qt] IM: Don't manipulate selection via RenderTextControl
https://bugs.webkit.org/show_bug.cgi?id=48700
Go directly through the Frame's SelectionController instead.
No new tests, this is covered by tst_QWebPage::inputMethods.
- Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent): (QWebPage::inputMethodQuery):
- 7:49 AM Changeset in webkit [70981] by
-
- 2 edits in trunk/WebKit2
2010-10-30 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Crash in drawUpdateChunkIntoBackingStore
https://bugs.webkit.org/show_bug.cgi?id=48707
UpdateChunk images have to be created using the QImage constructor
that takes a bytesPerLine (stride) value, or the data length won't
match UpdateChunk::size().
- Shared/qt/UpdateChunk.cpp: (WebKit::UpdateChunk::createImage):
- 7:48 AM Changeset in webkit [70980] by
-
- 3 edits in trunk/WebKitTools
2010-10-30 Andreas Kling <kling@webkit.org>
Reviewed by Antonio Gomes.
[Qt] QtTestBrowser: Switching view type moves the embedded inspector
https://bugs.webkit.org/show_bug.cgi?id=48705
Reinsert the embedded inspector into the splitter after changing
between QWebView/QGraphicsWebView.
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::init): (LauncherWindow::initializeView):
- QtTestBrowser/webinspector.h: (WebInspector::WebInspector):
- 6:23 AM Changeset in webkit [70979] by
-
- 50 edits10 adds in trunk
2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48686
Convert the next set of primitives to use the new SVG(Animated)PropertyTearOff concept.
Tests: svg/dom/SVGAnimatedNumber.html
svg/dom/SVGAnimatedNumberList.html
svg/dom/SVGNumber.html
- GNUmakefile.am: Add SVGAnimatedNumber.h / SVGAnimatedNumberList.h to build.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/scripts/CodeGenerator.pm: Recognize SVGAnimatedNumber/SVGAnimatedNumberList as new style SVG animated properties. Remove SVGNumber from PODType hash.
- bindings/scripts/CodeGeneratorJS.pm: Remove special SVGNumber handing, it's obsolete now.
- bindings/scripts/CodeGeneratorObjC.pm: Add special SVGNumber handling, as it's the first of the converted dynamic SVGAnimatedProperty types that's not in WebCore namespace.
- bindings/scripts/CodeGeneratorV8.pm: Use AvoidInclusionOfType method from CodeGenerator.pm, remove special SVGNumber handling, that's obsolete now.
- rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::extractFloatValuesFromSVGNumberList): Adapt to SVGNumberList change, which is a plain Vector<float> now.
- svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedNumber/SVGAnimatedNumberList handling.
- svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
- svg/SVGAnimatedNumber.h: Added.
- svg/SVGAnimatedNumber.idl: Enable StrictTypeChecking.
- svg/SVGAnimatedNumberList.h: Added.
- svg/SVGAnimatedNumberList.idl: Ditto.
- svg/SVGComponentTransferFunctionElement.cpp: Switch animated float properties to the new SVGAnimatedNumber(List). (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): (WebCore::SVGComponentTransferFunctionElement::transferFunction):
- svg/SVGComponentTransferFunctionElement.h:
- svg/SVGFEColorMatrixElement.cpp: Ditto. (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement): (WebCore::SVGFEColorMatrixElement::parseMappedAttribute): (WebCore::SVGFEColorMatrixElement::build):
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFECompositeElement.h: Ditto.
- svg/SVGFEConvolveMatrixElement.cpp: Ditto. (WebCore::SVGFEConvolveMatrixElement::SVGFEConvolveMatrixElement): (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthXIdentifier): Added, replacing char[] hack by a static atomic string. (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthYIdentifier): Ditto. (WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute): (WebCore::SVGFEConvolveMatrixElement::build):
- svg/SVGFEConvolveMatrixElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
- svg/SVGFEDiffuseLightingElement.cpp: Ditto. (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthXIdentifier): Remove trailing whitespace. (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthYIdentifier): Ditto.
- svg/SVGFEDiffuseLightingElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
- svg/SVGFEDisplacementMapElement.h: Ditto.
- svg/SVGFEGaussianBlurElement.cpp: Ditto. (WebCore::SVGFEGaussianBlurElement::stdDeviationXIdentifier): Remove trailing whitespace. (WebCore::SVGFEGaussianBlurElement::stdDeviationYIdentifier): Ditto.
- svg/SVGFEGaussianBlurElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
- svg/SVGFELightElement.h: Ditto.
- svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::radiusXIdentifier): Added, replacing char[] hack by a static atomic string. (WebCore::SVGFEMorphologyElement::radiusYIdentifier): Ditto.
- svg/SVGFEMorphologyElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
- svg/SVGFEOffsetElement.h: Ditto.
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::kernelUnitLengthXIdentifier): Remove trailing whitespace. (WebCore::SVGFESpecularLightingElement::kernelUnitLengthYIdentifier): Ditto.
- svg/SVGFESpecularLightingElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::baseFrequencyXIdentifier): Remove trailing whitespace. (WebCore::SVGFETurbulenceElement::baseFrequencyYIdentifier): Ditto.
- svg/SVGFETurbulenceElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::filterResXIdentifier): Remove trailing whitespace. (WebCore::SVGFilterElement::filterResYIdentifier): Ditto.
- svg/SVGLengthList.idl: Remove leftover [SVGListProperty] marker.
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::orientTypeIdentifier): Remove trailing whitespace. (WebCore::SVGMarkerElement::orientAngleIdentifier): Ditto.
- svg/SVGNumber.idl: Remove [PODType] marker, add StrictTypeChecking.
- svg/SVGNumberList.cpp: Convert from SVGPODList<RefPtr<SVGPODListItem<float> > > to plain Vector<float>, just like it has been done for SVGLengthList before. (WebCore::SVGNumberList::parse): (WebCore::SVGNumberList::valueAsString):
- svg/SVGNumberList.h: (WebCore::SVGNumberList::SVGNumberList):
- svg/SVGPathElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
- svg/SVGStopElement.h: Ditto.
- svg/SVGTextPositioningElement.cpp: Switch animated float properties to the new SVGAnimatedNumber(List). (WebCore::SVGTextPositioningElement::SVGTextPositioningElement): (WebCore::SVGTextPositioningElement::parseMappedAttribute):
- svg/SVGTextPositioningElement.h: Ditto.
- svg/properties/SVGPropertyTraits.h: Add SVGNumberList handling.
2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48686
Fix invalid tests in svg/dynamic-updates, that relied on a bug in our SVGNumberList implementation. If an item was already
inserted in a list, and we tried to insert it somewhere else, we didn't remove it from the old list. Now that SVGNumberList
has been switched to SVGAnimatedListPropertyTearOff, the bug is fixed, and it behaves exactly like SVGLengthList.
Side effect: svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html now works as expected (dynamic update is executed)
- platform/mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum:
- platform/mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
- svg/dom/SVGAnimatedNumber-expected.txt: Added.
- svg/dom/SVGAnimatedNumber.html: Added.
- svg/dom/SVGAnimatedNumberList-expected.txt: Added.
- svg/dom/SVGAnimatedNumberList.html: Added.
- svg/dom/SVGNumber-expected.txt: Added.
- svg/dom/SVGNumber.html: Added.
- svg/dom/script-tests/SVGAnimatedNumber.js: Added.
- svg/dom/script-tests/SVGAnimatedNumberList.js: Added.
- svg/dom/script-tests/SVGNumber.js: Added.
- svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-svgdom-type-prop.js: Test now works in Firefox as well. (executeTest): SVGNumber.value only accepts numbers, not strings, now that StrictTypeChecking is enabled.
- svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-svgdom-values-prop.js: Test now works in Firefox as well. (executeTest): Don't call appendItem several times with the same SVGNumber, it will be removed if it was already inserted in a list.
- svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-baseFrequency-prop.js:
- 1:59 AM Changeset in webkit [70978] by
-
- 5 edits in trunk/LayoutTests
2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Update SVGFEFloodElement mac-leopard baseline, which was forgotten.
- platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.checksum:
- platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
- platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.checksum:
- platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
Oct 29, 2010:
- 11:15 PM Changeset in webkit [70977] by
-
- 1 edit2 copies in branches/chromium/552
Merge 70718 - 2010-10-27 Adam Barth <abarth@webkit.org>
Reviewed by Ojan Vafai.
REGRESSION(66511): CORDYS Process Factory doesn't work
https://bugs.webkit.org/show_bug.cgi?id=48453
Test some appendChild cases that didn't have coverage before.
- fast/dom/allowed-children-expected.txt: Added.
- fast/dom/allowed-children.html: Added.
2010-10-27 Adam Barth <abarth@webkit.org>
Reviewed by Ojan Vafai.
REGRESSION(66511): CORDYS Process Factory doesn't work
https://bugs.webkit.org/show_bug.cgi?id=48453
When Ojan refactored this function in 66511, he missed an "else",
which causes us to generated HIERARCHY_REQUEST_ERR in some cases where
we're not supposed to. This patch restores the "else" behavior (using
an early return) and adds a test for the cases that caused problems in
the field.
Test: fast/dom/allowed-children.html
- dom/Node.cpp: (WebCore::isChildTypeAllowed):
- 11:13 PM Changeset in webkit [70976] by
-
- 28 edits2 copies in trunk
2010-10-29 Daniel Bates <dbates@rim.com>
No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751
Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout tests regressions on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::name):
2010-10-29 Daniel Bates <dbates@rim.com>
No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751
Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout tests regressions on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.
- Api/qwebframe.cpp: (QWebFrame::frameName):
2010-10-29 Daniel Bates <dbates@rim.com>
No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751
Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout tests regressions on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.
- webkit/webkitwebframe.cpp: (webkit_web_frame_get_name):
2010-10-29 Daniel Bates <dbates@rim.com>
No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751
Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.
- WebFrame.cpp: (WebFrame::name):
2010-10-29 Daniel Bates <dbates@rim.com>
No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751
Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.
- WebView/WebFrame.mm: (-[WebFrame name]):
2010-10-29 Daniel Bates <dbates@rim.com>
No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751
Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.
- ewk/ewk_frame.cpp: (ewk_frame_name_get):
2010-10-29 Daniel Bates <dbates@rim.com>
No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751
Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.
Test: fast/frames/iframe-set-inner-html.html
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL): (WebCore::HTMLFrameElementBase::setName):
- html/HTMLFrameElementBase.h:
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::mainResource):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::commitProvisionalLoad):
- loader/HistoryController.cpp: (WebCore::HistoryController::saveDocumentState): (WebCore::HistoryController::restoreDocumentState): (WebCore::HistoryController::createItem): (WebCore::HistoryController::currentFramesMatchItem):
- loader/ProgressTracker.cpp: (WebCore::ProgressTracker::progressStarted): (WebCore::ProgressTracker::progressCompleted):
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create):
- page/FrameTree.cpp: (WebCore::FrameTree::setName): (WebCore::FrameTree::clearName): (WebCore::FrameTree::uniqueChildName): (WebCore::FrameTree::child): (WebCore::FrameTree::find):
- page/FrameTree.h: (WebCore::FrameTree::name):
2010-10-29 Daniel Bates <dbates@rim.com>
No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751
Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.
- fast/frames/frame-element-name-expected.txt:
- fast/frames/iframe-set-inner-html-expected.txt: Copied from LayoutTests/fast/frames/iframe-set-inner-html-expected.txt.
- fast/frames/iframe-set-inner-html.html: Copied from LayoutTests/fast/frames/iframe-set-inner-html.html.
- fast/frames/resources/frame-element-name-left.html:
- fast/frames/resources/frame-element-name-right.html:
2010-10-29 Daniel Bates <dbates@rim.com>
No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751
Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.
- WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::name):
- 10:38 PM Changeset in webkit [70975] by
-
- 21 edits in trunk
Needs a "LinuxEditingBehavior", perhaps with a better name
https://bugs.webkit.org/show_bug.cgi?id=36627
Reviewed by Ojan Vafai.
Patch by Antonio Gomes <agomes@rim.com>
WebCore:
Added EditingUnixBehavior editing type aim to cover the cases when
neither Mac or Windows behaviors are appropriated.
It was decided to name it Unix not Linux.
No new tests. The current editing tests that involve platform specific
bahaviors are coded so that they go through all editing behavior
types possible. There will be a follow up bug where all of them will
be updated to include the new editing behavior ("unix").
- editing/EditingBehaviorTypes.h:
- page/Settings.cpp:
(WebCore::editingBehaviorTypeForPlatform):
(WebCore::Settings::Settings):
WebKit/chromium:
Added the corresponding Chromium setting to WebCore's EditingUnixBehavior: EditingBehaviorUnix.
- public/WebSettings.h:
- src/AssertMatchingEnums.cpp:
WebKit/gtk:
Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WEBKIT_EDITING_BEHAVIOR_UNIX.
- webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
- webkit/webkitwebsettings.h:
WebKit/mac:
Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
- WebView/WebFrame.mm:
(core):
- WebView/WebPreferencesPrivate.h:
WebKit/qt:
Adding support to Qt's DRTSupport class to test the newly introduced Unix editing behavior.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setEditingBehavior):
WebKit/win:
Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
- Interfaces/IWebPreferences.idl:
WebKitTools:
Adding support to Mac's, GTK+'s, Windows' and Chromium's LayoutTestController class to test the newly introduced Unix editing behavior.
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::setEditingBehavior):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setEditingBehavior):
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setEditingBehavior):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setEditingBehavior):
- 9:07 PM Changeset in webkit [70974] by
-
- 9 edits2 deletes in tags/Safari-534.11.1/WebCore
Merge r70970.
- 9:07 PM Changeset in webkit [70973] by
-
- 5 edits in tags/Safari-534.11.1
Versioning.
- 8:57 PM Changeset in webkit [70972] by
-
- 1 copy in tags/Safari-534.11.1
New tag.
- 8:49 PM Changeset in webkit [70971] by
-
- 28 edits2 deletes in trunk
2010-10-29 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751
Modified Chromium-port to use FrameTree::uniqueName().
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::name):
2010-10-29 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751
Modified Qt-port to use FrameTree::uniqueName().
- Api/qwebframe.cpp: (QWebFrame::frameName):
2010-10-29 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751
Modified GTK-port to use FrameTree::uniqueName().
- webkit/webkitwebframe.cpp: (webkit_web_frame_get_name):
2010-10-29 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751
Modified Apple Windows-port to use FrameTree::uniqueName().
- WebFrame.cpp: (WebFrame::name):
2010-10-29 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751
Modified Mac-port to use FrameTree::uniqueName().
- WebView/WebFrame.mm: (-[WebFrame name]):
2010-10-29 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751
Modified EFL-port to use FrameTree::uniqueName().
- ewk/ewk_frame.cpp: (ewk_frame_name_get):
2010-10-29 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751
Fixes an issue where the window.name of an unnamed frame returns
a unique generated name that is used internally to identify the
frame. Instead, we should return an empty string as implied by
section 5.1.6 of the HTML5 spec. (http://www.w3.org/TR/html5/browsers.html#browsing-context-names).
This section describes that a browsing context can have no name or be
the empty string.
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL): Removed ASSERT for empty frame name since this is valid as per the HTML5 spec. (WebCore::HTMLFrameElementBase::setName): Removed the call to FrameTree::uniqueChildName() since the loader code no longer depends on the frame name being unique.
- html/HTMLFrameElementBase.h:
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::mainResource): Use FrameTree::uniqueName().
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): Ditto. (WebCore::FrameLoader::commitProvisionalLoad): Ditto.
- loader/HistoryController.cpp: (WebCore::HistoryController::saveDocumentState): Ditto. (WebCore::HistoryController::restoreDocumentState): Ditto. (WebCore::HistoryController::createItem): (WebCore::HistoryController::currentFramesMatchItem): Ditto.
- loader/ProgressTracker.cpp: (WebCore::ProgressTracker::progressStarted): Ditto. (WebCore::ProgressTracker::progressCompleted): Ditto.
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Ditto.
- page/FrameTree.cpp: (WebCore::FrameTree::setName): Modified to store the DOM-specified name of the frame. (WebCore::FrameTree::clearName): (WebCore::FrameTree::uniqueChildName): Use FrameTree::uniqueName(). (WebCore::FrameTree::child): Ditto. (WebCore::FrameTree::find): Ditto.
- page/FrameTree.h: (WebCore::FrameTree::uniqueName): Added.
2010-10-29 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751
Updated test case fast/frames/frame-element-name.html to check
the value of window.name.
- fast/frames/frame-element-name-expected.txt: Updated result.
- fast/frames/iframe-set-inner-html-expected.txt: Removed; This test ensured that the generated name for an unnamed frames was unique by looking at the value of window.name. However, the generated name should not be exposed to web developers. Instead, window.name should return the empty string for an unnamed frame as implied by section 5.1.6 of the HTML5 spec. We should consider exposing a DRT method for obtaining the internal frame name (which may be generated) and re-implementing this test to use it.
- fast/frames/iframe-set-inner-html.html: Removed.
- fast/frames/resources/frame-element-name-left.html: Added test for window.name.
- fast/frames/resources/frame-element-name-right.html: Ditto.
2010-10-29 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751
Modified WebKit2 to use FrameTree::uniqueName().
- WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::name):
- 8:42 PM Changeset in webkit [70970] by
-
- 9 edits2 deletes in trunk/WebCore
Roll out r70847 as it causes crashes when typing text in both Safari and Mail: <http://webkit.org/b/48708>.
- 8:37 PM Changeset in webkit [70969] by
-
- 2 edits in trunk/WebKitLibraries
Snow Leopard PowerPC build fix.
- libWebKitSystemInterfaceSnowLeopard.a:
- 8:34 PM Changeset in webkit [70968] by
-
- 2 edits in trunk/WebKitLibraries
Leopard PowerPC build fix.
- libWebKitSystemInterfaceLeopard.a:
- 6:40 PM Changeset in webkit [70967] by
-
- 495 edits494 copies in trunk/LayoutTests
2010-10-29 James Robinson <jamesr@chromium.org>
Update pixel expectations for Snow Leopard for tests in tables/mozilla/bugs.
Moves the leopard-specific mac baselines to platform/mac-leopard/ and adds new Snow Leopard pixel
expectations for tests that need them. List of files omitted due to length.
- 6:28 PM Changeset in webkit [70966] by
-
- 2 edits in trunk/WebKit2
Implement WebProcess::platformSetCacheModel for windows
<rdar://problem/8605796>
https://bugs.webkit.org/show_bug.cgi?id=48703
Reviewed by Simon Fraser.
- WebProcess/win/WebProcessWin.cpp:
(WebKit::memorySize):
(WebKit::volumeFreeSize):
(WebKit::WebProcess::platformSetCacheModel):
Add implemenation based on the version in WebKit/win/WebView.cpp.
- 6:23 PM Changeset in webkit [70965] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
Enable a few tests that were fixed in revs 70891:70949.
- platform/chromium/test_expectations.txt:
- 6:09 PM Changeset in webkit [70964] by
-
- 2 edits in trunk/WebKit2
2010-10-29 Andreas Kling <kling@webkit.org>
Reviewed by Anders Carlsson.
WK2: Unbreak compilation of WebPlatformTouchPoint::decode()
- Shared/WebPlatformTouchPoint.cpp: (WebKit::WebPlatformTouchPoint::decode):
- 6:07 PM Changeset in webkit [70963] by
-
- 5 edits in trunk/WebCore
Try to fix build.
- page/ContextMenuController.cpp: Added include of BackForwardController.h.
- page/DOMWindow.cpp: Ditto.
- page/History.cpp: Ditto.
- platform/ContextMenu.cpp: Ditto.
- 5:58 PM Changeset in webkit [70962] by
-
- 5 edits in trunk
Versioning.
- 5:55 PM Changeset in webkit [70961] by
-
- 1 copy in tags/Safari-534.11
New tag.
- 5:44 PM Changeset in webkit [70960] by
-
- 33 edits3 deletes in trunk
More back/forward refactoring
Reviewed by Sam Weinig.
WebCore:
- WebCore.exp.in: Updated.
- GNUmakefile.am: Removed BackForwardControllerClient.h.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- history/BackForwardControllerClient.h: Removed.
- history/BackForwardController.cpp:
(WebCore::BackForwardController::BackForwardController):
Set up just m_client.
(WebCore::BackForwardController::~BackForwardController):
Removed call to backForwardControllerDestroyed.
(WebCore::BackForwardController::canGoBackOrForward): Added.
(WebCore::BackForwardController::goBackOrForward): Added.
(WebCore::BackForwardController::goBack): Added.
(WebCore::BackForwardController::goForward): Added.
(WebCore::BackForwardController::addItem): Added.
(WebCore::BackForwardController::setCurrentItem): Added.
(WebCore::BackForwardController::count): Added.
(WebCore::BackForwardController::backCount): Added.
(WebCore::BackForwardController::forwardCount): Added.
(WebCore::BackForwardController::itemAtIndex): Added.
(WebCore::BackForwardController::isActive): Added.
(WebCore::BackForwardController::close): Added.
- history/BackForwardController.h: Added functions from Page
and BackForwardList that should be called here instead.
Note that BackForwardList is to be renamed BackForwardClient soon.
- history/BackForwardList.h: Removed many now-unneeded
virtual functions.
- history/BackForwardListImpl.h: Moved BackForwardListClient
in here.
- history/PageCache.cpp:
(WebCore::logCanCachePageDecision): Use backForward().
(WebCore::PageCache::canCache): Ditto.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted): Removed unneeded
null check of backFowardList, which is never null.
(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Use backForward.
(WebCore::FrameLoader::didFirstLayout): Ditto.
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Ditto.
(WebCore::FrameLoader::checkDidPerformFirstNavigation): Ditto.
- loader/HistoryController.cpp:
(WebCore::HistoryController::goToItem): Ditto.
(WebCore::HistoryController::updateForStandardLoad): Ditto.
(WebCore::HistoryController::updateForRedirectWithLockedBackForwardList): Ditto.
(WebCore::HistoryController::updateBackForwardListClippedAtTarget): Ditto.
(WebCore::HistoryController::pushState): Ditto.
- loader/NavigationScheduler.cpp:
(WebCore::ScheduledHistoryNavigation::fire): Ditto.
(WebCore::NavigationScheduler::scheduleHistoryNavigation): Ditto.
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::close): Ditto.
- page/History.cpp:
(WebCore::History::length): Ditto.
- page/Page.cpp:
(WebCore::Page::Page): Use more adoptPtr. Use backForwardClient instead of
backForwardControllerClient.
(WebCore::Page::~Page): Use backForward.
(WebCore::Page::backForwardList): Ditto.
(WebCore::Page::goBack): Ditto.
(WebCore::Page::goForward): Ditto.
(WebCore::Page::canGoBackOrForward): Ditto.
(WebCore::Page::goBackOrForward): Ditto.
(WebCore::Page::getHistoryLength): Ditto.
(WebCore::Page::PageClients::PageClients): Made non-inline.
(WebCore::Page::PageClients::~PageClients): Ditto.
- page/Page.h: Made PageClients constructor and destructor non-inline.
Added backForward function. Marked old functions as deprecated.
- page/Settings.cpp:
(WebCore::Settings::setUsesPageCache): Use backForward.
- platform/ContextMenu.cpp:
(WebCore::ContextMenu::populate): Ditto.
(WebCore::ContextMenu::checkOrEnableIfNeeded): Ditto.
- wml/WMLDoElement.cpp:
(WebCore::WMLDoElement::defaultEventHandler): Ditto.
- wml/WMLDocument.cpp:
(WebCore::WMLDocument::finishedParsing): Ditto.
- wml/WMLPageState.cpp:
(WebCore::WMLPageState::reset): Ditto.
(WebCore::tryAccessHistoryURLs): Ditto.
- wml/WMLPrevElement.cpp:
(WebCore::WMLPrevElement::executeTask): Ditto.
WebKit2:
- WebKit2.pro: Removed WebBackForwardControllerClient.cpp and .h.
- WebKit2.xcodeproj/project.pbxproj: Ditto.
- WebProcess/WebCoreSupport/WebBackForwardControllerClient.cpp: Removed.
- WebProcess/WebCoreSupport/WebBackForwardControllerClient.h: Removed.
- WebProcess/InjectedBundle/InjectedBundleBackForwardList.cpp:
(WebKit::InjectedBundleBackForwardList::itemAtIndex): Use backForward.
(WebKit::InjectedBundleBackForwardList::backListCount): Ditto.
(WebKit::InjectedBundleBackForwardList::forwardListCount): Ditto.
(WebKit::InjectedBundleBackForwardList::clear): Ditto.
- WebProcess/WebPage/WebBackForwardListProxy.h: Added newly-needed include.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Set up backForwardClient.
- 5:38 PM Changeset in webkit [70959] by
-
- 25 edits4 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=48663
Reviewed by Sam Weinig.
Make repaint invalidation work with vertical lines. Rewrite linesBoundingBox for RenderText and
RenderInline to give the correct rectangle back for vertical lines. Also patch linesVisibleOverflowBoundingBox
to give back the correct rectangle for vertical lines.
Fix bugs in the overflow accessors of InlineFlowBox when m_overflow was 0.
Added fast/repaint/inline-vertical-lr-overflow.html
WebCore:
- rendering/InlineBox.cpp:
(WebCore::InlineBox::adjustForFlippedBlocksWritingMode):
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::logicalLeftVisibleOverflow):
(WebCore::InlineFlowBox::logicalRightVisibleOverflow):
(WebCore::InlineFlowBox::bottomLayoutOverflow):
(WebCore::InlineFlowBox::rightLayoutOverflow):
(WebCore::InlineFlowBox::bottomVisualOverflow):
(WebCore::InlineFlowBox::rightVisualOverflow):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::adjustForFlippedBlocksWritingMode):
- rendering/RenderBox.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::linesVisibleOverflowBoundingBox):
(WebCore::RenderInline::clippedOverflowRectForRepaint):
- rendering/RenderText.cpp:
(WebCore::RenderText::linesBoundingBox):
LayoutTests:
- fast/repaint/inline-vertical-rl-overflow.html: Added.
- platform/mac/fast/blockflow/background-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/background-vertical-rl-expected.txt:
- platform/mac/fast/blockflow/basic-vertical-line-expected.txt:
- platform/mac/fast/blockflow/border-image-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/border-image-vertical-rl-expected.txt:
- platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
- platform/mac/fast/blockflow/border-vertical-lr-expected.png:
- platform/mac/fast/blockflow/border-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.txt:
- platform/mac/fast/blockflow/english-lr-text-expected.txt:
- platform/mac/fast/blockflow/english-rl-text-expected.txt:
- platform/mac/fast/blockflow/japanese-lr-text-expected.txt:
- platform/mac/fast/blockflow/japanese-rl-text-expected.txt:
- platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum: Added.
- platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.png: Added.
- platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.txt: Added.
- platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt:
- 5:37 PM Changeset in webkit [70958] by
-
- 321 edits320 copies in trunk/LayoutTests
2010-10-29 James Robinson <jamesr@chromium.org>
Update pixel expectations for Snow Leopard for tests in tables/mozilla/marvin.
Moves the leopard-specific mac baselines to platform/mac-leopard/ and adds new Snow Leopard pixel
expectations for tests that need them. List of files omitted due to length.
- 5:13 PM Changeset in webkit [70957] by
-
- 5 edits1 delete in trunk
2010-10-29 Mike Lawther <mikelawther@chromium.org>
Reviewed by James Robinson.
Fix canvas/philip/tests/2d.imageData.get.source.negative
https://bugs.webkit.org/show_bug.cgi?id=48277
Remove canvas/philip/tests/2d.imageData.get.source.negative from chromium skipped.
Also remove spurious trailing newlines from 2d.imageData.get.source.negative-expected.txt
- canvas/philip/tests/2d.imageData.get.source.negative-expected.txt:
- platform/chromium/test_expectations.txt:
2010-10-29 Mike Lawther <mikelawther@chromium.org>
Reviewed by James Robinson.
Fix canvas/philip/tests/2d.imageData.get.source.negative
https://bugs.webkit.org/show_bug.cgi?id=48277
Handle negative width/height.
See http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#pixel-manipulation
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::getImageData):
- 4:57 PM Changeset in webkit [70956] by
-
- 25 edits3 adds in trunk
2010-10-29 Kavita Kanetkar <kkanetkar@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: FileSystem integration
https://bugs.webkit.org/show_bug.cgi?id=45982
Adding filesystem support for Inspector under storage tab. This fetches root paths for
temporary and persistent filesystems and allows "reveal folder in OS" option that
launches native file browser. Currently this feature is disabled for non-chromium platforms.
- CMakeLists.txt:
- English.lproj/localizedStrings.js:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents):
- inspector/InspectorController.h: (WebCore::InspectorController::fileSystemAgent):
- inspector/InspectorFileSystemAgent.cpp: Added.
- inspector/InspectorFileSystemAgent.h: Added.
- inspector/front-end/FileSystemView.js: Added.
- inspector/front-end/Settings.js:
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addFileSystem): (WebInspector.StoragePanel.prototype.showFileSystem): (WebInspector.StoragePanel.prototype.updateFileSystemPath): (WebInspector.StoragePanel.prototype.updateFileSystemError): (WebInspector.FileSystemTreeElement): (WebInspector.FileSystemTreeElement.prototype.onselect):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css: (.file-system-storage-tree-item .icon):
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.updateResource): (WebInspector._addFileSystemOrigin): (WebInspector.didGetFileSystemPath): (WebInspector.didGetFileSystemError): (WebInspector.reset):
- platform/AsyncFileSystem.h: (WebCore::AsyncFileSystem::root):
- platform/FileSystem.h:
- platform/chromium/ChromiumBridge.h:
- platform/chromium/FileSystemChromium.cpp: (WebCore::revealFolderInOS):
2010-10-29 Kavita Kanetkar <kkanetkar@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: FileSystem integration
https://bugs.webkit.org/show_bug.cgi?id=45982
- public/WebFileUtilities.h: (WebKit::WebFileUtilities::revealFolderInOS):
- src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::revealFolderInOS):
- 4:53 PM Changeset in webkit [70955] by
-
- 2 edits in trunk/WebKit/gtk
2010-10-29 Martin Robinson <mrobinson@igalia.com>
Build fix for GTK+ after BackForwardListImpl introduction.
- webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_new_with_web_view):
- 4:45 PM Changeset in webkit [70954] by
-
- 8 edits in trunk/WebKit2
Stop using encode/decodeBytes for WebEvent subclasses
The use of encode/decodeBytes was making these classes sensitive to
differences in padding on different architectures (e.g., 32-bit vs.
64-bit). By encoding each data member explicitly we remove this
sensitivity, allowing these classes to be passed between processes
with different padding.
Fixes <http://webkit.org/b/48552> <rdar://problem/8606571> Mouse
events never reach Flash in WebKit2 on Mac (asserts in Debug builds)
Reviewed by Anders Carlsson.
- Platform/CoreIPC/Arguments.h:
(CoreIPC::Arguments8::Arguments8):
(CoreIPC::Arguments8::encode):
(CoreIPC::Arguments8::decode):
(CoreIPC::In):
(CoreIPC::Out):
Added Arguments8, the biggest Arguments yet.
- Shared/WebEvent.cpp:
(WebKit::WebEvent::encode):
(WebKit::WebEvent::decode):
- Shared/WebKeyboardEvent.cpp:
(WebKit::WebKeyboardEvent::encode):
(WebKit::WebKeyboardEvent::decode):
- Shared/WebMouseEvent.cpp:
(WebKit::WebMouseEvent::encode):
(WebKit::WebMouseEvent::decode):
- Shared/WebPlatformTouchPoint.cpp:
(WebKit::WebPlatformTouchPoint::encode):
(WebKit::WebPlatformTouchPoint::decode):
- Shared/WebTouchEvent.cpp:
(WebKit::WebTouchEvent::encode):
(WebKit::WebTouchEvent::decode):
- Shared/WebWheelEvent.cpp:
(WebKit::WebWheelEvent::encode):
(WebKit::WebWheelEvent::decode):
Changed all encode/decode function to use CoreIPC::In/Out to
encode/decode data members individually.
- 4:44 PM Changeset in webkit [70953] by
-
- 2 edits in trunk/WebKit2
Use only CoreIPC-sanctioned types in WebEvent subclasses
Fixes <http://webkit.org//48694> WebEvent subclasses should not use
architecture-dependent types
Reviewed by Anders Carlsson.
- Shared/WebEvent.h:
(WebKit::WebEvent::type):
(WebKit::WebMouseEvent::button):
(WebKit::WebMouseEvent::clickCount):
(WebKit::WebWheelEvent::granularity):
(WebKit::WebPlatformTouchPoint::id):
(WebKit::WebPlatformTouchPoint::state):
Replaced enums, ints, and unsigneds with uint32_ts, int32_ts, and
uint32_ts, respectively.
- 4:44 PM Changeset in webkit [70952] by
-
- 3 edits in trunk/LayoutTests
2010-10-29 Aaron Colwell <acolwell@chromium.org>
Reviewed by David Levin.
Disable media/video-canvas-alpha.html for Qt & GTK
https://bugs.webkit.org/show_bug.cgi?id=48688
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 4:37 PM Changeset in webkit [70951] by
-
- 3 edits in trunk/WebKit2
Generate a DelayedReply struct for sync messages marked delayed
https://bugs.webkit.org/show_bug.cgi?id=48696
Reviewed by Adam Roben.
- Scripts/webkit2/messages.py:
If we encounter a sync message marked delayed, generate a DelayedReply struct with a send member funciton
that can be used for sending the reply.
- Scripts/webkit2/messages_unittest.py:
Update expected results.
- 4:34 PM Changeset in webkit [70950] by
-
- 89 edits88 copies in trunk/LayoutTests
2010-10-29 James Robinson <jamesr@chromium.org>
Update Snow Leopard pixel baselines for tests in tables/mozilla pt 1
This updates the pixel baselines in platform/mac to be valid for Snow Leopard for tests
in tables/mozilla/collapsing_borders, /core, /dom, and /other. Old baselines moved to
platform/mac-leopard.
- 4:31 PM Changeset in webkit [70949] by
-
- 3 edits in trunk/LayoutTests
[Chromium] Unreviewed, test expectations update.
- platform/chromium-win/editing/deleting/5390681-2-expected.checksum:
- platform/chromium-win/editing/deleting/5390681-2-expected.png:
- 4:24 PM Changeset in webkit [70948] by
-
- 2 edits in trunk/WebKit/qt
2010-10-29 Andreas Kling <kling@webkit.org>
Reviewed by Ariya Hidayat.
[Qt] QWebPage's InputMethod event handling calls ShortcutOverride handler too
https://bugs.webkit.org/show_bug.cgi?id=48692
- Api/qwebpage.cpp: (QWebPage::event): Add missing break statement.
- 4:22 PM Changeset in webkit [70947] by
-
- 2 edits in trunk/WebKitTools
2010-10-29 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QtTestBrowser: Add keyboard shortcut to toggle full screen (F11)
https://bugs.webkit.org/show_bug.cgi?id=48695
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome):
- 4:19 PM Changeset in webkit [70946] by
-
- 3 edits in trunk/WebKitTools
2010-10-29 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QtTestBrowser: Fix uninitialized read in FpsTimer
https://bugs.webkit.org/show_bug.cgi?id=48675
FpsTimer::m_timer was never initialized and passed to QObject::killTimer()
on startup with in -graphicsbased mode.
- QtTestBrowser/fpstimer.cpp: (FpsTimer::FpsTimer): (FpsTimer::numFrames): (FpsTimer::stop): (FpsTimer::timerEvent):
- QtTestBrowser/fpstimer.h:
- 4:15 PM Changeset in webkit [70945] by
-
- 8 edits in trunk
2010-10-29 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Remove RenderTextControl::setSelectionRange
https://bugs.webkit.org/show_bug.cgi?id=47870
Converted RenderTextControll::setSelectionRange to a global function.
- Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent): Calls setSelectionRange.
2010-10-29 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Remove RenderTextControl::setSelectionRange
https://bugs.webkit.org/show_bug.cgi?id=47870
Made RenderTextControl::setSelectionRange a global function.
Removed setSelectionStart, setSelectionEnd, and select from RenderTextControl.
No new tests are added since there is no behavioral change.
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::setSelectedTextRange): Calls setSelectedTextRange.
- dom/InputElement.cpp: (WebCore::InputElement::updateSelectionRange): Ditto.
- html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::setSelectionStart): Ditto. (WebCore::HTMLTextFormControlElement::setSelectionEnd): Ditto. (WebCore::HTMLTextFormControlElement::select): Ditto. (WebCore::HTMLTextFormControlElement::setSelectionRange): Ditto.
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::hasVisibleTextArea): Added. (WebCore::setSelectionRange): See above.
- rendering/RenderTextControl.h:
- 3:48 PM Changeset in webkit [70944] by
-
- 191 edits190 copies1 add in trunk/LayoutTests
2010-10-29 James Robinson <jamesr@chromium.org>
Update pixel expectations for Snow Leopard for tests in tables/mozilla_expected_failures.
Moves the leopard-specific mac baselines to platform/mac-leopard/ and adds new Snow Leopard pixel
expectations for 96 tests that need them. List of files omitted due to length.
- 3:46 PM Changeset in webkit [70943] by
-
- 7 edits1 copy1 add in trunk/WebKitTools
2010-10-29 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: change TestResults to be serializable
In preparation for changing new-run-webkit-tests from
multithreaded to multiprocess, we need to make sure the data
going between the threads is easily serialized over a socket.
This change adds serialization/pickling for the TestResults and
TestFailure objects (using cPickle).
The TestFailure objects included a "has_wdiff" flag for Text
results, but the flag wasn't being used, so I've removed it,
simplifying the state to basically a set of enum objects with
associated methods.
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
- Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/test_results.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:Added.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/test_types/text_diff.py:
- 3:44 PM Changeset in webkit [70942] by
-
- 3 edits in trunk/WebKitTools
2010-10-29 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: need to provide separate dashboard results for GPU tests
https://bugs.webkit.org/show_bug.cgi?id=48687
Modify the steps to upload the JSON files to the dashboards so
that the GPU tests don't conflict with the regular tests on a
port. We do this by modifying the --builder-name parameter to
append " - GPU", which should cause the app to treat the results
as a completely new builder. This is a little non-obvious, but
keeps us from having to restructure the app.
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
- Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 3:39 PM Changeset in webkit [70941] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
- platform/chromium/test_expectations.txt:
- 3:36 PM Changeset in webkit [70940] by
-
- 3 edits in trunk/LayoutTests
2010-10-29 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
Results for media test controls-drag-timebar.html are needlessly platform specific
https://bugs.webkit.org/show_bug.cgi?id=48662
- media/controls-drag-timebar-expected.txt:
- media/controls-drag-timebar.html: Remove some of the logging to avoid timing differences on slower machines.
- 3:32 PM Changeset in webkit [70939] by
-
- 4 edits in branches/chromium/552
Merge 70923 - 2010-10-28 Michael Nordman <Michael Nordman>
Reviewed by ap.
[Chrome] Fix an appcache regression introduced in r69226
https://bugs.webkit.org/show_bug.cgi?id=48592
Provide a noop method body ApplicationCacheHost::maybeLoadMainResourceForRedirect.
- src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::maybeLoadMainResourceForRedirect):
2010-10-28 Michael Nordman <Michael Nordman>
Reviewed by ap.
[Chrome] Fix an appcache regression introduced in r69226
https://bugs.webkit.org/show_bug.cgi?id=48592
Define a new ApplicationCacheHost method for the specific case of main resource redirect handling.
Tests: the existing layout test applies
- loader/MainResourceLoader.cpp: use the newly introduced method (WebCore::MainResourceLoader::willSendRequest):
- loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::maybeLoadMainResourceForRedirect):
- loader/appcache/ApplicationCacheHost.h:
TBR=Michael Nordman
- 3:23 PM Changeset in webkit [70938] by
-
- 5 edits in trunk/LayoutTests
Update test results for the presence of HTMLMeterElement
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- platform/win/fast/dom/prototype-inheritance-expected.txt:
- platform/win/fast/js/global-constructors-expected.txt:
- 3:23 PM Changeset in webkit [70937] by
-
- 2 edits22 adds in trunk/LayoutTests
Stop skipping HTMLMeterElement tests on Windows and check in results for them
Fixes <http://webkit.org/b/48681>
fast/dom/HTMLMeterElement/meter-boundary-values.html fails on Windows
- platform/win/Skipped: Removed HTMLMeterElement tests.
- platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
- platform/win/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
- 3:16 PM Changeset in webkit [70936] by
-
- 8 edits in trunk/WebKit2
Use WebPage::send in a couple of more places.
Reviewed by Adam Roben.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::setWindowRect):
(WebKit::WebChromeClient::takeFocus):
(WebKit::WebChromeClient::setToolbarsVisible):
(WebKit::WebChromeClient::setStatusbarVisible):
(WebKit::WebChromeClient::setMenubarVisible):
(WebKit::WebChromeClient::setResizable):
(WebKit::WebChromeClient::setStatusbarText):
(WebKit::WebChromeClient::contentsSizeChanged):
(WebKit::WebChromeClient::mouseDidMoveOverElement):
(WebKit::WebChromeClient::setToolTip):
(WebKit::WebChromeClient::setCursor):
(WebKit::WebChromeClient::dispatchViewportDataDidChange):
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::registerCommandForUndo):
(WebKit::WebEditorClient::clearUndoRedoOperations):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::detachedFromParent2):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle):
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout):
(WebKit::WebFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
(WebKit::WebFrameLoaderClient::postProgressStartedNotification):
(WebKit::WebFrameLoaderClient::postProgressEstimateChangedNotification):
(WebKit::WebFrameLoaderClient::postProgressFinishedNotification):
(WebKit::WebFrameLoaderClient::didDisplayInsecureContent):
(WebKit::WebFrameLoaderClient::didRunInsecureContent):
(WebKit::WebFrameLoaderClient::dispatchDidBecomeFrameset):
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findString):
(WebKit::FindController::hideFindIndicator):
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::WebBackForwardListProxy::addItem):
(WebKit::WebBackForwardListProxy::goToItem):
(WebKit::WebBackForwardListProxy::clear):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createMainFrame):
(WebKit::WebFrame::createSubframe):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendClose):
(WebKit::WebPage::pageDidScroll):
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::wheelEvent):
(WebKit::WebPage::keyEvent):
(WebKit::WebPage::validateMenuItem):
(WebKit::WebPage::touchEvent):
(WebKit::WebPage::show):
(WebKit::WebPage::runJavaScriptInMainFrame):
(WebKit::WebPage::getRenderTreeExternalRepresentation):
(WebKit::WebPage::getSourceForFrame):
- 3:15 PM Changeset in webkit [70935] by
-
- 2 edits in trunk/WebCore
2010-10-29 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Andreas Kling.
[GTK] Crash in TextEncoding.cpp when using glib unicode
https://bugs.webkit.org/show_bug.cgi?id=48521
When the conversion to UTF-8 fails, try to encode the original string
without normalizing. Fixes tests cases:
fast/url/anchor.html
fast/url/query.html
fast/url/standard-url.html
- platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encode):
- 3:02 PM Changeset in webkit [70934] by
-
- 8 edits1 add in trunk/WebKit2
Add a MessageSender class template
https://bugs.webkit.org/show_bug.cgi?id=48683
Reviewed by Adam Roben.
- Platform/CoreIPC/MessageSender.h: Added.
(CoreIPC::MessageSender::send):
Add send overloads for simple message sending.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
Add MessageSender.h
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::countStringMatches):
(WebKit::FindController::findString):
(WebKit::FindController::updateFindIndicator):
Call send on the web page.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::connection):
Add connection(), used by the MessageSender.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::destinationID):
Add destinationID(), used by the MessageSender.
- win/WebKit2.vcproj:
Add MessageSender.h
- 3:01 PM Changeset in webkit [70933] by
-
- 2 edits in trunk/WebCore
2010-10-29 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Antonio Gomes.
TextureMapperGL get the driver info log but do not use it
https://bugs.webkit.org/show_bug.cgi?id=48247
Remove the call to glGetProgramInfoLog().
- platform/graphics/opengl/TextureMapperGL.cpp: (WebCore::TexmapShaderInfo::createShaderProgram):
- 2:47 PM Changeset in webkit [70932] by
-
- 10 edits in trunk
2010-10-29 Benjamin Kalman <kalman@google.com>
Reviewed by Tony Chang.
Deleting contenteditable text to the left of a non-contenteditable span inserts unnecessary placeholder <br/>
https://bugs.webkit.org/show_bug.cgi?id=48658
- editing/deleting/5390681-expected.txt: Update test for changed behaviour.
- editing/deleting/5390681.html: Ditto (update comment).
- editing/deleting/delete-mixed-editable-content-001-expected.txt: Ditto.
- editing/pasteboard/copy-backslash-with-euc-expected.txt: Ditto.
2010-10-29 Benjamin Kalman <kalman@google.com>
Reviewed by Tony Chang.
Deleting contenteditable text to the left of a non-contenteditable span inserts unnecessary placeholder <br/>
https://bugs.webkit.org/show_bug.cgi?id=48658
- WebCore.exp.in: Update is{Start,End}OfParagraph symbols.
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply): Cross editability boundaries when determining whether to insert placeholder.
- editing/visible_units.cpp: Allow editability boundary to be crossed in {start,end,isStart,isEnd}OfParagraph. (WebCore::startOfParagraph): Also, avoid returning a position where renderer can't accept caret, like in endOfParagraph. (WebCore::endOfParagraph): (WebCore::isStartOfParagraph): (WebCore::isEndOfParagraph):
- editing/visible_units.h: Ditto.
- 2:38 PM Changeset in webkit [70931] by
-
- 23 edits in trunk/WebKit
2010-10-29 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
https://bugs.webkit.org/show_bug.cgi?id=48574
- src/BackForwardListClientImpl.h: Use BackForwardListImpl.h.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): Cast to BackForwardList* before calling setClient.
2010-10-29 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
https://bugs.webkit.org/show_bug.cgi?id=48574
- Api/qwebhistory.cpp: (QWebHistory::clear):
- Api/qwebhistory_p.h:
- Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): Use BackForwardListImpl.
2010-10-29 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
https://bugs.webkit.org/show_bug.cgi?id=48574
- webkit/webkitprivate.h:
- webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_dispose): (webkit_web_back_forward_list_new_with_web_view): (webkit_web_back_forward_list_go_forward): (webkit_web_back_forward_list_go_back): (webkit_web_back_forward_list_contains_item): (webkit_web_back_forward_list_go_to_item): (webkit_web_back_forward_list_get_forward_list_with_limit): (webkit_web_back_forward_list_get_back_list_with_limit): (webkit_web_back_forward_list_get_back_item): (webkit_web_back_forward_list_get_current_item): (webkit_web_back_forward_list_get_forward_item): (webkit_web_back_forward_list_get_nth_item): (webkit_web_back_forward_list_get_back_length): (webkit_web_back_forward_list_get_forward_length): (webkit_web_back_forward_list_get_limit): (webkit_web_back_forward_list_set_limit): (webkit_web_back_forward_list_add_item): (webkit_web_back_forward_list_clear): (WebKit::core):
- webkit/webkitwebview.cpp: (webkit_web_view_set_maintains_back_forward_list): (webkit_web_view_get_back_forward_list): Use BackForwardListImpl.
2010-10-29 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
https://bugs.webkit.org/show_bug.cgi?id=48574
- WebBackForwardList.cpp: (backForwardListWrappers): (WebBackForwardList::WebBackForwardList): (WebBackForwardList::createInstance):
- WebBackForwardList.h:
- WebView.cpp: (WebView::backForwardList): Use BackForwardListImpl.
2010-10-29 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
https://bugs.webkit.org/show_bug.cgi?id=48574
- WebFrame.cpp: (wxWebFrame::CanGoBack): Use canGoBackOrForward. (wxWebFrame::CanGoForward): Ditto.
2010-10-29 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
https://bugs.webkit.org/show_bug.cgi?id=48574
- History/WebBackForwardList.mm: Use BackForwardListImpl.
2010-10-29 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
https://bugs.webkit.org/show_bug.cgi?id=48574
- ewk/ewk_history.cpp: (ewk_history_new):
- ewk/ewk_private.h:
- ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_history_enable_get): (ewk_view_history_enable_set): (ewk_view_history_get): Use BackForwardListImpl.
- 2:31 PM Changeset in webkit [70930] by
-
- 2 edits in trunk/WebKit2
Add the plug-in proxy to the map before sending the CreatePlugin message
https://bugs.webkit.org/show_bug.cgi?id=48678
Reviewed by Adam Roben.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::initialize):
- 2:28 PM Changeset in webkit [70929] by
-
- 7 edits in trunk/WebCore
2010-10-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: last active panel is not restored upon opening inspector.
https://bugs.webkit.org/show_bug.cgi?id=48668
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspect): (WebCore::InspectorController::showPanel): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::populateScriptObjects):
- inspector/InspectorController.h:
- inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
- inspector/front-end/Settings.js: (WebInspector.Settings):
- inspector/front-end/inspector.js: (WebInspector.set currentPanel): (WebInspector.doLoadedDone.onPopulateScriptObjects): (WebInspector.doLoadedDone): (WebInspector.documentClick.followLink): (WebInspector.documentClick):
- 2:26 PM Changeset in webkit [70928] by
-
- 3 edits in trunk/WebKit2
Remove redundant data members from WebTouchEvent
WebEvent already stores the Type and timestamp.
Fixes <http://webkit.org/b/48671> WebTouchEvent duplicates data from
WebEvent
Reviewed by Anders Carlsson.
- Shared/WebEvent.h:
- Shared/WebTouchEvent.cpp:
(WebKit::WebTouchEvent::WebTouchEvent):
Removed m_type and m_timestamp (which was never even getting
initialized!).
- 2:24 PM Changeset in webkit [70927] by
-
- 5 edits in trunk/WebKit2
Add GetWindowScriptNPObject message
https://bugs.webkit.org/show_bug.cgi?id=48670
Reviewed by Adam Roben.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::windowScriptNPObject):
Send the GetWindowScriptNPObject message.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::getWindowScriptNPObject):
Add stub.
- WebProcess/Plugins/PluginProxy.messages.in:
Add GetWindowScriptNPObject message.
- 2:18 PM Changeset in webkit [70926] by
-
- 3 edits1 add7 deletes in trunk/LayoutTests
2010-10-29 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
Results for media test controls-drag-timebar.html are needlessly platform specific
https://bugs.webkit.org/show_bug.cgi?id=48662
- media/controls-drag-timebar-expected.txt: Added.
- media/controls-drag-timebar.html: Remove all platform specific logging.
- platform/chromium-mac/media/controls-drag-timebar-expected.txt: Removed.
- platform/chromium-win/media/controls-drag-timebar-expected.txt: Removed.
- platform/gtk/media/controls-drag-timebar-expected.txt: Removed.
- platform/mac-leopard/media/controls-drag-timebar-expected.txt: Removed.
- platform/mac-snowleopard/Skipped: Unskip test.
- platform/mac-tiger/media/controls-drag-timebar-expected.txt: Removed.
- platform/mac/media/controls-drag-timebar-expected.txt: Removed.
- platform/win/media/controls-drag-timebar-expected.txt: Removed.
- 2:07 PM Changeset in webkit [70925] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
- platform/chromium/test_expectations.txt:
- 2:06 PM Changeset in webkit [70924] by
-
- 2 edits in trunk/WebKitTools
2010-10-29 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
[chromium] add debug logging to help diagnose flakiness dashboard issues
https://bugs.webkit.org/show_bug.cgi?id=48657
The appengine app thinks it's getting empty files uploaded. Add some logging
to see if new-run-webkit-tests agrees.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 2:06 PM Changeset in webkit [70923] by
-
- 6 edits in trunk
2010-10-28 Michael Nordman <Michael Nordman>
Reviewed by ap.
[Chrome] Fix an appcache regression introduced in r69226
https://bugs.webkit.org/show_bug.cgi?id=48592
Provide a noop method body ApplicationCacheHost::maybeLoadMainResourceForRedirect.
- src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::maybeLoadMainResourceForRedirect):
2010-10-28 Michael Nordman <Michael Nordman>
Reviewed by ap.
[Chrome] Fix an appcache regression introduced in r69226
https://bugs.webkit.org/show_bug.cgi?id=48592
Define a new ApplicationCacheHost method for the specific case of main resource redirect handling.
Tests: the existing layout test applies
- loader/MainResourceLoader.cpp: use the newly introduced method (WebCore::MainResourceLoader::willSendRequest):
- loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::maybeLoadMainResourceForRedirect):
- loader/appcache/ApplicationCacheHost.h:
- 2:00 PM Changeset in webkit [70922] by
-
- 3 edits2 adds in trunk
2010-10-29 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
Navigating to a .wav file creates a plugin document but should create a media document
https://bugs.webkit.org/show_bug.cgi?id=48546
<rdar://problem/8606105>
Test: media/media-can-play-wav-audio.html
- platform/MIMETypeRegistry.cpp: Add mapping from ".wav" to "audio/x-wav".
2010-10-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
Navigating to a .wav file creates a plugin document but should create a media document
https://bugs.webkit.org/show_bug.cgi?id=48546
<rdar://problem/8606105>
- media/media-can-play-wav-audio-expected.txt: Added.
- media/media-can-play-wav-audio.html: Added.
- 1:52 PM Changeset in webkit [70921] by
-
- 96 edits94 copies in trunk/LayoutTests
2010-10-29 Mihai Parparita <mihaip@chromium.org>
Update the pixel expectations for fast/block/float for the Mac port.
For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.
List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.
platform/mac/test_expectations.txt was also modified to remove a
now-passing test.
- 1:51 PM Changeset in webkit [70920] by
-
- 12 edits in trunk/WebKit2
Change the Connection::sendSync timeout parameter to have the NoTimeout argument as a default
argument and update all the call sites.
Reviewed by Dan Bernstein.
- Platform/CoreIPC/Connection.h:
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::proxiesForURL):
(WebKit::PluginControllerProxy::cookiesForURL):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::postSynchronousMessage):
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::initialize):
(WebKit::PluginProxy::destroy):
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::handleMouseEvent):
(WebKit::PluginProxy::handleWheelEvent):
(WebKit::PluginProxy::handleMouseEnterEvent):
(WebKit::PluginProxy::handleMouseLeaveEvent):
(WebKit::PluginProxy::handleKeyboardEvent):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::windowRect):
(WebKit::WebChromeClient::createWindow):
(WebKit::WebChromeClient::toolbarsVisible):
(WebKit::WebChromeClient::statusbarVisible):
(WebKit::WebChromeClient::menubarVisible):
(WebKit::WebChromeClient::canRunBeforeUnloadConfirmPanel):
(WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::populatePluginCache):
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::WebBackForwardListProxy::itemAtIndex):
(WebKit::WebBackForwardListProxy::backListCount):
(WebKit::WebBackForwardListProxy::forwardListCount):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
(WebKit::WebPage::changeAcceleratedCompositingMode):
- WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:
(WebKit::LayerBackedDrawingArea::attachCompositingContext):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::interceptEditingKeyboardEvent):
- 1:49 PM Changeset in webkit [70919] by
-
- 7 edits6 adds in trunk
2010-10-29 Aaron Colwell <acolwell@chromium.org>
Reviewed by James Robinson.
Added a layout test for verifying that globalAlpha is properly handled
when copying a video frame to a 2D canvas context.
https://bugs.webkit.org/show_bug.cgi?id=48094
- media/video-canvas-alpha-expected.txt: Added.
- media/video-canvas-alpha.html: Added.
- platform/chromium-mac/media/video-canvas-alpha-expected.checksum: Added.
- platform/chromium-mac/media/video-canvas-alpha-expected.png: Added.
- platform/chromium-win/media/video-canvas-alpha-expected.checksum: Added.
- platform/chromium-win/media/video-canvas-alpha-expected.png: Added.
2010-10-29 Aaron Colwell <acolwell@chromium.org>
Reviewed by James Robinson.
Created helper method WebCore::PlatformContextSkia::getNormalizedAlpha()
to centralize alpha rounding & clipping logic.
https://bugs.webkit.org/show_bug.cgi?id=48094
Test: media/video-canvas-alpha.html
- platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap):
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::getNormalizedAlpha):
- platform/graphics/skia/PlatformContextSkia.h:
2010-10-29 Aaron Colwell <acolwell@chromium.org>
Reviewed by James Robinson.
Fix globalAlpha support when using drawImage() to copy a video frame
to a 2D canvas context.
https://bugs.webkit.org/show_bug.cgi?id=48094
This fix applies the globalAlpha value to the canvas before passing it
down to the lower layers that don't have access to the graphics
context. This makes sure that any drawing on the canvas will have the
proper global alpha value applied.
- src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::paint):
- 1:33 PM Changeset in webkit [70918] by
-
- 8 edits2 adds in trunk
2010-10-29 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
ASSERT when SVGAnimatedProperty instance is assigned to multiple elements.
https://bugs.webkit.org/show_bug.cgi?id=48555
Test: svg/custom/insertItemBefore-from-non-list-origin.svg
- bindings/scripts/CodeGeneratorJS.pm: Include SVGAnimatedPropertyTearOff.h instead of SVGPropertyTearOff.h
- bindings/scripts/CodeGeneratorObjC.pm: Ditto.
- bindings/scripts/CodeGeneratorV8.pm: Ditto.
- svg/properties/SVGAnimatedListPropertyTearOff.h: (WebCore::SVGAnimatedListPropertyTearOff::isAnimatedListTearOff): Return true. (WebCore::SVGAnimatedListPropertyTearOff::removeItemFromList): Devirtualize function.
- svg/properties/SVGAnimatedProperty.h: (WebCore::SVGAnimatedProperty::isAnimatedListTearOff): Return false.
- svg/properties/SVGListPropertyTearOff.h: (WebCore::SVGListPropertyTearOff::removeItemFromListIfNeeded): Only try to remove the passed item from its list, if its actually a list and not just a SVGAnimatedProperty.
2010-10-29 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
ASSERT when SVGAnimatedProperty instance is assigned to multiple elements.
https://bugs.webkit.org/show_bug.cgi?id=48555
- svg/custom/insertItemBefore-from-non-list-origin-expected.txt: Added.
- svg/custom/insertItemBefore-from-non-list-origin.svg: Added.
- 1:25 PM Changeset in webkit [70917] by
-
- 9 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=48444
Reviewed by Adam Roben.
Fix the dirty rect checks in RenderBoxLineList, InlineFlowBox, InlineTextBox. They were still assuming horizontal-tb writing-mode.
This patch makes the checks directionally abstract and also refactors the checks in RenderLineBoxList to share code.
No tests yet, since the invalidation code for inlines still assumes horizontal-tb. That will be fixed in a follow-up bug,
and then repaint tests will be easy to write.
- rendering/InlineBox.cpp:
(WebCore::InlineBox::adjustForFlippedBlocksWritingMode):
- rendering/InlineBox.h:
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paint):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::convertFromFlippedWritingMode):
- rendering/RenderBox.h:
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::rangeIntersectsDirtyRect):
(WebCore::RenderLineBoxList::anyLineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
- rendering/RenderLineBoxList.h:
- 1:06 PM Changeset in webkit [70916] by
-
- 5 edits in trunk/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48666
WebKit2 should provide counterpart getter to WKBundleNodeHandleSetHTMLInputElementAutofilled
Reviewed by Anders Carlsson.
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
(WKBundleNodeHandleGetHTMLInputElementAutofilled):
New function, calls through to InjectedBundleNodeHandle.
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
Declared new function.
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::isHTMLInputElementAutofilled):
New function, calls through to HTMLInputElement.
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
Declared new function.
- 12:30 PM Changeset in webkit [70915] by
-
- 2 edits in trunk/WebKit2
ASSERTION FAILURE in WebProcessProxy::frameDestroyed when a Page is closed before it can send
the DidCreateMainFrame messsage to the UIProcess.
https://bugs.webkit.org/show_bug.cgi?id=48654
Reviewed by Anders Carlsson.
WebProcessProxy::frameDestroyed was asserting that the frameID it was called with was
registered in WebProcessProxy::frameCreated (which is called when the WebPageProxy is
created). However, in the case where we close the page before it's had the chance to send
the DidCreateMainFrame message back to the UI process, the UI Process will get the
DidDestroyFrame message because it's sent directly to the WebProcessProxy and doesn't go
through WebPageProxy.
Remove the assert because it is invalid in this case.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::frameDestroyed):
- 12:13 PM Changeset in webkit [70914] by
-
- 2 edits in trunk/WebCore
2010-10-29 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
Cleanup createGlobalImageFileDescriptor in ClipboardWin
https://bugs.webkit.org/show_bug.cgi?id=48189
- platform/win/ClipboardWin.cpp: (WebCore::createGlobalURLContent): (WebCore::createGlobalUrlFileDescriptor): (WebCore::ClipboardWin::writeURL):
- 12:00 PM Changeset in webkit [70913] by
-
- 4 edits in trunk/LayoutTests
2010-10-29 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
[Chromium] fast/loader/stateobjects/state-api-on-detached-frame-crash.html does not pass on Chromium
https://bugs.webkit.org/show_bug.cgi?id=48647
Chromium throws an exception if calling push/replaceState on a detached
frame, while the mac port fails silently (presumably a JSC vs. V8
difference). Either behavior is correct (as long as we don't crash),
make the test handle both.
- fast/loader/stateobjects/state-api-on-detached-frame-crash-expected.txt:
- fast/loader/stateobjects/state-api-on-detached-frame-crash.html:
- platform/chromium/test_expectations.txt:
- 12:00 PM Changeset in webkit [70912] by
-
- 2 edits in trunk/WebCore
[Chromium clang] Unreviewed fix removing compiler warning.
If GIFImageReader is a struct, don't call it a class.
- platform/image-decoders/gif/GIFImageDecoder.h:
- 11:56 AM Changeset in webkit [70911] by
-
- 2 edits in trunk/WebKit/mac
Rubber-stamped by Sam Weinig.
Comment for usesDocumentViews explains it backwards. This flag is true in ToT, and we do
create views for subframes.
- WebView/WebViewData.h: Double negation is better than a lie.
- 11:55 AM Changeset in webkit [70910] by
-
- 4 edits3 adds in trunk
2010-10-29 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
REGRESSION: r69429-r69611: Crash in JSC::Interpreter::privateExecute
https://bugs.webkit.org/show_bug.cgi?id=47573
I think the interpreter portion of this was introduced by
an incorrect but silent merge when I updated prior to committing.
The JIT change is basically just a correctness fix, but it is
needed to prevent the testcase from asserting in debug builds.
The basic problem is incorrectly setting the activation object
on an arguments object. The crash was due to us setting a null
activation in the interpreter, in the jit we were setting the
activation of a strict mode arguments object.
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
- wtf/Platform.h:
2010-10-29 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
REGRESSION: r69429-r69611: Crash in JSC::Interpreter::privateExecute
https://bugs.webkit.org/show_bug.cgi?id=47573
Add a test to ensure that we don't incorrectly set a null activation
as an argument object's activation.
- fast/js/interpreter-no-activation-expected.txt: Added.
- fast/js/interpreter-no-activation.html: Added.
- fast/js/script-tests/interpreter-no-activation.js: Added.
- 11:48 AM Changeset in webkit [70909] by
-
- 5 edits2 copies in branches/chromium/517
Merge 70748 - 2010-10-27 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
r66156 broke AtlasCT library, formerly affected http://map.d.co.il/
https://bugs.webkit.org/show_bug.cgi?id=45679
This patch removes WebKit's map of classid values to MIME types. It also
changes the behavior of object elements to render fallback content when
a non-empty classid attribute is specified, which is the behavior HTML5
specifies when a UA encounters a classid it doesn't understand.
Test: fast/replaced/object-with-non-empty-classid-triggers-fallback.html
- html/HTMLObjectElement.cpp: Remove serviceTypeForClassId(), createClassIdToTypeMap(), and the ClassIdToTypeMap typedef. (WebCore::HTMLObjectElement::updateWidget): Do not call serviceTypeForClassId() when there is no type attribute, and render fallback content if the classid attribute is non-empty.
2010-10-27 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
r66156 broke AtlasCT library, formerly affected http://map.d.co.il/
https://bugs.webkit.org/show_bug.cgi?id=45679
- fast/dom/object-embed-plugin-scripting.html: Changed classid attributes to type attributes.
- fast/dom/object-plugin-hides-properties.html: Ditto.
- fast/replaced/object-with-non-empty-classid-triggers-fallback-expected.txt: Added.
- fast/replaced/object-with-non-empty-classid-triggers-fallback.html: Added.
TBR=cpu@google.com
BUG=57986
Review URL: http://codereview.chromium.org/4214004
- 11:43 AM Changeset in webkit [70908] by
-
- 2 edits in trunk/LayoutTests
2010-10-29 Mihai Parparita <mihaip@chromium.org>
Unreviewed cleanp of platform/chromium/test_expectations.txt
Group http/tests/navigation failures together, and differentiate between
flaky/failing tests and those that need updated baselines (though really
they shouldn't be pixel tests in the first place).
Also enable http/tests/navigation/post-goback-repost-policy.html, it
seems to be passing now (we've enabled sessionStorage for a while).
- platform/chromium/test_expectations.txt:
- 11:40 AM Changeset in webkit [70907] by
-
- 2 edits in trunk/WebCore
Fix the world (d'oh!)
https://bugs.webkit.org/show_bug.cgi?id=48576
Let WebKit2 client know when a frame is a frameset
- html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::insertedIntoDocument): (WebCore::HTMLFrameSetElement::removedFromDocument): Call base class version.
- 11:36 AM Changeset in webkit [70906] by
-
- 2 edits in trunk/WebCore
Unreviewed. Fix chromium build break.
- bindings/v8/custom/V8FileReaderCustom.cpp:
(WebCore::V8FileReader::resultAccessorGetter):
- 11:28 AM Changeset in webkit [70905] by
-
- 2 edits in trunk/WebKitTools
2010-10-29 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Ojan Vafai.
[Chromium/DRT] Add master-name flag to new-run-webkit-tests.
https://bugs.webkit.org/show_bug.cgi?id=48649
- BuildSlaveSupport/build.webkit.org-config/master.cfg: Added flag.
- 11:23 AM Changeset in webkit [70904] by
-
- 26 edits2 copies2 adds in trunk
Support readAsArrayBuffer in FileReader and FileReaderSync
https://bugs.webkit.org/show_bug.cgi?id=47691
Reviewed by David Levin.
WebCore:
Merge the similar code in FileReader and FileReaderSync into
FileReaderLoader.
Test cases have been added to read-file-test-cases.js.
- Android.jscbindings.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/v8/custom/V8FileReaderCustom.cpp: Added.
- fileapi/FileReader.cpp:
(WebCore::FileReader::FileReader):
(WebCore::FileReader::readAsArrayBuffer):
(WebCore::FileReader::readAsBinaryString):
(WebCore::FileReader::readAsText):
(WebCore::FileReader::readAsDataURL):
(WebCore::FileReader::readInternal):
(WebCore::FileReader::doAbort):
(WebCore::FileReader::terminate):
(WebCore::FileReader::start):
(WebCore::FileReader::didStartLoading):
(WebCore::FileReader::didReceiveData):
(WebCore::FileReader::didFinishLoading):
(WebCore::FileReader::didFail):
(WebCore::FileReader::fireEvent):
(WebCore::FileReader::arrayBufferResult):
(WebCore::FileReader::stringResult):
- fileapi/FileReader.h:
(WebCore::FileReader::readType):
- fileapi/FileReader.idl:
- fileapi/FileReaderLoader.cpp: Added.
- fileapi/FileReaderLoader.h: Added.
- fileapi/FileReaderLoaderClient.h: Added.
- fileapi/FileReaderSync.cpp:
(WebCore::FileReaderSync::FileReaderSync):
(WebCore::FileReaderSync::readAsArrayBuffer):
(WebCore::FileReaderSync::readAsBinaryString):
(WebCore::FileReaderSync::readAsText):
(WebCore::FileReaderSync::readAsDataURL):
(WebCore::FileReaderSync::startLoading):
- fileapi/FileReaderSync.h:
- fileapi/FileReaderSync.idl:
- html/canvas/ArrayBuffer.cpp:
(WebCore::ArrayBuffer::create):
- html/canvas/ArrayBuffer.h:
- loader/ThreadableLoaderClient.h:
LayoutTests:
- fast/files/read-file-async-expected.txt:
- fast/files/resources/read-common.js:
(readBlobAsArrayBuffer):
(_readBlobAsArrayBufferAsync):
(_readBlobAsArrayBufferSync):
(_readBlobAsBinaryStringSync):
(_readBlobAsTextSync):
(_readBlobAsDataURLSync):
(logResult):
(loaded):
(_toString):
(_isASCIIString):
(_toHexadecimal):
(_getElementAt):
- fast/files/resources/read-file-test-cases.js:
(testReadingNonExistentFileAsArrayBuffer):
(testReadingEmptyFileAsArrayBuffer):
(testReadingUTF8EncodedFileAsArrayBuffer):
(testReadingBinaryFileAsArrayBuffer):
(testMultipleReads):
- fast/files/workers/resources/worker-read-file-sync.js:
(testMultipleReadsSync):
- fast/files/workers/worker-read-blob-sync-expected.txt:
- fast/files/workers/worker-read-file-async-expected.txt:
- fast/files/workers/worker-read-file-sync-expected.txt:
- 11:00 AM Changeset in webkit [70903] by
-
- 2 edits in trunk/WebKit2
Build fix when Carbon plugins are disabled
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformHandleMouseEvent):
- 10:57 AM Changeset in webkit [70902] by
-
- 2 edits in trunk/WebKit/win
Windows build fix
- WebKitPrefix.h: Touched to force a rebuild.
- 10:53 AM Changeset in webkit [70901] by
-
- 3 edits in trunk/WebKit/mac
2010-10-27 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Full screen video in Safari (still) exits full-screen if you switch to another
app on a multi-display system.
https://bugs.webkit.org/show_bug.cgi?id=47364
<rdar://problem/8382299>
The FullScreen window does not technically close when it deactivates, but the
two NSWindows that make up the FullScreen feature should not hide when deactivated.
- WebView/WebVideoFullscreenController.mm: (createBackgroundFullscreenWindow): Do not set hidesOnDeactivate. (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
- WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
- 10:50 AM Changeset in webkit [70900] by
-
- 1 edit in branches/chromium/552/WebCore/html/HTMLMediaElement.cpp
Merge 70065 - 2010-10-19 Eric Carlson <eric.carlson@apple.com>
Not reviewed. Build fix.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::selectNextSourceChild): Initialize variable to avoid Windows "potentially uninitialized local variable" warning.
BUG=59593
TBR=jschuh@chromium.org
- 10:47 AM Changeset in webkit [70899] by
-
- 5 edits4 copies in branches/chromium/552
Merge 70063 - 2010-10-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=46763
CRASH in WebCore::ThreadTimers::sharedTimerFiredInternal
Fix crashes caused by moving and deleting <source> element(s) of active media element.
Tests: media/video-source-moved.html
media/video-source-removed.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Add logging. Initialize selectNextSourceChild. (WebCore::HTMLMediaElement::~HTMLMediaElement): Ditto. (WebCore::HTMLMediaElement::insertedIntoDocument): Ditto. (WebCore::HTMLMediaElement::removedFromDocument): Ditto. (WebCore::HTMLMediaElement::scheduleLoad): Ditto. (WebCore::HTMLMediaElement::setNetworkState): Deal with m_currentSourceNode being null when the media engine signals a failure by skipping the error message and continuing as usual. (WebCore::HTMLMediaElement::setVolume): Fix logging typo. (WebCore::HTMLMediaElement::havePotentialSourceChild): Save and restore m_nextChildNodeToConsider around call to selectNextSourceChild because they are both significant. (WebCore::HTMLMediaElement::selectNextSourceChild): Use m_nextChildNodeToConsider to pick the first node to consider. Bail immediately if it signals that we have already processed every <source> node. Stach the node following the current source element in m_nextChildNodeToConsider so we can resume the search even if m_currentSourceNode is removed while it is being processed. (WebCore::HTMLMediaElement::sourceWasAdded): New, move logic from HTMLSourceElement::insertedIntoTree here and correct it to deal with a <source> node being inserted immediately after the current <source> node and a new <source> node being inserted at the end of the list after all candidates have failed. (WebCore::HTMLMediaElement::sourceWillBeRemoved): New, deal with current source node and next potential node being removed.
- html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::sourceChildEndOfListValue): New, define sentinal value used to indicate that all nodes have been processed.
- html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::HTMLSourceElement): Add logging. (WebCore::HTMLSourceElement::insertedIntoTree): Call mediaElement->sourceWasAdded instead of having logic here. (WebCore::HTMLSourceElement::willRemove): New, call mediaElement->sourceWillBeRemoved (WebCore::HTMLSourceElement::scheduleErrorEvent): Add logging. (WebCore::HTMLSourceElement::cancelPendingErrorEvent): Add logging.
- html/HTMLSourceElement.h:
2010-10-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=46763
CRASH in WebCore::ThreadTimers::sharedTimerFiredInternal
Test moving and deleting <source> element(s) of active <video>.
- media/media-file.js: (mimeTypeForExtension): New, added to make it possible to set 'type' attribute on <source>.
- media/video-source-moved-expected.txt: Added.
- media/video-source-moved.html: Added.
- media/video-source-removed-expected.txt: Added.
- media/video-source-removed.html: Added.
BUG=59593
TBR=jschuh@chromium.org
- 10:45 AM Changeset in webkit [70898] by
-
- 4 edits10 moves in trunk/WebKit2
Move NPRuntime-related files into WebProcess/Plugins/Netscape
Fixes <http://webkit.org/b/48645>.
Reviewed by Anders Carlsson.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Updated the files' paths.
- WebProcess/Plugins/Netscape/JSNPMethod.cpp: Renamed from WebKit2/WebProcess/Plugins/JSNPMethod.cpp.
- WebProcess/Plugins/Netscape/JSNPMethod.h: Renamed from WebKit2/WebProcess/Plugins/JSNPMethod.h.
- WebProcess/Plugins/Netscape/JSNPObject.cpp: Renamed from WebKit2/WebProcess/Plugins/JSNPObject.cpp.
- WebProcess/Plugins/Netscape/JSNPObject.h: Renamed from WebKit2/WebProcess/Plugins/JSNPObject.h.
- WebProcess/Plugins/Netscape/NPJSObject.cpp: Renamed from WebKit2/WebProcess/Plugins/NPJSObject.cpp.
- WebProcess/Plugins/Netscape/NPJSObject.h: Renamed from WebKit2/WebProcess/Plugins/NPJSObject.h.
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp: Renamed from WebKit2/WebProcess/Plugins/NPRuntimeObjectMap.cpp.
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h: Renamed from WebKit2/WebProcess/Plugins/NPRuntimeObjectMap.h.
- WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp: Renamed from WebKit2/WebProcess/Plugins/NPRuntimeUtilities.cpp.
- WebProcess/Plugins/Netscape/NPRuntimeUtilities.h: Renamed from WebKit2/WebProcess/Plugins/NPRuntimeUtilities.h.
- 10:44 AM Changeset in webkit [70897] by
-
- 1 edit in branches/chromium/552/WebCore/html/HTMLMediaElement.cpp
Merge 69514 - 2010-10-11 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Eric Carlson.
CRASH at WebCore::HTMLSourceElement::scheduleErrorEvent
https://bugs.webkit.org/show_bug.cgi?id=46777
Another case that could lead to an improper set of states between
m_currentNode and m_loadingState. Also added an ASSERT and early
return to prevent crashes if this case can still happen in other ways.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::prepareForLoad):
BUG=59593
TBR=jschuh@chromium.org
- 10:32 AM Changeset in webkit [70896] by
-
- 7 edits in trunk/WebCore
2010-10-29 Tony Chang <tony@chromium.org>
Unreviewed, rolling out r70850.
http://trac.webkit.org/changeset/70850
https://bugs.webkit.org/show_bug.cgi?id=45640
chromium and qt pixel test regressions
- dom/Document.cpp:
- dom/Document.h:
- page/FrameView.cpp: (WebCore::FrameView::invalidateRect): (WebCore::FrameView::repaintContentRectangle): (WebCore::FrameView::doDeferredRepaints):
- page/FrameView.h:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintContents):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
- 10:28 AM Changeset in webkit [70895] by
-
- 2 edits in trunk/LayoutTests
2010-10-29 Zhenyao Mo <zmo@google.com>
Unreviewed, webgl test expectations update.
- platform/chromium/test_expectations.txt:
- 10:23 AM Changeset in webkit [70894] by
-
- 43 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=48576
Let WebKit2 client know when a frame is a frameset
This can change in two cases, when document changes, and when frame is navigated to another
document.
- 10:22 AM Changeset in webkit [70893] by
-
- 3 edits in trunk/WebKit2
Connection::sendSyncMessage needs to dispatch incoming sync messages
https://bugs.webkit.org/show_bug.cgi?id=48606
Reviewed by Adam Roben.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::sendSyncMessage):
Protect the connection when waiting for a reply. Schedule for any remaining incoming sync messages
to be sent once the bottom-most waitForSyncReply calls returns.
(CoreIPC::Connection::waitForSyncReply):
Make sure to dispatch any incoming sync messages.
(CoreIPC::Connection::processIncomingMessage):
If the incoming message is a sync message and we're waiting for a sync reply, add the message to the
queue of "sync messages received while waiting for sync reply" and wake up the client thread.
- Platform/CoreIPC/Connection.h:
- 10:06 AM Changeset in webkit [70892] by
-
- 11 edits in trunk/WebKit2
Use IntPoint/FloatSize in WebEvent subclasses
This is nicer than passing around pairs of ints/floats.
Fixes <http://webkit.org/b/48611>.
Reviewed by Anders Carlsson.
- Shared/WebEvent.h:
- Shared/WebMouseEvent.cpp:
- Shared/WebPlatformTouchPoint.cpp:
- Shared/WebWheelEvent.cpp:
Changed all x/y pairs to either use IntPoint or FloatSize, as
appropriate.
- Shared/WebEventConversion.cpp:
- Shared/mac/WebEventFactory.mm:
- Shared/qt/WebEventFactoryQt.cpp:
- Shared/win/WebEventFactory.cpp:
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
- WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
Updated for WebEvent changes.
- 10:05 AM Changeset in webkit [70891] by
-
- 2 edits in trunk/LayoutTests
2010-10-29 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test_expectations update.
Fix a duplicate for Mac, address r70887 tests miss.y
- platform/chromium/test_expectations.txt:
- 10:01 AM Changeset in webkit [70890] by
-
- 2 edits in trunk/WebKit2
Touch WebKit2Prefix.h to fix incremental builds on Windows
- WebKit2Prefix.h:
- 9:59 AM Changeset in webkit [70889] by
-
- 2 edits in trunk/WebKitSite
Instruct developers to install the Feburary 2010 DirectX SDK, not just any version
The February 2010 SDK is the last one with support for Visual Studio
2005.
I also removed some unnecessary instructions regarding the DirectX
SDK.
Fixes <http://webkit.org/b/48642> webkit.org should recommend a
specific version of the DirectX SDK
Reviewed by Steve Falkenburg.
- building/tools.html:
- 9:57 AM Changeset in webkit [70888] by
-
- 2 edits in trunk/WebKit/qt
2010-10-29 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Andreas Kling.
[Qt] Fix tst_QWebFrame on XVFB.
https://bugs.webkit.org/show_bug.cgi?id=48637
These tests relied on a window manager to activate the window.
Fixes:
- tst_QWebFrame::popupFocus()
- tst_QwebFrame::inputFieldFocus()
- tests/qwebframe/tst_qwebframe.cpp:
- 9:37 AM Changeset in webkit [70887] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-10-29 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Add IndexedDB test/tutorial
https://bugs.webkit.org/show_bug.cgi?id=48067
This document is useful in terms of demonstrating IndexedDB and
documenting what we do and don't support currently, since I'll be
maintaining it for at least some time.
- storage/indexeddb/tutorial-expected.txt: Added.
- storage/indexeddb/tutorial.html: Added.
- 9:31 AM Changeset in webkit [70886] by
-
- 2 edits in trunk/WebKitTools
2010-10-29 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Reviewed by Martin Robinson.
Enable popup window in GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=48335
The GtkLauncher application does not support opening new window when
a link with "target=_blank" is clicked or similar call to
window.open(). Instead, GtkLauncher does nothing which breaks
navigation of some websites.
- GtkLauncher/main.c: (activate_uri_entry_cb): (update_title): (link_hover_cb): (notify_title_cb): (notify_load_status_cb): (notify_progress_cb): (destroy_cb): (go_back_cb): (go_forward_cb): (create_web_view_cb): (web_view_ready_cb): (close_web_view_cb): (create_browser): (create_statusbar): (create_toolbar): (create_window): (main):
- 9:27 AM Changeset in webkit [70885] by
-
- 21 edits in trunk/WebKit2
Remove unnecessary #includes from WebEvent.h
Fixes <http://webkit.org/b/48609> WebEvent.h #includes things it
doesn't need
Reviewed by Sam Weinig.
- Scripts/webkit2/messages.py:
(MessageReceiver.iterparameters): Merged iterreplyparameters into this
function. All callers to iterparameters are really interested in the
reply parameters, too. This will cause us to, e.g., add
forward-declarations for types used in sync replies.
(headers_for_type): Added a special case for WebCore::KeypressCommand.
- Scripts/webkit2/messages_unittest.py: Added a test to cover the
failing case that inspired the above changes.
- Shared/WebEvent.h: Replaced #includes with forward-declarations.
- Shared/API/c/WKSharedAPICast.h:
- Shared/NativeWebKeyboardEvent.h:
- Shared/WebEvent.cpp:
- Shared/WebKeyboardEvent.cpp:
- Shared/WebMouseEvent.cpp:
- Shared/WebPlatformTouchPoint.cpp:
- Shared/WebTouchEvent.cpp:
- Shared/WebWheelEvent.cpp:
- UIProcess/LayerBackedDrawingAreaProxy.cpp:
- UIProcess/WebUIClient.cpp:
- UIProcess/WebUIClient.h:
- WebProcess/WebPage/FindController.cpp:
- WebProcess/WebPage/mac/WebPageMac.mm:
Added now-needed #includes and declarations.
- 8:45 AM Changeset in webkit [70884] by
-
- 2 edits in trunk/WebCore
Unreviewed fix. Touch WebCorePrefix.h to fix incremental build failure after r70878.
- WebCorePrefix.h:
- 8:45 AM Changeset in webkit [70883] by
-
- 2 edits in trunk/WebKitTools
Teach check-webkit-style about WebKit2's idiosyncracies
Fixes <http://webkit.org/b/48638> Style bot complains about a number
of WebKit2 conventions
Reviewed by Anders Carlsson.
- Scripts/webkitpy/style/checker.py: Excluded some rules for various
WebKit2-related files. Also updated the excluded rules for
WebKitAPITest to match the current code.
- 8:41 AM Changeset in webkit [70882] by
-
- 2 edits in trunk/LayoutTests
2010-10-29 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test_expectations fix.
Remove duplicate for body-propagation\overflow\004-xhtml.xhtml.
- platform/chromium/test_expectations.txt:
- 8:39 AM Changeset in webkit [70881] by
-
- 2 edits in trunk/WebCore
2010-10-29 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Handle surrogate pairs in TextBreakIteratorGtk
https://bugs.webkit.org/show_bug.cgi?id=48227
TextBreakIteratorGtk uses UTF-8 because it's what pango expects, but we
need to return indices for the given input string that are in UTF-16.
The number of characters is the same for both UTF-16 and UTF-8 except when
the input string contains surrogate pairs. We need to keep both, the
index for the UTF-8 string to be used internally, and the index for the
UTF-16 string to be used as return value of the iterator interface. It
fixes test fast/forms/textarea-maxlength.html
- platform/text/gtk/TextBreakIteratorGtk.cpp: (WebCore::CharacterIterator::getText): (WebCore::CharacterIterator::getLength): (WebCore::CharacterIterator::getSize): (WebCore::CharacterIterator::getIndex): (WebCore::CharacterIterator::getUTF16Index): (WebCore::CharacterIterator::getUTF16Length): (WebCore::CharacterIterator::characterSize): (WebCore::CharacterIterator::setText): (WebCore::CharacterIterator::setIndex): (WebCore::CharacterIterator::setUTF16Index): (WebCore::CharacterIterator::first): (WebCore::CharacterIterator::last): (WebCore::CharacterIterator::next): (WebCore::CharacterIterator::previous): (WebCore::setUpIterator): (WebCore::textBreakFirst): (WebCore::textBreakLast): (WebCore::textBreakNext): (WebCore::textBreakPrevious): (WebCore::textBreakPreceding): (WebCore::textBreakFollowing): (WebCore::textBreakCurrent): (WebCore::isTextBreak):
- 8:34 AM Changeset in webkit [70880] by
-
- 3 edits2 adds in trunk
2010-10-29 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] Addition of a new (blank) style property does not work
https://bugs.webkit.org/show_bug.cgi?id=48631
Test: inspector/styles-add-blank-property.html
WebCore:
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): (WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
LayoutTests:
- inspector/styles-add-blank-property-expected.txt: Added.
- inspector/styles-add-blank-property.html: Added.
- 8:25 AM Changeset in webkit [70879] by
-
- 11 edits in trunk
2010-10-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add close button to network view, make tests pass for
resource manager on all ports.
https://bugs.webkit.org/show_bug.cgi?id=48628
- inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::frameDetachedFromParent): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::markResourceAsCached): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket):
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel):
- inspector/front-end/ResourceManager.js: (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.addResourceToFrame):
- inspector/front-end/inspector.js: (WebInspector._createPanels):
- inspector/front-end/networkPanel.css: (.network-close-button):
2010-10-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add close button to network view, make tests pass
for resource manager on all ports.
https://bugs.webkit.org/show_bug.cgi?id=48628
- src/js/Tests.js:
2010-10-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add close button to network view, make tests pass
for resource manager on all ports.
https://bugs.webkit.org/show_bug.cgi?id=48628
- inspector/audits-panel-functional.html:
- 8:23 AM Changeset in webkit [70878] by
-
- 17 edits in trunk
Fix and cleanup of build systems
https://bugs.webkit.org/show_bug.cgi?id=48342
Reviewed by Adam Roben and David Kilzer.
.:
- cmake/OptionsEfl.cmake: Remove unnecessary ENABLE_SANDBOX.
- cmakeconfig.h.cmake:
- configure.ac:
- Configurations/FeatureDefines.xcconfig: Add missing ENABLE_FULLSCREEN_API
WebKit/chromium:
- features.gypi: Remove unnecessary ENABLE_SANDBOX.
WebKit/mac:
- Configurations/FeatureDefines.xcconfig: Remove unnecessary ENABLE_SANDBOX.
WebKit2:
- Configurations/FeatureDefines.xcconfig: Remove unnecessary ENABLE_SANDBOX and add missing features.
WebKitLibraries:
Remove unnecessary ENABLE_SANDBOX.
Add missing features to converge to FeatureDefines.xcconfig.
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
WebKitTools:
- Scripts/build-webkit:
- Remove unnecessary ENABLE_SANDBOX option.
- Add ENABLE_FULLSCREEN_API option.
- 8:19 AM Changeset in webkit [70877] by
-
- 2 edits in trunk/LayoutTests
2010-10-29 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update.
Add 4 more suspicious tests to bug 48634.
https://bugs.webkit.org/show_bug.cgi?id=48634
- platform/chromium/test_expectations.txt:
- 7:43 AM Changeset in webkit [70876] by
-
- 5 edits in trunk/LayoutTests
Update Windows test results after r70854
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- platform/win/fast/dom/prototype-inheritance-expected.txt:
- platform/win/fast/js/global-constructors-expected.txt:
- 7:33 AM Changeset in webkit [70875] by
-
- 2 edits in trunk/LayoutTests
2010-10-29 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed, disable tests after r70867.
- platform/chromium/test_expectations.txt:
- 7:19 AM Changeset in webkit [70874] by
-
- 2 edits in trunk/LayoutTests
2010-10-29 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed, disable tests.
- platform/chromium/test_expectations.txt:
- 6:52 AM Changeset in webkit [70873] by
-
- 1 edit6 adds in trunk/LayoutTests
2010-10-29 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed rebaselines, probably leftover from r70858.
- platform/chromium-mac/fast/images/icon-decoding-expected.checksum: Added.
- platform/chromium-mac/fast/images/icon-decoding-expected.txt: Added.
- platform/chromium-mac/fast/images/pdf-as-background-expected.checksum: Added.
- platform/chromium-mac/fast/images/pdf-as-background-expected.png: Added.
- platform/chromium-mac/svg/custom/createImageElement-expected.checksum: Added.
- platform/chromium-mac/svg/custom/createImageElement-expected.png: Added.
- 6:50 AM Changeset in webkit [70872] by
-
- 37 edits2 adds in trunk/WebCore
2010-10-29 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Convert SVGAnimatedEnumeration/Integer to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48623
Besides converting SVGAnimatedEnumeration/Integer to the new animated property tear off concept, fix support
for multiple wrappers within the new concept, which was broken - covered by existing svg/dynamic-updates/ tests.
Replace all 'extern char[]' usage when using the multiple wrappers macro, by static AtomicStrings.
- GNUmakefile.am: Add SVGAnimatedEnumeration.h / SVGAnimatedInteger.h to build.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/scripts/CodeGenerator.pm: Recognize SVGAnimatedEnumeration / SVGAnimatedInteger as animated types using the new concept.
- bindings/scripts/CodeGeneratorObjC.pm: Touched, to force regenerating ObjC bindings, dependency tracking is obviously broken.
- svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedBoolean/Enumeration/Integer handling.
- svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
- svg/SVGAnimatedEnumeration.h: Added.
- svg/SVGAnimatedEnumeration.idl:
- svg/SVGAnimatedInteger.h: Added.
- svg/SVGClipPathElement.h: Adapted all code to create new style animated property tear offs for long & int types.
- svg/SVGComponentTransferFunctionElement.h:
- svg/SVGFEBlendElement.h:
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFECompositeElement.h:
- svg/SVGFEConvolveMatrixElement.h:
- svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthXIdentifier): Replaced extern[] char hack using a static AtomicString. (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthYIdentifier): Ditto.
- svg/SVGFEDiffuseLightingElement.h:
- svg/SVGFEDisplacementMapElement.h:
- svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::stdDeviationXIdentifier): Ditto. (WebCore::SVGFEGaussianBlurElement::stdDeviationYIdentifier): Ditto.
- svg/SVGFEGaussianBlurElement.h:
- svg/SVGFEMorphologyElement.h:
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::kernelUnitLengthXIdentifier): Ditto. (WebCore::SVGFESpecularLightingElement::kernelUnitLengthYIdentifier): Ditto.
- svg/SVGFESpecularLightingElement.h:
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::baseFrequencyXIdentifier): Ditto. (WebCore::SVGFETurbulenceElement::baseFrequencyYIdentifier): Ditto.
- svg/SVGFETurbulenceElement.h:
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::filterResXIdentifier): Ditto. (WebCore::SVGFilterElement::filterResYIdentifier): Ditto.
- svg/SVGFilterElement.h:
- svg/SVGGradientElement.h:
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::orientTypeIdentifier): Ditto. (WebCore::SVGMarkerElement::orientAngleIdentifier): Ditto.
- svg/SVGMarkerElement.h:
- svg/SVGMaskElement.h:
- svg/SVGPatternElement.h:
- svg/SVGTextContentElement.h:
- svg/SVGTextPathElement.h:
- svg/properties/SVGAnimatedPropertyMacros.h: Add new macro for multiple wrappers using static properties.
- 6:45 AM Changeset in webkit [70871] by
-
- 2 edits in trunk/WebKitTools
Switch the Windows WebKit2 bot to the Release configuration
We only have one machine testing WebKit2 on Windows right now, and
Debug is just too slow for it to keep up.
Fixes (hopefully!) <http://webkit.org/b/48615> Windows WebKit2 bot is
always way behind
Reviewed by Jon Honeycutt.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 6:44 AM Changeset in webkit [70870] by
-
- 2 edits in trunk/WebCore
2010-10-29 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Make GraphicsContext cheaper to construct
https://bugs.webkit.org/show_bug.cgi?id=48626
Do less unnecessary things when creating the Qt GraphicsContext:
- Don't create a black QBrush that's immediately discarded.
- Don't call setPlatform*(), set the painter brush and pen directly.
- Call setRenderHints() once instead of multiple setRenderHint().
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::GraphicsContext):
- 6:41 AM Changeset in webkit [70869] by
-
- 2 edits in branches/chromium/517/WebCore
Merge 70644 - 2010-10-27 Satish Sampath <satish@chromium.org>
Reviewed by Steve Block.
Add runtime flag check before enabling speech input in code.
https://bugs.webkit.org/show_bug.cgi?id=48426
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isSpeechEnabled): Added runtime flag check.
TBR=satish@chromium.org
Review URL: http://codereview.chromium.org/4111010
- 6:39 AM Changeset in webkit [70868] by
-
- 2 edits in trunk/WebCore
2010-10-29 Andreas Kling <kling@webkit.org>
Reviewed by Simon Hausmann.
[Qt] GraphicsLayer: Don't notifySyncRequired() more than necessary
https://bugs.webkit.org/show_bug.cgi?id=48624
Don't queue multiple meta method invocations for notifySyncRequired()
4% speedup on <http://ariya.github.com/clock.htm>
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::notifySyncRequired): (WebCore::GraphicsLayerQtImpl::notifyChange):
- 6:35 AM Changeset in webkit [70867] by
-
- 7 edits in trunk
2010-10-29 Zhenyao Mo <zmo@google.com>
Reviewed by Chris Marrin.
drawArrays/drawElements with first/offset out of range but size==0 should generate no error
https://bugs.webkit.org/show_bug.cgi?id=48601
- fast/canvas/webgl/draw-arrays-out-of-bounds-expected.txt:
- fast/canvas/webgl/draw-arrays-out-of-bounds.html:
- fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
- fast/canvas/webgl/draw-elements-out-of-bounds.html:
2010-10-29 Zhenyao Mo <zmo@google.com>
Reviewed by Chris Marrin.
drawArrays/drawElements with first/offset out of range but size==0 should generate no error
https://bugs.webkit.org/show_bug.cgi?id=48601
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::drawArrays): (WebCore::WebGLRenderingContext::drawElements):
- 6:26 AM Changeset in webkit [70866] by
-
- 2 edits3 adds in trunk/LayoutTests
2010-10-29 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed tests checksums update. Also, fix duplicates introduced in r70865.
- platform/chromium-mac/fast/blockflow/background-horizontal-bt-expected.checksum: Added.
- platform/chromium-mac/fast/blockflow/background-vertical-lr-expected.checksum: Added.
- platform/chromium-mac/fast/blockflow/background-vertical-rl-expected.checksum: Added.
- platform/chromium/test_expectations.txt:
- 6:06 AM Changeset in webkit [70865] by
-
- 2 edits in trunk/LayoutTests
2010-10-29 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update.
- platform/chromium/test_expectations.txt:
- 5:08 AM Changeset in webkit [70864] by
-
- 15 edits12 adds in trunk/LayoutTests
2010-10-29 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed tests rebaselines after r70843, r70847, r70856
- platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Added.
- platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.png: Added.
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum:
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
- platform/chromium-mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Added.
- platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
- platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum:
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.png: Added.
- platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt: Added.
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt: Added.
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
- 5:00 AM Changeset in webkit [70863] by
-
- 30 edits2 adds in trunk
2010-10-29 Leandro Gracia Gil <leandrogracia@google.com>
Reviewed by Jeremy Orlow.
Added a layout test for the language tag in speech input. Updated
the speech button tests to include the new language parameter in the
mock result.
https://bugs.webkit.org/show_bug.cgi?id=47089
- fast/speech/input-text-language-tag-expected.txt: Added.
- fast/speech/input-text-language-tag.html: Added.
- fast/speech/input-text-speechbutton.html:
- fast/speech/speech-button-ignore-generated-events.html:
- platform/chromium/test_expectations.txt:
2010-10-29 Leandro Gracia Gil <leandrogracia@google.com>
Reviewed by Jeremy Orlow.
Patch the current speech input implementation to use the nearest
language tag. The language is now passed to the startRecognition
methods so that language-specific recognition could be used. Also added
a second parameter to setMockSpeechInputResult for the language used in
speech recognition.
https://bugs.webkit.org/show_bug.cgi?id=47089
This is the 2nd of a 4-sided patch in Chromium and WebKit. For more
details see http://codereview.chromium.org/3615005/show,
http://codereview.chromium.org/3595018/show and
https://bugs.webkit.org/show_bug.cgi?id=47420.
Test: fast/speech/input-text-language-tag.html
- page/SpeechInput.cpp: (WebCore::SpeechInput::startRecognition):
- page/SpeechInput.h:
- page/SpeechInputClient.h:
- platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::startRecognition): (WebCore::SpeechInputClientMock::setRecognitionResult): (WebCore::SpeechInputClientMock::timerFired):
- platform/mock/SpeechInputClientMock.h:
- rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::attachInnerElement): (WebCore::SearchFieldCancelButtonElement::detach): (WebCore::SpinButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::detach):
2010-10-29 Leandro Gracia Gil <leandrogracia@google.com>
Reviewed by Jeremy Orlow.
Patch the current speech input implementation to use the nearest
language tag. The language is now passed to the startRecognition
methods so that language-specific recognition could be used. Also added
a second parameter to setMockSpeechInputResult for the language used in
speech recognition.
https://bugs.webkit.org/show_bug.cgi?id=47089
This is the 2nd of a 4-sided patch in Chromium and WebKit. For more
details see http://codereview.chromium.org/3615005/show,
http://codereview.chromium.org/3595018/show and
https://bugs.webkit.org/show_bug.cgi?id=47420.
- public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition):
- public/WebSpeechInputControllerMock.h:
- src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::create): (WebKit::SpeechInputClientImpl::startRecognition):
- src/SpeechInputClientImpl.h:
- src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::setMockRecognitionResult): (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
- src/WebSpeechInputControllerMockImpl.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
- src/WebViewImpl.h:
2010-10-29 Leandro Gracia Gil <leandrogracia@google.com>
Reviewed by Jeremy Orlow.
Added a second parameter to setMockSpeechInputResult for
the language used in speech input.
https://bugs.webkit.org/show_bug.cgi?id=47089
- DumpRenderTree/LayoutTestController.cpp: (setMockSpeechInputResultCallback):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockSpeechInputResult):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setMockSpeechInputResult):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMockSpeechInputResult):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setMockSpeechInputResult):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setMockSpeechInputResult):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setMockSpeechInputResult): (LayoutTestController::pageSizeAndMarginsInPixels):
- 4:50 AM Changeset in webkit [70862] by
-
- 3 edits3 adds in trunk
2010-10-29 Mads Ager <ager@chromium.org>
Reviewed by Pavel Feldman.
[V8] The DateExtension cannot handle overwritten Date
https://bugs.webkit.org/show_bug.cgi?id=48621
Check that the Date property is an object before attempting to get
hidden properties from it.
Test: fast/dom/Window/slow-unload-handler-overwritten-date.html
- bindings/v8/DateExtension.cpp: (WebCore::DateExtension::setAllowSleep):
2010-10-29 Mads Ager <ager@chromium.org>
Reviewed by Pavel Feldman.
[V8] The DateExtension cannot handle overwritten Date
https://bugs.webkit.org/show_bug.cgi?id=48621
- fast/dom/Window/resources/slow-unload-handler-overwritten-date1.html: Added.
- fast/dom/Window/slow-unload-handler-overwritten-date-expected.txt: Added.
- fast/dom/Window/slow-unload-handler-overwritten-date.html: Added.
- 4:25 AM Changeset in webkit [70861] by
-
- 3 edits in trunk/WebKit/gtk
2010-10-29 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add the GtkScrollablePolicy property to the webview
https://bugs.webkit.org/show_bug.cgi?id=48357
Added the GtkScrollablePolicy properties to the webview widget, it
is now required for GtkScrollable widgets in GTK+ 3.x.
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp: (setHorizontalScrollPolicy): Added. (setVerticalScrollPolicy): Added. (getHorizontalScrollPolicy): Added. (getVerticalScrollPolicy): Added. (webkit_web_view_get_property): (webkit_web_view_set_property): (webkit_web_view_class_init):
- 3:32 AM Changeset in webkit [70860] by
-
- 2 edits in trunk/LayoutTests
2010-10-29 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Oh my, remove a left-over alert(), that I accidently landed.
- svg/dom/SVGScriptElement/resources/script-load4.js:
- 3:31 AM Changeset in webkit [70859] by
-
- 8 edits in trunk/LayoutTests
2010-10-29 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
Update Qt and GTK expectations for r70854.
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- 3:11 AM Changeset in webkit [70858] by
-
- 66 edits192 adds16 deletes in trunk/LayoutTests
2010-10-29 Adam Barth <abarth@webkit.org>
Unreviewed.
[chromium] Chromium Mac should use WebKit's image decoders
https://bugs.webkit.org/show_bug.cgi?id=47974
Update chromium-mac expectations for new image decoders. There are a
lot of changed images here, but I think they're correct.
- platform/chromium-mac/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum:
- platform/chromium-mac/css2.1/t0804-c5510-padn-00-b-ag-expected.png: Removed.
- platform/chromium-mac/css2.1/t0905-c414-flt-01-d-g-expected.checksum: Added.
- platform/chromium-mac/css2.1/t0905-c414-flt-wrap-01-d-g-expected.checksum: Added.
- platform/chromium-mac/css2.1/t100801-c544-valgn-02-d-agi-expected.checksum: Added.
- platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum: Added.
- platform/chromium-mac/css2.1/t100801-c544-valgn-04-d-agi-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
- platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize01-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize01-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize05-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize05-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize06-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize07-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize08-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize09-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize10-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize11-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize12-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize12-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize16-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize16-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize17-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize17-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize18-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize18-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize19-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize19-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize20-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize20-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize21-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize21-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.png: Added.
- platform/chromium-mac/fast/backgrounds/size/zero-expected.checksum: Added.
- platform/chromium-mac/fast/backgrounds/size/zero-expected.png: Added.
- platform/chromium-mac/fast/block/float/014-expected.checksum: Added.
- platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum: Added.
- platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
- platform/chromium-mac/fast/borders/border-fit-expected.checksum: Added.
- platform/chromium-mac/fast/borders/border-fit-expected.png: Added.
- platform/chromium-mac/fast/borders/border-image-omit-right-slice-expected.checksum: Added.
- platform/chromium-mac/fast/borders/border-image-omit-right-slice-expected.png: Added.
- platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.checksum:
- platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
- platform/chromium-mac/fast/borders/svg-as-border-image-2-expected.checksum: Added.
- platform/chromium-mac/fast/borders/svg-as-border-image-2-expected.png: Added.
- platform/chromium-mac/fast/borders/svg-as-border-image-expected.checksum: Added.
- platform/chromium-mac/fast/borders/svg-as-border-image-expected.png: Added.
- platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.checksum: Added.
- platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.checksum: Added.
- platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.png: Added.
- platform/chromium-mac/fast/css/contentDiv-expected.checksum: Added.
- platform/chromium-mac/fast/css/contentDiv-expected.png: Added.
- platform/chromium-mac/fast/css/contentDivWithChildren-expected.checksum: Added.
- platform/chromium-mac/fast/css/contentDivWithChildren-expected.png: Added.
- platform/chromium-mac/fast/css/contentImage-expected.checksum: Added.
- platform/chromium-mac/fast/css/contentImage-expected.png: Added.
- platform/chromium-mac/fast/css/value-list-out-of-bounds-crash-expected.checksum: Added.
- platform/chromium-mac/fast/forms/input-align-image-expected.checksum: Added.
- platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.checksum: Added.
- platform/chromium-mac/fast/forms/input-type-change-expected.checksum: Added.
- platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.checksum: Added.
- platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum:
- platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.checksum: Added.
- platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.png: Added.
- platform/chromium-mac/fast/reflections/reflection-masks-expected.checksum: Added.
- platform/chromium-mac/fast/reflections/reflection-masks-expected.png: Added.
- platform/chromium-mac/fast/reflections/reflection-masks-opacity-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.checksum:
- platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
- platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.checksum: Added.
- platform/chromium-mac/fast/replaced/image-onload-expected.checksum: Added.
- platform/chromium-mac/fast/replaced/image-sizing-expected.checksum: Added.
- platform/chromium-mac/fast/replaced/image-tag-expected.checksum: Added.
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.checksum:
- platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.png:
- platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.checksum: Added.
- platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.checksum: Added.
- platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
- platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.checksum:
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-01-t-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-03-t-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-03-t-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-04-t-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-04-t-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-07-t-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-07-t-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-08-t-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-08-t-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-09-t-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-09-t-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-10-t-expected.checksum: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-10-t-expected.png: Added.
- platform/chromium-mac/svg/carto.net/scrollbar-expected.checksum: Added.
- platform/chromium-mac/svg/carto.net/scrollbar-expected.png: Added.
- platform/chromium-mac/svg/carto.net/selectionlist-expected.checksum: Added.
- platform/chromium-mac/svg/carto.net/selectionlist-expected.png: Added.
- platform/chromium-mac/svg/custom/convolution-crash-expected.checksum: Added.
- platform/chromium-mac/svg/custom/focus-ring-expected.checksum:
- platform/chromium-mac/svg/custom/focus-ring-expected.png:
- platform/chromium-mac/svg/custom/group-opacity-expected.checksum: Added.
- platform/chromium-mac/svg/custom/group-opacity-expected.png: Added.
- platform/chromium-mac/svg/custom/image-parent-translation-expected.checksum: Added.
- platform/chromium-mac/svg/custom/image-parent-translation-expected.png: Added.
- platform/chromium-mac/svg/custom/image-small-width-height-expected.checksum: Added.
- platform/chromium-mac/svg/custom/image-small-width-height-expected.png: Added.
- platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.checksum: Added.
- platform/chromium-mac/svg/custom/js-update-image-and-display-expected.checksum: Added.
- platform/chromium-mac/svg/custom/js-update-image-and-display-expected.png: Added.
- platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.checksum: Added.
- platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.png: Added.
- platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.checksum: Added.
- platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.png: Added.
- platform/chromium-mac/svg/custom/js-update-image-expected.checksum: Added.
- platform/chromium-mac/svg/custom/js-update-image-expected.png: Added.
- platform/chromium-mac/svg/custom/pointer-events-image-expected.checksum: Added.
- platform/chromium-mac/svg/custom/pointer-events-image-expected.png: Added.
- platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum:
- platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac/svg/custom/text-image-opacity-expected.checksum: Added.
- platform/chromium-mac/svg/custom/text-image-opacity-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum:
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Added.
- platform/chromium-mac/svg/filters/feDisplacementMap-expected.checksum: Added.
- platform/chromium-mac/svg/filters/filterRes-expected.checksum: Added.
- platform/chromium-mac/svg/filters/filteredImage-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug10565-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug120107-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug1271-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug12908-1-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug12908-2-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug12910-2-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug13169-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug17138-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug196870-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug2981-2-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug4284-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.png: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug4523-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug50695-2-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug82946-2-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug82946-2-expected.png: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug86708-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png: Added.
- platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
- platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/core/misc-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.checksum: Added.
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum: Added.
- platform/chromium/test_expectations.txt:
- Now that we now fail a handful of tests more consistently across platforms.
- 2:54 AM Changeset in webkit [70857] by
-
- 52 edits5 adds in trunk
2010-10-27 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Convert SVGAnimatedBoolean to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48469
Convert the next SVG animated primitive type to use the SVGAnimatedPropertyTearOff concept: SVGAnimatedBoolean.
Added new test verifying that StrictTypeChecking is enabled for SVGAnimatedBooleans. It also tests that this type is "static", see LayoutTests/ChangeLog for details.
Add support for StrictTypeChecking for boolean types.
Test: svg/dom/SVGExternalResourcesRequired.html
- GNUmakefile.am: Add SVGAnimatedBoolean.h and SVGAnimatedStaticPropertyTearOff.h to build.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/scripts/CodeGenerator.pm: Add SVGAnimatedBoolean to the new style svg animated bindings list.
- bindings/scripts/CodeGeneratorJS.pm: Add StrictTypeChecking support for boolean types.
- bindings/scripts/CodeGeneratorObjC.pm: Ditto. Only generate kit() usage for new style animated types, if the wrapped type needs a tear off.
- bindings/scripts/CodeGeneratorV8.pm: Ditto.
- svg/DeprecatedSVGAnimatedTemplate.h: Remove SVGAnimatedBoolean handling.
- svg/SVGAElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARE_ANIMATED_STATIC_PROPERTY_NEW/ for boolean types everywhere. Include SVGAnimatedPropertyMacros.h where needed.
- svg/SVGAnimatedBoolean.h: Added.
- svg/SVGAnimatedBoolean.idl:
- svg/SVGAnimationElement.h:
- svg/SVGCircleElement.h:
- svg/SVGClipPathElement.h:
- svg/SVGCursorElement.h:
- svg/SVGDefsElement.h:
- svg/SVGEllipseElement.h:
- svg/SVGExternalResourcesRequired.cpp:
- svg/SVGExternalResourcesRequired.h: (WebCore::SVGExternalResourcesRequired::~SVGExternalResourcesRequired):
- svg/SVGFEConvolveMatrixElement.h:
- svg/SVGFEImageElement.h:
- svg/SVGFilterElement.h:
- svg/SVGFontElement.h:
- svg/SVGForeignObjectElement.h:
- svg/SVGGElement.h:
- svg/SVGGradientElement.h:
- svg/SVGImageElement.h:
- svg/SVGLineElement.h:
- svg/SVGMPathElement.h:
- svg/SVGMarkerElement.h:
- svg/SVGMaskElement.h:
- svg/SVGPathElement.h:
- svg/SVGPatternElement.h:
- svg/SVGPolyElement.h:
- svg/SVGRectElement.h:
- svg/SVGSVGElement.h:
- svg/SVGScriptElement.h:
- svg/SVGSwitchElement.h:
- svg/SVGSymbolElement.h:
- svg/SVGTextContentElement.h:
- svg/SVGUseElement.h:
- svg/SVGViewElement.h:
- svg/properties/SVGAnimatedListPropertyTearOff.h: Moved RefPtr<SVGProperty> m_baseVal/m_animVal from SVGAnimatedProperty, as SVGAnimatedStaticPropertyTearOff doesn't need them.
- svg/properties/SVGAnimatedProperty.h: Remove m_baseVal/m_animVal. (WebCore::SVGAnimatedProperty::commitChange): New method to share code between the SVGAnimated*PropertyTearOff classes.
- svg/properties/SVGAnimatedPropertyMacros.h: Add new DECLARE_ANIMATED_STATIC_PROPERTY_NEW macro which creates SVGAnimatedStaticPropertyTearOff types.
- svg/properties/SVGAnimatedPropertyTearOff.h: Moved RefPtr<SVGProperty> m_baseVal/m_animVal from SVGAnimatedProperty, as SVGAnimatedStaticPropertyTearOff doesn't need them.
- svg/properties/SVGAnimatedStaticPropertyTearOff.h: Added. (WebCore::SVGAnimatedStaticPropertyTearOff::baseVal): Directly returns the stored m_property as reference, no tear off is created. (WebCore::SVGAnimatedStaticPropertyTearOff::animVal): Ditto. (WebCore::SVGAnimatedStaticPropertyTearOff::setBaseVal): Directly updates the stored m_property reference, and invalidates the SVG attributes. (WebCore::SVGAnimatedStaticPropertyTearOff::setAnimVal): Not implemented. (WebCore::SVGAnimatedStaticPropertyTearOff::create): (WebCore::SVGAnimatedStaticPropertyTearOff::SVGAnimatedStaticPropertyTearOff):
- svg/properties/SVGListPropertyTearOff.h: (WebCore::SVGListPropertyTearOff::commitChange): Share code, use SVGAnimatedProperty::commitChange.
- svg/properties/SVGPropertyTearOff.h: (WebCore::SVGPropertyTearOff::commitChange): Ditto.
2010-10-27 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Convert SVGAnimatedBoolean to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48469
Add simple test that SVGAnimatedBooleans aren't creating tear off when accessing baseVal/animVal.
For example with SVGLength you can do:
var foo = rect.x.baseVal; SVGRectElement -> SVGAnimatedLength -> SVGLength
foo.value = 50; affects the SVGRectElement
For SVGExternalResourcesRequired (one of the two SVGAnimatedBoolean types), this is not possible, as baseVal returns a POD type (boolean).
var bar = rect.externalResourcesRequired.baseVal; bar is a boolean
bar = false; does NOT effect the rect.externalResourcesRequired object
- svg/dom/SVGExternalResourcesRequired-expected.txt: Added.
- svg/dom/SVGExternalResourcesRequired.html: Added.
- svg/dom/script-tests/SVGExternalResourcesRequired.js: Added.
- 2:47 AM Changeset in webkit [70856] by
-
- 7 edits4 adds in trunk
2010-10-28 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
<meter min=0 max=100 value=100> should be optimum.
https://bugs.webkit.org/show_bug.cgi?id=48613
- fast/dom/HTMLMeterElement/meter-boundary-values.html: Added.
- platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
- platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
- platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
- platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
- platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt: Added.
- platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
- platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
2010-10-28 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
<meter min=0 max=100 value=100> should be optimum.
https://bugs.webkit.org/show_bug.cgi?id=48613
Changed to make the condition inclusive for better case consistently.
- Values on the border between optimum and subsequntial go optimum.
- Values on the border between suboptimal and even-less-than-good go suboptimal.
Test: fast/dom/HTMLMeterElement/meter-boundary-values.html
- html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::gaugeRegion):
- 2:43 AM Changeset in webkit [70855] by
-
- 19 edits17 adds in trunk/LayoutTests
2010-10-29 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update after r70843.
- platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Added.
- platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.png: Added.
- platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Added.
- platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.png: Added.
- platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Added.
- platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.png: Added.
- platform/chromium-linux/fast/blockflow/english-lr-text-expected.checksum:
- platform/chromium-linux/fast/blockflow/english-rl-text-expected.checksum:
- platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.checksum:
- platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.png:
- platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.checksum:
- platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.png:
- platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.checksum:
- platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Added.
- platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Added.
- platform/chromium-mac/fast/blockflow/english-lr-text-expected.checksum:
- platform/chromium-mac/fast/blockflow/japanese-lr-text-expected.checksum:
- platform/chromium-mac/fast/blockflow/japanese-rl-text-expected.checksum:
- platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.png: Added.
- platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.txt: Added.
- platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.png: Added.
- platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.txt: Added.
- platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.png: Added.
- platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.txt: Added.
- platform/chromium-win/fast/blockflow/english-lr-text-expected.checksum:
- platform/chromium-win/fast/blockflow/english-lr-text-expected.png:
- platform/chromium-win/fast/blockflow/english-rl-text-expected.checksum:
- platform/chromium-win/fast/blockflow/english-rl-text-expected.png:
- platform/chromium-win/fast/blockflow/japanese-lr-text-expected.checksum:
- platform/chromium-win/fast/blockflow/japanese-lr-text-expected.png:
- platform/chromium-win/fast/blockflow/japanese-rl-text-expected.checksum:
- platform/chromium-win/fast/blockflow/japanese-rl-text-expected.png:
- 2:32 AM Changeset in webkit [70854] by
-
- 32 edits4 copies2 adds in trunk
2010-10-29 Kenichi Ishibashi <bashi@google.com>
Reviewed by Kent Tamura.
[HTML5] Add DOMSettableTokenList
https://bugs.webkit.org/show_bug.cgi?id=47810
- fast/dom/Window/window-properties-expected.txt: Updated expectations.
- fast/dom/Window/window-property-descriptors-expected.txt: Updated expectations.
- fast/dom/prototype-inheritance-2-expected.txt: Updated expectations.
- fast/dom/prototype-inheritance-expected.txt: Updated expectations.
- fast/js/global-constructors-expected.txt: Updated expectations.
2010-10-29 Kenichi Ishibashi <bashi@google.com>
Reviewed by Kent Tamura.
[HTML5] Add DOMSettableTokenList
https://bugs.webkit.org/show_bug.cgi?id=47810
Adds DOMSettableTokenList interface to support <output> element.
The DOMTokenList interface was refactored since its was tightly coupled
with HTMLElement.classList property.
- Android.derived.jscbindings.mk: Added JSDOMSettableTokenList.h file.
- Android.derived.v8bindings.mk: Added V8DOMSettableTokenList.h file.
- Android.jscbindings.mk: Added JSDOMSettableTokenList.cpp file.
- Android.mk: Added ClassList.cpp file.
- CMakeLists.txt: Added DOMSettableTokenList.{cpp,idl} and ClassList.cpp files.
- DerivedSources.cpp: Added JSDOMSettableTokenList.cpp file.
- DerivedSources.make: Added DOMSettableTokenList entry.
- GNUmakefile.am: Added JSDOMSettableTokenList.{h,cpp} and ClassList.{h,cpp} files.
- WebCore.gypi: Added DOMSettableTokenList.{h,cpp,idl}, V8DOMSettableTokenListCustom.cpp and ClassList.{h,cpp} files.
- WebCore.pri: Added DOMSettableTokenList.idl file.
- WebCore.pro: Added V8DOMSettableTokenListCustom.cpp, ClassList.{h,cpp} and DOMSettableTokenList.{h,cpp} files.
- WebCore.vcproj/WebCore.vcproj: Added JSDOMSettableTokenList.{h,cpp}, ClassList.{h,cpp} and DOMSettableTokenList.{h,cpp} files.
- WebCore.xcodeproj/project.pbxproj: Added ClassList.{h,cpp}, DOMSettabletokenList.{h,cpp} and JSDOMSettableTokenList.{h,cpp}
- bindings/gobject/GNUmakefile.am: Added WebKitDOMDOMSettableTokenList.{h,cpp} and WebKitDOMDOMSettableTokenListPrivate.cpp files.
- bindings/scripts/CodeGeneratorJS.pm: Modified IndexGetterReturnsStrings() returns 1 for DOMSettableTokenList.
- bindings/v8/custom/V8DOMSettableTokenListCustom.cpp: Added. (WebCore::V8DOMSettableTokenList::indexedPropertyGetter):
- dom/Element.cpp: Replaced DOMTokenList to ClassList. (WebCore::Element::classList):
- dom/ElementRareData.h: ditto.
- dom/SpaceSplitString.cpp: Added add() and remove() functions. (WebCore::SpaceSplitStringData::add): (WebCore::SpaceSplitStringData::remove): (WebCore::SpaceSplitString::add): (WebCore::SpaceSplitString::remove):
- dom/SpaceSplitString.h: Added add() and remove() functions.
- dom/StyledElement.cpp: Replaced DOMTokenList to ClassList. (WebCore::StyledElement::classAttributeChanged):
- dom/StyledElement.h: ditto.
- html/ClassList.cpp: Added, mostly from original DOMTokenList.cpp. (WebCore::ClassList::ClassList): (WebCore::ClassList::ref): (WebCore::ClassList::deref): (WebCore::ClassList::length): (WebCore::ClassList::item): (WebCore::ClassList::contains): (WebCore::ClassList::containsInternal): (WebCore::ClassList::add): (WebCore::ClassList::addInternal): (WebCore::ClassList::remove): (WebCore::ClassList::removeInternal): (WebCore::ClassList::toggle): (WebCore::ClassList::toString): (WebCore::ClassList::reset): (WebCore::ClassList::classNames):
- html/ClassList.h: Added, mostly from original DOMTokenList.h. (WebCore::ClassList::create): (WebCore::ClassList::element):
- html/DOMSettableTokenList.cpp: Added. (WebCore::DOMSettableTokenList::DOMSettableTokenList): (WebCore::DOMSettableTokenList::~DOMSettableTokenList): (WebCore::DOMSettableTokenList::item): (WebCore::DOMSettableTokenList::contains): (WebCore::DOMSettableTokenList::add): (WebCore::DOMSettableTokenList::addInternal): (WebCore::DOMSettableTokenList::remove): (WebCore::DOMSettableTokenList::removeInternal): (WebCore::DOMSettableTokenList::toggle): (WebCore::DOMSettableTokenList::setValue):
- html/DOMSettableTokenList.h: Added. (WebCore::DOMSettableTokenList::create): (WebCore::DOMSettableTokenList::ref): (WebCore::DOMSettableTokenList::deref): (WebCore::DOMSettableTokenList::length): (WebCore::DOMSettableTokenList::toString): (WebCore::DOMSettableTokenList::value):
- html/DOMSettableTokenList.idl: Added.
- html/DOMTokenList.cpp: Refactored to be an abstract interface for both of ClassList and DOMSettableTokenList. (WebCore::DOMTokenList::validateToken): Changed to be a static member function of DOMTokenList. (WebCore::DOMTokenList::addToken): Added, mostly from original DOMTokenList::addInternal(). (WebCore::DOMTokenList::removeToken): Added, mostly from original DOMTokenList::removeInternal().
- html/DOMTokenList.h: Refactored to be an abstract interface for both of ClassList and DOMSettableTokenList. (WebCore::DOMTokenList::~DOMTokenList): (WebCore::DOMTokenList::element):
- page/DOMWindow.cpp: Added an entry for DOMSettableTokenList.
- page/DOMWindow.idl: ditto.
- 2:00 AM Changeset in webkit [70853] by
-
- 11 edits in trunk/WebCore
2010-10-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: make legacy resource tracking optional in the native code,
make cookeis work against new resource manager.
https://bugs.webkit.org/show_bug.cgi?id=48532
- inspector/InspectorCSSStore.cpp: (WebCore::InspectorCSSStore::resourceStyleSheetText):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::unbindAllResources): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::frameDetachedFromParent): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::markResourceAsCached): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::setResourceTrackingEnabled): (WebCore::InspectorController::getCookies): (WebCore::InspectorController::deleteCookie): (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket): (WebCore::InspectorController::breakpointsSettingKey): (WebCore::InspectorController::getResourceContent):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::markFailed):
- inspector/InspectorResource.h:
- inspector/InspectorResourceAgent.cpp: (WebCore::populateObjectWithFrameResources):
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._updateWithCookies): (WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType): (WebInspector.Resource.prototype._checkWarning):
- inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype._updateResourceWithResponse): (WebInspector.ResourceManager.prototype.didFailLoading):
- inspector/front-end/inspector.js:
- 1:23 AM Changeset in webkit [70852] by
-
- 2 edits in trunk/WebCore
2010-10-29 MORITA Hajime <morrita@google.com>
Unreviewed attempt for fixing build break for http://trac.webkit.org/changeset/70847
- editing/EditingAllInOne.cpp:
- 1:08 AM Changeset in webkit [70851] by
-
- 4 edits in trunk
2010-10-29 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Support RegExp in V8 implementation of SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=44809
fast/loader/stateobjects/pushstate-object-types.html now passes.
- platform/chromium/test_expectations.txt:
2010-10-29 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
Support RegExp in V8 implementation of SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=44809
Add RegExp serialization/deserialization now that V8 provides API access
to the RegExp type.
- bindings/v8/SerializedScriptValue.cpp: (WebCore::ZigZag::Writer::writeRegExp): (WebCore::ZigZag::Serializer::writeRegExp): (WebCore::ZigZag::Serializer::doSerialize): (WebCore::ZigZag::Reader::read): (WebCore::ZigZag::Reader::readRegExp):
- 12:49 AM Changeset in webkit [70850] by
-
- 7 edits in trunk/WebCore
2010-10-13 MORITA Hajime <morrita@google.com>
Reviewed by David Hyatt.
Navigating dark background websites results in blinding white flashes between pages.
https://bugs.webkit.org/show_bug.cgi?id=45640
This FOUC is caused by an early layout request before the <body> is ready,
and the page's background style given for <body>, instead of <html>.
So many sites have such stylesheets that we should care them.
- Some DOM operation such as 'element.offsetLeft' causes page layout.
- The page layout results page repaint
- The page page repaint makes a white screen. because there is nothing to paint before <body> is available.
This change:
- extracted existing FOUC check on RenderBlock and RenderLayer to Document::mayCauseFlashOfUnstyledContent(),
- checked <body> availability on mayCauseFlashOfUnstyledContent(), and
- added FOUC guards before requesting reapint on FrameView.
No new tests. The data loading speed matters and it cannot be
captured by DRT.
- dom/Document.cpp: (WebCore::Document::mayCauseFlashOfUnstyledContent): Added.
- dom/Document.h:
- page/FrameView.cpp: (WebCore::FrameView::invalidateRect): Added a guard. (WebCore::FrameView::repaintContentRectangle): Added a guard. (WebCore::FrameView::doDeferredRepaints): Added a guard. (WebCore::FrameView::shouldUpdate): Added.
- page/FrameView.h:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintContents): Replaced FOUC check to use mayCauseFlashOfUnstyledContent
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Replaced FOUC check to use mayCauseFlashOfUnstyledContent
- 12:16 AM Changeset in webkit [70849] by
-
- 2 edits in branches/chromium/552/WebCore/inspector
Merge 70799 - 2010-10-28 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: fix pausing on next JavaScript statement
https://bugs.webkit.org/show_bug.cgi?id=48534
- inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement): (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement): (WebCore::InspectorDebuggerAgent::pause): (WebCore::InspectorDebuggerAgent::didPause):
- inspector/InspectorDebuggerAgent.h:
TBR=podivilov@chromium.org
BUG=61195
- 12:07 AM Changeset in webkit [70848] by
-
- 8 edits4 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=48618
Reviewed by Dan Bernstein.
WebCore:
Backgrounds should clip to the border radius properly for vertical lines. The code that does this still assumes horizontal lines.
The testcase to cover this used nested spans, which also exposed a bug in the propagation of the vertical bit through the line
box tree.
Added fast/blockflow/border-radius-clipping-vertical-lr.html.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::createLineBoxes):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
LayoutTests:
Backgrounds should clip to the border radius properly for vertical lines. The code that does this still assumes horizontal lines.
The testcase to cover this used nested spans, which also exposed a bug in the propagation of the vertical bit through the line
box tree.
Added fast/blockflow/border-radius-clipping-vertical-lr.html.
- fast/blockflow/border-radius-clipping-vertical-lr.html: Added.
- platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Added.
- platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.png: Added.
- platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt: Added.
- platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
- platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.png:
- platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum:
- platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.png:
Oct 28, 2010:
- 11:58 PM Changeset in webkit [70847] by
-
- 9 edits2 adds in trunk/WebCore
2010-10-26 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
Refactoring: Spellchecking related static functions could form a class
https://bugs.webkit.org/show_bug.cgi?id=48287
Extracted spellcheck related static functions to TextCheckingHelper class,
which has EditorClient and Range as its member.
No new tests. Just a refactoring.
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- editing/Editor.cpp: (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::Editor::markMisspellingsOrBadGrammar): (WebCore::Editor::markMisspellings): (WebCore::Editor::markBadGrammar): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::changeBackToReplacedString):
- editing/Editor.h:
- editing/TextCheckingHelper.cpp: Added. (WebCore::TextCheckingHelper::TextCheckingHelper): (WebCore::TextCheckingHelper::~TextCheckingHelper): (WebCore::TextCheckingHelper::paragraphAlignedRange): (WebCore::TextCheckingHelper::findFirstMisspelling): (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): (WebCore::TextCheckingHelper::findFirstGrammarDetail): (WebCore::TextCheckingHelper::findFirstBadGrammar): (WebCore::TextCheckingHelper::isUngrammatical): (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): (WebCore::TextCheckingHelper::markAllMisspellings): (WebCore::TextCheckingHelper::markAllBadGrammar):
- editing/TextCheckingHelper.h: Added.
- 11:55 PM Changeset in webkit [70846] by
-
- 13 edits1 add in trunk
2010-10-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel, Peter Kasting, and Darin Fisher.
(Eric reviewed the CoreGraphics interactions, Peter reviewed the image
decoder interaction, and Darin Fisher SGTMed the policy decision.)
[chromium] Chromium Mac should use WebKit's image decoders
https://bugs.webkit.org/show_bug.cgi?id=47974
Enable WebKit's image decoders.
- features.gypi:
2010-10-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel, Peter Kasting, and Darin Fisher.
(Eric reviewed the CoreGraphics interactions, Peter reviewed the image
decoder interaction, and Darin Fisher SGTMed the policy decision.)
[chromium] Chromium Mac should use WebKit's image decoders
https://bugs.webkit.org/show_bug.cgi?id=47974
This patch teaches WebKit's image decoders how to talk to CoreGraphics.
This patch doesn't handle color profiles, but that will come in a
subsequent patch.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
- platform/graphics/ImageSource.h:
- platform/image-decoders/ImageDecoder.cpp: (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize):
- platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::getAddr):
- platform/image-decoders/cg: Added.
- platform/image-decoders/cg/ImageDecoderCG.cpp: Added. (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage):
- 11:45 PM Changeset in webkit [70845] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 11:32 PM Changeset in webkit [70844] by
-
- 2 edits in trunk/WebCore
2010-10-28 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Xan Lopez.
[GTK] GObject bindings generator issues
https://bugs.webkit.org/show_bug.cgi?id=48135
GObject code generator must not generate conditional API's. This
patch also adds an alternative return value for non-void
conditional methods. With this change the conditionalMethods hack
is no longer needed.
- bindings/scripts/CodeGeneratorGObject.pm:
- 11:30 PM Changeset in webkit [70843] by
-
- 17 edits12 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=48569
Reviewed by Dan Bernstein.
Box shadows on vertical inlines don't paint properly. Fix the paintBoxShadow method to treat the edges to include as
logical (so that top/bottom are used instead of left/right for vertical lines). In order to make my box-shadow tests
work I had to fix a bug in the transform code of InlineTextBox that was causing the baselines of vertical lines to
be wrong.
Added fast/blockflow/box-shadow-* tests
WebCore:
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBoxShadow):
- rendering/RenderBoxModelObject.h:
LayoutTests:
- fast/blockflow/box-shadow-horizontal-bt.html: Added.
- fast/blockflow/box-shadow-vertical-lr.html: Added.
- fast/blockflow/box-shadow-vertical-rl.html: Added.
- platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
- platform/mac/fast/blockflow/border-vertical-lr-expected.png:
- platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Added.
- platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.png: Added.
- platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.txt: Added.
- platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Added.
- platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Added.
- platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt: Added.
- platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Added.
- platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.png: Added.
- platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.txt: Added.
- platform/mac/fast/blockflow/english-lr-text-expected.checksum:
- platform/mac/fast/blockflow/english-lr-text-expected.png:
- platform/mac/fast/blockflow/english-rl-text-expected.checksum:
- platform/mac/fast/blockflow/english-rl-text-expected.png:
- platform/mac/fast/blockflow/japanese-lr-text-expected.checksum:
- platform/mac/fast/blockflow/japanese-lr-text-expected.png:
- platform/mac/fast/blockflow/japanese-rl-text-expected.checksum:
- platform/mac/fast/blockflow/japanese-rl-text-expected.png:
- 10:22 PM Changeset in webkit [70842] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, test expectations update.
Disable new test added in http://trac.webkit.org/changeset/70840.
- platform/chromium/test_expectations.txt:
- 9:54 PM Changeset in webkit [70841] by
-
- 1 edit2 adds in trunk/LayoutTests
[Chromium] Not reviewed, fix test expectations.
- platform/chromium-win/fast/table/simple_paint-expected.checksum: Added.
- platform/chromium-win/fast/table/simple_paint-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 9:48 PM Changeset in webkit [70840] by
-
- 3 edits5 adds in trunk
2010-10-28 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
iframes forced into slow scrolling mode by containing RenderLayer sometimes
https://bugs.webkit.org/show_bug.cgi?id=48570
Adds a test that verifies that the repaint region for a scrolled iframe is not
larger than necessary.
- fast/repaint/iframe-scroll-repaint.html: Added.
- fast/repaint/resources/iframe-scroll-repaint-iframe.html: Added.
- platform/mac/fast/repaint/iframe-scroll-repaint-expected.checksum: Added.
- platform/mac/fast/repaint/iframe-scroll-repaint-expected.png: Added.
- platform/mac/fast/repaint/iframe-scroll-repaint-expected.txt: Added.
2010-10-28 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
iframes forced into slow scrolling mode by containing RenderLayer sometimes
https://bugs.webkit.org/show_bug.cgi?id=48570
Only performs the overlap test for RenderLayers that paint themselves. This
prevents marking RenderWidgets as being overlapped unnecessarily.
Test: fast/repaint/iframe-scroll-repaint.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
- 9:31 PM Changeset in webkit [70839] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Not reviewed, test_expectations fix.
- platform/chromium/test_expectations.txt:
- 9:19 PM Changeset in webkit [70838] by
-
- 4 edits in trunk
LLVM compiler build fix
WebKit/mac:
Reviewed by Mark Rowe.
- Misc/WebDownload.mm:
(-[WebDownload initWithRequest:delegate:]): Changed the delegate type from id to
id<NSURLDownloadDelegate> to match the method signature in NSURLDownload.
WebKit2:
- WebProcess/Downloads/mac/DownloadMac.mm:
(-[WKDownloadAsDelegate download:didReceiveResponse:]): Removed a stray semicolon.
- 8:50 PM Changeset in webkit [70837] by
-
- 12 edits2 deletes in trunk
2010-10-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r70814.
http://trac.webkit.org/changeset/70814
https://bugs.webkit.org/show_bug.cgi?id=48612
Caused media/controls-drag-timebar.html to fail on multiple
platforms (Requested by aroben on #webkit).
- media/video-seek-by-small-increment-expected.txt: Removed.
- media/video-seek-by-small-increment.html: Removed.
2010-10-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r70814.
http://trac.webkit.org/changeset/70814
https://bugs.webkit.org/show_bug.cgi?id=48612
Caused media/controls-drag-timebar.html to fail on multiple
platforms (Requested by aroben on #webkit).
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::seek):
- platform/graphics/MediaPlayer.cpp:
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
- platform/graphics/win/QTMovie.cpp:
- platform/graphics/win/QTMovie.h:
- 8:20 PM Changeset in webkit [70836] by
-
- 5 edits6 adds in trunk/WebKit2
Move some function definitions from WebEvent.h into new .cpp files
Someday maybe we'll split the classes into their own header files,
too.
Fixes <http://webkit.org/b/48604>.
Reviewed by Anders Carlsson.
- Shared/WebEvent.h: Moved code from here...
- Shared/WebEvent.cpp: Added.
- Shared/WebKeyboardEvent.cpp: Added.
- Shared/WebMouseEvent.cpp: Added.
- Shared/WebPlatformTouchPoint.cpp: Added.
- Shared/WebTouchEvent.cpp: Added.
- Shared/WebWheelEvent.cpp: Added.
...to here. Also changed WebTouchEvent::touchPoints not to copy the
Vector.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Added the new files.
- 7:56 PM Changeset in webkit [70835] by
-
- 197 edits196 copies3 adds in trunk/LayoutTests
2010-10-28 James Robinson <jamesr@chromium.org>
Update the pixel expectations for fast/tables for the Mac port.
For the tests that currently fail on Snow Leopard with --pixel-tests --tolerance 0,
this moves the current pixel results to mac-leopard and adds new Snow Leopard-specific
results to platform/mac.
List of files omitted due to length but composed entirely of moves from platform/mac to
platform/mac-leopard and newly added files in platform/mac.
- 7:35 PM Changeset in webkit [70834] by
-
- 3 edits2 adds in trunk
<rdar://problem/8597430> Crash triggered by incremental layout of block truncated by line-clamp
https://bugs.webkit.org/show_bug.cgi?id=48602
Reviewed by Simon Fraser.
WebCore:
Test: fast/flexbox/line-clamp-crash.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::applyLineClamp): Even if the child needs layout, call clearTruncation(),
since layout itself may be partial and not touch the truncated line (but touch its markup box).
LayoutTests:
- fast/flexbox/line-clamp-crash-expected.txt: Added.
- fast/flexbox/line-clamp-crash.html: Added.
- 6:29 PM Changeset in webkit [70833] by
-
- 3 edits in trunk/WebKit2
Move code to dispatch a sync message out into a separate function
https://bugs.webkit.org/show_bug.cgi?id=48605
Reviewed by Adam Roben.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::dispatchSyncMessage):
Factor code out from dispatchMessage. Handle receiving a message with an invalid reply ID.
(CoreIPC::Connection::dispatchMessages):
Call dispatchSyncMessage.
- Platform/CoreIPC/Connection.h:
- 6:28 PM Changeset in webkit [70832] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Uneviewed, test_expectations fix.
Re-suppress few test from a bunch re-enabled by http://trac.webkit.org/changeset/70823.
They have some old issues still.
- platform/chromium/test_expectations.txt:
- 6:28 PM Changeset in webkit [70831] by
-
- 1 edit in branches/chromium/552/WebCore/platform/UUID.cpp
Merge 70830 - [chromium] UUID generation does not work in Linux that has sandbox
turned on
https://bugs.webkit.org/show_bug.cgi?id=48571
BUG=59680
TEST=none
Reviewed by Dmitry Titov.
This is because we cannot access /proc when sandbox is on. The fix is to
use random numbers to construct UUID.
- platform/UUID.cpp:
(WebCore::createCanonicalUUIDString):
- 6:12 PM Changeset in webkit [70830] by
-
- 2 edits in trunk/WebCore
[chromium] UUID generation does not work in Linux that has sandbox
turned on
https://bugs.webkit.org/show_bug.cgi?id=48571
Reviewed by Dmitry Titov.
This is because we cannot access /proc when sandbox is on. The fix is to
use random numbers to construct UUID.
- platform/UUID.cpp:
(WebCore::createCanonicalUUIDString):
- 5:43 PM Changeset in webkit [70829] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-28 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Include stddef.h unconditionally in Assertions.h
https://bugs.webkit.org/show_bug.cgi?id=48573
There is no reason to have stddef.h include be MSVC-only.
- wtf/Assertions.h:
- 5:23 PM WebKit Team edited by
- (diff)
- 5:21 PM Changeset in webkit [70828] by
-
- 2 edits2 adds in trunk/WebKit2
Add NPObjectMessageReceiver class.
https://bugs.webkit.org/show_bug.cgi?id=48599
Reviewed by Darin Adler.
- Shared/Plugins/NPObjectMessageReceiver.cpp: Added.
(WebKit::NPObjectMessageReceiver::NPObjectMessageReceiver):
(WebKit::NPObjectMessageReceiver::~NPObjectMessageReceiver):
- Shared/Plugins/NPObjectMessageReceiver.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
- 5:16 PM WebKit Team edited by
- Add new committer(Gyuyoung Kim) to list (diff)
- 5:15 PM Changeset in webkit [70827] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed fix for test_expectations.
Temporarily suppress new tests that fail in Chromium port.
- platform/chromium/test_expectations.txt:
- 4:45 PM Changeset in webkit [70826] by
-
- 14 edits6 adds in trunk
2010-10-28 Jia Pu <jpu@apple.com>
Reviewed by Dan Bernstein.
Editing a word with misspell or autocorrection underline should remove the underline when the editing changes the word.
https://bugs.webkit.org/show_bug.cgi?id=48078
<rdar://problem/8579155>
- platform/mac-leopard/Skipped: New tests don't apply to this platform.
- platform/mac-snowleopard/Skipped: Ditto.
- platform/mac-tiger/Skipped: Ditto.
- platform/mac-wk2/Skipped: Ditto.
- platform/mac/editing/spelling/autocorrection-delete-expected.checksum: Updated expected test result.
- platform/mac/editing/spelling/autocorrection-delete-expected.png: Ditto.
- platform/mac/editing/spelling/editing-multiple-words-with-markers-expected.txt: Added.
- platform/mac/editing/spelling/editing-multiple-words-with-markers.html: Added.
- platform/mac/editing/spelling/editing-word-with-marker-1-expected.txt: Added.
- platform/mac/editing/spelling/editing-word-with-marker-1.html: Added.
- platform/mac/editing/spelling/editing-word-with-marker-2-expected.txt: Added.
- platform/mac/editing/spelling/editing-word-with-marker-2.html: Added.
2010-10-28 Jia Pu <jpu@apple.com>
Reviewed by Dan Bernstein.
Editing a word with misspell or autocorrection underline should remove the underline when the editing changes the word.
https://bugs.webkit.org/show_bug.cgi?id=48078
<rdar://problem/8579155>
Tests: platform/mac/editing/spelling/editing-multiple-words-with-markers.html
platform/mac/editing/spelling/editing-word-with-marker-1.html
platform/mac/editing/spelling/editing-word-with-marker-2.html
This patch is part of on-going improvement of autocorrection feature on Mac OS X. When an editing
occurs, if it affects words (by deleting/inserting characters, spliting word, merging words) that
have Spelling and/or CorrectionIndicator markers, we want to remove the markers. If subsequntial
spelling checking finds spelling error in newlly formed words, it will add the markers back in.
- dom/DocumentMarker.h: Changed MarkerType to bit masks to make search multiple types easier.
- dom/DocumentMarkerController.cpp: Refactored two removeMarkers() methods to support remove markers with specific type from a node. (WebCore::DocumentMarkerController::removeMarkers): Changed signature to remove marker with specific type. (WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair): Refactoring. (WebCore::DocumentMarkerController::hasMarkers): Convenience method to search markers in range.
- dom/DocumentMarkerController.h: Added new methods and matched new signature of removeMarkers().
- editing/Editor.cpp: (WebCore::Editor::respondToChangedContents): Remove existing markers if the change formed new word. (WebCore::Editor::cut): Remove markers on words that will be modified by this editing. (WebCore::Editor::paste): Ditto. (WebCore::Editor::pasteAsPlainText): Ditto. (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited): Main logic for removing markers on words affected by editing.
- editing/Editor.h: Added removeSpellAndCorrectionMarkersFromWordsToBeEdited(). Added REMOVE_MARKERS_UPON_EDITING and SUPPORT_AUTOCORRECTION_PANEL macro to improve readability.
- editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): Remove markers on words that will be modified by this editing. (WebCore::TypingCommand::deleteKeyPressed): Ditto. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
- 4:43 PM Changeset in webkit [70825] by
-
- 4 edits in trunk
Part of <https://bugs.webkit.org/show_bug.cgi?id=45980>
userscripts/user-script-*-document.html tests are flaky on Windows
Reviewed by Brady Eidson.
WebCore:
In WebFrameLoaderClient::committedLoad on Windows, we call through to PluginStream::didRecieveData
if our manual loader is a plugin stream, and we can call didRecieveData with a 0 length.
We shouldn't ASSERT that length is 0, because code paths exists where we call it with a 0 length.
This is tested by re-enabling user-script-plugin-document.html on Windows.
- plugins/PluginStream.cpp:
(WebCore::PluginStream::didReceiveData):
LayoutTests:
Unskip the user-script-plugin-document test because its issue is fixed.
- platform/win/Skipped:
- 4:41 PM Changeset in webkit [70824] by
-
- 2 edits1 move2 adds2 deletes in trunk/WebKitSite
2010-10-28 Lucas Forschler <Lucas Forschler>
Reviewed by Geoffrey Garen.
Bug 46927 - Sunspider 0.9 web site should prominently link to Sunspider 0.9.1
Notes:
-Created a new sunspider "landing" page which lists current and previous versions of SunSpider.
-Edited the .htaccess file to redirect the old pages to the new landing page.
-This should keep our search engine page rankings effective.
Potentially breaking:
-This COULD potentially break the SunSpider benchmark.
-Local testing with relative links seems to function as expected.
-The .htaccess 301 redirects are UNTESTED.
- .htaccess:
- perf/sunspider: Added.
- perf/sunspider-0.9.1/sunspider.html: Removed.
- perf/sunspider-0.9.1/versions.html: Removed.
- perf/sunspider-0.9/sunspider.html: Removed.
- perf/sunspider/sunspider.css: Added.
- perf/sunspider/sunspider.html: Added.
- 4:20 PM Changeset in webkit [70823] by
-
- 8 edits in trunk
2010-10-28 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Adler.
[Chromium] History related tests REGRESSED after r70723
https://bugs.webkit.org/show_bug.cgi?id=48513
Remove test_expectations.txt lines for tests that now pass.
- platform/chromium/test_expectations.txt:
2010-10-28 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Adler.
[Chromium] History related tests REGRESSED after r70723
https://bugs.webkit.org/show_bug.cgi?id=48513
Remove backItem(), forwardItem() and currentItem() from the Chromium
BackForwardList implementation, since they can use the base class
behavior now (which call itemAtIndex with -1, 1, and 0 respectively).
- history/BackForwardList.h:
- history/BackForwardListChromium.cpp:
2010-10-28 Mihai Parparita <mihaip@chromium.org>
Reviewed by Darin Adler.
[Chromium] History related tests REGRESSED after r70723
https://bugs.webkit.org/show_bug.cgi?id=48513
Since r70723 made BackForwardList::currentItem no longer be virtual,
we were not reaching the implementation in Chromium's
BackForwardListClientImpl, and for Chromium currentItem is not the same
as itemAtIndex(0).
The fix is to make itemAtIndex(0) have the currentItem() behavior, which
lets us keep currentItem as non-virtual (and remove its implementation
from the Chromium side).
This also switches Chromium to use the default implementation of
backItem() and forwardItem() (vs. the old stubs that just had
ASSERT_NOT_REACHED) since they're actually reacheable with Chromium
code thanks to the calls in FrameLoader::checkDidPerformFirstNavigation.
- src/BackForwardListClientImpl.cpp: (WebKit::BackForwardListClientImpl::itemAtIndex):
- src/BackForwardListClientImpl.h:
- 4:19 PM Changeset in webkit [70822] by
-
- 5 edits in trunk/WebKitTools
2010-10-28 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
[chromium] add a result-small.json file for the test dashboard
https://bugs.webkit.org/show_bug.cgi?id=48547
Output both a results.json file and a results-small.json file.
The dashboard will load results-small.json by default so it loads faster.
- TestResultServer/model/jsonresults.py:
- TestResultServer/model/jsonresults_unittest.py: Added a bunch of sys.path hackery. Unforunately, this uses hardcoded paths. That obviously needs to be fixed, but at least this way it clearly documents what paths are necessary.
- 4:07 PM Changeset in webkit [70821] by
-
- 3 edits2 adds in trunk
2010-10-28 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
chrome.dll!WebCore::Node::shadowAncestorNode ReadAV@NULL (98643190851b5662363449cc7303d8a5)
https://bugs.webkit.org/show_bug.cgi?id=47888
The crash was caused by the while loop in ApplyStyleCommand::fixRangeAndApplyInlineStyle
not considering the case where startNode is the root editable element.
Fixed the bug by not entering the loop when startNode is the editable root.
Test: editing/style/fix-range-from-root-editable-crash.html
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle):
2010-10-28 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
chrome.dll!WebCore::Node::shadowAncestorNode ReadAV@NULL (98643190851b5662363449cc7303d8a5)
https://bugs.webkit.org/show_bug.cgi?id=47888
Added a test to ensure ApplyStyleCommand::fixRangeAndApplyInlineStyle doesn't crash
when startNode is body and it is, therefore, the editable root.
Note that the test does not reproduce the crash when DOCTYPE is added.
- editing/style/fix-range-from-root-editable-crash-expected.txt: Added.
- editing/style/fix-range-from-root-editable-crash.html: Added.
- 4:01 PM Changeset in webkit [70820] by
-
- 7 edits in trunk/WebKitTools
2010-10-28 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkit-patch upload calls changed_files more often than it should
https://bugs.webkit.org/show_bug.cgi?id=48567
Passing changed_files around everywhere isn't a very elegant solution
but it's the one we have for the moment. I think keeping an explicit
cache on Checkout (or making StepState() a real class) is a better
long-term option.
Previously bug_id_for_this_commit was calling changed_files and the
result was never getting cached on the state. Now we're explicitly
caching the result on the state and passing that to the bug_id_for_this_commit call.
I looked into building unit tests for this. Doing so would require
using a real Checkout object with a MockSCM and overriding the appropriate
calls on SCM to count how often we're stating the file system.
That's a useful set of tests to build for a separate change.
- Scripts/webkitpy/common/checkout/api.py:
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/upload.py:
- Scripts/webkitpy/tool/mocktool.py:
- 3:57 PM Changeset in webkit [70819] by
-
- 8 edits in trunk
2010-10-28 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070
Build fix, some wrong changes slipped into the previous patch.
No new tests: build fix.
- platform/graphics/GraphicsLayer.h:
- platform/graphics/opengl/TextureMapperGL.cpp: (WebCore::BitmapTextureGL::setContentsToImage):
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::TextureMapperNode::uploadTextureFromContent): (WebCore::TextureMapperNode::paintRecursive):
- platform/qt/QWebPageClient.h: (QWebPageClient::setRootGraphicsLayer):
2010-10-28 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070
Build fix,
- WebCoreSupport/PageClientQt.cpp: (WebCore::PlatformLayerProxyQGraphicsObject::PlatformLayerProxyQGraphicsObject): (WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
- WebCoreSupport/PageClientQt.h:
- 3:27 PM Changeset in webkit [70818] by
-
- 4 edits in trunk/LayoutTests
2010-10-28 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Missing expectation file changes from bug 47853.
https://bugs.webkit.org/show_bug.cgi?id=48564
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- 3:17 PM Changeset in webkit [70817] by
-
- 5 edits2 copies in branches/chromium/552
Merge 70748 - 2010-10-27 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
r66156 broke AtlasCT library, formerly affected http://map.d.co.il/
https://bugs.webkit.org/show_bug.cgi?id=45679
This patch removes WebKit's map of classid values to MIME types. It also
changes the behavior of object elements to render fallback content when
a non-empty classid attribute is specified, which is the behavior HTML5
specifies when a UA encounters a classid it doesn't understand.
Test: fast/replaced/object-with-non-empty-classid-triggers-fallback.html
- html/HTMLObjectElement.cpp: Remove serviceTypeForClassId(), createClassIdToTypeMap(), and the ClassIdToTypeMap typedef. (WebCore::HTMLObjectElement::updateWidget): Do not call serviceTypeForClassId() when there is no type attribute, and render fallback content if the classid attribute is non-empty.
2010-10-27 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
r66156 broke AtlasCT library, formerly affected http://map.d.co.il/
https://bugs.webkit.org/show_bug.cgi?id=45679
- fast/dom/object-embed-plugin-scripting.html: Changed classid attributes to type attributes.
- fast/dom/object-plugin-hides-properties.html: Ditto.
- fast/replaced/object-with-non-empty-classid-triggers-fallback-expected.txt: Added.
- fast/replaced/object-with-non-empty-classid-triggers-fallback.html: Added.
TBR=cpu@google.com
BUG=57986
- 3:12 PM Changeset in webkit [70816] by
-
- 3 edits12 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=48568
Reviewed by James Robinson.
WebCore:
Backgrounds don't work right with vertical RenderInlines. Make background painting
do the right thing for vertical strips.
Added fast/blockflow/background-* tests
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintFillLayer):
LayoutTests:
Backgrounds don't work right with vertical RenderInlines. Make background painting
do the right thing for vertical strips.
- fast/blockflow/background-horizontal-bt.html: Added.
- fast/blockflow/background-vertical-lr.html: Added.
- fast/blockflow/background-vertical-rl.html: Added.
- platform/mac/fast/blockflow/background-horizontal-bt-expected.checksum: Added.
- platform/mac/fast/blockflow/background-horizontal-bt-expected.png: Added.
- platform/mac/fast/blockflow/background-horizontal-bt-expected.txt: Added.
- platform/mac/fast/blockflow/background-vertical-lr-expected.checksum: Added.
- platform/mac/fast/blockflow/background-vertical-lr-expected.png: Added.
- platform/mac/fast/blockflow/background-vertical-lr-expected.txt: Added.
- platform/mac/fast/blockflow/background-vertical-rl-expected.checksum: Added.
- platform/mac/fast/blockflow/background-vertical-rl-expected.png: Added.
- platform/mac/fast/blockflow/background-vertical-rl-expected.txt: Added.
- 2:56 PM Changeset in webkit [70815] by
-
- 2 edits in trunk/WebKitTools
2010-10-28 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make suggest-reviewers slightly faster
https://bugs.webkit.org/show_bug.cgi?id=48562
Add @memoized to one more common call.
- Scripts/webkitpy/common/checkout/api.py:
- 2:46 PM Changeset in webkit [70814] by
-
- 12 edits2 adds in trunk
2010-10-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
Seeking by very small increment doesn't generate 'seeked' event
https://bugs.webkit.org/show_bug.cgi?id=48530
Test: media/video-seek-by-small-increment.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::seek): Ask the media engine for its closest time value so we can avoid asking it to seek to the current time.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::mediaTimeForTimeValue): New.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::mediaTimeForTimeValue): Ditto.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::mediaTimeForTimeValue): Return the closest value in the movie's time scale.
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::mediaTimeForTimeValue): Ditto
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
- platform/graphics/win/QTMovie.cpp: (QTMovie::timeScale): Return the movie's time scale.
- platform/graphics/win/QTMovie.h:
2010-10-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben.
Seeking by very small increment doesn't generate 'seeked' event
https://bugs.webkit.org/show_bug.cgi?id=48530
- media/video-seek-by-small-increment-expected.txt: Added.
- media/video-seek-by-small-increment.html: Added.
- 2:44 PM Changeset in webkit [70813] by
-
- 3 edits12 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=48443
Reviewed by Beth Dakin.
Border images don't work right with vertical RenderInlines. Make border/mask/background painting
do the right thing for vertical strips.
WebCore:
Added fast/blockflow/border-image-* tests.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
LayoutTests:
- fast/blockflow/border-image-horizontal-bt.html: Added.
- fast/blockflow/border-image-vertical-lr.html: Added.
- fast/blockflow/border-image-vertical-rl.html: Added.
- 2:41 PM Changeset in webkit [70812] by
-
- 2 edits in trunk/WebCore
2010-10-28 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
Port ContextMenuItemWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=48407
- platform/win/ContextMenuItemWin.cpp:
- 2:38 PM Changeset in webkit [70811] by
-
- 2 edits in trunk/WebKitTools
2010-10-28 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkit-patch suggest-reviewers -g 260550a6e30b7bf34f16bdb4a5396cf26264fc1c is still very slow
https://bugs.webkit.org/show_bug.cgi?id=48536
This patch makes it about 40 seconds faster, but it still
takes 1:40. This will require more refinement.
The suggested reviewers list appears to be the same.
I think the next step may be to have it stop the search after
5 reviewers are found. We never want to suggest 30 people.
- Scripts/webkitpy/common/checkout/scm.py:
- Using --remove-empty to theoretically stop lookups past when a file is removed. I'm not entirely clear that the option does what it says it does. Example: git log --pretty=format:%H -5 --remove-empty -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h returns only one commit vs. git log --pretty=format:%H -5 -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h which returns 5. I was not aware that wx files were ever removed from the repository?
- 2:38 PM Changeset in webkit [70810] by
-
- 5 edits in trunk
2010-10-28 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
queryCommandValue should fall back to queryCommandState
https://bugs.webkit.org/show_bug.cgi?id=48479
Added a fallback to Command::value so that commands with a state function without a value function
returns the value returned by the state function as a string.
- editing/EditorCommand.cpp: (WebCore::Editor::Command::value):
2010-10-28 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
queryCommandValue should fall back to queryCommandState
https://bugs.webkit.org/show_bug.cgi?id=48479
Modified the existing tests to ensure queryCommandValue returns 'true' or 'false'
for commands that supports queryCommandState.
- editing/execCommand/script-tests/query-command-state.js: (testQueryCommandState):
- editing/execCommand/script-tests/query-text-alignment.js: (isEquivalentBoolean): (queryTextAlignment):
- 2:35 PM Changeset in webkit [70809] by
-
- 2 edits2 adds in trunk/WebKit2
Add NPObjectProxy class
https://bugs.webkit.org/show_bug.cgi?id=48558
Reviewed by Sam Weinig.
- Shared/Plugins/NPObjectProxy.cpp: Added.
(WebKit::NPObjectProxy::NPObjectProxy):
(WebKit::NPObjectProxy::~NPObjectProxy):
- Shared/Plugins/NPObjectProxy.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
- 2:23 PM Changeset in webkit [70808] by
-
- 2 edits in trunk/LayoutTests
2010-10-28 Martin Robinson <mrobinson@igalia.com>
Unskip some passing canvas tests on GTK+. These were
likely fixed by the recent shadow changes.
- platform/gtk/Skipped: Unskip passing tests.
- 2:16 PM Changeset in webkit [70807] by
-
- 3 edits6 deletes in trunk/LayoutTests
Remove test expectations obsoleted by r70619.
- platform/chromium-linux/fast/block/float/tableshifting-expected.checksum: Removed.
- platform/chromium-linux/fast/block/float/tableshifting-expected.png: Removed.
- platform/chromium-win/fast/block/float/tableshifting-expected.checksum: Removed.
- platform/chromium-win/fast/block/float/tableshifting-expected.png: Removed.
- platform/chromium-win/fast/block/float/tableshifting-expected.txt: Removed.
- platform/gtk/Skipped: Unskip fast/block/float/tableshifting.html
- platform/qt/Skipped: Ditto.
- platform/qt/fast/block/float/tableshifting-expected.txt: Removed.
- 2:15 PM UsingGitWithWebKit edited by
- (diff)
- 2:09 PM Changeset in webkit [70806] by
-
- 2 edits in trunk/LayoutTests
2010-10-28 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed, updating drt_expectations.txt.
- platform/chromium/drt_expectations.txt:
- 2:09 PM Changeset in webkit [70805] by
-
- 12 edits in trunk/WebCore
2010-10-28 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Rolling out r70800.
- 1:35 PM Changeset in webkit [70804] by
-
- 3 edits in trunk/WebCore
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=48551
HTMLDocument::isFrameSet() should not depend on renderer
No change in functionality, so no new tests.
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::isFrameSet): Omit the check for renderer.
- rendering/RenderLayer.h: Removed unneeded includes and forward declarations.
- 1:30 PM Changeset in webkit [70803] by
-
- 3 edits52 adds in trunk/LayoutTests
2010-10-28 Matthew Delaney <mdelaney@apple.com>
Reviewed by Oliver Hunt.
Unskip remaining canvas layout tests so that they can track progressions/regressions
https://bugs.webkit.org/show_bug.cgi?id=46439
- platform/mac-leopard/Skipped: Moving overall mac skipped tests down to specifically leopard skipped.
- platform/mac-snowleopard/canvas/philip/tests: Added snowleopard specific expectation files for now unskipped tests.
- platform/mac/Skipped: Unskipped all canvas tests that we want to track. Commented why the test that remain on the list are there.
- 1:23 PM Changeset in webkit [70802] by
-
- 2 edits3 adds in trunk/WebKit2
Add NPRemoteObjectMap class
https://bugs.webkit.org/show_bug.cgi?id=48553
Reviewed by Sam Weinig.
- Shared/Plugins/NPRemoteObjectMap.cpp: Added.
(WebKit::NPRemoteObjectMap::NPRemoteObjectMap):
- Shared/Plugins/NPRemoteObjectMap.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
- 1:23 PM Changeset in webkit [70801] by
-
- 6 edits4 copies in branches/chromium/552
Merge 70797
BUG=55215
- 1:22 PM Changeset in webkit [70800] by
-
- 12 edits in trunk/WebCore
2010-10-28 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: make legacy resource tracking optional in the native code,
make cookeis work against new resource manager.
https://bugs.webkit.org/show_bug.cgi?id=48532
- inspector/InspectorCSSStore.cpp: (WebCore::InspectorCSSStore::resourceStyleSheetText):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::unbindAllResources): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::frameDetachedFromParent): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::markResourceAsCached): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::setResourceTrackingEnabled): (WebCore::InspectorController::getCookies): (WebCore::InspectorController::deleteCookie): (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket): (WebCore::InspectorController::breakpointsSettingKey): (WebCore::InspectorController::getResourceContent):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::markFailed):
- inspector/InspectorResource.h:
- inspector/InspectorResourceAgent.cpp: (WebCore::populateObjectWithFrameResources):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
- inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype._updateResourceWithResponse): (WebInspector.ResourceManager.prototype.didFailLoading):
- inspector/front-end/inspector.js: (WebInspector.updateResource):
- 1:13 PM Changeset in webkit [70799] by
-
- 3 edits in trunk/WebCore
2010-10-28 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: fix pausing on next JavaScript statement
https://bugs.webkit.org/show_bug.cgi?id=48534
- inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement): (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement): (WebCore::InspectorDebuggerAgent::pause): (WebCore::InspectorDebuggerAgent::didPause):
- inspector/InspectorDebuggerAgent.h:
- 1:01 PM QtWebKitTableOfFeatures46 edited by
- (diff)
- 12:48 PM QtWebKitPerformanceWork edited by
- (diff)
- 12:46 PM Changeset in webkit [70798] by
-
- 24 edits3 copies in branches/chromium/552
Merge 70741 - 2010-10-27 Kinuko Yasuda <kinuko@chromium.org>
DOMFileSystem's reference should be kept while there're any active Entries/callbacks
https://bugs.webkit.org/show_bug.cgi?id=47535
Changed to keep DOMFileSystem's reference in each EntryBase, DirectoryReaderBase, EntryCallbacks and EntriesCallbacks.
BUG=61040
TEST=fast/filesystem/filesystem-reference.html
- 12:43 PM QtWebKitMirrorGuide edited by
- (diff)
- 12:30 PM Changeset in webkit [70797] by
-
- 8 edits4 adds in trunk
2010-10-28 Yuzo Fujishima <yuzo@google.com>
Reviewed by David Hyatt.
Fix for Bug 14550 - Non-layout style change does not update nested first-letter
https://bugs.webkit.org/show_bug.cgi?id=14550
If a render text fragment is accompanied by a first letter, update the
first letter's style when the fragment's style is changed.
Test: fast/css/first-letter-nested.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleDidChange): Stop calling updateFirstLetter from here.
- rendering/RenderBlock.h: Make updateFirstLetter accessbile from RenderTextFragment.
- rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::styleDidChange): If appropriate, update first letter after removing stale cached pseudo style. (WebCore::RenderTextFragment::blockForAccompanyingFirstLetter): Helper to get the block for the first letter.
- rendering/RenderTextFragment.h:
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::removeCachedPseudoStyle): Remove the specified pseudo style from cache.
- rendering/style/RenderStyle.h:
2010-10-28 Yuzo Fujishima <yuzo@google.com>
Reviewed by David Hyatt.
Fix for Bug 14550 - Non-layout style change does not update nested first-letter
https://bugs.webkit.org/show_bug.cgi?id=14550
- fast/css/first-letter-nested-expected.txt: Added.
- fast/css/first-letter-nested.html: Added.
- fast/css/first-letter-removed-added-expected.txt: Added.
- fast/css/first-letter-removed-added.html: Added.
- 12:30 PM QtWebKitFeatures46 edited by
- (diff)
- 12:29 PM QtWebKitFeatures20 edited by
- (diff)
- 12:27 PM QtWebKitContrib edited by
- (diff)
- 12:21 PM QtWebKit edited by
- (diff)
- 12:17 PM Changeset in webkit [70796] by
-
- 7 edits in trunk
2010-10-28 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
[Chromium] Support FileSystem in chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=47643
Update the chromium DEPS to pick up corresponding webkit_support change.
Also add a temporary glue implementation with FIXME comment to
WebFrameClient::openFileSystem.
- DEPS:
- public/WebFrameClient.h: (WebKit::WebFrameClient::openFileSystem):
2010-10-28 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
[Chromium] Support FileSystem in chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=47643
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::openFileSystem): Added.
- DumpRenderTree/chromium/WebViewHost.h: (WebViewHost::openFileSystem): Added.
- 12:09 PM Changeset in webkit [70795] by
-
- 5 edits in trunk
WKURLRefs should be allowed to be null
<rdar://problem/8575621>
https://bugs.webkit.org/show_bug.cgi?id=48535
Reviewed by Anders Carlsson.
WebKit2:
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toURLRef):
(WebKit::toCopiedURLAPI):
Turn a null WTF::String into a null WKURLRef.
WebKitTools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
(TestWebKitAPI::didStartProvisionalLoadForFrame):
(TestWebKitAPI::didCommitLoadForFrame):
(TestWebKitAPI::didFinishLoadForFrame):
Test that URLs are null pointers when unset.
- 12:05 PM Changeset in webkit [70794] by
-
- 5 edits in trunk/LayoutTests
2010-10-28 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Add shouldBeDefined function to js-test-pre.js and update
context-attributes-etc test to use it.
https://bugs.webkit.org/show_bug.cgi?id=47853
- fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt:
- fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/js/resources/js-test-pre.js: (shouldBeDefined):
- 12:04 PM Changeset in webkit [70793] by
-
- 2 edits in trunk/WebCore
2010-10-28 Benoit Jacob <bjacob@mozilla.com>
Reviewed by Kenneth Russell.
Ensure that WebGL stencil buffers are correctly initialized
https://bugs.webkit.org/show_bug.cgi?id=48351
- html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::initializeRenderbuffers):
- 11:54 AM Changeset in webkit [70792] by
-
- 7 edits2 adds in trunk
AX: multi select group option does not handle setting of AXSelectedChildren correctly
https://bugs.webkit.org/show_bug.cgi?id=48464
Reviewed by Adele Peterson.
WebCore:
Ensure that when selecting an item from a <select> element, it accounts for <optgroups>.
Test: platform/mac/accessibility/select-element-selection-with-optgroups.html
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::setSelected):
WebKitTools:
Add support for querying information about selected children to DRT, including:
selectedChildAtIndex
selectedChildrenCount
setSelectedChild
- DumpRenderTree/AccessibilityUIElement.cpp:
(selectedChildAtIndexCallback):
(setSelectedChildCallback):
(selectedChildrenCountCallback):
(AccessibilityUIElement::setSelectedChild):
(AccessibilityUIElement::selectedChildrenCount):
(AccessibilityUIElement::selectedChildAtIndex):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::selectedChildAtIndex):
(AccessibilityUIElement::selectedChildrenCount):
(AccessibilityUIElement::setSelectedChild):
LayoutTests:
- platform/mac/accessibility/select-element-selection-with-optgroups-expected.txt: Added.
- platform/mac/accessibility/select-element-selection-with-optgroups.html: Added.
- 11:28 AM Changeset in webkit [70791] by
-
- 4 edits in trunk/WebKitLibraries
Added UniCharProvider-based ways to create a CTTypeSetter and a CTLine, to be used in an
upcoming ComplexTextController patch.
Reviewed by John Sullivan.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 11:21 AM Changeset in webkit [70790] by
-
- 13 edits in trunk
Add WebKit2 API for window feature getter/setters
<rdar://problem/8590373>
https://bugs.webkit.org/show_bug.cgi?id=48496
Reviewed by Anders Carlsson.
WebKit2:
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setToolbarsAreVisible):
(WebKit::WebPageProxy::getToolbarsAreVisible):
(WebKit::WebPageProxy::setMenuBarIsVisible):
(WebKit::WebPageProxy::getMenuBarIsVisible):
(WebKit::WebPageProxy::setStatusBarIsVisible):
(WebKit::WebPageProxy::getStatusBarIsVisible):
(WebKit::WebPageProxy::setIsResizable):
(WebKit::WebPageProxy::getIsResizable):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::toolbarsAreVisible):
(WebKit::WebUIClient::setToolbarsAreVisible):
(WebKit::WebUIClient::menuBarIsVisible):
(WebKit::WebUIClient::setMenuBarIsVisible):
(WebKit::WebUIClient::statusBarIsVisible):
(WebKit::WebUIClient::setStatusBarIsVisible):
(WebKit::WebUIClient::isResizable):
(WebKit::WebUIClient::setIsResizable):
- UIProcess/WebUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::setToolbarsVisible):
(WebKit::WebChromeClient::toolbarsVisible):
(WebKit::WebChromeClient::setStatusbarVisible):
(WebKit::WebChromeClient::statusbarVisible):
(WebKit::WebChromeClient::setMenubarVisible):
(WebKit::WebChromeClient::menubarVisible):
(WebKit::WebChromeClient::setResizable):
Plumb through the calls.
WebKitTools:
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
- MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):
- WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage):
(WTR::TestController::initialize):
- 11:08 AM Changeset in webkit [70789] by
-
- 3 edits in trunk/WebKitTools
2010-10-28 Søren Gjesse <sgjesse@chromium.org>
Reviewed by Tony Chang.
Added support for the DumpRenderTree flags --multiple-loads and --js-flags to the Python test runner.
https://bugs.webkit.org/show_bug.cgi?id=48236
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 10:37 AM Changeset in webkit [70788] by
-
- 6 edits in trunk
2010-10-28 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] WebKitWebFrame's load-status is not properly notified to the tests
https://bugs.webkit.org/show_bug.cgi?id=48048
- platform/gtk/Skipped: unskipped a couple of tests
2010-10-28 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] WebKitWebFrame's load-status is not properly notified to the tests
https://bugs.webkit.org/show_bug.cgi?id=48048
"frame-created" signal must be issued before loading any data,
that way clients can correctly capture all the loading related
signals for that frame.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame):
2010-10-28 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] WebKitWebFrame's load-status is not properly notified to the tests
https://bugs.webkit.org/show_bug.cgi?id=48048
DRT now listens to WebKitWebFrame load-status signals for each
created frame instead of the load-status signal of the
WebKitWebView that only notifies about changes in the main frame.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewLoadFinished): (webFrameLoadStatusNotified): (frameCreatedCallback): (createWebView): (main):
- 10:19 AM Changeset in webkit [70787] by
-
- 2 edits in trunk/WebKit2
Build fix.
- win/WebKit2Common.vsprops:
- 10:10 AM Changeset in webkit [70786] by
-
- 4 edits in trunk
2010-10-28 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix textInputController.{selectedRange,markedRange}
https://bugs.webkit.org/show_bug.cgi?id=48487
- platform/chromium/test_expectations.txt: correct some comments about
firstRectForCharacterRange.
2010-10-28 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix textInputController.{selectedRange,markedRange}
https://bugs.webkit.org/show_bug.cgi?id=48487
- DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::markedRange): Return arrays of ints, rather than a string (TextInputController::selectedRange): Ditto.
- 9:53 AM Changeset in webkit [70785] by
-
- 6 edits in trunk
No longer soft-link zlib
https://bugs.webkit.org/show_bug.cgi?id=48004
Reviewed by Adam Roben.
WebCore:
- platform/graphics/WOFFFileFormat.cpp:
(WebCore::convertWOFFToSfnt): Removed Windows-speciific code to soft-link
zlib.
WebKit2:
- win/WebKit2Common.vsprops: Added zlib.lib to AdditionalDependencies.
LayoutTests:
- platform/win/Skipped: Enabled fast/css/font-face-woff.html.
- 9:51 AM Changeset in webkit [70784] by
-
- 6 edits in trunk
2010-10-27 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Work around a Mac driver bug in generateMipmap
https://bugs.webkit.org/show_bug.cgi?id=48489
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::generateMipmap): Make sure minFilter is set to NEAREST_MIPMAP_LINEAR before generateMipmap, and after the call, set it back to the original value.
- html/canvas/WebGLTexture.h: (WebCore::WebGLTexture::getMinFilter): Return the cached minFilter value.
2010-10-27 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Work around a Mac driver bug in generateMipmap
https://bugs.webkit.org/show_bug.cgi?id=48489
- fast/canvas/webgl/texture-npot-expected.txt: Add back the failing part due to the generateMipmap Mac driver bug.
- fast/canvas/webgl/texture-npot.html: Ditto.
- 9:38 AM Changeset in webkit [70783] by
-
- 2 edits in trunk/LayoutTests
2010-10-28 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed fix for test_expectations.
- platform/chromium/test_expectations.txt:
- 9:27 AM Changeset in webkit [70782] by
-
- 2 edits in trunk/WebKitTools
2010-10-27 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
[chromium] add a master-name flag to new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=48488
The test results server now allows adding a master name to
the uploaded files. This lets us distinguish bots that have
the same name, but are on different masters.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 9:14 AM Changeset in webkit [70781] by
-
- 5 edits in trunk
Make PluginView retain its HTMLPlugInElement
This matches WebKit/mac's WebBaseNetscapePluginView. WebCore didn't do
this, but had a very different mechanism for implementing NPRuntime
that didn't require it.
Fixes <http://webkit.org/b/46672> <rdar://problem/8484208> Crash
(preceded by assertion) in Node::document when running
plugins/document-open.html in WebKit2 on Windows
Reviewed by Anders Carlsson.
LayoutTests:
Remove plugins/document-open.html from the win-wk2 Skipped file
It passes now that <http://webkit.org/b/46672> is fixed.
- platform/win-wk2/Skipped:
WebKit2:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::create): Moved here from the header file so that
clients of the header file won't have to pull in HTMLPlugInElement.h.
Changed to take a PassRefPtr<HTMLPlugInElement>.
(WebKit::PluginView::PluginView): Changed to take a
PassRefPtr<HTMLPlugInElement> and to use m_pluginElement later (because
the parameter to the function will be nulled-out after assigning into
m_pluginElement).
(WebKit::PluginView::pluginElementNPObject): Updated for change to m_pluginElement.
- WebProcess/Plugins/PluginView.h: Made m_pluginElement a RefPtr.
- 9:13 AM Changeset in webkit [70780] by
-
- 2 edits in trunk/WebKitTools
Don't append a newline to the test output if the frame has no document element in WebKitTestRunner
Fixes <http://webkit.org/b/48526> Extra trailing newline when running
plugins/document-open.html in WebKitTestRunner
Reviewed by Anders Carlsson.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::toJS): Added. Turns a UTF-8 C string into a JSStringRef.
(WTR::hasDocumentElement): Added. Uses the JSC API to figure out
whether the frame has a document element.
(WTR::dumpFrameText): Match DRT by bailing (rather than appending an
empty string and a newline) if the frame has no document element.
- 9:13 AM Changeset in webkit [70779] by
-
- 3 edits in trunk/LayoutTests
Recategorize the failure of plugins/mouse-events.html for WebKit2
This should have been done in r70685.
- platform/mac-wk2/Skipped: Moved plugins/mouse-events.html into the
"Need eventSender" category...
- platform/win-wk2/Skipped: ...from here.
- 9:05 AM Changeset in webkit [70778] by
-
- 2 edits in trunk/WebKit/qt
[Qt] QWebElement: Don't retrieve CSS rules through DOMWindow.
https://bugs.webkit.org/show_bug.cgi?id=48519
Reviewed by Andreas Kling.
JavaScript is prevented from retrieving cross-domain CSS rules since r70335.
This patch allow QWebElement to retrive style without this limitation
by asking the Document directly instead of going through DOMWindow.
Fixes:
- tst_QWebFrame::setHtmlWithResource()
- tst_QWebElement::style()
- Api/qwebelement.cpp:
(QWebElement::styleProperty):
- 8:49 AM Changeset in webkit [70777] by
-
- 4 edits in trunk
2010-10-28 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Andreas Kling.
Make Qt viewportAttributesForSize not assert on (0, 0) size
https://bugs.webkit.org/show_bug.cgi?id=48524
We now return an invalid (isValid() == false) ViewportAttributes
instance when the supplied size is (0, 0).
- Api/qwebpage.cpp: (QWebPage::viewportAttributesForSize):
2010-10-28 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Andreas Kling.
Make Qt viewportAttributesForSize not assert on (0, 0) size
https://bugs.webkit.org/show_bug.cgi?id=48524
We now return an invalid (isValid() == false) ViewportAttributes
instance when the supplied size is (0, 0).
- UIProcess/API/qt/qwkpage.cpp: (QWKPage::viewportAttributesForSize):
- 7:52 AM Changeset in webkit [70776] by
-
- 2 edits in trunk/WebKit2
2010-10-28 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Andreas Kling.
[Qt][WK2] SharedMemory should be released by the receiving process
https://bugs.webkit.org/show_bug.cgi?id=48520
- Platform/qt/SharedMemoryQt.cpp: (WebKit::SharedMemory::~SharedMemory): (WebKit::SharedMemory::createHandle):
- 7:23 AM Changeset in webkit [70775] by
-
- 3 edits in trunk/WebCore
2010-10-28 Mikhail Naganov <mnaganov@chromium.org>
[Chromium clang] Unreviewed. Fix forward declaration of 'struct FileMetadata'.
- fileapi/FileSystemCallbacks.h:
- platform/AsyncFileSystemCallbacks.h:
- 7:03 AM Changeset in webkit [70774] by
-
- 2 edits in trunk/LayoutTests
2010-10-28 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update.
Remove rule for non-existent long-css-selector-matches test.
- platform/chromium/test_expectations.txt:
- 6:50 AM Changeset in webkit [70773] by
-
- 2 edits in trunk/WebKitTools
Skip npn-invalidate-rect-invalidates-window.html on headless XP machines
TestNetscapePlugIn never receives a WM_PAINT message on headless XP
machines, so this test times out. Fixing the test is covered by
<http://webkit.org/b/48333>.
- Scripts/old-run-webkit-tests: Skip
npn-invalidate-rect-invalidates-window.html on Windows if accelerated
compositing support is disabled, which likely means we're on a headless
XP machine.
- 6:27 AM Changeset in webkit [70772] by
-
- 11 edits in trunk
2010-10-28 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Bring backend-frontend message format to follow the protocol specification
https://bugs.webkit.org/show_bug.cgi?id=48406
WebCore:
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::applyStyleText): (WebCore::InspectorDOMAgent::buildObjectForStyle): (WebCore::InspectorDOMAgent::populateObjectWithStyleProperties): (WebCore::InspectorDOMAgent::buildObjectForStyleSheet): (WebCore::InspectorDOMAgent::buildObjectForRule):
- inspector/InspectorDOMAgent.h:
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
- inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.parseRuleArrayPayload): (WebInspector.CSSStyleModel.prototype.getStylesAsync): (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync): (WebInspector.CSSStyleModel.prototype.getInlineStyleAsync): (WebInspector.CSSStyleModel.prototype.setCSSText):
- inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration): (WebInspector.CSSStyleDeclaration.parsePayload): (WebInspector.CSSStyleDeclaration.prototype.get allProperties): (WebInspector.CSSStyleDeclaration.prototype.getLiveProperty): (WebInspector.CSSStyleDeclaration.prototype.getPropertyValue): (WebInspector.CSSStyleDeclaration.prototype.getPropertyPriority): (WebInspector.CSSStyleDeclaration.prototype.getPropertyShorthand): (WebInspector.CSSStyleDeclaration.prototype.isPropertyImplicit): (WebInspector.CSSStyleDeclaration.prototype.getShorthandValue): (WebInspector.CSSStyleDeclaration.prototype.getShorthandPriority): (WebInspector.CSSStyleDeclaration.prototype.appendProperty): (WebInspector.CSSStyleDeclaration.prototype.propertyAt): (WebInspector.CSSRule): (WebInspector.CSSRule.parsePayload): (WebInspector.CSSRule.prototype.get isUserAgent): (WebInspector.CSSRule.prototype.get isUser): (WebInspector.CSSRule.prototype.get isViaInspector): (WebInspector.CSSRule.prototype.get isRegular): (WebInspector.CSSProperty): (WebInspector.CSSProperty.parsePayload): (WebInspector.CSSProperty.prototype.get propertyText): (WebInspector.CSSProperty.prototype.get isLive): (WebInspector.CSSProperty.prototype.get active): (WebInspector.CSSProperty.prototype.get styleBased): (WebInspector.CSSProperty.prototype.get inactive): (WebInspector.CSSProperty.prototype.get disabled): (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setValue): (WebInspector.CSSProperty.prototype.setDisabled.callback): (WebInspector.CSSProperty.prototype.setDisabled):
- inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.update.callback): (WebInspector.MetricsSidebarPane.prototype.update.inlineStyleCallback): (WebInspector.MetricsSidebarPane.prototype.update): (WebInspector.MetricsSidebarPane.prototype._update): (WebInspector.MetricsSidebarPane.prototype.editingCommitted.callback): (WebInspector.MetricsSidebarPane.prototype.editingCommitted.setEnabledValueCallback): (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._rebuildUpdate): (WebInspector.StylesSidebarPane.prototype._refreshStyleRules): (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules): (WebInspector.StylesSidebarPane.prototype._markUsedProperties): (WebInspector.StylesSidebarPane.prototype._containsInherited): (WebInspector.StylePropertiesSection): (WebInspector.StylePropertiesSection.prototype.isPropertyInherited): (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded): (WebInspector.StylePropertiesSection.prototype.onpopulate): (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.ComputedStylePropertiesSection.prototype._isPropertyInherited): (WebInspector.ComputedStylePropertiesSection.prototype.onpopulate): (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace): (WebInspector.StylePropertyTreeElement): (WebInspector.StylePropertyTreeElement.prototype.get disabled): (WebInspector.StylePropertyTreeElement.prototype.get name): (WebInspector.StylePropertyTreeElement.prototype.get priority): (WebInspector.StylePropertyTreeElement.prototype.get value): (WebInspector.StylePropertyTreeElement.prototype.get parsedOk): (WebInspector.StylePropertyTreeElement.prototype): (WebInspector.StylePropertyTreeElement.prototype.):
LayoutTests:
- http/tests/inspector/inspect-iframe-from-different-domain.html:
- inspector/styles-source-offsets.html:
- 6:04 AM Changeset in webkit [70771] by
-
- 6 edits in branches/chromium/552
Merge 70682 - 2010-10-27 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: "Reload Page and Audit on Load" fails to run audits when resource tracking is disabled
https://bugs.webkit.org/show_bug.cgi?id=48431
- http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.enableResourceTracking): (initialize_InspectorTest.InspectorTest.disableResourceTracking):
- http/tests/inspector/resource-parameters.html:
- inspector/audits-panel-functional.html:
- inspector/styles-source-offsets.html:
2010-10-27 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: "Reload Page and Audit on Load" fails to run audits when resource tracking is disabled
https://bugs.webkit.org/show_bug.cgi?id=48431
- inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._createPanelEnabler): (WebInspector.ResourcesPanel.prototype._enableResourceTracking):
TBR=apavlov@chromium.org
BUG=60929
- 6:01 AM Changeset in webkit [70770] by
-
- 2 edits in trunk/LayoutTests
2010-10-28 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update.
Update expectation for linux javascriptlink-frames.html
- platform/chromium/test_expectations.txt:
- 5:56 AM Changeset in webkit [70769] by
-
- 2 edits in trunk/WebKit/chromium
2010-10-28 Satish Sampath <satish@chromium.org>
Reviewed by Steve Block.
Remove obsolete public/API methods in chromium port
https://bugs.webkit.org/show_bug.cgi?id=48504
- public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition):
- 5:37 AM Changeset in webkit [70768] by
-
- 3 edits1 add1 delete in trunk/LayoutTests
2010-10-28 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update.
Rebaseline test results.
- platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.checksum: Added.
- platform/chromium-mac/fast/borders/border-radius-split-inline-expected.checksum:
- platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- 5:19 AM Changeset in webkit [70767] by
-
- 2 edits in trunk/LayoutTests
2010-10-28 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update.
Mark regressed after r70723 history-related tests.
- platform/chromium/test_expectations.txt:
- 5:16 AM Changeset in webkit [70766] by
-
- 2 edits in trunk/JavaScriptCore
Try to fix interpreter build.
Rubber stamped by Csaba Osztrogonác.
Needed parentheses around assignment to avoid GCC warning after
http://trac.webkit.org/changeset/70703
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- 5:03 AM Changeset in webkit [70765] by
-
- 2 edits in trunk/WebKitTools
2010-10-28 Kimmo Kinnunen <Kimmo Kinnunen>
Adding myself as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 4:17 AM Changeset in webkit [70764] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-28 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Csaba Osztrogonác.
resetAssertionMatches() is an unused function in YARR Interpreter
https://bugs.webkit.org/show_bug.cgi?id=48503
The resetAssertionMatches() function is removed from YARR Interpreter
because it's never called.
- yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::resetMatches):
- 3:41 AM Changeset in webkit [70763] by
-
- 8 edits6 adds in trunk
2010-10-28 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
WebKit needs to expose an Element::spellcheck attribute to javascript.
https://bugs.webkit.org/show_bug.cgi?id=25536
- editing/spelling/script-tests/spelling-attribute-change.js: Added.
- editing/spelling/spelling-attribute-change-expected.txt: Added.
- editing/spelling/spelling-attribute-change.html: Added.
- fast/dom/HTMLElement/script-tests/spellcheck.js: Added.
- fast/dom/HTMLElement/spellcheck-expected.txt: Added.
- fast/dom/HTMLElement/spellcheck.html: Added.
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/qt/Skipped:
2010-10-27 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
WebKit needs to expose an Element::spellcheck attribute to javascript.
https://bugs.webkit.org/show_bug.cgi?id=25536
Published Element.spellcheck property on IDL, implemented it.
Tests: editing/spelling/spelling-attribute-change.html
fast/dom/HTMLElement/spellcheck.html
- html/HTMLElement.cpp: (WebCore::HTMLElement::spellcheck): (WebCore::HTMLElement::setSpellcheck):
- html/HTMLElement.h:
- html/HTMLElement.idl:
- 3:22 AM Changeset in webkit [70762] by
-
- 15 edits in trunk
2010-10-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: make debugger work against new resource manager.
https://bugs.webkit.org/show_bug.cgi?id=48376
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::identifierForInitialRequest):
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::identifierForInitialRequest):
- inspector/InspectorResourceAgent.h:
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onGetResourceContent):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set content):
- inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager): (WebInspector.ResourceManager.prototype.identifierForInitialRequest): (WebInspector.ResourceManager.prototype._createResource): (WebInspector.ResourceManager.prototype.willSendRequest): (WebInspector.ResourceManager.prototype._updateResourceWithRequest): (WebInspector.ResourceManager.prototype.didFinishLoading): (WebInspector.ResourceManager.prototype.didFailLoading): (WebInspector.ResourceManager.prototype.setOverrideContent): (WebInspector.ResourceManager.prototype._processCachedResources): (WebInspector.ResourceManager.prototype._addFramesRecursively): (WebInspector.ResourceManager.prototype.resourceForURL): (WebInspector.ResourceManager.prototype.addConsoleMessage): (WebInspector.ResourceManager.prototype.clearConsoleMessages): (WebInspector.ResourceManager.prototype.forAllResources): (WebInspector.ResourceManager.prototype._bindResourceURL): (WebInspector.ResourceManager.prototype._unbindResourceURL): (WebInspector.ResourceManager.getContent): (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame): (WebInspector.ResourceTreeModel.prototype.addResourceToFrame): (WebInspector.ResourceTreeModel.prototype._clearResources):
- inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.addOrUpdateFrame):
- inspector/front-end/networkPanel.css: (.network.panel .resources-dividers):
2010-10-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: make debugger work against new resource manager.
https://bugs.webkit.org/show_bug.cgi?id=48376
- http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.reloadPageIfNeeded): (initialize_InspectorTest.InspectorTest.pageReloaded):
- http/tests/inspector/resource-har-conversion.html:
- http/tests/inspector/resource-parameters.html:
- inspector/extensions-resources.html:
- 2:25 AM Changeset in webkit [70761] by
-
- 1 edit in branches/chromium/552/WebCore/inspector/front-end/inspector.css
Merge 69494 - 2010-10-11 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: fix event listener breakpoints sidebar pane style
https://bugs.webkit.org/show_bug.cgi?id=47487
- inspector/front-end/inspector.css: (.section .properties, .event-bar .event-properties): (.section.expanded .properties, .event-bar.expanded .event-properties): (.properties-tree): (.properties-tree li): (.properties-tree li.parent): (.properties-tree li.parent::before): (.properties-tree li.parent.expanded::before): (.properties-tree li .info): (.properties-tree ol, .stack-trace ol, ol.stack-trace): (.properties-tree ol.expanded, .stack-trace ol, ol.stack-trace): (ol.stack-trace): (.event-listener-breakpoints .event-category): (.event-listener-breakpoints.properties-tree .children li): (.event-listener-breakpoints .checkbox-elem): (.breakpoint-list .breakpoint-hit):
TBR=podivilov@chromium.org
BUG=61066
- 2:02 AM Changeset in webkit [70760] by
-
- 2 edits in trunk/WebKit2
2010-10-28 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Web process cannot be debugged if it crashes in initialization
https://bugs.webkit.org/show_bug.cgi?id=47399
Wait 3 seconds for the debugger on debug mode if
WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH environment variable is set.
The debugging can be initiated for example in following way:
export WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH=1
./MiniBrowser & while [ -zpidof QtWebProcess]; do sleep 1; done; \
gdb --pid=
pidof QtWebProcess
- WebProcess/qt/WebProcessMainQt.cpp: (WebKit::WebProcessMainQt):
- 1:33 AM Changeset in webkit [70759] by
-
- 2 edits in trunk/WebCore
One more Qt fix due to r70754.
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::hasValidClassId):
- 1:21 AM Changeset in webkit [70758] by
-
- 2 edits in trunk/WebCore
2010-10-28 Pascal Massimino <pascal.massimino@gmail.com>
Reviewed by Adam Barth.
fix setSize() call flow: it was only called the first
time (when onlySize is true)
Bug URL: https://bugs.webkit.org/show_bug.cgi?id=48494
Testing: difficult to exercise the bug, as it requires
some manual flow (change tab, scroll,...)
- platform/image-decoders/webp/WEBPImageDecoder.cpp: (WebCore::WEBPImageDecoder::decode):
fix: call setSize() even when onlySize is false
- 1:16 AM Changeset in webkit [70757] by
-
- 3 edits in trunk/WebCore
Fix the Qt build after r70754.
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::hasValidClassId):
(WebCore::HTMLObjectElement::updateWidget):
- html/HTMLObjectElement.h:
- 1:08 AM Changeset in webkit [70756] by
-
- 2 edits in trunk/WebKit2
32-bit build fix.
Qualify references to Rect to avoid ambiguity between WebCore::Rect and Carbon's Rect.
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformPostInitialize):
(WebKit::NetscapePlugin::windowFrameChanged):
- 1:02 AM Changeset in webkit [70755] by
-
- 3 edits in trunk/LayoutTests
2010-10-28 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Fix test description
https://bugs.webkit.org/show_bug.cgi?id=48501
I mistakenly copy/pasted this text from another test.
- fast/dom/allowed-children-expected.txt:
- fast/dom/allowed-children.html:
- 12:47 AM Changeset in webkit [70754] by
-
- 2 edits in trunk/WebCore
2010-10-28 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
Fix a test failure introduced in r70748 by supporting Qt's non-standard
use of classid.
https://bugs.webkit.org/show_bug.cgi?id=45679
- html/HTMLObjectElement.cpp: (WebCore::objectHasSupportedClassId): Return true if the object's serviceType is 'application/x-qt-plugin'. (WebCore::HTMLObjectElement::updateWidget): Do not render fallback content if a non-empty classid is specified for a Qt plugin object.
- 12:47 AM Changeset in webkit [70753] by
-
- 2 edits in trunk/WebKit
Stop allowing deprecated methods to be used in NetscapePluginHostProxy.mm now
that deprecated methods are no longer used.
- WebKit.xcodeproj/project.pbxproj:
- 12:22 AM Changeset in webkit [70752] by
-
- 2 edits in trunk/JavaScriptCore
Wrong instruction form for BKPT
https://bugs.webkit.org/show_bug.cgi?id=48427
Reviewed by Andreas Kling.
One '0' is missing from BKPT instruction.
Thanks for Jacob Bramley for reporting this error.
- assembler/ARMAssembler.h:
- 12:14 AM Changeset in webkit [70751] by
-
- 18 edits in trunk
2010-10-28 Ivan Krstić <ike@apple.com>
Reviewed by Mark Rowe.
Remove unused experimental proxied panel interface.
<rdar://problem/7237059>
- WebCore.exp.in:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
2010-10-28 Ivan Krstić <ike@apple.com>
Reviewed by Mark Rowe.
Remove unused experimental proxied panel interface.
<rdar://problem/7237059>
- Plugins/Hosted/NetscapePluginHostManager.h:
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::hostForPlugin): (WebKit::NetscapePluginHostManager::spawnPluginHost): (WebKit::NetscapePluginHostManager::instantiatePlugin):
- Plugins/Hosted/NetscapePluginHostProxy.mm:
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/Hosted/WebKitPluginHost.defs:
- WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]):
- WebView/WebPreferencesPrivate.h:
2010-10-28 Ivan Krstić <ike@apple.com>
Reviewed by Mark Rowe.
Remove unused experimental proxied panel interface.
<rdar://problem/7237059>
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface):
2010-10-28 Ivan Krstić <ike@apple.com>
Reviewed by Mark Rowe.
Remove unused experimental proxied panel interface.
<rdar://problem/7237059>
- WebKitSystemInterface.h:
- 12:11 AM Changeset in webkit [70750] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-28 Xan Lopez <xlopez@igalia.com>
Try to fix Snow Leopard build.
- jit/JITPropertyAccess.cpp: (JSC::JIT::testPrototype):
- 12:00 AM Changeset in webkit [70749] by
-
- 13 edits in trunk/JavaScriptCore
2010-10-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Oliver Hunt.
Do not have two different asCell APIs in JSValue
https://bugs.webkit.org/show_bug.cgi?id=47979
Remove JSCell* asCell(JSValue) in favor of only using
JSValue::asCell().
- API/APICast.h: (toRef):
- jit/JITPropertyAccess32_64.cpp: (JSC::JIT::testPrototype):
- jit/JITStubs.cpp: (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
- runtime/GetterSetter.h: (JSC::asGetterSetter):
- runtime/JSByteArray.h: (JSC::asByteArray):
- runtime/JSCell.h: (JSC::JSCell::getCallData): (JSC::JSCell::getConstructData):
- runtime/JSString.h: (JSC::RopeBuilder::appendValueInConstructAndIncrementLength): (JSC::asString):
- runtime/JSValue.h:
- runtime/Operations.cpp: (JSC::jsIsObjectType):
- runtime/Operations.h: (JSC::normalizePrototypeChain):
- runtime/Protect.h: (JSC::gcProtect): (JSC::gcUnprotect):
Oct 27, 2010:
- 11:15 PM Changeset in webkit [70748] by
-
- 5 edits2 adds in trunk
2010-10-27 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
r66156 broke AtlasCT library, formerly affected http://map.d.co.il/
https://bugs.webkit.org/show_bug.cgi?id=45679
This patch removes WebKit's map of classid values to MIME types. It also
changes the behavior of object elements to render fallback content when
a non-empty classid attribute is specified, which is the behavior HTML5
specifies when a UA encounters a classid it doesn't understand.
Test: fast/replaced/object-with-non-empty-classid-triggers-fallback.html
- html/HTMLObjectElement.cpp: Remove serviceTypeForClassId(), createClassIdToTypeMap(), and the ClassIdToTypeMap typedef. (WebCore::HTMLObjectElement::updateWidget): Do not call serviceTypeForClassId() when there is no type attribute, and render fallback content if the classid attribute is non-empty.
2010-10-27 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
r66156 broke AtlasCT library, formerly affected http://map.d.co.il/
https://bugs.webkit.org/show_bug.cgi?id=45679
- fast/dom/object-embed-plugin-scripting.html: Changed classid attributes to type attributes.
- fast/dom/object-plugin-hides-properties.html: Ditto.
- fast/replaced/object-with-non-empty-classid-triggers-fallback-expected.txt: Added.
- fast/replaced/object-with-non-empty-classid-triggers-fallback.html: Added.
- 10:12 PM Changeset in webkit [70747] by
-
- 2 edits2 adds in trunk/WebKitTools
2010-10-27 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkit-patch suggest-reviewers -g 260550a6e30b7bf34f16bdb4a5396cf26264fc1c is very slow
https://bugs.webkit.org/show_bug.cgi?id=48500
This doesn't fix the problem, but it makes things slightly better.
Each git svn find-rev call takes about .25 seconds on my desktop.
This patch uses a new memoized class to avoid those calls when possible.
The real slowness is still git log on some files, like:
git log --pretty=format:%H -5 -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h
I'm not yet sure how to make the pathological git logs better.
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/common/memoized.py: Added.
- Scripts/webkitpy/common/memoized_unittest.py: Added.
- 9:00 PM Changeset in webkit [70746] by
-
- 2 edits in trunk/LayoutTests
2010-10-27 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed, updating drt_expectations.txt.
- platform/chromium/drt_expectations.txt:
- 8:57 PM Changeset in webkit [70745] by
-
- 12 edits1 copy in trunk
2010-10-27 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
[Chromium] Metadata queries should return full file info, not just modification time
https://bugs.webkit.org/show_bug.cgi?id=48098
LayoutTests that use this functionality via WorkerAsyncFileWriter are in review.
Build file changes to add FileMetadata.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
The rest of the changes here just pass the new FileMetadata object through calls that used to take a modification time.
- platform/FileMetadata.h: Added. (WebCore::FileMetadata::FileMetadata):
- fileapi/FileSystemCallbacks.cpp: (WebCore::FileSystemCallbacksBase::didReadMetadata): (WebCore::MetadataCallbacks::didReadMetadata):
- fileapi/FileSystemCallbacks.h:
- platform/AsyncFileSystemCallbacks.h:
2010-10-27 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
[Chromium] Metadata queries should return full file info, not just modification time
https://bugs.webkit.org/show_bug.cgi?id=48098
- src/AssertMatchingEnums.cpp: Ensure WebFileInfo and FileMetadata use the same values for file/directory indicators.
- src/WebFileSystemCallbacksImpl.cpp: (WebKit::WebFileSystemCallbacksImpl::didReadMetadata): Pass through the new information.
- 8:48 PM Changeset in webkit [70744] by
-
- 2 edits in trunk/LayoutTests
2010-10-27 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed, update drt_expectations.txt.
- platform/chromium/drt_expectations.txt:
- 8:38 PM Changeset in webkit [70743] by
-
- 1 edit2 adds in trunk/WebCore
2010-10-27 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add VectorMath files
https://bugs.webkit.org/show_bug.cgi?id=48467
No new tests since audio API is not yet implemented.
- platform/audio/VectorMath.cpp: Added. (WebCore::VectorMath::vsmul): (WebCore::VectorMath::vadd):
- platform/audio/VectorMath.h: Added.
- 8:21 PM Changeset in webkit [70742] by
-
- 15 edits in trunk/WebCore
2010-10-27 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Fixup files affected by VectorMath and related API changes
https://bugs.webkit.org/show_bug.cgi?id=48481
No new tests since audio API is not yet implemented.
- platform/audio/AudioBus.cpp:
- platform/audio/AudioChannel.cpp:
- platform/audio/Biquad.cpp:
- platform/audio/FFTConvolver.cpp:
- platform/audio/FFTConvolver.h:
- platform/audio/Panner.cpp: (WebCore::Panner::create):
- platform/audio/Reverb.cpp: (WebCore::calculateNormalizationScale): (WebCore::Reverb::initialize): (WebCore::Reverb::process):
- platform/audio/ReverbAccumulationBuffer.cpp:
- platform/audio/ReverbAccumulationBuffer.h:
- platform/audio/ReverbConvolver.cpp: (WebCore::ReverbConvolver::ReverbConvolver): (WebCore::ReverbConvolver::process):
- platform/audio/ReverbConvolver.h:
- platform/audio/ReverbConvolverStage.cpp: (WebCore::ReverbConvolverStage::ReverbConvolverStage):
- platform/audio/ReverbConvolverStage.h:
- platform/audio/ReverbInputBuffer.h:
- 8:18 PM Changeset in webkit [70741] by
-
- 24 edits3 adds in trunk
2010-10-27 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dumitru Daniliuc.
DOMFileSystem's reference should be kept while there're any active Entries/callbacks
https://bugs.webkit.org/show_bug.cgi?id=47535
Changed to keep DOMFileSystem's reference in each EntryBase, DirectoryReaderBase, EntryCallbacks and EntriesCallbacks.
Test: fast/filesystem/filesystem-reference.html
- fileapi/DOMFileSystemBase.cpp: (WebCore::DOMFileSystemBase::readDirectory): Changed to pass/take PassRefPtr but not a raw pointer.
- fileapi/DOMFileSystemBase.h:
- fileapi/DirectoryEntry.cpp: (WebCore::DirectoryEntry::DirectoryEntry): Ditto. (WebCore::DirectoryEntry::createReader):
- fileapi/DirectoryEntry.h: (WebCore::DirectoryEntry::create): Ditto.
- fileapi/DirectoryEntrySync.cpp: (WebCore::DirectoryEntrySync::DirectoryEntrySync): Ditto.
- fileapi/DirectoryEntrySync.h: (WebCore::DirectoryEntrySync::create): Ditto.
- fileapi/DirectoryReader.h: (WebCore::DirectoryReader::filesystem):
- fileapi/DirectoryReaderBase.h: (WebCore::DirectoryReaderBase::filesystem):
- fileapi/Entry.cpp: (WebCore::Entry::Entry): Ditto.
- fileapi/Entry.h: (WebCore::Entry::filesystem):
- fileapi/EntryBase.h: (WebCore::EntryBase::filesystem): (WebCore::EntryBase::EntryBase): Ditto.
- fileapi/EntrySync.cpp: (WebCore::EntrySync::create): Ditto. (WebCore::EntrySync::getParent): (WebCore::EntrySync::EntrySync): Ditto.
- fileapi/EntrySync.h: (WebCore::EntrySync::filesystem):
- fileapi/FileEntry.cpp: (WebCore::FileEntry::FileEntry): Ditto.
- fileapi/FileEntry.h: (WebCore::FileEntry::create): Ditto.
- fileapi/FileEntrySync.cpp: (WebCore::FileEntrySync::FileEntrySync): Ditto.
- fileapi/FileEntrySync.h: (WebCore::FileEntrySync::create): Ditto.
- fileapi/FileSystemCallbacks.cpp: (WebCore::EntriesCallbacks::create): Ditto. (WebCore::EntriesCallbacks::EntriesCallbacks): Ditto.
- fileapi/FileSystemCallbacks.h:
2010-10-27 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Dumitru Daniliuc.
DOMFileSystem's reference should be kept while there're any active Entries/callbacks
https://bugs.webkit.org/show_bug.cgi?id=47535
- fast/filesystem/filesystem-reference-expected.txt: Added.
- fast/filesystem/filesystem-reference.html: Added.
- fast/filesystem/script-tests/filesystem-reference.js: Added.
- 8:11 PM Changeset in webkit [70740] by
-
- 4 edits2 adds in trunk
2010-10-27 Yuzo Fujishima <yuzo@google.com>
Reviewed by Eric Seidel.
Fix for Bug 48310 - SVG font-face-name without name attribute causes a crash
https://bugs.webkit.org/show_bug.cgi?id=48310
- svg/custom/font-face-name-without-name-attr-expected.txt: Added.
- svg/custom/font-face-name-without-name-attr.svg: Added.
2010-10-27 Yuzo Fujishima <yuzo@google.com>
Reviewed by Eric Seidel.
Fix for Bug 48310 - SVG font-face-name without name attribute causes a crash
https://bugs.webkit.org/show_bug.cgi?id=48310
Test: svg/custom/font-face-name-without-name-attr.svg
- svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::rebuildFontFace): Don't create src property if the src value list is empty.
- svg/SVGFontFaceSrcElement.cpp: (WebCore::SVGFontFaceSrcElement::srcValue): Don't add empty src values to the src value list.
- 8:02 PM Changeset in webkit [70739] by
-
- 2 edits in trunk/WebCore
2010-10-27 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Allow AudioDSPKernel to function without an AudioDSPKernelProcessor
https://bugs.webkit.org/show_bug.cgi?id=48472
No new tests since audio API is not yet implemented.
- platform/audio/AudioDSPKernel.h: (WebCore::AudioDSPKernel::AudioDSPKernel): (WebCore::AudioDSPKernel::sampleRate):
- 7:37 PM Changeset in webkit [70738] by
-
- 2 edits in trunk/WebKit2
Build fix.
- UIProcess/API/mac/PageClientImpl.mm: Reference the file using the correct case.
- 6:44 PM Changeset in webkit [70737] by
-
- 7 edits in trunk
Find indicators do not bounce
https://bugs.webkit.org/show_bug.cgi?id=48490
<rdar://problem/8564276>
Reviewed by Sam Weinig.
WebKit2:
- UIProcess/API/mac/FindIndicatorWindow.h:
- UIProcess/API/mac/FindIndicatorWindow.mm:
(-[WebFindIndicatorWindowAnimation _initWithFindIndicatorWindow:WebKit::animationDuration:animationProgressCallback:WebKit::FindIndicatorWindow::animationDidEndCallback:WebKit::FindIndicatorWindow::]):
Add an animationDuration parameter.
(WebKit::FindIndicatorWindow::FindIndicatorWindow):
Initialize m_bounceAnimationContext.
(WebKit::FindIndicatorWindow::setFindIndicator):
Create a bounce animation and start it.
(WebKit::FindIndicatorWindow::closeWindow):
Stop the bounce animation and destroy the bounce animation context.
(WebKit::FindIndicatorWindow::startFadeOutTimerFired):
pass the fade out duration.
(WebKit::FindIndicatorWindow::bounceAnimationCallback):
Set the bounce animation progress.
(WebKit::FindIndicatorWindow::bounceAnimationDidEnd):
Destroy the bounce animation context.
WebKitLibraries:
Add bounce animation context functions.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 6:30 PM Changeset in webkit [70736] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-27 Chao-ying Fu <fu@mips.com>
Reviewed by Oliver Hunt.
Support emit_op_mod() for MIPS on JSVALUE32_64
https://bugs.webkit.org/show_bug.cgi?id=46511
This patch uses MIPS div instructions for op_mod to improve performance.
- jit/JITArithmetic32_64.cpp: (JSC::JIT::emit_op_mod):
- 6:07 PM Changeset in webkit [70735] by
-
- 2 edits3 adds in trunk/LayoutTests
2010-10-27 Stephen White <senorblanco@chromium.org>
Reviewed by Kenneth Russell.
[CHROMIUM] Unskip the failing tests in chromium-gpu, and adjust the
expectations to match reality.
https://bugs.webkit.org/show_bug.cgi?id=48473
Some bugs were already fixed and the test lines could be removed, some
tests have started newly-failing. Rebaselined one test that had a bad
checksum.
- platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.png: Added.
- platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.txt: Added.
- platform/chromium-gpu/test_expectations.txt:
- 5:55 PM Changeset in webkit [70734] by
-
- 3 edits in trunk/WebKit2
2010-10-27 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Andreas Kling.
Remove the reference to the pageNamespace in the QWKPagePrivate.
Access it though the WebPageProxy instead which holds a strong
ref to it.
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPage::preferences):
- UIProcess/API/qt/qwkpage_p.h:
- 5:48 PM Changeset in webkit [70733] by
-
- 8 edits in trunk/WebKit2
More work on downloads
https://bugs.webkit.org/show_bug.cgi?id=48480
Reviewed by Sam Weinig.
- WebProcess/Downloads/Download.cpp:
(WebKit::Download::~Download):
Call platformInvalidate().
(WebKit::Download::didBegin):
(WebKit::Download::didReceiveData):
(WebKit::Download::didFinish):
Add empty stubs.
- WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload):
Create a Download object and insert it into the m_downloads map.
- WebProcess/Downloads/cf/DownloadCFNet.cpp:
(WebKit::Download::platformInvalidate):
Add empty stub.
- WebProcess/Downloads/mac/DownloadMac.mm:
(WebKit::Download::platformInvalidate):
Tell the WKDownloadAsDelegate object that we're being invalidated.
(-[WKDownloadAsDelegate downloadDidBegin:]):
Call Download::didBegin.
(-[WKDownloadAsDelegate download:didReceiveDataOfLength:]):
Call Download::didReceiveData.
(-[WKDownloadAsDelegate downloadDidFinish:]):
Call Download::didFinish.
- WebProcess/Downloads/qt/DownloadQt.cpp:
(WebKit::Download::platformInvalidate):
Add empty stub.
- 5:42 PM Changeset in webkit [70732] by
-
- 2 edits in trunk/WebKit/mac
2010-10-27 Pratik Solanki <psolanki@apple.com>
Reviewed by Darin Adler.
Improve memSize calculation in [WebView _setCacheModel]
https://bugs.webkit.org/show_bug.cgi?id=48484
- WebView/WebView.mm: (roundUpToPowerOf2): Added. Utility function to calculate the nearest power of 2. (+[WebView _setCacheModel:]): Update memSize calculation to set it to the next bigger power of 2. Also update WebCore cache settings.
- 5:05 PM Changeset in webkit [70731] by
-
- 5 edits in trunk/WebKitTools
2010-10-27 Eric Seidel <eric@webkit.org>
Reviewed by Ojan Vafai.
EWS bots should not use --quiet when running build-webkit
https://bugs.webkit.org/show_bug.cgi?id=48482
--quiet is only correct when the sub-process does the error reporting.
In the case of _can_build() the parent process is reporting the error.
We'd like the full build log at queues.webkit.org so someone can look
at the log and understand why the EWS is failing to build trunk.
- Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- 5:04 PM Changeset in webkit [70730] by
-
- 18 edits in trunk
WebCore: Support Appkit key bindings and custom key bindings in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48271
<rdar://problem/7660723>
Reviewed by Alexey Proskuryakov.
- dom/KeyboardEvent.h:
(WebCore::KeypressCommand::KeypressCommand): Added default constructor and modified assert for text
insertion command constructor to support WebKit2 scenarios.
The default constructor is needed to support the generated WebKit2 message processing code.
WebKit2: Support Appkit key bindings and custom key bindings in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48271
<rdar://problem/7660723>
Reviewed by Alexey Proskuryakov.
We need to support AppKit key bindings and custom key bindings in WebKit2.
Every keyboard event is first sent to the WebProcess and we inform AppKit that
we don't need further processing. When the event is processed by the WebProcess and no handler consumes it,
we send a synchronous message back to the UI process to let AppKit perform the key bindings.
This operation can result in one or more editing commands to execute or a noop.
The WebProcess then replies back to the UI process to inform whether further processing is required, in
which case the event is sent back to the application to be mapped.
There is a potential for a race condition: in case the WebProcess is very slow to process the key events, the UI
process could be in a completely different state when the event is being resent (for example it might not have the
keyboard focus anymore) and the command could be lost. We should look out for user experience impact.
- Scripts/webkit2/messages.py: Added header file in the generated file.
- Shared/WebCoreArgumentCoders.h: Added encoder/decoder for KeypressCommand.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::interceptKeyEvent): Pass-through call to WKView.
(WebKit::PageClientImpl::didNotHandleKeyEvent): Added logic to resend the event to the application.
- UIProcess/API/mac/WKView.mm:
(-[WKView validateUserInterfaceItem:]): Changed the default return value to YES, otherwise no menu shortcut is performed.
(-[WKView doCommandBySelector:]): Added.
(-[WKView insertText:]): Added.
(-[WKView _handleStyleKeyEquivalent:]): Added to handle command-B and command-I.
(-[WKView performKeyEquivalent:]): Added to intercept key binding sequences.
(-[WKView _setEventBeingResent:]):
(-[WKView _interceptKeyEvent:]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::interpretKeyEvent):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::WebEditorClient::handleKeyboardEvent):
(WebKit::WebEditorClient::handleInputMethodKeydown):
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/WebPageMac.mm: Moved handleKeyboardEvent and handleInputMethodKeydown
to the Mac specific implementation.
(WebKit::WebPage::interceptEditingKeyboardEvent): Added.
- 4:56 PM Changeset in webkit [70729] by
-
- 1 edit2 copies in branches/chromium/552
Merge 70652 - 2010-10-27 Justin Schuh <jschuh@chromium.org>
Reviewed by Dirk Schulze.
Ignore invalid blend modes
https://bugs.webkit.org/show_bug.cgi?id=48371
Test: svg/filters/feBlend-invalid-mode.xhtml
- platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):
2010-10-27 Justin Schuh <jschuh@chromium.org>
Reviewed by Dirk Schulze.
Ignore invalid blend modes
https://bugs.webkit.org/show_bug.cgi?id=48371
- svg/filters/feBlend-invalid-mode-expected.txt: Added.
- svg/filters/feBlend-invalid-mode.xhtml: Added.
BUG=60688
TBR=jschuh@chromium.org
- 4:53 PM Changeset in webkit [70728] by
-
- 4 edits in trunk
WebKit2: More Windows build fixage. Copy another new header into WebKitOutputDir.
- win/WebKit2Generated.make:
WebKitTools: More Windows build fixage. Rename a variable that was named string.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::hasPrefix):
- 4:52 PM Changeset in webkit [70727] by
-
- 1 edit2 copies in branches/chromium/517
Merge 70652 - 2010-10-27 Justin Schuh <jschuh@chromium.org>
Reviewed by Dirk Schulze.
Ignore invalid blend modes
https://bugs.webkit.org/show_bug.cgi?id=48371
Test: svg/filters/feBlend-invalid-mode.xhtml
- platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):
2010-10-27 Justin Schuh <jschuh@chromium.org>
Reviewed by Dirk Schulze.
Ignore invalid blend modes
https://bugs.webkit.org/show_bug.cgi?id=48371
- svg/filters/feBlend-invalid-mode-expected.txt: Added.
- svg/filters/feBlend-invalid-mode.xhtml: Added.
BUG=60688
TBR=jschuh@chromium.org
Review URL: http://codereview.chromium.org/4133004
- 4:40 PM Changeset in webkit [70726] by
-
- 2 edits in trunk/JavaScriptCore
Unreviewed build correction.
- wtf/Platform.h: Make sure ACCELERATED_COMPOSITING is
turned off in the WinCairo port. This isn't supported (yet.)
- 4:39 PM Changeset in webkit [70725] by
-
- 2 edits in trunk/WebKit2
Windows build fix. Copy a new header into WebKitOutputDir.
- win/WebKit2Generated.make:
- 4:33 PM Changeset in webkit [70724] by
-
- 7 edits in trunk/WebKitTools
2010-10-27 Ojan Vafai <ojan@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Make the test results server store which master the bot is on
https://bugs.webkit.org/show_bug.cgi?id=48478
The chromium bots recently changed so that there are multiple slaves with
the same name on different masters. Up till now, the test results server
assumed slave names were unique. Adds a master field to the file in order
to distinguish.
Also, for files that currently lack a master or testtype, set them appropriately.
- TestResultServer/handlers/testfilehandler.py:
- TestResultServer/index.yaml:
- TestResultServer/model/jsonresults.py:
- TestResultServer/model/testfile.py:
- TestResultServer/templates/showfilelist.html:
- TestResultServer/templates/uploadform.html:
- 4:18 PM Changeset in webkit [70723] by
-
- 61 edits8 copies in trunk
2010-10-26 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=42322
rdar://problem/8193631
WebKitTestRunner needs to support layoutTestController.clearBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=42333
rdar://problem/8193643
- History/WebBackForwardList.mm: (core): Return BackForwardListImpl. (kit): Take BackForwardListImpl. (-[WebBackForwardList initWithBackForwardList:]): Use BackForwardListImpl. (-[WebBackForwardList dealloc]): Ditto. (-[WebBackForwardList finalize]): Ditto. (-[WebBackForwardList description]): Ditto. (-[WebBackForwardList setPageCacheSize:]): Ditto. (-[WebBackForwardList pageCacheSize]): Ditto.
- History/WebBackForwardListInternal.h: Ditto.
- WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Ditto.
- WebView/WebView.mm: (-[WebView initWithCoder:]): Ditto. (-[WebView encodeWithCoder:]): Ditto. (-[WebView backForwardList]): Ditto. (-[WebView setMaintainsBackForwardList:]): Ditto.
2010-10-26 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=42322
rdar://problem/8193631
WebKitTestRunner needs to support layoutTestController.clearBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=42333
rdar://problem/8193643
- WebCore.exp.in: Updated exports.
- history/BackForwardList.h: Added comments about future refactoring. Moved functions that are not called inside WebCore into a separate section, to be removed later. Added an isActive function to replace the use of enabled() and entries().
- history/BackForwardListImpl.h: Removed isBackForwardListImpl. Marked virtual function overrides virtual explicitly, except for the ones that will be non-virtual once we make the changes above. Added the isActive function.
- history/PageCache.cpp: (WebCore::logCanCachePageDecision): Use isActive. (WebCore::PageCache::canCache): Ditto.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::checkDidPerformFirstNavigation): Check using currentItem, backItem, and forwardItem instead of using entries.
- page/Settings.cpp: (WebCore::Settings::setUsesPageCache): Loop through the back/forward list entries using backListCount and forwardListCount instead of using entries.
2010-10-26 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=42322
rdar://problem/8193631
WebKitTestRunner needs to support layoutTestController.clearBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=42333
rdar://problem/8193643
- platform/mac-wk2/Skipped: Resorted some test lists. Removed the section listing all the tests that were blocked by dumpBackForwardList.
2010-10-26 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=42322
rdar://problem/8193631
WebKitTestRunner needs to support layoutTestController.clearBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=42333
rdar://problem/8193643
- WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Renamed the product to WebKitTestRunnerInjectedBundle to avoid name conflicts in the build directory.
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpBackForwardList and clearBackForwardList.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::InjectedBundle): Removed initialization of m_mainPage. (WTR::InjectedBundle::didCreatePage): Removed unneeded underscore. (WTR::InjectedBundle::willDestroyPage): Ditto. (WTR::InjectedBundle::didReceiveMessage): Ditto. (WTR::InjectedBundle::initialize): Ditto. (WTR::InjectedBundle::didCreatePage): Changed code to use m_pages instead of m_mainPage and m_otherPages. (WTR::InjectedBundle::willDestroyPage): Ditto. (WTR::InjectedBundle::page): Ditto. (WTR::InjectedBundle::beginTesting): Ditto. (WTR::InjectedBundle::done): Ditto. (WTR::InjectedBundle::closeOtherPages): Ditto. (WTR::InjectedBundle::dumpBackForwardListsForAllPages): Added.
- WebKitTestRunner/InjectedBundle/InjectedBundle.h: Changed page function to longer be inline, and pageCount function to use m_pages. Added dumpBackForwardListsForAllPages, and removed some underscores. Replaced m_mainPage and m_otherPageas with m_pages.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::adoptWK): Added. (WTR::hasPrefix): Added. (WTR::InjectedBundlePage::reset): Added code to set up m_previousTestBackForwardListItem. (WTR::InjectedBundlePage::dump): Added code to call dumpBackForwardListsForAllPages. (WTR::compareByTargetName): Added. (WTR::dumpBackForwardListItem): Added. (WTR::InjectedBundlePage::dumpBackForwardList): Added.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added dumpBackForwardList and m_previousTestBackForwardListItem.
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController): Initialize m_shouldDumpBackForwardListsForAllWindows to false. (WTR::LayoutTestController::clearBackForwardList): Added.
- WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added dumpBackForwardList, clearBackForwardList, shouldDumpBackForwardListsForAllWindows, and m_shouldDumpBackForwardListsForAllWindows.
- WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set up didReceiveSynchronousMessageFromInjectedBundle. (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Added.
- WebKitTestRunner/TestController.h: Ditto.
- WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Added.
- WebKitTestRunner/TestInvocation.h: Ditto.
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Renamed bundle to WebKitTestRunnerInjectedBundle (see above).
- WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::initializeInjectedBundlePath): Ditto.
2010-10-26 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=42322
rdar://problem/8193631
WebKitTestRunner needs to support layoutTestController.clearBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=42333
rdar://problem/8193643
- Shared/API/c/WKBase.h: Added WKBundleBackForwardListRef and WKBundleBackForwardListItemRef.
- Shared/API/c/WKURL.cpp: (WKURLCopyString): Added.
- Shared/API/c/WKURL.h: Added WKURLCopyString.
- Shared/API/c/cf/WKURLCF.h: Fixed incorrect argument name.
- Shared/APIObject.h: Added TypeBundleBackForwardList and TypeBundleBackForwardListItem.
- Shared/ImmutableArray.h: Marked destructor virtual explicitly.
- Shared/ImmutableDictionary.h: Ditto.
- UIProcess/WebBackForwardListItem.h: Ditto.
- UIProcess/WebContext.h: Ditto.
- UIProcess/WebFrameProxy.h: Ditto.
- UIProcess/WebNavigationData.h: Ditto.
- UIProcess/WebPageNamespace.h: Ditto.
- UIProcess/WebPreferences.h: Ditto.
- WebProcess/InjectedBundle/InjectedBundleScriptWorld.h: Ditto.
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h: Ditto.
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h: Ditto.
- UIProcess/WebBackForwardList.cpp: Removed unneeded backListWithLimit and forwardListWithLimit functions. (WebKit::WebBackForwardList::clear): Added.
- UIProcess/WebBackForwardList.h: Marked destructor virtual explicitly. Added clear, removed backListWithLimit and forwardListWithLimit functions.
- UIProcess/WebPageProxy.cpp: Removed unneeded backForwardBackItem, backForwardCurrentItem, and backForwardForwardItem functions. (WebKit::WebPageProxy::backForwardClear): Added.
- UIProcess/WebPageProxy.h: Ditto.
- UIProcess/WebPageProxy.messages.in: Ditto.
- WebKit2.pro: Added new files.
- WebKit2.xcodeproj/project.pbxproj: Ditto.
- win/WebKit2.vcproj: Ditto.
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h: Added WKBundleBackForwardListRef and WKBundleBackForwardListItemRef.
- WebProcess/InjectedBundle/API/c/WKBundleBackForwardList.cpp: Started with a copy of from WebKit2/UIProcess/API/C/WKBackForwardList.cpp.
- WebProcess/InjectedBundle/API/c/WKBundleBackForwardList.h: Started with a copy of WebKit2/UIProcess/API/C/WKBackForwardList.h.
- WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp: Started with a copy of WebKit2/UIProcess/API/C/WKBackForwardListItem.cpp.
- WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.h: Started with a copy of WebKit2/UIProcess/API/C/WKBackForwardListItem.h.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageGetBackForwardList): Added.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h: Ditto.
- WebProcess/InjectedBundle/InjectedBundleBackForwardList.cpp: Started with a copy of WebKit2/UIProcess/WebBackForwardList.cpp.
- WebProcess/InjectedBundle/InjectedBundleBackForwardList.h: Started with a copy of WebKit2/UIProcess/WebBackForwardList.h.
- WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp: Started with a copy of WebKit2/UIProcess/WebBackForwardListItem.cpp.
- WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h: Started with a copy of WebKit2/UIProcess/WebBackForwardListItem.h.
- WebProcess/WebPage/WebBackForwardListProxy.cpp: Removed many unneeded functions. (WebKit::WebBackForwardListProxy::WebBackForwardListProxy): Removed unneeded initialization of m_closed. (WebKit::WebBackForwardListProxy::addItem): Added a check for the case of a capacity of 0. (WebKit::WebBackForwardListProxy::goToItem): Added a check for when the proxy outlives its page. (WebKit::WebBackForwardListProxy::itemAtIndex): Ditto. (WebKit::WebBackForwardListProxy::backListCount): Ditto. (WebKit::WebBackForwardListProxy::forwardListCount): Ditto. (WebKit::WebBackForwardListProxy::close): Removed unneeded code setting m_closed. (WebKit::WebBackForwardListProxy::isActive): Added. (WebKit::WebBackForwardListProxy::clear): Added.
- WebProcess/WebPage/WebBackForwardListProxy.h: Added clear, isActive, and detach functions. Removed many other unneeded function and data members.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::~WebPage): Added call to detach on the back/forward list. (WebKit::WebPage::backForwardList): Added.
- WebProcess/WebPage/WebPage.h: Added backForwardList function and m_backForwardList data member.
- 3:44 PM Changeset in webkit [70722] by
-
- 9 edits in trunk
2010-10-27 Chris Rogers <crogers@google.com>
Reviewed by Chris Marrin.
Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
https://bugs.webkit.org/show_bug.cgi?id=48279
- Configurations/FeatureDefines.xcconfig:
2010-10-27 Chris Rogers <crogers@google.com>
Reviewed by Chris Marrin.
Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
https://bugs.webkit.org/show_bug.cgi?id=48279
No new tests since flag is disabled.
- Configurations/FeatureDefines.xcconfig:
2010-10-27 Chris Rogers <crogers@google.com>
Reviewed by Chris Marrin.
Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
https://bugs.webkit.org/show_bug.cgi?id=48279
- Configurations/FeatureDefines.xcconfig:
2010-10-27 Chris Rogers <crogers@google.com>
Reviewed by Chris Marrin.
Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
https://bugs.webkit.org/show_bug.cgi?id=48279
- Scripts/build-webkit:
- 3:38 PM Changeset in webkit [70721] by
-
- 8 edits in trunk/LayoutTests
2010-10-27 Martin Robinson <mrobinson@igalia.com>
Rebaseline some GTK+ tests after r70688.
- platform/gtk/fast/css/font-face-opentype-expected.txt:
- platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
- platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
- platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
- platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt:
- platform/gtk/fast/text/backslash-to-yen-sign-expected.txt:
- platform/gtk/fast/text/international/plane2-expected.txt:
- 3:37 PM Changeset in webkit [70720] by
-
- 3 edits in trunk/WebKitTools
2010-10-27 Eric Seidel <eric@webkit.org>
Unreviewed.
build-webkit should collect Visual Studio Express logs and display them
https://bugs.webkit.org/show_bug.cgi?id=39199
It turns out my previous patch wasn't actually working on the win-ews
machine. So I've fixed my mistakes from before.
- Scripts/build-webkit:
- Windows VSE builds change the CWD while building. Why? Who knows.
- Scripts/print-vse-failure-logs:
- windows VSE builds don't use Debug/Release as I expected, so I've moved off of --configuration to --top-level and added the /obj optimization while I was there.
- 3:28 PM Changeset in webkit [70719] by
-
- 1 edit2 adds in trunk/WebCore
2010-10-27 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add AudioResamplerKernel files
https://bugs.webkit.org/show_bug.cgi?id=47624
No new tests since audio API is not yet implemented.
- platform/audio/AudioResamplerKernel.cpp: Added. (WebCore::AudioResamplerKernel::AudioResamplerKernel): (WebCore::AudioResamplerKernel::getSourcePointer): (WebCore::AudioResamplerKernel::process): (WebCore::AudioResamplerKernel::reset): (WebCore::AudioResamplerKernel::rate):
- platform/audio/AudioResamplerKernel.h: Added.
- 2:57 PM Changeset in webkit [70718] by
-
- 3 edits2 adds in trunk
2010-10-27 Adam Barth <abarth@webkit.org>
Reviewed by Ojan Vafai.
REGRESSION(66511): CORDYS Process Factory doesn't work
https://bugs.webkit.org/show_bug.cgi?id=48453
Test some appendChild cases that didn't have coverage before.
- fast/dom/allowed-children-expected.txt: Added.
- fast/dom/allowed-children.html: Added.
2010-10-27 Adam Barth <abarth@webkit.org>
Reviewed by Ojan Vafai.
REGRESSION(66511): CORDYS Process Factory doesn't work
https://bugs.webkit.org/show_bug.cgi?id=48453
When Ojan refactored this function in 66511, he missed an "else",
which causes us to generated HIERARCHY_REQUEST_ERR in some cases where
we're not supposed to. This patch restores the "else" behavior (using
an early return) and adds a test for the cases that caused problems in
the field.
Test: fast/dom/allowed-children.html
- dom/Node.cpp: (WebCore::isChildTypeAllowed):
- 2:53 PM Changeset in webkit [70717] by
-
- 2 edits in trunk/WebKit/chromium
2010-10-27 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
[chromium] WebGL does not work with the compositor in test_shell
https://bugs.webkit.org/show_bug.cgi?id=48470
- src/WebGraphicsContext3DDefaultImpl.cpp:
(WebKit::WebGraphicsContext3DDefaultImpl::resolveMultisampledFramebuffer):
- Properly restore the draw framebuffer after resolving.
(WebKit::WebGraphicsContext3DDefaultImpl::prepareTexture):
- Make the context current before calling resolveMultisampledFramebuffer.
- 2:46 PM Changeset in webkit [70716] by
-
- 19 edits in trunk
Fix for https://bugs.webkit.org/show_bug.cgi?id=48385 Add WebKit
SPI to scale a WebView
-and corresponding-
<rdar://problem/8107667>
Reviewed by Darin Adler.
WebCore:
This patch adds SPI to Mac WebKit that scales the page by the given
scale factor. The scale factor is factored into the RenderStyle's
transform.
Set the current pageScale for the document.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForDocument):
Frame keeps track of the page scale factor. When
scalePage() is called, it modifies the RenderView's style to
include a transform of the appropriate scale and forces a style
recalc.
- page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore::Frame::scalePage):
- page/Frame.h:
(WebCore::Frame::pageScaleFactor):
- WebCore.exp.in:
Add a scale to the transformation matrix.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setPageScaleTransform):
- rendering/style/RenderStyle.h:
WebKit/mac:
This patch adds SPI to Mac WebKit that scales the page by the given
scale factor.
- WebView/WebView.mm:
(-[WebView _scaleWebView:]):
(-[WebView _viewScaleFactor]):
- WebView/WebViewPrivate.h:
WebKit2:
This patch adds SPI to Mac WebKit that scales the page by the given
scale factor.
Implement scaleWebView(), which tells WebCore::Frame to scale, and
viewScaleFactor() which returns the current scale factor.
- Shared/API/c/WKSharedAPICast.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageScaleWebView):
(WKPageGetViewScaleFactor):
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::scaleWebView):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::viewScaleFactor):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::scaleWebView):
(WebKit::WebPage::viewScaleFactor):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 2:45 PM Changeset in webkit [70715] by
-
- 1 edit3 adds in trunk/LayoutTests
Add Windows-specific results for test added in r70692
This test isn't rendering correctly. That's covered by
<http://webkit.org/b/48459>.
- platform/win/fast/blockflow/border-vertical-lr-expected.checksum: Added.
- platform/win/fast/blockflow/border-vertical-lr-expected.png: Added.
- platform/win/fast/blockflow/border-vertical-lr-expected.txt: Added.
- 2:38 PM Changeset in webkit [70714] by
-
- 7 edits in trunk
REGRESSION (r70335): Incorrect article layout in Safari Reader
https://bugs.webkit.org/show_bug.cgi?id=48436
Reviewed by Darin Adler.
WebCore:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::getMatchedCSSRules): Return rules from all origins if the cross-origin
check is disabled.
- page/Settings.cpp:
(WebCore::Settings::Settings): Initialize m_crossOriginCheckInGetMatchedCSSRulesDisabled.
- page/Settings.h:
(WebCore::Settings::setCrossOriginCheckInGetMatchedCSSRulesDisabled): Added this accessor.
(WebCore::Settings::crossOriginCheckInGetMatchedCSSRulesDisabled): Ditto.
WebKit/mac:
- Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITH_GET_MATCHED_CSS_RULES_RESTRICTIONS.
- WebView/WebView.mm:
(-[WebView _needsUnrestrictedGetMatchedCSSRules]): Added. Returns YES for Safari linked against
versions of WebKit that did not have the cross-origin restrictions in getMatchedCSSRules().
(-[WebView _preferencesChangedNotification:]): Call Settings::setCrossOriginCheckInGetMatchedCSSRulesDisabled()
based on the above.
- 2:38 PM Changeset in webkit [70713] by
-
- 2 edits in trunk/WebKit/chromium
2010-10-27 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by David Levin.
Include caps lock state when converting NSEvent modifiers to
WebInputEvent
- src/mac/WebInputEventFactory.mm: (WebKit::modifiersFromEvent):
- 2:35 PM Changeset in webkit [70712] by
-
- 2 edits in trunk/WebKit/chromium
2010-10-27 Chris Rogers <crogers@google.com>
Reviewed by James Robinson.
Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) for Chromium
https://bugs.webkit.org/show_bug.cgi?id=48465
- features.gypi:
- 2:33 PM Changeset in webkit [70711] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- jit/JITStubs.cpp:
(JSC::jitThrow):
- 2:27 PM Changeset in webkit [70710] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed. Add Qt specific expected results after r70657.
- platform/qt/animations/missing-values-first-keyframe-expected.txt: Added.
- platform/qt/animations/missing-values-last-keyframe-expected.txt: Added.
- 2:22 PM Changeset in webkit [70709] by
-
- 2 edits6 adds in trunk/LayoutTests
2010-10-27 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Add expectations after r70692.
- platform/chromium-linux/fast/borders/border-radius-inline-flow-expected.checksum: Added.
- platform/chromium-linux/fast/borders/border-radius-inline-flow-expected.png: Added.
- platform/chromium-mac/fast/borders/border-radius-inline-flow-expected.checksum: Added.
- platform/chromium-win/fast/borders/border-radius-inline-flow-expected.checksum: Added.
- platform/chromium-win/fast/borders/border-radius-inline-flow-expected.png: Added.
- platform/chromium-win/fast/borders/border-radius-inline-flow-expected.txt: Added.
- platform/chromium/test_expectations.txt: Tweaked.
- 2:21 PM Changeset in webkit [70708] by
-
- 2 edits in trunk/WebKit/mac
2010-10-18 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
Safari fullscreen media element tickles when it should not.
- WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController updatePowerAssertions]):
- 2:16 PM Changeset in webkit [70707] by
-
- 1 edit3 deletes in trunk/LayoutTests
Remove som unnecessary Windows-specific results
These should have been removed back in r70630.
- platform/win/fast/blockflow/english-lr-text-expected.checksum: Removed.
- platform/win/fast/blockflow/english-lr-text-expected.png: Removed.
- platform/win/fast/blockflow/english-lr-text-expected.txt: Removed.
- 2:10 PM UsingGitWithWebKit edited by
- Clarified that you still need Cygwin's git even if you use msysgit … (diff)
- 2:09 PM Changeset in webkit [70706] by
-
- 4 edits in trunk/WebCore
2010-10-27 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
refactor the nested large switch statements in GraphicsContext3DCG.cpp:getImageData()
https://bugs.webkit.org/show_bug.cgi?id=47027
- platform/graphics/GraphicsContext3D.cpp: (WebCore::doPacking): ASSERT false if undefined format is passed in.
- platform/graphics/GraphicsContext3D.h: Add kSourceFormatUndefined enum.
- platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::getSourceDataFormat): Decide source data format from componentsPerPixel, alpha format, bitsPerComponet, etc. (WebCore::GraphicsContext3D::getImageData): Refactor the code to use getSourceDataFormat and remove nested switches.
- 2:08 PM UsingGitWithWebKit edited by
- Remove extraneous backticks (diff)
- 2:05 PM Changeset in webkit [70705] by
-
- 14 edits in trunk/WebCore
2010-10-27 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Use WTF::StringHasher::createBlobHash where possible
https://bugs.webkit.org/show_bug.cgi?id=48228
Replace StringImpl::computeHash with StringHasher::createBlobHash.
This removes many duplicated code.
- bindings/js/JSSVGPODTypeWrapper.h: (WebCore::PODTypeWrapperCacheInfoHash::hash):
- page/SecurityOriginHash.h: (WebCore::SecurityOriginHash::hash):
- platform/cf/SchedulePair.h: (WebCore::SchedulePairHash::hash):
- platform/graphics/FontCache.cpp: (WebCore::computeHash):
- platform/graphics/chromium/FontPlatformDataChromiumWin.h: (WebCore::FontPlatformData::RefCountedHFONT::hash):
- platform/graphics/cocoa/FontPlatformData.h: (WebCore::FontPlatformData::hash):
- platform/graphics/gtk/FontPlatformDataPango.h: (WebCore::FontPlatformData::hash):
- platform/graphics/wince/FontPlatformData.cpp: (WebCore::FixedSizeFontDataKeyHash::hash):
- platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::computeHash):
- plugins/PluginPackage.cpp: (WebCore::PluginPackage::hash):
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::hash):
- svg/DeprecatedSVGAnimatedTemplate.h: (WebCore::DeprecatedSVGAnimatedTypeWrapperKeyHash::hash):
- svg/properties/SVGAnimatedPropertyDescription.h: (WebCore::SVGAnimatedPropertyDescriptionHash::hash):
- 2:04 PM UsingGitWithWebKit edited by
- Added instructions for maintaining good performance (diff)
- 2:00 PM UsingGitWithWebKit edited by
- Make some instructions msysgit-compatible (diff)
- 1:58 PM UsingGitWithWebKit edited by
- Add instructions for installing and setting up msysgit (diff)
- 1:48 PM Changeset in webkit [70704] by
-
- 2 edits2 copies in branches/chromium/552
Merge 70484 - Calling FileReader.abort during reading could cause crash
https://bugs.webkit.org/show_bug.cgi?id=48163
BUG=60979
Reviewed by David Levin.
WebCore:
Test: fast/files/file-reader-abort.html
- fileapi/FileReader.cpp:
(WebCore::delayedAbort):
(WebCore::FileReader::abort): Schedule to do the abort later to work
around the case that abort() could be called from event handler.
(WebCore::FileReader::doAbort):
(WebCore::FileReader::didFail): Do not go with normal error handling
when we are in the process of aborting.
(WebCore::FileReader::failed):
(WebCore::FileReader::readyState):
- fileapi/FileReader.h:
LayoutTests:
- fast/files/file-reader-abort-expected.txt: Added.
- fast/files/file-reader-abort.html: Added.
- 1:46 PM Changeset in webkit [70703] by
-
- 22 edits in trunk/JavaScriptCore
Bug 48365 - Remove output parameters from JITStackFrame
Reviewed by Oliver Hunt.
The JIT stub functions presently use the stackframe to provide a couple of additional return values.
- In the case of uncaught exceptions the exception value is returned on the stackframe.exception property.
- In the case of caught exceptions the updated value for the callFrame register is returned on the stackframe.callFrame property.
Change exception returns such that exceptions are always returned on JSGlobalData::exception.
Change op_catch such that the new CallFrame value is returned from op_throw / vm_throw in regT0.
- JavaScriptCore.xcodeproj/project.pbxproj:
- debugger/Debugger.cpp:
(JSC::evaluateInGlobalCallFrame):
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluate):
- interpreter/CachedCall.h:
(JSC::CachedCall::CachedCall):
(JSC::CachedCall::call):
- interpreter/CallFrame.h:
(JSC::ExecState::exception):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::privateExecute):
- interpreter/Interpreter.h:
- jit/JITCode.h:
(JSC::JITCode::execute):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_catch):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_catch):
- jit/JITStubs.cpp:
(JSC::ctiTrampoline):
(JSC::jitThrow):
(JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
- runtime/CallData.cpp:
(JSC::call):
- runtime/Completion.cpp:
(JSC::evaluate):
- runtime/ConstructData.cpp:
(JSC::construct):
- runtime/ExceptionHelpers.cpp:
(JSC::createErrorForInvalidGlobalAssignment):
(JSC::throwOutOfMemoryError):
(JSC::throwStackOverflowError):
- runtime/ExceptionHelpers.h:
- runtime/JSArray.cpp:
(JSC::JSArray::sort):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace):
- 1:38 PM Changeset in webkit [70702] by
-
- 3 edits in trunk/WebKit2
Fix the WebKit2 API tests.
https://bugs.webkit.org/show_bug.cgi?id=48461
Reviewed by Sam Weinig.
The API tests were failing because the tests expect to be able to send messages before the
WebProcess finishes launching.
Instead of dispatching the pending messages in processDidFinishLaunching, dispatch them in
ensureWebProcess but do not make messages pending if the process is launching.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::processDidFinishLaunching):
Move dispatching the pending messages back from here ...
(WebKit::WebContext::ensureWebProcess):
... to here.
(WebKit::WebContext::postMessageToInjectedBundle):
Check whether the process can send messages in order to determine if a message needs to be
sent later.
- UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::canSendMessage):
The WebProcessProxy can send a message if it is valid or if it is launching.
- 1:34 PM Changeset in webkit [70701] by
-
- 2 edits in trunk/WebCore
2010-10-27 Tony Chang <tony@chromium.org>
Unreviewed, build fix after r70692.
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBorder):
- 1:32 PM Changeset in webkit [70700] by
-
- 1 edit2 deletes in trunk/LayoutTests
2010-10-27 Simon Fraser <Simon Fraser>
Remove Leopard-specific results that are no longer required.
- platform/mac-leopard/fast/text/international/vertical-text-glyph-test-expected.txt: Removed.
- platform/mac-leopard/fast/text/international/vertical-text-metrics-test-expected.txt: Removed.
- 1:32 PM Changeset in webkit [70699] by
-
- 3 edits in trunk/JavaScriptCore
2010-10-27 Gabor Loki <loki@webkit.org>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=48060
Speed up op_jeq_null and op_jneq_null.
For both opcodes the NullTag and UndefinedTag are checked to control the
jump. These values can be simply checked by AboveOrEqual or Below
condition if they are the two highest unsigned integers from JSValue's
Tag field.
- jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null):
- runtime/JSValue.h:
- 1:16 PM Changeset in webkit [70698] by
-
- 1 edit6 adds in trunk/LayoutTests
Add Windows-specific results for tests added in r70664
These tests aren't rendering correctly. That's covered by
<http://webkit.org/b/48459>.
- platform/win/fast/blockflow/japanese-lr-text-expected.checksum: Added.
- platform/win/fast/blockflow/japanese-lr-text-expected.png: Added.
- platform/win/fast/blockflow/japanese-lr-text-expected.txt: Added.
- platform/win/fast/blockflow/japanese-rl-text-expected.checksum: Added.
- platform/win/fast/blockflow/japanese-rl-text-expected.png: Added.
- platform/win/fast/blockflow/japanese-rl-text-expected.txt: Added.
- 1:15 PM Changeset in webkit [70697] by
-
- 2 edits in trunk/WebCore
2010-10-27 Leandro Pereira <leandro@profusion.mobi>
Unreviewed. Build fix after r70651.
- CMakeListsEfl.txt: Add SoupURIUtils.cpp.
- 1:10 PM Changeset in webkit [70696] by
-
- 3 edits in trunk/WebKit2
WebPageProxy::isValid should return false if the page has been explicitly closed
https://bugs.webkit.org/show_bug.cgi?id=48458
Reviewed by Sam Weinig.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::isValid):
(WebKit::WebPageProxy::relaunch):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::isClosed):
- 12:58 PM CSS21Results edited by
- (diff)
- 12:53 PM Changeset in webkit [70695] by
-
- 2 edits in trunk/WebCore
2010-10-27 Crystal Zhang <haizhang@rim.com>
Reviewed by Eric Carlson.
Fix an issue where we were passing the wrong parameter
to MIMETypeRegistry::getMIMETypeForExtension().
- platform/MIMETypeRegistry.cpp:
- 12:52 PM Changeset in webkit [70694] by
-
- 2 edits2 copies in branches/chromium/552
Merge 70681
BUG=60695
- 12:49 PM Changeset in webkit [70693] by
-
- 2 edits2 copies in branches/chromium/517
Merge 70681
BUG=60695
Review URL: http://codereview.chromium.org/4091006
- 12:48 PM Changeset in webkit [70692] by
-
- 4 edits8 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=48449
Reviewed by Beth Dakin.
Make border drawing work correctly with vertical inline flows. The top and bottom edge have to be omitted
rather than the left and right edges.
Also discovered that border-radius is broken with the new path-based-drawing code for all inline flows. This
is a regression from the old drawing code. I patched the code to be correct rather than clipping out stuff
that it shouldn't and applying border-radii on lines that don't even have them.
Added fast/blockflow/border-vertical-lr.html and fast/borders/border-radius-inline-flow.html
WebCore:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):
- rendering/RenderBoxModelObject.h:
LayoutTests:
- fast/blockflow/border-vertical-lr.html: Added.
- fast/borders/border-radius-inline-flow.html: Added.
- platform/mac/fast/blockflow/border-vertical-lr-expected.checksum: Added.
- platform/mac/fast/blockflow/border-vertical-lr-expected.png: Added.
- platform/mac/fast/blockflow/border-vertical-lr-expected.txt: Added.
- platform/mac/fast/borders/border-radius-inline-flow-expected.checksum: Added.
- platform/mac/fast/borders/border-radius-inline-flow-expected.png: Added.
- platform/mac/fast/borders/border-radius-inline-flow-expected.txt: Added.
- 12:43 PM Changeset in webkit [70691] by
-
- 2 edits in trunk/LayoutTests
Skip some failing tests on Windows
The tests don't fail in a reliable way, so skipping them is our best
option for now.
- platform/win/Skipped:
- 12:39 PM Changeset in webkit [70690] by
-
- 2 edits in trunk/WebKit/qt
2010-10-27 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix tst_QWebFrame::popupFocus().
https://bugs.webkit.org/show_bug.cgi?id=48432
- Call setFocus() before show() to work around a but in Qt.
- Remove the check on combo at the end since hidePopup() leads indirectly to its destruction and segfault.
- tests/qwebframe/tst_qwebframe.cpp:
- 12:35 PM Changeset in webkit [70689] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-10-27 Martin Robinson <mrobinson@igalia.com>
Add GTK+-specific baselines for a couple tests.
- platform/gtk/animations/missing-values-first-keyframe-expected.txt: Added.
- platform/gtk/animations/missing-values-last-keyframe-expected.txt: Added.
- 12:31 PM Changeset in webkit [70688] by
-
- 4 edits5 adds in trunk
2010-10-27 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Cairo] Font fallback determination is very ineffecient
https://bugs.webkit.org/show_bug.cgi?id=42052
Added a test which verifies the correct result rendering with a custom
font that is missing many glyphs.
- platform/gtk/fonts/custom-font-missing-glyphs-expected.checksum: Added.
- platform/gtk/fonts/custom-font-missing-glyphs-expected.png: Added.
- platform/gtk/fonts/custom-font-missing-glyphs-expected.txt: Added.
- platform/gtk/fonts/custom-font-missing-glyphs.html: Added.
- platform/gtk/fonts/resources/mostly-empty-font.ttf: Added. A font that I created in fotnforge which is composed of empty glyphs, except for 'A' which has a lonely polyhedron for a glyph.
2010-10-27 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Cairo] Font fallback determination is very ineffecient
https://bugs.webkit.org/show_bug.cgi?id=42052
When choosing a fallback font in FontCache::getFontDataForCharacters, use FontConfig's
mechanism for searching the fallback list directly, instead of scanning the list manually.
If the font is a custom font or any other font with no FontConfig pattern associated with
it, as FontConfig for a font that can supply the missing glyphs.
Test: platform/gtk/fonts/custom-font-missing-glyphs.html
- platform/graphics/cairo/FontCacheFreeType.cpp: (WebCore::createFontConfigPatternForCharacters): Added this helper which turns a collection of unicode characters into a FontConfig pattern. (WebCore::findBestFontGivenFallbacks): Using a FontConfig pattern created with th above helper and a FcFontSet of fallback fonts, this helper will find a font in the set which fulfills the requirments. (WebCore::FontCache::getFontDataForCharacters): Given an existing font with missing glyphs, either find an appropriate fallback font from the list of FontConfig fallbacks or ask FontConfig directly for an appropriate font.
- platform/graphics/cairo/FontPlatformDataFreeType.h: Made a member mutable, as it is initialized lazily.
- 12:21 PM Changeset in webkit [70687] by
-
- 9 edits4 copies4 adds in trunk/WebKit2
Begin stubbing out the Download class
https://bugs.webkit.org/show_bug.cgi?id=48447
Reviewed by Adam Roben.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- WebKit2Prefix.h:
Include WebCore/EmptyProtocolDefinitions.h
- WebProcess/Downloads/Download.cpp: Added.
- WebProcess/Downloads/Download.h: Added.
- WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload):
Create a Download object and start it.
- WebProcess/Downloads/mac/DownloadMac.mm: Added.
(WebKit::Download::start):
Create an NSURLDownload.
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::startDownload):
Ask the download manager to start downloading.
- win/WebKit2.vcproj:
- win/WebKit2Common.vsprops:
Add new files.
- 12:09 PM Changeset in webkit [70686] by
-
- 9 edits in trunk/LayoutTests
2010-10-27 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Dirk Schulze.
preserveAlpha attributes were misspeled in SVGFEConcolveMatrixElement tests.
https://bugs.webkit.org/show_bug.cgi?id=48403
Since expecteds and pixel tests didn't change after correcting this attribute has no effect so it is removed.
For checking preserveAlpha attribute we have already a dom test which is not affected by this patch.
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-bias-attr.js:
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-divisor-attr.js:
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-in-attr.js:
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr.js:
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr.js:
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-order-attr.js:
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetX-attr.js:
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetY-attr.js:
- 12:05 PM Changeset in webkit [70685] by
-
- 3 edits in trunk/WebKit2
Don't allow setting NetscapePlugin::m_isWindowed after NPP_New has completed
In Firefox, Chrome, and WebKit1 trying to set this value after NPP_New
does not actually affect whether the plugin is windowed.
Fixes <http://webkit.org/b/46673> <rdar://problem/8484211> Assertion
failure in NetscapePlugin::platformDestroy when running
plugins/mouse-events.html in WebKit2 on Windows
Reviewed by Anders Carlsson.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::setIsWindowed): Moved here from the header.
Bail out if m_isStarted is true, indicating that NPP_New has already
finished.
- WebProcess/Plugins/Netscape/NetscapePlugin.h: Removed the
implementation of setIsWindowed.
- 12:02 PM Changeset in webkit [70684] by
-
- 2 edits8 adds in trunk/LayoutTests
2010-10-27 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Update expectations after r70664.
- platform/chromium-mac/fast/blockflow/japanese-lr-text-expected.checksum: Added.
- platform/chromium-mac/fast/blockflow/japanese-rl-text-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/japanese-lr-text-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/japanese-lr-text-expected.png: Added.
- platform/chromium-win/fast/blockflow/japanese-lr-text-expected.txt: Added.
- platform/chromium-win/fast/blockflow/japanese-rl-text-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/japanese-rl-text-expected.png: Added.
- platform/chromium-win/fast/blockflow/japanese-rl-text-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 11:58 AM Changeset in webkit [70683] by
-
- 3 edits in trunk/WebKitTools
2010-10-27 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, rolling out r70674.
http://trac.webkit.org/changeset/70674
https://bugs.webkit.org/show_bug.cgi?id=48053
Broke Chromium Windows build.
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 11:53 AM Changeset in webkit [70682] by
-
- 8 edits in trunk
2010-10-27 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: "Reload Page and Audit on Load" fails to run audits when resource tracking is disabled
https://bugs.webkit.org/show_bug.cgi?id=48431
- http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.enableResourceTracking): (initialize_InspectorTest.InspectorTest.disableResourceTracking):
- http/tests/inspector/resource-parameters.html:
- inspector/audits-panel-functional.html:
- inspector/styles-source-offsets.html:
2010-10-27 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: "Reload Page and Audit on Load" fails to run audits when resource tracking is disabled
https://bugs.webkit.org/show_bug.cgi?id=48431
- inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._createPanelEnabler): (WebInspector.ResourcesPanel.prototype._enableResourceTracking):
- 11:46 AM Changeset in webkit [70681] by
-
- 4 edits2 adds in trunk
2010-10-27 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Add a function to make sure child is allowed before adding to a
render view.
https://bugs.webkit.org/show_bug.cgi?id=48328
Test: fast/inline/inline-child-height-width-calc-crash.html
- rendering/RenderView.cpp: (WebCore::RenderView::isChildAllowed):
- rendering/RenderView.h:
2010-10-27 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Tests that adding a br element to a new document does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=48328
- fast/inline/inline-child-height-width-calc-crash-expected.txt: Added.
- fast/inline/inline-child-height-width-calc-crash.html: Added.
- 11:45 AM Changeset in webkit [70680] by
-
- 8 edits in trunk/WebKit2
Add API for enabling the developer extras (Web Inspector).
Reviewed by John Sullivan.
- Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetDeveloperExtrasEnabled):
(WKPreferencesGetDeveloperExtrasEnabled):
- UIProcess/API/C/WKPreferences.h:
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::setDeveloperExtrasEnabled):
(WebKit::WebPreferences::developerExtrasEnabled):
- UIProcess/WebPreferences.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 11:42 AM Changeset in webkit [70679] by
-
- 6 edits in trunk
2010-10-25 Tony Chang <tony@chromium.org>
Reviewed by Anders Carlsson.
compile TestNetscapePlugIn on chromium linux
https://bugs.webkit.org/show_bug.cgi?id=48274
- WebKit.gyp: Enable compilation of TestNetscapePlugIn on Linux.
2010-10-25 Tony Chang <tony@chromium.org>
Reviewed by Anders Carlsson.
compile TestNetscapePlugIn on chromium linux
https://bugs.webkit.org/show_bug.cgi?id=48274
- DumpRenderTree/TestNetscapePlugIn/main.cpp: (NP_Initialize): On Linux, plugin funcs are set in initialize. (NPP_New): Mark the plugin as windowless. (NPP_GetValue): Handle mime type values. (NP_GetMIMEDescription): (NP_GetValue):
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: define TRUE and FALSE, which are in webkit's npapi.h.
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Pull in npapi.h to get TRUE/FALSE (matches webkit's npfunctions.h)
- 11:36 AM Changeset in webkit [70678] by
-
- 2 edits16 adds in trunk/LayoutTests
2010-10-27 Dimitri Glazkov <Dimitri Glazkov>
- platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.checksum: Added.
- platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.png: Added.
- platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.txt: Added.
- platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.checksum: Added.
- platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.png: Added.
- platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.txt: Added.
- platform/chromium-mac/animations/missing-values-first-keyframe-expected.checksum: Added.
- platform/chromium-mac/animations/missing-values-first-keyframe-expected.png: Added.
- platform/chromium-mac/animations/missing-values-last-keyframe-expected.checksum: Added.
- platform/chromium-mac/animations/missing-values-last-keyframe-expected.png: Added.
- platform/chromium-win/animations/missing-values-first-keyframe-expected.checksum: Added.
- platform/chromium-win/animations/missing-values-first-keyframe-expected.png: Added.
- platform/chromium-win/animations/missing-values-first-keyframe-expected.txt: Added.
- platform/chromium-win/animations/missing-values-last-keyframe-expected.checksum: Added.
- platform/chromium-win/animations/missing-values-last-keyframe-expected.png: Added.
- platform/chromium-win/animations/missing-values-last-keyframe-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 11:36 AM Changeset in webkit [70677] by
-
- 4 edits in trunk/WebCore
2010-10-27 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] r69296 includes a cast from GdkWindow* to GtkWindow*
https://bugs.webkit.org/show_bug.cgi?id=48445
Pass the pageClient GtkWidget* to gtk_xtbin_new instead of the
GdkWindow*. The pageClient is used to get the proper visual for the
plugin container widget.
No new tests. This patch should prevent plugins/null-npp-getvalue-pointer.html
from crashing.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::platformStart): Pass the widget instead of the window.
- plugins/gtk/gtk2xtbin.c: Accept the widget instead of the window. (gtk_xtbin_new):
- plugins/gtk/gtk2xtbin.h: Update the declaration.
- 11:19 AM Changeset in webkit [70676] by
-
- 14 edits in trunk
2010-10-27 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Anders Carlsson.
Move contentsSizeChange from the UIClient into the PageClient and
and make it a private Qt-only API in the process.
Make WKPageContentsSizeChangedCallback be a private API
https://bugs.webkit.org/show_bug.cgi?id=48409
- UIProcess/API/C/WKPage.h:
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::didChangeContentsSize): (QWKPage::QWKPage):
- UIProcess/API/qt/qwkpage_p.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didChangeContentsSize):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::contentsSizeChanged):
2010-10-27 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Anders Carlsson.
Remove contentSizeChanged callbacks as it is no longer
part of the public UIClient.
Make WKPageContentsSizeChangedCallback be a private API
https://bugs.webkit.org/show_bug.cgi?id=48409
- MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]):
- MiniBrowser/win/BrowserView.cpp: (BrowserView::create):
- WebKitTestRunner/TestController.cpp: (WTR::createOtherPage): (WTR::TestController::initialize):
- 11:05 AM Changeset in webkit [70675] by
-
- 4 edits in trunk/WebCore
2010-10-27 Kwang Yul Seo <skyul@company100.net>
Reviewed by James Robinson.
[BREWMP] Port graphics backend
https://bugs.webkit.org/show_bug.cgi?id=40275
Add PLATFORM(BREWMP) guard to skia's FontCustomPlatformData
to share OS(LINUX) implementation.
- loader/CachedFont.cpp:
- platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::createFontCustomPlatformData):
- platform/graphics/skia/FontCustomPlatformData.h:
- 11:02 AM Changeset in webkit [70674] by
-
- 3 edits in trunk/WebKitTools
Make http locking default in NRWT.
https://bugs.webkit.org/show_bug.cgi?id=48053
Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-10-27
Reviewed by Ojan Vafai.
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 10:59 AM Changeset in webkit [70673] by
-
- 5 edits3 adds in trunk
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=41948
REGRESSION(r60392): Registerfile can be unwound too far following an exception
Reviewed by Oliver Hunt.
SunSpider reports no change.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException): Walk the stack to calculate the high
water mark currently in use. It's not safe to assume that the current
CallFrame's high water mark is the highest high water mark because
calls do not always set up at the end of a CallFrame. A large caller
CallFrame can encompass a small callee CallFrame.
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTINativeCall):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall): Make sure to set a 0 CodeBlock
in the CallFrame of a host call, like the Interpreter does, instead of
leaving the CodeBlock field uninitialized. The backtracing code requires
a valid CodeBlock field in each CallFrame.
LayoutTests: Added a test for:
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=41948
REGRESSION(r60392): Registerfile can be unwound too far following an exception
- fast/js/exception-registerfile-shrink-expected.txt: Added.
- fast/js/exception-registerfile-shrink.html: Added.
- fast/js/script-tests/exception-registerfile-shrink.js: Added.
- 10:51 AM Changeset in webkit [70672] by
-
- 2 edits in trunk/WebKitTools
2010-10-27 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
Reviewed by Tony Chang.
[NRWT] Fix http lock on Windows platform
https://bugs.webkit.org/show_bug.cgi?id=48321
- Scripts/webkitpy/layout_tests/port/http_lock.py:
- 10:50 AM Changeset in webkit [70671] by
-
- 2 edits in trunk/LayoutTests
2010-10-27 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; grouped editing test failures in one place.
- platform/chromium/test_expectations.txt:
- 10:48 AM Changeset in webkit [70670] by
-
- 6 edits in trunk/LayoutTests
Unreviewed. Update Qt specific expected files after r70546.
- platform/qt/fast/blockflow/floats-in-block-layout-expected.txt:
- platform/qt/fast/blockflow/self-collapsing-block-expected.txt:
- platform/qt/fast/multicol/nested-columns-expected.checksum:
- platform/qt/fast/multicol/nested-columns-expected.png:
- platform/qt/fast/multicol/nested-columns-expected.txt:
- 10:46 AM Changeset in webkit [70669] by
-
- 30 edits2 deletes in trunk
2010-10-27 Satish Sampath <satish@chromium.org>
Unreviewed, rolling out r70665.
http://trac.webkit.org/changeset/70665
https://bugs.webkit.org/show_bug.cgi?id=47089
Need to address Alexey's review comments.
- fast/speech/input-text-language-tag-expected.txt: Removed.
- fast/speech/input-text-language-tag.html: Removed.
- fast/speech/input-text-speechbutton.html:
- fast/speech/speech-button-ignore-generated-events.html:
- platform/chromium/test_expectations.txt:
2010-10-27 Satish Sampath <satish@chromium.org>
Unreviewed, rolling out r70665.
http://trac.webkit.org/changeset/70665
https://bugs.webkit.org/show_bug.cgi?id=47089
Need to address Alexey's review comments.
- page/SpeechInput.cpp: (WebCore::SpeechInput::startRecognition):
- page/SpeechInput.h:
- page/SpeechInputClient.h:
- platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::startRecognition): (WebCore::SpeechInputClientMock::setRecognitionResult): (WebCore::SpeechInputClientMock::timerFired):
- platform/mock/SpeechInputClientMock.h:
- rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::attachInnerElement): (WebCore::SearchFieldCancelButtonElement::detach): (WebCore::SpinButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::detach):
2010-10-27 Satish Sampath <satish@chromium.org>
Unreviewed, rolling out r70665.
http://trac.webkit.org/changeset/70665
https://bugs.webkit.org/show_bug.cgi?id=47089
Need to address Alexey's review comments.
- public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition):
- public/WebSpeechInputControllerMock.h:
- src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::startRecognition):
- src/SpeechInputClientImpl.h:
- src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::setMockRecognitionResult): (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
- src/WebSpeechInputControllerMockImpl.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
- src/WebViewImpl.h:
2010-10-27 Satish Sampath <satish@chromium.org>
Unreviewed, rolling out r70665.
http://trac.webkit.org/changeset/70665
https://bugs.webkit.org/show_bug.cgi?id=47089
Need to address Alexey's review comments.
- DumpRenderTree/LayoutTestController.cpp: (setMockSpeechInputResultCallback):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockSpeechInputResult):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setMockSpeechInputResult):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMockSpeechInputResult):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setMockSpeechInputResult):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setMockSpeechInputResult):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setMockSpeechInputResult):
- 10:26 AM Changeset in webkit [70668] by
-
- 8 edits in trunk/LayoutTests
Change the results to account for a typo in the Japanese text string.
- 10:25 AM Changeset in webkit [70667] by
-
- 61 edits in trunk/LayoutTests
2010-10-27 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Update expectations after r70654.
https://bugs.webkit.org/show_bug.cgi?id=48347
- platform/chromium-*/svg/dynamic-updates/*: Updated.
- 10:24 AM Changeset in webkit [70666] by
-
- 4 edits in trunk
2010-10-27 ZHenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Must enable GL_POINT_SPRITE in GraphicsContext3D implementations
https://bugs.webkit.org/show_bug.cgi?id=45908
- src/WebGraphicsContext3DDefaultImpl.cpp: Enable for chromium --in-process-webgl port. (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
2010-10-27 ZHenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Must enable GL_POINT_SPRITE in GraphicsContext3D implementations
https://bugs.webkit.org/show_bug.cgi?id=45908
- platform/graphics/mac/GraphicsContext3DMac.mm: Enable for Mac port. (WebCore::GraphicsContext3D::GraphicsContext3D):
- 10:19 AM Changeset in webkit [70665] by
-
- 30 edits2 adds in trunk
2010-10-27 Leandro Gracia Gil <leandrogracia@google.com>
Reviewed by Jeremy Orlow.
Added a layout test for the language tag in speech input. Updated
the speech button tests to include the new language parameter in the
mock result.
https://bugs.webkit.org/show_bug.cgi?id=47089
- fast/speech/input-text-language-tag-expected.txt: Added.
- fast/speech/input-text-language-tag.html: Added.
- fast/speech/input-text-speechbutton.html:
- fast/speech/speech-button-ignore-generated-events.html:
- platform/chromium/test_expectations.txt:
2010-10-27 Leandro Gracia Gil <leandrogracia@google.com>
Reviewed by Jeremy Orlow.
Patch the current speech input implementation to use the nearest
language tag. The language is now passed to the startRecognition
methods so that language-specific recognition could be used. Also added
a second parameter to setMockSpeechInputResult for the language used in
speech recognition.
https://bugs.webkit.org/show_bug.cgi?id=47089
This is the 2nd of a 4-sided patch in Chromium and WebKit. For more
details see http://codereview.chromium.org/3615005/show and
http://codereview.chromium.org/3595018/show. The last of the 4 patches
depends also on the language tag validation provided by this patch:
https://bugs.webkit.org/show_bug.cgi?id=48225.
Test: fast/speech/input-text-language-tag.html
- page/SpeechInput.cpp: (WebCore::SpeechInput::startRecognition):
- page/SpeechInput.h:
- page/SpeechInputClient.h:
- platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::startRecognition): (WebCore::SpeechInputClientMock::setRecognitionResult): (WebCore::SpeechInputClientMock::timerFired):
- platform/mock/SpeechInputClientMock.h:
- rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::attachInnerElement): (WebCore::SearchFieldCancelButtonElement::detach): (WebCore::SpinButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::detach):
2010-10-27 Leandro Gracia Gil <leandrogracia@google.com>
Reviewed by Jeremy Orlow.
Patch the current speech input implementation to use the nearest
language tag. The language is now passed to the startRecognition
methods so that language-specific recognition could be used. Also added
a second parameter to setMockSpeechInputResult for the language used in
speech recognition.
https://bugs.webkit.org/show_bug.cgi?id=47089
This is the 2nd of a 4-sided patch in Chromium and WebKit. For more
details see http://codereview.chromium.org/3615005/show and
http://codereview.chromium.org/3595018/show. The last of the 4 patches
depends also on the language tag validation provided by this patch:
https://bugs.webkit.org/show_bug.cgi?id=48225.
- public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition):
- public/WebSpeechInputControllerMock.h:
- src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::create): (WebKit::SpeechInputClientImpl::startRecognition):
- src/SpeechInputClientImpl.h:
- src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::setMockRecognitionResult): (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
- src/WebSpeechInputControllerMockImpl.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
- src/WebViewImpl.h:
2010-10-27 Leandro Gracia Gil <leandrogracia@google.com>
Reviewed by Jeremy Orlow.
Added a second parameter to setMockSpeechInputResult for
the language used in speech input.
https://bugs.webkit.org/show_bug.cgi?id=47089
- DumpRenderTree/LayoutTestController.cpp: (setMockSpeechInputResultCallback):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockSpeechInputResult):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setMockSpeechInputResult):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMockSpeechInputResult):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setMockSpeechInputResult):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setMockSpeechInputResult):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setMockSpeechInputResult): (LayoutTestController::pageSizeAndMarginsInPixels):
- 10:16 AM Changeset in webkit [70664] by
-
- 6 edits8 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=48381
Reviewed by Dan Bernstein.
Make basic layer positioning work with vertical-lr writing-mode.
WebCore:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::paintFloats):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::adjustForFlippedBlocksWritingMode):
(WebCore::RenderBox::locationOffsetIncludingFlipping):
- rendering/RenderBox.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition):
LayoutTests:
- fast/blockflow/japanese-lr-text.html: Added.
- fast/blockflow/japanese-rl-text.html: Added.
- 10:14 AM Changeset in webkit [70663] by
-
- 2 edits in trunk/WebCore
2010-10-27 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
object-deletion-behaviour.html fails with mesa backend
https://bugs.webkit.org/show_bug.cgi?id=46667
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): If object_type is 0, we return early because object_name should be always be 0.
- 10:13 AM Changeset in webkit [70662] by
-
- 6 edits in trunk/WebKitTools
Reset TestNetscapePlugIn's NPP_GetValue pointer when NullNPPGetValuePointer finishes running
Fixes <http://webkit.org/b/48435> REGRESSION (r70655): Many plugins
tests are failing on Qt
Reviewed by Anders Carlsson.
- DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::NPP_Destroy):
- DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
Added a do-nothing NPP_Destroy implementation.
- DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:
(NullNPPGetValuePointer::NullNPPGetValuePointer): Save the original
NPP_GetValue pointer in m_originalNPPGetValuePointer so we can restore
it later.
(NullNPPGetValuePointer::NPP_Destroy): Added. Restores the original
NPP_GetValue pointer so it can be used in other tests.
- DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_Destroy):
- DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_destroy_instance):
Call through to the PluginTest when NPP_Destroy is called.
- 10:10 AM Changeset in webkit [70661] by
-
- 3 edits in trunk/WebCore
2010-10-27 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
If WebGL is running on top of a strict version of OpenGL ES it should make sure attribs have buffers assigned at all times
https://bugs.webkit.org/show_bug.cgi?id=47964
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateRenderingState): Minimum checking: if input <= 0, only check if each enabled vertex attribute is bound to a buffer. (WebCore::WebGLRenderingContext::drawArrays): If underlying GL performs bounds checking, we still need to do the minimum checking using validateRenderingState. (WebCore::WebGLRenderingContext::drawElements): Ditto.
- html/canvas/WebGLRenderingContext.h: Add a comment for input <= 0 in validateRenderingState.
- 10:04 AM Changeset in webkit [70660] by
-
- 2 edits5 adds in trunk/LayoutTests
2010-10-27 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Update results after r70569.
- platform/chromium-linux/fast/blockflow/english-lr-text-expected.checksum: Added.
- platform/chromium-mac/fast/blockflow/english-lr-text-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/english-lr-text-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/english-lr-text-expected.png: Added.
- platform/chromium-win/fast/blockflow/english-lr-text-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 10:00 AM Changeset in webkit [70659] by
-
- 5 edits3 adds in trunk/WebKit2
Add DownloadManager class
https://bugs.webkit.org/show_bug.cgi?id=48388
Reviewed by Sam Weinig.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- WebProcess/Downloads/DownloadManager.cpp: Added.
(WebKit::DownloadManager::shared):
(WebKit::DownloadManager::DownloadManager):
- WebProcess/Downloads/DownloadManager.h: Added.
- win/WebKit2.vcproj:
- win/WebKit2Common.vsprops:
Add new files.
- 9:56 AM Changeset in webkit [70658] by
-
- 5 edits1 add in trunk
WebKit2 shouldn't try to send an empty user agent
https://bugs.webkit.org/show_bug.cgi?id=48397
Reviewed by Adam Roben.
WebKit2:
Change the check of the custom user agent to an empty check instead of a null check. When the client application
sets a custom user agent and then resets it, the custom user agent is set to an empty string. If all we do
is check for a null string, then we will think we have a custom user agent (which is empty) and send an empty
user agent.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::userAgent):
WebKitTools:
Add a test that when we set our custom user agent to an empty string, we don't send
an empty user agent.
- TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: Added.
(TestWebKitAPI::didRunJavaScript): Make sure that the result of navigator.userAgent isn't empty.
(TestWebKitAPI::TEST): Set our custom user agent to the empty string, and run navigator.userAgent.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add the new file.
- TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
- 9:47 AM Changeset in webkit [70657] by
-
- 3 edits8 adds in trunk
2010-10-27 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Accelerated animation with missing values in keyframes is broken
https://bugs.webkit.org/show_bug.cgi?id=48395
r66339 changed the behavior of keyframe animations such that if a property
is missing from a keyframe, the property will be interpolated between those
keyframes that do have a value for the property. If a value is missing
from the first or last keyframes, the element's unanimated style supplies
that value.
However, accelerated animations had a bug where if a value was missing
from the first (and maybe subsequent) or last (and maybe preceding) keyframes,
the animation data given to the GraphicsLayer would be missing the style from the
first or final keyframe.
Tests: animations/missing-values-first-keyframe.html
animations/missing-values-last-keyframe.html
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation):
- 9:37 AM Changeset in webkit [70656] by
-
- 2 edits in trunk/LayoutTests
2010-10-27 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed.
Moved the tests with WONTFIX to the WONTFIX list.
- platform/chromium/test_expectations.txt:
- 9:12 AM Changeset in webkit [70655] by
-
- 2 edits in trunk/WebKitTools
Check in file I forgot in r70653
- DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
(NP_Initialize): Save the NPPluginFuncs struct the browser passed to us
so we can be naughty and modify it later.
- 9:10 AM Changeset in webkit [70654] by
-
- 2 edits in trunk/WebCore
2010-10-27 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Dirk Schulze.
Calling the super class of RenderSVGImage::updateFromElement is missing
https://bugs.webkit.org/show_bug.cgi?id=48347
RenderSVGImage::updateFromElement is an inherited function of RenderSVGModelObject what needs calling its ancestor.
Lack of this call caused filters were not invalidated at SVGImage objects.
No new tests, because this modification is covered by SVGFEConvolveMatrixElement's dynamic update tests.
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::updateFromElement):
- 9:08 AM Changeset in webkit [70653] by
-
- 11 edits3 adds in trunk
Don't call NPP_GetValue if the plugin didn't provide an implementation
Fixes <http://webkit.org/b/48433> Crash in
NetscapePlugin::shouldLoadSrcURL when using Shockwave Director 10.3 in
WebKit2 on Windows
Reviewed by Eric Carlson.
WebKit2:
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NPP_GetValue): Null-check the getvalue pointer
before using it to call NPP_GetValue.
WebKitTools:
Test that WebKit doesn't crash if the plugin passes 0 for its
NPP_GetValue pointer
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- GNUmakefile.am:
Added NullNPPGetValuePointer.cpp.
- DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
- DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
Set up a place to store the NPPluginFuncs struct the browser passed to us.
- DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp: Added.
(NullNPPGetValuePointer::NullNPPGetValuePointer): Null out the
NPP_GetValue pointer we passed to the browser to simulate a plugin that
doesn't implement NPP_GetValue.
(NullNPPGetValuePointer::NPP_GetValue): Print an error message. If this
function is called, it means that WebKit has changed in a way that
makes this test invalid.
- DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NP_GetEntryPoints): Save the NPPluginFuncs struct the browser passed
to us so we can be naughty and modify it later.
LayoutTests:
Test that WebKit doesn't crash if the plugin passes 0 for its
NPP_GetValue pointer
- plugins/null-npp-getvalue-pointer-expected.txt: Added.
- plugins/null-npp-getvalue-pointer.html: Added.
- 9:02 AM Changeset in webkit [70652] by
-
- 3 edits2 adds in trunk
2010-10-27 Justin Schuh <jschuh@chromium.org>
Reviewed by Dirk Schulze.
Ignore invalid blend modes
https://bugs.webkit.org/show_bug.cgi?id=48371
Test: svg/filters/feBlend-invalid-mode.xhtml
- platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):
2010-10-27 Justin Schuh <jschuh@chromium.org>
Reviewed by Dirk Schulze.
Ignore invalid blend modes
https://bugs.webkit.org/show_bug.cgi?id=48371
- svg/filters/feBlend-invalid-mode-expected.txt: Added.
- svg/filters/feBlend-invalid-mode.xhtml: Added.
- 8:58 AM Changeset in webkit [70651] by
-
- 7 edits2 adds in trunk
2010-10-27 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[Gtk] http/tests/xmlhttprequest/basic-auth-default.html fails
https://bugs.webkit.org/show_bug.cgi?id=38956
- platform/gtk/Skipped: removed test from skipped list
2010-10-27 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[Gtk] http/tests/xmlhttprequest/basic-auth-default.html fails
https://bugs.webkit.org/show_bug.cgi?id=38956
Added a new utility function that turns SoupURIs into
KURLs. That addresses some issues with SoupURIs like for example
soup_uri_to_string ignoring the URI password. Basic authentication
using URL credentials should work now.
- GNUmakefile.am:
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::loadResourceSynchronously):
- platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateFromSoupMessage):
- platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::updateFromSoupMessage):
- platform/network/soup/SoupURIUtils.cpp: Added. (WebCore::soupURIToKURL):
- platform/network/soup/SoupURIUtils.h: Added.
- 8:56 AM Changeset in webkit [70650] by
-
- 6 edits in trunk
2010-10-27 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Andreas Kling.
Remove references to ancient QGVLauncher and QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=48430
- manual-tests/plugins/windowed.html: change to QtTestBrowser
- manual-tests/plugins/windowless.html: ditto
2010-10-27 Ademar de Souza Reis Jr <Ademar Reis>
Reviewed by Andreas Kling.
Remove references to ancient QGVLauncher and QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=48430
QtTestBrowser substitutes both and has checks enabled.
- Scripts/webkitpy/style/checker.py: remove references
- Scripts/webkitpy/style/checker_unittest.py: ditto
- 8:51 AM Changeset in webkit [70649] by
-
- 3 edits in trunk/LayoutTests
2010-10-27 Martin Robinson <mrobinson@igalia.com>
Rebaseline a couple tests after r70569.
- platform/gtk/fast/blockflow/floats-in-block-layout-expected.txt:
- platform/gtk/fast/blockflow/self-collapsing-block-expected.txt:
- 8:48 AM Changeset in webkit [70648] by
-
- 2 edits in trunk/WebKitTools
[NRWT] Don't use image hash when it's no need in single test mode.
https://bugs.webkit.org/show_bug.cgi?id=48326
Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-10-27
Reviewed by Ojan Vafai.
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- 8:43 AM Changeset in webkit [70647] by
-
- 2 edits in trunk/WebKitTools
2010-10-27 David Kilzer <ddkilzer@apple.com>
Fix leak of CFMutableDictionaryRef in createXMLStringFromWebArchiveData()
Reviewed by Adam Roben.
Follow-up fix for: <https://bugs.webkit.org/show_bug.cgi?id=48278>
- DumpRenderTree/cf/WebArchiveDumpSupport.cpp: (createXMLStringFromWebArchiveData): Use RetainPtr<> to fix a leak introduced in r70613.
- 8:30 AM Changeset in webkit [70646] by
-
- 1 edit1 add in trunk/WebCore
2010-10-27 Patrick Gansterer <Patrick Gansterer>
Reviewed by Csaba Osztrogonác.
[WINCE] Buildfix after r70400.
https://bugs.webkit.org/show_bug.cgi?id=48419
- platform/wince/TemporaryLinkStubs.cpp: Added. (WebCore::setCookieStoragePrivateBrowsingEnabled):
- 8:22 AM Changeset in webkit [70645] by
-
- 2 edits in trunk/WebKit2
[Qt] Assert due to multiple initialization of WebPlatformStrategies
https://bugs.webkit.org/show_bug.cgi?id=48327
Reviewed by Andreas Kling.
We are using the LocalizationStrategy in the UI process
so the previous attempt to fix this (http://trac.webkit.org/changeset/70620)
was wrong.
- UIProcess/API/qt/qwkpage.cpp:
(initializePlatformStrategiesIfNeeded):
Call WebPlatformStrategies::initialize exactly once.
(QWKPagePrivate::QWKPagePrivate):
- 8:16 AM Changeset in webkit [70644] by
-
- 2 edits in trunk/WebCore
2010-10-27 Satish Sampath <satish@chromium.org>
Reviewed by Steve Block.
Add runtime flag check before enabling speech input in code.
https://bugs.webkit.org/show_bug.cgi?id=48426
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isSpeechEnabled): Added runtime flag check.
- 7:37 AM Changeset in webkit [70643] by
-
- 2 edits in trunk/WebKitTools
2010-10-27 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
Reviewed by Csaba Osztrogonác.
[NRWT] Add platform specific baseline search paths for Qt port
https://bugs.webkit.org/show_bug.cgi?id=48428
- Scripts/webkitpy/layout_tests/port/qt.py:
- 7:05 AM WebKitGtkLayoutTests edited by
- Add FreeType hinting note (diff)
- 6:48 AM Changeset in webkit [70642] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-27 Gabor Loki <loki@webkit.org>
Reviewed by Csaba Osztrogonác.
Add cmn to branch32(reg, imm) on ARM
https://bugs.webkit.org/show_bug.cgi?id=48062
The conditional comparison can be done with cmn if the imm value is
negative and can fit into the cmn instruction.
- assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::branch32):
- 6:15 AM Changeset in webkit [70641] by
-
- 2 edits in trunk/WebCore
Only decompress pixel buffers when needed (and fix a crash in the process)
Fixes <http://webkit.org/b/48417> Crash when running
compositing/video/video-background-color.html on Windows
Reviewed by Anders Carlsson.
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::paint): Only
decompress the pixel buffer when it has an incompatible format. This
also has the benefit of only decompressing the buffer when a
QTDecompressionSession has been created! (I assume this was just a typo
from when this code was added in r70252.)
- 6:13 AM Changeset in webkit [70640] by
-
- 2 edits in trunk/WebKitTools
Catch exceptions when checking if we're inside a git working directory
Fixes <http://webkit.org/b/48420> REGRESSION (r70562): test-webkitpy
fails on systems without git installed
Reviewed by Anders Carlsson.
- Scripts/webkitpy/common/net/credentials.py:
(Credentials._credentials_from_git): Put the call to
Git.in_working_directory inside the try/except since it, too, attempts
to execute git and thus will throw on systems that don't have git
installed.
- 5:46 AM Changeset in webkit [70639] by
-
- 1 edit in trunk/WebKit/gtk/tests/testatk.c
2010-10-27 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, added missing line in testatk.c to add an unit test.
This fixes a mistake that happened when landing reviewed patch for
bug 47365, while addressing a minor issue before committing it.
getTextAtOffset returns incorrect results if a link includes text and an image
https://bugs.webkit.org/show_bug.cgi?id=47365
- tests/testatk.c: (main):
- 5:35 AM Changeset in webkit [70638] by
-
- 1 edit3 adds in trunk/LayoutTests
Check in new Windows results for svg/custom/use-on-symbol-inside-pattern.svg
Windows has slightly different rounding behavior from Mac on this test.
- platform/win/svg/custom/use-on-symbol-inside-pattern-expected.checksum: Added.
- platform/win/svg/custom/use-on-symbol-inside-pattern-expected.png: Added.
- platform/win/svg/custom/use-on-symbol-inside-pattern-expected.txt: Added.
- 5:07 AM Changeset in webkit [70637] by
-
- 2 edits in trunk/WebKit2
2010-10-27 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
Reviewed by Andreas Kling.
[Qt] WebKit2 UI process crashes if web process crashes
https://bugs.webkit.org/show_bug.cgi?id=48400
Check the success of socket write operations.
Avoids crashing the UI process if web process has crashed.
Qt socket code segfaults when write is called for a socket
that has had an error.
- Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::Connection::platformInvalidate): Reset m_socket after deletion.
(CoreIPC::Connection::sendOutgoingMessage):
Check error status of write operations and
invalidate socket if writes fail.
- 4:52 AM Changeset in webkit [70636] by
-
- 2 edits in trunk/LayoutTests
2010-10-27 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed, fix english-lr-text expectations that I've messed up.
- platform/chromium/test_expectations.txt:
- 4:48 AM Changeset in webkit [70635] by
-
- 2 edits in trunk/WebKit2
2010-10-27 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
Reviewed by Andreas Kling.
[Qt] Type mismatch while serializing/deserializing message id size
https://bugs.webkit.org/show_bug.cgi?id=48401
Use correct types when reading data from connection buffer.
The message id is written as uint32_t, thus the buffer size should be
calculated based on sizeof(uint32_t) and not sizeof(MessageID).
- Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::Connection::readyReadHandler):
- 4:15 AM Changeset in webkit [70634] by
-
- 4 edits in trunk
2010-10-27 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
getTextAtOffset returns incorrect results if a link includes text and an image
https://bugs.webkit.org/show_bug.cgi?id=47365
Properly consider text under a non-text renderer in textForObject.
We need to check all the children under a non-text renderer, if
any, to consider when current object is not a text object but some
of its children are, in order not to miss those portions of text
by not properly handling those situations.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (textForRenderer): New. Get the text for a RenderObject's children. (textForObject): Use the new textForRenderer function.
2010-10-27 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
getTextAtOffset returns incorrect results if a link includes text and an image
https://bugs.webkit.org/show_bug.cgi?id=47365
New test to make sure this bug is actually fixed.
- tests/testatk.c: (testWebkitAtkLinksWithInlineImages): New test. (main): Added new test.
- 4:14 AM Changeset in webkit [70633] by
-
- 2 edits in trunk/LayoutTests
2010-10-27 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, build fix for r70622.
- inspector/storage-panel-dom-storage.html:
- 3:29 AM Changeset in webkit [70632] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
2010-10-26 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Add IndexedDB test/tutorial
https://bugs.webkit.org/show_bug.cgi?id=48067
This document is useful in terms of demonstrating IndexedDB and
documenting what we do and don't support currently, since I'll be
maintaining it for at least some time.
- storage/indexeddb/tutorial-expected.txt: Added.
- storage/indexeddb/tutorial.html: Added.
- 3:26 AM Changeset in webkit [70631] by
-
- 31 edits4 adds in trunk
2010-10-26 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
Convert SVGRect to the new SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48204
Convert the next SVG primitive type to use the SVGPropertyTearOff concept: SVGRect.
Added new test verifying that StrictTypeChecking is enabled for SVGRect. Refactor and share code between JSC/V8/ObjC generators.
Test: svg/dom/SVGRect.html
- GNUmakefile.am: Add SVGAnimatedRect.h to build.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/scripts/CodeGenerator.pm: Refactor SVGPropertyTearOff handling, and share code between JSC/V8/ObjC generators.
- bindings/scripts/CodeGeneratorJS.pm: Ditto.
- bindings/scripts/CodeGeneratorObjC.pm: Ditto.
- bindings/scripts/CodeGeneratorV8.pm: Ditto.
- svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedRect handling.
- svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
- svg/SVGAngle.idl: Remove [SVGProperty] flag.
- svg/SVGAnimatedAngle.idl: Remove [SVGAnimatedProperty] flag.
- svg/SVGAnimatedLength.idl: Ditto.
- svg/SVGAnimatedLengthList.idl: Ditto.
- svg/SVGAnimatedRect.h: Added.
- svg/SVGFitToViewBox.h: SVGRect now uses the new tear off concept, adapt code.
- svg/SVGLength.idl: Remove [SVGProperty] flag.
- svg/SVGMarkerElement.h:
- svg/SVGPatternElement.h:
- svg/SVGRect.idl: Remove [PODType] flag, add StrictTypeChecking to all attributes.
- svg/SVGSVGElement.cpp: s/setViewBox/setViewBoxBaseValue/. (WebCore::SVGSVGElement::currentView): (WebCore::SVGSVGElement::inheritViewAttributes):
- svg/SVGSVGElement.h:
- svg/SVGSVGElement.idl: Remove [Immutable] flags for SVGRect types, no longer needed.
- svg/SVGSymbolElement.h:
- svg/SVGViewElement.h:
- svg/SVGViewSpec.cpp: Take a SVGElement as context element. (WebCore::SVGViewSpec::SVGViewSpec):
- svg/SVGViewSpec.h: Ditto. (WebCore::SVGViewSpec::contextElement):
- svg/SVGZoomEvent.idl: Remove [Immutable] flags for SVGRect types, no longer needed.
- svg/properties/SVGAnimatedPropertyMacros.h: Support declaring animated properties on non-SVGElement types (here: SVGViewSpec), just like the old macros handled it.
2010-10-26 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Rob Buis.
Convert SVGRect to the new SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48204
Added new test verifying that StrictTypeChecking is enabled for SVGRect.
- svg/dom/SVGRect-expected.txt: Added.
- svg/dom/SVGRect.html: Added.
- svg/dom/script-tests/SVGRect.js: Added.
- 3:22 AM Changeset in webkit [70630] by
-
- 5 edits3 deletes in trunk/LayoutTests
Update Windows results for vertical-text tests after r70569
- platform/win/fast/blockflow/english-rl-text-expected.checksum: Removed.
- platform/win/fast/blockflow/english-rl-text-expected.png: Removed.
- platform/win/fast/blockflow/english-rl-text-expected.txt: Removed.
- platform/win/fast/text/international/vertical-text-glyph-test-expected.checksum:
- platform/win/fast/text/international/vertical-text-glyph-test-expected.png:
- platform/win/fast/text/international/vertical-text-glyph-test-expected.txt:
- platform/win/fast/text/international/vertical-text-metrics-test-expected.txt:
- 3:21 AM Changeset in webkit [70629] by
-
- 2 edits in trunk/WebKitTools
2010-10-27 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by David Kilzer.
Convert DumpRenderTree webarchive code to CoreFoundation
https://bugs.webkit.org/show_bug.cgi?id=48278
CFPropertyListCreateWithData and CFPropertyListCreateData are only available in 10.6+.
Replace CFPropertyListCreateWithData by a combination of CFReadStreamCreateWithBytesNoCopy and CFPropertyListCreateFromStream.
Replace CFPropertyListCreateData by CFPropertyListCreateXMLData.
These changes are wrapped in BUILDING_ON_LEOPARD, as the methods are deprecated on 10.6+.
- DumpRenderTree/cf/WebArchiveDumpSupport.cpp: (createXMLStringFromWebArchiveData):
- 3:05 AM Changeset in webkit [70628] by
-
- 2 edits1 add in trunk/LayoutTests
2010-10-27 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update -- add test results for Mac after r70619.
- platform/chromium-mac/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Added.
- platform/chromium/test_expectations.txt:
- 2:28 AM Changeset in webkit [70627] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-10-27 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update -- add test results after r70619.
- platform/chromium-linux/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Added.
- platform/chromium-win/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Added.
- platform/chromium-win/fast/block/float/clear-element-too-wide-for-containing-block-expected.png: Added.
- platform/chromium-win/fast/block/float/clear-element-too-wide-for-containing-block-expected.txt: Added.
- 2:22 AM Changeset in webkit [70626] by
-
- 1 edit in branches/chromium/552/WebCore/inspector/front-end/InjectedScript.js
Merge 70565 - 2010-10-26 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: console doesn't work in closures when window is overrode
https://bugs.webkit.org/show_bug.cgi?id=48320
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):
TBR=podivilov@chromium.org
BUG=60540
- 2:13 AM Changeset in webkit [70625] by
-
- 2 edits2 copies in branches/chromium/552
Merge 69752 - 2010-10-08 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] Scripts panel: the bubble shows wrong values
https://bugs.webkit.org/show_bug.cgi?id=47358
Test: inspector/debugger-eval-on-call-frame.html
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor.): don't embrace expression evaluated in the local scope of a call frame into with(window) to avoid shadowing local variables by global ones.
2010-10-08 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] Scripts panel: the bubble shows wrong values
https://bugs.webkit.org/show_bug.cgi?id=47358
- inspector/debugger-eval-on-call-frame-expected.txt: Added.
- inspector/debugger-eval-on-call-frame.html: Added.
- 2:04 AM Changeset in webkit [70624] by
-
- 1 edit in trunk/WebCore/ChangeLog
- 2:04 AM Changeset in webkit [70623] by
-
- 1 edit in trunk/WebCore/inspector/InspectorState.h
2010-10-27 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, fix line endings in InspectorState.h
- inspector/InspectorState.h:
- 1:52 AM Changeset in webkit [70622] by
-
- 15 edits in trunk/WebCore
2010-10-27 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move frontend settings to local storage
https://bugs.webkit.org/show_bug.cgi?id=47715
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::didCommitLoad):
- inspector/InspectorController.h:
- inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
- inspector/InspectorState.h:
- inspector/front-end/ConsoleView.js:
- inspector/front-end/EventListenersSidebarPane.js:
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._createStatusbarButtons):
- inspector/front-end/Panel.js: (WebInspector.Panel):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._createStatusbarButtons):
- inspector/front-end/Settings.js: (WebInspector.Settings): (WebInspector.Settings.prototype.installApplicationSetting): (WebInspector.Settings.prototype.installProjectSetting): (WebInspector.Settings.prototype._get): (WebInspector.Settings.prototype._set): (WebInspector.Settings.prototype._getProjectSetting): (WebInspector.Settings.prototype._setProjectSetting): (WebInspector.Settings.prototype._formatProjectKey):
- inspector/front-end/StylesSidebarPane.js:
- inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSidebarPane): (WebInspector.WatchExpressionsSidebarPane.prototype.reset):
- inspector/front-end/inspector.js: (WebInspector.reset):
- 1:52 AM Changeset in webkit [70621] by
-
- 2 edits in trunk/LayoutTests
2010-10-27 Mikhail Naganov <mnaganov@chromium.org>
[Chromium] Unreviewed test expectations update.
- platform/chromium/test_expectations.txt:
- 1:19 AM Changeset in webkit [70620] by
-
- 2 edits in trunk/WebKit2
2010-10-27 Zalan Bujtas <zbujtas@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
Multiple WebPlatformStrategy initialization triggers assert in WebCore/PlatformStrategies.
Remove the code for now, as it is not used at all.
https://bugs.webkit.org/show_bug.cgi?id=48327
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate):
- 1:18 AM Changeset in webkit [70619] by
-
- 3 edits1 move3 adds3 deletes in trunk
2010-10-27 Andy Estes <aestes@apple.com>
Reviewed by David Hyatt.
Siblings of floated elements should be cleared below the float if they
are too wide to fit in the containing block.
https://bugs.webkit.org/show_bug.cgi?id=48396
Test: fast/block/float/clear-element-too-wide-for-containing-block.html
WebKit did not clear elements adjacent to floats if they were wider than
the containing block, instead keeping them on the same line and allowing
them to spill out the right side of the containing block. We should
match the spec in this regard and clear the element below the float even
if it is too wide for the containing block. Doing this seems to also
match IE's and Firefox's behavior.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::getClearDelta): Continue to compute the clear delta even if the child's minimum preferred width is greater than the containing block's available width.
2010-10-27 Andy Estes <aestes@apple.com>
Reviewed by David Hyatt.
Siblings of floated elements should be cleared below the float if they
are too wide to fit in the containing block.
https://bugs.webkit.org/show_bug.cgi?id=48396
- fast/block/float/clear-element-too-wide-for-containing-block.html: Copied from LayoutTests/fast/block/float/tableshifting.html.
- fast/block/float/tableshifting.html: Removed.
- platform/mac/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Added.
- platform/mac/fast/block/float/clear-element-too-wide-for-containing-block-expected.png: Added.
- platform/mac/fast/block/float/clear-element-too-wide-for-containing-block-expected.txt: Added.
- platform/mac/fast/block/float/tableshifting-expected.checksum: Removed.
- platform/mac/fast/block/float/tableshifting-expected.png: Removed.
- platform/mac/fast/block/float/tableshifting-expected.txt: Removed.
- 12:21 AM Changeset in webkit [70618] by
-
- 2 edits in trunk/LayoutTests
[Qt] Add some tests to the Skipeed list, because of unimplemented
LayoutTestController and EventSender features.
- platform/qt-wk2/Skipped:
