Timeline



Nov 19, 2010:

11:56 PM Changeset in webkit [72470] by commit-queue@webkit.org
  • 5 edits
    15 adds in trunk

2010-11-19 W. James MacLean <wjmaclean@chromium.org>

Reviewed by James Robinson.

Scaled Resized images are blurred when sent to Skia
https://bugs.webkit.org/show_bug.cgi?id=42370

  • platform/chromium-linux/svg/custom/image-rescale-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/image-rescale-expected.png: Added.
  • platform/chromium-linux/svg/custom/image-rescale-expected.txt: Added.
  • platform/chromium-linux/svg/custom/image-rescale-scroll-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/image-rescale-scroll-expected.png: Added.
  • platform/chromium-linux/svg/custom/image-rescale-scroll-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/custom/image-rescale-expected.checksum: Added.
  • platform/mac/svg/custom/image-rescale-expected.png: Added.
  • platform/mac/svg/custom/image-rescale-expected.txt: Added.
  • platform/mac/svg/custom/image-rescale-scroll-expected.checksum: Added.
  • platform/mac/svg/custom/image-rescale-scroll-expected.png: Added.
  • platform/mac/svg/custom/image-rescale-scroll-expected.txt: Added.
  • platform/mac/test_expectations.txt:
  • svg/custom/image-rescale-scroll.html: Added.
  • svg/custom/image-rescale.svg: Added.
  • svg/custom/resources/image-rescale.jpg: Added.

2010-11-19 W. James MacLean <wjmaclean@chromium.org>

Reviewed by James Robinson.

Scaled Resized images are blurred when sent to Skia
https://bugs.webkit.org/show_bug.cgi?id=42370

This patch modifies ImageSkia.cpp to fix the calculation of resampled
bitmap sizes so as to include the transform matrix of the canvas.
Includes a new test to catch a regression that occured the first time
this patch was applied.

Tests: svg/custom/image-rescale-scroll.html

svg/custom/image-rescale.svg

  • platform/graphics/skia/ImageSkia.cpp: (WebCore::computeResamplingMode): (WebCore::drawResampledBitmap):
11:25 PM Changeset in webkit [72469] by commit-queue@webkit.org
  • 9 edits
    5 adds in trunk

2010-11-19 Jia Pu <jpu@apple.com>

Reviewed by Dan Bernstein.

Regression: contraction is considered misspelling.
https://bugs.webkit.org/show_bug.cgi?id=49423
<rdar://problem/8654206>

  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/editing/spelling/autocorrection-contraction-expected.checksum: Added.
  • platform/mac/editing/spelling/autocorrection-contraction-expected.png: Added.
  • platform/mac/editing/spelling/autocorrection-contraction-expected.txt: Added.
  • platform/mac/editing/spelling/autocorrection-contraction.html: Added.

2010-11-19 Jia Pu <jpu@apple.com>

Reviewed by Dan Bernstein.

Regression: contraction is considered misspelling.
https://bugs.webkit.org/show_bug.cgi?id=49423
<rdar://problem/8654206>

Test: platform/mac/editing/spelling/autocorrection-contraction.html

manual-tests/autocorrection/autocorrection-contraction.html

  • editing/Editor.cpp: (WebCore::isAmbiguousBoundaryCharacter): Moved function to the top of the file so that it can be used by all other functions in the file. (WebCore::Editor::markMisspellingsAfterTypingToWord): Renamed markMisspellingsAfterTypingToPosition() to improve readability, and to pass in additional argument. Before we apply pending autocorrection, we check to see if currently typed character makes current word a partial contraction, for instance "wouldn'". If that's the case, we would not apply the pending correction. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Make sure currently typed word is not a partial contraction, such as "wouldn'", before mark it as misspelled. Also update the location of ambiguous boundary if other replacements have changed the length of the paragraph.
  • editing/Editor.h:
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::markMisspellingsAfterTyping): Adopt renamed function.
  • manual-tests/autocorrection/autocorrection-contraction.html: Added.
10:27 PM Changeset in webkit [72468] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit2

2010-11-19 Zalan Bujtas <zbujtas@gmail.com>

Reviewed by Andreas Kling.

WebUIClient::createNewPage() expects a retained WKPageRef.
https://bugs.webkit.org/show_bug.cgi?id=48549

  • UIProcess/API/qt/ClientImpl.cpp: (qt_wk_createNewPage):
9:48 PM Changeset in webkit [72467] by benjamin.poulain@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-11-19 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Transition and animation do not work with QWebView anymore
https://bugs.webkit.org/show_bug.cgi?id=49797

Accelerated compositing should not be enabled on QWebView without
texture mapper.

  • WebCoreSupport/PageClientQt.h: (WebCore::PageClientQWidget::allowsAcceleratedCompositing):
9:20 PM Changeset in webkit [72466] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-11-19 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Memory leak in QWebInspector
https://bugs.webkit.org/show_bug.cgi?id=49765

Delete QWebInspectorPrivate in ~QWebInspector()

  • Api/qwebinspector.cpp: (QWebInspector::~QWebInspector):
8:51 PM Changeset in webkit [72465] by andreas.kling@nokia.com
  • 4 edits in trunk/WebCore

2010-11-19 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

ScrollView: Make delegatesScrolling() and avoidScrollbarCreation() const.
https://bugs.webkit.org/show_bug.cgi?id=49854

  • page/FrameView.cpp: (WebCore::FrameView::delegatesScrolling): (WebCore::FrameView::avoidScrollbarCreation):
  • page/FrameView.h:
  • platform/ScrollView.h: (WebCore::ScrollView::delegatesScrolling): (WebCore::ScrollView::avoidScrollbarCreation):
8:40 PM Changeset in webkit [72464] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-11-19 William Chan <willchan@chromium.org>

Reviewed by David Levin.

Add USE(CHROMIUM_NET)

Indicates the use of Chromium's network stack. Chromium's network
stack performs better when it has full view of all resource requests,
so USE(CHROMIUM_NET) can be used to bypass throttles.

https://bugs.webkit.org/show_bug.cgi?id=49778

  • wtf/Platform.h:
7:24 PM Changeset in webkit [72463] by sfalken@apple.com
  • 1 edit in trunk/WebKitTools/MiniBrowser/win/stdafx.h

Touch file to force build.

7:09 PM Changeset in webkit [72462] by podivilov@chromium.org
  • 2 edits in trunk/WebCore

2010-11-19 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: scripts panel should be shown before execution line is scrolled into view.
https://bugs.webkit.org/show_bug.cgi?id=49792

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.debuggerPaused):
6:20 PM Changeset in webkit [72461] by andersca@apple.com
  • 5 edits in trunk/WebKit2

Add a didFail WKContextDownloadClient callback
https://bugs.webkit.org/show_bug.cgi?id=49847

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKContext.h:

Add didFail callback.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::didFail):
Call WebDownloadClient::didFail.

  • UIProcess/WebDownloadClient.cpp:

(WebKit::WebDownloadClient::didFail):
Call the didFail client function.

6:12 PM Changeset in webkit [72460] by mihaip@chromium.org
  • 4 edits in trunk/WebKitTools

2010-11-19 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

Rebaseline server: checksum-only differences and prefetching
https://bugs.webkit.org/show_bug.cgi?id=49841

Add support for image test results where the only difference is in the
checksum.

Add prefetching of the image results from the next test.

  • Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
5:52 PM Changeset in webkit [72459] by commit-queue@webkit.org
  • 14 edits
    3 adds in trunk

2010-11-19 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Chang.

[chromium] Fix whitespace character handling in complex text on linux
https://bugs.webkit.org/show_bug.cgi?id=49771

  • platform/chromium-linux/fast/text/international/bidi-linebreak-001-expected.checksum: Remove null glyph from expected output.
  • platform/chromium-linux/fast/text/international/bidi-linebreak-001-expected.png: Ditto.
  • platform/chromium-linux/fast/text/international/bidi-linebreak-001-expected.txt: Ditto.
  • platform/chromium-linux/fast/text/international/bidi-linebreak-002-expected.checksum: Ditto.
  • platform/chromium-linux/fast/text/international/bidi-linebreak-002-expected.png: Ditto.
  • platform/chromium-linux/fast/text/international/bidi-linebreak-002-expected.txt: Ditto.
  • platform/chromium-linux/fast/text/international/bidi-linebreak-003-expected.checksum: Ditto.
  • platform/chromium-linux/fast/text/international/bidi-linebreak-003-expected.png: Ditto.
  • platform/chromium-linux/fast/text/international/bidi-linebreak-003-expected.txt: Ditto.
  • platform/chromium-linux/fast/text/wide-zero-width-space-expected.checksum: Added. Now passes on Linux.
  • platform/chromium-linux/fast/text/wide-zero-width-space-expected.png: Added.
  • platform/chromium-linux/fast/text/wide-zero-width-space-expected.txt: Added.
  • platform/chromium/test_expectations.txt: Removed LINUX from wide-zero-width-space.

2010-11-19 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Chang.

[chromium] Fix whitespace character handling in complex text on linux
https://bugs.webkit.org/show_bug.cgi?id=49771

  • platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::isZeroWidthSpaceGlyph): Added. (WebCore::SimpleFontData::boundsForGlyph): Use isZeroWidthSpaceGlyph(). (WebCore::SimpleFontData::widthForGlyph): Use isZeroWidthSpaceGlyph().
  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::nextScriptRun): Cache currently used font data. (WebCore::TextRunWalker::setGlyphXPositions): Skip zero width spaces. (WebCore::TextRunWalker::normalizeSpacesAndMirrorChars): Normalize zero width spaces. (WebCore::TextRunWalker::getNormalizedTextRun):
5:49 PM Changeset in webkit [72458] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-11-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread

Add the 'worker number' and 'worker name' concepts to the
TestShellThread objects, and move test_types and test_args from
the TestRunner to the TestShellThread.

https://bugs.webkit.org/show_bug.cgi?id=49768

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
5:48 PM Changeset in webkit [72457] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-11-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

Do some minor cleanup and bug fixing.

https://bugs.webkit.org/show_bug.cgi?id=49777

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
5:43 PM Changeset in webkit [72456] by andersca@apple.com
  • 8 edits in trunk/WebKit2

Extend sandbox when downloading files
https://bugs.webkit.org/show_bug.cgi?id=49844

Reviewed by Sam Weinig.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):
Add new overload.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::decideDestinationWithSuggestedFilename):
Create a sandbox extension handle if necessary.

  • UIProcess/Downloads/DownloadProxy.messages.in:

Add a sandbox extension handle out parameter to the DecideDestinationWithSuggestedFilename message.

  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::decideDestinationWithSuggestedFilename):
Create and consume the returned sandbox extension handle.

(WebKit::Download::didFinish):
(WebKit::Download::didFail):
Invalidate the sandbox extension handles.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(-[WKDownloadAsDelegate download:shouldDecodeSourceDataOfMIMEType:]):
Whoops, fix inverted logic.

5:39 PM Changeset in webkit [72455] by dpranke@chromium.org
  • 4 edits in trunk/WebKitTools

2010-11-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

nrwt - config.build_directory() is busted

Fixes a typo that was causing us to usually return the top level
directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
bug was hidden by test stubs that were too simplistic :(.

https://bugs.webkit.org/show_bug.cgi?id=49815

  • Scripts/webkitpy/common/system/executive_mock.py:
  • Scripts/webkitpy/layout_tests/port/config.py:
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
5:15 PM Changeset in webkit [72454] by sfalken@apple.com
  • 38 edits in trunk

2010-11-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
https://bugs.webkit.org/show_bug.cgi?id=49819

2010-11-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
https://bugs.webkit.org/show_bug.cgi?id=49819

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.sln:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:

2010-11-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
https://bugs.webkit.org/show_bug.cgi?id=49819

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreGenerated.vcproj:

2010-11-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
https://bugs.webkit.org/show_bug.cgi?id=49819

  • DumpRenderTree/DumpRenderTree.sln:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
  • FindSafari/FindSafari.vcproj:
  • MiniBrowser/MiniBrowser.vcproj:
  • TestWebKitAPI/win/TestWebKitAPI.sln:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
  • WebKitAPITest/WebKitAPITest.vcproj:
  • WebKitLauncherWin/WebKitLauncherWin.vcproj:
  • WebKitTestRunner/win/InjectedBundle.vcproj:
  • WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:
  • WinLauncher/WinLauncher.vcproj:
  • record-memory-win/record-memory-win.vcproj:

2010-11-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
https://bugs.webkit.org/show_bug.cgi?id=49819

  • win/WebKit2.vcproj:
  • win/WebKit2Generated.vcproj:
  • win/WebKit2WebProcess.vcproj:
  • win/WebKit2WebProcessCommon.vsprops:
4:40 PM Changeset in webkit [72453] by Adam Roben
  • 2 edits in trunk/PlanetWebKit

Add Lucas De Marchi's blog to Planet WebKit

Reviewed by Jon Honeycutt.

  • config.ini:
4:33 PM Changeset in webkit [72452] by Adam Roben
  • 2 edits in trunk/WebKitTools

Add some more Windows slaves

This is probably more than we will be using in the immediate future,
but having some extra slave names makes experimenting with different
configurations easier.

Reviewed by Jon Honeycutt.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more

Windows slaves and distributed them among the three different Test
builders.

4:32 PM Changeset in webkit [72451] by beidson@apple.com
  • 5 edits in trunk/WebKit2

More of <rdar://problem/8613727> and https://bugs.webkit.org/show_bug.cgi?id=49836
Add WebKit2 API relevant to customization of context menus

Reviewed by Darin Adler.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameAllowsFollowingLink):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::allowsFollowingLink):

  • WebProcess/WebPage/WebFrame.h:
4:24 PM Changeset in webkit [72450] by mihaip@chromium.org
  • 2 edits
    6 adds in trunk/LayoutTests

2010-11-19 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium/Mac rebaseline.

Rebaseline tests in fast/events that have different scrollbar rendering.

  • platform/chromium-mac/fast/events/autoscroll-expected.checksum: Added.
  • platform/chromium-mac/fast/events/autoscroll-expected.png: Added.
  • platform/chromium-mac/fast/events/pointer-events-2-expected.checksum: Added.
  • platform/chromium-mac/fast/events/pointer-events-2-expected.png: Added.
  • platform/chromium-mac/fast/events/reveal-link-when-focused-expected.checksum: Added.
  • platform/chromium-mac/fast/events/reveal-link-when-focused-expected.png: Added.
  • platform/chromium/test_expectations.txt:
4:21 PM Changeset in webkit [72449] by mihaip@chromium.org
  • 2 edits
    9 adds in trunk/LayoutTests

2010-11-19 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium/Mac rebaseline.

Rebaseline tests in fast/frames that have different scrollbar rendering.

  • platform/chromium-mac/fast/frames/frame-scrolling-attribute-expected.checksum: Added.
  • platform/chromium-mac/fast/frames/frame-scrolling-attribute-expected.png: Added.
  • platform/chromium-mac/fast/frames/iframe-scrolling-attribute-expected.checksum: Added.
  • platform/chromium-mac/fast/frames/iframe-scrolling-attribute-expected.png: Added.
  • platform/chromium-mac/fast/frames/invalid-expected.checksum: Added.
  • platform/chromium-mac/fast/frames/invalid-expected.png: Added.
  • platform/chromium-mac/fast/frames/valid-expected.checksum: Added.
  • platform/chromium-mac/fast/frames/valid-expected.png: Added.
  • platform/chromium/test_expectations.txt:
4:13 PM Changeset in webkit [72448] by mihaip@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-11-19 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium/Mac rebaseline of transforms/2d/zoom-menulist.html.

  • platform/chromium-mac/transforms/2d/zoom-menulist-expected.checksum: Added.
  • platform/chromium-mac/transforms/2d/zoom-menulist-expected.png: Added.
  • platform/chromium/test_expectations.txt:
4:05 PM Changeset in webkit [72447] by mihaip@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2010-11-19 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

http/tests/loading/bad-server-subframe.html had chromium-win baselines
that made it fail consistently on Windows and Linux. It should pass with
the regular upstream baselines.

  • platform/chromium-win/http/tests/loading/bad-server-subframe-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
3:41 PM Changeset in webkit [72446] by beidson@apple.com
  • 18 edits in trunk

<rdar://problem/8613727> and https://bugs.webkit.org/show_bug.cgi?id=49836
Add WebKit2 API relevant to customization of context menus

Reviewed by Darin Adler.

WebCore:

  • WebCore.exp.in:

WebKit2:

Most of this is just exposing already-existing concepts in API.

  • Shared/API/c/WKURLRequest.cpp:

(WKURLRequestCreateWithWKURL):

  • Shared/API/c/WKURLRequest.h:
  • Shared/WebURLRequest.cpp:

(WebKit::WebURLRequest::create):

  • Shared/WebURLRequest.h:
  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:

(WKBundleHitTestResultCopyAbsoluteImageURL):
(WKBundleHitTestResultCopyAbsoluteMediaURL):
(WKBundleHitTestResultGetImageRect):
(WKBundleHitTestResultGetIsSelected):

  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageHasLocalDataForURL):
(WKBundlePageCanHandleRequest):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:

(WebKit::InjectedBundleHitTestResult::absoluteImageURL):
(WebKit::InjectedBundleHitTestResult::absoluteMediaURL):
(WebKit::InjectedBundleHitTestResult::imageRect):
(WebKit::InjectedBundleHitTestResult::isSelected):

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::hasLocalDataForURL):
(WebKit::WebPage::canHandleRequest):

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::hasLocalDataForURL): Stubbed for now.
(WebKit::WebPage::canHandleRequest): Ditto.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::hasLocalDataForURL): Ditto.
(WebKit::WebPage::canHandleRequest): Ditto.

3:08 PM Changeset in webkit [72445] by kinuko@chromium.org
  • 4 edits in trunk/WebKitTools

2010-11-19 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Ojan Vafai.

[Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
https://bugs.webkit.org/show_bug.cgi?id=49702

Re-landing r72357 with a test fix.

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2:59 PM Changeset in webkit [72444] by jparent@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, adding TIMEOUT for inspector/styles-disable-then-delete.html.

  • platform/chromium/test_expectations.txt:
2:59 PM Changeset in webkit [72443] by msaboff@apple.com
  • 4 edits in trunk

2010-11-19 Michael Saboff <msaboff@apple.com>

Reviewed by Sam Weinig

Remove DOMSVGAnimatedPathData.h from all: target to fix build.

  • MigrateHeaders.make:

2010-11-19 Michael Saboff <msaboff@apple.com>

Reviewed by Sam Weinig

Remove DOMSVGAnimatedPathData.h from all: target to fix build.

  • MigrateHeaders.make:
2:40 PM Changeset in webkit [72442] by oliver@apple.com
  • 9 edits in trunk/JavaScriptCore

2010-11-19 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Don't check for constant registers when we can guarantee that the register won't be in the constant pool
https://bugs.webkit.org/show_bug.cgi?id=49814

Add uncheckedR(int) to CallFrame, and replace all the uses of r() with uncheckedR()
when we can guarantee that the register is not referring to a constant.
This makes the interpreter about 0.5% faster, and makes the CallFrame initialisation
logic correct when we're using a faked callframe (as in the case of the globalExec).

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::createActivation):
  • debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::thisObject):
  • interpreter/CallFrame.h: (JSC::ExecState::uncheckedR):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::resolveBase): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::callEval): (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::throwException): (JSC::Interpreter::execute): (JSC::Interpreter::executeCall): (JSC::Interpreter::executeConstruct): (JSC::Interpreter::prepareForRepeatCall): (JSC::Interpreter::createExceptionScope): (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
2:37 PM Changeset in webkit [72441] by commit-queue@webkit.org
  • 6 edits in trunk

2010-11-19 Avi Drissman <avi@google.com>

Reviewed by Antonio Gomes.

Complete support for Unix editing mode
https://bugs.webkit.org/show_bug.cgi?id=49757

  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h:

2010-11-19 Avi Drissman <avi@google.com>

Reviewed by Antonio Gomes.

Complete support for Unix editing mode
https://bugs.webkit.org/show_bug.cgi?id=49757

  • DumpRenderTree/LayoutTestController.cpp: (setEditingBehaviorCallback):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setEditingBehavior):
2:32 PM WebKit Team edited by rniwa@webkit.org
Added HTML DOM to my area (diff)
2:23 PM Changeset in webkit [72440] by Darin Adler
  • 11 edits in trunk/WebKit2

2010-11-19 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Need a way to clear disk cache from WebContext
https://bugs.webkit.org/show_bug.cgi?id=49820

  • UIProcess/API/C/WKContext.cpp: (WKContextClearResourceCaches): Added. (WKContextClearApplicationCache): Added.
  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp: (WebKit::WebContext::clearResourceCaches): Added. (WebKit::WebContext::clearApplicationCache): Added.
  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::clearResourceCaches): Added. (WebKit::WebProcess::clearApplicationCache): Added.
  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in: Added messages.
  • WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformClearResourceCaches): Added.
  • WebProcess/qt/WebProcessQt.cpp: (WebKit::WebProcess::platformClearResourceCaches): Added.
  • WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::platformClearResourceCaches): Added.
2:22 PM Changeset in webkit [72439] by zmo@google.com
  • 4 edits in trunk/LayoutTests

2010-11-19 Zhenyao Mo <zmo@google.com>

Unreviewed, update webgl test expectations.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/Skipped:
2:15 PM Changeset in webkit [72438] by andersca@apple.com
  • 6 edits in trunk/WebKit2

Implement support for loading local files
https://bugs.webkit.org/show_bug.cgi?id=49828
<rdar://problem/8447121>

Reviewed by Sam Weinig.

  • UIProcess/WebPageProxy.cpp:

(WebKit::initializeSandboxExtensionHandle):
Given an URL, create a sandbox extension if it's a local file URL.

(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
Pass along sandbox extension handles to the LoadURL and LoadURLRequest messages.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
Call SandboxExtensionTracker::didStartProvisionalLoad.

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
Call SandboxExtensionTracker::didCommitProvisionalLoad.

(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
Call SandboxExtensionTracker::didFailProvisionalLoad.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::~WebPage):
Invalidate the sandbox extension tracker.

(WebKit::WebPage::close):
Invalidate the sandbox extension tracker.

(WebKit::WebPage::loadURL):
(WebKit::WebPage::loadURLRequest):
Pass the sandbox extension handle to the sandbox extension tracker.

(WebKit::WebPage::SandboxExtensionTracker::~SandboxExtensionTracker):
Invalidate the sandbox extension tracker.

(WebKit::WebPage::SandboxExtensionTracker::invalidate):
invalidate ell the sandbox extensions.

(WebKit::WebPage::SandboxExtensionTracker::beginLoad):
Create a sandbox extension and store it as the "pending provisional extension".

(WebKit::WebPage::SandboxExtensionTracker::didStartProvisionalLoad):
Consume the pending provisional extension and make it the provisional extension.

(WebKit::WebPage::SandboxExtensionTracker::didCommitProvisionalLoad):
Invalidate the committed extension and make the provisional extension the committed extension.

(WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad):
Invalidate the provisional extension.

  • WebProcess/WebPage/WebPage.messages.in:

Add SandboxExtension::Handle parameters to LoadURL and LoadURLRequest.

2:14 PM Changeset in webkit [72437] by zmo@google.com
  • 3 edits in trunk/LayoutTests

2010-11-19 Zhenyao Mo <zmo@google.com>

Unreviewed, update webgl test expectations.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
2:13 PM Changeset in webkit [72436] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-11-19 Ilya Sherman <isherman@chromium.org>

Reviewed by Darin Fisher.

Expose default value of maxLength in Chromium API
https://bugs.webkit.org/show_bug.cgi?id=49723

  • public/WebInputElement.h: Added constant defaultMaximumLength
  • src/WebInputElement.cpp:
1:52 PM Changeset in webkit [72435] by Nate Chapin
  • 3 edits
    2 adds in trunk

2010-11-19 Nate Chapin <Nate Chapin>

Reviewed by Alexey Proskuryakov.

Test for https://bugs.webkit.org/show_bug.cgi?id=49693

  • fast/loader/subresource-willSendRequest-null-expected.txt: Added.
  • fast/loader/subresource-willSendRequest-null.html: Added.

2010-11-19 Nate Chapin <Nate Chapin>

Reviewed by Alexey Proskuryakov.

Remove requests from ResourceLoadScheduler's queue before
actually starting them. We're holding a RefPtr anyway, and
the load might be terminated and removed from the queue synchronously.
https://bugs.webkit.org/show_bug.cgi?id=49693

Test: fast/loader/subresource-willSendRequest-null.html

  • loader/ResourceLoadScheduler.cpp: (WebCore::ResourceLoadScheduler::servePendingRequests):
1:50 PM Changeset in webkit [72434] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Make it possible to encode null SandboxExtension handles
https://bugs.webkit.org/show_bug.cgi?id=49825

Reviewed by Darin Adler.

  • Shared/mac/SandboxExtensionMac.mm:

(WebKit::SandboxExtension::Handle::encode):
If there's no underlying sandbox extension, just encode an empty byte array.

(WebKit::SandboxExtension::Handle::decode):
If the decoded byte array is empty, don't try to create a sandbox extension.

(WebKit::SandboxExtension::create):
If the handle is null, return null.

(WebKit::SandboxExtension::consume):
Consuming shuld not null out the underlying sandbox extension object.

1:48 PM Changeset in webkit [72433] by zmo@google.com
  • 8 edits in trunk/WebCore

2010-11-18 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Make sure is* return false if the name is never bound
https://bugs.webkit.org/show_bug.cgi?id=49767

  • html/canvas/WebGLBuffer.h: Add function to check whether the buffer has been bound before. (WebCore::WebGLBuffer::hasEverBeenBound):
  • html/canvas/WebGLFramebuffer.cpp: Ditto. (WebCore::WebGLFramebuffer::WebGLFramebuffer):
  • html/canvas/WebGLFramebuffer.h: Ditto. (WebCore::WebGLFramebuffer::hasEverBeenBound): (WebCore::WebGLFramebuffer::setBound):
  • html/canvas/WebGLRenderbuffer.cpp: Ditto. (WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
  • html/canvas/WebGLRenderbuffer.h: Ditto. (WebCore::WebGLRenderbuffer::hasEverBeenBound): (WebCore::WebGLRenderbuffer::setBound):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::bindFramebuffer): Set bound status to true. (WebCore::WebGLRenderingContext::bindRenderbuffer): Ditto. (WebCore::WebGLRenderingContext::isBuffer): Return false if it's never bound. (WebCore::WebGLRenderingContext::isFramebuffer): Ditto. (WebCore::WebGLRenderingContext::isRenderbuffer): Ditto. (WebCore::WebGLRenderingContext::isTexture): Ditto.
  • html/canvas/WebGLTexture.h: Add function to check whether the texture has been bound before. (WebCore::WebGLTexture::hasEverBeenBound):
1:15 PM Changeset in webkit [72432] by benjamin.poulain@nokia.com
  • 2 edits in trunk/WebCore

2010-11-19 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] mask-box-image renders wrong in certain conditions
https://bugs.webkit.org/show_bug.cgi?id=43476

Qt does not follow the same convention as the other port
when rendering a pixmap with null width of height. When one
of those dimension is null, we should ignore the painting call
to behave like the other ports.

  • platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern):
1:03 PM Changeset in webkit [72431] by zmo@google.com
  • 8 edits in trunk

2010-11-18 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

GraphicsContext3D::reshape is clearing using current clear color instead of transparent
https://bugs.webkit.org/show_bug.cgi?id=44064

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::reshape): Use 0 as clear values.

2010-11-18 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

GraphicsContext3D::reshape is clearing using current clear color instead of transparent
https://bugs.webkit.org/show_bug.cgi?id=44064

  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::reset): Use 0 as clear values.
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::reshape): Ditto.

2010-11-18 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

GraphicsContext3D::reshape is clearing using current clear color instead of transparent
https://bugs.webkit.org/show_bug.cgi?id=44064

  • fast/canvas/webgl/renderbuffer-initialization-expected.txt:
  • fast/canvas/webgl/renderbuffer-initialization.html: Test that o is used as the clear values instead of the current gl clear values.
12:59 PM Changeset in webkit [72430] by bweinstein@apple.com
  • 4 edits in trunk/LayoutTests

Rebaseline fast/blockflow results for Windows after r72347.

  • platform/win/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
  • platform/win/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
  • platform/win/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
12:48 PM Changeset in webkit [72429] by bweinstein@apple.com
  • 1 edit
    48 deletes in trunk/LayoutTests

Fix failing Windows ruby tests by removing the Windows-specific results. These were the same as the Mac
results before r72347, and that change rebaselined the results in LayoutTests/platform/mac, making these
not match anymore, and causing the Windows tests to fail.

  • platform/win/fast/ruby/ruby-empty-rt-expected.checksum: Removed.
  • platform/win/fast/ruby/ruby-empty-rt-expected.png: Removed.
  • platform/win/fast/ruby/ruby-empty-rt-expected.txt: Removed.
  • platform/win/fast/ruby/ruby-length-expected.checksum: Removed.
  • platform/win/fast/ruby/ruby-length-expected.png: Removed.
  • platform/win/fast/ruby/ruby-length-expected.txt: Removed.
  • platform/win/fast/ruby/ruby-run-break-expected.checksum: Removed.
  • platform/win/fast/ruby/ruby-run-break-expected.png: Removed.
  • platform/win/fast/ruby/ruby-run-break-expected.txt: Removed.
  • platform/win/fast/ruby/ruby-runs-expected.checksum: Removed.
  • platform/win/fast/ruby/ruby-runs-expected.png: Removed.
  • platform/win/fast/ruby/ruby-runs-expected.txt: Removed.
  • platform/win/fast/ruby/ruby-runs-spans-expected.checksum: Removed.
  • platform/win/fast/ruby/ruby-runs-spans-expected.png: Removed.
  • platform/win/fast/ruby/ruby-runs-spans-expected.txt: Removed.
  • platform/win/fast/ruby/ruby-simple-expected.checksum: Removed.
  • platform/win/fast/ruby/ruby-simple-expected.png: Removed.
  • platform/win/fast/ruby/ruby-simple-expected.txt: Removed.
  • platform/win/fast/ruby/ruby-simple-rp-expected.checksum: Removed.
  • platform/win/fast/ruby/ruby-simple-rp-expected.png: Removed.
  • platform/win/fast/ruby/ruby-simple-rp-expected.txt: Removed.
  • platform/win/fast/ruby/ruby-trailing-expected.checksum: Removed.
  • platform/win/fast/ruby/ruby-trailing-expected.png: Removed.
  • platform/win/fast/ruby/ruby-trailing-expected.txt: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-rt-expected.checksum: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-rt-expected.png: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-rt-expected.txt: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-text1-expected.checksum: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-text1-expected.png: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-text1-expected.txt: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-text2-expected.checksum: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-text2-expected.png: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-text2-expected.txt: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-text3-expected.checksum: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-text3-expected.png: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-text3-expected.txt: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-rt1-expected.checksum: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-rt1-expected.png: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-rt1-expected.txt: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-rt2-expected.checksum: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-rt2-expected.png: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-rt2-expected.txt: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-text1-expected.checksum: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-text1-expected.png: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-text1-expected.txt: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-text2-expected.checksum: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-text2-expected.png: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-text2-expected.txt: Removed.
12:47 PM Changeset in webkit [72428] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix run-javascriptcore-tests when there's a space in the path to testapi

Reviewed by Sam Weinig.

  • Scripts/run-javascriptcore-tests: Use an indirect object when calling

system() to force it to interpret spaces in the path correctly.

12:46 PM Changeset in webkit [72427] by Adam Roben
  • 4 edits in trunk/WebKitTools

Update scripts for .exe name changes after r72327

As of r72327, the "_debug" suffix is only used in Debug_All builds.

Reviewed by Sam Weinig.

  • Scripts/run-javascriptcore-tests:

(testapiPath):

  • Scripts/sunspider-compare-results:

(pathToBuiltJSC):

  • Scripts/webkitdirs.pm:

(jscPath):
(safariPath):

12:27 PM Changeset in webkit [72426] by crogers@google.com
  • 2 edits in trunk/WebCore

2010-11-19 Chris Rogers <crogers@google.com>

Reviewed by Darin Adler.

AudioContext should not include "HTMLNames.h"
https://bugs.webkit.org/show_bug.cgi?id=49680

No new tests since audio API is not yet implemented.

  • webaudio/AudioContext.cpp:
12:22 PM Changeset in webkit [72425] by sfalken@apple.com
  • 25 edits in trunk

2010-11-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Normalize Cairo/CFLite project/solution configuration names
https://bugs.webkit.org/show_bug.cgi?id=49818

2010-11-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Normalize Cairo/CFLite project/solution configuration names
https://bugs.webkit.org/show_bug.cgi?id=49818

  • WebKit.vcproj/WebKit.sln:
  • WebKit.vcproj/WebKit.vcproj:

2010-11-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Normalize Cairo/CFLite project/solution configuration names
https://bugs.webkit.org/show_bug.cgi?id=49818

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreGenerated.vcproj:

2010-11-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Normalize Cairo/CFLite project/solution configuration names
https://bugs.webkit.org/show_bug.cgi?id=49818

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
  • MiniBrowser/MiniBrowser.vcproj:
  • TestWebKitAPI/win/TestWebKitAPI.sln:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • WebKitAPITest/WebKitAPITest.vcproj:
  • WebKitTestRunner/win/InjectedBundle.vcproj:
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:
  • WinLauncher/WinLauncher.vcproj:
  • Scripts/webkitdirs.pm: Updated cairo build configs.

2010-11-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Normalize Cairo/CFLite project/solution configuration names
https://bugs.webkit.org/show_bug.cgi?id=49818

  • win/WebKit2.vcproj:
  • win/WebKit2WebProcess.vcproj:
12:20 PM Changeset in webkit [72424] by jparent@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, remove suppression for svg/dom/fuzz-path-parser.html

  • platform/chromium/test_expectations.txt:
12:08 PM Changeset in webkit [72423] by dbates@webkit.org
  • 2 edits in trunk/WebCore

2010-11-19 Daniel Bates <dbates@rim.com>

Reviewed by Antonio Gomes.

Replace null checks of newParent in Frame::transferChildFrameToNewDocument() with ASSERT
https://bugs.webkit.org/show_bug.cgi?id=49489

Substitute ASSERT(newParent) for null-checks for newParent in
Frame::transferChildFrameToNewDocument() since newParent is
never null.

When Frame::transferChildFrameToNewDocument() is called the child
frame's owner element has already been transferred to the new
document D and D is attached (i.e. has a frame).

  • page/Frame.cpp: (WebCore::Frame::transferChildFrameToNewDocument):
12:01 PM Changeset in webkit [72422] by andersca@apple.com
  • 10 edits
    2 adds in trunk

Add SandboxExtension abstraction and use it for the injected bundle extension
https://bugs.webkit.org/show_bug.cgi?id=49817

Reviewed by Sam Weinig.

WebCore:

Export fileSystemRepresentation symbol needed by WebKit2.

  • WebCore.exp.in:

WebKit2:

  • Shared/SandboxExtension.h:

Add SandboxExtension abstraction.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Instead of encoding/decoding a token, encode/decode the sandbox extension handle.

  • Shared/mac/SandboxExtensionMac.mm: Added.

Add Mac implementation of SandboxExtension.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess):
Create a SandboxExtension::Handle object.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/InjectedBundle/InjectedBundle.h:

(WebKit::InjectedBundle::setSandboxExtension):
Set the sandbox extension.

  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:

(WebKit::InjectedBundle::load):
Consume the sandbox extension.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
Create a sandbox extension and set it on the injected bundle.

11:21 AM Changeset in webkit [72421] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-11-19 Tony Chang <tony@chromium.org>

Unreviewed, updating Chromium DEPS to try and fix the chromium win build.

11:06 AM Changeset in webkit [72420] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Windows build fix. Remove leftover Debug_Internal use.

  • WebCore.vcproj/WebCore.vcproj:
10:52 AM Changeset in webkit [72419] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, remove suppression for fast/repaint/inline-block-overflow.html.

  • platform/chromium/test_expectations.txt:
10:37 AM Changeset in webkit [72418] by sfalken@apple.com
  • 26 edits
    6 adds in trunk

2010-11-18 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Windows vcproj configuration names should be normalized across projects
https://bugs.webkit.org/show_bug.cgi?id=49776

2010-11-18 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Windows vcproj configuration names should be normalized across projects
https://bugs.webkit.org/show_bug.cgi?id=49776

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.sln:

2010-11-18 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Windows vcproj configuration names should be normalized across projects
https://bugs.webkit.org/show_bug.cgi?id=49776

  • WebCore.vcproj/WebCore.sln:
  • WebCore.vcproj/WebCore.submit.sln:
  • WebCore.vcproj/WebCoreGenerated.vcproj:
  • WebCore.vcproj/WebCoreGeneratedCairo.vsprops: Added.
  • WebCore.vcproj/WebCoreGeneratedCommon.vsprops: Added.

2010-11-18 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Windows vcproj configuration names should be normalized across projects
https://bugs.webkit.org/show_bug.cgi?id=49776

  • DumpRenderTree/DumpRenderTree.sln:
  • FindSafari/FindSafari.vcproj:
  • TestWebKitAPI/win/TestWebKitAPI.sln:
  • TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
  • TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
  • WebKitAPITest/WebKitAPITest.vcproj:
  • WebKitAPITest/WebKitAPITestCommon.vsprops:
  • WebKitLauncherWin/WebKitLauncherWin.vcproj:
  • WebKitTestRunner/WebKitTestRunner.sln:
  • WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
  • WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
  • record-memory-win/record-memory-win.vcproj:

2010-11-18 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Windows vcproj configuration names should be normalized across projects
https://bugs.webkit.org/show_bug.cgi?id=49776

  • win/WebKit2.submit.sln:
  • win/WebKit2Generated.vcproj:
  • win/WebKit2GeneratedCommon.vsprops: Added.
10:29 AM Changeset in webkit [72417] by tony@chromium.org
  • 5 edits in trunk

2010-11-19 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] Enable webkit's TestNetscapePlugIn for DRT on win and linux
https://bugs.webkit.org/show_bug.cgi?id=49706

  • platform/chromium/drt_expectations.txt:

2010-11-19 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] Enable webkit's TestNetscapePlugIn for DRT on win and linux
https://bugs.webkit.org/show_bug.cgi?id=49706

It is enabled simply by copying the plugin into
{Debug,Release}/plugins. This change also rolls in a version of
Chromium that disables the old plugin.

  • WebKit.gyp:
10:23 AM Changeset in webkit [72416] by mihaip@chromium.org
  • 2 edits in trunk

2010-11-19 Mihai Parparita <mihaip@chromium.org>

Add recent upstream Chromium dependencies to .gitignore.

  • .gitignore:
10:19 AM Changeset in webkit [72415] by commit-queue@webkit.org
  • 14 edits in trunk

2010-11-19 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Add unloadEventStart
https://bugs.webkit.org/show_bug.cgi?id=49101

  • fast/dom/Window/window-properties-performance-expected.txt:
  • fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): (checkTimingWhileDeferred): (checkWebTimingWhileAsync): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
  • fast/dom/webtiming-document-open-expected.txt:
  • fast/dom/webtiming-expected.txt:
  • fast/dom/webtiming-navigate-within-document-expected.txt:

2010-11-19 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Add unloadEventStart
https://bugs.webkit.org/show_bug.cgi?id=49101

  • loader/DocumentLoadTiming.h: (WebCore::DocumentLoadTiming::DocumentLoadTiming):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): Use dispatchTimedEvent().
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent): Use dispatchTimedEvent(). (WebCore::DOMWindow::dispatchTimedEvent): Added.
  • page/DOMWindow.h:
  • page/Timing.cpp: (WebCore::Timing::unloadEventStart):
  • page/Timing.h:
  • page/Timing.idl:
10:08 AM Changeset in webkit [72414] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, remove a suppression for svg/dom/svglist-exception-on-out-bounds-error.html

  • platform/chromium/test_expectations.txt:
10:02 AM Changeset in webkit [72413] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-11-19 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] fast/text/international tests are flaky on the bots
https://bugs.webkit.org/show_bug.cgi?id=49781

Beef up the == operator overload for Freetype FontPlatformData. Before
if two FontPlatformDatas had hash values which fell into the same bucket
and were similar enough, they would be evaluated as being equal, leading
to failures.

No new tests for this change. It's very hard to test, because it depends
on the memory address of new allocations. Hopefully flakiness on the bots
will go away after patch.

  • platform/graphics/freetype/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::operator==): Beef up the == operator overload.
9:34 AM Changeset in webkit [72412] by benjamin.poulain@nokia.com
  • 2 edits in trunk/WebCore

2010-11-19 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] mask-box-image renders wrong in certain conditions
https://bugs.webkit.org/show_bug.cgi?id=43476

When rendering a pixmap with a dest rect having a null dimension,
Qt uses the dimension of the Pixmap. The other ports do not render
anything by convention.

This patch change BitmapImage to follow the convention of other ports and do not
paint anything.

  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
9:16 AM Changeset in webkit [72411] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-11-19 Patrick Gansterer <Patrick Gansterer>

Unreviewed, build fix after r72360.

  • bytecode/CodeBlock.h: (JSC::CodeBlock::bytecodeOffset):
9:01 AM Changeset in webkit [72410] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Temporary suppression for fast/repaint/inline-block-overflow.html
See r72405.
It needs Chromium's images.

  • platform/chromium/test_expectations.txt:
8:51 AM Changeset in webkit [72409] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-11-19 Sam Magnuson <smagnuso@gmail.com>

Reviewed by Andreas Kling.

[Qt] Compile with QT_NO_UNDOCOMMAND
https://bugs.webkit.org/show_bug.cgi?id=49752

  • WebCoreSupport/EditCommandQt.cpp: (EditCommandQt::EditCommandQt):
  • WebCoreSupport/EditCommandQt.h:
8:51 AM Changeset in webkit [72408] by aestes@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

svg/batik/text/smallFonts.svg needs Leopard-specific results after
r72141.

  • platform/mac-leopard/svg/batik/text/smallFonts-expected.txt: Added.
8:45 AM Changeset in webkit [72407] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Temporary suppression for fast/images/imagemap-focus-ring-zoom.html.
See r72402.
It needs Chromium's images.

  • platform/chromium/test_expectations.txt:
8:41 AM Changeset in webkit [72406] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

Skip failing tests on the Leopard bots.

  • platform/mac-leopard/Skipped:
8:27 AM Changeset in webkit [72405] by Nikolas Zimmermann
  • 10 edits in trunk/WebCore

2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Don't call invalidateSVGAttributes() from the setFooBaseValue() methods
https://bugs.webkit.org/show_bug.cgi?id=49807

Covered by existing tests.

  • svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): Use setFooBaseValue(newList) instead of fooBaseValue() = newList;
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::parseMappedAttribute): Ditto.
  • svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute): Ditto.
  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::parseMappedAttribute): Ditto.
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::parseMappedAttribute): Ditto.
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::parseMappedAttribute): Ditto.
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::parseMappedAttribute): Ditto.
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::parseMappedAttribute): Ditto.
  • svg/properties/SVGAnimatedPropertyMacros.h: Don't call invalidateSVGAttributes() in setFooBaseValue().
8:21 AM Changeset in webkit [72404] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, nuking now unnecessary suppression.

  • platform/chromium/test_expectations.txt:
8:16 AM Changeset in webkit [72403] by commit-queue@webkit.org
  • 7 edits in trunk

2010-11-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72399.
http://trac.webkit.org/changeset/72399
https://bugs.webkit.org/show_bug.cgi?id=49805

Broke Chromium build (Requested by antonm_ on #webkit).

  • page/chromium/ChromeClientChromium.h:
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::showExternal): (WebCore::PopupListBox::layout): (WebCore::PopupMenuChromium::show):
  • platform/chromium/PopupMenuChromium.h:

2010-11-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72399.
http://trac.webkit.org/changeset/72399
https://bugs.webkit.org/show_bug.cgi?id=49805

Broke Chromium build (Requested by antonm_ on #webkit).

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::popupOpened):
  • src/ChromeClientImpl.h:
8:05 AM Changeset in webkit [72402] by yael.aharon@nokia.com
  • 3 edits
    4 adds in trunk

2010-11-19 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Focus ring in image maps does not take zooming into account
https://bugs.webkit.org/show_bug.cgi?id=49625

  • fast/images/imagemap-focus-ring-zoom.html: Added.
  • platform/mac/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
  • platform/mac/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
  • platform/mac/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.

2010-11-19 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Focus ring in image maps does not take zooming into account
https://bugs.webkit.org/show_bug.cgi?id=49625

Take pageZoomFactor into account when calculating the path of the focus ring.

Test: fast/images/imagemap-focus-ring-zoom.html

  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::getPath):
7:47 AM Changeset in webkit [72401] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Crash in WebKit::PluginView::manualLoadDidReceiveResponse when navigating to a .wav file in WebKit2 on Mac
https://bugs.webkit.org/show_bug.cgi?id=48559
<rdar://problem/8606622>

Reviewed by Adam Roben.

Add null checks for m_plugin.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::manualLoadDidReceiveResponse):
(WebKit::PluginView::manualLoadDidReceiveData):
(WebKit::PluginView::manualLoadDidFinishLoading):
(WebKit::PluginView::manualLoadDidFail):

7:44 AM Changeset in webkit [72400] by Nikolas Zimmermann
  • 3 edits
    2 adds in trunk

2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGTransformList::consolidate() fails on empty lists
https://bugs.webkit.org/show_bug.cgi?id=49619

Return null in consolidate() when the list is empty, according to SVG 1.1.

Test: svg/dom/SVGTransformList-empty-list-consolidation.html

  • svg/properties/SVGTransformListPropertyTearOff.h: (WebCore::SVGTransformListPropertyTearOff::consolidate):

2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGTransformList::consolidate() fails on empty lists
https://bugs.webkit.org/show_bug.cgi?id=49619

  • svg/dom/SVGTransformList-empty-list-consolidation-expected.txt: Added.
  • svg/dom/SVGTransformList-empty-list-consolidation.html: Added.
7:38 AM Changeset in webkit [72399] by jcivelli@chromium.org
  • 7 edits in trunk

2010-11-19 Jay Civelli <jcivelli@chromium.org>

Reviewed by David Levin.

[chromium] Removing the now unused code to show popup externally on Mac.
https://bugs.webkit.org/show_bug.cgi?id=49747

  • page/chromium/ChromeClientChromium.h:
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showPopup): (WebCore::PopupListBox::layout): (WebCore::PopupMenuChromium::show):
  • platform/chromium/PopupMenuChromium.h:

2010-11-19 Jay Civelli <jcivelli@chromium.org>

Reviewed by David Levin.

Removing unused code to show popup externally on Mac.
https://bugs.webkit.org/show_bug.cgi?id=49747

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::popupOpened):
  • src/ChromeClientImpl.h:
7:34 AM Changeset in webkit [72398] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-11-18 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: reduce the footprint of InspectorBackendDispatcher.
InspectorBackendDispatcher is a generated file.
Its content is not optimal and loc may be reduced by a quarter.
In each generated function we have a code for getting 'in' values from
the arguments properties object. I've extracted this code into separate getters.
The side effect is better readability of the generated code.

https://bugs.webkit.org/show_bug.cgi?id=49729

  • inspector/CodeGeneratorInspector.pm:
7:14 AM Changeset in webkit [72397] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] REGRESSION (r72351): fast/profiler/throw-exception-from-eval.html fails
https://bugs.webkit.org/show_bug.cgi?id=49801

[Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=49802

  • platform/qt/Skipped: Add failing tests to the Skipped list until fix.
    • fast/profiler/throw-exception-from-eval.html
    • http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write.html
    • http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url.html
    • http/tests/security/aboutBlank/xss-DENIED-set-opener.html
7:06 AM Changeset in webkit [72396] by commit-queue@webkit.org
  • 5 edits in trunk

2010-11-19 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Reentrant Geolocation tests crash with an assertion.
https://bugs.webkit.org/show_bug.cgi?id=39908

PositionErrors should not be sent to Geolocation watches or one
shots that are due to receive a valid cached position. Re-enable
fast/dom/Geolocation/maximum-age.html on Mac WebKit.

  • platform/mac/Skipped:

2010-11-19 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Reentrant Geolocation tests crash with an assertion.
https://bugs.webkit.org/show_bug.cgi?id=39908

PositionErrors should not be sent to Geolocation watches or one shots
that are due to receive a valid cached position.

Test: fast/dom/Geolocation/maximum-age.html

  • page/Geolocation.cpp: (WebCore::Geolocation::sendError): (WebCore::Geolocation::copyCachedNotifiers): (WebCore::Geolocation::handleError):
  • page/Geolocation.h:
6:57 AM Changeset in webkit [72395] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, next batch of Chromium suppressions for layout test failures after
http://trac.webkit.org/changeset/72381.

  • platform/chromium/test_expectations.txt:
6:42 AM Changeset in webkit [72394] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-19 Sam Magnuson <smagnuso@gmail.com>

Reviewed by Laszlo Gombos.

[Qt] Compile with QT_NO_CLIPBOARD
https://bugs.webkit.org/show_bug.cgi?id=49742

  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::canSmartReplace):
6:38 AM Changeset in webkit [72393] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, removing duplicate expectation.

  • platform/chromium/test_expectations.txt:
6:26 AM Changeset in webkit [72392] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-11-19 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: flip chromium version to mitigate two-sided patch impact.

  • DEPS:
6:21 AM Changeset in webkit [72391] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Upstreaming Chromium suppressions.

  • platform/chromium/test_expectations.txt:
6:15 AM Changeset in webkit [72390] by Nikolas Zimmermann
  • 9 edits in trunk/WebCore

2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Remove more unused V8/SVG code
https://bugs.webkit.org/show_bug.cgi?id=49800

Remove DOMSVGObjectWithContextMap and all usages.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::DOMDataStore): (WebCore::DOMDataStore::getDOMWrapperMap):
  • bindings/v8/DOMDataStore.h: (WebCore::DOMDataStore::domSvgElementInstanceMap):
  • bindings/v8/ScopedDOMDataStore.cpp: (WebCore::ScopedDOMDataStore::ScopedDOMDataStore): (WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):
  • bindings/v8/StaticDOMDataStore.cpp: (WebCore::StaticDOMDataStore::StaticDOMDataStore):
  • bindings/v8/StaticDOMDataStore.h:
  • bindings/v8/V8DOMMap.cpp: (WebCore::removeAllDOMObjectsInCurrentThread):
  • bindings/v8/V8DOMMap.h:
6:13 AM Changeset in webkit [72389] by zherczeg@webkit.org
  • 3 edits
    4 adds in trunk

createImageBuffer fail should be handled in the same way as other fails
https://bugs.webkit.org/show_bug.cgi?id=49799

Reviewed by Nikolas Zimmermann.

WebCore:

When createImageBuffer fails (i.e the image width or height is less than
0.5, which is rounded to 0) it just returs with false. Since the m_filter
hash map is not updated in this case, the filter image is not drawn.

Test: svg/filters/filter-rounding-issues.svg

  • rendering/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource):

LayoutTests:

  • platform/mac/svg/filters/filter-rounding-issues-expected.checksum: Added.
  • platform/mac/svg/filters/filter-rounding-issues-expected.png: Added.
  • svg/filters/filter-rounding-issues-expected.txt: Added.
  • svg/filters/filter-rounding-issues.svg: Added.
6:08 AM Changeset in webkit [72388] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, next batch of Chromium suppressions for layout test failures after
http://trac.webkit.org/changeset/72381.

  • platform/chromium/test_expectations.txt:
5:58 AM Changeset in webkit [72387] by Nikolas Zimmermann
  • 9 edits
    9 deletes in trunk/WebCore

2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Remove old style SVG DOM JS bindings and DeprecatedSVGAnimated* files
https://bugs.webkit.org/show_bug.cgi?id=49796

Just remove the old style SVG DOM JS bindings, now that everything has been converted to the new concept.

  • GNUmakefile.am: Remove SVGList/SVGListTraits/JSSVGPODListCustom/JSSVGPODTypeWrapper/JSSVGContextCache and V8SVGPODTypeWrapper files.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSSVGContextCache.h: Removed.
  • bindings/js/JSSVGPODListCustom.h: Removed.
  • bindings/js/JSSVGPODTypeWrapper.h: Removed.
  • bindings/v8/V8Proxy.cpp: Remove SVG specific context cache code, which is no longer needed.
  • bindings/v8/V8Proxy.h: Ditto.
  • bindings/v8/V8SVGPODTypeWrapper.h: Removed.
  • svg/DeprecatedSVGAnimatedProperty.h: Removed.
  • svg/DeprecatedSVGAnimatedPropertyTraits.h: Removed.
  • svg/DeprecatedSVGAnimatedTemplate.h: Removed.
  • svg/SVGElement.h: Remove DeprecatedSVGAnimated* include, which pulled in SVGNames.h for every file.
  • svg/SVGList.h: Removed.
  • svg/SVGListTraits.h: Removed.
5:33 AM Changeset in webkit [72386] by apavlov@chromium.org
  • 4 edits in trunk/WebCore

2010-11-19 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Crash on opening WebInspector for a page with CSS containing @media with nested rules
https://bugs.webkit.org/show_bug.cgi?id=49731

Temporarily disable building of styles for nested rules.

  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::buildObjectForRule): (WebCore::InspectorStyleSheet::buildObjectForStyle): (WebCore::InspectorStyleSheet::ensureParsedDataReady): (WebCore::InspectorStyleSheet::ensureSourceData):
  • inspector/InspectorStyleSheet.h:
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._rebuildUpdate): (WebInspector.StylesSidebarPane.prototype._refreshStyleRules): (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
5:30 AM Changeset in webkit [72385] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, suppressing Chromium layout test failures after
http://trac.webkit.org/changeset/72381.

  • platform/chromium/test_expectations.txt:
5:20 AM Changeset in webkit [72384] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix Qt build.

  • WebCore.pro: Move SVGPathSegListPropertyTearOff.cpp from HEADERS to SOURCES list. This got lost, when reapplying the patch from the bug - I only fixed it locally before landing the first time.
5:19 AM Changeset in webkit [72383] by antonm@chromium.org
  • 2 edits
    14 adds in trunk/LayoutTests

Not reviewed, rebaselining vertical text tests for Chromium.

  • platform/chromium-linux/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
  • platform/chromium-win/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
  • platform/chromium-win/fast/blockflow/vertical-align-table-baseline-expected.txt: Added.
  • platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
  • platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
5:00 AM Changeset in webkit [72382] by alex
  • 2 edits in trunk/LayoutTests

2010-11-19 Alejandro G. Castro <alex@igalia.com>

Unreviewed, added the font-size-zero.html test to skipped and
uploaded the bug: https://bugs.webkit.org/show_bug.cgi?id=49793

It was added with r72327.

  • platform/gtk/Skipped:
4:54 AM Changeset in webkit [72381] by Nikolas Zimmermann
  • 73 edits
    44 adds
    15 deletes in trunk

2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=49580

SVGPathElement.cloneNode loses generated pathSegList
https://bugs.webkit.org/show_bug.cgi?id=43388

SVG Path elements are not correctly updated through pathSegList manipulation on relative values
https://bugs.webkit.org/show_bug.cgi?id=30219

Changing an SVGPathSeg does not update a following Smooth Cubic Curveto
https://bugs.webkit.org/show_bug.cgi?id=19741

SVGPathElement should only build SVGPathSeg* list on demand
https://bugs.webkit.org/show_bug.cgi?id=10827

Tests: svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg

svg/dom/SVGPathSegList-appendItem.xhtml
svg/dom/SVGPathSegList-clear-and-initialize.xhtml
svg/dom/SVGPathSegList-cloning.html
svg/dom/SVGPathSegList-insertItemBefore.xhtml
svg/dom/SVGPathSegList-removeItem.xhtml
svg/dom/SVGPathSegList-replaceItem.xhtml
svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml
svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml
svg/dom/SVGPathSegList-segment-modification.svg

Convert SVGPathSeg*/SVGPathSegList to the new SVG(Animated)PropertyTearOff concept.
Unlike all other SVG* types that use the SVGPropertyTearOff concept, SVGPathSegs are already refcounted,
and don't need to be wrapped in SVGPropertyTearOff objects. The consequence is that SVGPathSegs need to track
themselves to which list and path element they belong. Introduce new SVGAnimatedPathSegListPropertyTearOff
and SVGPathSegListPropertyTearOff classes, that encapsulate the special needed for SVGPathSegList.

Each SVGPathSeg now needs to store a RefPtr<SVGPathElement> - this makes it impossible to use SVGPathSegList
to represent the 'd' attribute internally in SVGPathElement. SVGPathSegList is now only used in the SVG DOM bindings
if someone explicitely requests 'pathElement.pathSegList' (eg. via JS). Switch to use SVGPathByteStream to store
the 'd' attribute data in SVGPathElement, which is much more compact, and less memory intensive.
Dirk already prepared SVGPathParserFactory some months ago, which allows easy conversion between
String/Path/SVGPathSegList/SVGPathByteStream in all directions, including normalizing the lists, when requested.

As consequence SVGPathSegList is now only built on demand, when explicitely requested. Using the SVGAnimatedProperty
concept gives us 'd' attribute <-> SVGPathSegList synchronization for free, fixing several bugs, listed above.

  • Android.mk: Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp from build.
  • CMakeLists.txt: Ditto.
  • DerivedSources.make: Remove SVGAnimatedPathData IDL generation.
  • GNUmakefile.am: Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp from build.
  • WebCore.gyp/WebCore.gyp: Remove SVGAnimatedPathData IDL generation.
  • WebCore.gypi: Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp from build.
  • WebCore.order: Remove no-longer existant SVGAnimatedPathData symbols.
  • WebCore.pro: Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp / JSSVGPathSegCustom.* from build.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Remove JSSVGPathSegCustom.cpp from build.
  • bindings/js/JSDOMBinding.cpp: Adapt to toJS() changes, remove context parameter. (WebCore::setDOMException):
  • bindings/js/JSDOMBinding.h: Remove obsolete CREATE_SVG_OBJECT_WRAPPER macro, the context parameter is not existant anymore.
  • bindings/js/JSSVGPathSegCustom.cpp: Replace CREATE_SVG_OBJECT_WRAPPER by CREATE_DOM_OBJECT_WRAPPER. Remove context parameter/handling. (WebCore::toJS):
  • bindings/js/JSSVGPathSegListCustom.cpp: Removed.
  • bindings/scripts/CodeGenerator.pm: Map 'SVGPathSegList' IDL type to SVG 'SVGPathSegListPropertyTearOff' native type.
  • bindings/scripts/CodeGeneratorJS.pm: Remove IsSVGTypeNeedingContextParameter() methods and usages. Handle SVGPathSegListPropertyTearOff.
  • bindings/scripts/CodeGeneratorObjC.pm: Handle SVGPathSegListPropertyTearOff.
  • bindings/scripts/CodeGeneratorV8.pm: Remove IsSVGTypeNeedingContextParameter() methods and usages.
  • rendering/SVGRenderTreeAsText.cpp: Build path string from byte stream, not path segment list. (WebCore::operator<<):
  • svg/SVGAllInOne.cpp: Remove obsolete cpp files.
  • svg/SVGAnimatedPathData.cpp: Removed.
  • svg/SVGAnimatedPathData.h: Removed.
  • svg/SVGAnimatedPathData.idl: Removed.
  • svg/SVGPathElement.cpp: Build SVGPathList on demand. Use SVGPathByteStream to parse/store the 'd' attribute content. (WebCore::SVGPathElement::SVGPathElement): (WebCore::SVGPathElement::getPathSegAtLength): Use SVGPathByteStream, not SVGPathSegList to determine the getPathSegAtLength() information. (WebCore::SVGPathElement::createSVGPathSegClosePath): Pass SVGPathElement to SVGPathSeg and a SVGPathSegRole parameter and store it to track the list origin. (WebCore::SVGPathElement::createSVGPathSegMovetoAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegMovetoRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegLinetoAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegLinetoRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegArcAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegArcRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel): Ditto. (WebCore::SVGPathElement::parseMappedAttribute): Build SVGPathByteStream from 'd' attribute, not a SVGPathSegList. (WebCore::SVGPathElement::svgAttributeChanged): If a SVGPathSegList object has been built, synchronize it with the 'd' attribute. (WebCore::SVGPathElement::synchronizeProperty): Synchronize 'd' attribute with the SVGPathSegList, if needed. (WebCore::SVGPathElement::synchronizeD): Added. (WebCore::SVGPathElement::pathSegList): Use same trick as in SVGPolyElement to expose the 'pathSegList' / 'animatedPathSegList' object to the SVG DOM bindings. (WebCore::SVGPathElement::normalizedPathSegList): Ditto. (WebCore::SVGPathElement::animatedPathSegList): Ditto. (WebCore::SVGPathElement::animatedNormalizedPathSegList): Ditto. (WebCore::SVGPathElement::toPathData): Build 'Path' object from SVGPathByteStream, not from SVGPathSegList. (WebCore::SVGPathElement::pathSegListChanged): Used to synchronize the SVGPathSegLists and the d attribute, as well as any changes from any SVGPathSeg associated with this SVGPathElement.
  • svg/SVGPathElement.h: Add new accessors... (WebCore::SVGPathElement::pathByteStream): ... needed by SVGRenderTreeAsText. (WebCore::SVGPathElement::animatablePathSegList): ... needed by SVGPathSegListPropertyTearOff.
  • svg/SVGPathElement.idl: Merge SVGAnimatedPathData interface into SVGPathElement.
  • svg/SVGPathParserFactory.cpp: Cleanup SVGPathParserFactory, remove obsolete methods, now that SVGPathElement switched to using SVGPathByteStream internally. (WebCore::globalSVGPathSegListBuilder): (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromSVGPathSegList): (WebCore::SVGPathParserFactory::buildPathFromByteStream): (WebCore::SVGPathParserFactory::buildSVGPathSegListFromByteStream): (WebCore::SVGPathParserFactory::buildStringFromSVGPathSegList): (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString): (WebCore::SVGPathParserFactory::buildAnimatedSVGPathByteStream): (WebCore::SVGPathParserFactory::getSVGPathSegAtLengthFromSVGPathByteStream):
  • svg/SVGPathParserFactory.h:
  • svg/SVGPathSeg.cpp: Removed.
  • svg/SVGPathSeg.h: Add new SVGPathSegRole enum, identifying to which list a path segment belongs. (WebCore::SVGPathSeg::SVGPathSeg):
  • svg/SVGPathSeg.idl: Reindented.
  • svg/SVGPathSegArc.cpp: Removed.
  • svg/SVGPathSegArc.h: All setters now call the commitChange() method.
  • svg/SVGPathSegArcAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegArcRel.idl: Ditto.
  • svg/SVGPathSegClosePath.cpp: Removed.
  • svg/SVGPathSegClosePath.h:
  • svg/SVGPathSegCurvetoCubic.cpp: Removed.
  • svg/SVGPathSegCurvetoCubic.h: All setters now call the commitChange() method.
  • svg/SVGPathSegCurvetoCubicAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegCurvetoCubicRel.idl: Ditto.
  • svg/SVGPathSegCurvetoCubicSmooth.cpp: Removed.
  • svg/SVGPathSegCurvetoCubicSmooth.h: All setters now call the commitChange() method.
  • svg/SVGPathSegCurvetoCubicSmoothAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegCurvetoCubicSmoothRel.idl: Ditto.
  • svg/SVGPathSegCurvetoQuadratic.cpp: Removed.
  • svg/SVGPathSegCurvetoQuadratic.h: All setters now call the commitChange() method.
  • svg/SVGPathSegCurvetoQuadraticAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegCurvetoQuadraticRel.idl: Ditto.
  • svg/SVGPathSegCurvetoQuadraticSmooth.cpp: Removed.
  • svg/SVGPathSegCurvetoQuadraticSmooth.h: All setters now call the commitChange() method.
  • svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegCurvetoQuadraticSmoothRel.idl: Ditto.
  • svg/SVGPathSegLineto.cpp: Removed.
  • svg/SVGPathSegLineto.h: All setters now call the commitChange() method.
  • svg/SVGPathSegLinetoAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegLinetoHorizontal.cpp: Removed.
  • svg/SVGPathSegLinetoHorizontal.h: All setters now call the commitChange() method.
  • svg/SVGPathSegLinetoHorizontalAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegLinetoHorizontalRel.idl: Ditto.
  • svg/SVGPathSegLinetoRel.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegLinetoVertical.cpp: Removed.
  • svg/SVGPathSegLinetoVertical.h: All setters now call the commitChange() method.
  • svg/SVGPathSegLinetoVerticalAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegLinetoVerticalRel.idl: Ditto.
  • svg/SVGPathSegList.cpp: Switch from SVGList<RefPtr<SVGPathSeg> > to a plain Vector<RefPtr<SVGPathSeg> >. (WebCore::SVGPathSegList::valueAsString): Utilize SVGPathParserFactory to build a String from a SVGPathSegList. (WebCore::SVGPathSegList::commitChange): Call SVGPathElement::pathSegListChanged().
  • svg/SVGPathSegList.h: (WebCore::SVGPathSegList::SVGPathSegList):
  • svg/SVGPathSegList.idl: Remove [JSCCustom] flags, no longer needed.
  • svg/SVGPathSegListBuilder.cpp: Adapt to SVGPathSegList API changes. (WebCore::SVGPathSegListBuilder::SVGPathSegListBuilder): (WebCore::SVGPathSegListBuilder::moveTo): (WebCore::SVGPathSegListBuilder::lineTo): (WebCore::SVGPathSegListBuilder::lineToHorizontal): (WebCore::SVGPathSegListBuilder::lineToVertical): (WebCore::SVGPathSegListBuilder::curveToCubic): (WebCore::SVGPathSegListBuilder::curveToCubicSmooth): (WebCore::SVGPathSegListBuilder::curveToQuadratic): (WebCore::SVGPathSegListBuilder::curveToQuadraticSmooth): (WebCore::SVGPathSegListBuilder::arcTo): (WebCore::SVGPathSegListBuilder::closePath):
  • svg/SVGPathSegListBuilder.h: Ditto. (WebCore::SVGPathSegListBuilder::setCurrentSVGPathElement): (WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegList): (WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegRole): (WebCore::SVGPathSegListBuilder::cleanup):
  • svg/SVGPathSegListSource.cpp: Ditto. (WebCore::SVGPathSegListSource::SVGPathSegListSource): (WebCore::SVGPathSegListSource::parseSVGSegmentType): (WebCore::SVGPathSegListSource::nextCommand): (WebCore::SVGPathSegListSource::parseMoveToSegment): (WebCore::SVGPathSegListSource::parseLineToSegment): (WebCore::SVGPathSegListSource::parseCurveToQuadraticSmoothSegment):
  • svg/SVGPathSegListSource.h: Ditto. (WebCore::SVGPathSegListSource::create):
  • svg/SVGPathSegMoveto.cpp: Removed.
  • svg/SVGPathSegMoveto.h: All setters now call the commitChange() method.
  • svg/SVGPathSegMovetoAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegMovetoRel.idl: Ditto.
  • svg/SVGPathSegWithContext.h: Added. This is the new base class for all SVGPathSeg derived types, that's associated with a SVGPathElement and a 'role' (normalized/unaltered segment list). (WebCore::SVGPathSegWithContext::SVGPathSegWithContext): (WebCore::SVGPathSegWithContext::animatedProperty): (WebCore::SVGPathSegWithContext::setContextAndRole): (WebCore::SVGPathSegWithContext::commitChange): (WebCore::SVGPathSegSingleCoordinate::x): (WebCore::SVGPathSegSingleCoordinate::setX): (WebCore::SVGPathSegSingleCoordinate::y): (WebCore::SVGPathSegSingleCoordinate::setY): (WebCore::SVGPathSegSingleCoordinate::SVGPathSegSingleCoordinate):
  • svg/properties/SVGAnimatedPathSegListPropertyTearOff.h: Added. (WebCore::SVGAnimatedPathSegListPropertyTearOff::baseVal): (WebCore::SVGAnimatedPathSegListPropertyTearOff::animVal): (WebCore::SVGAnimatedPathSegListPropertyTearOff::removeItemFromList): (WebCore::SVGAnimatedPathSegListPropertyTearOff::create): (WebCore::SVGAnimatedPathSegListPropertyTearOff::SVGAnimatedPathSegListPropertyTearOff):
  • svg/properties/SVGPathSegListPropertyTearOff.cpp: Added. (WebCore::SVGPathSegListPropertyTearOff::clear): Added in the cpp file, not in the header, as it needs access to SVGPathSegWithContext, which we can't include from the header. (WebCore::SVGPathSegListPropertyTearOff::getItem): Ditto. (WebCore::SVGPathSegListPropertyTearOff::removeItem): Ditto. (WebCore::SVGPathSegListPropertyTearOff::contextElement): Needs access to SVGPathElement, that's why it lives in the cpp file. (WebCore::SVGPathSegListPropertyTearOff::processIncomingListItemValue): Needs access to SVGPathSegWithContext.
  • svg/properties/SVGPathSegListPropertyTearOff.h: Added. (WebCore::SVGPathSegListPropertyTearOff::create): (WebCore::SVGPathSegListPropertyTearOff::removeItemFromList): (WebCore::SVGPathSegListPropertyTearOff::numberOfItems): (WebCore::SVGPathSegListPropertyTearOff::initialize): (WebCore::SVGPathSegListPropertyTearOff::insertItemBefore): (WebCore::SVGPathSegListPropertyTearOff::replaceItem): (WebCore::SVGPathSegListPropertyTearOff::appendItem): (WebCore::SVGPathSegListPropertyTearOff::SVGPathSegListPropertyTearOff): (WebCore::SVGPathSegListPropertyTearOff::commitChange): (WebCore::SVGPathSegListPropertyTearOff::processIncomingListItemWrapper):

2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=49580

Add several new tests covering SVGPathSegList usage.

  • platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
  • platform/mac/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
  • platform/mac/svg/dom/SVGPathSegList-appendItem-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-cloning-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-cloning-expected.txt: Added.
  • platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-removeItem-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.txt: Added.
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg: Added.
  • svg/dom/SVGPathSegList-appendItem-expected.txt: Added.
  • svg/dom/SVGPathSegList-appendItem.xhtml: Added.
  • svg/dom/SVGPathSegList-clear-and-initialize-expected.txt: Added.
  • svg/dom/SVGPathSegList-clear-and-initialize.xhtml: Added.
  • svg/dom/SVGPathSegList-cloning.html: Added.
  • svg/dom/SVGPathSegList-insertItemBefore-expected.txt: Added.
  • svg/dom/SVGPathSegList-insertItemBefore.xhtml: Added.
  • svg/dom/SVGPathSegList-removeItem-expected.txt: Added.
  • svg/dom/SVGPathSegList-removeItem.xhtml: Added.
  • svg/dom/SVGPathSegList-replaceItem-expected.txt: Added.
  • svg/dom/SVGPathSegList-replaceItem.xhtml: Added.
  • svg/dom/SVGPathSegList-segment-modification.svg: Added.
  • svg/dom/SVGPathSegList-xml-dom-synchronization-expected.txt: Added.
  • svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml: Added.
  • svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml: Added.
  • svg/dom/fuzz-path-parser-expected.txt:
  • svg/dom/path-parser-expected.txt:
  • svg/dom/script-tests/path-parser.js: ():
  • svg/dom/svglist-exception-on-out-bounds-error-expected.txt:
  • svg/dom/svglist-exception-on-out-bounds-error.html:
  • svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
4:42 AM Changeset in webkit [72380] by alex
  • 4 edits in trunk/LayoutTests

2010-11-19 Alejandro G. Castro <alex@igalia.com>

Unreviewed, GTK expectations update after r72347

  • platform/gtk/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
  • platform/gtk/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
  • platform/gtk/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
4:41 AM Changeset in webkit [72379] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-11-19 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: one line follow up to r72376.

  • inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForResourceResponse):
4:32 AM Changeset in webkit [72378] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-19 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Xan Lopez.

[Gtk] "CRITICAL : msg_got_headers_cb: assertion `entry' failed" when using HTTP cache
https://bugs.webkit.org/show_bug.cgi?id=49666

WebKit resource load cache does validate its own resources by
issuing conditional requests to the server. The HTTP cache was
making the assumption that any possible conditional request was
always generated by itself.

  • platform/network/soup/cache/webkit/soup-cache.c: (webkit_soup_cache_entry_remove): added an assertion (msg_got_headers_cb):
4:13 AM Changeset in webkit [72377] by commit-queue@webkit.org
  • 5 edits in trunk

2010-11-19 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

stepUp/stepDown for values in step-mismatching state for input elements
https://bugs.webkit.org/show_bug.cgi?id=48976

  • fast/forms/input-stepup-stepdown-expected.txt:
  • fast/forms/script-tests/input-stepup-stepdown.js:

2010-11-19 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

stepUp/stepDown for values in step-mismatching state for input elements
https://bugs.webkit.org/show_bug.cgi?id=48976

Fixed stepUp/stepDown behaviors for step-mismatching values to follow the specification of
HTML5 4.10.7.3 Common input element APIs. In details, disabled any stepwise adjustment for
step-mismatching values.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::applyStep):
3:20 AM Changeset in webkit [72376] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-11-19 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Rolled out build failures introduced in r72373.

  • inspector/CodeGeneratorInspector.pm:
3:14 AM Changeset in webkit [72375] by pfeldman@chromium.org
  • 16 edits
    3 moves in trunk

2010-11-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: provide response code and status text as
a part of raw headers data.
https://bugs.webkit.org/show_bug.cgi?id=49668

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForResourceResponse):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype._updateResourceWithResponse):
  • platform/network/ResourceLoadInfo.h: Renamed from WebCore/platform/network/ResourceRawHeaders.h. (WebCore::ResourceLoadInfo::ResourceLoadInfo):
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::resourceLoadInfo): (WebCore::ResourceResponseBase::setResourceLoadInfo):
  • platform/network/ResourceResponseBase.h:

2010-11-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: provide response code and status text as a part
of raw headers data.
https://bugs.webkit.org/show_bug.cgi?id=49668

  • WebKit.gyp:
  • public/WebHTTPLoadInfo.h: Renamed from WebKit/chromium/public/WebResourceRawHeaders.h. (WebKit::WebHTTPLoadInfo::WebHTTPLoadInfo): (WebKit::WebHTTPLoadInfo::~WebHTTPLoadInfo): (WebKit::WebHTTPLoadInfo::operator =):
  • public/WebURLResponse.h:
  • src/WebHTTPLoadInfo.cpp: Renamed from WebKit/chromium/src/WebResourceRawHeaders.cpp. (WebKit::WebHTTPLoadInfo::initialize): (WebKit::WebHTTPLoadInfo::reset): (WebKit::WebHTTPLoadInfo::assign): (WebKit::WebHTTPLoadInfo::WebHTTPLoadInfo): (WebKit::WebHTTPLoadInfo::operator WTF::PassRefPtr<WebCore::ResourceRawHeaders>): (WebKit::WebHTTPLoadInfo::responseCode): (WebKit::WebHTTPLoadInfo::setResponseCode): (WebKit::WebHTTPLoadInfo::statusText): (WebKit::WebHTTPLoadInfo::setStatusText): (WebKit::addHeader): (WebKit::WebHTTPLoadInfo::addRequestHeader): (WebKit::WebHTTPLoadInfo::addResponseHeader):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::httpLoadInfo): (WebKit::WebURLResponse::setHTTPLoadInfo):
3:09 AM Changeset in webkit [72374] by commit-queue@webkit.org
  • 4 edits in trunk

2010-11-19 Mike Lawther <mikelawther@chromium.org>

Reviewed by James Robinson.

[skia] assert when attempting to get (but not use) pointer to outside the canvas
https://bugs.webkit.org/show_bug.cgi?id=49698

Removed expectation of failure on Win dbg

  • platform/chromium/test_expectations.txt:

2010-11-19 Mike Lawther <mikelawther@chromium.org>

Reviewed by James Robinson.

[skia] assert when attempting to get (but not use) pointer to outside the canvas
https://bugs.webkit.org/show_bug.cgi?id=49698

Early return to avoid getting a pointer to outside the canvas, and
hence triggering a Skia assert.

  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData):
2:57 AM Changeset in webkit [72373] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-11-18 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: reduce the footprint of InspectorBackendDispatcher.
InspectorBackendDispatcher is a generated file.
Its content is not optimal and loc may be reduced by a quarter.
In each generated function we have a code for getting 'in' values from
the arguments properties object. I've extracted this code into separate getters.
The side effect is better readability of the generated code.

https://bugs.webkit.org/show_bug.cgi?id=49729

  • inspector/CodeGeneratorInspector.pm:
2:54 AM Changeset in webkit [72372] by jparent@chromium.org
  • 2 edits
    6 adds in trunk/LayoutTests

2010-11-19 Julie Parent <jparent@chromium.org>

Reviewed by Ojan Vafai.

[Chromium]Several fast/transforms tests need linux specific baselines
https://bugs.webkit.org/show_bug.cgi?id=48788

  • platform/chromium-linux/fast/transforms/transform-on-inline-expected.checksum: Added.
  • platform/chromium-linux/fast/transforms/transform-on-inline-expected.png: Added.
  • platform/chromium-linux/fast/transforms/transform-table-row-expected.checksum: Added.
  • platform/chromium-linux/fast/transforms/transform-table-row-expected.png: Added.
  • platform/chromium-linux/fast/transforms/transformed-document-element-expected.checksum: Added.
  • platform/chromium-linux/fast/transforms/transformed-document-element-expected.png: Added.
  • platform/chromium/test_expectations.txt:
2:31 AM Changeset in webkit [72371] by yael.aharon@nokia.com
  • 3 edits
    3 adds in trunk

2010-11-19 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Focus ring does not show for image maps
https://bugs.webkit.org/show_bug.cgi?id=49615

  • platform/qt/fast/images/imagemap-focus-ring-expected.checksum: Added.
  • platform/qt/fast/images/imagemap-focus-ring-expected.png: Added.
  • platform/qt/fast/images/imagemap-focus-ring-expected.txt: Added.

2010-11-19 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Focus ring does not show for image maps
https://bugs.webkit.org/show_bug.cgi?id=49615

Draw a focus ring for the paths surrounding the focus ring of image map area.
Provide Qt specific results for the test fast/images/imagemap-focus-ring.html.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawFocusRing):
1:35 AM Changeset in webkit [72370] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-11-19 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

https://bugs.webkit.org/show_bug.cgi?id=49200
[Qt] bugs in Composition mode for QWebPage::inputMethodEvent & inputMethodQuery()

Make QWebPage work as following when editor is in composition mode:

  1. anchor position and cursor position are the same and always >= 0
  2. current selection is always null
  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent): (QWebPage::inputMethodQuery):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):

Nov 18, 2010:

11:11 PM Changeset in webkit [72369] by levin@chromium.org
  • 3 edits
    8 adds in trunk/LayoutTests

[chromium] Update/Add baselines for r72362 and r72355.

  • platform/chromium-linux/fast/ruby/nested-ruby-expected.checksum: Added.
  • platform/chromium-linux/fast/ruby/nested-ruby-expected.png: Added.
  • platform/chromium-linux/fast/ruby/nested-ruby-expected.txt: Added.
  • platform/chromium-mac/fast/js/function-prototype-descriptor-expected.txt:
  • platform/chromium-mac/fast/ruby/nested-ruby-expected.checksum: Added.
  • platform/chromium-mac/fast/ruby/nested-ruby-expected.png: Added.
  • platform/chromium-win/fast/js/function-prototype-descriptor-expected.txt:
  • platform/chromium-win/fast/ruby/nested-ruby-expected.checksum: Added.
  • platform/chromium-win/fast/ruby/nested-ruby-expected.png: Added.
  • platform/chromium-win/fast/ruby/nested-ruby-expected.txt: Added.
11:02 PM Changeset in webkit [72368] by barraclough@apple.com
  • 2 edits in trunk/WebKit/qt

Build fix - update error messages folllowing r72360.

  • tests/qwebframe/tst_qwebframe.cpp:
10:25 PM Changeset in webkit [72367] by morrita@google.com
  • 7 edits in trunk/WebCore

2010-11-01 MORITA Hajime <morrita@google.com>

Reviewed by David Hyatt.

Navigating dark background websites results in blinding white flashes between pages.
https://bugs.webkit.org/show_bug.cgi?id=45640

This FOUC is caused by an early layout request before the <body> is ready,
and the page's background style given for <body>, instead of <html>.
So many sites have such stylesheets that we should care them.

  • Some DOM operation such as 'element.offsetLeft' causes page layout.
  • The page layout results page repaint
  • The page page repaint makes a white screen. because there is nothing to paint before <body> is available.

This change:

  • extracted existing FOUC check on RenderBlock and RenderLayer to Document::mayCauseFlashOfUnstyledContent(),
  • checked non-<head> element availability on mayCauseFlashOfUnstyledContent(), and
  • added FOUC guards before requesting reapint on FrameView.

Note that non-<head> document root children are typically <body>, but possibly
some other type of elements in the case of non-HTML documents.

No new tests. The data loading speed matters and it cannot be
captured by DRT.

  • dom/Document.cpp: (hasHeadSibling): Added. (WebCore::Document::mayCauseFlashOfUnstyledContent): Added.
  • dom/Document.h:
  • page/FrameView.cpp: (WebCore::FrameView::invalidateRect): Added a guard. (WebCore::FrameView::repaintContentRectangle): Added a guard. (WebCore::FrameView::doDeferredRepaints): Added a guard. (WebCore::FrameView::shouldUpdate): Added.
  • page/FrameView.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintContents): Replaced FOUC check to use mayCauseFlashOfUnstyledContent
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Replaced FOUC check to use mayCauseFlashOfUnstyledContent
10:20 PM Changeset in webkit [72366] by barraclough@apple.com
  • 4 edits in trunk/WebKitTools

Build fix - as per DRT-mac, always enabled developer extras,
in win/qt/gtk DRT.

This is necessary to enable rich exception messages to be generated
following https://bugs.webkit.org/show_bug.cgi?id=49708.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(shouldEnableDeveloperExtras):

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::shouldEnableDeveloperExtras):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(shouldEnableDeveloperExtras):

9:16 PM Changeset in webkit [72365] by kinuko@chromium.org
  • 3 edits in trunk/WebKitTools

2010-11-18 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72357.
http://trac.webkit.org/changeset/72357
https://bugs.webkit.org/show_bug.cgi?id=49784

It broke test-webkitpy tests since the patch didn't have the
corresponding test update (Requested by kinuko on #webkit).

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
8:51 PM Changeset in webkit [72364] by mihaip@chromium.org
  • 6 edits
    1 add in trunk/WebKitTools

2010-11-18 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

Rebaseline server: add rebaseline queue
https://bugs.webkit.org/show_bug.cgi?id=49763

Add a UI queue (a multi-item <select>) where tests to be baselined
can be enqueued (also supports basic removal). A queue is used instead
of immediately doing rebaselines since SCM operations can take a while.
It's better to go through lots of tests quickly to mark them as
needing rebaselining and then batch the SCM operations.

Also adds a simple log where results can be displayed.

  • Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
8:48 PM Changeset in webkit [72363] by tkent@chromium.org
  • 23 edits in trunk

2010-11-18 Kent Tamura <tkent@chromium.org>

Reviewed by Tony Chang.

Add more validation message functions
https://bugs.webkit.org/show_bug.cgi?id=49716

Add the following message functions:

  • validationMessageValueMissingForCheckbox()
  • validationMessageValueMissingForFile()
  • validationMessageValueMissingForMultipleFile()
  • validationMessageValueMissingForRadio()
  • validationMessageValueMissingForSelect()

and update ValidityState, HTMLInputElement, and InputTypes to use them.

No new tests because this doesn't change visible behavior.

  • html/CheckboxInputType.cpp: (WebCore::CheckboxInputType::valueMissingText):
  • html/CheckboxInputType.h:
  • html/FileInputType.cpp: (WebCore::FileInputType::valueMissingText):
  • html/FileInputType.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueMissingText):
  • html/HTMLInputElement.h:
  • html/InputType.cpp: (WebCore::InputType::valueMissingText):
  • html/InputType.h:
  • html/RadioInputType.cpp: (WebCore::RadioInputType::valueMissingText):
  • html/RadioInputType.h:
  • html/ValidityState.cpp: (WebCore::ValidityState::validationMessage):
  • platform/LocalizedStrings.cpp: (WebCore::validationMessageValueMissingForCheckboxText): (WebCore::validationMessageValueMissingForFileText): (WebCore::validationMessageValueMissingForMultipleFileText): (WebCore::validationMessageValueMissingForRadioText): (WebCore::validationMessageValueMissingForSelectText):
  • platform/LocalizedStrings.h:
  • platform/android/LocalizedStringsAndroid.cpp: (WebCore::validationMessageValueMissingForCheckboxText): (WebCore::validationMessageValueMissingForFileText): (WebCore::validationMessageValueMissingForMultipleFileText): (WebCore::validationMessageValueMissingForRadioText): (WebCore::validationMessageValueMissingForSelectText):
  • platform/brew/LocalizedStringsBrew.cpp: (WebCore::validationMessageValueMissingForCheckboxText): (WebCore::validationMessageValueMissingForFileText): (WebCore::validationMessageValueMissingForMultipleFileText): (WebCore::validationMessageValueMissingForRadioText): (WebCore::validationMessageValueMissingForSelectText):
  • platform/efl/LocalizedStringsEfl.cpp: (WebCore::validationMessageValueMissingForCheckboxText): (WebCore::validationMessageValueMissingForFileText): (WebCore::validationMessageValueMissingForMultipleFileText): (WebCore::validationMessageValueMissingForRadioText): (WebCore::validationMessageValueMissingForSelectText):
  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::validationMessageValueMissingForCheckboxText): (WebCore::validationMessageValueMissingForFileText): (WebCore::validationMessageValueMissingForMultipleFileText): (WebCore::validationMessageValueMissingForRadioText): (WebCore::validationMessageValueMissingForSelectText):
  • platform/haiku/LocalizedStringsHaiku.cpp: (WebCore::validationMessageValueMissingText): (WebCore::validationMessageValueMissingForCheckboxText): (WebCore::validationMessageValueMissingForFileText): (WebCore::validationMessageValueMissingForMultipleFileText): (WebCore::validationMessageValueMissingForRadioText): (WebCore::validationMessageValueMissingForSelectText):
  • platform/wx/LocalizedStringsWx.cpp: (WebCore::validationMessageValueMissingForCheckboxText): (WebCore::validationMessageValueMissingForFileText): (WebCore::validationMessageValueMissingForMultipleFileText): (WebCore::validationMessageValueMissingForRadioText): (WebCore::validationMessageValueMissingForSelectText):

2010-11-18 Kent Tamura <tkent@chromium.org>

Reviewed by Tony Chang.

Add more validation message functions
https://bugs.webkit.org/show_bug.cgi?id=49716

Add implementations of new functions and symbols for new messages.

  • public/WebLocalizedString.h:
  • src/LocalizedStrings.cpp: (WebCore::validationMessageValueMissingForCheckboxText): (WebCore::validationMessageValueMissingForFileText): (WebCore::validationMessageValueMissingForMultipleFileText): (WebCore::validationMessageValueMissingForRadioText): (WebCore::validationMessageValueMissingForSelectText):
8:33 PM Changeset in webkit [72362] by barraclough@apple.com
  • 5 edits in trunk

Bug 49577 - Function.prototype should be non-configurable

Rubber stamped by Geoff Garen.

Ooops, Function.prototype should not be enumerable!

JavaScriptCore:

  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertySlot):

LayoutTests:

  • fast/js/function-prototype-descriptor-expected.txt:
  • fast/js/script-tests/function-prototype-descriptor.js:

(test):

7:34 PM Changeset in webkit [72361] by levin@chromium.org
  • 49 edits
    2 adds
    1 delete in trunk/LayoutTests

[chromium] Misc test updates (most Ruby).
Rebaselines corresponding to 72347 and 72355.
Add failures for r72344 (until I get the chance to investigate).
Add failures for context-menu failures.

  • platform/chromium-linux/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum:
  • platform/chromium-linux/fast/blockflow/japanese-ruby-horizontal-bt-expected.png:
  • platform/chromium-linux/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
  • platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
  • platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
  • platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
  • platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
  • platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
  • platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
  • platform/chromium-linux/fast/ruby/ruby-beforeafter-expected.txt: Removed.
  • platform/chromium-linux/fast/ruby/ruby-length-expected.checksum:
  • platform/chromium-linux/fast/ruby/ruby-length-expected.png:
  • platform/chromium-linux/fast/ruby/ruby-run-break-expected.checksum:
  • platform/chromium-linux/fast/ruby/ruby-run-break-expected.png:
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
  • platform/chromium-mac/fast/ruby/ruby-run-break-expected.checksum: Added.
  • platform/chromium-mac/fast/ruby/ruby-run-break-expected.png: Added.
  • platform/chromium-win/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum:
  • platform/chromium-win/fast/blockflow/japanese-ruby-horizontal-bt-expected.png:
  • platform/chromium-win/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
  • platform/chromium-win/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
  • platform/chromium-win/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
  • platform/chromium-win/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
  • platform/chromium-win/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
  • platform/chromium-win/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
  • platform/chromium-win/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
  • platform/chromium-win/fast/ruby/ruby-beforeafter-expected.txt:
  • platform/chromium-win/fast/ruby/ruby-empty-rt-expected.txt:
  • platform/chromium-win/fast/ruby/ruby-length-expected.checksum:
  • platform/chromium-win/fast/ruby/ruby-length-expected.png:
  • platform/chromium-win/fast/ruby/ruby-length-expected.txt:
  • platform/chromium-win/fast/ruby/ruby-run-break-expected.checksum:
  • platform/chromium-win/fast/ruby/ruby-run-break-expected.png:
  • platform/chromium-win/fast/ruby/ruby-run-break-expected.txt:
  • platform/chromium-win/fast/ruby/ruby-runs-expected.txt:
  • platform/chromium-win/fast/ruby/ruby-runs-spans-expected.txt:
  • platform/chromium-win/fast/ruby/ruby-simple-expected.txt:
  • platform/chromium-win/fast/ruby/ruby-simple-rp-expected.txt:
  • platform/chromium-win/fast/ruby/ruby-trailing-expected.txt:
  • platform/chromium-win/fast/ruby/rubyDOM-insert-rt-expected.txt:
  • platform/chromium-win/fast/ruby/rubyDOM-insert-text1-expected.txt:
  • platform/chromium-win/fast/ruby/rubyDOM-insert-text2-expected.txt:
  • platform/chromium-win/fast/ruby/rubyDOM-insert-text3-expected.txt:
  • platform/chromium-win/fast/ruby/rubyDOM-remove-rt1-expected.txt:
  • platform/chromium-win/fast/ruby/rubyDOM-remove-rt2-expected.txt:
  • platform/chromium-win/fast/ruby/rubyDOM-remove-text1-expected.txt:
  • platform/chromium-win/fast/ruby/rubyDOM-remove-text2-expected.txt:
  • platform/chromium/test_expectations.txt:
6:35 PM Changeset in webkit [72360] by barraclough@apple.com
  • 21 edits in trunk

Bug 49708 - Stop recompiling functions to regenerate exception info.

Reviewed by Oliver Hunt.

Instead only hold info as necessary – keep divot info is the inspector
is enabled, line number info is debugging or profiling, and handler
info for functions with try/catch.

JavaScriptCore:

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpStatistics):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::lineNumberForBytecodeOffset):
(JSC::CodeBlock::expressionRangeForBytecodeOffset):
(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::addExpressionInfo):
(JSC::CodeBlock::addLineInfo):
(JSC::CodeBlock::hasExpressionInfo):
(JSC::CodeBlock::hasLineInfo):
(JSC::CodeBlock::needsCallReturnIndices):
(JSC::CodeBlock::callReturnIndexVector):

  • bytecode/SamplingTool.cpp:

(JSC::SamplingTool::dump):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitNode):
(JSC::BytecodeGenerator::emitNodeInConditionContext):
(JSC::BytecodeGenerator::emitExpressionInfo):
(JSC::BytecodeGenerator::addLineInfo):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwindCallFrame):
(JSC::appendSourceToError):
(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveLastCaller):

  • interpreter/Interpreter.h:
  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITStubs.cpp:

(JSC::jitThrow):
(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Collector.cpp:

(JSC::Heap::markRoots):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::usingAPI):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::supportsRichSourceInfo):
(JSC::JSGlobalObject::globalData):

WebCore:

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::supportsRichSourceInfo):

  • report to JSC whether the inspector is enabled - in which case we will generate better error messages on exceptions.
  • bindings/js/JSDOMWindowBase.h:

WebKitTools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(shouldEnableDeveloperExtras):

  • always enable the developer tools from DRT, to ensure we produce rich error messages on JavaScript exceptions.
6:19 PM Changeset in webkit [72359] by Adam Roben
  • 3 edits
    1 add in trunk/JavaScriptCore

Add a script to delete manifest-related files when they are older than any .vsprops file

Changes to .vsprops files can cause the manifest files to become
invalid, and Visual Studio doesn't always figure out that it needs to
rebuild them.

Reviewed by Sam Weinig.

Call the new script.

Added the new script.

  • JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py: Added.

(file_modification_times): Generator to return the modification time of
each file in a directory hierarchy.
(main): Get the modification time of the newest vsprops file, then find
all manifest-related files in the obj directory. Delete all
manifest-related files that are older than the newest vsprops file.

6:13 PM Changeset in webkit [72358] by jianli@chromium.org
  • 15 edits in trunk/WebCore

Make binding code generation scripts support 'short' type
https://bugs.webkit.org/show_bug.cgi?id=49704

Reviewed by Kenneth Russell.

Updated binding tests.

  • bindings/scripts/CodeGeneratorJS.pm: Also fixed a style issue.
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:
6:05 PM Changeset in webkit [72357] by kinuko@chromium.org
  • 3 edits in trunk/WebKitTools

2010-11-18 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Ojan Vafai.

[Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
https://bugs.webkit.org/show_bug.cgi?id=49702

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
5:58 PM Changeset in webkit [72356] by mrowe@apple.com
  • 8 edits in trunk

<rdar://problem/8602509&8602717&8602724> Enable compaction support.

Rubber-stamped by Adam Roben.

JavaScriptCore:

  • Configurations/JavaScriptCore.xcconfig:

WebCore:

  • Configurations/WebCore.xcconfig:

WebKit/mac:

  • Configurations/WebKit.xcconfig:

WebKit2:

  • Configurations/WebKit2.xcconfig:
5:33 PM Changeset in webkit [72355] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=49772

Reviewed by Dan Bernstein.

Fix nested ruby. My previous checkin (for 49717) broke it. Push the ruby text and ruby base text
together based off logicalTopOverflow and logicalBottomOverflow rather than lineTop and lineBottom.
This way the overflow from nested rubies is accounted for.

Added fast/ruby/nested-ruby.html

WebCore:

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::layout):

LayoutTests:

  • fast/ruby/nested-ruby.html: Added.
  • platform/mac/fast/ruby/nested-ruby-expected.checksum: Added.
  • platform/mac/fast/ruby/nested-ruby-expected.png: Added.
  • platform/mac/fast/ruby/nested-ruby-expected.txt: Added.
5:32 PM Changeset in webkit [72354] by kinuko@chromium.org
  • 2 edits in trunk/WebCore

2010-11-18 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Nate Chapin.

[V8] ASSERT(WTF::isMainThread()) fails in V8Binding::int32ToWebCoreString in workers
https://bugs.webkit.org/show_bug.cgi?id=49613

No new tests. Running existing worker tests like
fast/workers/storage/execute-sql-args-worker.html in chromium
would verify it.

  • bindings/v8/V8Binding.cpp: (WebCore::int32ToWebCoreStringFast): (WebCore::int32ToWebCoreString):
5:21 PM Changeset in webkit [72353] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Updating test results. I don't know what this mega-test is doing, but at least they changed
from FAIL to PASS.

  • fast/dom/prototype-inheritance-2-expected.txt:
5:11 PM Changeset in webkit [72352] by bweinstein@apple.com
  • 6 edits in trunk/WebKit2

WebKit2: Safari shouldn't auto-activate plug-ins in background tabs.
https://bugs.webkit.org/show_bug.cgi?id=49770
<rdar://problem/8482424>


Reviewed by Adam Roben.

Add an API on Windows to call setIsInWindow, which calls through to WebPage::setIsInWindow.
Remove the !PLATFORM(WIN) check in WebPage, so we don't automatically start plugins that are
loaded in background tabs.

  • UIProcess/API/C/win/WKView.cpp:

(WKViewSetIsInWindow): Call through to WebView::setIsInWindow.

  • UIProcess/API/C/win/WKView.h:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::setIsInWindow): Call through to WebPage::setIsInWindow.

  • UIProcess/win/WebView.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Remove the !PLATFORM(WIN) check and update the comment.

4:54 PM Changeset in webkit [72351] by barraclough@apple.com
  • 14 edits in trunk

Bug 49635 - Profiler implementation is fragile

Reviewed by Oliver Hunt.

JavaScriptCore:

The profile presently requires the exception handling mechanism to explicitly
remove all stack frames that are exited during the exception unwind mechanism.
This is fragile in a number of ways:

  • We have to change bytecode register allocation when compiling code to run when profiling, to preserve the callee function (this is also required to call did_call after the call has returned).
  • In the JIT we have to maintain additional data structures (CodeBlock::RareData::m_functionRegisterInfos) to map back to the register containing the callee.
  • In the interpreter we use 'magic values' to offset into the instruction stream to rediscover the register containing the function.

Instead, move profiling into the head and tail of functions.

  • This correctly accounts the cost of the call itself to the caller.
  • This allows us to access the callee function object from the callframe.
  • This means that at the point a call is made we can track the stack depth on the ProfileNode.
  • When unwinding we can simply report the depth at which the exception is being handled - all call frames above this level are freed.
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::methodCallLinkInfo):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • profiler/Profile.cpp:

(JSC::Profile::Profile):

  • profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::addParentForConsoleStart):
(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):
(JSC::ProfileGenerator::exceptionUnwind):
(JSC::ProfileGenerator::stopProfiling):

  • profiler/ProfileGenerator.h:
  • profiler/ProfileNode.cpp:

(JSC::ProfileNode::ProfileNode):
(JSC::ProfileNode::willExecute):

  • profiler/ProfileNode.h:

(JSC::ProfileNode::create):
(JSC::ProfileNode::callerCallFrame):

  • profiler/Profiler.cpp:

(JSC::dispatchFunctionToProfiles):
(JSC::Profiler::_willExecute):
(JSC::Profiler::_didExecute):
(JSC::Profiler::exceptionUnwind):

  • profiler/Profiler.h:

LayoutTests:

Fixes previously failing tests - output was incorrect, showing duplicate entries
for '(program) (no file) (line 1)'.

  • fast/profiler/throw-exception-from-eval-expected.txt:
4:51 PM Changeset in webkit [72350] by Darin Adler
  • 2 edits in trunk/WebKit2
  • WebProcess/WebPage/WebPage.cpp: Fix build by rolling out a change.
4:51 PM Changeset in webkit [72349] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-18 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/win/Skipped: Add a bug URL for <progress>-related tests.
4:46 PM Changeset in webkit [72348] by ap@apple.com
  • 2 edits in trunk/WebCore

Windows build fix.

https://bugs.webkit.org/show_bug.cgi?id=49762
Stylesheet wrappers are not GC protected

  • bindings/js/JSBindingsAllInOne.cpp: Added new custom binding files.
4:43 PM Changeset in webkit [72347] by hyatt@apple.com
  • 44 edits
    18 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=49717

Reviewed by Dan Bernstein.

Implement better behavior for the logical height and block direction spacing of ruby text and ruby
base text.

Added six new tests: ruby-auto-line-expansion.html (one version for each of the four writing modes) to
test ruby text accommodation and quirks-mode-ruby-spacing.html / quirks-mode-ruby-spacing-bt.html to test
that ruby doesn't reset line-height.

  • css/html.css:

Remove the line-height:normal rule for <ruby> This behavior was incorrect, since a <ruby> on a line
by itself in quirks mode would cause the overall line-height of the enclosing block to not be honored.

  • rendering/InlineBox.h:

(WebCore::InlineBox::adjustBlockDirectionPosition):
Add adjustBlockDirectionPosition as a shorthand for calling adjustPosition with the correct delta (x or y)
depending on orientation.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
placeBoxesInBlockDirection now looks for Ruby runs, and when it encounters them it sets a flag, containsRuby,
to true. This flag is stored as a bit on the RootInlineBox and lets us know whether we need to do a later
crawl of the line boxes after they are positioned to see if all the Ruby texts fit or not.

Add the notion of a lineTop and lineBottom that include margins, since flipped lines writing modes (lr and bt)
mess up the flipping otherwise. These new variables are lineTopIncludingMargins and lineBottomIncludingMargins.
This is only relevant for replaced elements, since the block direction margins of inline flows are always 0.

Because RenderRubyRun is implemented as an inline-block (this is probably not a behavior we want to keep long-term),
the line-height is propagated into the inline-block, and it ends up being counted as part of the overall lineTop
and lineBottom since it is inside the inline-block's height. To prevent this from happening, we have to fake it
as though RenderRubyRun was just a normal inline. We look at the line boxes of the ruby base and we push lineTop/Bottom
in by the leading on either side so that it isn't counted as part of lineTop and lineBottom. This enables the later
Ruby code that examines the spacing between lines to not be fooled into thinking it can't intrude into an inline-block's
interior on a previous line.

(WebCore::InlineFlowBox::computeBlockDirectionRubyAdjustment):
This function computes the amount that a line box has to be moved in order to accommodate all of the Ruby texts on the
line. With tb and rl writing modes, the Ruby is trying to fit between the current line and a previous line, and so
we're checking some highest previous position and computing the amount we have to move.

For lr and bt writing modes, the lines are flipped relative to the block direction, so we are computing how much we have
to move the *following* line based off a lowest position.

In all writing modes we will allow Ruby text to intrude into the padding of a block.

  • rendering/InlineFlowBox.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChildren):
Ruby text is now considered a special child that should be excluded from normal layout, margin collapsing and height
computations. Rename the layoutLegend function to be more generalized and make it apply to both Ruby text and to
legends. This means that the RenderRubyRun computes its logical height without any regard for the ruby text.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::layoutSpecialExcludedChild):
layoutSpecialExcludedChild is the new version of layoutLegend and it is implemented by RenderFieldset and RenderRubyRun.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):
When we hit the end of line layout, if we're in lr or bt writing modes, we have to potentially grow the height of the block
to accommodate ruby text along the bottom side of the line. We call computeBlockDirectionRubyAdjustment here in flipped lines
writing mode only, and then we increase the logical height of the block if necessary.

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::layoutSpecialExcludedChild):

  • rendering/RenderFieldset.h:

No changes here other than the function rename.

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::staticCreateRubyRun):
Remove the hack that locked RenderRubyRun's writing mode to tb or rl, since it didn't really work anyway, and it isn't necessary
now that RenderRubyRun has its own layout method.

(WebCore::RenderRubyRun::layoutSpecialExcludedChild):
RenderRubyRun lays out the ruby text here but doesn't do anything with its placement yet. We wait until the base is positioned
and then handled positioning the RenderRubyText at the end of RenderRubyRun's layout method.

(WebCore::RenderRubyRun::layout):

  • rendering/RenderRubyRun.h:

RenderRubyRun now has its own layout method that calls the base class to get the RenderRubyBase positioned and then moves the
RenderRubyText such that its bottommost line box's bottom and the RenderRubyBase's topmost line box's line top are flush with
one another. The RenderRubyText will commonly be positioned at a negative coordinate now and spill out of the RenderRubyRun
as overflow.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):
Added the m_containsRuby bit for performance to avoid the extra pass to try to accommodate ruby texts when none are present.

(WebCore::RootInlineBox::adjustPosition):
Fixed a bug in adjustPosition where the lineTop, lineBottom and blockLogicalHeight values were always being augmented by dy
even in vertical writing modes (where dx needed to be used instead).

WebCore:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::blockDirectionRubyAdjustment):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::containsRuby):
RootInlineBox now calls blockDirectionRubyAdjustment to determine the amount of additional spacing that has to exist between
the lines in order to accommodate all Ruby texts, and then it does adjustPosition to move the new line by the amount required.

LayoutTests:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::blockDirectionRubyAdjustment):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::containsRuby):
RootInlineBox now calls blockDirectionRubyAdjustment to determine the amount of additional spacing that has to exist between
the lines in order to accommodate all Ruby texts, and then it does adjustPosition to move the new line by the amount required.

  • fast/ruby/ruby-line-height-expected.txt:
  • platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum:
  • platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.png:
  • platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
  • platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
  • platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/mac/fast/ruby/quirks-mode-ruby-spacing-bt-expected.checksum: Added.
  • platform/mac/fast/ruby/quirks-mode-ruby-spacing-bt-expected.png: Added.
  • platform/mac/fast/ruby/quirks-mode-ruby-spacing-bt-expected.txt: Added.
  • platform/mac/fast/ruby/quirks-mode-ruby-spacing-expected.checksum: Added.
  • platform/mac/fast/ruby/quirks-mode-ruby-spacing-expected.png: Added.
  • platform/mac/fast/ruby/quirks-mode-ruby-spacing-expected.txt: Added.
  • platform/mac/fast/ruby/ruby-auto-line-expansion-bt-expected.checksum: Added.
  • platform/mac/fast/ruby/ruby-auto-line-expansion-bt-expected.png: Added.
  • platform/mac/fast/ruby/ruby-auto-line-expansion-bt-expected.txt: Added.
  • platform/mac/fast/ruby/ruby-auto-line-expansion-expected.checksum: Added.
  • platform/mac/fast/ruby/ruby-auto-line-expansion-expected.png: Added.
  • platform/mac/fast/ruby/ruby-auto-line-expansion-expected.txt: Added.
  • platform/mac/fast/ruby/ruby-auto-line-expansion-lr-expected.checksum: Added.
  • platform/mac/fast/ruby/ruby-auto-line-expansion-lr-expected.png: Added.
  • platform/mac/fast/ruby/ruby-auto-line-expansion-lr-expected.txt: Added.
  • platform/mac/fast/ruby/ruby-auto-line-expansion-rl-expected.checksum: Added.
  • platform/mac/fast/ruby/ruby-auto-line-expansion-rl-expected.png: Added.
  • platform/mac/fast/ruby/ruby-auto-line-expansion-rl-expected.txt: Added.
  • platform/mac/fast/ruby/ruby-beforeafter-expected.txt:
  • platform/mac/fast/ruby/ruby-empty-rt-expected.txt:
  • platform/mac/fast/ruby/ruby-length-expected.txt:
  • platform/mac/fast/ruby/ruby-run-break-expected.checksum:
  • platform/mac/fast/ruby/ruby-run-break-expected.png:
  • platform/mac/fast/ruby/ruby-run-break-expected.txt:
  • platform/mac/fast/ruby/ruby-runs-expected.txt:
  • platform/mac/fast/ruby/ruby-runs-spans-expected.txt:
  • platform/mac/fast/ruby/ruby-simple-expected.txt:
  • platform/mac/fast/ruby/ruby-simple-rp-expected.txt:
  • platform/mac/fast/ruby/ruby-trailing-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-text2-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-insert-text3-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-remove-text1-expected.txt:
  • platform/mac/fast/ruby/rubyDOM-remove-text2-expected.txt:
4:40 PM Changeset in webkit [72346] by Darin Adler
  • 2 edits in trunk/WebKit2

2010-11-18 Darin Adler <Darin Adler>

Reviewed by Kevin Decker.

REGRESSION (WebKit2): Plug-ins and <video> start playing immediately in background tabs
https://bugs.webkit.org/show_bug.cgi?id=49766

Test: manual-tests/resources/video-tab.html

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): Call setCanStartMedia(false) since the rest of the code starts out treating the page as "not in a window".
4:40 PM Changeset in webkit [72345] by levin@chromium.org
  • 8 edits
    1 move
    3 adds
    3 deletes in trunk/LayoutTests

[chromium] Test baseline updates.

  • platform/chromium-linux/fast/compact/001-expected.checksum: Rebaselined due to r72141. Removes the green background in the test. Dave Hyatt confirmed the behavior: "We actually removed compact support ages ago, so really the test should just be removed."
  • platform/chromium-linux/fast/compact/001-expected.png: Ditto.
  • platform/chromium-mac/fast/compact/001-expected.checksum: Added. Ditto.
  • platform/chromium-mac/fast/compact/001-expected.png: Added. Ditto.
  • platform/chromium-win/fast/compact/001-expected.checksum: Ditto.
  • platform/chromium-win/fast/compact/001-expected.png: Ditto.
  • platform/chromium-mac/fast/blockflow/vertical-font-fallback-expected.checksum:
  • platform/chromium-mac/fast/blockflow/vertical-font-fallback-expected.png: Updated due to r72173. The changes in output appear minimal and the output looks ok.
  • platform/chromium-win/fast/js/regexp-overflow-expected.txt: Removed. Consolidated the results for this test.
  • platform/chromium/fast/js/regexp-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/js/regexp-overflow-expected.txt. Ditto.
  • platform/chromium-linux/fast/parser/style-script-head-test-expected.txt: Removed.
  • platform/chromium-win/fast/parser/style-script-head-test-expected.txt: Removed. Chromium results are exactly the same as platform/mac, so no need for platform specific results.
  • platform/chromium/test_expectations.txt: Updated due to these changes.
4:23 PM Changeset in webkit [72344] by ap@apple.com
  • 13 edits
    7 adds in trunk

Reviewed by Geoffrey Garen.

https://bugs.webkit.org/show_bug.cgi?id=49762
Stylesheet wrappers are not GC protected

Tests: fast/dom/StyleSheet/gc-inline-style-cssvalues.html

fast/dom/StyleSheet/gc-styleheet-wrapper.xhtml

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj: Added the new custom bindings files.
  • WebCore.xcodeproj/project.pbxproj: Added the new custom bindings files. Also, added some existing headers.
  • bindings/js/JSDOMBinding.cpp: (WebCore::isObservableThroughDOM): If a node has a stylesheet with a wrapper, it may be the only thing having the stylesheet's wrapper alive, so its own wrapper has to stay alive, too. While at it, also fixed the same issue with inline style declarations. Also, added a FIXME comment about one with attribute nodes. We implement a less conservative approach for nodes, so perhaps fixing this is not as easy as removing a hasCustomProperties() check.
  • bindings/js/JSHTMLLinkElementCustom.cpp: Added. (WebCore::JSHTMLLinkElement::markChildren):
  • bindings/js/JSHTMLStyleElementCustom.cpp: Added. (WebCore::JSHTMLStyleElement::markChildren):
  • bindings/js/JSProcessingInstructionCustom.cpp: Added. (WebCore::JSProcessingInstruction::markChildren): Mark stylesheets owned by these nodes. As always in markChildren() functions, we do it conservatively, without checking whether the stylesheet or any of its children have custom properties.
  • dom/ProcessingInstruction.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLStyleElement.idl: These have custom mark functions now.
4:12 PM Changeset in webkit [72343] by jianli@chromium.org
  • 29 edits
    2 deletes in trunk/WebCore

Move length and slice out of ArrayBufferView interface
https://bugs.webkit.org/show_bug.cgi?id=49697

Reviewed by Kenneth Russell.

No functionality change. Covered by existing ArrayBuffer tests.

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSArrayBufferViewCustom.cpp: Removed.
  • bindings/v8/custom/V8ArrayBufferViewCustom.cpp: Removed.
  • html/canvas/ArrayBufferView.h:
  • html/canvas/ArrayBufferView.idl:
  • html/canvas/Float32Array.cpp:

(WebCore::Float32Array::slice):

  • html/canvas/Float32Array.h:
  • html/canvas/Float32Array.idl:
  • html/canvas/Int16Array.cpp:

(WebCore::Int16Array::slice):

  • html/canvas/Int16Array.h:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.cpp:

(WebCore::Int32Array::slice):

  • html/canvas/Int32Array.h:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.cpp:

(WebCore::Int8Array::slice):

  • html/canvas/Int8Array.h:
  • html/canvas/Int8Array.idl:
  • html/canvas/TypedArrayBase.h:

(WebCore::TypedArrayBase::length):

  • html/canvas/Uint16Array.cpp:

(WebCore::Uint16Array::slice):

  • html/canvas/Uint16Array.h:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.cpp:

(WebCore::Uint32Array::slice):

  • html/canvas/Uint32Array.h:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.cpp:

(WebCore::Uint8Array::slice):

  • html/canvas/Uint8Array.h:
  • html/canvas/Uint8Array.idl:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::readPixels):

4:03 PM Changeset in webkit [72342] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-18 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/win/Skipped: Skip fast/forms/form-atribute.html. It needs <progress> support.
3:56 PM Changeset in webkit [72341] by zmo@google.com
  • 7 edits
    7 adds in trunk

2010-11-17 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=47196

  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::ignoresGammaAndColorProfile): Add a getter function for the ignoreGammaAndColorProfile setting.
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode): Hookup ignoreGammaAndColorProfile setting with color profile processing.
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): Ditto.

2010-11-17 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=47196

  • fast/canvas/webgl/gl-teximage-expected.txt:
  • fast/canvas/webgl/gl-teximage.html: Add test cases for images with ICC profiles.
  • fast/canvas/webgl/resources/small-square-with-cie-rgb-profile.png: Added.
  • fast/canvas/webgl/resources/small-square-with-colormatch-profile.png: Added.
  • fast/canvas/webgl/resources/small-square-with-colorspin-profile.jpg: Added.
  • fast/canvas/webgl/resources/small-square-with-colorspin-profile.png: Added.
  • fast/canvas/webgl/resources/small-square-with-e-srgb-profile.png: Added.
  • fast/canvas/webgl/resources/small-square-with-smpte-c-profile.png: Added.
  • fast/canvas/webgl/resources/small-square-with-srgb-iec61966-2.1-profile.png: Added.
3:33 PM Changeset in webkit [72340] by jianli@chromium.org
  • 7 edits
    5 moves
    6 adds
    2 deletes in trunk/LayoutTests

Move fileapi test files under http/tests/local to a new subdirectory under it
https://bugs.webkit.org/show_bug.cgi?id=49709

Reviewed by David Levin.

  • http/tests/local/fileapi/resources/setup-file-input-element-for-drag.js: Renamed from LayoutTests/http/tests/local/resources/setup-file-input-element-for-drag.js.
  • http/tests/local/fileapi/script-tests/TEMPLATE.html: Added.
  • http/tests/local/fileapi/script-tests/send-dragged-file.js: Renamed from LayoutTests/http/tests/local/resources/send-dragged-file.js.
  • http/tests/local/fileapi/script-tests/send-sliced-dragged-file.js: Renamed from LayoutTests/http/tests/local/resources/send-sliced-dragged-file.js.
  • http/tests/local/fileapi/send-dragged-file-expected.txt: Renamed from LayoutTests/http/tests/local/send-dragged-file-expected.txt.
  • http/tests/local/fileapi/send-dragged-file.html: Renamed from LayoutTests/http/tests/local/send-dragged-file.html.
  • http/tests/local/fileapi/send-sliced-dragged-file-expected.txt: Renamed from LayoutTests/http/tests/local/send-sliced-dragged-file-expected.txt.
  • http/tests/local/fileapi/send-sliced-dragged-file.html: Renamed from LayoutTests/http/tests/local/send-sliced-dragged-file.html.
  • platform/gtk/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
3:23 PM Changeset in webkit [72339] by dpranke@chromium.org
  • 4 edits
    2 adds
    1 delete in trunk/WebKitTools

2010-11-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes

Create the first version of the 'message_broker' package. This
class will encapsulate all of the threading/multiprocessing and
message-sending details for the communication between the
'manager' object and the 'worker' objects. For the moment, it
just holds some routines and tests for logging thread stacks.

There should be no functional changes in this patch, just moving stuff
around.

https://bugs.webkit.org/show_bug.cgi?id=49707

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2:46 PM Changeset in webkit [72338] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Add test expectations for failing tests.

  • platform/chromium/test_expectations.txt:
2:30 PM Changeset in webkit [72337] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-11-18 Tony Chang <tony@chromium.org>

Unreviewed, fix chromium compile. We need ipc and openssl now.

  • DEPS:
2:26 PM Changeset in webkit [72336] by sfalken@apple.com
  • 1 edit
    1 delete in trunk/WebKitLibraries

Remove unused debug_internal vsprops file.

Rubber-stamped by Adam Roben.

  • win/tools/vsprops/debug_internal.vsprops: Removed.
2:12 PM Changeset in webkit [72335] by sfalken@apple.com
  • 36 edits in trunk

Remove leftover Windows Debug_Internal configurations
https://bugs.webkit.org/show_bug.cgi?id=49758

Reviewed by Adam Roben.

JavaScriptCore:

WebCore:

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCore.vcproj:

WebKit/win:

  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:

WebKit2:

  • win/WebKit2.vcproj:
  • win/WebKit2WebProcess.vcproj:

WebKitTools:

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
  • MiniBrowser/MiniBrowser.vcproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • WebKitAPITest/WebKitAPITest.vcproj:
  • WebKitTestRunner/win/InjectedBundle.vcproj:
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:
  • WinLauncher/WinLauncher.vcproj:
2:03 PM Changeset in webkit [72334] by levin@chromium.org
  • 3 edits in trunk/WebCore

Unreviewed, rolling out r72299.
http://trac.webkit.org/changeset/72299
https://bugs.webkit.org/show_bug.cgi?id=49761

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-11-18
Broke chromium ui test SessionHistoryTest.FrameBackForward.
(Requested by dave_levin on #webkit).

  • loader/HistoryController.cpp:

(WebCore::HistoryController::HistoryController):
(WebCore::HistoryController::saveDocumentState):
(WebCore::HistoryController::updateForBackForwardNavigation):
(WebCore::HistoryController::updateForCommit):
(WebCore::HistoryController::updateForFrameLoadCompleted):
(WebCore::HistoryController::setCurrentItem):
(WebCore::HistoryController::createItem):
(WebCore::HistoryController::createItemTree):
(WebCore::HistoryController::recursiveGoToItem):

  • loader/HistoryController.h:
1:52 PM Changeset in webkit [72333] by mihaip@chromium.org
  • 92 edits
    89 copies
    9 adds in trunk/LayoutTests

2010-11-18 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

1:50 PM Changeset in webkit [72332] by Darin Adler
  • 2 edits in trunk/WebKit
  • StringsNotToBeLocalized.txt: Updated for recent changes.
1:42 PM Changeset in webkit [72331] by Darin Adler
  • 2 edits in trunk/LayoutTests

Fix failures seen on bot.

  • platform/qt/Skipped: Skip test, added bugs.webkit.org reference.
1:33 PM Changeset in webkit [72330] by Adam Roben
  • 2 edits in trunk/WebKitTools

Add three new Windows XP build slaves

Reviewed by Steve Falkenburg.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Added three

new slaves, and added them to the Windows XP Debug (Tests) builder.

1:29 PM Changeset in webkit [72329] by luiz@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-11-12 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Static platform plugin support
https://bugs.webkit.org/show_bug.cgi?id=49470

Adding support for statically linked platform plugins.

  • WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::QtPlatformPlugin::loadStaticallyLinkedPlugin): (WebCore::QtPlatformPlugin::plugin):
  • WebCoreSupport/QtPlatformPlugin.h:
1:21 PM Changeset in webkit [72328] by andersca@apple.com
  • 4 edits in trunk/WebKit2

Page overlays should be able to handle mouse events
https://bugs.webkit.org/show_bug.cgi?id=49756

Reviewed by John Sullivan.

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
Add API cast function for converting an IntPoint to a WKPoint.

  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(PageOverlayClientImpl::mouseEvent):
Call the appropriate callbacks.

  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:

Add new callbacks.

12:42 PM Changeset in webkit [72327] by sfalken@apple.com
  • 15 edits in trunk

WebCore: [chromium] REGRESSION(72141): Chromium fails acid3 on windows and linux
https://bugs.webkit.org/show_bug.cgi?id=49638

Patch by James Robinson <jamesr@chromium.org> on 2010-11-18
Reviewed by Darin Fisher.

Avoid clamping zero text size to 12pt in FontPlatformData::setupPaint() in FontPlatformDataLinux.cpp
Set all metrics to 0 if the font size is specified as zero in SimpleFontDataChromiumWin.cpp, just
like Safari Win did in r72270.

Test: fast/text/font-size-zero.html

  • platform/graphics/chromium/FontPlatformDataLinux.cpp:

(WebCore::FontPlatformData::setupPaint):

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:

(WebCore::SimpleFontData::platformInit):

WebKit/win: Debug_Internal Windows configuration is unnecessary, should be removed
https://bugs.webkit.org/show_bug.cgi?id=49753

Reviewed by Adam Roben.

  • WebKitPrefix.h:

WebKit2: Keep the web process alive if there are active downloads
https://bugs.webkit.org/show_bug.cgi?id=49755

Patch by Anders Carlsson <andersca@apple.com> on 2010-11-18
Reviewed by Sam Weinig.

Make sure that Download objects are destroyed when the download finishes or fails.
Don't close the web process if there are live Download objects.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::didFail):
Add stub.

  • UIProcess/Downloads/DownloadProxy.h:
  • UIProcess/Downloads/DownloadProxy.messages.in:

Add DidFail message.

  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::didFinish):
Call DownloadManager::downloadFinished.

(WebKit::Download::didFail):
Send DidFail message and call DownloadManager::downloadFinished.

  • WebProcess/Downloads/Download.h:

(WebKit::Download::destinationID):
Call downloadID().

(WebKit::Download::downloadID):
Return the download ID.

  • WebProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::downloadFinished):
Delete the Download object and call WebProcess::shutdownIfPossible.

  • WebProcess/Downloads/DownloadManager.h:

(WebKit::DownloadManager::isDownloading):
Return whether the download manager has any active downloads.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(-[WKDownloadAsDelegate download:didFailWithError:]):
Call Download::didFail.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::removeWebPage):
Call shutdownIfPossible.

(WebKit::WebProcess::shutdownIfPossible):
New function. Don't shutdown if there are live pages or active downloads.

  • WebProcess/WebProcess.h:

WebKitLibraries: Debug_Internal Windows configuration is unnecessary, should be removed
https://bugs.webkit.org/show_bug.cgi?id=49753

Reviewed by Adam Roben.

  • win/tools/vsprops/debug.vsprops:
  • win/tools/vsprops/debug_internal.vsprops:

WebKitTools: update-webkit-support-libs should fall back to existing
WebKitSupportLibrary version if there is no internet connectivity
https://bugs.webkit.org/show_bug.cgi?id=49503

Patch by Daniel Bates <dbates@rim.com> on 2010-11-18
Reviewed by Adam Roben.

Fall back to existing support libraries (if present) when there is
no internet connection.

Currently, update-webkit-support-libs dies with an "out-of-date"
error when there is no internet connection because it cannot
retrieve versioning information from developer.apple.com. Because
update-webkit-support-libs fails, build-webkit fails. Instead,
if there is no internet connection and the support libraries are
present then we should warn the user and exit() with success so
that build-webkit can work without an internet connection.

  • Scripts/update-webkit-support-libs:
12:29 PM Changeset in webkit [72326] by dbates@webkit.org
  • 2 edits in trunk/WebKitTools

2010-11-18 Daniel Bates <dbates@rim.com>

Reviewed by Adam Roben.

update-webkit-support-libs should fall back to existing
WebKitSupportLibrary version if there is no internet connectivity
https://bugs.webkit.org/show_bug.cgi?id=49503

Fall back to existing support libraries (if present) when there is
no internet connection.

Currently, update-webkit-support-libs dies with an "out-of-date"
error when there is no internet connection because it cannot
retrieve versioning information from developer.apple.com. Because
update-webkit-support-libs fails, build-webkit fails. Instead,
if there is no internet connection and the support libraries are
present then we should warn the user and exit() with success so
that build-webkit can work without an internet connection.

  • Scripts/update-webkit-support-libs:
12:26 PM Changeset in webkit [72325] by Adam Roben
  • 1 edit
    3 adds in trunk/LayoutTests

Add Windows results for test added in r71980

  • platform/win/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum: Added.
  • platform/win/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
  • platform/win/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Added.
12:10 PM Changeset in webkit [72324] by jamesr@google.com
  • 4 edits
    3 adds in trunk

2010-11-18 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

[chromium] REGRESSION(72141): Chromium fails acid3 on windows and linux
https://bugs.webkit.org/show_bug.cgi?id=49638

Adds a test checking that the bounding client rect of a text run with font-size:0
has zero height. This is also covered by acid3, but an isolated test case is easier
to work with.

  • fast/text/font-size-zero-expected.txt: Added.
  • fast/text/font-size-zero.html: Added.
  • fast/text/script-tests/font-size-zero.js: Added.

2010-11-18 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

[chromium] REGRESSION(72141): Chromium fails acid3 on windows and linux
https://bugs.webkit.org/show_bug.cgi?id=49638

Avoid clamping zero text size to 12pt in FontPlatformData::setupPaint() in FontPlatformDataLinux.cpp
Set all metrics to 0 if the font size is specified as zero in SimpleFontDataChromiumWin.cpp, just
like Safari Win did in r72270.

Test: fast/text/font-size-zero.html

  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint):
  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformInit):
12:06 PM Changeset in webkit [72323] by andersca@apple.com
  • 11 edits in trunk/WebKit2

Keep the web process alive if there are active downloads
https://bugs.webkit.org/show_bug.cgi?id=49755

Reviewed by Sam Weinig.

Make sure that Download objects are destroyed when the download finishes or fails.
Don't close the web process if there are live Download objects.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::didFail):
Add stub.

  • UIProcess/Downloads/DownloadProxy.h:
  • UIProcess/Downloads/DownloadProxy.messages.in:

Add DidFail message.

  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::didFinish):
Call DownloadManager::downloadFinished.

(WebKit::Download::didFail):
Send DidFail message and call DownloadManager::downloadFinished.

  • WebProcess/Downloads/Download.h:

(WebKit::Download::destinationID):
Call downloadID().

(WebKit::Download::downloadID):
Return the download ID.

  • WebProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::downloadFinished):
Delete the Download object and call WebProcess::shutdownIfPossible.

  • WebProcess/Downloads/DownloadManager.h:

(WebKit::DownloadManager::isDownloading):
Return whether the download manager has any active downloads.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(-[WKDownloadAsDelegate download:didFailWithError:]):
Call Download::didFail.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::removeWebPage):
Call shutdownIfPossible.

(WebKit::WebProcess::shutdownIfPossible):
New function. Don't shutdown if there are live pages or active downloads.

  • WebProcess/WebProcess.h:
12:02 PM Changeset in webkit [72322] by Adam Roben
  • 2 edits in trunk/LayoutTests

Update Windows results after r72050

  • platform/win/fast/dom/Window/window-postmessage-clone-frames-expected.txt:
12:01 PM Changeset in webkit [72321] by rwlbuis@webkit.org
  • 2 edits in trunk/WebCore

2010-11-18 Rob Buis <rwlbuis@gmail.com>

Reviewed by Simon Fraser.

Only inject fullscreen.css when in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=49510

Refactor to only add fullscreen sheet rules when document is in fullscreen mode.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::loadFullDefaultStyle): (WebCore::loadFullScreenRulesIfNeeded): (WebCore::CSSStyleSelector::styleForElement):
11:55 AM Changeset in webkit [72320] by mihaip@chromium.org
  • 1 edit
    40 adds in trunk/LayoutTests

2010-11-18 Mihai Parparita <mihaip@chromium.org>

Add missing mac pixel baselines (all baselines are for Snow Leopard).

  • platform/mac/css1/text_properties/text_transform-expected.checksum: Added.
  • platform/mac/css1/text_properties/text_transform-expected.png: Added.
  • platform/mac/fast/canvas/toDataURL-alpha-expected.checksum: Added.
  • platform/mac/fast/canvas/toDataURL-alpha-expected.png: Added.
  • platform/mac/fast/repaint/canvas-putImageData-expected.checksum: Added.
  • platform/mac/fast/repaint/canvas-putImageData-expected.png: Added.
  • platform/mac/fast/table/early-table-layout-expected.checksum: Added.
  • platform/mac/fast/table/early-table-layout-expected.png: Added.
  • platform/mac/media/video-canvas-alpha-expected.checksum: Added.
  • platform/mac/media/video-canvas-alpha-expected.png: Added.
  • platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum: Added.
  • platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • platform/mac/svg/text/text-intro-05-t-expected.png: Added.
  • platform/mac/transforms/3d/hit-testing/backface-hit-test-expected.checksum: Added.
  • platform/mac/transforms/3d/hit-testing/backface-hit-test-expected.png: Added.
  • platform/mac/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.checksum: Added.
  • platform/mac/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.png: Added.
  • platform/mac/transforms/3d/hit-testing/rotated-hit-test-expected.checksum: Added.
  • platform/mac/transforms/3d/hit-testing/rotated-hit-test-expected.png: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.checksum: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.png: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-3-expected.checksum: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-3-expected.png: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.checksum: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.checksum: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.checksum: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.checksum: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.checksum: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.checksum: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
11:54 AM Changeset in webkit [72319] by jamesr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-11-18 James Robinson <jamesr@chromium.org>

Reviewed by David Levin.

[chromium] Update chromium DEPS to r66658 to pick up skia roll
https://bugs.webkit.org/show_bug.cgi?id=49754

  • DEPS:
11:47 AM Changeset in webkit [72318] by Adam Roben
  • 1 edit
    6 adds in trunk/LayoutTests

Land new Windows results for tests from r72235

  • platform/win/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
  • platform/win/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
  • platform/win/fast/blockflow/vertical-align-table-baseline-expected.txt: Added.
  • platform/win/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
  • platform/win/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
  • platform/win/fast/blockflow/vertical-baseline-alignment-expected.txt: Added.
11:21 AM Changeset in webkit [72317] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Removing various items from expectations to reflect the current state.

  • platform/chromium/test_expectations.txt:
11:18 AM Changeset in webkit [72316] by sfalken@apple.com
  • 9 edits in trunk

Clean up vcproj errors
https://bugs.webkit.org/show_bug.cgi?id=49741

Reviewed by Adam Roben.

WebCore:

  • WebCore.vcproj/WebCore.vcproj:

WebKit2:

  • win/WebKit2WebProcess.vcproj:

WebKitTools:

  • MiniBrowser/MiniBrowser.vcproj:
  • WebKitAPITest/WebKitAPITest.vcproj:
  • WebKitTestRunner/win/InjectedBundle.vcproj:
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:
11:12 AM Changeset in webkit [72315] by ap@apple.com
  • 5 edits in trunk/WebCore

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=49694
Add some comments about XSLStyleSheet owner node

No change in behavior, so no tests.

  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  • xml/XSLStyleSheet.h: (WebCore::XSLStyleSheet::create): (WebCore::XSLStyleSheet::createEmbedded): (WebCore::XSLStyleSheet::createForXSLTProcessor):
  • xml/XSLStyleSheetLibxslt.cpp: (WebCore::XSLStyleSheet::XSLStyleSheet):
  • xml/XSLTProcessorLibxslt.cpp: (WebCore::xsltStylesheetPointer):
  • xml/XSLTProcessorQt.cpp: (WebCore::XSLTProcessor::transformToString):
11:06 AM Changeset in webkit [72314] by hayato@chromium.org
  • 2 edits in trunk/WebKitTools

2010-11-18 Hayato Ito <hayato@chromium.org>

Reviewed by Shinichiro Hamaji.

[NRWT] Fix a break of '--new-baseline' feature in pixel_test
which is caused by r72249.

https://bugs.webkit.org/show_bug.cgi?id=49751

  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
11:00 AM Changeset in webkit [72313] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-18 Tony Chang <tony@chromium.org>

Unreviewed, updating qt Skipped list.

  • platform/qt/Skipped:
10:51 AM Changeset in webkit [72312] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-18 Mihai Parparita <mihaip@chromium.org>

Unreviewed Mac expectations update.

r71700 and r72173 updated some Mac baselines recently, more tests now
pass when run with the DRT.

  • platform/mac/test_expectations.txt:
10:48 AM Changeset in webkit [72311] by Adam Roben
  • 4 edits in trunk

Implement layoutTestController.waitForPolicyDelegate on Windows

Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.

Reviewed by Simon Fraser.

LayoutTests:

Unskip tests that rely on layoutTestController.waitForPolicyDelegate on
Windows

  • platform/win/Skipped:

WebKitTools:

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::waitForPolicyDelegate): Implemented by porting
code from LayoutTestControllerMac.mm.

10:43 AM Changeset in webkit [72310] by antonm@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

Not reviewed, rebaselining fast/parser/style-script-head-test.html

  • platform/chromium-linux/fast/parser/style-script-head-test-expected.txt: Added.
  • platform/chromium-win/fast/parser/style-script-head-test-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:33 AM Changeset in webkit [72309] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-11-18 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Fix introspection build, we were missing a -I flag.

  • GNUmakefile.am:
10:31 AM Changeset in webkit [72308] by ap@apple.com
  • 2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=49743
[Qt] fast/xsl/import-non-document-node.xhtml fails

  • platform/qt/Skipped: Disabling the new test for Qt.
10:29 AM Changeset in webkit [72307] by hayato@chromium.org
  • 2 edits in trunk/WebKitTools

2010-11-18 Hayato Ito <hayato@chromium.org>

Reviewed by Shinichiro Hamaji.

[NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.

https://bugs.webkit.org/show_bug.cgi?id=49740

  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
10:23 AM Changeset in webkit [72306] by jorlow@chromium.org
  • 7 edits in trunk/WebKit/chromium

2010-11-18 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

[chromium] IndexedDB API cleanup
https://bugs.webkit.org/show_bug.cgi?id=49733

Make it so that you can't directly instantiate our "interface"
classes. Remove some code for 2 sided merges.

  • public/WebIDBCursor.h: (WebKit::WebIDBCursor::WebIDBCursor):
  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::WebIDBDatabase):
  • public/WebIDBIndex.h: (WebKit::WebIDBIndex::WebIDBIndex):
  • public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::WebIDBObjectStore):
  • public/WebIDBTransaction.h: (WebKit::WebIDBTransaction::WebIDBTransaction):
  • src/IDBTransactionBackendProxy.cpp: (WebCore::IDBTransactionBackendProxy::IDBTransactionBackendProxy):
10:09 AM Changeset in webkit [72305] by benjamin.poulain@nokia.com
  • 3 edits in trunk/WebKit2

2010-11-18 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] [WK2] WebKit 2 would not compile for Qt without ENABLE_TOUCH_EVENT
https://bugs.webkit.org/show_bug.cgi?id=49664

Move the ENABLE(TOUCH_EVENTS) to the code where internal WebKit touch
types are used.

  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::touchEvent):
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::touchEvent):
10:09 AM Changeset in webkit [72304] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

2010-11-16 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

REGRESSION (Safari 5.0.1): HTML5 videos on YouTube never start playing on Windows
https://bugs.webkit.org/show_bug.cgi?id=44439
<rdar://problem/8342407>


setUpCookiesForQuickTime() previously depended on having setFrameView() called first
in order to get a Frame, and when it wasn't set, the cookie-copy failed. Now,
setUpCookiesForQuickTime uses the MediaPlayerClient function mediaPlayerOwningDocument()
to retrieve the document and subsequently, the Frame.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpCookiesForQuickTime):
9:59 AM Changeset in webkit [72303] by Joseph Pecoraro
  • 8 edits
    6 adds in trunk

2010-11-18 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Allow no-store resources to be used for back navigation
https://bugs.webkit.org/show_bug.cgi?id=49672

Add tests for checking if the cache was used for a "Cache-control: no-store"
resource in back navigation, reload navigation, and normal navigation.

  • http/tests/cache/history-only-cached-subresource-loads-expected.txt: Added.
  • http/tests/cache/history-only-cached-subresource-loads.html: Added.
  • http/tests/cache/resources/no-store-resource-forward.html: Added.
  • http/tests/cache/resources/no-store-resource-next.html: Added.
  • http/tests/cache/resources/no-store-resource.html: Added.
  • http/tests/cache/resources/random.cgi: Added.

2010-11-18 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Allow no-store resources to be used for back navigation
https://bugs.webkit.org/show_bug.cgi?id=49672

Test: http/tests/cache/history-only-cached-subresource-loads.html

HTTP allows "Cache-Control: no-store" resources to "cached" for the
purposes of history, such as back/forward navigation. Previously
WebCore just immediately evicted these resources, now we leave them in
the cache as long as they are not "https". This allows us to use them
if they are used in a back navigation, or lazily evict and replace
them on other load types expecting non-stale resources.

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::removeClient): instead of immediately removing the resource from the cache, leave it in the cache.

  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::checkForReload): (WebCore::CachedResourceLoader::requestResource): allow history only resources if the CachePolicy is CachePolicyHistoryBuffer (back/forward navigation).
  • loader/cache/MemoryCache.cpp: (WebCore::MemoryCache::requestResource): lazily remove history only resources if it is requested for a load type expecting non-stale resources.
  • loader/cache/MemoryCache.h: default the forHistory parameter to false.

Rename cache policy CachePolicyAllowStale to CachePolicyHistoryBuffer.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::subresourceCachePolicy):
  • loader/cache/CachePolicy.h:
  • loader/cache/CachedResource.cpp:
9:54 AM Changeset in webkit [72302] by tony@chromium.org
  • 6 edits
    2 moves in trunk

2010-11-18 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

run platform/chromium/plugins/refcount-leaks.html on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49485

Moving the test into the top level plugins dir.

  • platform/chromium/drt_expectations.txt:
  • platform/chromium/plugins/refcount-leaks-expected.txt: Removed.
  • platform/chromium/plugins/refcount-leaks.html: Removed.
  • plugins/refcount-leaks-expected.txt: Copied from LayoutTests/platform/chromium/plugins/refcount-leaks-expected.txt.
  • plugins/refcount-leaks.html: Copied from LayoutTests/platform/chromium/plugins/refcount-leaks.html.

2010-11-18 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

run platform/chromium/plugins/refcount-leaks.html on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49485

Add PluginObject.testObjectCount which returns the number of allocated
TestObjects. Add PluginObject.testCreateTestObject which allocates
and returns a TestObject.

Add TestObject.refCount which returns the number of refs on the
TestObject.

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (pluginGetProperty): (pluginInvoke):
  • DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: (getTestObjectCount): (testAllocate): (testDeallocate): (testGetProperty): (testScriptObjectInvoke): Release a ref to a plugin object that was

previously leaked.

  • DumpRenderTree/TestNetscapePlugIn/TestObject.h:
9:48 AM Changeset in webkit [72301] by ap@apple.com
  • 4 edits
    2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=49700
XSLTProcessor.importNode is only tested with document nodes, and hits an assertion

Test: fast/xsl/import-non-document-node.xhtml

  • css/CSSStyleSheet.cpp: (WebCore::isAcceptableCSSStyleSheetParent): (WebCore::CSSStyleSheet::CSSStyleSheet):
  • css/StyleSheet.cpp: (WebCore::StyleSheet::StyleSheet): Moved the assertion - hopefully, it's valid for CSS stylesheets.
9:39 AM Changeset in webkit [72300] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, proper regrouping of suppressions.

  • platform/chromium/test_expectations.txt:
9:35 AM Changeset in webkit [72299] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-11-18 Charlie Reis <creis@chromium.org>

Reviewed by Darin Fisher.

Update correct content state during back/forward navigations
https://bugs.webkit.org/show_bug.cgi?id=48809

Ensures that history's previousItem is non-null when clients try to
update content state (e.g., Chromium's UpdateSessionHistory). We now
track load completions with a boolean field rather than by clearing
previousItem.

Behavior covered by existing tests in fast/history and fast/loader.

  • loader/HistoryController.cpp:
9:34 AM Changeset in webkit [72298] by antonm@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

Not reviewed, 1st fixing failures of fast/dom/setPrimitiveValue-exceptions.html
https://bugs.webkit.org/show_bug.cgi?id=49653

There is apparently a crash in Win DBG build so I'm keeping the suppression.

  • platform/chromium-mac/fast/dom/setPrimitiveValue-exceptions-expected.txt: Added.
  • platform/chromium-win/fast/dom/setPrimitiveValue-exceptions-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
9:26 AM Changeset in webkit [72297] by sfalken@apple.com
  • 3 edits
    4 adds in trunk/WebKitTools

WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
https://bugs.webkit.org/show_bug.cgi?id=49711

Reviewed by Adam Roben.

  • WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
  • WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
  • WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:
  • record-memory-win/record-memory-win-common.vsprops: Added.
  • record-memory-win/record-memory-win.vcproj:
9:14 AM Changeset in webkit [72296] by sfalken@apple.com
  • 2 edits
    1 add in trunk/WebKit/win

WebKit Interfaces project should use vsprops file for common build settings
https://bugs.webkit.org/show_bug.cgi?id=49713

Reviewed by Adam Roben.

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/InterfacesCommon.vsprops: Added.
9:06 AM Changeset in webkit [72295] by abecsi@webkit.org
  • 2 edits in trunk/WebKitTools

2010-11-18 Andras Becsi <abecsi@inf.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt][WK2] Only add user agent strings to the list which aren't listed yet.

  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::updateUserAgentList):
8:36 AM Changeset in webkit [72294] by commit-queue@webkit.org
  • 73 edits
    12 copies
    3 adds
    44 deletes in trunk

2010-11-18 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72288.
http://trac.webkit.org/changeset/72288
https://bugs.webkit.org/show_bug.cgi?id=49730

'krit attempted to do that, but revert got stuck' (Requested
by antonm on #webkit).

  • platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Removed.
  • platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Removed.
  • platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Removed.
  • platform/mac/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
  • platform/mac/svg/dom/SVGPathSegList-appendItem-expected.checksum: Removed.
  • platform/mac/svg/dom/SVGPathSegList-appendItem-expected.png: Removed.
  • platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Removed.
  • platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Removed.
  • platform/mac/svg/dom/SVGPathSegList-cloning-expected.checksum: Removed.
  • platform/mac/svg/dom/SVGPathSegList-cloning-expected.png: Removed.
  • platform/mac/svg/dom/SVGPathSegList-cloning-expected.txt: Removed.
  • platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Removed.
  • platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Removed.
  • platform/mac/svg/dom/SVGPathSegList-removeItem-expected.checksum: Removed.
  • platform/mac/svg/dom/SVGPathSegList-removeItem-expected.png: Removed.
  • platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Removed.
  • platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.png: Removed.
  • platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Removed.
  • platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.png: Removed.
  • platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.txt: Removed.
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.checksum: Removed.
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Removed.
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Removed.
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Removed.
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Removed.
  • svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg: Removed.
  • svg/dom/SVGPathSegList-appendItem-expected.txt: Removed.
  • svg/dom/SVGPathSegList-appendItem.xhtml: Removed.
  • svg/dom/SVGPathSegList-clear-and-initialize-expected.txt: Removed.
  • svg/dom/SVGPathSegList-clear-and-initialize.xhtml: Removed.
  • svg/dom/SVGPathSegList-cloning.html: Removed.
  • svg/dom/SVGPathSegList-insertItemBefore-expected.txt: Removed.
  • svg/dom/SVGPathSegList-insertItemBefore.xhtml: Removed.
  • svg/dom/SVGPathSegList-removeItem-expected.txt: Removed.
  • svg/dom/SVGPathSegList-removeItem.xhtml: Removed.
  • svg/dom/SVGPathSegList-replaceItem-expected.txt: Removed.
  • svg/dom/SVGPathSegList-replaceItem.xhtml: Removed.
  • svg/dom/SVGPathSegList-segment-modification.svg: Removed.
  • svg/dom/SVGPathSegList-xml-dom-synchronization-expected.txt: Removed.
  • svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml: Removed.
  • svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml: Removed.
  • svg/dom/fuzz-path-parser-expected.txt:
  • svg/dom/path-parser-expected.txt:
  • svg/dom/script-tests/path-parser.js: ():
  • svg/dom/svglist-exception-on-out-bounds-error-expected.txt:
  • svg/dom/svglist-exception-on-out-bounds-error.html:
  • svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:

2010-11-18 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72288.
http://trac.webkit.org/changeset/72288
https://bugs.webkit.org/show_bug.cgi?id=49730

'krit attempted to do that, but revert got stuck' (Requested
by antonm on #webkit).

  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMBinding.cpp: (WebCore::setDOMException):
  • bindings/js/JSDOMBinding.h: (WebCore::createDOMObjectWrapper): (WebCore::getDOMObjectWrapper):
  • bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS):
  • bindings/js/JSSVGPathSegListCustom.cpp: Added. (WebCore::JSSVGPathSegList::clear): (WebCore::JSSVGPathSegList::initialize): (WebCore::JSSVGPathSegList::getItem): (WebCore::JSSVGPathSegList::insertItemBefore): (WebCore::JSSVGPathSegList::replaceItem): (WebCore::JSSVGPathSegList::removeItem): (WebCore::JSSVGPathSegList::appendItem):
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::operator<<):
  • svg/SVGAllInOne.cpp:
  • svg/SVGAnimatedPathData.cpp: Added.
  • svg/SVGAnimatedPathData.h: Copied from WebCore/svg/SVGPathSegClosePath.h. (WebCore::SVGAnimatedPathData::~SVGAnimatedPathData):
  • svg/SVGAnimatedPathData.idl: Copied from WebCore/svg/SVGPathSegCurvetoQuadraticAbs.idl.
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::SVGPathElement): (WebCore::SVGPathElement::getPathSegAtLength): (WebCore::SVGPathElement::createSVGPathSegClosePath): (WebCore::SVGPathElement::createSVGPathSegMovetoAbs): (WebCore::SVGPathElement::createSVGPathSegMovetoRel): (WebCore::SVGPathElement::createSVGPathSegLinetoAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel): (WebCore::SVGPathElement::createSVGPathSegArcAbs): (WebCore::SVGPathElement::createSVGPathSegArcRel): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel): (WebCore::SVGPathElement::parseMappedAttribute): (WebCore::SVGPathElement::svgAttributeChanged): (WebCore::SVGPathElement::synchronizeProperty): (WebCore::SVGPathElement::pathSegList): (WebCore::SVGPathElement::normalizedPathSegList): (WebCore::SVGPathElement::animatedPathSegList): (WebCore::SVGPathElement::animatedNormalizedPathSegList): (WebCore::SVGPathElement::toPathData):
  • svg/SVGPathElement.h: (WebCore::SVGPathElement::isValid): (WebCore::SVGPathElement::supportsMarkers):
  • svg/SVGPathElement.idl:
  • svg/SVGPathParserFactory.cpp: (WebCore::globalSVGPathSegListBuilder): (WebCore::SVGPathParserFactory::buildPathFromByteStream): (WebCore::SVGPathParserFactory::buildPathFromSVGPathSegList): (WebCore::SVGPathParserFactory::buildSVGPathSegListFromString): (WebCore::SVGPathParserFactory::buildSVGPathSegListFromByteStream): (WebCore::SVGPathParserFactory::buildStringFromSVGPathSegList): (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString): (WebCore::SVGPathParserFactory::buildAnimatedSVGPathByteStream): (WebCore::SVGPathParserFactory::getSVGPathSegAtLengthFromSVGPathSegList):
  • svg/SVGPathParserFactory.h:
  • svg/SVGPathSeg.cpp: Copied from WebCore/svg/SVGPathSegLinetoHorizontalRel.idl. (WebCore::SVGPathSeg::associatedAttributeName):
  • svg/SVGPathSeg.h: (WebCore::SVGPathSegSingleCoord::setX): (WebCore::SVGPathSegSingleCoord::x): (WebCore::SVGPathSegSingleCoord::setY): (WebCore::SVGPathSegSingleCoord::y): (WebCore::SVGPathSegSingleCoord::SVGPathSegSingleCoord):
  • svg/SVGPathSeg.idl:
  • svg/SVGPathSegArc.cpp: Copied from WebCore/svg/SVGPathSegClosePath.h. (WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs): (WebCore::SVGPathSegArcRel::SVGPathSegArcRel):
  • svg/SVGPathSegArc.h: (WebCore::SVGPathSegArc::SVGPathSegArc): (WebCore::SVGPathSegArc::setX): (WebCore::SVGPathSegArc::x): (WebCore::SVGPathSegArc::setY): (WebCore::SVGPathSegArc::y): (WebCore::SVGPathSegArc::setR1): (WebCore::SVGPathSegArc::r1): (WebCore::SVGPathSegArc::setR2): (WebCore::SVGPathSegArc::r2): (WebCore::SVGPathSegArc::setAngle): (WebCore::SVGPathSegArc::angle): (WebCore::SVGPathSegArc::setLargeArcFlag): (WebCore::SVGPathSegArc::largeArcFlag): (WebCore::SVGPathSegArc::setSweepFlag): (WebCore::SVGPathSegArc::sweepFlag): (WebCore::SVGPathSegArcAbs::create): (WebCore::SVGPathSegArcAbs::pathSegType): (WebCore::SVGPathSegArcAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegArcRel::create): (WebCore::SVGPathSegArcRel::pathSegType): (WebCore::SVGPathSegArcRel::pathSegTypeAsLetter):
  • svg/SVGPathSegArcAbs.idl:
  • svg/SVGPathSegArcRel.idl:
  • svg/SVGPathSegClosePath.cpp: Added.
  • svg/SVGPathSegClosePath.h: (WebCore::SVGPathSegClosePath::create): (WebCore::SVGPathSegClosePath::SVGPathSegClosePath):
  • svg/SVGPathSegCurvetoCubic.cpp: Copied from WebCore/svg/SVGPathSegClosePath.h. (WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs): (WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel):
  • svg/SVGPathSegCurvetoCubic.h: (WebCore::SVGPathSegCurvetoCubic::SVGPathSegCurvetoCubic): (WebCore::SVGPathSegCurvetoCubic::setX): (WebCore::SVGPathSegCurvetoCubic::x): (WebCore::SVGPathSegCurvetoCubic::setY): (WebCore::SVGPathSegCurvetoCubic::y): (WebCore::SVGPathSegCurvetoCubic::setX1): (WebCore::SVGPathSegCurvetoCubic::x1): (WebCore::SVGPathSegCurvetoCubic::setY1): (WebCore::SVGPathSegCurvetoCubic::y1): (WebCore::SVGPathSegCurvetoCubic::setX2): (WebCore::SVGPathSegCurvetoCubic::x2): (WebCore::SVGPathSegCurvetoCubic::setY2): (WebCore::SVGPathSegCurvetoCubic::y2): (WebCore::SVGPathSegCurvetoCubicAbs::create): (WebCore::SVGPathSegCurvetoCubicAbs::pathSegType): (WebCore::SVGPathSegCurvetoCubicAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegCurvetoCubicRel::create): (WebCore::SVGPathSegCurvetoCubicRel::pathSegType): (WebCore::SVGPathSegCurvetoCubicRel::pathSegTypeAsLetter):
  • svg/SVGPathSegCurvetoCubicAbs.idl:
  • svg/SVGPathSegCurvetoCubicRel.idl:
  • svg/SVGPathSegCurvetoCubicSmooth.cpp: Copied from WebCore/svg/SVGPathSegClosePath.h. (WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs): (WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel):
  • svg/SVGPathSegCurvetoCubicSmooth.h: (WebCore::SVGPathSegCurvetoCubicSmooth::SVGPathSegCurvetoCubicSmooth): (WebCore::SVGPathSegCurvetoCubicSmooth::setX): (WebCore::SVGPathSegCurvetoCubicSmooth::x): (WebCore::SVGPathSegCurvetoCubicSmooth::setY): (WebCore::SVGPathSegCurvetoCubicSmooth::y): (WebCore::SVGPathSegCurvetoCubicSmooth::setX2): (WebCore::SVGPathSegCurvetoCubicSmooth::x2): (WebCore::SVGPathSegCurvetoCubicSmooth::setY2): (WebCore::SVGPathSegCurvetoCubicSmooth::y2): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::create): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::pathSegType): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegCurvetoCubicSmoothRel::create): (WebCore::SVGPathSegCurvetoCubicSmoothRel::pathSegType): (WebCore::SVGPathSegCurvetoCubicSmoothRel::pathSegTypeAsLetter):
  • svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
  • svg/SVGPathSegCurvetoCubicSmoothRel.idl:
  • svg/SVGPathSegCurvetoQuadratic.cpp: Copied from WebCore/svg/SVGPathSegClosePath.h. (WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs): (WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel):
  • svg/SVGPathSegCurvetoQuadratic.h: (WebCore::SVGPathSegCurvetoQuadratic::SVGPathSegCurvetoQuadratic): (WebCore::SVGPathSegCurvetoQuadratic::setX): (WebCore::SVGPathSegCurvetoQuadratic::x): (WebCore::SVGPathSegCurvetoQuadratic::setY): (WebCore::SVGPathSegCurvetoQuadratic::y): (WebCore::SVGPathSegCurvetoQuadratic::setX1): (WebCore::SVGPathSegCurvetoQuadratic::x1): (WebCore::SVGPathSegCurvetoQuadratic::setY1): (WebCore::SVGPathSegCurvetoQuadratic::y1): (WebCore::SVGPathSegCurvetoQuadraticAbs::create): (WebCore::SVGPathSegCurvetoQuadraticAbs::pathSegType): (WebCore::SVGPathSegCurvetoQuadraticAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegCurvetoQuadraticRel::create): (WebCore::SVGPathSegCurvetoQuadraticRel::pathSegType): (WebCore::SVGPathSegCurvetoQuadraticRel::pathSegTypeAsLetter):
  • svg/SVGPathSegCurvetoQuadraticAbs.idl:
  • svg/SVGPathSegCurvetoQuadraticRel.idl:
  • svg/SVGPathSegCurvetoQuadraticSmooth.cpp: Copied from WebCore/svg/SVGPathSegClosePath.h. (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel):
  • svg/SVGPathSegCurvetoQuadraticSmooth.h: (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::create): (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::pathSegType): (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::create): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::pathSegType): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::pathSegTypeAsLetter):
  • svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
  • svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
  • svg/SVGPathSegLineto.cpp: Copied from WebCore/svg/SVGPathSegClosePath.h. (WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs): (WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel):
  • svg/SVGPathSegLineto.h: (WebCore::SVGPathSegLinetoAbs::create): (WebCore::SVGPathSegLinetoAbs::pathSegType): (WebCore::SVGPathSegLinetoAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegLinetoRel::create): (WebCore::SVGPathSegLinetoRel::pathSegType): (WebCore::SVGPathSegLinetoRel::pathSegTypeAsLetter):
  • svg/SVGPathSegLinetoAbs.idl:
  • svg/SVGPathSegLinetoHorizontal.cpp: Copied from WebCore/svg/SVGPathSegClosePath.h. (WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs): (WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel):
  • svg/SVGPathSegLinetoHorizontal.h: (WebCore::SVGPathSegLinetoHorizontal::SVGPathSegLinetoHorizontal): (WebCore::SVGPathSegLinetoHorizontal::setX): (WebCore::SVGPathSegLinetoHorizontal::x): (WebCore::SVGPathSegLinetoHorizontalAbs::create): (WebCore::SVGPathSegLinetoHorizontalAbs::pathSegType): (WebCore::SVGPathSegLinetoHorizontalAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegLinetoHorizontalRel::create): (WebCore::SVGPathSegLinetoHorizontalRel::pathSegType): (WebCore::SVGPathSegLinetoHorizontalRel::pathSegTypeAsLetter):
  • svg/SVGPathSegLinetoHorizontalAbs.idl:
  • svg/SVGPathSegLinetoHorizontalRel.idl:
  • svg/SVGPathSegLinetoRel.idl:
  • svg/SVGPathSegLinetoVertical.cpp: Copied from WebCore/svg/SVGPathSegClosePath.h. (WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs): (WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel):
  • svg/SVGPathSegLinetoVertical.h: (WebCore::SVGPathSegLinetoVertical::SVGPathSegLinetoVertical): (WebCore::SVGPathSegLinetoVertical::setY): (WebCore::SVGPathSegLinetoVertical::y): (WebCore::SVGPathSegLinetoVerticalAbs::create): (WebCore::SVGPathSegLinetoVerticalAbs::pathSegType): (WebCore::SVGPathSegLinetoVerticalAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegLinetoVerticalRel::create): (WebCore::SVGPathSegLinetoVerticalRel::pathSegType): (WebCore::SVGPathSegLinetoVerticalRel::pathSegTypeAsLetter):
  • svg/SVGPathSegLinetoVerticalAbs.idl:
  • svg/SVGPathSegLinetoVerticalRel.idl:
  • svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::SVGPathSegList):
  • svg/SVGPathSegList.h: (WebCore::SVGPathSegList::create):
  • svg/SVGPathSegList.idl:
  • svg/SVGPathSegListBuilder.cpp: (WebCore::SVGPathSegListBuilder::SVGPathSegListBuilder): (WebCore::SVGPathSegListBuilder::moveTo): (WebCore::SVGPathSegListBuilder::lineTo): (WebCore::SVGPathSegListBuilder::lineToHorizontal): (WebCore::SVGPathSegListBuilder::lineToVertical): (WebCore::SVGPathSegListBuilder::curveToCubic): (WebCore::SVGPathSegListBuilder::curveToCubicSmooth): (WebCore::SVGPathSegListBuilder::curveToQuadratic): (WebCore::SVGPathSegListBuilder::curveToQuadraticSmooth): (WebCore::SVGPathSegListBuilder::arcTo): (WebCore::SVGPathSegListBuilder::closePath):
  • svg/SVGPathSegListBuilder.h: (WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegList): (WebCore::SVGPathSegListBuilder::cleanup):
  • svg/SVGPathSegListSource.cpp: (WebCore::SVGPathSegListSource::SVGPathSegListSource): (WebCore::SVGPathSegListSource::parseSVGSegmentType): (WebCore::SVGPathSegListSource::nextCommand): (WebCore::SVGPathSegListSource::parseMoveToSegment): (WebCore::SVGPathSegListSource::parseLineToSegment): (WebCore::SVGPathSegListSource::parseCurveToQuadraticSmoothSegment):
  • svg/SVGPathSegListSource.h: (WebCore::SVGPathSegListSource::create):
  • svg/SVGPathSegMoveto.cpp: Copied from WebCore/svg/SVGPathSegClosePath.h. (WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs): (WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel):
  • svg/SVGPathSegMoveto.h: (WebCore::SVGPathSegMovetoAbs::create): (WebCore::SVGPathSegMovetoAbs::pathSegType): (WebCore::SVGPathSegMovetoAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegMovetoRel::create): (WebCore::SVGPathSegMovetoRel::pathSegType): (WebCore::SVGPathSegMovetoRel::pathSegTypeAsLetter):
  • svg/SVGPathSegMovetoAbs.idl:
  • svg/SVGPathSegMovetoRel.idl:
  • svg/SVGPathSegWithContext.h: Removed.
  • svg/properties/SVGAnimatedPathSegListPropertyTearOff.h: Removed.
  • svg/properties/SVGPathSegListPropertyTearOff.cpp: Removed.
  • svg/properties/SVGPathSegListPropertyTearOff.h: Removed.

2010-11-18 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72288.
http://trac.webkit.org/changeset/72288
https://bugs.webkit.org/show_bug.cgi?id=49730

'krit attempted to do that, but revert got stuck' (Requested
by antonm on #webkit).

  • WebView/WebRenderLayer.mm:
7:39 AM Changeset in webkit [72293] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-11-18 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72292.
http://trac.webkit.org/changeset/72292
https://bugs.webkit.org/show_bug.cgi?id=49732

will break win build (Requested by loislo on #webkit).

  • inspector/CodeGeneratorInspector.pm:
7:33 AM Changeset in webkit [72292] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-11-18 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: reduce the footprint of InspectorBackendDispatcher.
InspectorBackendDispatcher is a generated file.
Its content is not optimal and loc may be reduced by a quarter.
In each generated function we have a code for getting 'in' values from
the arguments properties object. I've extracted this code into separate getters.
The side effect is better readability of the generated code.

https://bugs.webkit.org/show_bug.cgi?id=49729

  • inspector/CodeGeneratorInspector.pm:
6:47 AM Changeset in webkit [72291] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, removing rebaselined expectation for fast/backgrounds/size/contain-and-cover.html

  • platform/chromium/test_expectations.txt:
6:42 AM Changeset in webkit [72290] by apavlov@chromium.org
  • 4 edits in trunk

2010-11-18 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

[v8] fast/css/getFloatValueForUnit.html fails since http://trac.webkit.org/changeset/72189
https://bugs.webkit.org/show_bug.cgi?id=49656

WebCore:

  • bindings/scripts/CodeGeneratorV8.pm:

LayoutTests:

  • platform/chromium/test_expectations.txt:
5:51 AM Changeset in webkit [72289] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-11-18 Chao-ying Fu <fu@mips.com>

Reviewed by Csaba Osztrogonác.

Avoid increasing required alignment of target type warning
https://bugs.webkit.org/show_bug.cgi?id=43963

  • runtime/UString.h: (JSC::UStringHash::equal):
  • wtf/StdLibExtras.h:
5:42 AM Changeset in webkit [72288] by Nikolas Zimmermann
  • 73 edits
    44 adds
    15 deletes in trunk

2010-11-18 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=49580

SVGPathElement.cloneNode loses generated pathSegList
https://bugs.webkit.org/show_bug.cgi?id=43388

SVG Path elements are not correctly updated through pathSegList manipulation on relative values
https://bugs.webkit.org/show_bug.cgi?id=30219

Changing an SVGPathSeg does not update a following Smooth Cubic Curveto
https://bugs.webkit.org/show_bug.cgi?id=19741

SVGPathElement should only build SVGPathSeg* list on demand
https://bugs.webkit.org/show_bug.cgi?id=10827

Tests: svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg

svg/dom/SVGPathSegList-appendItem.xhtml
svg/dom/SVGPathSegList-clear-and-initialize.xhtml
svg/dom/SVGPathSegList-cloning.html
svg/dom/SVGPathSegList-insertItemBefore.xhtml
svg/dom/SVGPathSegList-removeItem.xhtml
svg/dom/SVGPathSegList-replaceItem.xhtml
svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml
svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml
svg/dom/SVGPathSegList-segment-modification.svg

Convert SVGPathSeg*/SVGPathSegList to the new SVG(Animated)PropertyTearOff concept.
Unlike all other SVG* types that use the SVGPropertyTearOff concept, SVGPathSegs are already refcounted,
and don't need to be wrapped in SVGPropertyTearOff objects. The consequence is that SVGPathSegs need to track
themselves to which list and path element they belong. Introduce new SVGAnimatedPathSegListPropertyTearOff
and SVGPathSegListPropertyTearOff classes, that encapsulate the special needed for SVGPathSegList.

Each SVGPathSeg now needs to store a RefPtr<SVGPathElement> - this makes it impossible to use SVGPathSegList
to represent the 'd' attribute internally in SVGPathElement. SVGPathSegList is now only used in the SVG DOM bindings
if someone explicitely requests 'pathElement.pathSegList' (eg. via JS). Switch to use SVGPathByteStream to store
the 'd' attribute data in SVGPathElement, which is much more compact, and less memory intensive.
Dirk already prepared SVGPathParserFactory some months ago, which allows easy conversion between
String/Path/SVGPathSegList/SVGPathByteStream in all directions, including normalizing the lists, when requested.

As consequence SVGPathSegList is now only built on demand, when explicitely requested. Using the SVGAnimatedProperty
concept gives us 'd' attribute <-> SVGPathSegList synchronization for free, fixing several bugs, listed above.

  • Android.mk: Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp from build.
  • CMakeLists.txt: Ditto.
  • DerivedSources.make: Remove SVGAnimatedPathData IDL generation.
  • GNUmakefile.am: Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp from build.
  • WebCore.gyp/WebCore.gyp: Remove SVGAnimatedPathData IDL generation.
  • WebCore.gypi: Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp from build.
  • WebCore.order: Remove no-longer existant SVGAnimatedPathData symbols.
  • WebCore.pro: Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp / JSSVGPathSegCustom.* from build.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Remove JSSVGPathSegCustom.cpp from build.
  • bindings/js/JSDOMBinding.cpp: Adapt to toJS() changes, remove context parameter. (WebCore::setDOMException):
  • bindings/js/JSDOMBinding.h: Remove obsolete CREATE_SVG_OBJECT_WRAPPER macro, the context parameter is not existant anymore.
  • bindings/js/JSSVGPathSegCustom.cpp: Replace CREATE_SVG_OBJECT_WRAPPER by CREATE_DOM_OBJECT_WRAPPER. Remove context parameter/handling. (WebCore::toJS):
  • bindings/js/JSSVGPathSegListCustom.cpp: Removed.
  • bindings/scripts/CodeGenerator.pm: Map 'SVGPathSegList' IDL type to SVG 'SVGPathSegListPropertyTearOff' native type.
  • bindings/scripts/CodeGeneratorJS.pm: Remove IsSVGTypeNeedingContextParameter() methods and usages. Handle SVGPathSegListPropertyTearOff.
  • bindings/scripts/CodeGeneratorObjC.pm: Handle SVGPathSegListPropertyTearOff.
  • bindings/scripts/CodeGeneratorV8.pm: Remove IsSVGTypeNeedingContextParameter() methods and usages.
  • rendering/SVGRenderTreeAsText.cpp: Build path string from byte stream, not path segment list. (WebCore::operator<<):
  • svg/SVGAllInOne.cpp: Remove obsolete cpp files.
  • svg/SVGAnimatedPathData.cpp: Removed.
  • svg/SVGAnimatedPathData.h: Removed.
  • svg/SVGAnimatedPathData.idl: Removed.
  • svg/SVGPathElement.cpp: Build SVGPathList on demand. Use SVGPathByteStream to parse/store the 'd' attribute content. (WebCore::SVGPathElement::SVGPathElement): (WebCore::SVGPathElement::getPathSegAtLength): Use SVGPathByteStream, not SVGPathSegList to determine the getPathSegAtLength() information. (WebCore::SVGPathElement::createSVGPathSegClosePath): Pass SVGPathElement to SVGPathSeg and a SVGPathSegRole parameter and store it to track the list origin. (WebCore::SVGPathElement::createSVGPathSegMovetoAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegMovetoRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegLinetoAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegLinetoRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegArcAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegArcRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel): Ditto. (WebCore::SVGPathElement::parseMappedAttribute): Build SVGPathByteStream from 'd' attribute, not a SVGPathSegList. (WebCore::SVGPathElement::svgAttributeChanged): If a SVGPathSegList object has been built, synchronize it with the 'd' attribute. (WebCore::SVGPathElement::synchronizeProperty): Synchronize 'd' attribute with the SVGPathSegList, if needed. (WebCore::SVGPathElement::synchronizeD): Added. (WebCore::SVGPathElement::pathSegList): Use same trick as in SVGPolyElement to expose the 'pathSegList' / 'animatedPathSegList' object to the SVG DOM bindings. (WebCore::SVGPathElement::normalizedPathSegList): Ditto. (WebCore::SVGPathElement::animatedPathSegList): Ditto. (WebCore::SVGPathElement::animatedNormalizedPathSegList): Ditto. (WebCore::SVGPathElement::toPathData): Build 'Path' object from SVGPathByteStream, not from SVGPathSegList. (WebCore::SVGPathElement::pathSegListChanged): Used to synchronize the SVGPathSegLists and the d attribute, as well as any changes from any SVGPathSeg associated with this SVGPathElement.
  • svg/SVGPathElement.h: Add new accessors... (WebCore::SVGPathElement::pathByteStream): ... needed by SVGRenderTreeAsText. (WebCore::SVGPathElement::animatablePathSegList): ... needed by SVGPathSegListPropertyTearOff.
  • svg/SVGPathElement.idl: Merge SVGAnimatedPathData interface into SVGPathElement.
  • svg/SVGPathParserFactory.cpp: Cleanup SVGPathParserFactory, remove obsolete methods, now that SVGPathElement switched to using SVGPathByteStream internally. (WebCore::globalSVGPathSegListBuilder): (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromSVGPathSegList): (WebCore::SVGPathParserFactory::buildPathFromByteStream): (WebCore::SVGPathParserFactory::buildSVGPathSegListFromByteStream): (WebCore::SVGPathParserFactory::buildStringFromSVGPathSegList): (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString): (WebCore::SVGPathParserFactory::buildAnimatedSVGPathByteStream): (WebCore::SVGPathParserFactory::getSVGPathSegAtLengthFromSVGPathByteStream):
  • svg/SVGPathParserFactory.h:
  • svg/SVGPathSeg.cpp: Removed.
  • svg/SVGPathSeg.h: Add new SVGPathSegRole enum, identifying to which list a path segment belongs. (WebCore::SVGPathSeg::SVGPathSeg):
  • svg/SVGPathSeg.idl: Reindented.
  • svg/SVGPathSegArc.cpp: Removed.
  • svg/SVGPathSegArc.h: All setters now call the commitChange() method.
  • svg/SVGPathSegArcAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegArcRel.idl: Ditto.
  • svg/SVGPathSegClosePath.cpp: Removed.
  • svg/SVGPathSegClosePath.h:
  • svg/SVGPathSegCurvetoCubic.cpp: Removed.
  • svg/SVGPathSegCurvetoCubic.h: All setters now call the commitChange() method.
  • svg/SVGPathSegCurvetoCubicAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegCurvetoCubicRel.idl: Ditto.
  • svg/SVGPathSegCurvetoCubicSmooth.cpp: Removed.
  • svg/SVGPathSegCurvetoCubicSmooth.h: All setters now call the commitChange() method.
  • svg/SVGPathSegCurvetoCubicSmoothAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegCurvetoCubicSmoothRel.idl: Ditto.
  • svg/SVGPathSegCurvetoQuadratic.cpp: Removed.
  • svg/SVGPathSegCurvetoQuadratic.h: All setters now call the commitChange() method.
  • svg/SVGPathSegCurvetoQuadraticAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegCurvetoQuadraticRel.idl: Ditto.
  • svg/SVGPathSegCurvetoQuadraticSmooth.cpp: Removed.
  • svg/SVGPathSegCurvetoQuadraticSmooth.h: All setters now call the commitChange() method.
  • svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegCurvetoQuadraticSmoothRel.idl: Ditto.
  • svg/SVGPathSegLineto.cpp: Removed.
  • svg/SVGPathSegLineto.h: All setters now call the commitChange() method.
  • svg/SVGPathSegLinetoAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegLinetoHorizontal.cpp: Removed.
  • svg/SVGPathSegLinetoHorizontal.h: All setters now call the commitChange() method.
  • svg/SVGPathSegLinetoHorizontalAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegLinetoHorizontalRel.idl: Ditto.
  • svg/SVGPathSegLinetoRel.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegLinetoVertical.cpp: Removed.
  • svg/SVGPathSegLinetoVertical.h: All setters now call the commitChange() method.
  • svg/SVGPathSegLinetoVerticalAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegLinetoVerticalRel.idl: Ditto.
  • svg/SVGPathSegList.cpp: Switch from SVGList<RefPtr<SVGPathSeg> > to a plain Vector<RefPtr<SVGPathSeg> >. (WebCore::SVGPathSegList::valueAsString): Utilize SVGPathParserFactory to build a String from a SVGPathSegList. (WebCore::SVGPathSegList::commitChange): Call SVGPathElement::pathSegListChanged().
  • svg/SVGPathSegList.h: (WebCore::SVGPathSegList::SVGPathSegList):
  • svg/SVGPathSegList.idl: Remove [JSCCustom] flags, no longer needed.
  • svg/SVGPathSegListBuilder.cpp: Adapt to SVGPathSegList API changes. (WebCore::SVGPathSegListBuilder::SVGPathSegListBuilder): (WebCore::SVGPathSegListBuilder::moveTo): (WebCore::SVGPathSegListBuilder::lineTo): (WebCore::SVGPathSegListBuilder::lineToHorizontal): (WebCore::SVGPathSegListBuilder::lineToVertical): (WebCore::SVGPathSegListBuilder::curveToCubic): (WebCore::SVGPathSegListBuilder::curveToCubicSmooth): (WebCore::SVGPathSegListBuilder::curveToQuadratic): (WebCore::SVGPathSegListBuilder::curveToQuadraticSmooth): (WebCore::SVGPathSegListBuilder::arcTo): (WebCore::SVGPathSegListBuilder::closePath):
  • svg/SVGPathSegListBuilder.h: Ditto. (WebCore::SVGPathSegListBuilder::setCurrentSVGPathElement): (WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegList): (WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegRole): (WebCore::SVGPathSegListBuilder::cleanup):
  • svg/SVGPathSegListSource.cpp: Ditto. (WebCore::SVGPathSegListSource::SVGPathSegListSource): (WebCore::SVGPathSegListSource::parseSVGSegmentType): (WebCore::SVGPathSegListSource::nextCommand): (WebCore::SVGPathSegListSource::parseMoveToSegment): (WebCore::SVGPathSegListSource::parseLineToSegment): (WebCore::SVGPathSegListSource::parseCurveToQuadraticSmoothSegment):
  • svg/SVGPathSegListSource.h: Ditto. (WebCore::SVGPathSegListSource::create):
  • svg/SVGPathSegMoveto.cpp: Removed.
  • svg/SVGPathSegMoveto.h: All setters now call the commitChange() method.
  • svg/SVGPathSegMovetoAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegMovetoRel.idl: Ditto.
  • svg/SVGPathSegWithContext.h: Added. This is the new base class for all SVGPathSeg derived types, that's associated with a SVGPathElement and a 'role' (normalized/unaltered segment list). (WebCore::SVGPathSegWithContext::SVGPathSegWithContext): (WebCore::SVGPathSegWithContext::animatedProperty): (WebCore::SVGPathSegWithContext::setContextAndRole): (WebCore::SVGPathSegWithContext::commitChange): (WebCore::SVGPathSegSingleCoordinate::x): (WebCore::SVGPathSegSingleCoordinate::setX): (WebCore::SVGPathSegSingleCoordinate::y): (WebCore::SVGPathSegSingleCoordinate::setY): (WebCore::SVGPathSegSingleCoordinate::SVGPathSegSingleCoordinate):
  • svg/properties/SVGAnimatedPathSegListPropertyTearOff.h: Added. (WebCore::SVGAnimatedPathSegListPropertyTearOff::baseVal): (WebCore::SVGAnimatedPathSegListPropertyTearOff::animVal): (WebCore::SVGAnimatedPathSegListPropertyTearOff::removeItemFromList): (WebCore::SVGAnimatedPathSegListPropertyTearOff::create): (WebCore::SVGAnimatedPathSegListPropertyTearOff::SVGAnimatedPathSegListPropertyTearOff):
  • svg/properties/SVGPathSegListPropertyTearOff.cpp: Added. (WebCore::SVGPathSegListPropertyTearOff::clear): Added in the cpp file, not in the header, as it needs access to SVGPathSegWithContext, which we can't include from the header. (WebCore::SVGPathSegListPropertyTearOff::getItem): Ditto. (WebCore::SVGPathSegListPropertyTearOff::removeItem): Ditto. (WebCore::SVGPathSegListPropertyTearOff::contextElement): Needs access to SVGPathElement, that's why it lives in the cpp file. (WebCore::SVGPathSegListPropertyTearOff::processIncomingListItemValue): Needs access to SVGPathSegWithContext.
  • svg/properties/SVGPathSegListPropertyTearOff.h: Added. (WebCore::SVGPathSegListPropertyTearOff::create): (WebCore::SVGPathSegListPropertyTearOff::removeItemFromList): (WebCore::SVGPathSegListPropertyTearOff::numberOfItems): (WebCore::SVGPathSegListPropertyTearOff::initialize): (WebCore::SVGPathSegListPropertyTearOff::insertItemBefore): (WebCore::SVGPathSegListPropertyTearOff::replaceItem): (WebCore::SVGPathSegListPropertyTearOff::appendItem): (WebCore::SVGPathSegListPropertyTearOff::SVGPathSegListPropertyTearOff): (WebCore::SVGPathSegListPropertyTearOff::commitChange): (WebCore::SVGPathSegListPropertyTearOff::processIncomingListItemWrapper):

2010-11-18 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=49580

Add several new tests covering SVGPathSegList usage.

  • platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
  • platform/mac/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
  • platform/mac/svg/dom/SVGPathSegList-appendItem-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-cloning-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-cloning-expected.txt: Added.
  • platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-removeItem-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.txt: Added.
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg: Added.
  • svg/dom/SVGPathSegList-appendItem-expected.txt: Added.
  • svg/dom/SVGPathSegList-appendItem.xhtml: Added.
  • svg/dom/SVGPathSegList-clear-and-initialize-expected.txt: Added.
  • svg/dom/SVGPathSegList-clear-and-initialize.xhtml: Added.
  • svg/dom/SVGPathSegList-cloning.html: Added.
  • svg/dom/SVGPathSegList-insertItemBefore-expected.txt: Added.
  • svg/dom/SVGPathSegList-insertItemBefore.xhtml: Added.
  • svg/dom/SVGPathSegList-removeItem-expected.txt: Added.
  • svg/dom/SVGPathSegList-removeItem.xhtml: Added.
  • svg/dom/SVGPathSegList-replaceItem-expected.txt: Added.
  • svg/dom/SVGPathSegList-replaceItem.xhtml: Added.
  • svg/dom/SVGPathSegList-segment-modification.svg: Added.
  • svg/dom/SVGPathSegList-xml-dom-synchronization-expected.txt: Added.
  • svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml: Added.
  • svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml: Added.
  • svg/dom/fuzz-path-parser-expected.txt:
  • svg/dom/path-parser-expected.txt:
  • svg/dom/script-tests/path-parser.js: ():
  • svg/dom/svglist-exception-on-out-bounds-error-expected.txt:
  • svg/dom/svglist-exception-on-out-bounds-error.html:
  • svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
5:29 AM Changeset in webkit [72287] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, rebaselining fast/backgrounds/size/contain-and-cover.html

  • platform/chromium/test_expectations.txt:
5:21 AM Changeset in webkit [72286] by senorblanco@chromium.org
  • 5 edits in trunk/LayoutTests

2010-11-18 Stephen White <senorblanco@chromium.org>

Unreviewed; new test baselines.

New win & linux baselines for test affected by http://trac.webkit.org/changeset/72282.

  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
4:57 AM Changeset in webkit [72285] by pfeldman@chromium.org
  • 2 edits
    1 add in trunk/WebKit/chromium

2010-11-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chrome DevTools: minify front-end JavaScript.
https://bugs.webkit.org/show_bug.cgi?id=49657

  • scripts/concatenate_js_files.py:
  • scripts/jsmin.py: Added.
4:42 AM Changeset in webkit [72284] by mario@webkit.org
  • 4 edits in trunk

2010-11-18 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] atk_text_get_selection returns the wrong offsets after a link
https://bugs.webkit.org/show_bug.cgi?id=49514

Consider possible embedded objects to calculate startOffset.

So far we were using offsetInContainerNode() to calculate the
value of startOffset when checking the offsets for the current
selection, which was wrong because that wouldn't work ok if any
embedded object was present in the paragraph before the
selection. Thus, we need to consider this fact when calculating
the startOffset from the point of view of the object this function
is called on, in order to return the right and actual values.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getSelectionOffsetsForObject): Check range length from the first position in the object the function is called on until the first position of current selection, and use it as startOffset.

2010-11-18 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] atk_text_get_selection returns the wrong offsets after a link
https://bugs.webkit.org/show_bug.cgi?id=49514

Updated test case to also chech this specific subcase.

We need to explicitly check the case of having a selection in a
paragraph after an embedded object (i.e. a link) to make sure the
right calculations are being done when the paragraph is composed
of more than just one text object, and the current selection is
made only in one of them.

  • tests/testatk.c: (testWebkitAtkTextSelections): Make sure that a selection after a link in a paragraph is working ok when asking for the text selection from the point of view of the paragraph.
4:34 AM Changeset in webkit [72283] by andreas.kling@nokia.com
  • 4 edits in trunk

2010-11-17 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Reuse the size of the actualVisibleContentRect when loading a new page
or navigating session history.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):

2010-11-17 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Reuse the size of the actualVisibleContentRect when loading a new page
or navigating session history.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
4:20 AM Changeset in webkit [72282] by senorblanco@chromium.org
  • 5 edits in trunk

2010-11-12 Stephen White <senorblanco@chromium.org>

Reviewed by Simon Fraser.

Fix for multiple urls in a background-image causing repeated repaints.
https://bugs.webkit.org/show_bug.cgi?id=42390

Change the key of RenderBoxModelObject's LastPaintSizeMap to include
the layer of the element being drawn, so that the same URL used
repeated in the same background-image, or another element's
background-image, can be uniquely identified. The layer is a void
pointer, since it is only used as part of the key and using a
void pointer will discourage dereferencing it. This pointer is NULL
when called from RenderImage (<img> elements).

Covered by fast/backgrounds/size/contain-and-cover.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::ImageQualityController::keyDestroyed): The old objectDestroyed() is renamed to keyDestroyed(). (WebCore::ImageQualityController::objectDestroyed): The new objectDestroyed() iterates over all outstanding resizes to remove any resizes pertaining to this object. (WebCore::ImageQualityController::highQualityRepaintTimerFired): Retrieve the RenderBoxModelObject from the pair's "first" member. (WebCore::ImageQualityController::shouldPaintAtLowQuality): Create a key from the {object, layer} pair, and use it to access the repaint size map. (WebCore::RenderBoxModelObject::shouldPaintAtLowQuality): Plumb the layer through to the image quality controller. (WebCore::RenderBoxModelObject::paintFillLayerExtended): Pass the bgLayer when checking
  • rendering/RenderBoxModelObject.h: Add the void* layer parameter to shouldPaintAtLowQuality.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintIntoRect): Pass 0 (null) for the layer parameter in this case.
3:47 AM Changeset in webkit [72281] by crogers@google.com
  • 6 edits
    2 adds in trunk

2010-11-18 Chris Rogers <crogers@google.com>

Reviewed by Dimitri Glazkov.

Add loadPlatformAudioResource() and decodeAudioFileData() to ChromiumBridge
https://bugs.webkit.org/show_bug.cgi?id=49557

No new tests since audio API is not yet implemented.

  • platform/chromium/ChromiumBridge.h:

2010-11-18 Chris Rogers <crogers@google.com>

Reviewed by Dimitri Glazkov.

Add loadPlatformAudioResource() and decodeAudioFileData() to ChromiumBridge
https://bugs.webkit.org/show_bug.cgi?id=49557

  • WebKit.gyp:
  • public/WebAudioBus.h: Added. (WebKit::WebAudioBus::WebAudioBus):
  • public/WebKitClient.h: (WebKit::WebKitClient::decodeAudioFileData):
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::loadPlatformAudioResource): (WebCore::ChromiumBridge::decodeAudioFileData):
  • src/WebAudioBus.cpp: Added. (WebKit::WebAudioBus::~WebAudioBus): (WebKit::WebAudioBus::initialize): (WebKit::WebAudioBus::numberOfChannels): (WebKit::WebAudioBus::length): (WebKit::WebAudioBus::sampleRate): (WebKit::WebAudioBus::channelData): (WebKit::WebAudioBus::release):
3:26 AM Changeset in webkit [72280] by antonm@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

Not reviewed, rebaselining fast/dom/setPrimitiveValue.html

https://bugs.webkit.org/show_bug.cgi?id=49653

  • platform/chromium-win/fast/dom/setPrimitiveValue-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
3:13 AM Changeset in webkit [72279] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-11-18 MORITA Hajime <morrita@google.com>

Unreviewed expectation update.

  • platform/chromium/test_expectations.txt:
12:28 AM Changeset in webkit [72278] by hyatt@apple.com
  • 3 edits in trunk/LayoutTests/platform/mac/fast/blockflow

Update layout test results for bots.

12:17 AM Changeset in webkit [72277] by levin@chromium.org
  • 4 edits
    2 adds in trunk/LayoutTests

Updates for recent rebaselines and changes.

  • platform/chromium-mac/fast/js/regexp-overflow-expected.txt:
  • platform/chromium-mac/fast/text/atsui-negative-spacing-features-expected.checksum: Added.
  • platform/chromium-mac/fast/text/atsui-negative-spacing-features-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: The only

non-chromium only change. This started failing when r72235 was landed and only has
some very small pixel placement changes (which is typicaly of other layout test
changes that happened with that change).

Nov 17, 2010:

10:36 PM Changeset in webkit [72276] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2010-11-17 Martin Robinson <mrobinson@igalia.com>

Fix two incorrect GTK+ baselines.

  • platform/gtk/fast/css/line-height-determined-by-primary-font-expected.txt:
  • platform/gtk/fast/css/negative-leading-expected.txt:
10:32 PM Changeset in webkit [72275] by Martin Robinson
  • 3 edits
    1 copy in trunk

2010-11-17 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Changing any GNUmakefile.am in the source tree forces a rebuld of the DOM bindings and WebKit APi
https://bugs.webkit.org/show_bug.cgi?id=49400

Move WebKit API build rules out of GNUmakefile.am. These are now in
WebKit/gtk/GNUmakefile.am.

  • GNUmakefile.am: Remove WebKit API build rules.

2010-11-17 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Changing any GNUmakefile.am in the source tree forces a rebuld of the DOM bindings and WebKit APi
https://bugs.webkit.org/show_bug.cgi?id=49400

Add GNUmakefile.am and include all WebKit API build rules. Make webkitenum.*
depend on this new file, instead of the generated GNUmakefile.am.

  • GNUmakefile.am: Copied from GNUmakefile.am.
9:22 PM Changeset in webkit [72274] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add some test_expectations for failing tests
that need to be investigated and dealt with.

  • platform/chromium/test_expectations.txt:
8:54 PM Changeset in webkit [72273] by levin@chromium.org
  • 7 edits
    2 deletes in trunk

Unreviewed, rolling out r72228.
http://trac.webkit.org/changeset/72228
https://bugs.webkit.org/show_bug.cgi?id=49712

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-11-17
Caused many >10 regressions on Win and Linux gpu layout test
runs. (Requested by dave_levin on #webkit).

WebCore:

  • html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::onAccess):
(WebCore::WebGLFramebuffer::initializeRenderbuffers):

  • html/canvas/WebGLFramebuffer.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::clear):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::texImage2DBase):

WebKit/chromium:

  • src/WebGraphicsContext3DDefaultImpl.cpp:

(WebKit::bytesPerComponent):
(WebKit::componentsPerPixel):
(WebKit::imageSizeInBytes):
(WebKit::WebGraphicsContext3DDefaultImpl::texImage2D):

LayoutTests:

  • fast/canvas/webgl/uninitialized-test-expected.txt: Removed.
  • fast/canvas/webgl/uninitialized-test.html: Removed.
8:33 PM Changeset in webkit [72272] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add some test_expectations for failing tests
that need to be investigated and dealt with.

  • platform/chromium/test_expectations.txt:
8:01 PM Changeset in webkit [72271] by levin@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, rolling out r72243.
http://trac.webkit.org/changeset/72243
https://bugs.webkit.org/show_bug.cgi?id=49710

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-11-17
Seemed to cause a large set of Chromium layout test to start
failing. (Requested by dave_levin on #webkit).

  • bindings/v8/V8NPUtils.cpp:

(WebCore::convertV8ObjectToNPVariant):

6:33 PM Changeset in webkit [72270] by Adam Roben
  • 2 edits in trunk/WebCore

Fix Acid3 in Safari for Windows

Reviewed by Dave Hyatt.

  • platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::initGDIFont): Initialize all our metrics to 0
if we have a font size of 0.

6:30 PM Changeset in webkit [72269] by Adam Roben
  • 3 edits in trunk/WebKitTools

Don't trigger Windows builds when chromium-win test results change

Reviewed by Mark Rowe.

  • Scripts/webkitpy/common/config/build.py:

(_should_file_trigger_build): Changed the regular expression used to
search for directory names to only consider full directory names,
rather than matching directory names where the string we care about is
a suffix of the name.

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest): Added a test.

6:19 PM Changeset in webkit [72268] by mihaip@chromium.org
  • 193 edits
    192 copies
    6 adds in trunk/LayoutTests

2010-11-17 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/tokenizer, fast/transforms, fast/wml, fast/xsl, fonts, scrollbars, svg, transforms, and transitions for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

6:02 PM Changeset in webkit [72267] by hayato@chromium.org
  • 3 edits in trunk/WebKitTools

2010-11-17 Hayato Ito <hayato@chromium.org>

Reviewed by Shinichiro Hamaji.

Remove a uri member from TestInput class.

https://bugs.webkit.org/show_bug.cgi?id=49691

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
5:41 PM Changeset in webkit [72266] by levin@chromium.org
  • 29 edits
    130 adds in trunk/LayoutTests

Update chromium results after r72125 and r72173.

  • platform/chromium-linux/fast/css/negative-leading-expected.checksum: Added.
  • platform/chromium-linux/fast/css/negative-leading-expected.png: Added.
  • platform/chromium-linux/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
  • platform/chromium-linux/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
  • platform/chromium-mac/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Added.
  • platform/chromium-mac/css2.1/t0805-c5519-brdr-r-00-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0805-c5519-brdr-r-00-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png: Added.
  • platform/chromium-mac/css2.1/t0805-c5521-brdr-l-00-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0805-c5521-brdr-l-00-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t0805-c5521-brdr-l-01-e-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0805-c5521-brdr-l-01-e-expected.png: Added.
  • platform/chromium-mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t0905-c414-flt-02-c-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0905-c414-flt-02-c-expected.png: Added.
  • platform/chromium-mac/css2.1/t0905-c414-flt-03-c-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0905-c414-flt-03-c-expected.png: Added.
  • platform/chromium-mac/css2.1/t0905-c414-flt-04-c-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0905-c414-flt-04-c-expected.png: Added.
  • platform/chromium-mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.png: Added.
  • platform/chromium-mac/css2.1/t0905-c5525-fltblck-01-d-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0905-c5525-fltblck-01-d-expected.png: Added.
  • platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
  • platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Added.
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png: Added.
  • platform/chromium-mac/css2.1/t090501-c414-flt-01-b-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t090501-c414-flt-01-b-expected.png: Added.
  • platform/chromium-mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t090501-c414-flt-03-b-g-expected.png: Added.
  • platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png: Added.
  • platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Added.
  • platform/chromium-mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png: Added.
  • platform/chromium-mac/css2.1/t1202-counter-03-b-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1202-counter-03-b-expected.png: Added.
  • platform/chromium-mac/css2.1/t1202-counter-04-b-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1202-counter-04-b-expected.png: Added.
  • platform/chromium-mac/css2.1/t1202-counter-09-b-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1202-counter-09-b-expected.png: Added.
  • platform/chromium-mac/css2.1/t1202-counters-03-b-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1202-counters-03-b-expected.png: Added.
  • platform/chromium-mac/css2.1/t1202-counters-09-b-expected.checksum:
  • platform/chromium-mac/css2.1/t1202-counters-09-b-expected.png:
  • platform/chromium-mac/editing/deleting/5144139-2-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/5144139-2-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-expected.png: Added.
  • platform/chromium-mac/editing/selection/extend-selection-bidi-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/extend-selection-bidi-expected.png: Added.
  • platform/chromium-mac/fast/css/beforeSelectorOnCodeElement-expected.checksum: Added.
  • platform/chromium-mac/fast/css/beforeSelectorOnCodeElement-expected.png: Added.
  • platform/chromium-mac/fast/css/font-face-opentype-expected.checksum: Added.
  • platform/chromium-mac/fast/css/font-face-opentype-expected.png: Added.
  • platform/chromium-mac/fast/css/negative-leading-expected.checksum: Added.
  • platform/chromium-mac/fast/css/negative-leading-expected.png: Added.
  • platform/chromium-mac/fast/css/rtl-ordering-expected.checksum: Added.
  • platform/chromium-mac/fast/css/rtl-ordering-expected.png: Added.
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-bidi-expected.checksum: Added.
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-bidi-expected.png: Added.
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.checksum:
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.png:
  • platform/chromium-mac/fast/css/text-security-expected.checksum: Added.
  • platform/chromium-mac/fast/css/text-security-expected.png: Added.
  • platform/chromium-mac/fast/encoding/denormalised-voiced-japanese-chars-expected.checksum: Added.
  • platform/chromium-mac/fast/encoding/denormalised-voiced-japanese-chars-expected.png: Added.
  • platform/chromium-mac/fast/encoding/invalid-UTF-8-expected.checksum: Added.
  • platform/chromium-mac/fast/encoding/invalid-UTF-8-expected.png:
  • platform/chromium-mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png: Added.
  • platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
  • platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.checksum:
  • platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
  • platform/chromium-mac/fast/text/backslash-to-yen-sign-expected.checksum: Added.
  • platform/chromium-mac/fast/text/backslash-to-yen-sign-expected.png: Added.
  • platform/chromium-mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum: Added.
  • platform/chromium-mac/fast/text/bidi-embedding-pop-and-push-same-expected.png: Added.
  • platform/chromium-mac/fast/text/cg-fallback-bolding-expected.checksum: Added.
  • platform/chromium-mac/fast/text/cg-fallback-bolding-expected.png: Added.
  • platform/chromium-mac/fast/text/complex-text-opacity-expected.checksum: Added.
  • platform/chromium-mac/fast/text/complex-text-opacity-expected.png: Added.
  • platform/chromium-mac/fast/text/complex-text-opacity-expected.txt: Added.
  • platform/chromium-mac/fast/text/in-rendered-text-rtl-expected.checksum: Added.
  • platform/chromium-mac/fast/text/in-rendered-text-rtl-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-AN-after-L-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-AN-after-L-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-AN-after-empty-run-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-AN-after-empty-run-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/bidi-CS-after-AN-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-CS-after-AN-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-CS-after-AN-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/bidi-L2-run-reordering-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-L2-run-reordering-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-european-terminators-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-european-terminators-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-innertext-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-innertext-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-linebreak-001-expected.checksum:
  • platform/chromium-mac/fast/text/international/bidi-linebreak-001-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-linebreak-002-expected.checksum:
  • platform/chromium-mac/fast/text/international/bidi-linebreak-002-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-linebreak-003-expected.checksum:
  • platform/chromium-mac/fast/text/international/bidi-linebreak-003-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-listbox-atsui-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-listbox-atsui-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-listbox-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-listbox-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
  • platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/chromium-mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.checksum:
  • platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/chromium-mac/fast/text/international/bidi-override-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-override-expected.png: Added.
  • platform/chromium-mac/fast/text/international/danda-space-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/danda-space-expected.png: Added.
  • platform/chromium-mac/fast/text/international/hindi-spacing-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/hindi-spacing-expected.png: Added.
  • platform/chromium-mac/fast/text/international/hindi-whitespace-expected.checksum:
  • platform/chromium-mac/fast/text/international/hindi-whitespace-expected.png:
  • platform/chromium-mac/fast/text/international/plane2-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/plane2-expected.png: Added.
  • platform/chromium-mac/fast/text/international/rtl-caret-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/rtl-caret-expected.png: Added.
  • platform/chromium-mac/fast/text/international/thai-baht-space-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/thai-baht-space-expected.png: Added.
  • platform/chromium-mac/fast/text/international/thai-baht-space-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/wrap-CJK-001-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/wrap-CJK-001-expected.png: Added.
  • platform/chromium-win/fast/compact/001-expected.txt:
  • platform/chromium-win/fast/css/negative-leading-expected.checksum: Added.
  • platform/chromium-win/fast/css/negative-leading-expected.png: Added.
  • platform/chromium-win/fast/css/negative-leading-expected.txt: Added.
  • platform/chromium-win/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
  • platform/chromium-win/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
  • platform/chromium-win/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
5:30 PM Changeset in webkit [72265] by Adam Roben
  • 2 edits
    1 add in trunk/WebKitTools

Move FindSafari's settings into a vsprops file

Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file

Reviewed by Steve Falkenburg.

  • FindSafari/FindSafari.vcproj:
  • FindSafari/FindSafariCommon.vsprops: Added.
5:16 PM Changeset in webkit [72264] by Adam Roben
  • 2 edits in trunk/WebKitTools

Use a minimum font size of 0 in DRT on Windows

This is the Windows equivalent of r72164.

Rubber-stamped by Dave Hyatt.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

5:10 PM Changeset in webkit [72263] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-11-17 Dirk Pranke <dpranke@chromium.org>

Reviewed by Andreas Kling.

webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
https://bugs.webkit.org/show_bug.cgi?id=49639

  • Scripts/webkitpy/common/checkout/scm.py:
4:42 PM Changeset in webkit [72262] by mihaip@chromium.org
  • 5 edits
    1 add in trunk/WebKitTools

2010-11-17 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

Rebaseline server: add loupe for image diffs
https://bugs.webkit.org/show_bug.cgi?id=49692

Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
enlarged area of the expected, actual and diff images side by side.

  • Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
4:24 PM Changeset in webkit [72261] by sfalken@apple.com
  • 2 edits
    1 add in trunk/WebKitTools

2010-11-17 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

WebKitLauncherWin should use vsprops for shared build settings
https://bugs.webkit.org/show_bug.cgi?id=49696

  • WebKitLauncherWin/WebKitLauncherWin.vcproj:
  • WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.
4:21 PM Changeset in webkit [72260] by sfalken@apple.com
  • 1 edit in trunk/WebKitTools/WinLauncher/stdafx.h

Unreviewed build fix. Touch precompiled header to force rebuild.

4:20 PM Changeset in webkit [72259] by Dimitri Glazkov
  • 48 edits in trunk

Converge means of querying a parent node into one way, which is Node::parentNode.
https://bugs.webkit.org/show_bug.cgi?id=49686

Reviewed by Darin Adler.

WebCore:

No change in behavior, so no new tests.

  • accessibility/AccessibilityObject.cpp:

(WebCore::renderListItemContainerForNode): Changed to use parentNode.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::mouseButtonListener): Ditto.
(WebCore::siblingWithAriaRole): Ditto.
(WebCore::AccessibilityRenderObject::getDocumentLinks): Ditto.
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest): Ditto.

  • accessibility/mac/AccessibilityObjectWrapper.mm: Ditto.

(blockquoteLevel): Ditto.

  • bindings/v8/V8GCController.cpp:

(WebCore::ObjectGrouperVisitor::visitDOMWrapper): Ditto.

  • dom/ContainerNode.cpp: Ditto.

(WebCore::ContainerNode::insertBefore): Ditto.
(WebCore::ContainerNode::insertBeforeCommon): Ditto.
(WebCore::ContainerNode::replaceChild): Ditto.
(WebCore::ContainerNode::removeChild): Ditto.
(WebCore::ContainerNode::appendChild): Ditto.
(WebCore::ContainerNode::parserAddChild): Ditto.

  • dom/DocumentType.cpp:

(WebCore::DocumentType::insertedIntoDocument): Ditto.

  • dom/Element.cpp:

(WebCore::Element::computeInheritedLanguage): Ditto.

  • dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::receivedTarget): Ditto.

  • dom/Position.cpp:

(WebCore::Position::isCandidate): Changed to use parentNode.

  • dom/PositionIterator.cpp:

(WebCore::PositionIterator::isCandidate): Ditto.

  • editing/AppendNodeCommand.cpp:

(WebCore::AppendNodeCommand::AppendNodeCommand): Ditto.

  • editing/ApplyStyleCommand.cpp:

(WebCore::dummySpanAncestorForNode): Ditto.
(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Ditto.
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Ditto.
(WebCore::highestEmbeddingAncestor): Ditto.
(WebCore::ApplyStyleCommand::splitTextElementAtEnd): Ditto.
(WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical): Ditto.
(WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical): Ditto.

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::splitTreeToNode): Ditto.

  • editing/DeleteSelectionCommand.cpp:

(WebCore::updatePositionForNodeRemoval): Ditto.

  • editing/Editor.cpp:

(WebCore::Editor::textDirectionForSelection): Ditto.

  • editing/MergeIdenticalElementsCommand.cpp:

(WebCore::MergeIdenticalElementsCommand::doUnapply): Ditto.

  • editing/htmlediting.cpp:

(WebCore::isEmptyTableCell): Ditto.

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::serializeNodes): Ditto.

  • editing/visible_units.cpp:

(WebCore::previousLinePosition): Ditto.
(WebCore::nextLinePosition): Ditto.

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::imageElement): Ditto.

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::setOuterHTML): Ditto.
(WebCore::HTMLElement::insertAdjacent): Ditto.
(WebCore::HTMLElement::supportsFocus): Ditto.

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::insertedIntoDocument): Ditto.
(WebCore::HTMLEmbedElement::attributeChanged): Ditto.

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::insertRow): Ditto.

  • html/HTMLTableRowsCollection.cpp: Ditto.

(WebCore::isInHead): Ditto.
(WebCore::isInBody): Ditto.
(WebCore::isInFoot): Ditto.
(WebCore::HTMLTableRowsCollection::rowAfter): Ditto.

  • html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::addRange): Ditto.

  • html/MediaDocument.cpp:

(WebCore::MediaDocument::replaceMediaElementTimerFired): Ditto.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::attach): Ditto.
(WebCore::HTMLConstructionSite::findFosterSite): Ditto.

  • html/parser/HTMLTreeBuilder.cpp:
  • page/FocusController.cpp:

(WebCore::FocusController::findFocusableNodeInDirection): Ditto.

  • rendering/MediaControlElements.cpp:

(WebCore::MediaControlElement::rendererIsNeeded): Ditto.
(WebCore::MediaControlElement::attach): Ditto.
(WebCore::MediaControlElement::updateStyle): Ditto.
(WebCore::MediaControlInputElement::rendererIsNeeded): Ditto.
(WebCore::MediaControlInputElement::attach): Ditto.
(WebCore::MediaControlInputElement::updateStyle): Ditto.

  • rendering/RenderSVGGradientStop.cpp:

(WebCore::RenderSVGGradientStop::gradientElement): Ditto.

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::createRenderer): Ditto.
(WebCore::SVGAElement::childShouldCreateRenderer): Ditto.

  • svg/SVGFELightElement.cpp:

(WebCore::SVGFELightElement::svgAttributeChanged): Ditto.
(WebCore::SVGFELightElement::childrenChanged): Ditto.

  • svg/SVGFEMergeNodeElement.cpp:

(WebCore::SVGFEMergeNodeElement::svgAttributeChanged): Ditto.

  • svg/SVGLength.cpp:

(WebCore::SVGLength::determineViewport): Ditto.

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::updateRelativeLengthsInformation): Ditto.

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::removeDisallowedElementsFromSubtree): Ditto.

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::insertedIntoDocument): Ditto.

  • xml/XPathNodeSet.cpp:

(WebCore::XPath::NodeSet::sort): Ditto.

  • xml/XPathStep.cpp:

(WebCore::XPath::Step::nodesInAxis): Ditto.

  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::xsltStylesheetPointer): Ditto.

WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::insertStyleText): Changed to use parentNode.
(WebKit::WebFrameImpl::setFindEndstateFocusAndSelection): Ditto.

WebKit/qt:

  • Api/qwebelement.cpp:

(QWebElement::prependOutside): Changed to use parentNode.
(QWebElement::appendOutside): Ditto.
(QWebElement::encloseContentsWith): Ditto.
(QWebElement::encloseWith): Ditto.

WebKit2:

  • WebProcess/WebPage/WebPage.cpp: Changed to use parentNode.

(WebKit::WebPage::findZoomableAreaForPoint): Ditto.

4:08 PM Changeset in webkit [72258] by sfalken@apple.com
  • 3 edits
    1 add in trunk/WebKitTools

2010-11-17 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

WinLauncher should use vsprops for shared build settings
https://bugs.webkit.org/show_bug.cgi?id=49695

  • WinLauncher/WinLauncher.cpp: (_tWinMain): (PrintView): (WndProc): (MyEditProc):
  • WinLauncher/WinLauncher.vcproj:
  • WinLauncher/WinLauncherCommon.vsprops: Added.
4:06 PM Changeset in webkit [72257] by aestes@apple.com
  • 1 edit
    7 adds in trunk/LayoutTests

Create Leopard-specific results for tests that differ between Leopard
and Snow Leopard due to r72173.

  • platform/mac-leopard/platform/mac/editing: Added.
  • platform/mac-leopard/platform/mac/editing/input: Added.
  • platform/mac-leopard/platform/mac/editing/input/devanagari-ligature-expected.txt: Added.
  • platform/mac-leopard/platform/mac/svg: Added.
  • platform/mac-leopard/platform/mac/svg/batik: Added.
  • platform/mac-leopard/platform/mac/svg/batik/text: Added.
  • platform/mac-leopard/platform/mac/svg/batik/text/smallFonts-expected.txt: Added.
3:58 PM Changeset in webkit [72256] by aestes@apple.com
  • 11 edits in trunk/LayoutTests

Add Leopard-specific results for r72173.

  • platform/mac-leopard/css2.1/t1202-counter-04-b-expected.txt:
  • platform/mac-leopard/css2.1/t1202-counters-04-b-expected.txt:
  • platform/mac-leopard/fast/text/complex-text-opacity-expected.txt:
  • platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt:
  • platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt:
  • platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.txt:
  • platform/mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
  • platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/mac-leopard/fast/text/international/thai-baht-space-expected.txt:
3:57 PM Changeset in webkit [72255] by tony@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2010-11-17 Tony Chang <tony@chromium.org>

Unreviewed, add chromium-win baselines for fast/text/atsui-negative-spacing-features.html.

  • platform/chromium-win/fast/text/atsui-negative-spacing-features-expected.checksum: Added.
  • platform/chromium-win/fast/text/atsui-negative-spacing-features-expected.png: Added.
  • platform/chromium-win/fast/text/atsui-negative-spacing-features-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:41 PM Changeset in webkit [72254] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

2010-11-17 Tony Chang <tony@chromium.org>

Unreviewed, skip atsui-negative-spacing-features.html on qt and
gtk since the other atsui tests are skipped.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
3:37 PM Changeset in webkit [72253] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-11-17 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

ScrollView: Don't translate by scrollX/scrollY or clip when paintsEntireContents()

This makes paint() with paintEntireContents() do exactly what it's supposed to:
paint from 0,0 to contentsSize().

The clipping was a no-op anyway since visibleContentRect() will return the whole
rect in paintsEntireContents() mode.

  • platform/ScrollView.cpp: (WebCore::ScrollView::paint):
3:19 PM Changeset in webkit [72252] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-11-17 Kenneth Rohde Christansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

ScrollView: Update the actualVisibleContentRect after delegating a scroll.

This lets us avoid updating the actualVisibleContentRect from the client
after each scroll. We had to do this synchronously for WebKit2 to support
programmatic "animated scrolling" from JS.

  • platform/ScrollView.cpp: (WebCore::ScrollView::setScrollPosition):
3:18 PM Changeset in webkit [72251] by sfalken@apple.com
  • 1 edit
    1 delete in trunk/WebKitTools

Delete unused file unintentionally added in last change.

  • DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.
3:16 PM Changeset in webkit [72250] by sfalken@apple.com
  • 4 edits
    7 adds in trunk/WebKitTools

DumpRenderTree on Windows should use a vsprops file for shared project settings
https://bugs.webkit.org/show_bug.cgi?id=49690

Reviewed by Adam Roben.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
  • DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
  • DumpRenderTree/win/ImageDiff.vcproj:
  • DumpRenderTree/win/ImageDiffCommon.vsprops: Added.
3:09 PM TriagingTestFailures edited by Adam Roben
Remove a no-longer-necessary Windows distinction (see r72245) (diff)
3:02 PM Changeset in webkit [72249] by hayato@chromium.org
  • 11 edits
    1 add in trunk/WebKitTools

2010-11-17 Hayato Ito <hayato@chromium.org>

Refactor TestTypeBase.compare_output().

Introduce a TestOutput class and update compare_output() of each test
types so that they can take both actual and expected TestOutput objects.

https://bugs.webkit.org/show_bug.cgi?id=49431

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2:57 PM Changeset in webkit [72248] by andreas.kling@nokia.com
  • 3 edits in trunk/WebCore

2010-11-17 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

ScrollView: Decouple actualVisibleContentRect from visibleContentRect

Added actualVisibleContentRect() which will return the override provided
by setActualVisibleContentRect() or fall back to visibleContentRect()
if no override has been set.

This is similar to what the iPhone does.

  • platform/ScrollView.cpp: (WebCore::ScrollView::visibleContentRect):
  • platform/ScrollView.h: (WebCore::ScrollView::actualVisibleContentRect): (WebCore::ScrollView::setActualVisibleContentRect): IntRect -> const IntRect&
2:46 PM Changeset in webkit [72247] by timothy@apple.com
  • 2 edits in trunk/WebKit2

Remove duplicate Web Inspector message handeling in WebPage::didReceiveMessage.

https://webkit.org/b/49689

Reviewed by Andreas Kling.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage): Remove duplicate code.

2:46 PM Changeset in webkit [72246] by timothy@apple.com
  • 2 edits in trunk/WebKit2

Fix a crash when closing the inspected page when the Web Inspector
page was never created.

https://bugs.webkit.org/show_bug.cgi?id=49687

Reviewed by John Sullivan.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::sendMessageToFrontend): Null check the Inspector WebPage.

2:37 PM Changeset in webkit [72245] by Adam Roben
  • 2 edits in trunk/WebKitTools

Make each Windows Test builder use the same OS for all its slaves

Currently each WebKit1 Windows Test builder has one Windows XP slave
and one Windows 7 slave. Having different OSes in a single builder
meant that the builders would alternate between red and green when
there were OS-specific failures.

Fixes <http://webkit.org/b/49688> Windows Test builders alternate
between red and green because of multiple OS versions

Reviewed by Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Renamed

"Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows
Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release
(WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the
builders for the two WebKit1 builders so that they would all use the
appropriate OS.

2:33 PM Changeset in webkit [72244] by tony@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-11-17 Tony Chang <tony@chromium.org>

Unreviewed, adding windows baseline for
fast/text/atsui-negative-spacing-features.html

  • platform/win/fast/text/atsui-negative-spacing-features-expected.txt: Added.
2:16 PM Changeset in webkit [72243] by tony@chromium.org
  • 2 edits in trunk/WebCore

2010-11-17 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

[chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
https://bugs.webkit.org/show_bug.cgi?id=49036

No new tests: Covered by plugins/npruntime/get-int-identifier-special-values.html

In http://codereview.chromium.org/11574, the forked chromium test
plugin changed how it testGetIntIdentifier to work around a change
caused by a silverlight specific plugin fix:
http://codereview.chromium.org/11569/diff/1/2

It's not clear to me that this change is needed anymore since
silverlight has had multiple releases, testing without this patch
works on a test windows build, and safari win seems to run silverlight
without this either. Since there's no test for this behavior, I'm
rolling it out so we can match the upstream test.

  • bindings/v8/V8NPUtils.cpp: (WebCore::convertV8ObjectToNPVariant):
2:02 PM Changeset in webkit [72242] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-11-17 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

ScrollView: Let visibleContentRect() return the contentsSize() if paintsEntireContents()

  • platform/ScrollView.cpp: (WebCore::ScrollView::visibleContentRect):
1:57 PM Changeset in webkit [72241] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Don't crash when invalidating a page overlay that hasn't been installed yet
https://bugs.webkit.org/show_bug.cgi?id=49685

Reviewed by John Sullivan.

Null check the web page.

  • WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::setNeedsDisplay):

1:36 PM Changeset in webkit [72240] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-17 Tony Chang <tony@chromium.org>

Unreviewed, css variable support was removed in r72116.

  • platform/chromium/test_expectations.txt:
1:29 PM Changeset in webkit [72239] by tony@chromium.org
  • 4 edits
    7 adds in trunk

2010-11-17 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Chang.

[chromium] Fix negative letter spacing in complex text on linux
https://bugs.webkit.org/show_bug.cgi?id=49563

  • fast/text/atsui-negative-spacing-features.html: Added.
  • platform/chromium-linux/fast/text/atsui-negative-spacing-features-expected.checksum: Added.
  • platform/chromium-linux/fast/text/atsui-negative-spacing-features-expected.png: Added.
  • platform/chromium-linux/fast/text/atsui-negative-spacing-features-expected.txt: Added.
  • platform/mac/fast/text/atsui-negative-spacing-features-expected.checksum: Added.
  • platform/mac/fast/text/atsui-negative-spacing-features-expected.png: Added.
  • platform/mac/fast/text/atsui-negative-spacing-features-expected.txt: Added.

2010-11-17 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Chang.

[chromium] Fix negative letter spacing in complex text on linux
https://bugs.webkit.org/show_bug.cgi?id=49563

Test: fast/text/atsui-negative-spacing-features.html

  • platform/graphics/chromium/FontLinux.cpp: Make spacing signed.
1:16 PM Changeset in webkit [72238] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-11-17 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

ScrollView: Avoid unnecessary work in setScrollPosition() when scrolling is delegated.

  • platform/ScrollView.cpp: (WebCore::ScrollView::setScrollPosition): If delegatesScrolling(), we never use the newScrollPosition, so move that calculation below the delegation path.
1:02 PM Changeset in webkit [72237] by beidson@apple.com
  • 5 edits in trunk/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=49682 - Expose "removeItemAtIndex" in WKMutableArray

Reviewed by Darin Adler.

  • Shared/API/c/WKMutableArray.cpp:

(WKArrayRemoveItemAtIndex):

  • Shared/API/c/WKMutableArray.h:
  • Shared/MutableArray.cpp:

(WebKit::MutableArray::removeItemAtIndex):

  • Shared/MutableArray.h:
1:01 PM Changeset in webkit [72236] by beidson@apple.com
  • 2 edits in trunk/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=49683 - Export WKContextMenuItem and WKContextMenuItemTypes as public headers

Reviewed by Anders Carlsson.

  • WebKit2.xcodeproj/project.pbxproj:
12:55 PM Changeset in webkit [72235] by hyatt@apple.com
  • 48 edits
    9 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=48537

Reviewed by Sam Weinig.

WebCore:

Fonts with no vertical metrics should synthesize baselines when they appear
on lines that do use fonts with vertical metrics. Basically we want to make
sure that English text behaves like vertical-align:middle, i.e., its baseline
should be treated as though it cuts through the middle of the ascent+descent.

The way this works is that each line in the line box tree is labeled as having
a baseline type that is either ideographic or alphabetic for the purposes of
vertical alignment. A line becomes ideographic if any font with vertical tables
is either explicitly specified as the primary font or in any of the used fonts
in the text on that line.

This baselineType is passed down to computeLogicalBoxHeights and placeBoxesInBlockDirection,
and passed to the ascent and descent methods of the fonts that are examined.
The underlying Font code selects an appropriate baseline given the type passed in.

This patch also rewrites vertical alignment to lop 4 bytes off all RenderInlines and
to instead carry around the cached vertical positions for RenderInlines in a new
VerticalPositionCache object. This cache only lives for a single layout
operation, but it does cache information across all the lines built and placed during the
layout.

This matches the old behavior, since every call to layoutInlineChildren invalidated
all of the vertical positions in all of the RenderInlines anyway.

The VerticalPositionCache consists of two HashMaps, and it caches vertical alignment
positions for both alphabetic and ideographic baseline types.

The vertical-align computation has now been moved out of RenderBoxModelObject and
RenderInline and just placed right into verticalPositionForBox in InlineFlowBox.
This function has been changed to no longer be recursive when checking parents,
and it now relies on the fact that the parent vertical alignment computation result
has already been stored in the logicalTop() of that parent's line box. By checking
the line box logicalTop() value instead of recurring, the performance of first lines
now significantly improves to no longer have O(n2) behavior in the depth of the line
box tree on the first line.

All of the baselinePosition functions on the various RenderObjects have been amended
to take a FontBaseline as the first argument. This patch does not attempt to fix up
MathML or form controls yet and just hardcodes AlphabeticBaselines for those renderers.

The RenderTableCell baselinePosition virtual method has been made non-virtual and had
all arguments removed, since it actually had no real connection with the rest of the
baseline positioning system. Cell baseline positioning works by calling firstLineBoxBaseline,
and that method has been patched to use the cached baselineType for the first line box
when computing the baseline of that line.

Added fast/blockflow/vertical-baseline-alignment.html and fast/blockflow/vertical-align-table-baseline.html.

  • WebCore.xcodeproj/project.pbxproj:
  • mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::baselinePosition):

  • mathml/RenderMathMLFraction.h:
  • mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::baselinePosition):

  • mathml/RenderMathMLOperator.h:
  • mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::baselinePosition):

  • mathml/RenderMathMLRow.h:
  • mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::baselinePosition):

  • mathml/RenderMathMLSubSup.h:
  • mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::layout):
(WebCore::RenderMathMLUnderOver::baselinePosition):

  • mathml/RenderMathMLUnderOver.h:
  • platform/graphics/SimpleFontData.h:
  • rendering/InlineBox.h:

(WebCore::InlineBox::baselinePosition):

  • rendering/InlineFlowBox.cpp:

(WebCore::verticalPositionForBox):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):

  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::baselinePosition):

  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::baselinePosition):
(WebCore::RenderBlock::firstLineBoxBaseline):
(WebCore::RenderBlock::lastLineBoxBaseline):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeBlockDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::baselinePosition):

  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp:
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::RenderInline):
(WebCore::RenderInline::baselinePosition):

  • rendering/RenderInline.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::baselinePosition):

  • rendering/RenderListBox.h:
  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::baselinePosition):

  • rendering/RenderListMarker.h:
  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::baselinePosition):

  • rendering/RenderSlider.h:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::baselinePosition):

  • rendering/RenderTableCell.h:
  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::baselinePosition):

  • rendering/RenderTextControlMultiLine.h:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::baselinePosition):

  • rendering/VerticalPositionCache.h: Added.

(WebCore::VerticalPositionCache::VerticalPositionCache):
(WebCore::VerticalPositionCache::get):
(WebCore::VerticalPositionCache::set):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::calculateBoundaries):

LayoutTests:

Fonts with no vertical metrics should synthesize baselines when they appear
on lines that do use fonts with vertical metrics. Basically we want to make
sure that English text behaves like vertical-align:middle, i.e., its baseline
should be treated as though it cuts through the middle of the ascent+descent.

The way this works is that each line in the line box tree is labeled as having
a baseline type that is either ideographic or alphabetic for the purposes of
vertical alignment. A line becomes ideographic if any font with vertical tables
is either explicitly specified as the primary font or in any of the used fonts
in the text on that line.

This baselineType is passed down to computeLogicalBoxHeights and placeBoxesInBlockDirection,
and passed to the ascent and descent methods of the fonts that are examined.
The underlying Font code selects an appropriate baseline given the type passed in.

This patch also rewrites vertical alignment to lop 4 bytes off all RenderInlines and
to instead carry around the cached vertical positions for RenderInlines in a new
VerticalPositionCache object. This cache only lives for a single layout
operation, but it does cache information across all the lines built and placed during the
layout.

This matches the old behavior, since every call to layoutInlineChildren invalidated
all of the vertical positions in all of the RenderInlines anyway.

The VerticalPositionCache consists of two HashMaps, and it caches vertical alignment
positions for both alphabetic and ideographic baseline types.

The vertical-align computation has now been moved out of RenderBoxModelObject and
RenderInline and just placed right into verticalPositionForBox in InlineFlowBox.
This function has been changed to no longer be recursive when checking parents,
and it now relies on the fact that the parent vertical alignment computation result
has already been stored in the logicalTop() of that parent's line box. By checking
the line box logicalTop() value instead of recurring, the performance of first lines
now significantly improves to no longer have O(n2) behavior in the depth of the line
box tree on the first line.

All of the baselinePosition functions on the various RenderObjects have been amended
to take a FontBaseline as the first argument. This patch does not attempt to fix up
MathML or form controls yet and just hardcodes AlphabeticBaselines for those renderers.

The RenderTableCell baselinePosition virtual method has been made non-virtual and had
all arguments removed, since it actually had no real connection with the rest of the
baseline positioning system. Cell baseline positioning works by calling firstLineBoxBaseline,
and that method has been patched to use the cached baselineType for the first line box
when computing the baseline of that line.

Added fast/blockflow/vertical-baseline-alignment.html and fast/blockflow/vertical-align-table-baseline.html

  • fast/blockflow/vertical-align-table-baseline.html: Added.
  • fast/blockflow/vertical-baseline-alignment.html: Added.
  • platform/mac/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
  • platform/mac/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
  • platform/mac/fast/blockflow/vertical-align-table-baseline-expected.txt: Added.
  • platform/mac/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
  • platform/mac/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
  • platform/mac/fast/blockflow/vertical-baseline-alignment-expected.txt: Added.
  • platform/mac/fast/blockflow/vertical-font-fallback-expected.checksum:
  • platform/mac/fast/blockflow/vertical-font-fallback-expected.png:
  • platform/mac/fast/blockflow/vertical-font-fallback-expected.txt:
  • platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
  • platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
12:52 PM Changeset in webkit [72234] by andersca@apple.com
  • 5 edits in trunk/WebKit2

Need way to invalidate part of a WKOverlayRef so it will be redrawn
https://bugs.webkit.org/show_bug.cgi?id=49679
<rdar://problem/8679152>

Reviewed by Darin Adler.

  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(WKBundlePageOverlaySetNeedsDisplay):

  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
  • WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::setNeedsDisplay):

  • WebProcess/WebPage/PageOverlay.h:
12:48 PM Changeset in webkit [72233] by jamesr@google.com
  • 2 edits in trunk/WebKitTools

2010-11-17 James Robinson <jamesr@chromium.org>

Reviewed by Dan Bernstein.

[chromium] Set minimum font size to 0 for DRT
https://bugs.webkit.org/show_bug.cgi?id=49677

Followup for http://trac.webkit.org/changeset/72141.

Test: http/tests/misc/acid3.html

  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset):
12:47 PM Changeset in webkit [72232] by weinig@apple.com
  • 4 edits
    2 adds in trunk

Add stubbed out ScrollAnimator for the Mac
https://bugs.webkit.org/show_bug.cgi?id=49678

Reviewed by Anders Carlsson.

JavaScriptCore:

  • wtf/Platform.h: Enable SMOOTH_SCROLLING on the Mac, this has no

change in behavior at the moment.

WebCore:

  • WebCore.xcodeproj/project.pbxproj:

Add ScrollAnimator.h/cpp.

  • platform/mac/ScrollAnimatorMac.cpp: Added.

(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scroll):
(WebCore::ScrollAnimatorMac::setScrollPositionAndStopAnimation):

  • platform/mac/ScrollAnimatorMac.h: Added.

ScrollAnimatorMac just calls through to the base class for now.

12:31 PM Changeset in webkit [72231] by Martin Robinson
  • 2 edits
    2 adds in trunk/LayoutTests

2010-11-17 Martin Robinson <mrobinson@igalia.com>

Update the skipped list to skip a newly failing geolocation test (requires
geolocation mock support). Organize geolocation test failures a bit better.
Add results for two new tests.

  • platform/gtk/Skipped: Update skipped list.
  • platform/gtk/fast/css/line-height-determined-by-primary-font-expected.txt: Added.
  • platform/gtk/fast/css/negative-leading-expected.txt: Added.
12:11 PM Changeset in webkit [72230] by inferno@chromium.org
  • 16 edits
    2 adds in trunk

2010-11-17 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Modified codepath for object fallback content which has failed to load.
Refactored CachedResource error handling to use more granular statuses instead of a boolean value.
https://bugs.webkit.org/show_bug.cgi?id=46921

Test: fast/html/object-image-nested-fallback.html

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::renderFallbackContent):
  • loader/cache/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::error):
  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedFont.cpp: (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::error):
  • loader/cache/CachedFont.h:
  • loader/cache/CachedImage.cpp: (WebCore::CachedImage::data): (WebCore::CachedImage::error):
  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::canUseCacheValidator): (WebCore::CachedResource::mustRevalidate):
  • loader/cache/CachedResource.h: (WebCore::CachedResource::error): (WebCore::CachedResource::httpStatusCodeError): (WebCore::CachedResource::errorOccurred):
  • loader/cache/CachedScript.cpp: (WebCore::CachedScript::error):
  • loader/cache/CachedScript.h:
  • loader/cache/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::error):
  • loader/cache/CachedXSLStyleSheet.h:
  • loader/loader.cpp: (WebCore::Loader::load): (WebCore::Loader::didFinishLoading): (WebCore::Loader::didFail): (WebCore::Loader::didReceiveData):

2010-11-17 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Added test for multiple image objects which use the same invalid data attribute.
https://bugs.webkit.org/show_bug.cgi?id=46921

  • fast/html/object-image-nested-fallback-expected.txt: Added.
  • fast/html/object-image-nested-fallback.html: Added.
12:07 PM Changeset in webkit [72229] by timothy@apple.com
  • 14 edits in trunk/WebKit2

Provide a way to create a WKView (WebPage) that is hidden from
the InjectedBundle. This is needed for the Web Inspector.

https://webkit.org/b/49670

Reviewed by Sam Weinig.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode): Added visibleToInjectedBundle.
(WebKit::WebPageCreationParameters::decode): Ditto.

  • Shared/WebPageCreationParameters.h: Ditto.
  • UIProcess/API/C/win/WKView.cpp:

(WKViewCreate): Pass VisibleToInjectedBundle to the WebView create function.

  • UIProcess/API/C/win/WKViewPrivate.cpp:

(WKViewCreateForWebInspector): Added. Not used yet. Passes HiddenFromInjectedBundle
to the WebView create function.

  • UIProcess/API/C/win/WKViewPrivate.h: Added WKViewCreateForWebInspector.
  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:pageNamespaceRef:hiddenFromInjectedBundle:]): Added hiddenFromInjectedBundle
parameter and calls WebPageProxy::setVisibleToInjectedBundle.
(-[WKView initWithFrame:pageNamespaceRef:]): Calls initWithFrame:pageNamespaceRef:hiddenFromInjectedBundle:
and passes NO for hiddenFromInjectedBundle.
(-[WKView initWithFrame:]): Cleaned up by removing the local assignment to self and just returns the result.

  • UIProcess/API/mac/WKViewInternal.h: Added initWithFrame:pageNamespaceRef:hiddenFromInjectedBundle:.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy): Initialize m_visibleToInjectedBundle from the creation parameters.
(WebKit::WebPageProxy::creationParameters): Set visibleToInjectedBundle using m_visibleToInjectedBundle.

  • UIProcess/WebPageProxy.h: Added m_visibleToInjectedBundle.

(WebKit::WebPageProxy::visibleToInjectedBundle): Added. Return m_visibleToInjectedBundle.
(WebKit::WebPageProxy::setVisibleToInjectedBundle): Added. Set m_visibleToInjectedBundle.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView): Added InjectedBundleVisibility parameter and calls
WebPageProxy::setVisibleToInjectedBundle.

  • UIProcess/win/WebView.h: Added InjectedBundleVisibility enum.

(WebKit::WebView::create): Added InjectedBundleVisibility parameter.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::create): Checks visibleToInjectedBundle before talking to the injected bundle.
(WebKit::WebPage::WebPage): Initialize m_isVisibleToInjectedBundle from the creation parameters.
(WebKit::WebPage::close): Checks m_isVisibleToInjectedBundle before talking to the injected bundle.

  • WebProcess/WebPage/WebPage.h: Added m_isVisibleToInjectedBundle.
11:55 AM Changeset in webkit [72228] by zmo@google.com
  • 7 edits
    2 adds in trunk

2010-11-16 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

WebGLRenderingContext needs to zero textures and renderbuffers
https://bugs.webkit.org/show_bug.cgi?id=49355

  • src/WebGraphicsContext3DDefaultImpl.cpp: Don't deal with texture initialization at this level.

2010-11-16 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

WebGLRenderingContext needs to zero textures and renderbuffers
https://bugs.webkit.org/show_bug.cgi?id=49355

Test: fast/canvas/webgl/uninitialized-test.html

  • html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::onAccess): Use a parameter to decide if renderbuffer initialization is needed. (WebCore::WebGLFramebuffer::initializeRenderbuffers): Don't return false if color buffer doesn't exist.
  • html/canvas/WebGLFramebuffer.h: Modify onAccess function signature.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::clear): Call onAccess with an added parameter. (WebCore::WebGLRenderingContext::copyTexImage2D): Ditto. (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto. (WebCore::WebGLRenderingContext::drawArrays): Ditto. (WebCore::WebGLRenderingContext::drawElements): Ditto. (WebCore::WebGLRenderingContext::readPixels): Ditto. (WebCore::WebGLRenderingContext::texImage2DBase): Create buffer data of 0s if input is null to initialize textures.

2010-11-16 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

WebGLRenderingContext needs to zero textures and renderbuffers
https://bugs.webkit.org/show_bug.cgi?id=49355

  • fast/canvas/webgl/uninitialized-test-expected.txt: Added.
  • fast/canvas/webgl/uninitialized-test.html: Added.
11:46 AM Changeset in webkit [72227] by commit-queue@webkit.org
  • 1 edit in trunk/ChangeLog

2010-11-17 Commit Queue <commit-queue@webkit.org>

Unreviewed. Test commit for commit-queue@webkit.org.

11:27 AM Changeset in webkit [72226] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-11-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

Fix a typo that leads to emitting the wrong signal if it is done
by using the signals array.

  • webkit/webkitwebview.cpp: (webkit_web_view_class_init):
11:27 AM Changeset in webkit [72225] by sfalken@apple.com
  • 1 edit in trunk/WebKitTools/TestWebKitAPI/win/TestWebKitAPI.vcproj

Unreviewed build fix. Don't put object files into the source tree.

11:24 AM Changeset in webkit [72224] by abecsi@webkit.org
  • 2 edits in trunk/WebKit2

Unreviewed buildfix.

[Qt] D'oh! I screwed up the dependencies.

  • DerivedSources.pro:
11:15 AM Changeset in webkit [72223] by abecsi@webkit.org
  • 1 edit
    1 add in trunk/WebKitTools

Unreviewed build fix.

[Qt] Add missing resource file I forgot in r72220.

  • MiniBrowser/MiniBrowser.qrc: Added.
10:56 AM Changeset in webkit [72222] by rniwa@webkit.org
  • 5 edits in trunk/WebCore

2010-11-17 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Merge ScriptElement and ScriptElementData
https://bugs.webkit.org/show_bug.cgi?id=49647

Merged two classes.

  • dom/AsyncScriptRunner.cpp: (WebCore::AsyncScriptRunner::executeScriptSoon): Takes ScriptElement* instead of ScriptElementData*. (WebCore::AsyncScriptRunner::timerFired): Uses ScriptElement* instead of ScriptElementData*.
  • dom/AsyncScriptRunner.h:
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::ScriptElement): Merged with ScriptElementData::ScriptElementData. (WebCore::ScriptElement::~ScriptElement): Merged with ScriptElementData::~ScriptElementData. (WebCore::ScriptElement::insertedIntoDocument): Calls createdByParser, isAsynchronous, requestScript, and scriptContent. (WebCore::ScriptElement::removedFromDocument): Calls stopLoadRequest. (WebCore::ScriptElement::childrenChanged): Calls createdByParser and accesses m_element. (WebCore::ScriptElement::finishParsingChildren): Calls scriptContent. (WebCore::ScriptElement::handleSourceAttribute): Calls ignoresLoadRequest and requestScript. (WebCore::ScriptElement::requestScript): Moved from ScriptElementData; calls dispatchErrorEvent. (WebCore::ScriptElement::evaluateScript): Moved from ScriptElementData. (WebCore::ScriptElement::executeScript): Ditto. (WebCore::ScriptElement::stopLoadRequest): Ditto. (WebCore::ScriptElement::execute): Moved from ScriptElementData; calls dispatchErrorEvent and dispatchLoadEvent. (WebCore::ScriptElement::notifyFinished): Moved from ScriptElementData. (WebCore::ScriptElement::ignoresLoadRequest): Ditto. (WebCore::ScriptElement::shouldExecuteAsJavaScript): Moved from ScriptElementData; calls typeAttributeValue, languageAttributeValue, forAttributeValue, and eventAttributeValue. (WebCore::ScriptElement::scriptCharset): Moved from ScriptElementData. (WebCore::ScriptElement::scriptContent): Ditto. (WebCore::ScriptElement::isAsynchronous): Moved from ScriptElementData; calls sourceAttributeValue and asyncAttributeValue. (WebCore::ScriptElement::isDeferred): Moved from ScriptElementData; calls sourceAttributeValue, asyncAttributeValue, and deferAttributeValue.
  • dom/ScriptElement.h: (WebCore::ScriptElement::element): (WebCore::ScriptElement::haveFiredLoadEvent): (WebCore::ScriptElement::setHaveFiredLoadEvent): (WebCore::ScriptElement::createdByParser): (WebCore::ScriptElement::isEvaluated):
10:43 AM Changeset in webkit [72221] by andreas.kling@nokia.com
  • 3 edits in trunk/WebKit2

2010-11-17 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

[WK2] Set paintsEntireContents for "resizes to contents" mode

Only relevant for the tiled backing store.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setResizesToContentsUsingLayoutSize):
10:40 AM Changeset in webkit [72220] by abecsi@webkit.org
  • 8 edits in trunk

2010-11-17 Andras Becsi <abecsi@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=49627

Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser.

  • MiniBrowser/MiniBrowser.qrc: Added. Add it here to prevent qmake from detecting it since it needs to be copied to the build directory.
  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): (BrowserWindow::updateUserAgentList): (BrowserWindow::showUserAgentDialog):
  • MiniBrowser/qt/BrowserWindow.h:
  • MiniBrowser/qt/MiniBrowser.pro:

2010-11-17 Andras Becsi <abecsi@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=49627

Copy the MiniBrowser.qrc and QtTestBrowser's useragentlist.txt file
to the build directory of MiniBrowser because it has to be in a
subdirectory of the resource file.
Add a method to QWKPage to retrieve the custom user agent string.

  • DerivedSources.pro:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::customUserAgent):
  • UIProcess/API/qt/qwkpage.h:
10:31 AM Changeset in webkit [72219] by sfalken@apple.com
  • 3 edits in trunk/WebKitLibraries

Update WebKitSystemInterfaceWin.

Rubber-stamped by Adam Roben.

  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
10:13 AM Changeset in webkit [72218] by Adam Roben
  • 3 edits in trunk/WebKitTools

Make changes to the Mac WebKit2 Skipped file trigger Windows builds

We use that file on Windows!

Fixes <http://webkit.org/b/49643> Changes to
LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't

Reviewed by Steve Falkenburg.

  • Scripts/webkitpy/common/config/build.py:

(_should_file_trigger_build): Added the mac-wk2 directory and make it
trigger builds on SnowLeopard and Windows.

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest.test_should_build): Added a test.

10:03 AM Changeset in webkit [72217] by Adam Roben
  • 11 edits in trunk/LayoutTests

Update Windows results after r72125 and r72173

  • platform/win/css2.1/t1202-counter-04-b-expected.txt:
  • platform/win/css2.1/t1202-counters-04-b-expected.txt:
  • platform/win/fast/blockflow/border-vertical-lr-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
  • platform/win/fast/text/international/complex-character-based-fallback-expected.txt:
  • platform/win/fast/text/international/hebrew-vowels-expected.txt:
  • platform/win/transforms/2d/hindi-rotated-expected.txt:
9:57 AM Debugging With Visual Studio edited by Adam Roben
Add instructions for inspecting WebKit2 API types (diff)
9:56 AM Changeset in webkit [72216] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-17 Tenghui Zhu <ztenghui@google.com>

Reviewed by Jeremy Orlow.

profileCallback and profileEndCallback should be guarded with ENABLE_JAVASCRIPT_DEBUGGER
https://bugs.webkit.org/show_bug.cgi?id=49623

No new tests. Just a compiling error fix.

  • bindings/v8/custom/V8ConsoleCustom.cpp: Add the guard ENABLE_JAVA_SCRIPT_DEBUGGER to profileCallback and profileEndCallback
9:45 AM Changeset in webkit [72215] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Update WebKit2 skipped list.

Rubber-stamped by Jon Honeycutt.

  • platform/mac-wk2/Skipped:
9:39 AM Changeset in webkit [72214] by mihaip@chromium.org
  • 4 edits in trunk/WebKitTools

2010-11-17 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Clear the speech input mock explicitly before each test.
https://bugs.webkit.org/show_bug.cgi?id=49660

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::speechInputController): (WebViewHost::reset): Invoke speech input mock's clearResults method.
  • DumpRenderTree/chromium/WebViewHost.h: (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
9:28 AM Changeset in webkit [72213] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-11-17 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Introduce GeoNotifierVector typedef for increased readability
https://bugs.webkit.org/show_bug.cgi?id=49597

  • page/Geolocation.cpp: (WebCore::Geolocation::Watchers::getNotifiersVector): (WebCore::Geolocation::sendError): (WebCore::Geolocation::sendPosition): (WebCore::Geolocation::stopTimer): (WebCore::Geolocation::stopTimersForOneShots): (WebCore::Geolocation::stopTimersForWatchers): (WebCore::Geolocation::cancelRequests): (WebCore::Geolocation::cancelAllRequests): (WebCore::Geolocation::handleError): (WebCore::Geolocation::makeSuccessCallbacks):
  • page/Geolocation.h:
9:25 AM Changeset in webkit [72212] by Simon Fraser
  • 6 edits
    2 adds in trunk/WebKit2

2010-11-17 Simon Fraser <Simon Fraser>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=45567
Add stubbed-out layer-backed drawing area for Windows.

Add implementations of LayerBackedDrawingArea and
LayerBackedDrawingAreaProxy for Windows, and add them
to the vcproj.

  • UIProcess/LayerBackedDrawingAreaProxy.cpp:
  • UIProcess/win/LayerBackedDrawingAreaProxyWin.cpp: Added. (WebKit::LayerBackedDrawingAreaProxy::page): (WebKit::LayerBackedDrawingAreaProxy::platformSetSize): (WebKit::LayerBackedDrawingAreaProxy::attachCompositingContext): (WebKit::LayerBackedDrawingAreaProxy::detachCompositingContext): (WebKit::LayerBackedDrawingAreaProxy::paint):
  • UIProcess/win/WebView.cpp: (WebKit::WebView::pageDidEnterAcceleratedCompositing): (WebKit::WebView::pageDidLeaveAcceleratedCompositing): (WebKit::WebView::switchToDrawingAreaTypeIfNecessary):
  • UIProcess/win/WebView.h:
  • WebProcess/WebPage/LayerBackedDrawingArea.cpp:
  • WebProcess/WebPage/win/LayerBackedDrawingAreaWin.cpp: Added. (WebKit::LayerBackedDrawingArea::platformInit): (WebKit::LayerBackedDrawingArea::platformClear): (WebKit::LayerBackedDrawingArea::attachCompositingContext): (WebKit::LayerBackedDrawingArea::detachCompositingContext): (WebKit::LayerBackedDrawingArea::setRootCompositingLayer): (WebKit::LayerBackedDrawingArea::scheduleCompositingLayerSync): (WebKit::LayerBackedDrawingArea::syncCompositingLayers):
  • win/WebKit2.vcproj:
9:08 AM Changeset in webkit [72211] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

2010-11-17 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Add a layout test to check that Geoposition timestamps are
well-formed. See https://bugs.webkit.org/show_bug.cgi?id=48518

  • fast/dom/Geolocation/script-tests/timestamp.js: Added. (checkPosition):
  • fast/dom/Geolocation/timestamp-expected.txt: Added.
  • fast/dom/Geolocation/timestamp.html: Added.

2010-11-17 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Convert correctly between GeolocationPosition and Geoposition
timestamp formats.
https://bugs.webkit.org/show_bug.cgi?id=48518

Test: fast/dom/Geolocation/timestamp.html

  • page/Geolocation.cpp: (WebCore::createGeoposition):
8:48 AM Changeset in webkit [72210] by chang.shu@nokia.com
  • 4 edits in trunk

2010-11-17 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

[Mac] Unskip the test that is passing now.

Test: fast/events/spatial-navigation/snav-single-select.html

  • platform/mac/Skipped:

2010-11-17 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

[Mac] Suppress single select popup menu when spatial navigation is enabled on Mac.
This makes spatial navigation work properly for single select box.

Test: fast/events/spatial-navigation/snav-single-select.html

  • dom/SelectElement.cpp: (WebCore::nextValidIndex): (WebCore::SelectElement::menuListDefaultEventHandler):
8:36 AM Changeset in webkit [72209] by ddkilzer@apple.com
  • 2 edits in trunk/JavaScriptCore

<http://webkit.org/b/49634> Make overflow guards in WTF::String::utf8 explicit

Reviewed by Darin Adler.

Add an explicit overflow check prior to allocating our buffer,
rather than implicitly relying on the guard in convertUTF16ToUTF8.

  • wtf/text/WTFString.cpp:

(WTF::String::utf8):

8:13 AM Changeset in webkit [72208] by antonm@chromium.org
  • 3 edits in trunk/LayoutTests

Not reviewed, rebaselining fast/js/regexp-overflow.html

https://bugs.webkit.org/show_bug.cgi?id=49665

  • platform/chromium-mac/fast/js/regexp-overflow-expected.txt:
  • platform/chromium-win/fast/js/regexp-overflow-expected.txt:
7:52 AM Changeset in webkit [72207] by commit-queue@webkit.org
  • 20 edits in trunk

2010-11-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72197.
http://trac.webkit.org/changeset/72197
https://bugs.webkit.org/show_bug.cgi?id=49661

broke fast/regex/test1.html (Requested by stampho on #webkit).

  • runtime/JSGlobalData.h:
  • runtime/RegExp.cpp: (JSC::RegExpRepresentation::~RegExpRepresentation): (JSC::RegExp::compile): (JSC::RegExp::match):
  • tests/mozilla/expected.html:
  • wtf/Platform.h:
  • yarr/RegexCompiler.cpp:
  • yarr/RegexCompiler.h:
  • yarr/RegexInterpreter.cpp:
  • yarr/RegexInterpreter.h:
  • yarr/RegexJIT.cpp: (JSC::Yarr::jitCompileRegex):
  • yarr/RegexJIT.h: (JSC::Yarr::RegexCodeBlock::RegexCodeBlock): (JSC::Yarr::RegexCodeBlock::~RegexCodeBlock): (JSC::Yarr::RegexCodeBlock::getFallback): (JSC::Yarr::RegexCodeBlock::setFallback): (JSC::Yarr::executeRegex):
  • yarr/RegexParser.h:
  • yarr/RegexPattern.h:

2010-11-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72197.
http://trac.webkit.org/changeset/72197
https://bugs.webkit.org/show_bug.cgi?id=49661

broke fast/regex/test1.html (Requested by stampho on #webkit).

  • fast/js/regexp-look-ahead-empty-expected.txt:
  • fast/js/regexp-overflow-expected.txt:
  • fast/js/script-tests/regexp-overflow.js:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.5_Term/S15.10.2.5_A1_T4-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.8_Atom/S15.10.2.8_A2_T1-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.6/15.10.6.2_RegExp.prototype.exec/S15.10.6.2_A1_T6-expected.txt:
7:17 AM Changeset in webkit [72206] by satish@chromium.org
  • 11 edits in trunk

2010-11-17 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Clear the speech input mock explicitly before each test.
https://bugs.webkit.org/show_bug.cgi?id=49660

  • platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::clearResults): Added clearResults method.
  • platform/mock/SpeechInputClientMock.h:

2010-11-17 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Clear the speech input mock explicitly before each test.
https://bugs.webkit.org/show_bug.cgi?id=49660

  • public/WebSpeechInputControllerMock.h:
  • src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::clearResults): Added method to clear results.
  • src/WebSpeechInputControllerMockImpl.h:

2010-11-17 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Clear the speech input mock explicitly before each test.
https://bugs.webkit.org/show_bug.cgi?id=49660

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::speechInputController): (WebViewHost::reset): Invoke speech input mock's clearResults method.
  • DumpRenderTree/chromium/WebViewHost.h: (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
6:49 AM Changeset in webkit [72205] by apavlov@chromium.org
  • 2 edits in trunk/WebCore

2010-11-17 Alexander Pavlov <apavlov@chromium.org>

[Chromium] Unreviewed, fix Chromium-Mac build from r72189.

  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::getDoubleValue):
6:06 AM Changeset in webkit [72204] by hans@chromium.org
  • 2 edits in trunk/WebCore

2010-11-17 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: IDBKey::whereSyntax should impose conditions on all columns
https://bugs.webkit.org/show_bug.cgi?id=49601

The WHERE clause should specifiy a condition for each key column to
make sure that the ObjectStoreData_composit index can be used when
querying the object store based on key. Not using the index causes
severe performance degradation for common IDB operations.

  • storage/IDBKey.cpp: (WebCore::IDBKey::whereSyntax):
6:04 AM Changeset in webkit [72203] by apavlov@chromium.org
  • 2 edits in trunk/WebKitTools

2010-11-17 Alexander Pavlov <apavlov@chromium.org>

Unreviewed, specify IRC nickname in committers.py.

  • Scripts/webkitpy/common/config/committers.py:
5:50 AM Changeset in webkit [72202] by benjamin.poulain@nokia.com
  • 6 edits in trunk/WebKit2

[Qt] [WK2] The focus switching does not seems to work with QGraphicsWKView
https://bugs.webkit.org/show_bug.cgi?id=49545

Reviewed by Kenneth Rohde Christiansen.

Implement focus switching with Tab. This is now done asynchronously,
waiting for webkit to call takeFocus() and switching the widget.

Since the focus can change between the Tab press and the callback,
QGraphicsWKView::focusNextPrevChildCallback() make sure the view still has
focus before passing it to the next widget.

  • UIProcess/API/qt/qgraphicswkview.cpp:

(QGraphicsWKView::QGraphicsWKView):
(QGraphicsWKView::focusNextPrevChildCallback):
(QGraphicsWKView::focusNextPrevChild):

  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::takeFocus):

  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:
5:32 AM Changeset in webkit [72201] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, disabling fast/css/getFloatValueForUnit.html.

https://bugs.webkit.org/show_bug.cgi?id=49656

  • platform/chromium/test_expectations.txt:
5:30 AM Changeset in webkit [72200] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

2010-11-17 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

[Chromium] implementation of async FileWriter for workers
https://bugs.webkit.org/show_bug.cgi?id=47681

Tests are in a separate changelist.

  • platform/CrossThreadCopier.h: Changed CrossThreadCopier[Base] to support PassRefPtrs

2010-11-17 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

[Chromium] implementation of async FileWriter for workers
https://bugs.webkit.org/show_bug.cgi?id=47681

Tests are in a separate changelist.

Added new files.

  • WebKit.gyp:
  • src/WorkerAsyncFileSystemChromium.cpp: Added WorkerAsyncFileWriterChromium construction.
  • src/WorkerAsyncFileWriterChromium.cpp: Added.
  • src/WorkerAsyncFileWriterChromium.h: Added.

This class bridges between the context and main threads for the WorkerAsyncFileWriterChromium.

  • src/WorkerFileWriterCallbacksBridge.cpp: Added.
  • src/WorkerFileWriterCallbacksBridge.h: Added.
5:26 AM Changeset in webkit [72199] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-17 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Commenting out failing Qt inspector tests. Need to fix harness.

  • platform/qt/Skipped:
5:24 AM Changeset in webkit [72198] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, now disabling for real fast/css/line-height-determined-by-primary-font.html.

https://bugs.webkit.org/show_bug.cgi?id=49653

  • platform/chromium/test_expectations.txt:
5:15 AM Changeset in webkit [72197] by Csaba Osztrogonác
  • 20 edits in trunk

YARR JIT should fallback to YARR Interpreter instead of PCRE.
https://bugs.webkit.org/show_bug.cgi?id=46719

Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-11-17
Reviewed by Gavin Barraclough.

Remove the ENABLE_YARR macro and the option of matching regular
expressions with PCRE from JavaScriptCore.

JavaScriptCore:

  • runtime/JSGlobalData.h:
  • runtime/RegExp.cpp:

(JSC::RegExp::compile):
(JSC::RegExp::match):

  • tests/mozilla/expected.html:
  • wtf/Platform.h:
  • yarr/RegexCompiler.cpp:
  • yarr/RegexCompiler.h:
  • yarr/RegexInterpreter.cpp:

(JSC::Yarr::byteCompileRegex):

  • yarr/RegexInterpreter.h:
  • yarr/RegexJIT.cpp:

(JSC::Yarr::jitCompileRegex):

  • yarr/RegexJIT.h:

(JSC::Yarr::RegexCodeBlock::RegexCodeBlock):
(JSC::Yarr::RegexCodeBlock::~RegexCodeBlock):
(JSC::Yarr::RegexCodeBlock::getFallback):
(JSC::Yarr::RegexCodeBlock::isFallback):
(JSC::Yarr::RegexCodeBlock::setFallback):
(JSC::Yarr::executeRegex):

  • yarr/RegexParser.h:
  • yarr/RegexPattern.h:

LayoutTests:

  • fast/js/regexp-look-ahead-empty-expected.txt:
  • fast/js/regexp-overflow-expected.txt:
  • fast/js/script-tests/regexp-overflow.js:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.5_Term/S15.10.2.5_A1_T4-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.8_Atom/S15.10.2.8_A2_T1-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.6/15.10.6.2_RegExp.prototype.exec/S15.10.6.2_A1_T6-expected.txt:
5:09 AM Changeset in webkit [72196] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-11-17 John Mellor <johnme@chromium.org>

Reviewed by Darin Fisher.

[chromium] Expose frame flattening setting in WebSettings.
https://bugs.webkit.org/show_bug.cgi?id=49621

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setFrameFlatteningEnabled):
  • src/WebSettingsImpl.h:
5:03 AM Changeset in webkit [72195] by apavlov@chromium.org
  • 1 edit
    4 deletes in trunk/LayoutTests

2010-11-17 Alexander Pavlov <apavlov@chromium.org>

Unreviewed, remove stale Chromium test expectations to fix build.

  • platform/chromium-linux/fast/css/getFloatValueForUnit-expected.png: Removed.
  • platform/chromium-win/fast/css/getFloatValueForUnit-expected.png: Removed.
  • platform/mac-leopard/fast/css/getFloatValueForUnit-expected.png: Removed.
  • platform/mac/fast/css/getFloatValueForUnit-expected.png: Removed.
4:54 AM Changeset in webkit [72194] by Csaba Osztrogonác
  • 2 edits
    2 adds in trunk/WebKitTools

[NRWT] Make http locking similar to perl implementation
https://bugs.webkit.org/show_bug.cgi?id=49187

Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-11-17
Reviewed by Tony Chang.

  • Scripts/webkitpy/common/system/file_lock.py: Added.
  • Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/http_lock.py:
4:37 AM Changeset in webkit [72193] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit2

2010-11-17 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Don't prohibit scrolling in tiled backing store mode.

We delegate scrolling instead.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
4:19 AM Changeset in webkit [72192] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-11-17 Jonathan Backer <backer@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Resize initiated by renderer.
https://bugs.webkit.org/show_bug.cgi?id=49617

To address synchronization issues with resizing, make resize work like DARWIN.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::resize):
4:06 AM Changeset in webkit [72191] by alex
  • 3 edits in trunk/WebCore

2010-11-17 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[gtk] r69119 modified just the gtk2 version of the
scrolled_window_paint function but not the gtk3 version
https://bugs.webkit.org/show_bug.cgi?id=49585

Use gtk_paint_shadow the same as the actual code from GTK+. Avoid
using state and use the same values we are using for gtk2 in the
paint function.

  • platform/gtk/ScrollbarThemeGtk.cpp: (WebCore::ScrollbarThemeGtk::paintButton): Initialized the depressed attribute of the state variable to avoid using it without initialization.
  • platform/gtk/gtk3drawing.c: (moz_gtk_scrolled_window_paint):
3:41 AM Changeset in webkit [72190] by alex
  • 5 edits in trunk/LayoutTests

2010-11-17 Alejandro G. Castro <alex@igalia.com>

Unreviewed, GTK expectations update after r72116 and r72141.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
3:39 AM Changeset in webkit [72189] by apavlov@chromium.org
  • 7 edits
    1 add
    7 deletes in trunk

2010-11-16 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Simon Fraser.

CSSPrimitiveValue.getFloatValue does not convert sizes
https://bugs.webkit.org/show_bug.cgi?id=35770

Extended getFloatValueForUnit and CSSPrimitiveValue tests. The former has been made text-only,
which allowed to get rid of a number of unnecessary baselines.

  • fast/css/CSSPrimitiveValue-exceptions-expected.txt:
  • fast/css/getFloatValueForUnit-expected.txt: Added.
  • fast/css/getFloatValueForUnit.html:
  • fast/css/resources/CSSPrimitiveValue-exceptions.js:
  • platform/chromium-linux/fast/css/getFloatValueForUnit-expected.checksum: Removed.
  • platform/chromium-win/fast/css/getFloatValueForUnit-expected.checksum: Removed.
  • platform/chromium-win/fast/css/getFloatValueForUnit-expected.txt: Removed.
  • platform/mac-leopard/fast/css/getFloatValueForUnit-expected.checksum: Removed.
  • platform/mac/fast/css/getFloatValueForUnit-expected.checksum: Removed.
  • platform/mac/fast/css/getFloatValueForUnit-expected.txt: Removed.
  • platform/qt/fast/css/getFloatValueForUnit-expected.txt: Removed.

2010-11-16 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Simon Fraser.

CSSPrimitiveValue.getFloatValue does not convert sizes
https://bugs.webkit.org/show_bug.cgi?id=35770

Implemented all same-category unit conversions (length, angle, time, frequency) and retained
absolute-relative (cm, mm, in, pt, pc) length conversions intact.
Illegal unit conversion attempts will throw an INVALID_ACCESS_ERR DOMException.

  • css/CSSPrimitiveValue.cpp: (WebCore::unitCategory): (WebCore::conversionToCanonicalUnitsScaleFactor): (WebCore::CSSPrimitiveValue::getDoubleValue): (WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory): (WebCore::CSSPrimitiveValue::getDoubleValueInternal): (WebCore::CSSPrimitiveValue::getIdent):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getFloatValue): (WebCore::CSSPrimitiveValue::getIntValue):
3:29 AM Changeset in webkit [72188] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-17 Ademar de Souza Reis Jr. <Ademar Reis>

Reviewed by Andreas Kling.

Document::nodesFromRect() has wrong source code documentation
https://bugs.webkit.org/show_bug.cgi?id=49610

  • dom/Document.h: fix nodesFromRect() documentation
3:21 AM Changeset in webkit [72187] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, disabling three layout tests for Chromium.

https://bugs.webkit.org/show_bug.cgi?id=49653

  • platform/chromium/test_expectations.txt:
3:03 AM Changeset in webkit [72186] by Csaba Osztrogonác
  • 3 edits in trunk/JavaScriptCore

Extend YARR Interpreter with beginning character look-up optimization
https://bugs.webkit.org/show_bug.cgi?id=45751

Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-11-17
Reviewed by Gavin Barraclough.

Add beginning character look-up optimization which sets the start
index to the first possible successful pattern match.
Extend YARR Interpreter with lookupForBeginChars function which
implements the beginning character look-up optimization.

  • yarr/RegexInterpreter.cpp:

(JSC::Yarr::Interpreter::InputStream::readPair):
(JSC::Yarr::Interpreter::InputStream::isNotAvailableInput):
(JSC::Yarr::Interpreter::lookupForBeginChars):
(JSC::Yarr::Interpreter::matchDisjunction):
(JSC::Yarr::Interpreter::interpret):

  • yarr/RegexInterpreter.h:

(JSC::Yarr::BytecodePattern::BytecodePattern):

3:01 AM Changeset in webkit [72185] by Simon Hausmann
  • 3 edits in trunk/WebKit2

[Qt] Improve painting performance on 16-bit displays

Reviewed by Kenneth Christiansen.

When the default pixmap depth is 16-bit, then use RGB16 instead of
RGB32 for the chunks, to avoid unnecessary conversions and reduce
chunk size. The conversions happen as images as QPixmaps have 16-bit
depth and the tiles on the ui process are also backed by QPixmaps.

  • Shared/qt/UpdateChunk.cpp:

(WebKit::UpdateChunk::size):
(WebKit::UpdateChunk::createImage):

  • Shared/qt/UpdateChunk.h:
2:54 AM Changeset in webkit [72184] by Simon Hausmann
  • 7 edits
    3 adds in trunk

[Qt] Add support for use GStreamer with the Qt build

Reviewed by Kenneth Christiansen, Tor Arne Vestbø.

JavaScriptCore:

Enable the build/inclusion of the wtf/QObject convenience classes.

WebCore:

Make it possible to use gstreamer with the Qt build via the USE_GSTREAMER macro. The
integration is rather basic at this point, allowing for software based rendering
only at the moment. AC integration and fullscreen playback is still missing.

  • WebCore.pro: Added a bunch of gstreamer files to the build and guard it as a

build option with the USE_GSTREAMER macro.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::installedMediaEngines): Don't use the generic media player registration
when using GStreamer. These #ifdefs should be removed, but the gstreamer folks want
to be able to build with gstreamer _and_ another backend simultaenously.

  • platform/graphics/gstreamer/ImageGStreamer.h:
  • platform/graphics/gstreamer/ImageGStreamerQt.cpp: Added.

(ImageGStreamer::createImage):
(ImageGStreamer::ImageGStreamer):
(ImageGStreamer::~ImageGStreamer):

  • platform/graphics/gstreamer/PlatformVideoWindowPrivate.h: Added.
  • platform/graphics/gstreamer/PlatformVideoWindowQt.cpp: Added.

(FullScreenVideoWindow::FullScreenVideoWindow):
(FullScreenVideoWindow::keyPressEvent):
(FullScreenVideoWindow::event):
(PlatformVideoWindow::PlatformVideoWindow):
(PlatformVideoWindow::~PlatformVideoWindow):
(PlatformVideoWindow::prepareForOverlay):

2:49 AM Changeset in webkit [72183] by morrita@google.com
  • 6 edits in trunk/WebKitTools

2010-11-17 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

[Chromium][DRT] EventSender.contextClick() should aware spellchecking
https://bugs.webkit.org/show_bug.cgi?id=49366

  • EvenSender: Checked WebContextMenuData.misspelledWord and added extra context menu entries according to the spellchecker suggestion
  • MockSpellCheck: add fillSuggestionList to provide fake suggestions.

test_expectations.txt will be changed after this change is ported to test_shell.

  • DumpRenderTree/chromium/EventSender.cpp: (makeMenuItemStringsFor): (EventSender::contextClick):
  • DumpRenderTree/chromium/MockSpellCheck.cpp: (MockSpellCheck::fillSuggestionList): (MockSpellCheck::initializeIfNeeded):
  • DumpRenderTree/chromium/MockSpellCheck.h:
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::mockSpellCheck):
  • DumpRenderTree/chromium/WebViewHost.h:
2:48 AM Changeset in webkit [72182] by apavlov@chromium.org
  • 6 edits in trunk

2010-11-17 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] editing disabled styles breaks style bodies.
https://bugs.webkit.org/show_bug.cgi?id=49602

  • inspector/styles-new-API-expected.txt:
  • inspector/styles-new-API.html:

2010-11-17 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] editing disabled styles breaks style bodies.
https://bugs.webkit.org/show_bug.cgi?id=49602

  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::setPropertyText):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.get name): (WebInspector.StylePropertyTreeElement.prototype.get priority): (WebInspector.StylePropertyTreeElement.prototype.get value):
2:02 AM Changeset in webkit [72181] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-11-17 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Dimitri Glazkov.

Fix click count for mouse-up events.

  • clickCount for mouse up was lost in conversion from NSEvent
  • clickCount was also lost when disptaching events through the plugin mouse capture event codepath.

https://bugs.webkit.org/show_bug.cgi?id=49290

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent):
  • src/mac/WebInputEventFactory.mm: (WebKit::WebInputEventFactory::mouseEvent):
1:42 AM Changeset in webkit [72180] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-11-17 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Collect the beginning characters in a RegExp pattern for look-up
optimization
https://bugs.webkit.org/show_bug.cgi?id=45748

Extend the YARR's parser with an algorithm which collects the potential
beginning characters from a RegExp pattern for later look-up optimization.

  • yarr/RegexCompiler.cpp: (JSC::Yarr::BeginCharHelper::BeginCharHelper): (JSC::Yarr::BeginCharHelper::addBeginChar): (JSC::Yarr::BeginCharHelper::merge): (JSC::Yarr::BeginCharHelper::addCharacter): (JSC::Yarr::BeginCharHelper::linkHotTerms): (JSC::Yarr::RegexPatternConstructor::RegexPatternConstructor): (JSC::Yarr::RegexPatternConstructor::addBeginTerm): (JSC::Yarr::RegexPatternConstructor::setupDisjunctionBeginTerms): (JSC::Yarr::RegexPatternConstructor::setupAlternativeBeginTerms): (JSC::Yarr::RegexPatternConstructor::setupBeginChars): (JSC::Yarr::compileRegex):
  • yarr/RegexPattern.h: (JSC::Yarr::TermChain::TermChain): (JSC::Yarr::BeginChar::BeginChar): (JSC::Yarr::RegexPattern::RegexPattern): (JSC::Yarr::RegexPattern::reset):
1:24 AM Changeset in webkit [72179] by aestes@apple.com
  • 3 edits in trunk/LayoutTests

Two more tests needing new results after r72173.

  • platform/mac/editing/selection/caret-rtl-expected.txt:
  • platform/mac/transforms/2d/hindi-rotated-expected.txt:
12:45 AM Changeset in webkit [72178] by aestes@apple.com
  • 5 edits in trunk/LayoutTests

More results needing new results after r72173.

  • platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/mac/fast/text/backslash-to-yen-sign-expected.txt:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
12:37 AM Changeset in webkit [72177] by aestes@apple.com
  • 10 edits in trunk/LayoutTests

The following results needed new results after r72173.

  • editing/selection/extend-selection-bidi-expected.txt:
  • platform/mac/editing/deleting/5144139-2-expected.checksum:
  • platform/mac/editing/deleting/5144139-2-expected.png:
  • platform/mac/editing/deleting/5144139-2-expected.txt:
  • platform/mac/editing/selection/caret-rtl-2-expected.checksum:
  • platform/mac/editing/selection/caret-rtl-2-expected.png:
  • platform/mac/editing/selection/caret-rtl-2-expected.txt:
  • platform/mac/editing/selection/extend-selection-bidi-expected.checksum:
  • platform/mac/editing/selection/extend-selection-bidi-expected.png:
12:05 AM Changeset in webkit [72176] by commit-queue@webkit.org
  • 21 edits in trunk/JavaScriptCore

2010-11-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72160.
http://trac.webkit.org/changeset/72160
https://bugs.webkit.org/show_bug.cgi?id=49646

Broke lots of fast/profiler tests, among others (Requested by
aroben on #webkit).

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::functionRegisterForBytecodeOffset): (JSC::CodeBlock::shrinkToFit):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::addFunctionRegisterInfo):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitCall): (JSC::BytecodeGenerator::emitCallVarargs): (JSC::BytecodeGenerator::emitReturn): (JSC::BytecodeGenerator::emitConstruct):
  • bytecompiler/BytecodeGenerator.h: (JSC::CallArguments::profileHookRegister):
  • bytecompiler/NodesCodegen.cpp: (JSC::CallArguments::CallArguments):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::throwException): (JSC::Interpreter::execute): (JSC::Interpreter::executeCall): (JSC::Interpreter::executeConstruct): (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_profile_will_call): (JSC::JIT::emit_op_profile_did_call):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_profile_will_call): (JSC::JIT::emit_op_profile_did_call):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h:
  • profiler/Profile.cpp: (JSC::Profile::Profile):
  • profiler/ProfileGenerator.cpp: (JSC::ProfileGenerator::addParentForConsoleStart): (JSC::ProfileGenerator::willExecute): (JSC::ProfileGenerator::didExecute): (JSC::ProfileGenerator::stopProfiling):
  • profiler/ProfileGenerator.h:
  • profiler/ProfileNode.cpp: (JSC::ProfileNode::ProfileNode): (JSC::ProfileNode::willExecute):
  • profiler/ProfileNode.h: (JSC::ProfileNode::create): (JSC::ProfileNode::operator==):
  • profiler/Profiler.cpp: (JSC::dispatchFunctionToProfiles): (JSC::Profiler::willExecute): (JSC::Profiler::didExecute):
  • profiler/Profiler.h:

Nov 16, 2010:

11:43 PM Changeset in webkit [72175] by Adam Roben
  • 3 edits in trunk/WebKitLibraries

Ignore files from libdispatch/zlib

Rubber-stamped by Eric Seidel.

  • win/include: Modified property svn:ignore.
  • win/lib: Modified property svn:ignore.
11:24 PM Changeset in webkit [72174] by Adam Roben
  • 2 edits
    1 add in trunk/WebCore

Move QTMovieWin's settings into a vsprops file

Fixes <http://webkit.org/b/49644> QTMovieWin should use a vsprops file

Reviewed by Steve Falkenburg.

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/QTMovieWinCommon.vsprops: Added.
10:45 PM Changeset in webkit [72173] by aestes@apple.com
  • 282 edits
    4 adds in trunk

WebKit mishandles line boxes where the content height exceeds the
specified line-height.
https://bugs.webkit.org/show_bug.cgi?id=49410

Reviewed by Dave Hyatt.

WebCore:

If a line height is explicitly specified on a text box and fallback
fonts are in use, only the primary font should be considered when
computing the box's ascent and descent. This prevents the inline box
from being sized larger than the specified line height.

This patch also fixes a math error when computing a used font's descent
in the case where line height isn't explicitly set. This change results
in a number of layout tests needing re-baselining.

Test: fast/css/line-height-determined-by-primary-font.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):

LayoutTests:

  • fast/css/line-height-determined-by-primary-font.html: Added.
  • platform/mac/fast/css/line-height-determined-by-primary-font-expected.checksum: Added.
  • platform/mac/fast/css/line-height-determined-by-primary-font-expected.png: Added.
  • platform/mac/fast/css/line-height-determined-by-primary-font-expected.txt: Added.

The following test results were re-baselined:

  • platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum:
  • platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
  • platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.checksum:
  • platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.png:
  • platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.checksum:
  • platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.png:
  • platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
  • platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.checksum:
  • platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.png:
  • platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.checksum:
  • platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png:
  • platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-02-c-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-02-c-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-02-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-03-c-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-03-c-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-03-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-04-c-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-04-c-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-04-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.txt:
  • platform/mac/css2.1/t090501-c414-flt-01-b-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-01-b-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-01-b-expected.txt:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt:
  • platform/mac/css2.1/t1202-counter-03-b-expected.checksum:
  • platform/mac/css2.1/t1202-counter-03-b-expected.png:
  • platform/mac/css2.1/t1202-counter-03-b-expected.txt:
  • platform/mac/css2.1/t1202-counter-04-b-expected.checksum:
  • platform/mac/css2.1/t1202-counter-04-b-expected.png:
  • platform/mac/css2.1/t1202-counter-04-b-expected.txt:
  • platform/mac/css2.1/t1202-counter-09-b-expected.checksum:
  • platform/mac/css2.1/t1202-counter-09-b-expected.png:
  • platform/mac/css2.1/t1202-counter-09-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-03-b-expected.checksum:
  • platform/mac/css2.1/t1202-counters-03-b-expected.png:
  • platform/mac/css2.1/t1202-counters-03-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-04-b-expected.checksum:
  • platform/mac/css2.1/t1202-counters-04-b-expected.png:
  • platform/mac/css2.1/t1202-counters-04-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-09-b-expected.checksum:
  • platform/mac/css2.1/t1202-counters-09-b-expected.png:
  • platform/mac/css2.1/t1202-counters-09-b-expected.txt:
  • platform/mac/fast/blockflow/vertical-font-fallback-expected.checksum:
  • platform/mac/fast/blockflow/vertical-font-fallback-expected.png:
  • platform/mac/fast/blockflow/vertical-font-fallback-expected.txt:
  • platform/mac/fast/css/beforeSelectorOnCodeElement-expected.checksum:
  • platform/mac/fast/css/beforeSelectorOnCodeElement-expected.png:
  • platform/mac/fast/css/beforeSelectorOnCodeElement-expected.txt:
  • platform/mac/fast/css/font-face-opentype-expected.checksum:
  • platform/mac/fast/css/font-face-opentype-expected.png:
  • platform/mac/fast/css/font-face-opentype-expected.txt:
  • platform/mac/fast/css/rtl-ordering-expected.checksum:
  • platform/mac/fast/css/rtl-ordering-expected.png:
  • platform/mac/fast/css/rtl-ordering-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.checksum:
  • platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.png:
  • platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.checksum:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.png:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-strict-expected.checksum:
  • platform/mac/fast/css/text-overflow-ellipsis-strict-expected.png:
  • platform/mac/fast/css/text-overflow-ellipsis-strict-expected.txt:
  • platform/mac/fast/css/text-security-expected.checksum:
  • platform/mac/fast/css/text-security-expected.png:
  • platform/mac/fast/css/text-security-expected.txt:
  • platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.checksum:
  • platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
  • platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
  • platform/mac/fast/encoding/invalid-UTF-8-expected.checksum:
  • platform/mac/fast/encoding/invalid-UTF-8-expected.png:
  • platform/mac/fast/encoding/invalid-UTF-8-expected.txt:
  • platform/mac/fast/events/updateLayoutForHitTest-expected.checksum:
  • platform/mac/fast/events/updateLayoutForHitTest-expected.png:
  • platform/mac/fast/events/updateLayoutForHitTest-expected.txt:
  • platform/mac/fast/forms/select-visual-hebrew-expected.checksum:
  • platform/mac/fast/forms/select-visual-hebrew-expected.png:
  • platform/mac/fast/forms/select-visual-hebrew-expected.txt:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.checksum:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.png:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.checksum:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
  • platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • platform/mac/fast/text/atsui-multiple-renderers-expected.checksum:
  • platform/mac/fast/text/atsui-multiple-renderers-expected.png:
  • platform/mac/fast/text/atsui-multiple-renderers-expected.txt:
  • platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum:
  • platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.png:
  • platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
  • platform/mac/fast/text/capitalize-boundaries-expected.checksum:
  • platform/mac/fast/text/capitalize-boundaries-expected.png:
  • platform/mac/fast/text/capitalize-boundaries-expected.txt:
  • platform/mac/fast/text/cg-fallback-bolding-expected.checksum:
  • platform/mac/fast/text/cg-fallback-bolding-expected.png:
  • platform/mac/fast/text/cg-fallback-bolding-expected.txt:
  • platform/mac/fast/text/complex-text-opacity-expected.checksum:
  • platform/mac/fast/text/complex-text-opacity-expected.png:
  • platform/mac/fast/text/complex-text-opacity-expected.txt:
  • platform/mac/fast/text/in-rendered-text-rtl-expected.checksum:
  • platform/mac/fast/text/in-rendered-text-rtl-expected.png:
  • platform/mac/fast/text/in-rendered-text-rtl-expected.txt:
  • platform/mac/fast/text/international/001-expected.checksum:
  • platform/mac/fast/text/international/001-expected.png:
  • platform/mac/fast/text/international/001-expected.txt:
  • platform/mac/fast/text/international/002-expected.checksum:
  • platform/mac/fast/text/international/002-expected.png:
  • platform/mac/fast/text/international/002-expected.txt:
  • platform/mac/fast/text/international/003-expected.checksum:
  • platform/mac/fast/text/international/003-expected.png:
  • platform/mac/fast/text/international/003-expected.txt:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.checksum:
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.png:
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
  • platform/mac/fast/text/international/bidi-L2-run-reordering-expected.checksum:
  • platform/mac/fast/text/international/bidi-L2-run-reordering-expected.png:
  • platform/mac/fast/text/international/bidi-L2-run-reordering-expected.txt:
  • platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.checksum:
  • platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.checksum:
  • platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
  • platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/mac/fast/text/international/bidi-european-terminators-expected.checksum:
  • platform/mac/fast/text/international/bidi-european-terminators-expected.png:
  • platform/mac/fast/text/international/bidi-european-terminators-expected.txt:
  • platform/mac/fast/text/international/bidi-fallback-font-weight-expected.checksum:
  • platform/mac/fast/text/international/bidi-fallback-font-weight-expected.png:
  • platform/mac/fast/text/international/bidi-fallback-font-weight-expected.txt:
  • platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum:
  • platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • platform/mac/fast/text/international/bidi-innertext-expected.checksum:
  • platform/mac/fast/text/international/bidi-innertext-expected.png:
  • platform/mac/fast/text/international/bidi-innertext-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.txt:
  • platform/mac/fast/text/international/bidi-listbox-atsui-expected.checksum:
  • platform/mac/fast/text/international/bidi-listbox-atsui-expected.png:
  • platform/mac/fast/text/international/bidi-listbox-atsui-expected.txt:
  • platform/mac/fast/text/international/bidi-listbox-expected.checksum:
  • platform/mac/fast/text/international/bidi-listbox-expected.png:
  • platform/mac/fast/text/international/bidi-listbox-expected.txt:
  • platform/mac/fast/text/international/bidi-menulist-expected.checksum:
  • platform/mac/fast/text/international/bidi-menulist-expected.png:
  • platform/mac/fast/text/international/bidi-menulist-expected.txt:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.checksum:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.png:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/mac/fast/text/international/bidi-override-expected.checksum:
  • platform/mac/fast/text/international/bidi-override-expected.png:
  • platform/mac/fast/text/international/bidi-override-expected.txt:
  • platform/mac/fast/text/international/danda-space-expected.checksum:
  • platform/mac/fast/text/international/danda-space-expected.png:
  • platform/mac/fast/text/international/danda-space-expected.txt:
  • platform/mac/fast/text/international/hebrew-vowels-expected.checksum:
  • platform/mac/fast/text/international/hebrew-vowels-expected.png:
  • platform/mac/fast/text/international/hebrew-vowels-expected.txt:
  • platform/mac/fast/text/international/hindi-spacing-expected.checksum:
  • platform/mac/fast/text/international/hindi-spacing-expected.png:
  • platform/mac/fast/text/international/hindi-spacing-expected.txt:
  • platform/mac/fast/text/international/hindi-whitespace-expected.checksum:
  • platform/mac/fast/text/international/hindi-whitespace-expected.png:
  • platform/mac/fast/text/international/hindi-whitespace-expected.txt:
  • platform/mac/fast/text/international/plane2-expected.checksum:
  • platform/mac/fast/text/international/plane2-expected.png:
  • platform/mac/fast/text/international/plane2-expected.txt:
  • platform/mac/fast/text/international/rtl-caret-expected.checksum:
  • platform/mac/fast/text/international/rtl-caret-expected.png:
  • platform/mac/fast/text/international/rtl-caret-expected.txt:
  • platform/mac/fast/text/international/thai-baht-space-expected.checksum:
  • platform/mac/fast/text/international/thai-baht-space-expected.png:
  • platform/mac/fast/text/international/thai-baht-space-expected.txt:
  • platform/mac/fast/text/international/thai-line-breaks-expected.checksum:
  • platform/mac/fast/text/international/thai-line-breaks-expected.png:
  • platform/mac/fast/text/international/thai-line-breaks-expected.txt:
  • platform/mac/fast/text/international/wrap-CJK-001-expected.checksum:
  • platform/mac/fast/text/international/wrap-CJK-001-expected.png:
  • platform/mac/fast/text/international/wrap-CJK-001-expected.txt:
  • platform/mac/mathml/presentation/attributes-expected.checksum:
  • platform/mac/mathml/presentation/attributes-expected.png:
  • platform/mac/mathml/presentation/attributes-expected.txt:
  • platform/mac/mathml/presentation/fractions-expected.checksum:
  • platform/mac/mathml/presentation/fractions-expected.png:
  • platform/mac/mathml/presentation/fractions-expected.txt:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/mo-expected.checksum:
  • platform/mac/mathml/presentation/mo-expected.png:
  • platform/mac/mathml/presentation/mo-expected.txt:
  • platform/mac/mathml/presentation/over-expected.checksum:
  • platform/mac/mathml/presentation/over-expected.png:
  • platform/mac/mathml/presentation/over-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.checksum:
  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.checksum:
  • platform/mac/mathml/presentation/row-alignment-expected.png:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/row-expected.txt:
  • platform/mac/mathml/presentation/style-expected.txt:
  • platform/mac/mathml/presentation/sub-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.txt:
  • platform/mac/mathml/presentation/sup-expected.checksum:
  • platform/mac/mathml/presentation/sup-expected.png:
  • platform/mac/mathml/presentation/sup-expected.txt:
  • platform/mac/mathml/presentation/tables-expected.checksum:
  • platform/mac/mathml/presentation/tables-expected.png:
  • platform/mac/mathml/presentation/tables-expected.txt:
  • platform/mac/mathml/presentation/tokenElements-expected.txt:
  • platform/mac/mathml/presentation/under-expected.checksum:
  • platform/mac/mathml/presentation/under-expected.png:
  • platform/mac/mathml/presentation/under-expected.txt:
  • platform/mac/mathml/presentation/underover-expected.checksum:
  • platform/mac/mathml/presentation/underover-expected.png:
  • platform/mac/mathml/presentation/underover-expected.txt:
  • platform/mac/mathml/xHeight-expected.txt:
9:56 PM Changeset in webkit [72172] by rniwa@webkit.org
  • 5 edits in trunk/WebCore

2010-11-15 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

ScriptElementData should be a private member of ScriptElement
https://bugs.webkit.org/show_bug.cgi?id=49578

Privatized m_data of ScriptElement. Added haveFiredLoadEvent, setHaveFiredLoadEvent, createdByParser,
and isEvaluated to ScriptElement to proxy calls from HTMLScriptElement and SVGScriptElement to ScriptElementData.

No tests are added since this is a cleanup.

  • dom/ScriptElement.h: (WebCore::ScriptElement::haveFiredLoadEvent): Added. (WebCore::ScriptElement::setHaveFiredLoadEvent): Added. (WebCore::ScriptElement::createdByParser): Added. (WebCore::ScriptElement::isEvaluated): Added.
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::dispatchLoadEvent): Calls haveFiredLoadEvent and setHaveFiredLoadEvent. (WebCore::HTMLScriptElement::cloneElementWithoutAttributesAndChildren): Calls isEvaluated.
  • html/HTMLScriptElement.h: (WebCore::HTMLScriptElement::text): Calls scriptContent. (WebCore::HTMLScriptElement::haveFiredLoadEvent): Calls haveFiredLoadEvent.
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::svgAttributeChanged): Calls haveFiredLoadEvent and createdByParser. (WebCore::SVGScriptElement::insertedIntoDocument): Calls createdByParser. (WebCore::SVGScriptElement::finishParsingChildren): Calls setHaveFiredLoadEvent. (WebCore::SVGScriptElement::haveLoadedRequiredResources): Ditto. (WebCore::SVGScriptElement::dispatchLoadEvent): Calls haveFiredLoadEvent. (WebCore::SVGScriptElement::cloneElementWithoutAttributesAndChildren): Calls createdByParser, haveFiredLoadEvent, and setHaveFiredLoadEvent.
8:52 PM Changeset in webkit [72171] by Antti Koivisto
  • 3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=49320
Minor ResourceLoadScheduler cleanups

Reviewed by Darin Adler.

  • loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::scheduleLoad):
(WebCore::ResourceLoadScheduler::servePendingRequests):
(WebCore::ResourceLoadScheduler::HostInformation::~HostInformation):
(WebCore::ResourceLoadScheduler::HostInformation::remove):
(WebCore::ResourceLoadScheduler::HostInformation::hasRequests):

  • loader/ResourceLoadScheduler.h:
8:27 PM Changeset in webkit [72170] by inferno@chromium.org
  • 4 edits in branches/chromium/552/LayoutTests

Merge 72166

BUG=63389

8:24 PM Changeset in webkit [72169] by inferno@chromium.org
  • 1 edit in branches/chromium/552/WebCore/css/CSSPrimitiveValue.cpp

Merge 72163

BUG=63389

8:13 PM Changeset in webkit [72168] by hyatt@apple.com
  • 5 edits in trunk/WebCore

Add a baselineType member to RootInlineBox that caches whether the default baseline behavior for that
line should be ideographic or alphabetic. Add a requiresIdeographicsBaseline recursive function to
InlineFlowBox that scans for the use of any vertical fonts.

Reviewed by Sam Weinig.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::requiresIdeographicBaseline):

  • rendering/InlineFlowBox.h:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::alignBoxesInBlockDirection):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::baselineType):

7:35 PM Changeset in webkit [72167] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Update WebKit2 skipped list.

Rubber-stamped by Jon Honeycutt.

  • platform/mac-wk2/Skipped:
7:24 PM Changeset in webkit [72166] by Antti Koivisto
  • 5 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=31223
Make primitive values immutable.

Patch by Antti Koivisto <koivisto@iki.fi> on 2010-11-16
Reviewed by Adam Barth.

Update test cases for behavior change and test computed style too. Note that there are some
failures in the results demonstrating unrelated bugs in CSSPrimitiveValues.

  • fast/dom/script-tests/setPrimitiveValue-exceptions.js:

(checkThrows):

  • fast/dom/setPrimitiveValue.html:
  • fast/dom/setPrimitiveValue-exceptions-expected.txt
  • fast/dom/setPrimitiveValue-expected.txt
7:24 PM Changeset in webkit [72165] by hyatt@apple.com
  • 4 edits
    1 add in trunk/WebCore

Add FontBaseline.h and make ascent and descent take a baseline parameter so that both an
alphabetic and ideographic baseline can be requested.

Reviewed by Sam Weinig.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/Font.h:

(WebCore::Font::ascent):
(WebCore::Font::descent):

  • platform/graphics/FontBaseline.h: Added.
  • platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::ascent):
(WebCore::SimpleFontData::descent):
(WebCore::SimpleFontData::height):

7:20 PM Changeset in webkit [72164] by hyatt@apple.com
  • 2 edits in trunk/WebKitTools

Make sure the pref for minimum font size is just explicitly set to 0 every time,
since the bots have 1 stuck in their plist otherwise.

Reviewed by Sam Weinig.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

7:15 PM Changeset in webkit [72163] by Antti Koivisto
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=31223
Make primitive values immutable.

Patch by Antti Koivisto <koivisto@iki.fi> on 2010-11-16
Reviewed by Adam Barth.

Make CSSPrimitiveValue setFloatValue and setStringValue always throw NO_MODIFICATION_ALLOWED exception.

Reasoning:

  • these setters never worked correctly, style was not invalidated so changing values would have no effect on rendering
  • computed style is immutable in all cases, and it wasn't
  • no other engine seems to support mutable primitives, as a result there is no content using these APIs
  • mutable primitive values are pointless, the usual way to change the value of a propertly is to replace it with a new value
  • allowing mutation of primitive values makes optimizations harder
  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::setFloatValue):
(WebCore::CSSPrimitiveValue::setStringValue):

7:13 PM Changeset in webkit [72162] by weinig@apple.com
  • 12 edits
    1 delete in trunk/WebKit2

WebKit2: Support enabling site-specific quirks
<rdar://problem/8451371>
https://bugs.webkit.org/show_bug.cgi?id=46076

Reviewed by Adam Roben.

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):

  • Shared/WebPreferencesStore.h:

Add needsSiteSpecificQuirks;

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toFontSmoothingLevel):
(WebKit::toAPI):
Move FontSmoothing conversion functions here.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetFontSmoothingLevel):
(WKPreferencesGetFontSmoothingLevel):
(WKPreferencesSetAcceleratedCompositingEnabled):
(WKPreferencesGetAcceleratedCompositingEnabled):
(WKPreferencesSetCompositingBordersVisible):
(WKPreferencesGetCompositingBordersVisible):
(WKPreferencesSetCompositingRepaintCountersVisible):
(WKPreferencesGetCompositingRepaintCountersVisible):
(WKPreferencesSetNeedsSiteSpecificQuirks):
(WKPreferencesGetNeedsSiteSpecificQuirks):
Add WKPreferencesSetNeedsSiteSpecificQuirks/WKPreferencesGetNeedsSiteSpecificQuirks
and move implementations from WKPreferencesPrivate.cpp here.

  • UIProcess/API/C/WKPreferencesPrivate.cpp: Removed.
  • UIProcess/API/C/WKPreferencesPrivate.h:

Add Add WKPreferencesSetNeedsSiteSpecificQuirks/WKPreferencesGetNeedsSiteSpecificQuirks.

  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::setNeedsSiteSpecificQuirks):
(WebKit::WebPreferences::needsSiteSpecificQuirks):

  • UIProcess/WebPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Pipe through needsSiteSpecificQuirks.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebKit2.pro:
  • win/WebKit2.vcproj:

Update for removed files.

7:11 PM Changeset in webkit [72161] by hyatt@apple.com
  • 3 edits in trunk/LayoutTests/platform/mac/svg/batik/text

Update SVG layout test.

7:03 PM Changeset in webkit [72160] by barraclough@apple.com
  • 21 edits in trunk/JavaScriptCore

Bug 49635 - Profiler implementation is fragile

Reviewed by Sam Weinig.

The profile presently requires the exception handling mechanism to explicitly
remove all stack frames that are exited during the exception unwind mechanism.
This is fragile in a number of ways:

  • We have to change bytecode register allocation when compiling code to run when profiling, to preserve the callee function (this is also required to call did_call after the call has returned).
  • In the JIT we have to maintain additional data structures (CodeBlock::RareData::m_functionRegisterInfos) to map back to the register containing the callee.
  • In the interpreter we use 'magic values' to offset into the instruction stream to rediscover the register containing the function.

Instead, move profiling into the head and tail of functions.

  • This correctly accounts the cost of the call itself to the caller.
  • This allows us to access the callee function object from the callframe.
  • This means that at the point a call is made we can track the stack depth on the ProfileNode.
  • When unwinding we can simply report the depth at which the exception is being handled - all call frames above this level are freed.

(JSC::CodeBlock::dump):
(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::methodCallLinkInfo):

  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitReturn):
(JSC::BytecodeGenerator::emitConstruct):

  • bytecompiler/BytecodeGenerator.h:

(JSC::CallArguments::count):

  • bytecompiler/NodesCodegen.cpp:

(JSC::CallArguments::CallArguments):

  • interpreter/Interpreter.cpp:

(JSC::ProfileHostCall::ProfileHostCall):
(JSC::ProfileHostCall::~ProfileHostCall):
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_profile_has_called):
(JSC::JIT::emit_op_profile_will_return):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_profile_has_called):
(JSC::JIT::emit_op_profile_will_return):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:
  • profiler/Profile.cpp:

(JSC::Profile::Profile):

  • profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::addParentForConsoleStart):
(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):
(JSC::ProfileGenerator::exceptionUnwind):
(JSC::ProfileGenerator::stopProfiling):

  • profiler/ProfileGenerator.h:
  • profiler/ProfileNode.cpp:

(JSC::ProfileNode::ProfileNode):
(JSC::ProfileNode::willExecute):

  • profiler/ProfileNode.h:

(JSC::ProfileNode::create):
(JSC::ProfileNode::operator==):
(JSC::ProfileNode::exec):

  • profiler/Profiler.cpp:

(JSC::dispatchFunctionToProfiles):
(JSC::Profiler::hasCalled):
(JSC::Profiler::willEvaluate):
(JSC::Profiler::willReturn):
(JSC::Profiler::didEvaluate):
(JSC::Profiler::exceptionUnwind):

  • profiler/Profiler.h:
6:58 PM Changeset in webkit [72159] by bweinstein@apple.com
  • 2 edits in trunk/JavaScriptCore

Touch Platform.h to force a rebuild for Windows.

Reviewed by Adam Roben and Steve Falkenburg.

  • wtf/Platform.h:
6:39 PM Changeset in webkit [72158] by sfalken@apple.com
  • 5 edits in trunk

Force a clean build for Windows projects using precompiled headers. Unreviewed.

6:37 PM Changeset in webkit [72157] by mihaip@chromium.org
  • 5 edits
    1 copy in trunk/WebKitTools

2010-11-16 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

Rebaseline server: display test results
https://bugs.webkit.org/show_bug.cgi?id=49626

Adds basic result display to the rebaseline server. On the Python side
this involves:

  • Parsing the unexpected_results.json into a dictionary.
  • Serving it as JSON under /results.json. (the JSON -> dict -> JSON transform isn't strictly necessary right now, but I'll need to have access to the parsed results on the Python side for follow-up changes).

On the web UI side this adds:

  • Markup for display image and text results (expected, actual, diff), and JS for populating it.
  • Markup for breaking down test results by failure type and directory, and JS for populating it.
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
6:24 PM Changeset in webkit [72156] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-11-16 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

See Chromium issue http://codereview.chromium.org/5133001/ - we
are modifying the build bots to pass in the builder name with
the "GPU" string appended instead of appending it in the code.

https://bugs.webkit.org/show_bug.cgi?id=49636

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
6:21 PM Changeset in webkit [72155] by Adam Roben
  • 2 edits in trunk/WebKit2

Fix horizontal scrolling via the mousewheel/trackpad on Windows

Reviewed by Mark Rowe.

  • Shared/win/WebEventFactory.cpp: Fixed typo in the

WM_VISTA_MOUSEHWHEEL constant.

6:20 PM Changeset in webkit [72154] by mihaip@chromium.org
  • 245 edits
    244 copies
    5 adds in trunk/LayoutTests

2010-11-16 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/reflections, fast/replaced, fast/ruby, fast/runin, and fast/text for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

5:49 PM Changeset in webkit [72153] by mihaip@chromium.org
  • 206 edits
    189 copies
    5 adds in trunk/LayoutTests

2010-11-16 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/html, fast/images, fast/innerHTML, fast/inspector-support, fast/loader, fast/media, fast/multicol, and fast/parser for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

Also includes updated baselines for fast/forms after r72052 changed how
placeholders are rendered.

5:03 PM Changeset in webkit [72152] by sfalken@apple.com
  • 33 edits in trunk

2010-11-16 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
https://bugs.webkit.org/show_bug.cgi?id=49632

2010-11-16 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
https://bugs.webkit.org/show_bug.cgi?id=49632

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.make:
  • WebKit.vcproj/WebKit.sln:
  • WebKit.vcproj/WebKit.submit.sln:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:

2010-11-16 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
https://bugs.webkit.org/show_bug.cgi?id=49632

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCore.make:
  • WebCore.vcproj/WebCore.sln:
  • WebCore.vcproj/WebCore.vcproj:

2010-11-16 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
https://bugs.webkit.org/show_bug.cgi?id=49632

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
  • MiniBrowser/MiniBrowser.vcproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • WebKitLauncherWin/WebKitLauncherWin.vcproj:
  • WebKitTestRunner/win/InjectedBundle.vcproj:
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:
  • WinLauncher/WinLauncher.vcproj:
  • record-memory-win/record-memory-win.vcproj:

2010-11-16 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
https://bugs.webkit.org/show_bug.cgi?id=49632

  • win/WebKit2.make:
  • win/WebKit2.submit.sln:
  • win/WebKit2.vcproj:
  • win/WebKit2WebProcess.vcproj:
5:02 PM Changeset in webkit [72151] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

4:49 PM Changeset in webkit [72150] by mrowe@apple.com
  • 1 copy in tags/Safari-534.12

New tag.

4:36 PM Changeset in webkit [72149] by dpranke@chromium.org
  • 4 edits in trunk/WebKitTools

2010-11-16 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread

Rename the TestInfo class to TestInput to be clearer about its
function, and move the checksum-reading code into dump_render_tree_thread
to avoid cross-thread access.

https://bugs.webkit.org/show_bug.cgi?id=49573

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4:19 PM Changeset in webkit [72148] by andersca@apple.com
  • 10 edits in trunk/WebKit2

Handle converting a ResourceHandle to a download
https://bugs.webkit.org/show_bug.cgi?id=49631

Reviewed by Sam Weinig.

  • WebProcess/Downloads/Download.h:

Add startWithHandle.

  • WebProcess/Downloads/DownloadManager.h:
  • WebProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::convertHandleToDownload):
Create a new Download object and call startWithHandle on it.

  • WebProcess/Downloads/cf/DownloadCFNet.cpp:

(WebKit::Download::startWithHandle):
Add stub.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::Download::startWithHandle):
Create an NSURLDownload object from passed in ResourceHandle.

  • WebProcess/Downloads/qt/DownloadQt.cpp:

(WebKit::Download::startWithHandle):
Add stub.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::download):
Call WebFrame::convertHandleToDownload.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::convertHandleToDownload):
Call DownloadManager::convertHandleToDownload.

4:18 PM Changeset in webkit [72147] by hyatt@apple.com
  • 2 edits in trunk/WebKitTools

Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

3:54 PM Changeset in webkit [72146] by Stephanie Lewis
  • 6 edits in trunk

<rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests

Reviewed by Geoff Garen.

WebKit/mac:

Make a static provider for WebDeviceOrientationProviderMock. The old code allocated a new WebDeviceOrientationProviderMock for
every WebView, and the WebKit API doesn't support that ownership model.

  • WebView/WebDeviceOrientationProviderMock.h:
  • WebView/WebDeviceOrientationProviderMock.mm:

(+[WebDeviceOrientationProviderMock shared]):

WebKitTools:

Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock
for every WebView, and the WebKit API doesn't support that ownership model.

I also fixed a leak in setMockDeviceOrientation by adding a missing release.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setMockDeviceOrientation):

3:52 PM Changeset in webkit [72145] by andersca@apple.com
  • 10 edits in trunk

Set the original URL for downloads
https://bugs.webkit.org/show_bug.cgi?id=49628

Reviewed by John Sullivan.

WebCore:

Export symbols needed by WebKit2.

  • WebCore.exp.in:

WebKit2:

  • WebProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::startDownload):

  • WebProcess/Downloads/DownloadManager.h:

startDownload now takes the originating web page.

  • WebProcess/Downloads/cf/DownloadCFNet.cpp:

(WebKit::Download::start):
start now takes the originating web page.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::originatingURL):
(WebKit::setOriginalURLForDownload):
Port code over from WebKit1 that sets the download URL.

(WebKit::Download::start):
Call setOriginalURLForDownload.

  • WebProcess/Downloads/qt/DownloadQt.cpp:

(WebKit::Download::start):
start now takes the originating web page.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::startDownload):
Pass the web page to DownloadManager::startDownload.

3:44 PM Changeset in webkit [72144] by hamaji@chromium.org
  • 5 edits
    1 copy in branches/chromium/552/WebCore

Merge 71892 - 2010-11-11 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

REGRESSION: window.print in onload doesn't fire if there's an img
https://bugs.webkit.org/show_bug.cgi?id=48195

This issue was introduced in
https://bugs.webkit.org/show_bug.cgi?id=43658
This happens because FrameLoader::isLoading() is false while an
image is still loading. Now, window.print() happens after all
resources are loaded.

Also changed the name of a member variable as Darin suggested in Bug 43658.

Added a manual test as DRT doesn't support window.print() yet.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::updateLoading):
  • loader/DocumentLoader.h:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::DOMWindow): (WebCore::DOMWindow::print): (WebCore::DOMWindow::finishedLoading):
  • page/DOMWindow.h:

TBR=hamaji@chromium.org

3:32 PM Changeset in webkit [72143] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-11-16 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: log the process id in --verbose mode

As part of the switch to multi-process mode, we should log the
process id when running w/ --verbose.

https://bugs.webkit.org/show_bug.cgi?id=49571

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
3:29 PM Changeset in webkit [72142] by inferno@chromium.org
  • 3 edits in branches/chromium/552

Merge 72046

BUG=63268

3:28 PM Changeset in webkit [72141] by hyatt@apple.com
  • 26 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=11004

Reviewed by Dan Bernstein.

font-size:0 is ignored. Remove the minimum font size of 1 in CSSStyleSelector.
Change the pref value for minimum font size from 1 to 0. Make sure to never use the NSFont's size,
since it doesn't honor a size of 0. Instead pass the size in to the FontPlatformData(NSFont*) version
of the constructor rather than using [NSFont pointSize].

https://bugs.webkit.org/show_bug.cgi?id=49582

Negative leading is not handled correctly. There are two bugs here. The first is that
maxAscent and maxDescent can be negative, so we need a notion of whether or not we have
set them before so that we can allow them to be < 0.

The second issue is that we should understand where fonts will end up relative to
our baseline (excluding line height), and only allow those boxes to impact ascent and
descent if the actual font box (without factoring in line height) is above or below the
root line box baseline.

Added fast/css/negative-leading.html

These two bug fixes have to land together to keep the Acid 3 test rendering correctly.

WebCore:

  • WebCore.exp.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):

  • platform/graphics/cocoa/FontPlatformData.h:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::smallCapsFontData):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):

  • rendering/InlineFlowBox.h:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):

WebKit/mac:

  • Misc/WebKitNSStringExtras.mm:

(-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
(-[NSString _web_widthWithFont:]):

  • Misc/WebStringTruncator.mm:

(fontFromNSFont):

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

WebKit/win:

  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):

WebKit2:

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::WebPreferencesStore):

LayoutTests:

  • fast/css/negative-leading.html: Added.
  • platform/mac/fast/compact/001-expected.checksum:
  • platform/mac/fast/compact/001-expected.png:
  • platform/mac/fast/compact/001-expected.txt:
  • platform/mac/fast/css/negative-leading-expected.checksum: Added.
  • platform/mac/fast/css/negative-leading-expected.png: Added.
  • platform/mac/fast/css/negative-leading-expected.txt: Added.
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
  • platform/mac/fast/parser/style-script-head-test-expected.png:
3:27 PM Changeset in webkit [72140] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-11-16 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

The number of recursive match calls isn't limited in YARR Interpreter
https://bugs.webkit.org/show_bug.cgi?id=47906

Check the number of the matchDisjunction recursive calls to avoid unbounded
recursion.
Now the matchDisjunction function returns JSRegExpResult instead of bool.
The JSRegExpResult enum contains the result of matching or the error code
of the failure (like HitLimit) which terminates the matching.
The error codes are based on pcre's jsRegExpExecute error codes.

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::parenthesesDoBacktrack): (JSC::Yarr::Interpreter::matchParentheses): (JSC::Yarr::Interpreter::backtrackParentheses): (JSC::Yarr::Interpreter::matchDisjunction): (JSC::Yarr::Interpreter::matchNonZeroDisjunction): (JSC::Yarr::Interpreter::interpret): (JSC::Yarr::Interpreter::Interpreter):
  • yarr/RegexInterpreter.h:
3:23 PM Changeset in webkit [72139] by inferno@chromium.org
  • 3 edits
    2 copies in branches/chromium/552

Merge 72135

BUG=63031

2:55 PM Changeset in webkit [72138] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Removed lines for tests that are now passing after r72137.

  • platform/chromium/test_expectations.txt:
2:51 PM Changeset in webkit [72137] by Darin Adler
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=49611
REGRESSION (r72115): 5 layout tests are broken

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadFrameRequest): Roll change from
https://bugs.webkit.org/show_bug.cgi?id=48603 out. I'll roll
it back in after fixing the failing tests.

2:43 PM Changeset in webkit [72136] by sfalken@apple.com
  • 3 edits
    2 adds in trunk/WebKit/win

2010-11-16 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Use vsprops files for common settings in Windows WebKit
https://bugs.webkit.org/show_bug.cgi?id=49622

  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitCommon.vsprops: Added.
2:08 PM Changeset in webkit [72135] by mitz@apple.com
  • 5 edits
    1 move
    2 adds in trunk

<rdar://problem/8672000> REGRESSION (r72040): Error image with alt text can cause style to be frozen in a subtree
https://bugs.webkit.org/show_bug.cgi?id=49579

Reviewed by Simon Fraser.

WebCore:

r72040 introduced a call to setNeedsStyleRecalc() from RenderImage::imageChanged(). When imageChanged()
got called beneath recalcStyle() on some ancestor element, the result was that the ancestor’s
childNeedsStyleRecalc flag got cleared, but its descendants all the way down to the image did not.
Thereafter, setNeedsStyleRecalc() would fail to propagate from that subtree up to the root. The fix
is to avoid the newly-added setNeedsStyleRecalc() in most cases, including during reclacStyle(), and
just keep it for when it is needed.

Tests: fast/block/float/015.html

fast/images/style-access-during-imageChanged-style-freeze.html

  • dom/Document.cpp:

(WebCore::Document::isPendingStyleRecalc): Added.

  • dom/Document.h:
  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageChanged): Only defer intrinsic size compoutation if a style recalc
is coming (indicating that current style() is stale).

LayoutTests:

  • fast/block/float/015.html: Copied from LayoutTests/fast/block/float/015.html-disabled.
  • fast/block/float/015.html-disabled: Removed.
  • fast/images/style-access-during-imageChanged-style-freeze-expected.txt: Added.
  • fast/images/style-access-during-imageChanged-style-freeze.html: Added.
1:56 PM Changeset in webkit [72134] by bweinstein@apple.com
  • 2 edits in trunk/JavaScriptCore

Rest of the Windows build fix.

1:52 PM WinCE edited by Patrick Gansterer
(diff)
1:44 PM Changeset in webkit [72133] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed Chromium expectations update.

  • platform/chromium/test_expectations.txt: Added the failure expectations for 5 tests which are failing due to r72115 (and filed bug 49620 about the issue).
1:41 PM Changeset in webkit [72132] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix pt 1.

1:30 PM Changeset in webkit [72131] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Fix clang++ build.

  • Scripts/webkit2/messages.py:
  • WebProcess/WebPage/WebInspector.h:
1:23 PM Changeset in webkit [72130] by zmo@google.com
  • 31 edits in trunk

2010-11-11 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=47196

  • src/WebImageDecoder.cpp: (WebKit::WebImageDecoder::init): Add ignoreGammaAndColorProfile parameter.

2010-11-11 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=47196

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::texImage2DImpl): Apply UNPACK_COLORSPACE_CONVERSION settings to image uploading. (WebCore::WebGLRenderingContext::texSubImage2DImpl): Ditto.
  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::extractImageData): Ditto.
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/ImageSource.cpp: (WebCore::ImageSource::ImageSource): Add ignoreGammaColorProfile parameter. (WebCore::ImageSource::setData): Ditto.
  • platform/graphics/ImageSource.h:
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData): Ditto.
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::ImageSource): Ditto.
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getImageData): Ditto.
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoder::create): Ditto. (WebCore::ImageDecoderQt::ImageDecoderQt): Ditto.
  • platform/graphics/qt/ImageDecoderQt.h:
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData): Ditto.
  • platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageDecoder::create): Ditto.
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::ImageDecoder): Ditto.
  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::BMPImageDecoder):
  • platform/image-decoders/bmp/BMPImageDecoder.h:
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::GIFImageDecoder): Ditto.
  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): Ditto. (WebCore::ICOImageDecoder::decodeAtIndex): Ditto.
  • platform/image-decoders/ico/ICOImageDecoder.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::JPEGImageDecoder): Ditto.
  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::PNGImageDecoder): Ditto. (WebCore::PNGImageDecoder::headerAvailable): Ignore gamma settings if ignoreGammaAndColorProfile is true.
  • platform/image-decoders/png/PNGImageDecoder.h:
  • platform/image-decoders/webp/WEBPImageDecoder.cpp: (WebCore::WEBPImageDecoder::WEBPImageDecoder): Add ignoreGammaAndColorProfile parameter.
  • platform/image-decoders/webp/WEBPImageDecoder.h:

2010-11-11 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=47196

  • fast/canvas/webgl/gl-teximage-expected.txt:
  • fast/canvas/webgl/gl-teximage.html: Testing that if UNPACK_COLORSPACE_CONVERSION is NONE, gamma settings are not applied to images.
1:15 PM Changeset in webkit [72129] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fix clang++ build.

  • WebCoreSupport/WebFrameLoaderClient.mm:
1:12 PM Changeset in webkit [72128] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2010-11-16 Eric Carlson <eric.carlson@apple.com>

Unreviewed attempt to fix GTK build after http://trac.webkit.org/changeset/72117

  • platform/graphics/MediaPlayer.cpp: (WebCore::installedMediaEngines):
1:11 PM Changeset in webkit [72127] by barraclough@apple.com
  • 26 edits
    3 copies in trunk

JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=49606

Reviewed by Oliver Hunt.

The bug here is that we read the prototype from the RHS argument using a regular
op_get_by_id before op_instanceof has checked that this is an object implementing
HasInstance. This incorrect behaviour gives rise to further unnecessary complexity
in the code base, since we have additional logic (implemented using the
GetByIdExceptionInfo data structures on CodeBlock) to convert not an object errors
from the get_by_id into invalid parameter errors. Having fixed this bug this code
is all redundant, since in these cases the get_by_id will never have been reached.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addExpressionInfo):

  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCheckHasInstance):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::InstanceOfNode::emitBytecode):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_check_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_check_has_instance):
(JSC::JIT::emitSlow_op_instanceof):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_check_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_check_has_instance):
(JSC::JIT::emitSlow_op_instanceof):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:
  • runtime/ExceptionHelpers.cpp:

(JSC::createInterruptedExecutionException):
(JSC::createTerminatedExecutionException):
(JSC::createUndefinedVariableError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):

  • runtime/ExceptionHelpers.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:
  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::toPrimitive):
(JSC::JSNotAnObject::getPrimitiveNumber):
(JSC::JSNotAnObject::toBoolean):
(JSC::JSNotAnObject::toNumber):
(JSC::JSNotAnObject::toString):
(JSC::JSNotAnObject::toObject):
(JSC::JSNotAnObject::getOwnPropertySlot):
(JSC::JSNotAnObject::getOwnPropertyDescriptor):
(JSC::JSNotAnObject::put):
(JSC::JSNotAnObject::deleteProperty):
(JSC::JSNotAnObject::getOwnPropertyNames):

  • runtime/JSNotAnObject.h:

(JSC::JSNotAnObject::JSNotAnObject):

  • runtime/JSObject.h:

(JSC::JSObject::isActivationObject):

  • runtime/JSValue.cpp:

(JSC::JSValue::toObjectSlowCase):
(JSC::JSValue::synthesizeObject):
(JSC::JSValue::synthesizePrototype):

LayoutTests: Bug 49606 - instanceof should only get the prototype property if the RHS operand implements HasInstance

Reviewed by Oliver Hunt.

  • fast/js/instanceof-XMLHttpRequest-expected.txt: Copied from LayoutTests/fast/js/instanceof-operator-expected.txt.
  • fast/js/instanceof-XMLHttpRequest.html: Copied from LayoutTests/fast/js/instanceof-operator.html.
  • fast/js/script-tests/instanceof-XMLHttpRequest.js: Copied from LayoutTests/fast/js/script-tests/instanceof-operator.js.
    • renamed existing testcase; these really test XMLHttpRequest objects, rather than the instanceof operator.
  • fast/js/instanceof-operator-expected.txt:
  • fast/js/script-tests/instanceof-operator.js:
    • added test case for: javascript: ({} instanceof { get prototype(){ alert("Error!"); } })
12:49 PM Changeset in webkit [72126] by andersca@apple.com
  • 5 edits in trunk/WebKit2

Add WKPageCanShowMIMEType
https://bugs.webkit.org/show_bug.cgi?id=49612

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKPage.cpp:

(WKPageCanShowMIMEType):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::canShowMIMEType):

  • UIProcess/WebPageProxy.h:
11:39 AM Changeset in webkit [72125] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected results after r72116.

Remove CSS Variable support
https://bugs.webkit.org/show_bug.cgi?id=49483

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
11:30 AM Changeset in webkit [72124] by zmo@google.com
  • 13 edits in trunk

2010-11-12 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Refactor GL backend flags
https://bugs.webkit.org/show_bug.cgi?id=49460

  • public/WebGraphicsContext3D.h: Remove GL flag queries at this level.
  • src/GraphicsContext3DChromium.cpp: Ditto.
  • src/GraphicsContext3DInternal.h: Ditto.
  • src/WebGraphicsContext3DDefaultImpl.cpp: Ditto.
  • src/WebGraphicsContext3DDefaultImpl.h: Ditto.

2010-11-12 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Refactor GL backend flags
https://bugs.webkit.org/show_bug.cgi?id=49460

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Call setupFlags(). (WebCore::WebGLRenderingContext::initializeNewContext): Remove flag initialization to setupFlags(). (WebCore::WebGLRenderingContext::setupFlags): Initialize GL flags. (WebCore::WebGLRenderingContext::getRenderbufferParameter): Use accessor function instead of member. (WebCore::WebGLRenderingContext::renderbufferStorage): Ditto.
  • html/canvas/WebGLRenderingContext.h: Use flags set in setupFlags instead of querying underlying GL implementation. (WebCore::WebGLRenderingContext::isGLES2Compliant): (WebCore::WebGLRenderingContext::isGLES2NPOTStrict): (WebCore::WebGLRenderingContext::isErrorGeneratedOnOutOfBoundsAccesses): (WebCore::WebGLRenderingContext::isResourceSafe): (WebCore::WebGLRenderingContext::isDepthStencilSupported):
  • platform/graphics/Extensions3D.h: Add NPOT extension.
  • platform/graphics/GraphicsContext3D.h: Remove GL flag queries at this level.
  • platform/graphics/chromium/Extensions3DChromium.h: Add resource_safe and strict_attribs extensions.
  • platform/graphics/mac/GraphicsContext3DMac.mm: Remove GL flag queries at this level.
11:19 AM Changeset in webkit [72123] by kbr@google.com
  • 29 edits
    2 adds in trunk

2010-11-16 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

WebIDL conversions from string to number and array to number should not generate TypeError
https://bugs.webkit.org/show_bug.cgi?id=49218

Recent SVG-related changes to the StrictTypeChecking extended attribute in
CodeGeneratorJS.pm and CodeGeneratorV8.pm were not correct according to the Web IDL and
ECMA-262 specifications. In particular, when an attribute or function argument is specified
as a number type (floating-point or integer), passing in a String or object is not supposed
to raise an exception.

The original intent of the StrictTypeChecking extended attribute was to properly raise
TypeError when an interface type is required, but the supplied object does not implement the
interface type (http://dev.w3.org/2006/webapi/WebIDL/#es-interface). Historically WebKit has
silently passed null to the C++ bindings in this case. The handling of strings in the
original StrictTypeChecking implementation was also incorrect, raising exceptions when it
should not.

The semantics of StrictTypeChecking have been changed to enforce only the restrictions on
interface types. The V8 custom bindings for WebGL have been updated to match the behavior of
the autogenerated code.

Test: fast/canvas/webgl/type-conversion-test.html

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::getObjectParameter): (WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback): (WebCore::V8WebGLRenderingContext::getParameterCallback): (WebCore::V8WebGLRenderingContext::getProgramParameterCallback): (WebCore::V8WebGLRenderingContext::getShaderParameterCallback): (WebCore::vertexAttribAndUniformHelperf):

2010-11-16 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

WebIDL conversions from string to number and array to number should not generate TypeError
https://bugs.webkit.org/show_bug.cgi?id=49218

Updated SVG tests which were incorrectly expecting exceptions to be raised when the Web IDL
and ECMA-262 specifications state that none should be. Incorporated WebGL test from Khronos
repository verifying the passing objects of various types to APIs.

Ran all layout tests in Safari on Mac OS X.

  • fast/canvas/webgl/type-conversion-test-expected.txt: Added.
  • fast/canvas/webgl/type-conversion-test.html: Added.
  • svg/dom/SVGAngle-expected.txt:
  • svg/dom/SVGAnimatedBoolean-expected.txt:
  • svg/dom/SVGAnimatedEnumeration-expected.txt:
  • svg/dom/SVGAnimatedInteger-expected.txt:
  • svg/dom/SVGAnimatedNumber-expected.txt:
  • svg/dom/SVGLength-expected.txt:
  • svg/dom/SVGMatrix-expected.txt:
  • svg/dom/SVGNumber-expected.txt:
  • svg/dom/SVGPoint-expected.txt:
  • svg/dom/SVGPreserveAspectRatio-expected.txt:
  • svg/dom/SVGRect-expected.txt:
  • svg/dom/SVGTransform-expected.txt:
  • svg/dom/script-tests/SVGAngle.js:
  • svg/dom/script-tests/SVGAnimatedBoolean.js:
  • svg/dom/script-tests/SVGAnimatedEnumeration.js:
  • svg/dom/script-tests/SVGAnimatedInteger.js:
  • svg/dom/script-tests/SVGAnimatedNumber.js:
  • svg/dom/script-tests/SVGLength.js:
  • svg/dom/script-tests/SVGMatrix.js:
  • svg/dom/script-tests/SVGNumber.js:
  • svg/dom/script-tests/SVGPoint.js:
  • svg/dom/script-tests/SVGPreserveAspectRatio.js:
  • svg/dom/script-tests/SVGRect.js:
  • svg/dom/script-tests/SVGTransform.js:
11:00 AM Changeset in webkit [72122] by andersca@apple.com
  • 6 edits in trunk/WebKit2

Make WebPageProxy::decidePolicyForMIMEType a tad synchronous
https://bugs.webkit.org/show_bug.cgi?id=49605

Reviewed by Sam Weinig.

Change the DecidePolicyForMIMEType message to be synchronous, and if the policy listener is
invoked from within the decidePolicyForMIMEType callback return the policy information as out
parameters. This is needed in order to convert a loading connection to a download.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForMIMEType):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):

10:58 AM Changeset in webkit [72121] by ap@apple.com
  • 2 edits in trunk/WebCore

Windows build fix.

  • DerivedSources.cpp: Removing CSS Variables generated files.
10:50 AM Changeset in webkit [72120] by sfalken@apple.com
  • 2 edits
    1 delete in trunk/WebKit/win

Remove unnecessary def file, remove outdated def files from vcproj.

Rubber stamped by Adam Roben.

  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKit_debug.def: Removed.
10:44 AM Changeset in webkit [72119] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2010-11-16 Eric Carlson <eric.carlson@apple.com>

Reviewed by John Sullivan.

getMIMEType(s)ForExtension should consult system mapping
https://bugs.webkit.org/show_bug.cgi?id=49497

No new tests possible.

  • platform/MIMETypeRegistry.cpp: (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): Add the type returned by getMIMETypeForExtension. Put the result of mediaMIMETypeMap().get() in a local variable and test instead of calling constains() and then get(). (WebCore::MIMETypeRegistry::getMediaMIMETypesForExtension): Ditto.
10:35 AM Changeset in webkit [72118] by sfalken@apple.com
  • 4 edits
    1 add in trunk/LayoutTests

Unreviewed baseline update for Windows.
Update test expectations following r72052.

  • platform/win/fast/blockflow/vertical-font-fallback-expected.txt: Added.
  • platform/win/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/win/fast/forms/textarea-placeholder-set-attribute-expected.txt:
10:28 AM Changeset in webkit [72117] by eric.carlson@apple.com
  • 4 edits in trunk/WebCore

2010-11-16 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Rename QTKit based media engine class name
https://bugs.webkit.org/show_bug.cgi?id=36663

No new tests as this just renames a class and restructures existing code.

  • platform/graphics/MediaPlayer.cpp: (WebCore::installedMediaEngines): Use a macro with the platform media player class name to reduce the number of #ifs in the code.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h: Rename MediaPlayerPrivate to MediaPlayerPrivateQTKit.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::create): (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): (WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit): (WebCore::MediaPlayerPrivateQTKit::~MediaPlayerPrivateQTKit): (WebCore::MediaPlayerPrivateQTKit::createQTMovie): (WebCore::MediaPlayerPrivateQTKit::createQTMovieView): (WebCore::MediaPlayerPrivateQTKit::detachQTMovieView): (WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer): (WebCore::MediaPlayerPrivateQTKit::destroyQTVideoRenderer): (WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer): (WebCore::MediaPlayerPrivateQTKit::destroyQTMovieLayer): (WebCore::MediaPlayerPrivateQTKit::currentRenderingMode): (WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode): (WebCore::MediaPlayerPrivateQTKit::setUpVideoRendering): (WebCore::MediaPlayerPrivateQTKit::tearDownVideoRendering): (WebCore::MediaPlayerPrivateQTKit::hasSetUpVideoRendering): (WebCore::MediaPlayerPrivateQTKit::createQTTime): (WebCore::MediaPlayerPrivateQTKit::resumeLoad): (WebCore::MediaPlayerPrivateQTKit::load): (WebCore::MediaPlayerPrivateQTKit::loadInternal): (WebCore::MediaPlayerPrivateQTKit::prepareToPlay): (WebCore::MediaPlayerPrivateQTKit::platformMedia): (WebCore::MediaPlayerPrivateQTKit::platformLayer): (WebCore::MediaPlayerPrivateQTKit::play): (WebCore::MediaPlayerPrivateQTKit::pause): (WebCore::MediaPlayerPrivateQTKit::duration): (WebCore::MediaPlayerPrivateQTKit::currentTime): (WebCore::MediaPlayerPrivateQTKit::seek): (WebCore::MediaPlayerPrivateQTKit::doSeek): (WebCore::MediaPlayerPrivateQTKit::cancelSeek): (WebCore::MediaPlayerPrivateQTKit::seekTimerFired): (WebCore::MediaPlayerPrivateQTKit::paused): (WebCore::MediaPlayerPrivateQTKit::seeking): (WebCore::MediaPlayerPrivateQTKit::naturalSize): (WebCore::MediaPlayerPrivateQTKit::hasVideo): (WebCore::MediaPlayerPrivateQTKit::hasAudio): (WebCore::MediaPlayerPrivateQTKit::supportsFullscreen): (WebCore::MediaPlayerPrivateQTKit::setVolume): (WebCore::MediaPlayerPrivateQTKit::hasClosedCaptions): (WebCore::MediaPlayerPrivateQTKit::setClosedCaptionsVisible): (WebCore::MediaPlayerPrivateQTKit::setRate): (WebCore::MediaPlayerPrivateQTKit::setPreservesPitch): (WebCore::MediaPlayerPrivateQTKit::buffered): (WebCore::MediaPlayerPrivateQTKit::maxTimeSeekable): (WebCore::MediaPlayerPrivateQTKit::maxTimeLoaded): (WebCore::MediaPlayerPrivateQTKit::bytesLoaded): (WebCore::MediaPlayerPrivateQTKit::totalBytes): (WebCore::MediaPlayerPrivateQTKit::cancelLoad): (WebCore::MediaPlayerPrivateQTKit::cacheMovieScale): (WebCore::MediaPlayerPrivateQTKit::isReadyForVideoSetup): (WebCore::MediaPlayerPrivateQTKit::prepareForRendering): (WebCore::MediaPlayerPrivateQTKit::updateStates): (WebCore::MediaPlayerPrivateQTKit::loadStateChanged): (WebCore::MediaPlayerPrivateQTKit::rateChanged): (WebCore::MediaPlayerPrivateQTKit::sizeChanged): (WebCore::MediaPlayerPrivateQTKit::timeChanged): (WebCore::MediaPlayerPrivateQTKit::didEnd): (WebCore::MediaPlayerPrivateQTKit::setSize): (WebCore::MediaPlayerPrivateQTKit::setVisible): (WebCore::MediaPlayerPrivateQTKit::hasAvailableVideoFrame): (WebCore::MediaPlayerPrivateQTKit::repaint): (WebCore::MediaPlayerPrivateQTKit::paintCurrentFrameInContext): (WebCore::MediaPlayerPrivateQTKit::paint): (WebCore::MediaPlayerPrivateQTKit::getSupportedTypes): (WebCore::MediaPlayerPrivateQTKit::supportsType): (WebCore::MediaPlayerPrivateQTKit::isAvailable): (WebCore::MediaPlayerPrivateQTKit::disableUnsupportedTracks): (WebCore::MediaPlayerPrivateQTKit::sawUnsupportedTracks): (WebCore::MediaPlayerPrivateQTKit::supportsAcceleratedRendering): (WebCore::MediaPlayerPrivateQTKit::acceleratedRenderingStateChanged): (WebCore::MediaPlayerPrivateQTKit::hasSingleSecurityOrigin): (WebCore::MediaPlayerPrivateQTKit::movieLoadType): (WebCore::MediaPlayerPrivateQTKit::setPreload): (WebCore::MediaPlayerPrivateQTKit::mediaTimeForTimeValue): (-[WebCoreMovieObserver initWithCallback:]):
10:25 AM Changeset in webkit [72116] by ap@apple.com
  • 45 edits
    13 deletes in trunk

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=49483
Remove CSS Variable support

10:15 AM Changeset in webkit [72115] by Darin Adler
  • 2 edits in trunk/WebCore

2010-11-16 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=48603
Boolean logic mistake in local file check

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadFrameRequest): Fix logic so that both checks have to pass before accepting a local file load.
10:04 AM Changeset in webkit [72114] by Darin Adler
  • 7 edits in trunk

2010-11-15 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Harden additional string functions against large lengths
https://bugs.webkit.org/show_bug.cgi?id=49574

  • wtf/text/CString.cpp: (WTF::CString::init): Check for length that is too large for CString. (WTF::CString::newUninitialized): Ditto. (WTF::CString::copyBufferIfNeeded): Fix types so the length stays in a size_t.
  • wtf/text/WTFString.cpp: (WTF::String::append): Check for length that is too large.

2010-11-15 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Harden additional string functions against large lengths
https://bugs.webkit.org/show_bug.cgi?id=49574

  • platform/text/TextCodecUTF16.cpp: (WebCore::TextCodecUTF16::encode): Check for length that is too large for size_t.
  • platform/text/TextStream.cpp: (WebCore::TextStream::operator<<): Check for length that is too large for size_t.
9:56 AM Changeset in webkit [72113] by Martin Robinson
  • 2 edits in trunk/WebKit/gtk

2010-11-16 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Some key-press events can't be handled by WebView
https://bugs.webkit.org/show_bug.cgi?id=48986

The problem is that "popup-menu" and "show-help" signals are
handled by GtkTextView, as they are added to the key bindings set
of every widget in gtk_widget_class_init(). For all other bindings
handled by GtkTextView we are stopping the signal emission in
their callbacks, so we only need to do the same for "popup-menu"
and "show-help" signals.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::toggleOverwriteCallback): (WebKit::popupMenuCallback): (WebKit::showHelpCallback): (WebKit::EditorClient::EditorClient):
9:50 AM Changeset in webkit [72112] by pfeldman@chromium.org
  • 2 edits
    3 moves
    1 add in trunk/WebKit/chromium

2010-11-16 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Chromium build fix.

  • WebKit.gyp:
  • scripts/concatenate_css_files.py: Renamed from WebKit/chromium/Build/concatenate_css_files.py.
  • scripts/concatenate_js_files.py: Renamed from WebKit/chromium/Build/concatenate_js_files.py.
  • scripts/generate_devtools_html.py: Renamed from WebKit/chromium/Build/generate_devtools_html.py.
9:41 AM Changeset in webkit [72111] by Adam Roben
  • 3 edits
    2 adds in trunk/WebKitTools

Only trigger Windows builds when files that we actually use on Windows are changed

A new Scheduler subclass, PlatformSpecificScheduler, has been added.
It uses the new webkitpy.common.config.build module to determine
whether a particular change should trigger a build on a particular
platform. The Windows builders have been switched to use a
PlatformSpecificScheduler.

The logic to determine whether or not a particular change should
trigger a build on a given platform has only been implemented/tested
for Windows. I tried to make it easy to add more platforms in the
future, but I don't have enough familiarity with all platforms to be
able to implement it for them.

Fixes <http://webkit.org/b/49407> Windows builders kick off builds for
lots irrelevant changes (e.g., rebaselining Chromium test results)

Reviewed by Eric Seidel.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Use a

PlatformSpecificScheduler for the Windows builders.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(PlatformSpecificScheduler.init): Added. Stores our platform, sets
up a ChangeFilter that filters to our branch and will call through to
our filter method, and calls up to our base class.
(PlatformSpecificScheduler.filter): Calls through to
build.should_build to find out whether we should trigger a build for
this change.

  • Scripts/webkitpy/common/net/build.py: Added.

(_should_file_trigger_build): Uses a set of directories and regexp
patterns to determine whether the given file should trigger a build on
the given platform. As mentioned earlier, this has only been
implemented for Windows, though I did try to make some guesses about
other platforms.
(should_build): Returns true if any of the files should trigger a
build on the given platform.

  • Scripts/webkitpy/common/net/build_unittest.py: Added.

(ShouldBuildTest.test_should_build): Does some basic testing to make
sure we're triggering builds for the right files. It only tests
Windows for now, though I tried to make some guesses about other
platforms.

9:32 AM Changeset in webkit [72110] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-11-16 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Touching inspector controller to make gtk / qt happier.

  • inspector/InspectorController.cpp:
9:31 AM Changeset in webkit [72109] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-11-16 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Show default context menu for the currently focused element when activated with keyboard
https://bugs.webkit.org/show_bug.cgi?id=49376

  • webkit/webkitwebview.cpp: (webkit_web_view_popup_menu_handler):
9:19 AM Changeset in webkit [72108] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-16 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

A couple of SVG tests don't time out on the Mac.

  • platform/chromium/test_expectations.txt:
9:16 AM Changeset in webkit [72107] by mihaip@chromium.org
  • 2 edits
    6 adds in trunk/LayoutTests

2010-11-16 Mihai Parparita <mihaip@chromium.org>

Unreviewed baseline update.

Add pixel baselines for fast/images/gray-scale-png-with-color-profile.html,
originally added by r71461.

  • platform/chromium-mac/fast/images/gray-scale-png-with-color-profile-expected.checksum: Added.
  • platform/chromium-mac/fast/images/gray-scale-png-with-color-profile-expected.png: Added.
  • platform/chromium-win/fast/images/gray-scale-png-with-color-profile-expected.checksum: Added.
  • platform/chromium-win/fast/images/gray-scale-png-with-color-profile-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/images/gray-scale-png-with-color-profile-expected.checksum: Added.
  • platform/mac/fast/images/gray-scale-png-with-color-profile-expected.png: Added.
9:14 AM Changeset in webkit [72106] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-16 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Use gdk_pixbuf_get_from_surface() when available
https://bugs.webkit.org/show_bug.cgi?id=49532

  • platform/graphics/gtk/GdkCairoUtilities.cpp: (cairoImageSurfaceToGdkPixbuf):
9:13 AM Changeset in webkit [72105] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-16 Marcus Bulach <bulach@chromium.org>

Not reviewed, chromium test expectation and baselines update.

Re-adds a couple of tests_expectations wrongly excluded by r72099
https://bugs.webkit.org/show_bug.cgi?id=49599

  • platform/chromium/test_expectations.txt:
9:06 AM Changeset in webkit [72104] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-16 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Remove expectations for tests that now pass:

  • r71993 made svg/W3C-SVG-1.1/fonts-desc-02-t.svg passes again (with the current baselines)
  • fast/forms/search-styled.html and fast/forms/search-placeholder-value-changed.html were rebaselined by r72073
  • platform/chromium/test_expectations.txt:
8:44 AM Changeset in webkit [72103] by pfeldman@chromium.org
  • 2 edits
    4 adds in trunk/WebKit/chromium

2010-11-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chrome DevTools: concatenate CSS files, do not link
missing JS files in release mode.
https://bugs.webkit.org/show_bug.cgi?id=49586

  • Build/concatenate_css_files.py: Added.
  • Build/concatenate_js_files.py: Added.
  • Build/generate_devtools_html.py: Added.
  • WebKit.gyp:
8:42 AM Changeset in webkit [72102] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-11-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: init front-end UI upon DOMContentLoaded, not load event.
https://bugs.webkit.org/show_bug.cgi?id=49596

  • inspector/front-end/inspector.js: (windowLoaded):
8:28 AM Changeset in webkit [72101] by Simon Hausmann
  • 11 edits in trunk

[Qt] Remove synchronous QWebPage::checkPermissions signal
https://bugs.webkit.org/show_bug.cgi?id=46810

Reviewed by Andreas Kling.

WebKit/qt:

As decided in the API review, we remove this signal and replace its only use currently
with cached credentials.

  • Api/qwebpage.cpp:

(QWebPage::setUserPermission): Pass the WebCore frame instead of the QWebFrame.

  • Api/qwebpage.h:
  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::checkPermission): Replaced explicit
signal emission with hash lookup of previously granted permission (or not).
(WebCore::NotificationPresenterClientQt::cancelRequestsForPermission): Remove
any previously cached/granted permission for the given script execution context.
(WebCore::NotificationPresenterClientQt::allowNotificationForFrame): Do not
only serve pending permission requests but before calling the JS callbacks, remember
the permission for subsequent synchronous checkPermission() calls.

  • WebCoreSupport/NotificationPresenterClientQt.h: Add cache for permissions.

WebKitTools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::WebPage):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::grantDesktopNotificationPermission): When granting
permission, grant it directly on the QWebPage/Frame, that will remember it.

  • QtTestBrowser/webpage.cpp:

(WebPage::WebPage):

  • QtTestBrowser/webpage.h:
8:14 AM Changeset in webkit [72100] by andreas.kling@nokia.com
  • 11 edits in trunk/WebKit2

2010-11-16 Kenneth Rohde Christiansen <kenneth@webkit.org>, Zalan Bujtas <zbujtas@gmail.com>

Reviewed by Andreas Kling.

[WK2][Qt] Add API for finding a zoomable area for a given point

This is useful for implementing e.g "double tap zoom"

Only enabled for Qt.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::findZoomableAreaForPoint): (QWKPagePrivate::didFindZoomableArea):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didFindZoomableArea): (WebKit::WebPageProxy::findZoomableAreaForPoint):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::findZoomableAreaForPoint):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
8:03 AM Changeset in webkit [72099] by bulach@chromium.org
  • 2 edits
    110 adds in trunk/LayoutTests

2010-11-16 Marcus Bulach <bulach@chromium.org>

Not reviewed, chromium test expectation and baselines update.

Update chromium baselines following r72092
https://bugs.webkit.org/show_bug.cgi?id=49595

  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.txt: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.txt: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium/test_expectations.txt:
7:52 AM Changeset in webkit [72098] by abecsi@webkit.org
  • 5 edits
    4 adds in trunk

2010-11-16 Andras Becsi <abecsi@inf.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.
Add previously removed expected file, png and checksum.

  • platform/qt/Skipped:
  • platform/qt/printing/page-rule-in-media-query-expected.checksum: Added.
  • platform/qt/printing/page-rule-in-media-query-expected.png: Added.
  • platform/qt/printing/page-rule-in-media-query-expected.txt: Added.

2010-11-16 Andras Becsi <abecsi@inf.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):
  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::isPrinting): (LayoutTestController::setPrinting):
7:45 AM Changeset in webkit [72097] by leandro@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-11-16 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed. Build fix.

  • WebCoreSupport/FrameLoaderClientEfl.h: Also include ResourceError.h.
7:25 AM Changeset in webkit [72096] by apavlov@chromium.org
  • 10 edits
    3 adds in trunk

2010-11-15 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Migrate frontend to the new CSS editing/retrieval API
https://bugs.webkit.org/show_bug.cgi?id=49492

Test: inspector/styles-new-API.html

WebCore:

  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.routine): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.receivedImages):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.getStylesAsync): (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync): (WebInspector.CSSStyleModel.prototype.getInlineStyleAsync): (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback): (WebInspector.CSSStyleModel.prototype.addRule): (WebInspector.CSSStyleModel.prototype.addRule.callback): (WebInspector.CSSStyleDeclaration): (WebInspector.CSSStyleDeclaration.prototype.propertyAt): (WebInspector.CSSStyleDeclaration.prototype.pastLastSourcePropertyIndex): (WebInspector.CSSStyleDeclaration.prototype.newBlankProperty): (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt): (WebInspector.CSSStyleDeclaration.prototype.appendProperty): (WebInspector.CSSRule): (WebInspector.CSSProperty.prototype.get propertyText): (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setDisabled): (WebInspector.CSSStyleSheet): (WebInspector.CSSStyleSheet.createForId): (WebInspector.CSSStyleSheet.prototype.getText): (WebInspector.CSSStyleSheet.prototype.setText):
  • inspector/front-end/Settings.js:
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.onpopulate): (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): (WebInspector.StylePropertiesSection.prototype._debugShowStyle.removeStyleBox): (WebInspector.StylePropertiesSection.prototype._debugShowStyle): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.StylePropertyTreeElement.prototype): (WebInspector.StylePropertyTreeElement.prototype.):
  • inspector/front-end/inspector.css: (.styles-section .properties li.not-parsed-ok): (.styles-section .properties li.not-parsed-ok::before): (.styles-section .properties .inactive):

LayoutTests:

  • inspector/audits-panel-functional-expected.txt:
  • inspector/elements-panel-styles-expected.txt:
  • inspector/resources/styles-new-API.css: Added. (html): (body): (/* comment before selector */body.main1/* comment after selector */): (body.main2): (body::after): (h1):
  • inspector/styles-new-API-expected.txt: Added.
  • inspector/styles-new-API.html: Added.
6:40 AM Changeset in webkit [72095] by apavlov@chromium.org
  • 7 edits
    11 adds
    1 delete in trunk

2010-11-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72082.
http://trac.webkit.org/changeset/72082
https://bugs.webkit.org/show_bug.cgi?id=49594

"broken SnowLeopard build" (Requested by apavlov on #webkit).

  • fast/css/CSSPrimitiveValue-exceptions-expected.txt:
  • fast/css/getFloatValueForUnit-expected.txt: Removed.
  • fast/css/getFloatValueForUnit.html:
  • fast/css/resources/CSSPrimitiveValue-exceptions.js:
  • platform/chromium-linux/fast/css/getFloatValueForUnit-expected.checksum: Added.
  • platform/chromium-linux/fast/css/getFloatValueForUnit-expected.png: Added.
  • platform/chromium-win/fast/css/getFloatValueForUnit-expected.checksum: Added.
  • platform/chromium-win/fast/css/getFloatValueForUnit-expected.png: Added.
  • platform/chromium-win/fast/css/getFloatValueForUnit-expected.txt: Added.
  • platform/mac-leopard/fast/css/getFloatValueForUnit-expected.checksum: Added.
  • platform/mac-leopard/fast/css/getFloatValueForUnit-expected.png: Added.
  • platform/mac/fast/css/getFloatValueForUnit-expected.checksum: Added.
  • platform/mac/fast/css/getFloatValueForUnit-expected.png: Added.
  • platform/mac/fast/css/getFloatValueForUnit-expected.txt: Added.
  • platform/qt/fast/css/getFloatValueForUnit-expected.txt: Added.

2010-11-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72082.
http://trac.webkit.org/changeset/72082
https://bugs.webkit.org/show_bug.cgi?id=49594

"broken SnowLeopard build" (Requested by apavlov on #webkit).

  • css/CSSPrimitiveValue.cpp: (WebCore::scaleFactorForConversion): (WebCore::CSSPrimitiveValue::getDoubleValue): (WebCore::CSSPrimitiveValue::getIdent):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getFloatValue): (WebCore::CSSPrimitiveValue::getIntValue):
6:23 AM Changeset in webkit [72094] by apavlov@chromium.org
  • 2 edits in trunk/WebCore

2010-11-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72087.
http://trac.webkit.org/changeset/72087
https://bugs.webkit.org/show_bug.cgi?id=49593

"broken build" (Requested by apavlov on #webkit).

  • css/CSSPrimitiveValue.cpp: (WebCore::unitCategory):
6:23 AM Changeset in webkit [72093] by andreas.kling@nokia.com
  • 5 edits in trunk/WebKit2

2010-11-16 Andreas Kling <kling@webkit.org>

Rubber-stamped by Simon Hausmann.

Revert !ENABLE(INSPECTOR) fix- we don't need it right now,
and it was less maintainable than I had though.

  • Shared/API/c/WKSharedAPICast.h: (WebKit::toAPI): (WebKit::toImpl):
  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
  • WebProcess/WebPage/WebInspector.cpp:
6:14 AM Changeset in webkit [72092] by Nikolas Zimmermann
  • 1 edit
    52 adds in trunk/LayoutTests

2010-11-16 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.


Add missing pixel test results that Rob forgot to add.

  • platform/mac/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Added.
5:44 AM Changeset in webkit [72091] by andreas.kling@nokia.com
  • 5 edits in trunk/WebKit2

2010-11-16 Andreas Kling <kling@webkit.org>

Reviewed by Simon Hausmann.

Fix compilation with !ENABLE(INSPECTOR)

  • Shared/API/c/WKSharedAPICast.h: (WebKit::toAPI): (WebKit::toImpl):
  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
  • WebProcess/WebPage/WebInspector.cpp:
5:42 AM Changeset in webkit [72090] by pfeldman@chromium.org
  • 12 edits
    1 move
    1 delete in trunk

2010-11-15 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: rename StoragePanel to ResourcesPanel.
https://bugs.webkit.org/show_bug.cgi?id=49534

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._queryFinished):
  • inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView.prototype._queryFinished):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
  • inspector/front-end/Images/storageIcon.png: Removed.
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.setOverrideContent): (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame): (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame): (WebInspector.ResourceTreeModel.prototype.frameDetachedFromParent): (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources): (WebInspector.ResourceTreeModel.prototype.addResourceToFrame):
  • inspector/front-end/StoragePanel.js: Removed.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.resources.panel .sidebar): (.resources.panel .sidebar li): (.resources.panel .sidebar li.parent): (.resources.panel .sidebar li.selected): (.resources.panel .sidebar li.selected .selection): (.resources.panel .sidebar :focus li.selected .selection): (body.inactive .resources.panel .sidebar li.selected .selection): (.resources.panel .sidebar .icon): (.resources.panel .base-storage-tree-element-title): (.resources.panel .status): (.resources.panel li .status .bubble):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels): (WebInspector.openResource): (WebInspector.showPanel): (WebInspector.selectDatabase): (WebInspector.selectDOMStorage): (WebInspector.addDatabase): (WebInspector.addDOMStorage): (WebInspector.updateDOMStorage): (WebInspector.updateApplicationCacheStatus): (WebInspector.didGetFileSystemPath): (WebInspector.didGetFileSystemError): (WebInspector.didGetFileSystemDisabled): (WebInspector.updateNetworkState): (WebInspector._choosePanelToShowSourceLine):
5:23 AM Changeset in webkit [72089] by kbalazs@webkit.org
  • 6 edits in trunk/WebKitTools

2010-11-16 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=49587

  • MiniBrowser/qt/BrowserView.cpp: (BrowserView::BrowserView): Added BackingStoreType argument to ctor. Propagating it to the QGraphicsWKView.
  • MiniBrowser/qt/BrowserView.h:
  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): (BrowserWindow::newWindow): Create the new BrowserWindow with the same BackingStoreType that this instance has.
  • MiniBrowser/qt/BrowserWindow.h: Added BackingStoreType member.
  • MiniBrowser/qt/main.cpp: (main): Use tiled backing store if got -tiled command line argument. Avoid redundant copy of command line args.
5:10 AM Changeset in webkit [72088] by abecsi@webkit.org
  • 2 edits in trunk/WebKit2

2010-11-16 Andras Becsi <abecsi@webkit.org>

Reviewed by Andreas Kling.

[Qt] Use SIGINT instead of SIGKILL to let the web process clean up after itself.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::QtWebProcess::setupChildProcess):
5:06 AM Changeset in webkit [72087] by apavlov@chromium.org
  • 2 edits in trunk/WebCore

2010-11-16 Alexander Pavlov <apavlov@chromium.org>

Unreviewed SnowLeopard build fix.

  • css/CSSPrimitiveValue.cpp: (WebCore::unitCategory):
4:55 AM Changeset in webkit [72086] by andreas.kling@nokia.com
  • 10 edits in trunk/WebKit2

2010-11-16 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

[WK2][Qt] Expose resizes-to-contents mode in WebKit2

Only available with ENABLE(TILED_BACKING_STORE)

Based on a patch by Antti Koivisto.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::setResizesToContentsUsingLayoutSize):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setResizesToContentsUsingLayoutSize):
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::contentsSizeChanged):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setSize): (WebKit::WebPage::setResizesToContentsUsingLayoutSize): (WebKit::WebPage::resizeToContentsIfNeeded):
  • WebProcess/WebPage/WebPage.h: (WebKit::WebPage::resizesToContentsEnabled): (WebKit::WebPage::resizesToContentsLayoutSize):
  • WebProcess/WebPage/WebPage.messages.in:
4:46 AM Changeset in webkit [72085] by andreas.kling@nokia.com
  • 2 edits in trunk

2010-11-16 Andreas Kling <kling@webkit.org>

Unreviewed typo fix for previous commit.

  • common.pri:
4:26 AM Changeset in webkit [72084] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-11-16 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

Viewport meta tag: Fix geometry computation

Available width and height should also be divided by the device pixel ratio.

  • dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):
  • platform/network/qt/DnsPrefetchHelper.cpp:
4:22 AM Changeset in webkit [72083] by Csaba Osztrogonác
  • 2 edits
    1 delete in trunk/LayoutTests

Unreviewed.

[Qt] Add printing/page-rule-in-media-query.html to the skipped
list because of missing layoutTestController.setPrinting().

And remove incorrect Qt specific expected result.

  • platform/qt/Skipped: printing/page-rule-in-media-query.html added until fix.
  • platform/qt/printing: Removed.
  • platform/qt/printing/page-rule-in-media-query-expected.checksum: Removed.
  • platform/qt/printing/page-rule-in-media-query-expected.png: Removed.
  • platform/qt/printing/page-rule-in-media-query-expected.txt: Removed.
4:12 AM Changeset in webkit [72082] by apavlov@chromium.org
  • 7 edits
    1 add
    11 deletes in trunk

2010-11-12 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Simon Fraser.

CSSPrimitiveValue.getFloatValue does not convert sizes

Extended getFloatValueForUnit and CSSPrimitiveValue tests. The former has been made text-only,
which allowed to get rid of a number of unnecessary baselines.
https://bugs.webkit.org/show_bug.cgi?id=35770

  • fast/css/CSSPrimitiveValue-exceptions-expected.txt:
  • fast/css/getFloatValueForUnit-expected.txt: Added.
  • fast/css/getFloatValueForUnit.html:
  • fast/css/resources/CSSPrimitiveValue-exceptions.js:
  • platform/chromium-linux/fast/css/getFloatValueForUnit-expected.checksum: Removed.
  • platform/chromium-linux/fast/css/getFloatValueForUnit-expected.png: Removed.
  • platform/chromium-win/fast/css/getFloatValueForUnit-expected.checksum: Removed.
  • platform/chromium-win/fast/css/getFloatValueForUnit-expected.png: Removed.
  • platform/chromium-win/fast/css/getFloatValueForUnit-expected.txt: Removed.
  • platform/mac-leopard/fast/css/getFloatValueForUnit-expected.checksum: Removed.
  • platform/mac-leopard/fast/css/getFloatValueForUnit-expected.png: Removed.
  • platform/mac/fast/css/getFloatValueForUnit-expected.checksum: Removed.
  • platform/mac/fast/css/getFloatValueForUnit-expected.png: Removed.
  • platform/mac/fast/css/getFloatValueForUnit-expected.txt: Removed.
  • platform/qt/fast/css/getFloatValueForUnit-expected.txt: Removed.

2010-11-12 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Simon Fraser.

CSSPrimitiveValue.getFloatValue does not convert sizes
https://bugs.webkit.org/show_bug.cgi?id=35770

Implemented all same-category unit conversions (length, angle, time, frequency) and retained
absolute-relative (cm, mm, in, pt, pc) length conversions intact.
Illegal unit conversion attempts will throw an INVALID_ACCESS_ERR DOMException.

  • css/CSSPrimitiveValue.cpp: (WebCore::unitCategory): (WebCore::scaleFactorForConversion): (WebCore::CSSPrimitiveValue::getDoubleValue): (WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory): (WebCore::CSSPrimitiveValue::getDoubleValueInternal):
  • css/CSSPrimitiveValue.h:
4:11 AM Changeset in webkit [72081] by andreas.kling@nokia.com
  • 2 edits in trunk

2010-11-16 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][Scratchbox] Use gold linker explicitly when available

gold is faster at linking QtWebKit than binutils ld, but it cannot be
enabled by default on a system that compiles other Qt projects.
This is due to gold not supporting the --add-needed flag.

Original patch by Kimmo Kinnunen.

  • common.pri:
4:06 AM Changeset in webkit [72080] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit2

2010-11-16 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Get proxy settings from environment (http[s]_proxy)

If http_proxy and/or https_proxy are set in the environment,
pass those in to QNetworkAccessManager.

  • WebProcess/qt/WebProcessMainQt.cpp: (WebKit::EnvHttpProxyFactory::EnvHttpProxyFactory): (WebKit::EnvHttpProxyFactory::initializeFromEnvironment): (WebKit::EnvHttpProxyFactory::queryProxy): (WebKit::initializeProxy): (WebKit::WebProcessMainQt):
3:56 AM Changeset in webkit [72079] by andreas.kling@nokia.com
  • 2 edits in trunk

2010-11-16 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add 'valgrind' build mode

Passing CONFIG+=valgrind to qmake will now build WebKit in a way
suitable for debugging with Valgrind.

Original patch by Christian Sejersen.

  • WebKit.pri:
3:53 AM Changeset in webkit [72078] by andreas.kling@nokia.com
  • 3 edits in trunk/WebKit2

2010-11-16 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Emit windowCloseRequested signal on window.close()

Original patch by Zalan Bujtas.

  • UIProcess/API/qt/ClientImpl.cpp: (qt_wk_close):
  • UIProcess/API/qt/qwkpage.h:
3:50 AM Changeset in webkit [72077] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit2

2010-11-15 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Kill the web process if the UI process dies

Connect UI (parent) process death signal to SIGKILL of the web
process (child). This ensures that there's no stale web processes
after the UI process has crashed.

Original patch by Kimmo Kinnunen.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::QtWebProcess::QtWebProcess): (WebKit::QtWebProcess::setupChildProcess): (WebKit::ProcessLauncherHelper::launch):
3:45 AM Changeset in webkit [72076] by bulach@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-11-16 Marcus Bulach <bulach@chromium.org>

Not reviewed, chromium test expectation update.

Update chromium baselines following r72063
https://bugs.webkit.org/show_bug.cgi?id=49591

  • platform/chromium-mac/fast/js/function-prototype-descriptor-expected.txt: Added.
  • platform/chromium-win/fast/js/function-prototype-descriptor-expected.txt: Added.
3:34 AM Changeset in webkit [72075] by bulach@chromium.org
  • 5 edits in trunk/LayoutTests

2010-11-16 Marcus Bulach <bulach@chromium.org>

Not reviewed, chromium test expectation update.

Update chromium baselines following r72050
https://bugs.webkit.org/show_bug.cgi?id=49590

  • platform/chromium-mac/fast/css/font-face-descriptor-multiple-values-parsing-expected.txt:
  • platform/chromium-mac/fast/js/exception-thrown-from-new-expected.txt:
  • platform/chromium-win/fast/css/font-face-descriptor-multiple-values-parsing-expected.txt:
  • platform/chromium-win/fast/js/exception-thrown-from-new-expected.txt:
3:31 AM Changeset in webkit [72074] by Simon Hausmann
  • 2 edits in trunk/WebKit2

[Qt] Trivial build fix for building WebKit2 inside Qt Creator

Rubber-stamped by Andreas Kling.

Similar to WebCore.pro, define a fallback for OUTPUT_DIR.

  • WebKit2.pro:
3:10 AM Changeset in webkit [72073] by bulach@chromium.org
  • 30 edits
    1 copy
    17 adds
    2 deletes in trunk/LayoutTests

2010-11-16 Marcus Bulach <bulach@chromium.org>

Not reviewed, chromium test expectation update.

Update chromium baselines following r72052
https://bugs.webkit.org/show_bug.cgi?id=49588

  • platform/chromium-linux/fast/forms/placeholder-pseudo-style-expected.checksum:
  • platform/chromium-linux/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-linux/fast/forms/placeholder-stripped-expected.checksum:
  • platform/chromium-linux/fast/forms/placeholder-stripped-expected.png:
  • platform/chromium-linux/fast/forms/search-placeholder-value-changed-expected.checksum:
  • platform/chromium-linux/fast/forms/search-placeholder-value-changed-expected.png:
  • platform/chromium-linux/fast/forms/search-styled-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/search-styled-expected.png: Added.
  • platform/chromium-linux/fast/forms/search-styled-expected.txt: Added.
  • platform/chromium-linux/fast/forms/textarea-placeholder-pseudo-style-expected.checksum:
  • platform/chromium-linux/fast/forms/textarea-placeholder-pseudo-style-expected.png:
  • platform/chromium-mac/fast/css/pseudo-cache-stale-expected.checksum: Added.
  • platform/chromium-mac/fast/css/pseudo-cache-stale-expected.png: Added.
  • platform/chromium-mac/fast/forms/isindex-placeholder-expected.checksum:
  • platform/chromium-mac/fast/forms/isindex-placeholder-expected.png:
  • platform/chromium-mac/fast/forms/password-placeholder-text-security-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/password-placeholder-text-security-expected.png: Added.
  • platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.png: Added.
  • platform/chromium-mac/fast/forms/placeholder-stripped-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/placeholder-stripped-expected.png: Added.
  • platform/chromium-mac/fast/forms/search-placeholder-value-changed-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/search-placeholder-value-changed-expected.png: Added.
  • platform/chromium-mac/fast/forms/search-styled-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/search-styled-expected.png: Added.
  • platform/chromium-mac/fast/forms/textarea-placeholder-pseudo-style-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/textarea-placeholder-pseudo-style-expected.png: Added.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.checksum: Removed.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.png: Removed.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/css/pseudo-cache-stale-expected.txt:
  • platform/chromium-win/fast/forms/isindex-placeholder-expected.txt:
  • platform/chromium-win/fast/forms/password-placeholder-expected.txt:
  • platform/chromium-win/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.checksum:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.checksum:
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.png:
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.txt:
  • platform/chromium-win/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/chromium-win/fast/forms/search-styled-expected.checksum:
  • platform/chromium-win/fast/forms/search-styled-expected.png:
  • platform/chromium-win/fast/forms/search-styled-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/fast/forms/search-styled-expected.txt.
  • platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.checksum:
  • platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.png:
  • platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-set-attribute-expected.txt:
2:59 AM Changeset in webkit [72072] by pfeldman@chromium.org
  • 8 edits in trunk/WebCore

2010-11-15 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract HTML title setter in treeoutline.js.
https://bugs.webkit.org/show_bug.cgi?id=49540

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.adjustCollapsedRange): (WebInspector.ElementsTreeElement.prototype.updateTitle):
  • inspector/front-end/treeoutline.js: (TreeElement.prototype.get titleHTML): (TreeElement.prototype.set titleHTML): (TreeElement.prototype._setListItemNodeContent):
2:54 AM Changeset in webkit [72071] by commit-queue@webkit.org
  • 7 edits in trunk

2010-11-16 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Assert that DeviceOrientationClientMock is used by only one controller.
https://bugs.webkit.org/show_bug.cgi?id=48506

This is a design constraint of the DeviceOrientationClientMock because the
m_controller field can only store a pointer to a single instance of the
corresponding DeviceOrientationController.

  • platform/mock/DeviceOrientationClientMock.cpp: (WebCore::DeviceOrientationClientMock::setController):

2010-11-16 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Move DeviceOrientationClientMock from LayoutTestController to WebViewHost.
https://bugs.webkit.org/show_bug.cgi?id=48506

This ensures that there is one mock per page WebView / WebViewHost. This is a
design constraint of the DeviceOrientationClientMock because the m_controller
field can only store a pointer to a single instance of the corresponding
DeviceOrientationController.

Test: fast/dom/DeviceOrientation/no-page-cache.html

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockDeviceOrientation): (LayoutTestController::deviceOrientationClientMock):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::deviceOrientationClientMock): (WebViewHost::deviceOrientationClient): (WebViewHost::reset):
  • DumpRenderTree/chromium/WebViewHost.h:
2:51 AM Changeset in webkit [72070] by Csaba Osztrogonác
  • 6 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected results after r72052.

  • platform/qt/fast/css/pseudo-cache-stale-expected.txt:
  • platform/qt/fast/forms/isindex-placeholder-expected.txt:
  • platform/qt/fast/forms/placeholder-stripped-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt:
2:29 AM Changeset in webkit [72069] by Csaba Osztrogonác
  • 5 edits
    8 adds in trunk/LayoutTests

.

1:21 AM Changeset in webkit [72068] by alex
  • 12 edits in trunk/LayoutTests

2010-11-16 Alejandro G. Castro <alex@igalia.com>

Unreviewed, updated test expectations for GTK and skip tests using
computedStyleIncludingVisitedInfo which is not currently supported
in GTK.

  • platform/gtk/Skipped:
  • platform/gtk/fast/forms/isindex-placeholder-expected.txt:
  • platform/gtk/fast/forms/password-placeholder-expected.txt:
  • platform/gtk/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt:
  • platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.txt:
1:01 AM Changeset in webkit [72067] by Patrick Gansterer
  • 4 edits in trunk/WebKit

2010-11-16 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Remove platform dependent include directories
https://bugs.webkit.org/show_bug.cgi?id=49553

  • CMakeLists.txt:

2010-11-16 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Add platform dependent include directories
https://bugs.webkit.org/show_bug.cgi?id=49553

  • CMakeListsEfl.txt:
12:44 AM Changeset in webkit [72066] by mihaip@chromium.org
  • 4 edits in trunk

2010-11-16 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

fast/images/size-failure.html results in malloc of 2 Gb after switching to WebKit image decoders
https://bugs.webkit.org/show_bug.cgi?id=48634

Re-enable fast/images/size-failure.html now that it passes and doesn't
affect subsequent tests.

  • platform/chromium/test_expectations.txt:

2010-11-16 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

fast/images/size-failure.html results in malloc of 2 Gb after switching to WebKit image decoders
https://bugs.webkit.org/show_bug.cgi?id=48634

Specify the capacity when calling CFDataCreateMutable, which can signal
malloc failures (by returning NULL), unlike CFDataSetLength.

  • platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::RGBA32Buffer::setSize):
12:10 AM Changeset in webkit [72065] by rwlbuis@webkit.org
  • 15 edits in trunk/WebCore

2010-11-15 Rob Buis <rwlbuis@gmail.com>

Reviewed by Dirk Schulze and Darin Adler.

requiredFeatures does not adapt to SVGStringList changes
https://bugs.webkit.org/show_bug.cgi?id=40887

Centralize the const_cast handling and only do it if needed.
Remove the const_cast in all svgAttributeChanged functions and move
it to SVGTest::handleAttributeChange. Add an early return to
handleAttributeChange to avoid unnecessary const_casts.

No tests necessary as functionality has not changed.

  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::svgAttributeChanged):
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::svgAttributeChanged):
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::svgAttributeChanged):
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::svgAttributeChanged):
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::svgAttributeChanged):
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::svgAttributeChanged):
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::svgAttributeChanged):
  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::svgAttributeChanged):
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::svgAttributeChanged):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::svgAttributeChanged):
  • svg/SVGTests.cpp: (WebCore::SVGTests::handleAttributeChange):
  • svg/SVGTests.h:
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::svgAttributeChanged):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::svgAttributeChanged):

Nov 15, 2010:

11:16 PM Changeset in webkit [72064] by mitz@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

Disabled a test that was failing intermittently due to https://bugs.webkit.org/show_bug.cgi?id=49579

Rubber-stamped by Mark Rowe.

  • fast/block/float/015.html: Removed.
  • fast/block/float/015.html-disabled: Copied from LayoutTests/fast/block/float/015.html.
10:05 PM Changeset in webkit [72063] by barraclough@apple.com
  • 5 edits
    3 adds in trunk

Bug 49577 - Function.prototype should be non-configurable

Reviewed by Sam Weinig.

JavaScriptCore:

JSC lazily allocates the prototype property of Function objects.

We check the prototype exists on 'get', but not on 'put'.
If you 'put' without having first done a 'get' you can end up with a configurable
prototype (prototype should only ever be non-configurable).

This is visible in a couple of ways:

  • 'delete' on the property may succeed. (the next access will result in a new, reset prototype object).
  • the prototype may be set to a getter.
  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertyNames):

Reify the prototype property before allowing an enumerate including don't enum properties.

(JSC::JSFunction::put):

Reify the prototype property before any put to it.

LayoutTests:

  • fast/js/script-tests/Object-getOwnPropertyNames.js:
  • fast/js/Object-getOwnPropertyNames-expected.txt:

Object.getOwnPropertyNames should enumerate the 'prototype' property on Functions.

  • fast/js/function-prototype-descriptor.html: Added.
  • fast/js/function-prototype-descriptor-expected.txt: Added.
  • fast/js/script-tests/function-prototype-descriptor.js: Added.

Test the attributes of Functions' prototype properties.

9:35 PM Changeset in webkit [72062] by Dimitri Glazkov
  • 3 edits
    2 adds in trunk

2010-11-15 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r71934): Removing an element with a shadow DOM from under a cursor causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=49569

  • fast/events/remove-shadow-host-crash-expected.txt: Added.
  • fast/events/remove-shadow-host-crash.html: Added.

2010-11-15 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r71934): Removing an element with a shadow DOM from under a cursor causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=49569

Test: fast/events/remove-shadow-host-crash.html

  • rendering/TextControlInnerElements.h: (WebCore::TextControlInnerElement::isShadowNode): (WebCore::TextControlInnerElement::shadowParentNode):
9:26 PM Changeset in webkit [72061] by barraclough@apple.com
  • 2 edits in trunk/WebKit/qt

Fix test broken by earlier patch.

Reviewed by NOBODY build fix.

  • tests/qwebframe/tst_qwebframe.cpp:
9:23 PM Changeset in webkit [72060] by rniwa@webkit.org
  • 7 edits in trunk/WebCore

2010-11-12 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

ScriptElement rather than HTMLScriptElement and SVGScriptElement should have ScriptElementData
https://bugs.webkit.org/show_bug.cgi?id=49469

Moved m_data, scriptCharset, scriptContent, shouldExecuteAsJavaScript, and executeScript from
HTMLScriptElement and SVGScriptElement to ScriptElementData.

Also made insertedIntoDocument, removedFromDocument, childrenChanged, finishParsingChildren,
and handleSourceAttribute of ScriptElement non-static.

No new tests are added since this is a cleanup.

  • dom/ScriptElement.cpp: (WebCore::ScriptElement::scriptCharset): Added. (WebCore::ScriptElement::scriptContent): Added. (WebCore::ScriptElement::shouldExecuteAsJavaScript): Added. (WebCore::ScriptElement::executeScript): Added. (WebCore::ScriptElement::insertedIntoDocument): Made non-static. Accesses m_data. (WebCore::ScriptElement::removedFromDocument): Ditto. (WebCore::ScriptElement::childrenChanged): Ditto. (WebCore::ScriptElement::finishParsingChildren): Ditto. (WebCore::ScriptElement::handleSourceAttribute): Ditto.
  • dom/ScriptElement.h: Moved the declaration of ScriptElement after that of ScriptElementData because ScriptElement has to instantiate ScriptElementData. (WebCore::ScriptElement::ScriptElement): Initializes m_data.
  • html/HTMLScriptElement.cpp: Removed scriptCharset, scriptContent, shouldExecuteAsJavaScript, and executeScript. (WebCore::HTMLScriptElement::HTMLScriptElement): Initializes ScriptElement instead of ScriptElementData. (WebCore::HTMLScriptElement::childrenChanged): Calls ScriptElement::childrenChanged. (WebCore::HTMLScriptElement::parseMappedAttribute): Calls ScriptElement::handleSourceAttribute. (WebCore::HTMLScriptElement::finishParsingChildren): Calls ScriptElement::finishParsingChildren. (WebCore::HTMLScriptElement::insertedIntoDocument): Calls ScriptElement::insertedIntoDocument. (WebCore::HTMLScriptElement::removedFromDocument): Calls ScriptElement::removedFromDocument.
  • html/HTMLScriptElement.h:
  • svg/SVGScriptElement.cpp: Removed scriptCharset, scriptContent, shouldExecuteAsJavaScript, and executeScript. (WebCore::SVGScriptElement::SVGScriptElement): Initializes ScriptElement instead of ScriptElementData. (WebCore::SVGScriptElement::svgAttributeChanged): Calls ScriptElement::handleSourceAttribute. (WebCore::SVGScriptElement::insertedIntoDocument): Calls ScriptElement::insertedIntoDocument. (WebCore::SVGScriptElement::removedFromDocument): Calls ScriptElement::removedFromDocument. (WebCore::SVGScriptElement::childrenChanged): Calls ScriptElement::childrenChanged. (WebCore::SVGScriptElement::finishParsingChildren): Calls ScriptElement::finishParsingChildren.
  • svg/SVGScriptElement.h:
9:13 PM Changeset in webkit [72059] by tkent@chromium.org
  • 23 edits in trunk/WebCore

Refactor HTMLInputElement: Move a part of HTMLInputElement::
defaultEventHandler() to InputTypes.
https://bugs.webkit.org/show_bug.cgi?id=48317

Reviewed by Darin Adler.

Move out the followings to InputTypes:

  • click event processing,
  • the first keydown event processing, and
  • DOMActivate event processing.

Move m_xPos and m_yPos from HTMLInputElement to ImageInputType as
m_clickLocation. It's ok to move them because they should be valid only
when HTMLInputElement::m_activeSubmit is true. For type=image,
m_activeSubmit is true only in DOMActivate event handling. So we reset
m_clickLocation in handleDOMActivateEvent() with Event::underlyingEvent().

No new tests because this is just a refactoring.

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::handleKeydownEvent):

  • html/BaseDateAndTimeInputType.h:
  • html/FileInputType.cpp:

(WebCore::FileInputType::handleDOMActivateEvent):

  • html/FileInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::defaultEventHandler):

  • html/HTMLInputElement.h:
  • html/ImageInputType.cpp:

(WebCore::ImageInputType::appendFormData):
(WebCore::ImageInputType::handleDOMActivateEvent):

  • html/ImageInputType.h:
  • html/InputType.cpp:

(WebCore::InputType::handleClickEvent):
(WebCore::InputType::handleDOMActivateEvent):
(WebCore::InputType::handleKeydownEvent):

  • html/InputType.h:
  • html/NumberInputType.cpp:

(WebCore::NumberInputType::handleKeydownEvent):

  • html/NumberInputType.h:
  • html/RadioInputType.cpp:

(WebCore::RadioInputType::handleClickEvent):

  • html/RadioInputType.h:
  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleKeydownEvent):

  • html/RangeInputType.h:
  • html/ResetInputType.cpp:

(WebCore::ResetInputType::handleDOMActivateEvent):

  • html/ResetInputType.h:
  • html/SubmitInputType.cpp:

(WebCore::SubmitInputType::handleDOMActivateEvent):

  • html/SubmitInputType.h:
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::handleKeydownEvent):
(WebCore::TextFieldInputType::handleKeydownEventForSpinButton):

  • html/TextFieldInputType.h:
9:12 PM Changeset in webkit [72058] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-11-15 Nat Duca <nduca@chromium.org>

Reviewed by Darin Fisher.

[chromium] Make WebWidget actively notify client when compositing enables.
https://bugs.webkit.org/show_bug.cgi?id=49396

  • public/WebWidgetClient.h: (WebKit::WebWidgetClient::didAcceleratedCompositingEnable):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::resize): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::setRootLayerNeedsDisplay): (WebKit::WebViewImpl::scrollRootLayerRect): (WebKit::WebViewImpl::invalidateRootLayerRect): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
8:53 PM Changeset in webkit [72057] by crogers@google.com
  • 2 edits
    2 adds in trunk/WebCore

2010-11-15 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioNode custom bindings
https://bugs.webkit.org/show_bug.cgi?id=49119

No new tests since audio API is not yet implemented.

  • bindings/js/JSAudioNodeCustom.cpp: Added. (WebCore::JSAudioNode::connect): (WebCore::JSAudioNode::disconnect):
  • bindings/v8/custom/V8AudioNodeCustom.cpp: Added. (WebCore::V8AudioNode::connectCallback): (WebCore::V8AudioNode::disconnectCallback):
  • webaudio/AudioNode.idl:
8:45 PM Changeset in webkit [72056] by hyatt@apple.com
  • 3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=49570

Reviewed by Dan Bernstein.

Put italics specialization check back in CSSFontSelector. I had to back it out, since it broke
a layout test, and the issue was that local font fallback fonts should not be considered by the
specialization check (since you never want to pick a fallback over an actual @font-face rule if
the @font-face rule can handle it).

  • css/CSSFontFace.h:

(WebCore::CSSFontFace::create):
(WebCore::CSSFontFace::isLocalFallback):
(WebCore::CSSFontFace::CSSFontFace):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::compareFontFaces):

8:13 PM Changeset in webkit [72055] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-11-15 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] ZoomTextOnly doesn't work
https://bugs.webkit.org/show_bug.cgi?id=49568

Check QWebSettings::ZoomTextOnly attribute before applying zoom

  • Api/qwebframe.cpp: (QWebFrame::textSizeMultiplier): (QWebFrame::setZoomFactor): (QWebFrame::zoomFactor):
  • Api/qwebframe_p.h: (QWebFramePrivate::QWebFramePrivate):
7:37 PM Changeset in webkit [72054] by Patrick Gansterer
  • 3 edits in trunk

2010-11-15 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Add additional flags to cmakeconfig.h
https://bugs.webkit.org/show_bug.cgi?id=49556

  • cmake/OptionsEfl.cmake:
  • cmakeconfig.h.cmake:
6:13 PM Changeset in webkit [72053] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-15 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Fix duplicated entries added in r72045.
6:09 PM Changeset in webkit [72052] by adele@apple.com
  • 23 edits in trunk

WebCore: Fix for: https://bugs.webkit.org/show_bug.cgi?id=49452
Placeholder should not be swapped in and out of the text control's inner text element

Reviewed by Darin Adler.

There's no need to swap the placeholder text in and out of the inner text element. Instead, just paint the text.
This reduces complexity and makes it easier to make independent decisions about the placeholder text and the text control value.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValueFromRenderer):

Since updatePlaceholderVisibility checks the value, set the value before calling updatePlaceholderVisibility.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::updatePlaceholderVisibility): Remove code that set the inner text value with the placeholder text.
(WebCore::RenderTextControl::paintObject): Paint the placeholder text during the background phase.

  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::nodeAtPoint): Remove custom hit testing that tried to avoid hitting the placeholder text at the wrong time.
(WebCore::RenderTextControlMultiLine::updateFromElement): Remove code that set the inner text value with the placeholder text.
(WebCore::RenderTextControlMultiLine::createInnerTextStyle): Remove code that created the inner text style based on the placeholder pseudoelement.
(WebCore::RenderTextControlMultiLine::textBoxInsetLeft): Added.
(WebCore::RenderTextControlMultiLine::textBoxInsetRight): Added.

  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::updateFromElement): Remove code that set the inner text value with the placeholder text.
(WebCore::RenderTextControlSingleLine::createInnerTextStyle): Remove code that created the inner text style based on the placeholder pseudoelement.
(WebCore::RenderTextControlSingleLine::textBoxInsetLeft): Added.
(WebCore::RenderTextControlSingleLine::textBoxInsetRight): Added.

  • rendering/RenderTextControlSingleLine.h:
  • rendering/TextControlInnerElements.cpp: Removed custom hit testing that tried to avoid hitting the placeholder text at the wrong time.

LayoutTests: Test for: https://bugs.webkit.org/show_bug.cgi?id=49452
Placeholder should not be swapped in and out of the text control's inner text element

Reviewed by Darin Adler.

The only visual change that occurred is in pseudo-cache-stale.html. The placeholder text did not
use to paint over the spot where the cancel button will display. Since the cancel button is not
present when the placeholder is drawn, now the placeholder text can draw to the edge of the field.

  • platform/mac/fast/css/pseudo-cache-stale-expected.checksum:
  • platform/mac/fast/css/pseudo-cache-stale-expected.png:
  • platform/mac/fast/css/pseudo-cache-stale-expected.txt:
  • platform/mac/fast/forms/isindex-placeholder-expected.txt:
  • platform/mac/fast/forms/password-placeholder-expected.txt:
  • platform/mac/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/mac/fast/forms/placeholder-stripped-expected.txt:
  • platform/mac/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-set-attribute-expected.txt:
6:00 PM Changeset in webkit [72051] by hamaji@chromium.org
  • 3 edits in branches/chromium/552

Merge 71964 - 2010-11-13 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Kent Tamura.

[Chromium] print doesn't work on http://nodejs.org/api.html
https://bugs.webkit.org/show_bug.cgi?id=49304

  • platform/chromium/test_expectations.txt:

2010-11-13 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Kent Tamura.

[Chromium] print doesn't work on http://nodejs.org/api.html
https://bugs.webkit.org/show_bug.cgi?id=49304

  • src/WebFrameImpl.cpp: (WebKit::ChromePrintContext::begin): (WebKit::WebFrameImpl::printBegin):

TBR=hamaji@chromium.org

5:30 PM Changeset in webkit [72050] by barraclough@apple.com
  • 93 edits in trunk

Bug 49488 - Only add source specific information to exceptions in Interpreter::throwException

Reviewed by Geoff Garen.

JavaScriptCore:

Three types of source location information are added to errors.

(1) Divot information.

This was added with the intention of using it to provide better source highlighting in the inspector.
We may still want to do so, but we probably should not be exposing these values in a manner visible to
user scripts – only through an internal C++ interface. The code adding divot properties to objects has
been removed.

(2) Line number information.

Line number information is presently sometimes added at the point the exception is created, and sometimes
added at the point the exception passes through throwException. Change this so that throwException has
the sole responsibility for adding line number and source file information.

(3) Source snippets in the message of certain type errors (e.g. 'doc' in Result of expression 'doc' [undefined] is not an object.).

These messages are currently created at the point the exceptions is raised. Instead reformat the message
such that the source snippet is located at the end (Result of expression 'b1' [undefined] is not an object.
becomes 'undefined' is not an object (evaluating 'b1.property')), and append these to the message at
the in throw Exception. This presents a number of advantages:

  • we no longer need to have source location information to create these TypeErrors.
  • we can chose to append source location information in other error messages, including those where passing source location to the point of construction would be inconvenient.
  • we can chose in future to omit to append source location information when running in a non-debug mode.

This also cleans up some error output, e.g. removing double brackets ('[[]]') around objects in output,
removing double periods (..) at end of lines, and adding slightly more context to some errors.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::expressionRangeForBytecodeOffset):

  • Separated called to access line and range information.
  • bytecode/CodeBlock.h:
    • Separated called to access line and range information.
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::resolve):
(JSC::Interpreter::resolveSkip):
(JSC::Interpreter::resolveGlobal):
(JSC::Interpreter::resolveGlobalDynamic):
(JSC::Interpreter::resolveBaseAndProperty):
(JSC::isInvalidParamForIn):
(JSC::isInvalidParamForInstanceOf):

  • Update parameters passed to error constructors.

(JSC::appendSourceToError):

  • Update message property to add location information (previously added in createErrorMessage, in ExceptionHelpers)

(JSC::Interpreter::throwException):

  • Updated to call appendSourceToError.

(JSC::Interpreter::privateExecute):

  • Update parameters passed to error constructors.
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • Update parameters passed to error constructors.
  • runtime/Error.cpp:

(JSC::addErrorInfo):
(JSC::hasErrorInfo):

  • Removed divot properties.
  • runtime/Error.h:
    • Removed divot properties.
  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::ErrorInstance):

  • Initialize new property.
  • runtime/ErrorInstance.h:

(JSC::ErrorInstance::appendSourceToMessage):
(JSC::ErrorInstance::setAppendSourceToMessage):
(JSC::ErrorInstance::clearAppendSourceToMessage):

  • Added flag to check for errors needing location information appending.

(JSC::ErrorInstance::isErrorInstance):

  • Added virtual method to check for ErrorInstances.
  • runtime/ExceptionHelpers.cpp:

(JSC::createUndefinedVariableError):
(JSC::createInvalidParamError):
(JSC::createNotAConstructorError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):

  • Update parameters passed to error constructors, stopped adding line number information early, changed TypeError messages.
  • runtime/ExceptionHelpers.h:
    • Updated function signatures.
  • runtime/JSFunction.cpp:

(JSC::callHostFunctionAsConstructor):

  • Update parameters passed to error constructors.
  • runtime/JSObject.h:

(JSC::JSObject::isErrorInstance):

  • Added virtual method to check for ErrorInstances.

LayoutTests:

Updated results to account for changes in TypeError messages.
(e.g. Result of expression 'b1' [undefined] is not an object. -> 'undefined' is not an object (evaluating 'b1.property')).

  • fast/css/font-face-descriptor-multiple-values-parsing-expected.txt:
  • fast/css/resources/font-face-descriptor-multiple-values-parsing.js:
  • fast/css/variables/color-hex-test-expected.txt:
  • fast/dom/HTMLSelectElement/named-options-expected.txt:
  • fast/dom/Range/getClientRects-expected.txt:
  • fast/dom/SelectorAPI/dumpNodeList-almost-strict-expected.txt:
  • fast/dom/SelectorAPI/dumpNodeList-expected.txt:
  • fast/forms/select-namedItem-expected.txt:
  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/date-toisostring-expected.txt:
  • fast/js/delete-getters-setters-expected.txt:
  • fast/js/exception-expression-offset-expected.txt:
  • fast/js/exception-for-nonobject-expected.txt:
  • fast/js/exception-thrown-from-new-expected.txt:
  • fast/js/exception-thrown-from-new.html:
  • fast/js/instance-of-immediates-expected.txt:
  • fast/js/script-tests/exception-expression-offset.js:

(testException):

  • fast/js/sputnik/Conformance/08_Types/8.6_The_Object_Type/8.6.2_Internal_Properties_and_Methods/S8.6.2_A7-expected.txt:
  • fast/js/sputnik/Conformance/13_Function_Definition/S13_A17_T2-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/S15.1_A1_T1-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/S15.1_A1_T2-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/S15.1_A2_T1-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.2_Object.prototype.toString/S15.2.4.2_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.3_Object.prototype.toLocaleString/S15.2.4.3_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.4_Object.prototype.valueOf/S15.2.4.4_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.5_Object.prototype.hasOwnProperty/S15.2.4.5_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.6_Object.prototype.isPrototypeOf/S15.2.4.6_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.7_Object.prototype.propertyIsEnumerable/S15.2.4.7_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/S15.2.4_A3-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/S15.2.4_A4-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.4/15.3.4.2_Function.prototype.toString/S15.3.4.2_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.4/S15.3.4_A5-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T4-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.13_String.prototype.slice/S15.5.4.13_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.15_String.prototype.substring/S15.5.4.15_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.17_String.prototype.toLocaleLowerCase/S15.5.4.17_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.7_String.prototype.indexOf/S15.5.4.7_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.8_String.prototype.lastIndexOf/S15.5.4.8_A7-expected.txt:
  • fast/xsl/transform-xhr-doc-expected.txt:
  • http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • java/lc3/ArrayMethods/byte-001-expected.txt:
  • java/lc3/CallStatic/object-001-expected.txt:
  • java/lc3/ConvertBoolean/boolean-007-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-008-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-009-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-010-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-011-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-012-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-013-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-014-expected.txt:
  • java/lc3/ConvertNull/null-001-expected.txt:
  • java/lc3/ConvertNumber/number-011-expected.txt:
  • java/lc3/ConvertString/string-006-expected.txt:
  • java/lc3/ConvertString/string-007-n-expected.txt:
  • java/lc3/ConvertUndefined/undefined-002-expected.txt:
  • java/lc3/ConvertUndefined/undefined-003-expected.txt:
  • java/lc3/JSBoolean/boolean-005-n-expected.txt:
  • java/lc3/JSNumber/ToDouble-002-expected.txt:
  • java/lc3/JSObject/ToJSObject-001-expected.txt:
  • java/lc3/JSObject/ToObject-001-expected.txt:
  • java/lc3/JavaObject/JavaObjectFieldOrMethod-001-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.imageData.create1.type-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.imageData.create2.type-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.imageData.get.type-expected.txt:
  • platform/mac/compositing/reflections/reflection-opacity-expected.txt:
  • platform/mac/fast/css/variables/remove-variable-test-expected.txt:
  • platform/mac/fast/css/variables/set-variable-test-expected.txt:
  • platform/mac/fast/css/variables/variable-iteration-test-expected.txt:
  • platform/mac/fast/events/updateLayoutForHitTest-expected.txt:
  • platform/mac/svg/custom/createelement-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug53690-1-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug92868_1-expected.txt:
  • plugins/npruntime/object-from-destroyed-plugin-expected.txt:
  • plugins/npruntime/plugin-scriptable-object-invoke-default-expected.txt:
  • svg/custom/use-nested-missing-target-removed-expected.txt:
  • svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
5:23 PM Changeset in webkit [72049] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-11-15 Andreas Kling <kling@webkit.org>

Unreviewed buildfix (Qt WebKit2 minimal)

  • platform/qt/CookieJarQt.cpp: Add missing <QStringList> include.
5:22 PM Changeset in webkit [72048] by crogers@google.com
  • 10 edits in trunk/WebCore

2010-11-15 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add Event and EventListener hooks for JavaScriptAudioNode and AudioProcessingEvent
https://bugs.webkit.org/show_bug.cgi?id=49357

No new tests since audio API is not yet implemented.

  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
  • dom/Event.cpp: (WebCore::Event::isAudioProcessingEvent):
  • dom/Event.h:
  • dom/EventNames.h:
  • dom/EventTarget.cpp: (WebCore::EventTarget::toJavaScriptAudioNode):
  • dom/EventTarget.h:
5:05 PM Changeset in webkit [72047] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

A minor style fix in StyledElement.cpp.

  • dom/StyledElement.cpp: (WebCore::StyledElement::addCSSProperty): (WebCore::StyledElement::addCSSImageProperty):
5:03 PM Changeset in webkit [72046] by ap@apple.com
  • 5 edits in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=49565
Remove Attr.style accessor

  • dom/Attr.idl: Only keep the accessor for Objective C API. Inspector doesn't seem to need it any more.
4:40 PM Changeset in webkit [72045] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-15 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Update for the recent status of Chromium-Linux DRT.
3:30 PM Changeset in webkit [72044] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

Unskip fast/forms/submit-form-attributes.html.

  • platform/mac-leopard/Skipped:
3:04 PM Changeset in webkit [72043] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/552

Merge 72040

BUG=63031

2:59 PM Changeset in webkit [72042] by Beth Dakin
  • 2 edits in trunk/WebCore

Fix for https://bugs.webkit.org/show_bug.cgi?id=49555
Frame::scalePage() should treat the origin as an absolute
coordinate
-and corresponding-
<rdar://problem/8667138>

Reviewed by Darin Adler.

  • page/Frame.cpp:

(WebCore::Frame::scalePage):

2:30 PM Changeset in webkit [72041] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fixed a weird typo

2:27 PM Changeset in webkit [72040] by mitz@apple.com
  • 4 edits
    2 adds in trunk

<rdar://problem/8662770> Error image has incorrect size when a custom font is used

Reviewed by Darin Adler.

WebCore:

Test: fast/images/style-access-during-imageChanged-crash.html

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::RenderImage): Added initialization of m_needsToSetSizeForAltText.
(WebCore::RenderImage::imageSizeForError): Factored the non-alt-text dependent size computation
out of setImageSizeForAltText() into this function.
(WebCore::RenderImage::setImageSizeForAltText): Changed to use imageSizeForError().
(WebCore::RenderImage::styleDidChange): Added. If m_needsToSetSizeForAltText is true, sets the
intrinsic size and calls imageDimensionsChanged() as needed to cause layout or invalidation.
(WebCore::RenderImage::imageChanged): Moved som comed from here...
(WebCore::RenderImage::imageDimensionsChanged): ...to here.

  • rendering/RenderImage.h:

LayoutTests:

  • fast/images/style-access-during-imageChanged-crash-expected.txt: Added.
  • fast/images/style-access-during-imageChanged-crash.html: Added.
2:16 PM Changeset in webkit [72039] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit2

2010-11-15 Andreas Kling <kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Make sure qwkpage.h and qwkpreferences.h are copied into includes/WebKit2

  • UIProcess/API/qt/WKView.h:
2:08 PM Changeset in webkit [72038] by andersca@apple.com
  • 4 edits in trunk/WebCore

ASSERTION (r72003): Assertion failure when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=49561

Reviewed by Dimitri Glazkov.

r72003 added the 'formaction' URL attribute to HTMLButtonElement and HTMLInputElement,
but did not add the attribute to the isURLAttribute which lead to assertion failures
when running the layout tests with a debug build.

  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::isURLAttribute):

  • html/HTMLButtonElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isURLAttribute):

2:07 PM Changeset in webkit [72037] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit2

2010-11-15 Andreas Kling <kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Use $${PYTHON} rather than "python" to execute Python scripts

Fixes building with the old Python that currently ships with Scratchbox.

  • DerivedSources.pro:
1:52 PM Changeset in webkit [72036] by ap@apple.com
  • 2 edits in trunk/WebCore

2010-11-15 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=49559
DOMWindow.getComputedStyle pseudo element argument lacks ConvertUndefinedOrNullToNullString

No observable change in behavior, so no tests.

  • page/DOMWindow.idl: Added ConvertUndefinedOrNullToNullString.
1:50 PM Changeset in webkit [72035] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

r72003 caused fast/forms/submit-form-attributes.html to crash
DumpRenderTree on the Leopard Intel Debug (Tests) bot. Skip this test
until the failure is resolved.
https://bugs.webkit.org/show_bug.cgi?id=49562

  • platform/mac-leopard/Skipped:
1:46 PM Changeset in webkit [72034] by andreas.kling@nokia.com
  • 3 edits in trunk/WebCore

2010-11-15 Andreas Kling <kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Make WTF_USE_MEEGOTOUCH available for WebKit2 as well

Move this into WebCore/features.pri which is used by both WebCore and WebKit2.

  • WebCore.pro:
  • features.pri:
1:42 PM Changeset in webkit [72033] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-11-15 Martin Robinson <mrobinson@igalia.com>

Build fix for GTK+.

  • GNUmakefile.am: Add some missing generated files to the source list.
1:38 PM Changeset in webkit [72032] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-11-15 Zhenyao Mo <zmo@google.com>

Ubreviewed, remove an empty line that causes the test to fail.

  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view-expected.txt:
1:33 PM Changeset in webkit [72031] by abecsi@webkit.org
  • 7 edits in trunk/WebKitTools

2010-11-15 Andras Becsi <abecsi@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Avoid polling in WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=49542

Make the WK2 testing session about 10-15% faster and decrease random flakiness
resulting from timing skew by removing the millisecond polling from TestControllerQt.

  • WebKitTestRunner/TestController.cpp: (WTR::TestController::didFinishLoadForFrame):
  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
  • WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::notifyDone): Add method stub.
  • WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::TestControllerRunLoop::instance): (WTR::TestControllerRunLoop::start): (WTR::TestControllerRunLoop::stop): (WTR::TestControllerRunLoop::TestControllerRunLoop): (WTR::TestControllerRunLoop::timerEvent): (WTR::TestController::notifyDone): (WTR::TestController::platformRunUntil):
  • WebKitTestRunner/win/TestControllerWin.cpp: (WTR::TestController::notifyDone): Add method stub.
1:29 PM Changeset in webkit [72030] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-11-15 Zhenyao Mo <zmo@google.com>

Unreviewed, update gpu test expectations.

  • platform/chromium-gpu/test_expectations.txt:
1:27 PM Changeset in webkit [72029] by beidson@apple.com
  • 2 edits in trunk/WebKit2
  • win/WebKit2Generated.make:

Reviewed by a better attempt at a Windows build fix.

1:20 PM Changeset in webkit [72028] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore.
1:17 PM Changeset in webkit [72027] by beidson@apple.com
  • 2 edits in trunk/WebKit2
  • win/WebKit2Generated.make: Add new API headers here.

Reviewed by my attempt to fix the Windows build

1:17 PM Changeset in webkit [72026] by kbr@google.com
  • 2 edits in trunk/WebCore

2010-11-15 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Avoid copying of SkBitmap in LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=49560

Ran CSS 3D content to test. No other new tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateRootLayerTextureRect):
1:04 PM Changeset in webkit [72025] by kbr@google.com
  • 3 edits in trunk/WebKit/chromium

2010-11-15 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Remove assumption that GL functions are function pointers
https://bugs.webkit.org/show_bug.cgi?id=49486

Added appropriate extension queries and no longer assume that GL
function names are function pointers which can be tested.

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes): (WebKit::WebGraphicsContext3DDefaultImpl::resolveMultisampledFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::generateMipmap): (WebKit::WebGraphicsContext3DDefaultImpl::getString):
  • src/WebGraphicsContext3DDefaultImpl.h:
12:47 PM Changeset in webkit [72024] by beidson@apple.com
  • 18 edits
    5 adds in trunk/WebKit2

Finish off <rdar://problem/8613727> and https://bugs.webkit.org/show_bug.cgi?id=48720
Customizable context menu support in WebKit2.

Reviewed by Sam Weinig.

  • Adds an API-level WKContextMenuItem.
  • Round trips through both the InjectedBundle client and the new PageContextMenuClient before actually displaying the menu.
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • Shared/API/c/WKBase.h:
  • Shared/API/c/WKContextMenuItem.cpp: Added.

(WKContextMenuItemGetTypeID):
(WKContextMenuItemCreateAsAction):
(WKContextMenuItemCreateAsCheckableAction):
(WKContextMenuItemCreateAsSubmenu):
(WKContextMenuItemSeparatorItem):
(WKContextMenuItemGetTag):
(WKContextMenuItemGetType):
(WKContextMenuItemCopyTitle):
(WKContextMenuItemGetEnabled):
(WKContextMenuItemGetChecked):
(WKContextMenuCopySubmenuItems):

  • Shared/API/c/WKContextMenuItem.h: Added.
  • Shared/API/c/WKContextMenuItemTypes.h: Added.
  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
(WebKit::toImpl):

  • Shared/WebContextMenuItem.cpp:

(WebKit::WebContextMenuItem::create):
(WebKit::WebContextMenuItem::separatorItem):
(WebKit::WebContextMenuItem::submenuItemsAsImmutableArray):

  • Shared/WebContextMenuItem.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageContextMenuClient):
(WKPageSetPageFindClient):
(WKPageSetPageLoaderClient):
(WKPageSetPagePolicyClient):
(WKPageSetPageUIClient):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageContextMenuClient.cpp: Added.

(WebKit::WebPageContextMenuClient::getContextMenuFromProposedMenu):

  • UIProcess/WebPageContextMenuClient.h: Added.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeContextMenuClient):
(WebKit::WebPageProxy::showContextMenu):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:

(WebKit::InjectedBundlePageContextMenuClient::getCustomMenuFromDefaultItems):

  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::getCustomMenuFromDefaultItems):

  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show):

12:46 PM Changeset in webkit [72023] by andersca@apple.com
  • 10 edits in trunk/WebKit2

Add shouldDecodeSourceDataOfMIMEType WKContextDownloadClient callback
https://bugs.webkit.org/show_bug.cgi?id=49558

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKContext.h:

Add shouldDecodeSourceDataOfMIMEType callback.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::shouldDecodeSourceDataOfMIMEType):
Call WebDownloadClient::shouldDecodeSourceDataOfMIMEType.

(WebKit::DownloadProxy::decideDestinationWithSuggestedFilename):
Add allowOverwrite out parameter.

  • UIProcess/Downloads/DownloadProxy.h:
  • UIProcess/Downloads/DownloadProxy.messages.in:

Add ShouldDecodeSourceDataOfMIMEType message.

  • UIProcess/WebDownloadClient.cpp:

(WebKit::WebDownloadClient::shouldDecodeSourceDataOfMIMEType):
Call the WKContextDownloadClient.

(WebKit::WebDownloadClient::decideDestinationWithSuggestedFilename):
Add allowOverwrite out parameter.

  • UIProcess/WebDownloadClient.h:
  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::shouldDecodeSourceDataOfMIMEType):
Send the ShouldDecodeSourceDataOfMIMEType message.

(WebKit::Download::decideDestinationWithSuggestedFilename):
Add allowOverwrite reply parameter.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(-[WKDownloadAsDelegate download:shouldDecodeSourceDataOfMIMEType:]):
Call Download::shouldDecodeSourceDataOfMIMEType.

(-[WKDownloadAsDelegate download:decideDestinationWithSuggestedFilename:]):
Add allowOverwrite parameter.

12:31 PM Changeset in webkit [72022] by inferno@chromium.org
  • 1 edit in branches/chromium/552/WebCore/page/EventHandler.cpp

Merge 72013

BUG=63051

12:25 PM Changeset in webkit [72021] by vangelis@chromium.org
  • 8 edits
    2 adds in trunk/WebCore

2010-11-15 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Fixes layer opacity implementation of composited layers
https://bugs.webkit.org/show_bug.cgi?id=49233

This introduces a fairly drastic change in how LayerRendererChromium draws
composited layers. Layers that have non-zero opacity as well as layers that
clip their descendants (and have non-trivial transforms) are now first
rendered onto off-screen surfaces (RenderSurfaceChromium's). The compositing
operation now consists of two distinct phases: First a hierarchical traversal
of the layer tree to compute the layer transforms, determine what the necessary
RenderSurfaces are and sort layer that preserve-3d based on their z-value. A second
pass goes through all the RenderSurfaces discovered by the first pass and updates
their contents.
Additional significant side-effects of this change are:

  1. Depth buffer and depth testing is no longer used. Drawing relies on a painter's algorithm to render layers with the preserves-3d property from back to front using the Z coordinate of their center. This will further be improved in the future with the intoduction of a BSP tree to properly deal with intersecting layers.
  2. Compositor no longer uses the stencil buffer to do clipping. Clipping is now performed by rendering layer subtrees into an offscreen buffer and setting the appropriate scissor and viewport transformation.

Tests: abs-position-inside-opacity.html (for the opacity implementation)

and the rest of the compositing layout tests to verify that
everything still works.

  • WebCore.gypi:
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::cleanupResources): (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::calculateClippedUpdateRect): (WebCore::ContentLayerChromium::updateContents):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::cleanupResources): (WebCore::LayerChromium::createRenderSurface): (WebCore::LayerChromium::descendantsDrawContent): (WebCore::LayerChromium::descendantsDrawContentRecursive):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::drawTransform): (WebCore::LayerChromium::layerRenderer):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::orthoMatrix): (WebCore::isScaleOrTranslation): (WebCore::LayerRendererChromium::compareLayerZ): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::prepareToDrawLayers): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::updateLayersRecursive): (WebCore::LayerRendererChromium::useRenderSurface): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::setScissorToRect): (WebCore::LayerRendererChromium::setDrawViewportRect): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: Added. (WebCore::RenderSurfaceChromium::RenderSurfaceChromium): (WebCore::RenderSurfaceChromium::~RenderSurfaceChromium): (WebCore::RenderSurfaceChromium::cleanupResources): (WebCore::RenderSurfaceChromium::layerRenderer): (WebCore::RenderSurfaceChromium::prepareContentsTexture):
  • platform/graphics/chromium/RenderSurfaceChromium.h: Added. (WebCore::RenderSurfaceChromium::contentRectCenter): (WebCore::RenderSurfaceChromium::contentRect):
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::cleanupResources):
12:16 PM Changeset in webkit [72020] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-11-15 Martin Robinson <mrobinson@igalia.com>

Reviewed by Andreas Kling.

[GTK] gdk_pixbuf_get_from_surface from GtkVersioning.h is broken on GTK+ 2 builds
https://bugs.webkit.org/show_bug.cgi?id=49549

No new tests. This can be verified by loading any existing vertical text test
in GtkLauncher and noticing the lack of CRITICAL GLib exceptions. There's currently
no automatic way of verifying custom cursors.

  • platform/gtk/GtkVersioning.c: (gdk_pixbuf_get_from_surface): Reverse a sanity check in this method to be correct.
11:59 AM Changeset in webkit [72019] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-11-15 Zhenyao Mo <zmo@google.com>

Unreviewed, skip failing WebGL test.

  • platform/mac-snowleopard/Skipped:
11:48 AM Changeset in webkit [72018] by andersca@apple.com
  • 13 edits in trunk/WebKit2

Add decideDestinationWithSuggestedFilename WKContextDownloadClient callback
https://bugs.webkit.org/show_bug.cgi?id=49554

Reviewed by Sam Weinig.

  • Platform/CoreIPC/MessageSender.h:

(CoreIPC::MessageSender::sendSync):
Add sendSync capabilities to Messagesender.

  • UIProcess/API/C/WKContext.h:

AdddecideDestinationWithSuggestedFilename callback.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::decideDestinationWithSuggestedFilename):
Call WebDownloadClient::decideDestinationWithSuggestedFilename.

  • UIProcess/Downloads/DownloadProxy.messages.in:

Add DecideDestinationWithSuggestedFilename.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::didReceiveSyncMessage):
Process MessageClassDownloadProxy messages.

  • UIProcess/WebDownloadClient.cpp:

(WebKit::WebDownloadClient::decideDestinationWithSuggestedFilename):
Ask the WKContextDownloadClient for the destination.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveSyncMessage):
MessageClassDownloadProxy messages should go to the WebContext.

  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::decideDestinationWithSuggestedFilename):
Send the DecideDestinationWithSuggestedFilename message.

  • WebProcess/Downloads/Download.h:
  • WebProcess/Downloads/mac/DownloadMac.mm:

(-[WKDownloadAsDelegate download:decideDestinationWithSuggestedFilename:]):
call Download::decideDestinationWithSuggestedFilename and set the destination.

11:39 AM Changeset in webkit [72017] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

2010-11-12 Jer Noble <jer.noble@apple.com>

Reviewed by Brady Eidson.

Can't view HTML5 video when running Safari with an authenticated proxy server
<rdar://problem/8351926>


  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie):
11:08 AM Changeset in webkit [72016] by andreas.kling@nokia.com
  • 9 edits in trunk/WebKit2

2010-11-15 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[WK2][Qt] Add "page snapshot" functionality to tiled backing store

Original patch by Antti Koivisto.

Add a way to take a snapshot of a specific part of the page, at a specific scale.
Only implemented for the tiled drawing area.

  • Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: New message: TakeSnapshot.
  • Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: New message: SnapshotTaken.
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::takeSnapshot): Expose the snapshot functionality.
  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::didReceiveMessage): (WebKit::TiledDrawingAreaProxy::takeSnapshot):
  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp: (WebKit::TiledDrawingAreaProxy::snapshotTaken):
  • WebProcess/WebPage/TiledDrawingArea.cpp: (WebKit::TiledDrawingArea::didReceiveMessage):
10:58 AM Changeset in webkit [72015] by Martin Robinson
  • 1 edit
    2 adds in trunk/LayoutTests

2010-11-15 Martin Robinson <mrobinson@igalia.com>

[GTK] Navigation policy decision API needs to include the DOM node that the decision originated from
https://bugs.webkit.org/show_bug.cgi?id=49551

Add GTK+-specific results for these tests which do policy delegate dumps,
until GTK+ can produce the "originating from" information.

  • platform/gtk/fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Added.
  • platform/gtk/fast/forms/mailto/formenctype-attribute-input-html-expected.txt: Added.
10:45 AM Changeset in webkit [72014] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-11-15 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt:
10:37 AM Changeset in webkit [72013] by inferno@chromium.org
  • 2 edits in trunk/WebCore

2010-11-14 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Event dispatch call can blow away the node's renderer initialized
before the call in updateSelectionForMouseDrag function. We need
to initialize it after the call.
https://bugs.webkit.org/show_bug.cgi?id=49524

  • page/EventHandler.cpp: (WebCore::EventHandler::updateSelectionForMouseDrag):
9:42 AM Changeset in webkit [72012] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-11-12 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

[Chromium] fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=48142

  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view.html: Cleanup the test, hoping to stop flaky crashes on chromium bots.
9:35 AM Changeset in webkit [72011] by Martin Robinson
  • 2 edits
    95 adds in trunk/LayoutTests

2010-11-15 Martin Robinson <mrobinson@igalia.com>

Add some baselines for new tests and skip a HTML5 meter test until
GTK+ supports rendering the meter element.

  • platform/gtk/Skipped: Skip meter test.
  • platform/gtk/fast/block/basic/truncation-rtl-expected.txt: Added.
  • platform/gtk/fast/blockflow/background-horizontal-bt-expected.txt: Added.
  • platform/gtk/fast/blockflow/background-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/blockflow/background-vertical-rl-expected.txt: Added.
  • platform/gtk/fast/blockflow/basic-vertical-line-expected.txt: Added.
  • platform/gtk/fast/blockflow/body-direction-propagation-blocked-expected.txt: Added.
  • platform/gtk/fast/blockflow/body-direction-propagation-expected.txt: Added.
  • platform/gtk/fast/blockflow/body-writing-mode-propagation-blocked-expected.txt: Added.
  • platform/gtk/fast/blockflow/body-writing-mode-propagation-expected.txt: Added.
  • platform/gtk/fast/blockflow/border-image-horizontal-bt-expected.txt: Added.
  • platform/gtk/fast/blockflow/border-image-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/blockflow/border-image-vertical-rl-expected.txt: Added.
  • platform/gtk/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/blockflow/border-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/blockflow/box-shadow-horizontal-bt-expected.txt: Added.
  • platform/gtk/fast/blockflow/box-shadow-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/blockflow/box-shadow-vertical-rl-expected.txt: Added.
  • platform/gtk/fast/blockflow/broken-ideograph-small-caps-expected.txt: Added.
  • platform/gtk/fast/blockflow/broken-ideographic-font-expected.txt: Added.
  • platform/gtk/fast/blockflow/english-bt-text-expected.txt: Added.
  • platform/gtk/fast/blockflow/english-lr-text-expected.txt: Added.
  • platform/gtk/fast/blockflow/english-rl-text-expected.txt: Added.
  • platform/gtk/fast/blockflow/horizontal-bt-replaced-selection-expected.txt: Added.
  • platform/gtk/fast/blockflow/japanese-lr-selection-expected.txt: Added.
  • platform/gtk/fast/blockflow/japanese-lr-text-expected.txt: Added.
  • platform/gtk/fast/blockflow/japanese-rl-selection-expected.txt: Added.
  • platform/gtk/fast/blockflow/japanese-rl-text-expected.txt: Added.
  • platform/gtk/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
  • platform/gtk/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
  • platform/gtk/fast/blockflow/vertical-font-fallback-expected.txt: Added.
  • platform/gtk/fast/blockflow/vertical-lr-replaced-selection-expected.txt: Added.
  • platform/gtk/fast/blockflow/vertical-rl-replaced-selection-expected.txt: Added.
  • platform/gtk/fast/borders/border-radius-inline-flow-expected.txt: Added.
  • platform/gtk/fast/images/gray-scale-png-with-color-profile-expected.txt: Added.
  • platform/gtk/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.txt: Added.
  • platform/gtk/fast/lists/001-vertical-expected.txt: Added.
  • platform/gtk/fast/lists/002-vertical-expected.txt: Added.
  • platform/gtk/fast/lists/003-vertical-expected.txt: Added.
  • platform/gtk/fast/lists/005-vertical-expected.txt: Added.
  • platform/gtk/fast/lists/006-vertical-expected.txt: Added.
  • platform/gtk/fast/lists/007-vertical-expected.txt: Added.
  • platform/gtk/fast/lists/008-vertical-expected.txt: Added.
  • platform/gtk/fast/lists/009-vertical-expected.txt: Added.
  • platform/gtk/fast/repaint/iframe-scroll-repaint-expected.txt: Added.
  • platform/gtk/fast/repaint/inline-horizontal-bt-overflow-expected.txt: Added.
  • platform/gtk/fast/repaint/inline-vertical-lr-overflow-expected.txt: Added.
  • platform/gtk/fast/repaint/inline-vertical-rl-overflow-expected.txt: Added.
  • platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added.
  • platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Added.
  • platform/gtk/fast/repaint/selection-rl-expected.txt: Added.
  • platform/gtk/fast/table/027-vertical-expected.txt: Added.
  • platform/gtk/fast/table/028-vertical-expected.txt: Added.
  • platform/gtk/fast/table/035-vertical-expected.txt: Added.
  • platform/gtk/fast/table/038-vertical-expected.txt: Added.
  • platform/gtk/fast/table/040-vertical-expected.txt: Added.
  • platform/gtk/fast/table/auto-with-percent-height-vertical-expected.txt: Added.
  • platform/gtk/fast/table/border-collapsing/001-vertical-expected.txt: Added.
  • platform/gtk/fast/table/border-collapsing/002-vertical-expected.txt: Added.
  • platform/gtk/fast/table/border-collapsing/003-vertical-expected.txt: Added.
  • platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt: Added.
  • platform/gtk/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt: Added.
  • platform/gtk/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt: Added.
  • platform/gtk/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt: Added.
  • platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt: Added.
  • platform/gtk/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Added.
  • platform/gtk/fast/table/growCellForImageQuirk-vertical-expected.txt: Added.
  • platform/gtk/fast/table/height-percent-test-vertical-expected.txt: Added.
  • platform/gtk/fast/table/percent-widths-stretch-vertical-expected.txt: Added.
  • platform/gtk/fast/table/rowspan-paint-order-vertical-expected.txt: Added.
  • platform/gtk/fast/table/table-display-types-vertical-expected.txt: Added.
  • platform/gtk/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
  • platform/gtk/fast/text/international/vertical-text-metrics-test-expected.txt: Added.
  • platform/gtk/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Added.
  • platform/gtk/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Added.
  • platform/gtk/mathml/xHeight-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
  • platform/gtk/svg/custom/repaint-on-constant-size-change-expected.txt: Added.
9:34 AM Changeset in webkit [72010] by andreas.kling@nokia.com
  • 8 edits
    8 adds in trunk/WebKit2

2010-11-15 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[WK2][Qt] WebKit2 implementation of tiled backing store
https://bugs.webkit.org/show_bug.cgi?id=49526

Basic opt-in tiling implementation for WebKit2/Qt.

Original patch by Antti Koivisto.

  • Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: New messages: RequestTileUpdate and CancelTileUpdate.
  • Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: New messages: Invalidate, TileUpdated, AllTileUpdatesProcessed.
  • Shared/DrawingAreaBase.h: New area type: TiledDrawingAreaType.
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::QGraphicsWKView): (QGraphicsWKView::setGeometry): (QGraphicsWKViewPrivate::QGraphicsWKViewPrivate): (QGraphicsWKView::prepareScaleChange): (QGraphicsWKView::commitScaleChange): (QGraphicsWKViewPrivate::onScaleChanged): (QGraphicsWKViewPrivate::commitScale): Support for tiled backing store.
  • UIProcess/TiledDrawingAreaProxy.cpp: Added. (WebKit::TiledDrawingAreaProxy::create): (WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy): (WebKit::TiledDrawingAreaProxy::~TiledDrawingAreaProxy): (WebKit::TiledDrawingAreaProxy::setSize): (WebKit::TiledDrawingAreaProxy::setPageIsVisible): (WebKit::TiledDrawingAreaProxy::didSetSize): (WebKit::TiledDrawingAreaProxy::didReceiveMessage): (WebKit::TiledDrawingAreaProxy::didReceiveSyncMessage): (WebKit::TiledDrawingAreaProxy::requestTileUpdate): (WebKit::TiledDrawingAreaProxy::waitUntilUpdatesComplete): (WebKit::TiledDrawingAreaProxy::createTile): (WebKit::TiledDrawingAreaProxy::setTileSize): (WebKit::TiledDrawingAreaProxy::setTileCreationDelay): (WebKit::TiledDrawingAreaProxy::setKeepAndCoverAreaMultipliers): (WebKit::TiledDrawingAreaProxy::invalidate): (WebKit::TiledDrawingAreaProxy::updateTileBuffers): (WebKit::TiledDrawingAreaProxy::tileBufferUpdateComplete): (WebKit::TiledDrawingAreaProxy::paint): (WebKit::TiledDrawingAreaProxy::adjustVisibleRect): (WebKit::TiledDrawingAreaProxy::setContentsScale): (WebKit::TiledDrawingAreaProxy::removeAllTiles): (WebKit::TiledDrawingAreaProxy::tileDistance): (WebKit::TiledDrawingAreaProxy::calculateKeepRect): (WebKit::TiledDrawingAreaProxy::calculateCoverRect): (WebKit::TiledDrawingAreaProxy::createTiles): (WebKit::TiledDrawingAreaProxy::resizeEdgeTiles): (WebKit::TiledDrawingAreaProxy::dropTilesOutsideRect): (WebKit::TiledDrawingAreaProxy::tileAt): (WebKit::TiledDrawingAreaProxy::setTile): (WebKit::TiledDrawingAreaProxy::removeTile): (WebKit::TiledDrawingAreaProxy::mapToContents): (WebKit::TiledDrawingAreaProxy::mapFromContents): (WebKit::TiledDrawingAreaProxy::contentsRect): (WebKit::TiledDrawingAreaProxy::tileRectForCoordinate): (WebKit::TiledDrawingAreaProxy::tileCoordinateForPoint): (WebKit::TiledDrawingAreaProxy::startTileBufferUpdateTimer): (WebKit::TiledDrawingAreaProxy::tileBufferUpdateTimerFired): (WebKit::TiledDrawingAreaProxy::startTileCreationTimer): (WebKit::TiledDrawingAreaProxy::tileCreationTimerFired): (WebKit::TiledDrawingAreaProxy::hasPendingUpdates):
  • UIProcess/TiledDrawingAreaProxy.h: Added. (WebKit::TiledDrawingAreaProxy::contentsScale): (WebKit::TiledDrawingAreaProxy::attachCompositingContext): (WebKit::TiledDrawingAreaProxy::detachCompositingContext): (WebKit::TiledDrawingAreaProxy::tileSize): (WebKit::TiledDrawingAreaProxy::tileCreationDelay): (WebKit::TiledDrawingAreaProxy::getKeepAndCoverAreaMultipliers):
  • UIProcess/TiledDrawingAreaTile.h: Added. (WebKit::TiledDrawingAreaTile::create): (WebKit::TiledDrawingAreaTile::hasBackBufferUpdatePending): (WebKit::TiledDrawingAreaTile::coordinate): (WebKit::TiledDrawingAreaTile::rect): (WebKit::TiledDrawingAreaTile::ID):
  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create):
  • WebProcess/WebPage/TiledDrawingArea.cpp: Added. (WebKit::TiledDrawingArea::TiledDrawingArea): (WebKit::TiledDrawingArea::~TiledDrawingArea): (WebKit::TiledDrawingArea::invalidateWindow): (WebKit::TiledDrawingArea::invalidateContentsAndWindow): (WebKit::TiledDrawingArea::invalidateContentsForSlowScroll): (WebKit::TiledDrawingArea::scroll): (WebKit::TiledDrawingArea::setNeedsDisplay): (WebKit::TiledDrawingArea::display): (WebKit::TiledDrawingArea::scheduleDisplay): (WebKit::TiledDrawingArea::setSize): (WebKit::TiledDrawingArea::suspendPainting): (WebKit::TiledDrawingArea::resumePainting): (WebKit::TiledDrawingArea::didUpdate): (WebKit::TiledDrawingArea::updateTile): (WebKit::TiledDrawingArea::tileUpdateTimerFired): (WebKit::TiledDrawingArea::didReceiveMessage):
  • WebProcess/WebPage/TiledDrawingArea.h: Added. (WebKit::TiledDrawingArea::attachCompositingContext): (WebKit::TiledDrawingArea::detachCompositingContext): (WebKit::TiledDrawingArea::setRootCompositingLayer): (WebKit::TiledDrawingArea::scheduleCompositingLayerSync): (WebKit::TiledDrawingArea::syncCompositingLayers):
  • WebProcess/WebPage/qt/TiledDrawingAreaQt.cpp: Added. (WebKit::TiledDrawingArea::paintIntoUpdateChunk):
  • WebKit2.pro:
  • UIProcess/qt/TiledDrawingAreaTileQt.cpp: Added. (WebKit::checkeredPixmap): (WebKit::TiledDrawingAreaTile::TiledDrawingAreaTile): (WebKit::TiledDrawingAreaTile::~TiledDrawingAreaTile): (WebKit::TiledDrawingAreaTile::isDirty): (WebKit::TiledDrawingAreaTile::isReadyToPaint): (WebKit::TiledDrawingAreaTile::hasReadyBackBuffer): (WebKit::TiledDrawingAreaTile::invalidate): (WebKit::TiledDrawingAreaTile::resize): (WebKit::TiledDrawingAreaTile::swapBackBufferToFront): (WebKit::TiledDrawingAreaTile::paint): (WebKit::TiledDrawingAreaTile::paintCheckerPattern): (WebKit::TiledDrawingAreaTile::updateFromChunk): (WebKit::TiledDrawingAreaTile::updateBackBuffer):
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp: Added. (WebKit::TiledDrawingAreaProxy::updateWebView): (WebKit::TiledDrawingAreaProxy::webViewVisibleRect): (WebKit::TiledDrawingAreaProxy::page):
9:29 AM Changeset in webkit [72009] by bulach@chromium.org
  • 1 edit
    12 adds in trunk/LayoutTests

2010-11-15 Marcus Bulach <bulach@chromium.org>

Not reviewed, Chromium test expectation update.

Update chromium baselines for svg following r72006
https://bugs.webkit.org/show_bug.cgi?id=49547

  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
8:56 AM Changeset in webkit [72008] by benjamin.poulain@nokia.com
  • 3 edits in trunk/WebKitTools

2010-11-15 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] [WK2] Add Ctrl+L shortcut to Qt Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=49544

Add the shortcut to BrowserWindow.

  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): (BrowserWindow::openLocation):
  • MiniBrowser/qt/BrowserWindow.h:
8:24 AM Changeset in webkit [72007] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-11-15 Patrick Gansterer <Patrick Gansterer>

Reviewed by Martin Robinson.

Make ContextShadow compile on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49535

Add a void* typedef for PlatformImage and PlatformContext for unsupported platforms
and move them into the WebCore namespace like all other Platform* typedefs.

  • platform/graphics/ContextShadow.h:
8:10 AM Changeset in webkit [72006] by reni@webkit.org
  • 4 edits
    10 adds in trunk

WebCore: SVGFEImageElement doesn't support dynamic invalidation
https://bugs.webkit.org/show_bug.cgi?id=49536

Patch by Renata Hodovan <reni@webkit.org> on 2010-11-15
Reviewed by Andreas Kling.

The dynamic changes are captured by the svgAttributeChanged function. Invalidate the filter primitive if necessary.

Tests: svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr.html

svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop.html

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::svgAttributeChanged):

  • svg/SVGFEImageElement.h:

LayoutTests: SVGFEImageElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=49536

Patch by Renata Hodovan <reni@webkit.org> on 2010-11-15
Reviewed by Andreas Kling.

Adding layout tests for feImage dynamic changes.

  • platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr.html: Added.
  • svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFEImageElement-dom-preserveAspectRatio-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEImageElement-svgdom-preserveAspectRatio-prop.js: Added.

(executeTest):

6:49 AM Changeset in webkit [72005] by Csaba Osztrogonác
  • 1 edit
    5 copies
    1 add in trunk/LayoutTests

Unreviewed. Add Qt specific expected results after r72003.

[Qt] Possible DRT bug revealed by r72003
https://bugs.webkit.org/show_bug.cgi?id=49538

  • platform/qt/fast/forms/formaction-attribute-expected.txt: Copied from LayoutTests/fast/forms/formaction-attribute-expected.txt.
  • platform/qt/fast/forms/formmethod-attribute-button-html-expected.txt: Copied from LayoutTests/fast/forms/formmethod-attribute-button-html-expected.txt.
  • platform/qt/fast/forms/formtarget-attribute-button-html-expected.txt: Copied from LayoutTests/fast/forms/formtarget-attribute-button-html-expected.txt.
  • platform/qt/fast/forms/mailto: Added.
  • platform/qt/fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Copied from LayoutTests/fast/forms/mailto/formenctype-attribute-button-html-expected.txt.
  • platform/qt/fast/forms/mailto/formenctype-attribute-input-html-expected.txt: Copied from LayoutTests/fast/forms/mailto/formenctype-attribute-input-html-expected.txt.
5:32 AM Changeset in webkit [72004] by yael.aharon@nokia.com
  • 3 edits
    3 adds in trunk

2010-11-15 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Focus ring does not show on focused links.
https://bugs.webkit.org/show_bug.cgi?id=49515

  • platform/qt/fast/inline/inline-focus-ring-expected.checksum: Added.
  • platform/qt/fast/inline/inline-focus-ring-expected.png: Added.
  • platform/qt/fast/inline/inline-focus-ring-expected.txt: Added.

2010-11-15 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Focus ring does not show on focused links.
https://bugs.webkit.org/show_bug.cgi?id=49515

After http://trac.webkit.org/changeset/69766 the focus ring on links is no longer
visible in Qt.
The reason is that Qt always returned true in RenderTheme::supportsFocusRing(),
but until r69766, we did not check that for links. Qt draws its own focus ring
for controls that it draws, but not for links.
Change the return value to false if the style's appearance is not something that Qt
draws by itself or does not support.
Added a Qt specific test result for the new test added in r69766.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::supportsFocusRing):
4:43 AM Changeset in webkit [72003] by commit-queue@webkit.org
  • 7 edits
    17 adds in trunk

2010-11-15 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

Implement formaction, formenctype, formmethod and formtarget attributes for input and button tags
https://bugs.webkit.org/show_bug.cgi?id=49240

  • fast/forms/formaction-attribute-expected.txt: Added.
  • fast/forms/formaction-attribute.html: Added.
  • fast/forms/formmethod-attribute-button-html-expected.txt: Added.
  • fast/forms/formmethod-attribute-button-html.html: Added.
  • fast/forms/formmethod-attribute-input-html-expected.txt: Added.
  • fast/forms/formmethod-attribute-input-html.html: Added.
  • fast/forms/formtarget-attribute-button-html-expected.txt: Added.
  • fast/forms/formtarget-attribute-button-html.html: Added.
  • fast/forms/formtarget-attribute-input-html-expected.txt: Added.
  • fast/forms/formtarget-attribute-input-html.html: Added.
  • fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Added.
  • fast/forms/mailto/formenctype-attribute-button-html.html: Added.
  • fast/forms/mailto/formenctype-attribute-input-html-expected.txt: Added.
  • fast/forms/mailto/formenctype-attribute-input-html.html: Added.
  • fast/forms/script-tests/submit-form-attributes.js: Added.
  • fast/forms/submit-form-attributes-expected.txt: Added.
  • fast/forms/submit-form-attributes.html: Added.

2010-11-15 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

Implement formaction, formenctype, formmethod and formtarget attributes for input and button tags
https://bugs.webkit.org/show_bug.cgi?id=49240

Tests: fast/forms/formaction-attribute.html

fast/forms/formmethod-attribute-button-html.html
fast/forms/formmethod-attribute-input-html.html
fast/forms/formtarget-attribute-button-html.html
fast/forms/formtarget-attribute-input-html.html
fast/forms/mailto/formenctype-attribute-button-html.html
fast/forms/mailto/formenctype-attribute-input-html.html
fast/forms/submit-form-attributes.html

  • html/HTMLAttributeNames.in: Added formaction, formmethod, formtarget and formenctype attributes
  • html/HTMLButtonElement.idl:
  • html/HTMLInputElement.idl:
  • loader/FormSubmission.cpp: Modified to check the pressed button and its attributes (WebCore::FormSubmission::Attributes::copyFrom): (WebCore::FormSubmission::create):
  • loader/FormSubmission.h:
4:09 AM Changeset in webkit [72002] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-11-15 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Do not hide default Ctrl+A behavior on non-Mac.
https://bugs.webkit.org/show_bug.cgi?id=49527

  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype._onKeyDown):
3:37 AM Changeset in webkit [72001] by commit-queue@webkit.org
  • 9 edits in trunk

2010-11-15 Ilya Sherman <isherman@chromium.org>

Reviewed by Kent Tamura.

Add capability for displaying warnings to autofill popup
Warnings are displayed in dark gray italic.
https://bugs.webkit.org/show_bug.cgi?id=49291
http://code.google.com/p/chromium/issues/detail?id=58509

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::getRowFont): Use item-specific font, not just the generic menu font. (WebCore::PopupListBox::selectIndex): Updated to clear the selection when hovering over a non-selectable item.
  • platform/chromium/PopupMenuChromium.h: Minor cleanup

2010-11-15 Ilya Sherman <isherman@chromium.org>

Reviewed by Kent Tamura.

Add capability for displaying warnings to autofill popup
Warnings are displayed in dark gray italic.
https://bugs.webkit.org/show_bug.cgi?id=49291
http://code.google.com/p/chromium/issues/detail?id=58509

  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::canRemoveSuggestionAtIndex): Updated logic -- can only remove Autocomplete suggestions, which have unique ID 0. (WebKit::AutoFillPopupMenuClient::itemIsEnabled): False for warnings. (WebKit::AutoFillPopupMenuClient::itemStyle): Dark gray italic for warnings. (WebKit::AutoFillPopupMenuClient::menuStyle): Variable name changed. (WebKit::AutoFillPopupMenuClient::itemIsWarning): True for unique ID < 0. (WebKit::AutoFillPopupMenuClient::initialize): Updated cached styles (see above).
  • src/AutoFillPopupMenuClient.h: Added itemIsEnabled(), variable to cache warning style.
  • src/WebViewImpl.cpp: Minor cleanup. (WebKit::WebViewImpl::applyAutoFillSuggestions):
2:39 AM Changeset in webkit [72000] by alex
  • 2 edits in trunk/LayoutTests

2010-11-15 Alejandro G. Castro <alex@igalia.com>

Unreviewed.

Skipping SVG failing tests for GTK+ until we find the issue,
opened a bug:
[gtk] SVGLineElement-dom-requiredFeatures.html and
SVGLineElement-svgdom-requiredFeatures.html failing in the bots
https://bugs.webkit.org/show_bug.cgi?id=49529

  • platform/gtk/Skipped:
Note: See TracTimeline for information about the timeline view.