Timeline
Jan 4, 2011:
- 11:45 PM Changeset in webkit [75052] by
-
- 2 edits in trunk/WebCore
2011-01-04 Chris Fleizach <Chris Fleizach>
Unreviewed. GTK build fix.
WK2: Support Accessibility
https://bugs.webkit.org/show_bug.cgi?id=51859
- page/FrameView.cpp: (WebCore::FrameView::axObjectCache):
- 11:37 PM Changeset in webkit [75051] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix. Update path to FindSafari after source code reorganization.
- JavaScriptCore.vcproj/JavaScriptCore.sln:
- 11:33 PM Changeset in webkit [75050] by
-
- 3 edits in trunk/Tools
2011-01-04 Koan-Sin Tan <koansin.tan@gmail.com>
Reviewed by David Levin.
check-webkit-style treated some macros with parentheses after #elif as function calls
https://bugs.webkit.org/show_bug.cgi?id=51695
Ingore function call space checking in any preprocessor directives
(things starting with #). Change search() to match() because
preprocessor directives are supposed to be in the beginning of lines.
- Scripts/webkitpy/style/checkers/cpp.py:
- Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
- 11:24 PM Changeset in webkit [75049] by
-
- 2 edits in trunk/LayoutTests
2011-01-04 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
insecure-css-in-main-frame.html is flaky on Chromium-linux too.
- platform/chromium/test_expectations.txt:
- 11:21 PM Changeset in webkit [75048] by
-
- 8 edits in trunk/WebCore
2011-01-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74992.
http://trac.webkit.org/changeset/74992
https://bugs.webkit.org/show_bug.cgi?id=51917
Crash in HTMLDocumentParser::suspendScheduledTasks()
(Requested by tkent on #webkit).
- dom/DocumentParser.cpp:
- dom/DocumentParser.h:
- html/parser/HTMLDocumentParser.cpp:
- html/parser/HTMLDocumentParser.h:
- html/parser/HTMLParserScheduler.cpp: (WebCore::HTMLParserScheduler::HTMLParserScheduler):
- html/parser/HTMLParserScheduler.h: (WebCore::HTMLParserScheduler::isScheduledForResume):
- page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
- 10:24 PM Changeset in webkit [75047] by
-
- 6 edits in trunk
2011-01-04 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [WK2] Add support for non-trivial context menu action
https://bugs.webkit.org/show_bug.cgi?id=51902
Fix the preprocessor guard for ContextMenuItemTagSelectAll in
the implementation of ContextMenuController::contextMenuItemSelected(). The guard was
inconsistent with what is defined in ContextMenuItem.h.
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
2011-01-04 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [WK2] Add support for non-trivial context menu action
https://bugs.webkit.org/show_bug.cgi?id=51902
Implement a call back from the QAction triggered in the UIProcess to the
action in WebProcess.
A few basic actions have been implemented based on this feature.
- UIProcess/API/qt/qwkpage.cpp: (contextMenuActionForWebAction): (QWKPage::triggerAction): (QWKPage::action):
- UIProcess/API/qt/qwkpage.h:
- UIProcess/qt/WebContextMenuProxyQt.cpp: (WebKit::webActionForContextMenuAction):
- 9:48 PM Changeset in webkit [75046] by
-
- 3 edits in trunk/WebKit2
2011-01-04 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Laszlo Gombos.
Include unistd.h for sleep() for non-Windows builds.
- WebProcess/WebProcess.cpp:
- WebProcess/qt/WebProcessMainQt.cpp:
- 9:30 PM Changeset in webkit [75045] by
-
- 5 edits in trunk/WebCore
2011-01-04 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Ryosuke Niwa.
Avoid manual ref/deref in AsyncScriptRunner by using PendingScript
https://bugs.webkit.org/show_bug.cgi?id=51723
ScriptElement should also be able to keep its Element+CachedScript in
a PendingScript, and then executeScriptSoon can accept a PendingScript.
Once HTMLScriptRunner, ScriptElement, and AsyncScriptRunner all use
PendingScripts, then generic request and execute which operate on
PendingScripts can be factored out to avoid code duplicate that we have.
No new tests because no new functionality.
- dom/AsyncScriptRunner.cpp: (WebCore::AsyncScriptRunner::~AsyncScriptRunner): (WebCore::AsyncScriptRunner::executeScriptSoon): (WebCore::AsyncScriptRunner::timerFired):
- dom/AsyncScriptRunner.h:
- dom/PendingScript.h: Add ctor which sets element and cachedScript. Rename adoptElement->setElement.
- dom/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::requestPendingScript):
- 8:07 PM Changeset in webkit [75044] by
-
- 2 edits in trunk/WebKit2
Windows build fix. Change the inline type of consumePermanently.
- Shared/SandboxExtension.h:
(WebKit::SandboxExtension::consumePermanently):
- 7:30 PM Changeset in webkit [75043] by
-
- 2 edits in trunk/LayoutTests
2011-01-04 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update
- slow-loading-image-in-pattern.html had a wrong expectation for Chromium-win.
- insecure-css-in-main-frame.html is flaky on Chromium-win?
- platform/chromium/test_expectations.txt:
- 7:10 PM Changeset in webkit [75042] by
-
- 7 edits in trunk/WebKit2
<rdar://problem/8821203> Sandbox violations trying to access the Safari cache
Reviewed by Dan Bernstein.
- Shared/SandboxExtension.h:
(WebKit::SandboxExtension::consumePermanently):
New function which consumes a sandbox extension and destroys it, making it impossible
to later revoke it.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
Encode and decode the path extension handle.
- Shared/mac/SandboxExtensionMac.mm:
(WebKit::SandboxExtension::createHandle):
Standardize the path before creating the handle.
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
Create a sandbox extension for the cache path.
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
Consume the sandbox extension.
- 7:08 PM Changeset in webkit [75041] by
-
- 2 edits in trunk/WebKit2
Fix build.
- UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::getGuessesForWord):
- 7:08 PM Changeset in webkit [75040] by
-
- 12 edits in trunk
2011-01-04 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
Member variable and method naming cleanup to be consistent with WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=51228
- page/win/EventHandlerWin.cpp: (WebCore::EventHandler::eventActivatedView): Rename activatedWebView() to didActivateWebView().
- platform/PlatformMouseEvent.h: Rename m_activatedWebView to m_didActivateWebView.
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
Initialize platform-specific member variables in PlatformMouseEvent constructors.
(WebCore::PlatformMouseEvent::didActivateWebView):
Rename activatedWebView() to didActivateWebView().
- platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Rename m_activatedWebView to m_didActivateWebView.
2011-01-04 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
Mouse events in WebKit2 on Windows need to know whether the click activated the WebView to match WebKit1 behavior.
https://bugs.webkit.org/show_bug.cgi?id=51228
- Shared/WebEvent.h: (WebKit::WebMouseEvent::didActivateWebView): Add m_didActivateWebView to WebMouseEvent on Windows.
- Shared/WebEventConversion.cpp: (WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent): Propagate whether the click activated the WebView when converting to a PlatformMouseEvent.
- Shared/WebMouseEvent.cpp: (WebKit::WebMouseEvent::WebMouseEvent): Add m_didActivateWebView to WebMouseEvent on Windows.
(WebKit::WebMouseEvent::encode):
(WebKit::WebMouseEvent::decode):
Encode and decode new m_didActivateWebView member variable.
- Shared/win/WebEventFactory.cpp: (WebKit::WebEventFactory::createWebMouseEvent):
- Shared/win/WebEventFactory.h: Add didActivateWebView parameter to createWebMouseEvent().
- UIProcess/win/WebView.cpp: (WebKit::WebView::wndProc): (WebKit::WebView::WebView): (WebKit::WebView::onMouseEvent):
- UIProcess/win/WebView.h: (WebKit::WebView::setWasActivatedByMouseEvent): Keep track of whether the click activated the WebView.
- 6:21 PM Changeset in webkit [75039] by
-
- 3 edits2 adds in trunk
2011-01-04 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
CSS3 :nth-child selector and valid whitespace test fails
https://bugs.webkit.org/show_bug.cgi?id=36279
- fast/css/css3-nth-space-expected.txt: Added.
- fast/css/css3-nth-space.html: Added.
2011-01-04 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
CSS3 :nth-child selector and valid whitespace test fails
https://bugs.webkit.org/show_bug.cgi?id=36279
Teach the tokenizer to allow white spaces around [+/-] signs in nth constructs.
Test: fast/css/css3-nth-space.html
- css/tokenizer.flex:
- 6:16 PM Changeset in webkit [75038] by
-
- 2 edits in trunk/WebKit2
Reviewed and landed by Anders Carlsson.
Patch by Ivan Krstić <ike@apple.com> on 2011-01-04
<rdar://problem/8602585>
<rdar://problem/8711641>
- WebProcess/com.apple.WebProcess.sb:
Fix a misplaced right parenthesis and add a new system path regex.
- 6:13 PM Changeset in webkit [75037] by
-
- 18 edits in trunk/WebKit2
2011-01-04 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
More work on spelling and grammar
https://bugs.webkit.org/show_bug.cgi?id=51910
- Scripts/webkit2/messages.py: Add special case for WebCore::TextCheckingResult.
- Shared/NotImplemented.h: Fix macro so that defining DISABLE_NOT_IMPLEMENTED_WARNINGS to 0 will enable the warnings.
- Shared/WebCoreArgumentCoders.h: Add argument coders for WebCore::GrammarDetail and WebCore::TextCheckingResult.
- UIProcess/API/mac/WKView.mm: (-[WKView checkSpelling:]): Call advanceToNextMisspelling.
- UIProcess/TextChecker.h: Add new NSSpellChecker wrappers.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Initialize the new member variables.
(WebKit::WebPageProxy::~WebPageProxy):
Call TextChecker::closeSpellDocumentWithTag.
(WebKit::WebPageProxy::advanceToNextMisspelling):
Send the AdvanceToNextMisspelling message.
(WebKit::WebPageProxy::spellDocumentTag):
Create a spell document tag if necessary.
(WebKit::WebPageProxy::checkTextOfParagraph):
(WebKit::WebPageProxy::updateSpellingUIWithMisspelledWord):
(WebKit::WebPageProxy::getGuessesForWord):
Call the TextChecker.
- UIProcess/WebPageProxy.messages.in: Add new messages.
- UIProcess/mac/TextCheckerMac.mm: (WebKit::TextChecker::uniqueSpellDocumentTag): (WebKit::TextChecker::closeSpellDocumentWithTag): (WebKit::TextChecker::checkTextOfParagraph): (WebKit::TextChecker::updateSpellingUIWithMisspelledWord): (WebKit::TextChecker::getGuessesForWord): Add NSSpellChecker wrappers.
- UIProcess/qt/TextCheckerQt.cpp:
- UIProcess/win/TextCheckerWin.cpp: Add stubs.
- WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::isContinuousSpellCheckingEnabled): (WebKit::WebEditorClient::isGrammarCheckingEnabled): Get the text checking state from the web process.
(WebKit::WebEditorClient::updateSpellingUIWithMisspelledWord):
(WebKit::WebEditorClient::getGuessesForWord):
Proxy calls to the UI process.
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::isAutomaticSpellingCorrectionEnabled):
(WebKit::WebEditorClient::checkTextOfParagraph):
Proxy calls to the UI process.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::advanceToNextMisspelling): Call the frame.
- WebProcess/WebPage/WebPage.messages.in: Add AdvanceToNextMisspelling message.
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess): Set the text checker state.
- 6:09 PM Changeset in webkit [75036] by
-
- 6 edits in trunk/Tools
2011-01-04 Søren Gjesse <sgjesse@chromium.org>
Reviewed by Tony Chang.
Change the --multi-load test option to --stress-opt
https://bugs.webkit.org/show_bug.cgi?id=50751
- DumpRenderTree/chromium/DumpRenderTree.cpp: (runTest): (main):
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
- DumpRenderTree/chromium/TestShell.h: (TestShell::stressOpt): (TestShell::setStressOpt): (TestShell::stressDeopt): (TestShell::setStressDeopt): (TestShell::javaScriptFlags): (TestShell::setJavaScriptFlags):
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 5:45 PM Changeset in webkit [75035] by
-
- 4 edits in trunk/LayoutTests
2011-01-04 Tony Gentilcore <tonyg@chromium.org>
Unreviewed expectations update.
Fix text metrics for "You should not see this at all" message
https://bugs.webkit.org/show_bug.cgi?id=51909
- http/tests/misc/acid3-expected.checksum:
- http/tests/misc/acid3-expected.png:
- platform/chromium/test_expectations.txt:
- 5:36 PM Changeset in webkit [75034] by
-
- 4 edits in trunk
Unreviewed. Build fix.
WK2: Support Accessibility
https://bugs.webkit.org/show_bug.cgi?id=51859
WebCore:
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(fallbackObject):
WebKit2:
- WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:
- 5:21 PM Changeset in webkit [75033] by
-
- 2 edits in trunk/WebKit2
Unreviewed. Build fix.
WK2: Support Accessibility
https://bugs.webkit.org/show_bug.cgi?id=51859
- WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:
(-[AccessibilityWebPageObject accessibilityAttributeValue:]):
- 5:14 PM Changeset in webkit [75032] by
-
- 2 edits in trunk/WebCore
2011-01-04 Cosmin Truta <ctruta@chromium.org>
Reviewed by Eric Seidel.
[chromium] PNG compression settings optimized for speed
https://bugs.webkit.org/show_bug.cgi?id=51719
Although Z_HUFFMAN_ONLY is the fastest on hard-to-compress images,
it is also the slowest, by a wide margin, on easy-to-compress images.
Use a more balanced configuration, based on the libpng compression defaults,
but with a faster compression level (3 instead of 6), and a faster filter
("sub" instead of "all").
No change in behaviour, so no new tests.
- platform/image-encoders/skia/PNGImageEncoder.cpp: (WebCore::PNGImageEncoder::encode):
- 5:07 PM Changeset in webkit [75031] by
-
- 69 edits6 adds in trunk
WK2: Support Accessibility
https://bugs.webkit.org/show_bug.cgi?id=51859
Reviewed by Sam Weinig.
Tools:
Use rootObject() method to get top of accessibility tree.
- DumpRenderTree/mac/AccessibilityControllerMac.mm:
(AccessibilityController::focusedElement):
(AccessibilityController::rootElement):
WebCore:
WK2 doesn't use platform scroll views anymore. Accessibility code
needs to have its own scroll views.
Test: platform/mac/accessibility/webkit-scrollarea.html
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::get):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::rootObject):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::handleScrollbarUpdate):
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::handleScrollbarUpdate):
- accessibility/AccessibilityARIAGrid.h:
- accessibility/AccessibilityAllInOne.cpp:
- accessibility/AccessibilityImageMapLink.cpp:
- accessibility/AccessibilityImageMapLink.h:
- accessibility/AccessibilityListBoxOption.cpp:
- accessibility/AccessibilityListBoxOption.h:
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::updateChildrenIfNecessary):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):
(WebCore::AccessibilityObject::axObjectCache):
(WebCore::AccessibilityObject::focusedUIElement):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isAccessibilityScrollView):
(WebCore::AccessibilityObject::isScrollView):
(WebCore::AccessibilityObject::canSetNumericValue):
(WebCore::AccessibilityObject::scrollBar):
(WebCore::AccessibilityObject::size):
(WebCore::AccessibilityObject::setValue):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::parentObject):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::updateChildrenIfNecessary):
(WebCore::AccessibilityRenderObject::addChildren):
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilityScrollView.cpp: Added.
(WebCore::AccessibilityScrollView::AccessibilityScrollView):
(WebCore::AccessibilityScrollView::create):
(WebCore::AccessibilityScrollView::scrollBar):
(WebCore::AccessibilityScrollView::children):
(WebCore::AccessibilityScrollView::updateChildrenIfNecessary):
(WebCore::AccessibilityScrollView::removeChildScrollbar):
(WebCore::AccessibilityScrollView::addChildScrollbar):
(WebCore::AccessibilityScrollView::addChildren):
(WebCore::AccessibilityScrollView::webAreaObject):
(WebCore::AccessibilityScrollView::accessibilityHitTest):
(WebCore::AccessibilityScrollView::document):
(WebCore::AccessibilityScrollView::elementRect):
(WebCore::AccessibilityScrollView::parentObject):
- accessibility/AccessibilityScrollView.h: Added.
(WebCore::AccessibilityScrollView::roleValue):
(WebCore::AccessibilityScrollView::scrollView):
(WebCore::AccessibilityScrollView::accessibilityIsIgnored):
(WebCore::AccessibilityScrollView::isAccessibilityScrollView):
(WebCore::toAccessibilityScrollView):
- accessibility/AccessibilityScrollbar.cpp:
(WebCore::AccessibilityScrollbar::AccessibilityScrollbar):
(WebCore::AccessibilityScrollbar::create):
(WebCore::AccessibilityScrollbar::elementRect):
(WebCore::AccessibilityScrollbar::document):
(WebCore::AccessibilityScrollbar::orientation):
(WebCore::AccessibilityScrollbar::isEnabled):
(WebCore::AccessibilityScrollbar::valueForRange):
(WebCore::AccessibilityScrollbar::setValue):
- accessibility/AccessibilityScrollbar.h:
(WebCore::AccessibilityScrollbar::setParent):
(WebCore::AccessibilityScrollbar::canSetValueAttribute):
(WebCore::AccessibilityScrollbar::canSetNumericValue):
(WebCore::AccessibilityScrollbar::isAccessibilityScrollbar):
(WebCore::AccessibilityScrollbar::parentObject):
(WebCore::AccessibilityScrollbar::roleValue):
- accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper remoteAccessibilityParentObject]):
(-[AccessibilityObjectWrapper position]):
(-[AccessibilityObjectWrapper scrollViewParent]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityHitTest:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
- dom/Document.cpp:
(WebCore::Document::axObjectCache):
- loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::accessibilityRemoteObject):
- loader/FrameLoaderClient.h:
- page/FrameView.cpp:
(WebCore::FrameView::~FrameView):
(WebCore::FrameView::axObjectCache):
- page/FrameView.h:
- platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::~Scrollbar):
(WebCore::Scrollbar::scroll):
(WebCore::Scrollbar::axObjectCache):
- platform/Scrollbar.h:
- platform/Widget.h:
(WebCore::Widget::axObjectCache):
WebKit/gtk:
Use rootObject() method to get top of ax tree.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::getFocusedAccessibleElement):
- webkit/webkitwebview.cpp:
(webkit_web_view_get_accessible):
WebKit/mac:
Use rootObject() method to get top of AX tree.
- WebCoreSupport/WebFrameLoaderClient.h:
(WebFrameLoaderClient::accessibilityRemoteObject):
- WebView/WebFrame.mm:
(-[WebFrame setAccessibleName:]):
(-[WebFrame accessibilityRoot]):
- WebView/WebFrameInternal.h:
- WebView/WebFramePrivate.h:
- WebView/WebHTMLView.mm:
(-[WebHTMLView accessibilityAttributeValue:]):
(-[WebHTMLView accessibilityFocusedUIElement]):
(-[WebHTMLView accessibilityHitTest:]):
(-[WebHTMLView _accessibilityParentForSubview:]):
WebKit/win:
Use rootObject() method to get the top of the AX tree.
- AccessibleDocument.cpp:
(AccessibleDocument::AccessibleDocument):
WebKit2:
Implement remote accessibility API to support cross process accessibility
on the Mac platform.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::accessibilityChildTokenReceived):
- UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView _updateWindowAndViewFrames]):
(-[WKView _setAccessibilityChildToken:]):
(-[WKView accessibilityIsIgnored]):
(-[WKView accessibilityHitTest:]):
(-[WKView accessibilityAttributeValue:]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/PageClient.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureWebProcess):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::windowAndViewFramesChanged):
(WebKit::WebPageProxy::didReceiveAccessibilityPageToken):
(WebKit::WebPageProxy::sendAccessibilityPresenterToken):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::accessibilityRemoteObject):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowAndViewFramesChanged):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::accessibilityPosition):
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/mac/AccessibilityWebPageObject.h: Added.
- WebProcess/WebPage/mac/AccessibilityWebPageObject.mm: Added.
(-[AccessibilityWebPageObject setWebPage:]):
(-[AccessibilityWebPageObject setRemoteParent:]):
(-[AccessibilityWebPageObject dealloc]):
(-[AccessibilityWebPageObject accessibilityIsIgnored]):
(-[AccessibilityWebPageObject accessibilityAttributeNames]):
(-[AccessibilityWebPageObject accessibilityIsAttributeSettable:]):
(-[AccessibilityWebPageObject accessibilitySetValue:forAttribute:]):
(-[AccessibilityWebPageObject accessibilityActionNames]):
(-[AccessibilityWebPageObject accessibilityChildren]):
(-[AccessibilityWebPageObject accessibilityAttributeValue:]):
(-[AccessibilityWebPageObject accessibilityShouldUseUniqueId]):
(-[AccessibilityWebPageObject accessibilityHitTest:]):
(-[AccessibilityWebPageObject accessibilityFocusedUIElement]):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::sendAccessibilityPresenterToken):
(WebKit::WebPage::accessibilityRemoteObject):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
- WebProcess/WebProcess.h:
(WebKit::WebProcess::presenterApplicationPid):
- WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):
LayoutTests:
- platform/mac/accessibility/webkit-scrollarea-expected.txt: Added.
- platform/mac/accessibility/webkit-scrollarea.html: Added.
- 4:53 PM Changeset in webkit [75030] by
-
- 3 edits in trunk/WebCore
2011-01-04 W. James MacLean <wjmaclean@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Add support to compositor to composite to offscreen texture.
https://bugs.webkit.org/show_bug.cgi?id=50833
A patch to extend compositor to be able to composite into an offscreen texture instead
of just directly to the display buffer. Builds on RenderSurfaceChromium support.
Explicitly resets alpha channel before rendering to display.
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateAndDrawRootLayer): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::setCompositeOffscreen): (WebCore::LayerRendererChromium::useRenderSurface): (WebCore::LayerRendererChromium::setScissorToRect):
- platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::isCompositingOffscreen): (WebCore::LayerRendererChromium::getOffscreenLayerTexture):
- 4:50 PM Changeset in webkit [75029] by
-
- 1 edit1 add in trunk/LayoutTests
2011-01-04 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
Add home-end-expected.txt for Chromium-win again. It's a
platform-dependent text test.
- platform/chromium-win/editing/selection/home-end-expected.txt: Added.
- 4:26 PM Changeset in webkit [75028] by
-
- 3 edits2 copies in branches/chromium/552
Merge 74779 - 2010-12-29 Justin Schuh <jschuh@chromium.org>
Reviewed by Darin Adler.
Check SVG element type in FrameView::scrollToAnchor
https://bugs.webkit.org/show_bug.cgi?id=51718
Test: svg/custom/scroll-to-anchor-in-symbol.svg
- page/FrameView.cpp: (WebCore::FrameView::scrollToAnchor):
2010-12-29 Justin Schuh <jschuh@chromium.org>
Reviewed by Darin Adler.
Check SVG element type in FrameView::scrollToAnchor
https://bugs.webkit.org/show_bug.cgi?id=51718
- svg/custom/scroll-to-anchor-in-symbol-expected.txt: Added.
- svg/custom/scroll-to-anchor-in-symbol.svg: Added.
BUG=68178
TBR=jschuh@chromium.org
- 4:23 PM Changeset in webkit [75027] by
-
- 2 edits in trunk/WebKit/chromium
2011-01-04 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
Update README file with a description of the WEBKIT_API macro and
guidelines for its usage. Also document the various WEBKIT_USING_*
macros.
- README:
- 4:21 PM Changeset in webkit [75026] by
-
- 1 edit in branches/chromium/552/WebCore/svg/SVGLength.cpp
Merge 74788 - 2010-12-30 Justin Schuh <jschuh@chromium.org>
Reviewed by Dirk Schulze.
Prevent stringToLengthType() from skipping past end-of-string on invalid length unit.
https://bugs.webkit.org/show_bug.cgi?id=51692
- svg/SVGLength.cpp: (WebCore::stringToLengthType): (WebCore::SVGLength::setValueAsString):
2010-12-30 Justin Schuh <jschuh@chromium.org>
Reviewed by Dirk Schulze.
Adding long float string to improve test coverage.
https://bugs.webkit.org/show_bug.cgi?id=51692
- svg/dom/length-list-parser.html:
- svg/dom/length-list-parser-expected.txt:
BUG=68062
TBR=jschuh@chromium.org
- 4:17 PM Changeset in webkit [75025] by
-
- 2 edits in trunk/LayoutTests
2011-01-04 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
- platform/chromium/test_expectations.txt: Fix a syntax error in the previous change
- 4:09 PM Changeset in webkit [75024] by
-
- 2 edits1 delete in trunk/LayoutTests
2011-01-04 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
- platform/chromium-win/editing/selection/home-end-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 4:06 PM Changeset in webkit [75023] by
-
- 4 edits in trunk
2011-01-04 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[chromium] depend on harfbuzz explicitly
https://bugs.webkit.org/show_bug.cgi?id=51895
platform/graphics/chromium uses Harfbuzz directly. Rather than
expecting Skia to adjust the include paths, be explicit about
the dependency.
- WebCore.gyp/WebCore.gyp:
2011-01-04 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[chromium] depend on harfbuzz explicitly
https://bugs.webkit.org/show_bug.cgi?id=51895
Update Chromium DEPS to pick up newer Chromium version
that simplifies expressing the Harfbuzz dependency.
- DEPS:
- 3:57 PM Changeset in webkit [75022] by
-
- 10 edits in trunk/WebKit2
Get rid of an extra copy in the back/forward item IPC message by using a DataReference.
Reviewed by Darin Adler.
- UIProcess/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::WebBackForwardListItem):
(WebKit::WebBackForwardListItem::setBackForwardData):
- UIProcess/WebBackForwardListItem.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::dataCallback): Get rid of no-longer-needed check for size 0.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addBackForwardItem):
- UIProcess/WebProcessProxy.h:
- UIProcess/WebProcessProxy.messages.in:
- WebProcess/WebPage/EncoderAdapter.cpp:
(WebKit::EncoderAdapter::data):
- WebProcess/WebPage/EncoderAdapter.h:
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
- 3:35 PM Changeset in webkit [75021] by
-
- 6 edits in trunk/WebKit2
Store more data per history entry in the session state blob.
Reviewed by Darin Adler.
- UIProcess/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::WebBackForwardListItem):
- UIProcess/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::create):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addBackForwardItem):
- UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation):
- UIProcess/cf/WebPageProxyCF.cpp:
- 3:28 PM Changeset in webkit [75020] by
-
- 12 edits4 adds in trunk
2011-01-04 Darin Adler <Darin Adler>
Reviewed by Brady Eidson.
Add back/forward encoding and decoding to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51901
- WebCore.exp.in: Export functions used in WebKit2.
- history/HistoryItem.cpp: (WebCore::HistoryItem::encodeBackForwardTree): Use references instead of pointers. (WebCore::HistoryItem::encodeBackForwardTreeNode): Ditto. (WebCore::HistoryItem::decodeBackForwardTree): Ditto.
- history/HistoryItem.h: Ditto.
- platform/network/FormData.cpp: (WebCore::encode): Ditto. (WebCore::decode): Ditto. (WebCore::FormData::encodeForBackForward): Ditto. (WebCore::FormData::decodeForBackForward): Ditto.
- platform/network/FormData.h: Ditto.
2011-01-04 Darin Adler <Darin Adler>
Reviewed by Brady Eidson.
Add back/forward encoding and decoding to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51901
- GNUmakefile.am: Added new source files.
- WebKit2.pro: Ditto.
- WebKit2.xcodeproj/project.pbxproj: Ditto.
- win/WebKit2.vcproj: Ditto.
- WebProcess/WebPage/DecoderAdapter.cpp: Added.
- WebProcess/WebPage/DecoderAdapter.h: Added.
- WebProcess/WebPage/EncoderAdapter.cpp: Added.
- WebProcess/WebPage/EncoderAdapter.h: Added.
- WebProcess/WebPage/WebBackForwardListProxy.cpp: (WebKit::updateBackForwardItem): Added code to encode the back/forward tree and send it along. The code to decode needs to wait on Brady's current project.
- 3:17 PM Changeset in webkit [75019] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-04 Daniel Bates <dbates@rim.com>
Fix the Android build after changeset 74975 <http://trac.webkit.org/changeset/74975>
(https://bugs.webkit.org/show_bug.cgi?id=51855).
- wtf/ThreadingPthreads.cpp: Add include of PassOwnPtr.h. (WTF::runThreadWithRegistration): Use -> instead of . to dereference pointer.
- 3:05 PM Changeset in webkit [75018] by
-
- 7 edits in trunk
2011-01-04 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Implement sel.modify('move', 'left'/'right', 'lineBoundary').
https://bugs.webkit.org/show_bug.cgi?id=33435
- editing/SelectionController.cpp: (WebCore::SelectionController::modifyMovingRight): (WebCore::SelectionController::modifyMovingLeft):
- editing/visible_units.cpp: (WebCore::logicalStartOfLine): (WebCore::logicalEndOfLine): (WebCore::leftBoundaryOfLine): (WebCore::rightBoundaryOfLine):
- editing/visible_units.h:
2011-01-04 Xiaomei Ji <xji@chromium.org>
Implement sel.modify('move', 'left'/'right', 'lineBoundary').
https://bugs.webkit.org/show_bug.cgi?id=33435
- editing/selection/home-end-expected.txt:
- editing/selection/home-end.html:
- 3:04 PM Changeset in webkit [75017] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-04 Martin Robinson <mrobinson@igalia.com>
Try to fix the EFL build.
- wtf/CMakeLists.txt: Remove PlatformRefPtr from the CMake source list.
- 2:58 PM Changeset in webkit [75016] by
-
- 21 edits in trunk
2011-01-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Use the default CSS text input control border width of relying on the GTK+ theme
https://bugs.webkit.org/show_bug.cgi?id=51887
Update all results that use text areas. These controls now have a 1 pixel
border (the default in html.css) instead of using the border size from the
GTK+ theme.
- platform/gtk/fast/forms/basic-textareas-expected.txt:
- platform/gtk/fast/forms/form-element-geometry-expected.txt:
- platform/gtk/fast/forms/onselect-textarea-expected.txt:
- platform/gtk/fast/forms/placeholder-stripped-expected.txt:
- platform/gtk/fast/forms/search-styled-expected.txt:
- platform/gtk/fast/forms/textAreaLineHeight-expected.txt:
- platform/gtk/fast/forms/textarea-align-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-set-value-expected.txt:
- platform/gtk/fast/forms/textarea-scroll-height-expected.txt:
- platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
- platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
- platform/gtk/fast/forms/textarea-setinnerhtml-expected.txt:
- platform/gtk/fast/forms/textarea-width-expected.txt:
2011-01-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Use the default CSS text input control border width of relying on the GTK+ theme
https://bugs.webkit.org/show_bug.cgi?id=51887
Do not rely on the GTK+ theme to determine text control borders. This simplifies
the RenderTheme code, prevents metrics differences between GTK+ 2.x and 3.x and
doesn't break the rendering of any theme that I've encountered.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::adjustSearchFieldStyle): No longer call setTextInputBorders, but still disable any border radius.
- platform/gtk/RenderThemeGtk.h: Remove setTextInputBorders and no longer override the default style of text areas and text input controls.
- platform/gtk/RenderThemeGtk2.cpp: Ditto.
- platform/gtk/RenderThemeGtk3.cpp: Ditto.
- 2:58 PM Changeset in webkit [75015] by
-
- 2 edits in trunk/WebKit2
<rdar://problem/8766999> WebKit2: Sandboxing causes certificate error on access to any HTTPS URL
Reviewed by Sam Weinig.
Allow read access to /Library/Preferences/com.apple.security.plist.
- WebProcess/com.apple.WebProcess.sb:
- 2:56 PM Changeset in webkit [75014] by
-
- 6 edits2 copies in branches/chromium/552
Merge 74636 - 2010-12-24 Justin Schuh <jschuh@chromium.org>
Reviewed by Nikolas Zimmermann.
SVGElementInstance::m_useElement should be cleared when use element is removed from document
https://bugs.webkit.org/show_bug.cgi?id=51486
Test: svg/custom/use-instanceRoot-with-use-removed.svg
- svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
- svg/SVGElementInstance.h: (WebCore::SVGElementInstance::clearUseElement):
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::removedFromDocument): (WebCore::ShadowTreeUpdateBlocker::if): (WebCore::SVGUseElement::detachInstance): (WebCore::SVGUseElement::detach):
- svg/SVGUseElement.h:
2010-12-24 Justin Schuh <jschuh@chromium.org>
Reviewed by Nikolas Zimmermann.
SVGElementInstance::m_useElement should be cleared when use element is removed from document
https://bugs.webkit.org/show_bug.cgi?id=51486
- svg/custom/use-instanceRoot-with-use-removed-expected.txt: Added.
- svg/custom/use-instanceRoot-with-use-removed.svg: Added.
BUG=67363
TBR=jschuh@chromium.org
- 2:56 PM Changeset in webkit [75013] by
-
- 3 edits in trunk/WebKit2
Build fixes.
- UIProcess/qt/TextCheckerQt.cpp:
- UIProcess/win/TextCheckerWin.cpp:
- 2:49 PM Changeset in webkit [75012] by
-
- 2 edits in trunk/WebKit2
Don't use macros for the key names.
Reviewed by Darin Adler.
- UIProcess/mac/TextCheckerMac.mm:
- 2:47 PM Changeset in webkit [75011] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-01-04 James Robinson <jamesr@chromium.org>
Reviewed by Darin Adler.
StackBounds initialization in WTFThreadData should be guarded by #if USE(JSC)
https://bugs.webkit.org/show_bug.cgi?id=51881
The StackBounds class is only used by JavaScriptCore.
- wtf/WTFThreadData.cpp: (WTF::WTFThreadData::WTFThreadData):
- wtf/WTFThreadData.h: (WTF::WTFThreadData::resetCurrentIdentifierTable):
- 2:41 PM Changeset in webkit [75010] by
-
- 17 edits1 add in trunk/WebKit2
2011-01-04 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Send over text checker state to the web process
https://bugs.webkit.org/show_bug.cgi?id=51896
- Platform/CoreIPC/Arguments.h: Remove 'const' from the argument, this matches all the other Arguments classes.
- Shared/TextCheckerState.h: Added. New class with text checker state.
- Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h: Add textCheckerState.
- UIProcess/API/mac/WKView.mm: (-[WKView validateUserInterfaceItem:]): (-[WKView toggleContinuousSpellChecking:]): (-[WKView toggleGrammarChecking:]): (-[WKView toggleAutomaticSpellingCorrection:]): Get the needed flags from the text checker state.
- UIProcess/TextChecker.h: Add state() function, remove getters.
- UIProcess/WebContext.cpp: (WebKit::WebContext::ensureWebProcess): Initialize the text checker state.
- UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::updateTextCheckerState): Send the SetTextCheckerState message to the web process.
- UIProcess/mac/TextCheckerMac.mm: (WebKit::initializeState): Initialize the state from the user defaults.
(WebKit::TextChecker::state):
Return the state.
(WebKit::TextChecker::setContinuousSpellCheckingEnabled):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::setAutomaticSpellingCorrectionEnabled):
Make sure to write the new state.
- UIProcess/qt/TextCheckerQt.cpp: (WebKit::TextChecker::state):
- UIProcess/win/TextCheckerWin.cpp: (WebKit::TextChecker::state): Add stubs.
- WebKit2.xcodeproj/project.pbxproj: Add TextCheckerState.h.
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): Initialize m_textCheckerState.
(WebKit::WebProcess::setTextCheckerState):
Update.
- WebProcess/WebProcess.messages.in: Add SetTextCheckerState message.
- win/WebKit2.vcproj: Add TextCheckerState.h.
- 2:29 PM Changeset in webkit [75009] by
-
- 53 edits1 delete in trunk
2011-01-03 Martin Robinson <mrobinson@igalia.com>
Reviewed by Darin Adler.
Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=51846
- GNUmakefile.am: Remove PlatformRefPtr.h from the sources list.
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
- jit/ExecutableAllocator.h: Change references to PlatformRefPtr to RefPtr. (JSC::ExecutableAllocator::cacheFlush): Ditto.
- wtf/PlatformRefPtr.h: Removed.
- wtf/RandomNumber.cpp: Change references to PlatformRefPtr to RefPtr. (WTF::randomNumber): Ditto.
- wtf/brew/RefPtrBrew.h: Ditto. (WTF::refIfNotNull): Added. (WTF::derefIfNotNull): Added.
- wtf/brew/ShellBrew.h: Change references to PlatformRefPtr to RefPtr. (WTF::createRefPtrInstance): Modified to return a RefPtr.
- wtf/gobject/GRefPtr.cpp: (WTF::refGPtr): Moved from PlatformRefPtr here. (WTF::derefGPtr): Ditto.
- wtf/gobject/GRefPtr.h: Ditto. (WTF::GRefPtr::GRefPtr): Ditto. (WTF::GRefPtr::~GRefPtr): Ditto. (WTF::GRefPtr::clear): Ditto. (WTF::GRefPtr::isHashTableDeletedValue): Ditto. (WTF::GRefPtr::get): Ditto. (WTF::GRefPtr::operator*): Ditto. (WTF::GRefPtr::operator->): Ditto. (WTF::GRefPtr::operator!): Ditto. (WTF::GRefPtr::operator UnspecifiedBoolType): Ditto. (WTF::GRefPtr::hashTableDeletedValue): Ditto. (WTF::::operator): Ditto. (WTF::::swap): Ditto. (WTF::swap): Ditto. (WTF::operator==): Ditto. (WTF::operator!=): Ditto. (WTF::static_pointer_cast): Ditto. (WTF::const_pointer_cast): Ditto. (WTF::getPtr): Ditto. (WTF::adoptGRef): Ditto. (WTF::refGPtr): Ditto. (WTF::derefGPtr): Ditto.
2011-01-03 Martin Robinson <mrobinson@igalia.com>
Reviewed by Darin Adler.
Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=51846
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr back to GRefPtr.
2011-01-03 Martin Robinson <mrobinson@igalia.com>
Reviewed by Darin Adler.
Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=51846
No new tests. This should not introduce any functional changes.
Changed all references to PlatformRefPtr in GTK+ code to GRefPtr. Changed
all references to PlatformRefPtr in Brew code to RefPtr.
2011-01-03 Martin Robinson <mrobinson@igalia.com>
Reviewed by Darin Adler.
Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=51846
Changed all references to PlatformRefPtr in GTK+ code to GRefPtr.
- 2:28 PM Changeset in webkit [75008] by
-
- 3 edits2 copies in branches/chromium/552
Merge 74574
BUG=66748
- 2:21 PM Changeset in webkit [75007] by
-
- 3 edits2 copies in branches/chromium/552
Merge 73927
BUG=66560
- 2:07 PM Changeset in webkit [75006] by
-
- 5 edits1 move in trunk/WebCore
<http://webkit.org/b/51890> Move ResourceLoadPriority.h into WebCore/platform/network
Reviewed by Antti Koivisto.
This is needed to prevent a WebCore/platform policy violation in
my next patch.
- WebCore.gypi: Updated for moved header.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- platform/network/ResourceLoadPriority.h: Renamed from WebCore/loader/ResourceLoadPriority.h.
- 2:04 PM Changeset in webkit [75005] by
-
- 2 edits in trunk
2011-01-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by David Levin.
.gitignore should be updated to reflect Sources rename to Source
https://bugs.webkit.org/show_bug.cgi?id=51893
- .gitignore: Change all paths that reference the "Sources" directory to say "Source".
- 1:56 PM Changeset in webkit [75004] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-01-04 Ojan Vafai <ojan@chromium.org>
Increment version number to avoid getting the cached JS file.
- PrettyPatch/PrettyPatch.rb:
- 1:52 PM Changeset in webkit [75003] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2010-12-15 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
anchor the toolbar to the bottom of the diff if the diff doesn't take a full screen of height
https://bugs.webkit.org/show_bug.cgi?id=51162
- PrettyPatch/PrettyPatch.rb:
- code-review.js:
- 1:39 PM Changeset in webkit [75002] by
-
- 1 edit in branches/chromium/552/WebCore/dom/Range.cpp
Merge 73818 Build Fix for 552 branch
BUG=65942
- 1:35 PM Changeset in webkit [75001] by
-
- 2 edits in trunk/WebCore
- storage/StorageMap.h: mesured? Really?
Reviewed by a spell checker.
- 1:27 PM Changeset in webkit [75000] by
-
- 16 edits2 copies2 deletes in trunk
2011-01-04 Zhe Su <suzhe@chromium.org>
Reviewed by Kenneth Russell.
- Remove entry for editing/input/ime-composition-clearpreedit.html test.
- Improve fast/events/ime-composition-events-001.html to cover more cases. And fix test expectations of chromium port. https://bugs.webkit.org/show_bug.cgi?id=51693
- fast/events/ime-composition-events-001-expected.txt:
- fast/events/ime-composition-events-001.html:
- platform/chromium-mac/fast/events/ime-composition-events-001-expected.txt: Removed.
- platform/chromium-win/fast/events/ime-composition-events-001-expected.txt: Removed.
- platform/chromium/fast/events/ime-composition-events-001-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- platform/qt/fast/events/ime-composition-events-001-expected.txt: Added.
2011-01-04 Zhe Su <suzhe@chromium.org>
Reviewed by Kenneth Russell.
Fix insertText, setMarkedText and unmarkText methods of
TextInputController to call corresponding methods of WebKit::WebView
rather than WebKit::WebFrame. This change matches the behavior of
chromium browser.
insertText corresponds to WebView::confirmComposition(text)
setMarkedText corresponds to WebView::setComposition(...)
unmarkText corresponds to WebView::confirmComposition()
https://bugs.webkit.org/show_bug.cgi?id=51693
- DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::insertText): (TextInputController::setMarkedText): (TextInputController::unmarkText):
2011-01-04 Zhe Su <suzhe@chromium.org>
Reviewed by Kenneth Russell.
Changes:
- Add WebKit::WebWidget::confirmComposition(const WebString& text) This new method corresponds to Editor::confirmComposition(text) and Editor::insertText(text). It'll be used by both DumpRenderTree's TextInputController and chromium browser.
- Fix WebFrameImpl::insertText It should call Editor::confirmComposition(text) rather than Editor::insertText(text) if there is an ongoing composition. It matches the behavior of WebKit Mac port.
- Fix WebFrameImpl::setMarkedText Editor::confirmComposition(text) shouldn't be called in this method, which incorrectly inserts the text.
- public/WebWidget.h:
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::insertText): (WebKit::WebFrameImpl::setMarkedText):
- src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::confirmComposition):
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::confirmComposition):
- src/WebViewImpl.h:
- tests/PopupMenuTest.cpp: (WebKit::TestWebWidget::confirmComposition):
2011-01-04 Zhe Su <suzhe@chromium.org>
Reviewed by Kenneth Russell.
Fix test LayoutTests/fast/events/ime-composition-events-001.html.
- Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent): Calls editor->insertText() to insert the commit string when no composition text is available.
- 1:23 PM Changeset in webkit [74999] by
-
- 2 edits in trunk/WebKit2
Attach a radar # to this FIXME:
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
Rubberstamped by Anders Carlsson.
- 1:12 PM Changeset in webkit [74998] by
-
- 2 edits in trunk
2011-01-04 Dihan Wickremasuriya <dihan.wickremasuriya@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] [Symbian] Build system cleanup
After r74811 special handling for the Symbian build is no longer needed.
This patch reverts r58756.
- WebKit.pri:
- 1:09 PM Changeset in webkit [74997] by
-
- 5 edits in trunk/WebCore
2011-01-04 Carlos Garcia Campos <cgarcia@igalia.com> and Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Port stock icon painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51764
Port stock icon painting for media and search input elements to
GtkStyleContext. Also create the initial machinery for accessing
style contexts for all GTK+ 3.x based widgets.
No new tests. This should not change functionality.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::paintGdkPixbuf): (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): (WebCore::RenderThemeGtk::paintMediaButton):
- platform/gtk/RenderThemeGtk.h:
- platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::getStockIcon):
- platform/gtk/RenderThemeGtk3.cpp: (WebCore::gtkStyleChangedCallback): (WebCore::styleContextMap): (WebCore::getStyleContext): (WebCore::RenderThemeGtk::paintMenuList):
- 12:47 PM Changeset in webkit [74996] by
-
- 2 edits in trunk/WebKit/mac
<http://webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name
Reviewed by Eric Carlson.
This originally broke in r61581. It is inside an
ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac
build then.
- WebCoreSupport/WebFrameLoaderClient.mm: Call
(WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to
use WebCore::PluginInfo.name instead of
-[WebBasePluginPackage name].
- 12:46 PM Changeset in webkit [74995] by
-
- 8 edits4 adds in trunk
WebCore: Scripts should not be executed before preceding stylesheets are loaded
https://bugs.webkit.org/show_bug.cgi?id=8852
Reviewed by Dave Hyatt.
Block inline script execution on pending stylesheet loads. This matches
other browsers and HTML5.
Tests: fast/tokenizer/inline-script-stylesheet-write.html
fast/tokenizer/inline-script-stylesheet.html
- dom/PendingScript.cpp:
(WebCore::PendingScript::releaseElementAndClear):
- dom/PendingScript.h:
(WebCore::PendingScript::PendingScript):
(WebCore::PendingScript::operator=):
(WebCore::PendingScript::startingPosition):
(WebCore::PendingScript::setStartingPosition):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
This fixes an unrelated bug with beforeload events that was exposed by the other
changes (fast/dom/beforeload/remove-link-in-beforeload-listener.html).
- html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::sourceFromPendingScript):
(WebCore::HTMLScriptRunner::runScript):
LayoutTests: Scripts should not be executed before preceding stylesheets are loaded
https://bugs.webkit.org/show_bug.cgi?id=8852
Reviewed by Dave Hyatt.
New tests plus a few test with slightly changed output due to different load serialization behavior.
- fast/tokenizer/inline-script-stylesheet-expected.txt: Added.
- fast/tokenizer/inline-script-stylesheet-write-expected.txt: Added.
- fast/tokenizer/inline-script-stylesheet-write.html: Added.
- fast/tokenizer/inline-script-stylesheet.html: Added.
- http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
- platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- 12:43 PM Changeset in webkit [74994] by
-
- 6 edits in trunk/WebCore
2011-01-04 Xianzhu Wang <wangxianzhu@google.com>
Reviewed by Darin Adler.
Let DataView.getInt8() and DataView.setInt8() use int8_t instead of
ambiguous 'char' to fix fast/canvas/webgl/data-view-test.html failure
on ARM.
https://bugs.webkit.org/show_bug.cgi?id=51861
By the way, changed other getIntXX() and setIntXX() methods to use
more precise integer types.
- bindings/js/JSDataViewCustom.cpp: (WebCore::setDataViewMember):
- bindings/v8/custom/V8DataViewCustom.cpp: (WebCore::V8DataView::getInt8Callback): (WebCore::V8DataView::setInt8Callback):
- html/canvas/DataView.cpp: (WebCore::DataView::getInt8): (WebCore::DataView::setInt8):
- html/canvas/DataView.h:
- html/canvas/DataView.idl:
- 12:34 PM Changeset in webkit [74993] by
-
- 2 edits in trunk/LayoutTests
Unreviewed trivial fix after r74976.
- platform/qt/Skipped:
- 12:20 PM Changeset in webkit [74992] by
-
- 8 edits in trunk/WebCore
2011-01-04 Yong Li <yoli@rim.com>
Reviewed by Adam Barth.
Suspend HTMLParserScheduler when page load is deferred to
avoid potential JS re-entrancy. Otherwise, when JS execution is triggered
from an external script or by events, and is blocked by a modal dialog,
WebKit can parse more HTML source and also start another JS execution.
Test case: WebCore/manual-tests/bugzilla-48077.html.
- dom/DocumentParser.cpp: (WebCore::DocumentParser::suspendScheduledTasks): (WebCore::DocumentParser::resumeScheduledTasks):
- dom/DocumentParser.h:
- html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::suspendScheduledTasks): (WebCore::HTMLDocumentParser::resumeScheduledTasks):
- html/parser/HTMLParserScheduler.cpp: (WebCore::HTMLParserScheduler::HTMLParserScheduler): (WebCore::HTMLParserScheduler::suspend): (WebCore::HTMLParserScheduler::resume):
- html/parser/HTMLParserScheduler.h: (WebCore::HTMLParserScheduler::isScheduledForResume):
- page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
- 12:07 PM Changeset in webkit [74991] by
-
- 1 edit in branches/chromium/552/WebCore/dom/Range.cpp
Merge 73818 - 2010-12-10 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION(r73799): editing/execCommand/4920488.html fails
https://bugs.webkit.org/show_bug.cgi?id=50854
The regression was caused by Range::processContents's not extracting
m_end.container()->firstChild(). Fixed the bug by always adding the first child.
- dom/Range.cpp: (WebCore::Range::processContents):
TBR=rniwa@webkit.org
BUG=65942
- 12:04 PM Changeset in webkit [74990] by
-
- 1 edit2 copies in branches/chromium/552
Merge 73799 - 2010-12-10 Emil Eklund <eae@chromium.org>
Reviewed by Adam Barth.
Fix crash in Range::processContents when modified during mutation event.
https://bugs.webkit.org/show_bug.cgi?id=50710
Test: fast/dom/Range/range-extractContents.html
- dom/Range.cpp: (WebCore::Range::processContents): Replace raw pointers with RefPtrs and add checks.
2010-12-10 Emil Eklund <eae@chromium.org>
Reviewed by Adam Barth.
Add testcase for range.extractContents crash.
https://bugs.webkit.org/show_bug.cgi?id=50710
- fast/dom/Range/range-extractContents-expected.txt: Added.
- fast/dom/Range/range-extractContents.html: Added.
TBR=inferno@chromium.org
BUG=65942
- 11:49 AM Changeset in webkit [74989] by
-
- 6 edits in trunk/WebKit2
2011-01-04 Anders Carlsson <andersca@apple.com>
Reviewed by John Sullivan.
Add more spelling/grammar related methods
https://bugs.webkit.org/show_bug.cgi?id=51886
- UIProcess/API/mac/WKView.mm: (-[WKView validateUserInterfaceItem:]): Handle more selectors.
(-[WKView showGuessPanel:]):
Add stub.
(-[WKView checkSpelling:]):
Ditto.
(-[WKView toggleAutomaticSpellingCorrection:]):
Toggle automatic spelling correction.
- UIProcess/TextChecker.h: Add setAutomaticSpellingCorrectionEnabled and isAutomaticSpellingCorrectionEnabled.
- UIProcess/mac/TextCheckerMac.mm: (WebKit::TextChecker::setAutomaticSpellingCorrectionEnabled): (WebKit::TextChecker::isAutomaticSpellingCorrectionEnabled): Update the toggle.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
- WebProcess/WebCoreSupport/mac/WebErrorsMac.mm: Add a Radar URL for the localization FIXMEs.
- 11:40 AM Changeset in webkit [74988] by
-
- 2 edits in trunk/WebKit2
Unreviewed build fix.
- win/WebKit2.vcproj: Correct the missing $(WebKitVSPropsRedirectionDir)
variables that Visual Studio helpfully removes when making changes.
- 11:38 AM Changeset in webkit [74987] by
-
- 3 edits16 copies2 deletes in branches/chromium/552
Merge 74954
BUG=66760
- 11:35 AM Changeset in webkit [74986] by
-
- 1 edit2 copies in branches/chromium/552
Merge 74364
BUG=66760
- 11:33 AM Changeset in webkit [74985] by
-
- 1 edit in trunk/Source/JavaScriptCore/ChangeLog
2011-01-04 Daniel Bates <dbates@rim.com>
Fix the date recorded in the change log entry for changeset 74973 <http://trac.webkit.org/changeset/74973>.
It was recorded as "2011-01-03". Instead, it should be "2011-01-04" to correspond
with the date this changeset was committed.
- 11:29 AM Changeset in webkit [74984] by
-
- 1 edit2 copies in branches/chromium/552
Merge 74787
BUG=68181
- 11:29 AM Changeset in webkit [74983] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-04 Daniel Bates <dbates@rim.com>
Reviewed by Adam Roben.
LEAK: Deallocate instance of ThreadFunctionInvocation if thread creation fails
https://bugs.webkit.org/show_bug.cgi?id=51860
- wtf/ThreadingWin.cpp: (WTF::createThreadInternal):
- 11:26 AM Changeset in webkit [74982] by
-
- 1 edit2 copies in branches/chromium/552
Merge 74781
BUG=66986
- 11:24 AM Changeset in webkit [74981] by
-
- 1 edit4 copies in branches/chromium/552
Merge 74743
BUG=65796
- 11:21 AM Changeset in webkit [74980] by
-
- 2 edits in trunk/WebKit2
Unreviewed build fix.
- win/WebKit2.vcproj: Disable CG-specific WKImageCG.cpp from
Debug_Cairo_CFLite/Release_Cario_CFLite builds.
- 11:19 AM Changeset in webkit [74979] by
-
- 1 edit2 copies in branches/chromium/552
Merge 73801
BUG=66473
- 11:16 AM Changeset in webkit [74978] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-04 Laszlo Gombos <Laszlo Gombos>
Reviewed by Ariya Hidayat.
[Qt][Symbian] Make sure that WebKit headers are included before platform headers on Symbian
https://bugs.webkit.org/show_bug.cgi?id=31273
On Symbian PREPEND_INCLUDEPATH is the best way to make sure that WebKit headers
are included before platform headers. On all other platforms continue to use
INCLUDEPATH (as before). This is a continuation of r65877.
No new tests as there is no new functionality.
- JavaScriptCore.pri:
- 11:11 AM Changeset in webkit [74977] by
-
- 2 edits in trunk/Source/JavaScriptCore
Try to fix Windows build.
- wtf/ThreadingWin.cpp: Added include of PassOwnPtr.h. Fixed paragraphing
of conditional includes.
(WTF::wtfThreadEntryPoint): Use -> instead of . to dereference pointer.
(WTF::createThreadInternal): Tweaked #if to not need separate macro.
- 11:04 AM Changeset in webkit [74976] by
-
- 2 edits in trunk/LayoutTests
2011-01-04 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; Added editing/selection/caret-bidi-first-and-last-letters.html to Qt's skipped list.
The tracking bug 51884 (https://bugs.webkit.org/show_bug.cgi?id=51884) has been filed.
- platform/qt/Skipped:
- 10:56 AM Changeset in webkit [74975] by
-
- 4 edits1 add in trunk/Source/JavaScriptCore
2011-01-04 Daniel Bates <dbates@rim.com>
Reviewed by Adam Roben.
Extract ThreadFunctionInvocation into separate file and share between Apple Windows and Android
https://bugs.webkit.org/show_bug.cgi?id=51855
Both the Apple Windows and Android ports implement a similar adapter structure,
called ThreadFunctionInvocation and ThreadData respectively, as part of
their thread creation process. Instead, we should share such an adapter
structure and remove duplicate code.
- JavaScriptCore.gypi: Added header wtf/ThreadFunctionInvocation.h.
- wtf/ThreadFunctionInvocation.h: Added. (WTF::ThreadFunctionInvocation::ThreadFunctionInvocation):
- wtf/ThreadingPthreads.cpp: Removed Android-specific structure ThreadData; Instead, use ThreadFunctionInvocation. (WTF::runThreadWithRegistration): (WTF::createThreadInternal):
- wtf/ThreadingWin.cpp: Moved structure ThreadFunctionInvocation to its own file so that it can be shared with the Android implementation of createThreadInternal(). (WTF::wtfThreadEntryPoint): Use OwnPtr to hold passed instance of ThreadFunctionInvocation.
- 10:53 AM Changeset in webkit [74974] by
-
- 2 edits in trunk/Tools
2011-01-04 Dihan Wickremasuriya <dihan.wickremasuriya@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] [Symbian] Do not remove 0 byte sized files from productDir
On Symbian productDir points to the source directory. Removing all the
empty files from the productDir directory corrupts the svn repository.
- Scripts/build-webkit:
- 10:32 AM BuildBot edited by
- Add umask change for slaves (diff)
- 9:44 AM Changeset in webkit [74973] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-03 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Use builtin_expect when compiling using RVCT in GNU mode
https://bugs.webkit.org/show_bug.cgi?id=51866
Derived from a patch by Dave Tapuska.
- wtf/AlwaysInline.h:
- 9:29 AM Changeset in webkit [74972] by
-
- 2 edits in trunk/WebCore
2011-01-04 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
Include glib-object.h for GObject
https://bugs.webkit.org/show_bug.cgi?id=51876
- bindings/gobject/DOMObjectCache.cpp:
- 9:21 AM Changeset in webkit [74971] by
-
- 4 edits2 adds in trunk
2011-01-04 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dan Bernstein.
Clicking on the first or the last letter of LTR/RTL text in a RTL/LTR block puts caret on the opposite side.
https://bugs.webkit.org/show_bug.cgi?id=50992
Fixed the bug by interchanging the offset when the direction of inline text box and the containing block
does not match. Reused the code added by http://trac.webkit.org/changeset/73553.
Test: editing/selection/caret-bidi-first-and-last-letters.html
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::offsetForPosition):
2011-01-04 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Dan Bernstein.
Clicking on the first or the last letter of LTR/RTL text in a RTL/LTR block puts caret on the opposite side.
https://bugs.webkit.org/show_bug.cgi?id=50992
Added a test to ensure WebKit places the caret on the side user clicked even when text's natural direction
and the containing block's direction do not match.
- editing/selection/caret-bidi-first-and-last-letters-expected.txt: Added.
- editing/selection/caret-bidi-first-and-last-letters.html: Added.
- editing/selection/resources/caret-edge-shared.js: Avoid calling verify() outside of DRT.
- 9:05 AM Changeset in webkit [74970] by
-
- 11 edits in trunk/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51856
Pass encoded back/forward tree data from the WebProcess to the UIProcess
Reviewed by Darin Adler.
Remove the WKBackForwardListItemCopyOriginalURL API as it's not needed:
- UIProcess/API/C/WKBackForwardListItem.cpp:
- UIProcess/API/C/WKBackForwardListItem.h:
- UIProcess/API/qt/qwkhistory.cpp:
- UIProcess/API/qt/qwkhistory.h:
- UIProcess/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::WebBackForwardListItem):
- UIProcess/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::create):
(WebKit::WebBackForwardListItem::setBackForwardData):
(WebKit::WebBackForwardListItem::backForwardData):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addBackForwardItem):
- UIProcess/WebProcessProxy.h:
- UIProcess/WebProcessProxy.messages.in:
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::updateBackForwardItem):
- 8:56 AM Changeset in webkit [74969] by
-
- 22 edits in trunk
2010-12-29 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Adler.
Remove 2 unnecessary includes from Document.h
https://bugs.webkit.org/show_bug.cgi?id=51727
No new tests because no changed functionality.
- dom/Document.cpp:
- dom/Document.h:
- editing/Editor.cpp:
- editing/SpellChecker.h:
- editing/SplitTextNodeCommand.cpp:
- editing/TextCheckingHelper.cpp:
- page/FrameView.cpp:
- page/Page.cpp:
- rendering/HitTestResult.cpp:
- rendering/InlineTextBox.cpp:
- rendering/InlineTextBox.h:
- rendering/svg/SVGInlineFlowBox.cpp:
- 7:33 AM Changeset in webkit [74968] by
-
- 2 edits in trunk/WebCore
2011-01-04 Patrick Gansterer <Patrick Gansterer>
Unreviewed WinCE build fix.
- CMakeListsWinCE.txt: Added missing include directories, files and libraries.
- 6:01 AM Changeset in webkit [74967] by
-
- 7 edits2 moves in trunk/WebKit2
2011-01-04 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Incomplete clean up on termination
https://bugs.webkit.org/show_bug.cgi?id=51474
Do not kill the web process to force it's termination.
Fix object destruction and cleanup logic and make the cleanup more reliable.
Do not try to cleanup on crash because it is not reliable.
- Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::Connection::platformInvalidate): Do not delete the socket if we do not own it. This is the case with a server connection.
- Platform/qt/MappedMemoryPool.cpp: Turn MappedMemoryPool into a QObject so the CleanupHandler can destruct it in the same way as the other objects. (WebKit::MappedMemoryPool::instance): (WebKit::MappedMemoryPool::~MappedMemoryPool):
- Platform/qt/MappedMemoryPool.h: (WebKit::MappedMemoryPool::MappedMemoryPool):
- Platform/qt/SharedMemoryQt.cpp: (WebKit::SharedMemory::create): No need to care about QCoreApplication::aboutToQuit. It is handled by the CleanupHandler. (WebKit::SharedMemory::~SharedMemory): Ditto.
- Shared/qt/CleanupHandler.cpp: Renamed from WebKit2/Shared/qt/CrashHandler.cpp. No longer try to handle crash but just normal termination. (WebKit::CleanupHandler::CleanupHandler): Connect deleteObjects with QCoreApplication::aboutToQuit. Ensure appropriate thread affinity. (WebKit::CleanupHandler::sigTermHandler): Stop the main event loop. (WebKit::CleanupHandler::deleteObjects): Use deleteLater instead of delete since it is more reliable.
- Shared/qt/CleanupHandler.h: Renamed from WebKit2/Shared/qt/CrashHandler.h. (WebKit::CleanupHandler::instance): (WebKit::CleanupHandler::markForCleanup): (WebKit::CleanupHandler::unmark):
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Do not kill the web process immidiately but give it a chance to cleanup. Use QLocalServer::removeServer for assuring that the socket file will be removed. (WebKit::ProcessLauncherHelper::serverName): (WebKit::cleanupAtExit): Renamed from cleanupProcesses. Only kill the web process when it times out terminating. Fixed the bug of changing the list while iterating it over by disconnecting from the processStateChanged slot. (WebKit::QtWebProcess::QtWebProcess): Added missing meta type registration of QProcess::ProcessState. (WebKit::ProcessLauncherHelper::~ProcessLauncherHelper): (WebKit::ProcessLauncherHelper::ProcessLauncherHelper): No need to add the the instance to the CleanupHandler because we will remove the socket file in cleanupAtExit. (WebKit::ProcessLauncherHelper::instance): (WebKit::ProcessLauncher::terminateProcess):
- WebKit2.pro:
- 5:44 AM Changeset in webkit [74966] by
-
- 3 edits in trunk/WebKit/wince
2011-01-04 Patrick Gansterer <Patrick Gansterer>
Unreviewed WinCE build fix.
- WebCoreSupport/ChromeClientWinCE.cpp: (WebKit::ChromeClientWinCE::exceededDatabaseQuota): Added missing semicolon. (WebKit::ChromeClientWinCE::reachedApplicationCacheOriginQuota):
- WebCoreSupport/ChromeClientWinCE.h:
- 5:17 AM Changeset in webkit [74965] by
-
- 2 edits in trunk/WebCore
2011-01-04 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Simon Hausmann.
Provide an interface to require using fullscreen mediaplayer
https://bugs.webkit.org/show_bug.cgi?id=51133
Only video should be displayed in fullscreen when
requiresFullscreenForVideoPlayback is specified.
No new tests because no client implements requiresFullscreenForVideoPlayback yet.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::updatePlayState):
- 3:53 AM Changeset in webkit [74964] by
-
- 9 edits in trunk
2011-01-04 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [WK2] create an initial implementation of the context menu handling for WebKit 2
https://bugs.webkit.org/show_bug.cgi?id=51825
Implement contextMenuItemVector() for Qt, this method is used in WebKit 2 to get the
platform independent menu informations.
- platform/qt/ContextMenuQt.cpp: (WebCore::contextMenuItemVector):
2011-01-04 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] [WK2] create an initial implementation of the context menu handling for WebKit 2
https://bugs.webkit.org/show_bug.cgi?id=51825
Implement the necessary methods to get a basic context menu working for Qt.
Only 4 basic WebAction have been added on the UIProcess side: back, forward, stop and reload.
- UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::QGraphicsWKView): (QGraphicsWKView::showContextMenu): (QGraphicsWKViewPrivate::QGraphicsWKViewPrivate):
- UIProcess/API/qt/qgraphicswkview.h:
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::createContextMenuProxy):
- UIProcess/API/qt/qwkpage.h:
- UIProcess/qt/WebContextMenuProxyQt.cpp: (WebKit::webActionForContextMenuAction): (WebKit::WebContextMenuProxyQt::WebContextMenuProxyQt): (WebKit::WebContextMenuProxyQt::create): (WebKit::WebContextMenuProxyQt::showContextMenu): (WebKit::WebContextMenuProxyQt::hideContextMenu): (WebKit::WebContextMenuProxyQt::createContextMenu):
- UIProcess/qt/WebContextMenuProxyQt.h:
- 2:43 AM Changeset in webkit [74963] by
-
- 3 edits2 deletes in trunk
2011-01-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74960.
http://trac.webkit.org/changeset/74960
https://bugs.webkit.org/show_bug.cgi?id=51868
Rollout since we hit an assert after this patch. (Requested by
krit on #webkit).
- svg/custom/recursive-use-expected.txt: Removed.
- svg/custom/recursive-use.svg: Removed.
2011-01-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74960.
http://trac.webkit.org/changeset/74960
https://bugs.webkit.org/show_bug.cgi?id=51868
Rollout since we hit an assert after this patch. (Requested by
krit on #webkit).
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildInstanceTree):
- 1:43 AM Changeset in webkit [74962] by
-
- 2 edits in trunk/WebCore
2011-01-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74961.
http://trac.webkit.org/changeset/74961
https://bugs.webkit.org/show_bug.cgi?id=51867
breaks 32/64-bits debug bots build (Requested by philn-tp on
#webkit).
- platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::setWindowOverlay):
- 1:12 AM Changeset in webkit [74961] by
-
- 2 edits in trunk/WebCore
2011-01-03 Philippe Normand <pnormand@igalia.com>
Rubber-stamped by Eric Seidel.
[GStreamer] build fails with gstreamer core 0.10.31 and -plugins-base 0.10.30
https://bugs.webkit.org/show_bug.cgi?id=51810
Based on a patch by Mart Raudsepp.
No new tests, build fix only.
- platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::setWindowOverlay): Use the new xoverlay API if the GST_CHECK_PLUGINS_BASE_VERSION macro is defined. It was introduced in same version as the xoverlay API change.
- 1:11 AM Changeset in webkit [74960] by
-
- 3 edits2 adds in trunk
2011-01-04 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Dirk Schulze.
Malformed SVG causes crash in updateContainerOffset
https://bugs.webkit.org/show_bug.cgi?id=44610
Test case for recursive svg <use>.
This test case passes if no crash occurs.
- svg/custom/recursive-use-expected.txt: Added.
- svg/custom/recursive-use.svg: Added.
2011-01-04 Leo Yang <leo.yang@torchmobile.com.cn>
Reviewed by Dirk Schulze.
Malformed SVG causes crash in updateContainerOffset
https://bugs.webkit.org/show_bug.cgi?id=44610
We should check recursive <use> at the begining of
WebCore::SVGUseElement::buildInstanceTree instead
of at the end of it because the target element's
children may cause infinite recursive <use>.
Test: svg/custom/recursive-use.svg
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildInstanceTree):
- 12:33 AM Changeset in webkit [74959] by
-
- 2 edits in trunk/WebCore
2011-01-04 Kent Tamura <tkent@chromium.org>
Unreviewed, build fix.
Try to fix Clang build.
- css/CSSParser.cpp: (WebCore::valueFromSideKeyword): (WebCore::CSSParser::parseLinearGradient):
Jan 3, 2011:
- 10:47 PM Changeset in webkit [74958] by
-
- 1 edit28 adds in trunk/LayoutTests
2011-01-03 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update
Add expectations of r74954 tests for Chromium.
- platform/chromium-linux/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
- platform/chromium-linux/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
- platform/chromium-linux/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
- platform/chromium-linux/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
- platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
- platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
- platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
- platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
- platform/chromium-mac/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
- platform/chromium-mac/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
- platform/chromium-mac/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
- platform/chromium-mac/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
- platform/chromium-mac/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
- platform/chromium-mac/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
- platform/chromium-mac/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
- platform/chromium-mac/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
- platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
- platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
- platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.txt: Added.
- platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
- platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
- platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.txt: Added.
- platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
- platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
- platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added.
- platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
- platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
- platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added.
- 10:20 PM Changeset in webkit [74957] by
-
- 3 edits4 adds in trunk
WebCore: HTML5 Conformance Test failure: approved/xhtml5/object_border_pixel.xhtml
https://bugs.webkit.org/show_bug.cgi?id=48596
Patch by Julie-Jeongeun-Kim <Jeongeun.Kim@obigo.com> on 2011-01-03
Reviewed by Darin Adler.
border attribute was not parsed in HTMLObjectElement.
I added code for it as HTMLImageElement handled.
new test:fast/html/object-border.html
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):
LayoutTests: HTML5 Conformance Test failure: approved/xhtml5/object_border_pixel.xhtml
https://bugs.webkit.org/show_bug.cgi?id=48596
Patch by Julie-Jeongeun-Kim <Jeongeun.Kim@obigo.com> on 2011-01-03
Reviewed by Darin Adler.
- fast/html/object-border-expected.txt: Added.
- fast/html/object-border.html: Added.
- fast/html/resources/images/blue-border.png: Added.
- fast/html/resources/images/blue.png: Added.
- 9:36 PM Changeset in webkit [74956] by
-
- 2 edits in trunk/WebCore
Try to fix Chromium build.
- history/HistoryItem.cpp:
(WebCore::HistoryItem::encodeBackForwardTreeNode): Added a V8 case here.
Not sure this ever will be used with V8.
(WebCore::HistoryItem::decodeBackForwardTree): Ditto.
- 9:31 PM Changeset in webkit [74955] by
-
- 2 edits in trunk/WebCore
Try to fix Leopard build.
- history/HistoryItem.cpp: Use a consistent type, uint64_t, for the
size variable.
- 6:27 PM Changeset in webkit [74954] by
-
- 5 edits16 adds2 deletes in trunk
2011-01-01 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
Fixes before child calculation when adding anonymous childs to table parts.
https://bugs.webkit.org/show_bug.cgi?id=50932
Fix in r74364 was incomplete. When before child is equal to the table part(to
which the new child is getting added), it confuses the table part to add it
incorrectly as an after child. The patch fixes by passing the before child as
the table part's first child.
Tests: fast/css-generated-content/table-before-after-child-add.html
fast/css-generated-content/table-cell-before-after-child-add.html
fast/css-generated-content/table-row-before-after-child-add.html
fast/css-generated-content/table-row-before-after-child-add.html
- rendering/RenderTable.cpp: (WebCore::RenderTable::addChild):
- rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild):
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild):
2010-12-20 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
Tests that "before" and "after" childs are added to table correctly.
https://bugs.webkit.org/show_bug.cgi?id=50932
- fast/css-generated-content/table-before-after-child-add.html: Added.
- fast/css-generated-content/table-before-child-add.html: Removed.
- fast/css-generated-content/table-cell-before-after-child-add.html: Added.
- fast/css-generated-content/table-row-before-after-child-add.html: Added.
- platform/mac/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
- platform/mac/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
- platform/mac/fast/css-generated-content/table-before-after-child-add-expected.txt: Added.
- platform/mac/fast/css-generated-content/table-before-child-add-expected.txt: Removed.
- platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
- platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
- platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.txt: Added.
- platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
- platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
- platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added.
- platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
- platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
- platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added.
- 6:02 PM Changeset in webkit [74953] by
-
- 3 edits in trunk/WebCore
Shrink HTMLTableCellElement
https://bugs.webkit.org/show_bug.cgi?id=51858
Reviewed by Simon Fraser.
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::HTMLTableCellElement): Removed intialization of m_row and
m_col.
- html/HTMLTableCellElement.h: Removed m_row and m_col and their accessors.
- 5:57 PM Changeset in webkit [74952] by
-
- 4 edits in trunk/WebCore
Fix build.
- platform/network/FormData.cpp:
(WebCore::FormData::create): Roll back uint8_t change.
(WebCore::FormData::flatten): Ditto.
(WebCore::FormData::flattenToString): Ditto.
(WebCore::encode): Ditto.
(WebCore::decode): Ditto.
(WebCore::FormData::encodeForBackForward):
- platform/network/FormData.h: Ditto.
- platform/network/mac/FormDataStreamMac.mm:
(WebCore::advanceCurrentStream): Ditto.
- 5:35 PM Changeset in webkit [74951] by
-
- 6 edits in trunk/WebCore
2011-01-03 Darin Adler <Darin Adler>
Reviewed by Brady Eidson.
Add code to encode/decode the back/forward tree
https://bugs.webkit.org/show_bug.cgi?id=51853
- history/HistoryItem.cpp: (WebCore::HistoryItem::encodeBackForwardTree): Added. (WebCore::HistoryItem::encodeBackForwardTreeNode): Added. (WebCore::HistoryItem::decodeBackForwardTree): Added.
- history/HistoryItem.h: Added functions above.
- platform/network/FormData.cpp: (WebCore::FormData::create): Changed type to Vector<uint8_t> instead of Vector<char>. This type is used in our newer code for vectors of bytes. (WebCore::FormData::flatten): Ditto. (WebCore::FormData::flattenToString): Ditto. Had to add a cast here. (WebCore::FormData::encodeForBackForward): Added. (WebCore::FormData::decodeForBackForward): Added.
- platform/network/FormData.h: Changed type to Vector<uint8_t> instead of Vector<char>. Also made some single-argument constructors explicit. Also added the new functions.
- platform/network/mac/FormDataStreamMac.mm: (WebCore::advanceCurrentStream): Changed to use uint8_t to match above.
- 5:28 PM Changeset in webkit [74950] by
-
- 2 edits in trunk/WebCore
2011-01-03 Simon Fraser <Simon Fraser>
Attempt to fix GTK build.
- platform/graphics/gtk/FontGtk.cpp: (WebCore::drawGlyphsShadow):
- 4:54 PM Changeset in webkit [74949] by
-
- 2 edits in trunk/WebKit/cf
Mac build fix. Define WTF_USE_CFNETWORK for Windows build only.
- WebCoreSupport/WebInspectorClientCF.cpp:
- 4:39 PM Changeset in webkit [74948] by
-
- 2 edits in trunk/WebKit/cf
Windows build fix. Define WTF_USE_CFNETWORK in WebInspectorClientCF.
- WebCoreSupport/WebInspectorClientCF.cpp:
- 4:21 PM Changeset in webkit [74947] by
-
- 13 edits in trunk/WebCore
2011-01-03 Helder Correia <helder@sencha.com>
Reviewed by Simon Fraser.
ContextShadow can avoid code duplication for getting the CTM
https://bugs.webkit.org/show_bug.cgi?id=51799
ContextShadow defines its own getTransformationMatrixFromContext()
which does exactly the same as GraphicsContext::getCTM().
Existing tests: fast/canvas/canvas*shadow*html
- platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::mustUseContextShadow): (WebCore::ContextShadow::adjustBlurDistance): (WebCore::ContextShadow::calculateLayerBoundingRect):
- platform/graphics/ContextShadow.h:
- platform/graphics/cairo/ContextShadowCairo.cpp: (WebCore::ContextShadow::beginShadowLayer): (WebCore::ContextShadow::endShadowLayer): (WebCore::ContextShadow::drawRectShadowWithoutTiling):
- platform/graphics/cairo/FontCairo.cpp: (WebCore::drawGlyphsShadow):
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow):
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw):
- platform/graphics/gtk/FontGtk.cpp: (WebCore::drawGlyphsShadow):
- platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ContextShadow::beginShadowLayer): (WebCore::ContextShadow::endShadowLayer):
- platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect):
- platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
- platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw):
- 4:09 PM Changeset in webkit [74946] by
-
- 3 edits in trunk/WebCore
2011-01-03 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
InsertTextCommand::m_charactersAdded is unused
https://bugs.webkit.org/show_bug.cgi?id=51849
- editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::InsertTextCommand): Don't initialize m_charactersAdded. (WebCore::InsertTextCommand::input): Don't update m_charactersAdded.
- editing/InsertTextCommand.h: Removed charactersAdded function and m_charactersAdded data member.
- 3:56 PM Changeset in webkit [74945] by
-
- 4 edits in trunk/WebCore
2011-01-03 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Move paintMenuListButton() to RenderThemeGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=51832
Method paintMenuListButton() contains code common to both gtk 2
and 3, so it can be moved to RenderThemeGtk.cpp instead of
duplicating it.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintMenuListButton):
- platform/gtk/RenderThemeGtk2.cpp:
- platform/gtk/RenderThemeGtk3.cpp:
- 3:52 PM WebKit Team edited by
- Adding myself to the committers list. (diff)
- 3:52 PM Changeset in webkit [74944] by
-
- 2 edits in trunk
2011-01-03 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
- autogen.sh: also pass $ACLOCAL_FLAGS for tools that set that env variable (like jhbuild).
- 3:45 PM Changeset in webkit [74943] by
-
- 31 edits in trunk/WebCore
2011-01-03 Pratik Solanki <psolanki@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=51850
Put CFNetwork loader code inside USE(CFNETWORK)
Add USE(CFNETWORK) macros around all the cf/mac network files. Also added all CFNetwork
files to the WebCore Xcode project.
- WebCore.xcodeproj/project.pbxproj:
- loader/cf/ResourceLoaderCFNet.cpp:
- loader/mac/ResourceLoaderMac.mm:
- platform/network/cf/AuthenticationCF.cpp:
- platform/network/cf/AuthenticationCF.h:
- platform/network/cf/CookieJarCFNet.cpp:
- platform/network/cf/CookieStorageCFNet.cpp:
- platform/network/cf/CookieStorageCFNet.h:
- platform/network/cf/CredentialStorageCFNet.cpp:
- platform/network/cf/FormDataStreamCFNet.cpp:
- platform/network/cf/FormDataStreamCFNet.h:
- platform/network/cf/LoaderRunLoopCF.cpp:
- platform/network/cf/LoaderRunLoopCF.h:
- platform/network/cf/ResourceError.h:
- platform/network/cf/ResourceHandleCFNet.cpp:
- platform/network/cf/ResourceRequest.h:
- platform/network/cf/ResourceRequestCFNet.cpp:
- platform/network/cf/ResourceRequestCFNet.h:
- platform/network/cf/ResourceResponse.h:
- platform/network/cf/ResourceResponseCFNet.cpp:
- platform/network/mac/AuthenticationMac.h:
- platform/network/mac/AuthenticationMac.mm:
- platform/network/mac/FormDataStreamMac.h:
- platform/network/mac/FormDataStreamMac.mm:
- platform/network/mac/ResourceError.h:
- platform/network/mac/ResourceHandleMac.mm:
- platform/network/mac/ResourceRequest.h:
- platform/network/mac/ResourceRequestMac.mm:
- platform/network/mac/ResourceResponse.h:
- platform/network/mac/ResourceResponseMac.mm:
- 3:43 PM Changeset in webkit [74942] by
-
- 2 edits in trunk
2011-01-03 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Use autoreconf instead of calling manually all the usual commands.
- autogen.sh: call autoreconf instead of aclocal/autoheader/autoconf/automake/libtoolize.
- 3:42 PM Changeset in webkit [74941] by
-
- 15 edits in trunk
2011-01-03 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Adam Barth.
[Qt] Add SelectAll option to the context menu for the editor
https://bugs.webkit.org/show_bug.cgi?id=50049
Set shortcut for the SelectAll action.
- QtTestBrowser/mainwindow.cpp: (MainWindow::buildUI):
2011-01-03 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Adam Barth.
[Qt] Add SelectAll option to the context menu for the editor
https://bugs.webkit.org/show_bug.cgi?id=50049
Enable SelectAll for the Qt context menu.
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::populate):
- platform/ContextMenuItem.h:
- platform/LocalizationStrategy.h:
- platform/LocalizedStrings.cpp: (WebCore::contextMenuItemTagSelectAll):
- platform/LocalizedStrings.h:
2011-01-03 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Adam Barth.
[Qt] Add SelectAll option to the context menu for the editor
https://bugs.webkit.org/show_bug.cgi?id=50049
Enable SelectAll for the Qt context menu.
- Api/qwebpage.cpp: (webActionForContextMenuAction): (QWebPage::action):
- WebCoreSupport/WebPlatformStrategies.cpp: (WebPlatformStrategies::contextMenuItemTagSelectAll):
- WebCoreSupport/WebPlatformStrategies.h:
2011-01-03 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Adam Barth.
[Qt] Add SelectAll option to the context menu for the editor
https://bugs.webkit.org/show_bug.cgi?id=50049
Add WebPlatformStrategies::contextMenuItemTagSelectAll for Qt.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::contextMenuItemTagSelectAll):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- 2:25 PM Changeset in webkit [74940] by
-
- 4 edits in trunk/WebKitLibraries
Reviewed, tweaked and landed by Sam Weinig.
Patch by Chris Fleizach <Chris Fleizach> on 2011-01-03
WebKit2: Accessibility support (42130)
<rdar://problem/7660629>
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 1:53 PM Changeset in webkit [74939] by
-
- 2 edits in trunk/LayoutTests
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Group tests that fail on Leopard but pass on Snow Leopard (due to
stale platform/mac baselines).
- platform/chromium/test_expectations.txt:
- 1:42 PM Changeset in webkit [74938] by
-
- 2 edits in trunk
2011-01-03 Patrick Gansterer <Patrick Gansterer>
Reviewed by Darin Adler.
[WINCE] Provide third party directory via environment variable
https://bugs.webkit.org/show_bug.cgi?id=51643
- Source/cmake/OptionsWinCE.cmake:
- 1:40 PM Changeset in webkit [74937] by
-
- 3 edits in trunk/WebCore
Shrink RootInlineBox
https://bugs.webkit.org/show_bug.cgi?id=51847
Reviewed by Darin Adler.
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection): Changed to use the baselineType()
accessor.
- rendering/RootInlineBox.h: Rolled m_baselineType into a bitfield. Changed its type to
unsigned because otherwise MSVC treats it as signed.
(WebCore::RootInlineBox::baselineType): Added a cast.
- 1:38 PM Changeset in webkit [74936] by
-
- 2 edits in trunk/Source/JavaScriptCore
- wtf/Forward.h: Added Decoder and Encoder.
Reviewed by Brady Eidson.
- 1:36 PM Changeset in webkit [74935] by
-
- 4 adds in trunk/WebKit/gtk/webkit
Adding files I missed in my last git add. *shame*
- 1:21 PM Changeset in webkit [74934] by
-
- 3 edits in trunk/Tools
2011-01-03 David Levin <levin@chromium.org>
Reviewed by Eric Seidel.
check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
https://bugs.webkit.org/show_bug.cgi?id=51842
- Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
- Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
- 1:20 PM Changeset in webkit [74933] by
-
- 39 edits1 copy2 adds2 deletes in trunk
WebKit/gtk
2011-01-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Split webkitprivate.{cpp,h} in more manageable chunks
https://bugs.webkit.org/show_bug.cgi?id=50698
Final patch, removing webkitprivate.{cpp,h}, and adding a
webkitglobals module to hold non-object-specific functions and
definitions that do not make sense on their own.
- GNUmakefile.am:
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::createWindow):
- WebCoreSupport/ContextMenuClientGtk.cpp:
- WebCoreSupport/DocumentLoaderGtk.cpp: (WebKit::DocumentLoader::attachToFrame):
- WebCoreSupport/DragClientGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::ignoreWordInSpellDocument): (WebKit::EditorClient::learnWord): (WebKit::EditorClient::checkSpellingOfString): (WebKit::EditorClient::getGuessesForWord):
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createDocumentLoader):
- WebCoreSupport/InspectorClientGtk.cpp:
- webkit/webkit.h:
- webkit/webkitapplicationcache.cpp: (webkit_application_cache_set_maximum_size):
- webkit/webkitdownload.cpp: (webkit_download_class_init):
- webkit/webkitgeolocationpolicydecision.cpp:
- webkit/webkitglobals.cpp: Added. (webkit_get_default_session): (webkit_set_cache_model): (webkit_get_cache_model): (webkit_get_web_plugin_database): (currentToplevelCallback): (closeIconDatabaseOnExit): (webkitInit): (WebKit::pasteboardHelperInstance):
- webkit/webkitglobals.h: Added.
- webkit/webkitglobalsprivate.h: Copied from WebKit/gtk/webkit/webkitwebsettingsprivate.h.
- webkit/webkithittestresult.cpp: (webkit_hit_test_result_class_init):
- webkit/webkitnetworkrequest.cpp: (webkit_network_request_class_init):
- webkit/webkitnetworkresponse.cpp: (webkit_network_response_class_init):
- webkit/webkitprivate.cpp: Removed.
- webkit/webkitprivate.h: Removed.
- webkit/webkitsecurityorigin.cpp:
- webkit/webkitviewportattributes.cpp:
- webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_class_init):
- webkit/webkitwebdatabase.cpp:
- webkit/webkitwebdatasource.cpp: (webkit_web_data_source_class_init): (webkit_web_data_source_new_with_request): (WebKit::kitNew):
- webkit/webkitwebframe.cpp: (webkit_web_frame_class_init):
- webkit/webkitwebframeprivate.h:
- webkit/webkitwebhistoryitem.cpp: (webkit_web_history_item_class_init):
- webkit/webkitwebinspector.cpp:
- webkit/webkitwebnavigationaction.cpp:
- webkit/webkitwebplugin.cpp: (webkit_web_plugin_class_init):
- webkit/webkitwebplugindatabase.cpp: (webkit_web_plugin_database_class_init):
- webkit/webkitwebpluginprivate.h:
- webkit/webkitwebpolicydecision.cpp:
- webkit/webkitwebresource.cpp:
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkitWebViewGetEnchantDicts): (WebKit::core):
- webkit/webkitwebsettingsprivate.h:
- webkit/webkitwebview.cpp: (webkit_web_view_class_init): (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
- webkit/webkitwebview.h:
- webkit/webkitwebwindowfeatures.cpp: (webkit_web_window_features_class_init): (WebKit::kitNew):
WebCore
2011-01-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Split webkitprivate.{cpp,h} in more manageable chunks
https://bugs.webkit.org/show_bug.cgi?id=50698
Fix DOM bindings generation to no longer include the now-gone
webkitprivate.h header, including the appropriate replacements
instead.
- bindings/scripts/CodeGeneratorGObject.pm:
- 1:16 PM Changeset in webkit [74932] by
-
- 2 edits in trunk/WebKit/qt
2011-01-03 Antonio Gomes <agomes@rim.com>
Unreviewed crash fix.
Follow up of r74891: potential crash fix (bogus assertion).
- WebCoreSupport/EditorClientQt.cpp: (WebCore::editorCommandForKeyDownEvent):
- 1:13 PM Changeset in webkit [74931] by
-
- 2 edits in trunk/LayoutTests
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Missed a few failing tests.
- platform/chromium/test_expectations.txt:
- 1:10 PM Changeset in webkit [74930] by
-
- 3 edits in trunk/Tools
2011-01-03 Patrick Gansterer <Patrick Gansterer>
Reviewed by David Kilzer.
[WINCE] Adds a build slave.
https://bugs.webkit.org/show_bug.cgi?id=50523
- BuildSlaveSupport/build.webkit.org-config/config.json: Add an entry for a release build of the WinCE port.
- BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform flag to build the WinCE port.
- 1:04 PM Changeset in webkit [74929] by
-
- 2 edits182 deletes in trunk/LayoutTests
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Remove fast/, printing/, svg/, tables/ and transforms/ chromium-mac
baselines that are no longer necessary after r74892 (now that
chromium-mac scrollbars match mac ones).
- platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum: Removed.
- platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.png: Removed.
- platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.checksum: Removed.
- platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.png: Removed.
- platform/chromium-mac/fast/events/autoscroll-expected.checksum: Removed.
- platform/chromium-mac/fast/events/autoscroll-expected.png: Removed.
- platform/chromium-mac/fast/events/reveal-link-when-focused-expected.checksum: Removed.
- platform/chromium-mac/fast/events/reveal-link-when-focused-expected.png: Removed.
- platform/chromium-mac/fast/events/standalone-image-drag-to-editable-expected.checksum: Removed.
- platform/chromium-mac/fast/events/standalone-image-drag-to-editable-expected.png: Removed.
- platform/chromium-mac/fast/forms/basic-textareas-expected.checksum: Removed.
- platform/chromium-mac/fast/forms/basic-textareas-expected.png: Removed.
- platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.checksum: Removed.
- platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.png: Removed.
- platform/chromium-mac/fast/forms/button-default-title-expected.checksum: Removed.
- platform/chromium-mac/fast/forms/button-default-title-expected.png: Removed.
- platform/chromium-mac/fast/frames/frame-scrolling-attribute-expected.checksum: Removed.
- platform/chromium-mac/fast/frames/frame-scrolling-attribute-expected.png: Removed.
- platform/chromium-mac/fast/frames/iframe-scrolling-attribute-expected.checksum: Removed.
- platform/chromium-mac/fast/frames/iframe-scrolling-attribute-expected.png: Removed.
- platform/chromium-mac/fast/invalid/residual-style-expected.checksum: Removed.
- platform/chromium-mac/fast/invalid/residual-style-expected.png: Removed.
- platform/chromium-mac/fast/lists/001-vertical-expected.checksum: Removed.
- platform/chromium-mac/fast/lists/001-vertical-expected.png: Removed.
- platform/chromium-mac/fast/lists/008-vertical-expected.checksum: Removed.
- platform/chromium-mac/fast/lists/008-vertical-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-02-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-02-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-03-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-03-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-04-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-04-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-05-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-05-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-06-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-06-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-07-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-07-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-09-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-relative-constraints-09-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-width-absolute-01-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-width-absolute-01-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-width-absolute-02-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-width-absolute-02-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-width-absolute-03-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-width-absolute-03-expected.png: Removed.
- platform/chromium-mac/fast/media/mq-width-absolute-04-expected.checksum: Removed.
- platform/chromium-mac/fast/media/mq-width-absolute-04-expected.png: Removed.
- platform/chromium-mac/fast/multicol/client-rects-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.png: Removed.
- platform/chromium-mac/fast/multicol/float-multicol-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/float-multicol-expected.png: Removed.
- platform/chromium-mac/fast/multicol/float-paginate-complex-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/float-paginate-complex-expected.png: Removed.
- platform/chromium-mac/fast/multicol/float-paginate-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/float-paginate-expected.png: Removed.
- platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Removed.
- platform/chromium-mac/fast/multicol/layers-split-across-columns-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/paginate-block-replaced-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/span/anonymous-style-inheritance-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/span/anonymous-style-inheritance-expected.png: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png: Removed.
- platform/chromium-mac/fast/multicol/span/span-margin-collapsing-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/span/span-margin-collapsing-expected.png: Removed.
- platform/chromium-mac/fast/multicol/table-vertical-align-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/table-vertical-align-expected.png: Removed.
- platform/chromium-mac/fast/repaint/overflow-scroll-body-appear-expected.checksum: Removed.
- platform/chromium-mac/fast/repaint/overflow-scroll-body-appear-expected.png: Removed.
- platform/chromium-mac/fast/table/027-vertical-expected.checksum: Removed.
- platform/chromium-mac/fast/table/027-vertical-expected.png: Removed.
- platform/chromium-mac/fast/table/028-vertical-expected.checksum: Removed.
- platform/chromium-mac/fast/table/028-vertical-expected.png: Removed.
- platform/chromium-mac/fast/table/038-vertical-expected.checksum: Removed.
- platform/chromium-mac/fast/table/038-vertical-expected.png: Removed.
- platform/chromium-mac/fast/table/040-vertical-expected.checksum: Removed.
- platform/chromium-mac/fast/table/040-vertical-expected.png: Removed.
- platform/chromium-mac/fast/table/border-collapsing/002-vertical-expected.checksum: Removed.
- platform/chromium-mac/fast/table/border-collapsing/002-vertical-expected.png: Removed.
- platform/chromium-mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.checksum: Removed.
- platform/chromium-mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png: Removed.
- platform/chromium-mac/fast/table/table-display-types-vertical-expected.checksum: Removed.
- platform/chromium-mac/fast/table/table-display-types-vertical-expected.png: Removed.
- platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.checksum: Removed.
- platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.png: Removed.
- platform/chromium-mac/fast/text/text-letter-spacing-expected.checksum: Removed.
- platform/chromium-mac/fast/text/text-letter-spacing-expected.png: Removed.
- platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.checksum: Removed.
- platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: Removed.
- platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.checksum: Removed.
- platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.png: Removed.
- platform/chromium-mac/printing/return-from-printing-mode-expected.checksum: Removed.
- platform/chromium-mac/printing/return-from-printing-mode-expected.png: Removed.
- platform/chromium-mac/svg/custom/altglyph-expected.checksum: Removed.
- platform/chromium-mac/svg/custom/altglyph-expected.png: Removed.
- platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.checksum: Removed.
- platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Removed.
- platform/chromium-mac/svg/custom/junk-data-expected.checksum: Removed.
- platform/chromium-mac/svg/custom/junk-data-expected.png: Removed.
- platform/chromium-mac/svg/custom/missing-xlink-expected.checksum: Removed.
- platform/chromium-mac/svg/custom/missing-xlink-expected.png: Removed.
- platform/chromium-mac/svg/custom/text-xy-updates-SVGList-expected.checksum: Removed.
- platform/chromium-mac/svg/custom/text-xy-updates-SVGList-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-appendItem-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-appendItem-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-initialize-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-initialize-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-insertItemBefore-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-insertItemBefore-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-removeItem-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-removeItem-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-replaceItem-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-replaceItem-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGPathSegList-appendItem-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGPathSegList-appendItem-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGPathSegList-removeItem-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGPathSegList-removeItem-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGPathSegList-replaceItem-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGPointList-basics-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGPointList-basics-expected.png: Removed.
- platform/chromium-mac/svg/dom/SVGStringList-basics-expected.checksum: Removed.
- platform/chromium-mac/svg/dom/SVGStringList-basics-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.checksum: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Removed.
- platform/chromium-mac/svg/in-html/circle-expected.checksum: Removed.
- platform/chromium-mac/svg/in-html/circle-expected.png: Removed.
- platform/chromium-mac/svg/text/kerning-expected.checksum: Removed.
- platform/chromium-mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.checksum: Removed.
- platform/chromium-mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Removed.
- platform/chromium-mac/svg/zoom/page/relative-sized-document-scrollbars-expected.checksum: Removed.
- platform/chromium-mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Removed.
- platform/chromium-mac/svg/zoom/page/zoom-svg-float-border-padding-expected.checksum: Removed.
- platform/chromium-mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Removed.
- platform/chromium-mac/svg/zoom/text/zoom-svg-float-border-padding-expected.checksum: Removed.
- platform/chromium-mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.checksum: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug96343-expected.checksum: Removed.
- platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.checksum: Removed.
- platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.checksum: Removed.
- platform/chromium-mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.png: Removed.
- platform/chromium-mac/transforms/2d/transform-fixed-container-expected.checksum: Removed.
- platform/chromium-mac/transforms/2d/transform-fixed-container-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- 1:04 PM Changeset in webkit [74928] by
-
- 3 edits in trunk/Tools
2011-01-03 Patrick Gansterer <Patrick Gansterer>
Reviewed by David Kilzer.
Add WinCE support to build-webkit
https://bugs.webkit.org/show_bug.cgi?id=51642
- Scripts/build-webkit:
- Scripts/webkitdirs.pm:
- 12:59 PM Changeset in webkit [74927] by
-
- 10 edits in trunk/Tools
2011-01-03 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
https://bugs.webkit.org/show_bug.cgi?id=51802
I'm not the biggest fan of the test_failures or test_results classes,
but it's better to have one shared set of classes, than separate ones
for new vs. old run-webkit-test result handling.
This moves the ORWT results class "LayoutTestResults" over to using
TestResult and TestFailure classes, making it easy for us to
make all our sheriff-bot and other webkitpy code NRWT ready.
This also makes it a trivial patch to generate results.json information
from ORWT results.html files (for flaky test analysis, etc.) as well
as making it a one-liner to report test failure types when the
commit-queue sees flaky tests.
This patch tried not to add new functionality, but only to replace
the guts of LayoutTestResults, while adding unit tests and hoping
not to break anything.
I also moved callers which assumed User.prompt* were static/class methods
to using them as instance methods (since we'll eventually want to make them such).
In the process of re-writing things, I broke the rebaseline command, so I wrote
a unit test to catch my breakage were I do do so again in the future.
- Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
- Scripts/webkitpy/common/net/layouttestresults.py:
- Scripts/webkitpy/common/net/layouttestresults_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
- Scripts/webkitpy/layout_tests/layout_package/test_results.py:
- Scripts/webkitpy/tool/commands/queries.py:
- Scripts/webkitpy/tool/commands/rebaseline.py:
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- 12:57 PM Changeset in webkit [74926] by
-
- 6 edits4 adds in trunk
Add Encode/Decode machinery Darin and I plan to work with for back/forward stuff in WebKit2.
Reviewed by Darin Adler.
Source/JavaScriptCore:
Starting out with a pure virtual interface to be implemented in WK2, but we might change that later.
- GNUmakefile.am:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/Decoder.h: Added.
- wtf/Encoder.h: Added.
WebCore:
- ForwardingHeaders/wtf/Decoder.h: Added.
- ForwardingHeaders/wtf/Encoder.h: Added.
- 12:40 PM Changeset in webkit [74925] by
-
- 2 edits in trunk/Tools
2011-01-03 Adam Barth <abarth@webkit.org>
Reviewed by Simon Fraser.
webkit-patch shouldn't waste time cleaning a working directory that's already clean
https://bugs.webkit.org/show_bug.cgi?id=51840
- Scripts/webkitpy/common/checkout/scm.py:
- 12:36 PM Changeset in webkit [74924] by
-
- 2 edits in trunk/LayoutTests
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
New gradient tests fail on chromium-mac too.
- platform/chromium/test_expectations.txt:
- 12:26 PM Changeset in webkit [74923] by
-
- 2 edits48 deletes in trunk/LayoutTests
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Remove editing/, fast/backgrounds, fast/block, fast/blockflow, and
fast/borders chromium-mac baselines that are no longer necessary after
r74892 (now that chromium-mac scrollbars match mac ones).
- platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.checksum: Removed.
- platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.png: Removed.
- platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.checksum: Removed.
- platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.png: Removed.
- platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.checksum: Removed.
- platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.png: Removed.
- platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.checksum: Removed.
- platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.png: Removed.
- platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.checksum: Removed.
- platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.png: Removed.
- platform/chromium-mac/editing/inserting/insert-div-023-expected.checksum: Removed.
- platform/chromium-mac/editing/inserting/insert-div-023-expected.png: Removed.
- platform/chromium-mac/editing/selection/focus_editable_html-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/focus_editable_html-expected.png: Removed.
- platform/chromium-mac/editing/selection/iframe-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/iframe-expected.png: Removed.
- platform/chromium-mac/editing/selection/select-all-001-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/select-all-001-expected.png: Removed.
- platform/chromium-mac/editing/selection/select-all-002-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/select-all-002-expected.png: Removed.
- platform/chromium-mac/editing/selection/select-all-003-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/select-all-003-expected.png: Removed.
- platform/chromium-mac/editing/selection/select-all-004-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/select-all-004-expected.png: Removed.
- platform/chromium-mac/editing/selection/unrendered-001-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/unrendered-001-expected.png: Removed.
- platform/chromium-mac/editing/selection/unrendered-002-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/unrendered-002-expected.png: Removed.
- platform/chromium-mac/editing/selection/unrendered-003-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/unrendered-003-expected.png: Removed.
- platform/chromium-mac/editing/selection/unrendered-004-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/unrendered-004-expected.png: Removed.
- platform/chromium-mac/editing/selection/unrendered-005-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/unrendered-005-expected.png: Removed.
- platform/chromium-mac/fast/backgrounds/background-inherit-color-bug-expected.checksum: Removed.
- platform/chromium-mac/fast/backgrounds/background-inherit-color-bug-expected.png: Removed.
- platform/chromium-mac/fast/block/basic/016-expected.checksum: Removed.
- platform/chromium-mac/fast/block/basic/truncation-rtl-expected.checksum: Removed.
- platform/chromium-mac/fast/block/basic/truncation-rtl-expected.png: Removed.
- platform/chromium-mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Removed.
- platform/chromium-mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.png: Removed.
- platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
- platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Removed.
- platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
- platform/chromium-mac/fast/blockflow/fieldsets-expected.checksum: Removed.
- platform/chromium-mac/fast/blockflow/fieldsets-expected.png: Removed.
- platform/chromium-mac/fast/borders/border-image-scale-transform-expected.checksum: Removed.
- platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- 12:08 PM Changeset in webkit [74922] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-03 Laszlo Gombos <Laszlo Gombos>
Unreviewed build fix.
[Qt] Add NullPtr.cpp introduced in r71155 to the Qt build system.
This fix is required for builds where HAVE(NULLPTR) is false
(e.g. some MSVC and Symbian builds).
- wtf/wtf.pri:
- 12:02 PM Changeset in webkit [74921] by
-
- 2 edits in trunk/LayoutTests
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test expectation update.
Add failing expectations for tests that depend on elliptical gradient
support.
- platform/chromium/test_expectations.txt:
- 12:01 PM Changeset in webkit [74920] by
-
- 3 edits2 adds in trunk
AX: Regression: WebKit no longer auto-scrolls with VoiceOver navigation
https://bugs.webkit.org/show_bug.cgi?id=51833
Reviewed by Darin Adler.
WebCore:
Make sure the web area returns the contentsSize, not the same size as what is displayed.
Test: platform/mac/accessibility/webarea-size-equals-content-size.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::boundingBoxRect):
LayoutTests:
- platform/mac/accessibility/webarea-size-equals-content-size-expected.txt: Added.
- platform/mac/accessibility/webarea-size-equals-content-size.html: Added.
- 11:57 AM Changeset in webkit [74919] by
-
- 2 edits in trunk/WebCore
2011-01-03 Simon Fraser <Simon Fraser>
Fix warning in 32-bit builds.
- css/CSSGradientValue.cpp: (WebCore::CSSLinearGradientValue::createGradient):
- 11:50 AM Changeset in webkit [74918] by
-
- 2 edits26 deletes in trunk/LayoutTests
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Remove css2.1/ chromium-mac baselines that are no longer necessary after
r74892 (now that chromium-mac scrollbars match mac ones).
- platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.png: Removed.
- platform/chromium-mac/css2.1/t0803-c5505-mrgn-02-c-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t0803-c5505-mrgn-02-c-expected.png: Removed.
- platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.png: Removed.
- platform/chromium-mac/css2.1/t0905-c5525-fltclr-00-c-ag-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png: Removed.
- platform/chromium-mac/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png: Removed.
- platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Removed.
- platform/chromium-mac/css2.1/t0905-c5526-fltclr-00-c-ag-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png: Removed.
- platform/chromium-mac/css2.1/t1002-c5523-width-02-b-g-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t1002-c5523-width-02-b-g-expected.png: Removed.
- platform/chromium-mac/css2.1/t1202-counters-08-b-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t1202-counters-08-b-expected.png: Removed.
- platform/chromium-mac/css2.1/t1202-counters-09-b-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t1202-counters-09-b-expected.png: Removed.
- platform/chromium-mac/css2.1/t140201-c535-bg-fixd-00-b-g-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png: Removed.
- platform/chromium-mac/css2.1/t140201-c537-bgfxps-00-c-ag-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png: Removed.
- platform/chromium-mac/css2.1/t1508-c527-font-07-b-expected.checksum: Removed.
- platform/chromium-mac/css2.1/t1508-c527-font-07-b-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- 11:43 AM Changeset in webkit [74917] by
-
- 2 edits in trunk/LayoutTests
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test expectation update.
Remove failing expectations for tests that now pass (due to r74892).
- platform/chromium/test_expectations.txt:
- 11:37 AM Changeset in webkit [74916] by
-
- 2 edits in trunk/WebCore
2011-01-03 Benjamin C Meyer <bmeyer@rim.com>
Reviewed by Daniel Bates.
In the cmake build system move logic related to ENABLE_NOTIFICATIONS into its own block.
https://bugs.webkit.org/show_bug.cgi?id=51827
- CMakeLists.txt:
- 11:36 AM Changeset in webkit [74915] by
-
- 13 edits8 adds in trunk
2011-01-03 Simon Fraser <Simon Fraser>
Reviewed by David Hyatt.
Implement -webkit-linear-gradient and -webkit-radial-gradient
https://bugs.webkit.org/show_bug.cgi?id=28152
Add support for -webkit-radial-gradients.
Tests: fast/gradients/css3-radial-gradients.html
fast/gradients/css3-radial-gradients2.html
- css/CSSGradientValue.cpp: (WebCore::blend): Used to blend colors, which is necessary when truncating the start of radial gradients. (WebCore::GradientStop): Small struct to aid gradient stop processing. (WebCore::CSSGradientValue::addStops): Rename 'positions' to 'stops', and store the color so that we can blend it when truncating radial gradients. Changed to handle both linear and radial gradients. (WebCore::CSSRadialGradientValue::cssText): Update to follow the spec. (WebCore::CSSRadialGradientValue::resolveRadius): Stylistic change. (WebCore::distanceToClosestCorner): New utility method. (WebCore::distanceToFarthestCorner): Ditto. (WebCore::CSSRadialGradientValue::createGradient): New logic to deal with shape and fill rules.
- css/CSSGradientValue.h: (WebCore::CSSGradientValue::isLinearGradient): Color-stop processing needs to know what kind of gradient it's dealing with, so add new isFooGradient methods. (WebCore::CSSGradientValue::isRadialGradient): Ditto. (WebCore::CSSLinearGradientValue::isLinearGradient): (WebCore::CSSRadialGradientValue::setShape): New setters for shape, size etc. (WebCore::CSSRadialGradientValue::setSizingBehavior): (WebCore::CSSRadialGradientValue::setEndHorizontalSize): (WebCore::CSSRadialGradientValue::setEndVerticalSize): (WebCore::CSSRadialGradientValue::isRadialGradient):
- css/CSSParser.h:
- css/CSSParser.h: Pass a CSSParserValueList* into parseFillPositionXY() and parseFillPosition() so we can use parseFillPosition() when parsing a gradient function.
- css/CSSParser.cpp: (WebCore::CSSParser::parseFillPositionXY): Pass in a CSSParserValueList* (WebCore::CSSParser::parseFillPosition): Ditto (WebCore::CSSParser::parseFillProperty): Pass m_valueList to parseFillPosition. (WebCore::CSSParser::parseTransformOriginShorthand): Ditto (WebCore::CSSParser::parseRadialGradient): Flesh out radial gradient parsing. (WebCore::CSSParser::parseTransformOrigin): Pass m_valueList to parseFillPosition. (WebCore::CSSParser::parsePerspectiveOrigin): Ditto
- css/CSSValueKeywords.in: New keywords for radial gradient shape and fill behaviors.
- platform/graphics/Gradient.cpp: (WebCore::Gradient::Gradient): Pass aspect ratio for elliptical gradients.
- platform/graphics/Gradient.h: Add aspect ratio for elliptical gradients. (WebCore::Gradient::create): (WebCore::Gradient::startRadius): Expose radii. (WebCore::Gradient::endRadius): (WebCore::Gradient::setStartRadius): Setters are required for when we need to scale color stops. (WebCore::Gradient::setEndRadius): (WebCore::Gradient::aspectRatio):
- platform/graphics/cg/GradientCG.cpp: (WebCore::Gradient::paint): For elliptical gradients, scale the CTM.
- platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::fillRect): Use start/endRadius() rather than r0() and r1().
- 11:33 AM Changeset in webkit [74914] by
-
- 2 edits in trunk/Tools
2011-01-03 Adam Barth <abarth@webkit.org>
Reviewed by Simon Fraser.
webkit-patch should only hide update output if --quiet
https://bugs.webkit.org/show_bug.cgi?id=51838
As requested by smfr.
- Scripts/webkitpy/tool/steps/update.py:
- 11:33 AM Changeset in webkit [74913] by
-
- 3 edits in trunk/WebCore
2011-01-03 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
Remove the unused RenderTableCell::m_percentageHeight
https://bugs.webkit.org/show_bug.cgi?id=51837
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::RenderTableCell): Removed initialization of m_percentageHeight.
- rendering/RenderTableCell.h: Removed m_percentageHeight.
- 11:31 AM Changeset in webkit [74912] by
-
- 7 edits14 adds in trunk
2011-01-03 Simon Fraser <Simon Fraser>
Reviewed by David Hyatt.
Implement -webkit-linear-gradient and -webkit-radial-gradient
https://bugs.webkit.org/show_bug.cgi?id=28152
Add support for the parsing and rendering of non-repeating CSS3 linear gradients,
according to <http://dev.w3.org/csswg/css3-images/#linear-gradients>.
Tests: fast/gradients/css3-color-stop-units.html
fast/gradients/css3-color-stops.html
fast/gradients/css3-gradient-parsing.html
fast/gradients/css3-linear-angle-gradients.html
- css/CSSGradientValue.h: Add subclasses of CSSGradientValue for linear and radial gradients.
- css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::image): Add FIXME comment about why we can't cache the gradient sometimes. (WebCore::compareStops): positions are CSSValues now. (WebCore::CSSGradientValue::sortStopsIfNeeded): Add assertion that this is only called for old-style gradients. (WebCore::CSSGradientValue::addStops): New method that handles the spec rules about missing positions, ensuring that stop position is ordered, and spacing out stops without positions. Also normalize gradients which use stops outside the 0-1 range so that platforms can render them correctly. (WebCore::positionFromValue): Determin the position on the gradient line for percentage, number and length values. (WebCore::CSSGradientValue::computeEndPoint): (WebCore::CSSLinearGradientValue::cssText): (WebCore::endPointsFromAngle): Compute endpoints for a gradient which covers the rectangle given an angle. (WebCore::CSSLinearGradientValue::createGradient): (WebCore::CSSRadialGradientValue::cssText): (WebCore::CSSRadialGradientValue::resolveRadius): (WebCore::CSSRadialGradientValue::createGradient):
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Style fix. (WebCore::CSSParser::parseContent): Use isGeneratedImageValue() and parseGeneratedImage() (WebCore::CSSParser::parseFillImage): Use isGeneratedImageValue() and parseGeneratedImage() (WebCore::CSSParser::parseBorderImage): Use isGeneratedImageValue() and parseGeneratedImage() (WebCore::parseDeprecatedGradientPoint): Renamed to indicate that it's only used for -webkit-gradient. (WebCore::parseDeprecatedGradientColorStop): Renamed to indicate that it's only used for -webkit-gradient, and fixed to store CSSValues for the stop position. (WebCore::CSSParser::parseDeprecatedGradient): Renamed to indicate that it's only used for -webkit-gradient, and create CSSLinearGradientValue and CSSRadialGradientValue as appropriate. (WebCore::valueFromSideKeyword): (WebCore::parseGradientColorOrKeyword): Color parsing utility. (WebCore::CSSParser::parseLinearGradient): New method to parse linear gradients. (WebCore::CSSParser::parseRadialGradient): Stub for new method to parse radial gradients. (WebCore::CSSParser::isGeneratedImageValue): Detect gradients and CSS canvas. (WebCore::CSSParser::parseGeneratedImage): Parser for generated images like gradients and CSS canvas.
- css/CSSParser.h:
- platform/graphics/Gradient.h: (WebCore::Gradient::setP0): We need to be able to change the points when normalizing gradients. (WebCore::Gradient::setP1): Ditto.
- 11:18 AM Changeset in webkit [74911] by
-
- 2 edits in trunk/LayoutTests
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Missed a few failing tests.
- platform/chromium/test_expectations.txt:
- 11:04 AM Changeset in webkit [74910] by
-
- 2 edits in trunk/Tools
2011-01-03 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
commit-queue shouldn't reject patches twice if two bots process the same patch
https://bugs.webkit.org/show_bug.cgi?id=51805
Before raising an error, we first check whether the patch is still in
the commit-queue. This check is still racy, of course, but the time
window is much smaller.
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
- 11:01 AM Changeset in webkit [74909] by
-
- 7 edits in trunk
2011-01-03 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Andreas Kling.
[Qt] document.getElementById(...) doesn't return the right object in combination with QGraphicsWidget
https://bugs.webkit.org/show_bug.cgi?id=51464
Added a way to bind any QObject created as a plugin to JavaScript,
by adding a custom member (qtObject) to WebCore::Widget.
Added a test to tst_qwebpage to make sure plugins created
as QGraphicsWidget are accessible through JavaScript.
- bindings/js/ScriptControllerQt.cpp: (WebCore::ScriptController::createScriptInstanceForWidget):
- platform/Widget.h:
- platform/qt/WidgetQt.cpp: (WebCore::Widget::Widget): (WebCore::Widget::setBindingObject): (WebCore::Widget::bindingObject):
2011-01-03 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Andreas Kling.
[Qt] document.getElementById(...) doesn't return the right object in combination with QGraphicsWidget
https://bugs.webkit.org/show_bug.cgi?id=51464
Added a way to bind any QObject created as a plugin to JavaScript,
by adding a custom membe to WebCore::Widget.
Added a test to make sure plugins created as QGraphicsWidget are
accessible through JavaScript.
- WebCoreSupport/FrameLoaderClientQt.cpp:
- tests/qwebpage/tst_qwebpage.cpp: (PluginPage::createPlugin): (tst_QWebPage::graphicsWidgetPlugin):
- 10:55 AM Changeset in webkit [74908] by
-
- 3 edits3 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=51328
Reviewed by Simon Fraser.
WebCore:
Printing on a page with body { height: 100% } clips out the overflow contents. This happened
because the computePageRects function was never correct. It was using the layer's width and height
for the document's width and height, and the layer no longer includes overflow in its width and
height. It was also incorrectly assuming the first page would begin at (0,0), and this is an invalid
assumption in RTL or vertical text environments.
Added printing/page-count-percentage-height.html
- page/PrintContext.cpp:
(WebCore::PrintContext::computePageRects):
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
LayoutTests:
Add layout test for printing clipping bug.
- printing/page-count-percentage-height-expected.txt: Added.
- printing/page-count-percentage-height.html: Added.
- printing/script-tests/page-count-percentage-height.js: Added.
(test):
- 10:41 AM Changeset in webkit [74907] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out unnecessary r74905.
[Qt] DRT sideeffect revealed by r74896
https://bugs.webkit.org/show_bug.cgi?id=51829
- platform/qt/Skipped:
- 10:40 AM Changeset in webkit [74906] by
-
- 2 edits in trunk/Tools
Make run-api-tests less chatty.
https://bugs.webkit.org/show_bug.cgi?id=51831
Reviewed by Anders Carlsson.
- Make script quiet by default and add --verbose option (replacing --quiet).
- When not verbose, pipe stdout and stderr to devnull.
- Scripts/run-api-tests:
- 10:33 AM Changeset in webkit [74905] by
-
- 2 edits in trunk/LayoutTests
Unreviewed fix.
[Qt] DRT sideeffect revealed by r74896
https://bugs.webkit.org/show_bug.cgi?id=51829
- platform/qt/Skipped: http/tests/misc/401-alternative-content.php added until fix.
- 10:29 AM Changeset in webkit [74904] by
-
- 2 edits in trunk/LayoutTests
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Fix duplicate expectation.
- platform/chromium/test_expectations.txt:
- 10:26 AM Changeset in webkit [74903] by
-
- 2 edits in trunk
2011-01-03 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Disable superfluous GNU make built-in implicit rules
https://bugs.webkit.org/show_bug.cgi?id=51826
GNU make ships some superflous built-in rules that we never use
and that end up adding up to a very significant portion of our
total Makefile processing time. Disable them completely by
defining the rule without any recipe, as suggested by the GNU make
manual (10.5.6, Cancelling Implicit Rules).
In my system the null-build goes from:
make 43.51s user 12.77s system 99% cpu 56.628 total
to:
make 31.45s user 11.59s system 99% cpu 43.227 total
- GNUmakefile.am: disable implicit built-in rules.
- 10:24 AM Changeset in webkit [74902] by
-
- 2 edits in trunk/Tools
2011-01-03 Pratik Solanki <psolanki@apple.com>
Unreviewed. Adding myself to committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 10:12 AM Changeset in webkit [74901] by
-
- 2 edits in trunk/LayoutTests
2011-01-03 Laszlo Gombos <Laszlo Gombos>
Unreviewed, build fix.
[Qt] Add back auth.html to the skipped list after r74896.
- platform/qt/Skipped: Add http/tests/appcache/auth.html to the list.
- 10:10 AM Changeset in webkit [74900] by
-
- 3 edits in trunk/WebCore
[Qt] Unreviewed buildfix for --minimal build after r74895.
- html/InputType.cpp: Missing include added.
- html/NumberInputType.cpp: Missing include added.
- 9:59 AM Changeset in webkit [74899] by
-
- 2 edits in trunk/WebKit/chromium
2011-01-03 Daniel Bates <dbates@rim.com>
Attempt to fix the Chromium Linux Release build after changeset 74895 <http://trac.webkit.org/changeset/74895>.
The portion of the patch in <https://bugs.webkit.org/show_bug.cgi?id=51791> that modified the
file src/WebSearchableFormData.cpp was not landed (why?). Although the change log entry
associated with this change was landed.
- src/WebSearchableFormData.cpp: (HTMLNames::IsInDefaultState):
- 9:53 AM Changeset in webkit [74898] by
-
- 2 edits in trunk
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed. Update .gitignore with new JavaScriptCore location.
- .gitignore:
- 9:48 AM Changeset in webkit [74897] by
-
- 2 edits124 deletes in trunk/LayoutTests
2011-01-03 Laszlo Gombos <Laszlo Gombos>
Reviewed by David Levin.
[Qt] Unskip some passing tests as the bot is migrated to Qt 4.7+
https://bugs.webkit.org/show_bug.cgi?id=51819
- platform/qt/Skipped: Remove passing HTTP tests. Keep timer-vs-loading.html as it is still failing.
- platform/qt/http/tests/loading/bad-scheme-subframe-expected.txt: Match the expected results with chromium to pass the test.
- 9:31 AM QtWebKitReleases edited by
- (diff)
- 9:28 AM QtWebKit edited by
- (diff)
- 9:26 AM Changeset in webkit [74896] by
-
- 3 edits in trunk/LayoutTests
2011-01-03 Laszlo Gombos <Laszlo Gombos>
Reviewed by David Levin.
[Qt] Unskip some passing tests as the bot is migrated to Qt 4.7+
https://bugs.webkit.org/show_bug.cgi?id=51819
- platform/qt/Skipped: Remove passing HTTP tests. Keep timer-vs-loading.html as it is still failing.
- platform/qt/http/tests/loading/bad-scheme-subframe-expected.txt: Match the expected results with chromium to pass the test.
- 9:21 AM Changeset in webkit [74895] by
-
- 55 edits in trunk/WebCore
2011-01-02 Darin Adler <Darin Adler>
Reviewed by Kent Tamura.
Eliminate HTMLInputElement::m_deprecatedTypeNumber, other input refactoring and renaming
https://bugs.webkit.org/show_bug.cgi?id=51791
- src/WebSearchableFormData.cpp: (HTMLNames::IsInDefaultState): Use hasAttribute(checkedAttr) to find out whether a button should be checked by default, rather than calling the defaultChecked function.
2011-01-02 Darin Adler <Darin Adler>
Reviewed by Kent Tamura.
Eliminate HTMLInputElement::m_deprecatedTypeNumber, other input refactoring and renaming
https://bugs.webkit.org/show_bug.cgi?id=51791
- dom/InputElement.h: Make sanitizeValueForTextField public so it can be called by InputType.
- html/BaseButtonInputType.cpp: (WebCore::BaseButtonInputType::accessKeyAction): Added. (WebCore::BaseButtonInputType::storesValueSeparateFromAttribute): Added.
- html/BaseButtonInputType.h: Ditto.
- html/BaseCheckableInputType.cpp: (WebCore::BaseCheckableInputType::canSetStringValue): Added. (WebCore::BaseCheckableInputType::accessKeyAction): Added. (WebCore::BaseCheckableInputType::fallbackValue): Added. (WebCore::BaseCheckableInputType::storesValueSeparateFromAttribute): Added. (WebCore::BaseCheckableInputType::isCheckable): Added.
- html/BaseCheckableInputType.h: Ditto.
- html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::hasSpinButton): Added.
- html/BaseDateAndTimeInputType.h: Ditto.
- html/BaseTextInputType.h: Made more functions private.
- html/ButtonInputType.cpp: (WebCore::ButtonInputType::isTextButton): Added.
- html/ButtonInputType.h: Ditto.
- html/CheckboxInputType.cpp: (WebCore::CheckboxInputType::willDispatchClick): Added. (WebCore::CheckboxInputType::didDispatchClick): Added. (WebCore::CheckboxInputType::isCheckbox): Added.
- html/CheckboxInputType.h: Ditto.
- html/DateTimeInputType.cpp: (WebCore::DateTimeInputType::scaledStepValueShouldBeInteger): Fixed typo in name of this function.
- html/DateTimeInputType.h: Ditto.
- html/DateTimeLocalInputType.cpp: (WebCore::DateTimeLocalInputType::scaledStepValueShouldBeInteger): Ditto.
- html/DateTimeLocalInputType.h: Ditto.
- html/EmailInputType.cpp: (WebCore::EmailInputType::isEmailField): Added.
- html/EmailInputType.h: Ditto.
- html/FileInputType.cpp: (WebCore::FileInputType::FileInputType): Added. (WebCore::FileInputType::canSetStringValue): Added. (WebCore::FileInputType::canChangeFromAnotherType): Added. (WebCore::FileInputType::files): Added. (WebCore::FileInputType::canSetValue): Added. (WebCore::FileInputType::getTypeSpecificValue): Added. (WebCore::FileInputType::storesValueSeparateFromAttribute): Added. (WebCore::FileInputType::setFileList): Added. (WebCore::FileInputType::isFileUpload): Added.
- html/FileInputType.h: Ditto.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::HTMLInputElement): Updated for data member renaming and removal. (WebCore::HTMLInputElement::isValidValue): Call canSetStringValue instead of checking specific type numbers. (WebCore::HTMLInputElement::getAllowedValueStepWithDecimalPlaces): Use fastGetAttribute and fixed typo in the name of the scaledStepValueShouldBeInteger function. (WebCore::HTMLInputElement::isKeyboardFocusable): Call InputType::isKeyboardFocusable; moved most of the type-specific logic there. (WebCore::HTMLInputElement::shouldUseInputMethod): Call InputType::shouldUseInputMethod; moved the type-specific logic there. (WebCore::HTMLInputElement::handleBlurEvent): Call InputType::handleBlurEvent; moved the type-specific logic there. (WebCore::HTMLInputElement::setType): Tweak the names and types in this function. (WebCore::HTMLInputElement::updateType): Removed the code that set m_deprecatedTypeNumber. Compare types by comparing the value from formControlType. Removed file-specific logic and instead call InputType::canChangeFromAnotherType. Streamlined the logic for activation callbacks. (WebCore::HTMLInputElement::accessKeyAction): Call InputType::accessKeyAction; moved the type-specific logic there. (WebCore::HTMLInputElement::mapToEntry): Call InputType::shouldRespectHeightAndWidthAttributes and InputType::shouldRespectAlignAttribute. (WebCore::HTMLInputElement::parseMappedAttribute): Updated for name changes and the removal of m_defaultChecked. Changed the alt attribute logic to be based on the class of the renderer. Call InputType::srcAttributeChanged and moved the type-specific logic there. Call shouldRespectAlignAttribute and shouldRespectHeightAndWidthAttributes rather than having type-specific logic here. Call minOrMaxAttributeChanged. (WebCore::HTMLInputElement::rendererIsNeeded): Call InputType::rendererIsNeeded; moved the type-specific logic there. (WebCore::HTMLInputElement::attach): Removed the unneeded m_inited flag, which was redundant with the m_haveType flag. Call InputType::attach; moved the type-specific logic there. (WebCore::HTMLInputElement::altText): Use fastGetAttribute. (WebCore::HTMLInputElement::isSuccessfulSubmitButton): Call InputType::canBeSuccessfulSubmitButton; moved the type-specific logic there. (WebCore::HTMLInputElement::isActivatedSubmit): Updated for name changes. (WebCore::HTMLInputElement::setActivatedSubmit): Ditto. (WebCore::HTMLInputElement::reset): Updated to use InputType::storesValueSeparateFromAttribute. Also use hasAttribute(checkedAttr) rather than m_defaultChecked, since both are the same. Also updated for name change. (WebCore::HTMLInputElement::setChecked): Updated for name changes. Also added call to InputType::shouldSendChangeEventAfterCheckedChanged and moved the type-specific logic there. (WebCore::HTMLInputElement::setIndeterminate): Call isCheckable to see if indeterminate is allowed. Also updated for name changes. (WebCore::HTMLInputElement::copyNonAttributeProperties): Updated for name changes and removed data members. (WebCore::HTMLInputElement::value): Call InputType::getTypeSpecificValue and InputType::fallbackValue. Moved the type-specific logic there. (WebCore::HTMLInputElement::valueWithDefault): Call InputType::defaultValue. Moved the type-specific logic there. (WebCore::HTMLInputElement::setSuggestedValue): Call InputType::canSetSuggestedValue. Moved the type-specific logic there. (WebCore::HTMLInputElement::setValue): Call InputType::canSetValue. Moved the type-specific logic there. Clear the file list if it exists rather than checking the type explicitly. We could probably do that a more elegant way. (WebCore::HTMLInputElement::placeholder): Use fastGetAttribute. (WebCore::HTMLInputElement::setValueFromRenderer): Use the isFileUpload function in the assertion. (WebCore::HTMLInputElement::setFileListFromRenderer): Put most of the code from this function into FileInputType::setFileList. (WebCore::HTMLInputElement::preDispatchEventHandler): Changed to call InputType::willDispatchClick, which does the type-specific work. Still need to use a single struct for all types, because the type of the element could change during the event handling. (WebCore::HTMLInputElement::postDispatchEventHandler): Changed to call InputType::didDispatchClick. (WebCore::HTMLInputElement::defaultValue): Use fastGetAttribute. (WebCore::HTMLInputElement::accept): Use fastGetAttribute. (WebCore::HTMLInputElement::alt): Use fastGetAttribute. (WebCore::HTMLInputElement::src): Use fastGetAttribute. (WebCore::HTMLInputElement::setAutofilled): Updated for name changes. (WebCore::HTMLInputElement::files): Use InputType::files. (WebCore::HTMLInputElement::isAcceptableValue): Use InputType::isAcceptableValue. (WebCore::HTMLInputElement::sanitizeValue): Use InputType::sanitizeValue. (WebCore::HTMLInputElement::hasUnacceptableValue): Use InputType::hasUnacceptableValue. (WebCore::HTMLInputElement::needsActivationCallback): Use InputType::shouldResetOnDocumentActivation. (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Use InputType::willMoveToNewOwnerDocument. (WebCore::HTMLInputElement::dataList): Use InputType::shouldRespectListAttribute. (WebCore::HTMLInputElement::selectedOption): Tweaked logic and naming a bit. (WebCore::HTMLInputElement::stepUpFromRenderer): Use fastGetAttribute. (WebCore::HTMLInputElement::isSpeechEnabled): Use InputType::shouldRespectSpeechAttribute. (WebCore::HTMLInputElement::isTextButton): No longer inline. Calls through to InputType. (WebCore::HTMLInputElement::isRadioButton): Ditto. (WebCore::HTMLInputElement::isSearchField): Ditto. (WebCore::HTMLInputElement::isInputTypeHidden): Ditto. (WebCore::HTMLInputElement::isPasswordField): Ditto. (WebCore::HTMLInputElement::isCheckbox): Ditto. (WebCore::HTMLInputElement::isText): Ditto. (WebCore::HTMLInputElement::isEmailField): Ditto. (WebCore::HTMLInputElement::isFileUpload): Ditto. (WebCore::HTMLInputElement::isImageButton): Ditto. (WebCore::HTMLInputElement::isNumberField): Ditto. (WebCore::HTMLInputElement::isSubmitButton): Ditto. (WebCore::HTMLInputElement::isTelephoneField): Ditto. (WebCore::HTMLInputElement::isURLField): Ditto. (WebCore::HTMLInputElement::isEnumeratable): Ditto. (WebCore::HTMLInputElement::isChecked): No longer inline. Calls InputType::isCheckable. (WebCore::HTMLInputElement::hasSpinButton): No longer inline. Calls through to InputType. (WebCore::HTMLInputElement::supportsPlaceholder): No longer inline. Calls isTextType as before, but with no special case for ISINDEX. That special case was unneeded since it returns true from isTextType. (WebCore::HTMLInputElement::checkedRadioButtons): No longer inline. (WebCore::HTMLInputElement::handleBeforeTextInsertedEvent): No longer inline.
- html/HTMLInputElement.h: Removed multiple unneeded includes. The big one is probably InputType.h, but also HTMLFormElement.h. Removed unneeded forward declarations. Made many functions no longer inline since they now need to make virtual function dispatches. Removed the unneeded defaultChecked and webkitdirectory functions. Both are handled by HTML attribute reflection for DOM bindings, and the callers instead can get at the attribute. Made updateCheckedRadioButtons public so it can be called by an InputType class. Removed DeprecatedInputType, InputTypeMap, createTypeMap, deprecatedInputType, allowsIndeterminate, respectHeightAndWidthAttrs, storesValueSeparateFromAttribute, m_imageLoader, m_fileList, m_deprecatedTypeNumber, m_defaultChecked, and m_inited. Renamed m_checked to m_isChecked, m_useDefaultChecked to m_reflectsCheckedAttribute, m_indeterminate tom_isIndeterminate, m_haveType to m_hasType, m_activeSubmit to m_isActivatedSubmit, and m_autofilled to m_isAutofilled.
- html/HiddenInputType.cpp: (WebCore::HiddenInputType::accessKeyAction): Added. (WebCore::HiddenInputType::rendererIsNeeded) Added.: (WebCore::HiddenInputType::storesValueSeparateFromAttribute): Added. (WebCore::HiddenInputType::isHiddenType): Added. (WebCore::HiddenInputType::shouldRespectHeightAndWidthAttributes): Added.
- html/HiddenInputType.h: Ditto.
- html/ImageInputType.cpp: (WebCore::ImageInputType::ImageInputType): Moved out of the header file. (WebCore::ImageInputType::srcAttributeChanged): Added. (WebCore::ImageInputType::attach): Added. (WebCore::ImageInputType::willMoveToNewOwnerDocument): Added. (WebCore::ImageInputType::shouldRespectAlignAttribute): Added. (WebCore::ImageInputType::canBeSuccessfulSubmitButton): Added. (WebCore::ImageInputType::isImageButton): Added. (WebCore::ImageInputType::isEnumeratable): Added. (WebCore::ImageInputType::shouldRespectHeightAndWidthAttributes): Added.
- html/ImageInputType.h: Ditto.
- html/InputType.cpp: (WebCore::InputType::create): Changed argument type to String. There is no value in taking an AtomicString here. (WebCore::InputType::scaledStepValueShouldBeInteger): Fixed typo in this function name. (WebCore::InputType::canSetStringValue): Added. (WebCore::InputType::isKeyboardFocusable): Added. (WebCore::InputType::shouldUseInputMethod): Added. (WebCore::InputType::handleBlurEvent): Added. (WebCore::InputType::accessKeyAction): Added. (WebCore::InputType::attach): Added. (WebCore::InputType::srcAttributeChanged): Added. (WebCore::InputType::willMoveToNewOwnerDocument): Added. (WebCore::InputType::shouldRespectAlignAttribute): Added. (WebCore::InputType::canChangeFromAnotherType): Added. (WebCore::InputType::minOrMaxAttributeChanged): Added. (WebCore::InputType::canBeSuccessfulSubmitButton): Added. (WebCore::InputType::rendererIsNeeded): Added. (WebCore::InputType::files): Added. (WebCore::InputType::getTypeSpecificValue): Added. (WebCore::InputType::fallbackValue): Added. (WebCore::InputType::defaultValue): Added. (WebCore::InputType::canSetSuggestedValue): Added. (WebCore::InputType::shouldSendChangeEventAfterCheckedChanged): Added. (WebCore::InputType::storesValueSeparateFromAttribute): Added. (WebCore::InputType::canSetValue): Added. (WebCore::InputType::willDispatchClick): Added. (WebCore::InputType::didDispatchClick): Added. (WebCore::InputType::isAcceptableValue): Added. (WebCore::InputType::sanitizeValue): Added. (WebCore::InputType::hasUnacceptableValue): Added. (WebCore::InputType::setFileList): Added. (WebCore::InputType::shouldResetOnDocumentActivation): Added. (WebCore::InputType::shouldRespectListAttribute): Added. (WebCore::InputType::shouldRespectSpeechAttribute): Added. (WebCore::InputType::isTextButton): Added. (WebCore::InputType::isRadioButton): Added. (WebCore::InputType::isSearchField): Added. (WebCore::InputType::isHiddenType): Added. (WebCore::InputType::isPasswordField): Added. (WebCore::InputType::isCheckbox): Added. (WebCore::InputType::isEmailField): Added. (WebCore::InputType::isFileUpload): Added. (WebCore::InputType::isImageButton): Added. (WebCore::InputType::isNumberField): Added. (WebCore::InputType::isSubmitButton): Added. (WebCore::InputType::isTelephoneField): Added. (WebCore::InputType::isURLField): Added. (WebCore::InputType::isEnumeratable): Added. (WebCore::InputType::isCheckable): Added. (WebCore::InputType::hasSpinButton): Added. (WebCore::InputType::shouldRespectHeightAndWidthAttributes): Added.
- html/InputType.h: Removed unneeded ExceptionCode.h include and used a typedef instead as we do when we want for forward declare it. Added includes and forward declarations needed for new functions. Added ClickHandlingState structure. Changed the argument to create to a String rather than AtomicString. Added many virtual functions.
- html/IsIndexInputType.cpp: (WebCore::IsIndexInputType::shouldRespectListAttribute): Added.
- html/IsIndexInputType.h: Ditto.
- html/NumberInputType.cpp: (WebCore::NumberInputType::handleBlurEvent): Added. (WebCore::NumberInputType::isAcceptableValue): Added. (WebCore::NumberInputType::sanitizeValue): Added. (WebCore::NumberInputType::hasUnacceptableValue): Added. (WebCore::NumberInputType::shouldRespectSpeechAttribute): Added. (WebCore::NumberInputType::isNumberField): Added. (WebCore::NumberInputType::hasSpinButton): Added.
- html/NumberInputType.h: Ditto.
- html/PasswordInputType.cpp: (WebCore::PasswordInputType::shouldUseInputMethod): Added. (WebCore::PasswordInputType::shouldResetOnDocumentActivation): Added. (WebCore::PasswordInputType::shouldRespectListAttribute): Added. (WebCore::PasswordInputType::shouldRespectSpeechAttribute): Added. (WebCore::PasswordInputType::isPasswordField): Added.
- html/PasswordInputType.h: Ditto.
- html/RadioInputType.cpp: (WebCore::RadioInputType::isKeyboardFocusable): Added. (WebCore::RadioInputType::attach): Added. (WebCore::RadioInputType::shouldSendChangeEventAfterCheckedChanged): Added. (WebCore::RadioInputType::willDispatchClick): Added. (WebCore::RadioInputType::didDispatchClick): Added. (WebCore::RadioInputType::isRadioButton): Added.
- html/RadioInputType.h: Ditto.
- html/RangeInputType.cpp: (WebCore::RangeInputType::accessKeyAction): Added. (WebCore::RangeInputType::minOrMaxAttributeChanged): Added. (WebCore::RangeInputType::fallbackValue): Added. (WebCore::RangeInputType::sanitizeValue): Added. (WebCore::RangeInputType::shouldRespectListAttribute): Added.
- html/RangeInputType.h: Ditto.
- html/ResetInputType.cpp: (WebCore::ResetInputType::defaultValue): Added. (WebCore::ResetInputType::isTextButton): Added.
- html/ResetInputType.h: Ditto.
- html/SearchInputType.cpp: (WebCore::SearchInputType::shouldRespectSpeechAttribute): Added. (WebCore::SearchInputType::isSearchField): Added.
- html/SearchInputType.h: Ditto.
- html/SubmitInputType.cpp: (WebCore::SubmitInputType::canBeSuccessfulSubmitButton): Added. (WebCore::SubmitInputType::defaultValue): Added. (WebCore::SubmitInputType::isSubmitButton): Added. (WebCore::SubmitInputType::isTextButton): Added.
- html/SubmitInputType.h: Ditto.
- html/TelephoneInputType.cpp: (WebCore::TelephoneInputType::shouldRespectSpeechAttribute): Added. (WebCore::TelephoneInputType::isTelephoneField): Added.
- html/TelephoneInputType.h: Ditto.
- html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::shouldUseInputMethod): Added. (WebCore::TextFieldInputType::sanitizeValue): Added. (WebCore::TextFieldInputType::shouldRespectListAttribute): Added.
- html/TextFieldInputType.h: Ditto.
- html/TextInputType.cpp: (WebCore::TextInputType::canSetSuggestedValue): Added. (WebCore::TextInputType::shouldRespectSpeechAttribute): Added.
- html/TextInputType.h: Ditto.
- html/TimeInputType.cpp: (WebCore::TimeInputType::scaledStepValueShouldBeInteger): Fixed typo in the name of this function.
- html/TimeInputType.h: Ditto.
- html/URLInputType.cpp: (WebCore::URLInputType::isURLField): Added.
- html/URLInputType.h: Ditto.
- 9:11 AM Changeset in webkit [74894] by
-
- 2 edits in trunk/LayoutTests
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed, Chromium test expectation update.
Update expectations after r74892. A bunch of previously failing tests
now pass (since they match scrollbars with the mac port). Some tests
also started to fail, they should be fixed by removing their
chromium-mac baselines.
- platform/chromium/test_expectations.txt:
- 9:02 AM Changeset in webkit [74893] by
-
- 2 edits in trunk/WebKit2
Ensure that the correct initial focusable area is focused when tabbing
and shift-tabbing into the WKView.
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView becomeFirstResponder]): Use the keyViewSelectionDirection to set
the initial focus.
- 8:16 AM Changeset in webkit [74892] by
-
- 2 edits in trunk/WebCore
2011-01-03 Mihai Parparita <mihaip@chromium.org>
Unreviewed.
NSScrollView-based scrollbars and ScrollBarTheme-based scrollbars don't look the same
https://bugs.webkit.org/show_bug.cgi?id=51151
Flip switch to use WebThemeEngine for Chromium/Mac scrollbar rendering,
so that it can match Safari's (and thus use the same baselines).
No new tests, should be covered by layout tests (which will need
expectation changes)
- platform/chromium/ScrollbarThemeChromiumMac.mm:
- 8:04 AM Changeset in webkit [74891] by
-
- 2 edits in trunk/WebKit/qt
2011-01-02 Antonio Gomes <agomes@rim.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Refactor EditorClientQt::handleKeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=51306
EditorClientQt::handleKeyboardEvent relies on QWebPagePrivate::editorActionForKeyEvent()
to handle all editor commands that have a QAction associted with it.
In practice, that covers most of editor commands (as one can see in editorCommandWebActions,
in qwebpage.cpp). However, there are some key down events that are associated to no QAction
or need special handling when features like spatial navigation or
caret browsing are enabled. Currently, these cases are being handled with confusing
and nested if/else switch's statements in EditorClientQt::handleKeyboardEvent(),
and the code is hardly readable.
This patch introduces a mapping hash for those cases, simplifying much
the code. Basically, nested switches statements mixed with if/else's were
refactored, and early returns were added right after an event gets consumed
by the Editor.
Since it is a refactor only patch, there is no funcionality change at
all, and then no new tests are being added.
- WebCoreSupport/EditorClientQt.cpp: (WebCore::interpretKeyEvent): (WebCore::EditorClientQt::handleKeyboardEvent):
- 7:50 AM Changeset in webkit [74890] by
-
- 2 edits in trunk/WebCore
2011-01-03 Antonio Gomes <agomes@rim.com>
Unreviewed build fix for WebKit/Gtk+.
RenderThemeGtk::initMediaColors() in RenderThemeGtk2.cpp needs to be
guarded by ENABLE(VIDEO), as it is in its header.
No new tests.
- platform/gtk/RenderThemeGtk2.cpp:
- 6:00 AM Changeset in webkit [74889] by
-
- 2 edits in trunk/Tools
2011-01-03 Koan-Sin Tan <koansin.tan@gmail.com>
Reviewed by Xan Lopez.
"Tool/Scripts/run-launcher --gtk" stopped working after 74855
https://bugs.webkit.org/show_bug.cgi?id=51806
Originally, the $libraryName is 'JavaScriptCore'. When building release
one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
is 'WebKitBuild/Release/Source/JavaScriptCore' now), and
'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
so make it 'WebKitBuild/Release/.libs'
- Scripts/webkitdirs.pm:
Jan 2, 2011:
- 9:45 PM Changeset in webkit [74888] by
-
- 2 edits in trunk/LayoutTests
2011-01-02 Adam Barth <abarth@webkit.org>
Skip this test for now. It's been failing for a while. I'm
investigating the root cause now, but having this red on the buildbot
isn't productive.
- platform/mac/Skipped:
- 8:53 PM Changeset in webkit [74887] by
-
- 13 edits in trunk
<rdar://problem/8812159> Update copyright strings
Rubber-stamped by Simon Fraser.
Source/JavaScriptCore:
- Info.plist:
Source/JavaScriptGlue:
- Info.plist:
WebCore:
- Info.plist:
WebKit/mac:
- Info.plist:
WebKit2:
- Info.plist:
- WebProcess/Info.plist:
WebKitLibraries:
- win/tools/scripts/COPYRIGHT-END-YEAR:
- 8:45 PM Changeset in webkit [74886] by
-
- 2 edits1 add in trunk/WebCore
<rdar://problem/8806570> REGRESSION (r73337): Incorrect text match count when a match occurs in a text field
https://bugs.webkit.org/show_bug.cgi?id=51623
Reviewed by Sam Weinig.
- editing/Editor.cpp:
(WebCore::Editor::countMatchesForText): Actually remember the original search range end
container and offset and restore them when needed, instead of using two references to the
same Range.
- manual-tests/find-count-matches-after-text-control.html: Added.
- 7:29 PM Changeset in webkit [74885] by
-
- 2 edits in trunk/LayoutTests
2011-01-02 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
Two more fixes.
- platform/chromium/test_expectations.txt:
- 7:18 PM Changeset in webkit [74884] by
-
- 2 edits in trunk/LayoutTests
2011-01-02 Kent Tamura <tkent@chromium.org>
Unreviewed, correct test_expectations.txt syntax.
- platform/chromium/test_expectations.txt:
- 6:18 PM Changeset in webkit [74883] by
-
- 2 edits7 adds in trunk/LayoutTests
2011-01-02 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
- Add expectation files for application-plugin-plugins-disabled.html
- Add some flaky tests to test_expectations.txt
- platform/chromium-linux/plugins/application-plugin-plugins-disabled-expected.checksum: Added.
- platform/chromium-linux/plugins/application-plugin-plugins-disabled-expected.png: Added.
- platform/chromium-mac/plugins/application-plugin-plugins-disabled-expected.checksum: Added.
- platform/chromium-mac/plugins/application-plugin-plugins-disabled-expected.png: Added.
- platform/chromium-win/plugins/application-plugin-plugins-disabled-expected.checksum: Added.
- platform/chromium-win/plugins/application-plugin-plugins-disabled-expected.png: Added.
- platform/chromium-win/plugins/application-plugin-plugins-disabled-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 5:29 PM Changeset in webkit [74882] by
-
- 5 edits in trunk
2011-01-02 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Csaba Osztrogonác.
WebKit 2 does not build on 64bits with a recent GCC
https://bugs.webkit.org/show_bug.cgi?id=51754
Use explicitely 64 bits types for the attributes of DatabaseDetails.
- storage/DatabaseDetails.h: (WebCore::DatabaseDetails::expectedUsage): (WebCore::DatabaseDetails::currentUsage):
2011-01-02 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Csaba Osztrogonác.
WebKit 2 does not build on 64bits with a recent GCC
https://bugs.webkit.org/show_bug.cgi?id=51754
Change the argument coding for DatabaseDetails to use explicitely the 64 bits type.
- Shared/OriginAndDatabases.h:
- Shared/WebCoreArgumentCoders.h:
- 5:06 PM Changeset in webkit [74881] by
-
- 3 edits in trunk/Tools
2011-01-02 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Make EFL a core builder
https://bugs.webkit.org/show_bug.cgi?id=51804
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
- Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
- 4:08 PM Changeset in webkit [74880] by
-
- 2 edits in trunk/Tools
[Qt] Unreviewed fix after r74855 and r74875.
- BuildSlaveSupport/built-product-archive:
- Create directories explicitly.
- Pass shell=True to subprocess.call().
- 3:38 PM Changeset in webkit [74879] by
-
- 2 edits in trunk/WebCore
2011-01-02 Patrick Gansterer <Patrick Gansterer>
Unreviewed WinCE build fix for r74868.
- platform/graphics/wince/ImageBufferWinCE.cpp: (WebCore::getImageData):
- 3:26 PM Changeset in webkit [74878] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix GTK+ build after r74855.
Reviewed by Xan Lopez.
- GNUmakefile.am: Fix include pathes.
- 2:27 PM Changeset in webkit [74877] by
-
- 20 edits in trunk/WebCore
2011-01-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74847.
http://trac.webkit.org/changeset/74847
https://bugs.webkit.org/show_bug.cgi?id=51803
"Preprocessor guards should be in header files" (Requested by
ap on #webkit).
- bindings/js/JSDOMWindowBase.cpp:
- dom/Document.cpp: (WebCore::Document::recalcStyle):
- html/HTMLDocument.cpp:
- loader/FrameLoader.cpp:
- loader/ResourceLoadNotifier.cpp:
- page/Chrome.cpp:
- page/Console.cpp:
- page/ContextMenuController.cpp:
- page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchEvent):
- page/EventHandler.cpp:
- page/Page.cpp:
- storage/Database.cpp:
- workers/AbstractWorker.cpp:
- workers/DefaultSharedWorkerRepository.cpp:
- workers/SharedWorker.cpp:
- workers/Worker.cpp:
- workers/WorkerContext.cpp:
- workers/WorkerMessagingProxy.cpp:
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener):
- 2:11 PM Changeset in webkit [74876] by
-
- 3 edits1 copy in trunk/LayoutTests
2011-01-02 Robert Hogan <robert@webkit.org>
Unreviewed, update expected results.
Update expected results for tests added in r74872
Skip test on Qt as Qt Styled Widgets are no longer getting
rendered when plugins are disabled. This is a bug.
- platform/gtk/plugins/application-plugin-plugins-disabled-expected.txt: Copied from LayoutTests/plugins/application-plugin-plugins-disabled-expected.txt.
- platform/qt/Skipped:
- plugins/application-plugin-plugins-disabled-expected.txt:
- 1:44 PM Changeset in webkit [74875] by
-
- 2 edits in trunk/Tools
[Qt] Unreviewed fix after r74855.
Move JavaScriptCore to Source
https://bugs.webkit.org/show_bug.cgi?id=51604
- BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
- 1:28 PM Changeset in webkit [74874] by
-
- 2 edits in trunk/Tools
[Qt] Unreviewed run-javasriptcore-tests fix after r74855.
Move JavaScriptCore to Source
https://bugs.webkit.org/show_bug.cgi?id=51604
- Scripts/webkitdirs.pm:
- 1:16 PM Changeset in webkit [74873] by
-
- 2 edits in trunk/WebKit2
Move JavaScriptCore to Source
https://bugs.webkit.org/show_bug.cgi?id=51604
Reviewed by Adam Barth.
Workaround until moving all sources to Source directory is finished.
- Scripts/generate-forwarding-headers.pl: Add Sources to searching path for JavaScriptCore.
- 1:13 PM Changeset in webkit [74872] by
-
- 1 edit3 adds in trunk/LayoutTests
2011-01-02 Robert Hogan <robert@webkit.org>
Unreviewed.
Layout tests from changeset r56661 were missed
This test was accidentally omitted from changeset 56661.
See also https://webkit.org/b/32196
- platform/qt/plugins/application-plugin-plugins-disabled-expected.txt: Added.
- plugins/application-plugin-plugins-disabled-expected.txt: Added.
- plugins/application-plugin-plugins-disabled.html: Added.
- 11:31 AM Changeset in webkit [74871] by
-
- 2 edits in trunk/WebCore
2011-01-02 Patrick Gansterer <Patrick Gansterer>
[CMake] Unreviewed build fix.
- CMakeLists.txt:
- 11:16 AM Changeset in webkit [74870] by
-
- 3 edits in trunk
2011-01-02 Patrick Gansterer <Patrick Gansterer>
[CMake] Unreviewed build fix.
- CMakeLists.txt:
- Source/cmake/OptionsCommon.cmake:
- 8:06 AM Changeset in webkit [74869] by
-
- 2 edits in trunk/Tools
2011-01-02 Robert Hogan <robert@webkit.org>
Unreviewed, build fix.
[Qt] Fix DRT build after 74855
- DumpRenderTree/qt/DumpRenderTree.pro:
- 2:38 AM Changeset in webkit [74868] by
-
- 29 edits in trunk
2011-01-02 Dirk Schulze <krit@webkit.org>
Reviewed by Simon Fraser.
Clarify ImageBuffer and ImageData relationship
https://bugs.webkit.org/show_bug.cgi?id=51297
Use ByteArray instead of ImageData.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas):
2011-01-02 Dirk Schulze <krit@webkit.org>
Reviewed by Simon Fraser.
Clarify ImageBuffer and ImageData relationship
https://bugs.webkit.org/show_bug.cgi?id=51297
Remove references to ImageData and CanvasPixelArray from ImageBuffer and SVG filter/masker code,
since this was a layering violation, and replaced it by ByteArray.
No change of functionality, so no new test added.
- html/ImageData.cpp: (WebCore::ImageData::create): (WebCore::ImageData::ImageData):
- html/ImageData.h: Added new constructor with ByteArray input. (WebCore::ImageData::width): (WebCore::ImageData::height): (WebCore::ImageData::data):
- html/canvas/CanvasPixelArray.cpp: (WebCore::CanvasPixelArray::create): (WebCore::CanvasPixelArray::CanvasPixelArray):
- html/canvas/CanvasPixelArray.h: New conctructor with ByteArray input, used by HTML Canvas. (WebCore::CanvasPixelArray::data): (WebCore::CanvasPixelArray::length): (WebCore::CanvasPixelArray::set): (WebCore::CanvasPixelArray::get):
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::getImageData): (WebCore::CanvasRenderingContext2D::putImageData):
- platform/graphics/ImageBuffer.h:
- platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
- platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):
- platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
- platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::apply):
- platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
- platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::setDestinationPixels): (WebCore::FEConvolveMatrix::apply):
- platform/graphics/filters/FEConvolveMatrix.h:
- platform/graphics/filters/FEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply):
- platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::apply):
- platform/graphics/filters/FELighting.cpp: (WebCore::FELighting::apply):
- platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::apply):
- platform/graphics/filters/FETurbulence.cpp: (WebCore::FETurbulence::apply):
- platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::asImageBuffer): (WebCore::FilterEffect::asUnmultipliedImage): (WebCore::FilterEffect::asPremultipliedImage): (WebCore::FilterEffect::copyImageBytes): (WebCore::FilterEffect::copyUnmultipliedImage): (WebCore::FilterEffect::copyPremultipliedImage): (WebCore::FilterEffect::createUnmultipliedImageResult): (WebCore::FilterEffect::createPremultipliedImageResult):
- platform/graphics/filters/FilterEffect.h:
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
- platform/graphics/wince/ImageBufferWinCE.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
- platform/graphics/wx/ImageBufferWx.cpp: (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
- rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
- 1:51 AM Changeset in webkit [74867] by
-
- 2 edits in trunk/WebKit/gtk
2011-01-02 Xan Lopez <xlopez@igalia.com>
Fix GTK+ build.
- GNUmakefile.am: tests do actually include JSC.
- 1:12 AM Changeset in webkit [74866] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-02 Adam Barth <abarth@webkit.org>
One more .. missing in the Qt build.
- jsc.pro:
- 1:06 AM Changeset in webkit [74865] by
-
- 4 edits in trunk
WebKit/gtk:
2011-01-02 Xan Lopez <xlopez@igalia.com>
Fix GTK+ build.
- GNUmakefile.am: remove individual -I$(srcdir)/Source when we'll already get them from javascriptcore_cppflags, and add it for the introspection build (which is not tested in the bots).
2011-01-02 Xan Lopez <xlopez@igalia.com>
Fix GTK+ build.
- GNUmakefile.am: add -I$(srcdir)/Source to the JSC cppflags so that anyone can include its headers without adding the prefix 'Source/'.
- 12:28 AM Changeset in webkit [74864] by
-
- 2 edits in trunk/WebKit/gtk
2011-01-02 Adam Barth <abarth@webkit.org>
Speculative build fix for GTK. Add Source to the include paths.
- GNUmakefile.am:
- 12:15 AM Changeset in webkit [74863] by
-
- 6 edits in trunk/Source/JavaScriptCore
2011-01-02 Carl Lobo <carllobo@gmail.com>
Reviewed by Adam Barth.
Fix Windows Build for non-production where VSPropsRedirectionDir is not defined.
https://bugs.webkit.org/show_bug.cgi?id=51797
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.vcproj/jsc/jsc.vcproj:
- JavaScriptCore.vcproj/testapi/testapi.vcproj:
Jan 1, 2011:
- 11:52 PM Changeset in webkit [74862] by
-
- 2 edits in trunk/WebKit2
2011-01-01 Adam Barth <abarth@webkit.org>
Speculative build fix for Qt. Add some more include paths.
- WebKit2.pro:
- 11:42 PM Changeset in webkit [74861] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-01-01 Adam Barth <abarth@webkit.org>
Fix relative include paths in an attempt to fix the Qt build.
- JavaScriptCore.pri:
- JavaScriptCore.pro:
- 11:14 PM Changeset in webkit [74860] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-01 Adam Barth <abarth@webkit.org>
Another speculative build fix for GTK.
- GNUmakefile.am:
- 11:09 PM Changeset in webkit [74859] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-01 Adam Barth <abarth@webkit.org>
Speculative build fix for GTK. Update the paths in GNUmakefile to
include "Source".
- GNUmakefile.am:
- 10:46 PM Changeset in webkit [74858] by
-
- 2 edits in trunk/Tools
2011-01-01 Adam Barth <abarth@webkit.org>
Remove the assumption from the Qt and Gtk builds that every project is
in the root directory.
- Scripts/build-webkit:
- 10:40 PM Changeset in webkit [74857] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-01-01 Adam Barth <abarth@webkit.org>
Update relative paths in JavaScriptCore.gyp to account for the extra
level of directories.
- JavaScriptCore.gyp/JavaScriptCore.gyp:
- 10:28 PM Changeset in webkit [74856] by
-
- 2 edits in trunk/Tools
2011-01-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Teach svn-apply how to apply patches even though JavaScriptCore has moved
https://bugs.webkit.org/show_bug.cgi?id=51796
After this change, svn-apply will magically apply patches to
JavaScriptCore/foo to Source/JavaScriptCore/foo.
- Scripts/VCSUtils.pm:
- 10:22 PM Changeset in webkit [74855] by
-
- 57 edits1 move in trunk
Move JavaScriptCore to Source
https://bugs.webkit.org/show_bug.cgi?id=51604
Reviewed by Eric Seidel.
Update references to JavaScriptCore to point to the new location.
- Android.mk:
- CMakeLists.txt:
- DerivedSources.pro:
- GNUmakefile.am:
- Makefile:
- WebKit.pri:
- WebKit.pro:
- wscript:
Tools:
Update references to JavaScriptCore to point to the new location.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/ImageDiff.pro:
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- DumpRenderTree/wscript:
- Scripts/build-jsc:
- Scripts/build-webkit:
- Scripts/do-file-rename:
- Scripts/do-webcore-rename:
- Scripts/run-javascriptcore-tests:
- Scripts/update-javascriptcore-test-results:
- Scripts/webkitdirs.pm:
- Scripts/webkitpy/common/config/build_unittest.py:
- Scripts/webkitpy/style/checker.py:
- Scripts/webkitpy/style/checker_unittest.py:
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
- WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
- WebKitTestRunner/qt/WebKitTestRunner.pro:
- wx/build/settings.py:
WebCore:
Update references to JavaScriptCore.
- Android.derived.jscbindings.mk:
- Android.v8bindings.mk:
- CMakeLists.txt:
- WebCore.gyp/WebCore.gyp:
- WebCore.pro:
- These changes are subtle and might not be 100% correct.
- move-js-headers.sh:
WebKit/chromium:
- WebKit.gyp:
- Point to JavaScriptCore in its new location.
WebKit/gtk:
- GNUmakefile.am:
- docs/GNUmakefile.am:
- Point to JavaScriptCore in its new location.
WebKit/qt:
- WebKit_pch.h:
- docs/qtwebkit.qdocconf:
- Point to JavaScriptCore in its new location.
WebKit/win:
- WebKit.vcproj/WebKit.sln:
- Point to JavaScriptCore in its new location.
WebKit/wx:
- bindings/python/wscript:
- wscript:
- Point to JavaScriptCore in its new location.
WebKit2:
- WebKit2.pro:
- Point to JavaScriptCore in its new location.
Websites/bugs.webkit.org:
- PrettyPatch/PrettyPatch.rb:
- Remove reference to JavaScriptCore as a source directory.
Websites/webkit.org:
- coding/assertion-guidelines.html:
- Update documentation to point to the new location of JavaScriptCore.
- 8:33 PM Changeset in webkit [74854] by
-
- 5 edits7 adds in trunk
2011-01-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
forbid sandboxed frames to call top.close() when allow-same-origin is not setted
https://bugs.webkit.org/show_bug.cgi?id=38340
We now pass the ScriptExecutionContext to window.close so it can find
the Frame and check whether navigation is allowed. This check will
almost always pass because you can only close top-level frames, but the
check will fail when the calling script is sandboxed.
Tests: fast/frames/sandboxed-iframe-close-top-noclose.html
fast/frames/sandboxed-iframe-close-top.html
- page/DOMWindow.cpp: (WebCore::DOMWindow::close):
- page/DOMWindow.h:
- page/DOMWindow.idl:
2011-01-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
forbid sandboxed frames to call top.close() when allow-same-origin is not setted
https://bugs.webkit.org/show_bug.cgi?id=38340
Test the interaction between the HTML5 sandbox and window.close.
- fast/frames/resources/close-top.html: Added.
- fast/frames/resources/sandboxed-iframe-close-top-does-close.html: Added.
- fast/frames/resources/sandboxed-iframe-close-top-does-not-close.html: Added.
- fast/frames/sandboxed-iframe-close-top-expected.txt: Added.
- fast/frames/sandboxed-iframe-close-top-noclose-expected.txt: Added.
- fast/frames/sandboxed-iframe-close-top-noclose.html: Added.
- fast/frames/sandboxed-iframe-close-top.html: Added.
- 6:28 PM Changeset in webkit [74853] by
-
- 5 edits2 adds in trunk
2011-01-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
sandbox iframes have access to top.history methods
https://bugs.webkit.org/show_bug.cgi?id=38152
To enforce the sandbox restrictions on History, we need to pass the
ScriptExecutionContext to WebCore. This patch leaves the original
History methods in place because they are used directly by folks who
don't care about security checks.
Test: fast/frames/sandboxed-iframe-history-denied.html
- page/History.cpp: (WebCore::History::back): (WebCore::History::forward): (WebCore::History::go):
- page/History.h:
- page/History.idl:
2011-01-01 Justin Schuh <jschuh@chromium.org>
Reviewed by Eric Seidel.
sandbox iframes have access to top.history methods
https://bugs.webkit.org/show_bug.cgi?id=38152
Test that sandboxed iframes cannot use history to navigate the top
frame. This test is less than ideal, as described in the test itself.
If I was really on top of things, I'd add a test for successful use of
the history API when allow-top-navigation is set, but that test would
be complicated and I'm lazy (enough to copy directly from abarth).
- fast/frames/sandboxed-iframe-history-denied-expected.txt: Added.
- fast/frames/sandboxed-iframe-history-denied.html: Added.
- 6:04 PM Changeset in webkit [74852] by
-
- 14 edits1 move in trunk
Move Sources to Source
https://bugs.webkit.org/show_bug.cgi?id=51794
Reviewed by Eric Seidel.
Update build files to point to the new location.
- CMakeLists.txt:
- GNUmakefile.am:
- Makefile:
- autogen.sh:
- configure.ac:
Tools:
Update scripts to point to the new location.
- Scripts/build-webkit:
- Scripts/do-file-rename:
- Scripts/do-webcore-rename:
- Scripts/webkitpy/common/config/build.py:
- Scripts/webkitpy/common/config/build_unittest.py:
Websites/bugs.webkit.org:
- PrettyPatch/PrettyPatch.rb:
- 5:50 PM Changeset in webkit [74851] by
-
- 9 edits1 delete in trunk/WebCore
2011-01-01 Adam Barth <abarth@webkit.org>
Remove empty file.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/DOMAllInOne.cpp:
- dom/Entity.cpp: Removed.
- 5:43 PM Changeset in webkit [74850] by
-
- 7 edits1 delete in trunk/WebCore
2011-01-01 Adam Barth <abarth@webkit.org>
Remove empty file.
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSPopStateEventCustom.cpp: Removed.
- 5:37 PM Changeset in webkit [74849] by
-
- 5 edits2 deletes in trunk/WebCore
2011-01-01 Adam Barth <abarth@webkit.org>
Remove empty files.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/generic/BindingFrame.h: Removed.
- bindings/generic/BindingLocation.h: Removed.
- 4:35 PM Changeset in webkit [74848] by
-
- 1 edit in trunk/WebKit2/WebKit2.xcodeproj
Changed WebKit2.xcodeproj's svn:ignore property up to match other projects'
- 10:00 AM Changeset in webkit [74847] by
-
- 20 edits in trunk/WebCore
2011-01-01 Konstantin Tokarev <Konstantin Tokarev>
Reviewed by Darin Adler.
Don't include Inspector headers when Inspector is disabled
https://bugs.webkit.org/show_bug.cgi?id=51789
- bindings/js/JSDOMWindowBase.cpp: Include Inspector headers when Inspector is enabled
- dom/Document.cpp: Include Inspector headers when Inspector is enabled (WebCore::Document::recalcStyle): Disabled InspectorInstrumentationCookie handling
- html/HTMLDocument.cpp: Include Inspector headers when Inspector is enabled
- loader/FrameLoader.cpp: Include Inspector headers when Inspector is enabled
- loader/ResourceLoadNotifier.cpp: Include Inspector headers when Inspector is enabled
- page/Chrome.cpp: Include Inspector headers when Inspector is enabled
- page/Console.cpp: Include Inspector headers when Inspector is enabled
- page/ContextMenuController.cpp: Include Inspector headers when Inspector is enabled
- page/DOMWindow.cpp: Include Inspector headers when Inspector is enabled (WebCore::DOMWindow::dispatchEvent): Disabled InspectorInstrumentationCookie handling
- page/EventHandler.cpp: Include Inspector headers when Inspector is enabled
- page/Page.cpp: Include Inspector headers when Inspector is enabled
- storage/Database.cpp: Include Inspector headers when Inspector is enabled
- workers/AbstractWorker.cpp: Include Inspector headers when Inspector is enabled
- workers/DefaultSharedWorkerRepository.cpp: Include Inspector headers when Inspector is enabled
- workers/SharedWorker.cpp: Include Inspector headers when Inspector is enabled
- workers/Worker.cpp: Include Inspector headers when Inspector is enabled
- workers/WorkerContext.cpp: Include Inspector headers when Inspector is enabled
- workers/WorkerMessagingProxy.cpp: Include Inspector headers when Inspector is enabled
- xml/XMLHttpRequest.cpp: Include Inspector headers when Inspector is enabled (WebCore::XMLHttpRequest::callReadyStateChangeListener): Disabled InspectorInstrumentationCookie handling
- 3:01 AM Changeset in webkit [74846] by
-
- 2 edits5 adds in trunk/LayoutTests
2011-01-01 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
One more rebaseline for a spelling test, and remove passing tests from
test_expectations.txt.
- platform/chromium-linux/editing/spelling/inline_spelling_markers-expected.checksum: Added.
- platform/chromium-linux/editing/spelling/inline_spelling_markers-expected.png: Added.
- platform/chromium-win/editing/spelling/inline_spelling_markers-expected.checksum: Added.
- platform/chromium-win/editing/spelling/inline_spelling_markers-expected.png: Added.
- platform/chromium-win/editing/spelling/inline_spelling_markers-expected.txt: Added.
- platform/chromium/test_expectations.txt:
Dec 31, 2010:
- 10:54 PM Changeset in webkit [74845] by
-
- 371 edits in trunk/LayoutTests
Unreviewed, test expectation update.
r74844 enabled spell checker on Chromium Linux and Chromium
Windows. So we need to update all of images with misspelled words.
- platform/chromium-linux/editing/deleting/delete-3928305-fix-expected.checksum:
- platform/chromium-linux/editing/deleting/delete-3928305-fix-expected.png:
- platform/chromium-linux/editing/deleting/delete-3959464-fix-expected.checksum:
- platform/chromium-linux/editing/deleting/delete-3959464-fix-expected.png:
- platform/chromium-linux/editing/deleting/delete-and-undo-expected.checksum:
- platform/chromium-linux/editing/deleting/delete-and-undo-expected.png:
- platform/chromium-linux/editing/deleting/delete-block-contents-003-expected.checksum:
- platform/chromium-linux/editing/deleting/delete-block-contents-003-expected.png:
- platform/chromium-linux/editing/deleting/delete-contiguous-ws-001-expected.checksum:
- platform/chromium-linux/editing/deleting/delete-contiguous-ws-001-expected.png:
- platform/chromium-linux/editing/deleting/delete-tab-002-expected.checksum:
- platform/chromium-linux/editing/deleting/delete-tab-002-expected.png:
- platform/chromium-linux/editing/deleting/delete-tab-003-expected.checksum:
- platform/chromium-linux/editing/deleting/delete-tab-003-expected.png:
- platform/chromium-linux/editing/deleting/delete-to-select-table-expected.checksum:
- platform/chromium-linux/editing/deleting/delete-to-select-table-expected.png:
- platform/chromium-linux/editing/deleting/delete-trailing-ws-002-expected.checksum:
- platform/chromium-linux/editing/deleting/delete-trailing-ws-002-expected.png:
- platform/chromium-linux/editing/deleting/delete-ws-fixup-001-expected.checksum:
- platform/chromium-linux/editing/deleting/delete-ws-fixup-001-expected.png:
- platform/chromium-linux/editing/deleting/delete-ws-fixup-002-expected.checksum:
- platform/chromium-linux/editing/deleting/delete-ws-fixup-002-expected.png:
- platform/chromium-linux/editing/execCommand/5569741-expected.checksum:
- platform/chromium-linux/editing/execCommand/5569741-expected.png:
- platform/chromium-linux/editing/execCommand/insert-list-and-stitch-expected.checksum:
- platform/chromium-linux/editing/execCommand/insert-list-and-stitch-expected.png:
- platform/chromium-linux/editing/execCommand/insertHorizontalRule-expected.checksum:
- platform/chromium-linux/editing/execCommand/insertHorizontalRule-expected.png:
- platform/chromium-linux/editing/execCommand/outdent-selection-expected.checksum:
- platform/chromium-linux/editing/execCommand/outdent-selection-expected.png:
- platform/chromium-linux/editing/inserting/5418891-expected.checksum:
- platform/chromium-linux/editing/inserting/5418891-expected.png:
- platform/chromium-linux/editing/inserting/editing-empty-divs-expected.checksum:
- platform/chromium-linux/editing/inserting/editing-empty-divs-expected.png:
- platform/chromium-linux/editing/inserting/insert-3907422-fix-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-3907422-fix-expected.png:
- platform/chromium-linux/editing/inserting/insert-br-004-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-br-004-expected.png:
- platform/chromium-linux/editing/inserting/insert-br-005-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-br-005-expected.png:
- platform/chromium-linux/editing/inserting/insert-br-007-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-br-007-expected.png:
- platform/chromium-linux/editing/inserting/insert-div-007-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-div-007-expected.png:
- platform/chromium-linux/editing/inserting/insert-div-012-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-div-012-expected.png:
- platform/chromium-linux/editing/inserting/insert-div-013-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-div-013-expected.png:
- platform/chromium-linux/editing/inserting/insert-div-014-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-div-014-expected.png:
- platform/chromium-linux/editing/inserting/insert-div-015-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-div-015-expected.png:
- platform/chromium-linux/editing/inserting/insert-div-016-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-div-016-expected.png:
- platform/chromium-linux/editing/inserting/insert-div-017-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-div-017-expected.png:
- platform/chromium-linux/editing/inserting/insert-div-018-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-div-018-expected.png:
- platform/chromium-linux/editing/inserting/insert-div-019-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-div-019-expected.png:
- platform/chromium-linux/editing/inserting/insert-div-020-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-div-020-expected.png:
- platform/chromium-linux/editing/inserting/insert-div-021-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-div-021-expected.png:
- platform/chromium-linux/editing/inserting/insert-div-022-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-div-022-expected.png:
- platform/chromium-linux/editing/inserting/insert-div-025-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-div-025-expected.png:
- platform/chromium-linux/editing/inserting/insert-div-027-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-div-027-expected.png:
- platform/chromium-linux/editing/inserting/insert-paragraph-02-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-paragraph-02-expected.png:
- platform/chromium-linux/editing/inserting/insert-paragraph-03-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-paragraph-03-expected.png:
- platform/chromium-linux/editing/inserting/insert-tab-002-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-tab-002-expected.png:
- platform/chromium-linux/editing/inserting/insert-tab-003-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-tab-003-expected.png:
- platform/chromium-linux/editing/inserting/insert-text-with-newlines-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-text-with-newlines-expected.png:
- platform/chromium-linux/editing/inserting/paragraph-separator-01-expected.checksum:
- platform/chromium-linux/editing/inserting/paragraph-separator-01-expected.png:
- platform/chromium-linux/editing/inserting/paragraph-separator-02-expected.checksum:
- platform/chromium-linux/editing/inserting/paragraph-separator-02-expected.png:
- platform/chromium-linux/editing/inserting/paragraph-separator-03-expected.checksum:
- platform/chromium-linux/editing/inserting/paragraph-separator-03-expected.png:
- platform/chromium-linux/editing/inserting/return-key-with-selection-001-expected.checksum:
- platform/chromium-linux/editing/inserting/return-key-with-selection-001-expected.png:
- platform/chromium-linux/editing/inserting/return-key-with-selection-002-expected.checksum:
- platform/chromium-linux/editing/inserting/return-key-with-selection-002-expected.png:
- platform/chromium-linux/editing/inserting/return-key-with-selection-003-expected.checksum:
- platform/chromium-linux/editing/inserting/return-key-with-selection-003-expected.png:
- platform/chromium-linux/editing/inserting/typing-002-expected.checksum:
- platform/chromium-linux/editing/inserting/typing-002-expected.png:
- platform/chromium-linux/editing/inserting/typing-around-br-001-expected.checksum:
- platform/chromium-linux/editing/inserting/typing-around-br-001-expected.png:
- platform/chromium-linux/editing/pasteboard/4242293-expected.checksum:
- platform/chromium-linux/editing/pasteboard/4242293-expected.png:
- platform/chromium-linux/editing/pasteboard/4944770-1-expected.checksum:
- platform/chromium-linux/editing/pasteboard/4944770-1-expected.png:
- platform/chromium-linux/editing/pasteboard/8145-2-expected.checksum:
- platform/chromium-linux/editing/pasteboard/8145-2-expected.png:
- platform/chromium-linux/editing/pasteboard/cut-text-001-expected.checksum:
- platform/chromium-linux/editing/pasteboard/cut-text-001-expected.png:
- platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.checksum:
- platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.png:
- platform/chromium-linux/editing/pasteboard/merge-after-delete-1-expected.checksum:
- platform/chromium-linux/editing/pasteboard/merge-after-delete-1-expected.png:
- platform/chromium-linux/editing/pasteboard/merge-after-delete-2-expected.checksum:
- platform/chromium-linux/editing/pasteboard/merge-after-delete-2-expected.png:
- platform/chromium-linux/editing/pasteboard/merge-after-delete-expected.checksum:
- platform/chromium-linux/editing/pasteboard/merge-after-delete-expected.png:
- platform/chromium-linux/editing/pasteboard/merge-end-4-expected.checksum:
- platform/chromium-linux/editing/pasteboard/merge-end-4-expected.png:
- platform/chromium-linux/editing/pasteboard/merge-end-blockquote-expected.checksum:
- platform/chromium-linux/editing/pasteboard/merge-end-blockquote-expected.png:
- platform/chromium-linux/editing/pasteboard/merge-end-list-expected.checksum:
- platform/chromium-linux/editing/pasteboard/merge-end-list-expected.png:
- platform/chromium-linux/editing/pasteboard/merge-end-table-expected.checksum:
- platform/chromium-linux/editing/pasteboard/merge-end-table-expected.png:
- platform/chromium-linux/editing/pasteboard/paste-blockquote-3-expected.checksum:
- platform/chromium-linux/editing/pasteboard/paste-blockquote-3-expected.png:
- platform/chromium-linux/editing/pasteboard/paste-text-001-expected.checksum:
- platform/chromium-linux/editing/pasteboard/paste-text-001-expected.png:
- platform/chromium-linux/editing/pasteboard/paste-text-012-expected.checksum:
- platform/chromium-linux/editing/pasteboard/paste-text-012-expected.png:
- platform/chromium-linux/editing/pasteboard/paste-text-013-expected.checksum:
- platform/chromium-linux/editing/pasteboard/paste-text-013-expected.png:
- platform/chromium-linux/editing/pasteboard/paste-text-014-expected.checksum:
- platform/chromium-linux/editing/pasteboard/paste-text-014-expected.png:
- platform/chromium-linux/editing/pasteboard/paste-text-019-expected.checksum:
- platform/chromium-linux/editing/pasteboard/paste-text-019-expected.png:
- platform/chromium-linux/editing/pasteboard/paste-xml-expected.checksum:
- platform/chromium-linux/editing/pasteboard/paste-xml-expected.png:
- platform/chromium-linux/editing/pasteboard/undoable-fragment-removes-expected.checksum:
- platform/chromium-linux/editing/pasteboard/undoable-fragment-removes-expected.png:
- platform/chromium-linux/editing/selection/13804-expected.checksum:
- platform/chromium-linux/editing/selection/13804-expected.png:
- platform/chromium-linux/editing/selection/5234383-1-expected.checksum:
- platform/chromium-linux/editing/selection/5234383-1-expected.png:
- platform/chromium-linux/editing/selection/5234383-2-expected.checksum:
- platform/chromium-linux/editing/selection/5234383-2-expected.png:
- platform/chromium-linux/editing/selection/extend-by-word-001-expected.checksum:
- platform/chromium-linux/editing/selection/extend-by-word-001-expected.png:
- platform/chromium-linux/editing/selection/move-backwords-by-word-001-expected.checksum:
- platform/chromium-linux/editing/selection/move-backwords-by-word-001-expected.png:
- platform/chromium-linux/editing/selection/move-by-character-001-expected.checksum:
- platform/chromium-linux/editing/selection/move-by-character-001-expected.png:
- platform/chromium-linux/editing/selection/move-by-line-001-expected.checksum:
- platform/chromium-linux/editing/selection/move-by-line-001-expected.png:
- platform/chromium-linux/editing/selection/move-by-word-001-expected.checksum:
- platform/chromium-linux/editing/selection/move-by-word-001-expected.png:
- platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.checksum:
- platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.png:
- platform/chromium-linux/editing/selection/unrendered-002-expected.checksum:
- platform/chromium-linux/editing/selection/unrendered-002-expected.png:
- platform/chromium-linux/editing/spelling/spelling-expected.checksum:
- platform/chromium-linux/editing/spelling/spelling-expected.png:
- platform/chromium-linux/editing/style/5046875-2-expected.checksum:
- platform/chromium-linux/editing/style/5046875-2-expected.png:
- platform/chromium-linux/editing/style/block-styles-007-expected.checksum:
- platform/chromium-linux/editing/style/block-styles-007-expected.png:
- platform/chromium-linux/editing/style/create-block-for-style-002-expected.checksum:
- platform/chromium-linux/editing/style/create-block-for-style-002-expected.png:
- platform/chromium-linux/editing/style/create-block-for-style-003-expected.checksum:
- platform/chromium-linux/editing/style/create-block-for-style-003-expected.png:
- platform/chromium-linux/editing/style/create-block-for-style-004-expected.checksum:
- platform/chromium-linux/editing/style/create-block-for-style-004-expected.png:
- platform/chromium-linux/editing/style/create-block-for-style-006-expected.checksum:
- platform/chromium-linux/editing/style/create-block-for-style-006-expected.png:
- platform/chromium-linux/editing/style/create-block-for-style-008-expected.checksum:
- platform/chromium-linux/editing/style/create-block-for-style-008-expected.png:
- platform/chromium-linux/editing/style/create-block-for-style-009-expected.checksum:
- platform/chromium-linux/editing/style/create-block-for-style-009-expected.png:
- platform/chromium-linux/editing/style/create-block-for-style-011-expected.checksum:
- platform/chromium-linux/editing/style/create-block-for-style-011-expected.png:
- platform/chromium-linux/editing/style/create-block-for-style-012-expected.checksum:
- platform/chromium-linux/editing/style/create-block-for-style-012-expected.png:
- platform/chromium-linux/editing/style/create-block-for-style-013-expected.checksum:
- platform/chromium-linux/editing/style/create-block-for-style-013-expected.png:
- platform/chromium-linux/fast/dom/blur-contenteditable-expected.checksum:
- platform/chromium-linux/fast/dom/blur-contenteditable-expected.png:
- platform/chromium-win/editing/deleting/delete-3928305-fix-expected.checksum:
- platform/chromium-win/editing/deleting/delete-3928305-fix-expected.png:
- platform/chromium-win/editing/deleting/delete-3959464-fix-expected.checksum:
- platform/chromium-win/editing/deleting/delete-3959464-fix-expected.png:
- platform/chromium-win/editing/deleting/delete-and-undo-expected.checksum:
- platform/chromium-win/editing/deleting/delete-and-undo-expected.png:
- platform/chromium-win/editing/deleting/delete-block-contents-003-expected.checksum:
- platform/chromium-win/editing/deleting/delete-block-contents-003-expected.png:
- platform/chromium-win/editing/deleting/delete-contiguous-ws-001-expected.checksum:
- platform/chromium-win/editing/deleting/delete-contiguous-ws-001-expected.png:
- platform/chromium-win/editing/deleting/delete-tab-002-expected.checksum:
- platform/chromium-win/editing/deleting/delete-tab-002-expected.png:
- platform/chromium-win/editing/deleting/delete-tab-003-expected.checksum:
- platform/chromium-win/editing/deleting/delete-tab-003-expected.png:
- platform/chromium-win/editing/deleting/delete-to-select-table-expected.checksum:
- platform/chromium-win/editing/deleting/delete-to-select-table-expected.png:
- platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.checksum:
- platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.png:
- platform/chromium-win/editing/deleting/delete-ws-fixup-001-expected.checksum:
- platform/chromium-win/editing/deleting/delete-ws-fixup-001-expected.png:
- platform/chromium-win/editing/deleting/delete-ws-fixup-002-expected.checksum:
- platform/chromium-win/editing/deleting/delete-ws-fixup-002-expected.png:
- platform/chromium-win/editing/deleting/smart-delete-002-expected.checksum:
- platform/chromium-win/editing/deleting/smart-delete-002-expected.png:
- platform/chromium-win/editing/deleting/smart-delete-003-expected.checksum:
- platform/chromium-win/editing/deleting/smart-delete-003-expected.png:
- platform/chromium-win/editing/deleting/smart-delete-004-expected.checksum:
- platform/chromium-win/editing/deleting/smart-delete-004-expected.png:
- platform/chromium-win/editing/execCommand/5569741-expected.checksum:
- platform/chromium-win/editing/execCommand/5569741-expected.png:
- platform/chromium-win/editing/execCommand/insert-list-and-stitch-expected.checksum:
- platform/chromium-win/editing/execCommand/insert-list-and-stitch-expected.png:
- platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.checksum:
- platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.png:
- platform/chromium-win/editing/execCommand/outdent-selection-expected.checksum:
- platform/chromium-win/editing/execCommand/outdent-selection-expected.png:
- platform/chromium-win/editing/inserting/5418891-expected.checksum:
- platform/chromium-win/editing/inserting/5418891-expected.png:
- platform/chromium-win/editing/inserting/editing-empty-divs-expected.checksum:
- platform/chromium-win/editing/inserting/editing-empty-divs-expected.png:
- platform/chromium-win/editing/inserting/insert-3907422-fix-expected.checksum:
- platform/chromium-win/editing/inserting/insert-3907422-fix-expected.png:
- platform/chromium-win/editing/inserting/insert-br-004-expected.checksum:
- platform/chromium-win/editing/inserting/insert-br-004-expected.png:
- platform/chromium-win/editing/inserting/insert-br-005-expected.checksum:
- platform/chromium-win/editing/inserting/insert-br-005-expected.png:
- platform/chromium-win/editing/inserting/insert-br-007-expected.checksum:
- platform/chromium-win/editing/inserting/insert-br-007-expected.png:
- platform/chromium-win/editing/inserting/insert-div-007-expected.checksum:
- platform/chromium-win/editing/inserting/insert-div-007-expected.png:
- platform/chromium-win/editing/inserting/insert-div-012-expected.checksum:
- platform/chromium-win/editing/inserting/insert-div-012-expected.png:
- platform/chromium-win/editing/inserting/insert-div-013-expected.checksum:
- platform/chromium-win/editing/inserting/insert-div-013-expected.png:
- platform/chromium-win/editing/inserting/insert-div-014-expected.checksum:
- platform/chromium-win/editing/inserting/insert-div-014-expected.png:
- platform/chromium-win/editing/inserting/insert-div-015-expected.checksum:
- platform/chromium-win/editing/inserting/insert-div-015-expected.png:
- platform/chromium-win/editing/inserting/insert-div-016-expected.checksum:
- platform/chromium-win/editing/inserting/insert-div-016-expected.png:
- platform/chromium-win/editing/inserting/insert-div-017-expected.checksum:
- platform/chromium-win/editing/inserting/insert-div-017-expected.png:
- platform/chromium-win/editing/inserting/insert-div-018-expected.checksum:
- platform/chromium-win/editing/inserting/insert-div-018-expected.png:
- platform/chromium-win/editing/inserting/insert-div-019-expected.checksum:
- platform/chromium-win/editing/inserting/insert-div-019-expected.png:
- platform/chromium-win/editing/inserting/insert-div-020-expected.checksum:
- platform/chromium-win/editing/inserting/insert-div-020-expected.png:
- platform/chromium-win/editing/inserting/insert-div-021-expected.checksum:
- platform/chromium-win/editing/inserting/insert-div-021-expected.png:
- platform/chromium-win/editing/inserting/insert-div-022-expected.checksum:
- platform/chromium-win/editing/inserting/insert-div-022-expected.png:
- platform/chromium-win/editing/inserting/insert-div-025-expected.checksum:
- platform/chromium-win/editing/inserting/insert-div-025-expected.png:
- platform/chromium-win/editing/inserting/insert-div-027-expected.checksum:
- platform/chromium-win/editing/inserting/insert-div-027-expected.png:
- platform/chromium-win/editing/inserting/insert-paragraph-02-expected.checksum:
- platform/chromium-win/editing/inserting/insert-paragraph-02-expected.png:
- platform/chromium-win/editing/inserting/insert-paragraph-03-expected.checksum:
- platform/chromium-win/editing/inserting/insert-paragraph-03-expected.png:
- platform/chromium-win/editing/inserting/insert-tab-002-expected.checksum:
- platform/chromium-win/editing/inserting/insert-tab-002-expected.png:
- platform/chromium-win/editing/inserting/insert-tab-003-expected.checksum:
- platform/chromium-win/editing/inserting/insert-tab-003-expected.png:
- platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.checksum:
- platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.png:
- platform/chromium-win/editing/inserting/paragraph-separator-01-expected.checksum:
- platform/chromium-win/editing/inserting/paragraph-separator-01-expected.png:
- platform/chromium-win/editing/inserting/paragraph-separator-02-expected.checksum:
- platform/chromium-win/editing/inserting/paragraph-separator-02-expected.png:
- platform/chromium-win/editing/inserting/paragraph-separator-03-expected.checksum:
- platform/chromium-win/editing/inserting/paragraph-separator-03-expected.png:
- platform/chromium-win/editing/inserting/return-key-with-selection-001-expected.checksum:
- platform/chromium-win/editing/inserting/return-key-with-selection-001-expected.png:
- platform/chromium-win/editing/inserting/return-key-with-selection-002-expected.checksum:
- platform/chromium-win/editing/inserting/return-key-with-selection-002-expected.png:
- platform/chromium-win/editing/inserting/return-key-with-selection-003-expected.checksum:
- platform/chromium-win/editing/inserting/return-key-with-selection-003-expected.png:
- platform/chromium-win/editing/inserting/typing-002-expected.checksum:
- platform/chromium-win/editing/inserting/typing-002-expected.png:
- platform/chromium-win/editing/inserting/typing-around-br-001-expected.checksum:
- platform/chromium-win/editing/inserting/typing-around-br-001-expected.png:
- platform/chromium-win/editing/pasteboard/4242293-expected.checksum:
- platform/chromium-win/editing/pasteboard/4242293-expected.png:
- platform/chromium-win/editing/pasteboard/4944770-1-expected.checksum:
- platform/chromium-win/editing/pasteboard/4944770-1-expected.png:
- platform/chromium-win/editing/pasteboard/8145-2-expected.checksum:
- platform/chromium-win/editing/pasteboard/8145-2-expected.png:
- platform/chromium-win/editing/pasteboard/cut-text-001-expected.checksum:
- platform/chromium-win/editing/pasteboard/cut-text-001-expected.png:
- platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.checksum:
- platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.png:
- platform/chromium-win/editing/pasteboard/merge-after-delete-1-expected.checksum:
- platform/chromium-win/editing/pasteboard/merge-after-delete-1-expected.png:
- platform/chromium-win/editing/pasteboard/merge-after-delete-2-expected.checksum:
- platform/chromium-win/editing/pasteboard/merge-after-delete-2-expected.png:
- platform/chromium-win/editing/pasteboard/merge-after-delete-expected.checksum:
- platform/chromium-win/editing/pasteboard/merge-after-delete-expected.png:
- platform/chromium-win/editing/pasteboard/merge-end-4-expected.checksum:
- platform/chromium-win/editing/pasteboard/merge-end-4-expected.png:
- platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.checksum:
- platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.png:
- platform/chromium-win/editing/pasteboard/merge-end-list-expected.checksum:
- platform/chromium-win/editing/pasteboard/merge-end-list-expected.png:
- platform/chromium-win/editing/pasteboard/merge-end-table-expected.checksum:
- platform/chromium-win/editing/pasteboard/merge-end-table-expected.png:
- platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.checksum:
- platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.png:
- platform/chromium-win/editing/pasteboard/paste-text-001-expected.checksum:
- platform/chromium-win/editing/pasteboard/paste-text-001-expected.png:
- platform/chromium-win/editing/pasteboard/paste-text-012-expected.checksum:
- platform/chromium-win/editing/pasteboard/paste-text-012-expected.png:
- platform/chromium-win/editing/pasteboard/paste-text-013-expected.checksum:
- platform/chromium-win/editing/pasteboard/paste-text-013-expected.png:
- platform/chromium-win/editing/pasteboard/paste-text-014-expected.checksum:
- platform/chromium-win/editing/pasteboard/paste-text-014-expected.png:
- platform/chromium-win/editing/pasteboard/paste-text-019-expected.checksum:
- platform/chromium-win/editing/pasteboard/paste-text-019-expected.png:
- platform/chromium-win/editing/pasteboard/paste-xml-expected.checksum:
- platform/chromium-win/editing/pasteboard/paste-xml-expected.png:
- platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.checksum:
- platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.png:
- platform/chromium-win/editing/selection/13804-expected.checksum:
- platform/chromium-win/editing/selection/13804-expected.png:
- platform/chromium-win/editing/selection/5234383-1-expected.checksum:
- platform/chromium-win/editing/selection/5234383-1-expected.png:
- platform/chromium-win/editing/selection/5234383-2-expected.checksum:
- platform/chromium-win/editing/selection/5234383-2-expected.png:
- platform/chromium-win/editing/selection/extend-by-word-001-expected.checksum:
- platform/chromium-win/editing/selection/extend-by-word-001-expected.png:
- platform/chromium-win/editing/selection/move-backwords-by-word-001-expected.checksum:
- platform/chromium-win/editing/selection/move-backwords-by-word-001-expected.png:
- platform/chromium-win/editing/selection/move-by-character-001-expected.checksum:
- platform/chromium-win/editing/selection/move-by-character-001-expected.png:
- platform/chromium-win/editing/selection/move-by-line-001-expected.checksum:
- platform/chromium-win/editing/selection/move-by-line-001-expected.png:
- platform/chromium-win/editing/selection/move-by-word-001-expected.checksum:
- platform/chromium-win/editing/selection/move-by-word-001-expected.png:
- platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.checksum:
- platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.png:
- platform/chromium-win/editing/selection/unrendered-002-expected.checksum:
- platform/chromium-win/editing/selection/unrendered-002-expected.png:
- platform/chromium-win/editing/spelling/spelling-expected.checksum:
- platform/chromium-win/editing/spelling/spelling-expected.png:
- platform/chromium-win/editing/style/5046875-2-expected.checksum:
- platform/chromium-win/editing/style/5046875-2-expected.png:
- platform/chromium-win/editing/style/block-styles-007-expected.checksum:
- platform/chromium-win/editing/style/block-styles-007-expected.png:
- platform/chromium-win/editing/style/create-block-for-style-002-expected.checksum:
- platform/chromium-win/editing/style/create-block-for-style-002-expected.png:
- platform/chromium-win/editing/style/create-block-for-style-003-expected.checksum:
- platform/chromium-win/editing/style/create-block-for-style-003-expected.png:
- platform/chromium-win/editing/style/create-block-for-style-004-expected.checksum:
- platform/chromium-win/editing/style/create-block-for-style-004-expected.png:
- platform/chromium-win/editing/style/create-block-for-style-006-expected.checksum:
- platform/chromium-win/editing/style/create-block-for-style-006-expected.png:
- platform/chromium-win/editing/style/create-block-for-style-008-expected.checksum:
- platform/chromium-win/editing/style/create-block-for-style-008-expected.png:
- platform/chromium-win/editing/style/create-block-for-style-009-expected.checksum:
- platform/chromium-win/editing/style/create-block-for-style-009-expected.png:
- platform/chromium-win/editing/style/create-block-for-style-011-expected.checksum:
- platform/chromium-win/editing/style/create-block-for-style-011-expected.png:
- platform/chromium-win/editing/style/create-block-for-style-012-expected.checksum:
- platform/chromium-win/editing/style/create-block-for-style-012-expected.png:
- platform/chromium-win/editing/style/create-block-for-style-013-expected.checksum:
- platform/chromium-win/editing/style/create-block-for-style-013-expected.png:
- platform/chromium-win/fast/dom/blur-contenteditable-expected.checksum:
- platform/chromium-win/fast/dom/blur-contenteditable-expected.png:
- 10:06 PM Changeset in webkit [74844] by
-
- 2 edits in trunk/Tools
2010-12-31 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
[DRT/Chromium] Enable mock spell checker on non-OSX
https://bugs.webkit.org/show_bug.cgi?id=51401
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::spellCheck):
- 6:38 PM Changeset in webkit [74843] by
-
- 2 edits in trunk/WebCore
2010-12-31 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
fast/loader/about-blank-hash-change.html fails on Chromium
https://bugs.webkit.org/show_bug.cgi?id=51788
I'm unable to reproduce the failure locally, so this patch is slightly
speculative. We need to be slighly more careful how we compare the
fragment identifiers for Chromium because Chromium uses a URL parser
that is more agressive about canonicalization.
- page/Location.cpp: (WebCore::Location::setHash):
- 6:17 PM Changeset in webkit [74842] by
-
- 3 edits in trunk/WebCore
2010-12-31 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Use GLib/GIO API for FileSystemGtk implementation
https://bugs.webkit.org/show_bug.cgi?id=51617
Complete implementation of FileSystem platform code for GLib. This
converts remaining API points using POSIX calls to platform-independent
GLib calls and fixes other compilation errors.
No new tests. This code will be tested when an implementation
of beginDragWithFiles is complete.
(WebCore::JSDirectoryEntry::getFile):
(WebCore::JSDirectoryEntry::getDirectory):
- platform/FileSystem.h: Added forward declarations for GLib types to avoid GLib includes and changed the PlatformFileHandle to be a GIOStream.
- platform/gtk/FileSystemGtk.cpp: (WebCore::openTemporaryFile): Reimplement using only GLib calls. (WebCore::openFile): Ditto. (WebCore::closeFile): Ditto. (WebCore::seekFile): Added implementation. (WebCore::writeToFile): Reimplement using only GLib calls. (WebCore::readFromFile): Ditto.
- 4:58 PM Changeset in webkit [74841] by
-
- 12 edits in trunk/WebCore
2010-12-31 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Some renaming and refactoring of form element code
https://bugs.webkit.org/show_bug.cgi?id=51784
- bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::JSHTMLSelectElement::remove): Call new overload of remove for option elements instead of putting the logic in the binding.
- html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::HTMLButtonElement): Updated for name changes. (WebCore::HTMLButtonElement::defaultEventHandler): Renamed argument to "event" instead of "evt". Also updated for name changes. (WebCore::HTMLButtonElement::isActivatedSubmit): Ditto. (WebCore::HTMLButtonElement::setActivatedSubmit): Ditto. (WebCore::HTMLButtonElement::appendFormData): Ditto.
- html/HTMLButtonElement.h: Renamed m_activeSubmit to m_isActivatedSubmit to match the getter function name. The name still doesn't seem great.
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): Updated for name changes. (WebCore::HTMLFormElement::~HTMLFormElement): Use autoComplete function instead of m_autocomplete data member. (WebCore::HTMLFormElement::rendererIsNeeded): Use m_wasDemoted data member instead of otherwise-unused isDemoted function. (WebCore::HTMLFormElement::submitImplicitly): Updated for name changes. (WebCore::HTMLFormElement::validateInteractively): Removed code to clear m_insubmit. This is now handled by the caller, prepareForSubmission. (WebCore::HTMLFormElement::prepareForSubmission): Renamed. Updated for name changes. Moved code to clear m_isSubmittingOrPreparingForSubmission here from validateInteractively. Removed unneeded check of m_doingsubmit boolean before setting it. (WebCore::HTMLFormElement::submit): Factored this function into two. One for JavaScript and one for non-JavaScript. Neither function needs a frame argument, because the question being asked, anyPageIsProcessingUserGesture, is a question asked of an entire page group, not a specific frame or page, so it's not important which is the active frame. (WebCore::HTMLFormElement::submitFromJavaScript): Ditto. (WebCore::HTMLFormElement::reset): Updated for name changes. (WebCore::HTMLFormElement::parseMappedAttribute): Removed code to parse acceptAttr and got rid of code to set m_autocomplete. (WebCore::HTMLFormElement::elementForAlias): Changed return type to a raw pointer. (WebCore::HTMLFormElement::getNamedElements): Updated to use raw pointer and the vector find function. Added a FIXME about the comment. (WebCore::HTMLFormElement::documentDidBecomeActive): Use autoComplete function instead of m_autocomplete data member. (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Ditto. (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Ditto. (WebCore::HTMLFormElement::autoComplete): Ditto.
- html/HTMLFormElement.h: Added a FIXME about renaming the autoComplete function. Renamed prepareSubmit to prepareForSubmission. Got rid of the frame argument from the submit function and added a new submitFromJavaScript variant. Removed the unneeded isDemoted function. Changed the return type of elementForAlias to a raw pointer. Removed m_autocomplete. Renamed m_insubmit to m_isSubmittingOrPreparingForSubmission, m_doingsubmit to m_shouldSubmit, m_inreset to m_inResetFunction, m_malformed to m_wasMalformed, m_demoted to m_wasDemoted. Use plain bool instead of bitfields.
- html/HTMLFormElement.idl: Use the function named submitFromJavaScript instead of using CallWith=DynamicFrame because we don't need to know what frame is calling. If we did, it's not clear that the "dynamic" frame would be the right one anyway.
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::remove): Added an overload that takes an option element, since the JavaScript binding supports this.
- html/HTMLSelectElement.h: Ditto.
- html/ImageInputType.cpp: (WebCore::ImageInputType::handleDOMActivateEvent): Updated for name changes.
- html/ImageInputType.h: Ditto.
- html/SubmitInputType.cpp: (WebCore::SubmitInputType::handleDOMActivateEvent): Ditto.
- 4:48 PM Changeset in webkit [74840] by
-
- 2 edits1 delete in trunk/LayoutTests
The correct temporary fix for media/video-element-other-namespace-crash.html timing out on
the Windows 7 Release Test bots is to add it to the Windows skipped list.
Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51787
- platform/win/Skipped:
- platform/win/media/video-element-other-namespace-crash-expected.txt: Removed.
- 4:36 PM Changeset in webkit [74839] by
-
- 2 edits in trunk/WebCore
2010-12-31 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Pass style for <area> instead of associated <img> when querying whether
the theme draws the focus ring for an <area>
https://bugs.webkit.org/show_bug.cgi?id=51632
Fixes an issue where the style for the associated <img> of an <area>
was passed when considering whether the theme should draw a focus ring
for the <area>. Instead, we should pass the theme the style for the <area>.
It's not possible to test this at this time since there are no themes
that override focus ring drawing for <area>s.
- rendering/RenderImage.cpp: (WebCore::RenderImage::paintFocusRing): Moved call to RenderTheme::supportsFocusRing() such that it's called with respect to the focused <area>.
- 2:46 PM Changeset in webkit [74838] by
-
- 2 edits in trunk/WebKit
2010-12-31 Adam Barth <abarth@webkit.org>
Update SVN ignore property to hide two more external dependencies.
- chromium: Modified property svn:ignore.
- 2:10 PM Changeset in webkit [74837] by
-
- 1 edit1 add in trunk/LayoutTests
Add Windows-specific (failing) expected results for
media/video-element-other-namespace-crash.html in order to get the Windows 7 Release test bot green again.
Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51787
- platform/win/media/video-element-other-namespace-crash-expected.txt: Added.
- 1:45 PM Changeset in webkit [74836] by
-
- 1 edit2 adds in trunk/LayoutTests
Add Windows-specific (failing) expected results for
svg/dom/length-list-parser.html in order to get the Windows 7 Release test bot green again.
Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51786
- platform/win/svg/dom: Added.
- platform/win/svg/dom/length-list-parser-expected.txt: Added.
- 12:36 PM Changeset in webkit [74835] by
-
- 1 edit1 delete in trunk/LayoutTests
2010-12-31 Adam Barth <abarth@webkit.org>
Remove custom Chromium expectation for invalid-protocol. Now that we
share more code with JavaScriptCore, we throw exactly the same
exception and therefore can share results.
- platform/chromium/fast/dom/Window/invalid-protocol-expected.txt: Removed.
- 12:12 PM Changeset in webkit [74834] by
-
- 2 edits in trunk/WebCore
- WebCore.xcodeproj/project.pbxproj: Added back the language.
Developers should be using Xcode 3.2.5 or newer.
- 11:56 AM Changeset in webkit [74833] by
-
- 8 edits in trunk/WebCore
2010-12-31 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move V8 to WebCore Location implementation
https://bugs.webkit.org/show_bug.cgi?id=51768
- bindings/generic/BindingFrame.h:
- bindings/generic/BindingLocation.h:
- bindings/v8/V8Binding.h:
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::setLocation):
- bindings/v8/V8Utilities.cpp:
- bindings/v8/V8Utilities.h:
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::hashAccessorSetter): (WebCore::V8Location::hostAccessorSetter): (WebCore::V8Location::hostnameAccessorSetter): (WebCore::V8Location::hrefAccessorSetter): (WebCore::V8Location::pathnameAccessorSetter): (WebCore::V8Location::portAccessorSetter): (WebCore::V8Location::protocolAccessorSetter): (WebCore::V8Location::searchAccessorSetter): (WebCore::V8Location::reloadCallback): (WebCore::V8Location::replaceCallback): (WebCore::V8Location::assignCallback):
- 9:58 AM Changeset in webkit [74832] by
-
- 2 edits in trunk/WebCore
2010-12-31 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Eric Seidel.
Make retrieving extraMediaControlsStyleSheet be page dependent.
https://bugs.webkit.org/show_bug.cgi?id=51752
Use themeForPage to retrieve extraMediaControlsStyleSheet for media
controls.
No new tests because no platform-specific theme implementation uses
the passed page pointer yet.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement):
- 8:11 AM Changeset in webkit [74831] by
-
- 1 edit1 delete in trunk/Tools
2010-12-31 Adam Barth <abarth@webkit.org>
Reviewed by Ariya Hidayat.
Remove Tools/Scripts/wkstyle
https://bugs.webkit.org/show_bug.cgi?id=51774
This script appears to not have been touched in a while and seems to
have been replaced by check-webkit-style.
- Scripts/wkstyle: Removed.
- 5:02 AM Changeset in webkit [74830] by
-
- 2 edits in trunk/WebCore
2010-12-31 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] WebInspector.ResourcesPanel.prototype.canShowSourceLine() broken.
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLine):
- 4:43 AM Changeset in webkit [74829] by
-
- 2 edits in trunk/JavaScriptCore
2010-12-31 Patrick Gansterer <Patrick Gansterer>
Reviewed by Darin Adler.
Add a fast case for ASCII strings in HashAndUTF8CharactersTranslator::equal
https://bugs.webkit.org/show_bug.cgi?id=50517
This change shows about 2% performance win on the xml-parser benchmark.
- wtf/text/AtomicString.cpp: (WTF::HashAndUTF8CharactersTranslator::equal):
- 3:59 AM Changeset in webkit [74828] by
-
- 3 edits in trunk/WebCore
2010-12-31 Patrick Gansterer <Patrick Gansterer>
Unreviewed build fix after r74800.
- bindings/js/JSDOMWindowCustom.cpp: Add missing header.
- bindings/js/JSLocationCustom.cpp: Ditto.
- 3:47 AM Changeset in webkit [74827] by
-
- 2 edits in trunk/Tools
2010-12-31 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Coding style fix.
- DumpRenderTree/chromium/TestShell.h:
- 3:41 AM Changeset in webkit [74826] by
-
- 4 edits in trunk/Tools
2010-12-31 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
It was a problem with Chromium DRT. DevToolsAgent object instance was
attached not only to the inspected page but to the DevTools window too.
As result all the inspector files were interpreted as a content of inspected page
and were transfered to the DevTools scripts panel for debugging etc.
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::bindJSObjectsToWindow): (TestShell::createNewWindow):
- DumpRenderTree/chromium/TestShell.h:
- 2:16 AM Changeset in webkit [74825] by
-
- 2 edits1 copy1 add1 delete in trunk
Move HTML and XML parser benchmarks into PerformanceTests/Parser
https://bugs.webkit.org/show_bug.cgi?id=51772
Rubber-stamped by Eric Seidel.
Actually move the directory.
- PerformanceTests/Parser: Copied from WebCore/benchmarks/parser.
PerformanceTests/Parser:
Add a ChangeLog for tracking changes to the Parser PerformanceTest.
- ChangeLog: Added.
WebCore:
Remove the benchmarks folder now that it's empty. Future benchmarks
should go in the PerformanceTests directory.
- benchmarks: Removed.
- benchmarks/parser: Removed.
- benchmarks/parser/html-parser.html: Removed.
- benchmarks/parser/resources: Removed.
- benchmarks/parser/resources/html5.html: Removed.
- benchmarks/parser/resources/runner.js: Removed.
- benchmarks/parser/xml-parser.html: Removed.
- 2:01 AM Changeset in webkit [74824] by
-
- 2 edits2 copies in trunk/WebCore
2010-12-31 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Barth.
Add XML parser benchmark
https://bugs.webkit.org/show_bug.cgi?id=51612
Move the JavaScript code of html parser into a separate file to share it with xml parser.
- benchmarks/parser/html-parser.html:
- benchmarks/parser/resources/runner.js: Copied from WebCore/benchmarks/parser/html-parser.html. (runFunction): (run): (start):
- benchmarks/parser/xml-parser.html: Copied from WebCore/benchmarks/parser/html-parser.html.
- 1:51 AM Changeset in webkit [74823] by
-
- 9 edits1 move in trunk
Move PageLoadTests to PerformanceTests/PageLoad
https://bugs.webkit.org/show_bug.cgi?id=51771
Rubber-stamped by Eric Seidel.
Actually move the directory.
- PageLoadTests: Removed.
- PageLoadTests/svg: Removed.
- PageLoadTests/svg/LICENSES: Removed.
- PageLoadTests/svg/files: Removed.
- PageLoadTests/svg/files/33041-Samurai.svg: Removed.
- PageLoadTests/svg/files/42450-under the see.svg: Removed.
- PageLoadTests/svg/files/42470-flower_from_my_garden_v2.svg: Removed.
- PageLoadTests/svg/files/44057-drops on a blade.svg: Removed.
- PageLoadTests/svg/files/Harvey_Rayner.svg: Removed.
- PageLoadTests/svg/files/az-lizard_benji_park_01.svg: Removed.
- PageLoadTests/svg/files/bamboo_01.svg: Removed.
- PageLoadTests/svg/files/cacuts_01.svg: Removed.
- PageLoadTests/svg/files/cowboy.svg: Removed.
- PageLoadTests/svg/files/crawfish2_ganson.svg: Removed.
- PageLoadTests/svg/files/deb9frac1.svg: Removed.
- PageLoadTests/svg/files/food_leif_lodahl_01.svg: Removed.
- PageLoadTests/svg/files/france.svg: Removed.
- PageLoadTests/svg/files/francobollo_gnome_ezechi_02.svg: Removed.
- PageLoadTests/svg/files/gearflowers.svg: Removed.
- PageLoadTests/svg/files/hereGear4.svg: Removed.
- PageLoadTests/svg/files/mtsthelens.svg: Removed.
- PageLoadTests/svg/files/mtsthelens0.jpg: Removed.
- PageLoadTests/svg/files/world-iso.svg: Removed.
- PageLoadTests/svg/files/worldcup.svg: Removed.
- PageLoadTests/svg/svg.pltsuite: Removed.
- PerformanceTests/PageLoad: Copied from PageLoadTests.
- Sources/cmake/WebKitPackaging.cmake:
PerformanceTests/PageLoad:
Update URLs to point to the new directory name.
- svg/svg.pltsuite:
Tools:
Update references to PageLoadTests to point to the new location.
- Scripts/run-pageloadtest:
- Scripts/webkitpy/common/config/build.py:
Websites/bugs.webkit.org:
Update list of top-level open-source directories.
- PrettyPatch/PrettyPatch.rb:
- 1:28 AM Changeset in webkit [74822] by
-
- 7 edits1 move1 add in trunk
Move SunSpider into PerformanceTests
https://bugs.webkit.org/show_bug.cgi?id=51769
Rubber-stamped by Eric Seidel.
Actually move the directory.
- PerformanceTests: Added.
- PerformanceTests/SunSpider: Copied from SunSpider.
- Sources/cmake/WebKitPackaging.cmake:
- SunSpider: Removed.
- SunSpider/SunSpider.make: Removed.
- SunSpider/TODO: Removed.
- SunSpider/UNCOVERED: Removed.
- SunSpider/hosted: Removed.
- SunSpider/hosted/json2.js: Removed.
- SunSpider/hosted/sunspider.css: Removed.
- SunSpider/hosted/sunspider.html: Removed.
- SunSpider/hosted/versions.html: Removed.
- SunSpider/make-hosted: Removed.
- SunSpider/resources: Removed.
- SunSpider/resources/TEMPLATE.html: Removed.
- SunSpider/resources/driver-TEMPLATE.html: Removed.
- SunSpider/resources/results-TEMPLATE.html: Removed.
- SunSpider/resources/sunspider-analyze-results.js: Removed.
- SunSpider/resources/sunspider-compare-results.js: Removed.
- SunSpider/resources/sunspider-standalone-compare.js: Removed.
- SunSpider/resources/sunspider-standalone-driver.js: Removed.
- SunSpider/sunspider: Removed.
- SunSpider/sunspider-compare-results: Removed.
- SunSpider/tests: Removed.
- SunSpider/tests/parse-only: Removed.
- SunSpider/tests/parse-only/LIST: Removed.
- SunSpider/tests/parse-only/concat-jquery-mootools-prototype.js: Removed.
- SunSpider/tests/parse-only/jquery-1.3.2.js: Removed.
- SunSpider/tests/parse-only/mootools-1.2.2-core-nc.js: Removed.
- SunSpider/tests/parse-only/prototype-1.6.0.3.js: Removed.
- SunSpider/tests/sunspider-0.9: Removed.
- SunSpider/tests/sunspider-0.9.1: Removed.
- SunSpider/tests/sunspider-0.9.1/3d-cube.js: Removed.
- SunSpider/tests/sunspider-0.9.1/3d-morph.js: Removed.
- SunSpider/tests/sunspider-0.9.1/3d-raytrace.js: Removed.
- SunSpider/tests/sunspider-0.9.1/LIST: Removed.
- SunSpider/tests/sunspider-0.9.1/access-binary-trees.js: Removed.
- SunSpider/tests/sunspider-0.9.1/access-fannkuch.js: Removed.
- SunSpider/tests/sunspider-0.9.1/access-nbody.js: Removed.
- SunSpider/tests/sunspider-0.9.1/access-nsieve.js: Removed.
- SunSpider/tests/sunspider-0.9.1/bitops-3bit-bits-in-byte.js: Removed.
- SunSpider/tests/sunspider-0.9.1/bitops-bits-in-byte.js: Removed.
- SunSpider/tests/sunspider-0.9.1/bitops-bitwise-and.js: Removed.
- SunSpider/tests/sunspider-0.9.1/bitops-nsieve-bits.js: Removed.
- SunSpider/tests/sunspider-0.9.1/controlflow-recursive.js: Removed.
- SunSpider/tests/sunspider-0.9.1/crypto-aes.js: Removed.
- SunSpider/tests/sunspider-0.9.1/crypto-md5.js: Removed.
- SunSpider/tests/sunspider-0.9.1/crypto-sha1.js: Removed.
- SunSpider/tests/sunspider-0.9.1/date-format-tofte.js: Removed.
- SunSpider/tests/sunspider-0.9.1/date-format-xparb.js: Removed.
- SunSpider/tests/sunspider-0.9.1/math-cordic.js: Removed.
- SunSpider/tests/sunspider-0.9.1/math-partial-sums.js: Removed.
- SunSpider/tests/sunspider-0.9.1/math-spectral-norm.js: Removed.
- SunSpider/tests/sunspider-0.9.1/regexp-dna.js: Removed.
- SunSpider/tests/sunspider-0.9.1/string-base64.js: Removed.
- SunSpider/tests/sunspider-0.9.1/string-fasta.js: Removed.
- SunSpider/tests/sunspider-0.9.1/string-tagcloud.js: Removed.
- SunSpider/tests/sunspider-0.9.1/string-unpack-code.js: Removed.
- SunSpider/tests/sunspider-0.9.1/string-validate-input.js: Removed.
- SunSpider/tests/sunspider-0.9/3d-cube.js: Removed.
- SunSpider/tests/sunspider-0.9/3d-morph.js: Removed.
- SunSpider/tests/sunspider-0.9/3d-raytrace.js: Removed.
- SunSpider/tests/sunspider-0.9/LIST: Removed.
- SunSpider/tests/sunspider-0.9/access-binary-trees.js: Removed.
- SunSpider/tests/sunspider-0.9/access-fannkuch.js: Removed.
- SunSpider/tests/sunspider-0.9/access-nbody.js: Removed.
- SunSpider/tests/sunspider-0.9/access-nsieve.js: Removed.
- SunSpider/tests/sunspider-0.9/bitops-3bit-bits-in-byte.js: Removed.
- SunSpider/tests/sunspider-0.9/bitops-bits-in-byte.js: Removed.
- SunSpider/tests/sunspider-0.9/bitops-bitwise-and.js: Removed.
- SunSpider/tests/sunspider-0.9/bitops-nsieve-bits.js: Removed.
- SunSpider/tests/sunspider-0.9/controlflow-recursive.js: Removed.
- SunSpider/tests/sunspider-0.9/crypto-aes.js: Removed.
- SunSpider/tests/sunspider-0.9/crypto-md5.js: Removed.
- SunSpider/tests/sunspider-0.9/crypto-sha1.js: Removed.
- SunSpider/tests/sunspider-0.9/date-format-tofte.js: Removed.
- SunSpider/tests/sunspider-0.9/date-format-xparb.js: Removed.
- SunSpider/tests/sunspider-0.9/math-cordic.js: Removed.
- SunSpider/tests/sunspider-0.9/math-partial-sums.js: Removed.
- SunSpider/tests/sunspider-0.9/math-spectral-norm.js: Removed.
- SunSpider/tests/sunspider-0.9/regexp-dna.js: Removed.
- SunSpider/tests/sunspider-0.9/string-base64.js: Removed.
- SunSpider/tests/sunspider-0.9/string-fasta.js: Removed.
- SunSpider/tests/sunspider-0.9/string-tagcloud.js: Removed.
- SunSpider/tests/sunspider-0.9/string-unpack-code.js: Removed.
- SunSpider/tests/sunspider-0.9/string-validate-input.js: Removed.
- SunSpider/tests/ubench: Removed.
- SunSpider/tests/ubench/LIST: Removed.
- SunSpider/tests/ubench/function-closure.js: Removed.
- SunSpider/tests/ubench/function-correct-args.js: Removed.
- SunSpider/tests/ubench/function-empty.js: Removed.
- SunSpider/tests/ubench/function-excess-args.js: Removed.
- SunSpider/tests/ubench/function-missing-args.js: Removed.
- SunSpider/tests/ubench/function-sum.js: Removed.
- SunSpider/tests/ubench/loop-empty-resolve.js: Removed.
- SunSpider/tests/ubench/loop-empty.js: Removed.
- SunSpider/tests/ubench/loop-sum.js: Removed.
- SunSpider/tests/v8-v4: Removed.
- SunSpider/tests/v8-v4/LIST: Removed.
- SunSpider/tests/v8-v4/v8-crypto.js: Removed.
- SunSpider/tests/v8-v4/v8-deltablue.js: Removed.
- SunSpider/tests/v8-v4/v8-earley-boyer.js: Removed.
- SunSpider/tests/v8-v4/v8-raytrace.js: Removed.
- SunSpider/tests/v8-v4/v8-regexp.js: Removed.
- SunSpider/tests/v8-v4/v8-richards.js: Removed.
- SunSpider/tests/v8-v4/v8-splay.js: Removed.
- SunSpider/tests/v8-v5: Removed.
- SunSpider/tests/v8-v5/LIST: Removed.
- SunSpider/tests/v8-v5/v8-crypto.js: Removed.
- SunSpider/tests/v8-v5/v8-deltablue.js: Removed.
- SunSpider/tests/v8-v5/v8-earley-boyer.js: Removed.
- SunSpider/tests/v8-v5/v8-raytrace.js: Removed.
- SunSpider/tests/v8-v5/v8-regexp.js: Removed.
- SunSpider/tests/v8-v5/v8-richards.js: Removed.
- SunSpider/tests/v8-v5/v8-splay.js: Removed.
- SunSpider/tests/v8-v6: Removed.
- SunSpider/tests/v8-v6/LIST: Removed.
- SunSpider/tests/v8-v6/v8-crypto.js: Removed.
- SunSpider/tests/v8-v6/v8-deltablue.js: Removed.
- SunSpider/tests/v8-v6/v8-earley-boyer.js: Removed.
- SunSpider/tests/v8-v6/v8-raytrace.js: Removed.
- SunSpider/tests/v8-v6/v8-regexp.js: Removed.
- SunSpider/tests/v8-v6/v8-richards.js: Removed.
- SunSpider/tests/v8-v6/v8-splay.js: Removed.
- SunSpider/xcopy.excludes: Removed.
Tools:
Update these scripts to point to the new location.
- Scripts/run-sunspider:
- Scripts/sunspider-compare-results:
Websites/bugs.webkit.org:
Update list of top-level open-source directories.
- PrettyPatch/PrettyPatch.rb:
