Timeline



Jan 26, 2011:

11:42 PM Changeset in webkit [76766] by Csaba Osztrogonác
  • 17 edits
    2 adds in trunk/LayoutTests

Unreviewed.

[Qt] Update test expectations after r76726.

  • platform/qt/fast/lists/002-vertical-expected.checksum:
  • platform/qt/fast/lists/002-vertical-expected.png:
  • platform/qt/fast/lists/002-vertical-expected.txt:
  • platform/qt/fast/lists/003-vertical-expected.checksum:
  • platform/qt/fast/lists/003-vertical-expected.png:
  • platform/qt/fast/lists/003-vertical-expected.txt:
  • platform/qt/fast/overflow/overflow-rtl-vertical-expected.checksum:
  • platform/qt/fast/overflow/overflow-rtl-vertical-expected.png:
  • platform/qt/fast/overflow/overflow-rtl-vertical-expected.txt:
  • platform/qt/fast/table/028-vertical-expected.checksum:
  • platform/qt/fast/table/028-vertical-expected.png:
  • platform/qt/fast/table/028-vertical-expected.txt:
  • platform/qt/fast/table/border-collapsing/003-vertical-expected.checksum:
  • platform/qt/fast/table/border-collapsing/003-vertical-expected.png:
  • platform/qt/fast/table/border-collapsing/003-vertical-expected.txt:
  • platform/qt/fast/table/height-percent-test-vertical-expected.txt:
11:14 PM Changeset in webkit [76765] by yuzo@google.com
  • 84 edits
    9 adds in trunk/LayoutTests

2011-01-26 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

Update test expectations for r76743

  • platform/chromium-linux/css1/box_properties/clear_float-expected.checksum:
  • platform/chromium-linux/css1/box_properties/clear_float-expected.png:
  • platform/chromium-linux/css1/box_properties/float_elements_in_series-expected.checksum:
  • platform/chromium-linux/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.checksum:
  • platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-linux/fast/multicol/shadow-breaking-expected.checksum:
  • platform/chromium-linux/fast/multicol/shadow-breaking-expected.png: Added.
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-1-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-10-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-2-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-3-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-4-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-5-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-6-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-7-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-8-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/chromium-mac/css1/box_properties/clear_float-expected.checksum: Added.
  • platform/chromium-mac/css1/box_properties/clear_float-expected.png: Added.
  • platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.checksum: Added.
  • platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.png: Added.
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
  • platform/chromium-mac/fast/multicol/shadow-breaking-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/shadow-breaking-expected.png: Added.
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/css1/box_properties/clear_float-expected.checksum:
  • platform/chromium-win/css1/box_properties/clear_float-expected.png:
  • platform/chromium-win/css1/box_properties/float_elements_in_series-expected.checksum:
  • platform/chromium-win/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-win/css1/box_properties/float_on_text_elements-expected.checksum:
  • platform/chromium-win/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.checksum:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.png:
10:41 PM Changeset in webkit [76764] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Don't create the Direct3D device before it's first needed

We only need the device once we decide to render. There's no point in creating it before
then.

Reviewed by Sam Weinig.

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::setWindow): Removed the call to createRenderer() from here.
We already have code to create it when we first try to draw.
(WebCore::CACFLayerTreeHost::createRenderer): Flush the context after we set our layer's
bounds so that the bounds will take effect the next time we render (which could be just
after this function returns).

10:40 PM Changeset in webkit [76763] by Adam Roben
  • 3 edits in trunk/Source/WebCore

Add assertions that CACFLayerTreeHost gains and loses an HWND only once

CACFLayerTreeHost doesn't support any other use pattern.

Reviewed by Sam Weinig.

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::CACFLayerTreeHost): Initialize new member.
(WebCore::CACFLayerTreeHost::setWindow): Assert that we transition from not having a window,
to having a window, to not having a window just once over the lifetime of this object.

  • platform/graphics/ca/win/CACFLayerTreeHost.h: Added m_state.
10:40 PM Changeset in webkit [76762] by Adam Roben
  • 3 edits in trunk/Source/WebCore

Notify layers that their animations have started when we flush the context, not when we render

r76372 separated context flushing from rendering, but this bit of code got left behind.

Reviewed by Sam Weinig.

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::render): Moved code to notify the layers from here to
notifyAnimationsStarted.
(WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Added a call to
notifyAnimationsStarted after we flush the context.
(WebCore::CACFLayerTreeHost::notifyAnimationsStarted): Added. Code came from render. Changed
to call PlatformCALayer::animationStarted rather than calling through to the client
directly.

  • platform/graphics/ca/win/CACFLayerTreeHost.h: Added notifyAniamtionsStarted.
10:39 PM Changeset in webkit [76761] by Adam Roben
  • 3 edits in trunk/Source/WebCore

Small cleanup in MediaPlayerPrivateFullscreenWindow

Reviewed by Sam Weinig.

  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:

(WebCore::MediaPlayerPrivateFullscreenWindow::~MediaPlayerPrivateFullscreenWindow): Moved
code here from close(), since this was the only place that called it after the following
change to createWindow.
(WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): Replaced code that handled the
case where we had already created the window with an assertion that we have not already done
so. Our single caller (FullscreenVideoController) did not require this behavior.

  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h: Removed layerView.
10:31 PM Changeset in webkit [76760] by mitz@apple.com
  • 4 edits in trunk/LayoutTests

Updated results for the html.css changes in r76726. The old results were prepared before
r76726.

  • platform/mac/fast/text/justify-ideograph-vertical-expected.checksum:
  • platform/mac/fast/text/justify-ideograph-vertical-expected.png:
  • platform/mac/fast/text/justify-ideograph-vertical-expected.txt:
10:30 PM Changeset in webkit [76759] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-01-26 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

fast/text/justify-ideograph-vertical.html crashes on LINUX.

  • platform/chromium/test_expectations.txt:
9:59 PM Changeset in webkit [76758] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-01-26 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

Mark the tests started failing at ​http://trac.webkit.org/changeset/76726 as such.

  • platform/chromium/test_expectations.txt:
9:12 PM Changeset in webkit [76757] by weinig@apple.com
  • 6 edits in trunk/Source/WebCore

Move ScrollView scroll wheel code to ScrollAnimator.

Reviewed by Adam Roben.

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent):

  • platform/ScrollAnimator.h:

Moved implementation of handleWheelEvent from ScrollView::wheelEvent.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):
Call down to the ScrollableArea.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::handleWheelEvent):
Call down to the ScrollAnimator.

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollPosition):
(WebCore::ScrollableArea::minimumScrollPosition):
(WebCore::ScrollableArea::maximumScrollPosition):
(WebCore::ScrollableArea::visibleContentRect):
(WebCore::ScrollableArea::visibleHeight):
(WebCore::ScrollableArea::visibleWidth):
Add functions needed to implement wheel event in the animator.

8:57 PM Changeset in webkit [76756] by ddkilzer@apple.com
  • 21 edits in trunk

<​http://webkit.org/b/53192> Add experimental support for HTTP pipelining in CFNetwork
<rdar://problem/8821760>

Reviewed by Antti Koivisto.

Source/WebCore:

This adds support for HTTP pipelining in CFNetwork, but does not
enable it. To enable it post-SnowLeopard, use this command:

defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES

Once enabled, it is possible to force the same load priority
(high) to be sent to CFNetwork to allow WebCore to handle the
scheduling:

defaults write BUNDLE.ID WebKitForceHTTPPipeliningPriorityHigh -bool YES

  • WebCore.exp.in: Export _wkGetHTTPPipeliningPriority and

_wkSetHTTPPipeliningPriority.

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight):
Copy the priority to preflightRequest.

  • loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::scheduleLoad): Refactored code
at the end of the method to use an early return.

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::load): Set the priority on the
ResourceRequest object based on the priority of the
CachedResourceRequest before calling
ResourceLoadScheduler::scheduleSubresourceLoad().

  • loader/icon/IconLoader.cpp:

(WebCore::IconLoader::startLoading): Create a ResourceRequest
object and set its priority to ResourceLoadPriorityLow before
passing it to ResourceLoadScheduler::scheduleSubresourceLoad().

  • platform/mac/WebCoreSystemInterface.h:

(wkGetHTTPPipeliningPriority): Added.
(wkSetHTTPPipeliningPriority): Added.

  • platform/mac/WebCoreSystemInterface.mm:

(wkGetHTTPPipeliningPriority): Added.
(wkSetHTTPPipeliningPriority): Added.

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::adopt): Set m_priority when
adopting a CrossThreadResourceRequestData.
(WebCore::ResourceRequestBase::copyData): Set m_priority when
creating a CrossThreadResourceRequestData.
(WebCore::ResourceRequestBase::priority): Added.
(WebCore::ResourceRequestBase::setPriority): Added.
(WebCore::equalIgnoringHeaderFields): Priorities must match when
comparing two ResourceRequest objects.

  • platform/network/ResourceRequestBase.h:

(WebCore::ResourceRequestBase::ResourceRequestBase): Set default
priority of new objects to ResourceLoadPriorityLow.
(WebCore::ResourceRequestBase::priority): Added declaration.
(WebCore::ResourceRequestBase::setPriority): Added declaration.
(WebCore::isHTTPPipeliningEnabled): Added.
(WebCore::shouldUseHTTPPipeliningPriority): Added.

  • platform/network/cf/ResourceRequestCFNet.cpp: Updated so that

Mac OS X and Windows share code.
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Always
set the HTTP connection count per host, but return an
'unlimited' value when using HTTP pipelining. This method used
to be defined in ResourceRequestMac.mm for Mac OS X.
(WebCore::readBooleanPreference): Added. Helper method for
reading boolean user defaults.
(WebCore::isHTTPPipeliningEnabled): Returns value of user
default key WebKitEnableHTTPPipelining, or false if not set.
(WebCore::shouldUseHTTPPipeliningPriority): Returns value of
user default key WebKitForceHTTPPipeliningPriorityHigh, or false
if not set.

  • platform/network/cf/ResourceRequestCFNet.h: Updated so that

Mac OS X and Windows share code. Fixed indentation.
(WebCore::mapHTTPPipeliningPriorityToResourceLoadPriority): Added.
(WebCore::mapResourceLoadPriorityToHTTPPipeliningPriority): Added.

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdatePlatformRequest): Update
HTTP pipelining priority on NSMutableFURLRequest object.
(WebCore::ResourceRequest::doUpdateResourceRequest): Update
m_priority from the NSURLRequest object.
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Removed.
Code is now shared with Windows in ResourceRequestCFNet.cpp.

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Added initialization for
GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Added initialization for
GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.

WebKitLibraries:

  • WebKitSystemInterface.h:

New methods added for HTTP pipelining support.

(WKGetHTTPPipeliningPriority): Added.
(WKSetHTTPPipeliningPriority): Added.

Unrelated methods added after updating the header.

(WKMakeScrollbarPainter): Added.
(WKScrollbarPainterPaint): Added.

  • libWebKitSystemInterfaceLeopard.a: Updated.
  • libWebKitSystemInterfaceSnowLeopard.a: Updated.
8:36 PM Changeset in webkit [76755] by rniwa@webkit.org
  • 1 edit
    8 adds in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed Chromium Mac rebaselines for r76726.

  • platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
  • platform/chromium-mac/fast/multicol/vertical-rl: Added.
  • platform/chromium-mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
  • platform/chromium-mac/fast/table/028-vertical-expected.checksum: Added.
  • platform/chromium-mac/fast/table/028-vertical-expected.png: Added.
  • platform/chromium-mac/fast/text/complex-text-opacity-expected.checksum: Added.
  • platform/chromium-mac/fast/text/complex-text-opacity-expected.png: Added.
8:08 PM Changeset in webkit [76754] by Beth Dakin
  • 9 edits in trunk/Source

Fix for <rdar://problem/8895140> Adopt WKScrollbar metrics
when using WKScrollbars.

Reviewed by Darin Adler.

Source/WebCore:

New WebKitSystemInterface Functionality.

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Some of the terrible static arrays are now only needed in the
old non-WK code, so they are if-def'd now.

  • platform/mac/ScrollbarThemeMac.mm:


Just patching this function in a better way than I did
before.
(WebCore::updateArrowPlacement):

Call into WK for the right values.
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):

Return false if there are no buttons.
(WebCore::ScrollbarThemeMac::hasButtons):

Return an empty IntRect if there are not buttons.
(WebCore::buttonRepaintRect):

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

8:07 PM Changeset in webkit [76753] by rniwa@webkit.org
  • 11 edits
    25 adds in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed Chromium Windows/Linux rebaselines for r76726.

  • platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/float-paginate-complex-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/float-paginate-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/unsplittable-inline-block-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-linux/fast/table/028-vertical-expected.checksum:
  • platform/chromium-linux/fast/table/028-vertical-expected.png:
  • platform/chromium-linux/fast/table/border-collapsing/003-vertical-expected.checksum:
  • platform/chromium-linux/fast/table/border-collapsing/003-vertical-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/float-paginate-complex-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/float-paginate-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/float-paginate-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt: Added.
  • platform/chromium-win/fast/table/028-vertical-expected.checksum:
  • platform/chromium-win/fast/table/028-vertical-expected.png:
  • platform/chromium-win/fast/table/028-vertical-expected.txt:
  • platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.checksum:
  • platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.txt:
8:04 PM Changeset in webkit [76752] by rniwa@webkit.org
  • 1 edit
    47 adds in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed Chromium Windows/Linux rebaselines for r76726.

  • platform/chromium-linux/fast/multicol/vertical-lr/float-paginate-complex-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/float-paginate-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/unsplittable-inline-block-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/border-padding-pagination-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/border-padding-pagination-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/column-break-with-balancing-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/column-count-with-rules-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/column-count-with-rules-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/column-rules-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/column-rules-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-paginate-complex-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-paginate-complex-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-paginate-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-paginate-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-rl: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/border-padding-pagination-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/border-padding-pagination-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/border-padding-pagination-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/column-break-with-balancing-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/column-count-with-rules-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/column-count-with-rules-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/column-count-with-rules-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/column-rules-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/column-rules-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/column-rules-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.txt: Added.
7:59 PM Changeset in webkit [76751] by rniwa@webkit.org
  • 16 edits
    32 adds
    1 delete in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed Chromium Windows/Linux rebaselines for r76726.

  • platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.checksum:
  • platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.png:
  • platform/chromium-linux/fast/lists/002-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/002-vertical-expected.png:
  • platform/chromium-linux/fast/lists/002-vertical-expected.txt: Removed.
  • platform/chromium-linux/fast/lists/003-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/003-vertical-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/border-padding-pagination-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/border-padding-pagination-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/column-break-with-balancing-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/column-count-with-rules-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/column-count-with-rules-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/column-rules-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/column-rules-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/float-multicol-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
  • platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.checksum:
  • platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.png:
  • platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.txt:
  • platform/chromium-win/fast/lists/002-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/002-vertical-expected.png:
  • platform/chromium-win/fast/lists/002-vertical-expected.txt:
  • platform/chromium-win/fast/lists/003-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/003-vertical-expected.png:
  • platform/chromium-win/fast/lists/003-vertical-expected.txt:
  • platform/chromium-win/fast/multicol/vertical-lr: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/border-padding-pagination-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/border-padding-pagination-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/border-padding-pagination-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/column-break-with-balancing-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/column-count-with-rules-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/column-count-with-rules-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/column-count-with-rules-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/column-rules-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/column-rules-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/column-rules-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.txt: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
  • platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.txt: Added.
7:13 PM Changeset in webkit [76750] by bweinstein@apple.com
  • 3 edits in trunk/LayoutTests

Rebaseline Windows fast/blockfow results after r76726.

  • platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
  • platform/win/fast/blockflow/vertical-baseline-alignment-expected.txt:
6:46 PM Changeset in webkit [76749] by Martin Robinson
  • 29 edits in trunk

2011-01-26 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Pixel dumps do not include scrollbars in output images
​https://bugs.webkit.org/show_bug.cgi?id=53216

Update expected results which should show scrollbars.

  • platform/gtk/css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum:
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-02-c-expected.png:
  • platform/gtk/css2.1/t0803-c5505-mrgn-02-c-expected.checksum:
  • platform/gtk/css2.1/t0803-c5505-mrgn-02-c-expected.png:
  • platform/gtk/css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum:
  • platform/gtk/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
  • platform/gtk/css2.1/t0905-c5525-fltclr-00-c-ag-expected.checksum:
  • platform/gtk/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png:
  • platform/gtk/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.checksum:
  • platform/gtk/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png:
  • platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/gtk/css2.1/t0905-c5526-fltclr-00-c-ag-expected.checksum:
  • platform/gtk/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png:
  • platform/gtk/css2.1/t1002-c5523-width-02-b-g-expected.checksum:
  • platform/gtk/css2.1/t1002-c5523-width-02-b-g-expected.png:
  • platform/gtk/css2.1/t1202-counters-08-b-expected.checksum:
  • platform/gtk/css2.1/t1202-counters-08-b-expected.png:
  • platform/gtk/css2.1/t1202-counters-09-b-expected.checksum:
  • platform/gtk/css2.1/t1202-counters-09-b-expected.png:
  • platform/gtk/css2.1/t140201-c535-bg-fixd-00-b-g-expected.checksum:
  • platform/gtk/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
  • platform/gtk/css2.1/t140201-c537-bgfxps-00-c-ag-expected.checksum:
  • platform/gtk/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png:
  • platform/gtk/css2.1/t1508-c527-font-07-b-expected.checksum:
  • platform/gtk/css2.1/t1508-c527-font-07-b-expected.png:

2011-01-26 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Pixel dumps do not include scrollbars in output images
​https://bugs.webkit.org/show_bug.cgi?id=53216

Show scrollbars in pixel dumps. This will fix pixel dumps for tests
that have scrollbars.

  • DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow instead of the web view itself.
6:20 PM Changeset in webkit [76748] by Martin Robinson
  • 8 edits in trunk/LayoutTests

2011-01-26 Martin Robinson <​mrobinson@igalia.com>

[GTK] Text input controls do not react properly to CSS styling
​https://bugs.webkit.org/show_bug.cgi?id=40855

Unskip tests which were previously skipped due to issue #40855.
The bug is closed now, so it's safe to rebaseline the tests and
unskip them.

  • platform/gtk/Skipped: Unskip tests.
  • platform/gtk/fast/forms/basic-selects-expected.checksum:
  • platform/gtk/fast/forms/basic-selects-expected.png:
  • platform/gtk/fast/forms/basic-selects-expected.txt:
  • platform/gtk/fast/forms/basic-textareas-quirks-expected.checksum:
  • platform/gtk/fast/forms/basic-textareas-quirks-expected.png:
  • platform/gtk/fast/forms/basic-textareas-quirks-expected.txt:
6:02 PM Changeset in webkit [76747] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-01-26 Martin Robinson <​mrobinson@igalia.com>

[GTK] media/unsupported-rtsp.html fails after timing out
​https://bugs.webkit.org/show_bug.cgi?id=53056

  • platform/gtk/Skipped: Update the skipped list to explain why this test is skipped and should remain skipped.
6:01 PM Changeset in webkit [76746] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-01-26 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Mihai Parparita.

Fix regression introduced in r76322 ... new-run-webkit-tests
was attempting to save the image diff output as a UTF-8-encoded
file.

​https://bugs.webkit.org/show_bug.cgi?id=53210

  • Scripts/webkitpy/layout_tests/port/webkit.py:
5:55 PM Changeset in webkit [76745] by weinig@apple.com
  • 21 edits
    2 adds in trunk/Source

Add events to represent the start/end of a gesture scroll
​https://bugs.webkit.org/show_bug.cgi?id=53215

Reviewed by Maciej Stachowiak.

Source/JavaScriptCore:

  • wtf/Platform.h: Add ENABLE for gesture events.

Source/WebCore:

  • WebCore.exp.in:

Add new file.

  • WebCore.xcodeproj/project.pbxproj:

Add new file.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

  • page/EventHandler.h:

Add entry point for handling gesture events.

  • platform/PlatformGestureEvent.h: Added.

(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(WebCore::PlatformGestureEvent::type):
(WebCore::PlatformGestureEvent::position):
(WebCore::PlatformGestureEvent::globalPosition):
(WebCore::PlatformGestureEvent::timestamp):
Add platform agnostic representation of a gesture event.

Source/WebKit2:

  • Scripts/webkit2/messages.py:
  • Shared/WebEvent.h:

(WebKit::WebGestureEvent::WebGestureEvent):
(WebKit::WebGestureEvent::position):
(WebKit::WebGestureEvent::globalPosition):

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent):
(WebKit::platform):

  • Shared/WebEventConversion.h:
  • Shared/WebGestureEvent.cpp: Added.

(WebKit::WebGestureEvent::WebGestureEvent):
(WebKit::WebGestureEvent::encode):
(WebKit::WebGestureEvent::decode):
(WebKit::WebGestureEvent::isGestureEventType):

  • Shared/mac/WebEventFactory.h:
  • Shared/mac/WebEventFactory.mm:

(WebKit::gestureEventTypeForEvent):
(WebKit::WebEventFactory::createWebGestureEvent):

  • UIProcess/API/mac/WKView.mm:

(-[WKView shortCircuitedEndGestureWithEvent:]):
(-[WKView beginGestureWithEvent:]):
(-[WKView viewDidMoveToWindow]):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleGestureEvent):
(WebKit::WebPageProxy::didReceiveEvent):

  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::handleGestureEvent):
(WebKit::WebPage::gestureEvent):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Pipe gesture events down to WebCore.

5:45 PM Changeset in webkit [76744] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-26 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] WebFrame::forms() should not return empty WebFormElements
​https://bugs.webkit.org/show_bug.cgi?id=53204

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::forms):
    • Should iterate by forms->length(), not the number of HTMLElements.
    • Do not increment the index for "temp" if a node is not an HTMLElement.
5:39 PM Changeset in webkit [76743] by mitz@apple.com
  • 38 edits
    12 adds in trunk

<rdar://problem/8446709> Allow inter-ideograph justification for CJK
​https://bugs.webkit.org/show_bug.cgi?id=53184

Reviewed by Dave Hyatt.

Source/WebCore:

Tests: fast/text/justify-ideograph-complex.html

fast/text/justify-ideograph-simple.html
fast/text/justify-ideograph-vertical.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal): Corrected the type of the third parameter
passed to the TextRun constructor and added the trailingExpansionBehavior parameter.

  • platform/graphics/Font.cpp:

(WebCore::Font::expansionOpportunityCount): Added. Returns the number of expansion opportunities
for text justification. On entry, isAfterExpansion says whether an expansion opportunity exists
before the first character. On return, isAfterExpansion says whether an expansion opportunity
exists after the last character.

  • platform/graphics/Font.h:
  • platform/graphics/GlyphBuffer.h:

(WebCore::GlyphBuffer::expandLastAdvance): Added.

  • platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun): Added a TrailingExpansionBehavior parameter to the constructors.
Renamed padding to expansion.
(WebCore::TextRun::expansion): Renamed padding() to this.
(WebCore::TextRun::allowsTrailingExpansion): Added this accessor.

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator): Initialize m_isAfterExpansion. Use Font::expansionOpportunityCount()
and adjust the count if it includes a trailing expansion opportunity but the run disallows trailing
expansion.
(WebCore::WidthIterator::advance): Apply expansion before and after CJK ideographs.
(WebCore::WidthIterator::advanceOneCharacter): Changed to not clear the GlyphBuffer so that advance()
can expand the last advance if it is followed by a CJK ideograph.

  • platform/graphics/WidthIterator.h: Renamed m_padding to m_expansion and m_padPerSpace

to m_expansionPerOpportunity.

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.

  • platform/graphics/chromium/FontLinux.cpp:

(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.

  • platform/graphics/efl/FontEfl.cpp:

(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.

  • platform/graphics/gtk/FontGtk.cpp:

(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.

  • platform/graphics/haiku/FontHaiku.cpp:

(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController): Initialize m_isAfterExpansion. Use
Font::expansionOpportunityCount() and adjust the count if it includes a trailing expansion
opportunity but the run disallows trailing expansion.
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Moved the definition and initialization
of hasExtraSpacing outside the loop. Apply expansion before and after CJK ideographs.

  • platform/graphics/mac/ComplexTextController.h: Renamed m_padding to m_expansion and m_padPerSpace

to m_expansionPerOpportunity.

  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.

  • platform/graphics/win/FontWin.cpp:

(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::UniscribeController): Updated for rename.

  • platform/graphics/wince/FontWinCE.cpp:

(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.

  • platform/graphics/wx/FontWx.cpp:

(WebCore::Font::canExpandAroundIdeographsInComplexText): Added.

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint): Pass a TrailingExpansionBehavior to the TextRun constructor.
(WebCore::EllipsisBox::selectionRect): Ditto.
(WebCore::EllipsisBox::paintSelection): Ditto.

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox): Renamed m_toAdd to m_expansion.
(WebCore::InlineBox::expansion): Renamed toAdd() to this.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionRect): Pass a TrailingExpansionBehavior to the TextRun constructor.
(WebCore::InlineTextBox::paint): Ditto.
(WebCore::InlineTextBox::paintSelection): Ditto.
(WebCore::InlineTextBox::paintCompositionBackground): Ditto.
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Ditto.
(WebCore::InlineTextBox::paintTextMatchMarker): Ditto.
(WebCore::InlineTextBox::computeRectForReplacementMarker): Ditto.
(WebCore::InlineTextBox::offsetForPosition): Ditto.
(WebCore::InlineTextBox::positionForOffset): Ditto.

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::setExpansion): Renamed setSpaceAdd() to this.
(WebCore::InlineTextBox::trailingExpansionBehavior): Added. Trailing expansion is allowed if this
is not the last leaf box on the line.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Keep expansion opportunity counts
in a vector instead of computing them twice. Discard the trailing expansion opportunity in the
last text box.

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject): Pass a TrailingExpansionBehavior to the TextRun constructor.
(WebCore::RenderFileUploadControl::computePreferredLogicalWidths): Ditto.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement): Ditto.
(WebCore::RenderListBox::paintItemForeground): Ditto. Also corrected the type of the second parameter.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::getAvgCharWidth): Ditto.
(WebCore::RenderTextControl::paintPlaceholder): Ditto.

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::constructTextRun): Ditto.

Source/WebKit/chromium:

  • src/WebTextRun.cpp:

(WebKit::WebTextRun::operator WebCore::TextRun): Added a TrailingExpansionBehavior parameter to the
RenderText constructor.

Source/WebKit2:

  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:

(WebKit::WebPopupMenu::setUpPlatformData): Added a TrailingExpansionBehavior parameter to the
RenderText constructor.

LayoutTests:

  • fast/text/justify-ideograph-complex.html: Added.
  • fast/text/justify-ideograph-simple.html: Added.
  • fast/text/justify-ideograph-vertical.html: Added.
  • platform/mac/fast/text/justify-ideograph-complex-expected.checksum: Added.
  • platform/mac/fast/text/justify-ideograph-complex-expected.png: Added.
  • platform/mac/fast/text/justify-ideograph-complex-expected.txt: Added.
  • platform/mac/fast/text/justify-ideograph-simple-expected.checksum: Added.
  • platform/mac/fast/text/justify-ideograph-simple-expected.png: Added.
  • platform/mac/fast/text/justify-ideograph-simple-expected.txt: Added.
  • platform/mac/fast/text/justify-ideograph-vertical-expected.checksum: Added.
  • platform/mac/fast/text/justify-ideograph-vertical-expected.png: Added.
  • platform/mac/fast/text/justify-ideograph-vertical-expected.txt: Added.
5:34 PM Changeset in webkit [76742] by mitz@apple.com
  • 5 edits
    1 add in trunk/Source/WebKit2

Methods to temporarily disable size updates to the page drawing area in WKView.
​https://bugs.webkit.org/show_bug.cgi?id=53206
Part of <rdar://problem/8818585>

Patch by Jing Jin <​jjin@apple.com> on 2011-01-26
Reviewed by Darin Adler.

  • UIProcess/API/mac/WKView.h: Added _frameSizeUpdateDisabledCount.
  • UIProcess/API/mac/WKView.mm:

(-[WKView setFrameSize:]): Only update page size if frame size updates are enabled.
(-[WKView _setDrawingAreaSize:]): Helper method to set the page's drawing area's size.
(-[WKView disableFrameSizeUpdates]): Increment _frameSizeUpdateDisabledCount
(-[WKView enableFrameSizeUpdates]): Decrement _frameSizeUpdateDisabledCount, and if the count is 0, meaning
that no one is disabling frame size updates anymore, update the drawing area's size to match the current frame.
(-[WKView frameSizeUpdatesDisabled]): Returns YES if at least one caller is disabling frame size updates.

  • UIProcess/API/mac/WKViewInternal.h: Declared -disableFrameSizeUpdates, -enableFrameSizeUpdates, and -frameSizeUpdatesDisabled.
  • UIProcess/API/mac/WKViewPrivate.h: Added.
  • WebKit2.xcodeproj/project.pbxproj: Added WKViewPrivate.h
5:32 PM Changeset in webkit [76741] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Several WKView Internal category methods are implemented in the main category.
​https://bugs.webkit.org/show_bug.cgi?id=53195

Patch by Jing Jin <​jjin@apple.com> on 2011-01-26
Rubber-stamped by Dan Bernstein.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setEventBeingResent:]): Moved into implementation of WKView (Internal).
(-[WKView _interceptKeyEvent:]): Moved into implementation of WKView (Internal).
(-[WKView _getTextInputState:selectionEnd:underlines:WebCore::]): Moved into implementation of WKView (Internal).
(-[WKView _setAccessibilityChildToken:]): Moved into implementation of WKView (Internal).

5:19 PM WikiStart edited by mihaip@chromium.org
(diff)
5:17 PM WikiStart edited by mihaip@chromium.org
(diff)
5:12 PM Changeset in webkit [76740] by Martin Robinson
  • 2 edits
    261 adds in trunk/LayoutTests

2011-01-26 Martin Robinson <​mrobinson@igalia.com>

Add the final set of CSS 2.1 GTK+ baselines.

  • platform/gtk/Skipped: Unskip the remaining CSS 2.1 tests.
  • platform/gtk/css2.1: Add the remaining baselines.
5:09 PM Changeset in webkit [76739] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/fast/text/text-letter-spacing-expected.txt

Update fast/text/text-letter-spacing.html since it progressed.

5:06 PM Changeset in webkit [76738] by Martin Robinson
  • 2 edits
    300 adds in trunk/LayoutTests

2011-01-26 Martin Robinson <​mrobinson@igalia.com>

Add the next set of GTK+ baselines for the CSS 2.1 test suite.

  • platform/gtk/Skipped: Unskip the next block of tests.
  • platform/gtk/css2.1: Added CSS 2.1 test results for GTK+.
5:03 PM CSS21Results edited by leviw@chromium.org
(diff)
4:58 PM Changeset in webkit [76737] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/fast/dom/vertical-scrollbar-in-rtl-doesnt-fire-onscroll-expected.txt

Update fast/dom test since it progressed.

4:57 PM Changeset in webkit [76736] by hyatt@apple.com
  • 28 edits in trunk/LayoutTests/platform/mac/fast/table

Update fast/table results since they progressed.

4:53 PM Changeset in webkit [76735] by hyatt@apple.com
  • 7 edits in trunk/LayoutTests/platform/mac/fast/overflow

Update fast/overflow results since they progressed.

4:51 PM Changeset in webkit [76734] by hyatt@apple.com
  • 6 edits in trunk/LayoutTests/platform/mac/fast/lists

Update fast/lists results since they progressed.

4:50 PM Changeset in webkit [76733] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Inline HTMLObjectElement::hasValidClassId().

Rubber-stamped by Darin Adler.

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::hasValidClassId):

4:49 PM Changeset in webkit [76732] by evan@chromium.org
  • 4 edits
    2 adds in trunk

2010-01-26 Evan Martin <​evan@chromium.org>

Reviewed by Tony Chang.

[chromium] crash on getBoundingClientRect in complex text
​https://bugs.webkit.org/show_bug.cgi?id=53199

Add a test that reproduces the crash and verifies the resulting values
are sane (when it didn't crash, it would get garbage values).

  • platform/chromium-linux/fast/text/international/complex-text-rectangle-expected.txt: Added.
  • platform/chromium-linux/fast/text/international/complex-text-rectangle.html: Added.

2011-01-26 Evan Martin <​evan@chromium.org>

Reviewed by Tony Chang.

[chromium] crash on getBoundingClientRect in complex text
​https://bugs.webkit.org/show_bug.cgi?id=53199

Use the correct array bound; we want the number of characters processed by
the shaper, not the longest continuous script run length.

Test: platform/chromium-linux/fast/text/international/complex-text-rectangle.html

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::nextScriptRun):
  • platform/graphics/chromium/ComplexTextControllerLinux.h: (WebCore::ComplexTextController::numCodePoints):
4:44 PM Changeset in webkit [76731] by hyatt@apple.com
  • 6 edits in trunk/LayoutTests/platform/mac/fast/blockflow

Update fast/blockflow results since they progressed.

4:39 PM Changeset in webkit [76730] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch

Versioning.

3:54 PM Changeset in webkit [76729] by mrowe@apple.com
  • 1 copy in branches/safari-533.20-branch

New branch.

3:43 PM Changeset in webkit [76728] by inferno@chromium.org
  • 8 edits
    2 adds in trunk

2011-01-26 Emil A Eklund <​eae@chromium.org>

Reviewed by Alexey Proskuryakov.

Remove cached document reference from CSSStyleSheet and XSLStyleSheet.
​https://bugs.webkit.org/show_bug.cgi?id=52084

Test: fast/dom/css-delete-doc.html

  • css/CSSMediaRule.cpp: (WebCore::CSSMediaRule::insertRule): (WebCore::CSSMediaRule::deleteRule):
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::CSSStyleSheet): (WebCore::CSSStyleSheet::document):
  • css/CSSStyleSheet.h:
  • xml/XSLStyleSheet.h: (WebCore::XSLStyleSheet::parentStyleSheet):
  • xml/XSLStyleSheetLibxslt.cpp: (WebCore::XSLStyleSheet::XSLStyleSheet): (WebCore::XSLStyleSheet::cachedResourceLoader): (WebCore::XSLStyleSheet::setParentStyleSheet): (WebCore::XSLStyleSheet::ownerDocument):
  • xml/XSLStyleSheetQt.cpp: (WebCore::XSLStyleSheet::XSLStyleSheet): (WebCore::XSLStyleSheet::cachedResourceLoader): (WebCore::XSLStyleSheet::ownerDocument):

2011-01-26 Emil A Eklund <​eae@chromium.org>

Reviewed by Alexey Proskuryakov.

Remove cached document reference from CSSStyleSheet and XSLStyleSheet.
​https://bugs.webkit.org/show_bug.cgi?id=52084

Added test for accessing a style sheet associated with a document that
has been removed.

  • fast/dom/css-delete-doc-expected.txt: Added.
  • fast/dom/css-delete-doc.html: Added.
3:26 PM Changeset in webkit [76727] by Dimitri Glazkov
  • 5 edits in trunk/Source/WebCore

2011-01-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

Reduce ref-count churn in shadowPseudoId.
​https://bugs.webkit.org/show_bug.cgi?id=53136

Refactoring, so no new tests.

  • dom/Element.h: (WebCore::Element::shadowPseudoId): Changed signature to use const AtomicString&
  • html/ValidationMessage.cpp: (WebCore::ElementWithPseudoId::shadowPseudoId): Ditto.
  • html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::shadowPseudoId): Ditto, plus moved from the header file.
  • html/shadow/SliderThumbElement.h: Ditto.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlMuteButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlVolumeSliderMuteButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlPlayButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlSeekForwardButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlSeekBackButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlRewindButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId): Ditto. (WebCore::MediaControlTimelineElement::shadowPseudoId): Ditto. (WebCore::MediaControlVolumeSliderElement::shadowPseudoId): Ditto. (WebCore::MediaControlFullscreenButtonElement::shadowPseudoId): Ditto.
  • rendering/MediaControlElements.h: Ditto.
3:10 PM Changeset in webkit [76726] by hyatt@apple.com
  • 23 edits
    104 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=46421, make multi-column layout work with vertical text.

Reviewed by Dan Bernstein.

Added new tests in fast/multicol/vertical-lr and fast/multicol/vertical-rl.

Source/WebCore:

  • css/html.css:

Update p, blockquote and h1-h6 to respect directionality so that column layout tests that use those
elements work properly.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
Fix a flipping bug with the computation of lineTopIncludingMargins where it could be incorrectly shrunk
in some cases (causing lines to all stack on top of one another).

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::calculateBoundaries):
Fix calculateBoundaries to be physical rather than logical.

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::addForcedColumnBreak):

  • rendering/LayoutState.h:

Rename childY to childLogicalOffset.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::markForPaginationRelayoutIfNeeded):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::RenderBlock::calcColumnWidth):
(WebCore::RenderBlock::desiredColumnWidth):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::flipForWritingModeIncludingColumns):
(WebCore::RenderBlock::adjustForColumns):
(WebCore::RenderBlock::adjustForBorderFit):
(WebCore::RenderBlock::nextPageLogicalTop):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::leftForFloatIncludingMargin):
(WebCore::RenderBlock::topForFloatIncludingMargin):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
Reworking of all the RenderBlock column functions to support flipping and vertical modes.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::flipForWritingModeIncludingColumns):
Patch offsetFromContainer to be aware of flipped block writing modes when dealing with column layouts.

  • rendering/RenderBox.h:

(WebCore::RenderBox::clientLogicalBottom):
Fix a bug in clientLogicalBottom where it didn't add in the right border/padding.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
Better terminology for pagination.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::offsetFromContainer):
(WebCore::RenderInline::mapLocalToContainer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintChildLayerIntoColumns):
(WebCore::RenderLayer::hitTestChildLayerColumns):
(WebCore::RenderLayer::localBoundingBox):
(WebCore::RenderLayer::boundingBox):
Patch painting in RenderLayers to be vertical-text-aware.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::mapLocalToContainer):
Add code to be flipped block-aware with columns.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):
Fix pagination to use better terminology.

  • rendering/RenderText.cpp:

(WebCore::RenderText::absoluteQuads):
(WebCore::RenderText::absoluteQuadsForRange):
Fix a bug where vertical text wasn't taken into account.

LayoutTests:

  • fast/multicol/break-properties-expected.txt:
  • fast/multicol/break-properties.html:
  • fast/multicol/float-truncation.html:
  • fast/multicol/vertical-lr: Added.
  • fast/multicol/vertical-lr/border-padding-pagination.html: Added.
  • fast/multicol/vertical-lr/break-properties-expected.txt: Added.
  • fast/multicol/vertical-lr/break-properties.html: Added.
  • fast/multicol/vertical-lr/column-break-with-balancing.html: Added.
  • fast/multicol/vertical-lr/column-count-with-rules.html: Added.
  • fast/multicol/vertical-lr/column-rules.html: Added.
  • fast/multicol/vertical-lr/float-avoidance.html: Added.
  • fast/multicol/vertical-lr/float-multicol.html: Added.
  • fast/multicol/vertical-lr/float-paginate-complex.html: Added.
  • fast/multicol/vertical-lr/float-paginate.html: Added.
  • fast/multicol/vertical-lr/float-truncation-expected.txt: Added.
  • fast/multicol/vertical-lr/float-truncation.html: Added.
  • fast/multicol/vertical-lr/gap-non-negative-expected.txt: Added.
  • fast/multicol/vertical-lr/gap-non-negative.html: Added.
  • fast/multicol/vertical-lr/image-inside-nested-blocks-with-border-expected.txt: Added.
  • fast/multicol/vertical-lr/image-inside-nested-blocks-with-border.html: Added.
  • fast/multicol/vertical-lr/nested-columns.html: Added.
  • fast/multicol/vertical-lr/resources: Added.
  • fast/multicol/vertical-lr/resources/blimp.png: Added.
  • fast/multicol/vertical-lr/unsplittable-inline-block.html: Added.
  • fast/multicol/vertical-rl: Added.
  • fast/multicol/vertical-rl/border-padding-pagination.html: Added.
  • fast/multicol/vertical-rl/break-properties-expected.txt: Added.
  • fast/multicol/vertical-rl/break-properties.html: Added.
  • fast/multicol/vertical-rl/column-break-with-balancing.html: Added.
  • fast/multicol/vertical-rl/column-count-with-rules.html: Added.
  • fast/multicol/vertical-rl/column-rules.html: Added.
  • fast/multicol/vertical-rl/float-avoidance.html: Added.
  • fast/multicol/vertical-rl/float-multicol.html: Added.
  • fast/multicol/vertical-rl/float-paginate-complex.html: Added.
  • fast/multicol/vertical-rl/float-paginate.html: Added.
  • fast/multicol/vertical-rl/float-truncation-expected.txt: Added.
  • fast/multicol/vertical-rl/float-truncation.html: Added.
  • fast/multicol/vertical-rl/gap-non-negative-expected.txt: Added.
  • fast/multicol/vertical-rl/gap-non-negative.html: Added.
  • fast/multicol/vertical-rl/image-inside-nested-blocks-with-border-expected.txt: Added.
  • fast/multicol/vertical-rl/image-inside-nested-blocks-with-border.html: Added.
  • fast/multicol/vertical-rl/nested-columns.html: Added.
  • fast/multicol/vertical-rl/resources: Added.
  • fast/multicol/vertical-rl/resources/blimp.png: Added.
  • fast/multicol/vertical-rl/unsplittable-inline-block.html: Added.
  • platform/mac/fast/multicol/vertical-lr: Added.
  • platform/mac/fast/multicol/vertical-lr/border-padding-pagination-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-lr/border-padding-pagination-expected.png: Added.
  • platform/mac/fast/multicol/vertical-lr/border-padding-pagination-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
  • platform/mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-lr/column-count-with-rules-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-lr/column-count-with-rules-expected.png: Added.
  • platform/mac/fast/multicol/vertical-lr/column-count-with-rules-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-lr/column-rules-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-lr/column-rules-expected.png: Added.
  • platform/mac/fast/multicol/vertical-lr/column-rules-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
  • platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-lr/float-multicol-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
  • platform/mac/fast/multicol/vertical-lr/float-multicol-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-lr/float-paginate-complex-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
  • platform/mac/fast/multicol/vertical-lr/float-paginate-complex-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-lr/float-paginate-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
  • platform/mac/fast/multicol/vertical-lr/float-paginate-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-lr/nested-columns-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
  • platform/mac/fast/multicol/vertical-lr/nested-columns-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-lr/unsplittable-inline-block-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
  • platform/mac/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-rl: Added.
  • platform/mac/fast/multicol/vertical-rl/border-padding-pagination-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-rl/border-padding-pagination-expected.png: Added.
  • platform/mac/fast/multicol/vertical-rl/border-padding-pagination-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
  • platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-rl/column-count-with-rules-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-rl/column-count-with-rules-expected.png: Added.
  • platform/mac/fast/multicol/vertical-rl/column-count-with-rules-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-rl/column-rules-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-rl/column-rules-expected.png: Added.
  • platform/mac/fast/multicol/vertical-rl/column-rules-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
  • platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-rl/float-multicol-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
  • platform/mac/fast/multicol/vertical-rl/float-multicol-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
  • platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-rl/float-paginate-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
  • platform/mac/fast/multicol/vertical-rl/float-paginate-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-rl/nested-columns-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
  • platform/mac/fast/multicol/vertical-rl/nested-columns-expected.txt: Added.
  • platform/mac/fast/multicol/vertical-rl/unsplittable-inline-block-expected.checksum: Added.
  • platform/mac/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
  • platform/mac/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt: Added.
2:58 PM Changeset in webkit [76725] by bweinstein@apple.com
  • 3 edits in trunk/Source/WebKit2

WebKit2: Need API to get the frame load state of a BundleFrame
​https://bugs.webkit.org/show_bug.cgi?id=53193

Reviewed by John Sullivan.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameGetFrameLoadState): Call through to the FrameLoader to get the frame load state.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
2:54 PM Changeset in webkit [76724] by Dimitri Glazkov
  • 8 edits in trunk/Source/WebCore

2011-01-26 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r76719.
​http://trac.webkit.org/changeset/76719
​https://bugs.webkit.org/show_bug.cgi?id=53122

Broke a bunch of media tests in Chromium/Qt/GTK.

2:52 PM Changeset in webkit [76723] by tony@chromium.org
  • 6 edits in trunk

2011-01-26 Tony Chang <​tony@chromium.org>

Reviewed by Ryosuke Niwa.

[gtk] strip NUL characters when copying text/html on GTK+
​https://bugs.webkit.org/show_bug.cgi?id=52508

  • editing/pasteboard/copy-null-characters.html: Make sure we didn't

change innerHTML (it should still contain the null)

  • platform/gtk/Skipped: Re-enable the test

2011-01-26 Tony Chang <​tony@chromium.org>

Reviewed by Ryosuke Niwa.

[gtk] strip NUL characters when copying text/html on GTK+
​https://bugs.webkit.org/show_bug.cgi?id=52508

Putting NUL characters in the text/html clipboard doesn't work in
WebKit GTK+ (the pasted value is truncated at the NUL). Since we're
already stripping this character for plain text (for Windows), strip
it in text/html too.

  • editing/MarkupAccumulator.h: mark function as virtual
  • editing/markup.cpp: (WebCore::StyledMarkupAccumulator::appendString): (WebCore::StyledMarkupAccumulator::takeResults): strip nulls
2:50 PM Changeset in webkit [76722] by dpranke@chromium.org
  • 2 edits
    2 deletes in trunk/Tools

2011-01-26 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r76709.
​http://trac.webkit.org/changeset/76709
​https://bugs.webkit.org/show_bug.cgi?id=53194

"broke python tests on non-snowleopard platforms" (Requested
by dpranke on #webkit).

  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
2:43 PM Changeset in webkit [76721] by mario@webkit.org
  • 4 edits in trunk/Source

2011-01-26 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Reliable crash with getTextAtOffset()
​https://bugs.webkit.org/show_bug.cgi?id=53131

Properly calculate length in bytes for a UTF8 substring.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (utf8Substr): Use character instead of bytes as units to calculate the length in bytes for the UTF8 string.

2011-01-26 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Reliable crash with getTextAtOffset()
​https://bugs.webkit.org/show_bug.cgi?id=53131

New unit test to check the fix for this bug.

  • tests/testatk.c: (testWebkitAtkGetTextAtOffsetWithSpecialCharacters): New. (main): Add new unit test.
2:22 PM Changeset in webkit [76720] by Martin Robinson
  • 2 edits
    282 adds in trunk/LayoutTests

2011-01-26 Martin Robinson <​mrobinson@igalia.com>

Add the next set of CSS 2.1 baselines for GTK+.

  • platform/gtk/Skipped: Unskip tests which now have results.
  • platform/gtk/css2.1/t010403-shand-border-00-c-expected.checksum: Added.
  • platform/gtk/css2.1/t010403-shand-border-00-c-expected.png: Added.
  • platform/gtk/css2.1/t010403-shand-border-00-c-expected.txt: Added.
  • platform/gtk/css2.1/t010403-shand-font-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t010403-shand-font-00-b-expected.png: Added.
  • platform/gtk/css2.1/t010403-shand-font-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t010403-shand-font-01-b-expected.checksum: Added.
  • platform/gtk/css2.1/t010403-shand-font-01-b-expected.png: Added.
  • platform/gtk/css2.1/t010403-shand-font-01-b-expected.txt: Added.
  • platform/gtk/css2.1/t010403-shand-font-02-b-expected.checksum: Added.
  • platform/gtk/css2.1/t010403-shand-font-02-b-expected.png: Added.
  • platform/gtk/css2.1/t010403-shand-font-02-b-expected.txt: Added.
  • platform/gtk/css2.1/t010403-shand-font-03-b-expected.checksum: Added.
  • platform/gtk/css2.1/t010403-shand-font-03-b-expected.png: Added.
  • platform/gtk/css2.1/t010403-shand-font-03-b-expected.txt: Added.
  • platform/gtk/css2.1/t040102-keywords-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t040102-keywords-00-b-expected.png: Added.
  • platform/gtk/css2.1/t040102-keywords-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t040102-keywords-01-b-expected.checksum: Added.
  • platform/gtk/css2.1/t040102-keywords-01-b-expected.png: Added.
  • platform/gtk/css2.1/t040102-keywords-01-b-expected.txt: Added.
  • platform/gtk/css2.1/t040103-case-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-case-00-b-expected.png: Added.
  • platform/gtk/css2.1/t040103-case-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t040103-case-01-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-case-01-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-case-01-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-escapes-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-escapes-00-b-expected.png: Added.
  • platform/gtk/css2.1/t040103-escapes-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t040103-escapes-01-b-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-escapes-01-b-expected.png: Added.
  • platform/gtk/css2.1/t040103-escapes-01-b-expected.txt: Added.
  • platform/gtk/css2.1/t040103-escapes-02-d-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-escapes-02-d-expected.png: Added.
  • platform/gtk/css2.1/t040103-escapes-02-d-expected.txt: Added.
  • platform/gtk/css2.1/t040103-escapes-03-b-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-escapes-03-b-expected.png: Added.
  • platform/gtk/css2.1/t040103-escapes-03-b-expected.txt: Added.
  • platform/gtk/css2.1/t040103-escapes-04-b-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-escapes-04-b-expected.png: Added.
  • platform/gtk/css2.1/t040103-escapes-04-b-expected.txt: Added.
  • platform/gtk/css2.1/t040103-escapes-05-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-escapes-05-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-escapes-05-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-escapes-06-b-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-escapes-06-b-expected.png: Added.
  • platform/gtk/css2.1/t040103-escapes-06-b-expected.txt: Added.
  • platform/gtk/css2.1/t040103-escapes-07-b-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-escapes-07-b-expected.png: Added.
  • platform/gtk/css2.1/t040103-escapes-07-b-expected.txt: Added.
  • platform/gtk/css2.1/t040103-escapes-08-b-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-escapes-08-b-expected.png: Added.
  • platform/gtk/css2.1/t040103-escapes-08-b-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-00-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-00-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-00-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-01-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-01-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-01-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-02-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-02-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-02-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-03-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-03-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-03-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-04-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-04-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-04-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-05-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-05-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-05-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-06-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-06-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-06-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-07-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-07-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-07-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-08-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-08-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-08-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-09-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-09-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-09-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-10-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-10-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-10-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-11-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-11-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-11-c-expected.txt: Added.
  • platform/gtk/css2.1/t040103-ident-12-c-expected.checksum: Added.
  • platform/gtk/css2.1/t040103-ident-12-c-expected.png: Added.
  • platform/gtk/css2.1/t040103-ident-12-c-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-02-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-02-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-02-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-03-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-03-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-03-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-04-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-04-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-04-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-05-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-05-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-05-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-06-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-06-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-06-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-07-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-07-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-07-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-08-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-08-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-08-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-09-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-09-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-09-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-11-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-11-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-11-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-12-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-12-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-12-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-13-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-13-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-13-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-14-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-14-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-14-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-15-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-15-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-15-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-16-c-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-16-c-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-16-c-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-17-d-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-17-d-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-17-d-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-18-f-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-18-f-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-18-f-expected.txt: Added.
  • platform/gtk/css2.1/t1204-implied-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1204-implied-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1204-implied-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1204-implied-01-c-expected.checksum: Added.
  • platform/gtk/css2.1/t1204-implied-01-c-expected.png: Added.
  • platform/gtk/css2.1/t1204-implied-01-c-expected.txt: Added.
  • platform/gtk/css2.1/t1204-implied-02-d-expected.checksum: Added.
  • platform/gtk/css2.1/t1204-implied-02-d-expected.png: Added.
  • platform/gtk/css2.1/t1204-implied-02-d-expected.txt: Added.
  • platform/gtk/css2.1/t1204-multiple-00-c-expected.checksum: Added.
  • platform/gtk/css2.1/t1204-multiple-00-c-expected.png: Added.
  • platform/gtk/css2.1/t1204-multiple-00-c-expected.txt: Added.
  • platform/gtk/css2.1/t1204-multiple-01-c-expected.checksum: Added.
  • platform/gtk/css2.1/t1204-multiple-01-c-expected.png: Added.
  • platform/gtk/css2.1/t1204-multiple-01-c-expected.txt: Added.
  • platform/gtk/css2.1/t1204-order-00-c-expected.checksum: Added.
  • platform/gtk/css2.1/t1204-order-00-c-expected.png: Added.
  • platform/gtk/css2.1/t1204-order-00-c-expected.txt: Added.
  • platform/gtk/css2.1/t1204-order-01-d-expected.checksum: Added.
  • platform/gtk/css2.1/t1204-order-01-d-expected.png: Added.
  • platform/gtk/css2.1/t1204-order-01-d-expected.txt: Added.
  • platform/gtk/css2.1/t1204-root-e-expected.checksum: Added.
  • platform/gtk/css2.1/t1204-root-e-expected.png: Added.
  • platform/gtk/css2.1/t1204-root-e-expected.txt: Added.
  • platform/gtk/css2.1/t1205-c561-list-displ-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1205-c561-list-displ-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1205-c561-list-displ-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1205-c563-list-type-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1205-c563-list-type-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1205-c563-list-type-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1205-c563-list-type-01-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1205-c563-list-type-01-b-expected.png: Added.
  • platform/gtk/css2.1/t1205-c563-list-type-01-b-expected.txt: Added.
  • platform/gtk/css2.1/t1205-c564-list-img-00-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t1205-c564-list-img-00-b-g-expected.png: Added.
  • platform/gtk/css2.1/t1205-c564-list-img-00-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t1205-c565-list-pos-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1205-c565-list-pos-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1205-c565-list-pos-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1205-c566-list-stl-00-e-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t1205-c566-list-stl-00-e-ag-expected.png: Added.
  • platform/gtk/css2.1/t1205-c566-list-stl-00-e-ag-expected.txt: Added.
  • platform/gtk/css2.1/t1205-c566-list-stl-01-c-g-expected.checksum: Added.
  • platform/gtk/css2.1/t1205-c566-list-stl-01-c-g-expected.png: Added.
  • platform/gtk/css2.1/t1205-c566-list-stl-01-c-g-expected.txt: Added.
  • platform/gtk/css2.1/t1401-c531-color-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t1401-c531-color-00-a-expected.png: Added.
  • platform/gtk/css2.1/t1401-c531-color-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t1402-c45-bg-canvas-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1402-c45-bg-canvas-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1402-c45-bg-canvas-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1503-c522-font-family-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1503-c522-font-family-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1503-c522-font-family-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1504-c523-font-style-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1504-c523-font-style-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1504-c523-font-style-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1504-c543-txt-decor-00-d-g-expected.checksum: Added.
  • platform/gtk/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Added.
  • platform/gtk/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt: Added.
  • platform/gtk/css2.1/t1505-c524-font-var-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1505-c524-font-var-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1505-c524-font-var-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1506-c525-font-wt-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1506-c525-font-wt-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1506-c525-font-wt-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-01-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-01-b-a-expected.png: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-01-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-02-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-02-b-a-expected.png: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-02-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-03-f-a-expected.checksum: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-03-f-a-expected.png: Added.
  • platform/gtk/css2.1/t1507-c526-font-sz-03-f-a-expected.txt: Added.
  • platform/gtk/css2.1/t1508-c527-font-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1508-c527-font-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1508-c527-font-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1508-c527-font-01-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1508-c527-font-01-b-expected.png: Added.
  • platform/gtk/css2.1/t1508-c527-font-01-b-expected.txt: Added.
  • platform/gtk/css2.1/t1508-c527-font-02-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1508-c527-font-02-b-expected.png: Added.
  • platform/gtk/css2.1/t1508-c527-font-02-b-expected.txt: Added.
  • platform/gtk/css2.1/t1508-c527-font-03-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1508-c527-font-03-b-expected.png: Added.
  • platform/gtk/css2.1/t1508-c527-font-03-b-expected.txt: Added.
  • platform/gtk/css2.1/t1508-c527-font-04-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1508-c527-font-04-b-expected.png: Added.
  • platform/gtk/css2.1/t1508-c527-font-04-b-expected.txt: Added.
  • platform/gtk/css2.1/t1508-c527-font-05-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1508-c527-font-05-b-expected.png: Added.
  • platform/gtk/css2.1/t1508-c527-font-05-b-expected.txt: Added.
  • platform/gtk/css2.1/t1508-c527-font-06-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1508-c527-font-06-b-expected.png: Added.
  • platform/gtk/css2.1/t1508-c527-font-06-b-expected.txt: Added.
  • platform/gtk/css2.1/t1508-c527-font-07-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1508-c527-font-07-b-expected.png: Added.
  • platform/gtk/css2.1/t1508-c527-font-07-b-expected.txt: Added.
  • platform/gtk/css2.1/t1508-c527-font-08-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1508-c527-font-08-b-expected.png: Added.
  • platform/gtk/css2.1/t1508-c527-font-08-b-expected.txt: Added.
  • platform/gtk/css2.1/t1508-c527-font-09-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1508-c527-font-09-b-expected.png: Added.
  • platform/gtk/css2.1/t1508-c527-font-09-b-expected.txt: Added.
  • platform/gtk/css2.1/t1508-c527-font-10-c-expected.checksum: Added.
  • platform/gtk/css2.1/t1508-c527-font-10-c-expected.png: Added.
  • platform/gtk/css2.1/t1508-c527-font-10-c-expected.txt: Added.
  • platform/gtk/css2.1/t1601-c547-indent-00-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t1601-c547-indent-00-b-a-expected.png: Added.
  • platform/gtk/css2.1/t1601-c547-indent-00-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t1601-c547-indent-01-d-expected.checksum: Added.
  • platform/gtk/css2.1/t1601-c547-indent-01-d-expected.png: Added.
  • platform/gtk/css2.1/t1601-c547-indent-01-d-expected.txt: Added.
  • platform/gtk/css2.1/t1602-c43-center-00-d-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t1602-c43-center-00-d-ag-expected.png: Added.
  • platform/gtk/css2.1/t1602-c43-center-00-d-ag-expected.txt: Added.
  • platform/gtk/css2.1/t1602-c546-txt-align-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1602-c546-txt-align-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1602-c546-txt-align-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1604-c541-word-sp-00-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Added.
  • platform/gtk/css2.1/t1604-c541-word-sp-00-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.png: Added.
  • platform/gtk/css2.1/t1604-c541-word-sp-01-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t1604-c542-letter-sp-00-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t1604-c542-letter-sp-00-b-a-expected.png: Added.
  • platform/gtk/css2.1/t1604-c542-letter-sp-00-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t1604-c542-letter-sp-01-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t1604-c542-letter-sp-01-b-a-expected.png: Added.
  • platform/gtk/css2.1/t1604-c542-letter-sp-01-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t1605-c545-txttrans-00-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t1605-c545-txttrans-00-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t1605-c545-txttrans-00-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t1606-c562-white-sp-00-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t1606-c562-white-sp-00-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t1606-c562-white-sp-00-b-ag-expected.txt: Added.
2:19 PM Changeset in webkit [76719] by Dimitri Glazkov
  • 8 edits in trunk/Source/WebCore

2011-01-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

Change HTMLInputElement-derived parts of media element shadow DOM to use shadowPseudoId.
​https://bugs.webkit.org/show_bug.cgi?id=53122

This is the first step in converting HTMLMediaElement to the new shadow DOM.

Should not regress any existing tests. No observable change in behavior.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Removed now-unnecessary hard-coded pseudo-element selectors. (WebCore::nameToPseudoTypeMap): Ditto. (WebCore::CSSSelector::extractPseudoType): Ditto.
  • css/CSSSelector.h: Ditto.
  • css/mediaControls.css: Added proper initial values, now that elements use the proper selector pipeline.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlInputElement::MediaControlInputElement): Removed the switch statement,

which is now replaced with virtual shadowPseudoId on each corresponding class.

(WebCore::MediaControlInputElement::styleForElement): Changed to use element pipeline.
(WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement): Changed to set

display type in constructor.

(WebCore::MediaControlMuteButtonElement::create): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlMuteButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlVolumeSliderMuteButtonElement::MediaControlVolumeSliderMuteButtonElement): Added

to disambiguate from the MediaControlMuteButtonElement.

(WebCore::MediaControlVolumeSliderMuteButtonElement::create): Added.
(WebCore::MediaControlVolumeSliderMuteButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlPlayButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlSeekForwardButtonElement::MediaControlSeekForwardButtonElement): Added.
(WebCore::MediaControlSeekForwardButtonElement::create): Added.
(WebCore::MediaControlSeekForwardButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlSeekBackButtonElement::MediaControlSeekBackButtonElement): Added.
(WebCore::MediaControlSeekBackButtonElement::create): Added.
(WebCore::MediaControlSeekBackButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement): Added.
(WebCore::MediaControlRewindButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlReturnToRealtimeButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlTimelineElement::shadowPseudoId): Added.
(WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlVolumeSliderElement::shadowPseudoId): Added.
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlFullscreenButtonElement::shadowPseudoId): Added.

  • rendering/MediaControlElements.h: (WebCore::MediaControlSeekForwardButtonElement::isForwardButton): Added. (WebCore::MediaControlSeekBackButtonElement::isForwardButton): Added.
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::createMuteButton): Changed to use new constructor. (WebCore::RenderMedia::createSeekBackButton): Ditto. (WebCore::RenderMedia::createSeekForwardButton): Ditto. (WebCore::RenderMedia::createVolumeSliderMuteButton): Ditto.
  • rendering/style/RenderStyleConstants.h: Removed constants that are no longer used.
2:10 PM Changeset in webkit [76718] by Martin Robinson
  • 2 edits
    300 adds in trunk/LayoutTests

2011-01-26 Martin Robinson <​mrobinson@igalia.com>

Continue the import of GTK+ test results for the CSS 2.1 test suite.

  • platform/gtk/Skipped: Unskip tests which now have results.
  • platform/gtk/css2.1/t0805-c5512-ibrdr-rw-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5512-ibrdr-rw-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5512-ibrdr-rw-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-00-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-01-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-01-b-g-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-01-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-02-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-02-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-02-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-03-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-03-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-03-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5513-ibrdr-bw-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5513-ibrdr-bw-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5513-ibrdr-bw-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-00-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-01-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-01-b-g-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-01-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-02-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-02-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-02-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-03-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-03-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-03-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5514-ibrdr-lw-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5514-ibrdr-lw-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5514-ibrdr-lw-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5515-brdr-w-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5515-brdr-w-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5515-brdr-w-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5515-brdr-w-01-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5515-brdr-w-01-b-g-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5515-brdr-w-01-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5515-brdr-w-02-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5515-brdr-w-02-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5515-brdr-w-02-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5515-ibrdr-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5515-ibrdr-00-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5515-ibrdr-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5516-brdr-c-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5516-brdr-c-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5516-brdr-c-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5516-ibrdr-c-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5516-ibrdr-c-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5516-ibrdr-c-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5517-brdr-s-00-c-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5517-brdr-s-00-c-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5517-brdr-s-00-c-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5517-ibrdr-s-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5517-ibrdr-s-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5517-ibrdr-s-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5518-brdr-t-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5518-brdr-t-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5518-brdr-t-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5518-brdr-t-01-e-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5518-ibrdr-t-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5518-ibrdr-t-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5518-ibrdr-t-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5519-brdr-r-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5519-brdr-r-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5519-brdr-r-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5519-brdr-r-01-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5519-brdr-r-01-e-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5519-brdr-r-02-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5519-brdr-r-02-e-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5519-brdr-r-02-e-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5519-ibrdr-r-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5519-ibrdr-r-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5520-brdr-b-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5520-brdr-b-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5520-brdr-b-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5520-brdr-b-01-e-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5520-brdr-b-01-e-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5520-ibrdr-b-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5520-ibrdr-b-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5521-brdr-l-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5521-brdr-l-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5521-brdr-l-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5521-brdr-l-01-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5521-brdr-l-01-e-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5521-brdr-l-01-e-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5521-brdr-l-02-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5521-brdr-l-02-e-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5521-brdr-l-02-e-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5521-ibrdr-l-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5522-brdr-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5522-brdr-00-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5522-brdr-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5522-brdr-01-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5522-brdr-01-b-g-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5522-brdr-01-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5522-brdr-02-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5522-brdr-02-e-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5522-brdr-02-e-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5522-ibrdr-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5522-ibrdr-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5522-ibrdr-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c414-flt-00-d-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c414-flt-00-d-expected.png: Added.
  • platform/gtk/css2.1/t0905-c414-flt-00-d-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c414-flt-01-d-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c414-flt-01-d-g-expected.png: Added.
  • platform/gtk/css2.1/t0905-c414-flt-01-d-g-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c414-flt-02-c-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c414-flt-02-c-expected.png: Added.
  • platform/gtk/css2.1/t0905-c414-flt-02-c-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c414-flt-03-c-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c414-flt-03-c-expected.png: Added.
  • platform/gtk/css2.1/t0905-c414-flt-03-c-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c414-flt-04-c-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c414-flt-04-c-expected.png: Added.
  • platform/gtk/css2.1/t0905-c414-flt-04-c-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c414-flt-fit-00-d-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c414-flt-fit-00-d-expected.png: Added.
  • platform/gtk/css2.1/t0905-c414-flt-fit-00-d-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c414-flt-fit-01-d-g-expected.png: Added.
  • platform/gtk/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c414-flt-wrap-00-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c414-flt-wrap-00-e-expected.png: Added.
  • platform/gtk/css2.1/t0905-c414-flt-wrap-00-e-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c414-flt-wrap-01-d-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png: Added.
  • platform/gtk/css2.1/t0905-c414-flt-wrap-01-d-g-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltblck-00-d-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltblck-00-d-ag-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltblck-01-d-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltblck-01-d-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltblck-01-d-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltclr-00-c-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltclr-00-c-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-flthw-00-c-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-flthw-00-c-g-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-flthw-00-c-g-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltinln-00-c-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltinln-00-c-ag-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltinln-00-c-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltmult-00-d-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltmult-00-d-g-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltmult-00-d-g-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-01-c-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-01-c-g-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-01-c-g-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-02-c-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-02-c-g-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-03-c-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwrap-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwrap-00-b-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5525-fltwrap-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5526-fltclr-00-c-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5526-fltclr-00-c-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0905-c5526-flthw-00-c-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0905-c5526-flthw-00-c-g-expected.png: Added.
  • platform/gtk/css2.1/t0905-c5526-flthw-00-c-g-expected.txt: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-01-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-01-b-expected.png: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-01-b-expected.txt: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-02-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-02-b-expected.png: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-02-b-expected.txt: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-03-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-03-b-expected.png: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-03-b-expected.txt: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-04-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-04-b-expected.png: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-04-b-expected.txt: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-05-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-05-b-expected.png: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-05-b-expected.txt: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-06-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-06-b-expected.png: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-06-b-expected.txt: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-07-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-07-b-expected.png: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-07-b-expected.txt: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-08-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-08-b-expected.png: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-08-b-expected.txt: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-09-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-09-b-expected.png: Added.
  • platform/gtk/css2.1/t1001-abs-pos-cb-09-b-expected.txt: Added.
  • platform/gtk/css2.1/t1002-c5523-width-00-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t1002-c5523-width-00-b-g-expected.png: Added.
  • platform/gtk/css2.1/t1002-c5523-width-00-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t1002-c5523-width-01-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t1002-c5523-width-01-b-g-expected.png: Added.
  • platform/gtk/css2.1/t1002-c5523-width-01-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t1002-c5523-width-02-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t1002-c5523-width-02-b-g-expected.png: Added.
  • platform/gtk/css2.1/t1002-c5523-width-02-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t1004-c43-rpl-bbx-00-d-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t1004-c43-rpl-bbx-00-d-ag-expected.png: Added.
  • platform/gtk/css2.1/t1004-c43-rpl-bbx-00-d-ag-expected.txt: Added.
  • platform/gtk/css2.1/t1004-c43-rpl-ibx-00-d-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t1004-c43-rpl-ibx-00-d-ag-expected.png: Added.
  • platform/gtk/css2.1/t1004-c43-rpl-ibx-00-d-ag-expected.txt: Added.
  • platform/gtk/css2.1/t1004-c5524-width-00-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t1004-c5524-width-00-b-g-expected.png: Added.
  • platform/gtk/css2.1/t1004-c5524-width-00-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t1005-c5524-width-00-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t1005-c5524-width-00-b-g-expected.png: Added.
  • platform/gtk/css2.1/t1005-c5524-width-00-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t1005-c5524-width-01-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t1005-c5524-width-01-b-g-expected.png: Added.
  • platform/gtk/css2.1/t1005-c5524-width-01-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-00-d-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-00-d-ag-expected.png: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-00-d-ag-expected.txt: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-01-d-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-01-d-ag-expected.png: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-01-d-ag-expected.txt: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-02-d-ag-expected.txt: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-03-d-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-03-d-ag-expected.png: Added.
  • platform/gtk/css2.1/t1008-c44-ln-box-03-d-ag-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-01-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-01-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-01-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-02-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-02-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-02-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-03-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-03-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-03-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-04-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-04-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-04-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-05-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-05-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-05-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-06-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-06-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-06-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-07-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-07-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-07-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-08-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-08-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-08-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-09-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-09-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-09-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-11-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-11-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-11-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-12-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-12-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-12-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-13-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-13-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-13-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-14-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-14-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-14-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-15-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-15-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-15-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counter-16-f-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counter-16-f-expected.png: Added.
  • platform/gtk/css2.1/t1202-counter-16-f-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-00-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t1202-counters-01-b-expected.checksum: Added.
  • platform/gtk/css2.1/t1202-counters-01-b-expected.png: Added.
  • platform/gtk/css2.1/t1202-counters-01-b-expected.txt: Added.
2:06 PM Changeset in webkit [76717] by kbr@google.com
  • 11 edits in trunk/Source

2011-01-26 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

Fix multisampling support in DrawingBuffer
​https://bugs.webkit.org/show_bug.cgi?id=53154

Plumbed GL_ANGLE_framebuffer_multisample and
GL_ANGLE_framebuffer_blit (exposed as the unified extension
GL_CHROMIUM_framebuffer_multisample) through WebGraphicsContext3D.

  • public/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp: (WebCore::Extensions3DChromium::blitFramebuffer): (WebCore::Extensions3DChromium::renderbufferStorageMultisample):
  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::supportsExtension): (WebCore::GraphicsContext3DInternal::ensureExtensionEnabled):
  • src/GraphicsContext3DInternal.h:

2011-01-26 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

Fix multisampling support in DrawingBuffer
​https://bugs.webkit.org/show_bug.cgi?id=53154

In DrawingBuffer's multisampling code path, fixed enum usage and a
bug where it would incorrectly redefine the depth and stencil
buffers. Hooked up multisampling code path in Chromium port.

Tested manually with some accelerated 2D canvas content.
Multisampling isn't being switched on for the accelerated 2D
canvas at the current time because it will increase fill rate
requirements and cause a large number of rebaselines.

  • platform/graphics/Extensions3D.h:
  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::publishToPlatformLayer):
  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::create): (WebCore::DrawingBuffer::reset):
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: (WebCore::Extensions3DOpenGL::supports):
1:59 PM Changeset in webkit [76716] by yael.aharon@nokia.com
  • 6 edits in trunk

2011-01-26 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Symbian] Fix --minimal build
​https://bugs.webkit.org/show_bug.cgi?id=52839

Move definition of USE_SYSTEM_MALLOC out of pri file.
Put it in platform.h instead.

  • Source/WebKit.pri:

2011-01-26 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Symbian] Fix --minimal build
​https://bugs.webkit.org/show_bug.cgi?id=52839

Move definition of USE_SYSTEM_MALLOC out of pri file.
Put it in platform.h instead.

  • wtf/Platform.h:
  • wtf/TCSystemAlloc.cpp:
  • wtf/wtf.pri:
1:54 PM Changeset in webkit [76715] by Martin Robinson
  • 2 edits
    150 adds in trunk/LayoutTests

2011-01-26 Martin Robinson <​mrobinson@igalia.com>

Continue importing GTK+ test results for the CSS 2.1 test suite.

  • platform/gtk/Skipped: Unskip tests with results.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-05-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-05-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-05-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-06-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-06-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-06-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-01-c-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-01-c-a-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-01-c-a-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-02-c-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-02-c-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-02-c-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-03-c-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-03-c-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-03-c-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5505-imrgn-00-a-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5505-imrgn-00-a-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5505-imrgn-00-a-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-00-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-00-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-00-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-01-e-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-01-e-a-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-01-e-a-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-02-c-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-02-c-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-02-c-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-03-c-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-03-c-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5505-mrgn-03-c-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5506-ipadn-t-00-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5506-ipadn-t-00-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5506-ipadn-t-00-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5506-ipadn-t-01-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5506-ipadn-t-01-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5506-ipadn-t-01-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5506-ipadn-t-02-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5506-ipadn-t-02-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5506-ipadn-t-02-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5506-padn-t-00-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5506-padn-t-00-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5506-padn-t-00-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-00-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-00-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-00-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-01-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-01-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-01-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-02-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-02-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-02-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-03-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-03-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-03-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-04-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-04-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5507-ipadn-r-04-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-00-c-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-00-c-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-01-c-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-01-c-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-01-c-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-02-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-02-f-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-02-f-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-03-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-03-f-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5507-padn-r-03-f-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-00-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-00-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-00-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-01-f-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-01-f-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-01-f-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-02-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-02-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-02-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-00-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-00-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-00-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-01-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-01-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-01-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-03-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-03-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-03-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-04-f-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-04-f-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5509-ipadn-l-04-f-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-00-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-00-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-01-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-01-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-01-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-02-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-02-f-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-02-f-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-03-f-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-03-f-g-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5510-ipadn-00-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5510-ipadn-00-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5510-ipadn-00-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5510-padn-00-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5510-padn-00-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5510-padn-01-e-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5510-padn-01-e-a-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5510-padn-01-e-a-expected.txt: Added.
  • platform/gtk/css2.1/t0804-c5510-padn-02-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0804-c5510-padn-02-f-expected.png: Added.
  • platform/gtk/css2.1/t0804-c5510-padn-02-f-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-00-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-01-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-01-b-g-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-01-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-02-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-02-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-02-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-03-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-03-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-03-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5511-ibrdr-tw-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5511-ibrdr-tw-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5511-ibrdr-tw-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-00-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-01-b-g-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-01-b-g-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-01-b-g-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-02-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-02-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-02-b-expected.txt: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-03-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-03-b-expected.png: Added.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-03-b-expected.txt: Added.
1:45 PM Changeset in webkit [76714] by Martin Robinson
  • 2 edits
    150 adds in trunk/LayoutTests

2011-01-26 Martin Robinson <​mrobinson@igalia.com>

Begin importing GTK+ results for the CSS 2.1 test suite. This will
be the first in a series of commits. Each test results has been checked
against those generated for Qt and Mac.

  • platform/gtk/Skipped: Unskip tests which now have results.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-00-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-00-f-expected.png: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-00-f-expected.txt: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-01-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-01-f-expected.png: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-01-f-expected.txt: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-02-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-02-f-expected.png: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-02-f-expected.txt: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-03-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-03-f-expected.png: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-03-f-expected.txt: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-04-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-04-f-expected.png: Added.
  • platform/gtk/css2.1/t0402-c71-fwd-parsing-04-f-expected.txt: Added.
  • platform/gtk/css2.1/t0402-syntax-01-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0402-syntax-01-f-expected.png: Added.
  • platform/gtk/css2.1/t0402-syntax-01-f-expected.txt: Added.
  • platform/gtk/css2.1/t0402-syntax-02-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0402-syntax-02-f-expected.png: Added.
  • platform/gtk/css2.1/t0402-syntax-02-f-expected.txt: Added.
  • platform/gtk/css2.1/t0402-syntax-03-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0402-syntax-03-f-expected.png: Added.
  • platform/gtk/css2.1/t0402-syntax-03-f-expected.txt: Added.
  • platform/gtk/css2.1/t0402-syntax-04-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0402-syntax-04-f-expected.png: Added.
  • platform/gtk/css2.1/t0402-syntax-04-f-expected.txt: Added.
  • platform/gtk/css2.1/t0402-syntax-05-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0402-syntax-05-f-expected.png: Added.
  • platform/gtk/css2.1/t0402-syntax-05-f-expected.txt: Added.
  • platform/gtk/css2.1/t0402-syntax-06-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0402-syntax-06-f-expected.png: Added.
  • platform/gtk/css2.1/t0402-syntax-06-f-expected.txt: Added.
  • platform/gtk/css2.1/t0505-c16-descendant-00-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0505-c16-descendant-00-e-expected.png: Added.
  • platform/gtk/css2.1/t0505-c16-descendant-00-e-expected.txt: Added.
  • platform/gtk/css2.1/t0505-c16-descendant-01-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0505-c16-descendant-01-e-expected.png: Added.
  • platform/gtk/css2.1/t0505-c16-descendant-01-e-expected.txt: Added.
  • platform/gtk/css2.1/t0505-c16-descendant-02-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0505-c16-descendant-02-e-expected.png: Added.
  • platform/gtk/css2.1/t0505-c16-descendant-02-e-expected.txt: Added.
  • platform/gtk/css2.1/t0509-c15-ids-00-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0509-c15-ids-00-a-expected.png: Added.
  • platform/gtk/css2.1/t0509-c15-ids-00-a-expected.txt: Added.
  • platform/gtk/css2.1/t0509-c15-ids-01-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0509-c15-ids-01-e-expected.png: Added.
  • platform/gtk/css2.1/t0509-c15-ids-01-e-expected.txt: Added.
  • platform/gtk/css2.1/t0509-id-sel-syntax-01-f-expected.checksum: Added.
  • platform/gtk/css2.1/t0509-id-sel-syntax-01-f-expected.png: Added.
  • platform/gtk/css2.1/t0509-id-sel-syntax-01-f-expected.txt: Added.
  • platform/gtk/css2.1/t0509-id-sel-syntax-02-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0509-id-sel-syntax-02-b-expected.png: Added.
  • platform/gtk/css2.1/t0509-id-sel-syntax-02-b-expected.txt: Added.
  • platform/gtk/css2.1/t0510-c25-pseudo-elmnt-00-c-expected.checksum: Added.
  • platform/gtk/css2.1/t0510-c25-pseudo-elmnt-00-c-expected.png: Added.
  • platform/gtk/css2.1/t0510-c25-pseudo-elmnt-00-c-expected.txt: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-anch-00-e-i-expected.checksum: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-anch-00-e-i-expected.png: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-anch-00-e-i-expected.txt: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-00-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-00-e-expected.png: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-00-e-expected.txt: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-01-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-01-e-expected.png: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-01-e-expected.txt: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-02-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-02-e-expected.png: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-02-e-expected.txt: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-03-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-03-e-expected.png: Added.
  • platform/gtk/css2.1/t0511-c21-pseud-link-03-e-expected.txt: Added.
  • platform/gtk/css2.1/t0602-c13-inh-underlin-00-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0602-c13-inh-underlin-00-e-expected.png: Added.
  • platform/gtk/css2.1/t0602-c13-inh-underlin-00-e-expected.txt: Added.
  • platform/gtk/css2.1/t0602-c13-inheritance-00-e-expected.checksum: Added.
  • platform/gtk/css2.1/t0602-c13-inheritance-00-e-expected.png: Added.
  • platform/gtk/css2.1/t0602-c13-inheritance-00-e-expected.txt: Added.
  • platform/gtk/css2.1/t0602-inherit-bdr-pad-b-00-expected.checksum: Added.
  • platform/gtk/css2.1/t0602-inherit-bdr-pad-b-00-expected.png: Added.
  • platform/gtk/css2.1/t0602-inherit-bdr-pad-b-00-expected.txt: Added.
  • platform/gtk/css2.1/t0603-c11-import-00-b-expected.checksum: Added.
  • platform/gtk/css2.1/t0603-c11-import-00-b-expected.png: Added.
  • platform/gtk/css2.1/t0603-c11-import-00-b-expected.txt: Added.
  • platform/gtk/css2.1/t0801-c412-hz-box-00-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0801-c412-hz-box-00-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0801-c412-hz-box-00-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-00-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-00-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-00-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-01-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-01-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-01-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-02-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-02-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-02-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-03-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-03-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-03-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-04-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-04-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-04-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-05-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-05-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-05-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-06-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-06-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5502-imrgn-r-06-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-01-c-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-01-c-a-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-01-c-a-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-02-c-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-02-c-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-03-c-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-03-c-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5502-mrgn-r-03-c-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-00-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-00-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-00-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-01-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-01-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-01-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-03-b-a-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-03-b-a-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-03-b-a-expected.txt: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-04-b-ag-expected.checksum: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-04-b-ag-expected.png: Added.
  • platform/gtk/css2.1/t0803-c5504-imrgn-l-04-b-ag-expected.txt: Added.
  • platform/gtk/css2.1/t09-c5526c-display-00-e-expected.checksum: Added.
  • platform/gtk/css2.1/t09-c5526c-display-00-e-expected.png: Added.
  • platform/gtk/css2.1/t09-c5526c-display-00-e-expected.txt: Added.
1:30 PM Changeset in webkit [76713] by tony@chromium.org
  • 4 edits in trunk/Source

2011-01-26 Tony Chang <​tony@chromium.org>

Unreviewed.

[chromium] revert r68310 because of race conditions detected by tsans
​https://bugs.webkit.org/show_bug.cgi?id=53185

Causes stability problems for Chromium, ​http://crbug.com/70589

  • platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: (WebCore::SQLiteFileSystem::registerSQLiteVFS):

2011-01-26 Tony Chang <​tony@chromium.org>

Unreviewed.

[chromium] revert r68310 because of race conditions detected by tsans
​https://bugs.webkit.org/show_bug.cgi?id=53185

  • DEPS: Roll chromium to 72673 to pick up sqlite revert.
1:07 PM Changeset in webkit [76712] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Skip fast/loader/willSendRequest-null-for-preload.html on GTK, because GTK doesn't have
support for setWillSendRequestReturnsNull.

  • platform/gtk/Skipped:
1:02 PM Changeset in webkit [76711] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <​rniwa@webkit.org>

Another unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
12:46 PM Changeset in webkit [76710] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
12:45 PM Changeset in webkit [76709] by dpranke@chromium.org
  • 2 edits
    2 adds in trunk/Tools

2011-01-26 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: add a "mock DRT" port implementation
and a separate class that emulates what we expect the
DumpRenderTree behavior to be.

This will eventually replace port/dryrun.py and allow us to get
better test coverage of the new-run-webkit-tests code as well as
a reference for what new-run-webkit-tests expects from DRT.

This is the first attempt at this, and it is pretty bare-boned. It
really only has been tested on the 'mac' port (and a little on
the 'chromium-mac' port.

​https://bugs.webkit.org/show_bug.cgi?id=53126

  • Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/factory.py:
12:42 PM Changeset in webkit [76708] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2011-01-26 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

Make fireEventsAndUpdateStyle use stack local vectors.
​https://bugs.webkit.org/show_bug.cgi?id=46760

Test: animations/animation-add-events-in-handler.html

  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle):

2011-01-26 Justin Schuh <​jschuh@chromium.org>

Reviewed by Adam Barth.

Make fireEventsAndUpdateStyle use stack local vectors.
​https://bugs.webkit.org/show_bug.cgi?id=46760

  • animations/animation-add-events-in-handler-expected.txt: Added.
  • animations/animation-add-events-in-handler.html: Added.
12:32 PM Changeset in webkit [76707] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-26 Tony Chang <​tony@chromium.org>

Unreviewed, marking fast/overflow/overflow-rtl-vertical.html as
passing. This was fixed in r76669.

  • platform/chromium/test_expectations.txt:
12:12 PM Changeset in webkit [76706] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Skip fast/loader/willSendRequest-null-for-preload.html on WebKit2, because WebKit2 doesn't have
setWillSendRequestReturnsNull yet.

This is tracked by ​https://bugs.webkit.org/show_bug.cgi?id=42690.

  • platform/mac-wk2/Skipped:
12:03 PM Changeset in webkit [76705] by bweinstein@apple.com
  • 3 edits
    1 add
    1 delete in trunk/LayoutTests

Update the test landed in r76701 to not depend on loading a "script" from ​http://example.com, make it
use a local script (which still reproduces the crash).

Reviewed by Ryosuke Niwa.

  • fast/loader/resources/empty-script.js: Added.
  • fast/loader/willSendRequest-null-for-preload-expected.txt: Removed the line for the console error.
  • fast/loader/willSendRequest-null-for-preload.html: Have the script in the head be a local script.
  • platform/win/fast/loader: Removed.
  • platform/win/fast/loader/willSendRequest-null-for-preload-expected.txt: Removed. No need for platform-specific results.
11:53 AM Changeset in webkit [76704] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-01-26 Xianzhu Wang <​wangxianzhu@google.com>

Reviewed by Tony Chang.

Add '--no-timeout' option to Chromium DRT to ease debugging.
​https://bugs.webkit.org/show_bug.cgi?id=52873

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
11:43 AM Changeset in webkit [76703] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <​rniwa@webkit.org>

Another unreviewed Chromium rebaselines for r76688.

  • platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-win/svg/custom/use-setAttribute-crash-expected.checksum:
  • platform/chromium-win/svg/custom/use-setAttribute-crash-expected.png:
11:14 AM Changeset in webkit [76702] by Nate Chapin
  • 6 edits in trunk/Source/WebCore

2011-01-26 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Remove m_URL from FrameLoader and depend on Document::url()
instead. FrameLoader::url() will be removed in a followup patch.
​https://bugs.webkit.org/show_bug.cgi?id=41165

Refactor only, no new tests.

  • WebCore.exp.in:
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::updateURLForPushOrReplaceState):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::begin):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL): (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::url): (WebCore::FrameLoader::setOutgoingReferrer): (WebCore::FrameLoader::startIconLoader): (WebCore::FrameLoader::commitIconURLToIconDatabase): (WebCore::FrameLoader::finishedParsing): (WebCore::FrameLoader::checkIfDisplayInsecureContent): (WebCore::FrameLoader::checkIfRunInsecureContent): (WebCore::FrameLoader::updateFirstPartyForCookies): (WebCore::FrameLoader::loadInSameDocument): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::open): (WebCore::FrameLoader::shouldScrollToAnchor):
  • loader/FrameLoader.h: Rename setURL() to setOutgoingReferrer().
11:07 AM Changeset in webkit [76701] by bweinstein@apple.com
  • 7 edits
    4 adds in trunk

Source/WebCore: Crashes loading pages when cancelling subresource loads through WebKit
​https://bugs.webkit.org/show_bug.cgi?id=53123
<rdar://problem/8914361>

Reviewed by Antti Koivisto.

Fix a crash that happened when cancelling subresource loads through WebKit.

When a load is cancelled synchronously (via the WebKit client), CachedResourceLoader::requestResource
can be called recursively on the same function, either leading to infinite recursion, or deleting
an object when it is not done being used.

The fix for this was to call checkForPendingPreloads and servePendingRequests asynchronously when
CachedResourceLoader::loadDone was called synchronously (due to the load being cancelled synchronously).

Test: fast/loader/willSendRequest-null-for-preload.html

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::setRequest): Only dispatch didReceiveServerRedirectForProvisionalLoadForFrame

if our new URL is non-null.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader): Initialize our timer.
(WebCore::CachedResourceLoader::loadDone): If the CachedResource we were passed in was 0, that means this

function was called synchronously
from CachedResourceRequest::load, and we don't want to call into checkForPendingPreloads synchronously,
so put it on a 0-delay timer to make the calls to checkForPendingPreloads and servePendingRequests asynchronous.

(WebCore::CachedResourceLoader::loadDonePendingActionTimerFired): Call checkForPendingPreloads and servePendingRequests.
(WebCore::CachedResourceLoader::checkForPendingPreloads): m_pendingPreloads is now a Deque instead of a Vector,

so use Deque methods.

  • loader/cache/CachedResourceLoader.h: Add the timer, the timer callback function, and make m_pendingPreloads a Deque.

Source/WebKit2: Crashes loading pages when cancelling subresource loads through WebKit
​https://bugs.webkit.org/show_bug.cgi?id=53123
<rdar://problem/8914361>

Reviewed by Antti Koivisto.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): If our URL is null, return early instead of dispatching

a message.

LayoutTests: Reviewed byAntti Koivisto.

Crashes loading pages when cancelling subresource loads through WebKit
​https://bugs.webkit.org/show_bug.cgi?id=53123
<rdar://problem/8914361>

Add tests for crashing when cancelling subresource loads through WebKit via setWillSendRequestReturnsNull.

  • fast/loader/willSendRequest-null-for-preload-expected.txt: Added.
  • fast/loader/willSendRequest-null-for-preload.html: Added.
11:05 AM CSS21Results edited by tabatkins@google.com
Added rtl-linebreak (was missing because Simon had marked as invalid), … (diff)
10:40 AM Changeset in webkit [76700] by rniwa@webkit.org
  • 29 edits in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium Linux rebaselines for r76688.

  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
  • platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/chromium-linux/svg/batik/text/verticalText-expected.checksum:
  • platform/chromium-linux/svg/batik/text/verticalText-expected.png:
  • platform/chromium-linux/svg/batik/text/verticalTextOnPath-expected.checksum:
  • platform/chromium-linux/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-all-expected.checksum:
  • platform/chromium-linux/svg/custom/linking-a-03-b-all-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-viewBox-transform-expected.checksum:
  • platform/chromium-linux/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-linux/svg/custom/preserve-aspect-ratio-syntax-expected.checksum:
  • platform/chromium-linux/svg/custom/preserve-aspect-ratio-syntax-expected.png:
  • platform/chromium-linux/svg/custom/use-transform-expected.checksum:
  • platform/chromium-linux/svg/custom/use-transform-expected.png:
  • platform/chromium-linux/svg/custom/viewbox-syntax-expected.checksum:
  • platform/chromium-linux/svg/custom/viewbox-syntax-expected.png:
  • platform/chromium-linux/svg/text/text-text-06-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-06-t-expected.png:
10:40 AM QtWebKit edited by Ademar Reis
(diff)
10:39 AM QtWebKitRelease21 edited by Ademar Reis
(diff)
10:24 AM Changeset in webkit [76699] by podivilov@chromium.org
  • 3 edits
    2 adds in trunk

2011-01-25 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: evaluate in console may not work when window.console is substituted or deleted.
​https://bugs.webkit.org/show_bug.cgi?id=53072

  • inspector/console-substituted-expected.txt: Added.
  • inspector/console-substituted.html: Added.

2011-01-25 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: evaluate in console may not work when window.console is substituted or deleted.
​https://bugs.webkit.org/show_bug.cgi?id=53072

Test: inspector/console-substituted.html

  • inspector/InjectedScriptSource.js: (.):
10:20 AM Changeset in webkit [76698] by rniwa@webkit.org
  • 2 edits
    6 adds in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <​rniwa@webkit.org>

Layout test missing expectation after 58524
​https://bugs.webkit.org/show_bug.cgi?id=38360

Unreviewed; Chromium rebaselines.

  • platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.checksum: Added.
  • platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.png: Added.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.checksum: Added.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.png: Added.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.txt: Added.
  • platform/chromium-win/svg/carto.net/tabgroup-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:17 AM Changeset in webkit [76697] by Carlos Garcia Campos
  • 4 edits
    3 adds in trunk

2011-01-26 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[cairo] Use CAIRO_OPERATOR_DARKEN when available
​https://bugs.webkit.org/show_bug.cgi?id=53084

  • platform/gtk/Skipped: Unskip test.
  • platform/gtk/fast/canvas/canvas-composite-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvas-composite-expected.png: Added.
  • platform/gtk/fast/canvas/canvas-composite-expected.txt: Added.

2011-01-26 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[cairo] Use CAIRO_OPERATOR_DARKEN when available
​https://bugs.webkit.org/show_bug.cgi?id=53084

Use CAIRO_OPERATOR_DARKEN for CompositePlusDarker instead of
CAIRO_OPERATOR_SATURATE when building with cairo version >= 1.10.

  • platform/graphics/cairo/CairoUtilities.cpp: (WebCore::toCairoOperator):
10:09 AM Changeset in webkit [76696] by kov@webkit.org
  • 2 edits in trunk/Websites/planet.webkit.org

2011-01-26 Gustavo Noronha Silva <Gustavo Noronha Silva>

Rubber-stamped by Andreas Kling.

Fix my blog's feed URL, since it seems to have changed with the
new version of Wordpress causing unwanted posts to appear in
Planet WebKit.

  • config.ini:
10:08 AM QtWebKitFeatures21 edited by Ademar Reis
(diff)
10:07 AM Changeset in webkit [76695] by rniwa@webkit.org
  • 39 edits
    2 adds in trunk/LayoutTests

2011-01-26 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium rebaselines for r76688.

  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-linux/fast/backgrounds/svg-as-background-5-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/svg-as-background-5-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-33-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-linux/svg/custom/focus-ring-expected.checksum:
  • platform/chromium-linux/svg/custom/focus-ring-expected.png:
  • platform/chromium-linux/svg/custom/svg-curve-with-relative-cordinates-expected.checksum:
  • platform/chromium-linux/svg/custom/svg-curve-with-relative-cordinates-expected.png:
  • platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.checksum: Added.
  • platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.checksum:
  • platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.png:
  • platform/chromium-win/fast/images/animated-svg-as-image-expected.checksum:
  • platform/chromium-win/fast/images/animated-svg-as-image-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-33-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/chromium-win/svg/custom/focus-ring-expected.checksum:
  • platform/chromium-win/svg/custom/focus-ring-expected.png:
  • platform/chromium-win/svg/custom/svg-curve-with-relative-cordinates-expected.checksum:
  • platform/chromium-win/svg/custom/svg-curve-with-relative-cordinates-expected.png:
  • platform/chromium-win/svg/custom/use-css-events-expected.checksum:
  • platform/chromium-win/svg/custom/use-css-events-expected.png:
  • platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.checksum:
  • platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.checksum:
  • platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
9:56 AM Changeset in webkit [76694] by Csaba Osztrogonác
  • 4 edits in trunk

[Qt] Fix qt_minimal build
​https://bugs.webkit.org/show_bug.cgi?id=53172

Reviewed by Andreas Kling.

  • Source/WebKit.pri:
  • Tools/QtTestBrowser/locationedit.h:
9:41 AM QtWebKitFeatures22 edited by Ademar Reis
(diff)
9:38 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
9:34 AM QtWebKitRelease21 edited by Ademar Reis
(diff)
9:32 AM Changeset in webkit [76693] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-01-26 Mansi Mithal <​mansi.mithal@nokia.com>

Reviewed by Antonio Gomes.

QtTestBrowser should have a UI Setting to disable plugins
​https://bugs.webkit.org/show_bug.cgi?id=52408

Added a new action item named "Disable Plugins"
under the "Settings" menu.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): (LauncherWindow::togglePlugins):
  • QtTestBrowser/launcherwindow.h:
9:19 AM Changeset in webkit [76692] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-26 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: visualize \n in strings as unicode cr
symbol in stack variables sidebar.
​https://bugs.webkit.org/show_bug.cgi?id=53162

  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.update):
8:24 AM Changeset in webkit [76691] by caseq@chromium.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Unreviewed: fixed bug summary in ChangeLog entry for r76690.

8:06 AM Changeset in webkit [76690] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-26 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: summary bar is not resized properly with the rest of network panel

  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didReceiveResponse):
  • inspector/front-end/Resource.js: (WebInspector.Resource): (WebInspector.Resource.prototype.get transferSize): (WebInspector.Resource.prototype.set responseHeaders): (WebInspector.Resource.prototype._headersSize): (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
7:51 AM Changeset in webkit [76689] by carol.szabo@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-26 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by Simon Hausmann.

Fixed TiledBacking store to take into account new dirty regions caused by
paint time layouts.

Flawed rendering design for QtWebKit resulting in artifacts being displayed
​https://bugs.webkit.org/show_bug.cgi?id=49184

There are no new tests as this patch aims at fixing flicker that
happen randomly, mostly on slow hardware, thus are hard to reproduce
consistently in an automated test.

This patch does not fully address the said bug but it is a step in the
right direction. A full solution to the bug, as currently perceived,
requires either a Qt GUI API change, a performance hit for QtWebKit,
or a hack, until a full solution is provided this patch is progress.

  • platform/graphics/TiledBackingStore.cpp: (WebCore::TiledBackingStore::updateTileBuffers): Changed to take into account newly dirtied areas created during tile update initiated layouts during the same update.
6:50 AM Changeset in webkit [76688] by Patrick Gansterer
  • 6 edits in trunk/Source/WebCore

2011-01-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[SKIA] Remove "current path" of GraphicsContext
​https://bugs.webkit.org/show_bug.cgi?id=53124

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath):
  • platform/graphics/skia/PathSkia.cpp: (WebCore::Path::strokeBoundingRect):
  • platform/graphics/skia/PlatformContextSkia.cpp:
  • platform/graphics/skia/PlatformContextSkia.h:
6:11 AM Changeset in webkit [76687] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WINCE] Add JIT support to build system
​https://bugs.webkit.org/show_bug.cgi?id=53079

  • CMakeListsWinCE.txt:
6:09 AM Changeset in webkit [76686] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-26 Zalan Bujtas <​zbujtas@gmail.com>

Reviewed by Andreas Kling.

[Qt] Path::normalAngleAtLength() returns incorrect value on ACID3.

QPainterPath returns angle values with the origo being at the top left corner,
we need to account for this in normalAngleAtLength().
This Regressed with r66979.

No new tests as this is already covered by ACID3.

  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::normalAngleAtLength):
5:06 AM Changeset in webkit [76685] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-26 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Andreas Kling.

Skip a test for WebKit2 that uses eventSender
​https://bugs.webkit.org/show_bug.cgi?id=53168

  • platform/mac-wk2/Skipped:
3:43 AM Changeset in webkit [76684] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/cf

2011-01-26 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector should start in attached state by default
​https://bugs.webkit.org/show_bug.cgi?id=53165

  • WebCoreSupport/WebInspectorClientCF.cpp: (WebInspectorClient::inspectorStartsAttached):
3:39 AM Changeset in webkit [76683] by pfeldman@chromium.org
  • 9 edits in trunk

2011-01-26 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: inspector tests fix.

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.evaluateInPage):
  • inspector/console-format.html:
2:26 AM Changeset in webkit [76682] by Carlos Garcia Campos
  • 2 edits
    63 adds in trunk/LayoutTests

2011-01-26 Carlos Garcia Campos <​cgarcia@igalia.com>

Unreviewed, unskip passing canvas tests in GTK port.

  • platform/gtk/Skipped: Unskip passing canvas tests.
  • platform/gtk/fast/canvas/arc360-expected.checksum: Added.
  • platform/gtk/fast/canvas/arc360-expected.png: Added.
  • platform/gtk/fast/canvas/arc360-expected.txt: Added.
  • platform/gtk/fast/canvas/canvas-as-image-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvas-as-image-expected.png: Added.
  • platform/gtk/fast/canvas/canvas-as-image-expected.txt: Added.
  • platform/gtk/fast/canvas/canvas-as-image-incremental-repaint-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Added.
  • platform/gtk/fast/canvas/canvas-as-image-incremental-repaint-expected.txt: Added.
  • platform/gtk/fast/canvas/canvas-before-css-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvas-before-css-expected.png: Added.
  • platform/gtk/fast/canvas/canvas-before-css-expected.txt: Added.
  • platform/gtk/fast/canvas/canvas-bg-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvas-bg-expected.png: Added.
  • platform/gtk/fast/canvas/canvas-bg-expected.txt: Added.
  • platform/gtk/fast/canvas/canvas-bg-zoom-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvas-bg-zoom-expected.png: Added.
  • platform/gtk/fast/canvas/canvas-bg-zoom-expected.txt: Added.
  • platform/gtk/fast/canvas/canvas-incremental-repaint-2-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvas-incremental-repaint-2-expected.png: Added.
  • platform/gtk/fast/canvas/canvas-incremental-repaint-2-expected.txt: Added.
  • platform/gtk/fast/canvas/canvas-resize-reset-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvas-resize-reset-expected.png: Added.
  • platform/gtk/fast/canvas/canvas-resize-reset-expected.txt: Added.
  • platform/gtk/fast/canvas/canvas-size-change-after-layout-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvas-size-change-after-layout-expected.png: Added.
  • platform/gtk/fast/canvas/canvas-size-change-after-layout-expected.txt: Added.
  • platform/gtk/fast/canvas/canvas-text-baseline-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvas-text-baseline-expected.png: Added.
  • platform/gtk/fast/canvas/canvas-text-baseline-expected.txt: Added.
  • platform/gtk/fast/canvas/canvas-transforms-during-path-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvas-transforms-during-path-expected.png: Added.
  • platform/gtk/fast/canvas/canvas-transforms-during-path-expected.txt: Added.
  • platform/gtk/fast/canvas/canvasDrawingIntoSelf-expected.checksum: Added.
  • platform/gtk/fast/canvas/canvasDrawingIntoSelf-expected.png: Added.
  • platform/gtk/fast/canvas/canvasDrawingIntoSelf-expected.txt: Added.
  • platform/gtk/fast/canvas/drawImage-expected.checksum: Added.
  • platform/gtk/fast/canvas/drawImage-expected.png: Added.
  • platform/gtk/fast/canvas/drawImage-expected.txt: Added.
  • platform/gtk/fast/canvas/drawImage-with-globalAlpha-expected.checksum: Added.
  • platform/gtk/fast/canvas/drawImage-with-globalAlpha-expected.png: Added.
  • platform/gtk/fast/canvas/drawImage-with-globalAlpha-expected.txt: Added.
  • platform/gtk/fast/canvas/fill-stroke-clip-reset-path-expected.checksum: Added.
  • platform/gtk/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
  • platform/gtk/fast/canvas/fill-stroke-clip-reset-path-expected.txt: Added.
  • platform/gtk/fast/canvas/fillrect-gradient-zero-stops-expected.checksum: Added.
  • platform/gtk/fast/canvas/fillrect-gradient-zero-stops-expected.png: Added.
  • platform/gtk/fast/canvas/fillrect-gradient-zero-stops-expected.txt: Added.
  • platform/gtk/fast/canvas/fillrect_gradient-expected.checksum: Added.
  • platform/gtk/fast/canvas/fillrect_gradient-expected.png: Added.
  • platform/gtk/fast/canvas/fillrect_gradient-expected.txt: Added.
  • platform/gtk/fast/canvas/gradient-add-second-start-end-stop-expected.checksum: Added.
  • platform/gtk/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
  • platform/gtk/fast/canvas/gradient-add-second-start-end-stop-expected.txt: Added.
  • platform/gtk/fast/canvas/image-object-in-canvas-expected.checksum: Added.
  • platform/gtk/fast/canvas/image-object-in-canvas-expected.png: Added.
  • platform/gtk/fast/canvas/image-object-in-canvas-expected.txt: Added.
  • platform/gtk/fast/canvas/quadraticCurveTo-expected.checksum: Added.
  • platform/gtk/fast/canvas/quadraticCurveTo-expected.png: Added.
  • platform/gtk/fast/canvas/quadraticCurveTo-expected.txt: Added.
  • platform/gtk/fast/canvas/zero-size-fill-rect-expected.checksum: Added.
  • platform/gtk/fast/canvas/zero-size-fill-rect-expected.png: Added.
  • platform/gtk/fast/canvas/zero-size-fill-rect-expected.txt: Added.
2:24 AM Changeset in webkit [76681] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-26 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: live edit does not update source snippet.
​https://bugs.webkit.org/show_bug.cgi?id=53097

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
2:19 AM Changeset in webkit [76680] by pfeldman@chromium.org
  • 13 edits in trunk/Source/WebCore

2011-01-26 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Incorrect on-hover evaluation of a variable named 'profile'.
​https://bugs.webkit.org/show_bug.cgi?id=53018

  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::evaluate): (WebCore::InjectedScript::evaluateOnCallFrame): (WebCore::InjectedScript::getCompletions): (WebCore::InjectedScript::getCompletionsOnCallFrame):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js: (.):
  • inspector/Inspector.idl:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::evaluate): (WebCore::InspectorRuntimeAgent::getCompletions):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype.evalInInspectedWindow): (WebInspector.ConsoleView.prototype._enterKeyPressed):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper): (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):
2:12 AM Changeset in webkit [76679] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-26 Hironori Bono <​hbono@chromium.org>

Reviewed by Kent Tamura.

A speculative fix for Bug 52422 - [chromium] More crash in
FontFallbackList::determinePitch(const Font* font)
​https://bugs.webkit.org/show_bug.cgi?id=52422

My previous change may not work on non-US Windows whose system fonts
have localized aliases matching to the system locale because of a
font-name mismatch in createFontIndirectAndGetWinName(). This change
tries all the fonts installed in a PC and returns the first font that we
can create without errors.

  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData): Added a struct used for getLastResortFallbackFontProc(). (WebCore::getLastResortFallbackFontProc): Added a callback for EnumFontFamilies(). (WebCore::FontCache::getLastResortFallbackFont): Use EnumFontFamilies() to find a last-resort font.
1:42 AM Changeset in webkit [76678] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-01-26 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

Mark some complex script tests as failing since r76674.

  • platform/chromium/test_expectations.txt:
1:18 AM Changeset in webkit [76677] by commit-queue@webkit.org
  • 12 edits
    3 adds in trunk

2011-01-26 James Robinson <​jamesr@chromium.org>

Reviewed by Nate Chapin.

Add a DOMTimeStamp parameter to the requestAnimationFrame callback
​https://bugs.webkit.org/show_bug.cgi?id=53142

Adds a test for the parameter passed to the requestAnimationFrame callback.

  • fast/animation/request-animation-frame-timestamps-expected.txt: Added.
  • fast/animation/request-animation-frame-timestamps.html: Added.
  • fast/animation/script-tests/request-animation-frame-timestamps.js: Added.

2011-01-26 James Robinson <​jamesr@chromium.org>

Reviewed by Nate Chapin.

Add a DOMTimeStamp parameter to the requestAnimationFrame callback
​https://bugs.webkit.org/show_bug.cgi?id=53142

This adds a DOMTimeStamp parameter to the requestAnimationFrame callback to more
closely match mozilla's proposal. This is useful if the page has multiple imperative animations
and wants to ensure that they all remain synchronized. If each callback used Date.now() to
update its animation state, they would potentially be out of sync with each other. If they use
the timestamp then all callbacks for the same "frame" will update to the same state.

Test: fast/animation/request-animation-frame-timestamps.html

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/V8/V8TestCallback.cpp: (WebCore::V8TestCallback::callbackWithClass2Param):
  • dom/Document.cpp: (WebCore::Document::serviceScriptedAnimations):
  • dom/Document.h:
  • dom/RequestAnimationFrameCallback.h:
  • dom/RequestAnimationFrameCallback.idl:
  • page/FrameView.cpp: (WebCore::FrameView::serviceScriptedAnimations):
  • page/FrameView.h:

2011-01-26 James Robinson <​jamesr@chromium.org>

Reviewed by Nate Chapin.

Add a DOMTimeStamp parameter to the requestAnimationFrame callback
​https://bugs.webkit.org/show_bug.cgi?id=53142

Provides a timestamp to use for imperative animation callbacks. In this patch the timestamp is
just the current time at the start of the callback invocation algorithm. In the future we
could enhance this to try to take the compositing delay into effect to try to synchronize
imperative animations more closely with declarative ones, but this should do for now.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::animate):

Jan 25, 2011:

11:58 PM Changeset in webkit [76676] by yuzo@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-25 Yuzo Fujishima <​yuzo@google.com>

Unreviewed attempt to fix compilation error for Chromium Clang.

  • platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::advance):
11:17 PM Changeset in webkit [76675] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-01-25 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change

Mark fast/text/offsetForPosition-complex-fallback.html as failing for WIN and LINUX.

  • platform/chromium/test_expectations.txt:
10:08 PM Changeset in webkit [76674] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

2011-01-25 Ned Holbrook <​nholbrook@apple.com>

Reviewed by Dan Bernstein.

ComplexTextController incorrectly conflates string length and range of indexes
​https://bugs.webkit.org/show_bug.cgi?id=52760

  • fast/text/offsetForPosition-complex-fallback-expected.txt: Added.
  • fast/text/offsetForPosition-complex-fallback.html: Added.

2011-01-25 Ned Holbrook <​nholbrook@apple.com>

Reviewed by Dan Bernstein.

ComplexTextController incorrectly conflates string length and range of indexes
​https://bugs.webkit.org/show_bug.cgi?id=52760

Test: fast/text/offsetForPosition-complex-fallback.html

  • platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::offsetForPosition): (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): (WebCore::ComplexTextController::ComplexTextRun::setIsNonMonotonic): (WebCore::ComplexTextController::advance):
  • platform/graphics/mac/ComplexTextController.h: (WebCore::ComplexTextController::ComplexTextRun::create): (WebCore::ComplexTextController::ComplexTextRun::indexEnd):
  • platform/graphics/mac/ComplexTextControllerATSUI.cpp: (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
  • platform/graphics/mac/ComplexTextControllerCoreText.cpp: (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
9:41 PM Changeset in webkit [76673] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Make this test a bit more robust agains different scrollbar widths.

  • fast/overflow/overflow-rtl-vertical-origin.html:
9:15 PM Changeset in webkit [76672] by sfalken@apple.com
  • 2 edits in tags/Safari-534.16.2/Source/WebKit/win

Merge r76671.

9:13 PM Changeset in webkit [76671] by sfalken@apple.com
  • 2 edits in trunk/Source/WebKit/win

Windows production build fix.
Build correct configuration of Interfaces for Debug_All.

  • WebKit.vcproj/WebKit.submit.sln:
9:04 PM Changeset in webkit [76670] by sfalken@apple.com
  • 2 edits in tags/Safari-534.16.2/Source/WebCore

Merge r76665.

9:02 PM Changeset in webkit [76669] by weinig@apple.com
  • 3 edits
    2 adds in trunk

Scrollbars don't work correctly for top-to-bottom text in an overflow: scroll area
​https://bugs.webkit.org/show_bug.cgi?id=53048

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/overflow/overflow-rtl-vertical-origin.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollPosition):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
Take the scroll origin into account when calculating scrollbars in more places.

LayoutTests:

  • fast/overflow/overflow-rtl-vertical-origin-expected.txt: Added.
  • fast/overflow/overflow-rtl-vertical-origin.html: Added.
8:50 PM Changeset in webkit [76668] by tkent@chromium.org
  • 7 edits
    3 adds in trunk

2011-01-25 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.checksum: Added.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Added.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Added.
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.checksum:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium/test_expectations.txt:

2011-01-25 Kent Tamura <​tkent@chromium.org>

Unreviewed trivial change.

  • DEPS: Roll to r72581 to have a webkit_support fix.
8:47 PM Changeset in webkit [76667] by sfalken@apple.com
  • 5 edits in tags/Safari-534.16.2/Source

Versioning.

8:40 PM Changeset in webkit [76666] by sfalken@apple.com
  • 1 copy in tags/Safari-534.16.2

New tag.

8:39 PM Changeset in webkit [76665] by sfalken@apple.com
  • 2 edits in trunk/Source/WebCore

Windows production build fix.
Use correct configuration-specific path in makefile.

  • WebCore.vcproj/WebCore.make:
8:18 PM Changeset in webkit [76664] by tkent@chromium.org
  • 10 edits
    2 adds in trunk

Radio button group state is not restored correctly
​https://bugs.webkit.org/show_bug.cgi?id=50442

Reviewed by Dimitri Glazkov.

Source/WebCore:

Fixes a bug that radio button states are not restored correctly in
a case that non-first radio button in a group is checked.

If "checked" attribute is present, the radio button is checked and
other radio buttons in the group are unchecked. This behavior
disturbs form state restoring. This patch changes this behavior so
that the "checked" attribute handling is delayed after form state
restoring.

Test: fast/forms/state-restore-radio-group.html

  • html/HTMLFormControlElement.h: Make finishParsingChildren() protected so that HTMLInpuElement can call it.
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):

  • Add createdByParser parameter.
  • Initialize m_stateRestored and m_parsingInProgress.

(WebCore::HTMLInputElement::create): Sync with the constructor.
(WebCore::HTMLInputElement::restoreFormControlState):

Set m_stateRestored in order to refer it in finishParsingChildren().

(WebCore::HTMLInputElement::parseMappedAttribute):

Don't call setChecked() during parsing. Move setNeedsValidityCheck()
to setChecked().

(WebCore::HTMLInputElement::finishParsingChildren):

Call setChecked() if form state is not restored.

(WebCore::HTMLInputElement::setChecked):

Move setNeedsValidityCheck() from parseMappedAttribute() because
finishParsingChildren() also needs to call setNeedsValidityCheck().

  • html/HTMLInputElement.h:
    • Remove the default value of HTMLFormElement* of the HTMLInputElement constructor, and add createdByParser parameter.
    • Introduce m_parsingInProgress and m_stateRestored.
  • html/HTMLIsIndexElement.cpp:

(WebCore::HTMLIsIndexElement::HTMLIsIndexElement):

Sync with the HTMLInputElement constructor change.

  • html/HTMLTagNames.in: Add constructorNeedsCreatedByParser flag.
  • rendering/MediaControlElements.cpp:

(WebCore::MediaControlInputElement::MediaControlInputElement):

Sync with the HTMLInputElement constructor change.

  • rendering/ShadowElement.cpp:

(WebCore::ShadowInputElement::ShadowInputElement): ditto.

  • rendering/ShadowElement.h:

(WebCore::ShadowElement::ShadowElement): ditto.

LayoutTests:

  • fast/forms/state-restore-radio-group-expected.txt: Added.
  • fast/forms/state-restore-radio-group.html: Added.
8:00 PM Changeset in webkit [76663] by tkent@chromium.org
  • 10 edits in trunk

HTMLFormElement::checkValidity() returns incorrect result if 'invalid' events are canceled.
​https://bugs.webkit.org/show_bug.cgi?id=52565

Reviewed by Dimitri Glazkov.

Source/WebCore:

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

Check checkInvalidControlsAndCollectUnhandled() result instead of
checking emptiness of unhandled invalid controls list.

(WebCore::HTMLFormElement::checkValidity): ditto.
(WebCore::HTMLFormElement::checkInvalidControlsAndCollectUnhandled):

Renamed from collectUnhandledInvalidControls().
Returns true if there is any invalid control regardless of event canceling.

  • html/HTMLFormElement.h: Rename collectUnhandledInvalidControls() to checkInvalidControlsAndCollectUnhandled().

LayoutTests:

Fix tests and results for the behavior change.

  • fast/forms/checkValidity-cancel-expected.txt:
  • fast/forms/checkValidity-handler-updates-dom-expected.txt:
  • fast/forms/interactive-validation-cancel-expected.txt:
  • fast/forms/interactive-validation-cancel.html:
  • fast/forms/script-tests/checkValidity-cancel.js:
  • fast/forms/script-tests/checkValidity-handler-updates-dom.js:
7:50 PM Changeset in webkit [76662] by tkent@chromium.org
  • 10 edits in trunk

2011-01-25 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Range and number inputs should reject increment and decrement by
keyboard or mouse wheel if they are disabled or read-only
​https://bugs.webkit.org/show_bug.cgi?id=53151

Add checks for 'disabled' and 'readOnly'.

  • fast/forms/input-number-keyoperation-expected.txt:
  • fast/forms/input-number-wheel-expected.txt:
  • fast/forms/range-keyoperation-expected.txt:
  • fast/forms/range-keyoperation.html:
  • fast/forms/script-tests/input-number-keyoperation.js:
  • fast/forms/script-tests/input-number-wheel.js:

2011-01-25 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Range and number inputs should reject increment and decrement by
keyboard or mouse wheel if they are disabled or read-only
​https://bugs.webkit.org/show_bug.cgi?id=53151

  • html/RangeInputType.cpp: (WebCore::RangeInputType::handleKeydownEvent): Check disabled() and readOnly().
  • html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::handleKeydownEventForSpinButton): ditto. (WebCore::TextFieldInputType::handleWheelEventForSpinButton): ditto.
7:44 PM Changeset in webkit [76661] by tkent@chromium.org
  • 17 edits
    2 adds in trunk/Source/WebCore

API to support localized numbers for <input type=number>
​https://bugs.webkit.org/show_bug.cgi?id=45730

Reviewed by Dimitri Glazkov.

Introduce platform/text/LocalizedNumber.h, and
LocalizedNumberNone.cpp, which is an empty implementation of the
functions in LocalizedNumber.h. We use LocalizedNumberNone.cpp in
all platforms for now.

A string in a type=number field is parsed as a localized number
first. If the parsing fails, it is parsed as the HTML5 number.

We introduce HTMLInputElement::visibleValue(). It represents a value
which should be drawn by a renderer. HTMLInputElement::value() always
returns a number formatted for HTML5, and visibleValue() may return a
localized number.

No new tests because this doesn't change any behavior.

  • Android.mk: Add LocalizedNumber.h and/or LocalizedNumberNone.cpp.
  • CMakeLists.txt: ditto.
  • GNUmakefile.am: ditto.
  • WebCore.gypi: ditto.
  • WebCore.pro: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • dom/InputElement.h: Add visibleValue().
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::visibleValue): Added. Just call InputType::visibleValue().

  • html/HTMLInputElement.h: Declare visibleValue().
  • html/InputType.cpp:

(WebCore::InputType::visibleValue): Add the default implementation of

visibleValue(), which returns HTMLInputElement::value().

  • html/InputType.h: Add declarations.
  • html/NumberInputType.cpp:

(WebCore::isHTMLNumberCharacter): Renamed from isNumberCharacter().
(WebCore::isNumberCharacter): Calls isLocalizedNumberCharacter() and isHTMLNumberCharacter().
(WebCore::NumberInputType::visibleValue):

Returns a localized number string produced by formatLocalizedNumber().

(WebCore::NumberInputType::isAcceptableValue): Calls parseLocalizedNumber().
(WebCore::NumberInputType::sanitizeValue): Calls parseLocalizedNumber().

  • html/NumberInputType.h: Add declarations.
  • platform/text/LocalizedNumber.h: Added.
  • platform/text/LocalizedNumberNone.cpp: Added.

(WebCore::parseLocalizedNumber):
(WebCore::formatLocalizedNumber):
(WebCore::isLocalizedNumberCharacter):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::updateFromElement):

Calls InputElement::visibleValue() instead of value().

  • wml/WMLInputElement.h:

(WebCore::WMLInputElement::visibleValue): Added. It just calls value().

7:29 PM Changeset in webkit [76660] by ap@apple.com
  • 3 edits
    1 add in trunk/Source/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=53143
Add IntRectHash

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/IntRectHash.h: Added.
  • platform/graphics/IntSizeHash.h: Don't do "using WebCore::IntSize"!
7:19 PM Changeset in webkit [76659] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-25 Ilya Sherman <​isherman@chromium.org>

Reviewed by Ryosuke Niwa.

Remove trailing whitespace in HTMLInputElement.cpp
​https://bugs.webkit.org/show_bug.cgi?id=53152

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateCheckedRadioButtons): (WebCore::HTMLInputElement::applyStep): (WebCore::HTMLInputElement::updateFocusAppearance): (WebCore::HTMLInputElement::mapToEntry): (WebCore::HTMLInputElement::setAutofilled): (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): (WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
6:13 PM Changeset in webkit [76658] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-25 Mike Reed <​reed@google.com>

Reviewed by James Robinson.

DrawingBufer::reset() today checks if the new size is the same as its
m_size, and if so, returns immediately. This does not match the
semantics of <canvas>, which wants to clear its contents anytime the
size is specified.
​https://bugs.webkit.org/show_bug.cgi?id=53149

Test: Covered by existing <canvas> tests using gpu.

  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer):
  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::reset):
5:54 PM Changeset in webkit [76657] by Chris Fleizach
  • 10 edits in trunk/Source/WebKit2

WK2 leaks when a page is closed
​https://bugs.webkit.org/show_bug.cgi?id=53100

Reviewed by Darin Adler.

Allow the WKView a chance to clean up on a page close. In this case,
cleaning up means removing the references the accessibility token has
to the window.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::pageClosed):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setRemoteAccessibilityWindow:]):
(-[WKView _setAccessibilityChildToken:]):
(-[WKView _processDidCrash]):
(-[WKView _pageClosed]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/qt/qwkpage_p.h:

(QWKPagePrivate::pageClosed):

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::pageClosed):

  • UIProcess/win/WebView.h:
5:17 PM Changeset in webkit [76656] by Patrick Gansterer
  • 3 edits
    2 moves in trunk

2011-01-25 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Move main CMakeLists.txt into Source directory
​https://bugs.webkit.org/show_bug.cgi?id=52888

  • CMakeLists.txt: Removed.
  • Source/CMakeLists.txt: Copied from CMakeLists.txt.
  • Source/cmakeconfig.h.cmake: Copied from cmakeconfig.h.cmake.
  • cmakeconfig.h.cmake: Removed.

2011-01-25 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Move main CMakeLists.txt into Source directory
​https://bugs.webkit.org/show_bug.cgi?id=52888

  • Scripts/webkitdirs.pm:
5:07 PM CSS21Results edited by tabatkins@google.com
(diff)
4:50 PM Changeset in webkit [76655] by Patrick Gansterer
  • 2 edits in trunk/Tools

2011-01-25 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Improve label text in submit-to-ews
​https://bugs.webkit.org/show_bug.cgi?id=53130

  • QueueStatusServer/templates/submittoews.html:
4:39 PM CSS21Results edited by tabatkins@google.com
(diff)
4:36 PM Changeset in webkit [76654] by cmarrin@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-01-25 Chris Marrin <​cmarrin@apple.com>

Reviewed by Adam Roben.

Expose WebGL flag set/get in WK2
​https://bugs.webkit.org/show_bug.cgi?id=53096

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetWebGLEnabled): (WKPreferencesGetWebGLEnabled):
  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
4:23 PM CSS21Results edited by Simon Fraser
(diff)
4:18 PM Changeset in webkit [76653] by andersca@apple.com
  • 5 edits
    1 add in trunk/Source/WebKit2

2011-01-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Add and implement LayerTreeHost::scheduleLayerFlush
​https://bugs.webkit.org/show_bug.cgi?id=53135

  • WebKit2.xcodeproj/project.pbxproj: Add LayerTreeHostMac.mm.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::scheduleCompositingLayerSync): Call LayerTreeHost::scheduleLayerFlush.
  • WebProcess/WebPage/LayerTreeHost.cpp: (WebKit::LayerTreeHost::~LayerTreeHost): Call platformInvalidate().

(WebKit::LayerTreeHost::flushPendingLayerChanges):
Rename from syncCompositingLayers.

  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: Added. (WebKit::LayerTreeHost::scheduleLayerFlush): Create a run loop observer if needed. This code is copied from LayerBackedDrawingAreaMac.mm

(WebKit::LayerTreeHost::platformInvalidate):
Invalidate the run loop observer.

(WebKit::LayerTreeHost::flushPendingLayerChangesRunLoopObserverCallback):
Call flushPendingChanges() and remove the run loop observer if it succeeded.

4:10 PM Changeset in webkit [76652] by inferno@chromium.org
  • 6 edits
    2 adds in trunk

2011-01-25 Cris Neckar <​cdn@chromium.org>

Reviewed by Adam Barth.

Test for crash when a window's location changes before creating an object URL.
​https://bugs.webkit.org/show_bug.cgi?id=53038

  • fast/dom/window-domurl-crash-expected.txt: Added.
  • fast/dom/window-domurl-crash.html: Added.

2011-01-25 Cris Neckar <​cdn@chromium.org>

Reviewed by Adam Barth.

Add a hashset of DOMURLs to ScriptExecutionContext to track back references.
​https://bugs.webkit.org/show_bug.cgi?id=53038

Test: fast/dom/window-domurl-crash.html

  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::~ScriptExecutionContext): (WebCore::ScriptExecutionContext::createdDomUrl): (WebCore::ScriptExecutionContext::destroyedDomUrl):
  • dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::domUrls):
  • html/DOMURL.cpp: (WebCore::DOMURL::DOMURL): (WebCore::DOMURL::~DOMURL): (WebCore::DOMURL::contextDestroyed):
  • html/DOMURL.h: (WebCore::DOMURL::scriptExecutionContext):
4:07 PM CSS21Results edited by Simon Fraser
(diff)
4:04 PM CSS21Results edited by Simon Fraser
(diff)
3:59 PM CSS21Results edited by Simon Fraser
(diff)
3:47 PM Changeset in webkit [76651] by sfalken@apple.com
  • 2 edits in tags/Safari-534.16.1/Source/JavaScriptCore

Merge r76650.

3:46 PM Changeset in webkit [76650] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Windows Production build fix

Reviewed by Steve Falkenburg.

  • JavaScriptCore.vcproj/JavaScriptCore.make: Set BUILDSTYLE to Release_PGO at the very start

of the file so that ConfigurationBuildDir takes that into account. Also set it the right way
(by redefining the macro) rather than the wrong way (by modifying the environment variable).

3:40 PM Changeset in webkit [76649] by andersca@apple.com
  • 4 edits
    2 adds in trunk/Source/WebKit2

2011-01-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Simon Fraser.

Add LayerTreeHost class
​https://bugs.webkit.org/show_bug.cgi?id=53132

  • WebKit2.xcodeproj/project.pbxproj: Add LayerTreeHost files.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize m_layerTreeHost.

(WebKit::DrawingAreaImpl::setRootCompositingLayer):
Call the m_layerTreeHost.

  • WebProcess/WebPage/LayerTreeHost.cpp: Added. (WebKit::LayerTreeHost::attachRootCompositingLayer): (WebKit::LayerTreeHost::detachRootCompositingLayer): Add stubbed out functions.

(WebKit::LayerTreeHost::syncCompositingLayers):
Sync the compositing layers in the main frame.

  • WebProcess/WebPage/LayerTreeHost.h: Added.
3:31 PM Changeset in webkit [76648] by Antti Koivisto
  • 17 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=52983
Eliminate m_tagHistory pointer from CSSSelector

Reviewed by Darin Adler.

Keep the component selectors in the array in CSSSelectorList instead
of maintaining a linked list between them. This allows eliminating
m_tagHistory pointer, shrinking CSSSelector by 25% (selection performance
seems to improve some too due to better locality).

  • WebCore.xcodeproj/project.pbxproj:


Make CSSSelector.h a private header.


  • css/CSSGrammar.y:


Use CSSParserSelector during parsing to keep the tag history in
a linked list. This is flattened to an array after parsing.
Use accessors for setting selector values.
Use OwnPtr in selector vector.


  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::CSSPageRule):

  • css/CSSPageRule.h:

(WebCore::CSSPageRule::create):

Simplify.


  • css/CSSParser.cpp:

(WebCore::CSSParser::~CSSParser):
(WebCore::CSSParser::createFloatingSelector):
(WebCore::CSSParser::sinkFloatingSelector):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::updateSpecifiersWithElementName):
(WebCore::CSSParser::createPageRule):

  • css/CSSParser.h:

(WebCore::CSSParser::reusableSelectorVector):

CSSSelector -> CSSParserSelector.
Use OwnPtr in selector vector.


  • css/CSSParserValues.cpp:

(WebCore::CSSParserSelector::CSSParserSelector):
(WebCore::CSSParserSelector::~CSSParserSelector):

  • css/CSSParserValues.h:

(WebCore::CSSParserSelector::releaseSelector):
(WebCore::CSSParserSelector::setTag):
(WebCore::CSSParserSelector::setValue):
(WebCore::CSSParserSelector::setAttribute):
(WebCore::CSSParserSelector::setArgument):
(WebCore::CSSParserSelector::setSimpleSelector):
(WebCore::CSSParserSelector::setMatch):
(WebCore::CSSParserSelector::setRelation):
(WebCore::CSSParserSelector::setForPage):
(WebCore::CSSParserSelector::pseudoType):
(WebCore::CSSParserSelector::isUnknownPseudoElement):
(WebCore::CSSParserSelector::isSimple):
(WebCore::CSSParserSelector::tagHistory):
(WebCore::CSSParserSelector::setTagHistory):

Linked list used during parsing.
Avoid recursive destruction.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::extractPseudoType):
(WebCore::CSSSelector::operator==):
(WebCore::CSSSelector::selectorText):
(WebCore::CSSSelector::setSimpleSelector):

  • css/CSSSelector.h:

(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::~CSSSelector):
(WebCore::CSSSelector::tagHistory):
(WebCore::CSSSelector::tag):
(WebCore::CSSSelector::value):
(WebCore::CSSSelector::setTag):
(WebCore::CSSSelector::isLastInTagHistory):
(WebCore::CSSSelector::setNotLastInTagHistory):
(WebCore::CSSSelector::RareData::RareData):
(WebCore::CSSSelector::RareData::~RareData):
(WebCore::CSSSelector::createRareData):
(WebCore::CSSSelector::setValue):

Remove m_tagHistory.
Keep m_value in the union with the rare data pointer instead.
Make m_value and m_tag private, implement accessors.
Add a new bit to indicate end of the tag history (multipart selector).
Eliminate complex destruction. Selectors are now deleted as an array or by a CSSParserSelector chain.


  • css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::adoptSelectorVector):

Flatten everything to an array.


(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):

  • css/CSSSelectorList.h:

(WebCore::CSSSelectorList::hasOneSelector):
(WebCore::CSSSelectorList::next):

Skip over the subparts of multipart selectors to find the next selector.


  • css/CSSStyleRule.h:

(WebCore::CSSStyleRule::adoptSelectorVector):

CSSSelector -> CSSParserSelector.


  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSRuleSet::addRule):
(WebCore::collectIdsAndSiblingRulesFromList):
(WebCore::CSSStyleSelector::matchPageRulesForList):

  • dom/Node.cpp:

(WebCore::Node::querySelector):

  • dom/SelectorNodeList.cpp:

(WebCore::createSelectorNodeList):

Use accessors.

3:25 PM CSS21Results edited by Simon Fraser
(diff)
3:23 PM Changeset in webkit [76647] by sfalken@apple.com
  • 10 edits in tags/Safari-534.16.1/Source

Merge r76638.

3:20 PM Changeset in webkit [76646] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-01-25 Mansi Mithal <​mansi.mithal@nokia.com>

Reviewed by Antonio Gomes.

QtTestBrowser should have a UI Settings to prevent loading images
​https://bugs.webkit.org/show_bug.cgi?id=52409

Added a new action item named "DisableAutoLoadImages"
under the "Settings" menu

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): (LauncherWindow::toggleAutoLoadImages):
  • QtTestBrowser/launcherwindow.h:
3:08 PM Changeset in webkit [76645] by sfalken@apple.com
  • 2 edits in tags/Safari-534.16.1/Source/JavaScriptCore

Merge r76598.

3:07 PM Changeset in webkit [76644] by simonjam@chromium.org
  • 5 edits
    5 adds in trunk

2011-01-25 James Simonsen <​simonjam@chromium.org>

Reviewed by Tony Chang.

[Chromium] Support small caps in complex text on linux
​https://bugs.webkit.org/show_bug.cgi?id=53051

  • platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.checksum: Added.
  • platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.png: Added.
  • platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.txt: Added.
  • platform/chromium-linux/fast/text/atsui-small-caps-punctuation-size-expected.checksum: Added.
  • platform/chromium-linux/fast/text/atsui-small-caps-punctuation-size-expected.png: Added.
  • platform/chromium/test_expectations.txt: Re-enable 2 tests on linux.

2011-01-25 James Simonsen <​simonjam@chromium.org>

Reviewed by Tony Chang.

[Chromium] Support small caps in complex text on linux
​https://bugs.webkit.org/show_bug.cgi?id=53051

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::nextScriptRun): Break runs at small caps boundaries. (WebCore::ComplexTextController::setupFontForScriptRun): Setup small caps font data if needed.
  • platform/graphics/chromium/ComplexTextControllerLinux.h: Store small caps text in separate string.
3:02 PM Changeset in webkit [76643] by sfalken@apple.com
  • 8 edits in tags/Safari-534.16.1/Source

Merge r76546.

2:58 PM Applications using WebKit edited by munk666@o2.pl
added Kadu (diff)
2:52 PM Changeset in webkit [76642] by dpranke@chromium.org
  • 10 edits in trunk/Tools

2011-01-25 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Tony Chang.

Minor bug fixes and cleanup for filesystem wrappers, port/* test
classes, test_expectations.py. This change adds "test-win" and
"test-mac" variants to the test port so that we can better test
rebaselining, and adds a MockUser() object for reuse in testing.

​https://bugs.webkit.org/show_bug.cgi?id=53036

  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
2:31 PM Changeset in webkit [76641] by sfalken@apple.com
  • 5 edits in tags/Safari-534.16.1/Source

Versioning.

2:23 PM Changeset in webkit [76640] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed build fix: add failing test to gtk/Skipped.

  • platform/gtk/Skipped:
2:05 PM Changeset in webkit [76639] by sfalken@apple.com
  • 1 copy in tags/Safari-534.16.1

New tag.

1:49 PM Changeset in webkit [76638] by sfalken@apple.com
  • 10 edits in trunk/Source

Windows production build fix.
Use correct environment variable escaping

Rubber-stamped by Adam Roben.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.vcproj/WebCore.make:

Source/WebKit/win:

  • WebKit.vcproj/WebKit.make:

Source/WebKit2:

  • win/WebKit2.make:
  • win/WebKit2Generated.make:
1:29 PM Changeset in webkit [76637] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-25 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Empty URLs are never display isolated
​https://bugs.webkit.org/show_bug.cgi?id=53053

This check mirrors the check in the local case. There isn't a good way
to test this with a LayoutTest, but it is tested in Chromium (where
this registry is used).

  • platform/SchemeRegistry.cpp: (WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):
1:14 PM Changeset in webkit [76636] by weinig@apple.com
  • 5 edits in trunk/Source

2011-01-25 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Pipe a timestamp down into the PlatformWheelEvent for the Mac.
​https://bugs.webkit.org/show_bug.cgi?id=53111

  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::PlatformWheelEvent): (WebCore::PlatformWheelEvent::timestamp): Add timestamp member.
  • platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent): Initialize the timestamp from the event.

2011-01-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Don't inform the UI process about compositing changes when using the new drawing area
​https://bugs.webkit.org/show_bug.cgi?id=53120

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::changeAcceleratedCompositingMode): Return early if we're using the new drawing area.

(WebKit::WebPage::exitAcceleratedCompositingMode):
Call setRootCompositingLayer(0) so the drawing area knows when we leave accelerated compositing.

1:13 PM Changeset in webkit [76635] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-25 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

JSON.stringify processing time exponentially grows with size of object
​https://bugs.webkit.org/show_bug.cgi?id=51922

Remove last use of reserveCapacity from JSON stringification, as it results
in appalling append behaviour when there are a large number of property names
and nothing else.

  • runtime/JSONObject.cpp: (JSC::Stringifier::appendQuotedString):
1:11 PM Changeset in webkit [76634] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Don't inform the UI process about compositing changes when using the new drawing area
​https://bugs.webkit.org/show_bug.cgi?id=53120

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::changeAcceleratedCompositingMode): Return early if we're using the new drawing area.

(WebKit::WebPage::exitAcceleratedCompositingMode):
Call setRootCompositingLayer(0) so the drawing area knows when we leave accelerated compositing.

1:08 PM Changeset in webkit [76633] by rniwa@webkit.org
  • 5 edits
    8 deletes in trunk

2011-01-25 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r76625.
​http://trac.webkit.org/changeset/76625
​https://bugs.webkit.org/show_bug.cgi?id=53119

"incorrect pixel test results" (Requested by rniwa on
#webkit).

  • rendering/RenderBox.cpp: (WebCore::RenderBox::localCaretRect):

2011-01-25 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r76625.
​http://trac.webkit.org/changeset/76625
​https://bugs.webkit.org/show_bug.cgi?id=53119

"incorrect pixel test results" (Requested by rniwa on
#webkit).

  • editing/selection/caret-painting-after-paste-undo-rtl.html: Removed.
  • editing/selection/caret-painting-after-paste-undo.html: Removed.
  • platform/mac/editing/deleting/5408255-expected.checksum:
  • platform/mac/editing/deleting/5408255-expected.png:
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Removed.
1:05 PM Changeset in webkit [76632] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-25 Tony Chang <​tony@chromium.org>

Unreviewed, debugger-scripts.html is failing on windows too.

  • platform/chromium/test_expectations.txt:
1:03 PM Changeset in webkit [76631] by dimich@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

[Chromium] Not reviewed, rebaseline for a test.
The difference is because V8 has different error messages.

  • platform/chromium-mac/fast/js/js-continue-break-restrictions-expected.txt: Added.
  • platform/chromium-win/fast/js/js-continue-break-restrictions-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
12:55 PM Changeset in webkit [76630] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-01-25 James Robinson <​jamesr@chromium.org>

Remove = TEXT PASS lines for tests that consistently pass.

  • platform/chromium/test_expectations.txt:
12:55 PM Changeset in webkit [76629] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/wince

2011-01-25 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WINCE] Ensure layouted frame when painting
​https://bugs.webkit.org/show_bug.cgi?id=53108

  • WebView.cpp: (WebView::paint):
12:52 PM Changeset in webkit [76628] by jer.noble@apple.com
  • 4 edits in trunk/LayoutTests

Unreviewed build fix: rollback untintentional changes in media expected results.

  • media/video-source-moved-expected.txt:
  • media/video-source-none-supported-expected.txt:
  • LayoutTests/platform/win/media/audio-data-url-expected.txt:
12:48 PM Changeset in webkit [76627] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-25 Tony Chang <​tony@chromium.org>

Unreviewed, mark inspector/debugger-scripts.html as failing on chromium linux.

  • platform/chromium/test_expectations.txt:
12:41 PM Changeset in webkit [76626] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-01-25 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r76614.

  • platform/FileSystem.h:
12:23 PM CSS21Results edited by tabatkins@google.com
(diff)
12:18 PM CSS21Results edited by tabatkins@google.com
Added bug link for containing-block-032 (diff)
12:17 PM Changeset in webkit [76625] by leviw@chromium.org
  • 5 edits
    8 adds in trunk

2011-01-21 Levi Weintraub <​leviw@chromium.org>

Reviewed by Darin Adler.

Adding border and padding to the calculation of the local caret rect for RenderBoxes.

Undo moves caret to invalid position
​https://bugs.webkit.org/show_bug.cgi?id=49744

Tests: editing/selection/caret-painting-after-paste-undo-rtl.html

editing/selection/caret-painting-after-paste-undo.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::localCaretRect):

2011-01-21 Levi Weintraub <​leviw@chromium.org>

Reviewed by Darin Adler.

Updating the expected result for 5408255 and adding tests for caret positioning at the
beginning and end of RenderBoxes.

Undo moves caret to invalid position
​https://bugs.webkit.org/show_bug.cgi?id=49744

  • editing/selection/caret-painting-after-paste-undo-rtl.html: Added.
  • editing/selection/caret-painting-after-paste-undo.html: Added.
  • platform/mac/editing/deleting/5408255-expected.checksum:
  • platform/mac/editing/deleting/5408255-expected.png:
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Added.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Added.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Added.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Added.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Added.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Added.
12:03 PM Changeset in webkit [76624] by tony@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-01-25 Tony Chang <​tony@chromium.org>

Unreviewed, add chromium-mac baselines after r76599.

The platform/mac-leopard results were stale which is why the expected
text results aren't updated as well.

  • platform/chromium-mac/svg/custom/junk-data-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/junk-data-expected.png: Added.
  • platform/chromium-mac/svg/custom/missing-xlink-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/missing-xlink-expected.png: Added.
12:01 PM Changeset in webkit [76623] by jamesr@google.com
  • 11 edits
    3 copies
    4 adds in trunk/LayoutTests

2011-01-25 James Robinson <​jamesr@chromium.org>

Reviewed by Mihai Parparita.

Convert requestAnimationFrame tests to be script-tests
​https://bugs.webkit.org/show_bug.cgi?id=53109

This converts the new requestAnimationFrame tests to be proper script-tests using make-script-test-wrapper.

  • fast/animation/request-animation-frame-cancel-expected.txt:
  • fast/animation/request-animation-frame-cancel.html:
  • fast/animation/request-animation-frame-cancel2-expected.txt:
  • fast/animation/request-animation-frame-cancel2.html:
  • fast/animation/request-animation-frame-display-expected.txt:
  • fast/animation/request-animation-frame-display.html:
  • fast/animation/request-animation-frame-expected.txt:
  • fast/animation/request-animation-frame-within-callback-expected.txt:
  • fast/animation/request-animation-frame-within-callback.html:
  • fast/animation/request-animation-frame.html:
  • fast/animation/script-tests/TEMPLATE.html: Added.
  • fast/animation/script-tests/request-animation-frame-cancel.js: Copied from LayoutTests/fast/animation/request-animation-frame-cancel.html.
  • fast/animation/script-tests/request-animation-frame-cancel2.js: Copied from LayoutTests/fast/animation/request-animation-frame-cancel2.html. (secondCallbackId):
  • fast/animation/script-tests/request-animation-frame-display.js: Added.
  • fast/animation/script-tests/request-animation-frame-within-callback.js: Copied from LayoutTests/fast/animation/request-animation-frame-within-callback.html. (window):
  • fast/animation/script-tests/request-animation-frame.js: Added.
11:54 AM Changeset in webkit [76622] by weinig@apple.com
  • 8 edits in trunk/Source

2011-01-25 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Add hasPreciseScrollingDeltas bit to PlatformWheelEvent on the Mac.
​https://bugs.webkit.org/show_bug.cgi?id=53107

  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::PlatformWheelEvent): (WebCore::PlatformWheelEvent::hasPreciseScrollingDeltas):
  • platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

2011-01-25 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Add hasPreciseScrollingDeltas bit to PlatformWheelEvent on the Mac.
​https://bugs.webkit.org/show_bug.cgi?id=53107

  • Shared/WebEvent.h: (WebKit::WebWheelEvent::hasPreciseScrollingDeltas):
  • Shared/WebEventConversion.cpp: (WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):
  • Shared/WebWheelEvent.cpp: (WebKit::WebWheelEvent::WebWheelEvent):
  • Shared/mac/WebEventFactory.mm: (WebKit::WebEventFactory::createWebWheelEvent):
11:52 AM Changeset in webkit [76621] by jer.noble@apple.com
  • 12 edits
    3 adds in trunk

2011-01-20 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

REGRESSION (r72119): Audio never plays on Star Wars intro animation
​https://bugs.webkit.org/show_bug.cgi?id=52467

Test the ability to read audio/m4a files. Disabled this new test
on the chromium and qt platforms, as they do not support M4A/AAC.

  • media/audio-mpeg4-supported-expected.txt: Added.
  • media/audio-mpeg4-supported.html: Added.
  • media/content/silence.m4a: Added.
  • platform/chromium/test_expectations.txt:
  • platform/qt/Skipped:

2011-01-20 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

REGRESSION (r72119): Audio never plays on Star Wars intro animation
​https://bugs.webkit.org/show_bug.cgi?id=52467

QuickTime's eat/m4a movie importer compontent doesn't list audio/m4a as a mime
type which it supports, though it handles .m4a files just fine. Change the way
we build the list of supported MIME Types through a new WebKitSystemInterface
function.

Caused by r72119, which adds system-specific extension->MIME entries to the cache
before global entries, and the system-specific entries include QuickTime's registry
entries which contain the audio/m4a MIME type, while its components do not.

Test: media/audio-mpeg4-supported.html

  • WebCore.vcproj/QTMovieWinCommon.vsprops:
  • platform/graphics/win/QTMovie.cpp: (getMIMETypeCallBack): (initializeSupportedTypes): (QTMovie::countSupportedTypes): gSupportedTypes is now a CFArrayRef. (QTMovie::getSupportedType): Ditto.

2011-01-24 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

REGRESSION (r72119): Audio never plays on Star Wars intro animation
​https://bugs.webkit.org/show_bug.cgi?id=52467

Add wkGetQuickTimeMIMETypeList() function.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
11:39 AM Changeset in webkit [76620] by tony@chromium.org
  • 3 edits in trunk/Tools

2011-01-25 Tony Chang <​tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] remove unused layoutTestController callback
​https://bugs.webkit.org/show_bug.cgi?id=53103

This method is used by a test_shell_test, but not needed by DRT.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController):
  • DumpRenderTree/chromium/LayoutTestController.h:
11:39 AM Changeset in webkit [76619] by tony@chromium.org
  • 5 edits in trunk/LayoutTests

2011-01-25 Tony Chang <​tony@chromium.org>

Unreviewed, rebaseline a test on chromium-win. Part of r76586 rebaselines.

  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/chromium/test_expectations.txt:
11:25 AM Changeset in webkit [76618] by rniwa@webkit.org
  • 11 edits in trunk/LayoutTests

2011-01-25 Ryosuke Niwa <​rniwa@webkit.org>

Another unreviewed SVG rebaselines for Chromium.

  • platform/chromium-linux/svg/text/text-text-05-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-05-t-expected.png:
  • platform/chromium-mac/svg/text/text-text-05-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-05-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/chromium-win/svg/text/text-text-05-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-05-t-expected.png:
  • platform/chromium-win/svg/text/text-text-05-t-expected.txt:
  • platform/chromium/test_expectations.txt:
11:14 AM Changeset in webkit [76617] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-01-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

need a way to request the host CALayer render server port
​https://bugs.webkit.org/show_bug.cgi?id=53101
<rdar://problem/8913620>

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::compositingRenderServerPort): Get the render server port from the plug-in process.
  • PluginProcess/PluginControllerProxy.h:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_GetValue): Call NetscapePlugin::compositingRenderServerPort.
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::compositingRenderServerPort): Call PluginController::compositingRenderServerPort.
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::compositingRenderServerPort): Get the render server port from the web process.
  • WebProcess/Plugins/PluginView.h: Add compositingRenderServerPort.
11:07 AM Changeset in webkit [76616] by hans@chromium.org
  • 8 edits in trunk/Source

2011-01-25 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Remove PlatformBridge::idbShutdown()
​https://bugs.webkit.org/show_bug.cgi?id=53077

Since Chromium r72157, this is not used anymore. The previous use was
to signal to the embedder that IndexedDB was shutting down, but we
agreed it is better if the embedder keeps track of that itself.

No new tests: this does not change any functionality.

  • platform/chromium/PlatformBridge.h:
  • storage/IDBFactoryBackendInterface.cpp:
  • storage/IDBFactoryBackendInterface.h: (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
  • storage/chromium/IDBFactoryBackendInterface.cpp:

2011-01-25 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Remove PlatformBridge::idbShutdown()
​https://bugs.webkit.org/show_bug.cgi?id=53077

Since Chromium r72157, this is not used anymore. Chromium keeps track
of when it shuts down IndexedDB itself.

  • public/WebKitClient.h:
  • src/PlatformBridge.cpp:
11:06 AM Changeset in webkit [76615] by Antti Koivisto
  • 2 edits in trunk/Source/JavaScriptCore

Not reviewed.

Try to fix windows build.

11:03 AM Changeset in webkit [76614] by Darin Adler
  • 11 edits in trunk/Source

2011-01-25 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

WebKit is using CSBackupSetItemExcluded incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=53095
rdar://problem/8790540

  • Misc/WebIconDatabase.mm: (importToWebCoreFormat): Removed code that was calling CSBackupSetItemExcluded. It was incorrect, and this responsibility has been moved to WebCore.

2011-01-25 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

WebKit is using CSBackupSetItemExcluded incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=53095
rdar://problem/8790540

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::performOpenInitialization): Added code to exclude the database from backup one time, and record inside the database that this has been done. (WebCore::IconDatabase::wasExcludedFromBackup): Added. (WebCore::IconDatabase::setWasExcludedFromBackup): Added.
  • loader/icon/IconDatabase.h: Added new functions above.
  • platform/FileSystem.cpp: (WebCore::canExcludeFromBackup): Added. (WebCore::excludeFromBackup): Added.
  • platform/FileSystem.h: Added canExcludeFromBackup, excludeFromBackup, and pathAsURL functions. Cleaned up ifdefs and comments a bit and sorted things alphabetically, particularly platform-specific sections.
  • platform/cf/FileSystemCF.cpp: (WebCore::pathAsURL): Added.
  • platform/mac/FileSystemMac.mm: (WebCore::canExcludeFromBackup): Added. (WebCore::excludeFromBackup): Added.
  • platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::advanceCurrentStream): Changed to call pathAsURL.
  • platform/network/mac/FormDataStreamMac.mm: (WebCore::advanceCurrentStream): Ditto.
10:56 AM Changeset in webkit [76613] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-25 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Adler.

Skip another new test that uses eventSender
​https://bugs.webkit.org/show_bug.cgi?id=53094

  • platform/mac-wk2/Skipped:
10:54 AM Changeset in webkit [76612] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-25 Helder Correia <​helder@sencha.com>

Reviewed by Dirk Schulze.

REGRESSION(75139): SVG gradients are not applied to texts
​https://bugs.webkit.org/show_bug.cgi?id=52531

CGContextConcatCTM should use the CGLayer context, not the
GraphicsContext. Also, the CTM needs to be adjusted (translated).
This fixes SVG text gradient fill.

Test: svg/css/composite-shadow-text.svg

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect):
10:46 AM CSS21Results edited by Simon Fraser
(diff)
10:44 AM Changeset in webkit [76611] by Antti Koivisto
  • 10 edits
    3 adds in trunk/Source/JavaScriptCore

REGRESSION: Leak in JSParser::Scope::copyCapturedVariablesToVector()
​https://bugs.webkit.org/show_bug.cgi?id=53061

Reviewed by Oliver Hunt.

Cache did not know about the subclass so failed to fully delete the items.
Got rid of the subclass and moved the classes to separate files.

(JSC::JSParser::Scope::saveFunctionInfo):
(JSC::JSParser::Scope::restoreFunctionInfo):
(JSC::JSParser::findCachedFunctionInfo):
(JSC::JSParser::parseFunctionInfo):

  • parser/SourceProvider.h:
  • parser/SourceProviderCache.cpp: Added.

(JSC::SourceProviderCache::~SourceProviderCache):
(JSC::SourceProviderCache::byteSize):

  • parser/SourceProviderCache.h: Added.

(JSC::SourceProviderCache::SourceProviderCache):
(JSC::SourceProviderCache::add):
(JSC::SourceProviderCache::get):

  • parser/SourceProviderCacheItem.h: Added.

(JSC::SourceProviderCacheItem::SourceProviderCacheItem):
(JSC::SourceProviderCacheItem::approximateByteSize):
(JSC::SourceProviderCacheItem::closeBraceToken):

10:42 AM Changeset in webkit [76610] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-01-25 Benjamin Kalman <​kalman@chromium.org>

Reviewed by Ryosuke Niwa.

Cannot extend or modify forward by word over a non-contenteditable region
​https://bugs.webkit.org/show_bug.cgi?id=53070

Add regression test.

  • editing/selection/extend-forward-by-word-over-non-editable-expected.txt: Added.
  • editing/selection/extend-forward-by-word-over-non-editable.html: Added.

2011-01-25 Benjamin Kalman <​kalman@chromium.org>

Reviewed by Ryosuke Niwa.

Cannot extend or modify forward by word over a non-contenteditable region
​https://bugs.webkit.org/show_bug.cgi?id=53070

Test: editing/selection/extend-forward-by-word-over-non-editable.html

Change all instances of honorEditableBoundaryAtOrAfter to honorEditableBoundaryAtOrBefore and vice versa in the
functions which determine the end/start of words/lines/sentences in visible_units.cpp.

This fixes the bug where moving forwards by a word over a non-contenteditable region would place the cursor
inside that region, and then get moved back to the start of the word due to honorEditableBoundaryAtOrBefore.
The cursor is now moved to the end of the region (which is effectively a noop in this case).

  • editing/visible_units.cpp: Change all instances of honorEditableBoundaryAtOrAfter to honorEditableBoundaryAtOrBefore and vice versa. (WebCore::previousWordPosition): (WebCore::nextWordPosition): (WebCore::startOfLine): (WebCore::endOfLine): (WebCore::previousSentencePosition): (WebCore::nextSentencePosition): (WebCore::logicalStartOfLine): (WebCore::logicalEndOfLine):
10:28 AM Changeset in webkit [76609] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-25 Marcilio Mendonca <​mamendonca@rim.com>

Reviewed by Darin Adler.

Bug 53087: Refactoring: replaced a hanging "else" with a "return"
statement
​https://bugs.webkit.org/show_bug.cgi?id=53087.

Refactoring work: Replaced a hanging "else" within an #if PLATFORM(M
with a "return" so that the code is more readable and less error pro
(e.g., "else" doesn't use braces so adding extra lines to the else
block won't have any effect; even worse, code still compiles
successfully.

  • wtf/Assertions.cpp:
10:26 AM Changeset in webkit [76608] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

Change some floating point constants from 1.0 to 1.

Rubber stamped by Dan Bernstein.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):

10:19 AM Changeset in webkit [76607] by rniwa@webkit.org
  • 36 edits
    2 adds
    2 deletes in trunk/LayoutTests

2011-01-25 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed SVG rebaselines for Chromium.

  • platform/chromium-linux/svg/batik/text/textEffect-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textEffect-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.txt: Added.
  • platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
  • platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-without-missing-glyph-expected.checksum:
  • platform/chromium-linux/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/chromium-linux/svg/text/text-text-06-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-06-t-expected.png:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-mac/svg/text/text-text-06-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-06-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect-expected.checksum:
  • platform/chromium-win/svg/batik/text/textEffect-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
  • platform/chromium-win/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-without-missing-glyph-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/chromium-win/svg/text/text-text-06-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-06-t-expected.png:
  • platform/chromium-win/svg/text/text-text-06-t-expected.txt:
  • platform/chromium/test_expectations.txt:
10:18 AM Changeset in webkit [76606] by yael.aharon@nokia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.
After r76466, efsrv.lib is used unconditionally.
Don't guard it with ENABLE_NETSCAPE_PLUGIN_API.

  • WebCore.pro:
10:09 AM Changeset in webkit [76605] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-25 Tony Chang <​tony@chromium.org>

Unreviewed, remove passing chromium win tests.

  • platform/chromium/test_expectations.txt:
9:54 AM Changeset in webkit [76604] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-25 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Anders Carlsson.

Improve scale factor resetting
​https://bugs.webkit.org/show_bug.cgi?id=53093


Two key changes:

  • Don't set the scale factor to what it already is, as this causes an uneeded force layout and scroll
  • Don't ever set the scale factor based on a non-main frame committing


This fixes two WebKit2 layout tests.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
9:47 AM Changeset in webkit [76603] by zmo@google.com
  • 12 edits in trunk/Source/WebCore

2011-01-24 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Style cleanup for WebGLRenderingContext
​https://bugs.webkit.org/show_bug.cgi?id=52352

  • html/canvas/WebGLBuffer.cpp:
  • html/canvas/WebGLBuffer.h:
  • html/canvas/WebGLObject.cpp:
  • html/canvas/WebGLProgram.cpp:
  • html/canvas/WebGLRenderbuffer.cpp:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create): (WebCore::WebGLRenderingContext::blendFunc): (WebCore::WebGLRenderingContext::createShader): (WebCore::WebGLRenderingContext::deleteBuffer): (WebCore::WebGLRenderingContext::deleteShader): (WebCore::WebGLRenderingContext::deleteTexture): (WebCore::WebGLRenderingContext::disableVertexAttribArray): (WebCore::WebGLRenderingContext::validateIndexArrayPrecise): (WebCore::WebGLRenderingContext::validateRenderingState): (WebCore::WebGLRenderingContext::enableVertexAttribArray): (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::detachAndRemoveAllObjects):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLShader.cpp:
  • html/canvas/WebGLTexture.cpp:
  • html/canvas/WebGLUniformLocation.cpp:
  • html/canvas/WebGLUniformLocation.h:
9:43 AM Changeset in webkit [76602] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-01-25 Ilya Sherman <​isherman@chromium.org>

Reviewed by Darin Fisher.

Chromium WebKit API: Move dispatchFormControlChangeEvent() from WebInputElement to WebFormControlElement
In service of ​https://code.google.com/p/chromium/issues/detail?id=42716
​https://bugs.webkit.org/show_bug.cgi?id=53069

  • public/WebFormControlElement.h:
  • public/WebInputElement.h:
  • src/WebFormControlElement.cpp: (WebKit::WebFormControlElement::dispatchFormControlChangeEvent): Moved from WebInputElement
  • src/WebInputElement.cpp:
9:34 AM Changeset in webkit [76601] by zmo@google.com
  • 7 edits in trunk/Source/WebCore

2011-01-24 Chris Marrin <​cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
​https://bugs.webkit.org/show_bug.cgi?id=53041

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • GNUmakefile.am:
  • WebCore.pro:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • bindings/js/JSArrayBufferCustom.cpp:
  • bindings/js/JSCanvasRenderingContextCustom.cpp: (WebCore::toJS):
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDataViewCustom.cpp:
  • bindings/js/JSDocumentCustom.cpp:
  • bindings/js/JSFloat32ArrayCustom.cpp:
  • bindings/js/JSHTMLCanvasElementCustom.cpp: (WebCore::JSHTMLCanvasElement::getContext):
  • bindings/js/JSInt16ArrayCustom.cpp:
  • bindings/js/JSInt32ArrayCustom.cpp:
  • bindings/js/JSInt8ArrayCustom.cpp:
  • bindings/js/JSUint16ArrayCustom.cpp:
  • bindings/js/JSUint32ArrayCustom.cpp:
  • bindings/js/JSUint8ArrayCustom.cpp:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::markChildren): (WebCore::JSXMLHttpRequest::send): (WebCore::JSXMLHttpRequest::response):
  • bindings/v8/custom/V8ArrayBufferCustom.cpp:
  • bindings/v8/custom/V8ArrayBufferViewCustom.h:
  • bindings/v8/custom/V8DataViewCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::V8Document::getCSSCanvasContextCallback):
  • bindings/v8/custom/V8Float32ArrayCustom.cpp:
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback):
  • bindings/v8/custom/V8Int16ArrayCustom.cpp:
  • bindings/v8/custom/V8Int32ArrayCustom.cpp:
  • bindings/v8/custom/V8Int8ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint16ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint32ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint8ArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::responseAccessorGetter): (WebCore::V8XMLHttpRequest::sendCallback):
  • features.pri:
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): (WebCore::HTMLCanvasElement::reset):
  • html/HTMLCanvasElement.h:
  • html/canvas/ArrayBuffer.cpp:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/ArrayBufferView.cpp:
  • html/canvas/ArrayBufferView.idl:
  • html/canvas/DataView.cpp:
  • html/canvas/DataView.idl:
  • html/canvas/Float32Array.cpp:
  • html/canvas/Float32Array.idl:
  • html/canvas/Int16Array.cpp:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.cpp:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.cpp:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESStandardDerivatives.cpp:
  • html/canvas/OESStandardDerivatives.idl:
  • html/canvas/OESTextureFloat.cpp:
  • html/canvas/OESTextureFloat.idl:
  • html/canvas/Uint16Array.cpp:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.cpp:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.cpp:
  • html/canvas/Uint8Array.idl:
  • html/canvas/WebGLActiveInfo.idl:
  • html/canvas/WebGLBuffer.cpp:
  • html/canvas/WebGLBuffer.idl:
  • html/canvas/WebGLContextAttributes.cpp:
  • html/canvas/WebGLContextAttributes.idl:
  • html/canvas/WebGLContextEvent.idl:
  • html/canvas/WebGLExtension.cpp:
  • html/canvas/WebGLFramebuffer.cpp:
  • html/canvas/WebGLFramebuffer.idl:
  • html/canvas/WebGLGetInfo.cpp:
  • html/canvas/WebGLObject.cpp:
  • html/canvas/WebGLProgram.cpp:
  • html/canvas/WebGLProgram.idl:
  • html/canvas/WebGLRenderbuffer.cpp:
  • html/canvas/WebGLRenderbuffer.idl:
  • html/canvas/WebGLRenderingContext.cpp:
  • html/canvas/WebGLRenderingContext.idl:
  • html/canvas/WebGLShader.cpp:
  • html/canvas/WebGLShader.idl:
  • html/canvas/WebGLTexture.cpp:
  • html/canvas/WebGLTexture.idl:
  • html/canvas/WebGLUniformLocation.cpp:
  • html/canvas/WebGLUniformLocation.idl:
  • html/canvas/WebKitLoseContext.cpp:
  • html/canvas/WebKitLoseContext.idl:
  • page/DOMWindow.idl:
  • platform/graphics/ANGLEWebKitBridge.cpp:
  • platform/graphics/GraphicsContext3D.cpp:
  • platform/graphics/cg/GraphicsContext3DCG.cpp:
  • platform/graphics/gpu/DrawingBuffer.cpp:
  • platform/graphics/gpu/mac/DrawingBufferMac.mm:
  • platform/graphics/mac/GraphicsContext3DMac.mm:
  • platform/graphics/mac/WebGLLayer.mm:
  • platform/graphics/opengl/Extensions3DOpenGL.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/graphics/qt/Extensions3DQt.cpp:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:
  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges):
  • platform/graphics/qt/GraphicsLayerQt.h:
  • platform/graphics/skia/GraphicsContext3DSkia.cpp:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::isAcceleratedCanvas): (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): (WebCore::RenderLayerBacking::containsPaintedContent): (WebCore::RenderLayerBacking::contentChanged):
  • webaudio/AudioBuffer.cpp:
  • webaudio/AudioBuffer.idl:
  • webaudio/RealtimeAnalyser.cpp:
  • webaudio/RealtimeAnalyser.h:
  • webaudio/RealtimeAnalyserNode.h:
  • webaudio/RealtimeAnalyserNode.idl:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::setResponseType): (WebCore::XMLHttpRequest::clearResponse): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/XMLHttpRequest.h:
9:27 AM Changeset in webkit [76600] by cmarrin@apple.com
  • 130 edits in trunk

2011-01-24 Chris Marrin <​cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
​https://bugs.webkit.org/show_bug.cgi?id=53041

  • configure.ac:

2011-01-24 Chris Marrin <​cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
​https://bugs.webkit.org/show_bug.cgi?id=53041

  • Configurations/FeatureDefines.xcconfig:

2011-01-24 Chris Marrin <​cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
​https://bugs.webkit.org/show_bug.cgi?id=53041

  • WebKit.gyp:
  • features.gypi:
  • src/Extensions3DChromium.cpp:
  • src/GraphicsContext3DChromium.cpp:
  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableWebGL): (WebKit::WebRuntimeFeatures::isWebGLEnabled):

2011-01-24 Chris Marrin <​cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
​https://bugs.webkit.org/show_bug.cgi?id=53041

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):

2011-01-24 Chris Marrin <​cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
​https://bugs.webkit.org/show_bug.cgi?id=53041

  • WebView.cpp: (WebView::notifyPreferencesChanged):

2011-01-24 Chris Marrin <​cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
​https://bugs.webkit.org/show_bug.cgi?id=53041

  • Configurations/FeatureDefines.xcconfig:

2011-01-24 Chris Marrin <​cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
​https://bugs.webkit.org/show_bug.cgi?id=53041

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • GNUmakefile.am:
  • WebCore.pro:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • bindings/js/JSArrayBufferCustom.cpp:
  • bindings/js/JSCanvasRenderingContextCustom.cpp: (WebCore::toJS):
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDataViewCustom.cpp:
  • bindings/js/JSDocumentCustom.cpp:
  • bindings/js/JSFloat32ArrayCustom.cpp:
  • bindings/js/JSHTMLCanvasElementCustom.cpp: (WebCore::JSHTMLCanvasElement::getContext):
  • bindings/js/JSInt16ArrayCustom.cpp:
  • bindings/js/JSInt32ArrayCustom.cpp:
  • bindings/js/JSInt8ArrayCustom.cpp:
  • bindings/js/JSUint16ArrayCustom.cpp:
  • bindings/js/JSUint32ArrayCustom.cpp:
  • bindings/js/JSUint8ArrayCustom.cpp:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::markChildren): (WebCore::JSXMLHttpRequest::send): (WebCore::JSXMLHttpRequest::response):
  • bindings/v8/custom/V8ArrayBufferCustom.cpp:
  • bindings/v8/custom/V8ArrayBufferViewCustom.h:
  • bindings/v8/custom/V8DataViewCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::V8Document::getCSSCanvasContextCallback):
  • bindings/v8/custom/V8Float32ArrayCustom.cpp:
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback):
  • bindings/v8/custom/V8Int16ArrayCustom.cpp:
  • bindings/v8/custom/V8Int32ArrayCustom.cpp:
  • bindings/v8/custom/V8Int8ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint16ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint32ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint8ArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::responseAccessorGetter): (WebCore::V8XMLHttpRequest::sendCallback):
  • features.pri:
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): (WebCore::HTMLCanvasElement::reset):
  • html/HTMLCanvasElement.h:
  • html/canvas/ArrayBuffer.cpp:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/ArrayBufferView.cpp:
  • html/canvas/ArrayBufferView.idl:
  • html/canvas/DataView.cpp:
  • html/canvas/DataView.idl:
  • html/canvas/Float32Array.cpp:
  • html/canvas/Float32Array.idl:
  • html/canvas/Int16Array.cpp:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.cpp:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.cpp:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESStandardDerivatives.cpp:
  • html/canvas/OESStandardDerivatives.idl:
  • html/canvas/OESTextureFloat.cpp:
  • html/canvas/OESTextureFloat.idl:
  • html/canvas/Uint16Array.cpp:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.cpp:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.cpp:
  • html/canvas/Uint8Array.idl:
  • html/canvas/WebGLActiveInfo.idl:
  • html/canvas/WebGLBuffer.cpp:
  • html/canvas/WebGLBuffer.idl:
  • html/canvas/WebGLContextAttributes.cpp:
  • html/canvas/WebGLContextAttributes.idl:
  • html/canvas/WebGLContextEvent.idl:
  • html/canvas/WebGLExtension.cpp:
  • html/canvas/WebGLFramebuffer.cpp:
  • html/canvas/WebGLFramebuffer.idl:
  • html/canvas/WebGLGetInfo.cpp:
  • html/canvas/WebGLObject.cpp:
  • html/canvas/WebGLProgram.cpp:
  • html/canvas/WebGLProgram.idl:
  • html/canvas/WebGLRenderbuffer.cpp:
  • html/canvas/WebGLRenderbuffer.idl:
  • html/canvas/WebGLRenderingContext.cpp:
  • html/canvas/WebGLRenderingContext.idl:
  • html/canvas/WebGLShader.cpp:
  • html/canvas/WebGLShader.idl:
  • html/canvas/WebGLTexture.cpp:
  • html/canvas/WebGLTexture.idl:
  • html/canvas/WebGLUniformLocation.cpp:
  • html/canvas/WebGLUniformLocation.idl:
  • html/canvas/WebKitLoseContext.cpp:
  • html/canvas/WebKitLoseContext.idl:
  • page/DOMWindow.idl:
  • platform/graphics/ANGLEWebKitBridge.cpp:
  • platform/graphics/GraphicsContext3D.cpp:
  • platform/graphics/cg/GraphicsContext3DCG.cpp:
  • platform/graphics/gpu/DrawingBuffer.cpp:
  • platform/graphics/gpu/mac/DrawingBufferMac.mm:
  • platform/graphics/mac/GraphicsContext3DMac.mm:
  • platform/graphics/mac/WebGLLayer.mm:
  • platform/graphics/opengl/Extensions3DOpenGL.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/graphics/qt/Extensions3DQt.cpp:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:
  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges):
  • platform/graphics/qt/GraphicsLayerQt.h:
  • platform/graphics/skia/GraphicsContext3DSkia.cpp:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::isAcceleratedCanvas): (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): (WebCore::RenderLayerBacking::containsPaintedContent): (WebCore::RenderLayerBacking::contentChanged):
  • webaudio/AudioBuffer.cpp:
  • webaudio/AudioBuffer.idl:
  • webaudio/RealtimeAnalyser.cpp:
  • webaudio/RealtimeAnalyser.h:
  • webaudio/RealtimeAnalyserNode.h:
  • webaudio/RealtimeAnalyserNode.idl:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::setResponseType): (WebCore::XMLHttpRequest::clearResponse): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/XMLHttpRequest.h:

2011-01-24 Chris Marrin <​cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
​https://bugs.webkit.org/show_bug.cgi?id=53041

  • Configurations/FeatureDefines.xcconfig:
9:22 AM Changeset in webkit [76599] by Nikolas Zimmermann
  • 13 edits
    12 adds in trunk/LayoutTests

2011-01-25 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

Update Leopard svg/ pixel test baselines, to make run-webkit-tests -p pass again with --tolerance 0.
Contains only marginal differences, or updates pixel test results that were forgotten to update.

  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-image-07-t-expected.checksum: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-image-07-t-expected.png: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.checksum: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.png: Added.
  • platform/mac-leopard/svg/css/text-gradient-shadow-expected.checksum: Added.
  • platform/mac-leopard/svg/css/text-gradient-shadow-expected.png: Added.
  • platform/mac-leopard/svg/custom/image-rescale-clip-expected.checksum:
  • platform/mac-leopard/svg/custom/image-rescale-clip-expected.png:
  • platform/mac-leopard/svg/custom/image-rescale-scroll-expected.checksum: Added.
  • platform/mac-leopard/svg/custom/image-rescale-scroll-expected.png: Added.
  • platform/mac-leopard/svg/custom/junk-data-expected.checksum:
  • platform/mac-leopard/svg/custom/junk-data-expected.png:
  • platform/mac-leopard/svg/custom/missing-xlink-expected.checksum:
  • platform/mac-leopard/svg/custom/missing-xlink-expected.png:
  • platform/mac-leopard/svg/filters/feComposite-expected.checksum:
  • platform/mac-leopard/svg/filters/feComposite-expected.png:
  • platform/mac-leopard/svg/filters/filter-rounding-issues-expected.checksum: Added.
  • platform/mac-leopard/svg/filters/filter-rounding-issues-expected.png: Added.
  • platform/mac-leopard/svg/repaint/filter-repaint-expected.checksum:
  • platform/mac-leopard/svg/repaint/filter-repaint-expected.png:
9:14 AM Changeset in webkit [76598] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Windows Production build fix

9:11 AM Changeset in webkit [76597] by mnaganov@chromium.org
  • 17 edits
    2 adds in trunk/Source

2011-01-25 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Prepare for landing of detailed heap snapshots.

  • Introduce Preferences.detailedHeapProfiles flag for controlling querying of detailed heap snapshots.
  • Add boilerplate code for the new view.
  • Factor out common code.

​https://bugs.webkit.org/show_bug.cgi?id=52624

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/ScriptProfiler.h: (WebCore::ScriptProfiler::HeapSnapshotControl::~HeapSnapshotControl): (WebCore::ScriptProfiler::takeHeapSnapshot):
  • bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::takeHeapSnapshot):
  • bindings/v8/ScriptProfiler.h: (WebCore::ScriptProfiler::HeapSnapshotControl::~HeapSnapshotControl):
  • inspector/Inspector.idl:
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::takeHeapSnapshot):
  • inspector/InspectorProfilerAgent.h:
  • inspector/front-end/DetailedHeapshotView.js: Added. (WebInspector.DetailedHeapshotView): (WebInspector.DetailedHeapshotView.prototype.get statusBarItems): (WebInspector.DetailedHeapshotView.prototype.get profile): (WebInspector.DetailedHeapshotView.prototype.set profile): (WebInspector.DetailedHeapshotView.prototype.show): (WebInspector.DetailedHeapshotView.prototype.hide): (WebInspector.DetailedHeapshotProfileType): (WebInspector.DetailedHeapshotProfileType.prototype.get buttonTooltip): (WebInspector.DetailedHeapshotProfileType.prototype.get buttonStyle): (WebInspector.DetailedHeapshotProfileType.prototype.buttonClicked): (WebInspector.DetailedHeapshotProfileType.prototype.get welcomeMessage): (WebInspector.DetailedHeapshotProfileType.prototype.createSidebarTreeElementForProfile): (WebInspector.DetailedHeapshotProfileType.prototype.createView):
  • inspector/front-end/HeapSnapshot.js: Added. (WebInspector.HeapSnapshotEdgesIterator): (WebInspector.HeapSnapshotEdgesIterator.prototype.get done): (WebInspector.HeapSnapshotEdgesIterator.prototype.get isElement): (WebInspector.HeapSnapshotEdgesIterator.prototype.get isHidden): (WebInspector.HeapSnapshotEdgesIterator.prototype.get name): (WebInspector.HeapSnapshotEdgesIterator.prototype.next): (WebInspector.HeapSnapshotEdgesIterator.prototype.get node): (WebInspector.HeapSnapshotEdgesIterator.prototype.get nodeIndex): (WebInspector.HeapSnapshotEdgesIterator.prototype._getNameOrIndex): (WebInspector.HeapSnapshotEdgesIterator.prototype._getType): (WebInspector.HeapSnapshotNodeWrapper): (WebInspector.HeapSnapshotNodeWrapper.prototype.get edges): (WebInspector.HeapSnapshotNodeWrapper.prototype.get edgesCount): (WebInspector.HeapSnapshotNodeWrapper.prototype.get instancesCount): (WebInspector.HeapSnapshotNodeWrapper.prototype.get isHidden): (WebInspector.HeapSnapshotNodeWrapper.prototype.get name): (WebInspector.HeapSnapshotNodeWrapper.prototype.get selfSize): (WebInspector.HeapSnapshotNodeWrapper.prototype._getName): (WebInspector.HeapSnapshotNodeWrapper.prototype._getEdges): (WebInspector.HeapSnapshotNodeWrapper.prototype._getType): (WebInspector.HeapSnapshot): (WebInspector.HeapSnapshot.prototype._init): (WebInspector.HeapSnapshot.prototype.get rootEdges):
  • inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._setRecordingProfile): (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress): (WebInspector.ProfilerDispatcher.prototype.setRecordingProfile): (WebInspector.ProfilerDispatcher.prototype.reportHeapSnapshotProgress):
  • inspector/front-end/Settings.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels):
  • src/js/DevTools.js: ():
9:10 AM Changeset in webkit [76596] by Nikolas Zimmermann
  • 67 edits in trunk/LayoutTests

2011-01-25 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

Update Snow Leopard svg/ pixel test baselines, to make run-webkit-tests -p pass again with --tolerance 0.
Contains only marginal differences, or updates pixel test results that were forgotten to update.

  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-07-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-07-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
  • platform/mac/svg/batik/text/textEffect-expected.checksum:
  • platform/mac/svg/batik/text/textEffect-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.checksum:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/custom/baseval-animval-equality-expected.checksum:
  • platform/mac/svg/custom/baseval-animval-equality-expected.png:
  • platform/mac/svg/custom/foreign-object-skew-expected.checksum:
  • platform/mac/svg/custom/foreign-object-skew-expected.png:
  • platform/mac/svg/custom/image-rescale-expected.checksum:
  • platform/mac/svg/custom/image-rescale-expected.png:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.checksum:
  • platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/mac/svg/filters/feComposite-expected.checksum:
  • platform/mac/svg/filters/feComposite-expected.png:
  • platform/mac/svg/filters/filter-rounding-issues-expected.checksum:
  • platform/mac/svg/filters/filter-rounding-issues-expected.png:
  • platform/mac/svg/filters/filteredImage-expected.checksum:
  • platform/mac/svg/filters/filteredImage-expected.png:
  • platform/mac/svg/repaint/filter-repaint-expected.checksum:
  • platform/mac/svg/repaint/filter-repaint-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.checksum:
  • platform/mac/svg/text/text-text-05-t-expected.png:
  • platform/mac/svg/text/text-text-06-t-expected.checksum:
  • platform/mac/svg/text/text-text-06-t-expected.png:
8:48 AM Changeset in webkit [76595] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-25 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Add missing defines for COMPILER(RVCT) && CPU(ARM_THUMB2)
​https://bugs.webkit.org/show_bug.cgi?id=52949

  • jit/JITStubs.cpp:
8:09 AM Changeset in webkit [76594] by yurys@chromium.org
  • 15 edits in trunk/Source

2011-01-25 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove "attached" state related methods from InspectorAgent
​https://bugs.webkit.org/show_bug.cgi?id=53086

  • WebCore.exp.in:
  • inspector/InspectorAgent.cpp:
  • inspector/InspectorAgent.h:
  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight): (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
  • inspector/InspectorSettings.cpp: (WebCore::InspectorSettings::InspectorSettings):
  • inspector/InspectorSettings.h:

2011-01-25 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove "attached" state related methods from InspectorAgent
​https://bugs.webkit.org/show_bug.cgi?id=53086

  • WebCoreSupport/WebInspectorClientCF.cpp: (WebInspectorClient::sendMessageToFrontend): (WebInspectorClient::inspectorStartsAttached): (WebInspectorClient::setInspectorStartsAttached): (WebInspectorClient::releaseFrontendPage):

2011-01-25 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove "attached" state related methods from InspectorAgent
​https://bugs.webkit.org/show_bug.cgi?id=53086

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController attach]): (-[WebInspectorWindowController detach]):

2011-01-25 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove "attached" state related methods from InspectorAgent
​https://bugs.webkit.org/show_bug.cgi?id=53086

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorFrontendClient::attachWindow): (WebInspectorFrontendClient::detachWindow): (WebInspectorFrontendClient::showWindowWithoutNotifications):
  • WebCoreSupport/WebInspectorClient.h:
7:46 AM Changeset in webkit [76593] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

2011-01-25 Carlos Garcia Campos <​cgarcia@igalia.com>

Unreviewed, add bug url for failing test on GTK.

[cairo] Fix LayoutTests/fast/canvas/patternfill-repeat.html
​https://bugs.webkit.org/show_bug.cgi?id=53085

  • platform/gtk/Skipped:
7:24 AM Changeset in webkit [76592] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-01-25 Qi Zhang <​qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Symbian] RVCT fails to compile [U|I]nt[8|16|32]Array.h
​https://bugs.webkit.org/show_bug.cgi?id=51873

Replace the using declaration, because it doesn't compile on RVCT, and WINSCW has the same issue.
No new functionality so no new tests.

  • html/canvas/Int32Array.h: (WebCore::Int32Array::set):
  • html/canvas/Int8Array.h: (WebCore::Int8Array::set):
  • html/canvas/Uint16Array.h: (WebCore::Uint16Array::set):
  • html/canvas/Uint32Array.h: (WebCore::Uint32Array::set):
  • html/canvas/Uint8Array.h: (WebCore::Uint8Array::set):
7:15 AM Changeset in webkit [76591] by mario@webkit.org
  • 3 edits in trunk/LayoutTests

2011-01-25 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Antonio Gomes.

fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=53073

Make the two steps in the flaky test to be executed sequentially.

  • fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html: Fix flaky test by chaining its two steps up.
  • platform/gtk/Skipped: Unskip test.
7:10 AM Changeset in webkit [76590] by zherczeg@webkit.org
  • 14 edits in trunk/Source/WebCore

Repaint SVG elements with filter instead of relayout where possible
​https://bugs.webkit.org/show_bug.cgi?id=52200

Reviewed by Dirk Schulze.

This patch allows repainting of filters, when their
attribute changes does not require relayout.

Existing dynamic-update tests cover this feature.

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::clearResult): Clearing the currently stored image
before repainting.

  • platform/graphics/filters/FilterEffect.h:
  • rendering/RenderObject.h:

(WebCore::RenderObject::isSVGResourceFilter): Not only the filter primitives,
but filters should also be detected to allow safe testing and casting.

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::buildPrimitives): Passing the renderer.
(WebCore::RenderSVGResourceFilter::applyResource):
determineFilterPrimitiveSubregion does not require the filter anymore.
(WebCore::RenderSVGResourceFilter::postApplyResource): Repaint
if lastEffect->hasResult() is false.
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):
Searching for all FilterEffects, whose created by the current FilterElement,
and clearing all resulting images depending on those FilterEffects.

  • rendering/svg/RenderSVGResourceFilter.h:

(WebCore::RenderSVGResourceFilter::isSVGResourceFilter):

  • rendering/svg/RenderSVGResourceFilterPrimitive.cpp:

(WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
The filter argument is unnecessary anymore. But is is still kept as a static
member, since the primitive renderer still does not know about the
FilterEffect objects.

  • rendering/svg/RenderSVGResourceFilterPrimitive.h:

(WebCore::RenderSVGResourceFilterPrimitive::RenderSVGResourceFilterPrimitive):
(WebCore::RenderSVGResourceFilterPrimitive::primitiveAttributeChanged):
Calls RenderSVGResourceFilter::primitiveAttributeChanged.

  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
Setting the new attribute value for each FilterEffect.
(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged):

  • svg/SVGFEDiffuseLightingElement.h:

Calling primitiveAttributeChanged.

  • svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::setFilterEffectAttribute):
This function will be removed when all FilterElement implements
their setFilterEffectAttribute

  • svg/SVGFilterPrimitiveStandardAttributes.h:

(WebCore::SVGFilterPrimitiveStandardAttributes::primitiveAttributeChanged):

  • svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::appendEffectToEffectReferences): The
renderers are assigned to the filter effects.
(WebCore::SVGFilterBuilder::clearEffects):
(WebCore::SVGFilterBuilder::clearResultsRecursive): Recursively
clearing the result images for those filters, whose depend on
the starting filter.

  • svg/graphics/filters/SVGFilterBuilder.h:

(WebCore::SVGFilterBuilder::effectReferences): 'get' is unnecessary
(WebCore::SVGFilterBuilder::effectByRenderer): returns the
FilterEffect belongs to this RenderObject.

5:46 AM Changeset in webkit [76589] by krit@webkit.org
  • 4 edits
    3 adds in trunk

2011-01-25 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG is missing to-animation support for Path
​https://bugs.webkit.org/show_bug.cgi?id=52982

Added an animation test to check 'to' animations in combination with SVG paths.

  • svg/animations/animate-path-to-animation-expected.txt: Added.
  • svg/animations/animate-path-to-animation.html: Added.
  • svg/animations/script-tests/animate-path-to-animation.js: Added. (sample1): (sample2): (sample3): (executeTest):

2011-01-25 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG is missing to-animation support for Path
​https://bugs.webkit.org/show_bug.cgi?id=52982

SVG was missing 'to' animation support for SVG paths. Even the fallback to discrete
animation did not work and an assert was thrown, because of the missing m_fromPath.
This also influences a test of the W3C test suite. Subtest 2 of animate-elem-83-t.svg passes now.

Test: svg/animations/animate-path-to-animation.html

  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateAnimatedValue): Take the value of the last SVGAnimateElement for m_fromPath, since 'to' animations are accumulative. (WebCore::SVGAnimateElement::calculateFromAndToValues): Added support for 'to' animations. (WebCore::SVGAnimateElement::resetToBaseValue): Set m_animatedPath on the first animation element to baseVal.
  • svg/SVGPathByteStream.h: (WebCore::SVGPathByteStream::copySVGPathByteStream): Return copy of current byte stream.
5:34 AM Changeset in webkit [76588] by Nikolas Zimmermann
  • 22 edits in trunk/LayoutTests

2011-01-25 Nikolas Zimmermann <​nzimmermann@rim.com>

Introduce FontMetrics abstraction
​https://bugs.webkit.org/show_bug.cgi?id=51456

Update gtk/qt baseline.

  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/gtk/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/gtk/svg/text/text-hkern-expected.txt:
  • platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/gtk/svg/text/text-vkern-expected.txt:
  • platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/qt/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
  • platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/qt/svg/text/text-hkern-expected.txt:
  • platform/qt/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/qt/svg/text/text-vkern-expected.txt:
  • platform/qt/svg/text/text-vkern-on-horizontal-text-expected.txt:
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
5:32 AM Changeset in webkit [76587] by pfeldman@chromium.org
  • 11 edits in trunk

2011-01-25 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: bind resources to URLs upon adding them into the tree.
​https://bugs.webkit.org/show_bug.cgi?id=53013

  • inspector/debugger-scripts-expected.txt:
  • inspector/debugger-scripts.html:

2011-01-25 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: bind resources to URLs upon adding them into the tree.
​https://bugs.webkit.org/show_bug.cgi?id=53013

  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype._parsedScriptSource):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype._processCachedResources): (WebInspector.NetworkManager.prototype.inflightResourceForURL): (WebInspector.NetworkDispatcher): (WebInspector.NetworkDispatcher.prototype.willSendRequest): (WebInspector.NetworkDispatcher.prototype.markResourceAsCached): (WebInspector.NetworkDispatcher.prototype.didReceiveResponse): (WebInspector.NetworkDispatcher.prototype.didReceiveContentLength): (WebInspector.NetworkDispatcher.prototype.didFinishLoading): (WebInspector.NetworkDispatcher.prototype.didFailLoading): (WebInspector.NetworkDispatcher.prototype.willSendWebSocketHandshakeRequest): (WebInspector.NetworkDispatcher.prototype.didReceiveWebSocketHandshakeResponse): (WebInspector.NetworkDispatcher.prototype.didCloseWebSocket): (WebInspector.NetworkDispatcher.prototype._appendRedirect): (WebInspector.NetworkDispatcher.prototype._startResource): (WebInspector.NetworkDispatcher.prototype._finishResource): (WebInspector.NetworkDispatcher.prototype._createResource):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype.addResourceToFrame): (WebInspector.ResourceTreeModel.prototype._bindResourceURL): (WebInspector.ResourceTreeModel.prototype._clearResources): (WebInspector.ResourceTreeModel.prototype._unbindResourceURL):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLine): (WebInspector.ResourcesPanel.prototype.showSourceLine):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._parsedScriptSource): (WebInspector.ScriptsPanel.prototype._addScript):
4:47 AM Changeset in webkit [76586] by Nikolas Zimmermann
  • 42 edits in trunk

2011-01-25 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Introduce FontMetrics abstraction
​https://bugs.webkit.org/show_bug.cgi?id=51456

Use accurate floating-point metrics for SVG Font calculations instead of casting float -> integer.
This hopefully fixes differences between 32/64 bit bots.

Needs new layout test results for several platforms, which need to be taken from the bots landing afterwards.

  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData): (WebCore::SimpleFontData::initCharWidths):

2011-01-25 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Introduce FontMetrics abstraction
​https://bugs.webkit.org/show_bug.cgi?id=51456

Update mac/mac-leopard pixel baseline after removing the float -> int truncation in the SVG Fonts ascent/descent calculation code.

  • platform/gtk/Skipped: Unskip several tests.
  • platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/mac-leopard/svg/batik/text/textEffect-expected.checksum:
  • platform/mac-leopard/svg/batik/text/textEffect-expected.png:
  • platform/mac-leopard/svg/batik/text/textEffect3-expected.checksum:
  • platform/mac-leopard/svg/batik/text/textEffect3-expected.png:
  • platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png:
  • platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
  • platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.checksum:
  • platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/mac-leopard/svg/text/text-text-05-t-expected.checksum:
  • platform/mac-leopard/svg/text/text-text-05-t-expected.png:
  • platform/mac-leopard/svg/text/text-text-06-t-expected.checksum:
  • platform/mac-leopard/svg/text/text-text-06-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/textPosition2-expected.png:
  • platform/mac/svg/batik/text/textPosition2-expected.txt:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
  • platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/mac/svg/text/text-text-05-t-expected.txt:
  • platform/mac/svg/text/text-text-06-t-expected.txt:
  • svg/custom/glyph-transformation-with-hkern-expected.txt:

-This line, and those below, will be ignored--

M LayoutTests/platform/mac-leopard/svg/text/text-text-05-t-expected.checksum
M LayoutTests/platform/mac-leopard/svg/text/text-text-06-t-expected.checksum
M LayoutTests/platform/mac-leopard/svg/text/text-text-05-t-expected.png
M LayoutTests/platform/mac-leopard/svg/text/text-text-06-t-expected.png
M LayoutTests/platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png
M LayoutTests/platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum
M LayoutTests/platform/mac-leopard/svg/batik/text/textEffect3-expected.checksum
M LayoutTests/platform/mac-leopard/svg/batik/text/textEffect-expected.checksum
M LayoutTests/platform/mac-leopard/svg/batik/text/textEffect-expected.png
M LayoutTests/platform/mac-leopard/svg/batik/text/textEffect3-expected.png
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.png
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.checksum
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.checksum
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.png
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png
M LayoutTests/platform/mac/svg/text/text-text-06-t-expected.txt
M LayoutTests/platform/mac/svg/text/text-text-05-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png
M LayoutTests/platform/mac/svg/batik/text/textEffect3-expected.txt
M LayoutTests/platform/mac/svg/batik/text/textPosition2-expected.png
M LayoutTests/platform/mac/svg/batik/text/textEffect-expected.txt
M LayoutTests/platform/mac/svg/batik/text/textPosition2-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt
M LayoutTests/platform/mac/svg/custom/svg-fonts-in-html-expected.txt
M LayoutTests/platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt
M LayoutTests/platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt
M LayoutTests/platform/gtk/Skipped
M LayoutTests/ChangeLog
M LayoutTests/svg/custom/glyph-transformation-with-hkern-expected.txt
M Source/WebCore/ChangeLog
M Source/WebCore/platform/graphics/SimpleFontData.cpp

4:43 AM Changeset in webkit [76585] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebKit2

2011-01-25 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Add QWKPage::processCrashed() signal
​https://bugs.webkit.org/show_bug.cgi?id=53076

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::processDidCrash):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:
3:43 AM Changeset in webkit [76584] by kov@webkit.org
  • 2 edits in trunk/Tools

2011-01-25 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Andreas Kling.

[GTK] Remove 64 bits release bot from the buildbot master
​https://bugs.webkit.org/show_bug.cgi?id=52899

Removes the 64 bits release slave from the buildbot configuration,
so that we can use it as an EWS.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
3:38 AM Changeset in webkit [76583] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-25 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, skipping flaky test on GTK debug bots.

editing/selection/extend-selection-bidi.html test is flaky
​https://bugs.webkit.org/show_bug.cgi?id=53074

  • platform/gtk/Skipped: Skipped test.
3:09 AM Changeset in webkit [76582] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-25 Mario Sanchez Prada <​msanchez@igalia.com>

Unreviewed, skipping flaky test on GTK debug bots.

fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=53073

  • platform/gtk/Skipped: Skipped test.
1:44 AM Changeset in webkit [76581] by podivilov@chromium.org
  • 11 edits in trunk/Source/WebCore

2011-01-24 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: debugger and browser debugger agents should manage sticky breakpoints independently.
​https://bugs.webkit.org/show_bug.cgi?id=52999

  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::enableDebugger): (WebCore::InspectorAgent::inspectedURLWithoutFragment):
  • inspector/InspectorAgent.h:
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::setAllJavaScriptBreakpoints): (WebCore::InspectorDebuggerAgent::inspectedURLChanged): (WebCore::InspectorDebuggerAgent::restoreBreakpoints):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
  • inspector/InspectorState.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._saveBreakpoints): (WebInspector.BreakpointManager.prototype._pushBreakpointsToBackend):
1:19 AM Changeset in webkit [76580] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-24 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Nikolas Zimmermann.

Skip some new tests for WebKit2 that use eventSender
​https://bugs.webkit.org/show_bug.cgi?id=53068

  • platform/mac-wk2/Skipped:
1:15 AM Changeset in webkit [76579] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-25 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, trivial debugger test fix.

  • src/js/Tests.js:
12:43 AM Changeset in webkit [76578] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

2011-01-25 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Crash in some pages containing flash
​https://bugs.webkit.org/show_bug.cgi?id=53016

Flash plugin can produce X errors that are handled by the GDK X
error handler, which exits the process. Since we don't want to
crash due to flash bugs, we install a custom error handler to show
a warning when a X error happens without aborting.

  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::webkitgtkXError): (WebCore::PluginPackage::load):
12:33 AM Changeset in webkit [76577] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebCore

2011-01-25 Carlos Garcia Campos <​cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement spin buttons in RenderThemeGtk
​https://bugs.webkit.org/show_bug.cgi?id=51454

Paint inner up/down buttons for spin button elements when building
with GTK+ 3.x.

Test results will land with the GTK+ 2.x version of this patch.

  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle): (WebCore::RenderThemeGtk::paintInnerSpinButton):
  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::spinButtonArrowSize): (WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle): (WebCore::paintSpinArrowButton): (WebCore::RenderThemeGtk::paintInnerSpinButton):

Jan 24, 2011:

10:44 PM Changeset in webkit [76576] by mihaip@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-24 Mihai Parparita <​mihaip@chromium.org>

Unreviewed. Missed move of one m_deleted use to be outside NDEBUG block
in r76575.

  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::~CachedResource):
10:17 PM Changeset in webkit [76575] by mihaip@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-01-24 Mihai Parparita <​mihaip@chromium.org>

Reviewed by Tony Chang.

Add runtime checks for invariants in memory cache
​https://bugs.webkit.org/show_bug.cgi?id=53059

To help track down bug 53045, add some CRASH calls in addition to
ASSERTs, so that we can track down failures in reliability bots.

Just some checks, no new tests necessary.

  • css/CSSImageValue.cpp: (WebCore::CSSImageValue::cachedImage):
  • loader/cache/CachedResource.h:
  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::~CachedResource):
10:15 PM Changeset in webkit [76574] by mjs@apple.com
  • 2 edits in trunk/Tools

2011-01-24 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Dan Bernstein.

Implement database quota callback to fix storage tests on WebKit2 bot
​https://bugs.webkit.org/show_bug.cgi?id=53064

  • WebKitTestRunner/TestController.cpp: (WTR::exceededDatabaseQuota): (WTR::TestController::createOtherPage): (WTR::TestController::initialize):
10:09 PM Changeset in webkit [76573] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-01-24 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Leaking CSSRuleDataList objects
​https://bugs.webkit.org/show_bug.cgi?id=53062

Fix leaked CSSRuleDataLists added to the m_pseudoRules hash.

  • css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::~CSSRuleSet):
10:05 PM Changeset in webkit [76572] by tkent@chromium.org
  • 8 edits in trunk/LayoutTests

2011-01-24 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

Chromium-Linux rebaseline for r76567.

  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.checksum:
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.checksum:
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium/test_expectations.txt:
9:52 PM Changeset in webkit [76571] by Simon Fraser
  • 18 edits in trunk/Source/WebCore

2011-01-24 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel.

Refcount Images used in rendering code
​https://bugs.webkit.org/show_bug.cgi?id=52701

Change StyleImage::image(RenderObject*, const IntSize&) and
CSSImageGeneratorValue::image(RenderObject*, const IntSize&) to
return PassRefPtr<Image>, and adjust other code accordingly.

This allows us to return one-time images, for example for CSS gradients
whose appearance may change depending on factors other than the renderer
and the destination size.

  • css/CSSCanvasValue.cpp: (WebCore::CSSCanvasValue::image):
  • css/CSSCanvasValue.h:
  • css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::image):
  • css/CSSGradientValue.h:
  • css/CSSImageGeneratorValue.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::paintNinePieceImage):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced): (WebCore::RenderImage::paintIntoRect):
  • rendering/RenderImageResource.h: (WebCore::RenderImageResource::image):
  • rendering/RenderImageResourceStyleImage.h: (WebCore::RenderImageResourceStyleImage::image):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/style/StyleCachedImage.cpp: (WebCore::StyleCachedImage::image):
  • rendering/style/StyleCachedImage.h:
  • rendering/style/StyleGeneratedImage.cpp: (WebCore::StyleGeneratedImage::image):
  • rendering/style/StyleGeneratedImage.h:
  • rendering/style/StyleImage.h:
  • rendering/style/StylePendingImage.h: (WebCore::StylePendingImage::image):
  • rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
9:38 PM Changeset in webkit [76570] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-01-24 Martin Robinson <​mrobinson@igalia.com>

Skip a slightly different set of tests after r76555. Seems that some of these
failures are cascading.

  • platform/gtk/Skipped: Update the skipped list.
9:17 PM Changeset in webkit [76569] by tony@chromium.org
  • 44 edits
    7 adds
    36 deletes in trunk

2011-01-24 Tony Chang <​tony@chromium.org>

Unreviewed, reverting 5 changes of baselines that are incorrect for Linux.
Mark win tests as failing for now.

  • platform/chromium-linux/fast/css/acid2-expected.txt: Removed.
  • platform/chromium-linux/fast/css/acid2-pixel-expected.checksum:
  • platform/chromium-linux/fast/css/acid2-pixel-expected.png:
  • platform/chromium-linux/fast/css/acid2-pixel-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/button-sizes-expected.checksum:
  • platform/chromium-linux/fast/forms/button-sizes-expected.png:
  • platform/chromium-linux/fast/forms/button-sizes-expected.txt:
  • platform/chromium-linux/fast/forms/input-button-sizes-expected.checksum:
  • platform/chromium-linux/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-linux/fast/forms/input-button-sizes-expected.txt:
  • platform/chromium-linux/http/tests/misc/acid2-expected.txt: Removed.
  • platform/chromium-linux/http/tests/misc/acid2-pixel-expected.checksum:
  • platform/chromium-linux/http/tests/misc/acid2-pixel-expected.png:
  • platform/chromium-linux/http/tests/misc/acid2-pixel-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
  • platform/chromium-linux/svg/hixie/perf/003-expected.txt: Added.
  • platform/chromium-linux/svg/hixie/perf/004-expected.txt: Added.
  • platform/chromium-linux/svg/hixie/perf/005-expected.txt: Added.
  • platform/chromium-linux/svg/hixie/perf/006-expected.txt: Added.
  • platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Added.
  • platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-hkern-expected.txt: Removed.
  • platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.checksum: Removed.
  • platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.png: Removed.
  • platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.txt: Removed.
  • platform/chromium-linux/svg/text/text-text-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-01-b-expected.txt:
  • platform/chromium-linux/svg/text/text-text-04-t-expected.txt: Removed.
  • platform/chromium-linux/svg/text/text-vkern-expected.checksum: Removed.
  • platform/chromium-linux/svg/text/text-vkern-expected.txt: Removed.
  • platform/chromium-linux/svg/text/text-vkern-on-horizontal-text-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/chromium-win/svg/batik/text/xmlSpace-expected.txt:
  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
  • platform/chromium-win/svg/text/text-hkern-expected.txt: Removed.
  • platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.checksum:
  • platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.png:
  • platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.txt: Removed.
  • platform/chromium-win/svg/text/text-text-04-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-04-t-expected.png:
  • platform/chromium-win/svg/text/text-text-04-t-expected.txt:
  • platform/chromium-win/svg/text/text-vkern-expected.checksum:
  • platform/chromium-win/svg/text/text-vkern-expected.png:
  • platform/chromium-win/svg/text/text-vkern-expected.txt: Removed.
  • platform/chromium-win/svg/text/text-vkern-on-horizontal-text-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:

2011-01-24 Tony Chang <​tony@chromium.org>

Unreviewed, round ascent and descent to match old code.

  • platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformInit):
9:15 PM Changeset in webkit [76568] by Simon Fraser
  • 8 edits
    2 adds in trunk

2011-01-24 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

perspective() transform function should take lengths
​https://bugs.webkit.org/show_bug.cgi?id=52683

The argument to the perspective() transform function should
be a Length, rather than a bare number. Bare numbers are still
accepted (and treated as px), but this behavior is deprecated.

Test: animations/3d/transform-perspective.html

transforms/3d/general/3dtransform-values.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseTransform): Check the units for the perspective() function. Allow bare numbers for backwards compatibility.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::createTransformOperations): Convert value to Length.
  • platform/graphics/transforms/PerspectiveTransformOperation.cpp: (WebCore::clampToPostiveInteger): Helper. (WebCore::PerspectiveTransformOperation::blend): Blend via Lengths.
  • platform/graphics/transforms/PerspectiveTransformOperation.h: (WebCore::PerspectiveTransformOperation::create): double -> Length. (WebCore::PerspectiveTransformOperation::perspective): Ditto. (WebCore::PerspectiveTransformOperation::isIdentity): Ditto. (WebCore::PerspectiveTransformOperation::apply): Ditto. (WebCore::PerspectiveTransformOperation::PerspectiveTransformOperation): Assert that the Length is a fixed type.
8:38 PM Changeset in webkit [76567] by tkent@chromium.org
  • 4 edits
    2 adds in trunk

2011-01-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Windows] Textfield <input>s have different widths.
​https://bugs.webkit.org/show_bug.cgi?id=48405

  • fast/forms/input-widths-expected.txt: Added.
  • fast/forms/input-widths.html: Added.

2011-01-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Windows] Textfield <input>s have different widths.
​https://bugs.webkit.org/show_bug.cgi?id=48405

  • Apply the padding override for type=text to other textfield types too.
  • Reset margin value of outer spin button, which is not used in Windows.
  • Don't add inner spin button width to the preferred text field width. Text fields should have the identical widths regardless of the existence of spin buttons.

Test: fast/forms/input-widths.html

  • css/themeWin.css: (input[type="week"]): (input[type="week"]:disabled): (input[type="search"]::-webkit-search-cancel-button): (input::-webkit-outer-spin-button):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::preferredContentWidth): Don't add inner spin button width to the preferred width.
8:36 PM Changeset in webkit [76566] by tkent@chromium.org
  • 4 edits
    4 adds in trunk

2011-01-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Some bugs of search cancel button and spin button about state change in
an event handler.
​https://bugs.webkit.org/show_bug.cgi?id=46950

  • fast/forms/input-number-change-type-on-focus-expected.txt: Added.
  • fast/forms/input-number-change-type-on-focus.html: Added.
  • fast/forms/search-hide-cancel-on-cancel-expected.txt: Added.
  • fast/forms/search-hide-cancel-on-cancel.html: Added.

2011-01-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Some bugs of search cancel button and spin button about state change in
an event handler.
​https://bugs.webkit.org/show_bug.cgi?id=46950

Fix the following problems:

  • Type=search field didn't release event capturing
  • Assertion failure when an input field with spin buttons was changed to another type on focus event.
  • A input field with spin button didn't release event capturing when it was changed to another type on focus event.

Tests: fast/forms/input-number-change-type-on-focus.html

fast/forms/search-hide-cancel-on-cancel.html

  • rendering/TextControlInnerElements.cpp: (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
    • Make the variable 'input' RefPtr. It makes the code simpler.
    • Remove visibility check on mouseup event. We should release capturing anyway because the cancel button may be invisible if JavaScript code called by the focus event removes the input value.

(WebCore::SpinButtonElement::detach):

  • Release capturing on detach because it is possible that a spin button node is detached while it is capturing events.

(WebCore::SpinButtonElement::defaultEventHandler):

Take a reference to this and check renderer() after some functions which
may run JavaScript code.

(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):

Make the variable 'input' RefPtr to align other functions in this file.

(WebCore::InputFieldSpeechButtonElement::setRecognitionResult): ditto.

  • rendering/TextControlInnerElements.h: Declare SpinButtonElement::detach().
7:27 PM Changeset in webkit [76565] by rniwa@webkit.org
  • 7 edits in trunk

2011-01-24 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Ojan Vafai.

Inserting multiple whitespace using text composition (IME) should insert interleaved nbsp and whitespace.
​https://bugs.webkit.org/show_bug.cgi?id=52781

The test was rebaselined to have interleaved space and non-breaking space.

  • editing/inserting/insert-composition-whitespace-expected.txt:
  • editing/inserting/insert-composition-whitespace.html:

2011-01-24 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Ojan Vafai.

Inserting multiple whitespace using text composition (IME) should insert interleaved nbsp and whitespace.
​https://bugs.webkit.org/show_bug.cgi?id=52781

The bug was caused by stringWithRebalancedWhitespace's replacing the space at the beginning of a paragraph
and the end of a paragraph by a non-breaking space after it replaced two consecutive spaces by a space and
non-breaking space pattern, thereby replacing more spaces by non-breaking spaces than needed.

Rewrote the function using Vector<UChar> to fix the bug. New function no longer calls String::replace
multiple times but instead it traverses through the string and replaces a space that immediately follows
another space or appears at the beginning of a paragraph or at the end of a paragraph by a non-break space.

  • editing/CompositeEditCommand.cpp:
  • editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): Written.
  • editing/htmlediting.h: (WebCore::isWhitespace): Removed from CompositeEditCommand.cpp
6:56 PM Changeset in webkit [76564] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-01-24 Martin Robinson <​mrobinson@igalia.com>

Skip one more crashing test.

  • platform/gtk/Skipped: Skip a test.
6:48 PM Changeset in webkit [76563] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox):

6:39 PM Changeset in webkit [76562] by kbr@google.com
  • 4 edits
    2 adds in trunk/Source/WebCore

2011-01-24 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

Web Audio API: port FFTFrame to FFTW
​https://bugs.webkit.org/show_bug.cgi?id=52989

Ported FFTFrame class to the open-source FFTW library. Tested with
unit tests from Chris Rogers. Made preliminary changes to GYP
files for conditional compilation of these files; will need to be
adjusted once FFTW is integrated as third-party source.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/audio/FFTFrame.h:
  • platform/audio/fftw: Added.
  • platform/audio/fftw/FFTFrameFFTW.cpp: Added. (WebCore::FFTFrame::FFTFrame): (WebCore::FFTFrame::~FFTFrame): (WebCore::FFTFrame::multiply): (WebCore::FFTFrame::doFFT): (WebCore::FFTFrame::doInverseFFT): (WebCore::FFTFrame::cleanup): (WebCore::FFTFrame::realData): (WebCore::FFTFrame::imagData): (WebCore::FFTFrame::fftwPlanForSize):
6:38 PM Changeset in webkit [76561] by andersca@apple.com
  • 9 edits in trunk/Source

2011-01-24 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Reset the page scale factor on standard frame loads
​https://bugs.webkit.org/show_bug.cgi?id=53058
<rdar://problem/8908844>

Add a symbol needed by WebKit2.

  • WebCore.exp.in:

2011-01-24 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Reset the page scale factor on standard frame loads
​https://bugs.webkit.org/show_bug.cgi?id=53058
<rdar://problem/8908844>

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::scaleWebView): Don't set m_viewScaleFactor here. It will be set in viewScaleFactorDidChange.

(WebKit::WebPageProxy::viewScaleFactorDidChange):
Update m_viewScaleFactor.

  • UIProcess/WebPageProxy.h: Add viewScaleFactorDidChange.
  • UIProcess/WebPageProxy.messages.in: Add ViewScaleFactorDidChange message.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidCommitLoad): Set the scale factor.

(WebKit::WebFrameLoaderClient::restoreViewState):
Inform the UI process about the new view scale factor.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::scaleWebView): Send a ViewScaleFactorDidChange message.
6:21 PM Changeset in webkit [76560] by rniwa@webkit.org
  • 8 edits in trunk/Source/WebCore

2011-01-24 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Stop instantiating legacy editing positions in InsertTextCommand, MoveSelectionCommand,
ReplaceSelectionCommand, SelectionController, SpellChecker, TypingCommand, and markup.cpp
​https://bugs.webkit.org/show_bug.cgi?id=52676

Stop instantiating legacy editing positions in the following files.

  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::prepareForTextInsertion): (WebCore::InsertTextCommand::performTrivialReplace): (WebCore::InsertTextCommand::input): (WebCore::InsertTextCommand::insertTab):
  • editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::doApply):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds): (WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): (WebCore::ReplaceSelectionCommand::performTrivialReplace):
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelectionFromNone):
  • editing/SpellChecker.cpp: (WebCore::SpellChecker::didCheck):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::makeEditableRootEmpty): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • editing/markup.cpp: (WebCore::StyledMarkupAccumulator::appendText): (WebCore::StyledMarkupAccumulator::serializeNodes): (WebCore::highestAncestorToWrapMarkup): (WebCore::createMarkup):
6:08 PM Changeset in webkit [76559] by mjs@apple.com
  • 25 edits
    4 deletes in trunk

2011-01-24 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Anders Carlsson.

Use designated temp directory for the database for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=53052


Adopt the new WK2 API for this.

  • WebKitTestRunner/TestController.cpp: (WTR::TestController::libraryPathForTesting): (WTR::TestController::initialize):
  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformLibraryPathForTesting):
  • WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::TestController::platformLibraryPathForTesting):
  • WebKitTestRunner/win/TestControllerWin.cpp: (WTR::TestController::platformLibraryPathForTesting):

2011-01-24 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Anders Carlsson.

Use designated temp directory for the database for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=53052


Add the API necessary to support this. Database path is now
determined on the UI process side and passed to the Web process.
Reviewed by Anders Carlsson.

  • GNUmakefile.am:
  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
  • Shared/WebProcessCreationParameters.h:
  • UIProcess/API/C/WKContext.cpp: (WKContextSetDatabaseDirectory):
  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/WebContext.cpp: (WebKit::WebContext::ensureWebProcess): (WebKit::WebContext::databaseDirectory):
  • UIProcess/WebContext.h: (WebKit::WebContext::setDatabaseDirectory):
  • UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformDefaultDatabaseDirectory):
  • UIProcess/qt/WebContextQt.cpp: (WebKit::WebContext::platformDefaultDatabaseDirectory):
  • UIProcess/win/WebContextWin.cpp: (WebKit::WebContext::platformDefaultDatabaseDirectory):
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp: (WebKit::WebDatabaseManager::initialize): (WebKit::WebDatabaseManager::WebDatabaseManager):
  • WebProcess/WebCoreSupport/WebDatabaseManager.h:
  • WebProcess/WebCoreSupport/gtk/WebDatabaseManagerGtk.cpp: Removed.
  • WebProcess/WebCoreSupport/mac/WebDatabaseManagerMac.mm: Removed.
  • WebProcess/WebCoreSupport/qt/WebDatabaseManagerQt.cpp: Removed.
  • WebProcess/WebCoreSupport/win/WebDatabaseManagerWin.cpp: Removed.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): (WebKit::WebProcess::initializeWebProcess):
  • WebProcess/com.apple.WebProcess.sb:
  • WebProcess/mac/WebProcessMac.mm: (WebKit::initializeSandbox):
  • win/WebKit2.vcproj:
6:05 PM Changeset in webkit [76558] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-01-24 Martin Robinson <​mrobinson@igalia.com>

Skipping failing tests after r76555.

  • platform/gtk/Skipped: Skip failing tests.
5:36 PM Changeset in webkit [76557] by commit-queue@webkit.org
  • 7 edits in trunk

2011-01-24 Peter Kasting <​pkasting@google.com>

Reviewed by Darin Adler.

Roll back r67261 ("Don't fire onclick on middle clicks") due to
regressions.
​https://bugs.webkit.org/show_bug.cgi?id=46733

  • fast/events/mouse-click-events-expected.txt:
  • fast/events/script-tests/mouse-click-events.js:

2011-01-24 Peter Kasting <​pkasting@google.com>

Reviewed by Darin Adler.

Roll back r67261 ("Don't fire onclick on middle clicks") due to
regressions.
​https://bugs.webkit.org/show_bug.cgi?id=46733

  • html/HTMLAnchorElement.cpp: (WebCore::isLinkClick):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::preDispatchEventHandler): (WebCore::HTMLInputElement::postDispatchEventHandler): (WebCore::HTMLInputElement::defaultEventHandler):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseReleaseEvent):
4:58 PM Changeset in webkit [76556] by xji@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-24 Xiaomei Ji <​xji@chromium.org>

Unreviewed.

Skip cjk-segmentation.html (introduced in r76548) in QT.
QT skipped range-expand.html, skip cjk-segmentation as well.

  • platform/qt/Skipped:
4:47 PM Changeset in webkit [76555] by Martin Robinson
  • 4 edits in trunk

2011-01-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Many DOM XHTML tests time out
​https://bugs.webkit.org/show_bug.cgi?id=52553

  • platform/gtk/Skipped: Unskip tests which are no longer timing out.

2011-01-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Many DOM XHTML tests time out
​https://bugs.webkit.org/show_bug.cgi?id=52553

Properly handle the situation where a synchronous load fails before the inner
event loop has started. In this case, we simply do not run the inner event loop,
or else it will block indefinitely (since no GIO or libsoup callbacks will fire).

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::loadResourceSynchronously): Bail out of a synchronous load if it fails up front.
4:46 PM Changeset in webkit [76554] by Lucas Forschler
  • 2 edits in trunk/Tools

Add a new Leopard test bot.

Reviewed by Stephanie Lewis.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
4:35 PM Changeset in webkit [76553] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Tools

2011-01-24 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Adam Barth.

Add EFL Builder to core waterfall
​https://bugs.webkit.org/show_bug.cgi?id=52704

Add EFL Builder to the core waterfall again.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4:09 PM Changeset in webkit [76552] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-24 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium test expectation update for r76548.

  • platform/chromium/test_expectations.txt:
3:40 PM Changeset in webkit [76551] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix.

  • win/WebKit2.vcproj: Don't build the CG Utilities when building

without CG support.

3:16 PM Changeset in webkit [76550] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-01-24 Anders Carlsson <​andersca@apple.com>

Reviewed by John Sullivan.

Don't use the timeout checker for non-user-interaction messages
​https://bugs.webkit.org/show_bug.cgi?id=53046

  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::didSetSize): (WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
  • UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::sizeDidChange): (WebKit::LayerBackedDrawingAreaProxy::didSetSize):
2:42 PM Changeset in webkit [76549] by zmo@google.com
  • 8 edits in trunk/Source

2011-01-24 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Adler.

Remove sizeInBytes from GraphicsContext3D's various implementations
​https://bugs.webkit.org/show_bug.cgi?id=52339

  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DInternal.h:

2011-01-24 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Adler.

Remove sizeInBytes from GraphicsContext3D's various implementations
​https://bugs.webkit.org/show_bug.cgi?id=52339

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::sizeInBytes):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:
2:25 PM Changeset in webkit [76548] by xji@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-01-24 Xiaomei Ji <​xji@chromium.org>

Reviewed by Ryosuke Niwa.

Add test for Chinese Segmentation.
​https://bugs.webkit.org/show_bug.cgi?id=52926

The CJK segmentation currently does not work in other ports except Chromium.
Please refer to ​https://bugs.webkit.org/show_bug.cgi?id=53044 for detail.

  • fast/text/international/cjk-segmentation-expected.txt: Added.
  • fast/text/international/cjk-segmentation.html: Added.
  • platform/chromium/fast/text/international: Added.
  • platform/chromium/fast/text/international/cjk-segmentation-expected.txt: Added.
2:22 PM Changeset in webkit [76547] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-01-24 Xianzhu Wang <​wangxianzhu@google.com>

Reviewed by Tony Chang.

new-run-webkit-tests fails to start HTTP server if there are proxy settings
​https://bugs.webkit.org/show_bug.cgi?id=52872

Force disabling proxy to resolve the problem.

  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
2:17 PM Changeset in webkit [76546] by Adam Roben
  • 8 edits in trunk/Source

Windows Production build fix

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.vcproj/WebCore.make: Update for move of WebCore into Source.

Source/WebKit/win:

  • WebKit.vcproj/WebKit.make: Update for move of WebKit into Source.

Source/WebKit2:

  • win/WebKit2.make: Update for move of WebKit2 into Source.
2:01 PM Changeset in webkit [76545] by wsiegrist@apple.com
  • 4 edits in trunk/Websites/bugs.webkit.org

2011-01-24 William Siegrist <​wsiegrist@apple.com>

Apply fix for ​https://bugzilla.mozilla.org/show_bug.cgi?id=621591

1:33 PM Changeset in webkit [76544] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-24 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Eric Seidel.

Skip a newly added test that uses textInputController
​https://bugs.webkit.org/show_bug.cgi?id=53027

  • platform/mac-wk2/Skipped:
1:02 PM Changeset in webkit [76543] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

WebKit2: LayoutTests: The UNIMPLEMENTED warnings in TextCheckerWin should be disabled
​https://bugs.webkit.org/show_bug.cgi?id=53029

Reviewed by Adam Roben.

  • UIProcess/win/TextCheckerWin.cpp:

Disable the warnings for this file.

12:31 PM Changeset in webkit [76542] by andreip@google.com
  • 2 edits in trunk/LayoutTests

2011-01-24 Andrei Popescu <​andreip@google.com>

Unreviewed, build fix.

LayoutTest/storage/indexeddb/objectstore-autoincrement.html is failing after r76533
​https://bugs.webkit.org/show_bug.cgi?id=53032

Fix the expected output, which still had an error.

  • storage/indexeddb/objectstore-autoincrement-expected.txt:
12:22 PM Changeset in webkit [76541] by antonm@chromium.org
  • 5 edits
    1 add in trunk/Source/WebCore

2011-01-24 Anton Muhin <​antonm@chromium.org>

Reviewed by Nate Chapin.

[v8] Refactoring: extract IntrusiveDOMWrapperMap into a seprate class and files.
​https://bugs.webkit.org/show_bug.cgi?id=52911

Plain refactoring, covered by the existing tests.

  • WebCore.gypi: IntrusiveDOMWrapperMap.h added.
  • bindings/v8/DOMDataStore.cpp: IntrusiveDOMWrapperMap is moved out of DOMDataStore class.
  • bindings/v8/DOMDataStore.h: IntrusiveDOMWrapperMap is moved out of DOMDataStore class.
  • bindings/v8/IntrusiveDOMWrapperMap.h: Added. (WebCore::ChunkedTable::ChunkedTable): (WebCore::ChunkedTable::add): (WebCore::ChunkedTable::remove): (WebCore::ChunkedTable::clear): (WebCore::ChunkedTable::visit): (WebCore::ChunkedTable::Chunk::Chunk): (WebCore::ChunkedTable::clearEntries): (WebCore::ChunkedTable::visitEntries): (WebCore::IntrusiveDOMWrapperMap::IntrusiveDOMWrapperMap): (WebCore::IntrusiveDOMWrapperMap::get): (WebCore::IntrusiveDOMWrapperMap::set): (WebCore::IntrusiveDOMWrapperMap::contains): (WebCore::IntrusiveDOMWrapperMap::visit): (WebCore::IntrusiveDOMWrapperMap::removeIfPresent): (WebCore::IntrusiveDOMWrapperMap::clear): (WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::move): (WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::clear): (WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::visit):
  • bindings/v8/StaticDOMDataStore.h: include added.
12:11 PM Changeset in webkit [76540] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-24 Kenji Imasaki <​imasaki@chromium.org>

Reviewed by Jian Li.

[chromium] Remove non-flaky tests from test expectation file
​https://bugs.webkit.org/show_bug.cgi?id=53022

  • platform/chromium/test_expectations.txt:
12:07 PM Changeset in webkit [76539] by jam@chromium.org
  • 3 edits in branches/chromium/648/Source/WebKit/chromium

Merge 76455 - 2011-01-22 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Adam Barth.

[chromium]: Fix WebScrollbarImpl not getting scroll events after recent scrollbar refactoring
​https://bugs.webkit.org/show_bug.cgi?id=52967

  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::horizontalScrollbar): (WebKit::WebScrollbarImpl::verticalScrollbar):
  • src/WebScrollbarImpl.h:

TBR=​jam@chromium.org
Review URL: ​http://codereview.chromium.org/6392001

11:43 AM Changeset in webkit [76538] by andreip@google.com
  • 3 edits in trunk/LayoutTests

2011-01-24 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

LayoutTest/storage/indexeddb/objectstore-autoincrement.html is failing after r76533
​https://bugs.webkit.org/show_bug.cgi?id=53032

This fixes the layout test by modifying the arguments to IDBDatabase::transaction.

  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-autoincrement.html:
11:42 AM Changeset in webkit [76537] by commit-queue@webkit.org
  • 14 edits in trunk/Source/WebCore

2011-01-24 Shane Stephens <​shanestephens@google.com>

Reviewed by Chris Marrin.

TransformationMatrix multiply operations apply operands in wrong order.
​https://bugs.webkit.org/show_bug.cgi?id=52780

Rename TranformationMatrix::multLeft into multiply (the method does a multRight,
not a multLeft).

Remove TransformationMatrix::multiply, which was actually doing a multLeft.

Fix TransformationMatrix::operator* and operator*= such that the operand is
applied to the right-hand side of the matrix that the method is called on.
i.e., previously "a * b" used to compute "b * a", and "a *= b" used to store
"b * a" in "a". This has now been fixed so "a * b" computes "a * b" and
"a *= b" stores "a * b" in "a".

Convert all call sites for these methods to provide operands in the correct order.

No new tests as patch adds no new functionality.

  • css/WebKitCSSMatrix.cpp: (WebCore::WebKitCSSMatrix::multiply):
  • platform/graphics/transforms/Matrix3DTransformOperation.h: (WebCore::Matrix3DTransformOperation::apply):
  • platform/graphics/transforms/MatrixTransformOperation.h: (WebCore::MatrixTransformOperation::apply):
  • platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::scaleNonUniform): (WebCore::TransformationMatrix::scale3d): (WebCore::TransformationMatrix::rotate3d): (WebCore::TransformationMatrix::skew): (WebCore::TransformationMatrix::applyPerspective): (WebCore::TransformationMatrix::multiply): (WebCore::TransformationMatrix::recompose):
  • platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::operator*=): (WebCore::TransformationMatrix::operator*):
  • rendering/RenderLayer.cpp: (WebCore::transparencyClipBox):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::getTransformFromContainer):
  • rendering/TransformState.cpp: (WebCore::TransformState::applyTransform): (WebCore::HitTestingTransformState::applyTransform):
11:33 AM Changeset in webkit [76536] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-24 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Wait for half a second if we're asked to paint when receiving a DidSetSize message
​https://bugs.webkit.org/show_bug.cgi?id=53028

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::paint):
11:18 AM Changeset in webkit [76535] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-01-24 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Implement forceRedisplay in the new drawing area
​https://bugs.webkit.org/show_bug.cgi?id=53026

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::forceRepaint):
  • WebProcess/WebPage/DrawingAreaImpl.h:
11:16 AM Changeset in webkit [76534] by Dimitri Glazkov
  • 1 add in branches/chromium/648/codereview.settings

Added codereview.settings file.

11:11 AM Changeset in webkit [76533] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-24 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Fill unpainted rects with the background color.
​https://bugs.webkit.org/show_bug.cgi?id=53025

  • UIProcess/API/mac/WKView.mm: (drawPageBackground): Add new helper function.

(-[WKView drawRect:]):
Iterate over the unpainted rects and fill them with the background color.

11:10 AM Changeset in webkit [76532] by Dimitri Glazkov
  • 1 copy in branches/chromium/648

Branching Chromium 648.

11:01 AM Changeset in webkit [76531] by andreip@google.com
  • 33 edits in trunk

2011-01-24 Andrei Popescu <​andreip@google.com>

Reviewed by Nate Chapin.

IndexedDatabase methods should not take arguments of type OptionsObject
​https://bugs.webkit.org/show_bug.cgi?id=53012

  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/create-object-store-options.html:
  • storage/indexeddb/cursor-delete-expected.txt:
  • storage/indexeddb/cursor-delete.html:
  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/data-corruption-expected.txt:
  • storage/indexeddb/data-corruption.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls.html:
  • storage/indexeddb/tutorial.html:

2011-01-24 Andrei Popescu <​andreip@google.com>

Reviewed by Nate Chapin.

IndexedDatabase methods should not take arguments of type OptionsObject
​https://bugs.webkit.org/show_bug.cgi?id=53012

This patch reverts all IDB methods, except IDBDatabase::createObjectStore and
IDBObjectStore::createIndex, to using a plain list of arguments instead of
grouping the various parameters inside a single OptionsObject argument.
This decision was made on ​public-webapps@w3.org mailing list.

We also add support (v8 only for now) for passing DOMStringList objects as arguments to native
methods. The code for obtaining a DOMStringList object from a JS array of strings existed already
in OptionsObject.cpp, I just copied it to V8Bindings.cpp and taught the v8 code generator how to
use it.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Binding.cpp: (WebCore::v8ValueToWebCoreDOMStringList):
  • bindings/v8/V8Binding.h:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::transaction):
  • storage/IDBDatabase.h: (WebCore::IDBDatabase::transaction):
  • storage/IDBDatabase.idl:
  • storage/IDBIndex.cpp: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor):
  • storage/IDBIndex.h: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor):
  • storage/IDBIndex.idl:
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::openCursor):
  • storage/IDBObjectStore.h: (WebCore::IDBObjectStore::openCursor):
  • storage/IDBObjectStore.idl:
10:33 AM Changeset in webkit [76530] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-01-24 Andreas Kling <​kling@webkit.org>

Reviewed by Darin Adler.

check-webkit-style: Update exemptions following Source/ move.
​https://bugs.webkit.org/show_bug.cgi?id=53017

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
9:54 AM Changeset in webkit [76529] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2 version of <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter

Reviewed by John Sullivan.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setCursor): If the current cursor comes from a cursor rect, do not override it.

9:40 AM Changeset in webkit [76528] by chang.shu@nokia.com
  • 1 edit
    30 moves in trunk/LayoutTests

2011-01-24 Chang Shu <​chang.shu@nokia.com>

Reviewed by Darin Adler.

Move contentEditable related test cases to the right place as they are DOM
related instead of editing related.
​https://bugs.webkit.org/show_bug.cgi?id=53010

  • editing/editability: Removed.
  • editing/editability/attr-empty-string-expected.txt: Removed.
  • editing/editability/attr-empty-string.html: Removed.
  • editing/editability/attr-false-string-expected.txt: Removed.
  • editing/editability/attr-false-string.html: Removed.
  • editing/editability/attr-invalid-string-expected.txt: Removed.
  • editing/editability/attr-invalid-string.html: Removed.
  • editing/editability/attr-missing-ancestor-false-expected.txt: Removed.
  • editing/editability/attr-missing-ancestor-false.html: Removed.
  • editing/editability/attr-missing-ancestor-true-expected.txt: Removed.
  • editing/editability/attr-missing-ancestor-true.html: Removed.
  • editing/editability/attr-missing-parent-ancestor-missing-expected.txt: Removed.
  • editing/editability/attr-missing-parent-ancestor-missing.html: Removed.
  • editing/editability/attr-missing-parent-false-expected.txt: Removed.
  • editing/editability/attr-missing-parent-false.html: Removed.
  • editing/editability/attr-missing-parent-true-expected.txt: Removed.
  • editing/editability/attr-missing-parent-true.html: Removed.
  • editing/editability/attr-true-string-expected.txt: Removed.
  • editing/editability/attr-true-string.html: Removed.
  • editing/editability/set-false-expected.txt: Removed.
  • editing/editability/set-false.html: Removed.
  • editing/editability/set-inherit-parent-false-expected.txt: Removed.
  • editing/editability/set-inherit-parent-false.html: Removed.
  • editing/editability/set-inherit-parent-true-expected.txt: Removed.
  • editing/editability/set-inherit-parent-true.html: Removed.
  • editing/editability/set-invalid-value-expected.txt: Removed.
  • editing/editability/set-invalid-value.html: Removed.
  • editing/editability/set-true-expected.txt: Removed.
  • editing/editability/set-true.html: Removed.
  • editing/editability/set-value-caseinsensitive-expected.txt: Removed.
  • editing/editability/set-value-caseinsensitive.html: Removed.
  • fast/dom/HTMLElement/attr-empty-string-expected.txt: Copied from LayoutTests/editing/editability/attr-empty-string-expected.txt.
  • fast/dom/HTMLElement/attr-empty-string.html: Copied from LayoutTests/editing/editability/attr-empty-string.html.
  • fast/dom/HTMLElement/attr-false-string-expected.txt: Copied from LayoutTests/editing/editability/attr-false-string-expected.txt.
  • fast/dom/HTMLElement/attr-false-string.html: Copied from LayoutTests/editing/editability/attr-false-string.html.
  • fast/dom/HTMLElement/attr-invalid-string-expected.txt: Copied from LayoutTests/editing/editability/attr-invalid-string-expected.txt.
  • fast/dom/HTMLElement/attr-invalid-string.html: Copied from LayoutTests/editing/editability/attr-invalid-string.html.
  • fast/dom/HTMLElement/attr-missing-ancestor-false-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-ancestor-false-expected.txt.
  • fast/dom/HTMLElement/attr-missing-ancestor-false.html: Copied from LayoutTests/editing/editability/attr-missing-ancestor-false.html.
  • fast/dom/HTMLElement/attr-missing-ancestor-true-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-ancestor-true-expected.txt.
  • fast/dom/HTMLElement/attr-missing-ancestor-true.html: Copied from LayoutTests/editing/editability/attr-missing-ancestor-true.html.
  • fast/dom/HTMLElement/attr-missing-parent-ancestor-missing-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-parent-ancestor-missing-expected.txt.
  • fast/dom/HTMLElement/attr-missing-parent-ancestor-missing.html: Copied from LayoutTests/editing/editability/attr-missing-parent-ancestor-missing.html.
  • fast/dom/HTMLElement/attr-missing-parent-false-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-parent-false-expected.txt.
  • fast/dom/HTMLElement/attr-missing-parent-false.html: Copied from LayoutTests/editing/editability/attr-missing-parent-false.html.
  • fast/dom/HTMLElement/attr-missing-parent-true-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-parent-true-expected.txt.
  • fast/dom/HTMLElement/attr-missing-parent-true.html: Copied from LayoutTests/editing/editability/attr-missing-parent-true.html.
  • fast/dom/HTMLElement/attr-true-string-expected.txt: Copied from LayoutTests/editing/editability/attr-true-string-expected.txt.
  • fast/dom/HTMLElement/attr-true-string.html: Copied from LayoutTests/editing/editability/attr-true-string.html.
  • fast/dom/HTMLElement/set-false-expected.txt: Copied from LayoutTests/editing/editability/set-false-expected.txt.
  • fast/dom/HTMLElement/set-false.html: Copied from LayoutTests/editing/editability/set-false.html.
  • fast/dom/HTMLElement/set-inherit-parent-false-expected.txt: Copied from LayoutTests/editing/editability/set-inherit-parent-false-expected.txt.
  • fast/dom/HTMLElement/set-inherit-parent-false.html: Copied from LayoutTests/editing/editability/set-inherit-parent-false.html.
  • fast/dom/HTMLElement/set-inherit-parent-true-expected.txt: Copied from LayoutTests/editing/editability/set-inherit-parent-true-expected.txt.
  • fast/dom/HTMLElement/set-inherit-parent-true.html: Copied from LayoutTests/editing/editability/set-inherit-parent-true.html.
  • fast/dom/HTMLElement/set-invalid-value-expected.txt: Copied from LayoutTests/editing/editability/set-invalid-value-expected.txt.
  • fast/dom/HTMLElement/set-invalid-value.html: Copied from LayoutTests/editing/editability/set-invalid-value.html.
  • fast/dom/HTMLElement/set-true-expected.txt: Copied from LayoutTests/editing/editability/set-true-expected.txt.
  • fast/dom/HTMLElement/set-true.html: Copied from LayoutTests/editing/editability/set-true.html.
  • fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt: Copied from LayoutTests/editing/editability/set-value-caseinsensitive-expected.txt.
  • fast/dom/HTMLElement/set-value-caseinsensitive.html: Copied from LayoutTests/editing/editability/set-value-caseinsensitive.html.
9:37 AM Changeset in webkit [76527] by tony@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-01-24 Tony Chang <​tony@chromium.org>

Reviewed by James Robinson.

[chromium] turn off gyp circular dependency checking and roll chromium deps
​https://bugs.webkit.org/show_bug.cgi?id=52935

  • DEPS:
  • gyp_webkit: Turn off gyp circular dependency checking on Linux

and Win since we don't do these checks in gyp_chromium. It's
just making it harder for us to roll DEPS and have something
explode.

9:35 AM Changeset in webkit [76526] by satish@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-24 Satish Sampath <​satish@chromium.org>

Reviewed by Csaba Osztrogonác.

Remove obsolete public/API method in chromium port
​https://bugs.webkit.org/show_bug.cgi?id=53015

  • public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition): Removed obsolete method
9:29 AM Changeset in webkit [76525] by abecsi@webkit.org
  • 2 edits in trunk/Tools

2011-01-24 Andras Becsi <​abecsi@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

[Qt] Move project files into Source
​https://bugs.webkit.org/show_bug.cgi?id=52891

  • DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
9:25 AM Changeset in webkit [76524] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Add editing/inserting/insert-composition-whitespace.html to the windows
skipped list.

  • platform/win/Skipped:
8:56 AM Changeset in webkit [76523] by Csaba Osztrogonác
  • 42 edits
    115 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected results for passing editing/selections tests.
Compared to Mac png files and Mac expected files. (part 3)

  • platform/qt/editing/selection/ [...]:
8:50 AM Changeset in webkit [76522] by Csaba Osztrogonác
  • 10 edits
    72 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected results for passing editing/selections tests.
Compared to Mac png files and Mac expected files. (part 2)

  • platform/qt/editing/selection/ [...]:
8:37 AM Changeset in webkit [76521] by Csaba Osztrogonác
  • 55 edits
    240 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected results for passing editing/selections tests.
Compared to Mac png files and Mac expected files. (part 1)

  • platform/qt/editing/selection/ [...]:
8:20 AM Changeset in webkit [76520] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

Typo fix.

Rubber-stamped by Csaba Osztrogonác.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess): Move the bracket to the right place.

7:28 AM Changeset in webkit [76519] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-01-24 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract dispatch API from network manager.
​https://bugs.webkit.org/show_bug.cgi?id=53009

  • WebCore.xcodeproj/project.pbxproj:
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager): (WebInspector.NetworkManager.prototype.reset): (WebInspector.NetworkManager.prototype.requestContent): (WebInspector.NetworkManager.prototype._processCachedResources): (WebInspector.NetworkDispatcher): (WebInspector.NetworkDispatcher.prototype._updateResourceWithRequest): (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse): (WebInspector.NetworkDispatcher.prototype._updateResourceWithCachedResource): (WebInspector.NetworkDispatcher.prototype.identifierForInitialRequest): (WebInspector.NetworkDispatcher.prototype.willSendRequest): (WebInspector.NetworkDispatcher.prototype.didReceiveResponse): (WebInspector.NetworkDispatcher.prototype.didLoadResourceFromMemoryCache): (WebInspector.NetworkDispatcher.prototype.didCommitLoadForFrame): (WebInspector.NetworkDispatcher.prototype.didCreateWebSocket): (WebInspector.NetworkDispatcher.prototype._appendRedirect): (WebInspector.NetworkDispatcher.prototype._startResource): (WebInspector.NetworkDispatcher.prototype._updateResource): (WebInspector.NetworkDispatcher.prototype._finishResource): (WebInspector.NetworkDispatcher.prototype._addFramesRecursively): (WebInspector.NetworkDispatcher.prototype._dispatchEventToListeners): (WebInspector.NetworkDispatcher.prototype._createResource):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._innerRequestContent):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype.reset): (WebInspector.ResourceTreeModel.prototype.unbindResourceURL):
7:20 AM Changeset in webkit [76518] by yurys@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-01-24 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [JSC] remove ScriptDebugServer::pageCreated
​https://bugs.webkit.org/show_bug.cgi?id=53007

It's impossible to create "provisional" inspector for pages which are
not yet created so there is no need to listen for page creation in ScriptDebugServer.

  • bindings/js/ScriptDebugServer.cpp:
  • bindings/js/ScriptDebugServer.h:
  • page/Page.cpp: (WebCore::Page::Page):
7:11 AM Changeset in webkit [76517] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-24 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] AppCache view on resources panel is broken.
​https://bugs.webkit.org/show_bug.cgi?id=53002

  • inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView.prototype._update):
  • inspector/front-end/DOMAgent.js: (WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync):
7:01 AM Changeset in webkit [76516] by reni@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] QWebFramePrivate::renderRelativeCoords() calls QPainter::save/restore more than necessary
​https://bugs.webkit.org/show_bug.cgi?id=49915

Reviewed by Andreas Kling.

In the first loop of renderRelativeCoords() the call of QPainter::save/restore is useless, because
the context is saved/stored within the loop.
In the second loop the calls are also avoidable by using inverse translation on context.

  • Api/qwebframe.cpp:

(QWebFramePrivate::renderRelativeCoords):

6:46 AM Changeset in webkit [76515] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-24 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix warnings about unregistering an invalid timer
​https://bugs.webkit.org/show_bug.cgi?id=53006

The ShadowBuffer's purge timer ID was initialized with 0 which lead
to us calling QObject::killTimer(0), causing some qWarnings.

  • platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ShadowBuffer::ShadowBuffer): (WebCore::ShadowBuffer::schedulePurge):
6:39 AM Changeset in webkit [76514] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-21 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Fix heap snapshot table sorting.

Fix table sorting to avoid qsort instability artefacts.

​https://bugs.webkit.org/show_bug.cgi?id=52914

  • inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._sortData): (WebInspector.HeapSnapshotDataGridList.propertyComparator.comparator): (WebInspector.HeapSnapshotDataGridList.propertyComparator):
6:24 AM Changeset in webkit [76513] by Csaba Osztrogonác
  • 2 edits
    1 delete in trunk/LayoutTests

Unreviewed.

RTL: selection.modify("move", "forward", "line") when cursor is at start of a line does not move down a line
​https://bugs.webkit.org/show_bug.cgi?id=51517

  • platform/qt-linux/editing: Removed.
  • platform/qt-linux/editing/selection: Removed.
  • platform/qt-linux/editing/selection/extend-to-line-boundary-expected.txt: Removed.
  • platform/qt/Skipped: Add editing/selection/extend-to-line-boundary.html until fix.
6:16 AM Changeset in webkit [76512] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-24 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, build fix for r76509.

  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setBreakpoint):
6:06 AM Changeset in webkit [76511] by mnaganov@chromium.org
  • 4 edits in trunk

2011-01-24 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Find duplicate strings in localizedStrings.js, update it.

​https://bugs.webkit.org/show_bug.cgi?id=53005

  • English.lproj/localizedStrings.js:
  • Scripts/check-inspector-strings:
6:05 AM Changeset in webkit [76510] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-24 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, build fix for r76509.

  • bindings/js/ScriptDebugServer.h:
5:55 AM Changeset in webkit [76509] by podivilov@chromium.org
  • 20 edits
    1 delete in trunk/Source/WebCore

2011-01-24 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: set breakpoints by line:column.
​https://bugs.webkit.org/show_bug.cgi?id=52615

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint): (WebCore::ScriptDebugServer::hasBreakpoint): (WebCore::ScriptDebugServer::clearBreakpoints):
  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/DebuggerScript.js: ():
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint):
  • bindings/v8/ScriptDebugServer.h:
  • inspector/Inspector.idl:
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setStickyBreakpoint): (WebCore::InspectorDebuggerAgent::setBreakpoint): (WebCore::InspectorDebuggerAgent::restoreBreakpoint): (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/ScriptBreakpoint.cpp: Removed.
  • inspector/ScriptBreakpoint.h: (WebCore::ScriptBreakpoint::ScriptBreakpoint):
  • inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint): (WebInspector.Breakpoint.prototype.get url):
  • inspector/front-end/BreakpointManager.js: (WebInspector.JavaScriptBreakpoint.prototype._serializeToJSON):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.continueToLine): (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype._breakpointSetOnBackend): (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
5:05 AM Changeset in webkit [76508] by Csaba Osztrogonác
  • 1 edit
    1 delete in trunk
  • runtime: Removed. It was accidentally created by r76457.

Rubber-stamped by Csaba Osztrogonác.
Patch by Peter Gal <​galpater@inf.u-szeged.hu> on 2011-01-24

4:58 AM Changeset in webkit [76507] by commit-queue@webkit.org
  • 19 edits
    1 copy
    2 deletes in trunk/Source/WebKit2

2011-01-24 Kimmo Kinnunen <​kimmo.t.kinnunen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove CleanupHandler by passing file descriptors.

Deleting files in signal handler of UI process is not a good idea,
because the memory where filenames are stored might not be valid
after a crash.

To avoid the need of using signal handlers for cleanup,
change following:

1) Avoid passing filenames between processes, pass fds
2) When mmap'ing files, delete them immediately after

opening and mmap'ing them.

3) Pass sockets with fds during fork+exec instead of

passing them via the filesystem.

4) Use mmap'ed files for implementation of SharedMemory.

QSharedMemory does not support cleanup correctly.

Consquences:

  • Move MappedMemory to SharedMemory, make UpdateChunk use this.
  • Implement CoreIPC::Attachment using mmaped files.
  • Send messages using datagram socket. This solution works similiarly to Mach ports on Mac.
  • Send big messages out-of-line and thus avoid increasing the receive buffer.
  • Remove MemoryMappedPool and rely on libc/kernel caching of mmapped areas.
  • Unmap memory areas after use.
  • When UI process crashes, kill the web process using SIGKILL. This is possible again because cleanup handler is not needed.

[WK2][Qt] Multiple problems with MemoryMappedPool
​https://bugs.webkit.org/show_bug.cgi?id=51984

  • Platform/CoreIPC/Attachment.cpp: (CoreIPC::Attachment::Attachment):
  • Platform/CoreIPC/Attachment.h: (CoreIPC::Attachment::size): (CoreIPC::Attachment::releaseFileDescriptor): (CoreIPC::Attachment::fileDescriptor):
  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::MessageInfo::MessageInfo): (CoreIPC::MessageInfo::setMessageBodyOOL): (CoreIPC::MessageInfo::isMessageBodyOOL): (CoreIPC::MessageInfo::bodySize): (CoreIPC::MessageInfo::messageID): (CoreIPC::MessageInfo::attachmentCount): (CoreIPC::Connection::platformInitialize): (CoreIPC::Connection::platformInvalidate): (CoreIPC::SocketNotifierDisableGuard::SocketNotifierDisableGuard): (CoreIPC::SocketNotifierDisableGuard::~SocketNotifierDisableGuard): (CoreIPC::Connection::readyReadHandler): (CoreIPC::Connection::open): (CoreIPC::Connection::platformCanSendOutgoingMessages): (CoreIPC::Connection::sendOutgoingMessage):
  • Platform/SharedMemory.h:
  • Platform/WorkQueue.h:
  • Platform/qt/MappedMemoryPool.cpp: Removed.
  • Platform/qt/MappedMemoryPool.h: Removed.
  • Platform/qt/SharedMemoryQt.cpp: (WebKit::SharedMemory::Handle::Handle): (WebKit::SharedMemory::Handle::~Handle): (WebKit::SharedMemory::Handle::isNull): (WebKit::SharedMemory::Handle::encode): (WebKit::SharedMemory::Handle::decode): (WebKit::SharedMemory::Handle::releaseToAttachment): (WebKit::SharedMemory::Handle::adoptFromAttachment): (WebKit::SharedMemory::create): (WebKit::accessModeMMap): (WebKit::SharedMemory::~SharedMemory): (WebKit::accessModeFile): (WebKit::SharedMemory::createHandle):
  • Platform/qt/WorkQueueQt.cpp: (WorkQueue::registerSocketEventHandler):
  • Shared/qt/UpdateChunk.cpp: (WebKit::UpdateChunk::UpdateChunk): (WebKit::UpdateChunk::~UpdateChunk): (WebKit::UpdateChunk::encode): (WebKit::UpdateChunk::decode): (WebKit::UpdateChunk::createImage):
  • Shared/qt/UpdateChunk.h:
  • UIProcess/Launcher/ProcessLauncher.h:
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::QtWebProcess::QtWebProcess): (WebKit::QtWebProcess::setupChildProcess): (WebKit::ProcessLauncher::launchProcess): (WebKit::ProcessLauncher::platformInvalidate):
  • UIProcess/Launcher/qt/ThreadLauncherQt.cpp: (WebKit::webThreadBody): (WebKit::ThreadLauncher::createWebThread):
  • WebKit2.pro:
  • WebProcess/qt/WebProcessMainQt.cpp: (WebKit::WebProcessMainQt):
4:56 AM Changeset in webkit [76506] by yurys@chromium.org
  • 5 edits in trunk/LayoutTests

2011-01-24 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt:
  • platform/chromium/test_expectations.txt:
4:46 AM Changeset in webkit [76505] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-24 Peter Beverloo <​peter@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: recognize application/x-font-woff as a valid mime-type.
​https://bugs.webkit.org/show_bug.cgi?id=52977

No new tests.

  • inspector/front-end/inspector.js:
3:55 AM Changeset in webkit [76504] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-24 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, fix for r76497.

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show):
3:53 AM Changeset in webkit [76503] by zoltan@webkit.org
  • 3 edits in trunk/Tools

[Qt] Regroup MiniBrowser's menubar and add open file action
​https://bugs.webkit.org/show_bug.cgi?id=53000

Reviewed by Andreas Kling.

Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::openFile):
(BrowserWindow::~BrowserWindow):

  • MiniBrowser/qt/BrowserWindow.h:
3:52 AM Changeset in webkit [76502] by pvarga@webkit.org
  • 5 edits in trunk

2011-01-24 Peter Varga <​pvarga@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

Optimize regex patterns which contain empty alternatives
​https://bugs.webkit.org/show_bug.cgi?id=51395

Eliminate the empty alternatives from the regex pattern and convert it to do
the matching in an easier way.

  • fast/regex/script-tests/slow.js:
  • fast/regex/slow-expected.txt:

2011-01-24 Peter Varga <​pvarga@webkit.org>

Reviewed by Oliver Hunt.

Optimize regex patterns which contain empty alternatives
​https://bugs.webkit.org/show_bug.cgi?id=51395

Eliminate the empty alternatives from the regex pattern and convert it to do
the matching in an easier way.

  • yarr/YarrPattern.cpp: (JSC::Yarr::YarrPatternConstructor::atomParenthesesEnd):
3:51 AM Changeset in webkit [76501] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-01-24 Andreas Kling <​kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Use rad2deg() from WTF instead of rolling our own.
​https://bugs.webkit.org/show_bug.cgi?id=52993

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::rotate):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):
3:35 AM Changeset in webkit [76500] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-24 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, test fix for r76497.

  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.setBreakpointInVisibleView): (initialize_DebuggerTest.InspectorTest._showScriptSource):
3:22 AM Changeset in webkit [76499] by Csaba Osztrogonác
  • 4 edits in trunk/Tools

Unreviewed fix after r76496

[Qt] Move project files into Source
​https://bugs.webkit.org/show_bug.cgi?id=52891

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
  • BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
  • Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
2:57 AM Changeset in webkit [76498] by sergio@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-24 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[Gtk] ResourceHandleSoup: do not wait for streams to close to issue didFinishLoading
​https://bugs.webkit.org/show_bug.cgi?id=52885

No new tests as it does not change functionality. We will not wait for
the the input stream to close to issue didFinishLoading to
WebCore. We expect a subtle performance improvement with this
patch when loading complex web pages, as we wouldn't have to wait
for the stream to close (which involves creating a thread among
other things).

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::closeCallback): (WebCore::readCallback):
2:38 AM Changeset in webkit [76497] by podivilov@chromium.org
  • 10 edits
    2 deletes in trunk/Source/WebCore

2011-01-21 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: eliminate SourceView and ScriptView classes.
​https://bugs.webkit.org/show_bug.cgi?id=52896

SourceView and ScriptView delegate everything to SourceFrame and should be eliminated.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/GoToLineDialog.js: (WebInspector.GoToLineDialog.prototype._highlightSelectedLine):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.createResourceView): (WebInspector.ResourceView.resourceViewTypeMatchesResource): (WebInspector.SourceFrameContentProviderForResource): Moved from SourceView.
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype._applyDiffMarkup): (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated):
  • inspector/front-end/ScriptView.js: Removed.
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._scriptSourceChanged): (WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource): (WebInspector.ScriptsPanel.prototype._showScriptOrResource): (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions): (WebInspector.ScriptsPanel.prototype._formatScript): (WebInspector.SourceFrameContentProviderForScript): Moved from ScriptView.
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.show): (WebInspector.SourceFrame.prototype.hide): (WebInspector.SourceFrame.prototype.hasContent): (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches): (WebInspector.SourceFrame.prototype.performSearch):
  • inspector/front-end/SourceView.js: Removed.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
2:36 AM Changeset in webkit [76496] by abecsi@webkit.org
  • 26 edits
    1 copy
    3 moves
    2 adds
    1 delete in trunk

2011-01-24 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Move project files into Source
​https://bugs.webkit.org/show_bug.cgi?id=52891

  • Source/DerivedSources.pro: Copied from DerivedSources.pro.
  • Source/WebKit.pri: Renamed from WebKit.pri.
  • Source/WebKit.pro: Added.
  • Source/common.pri: Renamed from common.pri.
  • WebKit.pro: Removed.

2011-01-24 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Move project files into Source
​https://bugs.webkit.org/show_bug.cgi?id=52891

2011-01-24 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Move project files into Source
​https://bugs.webkit.org/show_bug.cgi?id=52891

No new tests needed.

  • WebCore.pri:
  • WebCore.pro:

2011-01-24 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Move project files into Source
​https://bugs.webkit.org/show_bug.cgi?id=52891

  • declarative/declarative.pro:
  • docs/docs.pri:
  • tests/tests.pri:

2011-01-24 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Move project files into Source
​https://bugs.webkit.org/show_bug.cgi?id=52891

  • DerivedSources.pro:
  • WebKit2.pro:
  • WebProcess.pro:

2011-01-24 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Move project files into Source
​https://bugs.webkit.org/show_bug.cgi?id=52891

  • DerivedSources.pro: Renamed from DerivedSources.pro.
  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • MiniBrowser/DerivedSources.pro:
  • MiniBrowser/qt/MiniBrowser.pro:
  • QtTestBrowser/QtTestBrowser.pro:
  • Scripts/webkitdirs.pm:
  • Tools.pro: Added.
  • WebKitTestRunner/DerivedSources.pro:
  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  • WebKitTestRunner/qt/WebKitTestRunner.pro:
2:32 AM Changeset in webkit [76495] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, trivial fix.

Fix a Chromium-only assertion failure by r76491.
​https://bugs.webkit.org/show_bug.cgi?id=38982

Separate icon loading from the FileChooser constructor in order to avoid
ref() before adoptRef().

  • platform/FileChooser.cpp:

(WebCore::FileChooser::FileChooser):
(WebCore::FileChooser::initialize):
(WebCore::FileChooser::create):

  • platform/FileChooser.h:
2:27 AM Changeset in webkit [76494] by morrita@google.com
  • 3 edits in trunk/Source/WebCore

2011-01-24 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

TextControlInnerElement::m_shadowParent should be removed.
​https://bugs.webkit.org/show_bug.cgi?id=52998

No new tests. No behavioral change.

  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::TextControlInnerElement):
  • rendering/TextControlInnerElements.h:
2:20 AM Changeset in webkit [76493] by yurys@chromium.org
  • 10 edits
    2 adds in trunk/Source/WebCore

2011-01-24 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

REGRESSION (r72895): console.trace crashes
​https://bugs.webkit.org/show_bug.cgi?id=52981

  • Use local RefPtr variable for accessing PassRefPtr arguments to make sure the PassRefPtr has non-null value.
  • Use PassRefPtr for objects whos ownership is passed to the inspector.
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorConsoleInstrumentation.h: Added. Extract inline methods called from the console into their own header to reduce compilation time of other classes that depend on the inspector instrumentation. (WebCore::InspectorInstrumentation::addMessageToConsole): (WebCore::InspectorInstrumentation::consoleCount): (WebCore::InspectorInstrumentation::startConsoleTiming): (WebCore::InspectorInstrumentation::stopConsoleTiming): (WebCore::InspectorInstrumentation::consoleMarkTimeline): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole): (WebCore::InspectorInstrumentation::addProfile): (WebCore::InspectorInstrumentation::profilerEnabled): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
  • inspector/InspectorDatabaseInstrumentation.h: Added. Extract inline methods called from the datanase code into their own header to reduce compilation time of other classes that depend on the inspector instrumentation. (WebCore::InspectorInstrumentation::didOpenDatabase):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addMessageToConsoleImpl): (WebCore::InspectorInstrumentation::consoleCountImpl): (WebCore::InspectorInstrumentation::stopConsoleTimingImpl): (WebCore::InspectorInstrumentation::consoleMarkTimelineImpl): (WebCore::InspectorInstrumentation::addProfileImpl): (WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
  • inspector/InspectorInstrumentation.h:
  • page/Console.cpp: use RefPtr local variable instead of accessing PassRefPtr argument directly. (WebCore::Console::addMessage): (WebCore::Console::trace): (WebCore::Console::count): (WebCore::Console::markTimeline): (WebCore::Console::profileEnd): (WebCore::Console::timeEnd): (WebCore::Console::group): (WebCore::Console::groupCollapsed):
  • storage/Database.cpp: (WebCore::Database::openDatabase):
1:16 AM Changeset in webkit [76492] by yuzo@google.com
  • 1 edit
    10 adds in trunk/LayoutTests

2011-01-24 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

Update Chromim test expectations (LINUX/SVG) in response to r76442, again.

  • platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Added.
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.txt: Added.
  • platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-hkern-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.checksum: Added.
  • platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.png: Added.
  • platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-text-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-vkern-expected.checksum: Added.
  • platform/chromium-linux/svg/text/text-vkern-expected.txt: Added.
1:15 AM Changeset in webkit [76491] by tkent@chromium.org
  • 8 edits
    1 copy
    3 moves in trunk/Source

2010-01-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Support icon loading for <input type=file>
​https://bugs.webkit.org/show_bug.cgi?id=38982

An icon data in Chromium port is represented as WebCore::Image. We
don't need OS-specific code anymore.

  • WebCore.gypi:
  • platform/graphics/Icon.h: (WebCore::Icon::create): Add Chromium-specific factory.
  • platform/graphics/chromium/IconChromium.cpp: Added.
  • platform/graphics/chromium/IconChromiumLinux.cpp: Removed.
  • platform/graphics/chromium/IconChromiumMac.cpp: Removed.
  • platform/graphics/chromium/IconChromiumWin.cpp: Removed.
  • platform/graphics/chromium/PlatformIcon.h:

2010-01-24 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Support icon loading for <input type=file>
​https://bugs.webkit.org/show_bug.cgi?id=38982

Implement ChromeClientImpl::chooseIconForFiles(). It delegates loading
to WebViewClient::queryIconForFiles(), and an implementation of
WebViewClient::queryIconForFiles() loads an icon and passes it to a
FileChooser through WebIconLoadingCompletion.

  • WebKit.gyp:
  • public/WebIconLoadingCompletion.h: Added. (WebKit::WebIconLoadingCompletion::~WebIconLoadingCompletion):
  • public/WebViewClient.h: (WebKit::WebViewClient::queryIconForFiles):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::chooseIconForFiles):
  • src/WebIconLoadingCompletionImpl.cpp: Added. (WebKit::WebIconLoadingCompletionImpl::WebIconLoadingCompletionImpl): (WebKit::WebIconLoadingCompletionImpl::~WebIconLoadingCompletionImpl): (WebKit::WebIconLoadingCompletionImpl::didLoadIcon):
  • src/WebIconLoadingCompletionImpl.h: Added.
1:10 AM Changeset in webkit [76490] by alex
  • 2 edits in trunk/LayoutTests

2011-01-24 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, GTK still does not have TestInputController support. Opened
a bug to follow the issue:
​https://bugs.webkit.org/show_bug.cgi?id=52997

  • platform/gtk/Skipped:
1:05 AM Changeset in webkit [76489] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-01-24 MORITA Hajime <​morrita@google.com>

Unreviewed, skipped insert-composition-whitespace.html due to missing DRT feature.

  • platform/gtk/Skipped:
12:44 AM Changeset in webkit [76488] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-21 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move search functions from SourceView to SourceFrame.
​https://bugs.webkit.org/show_bug.cgi?id=52895

This is the last step before eliminating SourceView and ScriptView since
this classes just delegate everything to SourceFrame.

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.set visible): (WebInspector.SourceFrame.prototype._clearLineHighlight): (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches): (WebInspector.SourceFrame.prototype.performSearch): (WebInspector.SourceFrame.prototype.searchCanceled): (WebInspector.SourceFrame.prototype.jumpToFirstSearchResult): (WebInspector.SourceFrame.prototype.jumpToLastSearchResult): (WebInspector.SourceFrame.prototype.jumpToNextSearchResult): (WebInspector.SourceFrame.prototype.jumpToPreviousSearchResult): (WebInspector.SourceFrame.prototype.showingFirstSearchResult): (WebInspector.SourceFrame.prototype.showingLastSearchResult): (WebInspector.SourceFrame.prototype._jumpToSearchResult):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.hide): (WebInspector.SourceView.prototype.searchCanceled): (WebInspector.SourceView.prototype.performSearch): (WebInspector.SourceView.prototype.jumpToFirstSearchResult): (WebInspector.SourceView.prototype.jumpToLastSearchResult): (WebInspector.SourceView.prototype.jumpToNextSearchResult): (WebInspector.SourceView.prototype.jumpToPreviousSearchResult): (WebInspector.SourceView.prototype.showingFirstSearchResult): (WebInspector.SourceView.prototype.showingLastSearchResult): (WebInspector.SourceView.prototype.clearMessages):
12:33 AM Changeset in webkit [76487] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-24 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r76463.
​http://trac.webkit.org/changeset/76463
​https://bugs.webkit.org/show_bug.cgi?id=52993

It broke canvas/philip/tests/2d.path.stroke.skew.html
(Requested by Ossy on #webkit).

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::rotate):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):
12:33 AM Changeset in webkit [76486] by alex
  • 2 edits in trunk/LayoutTests

2011-01-24 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, skipped tests failing the 64bits bot and passing in the
32bits bots. Bug following the issue:
​https://bugs.webkit.org/show_bug.cgi?id=52996

  • platform/gtk/Skipped:

Jan 23, 2011:

11:52 PM Changeset in webkit [76485] by yuzo@google.com
  • 2 edits
    15 adds in trunk/LayoutTests

2011-01-23 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

Update Chromim test expectations (LINUX/SVG) in response to r76442.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-vkern-on-horizontal-text-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:19 PM Changeset in webkit [76484] by yuzo@google.com
  • 14 edits
    3 adds in trunk/LayoutTests

2011-01-23 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.

Update Chromim test expectations (WIN/SVG) in response to r76442.

  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
  • platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.checksum:
  • platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.png:
  • platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.txt: Added.
  • platform/chromium-win/svg/text/text-text-04-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-04-t-expected.png:
  • platform/chromium-win/svg/text/text-text-04-t-expected.txt:
  • platform/chromium-win/svg/text/text-vkern-expected.checksum:
  • platform/chromium-win/svg/text/text-vkern-expected.png:
  • platform/chromium-win/svg/text/text-vkern-expected.txt: Added.
11:13 PM Changeset in webkit [76483] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-23 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: summary bar is not resized properly with the rest of net
​https://bugs.webkit.org/show_bug.cgi?id=52881

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.updateSidebarWidth): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._toggleGridMode):
10:53 PM Changeset in webkit [76482] by morrita@google.com
  • 12 edits
    2 adds in trunk

2011-01-19 MORITA Hajime <​morrita@google.com>

Reviewed by Ryosuke Niwa.

Space and tab characters "sent" by an input method give totally different results than typing them directly.
​https://bugs.webkit.org/show_bug.cgi?id=5241

Added a test that exercises continous whitespace characters and tabs inserted by IME.

  • editing/inserting/insert-composition-whitespace-expected.txt: Added.
  • editing/inserting/insert-composition-whitespace.html: Added.

2011-01-19 MORITA Hajime <​morrita@google.com>

Reviewed by Ryosuke Niwa.

Space and tab characters "sent" by an input method give totally different results than typing them directly
​https://bugs.webkit.org/show_bug.cgi?id=5241

  • Introduced TextEvent::InputTypeComposition and TypingCommand::TextCompositionType to distinguish text input which is originated by composition.
  • Generalized rebalanceWhitespaceAt() to rebalanceWhitespaceOnTextSubstring() to rebalancing range of string on text node, instead of surrounding part of that.

Test: editing/inserting/insert-composition-whitespace.html

  • dom/TextEvent.h: (WebCore::TextEvent::isComposition):
  • dom/TextEventInputType.h: Added TextEventInputComposition as a member of TextEvent::InputType
  • editing/CompositeEditCommand.cpp: (WebCore::containsOnlyWhitespace): (WebCore::CompositeEditCommand::shouldRebalanceLeadingWhitespaceFor): (WebCore::CompositeEditCommand::canRebalance): (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): Added: A generalized version of rebalanceWhitespaceAt(), which takes a range inside Text string.
  • editing/CompositeEditCommand.h:
  • editing/Editor.cpp: (WebCore::Editor::insertTextForConfirmedComposition): Added. (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::confirmComposition): Now uses insertTextForConfirmedComposition(). (WebCore::Editor::setComposition):
  • editing/Editor.h:
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
  • editing/InsertTextCommand.h:
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::insertTextRunWithoutNewlines):
  • editing/TypingCommand.h: Added TypingCommand::m_compositionType and TypingCommand::TextCompositionType (WebCore::TypingCommand::setCompositionType): Added. (WebCore::TypingCommand::create):
9:37 PM Changeset in webkit [76481] by yuzo@google.com
  • 15 edits
    4 adds in trunk/LayoutTests

2011-01-23 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.
Update Chromim test expectations (WIN) in response to r76442.

  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/chromium-win/svg/batik/text/xmlSpace-expected.txt:
  • platform/chromium-win/svg/text/text-hkern-expected.txt: Added.
  • platform/chromium-win/svg/text/text-vkern-on-horizontal-text-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
8:52 PM Changeset in webkit [76480] by tkent@chromium.org
  • 2 edits in branches/chromium/597/WebCore

Merge 76319

2011-01-20 Xiaomei Ji <​xji@chromium.org>

Reviewed by Dan Bernstein.

Fix regression(r71566): PDF in RTL block might messes up text directionality.
​https://bugs.webkit.org/show_bug.cgi?id=52776

Test: fast/dom/52776.html

  • platform/text/BidiResolver.h: (WebCore::::checkDirectionInLowerRaiseEmbeddingLevel): (WebCore::::lowerExplicitEmbeddingLevel): (WebCore::::raiseExplicitEmbeddingLevel): (WebCore::::createBidiRunsForLine):

BUG=70234
TBR=laforge

7:48 PM Changeset in webkit [76479] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-01-23 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.
Mark fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html as TEXT for LINUX.

  • platform/chromium/test_expectations.txt:
7:46 PM Changeset in webkit [76478] by mrowe@apple.com
  • 8 edits in trunk/Source

Follow-up to r76477.

Fix the scripts that detect problematic code such as static initializers
and destructors, weak vtables, inappropriate files in the framework wrappers,
and public headers including private headers. These had all been broken
since the projects were moved in to the Source directory as the paths to the
scripts were not updated at that time.

Source/JavaScriptCore:

Source/JavaScriptGlue:

  • JavaScriptGlue.xcodeproj/project.pbxproj:

Source/WebCore:

Stop copying an IDL file in to the framework wrapper. Doing that doesn't even make sense.

  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:
7:26 PM Changeset in webkit [76477] by mrowe@apple.com
  • 3 edits in trunk/Source/WebCore

Build fix after r76459.

Static member variables or globals of types that have constructors or destructors are bad as
they generate static initializers and destructors. This is code that is run either at link time
when the library is loaded in to memory or at application termination time. Both of these are
terrible for performance and are thus outlawed in WebKit code.

The typical solution is to replace the static member or global with a function that allocates
the necessary variable on the heap. The variable is leaked to prevent it from being destroyed
at application termination time. The DEFINE_STATIC_LOCAL macro wraps this in to a concise little
package, but sadly fails to work in this case due to the type containing multiple template
parameters.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::inspectorAgents):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::bindInspectorAgent):
(WebCore::InspectorInstrumentation::unbindInspectorAgent):
(WebCore::InspectorInstrumentation::inspectorAgentForPage):

6:33 PM Changeset in webkit [76476] by yuzo@google.com
  • 15 edits
    4 adds
    7 deletes in trunk/LayoutTests

2011-01-23 Yuzo Fujishima <​yuzo@google.com>

Unreviewed Chromium test expectation change.
Update Chromim test expectations in response to r76442.

  • platform/chromium-linux/fast/css/acid2-expected.txt: Added.
  • platform/chromium-linux/fast/css/acid2-pixel-expected.checksum:
  • platform/chromium-linux/fast/css/acid2-pixel-expected.png:
  • platform/chromium-linux/fast/css/acid2-pixel-expected.txt: Added.
  • platform/chromium-linux/fast/forms/button-sizes-expected.checksum:
  • platform/chromium-linux/fast/forms/button-sizes-expected.png:
  • platform/chromium-linux/fast/forms/button-sizes-expected.txt:
  • platform/chromium-linux/fast/forms/input-button-sizes-expected.checksum:
  • platform/chromium-linux/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-linux/fast/forms/input-button-sizes-expected.txt:
  • platform/chromium-linux/http/tests/misc/acid2-expected.txt: Added.
  • platform/chromium-linux/http/tests/misc/acid2-pixel-expected.checksum:
  • platform/chromium-linux/http/tests/misc/acid2-pixel-expected.png:
  • platform/chromium-linux/http/tests/misc/acid2-pixel-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • platform/chromium-linux/svg/hixie/perf/003-expected.txt: Removed.
  • platform/chromium-linux/svg/hixie/perf/004-expected.txt: Removed.
  • platform/chromium-linux/svg/hixie/perf/005-expected.txt: Removed.
  • platform/chromium-linux/svg/hixie/perf/006-expected.txt: Removed.
  • platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Removed.
  • platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Removed.
  • platform/chromium-linux/svg/text/text-text-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-01-b-expected.txt:
5:53 PM Changeset in webkit [76475] by vangelis@chromium.org
  • 11 edits in trunk/Source/WebCore

2011-01-21 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Add support for -webkit-mask properties to the
accelerated compositing path.
​https://bugs.webkit.org/show_bug.cgi?id=49780


Tests: Existing tests in LayoutTests/compositing/masks

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::draw): (WebCore::ContentLayerChromium::unreserveContentsTexture): (WebCore::ContentLayerChromium::bindContentsTexture):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setMaskLayer):
  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::setMaskLayer): (WebCore::LayerChromium::maskLayer): (WebCore::LayerChromium::unreserveContentsTexture): (WebCore::LayerChromium::bindContentsTexture):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateLayersRecursive):
  • platform/graphics/chromium/LayerTexture.cpp: (WebCore::LayerTexture::bindTexture):
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::SharedValues::SharedValues): (WebCore::RenderSurfaceChromium::SharedValues::~SharedValues): (WebCore::RenderSurfaceChromium::RenderSurfaceChromium): (WebCore::RenderSurfaceChromium::draw):
  • platform/graphics/chromium/RenderSurfaceChromium.h: (WebCore::RenderSurfaceChromium::SharedValues::maskShaderProgram): (WebCore::RenderSurfaceChromium::SharedValues::maskShaderSamplerLocation): (WebCore::RenderSurfaceChromium::SharedValues::maskShaderMaskSamplerLocation): (WebCore::RenderSurfaceChromium::SharedValues::maskShaderMatrixLocation): (WebCore::RenderSurfaceChromium::SharedValues::maskShaderAlphaLocation):
5:00 PM Changeset in webkit [76474] by Patrick Gansterer
  • 8 edits in trunk/Source

2011-01-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Use WTF::StringHasher in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=52934

Add an additional function to calculate the hash
of data with a runtimedependent size.

  • wtf/StringHasher.h: (WTF::StringHasher::createBlobHash):

2011-01-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Use WTF::StringHasher in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=52934

  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::urlHostHash):
  • platform/LinkHash.cpp: (WebCore::visitedLinkHashInline):
  • platform/cf/BinaryPropertyList.cpp: (WebCore::IntegerArrayHash::hash):
  • platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::computeHash):
  • platform/network/ProtectionSpaceHash.h: (WebCore::ProtectionSpaceHash::hash):
3:50 PM Changeset in webkit [76473] by kdecker@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-23 Damian Kaleta <​dkaleta@apple.com>

Reviewed by Kevin Decker.

<rdar://problem/8905171>
​https://bugs.webkit.org/show_bug.cgi?id=52985

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::scaleWebView): Eliminated early return inside WebPageProxy::scaleWebView, making it consistent with WebKit1.
3:17 PM Changeset in webkit [76472] by Patrick Gansterer
  • 11 edits in trunk/Source/WebCore

2011-01-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Add an overload to base64Encode with String output
​https://bugs.webkit.org/show_bug.cgi?id=50122

This change removes duplicated code.

  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceContentBase64):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::btoa):
  • platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::createUniqueFontName):
  • platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::createUniqueFontName):
  • platform/graphics/wince/FontCustomPlatformData.cpp: (WebCore::createUniqueFontName):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::encodeBasicAuthorization):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::encodeBasicAuthorization):
  • platform/text/Base64.cpp: (WebCore::base64Encode):
  • platform/text/Base64.h: (WebCore::base64Encode):
  • platform/wince/KeygenWinCE.cpp: (WebCore::WebCore::signedPublicKeyAndChallengeString):
2:57 PM Changeset in webkit [76471] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Fix comment in String::ascii()
​https://bugs.webkit.org/show_bug.cgi?id=52980

  • wtf/text/WTFString.cpp: (WTF::String::ascii):
2:28 PM Changeset in webkit [76470] by ap@apple.com
  • 3 edits
    2 adds in trunk/Source/WebKit2

2011-01-23 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=52968
Use a separate NSView for printing

Also addresses <rdar://problem/8900148> Improper check for
-[NSGraphicsContext currentContextDrawingToScreen]

  • UIProcess/API/mac/WKPrintingView.h: Added.
  • UIProcess/API/mac/WKPrintingView.mm: Added. (-[WKPrintingView initWithFrameProxy:]): (-[WKPrintingView isFlipped]): (-[WKPrintingView _adjustPrintingMarginsForHeaderAndFooter]): (-[WKPrintingView knowsPageRange:]): (-[WKPrintingView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): (-[WKPrintingView drawPageBorderWithSize:]): (-[WKPrintingView _provideTotalScaleFactorForPrintOperation:]): (-[WKPrintingView rectForPage:]):
  • UIProcess/API/mac/WKView.mm: (-[WKView drawRect:]): (-[WKView canChangeFrameLayout:]): (-[WKView printOperationWithPrintInfo:forFrame:]):
  • WebKit2.xcodeproj/project.pbxproj: Moved printing code to a separate view, simplifying as appropriate. The view is currently not referenced by anything in WebKit2 directly, being owned by NSPrintOperation.
2:02 PM Changeset in webkit [76469] by Patrick Gansterer
  • 4 edits in trunk/Source

2011-01-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Add String::containsOnlyLatin1()
​https://bugs.webkit.org/show_bug.cgi?id=52979

  • wtf/text/WTFString.h: (WTF::String::containsOnlyLatin1): (WTF::charactersAreAllLatin1):

2011-01-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Add String::containsOnlyLatin1()
​https://bugs.webkit.org/show_bug.cgi?id=52979

Use String::containsOnlyLatin1() instead of isSafeToConvertCharList().

  • page/DOMWindow.cpp: (WebCore::DOMWindow::btoa): (WebCore::DOMWindow::atob):
1:08 PM Changeset in webkit [76468] by ap@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2011-01-23 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=15649
Empty STYLE elements are not reflected into the document.styleSheets object

Adding a test for a bug that no longer occurs.

  • fast/dom/document-stylesheets-empty-style-expected.txt: Added.
  • fast/dom/document-stylesheets-empty-style.html: Added.
11:50 AM Changeset in webkit [76467] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-01-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Add missing CodeGenerator dependencies
​https://bugs.webkit.org/show_bug.cgi?id=52976

  • CMakeLists.txt:
11:28 AM Changeset in webkit [76466] by yael.aharon@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-01-23 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt][Symbian] Fix --minimal build
​https://bugs.webkit.org/show_bug.cgi?id=52839

Some of the plugins' functionality is reimplemented in
Symbian specific files.
Some of this functionality should be compiled in even if
the guard NETSCAPE_PLUGIN_API is turned off.
This patch moves that functionality out of the
NETSCAPE_PLUGIN_API guard.

Build fix so no new tests.

  • WebCore.pro:
  • plugins/symbian/PluginPackageSymbian.cpp:
11:16 AM Changeset in webkit [76465] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Oliver Hunt.

Remove obsolete JSVALUE32 code
​https://bugs.webkit.org/show_bug.cgi?id=52948

r70111 removed support for JSVALUE32.
ARM, MIPS and X86 support JSVALUE32_64 only.

  • jit/JITStubs.cpp:
9:33 AM Changeset in webkit [76464] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

<rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter

Reviewed by John Sullivan.

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::setCursor): If the current cursor comes from a cursor rect, do not override it.

8:24 AM Changeset in webkit [76463] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-01-23 Andreas Kling <​kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Use rad2deg() from WTF instead of rolling our own.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::rotate):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):
6:43 AM Changeset in webkit [76462] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-23 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Andreas Kling.

Viewport meta: Always adjust device dimensions to the device pixel ratio.

  • dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):
6:33 AM Changeset in webkit [76461] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-23 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Don't scale absolute geometry specified by viewport meta tag.

  • dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):
2:48 AM Changeset in webkit [76460] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-23 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed build fix.

Web Inspector: looks like efl doesn't regenerate InspectorBackendDispatcher.

Touch Inspector.idl.

  • inspector/Inspector.idl:
1:36 AM Changeset in webkit [76459] by pfeldman@chromium.org
  • 33 edits
    2 copies in trunk/Source

2011-01-22 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: next step in splitting InspectorController.

Splitting InspectorController is a bit tricky process.

As a first step I'll do the next things:
1) rename existing InspectorController to InspectorAgent;
2) s/nspectorController/nspectorAgent/g everywhere in WebCore/inspector but InspectorInstrumentation;
3) create a fake InspectorController derived from the InspectorAgent for the rest of WebCore and WebKit;

The second step is a migration of a small set of functions described in bug 52510 from InspectorAgent to InspectorController.

As far as the second step will have significant changes in the functions' implementation I'll do it as a separate patch.

​https://bugs.webkit.org/show_bug.cgi?id=52955

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::nodeForId): (WebCore::JSInjectedScriptHost::selectDOMStorage):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::nodeForIdCallback):
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::clearConsoleMessages): (WebCore::InjectedScriptHost::databaseForId): (WebCore::InjectedScriptHost::selectDatabase): (WebCore::InjectedScriptHost::selectDOMStorage): (WebCore::InjectedScriptHost::injectedScriptForMainFrame): (WebCore::InjectedScriptHost::inspectorDOMAgent): (WebCore::InjectedScriptHost::frontend): (WebCore::InjectedScriptHost::didCreateWorker): (WebCore::InjectedScriptHost::didDestroyWorker):
  • inspector/InjectedScriptHost.h: (WebCore::InjectedScriptHost::create): (WebCore::InjectedScriptHost::inspectorAgent): (WebCore::InjectedScriptHost::disconnectController):
  • inspector/InspectorAgent.cpp: Copied from Source/WebCore/inspector/InspectorController.cpp. (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::~InspectorAgent): (WebCore::InspectorAgent::inspectedPageDestroyed): (WebCore::InspectorAgent::enabled): (WebCore::InspectorAgent::inspectorStartsAttached): (WebCore::InspectorAgent::setInspectorStartsAttached): (WebCore::InspectorAgent::setInspectorAttachedHeight): (WebCore::InspectorAgent::inspectorAttachedHeight): (WebCore::InspectorAgent::searchingForNodeInPage): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::inspect): (WebCore::InspectorAgent::focusNode): (WebCore::InspectorAgent::highlight): (WebCore::InspectorAgent::highlightDOMNode): (WebCore::InspectorAgent::highlightFrame): (WebCore::InspectorAgent::hideHighlight): (WebCore::InspectorAgent::mouseDidMoveOverElement): (WebCore::InspectorAgent::handleMousePress): (WebCore::InspectorAgent::setInspectorFrontendClient): (WebCore::InspectorAgent::didClearWindowObjectInWorld): (WebCore::InspectorAgent::setSearchingForNode): (WebCore::InspectorAgent::connectFrontend): (WebCore::InspectorAgent::show): (WebCore::InspectorAgent::showPanel): (WebCore::InspectorAgent::close): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::resourceAgent): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::pushDataCollectedOffline): (WebCore::InspectorAgent::restoreDebugger): (WebCore::InspectorAgent::restoreProfiler): (WebCore::InspectorAgent::unbindAllResources): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::mainResourceFiredDOMContentEvent): (WebCore::InspectorAgent::mainResourceFiredLoadEvent): (WebCore::InspectorAgent::isMainResourceLoader): (WebCore::InspectorAgent::willSendRequest): (WebCore::InspectorAgent::ensureSettingsLoaded): (WebCore::InspectorAgent::startTimelineProfiler): (WebCore::InspectorAgent::stopTimelineProfiler): (WebCore::PostWorkerNotificationToFrontendTask::create): (WebCore::PostWorkerNotificationToFrontendTask::PostWorkerNotificationToFrontendTask): (WebCore::PostWorkerNotificationToFrontendTask::performTask): (WebCore::InspectorAgent::postWorkerNotificationToFrontend): (WebCore::InspectorAgent::didCreateWorker): (WebCore::InspectorAgent::didDestroyWorker): (WebCore::InspectorAgent::didOpenDatabase): (WebCore::InspectorAgent::getCookies): (WebCore::InspectorAgent::buildArrayForCookies): (WebCore::InspectorAgent::buildObjectForCookie): (WebCore::InspectorAgent::deleteCookie): (WebCore::InspectorAgent::didUseDOMStorage): (WebCore::InspectorAgent::didCreateWebSocket): (WebCore::InspectorAgent::willSendWebSocketHandshakeRequest): (WebCore::InspectorAgent::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorAgent::didCloseWebSocket): (WebCore::InspectorAgent::isRecordingUserInitiatedProfile): (WebCore::InspectorAgent::startUserInitiatedProfiling): (WebCore::InspectorAgent::stopUserInitiatedProfiling): (WebCore::InspectorAgent::profilerEnabled): (WebCore::InspectorAgent::enableProfiler): (WebCore::InspectorAgent::disableProfiler): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::enableDebugger): (WebCore::InspectorAgent::disableDebugger): (WebCore::InspectorAgent::resume): (WebCore::InspectorAgent::setAllBrowserBreakpoints): (WebCore::InspectorAgent::evaluateForTestInFrontend): (WebCore::InspectorAgent::didEvaluateForTestInFrontend): (WebCore::quadToPath): (WebCore::drawOutlinedQuad): (WebCore::drawOutlinedQuadWithClip): (WebCore::drawHighlightForBox): (WebCore::drawHighlightForLineBoxesOrSVGRenderer): (WebCore::convertFromFrameToMainFrame): (WebCore::frameToMainFrameOffset): (WebCore::InspectorAgent::drawNodeHighlight): (WebCore::InspectorAgent::drawElementTitle): (WebCore::InspectorAgent::openInInspectedWindow): (WebCore::InspectorAgent::addScriptToEvaluateOnLoad): (WebCore::InspectorAgent::removeAllScriptsToEvaluateOnLoad): (WebCore::InspectorAgent::setInspectorExtensionAPI): (WebCore::InspectorAgent::inspectedURL): (WebCore::InspectorAgent::reloadPage): (WebCore::InspectorAgent::setExtraHeaders):
  • inspector/InspectorAgent.h: Copied from Source/WebCore/inspector/InspectorController.h. (WebCore::InspectorAgent::inspectorBackendDispatcher): (WebCore::InspectorAgent::inspectorClient): (WebCore::InspectorAgent::injectedScriptHost): (WebCore::InspectorAgent::inspectedPage): (WebCore::InspectorAgent::hideDOMNodeHighlight): (WebCore::InspectorAgent::hideFrameHighlight): (WebCore::InspectorAgent::frontend): (WebCore::InspectorAgent::inspectorController): (WebCore::InspectorAgent::inspectorAgent): (WebCore::InspectorAgent::consoleAgent): (WebCore::InspectorAgent::cssAgent): (WebCore::InspectorAgent::domAgent): (WebCore::InspectorAgent::injectedScriptAgent): (WebCore::InspectorAgent::runtimeAgent): (WebCore::InspectorAgent::timelineAgent): (WebCore::InspectorAgent::databaseAgent): (WebCore::InspectorAgent::domStorageAgent): (WebCore::InspectorAgent::fileSystemAgent): (WebCore::InspectorAgent::browserDebuggerAgent): (WebCore::InspectorAgent::debuggerAgent): (WebCore::InspectorAgent::profilerAgent): (WebCore::InspectorAgent::applicationCacheAgent): (WebCore::InspectorAgent::hasInspectorFrontendClient): (WebCore::InspectorAgent::hasFrontend): (WebCore::InspectorAgent::startProfiling): (WebCore::InspectorAgent::stopProfiling): (WebCore::InspectorAgent::debuggerEnabled): (WebCore::InspectorAgent::state): (WebCore::InspectorAgent::settings):
  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent): (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
  • inspector/InspectorBrowserDebuggerAgent.h: (WebCore::InspectorBrowserDebuggerAgent::create):
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::clearConsoleMessages): (WebCore::InspectorConsoleAgent::addMessageToConsole): (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorConsoleAgent::didReceiveResponse): (WebCore::InspectorConsoleAgent::didFailLoading): (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled): (WebCore::InspectorConsoleAgent::addConsoleMessage):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController):
  • inspector/InspectorController.h:
  • inspector/InspectorDatabaseAgent.cpp:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::create): (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame): (WebCore::InspectorDebuggerAgent::currentCallFrames):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorFileSystemAgent.cpp: (WebCore::InspectorFileSystemAgentCallbacks::didOpenFileSystem): (WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent): (WebCore::InspectorFileSystemAgent::stop): (WebCore::InspectorFileSystemAgent::getFileSystemPathAsync): (WebCore::InspectorFileSystemAgent::didGetFileSystemPath): (WebCore::InspectorFileSystemAgent::didGetFileSystemError):
  • inspector/InspectorFileSystemAgent.h: (WebCore::InspectorFileSystemAgent::create):
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::setExtensionAPI):
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::create): (WebCore::InspectorProfilerAgent::InspectorProfilerAgent): (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole): (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole): (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling): (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
  • inspector/InspectorProfilerAgent.h:

2011-01-22 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: next step in splitting InspectorController.

#include "InspectorController.h" was added.

​https://bugs.webkit.org/show_bug.cgi?id=52955

  • WebCoreSupport/InspectorServerQt.cpp:

Jan 22, 2011:

9:48 PM Changeset in webkit [76458] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-22 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.

Skip a test that seems to cause the subsequent test to sporadically fail, and unskip the several tests after it
​https://bugs.webkit.org/show_bug.cgi?id=52970

  • platform/mac-wk2/Skipped:
9:03 PM Changeset in webkit [76457] by ggaren@apple.com
  • 5 edits
    1 add in trunk

2011-01-22 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Dan Bernstein.

ASSERT running run-webkit-tests --threaded.
​https://bugs.webkit.org/show_bug.cgi?id=52971


SunSpider and v8 report no change.

  • runtime/ConservativeSet.cpp: (JSC::ConservativeSet::grow): (JSC::ConservativeSet::add):
  • runtime/ConservativeSet.h: Tweaked the inline capacity to 128, and the growth policy to 2X, to make SunSpider and v8 happy. (JSC::ConservativeSet::ConservativeSet): (JSC::ConservativeSet::~ConservativeSet): (JSC::ConservativeSet::mark): Use OSAllocator directly, instead of malloc. Malloc is forbidden during a multi-threaded mark phase because it can cause deadlock.

2011-01-22 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Dan Bernstein.

Beefed up --threaded mode to catch even more kinds of errors.
​https://bugs.webkit.org/show_bug.cgi?id=52971

  • DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared context group to force JSC to mark multiple threads. (This used to be the default, but it changed in SnowLeopard.) (runJavaScriptThread): Do more locking and unlocking, and more allocation, to give threading mistakes more chances to show themselves. (startJavaScriptThreads): (stopJavaScriptThreads):
4:33 PM Changeset in webkit [76456] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-22 Chris Rogers <​crogers@google.com>

Rubber-stamped by Anders Carlsson.

Fix FFTFrameStub to compile properly
​https://bugs.webkit.org/show_bug.cgi?id=52969

No new tests since this is a build fix.

  • platform/audio/FFTFrameStub.cpp: (WebCore::FFTFrame::FFTFrame):
1:55 PM Changeset in webkit [76455] by jam@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-01-22 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Adam Barth.

[chromium]: Fix WebScrollbarImpl not getting scroll events after recent scrollbar refactoring
​https://bugs.webkit.org/show_bug.cgi?id=52967

  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::horizontalScrollbar): (WebKit::WebScrollbarImpl::verticalScrollbar):
  • src/WebScrollbarImpl.h:
12:11 PM Changeset in webkit [76454] by ggaren@apple.com
  • 12 edits
    2 adds in trunk/Source/JavaScriptCore

2011-01-22 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Geoffrey Garen.

Rubber-stamped by Maciej Stachowiak.

A few of Maciej's review suggestions for my last patch.
​https://bugs.webkit.org/show_bug.cgi?id=52946

SunSpider reports no change.

  • runtime/ConservativeSet.cpp: Added. (JSC::isPointerAligned): (JSC::ConservativeSet::add):
  • runtime/ConservativeSet.h: Added. (JSC::ConservativeSet::ConservativeSet): (JSC::ConservativeSet::mark): Split ConservativeSet out into its own file, and moved the conservative check into ConservativeSet::add, making ConservativeSet's responsibility clearer.
  • runtime/Heap.cpp: (JSC::Heap::markRoots):
  • runtime/MachineStackMarker.cpp: (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal): (JSC::MachineStackMarker::markOtherThreadConservatively):
  • runtime/MachineStackMarker.h:
  • runtime/MarkStack.h: Updated for changes above.
11:56 AM Changeset in webkit [76453] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-01-22 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Transparent windows with compositing WebKit2 content show garbage
​https://bugs.webkit.org/show_bug.cgi?id=52966
<rdar://problem/8765051>

  • UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm: (WebKit::LayerBackedDrawingAreaProxy::paint): If the WKView should draw transparent background, do so.
11:36 AM Changeset in webkit [76452] by andersca@apple.com
  • 13 edits in trunk/Source/WebKit2

2011-01-22 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add an asynchronous WKPageForceRepaint
​https://bugs.webkit.org/show_bug.cgi?id=52964
<rdar://problem/8898527>

  • UIProcess/API/C/WKPage.cpp: (WKPageForceRepaint): Call WebPageProxy::forceRepaint.
  • UIProcess/API/C/WKPage.h: Add WKPageForceRepaint.
  • UIProcess/GenericCallback.h: Add a "generic" VoidCallback class.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::forceRepaint): Insert the callback in the m_voidCallbacks map and send a forceRepaint message.

(WebKit::WebPageProxy::voidCallback):
Call the right void callback.

(WebKit::WebPageProxy::processDidCrash):
Invalidate m_voidCallbacks.

  • UIProcess/WebPageProxy.messages.in: Add a VoidCallback message.
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::forceRepaint): Force a repaint.
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h: Add forceRepaint.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::forceRepaint): Call forceRepaint on the drawing area.
  • WebProcess/WebPage/WebPage.messages.in: Add a ForceRepaint message.
9:27 AM Changeset in webkit [76451] by robert@webkit.org
  • 10 edits in trunk

2011-01-22 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Support layoutTestController.addURLToRedirect()
​https://bugs.webkit.org/show_bug.cgi?id=52956

  • platform/qt/Skipped:

2011-01-22 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Support layoutTestController.addURLToRedirect()
​https://bugs.webkit.org/show_bug.cgi?id=52956

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::addURLToRedirect):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
  • WebCoreSupport/FrameLoaderClientQt.h:

2011-01-22 Robert Hogan <​robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Support layoutTestController.addURLToRedirect()
​https://bugs.webkit.org/show_bug.cgi?id=52956

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::addURLToRedirect):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
8:16 AM Changeset in webkit [76450] by Nikolas Zimmermann
  • 24 edits in trunk/LayoutTests

2011-01-22 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

REGRESSION: Vertical line metrics incorrect
​https://bugs.webkit.org/show_bug.cgi?id=52960

Revert accidently landed mac baseline changes.

  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/mac/svg/batik/text/xmlSpace-expected.txt:
  • platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
  • platform/mac/svg/text/text-hkern-expected.txt:
  • platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/mac/svg/text/text-text-04-t-expected.txt:
  • platform/mac/svg/text/text-vkern-expected.txt:
  • platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt:
  • platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
7:14 AM Changeset in webkit [76449] by Nikolas Zimmermann
  • 38 edits in trunk/LayoutTests/platform

2011-01-22 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

REGRESSION: Vertical line metrics incorrect
​https://bugs.webkit.org/show_bug.cgi?id=52960

Rebaselined several text dumps from the bots, after the FontMetrics change.
All show 1px diffs, but are progressions, since the lineSpacing calculation has been improved.
Mac still has the old results - as it depends on a rounding trick at the moment.

  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/gtk/svg/text/text-hkern-expected.txt:
  • platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/gtk/svg/text/text-vkern-expected.txt:
  • platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/mac/svg/batik/text/xmlSpace-expected.txt:
  • platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
  • platform/mac/svg/text/text-hkern-expected.txt:
  • platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/mac/svg/text/text-text-04-t-expected.txt:
  • platform/mac/svg/text/text-vkern-expected.txt:
  • platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt:
  • platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/qt/css2.1/t1507-c526-font-sz-02-b-a-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/qt/svg/text/text-hkern-expected.txt:
  • platform/qt/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/qt/svg/text/text-vkern-expected.txt:
  • platform/qt/svg/text/text-vkern-on-horizontal-text-expected.txt:
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
7:00 AM Changeset in webkit [76448] by andreip@google.com
  • 7 edits
    2 adds in trunk

2011-01-22 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

IndexedDB corrupts data on disk
​https://bugs.webkit.org/show_bug.cgi?id=52890

  • storage/indexeddb/data-corruption-expected.txt: Added.
  • storage/indexeddb/data-corruption.html: Added.

2011-01-22 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

IndexedDB corrupts data on disk
​https://bugs.webkit.org/show_bug.cgi?id=52890

We need to store the SerializedScriptValues on disk in a BLOB column rather than TEXT.
Test: storage/indexeddb/data-corruption.html

  • platform/sql/SQLiteStatement.cpp: (WebCore::SQLiteStatement::bindBlob): (WebCore::SQLiteStatement::getColumnBlobAsString): (WebCore::SQLiteStatement::getColumnBlobAsVector):
  • platform/sql/SQLiteStatement.h:
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::loadCurrentRow):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::runCommands): (WebCore::createTables): (WebCore::createMetaDataTable): (WebCore::migrateDatabase):
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::getInternal): (WebCore::putObjectStoreData):
6:18 AM Changeset in webkit [76447] by Nikolas Zimmermann
  • 3 edits in trunk/Source/WebCore

2011-01-22 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Fix WinCE build.

  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::drawText):
  • rendering/RenderThemeWinCE.cpp: (WebCore::RenderThemeWinCE::adjustMenuListButtonStyle):
6:13 AM Changeset in webkit [76446] by robert@webkit.org
  • 4 edits
    4 adds in trunk

2011-01-22 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
​https://bugs.webkit.org/show_bug.cgi?id=49802

  • platform/qt/Skipped:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Added.
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Added.
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Added.

2011-01-22 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
​https://bugs.webkit.org/show_bug.cgi?id=49802

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::open):
5:46 AM Changeset in webkit [76445] by Nikolas Zimmermann
  • 15 edits in trunk/Source/WebCore

2011-01-22 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

REGRESSION: Vertical line metrics incorrect
​https://bugs.webkit.org/show_bug.cgi?id=52960

SimpleFontDataMac.mm contains a hack to modifiy lineGap/descent for the 'Hiragino' font.
That didn't influence the lineSpacing so far, but does now, causing regressions.

Restore old line spacing behaviour to fix the regression.
Covered by existing fast/blockflow, fast/repaint and fast/text/international test cases.

  • platform/graphics/FontMetrics.h: (WebCore::FontMetrics::FontMetrics): (WebCore::FontMetrics::floatLineSpacing): (WebCore::FontMetrics::setLineSpacing): (WebCore::FontMetrics::lineSpacing): (WebCore::FontMetrics::reset):
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData):
  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/freetype/SimpleFontDataFreeType.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/haiku/SimpleFontDataHaiku.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/pango/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::initGDIFont):
  • platform/graphics/wince/SimpleFontDataWinCE.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/wx/SimpleFontDataWx.cpp: (WebCore::SimpleFontData::platformInit):
4:52 AM Changeset in webkit [76444] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-22 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fast/backgrounds/svg-as-mask.html fails
​https://bugs.webkit.org/show_bug.cgi?id=52906

Transparency layers should start out with in SourceOver mode with
alpha 1.0 (modeled after CGContextBeginTransparencyLayer.)

  • platform/graphics/qt/TransparencyLayer.h: (WebCore::TransparencyLayer::TransparencyLayer):
4:44 AM Changeset in webkit [76443] by Nikolas Zimmermann
  • 2 edits in trunk/Source/WebCore

2011-01-22 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

Introduce FontMetrics abstraction
​https://bugs.webkit.org/show_bug.cgi?id=51456

Fix Chromium/Win build.

  • platform/graphics/chromium/UniscribeHelperTextRun.cpp: s/->/./ (WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun):
3:46 AM Changeset in webkit [76442] by Nikolas Zimmermann
  • 68 edits
    1 add in trunk/Source

2011-01-21 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Introduce FontMetrics abstraction
​https://bugs.webkit.org/show_bug.cgi?id=51456

  • src/ExternalPopupMenu.cpp: Use FontMetrics instead of Font to access the metrics. (WebKit::ExternalPopupMenu::getPopupMenuInfo):
  • src/WebFontImpl.cpp: Ditto. (WebKit::WebFontImpl::ascent): (WebKit::WebFontImpl::descent): (WebKit::WebFontImpl::height): (WebKit::WebFontImpl::lineSpacing): (WebKit::WebFontImpl::xHeight):

2011-01-21 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Introduce FontMetrics abstraction
​https://bugs.webkit.org/show_bug.cgi?id=51456

  • FullscreenVideoController.cpp: Use FontMetrics instead of Font to access the metrics. (FullscreenVideoController::draw):
  • WebCoreSupport/WebDragClient.cpp: Ditto. (WebDragClient::createDragImageForLink):
  • WebKitGraphics.cpp: Ditto. (FontMetrics):

2011-01-21 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Introduce FontMetrics abstraction
​https://bugs.webkit.org/show_bug.cgi?id=51456

Encapsulate ascent/descent/lineHeight/lineGap methods in a single FontMetrics class, instead of
having to define them in both Font & SimpleFontData. Changed to store floating point values
as default, in order to get accurate information for small sized fonts. All these methods
now have floating-point and integer versions. Whenever an integer variant of these functions
is called, lroundf() is used to round the value.

This makes it possible to support small font-sizes for SVG in a follow-up patch, as well
as fixing rounding issues when using SVG Fonts.


Shouldn't affect existing tests.

  • GNUmakefile.am: Add FontMetrics.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: Use style->fontMetrics() instead of style->font() to access the metrics. (baselinePositionForAccessibilityRenderObject):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::computeLengthDouble):
  • html/canvas/CanvasRenderingContext2D.cpp: Ditto. (WebCore::CanvasRenderingContext2D::drawTextInternal):
  • inspector/InspectorController.cpp: Ditto. (WebCore::InspectorController::drawElementTitle):
  • platform/chromium/PopupMenuChromium.cpp: Ditto. (WebCore::PopupListBox::paintRow): (WebCore::PopupListBox::getRowHeight):
  • platform/graphics/Font.h: Remove ascent/descent/height/lineGap/lineSpacing/xHeight/unitsPerEm accessor... (WebCore::Font::fontMetrics): ... and only expose a single FontMetrics object here.
  • platform/graphics/FontFastPath.cpp: Use fontMetrics() to query metrics information. (WebCore::Font::emphasisMarkAscent): (WebCore::Font::emphasisMarkDescent): (WebCore::Font::emphasisMarkHeight): (WebCore::Font::floatWidthForSimpleText):
  • platform/graphics/FontMetrics.h: Added. (WebCore::FontMetrics::FontMetrics): Creates a FontMetrics object, stored in SimpleFontData. (WebCore::FontMetrics::unitsPerEm): Returns an unsigned describing the unitsPerEm. (WebCore::FontMetrics::setUnitsPerEm): Sets the unitsPerEm value. (WebCore::FontMetrics::floatAscent): Returns the stored m_ascent float. (WebCore::FontMetrics::setAscent): Sets the stored m_ascent float. (WebCore::FontMetrics::floatDescent): Returns the stored m_descent float. (WebCore::FontMetrics::setDescent): Sets the stored m_descent float. (WebCore::FontMetrics::floatHeight): Returns floatAscent() + floatDescent(). (WebCore::FontMetrics::floatLineGap): Returns the stored m_lineGap float. (WebCore::FontMetrics::setLineGap): Sets the stored m_lineGap float. (WebCore::FontMetrics::floatLineSpacing): Returns the stored m_lineSpacing float. (WebCore::FontMetrics::setLineSpacing): Sets the stored m_lineSpacing float. (WebCore::FontMetrics::xHeight): Returns the stored m_xHeight float (no integer version available, hence no 'float' prefix). (WebCore::FontMetrics::setXHeight): Sets the stored m_xHeight float. (WebCore::FontMetrics::ascent): Returns a rounded version of ascent(). (WebCore::FontMetrics::descent): Ditto (for descent). (WebCore::FontMetrics::height): Returns ascent() + descent(). (WebCore::FontMetrics::lineGap): Returns a rounded version of lineGap(). (WebCore::FontMetrics::lineSpacing): Ditto (for lineSpacing). (WebCore::FontMetrics::reset): Nulls all members, used only by the platform variants of SimpleFontData.
  • platform/graphics/SimpleFontData.cpp: Adapt SVG Fonts code, to initialize the FontMetrics object, as the m_ascent/etc.. members are gone. (WebCore::SimpleFontData::SimpleFontData): (WebCore::SimpleFontData::initCharWidths):
  • platform/graphics/SimpleFontData.h: Remove ascent/descent/height/lineSpacing/lineGap/xHeight/unitsPerEm accessors, and members, just store a FontMetrics object and expose it. (WebCore::SimpleFontData::fontMetrics): (WebCore::SimpleFontData::avgCharWidth):
  • platform/graphics/chromium/FontChromiumWin.cpp: Use fontMetrics() to query font metrics. (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::estimateTextBounds): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::estimateTextBounds): (WebCore::Font::drawComplexText):
  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Adapt platform code, to initialize the FontMetrics object. (WebCore::SimpleFontData::platformInit):
  • platform/graphics/chromium/SimpleFontDataLinux.cpp: Ditto. (WebCore::SimpleFontData::platformInit):
  • platform/graphics/chromium/UniscribeHelperTextRun.cpp: Use fontMetrics() to query font metrics. (WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun): (WebCore::UniscribeHelperTextRun::nextWinFontData):
  • platform/graphics/freetype/SimpleFontDataFreeType.cpp: Adapt platform code, to initialize the FontMetrics object. (WebCore::SimpleFontData::platformInit):
  • platform/graphics/haiku/SimpleFontDataHaiku.cpp: Ditto. (WebCore::SimpleFontData::platformInit):
  • platform/graphics/mac/FontComplexTextMac.cpp: Use fontMetrics() to query font metrics. (WebCore::Font::floatWidthForComplexText):
  • platform/graphics/mac/FontMac.mm: Ditto. (WebCore::showGlyphsWithAdvances):
  • platform/graphics/mac/SimpleFontDataMac.mm: Adapt platform code, to initialize the FontMetrics object. (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformCharWidthInit):
  • platform/graphics/pango/SimpleFontDataPango.cpp: Ditto. (WebCore::SimpleFontData::platformInit):
  • platform/graphics/qt/SimpleFontDataQt.cpp: Ditto. (+ Switch to QFontMetricsF to get floating-point accurancy.) (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/FontCGWin.cpp: Use fontMetrics() to query font metrics. (WebCore::drawGDIGlyphs):
  • platform/graphics/win/FontWin.cpp: Ditto. (WebCore::Font::floatWidthForComplexText):
  • platform/graphics/win/SimpleFontDataCGWin.cpp: Adapt platform code, to initialize the FontMetrics object. (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformBoundsForGlyph):
  • platform/graphics/win/SimpleFontDataCairoWin.cpp: Ditto. (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/SimpleFontDataWin.cpp: Ditto. (WebCore::SimpleFontData::initGDIFont):
  • platform/graphics/wince/GraphicsContextWinCE.cpp: Use fontMetrics() to query font metrics. (WebCore::GraphicsContext::drawText):
  • platform/graphics/wince/SimpleFontDataWinCE.cpp: Adapt platform code, to initialize the FontMetrics object. (WebCore::SimpleFontData::platformInit):
  • platform/graphics/wx/SimpleFontDataWx.cpp: Ditto. (WebCore::SimpleFontData::platformInit):
  • platform/win/PopupMenuWin.cpp: Use style->fontMetrics() instead of style->font() to access the metrics. (WebCore::PopupMenuWin::calculatePositionAndSize): (WebCore::PopupMenuWin::paint):
  • rendering/EllipsisBox.cpp: Ditto. (WebCore::EllipsisBox::paint): (WebCore::EllipsisBox::nodeAtPoint):
  • rendering/InlineBox.cpp: Ditto. (WebCore::InlineBox::logicalHeight):
  • rendering/InlineFlowBox.cpp: Ditto. (WebCore::verticalPositionForBox): (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesInBlockDirection):
  • rendering/InlineTextBox.cpp: Ditto. (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintCompositionUnderline):
  • rendering/RenderBlock.cpp: Ditto. (WebCore::RenderBlock::baselinePosition): (WebCore::RenderBlock::firstLineBoxBaseline): (WebCore::RenderBlock::lastLineBoxBaseline):
  • rendering/RenderBox.cpp: Ditto. (WebCore::RenderBox::localCaretRect):
  • rendering/RenderEmbeddedObject.cpp: Ditto. (WebCore::RenderEmbeddedObject::paintReplaced):
  • rendering/RenderImage.cpp: Ditto. (WebCore::RenderImage::setImageSizeForAltText): (WebCore::RenderImage::paintReplaced):
  • rendering/RenderInline.cpp: Ditto. (WebCore::RenderInline::baselinePosition):
  • rendering/RenderListBox.cpp: Ditto. (WebCore::RenderListBox::paintItemForeground): (WebCore::RenderListBox::itemHeight):
  • rendering/RenderListMarker.cpp: Ditto. (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::layout): (WebCore::RenderListMarker::computePreferredLogicalWidths): (WebCore::RenderListMarker::updateMargins): (WebCore::RenderListMarker::getRelativeMarkerRect):
  • rendering/RenderTextControl.cpp: Ditto. (WebCore::RenderTextControl::paintPlaceholder):
  • rendering/RenderTextControlSingleLine.cpp: Ditto. (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
  • rendering/RenderThemeWin.cpp: Ditto. (WebCore::RenderThemeWin::adjustMenuListButtonStyle):
  • rendering/mathml/RenderMathMLFraction.cpp: Ditto. (WebCore::RenderMathMLFraction::baselinePosition):
  • rendering/style/RenderStyle.h: Add "const FontMetrics& fontMetrics() const" accessor. (WebCore::InheritedFlags::fontMetrics): (WebCore::InheritedFlags::computedLineHeight):
  • rendering/svg/RenderSVGInlineText.cpp: Use style->fontMetrics() instead of style->font() to access the metrics. (WebCore::RenderSVGInlineText::positionForPoint):
  • rendering/svg/SVGInlineTextBox.cpp: Ditto. (WebCore::SVGInlineTextBox::selectionRectForTextFragment): (WebCore::positionOffsetForDecoration): (WebCore::SVGInlineTextBox::paintDecorationWithStyle): (WebCore::SVGInlineTextBox::paintTextWithShadows): (WebCore::SVGInlineTextBox::calculateBoundaries):
  • rendering/svg/SVGTextLayoutEngineBaseline.cpp: Ditto. (WebCore::SVGTextLayoutEngineBaseline::calculateBaselineShift): (WebCore::SVGTextLayoutEngineBaseline::calculateAlignmentBaselineShift): (WebCore::SVGTextLayoutEngineBaseline::calculateGlyphAdvanceAndOrientation):
  • rendering/svg/SVGTextLayoutEngineSpacing.cpp: Ditto. (WebCore::SVGTextLayoutEngineSpacing::calculateSVGKerning):
  • rendering/svg/SVGTextMetrics.cpp: Ditto. (WebCore::SVGTextMetrics::SVGTextMetrics):
  • rendering/svg/SVGTextQuery.cpp: Ditto. (WebCore::calculateGlyphBoundaries):
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::unitsPerEm): Rename defaultUnitsPerEm global to gDefaultUnitsPerEm.
  • svg/SVGLength.cpp: Use style->fontMetrics() instead of style->font() to access the metrics. (WebCore::SVGLength::convertValueFromUserUnitsToEXS): (WebCore::SVGLength::convertValueFromEXSToUserUnits):

2011-01-21 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Introduce FontMetrics abstraction
​https://bugs.webkit.org/show_bug.cgi?id=51456

  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp: Use FontMetrics instead of Font to access the metrics. (WebKit::WebPopupMenu::setUpPlatformData):
3:36 AM Changeset in webkit [76441] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-22 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r76430.

  • runtime/MachineStackMarker.cpp: (JSC::swapIfBackwards):
3:02 AM Changeset in webkit [76440] by andreas.kling@nokia.com
  • 1 edit
    1 add in trunk/LayoutTests

2011-01-22 Andreas Kling <​kling@webkit.org>

Unreviewed, add Qt-specific result for test added in r76414.

  • platform/qt/fast/text/justify-nbsp-expected.txt: Added.
2:58 AM Changeset in webkit [76439] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-22 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
2:51 AM Changeset in webkit [76438] by rniwa@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-01-22 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Eric Seidel.

Stop instantiating legacy editing positions in VisibleSelection, visible_units.cpp, Frame, and RenderBlock
​https://bugs.webkit.org/show_bug.cgi?id=52759

Stopped instantiating legacy editing positions in the following files.

  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
  • editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfBlock):
  • page/Frame.cpp: (WebCore::Frame::visiblePositionForPoint):
  • rendering/RenderBlock.cpp: Removed RenderBlock::positionForRenderer because it was not called anywhere.
  • rendering/RenderBlock.h: Ditto.
2:00 AM Changeset in webkit [76437] by enne@google.com
  • 3 edits in trunk/Source/WebCore

2011-01-22 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Fix compositor repaints for offscreen fixed elements
​https://bugs.webkit.org/show_bug.cgi?id=52681

The fast path scrolling was clipping offscreen invalidations.
Additionally, the compositor was ignoring all invalidations that were
entirely out of the content rect.

Test: compositing/ to verify this caused no regressions.
Tested fix manually in browser as I could not generate a LayoutTest that reproduced the bug in run-webkit-tests.

  • page/FrameView.cpp: (WebCore::FrameView::scrollContentsFastPath):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::invalidateRootLayerRect):
1:29 AM Changeset in webkit [76436] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-22 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
1:23 AM Changeset in webkit [76435] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=52473
Auto-scaling to avoid orphans is broken, remove dysfunctional code

  • WebView/WebHTMLView.mm: (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]): (-[WebHTMLView _scaleFactorForPrintOperation:]): (-[WebHTMLView knowsPageRange:]):
1:15 AM Changeset in webkit [76434] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-22 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=52950
Leak in WebPage::drawRectToPDF

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRectToPDF): Use RetainPtr here, too.
12:22 AM Changeset in webkit [76433] by ap@apple.com
  • 4 edits in trunk/Source

2011-01-22 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=52951
WebKit2 generates a bad PDF for cross process messaging

  • page/PrintContext.cpp: (WebCore::PrintContext::spoolRect): Use a correct offset to actually draw inside the requested rectangle.

2011-01-22 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=52951
WebKit2 generates a bad PDF for cross process messaging

  • UIProcess/API/mac/WKView.mm: (-[WKView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Use a correct offset when flipping.
Note: See TracTimeline for information about the timeline view.