Context Navigation

(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar): Remove some extraneous characters.
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar): Ditto.

11:07 PM Changeset in webkit [77909] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

2011-02-07 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

[Chromium] Remove non-Flaky media layout tests and update bugs that
are associated with media layout tests
https://bugs.webkit.org/show_bug.cgi?id=53948

platform/chromium/test_expectations.txt:

11:07 PM Changeset in webkit [77908] by mjs@apple.com

16 edits
2 adds in trunk

2011-02-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Add resource load client for injected bundle and move willSendRequest there
https://bugs.webkit.org/show_bug.cgi?id=53972

GNUmakefile.am:
WebKit2.pro:
WebKit2.xcodeproj/project.pbxproj:
WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageSetPageLoaderClient): (WKBundlePageSetResourceLoadClient):
WebProcess/InjectedBundle/API/c/WKBundlePage.h:
WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp: Added. (WebKit::InjectedBundlePageResourceLoadClient::didInitiateLoadForResource): (WebKit::InjectedBundlePageResourceLoadClient::willSendRequestForFrame): (WebKit::InjectedBundlePageResourceLoadClient::didReceiveResponseForResource): (WebKit::InjectedBundlePageResourceLoadClient::didReceiveContentLengthForResource): (WebKit::InjectedBundlePageResourceLoadClient::didFinishLoadForResource): (WebKit::InjectedBundlePageResourceLoadClient::didFailLoadForResource):
WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h: Added.
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebKit::WebFrameLoaderClient::dispatchWillSendRequest): (WebKit::WebFrameLoaderClient::dispatchDidReceiveResponse): (WebKit::WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebKit::WebFrameLoaderClient::dispatchDidFinishLoading): (WebKit::WebFrameLoaderClient::dispatchDidFailLoading):
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::initializeInjectedBundleResourceLoadClient):
WebProcess/WebPage/WebPage.h: (WebKit::WebPage::injectedBundleResourceLoadClient):
win/WebKit2.vcproj:

2011-02-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Add resource load client for injected bundle and move willSendRequest there
https://bugs.webkit.org/show_bug.cgi?id=53972

MiniBrowser/mac/WebBundle/WebBundleMain.m: (didCreatePage):
WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::didInitiateLoadForResource): (WTR::InjectedBundlePage::didReceiveResponseForResource): (WTR::InjectedBundlePage::didReceiveContentLengthForResource): (WTR::InjectedBundlePage::didFinishLoadForResource): (WTR::InjectedBundlePage::didFailLoadForResource): (WTR::InjectedBundlePage::willSendRequestForFrame):
WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

11:07 PM Changeset in webkit [77907] by commit-queue@webkit.org

2 edits
1 add in trunk/Source/WebCore

2011-02-07 Xiyuan Xia <xiyuan@chromium.org>

Reviewed by Tony Chang.

[Chromium] Select popup box does not align with select button when appearance is not "menulist".
https://bugs.webkit.org/show_bug.cgi?id=53942

Added manual test select_webkit_appearance_off_popup_alignment.html.

manual-tests/select_webkit_appearance_off_popup_alignment.html: Added.
platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::layout):

10:59 PM Changeset in webkit [77906] by commit-queue@webkit.org

4 edits in trunk/Source

2011-02-07 Aparna Nandyal <aparna.nand@wipro.com>

Reviewed by Andreas Kling.

[Qt] - Context menu needs "Copy" as well when the selected text is a link.
https://bugs.webkit.org/show_bug.cgi?id=40983

Added copy option for Qt platform if selection is a link.
Added a test in tst_qwebpage.cpp.

page/ContextMenuController.cpp: (WebCore::ContextMenuController::populate):

2011-02-07 Aparna Nandyal <aparna.nand@wipro.com>

Reviewed by Andreas Kling.

[Qt] - Context menu needs "Copy" as well when the selected text is a link.
https://bugs.webkit.org/show_bug.cgi?id=40983

Added a test case to create a context sensitive menu.
A check is made if it has Copy menu item when user
selects a link and opens context menu.

tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::contextMenuCopy):

10:48 PM Changeset in webkit [77905] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

2011-02-07 Mike Reed <reed@google.com>

Reviewed by Kenneth Russell.

Add compile-time flag ENABLE(SKIA_GPU) to use Skia's gpu backend
when drawing <canvas>. Disabled by default.

No new tests. existing canvas layouttests apply

platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::publishToPlatformLayer):
platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::GetGlobalGrContext): (WebCore::PlatformContextSkia::isPrinting): (WebCore::PlatformContextSkia::setSharedGraphicsContext3D): (WebCore::PlatformContextSkia::syncSoftwareCanvas):

10:45 PM Changeset in webkit [77904] by jcivelli@chromium.org

3 edits in trunk/Source/WebCore

2011-02-07 Jay Civelli <jcivelli@chromium.org>

Reviewed by Darin Fisher.

Removing unused code from PopupMenuChromium.
https://bugs.webkit.org/show_bug.cgi?id=53866

platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::layout): (WebCore::PopupMenuChromium::show):
- platform/chromium/PopupMenuChromium.h:

10:39 PM Changeset in webkit [77903] by ojan@chromium.org

2 edits in trunk/Websites/bugs.webkit.org

2011-02-07 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

bring back diff context lines into the review tool
https://bugs.webkit.org/show_bug.cgi?id=53974

code-review.js:

10:30 PM Changeset in webkit [77902] by commit-queue@webkit.org

3 edits
2 adds in trunk

2011-02-07 Kenichi Ishibashi <bashi@google.com>

Reviewed by Andreas Kling.

HTMLOutputElement::childrenChanged() should call its base class childrenChanged()
https://bugs.webkit.org/show_bug.cgi?id=53791

Test that a live list is updated after the child of an HTMLOutputElement was removed.

fast/dom/HTMLOutputElement/htmloutputelement-children-removed-expected.txt: Added.
fast/dom/HTMLOutputElement/htmloutputelement-children-removed.html: Added.

2011-02-07 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Andreas Kling.

HTMLOutputElement::childrenChanged() should call its base class childrenChanged()
https://bugs.webkit.org/show_bug.cgi?id=53791

Calls HTMLFormControlElement::childrenChanged() in HTMLOutputElement::childrenChanged().

Test: fast/dom/HTMLOutputElement/htmloutputelement-children-removed.html

html/HTMLOutputElement.cpp: (WebCore::HTMLOutputElement::childrenChanged): Calls super class's childrenChanged().

10:27 PM Changeset in webkit [77901] by commit-queue@webkit.org

6 edits in trunk/Source

2011-02-07 Benjamin Poulain <ikipou@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] cookiesEnabled could create the cookieJar on the wrong thread.
https://bugs.webkit.org/show_bug.cgi?id=52289

Use the QtNAMThreadSafeProxy to make sure the cookie jar is created
in the same thread as the QNetworkAccessManager.

platform/network/qt/QtNAMThreadSafeProxy.cpp: (WebCore::QtNAMThreadSafeProxy::QtNAMThreadSafeProxy): (WebCore::QtNAMThreadSafeProxy::hasCookieJar):
platform/network/qt/QtNAMThreadSafeProxy.h:
platform/qt/CookieJarQt.cpp: (WebCore::cookiesEnabled):

2011-02-07 Benjamin Poulain <ikipou@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] cookiesEnabled could create the cookieJar on the wrong thread.
https://bugs.webkit.org/show_bug.cgi?id=52289

Test if the cookie jar is created in the right thread when accessed from
the navigator object.

tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::navigatorCookieEnabledForNetworkAccessManagerOnDifferentThread):

10:25 PM Changeset in webkit [77900] by commit-queue@webkit.org

9 edits in trunk/Source

2011-02-07 Alexey Marinichev <amarinichev@chromium.org>

Reviewed by Kenneth Russell.

Hook up WebGraphicsContext3D::setContextLostCallback.
https://bugs.webkit.org/show_bug.cgi?id=53722

Test: fast/canvas/webgl/context-lost.html, comment out the line with
extension.loseContext() and kill the GPU process "Lose context"
message shows up.

html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContextLostCallback::WebGLRenderingContextLostCallback): (WebCore::WebGLRenderingContextLostCallback::onContextLost): (WebCore::WebGLRenderingContextLostCallback::~WebGLRenderingContextLostCallback): (WebCore::WebGLRenderingContext::initializeNewContext): (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::ContextLostCallback::~ContextLostCallback):
platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::setContextLostCallback): stub
platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::setContextLostCallback): stub

2011-02-07 Alexey Marinichev <amarinichev@chromium.org>

Reviewed by Kenneth Russell.

Hook up WebGraphicsContext3D::setContextLostCallback.
https://bugs.webkit.org/show_bug.cgi?id=53722

Test: fast/canvas/webgl/context-lost.html, comment out the line with
extension.loseContext() and kill the GPU process "Lose context"
message shows up.

public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::WebGraphicsContextLostCallback::~WebGraphicsContextLostCallback):
src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContextLostCallbackAdapter::~GraphicsContextLostCallbackAdapter): (WebCore::GraphicsContextLostCallbackAdapter::GraphicsContextLostCallbackAdapter): (WebCore::GraphicsContextLostCallbackAdapter::onContextLost): (WebCore::GraphicsContextLostCallbackAdapter::create): (WebCore::GraphicsContext3DInternal::setContextLostCallback):
src/GraphicsContext3DInternal.h:

10:24 PM Changeset in webkit [77899] by mrowe@apple.com

2 edits in trunk/Source/WebKit2

Fix the 32-bit build.

UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation): Add some casts
to prevent warnings about mixing signed and unsigned comparisons.

10:11 PM Changeset in webkit [77898] by abarth@webkit.org

3 edits in trunk/Tools

2011-02-07 Adam Barth <abarth@webkit.org>

Add Leopard Debug back to the core builders.

Scripts/webkitpy/common/net/buildbot/buildbot.py:
Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

10:08 PM Changeset in webkit [77897] by commit-queue@webkit.org

4 edits in trunk/LayoutTests

2011-02-07 Ami Fischman <fischman@google.com>

Reviewed by Eric Seidel.

Re-baseline media/video-zoom.html for http://crbug.com/70252 aka
https://bugs.webkit.org/show_bug.cgi?id=53737 to account for (very)
slightly different scrollbar shading.
This test isn't flaky on LINUX or MAC according to
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showAllRuns=true&master=ChromiumWebkit&tests=media%2Fvideo-zoom.html
so take it out of test_expectations.txt; it passes 100% on LINUX and
fails 100% on MAC, and should pass 100% on MAC with this new
baseline.

platform/chromium-mac/media/video-zoom-expected.checksum:
platform/chromium-mac/media/video-zoom-expected.png:
platform/chromium/test_expectations.txt:

10:05 PM Changeset in webkit [77896] by commit-queue@webkit.org

5 edits in trunk

2011-02-07 Adam Klein <adamk@chromium.org>

Reviewed by Jian Li.

[chromium] Remove deprecated method WebNotification::dir
https://bugs.webkit.org/show_bug.cgi?id=53735

public/WebNotification.h:
src/WebNotification.cpp:

2011-02-07 Adam Klein <adamk@chromium.org>

Reviewed by Jian Li.

[chromium] Remove deprecated method WebNotification::dir
https://bugs.webkit.org/show_bug.cgi?id=53735

DumpRenderTree/chromium/NotificationPresenter.cpp: (NotificationPresenter::show):

10:02 PM Changeset in webkit [77895] by Patrick Gansterer

2 edits in trunk/Source/WebCore

2011-02-07 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Add missing PaintInfo include in RenderThemeWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=53885

rendering/RenderThemeWin.cpp:

9:39 PM Changeset in webkit [77894] by jamesr@google.com

1 edit
3 moves in trunk/LayoutTests

2011-02-07 James Robinson <jamesr@chromium.org>

Move sputnik expectations to match test movement.

platform/gtk/fast/js/sputnik: Removed.
platform/gtk/fast/js/sputnik/Unicode: Removed.
platform/gtk/fast/js/sputnik/Unicode/Unicode_510: Removed.
platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Removed.
platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Removed.
platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Removed.
platform/gtk/sputnik: Copied from LayoutTests/platform/gtk/fast/js/sputnik.
platform/mac-leopard/fast/js/sputnik: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A3.2-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S15.5.4.16_A1-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S15.5.4.18_A1-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T1-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T2-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.2_T1-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.2_T2-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.3-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T1-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T2-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T7-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T8-expected.txt: Removed.
platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T9-expected.txt: Removed.
platform/mac-leopard/sputnik: Copied from LayoutTests/platform/mac-leopard/fast/js/sputnik.
platform/win/fast/js/sputnik: Removed.
platform/win/fast/js/sputnik/Conformance: Removed.
platform/win/fast/js/sputnik/Conformance/11_Expressions: Removed.
platform/win/fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators: Removed.
platform/win/fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Percent: Removed.
platform/win/fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Percent/S11.5.3_A4_T6-expected.txt: Removed.
platform/win/fast/js/sputnik/Unicode: Removed.
platform/win/fast/js/sputnik/Unicode/Unicode_510: Removed.
platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Removed.
platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Removed.
platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Removed.
platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Removed.
platform/win/sputnik: Copied from LayoutTests/platform/win/fast/js/sputnik.

9:37 PM Changeset in webkit [77893] by commit-queue@webkit.org

37 edits
38 deletes in trunk/LayoutTests

2011-02-07 Ami Fischman <fischman@google.com>

Reviewed by Eric Carlson.

Removed two of the three almost-duplicate test expectations
between {media,platform/chromium-{mac,win}} by excluding file
extensions from the emitted output.
Removed outdated test_expectation for deleted test.
http://crbug.com/28993

media/controls-right-click-on-timebar-expected.txt:
media/controls-right-click-on-timebar.html:
media/media-file.js: (stripExtension):
media/media-startTime-expected.txt:
media/media-startTime.html:
media/video-append-source-expected.txt:
media/video-append-source.html:
media/video-canvas-source-expected.txt:
media/video-canvas-source.html:
media/video-dom-src-expected.txt:
media/video-dom-src.html:
media/video-load-networkState-expected.txt:
media/video-load-networkState.html:
media/video-played-reset-expected.txt:
media/video-played-reset.html:
media/video-seek-past-end-paused-expected.txt:
media/video-seek-past-end-paused.html:
media/video-seek-past-end-playing-expected.txt:
media/video-seek-past-end-playing.html:
media/video-source-expected.txt:
media/video-source-type-expected.txt:
media/video-source-type-params-expected.txt:
media/video-source-type-params.html:
media/video-source-type.html:
media/video-source.html:
media/video-src-change-expected.txt:
media/video-src-change.html:
media/video-src-expected.txt:
media/video-src-remove-expected.txt:
media/video-src-remove.html:
media/video-src-set-expected.txt:
media/video-src-set.html:
media/video-src-source-expected.txt:
media/video-src-source.html:
media/video-src.html:
media/video-test.js: (enableFullTestDetailsPrinting): (test): (testExpected): (waitForEvent._eventCallback): (waitForEvent): (waitForEventAndTest._eventCallback): (waitForEventAndTest): (testException): (endTest):
platform/chromium-mac/media/controls-right-click-on-timebar-expected.txt: Removed.
platform/chromium-mac/media/media-startTime-expected.txt: Removed.
platform/chromium-mac/media/video-append-source-expected.txt: Removed.
platform/chromium-mac/media/video-canvas-source-expected.txt: Removed.
platform/chromium-mac/media/video-dom-src-expected.txt: Removed.
platform/chromium-mac/media/video-load-networkState-expected.txt: Removed.
platform/chromium-mac/media/video-played-reset-expected.txt: Removed.
platform/chromium-mac/media/video-seek-past-end-paused-expected.txt: Removed.
platform/chromium-mac/media/video-seek-past-end-playing-expected.txt: Removed.
platform/chromium-mac/media/video-source-add-src-expected.txt: Removed.
platform/chromium-mac/media/video-source-error-expected.txt: Removed.
platform/chromium-mac/media/video-source-expected.txt: Removed.
platform/chromium-mac/media/video-source-type-expected.txt: Removed.
platform/chromium-mac/media/video-source-type-params-expected.txt: Removed.
platform/chromium-mac/media/video-src-change-expected.txt: Removed.
platform/chromium-mac/media/video-src-expected.txt: Removed.
platform/chromium-mac/media/video-src-remove-expected.txt: Removed.
platform/chromium-mac/media/video-src-set-expected.txt: Removed.
platform/chromium-mac/media/video-src-source-expected.txt: Removed.
platform/chromium-win/media/controls-right-click-on-timebar-expected.txt: Removed.
platform/chromium-win/media/media-startTime-expected.txt: Removed.
platform/chromium-win/media/video-append-source-expected.txt: Removed.
platform/chromium-win/media/video-canvas-source-expected.txt: Removed.
platform/chromium-win/media/video-dom-src-expected.txt: Removed.
platform/chromium-win/media/video-load-networkState-expected.txt: Removed.
platform/chromium-win/media/video-played-reset-expected.txt: Removed.
platform/chromium-win/media/video-seek-past-end-paused-expected.txt: Removed.
platform/chromium-win/media/video-seek-past-end-playing-expected.txt: Removed.
platform/chromium-win/media/video-source-add-src-expected.txt: Removed.
platform/chromium-win/media/video-source-error-expected.txt: Removed.
platform/chromium-win/media/video-source-expected.txt: Removed.
platform/chromium-win/media/video-source-type-expected.txt: Removed.
platform/chromium-win/media/video-source-type-params-expected.txt: Removed.
platform/chromium-win/media/video-src-change-expected.txt: Removed.
platform/chromium-win/media/video-src-expected.txt: Removed.
platform/chromium-win/media/video-src-remove-expected.txt: Removed.
platform/chromium-win/media/video-src-set-expected.txt: Removed.
platform/chromium-win/media/video-src-source-expected.txt: Removed.
platform/chromium/test_expectations.txt:

9:37 PM Changeset in webkit [77892] by commit-queue@webkit.org

14 edits in trunk/Source

2011-02-07 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

[Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl
https://bugs.webkit.org/show_bug.cgi?id=52974

Add ContextMenuItemTagCopyImageUrlToClipboard into standard action but Qt platform specific.

page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): (WebCore::ContextMenuController::populate): (WebCore::ContextMenuController::checkOrEnableIfNeeded):
platform/ContextMenuItem.h:
platform/LocalizationStrategy.h:
platform/LocalizedStrings.cpp: (WebCore::contextMenuItemTagCopyImageUrlToClipboard):
platform/LocalizedStrings.h:

2011-02-07 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

[Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl
https://bugs.webkit.org/show_bug.cgi?id=52974

Add QWebPage::CopyImageUrlToClipboard into QWebPage::WebAction.

Api/qwebpage.cpp: (webActionForContextMenuAction): (QWebPage::triggerAction): (QWebPage::action):
Api/qwebpage.h:
WebCoreSupport/WebPlatformStrategies.cpp: (WebPlatformStrategies::contextMenuItemTagCopyImageUrlToClipboard):
WebCoreSupport/WebPlatformStrategies.h:

2011-02-07 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

[Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl
https://bugs.webkit.org/show_bug.cgi?id=52974

Add ContextMenuItemTagCopyImageUrlToClipboard into standard action but Qt platform specific.

WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::contextMenuItemTagCopyImageUrlToClipboard):
WebProcess/WebCoreSupport/WebPlatformStrategies.h:

9:28 PM Changeset in webkit [77891] by tkent@chromium.org

4 edits
2 adds in trunk

2011-02-07 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Kent Tamura.

HTMLFormElement::formElementIndex() returns a bad index into a vector of form associated elements
https://bugs.webkit.org/show_bug.cgi?id=53970

Adds HTMLObjectElement::virtualForm() to make HTMLObjectElement::form()
return the right value.

Test: fast/dom/HTMLObjectElement/form/nested-form-element.html

html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::virtualForm): Added.
html/HTMLObjectElement.h: Added virtualForm().

2011-02-07 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Kent Tamura.

HTMLFormElement::formElementIndex() returns a bad index into a vector of form associated elements
https://bugs.webkit.org/show_bug.cgi?id=53970

Adds a test that ensures WebKit parses successfully a page that
contains object elements which are in nested and defective form
elements.

fast/dom/HTMLObjectElement/form/nested-form-element-expected.txt: Added.
fast/dom/HTMLObjectElement/form/nested-form-element.html: Added.

8:39 PM Changeset in webkit [77890] by abarth@webkit.org

3 edits in trunk/Tools

2011-02-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove Leopard Debug as a core builder
https://bugs.webkit.org/show_bug.cgi?id=53971

The Leopard Debug builder has been failing to compile for several days.
My understanding is that folks are working on fixing the build, but for
the time being we should probably remove it from the list of core
builders so that the core waterfall can be green. We can certainly add
it back once the build is fixed.

Also, I've removed the Tiger builders because those no longer appear to
be attached to the buildbot master.

Scripts/webkitpy/common/net/buildbot/buildbot.py:
Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

8:29 PM Changeset in webkit [77889] by ojan@chromium.org

5 edits in trunk

2011-02-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Roben.

include svn revisions in git diffs for the code review tool to use
https://bugs.webkit.org/show_bug.cgi?id=53569

Scripts/webkitpy/common/checkout/scm.py:
Scripts/webkitpy/common/checkout/scm_unittest.py:

2011-02-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Roben.

include svn revisions in git diffs for the code review tool to use
https://bugs.webkit.org/show_bug.cgi?id=53569

PrettyPatch/PrettyPatch.rb:

8:27 PM Changeset in webkit [77888] by rniwa@webkit.org

3 edits in trunk/Source/WebCore

2011-02-07 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Leopard build fix.

WebCore.xcodeproj/project.pbxproj: let XCode have developmentRegion.
platform/mac/DragImageMac.mm: (WebCore::webkit_CGCeiling): Cast the return value of ceil to CGFloat.

8:21 PM Changeset in webkit [77887] by yuzo@google.com

2 edits in trunk/LayoutTests

2011-02-07 Yuzo Fujishima <yuzo@google.com>

Unreviewed attempt to fix a flaky test.
https://bugs.webkit.org/show_bug.cgi?id=51757

fast/css/font-face-download-error.html:

8:07 PM Changeset in webkit [77886] by zmo@google.com

2 edits in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

platform/chromium/test_expectations.txt:

7:55 PM Changeset in webkit [77885] by jamesr@google.com

8 edits
1 move in trunk/LayoutTests

2011-02-07 James Robinson <jamesr@chromium.org>

Reviewed by Dan Bernstein.

Move the sputnik test suite out of fast/js/
https://bugs.webkit.org/show_bug.cgi?id=53954

The sputnik suite shouldn't go in fast/js/ because it is not fast and
it is an imported test suite. This moves it to LayoutTests/sputnik
and updates references in skipped lists / expectations.

platform/chromium/test_expectations.txt:
platform/gtk/Skipped:
platform/mac-tiger/Skipped:
platform/mac-wk2/Skipped:
platform/qt-wk2/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

7:37 PM Changeset in webkit [77884] by rniwa@webkit.org

1 edit in trunk/Source/JavaScriptCore/ChangeLog

Fixing the change log entry.

7:34 PM Changeset in webkit [77883] by rniwa@webkit.org

5 edits in trunk/Source/JavaScriptCore

2011-02-07 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Removed some dead code from Heap
https://bugs.webkit.org/show_bug.cgi?id=53969

SunSpider reports no change.

runtime/MarkedSpace.cpp: (JSC::MarkedSpace::shrink): (JSC::MarkedSpace::sweep):
runtime/MarkedSpace.h: Removed resizeBlocks and growBlocks, and renamed shrinkBlocks to shrink, making it unconditionally shrink as much as possible.

7:13 PM Changeset in webkit [77882] by enrica@apple.com

4 edits in trunk/Source

Source/WebCore: Fixing a build break on Mac caused by http://trac.webkit.org/changeset/77874

Reviewed by Sam Weinig.

When moving code from WebKit to WebCore we needed to move some additional
functions previously in NSStringExtras.

WebCore.xcodeproj/project.pbxproj:
platform/mac/DragImageMac.mm:

(WebCore::fontFromNSFont):
(WebCore::canUseFastRenderer):
(WebCore::widthWithFont):
(WebCore::webkit_CGCeiling):
(WebCore::drawAtPoint):
(WebCore::drawDoubledAtPoint):
(WebCore::createDragImageForLink):

Source/WebKit2: Fixing a build break on Mac caused by http://trac.webkit.org/changeset/77874

Reviewed by Sam Weinig.

Removed unused static function.

WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

7:08 PM Changeset in webkit [77881] by ggaren@apple.com

3 edits in trunk/Source/JavaScriptCore

2011-02-07 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Removed some dead code from Heap
https://bugs.webkit.org/show_bug.cgi?id=53969

SunSpider reports no change.

runtime/MarkedSpace.cpp: (JSC::MarkedSpace::shrink): (JSC::MarkedSpace::sweep):
runtime/MarkedSpace.h: Removed resizeBlocks and growBlocks, and renamed shrinkBlocks to shrink, making it unconditionally shrink as much as possible.

6:21 PM Changeset in webkit [77880] by andersca@apple.com

2 edits in trunk/Source/WebKit2

<rdar://problem/8969888>
The WebProcess should set LSFileQuarantineEnabled to true

Reviewed by Sam Weinig.

WebProcess/Info.plist:

6:13 PM Changeset in webkit [77879] by zmo@google.com

2 edits in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

platform/chromium/test_expectations.txt:

6:04 PM Changeset in webkit [77878] by Lucas Forschler

3 edits in trunk/Source/WebCore

2011-02-07 Lucas Forschler <Lucas Forschler>

Reviewed by Geoff Garen.

Tr #2, Fix the Leopard 32bit debug build.

No new tests required.

WebCore.xcodeproj/project.pbxproj:
accessibility/AccessibilityAllInOne.cpp:

5:58 PM Changeset in webkit [77877] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

2011-02-07 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Simplified the marked space's mark invariant
https://bugs.webkit.org/show_bug.cgi?id=53968

SunSpider reports no change.

runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): Mark objects when allocating them. This means that, at all times other than the mark phase, an object is live if and only if it is marked.

(JSC::MarkedSpace::containsSlowCase): Use the new mark invariant to
simplify testing whether an object is live.

5:53 PM Changeset in webkit [77876] by Beth Dakin

3 edits in trunk/Source/WebCore

Fix for <rdar://problem/8946961> Fix repaint problems
with WKScrollbarPainter scrollers while resizing the window

Reviewed by Sam Weinig.

Remove setPainterForPainterController() and
removePainterFromPainterController() since they aren't
used anymore.

platform/mac/ScrollAnimatorMac.h:

Return early if they alpha hasn't changed.

platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):

If we're in a live resize, restore alpha to 1.
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):

5:47 PM Changeset in webkit [77875] by morrita@google.com

15 edits
4 adds in trunk

2011-02-03 MORITA Hajime <morrita@google.com>

Reviewed by Darin Fisher.

[Chromium] Should implement EditorClientImpl::requestCheckingOfString()
https://bugs.webkit.org/show_bug.cgi?id=51013

Unskipped passed test.

platform/chromium/test_expectations.txt:

2011-02-03 MORITA Hajime <morrita@google.com>

Reviewed by Darin Fisher.

[Chromium] Should implement EditorClientImpl::requestCheckingOfString()
https://bugs.webkit.org/show_bug.cgi?id=51013

Added WebTextCheckingCompletion to receive the checked result asynchronously.
Added WebViewClient::requestCheckingOfText() and related classes.
Implemented EditorClientImpl::requestCheckingOfString().

WebKit.gyp:
public/WebSettings.h:
public/WebTextCheckingCompletion.h: Added. (WebKit::WebTextCheckingCompletion::~WebTextCheckingCompletion):
public/WebTextCheckingResult.h: Added. (WebKit::WebTextCheckingResult::error): (WebKit::WebTextCheckingResult::position): (WebKit::WebTextCheckingResult::length): (WebKit::WebTextCheckingResult::WebTextCheckingResult):
public/WebViewClient.h: (WebKit::WebViewClient::requestCheckingOfText): Gave an implementation
src/AssertMatchingEnums.cpp:
src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::requestCheckingOfString):
src/EditorClientImpl.h:
src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setAsynchronousSpellCheckingEnabled):
src/WebSettingsImpl.h:
src/WebTextCheckingCompletionImpl.cpp: Added. (WebKit::toCoreResults): (WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
src/WebTextCheckingCompletionImpl.h: Added. (WebKit::WebTextCheckingCompletionImpl::WebTextCheckingCompletionImpl):

2011-02-03 MORITA Hajime <morrita@google.com>

Reviewed by Darin Fisher.

[Chromium] Should implement EditorClientImpl::requestCheckingOfString()
https://bugs.webkit.org/show_bug.cgi?id=51013

Gave DRT implementation for requestTextCheck().

DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setAsynchronousSpellCheckingEnabled): Implemented.
DumpRenderTree/chromium/WebViewHost.cpp: (invokeFinishLastTextCheck): Added. (WebViewHost::requestTextCheck): Added. (WebViewHost::finishLastTextCheck): Added.
DumpRenderTree/chromium/WebViewHost.h:

5:44 PM Changeset in webkit [77874] by andersca@apple.com

8 edits in trunk/Source/WebKit2

2011-02-07 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Crash in web process after the connection had been closed
https://bugs.webkit.org/show_bug.cgi?id=51115
<rdar://problem/8964255>

Remove didCloseOnConnectionWorkQueue from Connection::Client and add
Connection::setDidCloseOnConnectionWorkQueueCallback which takes a static
function, eliminating the race condition in connectionDidClose where m_client could be
nulled out in the client thread right before we try to dereference it.

Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::Connection): Initialize m_didCloseOnConnectionWorkQueueCallback.

(CoreIPC::Connection::setDidCloseOnConnectionWorkQueueCallback):
Update m_didCloseOnConnectionWorkQueueCallback.

(CoreIPC::Connection::connectionDidClose):
Call m_didCloseOnConnectionWorkQueueCallback.

Platform/WorkQueue.h: Make WorkQueue noncopyable.

PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::initializeConnection): Call setDidCloseOnConnectionWorkQueueCallback.

Shared/ChildProcess.cpp: (WebKit::ChildProcess::didCloseOnConnectionWorkQueue):
Shared/ChildProcess.h: didCloseOnConnectionWorkQueue is now a static member function.

WebProcess/WebProcess.cpp: (WebKit::WebProcess::initialize): Call setDidCloseOnConnectionWorkQueueCallback.

5:39 PM Changeset in webkit [77873] by Martin Robinson

2 edits
59 adds in trunk/LayoutTests

2011-02-07 Martin Robinson <mrobinson@igalia.com>

Classify tests failing in the fast directory on GTK+. Add results for
tests that just need platform expectations.

platform/gtk/Skipped: Update the skipped list.
platform/gtk/fast/backgrounds/background-clip-text-expected.checksum: Added.
platform/gtk/fast/backgrounds/background-clip-text-expected.png: Added.
platform/gtk/fast/backgrounds/background-clip-text-expected.txt: Added.
platform/gtk/fast/canvas/canvas-zoom-expected.txt: Added.
platform/gtk/fast/css/css1_forward_compatible_parsing-expected.checksum: Added.
platform/gtk/fast/css/css1_forward_compatible_parsing-expected.png: Added.
platform/gtk/fast/css/css1_forward_compatible_parsing-expected.txt: Added.
platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
platform/gtk/fast/css/invalid-percentage-property-expected.checksum: Added.
platform/gtk/fast/css/invalid-percentage-property-expected.png: Added.
platform/gtk/fast/css/invalid-percentage-property-expected.txt: Added.
platform/gtk/fast/css/text-align-expected.checksum: Added.
platform/gtk/fast/css/text-align-expected.png: Added.
platform/gtk/fast/css/text-align-expected.txt: Added.
platform/gtk/fast/dom/Element/getBoundingClientRect-expected.txt: Added.
platform/gtk/fast/dom/Range/getBoundingClientRect-expected.txt: Added.
platform/gtk/fast/dom/Range/getClientRects-expected.txt: Added.
platform/gtk/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
platform/gtk/fast/dom/null-document-location-put-crash-expected.txt: Added.
platform/gtk/fast/dom/tabindex-clamp-expected.txt: Added.
platform/gtk/fast/events/js-keyboard-event-creation-expected.txt: Added.
platform/gtk/fast/events/offsetX-offsetY-expected.txt: Added.
platform/gtk/fast/events/pointer-events-2-expected.checksum: Added.
platform/gtk/fast/events/pointer-events-2-expected.png: Added.
platform/gtk/fast/events/pointer-events-2-expected.txt: Added.
platform/gtk/fast/fast-mobile-scrolling/fixed-position-element-expected.checksum: Added.
platform/gtk/fast/fast-mobile-scrolling/fixed-position-element-expected.png: Added.
platform/gtk/fast/fast-mobile-scrolling/fixed-position-element-expected.txt: Added.
platform/gtk/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.checksum: Added.
platform/gtk/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.png: Added.
platform/gtk/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.txt: Added.
platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.checksum: Added.
platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.png: Added.
platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.txt: Added.
platform/gtk/fast/html/tab-order-expected.txt: Added.
platform/gtk/fast/replaced/table-percent-height-expected.txt: Added.
platform/gtk/fast/selectors/lang-inheritance-expected.checksum: Added.
platform/gtk/fast/selectors/lang-inheritance-expected.png: Added.
platform/gtk/fast/selectors/lang-inheritance-expected.txt: Added.
platform/gtk/fast/selectors/lang-inheritance2-expected.checksum: Added.
platform/gtk/fast/selectors/lang-inheritance2-expected.png: Added.
platform/gtk/fast/selectors/lang-inheritance2-expected.txt: Added.
platform/gtk/fast/selectors/lang-vs-xml-lang-expected.checksum: Added.
platform/gtk/fast/selectors/lang-vs-xml-lang-expected.png: Added.
platform/gtk/fast/selectors/lang-vs-xml-lang-expected.txt: Added.
platform/gtk/fast/selectors/lang-vs-xml-lang-xhtml-expected.checksum: Added.
platform/gtk/fast/selectors/lang-vs-xml-lang-xhtml-expected.png: Added.
platform/gtk/fast/selectors/lang-vs-xml-lang-xhtml-expected.txt: Added.
platform/gtk/fast/text/international/danda-space-expected.checksum: Added.
platform/gtk/fast/text/international/danda-space-expected.png: Added.
platform/gtk/fast/text/international/danda-space-expected.txt: Added.
platform/gtk/fast/text/international/thai-baht-space-expected.checksum: Added.
platform/gtk/fast/text/international/thai-baht-space-expected.png: Added.
platform/gtk/fast/text/international/thai-baht-space-expected.txt: Added.

5:38 PM Changeset in webkit [77872] by zmo@google.com

2 edits in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

platform/chromium/test_expectations.txt:

5:35 PM Changeset in webkit [77871] by Beth Dakin

4 edits in trunk/Source

Fix for https://bugs.webkit.org/show_bug.cgi?id=53950
USE_WK_SCROLLBAR_PAINTER in ScrollbarThemeMac should be in
Platform.h instead

Reviewed by Eric Seidel.

../JavaScriptCore:

wtf/Platform.h:

../WebCore:

Use hot new USE(WK_SCROLLBAR_PAINTER) from Platform.h rather
than the silly, old in-file #define.

platform/mac/ScrollbarThemeMac.mm:

(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
(WebCore::updateArrowPlacement):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::paint):

5:34 PM Changeset in webkit [77870] by enrica@apple.com

47 edits
3 adds in trunk/Source

Reviewed Adam Roben and Darin Adler.

Source/WebCore:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
<rdar://problem/8514409>

loader/EmptyClients.h: Removed createDragImageFromLink.
page/DragClient.h: Ditto.
page/DragController.cpp:

(WebCore::DragController::startDrag): changed call to createDragImageFromLink.

platform/DragImage.h:
platform/mac/DragImageMac.mm:

(WebCore::createDragImageForLink): Moved from DragClient.

platform/win/ClipboardUtilitiesWin.cpp: Added a series of functions

to de-serialize the drag data from the map into an IDataObject.
(WebCore::getWebLocData):
(WebCore::texthtmlFormat):
(WebCore::createGlobalData):
(WebCore::getFullCFHTML):
(WebCore::urlWFormat):
(WebCore::urlFormat):
(WebCore::filenameWFormat):
(WebCore::filenameFormat):
(WebCore::htmlFormat):
(WebCore::smartPasteFormat):
(WebCore::getURL):
(WebCore::getPlainText):
(WebCore::getTextHTML):
(WebCore::ClipboardDataItem::ClipboardDataItem):
(WebCore::getStringData):
(WebCore::getUtf8Data):
(WebCore::getCFData):
(WebCore::setUCharData):
(WebCore::setCharData):
(WebCore::setCFData):
(WebCore::getClipboardMap):
(WebCore::getClipboardData):
(WebCore::setClipboardData):

platform/win/ClipboardUtilitiesWin.h:
platform/win/DragImageWin.cpp: Moved createDragImageForLink from DragClient

to a platform specific file in WebCore. It makes a lot more sense here, since
the drag image is always created in WebCore for all the other content types
except for links.
(WebCore::dragLabelFont):
(WebCore::createDragImageForLink):

platform/win/WCDataObject.cpp: Added new way to

construct a WCDataObject from a DragDataMap.
(WebCore::WCDataObject::createInstance):
(WebCore::WCDataObject::clearData):

platform/win/WCDataObject.h:

Source/WebKit/chromium:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

src/DragClientImpl.cpp:
src/DragClientImpl.h:

Source/WebKit/efl:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

WebCoreSupport/DragClientEfl.cpp:
WebCoreSupport/DragClientEfl.h:

Source/WebKit/gtk:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

WebCoreSupport/DragClientGtk.cpp:
WebCoreSupport/DragClientGtk.h:

Source/WebKit/haiku:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

WebCoreSupport/DragClientHaiku.cpp:
WebCoreSupport/DragClientHaiku.h:

Source/WebKit/mac:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

WebCoreSupport/WebDragClient.h:
WebCoreSupport/WebDragClient.mm:

(WebDragClient::startDrag):

Source/WebKit/qt:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

WebCoreSupport/DragClientQt.cpp:
WebCoreSupport/DragClientQt.h:

Source/WebKit/win:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

WebCoreSupport/WebDragClient.cpp:

(WebDragClient::startDrag):

WebCoreSupport/WebDragClient.h:

Source/WebKit/wince:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

WebCoreSupport/DragClientWinCE.cpp:
WebCoreSupport/DragClientWinCE.h:

Source/WebKit/wx:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

WebKitSupport/DragClientWx.cpp:
WebKitSupport/DragClientWx.h:

Source/WebKit2:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
<rdar://problem/8514409>

This patch contains the remaining work to support
a WebKit window as drag source on Windows.
I've added the code to generate the image for dragging a link as
well as the steps necessary to package the HBITMAP into a SharedMemory
object and send it over to the UI process where DoDragDrop is performed.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setDragImage):
(WebKit::WebPageProxy::startDragDrop):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebProcess/WebCoreSupport/WebDragClient.cpp:

(WebKit::WebDragClient::startDrag): Made startDrag for
platforms other than Windows and Mac.

WebProcess/WebCoreSupport/WebDragClient.h:
WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::startDrag):

WebProcess/WebCoreSupport/win/WebDragClientWin.cpp: Added.

(WebKit::draggingSourceOperationMaskToDragCursors):
(WebKit::WebDragClient::startDrag):

WebProcess/WebCoreSupport/win/WebDragSource.cpp: Added.

This object implements the IDropSource interface.
(WebDragSource::createInstance):
(WebDragSource::WebDragSource):
(WebDragSource::QueryInterface):
(WebDragSource::AddRef):
(WebDragSource::Release):
(WebDragSource::QueryContinueDrag):
(WebDragSource::GiveFeedback):

WebProcess/WebCoreSupport/win/WebDragSource.h: Added.
win/WebKit2.vcproj:

5:32 PM Changeset in webkit [77869] by zmo@google.com

2 edits in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

platform/chromium/test_expectations.txt:

5:23 PM Changeset in webkit [77868] by joone.hur@collabora.co.uk

8 edits
1 add in trunk

2011-02-07 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[Gtk] Implement layoutTestController.findString
https://bugs.webkit.org/show_bug.cgi?id=50237

Unskip editing/text-iterator/findString.html.

platform/gtk/Skipped: Unskip findString test.

2011-02-07 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[Gtk] Implement layoutTestController.findString
https://bugs.webkit.org/show_bug.cgi?id=50237

GNUmakefile.am: Add AssertMatchingEnums.cpp.
WebCoreSupport/AssertMatchingEnums.cpp: Add this file to assert that various WebKit API enum values continue matching WebCore defined enum values.
WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::findString):
WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-02-07 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[Gtk] Implement layoutTestController.findString
https://bugs.webkit.org/show_bug.cgi?id=50237

DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::findString):

5:02 PM Changeset in webkit [77867] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-02-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77848.
http://trac.webkit.org/changeset/77848
https://bugs.webkit.org/show_bug.cgi?id=53963

caused 6 test failures (Requested by othermaciej on #webkit).

rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):

5:00 PM Changeset in webkit [77866] by andersca@apple.com

2 edits in trunk/Source/WebKit2

2011-02-07 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

UI process crashes if web process crashes while web inspector is focused
https://bugs.webkit.org/show_bug.cgi?id=53965
<rdar://problem/8961633>

Make sure to close the web inspector web page proxy before calling platformClose, since
platformClose can cause the web page proxy to try to send messages (such as SetActive)
to the web process while it's in a bad state.

UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::didClose):

4:57 PM Changeset in webkit [77865] by kbr@google.com

5 edits
4 adds in trunk/Source/WebCore

2011-02-04 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Add shaders for GPU accelerated path rendering
https://bugs.webkit.org/show_bug.cgi?id=45520

Refactored SolidFillShader and TexShader to call new
generateVertex() and generateFragment() methods on base Shader
class, and added support for the Loop/Blinn shaders. Refactored
Loop/Blinn shader classes to derive from Shader.

Tested these changes with several of the IE9 Testdrive demos with
accelerated 2D canvas enabled, as well as a full layout test run
with --platform chromium-gpu.

platform/graphics/gpu/LoopBlinnShader.cpp: Added. (WebCore::LoopBlinnShader::LoopBlinnShader): (WebCore::LoopBlinnShader::use):
platform/graphics/gpu/LoopBlinnShader.h: Added.
platform/graphics/gpu/LoopBlinnSolidFillShader.cpp: Added. (WebCore::LoopBlinnSolidFillShader::create): (WebCore::LoopBlinnSolidFillShader::LoopBlinnSolidFillShader): (WebCore::LoopBlinnSolidFillShader::use):
platform/graphics/gpu/LoopBlinnSolidFillShader.h: Added.
platform/graphics/gpu/Shader.cpp: (WebCore::Shader::affineTo4x4): (WebCore::Shader::loadShader): (WebCore::Shader::loadProgram): (WebCore::Shader::generateVertex): (WebCore::Shader::generateFragment):
platform/graphics/gpu/Shader.h:
platform/graphics/gpu/SolidFillShader.cpp: (WebCore::SolidFillShader::create):
platform/graphics/gpu/TexShader.cpp: (WebCore::TexShader::TexShader): (WebCore::TexShader::create):

4:51 PM Changeset in webkit [77864] by mjs@apple.com

2 edits in trunk/LayoutTests

2011-02-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

Skip a newly added test that uses unimplemented DRT functionality
https://bugs.webkit.org/show_bug.cgi?id=53938

platform/mac-wk2/Skipped:

4:30 PM Changeset in webkit [77863] by zmo@google.com

5 edits
1 add in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, rebaseline.

platform/chromium-linux/fast/html/keygen-expected.checksum:
platform/chromium-linux/fast/html/keygen-expected.png:
platform/chromium-linux/fast/html/keygen-expected.txt: Added.
platform/chromium-win/fast/html/keygen-expected.txt:
platform/chromium/test_expectations.txt:

4:29 PM Changeset in webkit [77862] by andersca@apple.com

2 edits in trunk/Source/WebKit2

2011-02-07 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Find bouncy is missing content on pages with framesets
https://bugs.webkit.org/show_bug.cgi?id=53958
<rdar://problem/8904447>

Fix paint rect computation; FrameView::paint expects the paint rect to be in the
parent widget's coordinate system.

WebProcess/WebPage/FindController.cpp: (WebKit::FindController::updateFindIndicator):

4:22 PM Changeset in webkit [77861] by beidson@apple.com

2 edits in trunk/Source/WebKit2

<rdar://problem/8960434> and https://bugs.webkit.org/show_bug.cgi?id=53957
Crash after incorrectly restoring bogus session state.

Reviewed by Anders Carlsson.

In some cases we're writing an invalid session state for a back/forward list where the current entry is 0
but the number of entries is also 0.
In such cases the current entry should be "NoCurrentEntryIndex."

When we later read this state in, we set ourselves up to crash later.

Amusingly an ASSERT caught this, but we should've rejected it before the ASSERT fired.

UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation): Fail the restore if the "current index past the end

of the list" case occurs, and speculatively bail out of the case where we have no current index but do have a list.
Also remove the unhelpful ASSERT.

4:22 PM Changeset in webkit [77860] by zmo@google.com

2 edits in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

platform/chromium/test_expectations.txt:

4:11 PM Changeset in webkit [77859] by zmo@google.com

2 edits in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

platform/chromium/test_expectations.txt:

4:07 PM Changeset in webkit [77858] by mitz@apple.com

3 edits in trunk/Source/WebCore

<rdar://problem/8946023> REGRESSION (r76674): SVG + BiDi text broken (text-intro-05-t.svg)
https://bugs.webkit.org/show_bug.cgi?id=53480

Reviewed by Oliver Hunt.

WebCore.xcodeproj/project.pbxproj:
platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): m_indexEnd should be an
offset into m_characters, not into the run’s characters.

platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Ditto.

4:01 PM Changeset in webkit [77857] by zmo@google.com

2 edits in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

platform/chromium/test_expectations.txt:

3:46 PM Changeset in webkit [77856] by weinig@apple.com

7 edits in trunk/Source

Add bundle API to get the background color of a frame
<rdar://problem/8962670>
https://bugs.webkit.org/show_bug.cgi?id=53952

Reviewed by Anders Carlsson.

../WebCore:

WebCore.exp.in: Add export.

../WebKit2:

WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameGetBodyBackgroundColor):

WebProcess/InjectedBundle/API/c/WKBundleFrame.h:

Add API function.

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::getDocumentBackgroundColor):

WebProcess/WebPage/WebFrame.h:

Call down into the document to get either the body's, or if there is no body,
the root element's, background color.

3:45 PM Changeset in webkit [77855] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Fix crashes in QMetaObject::metacall
https://bugs.webkit.org/show_bug.cgi?id=53912

platform/qt/Skipped: http/tests/websocket/tests/websocket-pending-activity.html added until fix.

3:41 PM Changeset in webkit [77854] by zmo@google.com

3 edits in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, rebaseline.

platform/chromium-mac/fast/url/path-expected.txt:
platform/chromium-win/fast/url/path-expected.txt:

3:37 PM Changeset in webkit [77853] by ggaren@apple.com

4 edits in trunk/Source/WebCore

2011-02-07 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Assertion failure in ~JSGlobalObject when loading apple.com HTML5
transitions demo page
https://bugs.webkit.org/show_bug.cgi?id=53853

This was a long-standing bookkeeping bug uncovered by some heap refactoring.

html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer):
html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::notifyFinished):
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dropProtection): Take the JSLock before reporting extra cost to the JavaScriptCore heap, since all use of JavaScriptCore is supposed to be guarded by JSLock.

3:28 PM Changeset in webkit [77852] by jianli@chromium.org

8 edits in trunk

Intermittent crash in fast/files/read-blob-async.html on the GTK+ debug
bots
https://bugs.webkit.org/show_bug.cgi?id=53104

Reviewed by David Levin.

Source/WebCore:

Covered by the existing tests.

fileapi/FileStreamProxy.cpp:

(WebCore::FileStreamProxy::startOnFileThread):

platform/network/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::createResourceHandle):

platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::BlobResourceHandle):
(WebCore::BlobResourceHandle::cancel):
(WebCore::delayedStartBlobResourceHandle):
(WebCore::BlobResourceHandle::start): Keep BlobResourceHandle alive
till the delay function is called.
(WebCore::BlobResourceHandle::doStart):
(WebCore::doNotifyFinish):
(WebCore::BlobResourceHandle::notifyFinish): Notify the client via the
standalone function to prevent the handle from being disposed immediately
by the client which will make the calls in the stack that're still bound
to the handle suffer.

platform/network/BlobResourceHandle.h:
platform/network/ResourceHandle.h: Change cancel() to virtual so that

BlobResourceHandle::cancel will be called when we abort a FileReader.

LayoutTests:

platform/gtk/Skipped: Enable the flakey test that has been fixed.

3:27 PM Changeset in webkit [77851] by abarth@webkit.org

1 edit
1 delete in trunk/LayoutTests

2011-02-07 Adam Barth <abarth@webkit.org>

Remove wrong platform-specific expectation.

platform/win/plugins/plugin-document-back-forward-expected.txt: Removed.

3:09 PM Changeset in webkit [77850] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

2011-02-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77845.
http://trac.webkit.org/changeset/77845
https://bugs.webkit.org/show_bug.cgi?id=53946

build failure (Requested by lforschler_ on #webkit).

WebCore.xcodeproj/project.pbxproj:
accessibility/AccessibilityAllInOne.cpp:

3:05 PM Changeset in webkit [77849] by Darin Adler

2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=53939
fast/css/text-overflow-ellipsis.html failure after r77818/77819

platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::registerExtendedEncodingNames):
Add back the "utf8" synonym for "UTF-8".

2:58 PM Changeset in webkit [77848] by hyatt@apple.com

2 edits in trunk/Source/WebCore

Remove an unnecessary extra computeLogicalWidth() from line layout.

Reviewed by Dan Bernstein.

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):

2:34 PM Changeset in webkit [77847] by weinig@apple.com

3 edits in trunk/Source/WebKit2

Fix typo. vectical -> vertical.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeScrollbarsForMainFrame):

2:32 PM Changeset in webkit [77846] by weinig@apple.com

8 edits in trunk/Source/WebKit2

Inform the UIProcess when main frame scrollbars change
<rdar://problem/8967496>
https://bugs.webkit.org/show_bug.cgi?id=53941

Reviewed by Anders Carlsson.

UIProcess/API/C/WKPage.cpp:

(WKPageHasHorizontalScrollbar):
(WKPageHasVerticalScrollbar):

UIProcess/API/C/WKPage.h:

Add API to query whether the main frame has scrollbars.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::didChangeScrollbarsForMainFrame):

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::hasHorizontalScrollbar):
(WebKit::WebPageProxy::hasVerticalScrollbar):
Store/update main frame scrollbar state.

UIProcess/WebPageProxy.messages.in:
WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged):

WebProcess/WebCoreSupport/WebChromeClient.h:

(WebKit::WebChromeClient::WebChromeClient):
Post message when main frame scrollbar state changes.

2:28 PM Changeset in webkit [77845] by Lucas Forschler

3 edits in trunk/Source/WebCore

2011-02-07 Lucas Forschler <Lucas Forschler>

Reviewed by Geoffrey Garen.

Fix Leopard Intel Debug Build.
<rdar://problem/8953606> REGRESSION: Can't link WebCore on 32-bit Leopard (53681)
This could potentially break windows, since I had to change #include <filename> to #include "filename"

WebCore.xcodeproj/project.pbxproj:
accessibility/AccessibilityAllInOne.cpp:

1:54 PM Changeset in webkit [77844] by zmo@google.com

2 edits in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

platform/chromium/test_expectations.txt:

1:48 PM Changeset in webkit [77843] by weinig@apple.com

2 edits in trunk/Source/WebCore

Fix build.

platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):

1:42 PM Changeset in webkit [77842] by andersca@apple.com

8 edits in trunk/Source/WebKit2

2011-02-07 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Some content is not covered by Find-on-page overlay
https://bugs.webkit.org/show_bug.cgi?id=53937
<rdar://problem/8711353>

WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::didInstallPageOverlay): Call LayerTreeHost::didInstallPageOverlay.

(WebKit::DrawingAreaImpl::didUninstallPageOverlay):
Call LayerTreeHost::didUninstallPageOverlay.

(WebKit::DrawingAreaImpl::setPageOverlayNeedsDisplay):
Call LayerTreeHost::setPageOverlayNeedsDisplay.

WebProcess/WebPage/FindController.cpp: (WebKit::FindController::drawRect): Remove a bogus assertion.

WebProcess/WebPage/LayerTreeHost.h: Add new pure virtual member functions.

WebProcess/WebPage/PageOverlay.cpp: (WebKit::PageOverlay::setNeedsDisplay): Call DrawingArea::setPageOverlayNeedsDisplay.

WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::installPageOverlay): Make sure to call PageOverlay::setNeedsDisplay after the page overlay has been installed.

WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::LayerTreeHostMac): Create the page overlay layer if needed.

(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay):
Invalidate the page overlay layer as well.

(WebKit::LayerTreeHostMac::sizeDidChange):
Resize the page overlay layer.

(WebKit::LayerTreeHostMac::didInstallPageOverlay):
Create the page overlay layer.

(WebKit::LayerTreeHostMac::didUninstallPageOverlay):
Destroy the page overlay layer.

(WebKit::LayerTreeHostMac::setPageOverlayNeedsDisplay):
Call setNeedsDisplay on the page overlay layer.

(WebKit::LayerTreeHostMac::paintContents):
Handle painting the page overlay layer.

(WebKit::LayerTreeHostMac::flushPendingLayerChanges):
Flush the page overlay layer changes as well.

(WebKit::LayerTreeHostMac::createPageOverlayLayer):
Create a layer and add it as a sublayer of the root layer.

(WebKit::LayerTreeHostMac::destroyPageOverlayLayer):
Destroy the page overlay layer.

1:29 PM Changeset in webkit [77841] by weinig@apple.com

9 edits in trunk/Source/WebCore

Add mechanism to inform the ScrollAnimator when Scrollbars are added
and removed.

Reviewed by Beth Dakin.

platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::didAddVerticalScrollbar):
(WebCore::ScrollAnimator::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimator::didAddHorizontalScrollbar):
(WebCore::ScrollAnimator::willRemoveHorizontalScrollbar):
Make virtual to allow platform specific overrides.

platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
Call new ScrollableArea functions.

platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::didAddVerticalScrollbar):
(WebCore::ScrollableArea::willRemoveVerticalScrollbar):
(WebCore::ScrollableArea::didAddHorizontalScrollbar):
(WebCore::ScrollableArea::willRemoveHorizontalScrollbar):

platform/ScrollableArea.h:

Pipe to ScrollAnimator.

platform/mac/ScrollAnimatorMac.h:
platform/mac/ScrollAnimatorMac.mm:

platform/mac/ScrollbarThemeMac.h:
platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::painterForScrollbar):
Move painter delegate registration to the new didAdd/willRemove functions.

1:25 PM Changeset in webkit [77840] by zmo@google.com

2 edits in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

platform/chromium/test_expectations.txt:

1:19 PM Changeset in webkit [77839] by Adam Roben

4 edits in trunk/Source/WebKit2

Make it possible to use DrawingAreaProxyImpl on Windows

It can be optionally turned on by setting the WEBKIT2_USE_NEW_DRAWING_AREA environment
variable. Turning it on by default is covered by <http://webkit.org/b/53805>.

Fixes <http://webkit.org/b/53879>.

Reviewed by Anders Carlsson.

UIProcess/BackingStore.h: Add an m_bitmap member on Windows.

UIProcess/win/BackingStoreWin.cpp:

(WebKit::BitmapDC::operator HDC):
(WebKit::BitmapDC::BitmapDC):
(WebKit::BitmapDC::~BitmapDC):
Added this helper class, which uses RAII to select a bitmap into a new memory DC.
(WebKit::BackingStore::paint): Wrap our bitmap in a BitmapDC and use ::BitBlt to copy the
specified rect into the destination DC.
(WebKit::createBitmap): New helper function, just creates a DIB section with the specified
size.
(WebKit::BackingStore::incorporateUpdate): Ported from BackingStoreMac.mm. It seems like
this code could be shared at some point.
(WebKit::BackingStore::scroll): Wrap our bitmap in a BitmapDC and use ::ScrollDC to scroll
the specified rect.

UIProcess/win/WebView.cpp:

(WebKit::useNewDrawingArea): Added. Returns true if the WEBKIT2_USE_NEW_DRAWING_AREA
environment variable is set.
(WebKit::drawPageBackground): New helper function. Code came from onPaintEvent.
(WebKit::WebView::onPaintEvent): Ported from -[WKView drawRect:].
(WebKit::WebView::createDrawingAreaProxy): Create a DrawingAreaProxyImpl if we're using the
new drawing area.

(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):
(WebKit::WebView::pageDidEnterAcceleratedCompositing):
(WebKit::WebView::pageDidLeaveAcceleratedCompositing):
Added some assertions to make sure these are only called when expected. We don't expect
enter/exitAcceleratedCompositingMode to be called at all right now, because accelerated
compositing is turned off in WebKit2 on Windows.

(WebKit::WebView::switchToDrawingAreaTypeIfNecessary): Ditto, and added a case for the
DrawingAreaInfo::Impl constant.

1:19 PM Changeset in webkit [77838] by Adam Roben

13 edits
2 copies in trunk/Source/WebKit2

Start compiling DrawingArea[Proxy]Impl and dependencies on Windows

Fixes <http://webkit.org/b/53875> WebKit2 on Windows should build DrawingArea[Proxy]Impl

Reviewed by Sam Weinig and Darin Adler.

Platform/Region.cpp:

(WebKit::Region::Shape::shapeOperation): Initialize variable to avoid a bogus "potentially
uninitialized variable" warning.

UIProcess/BackingStore.cpp: Removed #error for non-Mac platforms.

UIProcess/BackingStore.h: Added a PlatformGraphicsContext typedef for Windows.

UIProcess/DrawingAreaProxy.h:
UIProcess/DrawingAreaProxyImpl.cpp:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
Allow Windows to compile the new drawing area code.

WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create): Allow creating a DrawingAreaImpl on Windows, too.

WebProcess/WebPage/DrawingArea.h:
WebProcess/WebPage/DrawingAreaImpl.cpp:
WebProcess/WebPage/LayerTreeHost.cpp:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage):
Allow Windows to compile the new drawing area code.

Shared/win/LayerTreeContextWin.cpp: Added.
UIProcess/win/BackingStoreWin.cpp: Added.

Stubbed out these files.

win/WebKit2.vcproj: Added new files.

12:57 PM Changeset in webkit [77837] by andersca@apple.com

7 edits in trunk/Source/WebKit2

2011-02-07 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Rename some drawing area related member functions
https://bugs.webkit.org/show_bug.cgi?id=53935

WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::setPageOverlayNeedsDisplay):
WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setNeedsDisplay): (WebKit::DrawingAreaImpl::setPageOverlayNeedsDisplay):
WebProcess/WebPage/DrawingAreaImpl.h:
WebProcess/WebPage/LayerTreeHost.h:
WebProcess/WebPage/mac/LayerTreeHostMac.h:
WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay): (WebKit::LayerTreeHostMac::scrollNonCompositedContents):

12:49 PM Changeset in webkit [77836] by chang.shu@nokia.com

2 edits in trunk/Tools

2011-02-07 Chang Shu <chang.shu@nokia.com>

Reviewed by Darin Adler.

We should disable spatial navigation explicitly during the initialization
of DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=53928

DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):

12:43 PM Changeset in webkit [77835] by andersca@apple.com

2 edits in trunk/Source/WebCore

2011-02-07 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Missing text match markers with accelerated content
https://bugs.webkit.org/show_bug.cgi?id=53934

When doing the fake paint that recomputes the text match rects, we need to
flatten compositing layers, otherwise the rects won't be updated until the next paint call.

(This worked by accident in WebKit1 because Safari calls -[NSWindow displayIfNeeded] on the containing
window before asking for the text match rects).

editing/Editor.cpp: (WebCore::Editor::countMatchesForText):

12:08 PM Changeset in webkit [77834] by Antti Koivisto

4 edits in trunk/Source/WebCore

REGRESSION(r77740): CSSStyleSelector accessing deleted memory for svg/dom/use-transform.svg
https://bugs.webkit.org/show_bug.cgi?id=53900

Reviewed by Andreas Kling.

Ignore link elements in shadow trees.

dom/Element.cpp:

(WebCore::StyleSelectorParentPusher::StyleSelectorParentPusher):
(WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):

Some asserts to catch cases like this.

(WebCore::Element::attach):
(WebCore::Element::recalcStyle):

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::insertedIntoDocument):
(WebCore::HTMLLinkElement::removedFromDocument):

html/HTMLLinkElement.h:

11:39 AM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com

add .slimdebug (diff)

11:18 AM Changeset in webkit [77833] by Dimitri Glazkov

2 edits in trunk/LayoutTests

2011-02-07 Dimitri Glazkov <Dimitri Glazkov>

Mark test as flaky per dashboard.
https://bugs.webkit.org/show_bug.cgi?id=53824

platform/chromium/test_expectations.txt: Marked.

11:10 AM Changeset in webkit [77832] by jam@chromium.org

7 edits
2 copies in branches/chromium/648

Merge 77706 - 2011-02-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474

Test that plugin loads when in a plugin document on back-forward.

plugins/plugin-document-back-forward-expected.txt: Added.
plugins/plugin-document-back-forward.html: Added.

2011-02-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474

Long ago, PluginDocument always caused the HTMLEmbedElement to create
its widget synchronously during a post-layout task. Recently, however,
some changes to the HistroyController caused layout on back/forward to
become slightly more complicated (and added an extra level of recursion
to layout). This extra level of recursion triggered the "I've recursed
too many times" condition in the post-layout task queue, causing the
FrameView to run the remainder of the tasks asynchronously.
Unfortunately, that broke PluginDocument because it needs its the
HTMLEmbedElement's updateWidget task to run synchronously.

This patch adds a mechanism for "kicking off" the pending post-layout
tasks synchronously (instead of waiting for the timer to fire).
PluginDocument then uses that facility to ensure that the
HTMLEmbedElement's updateWidget task happens.

Test: plugins/plugin-document-back-forward.html

html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
page/FrameView.cpp: (WebCore::FrameView::flushAnyPendingPostLayoutTasks):
page/FrameView.h:

2011-02-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474

Teach the test plugin how to call alert on load.

DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New):

TBR=abarth@webkit.org
Review URL: http://codereview.chromium.org/6286151

10:47 AM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com

add -b syntax for compiling both Source and Tools project files (diff)

10:46 AM Changeset in webkit [77831] by Darin Adler

9 edits in trunk/Source/WebCore

Turn UTF-8 decoder off for now so we can look into failing tests
without leaving the tree red.

platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::registerBaseEncodingNames): Reverting
earlier change so this can handle UTF-8.
(WebCore::TextCodecICU::registerBaseCodecs): Ditto.
(WebCore::TextCodecICU::registerExtendedEncodingNames): Ditto.
(WebCore::TextCodecICU::registerExtendedCodecs): Ditto.

platform/text/TextCodecICU.h: Ditto.
platform/text/TextEncodingRegistry.cpp:

(WebCore::buildBaseTextCodecMaps): Ditto.
(WebCore::extendTextCodecMaps): Ditto.

platform/text/brew/TextCodecBrew.cpp:

(WebCore::TextCodecBrew::registerBaseEncodingNames): Ditto.
(WebCore::TextCodecBrew::registerBaseCodecs): Ditto.
(WebCore::TextCodecBrew::registerExtendedEncodingNames): Ditto.
(WebCore::TextCodecBrew::registerExtendedCodecs): Ditto.

platform/text/brew/TextCodecBrew.h: Ditto.
platform/text/gtk/TextCodecGtk.cpp:

(WebCore::TextCodecGtk::registerBaseEncodingNames): Ditto.
(WebCore::TextCodecGtk::registerBaseCodecs): Ditto.

platform/text/wince/TextCodecWinCE.cpp:

(WebCore::TextCodecWinCE::registerBaseEncodingNames): Ditto.
(WebCore::TextCodecWinCE::registerBaseCodecs): Ditto.
(WebCore::TextCodecWinCE::registerExtendedEncodingNames): Ditto.
(WebCore::TextCodecWinCE::registerExtendedCodecs): Ditto.

platform/text/wince/TextCodecWinCE.h: Ditto.

10:45 AM Changeset in webkit [77830] by Adam Roben

2 edits in trunk/Source/WebKit2

Use the right calling convention when calling WebKitMain

Fixes <http://webkit.org/b/53923> REGRESSION (r77678): Crash on quit in web process in
wWinMain

Reviewed by Steve Falkenburg.

win/MainWin.cpp:

(wWinMain): Use cdecl instead of WINAPI (stdcall) when calling WebKitMain, since that is
how that function is declared.

10:39 AM Changeset in webkit [77829] by andersca@apple.com

6 edits in trunk/Source/WebKit2

2011-02-07 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

The drawing area should be in charge of drawing the page overlay
https://bugs.webkit.org/show_bug.cgi?id=53927

WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::didInstallPageOverlay): (WebKit::DrawingArea::didUninstallPageOverlay): (WebKit::DrawingArea::setOverlayNeedsDisplay): Add empty stubs.

WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::didInstallPageOverlay): Add empty function. This will eventually ask the layer tree host to create a GraphicsLayer for the page overlay.

(WebKit::DrawingAreaImpl::didUninstallPageOverlay):
Tell the page that it needs to be repainted.

(WebKit::DrawingAreaImpl::setOverlayNeedsDisplay):
Just call setNeedsDisplay for now.

(WebKit::DrawingAreaImpl::display):
Paint the page overlay too.

WebProcess/WebPage/DrawingAreaImpl.h:
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRect): Only call drawPageOverlay if we have an old drawing area.

(WebKit::WebPage::drawPageOverlay):
Draw the page overlay. Code moved here from WebPage::drawRect.

(WebKit::WebPage::installPageOverlay):
Call DrawingArea::installPageOverlay.

(WebKit::WebPage::uninstallPageOverlay):
Call DrawingArea::uninstallPageOverlay.

WebProcess/WebPage/WebPage.h: (WebKit::WebPage::hasPageOverlay): Add getter.

10:31 AM Changeset in webkit [77828] by andersca@apple.com

2 edits in trunk/Source/WebCore

Don't exclude overlay scrollers from the page overlay bounds
https://bugs.webkit.org/show_bug.cgi?id=53924

Reviewed by Maciej Stachowiak.

Export ScrollbarTheme::nativeTheme.

WebCore.exp.in:

10:31 AM Changeset in webkit [77827] by antonm@chromium.org

3 edits in branches/chromium/648/Source/WebCore

Merge 77597 - 2011-02-03 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Bail out if to string conversion returned empty handle
https://bugs.webkit.org/show_bug.cgi?id=53687

This a temporary measure: actually one probably should never get empty handle
if there was no exception. The root cause is under investigation.
The bailout though allows Chromium not to crash---attempt to convert an empty
v8 hande into WebCore string crashes with invalid memory access.

See http://code.google.com/p/chromium/issues/detail?id=71544

There is no known reduction expressible as a layout test so far. The crash found with automated testing tools.

bindings/v8/V8Binding.cpp: (WebCore::v8NonStringValueToWebCoreString): Bail out on empty handle
bindings/v8/V8Binding.h: (WebCore::V8ParameterBase::prepareBase): Ditto

TBR=antonm@chromium.org
Review URL: http://codereview.chromium.org/6368135

10:26 AM Changeset in webkit [77826] by andersca@apple.com

4 edits in trunk/Source/WebKit2

2011-02-07 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add WebPage::bounds and use it
https://bugs.webkit.org/show_bug.cgi?id=53926

WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::resumePainting):
WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::resumePainting): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
WebProcess/WebPage/WebPage.h: (WebKit::WebPage::bounds):

10:21 AM Changeset in webkit [77825] by andersca@apple.com

2 edits in trunk/Source/WebKit2

2011-02-07 Anders Carlsson <andersca@apple.com>

Reviewed by Maciej Stachowiak.

Don't exclude overlay scrollers from the page overlay bounds
https://bugs.webkit.org/show_bug.cgi?id=53924

Don't subtract the scrollbars from the page overlay bounds if
overlay scrollers are enabled.

WebProcess/WebPage/PageOverlay.cpp: (WebKit::PageOverlay::bounds):

10:18 AM Changeset in webkit [77824] by Martin Robinson

2 edits
1 add in trunk/LayoutTests

2011-02-07 Martin Robinson <mrobinson@igalia.com>

Unskip a passing accessibility test and organize the rest of the tests missing
results as failing.

platform/gtk/Skipped: Unskip passing test and organize remaining failures.
platform/gtk/accessibility/aria-describedby-on-input-expected.txt: Added.

10:02 AM Changeset in webkit [77823] by Darin Adler

2 edits in trunk/Source/JavaScriptCore

Add built-in decoder for UTF-8 for improved performance
https://bugs.webkit.org/show_bug.cgi?id=53898

Reviewed by Antti Koivisto.

wtf/unicode/UnicodeMacrosFromICU.h: Added U8_MAX_LENGTH and

U8_APPEND_UNSAFE. Also fixed header.

9:57 AM Changeset in webkit [77822] by mjs@apple.com

2 edits in trunk/Tools

Not reviewed.

Fix WebKitTestRunner build on the SL bot.

WebKitTestRunner/Configurations/Base.xcconfig: Look for the JSC copy

of ICU headers.

9:29 AM Changeset in webkit [77821] by zmo@google.com

4 edits
2 adds in trunk

2011-02-03 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Crash in glDrawArrays with NaCl crystal model
https://bugs.webkit.org/show_bug.cgi?id=52831

html/canvas/WebGLRenderingContext.cpp: Allocate large enough buffer for atttrib0 if it's enabled and not used. (WebCore::WebGLRenderingContext::initVertexAttrib0): (WebCore::WebGLRenderingContext::simulateVertexAttrib0):
html/canvas/WebGLRenderingContext.h:

2011-02-03 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Crash in glDrawArrays with NaCl crystal model
https://bugs.webkit.org/show_bug.cgi?id=52831

fast/canvas/webgl/gl-vertex-attrib-zero-issues-expected.txt: Added.
fast/canvas/webgl/gl-vertex-attrib-zero-issues.html: Added.

9:24 AM Changeset in webkit [77820] by Chris Fleizach

6 edits
2 adds in trunk

Source/WebCore: WAI-ARIA @aria-sort not exposed on rowheader and columnheader roles.
https://bugs.webkit.org/show_bug.cgi?id=53842

Reviewed by Darin Adler.

Test: platform/mac/accessibility/aria-sort.html

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::sortDirection):

accessibility/AccessibilityObject.h:
accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

html/HTMLAttributeNames.in:

LayoutTests: WAI-ARIA @aria-sort not exposed on rowheader and columnheader roles
https://bugs.webkit.org/show_bug.cgi?id=53842

Reviewed by Darin Adler.

platform/mac/accessibility/aria-sort-expected.txt: Added.
platform/mac/accessibility/aria-sort.html: Added.

8:35 AM Changeset in webkit [77819] by Darin Adler

17 edits
2 adds in trunk/Source/WebCore

2011-02-06 Darin Adler <Darin Adler>

Reviewed by Antti Koivisto.

Add built-in decoder for UTF-8 for improved performance
https://bugs.webkit.org/show_bug.cgi?id=53898

Correct behavior is covered by existing tests.

Android.mk: Added TextCodecUTF8.
CMakeLists.txt: Ditto.
GNUmakefile.am: Ditto.
WebCore.gypi: Ditto.
WebCore.pro: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.

platform/text/TextCodecICU.cpp: Removed registration of UTF-8 since that's now handled by the built-in UTF-8 codec. (WebCore::TextCodecICU::registerEncodingNames): Renamed to remove the word "extended" since all codecs from ICU are now extended. (WebCore::TextCodecICU::registerCodecs): Ditto.
platform/text/TextCodecICU.h: Ditto.

platform/text/TextCodecUTF16.cpp: (WebCore::TextCodecUTF16::decode): Added a FIXME about missing error handling.

platform/text/TextCodecUTF8.cpp: Added.
platform/text/TextCodecUTF8.h: Added.

platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): Added TextCodecUTF8, and removed TextCodecICU, TextCodecBrew, and TextCodecWinCE. (WebCore::extendTextCodecMaps): Updated names for TextCodecICU and TextCodecWinCE.

platform/text/brew/TextCodecBrew.cpp: (WebCore::TextCodecBrew::registerEncodingNames): Renamed to remove the word "extended" since all codecs from Brew are now extended. (WebCore::TextCodecBrew::registerCodecs): Ditto.
platform/text/brew/TextCodecBrew.h: Ditto.

platform/text/gtk/TextCodecGtk.cpp: (WebCore::TextCodecGtk::registerBaseEncodingNames): Removed registration of UTF-8. It's questionable whether the other codecs here are really basic. If we think they qualify, then we should register them on other platforms, not just GTK. (WebCore::TextCodecGtk::registerBaseCodecs): Ditto.

platform/text/wince/TextCodecWinCE.cpp: (WebCore::getCodePage): Removed special case for UTF-8 since we no longer use this codec for UTF-8. (WebCore::TextCodecWinCE::registerEncodingNames): Renamed to remove the word "extended" since all codecs from WinCE are now extended. (WebCore::TextCodecWinCE::registerCodecs): Ditto.
platform/text/wince/TextCodecWinCE.h: Ditto.

8:35 AM Changeset in webkit [77818] by Martin Robinson

4 edits in trunk

2011-02-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] fast/history/history-subframe-with-name.html fails with GTK DRT
https://bugs.webkit.org/show_bug.cgi?id=44784

platform/gtk/Skipped: Unskip tests which are now passing.

2011-02-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] fast/history/history-subframe-with-name.html fails with GTK DRT
https://bugs.webkit.org/show_bug.cgi?id=44784

Call FrameLoader::loadURLIntoChildFrame on the parent frame's loader, not the child's.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame): Fix the call to FrameLoader::loadURLIntoChildFrame.

8:23 AM Changeset in webkit [77817] by mario@webkit.org

4 edits in trunk/Source

2011-02-07 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[Gtk] atk_text_get_caret_offset fails for list items
https://bugs.webkit.org/show_bug.cgi?id=53436

Consider list item markers when calculating the offset.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_caret_offset): Adjust the offset with the item marker's length for list items. (webkit_accessible_text_set_caret_offset): Replace usage of g_utf8_strlen() by calling to markerText.length().

2011-02-07 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[Gtk] atk_text_get_caret_offset fails for list items
https://bugs.webkit.org/show_bug.cgi?id=53436

Update unit test to check the fix for this bug.

tests/testatk.c: (testWebkitAtkCaretOffsets): Check that the caret offset returned match the value previously set.

8:03 AM Changeset in webkit [77816] by Adam Roben

2 edits in trunk/Source/WebKit2

Windows build fix after r77794

win/WebKit2.def: Export WebCore symbols used by WebKitTestRunner.

8:02 AM Changeset in webkit [77815] by Adam Roben

3 edits in trunk/Source/JavaScriptCore

Delete precompiled headers whenever any .vsprops file changes

Precompiled headers need to be rebuilt if, e.g., an ENABLE_* macro is changed in one of our
.vsprops files. Unfortunately, Visual Studio isn't smart enough to figure this out, so we
give it some assistance by deleting the precompiled headers whenever any .vsprops file
changes.

I also made some drive-by fixes while I was in the area.

Fixes <http://webkit.org/b/53826> react-to-vsprops-changes.py doesn't force precompiled
headers to be rebuilt, but should

Reviewed by David Kilzer.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Stop ignoring the

return code from react-to-vsprops-changes.py so we will notice when errors are introduced.
But skip the script entirely in production builds, where it is both unnecessary and can't
function correctly (due to not having the entire source tree available to it).

JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py:

(main): Removed an extra '*' in the glob for finding manifest files. The extra '*' was
leftover from before we rearranged WebKitBuild in r75138. Moved code to delete an old file
to the new delete_if_older_than function. Added code to delete any precompiled headers older
than the newest .vsprops file.
(delete_if_older_than): Added. Code came from main.

7:57 AM Changeset in webkit [77814] by yi.4.shen@nokia.com

4 edits in trunk

2011-02-07 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Fix LayoutTests/media/restore-from-page-cache.html
https://bugs.webkit.org/show_bug.cgi?id=53621

Unskip media/restore-from-page-cache.html for Qt.

platform/qt/Skipped:

2011-02-07 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Fix LayoutTests/media/restore-from-page-cache.html
https://bugs.webkit.org/show_bug.cgi?id=53621

Changed the networkState to MediaPlayer::Loaded when
MediaPlayerPrivateQt has enough data.

Test: media/restore-from-page-cache.html

platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::updateStates):

7:56 AM Changeset in webkit [77813] by Patrick Gansterer

2 edits in trunk/Source/WebKit/haiku

2011-02-07 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[Haiku] FrameLoaderClient calls loadURLInChildFrame on the child's frame loader
https://bugs.webkit.org/show_bug.cgi?id=53893

WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::createFrame): Use m_frame instead of childFrame.

7:31 AM Changeset in webkit [77812] by loislo@chromium.org

2 edits in trunk/LayoutTests

2011-02-07 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed.

Chromium: three tests temporary disabled for rebaseline after r77781

platform/chromium/test_expectations.txt:

7:18 AM Changeset in webkit [77811] by Patrick Gansterer

2 edits in trunk/Source/WebKit/efl

2011-02-07 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[EFL] FrameLoaderClient calls loadURLInChildFrame on the child's frame loader
https://bugs.webkit.org/show_bug.cgi?id=53892

ewk/ewk_frame.cpp: (ewk_frame_child_add): Use the loader of the core frame instead.

7:15 AM Changeset in webkit [77810] by podivilov@chromium.org

12 edits
1 add in trunk

2011-02-04 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement beautification of scripts inlined in html documents.
https://bugs.webkit.org/show_bug.cgi?id=52706

http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.setBreakpointInVisibleView):
inspector/debugger-breakpoints-not-activated-on-reload.html:
inspector/debugger-pause-on-breakpoint.html:

2011-01-31 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement beautification of scripts inlined in html documents.
https://bugs.webkit.org/show_bug.cgi?id=52706

To beautify scripts inlined in html, we need to cut individual scripts, beautify them using UglifyJS library, and
finally paste them back to html.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter): Implement formatting of scripts inlined in html. (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks): (WebInspector.ScriptFormatter.prototype.formatContent): (WebInspector.ScriptFormatter.prototype._splitContentIntoChunks): (WebInspector.ScriptFormatter.prototype._formatChunks.didFormat): (WebInspector.ScriptFormatter.prototype._formatChunks): (WebInspector.ScriptFormatter.prototype._buildContentFromChunks): (WebInspector.ScriptFormatter.prototype._formatScript.messageHandler): (WebInspector.ScriptFormatter.prototype._formatScript):
inspector/front-end/ScriptFormatterWorker.js: (onmessage): (buildMapping):
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrameContent): Use SourceFrameContent and FormattedSourceFrameContent to perform operations with line numbers.
inspector/front-end/SourceFrameContent.js: Added. (WebInspector.SourceFrameContent): Helper class, holds resource text and scripts layout (WebInspector.SourceFrameContent.prototype.get scriptRanges): (WebInspector.SourceFrameContent.prototype.locationToPosition): (WebInspector.SourceFrameContent.prototype.positionToLocation): (WebInspector.SourceFrameContent.prototype.scriptLocationForLineNumber): (WebInspector.SourceFrameContent.prototype.scriptLocationForRange): (WebInspector.SourceFrameContent.prototype.lineNumberToRange): (WebInspector.SourceFrameContent.prototype._intersectingScriptRange): (WebInspector): (WebInspector.FormattedSourceFrameContent): Helper class, holds original and formatted versions of resource and mapping between them. (WebInspector.FormattedSourceFrameContent.prototype.get text): (WebInspector.FormattedSourceFrameContent.prototype.originalLocationToFormattedLocation): (WebInspector.FormattedSourceFrameContent.prototype.scriptLocationForFormattedLineNumber): (WebInspector.FormattedSourceFrameContent.prototype._convertPosition):
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:

6:55 AM Changeset in webkit [77809] by Patrick Gansterer

2 edits in trunk/Source/WebKit/wx

2011-02-07 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[wx] FrameLoaderClient calls loadURLInChildFrame on the child's frame loader
https://bugs.webkit.org/show_bug.cgi?id=53895

WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::createFrame): Use m_frame instead of childFrame.

6:49 AM Changeset in webkit [77808] by loislo@chromium.org

1 edit
41 adds in trunk/LayoutTests

2011-02-07 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed.

Chromium: add explicit "Passed" expectations for the tests which have "failed" expectations in platfrom/mac
The problem was introduced at r77719.
I have to do that because platform/mac is in the list of baseline folders.
See 'Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py'.

platform/chromium/canvas/philip/tests/2d.drawImage.broken-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.fillStyle.parse.rgb-eof-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.fillStyle.parse.rgba-eof-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.imageData.put.wrongtype-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.line.cap.closed-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.line.join.parallel-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.line.miter.lineedge-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.path.rect.winding-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.pattern.image.broken-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.pattern.image.incomplete.empty-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.pattern.image.incomplete.omitted-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.text.draw.baseline.bottom-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.text.draw.baseline.hanging-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.text.draw.baseline.middle-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.text.draw.baseline.top-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.end-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.nonspace-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.other-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.space-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.start-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.text.font.parse.basic-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.text.font.parse.complex-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.text.font.parse.invalid-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.text.font.parse.system-expected.txt: Added.
platform/chromium/canvas/philip/tests/2d.text.measure.width.space-expected.txt: Added.

5:21 AM Changeset in webkit [77807] by Nikolas Zimmermann

208 edits in trunk/LayoutTests

2011-02-07 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448

Update Snow Leopard SVG pixel test baseline after r77485.

platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.png:
platform/mac/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png:

...

5:10 AM Changeset in webkit [77806] by Nikolas Zimmermann

131 edits in trunk/LayoutTests

2011-02-07 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448

Update Snow Leopard SVG pixel test baseline after r77485.

platform/mac/svg/custom/js-update-polygon-removal-expected.png:
platform/mac/svg/custom/js-update-style-expected.png:

...

5:05 AM Changeset in webkit [77805] by Nikolas Zimmermann

73 edits in trunk/LayoutTests

2011-02-07 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448

Update Snow Leopard SVG pixel test baseline after r77485.

platform/mac/svg/custom/class-baseValue-expected.png:
platform/mac/svg/custom/class-selector-expected.png:

...

4:59 AM Changeset in webkit [77804] by Nikolas Zimmermann

91 edits in trunk/LayoutTests

2011-02-07 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448

Update Snow Leopard SVG pixel test baseline after r77485.

platform/mac/svg/batik/paints/gradientLimit-expected.png:
platform/mac/svg/batik/paints/patternRegionA-expected.png:

...

3:56 AM Changeset in webkit [77803] by alex

2 edits
3 adds in trunk/LayoutTests

2011-02-07 Alejandro G. Castro <alex@igalia.com>

Unreviewed, added new results for the slider-thumb-drag-release
test and removed use-infinite-recursion.svg from skipped, required
after r77778.

platform/gtk/Skipped:
platform/gtk/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
platform/gtk/fast/repaint/slider-thumb-drag-release-expected.png: Added.
platform/gtk/fast/repaint/slider-thumb-drag-release-expected.txt: Added.

3:46 AM Changeset in webkit [77802] by apavlov@chromium.org

1 edit
3 moves
1 add in trunk/Websites/webkit.org

2011-02-07 Alexander Pavlov <apavlov@chromium.org>

Unreviewed. Add Web Inspector warning 10x10 PNG, move files from r77801 into the inspector/ directory.

blog-files/inspector/css_as_authored.png: Renamed from Websites/webkit.org/blog-files/inspector-css-as-authored.png.
blog-files/inspector/css_autocomplete.png: Renamed from Websites/webkit.org/blog-files/inspector-css-autocomplete.png.
blog-files/inspector/css_unknown_properties.png: Renamed from Websites/webkit.org/blog-files/inspector-unknown-css-properties.png.
blog-files/inspector/warning_10x10.png: Added.

3:27 AM Changeset in webkit [77801] by apavlov@chromium.org

1 edit
3 adds in trunk/Websites/webkit.org

2011-02-07 Alexander Pavlov <apavlov@chromium.org>

Unreviewed. Add Web Inspector style editing screenshots.

blog-files/inspector-css-as-authored.png: Added.
blog-files/inspector-css-autocomplete.png: Added.
blog-files/inspector-unknown-css-properties.png: Added.

3:26 AM Changeset in webkit [77800] by pfeldman@chromium.org

7 edits in trunk/Source/WebCore

2011-02-07 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: "Reveal in elements panel" does not always work.
https://bugs.webkit.org/show_bug.cgi?id=53775

inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView):
inspector/front-end/ContextMenu.js: (WebInspector.ContextMenu.prototype.show):
inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.switchToAndFocus):
inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement): (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.update): (WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired):
inspector/front-end/inspector.js: (WebInspector.cancelSearch):

3:24 AM Changeset in webkit [77799] by abarth@webkit.org

5 edits in trunk

2011-02-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Relative .. in URL paths shouldn't skip adjacent / characters
https://bugs.webkit.org/show_bug.cgi?id=53907

Add some more test cases.

fast/url/path-expected.txt:
fast/url/script-tests/path.js:

2011-02-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Relative .. in URL paths shouldn't skip adjacent / characters
https://bugs.webkit.org/show_bug.cgi?id=53907

Our new behavior matches Firefox, Chrome, and IE.

platform/KURL.cpp: (WebCore::copyPathRemovingDots):

3:16 AM Changeset in webkit [77798] by Csaba Osztrogonác

2 edits in trunk/Tools

Unreviewed.

[Qt][WK2] Buildfix after r77794.

WebKitTestRunner does not block remote resources or complain about them
https://bugs.webkit.org/show_bug.cgi?id=42139
<rdar://problem/8183942>

WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Add missing includepaths.

3:01 AM Changeset in webkit [77797] by mjs@apple.com

2 edits in trunk/Tools

Not reviewed.

More bot appeasement.

WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

2:47 AM Changeset in webkit [77796] by mjs@apple.com

2 edits in trunk/Tools

Not reviewed.

Remove accidental references to directories on my laptop.

WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

1:59 AM Changeset in webkit [77795] by pfeldman@chromium.org

2 edits in branches/chromium/648/Source/WebCore/inspector/front-end

Merge 76517 - 2011-01-24 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] AppCache view on resources panel is broken.
https://bugs.webkit.org/show_bug.cgi?id=53002

inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView.prototype._update):
inspector/front-end/DOMAgent.js: (WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync):

TBR=podivilov@chromium.org
Review URL: http://codereview.chromium.org/6368125

1:47 AM Changeset in webkit [77794] by mjs@apple.com

8 edits in trunk

2011-02-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Antti Koivisto.

WebKitTestRunner does not block remote resources or complain about them
https://bugs.webkit.org/show_bug.cgi?id=42139
<rdar://problem/8183942>

Configurations/WebCore.xcconfig: Allow WebKitTestRunner to link WebCore.
WebCore.exp.in: Export a handful of KURL symbols.

2011-02-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Antti Koivisto.

WebKitTestRunner does not block remote resources or complain about them
https://bugs.webkit.org/show_bug.cgi?id=42139
<rdar://problem/8183942>

platform/mac-wk2/Skipped: Unskip formerly skipped tests.

2011-02-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Antti Koivisto.

WebKitTestRunner does not block remote resources or complain about them
https://bugs.webkit.org/show_bug.cgi?id=42139
<rdar://problem/8183942>

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::willSendRequestForFrame): Implement the required checks (using KURL, to avoid need to invent a whole URL API).
WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Link WebCore directly to get at KURL symbols.

1:31 AM Changeset in webkit [77793] by mjs@apple.com

4 edits in trunk/Source/WebKit2

2011-02-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Antti Koivisto.

Add WKURLRequestCopyURL API (needed for tests and also generally useful)
https://bugs.webkit.org/show_bug.cgi?id=53909

Shared/API/c/WKURLRequest.cpp: (WKURLRequestCopyURL):
Shared/API/c/WKURLRequest.h:
Shared/WebURLRequest.h: (WebKit::WebURLRequest::url):

12:54 AM Changeset in webkit [77792] by Antti Koivisto

2 edits in trunk/Source/JavaScriptCore

Not reviewed.

ASSERTS_DISABLED -> ASSERT_DISABLED

wtf/BloomFilter.h:

Feb 6, 2011:

11:20 PM Changeset in webkit [77791] by mjs@apple.com

2 edits in trunk/Tools

2011-02-06 Maciej Stachowiak <mjs@apple.com>

Reviewed by Daniel Bates.

Add WebKit2 bot to list of expected builders in Python regression test results.
https://bugs.webkit.org/show_bug.cgi?id=53905

Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

10:49 PM Changeset in webkit [77790] by mjs@apple.com

2 edits in trunk/Tools

2011-02-06 Maciej Stachowiak <mjs@apple.com>

Reviewed by Ryosuke Niwa.

Update test expectations for new core builder
https://bugs.webkit.org/show_bug.cgi?id=53904

Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

10:20 PM Changeset in webkit [77789] by mjs@apple.com

2 edits in trunk/Tools

2011-02-06 Maciej Stachowiak <mjs@apple.com>

Reviewed by David Levin.

Add WebKit2 test bot to core builders
https://bugs.webkit.org/show_bug.cgi?id=53901

Scripts/webkitpy/common/net/buildbot/buildbot.py:

9:47 PM Changeset in webkit [77788] by rniwa@webkit.org

2 edits in trunk/Tools

2011-02-06 Ryosuke Niwa <rniwa@webkit.org>

Another unreviewed Chromium build fix.

DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::pathToLocalResource):

9:29 PM Changeset in webkit [77787] by rniwa@webkit.org

4 edits in trunk

2011-02-06 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium build fix.

DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::pathToLocalResource):

2011-02-06 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; speculative Qt build fix.

WebKit2.pro:

9:19 PM Changeset in webkit [77786] by rniwa@webkit.org

2 edits in trunk/Source/JavaScriptCore

2011-02-06 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; speculative Qt build fix.

JavaScriptCore.pro:

9:01 PM Changeset in webkit [77785] by rniwa@webkit.org

44 edits
3 deletes in trunk

2011-02-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867

DumpRenderTree/chromium/ImageDiff.cpp: (Image::craeteFromStdin): Call adoptArrayPtr.

2011-02-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867

Removed LOOSE_OWN_ARRAY_PTR and OwnArrayPtr<T>::set. Replaced all calls to OwnArrayPtr::set
and loose instantiation of OwnArrayPtr by calls to operator= and adoptArrayPtr. Also removed
OwnArrayPtrCommon.h since PassOwnArrayPtr.h needs to include OwnArrayPtr.h and there is
no point in putting deleteOwnedArrayPtr into a separate header.

Note: if this patch breaks build, the code is either instiantiating OwnArrayPtr
without calling adoptArrayPtr or calling set on ArrayOwnPtr instead of operator=.

No tests are added since this is a refactoring.

API/JSStringRefCF.cpp: (JSStringCreateWithCFString): Calls adoptArrayPtr.
GNUmakefile.am: Removed OwnArrayPtrCommon.h
JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
runtime/Arguments.cpp: (JSC::Arguments::deleteProperty): Calls adoptArrayPtr.
runtime/Arguments.h: (JSC::Arguments::copyRegisters): Ditto.
runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::JSPropertyNameIterator): Ditto.
runtime/JSVariableObject.h: (JSC::JSVariableObject::setRegisters): Calls operator= instead of set.
runtime/StructureChain.cpp: (JSC::StructureChain::StructureChain): Ditto.
wtf/CMakeLists.txt:
wtf/DateMath.h: (JSC::GregorianDateTime::GregorianDateTime): No longer instnatiates OwnArrayPtr with a null pointer.
wtf/OwnArrayPtr.h:
wtf/OwnArrayPtrCommon.h: Removed.
wtf/PassOwnArrayPtr.h: No longer includes OwnArrayCommon.h (WTF::deleteOwnedArrayPtr): Moved from OwnArrayPtrCommon.h

2011-02-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867

ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Removed.

2011-02-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867

WebHistory.cpp: (WebHistory::orderedLastVisitedDays): Calls adoptArrayPtr.
WebPreferences.cpp: (WebPreferences::copyWebKitPreferencesToCFPreferences): Ditto.

2011-02-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867

ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Removed.
bindings/v8/NPV8Object.cpp: (WebCore::createValueListFromVariantArgs): Returns PassOwnArrayPtr<v8::Handle<v8::Value>> instead of v8::Handle<v8::Value>*. (_NPN_Invoke): Calls createValueListFromVariantArgs. (_NPN_InvokeDefault): createValueListFromVariantArgs. (_NPN_Construct): createValueListFromVariantArgs.
bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call): Calls adoptArrayPtr. (WebCore::ScriptFunctionCall::construct): Ditto. (WebCore::ScriptCallback::call):
bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext): Ditto.
bindings/v8/V8NPObject.cpp: (WebCore::npObjectInvokeImpl): Ditto
bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::acceptNode): Ditto,
html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::parseMappedAttribute): Calls newCoordsArray.
html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute): Calls newLengthArray.
html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getAttachedShaders): Calls adoptArraYptr. (WebCore::WebGLRenderingContext::simulateVertexAttrib0): Ditto. (WebCore::WebGLRenderingContext::LRUImageBufferCache::LRUImageBufferCache): Dito.
platform/Length.cpp: (WebCore::newCoordsArray): Returns PassOwnArrayPtr<Length> instead of Length*. (WebCore::newLengthArray): Returns PassOwnArrayPtr<Length> instead of Length*.
platform/Length.h: Prototype changes.
platform/graphics/ANGLEWebKitBridge.cpp: (WebCore::ANGLEWebKitBridge::validateShaderSource): Calls adoptArrayPtr.
platform/graphics/ca/win/CACFLayerTreeHost.cpp: (WebCore::getDirtyRects): Ditto.
platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::getNormalizedTextRun): Ditto.
platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::glyphsToAdvances): Ditto. (WebCore::canRender): Ditto.
platform/graphics/gpu/Texture.cpp: (WebCore::Texture::updateSubRect): Ditto.
platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): Ditto.
platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::readbackHardwareToSoftware): Ditto.
platform/graphics/wince/SharedBitmap.cpp: (WebCore::SharedBitmap::to16bit): Ditto.
platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::getContextMenuItems): Ditto.
platform/win/LoggingWin.cpp: (WebCore::initializeWithUserDefault): Ditto.
plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::fetchInfo): Ditto.

2011-02-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867

Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp: (WebKit::NetscapePluginModule::getPluginInfo): Calls adoptArrayPtr.

8:54 PM Changeset in webkit [77784] by tkent@chromium.org

2 edits in trunk/Source/WebCore

2011-02-06 Kent Tamura <tkent@chromium.org>

Unreviewed.

WebCore.xcodeproj/project.pbxproj: Run sort-xcode-project-file.

8:08 PM Changeset in webkit [77783] by Patrick Gansterer

2 edits in trunk/Source/WebKit/wince

2011-02-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Martin Robinson.

[WINCE] FrameLoaderClient calls loadURLInChildFrame on the child's frame loader
https://bugs.webkit.org/show_bug.cgi?id=53896

WebView.cpp: (WebView::createFrame): Use coreFrame instead of childFrame.

6:20 PM Changeset in webkit [77782] by morrita@google.com

2 edits in trunk/LayoutTests

2011-02-06 MORITA Hajime <morrita@google.com>

Unreviewed, unskip the html5lib test again which fails for another reason. (See Bug 53030)

platform/qt/Skipped:

5:40 PM Changeset in webkit [77781] by morrita@google.com

13 edits in trunk

2011-02-06 Dominic Cooney <dominicc@google.com>

Reviewed by Dimitri Glazkov.

Convert <keygen> option elements to a shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=51379

html5lib/runner-expected.txt: Two more tests pass.
platform/mac/fast/html/keygen-expected.txt: Shadow render tree.
platform/mac/fast/invalid/residual-style-expected.txt:

2011-02-03 Dominic Cooney <dominicc@google.com>

Reviewed by Dimitri Glazkov.

Convert <keygen> option elements to a shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=51379

Covered by existing tests e.g. fast/html/keygen.html,
html5lib/runner.html, etc.

css/html.css: (form): Cleanup. (keygen, select): Border radii should match so focus ring looks good. (keygen::-webkit-keygen-select): No margin on the shadow element. (select): Hoisting border radius to keygen, select rule.
dom/SelectElement.cpp: (WebCore::toSelectElement): keygen is no longer a select element.
html/HTMLKeygenElement.cpp: Implements keygen shadow. (WebCore::KeygenSelectElement::create): (WebCore::KeygenSelectElement::shadowPseudoId): (WebCore::KeygenSelectElement::KeygenSelectElement): (WebCore::HTMLKeygenElement::HTMLKeygenElement): (WebCore::HTMLKeygenElement::parseMappedAttribute): (WebCore::HTMLKeygenElement::appendFormData): (WebCore::HTMLKeygenElement::formControlType): (WebCore::HTMLKeygenElement::reset): (WebCore::HTMLKeygenElement::selectShadow):
html/HTMLKeygenElement.h: keygen is no longer a select on C++ side. (WebCore::HTMLKeygenElement::canStartSelection): (WebCore::HTMLKeygenElement::isEnumeratable): (WebCore::HTMLKeygenElement::isResettable):
html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::ownerSelectElement): Only owned by selects.
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): Only 'select' tag name.

5:00 PM Changeset in webkit [77780] by commit-queue@webkit.org

1 edit
5 adds in trunk/Tools

2011-02-06 James Kozianski <koz@chromium.org>

Reviewed by Ojan Vafai.

Add classes for representing test outputs.
https://bugs.webkit.org/show_bug.cgi?id=52136

These classes will make it easier to write scripts that deal with test
outputs such as rebaselining and deduping scripts. The intent is that
eventually we will be have buildbot return TestOutputs for a
particular build which can be compared with TestOutputs derived from a
local LayoutTests directory.

Scripts/webkitpy/common/net/testoutput.py: Added.
Scripts/webkitpy/common/net/testoutput_unittest.py: Added.
Scripts/webkitpy/common/net/testoutputset.py: Added.
Scripts/webkitpy/common/net/testoutputset_unittest.py: Added.
Scripts/webkitpy/common/system/zip_mock.py: Added.

3:48 PM Changeset in webkit [77779] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-02-06 Benjamin Poulain <ikipou@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix coding style errors in ClipboardQt.h
https://bugs.webkit.org/show_bug.cgi?id=43520

Fix coding style: order of header and indentation.

platform/qt/ClipboardQt.h: (WebCore::ClipboardQt::create): (WebCore::ClipboardQt::clipboardData): (WebCore::ClipboardQt::invalidateWritableData):

2:16 PM Changeset in webkit [77778] by Patrick Gansterer

1 edit
6 deletes in trunk/LayoutTests

2011-02-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Oliver Hunt.

Remove empty svg test
https://bugs.webkit.org/show_bug.cgi?id=53887

This files are empty. Empty tests are pretty useless.

platform/chromium-win/svg/custom/use-infinite-recursion-expected.png: Removed.
platform/mac/svg/custom/use-infinite-recursion-expected.checksum: Removed.
platform/mac/svg/custom/use-infinite-recursion-expected.png: Removed.
platform/mac/svg/custom/use-infinite-recursion-expected.txt: Removed.
platform/qt/svg/custom/use-infinite-recursion-expected.txt: Removed.
svg/custom/use-infinite-recursion.svg: Removed.

12:43 PM Changeset in webkit [77777] by Antti Koivisto

8 edits
2 adds in trunk/Source

Use bloom filter for descendant selector filtering
https://bugs.webkit.org/show_bug.cgi?id=53880

Reviewed by Maciej Stachowiak.

Source/JavaScriptCore:

Implement a bloom filter with k=2 and 8 bit counting.

GNUmakefile.am:
JavaScriptCore.gypi:
JavaScriptCore.vcproj/WTF/WTF.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
wtf/BloomFilter.h: Added.

(WTF::BloomFilter::maximumCount):
(WTF::BloomFilter::BloomFilter):
(WTF::BloomFilter::mayContain):
(WTF::BloomFilter::add):
(WTF::BloomFilter::remove):
(WTF::BloomFilter::firstSlot):
(WTF::BloomFilter::secondSlot):
(WTF::::add):
(WTF::::remove):
(WTF::::clear):
(WTF::::likelyEmpty):
(WTF::::isClear):

Source/WebCore:

Bloom filter is faster than a hash set in this kind of use.

Shark thinks this speeds up style matching by ~30% on sites
with lots of descendant selectors.

ForwardingHeaders/wtf/BloomFilter.h: Added.
css/CSSStyleSelector.cpp:

(WebCore::collectElementIdentifierHashes):
(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):
(WebCore::CSSStyleSelector::fastRejectSelector):
(WebCore::RuleData::collectDescendantSelectorIdentifierHashes):

css/CSSStyleSelector.h:

12:05 PM Changeset in webkit [77776] by mjs@apple.com

2 edits in trunk/Source/WebCore

2011-02-06 Maciej Stachowiak <mjs@apple.com>

Reviewed by Antti Koivisto.

media/video-document-types.html sometimes crashes the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=53884

No new tests. Already covered by media/video-document-types.html

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::userCancelledLoad): Stop the load timer when cancelling the load.

10:52 AM Changeset in webkit [77775] by Patrick Gansterer

15 edits in trunk/Source/WebCore

2011-02-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WIN] Use WCHAR instead of TCHAR
https://bugs.webkit.org/show_bug.cgi?id=53863

We always use the UNICODE versions of windows functions, so
the usage of TCHAR makes no sense and mixing them is bad style.

platform/graphics/win/IconWin.cpp: (WebCore::Icon::createIconForFiles):
platform/graphics/win/QTMovie.cpp:
platform/graphics/win/QTMovieGWorld.cpp: (QTMovieGWorld::fullscreenWndProc): (QTMovieGWorld::enterFullscreen):
platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformInit):
platform/graphics/win/SimpleFontDataCairoWin.cpp:
platform/graphics/win/SimpleFontDataWin.cpp:
platform/graphics/wince/SimpleFontDataWinCE.cpp:
platform/win/BString.cpp:
platform/win/ClipboardWin.cpp: (WebCore::filesystemPathFromUrlOrTitle): (WebCore::createGlobalHDropContent): (WebCore::createGlobalImageFileDescriptor):
platform/win/ContextMenuWin.cpp:
platform/win/CursorWin.cpp: (WebCore::loadSharedCursor):
platform/win/FileChooserWin.cpp: (WebCore::FileChooser::basenameForWidth):
platform/win/PopupMenuWin.cpp: (WebCore::PopupMenuWin::popupClassName): (WebCore::PopupMenuWin::show):
platform/win/PopupMenuWin.h:

10:44 AM Changeset in webkit [77774] by Patrick Gansterer

9 edits in trunk/Source/WebCore

2011-02-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Replace FLT_MAX with std::numeric_limits
https://bugs.webkit.org/show_bug.cgi?id=53861

Also move EFL's userIdleTime from TemporaryLinkStubs into SystemTimeEfl.

html/NumberInputType.cpp:
html/parser/HTMLParserIdioms.cpp: (WebCore::parseToDoubleForNumberType):
platform/brew/SystemTimeBrew.cpp: (WebCore::userIdleTime):
platform/efl/SystemTimeEfl.cpp: (WebCore::userIdleTime):
platform/efl/TemporaryLinkStubs.cpp:
platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setupAnimation):
platform/win/SystemTimeWin.cpp: (WebCore::userIdleTime):
platform/wx/SystemTimeWx.cpp: (WebCore::userIdleTime):

10:39 AM Notes on Content Security Policies edited by abarth@webkit.org

(diff)

10:38 AM Notes on Content Security Policies created by abarth@webkit.org

10:31 AM Changeset in webkit [77773] by robert@webkit.org

2 edits in trunk/Source/WebKit/qt

2011-02-06 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Remove unnecessary QRect assignment
https://bugs.webkit.org/show_bug.cgi?id=53873

Api/qwebframe.cpp: (QWebFramePrivate::renderRelativeCoords):

10:18 AM Changeset in webkit [77772] by robert@webkit.org

4 edits in trunk

2011-02-06 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Clear page's groupName even when not in DRT
https://bugs.webkit.org/show_bug.cgi?id=53874

Matches behaviour of other ports.

WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::closeWindowSoon):

2011-02-06 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Clear page's groupName even when not in DRT
https://bugs.webkit.org/show_bug.cgi?id=53874

DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::windowCloseRequested):

9:47 AM Changeset in webkit [77771] by Patrick Gansterer

6 edits in trunk

2011-02-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Add dependencies for Visual Studio projects
https://bugs.webkit.org/show_bug.cgi?id=53773

Add a JavaScriptCore dependecy to WebCore, so CMake can
generate the correct build order for the solution.

CMakeLists.txt:

2011-02-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Add dependencies for Visual Studio projects
https://bugs.webkit.org/show_bug.cgi?id=53773

Add a WebCore dependecy to WebKit, so CMake can
generate the correct build order for the solution.

Remove JavaScriptCore dependecy, since WebCore already depends on it.

CMakeLists.txt:

2011-02-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Add dependencies for Visual Studio projects
https://bugs.webkit.org/show_bug.cgi?id=53773

Add a WebKit dependecy to WinCELauncher, so CMake can
generate the correct build order for the solution.

CMakeListsWinCE.txt:

9:14 AM Changeset in webkit [77770] by Patrick Gansterer

2 edits in trunk/Source/WebCore

2011-02-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Unify ENABLE_SVG sections
https://bugs.webkit.org/show_bug.cgi?id=53778

CMakeLists.txt:

9:08 AM Changeset in webkit [77769] by Martin Robinson

2 edits in trunk/LayoutTests

2011-02-06 Martin Robinson <mrobinson@igalia.com>

Reclassify a failing test and unskip another which should be passing now.

platform/gtk/Skipped: Update the skipped list.

8:22 AM Changeset in webkit [77768] by andreas.kling@nokia.com

5 edits in trunk/Source/WebCore

2011-02-06 Andreas Kling <kling@webkit.org>

Reviewed by Dirk Schulze.

Refactor Font::normalizeSpaces() to avoid an extra String copy.
https://bugs.webkit.org/show_bug.cgi?id=53871

Have normalizeSpaces() take UChar*,length arguments instead of a
String, since all call sites were creating temporaries from these
components anyway.

Font::normalizeSpaces() now always makes 1 String copy,
instead of 1 in the best case and 2 in the worst case.

platform/graphics/Font.cpp: (WebCore::Font::normalizeSpaces):
platform/graphics/Font.h:
platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon): (WebCore::Font::floatWidthForSimpleText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForSimpleText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForSimpleText): (WebCore::Font::selectionRectForComplexText):
svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk):

7:19 AM Changeset in webkit [77767] by andreas.kling@nokia.com

4 edits in trunk/Tools

2011-02-06 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt] MiniBrowser: Clean up handling of titleChanged() signal
https://bugs.webkit.org/show_bug.cgi?id=53869

MiniBrowser/qt/BrowserView.cpp: (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
MiniBrowser/qt/BrowserWindow.h:

6:35 AM Changeset in webkit [77766] by andreas.kling@nokia.com

2 edits in trunk/Source/WebCore

2011-02-06 Andreas Kling <kling@webkit.org>

Reviewed by Dirk Schulze.

Fix potential buffer overrun in SVGTextRunWalker::walk()
https://bugs.webkit.org/show_bug.cgi?id=53870

A new String was created from a UChar* with a 'length' argument
that could be greater than the number of UChars available.

svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk):

5:23 AM Changeset in webkit [77765] by commit-queue@webkit.org

11 edits in trunk/Source/WebKit2

2011-02-06 Benjamin Poulain <ikipou@gmail.com>

Reviewed by Andreas Kling.

[Qt] WebKit does not build on Mac with WebKit 2
https://bugs.webkit.org/show_bug.cgi?id=53380

Platform/CoreIPC/qt/ConnectionQt.cpp: Use fcntl() to set close on exec so we do not rely on recent kernel. (CoreIPC::Connection::readyReadHandler):
Platform/qt/SharedMemoryQt.cpp: ditto (WebKit::SharedMemory::create): (WebKit::SharedMemory::createHandle):
UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Guard prctl() since it is a Linux specific function. (WebKit::QtWebProcess::setupChildProcess):
UIProcess/DrawingAreaProxy.h: Differentiate between building on Mac and the Mac port.
UIProcess/DrawingAreaProxyImpl.cpp: ditto
UIProcess/WebPageProxy.cpp: ditto (WebKit::WebPageProxy::didReceiveMessage):
WebProcess/WebPage/DrawingArea.cpp: ditto (WebKit::DrawingArea::create):
WebProcess/WebPage/DrawingArea.h:
WebProcess/WebPage/DrawingAreaImpl.cpp: ditto
WebProcess/WebPage/WebPage.cpp: ditto (WebKit::WebPage::didReceiveMessage):

2:46 AM Changeset in webkit [77764] by robert@webkit.org

2 edits in trunk/LayoutTests

2011-02-06 Robert Hogan <robert@webkit.org>

Unreviewed, skip failing test on Qt bot.

[Qt] fast/notifications/notifications-document-close-crash.html fails after r77738
https://bugs.webkit.org/show_bug.cgi?id=53868

platform/qt/Skipped: Skip fast/notifications/notifications-document-close-crash.html

2:35 AM Changeset in webkit [77763] by mjs@apple.com

8 edits in trunk

2011-02-06 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
https://bugs.webkit.org/show_bug.cgi?id=42690
<rdar://problem/8213851>

platform/mac-wk2/Skipped: Unskip tests that now pass, except for the ones that mysteriously fail.

2011-02-06 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
https://bugs.webkit.org/show_bug.cgi?id=42690
<rdar://problem/8213851>

WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::willSendRequestForFrame):
WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController):
WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::willSendRequestReturnsNull): (WTR::LayoutTestController::setWillSendRequestReturnsNull):

Feb 5, 2011:

10:05 PM Changeset in webkit [77762] by mrowe@apple.com

5 edits in branches/safari-533.20-branch

Versioning.

10:05 PM Changeset in webkit [77761] by mrowe@apple.com

1 copy in tags/Safari-533.20.25

New tag.

10:00 PM Changeset in webkit [77760] by mrowe@apple.com

1 edit in branches/safari-533.20-branch/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp

Build fix.

9:24 PM Changeset in webkit [77759] by mjs@apple.com

2 edits in trunk/Source/WebKit2

2011-02-05 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

REGRESSION: New drawing area is causing some WebProcess crashes in layout tests
https://bugs.webkit.org/show_bug.cgi?id=53865
<rdar://problem/8963148>

WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): Handle the case where this is called repeatedly without exiting accelerated composting mode first. (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Handle the case of being called more than once.

9:05 PM Changeset in webkit [77758] by Dimitri Glazkov

1 edit
2 adds in trunk/LayoutTests

2011-02-05 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Add baselines for the test added in r77690.

platform/chromium-mac/media/video-frame-accurate-seek-expected.checksum: Added.
platform/chromium-mac/media/video-frame-accurate-seek-expected.png: Added.

6:58 PM Changeset in webkit [77757] by Dimitri Glazkov

2 edits in trunk/LayoutTests

2011-02-05 Dimitri Glazkov <Dimitri Glazkov>

Remove passing canvas tests from expectations.

platform/chromium/test_expectations.txt: Removed passing tests.

6:44 PM Changeset in webkit [77756] by Dimitri Glazkov

2 edits in trunk/LayoutTests

2011-02-05 Dimitri Glazkov <Dimitri Glazkov>

Remove passing tests whose results match mac/ and mac-leopard.

platform/chromium/test_expectations.txt: Removed passing tests.

6:07 PM Changeset in webkit [77755] by abarth@webkit.org

8 edits in trunk/Source/WebCore

2011-02-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove unused parameter related to XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=53862

WebCore.exp.in:
bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScript): (WebCore::ScriptController::executeIfJavaScriptURL):
bindings/ScriptControllerBase.h:
bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::evaluate): (WebCore::ScriptController::executeScriptInWorld):
bindings/js/ScriptController.h:
bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
bindings/v8/ScriptController.h:

4:54 PM Changeset in webkit [77754] by Dimitri Glazkov

1 edit
125 deletes in trunk/LayoutTests

2011-02-05 Dimitri Glazkov <Dimitri Glazkov>

Remove results for failing SVG tests. I will add the new ones after the
bots tell me which ones aren't matching mac/ or mac-leopard/.

3:02 PM Changeset in webkit [77753] by abarth@webkit.org

2 edits in trunk/Source/WebCore

2011-02-05 Adam Barth <abarth@webkit.org>

Fix Qt build.

WebCore.pro:

2:55 PM Changeset in webkit [77752] by abarth@webkit.org

20 edits
2 deletes in trunk/Source/WebCore

2011-02-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Delete XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=53859

The job of the XSSAuditor is now done by the XSSFilter. In the future,
we might rename XSSFilter to XSSAuditor.

Android.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
bindings/ScriptControllerBase.h:
bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluateInWorld):
bindings/js/ScriptController.h:
bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluate):
bindings/v8/ScriptController.h:
bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
dom/Document.cpp: (WebCore::Document::implicitOpen): (WebCore::Document::processBaseElement):
dom/ScriptableDocumentParser.cpp: (WebCore::ScriptableDocumentParser::ScriptableDocumentParser):
dom/ScriptableDocumentParser.h:
html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::shouldLoadExternalScriptFromSrc):
loader/SubframeLoader.cpp: (WebCore::SubframeLoader::requestObject): (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
page/XSSAuditor.cpp: Removed.
page/XSSAuditor.h: Removed.

2:28 PM Changeset in webkit [77751] by andersca@apple.com

18 edits in trunk/Source

2011-02-05 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Need a way to resize and scroll the page at the same time
https://bugs.webkit.org/show_bug.cgi?id=53814
<rdar://problem/8498008>

Export a function needed by WebKit2.

WebCore.exp.in:

2011-02-05 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Need a way to resize and scroll the page at the same time
https://bugs.webkit.org/show_bug.cgi?id=53814
<rdar://problem/8498008>

Add -[WKView setFrame:andScrollBy:].

UIProcess/API/mac/WKView.h:
UIProcess/API/mac/WKView.mm: (-[WKView setFrame:andScrollBy:]): Stash away the scroll offset and call setFrame:.

(-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaInfo::]):
(-[WKView _setDrawingAreaSize:]):

UIProcess/API/qt/qwkpage.cpp: (QWKPage::setViewportSize): DrawingAreaProxy::setSize now takes a scroll offset.

UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::setSize): This now takes a scroll offset and stores it in m_scrollOffset.

UIProcess/DrawingAreaProxy.h:
UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::sendSetSize): Send along the scroll offset and set it back to zero.

UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::didSetSize):
UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::didSetSize):
UIProcess/win/WebView.cpp: (WebKit::WebView::onSizeEvent): (WebKit::WebView::switchToDrawingAreaTypeIfNecessary): DrawingAreaProxy::setSize now takes a scroll offset.

WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::setSize): Add a scrollOffset parameter.

WebProcess/WebPage/DrawingArea.messages.in: Add a scroll offset parameter to the SetSize message.

WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setSize): Call WebPage::scrollMainFrameIfNotAtMaxScrollPosition.

WebProcess/WebPage/DrawingAreaImpl.h:
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::scrollMainFrameIfNotAtMaxScrollPosition): Compute a scroll offset and call setScrollPosition on the main frame view.

12:34 PM Changeset in webkit [77750] by Patrick Gansterer

6 edits in trunk/Source/WebCore

2011-02-05 Patrick Gansterer <Patrick Gansterer>

Reviewed by Alexey Proskuryakov.

Use Document::encoding() instead of DocumentWriter::encoding()
https://bugs.webkit.org/show_bug.cgi?id=53398

This change makes the code more readable, when a subresource
inherits the character encoding of the document.

dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
dom/ScriptElement.cpp: (WebCore::ScriptElement::scriptCharset):
html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestPreload):
platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::encodingFromAcceptCharset):

12:30 PM Changeset in webkit [77749] by Patrick Gansterer

7 edits
1 add in trunk/LayoutTests

2011-02-05 Patrick Gansterer <Patrick Gansterer>

Reviewed by Alexey Proskuryakov.

Add addition test for inherited encoding
https://bugs.webkit.org/show_bug.cgi?id=53398

Check if the right encoding is used, after document.charset was set.

fast/dom/Document/document-charset.html: Added doctype to make it pass in IE9 out of the box.
fast/encoding/css-charset-default-expected.txt:
fast/encoding/css-charset-default.xhtml:
fast/encoding/external-script-charset-expected.txt:
fast/encoding/external-script-charset-koi-8.js: Added.
fast/encoding/external-script-charset.js:
fast/encoding/external-script-charset.xhtml:

12:21 PM Changeset in webkit [77748] by abarth@webkit.org

6 edits
1 add in trunk/Source/WebCore

2011-02-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Introduce URLString to represent a canonicalized URL represented by a string
https://bugs.webkit.org/show_bug.cgi?id=53847

Instead of using String all over the codebase to represent a URL,
instead we should have a type to represent a canonicalized URL in the
form of a string. This patch introduces that type.

GNUmakefile.am:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
platform/KURL.cpp: (WebCore::KURL::KURL):
platform/KURL.h: (WebCore::KURL::urlString):

10:26 AM Changeset in webkit [77747] by Martin Robinson

2 edits in trunk/LayoutTests

2011-02-05 Martin Robinson <mrobinson@igalia.com>

JSC::Bindings m_rootObject->isValid() assert fails when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=53716

platform/gtk/Skipped: Skip a test hitting this assertion.

9:55 AM Changeset in webkit [77746] by robert@webkit.org

4 edits in trunk

2011-02-05 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Style widgets not rendering
https://bugs.webkit.org/show_bug.cgi?id=53849

platform/qt/Skipped: Unskip plugins/application-plugins-plugins-disabled.html

2011-02-05 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Style widgets not rendering
https://bugs.webkit.org/show_bug.cgi?id=53849

html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::hasValidClassId): x-qt-styled-widget is a valid class id too

9:19 AM Changeset in webkit [77745] by commit-queue@webkit.org

2 edits in trunk/Tools

2011-02-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77720.
http://trac.webkit.org/changeset/77720
https://bugs.webkit.org/show_bug.cgi?id=53854

"Broke nrwt on Chromium win." (Requested by dglazkov|away on
#webkit).

Scripts/webkitpy/common/system/executive.py:

5:00 AM Changeset in webkit [77744] by Nikolas Zimmermann

168 edits in trunk/LayoutTests

2011-02-04 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448

Update Snow Leopard SVG pixel test baseline after r77485.

platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:

...

4:48 AM Changeset in webkit [77743] by eric@webkit.org

3 edits in trunk/LayoutTests

2011-02-05 Eric Seidel <eric@webkit.org>

Unreviewed.

Safari should lowercase schemes in cannonicalized urls to match every other browser
https://bugs.webkit.org/show_bug.cgi?id=53848

Checkin results I forgot to update in my previous commit. All progressions.

fast/dom/anchor-origin-expected.txt:
http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:

3:52 AM Changeset in webkit [77742] by jochen@chromium.org

6 edits in trunk/Source/WebCore

2011-02-05 Jochen Eisinger <jochen@chromium.org>

Reviewed by Adam Barth.

Add ContentSecurityPolicy object to Document and pass the X-WebKit-CSP header from the MainResourceLoader.
https://bugs.webkit.org/show_bug.cgi?id=53685

WebCore.xcodeproj/project.pbxproj:
dom/Document.h: (WebCore::Document::contentSecurityPolicy):
loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse):
page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::didReceiveHeader):
page/ContentSecurityPolicy.h:

3:43 AM Changeset in webkit [77741] by eric@webkit.org

8 edits in trunk

2011-02-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Safari should lowercase schemes in cannonicalized urls to match every other browser
https://bugs.webkit.org/show_bug.cgi?id=53848

Update our results now that we pass more tests.

fast/url/file-expected.txt:
fast/url/file-http-base-expected.txt:
fast/url/path-url-expected.txt:
fast/url/relative-expected.txt:
fast/url/scheme-expected.txt:

2011-02-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Safari should lowercase schemes in cannonicalized urls to match every other browser
https://bugs.webkit.org/show_bug.cgi?id=53848

We're clearly the odd man out here. See results from every browser at:
https://github.com/abarth/url-spec/blob/master/tests/gurl-results/by-browser.txt

platform/KURL.cpp: (WebCore::KURL::parse):
- Just lowercase the scheme when copying.

3:23 AM Changeset in webkit [77740] by Antti Koivisto

4 edits in trunk/Source/WebCore

Optimize matching of descendant selectors
https://bugs.webkit.org/show_bug.cgi?id=49876
<rdar://problem/8772822>

Reviewed by Dave Hyatt.

During style recalculation, maintain a filter of tags, ids and classes seen in ancestor elements.
Use the filter to quickly reject descendant and child selectors when doing style matching.

This speeds up style recalculations 3-6x on many major web sites.

css/CSSStyleSelector.cpp:

(WebCore::RuleData::RuleData):
(WebCore::RuleData::descendantSelectorIdentifierHashes):
(WebCore::collectElementIdentifiers):
(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):
(WebCore::CSSStyleSelector::fastRejectSelector):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::RuleData::collectDescendantSelectorIdentifierHashes):

css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::ParentStackFrame::ParentStackFrame):

dom/Element.cpp:

(WebCore::StyleSelectorParentPusher::StyleSelectorParentPusher):
(WebCore::StyleSelectorParentPusher::push):
(WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
(WebCore::Element::attach):
(WebCore::Element::recalcStyle):

3:12 AM Changeset in webkit [77739] by eric@webkit.org

1 edit
3 adds in trunk/PerformanceTests

2011-02-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add performance tests for URL parsing
https://bugs.webkit.org/show_bug.cgi?id=53845

The final-url-en URL corpus is from:
http://corpus.leeds.ac.uk/internet.html

There are also other language corpuses which we may want to use in the future.

The usage instructions were as follows:
"URL lists and other resources: you can freely use them in your research
provided that you supply a link to this website: http://corpus.leeds.ac.uk/."
Done.

Parser/simple-url.html: Added. On my machine: Firefox: 255ms TOT WebKit: 378ms Chrome: 286ms Opera: 2830ms (no, that is not a typo)
Parser/url-parser.html: Added. Firefox: 381ms TOT WebKit: 216ms Chrome: 131ms Opera: 1383ms (again, not a typo)
Parser/resources/final-url-en: Added.

2:37 AM Changeset in webkit [77738] by Nate Chapin

5 edits in trunk/Source/WebCore

2011-02-05 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Refactor: NotificationCenter shouldn't hold its own copy of the ScriptExecutionContext*
when it inherits one from ActiveDOMObject.
https://bugs.webkit.org/show_bug.cgi?id=53815

bindings/js/JSDesktopNotificationsCustom.cpp: (WebCore::JSNotificationCenter::requestPermission):
bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::V8NotificationCenter::requestPermissionCallback):
notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::NotificationCenter): (WebCore::NotificationCenter::checkPermission): (WebCore::NotificationCenter::requestPermission): (WebCore::NotificationCenter::disconnectFrame):
notifications/NotificationCenter.h: (WebCore::NotificationCenter::createHTMLNotification): (WebCore::NotificationCenter::createNotification):

12:02 AM Changeset in webkit [77737] by commit-queue@webkit.org

4 edits in trunk/Tools

2011-02-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77725.
http://trac.webkit.org/changeset/77725
https://bugs.webkit.org/show_bug.cgi?id=53844

It broke Qt minimal build (Requested by Ossy_ on #webkit).

QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome):
QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):

Feb 4, 2011:

11:38 PM Changeset in webkit [77736] by mihaip@chromium.org

6 edits
2 copies in branches/chromium/648

Merge 77705 - 2011-02-04 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819

Tests that navigating back and forward between hash items works.

fast/history/history-back-forward-within-subframe-hash.html: Added.
fast/history/history-back-forward-within-subframe-hash-expected.txt: Added.

2011-02-04 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819

Avoids deleting the current HistoryItem while it is still in use.
Ensures that provisional items are committed for same document navigations.
Ensures that error pages are committed on back/forward navigations.
Also removes unneeded sanity checks used for diagnosing the problem.

loader/HistoryController.cpp:
loader/HistoryController.h:

2011-02-04 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819

Removes unneeded sanity checks used for diagnosing a memory error.

src/WebFrameImpl.cpp:

BUG=70315
TBR=creis@webkit.org
Review URL: http://codereview.chromium.org/6250180

11:35 PM Changeset in webkit [77735] by jer.noble@apple.com

2 edits in trunk/LayoutTests

2011-02-04 Jer Noble <jer.noble@apple.com>

Adding test to Qt Skipped list.

[Qt] media/video-frame-accurate-seek.html fails
https://bugs.webkit.org/show_bug.cgi?id=53843

platform/qt/Skipped:

10:25 PM Changeset in webkit [77734] by joone.hur@collabora.co.uk

2 edits in trunk/Source/WebKit/gtk

2011-02-04 Joone Hur <joone.hur@collabora.co.uk>

Unreviewed, Fix compilation warning.

Constructor initialization list should follow the declaration order.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::FrameLoaderClient): m_hasRepresentation is moved to the last position in the initialization list.

10:24 PM Changeset in webkit [77733] by mrowe@apple.com

20 edits in tags/Safari-534.18

Revert r77588 to work around <rdar://problem/8963096>.

10:03 PM Changeset in webkit [77732] by mrowe@apple.com

5 edits in trunk/Source

Versioning.

10:01 PM Changeset in webkit [77731] by mrowe@apple.com

1 copy in tags/Safari-534.18

New tag.

9:17 PM Changeset in webkit [77730] by abarth@webkit.org

3 edits
2 adds in trunk

2011-02-04 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Crash in WebCore::TextEncoding::decode below XSSFilter::init
https://bugs.webkit.org/show_bug.cgi?id=53837

Test that we can successfully execute a JavaScript URL when it isn't
blocked by the filter.

http/tests/security/xssAuditor/non-block-javascript-url-frame-expected.txt: Added.
http/tests/security/xssAuditor/non-block-javascript-url-frame.html: Added.

2011-02-04 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Crash in WebCore::TextEncoding::decode below XSSFilter::init
https://bugs.webkit.org/show_bug.cgi?id=53837

Add missing null check.

Test: http/tests/security/xssAuditor/non-block-javascript-url-frame.html

html/parser/XSSFilter.cpp: (WebCore::XSSFilter::init):

8:56 PM Changeset in webkit [77729] by Simon Fraser

2 edits in trunk/Source/WebCore

2011-02-04 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Crashes in ShadowBlur via WebKit2 FindController
https://bugs.webkit.org/show_bug.cgi?id=53830

Fix a crash cause by re-entering ShadowBlur, and add assertions to
detect when it happens.

The re-entrancy occurred when drawRectShadowWithTiling() filled
the interior of the shadow with fillRect() on the context
which still had the shadow state set. This would make another ShadowBlur
on the stack and call into the code again, potentially blowing away
the image buffer.

Fix by turning off shadows in the destination context while we're
drawing the tiled shadow. The non-tiled code path already did this.

Not testable because CSS shadows clip out the inside of the rect
being shadowed, and SVG uses fillPath, even for rects.

platform/graphics/ShadowBlur.cpp: (WebCore::ScratchBuffer::ScratchBuffer): (WebCore::ScratchBuffer::getScratchBuffer): (WebCore::ScratchBuffer::scheduleScratchBufferPurge): (WebCore::ShadowBlur::ShadowBlur): (WebCore::ShadowBlur::drawRectShadowWithTiling):

8:54 PM Changeset in webkit [77728] by mjs@apple.com

2 edits in trunk/LayoutTests

2011-02-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Skip a new test that uses EventSender
https://bugs.webkit.org/show_bug.cgi?id=53841

platform/mac-wk2/Skipped:

8:17 PM Changeset in webkit [77727] by commit-queue@webkit.org

4 edits in trunk

2011-02-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Adam Barth.

[GTK] plugins/plugin-document-back-forward.html fails
https://bugs.webkit.org/show_bug.cgi?id=53833

platform/gtk/Skipped: Unskip test which is now passing.

2011-02-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Adam Barth.

[GTK] plugins/plugin-document-back-forward.html fails
https://bugs.webkit.org/show_bug.cgi?id=53833

Add the new "alert on load" functionality for the Unix version of the
test plugin. This functionality was originally introduced in r77706.

DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): Add new plugin fuctionality.

7:37 PM Changeset in webkit [77726] by Martin Robinson

17 edits in trunk

2011-02-04 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

Update expected results reflecting the change to search icon rendering.

platform/gtk/fast/css/input-search-padding-expected.checksum:
platform/gtk/fast/css/input-search-padding-expected.png:
platform/gtk/fast/css/input-search-padding-expected.txt:
platform/gtk/fast/forms/search-styled-expected.checksum:
platform/gtk/fast/forms/search-styled-expected.png:
platform/gtk/fast/forms/search-styled-expected.txt:
platform/gtk/fast/forms/search-vertical-alignment-expected.checksum:
platform/gtk/fast/forms/search-vertical-alignment-expected.png:
platform/gtk/fast/forms/search-zoomed-expected.checksum:
platform/gtk/fast/forms/search-zoomed-expected.png:
platform/gtk/fast/forms/search-zoomed-expected.txt:
platform/gtk/fast/forms/searchfield-heights-expected.checksum:
platform/gtk/fast/forms/searchfield-heights-expected.png:
platform/gtk/fast/forms/searchfield-heights-expected.txt:

2011-02-04 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Don't use a fixed size for search field icons
https://bugs.webkit.org/show_bug.cgi?id=50624

Use the parent input content box to make sure the icon fits in the
search field, scaling it down when needed.

platform/gtk/RenderThemeGtk.cpp: (WebCore::paintGdkPixbuf): (WebCore::getIconSizeForPixelSize): (WebCore::adjustSearchFieldIconStyle): (WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationStyle): (WebCore::centerRectVerticallyInParentInputElement): (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): (WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): (WebCore::RenderThemeGtk::paintCapsLockIndicator): (WebCore::RenderThemeGtk::paintMediaButton):

7:11 PM Changeset in webkit [77725] by commit-queue@webkit.org

4 edits in trunk/Tools

2011-02-04 Kundu Suchismita <suchi.kundu@nokia.com>

Reviewed by Andreas Kling.

Local Storage settings can be enable/disable from "Develop" menu
https://bugs.webkit.org/show_bug.cgi?id=52296

QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): (LauncherWindow::toggleLocalStorage): (LauncherWindow::toggleOfflineStorageDatabase): (LauncherWindow::toggleOfflineWebApplicationCache): (LauncherWindow::setOfflineStorageDefaultQuota):
QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):

7:05 PM Changeset in webkit [77724] by commit-queue@webkit.org

3 edits
4 adds in trunk

2011-02-04 Hironori Bono <hbono@chromium.org>

Reviewed by Adam Barth.

[chromium] JPEG corruption
https://bugs.webkit.org/show_bug.cgi?id=53250

This change adds a new script test that we can render a CMYK JPEG with a
color profile correctly, i.e. we can render it without color corruption.

fast/images/cmyk-jpeg-with-color-profile-expected.txt: Added.
fast/images/cmyk-jpeg-with-color-profile.html: Added.
fast/images/resources/cmyk-jpeg.jpg: Added.
fast/images/script-tests/cmyk-jpeg-with-color-profile.js: Added. (image.onload):

2011-02-04 Hironori Bono <hbono@chromium.org>

Reviewed by Adam Barth.

[chromium] JPEG corruption
https://bugs.webkit.org/show_bug.cgi?id=53250

Same as gray-scale JPEGs, we convert the colors of CMYK JPEGs with color
profiles from CMYK to RGB twice and it causes color corruption. This
change suppresses the color profiles for CMYK JPEGs same as gray-scale
ones.

Test: fast/images/cmyk-jpeg-with-color-profile.html

platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode):

6:57 PM Changeset in webkit [77723] by Martin Robinson

254 edits
15 adds in trunk/LayoutTests

2011-02-04 Martin Robinson <mrobinson@igalia.com>

Update pixel results for the fast/forms directory in preparation for landing
fixes to input type=search icon sizing. Also add some missing results. These
results are out of date because of changes to font hinting some time ago.

platform/gtk/fast/forms/
platform/gtk/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
platform/gtk/fast/forms/input-placeholder-visibility-1-expected.png: Added.
platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt: Added.
platform/gtk/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
platform/gtk/fast/forms/input-placeholder-visibility-2-expected.png: Added.
platform/gtk/fast/forms/input-placeholder-visibility-2-expected.txt: Added.
platform/gtk/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
platform/gtk/fast/forms/input-placeholder-visibility-3-expected.png: Added.
platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt: Added.
platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt: Added.

6:55 PM Changeset in webkit [77722] by abarth@webkit.org

2 edits in trunk/LayoutTests

2011-02-04 Adam Barth <abarth@webkit.org>

[Windows 7 Release Tests] plugins/plugin-document-back-forward.html failing since introduction in r77706
https://bugs.webkit.org/show_bug.cgi?id=53831

Stop dumping the child frames because that's not needed for this test
and cause extra output on Windows.

plugins/plugin-document-back-forward.html:

6:50 PM Changeset in webkit [77721] by abarth@webkit.org

2 edits in trunk/LayoutTests

2011-02-04 Adam Barth <abarth@webkit.org>

[GTK] plugins/plugin-document-back-forward.html fails
https://bugs.webkit.org/show_bug.cgi?id=53833

Add plugins/plugin-document-back-forward.html to skipped list while we
investigate the issue.

platform/gtk/Skipped:

6:39 PM Changeset in webkit [77720] by tony@chromium.org

2 edits in trunk/Tools

2011-02-04 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

get test-webkitpy running on win32 python
https://bugs.webkit.org/show_bug.cgi?id=53822

The test harness crashes with a WindowsError because it can't find
'svn' when using subprocess.Popen. This gets us past the error
so we can see the failing tests on the Chromium Win Release Tests
bot.

Scripts/webkitpy/common/system/executive.py:

6:37 PM Changeset in webkit [77719] by mdelaney@apple.com

1 edit
51 moves
3 adds in trunk/LayoutTests

2011-02-04 Matthew Delaney <mdelaney@apple.com>

Reviewed by Dan Bernstein.

Move canvas layout test expectations into more appropriate locations
https://bugs.webkit.org/show_bug.cgi?id=53145

platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.broken-expected.txt: Removed.
...
platform/mac-snowleopard/canvas/philip/tests/type.prototype-expected.txt: Removed.
platform/mac/canvas: Added.
platform/mac/canvas/philip: Added.
platform/mac/canvas/philip/tests: Added.
platform/mac/canvas/philip/tests/2d.drawImage.broken-expected.txt: Copied from platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.broken-expected.txt.
...
platform/mac/canvas/philip/tests/type.prototype-expected.txt: Copied from platform/mac-snowleopard/canvas/philip/tests/type.prototype-expected.txt.

6:30 PM Changeset in webkit [77718] by jberlin@webkit.org

1 edit
1 add in trunk/LayoutTests

[Windows 7 Release Tests] plugins/plugin-document-back-forward.html failing since
introduction in r77706.
https://bugs.webkit.org/show_bug.cgi?id=53831

Unreviewed. Add expected (failing?) results to get the Windows 7 Release Test bots green.

platform/win/plugins/plugin-document-back-forward-expected.txt: Added.

6:26 PM Changeset in webkit [77717] by Martin Robinson

2 edits in trunk/LayoutTests

2011-02-04 Martin Robinson <mrobinson@igalia.com>

Unskip some tests which should now be passing.

platform/gtk/Skipped: Unskip tests.

6:19 PM Changeset in webkit [77716] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-02-04 Xiyuan Xia <xiyuan@chromium.org>

Reviewed by Tony Chang.

[Chromium] Option text in select popup does not align with menulist button text
https://bugs.webkit.org/show_bug.cgi?id=53632

This makes clientPaddingLeft and clientPaddingRight return
the additional m_innerBlock's padding so that the popup item text
aligns with the menulist button text.

rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::clientPaddingLeft): (WebCore::RenderMenuList::clientPaddingRight):

6:18 PM Changeset in webkit [77715] by andersca@apple.com

3 edits in trunk/Source/WebCore

REGRESSION: Horizontal scrollbar thumbs leave artifacts over page content when scrolling vertically
<rdar://problem/8962457>

Reviewed by Sam Weinig and Beth Dakin.

platform/ScrollView.cpp:

(WebCore::ScrollView::scrollContents):
Subtract scrollbars from the scroll view rect if overlay scrollers are enabled.

platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
Make sure to invalidate both scrollbars if overlay scrollers are enabled.

6:11 PM Changeset in webkit [77714] by Martin Robinson

4 edits in trunk

2011-02-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] WebKitWebFrame can return a stale frame name when calling webkit_web_frame_get_name
https://bugs.webkit.org/show_bug.cgi?id=53797

platform/gtk/Skipped: Unskip a test which is now passing.

2011-02-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] WebKitWebFrame can return a stale frame name when calling webkit_web_frame_get_name
https://bugs.webkit.org/show_bug.cgi?id=53797

When the frame name changes between different calls to webkit_web_frame_get_name
on the same frame, return the new frame name instead of the one valid during the
previous call.

webkit/webkitwebframe.cpp: (webkit_web_frame_init): Initialize the frame name to 0. (webkit_web_frame_get_name): Check the current frame name first before returning the cached value.

6:04 PM Changeset in webkit [77713] by bweinstein@apple.com

2 edits in trunk/Source/WebKit2

WebKit2: Crash when InjectedBundlePageLoaderClient::willSendRequestForFrame returns a null WKURLRequestRef
https://bugs.webkit.org/show_bug.cgi?id=53829

Reviewed by Maciej Stachowiak.

Store the result of m_client.willSendRequestForFrame in a RefPtr, and null check it before
calling resourceRequest() on it.

WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::willSendRequestForFrame):

5:58 PM Changeset in webkit [77712] by Martin Robinson

7 edits
1 add in trunk/LayoutTests

2011-02-04 Martin Robinson <mrobinson@igalia.com>

Rebaseline a few tests after r77665 and add a GTK-specific baseline
after r77690.

platform/gtk/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
platform/gtk/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
platform/gtk/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
platform/gtk/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
platform/gtk/fast/ruby/nested-ruby-expected.txt:
platform/gtk/fast/text/emphasis-avoid-ruby-expected.txt:
platform/gtk/media/video-frame-accurate-seek-expected.txt: Added.

5:45 PM Changeset in webkit [77711] by jberlin@webkit.org

16 edits in trunk/LayoutTests

[Windows 7 Release Tests] 5 ruby tests failing on Windows after r77665
https://bugs.webkit.org/show_bug.cgi?id=53820

Unreviewed. Landing expected results that are probably correct (given that the change in
77665 was to make the default ruby text size smaller by default).

platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
platform/win/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum:
platform/win/fast/blockflow/japanese-ruby-horizontal-bt-expected.png:
platform/win/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
platform/win/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
platform/win/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
platform/win/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
platform/win/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
platform/win/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
platform/win/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
platform/win/fast/ruby/nested-ruby-expected.checksum:
platform/win/fast/ruby/nested-ruby-expected.png:
platform/win/fast/ruby/nested-ruby-expected.txt:

5:41 PM Changeset in webkit [77710] by Martin Robinson

8 edits in trunk

2011-02-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] fast/events/pagehide-timeout.html fails
https://bugs.webkit.org/show_bug.cgi?id=53771

platform/gtk/Skipped: Unskip a test which is now passing.

2011-02-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] fast/events/pagehide-timeout.html fails
https://bugs.webkit.org/show_bug.cgi?id=53771

Add the document browser cache model. This model is optimized for viewing
a series of local files, while the document viewer is optimized for only
viewing one local file. Improve the documentation on the mapping of these
enum values to actual cache settings.

webkit/webkitglobals.cpp: (webkit_set_cache_model): Add support for the document browser cache model and improve comments in this section better explaining where the magic numbers come from.
webkit/webkitglobals.h: Added an enum value for the document browser cache model.

2011-02-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] fast/events/pagehide-timeout.html fails
https://bugs.webkit.org/show_bug.cgi?id=53771

Add knowledge of the document browser cache model the DRT. When resetting
WebKit settings to consistent values between tests, default to the document
browser cache model.

DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Reset the cache model to the document browser cache model between tests.
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the document browser cache model.

5:33 PM Changeset in webkit [77709] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Fix build.

WebProcess/mac/WebProcessMac.mm:

5:32 PM Changeset in webkit [77708] by andersca@apple.com

2 edits in trunk/Source/WebKit2

2011-02-04 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe.

Link opened in background tab fails to paint when activated if it completes loading before tab is selected
https://bugs.webkit.org/show_bug.cgi?id=53827
<rdar://problem/8962355>

WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::resumePainting): Invalidate the entire page.

5:23 PM Changeset in webkit [77707] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Fix <rdar://problem/8961227> WebKit2 does not work with symlinked home directories.

Reviewed by Sam Weinig.

WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformSetCacheModel):
Don't adopt an autoreleased pointer, this would lead to a crash.

(WebKit::appendSandboxParameterPath):
(WebKit::appendSandboxParameterConfPath):
(WebKit::initializeSandbox):
Clean up the sandbox parameter code and make sure that realpath is called for all parameters.

4:50 PM Changeset in webkit [77706] by abarth@webkit.org

7 edits
2 adds in trunk

2011-02-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474

Test that plugin loads when in a plugin document on back-forward.

plugins/plugin-document-back-forward-expected.txt: Added.
plugins/plugin-document-back-forward.html: Added.

2011-02-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474

Long ago, PluginDocument always caused the HTMLEmbedElement to create
its widget synchronously during a post-layout task. Recently, however,
some changes to the HistroyController caused layout on back/forward to
become slightly more complicated (and added an extra level of recursion
to layout). This extra level of recursion triggered the "I've recursed
too many times" condition in the post-layout task queue, causing the
FrameView to run the remainder of the tasks asynchronously.
Unfortunately, that broke PluginDocument because it needs its the
HTMLEmbedElement's updateWidget task to run synchronously.

This patch adds a mechanism for "kicking off" the pending post-layout
tasks synchronously (instead of waiting for the timer to fire).
PluginDocument then uses that facility to ensure that the
HTMLEmbedElement's updateWidget task happens.

Test: plugins/plugin-document-back-forward.html

html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
page/FrameView.cpp: (WebCore::FrameView::flushAnyPendingPostLayoutTasks):
page/FrameView.h:

2011-02-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474

Teach the test plugin how to call alert on load.

DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New):

4:48 PM Changeset in webkit [77705] by commit-queue@webkit.org

6 edits
2 adds in trunk

2011-02-04 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819

Tests that navigating back and forward between hash items works.

fast/history/history-back-forward-within-subframe-hash.html: Added.
fast/history/history-back-forward-within-subframe-hash-expected.txt: Added.

2011-02-04 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819

Avoids deleting the current HistoryItem while it is still in use.
Ensures that provisional items are committed for same document navigations.
Ensures that error pages are committed on back/forward navigations.
Also removes unneeded sanity checks used for diagnosing the problem.

loader/HistoryController.cpp:
loader/HistoryController.h:

2011-02-04 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819

Removes unneeded sanity checks used for diagnosing a memory error.

src/WebFrameImpl.cpp:

4:38 PM Changeset in webkit [77704] by Dimitri Glazkov

2 edits
3 adds in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Add expectations for the test, added in r77690.

platform/chromium-win/media/video-frame-accurate-seek-expected.checksum: Added.
platform/chromium-win/media/video-frame-accurate-seek-expected.png: Added.
platform/chromium-win/media/video-frame-accurate-seek-expected.txt: Added.
platform/chromium/test_expectations.txt:

4:30 PM Changeset in webkit [77703] by weinig@apple.com

2 edits in trunk/Source/WebKit2

Sandbox violations when visiting a site using HTTP authentication
<rdar://problem/8951079>

Reviewed by Mark Rowe.

WebProcess/com.apple.WebProcess.sb:

4:28 PM Changeset in webkit [77702] by carol.szabo@nokia.com

6 edits
2 adds in trunk

2011-02-04 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

Code Changes.

CSS 2.1 failure: content-*
https://bugs.webkit.org/show_bug.cgi?id=52126

fast/css/counters/content-021-expected.txt: Added.
fast/css/counters/content-021.html: Added. This is a copy of the test with the same name from the official css test suite, adapted for DumpRenderTree.

2011-02-04 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

Code Changes.

CSS 2.1 failure: content-*
https://bugs.webkit.org/show_bug.cgi?id=52126

Test: fast/css/counters/content-021.html

rendering/CounterNode.cpp: (showCounterTree): Made parameter const because it is supposed to be so.
rendering/RenderCounter.cpp: (WebCore::previousInPreOrder): (WebCore::previousSiblingOrParent): (WebCore::parentElement): (WebCore::areRenderersElementsSiblings): (WebCore::nextInPreOrder): Added these local helper functions to help navigate the DOM tree enriched with :before and :after pseudo elements. (WebCore::planCounter): Fixed bug that would create a repeat counter for second and subsequent renderers associated with the same DOM element. (WebCore::findPlaceForCounter): (WebCore::makeCounterNode): Changed to use the new tree navigation functions described above instead of the Renderer Tree navigation functions. (WebCore::RenderCounter::rendererSubtreeAttached): (WebCore::RenderCounter::rendererStyleChanged): Optimized to not bother about counters until the renderers are finally attached. (showRendererTree): (showNodeTree): Debug helper functions used to debug Counter bugs.

4:28 PM Changeset in webkit [77701] by ap@apple.com

5 edits in trunk/Source/WebKit2

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=53823
Print layout sometimes seen on screen

<rdar://problem/8948742> REGRESSION (WebKit2) - When I print a page, I visually see it re-layout
<rdar://problem/8899389> REGRESSION(WebKit2): Wrong content can appear when print dialog is up

UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::setAutodisplay): Removed a branch that didn't do anything useful.

UIProcess/API/mac/WKPrintingView.h:
UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _suspendAutodisplay]): (-[WKPrintingView _delayedResumeAutodisplayTimerFired]): (-[WKPrintingView _delayedResumeAutodisplay]): (-[WKPrintingView knowsPageRange:]): (-[WKPrintingView beginDocument]): (-[WKPrintingView endDocument]): When page setup changes, or when going from print preview to actual printing, AppKit calls -endDocument just to begin it again. Delay resuming autodisplay until the next run loop iteration.

WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::invalidateContentsAndWindow): (WebKit::WebChromeClient::invalidateContentsForSlowScroll): Tightened it up from other side - we should never send pixels to UI process while in printing mode. This is not 100% reliable, because relayout doesn't happen immediately, and we can still have print layout in screen mode - but it helps.

4:26 PM Changeset in webkit [77700] by Dimitri Glazkov

1 edit
6 deletes in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Removed Chromium-specific baselines that are no longer necessary.

platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Removed.
platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Removed.
platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Removed.
platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Removed.
platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Removed.
platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Removed.

4:20 PM Changeset in webkit [77699] by ggaren@apple.com

5 edits in trunk/Source/JavaScriptCore

2011-02-04 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Rolled back in r77612 with ASSERT/crash fixed.
https://bugs.webkit.org/show_bug.cgi?id=53759

Don't shrink the heap to 0 unconditionally. Instead, shrink to 1 if
necessary. For now, the heap assumes that it always has at least one
block live.

runtime/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::reset):
runtime/Heap.h:
runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::shrinkBlocks): (JSC::MarkedSpace::sweep): (JSC::MarkedSpace::reset):
runtime/MarkedSpace.h: (JSC::MarkedSpace::highWaterMark): (JSC::MarkedSpace::setHighWaterMark):

4:18 PM Changeset in webkit [77698] by mitz@apple.com

2 edits in trunk/Source/WebCore

Typo fix.

html/parser/XSSFilter.cpp:

(WebCore::HTMLNames::containsJavaScriptURL):

4:17 PM Changeset in webkit [77697] by mitz@apple.com

2 edits in trunk/Source/WebCore

Make an infinite loop introduced in r77454 finite.

Reviewed by Anders Carlsson.

html/parser/XSSFilter.cpp:

(WebCore::HTMLNames::containsJavaScriptURL):

4:16 PM Changeset in webkit [77696] by Dimitri Glazkov

5 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Update Leopard pixel results for fast/box-shadow.

platform/mac-leopard/fast/box-shadow/basic-shadows-expected.checksum:
platform/mac-leopard/fast/box-shadow/basic-shadows-expected.png:
platform/mac-leopard/fast/box-shadow/inset-expected.checksum:
platform/mac-leopard/fast/box-shadow/inset-expected.png:

4:11 PM Changeset in webkit [77695] by weinig@apple.com

2 edits in trunk/Source/WebKit2

Fix for <rdar://problem/8961580>.
Work around for <rdar://problem/8957845>.

Reviewed by Mark Rowe.

WebProcess/com.apple.WebProcess.sb:

4:11 PM Changeset in webkit [77694] by Darin Adler

9 edits in trunk/Source/WebKit2

2011-02-04 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

WebKit2 doesn't hide mouse pointer on keypress
https://bugs.webkit.org/show_bug.cgi?id=53821
rdar://problem/8630895

UIProcess/PageClient.h: Renamed didNotHandleKeyEvent to doneWithKeyEvent and added a bool wasEventHandled argument.
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveEvent): Changed code to call doneWithKeyEvent and call even if event was handled.

UIProcess/API/mac/PageClientImpl.h: Updated for above change.
UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::doneWithKeyEvent): Ditto. But also call [NSCursor setHiddenUntilMouseMoves:YES] when a key down event was handled. This matches what -[WebHTMLView keyDown:] does.
UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::doneWithKeyEvent): Ditto.
UIProcess/API/qt/qwkpage_p.h: Ditto.
UIProcess/win/WebView.cpp: (WebKit::WebView::doneWithKeyEvent): Ditto.
UIProcess/win/WebView.h: Ditto.

3:49 PM Changeset in webkit [77693] by mrowe@apple.com

5 edits in branches/safari-533.20-branch

Versioning.

3:49 PM Changeset in webkit [77692] by mrowe@apple.com

1 copy in tags/Safari-533.20.24

New tag.

3:49 PM Changeset in webkit [77691] by mrowe@apple.com

2 edits in branches/safari-533.20-branch/WebKit/win

Build fix.

3:48 PM Changeset in webkit [77690] by jer.noble@apple.com

5 edits
6 adds in trunk

2011-02-04 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

Frame accurate seeking isn't always accurate
https://bugs.webkit.org/show_bug.cgi?id=52697

New pixel test that seeks to specific currentTimes and records the rendered frame.

media/content/test-25fps.mp4: Added.
media/content/test-25fps.ogv: Added.
media/video-frame-accurate-seek-expected.txt: Added.
media/video-frame-accurate-seek.html: Added.
platform/mac/media/video-frame-accurate-seek-expected.checksum: Added.
platform/mac/media/video-frame-accurate-seek-expected.png: Added.

2011-02-04 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

Frame accurate seeking isn't always accurate
https://bugs.webkit.org/show_bug.cgi?id=52697

Test: media/video-frame-accurate-seek.html

Make seeking slightly more accurate by rounding instead of truncating
when converting from seconds-in-float to time/timeScale.

platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::createQTTime):
platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::mediaTimeForTimeValue):
platform/graphics/win/QTMovie.cpp: (QTMovie::setCurrentTime):

3:45 PM Changeset in webkit [77689] by jorlow@chromium.org

15 edits
2 adds in trunk

2011-02-04 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Second IndexedDB events overhaul patch
https://bugs.webkit.org/show_bug.cgi?id=53813

storage/indexeddb/request-event-propagation-expected.txt: Added.
storage/indexeddb/request-event-propagation.html: Added.

2011-02-04 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Second IndexedDB events overhaul patch
https://bugs.webkit.org/show_bug.cgi?id=53813

If an IDBRequest has a IDBTransaction, it should propogate
events through it. In order to do this, IDBRequest needs to
hold a transaction frontend object rather than a backend one.

Test: storage/indexeddb/request-event-propagation.html

storage/IDBCursor.cpp: (WebCore::IDBCursor::IDBCursor):
storage/IDBCursor.h: (WebCore::IDBCursor::create):
storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setSetVersionTransaction): (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::deleteObjectStore):
storage/IDBDatabase.h:
storage/IDBIndex.cpp: (WebCore::IDBIndex::IDBIndex): (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor): (WebCore::IDBIndex::get): (WebCore::IDBIndex::getKey):
storage/IDBIndex.h: (WebCore::IDBIndex::create):
storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::IDBObjectStore): (WebCore::IDBObjectStore::get): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::deleteFunction): (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::deleteIndex): (WebCore::IDBObjectStore::openCursor):
storage/IDBObjectStore.h: (WebCore::IDBObjectStore::create):
storage/IDBRequest.cpp: (WebCore::IDBRequest::create): (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::resetReadyState): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent):
storage/IDBRequest.h:
storage/IDBTransaction.cpp: (WebCore::IDBTransaction::IDBTransaction): (WebCore::IDBTransaction::objectStore): (WebCore::IDBTransaction::contextDestroyed): (WebCore::IDBTransaction::enqueueEvent):
storage/IDBTransaction.h:
storage/IDBTransaction.idl:

3:43 PM Changeset in webkit [77688] by jorlow@chromium.org

29 edits
1 copy
1 add in trunk

2011-02-04 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

First step towards event propogation within IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53795

This is the first step towards implementing
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.

The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.

storage/indexeddb/cursor-index-delete-expected.txt:
storage/indexeddb/cursor-index-delete.html:
storage/indexeddb/database-quota-expected.txt:
storage/indexeddb/database-quota.html:
storage/indexeddb/duplicates-expected.txt:
storage/indexeddb/duplicates.html:
storage/indexeddb/error-causes-abort-by-default-expected.txt: Copied from LayoutTests/storage/indexeddb/cursor-index-delete-expected.txt.
storage/indexeddb/error-causes-abort-by-default.html: Added.
storage/indexeddb/index-basics-expected.txt:
storage/indexeddb/index-basics.html:
storage/indexeddb/objectstore-autoincrement-expected.txt:
storage/indexeddb/objectstore-autoincrement.html:
storage/indexeddb/objectstore-basics-expected.txt:
storage/indexeddb/objectstore-basics.html:

2011-02-04 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

First step towards event propogation within IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53795

This is the first step towards implementing
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.

The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.

Test: storage/indexeddb/error-causes-abort-by-default.html

storage/IDBAbortEvent.cpp: (WebCore::IDBAbortEvent::create): (WebCore::IDBAbortEvent::IDBAbortEvent):
storage/IDBAbortEvent.h:
storage/IDBCompleteEvent.cpp: (WebCore::IDBCompleteEvent::create): (WebCore::IDBCompleteEvent::IDBCompleteEvent):
storage/IDBCompleteEvent.h:
storage/IDBErrorEvent.cpp: (WebCore::IDBErrorEvent::IDBErrorEvent):
storage/IDBEvent.cpp: (WebCore::IDBEvent::IDBEvent): (WebCore::IDBEvent::dispatch):
storage/IDBEvent.h:
storage/IDBRequest.cpp: (WebCore::IDBRequest::dispatchEvent):
storage/IDBRequest.h:
storage/IDBSuccessEvent.cpp: (WebCore::IDBSuccessEvent::IDBSuccessEvent):
storage/IDBTransaction.cpp: (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete):
storage/IDBTransaction.h: (WebCore::IDBTransaction::backend):
storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::taskTimerFired):

3:36 PM Changeset in webkit [77687] by dcheng@chromium.org

13 edits in trunk/Source

2011-02-04 Daniel Cheng <dcheng@chromium.org>

Reviewed by Dmitry Titov.

Clone WebClipboard to be frame-specific.
https://bugs.webkit.org/show_bug.cgi?id=53727

For drop operations, Chrome currently snapshots the data and copies it
into the renderer process. As we add more supported drag data types, the
copy will become increasingly expensive. Instead, we'd like to snapshot
data in the browser to reduce the amount of data copied and to support
Blob in DataTransferItem. In order to allow this, we associated
WebClipboard with a frame so it can correctly route its IPCs to the
corresponding Chromium host.

No new tests because no new functionality.

platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::createReadable):
platform/chromium/ChromiumDataObject.h:
platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::create):
platform/chromium/PlatformBridge.h:
platform/chromium/ReadableDataObject.cpp: (WebCore::ReadableDataObject::create): (WebCore::ReadableDataObject::ReadableDataObject): (WebCore::ReadableDataObject::getData): (WebCore::ReadableDataObject::urlTitle): (WebCore::ReadableDataObject::htmlBaseUrl): (WebCore::ReadableDataObject::filenames): (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
platform/chromium/ReadableDataObject.h:

2011-02-04 Daniel Cheng <dcheng@chromium.org>

Reviewed by Dmitry Titov.

Clone WebClipboard to be frame-specific.
https://bugs.webkit.org/show_bug.cgi?id=53727

For drop operations, Chrome currently snapshots the data and copies it
into the renderer process. As we add more supported drag data types, the
copy will become increasingly expensive. Instead, we'd like to snapshot
data in the browser to reduce the amount of data copied and to support
Blob in DataTransferItem. In order to allow this, we associated
WebClipboard with a frame so it can correctly route its IPCs to the
corresponding Chromium host.

public/WebFrameClient.h: (WebKit::WebFrameClient::clipboard):
src/PlatformBridge.cpp: (WebCore::getClipboard): (WebCore::PlatformBridge::clipboardReadAvailableTypes): (WebCore::PlatformBridge::clipboardReadData): (WebCore::PlatformBridge::clipboardReadFilenames):
src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::fromFrame):
src/WebFrameImpl.h:
src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragTargetDragEnterNew):

3:34 PM Changeset in webkit [77686] by Dimitri Glazkov

1 edit
6 deletes in trunk/LayoutTests

[Chromium] Remove Chromium-specific baselines that we no longer need.

platform/chromium-mac-leopard/fast/ruby/nested-ruby-expected.checksum: Removed.
platform/chromium-mac-leopard/fast/ruby/nested-ruby-expected.png: Removed.
platform/chromium-mac-leopard/fast/ruby/ruby-beforeafter-expected.checksum: Removed.
platform/chromium-mac-leopard/fast/ruby/ruby-beforeafter-expected.png: Removed.
platform/chromium-mac-leopard/fast/ruby/ruby-run-break-expected.checksum: Removed.
platform/chromium-mac-leopard/fast/ruby/ruby-run-break-expected.png: Removed.

3:33 PM Changeset in webkit [77685] by jorlow@chromium.org

29 edits
2 deletes in trunk

2011-02-04 Jeremy Orlow <jorlow@chromium.org>

Revert https://bugs.webkit.org/show_bug.cgi?id=53795

storage/indexeddb/cursor-index-delete-expected.txt:
storage/indexeddb/cursor-index-delete.html:
storage/indexeddb/cursor-update-expected.txt:
storage/indexeddb/cursor-update.html:
storage/indexeddb/database-quota-expected.txt:
storage/indexeddb/database-quota.html:
storage/indexeddb/duplicates-expected.txt:
storage/indexeddb/duplicates.html:
storage/indexeddb/error-causes-abort-by-default-expected.txt: Removed.
storage/indexeddb/error-causes-abort-by-default.html: Removed.
storage/indexeddb/index-basics-expected.txt:
storage/indexeddb/index-basics.html:
storage/indexeddb/objectstore-autoincrement-expected.txt:
storage/indexeddb/objectstore-autoincrement.html:
storage/indexeddb/objectstore-basics-expected.txt:
storage/indexeddb/objectstore-basics.html:

2011-02-04 Jeremy Orlow <jorlow@chromium.org>

Revert https://bugs.webkit.org/show_bug.cgi?id=53795

storage/IDBAbortEvent.cpp: (WebCore::IDBAbortEvent::create): (WebCore::IDBAbortEvent::IDBAbortEvent):
storage/IDBAbortEvent.h:
storage/IDBCompleteEvent.cpp: (WebCore::IDBCompleteEvent::create): (WebCore::IDBCompleteEvent::IDBCompleteEvent):
storage/IDBCompleteEvent.h:
storage/IDBErrorEvent.cpp: (WebCore::IDBErrorEvent::IDBErrorEvent):
storage/IDBEvent.cpp: (WebCore::IDBEvent::IDBEvent):
storage/IDBEvent.h:
storage/IDBRequest.cpp: (WebCore::IDBRequest::dispatchEvent):
storage/IDBRequest.h:
storage/IDBSuccessEvent.cpp: (WebCore::IDBSuccessEvent::IDBSuccessEvent):
storage/IDBTransaction.cpp: (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete):
storage/IDBTransaction.h:
storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::taskTimerFired):

3:19 PM Changeset in webkit [77684] by Dimitri Glazkov

2 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Marked test, added in r77680 as failing due to lighttpd.

platform/chromium/test_expectations.txt: Marked.

3:08 PM Changeset in webkit [77683] by Dimitri Glazkov

8 edits
6 deletes in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Update Leopard baselines for fast/blockflow, this time correctly.

platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Removed.
platform/mac-leopard/fast/blockflow/fieldsets-expected.png:
platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Removed.
platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Removed.
platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Removed.
platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Removed.
platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Removed.

2:54 PM Changeset in webkit [77682] by dpranke@chromium.org

2 edits in trunk/LayoutTests

2011-02-04 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Merge in some GPU expectations that got dropped in r77666, get lint to pass.

platform/chromium/test_expectations.txt:

2:49 PM Changeset in webkit [77681] by Dimitri Glazkov

33 edits
4 adds in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Add Leopard-specific pixel results for fast/ruby.

platform/mac-leopard/fast/ruby/nested-ruby-expected.checksum: Added.
platform/mac-leopard/fast/ruby/nested-ruby-expected.png: Added.
platform/mac-leopard/fast/ruby/ruby-beforeafter-expected.checksum: Added.
platform/mac-leopard/fast/ruby/ruby-beforeafter-expected.png: Added.
platform/mac-leopard/fast/ruby/ruby-empty-rt-expected.checksum:
platform/mac-leopard/fast/ruby/ruby-empty-rt-expected.png:
platform/mac-leopard/fast/ruby/ruby-length-expected.checksum:
platform/mac-leopard/fast/ruby/ruby-length-expected.png:
platform/mac-leopard/fast/ruby/ruby-run-break-expected.checksum:
platform/mac-leopard/fast/ruby/ruby-run-break-expected.png:
platform/mac-leopard/fast/ruby/ruby-runs-expected.checksum:
platform/mac-leopard/fast/ruby/ruby-runs-expected.png:
platform/mac-leopard/fast/ruby/ruby-runs-spans-expected.checksum:
platform/mac-leopard/fast/ruby/ruby-runs-spans-expected.png:
platform/mac-leopard/fast/ruby/ruby-simple-expected.checksum:
platform/mac-leopard/fast/ruby/ruby-simple-expected.png:
platform/mac-leopard/fast/ruby/ruby-simple-rp-expected.checksum:
platform/mac-leopard/fast/ruby/ruby-simple-rp-expected.png:
platform/mac-leopard/fast/ruby/ruby-trailing-expected.checksum:
platform/mac-leopard/fast/ruby/ruby-trailing-expected.png:
platform/mac-leopard/fast/ruby/rubyDOM-insert-rt-expected.checksum:
platform/mac-leopard/fast/ruby/rubyDOM-insert-rt-expected.png:
platform/mac-leopard/fast/ruby/rubyDOM-insert-text1-expected.checksum:
platform/mac-leopard/fast/ruby/rubyDOM-insert-text1-expected.png:
platform/mac-leopard/fast/ruby/rubyDOM-insert-text2-expected.checksum:
platform/mac-leopard/fast/ruby/rubyDOM-insert-text2-expected.png:
platform/mac-leopard/fast/ruby/rubyDOM-insert-text3-expected.checksum:
platform/mac-leopard/fast/ruby/rubyDOM-insert-text3-expected.png:
platform/mac-leopard/fast/ruby/rubyDOM-remove-rt1-expected.checksum:
platform/mac-leopard/fast/ruby/rubyDOM-remove-rt1-expected.png:
platform/mac-leopard/fast/ruby/rubyDOM-remove-rt2-expected.checksum:
platform/mac-leopard/fast/ruby/rubyDOM-remove-rt2-expected.png:
platform/mac-leopard/fast/ruby/rubyDOM-remove-text1-expected.checksum:
platform/mac-leopard/fast/ruby/rubyDOM-remove-text1-expected.png:
platform/mac-leopard/fast/ruby/rubyDOM-remove-text2-expected.checksum:
platform/mac-leopard/fast/ruby/rubyDOM-remove-text2-expected.png:

2:41 PM Changeset in webkit [77680] by commit-queue@webkit.org

3 edits
3 adds in trunk

2011-02-04 Martin Galpin <martin@66laps.com>

Reviewed by David Levin.

CORS origin header not set on GET when a preflight request is required.
https://bugs.webkit.org/show_bug.cgi?id=50773

http/tests/xmlhttprequest/cross-origin-preflight-get-expected.txt: Added.
http/tests/xmlhttprequest/cross-origin-preflight-get.html: Added.
http/tests/xmlhttprequest/resources/cross-origin-preflight-get.php: Added.

2011-02-04 Martin Galpin <martin@66laps.com>

Reviewed by David Levin.

CORS origin header not set on GET when a preflight request is required.
https://bugs.webkit.org/show_bug.cgi?id=50773

Test: http/tests/xmlhttprequest/cross-origin-preflight-get.html

loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::preflightSuccess): Explicitly set the request origin after a preflight request succeeds.

2:38 PM Changeset in webkit [77679] by jorlow@chromium.org

29 edits
1 copy
1 add in trunk

2011-02-04 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

First step towards event propogation within IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53795

This is the first step towards implementing
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.

The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.

storage/indexeddb/cursor-index-delete-expected.txt:
storage/indexeddb/cursor-index-delete.html:
storage/indexeddb/database-quota-expected.txt:
storage/indexeddb/database-quota.html:
storage/indexeddb/duplicates-expected.txt:
storage/indexeddb/duplicates.html:
storage/indexeddb/error-causes-abort-by-default-expected.txt: Copied from LayoutTests/storage/indexeddb/cursor-index-delete-expected.txt.
storage/indexeddb/error-causes-abort-by-default.html: Added.
storage/indexeddb/index-basics-expected.txt:
storage/indexeddb/index-basics.html:
storage/indexeddb/objectstore-autoincrement-expected.txt:
storage/indexeddb/objectstore-autoincrement.html:
storage/indexeddb/objectstore-basics-expected.txt:
storage/indexeddb/objectstore-basics.html:

2011-02-04 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

First step towards event propogation within IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53795

This is the first step towards implementing
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.

The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.

Test: storage/indexeddb/error-causes-abort-by-default.html

storage/IDBAbortEvent.cpp: (WebCore::IDBAbortEvent::create): (WebCore::IDBAbortEvent::IDBAbortEvent):
storage/IDBAbortEvent.h:
storage/IDBCompleteEvent.cpp: (WebCore::IDBCompleteEvent::create): (WebCore::IDBCompleteEvent::IDBCompleteEvent):
storage/IDBCompleteEvent.h:
storage/IDBErrorEvent.cpp: (WebCore::IDBErrorEvent::IDBErrorEvent):
storage/IDBEvent.cpp: (WebCore::IDBEvent::IDBEvent): (WebCore::IDBEvent::dispatch):
storage/IDBEvent.h:
storage/IDBRequest.cpp: (WebCore::IDBRequest::dispatchEvent):
storage/IDBRequest.h:
storage/IDBSuccessEvent.cpp: (WebCore::IDBSuccessEvent::IDBSuccessEvent):
storage/IDBTransaction.cpp: (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete):
storage/IDBTransaction.h: (WebCore::IDBTransaction::backend):
storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::taskTimerFired):

2:37 PM Changeset in webkit [77678] by sfalken@apple.com

3 edits in trunk/Source/WebKit2

2011-02-04 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

WebKit2 clients fail to launch on Windows if client exe is in a different directory from WebKit
https://bugs.webkit.org/show_bug.cgi?id=53810
<rdar://problem/8946085>

If WebKit2WebProcess.exe is in a different directory from the client process, and that
client process uses CreateProcess to launch WebKit2WebProcess, the DLL search path may
end up excluding the directory containing WebKit. To address this, we use SetDllDirectory
to explicitly include the WebKit directory in the DLL search path.

win/MainWin.cpp: (wWinMain): Use SetDllDirectory and LoadLibrary to load WebKit.dll from WebKit2WebProcess.exe
win/WebKit2WebProcessCommon.vsprops: Don't link directly to WebKit. Link against shlwapi.

2:31 PM Changeset in webkit [77677] by sfalken@apple.com

2 edits in trunk/WebKitLibraries

2011-02-04 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Bump Windows minimum system requirement to XPSP2
https://bugs.webkit.org/show_bug.cgi?id=53807

win/tools/vsprops/common.vsprops:

2:29 PM Changeset in webkit [77676] by Dimitri Glazkov

104 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Updated Win and Linux baselines after r77665.

2:08 PM Changeset in webkit [77675] by xji@chromium.org

7 edits in trunk/LayoutTests

2011-02-04 Xiaomei Ji <xji@chromium.org>

Unreviewed.

Rebaseline chromium after r77654.
text-align attribute in <select> is ignored both in button text and drop-down
items.

platform/chromium-linux/fast/text/international/bidi-menulist-expected.checksum:
platform/chromium-linux/fast/text/international/bidi-menulist-expected.png:
platform/chromium-linux/fast/text/international/bidi-menulist-expected.txt:
platform/chromium-win/fast/text/international/bidi-menulist-expected.checksum:
platform/chromium-win/fast/text/international/bidi-menulist-expected.png:
platform/chromium-win/fast/text/international/bidi-menulist-expected.txt:

2:05 PM Changeset in webkit [77674] by Dimitri Glazkov

1 edit
34 adds in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Add Leopard-specific pixel results for fast/blockflow.

platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Added.
platform/mac-leopard/fast/blockflow/block-level-images-expected.checksum: Added.
platform/mac-leopard/fast/blockflow/block-level-images-expected.png: Added.
platform/mac-leopard/fast/blockflow/border-vertical-lr-expected.checksum: Added.
platform/mac-leopard/fast/blockflow/border-vertical-lr-expected.png: Added.
platform/mac-leopard/fast/blockflow/english-bt-text-expected.checksum: Added.
platform/mac-leopard/fast/blockflow/english-bt-text-expected.png: Added.
platform/mac-leopard/fast/blockflow/english-lr-text-expected.checksum: Added.
platform/mac-leopard/fast/blockflow/english-lr-text-expected.png: Added.
platform/mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum: Added.
platform/mac-leopard/fast/blockflow/japanese-lr-selection-expected.png: Added.
platform/mac-leopard/fast/blockflow/japanese-lr-text-expected.checksum: Added.
platform/mac-leopard/fast/blockflow/japanese-lr-text-expected.png: Added.
platform/mac-leopard/fast/blockflow/japanese-rl-selection-expected.checksum: Added.
platform/mac-leopard/fast/blockflow/japanese-rl-selection-expected.png: Added.
platform/mac-leopard/fast/blockflow/japanese-rl-text-expected.checksum: Added.
platform/mac-leopard/fast/blockflow/japanese-rl-text-expected.png: Added.
platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Added.
platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
platform/mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
platform/mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
platform/mac-leopard/fast/blockflow/vertical-font-fallback-expected.checksum: Added.
platform/mac-leopard/fast/blockflow/vertical-font-fallback-expected.png: Added.

1:53 PM Changeset in webkit [77673] by Dimitri Glazkov

2 edits
6 deletes in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Remove platform-specific baselines, since we match platform/mac here.

platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Removed.
platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.png: Removed.
platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Removed.
platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.png: Removed.
platform/chromium/test_expectations.txt:

1:50 PM Changeset in webkit [77672] by Adam Roben

7 edits
2 adds in trunk

Add a test case for encode/decode of FormData/FormDataElement

If the fix made in r77401 is broken, this new test will crash.

Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.

Reviewed by Sam Weinig.

Tools:

TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.

Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.

TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
(TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
(TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
form, an return the session state data.
(TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
and restore it into another WKPage.

TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/win/TestWebKitAPI.vcproj:
TestWebKitAPI/win/copy-resources.cmd:

Added new files.

Source/WebKit2:

Allow passing a null filter callback to WKPageCopySessionState

UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::createCFDictionaryRepresentation): Check if the filter is null
before calling it.

1:50 PM Changeset in webkit [77671] by Adam Roben

4 edits
2 adds in trunk/Tools

Move code to run JavaScript tests into its own files

This will allow other tests to use this mechanism.

Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
world

Reviewed by Sam Weinig.

TestWebKitAPI/JavaScriptTest.cpp: Added.
TestWebKitAPI/JavaScriptTest.h: Added.

Moved code here...

TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/win/TestWebKitAPI.vcproj:

Added the new files.

1:48 PM Changeset in webkit [77670] by Dimitri Glazkov

2 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Update mac expectations.

platform/chromium/test_expectations.txt: Updated.

1:43 PM Changeset in webkit [77669] by Dimitri Glazkov

4 edits in trunk

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Csaba Osztrogonác.

[Qt]REGRESSION(r76951): media/controls-without-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=53674

platform/qt/Skipped:

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Csaba Osztrogonác.

[Qt]REGRESSION(r76951): media/controls-without-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=53674

css/mediaControlsQt.css:

1:27 PM Changeset in webkit [77668] by mihaip@chromium.org

2 edits in trunk/LayoutTests

2011-02-04 Mihai Parparita <mihaip@chromium.org>

Unreviewed GTK expectations update.

Unskip fast/history/timed-refresh-in-cached-frame.html, it should pass
with http://trac.webkit.org/changeset/77559.

platform/gtk/Skipped:

1:25 PM Changeset in webkit [77667] by bweinstein@apple.com

8 edits in trunk/Source/WebKit2

WebKit2: DidInitiateLoadForResource needs to know if the resource is being loaded by a committed or provisional frame
https://bugs.webkit.org/show_bug.cgi?id=53794

Reviewed by John Sullivan.

When we navigate from one page to another, there can be multiple subresource requests between when
the new page has started its provisional load and when it has committed the load.

There can be:

The main resource load of the provisional page
Synchronous XHR from the unload event of the loaded page.

WebKit clients need to be able to differentiate between these loads.

UIProcess/API/C/WKPage.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didInitiateLoadForResource): Pass whether or not the page is provisionally loading

to the client.

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in: Add a new parameter to DidInitiateLoadForResource.
UIProcess/WebResourceLoadClient.cpp:

(WebKit::WebResourceLoadClient::didInitiateLoadForResource): a new parameter to didInitiateLoadForResource.

UIProcess/WebResourceLoadClient.h:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest): Pass whether or not the page is currently

in a provisional load (checked by seeing if the DocumentLoader matches the FrameLoader's provisionalDocumentLoader)
to the UI Process.

1:21 PM Changeset in webkit [77666] by dpranke@chromium.org

7 edits
1 delete in trunk

2011-02-04 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

merge test expectations for chromium, chromium-gpu. From
now on, we will track GPU-specific expectations with the
"GPU" modifier in the main file, rather than in a separate
file (and non-GPU-specific expectations with the "CPU"
modifier.

https://bugs.webkit.org/show_bug.cgi?id=53562

platform/chromium-gpu/test_expectations.txt: Removed.
platform/chromium/test_expectations.txt:

2011-02-04 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

merge test expectations for chromium, chromium-gpu. The
chromium-gpu port will no longer maintain its own
test expectations file.

Also add in a graphics_type() call on the port object to
determine what graphics type to use in the test configuration,
and log the configuration as a config setting.

https://bugs.webkit.org/show_bug.cgi?id=53562

Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

1:18 PM Changeset in webkit [77665] by mitz@apple.com

78 edits in trunk

<rdar://problem/8902704> Make ruby text size 50% by default
https://bugs.webkit.org/show_bug.cgi?id=53723

Reviewed by Darin Adler and Dave Hyatt.

Source/WebCore:

css/html.css:

(ruby > rt): Changed the font-size from 60% to 50%.

LayoutTests:

fast/text/emphasis-avoid-ruby-expected.checksum:
fast/text/emphasis-avoid-ruby-expected.png:
fast/text/emphasis-avoid-ruby-expected.txt:
platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.png:
platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.png:
platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum:
platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.png:
platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum:
platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.png:
platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
platform/mac/fast/ruby/nested-ruby-expected.checksum:
platform/mac/fast/ruby/nested-ruby-expected.png:
platform/mac/fast/ruby/nested-ruby-expected.txt:
platform/mac/fast/ruby/ruby-beforeafter-expected.checksum:
platform/mac/fast/ruby/ruby-beforeafter-expected.png:
platform/mac/fast/ruby/ruby-beforeafter-expected.txt:
platform/mac/fast/ruby/ruby-empty-rt-expected.checksum:
platform/mac/fast/ruby/ruby-empty-rt-expected.png:
platform/mac/fast/ruby/ruby-empty-rt-expected.txt:
platform/mac/fast/ruby/ruby-length-expected.checksum:
platform/mac/fast/ruby/ruby-length-expected.png:
platform/mac/fast/ruby/ruby-length-expected.txt:
platform/mac/fast/ruby/ruby-run-break-expected.checksum:
platform/mac/fast/ruby/ruby-run-break-expected.png:
platform/mac/fast/ruby/ruby-run-break-expected.txt:
platform/mac/fast/ruby/ruby-runs-expected.checksum:
platform/mac/fast/ruby/ruby-runs-expected.png:
platform/mac/fast/ruby/ruby-runs-expected.txt:
platform/mac/fast/ruby/ruby-runs-spans-expected.checksum:
platform/mac/fast/ruby/ruby-runs-spans-expected.png:
platform/mac/fast/ruby/ruby-runs-spans-expected.txt:
platform/mac/fast/ruby/ruby-simple-expected.checksum:
platform/mac/fast/ruby/ruby-simple-expected.png:
platform/mac/fast/ruby/ruby-simple-expected.txt:
platform/mac/fast/ruby/ruby-simple-rp-expected.checksum:
platform/mac/fast/ruby/ruby-simple-rp-expected.png:
platform/mac/fast/ruby/ruby-simple-rp-expected.txt:
platform/mac/fast/ruby/ruby-trailing-expected.checksum:
platform/mac/fast/ruby/ruby-trailing-expected.png:
platform/mac/fast/ruby/ruby-trailing-expected.txt:
platform/mac/fast/ruby/rubyDOM-insert-rt-expected.checksum:
platform/mac/fast/ruby/rubyDOM-insert-rt-expected.png:
platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt:
platform/mac/fast/ruby/rubyDOM-insert-text1-expected.checksum:
platform/mac/fast/ruby/rubyDOM-insert-text1-expected.png:
platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt:
platform/mac/fast/ruby/rubyDOM-insert-text2-expected.checksum:
platform/mac/fast/ruby/rubyDOM-insert-text2-expected.png:
platform/mac/fast/ruby/rubyDOM-insert-text2-expected.txt:
platform/mac/fast/ruby/rubyDOM-insert-text3-expected.checksum:
platform/mac/fast/ruby/rubyDOM-insert-text3-expected.png:
platform/mac/fast/ruby/rubyDOM-insert-text3-expected.txt:
platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.checksum:
platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.png:
platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.txt:
platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.checksum:
platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.png:
platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.txt:
platform/mac/fast/ruby/rubyDOM-remove-text1-expected.checksum:
platform/mac/fast/ruby/rubyDOM-remove-text1-expected.png:
platform/mac/fast/ruby/rubyDOM-remove-text1-expected.txt:
platform/mac/fast/ruby/rubyDOM-remove-text2-expected.checksum:
platform/mac/fast/ruby/rubyDOM-remove-text2-expected.png:
platform/mac/fast/ruby/rubyDOM-remove-text2-expected.txt:

1:16 PM Changeset in webkit [77664] by Antti Koivisto

3 edits
4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=53610
Regression: adjacent sibling selector not working as expected
<rdar://problem/8960033>

Reviewed by Dimitri Glazkov.

Source/WebCore:

https://bugs.webkit.org/show_bug.cgi?id=53574
REGRESSION (r76012): :last-child:after not working as expected
<rdar://problem/8948643>

Test for additional conditions in parent style that prevent sharing.

Tests: fast/selectors/style-sharing-adjacent-selector.html

fast/selectors/style-sharing-last-child.html

css/CSSStyleSelector.cpp:

(WebCore::parentStylePreventsSharing):
(WebCore::CSSStyleSelector::locateSharedStyle):

LayoutTests:

https://bugs.webkit.org/show_bug.cgi?id=53574
REGRESSION (r76012): :last-child:after not working as expected
<rdar://problem/8948643>

fast/selectors/style-sharing-adjacent-selector-expected.txt: Added.
fast/selectors/style-sharing-adjacent-selector.html: Added.
fast/selectors/style-sharing-last-child-expected.txt: Added.
fast/selectors/style-sharing-last-child.html: Added.

1:11 PM Changeset in webkit [77663] by dpranke@chromium.org

2 edits
1 add in trunk/Source/WebCore

2011-02-04 Mark Mentovai <mark@chromium.org>

Reviewed by Dimitri Glazkov.

Chromium GYP build fix.

When various settings were moved to webcore_prerequisites in r66364,
things that should have been direct_dependent_settings were not marked
as such. GYP 'defines', for example, make no sense on a 'none'-type
target such as webcore_prerequisites. It appears that it was intended
for these settings to be pushed to direct dependents, which would make
direct_dependent_settings correct.

Losing the ChromiumWebCoreObjC defines on the Mac, for example, caused
http://crbug.com/71537, which at best causes Mac console log spew, and
at worst may result in Chromium's copy of WebCore using system
definitions of certain Objective-C classes at runtime, or vice-versa.

The build now includes a postbuild step to prevent
http://crbug.com/71537 from regressing again. The build will fail upon
regression.

https://bugs.webkit.org/show_bug.cgi?id=53630

WebCore.gyp/WebCore.gyp: Move things in webcore_prerequisites into direct_dependent_settings as needed, add the check_objc_rename postbuild step.
WebCore.gyp/mac/check_objc_rename.sh: Added.

1:09 PM Changeset in webkit [77662] by ddkilzer@apple.com

2 edits in trunk/Source/JavaScriptCore

BUILD FIX: REALLY remove the last vestiges of JSVALUE32!

<rdar://problem/8957409> Remove last vestiges of JSVALUE32
<http://webkit.org/b/53779>

DerivedSources.make: Removed dependency on

JavaScriptCore.JSVALUE32.exp.

1:04 PM Changeset in webkit [77661] by andersca@apple.com

2 edits in trunk/Source/WebKit2

2011-02-04 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe.

Mac WebKit2 should use the new drawing area
https://bugs.webkit.org/show_bug.cgi?id=53802
<rdar://problem/7881419>
<rdar://problem/7881447>
<rdar://problem/8252632>
<rdar://problem/8479422>
<rdar://problem/8633813>
<rdar://problem/8734512>
<rdar://problem/8787660>

UIProcess/API/mac/WKView.mm: (useNewDrawingArea): Return true. Eventually this function should be removed, but let's keep it for now so we can go back to the old drawing area if necessary.

12:49 PM Changeset in webkit [77660] by robert@webkit.org

8 edits
2 adds in trunk

2011-02-04 Robert Hogan <robert@webkit.org>

Reviewed by Darin Fisher.

Move chromium iframe shim code to cross-platform file.
https://bugs.webkit.org/show_bug.cgi?id=52594

platform/qt/Skipped: Unskip plugins/iframe-shims.html

2011-02-04 Robert Hogan <robert@webkit.org>

Reviewed by Darin Fisher.

Move chromium iframe shim code to cross-platform file
https://bugs.webkit.org/show_bug.cgi?id=52594

Move Chromium code for identifying and cutting out
iframe shims from plugins to cross-platform utility file
IFrameShimSupport.cpp.
Amend PluginViewQt to use this code to handle shims correctly.

WebCore.gypi: Add Chromium support for IFrameShimSupport.cpp
WebCore.pro: Add Qt support for IFrameShimSupport.cpp
plugins/IFrameShimSupport.cpp: Added. (WebCore::getObjectStack): (WebCore::iframeIsAbovePlugin): (WebCore::getPluginOcclusions):
plugins/IFframeShimSupport.h: Added.
plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setNPWindowIfNeeded):

2011-02-04 Robert Hogan <robert@webkit.org>

Reviewed by Darin Fisher.

Move chromium iframe shim code to cross-platform file
https://bugs.webkit.org/show_bug.cgi?id=52594

src/WebPluginContainerImpl.cpp: Move code to WebCore/plugin/IFrameShimSupport.cpp

12:47 PM Changeset in webkit [77659] by mjs@apple.com

2 edits in trunk/Source/WebKit2

2011-02-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

WebKit2: Crash in WebPageProxy::setPendingAPIRequestURL after web process crashed
https://bugs.webkit.org/show_bug.cgi?id=53799
<rdar://problem/8943956>

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::reload):

12:45 PM Changeset in webkit [77658] by andersca@apple.com

2 edits in trunk/Source/WebKit2

2011-02-04 Anders Carlsson <andersca@apple.com>

Reviewed by Maciej Stachowiak.

Fix a shared memory leak
https://bugs.webkit.org/show_bug.cgi?id=53800

Move the send right representing the shared memory.

Platform/mac/SharedMemoryMac.cpp: (WebKit::SharedMemory::Handle::encode):

12:38 PM Changeset in webkit [77657] by beidson@apple.com

7 edits
2 adds in trunk

<rdar://problem/8636239> and https://bugs.webkit.org/show_bug.cgi?id=53785
WebKit2: Pages with dynamically inserted iframes can add extraneous back/forward items.

Reviewed by Anders Carlsson.

Source/WebKit2:

WebCore doesn't gracefully handle the case where the decidePolicyForNavigationAction callback
does not occur synchronously. Let's make it synchronous.

Change WebPageProxy to handle this message reply synchronously:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in: Make the navigation policy action message be synchronous.

Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction): Add a 6-argument varient

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Send the message synchronously.

LayoutTests:

fast/loader/dynamic-iframe-extra-back-forward-item-expected.txt: Added.
fast/loader/dynamic-iframe-extra-back-forward-item.html: Added.

12:35 PM Changeset in webkit [77656] by sfalken@apple.com

2 edits in trunk/Source/WebKit2

Windows build fix.
Correct prebuild build-stopping rule to allow project only rebuilds.

win/WebKit2WebProcessPreBuild.cmd:

12:33 PM Changeset in webkit [77655] by bweinstein@apple.com

2 edits in trunk/Source/WebKit2

Assertion failure in WebInspectorProxy::platformClose closing main window when inspecting a popup
window, or when running regression tests.
https://bugs.webkit.org/show_bug.cgi?id=53798
<rdar://problem/8814364>

Reviewed by Adam Roben.

Only assert about the state of m_inspectorWindow and m_inspectorView if the inspector is visible.
Also, only call ::DestroyWindow if the HWND is non-null, just to be safe.

UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformClose):

12:30 PM Changeset in webkit [77654] by xji@chromium.org

6 edits in trunk/Source

2011-02-04 Xiaomei Ji <xji@chromium.org>

Reviewed by David Levin.

Implement "<option> should implement the dir attribute" for chromium port after r76983.
https://bugs.webkit.org/show_bug.cgi?id=50969

src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::selectItemAlignmentFollowsMenuWritingDirection): Override as true.
src/WebViewImpl.cpp: Remove directionality hint from autofill drop-down setting.

2011-02-04 Xiaomei Ji <xji@chromium.org>

Reviewed by David Levin.

Implement "<option> should implement the dir attribute" for chromium port after r76983.
https://bugs.webkit.org/show_bug.cgi?id=50969

Use manual test Source/WebCore/manual-tests/pop-up-alignment-and-direction.html
added in r76983.

platform/chromium/PopupMenuChromium.cpp: Remove directionality hint from <select> drop-down setting. (WebCore::PopupListBox::paintRow): Use <option>'s directionality to paint items in drop-down and pass-in bidi override flag when creating text run.
platform/chromium/PopupMenuChromium.h: Remove directionalityHint from PopupContainerSettings.

12:23 PM Changeset in webkit [77653] by Dimitri Glazkov

1 edit
10 adds in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Add platform/mac-leopard baselines for tests added in r77639. The text rendering is
different enough for them to be different from mac-snowleopard.

platform/mac-leopard/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
platform/mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png: Added.
platform/mac-leopard/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
platform/mac-leopard/fast/forms/input-placeholder-visibility-2-expected.png: Added.
platform/mac-leopard/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
platform/mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png: Added.
platform/mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
platform/mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
platform/mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
platform/mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.

12:10 PM Changeset in webkit [77652] by jorlow@chromium.org

2 edits in trunk/Source/WebCore

2011-02-04 Jeremy Orlow <jorlow@chromium.org>

Build fix from merge mistake.

storage/IDBTransaction.cpp: (WebCore::IDBTransaction::ensureEventTargetData):

11:57 AM Changeset in webkit [77651] by leviw@chromium.org

2 edits in trunk/Source/WebCore

2011-02-04 Levi Weintraub <leviw@chromium.org>

Reviewed by Darin Adler.

Remove unneeded function declarations in comments in EditorClient.h
https://bugs.webkit.org/show_bug.cgi?id=53745

Removing unused commented out function declarations. No tests since this is just cleanup.

page/EditorClient.h:

11:50 AM Changeset in webkit [77650] by jorlow@chromium.org

8 edits in trunk/Source/WebCore

2011-02-03 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Refactor IDBRequest and IDBTransaction a bit
https://bugs.webkit.org/show_bug.cgi?id=53565

There were a lot of subtle issues with the way IDBTransaction
and IDBRequest used to be written. This cleans a lot of them up
and largely simplifies the logic. Using EventQueue rather than
timers is one example of the simplification.

bindings/scripts/CodeGeneratorV8.pm:
dom/EventQueue.cpp: (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::dispatchEvent):
storage/IDBCursor.cpp: (WebCore::IDBCursor::continueFunction):
storage/IDBRequest.cpp: (WebCore::IDBRequest::create): (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::resetReadyState): (WebCore::IDBRequest::onError): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent): (WebCore::IDBRequest::enqueueEvent): (WebCore::IDBRequest::eventTargetData): (WebCore::IDBRequest::ensureEventTargetData):
storage/IDBRequest.h: (WebCore::IDBRequest::dispatchEvent):
storage/IDBTransaction.cpp: (WebCore::IDBTransaction::create): (WebCore::IDBTransaction::IDBTransaction): (WebCore::IDBTransaction::objectStore): (WebCore::IDBTransaction::abort): (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete): (WebCore::IDBTransaction::onTimeout): (WebCore::IDBTransaction::canSuspend): (WebCore::IDBTransaction::stop): (WebCore::IDBTransaction::enqueueEvent): (WebCore::IDBTransaction::eventTargetData): (WebCore::IDBTransaction::ensureEventTargetData):
storage/IDBTransaction.h:

11:38 AM Changeset in webkit [77649] by Dimitri Glazkov

1 edit
7 adds in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Add baselines for tests, added in r77644.

platform/chromium-linux/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
platform/chromium-linux/fast/repaint/slider-thumb-drag-release-expected.png: Added.
platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.png: Added.
platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.png: Added.
platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.txt: Added.

11:31 AM Changeset in webkit [77648] by Dimitri Glazkov

2 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Temporarily add tests added in r77639 as failing, because
we can't see the baselines for these tests (they are in platform/mac-snowleopard).

platform/chromium/test_expectations.txt: Added.

11:22 AM Changeset in webkit [77647] by jorlow@chromium.org

27 edits
2 deletes in trunk

2011-02-01 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Remove the timeout event from IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53521

storage/indexeddb/tutorial.html:

2011-02-01 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Remove the timeout event from IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53521

Remove timeout and ontimeout from IDBTransaction per the spec.

WebCore.gypi:
storage/IDBDatabase.cpp: (WebCore::IDBDatabase::transaction):
storage/IDBDatabase.h: (WebCore::IDBDatabase::transaction):
storage/IDBDatabase.idl:
storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::transaction):
storage/IDBDatabaseBackendImpl.h:
storage/IDBDatabaseBackendInterface.h:
storage/IDBTimeoutEvent.cpp: Removed.
storage/IDBTimeoutEvent.h: Removed.
storage/IDBTransaction.cpp: (WebCore::IDBTransaction::IDBTransaction): (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete):
storage/IDBTransaction.h:
storage/IDBTransaction.idl:
storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::create): (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
storage/IDBTransactionBackendImpl.h:
storage/IDBTransactionCallbacks.h:

2011-02-01 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Remove the timeout event from IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53521

public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::transaction):
public/WebIDBTransactionCallbacks.h:
src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::transaction):
src/IDBDatabaseProxy.h:
src/IDBTransactionCallbacksProxy.cpp:
src/IDBTransactionCallbacksProxy.h:
src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::transaction):
src/WebIDBDatabaseImpl.h:
src/WebIDBTransactionCallbacksImpl.cpp:
src/WebIDBTransactionCallbacksImpl.h:

11:16 AM Changeset in webkit [77646] by Dimitri Glazkov

2 edits
25 adds in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Add baselines for tests, added in r77639.

platform/chromium-linux/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
platform/chromium-linux/fast/forms/input-placeholder-visibility-1-expected.png: Added.
platform/chromium-linux/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
platform/chromium-linux/fast/forms/input-placeholder-visibility-2-expected.png: Added.
platform/chromium-linux/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
platform/chromium-linux/fast/forms/input-placeholder-visibility-3-expected.png: Added.
platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.png: Added.
platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt: Added.
platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.png: Added.
platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.txt: Added.
platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.png: Added.
platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt: Added.
platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt: Added.
platform/chromium/test_expectations.txt:

10:47 AM Changeset in webkit [77645] by Chris Fleizach

2 edits in trunk/Source/WebCore

AX: Can't set accessibility overridden attributes on web objects
https://bugs.webkit.org/show_bug.cgi?id=53725

Reviewed by Darin Adler.

accessibilitySetOverriddenValue does not work on AX objects from WebCore because
the right method needed to be overridden (accessibilitySupportsOverriddenAttributes).
Unfortunately, there's no way to test this from DRT, since AppKit returns the overridden
attribute only when an AX client asks for it through the AX frameworks.

accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilitySupportsOverriddenAttributes]):

10:42 AM Changeset in webkit [77644] by Dimitri Glazkov

3 edits
4 adds in trunk

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

REGRESSION(r76147): Slider thumb is not repainted when let go outside of the slider track.
https://bugs.webkit.org/show_bug.cgi?id=53691

fast/repaint/slider-thumb-drag-release.html: Added.
platform/mac/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
platform/mac/fast/repaint/slider-thumb-drag-release-expected.png: Added.
platform/mac/fast/repaint/slider-thumb-drag-release-expected.txt: Added.

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

REGRESSION(r76147): Slider thumb is not repainted when let go outside of the slider track.
https://bugs.webkit.org/show_bug.cgi?id=53691

Test: fast/repaint/slider-thumb-drag-release.html

html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::stopDragging): Added dirtying the layout bit to ensure

that the thumb is repainted.

10:32 AM Changeset in webkit [77643] by mnaganov@chromium.org

7 edits
2 adds in trunk/Source/WebCore

2011-02-04 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Add "show more" data grid node and waiting message UI components.
https://bugs.webkit.org/show_bug.cgi?id=53763

"show more" data grid node is used for on-demand population of data grid contents (similar to DOM tree capability for limiting displayed nodes count);

waiting message is used for informing user about long lasting operations (with a possibility to cancel them).

English.lproj/localizedStrings.js:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/PleaseWaitMessage.js: Added. (WebInspector.PleaseWaitMessage):
inspector/front-end/ShowMoreDataGridNode.js: Added. (WebInspector.ShowMoreDataGridNode):
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.css: (.data-grid button): (.please-wait-msg):
inspector/front-end/inspector.html:

10:32 AM Changeset in webkit [77642] by Dimitri Glazkov

16 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

Update mac baselines. They pixel-rotted.

platform/mac-leopard/fast/backgrounds/background-clip-text-expected.png:
platform/mac-leopard/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.png:
platform/mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
platform/mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
platform/mac-leopard/fast/backgrounds/size/backgroundSize15-expected.png:
platform/mac-leopard/fast/backgrounds/size/backgroundSize22-expected.checksum:
platform/mac-leopard/fast/backgrounds/size/backgroundSize22-expected.png:
platform/mac/fast/backgrounds/animated-svg-as-background-expected.checksum:
platform/mac/fast/backgrounds/animated-svg-as-background-expected.png:
platform/mac/fast/backgrounds/animated-svg-as-mask-expected.checksum:
platform/mac/fast/backgrounds/animated-svg-as-mask-expected.png:
platform/mac/fast/backgrounds/size/contain-and-cover-expected.checksum:
platform/mac/fast/backgrounds/size/contain-and-cover-expected.png:
platform/mac/fast/backgrounds/svg-as-background-4-expected.checksum:
platform/mac/fast/backgrounds/svg-as-background-4-expected.png:

10:27 AM Changeset in webkit [77641] by mnaganov@chromium.org

2 edits in trunk/Tools

2011-02-04 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
https://bugs.webkit.org/show_bug.cgi?id=53781

Scripts/check-inspector-strings:

10:25 AM Changeset in webkit [77640] by andersca@apple.com

2 edits in trunk/Source/WebKit2

2011-02-04 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Go out of accelerated compositing mode when the drawing area is destroyed
https://bugs.webkit.org/show_bug.cgi?id=53788

This fixes a crash in the UI process if a web process crashes while in accelerated compositing mode.

UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::~DrawingAreaProxyImpl):

10:18 AM Changeset in webkit [77639] by adele@apple.com

6 edits
36 adds
4 deletes in trunk

Fix for https://bugs.webkit.org/show_bug.cgi?id=53740
<rdar://problem/8503629> Allow platforms to specify if the placeholder should be visible when text controls are focused

Reviewed by Dan Bernstein.

Tests:
fast/forms/textarea-placeholder-visibility-1.html
fast/forms/textarea-placeholder-visibility-2.html
fast/forms/input-placeholder-visibility-1.html
fast/forms/input-placeholder-visibility-2.html
fast/forms/input-placeholder-visibility-3.html

html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):

Add a check for shouldShowPlaceholderWhenFocused.

html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateValue):

Whenever the value is updated, we should also update placeholder visibility.

rendering/RenderTheme.h: (WebCore::RenderTheme::shouldShowPlaceholderWhenFocused):

Make the default the same as the existing behavior.

rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):

Show placeholder when appropriate.

10:13 AM Changeset in webkit [77638] by ddkilzer@apple.com

4 edits
1 delete in trunk/Source/JavaScriptCore

<rdar://problem/8957409> Remove last vestiges of JSVALUE32
<http://webkit.org/b/53779>

Reviewed by Darin Adler.

Support for JSVALUE32 was originaly removed in r70111.

Configurations/JavaScriptCore.xcconfig: Changed armv6 to use

JavaScriptCore.JSVALUE32_64.exp and ppc64 to use
JavaScriptCore.JSVALUE64.exp to match Platform.h.

DerivedSources.make: Removed rule for

JavaScriptCore.JSVALUE32.exp.

JavaScriptCore.JSVALUE32only.exp: Removed.
JavaScriptCore.xcodeproj/project.pbxproj: Removed references

to JavaScriptCore.JSVALUE32only.exp.

10:02 AM Changeset in webkit [77637] by Dimitri Glazkov

2 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Tweak expectations for passing tests.

platform/chromium/test_expectations.txt: More tweakage.

10:01 AM Changeset in webkit [77636] by Adam Roben

2 edits in trunk/Tools

Include the crashing function in the link to a crash log on Mac

Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
function that crashed on Mac

Reviewed by David Kilzer.

Scripts/old-run-webkit-tests:

(crashLocation): Moved all the Windows code inside an if instead of using an early return,
but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
the crash log.

9:31 AM Changeset in webkit [77635] by ddkilzer@apple.com

2 edits in trunk/Source/JavaScriptCore

Use static_cast and other style cleanup in YarrInterpreter.cpp
<http://webkit.org/b/53772>

Reviewed by John Sullivan.

yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::InputStream::readChecked): Use
static_cast.
(JSC::Yarr::Interpreter::InputStream::checkInput): Remove
unnecessary else block.
(JSC::Yarr::Interpreter::matchAssertionEOL): Ditto.
(JSC::Yarr::Interpreter::backtrackBackReference): Ditto.
(JSC::Yarr::ByteCompiler::emitDisjunction): Use static_cast.

9:20 AM Changeset in webkit [77634] by Dimitri Glazkov

2 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Remove more passing tests.

platform/chromium/test_expectations.txt: Even more passages removed.

9:07 AM Changeset in webkit [77633] by Adam Roben

2 edits in trunk/Tools

Link to Mac crash logs from results.html

Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
results.html

Reviewed by David Kilzer.

Scripts/old-run-webkit-tests:

(captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.

9:05 AM Changeset in webkit [77632] by Dimitri Glazkov

2 edits in trunk/LayoutTests

2011-02-04 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Removed passing tests.

platform/chromium/test_expectations.txt: Passages removed.

8:38 AM Changeset in webkit [77631] by podivilov@chromium.org

2 edits in trunk/Source/WebCore

2011-02-04 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: evaluate on hover does not work on a breakpoint.
https://bugs.webkit.org/show_bug.cgi?id=53768

inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._mouseHover):

8:28 AM Changeset in webkit [77630] by loislo@chromium.org

23 edits
2 adds
4 deletes in trunk/Source

2011-02-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77625 and r77626.
http://trac.webkit.org/changeset/77625
http://trac.webkit.org/changeset/77626
https://bugs.webkit.org/show_bug.cgi?id=53765

It broke Windows builds (Requested by Ossy_ on #webkit).

Android.jscbindings.mk:
CMakeLists.txt:
ForwardingHeaders/pcre/pcre.h: Added.
ForwardingHeaders/yarr/Yarr.h: Removed.
ForwardingHeaders/yarr/YarrInterpreter.h: Removed.
ForwardingHeaders/yarr/YarrPattern.h: Removed.
WebCore.gyp/WebCore.gyp:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcproj/copyForwardingHeaders.cmd:
platform/text/RegularExpression.cpp: (WebCore::RegularExpression::Private::regexp): (WebCore::RegularExpression::Private::compile): (WebCore::RegularExpression::Private::Private): (WebCore::RegularExpression::Private::create): (WebCore::RegularExpression::Private::~Private): (WebCore::RegularExpression::match):

2011-02-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77625 and r77626.
http://trac.webkit.org/changeset/77625
http://trac.webkit.org/changeset/77626
https://bugs.webkit.org/show_bug.cgi?id=53765

It broke Windows builds (Requested by Ossy_ on #webkit).

JavaScriptCore.exp:
JavaScriptCore.gyp/JavaScriptCore.gyp:
JavaScriptCore.gypi:
JavaScriptCore.pro:
JavaScriptCore.xcodeproj/project.pbxproj:
create_regex_tables:
runtime/RegExp.cpp:
wtf/Platform.h:
yarr/Yarr.h:
yarr/YarrJIT.cpp:
yarr/YarrJIT.h:
yarr/YarrParser.h:
yarr/YarrPattern.h:
yarr/YarrSyntaxChecker.h:
yarr/yarr.pri: Removed.

8:24 AM Changeset in webkit [77629] by mnaganov@chromium.org

1 edit in branches/chromium/648/Source/WebCore/inspector/front-end/NetworkPanel.js

Merge 77623 - 2011-02-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Network panel filtering is broken.
https://bugs.webkit.org/show_bug.cgi?id=53764

inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._sortItems): (WebInspector.NetworkPanel.prototype._sortByTimeline): (WebInspector.NetworkPanel.prototype._filter): (WebInspector.NetworkPanel.prototype._updateOffscreenRows): (WebInspector.NetworkDataGridNode.prototype.isFilteredOut): (WebInspector.NetworkDataGridNode.prototype.get selectable): (WebInspector.NetworkTotalGridNode.prototype.isFilteredOut): (WebInspector.NetworkTotalGridNode.prototype.get selectable):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/6286112

7:51 AM Changeset in webkit [77628] by jberlin@webkit.org

2 edits in trunk/Source/JavaScriptCore

Windows build fix. Unreviewed.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:

7:21 AM Changeset in webkit [77627] by jberlin@webkit.org

2 edits in trunk/LayoutTests

[Windows 7 Release Tests] transitions/transition-end-event-multiple-04.html flakey
https://bugs.webkit.org/show_bug.cgi?id=53332

Unreviewed, attempt to get the Windows 7 Release bots uniformly green.

platform/win/Skipped:

6:54 AM Changeset in webkit [77626] by pvarga@webkit.org

2 edits in trunk/Source/WebCore

2011-02-04 Peter Varga <pvarga@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

Replace PCRE with Yarr in WebCore
https://bugs.webkit.org/show_bug.cgi?id=53496

Speculative windows build fix.

No new tests needed.

platform/text/RegularExpression.cpp:

6:29 AM Changeset in webkit [77625] by pvarga@webkit.org

23 edits
5 adds
1 delete in trunk/Source

2011-02-04 Peter Varga <pvarga@webkit.org>

Reviewed by Gavin Barraclough.

Replace PCRE with Yarr in WebCore
https://bugs.webkit.org/show_bug.cgi?id=53496

JavaScriptCore.exp:
JavaScriptCore.gyp/JavaScriptCore.gyp:
JavaScriptCore.gypi:
JavaScriptCore.pro:
JavaScriptCore.xcodeproj/project.pbxproj:
create_regex_tables:
runtime/RegExp.cpp:
wtf/Platform.h:
yarr/Yarr.h:
yarr/YarrJIT.cpp:
yarr/YarrJIT.h:
yarr/YarrParser.h:
yarr/YarrPattern.h:
yarr/YarrSyntaxChecker.h:
yarr/yarr.pri: Added.

2011-02-04 Peter Varga <pvarga@webkit.org>

Reviewed by Gavin Barraclough.

Replace PCRE with Yarr in WebCore
https://bugs.webkit.org/show_bug.cgi?id=53496

No new tests needed.

Android.jscbindings.mk:
CMakeLists.txt:
ForwardingHeaders/pcre/pcre.h: Removed.
ForwardingHeaders/yarr/Yarr.h: Added.
ForwardingHeaders/yarr/YarrInterpreter.h: Added.
ForwardingHeaders/yarr/YarrPattern.h: Added.
WebCore.gyp/WebCore.gyp:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcproj/copyForwardingHeaders.cmd:
platform/text/RegularExpression.cpp: (WebCore::RegularExpression::Private::create): (WebCore::RegularExpression::Private::Private): (WebCore::RegularExpression::Private::compile): (WebCore::RegularExpression::match):

6:27 AM Changeset in webkit [77624] by loislo@chromium.org

1 edit
8 adds in trunk/LayoutTests

2011-02-04 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed.

Rebaseline. The problem was introduced at r77601.

platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.checksum: Added.
platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Added.
platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Added.
platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.checksum: Added.
platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png: Added.

6:22 AM Changeset in webkit [77623] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

2011-02-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Network panel filtering is broken.
https://bugs.webkit.org/show_bug.cgi?id=53764

inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._sortItems): (WebInspector.NetworkPanel.prototype._sortByTimeline): (WebInspector.NetworkPanel.prototype._filter): (WebInspector.NetworkPanel.prototype._updateOffscreenRows): (WebInspector.NetworkDataGridNode.prototype.isFilteredOut): (WebInspector.NetworkDataGridNode.prototype.get selectable): (WebInspector.NetworkTotalGridNode.prototype.isFilteredOut): (WebInspector.NetworkTotalGridNode.prototype.get selectable):

5:47 AM Changeset in webkit [77622] by loislo@chromium.org

1 edit
4 adds in trunk/LayoutTests

2011-02-04 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed.

Rebaseline image for fast/box-shadow/shadow-tiling-artifact.html
The problem was introduced at r77601.

platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.checksum: Added.
platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.png: Added.
platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.checksum: Added.
platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.png: Added.

5:32 AM Changeset in webkit [77621] by sergio@webkit.org

1 edit
10 adds in trunk/LayoutTests

2011-02-04 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

New test expectations.

platform/gtk/fast/box-shadow/shadow-tiling-artifact-expected.txt: Added.
platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt: Added.
platform/gtk/svg/text/font-size-below-point-five-2-expected.txt: Added.
platform/gtk/svg/text/font-size-below-point-five-expected.txt: Added.
platform/gtk/svg/text/scaled-font-expected.txt: Added.
platform/gtk/svg/text/small-fonts-2-expected.txt: Added.
platform/gtk/svg/text/small-fonts-3-expected.txt: Added.
platform/gtk/svg/text/small-fonts-expected.txt: Added.
platform/gtk/svg/text/small-fonts-in-html5-expected.txt: Added.

5:25 AM Changeset in webkit [77620] by caseq@chromium.org

8 edits in trunk

2011-02-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: support overriding user agent strings
https://bugs.webkit.org/show_bug.cgi?id=51485

Test: http/tests/inspector/extensions-useragent.html

inspector/Inspector.idl:
inspector/InspectorController.cpp: (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::setUserAgentOverride): (WebCore::InspectorController::userAgentOverride):
inspector/InspectorController.h:
inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.InspectedWindow.prototype.reload):
inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onReload):
loader/FrameLoader.cpp: (WebCore::FrameLoader::userAgent): (WebCore::FrameLoader::applyUserAgent):

2011-02-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: support overriding user agent strings
https://bugs.webkit.org/show_bug.cgi?id=51485

http/tests/inspector/extensions-useragent-expected.txt: Added.
http/tests/inspector/extensions-useragent.html: Added.

5:03 AM Changeset in webkit [77619] by loislo@chromium.org

5 edits in trunk/Source/JavaScriptCore

2011-02-04 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed rollout two patches r77614 and r77612.

REGRESSION: Snow Leopard Intell Release anumber of failing tests.

runtime/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::reset):
runtime/Heap.h:
runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::sweep): (JSC::MarkedSpace::reset):
runtime/MarkedSpace.h:

4:40 AM Changeset in webkit [77618] by podivilov@chromium.org

2 edits in trunk/Source/WebCore

2011-02-04 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: scripts panel displays wrong file name after reload.
https://bugs.webkit.org/show_bug.cgi?id=53761

inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):

3:34 AM Changeset in webkit [77617] by yurys@chromium.org

27 edits in trunk/Source

2011-02-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686

WebCore.exp.in:
inspector/CodeGeneratorInspector.pm:
inspector/InspectorClient.h:
inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight): (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
inspector/InspectorFrontendClientLocal.h: ports that provide in-process implementation of the inspector front-end can provide platform-specific settings accessor. (WebCore::InspectorFrontendClientLocal::Settings::Settings): (WebCore::InspectorFrontendClientLocal::Settings::~Settings): (WebCore::InspectorFrontendClientLocal::Settings::inspectorAttachedHeight): (WebCore::InspectorFrontendClientLocal::Settings::storeInspectorAttachedHeight):
loader/EmptyClients.h:

2011-02-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686

WebCoreSupport/WebInspectorClientCF.cpp: (populateSetting): (storeSetting): (WebInspectorClient::createFrontendSettings):

2011-02-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686

WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorFrontendClient::InspectorFrontendClient):
WebCoreSupport/InspectorClientGtk.h:

2011-02-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686

WebCoreSupport/WebInspectorClient.h:
WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::openInspectorFrontend): (WebInspectorFrontendClient::WebInspectorFrontendClient):

2011-02-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686

WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorFrontendClientQt::InspectorFrontendClientQt):
WebCoreSupport/InspectorClientQt.h:

2011-02-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686

WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::openInspectorFrontend): (WebInspectorFrontendClient::WebInspectorFrontendClient):
WebCoreSupport/WebInspectorClient.h:

2011-02-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686

WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp: (WebKit::WebInspectorFrontendClient::WebInspectorFrontendClient):

2:32 AM Changeset in webkit [77616] by sergio@webkit.org

2 edits in trunk/LayoutTests

2011-02-04 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Skipping fast/events/pagehide-timeout.html that is failing on GTK
bots. See https://bugs.webkit.org/show_bug.cgi?id=53733

platform/gtk/Skipped: skip fast/events/pagehide-timeout.html

12:49 AM Changeset in webkit [77615] by loislo@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-02-04 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed.

Roll chromium to 73764.

DEPS:

12:12 AM Changeset in webkit [77614] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

Try to fix 32bit build.

runtime/Heap.cpp:

(JSC::Heap::reset): Use an explicit cast to avoid shortening warnings,
since 1.5 is double (64bit), and the result is size_t (32bit).

Feb 3, 2011:

11:50 PM Changeset in webkit [77613] by antonm@chromium.org

3 edits in trunk/Source/WebCore

2011-02-03 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] frame several more JS code invocations into v8::TryCatch
https://bugs.webkit.org/show_bug.cgi?id=53594

This patch is preemptive and adjusts v8 bindings code to forthcoming small change
in v8::ThrowException---currently sometimes exceptions thrown by this method
do not reach surrounding v8::TryCatch handler (see
http://code.google.com/p/v8/issues/detail?id=1072 and
http://codereview.chromium.org/6397011/). Therefore the goal of this patch
is to make forthcoming v8 roll as smooth as possible (alas, we'll still need
one rebaseline as of now.)

bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::runScript): Do not rely on empty handle as a signal of exception, wrap into v8::TryCatch instead
bindings/v8/V8WindowErrorHandler.cpp: (WebCore::V8WindowErrorHandler::callListenerFunction): Ditto

11:41 PM Changeset in webkit [77612] by ggaren@apple.com

5 edits in trunk/Source/JavaScriptCore

2011-02-03 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.

Changed MarkedSpace to delegate grow/shrink decisions to Heap
https://bugs.webkit.org/show_bug.cgi?id=53759

SunSpider reports no change.

runtime/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::reset):
runtime/Heap.h: Reorganized a few data members for better cache locality. Added a grow policy.

runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::sweep): (JSC::MarkedSpace::reset): Don't shrink automatically. Instead, wait for the heap to make an explicit sweep call.

runtime/MarkedSpace.h: (JSC::MarkedSpace::highWaterMark): (JSC::MarkedSpace::setHighWaterMark): Use a watermark to determine how many bytes to allocate before failing and giving the heap an opportunity to collect garbage. This also means that we allocate blocks on demand, instead of ahead of time.

11:27 PM Changeset in webkit [77611] by mjs@apple.com

11 edits in trunk

2011-02-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
https://bugs.webkit.org/show_bug.cgi?id=52897
<rdar://problem/8898294>

WebCore.exp.in: Add export now needed by WebKit2

2011-02-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
https://bugs.webkit.org/show_bug.cgi?id=52897
<rdar://problem/8898294>

Shared/API/c/WKSharedAPICast.h: (WebKit::toAPI):
WebProcess/InjectedBundle/API/c/WKBundlePage.h:
WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp: (WebKit::InjectedBundlePageLoaderClient::willSendRequestForFrame):
WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchWillSendRequest):

2011-02-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
https://bugs.webkit.org/show_bug.cgi?id=52897
<rdar://problem/8898294>

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::willSendRequestForFrame):
WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

11:00 PM Changeset in webkit [77610] by ike@apple.com

3 edits in trunk/Source/WebKit2

2011-02-03 Ivan Krstić <ike@apple.com>

Reviewed by Maciej Stachowiak.

Make WebProcess pass explicit homedir parameter to the sandbox
<rdar://problem/8405760>
<https://webkit.org/b/53558>

WebProcess/com.apple.WebProcess.sb:
WebProcess/mac/WebProcessMac.mm: (WebKit::initializeSandbox):

10:54 PM Changeset in webkit [77609] by ike@apple.com

2 edits in trunk/Tools

2011-02-03 Ivan Krstić <ike@apple.com>

Unreviewed.

Adding myself to committers.py.

Scripts/webkitpy/common/config/committers.py:

10:46 PM Changeset in webkit [77608] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

2011-02-03 Victoria Kirst <vrk@google.com>

Reviewed by James Robinson.

Replaces float literals with uniform values in shader code
so that buggy drivers unable to parse float values in different
locales will not produce a pink video.

[chromium] Fix pink video bug with gpu-acceleration enabled
https://bugs.webkit.org/show_bug.cgi?id=53568

platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::SharedValues::SharedValues): (WebCore::VideoLayerChromium::drawYUV):
platform/graphics/chromium/VideoLayerChromium.h: (WebCore::VideoLayerChromium::SharedValues::signAdjLocation):

10:31 PM Changeset in webkit [77607] by levin@chromium.org

26 edits
2 adds in trunk

Add navigator.registerProtocolHandler behind a flag.
https://bugs.webkit.org/show_bug.cgi?id=52609

Patch by James Kozianski <koz@chromium.org> on 2011-02-03
Reviewed by Dimitri Glazkov.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

This method is described in the HTML5 specification here,
http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registerprotocolhandler

This change is largely cribbed from B. Green's 29651 patches. It is
behind a flag so as not to break JS feature detection.

New layout test fast/dom/registerProtocolHandler.html.

Configurations/FeatureDefines.xcconfig:
loader/EmptyClients.h:

(WebCore::EmptyChromeClient::registerProtocolHandler):

page/Chrome.cpp:

(WebCore::Chrome::registerProtocolHandler):

page/Chrome.h:
page/ChromeClient.h:
page/Navigator.cpp:

(WebCore::verifyCustomHandlerURL):
(WebCore::verifyProtocolHandlerScheme):
(WebCore::Navigator::registerProtocolHandler):

page/Navigator.h:
page/Navigator.idl:

Source/WebKit/chromium:

features.gypi:
public/WebViewClient.h:
src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::registerProtocolHandler):

src/ChromeClientImpl.h:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Tools:

Scripts/build-webkit:

WebKitLibraries:

win/tools/vsprops/FeatureDefines.vsprops:
win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

fast/dom/register-protocol-handler-expected.txt: Added.
fast/dom/register-protocol-handler.html: Added.

10:26 PM Changeset in webkit [77606] by hayato@chromium.org

7 edits in trunk/Tools

2011-02-03 Hayato Ito <hayato@chromium.org>

Reviewed by Eric Seidel.

[NRWT] Remove TestArgs class, which is wrongly used.

https://bugs.webkit.org/show_bug.cgi?id=53063

Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
Scripts/webkitpy/layout_tests/test_types/image_diff.py:
Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
Scripts/webkitpy/layout_tests/test_types/text_diff.py:

9:45 PM Changeset in webkit [77605] by commit-queue@webkit.org

2 edits in trunk/Tools

2011-02-03 Andrew Wason <rectalogic@rectalogic.com>

Reviewed by Kenneth Russell.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=53714

Scripts/build-webkit: change --3d-canvas build option to set ENABLE_WEBGL

9:38 PM Changeset in webkit [77604] by commit-queue@webkit.org

6 edits in trunk/Source

2011-02-03 Brian Ryner <bryner@chromium.org>

Reviewed by Darin Fisher.

Add a field to the ResourceResponse for tracking the socket address
of the host that the resource was fetched from. Patch was originally
by Paul Marks.
https://bugs.webkit.org/show_bug.cgi?id=53699

platform/network/chromium/ResourceResponse.cpp: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::socketAddress): (WebCore::ResourceResponse::setSocketAddress):

2011-02-03 Brian Ryner <bryner@chromium.org>

Reviewed by Darin Fisher.

Add a field to the ResourceResponse for tracking the socket address
of the host that the resource was fetched from. Patch was originally
by Paul Marks.
https://bugs.webkit.org/show_bug.cgi?id=53699

public/WebURLResponse.h:
src/WebURLResponse.cpp: (WebKit::WebURLResponse::socketAddress): (WebKit::WebURLResponse::setSocketAddress):

9:36 PM Changeset in webkit [77603] by hayato@chromium.org

11 edits
1 add
1 delete in trunk/Tools

2011-02-03 Hayato Ito <hayato@chromium.org>

Reviewed by Tony Chang.

[NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
move _run_single_test() and _process_output() functions from
dump_render_tree_thread.py to a single_test_runner.py as an individual module.

This is clean up and acts as a preparation for elimination of test_types/*
classes. These classes will move to the single_test_runner module introduced
in this patch.

https://bugs.webkit.org/show_bug.cgi?id=53004

Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
Scripts/webkitpy/layout_tests/layout_package/test_input.py:
Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/chromium.py:
Scripts/webkitpy/layout_tests/port/dryrun.py:
Scripts/webkitpy/layout_tests/port/test.py:
Scripts/webkitpy/layout_tests/port/webkit.py:
Scripts/webkitpy/layout_tests/test_types/image_diff.py:
Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
Scripts/webkitpy/layout_tests/test_types/text_diff.py:

9:30 PM Changeset in webkit [77602] by agl@chromium.org

34 edits in trunk

2011-02-03 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384

Regressions covered by http/tests/security/mixedContent/*

loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::didRunInsecureContent):
loader/FrameLoader.cpp: (WebCore::FrameLoader::checkIfRunInsecureContent):
loader/FrameLoaderClient.h:

2011-02-03 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384

Regressions covered by http/tests/security/mixedContent/*

public/WebFrameClient.h: (WebKit::WebFrameClient::didRunInsecureContent):
src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::didRunInsecureContent):
src/FrameLoaderClientImpl.h:

2011-02-03 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384

Regressions covered by http/tests/security/mixedContent/*

WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::didRunInsecureContent):
WebCoreSupport/FrameLoaderClientEfl.h:

2011-02-03 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384

Regressions covered by http/tests/security/mixedContent/*

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::didRunInsecureContent):
WebCoreSupport/FrameLoaderClientGtk.h:

2011-02-03 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384

Regressions covered by http/tests/security/mixedContent/*

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didRunInsecureContent):

2011-02-03 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384

Regressions covered by http/tests/security/mixedContent/*

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::didRunInsecureContent):
WebCoreSupport/FrameLoaderClientQt.h:

2011-02-03 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384

Regressions covered by http/tests/security/mixedContent/*

WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::didRunInsecureContent):
WebCoreSupport/WebFrameLoaderClient.h:

2011-02-03 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384

Regressions covered by http/tests/security/mixedContent/*

WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::didRunInsecureContent):
WebCoreSupport/FrameLoaderClientWinCE.h:

2011-02-03 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384

Regressions covered by http/tests/security/mixedContent/*

WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::didRunInsecureContent):
WebKitSupport/FrameLoaderClientWx.h:

2011-02-03 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384

Regressions covered by http/tests/security/mixedContent/*

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::didRunInsecureContent):
WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

9:28 PM Changeset in webkit [77601] by Simon Fraser

3 edits
4 adds in trunk

2011-02-03 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

REGRESSION: Artifacts on box-shadow corners in some cases
https://bugs.webkit.org/show_bug.cgi?id=53731

Fix overdrawing artifacts in ShadowBlur's tiling code path,
which show up in shadows using a color with alpha.

Test: fast/box-shadow/shadow-tiling-artifact.html

platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::drawRectShadowWithTiling): Ensure that the inner rect that gets filled does not overlap with any of the eight tiled areas by having the corner and side dimensions be the same for contiguous areas.

9:26 PM Changeset in webkit [77600] by abarth@webkit.org

2 edits in trunk/Source/WebCore

2011-02-03 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

XSS Auditor is spinning inside decodeURLEscapeSequences() if there are
percent signs in large posted data
https://bugs.webkit.org/show_bug.cgi?id=53405

If the input string contains many non-% characters followed by a %
character that is not a valid URL escape sequence, then the old
algorithm would only advance the initial search by one character
(instead of jumping to just after the % character). That would cause
the algorithm to take N^{2 time (in the number of characters before the

first % character). This patch just advances the search past the first

% character so we can start looking for next % character sooner.}

platform/KURL.cpp: (WebCore::decodeURLEscapeSequences):

9:20 PM Changeset in webkit [77599] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/chromium

2011-02-03 Victoria Kirst <vrk@google.com>

Reviewed by James Robinson.

[chromium] Fix redundant video frame paint on CSS LayerChromium for <video>
https://bugs.webkit.org/show_bug.cgi?id=52868

src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::paint): (WebKit::WebMediaPlayerClientImpl::paintCurrentFrameInContext): (WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
src/WebMediaPlayerClientImpl.h:

9:08 PM Changeset in webkit [77598] by podivilov@chromium.org

2 edits in trunk/Source/WebCore

2011-02-03 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: click on a breakpoint highlights wrong line in source frame.
https://bugs.webkit.org/show_bug.cgi?id=53692

inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setupBreakpointElement):

9:04 PM Changeset in webkit [77597] by antonm@chromium.org

3 edits in trunk/Source/WebCore

2011-02-03 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Bail out if to string conversion returned empty handle
https://bugs.webkit.org/show_bug.cgi?id=53687

This a temporary measure: actually one probably should never get empty handle
if there was no exception. The root cause is under investigation.
The bailout though allows Chromium not to crash---attempt to convert an empty
v8 hande into WebCore string crashes with invalid memory access.

See http://code.google.com/p/chromium/issues/detail?id=71544

There is no known reduction expressible as a layout test so far. The crash found with automated testing tools.

bindings/v8/V8Binding.cpp: (WebCore::v8NonStringValueToWebCoreString): Bail out on empty handle
bindings/v8/V8Binding.h: (WebCore::V8ParameterBase::prepareBase): Ditto

9:03 PM Changeset in webkit [77596] by joone.hur@collabora.co.uk

3 edits in trunk/Source/WebKit/gtk

2011-02-03 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[Gtk] No need to set text encoding in the provisional phase
https://bugs.webkit.org/show_bug.cgi?id=53487

According to changeset 67253, setEncoding could be called multiple times from
committedLoad, finishedLoading, dispatchDidFailLoading, and setMainDocumentError
in FrameLoaderClient. To fix this, the relevant code was removed from
FrameLoaderClient and moved to DocumentLoader::commitData. However, that
code was not removed from FrameLoaderClient::finishedLoading in WebKitGtk+.

Due to this reason, after loading a html document, other ports initialize the
text encoding from FrameLoaderClient::finishedLoading, but WebKitGtk+ sets
the same encoding again, even tries to set encoding in the provisional phase.
This causes unnecessary encoding setting.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::FrameLoaderClient): Set m_hasRepresentation to false. (WebKit::FrameLoaderClient::makeRepresentation): Set m_hasRepresentation to true. (WebKit::FrameLoaderClient::revertToProvisionalState): Set m_hasRepresentation to true. (WebKit::FrameLoaderClient::finishedLoading): Skip the encoding setting when m_hasRepresentation is false.
WebCoreSupport/FrameLoaderClientGtk.h: Added m_hasRepresentation.

8:53 PM Changeset in webkit [77595] by dpranke@chromium.org

2 edits in trunk/Tools

2011-02-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Delete a line that was accidentally missed in r77586; without it
there is still a race between the two threads.

https://bugs.webkit.org/show_bug.cgi?id=51572

Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:

8:32 PM Changeset in webkit [77594] by levin@chromium.org

3 edits in trunk/LayoutTests

worker-importScriptsOnError needs to allow for the console error to
flush out before calling notifyDone.

Reviewed by Adam Barth.

http/tests/workers/worker-importScriptsOnError-expected.txt:
http/tests/workers/worker-importScriptsOnError.html:

8:24 PM Changeset in webkit [77593] by abarth@webkit.org

1 edit
3 adds in trunk/PerformanceTests

2011-02-03 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Add another XSSFilter PerformanceTest
https://bugs.webkit.org/show_bug.cgi?id=53750

This PerformanceTest tests the case that was slow in
https://bugs.webkit.org/show_bug.cgi?id=49845

XSSFilter/large-post-many-inline-scripts-and-events.html: Added.
XSSFilter/resources: Added.
XSSFilter/resources/target-for-large-post-many-inline-scripts-and-events.html: Added.

8:07 PM Changeset in webkit [77592] by dpranke@chromium.org

2 edits
1 add in trunk/Tools

2011-02-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt: handle "broken pipe" notifications from DRT more cleanly.

https://bugs.webkit.org/show_bug.cgi?id=52927

Scripts/webkitpy/layout_tests/port/server_process.py:
Scripts/webkitpy/layout_tests/port/server_process_unittest.py:

8:05 PM Changeset in webkit [77591] by abarth@webkit.org

2 edits in trunk/Source/WebCore

2011-02-03 Adam Barth <abarth@webkit.org>

Attempt to fix Chromium build.

html/parser/XSSFilter.cpp:

8:02 PM Changeset in webkit [77590] by abarth@webkit.org

1 edit
2 adds in trunk/PerformanceTests

2011-02-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add PerformanceTest for XSSFilter
https://bugs.webkit.org/show_bug.cgi?id=53741

This performance tests covers the case of a large POST data and many
small event handlers.

XSSFilter: Added.
XSSFilter/large-post-many-events.html: Added.

7:59 PM Changeset in webkit [77589] by dpranke@chromium.org

2 edits
1 delete in trunk/Source/WebCore

2011-02-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, rolling out r77562.
http://trac.webkit.org/changeset/77562
https://bugs.webkit.org/show_bug.cgi?id=53630

broke chromium mac build

WebCore.gyp/WebCore.gyp:
WebCore.gyp/mac/check_objc_rename.sh: Removed.

7:56 PM Changeset in webkit [77588] by abarth@webkit.org

22 edits in trunk

2011-02-03 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

XSS Auditor severely affects loading performance after submitting a large form
https://bugs.webkit.org/show_bug.cgi?id=49845

The XSSFilter catches some more cases and has different console
messages than the XSSAuditor. We might want to improve these messages
in the future.

http/tests/security/xssAuditor/base-href-control-char-expected.txt:
http/tests/security/xssAuditor/base-href-expected.txt:
http/tests/security/xssAuditor/base-href-null-char-expected.txt:
http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
http/tests/security/xssAuditor/dom-write-innerHTML-expected.txt:
http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
http/tests/security/xssAuditor/embed-tag-expected.txt:
http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
http/tests/security/xssAuditor/full-block-base-href-expected.txt:
http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
http/tests/security/xssAuditor/object-embed-tag-expected.txt:
http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
http/tests/security/xssAuditor/object-tag-expected.txt:
http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:

2011-02-03 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

XSS Auditor severely affects loading performance after submitting a large form
https://bugs.webkit.org/show_bug.cgi?id=49845

Switch over from the XSSAuditor to the XSSFilter, improving performance
on this example.

html/parser/XSSFilter.cpp: (WebCore::XSSFilter::filterToken):
page/XSSAuditor.cpp: (WebCore::XSSAuditor::isEnabled):

7:30 PM Changeset in webkit [77587] by dpranke@chromium.org

2 edits in trunk/Source/WebCore

2011-02-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, rolling out r77567.
http://trac.webkit.org/changeset/77567
https://bugs.webkit.org/show_bug.cgi?id=53468

broke chromium linux svg, canvas tests, possibly win also?

platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):

7:12 PM Changeset in webkit [77586] by dpranke@chromium.org

3 edits in trunk/Tools

2011-02-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Kenneth Russell.

Update, resubmit change to bug 51572. I think the race that was
fixed in r76703 caused the hang that caused us to roll this
patch out before, so I'd like to try again.

https://bugs.webkit.org/show_bug.cgi?id=51572

Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:

6:59 PM Changeset in webkit [77585] by jhoneycutt@apple.com

8 edits
1 copy
1 add in trunk/Source/WebKit2

Download bundles should be moved to their final destination when they
finish.

https://bugs.webkit.org/show_bug.cgi?id=53668

Reviewed by Adam Roben.

WebProcess/Downloads/Download.cpp:

(WebKit::Download::Download):
Initialize m_allowOverwrite.
(WebKit::Download::retrieveDestinationWithSuggestedFilename):
Return the result of requesting the destination filename from the UI
process.
(WebKit::Download::decideDestinationWithSuggestedFilename):
Call retrieveDestinationWithSuggestedFilename().
(WebKit::Download::didFinish):
Call platformDidFinish().

WebProcess/Downloads/Download.h:

Declare retrieveDestinationWithSuggestedFilename() and
platformDidFinish(). Add a member variable to store whether the UI
process would like us to overwrite existing files.

WebProcess/Downloads/cf/DownloadCFNet.cpp:

(WebKit::willResumeWithResponseCallback):
Remove some trailing whitespace.

WebProcess/Downloads/curl/DownloadCurl.cpp:

(WebKit::Download::platformDidFinish):
Stubbed.

WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::Download::platformDidFinish):
Stubbed.

WebProcess/Downloads/qt/DownloadQt.cpp:

(WebKit::Download::platformDidFinish):
Stubbed.

WebProcess/Downloads/cf/win/DownloadCFNetWin.cpp:

(WebKit::Download::didDecideDestination):
Store whether the UI process would like us to overwrite existing files.
(WebKit::Download::platformDidFinish):
Try to move the bundle to the final destination. If that fails, ask the
UI process for a new destination. If we receive one, try again to move
the bundle. Call didCreateDestination() to report the updated path of
file whether it's the bundle that we failed to move, or the new final
destination.

This is similar to what is done by WebKit 1's CFNetwork port.

win/WebKit2.vcproj:

Add DownloadWin.cpp.

6:57 PM Changeset in webkit [77584] by jhoneycutt@apple.com

2 edits in trunk/Source/WebKit2

Small clean-up in DownloadCFNet.cpp.

Rubber-stamped by Mark Rowe.

WebProcess/Downloads/cf/DownloadCFNet.cpp:

(WebKit::Download::didDecideDestination):
Moved out of the section labeled "CFURLDownload callbacks" and up near
the other member functions.

6:56 PM Changeset in webkit [77583] by mjs@apple.com

2 edits in trunk/LayoutTests

2011-02-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Daniel Bates.

Skip a test for WebKit2 that uses missing DRT API
https://bugs.webkit.org/show_bug.cgi?id=53748

platform/mac-wk2/Skipped:

5:58 PM Changeset in webkit [77582] by mrowe@apple.com

5 edits in branches/safari-533.20-branch

Versioning.

5:58 PM Changeset in webkit [77581] by mrowe@apple.com

1 copy in tags/Safari-533.20.23

New tag.

5:58 PM Changeset in webkit [77580] by mrowe@apple.com

2 edits in branches/safari-533.20-branch/WebCore

Build fix.

plugins/PluginView.cpp:

(WebCore::PluginView::start):
(WebCore::PluginView::getURLNotify):
(WebCore::PluginView::getURL):
(WebCore::PluginView::handlePost):

5:56 PM Changeset in webkit [77579] by inferno@chromium.org

1 edit
1 add in trunk/LayoutTests

2011-02-03 Abhishek Arya <inferno@chromium.org>

Unreviewed, simple qt test baseline.

platform/qt/fast/overflow/overflow-height-float-not-removed-crash-expected.txt: Added.

5:45 PM Changeset in webkit [77578] by morrita@google.com

13 edits
1 add in trunk

2011-02-02 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

Refactoring: <progress> should not use ShadowElement
https://bugs.webkit.org/show_bug.cgi?id=53583

Updated to catch the change on -webkit-progress-bar-value interpretation.

fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html:

2011-02-02 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

Refactoring: <progress> should not use ShadowElement
https://bugs.webkit.org/show_bug.cgi?id=53583

Introduced RenderIndicatorPart and RenderProgressBarValuePart to be responsible for bar-part layout, which adopted layout logic from ShadowBlockElement.
ProgressBarValueElement is no longer a subclass of ShadowBlockElement.
Remove dependency from RenderProgress to HTMLProgressElement and ShadowBlockElement.
The shadow tree is no longer removed on detach(). It becomes persistent. This is now possible because the ShadowBlockElement dependency is gone.
::-webkit-appearance for -webkit-progress-bar-value is no longer referred. That didn't make sense.

html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::createShadowSubtreeIfNeeded):
html/HTMLProgressElement.h:
html/shadow/ProgressBarValueElement.h: Added. (WebCore::ProgressBarValueElement::ProgressBarValueElement): (WebCore::ProgressBarValueElement::shadowPseudoId): (WebCore::ProgressBarValueElement::createRenderer): (WebCore::ProgressBarValueElement::create):
rendering/RenderIndicator.cpp: (WebCore::RenderIndicatorPart::RenderIndicatorPart): (WebCore::RenderIndicatorPart::~RenderIndicatorPart): (WebCore::RenderIndicatorPart::layout): (WebCore::RenderIndicatorPart::styleDidChange):
rendering/RenderIndicator.h: Added RenderIndicatorPart class (WebCore::RenderIndicatorPart::originalVisibility): (WebCore::RenderIndicatorPart::requiresForcedStyleRecalcPropagation): (WebCore::RenderIndicatorPart::canHaveChildren):
rendering/RenderProgress.cpp: (WebCore::RenderProgressBarValuePart::preferredFrameRect): (WebCore::RenderProgressBarValuePart::shouldBeHidden): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::layoutParts): (WebCore::RenderProgress::shouldHaveParts):
rendering/RenderProgress.h: (WebCore::RenderProgressBarValuePart::RenderProgressBarValuePart):

5:40 PM Changeset in webkit [77577] by mitz@apple.com

33 edits
1 add in trunk

Reversion should not be marked as misspelled.
https://bugs.webkit.org/show_bug.cgi?id=53255

Source/WebCore:

Patch by Jia Pu <jpu@apple.com> on 2011-02-03
This patch includes fix for reported bug, and also some housekeeping changes.

To implement desired behavior, we need:

Add a new marker type, SpellCheckingExemption, since now we distingusish between text that shouldn't be spellchecked and text shouldn't be autocorrected.
Make sure that there is no pending correction panel when we enter markAllMisspellingsAndBadGrammarInRanges(). Otherwise the spell checking code in that function may interfere with autocorrection. This is achieved by explicitly applying pending correction when user types space, line break or paragraph break.

Housekeeping code changes include:

Change manual-tests that were broken by relocated WebCore directory.
Use TextIterator in various DocumentMarkerController functions instead of using Node::traverseNextNode() directly.
Allow passing multiple marker types into DocumentMarkerController::removeMarkers() and DocumentMarkerController::hasMarkers() to improve clarity and efficiency.
Fixes of minor bugs that were exposed previously.

WebCore.exp.in: Change signature of DocumentMarkerController::removeMarkers().

dom/DocumentMarker.h: Added new marker type SpellCheckingExemption.

dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::removeMarkers): Use TextIterator to scan the range to be

consistent with addMarker() function. Allow passing in multiple marker types in one call.
Added a boolean argument to specify the behavior when removing markers that partially
overlap the specified range.

(WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair): Allow passing in

multiple marker types in one call.

(WebCore::DocumentMarkerController::hasMarkers): Use TextIterator to scan the range to be

consistent with addMarker() function. Allow passing in multiple marker types in one call.

dom/DocumentMarkerController.h: Allow passing in multiple marker types to removeMarkers()

and hasMarkers(). Added a boolean argument to removeMarkers() to specify the behavior when
removing markers that partially overlap the specified range.

editing/Editor.cpp:

(WebCore::markerTypesForAutocorrection): Add SpellCheckingExemption marker when apply correction.
(WebCore::markerTypesForReplacement): Ditto.
(WebCore::Editor::respondToChangedSelection): Reordered call to dismissCorrectionPanel() and

setSelection() to make sure there is no pending correction when entering
markAllMisspellingsAndBadGrammarInRanges().

(WebCore::Editor::appliedEditing): Only remove CorrectionIndicator markers when the command

is a top level command to improve efficiency.

(WebCore::Editor::insertTextWithoutSendingTextEvent): Added code to applying pending correction.
(WebCore::Editor::insertLineBreak): Ditto.
(WebCore::Editor::insertParagraphSeparator): Ditto.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Don't mark mispelling if the

text carries SpellCheckingExemption marker.

(WebCore::Editor::correctionPanelTimerFired): Reset correction panel if the returned suggestion

from spellchecker is an empty string.

(WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):

Use new DocumentMarkerController::removeMarkers() to replace custom implemenation to improve
efficiency and readability.

(WebCore::Editor::applyCorrectionPanelInfo): Remove the code that set caret position after

applying correction, since it's unnecessary. Also, store pre-correction string together with
the marker for reversion panel to use.

(WebCore::Editor::applyAutocorrectionBeforeTypingIfAppropriate): Apply pending correction.
(WebCore::Editor::changeSelectionAfterCommand): Moved marker removal code to Editor::appliedEditing()

where we have access to EditCommand object.

editing/Editor.h: Added new function applyAutocorrectionAfterTypingIfAppropriate().

manual-tests/autocorrection/autocorrection-cancelled-by-ESC.html: Change manual-tests that

were broken by relocated WebCore directory.

manual-tests/autocorrection/autocorrection-cancelled-by-typing-1.html: Ditto.

manual-tests/autocorrection/autocorrection-contraction.html: Ditto.

manual-tests/autocorrection/continue-typing-to-dismiss-reversion.html: Ditto.

manual-tests/autocorrection/delete-to-dismiss-reversion.html: Ditto.

manual-tests/autocorrection/delete-to-end-of-word-to-show-reversion.html: Ditto.

manual-tests/autocorrection/dismiss-multiple-guesses.html: Ditto.

manual-tests/autocorrection/move-to-end-of-word-to-show-reversion.html: Ditto.

manual-tests/autocorrection/select-from-multiple-guesses.html: Ditto.

manual-tests/autocorrection/spell-checking-after-reversion.html: Added.

manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html: Change manual-tests that

were broken by relocated WebCore directory.

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDocumentMarkers): Code clean-up to be more concise.

LayoutTests:

Patch by Jia Pu <jpu@apple.com> on 2011-02-03
Rebaselined tests broken by https://bugs.webkit.org/show_bug.cgi?id=51389

platform/mac/editing/spelling/autocorrection-contraction-expected.png:
platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
platform/mac/editing/spelling/autocorrection-delete-expected.png:
platform/mac/editing/spelling/autocorrection-delete-expected.txt:
platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.png:
platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.txt:
platform/mac/editing/spelling/autocorrection-removing-underline-expected.png:
platform/mac/editing/spelling/autocorrection-removing-underline-expected.txt:
platform/mac/editing/spelling/autocorrection-simple-expected.checksum:
platform/mac/editing/spelling/autocorrection-simple-expected.png:
platform/mac/editing/spelling/autocorrection-simple-expected.txt:
platform/mac/editing/spelling/autocorrection-simple.html:
platform/mac/editing/spelling/delete-autocorrected-word-1-expected.png:
platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt:

5:35 PM Changeset in webkit [77576] by mihaip@chromium.org

7 edits
2 copies in branches/chromium/648

Merge 77355 - 2011-02-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

Add tests for a scroll event triggered right before a modal dialog is
shown.

fast/events/scroll-event-during-modal-dialog-expected.txt: Added.
fast/events/scroll-event-during-modal-dialog.html: Added.

2011-02-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

Asychronous events that use EventQueue would currently fire while a
modal dialog (e.g. window.alert()) was up. Change EventQueue to use a
SuspendableTimer (which automatically gets suspended while dialogs are
up and in other cases where JS execution is not allowed).

Test: fast/events/scroll-event-during-modal-dialog.html

dom/Document.cpp: (WebCore::Document::Document):
dom/EventQueue.cpp: (WebCore::EventQueueTimer::EventQueueTimer): (WebCore::EventQueueTimer::fired): (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::pendingEventTimerFired):
dom/EventQueue.h: (WebCore::EventQueue::create):
page/SuspendableTimer.cpp: (WebCore::SuspendableTimer::SuspendableTimer): (WebCore::SuspendableTimer::suspend): (WebCore::SuspendableTimer::resume):
page/SuspendableTimer.h:

BUG=71888
TBR=jamesr@chromium.org
Review URL: http://codereview.chromium.org/6349095

5:29 PM Changeset in webkit [77575] by andersca@apple.com

5 edits in trunk/Source/WebKit2

2011-02-03 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Paint non-composited contents in a layer
https://bugs.webkit.org/show_bug.cgi?id=53742

WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setNeedsDisplay): Call LayerTreeHost::setNonCompositedContentsNeedDisplayInRect.

(WebKit::DrawingAreaImpl::scroll):
Call LayerTreeHost::scrollNonCompositedContents.

(WebKit::DrawingAreaImpl::setSize):
Call LayerTreeHost::sizeDidChange.

WebProcess/WebPage/LayerTreeHost.h: Add new pure virtual member functions.

WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::LayerTreeHostMac): Create the non-composited content layer.

(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplayInRect):
Call setNeedsDisplay on the GraphicsLayer.

(WebKit::LayerTreeHostMac::scrollNonCompositedContents):
Just call setNonCompositedContentsNeedDisplayInRect.

(WebKit::LayerTreeHostMac::sizeDidChange):
Resize the layers and flush any changes.

(WebKit::LayerTreeHostMac::paintContents):
Call WebPage::drawRect.

(WebKit::LayerTreeHostMac::flushPendingLayerChangesRunLoopObserverCallback):
Lay out the web page.

(WebKit::LayerTreeHostMac::flushPendingLayerChanges):
Call syncCompositingStateForThisLayerOnly on the non-composited content layer.

5:26 PM Changeset in webkit [77574] by dcheng@chromium.org

2 edits in trunk/Tools

Unreviewed.

Adding myself to committers.py.

Scripts/webkitpy/common/config/committers.py:

5:25 PM Changeset in webkit [77573] by inferno@chromium.org

2 edits in trunk/Source/WebCore

2011-02-03 Abhishek Arya <inferno@chromium.org>

Unreviewed, qt build fix.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeFloatingObject):

5:19 PM Changeset in webkit [77572] by jorlow@chromium.org

3 edits in trunk/Source/WebKit/chromium

2011-02-03 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Don't clear the callbacks ref in the proxy layer for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53535

Clearing the callbacks doesn't actually solve any problems and makes
this code behave subtly differently than how it would in Safari and
other single process environments. Let's remove the difference.

src/IDBCallbacksProxy.cpp: (WebCore::IDBCallbacksProxy::onError): (WebCore::IDBCallbacksProxy::onSuccess):
src/IDBTransactionCallbacksProxy.cpp: (WebCore::IDBTransactionCallbacksProxy::onAbort): (WebCore::IDBTransactionCallbacksProxy::onComplete): (WebCore::IDBTransactionCallbacksProxy::onTimeout):

5:17 PM Changeset in webkit [77571] by Adam Roben

2 edits in trunk/Tools

Include the crashing function in the link to a crash log

Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
function that crashed

Reviewed by David Kilzer.

Scripts/old-run-webkit-tests:

(crashLocation): Added. Returns the location of the crash.
(linksForErrorTest): Include the crash location in the link text for the crash log, if one
could be determined.

5:05 PM Changeset in webkit [77570] by mrowe@apple.com

5 edits in trunk/Source

Versioning.

5:04 PM Changeset in webkit [77569] by mrowe@apple.com

1 copy in tags/Safari-534.17

New tag.

4:53 PM Changeset in webkit [77568] by andersca@apple.com

3 edits in trunk/Source/WebKit2

2011-02-03 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

When in accelerated compositing mode, wait for DidSetSize messages
https://bugs.webkit.org/show_bug.cgi?id=53736

Normally we wait for DidSetSize messages from ::paint, but that's never called in
accelerated compositing mode so we just do it right after sending the SetSize message.

UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::paint): Call waitForAndDispatchDidSetSize.

(WebKit::DrawingAreaProxyImpl::sendSetSize):
Call waitForAndDispatchDidSetSize when in accelerated compositing mode.

(WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidSetSize):
New utility function which waits for and dispatches a DidSetSize message.

UIProcess/DrawingAreaProxyImpl.h:

4:52 PM Changeset in webkit [77567] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

2011-02-03 Brian Salomon <bsalomon@google.com>

Reviewed by James Robinson.

NHandle non-raster backed images in getUnmultipliedImageData()
https://bugs.webkit.org/show_bug.cgi?id=53468

No new tests. Existing canvas tests sufficient
LayoutTests/canvas/philip/...

platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):

4:51 PM Changeset in webkit [77566] by hans@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-02-03 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

Chromium: Remove deprecated WebIDBObjectStore::put() function
https://bugs.webkit.org/show_bug.cgi?id=53669

Remove deprecated put() function. Chromium side code now overrides
the new version.

public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::put):

4:51 PM Changeset in webkit [77565] by inferno@chromium.org

3 edits
2 adds in trunk

2011-02-03 Abhishek Arya <inferno@chromium.org>

Reviewed by James Robinson.

Tests that we do not crash when overflowing the height of a root
inline box.
https://bugs.webkit.org/show_bug.cgi?id=53729

fast/overflow/overflow-height-float-not-removed-crash-expected.txt: Added.
fast/overflow/overflow-height-float-not-removed-crash.html: Added.

2011-02-03 Abhishek Arya <inferno@chromium.org>

Reviewed by James Robinson.

Enforce more limits on root inline boxes height calculations.
https://bugs.webkit.org/show_bug.cgi?id=53729

Test: fast/overflow/overflow-height-float-not-removed-crash.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeFloatingObject): prevent logicalBottom to become negative when logicalTop is INT_MAX. (WebCore::RenderBlock::markLinesDirtyInBlockRange): when logicalBottom is INT_MAX, we should dirty everything. So, we bail out to make afterLowest equal to the lastRootBox() or lowestDirstLine.

4:49 PM Changeset in webkit [77564] by abarth@webkit.org

1 move
1 delete in trunk/PerformanceTests

Merge PerformanceTests/Parser/ChangeLog and
PerformanceTests/PageLoad/ChangeLog into PerformanceTests/ChangeLog.

Rubber-stamped by Eric Seidel.

It's silly to have ChangeLogs for each of these directories separately.
I've left SunSpider with its own ChangeLog because it's more of an
independent entity.

ChangeLog: Added.

4:48 PM Changeset in webkit [77563] by levin@chromium.org

9 edits
4 adds in trunk

Worker.importScript() should clean errors for cross origin imports.
https://bugs.webkit.org/show_bug.cgi?id=52871

Reviewed by Adam Barth and Oliver Hunt.

Source/WebCore:

Test: http/tests/workers/worker-importScriptsOnError.html

bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate): Use sanitizeScriptError
to determine when to create a clean exception.

bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::evaluate): Ditto.

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::sanitizeScriptError): Figure out
if the error needs to be cleaned up.
(WebCore::ScriptExecutionContext::dispatchErrorEvent): Extracted
sanitizeScriptError for use by other places.

dom/ScriptExecutionContext.h:
workers/WorkerContext.cpp:

(WebCore::WorkerContext::importScripts): Use the reponse url when
telling the evaluate where the script came fro.

workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::responseURL): Expose the url that
the script was loaded from (which may be different from url() due
to redirects).
(WebCore::WorkerScriptLoader::didReceiveResponse): Capture the reponse url.

workers/WorkerScriptLoader.h:

LayoutTests:

http/tests/workers/resources/worker-importScripts-error.js: Added.
http/tests/workers/resources/worker-importScripts-throw.js: Added.
http/tests/workers/worker-importScriptsOnError.html: Added.

4:46 PM Changeset in webkit [77562] by commit-queue@webkit.org

2 edits
1 add in trunk/Source/WebCore

2011-02-03 Mark Mentovai <mark@chromium.org>

Reviewed by Dimitri Glazkov.

Chromium GYP build fix.

When various settings were moved to webcore_prerequisites in r66364,
things that should have been direct_dependent_settings were not marked
as such. GYP 'defines', for example, make no sense on a 'none'-type
target such as webcore_prerequisites. It appears that it was intended
for these settings to be pushed to direct dependents, which would make
direct_dependent_settings correct.

Losing the ChromiumWebCoreObjC defines on the Mac, for example, caused
http://crbug.com/71537, which at best causes Mac console log spew, and
at worst may result in Chromium's copy of WebCore using system
definitions of certain Objective-C classes at runtime, or vice-versa.

The build now includes a postbuild step to prevent
http://crbug.com/71537 from regressing again. The build will fail upon
regression.

https://bugs.webkit.org/show_bug.cgi?id=53630

WebCore.gyp/WebCore.gyp: Move things in webcore_prerequisites into direct_dependent_settings as needed, add the check_objc_rename postbuild step.
WebCore.gyp/mac/check_objc_rename.sh: Added.

4:42 PM Changeset in webkit [77561] by andersca@apple.com

6 edits in trunk/Source/WebKit2

2011-02-03 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Pass along an UpdateInfo object to the ExitAcceleratedCompositingMode message
https://bugs.webkit.org/show_bug.cgi?id=53734

UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::exitAcceleratedCompositingMode): Add an UpdateInfo parameter.

UIProcess/DrawingAreaProxy.messages.in: Add an UpdateInfo parameter to the ExitAcceleratedCompositingMode message.

UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode): Incorporate the passed in update.

WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Create a new UpdateInfo object, paint into it and pass it along as a parameter to the ExitAcceleratedCompositingMode message.

4:41 PM Changeset in webkit [77560] by abarth@webkit.org

3 edits in trunk/Source/WebCore

2011-02-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make XSSFilter go fast by adding a SuffixTree
https://bugs.webkit.org/show_bug.cgi?id=53665

The SuffixTree lets us quickly reject snippets if the POST data is
large (because we can avoid a linear scan over the POST data).

html/parser/XSSFilter.cpp: (WebCore::XSSFilter::init): (WebCore::XSSFilter::isContainedInRequest):
html/parser/XSSFilter.h:

4:40 PM Changeset in webkit [77559] by mihaip@chromium.org

4 edits
3 adds in trunk

2011-02-03 Mihai Parparita <mihaip@chromium.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r77355): Page cache layout tests crash
https://bugs.webkit.org/show_bug.cgi?id=53648

Add test that calls setTimeout during a pagehide event handler (the
timeout should not fire while the document is in the page cache).

Skipped for Chromium since it doesn't use the page cache.

fast/events/pagehide-timeout-expected.txt: Added.
fast/events/pagehide-timeout.html: Added.
fast/events/resources/pagehide-timeout-go-back.html: Added.
platform/chromium/test_expectations.txt:

2011-02-03 Mihai Parparita <mihaip@chromium.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r77355): Page cache layout tests crash
https://bugs.webkit.org/show_bug.cgi?id=53648

Test: fast/events/pagehide-timeout.html

Suspend active DOM objects after all pagehide event handlers have run,
otherwise it's possible for them to create more objects that weren't
getting suspended.

history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame):

4:37 PM Changeset in webkit [77558] by jorlow@chromium.org

3 edits in trunk/Source/WebCore

2011-02-03 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

SerializedScriptValue should not require v8 to create undefined and null values
https://bugs.webkit.org/show_bug.cgi?id=53730

Instead of creating a v8 type and passing that into the constructor, just use
the writer class directly. While I was at it, I cleaned up the code a bit too
by getting rid of the WireData/StringValue enum as I found that personally
confusing.

This is necessary because these methods are called by IndexedDB in the browser
process where v8 is not spun up.

No functionality changed and not possible to test.

bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::createFromWire): (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::nullValue): (WebCore::SerializedScriptValue::undefinedValue): (WebCore::SerializedScriptValue::release): (WebCore::SerializedScriptValue::SerializedScriptValue):
bindings/v8/SerializedScriptValue.h:

4:27 PM Changeset in webkit [77557] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

2011-02-03 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Not all blocks are freed when the heap is freed (counting is hard!)
https://bugs.webkit.org/show_bug.cgi?id=53732

runtime/MarkedSpace.cpp: (JSC::MarkedSpace::destroy): Freeing a block compacts the list, so just keep freeing block 0 until there are no blocks left.

4:18 PM Changeset in webkit [77556] by dpranke@chromium.org

3 edits in trunk/Tools

2011-02-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Actually make the changes suggested by Mihai in his review
of bug 53720 :(

https://bugs.webkit.org/show_bug.cgi?id=53720

Scripts/webkitpy/layout_tests/port/test_files.py:
Scripts/webkitpy/layout_tests/port/test_files_unittest.py:

4:17 PM Changeset in webkit [77555] by Beth Dakin

9 edits in trunk/Source

Fix for <rdar://problem/8944544> Ability to animate track
for WKPainter scrollers

Reviewed by Sam Weinig.

Source/WebCore:

Two new WebKitSystemInterface functions.

WebCore.exp.in:
platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:

Use Scrollbar::convertFromContainingView() to return the right point.

platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):

ScrollKnobAnimation is now ScrollbarPartAnimation. It can
now be used to animate the knob or the track.
(-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPartAnimation setCurrentProgress:]):
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):

Scrollbars need invalodating after the overlay state changes.
(-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):

Source/WebKit/mac:

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

4:16 PM Changeset in webkit [77554] by Dimitri Glazkov

1 edit
4 adds in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

Added SL-specific result for the test and put back the original result that
I've neglected to do in r77539.

platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
platform/mac/svg/text/font-size-below-point-five-expected.txt: Added.

4:16 PM Changeset in webkit [77553] by mrowe@apple.com

5 edits in branches/safari-533.20-branch

Versioning.

4:15 PM Changeset in webkit [77552] by mrowe@apple.com

1 copy in tags/Safari-533.20.22

New tag.

4:15 PM Changeset in webkit [77551] by dpranke@chromium.org

4 edits in trunk/Tools

2011-02-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests: Fix bug introduced in r77434 that was
causing us to run the canvas GPU tests on the Mac GPU port. This
bug revealed that we were not setting the port.name() field
properly in many cases, so I've cleaned up all of that code, and
removed a few comments about "version-specific" GPU ports that
don't exist and just confused things.

Testing also revealed that port.abspath_for_test() wasn't
normalizing paths on Windows properly, so I fixed that as well.

https://bugs.webkit.org/show_bug.cgi?id=53719

Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:

4:13 PM Changeset in webkit [77550] by dpranke@chromium.org

4 edits in trunk/Tools

2011-02-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests: fix normalization of paths on windows when gathering files

r77434 introduced a bug that was causing the test expectations
for the GPU ports to not be treated properly. It turns out that
when we gathered the list of test files on Windows, we would
return paths of the form "c:\LayoutTests/fast/canvas", and the
mixture of backslashes and forward slashes was confusing things.

This patch normalizes all of the filenames returned from
test_files.find(), and adds better tests for this (fixing a
couple of other bugs found in the meantime).

https://bugs.webkit.org/show_bug.cgi?id=53720

Scripts/webkitpy/layout_tests/port/test.py:
Scripts/webkitpy/layout_tests/port/test_files.py:
Scripts/webkitpy/layout_tests/port/test_files_unittest.py:

4:11 PM Changeset in webkit [77549] by weinig@apple.com

2 edits in trunk/Source/WebCore

Scroll thumb jumps to top when resizing horizontally.

Reviewed by Beth Dakin.

platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars): Add call to update
the scrollbar's offset in the case where we may have created
a new scrollbar but have not changed the current position.

4:07 PM Changeset in webkit [77548] by jschuh@chromium.org

3 edits
2 adds in trunk

2011-02-03 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

startAnimations should use a local, RefCounted Vector.
https://bugs.webkit.org/show_bug.cgi?id=53458

Test: svg/custom/use-animation-in-fill.html

svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::startAnimations):

2011-02-03 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

startAnimations should use a local, RefCounted Vector.
https://bugs.webkit.org/show_bug.cgi?id=53458

svg/custom/use-animation-in-fill-expected.txt: Added.
svg/custom/use-animation-in-fill.html: Added.

3:54 PM Changeset in webkit [77547] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed.

small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448

platform/qt/Skipped: Add failing tests until fix.
- css3/zoom-coords.xhtml
- svg/zoom/page/zoom-zoom-coords.xhtml

3:38 PM Changeset in webkit [77546] by andersca@apple.com

8 edits in trunk/Source/WebKit2

2011-02-03 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Change DidSetSize to take a LayerTreeContext parameter
https://bugs.webkit.org/show_bug.cgi?id=53724

Since SetSize can cause layout to happen, we need to pass along a layer tree context to
the DidSetSize message so the UI process can enter/exit accelerated compositing mode appropriately.

Shared/LayerTreeContext.h:
Shared/mac/LayerTreeContextMac.mm: Add equality operators to LayerTreeContext.

UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::didSetSize): This now takes a LayerTreeContext parameter.

UIProcess/DrawingAreaProxy.messages.in: Add LayerTreeContext parameter.

UIProcess/DrawingAreaProxyImpl.cpp: Get rid of m_isInAcceleratedCompositingMode and use the current layer context instead.

(WebKit::DrawingAreaProxyImpl::paint):
Bail if the call to DidSetSize ended up entering accelerated compositing mode.

(WebKit::DrawingAreaProxyImpl::didSetSize):
If the new layer tree context is different, enter/exit accelerated compositing mode accordingly.

(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
Update the layer tree context.

UIProcess/DrawingAreaProxyImpl.h: (WebKit::DrawingAreaProxyImpl::isInAcceleratedCompositingMode): Add simple getter.

WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setSize): Pass along the layer tree context.

3:34 PM Changeset in webkit [77545] by abarth@webkit.org

3 edits in trunk/Source/WebCore

2011-02-03 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

XSSFilter shouldn't bother to analyze pages without "injection"
characters in the request
https://bugs.webkit.org/show_bug.cgi?id=53664

If the request lacks these "injection" characters, then it's unlikely
that there's a reflective XSS attack happening. This hueristic lets us
avoid analyzing the vast majority of responses for XSS. Of course, the
hueristic isn't perfect. Because of this huerstic, we miss out on
injections into unquoted attributes. However, it's a trade-off that's
worked well in the XSSAuditor.

html/parser/XSSFilter.cpp: (WebCore::HTMLNames::isRequiredForInjection): (WebCore::XSSFilter::XSSFilter): (WebCore::XSSFilter::init): (WebCore::XSSFilter::filterToken): (WebCore::XSSFilter::isContainedInRequest):
html/parser/XSSFilter.h:

3:34 PM Changeset in webkit [77544] by Dimitri Glazkov

2 edits in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

Add a failure until I investigate its cause.

platform/chromium/test_expectations.txt: Added.

3:28 PM Changeset in webkit [77543] by mrowe@apple.com

21 edits in branches/safari-533.20-branch

Merge r73444.

3:28 PM Changeset in webkit [77542] by mrowe@apple.com

7 edits in branches/safari-533.20-branch/WebCore

Merge r59596.

3:27 PM Changeset in webkit [77541] by mrowe@apple.com

5 edits in branches/safari-533.20-branch

Versioning.

3:26 PM Changeset in webkit [77540] by Dimitri Glazkov

11 edits in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

Updated platform/mac-leopard baselines for fast/backgrounds after r77485.

3:16 PM Changeset in webkit [77539] by Dimitri Glazkov

1 edit
1 move in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

Move Leopard result to the right spot, put back the original result.

platform/mac-leopard/svg/text/font-size-below-point-five-expected.txt:

Renamed from LayoutTests/platform/mac/svg/text/font-size-below-point-five-expected.txt.

3:09 PM Changeset in webkit [77538] by Adam Roben

2 edits in trunk/LayoutTests

Skip an SVG test that fails depending on what other tests came before it

Running any other SVG test before this one causes it to fail. If we were to check in new
failing results, it might start passing again if some more tests are added before it that
make it the first test that is run for a particular invocation of DumpRenderTree. So the
safest thing to do for now is to skip it. <http://webkit.org/b/35700> tracks this failure.

platform/win/Skipped: Added svg/W3C-SVG-1.1-SE/types-dom-01-b.svg.

2:54 PM Changeset in webkit [77537] by Adam Roben

2 edits in trunk/Tools

Add links to Windows crash logs in results.html

Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
results.html

Reviewed by David Kilzer.

Scripts/old-run-webkit-tests:

(top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
createDebuggerCommandFile).
(testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
tool has exited.
(captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
it into the test results directory tree. Only implemented for Cygwin currently.
(findNewestFileMatchingGlob): Added. Does what it says.
(htmlForResultsSection): Only link to files that exist.
(linksForErrorTest): Add a link to the crash log.
(deleteExpectedAndActualResults): Delete any old crash log for this test.
(createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
hardcoding it here.

2:51 PM Changeset in webkit [77536] by Dimitri Glazkov

622 edits in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

Updated platform/mac and platform/mac-leopard baselines for svg/ after r77485.

2:36 PM Changeset in webkit [77535] by Martin Robinson

2 edits in trunk

2011-02-03 Martin Robinson <mrobinson@igalia.com>

Fix GTK+ WebGL build after r76600.

configure.ac: Make sure to respect configure.ac conventions consistently when it comes to capitalization. Remove an old reference to enable_3d_canvas.

2:27 PM Changeset in webkit [77534] by andersca@apple.com

6 edits in trunk/Source/WebKit2

Get rid of LayerTreeContext::seed on Mac.
Add sequence checks to enterAcceleratedCompositingMode and exitAcceleratedCompositingMode and
have them call newly added overloads that don't have the checks.

Reviewed by Dan Bernstein.

Shared/LayerTreeContext.h:
Shared/mac/LayerTreeContextMac.mm:

(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):

UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):

UIProcess/DrawingAreaProxyImpl.h:
WebProcess/WebPage/mac/LayerTreeHostMac.mm:

(WebKit::LayerTreeHostMac::LayerTreeHostMac):

2:19 PM Changeset in webkit [77533] by andersca@apple.com

10 edits in trunk/Source/WebKit2

2011-02-03 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Get rid of timestamps in UpdateInfo
https://bugs.webkit.org/show_bug.cgi?id=53713

Add a 64-bit sequence number to all DrawingAreaProxy messages, and use it to
check whether Update messages should be handled or not.

Shared/UpdateInfo.cpp: (WebKit::UpdateInfo::encode): (WebKit::UpdateInfo::decode):
Shared/UpdateInfo.h: (WebKit::UpdateInfo::UpdateInfo):
UIProcess/BackingStore.cpp: (WebKit::BackingStore::BackingStore): (WebKit::BackingStore::incorporateUpdate):
UIProcess/BackingStore.h:
UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::update): (WebKit::DrawingAreaProxy::didSetSize): (WebKit::DrawingAreaProxy::enterAcceleratedCompositingMode): (WebKit::DrawingAreaProxy::exitAcceleratedCompositingMode):
UIProcess/DrawingAreaProxy.messages.in:
UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): (WebKit::DrawingAreaProxyImpl::update): (WebKit::DrawingAreaProxyImpl::didSetSize): (WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode): (WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
UIProcess/DrawingAreaProxyImpl.h:
WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::generateSequenceNumber): (WebKit::DrawingAreaImpl::setSize): (WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): (WebKit::DrawingAreaImpl::display):

1:51 PM Changeset in webkit [77532] by vangelis@chromium.org

2 edits in trunk/Source/WebCore

2011-02-03 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Fixing a compositor crash occurring on layers
without an associated RenderSurface.
https://bugs.webkit.org/show_bug.cgi?id=53679
Regression was introduced by in r77425

Test: http://webkit.org/blog/386/3d-transforms/ doesn't crash
anymore.

platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayer):

1:44 PM Changeset in webkit [77531] by Dimitri Glazkov

6 edits in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Updated baselines that are specific to Leopard.

platform/chromium-mac-leopard/svg/custom/linking-a-03-b-preserveAspectRatio-expected.txt:
platform/chromium-mac-leopard/svg/custom/linking-a-03-b-viewTarget-expected.txt:
platform/chromium-mac-leopard/svg/custom/linking-a-03-b-zoomAndPan-expected.txt:
platform/chromium-mac-leopard/svg/custom/stroked-pattern-expected.png:
platform/chromium-mac-leopard/svg/custom/stroked-pattern-expected.txt:

1:19 PM Changeset in webkit [77530] by mitz@apple.com

5 edits in trunk

<rdar://problem/8948788> Text emphasis marks have wrong orientation for vertical text
https://bugs.webkit.org/show_bug.cgi?id=53709

Reviewed by Anders Carlsson.

Source/WebCore:

Covered by rendering of fast/text/emphasis-vertical.html

platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::scaledFontData): Give the scaled font the same orientation this font
has.

LayoutTests:

platform/mac/fast/text/emphasis-vertical-expected.checksum:
platform/mac/fast/text/emphasis-vertical-expected.png:

1:12 PM ApplicationsGtk edited by grant_gayed@ca.ibm.com

add SWT to the Widget Toolkits section (diff)

12:50 PM Changeset in webkit [77529] by andersca@apple.com

7 edits in trunk/Source/WebKit2

2011-02-03 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Don't send enter/exit accelerated compositing mode messages when handling setSize
https://bugs.webkit.org/show_bug.cgi?id=53706

Don't send EnterAcceleratedCompositingMode/ExitAcceleratedCompositing mode when
the mode changes happen as a result of relayout in setSize, since an updated state
is going to be sent back in the DidSetSize message.

UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::didSetSize): Add an assert.

WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize m_inSetSize.

(WebKit::DrawingAreaImpl::setRootCompositingLayer):
Factor out code into enterAcceleratedCompositingMode and exitAcceleratedCompositingMode.

(WebKit::DrawingAreaImpl::setSize):
Set m_inSetSize to true while handling setSize.

(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
Take over the message sending responsibility from LayerTreeHostMac, and don't send messages
if we're currently handling a SetSize message.

WebProcess/WebPage/DrawingAreaImpl.h: Add m_inSetSize.

WebProcess/WebPage/LayerTreeHost.h: Add layerTreeHost getter.

WebProcess/WebPage/mac/LayerTreeHostMac.h:
WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::LayerTreeHostMac): Don't send EnterAcceleratedCompositingMode messages.

(WebKit::LayerTreeHostMac::layerTreeContext):
Add getter for the current layer tree context.

(WebKit::LayerTreeHostMac::invalidate):
Don't send ExitAcceleratedCompositingMode messages.

12:42 PM Changeset in webkit [77528] by Martin Robinson

2 edits in trunk/LayoutTests

2011-02-03 Martin Robinson <mrobinson@igalia.com>

Fix one GTK+ skipped list entry that referred to the wrong test file.

platform/gtk/Skipped: Fix skipped list entry.

12:33 PM Changeset in webkit [77527] by Dimitri Glazkov

1 edit
1 delete in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Removed the checksum that is out of place.

platform/chromium-win-xp/svg/text/text-fonts-01-t-expected.checksum: Removed.

12:30 PM Changeset in webkit [77526] by Dimitri Glazkov

2 edits
2 adds
1 delete in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Updated SVG baselines after r77485 for Mac and added expectations
of failure while waiting for platform/mac pixel results to land.

platform/chromium-mac/svg/custom/linking-a-03-b-transform-expected.txt: Removed.
platform/chromium-mac/svg/custom/stroked-pattern-expected.checksum: Added.
platform/chromium-mac/svg/custom/stroked-pattern-expected.png: Added.
platform/chromium/test_expectations.txt: Added fails.

12:29 PM Changeset in webkit [77525] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

Try to fix the Mac build.

JavaScriptCore.xcodeproj/project.pbxproj: The new MarkedBlock.h header

needs to be private, not project, so other projects can include headers
that depend on it.

11:52 AM Changeset in webkit [77524] by andersca@apple.com

5 edits in trunk/Source/WebKit2

2011-02-03 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make the layer tree host keep track of the layer tree context
https://bugs.webkit.org/show_bug.cgi?id=53698

Add a LayerTreeContext member variable to the LayerTreeHost object,
and also add a seed count to the LayerTreeContext so we can keep track of
how layer tree contexts relate to each other.

Shared/LayerTreeContext.h:
Shared/mac/LayerTreeContextMac.mm: (WebKit::LayerTreeContext::LayerTreeContext): (WebKit::LayerTreeContext::makeWithSeed): (WebKit::LayerTreeContext::encode): (WebKit::LayerTreeContext::decode):

WebProcess/WebPage/mac/LayerTreeHostMac.h: Add the layer tree context as a member variable.

WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::LayerTreeHostMac): Initialize the layer tree context.

11:48 AM Changeset in webkit [77523] by Adam Roben

17 edits
2 adds in trunk/LayoutTests

Check in the results I really meant to commit in r77507

A flub on the command-line meant that many of the results added in r77507 were identical to
the Mac results, rather than matching what happens on Windows.

platform/win/svg/W3C-SVG-1.1/text-align-06-b-expected.checksum:
platform/win/svg/W3C-SVG-1.1/text-align-06-b-expected.png:
platform/win/svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
platform/win/svg/batik/masking/maskRegions-expected.checksum: Added.
platform/win/svg/batik/masking/maskRegions-expected.png: Added.
platform/win/svg/batik/masking/maskRegions-expected.txt:
platform/win/svg/batik/text/textGlyphOrientationHorizontal-expected.checksum:
platform/win/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
platform/win/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
platform/win/svg/carto.net/scrollbar-expected.checksum:
platform/win/svg/carto.net/scrollbar-expected.png:
platform/win/svg/carto.net/scrollbar-expected.txt:
platform/win/svg/text/font-size-below-point-five-expected.checksum:
platform/win/svg/text/font-size-below-point-five-expected.png:
platform/win/svg/text/font-size-below-point-five-expected.txt:
platform/win/svg/text/text-align-06-b-expected.checksum:
platform/win/svg/text/text-align-06-b-expected.png:
platform/win/svg/text/text-align-06-b-expected.txt:

11:48 AM QtWebKitDocContrib edited by Ademar Reis

(diff)

11:44 AM Changeset in webkit [77522] by Dimitri Glazkov

1 edit
2 adds in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Two more updated SVG baselines after r77485 for Linux.

platform/chromium-linux/svg/batik/text/verticalText-expected.txt: Added.
platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.txt: Added.

11:31 AM Changeset in webkit [77521] by leviw@chromium.org

3 edits
2 adds in trunk

2011-02-02 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Moving cursor down in table cycles at the end of a row
https://bugs.webkit.org/show_bug.cgi?id=50012

Tests downward caret-navigation for tables at the end of a document.

editing/selection/move-by-line-cycles-in-table-expected.txt: Added.
editing/selection/move-by-line-cycles-in-table.html: Added.

2011-02-02 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Moving cursor down in table cycles at the end of a row
https://bugs.webkit.org/show_bug.cgi?id=50012

Avoids a caret cycling issue with certain content (e.g. tables) found at the very
end of a document due to a bug in nextLeafWithSameEditability.

Test: editing/selection/move-by-line-cycles-in-table.html

editing/visible_units.cpp: (WebCore::nextLeafWithSameEditability): Properly avoid descending back into the original leaf node.

11:28 AM Changeset in webkit [77520] by Dimitri Glazkov

3 edits in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] One more update SVG baselines after r77485 for Linux.

11:23 AM Changeset in webkit [77519] by ggaren@apple.com

4 edits in trunk/Source/JavaScriptCore

2011-02-03 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Start using MarkedBlock instead of CollectorBlock
https://bugs.webkit.org/show_bug.cgi?id=53693

SunSpider reports no change.

runtime/MarkedBlock.h: (JSC::MarkedBlock::blockFor): (JSC::MarkedBlock::setMarked): (JSC::MarkedBlock::isCellAligned): (JSC::MarkedBlock::isPossibleCell): Updated for const-ness.

runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocateBlock): (JSC::MarkedSpace::containsSlowCase): (JSC::MarkedSpace::clearMarkBits): Updated for const-ness.

runtime/MarkedSpace.h: (JSC::CollectorHeap::collectorBlock): (JSC::MarkedSpace::heap): (JSC::MarkedSpace::isMarked): (JSC::MarkedSpace::testAndSetMarked): (JSC::MarkedSpace::setMarked): (JSC::MarkedSpace::contains): Switched from CollectorBlock to MarkedBlock, and deleted dead CollectorBlock-related code.

11:23 AM Changeset in webkit [77518] by Dimitri Glazkov

9 edits
4 moves
8 deletes in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Moved XP/Vista-specific baselines to their proper places.

platform/chromium-win-vista/svg/text/text-fonts-01-t-expected.checksum:
platform/chromium-win-vista/svg/text/text-fonts-01-t-expected.png:
platform/chromium-win-xp/svg/batik/text/verticalText-expected.checksum:
platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.checksum:
platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.png:
platform/chromium-win-xp/svg/text/text-intro-05-t-expected.checksum:
platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png:
platform/chromium-win/svg/batik/text/verticalText-expected.checksum: Removed.
platform/chromium-win/svg/batik/text/verticalText-expected.png: Removed.
platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.checksum: Removed.
platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.png: Removed.
platform/chromium-win/svg/text/text-fonts-01-t-expected.checksum: Removed.
platform/chromium-win/svg/text/text-fonts-01-t-expected.png: Removed.
platform/chromium-win/svg/text/text-intro-05-t-expected.checksum: Removed.
platform/chromium-win/svg/text/text-intro-05-t-expected.png: Removed.

11:05 AM Changeset in webkit [77517] by Dimitri Glazkov

2 edits in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

Update expectations after r77495.

fast/dom/Window/window-properties-expected.txt: Updated.

10:50 AM Changeset in webkit [77516] by Dimitri Glazkov

2 edits in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Explicitly mark platform/chromium-linux as failing for other platforms.

platform/chromium/test_expectations.txt: Added expectation of failure.

10:46 AM Changeset in webkit [77515] by Adam Roben

2 edits in trunk/Tools

Tell the debugger the path to the WebKit source tree when saving a crash log

This allows the debugger to include the crashing line of code in the log.

Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
of code

Reviewed by Sam Weinig.

Scripts/old-run-webkit-tests:

(createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
file and returns the path to that file. The commands we pass came from
setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
WebKit source code lives.
(setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
line using -c, save them to a file and specify the path to that file using -cf. This works
around what is presumably a bug in Windows's command line parsing, where having multiple
quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
all. Also pulled the options we pass to the debugger out into a list that is then join()ed
together to make them easier to modify in the future.

10:41 AM Changeset in webkit [77514] by Dimitri Glazkov

2 edits in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

Update expectations after r77495.

fast/dom/Window/window-properties-performance-expected.txt: Updated.

10:33 AM Changeset in webkit [77513] by Dimitri Glazkov

1 edit
1 move
5 adds in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Add expectations for r77500.

platform/chromium-mac/fast/dom/HTMLInputElement/input-slider-update-expected.checksum: Added.
platform/chromium-mac/fast/dom/HTMLInputElement/input-slider-update-expected.png: Added.
platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-expected.checksum: Added.
platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-expected.png: Added.

10:28 AM Changeset in webkit [77512] by weinig@apple.com

2 edits in trunk/Source/WebKit2

Fix Qt build.

UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage):

10:20 AM Changeset in webkit [77511] by Dimitri Glazkov

338 edits
1 copy
26 adds
45 deletes in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Update SVG baselines after r77485 for Linux.

10:19 AM Changeset in webkit [77510] by podivilov@chromium.org

7 edits
1 delete in trunk/Source/WebCore

2011-02-03 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove dead code related to changes panel.
https://bugs.webkit.org/show_bug.cgi?id=53688

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/ChangesView.js: Removed.
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.css: (#error-warning-count): (#error-warning-count:hover): (#error-count + #warning-count):
inspector/front-end/inspector.html:
inspector/front-end/inspector.js:

10:13 AM Changeset in webkit [77509] by weinig@apple.com

21 edits in trunk

Add notification of the end of a rubber band.
<rdar://problem/8940648>

Reviewed by Anders Carlsson.

Source/WebCore:

WebCore.exp.in:

Add additional exprots.

page/ChromeClient.h:

(WebCore::ChromeClient::didCompleteRubberBandForMainFrame):

page/FrameView.cpp:

(WebCore::FrameView::didCompleteRubberBand):

page/FrameView.h:
platform/ScrollView.cpp:

(WebCore::ScrollView::didCompleteRubberBand):

platform/ScrollView.h:

Add hook.

platform/ScrollableArea.h:

(WebCore::ScrollableArea::inLiveResize):
(WebCore::ScrollableArea::maximumScrollPosition):
(WebCore::ScrollableArea::visibleWidth):
(WebCore::ScrollableArea::overhangAmount):
(WebCore::ScrollableArea::didCompleteRubberBand):
Reorganize and de-virtualize live resize notifications.

platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
Call the new hook when the rubberband ends.

Source/WebKit2:

UIProcess/API/C/WKPage.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::drawHeader):
(WebKit::WebPageProxy::drawFooter):
(WebKit::WebPageProxy::didCompleteRubberBandForMainFrame):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::didCompleteRubberBandForMainFrame):

UIProcess/WebUIClient.h:
WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::didCompleteRubberBandForMainFrame):

WebProcess/WebCoreSupport/WebChromeClient.h:

Pipe the notification up to the WKUIClient.

Tools:

MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
Stub out the new WKUIClient function.

10:07 AM Changeset in webkit [77508] by Adam Roben

2 edits in trunk/LayoutTests

Skip fast/canvas/set-colors.html on Windows

It currently fails on some bots but not others. <http://webkit.org/b/53677> tracks the
investigation.

platform/win/Skipped:

10:02 AM Changeset in webkit [77507] by Adam Roben

3 edits
22 adds in trunk/LayoutTests

Update Windows results after r77485

Windows used to match Mac on these tests, but now it doesn't. Presumably this is because
r77485 increased the precision of ascent/descent calculations, making differences in
Windows/Mac font metrics matter more.

One test (svg/W3C-SVG-1.1-SE/types-dom-01-b.svg) is still failing, but it passes when run on
its own, so warrants more investigation.

platform/win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.checksum: Added.
platform/win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png: Added.
platform/win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
platform/win/svg/W3C-SVG-1.1/text-align-06-b-expected.checksum: Added.
platform/win/svg/W3C-SVG-1.1/text-align-06-b-expected.png: Added.
platform/win/svg/W3C-SVG-1.1/text-align-06-b-expected.txt: Added.
platform/win/svg/batik/text/textGlyphOrientationHorizontal-expected.checksum: Added.
platform/win/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Added.
platform/win/svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Added.
platform/win/svg/carto.net/scrollbar-expected.checksum: Added.
platform/win/svg/carto.net/scrollbar-expected.png: Added.
platform/win/svg/carto.net/scrollbar-expected.txt: Added.
platform/win/svg/text/font-size-below-point-five-expected.checksum: Added.
platform/win/svg/text/font-size-below-point-five-expected.png: Added.
platform/win/svg/text/font-size-below-point-five-expected.txt: Added.
platform/win/svg/text/text-align-06-b-expected.checksum: Added.
platform/win/svg/text/text-align-06-b-expected.png: Added.
platform/win/svg/text/text-align-06-b-expected.txt: Added.
platform/win/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
platform/win/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
platform/win/svg/zoom/page/zoom-mask-with-percentages-expected.txt:

10:00 AM Changeset in webkit [77506] by Nikolas Zimmermann

70 edits in trunk/LayoutTests

2011-02-03 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448

First chunk, updating mac SVG pixel test baseline after r77485.

platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:

...

9:54 AM Changeset in webkit [77505] by Csaba Osztrogonác

2 edits
1 copy in trunk/LayoutTests

Unreviewed. Update Qt specific expected results after r77495.

platform/qt/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/dom/Window/window-properties-performance-expected.txt: Copied from LayoutTests/fast/dom/Window/window-properties-performance-expected.txt.

9:49 AM Changeset in webkit [77504] by evan@chromium.org

5 edits
4 adds in trunk

2011-02-02 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] complex joining characters positioned in wrong place
https://bugs.webkit.org/show_bug.cgi?id=53637

Add a test that includes some characters that exhibited the problem.
Unfortunately it's purely a rendering issue, so it is a pixel test.

platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.checksum: Added.
platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.png: Added.
platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt: Added.
platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html: Added.

2011-02-02 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] complex joining characters positioned in wrong place
https://bugs.webkit.org/show_bug.cgi?id=53637

Provide the correct font metrics to Harfbuzz related to the font design space.
There are used in some fonts for GPOS positioning.

Test: platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html

platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::setupFontForScriptRun): (WebCore::ComplexTextController::allocHarfbuzzFont):
platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::emSizeInFontUnits): (WebCore::FontPlatformData::operator=):
platform/graphics/chromium/FontPlatformDataLinux.h: (WebCore::FontPlatformData::FontPlatformData):

9:43 AM Changeset in webkit [77503] by mnaganov@chromium.org

2 edits in branches/chromium/648/Source/WebCore/inspector/front-end

Merge 77480 - 2011-02-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: resources panel doesn't show frames after reload.
https://bugs.webkit.org/show_bug.cgi?id=53430

inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype.loadEventFired): (WebInspector.ResourcesPanel.prototype._initDefaultSelection): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.clear):
inspector/front-end/inspector.js: (WebInspector.loadEventFired):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/6368081

9:42 AM Changeset in webkit [77502] by rniwa@webkit.org

2 edits in trunk/LayoutTests

2011-02-03 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; remove the line I intended to remove.

platform/chromium/test_expectations.txt:

9:36 AM Changeset in webkit [77501] by rniwa@webkit.org

2 edits in trunk/LayoutTests

2011-02-03 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update for
http://src.chromium.org/viewvc/chrome?view=rev&revision=73469

platform/chromium/test_expectations.txt:

9:28 AM Changeset in webkit [77500] by Dimitri Glazkov

7 edits
4 adds in trunk

2011-02-02 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

REGRESSION(r76147): Slider thumb position is not updated when value attribute is changed.
https://bugs.webkit.org/show_bug.cgi?id=53634

fast/dom/HTMLInputElement/input-slider-update.html: Added.
platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.checksum: Added.
platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.png: Added.
platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.txt: Added.

2011-02-02 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

REGRESSION(r76147): Slider thumb position is not updated when value attribute is changed.
https://bugs.webkit.org/show_bug.cgi?id=53634

Test: fast/dom/HTMLInputElement/input-slider-update.html

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue): Added a call to InputType::valueChanged.
html/InputType.cpp: (WebCore::InputType::valueChanged): Added empty implementation.
html/InputType.h: Added def.
html/RangeInputType.cpp: (WebCore::RangeInputType::valueChanged): Added implementation that dirties layout

bit on the thumb.

html/RangeInputType.h: Added def.

9:22 AM Changeset in webkit [77499] by Dimitri Glazkov

762 edits
1 copy
25 adds
5 deletes in trunk/LayoutTests

2011-02-03 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Update SVG baselines after r77485 for Windows.

9:15 AM Changeset in webkit [77498] by podivilov@chromium.org

4 edits in trunk/Source/WebCore

2011-02-02 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: do not share source frames between resources panel and scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=53584

Currently, we show error messages only for resources. This change will allow showing error
messages in source frame even when resource is not available (eval scripts, inlined scripts).

inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage): (WebInspector.ConsoleView.prototype.clearMessages):
inspector/front-end/ResourceView.js: (WebInspector.ResourceView.recreateResourceView):
inspector/front-end/ResourcesPanel.js: (WebInspector.FrameResourceTreeElement.prototype._setBubbleText):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._scriptSourceChanged): (WebInspector.ScriptsPanel.prototype.addConsoleMessage): (WebInspector.ScriptsPanel.prototype.clearConsoleMessages): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource): (WebInspector.ScriptsPanel.prototype._sourceFrameForResource): (WebInspector.ScriptsPanel.prototype._sourceFrameForScript):

9:13 AM Changeset in webkit [77497] by Csaba Osztrogonác

93 edits
4 adds in trunk/LayoutTests

Unreviewed, rebaseline Qt svg tests after r77485.

platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum:
platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum:
platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.checksum:
platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.checksum:
platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
platform/qt/svg/custom/stroke-width-large-expected.checksum:
platform/qt/svg/custom/stroke-width-large-expected.png:
platform/qt/svg/custom/stroke-width-large-expected.txt:
platform/qt/svg/custom/text-rotated-gradient-expected.checksum:
platform/qt/svg/custom/text-rotated-gradient-expected.png:
platform/qt/svg/custom/text-rotated-gradient-expected.txt:
platform/qt/svg/foreignObject/text-tref-02-b-expected.checksum:
platform/qt/svg/foreignObject/text-tref-02-b-expected.png:
platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
platform/qt/svg/text/lengthAdjust-text-metrics-expected.checksum: Added.
platform/qt/svg/text/lengthAdjust-text-metrics-expected.png: Added.
platform/qt/svg/text/lengthAdjust-text-metrics-expected.txt:
platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.checksum:
platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.png:
platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.checksum:
platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.png:
platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.checksum:
platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.png:
platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.checksum:
platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.png:
platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.checksum:
platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.png:
platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.txt:
platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.checksum:
platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.png:
platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.txt:
platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.checksum:
platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.png:
platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.txt:
platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.checksum:
platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.png:
platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.txt:
platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.checksum:
platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
platform/qt/svg/text/select-x-list-1-expected.checksum:
platform/qt/svg/text/select-x-list-1-expected.png:
platform/qt/svg/text/select-x-list-1-expected.txt:
platform/qt/svg/text/select-x-list-2-expected.checksum:
platform/qt/svg/text/select-x-list-2-expected.png:
platform/qt/svg/text/select-x-list-2-expected.txt:
platform/qt/svg/text/select-x-list-3-expected.checksum:
platform/qt/svg/text/select-x-list-3-expected.png:
platform/qt/svg/text/select-x-list-3-expected.txt:
platform/qt/svg/text/select-x-list-4-expected.checksum:
platform/qt/svg/text/select-x-list-4-expected.png:
platform/qt/svg/text/select-x-list-4-expected.txt:
platform/qt/svg/text/select-x-list-with-tspans-1-expected.checksum:
platform/qt/svg/text/select-x-list-with-tspans-1-expected.png:
platform/qt/svg/text/select-x-list-with-tspans-1-expected.txt:
platform/qt/svg/text/select-x-list-with-tspans-2-expected.checksum:
platform/qt/svg/text/select-x-list-with-tspans-2-expected.png:
platform/qt/svg/text/select-x-list-with-tspans-2-expected.txt:
platform/qt/svg/text/select-x-list-with-tspans-3-expected.checksum:
platform/qt/svg/text/select-x-list-with-tspans-3-expected.png:
platform/qt/svg/text/select-x-list-with-tspans-3-expected.txt:
platform/qt/svg/text/select-x-list-with-tspans-4-expected.checksum:
platform/qt/svg/text/select-x-list-with-tspans-4-expected.png:
platform/qt/svg/text/select-x-list-with-tspans-4-expected.txt:
platform/qt/svg/text/selection-doubleclick-expected.checksum:
platform/qt/svg/text/selection-doubleclick-expected.png:
platform/qt/svg/text/selection-doubleclick-expected.txt:
platform/qt/svg/text/selection-tripleclick-expected.checksum:
platform/qt/svg/text/selection-tripleclick-expected.png:
platform/qt/svg/text/selection-tripleclick-expected.txt:
platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.checksum:
platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.png:
platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum: Added.
platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.checksum:
platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.png:
platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.txt:

8:58 AM Changeset in webkit [77496] by Simon Fraser

2 edits in trunk/Source/WebCore

2011-02-03 Simon Fraser <Simon Fraser>

Fix 32-bit builds.

platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::blurLayerImage):

8:32 AM Changeset in webkit [77495] by mnaganov@chromium.org

17 edits
1 copy in trunk/Source/WebCore

2011-02-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Add reporting of JS heap size limit to 'console.memory'.
https://bugs.webkit.org/show_bug.cgi?id=53592

In JSC there is no limit, thus 'undefined' value is returned.
For V8, the limit reported by the VM is returned.

Android.jscbindings.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSBindingsAllInOne.cpp:
bindings/js/JSMemoryInfoCustom.cpp: Added.
bindings/js/ScriptGCEvent.cpp: (WebCore::ScriptGCEvent::getHeapSize):
bindings/js/ScriptGCEvent.h:
bindings/v8/ScriptGCEvent.cpp: (WebCore::ScriptGCEvent::getHeapSize):
bindings/v8/ScriptGCEvent.h:
inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
page/MemoryInfo.cpp: (WebCore::MemoryInfo::MemoryInfo):
page/MemoryInfo.h: (WebCore::MemoryInfo::jsHeapSizeLimit):
page/MemoryInfo.idl:

8:29 AM Changeset in webkit [77494] by Philippe Normand

4 edits in trunk

2011-01-27 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] LayoutTests/media/audio-mpeg4-supported.html fails
https://bugs.webkit.org/show_bug.cgi?id=53125

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache): Add audio/x-m4a mimetype in the cache.

LayoutTests:

2011-01-27 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] LayoutTests/media/audio-mpeg4-supported.html fails
https://bugs.webkit.org/show_bug.cgi?id=53125

platform/gtk/Skipped: Unskip fixed test.

8:19 AM Changeset in webkit [77493] by Philippe Normand

2 edits in trunk/LayoutTests

2011-02-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, skipping 2 more websocket tests on GTK, see bug 53683.

platform/gtk/Skipped: skip http/tests/websocket/tests/simple.html and http/tests/websocket/tests/cross-origin.html

8:10 AM Changeset in webkit [77492] by Simon Fraser

39 edits in trunk

2011-02-03 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

ShadowBlur radius for CSS shadows is slightly too big
https://bugs.webkit.org/show_bug.cgi?id=53660

If we follow SVG gaussian blur for CSS shadows, we can end up rendering
shadows that extend further than the CSS "blur radius", which results
in the shadows being truncated.

Fix with a small fudge factor to reduce the kernel diameter slightly
for CSS shadows.

Also more closely follow the algorithm described in the SVG spec
for computing the kernel size for different diameters, and clean up
some variable naming relating to the shadow bounds.

platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::blurLayerImage): (WebCore::ShadowBlur::drawRectShadowWithTiling):

8:02 AM Changeset in webkit [77491] by Patrick Gansterer

5 edits in trunk/Source/JavaScriptCore

2011-02-03 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Avoid strlen() in AtomicString::fromUTF8
https://bugs.webkit.org/show_bug.cgi?id=50516

Add an overload to calculateStringHashFromUTF8 to get
strlen() of the input data with only one call.

This change shows about 3% performance win on the xml-parser benchmark.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
wtf/text/AtomicString.cpp: (WTF::AtomicString::fromUTF8):
wtf/unicode/UTF8.cpp: (WTF::Unicode::calculateStringHashAndLengthFromUTF8Internal): (WTF::Unicode::calculateStringHashFromUTF8): (WTF::Unicode::calculateStringHashAndLengthFromUTF8):
wtf/unicode/UTF8.h:

7:51 AM Changeset in webkit [77490] by Philippe Normand

43 edits in trunk/LayoutTests

2011-02-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, rebaseline GTK svg tests after r77485.

platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
platform/gtk/svg/css/composite-shadow-text-expected.txt:
platform/gtk/svg/css/group-with-shadow-expected.txt:
platform/gtk/svg/css/shadow-changes-expected.txt:
platform/gtk/svg/css/text-gradient-shadow-expected.txt:
platform/gtk/svg/custom/stroke-width-large-expected.txt:
platform/gtk/svg/custom/text-rotated-gradient-expected.txt:
platform/gtk/svg/custom/text-rotation-expected.txt:
platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
platform/gtk/svg/hixie/text/001-expected.txt:
platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt:
platform/gtk/svg/text/select-textLength-spacing-stretch-2-expected.txt:
platform/gtk/svg/text/select-textLength-spacing-stretch-3-expected.txt:
platform/gtk/svg/text/select-textLength-spacing-stretch-4-expected.txt:
platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
platform/gtk/svg/text/select-x-list-1-expected.txt:
platform/gtk/svg/text/select-x-list-2-expected.txt:
platform/gtk/svg/text/select-x-list-3-expected.txt:
platform/gtk/svg/text/select-x-list-4-expected.txt:
platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt:
platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt:
platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt:
platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt:
platform/gtk/svg/text/selection-doubleclick-expected.txt:
platform/gtk/svg/text/selection-tripleclick-expected.txt:
platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
platform/gtk/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:

7:24 AM Changeset in webkit [77489] by podivilov@chromium.org

27 edits in trunk

2011-02-01 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: introduce new api for managing JavaScript breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=53235

inspector/report-protocol-errors.html:

2011-02-01 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: introduce new api for managing JavaScript breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=53235

Single protocol breakpoint (e.g. set by url) is mapped on zero or more VM breakpoints (set by sourceID).
removeJavaScriptBreakpoint(breakpointId) removes breakpoint and all linked VM breakpoints.
Since UI uses VM breakpoint location rather then protocol breakpoint location, all resolved breakpoints locations are passed to frontend.

SourceFrame is now aware of whether breakpoint is resolved or not and may display it accordingly.
JavaScriptBreakpointsSidebarPane filters out breakpoints set on nonexistent scripts to avoid UI cluttering.

bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint):
bindings/js/ScriptDebugServer.h:
bindings/v8/DebuggerScript.js: ():
bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint):
bindings/v8/ScriptDebugServer.h:
inspector/Inspector.idl:
inspector/InspectorAgent.cpp: clear breakpoints from inspector state when new frontend is created (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::restoreDebugger): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::enableDebugger):
inspector/InspectorAgent.h:
inspector/InspectorDebuggerAgent.cpp: manage relations between protocol breakpoints and VM breakpoints (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::inspectedURLChanged): (WebCore::InspectorDebuggerAgent::setJavaScriptBreakpoint): (WebCore::InspectorDebuggerAgent::setJavaScriptBreakpointBySourceId): (WebCore::InspectorDebuggerAgent::removeJavaScriptBreakpoint): (WebCore::InspectorDebuggerAgent::continueToLocation): (WebCore::InspectorDebuggerAgent::resolveBreakpoint): (WebCore::InspectorDebuggerAgent::getScriptSource): (WebCore::InspectorDebuggerAgent::didParseSource): (WebCore::InspectorDebuggerAgent::didPause):
inspector/InspectorDebuggerAgent.h: (WebCore::InspectorDebuggerAgent::Script::Script):
inspector/InspectorValues.cpp: (WebCore::InspectorValue::asNumber): (WebCore::InspectorBasicValue::asNumber): (WebCore::InspectorObject::remove):
inspector/InspectorValues.h: (WebCore::InspectorObject::getNumber): (WebCore::InspectorObject::find):
inspector/ScriptBreakpoint.h: (WebCore::ScriptBreakpoint::ScriptBreakpoint):
inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint): (WebInspector.Breakpoint.prototype.addLocation):
inspector/front-end/BreakpointManager.js: remove all stuff related to JavaScript breakpoints from here (WebInspector.BreakpointManager): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._saveBreakpoints): (WebInspector.BreakpointManager.prototype._validateBreakpoints):
inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.JavaScriptBreakpointsSidebarPane): filter breakpoints set on nonexistent scripts to avoid ui cluttering
inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): pull all JavaScript from localStorage and push them to fronted when debugger is enabled, save resolved breakpoints data
inspector/front-end/Script.js: (WebInspector.Script.prototype.sourceLine):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._toggleDebugging):
inspector/front-end/Settings.js: (WebInspector.Settings):
inspector/front-end/SourceFrame.js: handle resolved and unresolved breakpoints differently
inspector/front-end/inspector.js:

2011-02-01 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: introduce new api for managing JavaScript breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=53235

src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgent::shouldInterruptForMessage):

7:22 AM Changeset in webkit [77488] by Philippe Normand

2 edits in trunk/LayoutTests

2011-02-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip flaky websocket tests on GTK
https://bugs.webkit.org/show_bug.cgi?id=53683

platform/gtk/Skipped:

7:15 AM Changeset in webkit [77487] by apavlov@chromium.org

2 edits in trunk/LayoutTests

2011-02-03 Alexander Pavlov <apavlov@chromium.org>

Unreviewed, fix build after r77478.

inspector/styles-source-lines-inline.html: Roll back inadvertent function rename.

6:57 AM Changeset in webkit [77486] by Philippe Normand

2 edits in trunk/LayoutTests

2011-02-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip flaky test
fast/frames/sandboxed-iframe-scripting.html on GTK
https://bugs.webkit.org/show_bug.cgi?id=53680

platform/gtk/Skipped:

6:46 AM Changeset in webkit [77485] by Nikolas Zimmermann

366 edits
181 adds in trunk

2011-02-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448

SVG <text> with font-size smaller or equal to 1 does not paint correctly
https://bugs.webkit.org/show_bug.cgi?id=14242

misplaced text in SVG
https://bugs.webkit.org/show_bug.cgi?id=17053

Don't render very small (but zoomed) text inside SVG
https://bugs.webkit.org/show_bug.cgi?id=19393

Tiny fonts scaled up end up too large in Safari
https://bugs.webkit.org/show_bug.cgi?id=20192

Stretched SVG Text has awful glyph spacing
https://bugs.webkit.org/show_bug.cgi?id=21774

REGRESSION (r72141?): svg/batik/text/smallFonts.svg failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=49846

[Gtk] Text height in zoomed SVG is 1px too high
https://bugs.webkit.org/show_bug.cgi?id=50313

SVG text smaller than 0.5px not displayed properly
https://bugs.webkit.org/show_bug.cgi?id=50528

When rendering text, we're selecting a font with a size, as specified in the markup.
This can lead to problems, if the context, where the text is rendered upon, is scaled. If a parent
element of the <text> defines a transform=".." or the outermost <svg> containing a viewBox the
problem becomes apparent.

Consider following two snippets, which should render exactly the same:
<svg viewBox="0 0 100 100"><text x="25" y="50" font-size="25">test</text></svg>
<svg viewBox="0 0 1 1"><text x="0.25" y="0.5" font-size="0.25">test</text></svg>

When selecting a font size below 0.5, FontCacheMac would request a font with size 0,
which AppKit turns into 12. This lead to huge text rendering, instead of small text on Mac.
Other platforms have different problems (Qt simply scales the font, leading to pixelation etc.)

To fix this in a cross-platform fashion, we now always compute the final font size on screen,
remove any scaling from the context, draw the text using the scaled font size, then reapply
the context scale. This makes the example snippets above render exactly the same and fixes
numerous of bugs, present since years. As we're now heavily using floating-point font sizes
internally, depending on the scale of the document, it's very important to use the new
floating-point text metrics information (floatAscent/floatDescent/floatHeight) everywhere in SVG.

Fixes existing tests: css3/zoom-coords.xhtml (cross-platform inconsistencies should be gone, mac now reports floatHeight values for SVG text height)

svg/hixie/text/003.html (no more pixelation)
svg/batik/text/smallFonts.svg (small fonts aren't rendered huge anymore on mac)
svg/hixie/viewbox/preserveAspectRatio/001.xml (bug 21774, no more awful spacing)
svg/zoom/page/zoom-zoom-coords.xhtml (cross-platform inconsistencies should be gone, inspired by bug 50313)

Tests: svg/text/font-size-below-point-five-2.svg (reduction from bug 50528)

svg/text/font-size-below-point-five.svg (reduction from bug 50528)
svg/text/scaled-font.svg (reduction from bug 12448)
svg/text/small-fonts-2.svg (reduction from bug 14242)
svg/text/small-fonts-3.svg (reduction from bug 17053)
svg/text/small-fonts-in-html5.html (reduction from bug 19393)
svg/text/small-fonts.svg (reduction from bug 20192))

rendering/svg/RenderSVGInlineText.cpp: Cache 'float scalingFactor' & 'Font scaledFont', whenever the on-screen representation changes.
rendering/svg/RenderSVGInlineText.h:
rendering/svg/RenderSVGText.cpp: Update scalingFactor/scaledFont, if necessary.
rendering/svg/SVGInlineTextBox.cpp: Switch to new font rendering strategy. Always use scaledFont, and remove any context scale before drawing.
rendering/svg/SVGInlineTextBox.h:
rendering/svg/SVGTextLayoutEngineBaseline.cpp: Use floating-point metrics everywhere.
rendering/svg/SVGTextMetrics.cpp: Ditto.
rendering/svg/SVGTextMetrics.h: Ditto.
rendering/svg/SVGTextQuery.cpp: Ditto.
svg/SVGFont.cpp: Adjust stroke thickness, when drawing SVGFonts into a normalized context (no more scale).
svg/SVGTextContentElement.cpp: Make <text> elements always dependant on window size changes in combination with viewBox set.
svg/SVGTextPositioningElement.cpp: Remove now unnecessary code to determine wheter relative lengths are used as text attributes.
svg/SVGTextPositioningElement.h:

2011-02-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448

Update SVG test results after fixing small font size support. Land new mac/mac-leopard baseline, as text looks slightly different
in each testcase, as the font-size used for on-screen rendering has changed, this results in hinting differences, inter-glyph
space changes, etc. This commit only includes the textual result changes, the pixel test baseline will land in chunks in follow-up commits.

To those who have to rebaseline their platforms: Some of the svg/text pixel test results may look questionable on first sight,

svg/text/select-* tests: These tests render a certain string 'Foobar' and query the metrics using SVG Text DOM API (getExtentOfChar(firstChar) and getExtentOfChar(lastChar)). A red rectangle is drawn, to represent the size of the string, which gives precise results using floating-point accurancy. Using eventSender, a selection is simulated, by clicking the first char, holding down, and moving towards the last character. The blue selection rect which is drawn, should in theory be equal to the red rectangle. In practice it is not, as the selection rect is aligned to integer boundaries (see floor calls in Font::selectionRect...). Since we switched to use floating-point precision metrics, the actual drawn selection may exceed the red rectangle up to 1px.

svg/text/selection-(doubleclick|tripleclick).svg: These tests use DRTs dumpSelectionRect() which draws a red rectangle, highlighting the SelectionController::bounds() obtained through RenderView. In theory this red rectangle, should be equal to the drawn blue selection rect. Again it isn't, as the bounds() methods uses selectionRectForRepaint() of RenderText, which returns an enclosingIntRect of the actual selection. The drawn selection starts at y=0.93 in the first testcase, the selectionRectForRepaint() call returns an IntRect, which starts at y=0. That explains why the red rectangle starts slightly higher as it should be. Again this is no problem, the repaint rect may be 1px larger, if it would be smaller, we had a problem. The only way to fix this, would be to pass around FloatRect as repaint rects, but that's not worth it.

css3/zoom-coords.* / svg/zoom/page/zoom-zoom-coords*: These tests have different expectations now, as we're using the floatAscent/floatDesent/floatHeight FontMetrics methods instead of the integer variants ascent/descent/height - hopefully we'll see consistent results across platforms for these tests now, if not please comment in the bug report.

css3/zoom-coords-expected.txt:
css3/zoom-coords.xhtml:
platform/mac-leopard/Skipped:
platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum: Added.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum: Added.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
platform/mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.

...

6:38 AM Changeset in webkit [77484] by loislo@chromium.org

2 edits in trunk/LayoutTests

2011-02-03 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed.

BUGCR71783 : scrollbars/custom-scrollbar-with-incomplete-style.html = IMAGE
It is failing since r77459 by Sam Weinig.

platform/chromium/test_expectations.txt:

6:22 AM Changeset in webkit [77483] by Adam Roben

2 edits in trunk/LayoutTests

Skip a new showModalDialog test on Windows

showModalDialog support is now covered by <http://webkit.org/b/53675>.

I also sorted some sputnik tests that fail when showModalDialog is unsupported, and filed a
new bug (<http://webkit.org/b/53676>) about those failures, since it seems like those tests
should pass even when showModalDialog is unsupported.

platform/win/Skipped:

6:22 AM Changeset in webkit [77482] by Adam Roben

1 edit
1 add in trunk/LayoutTests

Check in expected failure results for an RTL <select> test

The failure is covered by <http://webkit.org/b/53443>.

platform/win/fast/text/international/bidi-menulist-expected.txt: Added.

6:21 AM Changeset in webkit [77481] by Adam Roben

1 edit
3 adds in trunk/LayoutTests

Add Windows results for test added in r77153

platform/win/fast/text/international/text-combine-image-test-expected.checksum: Added.
platform/win/fast/text/international/text-combine-image-test-expected.png: Added.
platform/win/fast/text/international/text-combine-image-test-expected.txt: Added.

5:45 AM Changeset in webkit [77480] by pfeldman@chromium.org

3 edits in trunk/Source/WebCore

2011-02-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: resources panel doesn't show frames after reload.
https://bugs.webkit.org/show_bug.cgi?id=53430

inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype.loadEventFired): (WebInspector.ResourcesPanel.prototype._initDefaultSelection): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.clear):
inspector/front-end/inspector.js: (WebInspector.loadEventFired):

5:43 AM Changeset in webkit [77479] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed.

[Qt]REGRESSION(r76951): media/controls-without-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=53674

platform/qt/Skipped: media/controls-without-preload.html added until fix.

5:06 AM WebKit Team edited by rgabor@webkit.org

(diff)

5:04 AM Changeset in webkit [77478] by apavlov@chromium.org

12 edits in trunk

2011-02-01 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Remove the *2 suffix from the CSS style-related protocol methods
https://bugs.webkit.org/show_bug.cgi?id=53492

WebCore:

inspector/Inspector.idl:
inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode): (WebCore::InspectorCSSAgent::getInlineStyleForNode): (WebCore::InspectorCSSAgent::getComputedStyleForNode): (WebCore::InspectorCSSAgent::getAllStyles): (WebCore::InspectorCSSAgent::getStyleSheet): (WebCore::InspectorCSSAgent::getStyleSheetText): (WebCore::InspectorCSSAgent::setStyleSheetText): (WebCore::InspectorCSSAgent::setPropertyText): (WebCore::InspectorCSSAgent::toggleProperty): (WebCore::InspectorCSSAgent::setRuleSelector): (WebCore::InspectorCSSAgent::addRule):
inspector/InspectorCSSAgent.h:
inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.getStylesAsync): (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync): (WebInspector.CSSStyleModel.prototype.getInlineStyleAsync): (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.addRule): (WebInspector.CSSStyleModel.prototype._styleSheetChanged): (WebInspector.CSSStyleModel.prototype._onRevert): (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt): (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setDisabled): (WebInspector.CSSStyleSheet.createForId): (WebInspector.CSSStyleSheet.prototype.setText):

LayoutTests:

inspector/styles-iframe.html:
inspector/styles-new-API.html:
inspector/styles-source-lines-inline.html:
inspector/styles-source-lines.html:
inspector/styles-source-offsets.html:

4:52 AM Changeset in webkit [77477] by Philippe Normand

2 edits in trunk/LayoutTests

2011-02-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip flaky test
fast/files/workers/worker-read-blob-async.html on GTK
https://bugs.webkit.org/show_bug.cgi?id=53673

platform/gtk/Skipped:

4:36 AM Changeset in webkit [77476] by rgabor@webkit.org

2 edits in trunk/Tools

Unreviewed.

Adding myself to committers.py.

Scripts/webkitpy/common/config/committers.py:

4:33 AM Changeset in webkit [77475] by Csaba Osztrogonác

1 edit
2 copies
4 adds in trunk/LayoutTests

Unreviewed.

[Qt] fast/dynamic/unicode-bidi.html fails
https://bugs.webkit.org/show_bug.cgi?id=53456

Add Qt specific expected files.

platform/qt/fast/dynamic/unicode-bidi-expected.checksum: Added.
platform/qt/fast/dynamic/unicode-bidi-expected.png: Added.
platform/qt/fast/dynamic/unicode-bidi-expected.txt: Copied from LayoutTests/fast/dynamic/unicode-bidi-expected.txt.
platform/qt/fast/text/bidi-embedding-pop-and-push-same-2-expected.checksum: Added.
platform/qt/fast/text/bidi-embedding-pop-and-push-same-2-expected.png: Added.
platform/qt/fast/text/bidi-embedding-pop-and-push-same-2-expected.txt: Copied from LayoutTests/fast/text/bidi-embedding-pop-and-push-same-2-expected.txt.

4:04 AM Changeset in webkit [77474] by Philippe Normand

1 edit
2 adds in trunk/LayoutTests

2011-02-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK baselines for 2 new tests added in r77267 and r77153.

platform/gtk/fast/dom/34176-expected.txt: Added.
platform/gtk/fast/text/international/text-combine-image-test-expected.txt: Added.

3:09 AM Changeset in webkit [77473] by kbalazs@webkit.org

2 edits in trunk/Tools

2011-02-03 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2] MiniBrowser's window size should be 800x600
https://bugs.webkit.org/show_bug.cgi?id=53670

Make layout test failure debugging easier.

MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow):

1:41 AM Changeset in webkit [77472] by Philippe Normand

2 edits in trunk/LayoutTests

2011-02-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip failing test
fast/history/timed-refresh-in-cached-frame.html on GTK
https://bugs.webkit.org/show_bug.cgi?id=53667

platform/gtk/Skipped:

1:37 AM Changeset in webkit [77471] by mjs@apple.com

2 edits in trunk/LayoutTests

2011-02-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Ryosuke Niwa.

Skip some tests that fail in WebKit2 due to missing DRT functionality
https://bugs.webkit.org/show_bug.cgi?id=53666

platform/mac-wk2/Skipped:

12:59 AM Changeset in webkit [77470] by abarth@webkit.org

3 edits
2 adds in trunk

2011-02-03 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Teach XSSFilter about data URLs
https://bugs.webkit.org/show_bug.cgi?id=53662

Tests that the XSS filter doesn't block script in data URLs.

http/tests/security/xssAuditor/data-urls-work-expected.txt: Added.
http/tests/security/xssAuditor/data-urls-work.html: Added.

2011-02-03 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Teach XSSFilter about data URLs
https://bugs.webkit.org/show_bug.cgi?id=53662

The XSS filter doesn't really make sense for data URLs because
everything in a "response" from a data URL was part of the request.

Test: http/tests/security/xssAuditor/data-urls-work.html

html/parser/XSSFilter.cpp: (WebCore::XSSFilter::init): (WebCore::XSSFilter::filterToken):

12:11 AM Changeset in webkit [77469] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

2011-02-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77449.
http://trac.webkit.org/changeset/77449
https://bugs.webkit.org/show_bug.cgi?id=53663

causes many WebKit2 tests to crash (Requested by othermaciej
on #webkit).

Shared/API/c/WKSharedAPICast.h: (WebKit::toAPI): (WebKit::toCopiedAPI): (WebKit::toURLRef): (WebKit::toCopiedURLAPI):
Shared/WebString.h: (WebKit::WebString::isNull): (WebKit::WebString::WebString):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed