Timeline
Feb 8, 2011:
- 11:59 PM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 11:58 PM Changeset in webkit [78027] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Incorrect assertion in WorkQueueGtk, we need to register
more than one handle
https://bugs.webkit.org/show_bug.cgi?id=54014
Fixed assertion condition we need to register more than one
handler for the same file descriptor.
- Platform/gtk/WorkQueueGtk.cpp: (WorkQueue::registerEventSourceHandler):
- 11:58 PM Changeset in webkit [78026] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt]Missing layoutTestController.displayInvalidatedRegion()
plugins/invalidate_rect.html introduced in r78010, but unfortunately
Qt DRT doesn't have layoutTestController.displayInvalidatedRegion().
- platform/qt/Skipped: Add plugins/invalidate_rect.html.
- 11:43 PM Changeset in webkit [78025] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
Fix typo in the include guards name in ChunkedUpdateDrawingAreaProxy.h
https://bugs.webkit.org/show_bug.cgi?id=54013
- UIProcess/ChunkedUpdateDrawingAreaProxy.h:
- 11:42 PM Changeset in webkit [78024] by
-
- 2 edits in trunk/Source/WebKit/mac
<rdar://problem/8959420> Find in Mail no longer cycles around
Reviewed by Jon Honeycutt and Maciej Stachowiak.
- WebView/WebHTMLView.mm:
(-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Set
the wrap option according to the flag.
- 11:30 PM Changeset in webkit [78023] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Kent Tamura.
Skip a freshly added test that depends on newly added DRT functionality
https://bugs.webkit.org/show_bug.cgi?id=54069
- platform/mac-wk2/Skipped:
- 11:25 PM Changeset in webkit [78022] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix after r77874, m_isConnected is initialized before the
socket is opened
https://bugs.webkit.org/show_bug.cgi?id=54011
Fixed connection breakage after r77874, we have to wait until open
the socket to open the connection.
- Platform/CoreIPC/gtk/ConnectionGtk.cpp: (CoreIPC::Connection::platformInitialize): (CoreIPC::Connection::open):
- 11:21 PM Changeset in webkit [78021] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[WK2] LayerTreeContext is used outside the ACCELERATED_COMPOSITING
guards but not defined in DrawingAreaProxy.h
https://bugs.webkit.org/show_bug.cgi?id=54009
Removed the guards in the forward declaration, this will fail if
the class is finally used in the function, but it works for the
moment.
- UIProcess/DrawingAreaProxy.h:
- 11:16 PM Changeset in webkit [78020] by
-
- 5 edits in trunk
2011-02-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
WebKit2 GTK Fails to Build #include nested too deeply
https://bugs.webkit.org/show_bug.cgi?id=52219
- GNUmakefile.am: Removed the commands to create the directories for the forwarding headers, the script already does it for us.
- config.h: Removed the config.h inclusion and added the autotoolsconfig.h directly, also added a condition to share the defines with QT.
2011-02-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
WebKit2 GTK Fails to Build #include nested too deeply
https://bugs.webkit.org/show_bug.cgi?id=52219
Removed the STDC_FORMAT_MACROS definition, it is already defined
in the file where PRIxx64 is used before the inclusion so we are
safe.
- configure.ac:
- 10:42 PM Changeset in webkit [78019] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
2011-02-08 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
fix toolbar anchoring in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=54058
Avoid the anchoring cycle of doom when on the cusp
of whether the toolbar needs to be anchored and
speculatively avoid the Firefox crash when resizing.
- PrettyPatch/PrettyPatch.rb:
- code-review.js:
- 10:09 PM Changeset in webkit [78018] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed some dead code from Heap
https://bugs.webkit.org/show_bug.cgi?id=54064
- runtime/MarkedSpace.cpp: Removed some now-unused constants and declarations.
(JSC::MarkedSpace::allocate): Removed some ASSERTs that are also ASSERTed
by our caller. Removed redundant typedefs.
- 9:59 PM Changeset in webkit [78017] by
-
- 4 edits in trunk/Source/JavaScriptCore
2011-02-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Use a vector to track blocks in the Heap, instead of hand-rolled vector-like code
https://bugs.webkit.org/show_bug.cgi?id=54062
SunSpider reports no change.
- runtime/CollectorHeapIterator.h: (JSC::CollectorHeapIterator::isValid): (JSC::CollectorHeapIterator::isLive): Updated for new mark invariant: To know if an object is live, you just need to test its mark bit.
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): Moved waterMark and highWaterMark from CollectorHeap into MarkedSpace, since they're global state. Removed call to memset since CollectorHeap is a true class with its own constructor now.
(JSC::MarkedSpace::destroy): Change uses of m_heap.usedBlocks to
m_heap.blocks.size(), and m_heap.numBlocks to m_heap.blocks.capacity().
(JSC::MarkedSpace::allocateBlock):
(JSC::MarkedSpace::freeBlock): No need to manage our vector manually anymore.
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::shrink):
(JSC::MarkedSpace::clearMarkBits):
(JSC::MarkedSpace::markedCells):
(JSC::MarkedSpace::sweep):
(JSC::MarkedSpace::objectCount):
(JSC::MarkedSpace::capacity):
(JSC::MarkedSpace::reset):
(JSC::MarkedSpace::primaryHeapEnd):
- runtime/MarkedSpace.h: (JSC::CollectorHeap::CollectorHeap): (JSC::MarkedSpace::highWaterMark): (JSC::MarkedSpace::setHighWaterMark): (JSC::MarkedSpace::contains): Same as above.
- 9:46 PM Changeset in webkit [78016] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Mark Rowe.
Skip some tests that fail in WebKit2 for obvious reasons
https://bugs.webkit.org/show_bug.cgi?id=54055
- platform/mac-wk2/Skipped:
- 9:40 PM Changeset in webkit [78015] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Mark Rowe.
Crash when going back/forward when back/forward list is in a bad state.
https://bugs.webkit.org/show_bug.cgi?id=54059
<rdar://problem/8975244>
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::goForward): Add a null check. (WebKit::WebPageProxy::goBack): ditto
- 9:33 PM Changeset in webkit [78014] by
-
- 5 edits in trunk/Tools
2011-02-08 Hayato Ito <hayato@chromium.org>
Reviewed by Tony Chang.
[NRWT] Pull up rebaseline code from compare_output() function defined
in text_diff.py and image_diff.py into a SingleTestRunner.
This patch is a first step for eliminating test_type/* classes.
- Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
- Scripts/webkitpy/layout_tests/test_types/image_diff.py:
- Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
- Scripts/webkitpy/layout_tests/test_types/text_diff.py:
- 8:34 PM Changeset in webkit [78013] by
-
- 2 edits in trunk
2011-02-08 Kristian Amlie <kristian.amlie@nokia.com>
Reviewed by Eric Seidel.
Added include paths for QtScript.
WebKit patches required to work with a modularized version of Qt
https://bugs.webkit.org/show_bug.cgi?id=53916
- Source/WebKit.pri:
- 8:32 PM Changeset in webkit [78012] by
-
- 6 edits in trunk/Tools
2011-02-07 Ojan Vafai <ojan@chromium.org>
Reviewed by Mihai Parparita.
stop generating results.json files
https://bugs.webkit.org/show_bug.cgi?id=53977
We've only used incremental_results.json for a while now
and there are plans to start generating a results.json file that matches
the format of unexpected_results.json.
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 8:17 PM Changeset in webkit [78011] by
-
- 5 edits2 adds in trunk
2011-02-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION(71556,68059): queryCommandValue screws up background color at collapsed cursor
https://bugs.webkit.org/show_bug.cgi?id=53196
The bug was caused by Editor::selectionComputedStyle's modifying typing style without making a copy,
and its removing non-inheritable properties from the typing style. Fixed the bug by making a copy
before making the modification and not removing non-inheritable properties.
Also fixed a bug in selectionStartCSSPropertyValue that it doesn't handle xx-small to -webkit-xxx-large
by extracting a function from StyleChange::extractTextStyles and calling it in both extractTextStyles
and selectionStartCSSPropertyValue.
Test: editing/style/query-typing-style.html
- editing/ApplyStyleCommand.cpp: (WebCore::legacyFontSizeFromCSSValue): Extracted from StyleChange::extractTextStyles. (WebCore::StyleChange::extractTextStyles): Calls legacyFontSizeFromCSSValue; this fixes the bug that CSS values from xx-small through -webkit-xxx-large are not accounted.
- editing/ApplyStyleCommand.h:
- editing/Editor.cpp: (WebCore::Editor::selectionStartCSSPropertyValue): Calls legacyFontSizeFromCSSValue. (WebCore::Editor::selectionComputedStyle): Makes a copy before modifying typing style. No longer calls removeNonEditingProperties on the copied typing style so that background-color property is included when merged into the style.
2011-02-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION(71556,68059): queryCommandValue screws up background color at collapsed cursor
https://bugs.webkit.org/show_bug.cgi?id=53196
Added a test to ensure calling queryCommandValue returns the correct value for backColor
and fontSize from typing style.
- editing/style/query-typing-style-expected.txt: Added.
- editing/style/query-typing-style.html: Added.
- 7:30 PM Changeset in webkit [78010] by
-
- 11 edits2 adds in trunk
2011-02-08 Sailesh Agrawal <sail@chromium.org>
Reviewed by Kenneth Russell.
Invalidate rect doesn't work for windowless plugins on Chromium
https://bugs.webkit.org/show_bug.cgi?id=53117
Added a test to make sure that NPN_InvalidateRect() works correctly for windowless plugins.
- plugins/invalidate_rect-expected.txt: Added.
- plugins/invalidate_rect.html: Added.
2011-02-08 Sailesh Agrawal <sail@chromium.org>
Reviewed by Kenneth Russell.
Invalidate rect doesn't work for windowless plugins on Chromium
https://bugs.webkit.org/show_bug.cgi?id=53117
Invalidate rect for windowless plugins wasn't working if the web page was composited.
The problem was that the invalidate call was causing simply dirtying the LayerChromium layers. Since the plugin was windowless this didn't cause the plugin to be repainted.
Fix was to copy the invalidate code from WebCore/plugins/PluginView.cpp/PluginView::invalidateWindowlessPluginRect() which does the correct thing.
Tested my fix on Windows and Mac and verified that the movie on http://apple.com/appltv correctly plays. Verified that windowed plugins still correctly draw as well.
- src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::invalidateRect):
2011-02-08 Sailesh Agrawal <sail@chromium.org>
Reviewed by Kenneth Russell.
Invalidate rect doesn't work for windowless plugins on Chromium
https://bugs.webkit.org/show_bug.cgi?id=53117
Added two new utility methods.
- layoutTestController.displayInvalidatedRegion() does a paint of any area that has been invalidated. This is different from layoutTestController.display() which explicitly invalidates the entire page then paints.
- plugin.invalidateRect(left, top, right, bottom) - invalidates the given rect This is used to test that invalidating a rect correctly causes a repaint of the plugin.
- DumpRenderTree/LayoutTestController.cpp: (displayInvalidatedRegionCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (invalidateRect): (pluginInvoke):
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::displayInvalidatedRegion):
- DumpRenderTree/chromium/LayoutTestController.h:
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
- 6:59 PM Changeset in webkit [78009] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r76831): Subframes are printed blank
<rdar://problem/8945867>
Reviewed by Maciej Stachowiak.
- page/FrameView.cpp:
(WebCore::FrameView::paintOverhangAreas):
Don't paint overhangs when printing.
- 6:43 PM Changeset in webkit [78008] by
-
- 1 edit1 delete in trunk/LayoutTests
2011-02-08 Mihai Parparita <mihaip@chromium.org>
Unreviewed. Remove chromium-gpu-win baseline that has a failing result,
since we now pass the test.
- platform/chromium-gpu-win/compositing/animation/animated-composited-inside-hidden-expected.txt: Removed.
- 6:39 PM Changeset in webkit [78007] by
-
- 20 edits1 copy99 adds in trunk/LayoutTests
2011-02-08 Mihai Parparita <mihaip@chromium.org>
Unreviewed chromium-gpu-win rebaseline.
- platform/chromium-gpu-win/compositing/direct-image-compositing-expected.txt:
- platform/chromium-gpu-win/compositing/geometry/composited-html-size-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/composited-html-size-expected.png: Copied from LayoutTests/platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.png.
- platform/chromium-gpu-win/compositing/geometry/composited-html-size-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.checksum:
- platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
- platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.txt:
- platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.checksum:
- platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/tall-page-composited-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/tall-page-composited-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.checksum:
- platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.txt:
- platform/chromium-gpu-win/compositing/iframes/composited-iframe-scroll-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/iframes/composited-iframe-scroll-expected.png: Added.
- platform/chromium-gpu-win/compositing/iframes/composited-iframe-scroll-expected.txt: Added.
- platform/chromium-gpu-win/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/chromium-gpu-win/compositing/images/direct-svg-image-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/images/direct-svg-image-expected.png: Added.
- platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.png: Added.
- platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.txt: Added.
- platform/chromium-gpu-win/compositing/masks/simple-composited-mask-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/masks/simple-composited-mask-expected.png: Added.
- platform/chromium-gpu-win/compositing/masks/simple-composited-mask-expected.txt: Added.
- platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.checksum:
- platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
- platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.txt:
- platform/chromium-gpu-win/compositing/reflections/animation-inside-reflection-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/animation-inside-reflection-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/animation-inside-reflection-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/compositing-change-inside-reflection-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/compositing-change-inside-reflection-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/masked-reflection-on-composited-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/masked-reflection-on-composited-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-mask-change-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-mask-change-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-on-overflow-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-on-overflow-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-on-overflow-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-opacity-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-opacity-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-opacity-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-size-change-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-size-change-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-size-change-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-ordering-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-ordering-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-ordering-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-positioning-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-positioning-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-positioning-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-positioning2-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-positioning2-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-positioning2-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/remove-add-reflection-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/remove-add-reflection-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/simple-composited-reflections-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/simple-composited-reflections-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/simple-composited-reflections-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.txt: Added.
- platform/chromium-gpu-win/compositing/repaint/content-into-overflow-expected.txt:
- platform/chromium-gpu-win/compositing/repaint/overflow-into-content-expected.txt:
- platform/chromium-gpu-win/compositing/text-on-large-layer-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/text-on-large-layer-expected.png: Added.
- platform/chromium-gpu-win/compositing/text-on-large-layer-expected.txt: Added.
- platform/chromium-gpu-win/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
- platform/chromium-gpu-win/compositing/tiling/huge-layer-expected.txt: Added.
- platform/chromium-gpu-win/compositing/tiling/huge-layer-with-layer-children-expected.txt: Added.
- platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.png: Added.
- platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.txt: Added.
- platform/chromium-gpu-win/compositing/webgl/webgl-reflection-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/webgl/webgl-reflection-expected.png: Added.
- platform/chromium-gpu-win/compositing/webgl/webgl-reflection-expected.txt: Added.
- platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.checksum:
- platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png:
- platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.checksum:
- platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.png:
- 6:27 PM Changeset in webkit [78006] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt
- 6:14 PM Changeset in webkit [78005] by
-
- 19 edits2 adds in trunk
2011-02-07 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Events should propagate through IDBDatabase (for IDBRequest and IDBTransaction)
https://bugs.webkit.org/show_bug.cgi?id=53975
- storage/indexeddb/objectstore-basics.html:
- storage/indexeddb/request-event-propagation-expected.txt:
- storage/indexeddb/request-event-propagation.html:
- storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
- storage/indexeddb/transaction-and-objectstore-calls.html:
- storage/indexeddb/transaction-basics.html:
- storage/indexeddb/transaction-event-propagation-expected.txt: Added.
- storage/indexeddb/transaction-event-propagation.html: Added.
2011-02-07 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Events should propagate through IDBDatabase (for IDBRequest and IDBTransaction)
https://bugs.webkit.org/show_bug.cgi?id=53975
The third change in the series of overhauling IndexedDB's event model to match
the spec (at least the version in our heads and bugs).
Test: storage/indexeddb/transaction-event-propagation.html
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
- dom/Event.cpp: (WebCore::Event::isIDBAbortEvent): (WebCore::Event::isIDBCompleteEvent):
- dom/Event.h:
- dom/EventTarget.cpp: (WebCore::EventTarget::toIDBDatabase):
- dom/EventTarget.h:
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::create): (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::scriptExecutionContext): (WebCore::IDBDatabase::eventTargetData): (WebCore::IDBDatabase::ensureEventTargetData):
- storage/IDBDatabase.h: (WebCore::IDBDatabase::toIDBDatabase): (WebCore::IDBDatabase::refEventTarget): (WebCore::IDBDatabase::derefEventTarget):
- storage/IDBDatabase.idl:
- storage/IDBRequest.cpp: (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent):
- storage/IDBTransaction.cpp: (WebCore::IDBTransaction::backend): (WebCore::IDBTransaction::db): (WebCore::IDBTransaction::objectStore): (WebCore::IDBTransaction::scriptExecutionContext): (WebCore::IDBTransaction::dispatchEvent): (WebCore::IDBTransaction::enqueueEvent):
- storage/IDBTransaction.h: (WebCore::IDBTransaction::dispatchEvent):
- 6:10 PM Changeset in webkit [78004] by
-
- 3 edits in branches/chromium/648/Source/WebCore
Merge 77608 - 2011-02-03 Victoria Kirst <vrk@google.com>
Reviewed by James Robinson.
Replaces float literals with uniform values in shader code
so that buggy drivers unable to parse float values in different
locales will not produce a pink video.
[chromium] Fix pink video bug with gpu-acceleration enabled
https://bugs.webkit.org/show_bug.cgi?id=53568
- platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::SharedValues::SharedValues): (WebCore::VideoLayerChromium::drawYUV):
- platform/graphics/chromium/VideoLayerChromium.h: (WebCore::VideoLayerChromium::SharedValues::signAdjLocation):
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6460020
- 6:08 PM Changeset in webkit [78003] by
-
- 3 edits in branches/chromium/648/Source/WebKit/chromium
Merge 77599 - 2011-02-03 Victoria Kirst <vrk@google.com>
Reviewed by James Robinson.
[chromium] Fix redundant video frame paint on CSS LayerChromium for <video>
https://bugs.webkit.org/show_bug.cgi?id=52868
- src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::paint): (WebKit::WebMediaPlayerClientImpl::paintCurrentFrameInContext): (WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
- src/WebMediaPlayerClientImpl.h:
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6465012
- 6:02 PM Changeset in webkit [78002] by
-
- 1 edit2 adds in trunk/Source/WebCore
2011-02-08 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Add cache for GPU-accelerated path processing results
https://bugs.webkit.org/show_bug.cgi?id=45519
Adding a cache which holds the results of processing a path into
interior and exterior triangle meshes, according to the path
rendering algorithm from GPU Gems 3. No tests yet; will be tested
in conjunction with later code.
- platform/graphics/gpu/LoopBlinnPathCache.cpp: Added. (WebCore::LoopBlinnPathCache::LoopBlinnPathCache): (WebCore::LoopBlinnPathCache::~LoopBlinnPathCache): (WebCore::LoopBlinnPathCache::addVertex): (WebCore::LoopBlinnPathCache::clear): (WebCore::LoopBlinnPathCache::addInteriorVertex): (WebCore::LoopBlinnPathCache::numberOfInteriorEdgeVertices): (WebCore::LoopBlinnPathCache::interiorEdgeVertices): (WebCore::LoopBlinnPathCache::addInteriorEdgeVertex):
- platform/graphics/gpu/LoopBlinnPathCache.h: Added. (WebCore::LoopBlinnPathCache::numberOfVertices): (WebCore::LoopBlinnPathCache::vertices): (WebCore::LoopBlinnPathCache::texcoords): (WebCore::LoopBlinnPathCache::numberOfInteriorVertices): (WebCore::LoopBlinnPathCache::interiorVertices):
- 5:55 PM Changeset in webkit [78001] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Nevermind
- 5:54 PM Changeset in webkit [78000] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
80,000
- 5:46 PM Changeset in webkit [77999] by
-
- 4 edits in trunk/Source/WebCore
2011-02-08 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Rename GraphicsContext3D::WebGLEnumType
https://bugs.webkit.org/show_bug.cgi?id=45708
- html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::getAttachedShader):
- html/canvas/WebGLProgram.h:
- platform/graphics/GraphicsContext3D.h:
- 5:17 PM Changeset in webkit [77998] by
-
- 3 edits in trunk/Tools
2011-02-08 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: move the logic that starts and stops the
servers from dump_render_tree_thread into single_test_runner
so that we can reuse it in the new multiprocessing worker class
as well.
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
- 5:04 PM Changeset in webkit [77997] by
-
- 26 edits in trunk/Source
2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77980.
http://trac.webkit.org/changeset/77980
https://bugs.webkit.org/show_bug.cgi?id=54043
"Crashes on Windows and Linux..." (Requested by leviw on
#webkit).
- WebView/WebFrame.mm: (-[WebFrame _caretRectAtNode:offset:affinity:]):
- WebView/WebFrameInternal.h:
- WebView/WebTextCompletionController.mm: (-[WebTextCompletionController doCompletion]):
2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77980.
http://trac.webkit.org/changeset/77980
https://bugs.webkit.org/show_bug.cgi?id=54043
"Crashes on Windows and Linux..." (Requested by leviw on
#webkit).
- WebCore.exp.in:
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
- accessibility/AccessibilityObject.cpp: (WebCore::startOfStyleRange): (WebCore::endOfStyleRange):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored):
- dom/Position.cpp: (WebCore::Position::upstream): (WebCore::Position::downstream):
- dom/Range.cpp: (WebCore::Range::editingStartPosition):
- editing/Editor.cpp: (WebCore::Editor::canDeleteRange):
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
- editing/SelectionController.cpp: (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): (WebCore::SelectionController::setSelectedRange):
- editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
- editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed):
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::VisiblePosition): (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): (WebCore::VisiblePosition::canonicalPosition): (WebCore::VisiblePosition::characterAfter): (WebCore::VisiblePosition::localCaretRect): (WebCore::makeRange): (WebCore::startVisiblePosition): (WebCore::endVisiblePosition): (WebCore::setStart): (WebCore::setEnd): (WebCore::isFirstVisiblePositionInNode): (WebCore::isLastVisiblePositionInNode):
- editing/VisiblePosition.h:
- editing/htmlediting.cpp: (WebCore::firstInSpecialElement): (WebCore::lastInSpecialElement): (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):
- editing/visible_units.cpp: (WebCore::startPositionForLine): (WebCore::endPositionForLine): (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::endOfBlock): (WebCore::startOfDocument): (WebCore::endOfDocument): (WebCore::logicalStartPositionForLine): (WebCore::logicalEndPositionForLine):
- page/DOMSelection.cpp: (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::setPosition): (WebCore::DOMSelection::extend):
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick):
- rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::visiblePositionForIndex):
- svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::selectSubString):
- 5:00 PM Changeset in webkit [77996] by
-
- 6 edits in trunk/Source/WebKit2
2011-02-08 Anders Carlsson <andersca@apple.com>
Reviewed by Beth Dakin.
Assertion failure !isInAcceleratedCompositingMode() in DrawingAreaProxyImpl::incorporateUpdate()
https://bugs.webkit.org/show_bug.cgi?id=54046
<rdar://problem/8973960>
DrawingAreaImpl::setRootCompositingLayer can be called with a new layer even when already
in accelerated compositing mode. Similarly, it can be called with a null layer even when not
in accelerated compositing mode. Make the drawing area and layer tree host handle both these cases.
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setRootCompositingLayer): Only call enterAcceleratedCompositingMode if there is no layer tree host, otherwise just call LayerTreeHost::setRootCompositingLayer.
(WebKit::DrawingAreaImpl::setSize):
Add an assert.
(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
Assert that we don't have a layer tree host.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
Assert that we do have a layer tree host.
(WebKit::DrawingAreaImpl::display):
If the call to display caused the page to enter accelerated compositing mode, we don't
want to send back an Update message.
- WebProcess/WebPage/LayerTreeHost.cpp: (WebKit::LayerTreeHost::create):
- WebProcess/WebPage/LayerTreeHost.h: Create no longer takes a graphics layer.
- WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::create): (WebKit::LayerTreeHostMac::LayerTreeHostMac): Create no longer takes a graphics layer.
(WebKit::LayerTreeHostMac::setRootCompositingLayer):
Set the new root compositing layer.
- 4:55 PM Changeset in webkit [77995] by
-
- 3 edits2 adds in trunk
2011-02-08 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
VisibleSelection::setWithoutValidation() should allow caret selection.
https://bugs.webkit.org/show_bug.cgi?id=53943
- editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Added.
- editing/undo/undo-paste-when-caret-is-not-in-range.html: Added.
2011-02-08 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
VisibleSelection::setWithoutValidation() should allow caret selection.
https://bugs.webkit.org/show_bug.cgi?id=53943
Test: editing/undo/undo-paste-when-caret-is-not-in-range.html
- editing/VisibleSelection.cpp: (WebCore::VisibleSelection::setWithoutValidation):
- 4:48 PM Changeset in webkit [77994] by
-
- 3 edits2 adds in trunk/Tools
2011-02-08 Dirk Pranke <dpranke@chromium.org>
Reviewed by Mihai Parparita.
new-run-webkit-tests: split out thread stack logging code into a sharable module
This patch splits out the code used to find and log thread
stacks from NRWT-specific packages to something generic and
shareable by other python modules. It will be shared in the near
future by the manager_worker_broker module, for example.
- Scripts/webkitpy/common/system/stack_utils.py: Added.
- Scripts/webkitpy/common/system/stack_utils_unittest.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
- Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
- 4:45 PM Changeset in webkit [77993] by
-
- 7 edits2 deletes in trunk/Source/WebCore
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Remove the last remnants of the Mozilla theme drawing code
https://bugs.webkit.org/show_bug.cgi?id=54035
Remove all Mozilla theme drawing code.
No new tests. This change only removes dead code.
- GNUmakefile.am: Remove Mozilla files from the source list.
- platform/gtk/RenderThemeGtk.h: Remove Mozilla-theme-drawing-related methods and add m_colormap to hold the current colormap of the widgets.
- platform/gtk/RenderThemeGtk2.cpp: Remove Mozilla code. (WebCore::RenderThemeGtk::platformInit): Ditto. (WebCore::RenderThemeGtk::~RenderThemeGtk): Ditto. (WebCore::RenderThemeGtk::gtkContainer): Ditto.
- platform/gtk/ScrollbarThemeGtk2.cpp: Ditto.
- platform/gtk/WidgetRenderingContext.cpp: Ditto. (WebCore::WidgetRenderingContext::WidgetRenderingContext): Ditto.
- platform/gtk/WidgetRenderingContext.h: Ditto.
- platform/gtk/gtk2drawing.c: Removed.
- platform/gtk/gtkdrawing.h: Removed.
- 4:40 PM Changeset in webkit [77992] by
-
- 4 edits in trunk/Tools
2011-02-08 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: move a bunch of testing logic out of
dump_render_tree_thread and into single_test_runner so that we
will be able to reuse it in the new multiprocessing worker class as well.
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
- 4:37 PM Changeset in webkit [77991] by
-
- 2 edits in trunk/Tools
2011-02-08 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: remove no longer needed WatchableThread
class.
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- 4:33 PM Changeset in webkit [77990] by
-
- 1 edit2 adds in trunk/Tools
2011-02-08 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: add stubs for the Manager objects that
will abstract the concurrency implementation (inline / threads /
processes). These classes do nothing yet and are not wired up to
anything.
- Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: Added.
- 4:31 PM Changeset in webkit [77989] by
-
- 1 edit2 adds in trunk/Tools
2011-02-08 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: add simplified message broker for new-style
messaging. This change adds a very simple message broker that
will be used to shuttle messages between the TestRunner2 manager
thread and the Worker threads. For now the class is not used by
anything, but the eventual usage can be seen in the patches
attached to bug 49566.
- Scripts/webkitpy/layout_tests/layout_package/message_broker2.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/message_broker2_unittest.py: Added.
- 4:25 PM Changeset in webkit [77988] by
-
- 3 edits5 adds in trunk
2011-02-08 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Antti Koivisto.
Crash when logging into gmail.com with frame flattening turned on.
https://bugs.webkit.org/show_bug.cgi?id=52449
- fast/frames/flattening/iframe-flattening-crash-expected.txt: Added.
- fast/frames/flattening/iframe-flattening-crash.html: Added.
- fast/frames/flattening/iframe-flattening-selection-crash-expected.txt: Added.
- fast/frames/flattening/iframe-flattening-selection-crash.html: Added.
- fast/frames/flattening/resources/iframe-flattening-crash.html: Added.
2011-02-08 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Antti Koivisto.
Crash when logging into gmail.com with frame flattening turned on.
https://bugs.webkit.org/show_bug.cgi?id=52449
Frame flattening algorithm requires that layout always starts from the main frame, since layout of
subframes impacts the layout of their parents.
There are places in the code that call view->layout() not on the main frame.
Instead of changing all the callsites, I changed FrameView::layout()
to force layout from the main frame if frame flattening is enabled.
In addition, postLayoutTasks can trigger relayout, so make it use the timer even more.
Move the call to SelectionController::updateAppearance() to performPostLayoutTasks(),
because calling the from layout() leads to a crash in pages that have a selection in an iframe.
Tests: fast/frames/flattening/iframe-flattening-crash.html
fast/frames/flattening/iframe-flattening-selection-crash.html
- page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::performPostLayoutTasks):
- 4:25 PM Changeset in webkit [77987] by
-
- 2 edits in trunk/Tools
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
chromium-win builder shouldn't run python or perl tests
https://bugs.webkit.org/show_bug.cgi?id=54032
These tests don't pass on this builder because the builder isn't
running in cygwin. There isn't really any point in running them and
making the bot red forever.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 4:07 PM Changeset in webkit [77986] by
-
- 2 edits in trunk
Add Radar URLs to a recent ChangeLog entry.
- 3:59 PM Changeset in webkit [77985] by
-
- 5 edits in trunk
2011-02-08 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
REGRESSION (r76301): 'plaintext-only' must be a supported contentEditable mode.
https://bugs.webkit.org/show_bug.cgi?id=54041
- html/HTMLElement.cpp: (WebCore::HTMLElement::setContentEditable): Setting the contentEditable attribute to 'plaintext-only' should not throw an exception.
2011-02-08 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
REGRESSION (r76301): 'plaintext-only' must be a supported contentEditable mode.
https://bugs.webkit.org/show_bug.cgi?id=54041
- fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt:
- fast/dom/HTMLElement/set-value-caseinsensitive.html:
- 3:51 PM Changeset in webkit [77984] by
-
- 3 edits in trunk/Source/WebCore
RenderRubyRun::m_beingDestroyed is redundant
https://bugs.webkit.org/show_bug.cgi?id=54042
Reviewed by Simon Fraser.
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::RenderRubyRun): Removed intialization of m_beingDestroyed.
(WebCore::RenderRubyRun::removeChild): Use the base class beingDestroyed().
- rendering/RenderRubyRun.h:
- 3:34 PM Changeset in webkit [77983] by
-
- 3 edits in trunk/Source/WebKit2
Implement WorkQueue::scheduleWorkAfterDelay on Windows
Each WorkQueue now owns its own timer queue. When scheduleWorkAfterDelay is called, we
create a timer-queue timer with the given delay. When the timer fires, we schedule the work
on the queue and clean up the timer.
Fixes <http://webkit.org/b/54040> <rdar://problem/8974230> Web process sticks around forever
if it's hung when UI process goes away
Reviewed by Anders Carlsson.
- Platform/WorkQueue.h: Added timerCallback and m_timerQueue.
- Platform/win/WorkQueueWin.cpp:
(WorkQueue::platformInitialize): Initialize m_timerQueue.
(WorkQueue::platformInvalidate): Clean up m_timerQueue.
(TimerContext::TimerContext): Added this helper object to hold the context needed by the
timer callback.
(WorkQueue::timerCallback): Added. Schedules the WorkItem on the WorkQueue and cleans up the
timer.
(WorkQueue::scheduleWorkAfterDelay): Create a timer-queue timer on our timer queue that will
fire after the given delay. Pass a new TimerContext object to the timer callback that
contains the information it needs.
- 3:15 PM Changeset in webkit [77982] by
-
- 4 edits in trunk/LayoutTests
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Unskip a series of tests that seem to be passing locally. Also unskip
a test that was mistakenly reskipped in r77979 due to what looks like a
merge issue. Rebaseline two of these test which have results originating
from long ago.
- platform/gtk/Skipped: Unskip some tests.
- platform/gtk/editing/selection/14971-expected.txt:
- platform/gtk/editing/selection/inline-closest-leaf-child-expected.txt:
- 3:14 PM Changeset in webkit [77981] by
-
- 5 edits in trunk/Source/WebKit2
2011-02-08 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Rename PluginProcess::initializeConnection to PluginProcess::initialize
https://bugs.webkit.org/show_bug.cgi?id=54039
- PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::initialize):
- PluginProcess/PluginProcess.h:
- PluginProcess/mac/PluginProcessMainMac.mm: (WebKit::PluginProcessMain):
- WebProcess/WebProcess.h:
- 3:13 PM Changeset in webkit [77980] by
-
- 26 edits in trunk/Source
2011-02-08 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
Stop instantiating legacy editing Positions in VisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=52919
Changing usage of legacy VisiblePosition constructor. Since we were dealing
with positions from DOM Ranges, we're guaranteed a parent-anchored position.
- WebView/WebFrame.mm: (-[WebFrame _caretRectAtPosition:affinity:]):
- WebView/WebFrameInternal.h:
- WebView/WebTextCompletionController.mm: (-[WebTextCompletionController doCompletion]):
2011-02-08 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
Stop instantiating legacy editing Positions in VisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=52919
Changing VisiblePosition completely away from legacy positions.
No new tests since this is functionaly equivalent.
- WebCore.exp.in: Removing the legacy VisiblePosition constructor and adding the PositionIsOffsetInAnchor symbol. If we must create VisiblePositions outside of WebCore, they should be parent anchored.
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
- accessibility/AccessibilityObject.cpp: (WebCore::startOfStyleRange): (WebCore::endOfStyleRange):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored):
- dom/Position.cpp: (WebCore::Position::upstream): Fixed to correctly respect PositionIsAfterAnchor (WebCore::Position::downstream): ditto
- dom/Range.cpp: (WebCore::Range::editingStartPosition):
- editing/Editor.cpp: (WebCore::Editor::canDeleteRange):
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
- editing/SelectionController.cpp: (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): (WebCore::SelectionController::setSelectedRange):
- editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
- editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed):
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): (WebCore::VisiblePosition::canonicalPosition): (WebCore::VisiblePosition::characterAfter): (WebCore::VisiblePosition::localCaretRect): (WebCore::makeRange): (WebCore::startVisiblePosition): (WebCore::endVisiblePosition): (WebCore::setStart): (WebCore::setEnd): (WebCore::isFirstVisiblePositionInNode): (WebCore::isLastVisiblePositionInNode):
- editing/VisiblePosition.h: (WebCore::VisiblePosition::VisiblePosition):
- editing/htmlediting.cpp: (WebCore::firstInSpecialElement): (WebCore::lastInSpecialElement): (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):
- editing/visible_units.cpp: (WebCore::startPositionForLine): (WebCore::endPositionForLine): (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::endOfBlock): (WebCore::startOfDocument): (WebCore::endOfDocument): (WebCore::logicalStartPositionForLine): (WebCore::logicalEndPositionForLine):
- page/DOMSelection.cpp: (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::setPosition): (WebCore::DOMSelection::extend):
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick):
- rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::visiblePositionForIndex):
- svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::selectSubString):
- 3:09 PM Changeset in webkit [77979] by
-
- 5 edits in trunk
2011-02-08 Michael Saboff <msaboff@apple.com>
JSC::Bindings m_rootObject->isValid() assert fails when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=53716
Changed ASSERT to be an if for the case where the RuntimeObject was
GC'ed before RootObject::invalidate is called. In that case there is
no need to remove the RuntimeObject from the RootObject. The isValid()
call will be false in this case, but the RuntimeObject has already
been removed from the RootObject. Added similar defensive code
in RootObject::removeRuntimeObject().
- bridge/jsc/BridgeJSC.cpp: (JSC::Bindings::Instance::willDestroyRuntimeObject):
- bridge/runtime_root.cpp: (JSC::Bindings::RootObject::removeRuntimeObject):
2011-02-08 Michael Saboff <msaboff@apple.com>
Reviewed by Darin Adler.
JSC::Bindings m_rootObject->isValid() assert fails when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=53716
Re-enabled tests that are fixed with the corresponding change in
WebCore.
- platform/gtk/Skipped:
- 3:07 PM Changeset in webkit [77978] by
-
- 9 edits in trunk
<rdar://problem/8972913> and https://bugs.webkit.org/show_bug.cgi?id=54036
didChangeBackForwardList should include some context about what changed
Reviewed by Darin Adler.
Source/WebKit2:
Update the implementation of this API to include the new item (if any) and removed items (if any):
- UIProcess/API/C/WKPage.h:
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didChangeBackForwardList):
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeBackForwardList):
- UIProcess/WebPageProxy.h:
Have WebBackForwardList pass the new items and/or removed items when calling the notifier:
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::goToItem):
(WebKit::WebBackForwardList::clear):
Tools:
- MiniBrowser/mac/BrowserWindowController.m:
(didChangeBackForwardList):
- 3:03 PM Changeset in webkit [77977] by
-
- 4 edits in trunk/Source/JavaScriptCore
2011-02-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Give each MarkedBlock enough mark bits to cover the whole block
https://bugs.webkit.org/show_bug.cgi?id=54029
SunSpider reports no change.
This simplifies access to mark bits, since any cell-aligned pointer
into a block now has a valid mark bit to test.
- runtime/MarkedBlock.h: Changed CELLS_PER_BLOCK to account for the extra mark bits. This happens not to change its actual value. (JSC::MarkedBlock::cellNumber): (JSC::MarkedBlock::isMarked): (JSC::MarkedBlock::testAndSetMarked): (JSC::MarkedBlock::setMarked): Changed const JSCell* to const void* to remove a cast from our caller, and to more accurately reflect the fact that MarkedBlock is agnostic about the types pointed to by the pointers you pass to it.
(JSC::MarkedBlock::isPossibleCell): Removed a null check. We now consider
the null pointer to be a possible cell with a 0 (impossible) block. This
removes a null check from marking.
- runtime/MarkedSpace.cpp:
- runtime/MarkedSpace.h: (JSC::MarkedSpace::contains): Simplified the contains check, and inlined the whole thing, now that it's so simple.
- 3:02 PM Changeset in webkit [77976] by
-
- 2 edits in trunk/Source/WebKit2
Sandbox violations visiting MobileMe.
<rdar://problem/8961330>
Reviewed by Anders Carlsson.
- WebProcess/com.apple.WebProcess.sb:
- 2:52 PM Changeset in webkit [77975] by
-
- 5 edits in trunk/Source/WebKit2
2011-02-08 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Rename PluginProcess::initialize to PluginProcess::initializePluginProcess
https://bugs.webkit.org/show_bug.cgi?id=54037
Rename PluginProcess::initialize to PluginProcess::initializePluginProcess to better
match the WebProcess initialization code, in preparation of sharing more code.
- PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::initializePluginProcess):
- PluginProcess/PluginProcess.h:
- PluginProcess/PluginProcess.messages.in:
- UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::didFinishLaunching):
- 2:48 PM Changeset in webkit [77974] by
-
- 26 edits6 adds in trunk
WK2: Add ability to pass context to policy delegate methods
https://bugs.webkit.org/show_bug.cgi?id=54031
Reviewed by Anders Carlsson.
Source/WebKit2:
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
(CoreIPC::handleMessageVariadic):
- Scripts/webkit2/messages.py:
Add ability to pass variadic messages to sync messages.
- Shared/API/c/WKBase.h:
- Shared/APIObject.h:
Add WKBundleNavigation type.
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForMIMEType):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebPolicyClient.cpp:
(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
(WebKit::WebPolicyClient::decidePolicyForMIMEType):
- UIProcess/WebPolicyClient.h:
Update policy client for new data.
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
- WebProcess/InjectedBundle/API/c/WKBundleNavigationAction.cpp: Added.
(WKBundleNavigationActionGetTypeID):
(WKBundleNavigationActionGetNavigationType):
(WKBundleNavigationActionGetEventModifiers):
(WKBundleNavigationActionGetEventMouseButton):
(WKBundleNavigationActionCopyHitTestResult):
(WKBundleNavigationActionCopyFormElement):
- WebProcess/InjectedBundle/API/c/WKBundleNavigationAction.h: Added.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetPolicyClient):
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp: Added.
(WebKit::mouseEventForNavigationAction):
(WebKit::mouseButtonForMouseEvent):
(WebKit::InjectedBundleNavigationAction::modifiersForNavigationAction):
(WebKit::InjectedBundleNavigationAction::mouseButtonForNavigationAction):
(WebKit::InjectedBundleNavigationAction::create):
(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):
- WebProcess/InjectedBundle/InjectedBundleNavigationAction.h: Added.
(WebKit::InjectedBundleNavigationAction::navigationType):
(WebKit::InjectedBundleNavigationAction::modifiers):
(WebKit::InjectedBundleNavigationAction::mouseButton):
(WebKit::InjectedBundleNavigationAction::hitTestResult):
(WebKit::InjectedBundleNavigationAction::formElement):
(WebKit::InjectedBundleNavigationAction::type):
- WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp: Added.
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNavigationAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNewWindowAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForMIMEType):
- WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h: Added.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::initializeInjectedBundlePolicyClient):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::injectedBundlePolicyClient):
Pipe the policy client through the bundle to allow setting user data.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- win/WebKit2Generated.make:
Add new files.
Tools:
- MiniBrowser/mac/BrowserWindowController.m:
(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):
(decidePolicyForMIMEType):
- TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
(TestWebKitAPI::decidePolicyForNavigationAction):
(TestWebKitAPI::decidePolicyForNewWindowAction):
(TestWebKitAPI::decidePolicyForMIMEType):
Update policy client for new API.
- 2:33 PM Changeset in webkit [77973] by
-
- 4 edits1 delete in trunk/LayoutTests
2011-02-08 Xiaomei Ji <xji@chromium.org>
Unreviewed.
Rebaseline for chromium-mac after r77952.
Not sure why the previous rebase did not get the right results.
https://bugs.webkit.org/show_bug.cgi?id=54026
- platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum:
- platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
- platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 2:31 PM Changeset in webkit [77972] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-02-08 Daniel Bates <dbates@rim.com>
Rubber-stamped by Martin Robinson.
Rename enum ProtectionSeting [sic] to ProtectionSetting.
- jit/ExecutableAllocator.cpp: (JSC::ExecutableAllocator::reprotectRegion):
- jit/ExecutableAllocator.h:
- 2:25 PM Changeset in webkit [77971] by
-
- 10 edits in trunk
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
https://bugs.webkit.org/show_bug.cgi?id=54033
- platform/gtk/Skipped: Unskip a test that is now passing.
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
https://bugs.webkit.org/show_bug.cgi?id=54033
Add a DumpRenderTreeSupportGtk method for turning the icon database on and off.
This is a likely candidate for a new API point.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setIconDatabaseEnabled): Added.
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
- webkit/webkitglobals.cpp: (webkitInit): Call setIconDatabaseEnabled(true) on startup, instead of initializing the database manually. (WebKit::setIconDatabaseEnabled): Added.
- webkit/webkitglobalsprivate.h: Added declarations.
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
https://bugs.webkit.org/show_bug.cgi?id=54033
Add an implementation of LayoutTestController.setIconDatabaseEnabled that just
call DumpRenderTreeSupportGtk. Turn off the icon database between tests.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Turn off the icon database.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setIconDatabaseEnabled): Call the appropriate DumpRenderTreeSupportGtk method.
- 2:11 PM Changeset in webkit [77970] by
-
- 3 edits in trunk/Source/WebCore
Fix for <rdar://problem/8953365> CrashTracer: 14
crashes in WebProcess at com.apple.WebCore:
-[ScrollKnobAnimation setCurrentProgress:] + 258
Reviewed by Darin Adler.
This crash seems to happen when the animation is running
and a window is closed. If the ScrollAnimator is destroyed,
delegate calls for the animation can still run, so we have
to make sure we inform the delegates when the ScrollAnimator
is gone, and then we have to null-check it before we do
anything with it.
Remove scrollbarPainterDelegate() since it's not used anymore.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
Add null-checks for _animator
(-[ScrollbarPartAnimation setCurrentProgress:]):
(-[ScrollbarPartAnimation scrollAnimatorDestroyed]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):
New function to inform the delegates that the ScrollAnimator
is being destroyed.
(-[ScrollbarPainterDelegate scrollAnimatorDestroyed]):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
- 2:00 PM Changeset in webkit [77969] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Zhenyao Mo <zmo@google.com>
Unreviewed, typo fix.
- platform/chromium/test_expectations.txt
- 1:51 PM Changeset in webkit [77968] by
-
- 3 edits in trunk/Source/WebKit2
2011-02-08 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Crash calling -setFrame:andScrollBy: in windowDidResize
https://bugs.webkit.org/show_bug.cgi?id=54030
<rdar://problem/8969760>
- Platform/mac/SharedMemoryMac.cpp: (WebKit::SharedMemory::create): Assert that size is not zero here; we never want to try to create shared memory with a zero size.
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setSize): Always invalidate the entire visible page when resizing.
- 1:09 PM Changeset in webkit [77967] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Unskip some inspector tests that are passing locally. The bugs are
missing test diffs, so we can either reskip them and get more information
or have passing tests. Classify another failure.
- platform/gtk/Skipped: Clean up the skipped list.
- 1:06 PM Changeset in webkit [77966] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt
- 12:54 PM Changeset in webkit [77965] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Kenji Imasaki <imasaki@chromium.org>
Reviewed by Jian Li.
[Chromium] Remove non-Flaky media tests from test expectation file
https://bugs.webkit.org/show_bug.cgi?id=54021
- platform/chromium/test_expectations.txt:
- 12:19 PM Changeset in webkit [77964] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Xiaomei Ji <xji@chromium.org>
Unreviewed. Fix typo in rebaseline in r77961.
- platform/mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
- 12:17 PM Changeset in webkit [77963] by
-
- 29 edits in trunk/Source
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
This code appears to be unused.
- html/HTMLParserErrorCodes.cpp:
- html/HTMLParserErrorCodes.h:
- html/HTMLParserQuirks.h:
- loader/EmptyClients.h:
- page/ChromeClient.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- src/ChromeClientImpl.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebCoreSupport/ChromeClientEfl.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebCoreSupport/ChromeClientGtk.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebCoreSupport/ChromeClientHaiku.cpp:
- WebCoreSupport/ChromeClientHaiku.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebCoreSupport/WebChromeClient.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebCoreSupport/ChromeClientQt.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebCoreSupport/WebChromeClient.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebCoreSupport/ChromeClientWinCE.cpp:
- WebCoreSupport/ChromeClientWinCE.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebKitSupport/ChromeClientWx.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebProcess/WebCoreSupport/WebChromeClient.cpp
- WebProcess/WebCoreSupport/WebChromeClient.h
- 11:36 AM Changeset in webkit [77962] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-08 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
UI process crashes if web process crashes while web inspector is focused
https://bugs.webkit.org/show_bug.cgi?id=53965
<rdar://problem/8961633>
Make sure to close the web inspector web page proxy before calling platformClose, since
platformClose can cause the web page proxy to try to send messages (such as SetActive)
to the web process while it's in a bad state.
The original fix, http://trac.webkit.org/changeset/77866, put the call to m_page->close() in
WebInspectorProxy::didClose, which was wrong and lead to crashes. The right place to close the page
is in WebInspectorProxy::invalidate.
- UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::invalidate):
- 11:25 AM Changeset in webkit [77961] by
-
- 2 edits11 adds in trunk/LayoutTests
2011-02-08 Xiaomei Ji <xji@chromium.org>
Unreviewed.
Rebaseline after r77952.
- platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
- platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
- platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
- platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
- platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
- platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
- platform/chromium-win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
- platform/chromium-win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
- platform/chromium-win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- platform/mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
- platform/win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
- 11:15 AM Changeset in webkit [77960] by
-
- 7 edits in trunk/Source/WebCore
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Move scrollbar rendering out of gtk2drawing.c
https://bugs.webkit.org/show_bug.cgi?id=52836
Replace gtk2drawing.c scrollbar rendering with our own version. This
is the last use of the Mozilla theme drawing code.
No new tests. This should not change the rendering of the default
theme.
- platform/gtk/GtkVersioning.h: Add some more backported allocation setters.
- platform/gtk/RenderThemeGtk.h: Add a getter for the scrollbar widgets.
- platform/gtk/RenderThemeGtk2.cpp: Initialize and add getters for scrollbar widgets. (WebCore::RenderThemeGtk::platformInit): Ditto. (WebCore::RenderThemeGtk::gtkHScrollbar): Ditto. (WebCore::RenderThemeGtk::gtkVScrollbar): Ditto.
- platform/gtk/ScrollbarThemeGtk.cpp: (WebCore::ScrollbarThemeGtk::paint): We only repaint the scrolled window background if we are repainting a button or the thumb. In that case also repaint the track rect.
- platform/gtk/ScrollbarThemeGtk2.cpp: Port to WidgetRenderingContext. (WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk): Ditto. (WebCore::ScrollbarThemeGtk::updateThemeProperties): Ditto. (WebCore::getWidgetForScrollbar): Ditto. (WebCore::ScrollbarThemeGtk::paintTrackBackground): Ditto. (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Ditto. (WebCore::ScrollbarThemeGtk::paintThumb): Ditto. (WebCore::ScrollbarThemeGtk::paintButton): Ditto.
- platform/gtk/WidgetRenderingContext.cpp: Ditto. (WebCore::WidgetRenderingContext::gtkPaintBox): Added an option which also adjusts a widget allocation according to the paint rect. This is necessary to properly draw scrollbar buttons.
- platform/gtk/WidgetRenderingContext.h: Ditto.
- 11:12 AM Changeset in webkit [77959] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Zhenyao Mo < zmo@google.com>
Unreviewed, test expectations update.
- LauoutTests/platform/chromium/test_expectations.txt
- 10:57 AM Changeset in webkit [77958] by
-
- 3 edits4 adds in trunk
2011-02-08 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Inset shadow with large offset renders incorrectly
https://bugs.webkit.org/show_bug.cgi?id=53882
Fix an issue with inset shadows, when the shadow offset
was larger than the box size. In this case we'd fail to
fill the box with the shadow color.
Test: fast/box-shadow/inset-shadow-large-offset.html
- rendering/RenderBoxModelObject.cpp: (WebCore::areaCastingShadowInHole): Return a rect that covers the area which contributes to the inset shadow.
(WebCore::RenderBoxModelObject::paintBoxShadow): Use areaCastingShadowInHole()
to compute the outerRect.
- 10:56 AM Changeset in webkit [77957] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-02-08 Tony Chang <tony@chromium.org>
Unreviewed, build fix for clobber builds of DRT on mac/linux.
This file moved in chromium r73530 and this path wasn't changed.
- WebKit.gyp:
- 10:47 AM Changeset in webkit [77956] by
-
- 5 edits in trunk
2011-02-08 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
drawElements should check if a buffer is bound to ELEMENT_ARRAY_BUFFER
https://bugs.webkit.org/show_bug.cgi?id=54017
- fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
- fast/canvas/webgl/draw-elements-out-of-bounds.html:
2011-02-08 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
drawElements should check if a buffer is bound to ELEMENT_ARRAY_BUFFER
https://bugs.webkit.org/show_bug.cgi?id=54017
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::drawElements):
- 10:37 AM Changeset in webkit [77955] by
-
- 4 edits in trunk/LayoutTests
2011-02-08 Xiaomei Ji <xji@chromium.org>
Unreviewed. after r77952,
skip pop-up-button-text-alignment-and-direction.html in qt and gtk as bidi-menulist.html.
set it as expect to fail in chromium.
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 10:35 AM Changeset in webkit [77954] by
-
- 12 edits in trunk/Source/WebCore
2011-01-28 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
Change the rest of HTMLMediaElement shadow DOM parts to use shadowPseudoId.
https://bugs.webkit.org/show_bug.cgi?id=53190
This is the second part of refactoring the HTMLMediaElement to use new
shadow DOM. The changes are mainly mechanical, except for needing to
add a new method to RenderTheme, which indicates whether or not status
display is being used by it. Previously, we relied on existence of a cached
pseudo style.
Refactoring, covered by existing tests.
- css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Removed now-unused enum values. (WebCore::nameToPseudoTypeMap): Ditto. (WebCore::CSSSelector::extractPseudoType): Ditto.
- css/CSSSelector.h: Ditto.
- html/shadow/MediaControls.cpp: (WebCore::MediaControls::createPanel): Changed to use the newly-added MediaControlPanelElement. (WebCore::MediaControls::createCurrentTimeDisplay): Changed to use the newly-added
MediaControlCurrentTimeDisplayElement.
(WebCore::MediaControls::createTimeRemainingDisplay): Changed to use the newly-added
MediaControlTimeRemainingDisplayElement.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlShadowRootElement::updateStyle): Changed to use the
standard style resolution.
(WebCore::MediaControlShadowRootElement::shadowPseudoId): Added.
(WebCore::MediaControlElement::MediaControlElement): Removed the switch statement
that is no longer necessary.
(WebCore::MediaControlElement::styleForElement): Changed to use the standard
style resolution.
(WebCore::MediaControlPanelElement::MediaControlPanelElement): Added.
(WebCore::MediaControlPanelElement::create): Added.
(WebCore::MediaControlPanelElement::displayType): Added.
(WebCore::MediaControlPanelElement::shadowPseudoId): Added.
(WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement):
Removed PseudoId constructor arg.
(WebCore::MediaControlTimelineContainerElement::rendererIsNeeded):
Changed to use the newly-plumbed usesMediaControlStatusDisplay helper.
(WebCore::MediaControlTimelineContainerElement::displayType): Added.
(WebCore::MediaControlTimelineContainerElement::shadowPseudoId): Added.
(WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement):
Removed PseudoId constructor arg.
(WebCore::MediaControlVolumeSliderContainerElement::displayType): Added.
(WebCore::MediaControlVolumeSliderContainerElement::shadowPseudoId): Added.
(WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):
Removed PseudoId constructor arg.
(WebCore::MediaControlStatusDisplayElement::rendererIsNeeded): Changed to
use the newly-plumbed usesMediaControlStatusDisplay helper.
(WebCore::MediaControlStatusDisplayElement::displayType): Added.
(WebCore::MediaControlStatusDisplayElement::shadowPseudoId): Added.
(WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement):
Removed PseudoId constructor arg.
(WebCore::MediaControlTimeRemainingDisplayElement::create): Added.
(WebCore::MediaControlTimeRemainingDisplayElement::MediaControlTimeRemainingDisplayElement): Added.
(WebCore::MediaControlTimeRemainingDisplayElement::displayType): Added.
(WebCore::MediaControlTimeRemainingDisplayElement::shadowPseudoId): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::create): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::MediaControlCurrentTimeDisplayElement): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::displayType): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::shadowPseudoId): Added.
- rendering/MediaControlElements.h: Added/changed defs accordingly.
- rendering/RenderTheme.h: (WebCore::RenderTheme::usesMediaControlStatusDisplay): Added.
- rendering/RenderThemeMac.h: Added def.
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::usesMediaControlStatusDisplay): Added.
- rendering/style/RenderStyleConstants.h: Removed now-unused enum values.
- 10:32 AM Changeset in webkit [77953] by
-
- 3 edits in trunk/Source/WebKit/win
<rdar://problem/8932077> REGRESSION (5.0.3-ToT): United boarding pass has wrong layout when printed
Reviewed by Adam Roben.
Windows never got patched to pass in the page height to WebCore, so when WebCore's pagination got re-written to depend on this
value, Windows got broken. Patch setPrinting to be identical to WebKit1 on OS X and to have it take an extra minimum page height
argument.
- WebFrame.cpp:
(WebFrame::setPrinting):
(WebFrame::setInPrintingMode):
- WebFrame.h:
- 10:22 AM Changeset in webkit [77952] by
-
- 3 edits4 adds in trunk
2011-02-08 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Fix pop-up button text not rendered correctly according to its direction
in <option>.
https://bugs.webkit.org/show_bug.cgi?id=53642
In adjustInnerStyle(), if m_innerBlock's direction or unicode-bidi
changes, set it needs layout.
- fast/text/international/pop-up-button-text-alignment-and-direction.html: Added.
- platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
- platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
- platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
2011-02-08 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Fix pop-up button text not rendered correctly according to its direction
in <option>.
https://bugs.webkit.org/show_bug.cgi?id=53642
In adjustInnerStyle(), if m_innerBlock's direction or unicode-bidi
changes, set it needs layout.
Test: fast/text/international/pop-up-button-text-alignment-and-direction.html
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle):
- 10:01 AM Changeset in webkit [77951] by
-
- 2 edits in trunk/Source/WebCore
2011-02-08 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix for Qt-minimal.
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::hasFrontend):
- 9:32 AM Changeset in webkit [77950] by
-
- 25 edits in trunk/Source
2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
All the Inspector API for WebCore has two parts.
The first one is InspectorInstrumentation for WebCore.
The second is InspectorController for WebKit.
InspectorAgent was produced by renaming original InspectorController.
This patch extracts WebKit related methods from InspectorAgent to InspectorController.
- WebCore.exp.in:
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::createParser):
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::~InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::inspect): (WebCore::InspectorAgent::handleMousePress): (WebCore::InspectorAgent::didClearWindowObjectInWorld): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::resourceAgent): (WebCore::InspectorAgent::createFrontendLifetimeAgents): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::pushDataCollectedOffline): (WebCore::InspectorAgent::restoreProfiler): (WebCore::InspectorAgent::startTimelineProfiler): (WebCore::PostWorkerNotificationToFrontendTask::performTask): (WebCore::InspectorAgent::didOpenDatabase): (WebCore::InspectorAgent::didUseDOMStorage): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::enableDebugger): (WebCore::InspectorAgent::enabled):
- inspector/InspectorAgent.h: (WebCore::InspectorAgent::frontend):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::setInspectorFrontendClient): (WebCore::InspectorController::hasInspectorFrontendClient): (WebCore::InspectorController::didClearWindowObjectInWorld): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::disconnectFrontendImpl): (WebCore::InspectorController::show): (WebCore::InspectorController::close): (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::evaluateForTestInFrontend): (WebCore::InspectorController::drawNodeHighlight): (WebCore::InspectorController::inspect): (WebCore::InspectorController::enabled): (WebCore::InspectorController::showPanel): (WebCore::InspectorController::frontendLoaded): (WebCore::InspectorController::timelineProfilerEnabled): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::profilerEnabled): (WebCore::InspectorController::debuggerEnabled): (WebCore::InspectorController::showAndEnableDebugger): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::isRecordingUserInitiatedProfile): (WebCore::InspectorController::setInspectorExtensionAPI): (WebCore::InspectorController::resume): (WebCore::InspectorController::hideHighlight): (WebCore::InspectorController::dispatchMessageFromFrontend):
- inspector/InspectorController.h: (WebCore::InspectorController::inspectorClient): (WebCore::InspectorController::inspectedPage): (WebCore::InspectorController::hasFrontend):
- inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::sendMessageToBackend):
- inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::setExtensionAPI):
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl): (WebCore::InspectorInstrumentation::profilerEnabledImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::hasFrontend):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
Minor change enforced by major changes in WebCore/inspector/InspectorController.
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::dispatchOnInspectorBackend):
- src/WebViewImpl.h:
2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
Minor change enforced by major changes in WebCore/inspector/InspectorController.
- WebCoreSupport/InspectorClientGtk.cpp:
- webkit/webkitwebinspector.cpp: (webkit_web_inspector_get_property):
2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
Minor change enforced by major changes in WebCore/inspector/InspectorController.
- WebInspector/WebInspector.mm: (-isTimelineProfilingEnabled):
2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
Minor change enforced by major changes in WebCore/inspector/InspectorController.
- WebInspector.cpp: (WebInspector::isTimelineProfilingEnabled):
- 9:30 AM Changeset in webkit [77949] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
editing/selection/end-of-document.html is failing in the GTK 64-bit debug bot
https://bugs.webkit.org/show_bug.cgi?id=53995
Ensure to wait for the body to be loaded before running the test.
- editing/selection/end-of-document.html: Call runEditingTest() on the body.onload event.
- 9:27 AM Changeset in webkit [77948] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-08 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Andreas Kling.
[Qt] Should not always define USE_SYSTEM_MALLOC
https://bugs.webkit.org/show_bug.cgi?id=54007
- wtf/Platform.h:
- 9:21 AM Changeset in webkit [77947] by
-
- 4 edits in trunk/Tools
2011-02-08 Kundu Suchismita <suchi.kundu@nokia.com>
Reviewed by Laszlo Gombos.
Local Storage settings can be enable/disable from "Develop" menu
https://bugs.webkit.org/show_bug.cgi?id=52296
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): (LauncherWindow::toggleLocalStorage): (LauncherWindow::toggleOfflineStorageDatabase): (LauncherWindow::toggleOfflineWebApplicationCache): (LauncherWindow::setOfflineStorageDefaultQuota):
- QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
- QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):
- 9:16 AM Changeset in webkit [77946] by
-
- 2 edits in trunk/Source/WebCore
2011-02-08 George Wright <gwright@rim.com>
Reviewed by Adam Barth.
Ensure that we pack the colour byte order correctly for Skia using
Skia's SkPackARGB32 function.
- platform/image-decoders/ImageDecoder.h: (WebCore::ImageFrame::setRGBA):
- 9:05 AM Changeset in webkit [77945] by
-
- 2 edits in trunk/Source/WebCore
2011-02-08 George Wright <gwright@rim.com>
Reviewed by Darin Adler.
Ensure we do not pass (-1, -1) sized rects to ImageBuffer but instead
pass the full image dimensions.
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImageBuffer):
- 8:50 AM Changeset in webkit [77944] by
-
- 3 edits in trunk/Source/WebCore
2011-02-08 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
[WIN] Add missing includes and forward declarations for DownloadBundle
https://bugs.webkit.org/show_bug.cgi?id=53881
- platform/network/cf/DownloadBundle.h:
- platform/network/win/DownloadBundleWin.cpp: (WebCore::DownloadBundle::appendResumeData):
- 8:47 AM Changeset in webkit [77943] by
-
- 2 edits in trunk/Source/WebCore
2011-02-08 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
[WIN] Add missing include in WKCAImageQueue
https://bugs.webkit.org/show_bug.cgi?id=53890
- platform/graphics/win/WKCAImageQueue.cpp:
- 8:28 AM Changeset in webkit [77942] by
-
- 2 edits in trunk/Source/WebKit2
ASSERTION FAILURE: ASSERT_NOT_REACHED() in Connection::writeEventHandler() after the Web
Process crashes.
https://bugs.webkit.org/show_bug.cgi?id=54005
Reviewed by Adam Roben.
- Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::writeEventHandler):
Handle ERROR_BROKEN_PIPE by calling connectionDidClose() and returning early.
- 8:17 AM Changeset in webkit [77941] by
-
- 2 edits in trunk/WebKitLibraries
2011-02-08 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
[WIN] Add missing forward declarations in WebKitSystemInterface.h
https://bugs.webkit.org/show_bug.cgi?id=53889
- win/include/WebKitSystemInterface/WebKitSystemInterface.h:
- 8:08 AM Changeset in webkit [77940] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Unskip a bunch of tests that are passing locally and move one
timeout with the other timeouts.
- platform/gtk/Skipped: Unskip some passing tests.
- 8:03 AM Changeset in webkit [77939] by
-
- 2 edits in trunk/Source/WebKit2
Handle WM_TIMER messages for stopped timers
Whenever we stop a timer, we call ::KillTimer to cancel any future firings of the timer. But
::KillTimer doesn't do anything about WM_TIMER messages that have already been posted to the
message queue. We need to handle those, too.
Fixes <http://webkit.org/b/53999> Occasional assertion failures in
RunLoop::TimerBase::timerFired
Reviewed by Darin Adler.
- Platform/win/RunLoopWin.cpp:
(RunLoop::TimerBase::timerFired): Just bail if the timer has already been stopped.
- 8:01 AM Changeset in webkit [77938] by
-
- 2 edits in trunk/Source/WebKit2
Don't mark a Connection as connected until open() is called on Windows
This matches Mac. Even though the Connection's pipe is connected before open() is called,
the Connection itself isn't really connected to the pipe until then, and we won't actually
read any data from before that point.
Fixes <http://webkit.org/b/53998> <rdar://problem/8971207> REGRESSION (r77874): Assertion
failure on launch in Connection::setDidCloseOnConnectionWorkQueueCallback on Windows
Reviewed by Darin Adler.
- Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::platformInitialize): Moved code to set m_isConnected from here to
open.
(CoreIPC::Connection::platformInvalidate): Unset m_isConnected, to match Mac. (This isn't
part of the bug fix, but seemed worthwhile.)
(CoreIPC::Connection::open): Set m_isConnected now that we're going to listen on the pipe.
- 7:58 AM Changeset in webkit [77937] by
-
- 7 edits in trunk/Source/WebCore
2011-02-08 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
[WIN] Add missing includes and forward declarations for CFNetwork
https://bugs.webkit.org/show_bug.cgi?id=53883
- platform/network/cf/DNSCFNet.cpp:
- platform/network/cf/LoaderRunLoopCF.cpp:
- platform/network/cf/LoaderRunLoopCF.h:
- platform/network/cf/ProxyServerCFNet.cpp:
- platform/network/cf/SocketStreamHandle.h:
- platform/network/cf/SocketStreamHandleCFNet.cpp:
- 7:57 AM Changeset in webkit [77936] by
-
- 4 edits in trunk
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] EventSender.keyDown does not support non-array modifier arguments
https://bugs.webkit.org/show_bug.cgi?id=53962
- platform/gtk/Skipped: Unskip a test which is now passing.
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] EventSender.keyDown does not support non-array modifier arguments
https://bugs.webkit.org/show_bug.cgi?id=53962
Support handling either an array or a string for the modifier argument
to EventSender.keyDown.
- DumpRenderTree/gtk/EventSender.cpp: (gdkModifierFromJSValue): Added this helper which factors out the string comparison bits. (gdkModifersFromJSValue): Test up front whether the value is a string, to handle it specially.
- 7:51 AM Changeset in webkit [77935] by
-
- 2 edits in trunk/Source/WebCore
2011-02-08 Patrick Gansterer <Patrick Gansterer>
Unreviewed WinCE build fix for r77870.
- platform/DragImage.cpp: Compile createDragImageForLink on WinCE.
- 7:48 AM Changeset in webkit [77934] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Removing inspector tests from Skipped on [win].
Resource tracking has been removed since then, maybe it'll help.
- platform/win/Skipped:
- 7:46 AM Changeset in webkit [77933] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Clean up the skipped list slightly and unskip a test which should now be passing.
- platform/gtk/Skipped: Clean up.
- 7:40 AM Changeset in webkit [77932] by
-
- 2 edits in trunk/Source/WebCore
2011-02-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: open network resource url in new tab upon double click.
https://bugs.webkit.org/show_bug.cgi?id=53930
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype.createCells): (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
- 7:34 AM Changeset in webkit [77931] by
-
- 2 edits in trunk/Source/WebCore
2011-02-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: $x: any node should work in optional context parameter.
https://bugs.webkit.org/show_bug.cgi?id=50138
- inspector/InjectedScriptSource.js:
- 7:30 AM Changeset in webkit [77930] by
-
- 2 edits in trunk/Source/WebCore
2011-02-08 Patrick Gansterer <Patrick Gansterer>
Unreviewed WinCE build fix for r77870.
Remove the global namespace prefix from GlobalLock/GlobalUnlock.
- platform/win/ClipboardUtilitiesWin.cpp:
- 7:27 AM Changeset in webkit [77929] by
-
- 5 edits2 adds in trunk
2011-02-08 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: re-apply r77924.
Test: inspector/console-api-on-call-frame.html
- inspector/InjectedScriptSource.js:
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
- 7:08 AM Changeset in webkit [77928] by
-
- 2 edits in trunk/Source/WebCore
2011-02-08 Andreas Kling <kling@webkit.org>
Reviewed by Tor Arne Vestbø.
REGRESSION(r77312): Unbreak TiledBackingStore.
Due to an off-by-one error, we were no longer rendering the
rightmost column and bottom row of tiles.
Covered by tst_QGraphicsWebView::widgetsRenderingThroughCache().
- platform/graphics/TiledBackingStore.cpp: (WebCore::TiledBackingStore::invalidate): (WebCore::TiledBackingStore::updateTileBuffers): (WebCore::TiledBackingStore::paint): (WebCore::TiledBackingStore::createTiles):
- 6:26 AM Changeset in webkit [77927] by
-
- 3 edits2 deletes in trunk
2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77924.
http://trac.webkit.org/changeset/77924
https://bugs.webkit.org/show_bug.cgi?id=53997
Breaks inspector tests. (Requested by pfeldman on #webkit).
- inspector/console-api-on-call-frame-expected.txt: Removed.
- inspector/console-api-on-call-frame.html: Removed.
2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77924.
http://trac.webkit.org/changeset/77924
https://bugs.webkit.org/show_bug.cgi?id=53997
Breaks inspector tests. (Requested by pfeldman on #webkit).
- inspector/InjectedScriptSource.js: (.): ():
- 6:04 AM Changeset in webkit [77926] by
-
- 3 edits in trunk/Tools
2011-02-08 Benjamin Poulain <ikipou@gmail.com>
Reviewed by Csaba Osztrogonác.
openDatabaseSync() stop responding after too many call
https://bugs.webkit.org/show_bug.cgi?id=53945
Reset the database quota to a known state between each test.
Define a quota for the known origins at each test run and delete
all the databases.
This way, the database related test do not depend on previous
allocations.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::dumpDatabaseQuota):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):
- 5:42 AM Changeset in webkit [77925] by
-
- 16 edits in trunk/Source/WebCore
2011-02-04 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [refacotring] merge InspectorAgent::willSendRequest() into InspectorResourceAgent
https://bugs.webkit.org/show_bug.cgi?id=53789
- perform UserAgent override via InspectorInstrumentation
- move adding extra request headers to InspectorResourceAgent
- simplified things in InspectorState
- inspector/Inspector.idl:
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::applyUserAgentOverride):
- inspector/InspectorAgent.h:
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl): (WebCore::InspectorInstrumentation::willSendRequestImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::applyUserAgentOverride):
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::setExtraHeaders): (WebCore::InspectorResourceAgent::willSendRequest):
- inspector/InspectorResourceAgent.h:
- inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState): (WebCore::InspectorState::restoreFromInspectorCookie): (WebCore::InspectorState::updateCookie): (WebCore::InspectorState::setValue): (WebCore::InspectorState::getBoolean): (WebCore::InspectorState::getString): (WebCore::InspectorState::getLong): (WebCore::InspectorState::getObject):
- inspector/InspectorState.h: (WebCore::InspectorState::setObject):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::userAgent):
- 5:29 AM Changeset in webkit [77924] by
-
- 3 edits2 adds in trunk
2011-02-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: do not hide scope variables with command line api.
https://bugs.webkit.org/show_bug.cgi?id=53497
- inspector/console-api-on-call-frame-expected.txt: Added.
- inspector/console-api-on-call-frame.html: Added.
2011-02-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: do not hide scope variables with command line api.
https://bugs.webkit.org/show_bug.cgi?id=53497
Test: inspector/console-api-on-call-frame.html
- inspector/InjectedScriptSource.js:
- 5:03 AM Changeset in webkit [77923] by
-
- 2 edits in trunk/Source/WebKit/efl
2011-02-08 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed build fix.
[EFL] Fix when building with curl backend.
- ewk/ewk_settings.cpp: (ewk_settings_proxy_uri_get):
- 4:57 AM Changeset in webkit [77922] by
-
- 11 edits1 delete in trunk
2011-02-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: ignore cache upon reload via Ctrl(Cmd)+Shift+R.
https://bugs.webkit.org/show_bug.cgi?id=53914
- http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.reloadPage):
- inspector/audits-panel-functional.html:
2011-02-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: ignore cache upon reload via Ctrl(Cmd)+Shift+R.
https://bugs.webkit.org/show_bug.cgi?id=53914
- inspector/Inspector.idl:
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::reloadPage):
- inspector/InspectorAgent.h:
- inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onReload):
- inspector/front-end/inspector.js: (WebInspector.documentKeyDown):
- 4:45 AM Changeset in webkit [77921] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipping test timing out on GTK 32-bit debug bot.
fast/loader/onload-willSendRequest-null-for-frame.html times out in GTK 32-bit debug bot
https://bugs.webkit.org/show_bug.cgi?id=53992
- platform/gtk/Skipped: Skipped test.
- 3:26 AM Changeset in webkit [77920] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipping flaky test on GTK debug bots.
fast/frames/sandboxed-iframe-storage.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=53991
- platform/gtk/Skipped: Skipped test.
- 2:52 AM Changeset in webkit [77919] by
-
- 3 edits in trunk/Source/WebCore
Skip over sibling selectors when collecting descendant selector hashes
https://bugs.webkit.org/show_bug.cgi?id=53987
Reviewed by Cameron Zwarich.
Skip instead of bailing out. This will allow optimizing some sibling selector cases.
- css/CSSStyleSelector.cpp:
(WebCore::RuleData::RuleData):
(WebCore::RuleData::collectIdentifierHashes):
(WebCore::RuleData::collectDescendantSelectorIdentifierHashes):
- css/CSSStyleSelector.h:
- 2:50 AM Changeset in webkit [77918] by
-
- 2 edits in trunk/LayoutTests
2011-02-08 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipping flaky test on GTK debug bots.
svg/custom/use-multiple-on-nested-disallowed-font.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=53989
- platform/gtk/Skipped: Skipped test.
- 2:20 AM Changeset in webkit [77917] by
-
- 8 edits2 adds in trunk
2011-02-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] DRT's TextInputController is unimplemented on GTK
https://bugs.webkit.org/show_bug.cgi?id=52997
- platform/gtk/Skipped: Unskip several tests that pass now that we have TextInputController.
2011-02-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] DRT's TextInputController is unimplemented on GTK
https://bugs.webkit.org/show_bug.cgi?id=52997
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setComposition): (DumpRenderTreeSupportGtk::confirmComposition): (DumpRenderTreeSupportGtk::firstRectForCharacterRange): (DumpRenderTreeSupportGtk::selectedRange): New methods needed by TextInputController.
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-02-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] DRT's TextInputController is unimplemented on GTK
https://bugs.webkit.org/show_bug.cgi?id=52997
Initial implementation of TextInputController for GTK port.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared):
- DumpRenderTree/gtk/TextInputController.cpp: Added. (setMarkedTextCallback): (insertTextCallback): (unmarkTextCallback): (firstRectForCharacterRangeCallback): (selectedRangeCallback): (getClass): (makeTextInputController):
- DumpRenderTree/gtk/TextInputController.h: Added.
- GNUmakefile.am:
- 1:18 AM Changeset in webkit [77916] by
-
- 2 edits in trunk/Source/JavaScriptCore
LLVM Compiler build fix.
Reviewed by Maciej Stachowiak.
- runtime/WriteBarrier.h:
(JSC::WriteBarrier::WriteBarrier):
- 12:49 AM Changeset in webkit [77915] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77866.
http://trac.webkit.org/changeset/77866
https://bugs.webkit.org/show_bug.cgi?id=53981
caused all WebKit2 inspector tests to crash (Requested by
othermaciej on #webkit).
- UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::didClose):
Feb 7, 2011:
- 11:44 PM Changeset in webkit [77914] by
-
- 3 edits2 adds in trunk
2011-02-07 Cris Neckar <cdn@chromium.org>
Reviewed by Jian Li.
Test for null deref in DOMURL
https://bugs.webkit.org/show_bug.cgi?id=53811
- fast/files/domurl-script-execution-context-crash-expected.txt: Added.
- fast/files/domurl-script-execution-context-crash.html: Added.
2011-02-07 Cris Neckar <cdn@chromium.org>
Reviewed by Jian Li.
Fix null deref in DOMURL
https://bugs.webkit.org/show_bug.cgi?id=53811
Test: fast/files/domurl-script-execution-context-crash.html
- html/DOMURL.cpp: (WebCore::DOMURL::DOMURL):
- 11:30 PM Changeset in webkit [77913] by
-
- 19 edits in trunk/Tools
2011-02-07 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
clean up python imports
https://bugs.webkit.org/show_bug.cgi?id=53966
Convert "import A.B.C.D as D" to "from A.B.C import D" and
make some imports absolute as required by PEP-8
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/common/net/irc/ircbot.py:
- Scripts/webkitpy/common/system/logutils.py:
- Scripts/webkitpy/common/system/logutils_unittest.py:
- Scripts/webkitpy/layout_tests/deduplicate_tests.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/mac.py: Remove some unused imports
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py:
- Scripts/webkitpy/tool/bot/irc_command.py:
- Scripts/webkitpy/tool/bot/sheriffircbot.py:
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/prettydiff.py:
- Scripts/webkitpy/tool/commands/queries.py:
- Scripts/webkitpy/tool/commands/roll.py:
- Scripts/webkitpy/tool/commands/stepsequence.py:
- Scripts/webkitpy/tool/commands/upload.py:
- Scripts/webkitpy/tool/main.py:
- 11:29 PM Changeset in webkit [77912] by
-
- 2 edits in trunk/Tools
2011-02-07 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Teach do-webcore-rename about the WebKit move to Source/
https://bugs.webkit.org/show_bug.cgi?id=53967
- Scripts/do-webcore-rename:
- 11:24 PM Changeset in webkit [77911] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] Fix crashes in QMetaObject::metacall
https://bugs.webkit.org/show_bug.cgi?id=53912
- platform/qt/Skipped: http/tests/websocket/tests/websocket-protocol-ignored.html added until fix.
- 11:13 PM Changeset in webkit [77910] by
-
- 2 edits in trunk/Source/WebCore
Fix the 32-bit build.
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar): Remove some extraneous characters.
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar): Ditto.
- 11:07 PM Changeset in webkit [77909] by
-
- 2 edits in trunk/LayoutTests
2011-02-07 Kenji Imasaki <imasaki@chromium.org>
Reviewed by David Levin.
[Chromium] Remove non-Flaky media layout tests and update bugs that
are associated with media layout tests
https://bugs.webkit.org/show_bug.cgi?id=53948
- platform/chromium/test_expectations.txt:
- 11:07 PM Changeset in webkit [77908] by
-
- 16 edits2 adds in trunk
2011-02-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Add resource load client for injected bundle and move willSendRequest there
https://bugs.webkit.org/show_bug.cgi?id=53972
- GNUmakefile.am:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageSetPageLoaderClient): (WKBundlePageSetResourceLoadClient):
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp: Added. (WebKit::InjectedBundlePageResourceLoadClient::didInitiateLoadForResource): (WebKit::InjectedBundlePageResourceLoadClient::willSendRequestForFrame): (WebKit::InjectedBundlePageResourceLoadClient::didReceiveResponseForResource): (WebKit::InjectedBundlePageResourceLoadClient::didReceiveContentLengthForResource): (WebKit::InjectedBundlePageResourceLoadClient::didFinishLoadForResource): (WebKit::InjectedBundlePageResourceLoadClient::didFailLoadForResource):
- WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h: Added.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebKit::WebFrameLoaderClient::dispatchWillSendRequest): (WebKit::WebFrameLoaderClient::dispatchDidReceiveResponse): (WebKit::WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebKit::WebFrameLoaderClient::dispatchDidFinishLoading): (WebKit::WebFrameLoaderClient::dispatchDidFailLoading):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::initializeInjectedBundleResourceLoadClient):
- WebProcess/WebPage/WebPage.h: (WebKit::WebPage::injectedBundleResourceLoadClient):
- win/WebKit2.vcproj:
2011-02-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Add resource load client for injected bundle and move willSendRequest there
https://bugs.webkit.org/show_bug.cgi?id=53972
- MiniBrowser/mac/WebBundle/WebBundleMain.m: (didCreatePage):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::didInitiateLoadForResource): (WTR::InjectedBundlePage::didReceiveResponseForResource): (WTR::InjectedBundlePage::didReceiveContentLengthForResource): (WTR::InjectedBundlePage::didFinishLoadForResource): (WTR::InjectedBundlePage::didFailLoadForResource): (WTR::InjectedBundlePage::willSendRequestForFrame):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- 11:07 PM Changeset in webkit [77907] by
-
- 2 edits1 add in trunk/Source/WebCore
2011-02-07 Xiyuan Xia <xiyuan@chromium.org>
Reviewed by Tony Chang.
[Chromium] Select popup box does not align with select button when appearance is not "menulist".
https://bugs.webkit.org/show_bug.cgi?id=53942
Added manual test select_webkit_appearance_off_popup_alignment.html.
- manual-tests/select_webkit_appearance_off_popup_alignment.html: Added.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::layout):
- 10:59 PM Changeset in webkit [77906] by
-
- 4 edits in trunk/Source
2011-02-07 Aparna Nandyal <aparna.nand@wipro.com>
Reviewed by Andreas Kling.
[Qt] - Context menu needs "Copy" as well when the selected text is a link.
https://bugs.webkit.org/show_bug.cgi?id=40983
Added copy option for Qt platform if selection is a link.
Added a test in tst_qwebpage.cpp.
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::populate):
2011-02-07 Aparna Nandyal <aparna.nand@wipro.com>
Reviewed by Andreas Kling.
[Qt] - Context menu needs "Copy" as well when the selected text is a link.
https://bugs.webkit.org/show_bug.cgi?id=40983
Added a test case to create a context sensitive menu.
A check is made if it has Copy menu item when user
selects a link and opens context menu.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::contextMenuCopy):
- 10:48 PM Changeset in webkit [77905] by
-
- 3 edits in trunk/Source/WebCore
2011-02-07 Mike Reed <reed@google.com>
Reviewed by Kenneth Russell.
Add compile-time flag ENABLE(SKIA_GPU) to use Skia's gpu backend
when drawing <canvas>. Disabled by default.
No new tests. existing canvas layouttests apply
- platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::publishToPlatformLayer):
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::GetGlobalGrContext): (WebCore::PlatformContextSkia::isPrinting): (WebCore::PlatformContextSkia::setSharedGraphicsContext3D): (WebCore::PlatformContextSkia::syncSoftwareCanvas):
- 10:45 PM Changeset in webkit [77904] by
-
- 3 edits in trunk/Source/WebCore
2011-02-07 Jay Civelli <jcivelli@chromium.org>
Reviewed by Darin Fisher.
Removing unused code from PopupMenuChromium.
https://bugs.webkit.org/show_bug.cgi?id=53866
- platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupListBox::layout):
(WebCore::PopupMenuChromium::show):
- platform/chromium/PopupMenuChromium.h:
- 10:39 PM Changeset in webkit [77903] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-02-07 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
bring back diff context lines into the review tool
https://bugs.webkit.org/show_bug.cgi?id=53974
- code-review.js:
- 10:30 PM Changeset in webkit [77902] by
-
- 3 edits2 adds in trunk
2011-02-07 Kenichi Ishibashi <bashi@google.com>
Reviewed by Andreas Kling.
HTMLOutputElement::childrenChanged() should call its base class childrenChanged()
https://bugs.webkit.org/show_bug.cgi?id=53791
Test that a live list is updated after the child of an HTMLOutputElement was removed.
- fast/dom/HTMLOutputElement/htmloutputelement-children-removed-expected.txt: Added.
- fast/dom/HTMLOutputElement/htmloutputelement-children-removed.html: Added.
2011-02-07 Kenichi Ishibashi <bashi@chromium.org>
Reviewed by Andreas Kling.
HTMLOutputElement::childrenChanged() should call its base class childrenChanged()
https://bugs.webkit.org/show_bug.cgi?id=53791
Calls HTMLFormControlElement::childrenChanged() in HTMLOutputElement::childrenChanged().
Test: fast/dom/HTMLOutputElement/htmloutputelement-children-removed.html
- html/HTMLOutputElement.cpp: (WebCore::HTMLOutputElement::childrenChanged): Calls super class's childrenChanged().
- 10:27 PM Changeset in webkit [77901] by
-
- 6 edits in trunk/Source
2011-02-07 Benjamin Poulain <ikipou@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] cookiesEnabled could create the cookieJar on the wrong thread.
https://bugs.webkit.org/show_bug.cgi?id=52289
Use the QtNAMThreadSafeProxy to make sure the cookie jar is created
in the same thread as the QNetworkAccessManager.
- platform/network/qt/QtNAMThreadSafeProxy.cpp: (WebCore::QtNAMThreadSafeProxy::QtNAMThreadSafeProxy): (WebCore::QtNAMThreadSafeProxy::hasCookieJar):
- platform/network/qt/QtNAMThreadSafeProxy.h:
- platform/qt/CookieJarQt.cpp: (WebCore::cookiesEnabled):
2011-02-07 Benjamin Poulain <ikipou@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] cookiesEnabled could create the cookieJar on the wrong thread.
https://bugs.webkit.org/show_bug.cgi?id=52289
Test if the cookie jar is created in the right thread when accessed from
the navigator object.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::navigatorCookieEnabledForNetworkAccessManagerOnDifferentThread):
- 10:25 PM Changeset in webkit [77900] by
-
- 9 edits in trunk/Source
2011-02-07 Alexey Marinichev <amarinichev@chromium.org>
Reviewed by Kenneth Russell.
Hook up WebGraphicsContext3D::setContextLostCallback.
https://bugs.webkit.org/show_bug.cgi?id=53722
Test: fast/canvas/webgl/context-lost.html, comment out the line with
extension.loseContext() and kill the GPU process "Lose context"
message shows up.
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContextLostCallback::WebGLRenderingContextLostCallback): (WebCore::WebGLRenderingContextLostCallback::onContextLost): (WebCore::WebGLRenderingContextLostCallback::~WebGLRenderingContextLostCallback): (WebCore::WebGLRenderingContext::initializeNewContext): (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
- platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::ContextLostCallback::~ContextLostCallback):
- platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::setContextLostCallback): stub
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::setContextLostCallback): stub
2011-02-07 Alexey Marinichev <amarinichev@chromium.org>
Reviewed by Kenneth Russell.
Hook up WebGraphicsContext3D::setContextLostCallback.
https://bugs.webkit.org/show_bug.cgi?id=53722
Test: fast/canvas/webgl/context-lost.html, comment out the line with
extension.loseContext() and kill the GPU process "Lose context"
message shows up.
- public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::WebGraphicsContextLostCallback::~WebGraphicsContextLostCallback):
- src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContextLostCallbackAdapter::~GraphicsContextLostCallbackAdapter): (WebCore::GraphicsContextLostCallbackAdapter::GraphicsContextLostCallbackAdapter): (WebCore::GraphicsContextLostCallbackAdapter::onContextLost): (WebCore::GraphicsContextLostCallbackAdapter::create): (WebCore::GraphicsContext3DInternal::setContextLostCallback):
- src/GraphicsContext3DInternal.h:
- 10:24 PM Changeset in webkit [77899] by
-
- 2 edits in trunk/Source/WebKit2
Fix the 32-bit build.
- UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation): Add some casts
to prevent warnings about mixing signed and unsigned comparisons.
- 10:11 PM Changeset in webkit [77898] by
-
- 3 edits in trunk/Tools
2011-02-07 Adam Barth <abarth@webkit.org>
Add Leopard Debug back to the core builders.
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
- Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
- 10:08 PM Changeset in webkit [77897] by
-
- 4 edits in trunk/LayoutTests
2011-02-07 Ami Fischman <fischman@google.com>
Reviewed by Eric Seidel.
Re-baseline media/video-zoom.html for http://crbug.com/70252 aka
https://bugs.webkit.org/show_bug.cgi?id=53737 to account for (very)
slightly different scrollbar shading.
This test isn't flaky on LINUX or MAC according to
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showAllRuns=true&master=ChromiumWebkit&tests=media%2Fvideo-zoom.html
so take it out of test_expectations.txt; it passes 100% on LINUX and
fails 100% on MAC, and should pass 100% on MAC with this new
baseline.
- platform/chromium-mac/media/video-zoom-expected.checksum:
- platform/chromium-mac/media/video-zoom-expected.png:
- platform/chromium/test_expectations.txt:
- 10:05 PM Changeset in webkit [77896] by
-
- 5 edits in trunk
2011-02-07 Adam Klein <adamk@chromium.org>
Reviewed by Jian Li.
[chromium] Remove deprecated method WebNotification::dir
https://bugs.webkit.org/show_bug.cgi?id=53735
- public/WebNotification.h:
- src/WebNotification.cpp:
2011-02-07 Adam Klein <adamk@chromium.org>
Reviewed by Jian Li.
[chromium] Remove deprecated method WebNotification::dir
https://bugs.webkit.org/show_bug.cgi?id=53735
- DumpRenderTree/chromium/NotificationPresenter.cpp: (NotificationPresenter::show):
- 10:02 PM Changeset in webkit [77895] by
-
- 2 edits in trunk/Source/WebCore
2011-02-07 Patrick Gansterer <Patrick Gansterer>
Reviewed by Eric Seidel.
Add missing PaintInfo include in RenderThemeWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=53885
- rendering/RenderThemeWin.cpp:
- 9:39 PM Changeset in webkit [77894] by
-
- 1 edit3 moves in trunk/LayoutTests
2011-02-07 James Robinson <jamesr@chromium.org>
Move sputnik expectations to match test movement.
- platform/gtk/fast/js/sputnik: Removed.
- platform/gtk/fast/js/sputnik/Unicode: Removed.
- platform/gtk/fast/js/sputnik/Unicode/Unicode_510: Removed.
- platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Removed.
- platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Removed.
- platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Removed.
- platform/gtk/sputnik: Copied from LayoutTests/platform/gtk/fast/js/sputnik.
- platform/mac-leopard/fast/js/sputnik: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A3.2-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S15.5.4.16_A1-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S15.5.4.18_A1-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T1-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T2-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.2_T1-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.2_T2-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.3-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T1-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T2-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T7-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T8-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T9-expected.txt: Removed.
- platform/mac-leopard/sputnik: Copied from LayoutTests/platform/mac-leopard/fast/js/sputnik.
- platform/win/fast/js/sputnik: Removed.
- platform/win/fast/js/sputnik/Conformance: Removed.
- platform/win/fast/js/sputnik/Conformance/11_Expressions: Removed.
- platform/win/fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators: Removed.
- platform/win/fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Percent: Removed.
- platform/win/fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Percent/S11.5.3_A4_T6-expected.txt: Removed.
- platform/win/fast/js/sputnik/Unicode: Removed.
- platform/win/fast/js/sputnik/Unicode/Unicode_510: Removed.
- platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Removed.
- platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Removed.
- platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Removed.
- platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Removed.
- platform/win/sputnik: Copied from LayoutTests/platform/win/fast/js/sputnik.
- 9:37 PM Changeset in webkit [77893] by
-
- 37 edits38 deletes in trunk/LayoutTests
2011-02-07 Ami Fischman <fischman@google.com>
Reviewed by Eric Carlson.
Removed two of the three almost-duplicate test expectations
between {media,platform/chromium-{mac,win}} by excluding file
extensions from the emitted output.
Removed outdated test_expectation for deleted test.
http://crbug.com/28993
- media/controls-right-click-on-timebar-expected.txt:
- media/controls-right-click-on-timebar.html:
- media/media-file.js: (stripExtension):
- media/media-startTime-expected.txt:
- media/media-startTime.html:
- media/video-append-source-expected.txt:
- media/video-append-source.html:
- media/video-canvas-source-expected.txt:
- media/video-canvas-source.html:
- media/video-dom-src-expected.txt:
- media/video-dom-src.html:
- media/video-load-networkState-expected.txt:
- media/video-load-networkState.html:
- media/video-played-reset-expected.txt:
- media/video-played-reset.html:
- media/video-seek-past-end-paused-expected.txt:
- media/video-seek-past-end-paused.html:
- media/video-seek-past-end-playing-expected.txt:
- media/video-seek-past-end-playing.html:
- media/video-source-expected.txt:
- media/video-source-type-expected.txt:
- media/video-source-type-params-expected.txt:
- media/video-source-type-params.html:
- media/video-source-type.html:
- media/video-source.html:
- media/video-src-change-expected.txt:
- media/video-src-change.html:
- media/video-src-expected.txt:
- media/video-src-remove-expected.txt:
- media/video-src-remove.html:
- media/video-src-set-expected.txt:
- media/video-src-set.html:
- media/video-src-source-expected.txt:
- media/video-src-source.html:
- media/video-src.html:
- media/video-test.js: (enableFullTestDetailsPrinting): (test): (testExpected): (waitForEvent._eventCallback): (waitForEvent): (waitForEventAndTest._eventCallback): (waitForEventAndTest): (testException): (endTest):
- platform/chromium-mac/media/controls-right-click-on-timebar-expected.txt: Removed.
- platform/chromium-mac/media/media-startTime-expected.txt: Removed.
- platform/chromium-mac/media/video-append-source-expected.txt: Removed.
- platform/chromium-mac/media/video-canvas-source-expected.txt: Removed.
- platform/chromium-mac/media/video-dom-src-expected.txt: Removed.
- platform/chromium-mac/media/video-load-networkState-expected.txt: Removed.
- platform/chromium-mac/media/video-played-reset-expected.txt: Removed.
- platform/chromium-mac/media/video-seek-past-end-paused-expected.txt: Removed.
- platform/chromium-mac/media/video-seek-past-end-playing-expected.txt: Removed.
- platform/chromium-mac/media/video-source-add-src-expected.txt: Removed.
- platform/chromium-mac/media/video-source-error-expected.txt: Removed.
- platform/chromium-mac/media/video-source-expected.txt: Removed.
- platform/chromium-mac/media/video-source-type-expected.txt: Removed.
- platform/chromium-mac/media/video-source-type-params-expected.txt: Removed.
- platform/chromium-mac/media/video-src-change-expected.txt: Removed.
- platform/chromium-mac/media/video-src-expected.txt: Removed.
- platform/chromium-mac/media/video-src-remove-expected.txt: Removed.
- platform/chromium-mac/media/video-src-set-expected.txt: Removed.
- platform/chromium-mac/media/video-src-source-expected.txt: Removed.
- platform/chromium-win/media/controls-right-click-on-timebar-expected.txt: Removed.
- platform/chromium-win/media/media-startTime-expected.txt: Removed.
- platform/chromium-win/media/video-append-source-expected.txt: Removed.
- platform/chromium-win/media/video-canvas-source-expected.txt: Removed.
- platform/chromium-win/media/video-dom-src-expected.txt: Removed.
- platform/chromium-win/media/video-load-networkState-expected.txt: Removed.
- platform/chromium-win/media/video-played-reset-expected.txt: Removed.
- platform/chromium-win/media/video-seek-past-end-paused-expected.txt: Removed.
- platform/chromium-win/media/video-seek-past-end-playing-expected.txt: Removed.
- platform/chromium-win/media/video-source-add-src-expected.txt: Removed.
- platform/chromium-win/media/video-source-error-expected.txt: Removed.
- platform/chromium-win/media/video-source-expected.txt: Removed.
- platform/chromium-win/media/video-source-type-expected.txt: Removed.
- platform/chromium-win/media/video-source-type-params-expected.txt: Removed.
- platform/chromium-win/media/video-src-change-expected.txt: Removed.
- platform/chromium-win/media/video-src-expected.txt: Removed.
- platform/chromium-win/media/video-src-remove-expected.txt: Removed.
- platform/chromium-win/media/video-src-set-expected.txt: Removed.
- platform/chromium-win/media/video-src-source-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 9:37 PM Changeset in webkit [77892] by
-
- 14 edits in trunk/Source
2011-02-07 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Andreas Kling.
[Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl
https://bugs.webkit.org/show_bug.cgi?id=52974
Add ContextMenuItemTagCopyImageUrlToClipboard into standard action but Qt platform specific.
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): (WebCore::ContextMenuController::populate): (WebCore::ContextMenuController::checkOrEnableIfNeeded):
- platform/ContextMenuItem.h:
- platform/LocalizationStrategy.h:
- platform/LocalizedStrings.cpp: (WebCore::contextMenuItemTagCopyImageUrlToClipboard):
- platform/LocalizedStrings.h:
2011-02-07 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Andreas Kling.
[Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl
https://bugs.webkit.org/show_bug.cgi?id=52974
Add QWebPage::CopyImageUrlToClipboard into QWebPage::WebAction.
- Api/qwebpage.cpp: (webActionForContextMenuAction): (QWebPage::triggerAction): (QWebPage::action):
- Api/qwebpage.h:
- WebCoreSupport/WebPlatformStrategies.cpp: (WebPlatformStrategies::contextMenuItemTagCopyImageUrlToClipboard):
- WebCoreSupport/WebPlatformStrategies.h:
2011-02-07 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Andreas Kling.
[Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl
https://bugs.webkit.org/show_bug.cgi?id=52974
Add ContextMenuItemTagCopyImageUrlToClipboard into standard action but Qt platform specific.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::contextMenuItemTagCopyImageUrlToClipboard):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- 9:28 PM Changeset in webkit [77891] by
-
- 4 edits2 adds in trunk
2011-02-07 Kenichi Ishibashi <bashi@chromium.org>
Reviewed by Kent Tamura.
HTMLFormElement::formElementIndex() returns a bad index into a vector of form associated elements
https://bugs.webkit.org/show_bug.cgi?id=53970
Adds HTMLObjectElement::virtualForm() to make HTMLObjectElement::form()
return the right value.
Test: fast/dom/HTMLObjectElement/form/nested-form-element.html
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::virtualForm): Added.
- html/HTMLObjectElement.h: Added virtualForm().
2011-02-07 Kenichi Ishibashi <bashi@chromium.org>
Reviewed by Kent Tamura.
HTMLFormElement::formElementIndex() returns a bad index into a vector of form associated elements
https://bugs.webkit.org/show_bug.cgi?id=53970
Adds a test that ensures WebKit parses successfully a page that
contains object elements which are in nested and defective form
elements.
- fast/dom/HTMLObjectElement/form/nested-form-element-expected.txt: Added.
- fast/dom/HTMLObjectElement/form/nested-form-element.html: Added.
- 8:39 PM Changeset in webkit [77890] by
-
- 3 edits in trunk/Tools
2011-02-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove Leopard Debug as a core builder
https://bugs.webkit.org/show_bug.cgi?id=53971
The Leopard Debug builder has been failing to compile for several days.
My understanding is that folks are working on fixing the build, but for
the time being we should probably remove it from the list of core
builders so that the core waterfall can be green. We can certainly add
it back once the build is fixed.
Also, I've removed the Tiger builders because those no longer appear to
be attached to the buildbot master.
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
- Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
- 8:29 PM Changeset in webkit [77889] by
-
- 5 edits in trunk
2011-02-01 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Roben.
include svn revisions in git diffs for the code review tool to use
https://bugs.webkit.org/show_bug.cgi?id=53569
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/common/checkout/scm_unittest.py:
2011-02-01 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Roben.
include svn revisions in git diffs for the code review tool to use
https://bugs.webkit.org/show_bug.cgi?id=53569
- PrettyPatch/PrettyPatch.rb:
- 8:27 PM Changeset in webkit [77888] by
-
- 3 edits in trunk/Source/WebCore
2011-02-07 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Leopard build fix.
- WebCore.xcodeproj/project.pbxproj: let XCode have developmentRegion.
- platform/mac/DragImageMac.mm: (WebCore::webkit_CGCeiling): Cast the return value of ceil to CGFloat.
- 8:21 PM Changeset in webkit [77887] by
-
- 2 edits in trunk/LayoutTests
2011-02-07 Yuzo Fujishima <yuzo@google.com>
Unreviewed attempt to fix a flaky test.
https://bugs.webkit.org/show_bug.cgi?id=51757
- fast/css/font-face-download-error.html:
- 8:07 PM Changeset in webkit [77886] by
-
- 2 edits in trunk/LayoutTests
2011-02-07 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 7:55 PM Changeset in webkit [77885] by
-
- 8 edits1 move in trunk/LayoutTests
2011-02-07 James Robinson <jamesr@chromium.org>
Reviewed by Dan Bernstein.
Move the sputnik test suite out of fast/js/
https://bugs.webkit.org/show_bug.cgi?id=53954
The sputnik suite shouldn't go in fast/js/ because it is not fast and
it is an imported test suite. This moves it to LayoutTests/sputnik
and updates references in skipped lists / expectations.
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac-tiger/Skipped:
- platform/mac-wk2/Skipped:
- platform/qt-wk2/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 7:37 PM Changeset in webkit [77884] by
-
- 1 edit in trunk/Source/JavaScriptCore/ChangeLog
Fixing the change log entry.
- 7:34 PM Changeset in webkit [77883] by
-
- 5 edits in trunk/Source/JavaScriptCore
2011-02-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed some dead code from Heap
https://bugs.webkit.org/show_bug.cgi?id=53969
SunSpider reports no change.
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::shrink): (JSC::MarkedSpace::sweep):
- runtime/MarkedSpace.h: Removed resizeBlocks and growBlocks, and renamed shrinkBlocks to shrink, making it unconditionally shrink as much as possible.
- 7:13 PM Changeset in webkit [77882] by
-
- 4 edits in trunk/Source
Source/WebCore: Fixing a build break on Mac caused by http://trac.webkit.org/changeset/77874
Reviewed by Sam Weinig.
When moving code from WebKit to WebCore we needed to move some additional
functions previously in NSStringExtras.
- WebCore.xcodeproj/project.pbxproj:
- platform/mac/DragImageMac.mm:
(WebCore::fontFromNSFont):
(WebCore::canUseFastRenderer):
(WebCore::widthWithFont):
(WebCore::webkit_CGCeiling):
(WebCore::drawAtPoint):
(WebCore::drawDoubledAtPoint):
(WebCore::createDragImageForLink):
Source/WebKit2: Fixing a build break on Mac caused by http://trac.webkit.org/changeset/77874
Reviewed by Sam Weinig.
Removed unused static function.
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
- 7:08 PM Changeset in webkit [77881] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-02-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed some dead code from Heap
https://bugs.webkit.org/show_bug.cgi?id=53969
SunSpider reports no change.
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::shrink): (JSC::MarkedSpace::sweep):
- runtime/MarkedSpace.h: Removed resizeBlocks and growBlocks, and renamed shrinkBlocks to shrink, making it unconditionally shrink as much as possible.
- 6:21 PM Changeset in webkit [77880] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/8969888>
The WebProcess should set LSFileQuarantineEnabled to true
Reviewed by Sam Weinig.
- WebProcess/Info.plist:
- 6:13 PM Changeset in webkit [77879] by
-
- 2 edits in trunk/LayoutTests
2011-02-07 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 6:04 PM Changeset in webkit [77878] by
-
- 3 edits in trunk/Source/WebCore
2011-02-07 Lucas Forschler <Lucas Forschler>
Reviewed by Geoff Garen.
Tr #2, Fix the Leopard 32bit debug build.
No new tests required.
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AccessibilityAllInOne.cpp:
- 5:58 PM Changeset in webkit [77877] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Simplified the marked space's mark invariant
https://bugs.webkit.org/show_bug.cgi?id=53968
SunSpider reports no change.
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): Mark objects when allocating them. This means that, at all times other than the mark phase, an object is live if and only if it is marked.
(JSC::MarkedSpace::containsSlowCase): Use the new mark invariant to
simplify testing whether an object is live.
- 5:53 PM Changeset in webkit [77876] by
-
- 3 edits in trunk/Source/WebCore
Fix for <rdar://problem/8946961> Fix repaint problems
with WKScrollbarPainter scrollers while resizing the window
Reviewed by Sam Weinig.
Remove setPainterForPainterController() and
removePainterFromPainterController() since they aren't
used anymore.
- platform/mac/ScrollAnimatorMac.h:
Return early if they alpha hasn't changed.
- platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
If we're in a live resize, restore alpha to 1.
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
- 5:47 PM Changeset in webkit [77875] by
-
- 15 edits4 adds in trunk
2011-02-03 MORITA Hajime <morrita@google.com>
Reviewed by Darin Fisher.
[Chromium] Should implement EditorClientImpl::requestCheckingOfString()
https://bugs.webkit.org/show_bug.cgi?id=51013
Unskipped passed test.
- platform/chromium/test_expectations.txt:
2011-02-03 MORITA Hajime <morrita@google.com>
Reviewed by Darin Fisher.
[Chromium] Should implement EditorClientImpl::requestCheckingOfString()
https://bugs.webkit.org/show_bug.cgi?id=51013
- Added WebTextCheckingCompletion to receive the checked result asynchronously.
- Added WebViewClient::requestCheckingOfText() and related classes.
- Implemented EditorClientImpl::requestCheckingOfString().
- WebKit.gyp:
- public/WebSettings.h:
- public/WebTextCheckingCompletion.h: Added. (WebKit::WebTextCheckingCompletion::~WebTextCheckingCompletion):
- public/WebTextCheckingResult.h: Added. (WebKit::WebTextCheckingResult::error): (WebKit::WebTextCheckingResult::position): (WebKit::WebTextCheckingResult::length): (WebKit::WebTextCheckingResult::WebTextCheckingResult):
- public/WebViewClient.h: (WebKit::WebViewClient::requestCheckingOfText): Gave an implementation
- src/AssertMatchingEnums.cpp:
- src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::requestCheckingOfString):
- src/EditorClientImpl.h:
- src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setAsynchronousSpellCheckingEnabled):
- src/WebSettingsImpl.h:
- src/WebTextCheckingCompletionImpl.cpp: Added. (WebKit::toCoreResults): (WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
- src/WebTextCheckingCompletionImpl.h: Added. (WebKit::WebTextCheckingCompletionImpl::WebTextCheckingCompletionImpl):
2011-02-03 MORITA Hajime <morrita@google.com>
Reviewed by Darin Fisher.
[Chromium] Should implement EditorClientImpl::requestCheckingOfString()
https://bugs.webkit.org/show_bug.cgi?id=51013
Gave DRT implementation for requestTextCheck().
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setAsynchronousSpellCheckingEnabled): Implemented.
- DumpRenderTree/chromium/WebViewHost.cpp: (invokeFinishLastTextCheck): Added. (WebViewHost::requestTextCheck): Added. (WebViewHost::finishLastTextCheck): Added.
- DumpRenderTree/chromium/WebViewHost.h:
- 5:44 PM Changeset in webkit [77874] by
-
- 8 edits in trunk/Source/WebKit2
2011-02-07 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Crash in web process after the connection had been closed
https://bugs.webkit.org/show_bug.cgi?id=51115
<rdar://problem/8964255>
Remove didCloseOnConnectionWorkQueue from Connection::Client and add
Connection::setDidCloseOnConnectionWorkQueueCallback which takes a static
function, eliminating the race condition in connectionDidClose where m_client could be
nulled out in the client thread right before we try to dereference it.
- Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::Connection): Initialize m_didCloseOnConnectionWorkQueueCallback.
(CoreIPC::Connection::setDidCloseOnConnectionWorkQueueCallback):
Update m_didCloseOnConnectionWorkQueueCallback.
(CoreIPC::Connection::connectionDidClose):
Call m_didCloseOnConnectionWorkQueueCallback.
- Platform/WorkQueue.h: Make WorkQueue noncopyable.
- PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::initializeConnection): Call setDidCloseOnConnectionWorkQueueCallback.
- Shared/ChildProcess.cpp: (WebKit::ChildProcess::didCloseOnConnectionWorkQueue):
- Shared/ChildProcess.h: didCloseOnConnectionWorkQueue is now a static member function.
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::initialize): Call setDidCloseOnConnectionWorkQueueCallback.
- 5:39 PM Changeset in webkit [77873] by
-
- 2 edits59 adds in trunk/LayoutTests
2011-02-07 Martin Robinson <mrobinson@igalia.com>
Classify tests failing in the fast directory on GTK+. Add results for
tests that just need platform expectations.
- platform/gtk/Skipped: Update the skipped list.
- platform/gtk/fast/backgrounds/background-clip-text-expected.checksum: Added.
- platform/gtk/fast/backgrounds/background-clip-text-expected.png: Added.
- platform/gtk/fast/backgrounds/background-clip-text-expected.txt: Added.
- platform/gtk/fast/canvas/canvas-zoom-expected.txt: Added.
- platform/gtk/fast/css/css1_forward_compatible_parsing-expected.checksum: Added.
- platform/gtk/fast/css/css1_forward_compatible_parsing-expected.png: Added.
- platform/gtk/fast/css/css1_forward_compatible_parsing-expected.txt: Added.
- platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
- platform/gtk/fast/css/invalid-percentage-property-expected.checksum: Added.
- platform/gtk/fast/css/invalid-percentage-property-expected.png: Added.
- platform/gtk/fast/css/invalid-percentage-property-expected.txt: Added.
- platform/gtk/fast/css/text-align-expected.checksum: Added.
- platform/gtk/fast/css/text-align-expected.png: Added.
- platform/gtk/fast/css/text-align-expected.txt: Added.
- platform/gtk/fast/dom/Element/getBoundingClientRect-expected.txt: Added.
- platform/gtk/fast/dom/Range/getBoundingClientRect-expected.txt: Added.
- platform/gtk/fast/dom/Range/getClientRects-expected.txt: Added.
- platform/gtk/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
- platform/gtk/fast/dom/null-document-location-put-crash-expected.txt: Added.
- platform/gtk/fast/dom/tabindex-clamp-expected.txt: Added.
- platform/gtk/fast/events/js-keyboard-event-creation-expected.txt: Added.
- platform/gtk/fast/events/offsetX-offsetY-expected.txt: Added.
- platform/gtk/fast/events/pointer-events-2-expected.checksum: Added.
- platform/gtk/fast/events/pointer-events-2-expected.png: Added.
- platform/gtk/fast/events/pointer-events-2-expected.txt: Added.
- platform/gtk/fast/fast-mobile-scrolling/fixed-position-element-expected.checksum: Added.
- platform/gtk/fast/fast-mobile-scrolling/fixed-position-element-expected.png: Added.
- platform/gtk/fast/fast-mobile-scrolling/fixed-position-element-expected.txt: Added.
- platform/gtk/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.checksum: Added.
- platform/gtk/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.png: Added.
- platform/gtk/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.txt: Added.
- platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.checksum: Added.
- platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.png: Added.
- platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.txt: Added.
- platform/gtk/fast/html/tab-order-expected.txt: Added.
- platform/gtk/fast/replaced/table-percent-height-expected.txt: Added.
- platform/gtk/fast/selectors/lang-inheritance-expected.checksum: Added.
- platform/gtk/fast/selectors/lang-inheritance-expected.png: Added.
- platform/gtk/fast/selectors/lang-inheritance-expected.txt: Added.
- platform/gtk/fast/selectors/lang-inheritance2-expected.checksum: Added.
- platform/gtk/fast/selectors/lang-inheritance2-expected.png: Added.
- platform/gtk/fast/selectors/lang-inheritance2-expected.txt: Added.
- platform/gtk/fast/selectors/lang-vs-xml-lang-expected.checksum: Added.
- platform/gtk/fast/selectors/lang-vs-xml-lang-expected.png: Added.
- platform/gtk/fast/selectors/lang-vs-xml-lang-expected.txt: Added.
- platform/gtk/fast/selectors/lang-vs-xml-lang-xhtml-expected.checksum: Added.
- platform/gtk/fast/selectors/lang-vs-xml-lang-xhtml-expected.png: Added.
- platform/gtk/fast/selectors/lang-vs-xml-lang-xhtml-expected.txt: Added.
- platform/gtk/fast/text/international/danda-space-expected.checksum: Added.
- platform/gtk/fast/text/international/danda-space-expected.png: Added.
- platform/gtk/fast/text/international/danda-space-expected.txt: Added.
- platform/gtk/fast/text/international/thai-baht-space-expected.checksum: Added.
- platform/gtk/fast/text/international/thai-baht-space-expected.png: Added.
- platform/gtk/fast/text/international/thai-baht-space-expected.txt: Added.
- 5:38 PM Changeset in webkit [77872] by
-
- 2 edits in trunk/LayoutTests
2011-02-07 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 5:35 PM Changeset in webkit [77871] by
-
- 4 edits in trunk/Source
Fix for https://bugs.webkit.org/show_bug.cgi?id=53950
USE_WK_SCROLLBAR_PAINTER in ScrollbarThemeMac should be in
Platform.h instead
Reviewed by Eric Seidel.
- wtf/Platform.h:
../WebCore:
Use hot new USE(WK_SCROLLBAR_PAINTER) from Platform.h rather
than the silly, old in-file #define.
- platform/mac/ScrollbarThemeMac.mm:
(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
(WebCore::updateArrowPlacement):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::paint):
- 5:34 PM Changeset in webkit [77870] by
-
- 47 edits3 adds in trunk/Source
Reviewed Adam Roben and Darin Adler.
Source/WebCore:
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
<rdar://problem/8514409>
- loader/EmptyClients.h: Removed createDragImageFromLink.
- page/DragClient.h: Ditto.
- page/DragController.cpp:
(WebCore::DragController::startDrag): changed call to createDragImageFromLink.
- platform/DragImage.h:
- platform/mac/DragImageMac.mm:
(WebCore::createDragImageForLink): Moved from DragClient.
- platform/win/ClipboardUtilitiesWin.cpp: Added a series of functions
to de-serialize the drag data from the map into an IDataObject.
(WebCore::getWebLocData):
(WebCore::texthtmlFormat):
(WebCore::createGlobalData):
(WebCore::getFullCFHTML):
(WebCore::urlWFormat):
(WebCore::urlFormat):
(WebCore::filenameWFormat):
(WebCore::filenameFormat):
(WebCore::htmlFormat):
(WebCore::smartPasteFormat):
(WebCore::getURL):
(WebCore::getPlainText):
(WebCore::getTextHTML):
(WebCore::ClipboardDataItem::ClipboardDataItem):
(WebCore::getStringData):
(WebCore::getUtf8Data):
(WebCore::getCFData):
(WebCore::setUCharData):
(WebCore::setCharData):
(WebCore::setCFData):
(WebCore::getClipboardMap):
(WebCore::getClipboardData):
(WebCore::setClipboardData):
- platform/win/ClipboardUtilitiesWin.h:
- platform/win/DragImageWin.cpp: Moved createDragImageForLink from DragClient
to a platform specific file in WebCore. It makes a lot more sense here, since
the drag image is always created in WebCore for all the other content types
except for links.
(WebCore::dragLabelFont):
(WebCore::createDragImageForLink):
- platform/win/WCDataObject.cpp: Added new way to
construct a WCDataObject from a DragDataMap.
(WebCore::WCDataObject::createInstance):
(WebCore::WCDataObject::clearData):
- platform/win/WCDataObject.h:
Source/WebKit/chromium:
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
Removed createDragImageForLink from DragClient.
- src/DragClientImpl.cpp:
- src/DragClientImpl.h:
Source/WebKit/efl:
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
Removed createDragImageForLink from DragClient.
- WebCoreSupport/DragClientEfl.cpp:
- WebCoreSupport/DragClientEfl.h:
Source/WebKit/gtk:
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
Removed createDragImageForLink from DragClient.
- WebCoreSupport/DragClientGtk.cpp:
- WebCoreSupport/DragClientGtk.h:
Source/WebKit/haiku:
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
Removed createDragImageForLink from DragClient.
- WebCoreSupport/DragClientHaiku.cpp:
- WebCoreSupport/DragClientHaiku.h:
Source/WebKit/mac:
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
Removed createDragImageForLink from DragClient.
- WebCoreSupport/WebDragClient.h:
- WebCoreSupport/WebDragClient.mm:
(WebDragClient::startDrag):
Source/WebKit/qt:
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
Removed createDragImageForLink from DragClient.
- WebCoreSupport/DragClientQt.cpp:
- WebCoreSupport/DragClientQt.h:
Source/WebKit/win:
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
Removed createDragImageForLink from DragClient.
- WebCoreSupport/WebDragClient.cpp:
(WebDragClient::startDrag):
- WebCoreSupport/WebDragClient.h:
Source/WebKit/wince:
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
Removed createDragImageForLink from DragClient.
- WebCoreSupport/DragClientWinCE.cpp:
- WebCoreSupport/DragClientWinCE.h:
Source/WebKit/wx:
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
Removed createDragImageForLink from DragClient.
- WebKitSupport/DragClientWx.cpp:
- WebKitSupport/DragClientWx.h:
Source/WebKit2:
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
<rdar://problem/8514409>
This patch contains the remaining work to support
a WebKit window as drag source on Windows.
I've added the code to generate the image for dragging a link as
well as the steps necessary to package the HBITMAP into a SharedMemory
object and send it over to the UI process where DoDragDrop is performed.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setDragImage):
(WebKit::WebPageProxy::startDragDrop):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebDragClient.cpp:
(WebKit::WebDragClient::startDrag): Made startDrag for
platforms other than Windows and Mac.
- WebProcess/WebCoreSupport/WebDragClient.h:
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::startDrag):
- WebProcess/WebCoreSupport/win/WebDragClientWin.cpp: Added.
(WebKit::draggingSourceOperationMaskToDragCursors):
(WebKit::WebDragClient::startDrag):
- WebProcess/WebCoreSupport/win/WebDragSource.cpp: Added.
This object implements the IDropSource interface.
(WebDragSource::createInstance):
(WebDragSource::WebDragSource):
(WebDragSource::QueryInterface):
(WebDragSource::AddRef):
(WebDragSource::Release):
(WebDragSource::QueryContinueDrag):
(WebDragSource::GiveFeedback):
- WebProcess/WebCoreSupport/win/WebDragSource.h: Added.
- win/WebKit2.vcproj:
- 5:32 PM Changeset in webkit [77869] by
-
- 2 edits in trunk/LayoutTests
2011-02-07 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 5:23 PM Changeset in webkit [77868] by
-
- 8 edits1 add in trunk
2011-02-07 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[Gtk] Implement layoutTestController.findString
https://bugs.webkit.org/show_bug.cgi?id=50237
Unskip editing/text-iterator/findString.html.
- platform/gtk/Skipped: Unskip findString test.
2011-02-07 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[Gtk] Implement layoutTestController.findString
https://bugs.webkit.org/show_bug.cgi?id=50237
- GNUmakefile.am: Add AssertMatchingEnums.cpp.
- WebCoreSupport/AssertMatchingEnums.cpp: Add this file to assert that various WebKit API enum values continue matching WebCore defined enum values.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::findString):
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-02-07 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[Gtk] Implement layoutTestController.findString
https://bugs.webkit.org/show_bug.cgi?id=50237
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::findString):
- 5:02 PM Changeset in webkit [77867] by
-
- 2 edits in trunk/Source/WebCore
2011-02-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77848.
http://trac.webkit.org/changeset/77848
https://bugs.webkit.org/show_bug.cgi?id=53963
caused 6 test failures (Requested by othermaciej on #webkit).
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
- 5:00 PM Changeset in webkit [77866] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-07 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
UI process crashes if web process crashes while web inspector is focused
https://bugs.webkit.org/show_bug.cgi?id=53965
<rdar://problem/8961633>
Make sure to close the web inspector web page proxy before calling platformClose, since
platformClose can cause the web page proxy to try to send messages (such as SetActive)
to the web process while it's in a bad state.
- UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::didClose):
- 4:57 PM Changeset in webkit [77865] by
-
- 5 edits4 adds in trunk/Source/WebCore
2011-02-04 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Add shaders for GPU accelerated path rendering
https://bugs.webkit.org/show_bug.cgi?id=45520
Refactored SolidFillShader and TexShader to call new
generateVertex() and generateFragment() methods on base Shader
class, and added support for the Loop/Blinn shaders. Refactored
Loop/Blinn shader classes to derive from Shader.
Tested these changes with several of the IE9 Testdrive demos with
accelerated 2D canvas enabled, as well as a full layout test run
with --platform chromium-gpu.
- platform/graphics/gpu/LoopBlinnShader.cpp: Added. (WebCore::LoopBlinnShader::LoopBlinnShader): (WebCore::LoopBlinnShader::use):
- platform/graphics/gpu/LoopBlinnShader.h: Added.
- platform/graphics/gpu/LoopBlinnSolidFillShader.cpp: Added. (WebCore::LoopBlinnSolidFillShader::create): (WebCore::LoopBlinnSolidFillShader::LoopBlinnSolidFillShader): (WebCore::LoopBlinnSolidFillShader::use):
- platform/graphics/gpu/LoopBlinnSolidFillShader.h: Added.
- platform/graphics/gpu/Shader.cpp: (WebCore::Shader::affineTo4x4): (WebCore::Shader::loadShader): (WebCore::Shader::loadProgram): (WebCore::Shader::generateVertex): (WebCore::Shader::generateFragment):
- platform/graphics/gpu/Shader.h:
- platform/graphics/gpu/SolidFillShader.cpp: (WebCore::SolidFillShader::create):
- platform/graphics/gpu/TexShader.cpp: (WebCore::TexShader::TexShader): (WebCore::TexShader::create):
- 4:51 PM Changeset in webkit [77864] by
-
- 2 edits in trunk/LayoutTests
2011-02-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
Skip a newly added test that uses unimplemented DRT functionality
https://bugs.webkit.org/show_bug.cgi?id=53938
- platform/mac-wk2/Skipped:
- 4:30 PM Changeset in webkit [77863] by
-
- 5 edits1 add in trunk/LayoutTests
2011-02-07 Zhenyao Mo <zmo@google.com>
Unreviewed, rebaseline.
- platform/chromium-linux/fast/html/keygen-expected.checksum:
- platform/chromium-linux/fast/html/keygen-expected.png:
- platform/chromium-linux/fast/html/keygen-expected.txt: Added.
- platform/chromium-win/fast/html/keygen-expected.txt:
- platform/chromium/test_expectations.txt:
- 4:29 PM Changeset in webkit [77862] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-07 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Find bouncy is missing content on pages with framesets
https://bugs.webkit.org/show_bug.cgi?id=53958
<rdar://problem/8904447>
Fix paint rect computation; FrameView::paint expects the paint rect to be in the
parent widget's coordinate system.
- WebProcess/WebPage/FindController.cpp: (WebKit::FindController::updateFindIndicator):
- 4:22 PM Changeset in webkit [77861] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/8960434> and https://bugs.webkit.org/show_bug.cgi?id=53957
Crash after incorrectly restoring bogus session state.
Reviewed by Anders Carlsson.
In some cases we're writing an invalid session state for a back/forward list where the current entry is 0
but the number of entries is also 0.
In such cases the current entry should be "NoCurrentEntryIndex."
When we later read this state in, we set ourselves up to crash later.
Amusingly an ASSERT caught this, but we should've rejected it before the ASSERT fired.
- UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation): Fail the restore if the "current index past the end
of the list" case occurs, and speculatively bail out of the case where we have no current index but do have a list.
Also remove the unhelpful ASSERT.
- 4:22 PM Changeset in webkit [77860] by
-
- 2 edits in trunk/LayoutTests
2011-02-07 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 4:11 PM Changeset in webkit [77859] by
-
- 2 edits in trunk/LayoutTests
2011-02-07 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 4:07 PM Changeset in webkit [77858] by
-
- 3 edits in trunk/Source/WebCore
<rdar://problem/8946023> REGRESSION (r76674): SVG + BiDi text broken (text-intro-05-t.svg)
https://bugs.webkit.org/show_bug.cgi?id=53480
Reviewed by Oliver Hunt.
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): m_indexEnd should be an
offset into m_characters, not into the run’s characters.
- platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Ditto.
- 4:01 PM Changeset in webkit [77857] by
-
- 2 edits in trunk/LayoutTests
2011-02-07 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 3:46 PM Changeset in webkit [77856] by
-
- 7 edits in trunk/Source
Add bundle API to get the background color of a frame
<rdar://problem/8962670>
https://bugs.webkit.org/show_bug.cgi?id=53952
Reviewed by Anders Carlsson.
../WebCore:
- WebCore.exp.in: Add export.
../WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameGetBodyBackgroundColor):
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
Add API function.
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::getDocumentBackgroundColor):
- WebProcess/WebPage/WebFrame.h:
Call down into the document to get either the body's, or if there is no body,
the root element's, background color.
- 3:45 PM Changeset in webkit [77855] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] Fix crashes in QMetaObject::metacall
https://bugs.webkit.org/show_bug.cgi?id=53912
- platform/qt/Skipped: http/tests/websocket/tests/websocket-pending-activity.html added until fix.
- 3:41 PM Changeset in webkit [77854] by
-
- 3 edits in trunk/LayoutTests
2011-02-07 Zhenyao Mo <zmo@google.com>
Unreviewed, rebaseline.
- platform/chromium-mac/fast/url/path-expected.txt:
- platform/chromium-win/fast/url/path-expected.txt:
- 3:37 PM Changeset in webkit [77853] by
-
- 4 edits in trunk/Source/WebCore
2011-02-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Assertion failure in ~JSGlobalObject when loading apple.com HTML5
transitions demo page
https://bugs.webkit.org/show_bug.cgi?id=53853
This was a long-standing bookkeeping bug uncovered by some heap refactoring.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer):
- html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::notifyFinished):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dropProtection): Take the JSLock before reporting extra cost to the JavaScriptCore heap, since all use of JavaScriptCore is supposed to be guarded by JSLock.
- 3:28 PM Changeset in webkit [77852] by
-
- 8 edits in trunk
Intermittent crash in fast/files/read-blob-async.html on the GTK+ debug
bots
https://bugs.webkit.org/show_bug.cgi?id=53104
Reviewed by David Levin.
Source/WebCore:
Covered by the existing tests.
- fileapi/FileStreamProxy.cpp:
(WebCore::FileStreamProxy::startOnFileThread):
- platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::createResourceHandle):
- platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::BlobResourceHandle):
(WebCore::BlobResourceHandle::cancel):
(WebCore::delayedStartBlobResourceHandle):
(WebCore::BlobResourceHandle::start): Keep BlobResourceHandle alive
till the delay function is called.
(WebCore::BlobResourceHandle::doStart):
(WebCore::doNotifyFinish):
(WebCore::BlobResourceHandle::notifyFinish): Notify the client via the
standalone function to prevent the handle from being disposed immediately
by the client which will make the calls in the stack that're still bound
to the handle suffer.
- platform/network/BlobResourceHandle.h:
- platform/network/ResourceHandle.h: Change cancel() to virtual so that
BlobResourceHandle::cancel will be called when we abort a FileReader.
LayoutTests:
- platform/gtk/Skipped: Enable the flakey test that has been fixed.
- 3:27 PM Changeset in webkit [77851] by
-
- 1 edit1 delete in trunk/LayoutTests
2011-02-07 Adam Barth <abarth@webkit.org>
Remove wrong platform-specific expectation.
- platform/win/plugins/plugin-document-back-forward-expected.txt: Removed.
- 3:09 PM Changeset in webkit [77850] by
-
- 3 edits in trunk/Source/WebCore
2011-02-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77845.
http://trac.webkit.org/changeset/77845
https://bugs.webkit.org/show_bug.cgi?id=53946
build failure (Requested by lforschler_ on #webkit).
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AccessibilityAllInOne.cpp:
- 3:05 PM Changeset in webkit [77849] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=53939
fast/css/text-overflow-ellipsis.html failure after r77818/77819
- platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::registerExtendedEncodingNames):
Add back the "utf8" synonym for "UTF-8".
- 2:58 PM Changeset in webkit [77848] by
-
- 2 edits in trunk/Source/WebCore
Remove an unnecessary extra computeLogicalWidth() from line layout.
Reviewed by Dan Bernstein.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
- 2:34 PM Changeset in webkit [77847] by
-
- 3 edits in trunk/Source/WebKit2
Fix typo. vectical -> vertical.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeScrollbarsForMainFrame):
- 2:32 PM Changeset in webkit [77846] by
-
- 8 edits in trunk/Source/WebKit2
Inform the UIProcess when main frame scrollbars change
<rdar://problem/8967496>
https://bugs.webkit.org/show_bug.cgi?id=53941
Reviewed by Anders Carlsson.
- UIProcess/API/C/WKPage.cpp:
(WKPageHasHorizontalScrollbar):
(WKPageHasVerticalScrollbar):
- UIProcess/API/C/WKPage.h:
Add API to query whether the main frame has scrollbars.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::didChangeScrollbarsForMainFrame):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::hasHorizontalScrollbar):
(WebKit::WebPageProxy::hasVerticalScrollbar):
Store/update main frame scrollbar state.
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::contentsSizeChanged):
- WebProcess/WebCoreSupport/WebChromeClient.h:
(WebKit::WebChromeClient::WebChromeClient):
Post message when main frame scrollbar state changes.
- 2:28 PM Changeset in webkit [77845] by
-
- 3 edits in trunk/Source/WebCore
2011-02-07 Lucas Forschler <Lucas Forschler>
Reviewed by Geoffrey Garen.
Fix Leopard Intel Debug Build.
<rdar://problem/8953606> REGRESSION: Can't link WebCore on 32-bit Leopard (53681)
This could potentially break windows, since I had to change #include <filename> to #include "filename"
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AccessibilityAllInOne.cpp:
- 1:54 PM Changeset in webkit [77844] by
-
- 2 edits in trunk/LayoutTests
2011-02-07 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 1:48 PM Changeset in webkit [77843] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
- 1:42 PM Changeset in webkit [77842] by
-
- 8 edits in trunk/Source/WebKit2
2011-02-07 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Some content is not covered by Find-on-page overlay
https://bugs.webkit.org/show_bug.cgi?id=53937
<rdar://problem/8711353>
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::didInstallPageOverlay): Call LayerTreeHost::didInstallPageOverlay.
(WebKit::DrawingAreaImpl::didUninstallPageOverlay):
Call LayerTreeHost::didUninstallPageOverlay.
(WebKit::DrawingAreaImpl::setPageOverlayNeedsDisplay):
Call LayerTreeHost::setPageOverlayNeedsDisplay.
- WebProcess/WebPage/FindController.cpp: (WebKit::FindController::drawRect): Remove a bogus assertion.
- WebProcess/WebPage/LayerTreeHost.h: Add new pure virtual member functions.
- WebProcess/WebPage/PageOverlay.cpp: (WebKit::PageOverlay::setNeedsDisplay): Call DrawingArea::setPageOverlayNeedsDisplay.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::installPageOverlay): Make sure to call PageOverlay::setNeedsDisplay after the page overlay has been installed.
- WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::LayerTreeHostMac): Create the page overlay layer if needed.
(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay):
Invalidate the page overlay layer as well.
(WebKit::LayerTreeHostMac::sizeDidChange):
Resize the page overlay layer.
(WebKit::LayerTreeHostMac::didInstallPageOverlay):
Create the page overlay layer.
(WebKit::LayerTreeHostMac::didUninstallPageOverlay):
Destroy the page overlay layer.
(WebKit::LayerTreeHostMac::setPageOverlayNeedsDisplay):
Call setNeedsDisplay on the page overlay layer.
(WebKit::LayerTreeHostMac::paintContents):
Handle painting the page overlay layer.
(WebKit::LayerTreeHostMac::flushPendingLayerChanges):
Flush the page overlay layer changes as well.
(WebKit::LayerTreeHostMac::createPageOverlayLayer):
Create a layer and add it as a sublayer of the root layer.
(WebKit::LayerTreeHostMac::destroyPageOverlayLayer):
Destroy the page overlay layer.
- 1:29 PM Changeset in webkit [77841] by
-
- 9 edits in trunk/Source/WebCore
Add mechanism to inform the ScrollAnimator when Scrollbars are added
and removed.
Reviewed by Beth Dakin.
- platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::didAddVerticalScrollbar):
(WebCore::ScrollAnimator::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimator::didAddHorizontalScrollbar):
(WebCore::ScrollAnimator::willRemoveHorizontalScrollbar):
Make virtual to allow platform specific overrides.
- platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
Call new ScrollableArea functions.
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::didAddVerticalScrollbar):
(WebCore::ScrollableArea::willRemoveVerticalScrollbar):
(WebCore::ScrollableArea::didAddHorizontalScrollbar):
(WebCore::ScrollableArea::willRemoveHorizontalScrollbar):
- platform/ScrollableArea.h:
Pipe to ScrollAnimator.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
- platform/mac/ScrollbarThemeMac.h:
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::painterForScrollbar):
Move painter delegate registration to the new didAdd/willRemove functions.
- 1:25 PM Changeset in webkit [77840] by
-
- 2 edits in trunk/LayoutTests
2011-02-07 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 1:19 PM Changeset in webkit [77839] by
-
- 4 edits in trunk/Source/WebKit2
Make it possible to use DrawingAreaProxyImpl on Windows
It can be optionally turned on by setting the WEBKIT2_USE_NEW_DRAWING_AREA environment
variable. Turning it on by default is covered by <http://webkit.org/b/53805>.
Fixes <http://webkit.org/b/53879>.
Reviewed by Anders Carlsson.
- UIProcess/BackingStore.h: Add an m_bitmap member on Windows.
- UIProcess/win/BackingStoreWin.cpp:
(WebKit::BitmapDC::operator HDC):
(WebKit::BitmapDC::BitmapDC):
(WebKit::BitmapDC::~BitmapDC):
Added this helper class, which uses RAII to select a bitmap into a new memory DC.
(WebKit::BackingStore::paint): Wrap our bitmap in a BitmapDC and use ::BitBlt to copy the
specified rect into the destination DC.
(WebKit::createBitmap): New helper function, just creates a DIB section with the specified
size.
(WebKit::BackingStore::incorporateUpdate): Ported from BackingStoreMac.mm. It seems like
this code could be shared at some point.
(WebKit::BackingStore::scroll): Wrap our bitmap in a BitmapDC and use ::ScrollDC to scroll
the specified rect.
- UIProcess/win/WebView.cpp:
(WebKit::useNewDrawingArea): Added. Returns true if the WEBKIT2_USE_NEW_DRAWING_AREA
environment variable is set.
(WebKit::drawPageBackground): New helper function. Code came from onPaintEvent.
(WebKit::WebView::onPaintEvent): Ported from -[WKView drawRect:].
(WebKit::WebView::createDrawingAreaProxy): Create a DrawingAreaProxyImpl if we're using the
new drawing area.
(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):
(WebKit::WebView::pageDidEnterAcceleratedCompositing):
(WebKit::WebView::pageDidLeaveAcceleratedCompositing):
Added some assertions to make sure these are only called when expected. We don't expect
enter/exitAcceleratedCompositingMode to be called at all right now, because accelerated
compositing is turned off in WebKit2 on Windows.
(WebKit::WebView::switchToDrawingAreaTypeIfNecessary): Ditto, and added a case for the
DrawingAreaInfo::Impl constant.
- 1:19 PM Changeset in webkit [77838] by
-
- 13 edits2 copies in trunk/Source/WebKit2
Start compiling DrawingArea[Proxy]Impl and dependencies on Windows
Fixes <http://webkit.org/b/53875> WebKit2 on Windows should build DrawingArea[Proxy]Impl
Reviewed by Sam Weinig and Darin Adler.
- Platform/Region.cpp:
(WebKit::Region::Shape::shapeOperation): Initialize variable to avoid a bogus "potentially
uninitialized variable" warning.
- UIProcess/BackingStore.cpp: Removed #error for non-Mac platforms.
- UIProcess/BackingStore.h: Added a PlatformGraphicsContext typedef for Windows.
- UIProcess/DrawingAreaProxy.h:
- UIProcess/DrawingAreaProxyImpl.cpp:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
Allow Windows to compile the new drawing area code.
- WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create): Allow creating a DrawingAreaImpl on Windows, too.
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
- WebProcess/WebPage/LayerTreeHost.cpp:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage):
Allow Windows to compile the new drawing area code.
- Shared/win/LayerTreeContextWin.cpp: Added.
- UIProcess/win/BackingStoreWin.cpp: Added.
Stubbed out these files.
- win/WebKit2.vcproj: Added new files.
- 12:57 PM Changeset in webkit [77837] by
-
- 7 edits in trunk/Source/WebKit2
2011-02-07 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Rename some drawing area related member functions
https://bugs.webkit.org/show_bug.cgi?id=53935
- WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::setPageOverlayNeedsDisplay):
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setNeedsDisplay): (WebKit::DrawingAreaImpl::setPageOverlayNeedsDisplay):
- WebProcess/WebPage/DrawingAreaImpl.h:
- WebProcess/WebPage/LayerTreeHost.h:
- WebProcess/WebPage/mac/LayerTreeHostMac.h:
- WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay): (WebKit::LayerTreeHostMac::scrollNonCompositedContents):
- 12:49 PM Changeset in webkit [77836] by
-
- 2 edits in trunk/Tools
2011-02-07 Chang Shu <chang.shu@nokia.com>
Reviewed by Darin Adler.
We should disable spatial navigation explicitly during the initialization
of DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=53928
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- 12:43 PM Changeset in webkit [77835] by
-
- 2 edits in trunk/Source/WebCore
2011-02-07 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Missing text match markers with accelerated content
https://bugs.webkit.org/show_bug.cgi?id=53934
When doing the fake paint that recomputes the text match rects, we need to
flatten compositing layers, otherwise the rects won't be updated until the next paint call.
(This worked by accident in WebKit1 because Safari calls -[NSWindow displayIfNeeded] on the containing
window before asking for the text match rects).
- editing/Editor.cpp: (WebCore::Editor::countMatchesForText):
- 12:08 PM Changeset in webkit [77834] by
-
- 4 edits in trunk/Source/WebCore
REGRESSION(r77740): CSSStyleSelector accessing deleted memory for svg/dom/use-transform.svg
https://bugs.webkit.org/show_bug.cgi?id=53900
Reviewed by Andreas Kling.
Ignore link elements in shadow trees.
- dom/Element.cpp:
(WebCore::StyleSelectorParentPusher::StyleSelectorParentPusher):
(WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
Some asserts to catch cases like this.
(WebCore::Element::attach):
(WebCore::Element::recalcStyle):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::insertedIntoDocument):
(WebCore::HTMLLinkElement::removedFromDocument):
- html/HTMLLinkElement.h:
- 11:39 AM BuildingQtOnSymbian edited by
- add .slimdebug (diff)
- 11:18 AM Changeset in webkit [77833] by
-
- 2 edits in trunk/LayoutTests
2011-02-07 Dimitri Glazkov <Dimitri Glazkov>
Mark test as flaky per dashboard.
https://bugs.webkit.org/show_bug.cgi?id=53824
- platform/chromium/test_expectations.txt: Marked.
- 11:10 AM Changeset in webkit [77832] by
-
- 7 edits2 copies in branches/chromium/648
Merge 77706 - 2011-02-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474
Test that plugin loads when in a plugin document on back-forward.
- plugins/plugin-document-back-forward-expected.txt: Added.
- plugins/plugin-document-back-forward.html: Added.
2011-02-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474
Long ago, PluginDocument always caused the HTMLEmbedElement to create
its widget synchronously during a post-layout task. Recently, however,
some changes to the HistroyController caused layout on back/forward to
become slightly more complicated (and added an extra level of recursion
to layout). This extra level of recursion triggered the "I've recursed
too many times" condition in the post-layout task queue, causing the
FrameView to run the remainder of the tasks asynchronously.
Unfortunately, that broke PluginDocument because it needs its the
HTMLEmbedElement's updateWidget task to run synchronously.
This patch adds a mechanism for "kicking off" the pending post-layout
tasks synchronously (instead of waiting for the timer to fire).
PluginDocument then uses that facility to ensure that the
HTMLEmbedElement's updateWidget task happens.
Test: plugins/plugin-document-back-forward.html
- html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
- page/FrameView.cpp: (WebCore::FrameView::flushAnyPendingPostLayoutTasks):
- page/FrameView.h:
2011-02-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474
Teach the test plugin how to call alert on load.
- DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New):
TBR=abarth@webkit.org
Review URL: http://codereview.chromium.org/6286151
- 10:47 AM BuildingQtOnSymbian edited by
- add -b syntax for compiling both Source and Tools project files (diff)
- 10:46 AM Changeset in webkit [77831] by
-
- 9 edits in trunk/Source/WebCore
Turn UTF-8 decoder off for now so we can look into failing tests
without leaving the tree red.
- platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::registerBaseEncodingNames): Reverting
earlier change so this can handle UTF-8.
(WebCore::TextCodecICU::registerBaseCodecs): Ditto.
(WebCore::TextCodecICU::registerExtendedEncodingNames): Ditto.
(WebCore::TextCodecICU::registerExtendedCodecs): Ditto.
- platform/text/TextCodecICU.h: Ditto.
- platform/text/TextEncodingRegistry.cpp:
(WebCore::buildBaseTextCodecMaps): Ditto.
(WebCore::extendTextCodecMaps): Ditto.
- platform/text/brew/TextCodecBrew.cpp:
(WebCore::TextCodecBrew::registerBaseEncodingNames): Ditto.
(WebCore::TextCodecBrew::registerBaseCodecs): Ditto.
(WebCore::TextCodecBrew::registerExtendedEncodingNames): Ditto.
(WebCore::TextCodecBrew::registerExtendedCodecs): Ditto.
- platform/text/brew/TextCodecBrew.h: Ditto.
- platform/text/gtk/TextCodecGtk.cpp:
(WebCore::TextCodecGtk::registerBaseEncodingNames): Ditto.
(WebCore::TextCodecGtk::registerBaseCodecs): Ditto.
- platform/text/wince/TextCodecWinCE.cpp:
(WebCore::TextCodecWinCE::registerBaseEncodingNames): Ditto.
(WebCore::TextCodecWinCE::registerBaseCodecs): Ditto.
(WebCore::TextCodecWinCE::registerExtendedEncodingNames): Ditto.
(WebCore::TextCodecWinCE::registerExtendedCodecs): Ditto.
- platform/text/wince/TextCodecWinCE.h: Ditto.
- 10:45 AM Changeset in webkit [77830] by
-
- 2 edits in trunk/Source/WebKit2
Use the right calling convention when calling WebKitMain
Fixes <http://webkit.org/b/53923> REGRESSION (r77678): Crash on quit in web process in
wWinMain
Reviewed by Steve Falkenburg.
- win/MainWin.cpp:
(wWinMain): Use cdecl instead of WINAPI (stdcall) when calling WebKitMain, since that is
how that function is declared.
- 10:39 AM Changeset in webkit [77829] by
-
- 6 edits in trunk/Source/WebKit2
2011-02-07 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
The drawing area should be in charge of drawing the page overlay
https://bugs.webkit.org/show_bug.cgi?id=53927
- WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::didInstallPageOverlay): (WebKit::DrawingArea::didUninstallPageOverlay): (WebKit::DrawingArea::setOverlayNeedsDisplay): Add empty stubs.
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::didInstallPageOverlay): Add empty function. This will eventually ask the layer tree host to create a GraphicsLayer for the page overlay.
(WebKit::DrawingAreaImpl::didUninstallPageOverlay):
Tell the page that it needs to be repainted.
(WebKit::DrawingAreaImpl::setOverlayNeedsDisplay):
Just call setNeedsDisplay for now.
(WebKit::DrawingAreaImpl::display):
Paint the page overlay too.
- WebProcess/WebPage/DrawingAreaImpl.h:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRect): Only call drawPageOverlay if we have an old drawing area.
(WebKit::WebPage::drawPageOverlay):
Draw the page overlay. Code moved here from WebPage::drawRect.
(WebKit::WebPage::installPageOverlay):
Call DrawingArea::installPageOverlay.
(WebKit::WebPage::uninstallPageOverlay):
Call DrawingArea::uninstallPageOverlay.
- WebProcess/WebPage/WebPage.h: (WebKit::WebPage::hasPageOverlay): Add getter.
- 10:31 AM Changeset in webkit [77828] by
-
- 2 edits in trunk/Source/WebCore
Don't exclude overlay scrollers from the page overlay bounds
https://bugs.webkit.org/show_bug.cgi?id=53924
Reviewed by Maciej Stachowiak.
Export ScrollbarTheme::nativeTheme.
- WebCore.exp.in:
- 10:31 AM Changeset in webkit [77827] by
-
- 3 edits in branches/chromium/648/Source/WebCore
Merge 77597 - 2011-02-03 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] Bail out if to string conversion returned empty handle
https://bugs.webkit.org/show_bug.cgi?id=53687
This a temporary measure: actually one probably should never get empty handle
if there was no exception. The root cause is under investigation.
The bailout though allows Chromium not to crash---attempt to convert an empty
v8 hande into WebCore string crashes with invalid memory access.
See http://code.google.com/p/chromium/issues/detail?id=71544
There is no known reduction expressible as a layout test so far. The crash found with automated testing tools.
- bindings/v8/V8Binding.cpp: (WebCore::v8NonStringValueToWebCoreString): Bail out on empty handle
- bindings/v8/V8Binding.h: (WebCore::V8ParameterBase::prepareBase): Ditto
TBR=antonm@chromium.org
Review URL: http://codereview.chromium.org/6368135
- 10:26 AM Changeset in webkit [77826] by
-
- 4 edits in trunk/Source/WebKit2
2011-02-07 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add WebPage::bounds and use it
https://bugs.webkit.org/show_bug.cgi?id=53926
- WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::resumePainting):
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::resumePainting): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
- WebProcess/WebPage/WebPage.h: (WebKit::WebPage::bounds):
- 10:21 AM Changeset in webkit [77825] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-07 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej Stachowiak.
Don't exclude overlay scrollers from the page overlay bounds
https://bugs.webkit.org/show_bug.cgi?id=53924
Don't subtract the scrollbars from the page overlay bounds if
overlay scrollers are enabled.
- WebProcess/WebPage/PageOverlay.cpp: (WebKit::PageOverlay::bounds):
- 10:18 AM Changeset in webkit [77824] by
-
- 2 edits1 add in trunk/LayoutTests
2011-02-07 Martin Robinson <mrobinson@igalia.com>
Unskip a passing accessibility test and organize the rest of the tests missing
results as failing.
- platform/gtk/Skipped: Unskip passing test and organize remaining failures.
- platform/gtk/accessibility/aria-describedby-on-input-expected.txt: Added.
- 10:02 AM Changeset in webkit [77823] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add built-in decoder for UTF-8 for improved performance
https://bugs.webkit.org/show_bug.cgi?id=53898
Reviewed by Antti Koivisto.
- wtf/unicode/UnicodeMacrosFromICU.h: Added U8_MAX_LENGTH and
U8_APPEND_UNSAFE. Also fixed header.
- 9:57 AM Changeset in webkit [77822] by
-
- 2 edits in trunk/Tools
Not reviewed.
Fix WebKitTestRunner build on the SL bot.
- WebKitTestRunner/Configurations/Base.xcconfig: Look for the JSC copy
of ICU headers.
- 9:29 AM Changeset in webkit [77821] by
-
- 4 edits2 adds in trunk
2011-02-03 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Crash in glDrawArrays with NaCl crystal model
https://bugs.webkit.org/show_bug.cgi?id=52831
- html/canvas/WebGLRenderingContext.cpp: Allocate large enough buffer for atttrib0 if it's enabled and not used. (WebCore::WebGLRenderingContext::initVertexAttrib0): (WebCore::WebGLRenderingContext::simulateVertexAttrib0):
- html/canvas/WebGLRenderingContext.h:
2011-02-03 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Crash in glDrawArrays with NaCl crystal model
https://bugs.webkit.org/show_bug.cgi?id=52831
- fast/canvas/webgl/gl-vertex-attrib-zero-issues-expected.txt: Added.
- fast/canvas/webgl/gl-vertex-attrib-zero-issues.html: Added.
- 9:24 AM Changeset in webkit [77820] by
-
- 6 edits2 adds in trunk
Source/WebCore: WAI-ARIA @aria-sort not exposed on rowheader and columnheader roles.
https://bugs.webkit.org/show_bug.cgi?id=53842
Reviewed by Darin Adler.
Test: platform/mac/accessibility/aria-sort.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::sortDirection):
- accessibility/AccessibilityObject.h:
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
- html/HTMLAttributeNames.in:
LayoutTests: WAI-ARIA @aria-sort not exposed on rowheader and columnheader roles
https://bugs.webkit.org/show_bug.cgi?id=53842
Reviewed by Darin Adler.
- platform/mac/accessibility/aria-sort-expected.txt: Added.
- platform/mac/accessibility/aria-sort.html: Added.
- 8:35 AM Changeset in webkit [77819] by
-
- 17 edits2 adds in trunk/Source/WebCore
2011-02-06 Darin Adler <Darin Adler>
Reviewed by Antti Koivisto.
Add built-in decoder for UTF-8 for improved performance
https://bugs.webkit.org/show_bug.cgi?id=53898
Correct behavior is covered by existing tests.
- Android.mk: Added TextCodecUTF8.
- CMakeLists.txt: Ditto.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- platform/text/TextCodecICU.cpp: Removed registration of UTF-8 since that's now handled by the built-in UTF-8 codec. (WebCore::TextCodecICU::registerEncodingNames): Renamed to remove the word "extended" since all codecs from ICU are now extended. (WebCore::TextCodecICU::registerCodecs): Ditto.
- platform/text/TextCodecICU.h: Ditto.
- platform/text/TextCodecUTF16.cpp: (WebCore::TextCodecUTF16::decode): Added a FIXME about missing error handling.
- platform/text/TextCodecUTF8.cpp: Added.
- platform/text/TextCodecUTF8.h: Added.
- platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): Added TextCodecUTF8, and removed TextCodecICU, TextCodecBrew, and TextCodecWinCE. (WebCore::extendTextCodecMaps): Updated names for TextCodecICU and TextCodecWinCE.
- platform/text/brew/TextCodecBrew.cpp: (WebCore::TextCodecBrew::registerEncodingNames): Renamed to remove the word "extended" since all codecs from Brew are now extended. (WebCore::TextCodecBrew::registerCodecs): Ditto.
- platform/text/brew/TextCodecBrew.h: Ditto.
- platform/text/gtk/TextCodecGtk.cpp: (WebCore::TextCodecGtk::registerBaseEncodingNames): Removed registration of UTF-8. It's questionable whether the other codecs here are really basic. If we think they qualify, then we should register them on other platforms, not just GTK. (WebCore::TextCodecGtk::registerBaseCodecs): Ditto.
- platform/text/wince/TextCodecWinCE.cpp: (WebCore::getCodePage): Removed special case for UTF-8 since we no longer use this codec for UTF-8. (WebCore::TextCodecWinCE::registerEncodingNames): Renamed to remove the word "extended" since all codecs from WinCE are now extended. (WebCore::TextCodecWinCE::registerCodecs): Ditto.
- platform/text/wince/TextCodecWinCE.h: Ditto.
- 8:35 AM Changeset in webkit [77818] by
-
- 4 edits in trunk
2011-02-07 Martin Robinson <mrobinson@igalia.com>
Reviewed by Daniel Bates.
[GTK] fast/history/history-subframe-with-name.html fails with GTK DRT
https://bugs.webkit.org/show_bug.cgi?id=44784
- platform/gtk/Skipped: Unskip tests which are now passing.
2011-02-07 Martin Robinson <mrobinson@igalia.com>
Reviewed by Daniel Bates.
[GTK] fast/history/history-subframe-with-name.html fails with GTK DRT
https://bugs.webkit.org/show_bug.cgi?id=44784
Call FrameLoader::loadURLIntoChildFrame on the parent frame's loader, not the child's.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame): Fix the call to FrameLoader::loadURLIntoChildFrame.
- 8:23 AM Changeset in webkit [77817] by
-
- 4 edits in trunk/Source
2011-02-07 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
[Gtk] atk_text_get_caret_offset fails for list items
https://bugs.webkit.org/show_bug.cgi?id=53436
Consider list item markers when calculating the offset.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_caret_offset): Adjust the offset with the item marker's length for list items. (webkit_accessible_text_set_caret_offset): Replace usage of g_utf8_strlen() by calling to markerText.length().
2011-02-07 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
[Gtk] atk_text_get_caret_offset fails for list items
https://bugs.webkit.org/show_bug.cgi?id=53436
Update unit test to check the fix for this bug.
- tests/testatk.c: (testWebkitAtkCaretOffsets): Check that the caret offset returned match the value previously set.
- 8:03 AM Changeset in webkit [77816] by
-
- 2 edits in trunk/Source/WebKit2
Windows build fix after r77794
- win/WebKit2.def: Export WebCore symbols used by WebKitTestRunner.
- 8:02 AM Changeset in webkit [77815] by
-
- 3 edits in trunk/Source/JavaScriptCore
Delete precompiled headers whenever any .vsprops file changes
Precompiled headers need to be rebuilt if, e.g., an ENABLE_* macro is changed in one of our
.vsprops files. Unfortunately, Visual Studio isn't smart enough to figure this out, so we
give it some assistance by deleting the precompiled headers whenever any .vsprops file
changes.
I also made some drive-by fixes while I was in the area.
Fixes <http://webkit.org/b/53826> react-to-vsprops-changes.py doesn't force precompiled
headers to be rebuilt, but should
Reviewed by David Kilzer.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Stop ignoring the
return code from react-to-vsprops-changes.py so we will notice when errors are introduced.
But skip the script entirely in production builds, where it is both unnecessary and can't
function correctly (due to not having the entire source tree available to it).
- JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py:
(main): Removed an extra '*' in the glob for finding manifest files. The extra '*' was
leftover from before we rearranged WebKitBuild in r75138. Moved code to delete an old file
to the new delete_if_older_than function. Added code to delete any precompiled headers older
than the newest .vsprops file.
(delete_if_older_than): Added. Code came from main.
- 7:57 AM Changeset in webkit [77814] by
-
- 4 edits in trunk
2011-02-07 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Fix LayoutTests/media/restore-from-page-cache.html
https://bugs.webkit.org/show_bug.cgi?id=53621
Unskip media/restore-from-page-cache.html for Qt.
- platform/qt/Skipped:
2011-02-07 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Fix LayoutTests/media/restore-from-page-cache.html
https://bugs.webkit.org/show_bug.cgi?id=53621
Changed the networkState to MediaPlayer::Loaded when
MediaPlayerPrivateQt has enough data.
Test: media/restore-from-page-cache.html
- platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::updateStates):
- 7:56 AM Changeset in webkit [77813] by
-
- 2 edits in trunk/Source/WebKit/haiku
2011-02-07 Patrick Gansterer <Patrick Gansterer>
Reviewed by Andreas Kling.
[Haiku] FrameLoaderClient calls loadURLInChildFrame on the child's frame loader
https://bugs.webkit.org/show_bug.cgi?id=53893
- WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::createFrame): Use m_frame instead of childFrame.
- 7:31 AM Changeset in webkit [77812] by
-
- 2 edits in trunk/LayoutTests
2011-02-07 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed.
Chromium: three tests temporary disabled for rebaseline after r77781
- platform/chromium/test_expectations.txt:
- 7:18 AM Changeset in webkit [77811] by
-
- 2 edits in trunk/Source/WebKit/efl
2011-02-07 Patrick Gansterer <Patrick Gansterer>
Reviewed by Andreas Kling.
[EFL] FrameLoaderClient calls loadURLInChildFrame on the child's frame loader
https://bugs.webkit.org/show_bug.cgi?id=53892
- ewk/ewk_frame.cpp: (ewk_frame_child_add): Use the loader of the core frame instead.
- 7:15 AM Changeset in webkit [77810] by
-
- 12 edits1 add in trunk
2011-02-04 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: implement beautification of scripts inlined in html documents.
https://bugs.webkit.org/show_bug.cgi?id=52706
- http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.setBreakpointInVisibleView):
- inspector/debugger-breakpoints-not-activated-on-reload.html:
- inspector/debugger-pause-on-breakpoint.html:
2011-01-31 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: implement beautification of scripts inlined in html documents.
https://bugs.webkit.org/show_bug.cgi?id=52706
To beautify scripts inlined in html, we need to cut individual scripts, beautify them using UglifyJS library, and
finally paste them back to html.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter): Implement formatting of scripts inlined in html. (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks): (WebInspector.ScriptFormatter.prototype.formatContent): (WebInspector.ScriptFormatter.prototype._splitContentIntoChunks): (WebInspector.ScriptFormatter.prototype._formatChunks.didFormat): (WebInspector.ScriptFormatter.prototype._formatChunks): (WebInspector.ScriptFormatter.prototype._buildContentFromChunks): (WebInspector.ScriptFormatter.prototype._formatScript.messageHandler): (WebInspector.ScriptFormatter.prototype._formatScript):
- inspector/front-end/ScriptFormatterWorker.js: (onmessage): (buildMapping):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrameContent): Use SourceFrameContent and FormattedSourceFrameContent to perform operations with line numbers.
- inspector/front-end/SourceFrameContent.js: Added. (WebInspector.SourceFrameContent): Helper class, holds resource text and scripts layout (WebInspector.SourceFrameContent.prototype.get scriptRanges): (WebInspector.SourceFrameContent.prototype.locationToPosition): (WebInspector.SourceFrameContent.prototype.positionToLocation): (WebInspector.SourceFrameContent.prototype.scriptLocationForLineNumber): (WebInspector.SourceFrameContent.prototype.scriptLocationForRange): (WebInspector.SourceFrameContent.prototype.lineNumberToRange): (WebInspector.SourceFrameContent.prototype._intersectingScriptRange): (WebInspector): (WebInspector.FormattedSourceFrameContent): Helper class, holds original and formatted versions of resource and mapping between them. (WebInspector.FormattedSourceFrameContent.prototype.get text): (WebInspector.FormattedSourceFrameContent.prototype.originalLocationToFormattedLocation): (WebInspector.FormattedSourceFrameContent.prototype.scriptLocationForFormattedLineNumber): (WebInspector.FormattedSourceFrameContent.prototype._convertPosition):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 6:55 AM Changeset in webkit [77809] by
-
- 2 edits in trunk/Source/WebKit/wx
2011-02-07 Patrick Gansterer <Patrick Gansterer>
Reviewed by Andreas Kling.
[wx] FrameLoaderClient calls loadURLInChildFrame on the child's frame loader
https://bugs.webkit.org/show_bug.cgi?id=53895
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::createFrame): Use m_frame instead of childFrame.
- 6:49 AM Changeset in webkit [77808] by
-
- 1 edit41 adds in trunk/LayoutTests
2011-02-07 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed.
Chromium: add explicit "Passed" expectations for the tests which have "failed" expectations in platfrom/mac
The problem was introduced at r77719.
I have to do that because platform/mac is in the list of baseline folders.
See 'Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py'.
- platform/chromium/canvas/philip/tests/2d.drawImage.broken-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.fillStyle.parse.rgb-eof-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.fillStyle.parse.rgba-eof-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.imageData.put.wrongtype-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.line.cap.closed-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.line.join.parallel-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.line.miter.lineedge-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.path.rect.winding-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.pattern.image.broken-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.pattern.image.incomplete.empty-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.pattern.image.incomplete.omitted-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.draw.baseline.bottom-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.draw.baseline.hanging-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.draw.baseline.middle-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.draw.baseline.top-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.end-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.nonspace-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.other-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.space-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.start-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.font.parse.basic-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.font.parse.complex-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.font.parse.invalid-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.font.parse.system-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.measure.width.space-expected.txt: Added.
- 5:21 AM Changeset in webkit [77807] by
-
- 208 edits in trunk/LayoutTests
2011-02-07 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448
Update Snow Leopard SVG pixel test baseline after r77485.
- platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.png:
- platform/mac/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png:
...
- 5:10 AM Changeset in webkit [77806] by
-
- 131 edits in trunk/LayoutTests
2011-02-07 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448
Update Snow Leopard SVG pixel test baseline after r77485.
- platform/mac/svg/custom/js-update-polygon-removal-expected.png:
- platform/mac/svg/custom/js-update-style-expected.png:
...
- 5:05 AM Changeset in webkit [77805] by
-
- 73 edits in trunk/LayoutTests
2011-02-07 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448
Update Snow Leopard SVG pixel test baseline after r77485.
- platform/mac/svg/custom/class-baseValue-expected.png:
- platform/mac/svg/custom/class-selector-expected.png:
...
- 4:59 AM Changeset in webkit [77804] by
-
- 91 edits in trunk/LayoutTests
2011-02-07 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448
Update Snow Leopard SVG pixel test baseline after r77485.
- platform/mac/svg/batik/paints/gradientLimit-expected.png:
- platform/mac/svg/batik/paints/patternRegionA-expected.png:
...
- 3:56 AM Changeset in webkit [77803] by
-
- 2 edits3 adds in trunk/LayoutTests
2011-02-07 Alejandro G. Castro <alex@igalia.com>
Unreviewed, added new results for the slider-thumb-drag-release
test and removed use-infinite-recursion.svg from skipped, required
after r77778.
- platform/gtk/Skipped:
- platform/gtk/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
- platform/gtk/fast/repaint/slider-thumb-drag-release-expected.png: Added.
- platform/gtk/fast/repaint/slider-thumb-drag-release-expected.txt: Added.
- 3:46 AM Changeset in webkit [77802] by
-
- 1 edit3 moves1 add in trunk/Websites/webkit.org
2011-02-07 Alexander Pavlov <apavlov@chromium.org>
Unreviewed. Add Web Inspector warning 10x10 PNG, move files from r77801 into the inspector/ directory.
- blog-files/inspector/css_as_authored.png: Renamed from Websites/webkit.org/blog-files/inspector-css-as-authored.png.
- blog-files/inspector/css_autocomplete.png: Renamed from Websites/webkit.org/blog-files/inspector-css-autocomplete.png.
- blog-files/inspector/css_unknown_properties.png: Renamed from Websites/webkit.org/blog-files/inspector-unknown-css-properties.png.
- blog-files/inspector/warning_10x10.png: Added.
- 3:27 AM Changeset in webkit [77801] by
-
- 1 edit3 adds in trunk/Websites/webkit.org
2011-02-07 Alexander Pavlov <apavlov@chromium.org>
Unreviewed. Add Web Inspector style editing screenshots.
- blog-files/inspector-css-as-authored.png: Added.
- blog-files/inspector-css-autocomplete.png: Added.
- blog-files/inspector-unknown-css-properties.png: Added.
- 3:26 AM Changeset in webkit [77800] by
-
- 7 edits in trunk/Source/WebCore
2011-02-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: "Reveal in elements panel" does not always work.
https://bugs.webkit.org/show_bug.cgi?id=53775
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView):
- inspector/front-end/ContextMenu.js: (WebInspector.ContextMenu.prototype.show):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.switchToAndFocus):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement): (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.update): (WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired):
- inspector/front-end/inspector.js: (WebInspector.cancelSearch):
- 3:24 AM Changeset in webkit [77799] by
-
- 5 edits in trunk
2011-02-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Relative .. in URL paths shouldn't skip adjacent / characters
https://bugs.webkit.org/show_bug.cgi?id=53907
Add some more test cases.
- fast/url/path-expected.txt:
- fast/url/script-tests/path.js:
2011-02-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Relative .. in URL paths shouldn't skip adjacent / characters
https://bugs.webkit.org/show_bug.cgi?id=53907
Our new behavior matches Firefox, Chrome, and IE.
- platform/KURL.cpp: (WebCore::copyPathRemovingDots):
- 3:16 AM Changeset in webkit [77798] by
-
- 2 edits in trunk/Tools
Unreviewed.
[Qt][WK2] Buildfix after r77794.
WebKitTestRunner does not block remote resources or complain about them
https://bugs.webkit.org/show_bug.cgi?id=42139
<rdar://problem/8183942>
- WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Add missing includepaths.
- 3:01 AM Changeset in webkit [77797] by
-
- 2 edits in trunk/Tools
Not reviewed.
More bot appeasement.
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 2:47 AM Changeset in webkit [77796] by
-
- 2 edits in trunk/Tools
Not reviewed.
Remove accidental references to directories on my laptop.
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 1:59 AM Changeset in webkit [77795] by
-
- 2 edits in branches/chromium/648/Source/WebCore/inspector/front-end
Merge 76517 - 2011-01-24 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] AppCache view on resources panel is broken.
https://bugs.webkit.org/show_bug.cgi?id=53002
- inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView.prototype._update):
- inspector/front-end/DOMAgent.js: (WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync):
TBR=podivilov@chromium.org
Review URL: http://codereview.chromium.org/6368125
- 1:47 AM Changeset in webkit [77794] by
-
- 8 edits in trunk
2011-02-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Antti Koivisto.
WebKitTestRunner does not block remote resources or complain about them
https://bugs.webkit.org/show_bug.cgi?id=42139
<rdar://problem/8183942>
- Configurations/WebCore.xcconfig: Allow WebKitTestRunner to link WebCore.
- WebCore.exp.in: Export a handful of KURL symbols.
2011-02-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Antti Koivisto.
WebKitTestRunner does not block remote resources or complain about them
https://bugs.webkit.org/show_bug.cgi?id=42139
<rdar://problem/8183942>
- platform/mac-wk2/Skipped: Unskip formerly skipped tests.
2011-02-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Antti Koivisto.
WebKitTestRunner does not block remote resources or complain about them
https://bugs.webkit.org/show_bug.cgi?id=42139
<rdar://problem/8183942>
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::willSendRequestForFrame): Implement the required checks (using KURL, to avoid need to invent a whole URL API).
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Link WebCore directly to get at KURL symbols.
- 1:31 AM Changeset in webkit [77793] by
-
- 4 edits in trunk/Source/WebKit2
2011-02-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Antti Koivisto.
Add WKURLRequestCopyURL API (needed for tests and also generally useful)
https://bugs.webkit.org/show_bug.cgi?id=53909
- Shared/API/c/WKURLRequest.cpp: (WKURLRequestCopyURL):
- Shared/API/c/WKURLRequest.h:
- Shared/WebURLRequest.h: (WebKit::WebURLRequest::url):
- 12:54 AM Changeset in webkit [77792] by
-
- 2 edits in trunk/Source/JavaScriptCore
Not reviewed.
ASSERTS_DISABLED -> ASSERT_DISABLED
- wtf/BloomFilter.h:
Feb 6, 2011:
- 11:20 PM Changeset in webkit [77791] by
-
- 2 edits in trunk/Tools
2011-02-06 Maciej Stachowiak <mjs@apple.com>
Reviewed by Daniel Bates.
Add WebKit2 bot to list of expected builders in Python regression test results.
https://bugs.webkit.org/show_bug.cgi?id=53905
- Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
- 10:49 PM Changeset in webkit [77790] by
-
- 2 edits in trunk/Tools
2011-02-06 Maciej Stachowiak <mjs@apple.com>
Reviewed by Ryosuke Niwa.
Update test expectations for new core builder
https://bugs.webkit.org/show_bug.cgi?id=53904
- Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
- 10:20 PM Changeset in webkit [77789] by
-
- 2 edits in trunk/Tools
2011-02-06 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add WebKit2 test bot to core builders
https://bugs.webkit.org/show_bug.cgi?id=53901
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
- 9:47 PM Changeset in webkit [77788] by
-
- 2 edits in trunk/Tools
2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
Another unreviewed Chromium build fix.
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::pathToLocalResource):
- 9:29 PM Changeset in webkit [77787] by
-
- 4 edits in trunk
2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Chromium build fix.
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::pathToLocalResource):
2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; speculative Qt build fix.
- WebKit2.pro:
- 9:19 PM Changeset in webkit [77786] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; speculative Qt build fix.
- JavaScriptCore.pro:
- 9:01 PM Changeset in webkit [77785] by
-
- 44 edits3 deletes in trunk
2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867
- DumpRenderTree/chromium/ImageDiff.cpp: (Image::craeteFromStdin): Call adoptArrayPtr.
2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867
Removed LOOSE_OWN_ARRAY_PTR and OwnArrayPtr<T>::set. Replaced all calls to OwnArrayPtr::set
and loose instantiation of OwnArrayPtr by calls to operator= and adoptArrayPtr. Also removed
OwnArrayPtrCommon.h since PassOwnArrayPtr.h needs to include OwnArrayPtr.h and there is
no point in putting deleteOwnedArrayPtr into a separate header.
Note: if this patch breaks build, the code is either instiantiating OwnArrayPtr
without calling adoptArrayPtr or calling set on ArrayOwnPtr instead of operator=.
No tests are added since this is a refactoring.
- API/JSStringRefCF.cpp: (JSStringCreateWithCFString): Calls adoptArrayPtr.
- GNUmakefile.am: Removed OwnArrayPtrCommon.h
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
- JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
- runtime/Arguments.cpp: (JSC::Arguments::deleteProperty): Calls adoptArrayPtr.
- runtime/Arguments.h: (JSC::Arguments::copyRegisters): Ditto.
- runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::JSPropertyNameIterator): Ditto.
- runtime/JSVariableObject.h: (JSC::JSVariableObject::setRegisters): Calls operator= instead of set.
- runtime/StructureChain.cpp: (JSC::StructureChain::StructureChain): Ditto.
- wtf/CMakeLists.txt:
- wtf/DateMath.h: (JSC::GregorianDateTime::GregorianDateTime): No longer instnatiates OwnArrayPtr with a null pointer.
- wtf/OwnArrayPtr.h:
- wtf/OwnArrayPtrCommon.h: Removed.
- wtf/PassOwnArrayPtr.h: No longer includes OwnArrayCommon.h (WTF::deleteOwnedArrayPtr): Moved from OwnArrayPtrCommon.h
2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867
- ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Removed.
2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867
- WebHistory.cpp: (WebHistory::orderedLastVisitedDays): Calls adoptArrayPtr.
- WebPreferences.cpp: (WebPreferences::copyWebKitPreferencesToCFPreferences): Ditto.
2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867
- ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Removed.
- bindings/v8/NPV8Object.cpp: (WebCore::createValueListFromVariantArgs): Returns PassOwnArrayPtr<v8::Handle<v8::Value>> instead of v8::Handle<v8::Value>*. (_NPN_Invoke): Calls createValueListFromVariantArgs. (_NPN_InvokeDefault): createValueListFromVariantArgs. (_NPN_Construct): createValueListFromVariantArgs.
- bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call): Calls adoptArrayPtr. (WebCore::ScriptFunctionCall::construct): Ditto. (WebCore::ScriptCallback::call):
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext): Ditto.
- bindings/v8/V8NPObject.cpp: (WebCore::npObjectInvokeImpl): Ditto
- bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::acceptNode): Ditto,
- html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::parseMappedAttribute): Calls newCoordsArray.
- html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute): Calls newLengthArray.
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getAttachedShaders): Calls adoptArraYptr. (WebCore::WebGLRenderingContext::simulateVertexAttrib0): Ditto. (WebCore::WebGLRenderingContext::LRUImageBufferCache::LRUImageBufferCache): Dito.
- platform/Length.cpp: (WebCore::newCoordsArray): Returns PassOwnArrayPtr<Length> instead of Length*. (WebCore::newLengthArray): Returns PassOwnArrayPtr<Length> instead of Length*.
- platform/Length.h: Prototype changes.
- platform/graphics/ANGLEWebKitBridge.cpp: (WebCore::ANGLEWebKitBridge::validateShaderSource): Calls adoptArrayPtr.
- platform/graphics/ca/win/CACFLayerTreeHost.cpp: (WebCore::getDirtyRects): Ditto.
- platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::getNormalizedTextRun): Ditto.
- platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::glyphsToAdvances): Ditto. (WebCore::canRender): Ditto.
- platform/graphics/gpu/Texture.cpp: (WebCore::Texture::updateSubRect): Ditto.
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): Ditto.
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::readbackHardwareToSoftware): Ditto.
- platform/graphics/wince/SharedBitmap.cpp: (WebCore::SharedBitmap::to16bit): Ditto.
- platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::getContextMenuItems): Ditto.
- platform/win/LoggingWin.cpp: (WebCore::initializeWithUserDefault): Ditto.
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::fetchInfo): Ditto.
2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867
- Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp: (WebKit::NetscapePluginModule::getPluginInfo): Calls adoptArrayPtr.
- 8:54 PM Changeset in webkit [77784] by
-
- 2 edits in trunk/Source/WebCore
2011-02-06 Kent Tamura <tkent@chromium.org>
Unreviewed.
- WebCore.xcodeproj/project.pbxproj: Run sort-xcode-project-file.
- 8:08 PM Changeset in webkit [77783] by
-
- 2 edits in trunk/Source/WebKit/wince
2011-02-06 Patrick Gansterer <Patrick Gansterer>
Reviewed by Martin Robinson.
[WINCE] FrameLoaderClient calls loadURLInChildFrame on the child's frame loader
https://bugs.webkit.org/show_bug.cgi?id=53896
- WebView.cpp: (WebView::createFrame): Use coreFrame instead of childFrame.
- 6:20 PM Changeset in webkit [77782] by
-
- 2 edits in trunk/LayoutTests
2011-02-06 MORITA Hajime <morrita@google.com>
Unreviewed, unskip the html5lib test again which fails for another reason. (See Bug 53030)
- platform/qt/Skipped:
- 5:40 PM Changeset in webkit [77781] by
-
- 13 edits in trunk
2011-02-06 Dominic Cooney <dominicc@google.com>
Reviewed by Dimitri Glazkov.
Convert <keygen> option elements to a shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=51379
- html5lib/runner-expected.txt: Two more tests pass.
- platform/mac/fast/html/keygen-expected.txt: Shadow render tree.
- platform/mac/fast/invalid/residual-style-expected.txt:
2011-02-03 Dominic Cooney <dominicc@google.com>
Reviewed by Dimitri Glazkov.
Convert <keygen> option elements to a shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=51379
Covered by existing tests e.g. fast/html/keygen.html,
html5lib/runner.html, etc.
- css/html.css: (form): Cleanup. (keygen, select): Border radii should match so focus ring looks good. (keygen::-webkit-keygen-select): No margin on the shadow element. (select): Hoisting border radius to keygen, select rule.
- dom/SelectElement.cpp: (WebCore::toSelectElement): keygen is no longer a select element.
- html/HTMLKeygenElement.cpp: Implements keygen shadow. (WebCore::KeygenSelectElement::create): (WebCore::KeygenSelectElement::shadowPseudoId): (WebCore::KeygenSelectElement::KeygenSelectElement): (WebCore::HTMLKeygenElement::HTMLKeygenElement): (WebCore::HTMLKeygenElement::parseMappedAttribute): (WebCore::HTMLKeygenElement::appendFormData): (WebCore::HTMLKeygenElement::formControlType): (WebCore::HTMLKeygenElement::reset): (WebCore::HTMLKeygenElement::selectShadow):
- html/HTMLKeygenElement.h: keygen is no longer a select on C++ side. (WebCore::HTMLKeygenElement::canStartSelection): (WebCore::HTMLKeygenElement::isEnumeratable): (WebCore::HTMLKeygenElement::isResettable):
- html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::ownerSelectElement): Only owned by selects.
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): Only 'select' tag name.
- 5:00 PM Changeset in webkit [77780] by
-
- 1 edit5 adds in trunk/Tools
2011-02-06 James Kozianski <koz@chromium.org>
Reviewed by Ojan Vafai.
Add classes for representing test outputs.
https://bugs.webkit.org/show_bug.cgi?id=52136
These classes will make it easier to write scripts that deal with test
outputs such as rebaselining and deduping scripts. The intent is that
eventually we will be have buildbot return TestOutputs for a
particular build which can be compared with TestOutputs derived from a
local LayoutTests directory.
- Scripts/webkitpy/common/net/testoutput.py: Added.
- Scripts/webkitpy/common/net/testoutput_unittest.py: Added.
- Scripts/webkitpy/common/net/testoutputset.py: Added.
- Scripts/webkitpy/common/net/testoutputset_unittest.py: Added.
- Scripts/webkitpy/common/system/zip_mock.py: Added.
- 3:48 PM Changeset in webkit [77779] by
-
- 2 edits in trunk/Source/WebCore
2011-02-06 Benjamin Poulain <ikipou@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix coding style errors in ClipboardQt.h
https://bugs.webkit.org/show_bug.cgi?id=43520
Fix coding style: order of header and indentation.
- platform/qt/ClipboardQt.h: (WebCore::ClipboardQt::create): (WebCore::ClipboardQt::clipboardData): (WebCore::ClipboardQt::invalidateWritableData):
- 2:16 PM Changeset in webkit [77778] by
-
- 1 edit6 deletes in trunk/LayoutTests
2011-02-06 Patrick Gansterer <Patrick Gansterer>
Reviewed by Oliver Hunt.
Remove empty svg test
https://bugs.webkit.org/show_bug.cgi?id=53887
This files are empty. Empty tests are pretty useless.
- platform/chromium-win/svg/custom/use-infinite-recursion-expected.png: Removed.
- platform/mac/svg/custom/use-infinite-recursion-expected.checksum: Removed.
- platform/mac/svg/custom/use-infinite-recursion-expected.png: Removed.
- platform/mac/svg/custom/use-infinite-recursion-expected.txt: Removed.
- platform/qt/svg/custom/use-infinite-recursion-expected.txt: Removed.
- svg/custom/use-infinite-recursion.svg: Removed.
- 12:43 PM Changeset in webkit [77777] by
-
- 8 edits2 adds in trunk/Source
Use bloom filter for descendant selector filtering
https://bugs.webkit.org/show_bug.cgi?id=53880
Reviewed by Maciej Stachowiak.
Source/JavaScriptCore:
Implement a bloom filter with k=2 and 8 bit counting.
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/BloomFilter.h: Added.
(WTF::BloomFilter::maximumCount):
(WTF::BloomFilter::BloomFilter):
(WTF::BloomFilter::mayContain):
(WTF::BloomFilter::add):
(WTF::BloomFilter::remove):
(WTF::BloomFilter::firstSlot):
(WTF::BloomFilter::secondSlot):
(WTF::::add):
(WTF::::remove):
(WTF::::clear):
(WTF::::likelyEmpty):
(WTF::::isClear):
Source/WebCore:
Bloom filter is faster than a hash set in this kind of use.
Shark thinks this speeds up style matching by ~30% on sites
with lots of descendant selectors.
- ForwardingHeaders/wtf/BloomFilter.h: Added.
- css/CSSStyleSelector.cpp:
(WebCore::collectElementIdentifierHashes):
(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):
(WebCore::CSSStyleSelector::fastRejectSelector):
(WebCore::RuleData::collectDescendantSelectorIdentifierHashes):
- css/CSSStyleSelector.h:
- 12:05 PM Changeset in webkit [77776] by
-
- 2 edits in trunk/Source/WebCore
2011-02-06 Maciej Stachowiak <mjs@apple.com>
Reviewed by Antti Koivisto.
media/video-document-types.html sometimes crashes the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=53884
No new tests. Already covered by media/video-document-types.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::userCancelledLoad): Stop the load timer when cancelling the load.
- 10:52 AM Changeset in webkit [77775] by
-
- 15 edits in trunk/Source/WebCore
2011-02-06 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
[WIN] Use WCHAR instead of TCHAR
https://bugs.webkit.org/show_bug.cgi?id=53863
We always use the UNICODE versions of windows functions, so
the usage of TCHAR makes no sense and mixing them is bad style.
- platform/graphics/win/IconWin.cpp: (WebCore::Icon::createIconForFiles):
- platform/graphics/win/QTMovie.cpp:
- platform/graphics/win/QTMovieGWorld.cpp: (QTMovieGWorld::fullscreenWndProc): (QTMovieGWorld::enterFullscreen):
- platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformInit):
- platform/graphics/win/SimpleFontDataCairoWin.cpp:
- platform/graphics/win/SimpleFontDataWin.cpp:
- platform/graphics/wince/SimpleFontDataWinCE.cpp:
- platform/win/BString.cpp:
- platform/win/ClipboardWin.cpp: (WebCore::filesystemPathFromUrlOrTitle): (WebCore::createGlobalHDropContent): (WebCore::createGlobalImageFileDescriptor):
- platform/win/ContextMenuWin.cpp:
- platform/win/CursorWin.cpp: (WebCore::loadSharedCursor):
- platform/win/FileChooserWin.cpp: (WebCore::FileChooser::basenameForWidth):
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenuWin::popupClassName): (WebCore::PopupMenuWin::show):
- platform/win/PopupMenuWin.h:
- 10:44 AM Changeset in webkit [77774] by
-
- 9 edits in trunk/Source/WebCore
2011-02-06 Patrick Gansterer <Patrick Gansterer>
Reviewed by Andreas Kling.
Replace FLT_MAX with std::numeric_limits
https://bugs.webkit.org/show_bug.cgi?id=53861
Also move EFL's userIdleTime from TemporaryLinkStubs into SystemTimeEfl.
- html/NumberInputType.cpp:
- html/parser/HTMLParserIdioms.cpp: (WebCore::parseToDoubleForNumberType):
- platform/brew/SystemTimeBrew.cpp: (WebCore::userIdleTime):
- platform/efl/SystemTimeEfl.cpp: (WebCore::userIdleTime):
- platform/efl/TemporaryLinkStubs.cpp:
- platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setupAnimation):
- platform/win/SystemTimeWin.cpp: (WebCore::userIdleTime):
- platform/wx/SystemTimeWx.cpp: (WebCore::userIdleTime):
- 10:39 AM Notes on Content Security Policies edited by
- (diff)
- 10:38 AM Notes on Content Security Policies created by
- 10:31 AM Changeset in webkit [77773] by
-
- 2 edits in trunk/Source/WebKit/qt
2011-02-06 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Remove unnecessary QRect assignment
https://bugs.webkit.org/show_bug.cgi?id=53873
- Api/qwebframe.cpp: (QWebFramePrivate::renderRelativeCoords):
- 10:18 AM Changeset in webkit [77772] by
-
- 4 edits in trunk
2011-02-06 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Clear page's groupName even when not in DRT
https://bugs.webkit.org/show_bug.cgi?id=53874
Matches behaviour of other ports.
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::closeWindowSoon):
2011-02-06 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Clear page's groupName even when not in DRT
https://bugs.webkit.org/show_bug.cgi?id=53874
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::windowCloseRequested):
- 9:47 AM Changeset in webkit [77771] by
-
- 6 edits in trunk
2011-02-06 Patrick Gansterer <Patrick Gansterer>
Reviewed by Andreas Kling.
[CMake] Add dependencies for Visual Studio projects
https://bugs.webkit.org/show_bug.cgi?id=53773
Add a JavaScriptCore dependecy to WebCore, so CMake can
generate the correct build order for the solution.
- CMakeLists.txt:
2011-02-06 Patrick Gansterer <Patrick Gansterer>
Reviewed by Andreas Kling.
[CMake] Add dependencies for Visual Studio projects
https://bugs.webkit.org/show_bug.cgi?id=53773
Add a WebCore dependecy to WebKit, so CMake can
generate the correct build order for the solution.
Remove JavaScriptCore dependecy, since WebCore already depends on it.
- CMakeLists.txt:
2011-02-06 Patrick Gansterer <Patrick Gansterer>
Reviewed by Andreas Kling.
[CMake] Add dependencies for Visual Studio projects
https://bugs.webkit.org/show_bug.cgi?id=53773
Add a WebKit dependecy to WinCELauncher, so CMake can
generate the correct build order for the solution.
- CMakeListsWinCE.txt:
- 9:14 AM Changeset in webkit [77770] by
-
- 2 edits in trunk/Source/WebCore
2011-02-06 Patrick Gansterer <Patrick Gansterer>
Reviewed by Andreas Kling.
[CMake] Unify ENABLE_SVG sections
https://bugs.webkit.org/show_bug.cgi?id=53778
- CMakeLists.txt:
- 9:08 AM Changeset in webkit [77769] by
-
- 2 edits in trunk/LayoutTests
2011-02-06 Martin Robinson <mrobinson@igalia.com>
Reclassify a failing test and unskip another which should be passing now.
- platform/gtk/Skipped: Update the skipped list.
- 8:22 AM Changeset in webkit [77768] by
-
- 5 edits in trunk/Source/WebCore
2011-02-06 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
Refactor Font::normalizeSpaces() to avoid an extra String copy.
https://bugs.webkit.org/show_bug.cgi?id=53871
Have normalizeSpaces() take UChar*,length arguments instead of a
String, since all call sites were creating temporaries from these
components anyway.
Font::normalizeSpaces() now always makes 1 String copy,
instead of 1 in the best case and 2 in the worst case.
- platform/graphics/Font.cpp: (WebCore::Font::normalizeSpaces):
- platform/graphics/Font.h:
- platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon): (WebCore::Font::floatWidthForSimpleText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForSimpleText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForSimpleText): (WebCore::Font::selectionRectForComplexText):
- svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk):
- 7:19 AM Changeset in webkit [77767] by
-
- 4 edits in trunk/Tools
2011-02-06 Andreas Kling <kling@webkit.org>
Reviewed by Antonio Gomes.
[Qt] MiniBrowser: Clean up handling of titleChanged() signal
https://bugs.webkit.org/show_bug.cgi?id=53869
- MiniBrowser/qt/BrowserView.cpp: (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
- MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
- MiniBrowser/qt/BrowserWindow.h:
- 6:35 AM Changeset in webkit [77766] by
-
- 2 edits in trunk/Source/WebCore
2011-02-06 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
Fix potential buffer overrun in SVGTextRunWalker::walk()
https://bugs.webkit.org/show_bug.cgi?id=53870
A new String was created from a UChar* with a 'length' argument
that could be greater than the number of UChars available.
- svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk):
- 5:23 AM Changeset in webkit [77765] by
-
- 11 edits in trunk/Source/WebKit2
2011-02-06 Benjamin Poulain <ikipou@gmail.com>
Reviewed by Andreas Kling.
[Qt] WebKit does not build on Mac with WebKit 2
https://bugs.webkit.org/show_bug.cgi?id=53380
- Platform/CoreIPC/qt/ConnectionQt.cpp: Use fcntl() to set close on exec so we do not rely on recent kernel. (CoreIPC::Connection::readyReadHandler):
- Platform/qt/SharedMemoryQt.cpp: ditto (WebKit::SharedMemory::create): (WebKit::SharedMemory::createHandle):
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Guard prctl() since it is a Linux specific function. (WebKit::QtWebProcess::setupChildProcess):
- UIProcess/DrawingAreaProxy.h: Differentiate between building on Mac and the Mac port.
- UIProcess/DrawingAreaProxyImpl.cpp: ditto
- UIProcess/WebPageProxy.cpp: ditto (WebKit::WebPageProxy::didReceiveMessage):
- WebProcess/WebPage/DrawingArea.cpp: ditto (WebKit::DrawingArea::create):
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/DrawingAreaImpl.cpp: ditto
- WebProcess/WebPage/WebPage.cpp: ditto (WebKit::WebPage::didReceiveMessage):
- 2:46 AM Changeset in webkit [77764] by
-
- 2 edits in trunk/LayoutTests
2011-02-06 Robert Hogan <robert@webkit.org>
Unreviewed, skip failing test on Qt bot.
[Qt] fast/notifications/notifications-document-close-crash.html fails after r77738
https://bugs.webkit.org/show_bug.cgi?id=53868
- platform/qt/Skipped: Skip fast/notifications/notifications-document-close-crash.html
- 2:35 AM Changeset in webkit [77763] by
-
- 8 edits in trunk
2011-02-06 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
https://bugs.webkit.org/show_bug.cgi?id=42690
<rdar://problem/8213851>
- platform/mac-wk2/Skipped: Unskip tests that now pass, except for the ones that mysteriously fail.
2011-02-06 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
https://bugs.webkit.org/show_bug.cgi?id=42690
<rdar://problem/8213851>
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::willSendRequestForFrame):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::willSendRequestReturnsNull): (WTR::LayoutTestController::setWillSendRequestReturnsNull):
Feb 5, 2011:
- 10:05 PM Changeset in webkit [77762] by
-
- 5 edits in branches/safari-533.20-branch
Versioning.
- 10:05 PM Changeset in webkit [77761] by
-
- 1 copy in tags/Safari-533.20.25
New tag.
- 10:00 PM Changeset in webkit [77760] by
-
- 1 edit in branches/safari-533.20-branch/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp
Build fix.
- 9:24 PM Changeset in webkit [77759] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-05 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
REGRESSION: New drawing area is causing some WebProcess crashes in layout tests
https://bugs.webkit.org/show_bug.cgi?id=53865
<rdar://problem/8963148>
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): Handle the case where this is called repeatedly without exiting accelerated composting mode first. (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Handle the case of being called more than once.
- 9:05 PM Changeset in webkit [77758] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-02-05 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Add baselines for the test added in r77690.
- platform/chromium-mac/media/video-frame-accurate-seek-expected.checksum: Added.
- platform/chromium-mac/media/video-frame-accurate-seek-expected.png: Added.
- 6:58 PM Changeset in webkit [77757] by
-
- 2 edits in trunk/LayoutTests
2011-02-05 Dimitri Glazkov <Dimitri Glazkov>
Remove passing canvas tests from expectations.
- platform/chromium/test_expectations.txt: Removed passing tests.
- 6:44 PM Changeset in webkit [77756] by
-
- 2 edits in trunk/LayoutTests
2011-02-05 Dimitri Glazkov <Dimitri Glazkov>
Remove passing tests whose results match mac/ and mac-leopard.
- platform/chromium/test_expectations.txt: Removed passing tests.
- 6:07 PM Changeset in webkit [77755] by
-
- 8 edits in trunk/Source/WebCore
2011-02-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove unused parameter related to XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=53862
- WebCore.exp.in:
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScript): (WebCore::ScriptController::executeIfJavaScriptURL):
- bindings/ScriptControllerBase.h:
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::evaluate): (WebCore::ScriptController::executeScriptInWorld):
- bindings/js/ScriptController.h:
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
- bindings/v8/ScriptController.h:
- 4:54 PM Changeset in webkit [77754] by
-
- 1 edit125 deletes in trunk/LayoutTests
2011-02-05 Dimitri Glazkov <Dimitri Glazkov>
Remove results for failing SVG tests. I will add the new ones after the
bots tell me which ones aren't matching mac/ or mac-leopard/.
- 3:02 PM Changeset in webkit [77753] by
-
- 2 edits in trunk/Source/WebCore
2011-02-05 Adam Barth <abarth@webkit.org>
Fix Qt build.
- WebCore.pro:
- 2:55 PM Changeset in webkit [77752] by
-
- 20 edits2 deletes in trunk/Source/WebCore
2011-02-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Delete XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=53859
The job of the XSSAuditor is now done by the XSSFilter. In the future,
we might rename XSSFilter to XSSAuditor.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
- bindings/ScriptControllerBase.h:
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluateInWorld):
- bindings/js/ScriptController.h:
- bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluate):
- bindings/v8/ScriptController.h:
- bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
- dom/Document.cpp: (WebCore::Document::implicitOpen): (WebCore::Document::processBaseElement):
- dom/ScriptableDocumentParser.cpp: (WebCore::ScriptableDocumentParser::ScriptableDocumentParser):
- dom/ScriptableDocumentParser.h:
- html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::shouldLoadExternalScriptFromSrc):
- loader/SubframeLoader.cpp: (WebCore::SubframeLoader::requestObject): (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
- page/XSSAuditor.cpp: Removed.
- page/XSSAuditor.h: Removed.
- 2:28 PM Changeset in webkit [77751] by
-
- 18 edits in trunk/Source
2011-02-05 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Need a way to resize and scroll the page at the same time
https://bugs.webkit.org/show_bug.cgi?id=53814
<rdar://problem/8498008>
Export a function needed by WebKit2.
- WebCore.exp.in:
2011-02-05 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Need a way to resize and scroll the page at the same time
https://bugs.webkit.org/show_bug.cgi?id=53814
<rdar://problem/8498008>
Add -[WKView setFrame:andScrollBy:].
- UIProcess/API/mac/WKView.h:
- UIProcess/API/mac/WKView.mm: (-[WKView setFrame:andScrollBy:]): Stash away the scroll offset and call setFrame:.
(-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaInfo::]):
(-[WKView _setDrawingAreaSize:]):
- UIProcess/API/qt/qwkpage.cpp: (QWKPage::setViewportSize): DrawingAreaProxy::setSize now takes a scroll offset.
- UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::setSize): This now takes a scroll offset and stores it in m_scrollOffset.
- UIProcess/DrawingAreaProxy.h:
- UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::sendSetSize): Send along the scroll offset and set it back to zero.
- UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::didSetSize):
- UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::didSetSize):
- UIProcess/win/WebView.cpp: (WebKit::WebView::onSizeEvent): (WebKit::WebView::switchToDrawingAreaTypeIfNecessary): DrawingAreaProxy::setSize now takes a scroll offset.
- WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::setSize): Add a scrollOffset parameter.
- WebProcess/WebPage/DrawingArea.messages.in: Add a scroll offset parameter to the SetSize message.
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setSize): Call WebPage::scrollMainFrameIfNotAtMaxScrollPosition.
- WebProcess/WebPage/DrawingAreaImpl.h:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::scrollMainFrameIfNotAtMaxScrollPosition): Compute a scroll offset and call setScrollPosition on the main frame view.
- 12:34 PM Changeset in webkit [77750] by
-
- 6 edits in trunk/Source/WebCore
2011-02-05 Patrick Gansterer <Patrick Gansterer>
Reviewed by Alexey Proskuryakov.
Use Document::encoding() instead of DocumentWriter::encoding()
https://bugs.webkit.org/show_bug.cgi?id=53398
This change makes the code more readable, when a subresource
inherits the character encoding of the document.
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
- dom/ScriptElement.cpp: (WebCore::ScriptElement::scriptCharset):
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
- loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestPreload):
- platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::encodingFromAcceptCharset):
- 12:30 PM Changeset in webkit [77749] by
-
- 7 edits1 add in trunk/LayoutTests
2011-02-05 Patrick Gansterer <Patrick Gansterer>
Reviewed by Alexey Proskuryakov.
Add addition test for inherited encoding
https://bugs.webkit.org/show_bug.cgi?id=53398
Check if the right encoding is used, after document.charset was set.
- fast/dom/Document/document-charset.html: Added doctype to make it pass in IE9 out of the box.
- fast/encoding/css-charset-default-expected.txt:
- fast/encoding/css-charset-default.xhtml:
- fast/encoding/external-script-charset-expected.txt:
- fast/encoding/external-script-charset-koi-8.js: Added.
- fast/encoding/external-script-charset.js:
- fast/encoding/external-script-charset.xhtml:
- 12:21 PM Changeset in webkit [77748] by
-
- 6 edits1 add in trunk/Source/WebCore
2011-02-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Introduce URLString to represent a canonicalized URL represented by a string
https://bugs.webkit.org/show_bug.cgi?id=53847
Instead of using String all over the codebase to represent a URL,
instead we should have a type to represent a canonicalized URL in the
form of a string. This patch introduces that type.
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- platform/KURL.cpp: (WebCore::KURL::KURL):
- platform/KURL.h: (WebCore::KURL::urlString):
- 10:26 AM Changeset in webkit [77747] by
-
- 2 edits in trunk/LayoutTests
2011-02-05 Martin Robinson <mrobinson@igalia.com>
JSC::Bindings m_rootObject->isValid() assert fails when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=53716
- platform/gtk/Skipped: Skip a test hitting this assertion.
- 9:55 AM Changeset in webkit [77746] by
-
- 4 edits in trunk
2011-02-05 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Style widgets not rendering
https://bugs.webkit.org/show_bug.cgi?id=53849
- platform/qt/Skipped: Unskip plugins/application-plugins-plugins-disabled.html
2011-02-05 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Style widgets not rendering
https://bugs.webkit.org/show_bug.cgi?id=53849
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::hasValidClassId): x-qt-styled-widget is a valid class id too
- 9:19 AM Changeset in webkit [77745] by
-
- 2 edits in trunk/Tools
2011-02-05 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77720.
http://trac.webkit.org/changeset/77720
https://bugs.webkit.org/show_bug.cgi?id=53854
"Broke nrwt on Chromium win." (Requested by dglazkov|away on
#webkit).
- Scripts/webkitpy/common/system/executive.py:
- 5:00 AM Changeset in webkit [77744] by
-
- 168 edits in trunk/LayoutTests
2011-02-04 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448
Update Snow Leopard SVG pixel test baseline after r77485.
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
...
- 4:48 AM Changeset in webkit [77743] by
-
- 3 edits in trunk/LayoutTests
2011-02-05 Eric Seidel <eric@webkit.org>
Unreviewed.
Safari should lowercase schemes in cannonicalized urls to match every other browser
https://bugs.webkit.org/show_bug.cgi?id=53848
Checkin results I forgot to update in my previous commit. All progressions.
- fast/dom/anchor-origin-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
- 3:52 AM Changeset in webkit [77742] by
-
- 6 edits in trunk/Source/WebCore
2011-02-05 Jochen Eisinger <jochen@chromium.org>
Reviewed by Adam Barth.
Add ContentSecurityPolicy object to Document and pass the X-WebKit-CSP header from the MainResourceLoader.
https://bugs.webkit.org/show_bug.cgi?id=53685
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.h: (WebCore::Document::contentSecurityPolicy):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse):
- page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::didReceiveHeader):
- page/ContentSecurityPolicy.h:
- 3:43 AM Changeset in webkit [77741] by
-
- 8 edits in trunk
2011-02-05 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Safari should lowercase schemes in cannonicalized urls to match every other browser
https://bugs.webkit.org/show_bug.cgi?id=53848
Update our results now that we pass more tests.
- fast/url/file-expected.txt:
- fast/url/file-http-base-expected.txt:
- fast/url/path-url-expected.txt:
- fast/url/relative-expected.txt:
- fast/url/scheme-expected.txt:
2011-02-05 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Safari should lowercase schemes in cannonicalized urls to match every other browser
https://bugs.webkit.org/show_bug.cgi?id=53848
We're clearly the odd man out here. See results from every browser at:
https://github.com/abarth/url-spec/blob/master/tests/gurl-results/by-browser.txt
- platform/KURL.cpp:
(WebCore::KURL::parse):
- Just lowercase the scheme when copying.
- 3:23 AM Changeset in webkit [77740] by
-
- 4 edits in trunk/Source/WebCore
Optimize matching of descendant selectors
https://bugs.webkit.org/show_bug.cgi?id=49876
<rdar://problem/8772822>
Reviewed by Dave Hyatt.
During style recalculation, maintain a filter of tags, ids and classes seen in ancestor elements.
Use the filter to quickly reject descendant and child selectors when doing style matching.
This speeds up style recalculations 3-6x on many major web sites.
- css/CSSStyleSelector.cpp:
(WebCore::RuleData::RuleData):
(WebCore::RuleData::descendantSelectorIdentifierHashes):
(WebCore::collectElementIdentifiers):
(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):
(WebCore::CSSStyleSelector::fastRejectSelector):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::RuleData::collectDescendantSelectorIdentifierHashes):
- css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::ParentStackFrame::ParentStackFrame):
- dom/Element.cpp:
(WebCore::StyleSelectorParentPusher::StyleSelectorParentPusher):
(WebCore::StyleSelectorParentPusher::push):
(WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
(WebCore::Element::attach):
(WebCore::Element::recalcStyle):
- 3:12 AM Changeset in webkit [77739] by
-
- 1 edit3 adds in trunk/PerformanceTests
2011-02-05 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add performance tests for URL parsing
https://bugs.webkit.org/show_bug.cgi?id=53845
The final-url-en URL corpus is from:
http://corpus.leeds.ac.uk/internet.html
There are also other language corpuses which we may want to use in the future.
The usage instructions were as follows:
"URL lists and other resources: you can freely use them in your research
provided that you supply a link to this website: http://corpus.leeds.ac.uk/."
Done.
- Parser/simple-url.html: Added. On my machine: Firefox: 255ms TOT WebKit: 378ms Chrome: 286ms Opera: 2830ms (no, that is not a typo)
- Parser/url-parser.html: Added. Firefox: 381ms TOT WebKit: 216ms Chrome: 131ms Opera: 1383ms (again, not a typo)
- Parser/resources/final-url-en: Added.
- 2:37 AM Changeset in webkit [77738] by
-
- 5 edits in trunk/Source/WebCore
2011-02-05 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Refactor: NotificationCenter shouldn't hold its own copy of the ScriptExecutionContext*
when it inherits one from ActiveDOMObject.
https://bugs.webkit.org/show_bug.cgi?id=53815
- bindings/js/JSDesktopNotificationsCustom.cpp: (WebCore::JSNotificationCenter::requestPermission):
- bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::V8NotificationCenter::requestPermissionCallback):
- notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::NotificationCenter): (WebCore::NotificationCenter::checkPermission): (WebCore::NotificationCenter::requestPermission): (WebCore::NotificationCenter::disconnectFrame):
- notifications/NotificationCenter.h: (WebCore::NotificationCenter::createHTMLNotification): (WebCore::NotificationCenter::createNotification):
- 12:02 AM Changeset in webkit [77737] by
-
- 4 edits in trunk/Tools
2011-02-05 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77725.
http://trac.webkit.org/changeset/77725
https://bugs.webkit.org/show_bug.cgi?id=53844
It broke Qt minimal build (Requested by Ossy_ on #webkit).
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome):
- QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
- QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):
Feb 4, 2011:
- 11:38 PM Changeset in webkit [77736] by
-
- 6 edits2 copies in branches/chromium/648
Merge 77705 - 2011-02-04 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819
Tests that navigating back and forward between hash items works.
- fast/history/history-back-forward-within-subframe-hash.html: Added.
- fast/history/history-back-forward-within-subframe-hash-expected.txt: Added.
2011-02-04 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819
Avoids deleting the current HistoryItem while it is still in use.
Ensures that provisional items are committed for same document navigations.
Ensures that error pages are committed on back/forward navigations.
Also removes unneeded sanity checks used for diagnosing the problem.
- loader/HistoryController.cpp:
- loader/HistoryController.h:
2011-02-04 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819
Removes unneeded sanity checks used for diagnosing a memory error.
- src/WebFrameImpl.cpp:
BUG=70315
TBR=creis@webkit.org
Review URL: http://codereview.chromium.org/6250180
- 11:35 PM Changeset in webkit [77735] by
-
- 2 edits in trunk/LayoutTests
2011-02-04 Jer Noble <jer.noble@apple.com>
Adding test to Qt Skipped list.
[Qt] media/video-frame-accurate-seek.html fails
https://bugs.webkit.org/show_bug.cgi?id=53843
- platform/qt/Skipped:
- 10:25 PM Changeset in webkit [77734] by
-
- 2 edits in trunk/Source/WebKit/gtk
2011-02-04 Joone Hur <joone.hur@collabora.co.uk>
Unreviewed, Fix compilation warning.
Constructor initialization list should follow the declaration order.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::FrameLoaderClient): m_hasRepresentation is moved to the last position in the initialization list.
- 10:24 PM Changeset in webkit [77733] by
-
- 20 edits in tags/Safari-534.18
Revert r77588 to work around <rdar://problem/8963096>.
- 10:03 PM Changeset in webkit [77732] by
-
- 5 edits in trunk/Source
Versioning.
- 10:01 PM Changeset in webkit [77731] by
-
- 1 copy in tags/Safari-534.18
New tag.
- 9:17 PM Changeset in webkit [77730] by
-
- 3 edits2 adds in trunk
2011-02-04 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Crash in WebCore::TextEncoding::decode below XSSFilter::init
https://bugs.webkit.org/show_bug.cgi?id=53837
Test that we can successfully execute a JavaScript URL when it isn't
blocked by the filter.
- http/tests/security/xssAuditor/non-block-javascript-url-frame-expected.txt: Added.
- http/tests/security/xssAuditor/non-block-javascript-url-frame.html: Added.
2011-02-04 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Crash in WebCore::TextEncoding::decode below XSSFilter::init
https://bugs.webkit.org/show_bug.cgi?id=53837
Add missing null check.
Test: http/tests/security/xssAuditor/non-block-javascript-url-frame.html
- html/parser/XSSFilter.cpp: (WebCore::XSSFilter::init):
- 8:56 PM Changeset in webkit [77729] by
-
- 2 edits in trunk/Source/WebCore
2011-02-04 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Crashes in ShadowBlur via WebKit2 FindController
https://bugs.webkit.org/show_bug.cgi?id=53830
Fix a crash cause by re-entering ShadowBlur, and add assertions to
detect when it happens.
The re-entrancy occurred when drawRectShadowWithTiling() filled
the interior of the shadow with fillRect() on the context
which still had the shadow state set. This would make another ShadowBlur
on the stack and call into the code again, potentially blowing away
the image buffer.
Fix by turning off shadows in the destination context while we're
drawing the tiled shadow. The non-tiled code path already did this.
Not testable because CSS shadows clip out the inside of the rect
being shadowed, and SVG uses fillPath, even for rects.
- platform/graphics/ShadowBlur.cpp: (WebCore::ScratchBuffer::ScratchBuffer): (WebCore::ScratchBuffer::getScratchBuffer): (WebCore::ScratchBuffer::scheduleScratchBufferPurge): (WebCore::ShadowBlur::ShadowBlur): (WebCore::ShadowBlur::drawRectShadowWithTiling):
- 8:54 PM Changeset in webkit [77728] by
-
- 2 edits in trunk/LayoutTests
2011-02-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Skip a new test that uses EventSender
https://bugs.webkit.org/show_bug.cgi?id=53841
- platform/mac-wk2/Skipped:
- 8:17 PM Changeset in webkit [77727] by
-
- 4 edits in trunk
2011-02-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Adam Barth.
[GTK] plugins/plugin-document-back-forward.html fails
https://bugs.webkit.org/show_bug.cgi?id=53833
- platform/gtk/Skipped: Unskip test which is now passing.
2011-02-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Adam Barth.
[GTK] plugins/plugin-document-back-forward.html fails
https://bugs.webkit.org/show_bug.cgi?id=53833
Add the new "alert on load" functionality for the Unix version of the
test plugin. This functionality was originally introduced in r77706.
- DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): Add new plugin fuctionality.
- 7:37 PM Changeset in webkit [77726] by
-
- 17 edits in trunk
2011-02-04 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
Update expected results reflecting the change to search icon rendering.
- platform/gtk/fast/css/input-search-padding-expected.checksum:
- platform/gtk/fast/css/input-search-padding-expected.png:
- platform/gtk/fast/css/input-search-padding-expected.txt:
- platform/gtk/fast/forms/search-styled-expected.checksum:
- platform/gtk/fast/forms/search-styled-expected.png:
- platform/gtk/fast/forms/search-styled-expected.txt:
- platform/gtk/fast/forms/search-vertical-alignment-expected.checksum:
- platform/gtk/fast/forms/search-vertical-alignment-expected.png:
- platform/gtk/fast/forms/search-zoomed-expected.checksum:
- platform/gtk/fast/forms/search-zoomed-expected.png:
- platform/gtk/fast/forms/search-zoomed-expected.txt:
- platform/gtk/fast/forms/searchfield-heights-expected.checksum:
- platform/gtk/fast/forms/searchfield-heights-expected.png:
- platform/gtk/fast/forms/searchfield-heights-expected.txt:
2011-02-04 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Don't use a fixed size for search field icons
https://bugs.webkit.org/show_bug.cgi?id=50624
Use the parent input content box to make sure the icon fits in the
search field, scaling it down when needed.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::paintGdkPixbuf): (WebCore::getIconSizeForPixelSize): (WebCore::adjustSearchFieldIconStyle): (WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationStyle): (WebCore::centerRectVerticallyInParentInputElement): (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): (WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): (WebCore::RenderThemeGtk::paintCapsLockIndicator): (WebCore::RenderThemeGtk::paintMediaButton):
- 7:11 PM Changeset in webkit [77725] by
-
- 4 edits in trunk/Tools
2011-02-04 Kundu Suchismita <suchi.kundu@nokia.com>
Reviewed by Andreas Kling.
Local Storage settings can be enable/disable from "Develop" menu
https://bugs.webkit.org/show_bug.cgi?id=52296
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): (LauncherWindow::toggleLocalStorage): (LauncherWindow::toggleOfflineStorageDatabase): (LauncherWindow::toggleOfflineWebApplicationCache): (LauncherWindow::setOfflineStorageDefaultQuota):
- QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
- QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):
- 7:05 PM Changeset in webkit [77724] by
-
- 3 edits4 adds in trunk
2011-02-04 Hironori Bono <hbono@chromium.org>
Reviewed by Adam Barth.
[chromium] JPEG corruption
https://bugs.webkit.org/show_bug.cgi?id=53250
This change adds a new script test that we can render a CMYK JPEG with a
color profile correctly, i.e. we can render it without color corruption.
- fast/images/cmyk-jpeg-with-color-profile-expected.txt: Added.
- fast/images/cmyk-jpeg-with-color-profile.html: Added.
- fast/images/resources/cmyk-jpeg.jpg: Added.
- fast/images/script-tests/cmyk-jpeg-with-color-profile.js: Added. (image.onload):
2011-02-04 Hironori Bono <hbono@chromium.org>
Reviewed by Adam Barth.
[chromium] JPEG corruption
https://bugs.webkit.org/show_bug.cgi?id=53250
Same as gray-scale JPEGs, we convert the colors of CMYK JPEGs with color
profiles from CMYK to RGB twice and it causes color corruption. This
change suppresses the color profiles for CMYK JPEGs same as gray-scale
ones.
Test: fast/images/cmyk-jpeg-with-color-profile.html
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode):
- 6:57 PM Changeset in webkit [77723] by
-
- 254 edits15 adds in trunk/LayoutTests
2011-02-04 Martin Robinson <mrobinson@igalia.com>
Update pixel results for the fast/forms directory in preparation for landing
fixes to input type=search icon sizing. Also add some missing results. These
results are out of date because of changes to font hinting some time ago.
- platform/gtk/fast/forms/
- platform/gtk/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
- platform/gtk/fast/forms/input-placeholder-visibility-1-expected.png: Added.
- platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt: Added.
- platform/gtk/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
- platform/gtk/fast/forms/input-placeholder-visibility-2-expected.png: Added.
- platform/gtk/fast/forms/input-placeholder-visibility-2-expected.txt: Added.
- platform/gtk/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
- platform/gtk/fast/forms/input-placeholder-visibility-3-expected.png: Added.
- platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
- platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
- platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
- platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt: Added.
- platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
- platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
- platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt: Added.
- 6:55 PM Changeset in webkit [77722] by
-
- 2 edits in trunk/LayoutTests
2011-02-04 Adam Barth <abarth@webkit.org>
[Windows 7 Release Tests] plugins/plugin-document-back-forward.html failing since introduction in r77706
https://bugs.webkit.org/show_bug.cgi?id=53831
Stop dumping the child frames because that's not needed for this test
and cause extra output on Windows.
- plugins/plugin-document-back-forward.html:
- 6:50 PM Changeset in webkit [77721] by
-
- 2 edits in trunk/LayoutTests
2011-02-04 Adam Barth <abarth@webkit.org>
[GTK] plugins/plugin-document-back-forward.html fails
https://bugs.webkit.org/show_bug.cgi?id=53833
Add plugins/plugin-document-back-forward.html to skipped list while we
investigate the issue.
- platform/gtk/Skipped:
- 6:39 PM Changeset in webkit [77720] by
-
- 2 edits in trunk/Tools
2011-02-04 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
get test-webkitpy running on win32 python
https://bugs.webkit.org/show_bug.cgi?id=53822
The test harness crashes with a WindowsError because it can't find
'svn' when using subprocess.Popen. This gets us past the error
so we can see the failing tests on the Chromium Win Release Tests
bot.
- Scripts/webkitpy/common/system/executive.py:
- 6:37 PM Changeset in webkit [77719] by
-
- 1 edit51 moves3 adds in trunk/LayoutTests
2011-02-04 Matthew Delaney <mdelaney@apple.com>
Reviewed by Dan Bernstein.
Move canvas layout test expectations into more appropriate locations
https://bugs.webkit.org/show_bug.cgi?id=53145
- platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.broken-expected.txt: Removed.
- ...
- platform/mac-snowleopard/canvas/philip/tests/type.prototype-expected.txt: Removed.
- platform/mac/canvas: Added.
- platform/mac/canvas/philip: Added.
- platform/mac/canvas/philip/tests: Added.
- platform/mac/canvas/philip/tests/2d.drawImage.broken-expected.txt: Copied from platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.broken-expected.txt.
- ...
- platform/mac/canvas/philip/tests/type.prototype-expected.txt: Copied from platform/mac-snowleopard/canvas/philip/tests/type.prototype-expected.txt.
- 6:30 PM Changeset in webkit [77718] by
-
- 1 edit1 add in trunk/LayoutTests
[Windows 7 Release Tests] plugins/plugin-document-back-forward.html failing since
introduction in r77706.
https://bugs.webkit.org/show_bug.cgi?id=53831
Unreviewed. Add expected (failing?) results to get the Windows 7 Release Test bots green.
- platform/win/plugins/plugin-document-back-forward-expected.txt: Added.
- 6:26 PM Changeset in webkit [77717] by
-
- 2 edits in trunk/LayoutTests
2011-02-04 Martin Robinson <mrobinson@igalia.com>
Unskip some tests which should now be passing.
- platform/gtk/Skipped: Unskip tests.
- 6:19 PM Changeset in webkit [77716] by
-
- 2 edits in trunk/Source/WebCore
2011-02-04 Xiyuan Xia <xiyuan@chromium.org>
Reviewed by Tony Chang.
[Chromium] Option text in select popup does not align with menulist button text
https://bugs.webkit.org/show_bug.cgi?id=53632
This makes clientPaddingLeft and clientPaddingRight return
the additional m_innerBlock's padding so that the popup item text
aligns with the menulist button text.
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::clientPaddingLeft): (WebCore::RenderMenuList::clientPaddingRight):
- 6:18 PM Changeset in webkit [77715] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION: Horizontal scrollbar thumbs leave artifacts over page content when scrolling vertically
<rdar://problem/8962457>
Reviewed by Sam Weinig and Beth Dakin.
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
Subtract scrollbars from the scroll view rect if overlay scrollers are enabled.
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
Make sure to invalidate both scrollbars if overlay scrollers are enabled.
- 6:11 PM Changeset in webkit [77714] by
-
- 4 edits in trunk
2011-02-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] WebKitWebFrame can return a stale frame name when calling webkit_web_frame_get_name
https://bugs.webkit.org/show_bug.cgi?id=53797
- platform/gtk/Skipped: Unskip a test which is now passing.
2011-02-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] WebKitWebFrame can return a stale frame name when calling webkit_web_frame_get_name
https://bugs.webkit.org/show_bug.cgi?id=53797
When the frame name changes between different calls to webkit_web_frame_get_name
on the same frame, return the new frame name instead of the one valid during the
previous call.
- webkit/webkitwebframe.cpp: (webkit_web_frame_init): Initialize the frame name to 0. (webkit_web_frame_get_name): Check the current frame name first before returning the cached value.
- 6:04 PM Changeset in webkit [77713] by
-
- 2 edits in trunk/Source/WebKit2
WebKit2: Crash when InjectedBundlePageLoaderClient::willSendRequestForFrame returns a null WKURLRequestRef
https://bugs.webkit.org/show_bug.cgi?id=53829
Reviewed by Maciej Stachowiak.
Store the result of m_client.willSendRequestForFrame in a RefPtr, and null check it before
calling resourceRequest() on it.
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::willSendRequestForFrame):
- 5:58 PM Changeset in webkit [77712] by
-
- 7 edits1 add in trunk/LayoutTests
2011-02-04 Martin Robinson <mrobinson@igalia.com>
Rebaseline a few tests after r77665 and add a GTK-specific baseline
after r77690.
- platform/gtk/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
- platform/gtk/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
- platform/gtk/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
- platform/gtk/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
- platform/gtk/fast/ruby/nested-ruby-expected.txt:
- platform/gtk/fast/text/emphasis-avoid-ruby-expected.txt:
- platform/gtk/media/video-frame-accurate-seek-expected.txt: Added.
- 5:45 PM Changeset in webkit [77711] by
-
- 16 edits in trunk/LayoutTests
[Windows 7 Release Tests] 5 ruby tests failing on Windows after r77665
https://bugs.webkit.org/show_bug.cgi?id=53820
Unreviewed. Landing expected results that are probably correct (given that the change in
77665 was to make the default ruby text size smaller by default).
- platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
- platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
- platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
- platform/win/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum:
- platform/win/fast/blockflow/japanese-ruby-horizontal-bt-expected.png:
- platform/win/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
- platform/win/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
- platform/win/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
- platform/win/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
- platform/win/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
- platform/win/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
- platform/win/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
- platform/win/fast/ruby/nested-ruby-expected.checksum:
- platform/win/fast/ruby/nested-ruby-expected.png:
- platform/win/fast/ruby/nested-ruby-expected.txt:
- 5:41 PM Changeset in webkit [77710] by
-
- 8 edits in trunk
2011-02-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] fast/events/pagehide-timeout.html fails
https://bugs.webkit.org/show_bug.cgi?id=53771
- platform/gtk/Skipped: Unskip a test which is now passing.
2011-02-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] fast/events/pagehide-timeout.html fails
https://bugs.webkit.org/show_bug.cgi?id=53771
Add the document browser cache model. This model is optimized for viewing
a series of local files, while the document viewer is optimized for only
viewing one local file. Improve the documentation on the mapping of these
enum values to actual cache settings.
- webkit/webkitglobals.cpp: (webkit_set_cache_model): Add support for the document browser cache model and improve comments in this section better explaining where the magic numbers come from.
- webkit/webkitglobals.h: Added an enum value for the document browser cache model.
2011-02-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] fast/events/pagehide-timeout.html fails
https://bugs.webkit.org/show_bug.cgi?id=53771
Add knowledge of the document browser cache model the DRT. When resetting
WebKit settings to consistent values between tests, default to the document
browser cache model.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Reset the cache model to the document browser cache model between tests.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the document browser cache model.
- 5:33 PM Changeset in webkit [77709] by
-
- 2 edits in trunk/Source/WebKit2
Fix build.
- WebProcess/mac/WebProcessMac.mm:
- 5:32 PM Changeset in webkit [77708] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-04 Anders Carlsson <andersca@apple.com>
Reviewed by Mark Rowe.
Link opened in background tab fails to paint when activated if it completes loading before tab is selected
https://bugs.webkit.org/show_bug.cgi?id=53827
<rdar://problem/8962355>
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::resumePainting): Invalidate the entire page.
- 5:23 PM Changeset in webkit [77707] by
-
- 2 edits in trunk/Source/WebKit2
Fix <rdar://problem/8961227> WebKit2 does not work with symlinked home directories.
Reviewed by Sam Weinig.
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformSetCacheModel):
Don't adopt an autoreleased pointer, this would lead to a crash.
(WebKit::appendSandboxParameterPath):
(WebKit::appendSandboxParameterConfPath):
(WebKit::initializeSandbox):
Clean up the sandbox parameter code and make sure that realpath is called for all parameters.
- 4:50 PM Changeset in webkit [77706] by
-
- 7 edits2 adds in trunk
2011-02-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474
Test that plugin loads when in a plugin document on back-forward.
- plugins/plugin-document-back-forward-expected.txt: Added.
- plugins/plugin-document-back-forward.html: Added.
2011-02-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474
Long ago, PluginDocument always caused the HTMLEmbedElement to create
its widget synchronously during a post-layout task. Recently, however,
some changes to the HistroyController caused layout on back/forward to
become slightly more complicated (and added an extra level of recursion
to layout). This extra level of recursion triggered the "I've recursed
too many times" condition in the post-layout task queue, causing the
FrameView to run the remainder of the tasks asynchronously.
Unfortunately, that broke PluginDocument because it needs its the
HTMLEmbedElement's updateWidget task to run synchronously.
This patch adds a mechanism for "kicking off" the pending post-layout
tasks synchronously (instead of waiting for the timer to fire).
PluginDocument then uses that facility to ensure that the
HTMLEmbedElement's updateWidget task happens.
Test: plugins/plugin-document-back-forward.html
- html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
- page/FrameView.cpp: (WebCore::FrameView::flushAnyPendingPostLayoutTasks):
- page/FrameView.h:
2011-02-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474
Teach the test plugin how to call alert on load.
- DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New):
- 4:48 PM Changeset in webkit [77705] by
-
- 6 edits2 adds in trunk
2011-02-04 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819
Tests that navigating back and forward between hash items works.
- fast/history/history-back-forward-within-subframe-hash.html: Added.
- fast/history/history-back-forward-within-subframe-hash-expected.txt: Added.
2011-02-04 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819
Avoids deleting the current HistoryItem while it is still in use.
Ensures that provisional items are committed for same document navigations.
Ensures that error pages are committed on back/forward navigations.
Also removes unneeded sanity checks used for diagnosing the problem.
- loader/HistoryController.cpp:
- loader/HistoryController.h:
2011-02-04 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819
Removes unneeded sanity checks used for diagnosing a memory error.
- src/WebFrameImpl.cpp:
- 4:38 PM Changeset in webkit [77704] by
-
- 2 edits3 adds in trunk/LayoutTests
2011-02-04 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Add expectations for the test, added in r77690.
- platform/chromium-win/media/video-frame-accurate-seek-expected.checksum: Added.
- platform/chromium-win/media/video-frame-accurate-seek-expected.png: Added.
- platform/chromium-win/media/video-frame-accurate-seek-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 4:30 PM Changeset in webkit [77703] by
-
- 2 edits in trunk/Source/WebKit2
Sandbox violations when visiting a site using HTTP authentication
<rdar://problem/8951079>
Reviewed by Mark Rowe.
- WebProcess/com.apple.WebProcess.sb:
- 4:28 PM Changeset in webkit [77702] by
-
- 6 edits2 adds in trunk
2011-02-04 Carol Szabo <carol.szabo@nokia.com>
Reviewed by David Hyatt.
Code Changes.
CSS 2.1 failure: content-*
https://bugs.webkit.org/show_bug.cgi?id=52126
- fast/css/counters/content-021-expected.txt: Added.
- fast/css/counters/content-021.html: Added. This is a copy of the test with the same name from the official css test suite, adapted for DumpRenderTree.
2011-02-04 Carol Szabo <carol.szabo@nokia.com>
Reviewed by David Hyatt.
Code Changes.
CSS 2.1 failure: content-*
https://bugs.webkit.org/show_bug.cgi?id=52126
Test: fast/css/counters/content-021.html
- rendering/CounterNode.cpp: (showCounterTree): Made parameter const because it is supposed to be so.
- rendering/RenderCounter.cpp: (WebCore::previousInPreOrder): (WebCore::previousSiblingOrParent): (WebCore::parentElement): (WebCore::areRenderersElementsSiblings): (WebCore::nextInPreOrder): Added these local helper functions to help navigate the DOM tree enriched with :before and :after pseudo elements. (WebCore::planCounter): Fixed bug that would create a repeat counter for second and subsequent renderers associated with the same DOM element. (WebCore::findPlaceForCounter): (WebCore::makeCounterNode): Changed to use the new tree navigation functions described above instead of the Renderer Tree navigation functions. (WebCore::RenderCounter::rendererSubtreeAttached): (WebCore::RenderCounter::rendererStyleChanged): Optimized to not bother about counters until the renderers are finally attached. (showRendererTree): (showNodeTree): Debug helper functions used to debug Counter bugs.
- 4:28 PM Changeset in webkit [77701] by
-
- 5 edits in trunk/Source/WebKit2
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=53823
Print layout sometimes seen on screen
<rdar://problem/8948742> REGRESSION (WebKit2) - When I print a page, I visually see it re-layout
<rdar://problem/8899389> REGRESSION(WebKit2): Wrong content can appear when print dialog is up
- UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::setAutodisplay): Removed a branch that didn't do anything useful.
- UIProcess/API/mac/WKPrintingView.h:
- UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _suspendAutodisplay]): (-[WKPrintingView _delayedResumeAutodisplayTimerFired]): (-[WKPrintingView _delayedResumeAutodisplay]): (-[WKPrintingView knowsPageRange:]): (-[WKPrintingView beginDocument]): (-[WKPrintingView endDocument]): When page setup changes, or when going from print preview to actual printing, AppKit calls -endDocument just to begin it again. Delay resuming autodisplay until the next run loop iteration.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::invalidateContentsAndWindow): (WebKit::WebChromeClient::invalidateContentsForSlowScroll): Tightened it up from other side - we should never send pixels to UI process while in printing mode. This is not 100% reliable, because relayout doesn't happen immediately, and we can still have print layout in screen mode - but it helps.
- 4:26 PM Changeset in webkit [77700] by
-
- 1 edit6 deletes in trunk/LayoutTests
2011-02-04 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Removed Chromium-specific baselines that are no longer necessary.
- platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Removed.
- platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Removed.
- platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Removed.
- platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Removed.
- platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Removed.
- platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Removed.
- 4:20 PM Changeset in webkit [77699] by
-
- 5 edits in trunk/Source/JavaScriptCore
2011-02-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Rolled back in r77612 with ASSERT/crash fixed.
https://bugs.webkit.org/show_bug.cgi?id=53759
Don't shrink the heap to 0 unconditionally. Instead, shrink to 1 if
necessary. For now, the heap assumes that it always has at least one
block live.
- runtime/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::reset):
- runtime/Heap.h:
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::shrinkBlocks): (JSC::MarkedSpace::sweep): (JSC::MarkedSpace::reset):
- runtime/MarkedSpace.h: (JSC::MarkedSpace::highWaterMark): (JSC::MarkedSpace::setHighWaterMark):
- 4:18 PM Changeset in webkit [77698] by
-
- 2 edits in trunk/Source/WebCore
Typo fix.
- html/parser/XSSFilter.cpp:
(WebCore::HTMLNames::containsJavaScriptURL):
- 4:17 PM Changeset in webkit [77697] by
-
- 2 edits in trunk/Source/WebCore
Make an infinite loop introduced in r77454 finite.
Reviewed by Anders Carlsson.
- html/parser/XSSFilter.cpp:
(WebCore::HTMLNames::containsJavaScriptURL):
- 4:16 PM Changeset in webkit [77696] by
-
- 5 edits in trunk/LayoutTests
2011-02-04 Dimitri Glazkov <Dimitri Glazkov>
Update Leopard pixel results for fast/box-shadow.
- platform/mac-leopard/fast/box-shadow/basic-shadows-expected.checksum:
- platform/mac-leopard/fast/box-shadow/basic-shadows-expected.png:
- platform/mac-leopard/fast/box-shadow/inset-expected.checksum:
- platform/mac-leopard/fast/box-shadow/inset-expected.png:
- 4:11 PM Changeset in webkit [77695] by
-
- 2 edits in trunk/Source/WebKit2
Fix for <rdar://problem/8961580>.
Work around for <rdar://problem/8957845>.
Reviewed by Mark Rowe.
- WebProcess/com.apple.WebProcess.sb:
- 4:11 PM Changeset in webkit [77694] by
-
- 9 edits in trunk/Source/WebKit2
2011-02-04 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
WebKit2 doesn't hide mouse pointer on keypress
https://bugs.webkit.org/show_bug.cgi?id=53821
rdar://problem/8630895
- UIProcess/PageClient.h: Renamed didNotHandleKeyEvent to doneWithKeyEvent and added a bool wasEventHandled argument.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveEvent): Changed code to call doneWithKeyEvent and call even if event was handled.
- UIProcess/API/mac/PageClientImpl.h: Updated for above change.
- UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::doneWithKeyEvent): Ditto. But also call [NSCursor setHiddenUntilMouseMoves:YES] when a key down event was handled. This matches what -[WebHTMLView keyDown:] does.
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::doneWithKeyEvent): Ditto.
- UIProcess/API/qt/qwkpage_p.h: Ditto.
- UIProcess/win/WebView.cpp: (WebKit::WebView::doneWithKeyEvent): Ditto.
- UIProcess/win/WebView.h: Ditto.
- 3:49 PM Changeset in webkit [77693] by
-
- 5 edits in branches/safari-533.20-branch
Versioning.
- 3:49 PM Changeset in webkit [77692] by
-
- 1 copy in tags/Safari-533.20.24
New tag.
- 3:49 PM Changeset in webkit [77691] by
-
- 2 edits in branches/safari-533.20-branch/WebKit/win
Build fix.
- 3:48 PM Changeset in webkit [77690] by
-
- 5 edits6 adds in trunk
2011-02-04 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
Frame accurate seeking isn't always accurate
https://bugs.webkit.org/show_bug.cgi?id=52697
New pixel test that seeks to specific currentTimes and records the rendered frame.
- media/content/test-25fps.mp4: Added.
- media/content/test-25fps.ogv: Added.
- media/video-frame-accurate-seek-expected.txt: Added.
- media/video-frame-accurate-seek.html: Added.
- platform/mac/media/video-frame-accurate-seek-expected.checksum: Added.
- platform/mac/media/video-frame-accurate-seek-expected.png: Added.
2011-02-04 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
Frame accurate seeking isn't always accurate
https://bugs.webkit.org/show_bug.cgi?id=52697
Test: media/video-frame-accurate-seek.html
Make seeking slightly more accurate by rounding instead of truncating
when converting from seconds-in-float to time/timeScale.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::createQTTime):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::mediaTimeForTimeValue):
- platform/graphics/win/QTMovie.cpp: (QTMovie::setCurrentTime):
- 3:45 PM Changeset in webkit [77689] by
-
- 15 edits2 adds in trunk
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Second IndexedDB events overhaul patch
https://bugs.webkit.org/show_bug.cgi?id=53813
- storage/indexeddb/request-event-propagation-expected.txt: Added.
- storage/indexeddb/request-event-propagation.html: Added.
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Second IndexedDB events overhaul patch
https://bugs.webkit.org/show_bug.cgi?id=53813
If an IDBRequest has a IDBTransaction, it should propogate
events through it. In order to do this, IDBRequest needs to
hold a transaction frontend object rather than a backend one.
Test: storage/indexeddb/request-event-propagation.html
- storage/IDBCursor.cpp: (WebCore::IDBCursor::IDBCursor):
- storage/IDBCursor.h: (WebCore::IDBCursor::create):
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setSetVersionTransaction): (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::deleteObjectStore):
- storage/IDBDatabase.h:
- storage/IDBIndex.cpp: (WebCore::IDBIndex::IDBIndex): (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor): (WebCore::IDBIndex::get): (WebCore::IDBIndex::getKey):
- storage/IDBIndex.h: (WebCore::IDBIndex::create):
- storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::IDBObjectStore): (WebCore::IDBObjectStore::get): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::deleteFunction): (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::deleteIndex): (WebCore::IDBObjectStore::openCursor):
- storage/IDBObjectStore.h: (WebCore::IDBObjectStore::create):
- storage/IDBRequest.cpp: (WebCore::IDBRequest::create): (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::resetReadyState): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent):
- storage/IDBRequest.h:
- storage/IDBTransaction.cpp: (WebCore::IDBTransaction::IDBTransaction): (WebCore::IDBTransaction::objectStore): (WebCore::IDBTransaction::contextDestroyed): (WebCore::IDBTransaction::enqueueEvent):
- storage/IDBTransaction.h:
- storage/IDBTransaction.idl:
- 3:43 PM Changeset in webkit [77688] by
-
- 29 edits1 copy1 add in trunk
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
First step towards event propogation within IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53795
This is the first step towards implementing
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.
The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.
- storage/indexeddb/cursor-index-delete-expected.txt:
- storage/indexeddb/cursor-index-delete.html:
- storage/indexeddb/database-quota-expected.txt:
- storage/indexeddb/database-quota.html:
- storage/indexeddb/duplicates-expected.txt:
- storage/indexeddb/duplicates.html:
- storage/indexeddb/error-causes-abort-by-default-expected.txt: Copied from LayoutTests/storage/indexeddb/cursor-index-delete-expected.txt.
- storage/indexeddb/error-causes-abort-by-default.html: Added.
- storage/indexeddb/index-basics-expected.txt:
- storage/indexeddb/index-basics.html:
- storage/indexeddb/objectstore-autoincrement-expected.txt:
- storage/indexeddb/objectstore-autoincrement.html:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
First step towards event propogation within IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53795
This is the first step towards implementing
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.
The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.
Test: storage/indexeddb/error-causes-abort-by-default.html
- storage/IDBAbortEvent.cpp: (WebCore::IDBAbortEvent::create): (WebCore::IDBAbortEvent::IDBAbortEvent):
- storage/IDBAbortEvent.h:
- storage/IDBCompleteEvent.cpp: (WebCore::IDBCompleteEvent::create): (WebCore::IDBCompleteEvent::IDBCompleteEvent):
- storage/IDBCompleteEvent.h:
- storage/IDBErrorEvent.cpp: (WebCore::IDBErrorEvent::IDBErrorEvent):
- storage/IDBEvent.cpp: (WebCore::IDBEvent::IDBEvent): (WebCore::IDBEvent::dispatch):
- storage/IDBEvent.h:
- storage/IDBRequest.cpp: (WebCore::IDBRequest::dispatchEvent):
- storage/IDBRequest.h:
- storage/IDBSuccessEvent.cpp: (WebCore::IDBSuccessEvent::IDBSuccessEvent):
- storage/IDBTransaction.cpp: (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete):
- storage/IDBTransaction.h: (WebCore::IDBTransaction::backend):
- storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::taskTimerFired):
- 3:36 PM Changeset in webkit [77687] by
-
- 13 edits in trunk/Source
2011-02-04 Daniel Cheng <dcheng@chromium.org>
Reviewed by Dmitry Titov.
Clone WebClipboard to be frame-specific.
https://bugs.webkit.org/show_bug.cgi?id=53727
For drop operations, Chrome currently snapshots the data and copies it
into the renderer process. As we add more supported drag data types, the
copy will become increasingly expensive. Instead, we'd like to snapshot
data in the browser to reduce the amount of data copied and to support
Blob in DataTransferItem. In order to allow this, we associated
WebClipboard with a frame so it can correctly route its IPCs to the
corresponding Chromium host.
No new tests because no new functionality.
- platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::createReadable):
- platform/chromium/ChromiumDataObject.h:
- platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::create):
- platform/chromium/PlatformBridge.h:
- platform/chromium/ReadableDataObject.cpp: (WebCore::ReadableDataObject::create): (WebCore::ReadableDataObject::ReadableDataObject): (WebCore::ReadableDataObject::getData): (WebCore::ReadableDataObject::urlTitle): (WebCore::ReadableDataObject::htmlBaseUrl): (WebCore::ReadableDataObject::filenames): (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
- platform/chromium/ReadableDataObject.h:
2011-02-04 Daniel Cheng <dcheng@chromium.org>
Reviewed by Dmitry Titov.
Clone WebClipboard to be frame-specific.
https://bugs.webkit.org/show_bug.cgi?id=53727
For drop operations, Chrome currently snapshots the data and copies it
into the renderer process. As we add more supported drag data types, the
copy will become increasingly expensive. Instead, we'd like to snapshot
data in the browser to reduce the amount of data copied and to support
Blob in DataTransferItem. In order to allow this, we associated
WebClipboard with a frame so it can correctly route its IPCs to the
corresponding Chromium host.
- public/WebFrameClient.h: (WebKit::WebFrameClient::clipboard):
- src/PlatformBridge.cpp: (WebCore::getClipboard): (WebCore::PlatformBridge::clipboardReadAvailableTypes): (WebCore::PlatformBridge::clipboardReadData): (WebCore::PlatformBridge::clipboardReadFilenames):
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::fromFrame):
- src/WebFrameImpl.h:
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragTargetDragEnterNew):
- 3:34 PM Changeset in webkit [77686] by
-
- 1 edit6 deletes in trunk/LayoutTests
[Chromium] Remove Chromium-specific baselines that we no longer need.
- platform/chromium-mac-leopard/fast/ruby/nested-ruby-expected.checksum: Removed.
- platform/chromium-mac-leopard/fast/ruby/nested-ruby-expected.png: Removed.
- platform/chromium-mac-leopard/fast/ruby/ruby-beforeafter-expected.checksum: Removed.
- platform/chromium-mac-leopard/fast/ruby/ruby-beforeafter-expected.png: Removed.
- platform/chromium-mac-leopard/fast/ruby/ruby-run-break-expected.checksum: Removed.
- platform/chromium-mac-leopard/fast/ruby/ruby-run-break-expected.png: Removed.
- 3:33 PM Changeset in webkit [77685] by
-
- 29 edits2 deletes in trunk
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
- storage/indexeddb/cursor-index-delete-expected.txt:
- storage/indexeddb/cursor-index-delete.html:
- storage/indexeddb/cursor-update-expected.txt:
- storage/indexeddb/cursor-update.html:
- storage/indexeddb/database-quota-expected.txt:
- storage/indexeddb/database-quota.html:
- storage/indexeddb/duplicates-expected.txt:
- storage/indexeddb/duplicates.html:
- storage/indexeddb/error-causes-abort-by-default-expected.txt: Removed.
- storage/indexeddb/error-causes-abort-by-default.html: Removed.
- storage/indexeddb/index-basics-expected.txt:
- storage/indexeddb/index-basics.html:
- storage/indexeddb/objectstore-autoincrement-expected.txt:
- storage/indexeddb/objectstore-autoincrement.html:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
- storage/IDBAbortEvent.cpp: (WebCore::IDBAbortEvent::create): (WebCore::IDBAbortEvent::IDBAbortEvent):
- storage/IDBAbortEvent.h:
- storage/IDBCompleteEvent.cpp: (WebCore::IDBCompleteEvent::create): (WebCore::IDBCompleteEvent::IDBCompleteEvent):
- storage/IDBCompleteEvent.h:
- storage/IDBErrorEvent.cpp: (WebCore::IDBErrorEvent::IDBErrorEvent):
- storage/IDBEvent.cpp: (WebCore::IDBEvent::IDBEvent):
- storage/IDBEvent.h:
- storage/IDBRequest.cpp: (WebCore::IDBRequest::dispatchEvent):
- storage/IDBRequest.h:
- storage/IDBSuccessEvent.cpp: (WebCore::IDBSuccessEvent::IDBSuccessEvent):
- storage/IDBTransaction.cpp: (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete):
- storage/IDBTransaction.h:
- storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::taskTimerFired):
- 3:19 PM Changeset in webkit [77684] by
-
- 2 edits in trunk/LayoutTests
2011-02-04 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Marked test, added in r77680 as failing due to lighttpd.
- platform/chromium/test_expectations.txt: Marked.
- 3:08 PM Changeset in webkit [77683] by
-
- 8 edits6 deletes in trunk/LayoutTests
2011-02-04 Dimitri Glazkov <Dimitri Glazkov>
Update Leopard baselines for fast/blockflow, this time correctly.
- platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
- platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
- platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Removed.
- platform/mac-leopard/fast/blockflow/fieldsets-expected.png:
- platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Removed.
- platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Removed.
- platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Removed.
- platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
- platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
- platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Removed.
- platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
- platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
- platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Removed.
- 2:54 PM Changeset in webkit [77682] by
-
- 2 edits in trunk/LayoutTests
2011-02-04 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Merge in some GPU expectations that got dropped in r77666, get lint to pass.
- platform/chromium/test_expectations.txt:
- 2:49 PM Changeset in webkit [77681] by
-
- 33 edits4 adds in trunk/LayoutTests
2011-02-04 Dimitri Glazkov <Dimitri Glazkov>
Add Leopard-specific pixel results for fast/ruby.
- platform/mac-leopard/fast/ruby/nested-ruby-expected.checksum: Added.
- platform/mac-leopard/fast/ruby/nested-ruby-expected.png: Added.
- platform/mac-leopard/fast/ruby/ruby-beforeafter-expected.checksum: Added.
- platform/mac-leopard/fast/ruby/ruby-beforeafter-expected.png: Added.
- platform/mac-leopard/fast/ruby/ruby-empty-rt-expected.checksum:
- platform/mac-leopard/fast/ruby/ruby-empty-rt-expected.png:
- platform/mac-leopard/fast/ruby/ruby-length-expected.checksum:
- platform/mac-leopard/fast/ruby/ruby-length-expected.png:
- platform/mac-leopard/fast/ruby/ruby-run-break-expected.checksum:
- platform/mac-leopard/fast/ruby/ruby-run-break-expected.png:
- platform/mac-leopard/fast/ruby/ruby-runs-expected.checksum:
- platform/mac-leopard/fast/ruby/ruby-runs-expected.png:
- platform/mac-leopard/fast/ruby/ruby-runs-spans-expected.checksum:
- platform/mac-leopard/fast/ruby/ruby-runs-spans-expected.png:
- platform/mac-leopard/fast/ruby/ruby-simple-expected.checksum:
- platform/mac-leopard/fast/ruby/ruby-simple-expected.png:
- platform/mac-leopard/fast/ruby/ruby-simple-rp-expected.checksum:
- platform/mac-leopard/fast/ruby/ruby-simple-rp-expected.png:
- platform/mac-leopard/fast/ruby/ruby-trailing-expected.checksum:
- platform/mac-leopard/fast/ruby/ruby-trailing-expected.png:
- platform/mac-leopard/fast/ruby/rubyDOM-insert-rt-expected.checksum:
- platform/mac-leopard/fast/ruby/rubyDOM-insert-rt-expected.png:
- platform/mac-leopard/fast/ruby/rubyDOM-insert-text1-expected.checksum:
- platform/mac-leopard/fast/ruby/rubyDOM-insert-text1-expected.png:
- platform/mac-leopard/fast/ruby/rubyDOM-insert-text2-expected.checksum:
- platform/mac-leopard/fast/ruby/rubyDOM-insert-text2-expected.png:
- platform/mac-leopard/fast/ruby/rubyDOM-insert-text3-expected.checksum:
- platform/mac-leopard/fast/ruby/rubyDOM-insert-text3-expected.png:
- platform/mac-leopard/fast/ruby/rubyDOM-remove-rt1-expected.checksum:
- platform/mac-leopard/fast/ruby/rubyDOM-remove-rt1-expected.png:
- platform/mac-leopard/fast/ruby/rubyDOM-remove-rt2-expected.checksum:
- platform/mac-leopard/fast/ruby/rubyDOM-remove-rt2-expected.png:
- platform/mac-leopard/fast/ruby/rubyDOM-remove-text1-expected.checksum:
- platform/mac-leopard/fast/ruby/rubyDOM-remove-text1-expected.png:
- platform/mac-leopard/fast/ruby/rubyDOM-remove-text2-expected.checksum:
- platform/mac-leopard/fast/ruby/rubyDOM-remove-text2-expected.png:
- 2:41 PM Changeset in webkit [77680] by
-
- 3 edits3 adds in trunk
2011-02-04 Martin Galpin <martin@66laps.com>
Reviewed by David Levin.
CORS origin header not set on GET when a preflight request is required.
https://bugs.webkit.org/show_bug.cgi?id=50773
- http/tests/xmlhttprequest/cross-origin-preflight-get-expected.txt: Added.
- http/tests/xmlhttprequest/cross-origin-preflight-get.html: Added.
- http/tests/xmlhttprequest/resources/cross-origin-preflight-get.php: Added.
2011-02-04 Martin Galpin <martin@66laps.com>
Reviewed by David Levin.
CORS origin header not set on GET when a preflight request is required.
https://bugs.webkit.org/show_bug.cgi?id=50773
Test: http/tests/xmlhttprequest/cross-origin-preflight-get.html
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::preflightSuccess): Explicitly set the request origin after a preflight request succeeds.
- 2:38 PM Changeset in webkit [77679] by
-
- 29 edits1 copy1 add in trunk
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
First step towards event propogation within IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53795
This is the first step towards implementing
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.
The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.
- storage/indexeddb/cursor-index-delete-expected.txt:
- storage/indexeddb/cursor-index-delete.html:
- storage/indexeddb/database-quota-expected.txt:
- storage/indexeddb/database-quota.html:
- storage/indexeddb/duplicates-expected.txt:
- storage/indexeddb/duplicates.html:
- storage/indexeddb/error-causes-abort-by-default-expected.txt: Copied from LayoutTests/storage/indexeddb/cursor-index-delete-expected.txt.
- storage/indexeddb/error-causes-abort-by-default.html: Added.
- storage/indexeddb/index-basics-expected.txt:
- storage/indexeddb/index-basics.html:
- storage/indexeddb/objectstore-autoincrement-expected.txt:
- storage/indexeddb/objectstore-autoincrement.html:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
First step towards event propogation within IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53795
This is the first step towards implementing
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.
The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.
Test: storage/indexeddb/error-causes-abort-by-default.html
- storage/IDBAbortEvent.cpp: (WebCore::IDBAbortEvent::create): (WebCore::IDBAbortEvent::IDBAbortEvent):
- storage/IDBAbortEvent.h:
- storage/IDBCompleteEvent.cpp: (WebCore::IDBCompleteEvent::create): (WebCore::IDBCompleteEvent::IDBCompleteEvent):
- storage/IDBCompleteEvent.h:
- storage/IDBErrorEvent.cpp: (WebCore::IDBErrorEvent::IDBErrorEvent):
- storage/IDBEvent.cpp: (WebCore::IDBEvent::IDBEvent): (WebCore::IDBEvent::dispatch):
- storage/IDBEvent.h:
- storage/IDBRequest.cpp: (WebCore::IDBRequest::dispatchEvent):
- storage/IDBRequest.h:
- storage/IDBSuccessEvent.cpp: (WebCore::IDBSuccessEvent::IDBSuccessEvent):
- storage/IDBTransaction.cpp: (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete):
- storage/IDBTransaction.h: (WebCore::IDBTransaction::backend):
- storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::taskTimerFired):
- 2:37 PM Changeset in webkit [77678] by
-
- 3 edits in trunk/Source/WebKit2
2011-02-04 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
WebKit2 clients fail to launch on Windows if client exe is in a different directory from WebKit
https://bugs.webkit.org/show_bug.cgi?id=53810
<rdar://problem/8946085>
If WebKit2WebProcess.exe is in a different directory from the client process, and that
client process uses CreateProcess to launch WebKit2WebProcess, the DLL search path may
end up excluding the directory containing WebKit. To address this, we use SetDllDirectory
to explicitly include the WebKit directory in the DLL search path.
- win/MainWin.cpp: (wWinMain): Use SetDllDirectory and LoadLibrary to load WebKit.dll from WebKit2WebProcess.exe
- win/WebKit2WebProcessCommon.vsprops: Don't link directly to WebKit. Link against shlwapi.
- 2:31 PM Changeset in webkit [77677] by
-
- 2 edits in trunk/WebKitLibraries
2011-02-04 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Bump Windows minimum system requirement to XPSP2
https://bugs.webkit.org/show_bug.cgi?id=53807
- win/tools/vsprops/common.vsprops:
- 2:29 PM Changeset in webkit [77676] by
-
- 104 edits in trunk/LayoutTests
2011-02-04 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Updated Win and Linux baselines after r77665.
- 2:08 PM Changeset in webkit [77675] by
-
- 7 edits in trunk/LayoutTests
2011-02-04 Xiaomei Ji <xji@chromium.org>
Unreviewed.
Rebaseline chromium after r77654.
text-align attribute in <select> is ignored both in button text and drop-down
items.
- platform/chromium-linux/fast/text/international/bidi-menulist-expected.checksum:
- platform/chromium-linux/fast/text/international/bidi-menulist-expected.png:
- platform/chromium-linux/fast/text/international/bidi-menulist-expected.txt:
- platform/chromium-win/fast/text/international/bidi-menulist-expected.checksum:
- platform/chromium-win/fast/text/international/bidi-menulist-expected.png:
- platform/chromium-win/fast/text/international/bidi-menulist-expected.txt:
- 2:05 PM Changeset in webkit [77674] by
-
- 1 edit34 adds in trunk/LayoutTests
2011-02-04 Dimitri Glazkov <Dimitri Glazkov>
Add Leopard-specific pixel results for fast/blockflow.
- platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
- platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
- platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Added.
- platform/mac-leopard/fast/blockflow/block-level-images-expected.checksum: Added.
- platform/mac-leopard/fast/blockflow/block-level-images-expected.png: Added.
- platform/mac-leopard/fast/blockflow/border-vertical-lr-expected.checksum: Added.
- platform/mac-leopard/fast/blockflow/border-vertical-lr-expected.png: Added.
- platform/mac-leopard/fast/blockflow/english-bt-text-expected.checksum: Added.
- platform/mac-leopard/fast/blockflow/english-bt-text-expected.png: Added.
- platform/mac-leopard/fast/blockflow/english-lr-text-expected.checksum: Added.
- platform/mac-leopard/fast/blockflow/english-lr-text-expected.png: Added.
- platform/mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum: Added.
- platform/mac-leopard/fast/blockflow/japanese-lr-selection-expected.png: Added.
- platform/mac-leopard/fast/blockflow/japanese-lr-text-expected.checksum: Added.
- platform/mac-leopard/fast/blockflow/japanese-lr-text-expected.png: Added.
- platform/mac-leopard/fast/blockflow/japanese-rl-selection-expected.checksum: Added.
- platform/mac-leopard/fast/blockflow/japanese-rl-selection-expected.png: Added.
- platform/mac-leopard/fast/blockflow/japanese-rl-text-expected.checksum: Added.
- platform/mac-leopard/fast/blockflow/japanese-rl-text-expected.png: Added.
- platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Added.
- platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
- platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
- platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
- platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
- platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
- platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
- platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
- platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
- platform/mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
- platform/mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
- platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
- platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
- platform/mac-leopard/fast/blockflow/vertical-font-fallback-expected.checksum: Added.
- platform/mac-leopard/fast/blockflow/vertical-font-fallback-expected.png: Added.
- 1:53 PM Changeset in webkit [77673] by
-
- 2 edits6 deletes in trunk/LayoutTests
2011-02-04 Dimitri Glazkov <Dimitri Glazkov>
Remove platform-specific baselines, since we match platform/mac here.
- platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Removed.
- platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.png: Removed.
- platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
- platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Removed.
- platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
- platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- 1:50 PM Changeset in webkit [77672] by
-
- 7 edits2 adds in trunk
Add a test case for encode/decode of FormData/FormDataElement
If the fix made in r77401 is broken, this new test will crash.
Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
Reviewed by Sam Weinig.
Tools:
- TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
- TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
(TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
(TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
form, an return the session state data.
(TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
and restore it into another WKPage.
- TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/win/TestWebKitAPI.vcproj:
- TestWebKitAPI/win/copy-resources.cmd:
Added new files.
Source/WebKit2:
Allow passing a null filter callback to WKPageCopySessionState
- UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation): Check if the filter is null
before calling it.
- 1:50 PM Changeset in webkit [77671] by
-
- 4 edits2 adds in trunk/Tools
Move code to run JavaScript tests into its own files
This will allow other tests to use this mechanism.
Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
world
Reviewed by Sam Weinig.
- TestWebKitAPI/JavaScriptTest.cpp: Added.
- TestWebKitAPI/JavaScriptTest.h: Added.
Moved code here...
- TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/win/TestWebKitAPI.vcproj:
Added the new files.
- 1:48 PM Changeset in webkit [77670] by
-
- 2 edits in trunk/LayoutTests
2011-02-04 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Update mac expectations.
- platform/chromium/test_expectations.txt: Updated.
- 1:43 PM Changeset in webkit [77669] by
-
- 4 edits in trunk
2011-02-04 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Csaba Osztrogonác.
[Qt]REGRESSION(r76951): media/controls-without-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=53674
- platform/qt/Skipped:
2011-02-04 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Csaba Osztrogonác.
[Qt]REGRESSION(r76951): media/controls-without-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=53674
- css/mediaControlsQt.css:
- 1:27 PM Changeset in webkit [77668] by
-
- 2 edits in trunk/LayoutTests
2011-02-04 Mihai Parparita <mihaip@chromium.org>
Unreviewed GTK expectations update.
Unskip fast/history/timed-refresh-in-cached-frame.html, it should pass
with http://trac.webkit.org/changeset/77559.
- platform/gtk/Skipped:
- 1:25 PM Changeset in webkit [77667] by
-
- 8 edits in trunk/Source/WebKit2
WebKit2: DidInitiateLoadForResource needs to know if the resource is being loaded by a committed or provisional frame
https://bugs.webkit.org/show_bug.cgi?id=53794
Reviewed by John Sullivan.
When we navigate from one page to another, there can be multiple subresource requests between when
the new page has started its provisional load and when it has committed the load.
There can be:
- The main resource load of the provisional page
- Synchronous XHR from the unload event of the loaded page.
WebKit clients need to be able to differentiate between these loads.
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didInitiateLoadForResource): Pass whether or not the page is provisionally loading
to the client.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in: Add a new parameter to DidInitiateLoadForResource.
- UIProcess/WebResourceLoadClient.cpp:
(WebKit::WebResourceLoadClient::didInitiateLoadForResource): a new parameter to didInitiateLoadForResource.
- UIProcess/WebResourceLoadClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest): Pass whether or not the page is currently
in a provisional load (checked by seeing if the DocumentLoader matches the FrameLoader's provisionalDocumentLoader)
to the UI Process.
- 1:21 PM Changeset in webkit [77666] by
-
- 7 edits1 delete in trunk
2011-02-04 Dirk Pranke <dpranke@chromium.org>
Reviewed by Mihai Parparita.
merge test expectations for chromium, chromium-gpu. From
now on, we will track GPU-specific expectations with the
"GPU" modifier in the main file, rather than in a separate
file (and non-GPU-specific expectations with the "CPU"
modifier.
- platform/chromium-gpu/test_expectations.txt: Removed.
- platform/chromium/test_expectations.txt:
2011-02-04 Dirk Pranke <dpranke@chromium.org>
Reviewed by Mihai Parparita.
merge test expectations for chromium, chromium-gpu. The
chromium-gpu port will no longer maintain its own
test expectations file.
Also add in a graphics_type() call on the port object to
determine what graphics type to use in the test configuration,
and log the configuration as a config setting.
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
- Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
- 1:18 PM Changeset in webkit [77665] by
-
- 78 edits in trunk
<rdar://problem/8902704> Make ruby text size 50% by default
https://bugs.webkit.org/show_bug.cgi?id=53723
Reviewed by Darin Adler and Dave Hyatt.
Source/WebCore:
- css/html.css:
(ruby > rt): Changed the font-size from 60% to 50%.
LayoutTests:
- fast/text/emphasis-avoid-ruby-expected.checksum:
- fast/text/emphasis-avoid-ruby-expected.png:
- fast/text/emphasis-avoid-ruby-expected.txt:
- platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
- platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
- platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
- platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
- platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.png:
- platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
- platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.png:
- platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum:
- platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.png:
- platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum:
- platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.png:
- platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
- platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
- platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
- platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
- platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
- platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
- platform/mac/fast/ruby/nested-ruby-expected.checksum:
- platform/mac/fast/ruby/nested-ruby-expected.png:
- platform/mac/fast/ruby/nested-ruby-expected.txt:
- platform/mac/fast/ruby/ruby-beforeafter-expected.checksum:
- platform/mac/fast/ruby/ruby-beforeafter-expected.png:
- platform/mac/fast/ruby/ruby-beforeafter-expected.txt:
- platform/mac/fast/ruby/ruby-empty-rt-expected.checksum:
- platform/mac/fast/ruby/ruby-empty-rt-expected.png:
- platform/mac/fast/ruby/ruby-empty-rt-expected.txt:
- platform/mac/fast/ruby/ruby-length-expected.checksum:
- platform/mac/fast/ruby/ruby-length-expected.png:
- platform/mac/fast/ruby/ruby-length-expected.txt:
- platform/mac/fast/ruby/ruby-run-break-expected.checksum:
- platform/mac/fast/ruby/ruby-run-break-expected.png:
- platform/mac/fast/ruby/ruby-run-break-expected.txt:
- platform/mac/fast/ruby/ruby-runs-expected.checksum:
- platform/mac/fast/ruby/ruby-runs-expected.png:
- platform/mac/fast/ruby/ruby-runs-expected.txt:
- platform/mac/fast/ruby/ruby-runs-spans-expected.checksum:
- platform/mac/fast/ruby/ruby-runs-spans-expected.png:
- platform/mac/fast/ruby/ruby-runs-spans-expected.txt:
- platform/mac/fast/ruby/ruby-simple-expected.checksum:
- platform/mac/fast/ruby/ruby-simple-expected.png:
- platform/mac/fast/ruby/ruby-simple-expected.txt:
- platform/mac/fast/ruby/ruby-simple-rp-expected.checksum:
- platform/mac/fast/ruby/ruby-simple-rp-expected.png:
- platform/mac/fast/ruby/ruby-simple-rp-expected.txt:
- platform/mac/fast/ruby/ruby-trailing-expected.checksum:
- platform/mac/fast/ruby/ruby-trailing-expected.png:
- platform/mac/fast/ruby/ruby-trailing-expected.txt:
- platform/mac/fast/ruby/rubyDOM-insert-rt-expected.checksum:
- platform/mac/fast/ruby/rubyDOM-insert-rt-expected.png:
- platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt:
- platform/mac/fast/ruby/rubyDOM-insert-text1-expected.checksum:
- platform/mac/fast/ruby/rubyDOM-insert-text1-expected.png:
- platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt:
- platform/mac/fast/ruby/rubyDOM-insert-text2-expected.checksum:
- platform/mac/fast/ruby/rubyDOM-insert-text2-expected.png:
- platform/mac/fast/ruby/rubyDOM-insert-text2-expected.txt:
- platform/mac/fast/ruby/rubyDOM-insert-text3-expected.checksum:
- platform/mac/fast/ruby/rubyDOM-insert-text3-expected.png:
- platform/mac/fast/ruby/rubyDOM-insert-text3-expected.txt:
- platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.checksum:
- platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.png:
- platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.txt:
- platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.checksum:
- platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.png:
- platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.txt:
- platform/mac/fast/ruby/rubyDOM-remove-text1-expected.checksum:
- platform/mac/fast/ruby/rubyDOM-remove-text1-expected.png:
- platform/mac/fast/ruby/rubyDOM-remove-text1-expected.txt:
- platform/mac/fast/ruby/rubyDOM-remove-text2-expected.checksum:
- platform/mac/fast/ruby/rubyDOM-remove-text2-expected.png:
- platform/mac/fast/ruby/rubyDOM-remove-text2-expected.txt:
- 1:16 PM Changeset in webkit [77664] by
-
- 3 edits4 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=53610
Regression: adjacent sibling selector not working as expected
<rdar://problem/8960033>
Reviewed by Dimitri Glazkov.
Source/WebCore:
https://bugs.webkit.org/show_bug.cgi?id=53574
REGRESSION (r76012): :last-child:after not working as expected
<rdar://problem/8948643>
Test for additional conditions in parent style that prevent sharing.
Tests: fast/selectors/style-sharing-adjacent-selector.html
fast/selectors/style-sharing-last-child.html
- css/CSSStyleSelector.cpp:
(WebCore::parentStylePreventsSharing):
(WebCore::CSSStyleSelector::locateSharedStyle):
LayoutTests:
https://bugs.webkit.org/show_bug.cgi?id=53574
REGRESSION (r76012): :last-child:after not working as expected
<rdar://problem/8948643>
- fast/selectors/style-sharing-adjacent-selector-expected.txt: Added.
- fast/selectors/style-sharing-adjacent-selector.html: Added.
- fast/selectors/style-sharing-last-child-expected.txt: Added.
- fast/selectors/style-sharing-last-child.html: Added.
- 1:11 PM Changeset in webkit [77663] by
-
- 2 edits1 add in trunk/Source/WebCore
2011-02-04 Mark Mentovai <mark@chromium.org>
Reviewed by Dimitri Glazkov.
Chromium GYP build fix.
When various settings were moved to webcore_prerequisites in r66364,
things that should have been direct_dependent_settings were not marked
as such. GYP 'defines', for example, make no sense on a 'none'-type
target such as webcore_prerequisites. It appears that it was intended
for these settings to be pushed to direct dependents, which would make
direct_dependent_settings correct.
Losing the ChromiumWebCoreObjC defines on the Mac, for example, caused
http://crbug.com/71537, which at best causes Mac console log spew, and
at worst may result in Chromium's copy of WebCore using system
definitions of certain Objective-C classes at runtime, or vice-versa.
The build now includes a postbuild step to prevent
http://crbug.com/71537 from regressing again. The build will fail upon
regression.
- WebCore.gyp/WebCore.gyp: Move things in webcore_prerequisites into direct_dependent_settings as needed, add the check_objc_rename postbuild step.
- WebCore.gyp/mac/check_objc_rename.sh: Added.
- 1:09 PM Changeset in webkit [77662] by
-
- 2 edits in trunk/Source/JavaScriptCore
BUILD FIX: REALLY remove the last vestiges of JSVALUE32!
<rdar://problem/8957409> Remove last vestiges of JSVALUE32
<http://webkit.org/b/53779>
- DerivedSources.make: Removed dependency on
JavaScriptCore.JSVALUE32.exp.
- 1:04 PM Changeset in webkit [77661] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-04 Anders Carlsson <andersca@apple.com>
Reviewed by Mark Rowe.
Mac WebKit2 should use the new drawing area
https://bugs.webkit.org/show_bug.cgi?id=53802
<rdar://problem/7881419>
<rdar://problem/7881447>
<rdar://problem/8252632>
<rdar://problem/8479422>
<rdar://problem/8633813>
<rdar://problem/8734512>
<rdar://problem/8787660>
- UIProcess/API/mac/WKView.mm: (useNewDrawingArea): Return true. Eventually this function should be removed, but let's keep it for now so we can go back to the old drawing area if necessary.
- 12:49 PM Changeset in webkit [77660] by
-
- 8 edits2 adds in trunk
2011-02-04 Robert Hogan <robert@webkit.org>
Reviewed by Darin Fisher.
Move chromium iframe shim code to cross-platform file.
https://bugs.webkit.org/show_bug.cgi?id=52594
- platform/qt/Skipped: Unskip plugins/iframe-shims.html
2011-02-04 Robert Hogan <robert@webkit.org>
Reviewed by Darin Fisher.
Move chromium iframe shim code to cross-platform file
https://bugs.webkit.org/show_bug.cgi?id=52594
Move Chromium code for identifying and cutting out
iframe shims from plugins to cross-platform utility file
IFrameShimSupport.cpp.
Amend PluginViewQt to use this code to handle shims correctly.
- WebCore.gypi: Add Chromium support for IFrameShimSupport.cpp
- WebCore.pro: Add Qt support for IFrameShimSupport.cpp
- plugins/IFrameShimSupport.cpp: Added. (WebCore::getObjectStack): (WebCore::iframeIsAbovePlugin): (WebCore::getPluginOcclusions):
- plugins/IFframeShimSupport.h: Added.
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
2011-02-04 Robert Hogan <robert@webkit.org>
Reviewed by Darin Fisher.
Move chromium iframe shim code to cross-platform file
https://bugs.webkit.org/show_bug.cgi?id=52594
- src/WebPluginContainerImpl.cpp: Move code to WebCore/plugin/IFrameShimSupport.cpp
- 12:47 PM Changeset in webkit [77659] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
WebKit2: Crash in WebPageProxy::setPendingAPIRequestURL after web process crashed
https://bugs.webkit.org/show_bug.cgi?id=53799
<rdar://problem/8943956>
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::reload):
- 12:45 PM Changeset in webkit [77658] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-04 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej Stachowiak.
Fix a shared memory leak
https://bugs.webkit.org/show_bug.cgi?id=53800
Move the send right representing the shared memory.
- Platform/mac/SharedMemoryMac.cpp: (WebKit::SharedMemory::Handle::encode):
- 12:38 PM Changeset in webkit [77657] by
-
- 7 edits2 adds in trunk
<rdar://problem/8636239> and https://bugs.webkit.org/show_bug.cgi?id=53785
WebKit2: Pages with dynamically inserted iframes can add extraneous back/forward items.
Reviewed by Anders Carlsson.
Source/WebKit2:
WebCore doesn't gracefully handle the case where the decidePolicyForNavigationAction callback
does not occur synchronously. Let's make it synchronous.
Change WebPageProxy to handle this message reply synchronously:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in: Make the navigation policy action message be synchronous.
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction): Add a 6-argument varient
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Send the message synchronously.
LayoutTests:
- fast/loader/dynamic-iframe-extra-back-forward-item-expected.txt: Added.
- fast/loader/dynamic-iframe-extra-back-forward-item.html: Added.
- 12:35 PM Changeset in webkit [77656] by
-
- 2 edits in trunk/Source/WebKit2
Windows build fix.
Correct prebuild build-stopping rule to allow project only rebuilds.
- win/WebKit2WebProcessPreBuild.cmd:
- 12:33 PM Changeset in webkit [77655] by
-
- 2 edits in trunk/Source/WebKit2
Assertion failure in WebInspectorProxy::platformClose closing main window when inspecting a popup
window, or when running regression tests.
https://bugs.webkit.org/show_bug.cgi?id=53798
<rdar://problem/8814364>
Reviewed by Adam Roben.
Only assert about the state of m_inspectorWindow and m_inspectorView if the inspector is visible.
Also, only call ::DestroyWindow if the HWND is non-null, just to be safe.
- UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformClose):
- 12:30 PM Changeset in webkit [77654] by
-
- 6 edits in trunk/Source
2011-02-04 Xiaomei Ji <xji@chromium.org>
Reviewed by David Levin.
Implement "<option> should implement the dir attribute" for chromium port after r76983.
https://bugs.webkit.org/show_bug.cgi?id=50969
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::selectItemAlignmentFollowsMenuWritingDirection): Override as true.
- src/WebViewImpl.cpp: Remove directionality hint from autofill drop-down setting.
2011-02-04 Xiaomei Ji <xji@chromium.org>
Reviewed by David Levin.
Implement "<option> should implement the dir attribute" for chromium port after r76983.
https://bugs.webkit.org/show_bug.cgi?id=50969
Use manual test Source/WebCore/manual-tests/pop-up-alignment-and-direction.html
added in r76983.
- platform/chromium/PopupMenuChromium.cpp: Remove directionality hint from <select> drop-down setting. (WebCore::PopupListBox::paintRow): Use <option>'s directionality to paint items in drop-down and pass-in bidi override flag when creating text run.
- platform/chromium/PopupMenuChromium.h: Remove directionalityHint from PopupContainerSettings.
- 12:23 PM Changeset in webkit [77653] by
-
- 1 edit10 adds in trunk/LayoutTests
2011-02-04 Dimitri Glazkov <Dimitri Glazkov>
Add platform/mac-leopard baselines for tests added in r77639. The text rendering is
different enough for them to be different from mac-snowleopard.
- platform/mac-leopard/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
- platform/mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png: Added.
- platform/mac-leopard/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
- platform/mac-leopard/fast/forms/input-placeholder-visibility-2-expected.png: Added.
- platform/mac-leopard/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
- platform/mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png: Added.
- platform/mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
- platform/mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
- platform/mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
- platform/mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
- 12:10 PM Changeset in webkit [77652] by
-
- 2 edits in trunk/Source/WebCore
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Build fix from merge mistake.
- storage/IDBTransaction.cpp: (WebCore::IDBTransaction::ensureEventTargetData):
- 11:57 AM Changeset in webkit [77651] by
-
- 2 edits in trunk/Source/WebCore
2011-02-04 Levi Weintraub <leviw@chromium.org>
Reviewed by Darin Adler.
Remove unneeded function declarations in comments in EditorClient.h
https://bugs.webkit.org/show_bug.cgi?id=53745
Removing unused commented out function declarations. No tests since this is just cleanup.
- page/EditorClient.h:
- 11:50 AM Changeset in webkit [77650] by
-
- 8 edits in trunk/Source/WebCore
2011-02-03 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Refactor IDBRequest and IDBTransaction a bit
https://bugs.webkit.org/show_bug.cgi?id=53565
There were a lot of subtle issues with the way IDBTransaction
and IDBRequest used to be written. This cleans a lot of them up
and largely simplifies the logic. Using EventQueue rather than
timers is one example of the simplification.
- bindings/scripts/CodeGeneratorV8.pm:
- dom/EventQueue.cpp: (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::dispatchEvent):
- storage/IDBCursor.cpp: (WebCore::IDBCursor::continueFunction):
- storage/IDBRequest.cpp: (WebCore::IDBRequest::create): (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::resetReadyState): (WebCore::IDBRequest::onError): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent): (WebCore::IDBRequest::enqueueEvent): (WebCore::IDBRequest::eventTargetData): (WebCore::IDBRequest::ensureEventTargetData):
- storage/IDBRequest.h: (WebCore::IDBRequest::dispatchEvent):
- storage/IDBTransaction.cpp: (WebCore::IDBTransaction::create): (WebCore::IDBTransaction::IDBTransaction): (WebCore::IDBTransaction::objectStore): (WebCore::IDBTransaction::abort): (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete): (WebCore::IDBTransaction::onTimeout): (WebCore::IDBTransaction::canSuspend): (WebCore::IDBTransaction::stop): (WebCore::IDBTransaction::enqueueEvent): (WebCore::IDBTransaction::eventTargetData): (WebCore::IDBTransaction::ensureEventTargetData):
- storage/IDBTransaction.h:
- 11:38 AM Changeset in webkit [77649] by
-
- 1 edit7 adds in trunk/LayoutTests
2011-02-04 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Add baselines for tests, added in r77644.
- platform/chromium-linux/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
- platform/chromium-linux/fast/repaint/slider-thumb-drag-release-expected.png: Added.
- platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.png: Added.
- platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
- platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.png: Added.
- platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.txt: Added.
- 11:31 AM Changeset in webkit [77648] by
-
- 2 edits in trunk/LayoutTests
2011-02-04 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Temporarily add tests added in r77639 as failing, because
we can't see the baselines for these tests (they are in platform/mac-snowleopard).
- platform/chromium/test_expectations.txt: Added.
- 11:22 AM Changeset in webkit [77647] by
-
- 27 edits2 deletes in trunk
2011-02-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Remove the timeout event from IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53521
- storage/indexeddb/tutorial.html:
2011-02-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Remove the timeout event from IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53521
Remove timeout and ontimeout from IDBTransaction per the spec.
- WebCore.gypi:
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::transaction):
- storage/IDBDatabase.h: (WebCore::IDBDatabase::transaction):
- storage/IDBDatabase.idl:
- storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::transaction):
- storage/IDBDatabaseBackendImpl.h:
- storage/IDBDatabaseBackendInterface.h:
- storage/IDBTimeoutEvent.cpp: Removed.
- storage/IDBTimeoutEvent.h: Removed.
- storage/IDBTransaction.cpp: (WebCore::IDBTransaction::IDBTransaction): (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete):
- storage/IDBTransaction.h:
- storage/IDBTransaction.idl:
- storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::create): (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
- storage/IDBTransactionBackendImpl.h:
- storage/IDBTransactionCallbacks.h:
2011-02-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Remove the timeout event from IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53521
- public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::transaction):
- public/WebIDBTransactionCallbacks.h:
- src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::transaction):
- src/IDBDatabaseProxy.h:
- src/IDBTransactionCallbacksProxy.cpp:
- src/IDBTransactionCallbacksProxy.h:
- src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::transaction):
- src/WebIDBDatabaseImpl.h:
- src/WebIDBTransactionCallbacksImpl.cpp:
- src/WebIDBTransactionCallbacksImpl.h:
- 11:16 AM Changeset in webkit [77646] by
-
- 2 edits25 adds in trunk/LayoutTests
2011-02-04 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Add baselines for tests, added in r77639.
- platform/chromium-linux/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
- platform/chromium-linux/fast/forms/input-placeholder-visibility-1-expected.png: Added.
- platform/chromium-linux/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
- platform/chromium-linux/fast/forms/input-placeholder-visibility-2-expected.png: Added.
- platform/chromium-linux/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
- platform/chromium-linux/fast/forms/input-placeholder-visibility-3-expected.png: Added.
- platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
- platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
- platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
- platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
- platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
- platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.png: Added.
- platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt: Added.
- platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
- platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.png: Added.
- platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.txt: Added.
- platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
- platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.png: Added.
- platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt: Added.
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 10:47 AM Changeset in webkit [77645] by
-
- 2 edits in trunk/Source/WebCore
AX: Can't set accessibility overridden attributes on web objects
https://bugs.webkit.org/show_bug.cgi?id=53725
Reviewed by Darin Adler.
accessibilitySetOverriddenValue does not work on AX objects from WebCore because
the right method needed to be overridden (accessibilitySupportsOverriddenAttributes).
Unfortunately, there's no way to test this from DRT, since AppKit returns the overridden
attribute only when an AX client asks for it through the AX frameworks.
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilitySupportsOverriddenAttributes]):
- 10:42 AM Changeset in webkit [77644] by
-
- 3 edits4 adds in trunk
2011-02-03 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Kent Tamura.
REGRESSION(r76147): Slider thumb is not repainted when let go outside of the slider track.
https://bugs.webkit.org/show_bug.cgi?id=53691
- fast/repaint/slider-thumb-drag-release.html: Added.
- platform/mac/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
- platform/mac/fast/repaint/slider-thumb-drag-release-expected.png: Added.
- platform/mac/fast/repaint/slider-thumb-drag-release-expected.txt: Added.
2011-02-03 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Kent Tamura.
REGRESSION(r76147): Slider thumb is not repainted when let go outside of the slider track.
https://bugs.webkit.org/show_bug.cgi?id=53691
Test: fast/repaint/slider-thumb-drag-release.html
- html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::stopDragging): Added dirtying the layout bit to ensure
that the thumb is repainted.
- 10:32 AM Changeset in webkit [77643] by
-
- 7 edits2 adds in trunk/Source/WebCore
2011-02-04 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Add "show more" data grid node and waiting message UI components.
https://bugs.webkit.org/show_bug.cgi?id=53763
- "show more" data grid node is used for on-demand population of data grid contents (similar to DOM tree capability for limiting displayed nodes count);
- waiting message is used for informing user about long lasting operations (with a possibility to cancel them).
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/PleaseWaitMessage.js: Added. (WebInspector.PleaseWaitMessage):
- inspector/front-end/ShowMoreDataGridNode.js: Added. (WebInspector.ShowMoreDataGridNode):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css: (.data-grid button): (.please-wait-msg):
- inspector/front-end/inspector.html:
- 10:32 AM Changeset in webkit [77642] by
-
- 16 edits in trunk/LayoutTests
2011-02-04 Dimitri Glazkov <Dimitri Glazkov>
Update mac baselines. They pixel-rotted.
- platform/mac-leopard/fast/backgrounds/background-clip-text-expected.png:
- platform/mac-leopard/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.png:
- platform/mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
- platform/mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- platform/mac-leopard/fast/backgrounds/size/backgroundSize15-expected.png:
- platform/mac-leopard/fast/backgrounds/size/backgroundSize22-expected.checksum:
- platform/mac-leopard/fast/backgrounds/size/backgroundSize22-expected.png:
- platform/mac/fast/backgrounds/animated-svg-as-background-expected.checksum:
- platform/mac/fast/backgrounds/animated-svg-as-background-expected.png:
- platform/mac/fast/backgrounds/animated-svg-as-mask-expected.checksum:
- platform/mac/fast/backgrounds/animated-svg-as-mask-expected.png:
- platform/mac/fast/backgrounds/size/contain-and-cover-expected.checksum:
- platform/mac/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/mac/fast/backgrounds/svg-as-background-4-expected.checksum:
- platform/mac/fast/backgrounds/svg-as-background-4-expected.png:
- 10:27 AM Changeset in webkit [77641] by
-
- 2 edits in trunk/Tools
2011-02-04 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
https://bugs.webkit.org/show_bug.cgi?id=53781
- Scripts/check-inspector-strings:
- 10:25 AM Changeset in webkit [77640] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-04 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Go out of accelerated compositing mode when the drawing area is destroyed
https://bugs.webkit.org/show_bug.cgi?id=53788
This fixes a crash in the UI process if a web process crashes while in accelerated compositing mode.
- UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::~DrawingAreaProxyImpl):
- 10:18 AM Changeset in webkit [77639] by
-
- 6 edits36 adds4 deletes in trunk
Fix for https://bugs.webkit.org/show_bug.cgi?id=53740
<rdar://problem/8503629> Allow platforms to specify if the placeholder should be visible when text controls are focused
Reviewed by Dan Bernstein.
Tests:
fast/forms/textarea-placeholder-visibility-1.html
fast/forms/textarea-placeholder-visibility-2.html
fast/forms/input-placeholder-visibility-1.html
fast/forms/input-placeholder-visibility-2.html
fast/forms/input-placeholder-visibility-3.html
- html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
Add a check for shouldShowPlaceholderWhenFocused.
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateValue):
Whenever the value is updated, we should also update placeholder visibility.
- rendering/RenderTheme.h: (WebCore::RenderTheme::shouldShowPlaceholderWhenFocused):
Make the default the same as the existing behavior.
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):
Show placeholder when appropriate.
- 10:13 AM Changeset in webkit [77638] by
-
- 4 edits1 delete in trunk/Source/JavaScriptCore
<rdar://problem/8957409> Remove last vestiges of JSVALUE32
<http://webkit.org/b/53779>
Reviewed by Darin Adler.
Support for JSVALUE32 was originaly removed in r70111.
- Configurations/JavaScriptCore.xcconfig: Changed armv6 to use
JavaScriptCore.JSVALUE32_64.exp and ppc64 to use
JavaScriptCore.JSVALUE64.exp to match Platform.h.
- DerivedSources.make: Removed rule for
JavaScriptCore.JSVALUE32.exp.
- JavaScriptCore.JSVALUE32only.exp: Removed.
- JavaScriptCore.xcodeproj/project.pbxproj: Removed references
to JavaScriptCore.JSVALUE32only.exp.
- 10:02 AM Changeset in webkit [77637] by
-
- 2 edits in trunk/LayoutTests
2011-02-04 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Tweak expectations for passing tests.
- platform/chromium/test_expectations.txt: More tweakage.
- 10:01 AM Changeset in webkit [77636] by
-
- 2 edits in trunk/Tools
Include the crashing function in the link to a crash log on Mac
Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
function that crashed on Mac
Reviewed by David Kilzer.
- Scripts/old-run-webkit-tests:
(crashLocation): Moved all the Windows code inside an if instead of using an early return,
but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
the crash log.
- 9:31 AM Changeset in webkit [77635] by
-
- 2 edits in trunk/Source/JavaScriptCore
Use static_cast and other style cleanup in YarrInterpreter.cpp
<http://webkit.org/b/53772>
Reviewed by John Sullivan.
- yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::InputStream::readChecked): Use
static_cast.
(JSC::Yarr::Interpreter::InputStream::checkInput): Remove
unnecessary else block.
(JSC::Yarr::Interpreter::matchAssertionEOL): Ditto.
(JSC::Yarr::Interpreter::backtrackBackReference): Ditto.
(JSC::Yarr::ByteCompiler::emitDisjunction): Use static_cast.
- 9:20 AM Changeset in webkit [77634] by
-
- 2 edits in trunk/LayoutTests
2011-02-04 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Remove more passing tests.
- platform/chromium/test_expectations.txt: Even more passages removed.
- 9:07 AM Changeset in webkit [77633] by
-
- 2 edits in trunk/Tools
Link to Mac crash logs from results.html
Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
results.html
Reviewed by David Kilzer.
- Scripts/old-run-webkit-tests:
(captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
- 9:05 AM Changeset in webkit [77632] by
-
- 2 edits in trunk/LayoutTests
2011-02-04 Dimitri Glazkov <Dimitri Glazkov>
[Chromium] Removed passing tests.
- platform/chromium/test_expectations.txt: Passages removed.
- 8:38 AM Changeset in webkit [77631] by
-
- 2 edits in trunk/Source/WebCore
2011-02-04 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: evaluate on hover does not work on a breakpoint.
https://bugs.webkit.org/show_bug.cgi?id=53768
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._mouseHover):
- 8:28 AM Changeset in webkit [77630] by
-
- 23 edits2 adds4 deletes in trunk/Source
2011-02-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77625 and r77626.
http://trac.webkit.org/changeset/77625
http://trac.webkit.org/changeset/77626
https://bugs.webkit.org/show_bug.cgi?id=53765
It broke Windows builds (Requested by Ossy_ on #webkit).
- Android.jscbindings.mk:
- CMakeLists.txt:
- ForwardingHeaders/pcre/pcre.h: Added.
- ForwardingHeaders/yarr/Yarr.h: Removed.
- ForwardingHeaders/yarr/YarrInterpreter.h: Removed.
- ForwardingHeaders/yarr/YarrPattern.h: Removed.
- WebCore.gyp/WebCore.gyp:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/copyForwardingHeaders.cmd:
- platform/text/RegularExpression.cpp: (WebCore::RegularExpression::Private::regexp): (WebCore::RegularExpression::Private::compile): (WebCore::RegularExpression::Private::Private): (WebCore::RegularExpression::Private::create): (WebCore::RegularExpression::Private::~Private): (WebCore::RegularExpression::match):
2011-02-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77625 and r77626.
http://trac.webkit.org/changeset/77625
http://trac.webkit.org/changeset/77626
https://bugs.webkit.org/show_bug.cgi?id=53765
It broke Windows builds (Requested by Ossy_ on #webkit).
- JavaScriptCore.exp:
- JavaScriptCore.gyp/JavaScriptCore.gyp:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.xcodeproj/project.pbxproj:
- create_regex_tables:
- runtime/RegExp.cpp:
- wtf/Platform.h:
- yarr/Yarr.h:
- yarr/YarrJIT.cpp:
- yarr/YarrJIT.h:
- yarr/YarrParser.h:
- yarr/YarrPattern.h:
- yarr/YarrSyntaxChecker.h:
- yarr/yarr.pri: Removed.
- 8:24 AM Changeset in webkit [77629] by
-
- 1 edit in branches/chromium/648/Source/WebCore/inspector/front-end/NetworkPanel.js
Merge 77623 - 2011-02-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Network panel filtering is broken.
https://bugs.webkit.org/show_bug.cgi?id=53764
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._sortItems): (WebInspector.NetworkPanel.prototype._sortByTimeline): (WebInspector.NetworkPanel.prototype._filter): (WebInspector.NetworkPanel.prototype._updateOffscreenRows): (WebInspector.NetworkDataGridNode.prototype.isFilteredOut): (WebInspector.NetworkDataGridNode.prototype.get selectable): (WebInspector.NetworkTotalGridNode.prototype.isFilteredOut): (WebInspector.NetworkTotalGridNode.prototype.get selectable):
TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/6286112
- 7:51 AM Changeset in webkit [77628] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows build fix. Unreviewed.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
- 7:21 AM Changeset in webkit [77627] by
-
- 2 edits in trunk/LayoutTests
[Windows 7 Release Tests] transitions/transition-end-event-multiple-04.html flakey
https://bugs.webkit.org/show_bug.cgi?id=53332
Unreviewed, attempt to get the Windows 7 Release bots uniformly green.
- platform/win/Skipped:
- 6:54 AM Changeset in webkit [77626] by
-
- 2 edits in trunk/Source/WebCore
2011-02-04 Peter Varga <pvarga@webkit.org>
Rubber-stamped by Csaba Osztrogonác.
Replace PCRE with Yarr in WebCore
https://bugs.webkit.org/show_bug.cgi?id=53496
Speculative windows build fix.
No new tests needed.
- platform/text/RegularExpression.cpp:
- 6:29 AM Changeset in webkit [77625] by
-
- 23 edits5 adds1 delete in trunk/Source
2011-02-04 Peter Varga <pvarga@webkit.org>
Reviewed by Gavin Barraclough.
Replace PCRE with Yarr in WebCore
https://bugs.webkit.org/show_bug.cgi?id=53496
- JavaScriptCore.exp:
- JavaScriptCore.gyp/JavaScriptCore.gyp:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.xcodeproj/project.pbxproj:
- create_regex_tables:
- runtime/RegExp.cpp:
- wtf/Platform.h:
- yarr/Yarr.h:
- yarr/YarrJIT.cpp:
- yarr/YarrJIT.h:
- yarr/YarrParser.h:
- yarr/YarrPattern.h:
- yarr/YarrSyntaxChecker.h:
- yarr/yarr.pri: Added.
2011-02-04 Peter Varga <pvarga@webkit.org>
Reviewed by Gavin Barraclough.
Replace PCRE with Yarr in WebCore
https://bugs.webkit.org/show_bug.cgi?id=53496
No new tests needed.
- Android.jscbindings.mk:
- CMakeLists.txt:
- ForwardingHeaders/pcre/pcre.h: Removed.
- ForwardingHeaders/yarr/Yarr.h: Added.
- ForwardingHeaders/yarr/YarrInterpreter.h: Added.
- ForwardingHeaders/yarr/YarrPattern.h: Added.
- WebCore.gyp/WebCore.gyp:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/copyForwardingHeaders.cmd:
- platform/text/RegularExpression.cpp: (WebCore::RegularExpression::Private::create): (WebCore::RegularExpression::Private::Private): (WebCore::RegularExpression::Private::compile): (WebCore::RegularExpression::match):
- 6:27 AM Changeset in webkit [77624] by
-
- 1 edit8 adds in trunk/LayoutTests
2011-02-04 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed.
Rebaseline. The problem was introduced at r77601.
- platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
- platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
- platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
- platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.checksum: Added.
- platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png: Added.
- 6:22 AM Changeset in webkit [77623] by
-
- 2 edits in trunk/Source/WebCore
2011-02-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Network panel filtering is broken.
https://bugs.webkit.org/show_bug.cgi?id=53764
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._sortItems): (WebInspector.NetworkPanel.prototype._sortByTimeline): (WebInspector.NetworkPanel.prototype._filter): (WebInspector.NetworkPanel.prototype._updateOffscreenRows): (WebInspector.NetworkDataGridNode.prototype.isFilteredOut): (WebInspector.NetworkDataGridNode.prototype.get selectable): (WebInspector.NetworkTotalGridNode.prototype.isFilteredOut): (WebInspector.NetworkTotalGridNode.prototype.get selectable):
- 5:47 AM Changeset in webkit [77622] by
-
- 1 edit4 adds in trunk/LayoutTests
2011-02-04 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed.
Rebaseline image for fast/box-shadow/shadow-tiling-artifact.html
The problem was introduced at r77601.
- platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.checksum: Added.
- platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.png: Added.
- platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.checksum: Added.
- platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.png: Added.
- 5:32 AM Changeset in webkit [77621] by
-
- 1 edit10 adds in trunk/LayoutTests
2011-02-04 Sergio Villar Senin <svillar@igalia.com>
Unreviewed.
New test expectations.
- platform/gtk/fast/box-shadow/shadow-tiling-artifact-expected.txt: Added.
- platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt: Added.
- platform/gtk/svg/text/font-size-below-point-five-2-expected.txt: Added.
- platform/gtk/svg/text/font-size-below-point-five-expected.txt: Added.
- platform/gtk/svg/text/scaled-font-expected.txt: Added.
- platform/gtk/svg/text/small-fonts-2-expected.txt: Added.
- platform/gtk/svg/text/small-fonts-3-expected.txt: Added.
- platform/gtk/svg/text/small-fonts-expected.txt: Added.
- platform/gtk/svg/text/small-fonts-in-html5-expected.txt: Added.
- 5:25 AM Changeset in webkit [77620] by
-
- 8 edits in trunk
2011-02-04 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: support overriding user agent strings
https://bugs.webkit.org/show_bug.cgi?id=51485
Test: http/tests/inspector/extensions-useragent.html
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::setUserAgentOverride): (WebCore::InspectorController::userAgentOverride):
- inspector/InspectorController.h:
- inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.InspectedWindow.prototype.reload):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onReload):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::userAgent): (WebCore::FrameLoader::applyUserAgent):
2011-02-04 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: support overriding user agent strings
https://bugs.webkit.org/show_bug.cgi?id=51485
- http/tests/inspector/extensions-useragent-expected.txt: Added.
- http/tests/inspector/extensions-useragent.html: Added.
- 5:03 AM Changeset in webkit [77619] by
-
- 5 edits in trunk/Source/JavaScriptCore
2011-02-04 Ilya Tikhonovsky <loislo@chromium.org>
REGRESSION: Snow Leopard Intell Release anumber of failing tests.
- runtime/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::reset):
- runtime/Heap.h:
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::sweep): (JSC::MarkedSpace::reset):
- runtime/MarkedSpace.h:
- 4:40 AM Changeset in webkit [77618] by
-
- 2 edits in trunk/Source/WebCore
2011-02-04 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: scripts panel displays wrong file name after reload.
https://bugs.webkit.org/show_bug.cgi?id=53761
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
- 3:34 AM Changeset in webkit [77617] by
-
- 27 edits in trunk/Source
2011-02-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686
- WebCore.exp.in:
- inspector/CodeGeneratorInspector.pm:
- inspector/InspectorClient.h:
- inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight): (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
- inspector/InspectorFrontendClientLocal.h: ports that provide in-process implementation of the inspector front-end can provide platform-specific settings accessor. (WebCore::InspectorFrontendClientLocal::Settings::Settings): (WebCore::InspectorFrontendClientLocal::Settings::~Settings): (WebCore::InspectorFrontendClientLocal::Settings::inspectorAttachedHeight): (WebCore::InspectorFrontendClientLocal::Settings::storeInspectorAttachedHeight):
- loader/EmptyClients.h:
2011-02-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686
- WebCoreSupport/WebInspectorClientCF.cpp: (populateSetting): (storeSetting): (WebInspectorClient::createFrontendSettings):
2011-02-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorFrontendClient::InspectorFrontendClient):
- WebCoreSupport/InspectorClientGtk.h:
2011-02-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686
- WebCoreSupport/WebInspectorClient.h:
- WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::openInspectorFrontend): (WebInspectorFrontendClient::WebInspectorFrontendClient):
2011-02-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorFrontendClientQt::InspectorFrontendClientQt):
- WebCoreSupport/InspectorClientQt.h:
2011-02-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::openInspectorFrontend): (WebInspectorFrontendClient::WebInspectorFrontendClient):
- WebCoreSupport/WebInspectorClient.h:
2011-02-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp: (WebKit::WebInspectorFrontendClient::WebInspectorFrontendClient):
- 2:32 AM Changeset in webkit [77616] by
-
- 2 edits in trunk/LayoutTests
2011-02-04 Sergio Villar Senin <svillar@igalia.com>
Unreviewed.
Skipping fast/events/pagehide-timeout.html that is failing on GTK
bots. See https://bugs.webkit.org/show_bug.cgi?id=53733
- platform/gtk/Skipped: skip fast/events/pagehide-timeout.html
- 12:49 AM Changeset in webkit [77615] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-02-04 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed.
Roll chromium to 73764.
- DEPS:
- 12:12 AM Changeset in webkit [77614] by
-
- 2 edits in trunk/Source/JavaScriptCore
Try to fix 32bit build.
- runtime/Heap.cpp:
(JSC::Heap::reset): Use an explicit cast to avoid shortening warnings,
since 1.5 is double (64bit), and the result is size_t (32bit).
