Timeline



Feb 22, 2011:

11:49 PM Changeset in webkit [79413] by morrita@google.com
  • 144 edits
    29 adds in trunk/LayoutTests

2011-02-22 MORITA Hajime <morrita@google.com>

Unreviewed, added or updated more Leopard-specific expectations for Chromium.

  • platform/chromium-mac-leopard/css1/text_properties/text_align-expected.checksum:
  • platform/chromium-mac-leopard/css1/text_properties/text_align-expected.png:
  • platform/chromium-mac-leopard/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum:
  • platform/chromium-mac-leopard/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
  • platform/chromium-mac-leopard/css2.1/t1202-counter-03-b-expected.checksum:
  • platform/chromium-mac-leopard/css2.1/t1202-counter-03-b-expected.png:
  • platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.checksum:
  • platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.png:
  • platform/chromium-mac-leopard/css2.1/t1202-counter-04-b-expected.txt: Added.
  • platform/chromium-mac-leopard/css2.1/t1202-counters-03-b-expected.checksum:
  • platform/chromium-mac-leopard/css2.1/t1202-counters-03-b-expected.png:
  • platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.checksum:
  • platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.png:
  • platform/chromium-mac-leopard/css2.1/t1202-counters-04-b-expected.txt: Added.
  • platform/chromium-mac-leopard/css2.1/t1602-c43-center-00-d-ag-expected.checksum: Added.
  • platform/chromium-mac-leopard/css2.1/t1602-c43-center-00-d-ag-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t1602-c546-txt-align-00-b-expected.checksum:
  • platform/chromium-mac-leopard/css2.1/t1602-c546-txt-align-00-b-expected.png: Added.
  • platform/chromium-mac-leopard/editing/deleting/delete-tab-003-expected.txt: Added.
  • platform/chromium-mac-leopard/editing/deleting/delete-ws-fixup-001-expected.txt: Added.
  • platform/chromium-mac-leopard/editing/inserting/insert-tab-003-expected.txt: Added.
  • platform/chromium-mac-leopard/editing/selection/4397952-expected.checksum:
  • platform/chromium-mac-leopard/editing/selection/4397952-expected.png:
  • platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.checksum:
  • platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/caret-rtl-2-left-expected.checksum:
  • platform/chromium-mac-leopard/editing/selection/caret-rtl-2-left-expected.png:
  • platform/chromium-mac-leopard/editing/selection/caret-rtl-expected.checksum:
  • platform/chromium-mac-leopard/editing/selection/caret-rtl-expected.png:
  • platform/chromium-mac-leopard/editing/selection/caret-rtl-right-expected.checksum:
  • platform/chromium-mac-leopard/editing/selection/caret-rtl-right-expected.png:
  • platform/chromium-mac-leopard/editing/selection/extend-selection-bidi-expected.checksum:
  • platform/chromium-mac-leopard/editing/selection/extend-selection-bidi-expected.png:
  • platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.checksum:
  • platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.png: Added.
  • platform/chromium-mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/vertical-font-fallback-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/vertical-font-fallback-expected.png:
  • platform/chromium-mac-leopard/fast/css/beforeSelectorOnCodeElement-expected.checksum:
  • platform/chromium-mac-leopard/fast/css/beforeSelectorOnCodeElement-expected.png:
  • platform/chromium-mac-leopard/fast/css/rtl-ordering-expected.checksum:
  • platform/chromium-mac-leopard/fast/css/rtl-ordering-expected.png:
  • platform/chromium-mac-leopard/fast/css/text-input-with-webkit-border-radius-expected.checksum:
  • platform/chromium-mac-leopard/fast/css/text-input-with-webkit-border-radius-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/text-overflow-ellipsis-bidi-expected.checksum:
  • platform/chromium-mac-leopard/fast/css/text-overflow-ellipsis-bidi-expected.png:
  • platform/chromium-mac-leopard/fast/css/text-security-expected.checksum:
  • platform/chromium-mac-leopard/fast/css/text-security-expected.png:
  • platform/chromium-mac-leopard/fast/forms/basic-selects-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/basic-selects-expected.png:
  • platform/chromium-mac-leopard/fast/forms/basic-selects-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.png:
  • platform/chromium-mac-leopard/fast/forms/file-input-direction-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/forms/input-button-sizes-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/input-button-sizes-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-file-re-render-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/input-file-re-render-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-option-wrap-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/menulist-option-wrap-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/menulist-style-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac-leopard/fast/forms/search-transformed-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/search-transformed-expected.png:
  • platform/chromium-mac-leopard/fast/forms/select-baseline-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/select-baseline-expected.png:
  • platform/chromium-mac-leopard/fast/forms/select-visual-hebrew-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/select-visual-hebrew-expected.png:
  • platform/chromium-mac-leopard/fast/forms/text-style-color-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.checksum:
  • platform/chromium-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/float-avoidance-expected.checksum:
  • platform/chromium-mac-leopard/fast/multicol/float-avoidance-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.checksum:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
  • platform/chromium-mac-leopard/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/width100percent-textarea-expected.checksum:
  • platform/chromium-mac-leopard/fast/replaced/width100percent-textarea-expected.png:
  • platform/chromium-mac-leopard/fast/text/atsui-negative-spacing-features-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/atsui-negative-spacing-features-expected.png:
  • platform/chromium-mac-leopard/fast/text/atsui-spacing-features-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/atsui-spacing-features-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/bidi-embedding-pop-and-push-same-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/bidi-embedding-pop-and-push-same-expected.png:
  • platform/chromium-mac-leopard/fast/text/in-rendered-text-rtl-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/in-rendered-text-rtl-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-L2-run-reordering-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-L2-run-reordering-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-CSS-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-HTML-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-european-terminators-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-european-terminators-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-innertext-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-innertext-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-layout-across-linebreak-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-layout-across-linebreak-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-001-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-001-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-002-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-002-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-003-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-linebreak-003-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-listbox-atsui-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-listbox-atsui-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-listbox-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-listbox-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/chromium-mac-leopard/fast/text/international/bidi-override-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/bidi-override-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/hebrew-vowels-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/hebrew-vowels-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/hindi-spacing-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/rtl-caret-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/rtl-caret-expected.png:
  • platform/chromium-mac-leopard/fast/text/international/rtl-white-space-pre-wrap-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/international/rtl-white-space-pre-wrap-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/justified-selection-at-edge-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/justified-selection-at-edge-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.checksum:
  • platform/chromium-mac-leopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-leopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum:
  • platform/chromium-mac-leopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tbody_align_justify-expected.checksum:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_td_align_justify-expected.checksum:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tfoot_align_justify-expected.checksum:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_th_align_justify-expected.checksum:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_tr_align_justify-expected.png:
  • platform/chromium/test_expectations.txt:
11:13 PM Changeset in webkit [79412] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-02-22 Fabrizio Machado <fabrizio.machado@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Don't fall through case in variantToSetting() if qvariant.type() is Bool
https://bugs.webkit.org/show_bug.cgi?id=54976

Test not needed.

  • WebCoreSupport/InspectorClientQt.cpp:
11:06 PM Changeset in webkit [79411] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-02-22 Jia Pu <jpu@apple.com>

Reviewed by Dan Bernstein.

On Mac OS X, English contractions are marked misspelled with certain user preference setting.
https://bugs.webkit.org/show_bug.cgi?id=54975

manual test: manual-tests/autocorrection/spellcheck-on-contraction-when-autocorrection-is-off.html

Without this patch, we check for contraction only when autocorrection or other type of auto-
substituation is on. And we failed to check for contraction if only spellchecking is turned on.
This patch implements the desired behavior, checking for contraction when either correction/substitution,
or spellchecking, is on.

  • editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  • manual-tests/autocorrection/spellcheck-on-contraction-when-autocorrection-is-off.html: Added.
10:58 PM Changeset in webkit [79410] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

2011-02-22 Charlie Reis <creis@chromium.org>

Reviewed by Darin Fisher.

Remove DatabasePolicy from FrameLoaderTypes
https://bugs.webkit.org/show_bug.cgi?id=54968

The DatabasePolicy enum is no longer needed now that we avoid stopping
loaders on same-document navigations.

Existing test: storage/hash-change-with-xhr.html

  • WebCore.exp.in:
  • loader/DocumentLoader.cpp:
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/FrameLoaderTypes.h:
  • workers/WorkerThread.cpp:
10:54 PM Changeset in webkit [79409] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-02-22 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] QWebView ignores a palette set with QWebView::setPalette()
https://bugs.webkit.org/show_bug.cgi?id=31742

Use custom QWebView palette if the view provides one.
Modified version of a patch made by Fabrizio Machado.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeQt::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeQt::platformActiveSelectionForegroundColor): (WebCore::RenderThemeQt::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeQt::platformFocusRingColor):

2011-02-22 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] QWebView ignores a palette set with QWebView::setPalette()
https://bugs.webkit.org/show_bug.cgi?id=31742

Test case to check that the palette sets on the QWebView is taken
into account.

  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::setPalette_data): (tst_QWebView::setPalette):
10:48 PM Changeset in webkit [79408] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-22 Brian Salomon <bsalomon@google.com>

Reviewed by Kenneth Russell.

Don't disable accelerated canvas when using the skia gpu backend.

No new tests are required.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
10:41 PM Changeset in webkit [79407] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-22 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] <select>s on http://www.ryanair.com render wrong
https://bugs.webkit.org/show_bug.cgi?id=29647

Reducing padding in <select> elements to improve its rendering and introducing a
rendering adjustment specific to QMacStyle.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::setPopupPadding): (WebCore::RenderThemeQt::paintMenuList):
10:38 PM Changeset in webkit [79406] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-22 MORITA Hajime <morrita@google.com>

Unreviewed test_expectations.txt update.

  • platform/chromium/test_expectations.txt:
10:04 PM Changeset in webkit [79405] by morrita@google.com
  • 2 edits
    102 adds in trunk/LayoutTests

2011-02-22 MORITA Hajime <morrita@google.com>

Unreviewed, added Leopard-specific expectations for Chromium.

  • platform/chromium-mac-leopard/css1/box_properties/clear_float-expected.checksum: Added.
  • platform/chromium-mac-leopard/css1/box_properties/clear_float-expected.png: Added.
  • platform/chromium-mac-leopard/css1/box_properties/float_elements_in_series-expected.checksum: Added.
  • platform/chromium-mac-leopard/css1/box_properties/float_elements_in_series-expected.png: Added.
  • platform/chromium-mac-leopard/css1/box_properties/float_on_text_elements-expected.checksum: Added.
  • platform/chromium-mac-leopard/css1/box_properties/float_on_text_elements-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum: Added.
  • platform/chromium-mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Added.
  • platform/chromium-mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Added.
  • platform/chromium-mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
  • platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/font-face-default-font-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/css/font-face-default-font-expected.png: Added.
  • platform/chromium-mac-leopard/fast/dom/52776-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Added.
  • platform/chromium-mac-leopard/fast/dynamic/008-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/dynamic/008-expected.png: Added.
  • platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/events/context-no-deselect-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/basic-buttons-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/basic-buttons-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/button-sizes-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/button-sizes-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png: Added.
  • platform/chromium-mac-leopard/fast/html/keygen-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/html/keygen-expected.png: Added.
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-expected.png: Added.
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-long-image-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-long-image-expected.png: Added.
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-x-expected.png: Added.
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-y-expected.png: Added.
  • platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.png: Added.
  • platform/chromium-mac-leopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/justify-ideograph-simple-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/justify-ideograph-simple-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/justify-ideograph-vertical-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/justify-ideograph-vertical-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/justify-nbsp-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/justify-nbsp-expected.png: Added.
  • platform/chromium-mac-leopard/fonts/sans-serif-expected.checksum: Added.
  • platform/chromium-mac-leopard/fonts/sans-serif-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/animate-path-discrete-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/animate-path-discrete-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-mac-leopard/svg/custom/text-dom-01-f-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/custom/text-dom-01-f-expected.png: Added.
  • platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.checksum: Added.
  • platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug113424-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug113424-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/core/bloomberg-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/core/bloomberg-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/core/misc-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/core/misc-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.png: Added.
10:01 PM Changeset in webkit [79404] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

LLVM Compiler build fix.

  • Scripts/webkit2/messages.py:
  • WebProcess/ApplicationCache/WebApplicationCacheManager.h:
9:54 PM Changeset in webkit [79403] by commit-queue@webkit.org
  • 8 edits in trunk/Tools

2011-02-22 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should dump as text if test path contains "dumpAsText/"
https://bugs.webkit.org/show_bug.cgi?id=54873

  • DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::setShouldDumpAsText): (LayoutTestController::setShouldGeneratePixelResults):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (shouldDumpAsText): (dump): (runTest):
  • DumpRenderTree/mac/DumpRenderTree.mm: (shouldDumpAsText): (runTest):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::isDumpAsTextTest): (WebCore::DumpRenderTree::open):
  • DumpRenderTree/win/DumpRenderTree.cpp: (shouldDumpAsText): (runTest):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump):
9:53 PM Changeset in webkit [79402] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-22 Andreas Kling <kling@webkit.org>

Reviewed by Dan Bernstein.

FontCache: Make cTargetInactiveFontData an int instead of float.
https://bugs.webkit.org/show_bug.cgi?id=54963

  • platform/graphics/FontCache.cpp:
9:51 PM Changeset in webkit [79401] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-22 Anna Cavender <annacc@chromium.org>

Reviewed by Eric Carlson.

Fix for media/video-replaces-poster.html. The test was failing because it assumes the results of a seek will be immediately available, when in fact the seek is asynchronous. I did not remove the line in test-expectations because rebaselines for many (all?) platforms will likely be needed after this patch lands. See also, http://code.google.com/p/chromium/issues/detail?id=60244
https://bugs.webkit.org/show_bug.cgi?id=54910

  • media/video-replaces-poster.html:
9:49 PM Changeset in webkit [79400] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2011-02-22 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; second attempt to land Windows 7 expected failure results for new tests from r79318
http://webkit.org/b/54966 tracks the failure.

  • platform/win/media/audio-repaint-expected.txt:
  • platform/win/media/media-document-audio-repaint-expected.txt:
9:39 PM Changeset in webkit [79399] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-02-21 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] focus first visible node if no node is focused
https://bugs.webkit.org/show_bug.cgi?id=54935

Now hitting j/k/n/p will focus the first/last visible node
if no other node is focused. Also tweaked the scroll into view
logic a bit to avoid scrolling in this case.

  • code-review.js:
9:35 PM Changeset in webkit [79398] by rniwa@webkit.org
  • 10 edits in trunk/Source/WebCore

2011-02-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Make Editor::selectionComputedStyle return EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=54933

Renamed selectionComputedStyle to selectionStartStyle and changed the return type to EditingStyle.
It also no longer takes a boolean shouldUseFixedFontDefaultSize.

Also added EditingStyle::mergeTypingStyle which replaced old editingStyleIncludingTypingStyle. This function
doesn't extract inheritable properties prior to merge because this turned out be a bug, which was revealed
by an existing layout test only after the code was shared with selectionStartStyle.

No tests are added since this is a refactoring.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Calls EditingStyle::create and EditingStyle::mergeTypingStyle. (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto.
  • editing/EditingStyle.cpp: Removed editingStyleIncludingTypingStyle. (WebCore::EditingStyle::mergeTypingStyle): Added.
  • editing/EditingStyle.h: (WebCore::EditingStyle::shouldUseFixedDefaultFontSize): Added.
  • editing/Editor.cpp: (WebCore::Editor::selectionStartHasStyle): Calls selectionStartStyle. (WebCore::Editor::selectionHasStyle): Ditto. (WebCore::Editor::selectionStartCSSPropertyValue): Ditto. (WebCore::Editor::selectionStartStyle): Renamed from selectionComputedStyle; returns EditingStyle.
  • editing/Editor.h:
  • editing/EditorCommand.cpp: (WebCore::executeToggleStyleInList): Calls selectionStartStyle.
  • editing/InsertLineBreakCommand.cpp:
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Calls EditingStyle::create and EditingStyle::mergeTypingStyle.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Ditto.
9:30 PM Changeset in webkit [79397] by robert@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-22 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] painting of windowed plugins faulty on certain scroll events

https://bugs.webkit.org/show_bug.cgi?id=52735

Invalidate the pluginview's relative rect rather then the frameRect(). This is because QWebFrame::renderRelativeCoords()
imitates ScrollView and adds the scroll offset back on to the rect we damage here (making the co-ordinates absolute
to the frame again) before passing it to FrameView.

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget):
9:29 PM Changeset in webkit [79396] by Laszlo Gombos
  • 22 edits
    2 adds in trunk

2011-02-22 Laszlo Gombos <Laszlo Gombos>

Reviewed by Alexey Proskuryakov.

Drop the language tag part from the User Agent string
https://bugs.webkit.org/show_bug.cgi?id=54560

  • http/tests/navigation/useragent-expected.txt: Added.
  • http/tests/navigation/useragent.php: Added.

2011-02-22 Laszlo Gombos <Laszlo Gombos>

Reviewed by Alexey Proskuryakov.

Drop the language tag part from the User Agent string
https://bugs.webkit.org/show_bug.cgi?id=54560

  • StringsNotToBeLocalized.txt: Change the User Agent string template.

2011-02-22 Laszlo Gombos <Laszlo Gombos>

Reviewed by Alexey Proskuryakov.

Drop the language tag part from the User Agent string
https://bugs.webkit.org/show_bug.cgi?id=54560

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::composeUserAgent):
  • ewk/ewk_settings.cpp: (ewk_settings_default_user_agent_get):

2011-02-22 Laszlo Gombos <Laszlo Gombos>

Reviewed by Alexey Proskuryakov.

Drop the language tag part from the User Agent string
https://bugs.webkit.org/show_bug.cgi?id=54560

  • webkit/webkitwebsettings.cpp: (webkitUserAgent):

2011-02-22 Laszlo Gombos <Laszlo Gombos>

Reviewed by Alexey Proskuryakov.

Drop the language tag part from the User Agent string
https://bugs.webkit.org/show_bug.cgi?id=54560

  • WebView/WebView.mm: (+[WebView _standardUserAgentWithApplicationName:]): Drop the language tag part.

2011-02-22 Laszlo Gombos <Laszlo Gombos>

Reviewed by Alexey Proskuryakov.

Drop the language tag part from the User Agent string
https://bugs.webkit.org/show_bug.cgi?id=54560

  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
  • tests/qwebpage/tst_qwebpage.cpp: Remove the userAgentLocaleChange test.

2011-02-22 Laszlo Gombos <Laszlo Gombos>

Reviewed by Alexey Proskuryakov.

Drop the language tag part from the User Agent string
https://bugs.webkit.org/show_bug.cgi?id=54560

  • WebView.cpp: (WebView::standardUserAgentWithApplicationName):

2011-02-22 Laszlo Gombos <Laszlo Gombos>

Reviewed by Alexey Proskuryakov.

Drop the language tag part from the User Agent string
https://bugs.webkit.org/show_bug.cgi?id=54560

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::userAgent):

2011-02-22 Laszlo Gombos <Laszlo Gombos>

Reviewed by Alexey Proskuryakov.

Drop the language tag part from the User Agent string
https://bugs.webkit.org/show_bug.cgi?id=54560

  • UIProcess/gtk/WebPageProxyGtk.cpp: (WebKit::WebPageProxy::standardUserAgent):
  • UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::standardUserAgent):
  • UIProcess/qt/WebPageProxyQt.cpp: (WebKit::WebPageProxy::standardUserAgent):
  • UIProcess/win/WebPageProxyWin.cpp: (WebKit::WebPageProxy::standardUserAgent): Drop the language tag part and fix style.
9:27 PM Changeset in webkit [79395] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-22 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update. Update Snow Leopard
expectations (some SVG tests now pass thanks to patches for bug 54474,
others now fail).

  • platform/chromium/test_expectations.txt:
9:22 PM Changeset in webkit [79394] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-22 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

Minimal build broken
https://bugs.webkit.org/show_bug.cgi?id=54743

Moved the code of setInspectorExtensionAPI and
dispatchMessageFromFrontend out of #if
ENABLE(JAVASCRIPT_DEBUGGER) to fix link error of the minimal build.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::setInspectorExtensionAPI): (WebCore::InspectorController::dispatchMessageFromFrontend):
8:49 PM Changeset in webkit [79393] by abarth@webkit.org
  • 1 edit
    3 adds in trunk/Source/JavaScriptGlue

2011-02-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add a GYP project for JavaScriptGlue
https://bugs.webkit.org/show_bug.cgi?id=55019

This is really just a proof-of-concept. The Xcode project file it
produces is able to build JavaScriptGlue, but it's not 100% correct.
Also, the GYP declarations aren't properly structured to allow for
multiple projects or ports. That should get better as we add
proof-of-concepts for other projects and ports.

This build system is not used currently.

  • gyp: Added.
  • gyp/JavaScriptGlue.gyp: Added.
  • gyp/JavaScriptGlue.gypi: Added.
8:45 PM Changeset in webkit [79392] by rniwa@webkit.org
  • 3 edits
    3 adds in trunk/LayoutTests

2011-02-22 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; fixed Windows expected failure results added by r79328 for new tests from r79318
http://webkit.org/b/54966 tracks the failure.

  • platform/win-xp/media: Added.
  • platform/win-xp/media/audio-repaint-expected.txt: Added.
  • platform/win-xp/media/media-document-audio-repaint-expected.txt: Added.
  • platform/win/media/audio-repaint-expected.txt:
  • platform/win/media/media-document-audio-repaint-expected.txt:
7:35 PM Changeset in webkit [79391] by weinig@apple.com
  • 11 edits
    1 add in trunk/Source/WebKit2

Add WebKit2 API to force a repaint with an invalidation
https://bugs.webkit.org/show_bug.cgi?id=55015

Reviewed by Anders Carlsson.

  • Shared/ForceRepaintFlags.h: Added.
  • UIProcess/API/C/WKPage.cpp:

(WKPageForceRepaint):
(WKPageForceRepaintWithInvalidation):

  • UIProcess/API/C/WKPage.h:

Add WKPageForceRepaintWithInvalidation which does the same thing WKPageForceRepaint
but also calls setNeedsDisplay on the entire bounds of the page.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::forceRepaint):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::forceRepaint):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Pipe the flag down to the WebProcess.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add ForceRepaintFlags.h.

7:31 PM Changeset in webkit [79390] by rniwa@webkit.org
  • 12 edits
    3 deletes in trunk/Source

2011-02-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r79367.
http://trac.webkit.org/changeset/79367
https://bugs.webkit.org/show_bug.cgi?id=55012

all layout tests are crashing on Snow Leopard (Requested by
rniwa on #webkit).

  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/MarkedBlock.cpp: (JSC::MarkedBlock::MarkedBlock):
  • runtime/MarkedBlock.h:
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::destroy): (JSC::MarkedSpace::allocateBlock): (JSC::MarkedSpace::freeBlock): (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::shrink): (JSC::MarkedSpace::reset):
  • runtime/MarkedSpace.h: (JSC::CollectorHeap::collectorBlock):
  • wtf/CMakeLists.txt:
  • wtf/DoublyLinkedList.h: Removed.

2011-02-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r79367.
http://trac.webkit.org/changeset/79367
https://bugs.webkit.org/show_bug.cgi?id=55012

all layout tests are crashing on Snow Leopard (Requested by
rniwa on #webkit).

  • ForwardingHeaders/wtf/DoublyLinkedList.h: Removed.

2011-02-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r79367.
http://trac.webkit.org/changeset/79367
https://bugs.webkit.org/show_bug.cgi?id=55012

all layout tests are crashing on Snow Leopard (Requested by
rniwa on #webkit).

  • ForwardingHeaders/wtf/DoublyLinkedList.h: Removed.
7:30 PM Changeset in webkit [79389] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-21 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] remove patch fuzzing
https://bugs.webkit.org/show_bug.cgi?id=54940

This code is buggy and not as necessary now that we
include svn revision numbers in uploaded patches.

  • code-review.js:
7:25 PM Changeset in webkit [79388] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-22 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update. Uncomment SNOWLEOPARD
expectations, since we still fail all those tests on Snow Leopard
(lines were commented out by r79275).

  • platform/chromium/test_expectations.txt:
7:23 PM Changeset in webkit [79387] by kbr@google.com
  • 4 edits in trunk

2011-02-22 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Many tests started timing out on the chrome mac canaries around r79035
https://bugs.webkit.org/show_bug.cgi?id=54885

Revert the code changes, but not the Chromium DEPS roll, from
r79038 to see whether this clears up the timing-out tests. Was not
able to reproduce the timeouts locally with a Release mode build
of DRT (on Snow Leopard).

  • src/WebKit.cpp: (WebKit::initialize):

2011-02-22 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Many tests started timing out on the chrome mac canaries around r79035
https://bugs.webkit.org/show_bug.cgi?id=54885

Revert the code changes, but not the Chromium DEPS roll, from
r79038 to see whether this clears up the timing-out tests. Was not
able to reproduce the timeouts locally with a Release mode build
of DRT (on Snow Leopard).

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::reset):
7:11 PM Changeset in webkit [79386] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

7:07 PM Changeset in webkit [79385] by mrowe@apple.com
  • 1 copy in tags/Safari-534.21

New tag.

6:36 PM Changeset in webkit [79384] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Marked tests as failing (image + text) on chromium, to reflect now-deleted rebaselines.

  • platform/chromium/test_expectations.txt:
6:31 PM Changeset in webkit [79383] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

2011-02-22 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

<rdar://problem/9039670>

Make sure that we set the accelerateDrawing property on the LayerTreeHosts's
non-composited content layer if the preference is set.

  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::LayerTreeHostMac):
6:22 PM Changeset in webkit [79382] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-02-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Deploy EditingStyle in removeInlineStyleFromElement and removeCSSStyle
https://bugs.webkit.org/show_bug.cgi?id=54944

Deployed EditingStyle in removeInlineStyleFromElement and removeCSSStyle.

Also extracted EditingStyle::conflictsWithInlineStyleOfElement from ApplyStyleCommand::removeCSSStyle,
which returns true iff the specified element has inline style that conflicts or matches the editing style.
It also appends conflicting property IDs to the vector of property IDs if one is specified.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): Calls removeCSSStyle. (WebCore::ApplyStyleCommand::applyInlineStyle): Calls shouldSplitTextElement. (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Calls removeInlineStyleFromElement. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Takes EditingStyle* instead of CSSMutableStyleDeclaration*. (WebCore::ApplyStyleCommand::removeCSSStyle): Ditto; extracted the logic to decide properties to remove as conflictsWithInlineStyleOfElement. (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): Calls shouldRemoveInlineStyleFromElement. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls removeInlineStyleFromElement. (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto. (WebCore::ApplyStyleCommand::shouldSplitTextElement): Takes EditingStyle* instead of CSSMutableStyleDeclaration*.
  • editing/ApplyStyleCommand.h: (WebCore::ApplyStyleCommand::shouldRemoveInlineStyleFromElement): Ditto.
  • editing/EditingStyle.cpp: (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Extracted from ApplyStyleCommand::removeCSSStyle.
  • editing/EditingStyle.h: (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Added.
6:15 PM Changeset in webkit [79381] by atwilson@chromium.org
  • 18 edits
    6 adds in trunk/LayoutTests

Unreviewed chromium-gpu expectations update.

  • platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.checksum:
  • platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.checksum:
  • platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.checksum:
  • platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.checksum:
  • platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.checksum:
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium-gpu-mac/compositing/masks/masked-ancestor-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/masks/simple-composited-mask-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/masks/simple-composited-mask-expected.png: Added.
  • platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
  • platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.checksum:
  • platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.checksum:
  • platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.checksum:
  • platform/chromium-gpu-win/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium/test_expectations.txt:
6:09 PM Changeset in webkit [79380] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-22 Dirk Pranke <dpranke@chromium.org>

Reviewed by James Robinson.

nrwt: --platform chromium-gpu doesn't work with --worker-model=processes
https://bugs.webkit.org/show_bug.cgi?id=55009

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
6:08 PM Changeset in webkit [79379] by Martin Robinson
  • 1 edit
    6 adds in trunk/LayoutTests

2011-02-22 Martin Robinson <mrobinson@igalia.com>

Add missing files from r79351. These are expected results for new media tests.

  • platform/gtk/media/audio-repaint-expected.checksum: Added.
  • platform/gtk/media/audio-repaint-expected.png: Added.
  • platform/gtk/media/audio-repaint-expected.txt: Added.
  • platform/gtk/media/media-document-audio-repaint-expected.checksum: Added.
  • platform/gtk/media/media-document-audio-repaint-expected.png: Added.
  • platform/gtk/media/media-document-audio-repaint-expected.txt: Added.
5:51 PM Changeset in webkit [79378] by atwilson@chromium.org
  • 7 edits
    3 adds in trunk/LayoutTests

Unreviewed expectations change for chromium.

  • platform/chromium-gpu-linux/compositing/reflections/deeply-nested-reflections-expected.checksum:
  • platform/chromium-gpu-linux/compositing/reflections/deeply-nested-reflections-expected.png:
  • platform/chromium-gpu-mac/compositing/reflections/deeply-nested-reflections-expected.checksum: Added.
  • platform/chromium-gpu-mac/compositing/reflections/deeply-nested-reflections-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.checksum:
  • platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.png:
  • platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.txt:
  • platform/chromium/test_expectations.txt:
5:37 PM Changeset in webkit [79377] by chang.shu@nokia.com
  • 4 edits in trunk/Source

2011-02-22 Chang Shu <cshu@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] editing/deleting/5408255.html fails
https://bugs.webkit.org/show_bug.cgi?id=54964

Move WebCore resource file to QtWebKit since they are referred in WebKit.

2011-02-22 Chang Shu <cshu@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] editing/deleting/5408255.html fails
https://bugs.webkit.org/show_bug.cgi?id=54964

Move WebCore resource file to QtWebKit since they are referred in WebKit.

  • WebCore.pro:
5:25 PM Changeset in webkit [79376] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix it Windows-style.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::getSitesWithPluginData):
(WebKit::WebProcess::clearPluginSiteData):

5:21 PM Changeset in webkit [79375] by morrita@google.com
  • 17 edits
    2 deletes in trunk/LayoutTests

2011-02-22 MORITA Hajime <morrita@google.com>

Unreviewed expectation update to catch up r79359.

  • platform/chromium-linux/media/audio-repaint-expected.checksum:
  • platform/chromium-linux/media/audio-repaint-expected.png:
  • platform/chromium-linux/media/audio-repaint-expected.txt: Removed.
  • platform/chromium-linux/media/media-document-audio-repaint-expected.checksum:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.txt: Removed.
  • platform/chromium-mac/media/audio-repaint-expected.checksum:
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/media/audio-repaint-expected.txt:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.checksum:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-win/media/audio-repaint-expected.checksum:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.txt:
  • platform/chromium-win/media/media-document-audio-repaint-expected.checksum:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
4:58 PM Changeset in webkit [79374] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Remove no-longer-necessary test expectation (LINUX video-cancel-load)
https://bugs.webkit.org/show_bug.cgi?id=55003

Patch by Ami Fischman <fischman@chromium.org> on 2011-02-22
Reviewed by Peter Kasting.

  • platform/chromium/test_expectations.txt:
4:48 PM Changeset in webkit [79373] by atwilson@chromium.org
  • 111 edits
    16 adds
    442 deletes in trunk/LayoutTests

Revert "Unreviewed rebaselines for Chromium." because the baselines were put in the wrong directory.

This partially reverts r79034 (we keep test_expectations the same as it is currently to avoid breaking the canaries).

4:42 PM Changeset in webkit [79372] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-02-22 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Rename WebProcess::shutdownIfPossible to WebProcess::terminateIfPossible
https://bugs.webkit.org/show_bug.cgi?id=55008

  • WebProcess/Downloads/DownloadManager.cpp: (WebKit::DownloadManager::downloadFinished):
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::removeWebPage): (WebKit::WebProcess::terminateIfPossible): (WebKit::WebProcess::getSitesWithPluginData):
  • WebProcess/WebProcess.h:
  • WebProcess/gtk/WebProcessGtk.cpp: (WebKit::WebProcess::platformTerminate):
  • WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformTerminate):
  • WebProcess/qt/WebProcessQt.cpp: (WebKit::WebProcess::platformTerminate):
  • WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::platformTerminate):
4:30 PM Changeset in webkit [79371] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Windows build-fix attempt.

  • win/WebKit2Generated.make:
4:14 PM Changeset in webkit [79370] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit2

Unreviewed.

<rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
API to view and delete Application Cache data by origin.

[Qt][WK2] Buildfix after r79364.

  • DerivedSources.pro:
  • WebKit2.pri:
4:14 PM Changeset in webkit [79369] by mihaip@chromium.org
  • 39 edits
    3 copies in branches/chromium/648

Merge 79107 - 2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Tests that going forward within the same document does not stop loading.

  • http/tests/navigation/forward-to-fragment-fires-onload.html: Added.
  • http/tests/navigation/forward-to-fragment-fires-onload-expected.txt: Added.
  • http/tests/navigation/resources/forward-to-fragment-fires-onload-2.html: Added.

2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Avoid stopping all loaders in goToItem for same document navigations
or pseudo-back-forward URLs. Make HistoryController::goToItem private
to force callers to go through Page::goToItem. Also add a callback to
FrameLoaderClient to let clients decide whether to stop loading first.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • loader/EmptyClients.h:
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/HistoryController.cpp:
  • loader/HistoryController.h:
  • page/Page.cpp:

2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Call Page::goToItem instead of HistoryController::goToItem, so that
FrameLoader::stopAllLoaders is called first. Also adds a callback in
FrameLoaderClient for checking for pseudo-back-forward URLs.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::shouldStopLoadingForHistoryItem): Added.
  • src/FrameLoaderClientImpl.h:
  • src/WebFrameImpl.cpp:

2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/FrameLoaderClientEfl.h:

2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClientGtk::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/FrameLoaderClientGtk.h:

2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/FrameLoaderClientHaiku.h:

2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/WebFrameLoaderClient.h:

2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/FrameLoaderClientQt.h:

2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/WebFrameLoaderClient.h:

2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/FrameLoaderClientWinCE.h:

2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::shouldStopLoadingForHistoryItem): Added.
  • WebKitSupport/FrameLoaderClientWx.h:

2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

BUG=73444
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6541090

4:10 PM Changeset in webkit [79368] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
API to view and delete Application Cache data by origin.

Reviewed by Anders Carlsson.

Implement these to be used by WK2 API:

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::getOriginsWithCache):
(WebCore::ApplicationCacheStorage::deleteEntriesForOrigin):

3:23 PM Changeset in webkit [79367] by ggaren@apple.com
  • 12 edits
    2 copies
    1 add in trunk/Source

2011-02-22 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Manage MarkedBlocks in a linked list instead of a vector, so arbitrary removal is O(1)
https://bugs.webkit.org/show_bug.cgi?id=54999


SunSpider reports no change.

  • runtime/MarkedBlock.cpp: (JSC::MarkedBlock::MarkedBlock):
  • runtime/MarkedBlock.h: (JSC::MarkedBlock::setPrev): (JSC::MarkedBlock::setNext): (JSC::MarkedBlock::prev): (JSC::MarkedBlock::next): Added linked list data members and accessors.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::destroy): (JSC::MarkedSpace::allocateBlock): Stop using vector, since it doesn't exist anymore.

(JSC::MarkedSpace::freeBlocks): New helper function for updating relevant
data structures when freeing blocks.

(JSC::MarkedSpace::allocate): Updated for nextBlock being a pointer and
not a vector index.

(JSC::MarkedSpace::shrink): Construct a temporary list of empties and
then free them, to avoid modifying our hash table while iterating it.
This wasn't a concern before because we were using indirect array
indexing, not direct pointer indexing.

(JSC::MarkedSpace::reset): Updated for nextBlock being a pointer and
not a vector index.

  • runtime/MarkedSpace.h: (JSC::CollectorHeap::CollectorHeap): Changed data type from vector to linked list.
  • wtf/DoublyLinkedList.h: Added. New linked list class. (WTF::::DoublyLinkedList): (WTF::::isEmpty): (WTF::::head): (WTF::::append): (WTF::::remove):

2011-02-22 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Manage MarkedBlocks in a linked list instead of a vector, so arbitrary removal is O(1)
https://bugs.webkit.org/show_bug.cgi?id=54999


New WTF header.

  • ForwardingHeaders/wtf/DoublyLinkedList.h: Copied from ForwardingHeaders/wtf/FixedArray.h.

2011-02-22 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Manage MarkedBlocks in a linked list instead of a vector, so arbitrary removal is O(1)
https://bugs.webkit.org/show_bug.cgi?id=54999


New WTF header.

  • ForwardingHeaders/wtf/DoublyLinkedList.h: Copied from ForwardingHeaders/wtf/FixedArray.h.
3:22 PM Changeset in webkit [79366] by andersca@apple.com
  • 9 edits
    2 deletes in trunk/Source/WebKit2

2011-02-22 Brady Eidson <beidson@apple.com>

Reviewed by Anders Carlsson and looked over by Brian Weinstein.

<rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
API to view and delete Application Cache data by origin.

I couldn't help myself - I also re-alphabetized WebResourceCacheManager in many places where
it's sorting was wrong due to a last minute name change.

Project file changes:

  • GNUmakefile.am:
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:
  • win/WebKit2Generated.make:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:

WK2 build-system and API paperwork:

  • DerivedSources.make:
  • Platform/CoreIPC/MessageID.h:
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • UIProcess/API/C/WKAPICast.h:

Add a helper to perform an ArrayCallback with a Vector of SecurityOriginDatas:

  • Shared/SecurityOriginData.cpp: (WebKit::performAPICallbackWithSecurityOriginDataVector):
  • Shared/SecurityOriginData.h:
  • UIProcess/WebResourceCacheManagerProxy.cpp: (WebKit::WebResourceCacheManagerProxy::didGetCacheOrigins): Use performAPICallbackWithSecurityOriginDataVector here.

Add an ApplicationCacheManagerProxy to the context and invalidate it at the appropriate times:

  • UIProcess/WebContext.cpp: (WebKit::WebContext::WebContext): (WebKit::WebContext::~WebContext): (WebKit::WebContext::processDidClose): (WebKit::WebContext::didReceiveMessage): Route messages to the right proxy.
  • UIProcess/WebContext.h: (WebKit::WebContext::applicationCacheManagerProxy): (WebKit::WebContext::resourceCacheManagerProxy):

Add API to get the ApplicationCacheManager for a context:

  • UIProcess/API/C/WKContext.cpp: (WKContextGetApplicationCacheManager): (WKContextGetResourceCacheManager):
  • UIProcess/API/C/WKContext.h:

Route messages to the right place:

  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didReceiveMessage):
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::didReceiveMessage):

Add the API object, which wraps to WebApplicationCacheManagerProxy:

  • UIProcess/API/C/WKApplicationCacheManager.cpp: Added. (WKApplicationCacheManagerGetTypeID): (WKApplicationCacheManagerGetApplicationCacheOrigins): (WKApplicationCacheManagerDeleteEntriesForOrigin): (WKApplicationCacheManagerDeleteAllEntries):
  • UIProcess/API/C/WKApplicationCacheManager.h: Added.

The UIProcess implementation of the manager to send messages to the WebProcess and pipe a callback back up to the client:

  • UIProcess/WebApplicationCacheManagerProxy.cpp: Added. (WebKit::WebApplicationCacheManagerProxy::create): (WebKit::WebApplicationCacheManagerProxy::WebApplicationCacheManagerProxy): (WebKit::WebApplicationCacheManagerProxy::~WebApplicationCacheManagerProxy): (WebKit::WebApplicationCacheManagerProxy::invalidate): (WebKit::WebApplicationCacheManagerProxy::didReceiveMessage): (WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins): (WebKit::WebApplicationCacheManagerProxy::didGetApplicationCacheOrigins): Use performAPICallbackWithSecurityOriginDataVector here. (WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin): (WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):
  • UIProcess/WebApplicationCacheManagerProxy.h: Added. (WebKit::WebApplicationCacheManagerProxy::clearContext): (WebKit::WebApplicationCacheManagerProxy::type):
  • UIProcess/WebApplicationCacheManagerProxy.messages.in: Added.

The WebProcess implementation to response to UIProcess messages and actually do the dirty-work in WebCore:

  • WebProcess/ApplicationCache: Added.
  • WebProcess/ApplicationCache/WebApplicationCacheManager.cpp: Added. (WebKit::WebApplicationCacheManager::shared): (WebKit::WebApplicationCacheManager::WebApplicationCacheManager): (WebKit::WebApplicationCacheManager::didReceiveMessage): (WebKit::WebApplicationCacheManager::getApplicationCacheOrigins): (WebKit::WebApplicationCacheManager::deleteEntriesForOrigin): (WebKit::WebApplicationCacheManager::deleteAllEntries):
  • WebProcess/ApplicationCache/WebApplicationCacheManager.h: Added.
  • WebProcess/ApplicationCache/WebApplicationCacheManager.messages.in: Added.
3:01 PM Changeset in webkit [79365] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed; neglected to update an expected result after changing some
boilerplate text at the top of the test.

  • media/audio-repaint-expected.txt:
2:52 PM Changeset in webkit [79364] by beidson@apple.com
  • 21 edits
    9 adds in trunk/Source/WebKit2

<rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
API to view and delete Application Cache data by origin.

Reviewed by Anders Carlsson and looked over by Brian Weinstein.

I couldn't help myself - I also re-alphabetized WebResourceCacheManager in many places where
it's sorting was wrong due to a last minute name change.

Project file changes:

  • GNUmakefile.am:
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:
  • win/WebKit2Generated.make:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:

WK2 build-system and API paperwork:

  • DerivedSources.make:
  • Platform/CoreIPC/MessageID.h:
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • UIProcess/API/C/WKAPICast.h:

Add a helper to perform an ArrayCallback with a Vector of SecurityOriginDatas:

  • Shared/SecurityOriginData.cpp:

(WebKit::performAPICallbackWithSecurityOriginDataVector):

  • Shared/SecurityOriginData.h:
  • UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::didGetCacheOrigins): Use performAPICallbackWithSecurityOriginDataVector here.

Add an ApplicationCacheManagerProxy to the context and invalidate it at the appropriate times:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::processDidClose):
(WebKit::WebContext::didReceiveMessage): Route messages to the right proxy.

  • UIProcess/WebContext.h:

(WebKit::WebContext::applicationCacheManagerProxy):
(WebKit::WebContext::resourceCacheManagerProxy):

Add API to get the ApplicationCacheManager for a context:

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetApplicationCacheManager):
(WKContextGetResourceCacheManager):

  • UIProcess/API/C/WKContext.h:

Route messages to the right place:

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage):

Add the API object, which wraps to WebApplicationCacheManagerProxy:

  • UIProcess/API/C/WKApplicationCacheManager.cpp: Added.

(WKApplicationCacheManagerGetTypeID):
(WKApplicationCacheManagerGetApplicationCacheOrigins):
(WKApplicationCacheManagerDeleteEntriesForOrigin):
(WKApplicationCacheManagerDeleteAllEntries):

  • UIProcess/API/C/WKApplicationCacheManager.h: Added.

The UIProcess implementation of the manager to send messages to the WebProcess and pipe a callback back up to the client:

  • UIProcess/WebApplicationCacheManagerProxy.cpp: Added.

(WebKit::WebApplicationCacheManagerProxy::create):
(WebKit::WebApplicationCacheManagerProxy::WebApplicationCacheManagerProxy):
(WebKit::WebApplicationCacheManagerProxy::~WebApplicationCacheManagerProxy):
(WebKit::WebApplicationCacheManagerProxy::invalidate):
(WebKit::WebApplicationCacheManagerProxy::didReceiveMessage):
(WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManagerProxy::didGetApplicationCacheOrigins): Use performAPICallbackWithSecurityOriginDataVector here.
(WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):

  • UIProcess/WebApplicationCacheManagerProxy.h: Added.

(WebKit::WebApplicationCacheManagerProxy::clearContext):
(WebKit::WebApplicationCacheManagerProxy::type):

  • UIProcess/WebApplicationCacheManagerProxy.messages.in: Added.

The WebProcess implementation to response to UIProcess messages and actually do the dirty-work in WebCore:

  • WebProcess/ApplicationCache: Added.
  • WebProcess/ApplicationCache/WebApplicationCacheManager.cpp: Added.

(WebKit::WebApplicationCacheManager::shared):
(WebKit::WebApplicationCacheManager::WebApplicationCacheManager):
(WebKit::WebApplicationCacheManager::didReceiveMessage):
(WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManager::deleteAllEntries):

  • WebProcess/ApplicationCache/WebApplicationCacheManager.h: Added.
  • WebProcess/ApplicationCache/WebApplicationCacheManager.messages.in: Added.
2:34 PM Changeset in webkit [79363] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2011-02-22 Ami Fischman <fischman@chromium.org>

Reviewed by Eric Carlson.

Second attempt at removing flakiness from media/video-poster.html (in
service of http://crbug.com/60845). First attempt (r79161)
relied on load & error events firing on the video element for
poster-related events, which the standard does not specify (and
are thus a bug). This change instead relies on a 20ms sleep loop to
observe the new expected dimensions (and relies on the test
runner to time out if the expectations fail to be met).

https://bugs.webkit.org/show_bug.cgi?id=54685

  • media/video-poster.html:
2:29 PM Changeset in webkit [79362] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-02-22 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Get rid of WebProcessManager::getAllWebProcessContexts
https://bugs.webkit.org/show_bug.cgi?id=55000

  • Shared/WebURLRequest.cpp: (WebKit::WebURLRequest::setDefaultTimeoutInterval): Call WebContext::allContexts instead.
  • UIProcess/WebContext.cpp:
  • UIProcess/WebContext.h: Add a vector of WebContext objects. Update it when creating and destroying contexts.
  • UIProcess/WebProcessManager.cpp:
  • UIProcess/WebProcessManager.h: Remove WebProcessManager::getAllWebProcessContexts.
2:29 PM Changeset in webkit [79361] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-22 Andrew Wilson <atwilson@chromium.org>

Unreviewed, rolling out r79339.
http://trac.webkit.org/changeset/79339
https://bugs.webkit.org/show_bug.cgi?id=54974

Baselines were put in the wrong directory, so we need to
continue to ignore failures

  • platform/chromium/test_expectations.txt:
2:28 PM Changeset in webkit [79360] by Beth Dakin
  • 10 edits in trunk/Source/WebCore

Fix for https://bugs.webkit.org/show_bug.cgi?id=54991
Scrollbar::nativeTheme()->usesOverlayScrollbars() should not be consulted for CSS
Scrollbars
-and corresponding-
<rdar://problem/9034318>

Reviewed by Sam Weinig.

Instead of consulting the theme directly, callers should ask the Scrollbar or
ScrollableArea if the scrollbars are overlay or not.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::visibleContentRect):
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
(WebCore::ScrollableArea::hasOverlayScrollbars):

  • platform/ScrollableArea.h:
  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::isOverlayScrollbar):

  • platform/Scrollbar.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::includeVerticalScrollbarSize):
(WebCore::RenderBox::includeHorizontalScrollbarSize):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::verticalScrollbarWidth):
(WebCore::RenderLayer::horizontalScrollbarHeight):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::verticalScrollbarWidth):

  • rendering/RenderScrollbar.h:

(WebCore::RenderScrollbar::isOverlayScrollbar):

2:09 PM Changeset in webkit [79359] by jer.noble@apple.com
  • 9 edits
    1 add in trunk/LayoutTests

2011-02-22 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

media/audio-repaint.html flakey.
https://bugs.webkit.org/show_bug.cgi?id=54970

Audio repaint tests flakey, as they took a snapshot 1.5s into a 7s file. Tests
modified to test against a 1s file, and will trigger a snapshot when the audio
finishes seeking to the 1/2way point.

  • media/audio-repaint-expected.txt:
  • media/audio-repaint.html:
  • media/content/silence.wav: Added.
  • media/media-document-audio-repaint-expected.txt:
  • media/media-document-audio-repaint.html:
  • platform/mac/media/audio-repaint-expected.checksum:
  • platform/mac/media/audio-repaint-expected.png:
  • platform/mac/media/media-document-audio-repaint-expected.checksum:
  • platform/mac/media/media-document-audio-repaint-expected.png:
2:09 PM Changeset in webkit [79358] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Re-add early bail out in dispatchDecidePolicyForNavigationAction with prevents
a crash running fast/loader/empty-embed-src-attribute.html. This matches a
bail out in the default policy delegate in WebKit1.

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

2:00 PM Changeset in webkit [79357] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] New fails caused by change(s) between r79317-r79320.

  • platform/qt/Skipped: Skip tests until fix.
1:55 PM Changeset in webkit [79356] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

1:49 PM Changeset in webkit [79355] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Bug 54988 - Re-create StructureTransitionTable class, encapsulate transition table

Reviewed by Sam Weinig.

The Structure class keeps a table of transitions to derived Structure types. Since
this table commonly contains a single entry we employ an optimization where instead
of holding a map, we may hold a pointer directly to a single instance of the mapped
type. We use an additional bit of data to flag whether the pointer is currently
pointing to a table of transitions, or a singleton transition. Previously we had
commonly used a pattern of storing data in the low bits of pointers, but had moved
away from this since it causes false leaks to be reported by the leaks tool. However
in this case, the entries in the map are weak links - this pointer will never be
responsible for keeping an object alive. As such we can use this approach provided
that the bit is set when a table is not in use (otherwise the table would appear to
be leaked).

Additionally, the transition table currently allows two entries to exist for a given
key - one specialized to a particular value, and one not specialized. This is
unnecessary, wasteful, and a little inconsistent. (If you create an entry for a
specialized value, then a non-specialized entry, both will exist. If you create an
entry for a non-specialized value, then try to create a specialized entry, only a
non-specialized form will be allowed.)

This shows a small progression on v8.

(JSC::JSObject::putDirectInternal):

  • runtime/Structure.cpp:

(JSC::StructureTransitionTable::contains):
(JSC::StructureTransitionTable::get):
(JSC::StructureTransitionTable::remove):
(JSC::StructureTransitionTable::add):
(JSC::Structure::dumpStatistics):
(JSC::Structure::Structure):
(JSC::Structure::~Structure):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):

  • runtime/Structure.h:

(JSC::Structure::get):

  • runtime/StructureTransitionTable.h:

(JSC::StructureTransitionTable::Hash::hash):
(JSC::StructureTransitionTable::Hash::equal):
(JSC::StructureTransitionTable::HashTraits::emptyValue):
(JSC::StructureTransitionTable::HashTraits::constructDeletedValue):
(JSC::StructureTransitionTable::HashTraits::isDeletedValue):
(JSC::StructureTransitionTable::StructureTransitionTable):
(JSC::StructureTransitionTable::~StructureTransitionTable):
(JSC::StructureTransitionTable::isUsingSingleSlot):
(JSC::StructureTransitionTable::map):
(JSC::StructureTransitionTable::setMap):
(JSC::StructureTransitionTable::singleTransition):
(JSC::StructureTransitionTable::setSingleTransition):

1:45 PM Changeset in webkit [79354] by thakis@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-02-21 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] WebWorkerBase::openFileSystem confuses clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54920

Rename WebWorkerBase::openFileSystem() to openFileSystemForWorker() to
make it obvious it's not an override of
WebFrameClient::openFileSystem().

Remove a failed attempt to override it in WebWorkerClientImpl (the
override didn't change the behavior).

No intended functionality change.

  • src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::requestFileSystem): Call new name.
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::openFileSystemForWorker): Rename openFileSystem() to openFileSystemForWorker().
  • src/WebWorkerBase.h: Rename openFileSystem() to openFileSystemForWorker().
  • src/WebWorkerClientImpl.h: (WebKit::WebWorkerClientImpl::allowDatabase): Remove unsuccessful (and pointless) override.
1:35 PM Changeset in webkit [79353] by atwilson@chromium.org
  • 2 edits
    18 adds in trunk/LayoutTests

Unreviewed expectations change.

[Chromium] Generate results for media/audio-repaint.html and media/media-document-audio-repaint.html
https://bugs.webkit.org/show_bug.cgi?id=54983

  • platform/chromium-linux/media/audio-repaint-expected.checksum: Added.
  • platform/chromium-linux/media/audio-repaint-expected.png: Added.
  • platform/chromium-linux/media/audio-repaint-expected.txt: Added.
  • platform/chromium-linux/media/media-document-audio-repaint-expected.checksum: Added.
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-linux/media/media-document-audio-repaint-expected.txt: Added.
  • platform/chromium-mac/media/audio-repaint-expected.checksum: Added.
  • platform/chromium-mac/media/audio-repaint-expected.png: Added.
  • platform/chromium-mac/media/audio-repaint-expected.txt: Added.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.checksum: Added.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt: Added.
  • platform/chromium-win/media/audio-repaint-expected.checksum: Added.
  • platform/chromium-win/media/audio-repaint-expected.png: Added.
  • platform/chromium-win/media/audio-repaint-expected.txt: Added.
  • platform/chromium-win/media/media-document-audio-repaint-expected.checksum: Added.
  • platform/chromium-win/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:19 PM Changeset in webkit [79352] by abecsi@webkit.org
  • 4 edits in trunk/Source

[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339

Reviewed by Csaba Osztrogonác.

Move inspector's resource files into the final build step to fix the layout test regression.

Source/WebCore:

No new tests needed.

  • WebCore.pro: Move inspector's resource files into QtWebKit.pro.

Source/WebKit/qt:

  • QtWebKit.pro: Add inspector's reaource files.
1:15 PM Changeset in webkit [79351] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-02-22 Martin Robinson <mrobinson@igalia.com>

Add some GTK+-specific expectations for new media tests.

  • platform/gtk/Skipped: Unskip tests which now have results.
1:06 PM Changeset in webkit [79350] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-02-22 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] fast/frames/iframe-scale-applied-twice.html fails after r79167
https://bugs.webkit.org/show_bug.cgi?id=54990

No new tests. This will cause fast/events/scroll-after-click-on-tab-index.html
to start passing again.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::visibleContentRect): Update this method to match the original in the parent class.
1:01 PM Changeset in webkit [79349] by Martin Robinson
  • 6 edits in trunk

2011-01-17 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] fast/events/scroll-after-click-on-tab-index has been failing on the bots
https://bugs.webkit.org/show_bug.cgi?id=49177

  • platform/gtk/Skipped: Unskip passing test.

2011-01-17 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] fast/events/scroll-after-click-on-tab-index has been failing on the bots
https://bugs.webkit.org/show_bug.cgi?id=49177

  • platform/ScrollView.cpp: Remove the GTK+ guards around the implementation of platformAddChild and platformRemoveChild. This code can be shared.
  • platform/gtk/MainFrameScrollbarGtk.cpp: (MainFrameScrollbarGtk::attachAdjustment): Prevent re-attaching an already attached adjustment. Connect the adjustment value-changed signal handler after resetting the adjustment. This prevents the rest from stomping on pre-existing WebCore values. (MainFrameScrollbarGtk::gtkValueChanged): If the scrollbar is no longer attached to a scrollview do not listing for value changes. These scrollbars are defunct.
  • platform/gtk/ScrollViewGtk.cpp: Remove duplicated empty methods.
1:01 PM Changeset in webkit [79348] by andersca@apple.com
  • 11 edits in trunk/Source/WebKit2

2011-02-22 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Grammar correction from Spelling & Grammar window doesn't work
https://bugs.webkit.org/show_bug.cgi?id=54982
<rdar://problem/8940918>

  • UIProcess/API/mac/WKView.mm: (-[WKView isGrammarCheckingEnabled]): (-[WKView setGrammarCheckingEnabled:]): Call down to the text checker.
  • UIProcess/TextChecker.h: Add updateSpellingUIWithGrammarString.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::updateSpellingUIWithGrammarString): Call TextChecker::updateSpellingUIWithGrammarString.
  • UIProcess/WebPageProxy.messages.in: Add UpdateSpellingUIWithGrammarString message.
  • UIProcess/gtk/TextCheckerGtk.cpp: (WebKit::TextChecker::updateSpellingUIWithGrammarString):
  • UIProcess/qt/TextCheckerQt.cpp: (WebKit::TextChecker::updateSpellingUIWithGrammarString):
  • UIProcess/win/TextCheckerWin.cpp: (WebKit::TextChecker::updateSpellingUIWithGrammarString): Add stubs.
  • UIProcess/mac/TextCheckerMac.mm: (WebKit::TextChecker::updateSpellingUIWithGrammarString): Update the spelling panel.
  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::updateSpellingUIWithGrammarString): Send an UpdateSpellingUIWithGrammarString message to the UI process.
12:42 PM Changeset in webkit [79347] by Martin Robinson
  • 3 edits in trunk/Source/WebKit/gtk

2011-02-22 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] position:fixed elements flicker while scrolling after r74196
https://bugs.webkit.org/show_bug.cgi?id=54981

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::ChromeClient): Initialize the new m_pendingScrollInvalidations boolean to false. (WebKit::ChromeClient::invalidateWindow): If this is an immediate invalidation and we having pending scrolling invalidations, instruct GDK to process updates now. (WebKit::ChromeClient::scroll): Remove the call to gdk_window_process_updates. Set m_pendingScrollInvalidations to true to force it to happen in invalidateWindow instead.
  • WebCoreSupport/ChromeClientGtk.h: Add new boolean member.
12:40 PM Changeset in webkit [79346] by jer.noble@apple.com
  • 4 edits in trunk/LayoutTests

Unreviewed, adding new pixel tests to the skipped list of various platforms.

media/audio-repaint.html flakey.
https://bugs.webkit.org/show_bug.cgi?id=54970

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
12:18 PM Changeset in webkit [79345] by pfeldman@chromium.org
  • 20 edits in trunk

2011-02-22 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor InjectedScript : InspectorDOMAgent interaction.
https://bugs.webkit.org/show_bug.cgi?id=54954

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::toNode): (WebCore::JSInjectedScriptHost::inspect):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::toNode): (WebCore::V8InjectedScriptHost::inspectCallback):
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::nodeForObjectId):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::inspect):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js: (.):
  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::focusNode):
  • inspector/InspectorAgent.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::inspect): (WebCore::InspectorDOMAgent::pushNodeToFrontend):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.evaluateInTargetWindow): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.receivedImages): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.pushImageNodes):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMDispatcher.prototype.childNodeRemoved): (WebInspector.DOMDispatcher.prototype.inspectElementRequested):
  • inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
11:38 AM Changeset in webkit [79344] by beidson@apple.com
  • 6 edits in trunk/Source

Part of <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
API to view and delete Application Cache data by origin.

Reviewed by Anders Carlsson.

../WebCore:

Stub these out for now:

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::getOriginsWithCache):
(WebCore::ApplicationCacheStorage::deleteEntriesForOrigin):
(WebCore::ApplicationCacheStorage::deleteAllEntries): Moved implementation here from WebKit/Mac

  • loader/appcache/ApplicationCacheStorage.h:

Export the new symbols:

  • WebCore.exp.in:

../WebKit/mac:

  • WebCoreSupport/WebApplicationCache.mm:

(+[WebApplicationCache deleteAllApplicationCaches]): Move this implementation into WebCore itself.

11:36 AM Changeset in webkit [79343] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix debug build.

  • WebCore.exp.in:
11:28 AM Changeset in webkit [79342] by atwilson@chromium.org
  • 2 edits
    5 deletes in trunk/LayoutTests

2011-02-22 Andrew Wilson <atwilson@chromium.org>

Unreviewed, rolling out r79337.
http://trac.webkit.org/changeset/79337

GPU-only test should have GPU baselines

  • platform/chromium-linux/compositing/reflections/deeply-nested-reflections-expected.checksum: Removed.
  • platform/chromium-linux/compositing/reflections/deeply-nested-reflections-expected.png: Removed.
  • platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.checksum: Removed.
  • platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.png: Removed.
  • platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
11:19 AM Changeset in webkit [79341] by Philippe Normand
  • 1 copy in releases/WebKitGTK/webkit-1.3.12

Branching for WebKitGTK+ release

10:59 AM Changeset in webkit [79340] by enne@google.com
  • 16 edits in trunk/LayoutTests

2011-02-22 Adrienne Walker <enne@google.com>

Unreviewed rebaseline of some GPU tests.

This cleans up the rest of the BUGWK54409 expectations after r79084.

  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.checksum:
  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.checksum:
  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium/test_expectations.txt:
10:56 AM Changeset in webkit [79339] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Prospectively removing test_expectations entries for some tests that seem to be passing now on the canaries.

  • platform/chromium/test_expectations.txt:
10:53 AM Changeset in webkit [79338] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a flaky Inspector test on Windows

<http://webkit.org/b/54974> tracks the failure.

  • platform/win/Skipped: Added inspector/extensions/extensions-events.html.
10:51 AM Changeset in webkit [79337] by atwilson@chromium.org
  • 2 edits
    8 adds in trunk/LayoutTests

Unreviewed expectations update for deeply-nested-reflections.html

  • platform/chromium-linux/compositing/reflections/deeply-nested-reflections-expected.checksum: Added.
  • platform/chromium-linux/compositing/reflections/deeply-nested-reflections-expected.png: Added.
  • platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.checksum: Added.
  • platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.png: Added.
  • platform/chromium-win/compositing/reflections/deeply-nested-reflections-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:47 AM Changeset in webkit [79336] by mihaip@chromium.org
  • 2 edits in trunk/Tools

2011-02-18 Mihai Parparita <mihaip@chromium.org>

Reviewed by Ojan Vafai.

Default to 500 for --exit-after-n-failures
https://bugs.webkit.org/show_bug.cgi?id=54773

Make 500 the default value for --exit-after-n-failures (ORWT bots
already default to this as of r75726). Similarly, change the default for
--exit-after-n-crashes-or-timeouts to 20.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
10:45 AM Changeset in webkit [79335] by kbalazs@webkit.org
  • 62 edits
    1 delete in trunk/Source

notImplemented() should behave identical in WebCore and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54449

Reviewed by Anders Carlsson.

Source/WebCore:

No functional change so no new tests.

  • WebCore.xcodeproj/project.pbxproj: Add NotImplemented.h as private header

to be able to use it in WebKit2.

Source/WebKit2:

Use NotImplemented.h from WebCore. Initialize logging channels.
Remove the WebKit2 concept of notImplemented().

  • Platform/gtk/SharedMemoryGtk.cpp:
  • Platform/gtk/WorkQueueGtk.cpp:
  • Platform/qt/WorkQueueQt.cpp:
  • Platform/win/WorkQueueWin.cpp:
  • Shared/NotImplemented.h: Removed.
  • Shared/Plugins/NPIdentifierData.cpp:
  • Shared/Plugins/NPRemoteObjectMap.cpp:
  • Shared/Plugins/NPVariantData.cpp:
  • Shared/cairo/ShareableBitmapCairo.cpp:
  • Shared/gtk/ShareableBitmapGtk.cpp:
  • Shared/gtk/WebCoreArgumentCodersGtk.cpp:
  • Shared/qt/WebCoreArgumentCodersQt.cpp:
  • Shared/win/LayerTreeContextWin.cpp:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/API/qt/qwkpage.cpp:
  • UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp:
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
  • UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):

  • UIProcess/WebInspectorProxy.cpp:
  • UIProcess/gtk/TextCheckerGtk.cpp:
  • UIProcess/gtk/WebInspectorGtk.cpp:
  • UIProcess/gtk/WebPreferencesGtk.cpp:
  • UIProcess/qt/TextCheckerQt.cpp:
  • UIProcess/qt/WebInspectorProxyQt.cpp:
  • UIProcess/win/TextCheckerWin.cpp:
  • UIProcess/win/WebContextMenuProxyWin.cpp:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Downloads/cf/DownloadCFNet.cpp:
  • WebProcess/Downloads/curl/DownloadCurl.cpp:
  • WebProcess/Downloads/mac/DownloadMac.mm:
  • WebProcess/Downloads/qt/DownloadQt.cpp:
  • WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:
  • WebProcess/Plugins/Netscape/NPJSObject.cpp:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
  • WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp:
  • WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
  • WebProcess/WebCoreSupport/WebDragClient.cpp:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:
  • WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp:
  • WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
  • WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp:
  • WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
  • WebProcess/WebPage/qt/WebInspectorQt.cpp:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

  • WebProcess/gtk/WebProcessGtk.cpp:
  • config.h:
  • win/WebKit2.vcproj:
10:41 AM Changeset in webkit [79334] by abecsi@webkit.org
  • 5 edits in trunk/Source

[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339

Reviewed by Laszlo Gombos.
Rubber-stamped by Csaba Osztrogonác.

The patch landed in r79320 didn't contain the cleanup
which was already addressed in the last attachment.

Source/WebCore:

No new tests needed.

  • WebCore.pri: Add common LIB and CONFIG options.
  • WebCore.pro: Add accidentally moved sections.

Source/WebKit/qt:

  • QtWebKit.pro: Move common LIB and CONFIG options to WebCore.pri.
10:26 AM Changeset in webkit [79333] by Philippe Normand
  • 3 edits in trunk

2011-02-22 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] 1.3.12 release preparation
https://bugs.webkit.org/show_bug.cgi?id=54967

Version bump for 1.3.12 and updated NEWS file with release notes.
Also bumped libsoup requirement to 2.33.6 as agreed with Sergio
and Martin.

  • Source/WebKit/gtk/NEWS:
  • configure.ac:
10:24 AM Changeset in webkit [79332] by Philippe Normand
  • 3 edits
    2 deletes in trunk

2011-02-22 Philippe Normand <pnormand@igalia.com>

Unreviewed, rolling out r79321.
http://trac.webkit.org/changeset/79321
https://bugs.webkit.org/show_bug.cgi?id=53146

Regresses fast/forms/listbox-typeahead-cyrillic.html and fast
/spatial-navigation/snav-single-select.html on GTK

  • platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Removed.
  • platform/gtk/accessibility/combo-box-collapsed-selection-changed.html: Removed.

2011-02-22 Philippe Normand <pnormand@igalia.com>

Unreviewed, rolling out r79321.
http://trac.webkit.org/changeset/79321
https://bugs.webkit.org/show_bug.cgi?id=53146

Regresses fast/forms/listbox-typeahead-cyrillic.html and fast
/spatial-navigation/snav-single-select.html on GTK

  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::notifyChildrenSelectionChange): (WebCore::AXObjectCache::postPlatformNotification):
10:19 AM Changeset in webkit [79331] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

Invalidate the WebResourceCacheManagerProxy in WebContext::processDidClose.

Rubber-stamped by Brady Eidson.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::processDidClose):

9:45 AM Changeset in webkit [79330] by Philippe Normand
  • 2 edits in trunk

Unreviewed, revert the duplicate ChangeLog entries added in r79307, r79312, r79313 and r79314

9:39 AM Changeset in webkit [79329] by Martin Robinson
  • 9 edits in trunk

2011-02-02 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
https://bugs.webkit.org/show_bug.cgi?id=53603

  • platform/gtk/Skipped: Unskip passing tests.

2011-02-02 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
https://bugs.webkit.org/show_bug.cgi?id=53603

Add setSelectTrailingWhitespaceEnabled and selectTrailingWhitespaceEnabled which allow
setting and querying the selectTrailingWhitespaceEnabled setting. EditorClient just
listens to this value during DRT runs. Perhaps later we can expose this to the public
API.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setSelectTrailingWhitespaceEnabled): Added (DumpRenderTreeSupportGtk::selectTrailingWhitespaceEnabled): Added
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::isSelectTrailingWhitespaceEnabled): Ask DRTSupportGtk for the appropriate return value.

2011-02-02 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
https://bugs.webkit.org/show_bug.cgi?id=53603

Add support for LayoutTestController.setSelectTrailingWhitespace by calling through
to DumpRenderTreeSupportGtk for this functionality.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Always call LayoutTestController.setSelectTrailingWhitespace to false when reseting values between tests.
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setSelectTrailingWhitespaceEnabled): Call LayoutTestController.setSelectTrailingWhitespace with the appropriate value.
9:16 AM Changeset in webkit [79328] by Adam Roben
  • 1 edit
    2 adds in trunk/LayoutTests

Add Windows expected failure results for new tests from r79318

<http://webkit.org/b/54966> tracks the failure.

  • platform/win/media/audio-repaint-expected.txt: Added.
  • platform/win/media/media-document-audio-repaint-expected.txt: Added.
8:08 AM Changeset in webkit [79327] by Adam Roben
  • 3 edits in trunk/Tools

Don't trigger a Windows build when the top-level ChangeLog changes

r79320 is an example of a change that shouldn't have built on Windows, but did, because of
this bug.

Fixes <http://webkit.org/b/54957> Windows bots build when top-level ChangeLog changes, but
shouldn't

Reviewed by Anders Carlsson.

  • Scripts/webkitpy/common/config/build.py:

(_should_file_trigger_build): Modified the ChangeLog pattern to match the top-level
ChangeLog, and re-sorted it in the list.

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest): Added a test that ChangeLogs don't trigger builds.

8:07 AM Changeset in webkit [79326] by Adam Roben
  • 3 edits in trunk/Source/WebKit2

Make DrawingAreaProxyImpl keep track of the most recent state ID it sent to the web process

This will be useful for sending repeated messages for the same state ID to the web process.
We don't do this currently, but will need to if we're asked to paint after we've thrown away
our backing store to save memory.

Fixes <http://webkit.org/b/54916> DrawingAreaProxyImpl should keep track of the state ID it
last sent to the web process

Reviewed by Anders Carlsson.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): Initialize m_requestedStateID, and
reordered member initialization to match the new declaration order.
(WebKit::DrawingAreaProxyImpl::didUpdateState): Added an assertion that the stateID we got
from the web process is no newer than the most recent one we requested.
(WebKit::DrawingAreaProxyImpl::sendUpdateState): Changed to increment and send
m_requestedStateID instead of a new global stateID.

  • UIProcess/DrawingAreaProxyImpl.h: Added m_requestedStateID, and moved the state IDs before

other data members. Also beefed the comment explaining m_currentStateID.

8:01 AM Changeset in webkit [79325] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-02-22 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Inspector.IDL change. rename attribute notify -> event.
https://bugs.webkit.org/show_bug.cgi?id=54958

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
7:44 AM Changeset in webkit [79324] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-02-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r78691.
http://trac.webkit.org/changeset/78691
https://bugs.webkit.org/show_bug.cgi?id=54956

Leopard Debug is successfully building again (Requested by
aroben on #webkit).

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
7:32 AM Changeset in webkit [79323] by yurys@chromium.org
  • 16 edits in trunk

2011-02-22 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Timeline agent should have same lifetime as InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=54951

  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:
  • inspector/timeline/timeline-test.js: (initialize_Timeline.InspectorTest.performActionsAndPrint.step2):
  • inspector/timeline/timeline-trivial.html:

2011-02-22 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Timeline agent should have same lifetime as InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=54951

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::domContentLoadedEventFired): (WebCore::InspectorAgent::loadEventFired):
  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::timelineProfilerEnabled):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::retrieveTimelineAgent):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::setFrontend): (WebCore::InspectorTimelineAgent::clearFrontend): (WebCore::InspectorTimelineAgent::restore): (WebCore::InspectorTimelineAgent::startTimelineProfiler): (WebCore::InspectorTimelineAgent::stopTimelineProfiler): (WebCore::InspectorTimelineAgent::timelineProfilerStarted): (WebCore::InspectorTimelineAgent::didCommitLoad): (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::clearRecordStack):
  • inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::create):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
7:28 AM Changeset in webkit [79322] by loislo@chromium.org
  • 14 edits
    2 deletes in trunk

2011-02-22 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by NOBODY (OOPS!).

Web Inspector: flakyness of inspector tests.
https://bugs.webkit.org/show_bug.cgi?id=54729

As far as we have the protocol with sequence numbers we can simplify test harness support
and drop out chomium specific methods.

Source/WebCore:

  • inspector/CodeGeneratorInspector.pm:
  • inspector/front-end/TestController.js: (WebInspector.TestController): (WebInspector.TestController.prototype.notifyDone): (WebInspector.TestController.prototype.runAfterPendingDispatches): (WebInspector.TestController.prototype._evaluateForTestInFrontend):
  • inspector/front-end/inspector.js: (WebInspector.dispatch):

Source/WebKit/chromium:

  • src/js/DevTools.js:

LayoutTests:

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.runAfterPendingDispatches):

Tools:

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp: (DRTDevToolsAgent::sendMessageToInspectorFrontend): (DRTDevToolsAgent::runtimePropertyChanged): (DRTDevToolsAgent::asyncCall): (DRTDevToolsAgent::call):
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
  • DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp: Removed.
  • DumpRenderTree/chromium/DRTDevToolsCallArgs.h: Removed.
  • DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::sendMessageToBackend): (DRTDevToolsClient::asyncCall): (DRTDevToolsClient::call):
  • DumpRenderTree/chromium/DRTDevToolsClient.h:
7:26 AM Changeset in webkit [79321] by mario@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-22 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Combo boxes should emit object:selection-changed even when collapsed
https://bugs.webkit.org/show_bug.cgi?id=53146

New GTK-specific layout test to check the right signals are emitted.

  • platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Added.
  • platform/gtk/accessibility/combo-box-collapsed-selection-changed.html: Added.

2011-02-22 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Combo boxes should emit object:selection-changed even when collapsed
https://bugs.webkit.org/show_bug.cgi?id=53146

Emit the selection-changed signals when the menu list value has changed

Test: platform/gtk/accessibility/combo-box-collapsed-selection-changed.html

  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::getListObject): New, return the right list object for menu lists and list boxes. (WebCore::notifyChildrenSelectionChange): Support menu lists. (WebCore::AXObjectCache::postPlatformNotification): Call function notifyChildrenSelectionChange for AXMenuListValueChanged.
7:14 AM Changeset in webkit [79320] by abecsi@webkit.org
  • 14 edits
    1 add in trunk

2011-02-22 Andras Becsi <abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339

Part 2.

Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.

  • Source/WebKit.pri: Add common include paths
  • Source/WebKit.pro: Add new project file to SUBDIRS

2011-02-22 Andras Becsi <abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339

Part 2.

Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.

  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Remove superfluous includepaths.

2011-02-22 Andras Becsi <abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339

Part 2.

Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.

2011-02-22 Andras Becsi <abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339

Part 2.

Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.

  • QtWebKit.pro: Added. Project file for the final build step.

2011-02-22 Andras Becsi <abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339

Part 2.

Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.

No new tests needed.

  • WebCore.pri: Add needed rules for handling the static library.
  • WebCore.pro: Reorganize API and linker options to QtWebKit.pro.

2011-02-22 Andras Becsi <abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] Redesign the build system
https://bugs.webkit.org/show_bug.cgi?id=51339

Part 2.

Build WebCore as a static library, compile the WebKit API and WebKit2 API
in a final step and link to WebKit2, WebCore and JSC libraries to fix
linking issues resulting from stripped away symbols.

  • WebKit2.pri: Add include paths.
  • WebKit2.pro: Move include paths to WebKit2.pri and move the API source to WebKit/qt/QtWebKit.pro
7:09 AM Changeset in webkit [79319] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-02-22 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] navigation does not work when inspector is opened.
https://bugs.webkit.org/show_bug.cgi?id=54947

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
  • inspector/InspectorState.cpp: (WebCore::InspectorState::loadFromCookie):
  • inspector/InspectorState.h:
7:07 AM Changeset in webkit [79318] by jer.noble@apple.com
  • 3 edits
    8 adds in trunk

2011-02-15 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Built-in HTML5 <audio> (and sometimes <video>) UI doesn't update playhead location or time displays
https://bugs.webkit.org/show_bug.cgi?id=46142

Added a repaint test which ensures the timeline controls repaint in an audio-only MediaDocument. Since
the change also affects in-page audio, also added a repaint test for those cases as well.

Other platforms will need to have results generated.

  • media/audio-repaint.html: Added.
  • media/media-document-audio-repaint-expected.txt: Added.
  • media/media-document-audio-repaint.html: Added.
  • platform/mac/media/audio-repaint-expected.checksum: Added.
  • platform/mac/media/audio-repaint-expected.png: Added.
  • platform/mac/media/audio-repaint-expected.txt: Added.
  • platform/mac/media/media-document-audio-repaint-expected.checksum: Added.
  • platform/mac/media/media-document-audio-repaint-expected.png: Added.

2011-02-15 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Built-in HTML5 <audio> (and sometimes <video>) UI doesn't update playhead location or time displays
https://bugs.webkit.org/show_bug.cgi?id=46142

Push a LayoutStateMaintainer in RenderMedia::layout() before calling layout() on the
container elements. This is necessary because, during layout(), the child renderers
query the current LayoutState to determine where they will be repainting. If a new
LayoutState is not pushed here, child renderers will attempt to repaint relative to
their grandparent's origin instead of their parents', and repaint operations will fail.

  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::layout):
6:49 AM Changeset in webkit [79317] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-22 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Cleaning: remove a overzealous check for the pointer "files" from Chrome::setToolTip()
https://bugs.webkit.org/show_bug.cgi?id=54952

Remove the unnecessary condition from the if(), HTMLInputElement::files() always return
a valid reference for the input type FileInputType.

  • page/Chrome.cpp: (WebCore::Chrome::setToolTip):
5:25 AM Changeset in webkit [79316] by benjamin.poulain@nokia.com
  • 6 edits in trunk/Source/WebKit2

2011-02-22 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [WK2] Improve the memory handling of the context menu for WebKit 2
https://bugs.webkit.org/show_bug.cgi?id=54902

Refactor the context menu handling of Qt to make it simpler to manage memory.

WebContextMenuProxyQt uses smart pointer for all the references to menu so
there is no need to delete it explicitely.

Passing the QMenu from QWKPage to the client of the signal now uses a QSharedPointer so
the client can choose to handle the memory, but there is no leak if it does not.

  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::QGraphicsWKView): (QGraphicsWKView::showContextMenu):
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/qt/WebContextMenuProxyQt.cpp: (WebKit::WebContextMenuProxyQt::showContextMenu): (WebKit::WebContextMenuProxyQt::createContextMenu):
  • UIProcess/qt/WebContextMenuProxyQt.h:
5:20 AM Changeset in webkit [79315] by Philippe Normand
  • 1 edit in trunk/LayoutTests/ChangeLog

2011-02-22 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip crashing inspector test on GTK

  • platform/gtk/Skipped: Skip http/tests/inspector-enabled/open-close-open.html
5:20 AM Changeset in webkit [79314] by Philippe Normand
  • 1 edit in trunk/Source/WebCore/ChangeLog

2011-02-22 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=54943

Added new headers and removed references to deleted files.

  • GNUmakefile.am:

2011-02-22 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=54943

Removed reference to NotImplemented.h which was removed.

  • GNUmakefile.am:
5:20 AM Changeset in webkit [79313] by Philippe Normand
  • 1 edit in trunk/Source/WebCore/ChangeLog

2011-02-22 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: provide a button to expand inspector toolbar when not all panel buttons fit
https://bugs.webkit.org/show_bug.cgi?id=54671

  • factored toolbar handling out of inspector.js
  • added toolbar dropdown
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onCreatePanel):
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.get toolbarItem):
  • inspector/front-end/Toolbar.js: Added. (WebInspector.Toolbar): (WebInspector.Toolbar.prototype.resize): (WebInspector.Toolbar.prototype.addPanel): (WebInspector.Toolbar.prototype._toolbarDragStart): (WebInspector.Toolbar.prototype._toolbarDragEnd): (WebInspector.Toolbar.prototype._toolbarDrag): (WebInspector.Toolbar.prototype._onClose): (WebInspector.Toolbar.prototype._setDropdownVisible): (WebInspector.Toolbar.prototype._toggleDropdown): (WebInspector.Toolbar.prototype._updateDropdownButtonAndHideDropdown): (WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked): (WebInspector.Toolbar.createPanelToolbarItem): (WebInspector.ToolbarDropdown): (WebInspector.ToolbarDropdown.prototype.show): (WebInspector.ToolbarDropdown.prototype.hide): (WebInspector.ToolbarDropdown.prototype.get visible): (WebInspector.ToolbarDropdown.prototype._populate): (WebInspector.ToolbarDropdown.prototype._onKeyDown):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (#toolbar): (.toolbar-item): (.toolbar-item.toggleable): (.toolbar-item.toggleable.toggled-on): (#toolbar-dropdown .toolbar-icon): (#toolbar-dropdown .toolbar-label): (#toolbar-controls): (#toolbar-dropdown-arrow): (body.attached #toolbar-dropdown-arrow): (#toolbar-dropdown-arrow.dropdown-visible): (#toolbar-dropdown-arrow:hover): (#toolbar-dropdown-arrow:active): (#toolbar-dropdown): (body.detached.platform-mac-snowleopard #toolbar-dropdown): (#toolbar-dropdown .scrollable-content): (#toolbar-dropdown .toolbar-item): (#toolbar-dropdown .toolbar-item.toggleable.toggled-on): (#toolbar-dropdown .toolbar-icon): (#toolbar-dropdown .toolbar-label): (#toolbar-controls): (#toolbar-dropdown-arrow): (body.attached #toolbar-dropdown-arrow): (#toolbar-dropdown-arrow.dropdown-visible): (#toolbar-dropdown-arrow:hover): (#toolbar-dropdown-arrow:active): (#toolbar-dropdown): (body.detached.platform-mac-snowleopard #toolbar-dropdown): (#toolbar-dropdown .scrollable-content): (#toolbar-dropdown .toolbar-item): (#toolbar-dropdown .toolbar-item.toggleable.toggled-on): (#toolbar-dropdown .toolbar-item:hover): (#toolbar-dropdown .toolbar-item.toggleable.toggled-on:hover): (#toolbar-dropdown .toolbar-item:active .toolbar-icon): (.scrollable-content): (.scrollable-content::-webkit-scrollbar): (.scrollable-content::-webkit-resizer): (.scrollable-content::-webkit-scrollbar-thumb:vertical): (.scrollable-content::-webkit-scrollbar-thumb:vertical:active): (.scrollable-content::-webkit-scrollbar-track:vertical): (.toolbar-search-item): (#search): (body.attached #search): (#search-results-matches): (#close-button-left, #close-button-right): (.close-left):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.set attached): (WebInspector.addPanel): (WebInspector.windowResize):
5:20 AM Changeset in webkit [79312] by Philippe Normand
  • 2 edits in trunk

Unreviewed.

[Qt] Add Qt specific expected results for passing tables/mozilla tests.

  • platform/qt/Skipped: Unskip passing tests.
  • platform/qt/tables/mozilla [...] : Added.
5:17 AM Changeset in webkit [79311] by podivilov@chromium.org
  • 11 edits
    3 adds in trunk

2011-02-21 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move source mapping from SourceFrame to ScriptsPanel.
https://bugs.webkit.org/show_bug.cgi?id=54645

  • http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite.createWrapper.return.try): (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite): (initialize_DebuggerTest.InspectorTest.showScriptSource):
  • inspector/debugger/source-frame-expected.txt: Added.
  • inspector/debugger/source-frame.html: Added.

2011-02-21 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract source mapping from SourceFrame to DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=54645

This is needed to map one script to several source files.

Test: inspector/debugger/source-frame.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DebuggerPresentationModel.js: Added. (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceName): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved): (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved): (WebInspector.DebuggerPresentationModel.prototype._encodeSourceLocation): (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._breakpointAdded): (WebInspector.ScriptsPanel.prototype._breakpointRemoved): (WebInspector.ScriptsPanel.prototype._sourceFrameForResource): (WebInspector.ScriptsPanel.prototype._sourceFrameForScript): (WebInspector.ScriptsPanel.prototype._addSourceFrame): (WebInspector.ScriptsPanel.prototype._removeSourceFrame): (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded): (WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.SourceFrameContentProviderForScript.prototype._buildSource):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.get loaded): (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype._setTextViewerDecorations): (WebInspector.SourceFrame.prototype.setExecutionLine): (WebInspector.SourceFrame.prototype.clearExecutionLine): (WebInspector.SourceFrame.prototype.addBreakpoint): (WebInspector.SourceFrame.prototype.removeBreakpoint): (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition): (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint): (WebInspector.SourceFrame.prototype._findBreakpoint.filter): (WebInspector.SourceFrame.prototype._findBreakpoint):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

2011-02-21 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move source mapping from SourceFrame to ScriptsPanel.
https://bugs.webkit.org/show_bug.cgi?id=54645

  • src/js/Tests.js: (.TestSuite.prototype._checkExecutionLine):
5:11 AM Changeset in webkit [79310] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-22 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK rebaseline of fast/forms/placeholder-position.html

  • platform/gtk/fast/forms/placeholder-position-expected.txt:
5:08 AM Changeset in webkit [79309] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-22 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK rebaseline of media/video-aspect-ratio.html

  • platform/gtk/media/video-aspect-ratio-expected.txt:
5:06 AM Changeset in webkit [79308] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-22 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip crashing inspector test on GTK

  • platform/gtk/Skipped: Skip http/tests/inspector-enabled/open-close-open.html
5:05 AM Changeset in webkit [79307] by Philippe Normand
  • 1 edit in trunk/Source/WebCore/ChangeLog

2011-02-22 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=54943

Added new headers and removed references to deleted files.

  • GNUmakefile.am:

2011-02-22 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=54943

Removed reference to NotImplemented.h which was removed.

  • GNUmakefile.am:
4:16 AM Changeset in webkit [79306] by caseq@chromium.org
  • 9 edits
    1 add in trunk/Source/WebCore

2011-02-22 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: provide a button to expand inspector toolbar when not all panel buttons fit
https://bugs.webkit.org/show_bug.cgi?id=54671

  • factored toolbar handling out of inspector.js
  • added toolbar dropdown
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onCreatePanel):
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.get toolbarItem):
  • inspector/front-end/Toolbar.js: Added. (WebInspector.Toolbar): (WebInspector.Toolbar.prototype.resize): (WebInspector.Toolbar.prototype.addPanel): (WebInspector.Toolbar.prototype._toolbarDragStart): (WebInspector.Toolbar.prototype._toolbarDragEnd): (WebInspector.Toolbar.prototype._toolbarDrag): (WebInspector.Toolbar.prototype._onClose): (WebInspector.Toolbar.prototype._setDropdownVisible): (WebInspector.Toolbar.prototype._toggleDropdown): (WebInspector.Toolbar.prototype._updateDropdownButtonAndHideDropdown): (WebInspector.Toolbar.createPanelToolbarItem.onToolbarItemClicked): (WebInspector.Toolbar.createPanelToolbarItem): (WebInspector.ToolbarDropdown): (WebInspector.ToolbarDropdown.prototype.show): (WebInspector.ToolbarDropdown.prototype.hide): (WebInspector.ToolbarDropdown.prototype.get visible): (WebInspector.ToolbarDropdown.prototype._populate): (WebInspector.ToolbarDropdown.prototype._onKeyDown):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (#toolbar): (.toolbar-item): (.toolbar-item.toggleable): (.toolbar-item.toggleable.toggled-on): (#toolbar-dropdown .toolbar-icon): (#toolbar-dropdown .toolbar-label): (#toolbar-controls): (#toolbar-dropdown-arrow): (body.attached #toolbar-dropdown-arrow): (#toolbar-dropdown-arrow.dropdown-visible): (#toolbar-dropdown-arrow:hover): (#toolbar-dropdown-arrow:active): (#toolbar-dropdown): (body.detached.platform-mac-snowleopard #toolbar-dropdown): (#toolbar-dropdown .scrollable-content): (#toolbar-dropdown .toolbar-item): (#toolbar-dropdown .toolbar-item.toggleable.toggled-on): (#toolbar-dropdown .toolbar-icon): (#toolbar-dropdown .toolbar-label): (#toolbar-controls): (#toolbar-dropdown-arrow): (body.attached #toolbar-dropdown-arrow): (#toolbar-dropdown-arrow.dropdown-visible): (#toolbar-dropdown-arrow:hover): (#toolbar-dropdown-arrow:active): (#toolbar-dropdown): (body.detached.platform-mac-snowleopard #toolbar-dropdown): (#toolbar-dropdown .scrollable-content): (#toolbar-dropdown .toolbar-item): (#toolbar-dropdown .toolbar-item.toggleable.toggled-on): (#toolbar-dropdown .toolbar-item:hover): (#toolbar-dropdown .toolbar-item.toggleable.toggled-on:hover): (#toolbar-dropdown .toolbar-item:active .toolbar-icon): (.scrollable-content): (.scrollable-content::-webkit-scrollbar): (.scrollable-content::-webkit-resizer): (.scrollable-content::-webkit-scrollbar-thumb:vertical): (.scrollable-content::-webkit-scrollbar-thumb:vertical:active): (.scrollable-content::-webkit-scrollbar-track:vertical): (.toolbar-search-item): (#search): (body.attached #search): (#search-results-matches): (#close-button-left, #close-button-right): (.close-left):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.set attached): (WebInspector.addPanel): (WebInspector.windowResize):
4:12 AM Changeset in webkit [79305] by Csaba Osztrogonác
  • 359 edits
    737 adds in trunk/LayoutTests

Unreviewed.

[Qt] Add Qt specific expected results for passing tables/mozilla tests.

  • platform/qt/Skipped: Unskip passing tests.
  • platform/qt/tables/mozilla [...] : Added.
3:11 AM Changeset in webkit [79304] by Philippe Normand
  • 4 edits in trunk/Source

2011-02-22 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=54943

Added new headers and removed references to deleted files.

  • GNUmakefile.am:

2011-02-22 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=54943

Removed reference to NotImplemented.h which was removed.

  • GNUmakefile.am:
1:34 AM Changeset in webkit [79303] by yurys@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-02-21 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: make DOM storage and Database agents have the same lifetime as InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=54891

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::createFrontendLifetimeAgents): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad):
  • inspector/InspectorAgent.h: (WebCore::InspectorAgent::instrumentingAgents):
  • inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::setFrontend): (WebCore::InspectorDOMStorageAgent::clearFrontend): (WebCore::InspectorDOMStorageAgent::selectDOMStorage): (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId): (WebCore::InspectorDOMStorageAgent::didUseDOMStorage): (WebCore::InspectorDOMStorageAgent::clearResources):
  • inspector/InspectorDOMStorageAgent.h: (WebCore::InspectorDOMStorageAgent::create):
  • inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::didOpenDatabase): (WebCore::InspectorDatabaseAgent::clearResources): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::setFrontend): (WebCore::InspectorDatabaseAgent::clearFrontend): (WebCore::InspectorDatabaseAgent::databaseForId): (WebCore::InspectorDatabaseAgent::selectDatabase):
  • inspector/InspectorDatabaseAgent.h: (WebCore::InspectorDatabaseAgent::create):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didOpenDatabaseImpl): (WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
1:12 AM Changeset in webkit [79302] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-02-22 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtWebProcess should be installed with 'make install'
https://bugs.webkit.org/show_bug.cgi?id=44100

Follow the standard in other project files and allow install
location to be changed with INSTALL_BINS variable.

  • WebProcess.pro: Install QtWebProcess.
1:03 AM Changeset in webkit [79301] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

2011-02-22 Steve Lacey <sjl@chromium.org>

Reviewed by Darin Fisher.

Rename new media statistics apis to better names

https://bugs.webkit.org/show_bug.cgi?id=54784

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::webkitAudioDecodedByteCount): (WebCore::HTMLMediaElement::webkitVideoDecodedByteCount):
  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::webkitDecodedFrameCount): (WebCore::HTMLVideoElement::webkitDroppedFrameCount):
  • html/HTMLVideoElement.h:
  • html/HTMLVideoElement.idl:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::decodedFrameCount): (WebCore::MediaPlayer::droppedFrameCount): (WebCore::MediaPlayer::audioDecodedByteCount): (WebCore::MediaPlayer::videoDecodedByteCount):
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::decodedFrameCount): (WebCore::MediaPlayerPrivateInterface::droppedFrameCount): (WebCore::MediaPlayerPrivateInterface::audioDecodedByteCount): (WebCore::MediaPlayerPrivateInterface::videoDecodedByteCount):
12:41 AM Changeset in webkit [79300] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-22 MORITA Hajime <morrita@google.com>

Unreviewed test_expectation.txt update.

Removed more BUGWK54736 lines which are no longer failed.

  • platform/chromium/test_expectations.txt:
12:32 AM Changeset in webkit [79299] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-22 MORITA Hajime <morrita@google.com>

Unreviewed test_expectation.txt update.

Mark styles-update-from-js.html as flaky.

  • platform/chromium/test_expectations.txt:
12:23 AM Changeset in webkit [79298] by rolandsteiner@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-21 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Kent Tamura.

Bug 54435 - Simplify CSSStyleSelector::canShareStyleWithElement
https://bugs.webkit.org/show_bug.cgi?id=54435

Changed the function to a series of early-exit 'if's,
removed most temporary variables.

No new tests. (refactoring)

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement):
12:18 AM Changeset in webkit [79297] by kbalazs@webkit.org
  • 60 edits
    1 copy in trunk/Source/WebKit2

Unreviewed, rolling out r79296.
http://trac.webkit.org/changeset/79296
https://bugs.webkit.org/show_bug.cgi?id=54941

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-02-22
Breaks compilation on SnowLeapard Intel Release (Requested by
kbalazs_ on #webkit).

  • Platform/gtk/SharedMemoryGtk.cpp:
  • Platform/gtk/WorkQueueGtk.cpp:
  • Platform/qt/WorkQueueQt.cpp:
  • Platform/win/WorkQueueWin.cpp:
  • Shared/NotImplemented.h: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
  • Shared/Plugins/NPIdentifierData.cpp:
  • Shared/Plugins/NPRemoteObjectMap.cpp:
  • Shared/Plugins/NPVariantData.cpp:
  • Shared/cairo/ShareableBitmapCairo.cpp:
  • Shared/gtk/ShareableBitmapGtk.cpp:
  • Shared/gtk/WebCoreArgumentCodersGtk.cpp:
  • Shared/qt/WebCoreArgumentCodersQt.cpp:
  • Shared/win/LayerTreeContextWin.cpp:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/API/qt/qwkpage.cpp:
  • UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp:
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
  • UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):

  • UIProcess/WebInspectorProxy.cpp:
  • UIProcess/gtk/TextCheckerGtk.cpp:
  • UIProcess/gtk/WebInspectorGtk.cpp:
  • UIProcess/gtk/WebPreferencesGtk.cpp:
  • UIProcess/qt/TextCheckerQt.cpp:
  • UIProcess/qt/WebInspectorProxyQt.cpp:
  • UIProcess/win/TextCheckerWin.cpp:
  • UIProcess/win/WebContextMenuProxyWin.cpp:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Downloads/cf/DownloadCFNet.cpp:
  • WebProcess/Downloads/curl/DownloadCurl.cpp:
  • WebProcess/Downloads/mac/DownloadMac.mm:
  • WebProcess/Downloads/qt/DownloadQt.cpp:
  • WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:
  • WebProcess/Plugins/Netscape/NPJSObject.cpp:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
  • WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp:
  • WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
  • WebProcess/WebCoreSupport/WebDragClient.cpp:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:
  • WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp:
  • WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
  • WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp:
  • WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
  • WebProcess/WebPage/qt/WebInspectorQt.cpp:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

  • WebProcess/gtk/WebProcessGtk.cpp:
  • config.h:
  • win/WebKit2.vcproj:

Feb 21, 2011:

11:42 PM Changeset in webkit [79296] by kbalazs@webkit.org
  • 60 edits
    1 delete in trunk/Source/WebKit2

notImplemented() should behave identical in WebCore and WebKit2 https://bugs.webkit.org/show_bug.cgi?id=54449

Reviewed by Anders Carlsson.

Use NotImplemented.h from WebCore. Initialize logging channels.
Remove the WebKit2 concept of notImplemented().

  • Platform/gtk/SharedMemoryGtk.cpp:
  • Platform/gtk/WorkQueueGtk.cpp:
  • Platform/qt/WorkQueueQt.cpp:
  • Platform/win/WorkQueueWin.cpp:
  • Shared/NotImplemented.h: Removed.
  • Shared/Plugins/NPIdentifierData.cpp:
  • Shared/Plugins/NPRemoteObjectMap.cpp:
  • Shared/Plugins/NPVariantData.cpp:
  • Shared/cairo/ShareableBitmapCairo.cpp:
  • Shared/gtk/ShareableBitmapGtk.cpp:
  • Shared/gtk/WebCoreArgumentCodersGtk.cpp:
  • Shared/qt/WebCoreArgumentCodersQt.cpp:
  • Shared/win/LayerTreeContextWin.cpp:
  • UIProcess/API/qt/qwkpage.cpp:
  • UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp:
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
  • UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):

  • UIProcess/WebInspectorProxy.cpp:
  • UIProcess/gtk/TextCheckerGtk.cpp:
  • UIProcess/gtk/WebInspectorGtk.cpp:
  • UIProcess/gtk/WebPreferencesGtk.cpp:
  • UIProcess/qt/TextCheckerQt.cpp:
  • UIProcess/qt/WebInspectorProxyQt.cpp:
  • UIProcess/win/TextCheckerWin.cpp:
  • UIProcess/win/WebContextMenuProxyWin.cpp:
  • WebKit2.pro:
  • WebProcess/Downloads/cf/DownloadCFNet.cpp:
  • WebProcess/Downloads/curl/DownloadCurl.cpp:
  • WebProcess/Downloads/mac/DownloadMac.mm:
  • WebProcess/Downloads/qt/DownloadQt.cpp:
  • WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:
  • WebProcess/Plugins/Netscape/NPJSObject.cpp:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
  • WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp:
  • WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
  • WebProcess/WebCoreSupport/WebDragClient.cpp:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:
  • WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp:
  • WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
  • WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp:
  • WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
  • WebProcess/WebPage/qt/WebInspectorQt.cpp:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

  • WebProcess/gtk/WebProcessGtk.cpp:
11:21 PM Changeset in webkit [79295] by commit-queue@webkit.org
  • 4 edits in trunk

2011-02-21 Lukasz Slachciak <l.slachciak@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Fixed missing spatial navigation setting initialization. Doxygen comments added.
https://bugs.webkit.org/show_bug.cgi?id=54806

  • ewk/ewk_view.cpp: (_ewk_view_priv_new): spatial navigation setting initialization added

2011-02-21 Lukasz Slachciak <l.slachciak@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Restored spatial navigation option in EWebLauncher since #18662 bug is closed
https://bugs.webkit.org/show_bug.cgi?id=54806

  • EWebLauncher/main.c: (on_key_down): calling ewk_view_setting_spatial_navigation_set when "F12" pressed added.
11:05 PM Changeset in webkit [79294] by thakis@chromium.org
  • 5 edits in trunk/Source

2011-02-21 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] PopupContainer::show() confuses clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54923

Rename PopupContainer::show() to showInRect(), to make it obvious it's
not an override of ScrollView::show().

No intended functionality change.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showInRect): (WebCore::PopupMenuChromium::show):
  • platform/chromium/PopupMenuChromium.h:

2011-02-21 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] PopupContainer::show() confuses clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54923

Rename PopupContainer::show() to showInRect(), to make it obvious it's
not an override of ScrollView::show().

No intended functionality change.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::applyAutoFillSuggestions):
10:48 PM Changeset in webkit [79293] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-21 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Antti Koivisto.

Improve the local{SharedStyle,CousinList} algorithm
https://bugs.webkit.org/show_bug.cgi?id=45507

This change improves the algorithm to find shared styles: the old
algorithm would stop the search after the first cousin, even if
the search threshold is not met. As such, the algorithm would
systematically miss sharings across second cousins and beyond.
The new algorithm continues the search, as long as threshold is
not met. It also separates the threshold for sibling/cousins
search, from that on the levels of search, which is easier to
optimize.
The new algorithm finds up to 30% more sharings on some sites
(e.g. amazon.com and rakuten.co.jp) with no noticeable slowdown.

No new test, refactoring only.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::locateCousinList): (WebCore::CSSStyleSelector::locateSharedStyle): While changing the algorithm, cleaned up the style of those 2 methods (use early return, renamed some variables).
  • css/CSSStyleSelector.h:
10:46 PM Changeset in webkit [79292] by thakis@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-02-21 Nico Weber <thakis@chromium.org>

Reviewed by Adam Barth.

RenderTableCell::baselinePosition() confuses clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54922

RenderTableCell::baselinePosition() has the same name as a virtual
method in superclass RenderBlock. Rename the subclass method to make
it clear it's not an attempted override.

No intended functionality change.

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::cellBaselinePosition):
  • rendering/RenderTableCell.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::calcRowLogicalHeight): (WebCore::RenderTableSection::layoutRows):
10:45 PM Changeset in webkit [79291] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-21 MORITA Hajime <morrita@google.com>

Unreviewed test_expectation.txt update.

r79285 removes too much lines. recover failed one.

  • platform/chromium/test_expectations.txt:
10:24 PM Changeset in webkit [79290] by kalman@chromium.org
  • 5 edits in trunk

2011-02-21 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ryosuke Niwa.

Extending selection by a boundary granularity (LineBoundary/ParagraphBoundary/DocumentBoundary) sets incorrect
start/end of selection for RTL
https://bugs.webkit.org/show_bug.cgi?id=54724

Augment extend-left-by-lineboundary test to extend the selection twice, which triggered the bug.

  • editing/selection/extend-left-right-by-lineboundary-expected.txt:
  • editing/selection/extend-left-right-by-lineboundary.html:

2011-02-21 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ryosuke Niwa.

Extending selection by a boundary granularity (LineBoundary/ParagraphBoundary/DocumentBoundary) sets incorrect
start/end of selection for RTL
https://bugs.webkit.org/show_bug.cgi?id=54724

On mac, the selection should always grow when extending by a boundary granularity (line/paragraph/document).
This is achieved by extending from the start for the "left" direction (e.g. pressing left arrow key), or
extending from the end when for the "right" direction (e.g. pressing right arrow key).

However, this has a bug for RTL text, which should actually extend from the *end* when extending left (since
direction is obviously reversed) and likewise extend from the start when extending right.

  • editing/SelectionController.cpp: (WebCore::SelectionController::modify):
10:19 PM Changeset in webkit [79289] by morrita@google.com
  • 10 edits in trunk/LayoutTests

2011-02-21 MORITA Hajime <morrita@google.com>

Unreviewed expectation rebaseline for r79284.

  • platform/chromium-linux/fast/forms/placeholder-position-expected.checksum:
  • platform/chromium-linux/fast/forms/placeholder-position-expected.png:
  • platform/chromium-linux/fast/forms/search-styled-expected.checksum:
  • platform/chromium-linux/fast/forms/search-styled-expected.png:
  • platform/chromium-win/fast/forms/placeholder-position-expected.checksum:
  • platform/chromium-win/fast/forms/placeholder-position-expected.png:
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt:
  • platform/chromium-win/fast/forms/search-styled-expected.checksum:
  • platform/chromium-win/fast/forms/search-styled-expected.png:
10:10 PM Changeset in webkit [79288] by thakis@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-02-21 Nico Weber <thakis@chromium.org>

Reviewed by Adam Barth.

ImageDocument::imageChanged() confuses clang's -Woverride-virtual
https://bugs.webkit.org/show_bug.cgi?id=54924

Rename ImageDocument::imageChanged() to imageUpdated() to make clear
that it's not an override of CachedResourceClient::imageChanged().

  • html/ImageDocument.cpp: (WebCore::ImageDocumentParser::appendBytes): (WebCore::ImageDocumentParser::finish): (WebCore::ImageDocument::imageUpdated):
  • html/ImageDocument.h:
9:58 PM Changeset in webkit [79287] by rolandsteiner@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-02-21 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Kent Tamura.

Bug 54934 - Sort the WebCore project file(s)
https://bugs.webkit.org/show_bug.cgi?id=54934

No new tests. (no code affected)

  • GNUmakefile.am:
  • WebCore.xcodeproj/project.pbxproj:
9:51 PM Changeset in webkit [79286] by thakis@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-02-21 Nico Weber <thakis@chromium.org>

Reviewed by Adam Barth.

canAccommodateEllipsis() confuses clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54909

Rename the overload in RootInlineBox to lineCanAccomodateEllipsis() to
unconfuse clang. No intended functionality change.

  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::checkLinesForTextOverflow):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::applyLineClamp):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::lineCanAccommodateEllipsis):
  • rendering/RootInlineBox.h:
9:14 PM Changeset in webkit [79285] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-21 MORITA Hajime <morrita@google.com>

Unreviewed test_expectation.txt update.

Removed BUGWK54736 lines which are no longer failed.

  • platform/chromium/test_expectations.txt:
8:56 PM Changeset in webkit [79284] by adele@apple.com
  • 7 edits in trunk

Source/WebCore: Fix for for https://bugs.webkit.org/show_bug.cgi?id=54402
REGRESSION (r72052): Placeholder text doesn't have the right padding for search fields on Windows

Reviewed by Dan Bernstein.

Test: updated fast/forms/placeholder-position.html and tested manually

Consider padding and margin for the results and cancel buttons. This is important for the Windows
theme which uses padding to correctly position those buttons. This change fixes the placeholder
position, and also better aligns the results popup list with the actual text you type.

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=54402
REGRESSION (r72052): Placeholder text doesn't have the right padding for search fields on Windows

Reviewed by Dan Bernstein.

Unfortunately, this doesn't test the Windows theme, since DRT uses the Safari theme, but I also tested this change manually on Windows and Mac.

  • fast/forms/placeholder-position.html: Added a case for a search field with the results button.
  • platform/mac/fast/forms/placeholder-position-expected.checksum:
  • platform/mac/fast/forms/placeholder-position-expected.png:
  • platform/mac/fast/forms/placeholder-position-expected.txt:
7:59 PM Changeset in webkit [79283] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-21 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] focus comment on accept
https://bugs.webkit.org/show_bug.cgi?id=54930

  • code-review.js:
7:57 PM Changeset in webkit [79282] by thakis@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-02-21 Nico Weber <thakis@chromium.org>

Reviewed by Kent Tamura.

GIFImageDecoder::setSize() tries to override the superclass method but fails
https://bugs.webkit.org/show_bug.cgi?id=54305

The superclass uses unsigned instead of int for its parameters, so
GIFImageDecoder::setSize() was an overload, not an override.

  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::setSize):
  • platform/image-decoders/gif/GIFImageDecoder.h:
7:44 PM Changeset in webkit [79281] by dpranke@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-21 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

This patch changes a test to work around a bug in PrettyPatch where
it will crash if lines starting with "--" are missing from the actual
output. The actual fix needed to PrettyPatch is described in the
bug.

https://bugs.webkit.org/show_bug.cgi?id=54918

  • platform/mac/fast/objc/dom-html-select-activate-expected.txt:
  • platform/mac/fast/objc/dom-html-select-activate.html:
7:38 PM Changeset in webkit [79280] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] avoid overriding ctrl/cmd + r
https://bugs.webkit.org/show_bug.cgi?id=54852

  • code-review.js:
7:31 PM Changeset in webkit [79279] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-02-21 Dirk Pranke <dpranke@chromium.org>

Reviewed by Kent Tamura.

nrwt: revert behavior on 10.5 to "old-threads". It's possible
that r79062 has introduced a bunch of flakiness, although I
can't explain why right now. This change should restore the
old behavior, and then we can look at the build logs to see
if the tests stop timing out or being flaky.

https://bugs.webkit.org/show_bug.cgi?id=54925

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
6:28 PM Changeset in webkit [79278] by rniwa@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-02-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Deploy EditingStyle more in ApplyStyleCommand and do some cleanup
https://bugs.webkit.org/show_bug.cgi?id=54528

  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): Allows style to be a null pointer. (WebCore::ApplyStyleCommand::applyInlineStyle): Overrides the value of text-decoration property by that of -webkit-text-decorations-in-effect and remove the latter property when present. This allows removeImplicitlyStyledElement to ignore -webkit-text-decorations-in-effect. Also uses the return value of EditingStyle::textDirection to determine whether or not we need to apply unicode-bidi / direction instead of directly checking the value of unicode-bidi property. (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): Takes EditingStyle* instead of CSSMutableStyleDeclaration*. (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Ditto. (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Ditto. (WebCore::ApplyStyleCommand::removeCSSStyle): Ditto. (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): Ditto. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Ditto. (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto; no longer collapse text decoration properties because ApplyStyleCommand::applyInlineStyle already does it.
  • editing/ApplyStyleCommand.h:
  • editing/EditingStyle.cpp: (WebCore::EditingStyle::textDirection): Exits early when m_mutableStyle is null. (WebCore::EditingStyle::collapseTextDecorationProperties): Extracted from ApplyStyleCommand::removeInlineStyle.
  • editing/EditingStyle.h:
6:14 PM Changeset in webkit [79277] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

<http://webkit.org/b/54919> / <rdar://problem/7689300> WebCore should retrieve unclamped frame delays from ImageIO

Reviewed by Darin Adler and Alexey Proskuryakov.

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::frameDurationAtIndex): Look for the unclamped frame delay in the
frame properties dictionary and use that if it exists. If it does not exist in the
dictionary then fall back to using the clamped frame delay.

6:08 PM Changeset in webkit [79276] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-21 Nico Weber <thakis@chromium.org>

Reviewed by Kent Tamura.

[chromium] ChromePluginPrintContext::begin() fails to override superclass method
https://bugs.webkit.org/show_bug.cgi?id=54914

Update subclass method signature to match superclass again. This
regressed in http://trac.webkit.org/changeset/71964

  • src/WebFrameImpl.cpp: (WebKit::ChromePluginPrintContext::begin):
6:07 PM Changeset in webkit [79275] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-21 MORITA Hajime <morrita@google.com>

Unreviewed test_expectation.txt update.

Disabled "BUGWK54322 MAC SNOWLEOPARD" lines, which sesms no longer needed.

  • platform/chromium/test_expectations.txt:
6:01 PM Changeset in webkit [79274] by timothy@apple.com
  • 1 edit in trunk/Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp

Fix Windows build.

5:43 PM Changeset in webkit [79273] by timothy@apple.com
  • 11 edits in trunk/Source/WebKit2

Set and update the window title for the Web Inspector in WebKit2.

https://webkit.org/b/50945
rdar://problem/8762410

Reviewed by Adam Roben.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::inspectedURLChanged): Added. Call platformInspectedURLChanged.

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/WebInspectorProxy.messages.in: Added InspectedURLChanged.
  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Set the window title.

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Set the window title.

  • UIProcess/gtk/WebInspectorGtk.cpp:

(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Not implemented.

  • UIProcess/qt/WebInspectorProxyQt.cpp:

(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Not implemented.

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:

(WebKit::WebInspectorFrontendClient::inspectedURLChanged): Call WebInspector::inspectedURLChanged.

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::inspectedURLChanged): Added. Send the InspectedURLChanged message.

  • WebProcess/WebPage/WebInspector.h:
5:40 PM Changeset in webkit [79272] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-21 MORITA Hajime <morrita@google.com>

Unreviewed test_expectation.txt clenaup.
Removed disabled lines which I commented out.

  • platform/chromium/test_expectations.txt:
5:32 PM Changeset in webkit [79271] by Lucas Forschler
  • 5 edits in branches/safari-534.20-branch/Source

Versioning.

5:28 PM Changeset in webkit [79270] by Lucas Forschler
  • 1 copy in tags/Safari-534.20.8

New tag.

5:27 PM Changeset in webkit [79269] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

2011-02-21 James Kozianski <koz@chromium.org>

Reviewed by Kent Tamura.

Causes elements to be unfocusable after tabindex property is removed.
https://bugs.webkit.org/show_bug.cgi?id=54727

  • fast/html/tabindex-removal-expected.txt: Added.
  • fast/html/tabindex-removal.html: Added.

2011-02-21 James Kozianski <koz@chromium.org>

Reviewed by Kent Tamura.

Causes elements to be unfocusable after tabindex property is removed.
https://bugs.webkit.org/show_bug.cgi?id=54727

Test: fast/html/tabindex-removal.html

  • dom/Node.cpp: (WebCore::Node::clearTabIndexExplicitly):
  • dom/Node.h:
  • dom/NodeRareData.h: (WebCore::NodeRareData::clearTabIndexExplicitly):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
5:23 PM Changeset in webkit [79268] by Lucas Forschler
  • 2 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78673.

5:23 PM Changeset in webkit [79267] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Reviewed by Mark Rowe.

<rdar://problem/8995483> Remove stubs of unneeded NSURLAuthenticationChallengeSender methods

  • platform/network/mac/AuthenticationMac.mm: Remove the stubs that are no longer needed.
5:22 PM Changeset in webkit [79266] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-21 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectations update.

Removed fast/js/kde/math.html because it has been passing since r79246.
Removed fast/text/capitalize-boundaries.html on Mac and Windows because it has been steadily passing.

  • platform/chromium/test_expectations.txt:
5:18 PM Changeset in webkit [79265] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

2011-02-21 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Overhang areas need to be invalidated on scroll
<rdar://problem/9032194>
https://bugs.webkit.org/show_bug.cgi?id=54917

  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): We need to explicitly invalidate the overhang areas when we scroll the contents of a ScrollView, since they could contain arbitrary content that cannot be blitted.
5:06 PM Changeset in webkit [79264] by rniwa@webkit.org
  • 3 edits
    2 copies in branches/chromium/648

Merge 78168 - 2011-02-09 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION(r76107): Crash in VisibleSelection::toNormalizedRange
https://bugs.webkit.org/show_bug.cgi?id=54053

The bug was caused by RenderBlock::positionForPoint's improperly returning a shadow node inside
RenderFileUploadControl for hit testing and VisibleSelection::toNormalizedRange's always assuming
the position variable "s" is not null.

Fixed the bug by always returning a null position from RenderFileUploadControl::positionForPoint,
and also exiting early when either "s" or "e" is null in VisibleSelection::toNormalizedRange.

Test: fast/forms/file-input-hit-test.html

  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::toNormalizedRange):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::positionForPoint):
  • rendering/RenderFileUploadControl.h:

2011-02-09 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION(r76107): Crash in VisibleSelection::toNormalizedRange
https://bugs.webkit.org/show_bug.cgi?id=54053

Added a test to ensure WebKit does not crash when a user clicks on a region immediately after a file
upload control.

  • fast/forms/file-input-hit-test-expected.txt: Added.
  • fast/forms/file-input-hit-test.html: Added.

TBR=rniwa@webkit.org
Review URL: http://codereview.chromium.org/6542053

5:01 PM Changeset in webkit [79263] by Lucas Forschler
  • 1 edit in trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
4:56 PM Changeset in webkit [79262] by Lucas Forschler
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fix the Leopard Debug build by incorporating the RenderSVGAllInOne.cpp

Reviewed by Stephanie Lewis.

No new tests required.

  • WebCore.xcodeproj/project.pbxproj:
4:13 PM Changeset in webkit [79261] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Remove global initializer in CookieStorageCFNet.cpp
https://bugs.webkit.org/show_bug.cgi?id=54905

Reviewed by Darin Adler.

  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::currentCookieStorage):
(WebCore::setCurrentCookieStorage):
(WebCore::setCookieStoragePrivateBrowsingEnabled):

3:57 PM Changeset in webkit [79260] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Can't paste from 3rd party text editor into WebKit2 window.
<rdar://problem/8978624>

Reviewed by Anders Carlsson.

  • WebProcess/com.apple.WebProcess.sb:
3:47 PM Changeset in webkit [79259] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-02-18 Jer Noble <jer.noble@apple.com>

Reviewed by Sam Weinig.

WebKit2: Media document videos play only sound, no video (affects trailers.apple.com)
https://bugs.webkit.org/show_bug.cgi?id=54771

Now that video is accelerated, we no longer need to special case
video playing within a media document.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode): (WebCore::MediaPlayerPrivateQTKit::supportsAcceleratedRendering):
3:42 PM Changeset in webkit [79258] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Fix linker warning on Windows

r79135 tried to export JSObject::s_info by adding it to JavaScriptCore.def. This is the
obvious way (since it's how we export functions), but unfortunately it doesn't work correct.
r79222 made us export it the right way (using the JS_EXPORTDATA macro), but forgot to remove
it from JavaScriptCore.def. This caused us to get linker warnings about exporting the symbol
multiple times.

Rubber-stamped by Anders Carlsson.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed JSObject::s_info.
3:34 PM Changeset in webkit [79257] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-02-21 Ami Fischman <fischman@chromium.org>

Reviewed by Eric Carlson.

Add regression test for clean shutdown during video playback.
DumpRenderTree used to crash if the test was ended while a video
was still playing. (http://crbug.com/72730).
https://bugs.webkit.org/show_bug.cgi?id=54888

  • media/video-plays-past-end-of-test-expected.txt: Added.
  • media/video-plays-past-end-of-test.html: Added.
3:29 PM Changeset in webkit [79256] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-21 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Initialize DrawingAreaProxy::m_size
https://bugs.webkit.org/show_bug.cgi?id=54913

This was removed in r76962 since it caused flashes when switching drawing areas due to
entering and exiting composited mode, but since we no longer switch drawing areas we can
put it back.

  • UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::DrawingAreaProxy):
3:21 PM Changeset in webkit [79255] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Add some assertions about the state IDs we receive from the web process

Rubber-stamped by Anders Carlsson.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::update):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
Assert that the state ID the web process sent us is no newer than our own state ID.

3:20 PM Changeset in webkit [79254] by Adam Roben
  • 9 edits in trunk/Source/WebKit2

Rename DrawingArea[Proxy]Impl's "sequence number" concept to "state ID".

As explained in r79251, DrawingAreaProxyImpl has some state that, when it changes, causes
all operations performed before that state change to become invalid. Currently, this state
consists of a single piece of data: the view's size. Eventually it will encompass more data
(e.g., the backing store we're drawing into; when we start throwing away the backing store
to save memory, our state will have changed, and any operations that were intended for the
old backing store will have become invalid). r79251 effectively transformed
DrawingArea[Proxy]Impl's "sequence number," which incremented every time DrawingAreaImpl
sent DrawingAreaProxyImpl a message, to a "state ID," which only increments when the view's
size changes.

This patch is just a set of simple renames to reflect the transformation that r79251
effected. It should not introduce any changes in behavior. The renames are:

  • Messages::DrawingArea::SetSize -> UpdateState
  • Messages::DrawingAreaProxy::DidSetSize -> DidUpdateState
  • DrawingAreaProxyImpl::m_lastDidSetSizeSequenceNumber -> m_currentStateID
  • DrawingAreaProxyImpl::m_isWaitingForDidSetSize -> m_isWaitingForDidUpdateState
  • DrawingAreaProxyImpl::waitForAndDispatchDidSetSize -> waitForAndDispatchDidUpdateState
  • DrawingAreaImpl::m_inSetSize -> m_inUpdateState
  • generateSequenceNumber -> generateStateID
  • sequenceNumber -> stateID

Fixes <http://webkit.org/b/54911> DrawingArea[Proxy]Impl's "sequence number" concept should
be renamed to "state ID"

Reviewed by Anders Carlsson.

  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxy.messages.in:
  • UIProcess/DrawingAreaProxyImpl.cpp:
  • UIProcess/DrawingAreaProxyImpl.h:
  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingArea.messages.in:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/DrawingAreaImpl.h:

Performed the renames described above.

2:47 PM Changeset in webkit [79253] by ap@apple.com
  • 19 edits in trunk/Source

Reviewed by Adam Roben.

REGRESSION (WebKit2): HTTP requests time out after 60 seconds
https://bugs.webkit.org/show_bug.cgi?id=54755
<rdar://problem/9006592>

WebCore:

It's now possible to set a default timeout to be used at ResourceRequest creation. If one
hasn't been set, ResourceRequest will behave as before (use NSURLRequest default on Mac,
or use INT_MAX on other platforms).

  • WebCore.exp.in:
  • platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::defaultTimeoutInterval): Get the ResourceRequest notion of default timeout interval (may be 0 if using NSURLRequest default). (WebCore::ResourceRequestBase::setDefaultTimeoutInterval): Set the static member variable. (WebCore::ResourceRequestBase::updatePlatformRequest): Added an assertion that resource request is updated. Plaform code often calls updateResourceRequest() indirectly from this function, and that must obviously be a no-op. (WebCore::ResourceRequestBase::updateResourceRequest): Added an assertion in the opposite direction.
  • platform/network/ResourceRequestBase.h: Changed "unspecifiedTimeoutInterval" to "defaultTimeoutInterval". It has been used as default by most platforms anyway. (WebCore::ResourceRequestBase::ResourceRequestBase):
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Now zero is the magic value, not INT_MAX. We'll use NSURLRequest default if neither setTimeoutInterval() nor setDefaultTimeoutInterval() has been called.

WebKit2:

  • Shared/API/c/WKURLRequest.cpp: (WKURLRequestSetDefaultTimeoutInterval):
  • Shared/API/c/WKURLRequest.h: Added an API to set a default timeout interval for requests created from URLs. The API affects both the UI process and requests created internally by the Web process. Requests created from NSURLRequest or CFURLRequest take timeout from those.
  • Shared/WebURLRequest.cpp: (WebKit::WebURLRequest::setDefaultTimeoutInterval):
  • Shared/WebURLRequest.h: Pipe the default timeout interval from WKURLRequest down to actual implementation. Since WebURLRequest is currently implemented with WebCore::ResourceRequest, it automatically respects NSURLRequest default timeout interval.
  • UIProcess/WebProcessManager.cpp: (WebKit::WebProcessManager::getAllWebProcessContexts):
  • UIProcess/WebProcessManager.h: Added a way to enumerate all contexts running in separate processes.
  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::WebProcessCreationParameters): (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
  • Shared/WebProcessCreationParameters.h: (WebKit::WebContext::ensureWebProcess): (WebKit::WebContext::setDefaultRequestTimeoutInterval):
  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess): (WebKit::WebProcess::setDefaultRequestTimeoutInterval):
  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in: Use UI process default timeout interval in separate process contexts, too.
2:26 PM Changeset in webkit [79252] by bweinstein@apple.com
  • 13 edits
    2 adds in trunk

Source/JavaScriptCore: WebResourceCacheManager should be responsible for managing the CFURLCache as well
as the WebCore memory cache.
https://bugs.webkit.org/show_bug.cgi?id=54886
Part of <rdar://problem/8971738>

Reviewed by Adam Roben.

Add a new use flag for using the CFURLCache.

  • wtf/Platform.h:

Source/WebKit2: WebResourceCacheManager should be responsible for managing the CFURLCache as well
as the WebCore memory cache.
https://bugs.webkit.org/show_bug.cgi?id=54886
Part of <rdar://problem/8971738>

Reviewed by Adam Roben.

  • WebProcess/ResourceCache/WebResourceCacheManager.cpp:

(WebKit::WebResourceCacheManager::getCacheOrigins): Call through to cFURLCacheHostNames, and add

create SecurityOrigin's for them and add them to the set of SecurityOrigins with cache.

(WebKit::WebResourceCacheManager::clearCacheForOrigin): Call through to clear the CFURLCache for

the origin's hostname.

  • WebProcess/ResourceCache/WebResourceCacheManager.h:
  • WebProcess/ResourceCache/cf: Added.
  • WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp: Added.

(WebKit::WebResourceCacheManager::cfURLCacheHostNames): Call through to WebKitSystemInterface.
(WebKit::WebResourceCacheManager::clearCFURLCacheForHostNames): Ditto.

  • win/WebKit2.vcproj: Added new file.
  • WebKit2.xcodeproj/project.pbxproj: Ditto.

WebKitLibraries: WebResourceCacheManager should be responsible for managing the CFURLCache as well
as the WebCore memory cache.
https://bugs.webkit.org/show_bug.cgi?id=54886
Part of <rdar://problem/8971738>

Reviewed by Adam Roben.

Update WebKitSystemInterface headers and libraries with new functions.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
2:21 PM Changeset in webkit [79251] by Adam Roben
  • 6 edits in trunk/Source/WebKit2

Move control of the sequence number from DrawingAreaImpl to DrawingAreaProxyImpl

DrawingAreaProxyImpl has some state that, when it changes, causes all operations performed
before that state change to become invalid. When painting, we need to have performed at
least one Update for the most recent state; otherwise, we'll be painting old/incorrect bits
into the view.

Currently, this state consists of a single piece of data: the view's size. Whenever the
state (i.e., size) changes, we tell the web process via the SetSize message, and the web
process lets us know that it has updated to match the new state (i.e., size) via the
DidSetSize message.

When it's time to paint, if we're waiting for the web process to update to match our current
state (i.e., size), we block for a little while hoping to receive a DidSetSize message so
that we can paint up-to-date bits into the window. This can cause us to receive messages
out-of-order; the DidSetSize message will be processed immediately, and any messages that
were sent before the DidSetSize message will be processed later. Since the messages from
before the DidSetSize message correspond to an old state (i.e., size), they are no longer
useful (e.g., they contain bits of the page that are drawn at the wrong size/location), so
we discard them.

The way we identify and discard these messages is by keeping track of a sequence number.
Currently, DrawingAreaImpl sends a monotonically-increasing sequence number to
DrawingAreaProxyImpl with every message. Whenever DrawingAreaProxyImpl receives a DidSetSize
message, it records the sequence number that came along with it. If we then later receive
any messages that have a lower sequence number, we know they correspond to an old state
(i.e., size) and can discard them.

This patch moves control of the sequence number to DrawingAreaProxyImpl.
DrawingAreaProxyImpl now sends a monotonically-increasing sequence number in the SetSize
message. DrawingAreaImpl records this sequence number when it receives the SetSize message,
and sends it back to DrawingAreaProxyImpl in every message. Otherwise the logic is the same
as before.

This should cause no changes in behavior, but will allow DrawingAreaProxyImpl to request a
full backing store update (by incrementing the sequence number) at times other than when the
view's size changes (e.g., after it has thrown away its backing store in order to save
memory).

Fixes <http://webkit.org/b/54907> DrawingAreaProxyImpl should tell DrawingAreaImpl what
sequence number to use

Reviewed by Anders Carlsson.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::generateSequenceNumber): Moved here from DrawingAreaImpl.cpp.
(WebKit::DrawingAreaProxyImpl::sendSetSize): Changed to pass a new sequence number in the
SetSize message.
(WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidSetSize): Added a FIXME about a
potential improvement.

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::setSize): Updated to match the message's new parameters.

  • WebProcess/WebPage/DrawingArea.messages.in: Added a sequenceNumber parameter to SetSize.
  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize m_sequenceNumber.
(WebKit::DrawingAreaImpl::setSize): Record the new sequence number from the UI process.

(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::display):
Send m_sequenceNumber, instead of a new sequence number, back to the UI process.

  • WebProcess/WebPage/DrawingAreaImpl.h: Added m_sequenceNumber, updated setSize function to

match the base class.

2:02 PM Changeset in webkit [79250] by bweinstein@apple.com
  • 2 edits in trunk/WebKitLibraries

Update WebKitSystemInterface.h on Mac. The header that was in the tree didn't
match the current WebKitSystemInterface.h.

Rubber-stamped by Dan Bernstein.

  • WebKitSystemInterface.h:
1:35 PM Changeset in webkit [79249] by Martin Robinson
  • 5 edits in trunk

2011-02-21 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] editing/pasteboard/dataTransfer-setData-getData.html fails
https://bugs.webkit.org/show_bug.cgi?id=54895

Update the results for this test which now includes a few more passing
lines. We maintain separate results, because we seem to pass more tests
than other platforms.

  • platform/gtk/Skipped: Unskip a test which is now passing.
  • platform/gtk/editing/pasteboard/dataTransfer-setData-getData-expected.txt:

2011-02-21 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] editing/pasteboard/dataTransfer-setData-getData.html fails
https://bugs.webkit.org/show_bug.cgi?id=54895

Correct the GTK+ clipboard implementation to know that "text" is an alias
for "text/html" data. This corrects the failing test.

  • platform/gtk/ClipboardGtk.cpp: (WebCore::dataObjectTypeFromHTMLClipboardType): Accept "text" as well as "Text". (WebCore::ClipboardGtk::types): Advertise "text" as well as "Text".
1:23 PM Changeset in webkit [79248] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-02-21 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

nrwt: fix typo causing us to try and repeatedly shut down the servers
https://bugs.webkit.org/show_bug.cgi?id=54904

  • Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
1:14 PM Changeset in webkit [79247] by xan@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

2011-02-21 Xan Lopez <xlopez@igalia.com>

Reviewed by Gavin Barraclough.

Use ASSERT_JIT_OFFSET in JITPropertyAccess32_64.cpp
https://bugs.webkit.org/show_bug.cgi?id=54901

  • jit/JIT.h: swap actual and expected values in message, they were reversed.
  • jit/JITCall32_64.cpp: (JSC::JIT::compileOpCall): use ASSERT_JIT_OFFSET instead of a simple ASSERT.
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::emit_op_method_check): ditto. (JSC::JIT::compileGetByIdHotPath): ditto. (JSC::JIT::compileGetByIdSlowCase): ditto. (JSC::JIT::emit_op_put_by_id): ditto.
12:46 PM Changeset in webkit [79246] by barraclough@apple.com
  • 5 edits in trunk

Ruber stamped by Sam Weinig

Bug 54899 - Math.LOG10E should be 0.4342944819032518
This value is quoted in section 15.8.1.5 of the spec.

Source/JavaScriptCore:

  • runtime/MathObject.cpp:

(JSC::MathObject::MathObject):

LayoutTests:

  • fast/js/kde/math-expected.txt:
  • fast/js/kde/script-tests/math.js:
12:30 PM Changeset in webkit [79245] by commit-queue@webkit.org
  • 2 edits
    4 adds
    1 delete in trunk/LayoutTests

2011-02-21 Anna Cavender <annacc@timberline.sea.corp.google.com>

Reviewed by Eric Carlson.

new baselines for video-transformed.html on mac
https://bugs.webkit.org/show_bug.cgi?id=54765

  • platform/chromium-mac-leopard/media/video-transformed-expected.checksum: Added.
  • platform/chromium-mac-leopard/media/video-transformed-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/video-transformed-expected.png.
  • platform/chromium-mac-snowleopard/media/video-transformed-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/media/video-transformed-expected.png: Added.
  • platform/chromium-mac/media/video-transformed-expected.checksum: Removed.
  • platform/chromium/test_expectations.txt:
11:58 AM Changeset in webkit [79244] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-21 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

ProcessingInstruction should provide a way to know if it is of CSS type.
https://bugs.webkit.org/show_bug.cgi?id=54868

  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::ProcessingInstruction): (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::setCSSStyleSheet):
  • dom/ProcessingInstruction.h: (WebCore::ProcessingInstruction::isCSS):
11:55 AM Changeset in webkit [79243] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-02-21 Simon Fraser <Simon Fraser>

Put JSDOMImplementationCustom.cpp where it belongs in the project.

  • WebCore.xcodeproj/project.pbxproj:
11:49 AM Changeset in webkit [79242] by alex
  • 2 edits in trunk/LayoutTests

2011-02-21 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skip
editing/pasteboard/dataTransfer-setData-getData.html. Added bug:
https://bugs.webkit.org/show_bug.cgi?id=54895

  • platform/gtk/Skipped:
11:33 AM Changeset in webkit [79241] by Csaba Osztrogonác
  • 542 edits
    1083 adds in trunk/LayoutTests

Unreviewed.

[Qt] Add Qt specific expected results for passing tables/mozilla tests.

  • platform/qt/Skipped: Unskip passing tests.
  • platform/qt/tables/mozilla [...] : Added.
11:31 AM Changeset in webkit [79240] by barraclough@apple.com
  • 35 edits in trunk/Source

Bug 54894 - Make inheritance structure described by ClassInfo match C++ class hierarchy.

Reviewed by Sam Weinig.

The ClassInfo objects describe an inheritance hierarchy, with each ClassInfo instance
containing a pointer to its parent class. These links should reflect the inheritance
hierarchy of C++ classes below JSObject. For the large part it does, but in some cases
entries in the C++ hierarchy are skipped over. This presently likely doesn't matter,
since intervening C++ classes may not have ClassInfo - but would be a potential bug
were ClassInfo were to be added.

Source/JavaScriptCore:

  • API/JSCallbackConstructor.cpp:
  • API/JSCallbackFunction.cpp:
  • API/JSCallbackObjectFunctions.h:
  • runtime/Arguments.h:
  • runtime/ArrayPrototype.cpp:
  • runtime/BooleanObject.cpp:
  • runtime/DateInstance.cpp:
  • runtime/DatePrototype.cpp:
  • runtime/ErrorInstance.cpp:
  • runtime/InternalFunction.cpp:
  • runtime/JSActivation.cpp:
  • runtime/JSArray.cpp:
  • runtime/JSFunction.cpp:
  • runtime/JSONObject.cpp:
  • runtime/JSObject.h:
  • runtime/JSZombie.h:
  • runtime/MathObject.cpp:
  • runtime/NativeErrorConstructor.cpp:
  • runtime/NumberConstructor.cpp:
  • runtime/NumberObject.cpp:
  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpObject.cpp:
  • runtime/StringObject.cpp:
  • runtime/StringPrototype.cpp:

Source/WebCore:

  • bindings/js/JSAudioConstructor.cpp:
  • bindings/js/JSDOMGlobalObject.cpp:
  • bindings/js/JSImageConstructor.cpp:
  • bindings/js/JSOptionConstructor.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/objc/objc_runtime.mm:
  • bridge/runtime_object.cpp:

Source/WebKit2:

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:
11:16 AM Changeset in webkit [79239] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-21 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: skip new inspector test on wk2.

  • platform/mac-wk2/Skipped:
11:07 AM Changeset in webkit [79238] by andersca@apple.com
  • 1 edit in trunk/Source/WebKit2/ChangeLog

Fix radar url.

11:06 AM Changeset in webkit [79237] by alex
  • 2 edits in trunk/Tools

2011-02-21 Alejandro G. Castro <alex@igalia.com>

Reviewed by Csaba Osztrogonác.

REGRESSION(r79157):
plugins/get-url-with-javascript-destroying-plugin.html make the
next test crash
https://bugs.webkit.org/show_bug.cgi?id=54863

  • GNUmakefile.am:
10:45 AM Changeset in webkit [79236] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-21 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Skip WebKit2 tests that need EventSender
https://bugs.webkit.org/show_bug.cgi?id=54890

These tests fail because EventSender is missing.

  • platform/mac-wk2/Skipped:
10:40 AM Changeset in webkit [79235] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

REGRESSION(r79157): plugins/get-url-with-javascript-destroying-plugin.html make the next test crash
https://bugs.webkit.org/show_bug.cgi?id=54863

Bug was fixed by http://trac.webkit.org/changeset/79231.

  • platform/qt/Skipped: Unskip plugins/get-url-with-javascript-destroying-plugin.html.
10:29 AM Changeset in webkit [79234] by pfeldman@chromium.org
  • 5 edits
    2 adds in trunk

2011-02-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: navigation does not work after reopening frontend.
https://bugs.webkit.org/show_bug.cgi?id=54879

Test: http/tests/inspector-enabled/open-close-open.html

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::setFrontend):
  • inspector/InspectorState.cpp: (WebCore::InspectorState::unmute):
  • inspector/InspectorState.h:
10:03 AM Changeset in webkit [79233] by Martin Robinson
  • 2 edits
    18 adds in trunk/LayoutTests

2011-02-21 Martin Robinson <mrobinson@igalia.com>

Add results for tests missing results and unskip a test that
is passing locally and when run manually on the bots.

  • platform/gtk/Skipped: Unskip tests that are now passing.
  • platform/gtk/editing/deleting/non-smart-delete-expected.checksum: Added.
  • platform/gtk/editing/deleting/non-smart-delete-expected.png: Added.
  • platform/gtk/editing/deleting/non-smart-delete-expected.txt: Added.
  • platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
  • platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
  • platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt: Added.
  • platform/gtk/fast/runin/generated2-expected.checksum: Added.
  • platform/gtk/fast/runin/generated2-expected.png: Added.
  • platform/gtk/fast/runin/generated2-expected.txt: Added.
  • platform/gtk/fast/runin/generated3-expected.checksum: Added.
  • platform/gtk/fast/runin/generated3-expected.png: Added.
  • platform/gtk/fast/runin/generated3-expected.txt: Added.
  • platform/gtk/fast/runin/generated4-expected.checksum: Added.
  • platform/gtk/fast/runin/generated4-expected.png: Added.
  • platform/gtk/fast/runin/generated4-expected.txt: Added.
  • platform/gtk/media/video-aspect-ratio-expected.checksum: Added.
  • platform/gtk/media/video-aspect-ratio-expected.png: Added.
  • platform/gtk/media/video-aspect-ratio-expected.txt: Added.
10:01 AM Changeset in webkit [79232] by alex
  • 2 edits in trunk/LayoutTests

2011-02-21 Alejandro G. Castro <alex@igalia.com>

Unreviewed added more tests with pixel differences between bots.

  • platform/gtk/Skipped:
9:48 AM Changeset in webkit [79231] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Protect the PluginView when evaluating javascript: URLs

Fixes <http://webkit.org/b/54884> <rdar://problem/9030864>
plugins/get-url-with-javascript-destroying-plugin.html crashing on Windows since it was
added

Reviewed by Sam Weinig.

  • plugins/PluginView.cpp:

(WebCore::PluginView::performRequest): Protect the PluginView, not just its parent frame,
when evaluating javascript: URLs.

9:44 AM Changeset in webkit [79230] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

2011-02-21 Martin Robinson <mrobinson@igalia.com>

Fix GTK+ build after r79223.

  • GNUmakefile.am: Add file missing from the source list.
9:35 AM Changeset in webkit [79229] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-14 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: audits should not warn about gzip compression for 304s
https://bugs.webkit.org/show_bug.cgi?id=54343

Do not run compression-related audits on 304 resources.
Drive-by: handle multi-encoding resources (Content-Encoding: sdhc,gzip) correctly.

  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.GzipRule.prototype.doRun): (WebInspector.AuditRules.GzipRule.prototype._isCompressed):
9:25 AM Changeset in webkit [79228] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations change to mark tests as timing out.

Many tests started timing out on the chrome mac canaries around r79035
https://bugs.webkit.org/show_bug.cgi?id=54885

  • platform/chromium/test_expectations.txt:
8:36 AM Changeset in webkit [79227] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations change - ignore styles-update-from-js.html failures on chromium-win.

Web Inspector: inspector/styles/styles-update-from-js.html is sporadically failing on chromium win bots
https://bugs.webkit.org/show_bug.cgi?id=54882

  • platform/chromium/test_expectations.txt:
8:36 AM Changeset in webkit [79226] by antonm@chromium.org
  • 1 edit in trunk/Source/WebCore/WebCore.pro

Another followup to 79223: correct QT project file

8:18 AM Changeset in webkit [79225] by antonm@chromium.org
  • 1 add in trunk/Source/WebCore/bindings/js/JSDOMImplementationCustom.cpp

Followup to 79223: forgotten file

8:13 AM Changeset in webkit [79224] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-02-21 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement WorkQueue::sheduleWorkAfterDelay
https://bugs.webkit.org/show_bug.cgi?id=54878

  • Platform/qt/WorkQueueQt.cpp: (WorkQueue::scheduleWorkAfterDelay):
8:01 AM Changeset in webkit [79223] by antonm@chromium.org
  • 17 edits in trunk

2011-02-08 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth and Alexey Proskuryakov.

Propagate security origin of parent document into HTML documents created with DOMImplementation
https://bugs.webkit.org/show_bug.cgi?id=53611

This restores invariant that JS wrappers residing in the same JS context should come
from the same security origin.

Absence of regressions is covered by the current tests. Different security origin of
DOMImplementation is difficult to check with layout tests as DOMImplementation
resides in the same JS context as parent document and therefore there are no security origin checks.
This is observable however in C++.

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/v8/V8GCController.cpp: (WebCore::NodeGrouperVisitor::visitDOMWrapper):
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::DOMImplementation): (WebCore::DOMImplementation::createDocument):
  • dom/DOMImplementation.h: (WebCore::DOMImplementation::create): (WebCore::DOMImplementation::documentDestroyed): (WebCore::DOMImplementation::parentDocument):
  • dom/DOMImplementation.idl:
  • dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::implementation):
  • dom/Document.h:

2011-02-21 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth and Alexey Proskuryakov.

Propagate security origin of parent document into HTML documents created with DOMImplementation
https://bugs.webkit.org/show_bug.cgi?id=53611

Additional test which checks case when parent document can be collected while
its implementation is alive.

  • fast/dom/gc-9.html:
7:55 AM Changeset in webkit [79222] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Export JSObject::s_info from JavaScriptCore.dll

This matches what we do for all other ClassInfo objects that WebCore needs access to.

Fixes <http://webkit.org/b/54881> REGRESSION (r79132): Lots of tests crashing in
JSCell::inherits on Windows

Reviewed by Sam Weinig.

  • runtime/JSObject.h: Added JS_EXPORTDATA to s_info.
7:03 AM Changeset in webkit [79221] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-21 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] Optimize editing updates in gutter panel
https://bugs.webkit.org/show_bug.cgi?id=54866

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.set startEditingListener): (WebInspector.TextViewer.prototype.set endEditingListener): (WebInspector.TextViewer.prototype.endUpdates): (WebInspector.TextViewer.prototype._enterInternalTextChangeMode): (WebInspector.TextViewer.prototype._exitInternalTextChangeMode): (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine): (WebInspector.TextEditorGutterPanel.prototype._expandChunks): (WebInspector.TextEditorGutterPanel.prototype.textChanged): (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
6:44 AM Changeset in webkit [79220] by rniwa@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Fixed the change log entry for r79219.

6:42 AM Changeset in webkit [79219] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-21 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Audits] Image dimensions in inline style not checked
https://bugs.webkit.org/show_bug.cgi?id=54738

  • inspector/audits/audits-panel-functional-expected.txt:
  • inspector/audits/audits-panel-functional.html:
6:40 AM Changeset in webkit [79218] by apavlov@chromium.org
  • 5 edits in trunk

2011-02-21 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Audits] Image dimensions in inline style not checked
https://bugs.webkit.org/show_bug.cgi?id=54738

  • inspector/audits/audits-panel-functional-expected.txt:
  • inspector/audits/audits-panel-functional.html:

2011-02-21 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Audits] Image dimensions in inline style not checked
https://bugs.webkit.org/show_bug.cgi?id=54738

  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
6:38 AM Changeset in webkit [79217] by yurys@chromium.org
  • 14 edits
    1 add in trunk/Source/WebCore

2011-02-21 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: create and destroy DOM agent along with InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=54875

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InstrumentingAgents.h: Added. Agents that want to instrument WebCore should register themselve on this object. (WebCore::InstrumentingAgents::InstrumentingAgents): (WebCore::InstrumentingAgents::~InstrumentingAgents): (WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent): (WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent): (WebCore::InstrumentingAgents::inspectorConsoleAgent): (WebCore::InstrumentingAgents::setInspectorConsoleAgent): (WebCore::InstrumentingAgents::inspectorDOMAgent): (WebCore::InstrumentingAgents::setInspectorDOMAgent): (WebCore::InstrumentingAgents::inspectorDOMStorageAgent): (WebCore::InstrumentingAgents::setInspectorDOMStorageAgent): (WebCore::InstrumentingAgents::inspectorDatabaseAgent): (WebCore::InstrumentingAgents::setInspectorDatabaseAgent): (WebCore::InstrumentingAgents::inspectorDebuggerAgent): (WebCore::InstrumentingAgents::setInspectorDebuggerAgent): (WebCore::InstrumentingAgents::inspectorProfilerAgent): (WebCore::InstrumentingAgents::setInspectorProfilerAgent): (WebCore::InstrumentingAgents::inspectorResourceAgent): (WebCore::InstrumentingAgents::setInspectorResourceAgent): (WebCore::InstrumentingAgents::inspectorRuntimeAgent): (WebCore::InstrumentingAgents::setInspectorRuntimeAgent): (WebCore::InstrumentingAgents::inspectorStorageAgent): (WebCore::InstrumentingAgents::setInspectorStorageAgent): (WebCore::InstrumentingAgents::inspectorTimelineAgent): (WebCore::InstrumentingAgents::setInspectorTimelineAgent):
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::createFrontendLifetimeAgents): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::domContentLoadedEventFired): (WebCore::InspectorAgent::loadEventFired):
  • inspector/InspectorAgent.h:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::InspectorCSSAgent): (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::clearConsoleMessages): (WebCore::InspectorConsoleAgent::clearFrontend): (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled): (WebCore::InspectorConsoleAgent::addConsoleMessage):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorDOMAgent.cpp: DOM agent now lives even when the front-end is not attached. (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::setFrontend): Add DOM agent to the set of active agents when the front-end is attached. (WebCore::InspectorDOMAgent::clearFrontend):
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
6:33 AM Changeset in webkit [79216] by commit-queue@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

2011-02-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r79029.
http://trac.webkit.org/changeset/79029
https://bugs.webkit.org/show_bug.cgi?id=54869

Revert unnecessary Chromium rebaseline (Requested by apavlov
on #webkit).

  • platform/chromium-win/inspector/styles-update-from-js-expected.txt: Removed.
6:29 AM Changeset in webkit [79215] by alex
  • 3 edits in trunk/Source/WebKit/gtk

2011-02-21 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] [REGRESSION] After r79130, spell tests did not work
https://bugs.webkit.org/show_bug.cgi?id=54860

  • WebCoreSupport/TextCheckerClientEnchant.cpp: (WebKit::TextCheckerClientEnchant::checkSpellingOfString): Avoided freeing the default PangoLanguage.
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): Initialized list of dictionaries.
6:16 AM Changeset in webkit [79214] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-21 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; Skip fast/events/menu-keydown-on-hidden-element.html on Mac WebKit 2 since it requires EventSender.

  • platform/mac-wk2/Skipped:
6:07 AM Changeset in webkit [79213] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-21 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; Remove incorrect Chromium test expectations.

  • platform/chromium/test_expectations.txt:
5:27 AM Changeset in webkit [79212] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-21 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; Skip fast/events/selectionchange-user-initiated.html added by r79208 on Mac WebKit 2.

  • platform/mac-wk2/Skipped:
5:10 AM Changeset in webkit [79211] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-21 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Andreas Kling.

Switched to compiler based detection, where the error actually is.

It is not the platform that needs the workaround, it is the compiler.

QtWebKit fails to compile on Windows XP with msvc-2008
https://bugs.webkit.org/show_bug.cgi?id=54746

  • bytecode/CodeBlock.h:
  • runtime/RegExpObject.h:
5:05 AM Changeset in webkit [79210] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt][V8]REGRESSION(r79157): Fix build
https://bugs.webkit.org/show_bug.cgi?id=54871

Reviewed by Andreas Kling.

  • bridge/npruntime_internal.h: Add one more undef because of evil X11 macro.
3:49 AM Changeset in webkit [79209] by vitalyr@chromium.org
  • 5 edits in trunk

2011-02-16 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Mihai Parparita.

[V8] SerializedScriptValue: fix JS exception handling.
https://bugs.webkit.org/show_bug.cgi?id=54555

Added checks for exceptions and empty handles:

  • bindings/v8/SerializedScriptValue.cpp: (WebCore::Serializer::Serializer): (WebCore::Serializer::serialize): (WebCore::Serializer::checkException): (WebCore::Serializer::reportFailure): (WebCore::Serializer::ArrayState::advance): (WebCore::Serializer::AbstractObjectState::AbstractObjectState): (WebCore::Serializer::AbstractObjectState::advance): (WebCore::Serializer::push): (WebCore::Serializer::handleError): (WebCore::Serializer::newObjectState): (WebCore::Serializer::doSerialize): (WebCore::SerializedScriptValue::SerializedScriptValue):

2011-02-16 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Mihai Parparita.

[V8] SerializedScriptValue: fix JS exception handling.
https://bugs.webkit.org/show_bug.cgi?id=54555

Added an exception throwing test case:

  • fast/dom/Window/window-postmessage-clone-expected.txt:
  • fast/dom/Window/window-postmessage-clone.html:
3:24 AM Changeset in webkit [79208] by rniwa@webkit.org
  • 9 edits
    4 adds in trunk

2011-02-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Add selectionchange event
https://bugs.webkit.org/show_bug.cgi?id=45712

Added a test to ensure WebKit fires selectionchange event for the correct document
when the document has an iframe, and a test to ensure selectionchange events are fired
on user-initiated events.

  • fast/events/selectionchange-iframe-expected.txt: Added.
  • fast/events/selectionchange-iframe.html: Added.
  • fast/events/selectionchange-user-initiated-expected.txt: Added.
  • fast/events/selectionchange-user-initiated.html: Added.

2011-02-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Add selectionchange event
https://bugs.webkit.org/show_bug.cgi?id=45712

Added the support for asynchronous selectionchange event, which is fired whenever selection is changed.
This event is not cancelable and does not bubble. An event listener can be attached to a document by
body element's onselectionchange attribute or via document's onselectionchange property.

Note that WebKit's implementation fires the event asynchronously whereas Internet Explorer's implementation
fires it synchronously. This implies that a script that modify selection (e.g. via selection's addRange)
will not observe the event before the control returns to JavaScript.

See also: http://msdn.microsoft.com/en-us/library/ms536968(VS.85).aspx

Tests: fast/events/selectionchange-iframe.html

fast/events/selectionchange-user-initiated.html

  • dom/Document.cpp: (WebCore::Document::enqueueDocumentEvent): Added.
  • dom/Document.h: Added selectionchange event listener.
  • dom/Document.idl: Added onselectionchagne attribute.
  • dom/EventNames.h: Added selectionchange
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Fires selectionchange event.
  • html/HTMLAttributeNames.in: Added onselectionchange.
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute): Handles onselectionchange attribute.
3:20 AM Changeset in webkit [79207] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

REGRESSION(r79157): plugins/get-url-with-javascript-destroying-plugin.html make the next test crash
https://bugs.webkit.org/show_bug.cgi?id=54863

  • platform/qt/Skipped: Unskip the innocent plugins/get-user-agent-with-null-npp-from-npp-new.html

and skip the real culprit plugins/get-url-with-javascript-destroying-plugin.html until fix.

3:16 AM Changeset in webkit [79206] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-21 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: protocol error messages are dumping incorrectly in Layout tests.
https://bugs.webkit.org/show_bug.cgi?id=54859

  • inspector/CodeGeneratorInspector.pm:
3:12 AM Changeset in webkit [79205] by pfeldman@chromium.org
  • 18 edits in trunk/LayoutTests

2011-02-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] inspector/debugger/dom-breakpoints.html TIMEOUTs
https://bugs.webkit.org/show_bug.cgi?id=54638

  • http/tests/inspector/change-iframe-src.html:
  • http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest): (initialize_DebuggerTest.InspectorTest.startDebuggerTest): (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger): (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite.runner): (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite): (initialize_DebuggerTest.InspectorTest.waitUntilPaused): (initialize_DebuggerTest.InspectorTest.waitUntilPausedAndDumpStack.step1): (initialize_DebuggerTest.InspectorTest.waitUntilPausedAndDumpStack): (initialize_DebuggerTest.InspectorTest.waitUntilResumed): (initialize_DebuggerTest.InspectorTest.resumeExecution): (initialize_DebuggerTest.InspectorTest.showScriptSource): (initialize_DebuggerTest.InspectorTest._showScriptSource): (initialize_DebuggerTest.InspectorTest.expandProperties.expandNextPath): (initialize_DebuggerTest.InspectorTest.expandProperties):
  • http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.nodeWithId.processChildren): (initialize_ElementTest.InspectorTest.nodeWithId): (initialize_ElementTest.InspectorTest.selectNodeWithId.mycallback): (initialize_ElementTest.InspectorTest.selectNodeWithId): (initialize_ElementTest.InspectorTest.expandElementsTree.mycallback): (initialize_ElementTest.InspectorTest.expandElementsTree): (initialize_ElementTest):
  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.evaluateInConsole): (initialize_InspectorTest.InspectorTest.evaluateInConsoleAndDump.mycallback): (initialize_InspectorTest.InspectorTest.evaluateInConsoleAndDump): (initialize_InspectorTest.InspectorTest.evaluateInPage.mycallback): (initialize_InspectorTest.InspectorTest.evaluateInPage): (initialize_InspectorTest.InspectorTest.evaluateInPageWithTimeout): (initialize_InspectorTest.InspectorTest.reloadPage): (initialize_InspectorTest.InspectorTest.runAfterPendingDispatches): (initialize_InspectorTest.InspectorTest.runTestSuite.runner): (initialize_InspectorTest.InspectorTest.runTestSuite): (initialize_InspectorTest.InspectorTest.safeWrap):
  • http/tests/inspector/resource-parameters.html:
  • inspector/console/console-assert.html:
  • inspector/console/console-trace-in-eval.html:
  • inspector/console/console-trace.html:
  • inspector/debugger/dom-breakpoints-expected.txt:
  • inspector/debugger/dom-breakpoints.html:
  • inspector/extensions/extensions-audits-tests.js: (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits): (initialize_ExtensionsAuditsTest):
  • inspector/styles/styles-iframe.html:
  • inspector/styles/styles-update-from-js.html:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:
  • platform/chromium/test_expectations.txt:
3:03 AM Changeset in webkit [79204] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: generate protocol documentation based on IDL.
https://bugs.webkit.org/show_bug.cgi?id=54822

  • inspector/CodeGeneratorInspector.pm:
2:55 AM Changeset in webkit [79203] by alex
  • 2 edits in trunk/LayoutTests

2011-02-21 Alejandro G. Castro <alex@igalia.com>

Fixed typo in gtk Skipped list.

  • platform/gtk/Skipped:
2:40 AM Changeset in webkit [79202] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt]REGRESSION(r79157): plugins/get-user-agent-with-null-npp-from-npp-new.html crashes
https://bugs.webkit.org/show_bug.cgi?id=54863

Paper over one more regression to make Qt buildbot happy and green.

  • platform/qt/Skipped: Add plugins/get-user-agent-with-null-npp-from-npp-new.html until fix.
2:19 AM Changeset in webkit [79201] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-18 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] media/audio-delete-while-slider-thumb-clicked.html still flaky
https://bugs.webkit.org/show_bug.cgi?id=54747

  • media/audio-delete-while-slider-thumb-clicked.html: Autoplay the media element and trigger the seek after playback started.
2:12 AM Changeset in webkit [79200] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

2011-02-21 Andoni Morales Alastruey <amorales@flumotion.com>

Reviewed by Martin Robinson.

[GStreamer] Add URI queries support in webkitwebsrc
https://bugs.webkit.org/show_bug.cgi?id=54627

This allow replying to URI queries from downstream elements
with the uri currently set in the source element.

No new tests, this feature is dedicated to internal GStreamer use,
such as the upcoming HTTP Live Streaming element.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webKitWebSrcQuery):
2:11 AM Changeset in webkit [79199] by morrita@google.com
  • 1 edit
    7 adds in trunk/LayoutTests

2011-02-21 MORITA Hajime <morrita@google.com>

Unreviewed expectation update.

  • platform/chromium-linux/animations/3d/matrix-transform-type-animation-expected.checksum: Added.
  • platform/chromium-linux/animations/3d/matrix-transform-type-animation-expected.png: Added.
  • platform/chromium-mac/animations/3d/matrix-transform-type-animation-expected.checksum: Added.
  • platform/chromium-mac/animations/3d/matrix-transform-type-animation-expected.png: Added.
  • platform/chromium-win/animations/3d/matrix-transform-type-animation-expected.checksum: Added.
  • platform/chromium-win/animations/3d/matrix-transform-type-animation-expected.png: Added.
  • platform/chromium-win/animations/3d/matrix-transform-type-animation-expected.txt: Added.
1:58 AM Changeset in webkit [79198] by Csaba Osztrogonác
  • 2 edits
    3 deletes in trunk/LayoutTests

Unreviewed.

[Qt] Possible DRT bug revealed by r72003
https://bugs.webkit.org/show_bug.cgi?id=49538

After r79103 we don't need Qt specific expected results
$for these tests because of whitespace differences.

  • platform/qt/fast/forms/formaction-attribute-expected.txt: Removed.
  • platform/qt/fast/forms/formmethod-attribute-button-html-expected.txt: Removed.
  • platform/qt/fast/forms/formtarget-attribute-button-html-expected.txt: Removed.
  • platform/qt/fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Updated.
1:33 AM Changeset in webkit [79197] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

2011-02-21 Andoni Morales Alastruey <amorales@flumotion.com>

Reviewed by Martin Robinson.

[GStreamer] Add 'location' property in webkitwebsrc
https://bugs.webkit.org/show_bug.cgi?id=54628

No new tests, this feature is dedicated to internal GStreamer use,
such as the upcoming HTTP Live Streaming element.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webkit_web_src_class_init): (webKitWebSrcSetProperty): (webKitWebSrcGetProperty):
1:28 AM Changeset in webkit [79196] by rniwa@webkit.org
  • 55 edits in trunk/Source

2011-02-17 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Rename Position::node() to Position::deprecatedNode()
https://bugs.webkit.org/show_bug.cgi?id=54622

Done the rename. All calls to node() are replaced by calls to deprecatedNode().

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setComposition): Check the nullity of startContainer() instead of startPosition()->node(). (WebKit::WebViewImpl::confirmComposition): Ditto. (WebKit::WebViewImpl::textInputType): (WebKit::WebViewImpl::caretOrSelectionBounds):

2011-02-17 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Rename Position::node() to Position::deprecatedNode()
https://bugs.webkit.org/show_bug.cgi?id=54622

Replaced the call to node() by a call to containerNode() because the returned node is
used to determine whether or not the selected contents are editable and such a check
must be done against the container node.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):

2011-02-17 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Rename Position::node() to Position::deprecatedNode()
https://bugs.webkit.org/show_bug.cgi?id=54622

Done the rename. All calls to node() are replaced by calls to deprecatedNode().

  • webkit/webkitwebview.cpp: (webkit_web_view_popup_menu_handler):

2011-02-17 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Rename Position::node() to Position::deprecatedNode()
https://bugs.webkit.org/show_bug.cgi?id=54622

  • WebView/WebFrame.mm: (-[WebFrame _smartDeleteRangeForProposedRange:]):

2011-02-17 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Rename Position::node() to Position::deprecatedNode()
https://bugs.webkit.org/show_bug.cgi?id=54622

Replaced the call to node() by a call to containerNode() because the returned node is
used to determine whether or not the selected contents are editable and such a check
must be done against the container node.

  • WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::handleKeyboardEvent):

2011-02-17 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Rename Position::node() to Position::deprecatedNode()
https://bugs.webkit.org/show_bug.cgi?id=54622

Done the rename. All calls to node() are replaced by calls to deprecatedNode() except when
calls were of the form node()->document() and node()->inDocument() in which case they were
replaced by anchorNode()->document() and anchorNode()->inDocument() respectively.

  • WebCore.exp.in: Added Position::containerNode.

The rest abbreviated for simplicity. Please see svn log.

1:00 AM Changeset in webkit [79195] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-21 MORITA Hajime <morrita@google.com>

Another unreviewed attempt to expectation update.

  • platform/chromium/test_expectations.txt:
12:16 AM Changeset in webkit [79194] by alex
  • 2 edits in trunk/Source/WebKit2

2011-02-20 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add WebResourceCacheDataManager to the compilation after r78848
https://bugs.webkit.org/show_bug.cgi?id=54732

Added resource cache manager API to GTK+ compilation after r78848.

  • GNUmakefile.am:
12:12 AM Changeset in webkit [79193] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-21 MORITA Hajime <morrita@google.com>

Unreviewed expectation update. (Removes invalid lines.)

  • platform/chromium/test_expectations.txt:

Feb 20, 2011:

11:26 PM Changeset in webkit [79192] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-20 MORITA Hajime <morrita@google.com>

Unreviewed expectation update.

  • platform/chromium/test_expectations.txt:
11:21 PM Changeset in webkit [79191] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-02-16 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

keyboard support for extending/shrinking comment context
https://bugs.webkit.org/show_bug.cgi?id=54612

ctrl+shift+up/down will extend/shrink the comment context when
a comment is focused or when one is being edited.

Also, switch over to using keydown instead of keypress events.
This lets us share code for handling escape and other key events.
Also, keypress is evil and should die.

  • code-review.js:
11:09 PM Changeset in webkit [79190] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <ojan@chromium.org>

Recommit accidental revert.
r79180 accidentally revereted r79178.

  • code-review.js:
11:04 PM Changeset in webkit [79189] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] add more help information
https://bugs.webkit.org/show_bug.cgi?id=54847

  • code-review.js:
10:53 PM Changeset in webkit [79188] by Lucas Forschler
  • 5 edits in branches/safari-534.20-branch/Source

Versioning.

10:48 PM Changeset in webkit [79187] by Lucas Forschler
  • 1 move in tags/Safari-534.20.7

Renaming tag

10:46 PM Changeset in webkit [79186] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] use 'r' to focus the review select element
https://bugs.webkit.org/show_bug.cgi?id=54845

This allows for quick keyboard access to the toolbar items.
Hit r to get to the review select element. Then you can
tab to the cq/preview/publish elements.

  • code-review.js:
10:41 PM Changeset in webkit [79185] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] don't let lines/diffblocks be mouse focusable
https://bugs.webkit.org/show_bug.cgi?id=54851

Unfortunately, this will only work once https://bugs.webkit.org/show_bug.cgi?id=54727
is committed. In the interim, it won't break anything.

  • code-review.js:
10:40 PM Changeset in webkit [79184] by Lucas Forschler
  • 1 copy in tags/Safari-534.20.8

New tag.

10:39 PM Changeset in webkit [79183] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] use keydown instead of keypress
https://bugs.webkit.org/show_bug.cgi?id=54849

There is no functional change. This is just a cleanup
to make future patches (e.g. https://bugs.webkit.org/show_bug.cgi?id=54612)
cleaner.

  • code-review.js:
10:37 PM Changeset in webkit [79182] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] fix layout nit
https://bugs.webkit.org/show_bug.cgi?id=54848

There is occasionally an off-by-one in the 50% width
calculation. This ensures that the add lines always
line up with the shared context lines.

  • PrettyPatch/PrettyPatch.rb:
9:48 PM Changeset in webkit [79181] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

test-webkitpy: stop skipping a bunch of tests on win32
https://bugs.webkit.org/show_bug.cgi?id=54788

  • Scripts/webkitpy/common/net/testoutputset_unittest.py:
  • Scripts/webkitpy/test/main.py:
9:44 PM Changeset in webkit [79180] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] make escape hide the preview form
https://bugs.webkit.org/show_bug.cgi?id=54844

  • code-review.js:
9:37 PM Changeset in webkit [79179] by barraclough@apple.com
  • 5 edits in trunk/Source/WebCore

Build fix (remove includes).

  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSHistoryCustom.cpp:
  • bindings/js/JSLocationCustom.cpp:
9:37 PM Changeset in webkit [79178] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-20 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] make enter work when an individual line is focused
https://bugs.webkit.org/show_bug.cgi?id=54843

  • code-review.js:
9:18 PM Changeset in webkit [79177] by barraclough@apple.com
  • 51 edits
    5 deletes in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=54839
Remove PrototypeFunction, NativeFunctionWrapper, and GlobalEvalFunction.

Reviewed by Oliver Hunt.

Historically, Native functions used to be represented by PrototypeFunctions, however
since introducing call optimizations to the JIT this has used JSFunctions for host
calls too. At the point this change was made, the interpreter continued to use
PrototypeFunctions, however since fallback from the JIT to interpreter was introduced
the interpreter has had to be able to run using host functions represented using
JSFunctions - leading to an unnecessary and redundant divergence in behaviour between
interpreter only builds, and situations where the JIT has fallen back to interpreting.

NativeFunctionWrapper only existed to select between PrototypeFunction and JSFunction
for wrappers for host functions, and as such can also be removed.

GlobalEvalFunction is a redundant wrapper that happens to be derived from
PrototypeFunction. It existed to hold a reference to the global object - but since all
functions how derive from JSObjectWithGlobalObject, this no longer requires an
additional class to provide this functionality.

Source/JavaScriptCore:

Removed symbols / references to files.

  • runtime/GlobalEvalFunction.cpp: Removed.
  • runtime/GlobalEvalFunction.h: Removed.
  • runtime/NativeFunctionWrapper.h: Removed.
  • runtime/PrototypeFunction.cpp: Removed.
  • runtime/PrototypeFunction.h: Removed.

Removed.

  • runtime/Executable.cpp:

(JSC::NativeExecutable::~NativeExecutable):

  • runtime/Executable.h:

(JSC::NativeExecutable::create):
(JSC::NativeExecutable::NativeExecutable):
(JSC::JSFunction::nativeFunction):

  • runtime/JSFunction.cpp:

(JSC::callHostFunctionAsConstructor):
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::getCallData):

  • runtime/JSFunction.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::getHostFunction):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::getCTIStub):

Added interpreter-friendly constructors for NativeExecutables.

  • bytecompiler/BytecodeGenerator.cpp:
  • interpreter/Interpreter.cpp:
  • jit/JITStubs.cpp:
  • jsc.cpp:
  • runtime/ArrayConstructor.cpp:
  • runtime/BooleanPrototype.cpp:
  • runtime/BooleanPrototype.h:
  • runtime/CallData.h:
  • runtime/DateConstructor.cpp:
  • runtime/DateConstructor.h:
  • runtime/ErrorPrototype.cpp:
  • runtime/ErrorPrototype.h:
  • runtime/FunctionPrototype.cpp:
  • runtime/FunctionPrototype.h:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:
  • runtime/JSGlobalObjectFunctions.cpp:
  • runtime/Lookup.cpp:
  • runtime/NumberPrototype.cpp:
  • runtime/NumberPrototype.h:
  • runtime/ObjectConstructor.cpp:
  • runtime/ObjectConstructor.h:
  • runtime/ObjectPrototype.cpp:
  • runtime/ObjectPrototype.h:
  • runtime/RegExpPrototype.cpp:
  • runtime/RegExpPrototype.h:
  • runtime/SmallStrings.h:
  • runtime/StringConstructor.cpp:
  • runtime/StringConstructor.h:

Removed use of redundant classes.

Source/WebCore:

  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSHistoryCustom.cpp:
  • bindings/js/JSLocationCustom.cpp:

Removed use of redundant classes.

9:07 PM Changeset in webkit [79176] by dpranke@chromium.org
  • 8 edits in trunk/Tools

2011-02-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

Fix various bugs related to handling of dir separators and real
vs. fake filesystems that were causing test-webkitpy to fail
tests on win32. These bugs have a variety of causes but are
lumped together because they should be easy to review.

https://bugs.webkit.org/show_bug.cgi?id=54700

  • Scripts/webkitpy/common/net/testoutput.py: Here we were using os.path.sep but not escaping it prior to using in a regexp, which caused bad things on win32.
  • Scripts/webkitpy/common/net/testoutput_unittest.py: Same here.
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Here we were using the native filesystem instead of the mock filesystem, making some tests unnecessarily platform dependent. Also we weren't setting the default configuration for the TestChromiumWinPort.
  • Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Here we *shouldn't* use os.path.join(), just so the code becomes less platform dependent.
  • Scripts/webkitpy/style/checker.py: Here we should be using os.path.sep instead of "/"; the tests require the native filesystem.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Here the underlying code is using os.path.sep, so we probably should as well.
  • Scripts/webkitpy/style/test_expectations_unittest.py: Here we should be using the filesystem hanging of the port object (which is the mocked filesystem) rather than the native one.
8:59 PM Changeset in webkit [79175] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-20 MORITA Hajime <morrita@google.com>

Unreviewed expectation update.

  • platform/chromium/test_expectations.txt:
8:37 PM Changeset in webkit [79174] by tkent@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-02-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r79169.
http://trac.webkit.org/changeset/79169
https://bugs.webkit.org/show_bug.cgi?id=54846

Made unexpected results for tests without CJK characters
(Requested by tkent on #webkit).

  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h: (WebCore::FontPlatformData::orientation):
  • platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
8:28 PM Changeset in webkit [79173] by Lucas Forschler
  • 2 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r79170.

8:20 PM Changeset in webkit [79172] by Lucas Forschler
  • 7 edits
    2 copies in branches/safari-534.20-branch

Merge r79167.

7:58 PM Changeset in webkit [79171] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebKit/efl

2011-02-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Fix coding style errors in tiled BS and ewk_window_feature.h
https://bugs.webkit.org/show_bug.cgi?id=54842

Fix style errors in ewk files.

  • ewk/ewk_tiled_backing_store.h:
  • ewk/ewk_tiled_matrix.h:
  • ewk/ewk_tiled_model.h:
  • ewk/ewk_window_features.h:
7:43 PM Changeset in webkit [79170] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash in WebProcess at com.apple.WebCore: WebCore::Page::goToItem + 46
<rdar://problem/8942726>

Reviewed by Dan Bernstein.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::goForward):
(WebKit::WebPage::goBack):
(WebKit::WebPage::goToBackForwardItem):
Defend agains null HistoryItems.

7:28 PM Changeset in webkit [79169] by tkent@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-02-20 Chun-Lung Huang <alvincl.huang@gmail.com>

Reviewed by Kent Tamura.

On Chromium Windows, glyphs in vertical text tests are rotated 90
degrees clockwise. https://bugs.webkit.org/show_bug.cgi?id=51450

This platform dependent patch makes Chromium Windows show the
vertical writing text correctly. Job was done by adding a prefix '@'
in front of the font family name (Windows Only). No new tests added.

  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h: (WebCore::FontPlatformData::orientation):
  • platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
7:26 PM Changeset in webkit [79168] by Simon Fraser
  • 3 edits
    4 adds in trunk

2011-02-20 Simon Fraser <Simon Fraser>

Reviewed by Dirk Schulze.

REGRESSION (r73369-r73405): transform animation interpolates incorrectly
https://bugs.webkit.org/show_bug.cgi?id=54793

After the refactoring in r73380, the ending state for some types of
accelerated animations was computed incorrectly, because the TransformationMatrix
wasn't reset to identity before the ending value transformations were applied.

Fix by cleaning up the code to use explicit, separate values for
starting and ending values. Only matrix-type animations had this
issue, but cleaned up other clauses similarly.

Test: animations/3d/matrix-transform-type-animation.html

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
7:06 PM Changeset in webkit [79167] by mitz@apple.com
  • 7 edits
    2 adds in trunk

<rdar://problem/9028929> REGRESSION (r75897): Scaling applied twice to an iframe with a transformed ancestor

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: fast/frames/iframe-scale-applied-twice.html

  • page/FrameView.cpp:

(WebCore::FrameView::create): Set the initial bounds of the view to match the
frame size.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::visibleContentRect): Based on bounds, not frame size.
(WebCore::ScrollView::updateScrollbars): Ditto.
(WebCore::ScrollView::setFrameRect): Moved code that really handles bounds size
change to setBoundsSize().
(WebCore::ScrollView::setBoundsSize): Added.
(WebCore::ScrollView::setInitialBoundsSize): Added. Sets the bounds size but does
not update anything.
(WebCore::ScrollView::frameRectsChanged): Based on bounds, not frame size.
(WebCore::ScrollView::scrollbarCornerPresent): Ditto.

  • platform/ScrollView.h:

(WebCore::ScrollView::boundsSize): Added this getter.

  • platform/Widget.h:

(WebCore::Widget::resize): Set the bounds size to the frame size.

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paint): Fixed an error in the indirect drawing code
path where the buffer rect was resized to capture only the damaged part, but was
still drawn in the original location.

LayoutTests:

  • fast/frames/iframe-scale-applied-twice-expected.txt: Added.
  • fast/frames/iframe-scale-applied-twice.html: Added.
6:45 PM Changeset in webkit [79166] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-02-17 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

use shift+j/k to focus next/previous line
https://bugs.webkit.org/show_bug.cgi?id=54723

Tested on a large Hyatt change to confirm it performed fine.
(https://bugs.webkit.org/attachment.cgi?id=82533&action=review)

  • code-review.js:
6:38 PM Changeset in webkit [79165] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-17 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

fix escape handling in code review tool
https://bugs.webkit.org/show_bug.cgi?id=54722

This broke with http://trac.webkit.org/changeset/78948.
Apparently jquery events get a wrapped object that
does not expose keyIdentifier.

  • code-review.js:
6:36 PM Changeset in webkit [79164] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-17 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

create comments when hitting enter with a focused diff
https://bugs.webkit.org/show_bug.cgi?id=54719

  • code-review.js:
6:29 PM Changeset in webkit [79163] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-02-17 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

use actual browser focus in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=54726

This makes keyboard handling play better with focusable element
(i.e. links/textareas/buttons). Also, in theory, this makes
the review tool more amenable to screen readers (I think).

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
6:24 PM Changeset in webkit [79162] by Lucas Forschler
  • 4 edits in branches/safari-534.20-branch/Source/WebKit2

Merge 79165.

6:20 PM Changeset in webkit [79161] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

2011-02-20 Ami Fischman <fischman@chromium.org>

Reviewed by Kent Tamura.

Remove flakiness from media/video-poster.html by using event callbacks
instead of 100ms timeouts and hoping that states have transitioned in
time (!).
Removed seemingly-outdated BUG_DRT annotation from test_expectation.

https://bugs.webkit.org/show_bug.cgi?id=54685
http://crbug.com/60845

  • media/video-poster.html:
  • platform/chromium/test_expectations.txt:
5:35 PM Changeset in webkit [79160] by kalman@chromium.org
  • 4 edits in trunk/LayoutTests

2011-02-21 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ryosuke Niwa.

Make editing/selection/extend-selection tests more human readable and hand-runnable
https://bugs.webkit.org/show_bug.cgi?id=54712

Three changes to achieve this:

  • Column-align the "right:", "left:", "forward:", and "backward:" labels in the output.
  • Add buttons to switch between LTR and RTL (the test will switch everything to RTL but LTR is useful).
  • Fix typo causing failing tests to have a js error (rather than layout error).

Expected results need to change due to column alignment.

  • editing/selection/extend-selection-character-expected.txt:
  • editing/selection/extend-selection-word-expected.txt:
  • editing/selection/resources/extend-selection.js: (logMismatchingPositions): (runSelectionTestsWithGranularity): (getTestNodeContainer.createButton.button.onmousedown): (getTestNodeContainer.createButton): (getTestNodeContainer.createButtonToSwitchDirection): (getTestNodeContainer): (createNode):
5:07 PM Changeset in webkit [79159] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Reviewed by Eric Seidel.

Tighten up access permissions by using libxslt API
https://bugs.webkit.org/show_bug.cgi?id=52688
<rdar://problem/8909191>

  • xml/XSLTProcessorLibxslt.cpp: (WebCore::XSLTProcessor::transformToString): We are only interested in a string result, so let libxslt know about that.
4:35 PM Changeset in webkit [79158] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-02-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r79104.
http://trac.webkit.org/changeset/79104
https://bugs.webkit.org/show_bug.cgi?id=54835

Might have caused flaky canaries (Requested by tonyg-cr on
#webkit).

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::canTakeNextToken): (WebCore::HTMLDocumentParser::pumpTokenizer):
  • html/parser/HTMLParserScheduler.cpp: (WebCore::isLayoutTimerActive):
  • html/parser/HTMLParserScheduler.h: (WebCore::HTMLParserScheduler::checkForYieldBeforeToken):
  • page/FrameView.h:
4:09 PM Changeset in webkit [79157] by andersca@apple.com
  • 11 edits
    3 adds in trunk

2011-02-20 Anders Carlsson <andersca@apple.com>

Reviewed by Maciej Stachowiak.

Crash when a plug-in requests a javascript: url that destroys the plug-in
https://bugs.webkit.org/show_bug.cgi?id=54837
<rdar://problem/9005475>

Add new plug-in test.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: (PluginTest::NPN_GetURL):
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  • DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURLDestroyingPlugin.cpp: Added. (GetURLWithJavaScriptURLDestroyingPlugin::GetURLWithJavaScriptURLDestroyingPlugin): (GetURLWithJavaScriptURLDestroyingPlugin::NPP_New):
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

2011-02-20 Anders Carlsson <andersca@apple.com>

Reviewed by Maciej Stachowiak.

Crash when a plug-in requests a javascript: url that destroys the plug-in
https://bugs.webkit.org/show_bug.cgi?id=54837
<rdar://problem/9005475>

Add test.

  • plugins/get-url-with-javascript-destroying-plugin-expected.txt: Added.
  • plugins/get-url-with-javascript-destroying-plugin.html: Added.

2011-02-20 Anders Carlsson <andersca@apple.com>

Reviewed by Maciej Stachowiak.

Crash when a plug-in requests a javascript: url that destroys the plug-in
https://bugs.webkit.org/show_bug.cgi?id=54837
<rdar://problem/9005475>

  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::destroy): Null out m_pluginController.
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::performJavaScriptURLRequest): Don't access the frame through m_pluginElement since it will be nulled out when the plug-in is destroyed.
3:04 PM Changeset in webkit [79156] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-02-20 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Fix another crash when a plug-in is destroyed when evaluating JavaScript
https://bugs.webkit.org/show_bug.cgi?id=54834
<rdar://problem/9013384>

This contains three separate fixes:

  • In unprotectPluginFromDestruction we can't just destroy the plug-in once the count reaches zero, because the plug-in might still have code executing on the stack. To fix this we use a zero-delay timer to defer destruction of the plug-in.
  • Trying to get the NPObject for the window using NPN_GetValue would return NPERR_NO_ERROR, even if the returned NPObject was null. Fix this to return NPERR_GENERIC_ERROR instead.
  • Protect the plug-in from destruction anytime an NPAPI call that sends a synchronous IPC message is made.
  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::PluginControllerProxy): (WebKit::PluginControllerProxy::destroy): (WebKit::PluginControllerProxy::unprotectPluginFromDestruction):
  • PluginProcess/PluginControllerProxy.h:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::PluginDestructionProtector::PluginDestructionProtector): (WebKit::NPN_GetValue): (WebKit::NPN_Evaluate): (WebKit::NPN_GetProperty): (WebKit::NPN_SetProperty): (WebKit::NPN_RemoveProperty): (WebKit::NPN_HasProperty): (WebKit::NPN_HasMethod): (WebKit::NPN_Enumerate): (WebKit::NPN_Construct): (WebKit::NPN_GetValueForURL): (WebKit::NPN_SetValueForURL):
2:27 PM Changeset in webkit [79155] by krit@webkit.org
  • 18 edits
    3 adds in trunk

2011-02-20 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG animation - analyze attribute type for animation
https://bugs.webkit.org/show_bug.cgi?id=54542

Check dynamic update of attributeName. The test fails at the moment, because of some wrong
internal mapping. Tested update manually with gdb. Working on a fix to get this test pass
as well.

  • svg/animations/animate-dynamic-update-attributeName-expected.txt: Added.
  • svg/animations/animate-dynamic-update-attributeName.html: Added.
  • svg/animations/script-tests/animate-dynamic-update-attributeName.js: Added. (sample1): (sample2): (sample3): (executeTest):

2011-02-20 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG animation - analyze attribute type for animation
https://bugs.webkit.org/show_bug.cgi?id=54542

Analyze animated attribute type to determine the kind of animation. Removed enum PropertyType and replace it
with AnimatedAttributeType instead. More cleanup of the animation code.
Added missing fillAttributeToPropertyTypeMap() for SVGGElement.

Use QualifiedName instead of AtomicStrings for attribute names. This makes it easier to handle animated attributes
from a different namespace like xlink:href. The rest of the SVG code is using QualifiedNames as well.

No change of functionality on the animation code. The changes for the <g>-element affect animateTransform. Sadly
animateTransform is not supported by our SVG animation test script at the moment. Can still be tested manually
with the W3C test suite in trunk.

The change on SVGUseElement gets covered by animate-elem-39-t.svg

Test: svg/animations/animate-dynamic-update-attributeName.html

  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::SVGAnimateElement): (WebCore::SVGAnimateElement::hasValidAttributeType): (WebCore::SVGAnimateElement::determineAnimatedAttributeType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::inheritsFromProperty): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::hasValidAttributeType): (WebCore::parsePoint): (WebCore::SVGAnimateMotionElement::resetToBaseValue): (WebCore::SVGAnimateMotionElement::calculateAnimatedValue): (WebCore::SVGAnimateMotionElement::calculateDistance):
  • svg/SVGAnimateMotionElement.h:
  • svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::hasValidAttributeType): (WebCore::SVGAnimateTransformElement::determineAnimatedAttributeType): (WebCore::SVGAnimateTransformElement::resetToBaseValue): (WebCore::SVGAnimateTransformElement::calculateAnimatedValue): (WebCore::SVGAnimateTransformElement::calculateFromAndByValues): (WebCore::SVGAnimateTransformElement::applyResultsToTarget): (WebCore::SVGAnimateTransformElement::calculateDistance):
  • svg/SVGAnimateTransformElement.h:
  • svg/SVGAnimationElement.cpp: (WebCore::parseKeyTimes): (WebCore::parseKeySplines): (WebCore::SVGAnimationElement::isTargetAttributeCSSProperty): (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue): (WebCore::SVGAnimationElement::calculateKeyTimesForCalcModePaced): (WebCore::solveEpsilon): (WebCore::SVGAnimationElement::calculatePercentFromKeyPoints): (WebCore::SVGAnimationElement::currentValuesFromKeyPoints): (WebCore::SVGAnimationElement::currentValuesForValuesAnimation): (WebCore::SVGAnimationElement::startedActiveInterval):
  • svg/SVGAnimationElement.h:
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::fillAttributeToPropertyTypeMap):
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::attributeToPropertyTypeMap): (WebCore::SVGGElement::fillAttributeToPropertyTypeMap): Added to fill the animated attribute map for this element.
  • svg/SVGGElement.h:
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::fillAttributeToPropertyTypeMap): Changed attribute type to AnimatedString for xlink:href.
  • svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::baseValueFor): (WebCore::SMILTimeContainer::updateAnimations):
  • svg/animation/SMILTimeContainer.h:
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::SVGSMILElement): (WebCore::constructQualifiedName): Create a QualifiedName from a attribute name. (WebCore::SVGSMILElement::insertedIntoDocument): Update local varaible of attribute name. (WebCore::SVGSMILElement::removedFromDocument): Ditto. (WebCore::SVGSMILElement::attributeChanged): Ditto.
  • svg/animation/SVGSMILElement.h: (WebCore::SVGSMILElement::attributeName):
1:16 PM Changeset in webkit [79154] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX: Add missing UNUSED_PARAM() when !ENABLE(FULLSCREEN_API)

Not reviewed.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForFullScreen):

3:20 AM Changeset in webkit [79153] by Lucas Forschler
  • 5 edits in branches/safari-534.20-branch/Source

Versioning.

3:14 AM Changeset in webkit [79152] by Lucas Forschler
  • 1 copy in tags/Safari-534.20.6

New tag.

1:28 AM Changeset in webkit [79151] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

2011-02-20 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement PlatformKeyboardEvent::getCurrentModifierState()
https://bugs.webkit.org/show_bug.cgi?id=52880

  • platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::getCurrentModifierState):
1:22 AM Changeset in webkit [79150] by Carlos Garcia Campos
  • 2 edits in trunk

2011-02-20 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Bump GTK+3 dependency to 3.0
https://bugs.webkit.org/show_bug.cgi?id=54394

  • configure.ac:
12:50 AM Changeset in webkit [79149] by mitz@apple.com
  • 815 edits in trunk/LayoutTests/platform

Set the svn:mime-type property of some PNG files to image/png

12:11 AM Changeset in webkit [79148] by Lucas Forschler
  • 5 edits in branches/safari-534.20-branch/Source

Versioning.

Feb 19, 2011:

11:33 PM Changeset in webkit [79147] by Lucas Forschler
  • 1 copy in tags/Safari-534.20.5

New tag.

10:20 PM Changeset in webkit [79146] by Lucas Forschler
  • 2 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r79133.

7:10 PM Changeset in webkit [79145] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-19 Andreas Kling <kling@webkit.org>

Reviewed by Oliver Hunt.

DragController should use Color::serialized() when passing colors to CSSStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=54545

  • page/DragController.cpp: (WebCore::DragController::concludeEditDrag):
5:00 PM Changeset in webkit [79144] by Laszlo Gombos
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-19 Laszlo Gombos <Laszlo Gombos>

Unreviewed build fix for Symbian.

[Symbian] Revert the removal of linking
against hal after r79126.

Dependency on the hal library can not be removed
as it is still used (e.g. in MarkStackSymbian.cpp).

4:44 PM Changeset in webkit [79143] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-02-19 Lukasz Slachciak <l.slachciak@samsung.com>

Reviewed by Andreas Kling.

[EFL] Eliminated error when .webkit directory doesn't exist.
https://bugs.webkit.org/show_bug.cgi?id=54813

  • ewk/ewk_main.cpp: (_ewk_init_body):
4:05 PM Changeset in webkit [79142] by barraclough@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

Interpreter build fix.

  • runtime/ArrayConstructor.cpp:
  • runtime/BooleanPrototype.cpp:
  • runtime/DateConstructor.cpp:
  • runtime/ErrorPrototype.cpp:
  • runtime/FunctionPrototype.cpp:
  • runtime/Lookup.cpp:
  • runtime/NumberPrototype.cpp:
  • runtime/ObjectConstructor.cpp:
  • runtime/ObjectPrototype.cpp:
  • runtime/RegExpPrototype.cpp:
  • runtime/StringConstructor.cpp:
3:59 PM Changeset in webkit [79141] by weinig@apple.com
  • 9 edits in trunk/Source

Add phase in addition to momentumPhase to platform wheel events
Part of <rdar://problem/8945362>

Reviewed by Anders Carlsson.

Rename existing phase to momentumPhase.

../WebCore:

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(WebCore::PlatformWheelEvent::momentumPhase):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):

  • platform/mac/WheelEventMac.mm:

(WebCore::momentumPhaseForEvent):
(WebCore::phaseForEvent):
(WebCore::PlatformWheelEvent::PlatformWheelEvent):

../WebKit2:

  • Shared/WebEvent.h:

(WebKit::WebWheelEvent::momentumPhase):

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):

  • Shared/WebWheelEvent.cpp:

(WebKit::WebWheelEvent::WebWheelEvent):
(WebKit::WebWheelEvent::encode):
(WebKit::WebWheelEvent::decode):

  • Shared/mac/WebEventFactory.mm:

(WebKit::phaseForEvent):
(WebKit::momentumPhaseForEvent):
(WebKit::WebEventFactory::createWebWheelEvent):

2:41 PM Changeset in webkit [79140] by barraclough@apple.com
  • 2 edits in trunk/Source/WebCore

Qt build fix.

  • bridge/runtime_method.h:

(JSC::RuntimeMethod::createStructure):

2:32 PM Changeset in webkit [79139] by barraclough@apple.com
  • 3 edits in trunk/Source/WebCore

Qt build fix.

  • bridge/qt/qt_instance.cpp:
  • bridge/qt/qt_pixmapruntime.cpp:
2:27 PM Changeset in webkit [79138] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix!!

2:24 PM Changeset in webkit [79137] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix!!

2:18 PM Changeset in webkit [79136] by barraclough@apple.com
  • 3 edits in trunk/Source/WebCore

Qt build fix.

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::getMethod):

  • bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::QtPixmapInstance::getMethod):

2:12 PM Changeset in webkit [79135] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix!

2:04 PM Changeset in webkit [79134] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix!

1:57 PM Changeset in webkit [79133] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-19 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Crash when trying to take a snapshot of an uninitialized plug-in
https://bugs.webkit.org/show_bug.cgi?id=54812

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::notifyWidget): Don't try to create a snapshot of the plug-in if it hasn't been initialized.
1:55 PM Changeset in webkit [79132] by barraclough@apple.com
  • 159 edits in trunk/Source

Bug 54786 - Devirtualize JSCell::classInfo()

Reviewed by Sam Weinig.

Instead of making a virtual function call, add a pointer to the ClassInfo
onto Structure.

This removes a virtual function call, and paves the way towards removing all
the createStructure methods, and StructureFlags/AnonymousSlotCount properties
(these should be able to move onto ClassInfo).

Calls to Structure::create must now pass a pointer to the ClassInfo for the
structure. All objects now have a ClassInfo pointer, non-object cell types
still do not.

Changes are most mechanical, involving three steps:

  • Remove virtual classInfo() methods.
  • Add &s_info parameter to calls to Structure::create.
  • Rename ClassInfo static members on classes from 'info' to 's_info', for consistency.

Source/JavaScriptCore:

  • API/JSCallbackConstructor.cpp:
  • API/JSCallbackConstructor.h:
  • API/JSCallbackFunction.cpp:
  • API/JSCallbackFunction.h:
  • API/JSCallbackObject.cpp:
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:
  • API/JSObjectRef.cpp:
  • API/JSValueRef.cpp:
  • API/JSWeakObjectMapRefPrivate.cpp:
  • JavaScriptCore.exp:
  • debugger/Debugger.cpp:
  • debugger/DebuggerActivation.h:
  • debugger/DebuggerCallFrame.cpp:
  • interpreter/Interpreter.cpp:
  • jit/JITCall32_64.cpp:
  • jit/JITOpcodes.cpp:
  • jit/JITStubs.cpp:
  • profiler/Profiler.cpp:
  • runtime/Arguments.cpp:
  • runtime/Arguments.h:
  • runtime/ArrayConstructor.cpp:
  • runtime/ArrayPrototype.cpp:
  • runtime/ArrayPrototype.h:
  • runtime/BooleanObject.cpp:
  • runtime/BooleanObject.h:
  • runtime/BooleanPrototype.cpp:
  • runtime/DateConstructor.cpp:
  • runtime/DateInstance.cpp:
  • runtime/DateInstance.h:
  • runtime/DatePrototype.cpp:
  • runtime/DatePrototype.h:
  • runtime/ErrorInstance.cpp:
  • runtime/ErrorInstance.h:
  • runtime/ErrorPrototype.cpp:
  • runtime/FunctionPrototype.cpp:
  • runtime/FunctionPrototype.h:
  • runtime/GetterSetter.h:
  • runtime/GlobalEvalFunction.h:
  • runtime/InternalFunction.cpp:
  • runtime/InternalFunction.h:
  • runtime/JSAPIValueWrapper.h:
  • runtime/JSActivation.cpp:
  • runtime/JSActivation.h:
  • runtime/JSArray.cpp:
  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp:
  • runtime/JSByteArray.h:
  • runtime/JSCell.cpp:
  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:
  • runtime/JSFunction.h:
  • runtime/JSGlobalData.cpp:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:
  • runtime/JSNotAnObject.h:
  • runtime/JSONObject.cpp:
  • runtime/JSONObject.h:
  • runtime/JSObject.cpp:
  • runtime/JSObject.h:
  • runtime/JSObjectWithGlobalObject.h:
  • runtime/JSPropertyNameIterator.h:
  • runtime/JSStaticScopeObject.h:
  • runtime/JSString.h:
  • runtime/JSVariableObject.h:
  • runtime/JSWrapperObject.h:
  • runtime/JSZombie.cpp:
  • runtime/JSZombie.h:
  • runtime/Lookup.cpp:
  • runtime/MathObject.cpp:
  • runtime/MathObject.h:
  • runtime/NativeErrorConstructor.cpp:
  • runtime/NativeErrorConstructor.h:
  • runtime/NumberConstructor.cpp:
  • runtime/NumberConstructor.h:
  • runtime/NumberObject.cpp:
  • runtime/NumberObject.h:
  • runtime/NumberPrototype.cpp:
  • runtime/ObjectConstructor.cpp:
  • runtime/ObjectPrototype.cpp:
  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpConstructor.h:
  • runtime/RegExpObject.cpp:
  • runtime/RegExpObject.h:
  • runtime/RegExpPrototype.cpp:
  • runtime/ScopeChain.cpp:
  • runtime/StringConstructor.cpp:
  • runtime/StringObject.cpp:
  • runtime/StringObject.h:
  • runtime/StringObjectThatMasqueradesAsUndefined.h:
  • runtime/StringPrototype.cpp:
  • runtime/StringPrototype.h:
  • runtime/Structure.cpp:
  • runtime/Structure.h:

Source/JavaScriptGlue:

  • JSUtils.cpp:

(KJSValueToJSObject):
(KJSValueToCFTypeInternal):

  • UserObjectImp.cpp:
  • UserObjectImp.h:

(UserObjectImp::createStructure):

Source/WebCore:

  • WebCore.exp.in:
  • bindings/js/JSAudioConstructor.cpp:
  • bindings/js/JSAudioConstructor.h:
  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMGlobalObject.cpp:
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSGeolocationCustom.cpp:
  • bindings/js/JSImageConstructor.cpp:
  • bindings/js/JSImageConstructor.h:
  • bindings/js/JSImageDataCustom.cpp:
  • bindings/js/JSOptionConstructor.cpp:
  • bindings/js/JSOptionConstructor.h:
  • bindings/js/JSWorkerContextBase.cpp:
  • bindings/js/JSWorkerContextBase.h:
  • bindings/js/SerializedScriptValue.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/c/CRuntimeObject.cpp:
  • bridge/c/CRuntimeObject.h:
  • bridge/c/c_instance.cpp:
  • bridge/jni/jsc/JNIUtilityPrivate.cpp:
  • bridge/jni/jsc/JavaInstanceJSC.cpp:
  • bridge/jni/jsc/JavaRuntimeObject.cpp:
  • bridge/jni/jsc/JavaRuntimeObject.h:
  • bridge/jsc/BridgeJSC.cpp:
  • bridge/objc/ObjCRuntimeObject.h:
  • bridge/objc/ObjCRuntimeObject.mm:
  • bridge/objc/objc_instance.mm:
  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:
  • bridge/runtime_array.cpp:
  • bridge/runtime_array.h:
  • bridge/runtime_method.cpp:
  • bridge/runtime_method.h:
  • bridge/runtime_object.cpp:
  • bridge/runtime_object.h:

Source/WebKit/mac:

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
(WebKit::ProxyRuntimeMethod::createStructure):

  • Plugins/Hosted/ProxyRuntimeObject.h:

(WebKit::ProxyRuntimeObject::createStructure):

  • Plugins/Hosted/ProxyRuntimeObject.mm:

(WebKit::ProxyRuntimeObject::ProxyRuntimeObject):

  • WebView/WebView.mm:

(aeDescFromJSValue):

Source/WebKit2:

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::JSNPMethod::JSNPMethod):

  • WebProcess/Plugins/Netscape/JSNPMethod.h:

(WebKit::JSNPMethod::createStructure):

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::JSNPObject):

  • WebProcess/Plugins/Netscape/JSNPObject.h:

(WebKit::JSNPObject::createStructure):

1:15 PM Changeset in webkit [79131] by ddkilzer@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

<http://webkit.org/b/54808> Change jsc target to build directly into JavaScriptCore.framework/Resources/jsc

Reviewed by Dan Bernstein.

  • Configurations/Base.xcconfig: Added

JAVASCRIPTCORE_FRAMEWORKS_DIR variable.

  • Configurations/JavaScriptCore.xcconfig: Used

JAVASCRIPTCORE_FRAMEWORKS_DIR to define INSTALL_PATH.

for Production configuration of jsc target.
(Copy Into Framework): Removed old build phase.
(Fix Framework Reference): Renamed build phase to "Copy Into
Framework". Added "set -x" call to make the script print the
commands it is running. Added code to exit early for Production
builds since this was never intended for them. Added code to
copy jsc into the JavaScriptCore.framework/Resources directory.

1:06 PM Changeset in webkit [79130] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

2011-02-19 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Martin Robinson.

[GTK] Remove mandatory Enchant dependency
https://bugs.webkit.org/show_bug.cgi?id=51587

Add enable-spellcheck option which decides whether to use enchant.
If disabled, WebKitGTK+ will not use enchant library.

  • configure.ac:

2011-02-19 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Martin Robinson.

[GTK] Remove mandatory Enchant dependency
https://bugs.webkit.org/show_bug.cgi?id=51587

Extract TextCheckerClientEnchant From EditorClientGtk and remove
enchant dependency from other files.

  • GNUmakefile.am:
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::EditorClient):
  • WebCoreSupport/EditorClientGtk.h: (WebKit::EditorClient::textChecker):
  • WebCoreSupport/TextCheckerClientEnchant.cpp: Added. (WebKit::TextCheckerClientEnchant::TextCheckerClientEnchant): (WebKit::TextCheckerClientEnchant::~TextCheckerClientEnchant): (WebKit::TextCheckerClientEnchant::ignoreWordInSpellDocument): (WebKit::TextCheckerClientEnchant::learnWord): (WebKit::TextCheckerClientEnchant::checkSpellingOfString): (WebKit::TextCheckerClientEnchant::getAutoCorrectSuggestionForMisspelledWord): (WebKit::TextCheckerClientEnchant::checkGrammarOfString): (WebKit::TextCheckerClientEnchant::getGuessesForWord): (WebKit::getAvailableDictionariesCallback): (WebKit::TextCheckerClientEnchant::updateSpellCheckingLanguage): (WebKit::TextCheckerClientEnchant::freeSpellCheckingLanguage):
  • WebCoreSupport/TextCheckerClientEnchant.h: Added. (WebKit::TextCheckerClientEnchant::requestCheckingOfString):
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_finalize): (webkit_web_settings_set_property):
  • webkit/webkitwebview.cpp: (webkit_web_view_settings_notify):
12:28 PM Changeset in webkit [79129] by commit-queue@webkit.org
  • 4 edits in trunk

2011-02-19 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Martin Robinson.

[cairo][canvas] Drawing from/into float rectangles with width or height in range 0 to 1 fails
https://bugs.webkit.org/show_bug.cgi?id=54491

Enable another passing test after fixing float values rounding.

  • platform/gtk/Skipped:

2011-02-19 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Martin Robinson.

[cairo][canvas] Drawing from/into float rectangles with width or height in range 0 to 1 fails
https://bugs.webkit.org/show_bug.cgi?id=54491

When width or height in float rectangle are in range (0, 0.5) or (-0.5, 0)
and would round to 0, alter the behaviour to ensure that width or height are
at least 1 pixel in size in these cases.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::roundToDevicePixels):
12:12 PM Changeset in webkit [79128] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

LLVM Compiler build fix.

  • platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::blurLayerImage): Eliminated a file static that generated
a global initializer since the compiler does not evaluate sqrtf at compile time.

11:05 AM Changeset in webkit [79127] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Rename performLookupAtCurrentMouseLocation to performDictionaryLookupAtCurrentMouseLocation

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView performDictionaryLookupAtCurrentMouseLocation]):

  • UIProcess/API/mac/WKViewPrivate.h:
10:05 AM Changeset in webkit [79126] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/JavaScriptCore

2011-02-19 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Symbian] OSAllocator implementation for Symbian OS.
Manages both data and code region requests. V8 and Sunspider tested
OK with interpreter. Not tested with JSC JIT yet as it has unrelated
failures. Also no thread safety yet.
https://bugs.webkit.org/show_bug.cgi?id=51128

  • JavaScriptCore.pri: removed HAL linkage
  • wtf/Bitmap.h: (WTF::::findRunOfZeros): find run of zeros in a bitmap. quick n dirty
  • wtf/OSAllocator.h: (WTF::OSAllocator::decommitAndRelease): decommit explicitly
  • wtf/OSAllocatorSymbian.cpp: Impl. of OSAllocator interface (WTF::allocateCodeChunk): utility for code chunks (WTF::deallocateCodeChunk): utility for code chunks (WTF::dataAllocatorInstance): getter for data allocator instance (WTF::OSAllocator::reserveUncommitted): (WTF::OSAllocator::releaseDecommitted): (WTF::OSAllocator::commit): (WTF::OSAllocator::decommit): (WTF::OSAllocator::reserveAndCommit): (WTF::PageAllocatorSymbian::PageAllocatorSymbian): maps requests to one underlying Symbian chunk (WTF::PageAllocatorSymbian::~PageAllocatorSymbian): (WTF::PageAllocatorSymbian::reserve): (WTF::PageAllocatorSymbian::release): (WTF::PageAllocatorSymbian::commit): (WTF::PageAllocatorSymbian::decommit): (WTF::PageAllocatorSymbian::contains):
  • wtf/PageAllocatorSymbian.h: Added. (WTF::SymbianChunk::SymbianChunk): wrapper around RChunk (WTF::SymbianChunk::~SymbianChunk): (WTF::SymbianChunk::contains):
8:06 AM Changeset in webkit [79125] by alex
  • 2 edits in trunk/LayoutTests

2011-02-19 Alejandro G. Castro <alex@igalia.com>

Unreviewed, fixed typo in the GTK+ skipped file.

  • platform/gtk/Skipped:
8:06 AM Changeset in webkit [79124] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-19 Yong Li <yoli@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=54687
When being built with armcc, "int" bit fields are treated as
unsigned integers, which will fail the comparisons like "m_offset == -1".
Using "signed" fixes the problem.

  • assembler/ARMAssembler.h:
  • assembler/ARMv7Assembler.h:
7:56 AM Changeset in webkit [79123] by commit-queue@webkit.org
  • 8 edits in trunk/Source

2011-02-19 Brian Ryner <bryner@chromium.org>

Reviewed by Adam Barth.

Replace the #include of DocumentLoader.h in Document.h with a
forward declaration, and add a missing #include now that this
transitive include is gone.
https://bugs.webkit.org/show_bug.cgi?id=50489

No new tests required.

  • bindings/ScriptControllerBase.cpp:
  • dom/Document.h:

2011-02-19 Brian Ryner <bryner@chromium.org>

Reviewed by Adam Barth.

Add missing #includes of DocumentLoader.h, needed since the transitive
include through Document.h is removed.
https://bugs.webkit.org/show_bug.cgi?id=50489

  • src/WebPageSerializerImpl.cpp:
  • src/WebSearchableFormData.cpp:

2011-02-19 Brian Ryner <bryner@chromium.org>

Reviewed by Adam Barth.

Add missing #include of DocumentLoader.h, needed since the transitive
include through Document.h is removed.
https://bugs.webkit.org/show_bug.cgi?id=50489

  • WebView/WebFrame.mm:
7:53 AM Changeset in webkit [79122] by Patrick Gansterer
  • 1 edit
    1 copy in trunk/Source/WebCore

2011-02-19 Patrick Gansterer <Patrick Gansterer>

Reviewed by Antonio Gomes.

[EFL] Remove WebCore::currentTime()
https://bugs.webkit.org/show_bug.cgi?id=53886

There is no declaration for it and we use WTF::currentTime() everywhere.

  • platform/efl/SystemTimeEfl.cpp:
7:45 AM Changeset in webkit [79121] by Patrick Gansterer
  • 2 edits
    1 move in trunk/Source/WebCore

2011-02-19 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Move KeygenWinCE from wince into win directory
https://bugs.webkit.org/show_bug.cgi?id=54804

Move this file into the win directory, since it can be used on all windows platforms.

  • CMakeListsWinCE.txt:
  • platform/win/SSLKeyGeneratorWin.cpp: Renamed from platform/wince/KeygenWinCE.cpp.
7:17 AM Changeset in webkit [79120] by Patrick Gansterer
  • 3 edits in trunk/Tools

2011-02-19 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Make WinCE a core builder
https://bugs.webkit.org/show_bug.cgi?id=54801

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
6:38 AM Changeset in webkit [79119] by Patrick Gansterer
  • 3 edits
    1 delete in trunk/Source/WebCore

2011-02-19 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Make FileChooserWin.cpp more portable and use it on WinCE
https://bugs.webkit.org/show_bug.cgi?id=54803

  • CMakeListsWinCE.txt:
  • platform/win/FileChooserWin.cpp: (WebCore::FileChooser::basenameForWidth):
  • platform/wince/FileChooserWinCE.cpp: Removed.
5:30 AM Changeset in webkit [79118] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-19 Benjamin Poulain <ikipou@gmail.com>

Reviewed by Andreas Kling.

[Qt] Enable the skipped tests combining workers and database
https://bugs.webkit.org/show_bug.cgi?id=54802

Enable the tests that do not seem to be flaky anymore.

  • platform/qt/Skipped:
2:01 AM Changeset in webkit [79117] by Lucas Forschler
  • 5 edits in branches/safari-534.20-branch/Source

Versioning again

1:49 AM Changeset in webkit [79116] by Lucas Forschler
  • 1 edit in branches/safari-534.20-branch/Source/WebKit2/ChangeLog

Versioning.

1:45 AM Changeset in webkit [79115] by Lucas Forschler
  • 6 edits in branches/safari-534.20-branch/Source

Versioning.

1:39 AM Changeset in webkit [79114] by simonjam@chromium.org
  • 13 edits in trunk

2011-02-19 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

Make ScriptElement match the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=54676

This implements the "prepare a script" section of the HTML5 spec in ScriptElement::prepareScript().
http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#prepare-a-script

There are a couple of things missing from the spec that would be new functionality. These will be added later.

  • Support for async=false
  • Empty src attribute should dispatch an error.

There are a couple of slight behavioral changes to match the spec.

  • An XHTML script that is loaded then copied will not fire load on the copy.
  • If onbeforeload moves the script to a different document, then it will not try to execute again because wasAlreadyStarted is true.

The parsers were updated to use the new API, but not rewritten to look like the spec. That will be done separately.

  • fast/dom/HTMLScriptElement/move-in-beforeload.html: Original author says test was only meant to check for crashes. Beforeload is not specified by HTML5. Test was modified to assume moved script wouldn't execute because wasAlreadyStarted is set.
  • fast/dom/script-clone-rerun-src.xhtml: According to HTML5 spec, load should only fire after a script executes. Test was modified to match that. The old broken behavior was that load fired on the cloned element, even though it didn't execute.

2011-02-19 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

Make ScriptElement match the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=54676

This implements the "prepare a script" section of the HTML5 spec in ScriptElement::prepareScript().
http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#prepare-a-script

There are a couple of things missing from the spec that would be new functionality. These will be added later.

  • Support for async=false
  • Empty src attribute should dispatch an error.

There are a couple of slight behavioral changes to match the spec.

  • An XHTML script that is loaded then copied will not fire load on the copy.
  • If onbeforeload moves the script to a different document, then it will not try to execute again because wasAlreadyStarted is true.

The parsers were updated to use the new API, but not rewritten to look like the spec. That will be done separately.

Test: All existing tests.

  • dom/ScriptElement.cpp: Rewritten to match HTML5 spec. (WebCore::ScriptElement::ScriptElement): (WebCore::ScriptElement::insertedIntoDocument): Logic moved to prepareScript. (WebCore::ScriptElement::childrenChanged): Logic moved to prepareScript. (WebCore::ScriptElement::handleSourceAttribute): Logic moved to prepareScript. (WebCore::isLegacySupportedJavaScriptLanguage): Added to support old script types in layout tests. (WebCore::ScriptElement::isScriptTypeSupported): Derived from old shouldExecuteAsJavaScript(). (WebCore::ScriptElement::prepareScript): START HERE. Main change. Should read exactly like HTML5's "prepare a script." Legacy type support needed for layout tests using XML parser. (WebCore::ScriptElement::requestScript): Most logic moved to prepareScript. Check security settings here. (WebCore::ScriptElement::executeScript): Combined evaluateScript() and executeScript() from old code. Logic moved to prepareScript. (WebCore::ScriptElement::stopLoadRequest): Ignore parser executed scripts. (WebCore::ScriptElement::execute): Renamed executeScript. (WebCore::ScriptElement::notifyFinished): We should only listen for non-parser executed scripts. (WebCore::ScriptElement::ignoresLoadRequest): New variable names. (WebCore::ScriptElement::childrenAreCommentsOrEmptyText): Added for HTML5 compliance. (WebCore::ScriptElement::scriptCharset): Use HTML5 variables.
  • dom/ScriptElement.h: (WebCore::ScriptElement::willBeParserExecuted): Added. (WebCore::ScriptElement::readyToBeParserExecuted): Added. (WebCore::ScriptElement::willExecuteWhenDocumentFinishedParsing): Added. (WebCore::ScriptElement::cachedScript): prepareScript() is the only place that should load scripts. This accessor lets the parsers listen for when loads finish. (WebCore::ScriptElement::isParserInserted): Added.
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::endElementNs): Should behave the same. Offloads much of its work to prepareScript().
  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseEndElement): Identical to libxml2 changes.
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::insertedIntoDocument): No longer needs url. (WebCore::HTMLScriptElement::hasSourceAttribute): Added.
  • html/HTMLScriptElement.h:
  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::requestPendingScript): Requesting scripts offloaded to ScriptElement. (WebCore::HTMLScriptRunner::runScript): Should behave the same. Offloads much of its work to prepareScript().
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::svgAttributeChanged): New ScriptElement function names. (WebCore::SVGScriptElement::insertedIntoDocument): No longer needs url. (WebCore::SVGScriptElement::finishParsingChildren): ScriptElement::finishParsingChildren is gone. (WebCore::SVGScriptElement::hasSourceAttribute): Added. (WebCore::SVGScriptElement::dispatchLoadEvent): New ScriptElement function names.
  • svg/SVGScriptElement.h:
1:35 AM Styling Form Controls edited by tkent@chromium.org
Mention validation messages (diff)
1:17 AM Changeset in webkit [79113] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-02-19 Lukasz Slachciak <l.slachciak@samsung.com>

Unreviewed build fix.

SoupSession build break fix
https://bugs.webkit.org/show_bug.cgi?id=54796

  • ewk/ewk_settings.cpp: (ewk_settings_proxy_uri_set):
12:58 AM Changeset in webkit [79112] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-19 Marc-Antoine Ruel <maruel@chromium.org>

Reviewed by James Robinson.

Split webcore_rendering off webcore_remaining to reduce its size for WPO builds
https://bugs.webkit.org/show_bug.cgi?id=54789

  • WebCore.gyp/WebCore.gyp:
12:46 AM Changeset in webkit [79111] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Updated test expectations (more fallout from r78846).

  • platform/chromium/test_expectations.txt:
12:39 AM Changeset in webkit [79110] by commit-queue@webkit.org
  • 4 edits
    1 copy in trunk/Source/WebCore

2011-02-19 Bill Budge <bbudge@chromium.org>

Reviewed by David Levin.

ThreadableLoaderClient needs willSendRequest method
https://bugs.webkit.org/show_bug.cgi?id=54688

No new tests. Exposes no new functionality

  • WebCore.gypi:
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::willSendRequest): (WebCore::DocumentThreadableLoader::didReceiveData): (WebCore::DocumentThreadableLoader::didReceiveCachedMetadata):
  • loader/DocumentThreadableLoaderClient.h: Added. (WebCore::DocumentThreadableLoaderClient::isDocumentThreadableLoaderClient): (WebCore::DocumentThreadableLoaderClient::willSendRequest):
  • loader/ThreadableLoaderClient.h: (WebCore::ThreadableLoaderClient::isDocumentThreadableLoaderClient):
12:33 AM Changeset in webkit [79109] by Lucas Forschler
  • 1 copy in tags/Safari-534.20.4

New tag.

12:31 AM Changeset in webkit [79108] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-02-19 Lukasz Slachciak <l.slachciak@samsung.com>

Reviewed by Andreas Kling.

[EFL] Use standard WebCore::homeDirectoryPath method instead of reimplementing it
https://webkit.org/b/54781

  • ewk/ewk_main.cpp: (_ewk_init_body):
12:29 AM Changeset in webkit [79107] by commit-queue@webkit.org
  • 39 edits
    3 adds in trunk

2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Tests that going forward within the same document does not stop loading.

  • http/tests/navigation/forward-to-fragment-fires-onload.html: Added.
  • http/tests/navigation/forward-to-fragment-fires-onload-expected.txt: Added.
  • http/tests/navigation/resources/forward-to-fragment-fires-onload-2.html: Added.

2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Avoid stopping all loaders in goToItem for same document navigations
or pseudo-back-forward URLs. Make HistoryController::goToItem private
to force callers to go through Page::goToItem. Also add a callback to
FrameLoaderClient to let clients decide whether to stop loading first.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • loader/EmptyClients.h:
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/HistoryController.cpp:
  • loader/HistoryController.h:
  • page/Page.cpp:

2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Call Page::goToItem instead of HistoryController::goToItem, so that
FrameLoader::stopAllLoaders is called first. Also adds a callback in
FrameLoaderClient for checking for pseudo-back-forward URLs.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::shouldStopLoadingForHistoryItem): Added.
  • src/FrameLoaderClientImpl.h:
  • src/WebFrameImpl.cpp:

2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/FrameLoaderClientEfl.h:

2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClientGtk::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/FrameLoaderClientGtk.h:

2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/FrameLoaderClientHaiku.h:

2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/WebFrameLoaderClient.h:

2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/FrameLoaderClientQt.h:

2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/WebFrameLoaderClient.h:

2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::shouldStopLoadingForHistoryItem): Added.
  • WebCoreSupport/FrameLoaderClientWinCE.h:

2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::shouldStopLoadingForHistoryItem): Added.
  • WebKitSupport/FrameLoaderClientWx.h:

2011-02-19 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517

Add a FrameLoaderClient callback for whether to stop loading before goToItem.

Test: http/tests/navigation/forward-to-fragment-fires-onload.html

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
12:12 AM Changeset in webkit [79106] by abarth@webkit.org
  • 5 edits in trunk

2011-02-19 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Fix xssAuditor/iframe-injection.html
https://bugs.webkit.org/show_bug.cgi?id=54591

Update expected results to show that we pass.

  • http/tests/security/xssAuditor/iframe-injection-expected.txt:

2011-02-19 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Fix xssAuditor/iframe-injection.html
https://bugs.webkit.org/show_bug.cgi?id=54591

We should block the iframe src attribute. Although this technically
can't be used to run script, it's a pretty easy vector for stealing
passwords.

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::filterTokenInitial): (WebCore::XSSFilter::filterIframeToken):
  • html/parser/XSSFilter.h:
12:07 AM Changeset in webkit [79105] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-02-19 Lukasz Slachciak <l.slachciak@samsung.com>

Reviewed by Andreas Kling.

Fixed problem with launching EWebLauncher with "run-launcher --efl". Incorrect path referring to non-existing .libs directory ws set.
https://webkit.org/b/54778

  • Scripts/webkitdirs.pm:

Feb 18, 2011:

11:57 PM Changeset in webkit [79104] by tonyg@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-02-18 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Let the parser yield for layout before running scripts
https://bugs.webkit.org/show_bug.cgi?id=54355

Prior to this patch, the parser would yield to perform a layout/paint before running a
script only if the script or a stylesheet blocking the script is not loaded yet. Since we
don't preload scan into the body while parsing the head, typically we'll block on a script
early in the body that causes us to yield to do the first paint within a reasonable time.

However, I'm planning to change the PreloadScanner to scan into the body from the head.
That significantly improves overall load time, but would hurt first paint time because
fewer scripts would be blocked during parsing and thus wouldn't yield.

This change causes us to yield before running scripts if we haven't painted yet (regardless
of whether or not the script is loaded). In addition to allowing the above mentioned
PreloadScanner change to be implemented without regressing first paint time, this also
improves first paint time by itself.

I tested Alexa's top 45 websites using Web Page Replay to control the content and simulate
bandwidth. This patch improved average first paint time by 1% over an unlimited connection,
6% over a 1Mbps connection and 11% over a 5Mbps connection. There was no statistically
signifcant change in page load time.

Within the pages tested, 33 had no statistically significant change in time to first paint,
12 improved, and none regressed. Of the improved, some of the standouts from the 1Mbps set
are: 20% on youtube, 37% on wiki, 27% on ebay, 13% on cnn, 16% on espn, 74% on sohu.

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::canTakeNextToken): This is the new yield point. (WebCore::HTMLDocumentParser::pumpTokenizer): Remove ASSERT that we are not paused. isPaused means that we are waiting for a script. Bug 54574 changed pumpTokenizer() so that it does the right thing whether we are just before a token or waiting for a script. Now that we may yield before a token or before a script, this may be called while paused.
  • html/parser/HTMLParserScheduler.cpp: (WebCore::isLayoutTimerActive): Added a FIXME because r52919 changed minimumLayoutDelay() to return m_extraLayoutDelay instead of 0 as a minimum. So checking !minimumLayoutDelay() no longer works. The fix is to change it to check minimumLayoutDelay() == m_extraLayoutDelay. But this is all the more reason to move this method onto Document. I'll do this in a follow up. (WebCore::HTMLParserScheduler::checkForYieldBeforeScript): Added.
  • page/FrameView.h: (WebCore::FrameView::hasEverPainted): Added.
11:22 PM Changeset in webkit [79103] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-18 Dawit Alemayehu <adawit@kde.org>

Reviewed by Andreas Kling.

[Qt] Button Element is rendered w/ text off-center.
https://bugs.webkit.org/show_bug.cgi?id=53373

Test: LayoutTests/fast/forms/button-white-space.html

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::adjustButtonStyle):
10:52 PM Changeset in webkit [79102] by levin@chromium.org
  • 3 edits in trunk/Tools

2011-02-18 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

check-webkit-style: Misses brace style error when the line with the { has a } in it.
https://bugs.webkit.org/show_bug.cgi?id=54769

  • Scripts/webkitpy/style/checkers/cpp.py: Fixed the check for the close brace to only look after the last open brace, so that the open brace in this line "} else {" will still be able to trigger the error.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added related unit tests.
10:16 PM Changeset in webkit [79101] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed test expectations fix.

  • platform/chromium/test_expectations.txt:
10:12 PM Changeset in webkit [79100] by Lucas Forschler
  • 1 edit in branches/safari-534.20-branch/Source/WebKit2/ChangeLog

Merge r79048.

10:05 PM Changeset in webkit [79099] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed test expectations fix.

  • platform/chromium/test_expectations.txt:
9:57 PM Changeset in webkit [79098] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

2011-02-18 Fabrizio Machado <fabrizio.machado@nokia.com>

Reviewed by Eric Seidel.

Remove reduntant checks.
https://bugs.webkit.org/show_bug.cgi?id=54764

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
  • WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationPresenterClientQt::toPage):
9:55 PM Changeset in webkit [79097] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Mark object-clip-rects-assertion.html as timing out.

  • platform/chromium/test_expectations.txt:
9:53 PM Changeset in webkit [79096] by commit-queue@webkit.org
  • 4 edits in trunk

2011-02-18 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Martin Robinson.

[Gtk] Re-enable meter tag support
https://bugs.webkit.org/show_bug.cgi?id=54762

Enable meter tag support in the configure.ac. This feature was
previously enabled by default in the makefile, but should be
enabled here after changes in r78981.

  • configure.ac:

2011-02-18 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Martin Robinson.

[Gtk] Re-enable meter tag support
https://bugs.webkit.org/show_bug.cgi?id=54762

Meter tag is supported on the Gtk port, enable it by default.

  • Scripts/build-webkit:
9:51 PM Changeset in webkit [79095] by levin@chromium.org
  • 4 edits in trunk/Tools

2011-02-18 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

check-webkit-style falsely complains about WebKitGTK+ public headers
https://bugs.webkit.org/show_bug.cgi?id=54650

  • Scripts/webkitpy/style/checker.py: Add some exceptions for the gtk files.
  • Scripts/webkitpy/style/checkers/cpp.py: Restrict the checks for WEBKIT_API to the chromium directory (and improved the checks slightly).
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added corresponding tests.
9:47 PM Changeset in webkit [79094] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations change.

  • platform/chromium/test_expectations.txt:
9:43 PM Changeset in webkit [79093] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-18 Jonathan Backer <backer@chromium.org>

Reviewed by Eric Seidel.

[chromium] Fix leak of texture IDs in compositor.
https://bugs.webkit.org/show_bug.cgi?id=54750

No new tests. It is extremely unlikely that this leak would have
any user visible impact because only a few bytes of space are wasted
(we're leaking texture IDs, not actual textures) and the space of
texture IDs is large (32 bits).

  • platform/graphics/chromium/TextureManager.cpp: (WebCore::TextureManager::requestTexture):
9:17 PM Changeset in webkit [79092] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-18 Dominic Mazzoni <dmazzoni@google.com>

Reviewed by Dimitri Glazkov.

Marks any actions triggered by performDefaultAction as a user
gesture, so that a user with a screen reader isn't prevented from
performing operations that must be triggered by a user gesture.
https://bugs.webkit.org/show_bug.cgi?id=54759

  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::performDefaultAction):
9:05 PM Changeset in webkit [79091] by Lucas Forschler
  • 2 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r79065.

9:02 PM Changeset in webkit [79090] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations change for chromium.

  • platform/chromium/test_expectations.txt:
9:00 PM Changeset in webkit [79089] by Lucas Forschler
  • 10 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r79057.

8:32 PM Changeset in webkit [79088] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations change because my rebaselines didn't seem to work.

  • platform/chromium/test_expectations.txt:
8:24 PM Changeset in webkit [79087] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-18 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Made MarkedSpace block iteration size-class agnostic
https://bugs.webkit.org/show_bug.cgi?id=54792


SunSpider reports no change.

  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::clearMarks): (JSC::MarkedSpace::sweep): (JSC::MarkedSpace::objectCount): (JSC::MarkedSpace::size): (JSC::MarkedSpace::capacity):
  • runtime/MarkedSpace.h: (JSC::MarkedSpace::forEach): Iterate blocks in hashing order instead of size class list order. This is a much simpler convention in a world of many different size classes.
8:02 PM Changeset in webkit [79086] by Lucas Forschler
  • 7 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r79020.

7:58 PM Changeset in webkit [79085] by yi.4.shen@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-18 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Tor Arne Vestbø.

Always display the media controls when requiresFullscreenForVideoPlayback() is true
https://bugs.webkit.org/show_bug.cgi?id=54308

For video element, it should have controls when
Chrome::requiresFullscreenForVideoPlayback() is true.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::controls):
7:53 PM Changeset in webkit [79084] by enne@google.com
  • 4 edits in trunk

2011-02-18 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Adjust expectations for chromium GPU tests.
https://bugs.webkit.org/show_bug.cgi?id=54409
https://bugs.webkit.org/show_bug.cgi?id=54509

Correct baselines for the 54409 images will be generated after this lands.

  • platform/chromium/test_expectations.txt:

2011-02-18 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

[chromium] Use nearest-neighbor filtering for root layer.
https://bugs.webkit.org/show_bug.cgi?id=54409
https://bugs.webkit.org/show_bug.cgi?id=54509

This setting creates more consistent images for LayoutTests and
prevents small floating point errors in texture coordinates from
creating off-by-one pixel color differences.

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::update):
7:52 PM Changeset in webkit [79083] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-18 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Andreas Kling.

Added friend exception to Qt platform, which also compiles Windows.

QtWebKit fails to compile on Windows XP with msvc-2008
https://bugs.webkit.org/show_bug.cgi?id=54746

  • bytecode/CodeBlock.h:
  • runtime/RegExpObject.h:
7:49 PM Changeset in webkit [79082] by Lucas Forschler
  • 3 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r79058.

7:46 PM BuildingQtOnLinux edited by bharathwaaj.s@gmail.com
Added solution provided by kling on irc for fixing Gold Linker Error. (diff)
7:45 PM Changeset in webkit [79081] by Lucas Forschler
  • 3 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r79023.

7:43 PM Changeset in webkit [79080] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-02-18 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Fix coding style errors in RenderThemeEfl.h
https://bugs.webkit.org/show_bug.cgi?id=54693

Fix style errors in RenderThemeEfl.h

  • platform/efl/RenderThemeEfl.h:
7:43 PM Changeset in webkit [79079] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-18 Geoffrey Garen <ggaren@apple.com>

(Rolled back in r79022 with crash fixed.)

Reviewed by Sam Weinig.

Use hashing instead of linear search in the conservative pointer test
https://bugs.webkit.org/show_bug.cgi?id=54767


SunSpider reports no change.

  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::destroy): No need to explicitly clear the blocks array, since freeBlock removes items for us.

(JSC::MarkedSpace::freeBlock): Fixed a typo that always removed the last
block from the block set instead of the block being freed. Changed to
remove a block from our data structures before deallocating it, since
this is slightly cleaner.

  • runtime/MarkedSpace.h: (JSC::MarkedSpace::contains): Variable-sized objects will use more, smaller blocks, so it's important for the contains check not to be O(n) in the number of blocks.
7:41 PM Changeset in webkit [79078] by Lucas Forschler
  • 3 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78959.

7:38 PM Changeset in webkit [79077] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-18 Ademar de Souza Reis Jr <Ademar Reis>

Reviewed by Andreas Kling.

[Qt] The localized vendor name for Qt SIS packages should be "Nokia"
https://bugs.webkit.org/show_bug.cgi?id=54742

This change was applied in the Qt repository (qt/src/3rdparty/webkit),
so we should do the same here in QtWebKit.

Patch by Eckhart Koppen <eckhart.koppen@nokia.com>
a8a84f1667966acfa093c4be0b7d4b0900ddd3d9:

The previously used name "Nokia, Qt" was not usable for Nokia
Content Signing, which only allows "Nokia" as the visible vendor
name. The unique vendor ID remains as "Nokia, Qt"

  • WebCore.pro:
7:35 PM Changeset in webkit [79076] by Lucas Forschler
  • 14 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78956.

7:35 PM Changeset in webkit [79075] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-02-18 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Fix coding style errors in ewk_frame.h
https://bugs.webkit.org/show_bug.cgi?id=54718

Fix style errors in ewk_frame.h.

  • ewk/ewk_frame.h:
7:31 PM Changeset in webkit [79074] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-18 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] REGRESSION(r67516) : on www.gmail.com a strange rendering issue appears on the
menu bar due to flash.
https://bugs.webkit.org/show_bug.cgi?id=54741

Only show plugins with a valid size. We then don't involve X11 if there is
nothing to see anyway.

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::platformStart):
7:27 PM Changeset in webkit [79073] by Lucas Forschler
  • 2 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r79050.

7:25 PM Changeset in webkit [79072] by commit-queue@webkit.org
  • 2 edits in trunk

2011-02-18 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Avoided UiTools dependency if the module is not present.

[Qt] WebKit patches required to work with a modularized version of Qt
https://bugs.webkit.org/show_bug.cgi?id=53916

  • Source/WebKit.pri:
7:23 PM Changeset in webkit [79071] by Lucas Forschler
  • 2 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r79059.

7:20 PM Changeset in webkit [79070] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-02-18 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Remove proxy feature of soup when proxy is null
https://bugs.webkit.org/show_bug.cgi?id=54621

When proxy value is NULL, remove proxy feature in soup.

  • ewk/ewk_settings.cpp: (ewk_settings_proxy_uri_set):
7:13 PM Changeset in webkit [79069] by commit-queue@webkit.org
  • 5 edits in trunk

2011-02-18 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Kent Tamura.

[EFL] Remove GDK dependency.
https://bugs.webkit.org/show_bug.cgi?id=53978

Remove checking GDK library.

  • Source/cmake/OptionsEfl.cmake:

2011-02-18 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Kent Tamura.

[EFL] Remove GDK dependency.
https://bugs.webkit.org/show_bug.cgi?id=53978

Remove GLIB_SUPPORT macro in GDK related code.
Regardless of GLIB_SUPPORT, getDefaultFontOptions() will works same way.

  • CMakeListsEfl.txt:
  • platform/graphics/freetype/FontPlatformDataFreeType.cpp: (WebCore::getDefaultFontOptions):
7:09 PM Changeset in webkit [79068] by Lucas Forschler
  • 4 edits in branches/safari-534.20-branch/Source/WebCore

Merge r79053.

7:07 PM Changeset in webkit [79067] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebKit/efl

2011-02-18 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Fix coding style errors in ewk_view.h
https://bugs.webkit.org/show_bug.cgi?id=54624

Fix style errors in ewk_view.h.

  • ewk/ewk_view.cpp: (ewk_view_pre_render_relative_radius):
  • ewk/ewk_view.h:
7:04 PM Changeset in webkit [79066] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-18 Peter Kasting <pkasting@google.com>

Reviewed by James Robinson.

https://bugs.webkit.org/show_bug.cgi?id=54605
Remove some time limits in a test, let test harnesses kill the test if
it runs long. Also changes a busy loop from 1 ms to 5 ms repeats since
this should be much less CPU at little visible cost.

  • http/tests/security/resources/cross-frame-access.js: (canAccessFrame.test): (canAccessFrame): (cannotAccessFrame.test): (cannotAccessFrame): (closeWindowAndNotifyDone.doneHandler): (closeWindowAndNotifyDone):
7:02 PM Changeset in webkit [79065] by Lucas Forschler
  • 2 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r79048.

6:22 PM Changeset in webkit [79064] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Real fix for <rdar://problem/9025723> CrashTracer: [USER]
1 crash in WebProcess at com.apple.WebKit2:
WebKit::WebPage::didChangeScrollOffsetForMainFrame + 31

Reviewed by Adele Peterson.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::didChangeScrollOffset):
Add null check for the FrameView. This function can be called when the
FrameView is being torn down during a transition to a new FrameView.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didChangeScrollOffsetForMainFrame):
Revert last attempt.

6:18 PM Changeset in webkit [79063] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-18 Noel Gordon <noel.gordon@gmail.com>

Reviewed by James Robinson.

[Chromium] Add elliptical gradient support to GradientSkia
https://bugs.webkit.org/show_bug.cgi?id=51841

Covered by existing tests, these need new rebaselines once this patch
lands for chrome linux, win32

fast/gradients/css3-color-stop-units.html
fast/gradients/css3-color-stops.html
fast/gradients/css3-linear-angle-gradients.html
fast/gradients/css3-radial-gradients.html
fast/gradients/css3-radial-gradients2.html
fast/gradients/css3-radial-gradients3.html
fast/gradients/css3-repeating-radial-gradients.html

  • platform/graphics/skia/GradientSkia.cpp: (WebCore::Gradient::platformGradient):
6:18 PM Changeset in webkit [79062] by dpranke@chromium.org
  • 6 edits in trunk/Tools

2011-02-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by James Robinson.

new-run-webkit-tests: enable multiple processes by default on
mac. This change removes the artificial restrictions we placed
on the # of child processes we used with the old threading
model, and switches to the new message-based model and multiple
processes, where available. If multiple processes are not
available (Leopard / Python 2.5), then we use the 'inline' model
instead of the 'old-threads' model on the 'mac' port or one
process on the 'chromium-mac' port. We need additional testing
to see if the new 'threads' model works reliably and is worth
supporting, or if we should just live with things being slightly
slow.

https://bugs.webkit.org/show_bug.cgi?id=54596

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
6:08 PM Changeset in webkit [79061] by Lucas Forschler
  • 2 edits in branches/safari-534.20-branch/Source/WebKit2

Merge r78832.

5:43 PM Changeset in webkit [79060] by commit-queue@webkit.org
  • 5 edits in trunk

2011-02-18 chris reiss <christopher.reiss@nokia.com>

Reviewed by Andreas Kling.

REGRESSION: Date.parse("Tue Nov 23 20:40:05 2010 GMT") returns NaN
https://bugs.webkit.org/show_bug.cgi?id=49989

  • fast/js/date-parse-test-expected.txt:
  • fast/js/script-tests/date-parse-test.js:

2011-02-18 chris reiss <christopher.reiss@nokia.com>

Reviewed by Andreas Kling.

REGRESSION: Date.parse("Tue Nov 23 20:40:05 2010 GMT") returns NaN
https://bugs.webkit.org/show_bug.cgi?id=49989

updated test fast/js/script-tests/date-parse-test.js

  • wtf/DateMath.cpp: (WTF::parseDateFromNullTerminatedCharacters):
5:43 PM Changeset in webkit [79059] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Hang trying to load nytimes.com with Flash installed
<rdar://problem/9018113>

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::sendSyncMessage):
Call beginWaitForSyncReply() before sending the message. Otherwise, in some cases we could
have gotten back a synchronous request before calling beginWaitForSyncReply(), and then we wouldn't
process it correctly. (Which would lead to the hang).

5:41 PM Changeset in webkit [79058] by Simon Fraser
  • 3 edits in trunk/Source/WebKit2

2011-02-18 Simon Fraser <Simon Fraser>

Reviewed by Kevin Decker.

<rdar://problem/9021296> Some plug-ins are the wrong size after zooming

Use the same frame/bounds adjustment that we use for NSView-based
plugins in WebKit2, which allows plug-ins and their snapshots to
render with the correct size after scaling.

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::setBoundsSize): (WebKit::PluginView::viewGeometryDidChange): (WebKit::PluginView::clipRectInWindowCoordinates):
  • WebProcess/Plugins/PluginView.h:
5:31 PM Changeset in webkit [79057] by Beth Dakin
  • 2 edits in trunk/Source/WebKit2

Fix for <rdar://problem/9025723> CrashTracer: [USER]
1 crash in WebProcess at com.apple.WebKit2:
WebKit::WebPage::didChangeScrollOffsetForMainFrame + 31

Rubber-stamped by Adele Peterson.

Simple null-check.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didChangeScrollOffsetForMainFrame):

5:23 PM Changeset in webkit [79056] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

2011-02-18 James Robinson <jamesr@chromium.org>

Fix typo in boundary test in ASSERT() - test is for an inclusive range, not exclusive.

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::updateTextureIfNeeded):
5:15 PM Changeset in webkit [79055] by atwilson@chromium.org
  • 3 edits in trunk/Tools

2011-02-18 Andrew Wilson <atwilson@chromium.org>

Unreviewed, rolling out r79047.
http://trac.webkit.org/changeset/79047
https://bugs.webkit.org/show_bug.cgi?id=54596

Broke canary bots - please watch the canaries the next time
you land this

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
5:11 PM Changeset in webkit [79054] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-02-18 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Tiled backing store area is too big.
Error in area calculcation causes size of backing store
up to 6 times bigger than viewport with default multipliers.
https://bugs.webkit.org/show_bug.cgi?id=54587

  • platform/graphics/TiledBackingStore.cpp: (WebCore::TiledBackingStore::createTiles):

2011-02-18 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Tiled backing store area is too big.
Error in area calculcation causes size of backing store
up to 8 times bigger than viewport with default multipliers.
https://bugs.webkit.org/show_bug.cgi?id=54587

  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::calculateKeepRect): (WebKit::TiledDrawingAreaProxy::calculateCoverRect):
5:05 PM Changeset in webkit [79053] by Beth Dakin
  • 4 edits in trunk/Source/WebCore

Fix for <rdar://problem/9018729> Horizontal scroller doesn't
appear when loading a page with a Horizontal scrollbar from
the back/forward cache.

Reviewed by Sam Weinig.

This patch adds a new bool member variable to FrameView to
keep track of whether we are loading a page from the back/
forward cache. If we are, don't suppress scrollbars on
first layout.

  • history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore):

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::layout):

  • page/FrameView.h:

(WebCore::FrameView::setIsRestoringFromBackForward):
(WebCore::FrameView::isRestoringFromBackForward):

5:00 PM Changeset in webkit [79052] by Patrick Gansterer
  • 4 edits in trunk/Source/WebCore

2011-02-18 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r78846.

  • platform/graphics/wince/FontWinCE.cpp: (WebCore::TextRunComponent::TextRunComponent):
  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::drawLineForText): (WebCore::GraphicsContext::drawLineForTextChecking): (WebCore::GraphicsContext::drawText):
  • platform/wince/FileChooserWinCE.cpp: (WebCore::FileChooser::basenameForWidth):
4:49 PM Changeset in webkit [79051] by Patrick Gansterer
  • 4 edits in trunk/Source/WebKit

2011-02-18 Patrick Gansterer <Patrick Gansterer>

Unreviewed build fix after r78634 and r78786.

  • CMakeLists.txt:

2011-02-18 Patrick Gansterer <Patrick Gansterer>

Unreviewed build fix after r78634 and r78786.

  • CMakeListsEfl.txt:
4:48 PM Changeset in webkit [79050] by sullivan@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9026169>
https://bugs.webkit.org/show_bug.cgi?id=54780
pendingAPIRequestURL isn't updated for WKPageGoToBackForwardListItem

Reviewed by Maciej Stachowiak.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::goToBackForwardItem):
Update the pending API URL.

4:42 PM Changeset in webkit [79049] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

2011-02-18 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

Crash in EventHandler::sendContextMenuEventForKey
https://bugs.webkit.org/show_bug.cgi?id=54495

Add test for triggering the context menu key event (VK_APPS) on a hidden
element.

  • fast/events/menu-keydown-on-hidden-element-expected.txt: Added.
  • fast/events/menu-keydown-on-hidden-element.html: Added.

2011-02-18 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

Crash in EventHandler::sendContextMenuEventForKey
https://bugs.webkit.org/show_bug.cgi?id=54495

Test: fast/events/menu-keydown-on-hidden-element.html

  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEventForKey): Add null check.

2011-02-18 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

Crash in EventHandler::sendContextMenuEventForKey
https://bugs.webkit.org/show_bug.cgi?id=54495

Add support for the context menu key (VK_APPS) to EventSender for
platforms that support the key.

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
  • DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::keyDown):
  • DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
4:32 PM Changeset in webkit [79048] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Accelerated content fades in when using a layer backed WKView
<rdar://problem/9021586>

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _enterAcceleratedCompositingMode:]):
Make a new nested CATransaction and disable animations when adding the layer
hosting subview. This avoids an implicit fade animation that would otherwise occur.

3:53 PM Changeset in webkit [79047] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: enable multiple processes by default on mac
https://bugs.webkit.org/show_bug.cgi?id=54596

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
3:47 PM Changeset in webkit [79046] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-02-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Roben.

Skip pretty patch unit tests if ruby isn't installed.

https://bugs.webkit.org/show_bug.cgi?id=54699

  • Scripts/webkitpy/common/prettypatch_unittest.py:
3:42 PM Changeset in webkit [79045] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-02-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Roben.

Skip mac.test_skipped_file_paths() when running on win32; the
test has hardcoded '/' directory separators and since it's a
port-specific test and we have coverage on other ports it's not
worth it to make the test more generic.

https://bugs.webkit.org/show_bug.cgi?id=54698

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3:42 PM Changeset in webkit [79044] by Csaba Osztrogonác
  • 12 edits
    1 copy
    694 adds in trunk/LayoutTests

Unreviewed.

[Qt] Add Qt specific expected results for passing svg/custom tests.

  • platform/qt/Skipped: Unskip passing tests.
  • platform/qt/svg/custom/ [...] : Added.
3:39 PM Changeset in webkit [79043] by enne@google.com
  • 18 edits
    1 copy
    5 adds in trunk/Source/WebCore

2011-02-15 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Clean up shader code from LayerChromium classes
https://bugs.webkit.org/show_bug.cgi?id=54484

This is a refactoring and there should be no change in functionality.
All shader code is pulled out into classes in ShaderChromium.
The SharedValues classes are now turned into ProgramBinding, one per
shader program. These contain shader classes that know about what
variables they can bind.

  • WebCore.gypi:
  • platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::draw):
  • platform/graphics/chromium/CanvasLayerChromium.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/GeometryBinding.cpp: Added. (WebCore::GeometryBinding::GeometryBinding): (WebCore::GeometryBinding::~GeometryBinding): (WebCore::GeometryBinding::prepareForDraw):
  • platform/graphics/chromium/GeometryBinding.h: Copied from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h. (WebCore::GeometryBinding::initialized): (WebCore::GeometryBinding::context): (WebCore::GeometryBinding::quadVerticesVbo): (WebCore::GeometryBinding::quadElementsVbo): (WebCore::GeometryBinding::positionAttribLocation): (WebCore::GeometryBinding::texCoordAttribLocation):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::drawDebugBorder):
  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::sharedGeometry): (WebCore::LayerRendererChromium::borderProgram): (WebCore::LayerRendererChromium::contentLayerProgram): (WebCore::LayerRendererChromium::canvasLayerProgram): (WebCore::LayerRendererChromium::videoLayerRGBAProgram): (WebCore::LayerRendererChromium::videoLayerYUVProgram): (WebCore::LayerRendererChromium::pluginLayerProgram): (WebCore::LayerRendererChromium::renderSurfaceProgram): (WebCore::LayerRendererChromium::renderSurfaceMaskProgram): (WebCore::LayerRendererChromium::tilerProgram):
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::draw): (WebCore::LayerTilerChromium::drawTexturedQuad):
  • platform/graphics/chromium/LayerTilerChromium.h:
  • platform/graphics/chromium/PluginLayerChromium.cpp: (WebCore::PluginLayerChromium::draw):
  • platform/graphics/chromium/PluginLayerChromium.h:
  • platform/graphics/chromium/ProgramBinding.cpp: Added. (WebCore::ProgramBindingBase::ProgramBindingBase): (WebCore::ProgramBindingBase::~ProgramBindingBase): (WebCore::ProgramBindingBase::init): (WebCore::ProgramBindingBase::loadShader): (WebCore::ProgramBindingBase::createShaderProgram):
  • platform/graphics/chromium/ProgramBinding.h: Added. (WebCore::ProgramBindingBase::program): (WebCore::ProgramBindingBase::initialized): (WebCore::ProgramBinding::ProgramBinding): (WebCore::ProgramBinding::vertexShader): (WebCore::ProgramBinding::fragmentShader):
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::drawSurface):
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/ShaderChromium.cpp: Added. (WebCore::VertexShaderPosTex::VertexShaderPosTex): (WebCore::VertexShaderPosTex::init): (WebCore::VertexShaderPosTex::getShaderString): (WebCore::VertexShaderPosTexYUVStretch::VertexShaderPosTexYUVStretch): (WebCore::VertexShaderPosTexYUVStretch::init): (WebCore::VertexShaderPosTexYUVStretch::getShaderString): (WebCore::VertexShaderPos::VertexShaderPos): (WebCore::VertexShaderPos::init): (WebCore::VertexShaderPos::getShaderString): (WebCore::VertexShaderPosTexTransform::VertexShaderPosTexTransform): (WebCore::VertexShaderPosTexTransform::init): (WebCore::VertexShaderPosTexTransform::getShaderString): (WebCore::FragmentTexAlphaBinding::FragmentTexAlphaBinding): (WebCore::FragmentTexAlphaBinding::init): (WebCore::FragmentShaderRGBATexFlipAlpha::getShaderString): (WebCore::FragmentShaderRGBATexAlpha::getShaderString): (WebCore::FragmentShaderBGRATexAlpha::getShaderString): (WebCore::FragmentShaderRGBATexAlphaMask::FragmentShaderRGBATexAlphaMask): (WebCore::FragmentShaderRGBATexAlphaMask::init): (WebCore::FragmentShaderRGBATexAlphaMask::getShaderString): (WebCore::FragmentShaderYUVVideo::FragmentShaderYUVVideo): (WebCore::FragmentShaderYUVVideo::init): (WebCore::FragmentShaderYUVVideo::getShaderString): (WebCore::FragmentShaderColor::FragmentShaderColor): (WebCore::FragmentShaderColor::init): (WebCore::FragmentShaderColor::getShaderString):
  • platform/graphics/chromium/ShaderChromium.h: Added. (WebCore::VertexShaderPosTex::matrixLocation): (WebCore::VertexShaderPosTexYUVStretch::matrixLocation): (WebCore::VertexShaderPosTexYUVStretch::yWidthScaleFactorLocation): (WebCore::VertexShaderPosTexYUVStretch::uvWidthScaleFactorLocation): (WebCore::VertexShaderPos::matrixLocation): (WebCore::VertexShaderPosTexTransform::matrixLocation): (WebCore::VertexShaderPosTexTransform::texTransformLocation): (WebCore::FragmentTexAlphaBinding::alphaLocation): (WebCore::FragmentTexAlphaBinding::samplerLocation): (WebCore::FragmentShaderRGBATexAlphaMask::alphaLocation): (WebCore::FragmentShaderRGBATexAlphaMask::samplerLocation): (WebCore::FragmentShaderRGBATexAlphaMask::maskSamplerLocation): (WebCore::FragmentShaderYUVVideo::yTextureLocation): (WebCore::FragmentShaderYUVVideo::uTextureLocation): (WebCore::FragmentShaderYUVVideo::vTextureLocation): (WebCore::FragmentShaderYUVVideo::alphaLocation): (WebCore::FragmentShaderYUVVideo::ccMatrixLocation): (WebCore::FragmentShaderYUVVideo::signAdjLocation): (WebCore::FragmentShaderColor::colorLocation):
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::draw): (WebCore::VideoLayerChromium::drawYUV): (WebCore::VideoLayerChromium::drawRGBA):
  • platform/graphics/chromium/VideoLayerChromium.h:
3:39 PM Changeset in webkit [79042] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-02-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Roben.

Fix webkitpy.layout_tests.port.config_unittest to work on Win32.

https://bugs.webkit.org/show_bug.cgi?id=54703

  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
3:34 PM Changeset in webkit [79041] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-02-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Roben.

Change the default port we're mocking out on win32 when we
run mock_drt_unittest. Normally we'd default to the
port-specific default, but that would be "win", which doesn't
currently work.

https://bugs.webkit.org/show_bug.cgi?id=38756

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3:27 PM Changeset in webkit [79040] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

2011-02-18 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Plugin snapshot location is wrong for subframes
https://bugs.webkit.org/show_bug.cgi?id=54776

Only change the CTM to the way that the plugin expects it
when painting the plugin, not when drawing the snapshot.
This fixes the snapshot location when painting flattened
frames.

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::paint):
3:21 PM Changeset in webkit [79039] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations change.

  • platform/chromium/test_expectations.txt:
3:20 PM Changeset in webkit [79038] by kbr@google.com
  • 5 edits in trunk

2011-02-18 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Clean up initialization of minimum timer interval
https://bugs.webkit.org/show_bug.cgi?id=54772

Rolled forward Chromium DEPS to pick up new webkit_support entry
point. Removed setting of default minimum timer interval, as this
is now done every time WebPreferences are applied.

Tested with Chromium DRT port built from WebKit workspace; ran
fast/dom/ layout tests.

  • DEPS:
  • src/WebKit.cpp: (WebKit::initialize):

2011-02-18 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Clean up initialization of minimum timer interval
https://bugs.webkit.org/show_bug.cgi?id=54772

Use new GetForegroundTabTimerInterval function in webkit_support
to reset the minimum timer interval before each test.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::reset):
3:07 PM Changeset in webkit [79037] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r79022.
http://trac.webkit.org/changeset/79022
https://bugs.webkit.org/show_bug.cgi?id=54775

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-02-18
It broke the whole world (Requested by Ossy on #webkit).

  • runtime/MarkedSpace.h:

(JSC::MarkedSpace::contains):

2:58 PM Changeset in webkit [79036] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-02-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Roben.

r78494 fixed the chromium_win unittest failing under win32,
but not cygwin. This fixes cygwin as well.

https://bugs.webkit.org/show_bug.cgi?id=54652

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
2:48 PM Changeset in webkit [79035] by dpranke@chromium.org
  • 6 edits in trunk/Tools

2011-02-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai, Mihai Parparita.

new-run-webkit-tests: r78522 made it impossible to create a
'chromium-win' or 'chromium-mac' port; they would always get the
version tacked on to the end. It turns out that we actually need
to be able to create these ports in order for
rebaseline-chromium-webkit-tests to work correctly given the
broken coverage of our layout bots. As soon as we get SL and
Win 7 bots running reliably on the canaries, we can get rid of
this change. Note that we only need to change the chromium_mac
and win ports because linux doesn't yet use versions and that
script doesn't work with non-chromium ports.

Also, this change fixes a bug where we were using
"platform/chromium-win-win7" and
"platform/chromium-mac-snowleopard" as the baseline dirs for
Win 7 and SL; we should've been using the generic directories
instead since they are the newest versions of the os's.

https://bugs.webkit.org/show_bug.cgi?id=54691

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2:21 PM Changeset in webkit [79034] by atwilson@chromium.org
  • 112 edits
    449 adds
    16 deletes in trunk/LayoutTests

Unreviewed rebaselines for Chromium.

  • platform/chromium-mac/compositing/reflections/deeply-nested-reflections-expected.checksum: Added.
  • platform/chromium-mac/compositing/reflections/deeply-nested-reflections-expected.png: Added.
  • platform/chromium-mac/css1/box_properties/clear_float-expected.checksum:
  • platform/chromium-mac/css1/box_properties/clear_float-expected.png:
  • platform/chromium-mac/css1/box_properties/float_elements_in_series-expected.checksum: Added.
  • platform/chromium-mac/css1/box_properties/float_elements_in_series-expected.png: Added.
  • platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.checksum:
  • platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-mac/css1/text_properties/text_align-expected.checksum: Added.
  • platform/chromium-mac/css1/text_properties/text_align-expected.png: Added.
  • platform/chromium-mac/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Added.
  • platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
  • platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-mac/css2.1/t1202-counter-03-b-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1202-counter-03-b-expected.png: Added.
  • platform/chromium-mac/css2.1/t1202-counter-04-b-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1202-counter-04-b-expected.png: Added.
  • platform/chromium-mac/css2.1/t1202-counter-04-b-expected.txt: Added.
  • platform/chromium-mac/css2.1/t1202-counters-03-b-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1202-counters-03-b-expected.png: Added.
  • platform/chromium-mac/css2.1/t1202-counters-04-b-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1202-counters-04-b-expected.png: Added.
  • platform/chromium-mac/css2.1/t1202-counters-04-b-expected.txt: Added.
  • platform/chromium-mac/css2.1/t1602-c43-center-00-d-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1602-c43-center-00-d-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t1602-c546-txt-align-00-b-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1602-c546-txt-align-00-b-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-tab-003-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/delete-tab-003-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-001-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-001-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-tab-003-expected.checksum: Added.
  • platform/chromium-mac/editing/inserting/insert-tab-003-expected.png: Added.
  • platform/chromium-mac/editing/inserting/typing-tab-designmode-forms-expected.checksum: Added.
  • platform/chromium-mac/editing/inserting/typing-tab-designmode-forms-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/4641033-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/4641033-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/block-wrappers-necessary-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/block-wrappers-necessary-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/nested-blocks-with-text-area-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/nested-blocks-with-text-area-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/nested-blocks-with-text-field-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/nested-blocks-with-text-field-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-2-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-2-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/pasting-tabs-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/pasting-tabs-expected.png: Added.
  • platform/chromium-mac/editing/selection/3690703-2-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/3690703-2-expected.png: Added.
  • platform/chromium-mac/editing/selection/3690703-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/3690703-expected.png: Added.
  • platform/chromium-mac/editing/selection/3690719-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/3690719-expected.png: Added.
  • platform/chromium-mac/editing/selection/4397952-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/4397952-expected.png: Added.
  • platform/chromium-mac/editing/selection/4975120-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/4975120-expected.png: Added.
  • platform/chromium-mac/editing/selection/5240265-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/5240265-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-rtl-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.png:
  • platform/chromium-mac/editing/selection/extend-selection-bidi-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/extend-selection-bidi-expected.png: Added.
  • platform/chromium-mac/editing/selection/move-past-trailing-space-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/replaced-boundaries-3-expected.checksum:
  • platform/chromium-mac/editing/selection/replaced-boundaries-3-expected.png: Added.
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.png: Added.
  • platform/chromium-mac/editing/style/5046875-1-expected.checksum: Added.
  • platform/chromium-mac/editing/style/5046875-1-expected.png: Added.
  • platform/chromium-mac/editing/style/create-block-for-style-011-expected.checksum: Removed.
  • platform/chromium-mac/editing/style/create-block-for-style-011-expected.png: Removed.
  • platform/chromium-mac/editing/style/create-block-for-style-012-expected.checksum: Removed.
  • platform/chromium-mac/editing/style/create-block-for-style-012-expected.png: Removed.
  • platform/chromium-mac/editing/style/table-selection-expected.checksum: Added.
  • platform/chromium-mac/editing/style/table-selection-expected.png: Added.
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.checksum:
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-mac/fast/block/positioning/inline-block-relposition-expected.checksum: Added.
  • platform/chromium-mac/fast/block/positioning/inline-block-relposition-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.png:
  • platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.txt: Added.
  • platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.checksum:
  • platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.png:
  • platform/chromium-mac/fast/blockflow/japanese-lr-text-expected.checksum:
  • platform/chromium-mac/fast/blockflow/japanese-lr-text-expected.png:
  • platform/chromium-mac/fast/blockflow/japanese-rl-selection-expected.checksum:
  • platform/chromium-mac/fast/blockflow/japanese-rl-selection-expected.png:
  • platform/chromium-mac/fast/blockflow/japanese-rl-text-expected.checksum:
  • platform/chromium-mac/fast/blockflow/japanese-rl-text-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/vertical-align-table-baseline-expected.checksum:
  • platform/chromium-mac/fast/blockflow/vertical-align-table-baseline-expected.png:
  • platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.checksum:
  • platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.png:
  • platform/chromium-mac/fast/blockflow/vertical-font-fallback-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/vertical-font-fallback-expected.png: Added.
  • platform/chromium-mac/fast/css/beforeSelectorOnCodeElement-expected.checksum: Added.
  • platform/chromium-mac/fast/css/beforeSelectorOnCodeElement-expected.png: Added.
  • platform/chromium-mac/fast/css/continuationCrash-expected.checksum: Added.
  • platform/chromium-mac/fast/css/continuationCrash-expected.png: Added.
  • platform/chromium-mac/fast/css/css2-system-fonts-expected.checksum: Added.
  • platform/chromium-mac/fast/css/css2-system-fonts-expected.png: Added.
  • platform/chromium-mac/fast/css/font-face-default-font-expected.checksum: Added.
  • platform/chromium-mac/fast/css/font-face-default-font-expected.png: Added.
  • platform/chromium-mac/fast/css/font-face-locally-installed-expected.checksum: Added.
  • platform/chromium-mac/fast/css/font-face-locally-installed-expected.png: Added.
  • platform/chromium-mac/fast/css/margin-top-bottom-dynamic-expected.checksum: Added.
  • platform/chromium-mac/fast/css/margin-top-bottom-dynamic-expected.png: Added.
  • platform/chromium-mac/fast/css/rtl-ordering-expected.checksum: Added.
  • platform/chromium-mac/fast/css/rtl-ordering-expected.png: Added.
  • platform/chromium-mac/fast/css/text-input-with-webkit-border-radius-expected.checksum: Added.
  • platform/chromium-mac/fast/css/text-input-with-webkit-border-radius-expected.png: Added.
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-bidi-expected.checksum: Added.
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-bidi-expected.png: Added.
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.checksum: Added.
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.png: Added.
  • platform/chromium-mac/fast/css/text-security-expected.checksum: Added.
  • platform/chromium-mac/fast/css/text-security-expected.png: Added.
  • platform/chromium-mac/fast/dom/52776-expected.txt:
  • platform/chromium-mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Added.
  • platform/chromium-mac/fast/dynamic/008-expected.checksum: Added.
  • platform/chromium-mac/fast/dynamic/008-expected.png: Added.
  • platform/chromium-mac/fast/events/autoscroll-expected.checksum: Added.
  • platform/chromium-mac/fast/events/autoscroll-expected.png: Added.
  • platform/chromium-mac/fast/events/context-no-deselect-expected.checksum: Added.
  • platform/chromium-mac/fast/events/context-no-deselect-expected.png: Added.
  • platform/chromium-mac/fast/forms/HTMLOptionElement_label01-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/HTMLOptionElement_label01-expected.png: Added.
  • platform/chromium-mac/fast/forms/HTMLOptionElement_label02-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/HTMLOptionElement_label02-expected.png: Added.
  • platform/chromium-mac/fast/forms/HTMLOptionElement_label03-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/HTMLOptionElement_label03-expected.png: Added.
  • platform/chromium-mac/fast/forms/HTMLOptionElement_label04-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/HTMLOptionElement_label04-expected.png: Added.
  • platform/chromium-mac/fast/forms/basic-buttons-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/basic-buttons-expected.png: Added.
  • platform/chromium-mac/fast/forms/basic-selects-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/basic-selects-expected.png: Added.
  • platform/chromium-mac/fast/forms/basic-selects-expected.txt: Added.
  • platform/chromium-mac/fast/forms/basic-textareas-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/basic-textareas-expected.png: Added.
  • platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.png: Added.
  • platform/chromium-mac/fast/forms/blankbuttons-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/blankbuttons-expected.png: Added.
  • platform/chromium-mac/fast/forms/button-align-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/button-align-expected.png: Added.
  • platform/chromium-mac/fast/forms/button-cannot-be-nested-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/button-cannot-be-nested-expected.png: Added.
  • platform/chromium-mac/fast/forms/button-default-title-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/button-default-title-expected.png: Added.
  • platform/chromium-mac/fast/forms/button-generated-content-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/button-generated-content-expected.png: Added.
  • platform/chromium-mac/fast/forms/button-positioned-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/button-positioned-expected.png: Added.
  • platform/chromium-mac/fast/forms/button-sizes-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/button-sizes-expected.png: Added.
  • platform/chromium-mac/fast/forms/button-style-color-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/button-style-color-expected.png: Added.
  • platform/chromium-mac/fast/forms/button-table-styles-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/button-table-styles-expected.png: Added.
  • platform/chromium-mac/fast/forms/button-text-transform-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/button-text-transform-expected.png: Added.
  • platform/chromium-mac/fast/forms/button-white-space-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/button-white-space-expected.png: Added.
  • platform/chromium-mac/fast/forms/control-clip-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/control-clip-expected.png: Added.
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.png: Added.
  • platform/chromium-mac/fast/forms/file-input-direction-expected.checksum:
  • platform/chromium-mac/fast/forms/file-input-direction-expected.png:
  • platform/chromium-mac/fast/forms/file-input-direction-expected.txt:
  • platform/chromium-mac/fast/forms/formmove3-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/formmove3-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-align-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-align-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.checksum:
  • platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-appearance-disabled-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-appearance-disabled-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-appearance-focus-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-appearance-focus-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-appearance-preventDefault-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-appearance-preventDefault-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-appearance-readonly-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-appearance-selection-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-appearance-selection-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-appearance-visibility-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-appearance-visibility-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-appearance-width-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-appearance-width-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-button-sizes-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-button-sizes-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-disabled-color-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-disabled-color-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-field-text-truncated-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-field-text-truncated-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-file-re-render-expected.checksum:
  • platform/chromium-mac/fast/forms/input-file-re-render-expected.png:
  • platform/chromium-mac/fast/forms/input-first-letter-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-first-letter-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-spaces-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-spaces-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-table-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-table-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-text-double-click-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-text-double-click-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-text-drag-down-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-text-drag-down-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-text-word-wrap-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-text-word-wrap-expected.png: Added.
  • platform/chromium-mac/fast/forms/menulist-no-overflow-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/menulist-no-overflow-expected.png: Added.
  • platform/chromium-mac/fast/forms/menulist-option-wrap-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png: Added.
  • platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.png: Added.
  • platform/chromium-mac/fast/forms/menulist-style-color-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/menulist-style-color-expected.png: Added.
  • platform/chromium-mac/fast/forms/menulist-width-change-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/menulist-width-change-expected.png: Added.
  • platform/chromium-mac/fast/forms/option-strip-whitespace-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/option-strip-whitespace-expected.png: Added.
  • platform/chromium-mac/fast/forms/option-text-clip-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/option-text-clip-expected.png: Added.
  • platform/chromium-mac/fast/forms/placeholder-position-expected.checksum:
  • platform/chromium-mac/fast/forms/placeholder-position-expected.png:
  • platform/chromium-mac/fast/forms/placeholder-set-value-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/placeholder-set-value-expected.png: Added.
  • platform/chromium-mac/fast/forms/plaintext-mode-2-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/plaintext-mode-2-expected.png: Added.
  • platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.png: Added.
  • platform/chromium-mac/fast/forms/search-rtl-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/search-rtl-expected.png: Added.
  • platform/chromium-mac/fast/forms/search-transformed-expected.checksum:
  • platform/chromium-mac/fast/forms/search-transformed-expected.png:
  • platform/chromium-mac/fast/forms/search-zoomed-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/search-zoomed-expected.png: Added.
  • platform/chromium-mac/fast/forms/select-align-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/select-align-expected.png: Added.
  • platform/chromium-mac/fast/forms/select-baseline-expected.checksum:
  • platform/chromium-mac/fast/forms/select-baseline-expected.png:
  • platform/chromium-mac/fast/forms/select-change-listbox-to-popup-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/select-change-listbox-to-popup-expected.png: Added.
  • platform/chromium-mac/fast/forms/select-disabled-appearance-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/select-disabled-appearance-expected.png: Added.
  • platform/chromium-mac/fast/forms/select-initial-position-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/select-initial-position-expected.png: Added.
  • platform/chromium-mac/fast/forms/select-selected-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/select-selected-expected.png: Added.
  • platform/chromium-mac/fast/forms/select-visual-hebrew-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/select-visual-hebrew-expected.png: Added.
  • platform/chromium-mac/fast/forms/stuff-on-my-optgroup-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/stuff-on-my-optgroup-expected.png: Added.
  • platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/tabbing-input-iframe-expected.png: Added.
  • platform/chromium-mac/fast/forms/targeted-frame-submission-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/targeted-frame-submission-expected.png: Added.
  • platform/chromium-mac/fast/forms/text-style-color-expected.checksum:
  • platform/chromium-mac/fast/forms/text-style-color-expected.png:
  • platform/chromium-mac/fast/forms/textarea-align-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/textarea-align-expected.png: Added.
  • platform/chromium-mac/fast/forms/textarea-placeholder-set-value-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/textarea-placeholder-set-value-expected.png: Added.
  • platform/chromium-mac/fast/forms/textarea-scroll-height-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/textarea-scroll-height-expected.png: Added.
  • platform/chromium-mac/fast/forms/textarea-scrolled-type-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/textarea-scrolled-type-expected.png: Added.
  • platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png: Added.
  • platform/chromium-mac/fast/html/keygen-expected.checksum: Added.
  • platform/chromium-mac/fast/html/keygen-expected.png: Added.
  • platform/chromium-mac/fast/inline/inline-box-background-expected.checksum:
  • platform/chromium-mac/fast/inline/inline-box-background-expected.png:
  • platform/chromium-mac/fast/inline/inline-box-background-long-image-expected.checksum:
  • platform/chromium-mac/fast/inline/inline-box-background-long-image-expected.png:
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.checksum:
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.png:
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.checksum:
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.png:
  • platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.checksum: Added.
  • platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.png: Added.
  • platform/chromium-mac/fast/multicol/float-avoidance-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/float-avoidance-expected.png: Added.
  • platform/chromium-mac/fast/multicol/shadow-breaking-expected.checksum:
  • platform/chromium-mac/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum: Added.
  • platform/chromium-mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png: Added.
  • platform/chromium-mac/fast/parser/document-write-option-expected.checksum: Added.
  • platform/chromium-mac/fast/parser/document-write-option-expected.png: Added.
  • platform/chromium-mac/fast/parser/entity-comment-in-textarea-expected.checksum: Added.
  • platform/chromium-mac/fast/parser/entity-comment-in-textarea-expected.png: Added.
  • platform/chromium-mac/fast/parser/open-comment-in-textarea-expected.checksum: Added.
  • platform/chromium-mac/fast/parser/open-comment-in-textarea-expected.png: Added.
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.checksum:
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.png:
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-9-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
  • platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/replaced/width100percent-button-expected.checksum: Added.
  • platform/chromium-mac/fast/replaced/width100percent-button-expected.png: Added.
  • platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.checksum: Added.
  • platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.png: Added.
  • platform/chromium-mac/fast/replaced/width100percent-textarea-expected.checksum:
  • platform/chromium-mac/fast/replaced/width100percent-textarea-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-textfield-expected.checksum: Added.
  • platform/chromium-mac/fast/replaced/width100percent-textfield-expected.png: Added.
  • platform/chromium-mac/fast/selectors/064-expected.checksum: Added.
  • platform/chromium-mac/fast/selectors/064-expected.png: Added.
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-mac/fast/table/append-cells2-expected.checksum: Added.
  • platform/chromium-mac/fast/table/append-cells2-expected.png: Added.
  • platform/chromium-mac/fast/table/border-collapsing/004-vertical-expected.checksum: Added.
  • platform/chromium-mac/fast/table/border-collapsing/004-vertical-expected.png: Added.
  • platform/chromium-mac/fast/table/frame-and-rules-expected.checksum: Added.
  • platform/chromium-mac/fast/table/frame-and-rules-expected.png: Added.
  • platform/chromium-mac/fast/table/remove-td-display-none-expected.checksum: Added.
  • platform/chromium-mac/fast/table/remove-td-display-none-expected.png: Added.
  • platform/chromium-mac/fast/text/atsui-negative-spacing-features-expected.checksum: Added.
  • platform/chromium-mac/fast/text/atsui-negative-spacing-features-expected.png: Added.
  • platform/chromium-mac/fast/text/atsui-partial-selection-expected.checksum: Added.
  • platform/chromium-mac/fast/text/atsui-partial-selection-expected.png: Added.
  • platform/chromium-mac/fast/text/atsui-spacing-features-expected.checksum: Added.
  • platform/chromium-mac/fast/text/atsui-spacing-features-expected.png: Added.
  • platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.checksum: Added.
  • platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
  • platform/chromium-mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum: Added.
  • platform/chromium-mac/fast/text/bidi-embedding-pop-and-push-same-expected.png: Added.
  • platform/chromium-mac/fast/text/capitalize-boundaries-expected.checksum: Added.
  • platform/chromium-mac/fast/text/capitalize-boundaries-expected.png: Added.
  • platform/chromium-mac/fast/text/in-rendered-text-rtl-expected.checksum: Added.
  • platform/chromium-mac/fast/text/in-rendered-text-rtl-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-AN-after-L-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-AN-after-L-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-AN-after-L-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/bidi-L2-run-reordering-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-L2-run-reordering-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-european-terminators-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-european-terminators-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-innertext-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-innertext-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-linebreak-001-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-linebreak-001-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-linebreak-002-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-linebreak-002-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-linebreak-003-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-linebreak-003-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-listbox-atsui-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-listbox-atsui-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-listbox-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-listbox-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/bidi-override-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-override-expected.png: Added.
  • platform/chromium-mac/fast/text/international/hebrew-vowels-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/hebrew-vowels-expected.png: Added.
  • platform/chromium-mac/fast/text/international/hindi-spacing-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/hindi-spacing-expected.png: Added.
  • platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum:
  • platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
  • platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Removed.
  • platform/chromium-mac/fast/text/international/rtl-caret-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/rtl-caret-expected.png: Added.
  • platform/chromium-mac/fast/text/international/rtl-white-space-pre-wrap-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/rtl-white-space-pre-wrap-expected.png: Added.
  • platform/chromium-mac/fast/text/international/text-combine-image-test-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png: Added.
  • platform/chromium-mac/fast/text/international/text-combine-image-test-expected.txt: Added.
  • platform/chromium-mac/fast/text/justified-selection-at-edge-expected.checksum: Added.
  • platform/chromium-mac/fast/text/justified-selection-at-edge-expected.png: Added.
  • platform/chromium-mac/fast/text/justify-ideograph-simple-expected.checksum:
  • platform/chromium-mac/fast/text/justify-ideograph-simple-expected.png:
  • platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.checksum:
  • platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.png:
  • platform/chromium-mac/fast/text/justify-nbsp-expected.checksum: Added.
  • platform/chromium-mac/fast/text/justify-nbsp-expected.png: Added.
  • platform/chromium-mac/fast/text/line-breaks-expected.checksum: Added.
  • platform/chromium-mac/fast/text/line-breaks-expected.png: Added.
  • platform/chromium-mac/fast/text/trailing-white-space-2-expected.checksum: Removed.
  • platform/chromium-mac/fast/text/trailing-white-space-expected.checksum: Removed.
  • platform/chromium-mac/fast/text/word-break-run-rounding-expected.checksum: Added.
  • platform/chromium-mac/fast/text/word-break-run-rounding-expected.png: Added.
  • platform/chromium-mac/fonts/sans-serif-expected.checksum: Added.
  • platform/chromium-mac/fonts/sans-serif-expected.png: Added.
  • platform/chromium-mac/svg/custom/animate-path-discrete-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/animate-path-discrete-expected.png: Added.
  • platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.checksum:
  • platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum:
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-mac/svg/custom/text-dom-01-f-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/text-dom-01-f-expected.png: Added.
  • platform/chromium-mac/svg/hixie/mixed/003-expected.checksum:
  • platform/chromium-mac/svg/hixie/mixed/003-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug113424-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug113424-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug14323-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug14323-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug26178-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug26178-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug2962-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug2962-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug30692-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug30692-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug4429-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug4429-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug44505-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug44505-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug51727-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug51727-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug52505-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug52505-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug52506-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug52506-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug60749-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug60749-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug67915-1-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug67915-1-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug68912-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug68912-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug88035-1-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug88035-1-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug88035-2-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug88035-2-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/core/bloomberg-expected.checksum:
  • platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-mac/tables/mozilla/core/misc-expected.checksum:
  • platform/chromium-mac/tables/mozilla/core/misc-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/dom/tableDom-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/x_tbody_align_justify-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/marvin/x_tbody_align_justify-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/x_td_align_justify-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/marvin/x_td_align_justify-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/x_th_align_justify-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/marvin/x_th_align_justify-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/x_thead_align_justify-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/chromium-mac/tables/mozilla/marvin/x_tr_align_justify-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/marvin/x_tr_align_justify-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/other/move_row-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/other/move_row-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png: Added.
  • platform/chromium/test_expectations.txt:
2:18 PM Changeset in webkit [79033] by jamesr@google.com
  • 6 edits in trunk/Source/WebCore

2011-02-18 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Update texture for ContentLayerChromiums in draw() call instead of updateContents..() call
https://bugs.webkit.org/show_bug.cgi?id=54315

This defers all operations on the compositor's GL context until the
draw() call which is a prerequisite for moving the draw() off-thread.
Also cleans up the update cycle a bit - there were some unused local
variables and whatnot.

One consequence of this change is that the upload buffer is retained
across updates now instead of allocated by each paint. This is
necessary so that the full layer contents can be uploaded if the
texture manager evicts the layer's backing texture. This costs more
persistent memory but avoids lots of allocator churn on updates.
Another nonobvious detail is that I have to update the texture for
ContentLayerChromiums in bindContentsTexture() because mask layers
never draw(), they are instead bound to the secondary texture unit.

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::updateContentsIfDirty): (WebCore::ContentLayerChromium::resizeUploadBufferForImage): (WebCore::ContentLayerChromium::resizeUploadBuffer): (WebCore::SkBitmapConditionalAutoLockerPixels::SkBitmapConditionalAutoLockerPixels): (WebCore::SkBitmapConditionalAutoLockerPixels::~SkBitmapConditionalAutoLockerPixels): (WebCore::SkBitmapConditionalAutoLockerPixels::lockPixels): (WebCore::ContentLayerChromium::updateTextureIfNeeded): (WebCore::ContentLayerChromium::draw): (WebCore::ContentLayerChromium::unreserveContentsTexture): (WebCore::ContentLayerChromium::bindContentsTexture):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContentsIfDirty):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::setBounds):
  • platform/graphics/chromium/LayerChromium.h:
2:16 PM Changeset in webkit [79032] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit/qt

Unreviewed.

[Qt] Buildfix for platforms with geolocation disabled.

  • Api/qwebpage.cpp: Add the missing guard.
1:53 PM Changeset in webkit [79031] by kbr@google.com
  • 2 edits in trunk/Source/WebCore

2011-02-18 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium build fix on certain Linux platforms.

  • platform/graphics/gpu/LoopBlinnSolidFillShader.cpp:
1:51 PM Changeset in webkit [79030] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-18 Anders Carlsson <andersca@apple.com>

Reviewed by Simon Fraser.

Implement NetscapePlugin::pluginComplexTextInputIdentifier
https://bugs.webkit.org/show_bug.cgi?id=54770

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::pluginComplexTextInputIdentifier):
1:44 PM Changeset in webkit [79029] by atwilson@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed expectations update.

  • platform/chromium-win/inspector/styles-update-from-js-expected.txt: Added.
1:40 PM Changeset in webkit [79028] by Csaba Osztrogonác
  • 11 edits
    2 adds
    2 deletes in trunk

[Qt] Implement client based geolocation for qtport
https://bugs.webkit.org/show_bug.cgi?id=42629

Patch by Mahesh Kulkarni <mahesh.kulkarni@nokia.com> on 2011-02-18
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Implements client based geolocation for qtwebkit. Removed old code related to non-client based geolocation

No tests as yet. This will be raised as different bug as new mock client implementation need to be done.

  • WebCore.pro:
  • features.pri:
  • platform/qt/GeolocationServiceQt.cpp: Removed.
  • platform/qt/GeolocationServiceQt.h: Removed.

Source/WebKit/qt:

Implements client based geolocation for qtwebkit.
New client based geolocation contains permission API's as well,
so removed the implementation from ChromeClientQt.cpp.

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

  • WebCoreSupport/ChromeClientQt.cpp:
  • WebCoreSupport/ChromeClientQt.h:

(WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
(WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):

  • WebCoreSupport/GeolocationClientQt.cpp: Added.

(WebCore::GeolocationClientQt::GeolocationClientQt):
(WebCore::GeolocationClientQt::~GeolocationClientQt):
(WebCore::GeolocationClientQt::geolocationDestroyed):
(WebCore::GeolocationClientQt::positionUpdated):
(WebCore::GeolocationClientQt::startUpdating):
(WebCore::GeolocationClientQt::stopUpdating):
(WebCore::GeolocationClientQt::setEnableHighAccuracy):
(WebCore::GeolocationClientQt::requestPermission):
(WebCore::GeolocationClientQt::cancelPermissionRequest):

  • WebCoreSupport/GeolocationClientQt.h: Added.

(WebCore::GeolocationClientQt::lastPosition):

LayoutTests:

Disable Geolocation layout test case until client-based mock layout controller is implemented.

  • platform/qt/Skipped:
1:32 PM Changeset in webkit [79027] by mihaip@chromium.org
  • 5 edits in trunk/LayoutTests

2011-02-18 Mihai Parparita <mihaip@chromium.org>

Unreviewed mac baseline update. Update some lingering failures after
r78846 (initial baselines in r78884 and r78855 were incorrect).

  • media/controls-without-preload-expected.txt:
  • platform/mac/fast/forms/text-control-intrinsic-widths-expected.txt:
  • platform/mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
1:30 PM Changeset in webkit [79026] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2011-02-18 Martin Robinson <mrobinson@igalia.com>

Reorganize the GTK+ skipped list to make it easier to triage issues
and ease any future switch to test_expectations.txt format.

  • platform/gtk/Skipped: Reorganize the GTK+ skipped list.
1:29 PM Changeset in webkit [79025] by weinig@apple.com
  • 10 edits in trunk/Source/WebKit2

Add the ability to ask the WKPage if the main frame is pinned
to the right or left hand side.
Part of <rdar://problem/9017043>.

Reviewed by Maciej Stachowiak.

  • UIProcess/API/C/WKPage.cpp:

(WKPageIsPinnedToLeftSide):
(WKPageIsPinnedToRightSide):

  • UIProcess/API/C/WKPage.h:

Add new API calls.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::didChangeScrollOffsetPinningForMainFrame):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::isPinnedToLeftSide):
(WebKit::WebPageProxy::isPinnedToRightSide):
Initialize, reset and update the pinned state.

  • UIProcess/WebPageProxy.messages.in:

Add message to update the pinned state.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::didChangeScrollOffset):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::didChangeScrollOffsetForMainFrame):

  • WebProcess/WebPage/WebPage.h:

Cache the pinned state, and only update the UIProcess when it
changes.

1:28 PM Changeset in webkit [79024] by yael.aharon@nokia.com
  • 12 edits
    14 adds in trunk

Add support for dir=auto
https://bugs.webkit.org/show_bug.cgi?id=50916

Reviewed by Dave Hyatt.

Source/JavaScriptCore:

Change defaultWritingDirection() to return if the writing direction
was determined from a letter with strong directionality or not.

(WTF::StringImpl::defaultWritingDirection):

  • wtf/text/StringImpl.h:
  • wtf/text/WTFString.h:

(WTF::String::defaultWritingDirection):

Source/WebCore:

When an element has dir attribute with value "auto", call defaultWritingMode
to find its directionality.
Added a flag SelfOrAncestorHasDirAutoFlag, and added hooks in the DOM to set
and check this flag. This flag is set on every node between an element with
dir=auto attribute and its first text node. Changes in the DOM between those
elements will trigger re-evaluating the directionality, but changes not
between those element do not need to be concerned.
The DOM hooks were added to childrenChanged, and to parseMappedAttribute.
The directionality is evaluated when children are added, and cleared when they are
removed. Directionality flag is also cleared on a child that is no longer determining
the directionality due to a sibling being added before that child.

Added 2 static CSSMutableStyleDeclarations to be used for elements with dir=auto.
We cannot used the mapped declaration, because it can take only one value.

Tests: fast/dom/HTMLElement/attr-dir-auto-change-before-text-node.html

fast/dom/HTMLElement/attr-dir-auto-change-child-node.html
fast/dom/HTMLElement/attr-dir-auto-change-text.html
fast/dom/HTMLElement/attr-dir-auto-children.html
fast/dom/HTMLElement/attr-dir-auto-remove-add-children.html
fast/dom/HTMLElement/attr-dir-auto.html
fast/dom/HTMLElement/attr-dir-value-change.html

  • css/CSSStyleSelector.cpp:

(WebCore::leftToRightDeclaration):
(WebCore::rightToLeftDeclaration):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::styleForElement):

  • dom/Node.h:

(WebCore::Node::selfOrAncestorHasDirAutoAttribute):
(WebCore::Node::setSelfOrAncestorHasDirAutoAttribute):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::mapToEntry):
(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::setHasDirAutoFlagRecursively):
(WebCore::HTMLElement::childrenChanged):
(WebCore::HTMLElement::directionalityIfhasDirAutoAttribute):
(WebCore::HTMLElement::directionality):
(WebCore::HTMLElement::dirAttributeChanged):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildAttributeChanged):
(WebCore::HTMLElement::calculateAndAdjustDirectionality):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged):

  • html/HTMLElement.h:

LayoutTests:

  • fast/dom/HTMLElement/attr-dir-auto-change-before-text-node.html: Added.
  • fast/dom/HTMLElement/attr-dir-auto-change-before-text-node-expected.txt: Added.
  • fast/dom/HTMLElement/attr-dir-auto-change-child-node-expected.txt: Added.
  • fast/dom/HTMLElement/attr-dir-auto-change-child-node.html: Added.
  • fast/dom/HTMLElement/attr-dir-auto-change-text-expected.txt: Added.
  • fast/dom/HTMLElement/attr-dir-auto-change-text.html: Added.
  • fast/dom/HTMLElement/attr-dir-auto-children-expected.txt: Added.
  • fast/dom/HTMLElement/attr-dir-auto-children.html: Added.
  • fast/dom/HTMLElement/attr-dir-auto-expected.txt: Added.
  • fast/dom/HTMLElement/attr-dir-auto-remove-add-children-expected.txt: Added.
  • fast/dom/HTMLElement/attr-dir-auto-remove-add-children.html: Added.
  • fast/dom/HTMLElement/attr-dir-auto.html: Added.
  • fast/dom/HTMLElement/attr-dir-value-change-expected.txt: Added.
  • fast/dom/HTMLElement/attr-dir-value-change.html: Added.
1:23 PM Changeset in webkit [79023] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-18 Anders Carlsson <andersca@apple.com>

Reviewed by Simon Fraser.

Fix assertion in SharedMemory::create when trying to snapshot 0x0 plug-in
https://bugs.webkit.org/show_bug.cgi?id=54768

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::snapshot): Don't try to create a handle from a null ShareableBitmap.
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::snapshot): Check for a zero sized plug-in before trying to create a snapshot.
1:10 PM Changeset in webkit [79022] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-18 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Use hashing instead of linear search in the conservative pointer test
https://bugs.webkit.org/show_bug.cgi?id=54767


SunSpider reports no change.

  • runtime/MarkedSpace.h: (JSC::MarkedSpace::contains): Variable-sized objects will use more, smaller blocks, so it's important for the contains check not to be O(n) in the number of blocks.
1:05 PM Changeset in webkit [79021] by yael.aharon@nokia.com
  • 5 edits
    2 adds in trunk

Navigating downwards / upwards does not focus on the links spread across more than one line.
https://bugs.webkit.org/show_bug.cgi?id=54639

Reviewed by Antonio Gomes.

Source/WebCore:

When 2 anchor elements span more than one line each, and one ends on the same line that the
second starts on, the rects reported by their renderers are overlapping. When handling
2 overlapping nodes, check for this case, and don't assume that one of the nodes is on a higher layer.

Test: fast/spatial-navigation/snav-two-elements-one-line.html

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateIfNeeded):
(WebCore::FocusController::findFocusCandidateInContainer):

  • page/SpatialNavigation.cpp:

(WebCore::areElementsOnSameLine):
(WebCore::distanceDataForNode):

  • page/SpatialNavigation.h:

LayoutTests:

  • fast/spatial-navigation/snav-two-elements-one-line-expected.txt: Added.
  • fast/spatial-navigation/snav-two-elements-one-line.html: Added.
12:55 PM Changeset in webkit [79020] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

2011-02-18 Anders Carlsson <andersca@apple.com>

Reviewed by Simon Fraser.

WKView flashes when entering/exiting compositing mode
https://bugs.webkit.org/show_bug.cgi?id=54695
<rdar://problem/9011554>

  • UIProcess/API/mac/WKView.mm: (-[WKView _exitAcceleratedCompositingMode]): Remove the layer hosting view before clearing out its layer, otherwise we can get white flashes when exiting accelerated compositing mode.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: When entering accelerated compositing mode, we want to defer sending the message until we've actually committed the layer tree and pushed all changes over to the UI process.

(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):
Tell the layer tree host to force a repaint. This will ensure that all layer tree
changes are pushed over to the UI process. When that is done, send the new layer tree
context over to the UI process.

(WebKit::DrawingAreaImpl::setRootCompositingLayer):
When exiting compositing mode in response to a didSetSize, we want to exit accelerated
compositing mode right away to avoid flashes. This is safe since we've laid out the page
already so we won't end up reentering setRootCompositingLayer.

(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
Tell the layer tree host to notify us when the next layer tree flush happened, so we can
let the UI process know. If we're entering accelerated compositing mode in response to a
SetSize message, the new layer tree context will be passed in the DidSetSize message.

  • WebProcess/WebPage/DrawingAreaImpl.h: Add layerHostDidFlushLayers.
  • WebProcess/WebPage/LayerTreeHost.h: Add setShouldNotifyAfterNextScheduledLayerFlush.
  • WebProcess/WebPage/mac/LayerTreeHostMac.h: Add a m_notifyAfterScheduledLayerFlush flag.
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::LayerTreeHostMac): Initialize m_notifyAfterScheduledLayerFlush to false.

(WebKit::LayerTreeHostMac::setShouldNotifyAfterNextScheduledLayerFlush):
Set m_notifyAfterScheduledLayerFlush to true.

(WebKit::LayerTreeHostMac::flushPendingLayerChangesRunLoopObserverCallback):
If m_notifyAfterScheduledLayerFlush is true, call DrawingAreaImpl::layerHostDidFlushLayers.

12:43 PM Changeset in webkit [79019] by atwilson@chromium.org
  • 2 edits
    566 deletes in trunk/LayoutTests

2011-02-18 Andrew Wilson <atwilson@chromium.org>

Unreviewed, rolling out r79007.
http://trac.webkit.org/changeset/79007

Rebaselines were put in the wrong directory due to bug 54691

  • platform/chromium-mac-snowleopard/compositing/reflections/deeply-nested-reflections-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/compositing/reflections/deeply-nested-reflections-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css1/box_properties/clear_float-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css1/box_properties/clear_float-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css1/box_properties/float_elements_in_series-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css1/box_properties/float_elements_in_series-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css1/box_properties/float_on_text_elements-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css1/box_properties/float_on_text_elements-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css1/text_properties/text_align-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css1/text_properties/text_align-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counter-03-b-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counter-03-b-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counter-04-b-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counter-04-b-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counter-04-b-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counters-03-b-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counters-03-b-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counters-04-b-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counters-04-b-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counters-04-b-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t1602-c43-center-00-d-ag-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t1602-c43-center-00-d-ag-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t1602-c546-txt-align-00-b-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/css2.1/t1602-c546-txt-align-00-b-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-003-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-003-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-001-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-001-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-003-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-003-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/inserting/typing-tab-designmode-forms-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/inserting/typing-tab-designmode-forms-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/4641033-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/4641033-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/block-wrappers-necessary-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/nested-blocks-with-text-area-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/nested-blocks-with-text-area-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/nested-blocks-with-text-field-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/nested-blocks-with-text-field-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-blockquote-2-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-blockquote-2-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/pasting-tabs-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/pasteboard/pasting-tabs-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/4397952-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/4397952-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/4975120-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/4975120-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/5240265-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/5240265-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-2-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-2-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-2-left-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-2-left-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-right-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-right-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/extend-selection-bidi-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/extend-selection-bidi-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/move-past-trailing-space-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/replaced-boundaries-3-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/replaced-boundaries-3-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/style/5046875-1-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/style/5046875-1-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-011-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-011-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-012-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-012-expected.png: Removed.
  • platform/chromium-mac-snowleopard/editing/style/table-selection-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/editing/style/table-selection-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/block/margin-collapse/103-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/block/margin-collapse/103-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/block/positioning/inline-block-relposition-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/block/positioning/inline-block-relposition-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/blockflow/border-vertical-lr-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/blockflow/border-vertical-lr-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/blockflow/border-vertical-lr-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-lr-selection-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-lr-selection-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-lr-text-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-lr-text-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-rl-selection-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-rl-selection-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-rl-text-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-rl-text-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/blockflow/vertical-align-table-baseline-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/blockflow/vertical-align-table-baseline-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/blockflow/vertical-baseline-alignment-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/blockflow/vertical-baseline-alignment-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/blockflow/vertical-font-fallback-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/blockflow/vertical-font-fallback-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/css/beforeSelectorOnCodeElement-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/css/beforeSelectorOnCodeElement-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/css/continuationCrash-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/css/continuationCrash-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/css/css2-system-fonts-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/css/css2-system-fonts-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/css/font-face-default-font-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/css/font-face-default-font-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/css/font-face-locally-installed-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/css/font-face-locally-installed-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/css/margin-top-bottom-dynamic-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/css/margin-top-bottom-dynamic-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/css/rtl-ordering-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/css/rtl-ordering-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/css/text-input-with-webkit-border-radius-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/css/text-input-with-webkit-border-radius-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-bidi-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-bidi-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-strict-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-strict-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/css/text-security-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/css/text-security-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/52776-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLInputElement/input-image-alt-text-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/dynamic/008-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/dynamic/008-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/events/autoscroll-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/events/autoscroll-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/events/context-no-deselect-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/events/context-no-deselect-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label01-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label01-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label02-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label02-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label03-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label03-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label04-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label04-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/basic-buttons-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/basic-buttons-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/basic-selects-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/basic-selects-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/basic-selects-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-quirks-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-quirks-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/blankbuttons-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/blankbuttons-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/button-align-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/button-align-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/button-cannot-be-nested-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/button-cannot-be-nested-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/button-default-title-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/button-default-title-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/button-generated-content-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/button-generated-content-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/button-positioned-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/button-positioned-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/button-sizes-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/button-sizes-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/button-style-color-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/button-style-color-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/button-table-styles-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/button-table-styles-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/button-text-transform-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/button-text-transform-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/button-white-space-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/button-white-space-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/control-clip-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/control-clip-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/control-restrict-line-height-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/control-restrict-line-height-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/file-input-direction-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/file-input-direction-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/file-input-direction-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/formmove3-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/formmove3-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-align-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-align-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-selection-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-selection-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-button-sizes-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-button-sizes-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-file-re-render-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-file-re-render-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-first-letter-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-first-letter-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-table-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-table-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-word-wrap-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-no-overflow-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-no-overflow-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-option-wrap-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-option-wrap-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-restrict-line-height-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-restrict-line-height-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-style-color-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-style-color-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-width-change-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-width-change-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/option-strip-whitespace-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/option-strip-whitespace-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/option-text-clip-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/option-text-clip-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-set-value-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-set-value-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/search-cancel-button-style-sharing-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/search-cancel-button-style-sharing-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/search-transformed-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/search-transformed-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/search-zoomed-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/search-zoomed-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/select-align-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/select-align-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/select-baseline-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/select-baseline-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/select-change-listbox-to-popup-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/select-change-listbox-to-popup-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/select-disabled-appearance-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/select-disabled-appearance-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/select-initial-position-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/select-initial-position-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/select-selected-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/select-selected-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/select-visual-hebrew-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/select-visual-hebrew-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/stuff-on-my-optgroup-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/stuff-on-my-optgroup-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/targeted-frame-submission-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/targeted-frame-submission-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/text-control-intrinsic-widths-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-align-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-align-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-set-value-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-set-value-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-scroll-height-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-scroll-height-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-scrolled-type-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-scrolled-type-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/html/keygen-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/html/keygen-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-long-image-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-long-image-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-repeat-x-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-repeat-x-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-repeat-y-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-repeat-y-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/multicol/float-avoidance-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/multicol/float-avoidance-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/multicol/shadow-breaking-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/multicol/shadow-breaking-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/parser/document-write-option-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/parser/document-write-option-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/parser/entity-comment-in-textarea-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/parser/entity-comment-in-textarea-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/parser/open-comment-in-textarea-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/parser/open-comment-in-textarea-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/japanese-rl-selection-clear-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/japanese-rl-selection-clear-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/japanese-rl-selection-repaint-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/japanese-rl-selection-repaint-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-1-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-1-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-10-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-10-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-2-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-2-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-3-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-3-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-4-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-4-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-5-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-5-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-6-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-6-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-7-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-7-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-8-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-8-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-9-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-9-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-horizontal-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-horizontal-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-vertical-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-vertical-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-button-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-button-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-searchfield-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-searchfield-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textarea-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textarea-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textfield-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textfield-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/selectors/064-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/selectors/064-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/table/append-cells2-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/table/append-cells2-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/table/border-collapsing/004-vertical-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/table/border-collapsing/004-vertical-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/table/frame-and-rules-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/table/frame-and-rules-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/table/remove-td-display-none-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/table/remove-td-display-none-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/atsui-partial-selection-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/atsui-partial-selection-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/backslash-to-yen-sign-euc-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/backslash-to-yen-sign-euc-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/bidi-embedding-pop-and-push-same-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/bidi-embedding-pop-and-push-same-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/capitalize-boundaries-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/capitalize-boundaries-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/in-rendered-text-rtl-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/in-rendered-text-rtl-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-L-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-L-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-L-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-L2-run-reordering-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-L2-run-reordering-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-CSS-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-CSS-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-HTML-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-HTML-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-european-terminators-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-european-terminators-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-innertext-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-innertext-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-layout-across-linebreak-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-layout-across-linebreak-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-001-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-001-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-002-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-002-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-003-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-003-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-listbox-atsui-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-listbox-atsui-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-listbox-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-listbox-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-mirror-he-ar-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-mirror-he-ar-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-neutral-run-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-neutral-run-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-neutral-run-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-override-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-override-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/hebrew-vowels-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/hebrew-vowels-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/hindi-spacing-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/hindi-spacing-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/rtl-caret-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/rtl-caret-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/rtl-white-space-pre-wrap-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/rtl-white-space-pre-wrap-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/text/justified-selection-at-edge-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/justified-selection-at-edge-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/justify-ideograph-simple-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/justify-ideograph-simple-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/justify-ideograph-vertical-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/justify-ideograph-vertical-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/justify-nbsp-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/justify-nbsp-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/line-breaks-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/line-breaks-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/trailing-white-space-2-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/trailing-white-space-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/word-break-run-rounding-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/word-break-run-rounding-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fonts/sans-serif-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fonts/sans-serif-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/animate-path-discrete-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/animate-path-discrete-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/svg-fonts-in-html-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/svg-fonts-in-html-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/text-dom-01-f-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/text-dom-01-f-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug113424-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug113424-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1318-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1318-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug138725-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug138725-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug14323-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug14323-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug26178-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug26178-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2962-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2962-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug30692-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug30692-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug33855-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug33855-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug39209-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug39209-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4429-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4429-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug44505-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug44505-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51727-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51727-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug52505-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug52505-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug52506-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug52506-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug60749-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug60749-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug67915-1-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug67915-1-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug68912-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug68912-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug88035-1-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug88035-1-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug88035-2-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug88035-2-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-4-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/misc-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/misc-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_tbody_align_justify-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_tbody_align_justify-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_td_align_justify-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_td_align_justify-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_tfoot_align_justify-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_tfoot_align_justify-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_th_align_justify-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_th_align_justify-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_thead_align_justify-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_thead_align_justify-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_tr_align_justify-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_tr_align_justify-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug58402-2-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
12:26 PM Changeset in webkit [79018] by Martin Robinson
  • 2 edits
    202 adds in trunk/LayoutTests

2011-02-18 Martin Robinson <mrobinson@igalia.com>

Unskip the final set of tests on GTK+ that are missing results.

  • platform/gtk/Skipped: Unskip tests that now have results.
12:07 PM Changeset in webkit [79017] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-02-18 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Tightened some usage accounting code in MarkedSpace
https://bugs.webkit.org/show_bug.cgi?id=54761


SunSpider reports no change.

  • runtime/Heap.cpp: (JSC::Heap::Heap): Initialize the marked space high water mark on construction, instead of relying on some implicit subtleties to make not initializing it work out OK.
  • runtime/Heap.h: Fixed up includes.
  • runtime/MarkedBlock.h: Made firstAtom() static so clients can call it even without having allocated a block.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): Don't pre-allocate a block, since this would be prohibitively expensive with multiple size classes.

(JSC::MarkedSpace::allocateBlock):
(JSC::MarkedSpace::freeBlock): Track allocated blocks in a hash set,
since linear search in the contains check will be prohibitively
expensive once we're using lots of smaller blocks.

(JSC::MarkedSpace::allocate): Don't assume that we always have a block
allocated, since we don't anymore. (See above.)

(JSC::MarkedSpace::reset):

  • runtime/MarkedSpace.h: Updated for changes mentioned above.
11:58 AM Changeset in webkit [79016] by Martin Robinson
  • 2 edits
    221 adds in trunk/LayoutTests

2011-02-18 Martin Robinson <mrobinson@igalia.com>

Import the final set of GTK+ baselines for the Mozilla table test suite.

  • platform/gtk/Skipped: Unskip tests which now have results.
11:53 AM Changeset in webkit [79015] by Martin Robinson
  • 2 edits
    304 adds in trunk/LayoutTests

2011-02-18 Martin Robinson <mrobinson@igalia.com>

Import another set of GTK+ baselines for the Mozilla table tests.

  • platform/gtk/Skipped: Unskip tests which now have results.
11:43 AM Changeset in webkit [79014] by Martin Robinson
  • 2 edits
    300 adds in trunk/LayoutTests

2011-02-18 Martin Robinson <mrobinson@igalia.com>

Continue importing GTK+ results for Mozilla table tests.

  • platform/gtk/Skipped: Unskip test which now have results.
11:20 AM Changeset in webkit [79013] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

(new) media/video-controls-in-media-documents.html needs baselines for win & mac
https://bugs.webkit.org/show_bug.cgi?id=54757

Unreviewed, adding to the skip list for now until someone can generate the expected results.

  • platform/win/Skipped:
11:10 AM Changeset in webkit [79012] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-18 Alexander Pavlov <apavlov@chromium.org>

[Qt] Unreviewed, skip failing inspector/styles/styles-update-from-js.html.

  • platform/qt/Skipped:
10:42 AM Changeset in webkit [79011] by kbr@google.com
  • 24 edits
    7 adds in trunk/Source

2011-02-18 Ben Vanik <benvanik@google.com>

Reviewed by Kenneth Russell.

Bug 53940: Implement the OES_vertex_array_object WebGL extension
https://bugs.webkit.org/show_bug.cgi?id=53940

Stubbed out methods for the new OES_vertex_array_object methods.

  • src/Extensions3DChromium.cpp: (WebCore::Extensions3DChromium::createVertexArrayOES): (WebCore::Extensions3DChromium::deleteVertexArrayOES): (WebCore::Extensions3DChromium::isVertexArrayOES): (WebCore::Extensions3DChromium::bindVertexArrayOES):

2011-02-18 Ben Vanik <benvanik@google.com>

Reviewed by Kenneth Russell.

Bug 53940: Implement the OES_vertex_array_object WebGL extension
https://bugs.webkit.org/show_bug.cgi?id=53940

Initial implementation of the OES_vertex_array_object extension adding the OESVertexArrayObject
extension container and WebGLVertexArrayObjectOES VAO object. The extension is plumbed through
the Extensions3D interface and implemented in the Extensions3DOpenGL (WebKit/OSX) version when
it is available.
Two big changes touching code outside of the extension files:

  • Moved the typedefs at the top of GraphicsContext3D.h to GraphicsTypes3D.h (modeled after GraphicsTypes.h). They are not namespaced as they weren't before.
  • To make the code cleaner/clearer all vertex attribute state has been moved to the WebGLVertexArrayObjectOES type (struct VertexAttribState) except for values which are still on the WebGLRenderingContext. A default VAO is now used to store the existing attribute states for when no other VAO is used. Code in WebGLRenderingContext dealing with buffers and vertex attributes now defers to or stores values in the bound array object.

Tested against the WebGL conformance suite and the new
oes-vertex-array-object test:
https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/oes-vertex-array-object.html

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp: Modified property svn:ignore.
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::toJS):
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::toV8Object):
  • html/canvas/OESVertexArrayObject.cpp: Added. (WebCore::OESVertexArrayObject::OESVertexArrayObject): (WebCore::OESVertexArrayObject::~OESVertexArrayObject): (WebCore::OESVertexArrayObject::getName): (WebCore::OESVertexArrayObject::create): (WebCore::OESVertexArrayObject::createVertexArrayOES): (WebCore::OESVertexArrayObject::deleteVertexArrayOES): (WebCore::OESVertexArrayObject::isVertexArrayOES): (WebCore::OESVertexArrayObject::bindVertexArrayOES):
  • html/canvas/OESVertexArrayObject.h: Added.
  • html/canvas/OESVertexArrayObject.idl: Added.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLGetInfo.cpp: (WebCore::WebGLGetInfo::WebGLGetInfo): (WebCore::WebGLGetInfo::getWebGLVertexArrayObjectOES):
  • html/canvas/WebGLGetInfo.h:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::initializeNewContext): (WebCore::WebGLRenderingContext::bindBuffer): (WebCore::WebGLRenderingContext::deleteBuffer): (WebCore::WebGLRenderingContext::disableVertexAttribArray): (WebCore::WebGLRenderingContext::validateElementArraySize): (WebCore::WebGLRenderingContext::validateIndexArrayConservative): (WebCore::WebGLRenderingContext::validateIndexArrayPrecise): (WebCore::WebGLRenderingContext::validateRenderingState): (WebCore::WebGLRenderingContext::drawElements): (WebCore::WebGLRenderingContext::enableVertexAttribArray): (WebCore::WebGLRenderingContext::getExtension): (WebCore::WebGLRenderingContext::getParameter): (WebCore::WebGLRenderingContext::getSupportedExtensions): (WebCore::WebGLRenderingContext::getVertexAttrib): (WebCore::WebGLRenderingContext::vertexAttribPointer): (WebCore::WebGLRenderingContext::validateBufferDataParameters): (WebCore::WebGLRenderingContext::vertexAttribfImpl): (WebCore::WebGLRenderingContext::vertexAttribfvImpl): (WebCore::WebGLRenderingContext::initVertexAttrib0): (WebCore::WebGLRenderingContext::simulateVertexAttrib0): (WebCore::WebGLRenderingContext::restoreStatesAfterVertexAttrib0Simulation): (WebCore::WebGLRenderingContext::getNumberOfExtensions): (WebCore::WebGLRenderingContext::getExtensionNumber):
  • html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::getMaxVertexAttribs): (WebCore::WebGLRenderingContext::setBoundVertexArrayObject): (WebCore::WebGLRenderingContext::VertexAttribValue::VertexAttribValue):
  • html/canvas/WebGLVertexArrayObjectOES.cpp: Added. (WebCore::WebGLVertexArrayObjectOES::create): (WebCore::WebGLVertexArrayObjectOES::WebGLVertexArrayObjectOES): (WebCore::WebGLVertexArrayObjectOES::deleteObjectImpl):
  • html/canvas/WebGLVertexArrayObjectOES.h: Added. (WebCore::WebGLVertexArrayObjectOES::~WebGLVertexArrayObjectOES): (WebCore::WebGLVertexArrayObjectOES::VertexAttribState::VertexAttribState): (WebCore::WebGLVertexArrayObjectOES::isDefaultObject): (WebCore::WebGLVertexArrayObjectOES::hasEverBeenBound): (WebCore::WebGLVertexArrayObjectOES::setHasEverBeenBound): (WebCore::WebGLVertexArrayObjectOES::getElementArrayBuffer): (WebCore::WebGLVertexArrayObjectOES::setElementArrayBuffer): (WebCore::WebGLVertexArrayObjectOES::getVertexAttribState): (WebCore::WebGLVertexArrayObjectOES::isVertexArray):
  • html/canvas/WebGLVertexArrayObjectOES.idl: Added.
  • platform/graphics/Extensions3D.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/GraphicsTypes3D.h: Added.
  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: (WebCore::Extensions3DOpenGL::supports): (WebCore::Extensions3DOpenGL::createVertexArrayOES): (WebCore::Extensions3DOpenGL::deleteVertexArrayOES): (WebCore::Extensions3DOpenGL::isVertexArrayOES): (WebCore::Extensions3DOpenGL::bindVertexArrayOES):
  • platform/graphics/opengl/Extensions3DOpenGL.h:
  • platform/graphics/qt/Extensions3DQt.cpp: (WebCore::Extensions3DQt::createVertexArrayOES): (WebCore::Extensions3DQt::deleteVertexArrayOES): (WebCore::Extensions3DQt::isVertexArrayOES): (WebCore::Extensions3DQt::bindVertexArrayOES):
  • platform/graphics/qt/Extensions3DQt.h:
10:23 AM Changeset in webkit [79010] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Windows 7 Release Tests] ~26 tests failing after r78846
https://bugs.webkit.org/show_bug.cgi?id=54748

Unreviewed. Missed the contents of one of the expected result files.

  • platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt:
10:13 AM Changeset in webkit [79009] by apavlov@chromium.org
  • 11 edits
    2 adds in trunk

2011-02-17 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: reflect changes to styles when they happen outside inspector.
https://bugs.webkit.org/show_bug.cgi?id=44620

Notify InspectorInstrumentation of inline style changes from CSSMutableStyleDeclaration
whenever the style change does not come from a direct "style" attribute modification.
The performance regression occurs only with the Web Inspector opened, when inline styles
are modified through setting style.cssText or style.<styleAttribute>: according to the Web Inspector protocol,
an attribute change requires that all attributes for the node in question be pushed into the frontend.

Test: inspector/styles/styles-update-from-js.html

WebCore:

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
  • inspector/InspectorDOMAgent.cpp: (WebCore::RevalidateStyleAttributeTask::reset): (WebCore::RevalidateStyleAttributeTask::RevalidateStyleAttributeTask): (WebCore::RevalidateStyleAttributeTask::scheduleFor): (WebCore::RevalidateStyleAttributeTask::onTimer): (WebCore::InspectorDOMAgent::reset): (WebCore::InspectorDOMAgent::didInvalidateStyleAttr):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didInvalidateStyleAttr):
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheetForInlineStyle::didModifyElementAttribute): (WebCore::InspectorStyleSheetForInlineStyle::ensureParsedDataReady): (WebCore::InspectorStyleSheetForInlineStyle::elementStyleText):
  • inspector/InspectorStyleSheet.h:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._attributesUpdated):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules): (WebInspector.StylesSidebarPane.prototype.addBlankSection): (WebInspector.StylePropertiesSection.prototype.onpopulate): (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): (WebInspector.ComputedStylePropertiesSection.prototype.onpopulate): (WebInspector.BlankStylePropertiesSection): (WebInspector.StylePropertyTreeElement): (WebInspector.StylePropertyTreeElement.prototype): (WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection):

LayoutTests:

  • inspector/styles/styles-update-from-js-expected.txt: Added.
  • inspector/styles/styles-update-from-js.html: Added.
10:01 AM Changeset in webkit [79008] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Adele Peterson.

REGRESSION (WebKit2): Wrong frame printed on tivofaq.com
https://bugs.webkit.org/show_bug.cgi?id=54677
<rdar://problem/8994133>

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::area): Use visible frame bounds. (WebKit::findLargestFrameInFrameSet): Added a comment explaining what we're up to here. WebKit2 shouldn't be making policy decisions for the client, but it gets dangerously close to that. We used to expose the same as WK1 API though.
9:46 AM Changeset in webkit [79007] by atwilson@chromium.org
  • 2 edits
    614 adds in trunk/LayoutTests

Unreviewed expectations changes for Chromium.

  • platform/chromium-mac-snowleopard/compositing/reflections/deeply-nested-reflections-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/compositing/reflections/deeply-nested-reflections-expected.png: Added.
  • platform/chromium-mac-snowleopard/css1/box_properties/clear_float-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css1/box_properties/clear_float-expected.png: Added.
  • platform/chromium-mac-snowleopard/css1/box_properties/float_elements_in_series-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css1/box_properties/float_elements_in_series-expected.png: Added.
  • platform/chromium-mac-snowleopard/css1/box_properties/float_on_text_elements-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css1/box_properties/float_on_text_elements-expected.png: Added.
  • platform/chromium-mac-snowleopard/css1/text_properties/text_align-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css1/text_properties/text_align-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counter-03-b-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counter-03-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counter-04-b-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counter-04-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counter-04-b-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counters-03-b-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counters-03-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counters-04-b-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counters-04-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counters-04-b-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1602-c43-center-00-d-ag-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1602-c43-center-00-d-ag-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1602-c546-txt-align-00-b-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1602-c546-txt-align-00-b-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-003-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-tab-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-001-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-003-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/insert-tab-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/typing-tab-designmode-forms-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/inserting/typing-tab-designmode-forms-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/4641033-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/4641033-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/block-wrappers-necessary-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/block-wrappers-necessary-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/nested-blocks-with-text-area-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/nested-blocks-with-text-area-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/nested-blocks-with-text-field-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/nested-blocks-with-text-field-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-blockquote-2-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-blockquote-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/pasting-tabs-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/pasting-tabs-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/4397952-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/selection/4397952-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/4975120-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/selection/4975120-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/5240265-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/selection/5240265-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-2-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-2-left-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-2-left-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-right-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/selection/caret-rtl-right-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/extend-selection-bidi-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/selection/extend-selection-bidi-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/move-past-trailing-space-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/selection/replaced-boundaries-3-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/selection/replaced-boundaries-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/5046875-1-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/style/5046875-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-011-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-011-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-012-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/style/create-block-for-style-012-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/style/table-selection-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/editing/style/table-selection-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/margin-collapse/103-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/block/margin-collapse/103-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/inline-block-relposition-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/block/positioning/inline-block-relposition-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/blockflow/border-vertical-lr-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/blockflow/border-vertical-lr-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/blockflow/border-vertical-lr-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-lr-selection-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-lr-selection-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-lr-text-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-lr-text-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-rl-selection-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-rl-selection-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-rl-text-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-rl-text-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/blockflow/vertical-font-fallback-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/blockflow/vertical-font-fallback-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/beforeSelectorOnCodeElement-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/css/beforeSelectorOnCodeElement-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/continuationCrash-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/css/continuationCrash-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/css2-system-fonts-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/css/css2-system-fonts-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-face-default-font-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-face-default-font-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-face-locally-installed-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/css/font-face-locally-installed-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/margin-top-bottom-dynamic-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/css/margin-top-bottom-dynamic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/rtl-ordering-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/css/rtl-ordering-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/text-input-with-webkit-border-radius-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/css/text-input-with-webkit-border-radius-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-bidi-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-bidi-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-strict-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-strict-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/text-security-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/css/text-security-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/52776-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLInputElement/input-image-alt-text-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/dynamic/008-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/dynamic/008-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/events/autoscroll-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/events/autoscroll-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/events/context-no-deselect-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/events/context-no-deselect-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label01-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label01-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label02-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label02-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label03-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label03-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label04-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label04-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/basic-buttons-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/basic-buttons-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/basic-selects-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/basic-selects-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/basic-selects-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-quirks-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-quirks-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/blankbuttons-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/blankbuttons-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/button-align-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/button-align-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/button-cannot-be-nested-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/button-cannot-be-nested-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/button-default-title-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/button-default-title-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/button-generated-content-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/button-generated-content-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/button-positioned-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/button-positioned-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/button-sizes-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/button-sizes-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/button-style-color-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/button-style-color-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/button-table-styles-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/button-table-styles-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/button-text-transform-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/button-text-transform-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/button-white-space-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/button-white-space-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/control-clip-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/control-clip-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/control-restrict-line-height-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/control-restrict-line-height-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/file-input-direction-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/file-input-direction-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/file-input-direction-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/formmove3-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/formmove3-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-align-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-align-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-selection-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-selection-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-button-sizes-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-button-sizes-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-file-re-render-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-file-re-render-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-first-letter-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-first-letter-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-table-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-table-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-word-wrap-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-no-overflow-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-no-overflow-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-option-wrap-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-option-wrap-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-restrict-line-height-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-restrict-line-height-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-style-color-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-style-color-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-width-change-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/menulist-width-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/option-strip-whitespace-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/option-strip-whitespace-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/option-text-clip-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/option-text-clip-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-set-value-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/placeholder-set-value-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/search-cancel-button-style-sharing-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/search-cancel-button-style-sharing-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/search-transformed-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/search-transformed-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/search-zoomed-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/search-zoomed-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-align-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-align-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-baseline-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-baseline-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-change-listbox-to-popup-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-change-listbox-to-popup-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-disabled-appearance-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-disabled-appearance-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-initial-position-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-initial-position-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-selected-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-selected-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-visual-hebrew-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select-visual-hebrew-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/stuff-on-my-optgroup-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/stuff-on-my-optgroup-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/targeted-frame-submission-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/targeted-frame-submission-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/text-control-intrinsic-widths-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-align-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-align-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-set-value-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-set-value-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-scroll-height-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-scroll-height-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-scrolled-type-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textarea-scrolled-type-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/html/keygen-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/html/keygen-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-long-image-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-long-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-repeat-x-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-repeat-y-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/float-avoidance-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/float-avoidance-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/shadow-breaking-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/shadow-breaking-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/parser/document-write-option-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/parser/document-write-option-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/parser/entity-comment-in-textarea-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/parser/entity-comment-in-textarea-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/parser/open-comment-in-textarea-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/parser/open-comment-in-textarea-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/japanese-rl-selection-clear-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/japanese-rl-selection-repaint-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/japanese-rl-selection-repaint-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-1-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-10-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-10-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-2-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-3-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-4-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-4-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-5-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-5-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-6-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-6-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-7-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-7-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-8-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-8-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-9-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/line-flow-with-floats-9-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-horizontal-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-vertical-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-vertical-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-button-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-button-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-searchfield-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-searchfield-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textarea-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textarea-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textfield-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textfield-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/selectors/064-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/selectors/064-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/table/append-cells2-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/table/append-cells2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/border-collapsing/004-vertical-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/table/border-collapsing/004-vertical-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/frame-and-rules-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/table/frame-and-rules-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/table/remove-td-display-none-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/table/remove-td-display-none-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/atsui-partial-selection-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/atsui-partial-selection-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/backslash-to-yen-sign-euc-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/bidi-embedding-pop-and-push-same-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/bidi-embedding-pop-and-push-same-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/capitalize-boundaries-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/capitalize-boundaries-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/in-rendered-text-rtl-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/in-rendered-text-rtl-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-L-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-L-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-L-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-L2-run-reordering-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-L2-run-reordering-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-CSS-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-CSS-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-HTML-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-HTML-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-european-terminators-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-european-terminators-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-innertext-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-innertext-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-layout-across-linebreak-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-layout-across-linebreak-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-001-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-001-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-002-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-002-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-003-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-003-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-listbox-atsui-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-listbox-atsui-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-listbox-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-listbox-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-neutral-run-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-neutral-run-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-neutral-run-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-override-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-override-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/hebrew-vowels-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/hebrew-vowels-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/hindi-spacing-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/hindi-spacing-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/rtl-caret-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/rtl-caret-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/rtl-white-space-pre-wrap-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/rtl-white-space-pre-wrap-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/justified-selection-at-edge-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/justified-selection-at-edge-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/justify-ideograph-simple-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/justify-ideograph-simple-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/justify-ideograph-vertical-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/justify-ideograph-vertical-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/justify-nbsp-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/justify-nbsp-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/line-breaks-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/line-breaks-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/trailing-white-space-2-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/trailing-white-space-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/word-break-run-rounding-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fast/text/word-break-run-rounding-expected.png: Added.
  • platform/chromium-mac-snowleopard/fonts/sans-serif-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/fonts/sans-serif-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/animate-path-discrete-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/animate-path-discrete-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/svg-fonts-in-html-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/svg-fonts-in-html-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/text-dom-01-f-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/custom/text-dom-01-f-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug113424-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug113424-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1318-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1318-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug138725-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug138725-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug14323-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug14323-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug26178-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug26178-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2962-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2962-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug30692-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug30692-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug33855-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug33855-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug39209-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug39209-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4429-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4429-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug44505-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug44505-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51727-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51727-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug52505-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug52505-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug52506-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug52506-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug60749-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug60749-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug67915-1-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug67915-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug68912-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug68912-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug88035-1-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug88035-1-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug88035-2-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug88035-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-4-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/misc-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/core/misc-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_tbody_align_justify-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_tbody_align_justify-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_td_align_justify-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_td_align_justify-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_tfoot_align_justify-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_tfoot_align_justify-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_th_align_justify-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_th_align_justify-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_thead_align_justify-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_thead_align_justify-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_tr_align_justify-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/marvin/x_tr_align_justify-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug58402-2-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.checksum: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png: Added.
  • platform/chromium/test_expectations.txt:
9:26 AM Changeset in webkit [79006] by tonyg@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-02-16 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Refactor pumpTokenizer loop
https://bugs.webkit.org/show_bug.cgi?id=54574

  1. This makes pumpTokenizer() safe to call when waiting for a script or when about to get the next token, although ASSERTs still enforce that we aren't waiting for a script. This enables resumeParsingAfterYield() to call pumpTokenizer with no modifications even if we yield before running a script rather than before taking a token (see bug 54355).
  2. This also picks up the refCount >= 1 assert when stopped.

Tested PerformanceTests/Parser to verify no regression. If anything it got faster.
Before:

avg 985.05
median 985.5
stdev 3.007906248539007
min 980
max 990

After:

avg 980.05
median 981
stdev 3.122098653149833
min 974
max 985

No new tests because no new functionality.

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::canTakeNextToken): Added. (WebCore::HTMLDocumentParser::pumpTokenizer):
  • html/parser/HTMLDocumentParser.h:
9:19 AM Changeset in webkit [79005] by Csaba Osztrogonác
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r79003.
http://trac.webkit.org/changeset/79003
https://bugs.webkit.org/show_bug.cgi?id=54753

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-02-18
It broke tests on GTK bots (Requested by Ossy on #webkit).

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::lastChildConsideringContinuation):

  • dom/Node.cpp:

(WebCore::Node::removeEventListener):

  • html/DateComponents.cpp:

(WebCore::DateComponents::parseTime):

9:18 AM Changeset in webkit [79004] by jberlin@webkit.org
  • 26 edits
    1 add in trunk/LayoutTests

[Windows 7 Release Tests] ~26 tests failing after r78846
https://bugs.webkit.org/show_bug.cgi?id=54748

Unreviewed. Landing expected (failing?) results to get the Windows 7 Release bots green.

Note: the pixel test results for fast/ruby/nested-ruby.html and
fast/blockflow/Kusa-Makura-background-canvas.html will be landed separately.

  • platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/win/css2.1/t1202-counter-04-b-expected.txt:
  • platform/win/css2.1/t1202-counters-04-b-expected.txt:
  • platform/win/editing/pasteboard/nested-blocks-with-text-area-expected.txt:
  • platform/win/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/win/editing/selection/mixed-editability-10-expected.txt:
  • platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
  • platform/win/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/win/fast/forms/basic-selects-expected.txt:
  • platform/win/fast/forms/basic-textareas-expected.txt:
  • platform/win/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/win/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/win/fast/forms/textAreaLineHeight-expected.txt:
  • platform/win/fast/forms/textarea-scrollbar-expected.txt:
  • platform/win/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/win/fast/parser/entity-comment-in-textarea-expected.txt:
  • platform/win/fast/parser/open-comment-in-textarea-expected.txt:
  • platform/win/fast/ruby/nested-ruby-expected.txt:
  • platform/win/fast/text/atsui-negative-spacing-features-expected.txt:
  • platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Added.
  • platform/win/fast/text/international/bidi-menulist-expected.txt:
  • platform/win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/win/fast/text/justify-ideograph-complex-expected.txt:
  • platform/win/fast/text/justify-ideograph-simple-expected.txt:
  • platform/win/fast/text/justify-ideograph-vertical-expected.txt:
8:57 AM Changeset in webkit [79003] by Csaba Osztrogonác
  • 4 edits in trunk/Source/WebCore

Warning fix. Use ASSERT_UNUSED() instead of ASSERT().

Rubber-stamped by Andreas Kling.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::lastChildConsideringContinuation):

  • dom/Node.cpp:

(WebCore::Node::removeEventListener):

  • html/DateComponents.cpp:

(WebCore::DateComponents::parseTime):

8:34 AM Changeset in webkit [79002] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-02-18 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
Mark inspector/debugger/debug-inlined-scripts.html also as timing out.
https://bugs.webkit.org/show_bug.cgi?id=54659

8:00 AM Changeset in webkit [79001] by Csaba Osztrogonác
  • 2 edits
    756 adds in trunk/LayoutTests

Unreviewed.

[Qt] Add Qt specific expected results for passing svg/W3C-SVG-1.1 tests.

  • platform/qt/Skipped: Unskip passing tests.
  • platform/qt/svg/W3C-SVG-1.1/ [...] : Added.
6:54 AM Changeset in webkit [79000] by Philippe Normand
  • 1 edit
    2 adds in trunk/LayoutTests

2011-02-18 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK baselines for two new tests.

  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.
  • platform/gtk/svg/custom/nested-pattern-boundingBoxModeContent-expected.txt: Added.
6:27 AM Changeset in webkit [78999] by Csaba Osztrogonác
  • 3 edits
    253 adds in trunk/LayoutTests

Unreviewed.

[Qt] Add Qt specific expected results for passing svg tests.

  • platform/qt/Skipped: Unskip a bunch of passing tests.
  • platform/qt/svg/clip-path/clip-in-mask-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-in-mask-expected.png: Added.
  • platform/qt/svg/clip-path/clip-in-mask-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-in-mask-objectBoundingBox-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png: Added.
  • platform/qt/svg/clip-path/clip-in-mask-objectBoundingBox-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png: Added.
  • platform/qt/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-child-clipped-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-child-clipped-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-child-clipped-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-childs-clipped-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-childs-clipped-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-childs-clipped-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-clipped-evenodd-twice-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-clipped-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-clipped-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-clipped-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-clipped-no-content-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-clipped-no-content-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-clipped-no-content-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-clipped-nonzero-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-clipped-nonzero-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-clipped-nonzero-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-evenodd-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-evenodd-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-evenodd-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-evenodd-nonzero-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-evenodd-nonzero-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-evenodd-nonzero-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-nonzero-evenodd-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-nonzero-evenodd-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-nonzero-evenodd-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-nonzero-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-nonzero-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-nonzero-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-objectBoundingBox-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-objectBoundingBox-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-objectBoundingBox-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-on-clipped-use-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-on-clipped-use-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-on-clipped-use-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-on-g-and-child-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-on-g-and-child-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-on-g-and-child-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-on-g-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-on-g-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-on-g-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-on-svg-and-child-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-on-svg-and-child-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-on-svg-and-child-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-on-svg-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-on-svg-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-on-svg-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-pixelation-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-pixelation-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-pixelation-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-recursive-call-by-child-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-recursive-call-by-child-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-recursive-call-by-child-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-recursive-call-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-recursive-call-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-recursive-call-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-text-and-shape-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-text-and-shape-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-text-and-shape-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-text-and-stroke-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-text-and-stroke-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-text-and-stroke-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-text-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-text-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-text-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-use-as-child-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-use-as-child-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-use-as-child-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-use-as-child2-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-use-as-child2-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-use-as-child2-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-use-as-child3-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-use-as-child3-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-use-as-child3-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-use-as-child4-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-use-as-child4-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-use-as-child4-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-use-as-child5-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-use-as-child5-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-use-as-child5-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-userSpaceOnUse-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-userSpaceOnUse-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-with-container-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-with-container-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-with-container-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-with-different-unittypes-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-with-different-unittypes-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-with-different-unittypes-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-with-different-unittypes2-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-with-different-unittypes2-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-with-different-unittypes2-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-with-invisibile-child-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-with-invisibile-child-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-with-invisibile-child-expected.txt: Added.
  • platform/qt/svg/clip-path/clip-path-with-text-clipped-expected.checksum: Added.
  • platform/qt/svg/clip-path/clip-path-with-text-clipped-expected.png: Added.
  • platform/qt/svg/clip-path/clip-path-with-text-clipped-expected.txt: Added.
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.checksum: Added.
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Added.
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Added.
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-expected.checksum: Added.
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-expected.png: Added.
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Added.
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-panning-expected.checksum: Added.
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Added.
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Added.
  • platform/qt/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.checksum: Added.
  • platform/qt/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Added.
  • platform/qt/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt: Added.
  • platform/qt/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.checksum: Added.
  • platform/qt/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Added.
  • platform/qt/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt: Added.
  • platform/qt/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.checksum: Added.
  • platform/qt/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Added.
  • platform/qt/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt: Added.
  • platform/qt/svg/custom/clip-path-child-changes-expected.checksum: Added.
  • platform/qt/svg/custom/clip-path-child-changes-expected.png: Added.
  • platform/qt/svg/custom/clip-path-child-changes-expected.txt: Added.
  • platform/qt/svg/custom/clip-path-href-changes-expected.checksum: Added.
  • platform/qt/svg/custom/clip-path-href-changes-expected.png: Added.
  • platform/qt/svg/custom/clip-path-href-changes-expected.txt: Added.
  • platform/qt/svg/custom/clip-path-units-changes-expected.checksum: Added.
  • platform/qt/svg/custom/clip-path-units-changes-expected.png: Added.
  • platform/qt/svg/custom/clip-path-units-changes-expected.txt: Added.
  • platform/qt/svg/custom/clip-path-with-transform-expected.checksum: Added.
  • platform/qt/svg/custom/clip-path-with-transform-expected.png: Added.
  • platform/qt/svg/custom/clip-path-with-transform-expected.txt: Added.
  • platform/qt/svg/custom/marker-overflow-clip-expected.checksum: Added.
  • platform/qt/svg/custom/marker-overflow-clip-expected.png: Added.
  • platform/qt/svg/custom/marker-overflow-clip-expected.txt: Added.
  • platform/qt/svg/custom/mask-with-all-units-expected.checksum: Added.
  • platform/qt/svg/custom/mask-with-all-units-expected.png: Added.
  • platform/qt/svg/custom/mask-with-all-units-expected.txt: Added.
  • platform/qt/svg/custom/recursive-clippath-expected.checksum: Added.
  • platform/qt/svg/custom/recursive-clippath-expected.png: Added.
  • platform/qt/svg/custom/recursive-clippath-expected.txt: Added.
  • platform/qt/svg/custom/svg-fonts-in-text-controls-expected.checksum: Added.
  • platform/qt/svg/custom/svg-fonts-in-text-controls-expected.png: Added.
  • platform/qt/svg/custom/svg-fonts-in-text-controls-expected.txt: Added.
  • platform/qt/svg/custom/text-dom-removal-expected.checksum: Added.
  • platform/qt/svg/custom/text-dom-removal-expected.png: Added.
  • platform/qt/svg/custom/use-clipped-transform-expected.checksum: Added.
  • platform/qt/svg/custom/use-clipped-transform-expected.png: Added.
  • platform/qt/svg/dom/length-list-parser-expected.checksum: Added.
  • platform/qt/svg/dom/length-list-parser-expected.png: Added.
  • platform/qt/svg/dom/length-list-parser-expected.txt:
  • platform/qt/svg/text/foreignObject-repaint-expected.checksum: Added.
  • platform/qt/svg/text/foreignObject-repaint-expected.png: Added.
  • platform/qt/svg/text/foreignObject-repaint-expected.txt: Added.
  • platform/qt/svg/text/kerning-expected.checksum: Added.
  • platform/qt/svg/text/kerning-expected.png: Added.
  • platform/qt/svg/text/kerning-expected.txt: Added.
  • platform/qt/svg/text/multichar-glyph-expected.checksum: Added.
  • platform/qt/svg/text/multichar-glyph-expected.png: Added.
  • platform/qt/svg/text/multichar-glyph-expected.txt: Added.
  • platform/qt/svg/text/text-align-01-b-expected.checksum: Added.
  • platform/qt/svg/text/text-align-01-b-expected.png: Added.
  • platform/qt/svg/text/text-align-01-b-expected.txt: Added.
  • platform/qt/svg/text/text-align-02-b-expected.checksum: Added.
  • platform/qt/svg/text/text-align-02-b-expected.png: Added.
  • platform/qt/svg/text/text-align-02-b-expected.txt: Added.
  • platform/qt/svg/text/text-align-03-b-expected.checksum: Added.
  • platform/qt/svg/text/text-align-03-b-expected.png: Added.
  • platform/qt/svg/text/text-align-03-b-expected.txt: Added.
  • platform/qt/svg/text/text-align-04-b-expected.checksum: Added.
  • platform/qt/svg/text/text-align-04-b-expected.png: Added.
  • platform/qt/svg/text/text-align-04-b-expected.txt: Added.
  • platform/qt/svg/text/text-align-05-b-expected.checksum: Added.
  • platform/qt/svg/text/text-align-05-b-expected.png: Added.
  • platform/qt/svg/text/text-align-05-b-expected.txt: Added.
  • platform/qt/svg/text/text-align-06-b-expected.checksum: Added.
  • platform/qt/svg/text/text-align-06-b-expected.png: Added.
  • platform/qt/svg/text/text-align-06-b-expected.txt: Added.
  • platform/qt/svg/text/text-altglyph-01-b-expected.checksum: Added.
  • platform/qt/svg/text/text-altglyph-01-b-expected.png: Added.
  • platform/qt/svg/text/text-altglyph-01-b-expected.txt: Added.
  • platform/qt/svg/text/text-deco-01-b-expected.checksum: Added.
  • platform/qt/svg/text/text-deco-01-b-expected.png: Added.
  • platform/qt/svg/text/text-deco-01-b-expected.txt: Added.
  • platform/qt/svg/text/text-fonts-02-t-expected.checksum: Added.
  • platform/qt/svg/text/text-fonts-02-t-expected.png: Added.
  • platform/qt/svg/text/text-fonts-02-t-expected.txt: Added.
  • platform/qt/svg/text/text-gradient-positioning-expected.checksum: Added.
  • platform/qt/svg/text/text-gradient-positioning-expected.png: Added.
  • platform/qt/svg/text/text-gradient-positioning-expected.txt: Added.
  • platform/qt/svg/text/text-path-01-b-expected.checksum: Added.
  • platform/qt/svg/text/text-path-01-b-expected.png: Added.
  • platform/qt/svg/text/text-path-01-b-expected.txt: Added.
  • platform/qt/svg/text/text-repaint-rects-expected.checksum: Added.
  • platform/qt/svg/text/text-repaint-rects-expected.png: Added.
  • platform/qt/svg/text/text-repaint-rects-expected.txt: Added.
  • platform/qt/svg/text/text-spacing-01-b-expected.checksum: Added.
  • platform/qt/svg/text/text-spacing-01-b-expected.png: Added.
  • platform/qt/svg/text/text-spacing-01-b-expected.txt: Added.
  • platform/qt/svg/text/text-text-01-b-expected.checksum: Added.
  • platform/qt/svg/text/text-text-01-b-expected.png: Added.
  • platform/qt/svg/text/text-text-01-b-expected.txt: Added.
  • platform/qt/svg/text/text-text-03-b-expected.checksum: Added.
  • platform/qt/svg/text/text-text-03-b-expected.png: Added.
  • platform/qt/svg/text/text-text-03-b-expected.txt: Added.
  • platform/qt/svg/text/text-text-04-t-expected.checksum: Added.
  • platform/qt/svg/text/text-text-04-t-expected.png: Added.
  • platform/qt/svg/text/text-text-04-t-expected.txt: Added.
  • platform/qt/svg/text/text-text-05-t-expected.checksum: Added.
  • platform/qt/svg/text/text-text-05-t-expected.png: Added.
  • platform/qt/svg/text/text-text-05-t-expected.txt: Added.
  • platform/qt/svg/text/text-text-06-t-expected.checksum: Added.
  • platform/qt/svg/text/text-text-06-t-expected.png: Added.
  • platform/qt/svg/text/text-text-06-t-expected.txt: Added.
  • platform/qt/svg/text/text-text-07-t-expected.checksum: Added.
  • platform/qt/svg/text/text-text-07-t-expected.png: Added.
  • platform/qt/svg/text/text-text-07-t-expected.txt: Added.
  • platform/qt/svg/text/text-text-08-b-expected.checksum: Added.
  • platform/qt/svg/text/text-text-08-b-expected.png: Added.
  • platform/qt/svg/text/text-text-08-b-expected.txt: Added.
  • platform/qt/svg/text/text-tref-01-b-expected.checksum: Added.
  • platform/qt/svg/text/text-tref-01-b-expected.png: Added.
  • platform/qt/svg/text/text-tref-01-b-expected.txt: Added.
  • platform/qt/svg/text/text-tselect-01-b-expected.checksum: Added.
  • platform/qt/svg/text/text-tselect-01-b-expected.png: Added.
  • platform/qt/svg/text/text-tselect-01-b-expected.txt: Added.
  • platform/qt/svg/text/text-tspan-01-b-expected.checksum: Added.
  • platform/qt/svg/text/text-tspan-01-b-expected.png: Added.
  • platform/qt/svg/text/text-tspan-01-b-expected.txt: Added.
  • platform/qt/svg/text/text-ws-01-t-expected.checksum: Added.
  • platform/qt/svg/text/text-ws-01-t-expected.png: Added.
  • platform/qt/svg/text/text-ws-01-t-expected.txt: Added.
  • platform/qt/svg/text/text-ws-02-t-expected.checksum: Added.
  • platform/qt/svg/text/text-ws-02-t-expected.png: Added.
  • platform/qt/svg/text/text-ws-02-t-expected.txt: Added.
  • platform/qt/svg/text/textPathBoundsBug-expected.checksum: Added.
  • platform/qt/svg/text/textPathBoundsBug-expected.png: Added.
  • platform/qt/svg/text/textPathBoundsBug-expected.txt: Added.
  • platform/qt/svg/transforms/animated-path-inside-transformed-html-expected.checksum: Added.
  • platform/qt/svg/transforms/animated-path-inside-transformed-html-expected.png: Added.
  • platform/qt/svg/transforms/animated-path-inside-transformed-html-expected.txt: Added.
  • platform/qt/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum: Added.
  • platform/qt/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
  • platform/qt/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt: Added.
  • platform/qt/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum: Added.
  • platform/qt/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
  • platform/qt/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Added.
5:38 AM Changeset in webkit [78998] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-18 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] Optimize editing updates in main panel
https://bugs.webkit.org/show_bug.cgi?id=54661

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer): (WebInspector.TextViewer.prototype._textChanged): (WebInspector.TextViewer.prototype._enterInternalTextChangeMode): (WebInspector.TextViewer.prototype._exitInternalTextChangeMode): (WebInspector.TextViewer.prototype._syncDecorationsForLine): (WebInspector.TextEditorChunkedPanel.prototype.textChanged): (WebInspector.TextEditorChunkedPanel.prototype._scroll): (WebInspector.TextEditorChunkedPanel.prototype.chunkForLine): (WebInspector.TextEditorChunkedPanel.prototype._totalHeight): (WebInspector.TextEditorGutterPanel.prototype._expandChunks): (WebInspector.TextEditorGutterChunk): (WebInspector.TextEditorGutterChunk.prototype.addDecoration): (WebInspector.TextEditorGutterChunk.prototype.removeDecoration): (WebInspector.TextEditorMainPanel): (WebInspector.TextEditorMainPanel.prototype._expandChunks): (WebInspector.TextEditorMainPanel.prototype._highlightDataReady): (WebInspector.TextEditorMainPanel.prototype._markSkippedPaintLines): (WebInspector.TextEditorMainPanel.prototype._paintSkippedLines): (WebInspector.TextEditorMainPanel.prototype._paintLines): (WebInspector.TextEditorMainPanel.prototype._paintLine): (WebInspector.TextEditorMainPanel.prototype._positionToSelection): (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates): (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges): (WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange): (WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv): (WebInspector.TextEditorMainChunk): (WebInspector.TextEditorMainChunk.prototype.get startLine): (WebInspector.TextEditorMainChunk.prototype.set startLine): (WebInspector.TextEditorMainChunk.prototype.getExpandedLineRow): (WebInspector.TextEditorMainChunk.prototype.updateCollapsedLineRow):
5:28 AM Changeset in webkit [78997] by kbalazs@webkit.org
  • 1 edit
    2 deletes in trunk/Source/WebKit2

2011-02-18 Balazs Kelemen <kbalazs@webkit.org>

Unreviwed.

Remove CleanupHandler since we do not use it anymore.

  • Shared/qt/CleanupHandler.cpp: Removed.
  • Shared/qt/CleanupHandler.h: Removed.
5:06 AM Changeset in webkit [78996] by Philippe Normand
  • 2 edits in trunk

2011-02-18 Philippe Normand <pnormand@igalia.com>

Unreviewed, build fix after r78981

  • configure.ac: datagrid is datagrid, it is not database. Also meter is not progress. Fixed copy/paste mistakes.
4:28 AM Changeset in webkit [78995] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-02-18 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
text-overflow-ellipsis may also fail with wrong image only.

4:27 AM Changeset in webkit [78994] by steveblock@google.com
  • 2 edits in trunk/Source/WebCore

2011-02-18 Steve Block <steveblock@google.com>

Reviewed by Andreas Kling

Memory allocation error in convertV8ObjectToNPVariant() for strings
https://bugs.webkit.org/show_bug.cgi?id=54737

Include the termination character in the length when allocating memory
and copying the string. This fixes a crashing bug on Android.

This should be tested by the java/ tests on Chromium, but these
tests are currently skipped.

  • bindings/v8/V8NPUtils.cpp: (WebCore::convertV8ObjectToNPVariant):
4:21 AM Changeset in webkit [78993] by Csaba Osztrogonác
  • 159 edits in trunk/LayoutTests

Unreviewed.

[Qt] Update pixel results for svg tests.

  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum:
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum:
  • platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
  • platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/qt/svg/animations/repeatDur-zero-expected.checksum:
  • platform/qt/svg/animations/repeatDur-zero-expected.png:
  • platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.checksum:
  • platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/qt/svg/batik/text/textDecoration-expected.checksum:
  • platform/qt/svg/batik/text/textDecoration-expected.png:
  • platform/qt/svg/css/composite-shadow-text-expected.checksum:
  • platform/qt/svg/css/composite-shadow-text-expected.png:
  • platform/qt/svg/css/text-gradient-shadow-expected.checksum:
  • platform/qt/svg/css/text-gradient-shadow-expected.png:
  • platform/qt/svg/custom/absolute-sized-content-with-resources-expected.checksum:
  • platform/qt/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/qt/svg/custom/bug45331-expected.checksum:
  • platform/qt/svg/custom/bug45331-expected.png:
  • platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.checksum:
  • platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.png:
  • platform/qt/svg/custom/convolution-crash-expected.checksum:
  • platform/qt/svg/custom/convolution-crash-expected.png:
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.checksum:
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.checksum:
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
  • platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.checksum:
  • platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
  • platform/qt/svg/custom/image-rescale-expected.checksum:
  • platform/qt/svg/custom/image-rescale-expected.png:
  • platform/qt/svg/custom/image-rescale-scroll-expected.checksum:
  • platform/qt/svg/custom/image-rescale-scroll-expected.png:
  • platform/qt/svg/custom/js-update-stop-linked-gradient-expected.checksum:
  • platform/qt/svg/custom/js-update-stop-linked-gradient-expected.png:
  • platform/qt/svg/custom/marker-child-changes-css-expected.checksum:
  • platform/qt/svg/custom/marker-child-changes-css-expected.png:
  • platform/qt/svg/custom/marker-empty-path-expected.checksum:
  • platform/qt/svg/custom/marker-empty-path-expected.png:
  • platform/qt/svg/custom/mask-invalidation-expected.checksum:
  • platform/qt/svg/custom/mask-invalidation-expected.png:
  • platform/qt/svg/custom/massive-coordinates-expected.checksum:
  • platform/qt/svg/custom/massive-coordinates-expected.png:
  • platform/qt/svg/custom/mouse-move-on-svg-container-expected.checksum:
  • platform/qt/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
  • platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/qt/svg/custom/mouse-move-on-svg-root-expected.checksum:
  • platform/qt/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/qt/svg/custom/non-scaling-stroke-expected.checksum:
  • platform/qt/svg/custom/non-scaling-stroke-expected.png:
  • platform/qt/svg/custom/pattern-incorrect-tiling-expected.checksum:
  • platform/qt/svg/custom/pattern-incorrect-tiling-expected.png:
  • platform/qt/svg/custom/pattern-no-pixelation-expected.checksum:
  • platform/qt/svg/custom/pattern-no-pixelation-expected.png:
  • platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.checksum:
  • platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.png:
  • platform/qt/svg/custom/pattern-skew-transformed-expected.checksum:
  • platform/qt/svg/custom/pattern-skew-transformed-expected.png:
  • platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum:
  • platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
  • platform/qt/svg/custom/recursive-filter-expected.checksum:
  • platform/qt/svg/custom/recursive-filter-expected.png:
  • platform/qt/svg/custom/recursive-gradient-expected.checksum:
  • platform/qt/svg/custom/recursive-gradient-expected.png:
  • platform/qt/svg/custom/recursive-mask-expected.checksum:
  • platform/qt/svg/custom/recursive-mask-expected.png:
  • platform/qt/svg/custom/recursive-pattern-expected.checksum:
  • platform/qt/svg/custom/recursive-pattern-expected.png:
  • platform/qt/svg/custom/relative-sized-content-with-resources-expected.checksum:
  • platform/qt/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/qt/svg/custom/relative-sized-inner-svg-expected.checksum:
  • platform/qt/svg/custom/relative-sized-inner-svg-expected.png:
  • platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum:
  • platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
  • platform/qt/svg/custom/repaint-on-constant-size-change-expected.checksum:
  • platform/qt/svg/custom/repaint-on-constant-size-change-expected.png:
  • platform/qt/svg/custom/repaint-stroke-width-changes-expected.checksum:
  • platform/qt/svg/custom/repaint-stroke-width-changes-expected.png:
  • platform/qt/svg/custom/text-rotation-expected.checksum:
  • platform/qt/svg/custom/text-rotation-expected.png:
  • platform/qt/svg/custom/text-x-dy-lists-expected.checksum:
  • platform/qt/svg/custom/text-x-dy-lists-expected.png:
  • platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.checksum:
  • platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.png:
  • platform/qt/svg/custom/use-property-synchronization-crash-expected.checksum:
  • platform/qt/svg/custom/use-property-synchronization-crash-expected.png:
  • platform/qt/svg/dom/SVGPathSegList-cloning-expected.checksum:
  • platform/qt/svg/dom/SVGPathSegList-cloning-expected.png:
  • platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.checksum:
  • platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.png:
  • platform/qt/svg/filters/filter-empty-g-expected.checksum:
  • platform/qt/svg/filters/filter-empty-g-expected.png:
  • platform/qt/svg/filters/filter-on-filter-for-text-expected.checksum:
  • platform/qt/svg/filters/filter-on-filter-for-text-expected.png:
  • platform/qt/svg/filters/filter-on-tspan-expected.checksum:
  • platform/qt/svg/filters/filter-on-tspan-expected.png:
  • platform/qt/svg/filters/filter-width-update-expected.checksum:
  • platform/qt/svg/filters/filter-width-update-expected.png:
  • platform/qt/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.checksum:
  • platform/qt/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png:
  • platform/qt/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.checksum:
  • platform/qt/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png:
  • platform/qt/svg/foreignObject/svg-document-as-direct-child-expected.checksum:
  • platform/qt/svg/foreignObject/svg-document-as-direct-child-expected.png:
  • platform/qt/svg/foreignObject/svg-document-in-html-document-expected.checksum:
  • platform/qt/svg/foreignObject/svg-document-in-html-document-expected.png:
  • platform/qt/svg/foreignObject/text-tref-02-b-expected.checksum:
  • platform/qt/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/qt/svg/in-html/circle-expected.checksum:
  • platform/qt/svg/in-html/circle-expected.png:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.checksum:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.checksum:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.checksum:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.checksum:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png:
  • platform/qt/svg/text/lengthAdjust-text-metrics-expected.checksum:
  • platform/qt/svg/text/lengthAdjust-text-metrics-expected.png:
  • platform/qt/svg/text/selection-styles-expected.checksum:
  • platform/qt/svg/text/selection-styles-expected.png:
  • platform/qt/svg/text/text-hkern-expected.checksum:
  • platform/qt/svg/text/text-hkern-expected.png:
  • platform/qt/svg/text/text-hkern-on-vertical-text-expected.checksum:
  • platform/qt/svg/text/text-hkern-on-vertical-text-expected.png:
  • platform/qt/svg/text/text-vkern-expected.checksum:
  • platform/qt/svg/text/text-vkern-expected.png:
  • platform/qt/svg/text/text-vkern-on-horizontal-text-expected.checksum:
  • platform/qt/svg/text/text-vkern-on-horizontal-text-expected.png:
  • platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum:
  • platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
  • platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.checksum:
  • platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
4:11 AM Changeset in webkit [78992] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-02-18 Mikhail Naganov < mnaganov@chromium.org>

[Chromium] Unreviewed test expectations fix.
Again, a quick fix for deeply-nested-reflections.html.

3:52 AM Changeset in webkit [78991] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-18 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip a GTK media test affected by pixel diferrence
between 32/64-Bits bots.

[GTK] media/video-display-toggle.html is flaky on debug bots
https://bugs.webkit.org/show_bug.cgi?id=54637

  • platform/gtk/Skipped:
3:49 AM Changeset in webkit [78990] by Csaba Osztrogonác
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed.

[Qt] http/tests/security/xssAuditor/script-tag-with-fancy-unicode.html fails
https://bugs.webkit.org/show_bug.cgi?id=54630

Platform independent expected fail isn't good for Qt, because
this test passes on Qt, so add Qt specific expected result.

  • platform/qt/Skipped: Unskip the passing test.
  • platform/qt/http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt: Added.
3:42 AM Changeset in webkit [78989] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-18 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip a GTK media test affected by pixel diferrence
between 32/64-Bits bots.

[GTK] media/video-display-toggle.html is flaky on debug bots
https://bugs.webkit.org/show_bug.cgi?id=54637

  • platform/gtk/Skipped:
2:56 AM Changeset in webkit [78988] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-02-18 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
Also mark deeply-nested-reflections as failing on GPU Mac.

2:52 AM Changeset in webkit [78987] by Philippe Normand
  • 3 edits
    2 deletes in trunk

2011-02-18 Philippe Normand <pnormand@igalia.com>

Unreviewed, rolling out r78979.
http://trac.webkit.org/changeset/78979
https://bugs.webkit.org/show_bug.cgi?id=53146

causes multiple crashes on GTK

  • platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Removed.
  • platform/gtk/accessibility/combo-box-collapsed-selection-changed.html: Removed.

2011-02-18 Philippe Normand <pnormand@igalia.com>

Unreviewed, rolling out r78979.
http://trac.webkit.org/changeset/78979
https://bugs.webkit.org/show_bug.cgi?id=53146

causes multiple crashes on GTK

  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::notifyChildrenSelectionChange): (WebCore::AXObjectCache::postPlatformNotification):
2:51 AM Changeset in webkit [78986] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-18 Philippe Normand <pnormand@igalia.com>

Unreviewed, rolling out r78982.
http://trac.webkit.org/changeset/78982

  • platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt:
2:48 AM Changeset in webkit [78985] by mnaganov@chromium.org
  • 2 edits
    5 adds in trunk/LayoutTests/platform

2011-02-18 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
Rebaseline 3 windows tests, and mark tests from r78983 as Mac-specific.
https://bugs.webkit.org/show_bug.cgi?id=54736

2:44 AM Changeset in webkit [78984] by morrita@google.com
  • 3 edits in trunk/Tools

2011-02-16 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

[Chromium][DRT] some PostDelayedTask() accesses possibly dangling this pointer.
http://webkit.org/b/53899

Replaced static invocation wrappers with MethodTask objects,
which are removed on WebViewHost destructor.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::requestCheckingOfText): (WebViewHost::scheduleAnimation): (WebViewHost::closeWidgetSoon):
  • DumpRenderTree/chromium/WebViewHost.h: (WebViewHost::HostMethodTask::HostMethodTask): (WebViewHost::HostMethodTask::runIfValid): (WebViewHost::taskList):
2:39 AM Changeset in webkit [78983] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-02-18 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.
Mark failing tests until we can rebaseline them.
https://bugs.webkit.org/show_bug.cgi?id=54736

2:26 AM Changeset in webkit [78982] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-18 Philippe Normand <pnormand@igalia.com>

Unreviewed, update platform/gtk/accessibility test baselines as
requested by Mario Sanchez Prada.

  • platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt:
2:05 AM Changeset in webkit [78981] by Philippe Normand
  • 4 edits in trunk

2011-02-18 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] minimal build unrecognized options
https://bugs.webkit.org/show_bug.cgi?id=50890

  • configure.ac: added new configure options to enable/disable the meter element, progress element, datagrid and client-based geolocation support.

2011-02-18 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] minimal build unrecognized options
https://bugs.webkit.org/show_bug.cgi?id=50890

  • GNUmakefile.am: new feature defines for optional features build.
1:56 AM Changeset in webkit [78980] by hans@chromium.org
  • 6 edits in trunk

2011-02-17 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Populate indexes created for object stores with data
https://bugs.webkit.org/show_bug.cgi?id=54669

Test that creating an index for an object store that already holds
data works.

  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:

2011-02-17 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Populate indexes created for object stores with data
https://bugs.webkit.org/show_bug.cgi?id=54669

Make sure that indices for object stores that already hold data get
populated.

  • storage/IDBIndexBackendImpl.h: (WebCore::IDBIndexBackendImpl::hasValidId):
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::putInternal): (WebCore::populateIndex): (WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
1:46 AM Changeset in webkit [78979] by mario@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-18 Mario Sanchez Prada <msanchez@igalia.com>

[GTK] Combo boxes should emit object:selection-changed even when collapsed
https://bugs.webkit.org/show_bug.cgi?id=53146

New GTK-specific layout test to check the right signals are emitted.

  • platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Added.
  • platform/gtk/accessibility/combo-box-collapsed-selection-changed.html: Added.

2011-02-18 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Combo boxes should emit object:selection-changed even when collapsed
https://bugs.webkit.org/show_bug.cgi?id=53146

Emit the selection-changed signals when the menu list value has changed

Test: platform/gtk/accessibility/combo-box-collapsed-selection-changed.html

  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::getListObject): New, return the right list object for menu lists and list boxes. (WebCore::notifyChildrenSelectionChange): Support menu lists. (WebCore::AXObjectCache::postPlatformNotification): Call function notifyChildrenSelectionChange for AXMenuListValueChanged.
1:40 AM Changeset in webkit [78978] by mario@webkit.org
  • 4 edits in trunk/Source

2011-02-18 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] atk_text_get_selection/atk_text_set_selection fails for list items
https://bugs.webkit.org/show_bug.cgi?id=53453

Ensure that atk_text_{get|set}_selection() work with list items.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_text): Properly handle list item markers when returning the text for an object for a given interval specified through the startOffset and endOffset parameters. (getSelectionOffsetsForObject): Bear in mind list item markers when returning the offsets for a selection over a list item. (webkit_accessible_text_set_selection): Adjust offsets if needed for list items with item markers. Ensure that it returns TRUE only when everything went fine setting the text selection.

2011-02-18 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] atk_text_get_selection/atk_text_set_selection fails for list items
https://bugs.webkit.org/show_bug.cgi?id=53453

Update unit test to check the fix for this bug.

  • tests/testatk.c: (testWebkitAtkTextSelections): Check that functions from AtkText interface to set and get text selections work with list items.
1:31 AM Changeset in webkit [78977] by alex
  • 2 edits in trunk/Source/WebKit2

2011-02-18 Alejandro G. Castro <alex@igalia.com>

Fix GTK build by fixing signature of platformPaint(), required after r78956.

  • WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp: (WebKit::NetscapePlugin::platformPaint):
1:18 AM Changeset in webkit [78976] by Philippe Normand
  • 20 edits in trunk/LayoutTests

2011-02-18 Philippe Normand <pnormand@igalia.com>

Unreviewed, update GTK tables/mozilla_expected_failures baselines

  • platform/gtk/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug104898-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-1-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-4-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-7-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-8-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
1:10 AM Changeset in webkit [78975] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-18 Philippe Normand <pnormand@igalia.com>

Unreviewed, update GTK media test baselines

  • platform/gtk/media/video-controls-in-media-document-expected.txt:
1:07 AM Changeset in webkit [78974] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=54728
checkSelector*Value functions used in fastCheckSelector fail to inline

Reviewed by Maciej Stachowiak.

Wrap the functions used as template arguments to classes.

  • css/CSSStyleSelector.cpp:

(WebCore::fastCheckSingleSelector):
(WebCore::ClassCheck::checkValue):
(WebCore::IdCheck::checkValue):
(WebCore::TagCheck::checkValue):
(WebCore::CSSStyleSelector::SelectorChecker::fastCheckSelector):

12:30 AM Changeset in webkit [78973] by Philippe Normand
  • 2 edits
    1 add in trunk/LayoutTests

2011-02-17 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] media/video-controls-in-media-document.html potentially flaky
https://bugs.webkit.org/show_bug.cgi?id=54631

Refactored the test to roll the element to play before dumping the
DRT. Also added baselines for GTK and fixed the media-file.js
include after r78778.

  • media/video-controls-in-media-document.html:
  • platform/gtk/media/video-controls-in-media-document-expected.txt: Added.
12:27 AM Changeset in webkit [78972] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-18 Philippe Normand <pnormand@igalia.com>

Unreviewed, update GTK media test baselines

  • platform/gtk/media/controls-styling-expected.txt:
12:18 AM Changeset in webkit [78971] by Lucas Forschler
  • 5 edits in branches/safari-534.20-branch/Source

Versioning.

12:01 AM Changeset in webkit [78970] by Lucas Forschler
  • 1 copy in tags/Safari-534.20.3

New tag.

Note: See TracTimeline for information about the timeline view.