Timeline



Feb 27, 2011:

11:30 PM Changeset in webkit [79844] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-27 Aparna Nandyal <aparna.nand@wipro.com>

Reviewed by Antonio Gomes.

[Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
https://bugs.webkit.org/show_bug.cgi?id=53917

The bug got fixed by other changes. Adding test case to avoid
regressions in the future.

  • fast/overflow/horizontal-scroll-after-back-expected.txt: Added.
  • fast/overflow/horizontal-scroll-after-back.html: Added.

2011-02-27 Aparna Nandyal <aparna.nand@wipro.com>

Reviewed by Antonio Gomes.

[Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
https://bugs.webkit.org/show_bug.cgi?id=53917

Adding test case to check the scenario to avoid regressions in the
future.

  • tests/qwebframe/tst_qwebframe.cpp:
11:28 PM Changeset in webkit [79843] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-02-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Darin Fisher.

Pass frame history state in the context menu parameters.
https://bugs.webkit.org/show_bug.cgi?id=55232

  • public/WebContextMenuData.h:
  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
10:53 PM Changeset in webkit [79842] by Patrick Gansterer
  • 4 edits in trunk/Source/WebCore

2011-02-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Remove registerBaseEncodingNames and registerBaseCodecs from TextCodecWinCE
https://bugs.webkit.org/show_bug.cgi?id=55317

This functions are obsolete, since r78499 added TextCodecUTF8.
Also remove the "fast path" for UTF-8 data, because we now have a separate TextCodec.

  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps):
  • platform/text/wince/TextCodecWinCE.cpp:
  • platform/text/wince/TextCodecWinCE.h:
9:49 PM Changeset in webkit [79841] by ojan@chromium.org
  • 3 edits in trunk/Tools

2011-02-27 Ojan Vafai <ojan@chromium.org>

Fix failing tests from http://trac.webkit.org/changeset/79837.

  • Scripts/webkitpy/layout_tests/layout_package/printing.py: This was just a mistake that would break if someone tried printing with this configuration.
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: Method signature changed. Didn't notice that this method was being calling in a unittest.
9:18 PM Changeset in webkit [79840] by hayato@chromium.org
  • 6 edits
    5 deletes in trunk/Tools

2011-02-24 Hayato Ito <hayato@chromium.org>

Reviewed by Eric Seidel.

[NRWT] Remove test_types/* classes.

This is the last patch in the series of efforts which tried to remove test_types classes.
A single_test_runner module will take over responsibilities of test_type classes.

From this patch, we won't display statistics per test_type even if a '--verbose' option is given.

https://bugs.webkit.org/show_bug.cgi?id=55123

  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
  • Scripts/webkitpy/layout_tests/test_types/init.py: Removed.
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py: Removed.
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Removed.
  • Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py: Removed.
8:35 PM Changeset in webkit [79839] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Force dictionary popup to use overlay type
<rdar://problem/9052483>
https://bugs.webkit.org/show_bug.cgi?id=55337

Reviewed by Dan Bernstein.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didPerformDictionaryLookup): As this is only
used for the hot key version of the dictionary popup, force the overlay
style.

8:00 PM Changeset in webkit [79838] by gyuyoung.kim@samsung.com
  • 8 edits in trunk/Source/WebKit/efl

2011-02-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Restore parameters of efl header files.
https://bugs.webkit.org/show_bug.cgi?id=55292

Restore parameters in efl header files.

  • ewk/ewk_frame.h:
  • ewk/ewk_tiled_backing_store.h:
  • ewk/ewk_tiled_matrix.h:
  • ewk/ewk_tiled_model.h:
  • ewk/ewk_view.cpp: (ewk_view_pre_render_relative_radius):
  • ewk/ewk_view.h:
  • ewk/ewk_window_features.h:
7:55 PM Changeset in webkit [79837] by ojan@chromium.org
  • 7 edits in trunk/Tools

2011-02-25 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

Change results.json format to the one used by unexpected_results.json
https://bugs.webkit.org/show_bug.cgi?id=52267

Also add runtimes in milliseconds to the JSON and make the output format more compact.
Named the file full_results.json to avoid conflicting with the results.json
file the test-results server currently serves up.

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
7:39 PM Changeset in webkit [79836] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-25 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

[codereviewtool] fix expand links on git diffs
https://bugs.webkit.org/show_bug.cgi?id=55208

In git diffs, we don't have a "revision" span at the end
of each FileDiff.

  • code-review.js:
7:11 PM Changeset in webkit [79835] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement WTF::randomNumber in terms of WTF::cryptographicallyRandomNumber when possible
https://bugs.webkit.org/show_bug.cgi?id=55326

Currently, randomNumber does a bunch of platform-specific work that to
get a cryptographic randomness when available. Instead, we should use
cryptographicallyRandomNumber, which abstracts this work.
Unfortunately, we can't remove all of the WTF::randomNumber
implementation because not every port has access to cryptographically
random numbers.

  • wtf/RandomNumber.cpp: (WTF::randomNumber):
5:33 PM Changeset in webkit [79834] by benjamin.poulain@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Sam Weinig.

Use OwnPtr to handle the memory of RenderBlock::m_floatingObjects and RenderBlock::m_positionedObjects
https://bugs.webkit.org/show_bug.cgi?id=55327

Refactor RenderBlock to use OwnPtr for m_floatingObjects and m_positionedObjects so we do not have
to release the memory manually.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::~RenderBlock): (WebCore::RenderBlock::selectionGaps): (WebCore::RenderBlock::insertPositionedObject): (WebCore::RenderBlock::insertFloatingObject): (WebCore::RenderBlock::addOverhangingFloats): (WebCore::RenderBlock::addIntrudingFloats):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::positionedObjects):
4:10 PM Debugging With Visual Studio edited by dbates@webkit.org
Fix misspelled word; "pauses all processes" should be "pause all … (diff)
3:28 PM Changeset in webkit [79833] by Adam Roben
  • 2 edits in trunk/Tools

Followup fix to r79827

  • DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::webViewAddMessageToConsole): Replaced call to urlSuitableForTestResult with
lastPathComponent. This matches what we did here before r79827, and matches Mac.

3:18 PM Changeset in webkit [79832] by benjamin.poulain@nokia.com
  • 3 edits in trunk/Source/WebKit2

[Qt] [WK2] QGraphicsWKView::showContextMenu() should be public
https://bugs.webkit.org/show_bug.cgi?id=55330

Reviewed by Kenneth Rohde Christiansen.

Move QGraphicsWKView::showContextMenu() to the public API. Add documentation
on its use.

  • UIProcess/API/qt/qgraphicswkview.cpp:
  • UIProcess/API/qt/qgraphicswkview.h:
2:14 PM Changeset in webkit [79831] by mitz@apple.com
  • 2 edits in trunk/Tools

Make bisect-builds print a trac link for the regression range
https://bugs.webkit.org/show_bug.cgi?id=55331

Reviewed by Adam Roben.

  • Scripts/bisect-builds:
1:51 PM Changeset in webkit [79830] by Adam Roben
  • 2 edits in trunk/Tools

Use iswalpha instead of isalpha when dealing with wchar_ts in EditingDelegate

Fixes <http://webkit.org/b/55062> <rdar://problem/9059907> Crash beneath
EditingDelegate::checkSpellingOfString when running fast/forms/input-text-maxlength.html or
fast/forms/input-text-paste-maxlength.html on Windows with full page heap enabled

Reviewed by Anders Carlsson.

  • DumpRenderTree/win/EditingDelegate.cpp:

(indexOfFirstWordCharacter):
(wordLength):
Use iswalpha instead of isalpha, since TCHAR is really just wchar_t.

1:29 PM Changeset in webkit [79829] by Adam Roben
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows expected failure results for fast/events/pageshow-pagehide-on-back-cached.html

<http://webkit.org/b/55329> tracks the failure.

  • platform/win/fast/events/pageshow-pagehide-on-back-cached-expected.txt: Added.
1:29 PM Changeset in webkit [79828] by Adam Roben
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows expected failure results for fast/images/support-broken-image-delegate.html

<http://webkit.org/b/55324> tracks the failure.

  • platform/win/fast/images/support-broken-image-delegate-expected.txt: Added.
1:16 PM Changeset in webkit [79827] by Adam Roben
  • 4 edits in trunk/Tools

Make ResourceLoadDelegate print URLs relative to the main resource on Windows

This matches Mac. (In fact, the code was ported from Mac!)

Fixes <http://webkit.org/b/55328> URLs printed by ResourceLoadDelegate on Windows don't
match Mac

Reviewed by Anders Carlsson.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(substringFromIndex): Added. Emulates -[NSString substringFromIndex:].
(urlSuitableForTestResult): Ported code from -[NSURL(DRTExtras)
_drt_descriptionSuitableForTestResult].
(cfStringRefToWString): Moved here from LayoutTestControllerWin.cpp.

  • DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of cfStringRefToWString.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: Moved cfStringRefToWString to

DumpRenderTree.cpp.

11:38 AM Changeset in webkit [79826] by benjamin.poulain@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] Reference the documentation of the WebKit bridge from QWebFrame::addToJavaScriptWindowObject()
https://bugs.webkit.org/show_bug.cgi?id=55322

Documentation update, add a reference to the QtWebKit bridge page.

  • Api/qwebframe.cpp:
11:00 AM Debugging With Visual Studio edited by Adam Roben
Removed unnecessary ".dll" suffixes (diff)
11:00 AM Debugging With Visual Studio edited by Adam Roben
Updated CFShow instructions (diff)
10:59 AM Changeset in webkit [79825] by benjamin.poulain@nokia.com
  • 9 edits
    3 deletes in trunk/Source/WebCore

Eliminate DeprecatedPtrList
https://bugs.webkit.org/show_bug.cgi?id=17425

Reviewed by Andreas Kling.

Remove the implementation of DeprecatedPtrList and all its references
from the build systems.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/DeprecatedPtrList.h: Removed.
  • platform/DeprecatedPtrListImpl.cpp: Removed.
  • platform/DeprecatedPtrListImpl.h: Removed.
10:25 AM Changeset in webkit [79824] by Adam Roben
  • 1 edit
    1 delete in trunk/LayoutTests

Remove Windows-specific html5lib results

I suspect these haven't been needed since r77781.

  • platform/win/html5lib/runner-expected.txt: Removed.
10:15 AM Changeset in webkit [79823] by Adam Roben
  • 2 edits in trunk/Tools

Change the order of Chang Shu's email addresses so the first one is their Bugzilla username

This makes Bugzilla autocompletion work correctly.

  • Scripts/webkitpy/common/config/committers.py:
10:05 AM Changeset in webkit [79822] by alex
  • 3 edits in trunk/Source/WebKit2

2011-02-27 Alejandro G. Castro <alex@igalia.com>

Unreviewed, fixed GTK compilation after r79806.

  • UIProcess/gtk/WebView.cpp: (WebKit::WebView::didFinishLoadingDataForCustomRepresentation):
  • UIProcess/gtk/WebView.h:
10:04 AM Changeset in webkit [79821] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip fast/frames/iframe-plugin-load-remove-document-crash.html on Windows

It's been crashing since it was added in r79808. <http://webkit.org/b/55307> tracks the
failure.

  • platform/win/Skipped:
9:59 AM Changeset in webkit [79820] by Patrick Gansterer
  • 4 edits in trunk

2011-02-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[Qt] fast/loader/user-stylesheet-fast-path.html fails
https://bugs.webkit.org/show_bug.cgi?id=50911

  • platform/qt/Skipped: Unskip test which is now passing.

2011-02-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[Qt] fast/loader/user-stylesheet-fast-path.html fails
https://bugs.webkit.org/show_bug.cgi?id=50911

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setUserStyleSheetLocation): Use QUrl::fromEncoded since the passed string is already encoded.
9:29 AM Changeset in webkit [79819] by Adam Roben
  • 2 edits in trunk/Tools

Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving

Windows 7 (and maybe Vista?) launches the post-mortem debugger with a working directory that
is different from old-run-webkit-test's. Because of this, the path to the crash log file
(which is relative to $testResultsDirectory) must be an absolute path. See the bug for more
details.

Fixes <http://webkit.org/b/55318> Crash logs aren't saved on Windows 7 when a relative
--results-directory path is used (like on the test slaves)

Reviewed by Dan Bernstein.

  • Scripts/old-run-webkit-tests: Moved the call to setUpWindowsCrashLogSaving after we've

made $testResultsDirectory an absolute path.

8:37 AM QtWebKitDocContrib edited by benjamin.poulain@nokia.com
Update some references since the code have moved. (diff)
7:56 AM Changeset in webkit [79818] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-02-27 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Use WTF ref counting for FontPlatformDataPrivate
https://bugs.webkit.org/show_bug.cgi?id=55303

Make FontPlatformDataPrivate a RefCounted<FPDP>.
Incidentally fixes an uninitialized member bug in FontPlatformData().

  • platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::font): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::family): (WebCore::FontPlatformData::bold): (WebCore::FontPlatformData::italic): (WebCore::FontPlatformData::smallCaps): (WebCore::FontPlatformData::pixelSize):
  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::toQFontWeight): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::hash):
7:51 AM Changeset in webkit [79817] by benjamin.poulain@nokia.com
  • 6 edits in trunk/Source

Eliminate DeprecatedPtrList from RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=54972

Patch by Benjamin Poulain <ikipou@gmail.com> on 2011-02-27
Reviewed by Darin Adler.

Source/JavaScriptCore:

Add methods find() and contains() using an adaptor to ListHashSet.
Those method are like the one of HashSet, they allow to find objects
based on a different key than the one used to define the set.

Add convenience methods for direct access to the head and tail of the list.
Those methods are providing similar API/behavior as Vector.

  • wtf/ListHashSet.h:

(WTF::::first):
(WTF::::last):
(WTF::::removeLast):
(WTF::ListHashSetTranslatorAdapter::hash):
(WTF::ListHashSetTranslatorAdapter::equal):
(WTF::::find):
(WTF::::contains):

Source/WebCore:

Refactor RenderBlock to get rid of the DeprecatedPtrList.
The floating objects are stored in a ListHashSet.

Refactoring covered by existing test.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::positionNewFloatOnLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::containsFloat):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObjectHashFunctions::hash):
(WebCore::RenderBlock::FloatingObjectHashFunctions::equal):
(WebCore::RenderBlock::FloatingObjectHashTranslator::hash):
(WebCore::RenderBlock::FloatingObjectHashTranslator::equal):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::matchedEndLine):

Feb 26, 2011:

10:53 PM Changeset in webkit [79816] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

<input value="type=submit"> throws a warning (“HTML parse error”)
https://bugs.webkit.org/show_bug.cgi?id=55120

This patch removes parse error messages from the HTML parser. These
messages are displayed at the wrong times, aren't tested, and aren't
helpful. We'll try again with some more informative messages and
better testing.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::parseError):
7:38 PM Changeset in webkit [79815] by Patrick Gansterer
  • 4 edits in trunk/Source/WebCore

2011-02-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Alexey Proskuryakov.

Remove registerBaseEncodingNames and registerBaseCodecs from TextCodecBrew
https://bugs.webkit.org/show_bug.cgi?id=55309

This functions are obsolete, since r78499 added TextCodecUTF8.

  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps):
  • platform/text/brew/TextCodecBrew.cpp:
  • platform/text/brew/TextCodecBrew.h:
7:28 PM Changeset in webkit [79814] by commit-queue@webkit.org
  • 2 edits in trunk

2011-02-26 Dihan Wickremasuriya <dihan.wickremasuriya@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] [Symbian] Disable dependency to a specific version of a Qt package for
non-production builds.
https://bugs.webkit.org/show_bug.cgi?id=55313

  • Source/WebKit.pri:
6:45 PM Changeset in webkit [79813] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-02-26 Dominic Mazzoni <dmazzoni@google.com>

Reviewed by Adam Barth.

m_dumpAccessibilityNotifications should be initialized.
https://bugs.webkit.org/show_bug.cgi?id=54874

  • DumpRenderTree/chromium/AccessibilityController.cpp: (AccessibilityController::AccessibilityController):
3:03 PM Changeset in webkit [79812] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

Add support for DragonFly BSD
https://bugs.webkit.org/show_bug.cgi?id=54407

DragonFly BSD is based on FreeBSD, so handle it like FreeBSD.

  • wtf/Platform.h:
2:55 PM Changeset in webkit [79811] by inferno@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-26 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Skip the test on QT, GTK until we can figure out the plugin load problem.
https://bugs.webkit.org/show_bug.cgi?id=55307

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
2:40 PM Changeset in webkit [79810] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-26 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

Delay firing of mutation events while setting attribute values
https://bugs.webkit.org/show_bug.cgi?id=55199

  • fast/dom/attribute-change-on-mutate-expected.txt: Added.
  • fast/dom/attribute-change-on-mutate.html: Added.

2011-02-26 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

Delay firing of mutation events while setting attribute values
https://bugs.webkit.org/show_bug.cgi?id=55199

Test: fast/dom/attribute-change-on-mutate.html

  • dom/Attr.cpp: (WebCore::Attr::setValue):
2:38 PM Changeset in webkit [79809] by yi.4.shen@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-02-26 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Notify HTMLMediaElement when MediaPlayerPrivateQt's playback state gets changed
https://bugs.webkit.org/show_bug.cgi?id=55252

Need to invoke a callback function to notify the HTMLMediaElement
when MediaPlayerPrivateQt's playback state gets changed.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): Set a flag to ignore the playback state change for pre-roll (WebCore::MediaPlayerPrivateQt::commitLoad): Call playbackStateChanged() to notify HTMLMediaElement (WebCore::MediaPlayerPrivateQt::stateChanged):
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
1:26 PM Changeset in webkit [79808] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-25 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Tests that removing a document during a plugin load does not result
in crash.
https://bugs.webkit.org/show_bug.cgi?id=55289

  • fast/frames/iframe-plugin-load-remove-document-crash-expected.txt: Added.
  • fast/frames/iframe-plugin-load-remove-document-crash.html: Added.

2011-02-25 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

When plugin document parser finishes parsing, it runs the raw
document's parser finish functions which call the pending document
onload events that removes the frame from underneath. So, we protect
frame (and hence frameloader) in DocumentLoader::commitLoad.
https://bugs.webkit.org/show_bug.cgi?id=55289

Test: fast/frames/iframe-plugin-load-remove-document-crash.html

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitLoad):
1:02 PM Changeset in webkit [79807] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-26 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Asynchronous response to FramePolicyListener is not finishing the load
https://bugs.webkit.org/show_bug.cgi?id=55305
<rdar://problem/9044356>

Always initialize the receivedPolicyAction reply parameter.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::decidePolicyForNavigationAction): (WebKit::WebPageProxy::decidePolicyForMIMEType):
12:44 PM Changeset in webkit [79806] by andersca@apple.com
  • 16 edits in trunk/Source/WebKit2

2011-02-26 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

DidFinishLoadingDataForCustomRepresentation should pass along the suggested filename
https://bugs.webkit.org/show_bug.cgi?id=55304

  • UIProcess/API/mac/PDFViewController.h:
  • UIProcess/API/mac/PDFViewController.mm: (WebKit::PDFViewController::setPDFDocumentData):
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
  • UIProcess/API/mac/WKView.mm: (-[WKView _didFinishLoadingDataForCustomRepresentationWithSuggestedFilename:dataReference:CoreIPC::]):
  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::didFinishLoadingDataForCustomRepresentation):
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didFinishLoadingDataForCustomRepresentation):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/win/WebView.cpp: (WebKit::WebView::didFinishLoadingDataForCustomRepresentation):
  • UIProcess/win/WebView.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::finishedLoading):
12:14 PM Changeset in webkit [79805] by pfeldman@chromium.org
  • 18 edits
    31 deletes in trunk

2011-02-26 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: rolling out 79799 and 79804 for breaking xml tests on mac.

11:58 AM Changeset in webkit [79804] by pfeldman@chromium.org
  • 4 edits in trunk

2011-02-26 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: follow up to r79799. Fixing WinCE+Efl, mute new tests on Qt.
https://bugs.webkit.org/show_bug.cgi?id=55302

  • CMakeLists.txt:
  • platform/qt/Skipped:
11:10 AM Changeset in webkit [79803] by andersca@apple.com
  • 25 edits in trunk/Source/WebKit2

2011-02-26 Anders Carlsson <andersca@apple.com>

Reviewed by Oliver Hunt.

DrawingArea should not be reference counted
https://bugs.webkit.org/show_bug.cgi?id=55284

  • Shared/DrawingAreaInfo.h:
  • Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode): (WebKit::WebPageCreationParameters::decode):
  • Shared/WebPageCreationParameters.h:
  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy): (WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible): (WebKit::ChunkedUpdateDrawingAreaProxy::update): (WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
  • UIProcess/ChunkedUpdateDrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::DrawingAreaProxy):
  • UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::type):
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveSyncMessage): (WebKit::WebPageProxy::creationParameters):
  • WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea): (WebKit::ChunkedUpdateDrawingArea::display): (WebKit::ChunkedUpdateDrawingArea::setSize): (WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create): (WebKit::DrawingArea::DrawingArea):
  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::create): (WebKit::DrawingAreaImpl::DrawingAreaImpl):
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/TiledDrawingArea.cpp: (WebKit::TiledDrawingArea::TiledDrawingArea):
  • WebProcess/WebPage/TiledDrawingArea.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRect):
  • WebProcess/WebPage/WebPage.h:
11:08 AM Changeset in webkit [79802] by commit-queue@webkit.org
  • 5 edits
    1 copy in trunk/Source/WebKit/gtk

2011-02-26 Lukasz Slachciak <l.slachciak@samsung.com>

Reviewed by Xan Lopez.

[GTK] Implemented API to set/get web application cache directory path database.

  • GNUmakefile.am: Add webkitapplicationcache.h file.
  • webkit/webkit.h: Add webkitapplicationcache.h file.
  • webkit/webkitapplicationcache.cpp: definition of API setting and getting web application cache directory path database. (webkit_application_cache_get_database_directory_path): (webkit_application_cache_set_database_directory_path):
  • webkit/webkitapplicationcache.h: Added new API file for setting and getting web application cache directory path database.
  • webkit/webkitglobals.cpp: (webkitInit): use webkit_application_cache_set_database_directory_path to set default web application cache directory path database.
11:06 AM Changeset in webkit [79801] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-26 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Add failing expectation for fast/images/support-broken-image-delegate.html

  • platform/chromium/test_expectations.txt:
11:00 AM Changeset in webkit [79800] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-26 Mihai Parparita <mihaip@chromium.org>

Unreviewed update of the Chromium html5lib expectations after r79765
(diff matches the base expectations change).

  • platform/chromium/html5lib/runner-expected.txt:
10:54 AM Changeset in webkit [79799] by pfeldman@chromium.org
  • 17 edits
    36 adds in trunk

2011-02-25 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

XML without style should render as syntax-highlighted source.
https://bugs.webkit.org/show_bug.cgi?id=13807

Added tests for XML tree view mode. Testing both logic for entering
XML tree view mode and rendering itself.

  • http/tests/xmlviewer/dumpAsText/css-stylesheet-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/css-stylesheet.xml: Added.
  • http/tests/xmlviewer/dumpAsText/frames-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/frames.html: Added.
  • http/tests/xmlviewer/dumpAsText/mathml-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/mathml.xml: Added.
  • http/tests/xmlviewer/dumpAsText/resources/css-stylesheet.css: Added. (assertion):
  • http/tests/xmlviewer/dumpAsText/resources/frames-helper.xml: Added.
  • http/tests/xmlviewer/dumpAsText/resources/xsl.xml: Added.
  • http/tests/xmlviewer/dumpAsText/svg-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/svg.xml: Added.
  • http/tests/xmlviewer/dumpAsText/wml-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/wml.xml: Added.
  • http/tests/xmlviewer/dumpAsText/xhtml-tag-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/xhtml-tag.xml: Added.
  • http/tests/xmlviewer/dumpAsText/xlink-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/xlink.xml: Added.
  • http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml: Added.
  • http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml: Added.
  • http/tests/xmlviewer/dumpAsText/xmlviewer-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/xmlviewer.xml: Added.
  • http/tests/xmlviewer/dumpAsText/xsl-stylesheet-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml: Added.
  • http/tests/xmlviewer/dumpAsText/xul-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/xul.xml: Added.
  • platform/chromium/http/tests/xmlviewer/dumpAsText/mathml-expected.txt: Added.

2011-02-25 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

XML without style should render as syntax-highlighted source.
https://bugs.webkit.org/show_bug.cgi?id=13807

XML tree view mode implemented. If XML does not have any style
information, it is rendered as highlighted source with collapsable
elements.

Tests: http/tests/xmlviewer/dumpAsText/css-stylesheet.xml

http/tests/xmlviewer/dumpAsText/frames.html
http/tests/xmlviewer/dumpAsText/mathml.xml
http/tests/xmlviewer/dumpAsText/svg.xml
http/tests/xmlviewer/dumpAsText/wml.xml
http/tests/xmlviewer/dumpAsText/xhtml-tag.xml
http/tests/xmlviewer/dumpAsText/xlink.xml
http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml
http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml
http/tests/xmlviewer/dumpAsText/xmlviewer.xml
http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml
http/tests/xmlviewer/dumpAsText/xul.xml

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchUARules):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::createElement):
  • dom/Document.h: (WebCore::Document::usesViewSourceStyles): (WebCore::Document::setUsesViewSourceStyles): (WebCore::Document::sawElementsInKnownNamespaces):
  • dom/XMLDocumentParser.h:
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd):
  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::parseProcessingInstruction):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
  • xml/XMLTreeViewer.cpp: Added. (WebCore::XMLTreeViewer::XMLTreeViewer): (WebCore::XMLTreeViewer::hasNoStyleInformation): (WebCore::XMLTreeViewer::transformDocumentToTreeView):
  • xml/XMLTreeViewer.h: Added. (WebCore::XMLTreeViewer::~XMLTreeViewer):
  • xml/XMLViewer.xsl: Added.
  • xml/XSLStyleSheet.h: (WebCore::XSLStyleSheet::createFromString):
10:26 AM Changeset in webkit [79798] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

2011-02-26 Christian Dywan <christian@lanedo.com>

Reviewed by Andreas Kling.

Untranslated network error messages
https://bugs.webkit.org/show_bug.cgi?id=55223

  • POTFILES: Add FrameLoaderClientGtk.cpp.
9:29 AM Changeset in webkit [79797] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

2011-02-26 Adam Klein <adamk@chromium.org>

Reviewed by James Robinson.

[chromium] Update op-get-entry filesystem test to match spec
https://bugs.webkit.org/show_bug.cgi?id=55263

Chromium behavior changed in r76098. This patch updates WebKit test
to match. Both now match the spec, which says of TYPE_MISMATCH_ERR:

user agent MUST use this code when the user has attempted to look up
a file or directory, but the Entry found is of the wrong type

Reference: http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#error-code-descriptions

  • fast/filesystem/op-get-entry-expected.txt:
  • fast/filesystem/resources/op-get-entry.js: GetFile/GetDirectory now expected to return TYPE_MISMATCH_ERR if requesting a non-file/non-directory.
  • platform/chromium/test_expectations.txt: Allow op-get-entry to pass while waiting for Chromium roll.
9:26 AM Changeset in webkit [79796] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-26 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations change.

Remove failing Snow Leopard expectations for tests that were fixed by
r79754.

Skip more viewport tests added by r79783.

  • platform/chromium/test_expectations.txt:
9:12 AM Changeset in webkit [79795] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

2011-02-26 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable usage of synchronous HTTP feature in Qt
https://bugs.webkit.org/show_bug.cgi?id=37191

Currently, we spin an event loop when doing synchronous calls to
wait for completion. This patch uses synchronous requests in Qt,
if available, and spins the event loop as a fallback solution.

Based on work by Simon Hausmann and Peter Hartmann.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::start):
  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::setReplyFinished): (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail): (WebCore::ResourceHandle::loadResourceSynchronously):
9:02 AM Changeset in webkit [79794] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

REGRESSION(r79398): Webkit crash on dojo theme tester page
https://bugs.webkit.org/show_bug.cgi?id=55290

Added a test to ensure WebKit does not crash when querying style value without selection.

  • editing/execCommand/value-without-selection-crash-expected.txt: Added.
  • editing/execCommand/value-without-selection-crash.html: Added.

2011-02-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

REGRESSION(r79398): Webkit crash on dojo theme tester page
https://bugs.webkit.org/show_bug.cgi?id=55290

The bug was caused by selectionStartCSSPropertyValue's not considering the possibility
of selectionStartStyle() returning a null pointer. Fixed it by adding a null check.

Test: editing/execCommand/value-without-selection-crash.html

  • editing/Editor.cpp: (WebCore::Editor::selectionStartCSSPropertyValue):
8:31 AM Changeset in webkit [79793] by pfeldman@chromium.org
  • 30 edits in trunk

2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

No new tests. (no code affected, just exporting a method for DumpRenderTree use)

  • WebCore.exp.in:

2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WebFrame.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::clearOpener):
  • src/WebFrameImpl.h:

2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to DumpRenderTreeSupportGTK.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::clearOpener):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WebFramePrivate.

  • WebView/WebFrame.mm: (-[WebFrame _clearOpener]):
  • WebView/WebFramePrivate.h:

2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to DumpRenderTreeSupportQT.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::clearOpener):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to IWebFramePrivate.
Touched WebKit.idl to trigger build scripts.

  • Interfaces/IWebFramePrivate.idl:
  • Interfaces/WebKit.idl:
  • WebFrame.cpp: (WebFrame::clearOpener):
  • WebFrame.h:

2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WKBundleWebFramePrivate.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameClearOpener):
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:

2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener() calls between tests.
Some tests are using window.open() to change current window location.
This changes window.opener property whose nullity is checked before
showing xml viewer.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::reset):
8:20 AM Changeset in webkit [79792] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebKit/efl

2011-02-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Replace WTF_USE_SOUP macro with USE(SOUP)
https://bugs.webkit.org/show_bug.cgi?id=55296

ewk_cookies.cpp and ewk_main.cpp are using WTF_USE_SOUP macro.
So, according to policy decision macro usage, the macro needs to
be changed with USE(SOUP).

  • ewk/ewk_cookies.cpp: (ewk_cookies_file_set): (ewk_cookies_clear): (ewk_cookies_get_all): (ewk_cookies_cookie_del): (ewk_cookies_cookie_free): (ewk_cookies_policy_set): (ewk_cookies_policy_get):
  • ewk/ewk_main.cpp: (_ewk_init_body):
7:52 AM Changeset in webkit [79791] by yael.aharon@nokia.com
  • 4 edits in trunk

2011-02-26 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Fix the focus in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=55288

Implement basic functionality for focus in QWKPagePrivate.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::isViewWindowActive): (QWKPagePrivate::isViewFocused): (QWKPagePrivate::isViewVisible):

2011-02-26 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Fix the focus in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=55288

Give focus to the web view when a load starts.

  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::urlChanged):
7:48 AM Changeset in webkit [79790] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-26 Jia Pu <jpu@apple.com>

Reviewed by Dan Bernstein.

On Mac, need to remove misspell underline in Editor::learnSpelling().
https://bugs.webkit.org/show_bug.cgi?id=55251

This change makes sure that the misspelling markers are removed after the word is learned.

  • editing/Editor.cpp: (WebCore::Editor::learnSpelling):
7:38 AM Changeset in webkit [79789] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

2011-02-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Adam Barth.

[EFL] Add coding style exceptions for EFL port
https://bugs.webkit.org/show_bug.cgi?id=54733

The EFL APIs use EFL naming style, which includes both lower-cased and camel-cased,
underscore-sparated values. But, style checking rule have found parameter_name errors
in efl directories so far.

  • Scripts/webkitpy/style/checker.py: Add prameter_name rule's exception and efl directories.
7:32 AM Changeset in webkit [79788] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-26 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

JavaScriptCore should use the xcconfig file instead of importing that information into GYP
https://bugs.webkit.org/show_bug.cgi?id=55282

Technically, this breaks the build because I had removed one of the
warnings in this config file, but this change seems like an
improvement.

  • gyp/JavaScriptCore.gyp:
7:29 AM Changeset in webkit [79787] by levin@chromium.org
  • 3 edits in trunk/Tools

2011-02-26 David Levin <levin@chromium.org>

Reviewed by Darin Adler.

check-webkit-style should check for spaces after periods in comments
https://bugs.webkit.org/show_bug.cgi?id=55253

  • Scripts/webkitpy/style/checkers/cpp.py: Added the check.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests and fixed the name of one related test.
7:00 AM Changeset in webkit [79786] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-26 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: rolling chromium DEPS.

  • DEPS:
6:45 AM Changeset in webkit [79785] by levin@chromium.org
  • 2 edits in trunk/Websites/webkit.org

2011-02-26 David Levin <levin@chromium.org>

Reviewed by Darin Adler.

Add style guidelines about comments from the unwritten rules email.
https://bugs.webkit.org/show_bug.cgi?id=55272

  • coding/coding-style.html: Added the guidelines.
6:40 AM Changeset in webkit [79784] by commit-queue@webkit.org
  • 8 edits in trunk

2011-02-26 Rik Cabanier <cabanier@adobe.com>

Reviewed by David Hyatt.

Fix that allows fixed length values to be floating point
https://bugs.webkit.org/show_bug.cgi?id=52699

Transitions now return matrices in floating point. 2 of the transition tests were failing
because they expected integer values.

  • transitions/matched-transform-functions.html:
  • transitions/retargetted-transition.html:

2011-02-26 Rik Cabanier <cabanier@adobe.com>

Reviewed by David Hyatt.

Fix that allows fixed length values to be floating point
https://bugs.webkit.org/show_bug.cgi?id=52699

Transitions now return matrices in floating point. 2 of the transition tests were failing
because they expected integer values.

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp: (WebCore::convertToLength): (WebCore::convertToIntLength): (WebCore::convertToFloatLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::createTransformOperations):
  • platform/Length.h: (WebCore::Length::Length): (WebCore::Length::operator==): (WebCore::Length::operator!=): (WebCore::Length::rawValue): (WebCore::Length::type): (WebCore::Length::quirk): (WebCore::Length::setValue): (WebCore::Length::calcFloatValue): (WebCore::Length::isZero): (WebCore::Length::blend): (WebCore::Length::getIntValue): (WebCore::Length::getFloatValue):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):
6:39 AM Changeset in webkit [79783] by kenneth@webkit.org
  • 134 edits
    6 copies in trunk

2011-02-26 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

Make it possible to test the targetdensity-dpi support
https://bugs.webkit.org/show_bug.cgi?id=55142

  • fast/viewport/viewport-*.html: Update to new JS API.
  • fast/viewport/viewport-91.html: Add new tests.
  • fast/viewport/viewport-92.html:
  • fast/viewport/viewport-93.html:
  • fast/viewport/viewport-94.html:
  • fast/viewport/viewport-95.html:
  • fast/viewport/viewport-96.html:

2011-02-26 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

Make it possible to test the targetdensity-dpi support
https://bugs.webkit.org/show_bug.cgi?id=55142

Test the viewport meta tag feature targetdensity-dpi by
adding extra arguments to dumpConfigurationForViewport

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::dumpConfigurationForViewport):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-02-26 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

Make it possible to test the targetdensity-dpi support
https://bugs.webkit.org/show_bug.cgi?id=55142

Test the viewport meta tag feature targetdensity-dpi by
adding extra arguments to dumpConfigurationForViewport

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::viewportAsText):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-02-26 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

Make it possible to test the targetdensity-dpi support
https://bugs.webkit.org/show_bug.cgi?id=55142

Test the viewport meta tag feature targetdensity-dpi by
adding extra arguments to dumpConfigurationForViewport

Add the new arguments to the shared header and all
implementation.

  • DumpRenderTree/LayoutTestController.cpp: (dumpConfigurationForViewportCallback):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::dumpConfigurationForViewport):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::dumpConfigurationForViewport):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::dumpConfigurationForViewport):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::dumpConfigurationForViewport):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::dumpConfigurationForViewport):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
6:26 AM Changeset in webkit [79782] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-02-26 Bill Budge <bbudge@chromium.org>

Reviewed by David Levin.

WebURLRequest, WebURLResponse properties should be passed to WebCore Layer
https://bugs.webkit.org/show_bug.cgi?id=54489

No tests needed. This is already tested by ui_tests, nacl_ui_tests, and nacl_sandbox_tests

  • src/WebURLRequest.cpp: (WebKit::WebURLRequestPrivateImpl::WebURLRequestPrivateImpl): (WebKit::WebURLRequest::downloadToFile): (WebKit::WebURLRequest::setDownloadToFile):
  • src/WebURLRequestPrivate.h: (WebKit::WebURLRequestPrivate::WebURLRequestPrivate):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponsePrivateImpl::WebURLResponsePrivateImpl): (WebKit::WebURLResponse::downloadFilePath): (WebKit::WebURLResponse::setDownloadFilePath):
  • src/WebURLResponsePrivate.h:
5:59 AM Changeset in webkit [79781] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-26 Eric Seidel <eric@webkit.org>

Reviewed by Maciej Stachowiak.

malloc in removeChildren shows up on profile of peacekeeper domDynamicCreationCreateElement
https://bugs.webkit.org/show_bug.cgi?id=55204

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren):
    • Using an inlineCapacity of 10 for now. We may want to tweak it later.
    • This removes yet another malloc from code which removes nodes (which is rather common).
5:47 AM Changeset in webkit [79780] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-26 Eric Seidel <eric@webkit.org>

Reviewed by Maciej Stachowiak.

HashSet<T>::end() creation is expensive and should be avoided
https://bugs.webkit.org/show_bug.cgi?id=55205

In the common case, m_ranges is an empty set. When that's
the case, we spend all our time in skipEmptyBuckets, walking
the hash storage skipping over empty buckets.

This looks to be at least a 5% speedup on (my local version of) peacekeeper's domDynamicCreationCreateElement.

Before:
avg 383.6666666666667
median 386
stdev 7.152311203768722
min 360
max 391

After:
avg 366.3333333333333
median 366
stdev 2.712112747574399
min 362
max 377

  • dom/Document.cpp: (WebCore::Document::nodeChildrenChanged): (WebCore::Document::nodeChildrenWillBeRemoved): (WebCore::Document::nodeWillBeRemoved): (WebCore::Document::textInserted): (WebCore::Document::textRemoved): (WebCore::Document::textNodesMerged): (WebCore::Document::textNodeSplit):
5:15 AM Changeset in webkit [79779] by rniwa@webkit.org
  • 30 edits in trunk

2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
http://trac.webkit.org/changeset/79764
https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::reset):

2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
http://trac.webkit.org/changeset/79764
https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:

2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
http://trac.webkit.org/changeset/79764
https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
http://trac.webkit.org/changeset/79764
https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
http://trac.webkit.org/changeset/79764
https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • Interfaces/IWebFramePrivate.idl:
  • Interfaces/WebKit.idl:
  • WebFrame.cpp:
  • WebFrame.h:

2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
http://trac.webkit.org/changeset/79764
https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • WebView/WebFrame.mm:
  • WebView/WebFramePrivate.h:

2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
http://trac.webkit.org/changeset/79764
https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • WebCore.exp.in:

2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r79764.
http://trac.webkit.org/changeset/79764
https://bugs.webkit.org/show_bug.cgi?id=55295

"broke Chromium builds" (Requested by rniwa on #webkit).

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
5:14 AM Changeset in webkit [79778] by commit-queue@webkit.org
  • 13 edits
    1 copy
    3 adds in trunk

2011-02-26 Adam Klein <adamk@chromium.org>

Reviewed by Adam Barth.

[fileapi] Implement EntrySync.toURI by moving Entry::toURI to EntryBase
https://bugs.webkit.org/show_bug.cgi?id=54585

  • fast/filesystem/resources/file-entry-to-uri-sync.js: Added.
  • fast/filesystem/workers/file-entry-to-uri-sync-expected.txt: Added.
  • fast/filesystem/workers/file-entry-to-uri-sync.html: Added.

2011-02-26 Adam Klein <adamk@chromium.org>

Reviewed by Adam Barth.

[fileapi] Implement EntrySync.toURI by moving Entry::toURI to EntryBase
https://bugs.webkit.org/show_bug.cgi?id=54585

In order to move toURI to EntryBase, it needed access to
SecurityOrigin. Most of the changes below were to pass a
ScriptExecutionContext to DOMFileSystemBase to enable this.

Test: fast/filesystem/workers/file-entry-to-uri-sync.html

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::DOMFileSystem):
  • fileapi/DOMFileSystemBase.cpp: (WebCore::DOMFileSystemBase::DOMFileSystemBase): (WebCore::DOMFileSystemBase::securityOrigin):
  • fileapi/DOMFileSystemBase.h: (WebCore::DOMFileSystemBase::create):
  • fileapi/DOMFileSystemSync.cpp: (WebCore::DOMFileSystemSync::create): (WebCore::DOMFileSystemSync::DOMFileSystemSync):
  • fileapi/DOMFileSystemSync.h: (WebCore::DOMFileSystemSync::create):
  • fileapi/Entry.cpp:
  • fileapi/Entry.h:
  • fileapi/EntryBase.cpp: Added. (WebCore::EntryBase::EntryBase): (WebCore::EntryBase::~EntryBase): (WebCore::EntryBase::toURI):
  • fileapi/EntryBase.h:
  • fileapi/EntrySync.idl:
4:12 AM Changeset in webkit [79777] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-26 Alice Boxhall <aboxhall@chromium.org>

Reviewed by Ojan Vafai.

Tests that typing enter in the input element does not fire textInput.
https://bugs.webkit.org/show_bug.cgi?id=54152

  • fast/forms/textinput-not-fired-on-enter-in-input-expected.txt: Added.
  • fast/forms/textinput-not-fired-on-enter-in-input.html: Added.

2011-02-26 Alice Boxhall <aboxhall@chromium.org>

Reviewed by Ojan Vafai.

typing enter in the input element should not fire textInput
https://bugs.webkit.org/show_bug.cgi?id=54152

Stop textInput event propagation in HTMLInputElement::preDispatchEventHandler if the event target should submit implicitly.

Test: fast/forms/textinput-not-fired-on-enter-in-input.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::preDispatchEventHandler): Check m_inputType->shouldSubmitImplicitly for textInputEvents and stop propagation if true.
4:04 AM Changeset in webkit [79776] by simonjam@chromium.org
  • 4 edits in trunk

2011-02-26 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Gentilcore.

[Web Timing] loadEvent timing should refer to first load event if there are many
https://bugs.webkit.org/show_bug.cgi?id=55201

  • fast/dom/script-tests/webtiming-document-open.js: (testTimingWithDocumentOpen): Fire via setTimeout to match w3c test and reveal loadEventEnd. (finishTest): Fire via setTimeout to match w3c test.

2011-02-26 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Gentilcore.

[Web Timing] loadEvent timing should refer to first load event if there are many
https://bugs.webkit.org/show_bug.cgi?id=55201

Test: fast/dom/webtiming-document-open.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent):
3:20 AM Changeset in webkit [79775] by tonyg@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-02-26 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Fix isLayoutTimerActive for ports that set a minimumLayoutDelay
https://bugs.webkit.org/show_bug.cgi?id=54810

No new tests because no new functionality.

  • dom/Document.cpp: (WebCore::Document::isLayoutTimerActive): Moved from HTMLParserScheduler per FIXME. Compare minimumLayoutDelay() to m_extraLayoutDelay instead of 0. This spirit of this comparison was broken by r52919. The effect would be that ports that set an extra layout delay can't yield between tokens. Note: can't be const because minimumLayoutDelay sets a member.
  • dom/Document.h:
  • html/parser/HTMLParserScheduler.cpp: (WebCore::HTMLParserScheduler::continueNextChunkTimerFired): (WebCore::HTMLParserScheduler::checkForYieldBeforeScript):
2:17 AM Changeset in webkit [79774] by commit-queue@webkit.org
  • 10 edits in trunk/Source

2011-02-26 David Dorwin <ddorwin@chromium.org>

Reviewed by Darin Fisher.

Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default.

fullscreen javascript bindings not implemented for v8
https://bugs.webkit.org/show_bug.cgi?id=44797

Tested by the existing fullscreen Layout Tests.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

2011-02-26 David Dorwin <ddorwin@chromium.org>

Reviewed by Darin Fisher.

Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default.

fullscreen javascript bindings not implemented for v8
https://bugs.webkit.org/show_bug.cgi?id=44797

  • features.gypi:
  • public/WebSettings.h:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::supportsFullScreenForElement): (WebKit::ChromeClientImpl::enterFullScreenForElement): (WebKit::ChromeClientImpl::exitFullScreenForElement): (WebKit::ChromeClientImpl::fullScreenRendererChanged):
  • src/ChromeClientImpl.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setFullScreenEnabled):
  • src/WebSettingsImpl.h:
2:11 AM Changeset in webkit [79773] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-26 Thouraya ANDOLSI <thouraya.andolsi@st.com>

Reviewed by Nikolas Zimmermann.

SH4 JIT SUPPORT
https://bugs.webkit.org/show_bug.cgi?id=44329

Provide an ExecutableAllocater::cacheFlush() implementation for
Linux/SH4.

  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
1:45 AM Changeset in webkit [79772] by tonyg@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-02-26 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Prevent parser yields from triggering early dumpAsText()
https://bugs.webkit.org/show_bug.cgi?id=55187

DRT's dumpAsText() takes a snapshot when DocumentLoader::isLoadingInAPISense()
indicates the page is done. isLoadingInAPISense depends on
HTMLDocumentParser::isProcessingData(), which just checks if the parser is in an
insert() or append().

This means that if the parser is pumping in a resumeParsingAfterScriptExecution() or
resumeParsingAfterYield(), isLoadingInAPISense() may not be blocked. This patch
fixes that by repurposing m_writeNestingLevel as m_pumpSessionNestingLevel and
incrementing it in pumpTokenizer().

When I locally cause the parser to yield after every token, a lot of tests fail
because DRT snapshots too early. This patch fixes those tests, however I'm having
trouble writing a test case that reliably reproduces the problem without this patch
and passes with it (without changing yield constants). This is because it requires
4,096 tokens in a single pump session to yield and (len('<b>' * 4096 = 12k, which
doesn't always happen).

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::~HTMLDocumentParser): (WebCore::HTMLDocumentParser::processingData): (WebCore::HTMLDocumentParser::pumpTokenizer): (WebCore::HTMLDocumentParser::insert): (WebCore::HTMLDocumentParser::append):
  • html/parser/HTMLDocumentParser.h: (WebCore::HTMLDocumentParser::inPumpSession): (WebCore::HTMLDocumentParser::shouldDelayEnd):
  • html/parser/HTMLParserScheduler.h: (WebCore::PumpSession::PumpSession):
  • html/parser/NestingLevelIncrementer.h:
1:32 AM Changeset in webkit [79771] by commit-queue@webkit.org
  • 16 edits
    3 adds in trunk

2011-02-26 Yongjun Zhang <yongjun_zhang@apple.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=48781

Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.

  • fast/images/resources/broken-image-with-invalid-format.png: Added.
  • fast/images/support-broken-image-delegate.html: Added.
  • platform/mac/fast/images/support-broken-image-delegate-expected.txt: Added.

2011-02-26 Yongjun Zhang <yongjun_zhang@apple.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=48781

Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.

Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore
should paint the default broken image when an image fails to load or decode. The method also passes the
URL of the failed image.

Test: fast/images/support-broken-image-delegate.html

  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::shouldPaintBrokenImage):
  • loader/cache/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::image): (WebCore::CachedImage::checkShouldPaintBrokenImage): (WebCore::CachedImage::error):
  • loader/cache/CachedImage.h:

2011-02-26 Yongjun Zhang <yongjun_zhang@apple.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=48781

Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.

Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore
should paint the default broken image when an image fails to load or decode. The method also passes the
URL of the failed image.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::shouldPaintBrokenImage):
  • WebView/WebDelegateImplementationCaching.h:
  • WebView/WebDelegateImplementationCaching.mm: Added case for passing one object. (CallResourceLoadDelegateReturningBoolean):
  • WebView/WebResourceLoadDelegatePrivate.h:
  • WebView/WebView.mm: (-[WebView _cacheResourceLoadDelegateImplementations]):

2011-02-26 Yongjun Zhang <yongjun_zhang@apple.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=48781

Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.

Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore
should paint the default broken image when an image fails to load or decode.

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (setShouldPaintBrokenImageCallback): (LayoutTestController::staticFunctions): (LayoutTestController::setShouldPaintBrokenImage):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::shouldPaintBrokenImage):
  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:shouldPaintBrokenImageForURL:]):
1:24 AM Changeset in webkit [79770] by eric@webkit.org
  • 1 edit
    9 deletes in trunk/LayoutTests

2011-02-26 Eric Seidel <eric@webkit.org>

Reviewed by Alexey Proskuryakov.

Remove disabled xmlhttprequest/web-apps tests
https://bugs.webkit.org/show_bug.cgi?id=55181

Per ap's suggestion in:
https://bugs.webkit.org/show_bug.cgi?id=55164#c15

I don't think we've ever run these tests. Some of them
depend on 10 minute timeouts and another nonsense. :)

  • http/tests/xmlhttprequest/web-apps/006-test.cgi: Removed.
  • http/tests/xmlhttprequest/web-apps/006.html-disabled: Removed.
  • http/tests/xmlhttprequest/web-apps/009-test.cgi: Removed.
  • http/tests/xmlhttprequest/web-apps/009.html-disabled: Removed.
  • http/tests/xmlhttprequest/web-apps/016-test.cgi: Removed.
  • http/tests/xmlhttprequest/web-apps/016.html-disabled: Removed.
  • http/tests/xmlhttprequest/web-apps/017.html-disabled: Removed.
  • http/tests/xmlhttprequest/web-apps/recursion/001.html-disabled: Removed.
  • http/tests/xmlhttprequest/web-apps/recursion/README: Removed.
1:16 AM Changeset in webkit [79769] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-26 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Database: Data race: should only touch the transaction queue inside the
lock.
https://bugs.webkit.org/show_bug.cgi?id=55031

  • storage/Database.cpp: (WebCore::Database::changeVersion): only touch queue inside lock. (WebCore::Database::runTransaction): only touch queue inside lock.
1:03 AM Changeset in webkit [79768] by yi.4.shen@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-26 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Eric Carlson.

Missing volumechangeEvent in case of mediaPlayerVolumeChanged gets callback
https://bugs.webkit.org/show_bug.cgi?id=55147

When HTMLMediaElement::mediaPlayerVolumeChanged() gets callback,
a volumechangeEvent event should be fired if the volume gets changed.

Test: media/event-attributes.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setMuted): Remove updateVolume() since it does nothing when m_player is 0. (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): Fire a volumechangeEvent when the volume is changed.
12:59 AM Changeset in webkit [79767] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-26 John Mellor <johnme@chromium.org>

Reviewed by Antonio Gomes.

[chromium] WebFrameImpl::m_totalMatchCount should be an int
https://bugs.webkit.org/show_bug.cgi?id=55134

WebFrameImpl::m_totalMatchCount should be an int instead of a size_t since it can be -1.

  • src/WebFrameImpl.h:
12:41 AM Changeset in webkit [79766] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-26 Eric Seidel <eric@webkit.org>

Reviewed by Maciej Stachowiak.

disableRangeMutation quirk for mail slows down peacekeeper domDynamicCreationCreateElement
https://bugs.webkit.org/show_bug.cgi?id=55127

Before:
avg 513.4
median 515
stdev 7.234638899074368
min 490
max 528

After:
avg 508.15
median 510
stdev 6.966168243733426
min 485
max 515

Yes, the stdev is a bit high to actually support my conclusions. But looking
at the profile, this change makes a lot of sense. I'll up the iterations
for future testing.

  • dom/Document.cpp: (WebCore::disableRangeMutation):
    • This check should only be compiled in if we're planning to run on Tiger or Leopard.
12:35 AM Changeset in webkit [79765] by abarth@webkit.org
  • 11 edits
    5 adds in trunk/LayoutTests

2011-02-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Synchronized tests with html5lib
https://bugs.webkit.org/show_bug.cgi?id=55128

I didn't copy all of plain-test-unsafe because it confuses pretty-diff.

  • html5lib/resources/pending-spec-changes-plain-text-unsafe.dat:
  • html5lib/resources/pending-spec-changes.dat:
  • html5lib/resources/tests1.dat:
  • html5lib/resources/tests10.dat:
  • html5lib/resources/tests19.dat:
  • html5lib/resources/tests20.dat:
  • html5lib/resources/tests22.dat: Added.
  • html5lib/resources/tests23.dat: Added.
  • html5lib/resources/tests24.dat: Added.
  • html5lib/resources/tests25.dat: Added.
  • html5lib/resources/tests26.dat: Added.
  • html5lib/resources/tests3.dat:
  • html5lib/resources/tests6.dat:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:
12:16 AM Changeset in webkit [79764] by commit-queue@webkit.org
  • 30 edits in trunk

2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

No new tests. (no code affected, just exporting a method for DumpRenderTree use)

  • WebCore.exp.in:

2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WebFrame.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::clearOpener):
  • src/WebFrameImpl.h:

2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to DumpRenderTreeSupportGTK.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::clearOpener):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WebFramePrivate.

  • WebView/WebFrame.mm: (-[WebFrame _clearOpener]):
  • WebView/WebFramePrivate.h:

2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to DumpRenderTreeSupportQT.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::clearOpener):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to IWebFramePrivate.
Touched WebKit.idl to trigger build scripts.

  • Interfaces/IWebFramePrivate.idl:
  • Interfaces/WebKit.idl:
  • WebFrame.cpp: (WebFrame::clearOpener):
  • WebFrame.h:

2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WKBundleWebFramePrivate.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameClearOpener):
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:

2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Pavel Feldman.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener() calls between tests.
Some tests are using window.open() to change current window location.
This changes window.opener property whose nullity is checked before
showing xml viewer.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::reset):
12:13 AM Changeset in webkit [79763] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-02-26 Xianzhu Wang <wangxianzhu@google.com>

Reviewed by Eric Seidel.

Fix Chromium test failure http://crbug.com/33358
https://bugs.webkit.org/show_bug.cgi?id=55125

  • platform/chromium/test_expectations.txt:
  • platform/chromium/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added.
12:12 AM Changeset in webkit [79762] by chang.shu@nokia.com
  • 7 edits
    2 adds in trunk

2011-02-26 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Spatial Navigation: Add support for <select> element in multiple selection mode
https://bugs.webkit.org/show_bug.cgi?id=49261

Enhanced existing tests and added new tests for the bug.

  • fast/spatial-navigation/snav-multiple-select-expected.txt:
  • fast/spatial-navigation/snav-multiple-select.html:
  • fast/spatial-navigation/snav-single-select-list-expected.txt: Added.
  • fast/spatial-navigation/snav-single-select-list.html: Added.

2011-02-26 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Based on patch by Carlos Garcia Campos <cgarcia@igalia.com>.

Spatial Navigation: Add support for <select> element in multiple selection mode
https://bugs.webkit.org/show_bug.cgi?id=49261

When spatial navigation is enabled, use space key to toggle select
items. And the up and down keys should not affect selection but just
navigate through items, which is indicated visually by a focus ring.

New Test: fast/spatial-navigation/snav-single-select-list.html
Enhanced Test: fast/spatial-navigation/snav-multiple-select.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::listBoxDefaultEventHandler):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::addFocusRingRects):
  • rendering/RenderListBox.h:

Feb 25, 2011:

11:55 PM Changeset in webkit [79761] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-02-25 Lukasz Slachciak <l.slachciak@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Added EWebLauncher command line option to turn on/off frame flattening
https://bugs.webkit.org/show_bug.cgi?id=54809

  • EWebLauncher/main.c: Handling -f option added. (on_key_down): (browserCreate): (main):
11:33 PM Changeset in webkit [79760] by eric@webkit.org
  • 6 edits in trunk/LayoutTests

2011-02-25 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Make positioned elements work with vertical text
https://bugs.webkit.org/show_bug.cgi?id=46500

Rebaseline fast/table/fixed-with-auto-with-colspan-vertical.html for r79725.

  • platform/gtk/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
  • platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.checksum:
  • platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.png:
  • platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
  • platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
9:35 PM Changeset in webkit [79759] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-25 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Qt build fix; included CSSValueList.h in EditingStyle.cpp.

  • editing/EditingStyle.cpp:
9:26 PM Changeset in webkit [79758] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-02-25 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Move HTMLEquivalent and its subclasses to EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55207

Moved HTMLEquivalent and its subclasses from ApplyStyleCommand to EditingStyle,
and renamed HTMLEquivalent, HTMLEquivalentValueList, HTMLAttributeEquivalent,
and HTMLEquivalentFontSizeAttribute to HTMLElementEquivalent, HTMLTextDecorationEquivalent,
HTMLAttributeEquivalent, and HTMLFontSizeEquivalent respectively.

Also extracted the logic to determine which element and attribute are removed
as conflictsWithImplicitStyleOfElement, conflictsWithImplicitStyleOfAttributes,
and extractConflictingImplicitStyleOfAttributes.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
  • editing/ApplyStyleCommand.h:
  • editing/EditingStyle.cpp: (WebCore::HTMLElementEquivalent::create): Moved from ApplyStyleCommand.cpp. (WebCore::HTMLElementEquivalent::~HTMLElementEquivalent): Ditto. (WebCore::HTMLElementEquivalent::matches): Ditto. (WebCore::HTMLElementEquivalent::hasAttribute): Ditto. (WebCore::HTMLElementEquivalent::propertyExistsInStyle): Ditto. (WebCore::HTMLElementEquivalent::HTMLElementEquivalent): Ditto. (WebCore::HTMLElementEquivalent::valueIsPresentInStyle): Ditto. (WebCore::HTMLElementEquivalent::addToStyle): Ditto. (WebCore::HTMLTextDecorationEquivalent::create): Ditto. (WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent): Ditto. (WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle): Ditto. (WebCore::HTMLAttributeEquivalent::create): Ditto. (WebCore::HTMLAttributeEquivalent::matches): Ditto. (WebCore::HTMLAttributeEquivalent::hasAttribute): Ditto. (WebCore::HTMLAttributeEquivalent::attributeName): Ditto. (WebCore::HTMLAttributeEquivalent::HTMLAttributeEquivalent): Ditto. (WebCore::HTMLAttributeEquivalent::valueIsPresentInStyle): Ditto. (WebCore::HTMLAttributeEquivalent::addToStyle): Ditto. (WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue): Ditto. (WebCore::HTMLFontSizeEquivalent::create): Ditto. (WebCore::HTMLFontSizeEquivalent::HTMLFontSizeEquivalent): Ditto. (WebCore::HTMLFontSizeEquivalent::attributeValueAsCSSValue): Ditto. (WebCore::EditingStyle::conflictsWithImplicitStyleOfElement): Added. (WebCore::htmlAttributeEquivalents): Added. (WebCore::EditingStyle::conflictsWithImplicitStyleOfAttributes): Added. (WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes): Added.
  • editing/EditingStyle.h:
6:49 PM Changeset in webkit [79757] by jamesr@google.com
  • 2 edits
    21 adds in trunk/LayoutTests

2011-02-25 James Robinson <jamesr@chromium.org>

Update chromium expectations and add new chromium and mac-leopard baselines for new tests.

  • platform/chromium-linux/fast/block/positioning/differing-writing-modes-expected.checksum: Added.
  • platform/chromium-linux/fast/block/positioning/differing-writing-modes-expected.png: Added.
  • platform/chromium-linux/fast/block/positioning/differing-writing-modes-replaced-expected.checksum: Added.
  • platform/chromium-linux/fast/block/positioning/differing-writing-modes-replaced-expected.png: Added.
  • platform/chromium-linux/fast/table/table-continuation-outline-paint-crash-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-continuation-outline-paint-crash-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/differing-writing-modes-expected.checksum: Added.
  • platform/chromium-win/fast/block/positioning/differing-writing-modes-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/differing-writing-modes-expected.txt: Added.
  • platform/chromium-win/fast/block/positioning/differing-writing-modes-replaced-expected.checksum: Added.
  • platform/chromium-win/fast/block/positioning/differing-writing-modes-replaced-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/differing-writing-modes-replaced-expected.txt: Added.
  • platform/chromium-win/fast/table/table-continuation-outline-paint-crash-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-continuation-outline-paint-crash-expected.png: Added.
  • platform/chromium-win/fast/table/table-continuation-outline-paint-crash-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/block/positioning/differing-writing-modes-expected.checksum: Added.
  • platform/mac-leopard/fast/block/positioning/differing-writing-modes-expected.png: Added.
  • platform/mac-leopard/fast/block/positioning/differing-writing-modes-replaced-expected.checksum: Added.
  • platform/mac-leopard/fast/block/positioning/differing-writing-modes-replaced-expected.png: Added.
  • platform/mac-leopard/fast/table/table-continuation-outline-paint-crash-expected.checksum: Added.
  • platform/mac-leopard/fast/table/table-continuation-outline-paint-crash-expected.png: Added.
6:45 PM Changeset in webkit [79756] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

6:18 PM Changeset in webkit [79755] by mrowe@apple.com
  • 1 copy in tags/Safari-534.22

New tag.

6:18 PM Changeset in webkit [79754] by mihaip@chromium.org
  • 79 edits in trunk/LayoutTests

2011-02-25 Mihai Parparita <mihaip@chromium.org>

Unreviewed rebaseline.

Update mac/ pixel baselines for Snow Leopard (new results match
chromium-mac and/or chromium-mac-leopard ones, which are known to be
good).

  • platform/mac/fast/backgrounds/svg-as-background-5-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-5-expected.png:
  • platform/mac/fast/block/margin-collapse/103-expected.checksum:
  • platform/mac/fast/block/margin-collapse/103-expected.png:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
  • platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
  • platform/mac/fast/css/empty-pseudo-class-expected.checksum:
  • platform/mac/fast/css/empty-pseudo-class-expected.png:
  • platform/mac/fast/css/first-child-pseudo-class-expected.checksum:
  • platform/mac/fast/css/first-child-pseudo-class-expected.png:
  • platform/mac/fast/css/first-of-type-pseudo-class-expected.checksum:
  • platform/mac/fast/css/first-of-type-pseudo-class-expected.png:
  • platform/mac/fast/css/font-face-default-font-expected.checksum:
  • platform/mac/fast/css/font-face-default-font-expected.png:
  • platform/mac/fast/css/font_property_normal-expected.checksum:
  • platform/mac/fast/css/font_property_normal-expected.png:
  • platform/mac/fast/css/last-child-pseudo-class-expected.checksum:
  • platform/mac/fast/css/last-child-pseudo-class-expected.png:
  • platform/mac/fast/css/last-of-type-pseudo-class-expected.checksum:
  • platform/mac/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/mac/fast/css/line-height-font-order-expected.checksum:
  • platform/mac/fast/css/line-height-font-order-expected.png:
  • platform/mac/fast/css/only-child-pseudo-class-expected.checksum:
  • platform/mac/fast/css/only-child-pseudo-class-expected.png:
  • platform/mac/fast/css/only-of-type-pseudo-class-expected.checksum:
  • platform/mac/fast/css/only-of-type-pseudo-class-expected.png:
  • platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.checksum:
  • platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
  • platform/mac/fast/dynamic/008-expected.checksum:
  • platform/mac/fast/dynamic/008-expected.png:
  • platform/mac/fast/events/context-no-deselect-expected.checksum:
  • platform/mac/fast/events/context-no-deselect-expected.png:
  • platform/mac/fast/forms/placeholder-position-expected.checksum:
  • platform/mac/fast/forms/placeholder-position-expected.png:
  • platform/mac/fast/html/keygen-expected.checksum:
  • platform/mac/fast/html/keygen-expected.png:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.checksum:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.png:
  • platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum:
  • platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/mac/fast/selectors/166-expected.checksum:
  • platform/mac/fast/selectors/166-expected.png:
  • platform/mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum:
  • platform/mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.png:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
  • platform/mac/fonts/sans-serif-expected.checksum:
  • platform/mac/fonts/sans-serif-expected.png:
  • platform/mac/svg/custom/text-dom-01-f-expected.checksum:
  • platform/mac/svg/custom/text-dom-01-f-expected.png:
  • platform/mac/tables/mozilla/bugs/bug113235-1-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug113235-1-expected.png:
  • platform/mac/tables/mozilla/bugs/bug113424-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug113424-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/mac/tables/mozilla/bugs/bug16012-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug16012-expected.png:
  • platform/mac/tables/mozilla/bugs/bug2479-2-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/mac/tables/mozilla/bugs/bug8858-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug8858-expected.png:
  • platform/mac/tables/mozilla/core/bloomberg-expected.checksum:
  • platform/mac/tables/mozilla/core/bloomberg-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.checksum:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
5:46 PM Changeset in webkit [79753] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: Add Xcode entries back to the navigator list for Accessibility cpp files
https://bugs.webkit.org/show_bug.cgi?id=55280

Reviewed by Anders Carlsson.

  • WebCore.xcodeproj/project.pbxproj:
5:46 PM Changeset in webkit [79752] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-25 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Plug-in process crashes when using GuardMalloc
https://bugs.webkit.org/show_bug.cgi?id=55279
<rdar://problem/9044618>

Update m_environmentPointer after copying the environment variables.


  • UIProcess/Launcher/mac/ProcessLauncherMac.mm: (WebKit::EnvironmentVariables::copyEnvironmentVariables):
5:40 PM Changeset in webkit [79751] by bweinstein@apple.com
  • 3 edits in trunk/WebKitLibraries

Fix linking of Chromium Mac build.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
5:34 PM Changeset in webkit [79750] by commit-queue@webkit.org
  • 9 edits in trunk/Source/JavaScriptCore

2011-02-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r79627.
http://trac.webkit.org/changeset/79627
https://bugs.webkit.org/show_bug.cgi?id=55274

broke worker tests (Requested by olliej on #webkit).

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/Heap.cpp: (JSC::Heap::allocate):
  • runtime/Heap.h:
  • runtime/JSCell.h: (JSC::JSCell::JSCell::operator new): (JSC::JSCell::MarkedSpace::sizeClassFor): (JSC::JSCell::MarkedSpace::allocate):
  • runtime/MarkedBlock.h:
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::allocateBlock): (JSC::MarkedSpace::reset):
  • runtime/MarkedSpace.h: (JSC::MarkedSpace::SizeClass::SizeClass):
5:27 PM Changeset in webkit [79749] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-25 Michael Saboff <msaboff@apple.com>

Reviewed by Darin Adler.

Leak in JSParser::Scope of ScopeLabelInfo Vector
https://bugs.webkit.org/show_bug.cgi?id=55249

Changed m_labels to be an OwnPtr<>. Added VectorTraits
and Scope copy constructor to support this change.

  • parser/JSParser.cpp: (JSC::JSParser::Scope::~Scope):
5:18 PM Changeset in webkit [79748] by Darin Adler
  • 2 edits in trunk/Source/WebKit2
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess): Fixed backwards logic from last change.

5:10 PM Changeset in webkit [79747] by Darin Adler
  • 2 edits in trunk/Source/WebKit2
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess): Fixed performance problem in production
builds by only setting DYLD_FRAMEWORK_PATH in engineering configurations.

Reviewed by Mark Rowe.

4:47 PM Changeset in webkit [79746] by Darin Adler
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/8036034> WebKit2 should work even if DYLD_FRAMEWORK_PATH is not set

Reviewed by Anders Carlsson.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::EnvironmentVariables::~EnvironmentVariables): Use fastFree, not delete, on
the strings here because they are allocated with fastMalloc, not new.
(WebKit::EnvironmentVariables::set): Use const more.
(WebKit::EnvironmentVariables::get): Ditto.
(WebKit::EnvironmentVariables::appendValue): Ditto.
(WebKit::EnvironmentVariables::valueIfVariableHasName): Ditto. Also fix mistake
where this would match if the name matched only a prefix of the environment variable's
name. We want to match the whole name, so we need to use memcmp, not strncmp.
(WebKit::EnvironmentVariables::createStringForVariable): Use const more.
(WebKit::ProcessLauncher::launchProcess): Use clearer name, frameworkExecutablePath,
for what was called bundlePath before. Append the frameworks path to DYLD_FRAMEWORK_PATH,
ensuring we can pick up other frameworks from the same directory in the web process.
Use a const_cast instead of a C-style cast.

4:46 PM Changeset in webkit [79745] by abarth@webkit.org
  • 4 edits in trunk/Source

2011-02-25 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Adam Barth.

WebSocket uses insecure random numbers
https://bugs.webkit.org/show_bug.cgi?id=54714

2011-02-25 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Adam Barth.

WebSocket uses insecure random numbers
https://bugs.webkit.org/show_bug.cgi?id=54714

  • websockets/WebSocketHandshake.cpp: (WebCore::randomNumberLessThan): (WebCore::generateSecWebSocketKey): (WebCore::generateKey3):
4:37 PM Changeset in webkit [79744] by eric.carlson@apple.com
  • 6 edits in trunk/Source/WebCore

2011-02-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Add API to enumerate/delete files downloaded for <audio> and <video>
https://bugs.webkit.org/show_bug.cgi?id=55267

Add review changes missed in r79737.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::clearMediaCacheForSite): Pass string by reference.
  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::clearMediaCacheForSite): Ditto.
4:31 PM Changeset in webkit [79743] by Chris Fleizach
  • 2 edits in trunk/Source/WebKit2

AX: WK2: AXApplication not returning the AXFocusedUIElement within the web area
https://bugs.webkit.org/show_bug.cgi?id=55277

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView accessibilityFocusedUIElement]):

4:25 PM Changeset in webkit [79742] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=55276
WebPage::close() accesses "this" after it is destroyed.

This was making many tests crash with GuardMalloc.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::close): Access "this" before it can be destroyed, not after.
4:02 PM Changeset in webkit [79741] by mrobinson@webkit.org
  • 1 edit
    234 adds in trunk/LayoutTests

2011-02-25 Martin Robinson <mrobinson@igalia.com>

Add the final set of missing GTK+ SVG pixel results.

  • platform/gtk/svg/dynamic-updates: Add missing results.
4:00 PM Changeset in webkit [79740] by mrobinson@webkit.org
  • 1 edit
    202 adds in trunk/LayoutTests

2011-02-25 Martin Robinson <mrobinson@igalia.com>

Add another set of missing GTK+ SVG pixel results.

  • platform/gtk/svg/dynamic-updates: Add missing pixel results.
3:58 PM Changeset in webkit [79739] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed.
Add missing sources to WebKit2API.pri.

  • WebKit2API.pri:
3:58 PM Changeset in webkit [79738] by mrobinson@webkit.org
  • 1 edit
    202 adds in trunk/LayoutTests

2011-02-25 Martin Robinson <mrobinson@igalia.com>

Add the next set of missing GTK+ SVG pixel results.

  • platform/gtk/svg/dom/SVGRectElement: Add missing pixel reults.
  • platform/gtk/svg/dynamic-updates: Ditto.
3:55 PM Changeset in webkit [79737] by eric.carlson@apple.com
  • 6 edits in trunk/Source/WebCore

2011-02-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Add API to enumerate/delete files downloaded for <audio> and <video>
https://bugs.webkit.org/show_bug.cgi?id=55267
<rdar://problem/9049280>

No new tests, this is just the plumbing.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::getSitesInMediaCache): New, call through to MediaPlayer. (WebCore::HTMLMediaElement::clearMediaCache): Ditto. (WebCore::HTMLMediaElement::clearMediaCacheForSite): Ditto.
  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::getSitesInMediaCache): New, call through to media engine. (WebCore::MediaPlayer::clearMediaCache): Ditto. (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::getSitesInMediaCache): Declare new interface. (WebCore::MediaPlayerPrivateInterface::clearMediaCache): Ditto. (WebCore::MediaPlayerPrivateInterface::clearMediaCacheForSite): Ditto.
3:55 PM Changeset in webkit [79736] by mrobinson@webkit.org
  • 1 edit
    330 adds in trunk/LayoutTests

2011-02-25 Martin Robinson <mrobinson@igalia.com>

Add some missing GTK+ SVG pixel results.

  • platform/gtk/svg: Add missing GTK+ SVG pixel results.
3:49 PM Changeset in webkit [79735] by mrobinson@webkit.org
  • 43 edits in trunk/LayoutTests

2011-02-25 Martin Robinson <mrobinson@igalia.com>

Update GTK+ SVG pixel results which have changed.

  • platform/gtk/svg: Update SVG pixel resultsj
3:18 PM Changeset in webkit [79734] by inferno@chromium.org
  • 6 edits
    4 adds in trunk

2011-02-25 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Don't add inline continuation outline to the containing block's
continuationOutlineTable list if it is not enclosed by an anonymous block.
https://bugs.webkit.org/show_bug.cgi?id=54690

We currently don't reconnect inline continuations after a child removal.
As a result, those merged inlines do not get seperated and hence not get enclosed
by anonymous blocks. In this case, it is better to bail out and paint it ourself.

Test: fast/table/table-continuation-outline-paint-crash.html

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintsContinuationOutline): helper function to tell if this containing block has the continuation flow in its continuations list.
  • rendering/RenderBlock.h: helper function definition.
  • rendering/RenderInline.cpp: (WebCore::RenderInline::destroy): debug only code that asserts if we leave behind a continuation in the containing block's continuation list when it is getting destroyed.

2011-02-25 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Ensure that we do not add the inline continuation flow to the table's continuation
table map for painting. The layout test should not crash on assert and should show
a solid outline around the inline child.
https://bugs.webkit.org/show_bug.cgi?id=54690

  • fast/table/table-continuation-outline-paint-crash.html: Added.
  • platform/mac/fast/table/table-continuation-outline-paint-crash-expected.checksum: Added.
  • platform/mac/fast/table/table-continuation-outline-paint-crash-expected.png: Added.
  • platform/mac/fast/table/table-continuation-outline-paint-crash-expected.txt: Added.
2:43 PM Changeset in webkit [79733] by hyatt@apple.com
  • 7 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=55265, remove the unused "Static" type
from Length.

Reviewed by Adam Roben.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • platform/Length.h:

(WebCore::Length::isFixed):

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::layout):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::isLogicalWidthSpecified):
(WebCore::RenderImage::isLogicalHeightSpecified):

  • rendering/RenderObject.h:

(WebCore::RenderObject::markContainingBlocksForLayout):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hasStaticX):
(WebCore::InheritedFlags::hasStaticY):

2:36 PM Changeset in webkit [79732] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-25 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

A WKView without a window will cause CG errors in the console
https://bugs.webkit.org/show_bug.cgi?id=55264
<rdar://problem/9044281>

Check that the window has a valid window number before trying to get its graphics context.

  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::containingWindowGraphicsContext):
2:35 PM Changeset in webkit [79731] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-02-25 James Robinson <jamesr@chromium.org>

Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
2:28 PM Changeset in webkit [79730] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-02-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r79324.
http://trac.webkit.org/changeset/79324
https://bugs.webkit.org/show_bug.cgi?id=55260

Leopard Debug is once again running out of address space while
linking (Requested by aroben on #webkit).

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2:20 PM Changeset in webkit [79729] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebCore

Windows build fix.

  • platform/network/cf/CookieJarCFNet.cpp:

(WebCore::getHostnamesWithCookies): Add a const_cast.
(WebCore::deleteCookiesForHostname): Ditto.

2:14 PM Changeset in webkit [79728] by mihaip@chromium.org
  • 18 edits
    9 moves
    30 deletes in trunk/LayoutTests

2011-02-25 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Fix 16 tests for Chromium Snow Leopard by promoting chromium-mac-leopard
results to mac-leopard and removing outdated chromium-mac and
chromium-mac-snowleopard ones.

  • platform/chromium-mac-leopard/svg/batik/masking/maskRegions-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/batik/masking/maskRegions-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/batik/masking/maskRegions-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/custom/absolute-sized-content-with-resources-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/custom/absolute-sized-content-with-resources-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/junk-data-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/custom/junk-data-expected.checksum.
  • platform/chromium-mac-leopard/svg/custom/junk-data-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/junk-data-expected.png.
  • platform/chromium-mac-leopard/svg/custom/junk-data-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/custom/junk-data-expected.txt.
  • platform/chromium-mac-leopard/svg/custom/missing-xlink-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/custom/missing-xlink-expected.checksum.
  • platform/chromium-mac-leopard/svg/custom/missing-xlink-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/missing-xlink-expected.png.
  • platform/chromium-mac-leopard/svg/custom/missing-xlink-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/custom/missing-xlink-expected.txt.
  • platform/chromium-mac-leopard/svg/custom/viewBox-hit-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/custom/viewBox-hit-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/filters/filterRes-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/filters/filterRes-expected.checksum.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.checksum: Removed.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.png: Removed.
  • platform/chromium-mac/fast/text/justify-ideograph-simple-expected.checksum:
  • platform/chromium-mac/fast/text/justify-ideograph-simple-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Removed.
  • platform/chromium-mac/svg/batik/masking/maskRegions-expected.checksum: Removed.
  • platform/chromium-mac/svg/batik/masking/maskRegions-expected.png: Removed.
  • platform/chromium-mac/svg/css/text-gradient-shadow-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/absolute-sized-content-with-resources-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/absolute-sized-content-with-resources-expected.png: Removed.
  • platform/chromium-mac/svg/custom/viewBox-hit-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/viewBox-hit-expected.png: Removed.
  • platform/chromium-mac/svg/filters/feComposite-expected.checksum: Removed.
  • platform/chromium-mac/svg/filters/feComposite-expected.png: Removed.
  • platform/chromium-mac/svg/hixie/perf/007-expected.checksum: Removed.
  • platform/chromium-mac/svg/hixie/perf/007-expected.png: Removed.
  • platform/chromium-mac/svg/repaint/filter-repaint-expected.checksum: Removed.
  • platform/chromium-mac/svg/repaint/filter-repaint-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug23235-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug23235-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/x_thead_align_justify-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/marvin/x_thead_align_justify-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/97619-expected.checksum: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
  • platform/mac-leopard/svg/batik/masking/maskRegions-expected.checksum:
  • platform/mac-leopard/svg/batik/masking/maskRegions-expected.png:
  • platform/mac-leopard/svg/batik/masking/maskRegions-expected.txt: Removed.
  • platform/mac-leopard/svg/custom/absolute-sized-content-with-resources-expected.checksum:
  • platform/mac-leopard/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/mac-leopard/svg/custom/viewBox-hit-expected.checksum:
  • platform/mac-leopard/svg/custom/viewBox-hit-expected.png:
  • platform/mac-leopard/tables/mozilla/bugs/bug23235-expected.checksum:
  • platform/mac-leopard/tables/mozilla/bugs/bug23235-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/mac-leopard/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
  • platform/mac-leopard/tables/mozilla_expected_failures/bugs/97619-expected.png:
2:01 PM Changeset in webkit [79727] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-25 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Empty Elements panel after closing and reopening Inspector
https://bugs.webkit.org/show_bug.cgi?id=55248

Fixing regression real quick. Test to follow.

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::reset):
1:58 PM Changeset in webkit [79726] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-25 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: added missing handle scope into V8InjectedScriptHostCustom.
https://bugs.webkit.org/show_bug.cgi?id=55256

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::nodeAsScriptValue): (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
1:45 PM Changeset in webkit [79725] by hyatt@apple.com
  • 3 edits
    8 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Sam Weinig.

Make positioned objects work with all possible crazy combinations of mixed writing modes. Added new helper
functions that flip around the padding box of the containing block and then add in the appropriate border
side to ensure that the offset of the positioned object is actually correctly placed in the containing block's
local coordinate space.

Added two new tests of both replaced and non-replaced positioned elements in mixed writing mode environments.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::computeLogicalLeftPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::computeLogicalTopPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

LayoutTests:

  • fast/block/positioning/differing-writing-modes-replaced.html: Added.
  • fast/block/positioning/differing-writing-modes.html: Added.
  • platform/mac/fast/block/positioning/differing-writing-modes-expected.checksum: Added.
  • platform/mac/fast/block/positioning/differing-writing-modes-expected.png: Added.
  • platform/mac/fast/block/positioning/differing-writing-modes-expected.txt: Added.
  • platform/mac/fast/block/positioning/differing-writing-modes-replaced-expected.checksum: Added.
  • platform/mac/fast/block/positioning/differing-writing-modes-replaced-expected.png: Added.
  • platform/mac/fast/block/positioning/differing-writing-modes-replaced-expected.txt: Added.
1:45 PM Changeset in webkit [79724] by tony@chromium.org
  • 2 edits
    2 adds in trunk/Tools

2011-02-25 Tony Chang <tony@chromium.org>

Reviewed by James Robinson.

Clean up temp files left by crashing DRTs on chromium-win
https://bugs.webkit.org/show_bug.cgi?id=55182

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • BuildSlaveSupport/chromium/remove-crash-logs: Added.
1:39 PM Changeset in webkit [79723] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Windows 7 Release Tests] http/tests/xmlhttprequest/basic-auth-nouser.html and
basic-auth-nopassword.html failing since introduction in r74609
https://bugs.webkit.org/show_bug.cgi?id=51596

Unreviewed. Adding http/tests/xmlhttprequest/basic-auth-nopassword.html to the Skipped list
because it is consistently timing out on the Windows XP Debug bot.

  • platform/win-xp/Skipped:
1:22 PM Changeset in webkit [79722] by bweinstein@apple.com
  • 15 edits in trunk/Source

WebKit2: Need a way to manage cookies from the web process
https://bugs.webkit.org/show_bug.cgi?id=55086

Reviewed by Brady Eidson and looked over by Jessie Berlin.

Source/WebCore:

Implement the functions needed to manage cookies in CookieJar (getHostnamesWithCookies,
deleteCookiesWithHostname, and deleteAllCookies) for Mac and CFNetwork (stub out the rest),
and call them from WebKit2's WebCookieManager.

No change in behavior needing tests.

  • WebCore.exp.in: Added needed functions to export.
  • platform/CookieJar.h:
  • platform/mac/CookieJar.mm:

(WebCore::getHostnamesWithCookies): Gets all hostnames with cookies from NSHTTPCookieStorage.
(WebCore::deleteCookiesForHostname): Deletes all cookies with a given hostname from

NSHTTPCookieStorage.

(WebCore::deleteAllCookies): Deletes all cookies from NSHTTPCookieStorage.

  • platform/network/cf/CookieJarCFNet.cpp:

(WebCore::getHostnamesWithCookies): Implement using CFNetwork cookie APIs.
(WebCore::deleteCookiesForHostname): Ditto.
(WebCore::deleteAllCookies): Ditto.

  • platform/efl/CookieJarEfl.cpp: Added stub functions.
  • platform/haiku/CookieJarHaiku.cpp: Ditto.
  • platform/network/android/CookieJarAndroid.cpp: Ditto.
  • platform/network/chromium/CookieJarChromium.cpp: Ditto.
  • platform/network/curl/CookieJarCurl.cpp: Ditto.
  • platform/network/soup/CookieJarSoup.cpp: Ditto.
  • platform/network/win/CookieJarWin.cpp: Ditto.
  • platform/qt/CookieJarQt.cpp: Ditto.

Source/WebKit2:

Call through to WebCore::CookieJar in our WebCookieManager functions.

  • WebProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::getHostnamesWithCookies):
(WebKit::WebCookieManager::deleteCookiesForHostname):
(WebKit::WebCookieManager::deleteAllCookies):

1:21 PM Changeset in webkit [79721] by mihaip@chromium.org
  • 10 edits
    12 moves
    20 deletes in trunk/LayoutTests

2011-02-25 Mihai Parparita <mihaip@chromium.org>

Fix 10 tests for Chromium Snow Leopard by promoting chromium-mac-leopard
results to mac-leopard and removing outdated chromium-mac and
chromium-mac-snowleopard ones.

  • platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/select-baseline-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/forms/select-baseline-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/atsui-negative-spacing-features-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/atsui-negative-spacing-features-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/atsui-spacing-features-expected.checksum: Removed.
  • platform/chromium-mac-snowleopard/fast/text/atsui-spacing-features-expected.png: Removed.
  • platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.checksum: Removed.
  • platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.png: Removed.
  • platform/chromium-mac/fast/forms/select-baseline-expected.checksum: Removed.
  • platform/chromium-mac/fast/forms/select-baseline-expected.png: Removed.
  • platform/chromium-mac/fast/forms/text-style-color-expected.checksum: Removed.
  • platform/chromium-mac/fast/forms/text-style-color-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/shadow-breaking-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/shadow-breaking-expected.png: Removed.
  • platform/chromium-mac/fast/table/028-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/table/028-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/text/complex-text-opacity-expected.checksum: Removed.
  • platform/chromium-mac/fast/text/complex-text-opacity-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum:
  • platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png:
  • platform/mac-leopard/fast/dom/isindex-002-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/dom/isindex-002-expected.checksum.
  • platform/mac-leopard/fast/dom/isindex-002-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/isindex-002-expected.png.
  • platform/mac-leopard/fast/dom/replaceChild-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/dom/replaceChild-expected.checksum.
  • platform/mac-leopard/fast/dom/replaceChild-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/replaceChild-expected.png.
  • platform/mac-leopard/fast/forms/select-baseline-expected.checksum:
  • platform/mac-leopard/fast/forms/select-baseline-expected.png:
  • platform/mac-leopard/fast/forms/text-style-color-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/forms/text-style-color-expected.checksum.
  • platform/mac-leopard/fast/forms/text-style-color-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png.
  • platform/mac-leopard/fast/multicol/shadow-breaking-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.checksum.
  • platform/mac-leopard/fast/multicol/shadow-breaking-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.png.
  • platform/mac-leopard/fast/table/028-vertical-expected.checksum:
  • platform/mac-leopard/fast/table/028-vertical-expected.png:
  • platform/mac-leopard/fast/text/atsui-negative-spacing-features-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/text/atsui-negative-spacing-features-expected.checksum.
  • platform/mac-leopard/fast/text/atsui-negative-spacing-features-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/text/atsui-negative-spacing-features-expected.png.
  • platform/mac-leopard/fast/text/atsui-spacing-features-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/text/atsui-spacing-features-expected.checksum.
  • platform/mac-leopard/fast/text/atsui-spacing-features-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/text/atsui-spacing-features-expected.png.
  • platform/mac-leopard/fast/text/complex-text-opacity-expected.checksum:
  • platform/mac-leopard/fast/text/complex-text-opacity-expected.png:
1:04 PM Changeset in webkit [79720] by jamesr@google.com
  • 4 edits
    34 adds in trunk/LayoutTests

2011-02-25 James Robinson <jamesr@chromium.org>

Add chromium win/linux baselines for new vertical replaced test and update various expectations.

  • platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.checksum:
  • platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.checksum: Added.
  • platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.png: Added.
  • platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.checksum: Added.
  • platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.png: Added.
  • platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.checksum: Added.
  • platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.png: Added.
  • platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.checksum: Added.
  • platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.png: Added.
  • platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.checksum: Added.
  • platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.png: Added.
  • platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.checksum: Added.
  • platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.png: Added.
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.checksum: Added.
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.png: Added.
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.txt: Added.
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.checksum: Added.
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.png: Added.
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.txt: Added.
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.checksum: Added.
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.png: Added.
  • platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.txt: Added.
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.checksum: Added.
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.png: Added.
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.txt: Added.
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.checksum: Added.
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.png: Added.
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.txt: Added.
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.checksum: Added.
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.png: Added.
  • platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:03 PM TriagingTestFailures edited by Adam Roben
Update the crash log URL to match the new URL format. (diff)
1:00 PM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
changed to armv5 (diff)
12:58 PM TriagingTestFailures edited by Adam Roben
Fix a link (diff)
12:55 PM TriagingTestFailures edited by Adam Roben
Add a link to Darin's email about checking in expected failure results (diff)
12:30 PM Changeset in webkit [79719] by tony@chromium.org
  • 9 edits in trunk

2011-02-25 Tony Chang <tony@chromium.org>

Unreviewed, updating chromium linux baselines after changes to
RGBToHSL code in chromium.

  • platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/chromium-linux/fast/forms/menulist-style-color-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-style-color-expected.png:
  • platform/chromium-linux/fast/forms/select-baseline-expected.checksum:
  • platform/chromium-linux/fast/forms/select-baseline-expected.png:

2011-02-25 Tony Chang <tony@chromium.org>

Roll chromium deps to include RBGToHSL fix and ICU update.

  • DEPS:
12:20 PM Changeset in webkit [79718] by eric.carlson@apple.com
  • 4 edits in trunk

2011-02-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Eric Seidel.

'load' and 'error' events fired for @poster
https://bugs.webkit.org/show_bug.cgi?id=54908

  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::dispatchLoadEvent): Don't fire events when being used by a video element.

2011-02-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Eric Seidel.

'load' and 'error' events fired for @poster
https://bugs.webkit.org/show_bug.cgi?id=54908

  • media/video-poster.html: Register listeners for 'load' and 'error' events so the test will fail if they ever fire.
12:17 PM Changeset in webkit [79717] by vangelis@chromium.org
  • 1 edit
    4 copies in branches/chromium/648

Merge 79699 - 2011-02-25 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Simon Fraser.

[chromium] Adding test to ensure clipping layer gets updated when layout
width/height change in the page.
https://bugs.webkit.org/show_bug.cgi?id=55103

  • platform/chromium/compositing/layout-width-change-expected.checksum: Added.
  • platform/chromium/compositing/layout-width-change-expected.png: Added.
  • platform/chromium/compositing/layout-width-change-expected.txt: Added.
  • platform/chromium/compositing/layout-width-change.html: Added.

2011-02-25 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Simon Fraser.

Update the clip layer size whenever the root layer's size and position
is updated. This only affects the accelerated compositing path.
https://bugs.webkit.org/show_bug.cgi?id=55103

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition):

Test: platform/chromium/compositing/layout-width-change.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition):

TBR=vangelis@chromium.org
Review URL: http://codereview.chromium.org/6597014

12:01 PM Changeset in webkit [79716] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

media/controls-without-preload.html failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=50471

Unreviewed. Add Windows-XP specific (failing?) results to get the bots green.

  • platform/win-xp/media/controls-without-preload-expected.txt: Added.
11:57 AM Changeset in webkit [79715] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-02-25 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Option-clicking on links doesn't download them due to sandbox violation
https://bugs.webkit.org/show_bug.cgi?id=55250
<rdar://problem/9018359>

The change to make DecidePolicyForNavigationAction sync didn't handle the case when the
decided policy was "Download". Fix this by passing along the download ID back to the web process.

  • Platform/CoreIPC/HandleMessage.h: (CoreIPC::callMemberFunction): Add new overload.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Initialize m_syncNavigationActionPolicyDownloadID.

(WebKit::WebPageProxy::receivedPolicyDecision):
Set m_syncNavigationActionPolicyDownloadID to the download ID.

(WebKit::WebPageProxy::decidePolicyForNavigationAction):
Return the m_syncNavigationActionPolicyDownloadID.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Add a DownloadID reply parameter.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Don't pass a zero download ID to didReceivePolicyDecision.
11:57 AM Changeset in webkit [79714] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-25 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Add recent Snow Leopard failures.

  • platform/chromium/test_expectations.txt:
11:49 AM Changeset in webkit [79713] by mihaip@chromium.org
  • 2 edits
    6 moves
    6 deletes in trunk/LayoutTests

2011-02-25 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Fix fast/inline/inline-box-background-repeat-x.html, fast/inline/
inline-box-background-repeat-y.html and fast/inline/
inline-box-background.html for Chromium Snow Leopard by promoting
chromium-mac-leopard results to mac-leopard and removing outdated
chromium-mac ones.

  • platform/chromium-mac/fast/inline/inline-box-background-expected.checksum: Removed.
  • platform/chromium-mac/fast/inline/inline-box-background-expected.png: Removed.
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.checksum: Removed.
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.png: Removed.
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.checksum: Removed.
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/inline/inline-box-background-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-expected.checksum.
  • platform/mac-leopard/fast/inline/inline-box-background-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-expected.png.
  • platform/mac-leopard/fast/inline/inline-box-background-repeat-x-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-x-expected.checksum.
  • platform/mac-leopard/fast/inline/inline-box-background-repeat-x-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-x-expected.png.
  • platform/mac-leopard/fast/inline/inline-box-background-repeat-y-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-y-expected.checksum.
  • platform/mac-leopard/fast/inline/inline-box-background-repeat-y-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-y-expected.png.
11:47 AM Changeset in webkit [79712] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-25 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Move timeBeginPeriod into OS(WINDOWS) section
https://bugs.webkit.org/show_bug.cgi?id=55247

  • jsc.cpp: (main): timeBeginPeriod is available on all Windows versions and not compiler specific.
11:46 AM Changeset in webkit [79711] by alex
  • 6 edits
    2 copies in trunk/Source/WebKit2

2011-02-25 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> and Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement WebContext and NativeKeyboardEvent classes for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48510

  • GNUmakefile.am:
  • Shared/NativeWebKeyboardEvent.h: Added the GTK event attribute and constructors, in our case we need it because we use a pointer and copy the event. (WebKit::NativeWebKeyboardEvent::nativeEvent):
  • Shared/gtk/NativeWebKeyboardEventGtk.cpp: Added. (WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent): We need to copy the event in the constructor to avoid two references to the same event.
  • Shared/gtk/WebEventFactory.cpp: Changed the prototype of the functions to add const, we need it for the NativeWebKeyboardEvent constructor. (WebKit::modifiersForEvent): (WebKit::WebEventFactory::createWebKeyboardEvent):
  • UIProcess/gtk/WebContextGtk.cpp: Added. Stubbed implementation for GTK port. Yet to implement. (WebKit::WebContext::applicationCacheDirectory): (WebKit::WebContext::platformInitializeWebProcess): (WebKit::WebContext::platformDefaultDatabaseDirectory):
  • UIProcess/gtk/WebView.cpp: (WebKit::WebView::handleKeyboardEvent):
11:41 AM Changeset in webkit [79710] by mihaip@chromium.org
  • 1 edit
    4 moves
    2 deletes in trunk/LayoutTests

2011-02-25 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Fix fast/dom/34176.html and fast/dom/52776.html for Chromium Snow
Leopard by promoting chromium-mac-leopard results to mac-leopard and
removing outdated chromium-mac ones.

  • platform/chromium-mac-leopard/fast/dom/52776-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/52776-expected.txt: Removed.
  • platform/mac-leopard/fast/dom/34176-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/dom/34176-expected.checksum.
  • platform/mac-leopard/fast/dom/34176-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/34176-expected.png.
  • platform/mac-leopard/fast/dom/52776-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/dom/52776-expected.checksum.
  • platform/mac-leopard/fast/dom/52776-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/52776-expected.png.
11:38 AM Changeset in webkit [79709] by jamesr@google.com
  • 2 edits
    15 adds in trunk/LayoutTests

2011-02-25 James Robinson <jamesr@chromium.org>

More chromium expectations and baselines.

  • platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.checksum: Added.
  • platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png: Added.
  • platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.checksum: Added.
  • platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png: Added.
  • platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.checksum: Added.
  • platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:28 AM Changeset in webkit [79708] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-02-25 James Robinson <jamesr@chromium.org>

Fix typo in Chromium test expectations.

  • platform/chromium/test_expectations.txt:
11:20 AM Changeset in webkit [79707] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-25 Patrick Gansterer <Patrick Gansterer>

Unreviewed WinCE build fix for r79695.

  • jsc.cpp: (main): SetErrorMode isn't available on WinCE.
11:18 AM Changeset in webkit [79706] by hyatt@apple.com
  • 3 edits
    28 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Sam Weinig.

Patch computePositionedLogicalHeightReplaced to be writing-mode aware.

Added six new tests in fast/replaced.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

LayoutTests:

  • fast/replaced/vertical-lr: Added.
  • fast/replaced/vertical-lr/absolute-position-percentage-width.html: Added.
  • fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom.html: Added.
  • fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right.html: Added.
  • fast/replaced/vertical-rl: Added.
  • fast/replaced/vertical-rl/absolute-position-percentage-width.html: Added.
  • fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom.html: Added.
  • fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right.html: Added.
11:17 AM Changeset in webkit [79705] by jamesr@google.com
  • 2 edits
    6 adds in trunk/LayoutTests

2011-02-25 James Robinson <jamesr@chromium.org>

Update chromium expectations and baselines for some ruby tests.

  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:15 AM Changeset in webkit [79704] by mihaip@chromium.org
  • 2 edits
    8 moves
    8 deletes in trunk/LayoutTests

2011-02-25 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Fix editing/selection/caret-rtl* for Chromium Snow Leopard. Remove
outdated chromium-mac baselines (the test will pass on Chromium SL with
the mac/ baselines). Promote the chromium-mac-leopard baselines to
mac-leopard (since the Mac port will pass with them on Leopard).

  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-expected.png: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/editing/selection/caret-rtl-2-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.checksum.
  • platform/mac-leopard/editing/selection/caret-rtl-2-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.png.
  • platform/mac-leopard/editing/selection/caret-rtl-2-left-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-2-left-expected.checksum.
  • platform/mac-leopard/editing/selection/caret-rtl-2-left-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-2-left-expected.png.
  • platform/mac-leopard/editing/selection/caret-rtl-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-expected.checksum.
  • platform/mac-leopard/editing/selection/caret-rtl-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-expected.png.
  • platform/mac-leopard/editing/selection/caret-rtl-right-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-right-expected.checksum.
  • platform/mac-leopard/editing/selection/caret-rtl-right-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-right-expected.png.
11:14 AM Changeset in webkit [79703] by brettw@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-15 Brett Wilson <brettw@chromium.org>

Reviewed by Darin Fisher.

Recover the mouse capture state when we recieve a mouse event where there is no longer a button down.
https://bugs.webkit.org/show_bug.cgi?id=54503

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent):
11:08 AM Changeset in webkit [79702] by andersca@apple.com
  • 10 edits in trunk/Source/WebKit2

2011-02-25 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Get rid of more old accelerated compositing code
https://bugs.webkit.org/show_bug.cgi?id=55235

  • Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h:
  • UIProcess/ChunkedUpdateDrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyImpl.cpp:
  • UIProcess/DrawingAreaProxyImpl.h:
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/DrawingAreaImpl.h:
11:06 AM BuildingOnWindows edited by Adam Roben
Clean up a bug link (diff)
11:01 AM Changeset in webkit [79701] by Patrick Gansterer
  • 3 edits in trunk/Source/WebCore

2011-02-25 Patrick Gansterer <Patrick Gansterer>

Unreviewed build fix.

  • platform/text/brew/TextBreakIteratorBrew.cpp: (WebCore::acquireLineBreakIterator):
  • platform/text/wince/TextBreakIteratorWinCE.cpp: (WebCore::acquireLineBreakIterator):
11:00 AM Changeset in webkit [79700] by mihaip@chromium.org
  • 4 edits
    1 delete in trunk/LayoutTests

2011-02-25 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

editing/pasteboard/merge-end-list.html was failing on Chromium Snow
Leopard because it was picking up the .checksum file in chromium-mac/,
even though it would pass with the mac/ .png/.checksum. Additionally, the
chromium-mac .checksum had no corresponding .png.

Fixes things by deleting the lone .checksum in chromium-mac and updating
the mac-leopard results (which can be used by both the Mac and Chromium
ports).

  • platform/chromium-mac/editing/pasteboard/merge-end-list-expected.checksum: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/editing/pasteboard/merge-end-list-expected.checksum:
  • platform/mac-leopard/editing/pasteboard/merge-end-list-expected.png:
11:00 AM BuildingOnWindows edited by Adam Roben
Add instructions for disabling UAC to get crash logs on Windows Vista/7 (diff)
10:58 AM Changeset in webkit [79699] by vangelis@chromium.org
  • 3 edits
    4 adds in trunk

2011-02-25 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Simon Fraser.

[chromium] Adding test to ensure clipping layer gets updated when layout
width/height change in the page.
https://bugs.webkit.org/show_bug.cgi?id=55103

  • platform/chromium/compositing/layout-width-change-expected.checksum: Added.
  • platform/chromium/compositing/layout-width-change-expected.png: Added.
  • platform/chromium/compositing/layout-width-change-expected.txt: Added.
  • platform/chromium/compositing/layout-width-change.html: Added.

2011-02-25 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Simon Fraser.

Update the clip layer size whenever the root layer's size and position
is updated. This only affects the accelerated compositing path.
https://bugs.webkit.org/show_bug.cgi?id=55103

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition):

Test: platform/chromium/compositing/layout-width-change.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition):
10:46 AM Changeset in webkit [79698] by Adam Roben
  • 2 edits in trunk/Tools

Double-check that modifying the registry worked

On Windows Vista/7 with UAC enabled, regtool will fail to modify the registry, but it will
still return a successful exit code. So we double-check here that the value we tried to
write to the registry was really written.

Fixes <http://webkit.org/b/55227> old-run-webkit-tests falsely claims to be saving crash
logs on Windows Vista/7

Reviewed by Darin Adler.

  • Scripts/old-run-webkit-tests:

(writeRegistryString): After trying to write the string value, check that it was really
written.

10:46 AM Changeset in webkit [79697] by Adam Roben
  • 2 edits in trunk/Tools

Set the 32-bit post-mortem debugger on 64-bit OSes

The post-mortem debugger is controlled by some registry values in
HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\AeDebug. On 64-bit OSes, you can either
set the values in that key, which will be used for 64-bit apps, or in the equivalent key
under Wow6432Node, which will be used for 32-bit apps. Since DumpRenderTree and
WebKitTestRunner are 32-bit, we want to use the latter location.

Fixes <http://webkit.org/b/55225> old-run-webkit-tests sets the post-mortem debugger for
64-bit apps, but should set it for 32-bit apps instead

Reviewed by Darin Adler.

  • Scripts/old-run-webkit-tests:

(readRegistryString):
(writeRegistryString):
Pass --wow32 to regtool so it will get/set values beneath Wow6432Node, which is where
Windows looks for the post-mortem debugger values when a 32-bit app crashes on a 64-bit OS.
Passing --wow32 on a 32-bit OS will not have any effect.

10:45 AM Changeset in webkit [79696] by Adam Roben
  • 2 edits in trunk/Tools

Clean up code to set up crash log saving on Windows

Fixes <http://webkit.org/b/55224> old-run-webkit-test's Windows registry code is ugly

Reviewed by David Kilzer.

  • Scripts/old-run-webkit-tests:

(readRegistryString):
(writeRegistryString):
Moved code to read strings from and write strings to the registry here...

(setUpWindowsCrashLogSaving): ...from here.

10:45 AM Changeset in webkit [79695] by Adam Roben
  • 9 edits in trunk

Work around Cygwin's crash-suppression behavior

Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which any processes it launches will
inherit. This is bad for testing/debugging, as it causes the post-mortem debugger not to be
invoked. (Cygwin does this because it makes crashes more UNIX-y.) We reset the error mode
when our test apps launch to work around Cygwin's behavior.

Fixes <http://webkit.org/b/55222> Test apps crash silently (without invoking post-mortem
debugger) when launched from Cygwin 1.7

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • API/tests/testapi.c: Added a now-needed #include.

(main):

  • jsc.cpp:

(main):
Call ::SetErrorMode(0) to undo Cygwin's folly.

  • JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Define NOMINMAX like many of our

other projects do so that windows.h won't define min/max macros that interfere with
std::numeric_limits<T>::min/max.

Tools:

  • DumpRenderTree/win/DumpRenderTree.cpp:

(main):

  • TestWebKitAPI/win/main.cpp:

(main):

  • WebKitAPITest/main.cpp:

(main):

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::platformInitialize):
Call ::SetErrorMode(0) to undo Cygwin's folly.

10:34 AM Changeset in webkit [79694] by mitz@apple.com
  • 12 edits in trunk/Source/WebCore

Minimize calls to ubrk_setText()
https://bugs.webkit.org/show_bug.cgi?id=54912
<rdar://problem/9032774>

Patch by Ned Holbrook <nholbrook@apple.com> on 2011-02-25
Reviewed by Dan Bernstein.

Avoid calling ubrk_setText() once per call to isBreakable() by using a LazyLineBreakIterator, which defers
break iterator creation until needed. This requires replacing the global line break iterator primitive with a
version that can be nested, since in some cases two iterators may need to be outstanding. In particular,
layoutInlineChildren() may indirectly call computePreferredLogicalWidths() and each may need an iterator.
In a test with a paragraph of Japanese text, this reduced the number of ubrk_setText() calls from 164 to 1.

  • platform/text/TextBreakIterator.h: Add LazyLineBreakIterator.

(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::~LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::string):
(WebCore::LazyLineBreakIterator::length):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):

  • platform/text/TextBreakIteratorICU.cpp: Replace lineBreakIterator() primitive with acquireLineBreakIterator()/releaseLineBreakIterator().

(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):

  • platform/text/brew/TextBreakIteratorBrew.cpp: Ditto.

(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):

  • platform/text/gtk/TextBreakIteratorGtk.cpp: Ditto.

(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):

  • platform/text/qt/TextBreakIteratorQt.cpp: Ditto.

(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):

  • platform/text/wince/TextBreakIteratorWinCE.cpp: Ditto.

(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren): Pass a mapping of RenderText to LazyLineBreakIterator from one call of findNextLineBreak() to the next.
(WebCore::RenderBlock::findNextLineBreak): Use said mapping, resetting LazyLineBreakIterator for any newly-encountered RenderText.

  • rendering/RenderText.cpp: Use a local LazyLineBreakIterator.

(WebCore::RenderText::computePreferredLogicalWidths):

  • rendering/break_lines.cpp: Accept LazyLineBreakIterator rather than UniChar buffer.

(WebCore::nextBreakablePosition):

  • rendering/break_lines.h: Accept LazyLineBreakIterator rather than UniChar buffer.

(WebCore::isBreakable):

10:28 AM Changeset in webkit [79693] by jberlin@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

[Windows 7 Release Tests] fast/ruby/base-shorter-than-text.html failing since introduction
in r79629.
https://bugs.webkit.org/show_bug.cgi?id=55230

Add Windows-specific expected results. Unreviewed.

  • platform/win/fast/ruby/base-shorter-than-text-expected.checksum: Added.
  • platform/win/fast/ruby/base-shorter-than-text-expected.png: Added.
  • platform/win/fast/ruby/base-shorter-than-text-expected.txt: Added.
10:25 AM Changeset in webkit [79692] by sergio@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

2011-02-25 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Added new GTK+ expectations for new tests.

  • platform/gtk/svg/custom/animate-target-id-changed-expected.checksum: Added.
  • platform/gtk/svg/custom/animate-target-id-changed-expected.png: Added.
  • platform/gtk/svg/custom/animate-target-id-changed-expected.txt: Added.
  • platform/gtk/svg/custom/animate-target-removed-from-document-expected.checksum: Added.
  • platform/gtk/svg/custom/animate-target-removed-from-document-expected.png: Added.
  • platform/gtk/svg/custom/animate-target-removed-from-document-expected.txt: Added.
  • platform/gtk/transitions/default-timing-function-expected.checksum: Added.
  • platform/gtk/transitions/default-timing-function-expected.png: Added.
  • platform/gtk/transitions/default-timing-function-expected.txt: Added.
10:11 AM Changeset in webkit [79691] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Sam Weinig.

Patch computePositionedLogicalWidthReplaced to be writing-mode aware. Not testable yet, since the height function overwrites the values
in a vertical text environment.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidthReplaced):

10:07 AM Changeset in webkit [79690] by Csaba Osztrogonác
  • 3 edits
    1 add in trunk/Source

2011-02-25 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Make the WebKit2 build system less confusing for non-Qt developers
https://bugs.webkit.org/show_bug.cgi?id=55213

  • QtWebKit.pro: Move the WebKit2 API into a project include file in the WebKit2 directory and include the pri file here.

2011-02-25 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Make the WebKit2 build system less confusing for non-Qt developers
https://bugs.webkit.org/show_bug.cgi?id=55213

  • WebKit2API.pri: Added.
9:51 AM Changeset in webkit [79689] by inferno@chromium.org
  • 3 edits
    3 adds in trunk

2011-02-25 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not crash when removing a text node adjacent to a word break node.
https://bugs.webkit.org/show_bug.cgi?id=55206

  • fast/text/resources/word-break-next-linebox-not-dirty-crash.html: Added.
  • fast/text/word-break-next-linebox-not-dirty-crash-main-expected.txt: Added.
  • fast/text/word-break-next-linebox-not-dirty-crash-main.html: Added.

2011-02-25 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

When trying to find which lines to dirty for a changed child, make sure
that we do test if the adjacent next linebox contains that changed child
and if yes, dirty it. This can happen in cases when we have a word break
between text nodes.
https://bugs.webkit.org/show_bug.cgi?id=55206

Test: fast/text/word-break-next-linebox-not-dirty-crash-main.html

  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
9:35 AM Changeset in webkit [79688] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-25 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium Snow Leopard expectations update. Remove failing
expectations for tests that pass after r79653. Add one more known
failure and flake.

  • platform/chromium/test_expectations.txt:
9:27 AM Changeset in webkit [79687] by christian@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

Unreviewed translation file.

L10N: Webkit translated to Basque (eu) language
https://bugs.webkit.org/show_bug.cgi?id=36588

  • eu.po: Added.
9:04 AM Changeset in webkit [79686] by kbalazs@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

Unreviewed build fix for Intel ICC and MSVC.

Patch by Alexis Menard <alexis.menard@openbossa.org> on 2011-02-25

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(tst_QGraphicsWebView::setPalette):

  • tests/qwebview/tst_qwebview.cpp:

(tst_QWebView::setPalette):

8:56 AM Changeset in webkit [79685] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-25 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Added an inspector test that fails on GTK debug bots.

  • platform/gtk/Skipped: inspector/extensions/extensions-events.html
8:43 AM Changeset in webkit [79684] by antonm@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt

Unreviewed. Chromium expectations.

  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt
8:15 AM Changeset in webkit [79683] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebKit/qt

2011-02-25 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Properly propagate the palette to QWebPage from QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=31742

Discovered while looking at 31742. When we set a palette on the
QGraphicsWebView we need to propagate it to the page like QWebView.
I have added the same tests as QWebView to be sure to catch potential
regressions as well as two extras QVERIFY to check the palette propagation.

  • Api/qgraphicswebview.cpp: (QGraphicsWebView::event):
  • tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::setPalette_data): (tst_QGraphicsWebView::setPalette):
8:13 AM Changeset in webkit [79682] by podivilov@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-25 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] Add basic layout tests for the highlighter
https://bugs.webkit.org/show_bug.cgi?id=54751

Adding basic tests for the highlighter.

  • inspector/editor/highlighter-basics-expected.txt: Added.
  • inspector/editor/highlighter-basics.html: Added.

2011-02-25 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] Add basic layout tests for the highlighter
https://bugs.webkit.org/show_bug.cgi?id=54751

Test: inspector/editor/highlighter-basics.html

  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter.prototype.highlight):
7:02 AM Changeset in webkit [79681] by antonm@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed. Temporary disabling a newly added test.

  • platform/chromium/test_expectations.txt
6:10 AM Changeset in webkit [79680] by antonm@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed. Correcting test expectations.

  • platform/chromium/test_expectations.txt
5:52 AM Changeset in webkit [79679] by sergio@webkit.org
  • 1 edit
    38 adds in trunk/LayoutTests

2011-02-25 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Added new GTK test expectations.

  • platform/gtk/fast/block/positioning/vertical-lr: Added 6 new test expectations.
  • platform/gtk/fast/block/positioning/vertical-rl: Added 6 new test expectations.
5:41 AM Changeset in webkit [79678] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit/qt

Unreviewed buildfix after r79672.

[Qt] Build tst_qdeclarativewebview if QT_CONFIG contains declarative.

  • tests/tests.pri:
  • tests/tests.pro:
5:35 AM Changeset in webkit [79677] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-24 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Huge fonts in font preview
https://bugs.webkit.org/show_bug.cgi?id=55143

5:13 AM Changeset in webkit [79676] by antonm@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed. Updating test expectations for Chromium.

  • platform/chromium/test_expectations.txt
5:08 AM Changeset in webkit [79675] by Nikolas Zimmermann
  • 23 edits
    6 adds in trunk

2011-02-25 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Implement SVGColor/SVGPaint API
https://bugs.webkit.org/show_bug.cgi?id=55119

SVGColor::cssText() shouldn't return #RRGGBBAA colors
https://bugs.webkit.org/show_bug.cgi?id=48120

Rewrite SVGColor/SVGPaint to actually implement their desired setPaint/setColor/setURI APIs.
SVGPaint is a CSSValue, and its setPaint() function allows to switch to an arbitary paint type.
That means, unlike all other CSSValues, SVGColor/SVGPaint are mutable. That means changes to
their CSSValues should be reflected in the elements style as well as in the computed style.
This patch doesn't yet implement that, the stubbed-out method valueChanged() is what
needs to be implemented. For now you can grab a SVGColor/SVGPaint object through getCSSPropertyValue
and manipulate it, in every possible way (SVPaint.uri/paintType/colorType/color attributes are all sync'ed).
Switch to strict JS bindings (RequiresAllArguments=Raise, StrictTypeChecking) for both objects.

Enable proper serialization of colors through Color::serialized(), affects some testcases (#FF.. -> #ff..)
Add extensive tests of all SVGColor/SVGPaint API, currently shows some FAIL messages, as element style
<-> computed style is not live, after mutating SVGColor/SVGPaint. That will be implemented in a follow-up patch.

Tests: svg/dom/SVGColor.html

svg/dom/SVGPaint.html

  • bindings/scripts/CodeGenerator.pm: Remove obsolete handling of "SVGPaintType", take ushort for paintType, as specified in the SVG 1.1 IDLs.
  • bindings/scripts/CodeGeneratorJS.pm: Ditto.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • css/SVGCSSParser.cpp: Adapt to SVGPaint/SVGColor create() naming convention changes. (WebCore::CSSParser::parseSVGValue): (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
  • svg/SVGColor.cpp: Rewrite to fully implement the SVGColor API, merge all constructors into one, use more descriptable create() naming convention. (WebCore::valueChanged): Stub implementation, will land in a follow-up patch. (WebCore::SVGColor::SVGColor): (WebCore::SVGColor::setRGBColor): (WebCore::SVGColor::colorFromRGBColorString): (WebCore::SVGColor::setRGBColorICCColor): (WebCore::SVGColor::setColor): (WebCore::SVGColor::cssText):
  • svg/SVGColor.h: (WebCore::SVGColor::createFromString): (WebCore::SVGColor::createFromColor): (WebCore::SVGColor::color): (WebCore::SVGColor::colorType): (WebCore::SVGColor::~SVGColor): (WebCore::SVGColor::setColor): (WebCore::SVGColor::setColorType):
  • svg/SVGColor.idl: Enable strict type checking.
  • svg/SVGPaint.cpp: Rewrite to fully implement the SVGPaint API, merge all constructors into one, use more descriptable create() naming convention. (WebCore::valueChanged): Stub implementation, will land in a follow-up patch. (WebCore::colorTypeForPaintType): (WebCore::SVGPaint::SVGPaint): (WebCore::SVGPaint::setUri): (WebCore::SVGPaint::defaultFill): (WebCore::SVGPaint::defaultStroke): (WebCore::SVGPaint::setPaint): (WebCore::SVGPaint::cssText): (WebCore::SVGPaint::matchesTargetURI):
  • svg/SVGPaint.h: (WebCore::SVGPaint::createUnknown): (WebCore::SVGPaint::createNone): (WebCore::SVGPaint::createCurrentColor): (WebCore::SVGPaint::createColor): (WebCore::SVGPaint::createURI): (WebCore::SVGPaint::createURIAndColor): (WebCore::SVGPaint::paintType): (WebCore::SVGPaint::uri): (WebCore::SVGPaint::create): (WebCore::SVGPaint::isSVGPaint):
  • svg/SVGPaint.idl: Enable strict type checking.

2011-02-25 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Implement SVGColor/SVGPaint API
https://bugs.webkit.org/show_bug.cgi?id=55119

SVGColor::cssText() shouldn't return #RRGGBBAA colors
https://bugs.webkit.org/show_bug.cgi?id=48120

Add two new tests covering the SVGColor/SVGPaint APIs.
Adapt to SVGColor::cssText() changes, color is properly serialized now.

  • svg/animations/animate-color-transparent-expected.txt:
  • svg/animations/animate-currentColor-expected.txt:
  • svg/animations/animate-dynamic-update-attributeName-expected.txt:
  • svg/animations/animate-inherit-css-property-expected.txt:
  • svg/animations/script-tests/animate-color-transparent.js: (expectTransparent): (expectOtherColor):
  • svg/animations/script-tests/animate-currentColor.js: (sample1):
  • svg/animations/script-tests/animate-inherit-css-property.js: (sample1):
  • svg/css/getComputedStyle-basic-expected.txt:
  • svg/custom/getPresentationAttribute-modify.svg:
  • svg/custom/rgbcolor-syntax.svg:
  • svg/dom/SVGColor-expected.txt: Added.
  • svg/dom/SVGColor.html: Added.
  • svg/dom/SVGPaint-expected.txt: Added.
  • svg/dom/SVGPaint.html: Added.
  • svg/dom/script-tests/SVGColor.js: Added. (checkStopColor):
  • svg/dom/script-tests/SVGPaint.js: Added. (resetStyle): (checkFillColor):
4:59 AM Changeset in webkit [79674] by reni@webkit.org
  • 10 edits
    5 adds in trunk

2011-02-25 Renata Hodovan <reni@webkit.org>

Reviewed by Nikolas Zimmermann.

FESpecularLightingElement changes doesn't require relayout.
https://bugs.webkit.org/show_bug.cgi?id=54451

When the FESpecularLightingElement receives an update message but the given value remains the same we don't need
to relayout the filter. Otherwise, the light source requests a repaint on the specular lighting filter.
Besides add ASSERTs to DiffuseLightElement::setFilterEffectAttribute as well to avoid lightSources being null.

No new tests are needed to check the repaint because it is covered by the dynamic update tests of FESpecularLighting.
We only test what happens if we remove the light source of specularLight.

Test: svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html

  • platform/graphics/filters/FESpecularLighting.cpp: (WebCore::FESpecularLighting::setSurfaceScale): (WebCore::FESpecularLighting::setSpecularConstant): (WebCore::FESpecularLighting::setSpecularExponent): (WebCore::FESpecularLighting::setKernelUnitLengthX): (WebCore::FESpecularLighting::setKernelUnitLengthY):
  • platform/graphics/filters/FESpecularLighting.h:
  • rendering/svg/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::postApplyResource):
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute): (WebCore::SVGFEDiffuseLightingElement::lightElementAttributeChanged): (WebCore::SVGFEDiffuseLightingElement::build):
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::findLightElement): (WebCore::SVGFELightElement::findLight): (WebCore::SVGFELightElement::svgAttributeChanged):
  • svg/SVGFELightElement.h:
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute): (WebCore::SVGFESpecularLightingElement::svgAttributeChanged): (WebCore::SVGFESpecularLightingElement::lightElementAttributeChanged): (WebCore::SVGFESpecularLightingElement::build):
  • svg/SVGFESpecularLightingElement.h:

2011-02-25 Renata Hodovan <reni@webkit.org>

Reviewed by Nikolas Zimmermann.

FESpecularLightingElement changes doesn't require relayout.
https://bugs.webkit.org/show_bug.cgi?id=54451

Test what happens if we remove the light source of specularLight.

  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.txt: Added.
  • svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html: Added.
  • svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-remove-lightSource.js: Added. (executeTest):
4:51 AM Changeset in webkit [79673] by antonm@chromium.org
  • 6 edits in trunk/LayoutTests/platform

Unreviewed.

Updated test expectations for Chromium.

  • platform/chromium-linux/fast/ruby/base-shorter-than-text-expected.png
  • platform/chromium-linux/fast/ruby/base-shorter-than-text-expected.checksum
  • platform/chromium-linux/fast/ruby/base-shorter-than-text-expected.txt
  • platform/chromium-win/fast/ruby/base-shorter-than-text-expected.png
  • platform/chromium-win/fast/ruby/base-shorter-than-text-expected.checksum
  • platform/chromium-win/fast/ruby/base-shorter-than-text-expected.txt
4:48 AM Changeset in webkit [79672] by andreas.kling@nokia.com
  • 4 edits
    7 adds in trunk/Source/WebKit/qt

2011-02-25 Gopal Raghavan <gopal.1.raghavan@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QML WebView inside a Flickable shows checkers pattern at startup
https://bugs.webkit.org/show_bug.cgi?id=50222.

This patch fixes the checkerboard visible at startup even if preferredWidth and preferredHeight are not set.

  • declarative/qdeclarativewebview.cpp: (QDeclarativeWebView::init):
  • tests/qdeclarativewebview: Added.
  • tests/qdeclarativewebview/qdeclarativewebview.pro: Added.
  • tests/qdeclarativewebview/resources: Added.
  • tests/qdeclarativewebview/resources/webviewtest.qml: Added.
  • tests/qdeclarativewebview/resources/webviewtestdefault.qml: Added.
  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Added. (tst_QDeclarativeWebView::initTestCase): (tst_QDeclarativeWebView::cleanupTestCase): (tst_QDeclarativeWebView::init): (tst_QDeclarativeWebView::cleanup): (tst_QDeclarativeWebView::preferredWidthTest): (tst_QDeclarativeWebView::preferredHeightTest): (tst_QDeclarativeWebView::preferredWidthDefaultTest): (tst_QDeclarativeWebView::preferredHeightDefaultTest): (tst_QDeclarativeWebView::checkNoErrors):
  • tests/tests.pri:
  • tests/tests.pro:
3:44 AM Changeset in webkit [79671] by alex
  • 4 edits
    1 copy
    3 adds in trunk/Source/WebKit2

2011-02-25 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> and Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement WebView and WebKitWebView classes for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48509

  • GNUmakefile.am:
  • UIProcess/API/C/gtk/WKView.cpp:
  • UIProcess/API/C/gtk/WKView.h: Removed gdkrectangle from constructor.
  • UIProcess/gtk/WebViewWidget.cpp: Added. The GObject interface for WebView. The GObject is the GtkWidget handle which is used by WebView class for GTK port.
  • UIProcess/gtk/WebViewWidget.h: Added. The GObject interface declarations for GtkWidget handle for GTK port.
  • UIProcess/gtk/WebView.cpp: Added. The native GtkWidget handle for GTK port which is associated with each WKViewRef.
  • UIProcess/gtk/WebView.h: Added. Class which implements the PageClient interface. It is a wrapper over the native GtkWidget handle associated with each WKViewRef for GTK port.
3:40 AM Changeset in webkit [79670] by alex
  • 2 edits in trunk/Source/WebKit2

2011-02-25 Alejandro G. Castro <alex@igalia.com>

Fix GTK compilation after r79654.

  • GNUmakefile.am:
3:24 AM Changeset in webkit [79669] by sergio@webkit.org
  • 3 edits in trunk/LayoutTests

2011-02-25 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Updated GTK test expectations after r79618.

  • platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/gtk/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
3:07 AM Changeset in webkit [79668] by jocelyn.turcotte@nokia.com
  • 15 edits
    2 deletes in trunk

[Qt] Revert the support for QNAM affined to a different thread.
https://bugs.webkit.org/show_bug.cgi?id=55149

Reviewed by Andreas Kling.

Qt 4.8 will have QNAM use its own thread internally by default,
no need to keep this complexity in WebKit.

This mainly reverts:
http://trac.webkit.org/changeset/73710
http://trac.webkit.org/changeset/73712

Source/WebCore:

  • WebCore.pro:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:

(WebCore::MediaPlayerPrivateQt::commitLoad):

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::FormDataIODevice::FormDataIODevice):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::setLoadMode):
(WebCore::QNetworkReplyHandler::abort):
(WebCore::QNetworkReplyHandler::release):
(WebCore::ignoreHttpError):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::start):
(WebCore::QNetworkReplyHandler::sendQueuedItems):

  • platform/network/qt/QNetworkReplyHandler.h:

(WebCore::QNetworkReplyHandler::reply):

  • platform/network/qt/QtNAMThreadSafeProxy.cpp: Removed.
  • platform/network/qt/QtNAMThreadSafeProxy.h: Removed.
  • platform/network/qt/ResourceHandleQt.cpp:

(WebCore::ResourceHandle::willLoadFromCache):

  • platform/qt/CookieJarQt.cpp:

(WebCore::cookieJar):
(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::download):

  • tests/qwebpage/tst_qwebpage.cpp:

Tools:

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::~LauncherWindow):
(LauncherWindow::initializeView):
(LauncherWindow::createChrome):

  • QtTestBrowser/launcherwindow.h:

(WindowOptions::WindowOptions):

  • QtTestBrowser/webpage.cpp:

(WebPage::WebPage):

  • QtTestBrowser/webpage.h:
2:44 AM Changeset in webkit [79667] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit/mac

<rdar://problem/8902546> Build fix.

  • Misc/QuickDrawCompatibility.h:
2:05 AM Changeset in webkit [79666] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-25 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Skipped 3 SVG tests failing in GTK 32-bit release bot.

  • platform/gtk/Skipped:
1:12 AM Changeset in webkit [79665] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

Unreviewed.

Update a Qt specific expected file after r79618.

  • platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.checksum:
  • platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.png:
  • platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
12:30 AM Changeset in webkit [79664] by reni@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-02-25 Renata Hodovan <reni@webkit.org>

Reviewed by Andreas Kling.

FEBlendElement changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=55138

When the FEBlendElement receives an update message but the given value remains the same we don't need
to relayout the filter.

No new tests are needed because this modificiation is covered by the dynamic update tests of FEBlend.

  • platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::setBlendMode):
  • platform/graphics/filters/FEBlend.h:
  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::setFilterEffectAttribute): (WebCore::SVGFEBlendElement::svgAttributeChanged): (WebCore::SVGFEBlendElement::synchronizeProperty):
  • svg/SVGFEBlendElement.h:

Feb 24, 2011:

10:28 PM Changeset in webkit [79663] by dbates@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-24 Daniel Bates <dbates@rim.com>

Reviewed by Antonio Gomes.

Clean up: Extract table height adjustment for <caption> into common function
https://bugs.webkit.org/show_bug.cgi?id=54936

We use similar logic for adjusting the height of a table with respect
to a top- and bottom-positioned <caption>. Instead, we should extract
the common code into a shared function.

No functionality changed. So no new tests.

  • rendering/RenderTable.cpp: (WebCore::RenderTable::adjustLogicalHeightForCaption): Added. (WebCore::RenderTable::layout): Extracted common code to adjust table height with respect to the <caption> into RenderTable::adjustLogicalHeightForCaption().
  • rendering/RenderTable.h:
10:21 PM Changeset in webkit [79662] by mihaip@chromium.org
  • 5 edits
    2 copies in trunk/LayoutTests

2011-02-24 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Rebaseline media/audio-repaint.html and media/video-display-toggle.html
for Snow Leopard.

  • platform/chromium-mac-leopard/media/video-display-toggle-expected.checksum: Copied from LayoutTests/platform/chromium-mac/media/video-display-toggle-expected.checksum.
  • platform/chromium-mac-leopard/media/video-display-toggle-expected.png: Copied from LayoutTests/platform/chromium-mac/media/video-display-toggle-expected.png.
  • platform/chromium-mac/media/audio-repaint-expected.checksum:
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.checksum:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
9:55 PM Changeset in webkit [79661] by Simon Fraser
  • 5 edits in trunk/LayoutTests

2011-02-24 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

fast/repaint/bugzilla-6473.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=53655

Add a waitUntilDone() and notifyDone() to this test, since it uses
a setTimeout(), and update results accordingly.

  • fast/repaint/bugzilla-6473.html:
  • platform/mac/fast/repaint/bugzilla-6473-expected.checksum:
  • platform/mac/fast/repaint/bugzilla-6473-expected.png:
  • platform/mac/fast/repaint/bugzilla-6473-expected.txt:
9:54 PM Changeset in webkit [79660] by mitz@apple.com
  • 3 edits in trunk/LayoutTests

Updated results after r79629.

  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
7:20 PM Changeset in webkit [79659] by jamesr@google.com
  • 12 edits
    3 adds in trunk/Source/WebCore

2011-02-24 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Move draw time properties out of *LayerChromium to CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=55013

This adds a new type (tentatively named CCLayerImpl) responsible for drawing/compositing layers.
Currently LayerChromiums know about their CCLayerImpls and CCLayerImpls rely on the LayerChromium
tree for structure. In theory updates are a LayerChromium-only concept and draw is a CCLayerImpl-only
concept, but this patch doesn't go all there yet in the interest of keeping the patch small-ish.

RenderSurfaces are a CCLayerImpl-only concepts and no longer have any direct LayerChromium dependencies.

Note: I've put CCLayerImpl into a new 'cc' directory under platform/graphics/chromium/ and intentionally
not added it to the include path. We plan to add more compositor implementation details to this directory
and we want to keep accidental dependencies on these files to a minimum.

See https://bugs.webkit.org/show_bug.cgi?id=54047 for the big picture.

Refactor only, compositing/ tests cover these codepaths.

  • WebCore.gypi:
  • platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::draw):
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::updateContentsIfDirty): (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::cleanupResources): (WebCore::LayerChromium::setLayerRenderer): (WebCore::LayerChromium::setBounds): (WebCore::LayerChromium::setFrame): (WebCore::LayerChromium::setNeedsDisplay): (WebCore::LayerChromium::setBorderColor): (WebCore::LayerChromium::borderColor): (WebCore::LayerChromium::setBorderWidth): (WebCore::LayerChromium::borderWidth): (WebCore::LayerChromium::layerRenderer): (WebCore::LayerChromium::setDoubleSided): (WebCore::LayerChromium::bounds):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::maskDrawLayer): (WebCore::LayerChromium::ccLayerImpl):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::compareLayerZ): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::updateLayersRecursive): (WebCore::LayerRendererChromium::setCompositeOffscreen): (WebCore::LayerRendererChromium::getOffscreenLayerTexture): (WebCore::LayerRendererChromium::drawLayer):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/PluginLayerChromium.cpp: (WebCore::PluginLayerChromium::draw):
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::RenderSurfaceChromium): (WebCore::RenderSurfaceChromium::drawSurface): (WebCore::RenderSurfaceChromium::draw):
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::drawYUV): (WebCore::VideoLayerChromium::drawRGBA):
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: Added. (WebCore::CCLayerImpl::CCLayerImpl): (WebCore::CCLayerImpl::~CCLayerImpl): (WebCore::CCLayerImpl::superlayer): (WebCore::CCLayerImpl::maskLayer): (WebCore::CCLayerImpl::replicaLayer): (WebCore::CCLayerImpl::setLayerRenderer): (WebCore::CCLayerImpl::createRenderSurface): (WebCore::CCLayerImpl::updateContentsIfDirty): (WebCore::CCLayerImpl::drawsContent): (WebCore::CCLayerImpl::draw): (WebCore::CCLayerImpl::unreserveContentsTexture): (WebCore::CCLayerImpl::bindContentsTexture): (WebCore::CCLayerImpl::cleanupResources): (WebCore::CCLayerImpl::getDrawRect): (WebCore::CCLayerImpl::drawDebugBorder):
  • platform/graphics/chromium/cc/CCLayerImpl.h: Added. (WebCore::CCLayerImpl::create): (WebCore::CCLayerImpl::setDebugBorderColor): (WebCore::CCLayerImpl::debugBorderColor): (WebCore::CCLayerImpl::setDebugBorderWidth): (WebCore::CCLayerImpl::debugBorderWidth): (WebCore::CCLayerImpl::layerRenderer): (WebCore::CCLayerImpl::renderSurface): (WebCore::CCLayerImpl::clearRenderSurface): (WebCore::CCLayerImpl::drawDepth): (WebCore::CCLayerImpl::setDrawDepth): (WebCore::CCLayerImpl::drawOpacity): (WebCore::CCLayerImpl::setDrawOpacity): (WebCore::CCLayerImpl::scissorRect): (WebCore::CCLayerImpl::setScissorRect): (WebCore::CCLayerImpl::targetRenderSurface): (WebCore::CCLayerImpl::setTargetRenderSurface): (WebCore::CCLayerImpl::doubleSided): (WebCore::CCLayerImpl::setDoubleSided): (WebCore::CCLayerImpl::bounds): (WebCore::CCLayerImpl::setBounds): (WebCore::CCLayerImpl::drawTransform): (WebCore::CCLayerImpl::setDrawTransform): (WebCore::CCLayerImpl::drawableContentRect): (WebCore::CCLayerImpl::setDrawableContentRect):
7:20 PM Changeset in webkit [79658] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Updated results after r79629.

  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
6:41 PM Changeset in webkit [79657] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

Qt build fix.

  • WebKit2.pri:
6:21 PM Changeset in webkit [79656] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r79629): Non-expanding ruby base is start-aligned rather than centered
https://bugs.webkit.org/show_bug.cgi?id=55197

Reviewed by Simon Fraser.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Adjust the line boundaries even
if there are no expansion opportunities. This allows RenderRubyBase to center itself.

6:20 PM Changeset in webkit [79655] by Darin Adler
  • 2 edits in trunk/Source/WebCore

2011-02-24 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

REGRESSION (r79466): http/tests/incremental/slow-utf8-html.pl flaky due to incorrect assertions
https://bugs.webkit.org/show_bug.cgi?id=55135

  • platform/text/TextCodecUTF8.cpp: (WebCore::TextCodecUTF8::decode): Removed incorrect assertions.
6:15 PM Changeset in webkit [79654] by beidson@apple.com
  • 20 edits
    9 adds in trunk/Source/WebKit2

Part of <rdar://problem/8762095> and https://bugs.webkit.org/show_bug.cgi?id=55172
Need WebKit2 API to view/manage origins with LocalStorage.

Reviewed by Sam Weinig and looked over by Brian Weinstein.

Project file stuff:

  • GNUmakefile.am:
  • WebKit2.pri:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:
  • win/WebKit2Generated.make:

WK2 derived sources and API stuff:

  • DerivedSources.make:
  • DerivedSources.pro:
  • Platform/CoreIPC/MessageID.h:
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • UIProcess/API/C/WKAPICast.h:

Add an KeyValueStorageManager to the context and invalidate it at the appropriate times:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::disconnectProcess):
(WebKit::WebContext::didReceiveMessage):

  • UIProcess/WebContext.h:

(WebKit::WebContext::keyValueStorageManagerProxy):

Add API to get the KeyValueStorageManager for a context:

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetKeyValueStorageManager):

  • UIProcess/API/C/WKContext.h:

Route messages to the right place:

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage):

Add the API object, which wraps to WebKeyValueStorageManagerProxy:

  • UIProcess/API/C/WKKeyValueStorageManager.cpp: Added.

(WKKeyValueStorageManagerGetTypeID):
(WKKeyValueStorageManagerGetKeyValueStorageOrigins):
(WKKeyValueStorageManagerDeleteEntriesForOrigin):
(WKKeyValueStorageManagerDeleteAllEntries):

  • UIProcess/API/C/WKKeyValueStorageManager.h: Added.

The UIProcess implementation of the manager to send messages to the WebProcess and pipe a callback back up to the client:

  • UIProcess/WebKeyValueStorageManagerProxy.cpp: Added.

(WebKit::WebKeyValueStorageManagerProxy::create):
(WebKit::WebKeyValueStorageManagerProxy::WebKeyValueStorageManagerProxy):
(WebKit::WebKeyValueStorageManagerProxy::~WebKeyValueStorageManagerProxy):
(WebKit::WebKeyValueStorageManagerProxy::invalidate):
(WebKit::WebKeyValueStorageManagerProxy::didReceiveMessage):
(WebKit::WebKeyValueStorageManagerProxy::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManagerProxy::didGetKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManagerProxy::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManagerProxy::deleteAllEntries):

  • UIProcess/WebKeyValueStorageManagerProxy.h: Added.

(WebKit::WebKeyValueStorageManagerProxy::clearContext):
(WebKit::WebKeyValueStorageManagerProxy::type):

  • UIProcess/WebKeyValueStorageManagerProxy.messages.in: Added.

The WebProcess implementation to response to UIProcess messages and actually do the dirty-work in WebCore:

  • WebProcess/KeyValueStorage: Added.
  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp: Added.

(WebKit::WebKeyValueStorageManager::shared):
(WebKit::WebKeyValueStorageManager::WebKeyValueStorageManager):
(WebKit::WebKeyValueStorageManager::didReceiveMessage):
(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManager::deleteAllEntries):

  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.h: Added.
  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.messages.in: Added.
6:13 PM Changeset in webkit [79653] by mihaip@chromium.org
  • 11 edits
    2 moves
    14 deletes in trunk/LayoutTests

2011-02-24 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Fix a few css1/ and css2.1/ Snow Leopard failures by deleting obsolete
chromium-mac baselines (so that we fall back on correct mac ones)

Also promotes some chromium-mac-leopard baselines to mac-leopard, since
they appear to work for the mac port too.

  • platform/chromium-mac-leopard/css1/box_properties/clear_float-expected.checksum: Removed.
  • platform/chromium-mac-leopard/css1/box_properties/clear_float-expected.png: Removed.
  • platform/chromium-mac-leopard/css1/box_properties/float_on_text_elements-expected.checksum: Removed.
  • platform/chromium-mac-leopard/css1/box_properties/float_on_text_elements-expected.png: Removed.
  • platform/chromium-mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Removed.
  • platform/chromium-mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Removed.
  • platform/chromium-mac/css1/box_properties/clear_float-expected.checksum: Removed.
  • platform/chromium-mac/css1/box_properties/clear_float-expected.png: Removed.
  • platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.checksum: Removed.
  • platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.png: Removed.
  • platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Removed.
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Removed.
  • platform/mac-leopard/css1/box_properties/clear_float-expected.checksum:
  • platform/mac-leopard/css1/box_properties/clear_float-expected.png:
  • platform/mac-leopard/css1/box_properties/float_on_text_elements-expected.checksum:
  • platform/mac-leopard/css1/box_properties/float_on_text_elements-expected.png:
  • platform/mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/mac/css1/box_properties/float_elements_in_series-expected.checksum:
  • platform/mac/css1/box_properties/float_elements_in_series-expected.png:
  • platform/mac/css1/text_properties/text_align-expected.checksum:
  • platform/mac/css1/text_properties/text_align-expected.png:
6:10 PM Changeset in webkit [79652] by Darin Adler
  • 8 edits
    2 adds in trunk/Source

2011-02-24 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

WebKit2: Image-based cursors do not work
https://bugs.webkit.org/show_bug.cgi?id=55184

  • WebCore.exp.in: Exported new entry points now used by WebKit2.

2011-02-24 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

WebKit2: Image-based cursors do not work
https://bugs.webkit.org/show_bug.cgi?id=55184

  • Shared/ShareableBitmap.h: Added releaseData function declaration. This is only defined for CG, but we can declare it without defining it on non-CG platforms without causing problems.
  • Shared/WebCoreArgumentCoders.cpp: Added. (CoreIPC::encodeImage): Added. For use in the Cursor argument coder. (CoreIPC::decodeImage): Ditto.
  • Shared/WebCoreArgumentCoders.h: Added code to the Cursor encoder and decoder to handle image-based cursors, using the new encodeImage and decodeImage functions.
  • Shared/cg/ShareableBitmapCG.cpp: (WebKit::ShareableBitmap::releaseData): Added. (WebKit::ShareableBitmap::createGraphicsContext): Use CGBitmapContextCreateWithData instead of CGBitmapContextCreate, to guarantee we outlast the CGBitmapContext we create. (WebKit::ShareableBitmap::paint): Got rid of unnneeded local variable.
  • Shared/cg/WebCoreArgumentCodersCG.cpp: Added. (CoreIPC::createImage): Added. For use by CoreIPC::decodeImage.
  • WebKit2.xcodeproj/project.pbxproj: Added WebCoreArgumentCoders.cpp and WebCoreArgumentCodersCG.cpp.
  • win/WebKit2.vcproj: Ditto.
6:07 PM Changeset in webkit [79651] by mdelaney@apple.com
  • 3 edits
    2 adds in trunk

2011-02-24 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

ImageBuffer::clip creates an image of the incorrect context in IOSurface case
https://bugs.webkit.org/show_bug.cgi?id=55170

  • fast/canvas/2d.fillText.gradient.html: Added. Draws a large "I" with an all-green gradient over a previously red canvas. Checks if (75,75) pixel is green to make sure the bottom left base of the I was painted, and checks (25,25) to make sure the red background wasn't overwritten by the textFill.

2011-02-24 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

ImageBuffer::clip creates an image of the incorrect context in IOSurface case
https://bugs.webkit.org/show_bug.cgi?id=55170

Test: fast/canvas/2d.fillText.gradient.html

  • platform/graphics/cg/ImageBufferCG.cpp: Clipping against ImageBuffer's context instead of ourself (the passed in context).
5:51 PM Changeset in webkit [79650] by jamesr@google.com
  • 4 edits in trunk/LayoutTests

2011-02-24 James Robinson <jamesr@chromium.org>

Update chromium-linux expectations for media/video-replaces-poster.html and expectations for V8 bugs.

  • platform/chromium-linux/media/video-replaces-poster-expected.checksum:
  • platform/chromium-linux/media/video-replaces-poster-expected.png:
  • platform/chromium/test_expectations.txt:
5:46 PM Changeset in webkit [79649] by mihaip@chromium.org
  • 4 edits in trunk/LayoutTests

2011-02-24 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Add LEOPARD modifier to tests that only fail on Leopard, not on Snow
Leopard.

Also updates Leopard expectations for fast/box-shadow/inset-expected.html
(SL expectations were updated in r78062).

  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/box-shadow/inset-expected.checksum:
  • platform/mac-leopard/fast/box-shadow/inset-expected.png:
5:20 PM Changeset in webkit [79648] by jamesr@google.com
  • 5 edits
    6 adds in trunk/LayoutTests

2011-02-24 James Robinson <jamesr@chromium.org>

Update chromium test expectations and baselines.

  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.checksum: Added.
  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png: Added.
  • platform/chromium-mac-leopard/media/video-controls-rendering-expected.checksum: Added.
  • platform/chromium-mac-leopard/media/video-controls-rendering-expected.png: Added.
  • platform/chromium-mac-leopard/media/video-replaces-poster-expected.checksum: Added.
  • platform/chromium-mac-leopard/media/video-replaces-poster-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/vertical-rl/001-expected.checksum:
  • platform/chromium-win/fast/block/positioning/vertical-rl/001-expected.png:
  • platform/chromium-win/fast/block/positioning/vertical-rl/001-expected.txt:
  • platform/chromium/test_expectations.txt:
5:02 PM Changeset in webkit [79647] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

2011-02-24 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

RenderBoxModelObject::paintBoxShadow should bail earlier
https://bugs.webkit.org/show_bug.cgi?id=55186

Make paintBoxShadow() bail early if there is no shadow, and make
callers consistent in not checking for box-shadow before calling it.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBoxDecorations):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBoxDecorations):
5:01 PM Changeset in webkit [79646] by abarth@webkit.org
  • 1 edit
    3 adds in trunk/Source/JavaScriptCore

2011-02-24 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add GYP project for JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=55027

Again, this GYP files is very rough, but it succeeds in building
JavaScriptCore. There's a lot more work to do here, especially in the
area of sharing with JavaScriptGlue.gyp. This patch is more of a
checkpoint so that other folks can help out if they wish.

  • gyp: Added.
  • gyp/JavaScriptCore.gyp: Added.
  • gyp/generate-derived-sources.sh: Added.
4:58 PM Changeset in webkit [79645] by abarth@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-24 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add missing files to JavaScriptCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55193

I forgot to add mm files in my previous patch.

4:55 PM Changeset in webkit [79644] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-24 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove unused parameter name in GCActivityCallback.cpp
https://bugs.webkit.org/show_bug.cgi?id=55194

This change is not strictly required for the GYP-based build system,
but I noticed this error when working on the new build system.

  • runtime/GCActivityCallback.cpp: (JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
4:53 PM Changeset in webkit [79643] by jamesr@google.com
  • 2 edits
    8 adds in trunk/LayoutTests

2011-02-24 James Robinson <jamesr@chromium.org>

Update chromium test expectations and baselines.

  • platform/chromium-linux/fast/ruby/base-shorter-than-text-expected.checksum: Added.
  • platform/chromium-linux/fast/ruby/base-shorter-than-text-expected.png: Added.
  • platform/chromium-linux/fast/ruby/base-shorter-than-text-expected.txt: Added.
  • platform/chromium-win/fast/ruby/base-shorter-than-text-expected.checksum: Added.
  • platform/chromium-win/fast/ruby/base-shorter-than-text-expected.png: Added.
  • platform/chromium-win/fast/ruby/base-shorter-than-text-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/ruby/base-shorter-than-text-expected.checksum: Added.
  • platform/mac-leopard/fast/ruby/base-shorter-than-text-expected.png: Added.
4:51 PM Changeset in webkit [79642] by abarth@webkit.org
  • 1 edit
    1 add in trunk/Tools

2011-02-24 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add a script for creating gypi files
https://bugs.webkit.org/show_bug.cgi?id=55113

This is a trivial script to create gypi files from the source code in
the current directory.

  • Scripts/make-gypi: Added.
4:42 PM Changeset in webkit [79641] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r79628.
http://trac.webkit.org/changeset/79628
https://bugs.webkit.org/show_bug.cgi?id=55195

"broke chromium win tests" (Requested by dpranke on #webkit).

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4:34 PM Changeset in webkit [79640] by mihaip@chromium.org
  • 9 edits
    2 deletes in trunk/LayoutTests

2011-02-24 Mihai Parparita <mihaip@chromium.org>

Unreviewed expectations update.

  • svg/custom/use-multiple-on-nested-disallowed-font.html has not crashed recently
  • Rebaseline fast/css/text-overflow-ellipsis.html for Leopard (Snow Leopard baselines were checked in with r78890)
  • Rebaseline fast/table/colspanMinWidth-vertical.html and fast/table/fixed-with-auto-with-colspan-vertical.html after r79618
  • platform/chromium-mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Removed.
  • platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/chromium-win/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/css/text-overflow-ellipsis-expected.checksum:
  • platform/mac-leopard/fast/css/text-overflow-ellipsis-expected.png:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.checksum:
  • platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.png:
  • platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
4:04 PM Changeset in webkit [79639] by jamesr@google.com
  • 7 edits in trunk/Source

2011-02-24 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Add a USE() macro to control use of the built-in UTF8 codec
https://bugs.webkit.org/show_bug.cgi?id=55189

Defaults USE(BUILTIN_UTF8_CODEC) to true for all platforms except chromium, which controls the flag via features.gypi.

  • wtf/Platform.h:

2011-02-24 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Add a USE() macro to control use of the built-in UTF8 codec
https://bugs.webkit.org/show_bug.cgi?id=55189

Guards the built in UTF8 codec registration with USE(BUILTIN_UTF8_CODEC). ICU is used if the USE() is not set.

  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerEncodingNames):
  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps):

2011-02-24 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Add a USE() macro to control use of the built-in UTF8 codec
https://bugs.webkit.org/show_bug.cgi?id=55189

Defaults USE(BUILTIN_UTF8_CODEC) to true for the Chromium port.

  • features.gypi:
3:58 PM Changeset in webkit [79638] by jamesr@google.com
  • 1 edit
    25 adds in trunk/LayoutTests

2011-02-24 James Robinson <jamesr@chromium.org>

Add chromium baselines for new fast/block/position/vertical- tests.

  • platform/chromium-linux/fast/block/positioning/vertical-lr/001-expected.checksum: Added.
  • platform/chromium-linux/fast/block/positioning/vertical-lr/001-expected.png: Added.
  • platform/chromium-linux/fast/block/positioning/vertical-lr/002-expected.checksum: Added.
  • platform/chromium-linux/fast/block/positioning/vertical-lr/002-expected.png: Added.
  • platform/chromium-linux/fast/block/positioning/vertical-rl/001-expected.checksum: Added.
  • platform/chromium-linux/fast/block/positioning/vertical-rl/001-expected.png: Added.
  • platform/chromium-linux/fast/block/positioning/vertical-rl/001-expected.txt: Added.
  • platform/chromium-linux/fast/block/positioning/vertical-rl/002-expected.checksum: Added.
  • platform/chromium-linux/fast/block/positioning/vertical-rl/002-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/vertical-lr/001-expected.checksum: Added.
  • platform/chromium-win/fast/block/positioning/vertical-lr/001-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/vertical-lr/001-expected.txt: Added.
  • platform/chromium-win/fast/block/positioning/vertical-lr/002-expected.checksum: Added.
  • platform/chromium-win/fast/block/positioning/vertical-lr/002-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/vertical-lr/002-expected.txt: Added.
  • platform/chromium-win/fast/block/positioning/vertical-rl/001-expected.checksum: Added.
  • platform/chromium-win/fast/block/positioning/vertical-rl/001-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/vertical-rl/001-expected.txt: Added.
  • platform/chromium-win/fast/block/positioning/vertical-rl/002-expected.checksum: Added.
  • platform/chromium-win/fast/block/positioning/vertical-rl/002-expected.png: Added.
  • platform/chromium-win/fast/block/positioning/vertical-rl/002-expected.txt: Added.
3:50 PM Changeset in webkit [79637] by ap@apple.com
  • 1 edit
    3 moves in trunk/LayoutTests

Rubber-stamped by Eric Seidel

Moving a test that doesn't need to be an http one out of http/tests.

  • fast/css/counter-crash-expected.txt: Copied from http/tests/css/counter-crash-expected.txt.
  • fast/css/counter-crash.html: Copied from http/tests/css/counter-crash.html.
  • fast/css/resources/counter-crash-frame-src.html: Copied from http/tests/css/resources/counter-crash-frame-src.html.
  • http/tests/css/counter-crash-expected.txt: Removed.
  • http/tests/css/counter-crash.html: Removed.
  • http/tests/css/resources/counter-crash-frame-src.html: Removed.
3:50 PM Changeset in webkit [79636] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-02-24 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

rebaseline-chromium-webkit-tests can't handle GPU variants
https://bugs.webkit.org/show_bug.cgi?id=55002

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3:41 PM Changeset in webkit [79635] by commit-queue@webkit.org
  • 8 edits in trunk/LayoutTests

2011-02-24 Anna Cavender <annacc@chromium.org>

Reviewed by Eric Seidel.

New baselines for media/video-replaces-poster.html needed after r79401
https://bugs.webkit.org/show_bug.cgi?id=54910

  • platform/chromium-linux/media/video-replaces-poster-expected.checksum:
  • platform/chromium-linux/media/video-replaces-poster-expected.png:
  • platform/chromium-mac/media/video-replaces-poster-expected.checksum:
  • platform/chromium-mac/media/video-replaces-poster-expected.png:
  • platform/chromium-win/media/video-replaces-poster-expected.checksum:
  • platform/chromium-win/media/video-replaces-poster-expected.png:
  • platform/chromium/test_expectations.txt:
3:40 PM Changeset in webkit [79634] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-24 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Crash when trying to send a sync message on an invalid connection
https://bugs.webkit.org/show_bug.cgi?id=55190
<rdar://problem/9035806>

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendSyncMessage): Don't try to call a client function if isValid() returns false since the client will be null in that case.
3:39 PM Changeset in webkit [79633] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-24 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

nrwt: log command used to start web server to --verbose

https://bugs.webkit.org/show_bug.cgi?id=55188

  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
3:16 PM Changeset in webkit [79632] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit/qt

Try to fix the Qt build.

3:13 PM Changeset in webkit [79631] by andersca@apple.com
  • 8 edits
    8 deletes in trunk/Source/WebKit2

2011-02-24 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Remove the layer backed drawing area
https://bugs.webkit.org/show_bug.cgi?id=55174

  • GNUmakefile.am:
  • Shared/DrawingAreaInfo.h:
  • UIProcess/API/mac/WKView.mm:
  • UIProcess/LayerBackedDrawingAreaProxy.cpp: Removed.
  • UIProcess/LayerBackedDrawingAreaProxy.h: Removed.
  • UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm: Removed.
  • UIProcess/win/LayerBackedDrawingAreaProxyWin.cpp: Removed.
  • UIProcess/win/WebView.cpp:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create):
  • WebProcess/WebPage/LayerBackedDrawingArea.cpp: Removed.
  • WebProcess/WebPage/LayerBackedDrawingArea.h: Removed.
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: Removed.
  • WebProcess/WebPage/win/LayerBackedDrawingAreaWin.cpp: Removed.
  • win/WebKit2.vcproj:
3:10 PM Changeset in webkit [79630] by mihaip@chromium.org
  • 145 edits
    2 moves in trunk

2011-02-24 Victoria Kirst <vrk@google.com>

Reviewed by Mihai Parparita.

[chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
https://bugs.webkit.org/show_bug.cgi?id=55089

Media's UILayoutTests rely on video-test.js and media-file.js to be in
the media/ folder.

  • http/tests/media/pdf-served-as-pdf.html:
  • http/tests/media/reload-after-dialog.html:
  • http/tests/media/remove-while-loading.html:
  • http/tests/media/text-served-as-text.html:
  • http/tests/media/video-buffered.html:
  • http/tests/media/video-cancel-load.html:
  • http/tests/media/video-cookie.html:
  • http/tests/media/video-error-abort.html:
  • http/tests/media/video-load-twice.html:
  • http/tests/media/video-play-stall-seek.html:
  • http/tests/media/video-play-stall.html:
  • http/tests/media/video-play-suspend.html:
  • http/tests/media/video-referer.html:
  • http/tests/media/video-seekable-stall.html:
  • http/tests/media/video-served-as-text.html:
  • media/adopt-node-crash.html:
  • media/audio-constructor-preload.html:
  • media/audio-constructor-src.html:
  • media/audio-constructor.html:
  • media/audio-controls-rendering.html:
  • media/audio-data-url.html:
  • media/audio-delete-while-slider-thumb-clicked.html:
  • media/audio-delete-while-step-button-clicked.html:
  • media/audio-mpeg-supported.html:
  • media/audio-mpeg4-supported.html:
  • media/audio-play-event.html:
  • media/before-load-member-access.html:
  • media/broken-video.html:
  • media/constructors.html:
  • media/context-menu-actions.html:
  • media/controls-after-reload.html:
  • media/controls-css-overload.html:
  • media/controls-drag-timebar.html:
  • media/controls-right-click-on-timebar.html:
  • media/controls-strict.html:
  • media/controls-styling.html:
  • media/controls-without-preload.html:
  • media/event-attributes.html:
  • media/invalid-media-url-crash.html:
  • media/media-can-play-mpeg-audio.html:
  • media/media-can-play-mpeg4-video.html:
  • media/media-can-play-octet-stream.html:
  • media/media-can-play-ogg.html:
  • media/media-can-play-wav-audio.html:
  • media/media-captions.html:
  • media/media-constants.html:
  • media/media-file.js: Renamed from LayoutTests/http/tests/media/media-file.js.
  • media/media-fullscreen-inline.html:
  • media/media-fullscreen-not-in-document.html:
  • media/media-load-event.html:
  • media/media-startTime.html:
  • media/remove-from-document-no-load.html:
  • media/remove-from-document.html:
  • media/restore-from-page-cache.html:
  • media/unsupported-rtsp.html:
  • media/unsupported-tracks.html:
  • media/video-append-source.html:
  • media/video-aspect-ratio.html:
  • media/video-autoplay.html:
  • media/video-buffered.html:
  • media/video-can-play-type.html:
  • media/video-canvas-alpha.html:
  • media/video-canvas-source.html:
  • media/video-click-dblckick-standalone.html:
  • media/video-controls-rendering.html:
  • media/video-controls-transformed.html:
  • media/video-controls-visible-audio-only.html:
  • media/video-controls-zoomed.html:
  • media/video-controls.html:
  • media/video-currentTime-delay.html:
  • media/video-currentTime-set.html:
  • media/video-currentTime-set2.html:
  • media/video-currentTime.html:
  • media/video-delay-load-event.html:
  • media/video-display-aspect-ratio.html:
  • media/video-display-none-crash.html:
  • media/video-display-toggle.html:
  • media/video-does-not-loop.html:
  • media/video-dom-autoplay.html:
  • media/video-dom-preload.html:
  • media/video-dom-src.html:
  • media/video-duration-known-after-eos.html:
  • media/video-error-does-not-exist.html:
  • media/video-frame-accurate-seek.html:
  • media/video-layer-crash.html:
  • media/video-load-networkState.html:
  • media/video-load-readyState.html:
  • media/video-loop.html:
  • media/video-muted.html:
  • media/video-no-audio.html:
  • media/video-no-autoplay.html:
  • media/video-pause-empty-events.html:
  • media/video-pause-immediately.html:
  • media/video-play-empty-events.html:
  • media/video-play-pause-events.html:
  • media/video-play-pause-exception.html:
  • media/video-played-collapse.html:
  • media/video-played-ranges-1.html:
  • media/video-played-reset.html:
  • media/video-poster-delayed.html:
  • media/video-poster-scale.html:
  • media/video-poster.html:
  • media/video-preload.html:
  • media/video-replaces-poster.html:
  • media/video-reverse-play-duration.html:
  • media/video-seek-by-small-increment.html:
  • media/video-seek-no-src-exception.html:
  • media/video-seek-past-end-paused.html:
  • media/video-seek-past-end-playing.html:
  • media/video-seekable.html:
  • media/video-seeking.html:
  • media/video-size-intrinsic-scale.html:
  • media/video-size.html:
  • media/video-source-error-no-candidate.html:
  • media/video-source-error.html:
  • media/video-source-inserted.html:
  • media/video-source-media.html:
  • media/video-source-moved.html:
  • media/video-source-none-supported.html:
  • media/video-source-removed.html:
  • media/video-source-type-params.html:
  • media/video-source-type.html:
  • media/video-source.html:
  • media/video-src-change.html:
  • media/video-src-invalid-remove.html:
  • media/video-src-none.html:
  • media/video-src-plus-source.html:
  • media/video-src-remove.html:
  • media/video-src-set.html:
  • media/video-src-source.html:
  • media/video-src.html:
  • media/video-test.js: Renamed from LayoutTests/http/tests/media/video-test.js.
  • media/video-timeupdate-during-playback.html:
  • media/video-timeupdate-reverse-play.html:
  • media/video-transformed.html:
  • media/video-volume-slider.html:
  • media/video-volume.html:
  • media/video-width-height.html:
  • media/video-zoom-controls.html:
  • media/video-zoom.html:

2011-02-24 Victoria Kirst <vrk@google.com>

Reviewed by Mihai Parparita.

[chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
https://bugs.webkit.org/show_bug.cgi?id=55089

This adds an alias into the media/ directory so that http/tests/media
tests can access the media resources when running in an httpd process.

  • Scripts/webkitperl/httpd.pm:
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
3:07 PM Changeset in webkit [79629] by mitz@apple.com
  • 8 edits
    4 adds in trunk

<rdar://problem/8902740> Expand ruby base when it is shorter than the ruby text
https://bugs.webkit.org/show_bug.cgi?id=55183

Reviewed by Dave Hyatt.

Source/WebCore:

Test: fast/ruby/base-shorter-than-text.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::availableLogicalWidthForLine):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::adjustInlineDirectionLineBounds): Added. The base clase implementation does nothing.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::textAlignmentForLine): Added. Implements the logic that changes "justify" to "auto" for
the last line or a line that ends with a hard break.
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Use textAlignmentForLine(), compute the available
width more efficiently, and call adjustInlineDirectionLineBounds() for justified lines.

  • rendering/RenderRubyBase.cpp:

(WebCore::RenderRubyBase::rubyRun): Added.
(WebCore::RenderRubyBase::textAlignmentForLine): Added. Alwyas returns "justify".
(WebCore::RenderRubyBase::adjustInlineDirectionLineBounds): Added. Insets the line such that the inset is
half the width of a single intra-line expansion.

  • rendering/RenderRubyBase.h:
  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::addChild):

LayoutTests:

  • fast/ruby/base-shorter-than-text.html: Added.
  • platform/mac/fast/ruby/base-shorter-than-text-expected.checksum: Added.
  • platform/mac/fast/ruby/base-shorter-than-text-expected.png: Added.
  • platform/mac/fast/ruby/base-shorter-than-text-expected.txt: Added.
3:05 PM Changeset in webkit [79628] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-24 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

nrwt: enable multiple processes by default on Chromium Win.

https://bugs.webkit.org/show_bug.cgi?id=55163

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2:58 PM Changeset in webkit [79627] by ggaren@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

2011-02-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Variable-sized allocation (but still capped at 64 bytes)
https://bugs.webkit.org/show_bug.cgi?id=55159


SunSpider reports no change.

  • runtime/Heap.cpp: (JSC::Heap::allocateSlowCase): Split allocation into a fast and slow case, so the fast case can inline size class selection and turn it into a compile-time constant.


Changed the collect-on-every allocation debugging switch to collect only
on every slow allocation, so you can still flip the switch without
recompiling the world. This may also be preferable for debugging purposes,
since collecting after every single allocation can be unusably slow,
and can mask problems by running destructors early.

  • runtime/Heap.h: Ditto.
  • runtime/JSCell.h: (JSC::JSCell::MarkedSpace::sizeClassFor): (JSC::JSCell::Heap::allocate): (JSC::JSCell::JSCell::operator new): The inlining mentioned above.
  • runtime/MarkedBlock.h: Dropped the block size from 256KB to 16KB. With multiple size classes, allocating a full 256KB for the first allocation in a given class can be pathologically wasteful. (8KB, or 4KB Mac and 8KB Windows, would be even better, but that seems to be a peformance regression for now.)


  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::allocateBlock): (JSC::MarkedSpace::reset): There's more than one size class now, and its cell size is not constant.
  • runtime/MarkedSpace.h: (JSC::MarkedSpace::SizeClass::SizeClass): Ditto.
2:53 PM Changeset in webkit [79626] by weinig@apple.com
  • 2 edits in trunk/Tools

Attempt to fix Qt.

  • WebKitTestRunner/TestInvocation.cpp:
2:40 PM Changeset in webkit [79625] by commit-queue@webkit.org
  • 10 edits in trunk/LayoutTests

2011-02-24 Xianzhu Wang <wangxianzhu@google.com>

Reviewed by Eric Seidel.

In layout tests, iframe's onload handler should not use script function
defined after the iframe.
https://bugs.webkit.org/show_bug.cgi?id=54942

  • editing/pasteboard/paste-noscript-svg-expected.txt:
  • editing/pasteboard/paste-noscript-svg.html:
  • editing/selection/cleared-by-relayout.html:
  • editing/undo/undo-iframe-location-change.html:
  • fast/dom/DOMImplementation/createDocument-with-used-doctype-expected.txt:
  • fast/dom/DOMImplementation/createDocument-with-used-doctype.html:
  • fast/dom/Window/window-postmessage-clone-frames.html:
  • fast/dom/wrapper-classes.html:
  • fast/dynamic/paused-event-dispatch.html:
  • fast/replaced/max-width-percent.html:
2:40 PM Changeset in webkit [79624] by mthole@apple.com
  • 5 edits in trunk/Source/WebKit2

WK2: Add ability to get document node for a WKBundleNodeHandle
https://bugs.webkit.org/post_bug.cgi

Reviewed by Sam Weinig.

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleCopyDocument):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::document):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
2:38 PM Changeset in webkit [79623] by jamesr@google.com
  • 145 edits
    2 moves in trunk

2011-02-24 James Robinson <jamesr@chromium.org>

Unreviewed, rolling out r79598.
http://trac.webkit.org/changeset/79598
https://bugs.webkit.org/show_bug.cgi?id=55089

Appears to be causing trouble with httpd on windows

  • http/tests/media/media-file.js: Renamed from LayoutTests/media/media-file.js. (): (mimeTypeForExtension): (setSrcByTagName): (setSrcById): (stripExtension):
  • http/tests/media/pdf-served-as-pdf.html:
  • http/tests/media/reload-after-dialog.html:
  • http/tests/media/remove-while-loading.html:
  • http/tests/media/text-served-as-text.html:
  • http/tests/media/video-buffered.html:
  • http/tests/media/video-cancel-load.html:
  • http/tests/media/video-cookie.html:
  • http/tests/media/video-error-abort.html:
  • http/tests/media/video-load-twice.html:
  • http/tests/media/video-play-stall-seek.html:
  • http/tests/media/video-play-stall.html:
  • http/tests/media/video-play-suspend.html:
  • http/tests/media/video-referer.html:
  • http/tests/media/video-seekable-stall.html:
  • http/tests/media/video-served-as-text.html:
  • http/tests/media/video-test.js: Renamed from LayoutTests/media/video-test.js. (disableFullTestDetailsPrinting): (enableFullTestDetailsPrinting): (logConsole): (findMediaElement): (testAndEnd): (test): (testExpected): (reportExpected): (runSilently): (run): (waitForEventAndEnd): (waitForEvent._eventCallback): (waitForEvent): (waitForEventTestAndEnd): (waitForEventAndFail): (waitForEventAndTest._eventCallback): (waitForEventAndTest): (testException): (endTest): (endTestLater): (failTestIn): (failTest): (logResult): (consoleWrite): (relativeURL): (isInTimeRanges):
  • media/adopt-node-crash.html:
  • media/audio-constructor-preload.html:
  • media/audio-constructor-src.html:
  • media/audio-constructor.html:
  • media/audio-controls-rendering.html:
  • media/audio-data-url.html:
  • media/audio-delete-while-slider-thumb-clicked.html:
  • media/audio-delete-while-step-button-clicked.html:
  • media/audio-mpeg-supported.html:
  • media/audio-mpeg4-supported.html:
  • media/audio-play-event.html:
  • media/before-load-member-access.html:
  • media/broken-video.html:
  • media/constructors.html:
  • media/context-menu-actions.html:
  • media/controls-after-reload.html:
  • media/controls-css-overload.html:
  • media/controls-drag-timebar.html:
  • media/controls-right-click-on-timebar.html:
  • media/controls-strict.html:
  • media/controls-styling.html:
  • media/controls-without-preload.html:
  • media/event-attributes.html:
  • media/invalid-media-url-crash.html:
  • media/media-can-play-mpeg-audio.html:
  • media/media-can-play-mpeg4-video.html:
  • media/media-can-play-octet-stream.html:
  • media/media-can-play-ogg.html:
  • media/media-can-play-wav-audio.html:
  • media/media-captions.html:
  • media/media-constants.html:
  • media/media-fullscreen-inline.html:
  • media/media-fullscreen-not-in-document.html:
  • media/media-load-event.html:
  • media/media-startTime.html:
  • media/remove-from-document-no-load.html:
  • media/remove-from-document.html:
  • media/restore-from-page-cache.html:
  • media/unsupported-rtsp.html:
  • media/unsupported-tracks.html:
  • media/video-append-source.html:
  • media/video-aspect-ratio.html:
  • media/video-autoplay.html:
  • media/video-buffered.html:
  • media/video-can-play-type.html:
  • media/video-canvas-alpha.html:
  • media/video-canvas-source.html:
  • media/video-click-dblckick-standalone.html:
  • media/video-controls-in-media-document.html:
  • media/video-controls-rendering.html:
  • media/video-controls-transformed.html:
  • media/video-controls-visible-audio-only.html:
  • media/video-controls-zoomed.html:
  • media/video-controls.html:
  • media/video-currentTime-delay.html:
  • media/video-currentTime-set.html:
  • media/video-currentTime-set2.html:
  • media/video-currentTime.html:
  • media/video-delay-load-event.html:
  • media/video-display-aspect-ratio.html:
  • media/video-display-none-crash.html:
  • media/video-display-toggle.html:
  • media/video-does-not-loop.html:
  • media/video-dom-autoplay.html:
  • media/video-dom-preload.html:
  • media/video-dom-src.html:
  • media/video-duration-known-after-eos.html:
  • media/video-error-does-not-exist.html:
  • media/video-frame-accurate-seek.html:
  • media/video-layer-crash.html:
  • media/video-load-networkState.html:
  • media/video-load-readyState.html:
  • media/video-loop.html:
  • media/video-muted.html:
  • media/video-no-audio.html:
  • media/video-no-autoplay.html:
  • media/video-pause-empty-events.html:
  • media/video-pause-immediately.html:
  • media/video-play-empty-events.html:
  • media/video-play-pause-events.html:
  • media/video-play-pause-exception.html:
  • media/video-played-collapse.html:
  • media/video-played-ranges-1.html:
  • media/video-played-reset.html:
  • media/video-plays-past-end-of-test.html:
  • media/video-poster-delayed.html:
  • media/video-poster-scale.html:
  • media/video-poster.html:
  • media/video-preload.html:
  • media/video-replaces-poster.html:
  • media/video-reverse-play-duration.html:
  • media/video-seek-by-small-increment.html:
  • media/video-seek-no-src-exception.html:
  • media/video-seek-past-end-paused.html:
  • media/video-seek-past-end-playing.html:
  • media/video-seekable.html:
  • media/video-seeking.html:
  • media/video-size-intrinsic-scale.html:
  • media/video-size.html:
  • media/video-source-error-no-candidate.html:
  • media/video-source-error.html:
  • media/video-source-inserted.html:
  • media/video-source-media.html:
  • media/video-source-moved.html:
  • media/video-source-none-supported.html:
  • media/video-source-removed.html:
  • media/video-source-type-params.html:
  • media/video-source-type.html:
  • media/video-source.html:
  • media/video-src-change.html:
  • media/video-src-invalid-remove.html:
  • media/video-src-none.html:
  • media/video-src-plus-source.html:
  • media/video-src-remove.html:
  • media/video-src-set.html:
  • media/video-src-source.html:
  • media/video-src.html:
  • media/video-timeupdate-during-playback.html:
  • media/video-timeupdate-reverse-play.html:
  • media/video-transformed.html:
  • media/video-volume-slider.html:
  • media/video-volume.html:
  • media/video-width-height.html:
  • media/video-zoom-controls.html:
  • media/video-zoom.html:

2011-02-24 James Robinson <jamesr@chromium.org>

Unreviewed, rolling out r79598.
http://trac.webkit.org/changeset/79598
https://bugs.webkit.org/show_bug.cgi?id=55089

Appears to be causing trouble with httpd on windows

  • Scripts/webkitperl/httpd.pm:
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
2:30 PM Changeset in webkit [79622] by mihaip@chromium.org
  • 6 edits
    11 adds in trunk/LayoutTests

2011-02-24 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium Snow Leopard expectations update.

  • platform/chromium-mac/editing/deleting/delete-tab-003-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/delete-tab-003-expected.png: Added.
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-001-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/delete-ws-fixup-001-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-tab-003-expected.checksum: Added.
  • platform/chromium-mac/editing/inserting/insert-tab-003-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-2-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/paste-blockquote-2-expected.png: Added.
  • platform/chromium-mac/editing/selection/replaced-boundaries-3-expected.checksum:
  • platform/chromium-mac/editing/selection/replaced-boundaries-3-expected.png: Added.
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.png: Added.
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium/test_expectations.txt:
2:27 PM Changeset in webkit [79621] by hyatt@apple.com
  • 1 edit in trunk/Source/WebCore/rendering/RenderBox.cpp

Add null check for containing block to stop reflections crash.

2:15 PM Changeset in webkit [79620] by jamesr@google.com
  • 3 edits
    4 deletes in trunk

2011-02-24 James Robinson <jamesr@chromium.org>

Unreviewed, rolling out r79604.
http://trac.webkit.org/changeset/79604
https://bugs.webkit.org/show_bug.cgi?id=55017

Causes assertions to fail on some SVG tests

  • svg/misc/SVGImage-leak-ResourceLoader-expected.txt: Removed.
  • svg/misc/SVGImage-leak-ResourceLoader.html: Removed.
  • svg/misc/resources/load-script.html: Removed.
  • svg/misc/resources/small.png: Removed.

2011-02-24 James Robinson <jamesr@chromium.org>

Unreviewed, rolling out r79604.
http://trac.webkit.org/changeset/79604
https://bugs.webkit.org/show_bug.cgi?id=55017

Causes assertions to fail on some SVG tests

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
2:14 PM Changeset in webkit [79619] by oliver@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix

2:08 PM Changeset in webkit [79618] by hyatt@apple.com
  • 4 edits
    52 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Simon Fraser.

Rework the logical height computation for positioned elements to work in terms of before and after. That way the offset is determined from
the correct container side in flipped block writing modes (e.g., vertical-rl).

Patch locationOffsetIncludingFlipping to use the containing block to flip so that it will behave correctly with absolute/fixed positioned
elements.

Patch offsetFromContainer to use the flipped location offset for absolute/fixed positioned elements so that localToAbsolute works properly.

Added twelve tests in fast/block/positioning/vertical-rl and fast/block/positioning/vertical-lr.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::locationOffsetIncludingFlipping):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::logicalTop):
(WebCore::InheritedFlags::logicalBottom):

LayoutTests:

  • fast/block/positioning/vertical-lr: Added.
  • fast/block/positioning/vertical-lr/001.html: Added.
  • fast/block/positioning/vertical-lr/002.html: Added.
  • fast/block/positioning/vertical-lr/003.html: Added.
  • fast/block/positioning/vertical-lr/004.html: Added.
  • fast/block/positioning/vertical-lr/005.html: Added.
  • fast/block/positioning/vertical-lr/006.html: Added.
  • fast/block/positioning/vertical-rl: Added.
  • fast/block/positioning/vertical-rl/001.html: Added.
  • fast/block/positioning/vertical-rl/002.html: Added.
  • fast/block/positioning/vertical-rl/003.html: Added.
  • fast/block/positioning/vertical-rl/004.html: Added.
  • fast/block/positioning/vertical-rl/005.html: Added.
  • fast/block/positioning/vertical-rl/006.html: Added.
  • platform/mac/fast/block/positioning/vertical-lr: Added.
  • platform/mac/fast/block/positioning/vertical-lr/001-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-lr/001-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-lr/001-expected.txt: Added.
  • platform/mac/fast/block/positioning/vertical-lr/002-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-lr/002-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-lr/002-expected.txt: Added.
  • platform/mac/fast/block/positioning/vertical-lr/003-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-lr/003-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-lr/003-expected.txt: Added.
  • platform/mac/fast/block/positioning/vertical-lr/004-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-lr/004-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-lr/004-expected.txt: Added.
  • platform/mac/fast/block/positioning/vertical-lr/005-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-lr/005-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-lr/005-expected.txt: Added.
  • platform/mac/fast/block/positioning/vertical-lr/006-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-lr/006-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-lr/006-expected.txt: Added.
  • platform/mac/fast/block/positioning/vertical-rl: Added.
  • platform/mac/fast/block/positioning/vertical-rl/001-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-rl/001-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-rl/001-expected.txt: Added.
  • platform/mac/fast/block/positioning/vertical-rl/002-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-rl/002-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-rl/002-expected.txt: Added.
  • platform/mac/fast/block/positioning/vertical-rl/003-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-rl/003-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-rl/003-expected.txt: Added.
  • platform/mac/fast/block/positioning/vertical-rl/004-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-rl/004-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-rl/004-expected.txt: Added.
  • platform/mac/fast/block/positioning/vertical-rl/005-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-rl/005-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-rl/005-expected.txt: Added.
  • platform/mac/fast/block/positioning/vertical-rl/006-expected.checksum: Added.
  • platform/mac/fast/block/positioning/vertical-rl/006-expected.png: Added.
  • platform/mac/fast/block/positioning/vertical-rl/006-expected.txt: Added.
2:04 PM Changeset in webkit [79617] by kbr@google.com
  • 3 edits in trunk/LayoutTests

2011-02-24 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Layout test fast/dom/timer-increase-then-decrease-min-interval.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=55176

Wait twice as long (1 second instead of 0.5 seconds) for results
from these two tests. They were on the verge of passing when
failures occurred previously, so this increase should push them
well over the passing threshold.

  • fast/dom/timer-increase-then-decrease-min-interval-repeating.html:
  • fast/dom/timer-increase-then-decrease-min-interval.html:
1:59 PM Changeset in webkit [79616] by oliver@apple.com
  • 24 edits
    2 deletes in trunk/Source

2011-02-23 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make WeakGCMap use new handle infrastructure
https://bugs.webkit.org/show_bug.cgi?id=55100

Remove old WeakGCMap implementation and move over to new handle
based logic.

This has a number of benefits, most notably it makes a WeakGCMap
always reflect the true state of the world by as all entries are
removed at the first gc cycle that makes them dead. This allows
us to get rid of code in a wide variety of objects where the only
purpose was to remove themselves from maps.

It also means that we no longer need to have special "unchecked"
versions of any functions on WeakGCMap. Alas in order to maintain
compatibility with the JSWeakObjectMapClear API it is still
necessary to have an api that resembles uncheckedRemove, this is
now deprecatedRemove and will be dealt with in a later patch.

In order to get correct semantics in WeakGCMap we need more
contextual information in the finalizer, so we've added an
abstract class based finaliser and a context parameter to the
calls.

The new an improved WeakGCMap also results in sigificantly more
churn in the weak handle lists so exposed some potential problems
during the post mark phase which have been rectified as well.

  • API/JSWeakObjectMapRefPrivate.cpp:
  • API/JSWeakObjectMapRefPrivate.h:
  • runtime/Heap.cpp: (JSC::Heap::globalObjectCount): (JSC::Heap::protectedGlobalObjectCount):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::~JSGlobalObject): (JSC::JSGlobalObject::init):
  • runtime/WeakGCMap.h: (JSC::WeakGCMap::iterator::iterator): (JSC::WeakGCMap::iterator::get): (JSC::WeakGCMap::iterator::getSlot): (JSC::WeakGCMap::iterator::operator++): (JSC::WeakGCMap::iterator::operator==): (JSC::WeakGCMap::iterator::operator!=): (JSC::WeakGCMap::WeakGCMap): (JSC::WeakGCMap::isEmpty): (JSC::WeakGCMap::clear): (JSC::WeakGCMap::get): (JSC::WeakGCMap::getSlot): (JSC::WeakGCMap::set): (JSC::WeakGCMap::take): (JSC::WeakGCMap::size): (JSC::WeakGCMap::deprecatedRemove): (JSC::WeakGCMap::begin): (JSC::WeakGCMap::end): (JSC::WeakGCMap::~WeakGCMap): (JSC::WeakGCMap::finalize):
  • runtime/WeakGCPtr.h: (JSC::WeakGCPtr::WeakGCPtr): (JSC::WeakGCPtr::set):

2011-02-23 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make WeakGCMap use new handle infrastructure
https://bugs.webkit.org/show_bug.cgi?id=55100

Update to new WeakGCMap APIs, this requires threading global
data to a few functions that did not need it in the past, but
also gets rid of a large number of destructors, as well as the
forgetDOMNode, etc APIs.

We can also drop the JSDebugWrapperSet as its only purpose was
to ensure that we retained correct semantics in the old WeakGCMap,
but happilly these semantics are now guaranteed by the map itself.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.cpp: (WebCore::hasCachedDOMObjectWrapperUnchecked): (WebCore::cacheDOMObjectWrapper): (WebCore::hasCachedDOMNodeWrapperUnchecked): (WebCore::cacheDOMNodeWrapper): (WebCore::isObservableThroughDOM): (WebCore::markDOMNodesForDocument): (WebCore::takeWrappers): (WebCore::updateDOMNodeDocument): (WebCore::markDOMObjectWrapper): (WebCore::markDOMNodeWrapper): (WebCore::stringWrapperDestroyed): (WebCore::jsStringSlowCase):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWrapper.cpp: (WebCore::DOMObject::~DOMObject):
  • bindings/js/JSDebugWrapperSet.cpp: Removed.
  • bindings/js/JSDebugWrapperSet.h: Removed.
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/jsc/BridgeJSC.cpp: (JSC::Bindings::Instance::createRuntimeObject):
  • bridge/jsc/BridgeJSC.h:
  • bridge/runtime_object.cpp: (JSC::Bindings::RuntimeObject::~RuntimeObject):
  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::invalidate): (JSC::Bindings::RootObject::addRuntimeObject): (JSC::Bindings::RootObject::removeRuntimeObject):
  • bridge/runtime_root.h:
1:56 PM Changeset in webkit [79615] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Fix clang build.

  • WebCoreSupport/WebKeyGenerator.m:

(toWebCertificateParseResult):
(-[WebKeyGenerator addCertificatesToKeychainFromData:]):

  • WebView/WebTextCompletionController.mm:
1:54 PM Changeset in webkit [79614] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

2011-02-24 James Robinson <jamesr@chromium.org>

Fix chromium compile.

  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::toStringCallback):
1:45 PM Changeset in webkit [79613] by Dimitri Glazkov
  • 12 edits in trunk/Source/WebCore

2011-02-24 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r79607.
http://trac.webkit.org/changeset/79607
https://bugs.webkit.org/show_bug.cgi?id=55157

Broke Chromium layout tests.

  • html/shadow/MediaControls.cpp: (WebCore::MediaControls::updateVolumeSliderContainer):
  • rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton):
  • rendering/RenderMediaControls.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton):
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton):
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton):
  • rendering/RenderThemeWin.h:
1:37 PM Changeset in webkit [79612] by weinig@apple.com
  • 15 edits
    6 adds in trunk/Tools

Add basic pixel testing support to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=55161

Reviewed by Darin Adler.

  • Scripts/old-run-webkit-tests:

Don't print color space information when using WebKitTestRunner since
we don't need to change the screen.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::initialize):
Add call to initializePlatformDefaults.

(WTR::InjectedBundle::done):
Return a dictionary on completion with both the text output and pixel dump override.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

Add declaration for initializePlatformDefaults.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::LayoutTestController):
(WTR::LayoutTestController::dumpAsText):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::shouldDumpPixels):
Make setting dumpAsText override the dump pixels preference.

  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: Added.

(WTR::InjectedBundle::initializePlatformDefaults):
Set platform defaults matching DumpRenderTree.

  • WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Added.

(WTR::InjectedBundle::initializePlatformDefaults):

  • WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Added.

(WTR::InjectedBundle::initializePlatformDefaults):
Add stubs for initializePlatformDefaults.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::runTest):
(WTR::TestController::runTestingServerLoop):
(WTR::TestController::run):
Parse expected pixel results out of stdin and setup the invocation with it.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::TestInvocation):
Initialize new members.

(WTR::TestInvocation::~TestInvocation):
(WTR::TestInvocation::setIsPixelTest):
(WTR::sizeWebViewForCurrentTest):
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::dump):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

  • WebKitTestRunner/TestInvocation.h:

Dump pixels in addition to text by calling dumpPixelsAndCompareWithExpected.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):
Use -[NSColorSpace genericRGBColorSpace] instead of the main screen color space.

  • WebKitTestRunner/mac/TestInvocationMac.mm: Added.

(WTR::createCGContextFromPlatformView):
(WTR::computeMD5HashStringForContext):
(WTR::dumpBitmap):
(WTR::forceRepaintFunction):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
Add mac specific pixel dumping support. Right now, we always pull pixels
from the window server.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  • WebKitTestRunner/qt/WebKitTestRunner.pro:
  • WebKitTestRunner/win/InjectedBundle.vcproj:
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:

Add new files.

1:31 PM Changeset in webkit [79611] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Fix the clang -Woverloaded-virtual build.

Reviewed by Sam Weinig.

JSLocation has a toString function which conflicts with the virtual JSObject::toString member function.
Fix this by renaming the implementation function from JSLocation::toString to JSLocation::toStringFunction.

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::toStringFunction):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::toStringFunctionCallback):

  • page/Location.idl:
1:31 PM Changeset in webkit [79610] by chang.shu@nokia.com
  • 4 edits in trunk/Tools

2011-02-24 Chang Shu <cshu@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Launch MiniBrowser if the test run is WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=55145

  • Scripts/old-run-webkit-tests:
  • Scripts/run-launcher:
  • Scripts/webkitdirs.pm:
1:24 PM Changeset in webkit [79609] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix clang build.

  • bindings/objc/WebScriptObject.mm:

(-[WebUndefined release]):
Release should be "oneway void".

(-[WebUndefined retainCount]):
Return NSUIntegerMax instead of UINT_MAX.

1:23 PM Changeset in webkit [79608] by mihaip@chromium.org
  • 8 edits in trunk/LayoutTests

2011-02-24 Mihai Parparita <mihaip@chromium.org>

Unreviewed Leopard baseline update for some text tests after r78846
(Snow Leopard baselines were updated with r78862). chromium-mac (the
Leopard bot) should be passing with the mac-leopard baselines.

  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/editing/selection/move-past-trailing-space-expected.checksum:
  • platform/mac-leopard/editing/selection/move-past-trailing-space-expected.png:
  • platform/mac-leopard/fast/text/trailing-white-space-2-expected.checksum:
  • platform/mac-leopard/fast/text/trailing-white-space-2-expected.png:
  • platform/mac-leopard/fast/text/trailing-white-space-expected.checksum:
  • platform/mac-leopard/fast/text/trailing-white-space-expected.png:
1:10 PM Changeset in webkit [79607] by Dimitri Glazkov
  • 12 edits in trunk/Source/WebCore

2011-02-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Simplify RenderTheme::volumeSliderOffsetFromMuteButton, unduplicate code.
https://bugs.webkit.org/show_bug.cgi?id=55157

Refactoring, no functional changes. Covered by existing tests.

RenderTheme::volumeSliderOffsetFromMuteButton has the same duplicated
logic for all platforms. This patch:
a) moves the common logic of determining absolute positioning to a

platform-agnostic place;

b) simplifies the method to return constant offset.

  • html/shadow/MediaControls.cpp: (WebCore::volumeSliderOffset): Added new helper function,

capturing common logic of finding the absolute position of the volume slider.

(WebCore::MediaControls::updateVolumeSliderContainer): Changed to use the

new helper.

  • rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::volumeSliderOffsetRelativeToMuteButton): Simplified.
  • rendering/RenderMediaControls.h: Ditto.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::volumeSliderOffsetRelativeToMuteButton): Ditto.
  • rendering/RenderTheme.h: Ditto.
  • rendering/RenderThemeChromiumMac.h: Ditto.
  • rendering/RenderThemeChromiumMac.mm: Ditto. (WebCore::RenderThemeChromiumMac::volumeSliderOffsetRelativeToMuteButton): Ditto.
  • rendering/RenderThemeMac.h: Ditto.
  • rendering/RenderThemeMac.mm: Ditto. (WebCore::RenderThemeMac::volumeSliderOffsetRelativeToMuteButton): Ditto.
  • rendering/RenderThemeWin.cpp: Ditto. (WebCore::RenderThemeWin::volumeSliderOffsetRelativeToMuteButton): Ditto.
  • rendering/RenderThemeWin.h: Ditto.
1:06 PM Changeset in webkit [79606] by jschuh@chromium.org
  • 5 edits
    2 adds in trunk

2011-02-24 Tom Sepez <tsepez@chromium.org>

Reviewed by Darin Fisher.

Add test for frame removal during resize event handler. Update
other tests to account for async onresize event disptach.
https://bugs.webkit.org/show_bug.cgi?id=54467

  • fast/dynamic/paused-event-dispatch.html:
  • fast/events/resize-subframe.html:
  • fast/replaced/frame-removed-during-resize-smaller-expected.txt: Added.
  • fast/replaced/frame-removed-during-resize-smaller.html: Added.

2011-02-24 Tom Sepez <tsepez@chromium.org>

Reviewed by Darin Fisher.

Make frameview resized event dispatch async so that it occurs
after layout has completed.


https://bugs.webkit.org/show_bug.cgi?id=54467
Test: fast/replaced/frame-removed-during-resize-smaller.html

  • page/EventHandler.cpp: (WebCore::EventHandler::sendResizeEvent):
1:03 PM Changeset in webkit [79605] by scherkus@chromium.org
  • 7 edits in branches/chromium/648/Source

Merge 78787 - 2011-02-16 Victoria Kirst <vrk@google.com>

Reviewed by Kenneth Russell.

[chromium] Fix green pixels at edge of certain GPU-accelerated videos
https://bugs.webkit.org/show_bug.cgi?id=54559

Adds logic to properly resize the range of YUV textures to only
select legitimate values.

  • platform/graphics/chromium/VideoFrameChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::SharedValues::SharedValues): (WebCore::VideoLayerChromium::allocateTexturesIfNeeded): (WebCore::VideoLayerChromium::drawYUV):
  • platform/graphics/chromium/VideoLayerChromium.h: (WebCore::VideoLayerChromium::SharedValues::yWidthScaleFactorLocation): (WebCore::VideoLayerChromium::SharedValues::uvWidthScaleFactorLocation):

2011-02-16 Victoria Kirst <vrk@google.com>

Reviewed by Kenneth Russell.

[chromium] Fix green pixels at edge of certain GPU-accelerated videos
https://bugs.webkit.org/show_bug.cgi?id=54559

  • src/VideoFrameChromiumImpl.cpp: (WebKit::VideoFrameChromiumImpl::width): (WebKit::VideoFrameChromiumImpl::height): (WebKit::VideoFrameChromiumImpl::requiredTextureSize): (WebKit::VideoFrameChromiumImpl::hasPaddingBytes):
  • src/VideoFrameChromiumImpl.h:

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6578030

12:57 PM Changeset in webkit [79604] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

2011-02-24 Xianzhu Wang <wangxianzhu@google.com>

Reviewed by Adam Barth.

Add a test to ensure SVGImage won't cause ResourceLoader leaks.
https://bugs.webkit.org/show_bug.cgi?id=55017

  • svg/misc: Added.
  • svg/misc/SVGImage-leak-ResourceLoader-expected.txt: Added.
  • svg/misc/SVGImage-leak-ResourceLoader.html: Added.
  • svg/misc/resources: Added.
  • svg/misc/resources/load-script.html: Added.
  • svg/misc/resources/small.png: Added.

2011-02-24 Xianzhu Wang <wangxianzhu@google.com>

Reviewed by Adam Barth.

Use loader->init() instead of loader->load() to avoid complex fake
request loading and cleanup logic, and also avoid ResourceLoader leaks.

https://bugs.webkit.org/show_bug.cgi?id=55017

Test: svg/misc/SVGImage-leak-ResourceLoader.html

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
12:45 PM Changeset in webkit [79603] by commit-queue@webkit.org
  • 27 edits
    6 copies
    1 add in trunk/LayoutTests

2011-02-24 Anna Cavender <annacc@chromium.org>

Reviewed by Mihai Parparita.

Rebaselines for media tests under snowleopard.
https://bugs.webkit.org/show_bug.cgi?id=54994

  • platform/chromium-mac-leopard/media/audio-repaint-expected.checksum: Copied from LayoutTests/platform/chromium-mac/media/audio-repaint-expected.checksum.
  • platform/chromium-mac-leopard/media/audio-repaint-expected.png: Copied from LayoutTests/platform/chromium-mac/media/audio-repaint-expected.png.
  • platform/chromium-mac-leopard/media/audio-repaint-expected.txt: Added.
  • platform/chromium-mac-leopard/media/video-aspect-ratio-expected.checksum: Copied from LayoutTests/platform/chromium-mac/media/video-aspect-ratio-expected.checksum.
  • platform/chromium-mac-leopard/media/video-aspect-ratio-expected.png: Copied from LayoutTests/platform/chromium-mac/media/video-aspect-ratio-expected.png.
  • platform/chromium-mac-leopard/media/video-zoom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/media/video-zoom-expected.checksum.
  • platform/chromium-mac-leopard/media/video-zoom-expected.png: Copied from LayoutTests/platform/chromium-mac/media/video-zoom-expected.png.
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/audio-repaint-expected.checksum:
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.checksum:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-strict-expected.checksum:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.txt:
  • platform/chromium-mac/media/controls-styling-expected.checksum:
  • platform/chromium-mac/media/controls-styling-expected.png:
  • platform/chromium-mac/media/controls-styling-expected.txt:
  • platform/chromium-mac/media/controls-without-preload-expected.checksum:
  • platform/chromium-mac/media/controls-without-preload-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.checksum:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/media/video-aspect-ratio-expected.checksum:
  • platform/chromium-mac/media/video-aspect-ratio-expected.png:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium-mac/media/video-zoom-controls-expected.checksum:
  • platform/chromium-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-mac/media/video-zoom-expected.checksum:
  • platform/chromium-mac/media/video-zoom-expected.png:
  • platform/chromium/test_expectations.txt:
12:30 PM Changeset in webkit [79602] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-02-24 Dimitri Glazkov <Dimitri Glazkov>

Chromium Mac build fix after r79591.

  • WebCore.gypi: Added RenderMediaControls to WebCore.gypi.
12:09 PM Changeset in webkit [79601] by oliver@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

2011-02-24 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Make weaklist processing deal with weak handles being removed during the iteration
https://bugs.webkit.org/show_bug.cgi?id=55105

It is possible for the handle heap to end up in a broken state if
a handle's finalizer removes either the current or next handle
to be visited during the post-gc cleanup. This patch removes that
problem by allowing the deallocate(Node*) routine to update the
iterator if it is called during finalization.

  • collector/handles/HandleHeap.cpp: (JSC::HandleHeap::HandleHeap): (JSC::HandleHeap::updateAfterMark): (JSC::HandleHeap::clearWeakPointers): (JSC::HandleHeap::writeBarrier): (JSC::HandleHeap::protectedGlobalObjectCount):
  • collector/handles/HandleHeap.h: (JSC::Finalizer::~Finalizer): (JSC::HandleHeap::getFinalizer): (JSC::HandleHeap::deallocate): (JSC::HandleHeap::makeWeak): (JSC::HandleHeap::makeSelfDestroying): (JSC::HandleHeap::Node::Node): (JSC::HandleHeap::Node::setFinalizer): (JSC::HandleHeap::Node::finalizer): (JSC::HandleHeap::Node::finalizerContext):
  • interpreter/RegisterFile.cpp: (JSC::RegisterFile::setGlobalObject): (JSC::GlobalObjectNotifier::finalize): (JSC::RegisterFile::globalObjectCollectedNotifier):
  • interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile):
  • runtime/Heap.cpp: (JSC::Heap::destroy):
  • runtime/WeakGCPtr.h: (JSC::WeakGCPtr::WeakGCPtr): (JSC::WeakGCPtr::set):
11:54 AM Changeset in webkit [79600] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-24 James Kozianski <koz@chromium.org>

Reviewed by Ojan Vafai.

Add missing plumbing for registerProtocolHandler in ChromeClientImpl.
https://bugs.webkit.org/show_bug.cgi?id=55112

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::registerProtocolHandler):
11:46 AM Changeset in webkit [79599] by jamesr@google.com
  • 5 edits
    8 adds in trunk/LayoutTests

2011-02-24 James Robinson <jamesr@chromium.org>

Update chromium test expectations.

  • platform/chromium-linux/media/video-display-toggle-expected.checksum:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/transitions/default-timing-function-expected.checksum: Added.
  • platform/chromium-linux/transitions/default-timing-function-expected.png: Added.
  • platform/chromium-win/media/video-display-toggle-expected.checksum:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/transitions/default-timing-function-expected.checksum: Added.
  • platform/chromium-win/transitions/default-timing-function-expected.png: Added.
  • platform/chromium-win/transitions/default-timing-function-expected.txt: Added.
  • platform/chromium/inspector/debugger/dom-breakpoints-expected.txt: Added.
  • platform/mac-leopard/transitions/default-timing-function-expected.checksum: Added.
  • platform/mac-leopard/transitions/default-timing-function-expected.png: Added.
11:42 AM Changeset in webkit [79598] by mihaip@chromium.org
  • 145 edits
    2 moves in trunk

2011-02-24 Victoria Kirst <vrk@google.com>

Reviewed by Mihai Parparita.

[chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
https://bugs.webkit.org/show_bug.cgi?id=55089

Media's UILayoutTests rely on video-test.js and media-file.js to be in
the media/ folder.

  • http/tests/media/pdf-served-as-pdf.html:
  • http/tests/media/reload-after-dialog.html:
  • http/tests/media/remove-while-loading.html:
  • http/tests/media/text-served-as-text.html:
  • http/tests/media/video-buffered.html:
  • http/tests/media/video-cancel-load.html:
  • http/tests/media/video-cookie.html:
  • http/tests/media/video-error-abort.html:
  • http/tests/media/video-load-twice.html:
  • http/tests/media/video-play-stall-seek.html:
  • http/tests/media/video-play-stall.html:
  • http/tests/media/video-play-suspend.html:
  • http/tests/media/video-referer.html:
  • http/tests/media/video-seekable-stall.html:
  • http/tests/media/video-served-as-text.html:
  • media/adopt-node-crash.html:
  • media/audio-constructor-preload.html:
  • media/audio-constructor-src.html:
  • media/audio-constructor.html:
  • media/audio-controls-rendering.html:
  • media/audio-data-url.html:
  • media/audio-delete-while-slider-thumb-clicked.html:
  • media/audio-delete-while-step-button-clicked.html:
  • media/audio-mpeg-supported.html:
  • media/audio-mpeg4-supported.html:
  • media/audio-play-event.html:
  • media/before-load-member-access.html:
  • media/broken-video.html:
  • media/constructors.html:
  • media/context-menu-actions.html:
  • media/controls-after-reload.html:
  • media/controls-css-overload.html:
  • media/controls-drag-timebar.html:
  • media/controls-right-click-on-timebar.html:
  • media/controls-strict.html:
  • media/controls-styling.html:
  • media/controls-without-preload.html:
  • media/event-attributes.html:
  • media/invalid-media-url-crash.html:
  • media/media-can-play-mpeg-audio.html:
  • media/media-can-play-mpeg4-video.html:
  • media/media-can-play-octet-stream.html:
  • media/media-can-play-ogg.html:
  • media/media-can-play-wav-audio.html:
  • media/media-captions.html:
  • media/media-constants.html:
  • media/media-file.js: Renamed from LayoutTests/http/tests/media/media-file.js.
  • media/media-fullscreen-inline.html:
  • media/media-fullscreen-not-in-document.html:
  • media/media-load-event.html:
  • media/media-startTime.html:
  • media/remove-from-document-no-load.html:
  • media/remove-from-document.html:
  • media/restore-from-page-cache.html:
  • media/unsupported-rtsp.html:
  • media/unsupported-tracks.html:
  • media/video-append-source.html:
  • media/video-aspect-ratio.html:
  • media/video-autoplay.html:
  • media/video-buffered.html:
  • media/video-can-play-type.html:
  • media/video-canvas-alpha.html:
  • media/video-canvas-source.html:
  • media/video-click-dblckick-standalone.html:
  • media/video-controls-rendering.html:
  • media/video-controls-transformed.html:
  • media/video-controls-visible-audio-only.html:
  • media/video-controls-zoomed.html:
  • media/video-controls.html:
  • media/video-currentTime-delay.html:
  • media/video-currentTime-set.html:
  • media/video-currentTime-set2.html:
  • media/video-currentTime.html:
  • media/video-delay-load-event.html:
  • media/video-display-aspect-ratio.html:
  • media/video-display-none-crash.html:
  • media/video-display-toggle.html:
  • media/video-does-not-loop.html:
  • media/video-dom-autoplay.html:
  • media/video-dom-preload.html:
  • media/video-dom-src.html:
  • media/video-duration-known-after-eos.html:
  • media/video-error-does-not-exist.html:
  • media/video-frame-accurate-seek.html:
  • media/video-layer-crash.html:
  • media/video-load-networkState.html:
  • media/video-load-readyState.html:
  • media/video-loop.html:
  • media/video-muted.html:
  • media/video-no-audio.html:
  • media/video-no-autoplay.html:
  • media/video-pause-empty-events.html:
  • media/video-pause-immediately.html:
  • media/video-play-empty-events.html:
  • media/video-play-pause-events.html:
  • media/video-play-pause-exception.html:
  • media/video-played-collapse.html:
  • media/video-played-ranges-1.html:
  • media/video-played-reset.html:
  • media/video-poster-delayed.html:
  • media/video-poster-scale.html:
  • media/video-poster.html:
  • media/video-preload.html:
  • media/video-replaces-poster.html:
  • media/video-reverse-play-duration.html:
  • media/video-seek-by-small-increment.html:
  • media/video-seek-no-src-exception.html:
  • media/video-seek-past-end-paused.html:
  • media/video-seek-past-end-playing.html:
  • media/video-seekable.html:
  • media/video-seeking.html:
  • media/video-size-intrinsic-scale.html:
  • media/video-size.html:
  • media/video-source-error-no-candidate.html:
  • media/video-source-error.html:
  • media/video-source-inserted.html:
  • media/video-source-media.html:
  • media/video-source-moved.html:
  • media/video-source-none-supported.html:
  • media/video-source-removed.html:
  • media/video-source-type-params.html:
  • media/video-source-type.html:
  • media/video-source.html:
  • media/video-src-change.html:
  • media/video-src-invalid-remove.html:
  • media/video-src-none.html:
  • media/video-src-plus-source.html:
  • media/video-src-remove.html:
  • media/video-src-set.html:
  • media/video-src-source.html:
  • media/video-src.html:
  • media/video-test.js: Renamed from LayoutTests/http/tests/media/video-test.js.
  • media/video-timeupdate-during-playback.html:
  • media/video-timeupdate-reverse-play.html:
  • media/video-transformed.html:
  • media/video-volume-slider.html:
  • media/video-volume.html:
  • media/video-width-height.html:
  • media/video-zoom-controls.html:
  • media/video-zoom.html:

2011-02-24 Victoria Kirst <vrk@google.com>

Reviewed by Mihai Parparita.

[chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
https://bugs.webkit.org/show_bug.cgi?id=55089

This adds an alias into the media/ directory so that http/tests/media
tests can access the media resources when running in an httpd process.

  • Scripts/webkitperl/httpd.pm:
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
11:40 AM Changeset in webkit [79597] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

2011-02-24 Anna Cavender <annacc@chromium.org>

Reviewed by Ojan Vafai.

rebaseline for media/video-controls-rendering.html on mac
https://bugs.webkit.org/show_bug.cgi?id=55108

  • platform/chromium-mac/media/video-controls-rendering-expected.checksum:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.txt:
  • platform/chromium/test_expectations.txt:
11:35 AM Changeset in webkit [79596] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=55165
Can call CF API with a null CFArray in WebResourceCacheManager

Reviewed by Adam Roben and looked at by Brian Weinstein.

  • WebProcess/ResourceCache/WebResourceCacheManager.cpp:

(WebKit::WebResourceCacheManager::getCacheOrigins): cfURLCacheHostNames() can return a null CFArrayRef,

so the call to CFArrayGetCount must be null checked.

11:31 AM Changeset in webkit [79595] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-24 Misha Tyutyunik <michael.tyutyunik@nokia.com>

Reviewed by Andreas Kling.

[Qt] Dont use QPixmapCache if QPixmapCache::cacheLimit() is too small
(2048Kb for now).
https://bugs.webkit.org/show_bug.cgi?id=54887

No new tests required.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::allowAcceleratedCompositingCache): (WebCore::GraphicsLayerQtImpl::drawLayerContent): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges):
11:25 AM Changeset in webkit [79594] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-24 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

PatternAlternative leaked in YarrPatternConstructor::atomParenthesesEnd()
https://bugs.webkit.org/show_bug.cgi?id=55156

Added code to delete unneeded PatternAlternative after it is removed
from m_alternatives Vector.

  • yarr/YarrPattern.cpp: (JSC::Yarr::YarrPatternConstructor::atomParenthesesEnd):
11:25 AM Changeset in webkit [79593] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-02-24 Anders Carlsson <andersca@apple.com>

Reviewed by Simon Fraser.

ASSERTION FAILED: !isInAcceleratedCompositingMode() when entering accelerated compositing early
https://bugs.webkit.org/show_bug.cgi?id=55162
<rdar://problem/9048523>

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::updateState): Call setShouldNotifyAfterNextScheduledLayerFlush(false) so the web process process won't send an EnterAcceleratedCompositingMode message.

(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
setShouldNotifyAfterNextScheduledLayerFlush now takes a boolean.

  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::setShouldNotifyAfterNextScheduledLayerFlush): Make this take a boolean.
11:00 AM Changeset in webkit [79592] by mrobinson@webkit.org
  • 104 edits
    2 copies
    46 adds in trunk

2011-02-20 Martin Robinson <mrobinson@igalia.com>

Reviewed by Nikolas Zimmermann.

[CAIRO] Support ImageBuffers clip operation on all Cairo ports
https://bugs.webkit.org/show_bug.cgi?id=23526

Update results for tests which are now passing and unskip them.

  • platform/gtk/Skipped: Unskip tests which are now passing.
  • platform/gtk/fast/backgrounds/animated-svg-as-mask-expected.checksum: Added.
  • platform/gtk/fast/backgrounds/animated-svg-as-mask-expected.png: Added.
  • platform/gtk/fast/backgrounds/animated-svg-as-mask-expected.txt: Added.
  • platform/gtk/fast/backgrounds/svg-as-mask-expected.checksum: Added.
  • platform/gtk/fast/backgrounds/svg-as-mask-expected.png: Added.
  • platform/gtk/fast/backgrounds/svg-as-mask-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • platform/gtk/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
  • platform/gtk/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum: Added.
  • platform/gtk/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
  • platform/gtk/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • platform/gtk/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/masking-path-01-b-expected.checksum:
  • platform/gtk/svg/W3C-SVG-1.1/masking-path-01-b-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum:
  • platform/gtk/svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
  • platform/gtk/svg/batik/masking/maskRegions-expected.checksum:
  • platform/gtk/svg/batik/masking/maskRegions-expected.png:
  • platform/gtk/svg/batik/text/textEffect2-expected.checksum:
  • platform/gtk/svg/batik/text/textEffect2-expected.png:
  • platform/gtk/svg/clip-path/clip-in-mask-expected.checksum:
  • platform/gtk/svg/clip-path/clip-in-mask-expected.png:
  • platform/gtk/svg/clip-path/clip-in-mask-objectBoundingBox-expected.checksum:
  • platform/gtk/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png:
  • platform/gtk/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.checksum:
  • platform/gtk/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png:
  • platform/gtk/svg/clip-path/clip-path-child-clipped-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-child-clipped-expected.png:
  • platform/gtk/svg/clip-path/clip-path-childs-clipped-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-childs-clipped-expected.png:
  • platform/gtk/svg/clip-path/clip-path-clipped-evenodd-twice-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png:
  • platform/gtk/svg/clip-path/clip-path-clipped-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-clipped-expected.png:
  • platform/gtk/svg/clip-path/clip-path-clipped-no-content-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-clipped-no-content-expected.png:
  • platform/gtk/svg/clip-path/clip-path-clipped-nonzero-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-clipped-nonzero-expected.png:
  • platform/gtk/svg/clip-path/clip-path-evenodd-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-evenodd-expected.png:
  • platform/gtk/svg/clip-path/clip-path-evenodd-nonzero-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-evenodd-nonzero-expected.png:
  • platform/gtk/svg/clip-path/clip-path-nonzero-evenodd-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-nonzero-evenodd-expected.png:
  • platform/gtk/svg/clip-path/clip-path-nonzero-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-nonzero-expected.png:
  • platform/gtk/svg/clip-path/clip-path-pixelation-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-pixelation-expected.png:
  • platform/gtk/svg/clip-path/clip-path-text-and-shape-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-text-and-shape-expected.png:
  • platform/gtk/svg/clip-path/clip-path-text-and-stroke-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-text-and-stroke-expected.png:
  • platform/gtk/svg/clip-path/clip-path-text-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-text-expected.png:
  • platform/gtk/svg/clip-path/clip-path-use-as-child2-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-use-as-child2-expected.png:
  • platform/gtk/svg/clip-path/clip-path-use-as-child3-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-use-as-child3-expected.png:
  • platform/gtk/svg/clip-path/clip-path-use-as-child4-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-use-as-child4-expected.png:
  • platform/gtk/svg/clip-path/clip-path-with-different-unittypes-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-with-different-unittypes-expected.png:
  • platform/gtk/svg/clip-path/clip-path-with-different-unittypes2-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-with-different-unittypes2-expected.png:
  • platform/gtk/svg/clip-path/clip-path-with-text-clipped-expected.checksum:
  • platform/gtk/svg/clip-path/clip-path-with-text-clipped-expected.png:
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.checksum:
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png:
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-expected.checksum:
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-expected.png:
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-panning-expected.checksum:
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png:
  • platform/gtk/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.checksum:
  • platform/gtk/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png:
  • platform/gtk/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.checksum:
  • platform/gtk/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png:
  • platform/gtk/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.checksum:
  • platform/gtk/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png:
  • platform/gtk/svg/css/circle-in-mask-with-shadow-expected.checksum: Added.
  • platform/gtk/svg/css/circle-in-mask-with-shadow-expected.png: Added.
  • platform/gtk/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
  • platform/gtk/svg/css/clippath-with-shadow-expected.checksum: Added.
  • platform/gtk/svg/css/clippath-with-shadow-expected.png: Added.
  • platform/gtk/svg/css/clippath-with-shadow-expected.txt: Added.
  • platform/gtk/svg/custom/absolute-sized-content-with-resources-expected.checksum: Added.
  • platform/gtk/svg/custom/absolute-sized-content-with-resources-expected.png: Added.
  • platform/gtk/svg/custom/absolute-sized-content-with-resources-expected.txt: Added.
  • platform/gtk/svg/custom/circular-marker-reference-2-expected.txt:
  • platform/gtk/svg/custom/js-late-mask-and-object-creation-expected.checksum:
  • platform/gtk/svg/custom/js-late-mask-and-object-creation-expected.png:
  • platform/gtk/svg/custom/js-late-mask-creation-expected.checksum:
  • platform/gtk/svg/custom/js-late-mask-creation-expected.png:
  • platform/gtk/svg/custom/marker-child-changes-css-expected.checksum: Added.
  • platform/gtk/svg/custom/marker-child-changes-css-expected.png: Copied from LayoutTests/platform/gtk/svg/custom/mask-changes-expected.png.
  • platform/gtk/svg/custom/marker-child-changes-css-expected.txt: Added.
  • platform/gtk/svg/custom/mask-changes-expected.checksum:
  • platform/gtk/svg/custom/mask-changes-expected.png:
  • platform/gtk/svg/custom/mask-child-changes-expected.checksum:
  • platform/gtk/svg/custom/mask-child-changes-expected.png:
  • platform/gtk/svg/custom/mask-colorspace-expected.checksum: Added.
  • platform/gtk/svg/custom/mask-colorspace-expected.png: Added.
  • platform/gtk/svg/custom/mask-colorspace-expected.txt: Added.
  • platform/gtk/svg/custom/mask-inside-defs-expected.checksum:
  • platform/gtk/svg/custom/mask-inside-defs-expected.png:
  • platform/gtk/svg/custom/mask-on-multiple-objects-expected.checksum: Added.
  • platform/gtk/svg/custom/mask-on-multiple-objects-expected.png: Added.
  • platform/gtk/svg/custom/mask-on-multiple-objects-expected.txt: Added.
  • platform/gtk/svg/custom/mask-with-all-units-expected.checksum:
  • platform/gtk/svg/custom/mask-with-all-units-expected.png:
  • platform/gtk/svg/custom/non-circular-marker-reference-expected.txt:
  • platform/gtk/svg/custom/recursive-mask-expected.checksum: Added.
  • platform/gtk/svg/custom/recursive-mask-expected.png: Added.
  • platform/gtk/svg/custom/recursive-mask-expected.txt:
  • platform/gtk/svg/custom/visibility-override-mask-expected.checksum:
  • platform/gtk/svg/custom/visibility-override-mask-expected.png:
  • platform/gtk/svg/filters/feGaussianBlur-expected.checksum: Added.
  • platform/gtk/svg/filters/feGaussianBlur-expected.png: Added.
  • platform/gtk/svg/filters/feGaussianBlur-expected.txt: Added.
  • platform/gtk/svg/filters/filter-clip-expected.checksum: Added.
  • platform/gtk/svg/filters/filter-clip-expected.png: Added.
  • platform/gtk/svg/filters/filter-clip-expected.txt: Added.
  • platform/gtk/svg/filters/shadow-on-filter-expected.checksum: Added.
  • platform/gtk/svg/filters/shadow-on-filter-expected.png: Added.
  • platform/gtk/svg/filters/shadow-on-filter-expected.txt: Added.
  • platform/gtk/svg/filters/shadow-on-rect-with-filter-expected.checksum: Added.
  • platform/gtk/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
  • platform/gtk/svg/filters/shadow-on-rect-with-filter-expected.txt: Added.
  • platform/gtk/svg/transforms/text-with-mask-with-svg-transform-expected.checksum: Added.
  • platform/gtk/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
  • platform/gtk/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
  • platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
  • platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.txt:

2011-02-20 Martin Robinson <mrobinson@igalia.com>

Reviewed by Nikolas Zimmermann.

[CAIRO] Support ImageBuffers clip operation on all Cairo ports
https://bugs.webkit.org/show_bug.cgi?id=23526

Add support for ImageBuffer clipping on Cairo by emulating them with image
masks. Since masking is immediate on Cairo, we must store the mask surfaces
on a stack and apply them during restorePlatformState.

  • platform/graphics/GraphicsContext.h: Add pushImageMask.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::savePlatformState): Push an empty mask onto the stack, so we can keep track of when to actually apply the image mask. (WebCore::GraphicsContext::restorePlatformState): When we are ready to apply an image mask, use cairo_mask_surface to mask the group that we pushed onto our surface. (WebCore::GraphicsContext::pushImageMask): Added. This method will push a surface onto the image mask stack and push a group onto the Cairo state, so that the masking only affects what we paint after this point.
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: Added a class to keep track of image masking information after calls to pushImageMask. (WebCore::ImageMaskInformation::update): Added (WebCore::ImageMaskInformation::valid): Added (WebCore::ImageMaskInformation::maskSurface): Added (WebCore::ImageMaskInformation::maskRect): Added
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::clip): Call GraphicsContext::pushImageMask.
10:54 AM Changeset in webkit [79591] by Dimitri Glazkov
  • 5 edits in trunk/Source/WebCore

2011-02-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Carlson.

Add RenderMediaControls to Mac build, unduplicate one method.
https://bugs.webkit.org/show_bug.cgi?id=55152

Refactoring, no functional changes.

  • WebCore.xcodeproj/project.pbxproj: Added RenderMediaControls to project,

ran sort-XCode-project-file.

  • rendering/RenderMediaControls.cpp: Moved ENABLE(VIDEO) and PLATFORM(WIN)

defines to allow building on Mac.

  • rendering/RenderMediaControls.h: Ditto.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton): Replaced guts

with a call to RenderMediaControls function.

10:44 AM Changeset in webkit [79590] by eric@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-24 Eric Seidel <eric@webkit.org>

Reviewed by Anders Carlsson.

VectorBuffer should not call malloc(0)
https://bugs.webkit.org/show_bug.cgi?id=55091

Turns out the malloc() call which was so hot in:
https://bugs.webkit.org/show_bug.cgi?id=55005
was actually just malloc(0).

We shouldn't be calling malloc(0) anyway, since there is no need to
and it might actually do work on some systems.
I believe on Mac it ends up taking the standard spinlocks (expensive)
and the code on Brew actually does a malloc(1) instead. Neither is desirable.

  • wtf/Vector.h: (WTF::VectorBufferBase::allocateBuffer): (WTF::VectorBufferBase::tryAllocateBuffer):
10:42 AM Changeset in webkit [79589] by commit-queue@webkit.org
  • 23 edits in trunk

2011-02-24 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

Drop the "U; " encryption level from the User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54566

  • http/tests/navigation/useragent-expected.txt:
  • http/tests/navigation/useragent.php:

2011-02-24 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

Drop the "U; " encryption level from the User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54566

  • StringsNotToBeLocalized.txt:

2011-02-24 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

Drop the "U; " encryption level from the User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54566

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::composeUserAgent):
  • ewk/ewk_settings.cpp: (ewk_settings_default_user_agent_get):

2011-02-24 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

Drop the "U; " encryption level from the User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54566

  • webkit/webkitwebsettings.cpp: (webkitUserAgent):

2011-02-24 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

Drop the "U; " encryption level from the User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54566

  • WebView/WebView.mm: (+[WebView _standardUserAgentWithApplicationName:]):

2011-02-24 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

Drop the "U; " encryption level from the User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54566

  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):

2011-02-24 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

Drop the "U; " encryption level from the User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54566

  • WebView.cpp: (WebView::standardUserAgentWithApplicationName):

2011-02-24 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

Drop the "U; " encryption level from the User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54566

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::userAgent):

2011-02-24 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

Drop the "U; " encryption level from the User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54566

  • UIProcess/gtk/WebPageProxyGtk.cpp: (WebKit::WebPageProxy::standardUserAgent):
  • UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::standardUserAgent):
  • UIProcess/qt/WebPageProxyQt.cpp: (WebKit::WebPageProxy::standardUserAgent):
  • UIProcess/win/WebPageProxyWin.cpp: (WebKit::WebPageProxy::standardUserAgent):
10:37 AM Changeset in webkit [79588] by jamesr@google.com
  • 10 edits in trunk/Source

2011-02-24 James Robinson <jamesr@chromium.org>

Unreviewed, rolling out r79584.
http://trac.webkit.org/changeset/79584
https://bugs.webkit.org/show_bug.cgi?id=44797

[chromium] Patch does not compile if ENABLE_FULLSCREEN_API is
not set

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

2011-02-24 James Robinson <jamesr@chromium.org>

Unreviewed, rolling out r79584.
http://trac.webkit.org/changeset/79584
https://bugs.webkit.org/show_bug.cgi?id=44797

[chromium] Patch does not compile if ENABLE_FULLSCREEN_API is
not set

  • features.gypi:
  • public/WebSettings.h:
  • src/ChromeClientImpl.cpp:
  • src/ChromeClientImpl.h:
  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:
10:11 AM Changeset in webkit [79587] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

2011-02-24 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

Do not cache the default cairo font options using a static
variable. It fixes a memory leak reported by valgrind.

  • platform/graphics/freetype/FontPlatformDataFreeType.cpp: (WebCore::getDefaultFontOptions): (WebCore::FontPlatformData::initializeWithFontFace):
10:07 AM Changeset in webkit [79586] by atwilson@chromium.org
  • 30 edits in trunk

2011-02-24 Andrew Wilson <atwilson@chromium.org>

Unreviewed, rolling out r79570.
http://trac.webkit.org/changeset/79570
https://bugs.webkit.org/show_bug.cgi?id=54874

Breaks chromium build because glue/mocks/mock_web_frame.h/cc
was not updated

  • WebCore.exp.in:

2011-02-24 Andrew Wilson <atwilson@chromium.org>

Unreviewed, rolling out r79570.
http://trac.webkit.org/changeset/79570
https://bugs.webkit.org/show_bug.cgi?id=54874

Breaks chromium build because glue/mocks/mock_web_frame.h/cc
was not updated

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:

2011-02-24 Andrew Wilson <atwilson@chromium.org>

Unreviewed, rolling out r79570.
http://trac.webkit.org/changeset/79570
https://bugs.webkit.org/show_bug.cgi?id=54874

Breaks chromium build because glue/mocks/mock_web_frame.h/cc
was not updated

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-02-24 Andrew Wilson <atwilson@chromium.org>

Unreviewed, rolling out r79570.
http://trac.webkit.org/changeset/79570
https://bugs.webkit.org/show_bug.cgi?id=54874

Breaks chromium build because glue/mocks/mock_web_frame.h/cc
was not updated

  • WebView/WebFrame.mm:
  • WebView/WebFramePrivate.h:

2011-02-24 Andrew Wilson <atwilson@chromium.org>

Unreviewed, rolling out r79570.
http://trac.webkit.org/changeset/79570
https://bugs.webkit.org/show_bug.cgi?id=54874

Breaks chromium build because glue/mocks/mock_web_frame.h/cc
was not updated

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-02-24 Andrew Wilson <atwilson@chromium.org>

Unreviewed, rolling out r79570.
http://trac.webkit.org/changeset/79570
https://bugs.webkit.org/show_bug.cgi?id=54874

Breaks chromium build because glue/mocks/mock_web_frame.h/cc
was not updated

  • Interfaces/IWebFramePrivate.idl:
  • Interfaces/WebKit.idl:
  • WebFrame.cpp:
  • WebFrame.h:

2011-02-24 Andrew Wilson <atwilson@chromium.org>

Unreviewed, rolling out r79570.
http://trac.webkit.org/changeset/79570
https://bugs.webkit.org/show_bug.cgi?id=54874

Breaks chromium build because glue/mocks/mock_web_frame.h/cc
was not updated

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:

2011-02-24 Andrew Wilson <atwilson@chromium.org>

Unreviewed, rolling out r79570.
http://trac.webkit.org/changeset/79570
https://bugs.webkit.org/show_bug.cgi?id=54874

Breaks chromium build because glue/mocks/mock_web_frame.h/cc
was not updated

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::reset):
10:02 AM Changeset in webkit [79585] by bweinstein@apple.com
  • 20 edits
    9 adds in trunk/Source/WebKit2

Part of WebKit2: Need a way to manage cookies from the web process
https://bugs.webkit.org/show_bug.cgi?id=55086

Reviewed by Adam Roben and looked over by Jessie Berlin.

This patch adds the plumbing and classes that are needed to manage cookies from the web process.
The functions that the API calls are currently stubs, but will be implemented in a follow-up patch.

Project file changes.

  • DerivedSources.make:
  • DerivedSources.pro:
  • GNUmakefile.am:
  • WebKit2.pri:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:
  • win/WebKit2Generated.make:

Add some needed plumbing for WebCookieManager{Proxy}.

  • Platform/CoreIPC/MessageID.h:
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKContext.cpp:

(WKContextGetCookieManager): Gets the cookie manager proxy.

  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKCookieManager.cpp: Added.

(WKCookieManagerGetTypeID):
(WKCookieManagerGetHostnamesWithCookies): Calls through to WebCookieManagerProxy.
(WKCookieManagerDeleteCookiesForHostname): Ditto.
(WKCookieManagerDeleteAllCookies): Ditto.

  • UIProcess/API/C/WKCookieManager.h: Added.
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage): Add a case for the cookie manager.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Initialize the cookie manager.
(WebKit::WebContext::~WebContext): Invalidate the cookie manager.
(WebKit::WebContext::disconnectProcess): Ditto.
(WebKit::WebContext::didReceiveMessage): Add a case for the cookie manager.

  • UIProcess/WebContext.h:

(WebKit::WebContext::cookieManagerProxy): Returns the cookie manager.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage): Add a case for the cookie manager.

  • UIProcess/WebCookieManagerProxy.cpp: Added.

(WebKit::WebCookieManagerProxy::create):
(WebKit::WebCookieManagerProxy::WebCookieManagerProxy):
(WebKit::WebCookieManagerProxy::~WebCookieManagerProxy):
(WebKit::WebCookieManagerProxy::invalidate):
(WebKit::WebCookieManagerProxy::didReceiveMessage):
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies): Call through to the web process to get hostnames with cookies.
(WebKit::WebCookieManagerProxy::didGetHostnamesWithCookies): Call the callback we were passed in getHostnamesWithCookies.
(WebKit::WebCookieManagerProxy::deleteCookiesForHostname): Call through to the web process to delete cookies

for the origin.

(WebKit::WebCookieManagerProxy::deleteAllCookies): Call through to the web process to delete all cookies.

  • UIProcess/WebCookieManagerProxy.h: Added.

(WebKit::WebCookieManagerProxy::clearContext):
(WebKit::WebCookieManagerProxy::type):

  • UIProcess/WebCookieManagerProxy.messages.in: Added.
  • WebProcess/Cookies: Added.
  • WebProcess/Cookies/WebCookieManager.cpp: Added.

(WebKit::WebCookieManager::shared):
(WebKit::WebCookieManager::WebCookieManager):
(WebKit::WebCookieManager::didReceiveMessage): Call through to didReceiveWebCookieManagerMessage.
(WebKit::WebCookieManager::getHostnamesWithCookies): Build an array from a HashSet (that isn't filled yet), and

convert that HashSet to a Vector to send to the UI process.

(WebKit::WebCookieManager::deleteCookiesForHostname): Added a stub.
(WebKit::WebCookieManager::deleteAllCookies): Ditto.

  • WebProcess/Cookies/WebCookieManager.h: Added.
  • WebProcess/Cookies/WebCookieManager.messages.in: Added.
10:00 AM Changeset in webkit [79584] by commit-queue@webkit.org
  • 10 edits in trunk/Source

2011-02-24 David Dorwin <ddorwin@chromium.org>

Reviewed by Eric Seidel.

Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default.

fullscreen javascript bindings not implemented for v8
https://bugs.webkit.org/show_bug.cgi?id=44797

Tested by the existing fullscreen Layout Tests.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

2011-02-24 David Dorwin <ddorwin@chromium.org>

Reviewed by Eric Seidel.

Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default.

fullscreen javascript bindings not implemented for v8
https://bugs.webkit.org/show_bug.cgi?id=44797

  • features.gypi:
  • public/WebSettings.h:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::supportsFullScreenForElement): (WebKit::ChromeClientImpl::enterFullScreenForElement): (WebKit::ChromeClientImpl::exitFullScreenForElement): (WebKit::ChromeClientImpl::fullScreenRendererChanged):
  • src/ChromeClientImpl.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setFullScreenEnabled):
  • src/WebSettingsImpl.h:
9:53 AM Changeset in webkit [79583] by pfeldman@chromium.org
  • 9 edits
    2 adds in trunk

2011-02-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move querySelectorAll from CSS agent to DOM agent where it belongs.
https://bugs.webkit.org/show_bug.cgi?id=55131

  • http/tests/inspector/inspector-test.js:
  • inspector/elements/dom-agent-query-selector-expected.txt: Added.
  • inspector/elements/dom-agent-query-selector.html: Added.

2011-02-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move querySelectorAll from CSS agent to DOM agent where it belongs.
https://bugs.webkit.org/show_bug.cgi?id=55131

Test: inspector/elements/dom-agent-query-selector.html

  • inspector/Inspector.idl:
  • inspector/InspectorCSSAgent.cpp:
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::nodeToSelectOn): (WebCore::InspectorDOMAgent::querySelector): (WebCore::InspectorDOMAgent::querySelectorAll):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback): (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.addRule.callback): (WebInspector.CSSStyleModel.prototype.addRule):
9:50 AM Changeset in webkit [79582] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-24 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Remove obsolete PLATFORM(CI)
https://bugs.webkit.org/show_bug.cgi?id=55082

  • wtf/Platform.h:
9:41 AM Changeset in webkit [79581] by alex
  • 5 edits
    3 adds in trunk/Source

2011-02-24 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> and Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement WebEventFactory, WebErrors classes for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48510

Exported static functions for GTK, we need them to create events
in WebKit2.

  • platform/PlatformKeyboardEvent.h:
  • platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::keyIdentifierForGdkKeyCode): (WebCore::PlatformKeyboardEvent::windowsKeyCodeForGdkKeyCode): (WebCore::PlatformKeyboardEvent::singleCharacterString):

2011-02-24 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> and Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement WebEventFactory, WebErrors classes for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48510

  • GNUmakefile.am:
  • Shared/gtk/WebEventFactory.cpp: Added. implementation for WebMouseEvent, WebWheelEvent, WebKeyboardEvent.
  • Shared/gtk/WebEventFactory.h: Added.
  • WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp: Added. Stubbed implementation for GTK port.
9:38 AM Changeset in webkit [79580] by mrobinson@webkit.org
  • 5 edits in trunk/Source

2011-02-24 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Remove the GFile GOwnPtr specialization
https://bugs.webkit.org/show_bug.cgi?id=55154

Remove the GFile specialization of GOwnPtr. It's sufficient to use GRefPtr
to track GFiles since they are just regular reference-counted GObjects.

  • wtf/gobject/GOwnPtr.cpp: Remove GFile specialization.
  • wtf/gobject/GOwnPtr.h: Ditto.

2011-02-24 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Remove the GFile GOwnPtr specialization
https://bugs.webkit.org/show_bug.cgi?id=55154

Convert uses of GOwnPtr<GFile> to GRefPtr<GFile>.

No new tests. This should not change behavior.

  • plugins/gtk/PluginPackageGtk.cpp: Fix include order and remove unnecessary include. (WebCore::PluginPackage::load): Use GRefPtr for GFile instead of GOwnPtr.
9:37 AM Changeset in webkit [79579] by Adam Roben
  • 2 edits
    2 adds in trunk/LayoutTests

Update Windows XP test results after r78846

  • platform/win-xp/fast/text/backslash-to-yen-sign-euc-expected.checksum: Added.
  • platform/win-xp/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
  • platform/win-xp/fast/text/backslash-to-yen-sign-euc-expected.txt:
9:33 AM Changeset in webkit [79578] by Patrick Gansterer
  • 36 edits in trunk/Source

2011-02-24 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Rename PLATFORM(SKIA) to USE(SKIA)
https://bugs.webkit.org/show_bug.cgi?id=55090

  • wtf/Platform.h:

2011-02-24 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Rename PLATFORM(SKIA) to USE(SKIA)
https://bugs.webkit.org/show_bug.cgi?id=55090

  • config.h: Removed second define of PLATFORM(SKIA).
  • html/HTMLCanvasElement.cpp:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/Gradient.cpp:
  • platform/graphics/Gradient.h:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/ImageSource.h:
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/Path.h:
  • platform/graphics/Pattern.cpp:
  • platform/graphics/Pattern.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp:
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/GLES2Canvas.cpp:
  • platform/graphics/chromium/ImageLayerChromium.cpp:
  • platform/graphics/chromium/LayerChromium.cpp:
  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTilerChromium.cpp:
  • platform/graphics/chromium/ShaderChromium.h:
  • platform/graphics/gpu/LoopBlinnPathProcessor.cpp:
  • platform/graphics/transforms/AffineTransform.h:
  • platform/graphics/transforms/TransformationMatrix.h:
  • platform/image-decoders/ImageDecoder.cpp:
  • platform/image-decoders/ImageDecoder.h:
  • rendering/svg/RenderSVGResourceSolidColor.cpp:

2011-02-24 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Rename PLATFORM(SKIA) to USE(SKIA)
https://bugs.webkit.org/show_bug.cgi?id=55090

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
  • src/GraphicsContext3DInternal.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas):
9:33 AM Changeset in webkit [79577] by alex
  • 2 edits in trunk

2011-02-24 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Martin Robinson.

Fixed compilation after r79537, added a bug to solve webkit2
translations:
https://bugs.webkit.org/show_bug.cgi?id=55153

  • GNUmakefile.am:
9:29 AM Changeset in webkit [79576] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-02-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: follow up to 79566. USE_PARAM not declared
https://bugs.webkit.org/show_bug.cgi?id=55155

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::currentCallFrame):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
9:20 AM Changeset in webkit [79575] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-02-24 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] add android 2.2 user agent to QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=55085

Credit to Forrest Hodgkins to find right user-agent which works for youtube.

  • QtTestBrowser/useragentlist.txt:
8:59 AM Changeset in webkit [79574] by eae@chromium.org
  • 5 edits
    2 adds in trunk

2011-02-24 Emil A Eklund <eae@chromium.org>

Reviewed by Simon Fraser.

Add support for missing properties to getComputedStyle
https://bugs.webkit.org/show_bug.cgi?id=23668

Test getComputedStyle for the content, counter and outline-offset
properties.

  • fast/css/getComputedStyle/computed-style-properties-expected.txt: Added.
  • fast/css/getComputedStyle/computed-style-properties.html: Added.

2011-02-24 Emil A Eklund <eae@chromium.org>

Reviewed by Simon Fraser.

Add support for missing properties to getComputedStyle
https://bugs.webkit.org/show_bug.cgi?id=23668

Implement getComputedStyle for the content, counter and outline-offset
properties.

Test: fast/css/getComputedStyle/computed-style-properties.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::contentToCSSValue): (WebCore::counterToCSSValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
  • css/CSSPrimitiveValue.h:
8:56 AM Changeset in webkit [79573] by Adam Roben
  • 2 edits in trunk/Tools

Change FrameLoadDelegate to support any number of delegates with delayed work to process

This makes our behavior match Mac more closely, and allows us to remove an incorrect
assertion that was firing during some tests. (The assertion was claiming that there was
never more than one delegate with delayed work to process, but that was not the case.)

Fixes <http://webkit.org/b/55146> Assertion failure in FrameLoadDelegate::locationChangeDone
when running http/tests/navigation/back-twice-without-commit.html

Reviewed by Eric Carlson.

  • DumpRenderTree/win/FrameLoadDelegate.cpp:

(delegatesWithDelayedWork): Added. Returns all FrameLoadDelegates that have delayed work to
process. A single delegate may appear in this Vector more than once (just as, on Mac, a
single delegate may have multiple performSelector requests).
(processWorkTimer): Pass the HWND to ::KillTimer, for pedantic brownie points. Added an
assertion that the timer firing is the shared process work timer. Instead of using the
single, global "delegate waiting for timer" delegate, give all delegates that have delayed
work to process a chance to process their work.
(FrameLoadDelegate::locationChangeDone): If we don't already have an active timer for
processing delayed work, create one. Then add ourselves to the delegatesWithDelayedWork
Vector so our processWork function will be called when the timer fires.

8:52 AM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
moved Qt to last section, it's optional (diff)
8:50 AM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
(diff)
8:44 AM Changeset in webkit [79572] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

SegmentedString does not need an m_composite member
https://bugs.webkit.org/show_bug.cgi?id=55083

Storing m_composite as distinct from m_substrings.isEmpty()
was just error prone and eventually going to get us in trouble.

I also cleaned up some of the style in SegementedString.*
since this file long predates check-webkit-style.

  • platform/text/SegmentedString.cpp: (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::operator=): (WebCore::SegmentedString::length): (WebCore::SegmentedString::setExcludeLineNumbers): (WebCore::SegmentedString::clear): (WebCore::SegmentedString::append): (WebCore::SegmentedString::prepend): (WebCore::SegmentedString::advanceSubstring): (WebCore::SegmentedString::toString):
  • platform/text/SegmentedString.h: (WebCore::SegmentedSubstring::SegmentedSubstring): (WebCore::SegmentedSubstring::appendTo): (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::isComposite):
8:40 AM Changeset in webkit [79571] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX: Add missing include for UnusedParam.h

Not reviewed.

  • platform/mac/FileSystemMac.mm: Add include. It should have

originally been added with r76614.

8:39 AM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
Improved English :) Remove references to Python script. Emphasized … (diff)
8:26 AM Changeset in webkit [79570] by commit-queue@webkit.org
  • 30 edits in trunk

2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

No new tests. (no code affected, just exporting a method for DumpRenderTree use)

  • WebCore.exp.in:

2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WebFrame.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::clearOpener):
  • src/WebFrameImpl.h:

2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to DumpRenderTreeSupportGTK.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::clearOpener):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WebFramePrivate.

  • WebView/WebFrame.mm: (-[WebFrame _clearOpener]):
  • WebView/WebFramePrivate.h:

2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to DumpRenderTreeSupportQT.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::clearOpener):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to IWebFramePrivate.
Touched WebKit.idl to trigger build scripts.

  • Interfaces/IWebFramePrivate.idl:
  • Interfaces/WebKit.idl:
  • WebFrame.cpp: (WebFrame::clearOpener):
  • WebFrame.h:

2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener method to WKBundleWebFramePrivate.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameClearOpener):
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:

2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>

Reviewed by Alexey Proskuryakov.

DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874

Added clearOpener() calls between tests.
Some tests are using window.open() to change current window location.
This changes window.opener property whose nullity is checked before
showing xml viewer.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::reset):
8:22 AM Changeset in webkit [79569] by krit@webkit.org
  • 10 edits
    8 adds in trunk

2011-02-24 Dirk Schulze <krit@webkit.org>

Reviewed by Darin Adler.

Removing a SVG animation target during animation crashes WebKit
https://bugs.webkit.org/show_bug.cgi?id=12065

SVGAnimations with IRI references via 'xlink:href' are slow
https://bugs.webkit.org/show_bug.cgi?id=49437

Test that WebKit does not crash, if the target element of a SVG animation gets removed, or if
its id changed.

  • platform/mac/svg/custom/animate-target-id-changed-expected.checksum: Added.
  • platform/mac/svg/custom/animate-target-id-changed-expected.png: Added.
  • platform/mac/svg/custom/animate-target-id-changed-expected.txt: Added.
  • platform/mac/svg/custom/animate-target-removed-from-document-expected.checksum: Added.
  • platform/mac/svg/custom/animate-target-removed-from-document-expected.png: Added.
  • platform/mac/svg/custom/animate-target-removed-from-document-expected.txt: Added.
  • svg/custom/animate-target-id-changed.svg: Added.
  • svg/custom/animate-target-removed-from-document.svg: Added.

2011-02-24 Dirk Schulze <krit@webkit.org>

Reviewed by Darin Adler.

Removing a SVG animation target during animation crashes WebKit
https://bugs.webkit.org/show_bug.cgi?id=12065

SVGAnimations with IRI references via 'xlink:href' are slow
https://bugs.webkit.org/show_bug.cgi?id=49437

Store reference to target element for SVG animation elements. This is important if the
target gets referenced via 'xlink:href'. At the moment we would call getElementById() multiple
times on every animation step. A very expensive operation. This will be avoided with this patch.
On the other hand, we need to be sure that the target element is always valid. The reference is
reset, if the target was removed from document or its destructor was called. A HashMap in
SVGDocumentExtensions stores all mappings from target element to all current animation elements.

Tests: svg/custom/animate-target-id-changed.svg

svg/custom/animate-target-removed-from-document.svg

  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::~SVGDocumentExtensions): (WebCore::SVGDocumentExtensions::addAnimationElementToTarget): New animation gets applied to target. (WebCore::SVGDocumentExtensions::removeAnimationElementFromTarget): Animation stoped, remove it from HashMap. (WebCore::SVGDocumentExtensions::removeAllAnimationElementsFromTarget): Target no longer in document, reset all references in SVG animation elements.
  • svg/SVGDocumentExtensions.h:
  • svg/SVGElement.cpp: (WebCore::SVGElement::~SVGElement): (WebCore::SVGElement::removedFromDocument): (WebCore::SVGElement::attributeChanged):
  • svg/SVGElement.h:
  • svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::removedFromDocument):
  • svg/SVGVKernElement.cpp: (WebCore::SVGVKernElement::removedFromDocument):
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::SVGSMILElement): (WebCore::SVGSMILElement::removedFromDocument): (WebCore::SVGSMILElement::eventBaseFor): (WebCore::SVGSMILElement::targetElement):
  • svg/animation/SVGSMILElement.h: (WebCore::SVGSMILElement::resetTargetElement):
8:12 AM Changeset in webkit [79568] by Simon Fraser
  • 3 edits
    4 adds in trunk

2011-02-24 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel.

REGRESSION: Accelerated transitions are jumpy
https://bugs.webkit.org/show_bug.cgi?id=55022

When an accelerated transition used the default timing function,
a typo in toCAMediaTimingFunction() resulting in the incorrect
timing function being used.

Test: transitions/default-timing-function.html

  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm: (toCAMediaTimingFunction):
8:09 AM Changeset in webkit [79567] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-24 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove bogus optimizations in TextBreakIteratorQt
https://bugs.webkit.org/show_bug.cgi?id=55139

Let QTextBoundaryFinder hold a deep copy of the string data it's
operating on, and don't use the same working buffer for all iterators.

  • platform/text/qt/TextBreakIteratorQt.cpp: (WebCore::TextBreakIterator::TextBreakIterator): (WebCore::setUpIterator):
8:05 AM Changeset in webkit [79566] by podivilov@chromium.org
  • 3 edits
    6 adds in trunk

2011-02-24 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] Bug in the highlighter
https://bugs.webkit.org/show_bug.cgi?id=54876

Fixing two bugs: 1) When restoring the state from a successful updateHighlight() call, we should restore the old state only if it is greater (closer to the end) than the current one.
2) When a long line is being highlighted in more than one chunk (timer tick), we wrongly deleted the result of the work done in the previous tick, rather than updating it with the new results.

  • inspector/editor/highlighter-long-line-expected.txt: Added.
  • inspector/editor/highlighter-long-line.html: Added.
  • inspector/editor/highlighter-paste-in-comment-expected.txt: Added.
  • inspector/editor/highlighter-paste-in-comment.html: Added.
  • inspector/editor/highlighter-test.js: Added. (initialize_HighlighterTests.InspectorTest.dumpTextModel): (initialize_HighlighterTests):

2011-02-24 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] Bug in the highlighter
https://bugs.webkit.org/show_bug.cgi?id=54876

Tests: inspector/editor/highlighter-long-line.html

inspector/editor/highlighter-paste-in-comment.html

  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.set highlightChunkLimit): (WebInspector.TextEditorHighlighter.prototype.updateHighlight): (WebInspector.TextEditorHighlighter.prototype._highlightLines):
7:51 AM Changeset in webkit [79565] by simonjam@chromium.org
  • 6 edits in trunk

2011-02-24 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Gentilcore.

[Web Timing] Zero out navigationStart and unloadEvent on cross-origin redirect
https://bugs.webkit.org/show_bug.cgi?id=55068

  • http/tests/misc/resources/webtiming-cross-origin-and-back2.html: Expect navStart and unload to be zero.
  • http/tests/misc/resources/webtiming-cross-origin-redirect.html: Expect navStart to be zero.
  • http/tests/misc/webtiming-origins-expected.txt:

2011-02-24 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Gentilcore.

[Web Timing] Zero out navigationStart and unloadEvent on cross-origin redirect
https://bugs.webkit.org/show_bug.cgi?id=55068

Test: http/tests/misc/webtiming-origins.html

  • page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::navigationStart): Zero out on cross origin redirect. (WebCore::PerformanceTiming::unloadEventStart): Ditto. (WebCore::PerformanceTiming::unloadEventEnd): Ditto.
7:49 AM Changeset in webkit [79564] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-24 Patrick Gansterer <Patrick Gansterer>

Reviewed by Alexey Proskuryakov.

Remove pthreads dependecy for JSLock
https://bugs.webkit.org/show_bug.cgi?id=54832

JSLock is only needed to support an obsolete execution model where JavaScriptCore
automatically protected against concurrent access from multiple threads.
So it's safe to disable it on non-mac platforms where we don't have native pthreads.

  • runtime/JSLock.cpp:
7:49 AM Changeset in webkit [79563] by commit-queue@webkit.org
  • 6 edits
    2 moves
    1 delete in trunk/Source

2011-02-24 Adam Klein <adamk@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add code to WebKit Chromium to allow access to NetworkStateNotifier
https://bugs.webkit.org/show_bug.cgi?id=54516

Give Chromium's NetworkStateNotifier the ability to change the value
of m_isOnLine, rather than making it always true.

No new tests, not sure how to test this. No other LayoutTests seem
to exercise navigator.onLine.

  • WebCore.gypi:
  • platform/network/NetworkStateNotifier.cpp: (WebCore::NetworkStateNotifier::setOnLine): Moved and renamed from NetworkStateNotifierAndroid.
  • platform/network/NetworkStateNotifier.h: (WebCore::NetworkStateNotifier::networkStateChange): Forward to setOnLine.
  • platform/network/android/NetworkStateNotifierAndroid.cpp: Removed.
  • platform/network/chromium/NetworkStateNotifierChromium.cpp: Removed.
  • platform/network/chromium/NetworkStateNotifierPrivate.h: Removed.

2011-02-24 Adam Klein <adamk@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add code to WebKit Chromium to allow access to NetworkStateNotifier
https://bugs.webkit.org/show_bug.cgi?id=54516

Add a new WebNetworkStateNotifier class with a single static method,
setOnLine(), which dispatches to WebCore's singleton NetworkStateNotifier.

  • WebKit.gyp:
  • public/WebNetworkStateNotifier.h: Added.
  • src/WebNetworkStateNotifier.cpp: Added. (WebKit::WebNetworkStateNotifier::setOnLine):
7:31 AM TriagingTestFailures edited by Adam Roben
Add tips for looking at old builds on build.webkit.org (diff)
7:21 AM Changeset in webkit [79562] by benjamin.poulain@nokia.com
  • 6 edits in trunk/Source

2011-02-24 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Eric Seidel.

Support building WebKit with Python 3
https://bugs.webkit.org/show_bug.cgi?id=55038

Add support for Python 3 without breaking support for Python 2.

Main issues:
-print is a function in Python 3
-list.sort() no longer have the cmp parameter
-string.uppercase and string.lowercase have been removed

  • html/parser/create-html-entity-table:

2011-02-24 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Eric Seidel.

Support building WebKit with Python 3
https://bugs.webkit.org/show_bug.cgi?id=55038

Update the generator scripts to support Python 3.

  • Scripts/generate-message-receiver.py: print is a function in Python 3, write the output to sys.stdout to be compatible with Python 2 and 3.
  • Scripts/generate-messages-header.py:
  • Scripts/webkit2/messages.py: dist.iteritems does not exist in Python 3, fallback to dict.items which is common to Python 2 and 3.
7:15 AM Changeset in webkit [79561] by Adam Roben
  • 3 edits in trunk/Tools

Don't trigger Windows builds for changes to WebCore.exp.in or the top-level GNUmakefile.am

Fixes <http://webkit.org/b/55144> Windows builders should not have built r79343 or r79440,
but did

Reviewed by Anders Carlsson.

  • Scripts/webkitpy/common/config/build.py:

(_should_file_trigger_build): Loosened the pattern for GNUmakefile.am to include the
top-level GNUmakefile.am, and loosened the pattern for .exp files to include WebCore.exp.in.

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest): Added some more tests.

7:12 AM Changeset in webkit [79560] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-24 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix bad expectation for new test added in r79555.

  • inspector/debugger/scripts-panel-expected.txt:
6:56 AM Changeset in webkit [79559] by Chris Fleizach
  • 4 edits
    2 adds in trunk

2011-02-24 Chris Fleizach <Chris Fleizach>

Reviewed by Eric Seidel.

AX: WebKit should expose MathML at least as well as it exposes ARIA role="math"
https://bugs.webkit.org/show_bug.cgi?id=55049

  • platform/mac/accessibility/math-alttext-expected.txt: Added.
  • platform/mac/accessibility/math-alttext.html: Added.

2011-02-24 Chris Fleizach <Chris Fleizach>

Reviewed by Eric Seidel.

AX: WebKit should expose MathML at least as well as it exposes ARIA role="math"
https://bugs.webkit.org/show_bug.cgi?id=55049

Make <math> elements behave as ARIA math roles and use MathML::alttext as a
possible accessible label.

Test: platform/mac/accessibility/math-alttext.html

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityDescription): (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
  • mathml/mathattrs.in:
6:51 AM Changeset in webkit [79558] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-24 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: adjust protocol message format according to spec.
https://bugs.webkit.org/show_bug.cgi?id=55140

  • inspector/CodeGeneratorInspector.pm:
6:48 AM Changeset in webkit [79557] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Windows Production build fix

  • platform/network/cf/AuthenticationCF.cpp: Add an extra #include as a workaround for

<rdar://problem/9042114>.

6:43 AM Changeset in webkit [79556] by pfeldman@chromium.org
  • 30 edits
    2 adds in trunk

2011-02-23 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor inspect() workflow so that it did not push dom nodes.
https://bugs.webkit.org/show_bug.cgi?id=55057

  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.runTestSuite.runner): (initialize_InspectorTest.InspectorTest.runTestSuite):
  • inspector/console/command-line-api-inspect-expected.txt: Added.
  • inspector/console/command-line-api-inspect.html: Added.

2011-02-23 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor inspect() workflow so that it did not push dom nodes.
https://bugs.webkit.org/show_bug.cgi?id=55057

Test: inspector/console/command-line-api-inspect.html

I am working on getting rid of DOM agent pushes - everything should happen upon
front-end request. This patch changes the way we handle inspect() command line
api: instead of pushing nodes, we are telling front-end that inspect(object) has
been requested. It is then up to front-end to request dom nodes and focus them in
the tree. I also made inspect() work in a generic manner, using same routines for
nodes, databases, storages and potentially new elements.

As a side-effect, we don't do console.log from within inspect() anymore, but dump
inspected value as inspect's result.

Also, I added individual object release method and made object groups optional.

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::scriptValueAsNode): (WebCore::InjectedScriptHost::nodeAsScriptValue): (WebCore::JSInjectedScriptHost::inspect): (WebCore::JSInjectedScriptHost::databaseId): (WebCore::JSInjectedScriptHost::storageId):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::scriptValueAsNode): (WebCore::InjectedScriptHost::nodeAsScriptValue): (WebCore::V8InjectedScriptHost::inspectCallback): (WebCore::V8InjectedScriptHost::databaseIdCallback): (WebCore::V8InjectedScriptHost::storageIdCallback):
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::nodeForObjectId): (WebCore::InjectedScript::releaseObject): (WebCore::InjectedScript::wrapForConsole): (WebCore::InjectedScript::inspectNode):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::inspectImpl): (WebCore::InjectedScriptHost::databaseIdImpl): (WebCore::InjectedScriptHost::storageIdImpl):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::focusNode):
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::storageId): (WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDOMStorageResource.cpp:
  • inspector/InspectorDOMStorageResource.h:
  • inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::databaseId):
  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDatabaseResource.cpp:
  • inspector/InspectorDatabaseResource.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::releaseObject):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.evaluateInTargetWindow): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
  • inspector/front-end/DOMStorage.js:
  • inspector/front-end/Database.js:
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
  • inspector/front-end/inspector.js: (WebInspector.inspect):
6:38 AM Changeset in webkit [79555] by podivilov@chromium.org
  • 7 edits
    5 adds in trunk

2011-02-22 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: refactor "script or resource" mess in scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=54961

  • Use sourceName instead of scriptOrResource
  • Replace two huge functions _addScriptToFilesMenu and _showScriptOrResource that are calling each other recursively with small one-purpose non-recursive functions
  • http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.showScriptSource): (initialize_DebuggerTest.InspectorTest._showScriptSource):
  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.assertEquals): (initialize_InspectorTest.InspectorTest.safeWrap):
  • inspector/debugger/resources/script1.js: Added. (f1):
  • inspector/debugger/resources/script2.js: Added. (f2):
  • inspector/debugger/resources/script3.js: Added. (f3):
  • inspector/debugger/scripts-panel-expected.txt: Added.
  • inspector/debugger/scripts-panel.html: Added.

2011-02-22 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: refactor "script or resource" mess in scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=54961

  • Use sourceName instead of scriptOrResource
  • Replace two huge functions _addScriptToFilesMenu and _showScriptOrResource that are calling each other recursively with small one-purpose non-recursive functions

Test: inspector/debugger/scripts-panel.html

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get defaultFocusedElement): (WebInspector.ScriptsPanel.prototype._scriptSourceChanged): (WebInspector.ScriptsPanel.prototype._addScript): (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelectAndShowSourceFrameIfNeeded): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype.canShowSourceLine): (WebInspector.ScriptsPanel.prototype.showSourceLine): (WebInspector.ScriptsPanel.prototype._showSourceFrame): (WebInspector.ScriptsPanel.prototype._sourceFrameForSourceName): (WebInspector.ScriptsPanel.prototype._recreateSourceFrame): (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded): (WebInspector.ScriptsPanel.prototype._addItemToBackForwardList): (WebInspector.ScriptsPanel.prototype._sourceNameForScript): (WebInspector.ScriptsPanel.prototype._scriptForSourceName): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.ScriptsPanel.prototype._filesSelectChanged): (WebInspector.ScriptsPanel.prototype._goBack): (WebInspector.ScriptsPanel.prototype._goForward):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.setExecutionLine):
6:34 AM Changeset in webkit [79554] by eric@webkit.org
  • 5 edits in trunk

2011-02-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fragment parsing does not need to use HTMLSourceTracker
https://bugs.webkit.org/show_bug.cgi?id=55011

Remove support of XSS-filtering innerHTML content.

  • http/tests/security/xssAuditor/dom-write-innerHTML-expected.txt:

2011-02-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fragment parsing does not need to use HTMLSourceTracker
https://bugs.webkit.org/show_bug.cgi?id=55011

Any performance gains from this patch are likely
the result of working around:
https://bugs.webkit.org/show_bug.cgi?id=55005
(Which suggests that fixing bug 55005 will speed
up normal HTML parsing substantially.)

Assuming I ran the numbers correct, here is the
change from PerformanceTests/Parser/tiny-innerHTML:
Before patch:
avg 5586.1
median 5594
stdev 41.295157101045135
min 5425
max 5633

After Patch:
avg 2603.9
median 2609.5
stdev 32.500615378789355
min 2475
max 2649

Removing just the HTMLSourceTracker calls brought our
score from 5500 to 5200, removing the XSSFilter as well
brought it to 2600 on my machine.

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::pumpTokenizer):
  • html/parser/HTMLDocumentParser.h:
6:08 AM Changeset in webkit [79553] by pfeldman@chromium.org
  • 9 edits in trunk/LayoutTests

2011-02-24 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: beautified inspector test suite output.

  • http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite.runner): (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite):
  • http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.runTestSuite.runner): (initialize_InspectorTest.InspectorTest.runTestSuite):
  • inspector/debugger/source-frame-expected.txt:
  • inspector/elements/insert-node-collapsed-expected.txt:
  • inspector/elements/insert-node-expected.txt:
  • inspector/elements/modify-chardata-expected.txt:
  • inspector/elements/remove-node-expected.txt:
  • inspector/elements/set-attribute-expected.txt:
5:44 AM Changeset in webkit [79552] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-02-24 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] tst_QWebView::setPalette(activeFG) fails
https://bugs.webkit.org/show_bug.cgi?id=55029

This time it should be the proper fix. The window needs to be shown before we
call activateWindow() otherwise there is no active windows for the application.

  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::setPalette):
5:25 AM Changeset in webkit [79551] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-24 Chao-ying Fu <fu@mips.com>

Reviewed by Eric Seidel.

Fix MIPS build with new patchOffsetPut/GetByIdPropertyMapOffset1/2 values
https://bugs.webkit.org/show_bug.cgi?id=54997

  • jit/JIT.h:
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
5:14 AM Changeset in webkit [79550] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-24 Philippe Normand <pnormand@igalia.com>

Unreviewed, skipping crashing test on GTK

  • platform/gtk/Skipped:
5:11 AM Changeset in webkit [79549] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-24 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium Mac test expectations update.

fast/text/shadow-no-blur.html has been passing for a while.
http tests have been passing since r79279.
media/video-display-toggle.html has been passing since r79415.
svg/text/font-size-below-point-five.svg has been passing since r78844.

  • platform/chromium/test_expectations.txt:
4:58 AM Changeset in webkit [79548] by abecsi@webkit.org
  • 14 edits in trunk

2011-02-24 Andras Becsi <abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] MinGW build fails to link
https://bugs.webkit.org/show_bug.cgi?id=55050

Prepend the libraries of subcomponents instead of appending them
to fix the library order according to the dependency of the libraries

  • JavaScriptCore.pri: rename addJavaScriptCore to prependJavaScriptCore
  • jsc.pro: ditto

2011-02-24 Andras Becsi <abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] MinGW build fails to link
https://bugs.webkit.org/show_bug.cgi?id=55050

Prepend the libraries of subcomponents instead of appending them
to fix the library order according to the dependency of the libraries

  • api/QtScript.pro:

2011-02-24 Andras Becsi <abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] MinGW build fails to link
https://bugs.webkit.org/show_bug.cgi?id=55050

Prepend the libraries of subcomponents instead of appending them
to fix the library order according to the dependency of the libraries

No new tests needed.

  • WebCore.pri:

2011-02-24 Andras Becsi <abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] MinGW build fails to link
https://bugs.webkit.org/show_bug.cgi?id=55050

Prepend the libraries of subcomponents instead of appending them
to fix the library order according to the dependency of the libraries

  • QtWebKit.pro: prepend libraries in the correct order

2011-02-24 Andras Becsi <abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] MinGW build fails to link
https://bugs.webkit.org/show_bug.cgi?id=55050

Prepend the libraries of subcomponents instead of appending them
to fix the library order according to the dependency of the libraries

  • WebKit2.pri:

2011-02-24 Andras Becsi <abecsi@webkit.org>

Reviewed by Laszlo Gombos.

[Qt] MinGW build fails to link
https://bugs.webkit.org/show_bug.cgi?id=55050

Prepend the libraries of subcomponents instead of appending them
to fix the library order according to the dependency of the libraries

  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  • WebKitTestRunner/qt/WebKitTestRunner.pro:
4:52 AM Changeset in webkit [79547] by abarth@webkit.org
  • 7 edits
    3 adds in trunk

2011-02-24 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

CSP's script-src should block JavaScript URLs
https://bugs.webkit.org/show_bug.cgi?id=54787

Test how various CSP policies affect JavaScript URLs. We could test
more contexts in the future, but this is a start.

  • http/tests/security/contentSecurityPolicy/javascript-url-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/javascript-url.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/javascript-url.pl: Added.

2011-02-24 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

CSP's script-src should block JavaScript URLs
https://bugs.webkit.org/show_bug.cgi?id=54787

Blocking JavaScript URLs required some re-architecting of the lifetime
of the ContentSecurityPolicy object. We now manage the lifetime the
same way we manage the lifetime of the SecurityOrigin object. In
particular, when SecurityOrigin inherits into an about:blank iframe, we
inherit the CSP object as well. (This is covered by the test added in
this patch.) In the future, we might consider making
ContentSecurityPolicy a component of SecurityOrigin instead of a
component of Document.

I noted the trickiness in
http://www.w3.org/Security/wiki/Content_Security_Policies so that we'll
make sure it gets defined properly in the spec.

Test: http/tests/security/contentSecurityPolicy/javascript-url.html

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • dom/Document.cpp: (WebCore::Document::initSecurityContext):
  • dom/Document.h: (WebCore::Document::contentSecurityPolicy):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
  • page/ContentSecurityPolicy.h: (WebCore::ContentSecurityPolicy::create):
4:47 AM Changeset in webkit [79546] by Philippe Normand
  • 4 edits
    2 adds in trunk/Source/WebCore

2011-02-21 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] GRefPtr support for GstElement
https://bugs.webkit.org/show_bug.cgi?id=54870

  • CMakeListsEfl.txt:
  • GNUmakefile.am:
  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp: Added. (WTF::GstElement):
  • platform/graphics/gstreamer/GRefPtrGStreamer.h: Added.
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webKitWebSrcQuery):
4:39 AM Changeset in webkit [79545] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

[Qt] Remove ARMv5 Release buildbot.

Patch by Gabor Loki <loki@webkit.org> on 2011-02-24
Reviewed by Csaba Osztrogonác.

Remove ARMv5 Release buildbot, because there is very little difference
between ARMv5 and ARMv7 Release bots, and there is also very little
interest in ARMv5 build slave (compared to ARMv7).

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4:33 AM Changeset in webkit [79544] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-02-24 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] REGRESSION(69304): WKNativeEvent.h forwarding header is always regenerated
https://bugs.webkit.org/show_bug.cgi?id=47589

In case of file name clashes only generate forwarding header for the current platform.

  • Scripts/generate-forwarding-headers.pl:
4:31 AM Changeset in webkit [79543] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-24 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Share code between elementFromPoint and caretRangeFromPoint in Document.
https://bugs.webkit.org/show_bug.cgi?id=54610

Eliminate duplicate code by moving shared logic from elementFromPoint and
caretRangeFromPoint into helper function.

  • dom/Document.cpp: (WebCore::nodeFromPoint): (WebCore::Document::elementFromPoint): (WebCore::Document::caretRangeFromPoint):
3:57 AM Changeset in webkit [79542] by loislo@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-02-24 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix.

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::removeAttribute):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::cachedResources):
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::evaluate):
3:51 AM Changeset in webkit [79541] by commit-queue@webkit.org
  • 4 edits in trunk

2011-02-24 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Eric Seidel.

[gtk] Failing collinear arcTo canvas tests
https://bugs.webkit.org/show_bug.cgi?id=54658

Enable two more tests that pass after adding collinearity check
when drawing arcTo in canvas.

  • platform/gtk/Skipped:

2011-02-24 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Eric Seidel.

[gtk] Failing collinear arcTo canvas tests
https://bugs.webkit.org/show_bug.cgi?id=54658

Check for collinearity of the three points that affect how arcTo call
results. This behavior is in accordance with the HTML standard.

No new tests added as this is already covered by at least two tests.

  • platform/graphics/cairo/PathCairo.cpp: (WebCore::areaOfTriangleFormedByPoints): (WebCore::Path::addArcTo):
3:50 AM Changeset in webkit [79540] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-24 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectations update.
Removed tests that have been passing since r79478.

  • platform/chromium/test_expectations.txt:
3:43 AM Changeset in webkit [79539] by loislo@chromium.org
  • 30 edits in trunk/Source/WebCore

2011-02-24 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: There is a validator of the protocol message format.

It has two parts. InspectorBackendStub.js is the frontend part.
InspectorBackendDispatcher.cpp is the backend part.
Both parts are checking protocol message format and report the error if
the message has not enough fields or the types of fields do not match with
Inspector.idl specification. These validators are generated automatically.

In addition, we have a number of places at the backend where we check the
function arguments and do nothing if the arguments are invalid
from the business logic point of view.

This patch bring us an ability to report a custom error from such function to the frontend.

https://bugs.webkit.org/show_bug.cgi?id=54971

  • inspector/CodeGeneratorInspector.pm:
  • inspector/InjectedScriptHost.cpp:
  • inspector/InspectorAgent.cpp:
  • inspector/InspectorAgent.h:
  • inspector/InspectorApplicationCacheAgent.cpp:
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorBrowserDebuggerAgent.cpp:
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/InspectorCSSAgent.cpp:
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorConsoleAgent.cpp:
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorController.cpp:
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMStorageAgent.cpp:
  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.cpp:
  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorProfilerAgent.cpp:
  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorResourceAgent.cpp:
  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorRuntimeAgent.cpp:
  • inspector/InspectorRuntimeAgent.h:
  • inspector/InspectorTimelineAgent.cpp:
  • inspector/InspectorTimelineAgent.h:
3:25 AM Changeset in webkit [79538] by eric@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Deque<T> should support inline capacity
https://bugs.webkit.org/show_bug.cgi?id=55032

The title says it all. There are currently no places
which use this code yet, however it's been tested in conjunction
with code for bug 55005.

This also adds an ASSERT that capacity is never 1. If you were able
to set the capacity equal to 1, the Deque would just get confused
and happily append your item but still think it had size 0.

  • wtf/Deque.h: (WTF::DequeIterator::DequeIterator): (WTF::DequeConstIterator::DequeConstIterator): (WTF::DequeReverseIterator::DequeReverseIterator): (WTF::DequeConstReverseIterator::DequeConstReverseIterator): (WTF::::checkValidity): (WTF::::checkIndexValidity): (WTF::::invalidateIterators): (WTF::::Deque): (WTF::deleteAllValues): (WTF::::operator): (WTF::::destroyAll): (WTF::::~Deque): (WTF::::swap): (WTF::::clear): (WTF::::findIf): (WTF::::expandCapacityIfNeeded): (WTF::::expandCapacity): (WTF::::takeFirst): (WTF::::append): (WTF::::prepend): (WTF::::removeFirst): (WTF::::remove): (WTF::::addToIteratorsList): (WTF::::removeFromIteratorsList): (WTF::::DequeIteratorBase): (WTF::::~DequeIteratorBase): (WTF::::isEqual): (WTF::::increment): (WTF::::decrement): (WTF::::after): (WTF::::before):
  • wtf/Vector.h:
3:22 AM Changeset in webkit [79537] by christian@webkit.org
  • 2 edits in trunk

[GTK] webkitgtk 1.3.7 build without translations
https://bugs.webkit.org/show_bug.cgi?id=50612

Rubber-stamped by Eric Seidel.

  • GNUmakefile.am: Require stamp-po target for all-local so

that po files are built before they install.

3:09 AM Changeset in webkit [79536] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Crash when deleting inside a blockquote with a large offset
https://bugs.webkit.org/show_bug.cgi?id=55098

The bug was caused by inconsistency in lineBreakExistsAtPosition and breakOutOfEmptyMailBlockquotedParagraph.
While lineBreakExistsAtPosition was checking that a line break exists at the downstream of the given position,
breakOutOfEmptyMailBlockquotedParagraph wasn't using the downstream for caretPos. Fixed the bug by using
the downstream position to instantiate caretPos.

Co-author: Abhishek Arya <inferno@chromium.org>.

Test: editing/deleting/delete-blockquote-large-offsets.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):

2011-02-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Crash when deleting inside a blockquote with a large offset
https://bugs.webkit.org/show_bug.cgi?id=55098

Added a test to ensure WebKit doesn't crash when deleting line inside a blockquote
and the caret is programmatically set to have a large offset.

Co-author: Abhishek Arya <inferno@chromium.org>.

  • editing/deleting/delete-blockquote-large-offsets-expected.txt: Added.
  • editing/deleting/delete-blockquote-large-offsets.html: Added.
3:03 AM Changeset in webkit [79535] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-24 MORITA Hajime <morrita@google.com>

Unreviewed test_expectations.txt update

  • platform/chromium/test_expectations.txt:
2:57 AM Changeset in webkit [79534] by commit-queue@webkit.org
  • 7 edits in trunk/Source

2011-02-24 Robert Kroeger <rjkroege@chromium.org>

Reviewed by Darin Fisher.

Added timestamps to PlatformTouchEvent etc.

PlatformTouchEvent doesn't have a timestamp and so
eventSender.leapForward cannot be used for touchevent based tests.
This change adds a timestamp to PlatformTouchEvent and initializes
it in a reasonable manner on Android and Qt platforms.

[chromium] [WebCore] [android] Touch events are missing time stamps
https://bugs.webkit.org/show_bug.cgi?id=53510

  • platform/PlatformTouchEvent.h: (WebCore::PlatformTouchEvent::PlatformTouchEvent): (WebCore::PlatformTouchEvent::timestamp):
  • platform/android/PlatformTouchEventAndroid.cpp: (WebCore::PlatformTouchEvent::PlatformTouchEvent):
  • platform/qt/PlatformTouchEventQt.cpp: (WebCore::PlatformTouchEvent::PlatformTouchEvent):

2011-02-24 Robert Kroeger <rjkroege@chromium.org>

Reviewed by Darin Fisher.

Added timestamps to PlatformTouchEvent etc.

PlatformTouchEvent doesn't have a timestamp and so
eventSender.leapForward cannot be used for touchevent based tests.
This change constructs PlatformTouchEvents with timestamps
provided from a WebTouchEvent on chromium. It also adds an enum
to make code referring to specific WebTouchPoints easier to read.

[chromium] [WebCore] [android] Touch events are missing time stamps
https://bugs.webkit.org/show_bug.cgi?id=53510

  • public/WebTouchPoint.h: (WebKit::WebTouchPoint::WebTouchPoint):
  • src/WebInputEventConversion.cpp: (WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
2:49 AM Changeset in webkit [79533] by andreas.kling@nokia.com
  • 2 edits in trunk/LayoutTests

2011-02-24 Andreas Kling <kling@webkit.org>

Unreviewed Qt rebaseline.

  • platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
2:36 AM Changeset in webkit [79532] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2011-02-24 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Mac rebaselines for r79490 and r79493.

  • fast/repaint/text-emphasis-h-expected.txt:
  • platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
2:24 AM Changeset in webkit [79531] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-24 Philippe Normand <pnormand@igalia.com>

Unreviewed, unskip 2 fixed SVG tests on GTK after r79530.

  • platform/gtk/Skipped:
2:21 AM Changeset in webkit [79530] by reni@webkit.org
  • 4 edits in trunk/Source/WebCore

Unreviewed GTK, Snow Leopard build fix for r79474.

  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::setKernelUnitLength):

  • platform/graphics/filters/FEConvolveMatrix.h:
2:18 AM Changeset in webkit [79529] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-24 MORITA Hajime <morrita@google.com>

Unreviewed skipping failing tests. (r79517 removed too many.)

  • platform/chromium/test_expectations.txt:
2:12 AM Changeset in webkit [79528] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-24 Philippe Normand <pnormand@igalia.com>

Unreviewed; skip canvas/philip/tests/2d.imageData.object.round.html and
canvas/philip/tests/2d.imageData.object.wrap.html on GTK.

They were passing before r79501.

  • platform/gtk/Skipped:
2:00 AM Changeset in webkit [79527] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-24 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; skip canvas/philip/tests/2d.imageData.object.round.html and
canvas/philip/tests/2d.imageData.object.wrap.html on Mac.

It was removed from the skipped list in r64156 but it wasn't added back
when r79501 reverted it.

  • platform/mac/Skipped:
1:34 AM Changeset in webkit [79526] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

2011-02-24 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

Use IntRect instead of a pointer to a GtkAllocation struct to avoid
unnecessary memory allocations.

  • plugins/PluginView.h:
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setNPWindowIfNeeded): (WebCore::PluginView::plugAddedCallback):
1:30 AM Changeset in webkit [79525] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-24 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip flaky media test on GTK.

  • platform/gtk/Skipped:
1:05 AM Changeset in webkit [79524] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

2011-02-24 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix the build with GTK+ 3.

  • plugins/PluginView.h:
12:55 AM Changeset in webkit [79523] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-02-24 Philippe Normand <pnormand@igalia.com>

Unreviewed, skipping 2 GTK+ SVG crashing tests.

  • platform/gtk/Skipped:
12:22 AM Changeset in webkit [79522] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-24 MORITA Hajime <morrita@google.com>

Unreviewed skipping failing tests.

  • platform/chromium/test_expectations.txt:
12:20 AM Changeset in webkit [79521] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-23 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Refactor HTMLEquivalent into a hierachy of classes
https://bugs.webkit.org/show_bug.cgi?id=55025

Converted HTMLEquivalent into a class. Some logic in removeImplicitlyStyledElement is
extracted as member functions of HTMLEquivalent and its subclasses.

  • editing/ApplyStyleCommand.cpp: (WebCore::HTMLEquivalent::create): Added. (WebCore::HTMLEquivalent::~HTMLEquivalent): Added. (WebCore::HTMLEquivalent::matches): Returns true if the element is an equivalent, meaning that the element's implicit style affects the property of this equivalence. (WebCore::HTMLEquivalent::hasAttribute): Returns true if this equivalence requires attributes; e.g. color, size, dir. (WebCore::HTMLEquivalent::propertyExistsInStyle): Returns true if the property of this equivalence exists in the specified style. e.g. if this equivalence is for size attribute and font-size property, this function returns true if the specified style has font-size property set. (WebCore::HTMLEquivalent::HTMLEquivalent): Added. (WebCore::HTMLEquivalent::valueIsPresentInStyle): Returns true if the specified style has the implicit style of the specified element of this equivalence. (WebCore::HTMLEquivalent::addToStyle): Adds the implicit style of the element of this equivalence to the specified mutable style. (WebCore::HTMLEquivalentValueList::create): Added. (WebCore::HTMLEquivalentValueList::HTMLEquivalentValueList): Added. (WebCore::HTMLEquivalentValueList::valueIsPresentInStyle): Added. (WebCore::HTMLEquivalentAttribute::create): Added. (WebCore::HTMLEquivalentAttribute::matches): Added. (WebCore::HTMLEquivalentAttribute::hasAttribute): Added. (WebCore::HTMLEquivalentAttribute::attributeName): Added. (WebCore::HTMLEquivalentAttribute::HTMLEquivalentAttribute): Added. (WebCore::HTMLEquivalentAttribute::valueIsPresentInStyle): Added. (WebCore::HTMLEquivalentAttribute::addToStyle): Added. (WebCore::HTMLEquivalentAttribute::attributeValueAsCSSValue): Added. (WebCore::HTMLEquivalentFontSizeAttribute::create): Added. (WebCore::HTMLEquivalentFontSizeAttribute::HTMLEquivalentFontSizeAttribute): Added. (WebCore::HTMLEquivalentFontSizeAttribute::attributeValueAsCSSValue): Added. (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Uses new classes.
12:13 AM Changeset in webkit [79520] by ojan@chromium.org
  • 3 edits in trunk/Tools

2011-02-22 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

fix revision number finding when creating git patches
https://bugs.webkit.org/show_bug.cgi?id=55024

HEAD~n does not walk merge commits correctly. git log however does.

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:

Feb 23, 2011:

11:56 PM Changeset in webkit [79519] by abarth@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-22 Adam Barth <abarth@webkit.org>

Reviewed by Ojan Vafai.

Add missing files to JavaScriptCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55020

gypi files are supposed to list every file under the sun. This patch
adds some missing files and sorts the rest.

11:03 PM Changeset in webkit [79518] by Csaba Osztrogonác
  • 9 edits in trunk/Source/WebCore

Unreviewed, rolling out r79510.
http://trac.webkit.org/changeset/79510
https://bugs.webkit.org/show_bug.cgi?id=55114

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-02-23
It made ~200 tests crash on Qt bot (Requested by Ossy_ on
#webkit).

  • platform/text/TextBreakIterator.h:
  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::lineBreakIterator):

  • platform/text/qt/TextBreakIteratorQt.cpp:

(WebCore::lineBreakIterator):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::findNextLineBreak):

  • rendering/RenderText.cpp:

(WebCore::RenderText::computePreferredLogicalWidths):

  • rendering/break_lines.cpp:

(WebCore::nextBreakablePosition):

  • rendering/break_lines.h:

(WebCore::isBreakable):

10:05 PM Changeset in webkit [79517] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-23 MORITA Hajime <morrita@google.com>

Unreviewed unskipping another passed tests.

  • platform/chromium/test_expectations.txt:
9:14 PM Changeset in webkit [79516] by mrobinson@webkit.org
  • 3 edits in trunk/LayoutTests

2011-02-23 Martin Robinson <mrobinson@igalia.com>

Rebaseline a couple GTK+ test results.

  • platform/gtk/fast/repaint/text-emphasis-h-expected.txt:
  • platform/gtk/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
8:21 PM Changeset in webkit [79515] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-23 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

autocomplete=off prevents refilling form fields on back/forward navigation
https://bugs.webkit.org/show_bug.cgi?id=47463

I haven't actually run this patch due to the difficulty of getting
a bugzilla instance running. It's simple enough code that I'm not too worried
about it.

  • committers-autocomplete.js:
7:38 PM Changeset in webkit [79514] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-23 MORITA Hajime <morrita@google.com>

Unreviewed unskipping passed tests.

  • platform/chromium/test_expectations.txt:
6:12 PM Changeset in webkit [79513] by ggaren@apple.com
  • 3 edits
    2 deletes in trunk/Source/WebCore

Used svn merge -r79502:79501 to roll out r79502 because it broke the
SnowLeopard and Leopard builds.

Reviewed by Mark Rowe.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/HTMLConverter.h: Removed.
  • platform/mac/HTMLConverter.mm: Removed.
  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection):

5:56 PM Changeset in webkit [79512] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-02-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Refactored MarkedSpace to operate in terms of size classes
https://bugs.webkit.org/show_bug.cgi?id=55106


SunSpider reports no change.

  • runtime/JSCell.h: (JSC::JSCell::MarkedSpace::sizeClassFor): (JSC::JSCell::MarkedSpace::allocate): Delegate allocation based on size class. Since these functions are inline, the compiler can constant fold them.
  • runtime/MarkedBlock.h: (JSC::MarkedBlock::cellSize): (JSC::MarkedBlock::size): Factored out a cellSize() helper.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocateBlock): (JSC::MarkedSpace::allocateFromSizeClass): (JSC::MarkedSpace::shrink): (JSC::MarkedSpace::reset):
  • runtime/MarkedSpace.h: (JSC::MarkedSpace::SizeClass::SizeClass): (JSC::MarkedSpace::SizeClass::reset): Changed to operate in terms of abstract SizeClass objects, which are independent linked lists of blocks of a certain size class, instead of a single m_heap object.
5:47 PM Changeset in webkit [79511] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Fix for <rdar://problem/9002157> Garbage in the bottom right corner of the window
when scrolling

Reviewed by Dan Bernstein.

When there is both a horizontal and a vertical scrollbar, it is necessary to
include the space between them in the invalidation.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::setScrollOffsetFromAnimation):

5:45 PM Changeset in webkit [79510] by mitz@apple.com
  • 9 edits in trunk/Source/WebCore

Minimize calls to ubrk_setText()
https://bugs.webkit.org/show_bug.cgi?id=54912
<rdar://problem/9032774>

Patch by Ned Holbrook <nholbrook@apple.com> on 2011-02-23
Reviewed by Dan Bernstein.

Avoid calling ubrk_setText() once per call to isBreakable() by using a LazyLineBreakIterator, which defers
break iterator creation until needed. This requires replacing the global line break iterator primitive with a
version that can be nested, since in some cases two iterators may need to be outstanding. In particular,
layoutInlineChildren() may indirectly call computePreferredLogicalWidths() and each may need an iterator.
In a test with a paragraph of Japanese text, this reduced the number of ubrk_setText() calls from 164 to 1.

  • platform/text/TextBreakIterator.h: Add LazyLineBreakIterator.

(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::~LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::string):
(WebCore::LazyLineBreakIterator::length):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):

  • platform/text/TextBreakIteratorICU.cpp: Replace lineBreakIterator() primitive with acquireLineBreakIterator()/releaseLineBreakIterator().

(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):

  • platform/text/qt/TextBreakIteratorQt.cpp: Ditto TextBreakIteratorICU.cpp.

(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren): Pass a mapping of RenderText to LazyLineBreakIterator from one call of findNextLineBreak() to the next.
(WebCore::RenderBlock::findNextLineBreak): Use said mapping, resetting LazyLineBreakIterator for any newly-encountered RenderText.

  • rendering/RenderText.cpp: Use a local LazyLineBreakIterator.

(WebCore::RenderText::computePreferredLogicalWidths):

  • rendering/break_lines.cpp: Accept LazyLineBreakIterator rather than TextBreakIterator.

(WebCore::nextBreakablePosition):

  • rendering/break_lines.h: Accept LazyLineBreakIterator rather than TextBreakIterator.

(WebCore::isBreakable):

5:40 PM Changeset in webkit [79509] by andersca@apple.com
  • 15 edits in trunk/Source/WebKit2

2011-02-23 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove some of the old accelerated compositing code
https://bugs.webkit.org/show_bug.cgi?id=55084

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::exitAcceleratedCompositingMode):
  • UIProcess/API/mac/WKView.mm:
  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::exitAcceleratedCompositingMode):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm: (WebKit::LayerBackedDrawingAreaProxy::attachCompositingContext): (WebKit::LayerBackedDrawingAreaProxy::detachCompositingContext):
  • UIProcess/win/WebView.cpp:
  • UIProcess/win/WebView.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::enterAcceleratedCompositingMode): (WebKit::WebPage::exitAcceleratedCompositingMode):
  • WebProcess/WebPage/WebPage.h:
5:28 PM Changeset in webkit [79508] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

  • platform/mac/HTMLConverter.h:
5:20 PM Changeset in webkit [79507] by eae@chromium.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

2011-02-23 Emil A Eklund <eae@chromium.org>

Unreviewed.

Add myself to the list of committers.

5:00 PM Changeset in webkit [79506] by atwilson@chromium.org
  • 2 edits
    4 deletes in trunk/LayoutTests

Removed outdated/incorrect chromium baselins. Unreviewed.

  • platform/chromium-mac-leopard/editing/deleting/delete-tab-003-expected.txt: Removed.
  • platform/chromium-mac-leopard/editing/deleting/delete-ws-fixup-001-expected.txt: Removed.
  • platform/chromium-mac-leopard/editing/inserting/insert-tab-003-expected.txt: Removed.
  • platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
4:49 PM Changeset in webkit [79505] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-02-23 James Robinson <jamesr@chromium.org>

Update chromium expectations for fast/repaint/text-emphasis-h.html

  • platform/chromium/test_expectations.txt:
4:23 PM Changeset in webkit [79504] by jamesr@google.com
  • 2 edits
    3 adds in trunk/LayoutTests

2011-02-23 James Robinson <jamesr@chromium.org>

Update chromium baselines and expectations.

  • platform/chromium-mac/fast/repaint/text-emphasis-h-expected.txt: Added.
  • platform/chromium-mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Added.
  • platform/chromium-win/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:18 PM Changeset in webkit [79503] by abarth@webkit.org
  • 4 edits
    1 add in trunk/Source

2011-02-23 Adam Barth <abarth@webkit.org>

Reviewed by James Robinson.

[Chromium] Use WebKitClient for OSRandomSource instead of trying to talk to the file system in the sandbox
https://bugs.webkit.org/show_bug.cgi?id=55093

Exclude OSRandomSource.cpp from the Chromium build. This function is
implemented in WebKit/chromium/src instead.

2011-02-23 Adam Barth <abarth@webkit.org>

Reviewed by James Robinson.

[Chromium] Use WebKitClient for OSRandomSource instead of trying to talk to the file system in the sandbox
https://bugs.webkit.org/show_bug.cgi?id=55093

We need to get OS randomness from the WebKit client rather than try to
get it from /dev/urandom directly because WebKit doesn't have access to
the file system when running inside the Chromium sandbox.

  • WebKit.gyp:
  • src/ChromiumOSRandomSource.cpp: Added.
4:09 PM Changeset in webkit [79502] by enrica@apple.com
  • 3 edits
    2 adds in trunk/Source/WebCore

REGRESSION: Copied content loses formatting on paste to external apps.
https://bugs.webkit.org/show_bug.cgi?id=47615
<rdar://problem/9001214>

Reviewed by Darin Adler.

This patch adds a way for WebKit2 to create NSAttributedStrings from
a DOM range without using the AppKit api initWithDOMRange that internally
needs to access the WebView. The NSAttributedString is needed to create
RTF formats in the pasteboard.
This is to be considered a first step, since in the future we want to have
an implementation based on the TextIterator.

  • WebCore.xcodeproj/project.pbxproj: Added new file.
  • platform/mac/HTMLConverter.h: Added.
  • platform/mac/HTMLConverter.mm: Added.
  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection): We now use WebHTMLConverter
class for WebKit2 to create the NSAttributedString from the DOM range.

4:04 PM Changeset in webkit [79501] by oliver@apple.com
  • 7 edits in trunk

Roll out r64156 as it introduces incorrect behaviour.

4:02 PM Changeset in webkit [79500] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-23 Adam Barth <abarth@webkit.org>

Reviewed by James Robinson.

Roll Chromium DEPS
https://bugs.webkit.org/show_bug.cgi?id=55096

Rolling to the future, like a truck.

  • DEPS:
3:57 PM Changeset in webkit [79499] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

Reverting an unintentional change that was part of http://trac.webkit.org/changeset/79494.
Unreviewed.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::interceptEditingKeyboardEvent):

3:34 PM Changeset in webkit [79498] by atwilson@chromium.org
  • 1 edit
    15 deletes in trunk/LayoutTests

Unreviewed removal of superfluous chromium expectations.

  • platform/chromium-mac/editing/selection/move-past-trailing-space-expected.checksum: Removed.
  • platform/chromium-mac/editing/style/create-block-for-style-011-expected.checksum: Removed.
  • platform/chromium-mac/editing/style/create-block-for-style-011-expected.png: Removed.
  • platform/chromium-mac/editing/style/create-block-for-style-012-expected.checksum: Removed.
  • platform/chromium-mac/editing/style/create-block-for-style-012-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/text/trailing-white-space-2-expected.checksum: Removed.
  • platform/chromium-mac/fast/text/trailing-white-space-expected.checksum: Removed.
3:27 PM Changeset in webkit [79497] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Sam Weinig.

Patch computePositionedLogicalHeightUsing to be writing-mode-aware.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):

  • rendering/RenderBox.h:
3:19 PM Changeset in webkit [79496] by mihaip@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

2011-02-23 Mihai Parparita <mihaip@chromium.org>

Unreviewed. Revert incorrect baseline added by r79473.

  • platform/mac-leopard/fast/forms/text-control-intrinsic-widths-expected.txt: Removed.
3:05 PM Changeset in webkit [79495] by mrobinson@webkit.org
  • 3 edits
    1 add in trunk/Source/WebCore

2011-02-23 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Flash item placed on wrong location right after load
https://bugs.webkit.org/show_bug.cgi?id=37769

If a plugin is GtkSocket based, do not set the widget allocation until the
window is actually embedded in the parent. When the window is embedded, use
any pending allocation for the call to gtk_widget_size_allocate. This bug
seems to only appear with Flash movies loaded as the src of an iframe.

  • manual-tests/plugins/windowed-in-iframe.html: Added.
  • plugins/PluginView.h: Add a few new members to track window embedding state.
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setNPWindowIfNeeded): If this is a GtkSocket-based plugin wait until the plug-added signal fires to set the widget allocation. (WebCore::PluginView::plugAddedCallback): Updated to be a static method, so that we can access private members. If there is a pending allocation, call gtk_widget_size_allocate with it. (WebCore::PluginView::platformStart): Update the plugin state, so that we do not call gtk_widget_size_allocate if the window isn't embedded.
2:56 PM Changeset in webkit [79494] by enrica@apple.com
  • 18 edits in trunk/Source

Source/WebCore: Mac OS X Services are not available for selected text in WebKit2 windows.
https://bugs.webkit.org/show_bug.cgi?id=54777
<rdar://problem/8666428>

Reviewed by Adam Roben.

The changes to WebCore for this bug are limited to exposing a new
entry point in the Editor class to write to the pasteboard and
changes to the Pasteboard class to write the selection with
a given set of pasteboard types. The majority of the work
is done in WebKit2.

  • WebCore.exp.in:
  • editing/Editor.h:
  • editing/mac/EditorMac.mm: Added entrypoint to write the

selection to the pasteboard.
(WebCore::Editor::writeSelectionToPasteboard):

  • platform/Pasteboard.h:
  • platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::writeRange):

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection):

Source/WebKit2: Mac OS X Services are not available for selected text in WebKit2 windows.
https://bugs.webkit.org/show_bug.cgi?id=54777
<rdar://problem/8666428>

Reviewed by Adam Roben.

This patch adds support for Mac OS X Services in WebKit2 windows.
In WKView we now call registerServicesMenuSendTypes providing the
pasteboard types supported by WebKit and we also implement the two
protocol methods required to validate the send type and write the
content to the pasteboard. Unfortunately, AppKit expects the content
to be available in the pasteboard upon return from writeSelectionToPasteboard and
this is the reason why the call to the WebProcess is synchronous.

  • Shared/SelectionState.h:

(WebKit::SelectionState::SelectionState): Extended to include
isContentRichlyEditable

  • Shared/mac/PasteboardTypes.h:
  • Shared/mac/PasteboardTypes.mm:

(WebKit::PasteboardTypes::forSelection): Added.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]): Added call
to registerServicesMenuSendTypes.
(-[WKView writeSelectionToPasteboard:types:]): Added.
(-[WKView validRequestorForSendType:returnType:]): Added.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::writeSelectionToPasteboard):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::respondToChangedSelection): Modified to
support the new SelectionState value.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::writeSelectionToPasteboard): Added synchronous
message to write the selected content to the pasteboard.

2:55 PM Changeset in webkit [79493] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Simon Fraser.

Patch computePositionedLogicalHeight to be writing-mode-aware. Functions it calls have not been
patched yet, so still not testable in a vertical text environment.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalHeight):

2:51 PM Changeset in webkit [79492] by ggaren@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

2011-02-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Moved the "nextAtom" allocation pointer into MarkedBlock for better encapsulation
https://bugs.webkit.org/show_bug.cgi?id=55079


SunSpider reports no change.

  • runtime/Heap.cpp: (JSC::Heap::reset): Moved Zombie sweeping here, up from MarkedSpace, since we want Heap to logically control MarkedSpace. MarkedSpace should never choose to sweep itself.
  • runtime/JSCell.h: (JSC::JSCell::MarkedBlock::allocate): Updated for nextAtom becoming a member of MarkedBlock. No need to reset nextAtom to firstAtom() when we reach the end of a block, since there's now an explicit reset pass during GC.
  • runtime/MarkedBlock.cpp: (JSC::MarkedBlock::MarkedBlock):
  • runtime/MarkedBlock.h: (JSC::MarkedBlock::reset): Added the nextAtom data member, and reordered some data members to improve cache locality.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::reset):
  • runtime/MarkedSpace.h: (JSC::CollectorHeap::CollectorHeap): Removed nextAtom, and added an explicit reset pass.
2:47 PM Changeset in webkit [79491] by mihaip@chromium.org
  • 2 edits
    1 move in trunk/LayoutTests

2011-02-23 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update. Remove tests that pass after
r79473, do the equivalent chromium-mac-leopard update for
fast/text/international/pop-up-button-text-alignment-and-direction.html

  • platform/chromium-mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt.
  • platform/chromium/test_expectations.txt:
2:25 PM Changeset in webkit [79490] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Sam Weinig.

Patch computePositionedLogicalWidthUsing to be writing-mode-aware. Still not testable in a vertical text
environment, since height computations will overwrite all values computed here until they are patched as well.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidthUsing):

  • rendering/RenderBox.h:
2:22 PM Changeset in webkit [79489] by atwilson@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

More unreviewed expectations cleanup for chromium.

  • platform/chromium-mac-leopard/editing/deleting/delete-tab-003-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/deleting/delete-tab-003-expected.png: Added.
  • platform/chromium-mac-leopard/editing/deleting/delete-ws-fixup-001-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/deleting/delete-ws-fixup-001-expected.png: Added.
  • platform/chromium-mac-leopard/editing/inserting/insert-tab-003-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/inserting/insert-tab-003-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png: Added.
2:11 PM Changeset in webkit [79488] by reni@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-02-23 Renata Hodovan <reni@webkit.org>

Reviewed by Nikolas Zimmermann.

FEColorMatrixElement changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=54880

When the FEColorMatrixElement receives an update message but the given value remains the same we don't need
to relayout the filter.

No new tests are needed because this modificiation is covered by the dynamic update tests of FEColorMatrix.

  • platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::setType): (WebCore::FEColorMatrix::setValues):
  • platform/graphics/filters/FEColorMatrix.h:
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::setFilterEffectAttribute): (WebCore::SVGFEColorMatrixElement::svgAttributeChanged):
  • svg/SVGFEColorMatrixElement.h:
2:08 PM Changeset in webkit [79487] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-23 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

[Chromium] Add WebKitClient::cryptographicallyRandomValues
https://bugs.webkit.org/show_bug.cgi?id=55073

This patch adds a WebKit client API to get cryptographic randomness.
We'll use this API to gather seed randomness while inside the sandbox.

  • public/WebKitClient.h: (WebKit::WebKitClient::cryptographicallyRandomValues):
2:06 PM Changeset in webkit [79486] by jamesr@google.com
  • 2 edits in trunk/Source/WebCore

2011-02-23 James Robinson <jamesr@chromium.org>

REGRESSION(79466): fast/parser/test-unicode-characters-in-attribute-name.html fails

Reverts TextCodecUTF16.cpp back to pre-79466 state. The crash fix in 79466 was for UTF-8 only, it also caused the UTF16 path to fail.

  • platform/text/TextCodecUTF16.cpp: (WebCore::newStreamingTextDecoderUTF16LE): (WebCore::newStreamingTextDecoderUTF16BE): (WebCore::TextCodecUTF16::decode): (WebCore::TextCodecUTF16::encode):
2:04 PM Changeset in webkit [79485] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Sam Weinig.

Patch computePositionedLogicalWidth to be writing-mode-aware. Functions it calls have not been
patched yet, so still not testable in a vertical text environment.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidth):

1:55 PM Changeset in webkit [79484] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-23 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add a ShareableBitmap::create overload that takes an existing SharedMemory object
https://bugs.webkit.org/show_bug.cgi?id=55081

  • Shared/ShareableBitmap.cpp: (WebKit::ShareableBitmap::createShareable): (WebKit::ShareableBitmap::create):
  • Shared/ShareableBitmap.h:
1:40 PM Changeset in webkit [79483] by jamesr@google.com
  • 4 edits in trunk/Source

2011-02-23 James Robinson <jamesr@chromium.org>

Unreviewed, rolling out r79428.
http://trac.webkit.org/changeset/79428
https://bugs.webkit.org/show_bug.cgi?id=54714

Does not work in the Chromium sandbox

2011-02-23 James Robinson <jamesr@chromium.org>

Unreviewed, rolling out r79428.
http://trac.webkit.org/changeset/79428
https://bugs.webkit.org/show_bug.cgi?id=54714

Does not work in the Chromium sandbox

  • websockets/WebSocketHandshake.cpp: (WebCore::generateSecWebSocketKey): (WebCore::generateKey3):
1:32 PM Changeset in webkit [79482] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Sam Weinig.

Add logical accessors for the left()/right()/top()/bottom() properties on the RenderStyle.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::logicalLeft):
(WebCore::InheritedFlags::logicalRight):
(WebCore::InheritedFlags::logicalTop):
(WebCore::InheritedFlags::logicalBottom):

1:31 PM Changeset in webkit [79481] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-23 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update. Add failing expectations for
two editing tests that were hidden by the TIMEOUT expectation remove by
r79480.

  • platform/chromium/test_expectations.txt:
1:21 PM Changeset in webkit [79480] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-23 Mihai Parparita <mihaip@chromium.org>

Unreviewed.

Many tests started timing out on the chrome mac canaries around r79035
https://bugs.webkit.org/show_bug.cgi?id=54885

Remove TIMEOUT expectations from tests, they were caused by a bad bot
(and are passing now that the bot has been restarted).

  • platform/chromium/test_expectations.txt:
1:08 PM Changeset in webkit [79479] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-23 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Web Inspector toolbar looks bad in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=55076
<rdar://problem/8866258>

  • UIProcess/API/mac/WKView.mm: (-[WKView mouseDownCanMoveWindow]): Return NO from mouseDownCanMoveWindow to prevent drags in the (now transparent) inspector WKView from dragging the window around.
  • UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage): Call [WKView setDrawsBackground:NO].
1:05 PM Changeset in webkit [79478] by atwilson@chromium.org
  • 1 edit
    290 adds in trunk/LayoutTests

Unreviewed expectations update for chromium.

  • platform/chromium-mac-leopard/editing/inserting/typing-tab-designmode-forms-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/inserting/typing-tab-designmode-forms-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/4641033-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/4641033-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/block-wrappers-necessary-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/block-wrappers-necessary-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/nested-blocks-with-text-area-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/nested-blocks-with-text-area-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/nested-blocks-with-text-field-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/nested-blocks-with-text-field-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-2-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-2-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/pasting-tabs-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/pasting-tabs-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/3690703-2-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/3690703-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/selection/3690703-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/3690719-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/selection/3690719-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/4975120-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/selection/4975120-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/5240265-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/selection/5240265-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/replaced-boundaries-3-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/selection/replaced-boundaries-3-expected.png: Added.
  • platform/chromium-mac-leopard/editing/style/5046875-1-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/style/5046875-1-expected.png: Added.
  • platform/chromium-mac-leopard/editing/style/table-selection-expected.checksum: Added.
  • platform/chromium-mac-leopard/editing/style/table-selection-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/inline-block-relposition-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/inline-block-relposition-expected.png: Added.
  • platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/continuationCrash-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/css/continuationCrash-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/css2-system-fonts-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/css/css2-system-fonts-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/font-face-locally-installed-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/css/font-face-locally-installed-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/margin-top-bottom-dynamic-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/css/margin-top-bottom-dynamic-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/text-overflow-ellipsis-strict-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/css/text-overflow-ellipsis-strict-expected.png: Added.
  • platform/chromium-mac-leopard/fast/dom/HTMLInputElement/input-image-alt-text-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Added.
  • platform/chromium-mac-leopard/fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Added.
  • platform/chromium-mac-leopard/fast/events/autoscroll-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/events/autoscroll-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label01-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label01-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label02-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label02-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label03-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label03-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label04-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/HTMLOptionElement_label04-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/basic-textareas-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/basic-textareas-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/basic-textareas-quirks-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/basic-textareas-quirks-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/blankbuttons-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/blankbuttons-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/button-align-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/button-align-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/button-cannot-be-nested-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/button-cannot-be-nested-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/button-default-title-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/button-default-title-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/button-generated-content-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/button-generated-content-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/button-positioned-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/button-positioned-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/button-style-color-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/button-style-color-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/button-table-styles-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/button-table-styles-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/button-text-transform-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/button-text-transform-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/button-white-space-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/button-white-space-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/control-clip-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/control-clip-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/control-restrict-line-height-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/control-restrict-line-height-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/formmove3-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/formmove3-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-align-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-align-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-disabled-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-disabled-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-focus-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-focus-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-preventDefault-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-preventDefault-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-readonly-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-readonly-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-selection-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-selection-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-visibility-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-visibility-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-width-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-appearance-width-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-field-text-truncated-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-field-text-truncated-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-first-letter-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-first-letter-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-readonly-autoscroll-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-readonly-autoscroll-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-readonly-dimmed-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-readonly-dimmed-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-spaces-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-spaces-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-table-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-table-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-text-double-click-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-text-drag-down-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-text-scroll-left-on-blur-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-text-word-wrap-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/input-text-word-wrap-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/menulist-no-overflow-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/menulist-no-overflow-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/menulist-width-change-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/menulist-width-change-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/option-strip-whitespace-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/option-strip-whitespace-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/option-text-clip-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/option-text-clip-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/placeholder-set-value-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/placeholder-set-value-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/plaintext-mode-2-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/plaintext-mode-2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/search-cancel-button-style-sharing-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/search-cancel-button-style-sharing-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/search-rtl-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/search-rtl-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/search-zoomed-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/search-zoomed-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/select-align-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/select-align-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/select-change-listbox-to-popup-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/select-change-listbox-to-popup-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/select-disabled-appearance-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/select-disabled-appearance-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/select-initial-position-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/select-initial-position-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/select-selected-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/select-selected-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/stuff-on-my-optgroup-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/stuff-on-my-optgroup-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/tabbing-input-iframe-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/tabbing-input-iframe-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/targeted-frame-submission-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/targeted-frame-submission-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/textarea-align-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/textarea-align-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/textarea-placeholder-set-value-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/textarea-placeholder-set-value-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/textarea-scroll-height-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/textarea-scroll-height-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/textarea-scrolled-type-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/forms/textarea-scrolled-type-expected.png: Added.
  • platform/chromium-mac-leopard/fast/parser/document-write-option-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/parser/document-write-option-expected.png: Added.
  • platform/chromium-mac-leopard/fast/parser/entity-comment-in-textarea-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/parser/entity-comment-in-textarea-expected.png: Added.
  • platform/chromium-mac-leopard/fast/parser/open-comment-in-textarea-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/parser/open-comment-in-textarea-expected.png: Added.
  • platform/chromium-mac-leopard/fast/replaced/width100percent-button-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/replaced/width100percent-button-expected.png: Added.
  • platform/chromium-mac-leopard/fast/replaced/width100percent-searchfield-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/replaced/width100percent-searchfield-expected.png: Added.
  • platform/chromium-mac-leopard/fast/replaced/width100percent-textfield-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/replaced/width100percent-textfield-expected.png: Added.
  • platform/chromium-mac-leopard/fast/selectors/064-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/selectors/064-expected.png: Added.
  • platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png: Added.
  • platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/table/append-cells2-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/table/append-cells2-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/border-collapsing/004-vertical-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/table/border-collapsing/004-vertical-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/frame-and-rules-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/table/frame-and-rules-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/remove-td-display-none-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/table/remove-td-display-none-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/atsui-partial-selection-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/atsui-partial-selection-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/backslash-to-yen-sign-euc-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/capitalize-boundaries-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/capitalize-boundaries-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/line-breaks-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/line-breaks-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/word-break-run-rounding-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/text/word-break-run-rounding-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug138725-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug138725-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug14323-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug14323-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug18359-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug18359-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug26178-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug26178-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug28928-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug28928-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2962-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug2962-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug30692-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug30692-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug33855-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug33855-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug39209-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug39209-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4429-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4429-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug44505-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug44505-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-1-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-1-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-2-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug46368-2-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug51037-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug51037-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug51727-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug51727-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug52505-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug52505-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug52506-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug52506-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug60749-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug60749-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug67915-1-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug67915-1-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug68912-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug68912-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug7342-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug7342-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug88035-1-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug88035-1-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug88035-2-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug88035-2-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug96334-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug96334-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/collapsing_borders/bug41262-4-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/dom/tableDom-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/dom/tableDom-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla/other/move_row-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla/other/move_row-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug58402-2-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.checksum: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png: Added.
12:57 PM Changeset in webkit [79477] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Fix crash seen in one of the regression tests.

Reviewed by Alexey Proskuryakov.

  • platform/text/TextCodecUTF16.cpp:

(WebCore::TextCodecUTF16::decode): Handle case where we did not decode any new data,
we were not told to flush, and we had a buffered byte. The assertion here was incorrect,
and the correct thing to do is nothing.

12:49 PM Changeset in webkit [79476] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-23 Sergey Glazunov <serg.glazunov@gmail.com>

Reviewed by James Robinson.

SVGCursorElement::removeClient() should verify that its argument is connected with
the proper cursor element.
https://bugs.webkit.org/show_bug.cgi?id=54979

Test: svg/css/multiple-cursors-crash.html

  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::removeClient):

2011-02-23 Sergey Glazunov <serg.glazunov@gmail.com>

Reviewed by James Robinson.

SVGCursorElement::removeClient() should verify that its argument is connected with
the proper cursor element.
https://bugs.webkit.org/show_bug.cgi?id=54979

  • svg/css/multiple-cursors-crash-expected.txt: Added.
  • svg/css/multiple-cursors-crash.html: Added.
12:45 PM Changeset in webkit [79475] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Fix an off-by-one error in JSC::appendSourceToError

Looks like this bug has been around since the code was first added in r35245.

Fixes <http://webkit.org/b/55052> <rdar://problem/9043512> Crash in JSC::appendSourceToError
when running fast/dom/objc-big-method-name.html on Windows with full page heap enabled

Reviewed by Darin Adler.

  • interpreter/Interpreter.cpp:

(JSC::appendSourceToError): When trimming whitespace off the end of the string, examine the
character at stop-1 rather than at stop. At this point in the code, stop represents the
index just past the end of the characters we care about, and can even be just past the end
of the entire data buffer.

12:45 PM Changeset in webkit [79474] by reni@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-02-23 Renata Hodovan <reni@webkit.org>

Reviewed by Darin Adler.

FEConvolveMatrixElement changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=55067

When the FEConvolveMatrixElement receives an update message but the
given value remains the same we don't need to relayout the filter.

No new tests are needed because this modificiation is covered by the
dynamic update tests of FEConvolveMatrix.

  • platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::setDivisor): (WebCore::FEConvolveMatrix::setBias): (WebCore::FEConvolveMatrix::setTargetOffset): (WebCore::FEConvolveMatrix::edgeMode): (WebCore::FEConvolveMatrix::setEdgeMode): (WebCore::FEConvolveMatrix::setPreserveAlpha):
  • platform/graphics/filters/FEConvolveMatrix.h:
  • svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::setFilterEffectAttribute): (WebCore::SVGFEConvolveMatrixElement::svgAttributeChanged):
  • svg/SVGFEConvolveMatrixElement.h:
12:45 PM Changeset in webkit [79473] by Simon Fraser
  • 16 edits
    3 adds
    2 deletes in trunk/LayoutTests

2011-02-22 Simon Fraser <Simon Fraser>

New Leopard results after r78846.

  • platform/mac-leopard/css2.1/t1202-counter-04-b-expected.txt:
  • platform/mac-leopard/css2.1/t1202-counters-04-b-expected.txt:
  • platform/mac-leopard/fast/blockflow/border-vertical-lr-expected.txt: Added.
  • platform/mac-leopard/fast/dom/52776-expected.txt:
  • platform/mac-leopard/fast/forms/basic-selects-expected.txt:
  • platform/mac-leopard/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/mac-leopard/fast/forms/text-control-intrinsic-widths-expected.txt: Added.
  • platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt:
  • platform/mac-leopard/fast/text/international/bidi-menulist-expected.txt:
  • platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/mac-leopard/fast/text/international/text-combine-image-test-expected.txt: Added.
  • platform/mac-leopard/media/controls-after-reload-expected.txt:
  • platform/mac-leopard/media/controls-strict-expected.txt:
  • platform/mac-leopard/media/controls-styling-expected.txt:
  • platform/mac-leopard/media/video-controls-rendering-expected.txt:
  • platform/mac-leopard/media/video-display-toggle-expected.txt:
  • platform/mac-leopard/media/video-no-audio-expected.txt:
  • platform/mac-leopard/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Removed.
  • platform/mac-leopard/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Removed.
12:25 PM Changeset in webkit [79472] by ggaren@apple.com
  • 12 edits
    3 adds in trunk/Source

2011-02-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.


Rolled back in r79367 with SnowLeopard Release bot crash fixed.
https://bugs.webkit.org/show_bug.cgi?id=54999


The crash was caused by failure to update the "nextBlock" pointer when
removing a block from the list while shrinking. The fix is to update the
"nextBlock" pointer.


This crash was very rare because it only happened in cases where the very
first block in the heap contained no marked cells.

2011-02-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Rolled back in r79367 with SnowLeopard Release bot crash fixed.
https://bugs.webkit.org/show_bug.cgi?id=54999

2011-02-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Rolled back in r79367 with SnowLeopard Release bot crash fixed.
https://bugs.webkit.org/show_bug.cgi?id=54999

  • ForwardingHeaders/wtf/DoublyLinkedList.h: Added.
12:13 PM Changeset in webkit [79471] by weinig@apple.com
  • 12 edits
    1 delete in trunk/Source/WebKit2

Remove WKPageForceRepaintWithInvalidation and instead make WKPageForceRepaint
always dirty the entire page.

Reviewed by Anders Carlsson.

  • Shared/ForceRepaintFlags.h: Removed.
  • UIProcess/API/C/WKPage.cpp:

(WKPageForceRepaint):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::forceRepaint):

  • UIProcess/WebPageProxy.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::forceRepaint):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::forceRepaint):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • win/WebKit2.vcproj:
12:08 PM Changeset in webkit [79470] by Dimitri Glazkov
  • 1 edit
    1 add in trunk/Source/WebCore

2011-02-23 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Add more thorough manual test coverage for media controls
https://bugs.webkit.org/show_bug.cgi?id=55006

  • manual-tests/media-controls.html: Added.
12:07 PM Changeset in webkit [79469] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Fix build.

  • platform/text/TextCodecUTF16.cpp:

(WebCore::TextCodecUTF16::decode): Removed stray unused local variable.

12:06 PM Changeset in webkit [79468] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-02-23 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Setting shadow host should also attach and set inDocument, just like
appending/inserting a child.
https://bugs.webkit.org/show_bug.cgi?id=55065

No new tests, because functionality is not yet used.

  • dom/Element.cpp: (WebCore::Element::setShadowRoot): Add attaching and setting inDocument

for the shadow DOM subtree, like the host.

12:00 PM Changeset in webkit [79467] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Darin Adler and Simon Fraser.

  • Add clientLogicalWidth and clientLogicalHeight that call the correct clientWidth or clientHeight based off

writing-mode.

  • Patch clientLogicalBottom to use clientLogicalHeight.
  • Convert containingBlockWidthForPositioned and containingBlockHeightForPositioned to be logical and to make use of

clientLogicalHeight/Width. Also make them able to handle perpendicular writing mode containining blocks.

  • Refine containingBlockLogicalHeightForPositioned to match containingBlockLogicalWidthForPositioned more closely.


  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

  • rendering/RenderBox.h:

(WebCore::RenderBox::clientLogicalWidth):
(WebCore::RenderBox::clientLogicalHeight):
(WebCore::RenderBox::clientLogicalBottom):

12:00 PM Changeset in webkit [79466] by Darin Adler
  • 4 edits in trunk/Source/WebCore

2011-02-23 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

REGRESSION (new UTF-8 decoder): Reproducible crash on alltommac.se
https://bugs.webkit.org/show_bug.cgi?id=54862

Correct handling of end of buffer partial sequence in UTF-8 and UTF-16 decoders when flushing with zero length
https://bugs.webkit.org/show_bug.cgi?id=54444

No new tests at this time. I will add some tests later, but since multiple
people are hitting this I wanted to get it in as quickly as possible.

  • platform/text/TextCodecUTF16.cpp: (WebCore::TextCodecUTF16::decode): Tweaked coding style quite a bit. Removed special case for zero length now that main code handles it correctly. Used words instead of abbreviations for local variable names. Added error handling for a trailing byte.
  • platform/text/TextCodecUTF8.cpp: (WebCore::TextCodecUTF8::consumePartialSequenceByte): Added. Helper function to make the handleError and handlePartialSequence functions clearer. (WebCore::TextCodecUTF8::handleError): Added. Helper function to make the handlePartialSequence clearer. (WebCore::TextCodecUTF8::handlePartialSequence): Added. Factored out code for the partial sequence case. Making this a separate function probably helps make the fast case a little faster. This new version handles more cases correctly, which is what fixes the crashes we were seeing. In particular, it no longer assumes that the partial sequence is truly partial, because there are cases where we end up handling complete sequences here, such as when a complete sequence is inside a malformed partial sequence. (WebCore::TextCodecUTF8::decode): Removed partial sequence code and made this call handlePartialSequence instead. Could be streamlined if we double checked that passing a reference to "destination" and "source" doesn't harm code generation too much, so perhaps someone can do that research on a few compilers later and clean this up. Removed special case for zero length now that the main code handles that correctly.
  • platform/text/TextCodecUTF8.h: Added declarations for new functions. Made partial sequence buffer large enough to hold a whole sequence so we can use it to complete and decode a sequence in place.
11:42 AM Changeset in webkit [79465] by inferno@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-02-23 Abhishek Arya <inferno@chromium.org>

Unreviewed. Qt rebaseline for my crasher test in r79462.

  • platform/qt/fast/overflow/overflow-height-float-not-removed-crash3-expected.txt: Added.
11:17 AM Changeset in webkit [79464] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-02-23 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Race condition when creating and destroying pages quickly
https://bugs.webkit.org/show_bug.cgi?id=55061
<rdar://problem/8708435>

When the last page in a web process is closed, the web process would
previously terminate, even if the UI process had created a new page
(the CreateNewPage message just wouldn't have reached the web process yet).

Fix this by adding a ShouldTerminate message that the web process sends when it's
about to terminate. If the UI process has any pending pages, downloads etc. it will
prevent the web process from terminating. Otherwise, it will immmediately disconnect
the WebPageProxy so that creating a page after that will launch a new web process.

  • UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::shouldTerminate):
  • UIProcess/Plugins/WebPluginSiteDataManager.h:
  • UIProcess/WebContext.cpp: (WebKit::WebContext::shouldTerminate): (WebKit::WebContext::disconnectProcess):
  • UIProcess/WebContext.h:
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::disconnect): (WebKit::WebProcessProxy::didReceiveSyncMessage): (WebKit::WebProcessProxy::didClose): (WebKit::WebProcessProxy::shouldTerminate):
  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in:
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::terminateIfPossible):
11:03 AM Changeset in webkit [79463] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-02-23 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Ariya Hidayat.

[Qt] tst_QWebView::setPalette(activeFG) fails
https://bugs.webkit.org/show_bug.cgi?id=55029

Attempt to make the test more robust. By investigating with the bot virtual machine
I discovered that the activation can take some time. In this patch we make sure that
the active window we want to have is the same as the QApplication.

  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::setPalette):
11:03 AM Changeset in webkit [79462] by inferno@chromium.org
  • 4 edits
    4 adds
    2 deletes in trunk

2011-02-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Rename a layouttest for conformity. Tests that we do not crash
when trying to overflow the logical height of a root inline box.
https://bugs.webkit.org/show_bug.cgi?id=54995

  • fast/overflow/overflow-block-logical-height-crash-expected.txt: Removed.
  • fast/overflow/overflow-block-logical-height-crash.html: Removed.
  • fast/overflow/overflow-height-float-not-removed-crash2-expected.txt: Added.
  • fast/overflow/overflow-height-float-not-removed-crash2.html: Added.
  • fast/overflow/overflow-height-float-not-removed-crash3-expected.txt: Added.
  • fast/overflow/overflow-height-float-not-removed-crash3.html: Added.

2011-02-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Make clear float lineboxes resilient against overflows.
https://bugs.webkit.org/show_bug.cgi?id=54995

We try to dirty everthing in block range if we have a negative
logical bottom, or if our logical bottom is less than our logical
top, or if our logical top is equal to INT_MAX. Plus, we also dirty
a linebox if its block logical height is less than zero.
Tests: fast/overflow/overflow-height-float-not-removed-crash2.html

fast/overflow/overflow-height-float-not-removed-crash3.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeFloatingObject): (WebCore::RenderBlock::markLinesDirtyInBlockRange):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::alignBoxesInBlockDirection): remove the hack added in r69735. we don't need this anymore since we are making the underlying float dirty logic resilient.
11:01 AM Changeset in webkit [79461] by mitz@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Include frame numbers in backtraces.
https://bugs.webkit.org/show_bug.cgi?id=55060

Reviewed by Gavin Barraclough.

  • wtf/Assertions.cpp:
10:55 AM Changeset in webkit [79460] by xan@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-23 Xan Lopez <xlopez@igalia.com>

Reviewed by Gavin Barraclough.

latest jsc for armv7 crashes in sunspider tests
https://bugs.webkit.org/show_bug.cgi?id=54667

Update JIT offset values in ARMv7 after r78732. Fixes crashes in
SunSpider and JavaScript tests.

  • jit/JIT.h: update values.
10:50 AM Changeset in webkit [79459] by mthole@apple.com
  • 2 edits in trunk/Source/WebKit2

WKBundleNavigationAction.h should be exposed as a public header
https://bugs.webkit.org/show_bug.cgi?id=55059

Reviewed by Darin Adler.

  • WebKit2.xcodeproj/project.pbxproj:

Changed WKBundleNavigationAction.h from 'project' to 'public'.

10:34 AM Changeset in webkit [79458] by hans@chromium.org
  • 64 edits in trunk/LayoutTests

2011-02-23 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Each layout test should use a separate DB
https://bugs.webkit.org/show_bug.cgi?id=55042

Each layout test should use a separate database to avoid problems in
case tests are run concurrently.

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics.html:
  • storage/indexeddb/create-and-remove-object-store-expected.txt:
  • storage/indexeddb/create-and-remove-object-store.html:
  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/create-object-store-options.html:
  • storage/indexeddb/cursor-delete-expected.txt:
  • storage/indexeddb/cursor-delete.html:
  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/cursor-skip-deleted-expected.txt:
  • storage/indexeddb/cursor-skip-deleted.html:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/cursor-update.html:
  • storage/indexeddb/data-corruption-expected.txt:
  • storage/indexeddb/data-corruption.html:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/duplicates-expected.txt:
  • storage/indexeddb/duplicates.html:
  • storage/indexeddb/error-causes-abort-by-default-expected.txt:
  • storage/indexeddb/error-causes-abort-by-default.html:
  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/exception-in-event-aborts.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-autoincrement.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-clear-expected.txt:
  • storage/indexeddb/objectstore-clear.html:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/queued-commands-expected.txt:
  • storage/indexeddb/queued-commands.html:
  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/request-event-propagation.html:
  • storage/indexeddb/set_version_blocked-expected.txt:
  • storage/indexeddb/set_version_blocked.html:
  • storage/indexeddb/set_version_queue-expected.txt:
  • storage/indexeddb/set_version_queue.html:
  • storage/indexeddb/transaction-after-close-expected.txt:
  • storage/indexeddb/transaction-after-close.html:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls.html:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:
  • storage/indexeddb/transaction-crash-on-abort-expected.txt:
  • storage/indexeddb/transaction-crash-on-abort.html:
  • storage/indexeddb/transaction-event-propagation-expected.txt:
  • storage/indexeddb/transaction-event-propagation.html:
  • storage/indexeddb/transaction-read-only-expected.txt:
  • storage/indexeddb/transaction-read-only.html:
  • storage/indexeddb/tutorial.html:
10:26 AM Changeset in webkit [79457] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-23 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update. Add final set of
Snow Leopard-only failures.

  • platform/chromium/test_expectations.txt:
10:14 AM Changeset in webkit [79456] by kbr@google.com
  • 4 edits in trunk

2011-02-23 Kenneth Russell <kbr@google.com>

Unreviewed, rolling out r79387.
https://bugs.webkit.org/show_bug.cgi?id=54885

Reapply the code changes from r79038 since they weren't the root
cause of the test timeouts.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::reset):

2011-02-23 Kenneth Russell <kbr@google.com>

Unreviewed, rolling out r79387.
https://bugs.webkit.org/show_bug.cgi?id=54885

Reapply the code changes from r79038 since they weren't the root
cause of the test timeouts.

  • src/WebKit.cpp: (WebKit::initialize):
10:00 AM Changeset in webkit [79455] by kbr@google.com
  • 4 edits
    4 adds in trunk

2011-02-22 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Per-page minimum DOMTimer interval broken for repeating timers
https://bugs.webkit.org/show_bug.cgi?id=55014

When the minimum timer interval is adjusted, if the timer is
repeating, cause its repeat interval to be set to its original
timeout clamped to the new minimum interval.

Tests: fast/dom/timer-increase-min-interval-repeating.html

fast/dom/timer-increase-then-decrease-min-interval-repeating.html

  • page/DOMTimer.cpp: (WebCore::DOMTimer::adjustMinimumTimerInterval):

2011-02-23 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Per-page minimum DOMTimer interval broken for repeating timers
https://bugs.webkit.org/show_bug.cgi?id=55014

Add tests using setInterval rather than setTimeout.
timer-increase-then-decrease-min-interval-repeating.html catches
the bug.

  • fast/dom/timer-increase-min-interval-repeating-expected.txt: Added.
  • fast/dom/timer-increase-min-interval-repeating.html: Added.
  • fast/dom/timer-increase-then-decrease-min-interval-repeating-expected.txt: Added.
  • fast/dom/timer-increase-then-decrease-min-interval-repeating.html: Added.
  • platform/mac-wk2/Skipped:
9:43 AM Changeset in webkit [79454] by jberlin@webkit.org
  • 3 edits in trunk/LayoutTests

[Windows 7 Release Tests] ~26 tests failing after r78846
https://bugs.webkit.org/show_bug.cgi?id=54748

Update the pixel results for fast/blockflow/Kusa-Makura-background-canvas.html.
The pixel results for fast/ruby/nested-ruby.html turned out to be identical to
those before r78846. Unreviewed.

  • platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
  • platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
9:38 AM Changeset in webkit [79453] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-23 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update. Mark failures from bug 54885
as being Leopard-only (which they are) so that they don't result in
duplicates with all the Snow Leopard expectations.

  • platform/chromium/test_expectations.txt:
9:27 AM Changeset in webkit [79452] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-23 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update. Add more Snow Leopard-only
failures.

  • platform/chromium/test_expectations.txt:
9:10 AM Changeset in webkit [79451] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Fix two issues seen in WebKit2 views on Mac:

  • <rdar://problem/8867831> WebKit2: Insertion points in form fields no longer blink
  • <rdar://problem/8950362> REGRESSION (WebKit2): Cannot deselect text

Reviewed by Maciej Stachowiak.

  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler): Initialize m_activationEventNumber
to -1. Since WebKit2 doesn't support non-activating clicks yet (<http://webkit.org/b/55053>
<rdar://problem/9042197>) and doesn't send event numbers, all events were considered to be
window-activating events. This in turn prevented them from clearing the selection and resuming
caret blinking on mouse up.

9:07 AM Changeset in webkit [79450] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-02-23 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Dan Bernstein.

[Qt]REGRESSION(r79167): It broke 3 Qt-API test cases
http://trac.webkit.org/changeset/79167 refactored the way the bound size of
the frame is handled. A new API setBoundsSize was added, we need to call it
in addition to setFrameRect. I could call setBoundSize after setFrameRect but
I thought It would be more elegant to use the resize method.

  • Api/qwebpage.cpp: (QWebPage::setViewportSize):
8:38 AM Changeset in webkit [79449] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-23 Jacob Dinu <dinu.jacob@nokia.com>

Reviewed by Pavel Feldman.

Web Inspector: Linking error for some InspectorController symbols
https://bugs.webkit.org/show_bug.cgi?id=54953

Moved out hideHighlight definition from under JAVASCRIPT_DEBUGGER flag

  • inspector/InspectorController.cpp: (WebCore::InspectorController::hideHighlight): (WebCore::InspectorController::resume):
8:30 AM Changeset in webkit [79448] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-23 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update. Add more Snow Leopard-only
failures.

  • platform/chromium/test_expectations.txt:
8:14 AM Changeset in webkit [79447] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-23 MORITA Hajime <morrita@google.com>

Unreviewed test_expectations.txt update.

Added TIMEOUTs that the last change missed.

  • platform/chromium/test_expectations.txt:
7:41 AM Changeset in webkit [79446] by Laszlo Gombos
  • 4 edits in trunk

2011-02-23 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Make sure Symbian binary UIDs are unique

  • WebProcess.pro: Resolve the UID collision with QtTestBrowser.pro by changing the UID.

2011-02-23 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Make sure Symbian binary UIDs are unique

  • MiniBrowser/qt/MiniBrowser.pro: Resolve the UID collision with QtTestBrowser.pro by changing the UID.
7:10 AM Changeset in webkit [79445] by hans@chromium.org
  • 7 edits in trunk/Source/WebCore

2011-02-23 Hans Wennborg <hans@chromium.org>

IndexedDB: Move some SQL code into IDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=54889

The idea is to gather all the SQL logic into IDBBackingStore.

No new functionality, so no new tests.

  • storage/IDBBackingStore.cpp: (WebCore::IDBBackingStore::IDBBackingStore): (WebCore::runCommands): (WebCore::createTables): (WebCore::createMetaDataTable): (WebCore::getDatabaseSchemaVersion): (WebCore::migrateDatabase): (WebCore::IDBBackingStore::open): (WebCore::IDBBackingStore::extractIDBDatabaseMetaData): (WebCore::IDBBackingStore::setIDBDatabaseMetaData): (WebCore::IDBBackingStore::getObjectStores): (WebCore::IDBBackingStore::createObjectStore): (WebCore::doDelete): (WebCore::IDBBackingStore::deleteObjectStore): (WebCore::whereSyntaxForKey): (WebCore::bindKeyToQuery): (WebCore::IDBBackingStore::getObjectStoreRecord): (WebCore::bindKeyToQueryWithNulls): (WebCore::IDBBackingStore::putObjectStoreRecord): (WebCore::IDBBackingStore::deleteIndexDataForRecord): (WebCore::IDBBackingStore::putIndexDataForRecord): (WebCore::IDBBackingStore::createIndex): (WebCore::IDBBackingStore::deleteIndex): (WebCore::IDBBackingStore::clearObjectStore):
  • storage/IDBBackingStore.h:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl): (WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal): (WebCore::IDBDatabaseBackendImpl::deleteObjectStoreInternal): (WebCore::IDBDatabaseBackendImpl::setVersionInternal): (WebCore::IDBDatabaseBackendImpl::loadObjectStores):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl): (WebCore::IDBFactoryBackendImpl::addIDBBackingStore): (WebCore::IDBFactoryBackendImpl::removeIDBBackingStore): (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::getInternal): (WebCore::IDBObjectStoreBackendImpl::putInternal): (WebCore::IDBObjectStoreBackendImpl::clearInternal): (WebCore::populateIndex): (WebCore::IDBObjectStoreBackendImpl::createIndexInternal): (WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
6:48 AM Changeset in webkit [79444] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-23 MORITA Hajime <morrita@google.com>

Unreviewed test_expectations.txt update.

  • platform/chromium/test_expectations.txt:
6:46 AM Changeset in webkit [79443] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-02-23 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix the Symbian build after r79334
https://bugs.webkit.org/show_bug.cgi?id=55044

No new tests as there is no new functionality.

  • WebCore.pri: Reorder symbian blocks to make sure that system-sqlite is set before it is tested.

Copy the rules from JavaScriptCore.pri for defineTest().

2011-02-23 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix the Symbian build after r79334
https://bugs.webkit.org/show_bug.cgi?id=55044

  • WebKit2.pri: Copy the rules from JavaScriptCore.pri for defineTest().

Remove addWebKit2LibWholeArchive as it is no longer needed.

6:40 AM Changeset in webkit [79442] by morrita@google.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r79418.
http://trac.webkit.org/changeset/79418
https://bugs.webkit.org/show_bug.cgi?id=55043

"breaks shlib linux build" (Requested by morrita on #webkit).

6:05 AM Changeset in webkit [79441] by Patrick Gansterer
  • 4 edits in trunk/Source

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Alexey Proskuryakov.

Use AtomicString::fromUTF8 instead of String::fromUTF8 for AtomicStrings
https://bugs.webkit.org/show_bug.cgi?id=54992

  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readHTTPHeaders):

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Alexey Proskuryakov.

Use AtomicString::fromUTF8 instead of String::fromUTF8 for AtomicStrings
https://bugs.webkit.org/show_bug.cgi?id=54992

Also remove the WTF namespace from AtomicString and String.

  • ewk/ewk_view.cpp:
6:00 AM Changeset in webkit [79440] by alex
  • 2 edits in trunk/Source/WebKit2

2011-02-23 Alejandro G. Castro <alex@igalia.com>

Unreviewed, fixed GTK WebKit2 compilation after r79366.

  • GNUmakefile.am:
5:32 AM Changeset in webkit [79439] by Patrick Gansterer
  • 4 edits in trunk/Source/WebCore

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[CMake] Move platform dependent files out of main CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=53891

Apple Windows port does not use the image decoders,
so move them into the platform specific CMake files.

  • CMakeLists.txt:
  • CMakeListsEfl.txt:
  • CMakeListsWinCE.txt:
4:31 AM Changeset in webkit [79438] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-23 MORITA Hajime <morrita@google.com>

Unreviewed test_expectations.txt update.

  • platform/chromium/test_expectations.txt:
4:05 AM Changeset in webkit [79437] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-21 Stephen White <senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Jittering when animating a rotated image
https://bugs.webkit.org/show_bug.cgi?id=50775

Since Skia does not seem to suffer from pixel cracks when scaling to
non-integral sizes the way CG does, no-op roundToDevicePixels on the
Skia implementation.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::roundToDevicePixels):
3:58 AM Changeset in webkit [79436] by Patrick Gansterer
  • 2 edits
    1 move in trunk/Source/WebCore

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WINCE] Get rid of TemporaryLinkStubs.cpp
https://bugs.webkit.org/show_bug.cgi?id=54825

  • CMakeListsWinCE.txt:
  • platform/network/win/CookieStorageWin.cpp: Copied from platform/wince/TemporaryLinkStubs.cpp.
  • platform/wince/TemporaryLinkStubs.cpp: Removed.
3:42 AM Changeset in webkit [79435] by Patrick Gansterer
  • 4 edits in trunk/Source/JavaScriptCore

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Alexey Proskuryakov.

Use DEFINE_STATIC_LOCAL for ignoreSetMutex in Structure.cpp
https://bugs.webkit.org/show_bug.cgi?id=54831

  • runtime/InitializeThreading.cpp: (JSC::initializeThreadingOnce):
  • runtime/Structure.cpp: (JSC::ignoreSetMutex): (JSC::Structure::Structure): (JSC::Structure::~Structure): (JSC::Structure::initializeThreading):
  • runtime/Structure.h:
3:31 AM Changeset in webkit [79434] by Patrick Gansterer
  • 46 edits in trunk

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Rename PLATFORM(CF) to USE(CF)
https://bugs.webkit.org/show_bug.cgi?id=53540

  • runtime/DatePrototype.cpp:
  • runtime/GCActivityCallbackCF.cpp:
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • wtf/CurrentTime.cpp:
  • wtf/Platform.h:
  • wtf/text/AtomicString.h:
  • wtf/text/StringImpl.h: (WTF::StringImpl::computeHash):
  • wtf/text/WTFString.h:
  • wtf/unicode/icu/CollatorICU.cpp: (WTF::Collator::userDefault):

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Rename PLATFORM(CF) to USE(CF)
https://bugs.webkit.org/show_bug.cgi?id=53540

  • WebCore.gyp/WebCore.gyp:
  • editing/SmartReplace.cpp:
  • editing/SmartReplaceICU.cpp:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::didReceiveData): (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::didFail):
  • loader/archive/ArchiveFactory.cpp: (WebCore::archiveMIMETypes):
  • platform/FileSystem.h:
  • platform/KURL.h:
  • platform/KURLGoogle.cpp:
  • platform/RunLoopTimer.h:
  • platform/SharedBuffer.cpp:
  • platform/SharedBuffer.h:
  • platform/UUID.cpp: (WebCore::createCanonicalUUIDString):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceRequestBase.h:
  • platform/network/curl/ResourceHandleCurl.cpp:
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::certificatePath):
  • platform/text/cf/StringCF.cpp:
  • platform/text/cf/StringImplCF.cpp:
  • platform/win/BString.cpp:
  • platform/win/BString.h:
  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::getWebLocData): (WebCore::getURL): (WebCore::getClipboardData):
  • platform/win/ClipboardWin.cpp: (WebCore::writeFileToDataObject):
  • platform/win/SearchPopupMenuWin.cpp: (WebCore::SearchPopupMenuWin::enabled): (WebCore::SearchPopupMenuWin::saveRecentSearches): (WebCore::SearchPopupMenuWin::loadRecentSearches):

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Rename PLATFORM(CF) to USE(CF)
https://bugs.webkit.org/show_bug.cgi?id=53540

  • WebCoreSupport/WebInspectorClientCF.cpp:

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Rename PLATFORM(CF) to USE(CF)
https://bugs.webkit.org/show_bug.cgi?id=53540

  • WebView.cpp:

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Rename PLATFORM(CF) to USE(CF)
https://bugs.webkit.org/show_bug.cgi?id=53540

  • UIProcess/WebBackForwardList.h:
  • UIProcess/WebPageProxy.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::formatLocalizedString):

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Rename PLATFORM(CF) to USE(CF)
https://bugs.webkit.org/show_bug.cgi?id=53540

  • DumpRenderTree/config.h:
3:15 AM Changeset in webkit [79433] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-23 MORITA Hajime <morrita@google.com>

Unreviewed test_expectations.txt update.

  • platform/chromium/test_expectations.txt:
3:05 AM Changeset in webkit [79432] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] media/controls-without-preload.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=55028

  • platform/qt/Skipped: Add media/controls-without-preload.html until fix.
2:58 AM Changeset in webkit [79431] by ukai@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-23 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed build fix for Windows.

WebSocket uses insecure random numbers
https://bugs.webkit.org/show_bug.cgi?id=54714

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export WTF::cryptographicallyRandomNumber()
2:49 AM Changeset in webkit [79430] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-23 Yuzo Fujishima <yuzo@google.com>

Unreviewed attempt to fix a flaky test.
https://bugs.webkit.org/show_bug.cgi?id=51757

  • fast/css/font-face-download-error.html: Increase the wait to 200ms.
2:10 AM Changeset in webkit [79429] by kalman@chromium.org
  • 5 edits
    2 adds in trunk

2011-02-23 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ojan Vafai.

Moving or selecting backwards by words jumps to start of contenteditable region if contenteditable=false span is encountered
https://bugs.webkit.org/show_bug.cgi?id=51001

Add regression test.

  • editing/selection/extend-backward-by-word-over-non-editable-expected.txt: Added.
  • editing/selection/extend-backward-by-word-over-non-editable.html: Added.

2011-02-23 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ojan Vafai.

Moving or selecting backwards by words jumps to start of contenteditable region if contenteditable=false span is encountered
https://bugs.webkit.org/show_bug.cgi?id=51001

Test: editing/selection/extend-backward-by-word-over-non-editable.html

Revert some previous changes (the TextIteratorEndsAtEditingBoundary text iteration behaviour) which caused this
bug in the first place, and fix SimplifiedBackwardsTextIterator's iteration range check as an alternative fix.

The original bug was that double-clicking on an inline editable span at the start of a paragraph would clear the
selection (webkit.org/b/36360). This was caused by upstream/downstream VisbiblePosition complications. To fix,
refuse to iterate beyond the start node (rather than refusing to iterate across editable boundaries, which
causes this bug).

To see why this is correct, and to make it clearer that is indeed what is happening, the text iterator code has
been slightly restructured to express the invariant that the iterator will never advance past the start node.

  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): Remove references to TextIterationEndsAtEditing boundary. (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Remove m_pastStartNode as the mechanism for iteration range checking, and use a flag m_havePassedStartNode instead. (WebCore::SimplifiedBackwardsTextIterator::advance): Clean up, use advanceRespectingRange and m_havePassedStartNode for iteration range checking rather than m_pastStartNode. (WebCore::SimplifiedBackwardsTextIterator::advanceRespectingRange): The new way of modifying m_node which updates m_havePassedStartNode and refuses to continue when it becomes true.
  • editing/TextIterator.h: Remove TextIteratorEndsAtEditingBoundary, update for new/removed prototypes and member variables.
  • editing/visible_units.cpp: (WebCore::previousBoundary): Remove references to TextIteratorEndsAtEditingBoundary.
1:50 AM Changeset in webkit [79428] by ukai@chromium.org
  • 4 edits in trunk/Source

2011-02-23 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Adam Barth.

WebSocket uses insecure random numbers
https://bugs.webkit.org/show_bug.cgi?id=54714

2011-02-23 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Adam Barth.

WebSocket uses insecure random numbers
https://bugs.webkit.org/show_bug.cgi?id=54714

  • websockets/WebSocketHandshake.cpp: (WebCore::randomNumberLessThan): (WebCore::generateSecWebSocketKey): (WebCore::generateKey3):
1:42 AM Changeset in webkit [79427] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-23 Takashi Toyoshima <toyoshim@chromium.org>

Reviewed by Shinichiro Hamaji.

[chromium] Control-Up/Down should be PageUp/Down on Mac.
https://bugs.webkit.org/show_bug.cgi?id=54606

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::scrollViewWithKeyboard):
1:40 AM Changeset in webkit [79426] by hans@chromium.org
  • 13 edits
    2 moves in trunk/Source/WebCore

2011-02-21 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Rename IDBSQLiteDatabase to IDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=54864

No new functionality, so no new tests.

  • GNUmakefile.am:
  • WebCore.gypi:
  • storage/IDBBackingStore.cpp: (WebCore::IDBBackingStore::IDBBackingStore): (WebCore::IDBBackingStore::~IDBBackingStore):
  • storage/IDBBackingStore.h: (WebCore::IDBBackingStore::create): (WebCore::IDBBackingStore::db):
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::currentRowExists): (WebCore::IDBCursorBackendImpl::database):
  • storage/IDBCursorBackendImpl.h: (WebCore::IDBCursorBackendImpl::create):
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl): (WebCore::IDBDatabaseBackendImpl::sqliteDatabase): (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::setVersionInternal): (WebCore::IDBDatabaseBackendImpl::loadObjectStores):
  • storage/IDBDatabaseBackendImpl.h: (WebCore::IDBDatabaseBackendImpl::create):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::removeIDBBackingStore): (WebCore::openSQLiteDatabase): (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl): (WebCore::IDBIndexBackendImpl::openCursorInternal): (WebCore::IDBIndexBackendImpl::sqliteDatabase):
  • storage/IDBIndexBackendImpl.h: (WebCore::IDBIndexBackendImpl::create):
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::openCursorInternal): (WebCore::IDBObjectStoreBackendImpl::loadIndexes): (WebCore::IDBObjectStoreBackendImpl::sqliteDatabase):
  • storage/IDBObjectStoreBackendImpl.h: (WebCore::IDBObjectStoreBackendImpl::create):
1:30 AM Changeset in webkit [79425] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

2011-02-23 Dominic Mazzoni <dmazzoni@google.com>

Reviewed by Kenneth Russell.

Add a new test to make sure that a canvas can receive click events and
that hit testing is working correctly.

https://bugs.webkit.org/show_bug.cgi?id=54697

  • canvas/canvas-mouse-events-expected.txt: Added.
  • canvas/canvas-mouse-events.html: Added.
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/win-wk2/Skipped:

2011-02-23 Dominic Mazzoni <dmazzoni@google.com>

Reviewed by Kenneth Russell.

Add a hit test handler for canvas elements that handles clicks on the canvas but ignores children.
https://bugs.webkit.org/show_bug.cgi?id=54697

New test to prevent this from regressing in the future: canvas/canvas-mouse-events.html

  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::nodeAtPoint):
1:29 AM Changeset in webkit [79424] by dpranke@chromium.org
  • 10 edits
    1 add in trunk/Tools

2011-02-23 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

nrwt: turn on multiprocessing on chromium_linux, clean up unit tests for worker model defaults
https://bugs.webkit.org/show_bug.cgi?id=55016

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
1:28 AM Changeset in webkit [79423] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-23 MORITA Hajime <morrita@google.com>

Unreviewed test_expectations.txt update.

Recovered "BUGWK54736 MAC" lines which was removed at r79413.
The failure type became from TEXT+IMAGE to IMAGAE.

  • platform/chromium/test_expectations.txt:
1:25 AM Changeset in webkit [79422] by tony@chromium.org
  • 2 edits in trunk/Tools

2011-02-23 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] DumpRenderTree --check-layout-test-sys-deps leaks 4 temp dirs
https://bugs.webkit.org/show_bug.cgi?id=55004

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment): (WebKitSupportTestEnvironment::~WebKitSupportTestEnvironment): (main): Use a C++ object to ensure that TearDownTestEnvironment

gets called when --check-layout-test-sys-deps is called

1:11 AM Changeset in webkit [79421] by benjamin.poulain@nokia.com
  • 3 edits in trunk/Source/WebKit2

2011-02-23 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] [WK2] When the context menu is empty, we should still send the signal QWKPage::showContextMenu()
https://bugs.webkit.org/show_bug.cgi?id=54996

Send the signal QWKPage::showContextMenu() with an empty menu even if the content menu generated
is empty/contain only disabled elements.

  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::showContextMenu):
  • UIProcess/qt/WebContextMenuProxyQt.cpp: (WebKit::WebContextMenuProxyQt::showContextMenu):
1:10 AM Changeset in webkit [79420] by Patrick Gansterer
  • 3 edits
    1 delete in trunk/Source/WebCore

2011-02-23 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Remove obsolete focusRingColor functions
https://bugs.webkit.org/show_bug.cgi?id=54824

  • CMakeListsWinCE.txt:
  • platform/graphics/haiku/ColorHaiku.cpp:
  • platform/graphics/wince/ColorWinCE.cpp: Removed.
1:07 AM Changeset in webkit [79419] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-02-23 Gopal Raghavan <gopal.1.raghavan@nokia.com>

Reviewed by Anders Carlsson.

[Qt] [Qt] check webkit style fails in qt/tests
https://bugs.webkit.org/show_bug.cgi?id=54998

check-webkit-style was complaining about missing config.h in WebKit/qt/test/qdeclarativewebview. This patch was originally part of 50222. Reviewer suggested to split and create a separate patch for checker.

  • Scripts/webkitpy/style/checker.py:
12:59 AM Changeset in webkit [79418] by abarth@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-22 Adam Barth <abarth@webkit.org>

Reviewed by Ojan Vafai.

Add missing files to JavaScriptCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=55020

gypi files are supposed to list every file under the sun. This patch
adds some missing files and sorts the rest.

12:56 AM Changeset in webkit [79417] by Philippe Normand
  • 3 edits in trunk/LayoutTests

2011-02-23 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK rebaseline of media tests.

  • platform/gtk/media/audio-repaint-expected.txt:
  • platform/gtk/media/media-document-audio-repaint-expected.txt:
12:45 AM Changeset in webkit [79416] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

  • platform/qt/Skipped: Remove passing tests.
12:27 AM Changeset in webkit [79415] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-23 Anna Cavender <annacc@chromium.org>

Reviewed by Mihai Parparita.

Avoid flakiness due to async drawing of control glyphs by acting on "canplaythrough" instead of "playing".
https://bugs.webkit.org/show_bug.cgi?id=54640

  • media/video-display-toggle.html:
12:08 AM Changeset in webkit [79414] by Csaba Osztrogonác
  • 43 edits
    10 adds in trunk/LayoutTests

Unreviewed.

[Qt] <select>s on http://www.ryanair.com render wrong
https://bugs.webkit.org/show_bug.cgi?id=29647

Update Qt specific expected files after r79407.

  • platform/qt/editing/pasteboard/4641033-expected.checksum: Added.
  • platform/qt/editing/pasteboard/4641033-expected.png: Added.
  • platform/qt/editing/pasteboard/4641033-expected.txt:
  • platform/qt/editing/pasteboard/4944770-1-expected.checksum: Added.
  • platform/qt/editing/pasteboard/4944770-1-expected.png: Added.
  • platform/qt/editing/pasteboard/4944770-1-expected.txt:
  • platform/qt/editing/pasteboard/4944770-2-expected.checksum: Added.
  • platform/qt/editing/pasteboard/4944770-2-expected.png: Added.
  • platform/qt/editing/pasteboard/4944770-2-expected.txt:
  • platform/qt/editing/selection/caret-before-select-expected.checksum:
  • platform/qt/editing/selection/caret-before-select-expected.png:
  • platform/qt/editing/selection/caret-before-select-expected.txt:
  • platform/qt/editing/selection/replaced-boundaries-3-expected.checksum:
  • platform/qt/editing/selection/replaced-boundaries-3-expected.png:
  • platform/qt/editing/selection/replaced-boundaries-3-expected.txt:
  • platform/qt/fast/forms/basic-selects-expected.checksum:
  • platform/qt/fast/forms/basic-selects-expected.png:
  • platform/qt/fast/forms/basic-selects-expected.txt:
  • platform/qt/fast/forms/menulist-style-color-expected.checksum: Added.
  • platform/qt/fast/forms/menulist-style-color-expected.png: Added.
  • platform/qt/fast/forms/menulist-style-color-expected.txt:
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.checksum: Added.
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug18359-expected.checksum:
  • platform/qt/tables/mozilla/bugs/bug18359-expected.png:
  • platform/qt/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.checksum:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug29326-expected.checksum:
  • platform/qt/tables/mozilla/bugs/bug29326-expected.png:
  • platform/qt/tables/mozilla/bugs/bug29326-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug33855-expected.checksum:
  • platform/qt/tables/mozilla/bugs/bug33855-expected.png:
  • platform/qt/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug4382-expected.checksum:
  • platform/qt/tables/mozilla/bugs/bug4382-expected.png:
  • platform/qt/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug96334-expected.checksum:
  • platform/qt/tables/mozilla/bugs/bug96334-expected.png:
  • platform/qt/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/qt/tables/mozilla/core/margins-expected.checksum:
  • platform/qt/tables/mozilla/core/margins-expected.png:
  • platform/qt/tables/mozilla/core/margins-expected.txt:
  • platform/qt/tables/mozilla/dom/tableDom-expected.checksum:
  • platform/qt/tables/mozilla/dom/tableDom-expected.png:
  • platform/qt/tables/mozilla/dom/tableDom-expected.txt:
Note: See TracTimeline for information about the timeline view.