Timeline
Mar 1, 2011:
- 11:34 PM Changeset in webkit [80098] by
-
- 2 edits1 add3 deletes in trunk/LayoutTests
2011-03-01 Anna Cavender <annacc@chromium.org>
Reviewed by Eric Carlson.
Remove playing of video in media/video-replaces-poster.html and update text results.
https://bugs.webkit.org/show_bug.cgi?id=54910
- media/video-replaces-poster-expected.txt: Added.
- media/video-replaces-poster.html:
- platform/chromium-win/media/video-replaces-poster-expected.txt: Removed.
- platform/gtk/media/video-replaces-poster-expected.txt: Removed.
- platform/mac/media/video-replaces-poster-expected.txt: Removed.
- 11:05 PM EFLWebKit edited by
- (diff)
- 11:04 PM Changeset in webkit [80097] by
-
- 9 edits2 adds in trunk
2011-03-01 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Assertion fails when a form validation bubble appears
https://bugs.webkit.org/show_bug.cgi?id=55550
- fast/forms/interactive-validation-attach-assertion-expected.txt: Added.
- fast/forms/interactive-validation-attach-assertion.html: Added.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
2011-03-01 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Assertion fails when a form validation bubble appears
https://bugs.webkit.org/show_bug.cgi?id=55550
Test: fast/forms/interactive-validation-attach-assertion.html
- html/ValidationMessage.cpp: (WebCore::ValidationMessage::buildBubbleTree): Just remove unnecessary attach().
2011-03-01 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Assertion fails when a form validation bubble appears
https://bugs.webkit.org/show_bug.cgi?id=55550
Test: fast/forms/interactive-validation-attach-assertion.html
- DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::applyTo): Enable the interactive validation feature by default. This matches to Chromium browser.
- 10:54 PM Changeset in webkit [80096] by
-
- 17 edits2 copies1 add in trunk
Support localized numbers in <input type=number>
https://bugs.webkit.org/show_bug.cgi?id=42484
Reviewed by Dimitri Glazkov.
Source/WebCore:
This change adds support of localized numbers in <input type=number>.
This affects only the UI, and not HTMLInputElement::value.
- Remove the keyboard input restriction feature because it is hard to retrieve characters usable for localized numbers in ICU.
- Separate convertFromVisibleValue() from sanitizeValue(). sanitizeValue() is used for not only converting a renderer value to a DOM value.
- Implement LocalizedNumber functions for ICU and NSNumberFormatter. It is used only in Chromium for now.
Test: manual-tests/input-number-localization.html
- WebCore.gypi: Use LocalizedNumberICU.cpp.
- WebCore.xcodeproj/project.pbxproj: Add LocalizedNumberMac.mm and remove LocalizedNumberNone.cpp.
- dom/InputElement.h: Introduce convertFromVisibleValue().
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::convertFromVisibleValue):
- html/HTMLInputElement.h:
- html/InputType.cpp:
(WebCore::InputType::convertFromVisibleValue):
- html/InputType.h:
- html/NumberInputType.cpp: Remove isHTMLNumberCharacter(), isNumberCharacter(), and handleBeforeTextInsertedEvent() because we remove the keyboard input restriction feature for type=number.
(WebCore::NumberInputType::convertFromVisibleValue):
(WebCore::NumberInputType::sanitizeValue):
- html/NumberInputType.h:
- manual-tests/input-number-localization.html: Add a manual test because the behavior depends on the current locale.
- platform/text/LocalizedNumber.h: Remove isLocalizedNumberCharacter().
- platform/text/LocalizedNumberICU.cpp: Implement LocalizedNumber functions with ICU NumberFormat.
(WebCore::createFormatterForCurrentLocale):
(WebCore::parseLocalizedNumber):
(WebCore::formatLocalizedNumber):
- platform/text/LocalizedNumberNone.cpp: Remove isLocalizedNumberCharacter().
- platform/text/mac/LocalizedNumberMac.mm: Implement LocalizedNumber functions with NSNumberFormatter.
(WebCore::parseLocalizedNumber):
(WebCore::formatLocalizedNumber):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::subtreeHasChanged):
- wml/WMLInputElement.h:
(WebCore::WMLInputElement::convertFromVisibleValue):
Implemented as a function doing nothing.
LayoutTests:
Update an existing test because of removing the keyboard input
restriction feature.
- fast/forms/input-number-keyoperation-expected.txt:
- fast/forms/script-tests/input-number-keyoperation.js:
- 10:28 PM Changeset in webkit [80095] by
-
- 2 edits in trunk/Tools
2011-03-01 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kent Tamura.
Remove efl port style exception of Webcore/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=55549
WebCore and JavaScriptCore need to adhere WebKit coding style.
- Scripts/webkitpy/style/checker.py:
- 10:14 PM Changeset in webkit [80094] by
-
- 4 edits in trunk/Source/JavaScriptCore
2011-03-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
JavaScriptCore GYP build should copy some headers into the target framework
https://bugs.webkit.org/show_bug.cgi?id=55524
After this patch, all the framework headers are exported as public
headers. We need to teach GYP how to handle private headers.
I struggled to determine how to store the information about whether a
header was public, private, or project (i.e., not exported).
Generally, the GYPI should just list the files, but it seemed siliy to
have an almost duplicated list of files in the GYP file itself. If
this design doesn't scale, we might have to revisit it in the future.
- JavaScriptCore.gyp/JavaScriptCore.gyp:
- JavaScriptCore.gypi:
- gyp/JavaScriptCore.gyp:
- 10:08 PM Changeset in webkit [80093] by
-
- 2 edits in trunk/Tools
2011-03-01 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[chromium] clean up temp files on chromium-mac builder too
https://bugs.webkit.org/show_bug.cgi?id=55525
- BuildSlaveSupport/chromium/remove-crash-logs:
- 10:06 PM Changeset in webkit [80092] by
-
- 3 edits in trunk/Source/WebCore
2011-03-01 Yuta Kitamura <yutak@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r78383): Failure to connect on websocketstest.com
https://bugs.webkit.org/show_bug.cgi?id=54811
After r78383, KURL::setPort() no longer appends ":port" part
if that port is the default port for URL scheme. This broke
SocketStreamHandleCFNet, whose code was based on an assumption
that KURL::setPort() always inserts ":port" part.
To fix this, KURL::port() call is removed from SocketStreamHandle
and the port number is calculated on-the-fly.
Unfortunately it is impossible to write a test; this bug only
affects WebSockets connecting to the default port (port 80
for ws, port 443 for wss), while we use different ports to test
WebSockets in LayoutTests.
- platform/network/cf/SocketStreamHandle.h:
- platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::createStreams): (WebCore::SocketStreamHandle::port):
- 9:49 PM Changeset in webkit [80091] by
-
- 2 edits56 adds in trunk/LayoutTests
2011-03-01 Victoria Kirst <vrk@chromium.org>
Reviewed by Kenneth Russell.
[Chromium] videos are not painted for compositing/ tests
https://bugs.webkit.org/show_bug.cgi?id=54694
Videos are now painted for compositing tests. This patch uploads the
expected layout results and enables the tests again.
- platform/chromium-gpu-linux/compositing/geometry/clipped-video-controller-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/geometry/clipped-video-controller-expected.png: Added.
- platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png: Added.
- platform/chromium-gpu-linux/compositing/geometry/video-opacity-overlay-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/geometry/video-opacity-overlay-expected.png: Added.
- platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png: Added.
- platform/chromium-gpu-linux/compositing/overflow/overflow-compositing-descendant-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
- platform/chromium-gpu-linux/compositing/overflow/scroll-ancestor-update-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/overflow/scroll-ancestor-update-expected.png: Added.
- platform/chromium-gpu-linux/compositing/reflections/load-video-in-reflection-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/reflections/load-video-in-reflection-expected.png: Added.
- platform/chromium-gpu-linux/compositing/self-painting-layers-expected.checksum: Added.
- platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png: Added.
- platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.checksum: Added.
- platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.png: Added.
- platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.checksum: Added.
- platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.png: Added.
- platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.checksum: Added.
- platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.png: Added.
- platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.checksum: Added.
- platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.png: Added.
- platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.checksum: Added.
- platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
- platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.checksum: Added.
- platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.png: Added.
- platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.checksum: Added.
- platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.png: Added.
- platform/chromium-gpu-mac/compositing/self-painting-layers-expected.checksum: Added.
- platform/chromium-gpu-mac/compositing/self-painting-layers-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.txt: Added.
- platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.png: Added.
- platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.txt: Added.
- platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
- platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.txt: Added.
- platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.png: Added.
- platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.txt: Added.
- platform/chromium-gpu-win/compositing/self-painting-layers-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/self-painting-layers-expected.png: Added.
- platform/chromium-gpu-win/compositing/self-painting-layers-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 8:44 PM Changeset in webkit [80090] by
-
- 5 edits in trunk/Tools
2011-02-28 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
wrap json in a function call to afford cross-domain loading
https://bugs.webkit.org/show_bug.cgi?id=55353
Also delete the code that compacts the JSON. It turns out this
breaks the rebaseline tool and is probably a premature optimization anyways.
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/tool/commands/rebaselineserver.py:
- 8:25 PM Changeset in webkit [80089] by
-
- 2 edits in trunk/Source/WebKit2
Hide the typeinfo name symbols for std::exception and std::bad_alloc too.
- Configurations/Base.xcconfig:
- 8:21 PM Changeset in webkit [80088] by
-
- 2 edits2 adds in trunk/LayoutTests
2011-03-01 Joseph Pecoraro <Joseph Pecoraro>
Unreviewed expectations update. This is a follow-up to r80061.
Leopard has a slightly different error message, so
platform/mac-leopard needs its own expected results for the
websocket test. Added platform specific expected results for
the other tests which are consistently failing with an extra
console message on the bots.
- platform/mac-leopard/http/tests/inspector/console-websocket-error-expected.txt:
- platform/mac-leopard/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Added.
- platform/mac-leopard/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Added.
- 7:57 PM Changeset in webkit [80087] by
-
- 3 edits1 add in trunk/Source/WebKit/chromium
2011-03-01 David Grogan <dgrogan@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: public webkit interfaces for firing versionchange events to IDBDatabase objects
https://bugs.webkit.org/show_bug.cgi?id=55548
- WebKit.gyp:
- public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::createObjectStore): (WebKit::WebIDBDatabase::open):
- public/WebIDBDatabaseCallbacks.h: Added. (WebKit::WebIDBDatabaseCallbacks::~WebIDBDatabaseCallbacks): (WebKit::WebIDBDatabaseCallbacks::onVersionChange):
- 7:22 PM Changeset in webkit [80086] by
-
- 17 edits in trunk
2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80079.
http://trac.webkit.org/changeset/80079
https://bugs.webkit.org/show_bug.cgi?id=55547
"Broke the Win debug build?" (Requested by dcheng on #webkit).
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80079.
http://trac.webkit.org/changeset/80079
https://bugs.webkit.org/show_bug.cgi?id=55547
"Broke the Win debug build?" (Requested by dcheng on #webkit).
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsWinCE.cmake:
- Source/cmakeconfig.h.cmake:
2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80079.
http://trac.webkit.org/changeset/80079
https://bugs.webkit.org/show_bug.cgi?id=55547
"Broke the Win debug build?" (Requested by dcheng on #webkit).
- wtf/Platform.h:
2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80079.
http://trac.webkit.org/changeset/80079
https://bugs.webkit.org/show_bug.cgi?id=55547
"Broke the Win debug build?" (Requested by dcheng on #webkit).
- features.gypi:
2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80079.
http://trac.webkit.org/changeset/80079
https://bugs.webkit.org/show_bug.cgi?id=55547
"Broke the Win debug build?" (Requested by dcheng on #webkit).
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- features.pri:
2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80079.
http://trac.webkit.org/changeset/80079
https://bugs.webkit.org/show_bug.cgi?id=55547
"Broke the Win debug build?" (Requested by dcheng on #webkit).
- Scripts/build-webkit:
- 7:14 PM Changeset in webkit [80085] by
-
- 2 edits in trunk/LayoutTests
2011-03-01 Joseph Pecoraro <Joseph Pecoraro>
Unreviewed expectations update. This is expected
behavior after r80061, which enabled printing
of more console messages.
- http/tests/xmlviewer/dumpAsText/wml-expected.txt:
- 7:05 PM Changeset in webkit [80084] by
-
- 2 edits in trunk/Source/WebKit/wx
[wx] Build fix after removal of Frame::isContentEditable.
- 6:54 PM Changeset in webkit [80083] by
-
- 2 edits in trunk/LayoutTests
2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80078.
http://trac.webkit.org/changeset/80078
https://bugs.webkit.org/show_bug.cgi?id=55545
underlying change was rolled out (Requested by tonyg-cr on
#webkit).
- platform/chromium/test_expectations.txt:
- 6:45 PM Changeset in webkit [80082] by
-
- 1 edit4 adds in trunk/LayoutTests
2011-03-01 Tony Gentilcore <tonyg@chromium.org>
Unreviewed new baselines
[chromium] Add expectations for new tests in r80049
https://bugs.webkit.org/show_bug.cgi?id=55543
- platform/chromium-mac/svg/css/path-gradient-stroke-shadow-expected.checksum: Added.
- platform/chromium-mac/svg/css/path-gradient-stroke-shadow-expected.png: Added.
- platform/chromium-win/svg/css/path-gradient-stroke-shadow-expected.checksum: Added.
- platform/chromium-win/svg/css/path-gradient-stroke-shadow-expected.png: Added.
- 6:35 PM Changeset in webkit [80081] by
-
- 8 edits1 copy3 adds in trunk/Source/WebCore
2011-02-25 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Abstract "pixels with a graphics context" into its own class
https://bugs.webkit.org/show_bug.cgi?id=55259
This creates new PlatformCanvas/PlatformImage classes which wrap
all of the #ifdef Skia/Cg warts from the compositor. All classes
(LayerTilerChromium, ContentLayerChromium, and ImageLayerChromium) are
modified to use these abstractions.
Tests: LayoutTests/compositing
- WebCore.gypi:
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::updateContentsIfDirty): (WebCore::ContentLayerChromium::resizeUploadBuffer): (WebCore::ContentLayerChromium::updateTextureIfNeeded): (WebCore::ContentLayerChromium::updateTexture): (WebCore::ContentLayerChromium::draw):
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContentsIfDirty): (WebCore::ImageLayerChromium::updateTextureIfNeeded):
- platform/graphics/chromium/ImageLayerChromium.h:
- platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::contentRectToTileIndices): (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::updateFromPixels):
- platform/graphics/chromium/LayerTilerChromium.h:
- platform/graphics/chromium/PlatformCanvas.cpp: Added. (WebCore::PlatformCanvas::PlatformCanvas): (WebCore::PlatformCanvas::~PlatformCanvas): (WebCore::PlatformCanvas::resize): (WebCore::PlatformCanvas::AutoLocker::AutoLocker): (WebCore::PlatformCanvas::AutoLocker::~AutoLocker): (WebCore::PlatformCanvas::Painter::Painter): (WebCore::PlatformCanvas::Painter::~Painter):
- platform/graphics/chromium/PlatformCanvas.h: Added. (WebCore::PlatformCanvas::AutoLocker::pixels): (WebCore::PlatformCanvas::Painter::context): (WebCore::PlatformCanvas::size):
- platform/graphics/chromium/PlatformImage.cpp: Copied from Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp. (WebCore::PlatformImage::PlatformImage): (WebCore::PlatformImage::updateFromImage):
- platform/graphics/chromium/PlatformImage.h: Added. (WebCore::PlatformImage::pixels): (WebCore::PlatformImage::size):
- 6:24 PM Changeset in webkit [80080] by
-
- 11 edits in trunk
Source/WebKit2: Add verification scripts to WebKit2 project and fix the issues they reveal.
Reviewed by Sam Weinig.
- Configurations/Base.xcconfig: Add linker flags to prevent C++ standard
library functions from being exported as weak externals.
- Configurations/WebKit2.xcconfig: Inherit linker flags from the project level.
- Shared/WebContextMenuItem.cpp:
(WebKit::WebContextMenuItem::separatorItem): Use DEFINE_STATIC_LOCAL.
- UIProcess/WebPageGroup.cpp:
(WebKit::webPageGroupMap): Ditto.
- WebKit2.xcodeproj/project.pbxproj: Don't copy .in files in to the framework.
Run verification scripts at the appropriate times.
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::didBeginEditing): Use DEFINE_STATIC_LOCAL.
(WebKit::WebEditorClient::respondToChangedContents): Ditto.
(WebKit::WebEditorClient::respondToChangedSelection): Ditto.
(WebKit::WebEditorClient::didEndEditing): Ditto.
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::idToHistoryItemMap): Ditto.
(WebKit::historyItemToIDMap): Ditto.
Tools: Update verification scripts to handle WebKit2.
Reviewed by Sam Weinig.
- Scripts/check-for-global-initializers: Skip object files that use RefCountedLeakChecker.
- Scripts/check-for-inappropriate-files-in-framework: Add some inappropriate file types for
WebKit2.
- 6:15 PM Changeset in webkit [80079] by
-
- 17 edits in trunk
2011-03-01 Daniel Cheng <dcheng@chromium.org>
Reviewed by David Levin.
Add feature define for data transfer items
https://bugs.webkit.org/show_bug.cgi?id=55510
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsWinCE.cmake:
- Source/cmakeconfig.h.cmake:
2011-03-01 Daniel Cheng <dcheng@chromium.org>
Reviewed by David Levin.
Add feature define for data transfer items
https://bugs.webkit.org/show_bug.cgi?id=55510
- wtf/Platform.h:
2011-03-01 Daniel Cheng <dcheng@chromium.org>
Reviewed by David Levin.
Add feature define for data transfer items
https://bugs.webkit.org/show_bug.cgi?id=55510
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- features.pri:
2011-03-01 Daniel Cheng <dcheng@chromium.org>
Reviewed by David Levin.
Add feature define for data transfer items
https://bugs.webkit.org/show_bug.cgi?id=55510
- features.gypi:
2011-03-01 Daniel Cheng <dcheng@chromium.org>
Reviewed by David Levin.
Add feature define for data transfer items
https://bugs.webkit.org/show_bug.cgi?id=55510
- Scripts/build-webkit:
2011-03-01 Daniel Cheng <dcheng@chromium.org>
Reviewed by David Levin.
Add feature define for data transfer items
https://bugs.webkit.org/show_bug.cgi?id=55510
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 6:10 PM Changeset in webkit [80078] by
-
- 2 edits in trunk/LayoutTests
2011-03-01 Tony Gentilcore <tonyg@chromium.org>
Unreviewed expectations
[chromium] Skip new viewport tests added by r80068
https://bugs.webkit.org/show_bug.cgi?id=55539
LayoutTestController doesn't implement dumpConfigurationForViewport() which is needed for this test.
- platform/chromium/test_expectations.txt:
- 6:04 PM Changeset in webkit [80077] by
-
- 14 edits7 deletes in trunk
2011-03-01 Joseph Pecoraro <Joseph Pecoraro>
Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.
- 6:02 PM Changeset in webkit [80076] by
-
- 9 edits in trunk
2011-03-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by James Robinson.
IDBKeyRange.bound() should not use the optional options object
https://bugs.webkit.org/show_bug.cgi?id=55419
- storage/indexeddb/index-cursor.html:
- storage/indexeddb/keyrange-expected.txt:
- storage/indexeddb/keyrange.html:
- storage/indexeddb/objectstore-cursor.html:
2011-03-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by James Robinson.
IDBKeyRange.bound() should not use the optional options object
https://bugs.webkit.org/show_bug.cgi?id=55419
http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#range-concept
Added some code to existing tests to cover these cases.
- storage/IDBKeyRange.cpp: (WebCore::IDBKeyRange::bound):
- storage/IDBKeyRange.h:
- storage/IDBKeyRange.idl:
- 5:46 PM Changeset in webkit [80075] by
-
- 2 edits in trunk/Source/WebCore
Build fix.
- dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
- 5:39 PM Changeset in webkit [80074] by
-
- 2 edits in trunk/Source/WebCore
2011-03-01 Kent Tamura <tkent@chromium.org>
Unreviewed. Apply sort-Xcode-project-file.
- WebCore.xcodeproj/project.pbxproj:
- 5:30 PM Changeset in webkit [80073] by
-
- 2 edits in trunk/Source/WebKit2
2011-03-01 Joseph Pecoraro <Joseph Pecoraro>
Unreviewed, missed updating a call to WebCore::computeViewportAttributes
who's prototype changed.
Viewport Warning/Error Messages Are Now Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=53707
- UIProcess/API/qt/qwkpage.cpp: (QWKPage::viewportAttributesForSize): pass in a value for the document argument.
- 5:23 PM Changeset in webkit [80072] by
-
- 12 edits3 copies10 adds in trunk/Source/WebCore
2011-03-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by James Robinson.
V8 code generator doesn't properly support a single SerializedScriptValue attribute
https://bugs.webkit.org/show_bug.cgi?id=55530
This is tested by the bindings tests changes.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp: Added. (WebDOMTestSerializedScriptValueInterface::WebDOMTestSerializedScriptValueInterfacePrivate::WebDOMTestSerializedScriptValueInterfacePrivate): (WebDOMTestSerializedScriptValueInterface::WebDOMTestSerializedScriptValueInterface): (WebDOMTestSerializedScriptValueInterface::operator=): (WebDOMTestSerializedScriptValueInterface::impl): (WebDOMTestSerializedScriptValueInterface::~WebDOMTestSerializedScriptValueInterface): (WebDOMTestSerializedScriptValueInterface::value): (toWebCore): (toWebKit):
- bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp: Added. (WebKit::kit): (webkit_dom_test_serialized_script_value_interface_get_value): (WebKit::core): (webkit_dom_test_serialized_script_value_interface_finalize): (webkit_dom_test_serialized_script_value_interface_set_property): (webkit_dom_test_serialized_script_value_interface_get_property): (webkit_dom_test_serialized_script_value_interface_constructed): (webkit_dom_test_serialized_script_value_interface_class_init): (webkit_dom_test_serialized_script_value_interface_init): (WebKit::wrapTestSerializedScriptValueInterface):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h: Added.
- bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor): (WebCore::JSTestInterface::JSTestInterface):
- bindings/scripts/test/JS/JSTestInterface.h:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: (WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor): (WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener): (WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
- bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::JSTestObjConstructor::JSTestObjConstructor): (WebCore::JSTestObj::JSTestObj): (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs): (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows): (WebCore::jsTestObjPrototypeFunctionSerializedValue): (WebCore::jsTestObjPrototypeFunctionIdbKey): (WebCore::jsTestObjPrototypeFunctionOptionsObject): (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD): (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg): (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs): (WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod1): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod2): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod3): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod4): (WebCore::jsTestObjPrototypeFunctionClassMethodWithOptional):
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Added. (WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure): (WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor): (WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertySlot): (WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertyDescriptor): (WebCore::JSTestSerializedScriptValueInterfacePrototype::self): (WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface): (WebCore::JSTestSerializedScriptValueInterface::createPrototype): (WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlot): (WebCore::JSTestSerializedScriptValueInterface::getOwnPropertyDescriptor): (WebCore::jsTestSerializedScriptValueInterfaceValue): (WebCore::jsTestSerializedScriptValueInterfaceConstructor): (WebCore::JSTestSerializedScriptValueInterface::getConstructor): (WebCore::toJS): (WebCore::toTestSerializedScriptValueInterface):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: Copied from Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h. (WebCore::JSTestSerializedScriptValueInterface::createStructure): (WebCore::JSTestSerializedScriptValueInterface::impl): (WebCore::JSTestSerializedScriptValueInterfacePrototype::createStructure): (WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):
- bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h: Added.
- bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm: Added. (-[DOMTestSerializedScriptValueInterface dealloc]): (-[DOMTestSerializedScriptValueInterface finalize]): (-[DOMTestSerializedScriptValueInterface value]): (core): (kit):
- bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterfaceInternal.h: Added.
- bindings/scripts/test/TestSerializedScriptValueInterface.idl: Added.
- bindings/scripts/test/V8/V8TestInterface.cpp: (WebCore::ConfigureV8TestInterfaceTemplate):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: Copied from Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp. (WebCore::TestSerializedScriptValueInterfaceInternal::V8_USE): (WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate): (WebCore::V8TestSerializedScriptValueInterface::GetRawTemplate): (WebCore::V8TestSerializedScriptValueInterface::GetTemplate): (WebCore::V8TestSerializedScriptValueInterface::HasInstance): (WebCore::V8TestSerializedScriptValueInterface::wrapSlow): (WebCore::V8TestSerializedScriptValueInterface::derefObject):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h: Added. (WebCore::V8TestSerializedScriptValueInterface::toNative): (WebCore::V8TestSerializedScriptValueInterface::wrap): (WebCore::toV8):
- 5:23 PM Changeset in webkit [80071] by
-
- 1 edit5 adds in trunk/LayoutTests
2011-03-01 Tony Gentilcore <tonyg@chromium.org>
Unreviewed expectations update
[chromium] Expectations updates from r80061
https://bugs.webkit.org/show_bug.cgi?id=55533
- platform/chromium-linux/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt: Added.
- platform/chromium-linux/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Added.
- platform/chromium-linux/http/tests/xmlviewer/dumpAsText/wml-expected.txt: Added.
- 5:23 PM Changeset in webkit [80070] by
-
- 4 edits in trunk/Source
2011-03-01 Oliver Hunt <oliver@apple.com>
Reviewed by Joseph Pecoraro.
Misaligned memory access in CloneDeserializer on all ARM arch.
https://bugs.webkit.org/show_bug.cgi?id=48742
Add a CPU class for architectures that need aligned addresses
for memory access.
- wtf/Platform.h:
2011-03-01 Oliver Hunt <oliver@apple.com>
Reviewed by Joseph Pecoraro.
Misaligned memory access in CloneDeserializer on all ARM arch.
https://bugs.webkit.org/show_bug.cgi?id=48742
Push platforms that need aligned memory access down the
endian independent serialization and deserialization
paths.
- bindings/js/SerializedScriptValue.cpp:
- 5:16 PM Changeset in webkit [80069] by
-
- 2 edits in trunk/LayoutTests
2011-03-01 Helder Correia <helder@sencha.com>
Unreviewed Qt skipped tests update.
The manually committed patch didn't include the update to
fast/canvas/canvas-strokePath-gradient-shadow.html by mistake:
No shadow when stroking a path with a gradient
https://bugs.webkit.org/show_bug.cgi?id=55436
- platform/qt/Skipped: Skip new test since it fails.
- 4:59 PM Changeset in webkit [80068] by
-
- 12 edits7 adds in trunk
2011-03-01 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Kenneth Rohde Christiansen.
Viewport Warning/Error Messages Are Now Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=53707
Added tests specifically to test Console warnings.
- fast/viewport/viewport-warnings-1.html: Added.
- fast/viewport/viewport-warnings-2.html: Added.
- fast/viewport/viewport-warnings-3.html: Added.
- fast/viewport/viewport-warnings-4.html: Added.
- fast/viewport/viewport-warnings-5.html: Added.
- fast/viewport/viewport-warnings-6.html: Added.
- fast/viewport/viewport-warnings-7.html: Added.
2011-03-01 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Kenneth Rohde Christiansen.
Viewport Warning/Error Messages Are Now Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=53707
Correct and improve the error messages for viewport
parsing. Clarify the difference between incorrect
keys, values, and when to use the device-width or
device-height constants.
- dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes): suggest using keywords if fixed input matches device width or height. (WebCore::numericPrefix): (WebCore::findSizeValue): remove incorrect warnings about fixed numbers because we don't know the device width or height. (WebCore::setViewportFeature): report a warning for an unrecognized key. (WebCore::viewportErrorMessageTemplate): added template for unrecognized key. (WebCore::viewportErrorMessageLevel):
- dom/ViewportArguments.h:
- 4:56 PM Changeset in webkit [80067] by
-
- 2 edits in trunk/Source/WebKit2
2011-03-01 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
WKPluginSiteDataManagerClearAllSiteData is not working
https://bugs.webkit.org/show_bug.cgi?id=55528
<rdar://problem/9071823>
- Shared/Plugins/Netscape/NetscapePluginModule.cpp: (WebKit::NetscapePluginModule::tryGetSitesWithData): Remove version checks, checking that the function pointer is not null is enough.
(WebKit::NetscapePluginModule::tryClearSiteData):
Remove version checks, checking that the function pointer is not null is enough.
Also, correctly convert a null String to a null CString.
- 4:50 PM Changeset in webkit [80066] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-03-01 Tony Gentilcore <tonyg@chromium.org>
Unreviewed baseline
[chromium] Add baseline for test added by r80040
https://bugs.webkit.org/show_bug.cgi?id=55529
- platform/chromium-mac/fast/table/table-and-parts-outline-expected.checksum: Added.
- platform/chromium-mac/fast/table/table-and-parts-outline-expected.png: Added.
- 4:47 PM Changeset in webkit [80065] by
-
- 4 edits in trunk/Source
2011-03-01 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Add pre- and post-build actions for JavaScriptCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=55507
After this patch, we have all the steps for building the main
JavaScriptCore framework except the "copy headers" step, which I'll do
next.
- gyp/JavaScriptCore.gyp:
2011-03-01 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Add pre- and post-build actions for JavaScriptCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=55507
Remove the portion of this file that was split out into common.gypi.
- gyp/JavaScriptGlue.gyp:
- 4:45 PM Changeset in webkit [80064] by
-
- 2 edits in trunk/LayoutTests
2011-03-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Alexey Proskuryakov.
Fix a bug in platform/mac/editing/input/selection-change-closes-typing.html
https://bugs.webkit.org/show_bug.cgi?id=55523
The marked text is at offset 0 with length 1, not at offset 1 with length 0.
- platform/mac/editing/input/selection-change-closes-typing.html:
- 4:34 PM Changeset in webkit [80063] by
-
- 2 edits2 adds in trunk/LayoutTests
2011-03-01 Tony Gentilcore <tonyg@chromium.org>
Unreviewed expectations
[chromium] Add expectations for new tests in r80049
https://bugs.webkit.org/show_bug.cgi?id=55526
- platform/chromium-linux/svg/css/path-gradient-stroke-shadow-expected.checksum: Added.
- platform/chromium-linux/svg/css/path-gradient-stroke-shadow-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 4:28 PM Changeset in webkit [80062] by
-
- 1 edit1 add in trunk/LayoutTests
2011-03-01 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Kenneth Rohde Christiansen.
Viewport parsing no longer accepts "1.0;" value as valid.
https://bugs.webkit.org/show_bug.cgi?id=53705
Adding expected results generated from the build-bot. They look
correct, as the viewport "123x135" has the expected width of "123".
- fast/viewport/viewport-129-expected.txt: Added.
- 4:21 PM Changeset in webkit [80061] by
-
- 24 edits in trunk
2011-02-23 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
LayoutTests:
2011-02-23 Joseph Pecoraro <Joseph Pecoraro>
All Console Messages should be passed to ChromeClients.
https://bugs.webkit.org/show_bug.cgi?id=54926
Passing more message types to the ChromeClient allows
some more messages to get output during tests. Specifically
HTML, XML, and Other message types.
- inspector/audits/audits-panel-functional.html: correct a legitimate HTML parse error.
- http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
- http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
- http/tests/security/mixedContent/insecure-iframe-in-main-frame-expected.txt:
- http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
- http/tests/security/mixedContent/insecure-plugin-in-iframe-expected.txt:
- http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
- http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame-expected.txt:
- http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt:
- http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt:
- http/tests/security/xss-DENIED-xml-external-entity-expected.txt:
- http/tests/security/xss-DENIED-xsl-document-expected.txt:
- http/tests/security/xss-DENIED-xsl-external-entity-expected.txt:
- platform/mac/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt:
- platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
- platform/mac/http/tests/inspector/console-websocket-error-expected.txt:
Source/WebCore:
2011-02-23 Joseph Pecoraro <Joseph Pecoraro>
All Console Messages should be passed to ChromeClients.
https://bugs.webkit.org/show_bug.cgi?id=54926
Do not filter the message type here, allow clients
to filter and deal with the different message types.
- page/Console.cpp: (WebCore::Console::addMessage):
Source/WebKit/mac:
2011-02-23 Joseph Pecoraro <Joseph Pecoraro>
All Console Messages should be passed to ChromeClients.
https://bugs.webkit.org/show_bug.cgi?id=54926
Add a new private UIDelegate method, -webView:addMessageToConsole:withSource:,
which supersedes -webView:addMessageToConsole if it exists. The new delegate
does not filter to only JavaScript originated console messages. The old
delegate is left around for clients that expect filtered messages, like
DashCode and older versions of Safari.
The dictionary message passed to the delegate now includes more information
about the message source, type, and level.
- WebCoreSupport/WebChromeClient.mm: (stringForMessageSource): (stringForMessageType): (stringForMessageLevel): (WebChromeClient::addMessageToConsole):
- WebView/WebUIDelegatePrivate.h:
Tools:
2011-02-23 Joseph Pecoraro <Joseph Pecoraro>
All Console Messages should be passed to ChromeClients.
https://bugs.webkit.org/show_bug.cgi?id=54926
Update DumpRenderTree's UIDelegate to use the new console message delegate.
- DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:addMessageToConsole:withSource:]):
- 4:14 PM Changeset in webkit [80060] by
-
- 8 edits2 adds in trunk
2011-03-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
WebKit does not merge text decorations in the typing style and the selected element properly
https://bugs.webkit.org/show_bug.cgi?id=55349
Added a test to ensure WebKit merges text decorations in the typing style and the inline style
of the element around the caret when computing the style at the selection start.
- editing/execCommand/merge-text-decoration-with-typing-style-expected.txt: Added.
- editing/execCommand/merge-text-decoration-with-typing-style.html: Added.
- editing/style/push-down-inline-styles-expected.txt: Rebaselined due to the change in which text decoration values appear.
- editing/style/script-tests/push-down-inline-styles.js: Ditto.
2011-03-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
WebKit does not merge text decorations in the typing style and the selected element properly
https://bugs.webkit.org/show_bug.cgi?id=55349
The bug was caused by EditingStyle::mergeTypingStyle's not properly merging text decoration property.
Fixed the bug by extracting a function from ApplyStyleCommand::pushDownInlineStyleAroundNode and
calling it in pushDownInlineStyleAroundNode and in mergeTypingStyle.
Test: editing/execCommand/merge-text-decoration-with-typing-style.html
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Takes EditingStyle*; calls mergeInlineStyleOfElement. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls applyInlineStyleToPushDown. (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto.
- editing/ApplyStyleCommand.h:
- editing/EditingStyle.cpp: (WebCore::EditingStyle::mergeTypingStyle): Added; calls mergeStyle. (WebCore::EditingStyle::mergeInlineStyleOfElement): Ditto. (WebCore::EditingStyle::mergeStyle): Extracted from applyInlineStyleToPushDown.
- editing/EditingStyle.h:
- 4:06 PM Changeset in webkit [80059] by
-
- 27 edits in trunk/Source
2011-03-01 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
Stop instantiating legacy editing Positions in VisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=52919
Changing usage of legacy VisiblePosition constructor. Since we were dealing
with positions from DOM Ranges, we're guaranteed a parent-anchored position.
- WebView/WebFrame.mm: (-[WebFrame _caretRectAtPosition:affinity:]):
- WebView/WebFrameInternal.h:
- WebView/WebTextCompletionController.mm: (-[WebTextCompletionController doCompletion]):
2011-03-01 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
Stop instantiating legacy editing Positions in VisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=52919
Changing VisiblePosition completely away from legacy positions.
No new tests since this is functionaly equivalent.
- WebCore.exp.in: Removing the legacy VisiblePosition constructor and adding the PositionIsOffsetInAnchor symbol. If we must create VisiblePositions outside of WebCore, they should be parent anchored.
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
- accessibility/AccessibilityObject.cpp: (WebCore::startOfStyleRange): (WebCore::endOfStyleRange):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored):
- dom/Position.cpp: (WebCore::Position::document): Added this inline function to avoid the necessity of calling anchorNode to assure a document from a Position. (WebCore::Position::upstream): Fixed to correctly respect PositionIsAfterAnchor (WebCore::Position::downstream): ditto
- dom/Range.cpp: (WebCore::Range::editingStartPosition):
- editing/Editor.cpp: (WebCore::Editor::canDeleteRange):
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
- editing/SelectionController.cpp: (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): (WebCore::SelectionController::setSelectedRange):
- editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
- editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed):
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): (WebCore::VisiblePosition::canonicalPosition): (WebCore::VisiblePosition::characterAfter): (WebCore::VisiblePosition::localCaretRect): (WebCore::makeRange): (WebCore::startVisiblePosition): (WebCore::endVisiblePosition): (WebCore::setStart): (WebCore::setEnd): (WebCore::isFirstVisiblePositionInNode): (WebCore::isLastVisiblePositionInNode):
- editing/VisiblePosition.h: (WebCore::VisiblePosition::VisiblePosition):
- editing/htmlediting.cpp: (WebCore::firstInSpecialElement): (WebCore::lastInSpecialElement): (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):
- editing/visible_units.cpp: (WebCore::startPositionForLine): (WebCore::endPositionForLine): (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::endOfBlock): (WebCore::startOfDocument): (WebCore::endOfDocument): (WebCore::logicalStartPositionForLine): (WebCore::logicalEndPositionForLine):
- page/DOMSelection.cpp: (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::setPosition): (WebCore::DOMSelection::extend):
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick):
- rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::visiblePositionForIndex):
- svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::selectSubString):
- 4:04 PM Changeset in webkit [80058] by
-
- 1 edit2 adds in trunk/LayoutTests
2011-03-01 Tony Gentilcore <tonyg@chromium.org>
Unreviewed expectations update
[chromium] Rebaseline fast/ruby/base-shorter-than-text.html
https://bugs.webkit.org/show_bug.cgi?id=55522
This changed as a result of r80015.
- platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.checksum: Added.
- platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.png: Added.
- 3:57 PM Changeset in webkit [80057] by
-
- 2 edits in trunk/Tools
2011-03-01 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
Tragically, we stopped running the python unit tests
on Chromium Win just as I was getting them to be green.
This patch turns them back on.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 3:57 PM Changeset in webkit [80056] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-03-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by James Robinson.
Add a primaryKey method to IDBCursor
https://bugs.webkit.org/show_bug.cgi?id=55518
In prep for https://bugs.webkit.org/show_bug.cgi?id=55443
- public/WebIDBCursor.h: (WebKit::WebIDBCursor::primaryKey):
- 3:55 PM Changeset in webkit [80055] by
-
- 14 edits2 adds in trunk
2011-03-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
When an IDBTransaction is aborted, all requests that have not yet fired should fire an ABORT_ERR
https://bugs.webkit.org/show_bug.cgi?id=54785
- storage/indexeddb/transaction-abort.html: Added
- storage/indexeddb/transaction-abort-expected.txt: Added
2011-03-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
When an IDBTransaction is aborted, all requests that have not yet fired should fire an ABORT_ERR
https://bugs.webkit.org/show_bug.cgi?id=54785
This patch adds in a lot of sanity checks/ASSERTs to make sure we're doing
the right thing and continue to do the right thing. It also modifies EventQueue
so that we can cancel an event. To do this efficiently, the vector is now a
ListHashSet.
Cancelling the event is harder/messier, but the most deterministic thing to do.
To the user, the work isn't done until we fire the onsuccess/onerror handler.
So the event (which does fire that) needs to be cancelable.
transaction-abort.html tests this.
- dom/EventQueue.cpp: (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::cancelEvent): (WebCore::EventQueue::pendingEventTimerFired): (WebCore::EventQueue::dispatchEvent):
- dom/EventQueue.h:
- dom/ExceptionCode.cpp:
- storage/IDBCursor.cpp: (WebCore::IDBCursor::update): (WebCore::IDBCursor::deleteFunction):
- storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::close):
- storage/IDBDatabaseException.h:
- storage/IDBIndex.cpp: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor): (WebCore::IDBIndex::get): (WebCore::IDBIndex::getKey):
- storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::get): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::deleteFunction): (WebCore::IDBObjectStore::clear): (WebCore::IDBObjectStore::openCursor):
- storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::~IDBRequest): (WebCore::IDBRequest::readyState): (WebCore::IDBRequest::markEarlyDeath): (WebCore::IDBRequest::source): (WebCore::IDBRequest::abort): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent): (WebCore::IDBRequest::enqueueEvent):
- storage/IDBRequest.h:
- storage/IDBTransaction.cpp: (WebCore::IDBTransaction::registerRequest): (WebCore::IDBTransaction::unregisterRequest): (WebCore::IDBTransaction::onAbort):
- storage/IDBTransaction.h:
- 3:54 PM Changeset in webkit [80054] by
-
- 4 edits in trunk/Source/WebCore
2011-03-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Mihai Parparita.
EventQueue needs to be ref counted
https://bugs.webkit.org/show_bug.cgi?id=55512
EventQueue needs to be ref counted because it's possible for its instance
to be deleted while it's dispatching events. This is the reason why
https://bugs.webkit.org/show_bug.cgi?id=54785 had to be reverted.
No change of behavior, so no tests.
- dom/Document.h:
- dom/EventQueue.cpp: (WebCore::EventQueue::create):
- dom/EventQueue.h:
- 3:45 PM Changeset in webkit [80053] by
-
- 2 edits in trunk/Source/WebKit2
Incorporate a review comment I missed in r80051
- Shared/Plugins/Netscape/NetscapePluginModule.cpp: Clarified error message.
- 3:36 PM Changeset in webkit [80052] by
-
- 10 edits in trunk/Source/JavaScriptCore
2011-03-01 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Rolled back in r79627 now that the underlying cause for it crashing is fixed.
https://bugs.webkit.org/show_bug.cgi?id=55159
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/Heap.cpp: (JSC::Heap::allocateSlowCase):
- runtime/Heap.h:
- runtime/JSCell.h: (JSC::JSCell::MarkedSpace::sizeClassFor): (JSC::JSCell::Heap::allocate): (JSC::JSCell::JSCell::operator new):
- runtime/MarkedBlock.h:
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::allocateBlock): (JSC::MarkedSpace::reset):
- runtime/MarkedSpace.h: (JSC::MarkedSpace::SizeClass::SizeClass):
- 3:36 PM Changeset in webkit [80051] by
-
- 4 edits in trunk/Source/WebKit2
Make the PLUGIN_ARCHITECTURE() macro work with MSVC
Fixes <http://webkit.org/b/55513> <rdar://problem/9069189> REGRESSION (r79925): Lots of
plugins tests crashing in NetscapePlugin::initialize on Windows
Reviewed by Anders Carlsson.
- Shared/Plugins/Netscape/NetscapePluginModule.cpp: Added a compile-time check to make sure
PLUGIN_ARCHITECTURE() is defined for some platform.
- config.h: Removed the parentheses from the use of "defined" in the PLUGIN_ARCHITECTURE()
macro. This matches PLATFORM(), OS(), etc., and makes the macro work on Windows. Also
replaced the nonsense OS(WIN) with OS(WINDOWS).
- win/WebKit2.vcproj: Added config.h for editing convenience. Let VS do its thang.
- 3:27 PM Changeset in webkit [80050] by
-
- 1 edit3 adds in trunk/LayoutTests
2011-03-01 Tony Gentilcore <tonyg@chromium.org>
Unreviewed new baseline
[chromium] Add win baseline for fast/table/table-and-parts-outline.html
https://bugs.webkit.org/show_bug.cgi?id=55517
Test was added by r80040
- platform/chromium-win/fast/table/table-and-parts-outline-expected.checksum: Added.
- platform/chromium-win/fast/table/table-and-parts-outline-expected.png: Added.
- platform/chromium-win/fast/table/table-and-parts-outline-expected.txt: Added.
- 3:24 PM Changeset in webkit [80049] by
-
- 3 edits7 adds in trunk
2011-03-01 Helder Correia <helder@sencha.com>
Reviewed by Simon Fraser.
No shadow when stroking a path with a gradient
https://bugs.webkit.org/show_bug.cgi?id=55436
This happens in CG and is related to bug 52509, this time to be fixed
in GraphicsContext::strokePath(). The gradient needs to be drawn
clipped to the stroke on a CGLayer first, then the layer drawn on the
GraphicsContext.
- fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
- fast/canvas/canvas-strokePath-gradient-shadow.html: Added.
- fast/canvas/script-tests/canvas-strokePath-gradient-shadow.js: Added.
- platform/chromium/test_expectations.txt: Skip new test since it fails.
- platform/mac/svg/css/path-gradient-stroke-shadow-expected.checksum: Added.
- platform/mac/svg/css/path-gradient-stroke-shadow-expected.png: Added.
- platform/mac/svg/css/path-gradient-stroke-shadow-expected.txt: Added.
- platform/qt/Skipped: Skip new test since it fails.
- platform/qt/svg/css/path-gradient-stroke-shadow-expected.checksum: Added.
- platform/qt/svg/css/path-gradient-stroke-shadow-expected.png: Added.
- platform/qt/svg/css/path-gradient-stroke-shadow-expected.txt: Added.
- svg/css/path-gradient-stroke-shadow.svg: Added.
2011-03-01 Helder Correia <helder@sencha.com>
Reviewed by Simon Fraser.
No shadow when stroking a path with a gradient
https://bugs.webkit.org/show_bug.cgi?id=55436
This happens in CG and is related to bug 52509, this time to be fixed
in GraphicsContext::strokePath(). The gradient needs to be drawn
clipped to the stroke on a CGLayer first, then the layer drawn on the
GraphicsContext.
Tests: fast/canvas/canvas-strokePath-gradient-shadow.html
svg/css/path-gradient-stroke-shadow.svg
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::strokePath):
- 3:19 PM Changeset in webkit [80048] by
-
- 2 edits in trunk/Tools
2011-03-01 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Roben.
Disable
webkitpy.common.system.executive_unittest.ExecutiveTest.\
test_kill_all fails on win until it can be properly triaged.
- Scripts/webkitpy/common/system/executive_unittest.py:
2011-03-01 Helder Correia <helder@sencha.com>
Unreviewed. Add myself to committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 3:13 PM Changeset in webkit [80047] by
-
- 2 edits in trunk/Source/WebCore
Fix Font::spaceWidth() to be a float instead of an int.
Reviewed by Dan Bernstein.
- platform/graphics/Font.h:
(WebCore::Font::spaceWidth):
- 3:01 PM Changeset in webkit [80046] by
-
- 2 edits in trunk/Tools
2011-03-01 Helder Correia <helder@sencha.com>
Unreviewed. Add myself to committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 2:56 PM Changeset in webkit [80045] by
-
- 3 edits in trunk/Source/WebCore
2011-02-28 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Chromium gypi file should include Java bridge files from WebCore/bridge
https://bugs.webkit.org/show_bug.cgi?id=55387
No new tests, no code changes.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- 2:55 PM Changeset in webkit [80044] by
-
- 1 edit3 adds in trunk/LayoutTests
2011-03-01 Tony Gentilcore <tonyg@chromium.org>
Unreviewed new baseline
[chromium] Add linux baseline for fast/table/table-and-parts-outline.html
https://bugs.webkit.org/show_bug.cgi?id=55511
Test was added by r80040
- platform/chromium-linux/fast/table/table-and-parts-outline-expected.checksum: Added.
- platform/chromium-linux/fast/table/table-and-parts-outline-expected.png: Added.
- platform/chromium-linux/fast/table/table-and-parts-outline-expected.txt: Added.
- 2:47 PM TriagingTestFailures edited by
- Show only open bugs with the MakingBotsRed keyword (diff)
- 2:45 PM TriagingTestFailures edited by
- Put the more useful numbuilds=N suggestion first (diff)
- 2:34 PM Changeset in webkit [80043] by
-
- 4 edits in trunk
2011-03-01 James Simonsen <simonjam@chromium.org>
Reviewed by Tony Gentilcore.
[Web Timing] Handle the case where no responseEnd time is available.
https://bugs.webkit.org/show_bug.cgi?id=55444
- platform/chromium/test_expectations.txt: Remove CRASH from fast/dom/prototype-inheritance-2.html
2011-03-01 James Simonsen <simonjam@chromium.org>
Reviewed by Tony Gentilcore.
[Web Timing] Handle the case where no responseEnd time is available.
https://bugs.webkit.org/show_bug.cgi?id=55444
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::MainResourceLoader): Initialize to 0. (WebCore::MainResourceLoader::didFinishLoading): Fall back to current time if no other time is available.
- 2:31 PM Changeset in webkit [80042] by
-
- 2 edits in trunk/Source/WebCore
2011-03-01 Patrick Gansterer <Patrick Gansterer>
Unreviewed, adding missing change for r80034.
Add a handler class for Win32 HANDLE
https://bugs.webkit.org/show_bug.cgi?id=55334
- platform/win/Win32Handle.h: Added missing WTF_MAKE_NONCOPYABLE macro.
- 2:23 PM TriagingTestFailures edited by
- Moved the expected failure policy discussion link to a more … (diff)
- 2:22 PM Changeset in webkit [80041] by
-
- 25 edits16 deletes in trunk
2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80037.
http://trac.webkit.org/changeset/80037
https://bugs.webkit.org/show_bug.cgi?id=55508
broke compile on SL (Requested by tonyg-cr on #webkit).
- fast/css/content/content-quotes-01-expected.txt: Removed.
- fast/css/content/content-quotes-01.html: Removed.
- fast/css/content/content-quotes-02-expected.txt: Removed.
- fast/css/content/content-quotes-02.html: Removed.
- fast/css/content/content-quotes-03-expected.txt: Removed.
- fast/css/content/content-quotes-03.html: Removed.
- fast/css/content/content-quotes-04-expected.txt: Removed.
- fast/css/content/content-quotes-04.html: Removed.
- fast/css/content/content-quotes-05-expected.txt: Removed.
- fast/css/content/content-quotes-05.html: Removed.
- fast/css/content/content-quotes-06-expected.txt: Removed.
- fast/css/content/content-quotes-06.html: Removed.
2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80037.
http://trac.webkit.org/changeset/80037
https://bugs.webkit.org/show_bug.cgi?id=55508
broke compile on SL (Requested by tonyg-cr on #webkit).
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
- css/CSSParser.h:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- css/html.css: (q:before): (q:after):
- rendering/RenderBlockLineLayout.cpp: (WebCore::dirtyLineBoxesForRenderer):
- rendering/RenderObject.h:
- rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::removeChildNode): (WebCore::RenderObjectChildList::appendChildNode): (WebCore::RenderObjectChildList::insertChildNode): (WebCore::RenderObjectChildList::updateBeforeAfterContent):
- rendering/RenderQuote.cpp: Removed.
- rendering/RenderQuote.h: Removed.
- rendering/RenderingAllInOne.cpp:
- rendering/style/ContentData.cpp: (WebCore::ContentData::dataEquivalent): (WebCore::ContentData::deleteContent):
- rendering/style/ContentData.h:
- rendering/style/QuotesData.cpp: Removed.
- rendering/style/QuotesData.h: Removed.
- rendering/style/RenderStyle.cpp:
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleAllInOne.cpp:
- rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
- 2:18 PM Changeset in webkit [80040] by
-
- 3 edits4 adds in trunk
2011-03-01 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Paint outline for tables.
https://bugs.webkit.org/show_bug.cgi?id=55474
Test: fast/table/table-and-parts-outline.html
- rendering/RenderTable.cpp: (WebCore::RenderTable::paintObject):
2011-03-01 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Tests that we draw outlines for table and table cells.
https://bugs.webkit.org/show_bug.cgi?id=55474
- fast/table/table-and-parts-outline.html: Added.
- platform/mac/fast/table/table-and-parts-outline-expected.checksum: Added.
- platform/mac/fast/table/table-and-parts-outline-expected.png: Added.
- platform/mac/fast/table/table-and-parts-outline-expected.txt: Added.
- 2:07 PM Changeset in webkit [80039] by
-
- 2 edits in trunk/Source/JavaScriptCore
Replace two script phases that do nothing but copy files with copy files build phases.
Reviewed by Sam Weinig.
This speeds up the build by a few seconds on high-end Mac Pros.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 2:05 PM Changeset in webkit [80038] by
-
- 14 edits2 deletes in trunk
2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80028.
http://trac.webkit.org/changeset/80028
https://bugs.webkit.org/show_bug.cgi?id=55502
'caused crashes; rolling out while investigating' (Requested
by jorlow on #webkit).
- storage/indexeddb/transaction-abort-expected.txt: Removed.
- storage/indexeddb/transaction-abort.html: Removed.
2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80028.
http://trac.webkit.org/changeset/80028
https://bugs.webkit.org/show_bug.cgi?id=55502
'caused crashes; rolling out while investigating' (Requested
by jorlow on #webkit).
- dom/EventQueue.cpp: (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::pendingEventTimerFired): (WebCore::EventQueue::dispatchEvent):
- dom/EventQueue.h:
- dom/ExceptionCode.cpp:
- storage/IDBCursor.cpp: (WebCore::IDBCursor::update): (WebCore::IDBCursor::deleteFunction):
- storage/IDBDatabaseException.h:
- storage/IDBDatabaseException.idl:
- storage/IDBIndex.cpp: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor): (WebCore::IDBIndex::get): (WebCore::IDBIndex::getKey):
- storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::get): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::deleteFunction): (WebCore::IDBObjectStore::clear): (WebCore::IDBObjectStore::openCursor):
- storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::~IDBRequest): (WebCore::IDBRequest::readyState): (WebCore::IDBRequest::dispatchEvent): (WebCore::IDBRequest::enqueueEvent): (WebCore::IDBRequest::source):
- storage/IDBRequest.h:
- storage/IDBTransaction.cpp: (WebCore::IDBTransaction::onAbort):
- storage/IDBTransaction.h:
- 2:01 PM Changeset in webkit [80037] by
-
- 27 edits16 adds in trunk
content property doesn't support quotes
https://bugs.webkit.org/show_bug.cgi?id=6503
Reviewed by David Hyatt <hyatt@apple.com>
Source/WebCore:
Added full support for quotes as defined by CSS 2.1.
Tests: fast/css/content/content-quotes-01.html
fast/css/content/content-quotes-02.html
fast/css/content/content-quotes-03.html
fast/css/content/content-quotes-04.html
fast/css/content/content-quotes-05.html
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Added RenderQuote.cpp/h and QuotesData.cpp/h to the dependency lists
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseQuotes):
- css/CSSParser.h:
Added needed stylesheet parsing support for quotes,
(no-)open-quote and (no-)close-quote
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Handled setting of the new quotes RenderStyle property and added
handling of quotes for the content property.
- css/html.css:
(q:before):
(q:after):
replaced the '"' workaround with open/close-quote
- rendering/RenderBlockLineLayout.cpp:
(WebCore::dirtyLineBoxesForRenderer):
Made RenderQuote behave like RenderCounter.
Needed to ensure that the Quote text is calculated before layout,
just as it is for RenderCounter.
- rendering/RenderObject.h:
(WebCore::RenderObject::isQuote):
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
Handled updating of quote depth when renderers are added and removed
from the tree.
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
- rendering/RenderQuote.cpp: Added.
(WebCore::adjustDepth):
(WebCore::RenderQuote::RenderQuote):
(WebCore::RenderQuote::~RenderQuote):
(WebCore::RenderQuote::renderName):
(WebCore::RenderQuote::placeQuote):
(WebCore::RenderQuote::originalText):
(WebCore::RenderQuote::computePreferredLogicalWidths):
(WebCore::RenderQuote::rendererSubtreeAttached):
(WebCore::RenderQuote::rendererRemovedFromTree):
(WebCore::RenderQuote::styleDidChange):
- rendering/RenderQuote.h: Added.
(WebCore::RenderQuote::isQuote):
(WebCore::toRenderQuote):
- rendering/RenderingAllInOne.cpp:
Included RenderQuote.cpp
- rendering/style/StyleAllInOne.cpp:
Included QuotesData.cpp
- rendering/style/ContentData.cpp:
(WebCore::ContentData::dataEquivalent):
Checked for quotetype identity.
(WebCore::ContentData::deleteContent):
Accounted for the new QUOTE_TYPE.
- rendering/style/ContentData.h:
(WebCore::ContentData::isQuote):
(WebCore::ContentData::quote):
(WebCore::ContentData::setQuote):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setContent):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::quotes):
(WebCore::InheritedFlags::setQuotes):
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::operator==):
Included quotes in equality check.
- rendering/style/StyleRareInheritedData.h:
Added quotes
LayoutTests:
Added new tests for quotes.
- fast/css/content/content-quotes-01-expected.txt: Added.
- fast/css/content/content-quotes-01.html: Added.
- fast/css/content/content-quotes-02-expected.txt: Added.
- fast/css/content/content-quotes-02.html: Added.
- fast/css/content/content-quotes-03-expected.txt: Added.
- fast/css/content/content-quotes-03.html: Added.
- fast/css/content/content-quotes-04-expected.txt: Added.
- fast/css/content/content-quotes-04.html: Added.
- fast/css/content/content-quotes-05-expected.txt: Added.
- fast/css/content/content-quotes-05.html: Added.
- 1:57 PM Changeset in webkit [80036] by
-
- 5 edits5 adds in trunk
2011-03-01 Michael Nordman <Michael Nordman>
Reviewed by Alexey Proskuryakov.
Tests for the correct relative priorities of network vs fallback namespaces in the appcache.
If a resource url is in an appcache's network namespace and fallback namespace, the network
namespace wins (with the exception of the special '*' network namespace which does not take
priority over the fallback namespace.
https://bugs.webkit.org/show_bug.cgi?id=49292
- http/tests/appcache/online-fallback-layering-expected.txt: Added.
- http/tests/appcache/online-fallback-layering.html: Added.
- http/tests/appcache/resources/fallbacknamespace-fallback-resource.txt: Added.
- http/tests/appcache/resources/fallbacknamespace-networknamespace-existing-resource.html: Added.
- http/tests/appcache/resources/online-fallback-layering.manifest: Added.
2011-03-01 Michael Nordman <Michael Nordman>
Reviewed by Alexey Proskuryakov.
Alter the relative priorities of network vs fallback namespaces in the appcache.
If a resource url is in an appcache's network namespace and fallback namespace, the network
namespace wins (with the exception of the special '*' network namespace which does not take
priority over the fallback namespace.
https://bugs.webkit.org/show_bug.cgi?id=49292
Test: http/tests/appcache/online-fallback-layering.html
- loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::isURLInOnlineWhitelist):
- loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::shouldLoadResourceFromApplicationCache): (WebCore::ApplicationCacheHost::getApplicationCacheFallbackResource):
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
- 1:55 PM Changeset in webkit [80035] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py
Unreviewed. Add myself to the list of committers.
- 1:38 PM Changeset in webkit [80034] by
-
- 1 edit1 add in trunk/Source/WebCore
2011-03-01 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
Add a handler class for Win32 HANDLE
https://bugs.webkit.org/show_bug.cgi?id=55334
This class will call CloseHandle in the destructor for valid handles.
- platform/win/Win32Handle.h: Added.
- 1:29 PM Changeset in webkit [80033] by
-
- 2 edits in trunk/Tools
Give up if a crash log for the web process is taking too long to be saved on Windows
This should keep the bots from getting stuck while waiting for a crash log, if writing a
crash log ever hangs or the UI process for some reason doesn't notice it's finished.
Fixes <http://webkit.org/b/55499> WebKitTestRunner can hang forever waiting for a crash log
to be saved for the web process
Reviewed by Steve Falkenburg.
- WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::runRunLoopUntil): Moved code to run the run loop here here from platformRunUntil.
Generalized the code slightly to handle the optional object to wait on.
(WTR::TestController::platformRunUntil): Use the new runRunLoopUntil function, and also use
it (with a timeout) when waiting for a crash log for the web process to be saved. This will
prevent us from waiting forever.
- 1:13 PM Changeset in webkit [80032] by
-
- 2 edits in trunk/LayoutTests
2011-03-01 Tony Gentilcore <tonyg@chromium.org>
Unreviewed expectations update.
[chromium] fast/text/font-size-zero.html
https://bugs.webkit.org/show_bug.cgi?id=55497
Appears to have been fixed by r79694.
- platform/chromium/test_expectations.txt:
- 1:07 PM Changeset in webkit [80031] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, fix GTK DumpRenderTree crash.
2011-03-01 Joseph Pecoraro <Joseph Pecoraro>
Unreviewed, fix GTK DumpRenderTree crash.
Viewport parsing no longer accepts "1.0;" value as valid.
https://bugs.webkit.org/show_bug.cgi?id=53705
Follow-up fix. Pass the correct number of arguments
into layoutTestController.dumpConfigurationForViewport.
- fast/viewport/viewport-129.html:
- 12:54 PM Changeset in webkit [80030] by
-
- 10 edits in trunk/Source/WebCore
2011-03-01 Eric Carlson <eric.carlson@apple.com>
Reviewed by Chris Marrin.
<audio> and <video> should respect private browsing mode
https://bugs.webkit.org/show_bug.cgi?id=55287
<rdar://problem/9057699>
No new tests, this is just the plumbing.
- dom/Document.cpp: (WebCore::Document::privateBrowsingStateDidChange): New. (WebCore::Document::registerForPrivateBrowsingStateChangedCallbacks): Ditto. (WebCore::Document::unregisterForPrivateBrowsingStateChangedCallbacks): Ditto.
- dom/Document.h:
- dom/Element.h: (WebCore::Element::privateBrowsingStateDidChange): New.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Register for privacy mode changes. (WebCore::HTMLMediaElement::~HTMLMediaElement): Unregister for privacy mode changes. (WebCore::HTMLMediaElement::loadResource): Tell player current privacy mode. (WebCore::HTMLMediaElement::privateBrowsingStateDidChange): New, call through to MediaPlayer.
- html/HTMLMediaElement.h:
- page/Page.cpp: (WebCore::Page::privateBrowsingStateChanged): Call document()->privateBrowsingStateDidChange.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::setPrivateBrowsingMode): New, call through to media engine.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setPrivateBrowsingMode): Declare new interface.
- 12:45 PM Changeset in webkit [80029] by
-
- 2 edits in trunk/Source/WebKit/gtk
2011-03-01 Kamil Blank <k.blank@samsung.com>
Reviewed by Martin Robinson.
[GTK] Fixing headers order in webkit.h.
https://bugs.webkit.org/show_bug.cgi?id=55316
- webkit/webkit.h: Style fix.
- 12:42 PM Changeset in webkit [80028] by
-
- 14 edits2 adds in trunk
2011-02-18 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
When an IDBTransaction is aborted, all requests that have not yet fired should fire an ABORT_ERR
https://bugs.webkit.org/show_bug.cgi?id=54785
- storage/indexeddb/transaction-abort.html: Added
- storage/indexeddb/transaction-abort-expected.txt: Added
2011-02-18 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
When an IDBTransaction is aborted, all requests that have not yet fired should fire an ABORT_ERR
https://bugs.webkit.org/show_bug.cgi?id=54785
This patch adds in a lot of sanity checks/ASSERTs to make sure we're doing
the right thing and continue to do the right thing. It also modifies EventQueue
so that we can cancel an event. To do this efficiently, the vector is now a
ListHashSet.
Canelling the event is harder/messier, but the most deterministic thing to do.
To the user, the work isn't done until we fire the onsuccess/onerror handler.
So the event (which does fire that) needs to be cancelable.
transaction-abort.html tests this.
- dom/EventQueue.cpp: (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::cancelEvent): (WebCore::EventQueue::pendingEventTimerFired): (WebCore::EventQueue::dispatchEvent):
- dom/EventQueue.h:
- dom/ExceptionCode.cpp:
- storage/IDBCursor.cpp: (WebCore::IDBCursor::update): (WebCore::IDBCursor::deleteFunction):
- storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::close):
- storage/IDBDatabaseException.h:
- storage/IDBIndex.cpp: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor): (WebCore::IDBIndex::get): (WebCore::IDBIndex::getKey):
- storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::get): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::deleteFunction): (WebCore::IDBObjectStore::clear): (WebCore::IDBObjectStore::openCursor):
- storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::~IDBRequest): (WebCore::IDBRequest::readyState): (WebCore::IDBRequest::markEarlyDeath): (WebCore::IDBRequest::source): (WebCore::IDBRequest::abort): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent): (WebCore::IDBRequest::enqueueEvent):
- storage/IDBRequest.h:
- storage/IDBTransaction.cpp: (WebCore::IDBTransaction::registerRequest): (WebCore::IDBTransaction::unregisterRequest): (WebCore::IDBTransaction::onAbort):
- storage/IDBTransaction.h:
- 12:40 PM Changeset in webkit [80027] by
-
- 2 edits in trunk/LayoutTests
2011-03-01 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
[chromium] Skip test added w/o expectations
https://bugs.webkit.org/show_bug.cgi?id=55496
Added by r80012 without expectations
- platform/chromium/test_expectations.txt:
- 12:39 PM Changeset in webkit [80026] by
-
- 2 edits in trunk/LayoutTests
2011-03-01 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations change. Remove failing expectations for
editing/ tests that pass after r79961.
- platform/chromium/test_expectations.txt:
- 12:37 PM Changeset in webkit [80025] by
-
- 8 edits in trunk
2011-02-28 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Only IndexedDB's error event should be cancelable
https://bugs.webkit.org/show_bug.cgi?id=55413
Add checks to existing tests.
- storage/indexeddb/objectstore-basics.html:
- storage/indexeddb/transaction-basics.html:
2011-02-28 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Only IndexedDB's error event should be cancelable
https://bugs.webkit.org/show_bug.cgi?id=55413
- storage/IDBRequest.cpp: (WebCore::createSuccessEvent):
- storage/IDBTransaction.cpp: (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete):
- 12:34 PM Changeset in webkit [80024] by
-
- 2 edits in trunk/Tools
Give WebKitLauncherWin's PDB file a name different from WebKit's
WebKitLauncherWin (which builds WebKit.exe) and WebKit (which builds WebKit.dll) were
fighting over the same PDB file, meaning that one of them was going to lose and not have
symbols. WebKitLauncherWin's PDB file is now named WebKitLauncherWin.pdb.
Fixes <http://webkit.org/b/55495> Crashes in WebKit.dll have bad backtraces for some test
runs (due to missing symbols)
Reviewed by David Kilzer.
- WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Use the project name,
"WebKitLauncherWin", instead of the target name, "WebKit", when naming the PDB file.
- 12:31 PM Changeset in webkit [80023] by
-
- 25 edits2 copies2 adds in trunk
2011-03-01 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Remove CorrectionIndicator markers sooner.
https://bugs.webkit.org/show_bug.cgi?id=54893
<rdar://problem/8997524>
See WebCore/ChangeLog for detail.
- platform/mac-leopard/Skipped:
- platform/mac-snowleopard/Skipped:
- platform/mac-tiger/Skipped:
- platform/mac-wk2/Skipped:
- platform/mac/editing/spelling/autocorrection-simple-expected.checksum:
- platform/mac/editing/spelling/autocorrection-simple-expected.png:
- platform/mac/editing/spelling/autocorrection-simple-expected.txt:
- platform/mac/editing/spelling/autocorrection-simple.html:
- platform/mac/editing/spelling/delete-into-autocorrected-word-expected.checksum:
- platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png:
- platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.checksum: Added.
- platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.png: Added.
- platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt: Copied from LayoutTests/platform/mac/editing/spelling/autocorrection-simple-expected.txt.
- platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html: Copied from LayoutTests/platform/mac/editing/spelling/autocorrection-simple.html.
2011-03-01 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Remove CorrectionIndicator markers sooner.
https://bugs.webkit.org/show_bug.cgi?id=54893
<rdar://problem/8997524>
Test: platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html
This patch changes the autocorrection behavior on Mac OS X. We want to remove CorrectionIndicator
marker after any editing command if the command:
- is not a SpellingCorrectionCommand itself.
- is not the command that triggers the autocorrection. This is achieved by adding shouldRetainAutocorrectionIndicator() function to EditCommand. This function returns false for all commands derived from EditCommand, except SpellingCorrectionCommand and TypingCommand. This function always returns true for SpellingCorrectionCommand. For TypingCommand, the return value is determined by member variable m_shouldRetainAutocorrectionIndicator, which can be modified by passing option into the TypingCommand's public functions.
To avoid constantly searching marker list, we use variable DocumentMarkerController::m_absentMarkerTypeCache
to cache whether there is any marker of a particular type.
This patch also fixes two minor existing bugs.
- We used to show reversion panel for word with CorrectionIndicator marker. This is incorrect because CorrectionIndicator marker can be removed from corrected words. Since all autocorrected words have Replacement marker unless the whole word is deleted, the correct behavior is to show reversion panel for word with Replacement marker, since all autocorrected words have such marker. However, since we don't want to show the reversion panel if an autocorrected word has been edited, we also check to see if the Replacement marker's description is null.
This works as following:
When we apply an autocorrection, we add Replacement marker to corrected word, and store original word
as the marker's description. If the user edited the corrected word afterward, we set description to null.
So when we decide whether to show a reversion panel, we not only check for the existence of Replacement
marker, but also check if description is null.
- Fixed an assertion violation in Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited(), which would occur when deleting the first character in an editable area.
- dom/DocumentMarker.h: Added m_possiblyExistingMarkerTypes to allow quickly checking whether a marker type is
completely in from the document.
- dom/DocumentMarkerController.cpp: Most of the functions listed here are optimized for early return by checking
the return value of possiblyHasMarkers() at beginning.
(WebCore::DocumentMarkerController::possiblyHasMarkers):
(WebCore::DocumentMarkerController::DocumentMarkerController):
(WebCore::DocumentMarkerController::detach):
(WebCore::DocumentMarkerController::removeMarkers):
(WebCore::DocumentMarkerController::addMarker):
(WebCore::DocumentMarkerController::copyMarkers):
(WebCore::DocumentMarkerController::markerContainingPoint):
(WebCore::DocumentMarkerController::renderedRectsForMarkers):
(WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair):
(WebCore::DocumentMarkerController::repaintMarkers):
(WebCore::DocumentMarkerController::shiftMarkers):
(WebCore::DocumentMarkerController::setMarkersActive):
(WebCore::DocumentMarkerController::hasMarkers):
(WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
- dom/DocumentMarkerController.h:
- editing/EditCommand.cpp: (WebCore::EditCommand::apply): (WebCore::EditCommand::shouldRetainAutocorrectionIndicator): (WebCore::EditCommand::setShouldRetainAutocorrectionIndicator):
- editing/EditCommand.h:
- editing/Editor.cpp: (WebCore::Editor::respondToChangedSelection): (WebCore::Editor::appliedEditing): (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::insertLineBreak): (WebCore::Editor::insertParagraphSeparator): (WebCore::Editor::markMisspellingsAfterTypingToWord): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited): (WebCore::Editor::applyAutocorrectionBeforeTypingIfAppropriate):
- editing/Editor.h:
- editing/EditorCommand.cpp: (WebCore::executeInsertLineBreak): (WebCore::executeInsertParagraph): (WebCore::executeInsertText):
- editing/SpellingCorrectionCommand.cpp: (WebCore::SpellingCorrectionCommand::shouldRetainAutocorrectionIndicator):
- editing/SpellingCorrectionCommand.h:
- editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::deleteSelection): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed): (WebCore::TypingCommand::updateSelectionIfDifferentFromCurrentSelection): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::insertLineBreak): (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent): (WebCore::TypingCommand::insertParagraphSeparator):
- editing/TypingCommand.h: (WebCore::TypingCommand::create): (WebCore::TypingCommand::shouldRetainAutocorrectionIndicator): (WebCore::TypingCommand::setShouldRetainAutocorrectionIndicator):
- manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html:
- 12:15 PM Changeset in webkit [80022] by
-
- 5 edits in trunk/Source/WebCore
2011-03-01 Renata Hodovan <reni@webkit.org>
Reviewed by Andreas Kling.
FEDisplacementMapElement changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=55454
When the FEDisplacementMapElement receives an update message but the given value remains the same we don't need
to relayout the filter.
No new tests are needed because this modification is covered by the dynamic update tests of FEDisplacementMap.
- platform/graphics/filters/FEDisplacementMap.cpp: (WebCore::FEDisplacementMap::setXChannelSelector): (WebCore::FEDisplacementMap::setYChannelSelector): (WebCore::FEDisplacementMap::setScale):
- platform/graphics/filters/FEDisplacementMap.h:
- svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::setFilterEffectAttribute): (WebCore::SVGFEDisplacementMapElement::svgAttributeChanged):
- svg/SVGFEDisplacementMapElement.h:
- 12:10 PM Changeset in webkit [80021] by
-
- 2 edits in trunk/Source/JavaScriptCore
Spring cleaning!
Rubber-stamped by Mark Rowe.
- JavaScriptCore.xcodeproj/project.pbxproj:
(Copy Into Framework): Remove "set -x" and its comment.
- 12:03 PM Changeset in webkit [80020] by
-
- 2 edits in trunk/LayoutTests
2011-03-01 Tony Gentilcore <tonyg@chromium.org>
Unreviewed build fix.
[chromium] pass fast/table/fixed-with-auto-with-colspan-vertical.html
https://bugs.webkit.org/show_bug.cgi?id=55491
Fixed by r79760.
- platform/chromium/test_expectations.txt:
- 12:02 PM Changeset in webkit [80019] by
-
- 2 edits in trunk/Tools
Count web process crashes toward the --exit-after-n-crashes-or-timeouts limit
Fixes <http://webkit.org/b/55492> Web process crashes aren't counted toward the
--exit-after-n-crashes-or-timeouts limit
Reviewed by David Kilzer.
- Scripts/old-run-webkit-tests:
(stopRunningTestsEarlyIfNeeded): Include web process crashes in the computation, and print
the number of tests that caused the web process to crash when exiting early.
- 11:54 AM Changeset in webkit [80018] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-03-01 Michael Saboff <msaboff@apple.com>
Reviewed by Darin Adler.
TinyMCE not working in nightlies
https://bugs.webkit.org/show_bug.cgi?id=54978
Disabling setupBeginChars() to temporarily work arround the test
failure. Filed https://bugs.webkit.org/show_bug.cgi?id=55479
to track fixing the issue.
- yarr/YarrPattern.cpp: (JSC::Yarr::YarrPattern::compile):
- 11:53 AM Changeset in webkit [80017] by
-
- 4 edits2 adds2 deletes in trunk/LayoutTests
2011-03-01 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Create layout test for progress event and remove test for suspend event.
LayoutTests/http/tests/media/video-play-suspend is now hanging on chromium
https://bugs.webkit.org/show_bug.cgi?id=55198
- http/tests/media/video-play-progress-expected.txt: Added.
- http/tests/media/video-play-progress.html: Added.
- http/tests/media/video-play-suspend-expected.txt: Removed.
- http/tests/media/video-play-suspend.html: Removed.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/win/Skipped:
- 11:49 AM Changeset in webkit [80016] by
-
- 1 edit6 adds in trunk/LayoutTests
2011-03-01 Martin Robinson <mrobinson@igalia.com>
REGRESSION (r79762): Items in <select multiple> have focus rings, but shouldn't
https://bugs.webkit.org/show_bug.cgi?id=55323
Add new GTK+ test results.
- platform/gtk/fast/forms/select-listbox-multiple-no-focusring-expected.checksum: Added.
- platform/gtk/fast/forms/select-listbox-multiple-no-focusring-expected.png: Added.
- platform/gtk/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Added.
- platform/gtk/fast/spatial-navigation/snav-multiple-select-focusring-expected.checksum: Added.
- platform/gtk/fast/spatial-navigation/snav-multiple-select-focusring-expected.png: Added.
- 11:48 AM Changeset in webkit [80015] by
-
- 18 edits in trunk
<rdar://problem/8902714> Expand ruby text when it is shorter than the ruby base
https://bugs.webkit.org/show_bug.cgi?id=55487
Reviewed by Darin Adler.
Source/WebCore:
- css/html.css:
(ruby > rt): Changed the default text-align value to -webkit-auto to signal
the default expansion behavior.
- rendering/RenderBlock.h:
(WebCore::RenderRubyText::textAlignmentForLine): Made protected.
(WebCore::RenderBlock::adjustInlineDirectionLineBounds): Made protected.
- rendering/RenderRubyText.cpp:
(WebCore::RenderRubyText::textAlignmentForLine): Added. If text-align is
-webkit-auto, returns JUSTIFY to allow expansion.
(WebCore::RenderRubyText::adjustInlineDirectionLineBounds): Added. If
text-align is -webkit-auto, insets the line such that the inset on each side
is the half the inter-ideograph expansion, or one ruby character wide,
whichever is smaller.
- rendering/RenderRubyText.h:
LayoutTests:
- platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
- platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
- platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
- platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum:
- platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.png:
- platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
- platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
- platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
- platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
- platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
- platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
- platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
- 11:41 AM Changeset in webkit [80014] by
-
- 13 edits1 copy1 move1 add in trunk/Source
WebKit2 needs to be made localizable
https://bugs.webkit.org/show_bug.cgi?id=55483
Reviewed by Timothy Hatcher.
Source/WebCore:
- English.lproj/Localizable.strings: Copied from Source/WebKit/English.lproj/Localizable.strings.
- WebCore.xcodeproj/project.pbxproj:
Move Localizable.strings to WebCore.
- WebCore.exp.in:
Add export for localizedString function.
- platform/LocalizedStrings.h:
- platform/mac/LocalizedStringsMac.mm: Added.
Add function to get localized version of a string from the WebCore bundle.
Source/WebKit:
- StringsNotToBeLocalized.txt: Removed.
- WebKit.xcodeproj/project.pbxproj:
Copied Localizable.strings to WebCore, it can't be removed entirely
yet since Windows is still using it.
Source/WebKit/mac:
- WebCoreSupport/WebPlatformStrategies.mm:
Use WebCore's localizedString function instead of WebLocalizableStrings
since WebCore is now responsible for localization.
Source/WebKit2:
- PluginProcess/mac/PluginProcessMainMac.mm:
- WebProcess/mac/WebProcessMainMac.mm:
Set the default localization from the passed in parameter.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
Add the preferred localization as a parameter when launching processes
so that they can set their localization to match the launching app.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
Use WebCore's localizedString function on the mac, to actually localize
these strings.
(WebKit::WebPlatformStrategies::imageTitle):
Switch to using replace, instead of concatenation, to give localizers a chance
to rearrange the wording.
- 11:34 AM TriagingTestFailures edited by
- Added an example URL using numbuilds=N (diff)
- 11:26 AM Changeset in webkit [80013] by
-
- 1 edit44 adds in trunk/LayoutTests
2011-03-01 Sergio Villar Senin <svillar@igalia.com>
Unreviewed.
Added new GTK test expectations.
- platform/gtk/fast/block/positioning/auto/vertical-lr/: 7 tests.
- platform/gtk/fast/block/positioning/auto/vertical-rl/: 7 tests.
- 11:03 AM Changeset in webkit [80012] by
-
- 10 edits1 add in trunk
Viewport parsing no longer accepts "1.0;" value as valid.
Reviewed by Kenneth Rohde Christiansen.
LayoutTests:
2011-02-23 Joseph Pecoraro <Joseph Pecoraro>
Viewport parsing no longer accepts "1.0;" value as valid.
https://bugs.webkit.org/show_bug.cgi?id=53705
Add a new test to check viewport argument parsing of
value "123x456", which although not completely a number
should return the numeric prefix "123" as the value.
Note that this affects "semicolons as separators" even
though semicolons are not valid separators.
- fast/viewport/viewport-129.html: Added.
Source/JavaScriptCore:
2011-02-23 Joseph Pecoraro <Joseph Pecoraro>
Viewport parsing no longer accepts "1.0;" value as valid.
https://bugs.webkit.org/show_bug.cgi?id=53705
Include a didReadNumber parameter to String -> float / double
conversion functions. This way, if the "ok" boolean out
parameter is false, you can check to see if there in fact
was a valid number parsed with garbage at the end. Examples
of that would be parsing "123x456" would have ok = false,
but didReadNumber = true.
- JavaScriptCore.exp:
- wtf/text/StringImpl.cpp: (WTF::StringImpl::toDouble): (WTF::StringImpl::toFloat):
- wtf/text/StringImpl.h:
- wtf/text/WTFString.cpp: (WTF::String::toDouble): (WTF::String::toFloat): (WTF::charactersToDouble): (WTF::charactersToFloat):
- wtf/text/WTFString.h:
Source/WebCore:
2011-02-23 Joseph Pecoraro <Joseph Pecoraro>
Viewport parsing no longer accepts "1.0;" value as valid.
https://bugs.webkit.org/show_bug.cgi?id=53705
When parsing numeric values, the "css-viewport" spec says
to use the number prefix, and the non numeric part of the
string can be ignored. This matches our behavior before
r67376. The change was that checking the error out condition
of String::toFloat doesn't necessarily mean that there
was a non-numeric prefix. This patch checks if there was
or wasn't a non-numeric prefix.
There is a console warning in any case where a numeric
value is not parsed cleanly. There is an error warning
when it is not a number at all, and a tip warning when
it has been truncated.
Error messages are slightly improved to provide more
context, both the key and value, when an error happens.
Test: fast/viewport/viewport-129.html
- dom/ViewportArguments.cpp: (WebCore::numericPrefix): (WebCore::findSizeValue): (WebCore::findScaleValue): (WebCore::findUserScalableValue): (WebCore::findTargetDensityDPIValue): (WebCore::viewportErrorMessageTemplate): (WebCore::viewportErrorMessageLevel): (WebCore::reportViewportWarning):
- dom/ViewportArguments.h:
- 10:45 AM Changeset in webkit [80011] by
-
- 4 edits in trunk/WebKitLibraries
WebKit2 needs to be made localizable
<rdar://problem/8728860>
Reviewed by Anders Carlsson.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 10:26 AM Changeset in webkit [80010] by
-
- 2 edits in trunk/LayoutTests
2011-03-01 Sergio Villar Senin <svillar@igalia.com>
Unreviewed.
Removed accessibility/canvas-fallback-content.html from Skipped
list as it was removed in 79920
- platform/gtk/Skipped:
- 10:13 AM Changeset in webkit [80009] by
-
- 11 edits in trunk/Tools
Save a crash log when the web process crashes
On Windows, WebKitTestRunner now detects when the web process is crashing and waits to exit
until it has finished crashing, which guarantees that the crash log will have had time to be
saved, too. On Mac, we always wait until ReportCrash has exited before capturing the crash
log, so all we have to do is choose the right crash log out of the CrashReporter directory.
Fixes <http://webkit.org/b/44121> <rdar://problem/8320759> When the web process crashes and
a crash log is being saved, WebKitTestRunner thinks the web process has become unresponsive
Reviewed by Sam Weinig.
- Scripts/old-run-webkit-tests:
(testCrashedOrTimedOut): Don't kill WebKitTestRunner when the web process crashes. It will
kill itself. On Windows, this will cause us to wait until the crash log has been saved. On
Mac, it should have no effect. Capture saved crash logs for web process crashes, too.
(captureSavedCrashLog): Added $webProcessCrashed argument. On Mac, look for
WebProces_*.crash files when the web process crashes.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::initialize): Added an initializationUserData argument. Updated for
initializePlatformDefaults -> platformInitialize rename. Pass the initializationUserData
along to platformInitialize.
- WebKitTestRunner/InjectedBundle/InjectedBundle.h: See above.
- WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
(WKBundleInitialize): Pass along the initializationUserData to the InjectedBundle.
- WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize):
- WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
(WTR::InjectedBundle::platformInitialize):
Updated function signature.
- WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
(WTR::exceptionFilter): Added. Tells the UI process we're crashing by signaling the
webProcessCrashingEvent, then lets the crash continue as normal.
(WTR::InjectedBundle::platformInitialize): Hook up exceptionFilter. Retrieve the name of the
event we should use to tell the UI process we're crashing from the initializationUserData,
and get a handle to that event.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController): Initialize new members.
(WTR::TestController::processDidCrash): Removed unnecessary WKPageRef argument. Changed to
only print the "#CRASHED - WebProcess" message once, since this can be called more than once
when a crash log is being saved on Windows. Exit right away if specified. (This is the
default.)
- WebKitTestRunner/TestController.h: Added new members.
- WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::platformInitialize): Set up the event the web process will use to tell
us it's crashing.
(WTR::TestController::platformRunUntil): Pass MWMO_INPUTAVAILABLE to
::MsgWaitForMultipleObjectsEx so we'll process messages that have already been seen by
::PeekMessage. (This is unrelated to the bug fix.) Notice when the webProcessCrashingEvent
has been signaled. When this happens, print the "#CRASHED - WebProcess" message right away
so the test harness will know the web process has crashed and not try to kill us, then wait
for the web process to finish crashing so a crash log will have time to be saved.
(WTR::toWK): Simple hepler function.
(WTR::TestController::platformInitializeContext): Pass along the name of the event the web
process should use to tell us it is crashing in the context's initialization user data.
- 10:00 AM Changeset in webkit [80008] by
-
- 2 edits in trunk/Tools
2011-03-01 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Tony Gentilcore.
Move the checks to exclude Python/Perl tests for Chromium Win build to the right place.
https://bugs.webkit.org/show_bug.cgi?id=55476
Chromium Win uses BuildAndTestFactory, not TestFactory.
- BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved to the right place.
- 9:47 AM Changeset in webkit [80007] by
-
- 8 edits in trunk/Source/WebKit2
2011-03-01 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Anders Carlsson.
[Qt][WK2] Plugin initialization
https://bugs.webkit.org/show_bug.cgi?id=48127
Apply the quirks that are necessary for the flash plugin
to not crash on X11.
- Platform/qt/ModuleQt.cpp: (WebKit::Module::load): Use the ResolveAllSymbols hint as we do in WebCore.
- Shared/Plugins/Netscape/NetscapePluginModule.cpp: (WebKit::NetscapePluginModule::tryLoad): Call applyX11QuirksBeforeLoad if PLUGIN_ARCHITECTURE is X11.
- Shared/Plugins/Netscape/NetscapePluginModule.h:
- Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp: (WebKit::initializeGTK): The same hack that we do in WebCore. Call gtk_init because flash don't do it for itself. (WebKit::NetscapePluginModule::applyX11QuirksBeforeLoad): Added for X11. Do the hacks that we need to do before calling NP_Initialize on the flash plugin to save it form crashing.
- Shared/Plugins/PluginQuirks.h: Use PLUGIN_ARCHITECTURE macros. Added RequiresGTKToolKit quirk for X11.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_GetValue): Handle the RequiresGTKToolKit quirk on X11.
- WebProcess/Plugins/Netscape/NetscapePlugin.h: (WebKit::NetscapePlugin::quirks): Added getter for the PluginModule's quirks to be available in NPN_GetValue.
- 9:41 AM Changeset in webkit [80006] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-02-28 Geoffrey Garen <ggaren@apple.com>
Reviewed by Gavin Barraclough.
Past-the-end writes in VM exceptions (caused crashes in r79627)
https://bugs.webkit.org/show_bug.cgi?id=55448
Some exceptions had the wrong structures, so they misoverestimated their
inline storage sizes.
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): Use the right structure.
- runtime/JSObject.h: (JSC::JSNonFinalObject::JSNonFinalObject): (JSC::JSFinalObject::JSFinalObject): ASSERT that our structure capacity is correct to verify this doesn't happen again.
- 9:28 AM Changeset in webkit [80005] by
-
- 2 edits in trunk/Source/WebCore
2011-03-01 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: InjectedScript.setPropertyValue doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=55475
- inspector/InjectedScript.cpp: (WebCore::InjectedScript::setPropertyValue):
- 9:23 AM Changeset in webkit [80004] by
-
- 4 edits in trunk/Source/WebCore
2011-03-01 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Remove unused JavaString::uchars()
https://bugs.webkit.org/show_bug.cgi?id=55465
No new tests, removing dead code only.
- bridge/jni/JNIBridge.h:
- bridge/jni/jsc/JavaStringJSC.h: (JSC::Bindings::JavaStringImpl::utf8):
- bridge/jni/v8/JavaStringV8.h:
- 8:51 AM Changeset in webkit [80003] by
-
- 4 edits in trunk/Source/WebCore
2011-03-01 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Extremely slow DOM search in GMail
https://bugs.webkit.org/show_bug.cgi?id=55456
The solution comprises three major parts:
- avoid multiple invocations of highlightSearchResults(), one per each nodeIds chunk.
- cache highlighted node's innerHTML so that no extra _nodeTitleInfo() calls will be needed.
- replace hand-written Text nodes iteration with a snapshot-based ".text()" XPathResult.
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.addNodesToSearchResult):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.highlightSearchResults): (WebInspector.ElementsTreeElement.prototype.updateTitle): ():
- inspector/front-end/utilities.js: ():
- 7:42 AM Changeset in webkit [80002] by
-
- 2 edits in trunk/Source/WebCore
Fix multiple-definition linker warnings introduced by r79978 on Windows
- rendering/RenderingAllInOne.cpp: Removed TextControlInnerElements.cpp, as it is now being
compiled separately.
- 7:29 AM Changeset in webkit [80001] by
-
- 9 edits1 copy1 add in trunk
Convert seconds to milliseconds before calling ::SetTimer
Fixes <http://webkit.org/b/55417> <rdar://problem/9065287> RunLoop::Timer fires 1000x too
early on Windows
Reviewed by Anders Carlsson.
Source/WebKit2:
- Platform/win/RunLoopWin.cpp:
(RunLoop::TimerBase::start): Convert the timeout interval to milliseconds, since that's what
::SetTimer expects.
Tools:
Test that the WebKit2 responsiveness timer doesn't fire too early
- TestWebKitAPI/PlatformUtilities.h: Added sleep().
- TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Added.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::processDidBecomeUnresponsive):
(TestWebKitAPI::setInjectedBundleClient):
(TestWebKitAPI::setPageLoaderClient):
Simple helper functions.
(TestWebKitAPI::TEST): Load an HTML file to make sure the web process is initialized. Then
tell the web process to pause and press the spacebar key. The spacebar keypress should cause
the responsiveness timer to start, but the web process should unpause before it has a chance
to fire. Run until the web process has unpaused, and assert that the timer didn't fire.
- TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Added.
(TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::ResponsivenessTimerDoesntFireEarlyTest):
Call up to the base class.
(TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::didReceiveMessage): When asked to
pause, sleep for 0.5 seconds, then send back a message saying we paused.
- TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::sleep): Added. Calls through to usleep.
- TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
(TestWebKitAPI::Util::sleep): Added. Calls through to ::Sleep.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/win/TestWebKitAPI.vcproj:
- TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
Added new files.
- 7:14 AM Changeset in webkit [80000] by
-
- 1 edit4 adds in trunk/LayoutTests/platform
Unreviewed. Rebaselining Chromium expectations.
- platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum
- platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum
- platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png
- platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png
- platform/chromium/test_expectations.txt
- 7:13 AM Changeset in webkit [79999] by
-
- 17 edits in trunk
2011-03-01 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Clean up the project files and move common options to WebKit.pri.
Mac related changes suggested by Prasanth Ullattil <prasanth.ullattil@nokia.com>
- Source/WebKit.pri: Common options should be here. Also move Mac options to this file to fix the Mac build.
2011-03-01 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Clean up the project files and move common options to WebKit.pri.
- JavaScriptCore.pri: Move options also needed in WebCore into WebKit.pri.
- JavaScriptCore.pro: Deduplicate options.
- jsc.pro: Ditto.
2011-03-01 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Clean up the project files and move common options to WebKit.pri.
- api/QtScript.pro: Deduplicate options.
2011-03-01 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Clean up the project files and move common options to WebKit.pri.
No new tests needed.
- WebCore.pri: Move common options to WebKit.pri.
- WebCore.pro: Ditto.
2011-03-01 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Clean up the project files and move common options to WebKit.pri.
- QtWebKit.pro: Move common options to WebKit.pri.
2011-03-01 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Clean up the project files and move common options to WebKit.pri.
- WebKit2.pro: Deduplicate options.
2011-03-01 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Clean up the project files and move common options to WebKit.pri.
- WebKitTestRunner/qt/WebKitTestRunner.pro: Deduplicate.
- 6:31 AM Changeset in webkit [79998] by
-
- 11 edits in trunk/Source/WebCore
2011-03-01 Steve Block <steveblock@google.com>
Reviewed by Pavel Feldman.
JNI code in Java bridge is not correctly guarded
https://bugs.webkit.org/show_bug.cgi?id=55459
No new tests, build fix only.
- bridge/jni/v8/JNIBridgeV8.cpp:
- bridge/jni/v8/JNIBridgeV8.h:
- bridge/jni/v8/JNIUtilityPrivate.cpp:
- bridge/jni/v8/JNIUtilityPrivate.h:
- bridge/jni/v8/JavaClassV8.cpp:
- bridge/jni/v8/JavaClassV8.h:
- bridge/jni/v8/JavaInstanceV8.cpp:
- bridge/jni/v8/JavaInstanceV8.h:
- bridge/jni/v8/JavaNPObjectV8.cpp:
- bridge/jni/v8/JavaNPObjectV8.h:
- 6:13 AM Changeset in webkit [79997] by
-
- 3 edits in trunk/Source/WebKit2
2011-03-01 Juha Savolainen <juha.savolainen@weego.fi>
Reviewed by Andreas Kling.
[Qt] WebKit2 needs to support font size changing and getting default font size
https://bugs.webkit.org/show_bug.cgi?id=53671
Added new enum for font size type and added methods to set and get default font sizes.
- UIProcess/API/qt/qwkpreferences.cpp: (QWKPreferences::setFontSize): Added. (QWKPreferences::fontSize): Added.
- UIProcess/API/qt/qwkpreferences.h:
- 6:01 AM Changeset in webkit [79996] by
-
- 3 edits3 adds in trunk/Source/WebKit/qt
2011-03-01 Aparna Nandyal <aparna.nand@wipro.com>
Reviewed by Simon Hausmann.
[Qt]tst_QWebPage::backActionUpdate fails when there is not network connection
https://bugs.webkit.org/show_bug.cgi?id=55319
The test case required internet connection to be able to connect to
google.com. Added new html file which refers to local html file.
- tests/qwebpage/resources/content.html: Added.
- tests/qwebpage/resources/frame_c.html: Added.
- tests/qwebpage/resources/framedindex.html: Added.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::backActionUpdate):
- tests/qwebpage/tst_qwebpage.qrc:
- 5:55 AM Changeset in webkit [79995] by
-
- 2 edits in trunk/LayoutTests
2011-03-01 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: remove manual watchdog from the inspector tests.
https://bugs.webkit.org/show_bug.cgi?id=55447
- http/tests/inspector/inspector-test.js:
- 5:53 AM Changeset in webkit [79994] by
-
- 2 edits in trunk/LayoutTests
Skip another timing-out test on Windows XP
<http://webkit.org/b/51596> tracks the failure.
- platform/win-xp/Skipped: Added http/tests/xmlhttprequest/basic-auth-nouser.html.
- 5:52 AM Changeset in webkit [79993] by
-
- 2 edits in trunk/Tools
Skip another multiprocessing test on Windows
It is sometimes failing (and may be leaving child Python processes around).
<http://webkit.org/b/55087> tracks the failure.
- Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
(FuncitonTests.test_getprocesses): Skip this test on Windows.
- 5:52 AM Changeset in webkit [79992] by
-
- 2 edits1 delete in trunk/LayoutTests
Skip fast/events/pageshow-pagehide-on-back-cached.html on Windows
It is flaky. The failure is tracked by <http://webkit.org/b/55329>.
- platform/win/Skipped:
- platform/win/fast/events/pageshow-pagehide-on-back-cached-expected.txt: Removed.
- 5:51 AM Changeset in webkit [79991] by
-
- 1 edit2 adds in trunk/LayoutTests
Check in Windows pixel results to match text results added in r79979
Fixes <http://webkit.org/b/55451> [Win] select-listbox-multiple-no-focusring.html needs
rebaseline
- platform/win/fast/forms/select-listbox-multiple-no-focusring-expected.checksum: Added.
- platform/win/fast/forms/select-listbox-multiple-no-focusring-expected.png: Added.
- 5:14 AM Changeset in webkit [79990] by
-
- 2 edits in trunk/LayoutTests
2011-03-01 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip one crashing tests on GTK. See also
https://bugs.webkit.org/show_bug.cgi?id=53146
- platform/gtk/Skipped:
- 4:09 AM Changeset in webkit [79989] by
-
- 2 edits in trunk/LayoutTests
2011-03-01 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip 2 crashing tests on GTK. See also
https://bugs.webkit.org/show_bug.cgi?id=53146
- platform/gtk/Skipped:
- 3:51 AM Changeset in webkit [79988] by
-
- 44 edits in trunk/Source
2011-03-01 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Bridge.h should not include BridgeJSC.h
https://bugs.webkit.org/show_bug.cgi?id=55212
Instead, BridgeJSC.h should include Bridge.h and code should include
BridgeJSC.h as appropriate.
This prevents ports that use V8 from having to include JSC-specific
files, even if the contents of those files are guarded.
No new tests, cleanup only.
- bindings/js/JSPluginElementFunctions.cpp:
- bindings/js/ScriptControllerBrew.cpp:
- bindings/js/ScriptControllerGtk.cpp:
- bindings/js/ScriptControllerHaiku.cpp:
- bindings/js/ScriptControllerQt.cpp:
- bindings/js/ScriptControllerMac.mm:
- bindings/js/ScriptControllerWin.cpp:
- bindings/js/ScriptControllerWx.cpp:
- bindings/js/ScriptInstance.h:
- bindings/objc/WebScriptObject.mm:
- bridge/Bridge.h:
- bridge/c/c_class.h:
- bridge/c/c_instance.h:
- bridge/c/c_runtime.h:
- bridge/jni/jsc/JNIBridgeJSC.h:
- bridge/jni/jsc/JavaInstanceJSC.h:
- bridge/jsc/BridgeJSC.h:
- bridge/objc/objc_runtime.h:
- bridge/qt/qt_class.h:
- bridge/qt/qt_instance.h:
- bridge/qt/qt_pixmapruntime.h:
- bridge/qt/qt_runtime.h:
- bridge/runtime_array.h:
- bridge/runtime_method.h:
- bridge/runtime_object.h:
- bridge/runtime_root.cpp:
- bridge/testbindings.cpp:
- bridge/testbindings.mm:
- bridge/testqtbindings.cpp:
- page/win/FrameWin.cpp:
- platform/graphics/wince/MediaPlayerProxy.cpp:
- plugins/PluginView.cpp:
- plugins/PluginViewNone.cpp:
- plugins/gtk/PluginViewGtk.cpp:
- plugins/mac/PluginViewMac.mm:
- plugins/qt/PluginViewQt.cpp:
- plugins/symbian/PluginViewSymbian.cpp:
- plugins/win/PluginViewWin.cpp:
2011-02-25 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Bridge.h should not include BridgeJSC.h
https://bugs.webkit.org/show_bug.cgi?id=55212
Include BridgeJSC.h directly instead.
- Plugins/Hosted/ProxyInstance.h:
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
2011-02-25 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Bridge.h should not include BridgeJSC.h
https://bugs.webkit.org/show_bug.cgi?id=55212
Include BridgeJSC.h directly instead.
- Api/qwebframe.cpp:
- 3:35 AM Changeset in webkit [79987] by
-
- 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt
Unreviewed. Changing Chromium expectations for recently added tests.
- chromium/test_expectations.txt
- 2:53 AM Changeset in webkit [79986] by
-
- 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt
Unreviewed. Temporary disabling tests which may affect others.
- chromium/test_expectations.txt
- 2:52 AM Changeset in webkit [79985] by
-
- 25 edits16 adds in trunk
2011-03-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Antti Koivisto.
SVG 1.1 2nd Edition color-prop-05-t.svg exposes bug in 'currentColor' handling
https://bugs.webkit.org/show_bug.cgi?id=54800
Add new layout test from the SVG 1.1 2nd Edition test suite, covering currentColor handling.
Add tests ensuring that mutating a previously shared SVGPaint object makes it unique, so that
mutations take affect, but don't affect other renderers which shared the SVGPaint object before.
- platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.checksum: Added.
- platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
- platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
- platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.checksum: Added.
- platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.png: Added.
- platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.txt: Added.
- platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.checksum: Added.
- platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.png: Added.
- platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.txt: Added.
- svg/W3C-SVG-1.1-SE/color-prop-05-t.svg: Added.
- svg/animations/animate-color-fill-currentColor-expected.txt: Added.
- svg/animations/animate-color-fill-currentColor.html: Added.
- svg/animations/script-tests/animate-color-fill-currentColor.js: Added.
- svg/custom/SVGPaint-mutate-attribute.svg: Added.
- svg/custom/SVGPaint-mutate-inline-style.svg: Added.
- svg/dom/SVGColor-expected.txt: SVGColor mutations now reflected in style/computed style.
- svg/dom/SVGPaint-expected.txt: Same for SVGPaint.
2011-03-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Antti Koivisto.
SVG 1.1 2nd Edition color-prop-05-t.svg exposes bug in 'currentColor' handling
https://bugs.webkit.org/show_bug.cgi?id=54800
Wrong handling of currentColor on inherit
https://bugs.webkit.org/show_bug.cgi?id=38102
Stop storing RefPtr<SVGPaint> objects in the SVGRenderStyle for fill/stroke. These are the last
two objects that held references to CSSValues, they're all gone now, aligning better with RenderStyle.
It's also dangerous, as a SVGPaint object can be shared by multiple SVGRenderStyles (MappedAttribute will
once create a CSSStyleDeclaration for fill="red" and reuse it where possible), and it was easy to
accidently mutate the object, affecting multiple styles. Instead store a Color, an URI and a paint
type in SVGRenderStyle, enough to create a SVGPaint object, if needed (eg for computed styles).
<g color="green"><rect fill="currentColor"/> already worked fine in trunk, but
<g fill="currentColor" color="green"><rect color="red"/> procuded a red rectangle.
In order to fix to bug we have to resolve all currentColor values for SVGPaint objects, in SVGCSSStyleSelector,
as it's already done for SVGColor objects (stop-color, flood-color, etc.) instead of in RenderSVGResource::fill/strokePaintingResource,
when trying to use the paint server. The correct "color" value that should be used from the RenderStyle, is directly
available in CSSStyleSelector: in applyProperty m_style->color() gives the desired value. In CSSStyleSelector it's handled
exactly this way for non-SVG currentColor properties. Also fix computed styles, which did not resolve currentColor for SVGPaint/SVGColor.
A previous patch implemented the SVGPaint/SVGColor API. SVG demands these CSSValues to be mutable. Introduce
CSSMutableValue, which extends CSSValue by a Node pointer, and let SVGPaint/SVGColor inherit from it.
Mutating a SVGPaint/SVGColor object now takes immediate effect, which is reflected in the inline style / computed style.
(Note that getPresentationAttribute() already takes care of removing the CSSValue from the mapped attribute cache, so that it's no longer shared.)
Add several new tests covering the patch.
Tests: svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
svg/animations/animate-color-fill-currentColor.html
svg/custom/SVGPaint-mutate-attribute.svg
svg/custom/SVGPaint-mutate-inline-style.svg
- GNUMakefile.am: Add CSSMutableValue.h
- WebCore.gypi: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- css/CSSMutableStyleDeclaration.cpp: Reset the Node pointer in all CSSMutableValues belonging to this style declaration. (WebCore::CSSMutableStyleDeclaration::~CSSMutableStyleDeclaration):
- css/CSSMutableStyleDeclaration.h: Add destructor.
- css/CSSMutableValue.h: Added. (WebCore::CSSMutableValue::CSSMutableValue): (WebCore::CSSMutableValue::~CSSMutableValue): (WebCore::CSSMutableValue::isMutableValue): (WebCore::CSSMutableValue::node): (WebCore::CSSMutableValue::setNode): (WebCore::CSSMutableValue::setNeedsStyleRecalc):
- css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::getPropertyCSSValue): Set the Node object of a CSSMutableValue to the Node, this style declaration belongs to.
- css/CSSValue.h: (WebCore::CSSValue::isMutableValue): Return false, default.
- css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::adjustSVGPaintForCurrentColor): Add helper function, resolving currentColor values for SVGPaint objects. (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue): Use currentColorOrValidColor/adjustSVGPaintForCurrentColor to resolve SVGColor/SVGPaint values.
- css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty): Store fill/stroke uri, color, paint type seperated in SVGRenderStyle, don't store the full SVGPaint object anymore.
- rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff): Adapt to SVGPaint changes.
- rendering/style/SVGRenderStyle.h: Ditto. (WebCore::SVGRenderStyle::initialFillOpacity): (WebCore::SVGRenderStyle::initialFillPaintType): (WebCore::SVGRenderStyle::initialFillPaintColor): (WebCore::SVGRenderStyle::initialFillPaintUri): (WebCore::SVGRenderStyle::initialStrokeOpacity): (WebCore::SVGRenderStyle::initialStrokePaintType): (WebCore::SVGRenderStyle::initialStrokePaintColor): (WebCore::SVGRenderStyle::initialStrokePaintUri): (WebCore::SVGRenderStyle::initialStrokeMiterLimit): (WebCore::SVGRenderStyle::initialStopOpacity): (WebCore::SVGRenderStyle::initialFloodOpacity): (WebCore::SVGRenderStyle::setFillPaint): (WebCore::SVGRenderStyle::setStrokePaint): (WebCore::SVGRenderStyle::fillPaintType): (WebCore::SVGRenderStyle::fillPaintColor): (WebCore::SVGRenderStyle::fillPaintUri): (WebCore::SVGRenderStyle::strokePaintType): (WebCore::SVGRenderStyle::strokePaintColor): (WebCore::SVGRenderStyle::strokePaintUri): (WebCore::SVGRenderStyle::hasStroke): (WebCore::SVGRenderStyle::hasFill):
- rendering/style/SVGRenderStyleDefs.cpp: Ditto. (WebCore::StyleFillData::StyleFillData): (WebCore::StyleFillData::operator==): (WebCore::StyleStrokeData::StyleStrokeData): (WebCore::StyleStrokeData::operator==):
- rendering/style/SVGRenderStyleDefs.h: Ditto.
- rendering/svg/RenderSVGResource.cpp: Ditto. (WebCore::requestPaintingResource):
- rendering/svg/RenderSVGResourceClipper.cpp: Ditto. (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
- rendering/svg/SVGResources.cpp: Ditto. (WebCore::paintingResourceFromSVGPaint): (WebCore::SVGResources::buildCachedResources):
- svg/SVGColor.cpp: Call setNeedsStyleRecalc() after mutating the object. (WebCore::SVGColor::setRGBColor): (WebCore::SVGColor::setRGBColorICCColor): (WebCore::SVGColor::setColor):
- svg/SVGColor.h:
- svg/SVGPaint.cpp: Ditto. (WebCore::SVGPaint::setUri): (WebCore::SVGPaint::setPaint):
- svg/SVGPaint.h:
- 2:21 AM Changeset in webkit [79984] by
-
- 3 edits in trunk/Source/WebCore
2011-03-01 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [Text editor] Handle decorated lines in the editor
https://bugs.webkit.org/show_bug.cgi?id=55373
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._startEditing): (WebInspector.SourceFrame.prototype._endEditing): (WebInspector.SourceFrame.prototype._createTextViewer):
- inspector/front-end/TextViewer.js: (WebInspector.TextEditorGutterPanel.prototype.textChanged): (WebInspector.TextEditorGutterChunk.prototype.addDecoration): (WebInspector.TextEditorGutterChunk.prototype.removeDecoration): (WebInspector.TextEditorMainPanel.prototype.set readOnly): (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates): (WebInspector.TextEditorMainPanel.prototype._handleDOMSubtreeModified): (WebInspector.TextEditorMainPanel.prototype._markDirtyLines): (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates): (WebInspector.TextEditorMainPanel.prototype._removeDecorationsInRange): (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges): (WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv): (WebInspector.TextEditorMainChunk.prototype.addDecoration): (WebInspector.TextEditorMainChunk.prototype.removeDecoration): (WebInspector.TextEditorMainChunk.prototype.removeAllDecorations): (WebInspector.TextEditorMainChunk.prototype.get decorated):
- 1:31 AM Changeset in webkit [79983] by
-
- 2 edits in trunk/Source/WebCore
2011-03-01 Philippe Normand <pnormand@igalia.com>
Unreviewed GTK build fix after r79978
- GNUmakefile.am:
- 1:29 AM Changeset in webkit [79982] by
-
- 4 edits in trunk
2011-03-01 Andras Becsi <abecsi@webkit.org>
Unreviewed build fix.
[Qt] Fix minimal build.
- Source/WebKit.pri: Move the XP_UNIX define back to WebCore.pri.
2011-03-01 Andras Becsi <abecsi@webkit.org>
Unreviewed build fix.
[Qt] Fix minimal build.
No new tests needed.
- WebCore.pri: Is included in WebKit2.pro, so XP_UNIX can remain here.
- 12:59 AM Changeset in webkit [79981] by
-
- 2 edits in trunk/Source/WebCore
2011-03-01 anthony taranto <anthony.taranto@gmail.com>
Return undefined value from ScriptController::evaluate(), allowing the
caller to distinguish between an error and an undefined return value.
https://bugs.webkit.org/show_bug.cgi?id=51528
- bindings/v8/ScriptController.cpp:
- 12:58 AM Changeset in webkit [79980] by
-
- 2 edits in trunk/LayoutTests
2011-03-01 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: fixing flaky snow XMLViewer test on snow leopard.
- http/tests/xmlviewer/dumpAsText/frames.html:
- 12:56 AM Changeset in webkit [79979] by
-
- 1 edit1 add in trunk/LayoutTests
2011-03-01 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Windows rebaseline. The bug 55451 tracks this rebaseline.
- platform/win/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Added.
- 12:48 AM Changeset in webkit [79978] by
-
- 9 edits2 moves in trunk/Source/WebCore
2011-03-01 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Kent Tamura.
Bug 54853 - Move TextControlInnerElements from WebCore/rendering to WebCore/html/shadow
https://bugs.webkit.org/show_bug.cgi?id=54853
Moving the files from rendering to html/shadow, with the exception of
the class RenderTextControlInnerBlock, which I moved to RenderTextControlSingleLine
(this place is not ideal, but only a temporary state during the larger refactoring
for <input>).
No new tests. (refactoring)
- Android.mk:
- CMakeLists.txt:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/shadow/TextControlInnerElements.cpp: Copied from Source/WebCore/rendering/TextControlInnerElements.cpp.
- html/shadow/TextControlInnerElements.h: Copied from Source/WebCore/rendering/TextControlInnerElements.h.
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlInnerBlock::positionForPoint):
- rendering/RenderTextControlSingleLine.h: (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): (WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):
- rendering/TextControlInnerElements.cpp: Removed.
- rendering/TextControlInnerElements.h: Removed.
- 12:46 AM Changeset in webkit [79977] by
-
- 2 edits in trunk/Source/WebKit/gtk
2011-03-01 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Convert use of cairo_t to RefPtr<cairo_t> in webkitwebiew.cpp
https://bugs.webkit.org/show_bug.cgi?id=55437
- webkit/webkitwebview.cpp: Convert use of cairo_t to RefPtr<cairo_t>. (webkit_web_view_expose_event):
- 12:39 AM Changeset in webkit [79976] by
-
- 7 edits in trunk/Source/WebCore
2011-03-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
applyInlineStyleToPushDown and removeInlineStyleFromElement should take EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55338
Deployed EditingStyle in applyInlineStyleToPushDown and removeInlineStyleFromElement.
Also added a convenience function EditingStyle::setProperty, which lazily instantiates
new CSSMutableStyleDeclaration for m_mutableStyle.
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Takes EditingStyle*. (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Ditto. (WebCore::ApplyStyleCommand::removeCSSStyle): Ditto. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls the above three functions. (WebCore::ApplyStyleCommand::removeInlineStyle): Calls pushDownInlineStyleAroundNode.
- editing/ApplyStyleCommand.h:
- editing/EditingStyle.cpp: (WebCore::HTMLElementEquivalent::addToStyle): Takes EditingStyle*; calls EditingStyle::setProperty. (WebCore::HTMLAttributeEquivalent::addToStyle): Ditto. (WebCore::EditingStyle::setProperty): Added. This member function lazily instantiates new CSSMutableStyleDeclaration for m_mutableStyle. (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Takes EditingStyle*. (WebCore::EditingStyle::conflictsWithImplicitStyleOfElement): Ditto. (WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes): Ditto.
- editing/EditingStyle.h: Added HTMLElementEquivalent and HTMLAttributeEquivalent as friends. (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Ditto.
- editing/InsertTextCommand.cpp: Removed unnecessary includes.
- editing/RemoveCSSPropertyCommand.h: Ditto.
- 12:14 AM Changeset in webkit [79975] by
-
- 3 edits in trunk/Tools
2011-03-01 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: reduce inspector tests flakiness.
https://bugs.webkit.org/show_bug.cgi?id=55401
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest):
- DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset):
- 12:14 AM Changeset in webkit [79974] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-03-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Teach JavaScriptCore GYP build about DEPTH
https://bugs.webkit.org/show_bug.cgi?id=55425
In addition to teaching the JavaScriptCore GYP build about DEPTH, this
change overrides the GCC warning configuration to disable a warning
that's causing probems in Assertions.cpp. With that warning disabled,
JavaScriptCore builds again.
- gyp/JavaScriptCore.gyp:
Feb 28, 2011:
- 11:41 PM Changeset in webkit [79973] by
-
- 3 edits in trunk/Tools
2011-02-28 Mihai Parparita <mihaip@chromium.org>
Reviewed by James Robinson.
NRWT should still upload results when it exits early due to too many failures
https://bugs.webkit.org/show_bug.cgi?id=55432
Only keyboard interrupts should prevent results from being uploaded.
- Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 11:09 PM Changeset in webkit [79972] by
-
- 2 edits in trunk/LayoutTests
2011-02-28 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Adler.
Fix a race condition in editing/selection/4975120
https://bugs.webkit.org/show_bug.cgi?id=55429
If the parser yields between the iframe and the script, it would have been
possible for step2() to be called before runTest() and the test would hang.
- editing/selection/4975120.html:
- 11:07 PM Changeset in webkit [79971] by
-
- 5 edits in trunk/LayoutTests
2011-02-28 Benjamin Kalman <kalman@chromium.org>
Reviewed by Ryosuke Niwa.
Make editing/selection/extend-selection-home-end test match other extend-selection with granularity tests
https://bugs.webkit.org/show_bug.cgi?id=55422
The other extend-selection tests which test a granularity just call into resources/extend-selection.js with the
granularity they're testing. The lineboundary test didn't due to RTL bugs in lineboundary, but these have now
been fixed.
- editing/selection/extend-selection-home-end-expected.txt:
- editing/selection/extend-selection-home-end.html:
- platform/mac/editing/selection/extend-selection-home-end-expected.txt:
- platform/win/editing/selection/extend-selection-home-end-expected.txt:
- 11:06 PM Changeset in webkit [79970] by
-
- 3 edits3 moves1 add in trunk
2011-02-28 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Teach JavaScriptGlue gyp build about DEPTH
https://bugs.webkit.org/show_bug.cgi?id=55421
Moves the previously JavaScriptGlue-specific GYP helper shell scripts
to the gyp directory in Source, where they can be shared by multiple
frameworks.
- Source/gyp: Added.
- Source/gyp/remove-headers-if-needed.sh: Copied from Source/JavaScriptGlue/gyp/remove-headers-if-needed.sh.
- Source/gyp/run-if-exists.sh: Copied from Source/JavaScriptGlue/gyp/run-if-exists.sh.
- Source/gyp/update-info-plist.sh: Copied from Source/JavaScriptGlue/gyp/update-info-plist.sh.
2011-02-28 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig & Darin Adler.
Bug 55423 - Clean up property tables in Structure
Encapsulate, reduce duplication of table search code,
and reduce the size of the tables (remove the index,
just maintain the tables in the correct order).
Shows a 0.5% - 1% progression on sunspider.
- ForwardingHeaders/wtf/HashTable.h: Added.
- 10:26 PM Changeset in webkit [79969] by
-
- 2 edits in trunk/Source/WebCore
2011-02-28 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium rebuilds XMLViewer after noop. Fixed gyp file.
- WebCore.gyp/WebCore.gyp:
- 9:26 PM Changeset in webkit [79968] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 9:12 PM Changeset in webkit [79967] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79948.
http://trac.webkit.org/changeset/79948
https://bugs.webkit.org/show_bug.cgi?id=55439
"caused crashes on the SL release bot" (Requested by ggaren on
#webkit).
- runtime/JSGlobalData.h:
- runtime/WriteBarrier.h:
- 8:40 PM Changeset in webkit [79966] by
-
- 11 edits2 adds in trunk
Source/WebKit2: https://bugs.webkit.org/show_bug.cgi?id=54898
InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle
Reviewed by Adam Roben and Gavin Barraclough.
- WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
(WKBundleHitTestResultCopyNodeHandle):
Instead of .get(), call .release.leakRef() like other functions that return WKBundleNodeHandleRef.
- WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
Renamed from "get" to "copy", because it leaksRef.
Tools: Test for https://bugs.webkit.org/show_bug.cgi?id=54898
InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle.
Reviewed by Adam Roben and Gavin Barraclough.
- TestWebKitAPI/InjectedBundleController.h:
(TestWebKitAPI::InjectedBundleController::bundle):
- TestWebKitAPI/PlatformWebView.h:
- TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Added.
(TestWebKitAPI::HitTestResultNodeHandleTest::HitTestResultNodeHandleTest):
(TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
(TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
- TestWebKitAPI/mac/PlatformWebViewMac.mm:
(TestWebKitAPI::PlatformWebView::simulateRightClick):
- TestWebKitAPI/win/PlatformWebViewWin.cpp:
(TestWebKitAPI::PlatformWebView::simulateRightClick):
Added files to:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/win/TestWebKitAPI.vcproj:
- TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
- 8:27 PM Changeset in webkit [79965] by
-
- 2 edits in trunk/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=55442
Webarchives don't contain subframe content
Reviewed by Gavin Barraclough.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getWebArchiveOfFrame):
Pass the frame's document instead of just the frame, to use a different LegacyWebArchive::create function.
- 7:59 PM Changeset in webkit [79964] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 7:53 PM Changeset in webkit [79963] by
-
- 6 edits1 add in trunk/Source
Bug 55423 - Clean up property tables in Structure
Reviewed by Sam Weinig & Darin Adler.
Encapsulate, reduce duplication of table search code,
and reduce the size of the tables (remove the index,
just maintain the tables in the correct order).
Shows a 0.5% - 1% progression on sunspider.
- JavaScriptCore.exp:
- runtime/PropertyMapHashTable.h:
(JSC::isPowerOf2):
(JSC::nextPowerOf2):
bit ops used to calculate table size.
(JSC::PropertyMapEntry::PropertyMapEntry):
(JSC::PropertyTable::ordered_iterator::operator++):
(JSC::PropertyTable::ordered_iterator::operator==):
(JSC::PropertyTable::ordered_iterator::operator!=):
(JSC::PropertyTable::ordered_iterator::operator*):
(JSC::PropertyTable::ordered_iterator::operator->):
(JSC::PropertyTable::ordered_iterator::ordered_iterator):
implementation of the iterator types
(JSC::PropertyTable::PropertyTable):
(JSC::PropertyTable::~PropertyTable):
constructors take an initial capacity for the table,
a table to copy, or both.
(JSC::PropertyTable::begin):
(JSC::PropertyTable::end):
create in-order iterators.
(JSC::PropertyTable::find):
search the hash table
(JSC::PropertyTable::add):
add a value to the hash table
(JSC::PropertyTable::remove):
remove a value from the hash table
(JSC::PropertyTable::size):
(JSC::PropertyTable::isEmpty):
accessors.
(JSC::PropertyTable::propertyStorageSize):
(JSC::PropertyTable::clearDeletedOffsets):
(JSC::PropertyTable::hasDeletedOffset):
(JSC::PropertyTable::getDeletedOffset):
(JSC::PropertyTable::addDeletedOffset):
cache deleted (available) offsets in the property storage array.
(JSC::PropertyTable::copy):
take a copy of the PropertyTable, potentially expanding the capacity.
(JSC::PropertyTable::sizeInMemory):
used for DEBUG build statistics
(JSC::PropertyTable::reinsert):
(JSC::PropertyTable::rehash):
(JSC::PropertyTable::tableCapacity):
(JSC::PropertyTable::deletedEntryIndex):
(JSC::PropertyTable::skipDeletedEntries):
(JSC::PropertyTable::table):
(JSC::PropertyTable::usedCount):
(JSC::PropertyTable::dataSize):
(JSC::PropertyTable::sizeForCapacity):
(JSC::PropertyTable::canInsert):
these methods provide internal implementation.
- runtime/Structure.cpp:
(JSC::Structure::dumpStatistics):
(JSC::Structure::~Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::despecifyAllFunctions):
(JSC::Structure::put):
(JSC::Structure::remove):
(JSC::Structure::createPropertyMap):
(JSC::Structure::getPropertyNames):
(JSC::PropertyTable::checkConsistency):
(JSC::Structure::checkConsistency):
factored out code to PropertyMapHashTable.h
- runtime/Structure.h:
(JSC::Structure::propertyStorageSize):
(JSC::Structure::isEmpty):
(JSC::Structure::get):
factored out code to PropertyMapHashTable.h
../JavaScriptGlue:
- ForwardingHeaders/wtf/HashTable.h: Added.
- 7:42 PM Changeset in webkit [79962] by
-
- 4 edits in trunk/LayoutTests
2011-02-28 James Robinson <jamesr@chromium.org>
Chromium baseline updates.
- platform/chromium-linux/svg/text/font-size-below-point-five-expected.txt:
- platform/chromium/test_expectations.txt:
- platform/mac-leopard/svg/text/font-size-below-point-five-expected.txt:
- 7:21 PM Changeset in webkit [79961] by
-
- 1 edit28 adds in trunk/LayoutTests
2011-02-28 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations change.
Rebaseline editing/ tests for Snow Leopard (mac/ baselines can't be used
due to spell checking differences).
- platform/chromium-mac-leopard/editing/deleting/delete-ws-fixup-002-expected.checksum: Added.
- platform/chromium-mac-leopard/editing/deleting/delete-ws-fixup-002-expected.png: Added.
- platform/chromium-mac-leopard/editing/inserting/typing-around-br-001-expected.checksum: Added.
- platform/chromium-mac-leopard/editing/inserting/typing-around-br-001-expected.png: Added.
- platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-3-expected.checksum: Added.
- platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-3-expected.png: Added.
- platform/chromium-mac-leopard/editing/selection/4932260-3-expected.checksum: Added.
- platform/chromium-mac-leopard/editing/selection/4932260-3-expected.png: Added.
- platform/chromium-mac-leopard/editing/selection/5234383-1-expected.checksum: Added.
- platform/chromium-mac-leopard/editing/selection/5234383-1-expected.png: Added.
- platform/chromium-mac-leopard/editing/selection/5234383-2-expected.checksum: Added.
- platform/chromium-mac-leopard/editing/selection/5234383-2-expected.png: Added.
- platform/chromium-mac-leopard/editing/selection/drag-in-iframe-expected.checksum: Added.
- platform/chromium-mac-leopard/editing/selection/drag-in-iframe-expected.png: Added.
- platform/chromium-mac/editing/deleting/delete-ws-fixup-002-expected.checksum: Added.
- platform/chromium-mac/editing/deleting/delete-ws-fixup-002-expected.png: Added.
- platform/chromium-mac/editing/inserting/typing-around-br-001-expected.checksum: Added.
- platform/chromium-mac/editing/inserting/typing-around-br-001-expected.png: Added.
- platform/chromium-mac/editing/pasteboard/paste-blockquote-3-expected.checksum: Added.
- platform/chromium-mac/editing/pasteboard/paste-blockquote-3-expected.png: Added.
- platform/chromium-mac/editing/selection/4932260-3-expected.checksum: Added.
- platform/chromium-mac/editing/selection/4932260-3-expected.png: Added.
- platform/chromium-mac/editing/selection/5234383-1-expected.checksum: Added.
- platform/chromium-mac/editing/selection/5234383-1-expected.png: Added.
- platform/chromium-mac/editing/selection/5234383-2-expected.checksum: Added.
- platform/chromium-mac/editing/selection/5234383-2-expected.png: Added.
- platform/chromium-mac/editing/selection/drag-in-iframe-expected.checksum: Added.
- platform/chromium-mac/editing/selection/drag-in-iframe-expected.png: Added.
- 6:34 PM Changeset in webkit [79960] by
-
- 2 edits in trunk/LayoutTests
2011-02-28 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations change.
Update Snow Leopard expectations.
- platform/chromium/test_expectations.txt:
- 6:30 PM Changeset in webkit [79959] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-28 Xan Lopez <xlopez@igalia.com>
Another fix build :(
Fix typo.
- runtime/MachineStackMarker.cpp: (JSC::freePlatformThreadRegisters):
- 6:26 PM Changeset in webkit [79958] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-28 Xan Lopez <xlopez@igalia.com>
Unreviewed build fix for Snow Leopard.
- runtime/MachineStackMarker.cpp: (JSC::freePlatformThreadRegisters):
- 6:20 PM Changeset in webkit [79957] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-28 Alejandro G. Castro <alex@igalia.com>
Unreviewed, fix SnowLeopard compilation after r79952.
- runtime/MachineStackMarker.cpp: (JSC::freePlatformThreadRegisters):
- 6:10 PM Changeset in webkit [79956] by
-
- 4 edits in trunk/Source/WebCore
KURL should expose a referrer property.
https://bugs.webkit.org/show_bug.cgi?id=55415
Reviewed by Darin Adler.
No change in functionality so no new tests.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::setOutgoingReferrer): Refactor to put the majority
of functionality in KURL::strippedForUseAsReferrer() so that this code can
be more easily reused.
- platform/KURL.cpp:
(WebCore::KURL::strippedForUseAsReferrer): Converts the url to a string
which is suitable for use as a referrer.
- platform/KURL.h:
- 5:55 PM Changeset in webkit [79955] by
-
- 2 edits in trunk/Source/JavaScriptCore
<http://webkit.org/b/55430> OwnArrayPtr.h's LOOSE_OWN_ARRAY_PTR results in link errors.
Reviewed by Darin Adler.
- wtf/OwnArrayPtr.h:
(WTF::::set): Implement OwnArrayPtr::set.
- 5:51 PM Changeset in webkit [79954] by
-
- 7 edits in trunk
Number type input cannot be set to empty string if it has an initial value
https://bugs.webkit.org/show_bug.cgi?id=53744
Reviewed by Darin Adler.
Source/WebCore:
We need to distinguish null strings and empty strings for
InputElementData::value. So InputType::sanitizeValue() also needs to
take care of it.
- dom/InputElement.h: Add a comment to InputElementData::value and setValue about null strings.
- html/InputType.h: Add a comment to sanitizeValue about null strings.
- html/NumberInputType.cpp:
(WebCore::NumberInputType::sanitizeValue): Returns a null string if the
proposed value is a null string. Returning an empty string if the
proposed value is not a number.
LayoutTests:
- fast/forms/input-value-sanitization-expected.txt:
- fast/forms/script-tests/input-value-sanitization.js: Add some tests.
- 5:47 PM Changeset in webkit [79953] by
-
- 50 edits in trunk
2011-02-28 Chang Shu <cshu@webkit.org>
Reviewed by Ryosuke Niwa.
Remove the support of Frame::isContentEditable and its dependencies.
https://bugs.webkit.org/show_bug.cgi?id=54292
Updated expected results after the change that syncs the WebKit isEditable
and WebCore isContentEditable.
- platform/mac/editing/selection/designmode-no-caret-expected.txt:
2011-02-28 Chang Shu <cshu@webkit.org>
Reviewed by Ryosuke Niwa.
Remove the support of Frame::isContentEditable and its dependencies.
https://bugs.webkit.org/show_bug.cgi?id=54292
Frame::isContentEditable is currently based on two things: Editor::clientIsEditable and
Document::inDesignMode. In fact, it should only rely on Document::inDesignMode. As a result,
Editor::clientIsEditable and its client-side implementation can be removed.
- WebCore.exp.in:
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isReadOnly):
- editing/Editor.cpp:
- editing/Editor.h:
- editing/SelectionController.cpp: (WebCore::SelectionController::setSelectionFromNone):
- html/HTMLElement.cpp: (WebCore::HTMLElement::isContentEditable): (WebCore::HTMLElement::isContentRichlyEditable):
- page/DragController.cpp: (WebCore::DragController::operationForLoad):
- page/EditorClient.h:
- page/Frame.cpp:
- page/Frame.h:
2011-02-28 Chang Shu <cshu@webkit.org>
Reviewed by Ryosuke Niwa.
Remove the support of Frame::isContentEditable and its dependencies.
https://bugs.webkit.org/show_bug.cgi?id=54292
Remove the WebKit side implementation.
- src/EditorClientImpl.cpp:
- src/EditorClientImpl.h:
2011-02-28 Chang Shu <cshu@webkit.org>
Reviewed by Ryosuke Niwa.
Remove the support of Frame::isContentEditable and its dependencies.
https://bugs.webkit.org/show_bug.cgi?id=54292
Remove the WebKit side implementation.
- WebCoreSupport/EditorClientEfl.cpp:
- WebCoreSupport/EditorClientEfl.h:
2011-02-28 Chang Shu <cshu@webkit.org>
Reviewed by Ryosuke Niwa.
Remove the support of Frame::isContentEditable and its dependencies.
https://bugs.webkit.org/show_bug.cgi?id=54292
Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
- WebCoreSupport/EditorClientGtk.cpp:
- WebCoreSupport/EditorClientGtk.h:
- webkit/webkitwebview.cpp: (webkit_web_view_init): (webkit_web_view_get_editable): (webkit_web_view_set_editable):
- webkit/webkitwebviewprivate.h:
2011-02-28 Chang Shu <cshu@webkit.org>
Reviewed by Ryosuke Niwa.
Remove the support of Frame::isContentEditable and its dependencies.
https://bugs.webkit.org/show_bug.cgi?id=54292
Remove the WebKit side implementation.
- WebCoreSupport/EditorClientHaiku.cpp:
- WebCoreSupport/EditorClientHaiku.h:
2011-02-28 Chang Shu <cshu@webkit.org>
Reviewed by Ryosuke Niwa.
Remove the support of Frame::isContentEditable and its dependencies.
https://bugs.webkit.org/show_bug.cgi?id=54292
Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm:
- WebView/WebView.mm: (-[WebView setEditable:]): (-[WebView isEditable]):
- WebView/WebViewData.h:
2011-02-28 Chang Shu <cshu@webkit.org>
Reviewed by Ryosuke Niwa.
Remove the support of Frame::isContentEditable and its dependencies.
https://bugs.webkit.org/show_bug.cgi?id=54292
Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
- Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): (QWebPage::setContentEditable): (QWebPage::isContentEditable):
- Api/qwebpage_p.h:
- WebCoreSupport/EditorClientQt.cpp:
- WebCoreSupport/EditorClientQt.h:
2011-02-28 Chang Shu <cshu@webkit.org>
Reviewed by Ryosuke Niwa.
Remove the support of Frame::isContentEditable and its dependencies.
https://bugs.webkit.org/show_bug.cgi?id=54292
Remove the WebKit side implementation.
- WebCoreSupport/WebEditorClient.cpp:
- WebCoreSupport/WebEditorClient.h:
2011-02-28 Chang Shu <cshu@webkit.org>
Reviewed by Ryosuke Niwa.
Remove the support of Frame::isContentEditable and its dependencies.
https://bugs.webkit.org/show_bug.cgi?id=54292
Remove the WebKit side implementation.
- WebCoreSupport/EditorClientWinCE.cpp:
- WebCoreSupport/EditorClientWinCE.h:
2011-02-28 Chang Shu <cshu@webkit.org>
Reviewed by Ryosuke Niwa.
Remove the support of Frame::isContentEditable and its dependencies.
https://bugs.webkit.org/show_bug.cgi?id=54292
Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
- WebFrame.cpp: (wxWebFrame::wxWebFrame): (wxWebFrame::MakeEditable): (wxWebFrame::IsEditable):
- WebFrame.h:
- WebKitSupport/EditorClientWx.cpp:
- WebKitSupport/EditorClientWx.h:
- WebView.cpp: (wxWebView::wxWebView):
- WebView.h:
- 5:45 PM Changeset in webkit [79952] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-02-28 Martin Zoubek <martin.zoubek@acision.com> and Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
Multithread support for JSC on UNIX
https://bugs.webkit.org/show_bug.cgi?id=26838
Implement suspendThread() and resumeThread() for systems with
pthread.h using thread signal handler.
- runtime/MachineStackMarker.cpp: (JSC::pthreadSignalHandlerSuspendResume): (JSC::MachineStackMarker::Thread::Thread): (JSC::getCurrentPlatformThread): (JSC::suspendThread): (JSC::resumeThread): (JSC::getPlatformThreadRegisters): (JSC::otherThreadStackPointer): (JSC::freePlatformThreadRegisters): (JSC::MachineStackMarker::markOtherThreadConservatively):
- wtf/Platform.h: Added Gtk port to use ENABLE_JSC_MULTIPLE_THREADS.
- 5:40 PM Changeset in webkit [79951] by
-
- 5 edits in trunk
Number type input should not handle mouse wheel events if it has no focus.
https://bugs.webkit.org/show_bug.cgi?id=53638
Reviewed by Darin Adler.
Source/WebCore:
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleWheelEventForSpinButton): Check focused().
LayoutTests:
Add a test case.
- fast/forms/input-number-wheel-expected.txt:
- fast/forms/script-tests/input-number-wheel.js:
- 5:33 PM Changeset in webkit [79950] by
-
- 2 edits in trunk/Source/WebCore
2011-02-28 Noel Gordon <noel.gordon@gmail.com>
Reviewed by James Robinson.
[chromium] GradientSkia: use the common Gradient stop sorting methods.
https://bugs.webkit.org/show_bug.cgi?id=54625
Remove a FIXME: call the Gradient.cpp stop storting routines, no need
to duplicate that code herein.
No change in behavior, so no new tests.
- platform/graphics/skia/GradientSkia.cpp: (WebCore::Gradient::platformGradient):
- 5:31 PM Changeset in webkit [79949] by
-
- 6 edits in trunk/LayoutTests
2011-02-28 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Adler.
Fix race condition in 4 media tests
https://bugs.webkit.org/show_bug.cgi?id=55414
The parser may yield and give events a chance to dispatch between any two tokens. So
it is possible that the loadstart event fires immediately after the video tag is
inserted into the document but before the subsequent script is parsed. This is very
rare in the layout test environment since these small files are loaded from disk.
This patch eliminates that race condition by allowing waitForEvent to register for
events that bubble up to the document from any element. Then the registration can
happen before before the element is inserted into the document.
- media/video-source-media.html:
- media/video-source-none-supported.html:
- media/video-source-type-params.html:
- media/video-source-type.html:
- media/video-test.js: (waitForEvent): (waitForEventAndTest):
- 5:06 PM Changeset in webkit [79948] by
-
- 3 edits in trunk/Source/JavaScriptCore
2011-02-28 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
Stop using DeprecatedPtr for the global exception slot
https://bugs.webkit.org/show_bug.cgi?id=55424
Create GCRootPtr to signify that the exception slot is
a gcroot, and so is exempt from the usual writebarrier
restrictions.
- runtime/JSGlobalData.h:
- runtime/WriteBarrier.h: (JSC::GCRootPtr::GCRootPtr): (JSC::GCRootPtr::operator=):
- 5:02 PM Changeset in webkit [79947] by
-
- 7 edits in trunk/Source/WebCore
2011-02-28 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
JNI code should include <jni.h> on non-OSX platforms.
https://bugs.webkit.org/show_bug.cgi?id=55219
On Mac we need to include <JavaVM/jni.h> as this is a framework
include. We include jni.h through JNIUtility.h to minimize the
number of ifdefs.
No new tests, build fix only.
- WebCore.xcodeproj/project.pbxproj
- bridge/jni/JNIUtility.h:
- bridge/jni/jni_jsobject.h:
- bridge/jni/jsc/JNIBridgeJSC.h:
- bridge/jni/jsc/JavaInstanceJSC.h:
- bridge/jni/v8/JavaInstanceV8.h:
- 4:59 PM Changeset in webkit [79946] by
-
- 2 edits in trunk/Source/WebCore
2011-02-28 Nebojsa Sabovic <neb@chromium.org>
Reviewed by James Robinson.
[chromium] Pepper plugins render upside down
https://bugs.webkit.org/show_bug.cgi?id=55101
No layout tests for pepper plugins (yet).
- platform/graphics/chromium/PluginLayerChromium.h:
- 4:57 PM Changeset in webkit [79945] by
-
- 4 edits9 adds in trunk
2011-02-28 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Add a way to test the WebKit 2 APIs
https://bugs.webkit.org/show_bug.cgi?id=55408
Add the build file for test to the build system.
- Source/WebKit.pri: Add the include path for WebKit 2 APIs.
- Source/WebKit.pro: Add the dependency to build the new test project.
2011-02-28 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Add a way to test the WebKit 2 APIs
https://bugs.webkit.org/show_bug.cgi?id=55408
Add an initial test for the WebKit 2 APIs of Qt.
- UIProcess/API/qt/tests/html/basic_page.html: Added.
- UIProcess/API/qt/tests/qgraphicswkview/qgraphicswkview.pro: Added.
- UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp: Added. (View::View): (View::resizeEvent): (tst_QGraphicsWKView::init): (tst_QGraphicsWKView::cleanup): (tst_QGraphicsWKView::loadEmptyPage):
- UIProcess/API/qt/tests/tests.pri: Added.
- UIProcess/API/qt/tests/tests.pro: Added.
- UIProcess/API/qt/tests/util.h: Added. (waitForSignal):
- 4:54 PM Changeset in webkit [79944] by
-
- 4 edits3 adds in trunk
2011-02-28 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Follow HTML5 spec for document.open() a little more closely
https://bugs.webkit.org/show_bug.cgi?id=55392
- fast/parser/double-write-from-closed-iframe-expected.txt: Added.
- fast/parser/double-write-from-closed-iframe.html: Added. Prior to this patch, the second write of 'PASS' could fail indeterminately.
- fast/parser/script-tests/double-write-from-closed-iframe.js: Added.
- fast/regex/script-tests/cross-frame-callable.js: Necessary to close late writes.
2011-02-28 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Follow HTML5 spec for document.open() a little more closely
https://bugs.webkit.org/show_bug.cgi?id=55392
See: 3.5.1.4 at http://www.whatwg.org/specs/web-apps/current-work/#dom-document-open.
The second return check matches the spec. The first return check (isExecutingScript())
was left in place because without it, fast/tokenizer/write-external-script-open.html
would fail. It also possible there is a spec bug because FF4 crashes on that test and
IE9 prints "FAILURE." The isLoadingMainResource() check was removed because the main
resource is always loading while parser->isParsing().
Test: fast/parser/double-write-from-closed-iframe.html
- dom/Document.cpp: (WebCore::Document::open):
- 4:54 PM Changeset in webkit [79943] by
-
- 6 edits in trunk/Source/WebKit2
Fix clang build.
- UIProcess/API/mac/FindIndicatorWindow.mm:
- UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
(WebKit::ChunkedUpdateDrawingAreaProxy::deprecatedUpdate):
(WebKit::ChunkedUpdateDrawingAreaProxy::didReceiveMessage):
- UIProcess/ChunkedUpdateDrawingAreaProxy.h:
- WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
(WebKit::ChunkedUpdateDrawingArea::deprecatedResumePainting):
(WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):
- WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
- 4:51 PM Changeset in webkit [79942] by
-
- 6 edits in trunk/Source
2011-02-28 Avi Drissman <avi@google.com>
Reviewed by James Robinson.
WebCursorInfo needs to match enums in platform/Cursor.h
https://bugs.webkit.org/show_bug.cgi?id=55094
- platform/chromium/CursorChromium.cpp: (WebCore::grabCursor): (WebCore::grabbingCursor):
- platform/chromium/PlatformCursor.h:
2011-02-28 Avi Drissman <avi@google.com>
Reviewed by James Robinson.
WebCursorInfo needs to match enums in platform/Cursor.h
https://bugs.webkit.org/show_bug.cgi?id=55094
- public/WebCursorInfo.h:
- src/AssertMatchingEnums.cpp:
- 4:49 PM Changeset in webkit [79941] by
-
- 3 edits80 adds in trunk/LayoutTests
2011-02-28 James Robinson <jamesr@chromium.org>
Update chromium expectations and baselines.
- platform/chromium-linux/fast/block/positioning/auto/vertical-lr/001-expected.checksum: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-lr/001-expected.png: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-lr/002-expected.checksum: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-lr/002-expected.png: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-lr/003-expected.checksum: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-lr/003-expected.png: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-lr/004-expected.checksum: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-lr/004-expected.png: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-lr/005-expected.checksum: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-lr/005-expected.png: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-lr/006-expected.checksum: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-lr/006-expected.png: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-lr/007-expected.checksum: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-rl/001-expected.checksum: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-rl/001-expected.png: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-rl/002-expected.checksum: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-rl/002-expected.png: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-rl/003-expected.checksum: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-rl/003-expected.png: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-rl/004-expected.checksum: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-rl/004-expected.png: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-rl/005-expected.checksum: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-rl/005-expected.png: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-rl/006-expected.checksum: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-rl/006-expected.png: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-rl/007-expected.checksum: Added.
- platform/chromium-linux/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
- platform/chromium-linux/fast/forms/select-listbox-multiple-no-focusring-expected.checksum: Added.
- platform/chromium-linux/fast/forms/select-listbox-multiple-no-focusring-expected.png: Added.
- platform/chromium-linux/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-lr/001-expected.checksum: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-lr/001-expected.png: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-lr/001-expected.txt: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-lr/002-expected.checksum: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-lr/002-expected.png: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-lr/002-expected.txt: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-lr/003-expected.checksum: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-lr/003-expected.png: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-lr/003-expected.txt: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-lr/004-expected.checksum: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-lr/004-expected.png: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-lr/004-expected.txt: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-lr/005-expected.checksum: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-lr/005-expected.png: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-lr/005-expected.txt: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-lr/006-expected.checksum: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-lr/006-expected.png: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-lr/006-expected.txt: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-lr/007-expected.checksum: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-lr/007-expected.txt: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-rl/001-expected.checksum: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-rl/001-expected.png: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-rl/001-expected.txt: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-rl/002-expected.checksum: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-rl/002-expected.png: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-rl/002-expected.txt: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-rl/003-expected.checksum: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-rl/003-expected.png: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-rl/003-expected.txt: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-rl/004-expected.checksum: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-rl/004-expected.png: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-rl/004-expected.txt: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-rl/005-expected.checksum: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-rl/005-expected.png: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-rl/005-expected.txt: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-rl/006-expected.checksum: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-rl/006-expected.png: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-rl/006-expected.txt: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-rl/007-expected.checksum: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
- platform/chromium-win/fast/block/positioning/auto/vertical-rl/007-expected.txt: Added.
- platform/chromium-win/fast/forms/select-listbox-multiple-no-focusring-expected.checksum: Added.
- platform/chromium-win/fast/forms/select-listbox-multiple-no-focusring-expected.png: Added.
- platform/chromium-win/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Added.
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- platform/chromium/test_expectations.txt:
- 4:02 PM Changeset in webkit [79940] by
-
- 2 edits in trunk/Source/WebKit2
Do not copy config.h into WebKit2.
Rubber-stamped by Anders Carlsson.
- WebKit2.xcodeproj/project.pbxproj:
- 3:59 PM Changeset in webkit [79939] by
-
- 3 edits in trunk/Source/WebKit2
LLVM Compiler build fix.
- Scripts/webkit2/messages.py:
- UIProcess/WebPageProxy.h:
- 3:59 PM Changeset in webkit [79938] by
-
- 6 edits1 copy6 adds in trunk
Start running InjectedBundle API tests on Windows
A new project, TestWebKitAPIInjectedBundle, builds the injected bundle DLL.
Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows
Reviewed by Darin Adler.
Source/WebKit/win:
Build TestWebKitAPIInjectedBundle on Windows
- WebKit.vcproj/WebKit.sln: Added TestWebKitAPIInjectedBundle. Let VS simplify the paths to
the project files.
Tools:
- TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added.
- TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added.
- TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added.
- TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added.
- TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added.
These are just extracted from TestWebKitAPI.vcproj.
- TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added. Just sets
up the DLL's filename.
- TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Fixed DLL name.
(TestWebKitAPI::Util::createInjectedBundlePath): Changed to use kCFAllocatorNull instead of
0 (== kCFAllocatorDefault) so that CF won't try to deallocate our C string.
- TestWebKitAPI/win/TestWebKitAPI.sln: Added TestWebKitAPIInjectedBundle. Removed the bogus
"all" configuration.
- TestWebKitAPI/win/TestWebKitAPI.vcproj: Changed to use the new .vsprops files. Added
injected bundle tests. Let VS resort things.
- TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Copied from Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj.
- 3:55 PM Changeset in webkit [79937] by
-
- 3 edits in trunk/Source/WebKit2
2011-02-28 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein, Sam Weinig, Alexey Proskuryakov and Darin Adler.
Open PDF in Preview doesn't work
https://bugs.webkit.org/show_bug.cgi?id=55400
<rdar://problem/8750353>
- UIProcess/API/mac/PDFViewController.mm: (-[WKPDFView initWithFrame:PDFViewController:]): Set the WKPDFView as the delegate of itself.
(-[WKPDFView PDFViewOpenPDFInNativeApplication:]):
Call PDFViewController::openPDFInFinder.
(WebKit::PDFViewController::PDFViewController):
Initialize m_hasWrittenPDFToDisk to false.
(WebKit::PDFViewController::openPDFInFinder):
Write the PDF to disk if needed and then open it using -[NSWorkspace openFile:].
(WebKit::temporaryPDFDirectoryPath):
Create a directory to put PDFs in.
(WebKit::PDFViewController::pathToPDFOnDisk):
Return a path to a (non-existent) file in the temporary PDF directory.
- 3:50 PM Changeset in webkit [79936] by
-
- 3 edits in trunk/Source/WebCore
2011-02-28 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
[Mac] Make "Change back to …" contextual menu item work with new autocorrection.
https://bugs.webkit.org/show_bug.cgi?id=55396
<rdar://problem/8836093>
The change in InlineTextBox.cpp fixes a bug, where the rectangle of Replacement marker isn't
calculated. We need this to do hit test when deciding whether to show "Change back to ..." on
contextual menu.
The change in Editor.cpp is for notifying spellchecker about the reversion whenever "Change
back to ..." is clicked.
- editing/Editor.cpp: (WebCore::Editor::changeBackToReplacedString):
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintDocumentMarkers):
- 3:35 PM Changeset in webkit [79935] by
-
- 2 edits in trunk/Source/WebCore
2011-02-28 Victoria Kirst <vrk@google.com>
Reviewed by Kenneth Russell.
[chromium] Fall back to texSubImage2D when mapTexSubImage2D fails in VideoLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=55269
Mesa does not support mapTexSubImage2D, so this change lets
GPU-accelerated video work with DRT layout tests.
- platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::updateTexture):
- 3:33 PM Changeset in webkit [79934] by
-
- 1 edit5 adds in trunk/LayoutTests
2011-02-28 Chang Shu <cshu@webkit.org>
Reviewed by Antonio Gomes.
REGRESSION (r79762): Items in <select multiple> have focus rings, but shouldn't
https://bugs.webkit.org/show_bug.cgi?id=55323
Added test case that draws focus rings on selected items when spatial navigation is enabled.
- fast/spatial-navigation/snav-multiple-select-focusring.html: Added.
- platform/mac/fast/spatial-navigation: Added.
- platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.checksum: Added.
- platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.png: Added.
- platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt: Added.
- 3:32 PM Changeset in webkit [79933] by
-
- 1 edit2 copies in branches/chromium/648
Merge 78728
BUG=72340
Review URL: http://codereview.chromium.org/6594060
- 3:27 PM Changeset in webkit [79932] by
-
- 4 edits2 copies in branches/chromium/648
Merge 77702
BUG=72340
Review URL: http://codereview.chromium.org/6597055
- 3:24 PM Changeset in webkit [79931] by
-
- 1 edit2 copies in branches/chromium/648
Merge 77273
BUG=72340
Review URL: http://codereview.chromium.org/6592050
- 3:21 PM Changeset in webkit [79930] by
-
- 12 edits60 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text. Change staticX and staticY
to be staticInlinePosition and staticBlockPosition. Patch all of the computations involving these variables to be writing
mode aware. Mixed writing modes are not yet supported.
Reviewed by Dan Bernstein.
Added new tests in fast/block/positioning/auto.
Source/WebCore:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::layoutPositionedObjects):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::startOffsetForLine):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::appendRunsForObject):
(WebCore::setStaticPositions):
(WebCore::RenderBlock::skipTrailingWhitespace):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::findNextLineBreak):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::positionLineBox):
(WebCore::computeInlineStaticDistance):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::computeBlockStaticDistance):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::borderAndPaddingLogicalLeft):
(WebCore::RenderBoxModelObject::borderAndPaddingStart):
(WebCore::RenderBoxModelObject::borderLogicalLeft):
(WebCore::RenderBoxModelObject::borderLogicalRight):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::relativePositionedInlineOffset):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
- rendering/RenderLayer.h:
(WebCore::RenderLayer::staticInlinePosition):
(WebCore::RenderLayer::staticBlockPosition):
(WebCore::RenderLayer::setStaticInlinePosition):
(WebCore::RenderLayer::setStaticBlockPosition):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::hasAutoLeftAndRight):
(WebCore::InheritedFlags::hasAutoTopAndBottom):
(WebCore::InheritedFlags::hasStaticInlinePosition):
(WebCore::InheritedFlags::hasStaticBlockPosition):
LayoutTests:
- fast/block/positioning/auto/vertical-lr: Added.
- fast/block/positioning/auto/vertical-lr/001.html: Added.
- fast/block/positioning/auto/vertical-lr/002.html: Added.
- fast/block/positioning/auto/vertical-lr/003.html: Added.
- fast/block/positioning/auto/vertical-lr/004.html: Added.
- fast/block/positioning/auto/vertical-lr/005.html: Added.
- fast/block/positioning/auto/vertical-lr/006.html: Added.
- fast/block/positioning/auto/vertical-lr/007.html: Added.
- fast/block/positioning/auto/vertical-rl: Added.
- fast/block/positioning/auto/vertical-rl/001.html: Added.
- fast/block/positioning/auto/vertical-rl/002.html: Added.
- fast/block/positioning/auto/vertical-rl/003.html: Added.
- fast/block/positioning/auto/vertical-rl/004.html: Added.
- fast/block/positioning/auto/vertical-rl/005.html: Added.
- fast/block/positioning/auto/vertical-rl/006.html: Added.
- fast/block/positioning/auto/vertical-rl/007.html: Added.
- platform/mac/fast/block/positioning/auto/vertical-lr: Added.
- platform/mac/fast/block/positioning/auto/vertical-lr/001-expected.checksum: Added.
- platform/mac/fast/block/positioning/auto/vertical-lr/001-expected.png: Added.
- platform/mac/fast/block/positioning/auto/vertical-lr/001-expected.txt: Added.
- platform/mac/fast/block/positioning/auto/vertical-lr/002-expected.checksum: Added.
- platform/mac/fast/block/positioning/auto/vertical-lr/002-expected.png: Added.
- platform/mac/fast/block/positioning/auto/vertical-lr/002-expected.txt: Added.
- platform/mac/fast/block/positioning/auto/vertical-lr/003-expected.checksum: Added.
- platform/mac/fast/block/positioning/auto/vertical-lr/003-expected.png: Added.
- platform/mac/fast/block/positioning/auto/vertical-lr/003-expected.txt: Added.
- platform/mac/fast/block/positioning/auto/vertical-lr/004-expected.checksum: Added.
- platform/mac/fast/block/positioning/auto/vertical-lr/004-expected.png: Added.
- platform/mac/fast/block/positioning/auto/vertical-lr/004-expected.txt: Added.
- platform/mac/fast/block/positioning/auto/vertical-lr/005-expected.checksum: Added.
- platform/mac/fast/block/positioning/auto/vertical-lr/005-expected.png: Added.
- platform/mac/fast/block/positioning/auto/vertical-lr/005-expected.txt: Added.
- platform/mac/fast/block/positioning/auto/vertical-lr/006-expected.checksum: Added.
- platform/mac/fast/block/positioning/auto/vertical-lr/006-expected.png: Added.
- platform/mac/fast/block/positioning/auto/vertical-lr/006-expected.txt: Added.
- platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.checksum: Added.
- platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
- platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.txt: Added.
- platform/mac/fast/block/positioning/auto/vertical-rl: Added.
- platform/mac/fast/block/positioning/auto/vertical-rl/001-expected.checksum: Added.
- platform/mac/fast/block/positioning/auto/vertical-rl/001-expected.png: Added.
- platform/mac/fast/block/positioning/auto/vertical-rl/001-expected.txt: Added.
- platform/mac/fast/block/positioning/auto/vertical-rl/002-expected.checksum: Added.
- platform/mac/fast/block/positioning/auto/vertical-rl/002-expected.png: Added.
- platform/mac/fast/block/positioning/auto/vertical-rl/002-expected.txt: Added.
- platform/mac/fast/block/positioning/auto/vertical-rl/003-expected.checksum: Added.
- platform/mac/fast/block/positioning/auto/vertical-rl/003-expected.png: Added.
- platform/mac/fast/block/positioning/auto/vertical-rl/003-expected.txt: Added.
- platform/mac/fast/block/positioning/auto/vertical-rl/004-expected.checksum: Added.
- platform/mac/fast/block/positioning/auto/vertical-rl/004-expected.png: Added.
- platform/mac/fast/block/positioning/auto/vertical-rl/004-expected.txt: Added.
- platform/mac/fast/block/positioning/auto/vertical-rl/005-expected.checksum: Added.
- platform/mac/fast/block/positioning/auto/vertical-rl/005-expected.png: Added.
- platform/mac/fast/block/positioning/auto/vertical-rl/005-expected.txt: Added.
- platform/mac/fast/block/positioning/auto/vertical-rl/006-expected.checksum: Added.
- platform/mac/fast/block/positioning/auto/vertical-rl/006-expected.png: Added.
- platform/mac/fast/block/positioning/auto/vertical-rl/006-expected.txt: Added.
- platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.checksum: Added.
- platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
- platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.txt: Added.
- 3:20 PM Changeset in webkit [79929] by
-
- 3 edits in branches/chromium/648/Source/WebCore/rendering
Merge 77191
BUG=72340
Review URL: http://codereview.chromium.org/6596056
- 3:07 PM Changeset in webkit [79928] by
-
- 4 edits in branches/chromium/648/Source/WebCore/rendering
Merge 76859
BUG=69628
Review URL: http://codereview.chromium.org/6592048
- 3:05 PM Changeset in webkit [79927] by
-
- 5 edits in trunk/Source/WebKit2
Reviewed by Dan Bernstein.
Frequent crashes in CFURLCache code on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=55412
<rdar://problem/9063922>
CString is evil, it has two lengths which can be different - specifically, fileSystemRepresentation()
creates a string with maximum possible buffer size. A path with garbage at the end confused
CFURLCache into corrupting its data structures.
- Shared/WebProcessCreationParameters.h: Added a FIXME about merging Mac and Windows code. This problem wouldn't have occured if we didn't use CString in the first place.
- UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformInitializeWebProcess): Added an assertion matching Windows behavior (seems likely that NSURLCache also wouldn't have liked trailing slash).
- UIProcess/win/WebContextWin.cpp: (WebKit::WebContext::platformInitializeWebProcess): Made slash removal conditional for robustness.
- WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformInitializeWebProcess): Use actual string length, not CString::length().
- 2:50 PM Changeset in webkit [79926] by
-
- 1 edit2 copies in branches/chromium/648
Merge 79536
BUG=73932
Review URL: http://codereview.chromium.org/6588066
- 2:48 PM Changeset in webkit [79925] by
-
- 7 edits in trunk
2011-02-28 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Anders Carlsson.
[Qt][WK2] Plugin initialization
https://bugs.webkit.org/show_bug.cgi?id=48127
- Source/WebKit.pri: Lift the definition of the XP_UNIX macro from WebCore.pri to WebKit.pri to apply it to WebKit2 as well.
2011-02-28 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Anders Carlsson.
[Qt][WK2] Plugin initialization
https://bugs.webkit.org/show_bug.cgi?id=48127
No function change so no new tests.
- WebCore.pri: Lift the definition of the XP_UNIX macro from WebCore.pri to WebKit.pri to apply it to WebKit2 as well.
2011-02-28 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Anders Carlsson.
[Qt][WK2] Plugin initialization
https://bugs.webkit.org/show_bug.cgi?id=48127
Specialize the way of initializing the plugin for X11.
Introduce PLUGIN_ARCHITECTURE macros to allow code sharing
across platforms.
- Shared/Plugins/Netscape/NetscapePluginModule.cpp: (WebKit::NetscapePluginModule::tryLoad):
- config.h:
- 2:40 PM Changeset in webkit [79924] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-28 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Use more xcconfig files in JavaScriptCore gyp build
https://bugs.webkit.org/show_bug.cgi?id=55391
The GYP experts tell me that we have have a total of two xcconfig
files: one for the xcodeproj as a whole and one for each target. This
patch uses that technique to re-use the existing xcconfig files and
eliminate the duplication.
Technically, this patch introduces some build errors because the
xcconfig files assume that the xcodeproj file is one level higher in
the directory hierarchy. Specifically, the xcodeproj file can no
longer find the Info.plist or the prefix header. I plan to fix that in
a subsequent patch.
Also, this patch introduces the Release and Production configurations,
which should work correctly now.
- gyp/JavaScriptCore.gyp:
- 2:33 PM Changeset in webkit [79923] by
-
- 1 edit2 deletes in branches/chromium/648
Revert 79909 - Merge 79536
BUG=73932
Review URL: http://codereview.chromium.org/6591047
TBR=cdn@chromium.org
Review URL: http://codereview.chromium.org/6591053
- 2:32 PM Changeset in webkit [79922] by
-
- 4 edits in trunk/Source/WebCore
2011-02-28 Dean Jackson <dino@apple.com>
Reviewed by Eric Carlson.
Allow webkitEnterFullScreen to be called from outside
a user gesture, but only when the correct restrictions
have been lifted in WebCore. Add a new restriction type
for this situation. Meanwhile, expose the current
restrictions externally from HTMLMediaElement, so that
clients can easily set restrictions on their port.
No new tests. This doesn't change existing behavior. Some
WebKit clients may lift the restriction.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement):
- ensure restrictions initialize with fullscreen restricted
- html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::requireUserGestureForLoad): (WebCore::HTMLMediaElement::requireUserGestureForRateChange): (WebCore::HTMLMediaElement::requireUserGestureForFullScreen): (WebCore::HTMLMediaElement::setBehaviorRestrictions):
- new methods to expose the current restrictions
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::webkitEnterFullscreen):
- 2:18 PM Changeset in webkit [79921] by
-
- 2 edits in trunk/LayoutTests
2011-02-28 Jungshik Shin <jshin@chromium.org>
[chromium] Unreviewed change of test_expectations.txt
With the platform-specific expectation file landed in r79912,
fast/xsl/sort-locale-expected.txt should pass now on chromium.
So, remove it from the failure list.
- platform/chromium/test_expectations.txt:
- 2:14 PM Changeset in webkit [79920] by
-
- 17 edits2 deletes in trunk
2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78789.
http://trac.webkit.org/changeset/78789
https://bugs.webkit.org/show_bug.cgi?id=55409
Incorrect canvas fallback implementation (Requested by
inferno-sec on #webkit).
- public/WebAccessibilityRole.h:
- src/AssertMatchingEnums.cpp:
2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78789.
http://trac.webkit.org/changeset/78789
https://bugs.webkit.org/show_bug.cgi?id=55409
Incorrect canvas fallback implementation (Requested by
inferno-sec on #webkit).
- AccessibleBase.cpp: (MSAARole):
2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78789.
http://trac.webkit.org/changeset/78789
https://bugs.webkit.org/show_bug.cgi?id=55409
Incorrect canvas fallback implementation (Requested by
inferno-sec on #webkit).
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::determineAccessibilityRole): (WebCore::AccessibilityRenderObject::canHaveChildren):
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkRole):
- accessibility/mac/AccessibilityObjectWrapper.mm:
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::isFocusable):
- rendering/RenderHTMLCanvas.cpp:
- rendering/RenderHTMLCanvas.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::repaint):
- rendering/RenderTreeAsText.cpp: (WebCore::write):
2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78789.
http://trac.webkit.org/changeset/78789
https://bugs.webkit.org/show_bug.cgi?id=55409
Incorrect canvas fallback implementation (Requested by
inferno-sec on #webkit).
- accessibility/canvas-fallback-content-expected.txt: Removed.
- accessibility/canvas-fallback-content.html: Removed.
- accessibility/canvas.html:
- 2:09 PM Changeset in webkit [79919] by
-
- 6 edits2 deletes in trunk
2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79425.
http://trac.webkit.org/changeset/79425
https://bugs.webkit.org/show_bug.cgi?id=55406
Incorrect canvas fallback implementation. (Requested by
inferno-sec on #webkit).
- canvas/canvas-mouse-events-expected.txt: Removed.
- canvas/canvas-mouse-events.html: Removed.
- platform/mac-wk2/Skipped:
- platform/qt-wk2/Skipped:
- platform/win-wk2/Skipped:
2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79425.
http://trac.webkit.org/changeset/79425
https://bugs.webkit.org/show_bug.cgi?id=55406
Incorrect canvas fallback implementation. (Requested by
inferno-sec on #webkit).
- rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::nodeAtPoint):
- 2:00 PM Changeset in webkit [79918] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Add symbol to export.
- 1:55 PM Changeset in webkit [79917] by
-
- 14 edits3 adds in trunk
2011-02-28 Adam Klein <adamk@chromium.org>
Reviewed by Adam Barth.
[fileapi] Implement LocalFileSystem.resolveLocalFileSystemURI
https://bugs.webkit.org/show_bug.cgi?id=54774
Tests for resolveLocalFileSystemURI.
- fast/filesystem/resolve-uri-expected.txt: Added.
- fast/filesystem/resolve-uri.html: Added.
- fast/filesystem/script-tests/resolve-uri.js: Added.
2011-02-28 Adam Klein <adamk@chromium.org>
Reviewed by Adam Barth.
[fileapi] Implement LocalFileSystem.resolveLocalFileSystemURI
https://bugs.webkit.org/show_bug.cgi?id=54774
See http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#methods
for the spec implemented by this patch.
Test: fast/filesystem/resolve-uri.html
- fileapi/DOMFileSystemBase.cpp: (WebCore::DOMFileSystemBase::crackFileSystemURL):
- fileapi/DOMFileSystemBase.h: Added constants for "temporary" and "persistent".
- fileapi/EntryBase.cpp: Replace hardcoded strings with aforementioned constants.
- fileapi/FileSystemCallbacks.cpp: (WebCore::ResolveURICallbacks::create): (WebCore::ResolveURICallbacks::ResolveURICallbacks): (WebCore::ResolveURICallbacks::didOpenFileSystem): Chains a call of openFileSystem to calls to getDirectory/getFile.
- fileapi/FileSystemCallbacks.h:
- fileapi/LocalFileSystem.cpp: (WebCore::LocalFileSystem::readFileSystem):
- fileapi/LocalFileSystem.h: Remove size argument from readFileSystem()
- page/DOMWindow.cpp: (WebCore::DOMWindow::resolveLocalFileSystemURI):
- page/DOMWindow.h:
- page/DOMWindow.idl:
2011-02-28 Adam Klein <adamk@chromium.org>
Reviewed by Adam Barth.
[fileapi] Implement LocalFileSystem.resolveLocalFileSystemURI
https://bugs.webkit.org/show_bug.cgi?id=54774
- src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::readFileSystem): Removed size argument to readFileSystem()
- 1:51 PM Changeset in webkit [79916] by
-
- 4 edits in trunk/Source
Build fix for Qt port after API changes of http://trac.webkit.org/changeset/79904.
Patch by Alexis Menard <alexis.menard@openbossa.org> on 2011-02-28
Reviewed by Oliver Hunt.
Source/WebCore:
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtConnectionObject::execute):
Source/WebKit/qt:
- Api/qwebelement.cpp:
(QWebElement::evaluateJavaScript):
- 1:41 PM Changeset in webkit [79915] by
-
- 4 edits6 deletes in trunk/LayoutTests
2011-02-28 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium rebaseline.
Fix 3 tests for Snow Leopard by removing out of date chromium-mac
baselines (there are already chromium-mac-leopard results).
Revert rebaseline done by r79881 since the behavior was reverted by
r79900.
- platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Removed.
- platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Removed.
- platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Removed.
- platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Removed.
- platform/chromium-mac/fast/forms/placeholder-position-expected.checksum: Removed.
- platform/chromium-mac/fast/forms/placeholder-position-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/forms/listbox-hit-test-zoomed-expected.checksum:
- platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png:
- 1:39 PM Changeset in webkit [79914] by
-
- 7 edits in trunk/Source/WebKit2
WK2 Context Menus - Implement LookUpInDictionary
https://bugs.webkit.org/show_bug.cgi?id=55405
Reviewed by Brady Eidson.
- Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):
- Shared/DictionaryPopupInfo.h:
Add type to differentiate between HotKey and ContextMenu triggered
dictionary popups. This is necessary since HotKey triggered ones want
to override the style to always be overlay.
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup):
Only force the overlay style for HotKey triggered dictionary lookups.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation):
(WebKit::WebPage::performDictionaryLookupForRange):
Factor out shared functionality into performDictionaryLookupForRange.
- WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
(WebKit::WebContextMenuClient::lookUpInDictionary):
Get selected range and call newly factored out performDictionaryLookupForRange.
- 1:38 PM Changeset in webkit [79913] by
-
- 1 edit2 copies in branches/chromium/648
Merge 79810
BUG=74030
Review URL: http://codereview.chromium.org/6588061
- 1:35 PM Changeset in webkit [79912] by
-
- 1 edit1 copy1 add in trunk/LayoutTests
2011-02-28 Jungshik Shin <jshin@chromium.org>
Reviewed by Tony Chang
[chromium] Recently, French Academy changed the sorting
rules for French in such a way that accents are not weighted
from the end of a word any more. ICU 4.6 / CLDR 1.9
incorporated the change. Canadian French hasn't adopted the
change, yet.
Chrome is the only port that uses new rules with ICU 4.6. So,
for now, I'm changing the expectation file for Chrome only.
- platform/chromium/fast/xsl: Added.
- platform/chromium/fast/xsl/sort-locale-expected.txt: Copied from LayoutTests/fast/xsl/sort-locale-expected.txt.
- 1:34 PM Changeset in webkit [79911] by
-
- 4 edits4 copies in branches/chromium/648
Merge 79734
BUG=72028
Review URL: http://codereview.chromium.org/6598044
- 1:30 PM Changeset in webkit [79910] by
-
- 1 edit3 copies in branches/chromium/648
Merge 79689
BUG=70027
Review URL: http://codereview.chromium.org/6591048
- 1:23 PM Changeset in webkit [79909] by
-
- 1 edit2 copies in branches/chromium/648
Merge 79536
BUG=73932
Review URL: http://codereview.chromium.org/6591047
- 1:18 PM Changeset in webkit [79908] by
-
- 1 edit2 copies in branches/chromium/648
Merge 79476
BUG=73746
Review URL: http://codereview.chromium.org/6596050
- 1:13 PM Changeset in webkit [79907] by
-
- 3 edits2 copies in branches/chromium/648
Merge 78921
BUG=73196
Review URL: http://codereview.chromium.org/6591046
- 1:07 PM Changeset in webkit [79906] by
-
- 4 edits in trunk/Source/WebCore
Remove some duplicate code from KURLGoogle.cpp
https://bugs.webkit.org/show_bug.cgi?id=55266
Reviewed by Darin Adler.
No change in functionality so no new tests.
- WebCore.gyp/WebCore.gyp: Make KURL.cpp get built by Chromium.
- platform/KURL.cpp:
Simply moved #include's and some code that was identical (i.e.
had been copied) to KURLGoogle.cpp outside of ifdef !USE(GOOGLEURL)
to reduce duplication.
- platform/KURLGoogle.cpp:
Removed the duplicate code.
- 1:07 PM Changeset in webkit [79905] by
-
- 2 edits in trunk/Source/JavaScriptGlue
2011-02-28 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Use more xcconfig files in JavaScriptGlue gyp build
https://bugs.webkit.org/show_bug.cgi?id=55395
Technically this patch breaks the build because the generated project
can't find the Info.plist file or the list of exported symbols. I'll
fix that in a follow-up patch.
- gyp/JavaScriptGlue.gyp:
- 1:05 PM Changeset in webkit [79904] by
-
- 60 edits3 adds in trunk/Source
2011-02-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Make ScopeChainNode GC allocated
https://bugs.webkit.org/show_bug.cgi?id=55283
Simplify lifetime and other issues with the scopechain
by making it gc allocated. This allows us to simplify
function exit and unwinding, as well as making the
current iterative refcounting go away.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::createActivation):
- bytecode/StructureStubInfo.cpp:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::generate): (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall): (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
- bytecompiler/BytecodeGenerator.h:
- debugger/Debugger.cpp: (JSC::Recompiler::operator()):
- debugger/DebuggerCallFrame.h: (JSC::DebuggerCallFrame::scopeChain):
- interpreter/CachedCall.h: (JSC::CachedCall::CachedCall):
- interpreter/CallFrame.h:
- interpreter/Interpreter.cpp: (JSC::depth): (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::throwException): (JSC::Interpreter::execute): (JSC::Interpreter::executeCall): (JSC::Interpreter::executeConstruct): (JSC::Interpreter::privateExecute):
- jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCall):
- jit/JITCall32_64.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::emit_op_ret): (JSC::JIT::emit_op_ret_object_or_this): (JSC::JIT::compileOpCall):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_end): (JSC::JIT::emit_op_ret): (JSC::JIT::emit_op_ret_object_or_this):
- jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_end):
- jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
- runtime/ArgList.cpp:
- runtime/Completion.cpp: (JSC::evaluate):
- runtime/Completion.h:
- runtime/DateConversion.cpp:
- runtime/Executable.cpp: (JSC::EvalExecutable::compileInternal): (JSC::ProgramExecutable::compileInternal): (JSC::FunctionExecutable::compileForCallInternal): (JSC::FunctionExecutable::compileForConstructInternal):
- runtime/FunctionConstructor.cpp: (JSC::constructFunction):
- runtime/GCActivityCallbackCF.cpp:
- runtime/Identifier.cpp:
- runtime/JSCell.h:
- runtime/JSChunk.cpp: Added.
- runtime/JSChunk.h: Added.
- runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): (JSC::JSFunction::markChildren): (JSC::JSFunction::getCallData): (JSC::JSFunction::getOwnPropertySlot): (JSC::JSFunction::getConstructData):
- runtime/JSFunction.h: (JSC::JSFunction::scope): (JSC::JSFunction::setScope):
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
- runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): (JSC::JSGlobalObject::markChildren):
- runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): (JSC::JSGlobalObject::globalScopeChain):
- runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncEval):
- runtime/JSLock.cpp:
- runtime/JSNumberCell.cpp:
- runtime/JSZombie.cpp:
- runtime/MarkedBlock.cpp:
- runtime/MarkedSpace.cpp:
- runtime/PropertyNameArray.cpp:
- runtime/ScopeChain.cpp: (JSC::ScopeChainNode::print): (JSC::ScopeChainNode::localDepth): (JSC::ScopeChainNode::markChildren):
- runtime/ScopeChain.h: (JSC::ScopeChainNode::ScopeChainNode): (JSC::ScopeChainNode::createStructure): (JSC::ScopeChainNode::push): (JSC::ScopeChainNode::pop): (JSC::ScopeChainIterator::ScopeChainIterator): (JSC::ScopeChainIterator::operator*): (JSC::ScopeChainIterator::operator->): (JSC::ScopeChainIterator::operator++): (JSC::ScopeChainNode::begin): (JSC::ScopeChainNode::end): (JSC::ExecState::globalData): (JSC::ExecState::lexicalGlobalObject): (JSC::ExecState::globalThisValue):
- runtime/ScopeChainMark.h:
- wtf/DateMath.cpp:
2011-02-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Make ScopeChainNode GC allocated
https://bugs.webkit.org/show_bug.cgi?id=55283
Update WebCore to deal with the absence of the ScopeChain
class.
- ForwardingHeaders/runtime/ScopeChain.h: Added.
- bindings/js/JSHTMLElementCustom.cpp: (WebCore::JSHTMLElement::pushEventHandlerScope):
- bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::scopeChain): (WebCore::JSJavaScriptCallFrame::scopeType):
- bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::initializeJSFunction):
- bindings/js/JSMainThreadExecState.h: (WebCore::JSMainThreadExecState::evaluate):
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::pushEventHandlerScope):
- bindings/js/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::scopeChain):
- bindings/js/JavaScriptCallFrame.h:
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/c/c_class.cpp:
- bridge/c/c_runtime.cpp:
- bridge/jni/JNIBridge.cpp:
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtConnectionObject::execute):
- plugins/PluginViewNone.cpp:
2011-02-28 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Make ScopeChainNode GC allocated
https://bugs.webkit.org/show_bug.cgi?id=55283
More updates for the absence of the ScopeChain class
- WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]):
- 1:05 PM Changeset in webkit [79903] by
-
- 1 edit2 copies in branches/chromium/648
Merge 78744
BUG=73134
Review URL: http://codereview.chromium.org/6588060
- 12:55 PM Changeset in webkit [79902] by
-
- 1 edit2 copies in branches/chromium/648
Merge 78775
BUG=73235
Review URL: http://codereview.chromium.org/6588058
- 12:54 PM Changeset in webkit [79901] by
-
- 8 edits10 copies in branches/chromium/648
Merge 78147
BUG=71763
- 12:51 PM Changeset in webkit [79900] by
-
- 4 edits4 adds in trunk
2011-02-28 Chang Shu <cshu@webkit.org>
Reviewed by Adele Peterson.
REGRESSION (r79762): Items in <select multiple> have focus rings, but shouldn't
https://bugs.webkit.org/show_bug.cgi?id=55323
Added test case to make sure no focus ring is drawn on selected items.
- fast/forms/select-listbox-multiple-no-focusring.html: Added.
- platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.checksum: Added.
- platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.png: Added.
- platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Added.
2011-02-28 Chang Shu <cshu@webkit.org>
Reviewed by Adele Peterson.
REGRESSION (r79762): Items in <select multiple> have focus rings, but shouldn't
https://bugs.webkit.org/show_bug.cgi?id=55323
Draw focus ring on selected items only if spatial navigation is enabled.
Test: fast/forms/select-listbox-multiple-no-focusring.html
- rendering/RenderBlock.h:
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::addFocusRingRects):
- 12:50 PM Changeset in webkit [79899] by
-
- 3 edits in branches/chromium/648
Merge 78738
BUG=73066
Review URL: http://codereview.chromium.org/6596048
- 12:30 PM Changeset in webkit [79898] by
-
- 3 edits2 copies in branches/chromium/648
Merge 79606
BUG=72936
Review URL: http://codereview.chromium.org/6592044
- 12:29 PM Changeset in webkit [79897] by
-
- 6 edits in trunk
2011-02-28 Abhishek Arya <inferno@chromium.org>
Reviewed by Anders Carlsson.
We can cancel the plugin load and fail with error before m_manualStream
got a chance to initialize in PluginView::didReceiveResponse. This can
happen when we run pending document onload events during plugin load that
remove the frame from underneath. So, change the assert into a null check.
https://bugs.webkit.org/show_bug.cgi?id=55307
- plugins/PluginView.cpp: (WebCore::PluginView::didFail):
2011-02-28 Abhishek Arya <inferno@chromium.org>
Reviewed by Anders Carlsson.
Unskip crashing test fast/frames/iframe-plugin-load-remove-document-crash.html.
https://bugs.webkit.org/show_bug.cgi?id=55307
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 12:25 PM Changeset in webkit [79896] by
-
- 3 edits in trunk/Source/WebCore
2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Alexey Proskuryakov.
Build fix for Intel ICC Compiler.
https://bugs.webkit.org/show_bug.cgi?id=55221
The virtual inheritance seems to confuse ICC.
Anything that links with webkit has an undefined reference otherwise.
- svg/SVGTransformable.cpp: (WebCore::SVGTransformable::~SVGTransformable):
- svg/SVGTransformable.h:
- 12:18 PM Changeset in webkit [79895] by
-
- 2 edits in trunk/LayoutTests
2011-02-28 Adam Klein <adamk@chromium.org>
Reviewed by James Robinson.
[chromium] Remove "PASS TEXT" expectation for fast/filesystem/op-get-entry.html
https://bugs.webkit.org/show_bug.cgi?id=55262
Test now passes as Chromium has rolled past r76098.
- platform/chromium/test_expectations.txt:
- 12:12 PM Changeset in webkit [79894] by
-
- 5 edits1 add in trunk/Source/WebKit/qt
[Qt]tst_QDeclarativeWebView - 8 test cases fail
https://bugs.webkit.org/show_bug.cgi?id=55214
Patch by Alexis Menard <alexis.menard@openbossa.org> on 2011-02-28
Reviewed by Andreas Kling.
Fix the API tests for the QML WebView element. The default size of the element should be the size of the QGraphicsWebView
if no preferred width or height are provided (see http://trac.webkit.org/changeset/79672).
I also refactored the tests so we don't use the network but instead a local html file.
QML doesn't support qrc loading so I had to workaround by using a property that I update afterwards.
- tests/qdeclarativewebview/resources/sample.html: Added.
- tests/qdeclarativewebview/resources/webviewtest.qml:
- tests/qdeclarativewebview/resources/webviewtestdefault.qml:
- tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
(tst_QDeclarativeWebView::preferredWidthTest):
(tst_QDeclarativeWebView::preferredHeightTest):
(tst_QDeclarativeWebView::preferredWidthDefaultTest):
(tst_QDeclarativeWebView::preferredHeightDefaultTest):
- tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
- 12:10 PM Changeset in webkit [79893] by
-
- 4 edits in branches/chromium/648/Source/WebCore
Merge 77738
BUG=71545
Review URL: http://codereview.chromium.org/6594055
- 12:09 PM Changeset in webkit [79892] by
-
- 1 edit in branches/chromium/648/Source/WebCore/bindings/v8/V8GCController.cpp
Temporary disable object grouping for some types of objects.
BUG=http://code.google.com/p/chromium/issues/detail?id=73441
- 12:03 PM Changeset in webkit [79891] by
-
- 3 edits in trunk/Source/WebKit2
2011-02-28 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
PDFViewController should hold a reference to the PDF data
https://bugs.webkit.org/show_bug.cgi?id=55394
- UIProcess/API/mac/PDFViewController.h:
- UIProcess/API/mac/PDFViewController.mm: (WebKit::PDFViewController::setPDFDocumentData):
- 11:50 AM Changeset in webkit [79890] by
-
- 3 edits3 adds in trunk/Source/JavaScriptGlue
2011-02-28 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Adam Barth.
Add necessary build steps to JavaScriptGlue GYP project.
https://bugs.webkit.org/show_bug.cgi?id=55196
- gyp/JavaScriptGlue.gyp: Added pre- and post- build steps.
- gyp/JavaScriptGlue.gypi: Added Info.plist.
- gyp/remove-headers-if-needed.sh: Added.
- gyp/run-if-exists.sh: Added.
- gyp/update-info-plist.sh: Added.
- 11:44 AM Changeset in webkit [79889] by
-
- 5 edits in trunk
2011-02-28 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[Gtk] Resource size is incorrectly reported to WebCore
https://bugs.webkit.org/show_bug.cgi?id=53228
- platform/gtk/Skipped: unskipped http/tests/inspector/network-size.html
2011-02-28 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[Gtk] Resource size is incorrectly reported to WebCore
https://bugs.webkit.org/show_bug.cgi?id=53228
When calling didReceiveData we are sending an invalid value for
lengthReceived. Sometimes we were even passing a boolean value instead of the
expected integer. We should pass the size of the received data instead of the
total amount of data received.
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotChunkCallback): (WebCore::sendRequestCallback): (WebCore::readCallback):
- 11:42 AM Changeset in webkit [79888] by
-
- 2 edits in trunk/Source/WebCore
2011-02-28 Laszlo Gombos <Laszlo Gombos>
Reviewed by Dan Bernstein.
Cleanup the include guard form an Objective-C files
https://bugs.webkit.org/show_bug.cgi?id=55379
Normally Objective-C files do not need include guard.
r76916 introduced an include guard in EmptyProtocolDefinitions.h.
The guard is no longer needed after r76991.
No new tests as there is no new functionality.
- platform/mac/EmptyProtocolDefinitions.h:
- 11:29 AM Changeset in webkit [79887] by
-
- 4 edits in trunk/Source/WebCore
2011-02-28 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] no resources in scripts panel because debugger is enabled too early.
https://bugs.webkit.org/show_bug.cgi?id=55389
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::populateScriptObjects):
- inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setFrontend): (WebCore::InspectorDebuggerAgent::enableDebuggerAfterShown):
- inspector/InspectorDebuggerAgent.h:
- 11:19 AM Changeset in webkit [79886] by
-
- 21 edits2 moves2 adds in trunk/Source/WebKit2
Size of text in popup menu doesn't match size of text in <select> itself in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48234
Reviewed by Darin Adler.
- Shared/TextInfo.cpp: Removed.
- Shared/TextInfo.h: Removed.
Replace this with the more appropriately DictionaryPopupInfo.
- Shared/DictionaryPopupInfo.cpp: Copied from Source/WebKit2/Shared/TextInfo.cpp.
(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):
- Shared/DictionaryPopupInfo.h: Copied from Source/WebKit2/Shared/TextInfo.h.
(WebKit::DictionaryPopupInfo::DictionaryPopupInfo):
Replace individual font related fields with FontInfo.
- Shared/FontInfo.cpp: Added.
(WebKit::FontInfo::FontInfo):
(WebKit::FontInfo::encode):
(WebKit::FontInfo::decode):
- Shared/FontInfo.h: Added.
Add class to encapsulate passing a font description over the wire.
- Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::encode):
(WebKit::PlatformPopupMenuData::decode):
- Shared/PlatformPopupMenuData.h:
Add FontInfo as extra data for the Mac.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup):
- UIProcess/PageClient.h:
Add scaleFactor and use it to construct a font at the right size.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::didPerformDictionaryLookup):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebPopupMenuProxy.h:
- UIProcess/mac/WebPopupMenuProxyMac.h:
(WebKit::WebPopupMenuProxyMac::create):
- UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::WebPopupMenuProxyMac):
(WebKit::WebPopupMenuProxyMac::populate):
(WebKit::WebPopupMenuProxyMac::showPopupMenu):
- UIProcess/qt/WebPopupMenuProxyQt.cpp:
(WebKit::WebPopupMenuProxyQt::showPopupMenu):
- UIProcess/qt/WebPopupMenuProxyQt.h:
- UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::showPopupMenu):
- UIProcess/win/WebPopupMenuProxyWin.h:
- WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:
(WebKit::WebPopupMenu::setUpPlatformData):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation):
Pass scale factor through and rename TextInfo -> DictionaryPopupInfo.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Add new files.
- 11:08 AM Changeset in webkit [79885] by
-
- 231 edits590 adds in trunk/LayoutTests
Unreviewed.
[Qt] Add Qt specific expected results for passing fast tests.
- platform/qt/Skipped: Unskip passing tests.
- platform/qt/fast/transforms [...] : Added.
- platform/qt/fast/tokenizer [...] : Added.
- platform/qt/fast/replaced [...] : Added.
- platform/qt/fast/runin [...] : Added.
- platform/qt/fast/selectors [...] : Added.
- platform/qt/fast/table [...] : Added.
- ChangeLog : Remove duplicated ChangeLog entry.
- 11:08 AM Changeset in webkit [79884] by
-
- 4 edits in trunk/Source/WebKit/qt
2011-02-28 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Andreas Kling.
[Qt] Add clipped version of QWebElement::render method.
Allows faster rendering of web element part.
https://bugs.webkit.org/show_bug.cgi?id=50311
- Api/qwebelement.cpp: (QWebElement::render):
- Api/qwebelement.h:
- tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::render):
- 10:58 AM Changeset in webkit [79883] by
-
- 2 edits in trunk/LayoutTests
2011-02-28 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations change.
Skip over fast/overflow/horizontal-scroll-after-back.html added by
r79844, since it's page cache-specific.
- platform/chromium/test_expectations.txt:
- 10:30 AM Changeset in webkit [79882] by
-
- 8 edits4 deletes in trunk/Source/WebCore
2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79877.
http://trac.webkit.org/changeset/79877
https://bugs.webkit.org/show_bug.cgi?id=55388
Breaks chromium build (Requested by antonm_ on #webkit).
- WebCore.gypi:
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::updateContentsIfDirty): (WebCore::ContentLayerChromium::resizeUploadBufferForImage): (WebCore::ContentLayerChromium::resizeUploadBuffer): (WebCore::SkBitmapConditionalAutoLockerPixels::SkBitmapConditionalAutoLockerPixels): (WebCore::SkBitmapConditionalAutoLockerPixels::~SkBitmapConditionalAutoLockerPixels): (WebCore::SkBitmapConditionalAutoLockerPixels::lockPixels): (WebCore::ContentLayerChromium::updateTextureIfNeeded): (WebCore::ContentLayerChromium::draw):
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContentsIfDirty):
- platform/graphics/chromium/ImageLayerChromium.h:
- platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::contentRectToTileIndices): (WebCore::LayerTilerChromium::update):
- platform/graphics/chromium/LayerTilerChromium.h:
- platform/graphics/chromium/PlatformCanvas.cpp: Removed.
- platform/graphics/chromium/PlatformCanvas.h: Removed.
- platform/graphics/chromium/PlatformImage.cpp: Removed.
- platform/graphics/chromium/PlatformImage.h: Removed.
- 10:29 AM Changeset in webkit [79881] by
-
- 4 edits in trunk/LayoutTests
2011-02-28 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations change.
Rebaseline fast/forms/listbox-hit-test-zoomed.html after r79762.
Also make a new other expectations more specific.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/forms/listbox-hit-test-zoomed-expected.checksum:
- platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png:
- 10:23 AM Changeset in webkit [79880] by
-
- 9 edits3 adds in trunk
2011-02-28 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add live edit test.
https://bugs.webkit.org/show_bug.cgi?id=55360
- http/tests/inspector/debugger-test.js: (initialize_DebuggerTest):
- inspector/debugger/debug-inlined-scripts.html:
- inspector/debugger/live-edit-expected.txt: Added.
- inspector/debugger/live-edit.html: Added.
- inspector/debugger/resources/edit-me.js: Added.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
2011-02-28 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add live edit test.
https://bugs.webkit.org/show_bug.cgi?id=55360
Test: inspector/debugger/live-edit.html
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._doubleClick): (WebInspector.SourceFrame.prototype._didEditLine):
- 10:16 AM Changeset in webkit [79879] by
-
- 3 edits in trunk/LayoutTests
2011-02-28 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. More follow ups to XML Viewer tests commit.
- http/tests/xmlviewer/dumpAsText/frames.html:
- platform/qt/Skipped:
- 10:11 AM Changeset in webkit [79878] by
-
- 2 edits in trunk/Source/WebCore
2011-02-28 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Follow up to r79858, removing optimistic assertion that fails on debug bot.
- inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
- 10:03 AM Changeset in webkit [79877] by
-
- 8 edits1 copy3 adds in trunk/Source/WebCore
2011-02-25 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] Abstract "pixels with a graphics context" into its own class
https://bugs.webkit.org/show_bug.cgi?id=55259
This creates new PlatformCanvas/PlatformImage classes which wrap
all of the #ifdef Skia/Cg warts from the compositor. All classes
(LayerTilerChromium, ContentLayerChromium, and ImageLayerChromium) are
modified to use these abstractions.
Tests: LayoutTests/compositing
- WebCore.gypi:
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::updateContentsIfDirty): (WebCore::ContentLayerChromium::resizeUploadBuffer): (WebCore::ContentLayerChromium::updateTextureIfNeeded): (WebCore::ContentLayerChromium::updateTexture): (WebCore::ContentLayerChromium::draw):
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContentsIfDirty): (WebCore::ImageLayerChromium::updateTextureIfNeeded):
- platform/graphics/chromium/ImageLayerChromium.h:
- platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::contentRectToTileIndices): (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::updateFromPixels):
- platform/graphics/chromium/LayerTilerChromium.h:
- platform/graphics/chromium/PlatformCanvas.cpp: Added. (WebCore::PlatformCanvas::PlatformCanvas): (WebCore::PlatformCanvas::~PlatformCanvas): (WebCore::PlatformCanvas::resize): (WebCore::PlatformCanvas::AutoLocker::AutoLocker): (WebCore::PlatformCanvas::AutoLocker::~AutoLocker): (WebCore::PlatformCanvas::Painter::Painter): (WebCore::PlatformCanvas::Painter::~Painter):
- platform/graphics/chromium/PlatformCanvas.h: Added. (WebCore::PlatformCanvas::AutoLocker::pixels): (WebCore::PlatformCanvas::Painter::context): (WebCore::PlatformCanvas::size):
- platform/graphics/chromium/PlatformImage.cpp: Copied from Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp. (WebCore::PlatformImage::PlatformImage): (WebCore::PlatformImage::updateFromImage):
- platform/graphics/chromium/PlatformImage.h: Added. (WebCore::PlatformImage::pixels): (WebCore::PlatformImage::size):
- 9:54 AM Changeset in webkit [79876] by
-
- 8 edits in trunk
2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79784.
http://trac.webkit.org/changeset/79784
https://bugs.webkit.org/show_bug.cgi?id=55386
This change causes lots of assertion failures in Debug builds
(Requested by aroben on #webkit).
- transitions/matched-transform-functions.html:
- transitions/retargetted-transition.html:
2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79784.
http://trac.webkit.org/changeset/79784
https://bugs.webkit.org/show_bug.cgi?id=55386
This change causes lots of assertion failures in Debug builds
(Requested by aroben on #webkit).
- css/CSSStyleSelector.cpp: (WebCore::convertToLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::createTransformOperations):
- platform/Length.h: (WebCore::Length::Length): (WebCore::Length::operator==): (WebCore::Length::operator!=): (WebCore::Length::rawValue): (WebCore::Length::type): (WebCore::Length::quirk): (WebCore::Length::setValue): (WebCore::Length::setRawValue): (WebCore::Length::calcFloatValue): (WebCore::Length::isZero): (WebCore::Length::blend):
- rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
- rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):
- 9:51 AM Changeset in webkit [79875] by
-
- 6 edits in trunk/Source/WebCore
2011-02-28 Andreas Kling <kling@webkit.org>
Reviewed by Darin Adler.
Use Frame::ownerElement() directly where appropriate.
https://bugs.webkit.org/show_bug.cgi?id=55385
Don't take the roundabout way through frame->document->ownerElement
which just checks that the document->frame is non-null.
No new test, refactoring only.
- editing/SelectionController.cpp: (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadWithDocumentLoader):
- page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent):
- page/EventHandler.cpp: (WebCore::EventHandler::scrollRecursively): (WebCore::EventHandler::logicalScrollRecursively):
- page/FrameView.cpp: (WebCore::FrameView::init): (WebCore::FrameView::layout): (WebCore::FrameView::repaintContentRectangle): (WebCore::FrameView::windowClipRect): (WebCore::FrameView::paintContents):
- 9:43 AM Changeset in webkit [79874] by
-
- 2 edits1 move in trunk/LayoutTests
2011-02-28 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: follow up to r79861, moved utf-16-no-bom to its new home, fixed flaky frames.html.
- fast/encoding/dumpAsText/utf-16-no-bom.xml: Renamed from LayoutTests/fast/encoding/utf-16-no-bom.xml.
- http/tests/xmlviewer/dumpAsText/frames.html:
- 9:29 AM Changeset in webkit [79873] by
-
- 5 edits in trunk
2011-02-28 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] source frame is recreated for each inlined script in document.
https://bugs.webkit.org/show_bug.cgi?id=55377
- inspector/debugger/scripts-panel-expected.txt:
- inspector/debugger/scripts-panel.html:
2011-02-28 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] source frame is recreated for each inlined script in document.
https://bugs.webkit.org/show_bug.cgi?id=55377
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished): (WebInspector.ScriptsPanel.prototype._sourceFrameForSourceName): (WebInspector.ScriptsPanel.prototype._createSourceFrame): (WebInspector.ScriptsPanel.prototype._recreateSourceFrame):
- 9:22 AM Changeset in webkit [79872] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] Remove non-existent tests from Skipped list after r79861.
- platform/qt/Skipped:
- 9:20 AM Changeset in webkit [79871] by
-
- 2 edits in trunk/Source/WebCore
2011-02-28 Patrick Gansterer <Patrick Gansterer>
Unreviewed build fix for !ENABLE(SVG_ANIMATION) after r79569.
- svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::removeAllAnimationElementsFromTarget):
- 9:16 AM Changeset in webkit [79870] by
-
- 101 edits3 copies373 adds in trunk/LayoutTests
Unreviewed.
[Qt] Add Qt specific expected results for passing fast/css tests.
- platform/qt/Skipped:
- platform/qt/fast/css [...] : Added.
- 8:55 AM Changeset in webkit [79869] by
-
- 3 edits in trunk/Source/WebKit2
One more rename as a followup to r79868
Rubber-stamped by Anders Carlsson.
- UIProcess/DrawingAreaProxyImpl.cpp:
- UIProcess/DrawingAreaProxyImpl.h:
Rename stateDidChange to backingStoreStateDidChange.
- 8:53 AM Changeset in webkit [79868] by
-
- 9 edits in trunk/Source/WebKit2
Rename DrawingArea[Proxy]Impl's "state ID" concept to "backing store state ID"
Rubber-stamped (and suggested) by Anders Carlsson.
- UIProcess/DrawingAreaProxy.h:
- UIProcess/DrawingAreaProxy.messages.in:
- UIProcess/DrawingAreaProxyImpl.cpp:
- UIProcess/DrawingAreaProxyImpl.h:
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/DrawingArea.messages.in:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
- WebProcess/WebPage/DrawingAreaImpl.h:
Perform the rename.
- 8:35 AM Changeset in webkit [79867] by
-
- 3 edits in trunk/Source/WebKit2
Decouple state changes from sending of UpdateState messages in DrawingAreaProxyImpl
The new DrawingAreaProxyImpl::stateDidChange function should be called whenever
DrawingAreaProxyImpl's state changes in a way that will require allocating a new backing
store. (Currently, this is just when the size changes.) This function will sometimes (but
not always, as when we're waiting for a DidUpdateState message) send an UpdateState message
to the web process. This means it's now possible for the state IDs sent in consecutive
UpdateState messages to increase by more than one, but that's OK.
This should cause no change in behavior.
Fixes <http://webkit.org/b/55382> DrawingAreaProxyImpl's state ID should be updated whenever
its state changes, not just when we send an UpdateState message
Reviewed by Anders Carlsson.
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): Updated for rename.
(WebKit::DrawingAreaProxyImpl::sizeDidChange): Changed to call stateDidChange.
(WebKit::DrawingAreaProxyImpl::didUpdateState): Updated for rename, and changed to call
sendUpdateState whenever our state has changed for any reason since the last UpdateState
message was sent.
(WebKit::DrawingAreaProxyImpl::stateDidChange): Added. Increments m_nextStateID and calls
through to sendUpdateState.
(WebKit::DrawingAreaProxyImpl::sendUpdateState): Updated for rename, moved incrementing of
the state ID we send to the web process from here to stateDidChange, and added an assertion.
- UIProcess/DrawingAreaProxyImpl.h: Renamed m_requestedStateID to m_nextStateID, and updated
the comment explaining its meaning.
- 8:16 AM Changeset in webkit [79866] by
-
- 3 edits in trunk/Source/WebCore
2011-02-28 Renata Hodovan <reni@webkit.org>
Reviewed by Andreas Kling.
Optimize parameter transmissions in FEConvolveMatrix.
https://bugs.webkit.org/show_bug.cgi?id=55381
Parameter transmission via reference is more efficient than with copy. So they are substituted.
No new tests are needed since this is a refactoring.
- platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::setKernelSize): (WebCore::FEConvolveMatrix::setTargetOffset): (WebCore::FEConvolveMatrix::setKernelUnitLength):
- platform/graphics/filters/FEConvolveMatrix.h:
- 8:05 AM Changeset in webkit [79865] by
-
- 2 edits in trunk/LayoutTests
Skip a sometimes-crashing test on Windows
The failure is tracked by <http://webkit.org/b/55375>.
- platform/win/Skipped: Added http/tests/websocket/tests/reload-crash.html.
- 7:50 AM Changeset in webkit [79864] by
-
- 2 edits in trunk/Source/WebCore
2011-02-28 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix Chromium tests failures due to r79858.
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::inspectedPageDestroyed):
- 7:49 AM TriagingTestFailures edited by
- Add information about the new MakingBotsRed keyword (diff)
- 7:31 AM Changeset in webkit [79863] by
-
- 14 edits7 adds in trunk
Pass the right dirty rect to Plugin::paint
A typo in r79040 broke this. Much of this patch is just support for testing the fix.
Fixes <http://webkit.org/b/55365> <rdar://problem/9031089> REGRESSION (r79040): WebKit2:
Large portions of pages with plugins paint black
Reviewed by Anders Carlsson.
Source/WebKit2:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::paint): Pass the dirty rect we calculated earlier to Plugin::paint,
rather than just passing along the dirty rect that was passed into this function. This is
the bug fix.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageForceRepaint):
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
Added new SPI. Just calls through to WebPage::forceRepaintWithoutCallback.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::forceRepaintWithoutCallback): Moved code to force a repaint here...
(WebKit::WebPage::forceRepaint): ...from here.
- WebProcess/WebPage/WebPage.h: Added forceRepaintWithoutCallback.
Tools:
Add a test for the paint rect passed via WM_PAINT to windowless plugins
- DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::NPP_HandleEvent):
- DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
Added NPP_HandleEvent. Just returns 0 at this level.
- DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp: Added.
(WindowlessPaintRectCoordinates::WindowlessPaintRectCoordinates): Call up to the base class.
(WindowlessPaintRectCoordinates::NPP_New): Mark ourselves as windowless.
(WindowlessPaintRectCoordinates::NPP_HandleEvent): Check that the paint rect passed via
WM_PAINT has the expected coordinates.
- DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_HandleEvent): Give the PluginTest a chance to handle the event before doing anything
else.
- DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new file, let VS
resort things.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didFinishLoadForFrame): Added a call to WKBundlePageForceRepaint.
This is roughly equivalent to the call to -[WebView displayIfNeeded] in -[FrameLoadDelegate
webView:didFinishLoadForFrame:] in DumpRenderTree.
- WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::PlatformWebView): Tell the WKView it's in a window so that plugins
can start running.
LayoutTests:
Add a test for the paint rect passed via WM_PAINT to windowless plugins
- platform/win-wk2/platform/win/plugins/windowless-paint-rect-coordinates-expected.txt: Added.
- platform/win/plugins/windowless-paint-rect-coordinates-expected.txt: Added. WebKit1
doesn't pass a paint rect via WM_PAINT, so we have different results there.
- platform/win/plugins/windowless-paint-rect-coordinates.html: Added.
- 7:30 AM Changeset in webkit [79862] by
-
- 2 edits in trunk/Tools
Tell MiniBrowser's WKViews that they're in a window
Fixes <http://webkit.org/b/55364> Plugins don't work in MiniBrowser on Windows
Reviewed by Anders Carlsson.
- MiniBrowser/win/BrowserView.cpp:
(BrowserView::create): Call WKViewSetIsInWindow after creating the view.
- 7:26 AM Changeset in webkit [79861] by
-
- 18 edits1 copy3 moves44 adds36 deletes in trunk
2011-02-28 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
XML without style should render as syntax-highlighted source.
https://bugs.webkit.org/show_bug.cgi?id=13807
Added tests for XML tree view mode. Testing both logic for entering
XML tree view mode and rendering itself.
Tests are disabled for QT since this logic is not yet implemented, see
https://bugs.webkit.org/show_bug.cgi?id=55302
- fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog-expected.txt: Copied from LayoutTests/fast/css/xml-stylesheet-pi-not-in-prolog.xml.
- fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog.xml: Renamed from LayoutTests/fast/css/xml-stylesheet-pi-not-in-prolog.xml.
- fast/encoding/dumpAsText/utf-16-no-bom-expected.txt: Added.
- fast/encoding/dumpAsText/utf-16-no-bom.xml: Renamed from LayoutTests/fast/encoding/utf-16-no-bom.xml.
- http/tests/xmlviewer/dumpAsText/css-stylesheet-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/css-stylesheet.xml: Added.
- http/tests/xmlviewer/dumpAsText/frames-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/frames.html: Added.
- http/tests/xmlviewer/dumpAsText/mathml-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/mathml.xml: Added.
- http/tests/xmlviewer/dumpAsText/resources/css-stylesheet.css: Added. (assertion):
- http/tests/xmlviewer/dumpAsText/resources/frames-helper.xml: Added.
- http/tests/xmlviewer/dumpAsText/resources/xsl.xml: Added.
- http/tests/xmlviewer/dumpAsText/svg-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/svg.xml: Added.
- http/tests/xmlviewer/dumpAsText/wml-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/wml.xml: Added.
- http/tests/xmlviewer/dumpAsText/xhtml-tag-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/xhtml-tag.xml: Added.
- http/tests/xmlviewer/dumpAsText/xlink-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/xlink.xml: Added.
- http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml: Added.
- http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml: Added.
- http/tests/xmlviewer/dumpAsText/xmlviewer-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/xmlviewer.xml: Added.
- http/tests/xmlviewer/dumpAsText/xsl-stylesheet-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml: Added.
- http/tests/xmlviewer/dumpAsText/xul-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/xul.xml: Added.
- platform/chromium-linux/fast/css/xml-stylesheet-pi-not-in-prolog-expected.checksum: Removed.
- platform/chromium-linux/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
- platform/chromium-linux/fast/encoding/utf-16-no-bom-expected.checksum: Removed.
- platform/chromium-linux/fast/encoding/utf-16-no-bom-expected.png: Removed.
- platform/chromium-linux/svg/hixie/error/004-expected.checksum: Removed.
- platform/chromium-linux/svg/hixie/error/004-expected.png: Removed.
- platform/chromium-linux/svg/hixie/error/005-expected.checksum: Removed.
- platform/chromium-linux/svg/hixie/error/005-expected.png: Removed.
- platform/chromium-win/fast/css/xml-stylesheet-pi-not-in-prolog-expected.checksum: Removed.
- platform/chromium-win/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
- platform/chromium-win/fast/css/xml-stylesheet-pi-not-in-prolog-expected.txt: Removed.
- platform/chromium-win/fast/encoding/utf-16-no-bom-expected.checksum: Removed.
- platform/chromium-win/fast/encoding/utf-16-no-bom-expected.png: Removed.
- platform/chromium-win/fast/encoding/utf-16-no-bom-expected.txt: Removed.
- platform/chromium-win/svg/hixie/error/004-expected.checksum: Removed.
- platform/chromium-win/svg/hixie/error/004-expected.png: Removed.
- platform/chromium-win/svg/hixie/error/004-expected.txt: Removed.
- platform/chromium-win/svg/hixie/error/005-expected.checksum: Removed.
- platform/chromium-win/svg/hixie/error/005-expected.png: Removed.
- platform/chromium-win/svg/hixie/error/005-expected.txt: Removed.
- platform/chromium/http/tests/xmlviewer/dumpAsText/mathml-expected.txt: Added.
- platform/gtk/fast/css/xml-stylesheet-pi-not-in-prolog-expected.checksum: Removed.
- platform/gtk/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
- platform/gtk/fast/css/xml-stylesheet-pi-not-in-prolog-expected.txt: Removed.
- platform/gtk/fast/encoding/utf-16-no-bom-expected.checksum: Removed.
- platform/gtk/fast/encoding/utf-16-no-bom-expected.png: Removed.
- platform/gtk/fast/encoding/utf-16-no-bom-expected.txt: Removed.
- platform/gtk/svg/hixie/error/004-expected.checksum: Removed.
- platform/gtk/svg/hixie/error/004-expected.png: Removed.
- platform/gtk/svg/hixie/error/004-expected.txt: Removed.
- platform/gtk/svg/hixie/error/005-expected.checksum: Removed.
- platform/gtk/svg/hixie/error/005-expected.png: Removed.
- platform/gtk/svg/hixie/error/005-expected.txt: Removed.
- platform/mac-leopard/fast/css/xml-stylesheet-pi-not-in-prolog-expected.checksum: Removed.
- platform/mac-leopard/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
- platform/mac-leopard/fast/encoding/utf-16-no-bom-expected.checksum: Removed.
- platform/mac-leopard/fast/encoding/utf-16-no-bom-expected.png: Removed.
- platform/mac-leopard/svg/hixie/error/004-expected.checksum: Removed.
- platform/mac-leopard/svg/hixie/error/004-expected.png: Removed.
- platform/mac-leopard/svg/hixie/error/005-expected.checksum: Removed.
- platform/mac-leopard/svg/hixie/error/005-expected.png: Removed.
- platform/mac/fast/css/xml-stylesheet-pi-not-in-prolog-expected.checksum: Removed.
- platform/mac/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
- platform/mac/fast/css/xml-stylesheet-pi-not-in-prolog-expected.txt: Removed.
- platform/mac/fast/encoding/utf-16-no-bom-expected.checksum: Removed.
- platform/mac/fast/encoding/utf-16-no-bom-expected.png: Removed.
- platform/mac/fast/encoding/utf-16-no-bom-expected.txt: Removed.
- platform/mac/svg/hixie/error/004-expected.checksum: Removed.
- platform/mac/svg/hixie/error/004-expected.png: Removed.
- platform/mac/svg/hixie/error/004-expected.txt: Removed.
- platform/mac/svg/hixie/error/005-expected.checksum: Removed.
- platform/mac/svg/hixie/error/005-expected.png: Removed.
- platform/mac/svg/hixie/error/005-expected.txt: Removed.
- platform/qt/Skipped:
- platform/qt/fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog-expected.txt: Added.
- platform/qt/fast/css/xml-stylesheet-pi-not-in-prolog-expected.txt: Removed.
- platform/qt/fast/encoding/dumpAsText/utf-16-no-bom-expected.txt: Added.
- platform/qt/fast/encoding/utf-16-no-bom-expected.txt: Removed.
- platform/qt/svg/hixie/error/004-expected.txt: Removed.
- platform/qt/svg/hixie/error/005-expected.txt: Removed.
- platform/qt/svg/hixie/error/dumpAsText/004-expected.txt: Added.
- platform/qt/svg/hixie/error/dumpAsText/005-expected.txt: Added.
- svg/hixie/error/dumpAsText/004-expected.txt: Added.
- svg/hixie/error/dumpAsText/004.xml: Renamed from LayoutTests/svg/hixie/error/004.xml.
- svg/hixie/error/dumpAsText/005-expected.txt: Added.
- svg/hixie/error/dumpAsText/005.xml: Renamed from LayoutTests/svg/hixie/error/005.xml.
2011-02-28 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
XML without style should render as syntax-highlighted source.
https://bugs.webkit.org/show_bug.cgi?id=13807
XML tree view mode implemented. If XML does not have any style
information, it is rendered as highlighted source with collapsable
elements.
Tests: fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog.xml
fast/encoding/dumpAsText/utf-16-no-bom.xml
http/tests/xmlviewer/dumpAsText/css-stylesheet.xml
http/tests/xmlviewer/dumpAsText/frames.html
http/tests/xmlviewer/dumpAsText/mathml.xml
http/tests/xmlviewer/dumpAsText/svg.xml
http/tests/xmlviewer/dumpAsText/wml.xml
http/tests/xmlviewer/dumpAsText/xhtml-tag.xml
http/tests/xmlviewer/dumpAsText/xlink.xml
http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml
http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml
http/tests/xmlviewer/dumpAsText/xmlviewer.xml
http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml
http/tests/xmlviewer/dumpAsText/xul.xml
svg/hixie/error/dumpAsText/004.xml
svg/hixie/error/dumpAsText/005.xml
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchUARules):
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::createElement):
- dom/Document.h: (WebCore::Document::usesViewSourceStyles): (WebCore::Document::setUsesViewSourceStyles): (WebCore::Document::sawElementsInKnownNamespaces):
- dom/XMLDocumentParser.h:
- dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd):
- dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::parseProcessingInstruction):
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
- xml/XMLTreeViewer.cpp: Added. (WebCore::XMLTreeViewer::XMLTreeViewer): (WebCore::XMLTreeViewer::hasNoStyleInformation): (WebCore::XMLTreeViewer::transformDocumentToTreeView):
- xml/XMLTreeViewer.h: Added. (WebCore::XMLTreeViewer::~XMLTreeViewer):
- xml/XMLViewer.xsl: Added.
- xml/XSLStyleSheet.h: (WebCore::XSLStyleSheet::createForXMLTreeViewer):
- 7:14 AM Changeset in webkit [79860] by
-
- 2 edits in trunk/LayoutTests
Nvel Feldman <pfeldman@chromium.org>
Not reviewed: skipping new inspector network tests on win.
- platform/win/Skipped:ot reviewed: skipping new inspector network tests on win.
- 6:55 AM Changeset in webkit [79859] by
-
- 2 edits in trunk/Tools
2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Csaba Osztrogonác.
The new QML tests require QML_IMPORT_PATH variable to be set in order to
load the proper plugin.
- Scripts/run-qtwebkit-tests:
- 6:49 AM Changeset in webkit [79858] by
-
- 14 edits in trunk
2011-02-28 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: debugger agents should have same livetime as InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=55369
- inspector/report-protocol-errors-expected.txt:
- inspector/report-protocol-errors.html:
2011-02-28 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: debugger agents should have same livetime as InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=55369
DOM and JS debugger agents are now created in InspectorAgent's constructor and owned
by the agent. Debugger state is cleared on frontend disconnect.
- inspector/Inspector.idl:
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::showScriptsPanel):
- inspector/InspectorAgent.h:
- inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::create): (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::debuggerWasEnabled): (WebCore::InspectorBrowserDebuggerAgent::debuggerWasDisabled): (WebCore::InspectorBrowserDebuggerAgent::disable): (WebCore::InspectorBrowserDebuggerAgent::setFrontend): (WebCore::InspectorBrowserDebuggerAgent::clearFrontend): (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorBrowserDebuggerAgent::clear):
- inspector/InspectorBrowserDebuggerAgent.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::debuggerEnabled): (WebCore::InspectorController::showAndEnableDebugger): (WebCore::InspectorController::disableDebugger):
- inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::create): (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::startUserInitiatedDebugging): (WebCore::InspectorDebuggerAgent::enable): (WebCore::InspectorDebuggerAgent::disable): (WebCore::InspectorDebuggerAgent::enabled): (WebCore::InspectorDebuggerAgent::restore): (WebCore::InspectorDebuggerAgent::setFrontend): (WebCore::InspectorDebuggerAgent::clearFrontend): (WebCore::InspectorDebuggerAgent::setJavaScriptBreakpoint): (WebCore::InspectorDebuggerAgent::removeJavaScriptBreakpoint): (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame): (WebCore::InspectorDebuggerAgent::currentCallFrames): (WebCore::InspectorDebuggerAgent::didParseSource): (WebCore::InspectorDebuggerAgent::clear):
- inspector/InspectorDebuggerAgent.h: (WebCore::InspectorDebuggerAgent::enable): (WebCore::InspectorDebuggerAgent::disable): (WebCore::InspectorDebuggerAgent::Listener::~Listener): (WebCore::InspectorDebuggerAgent::setListener):
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
- inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.enableDebugger): (WebInspector.DebuggerModel.prototype.disableDebugger):
- 6:25 AM Changeset in webkit [79857] by
-
- 6 edits1 copy1 add in trunk/LayoutTests
2011-02-28 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: updated inspector test harness and chromium expectations.
- http/tests/inspector/network/network-size-expected.txt:
- http/tests/inspector/network/network-timing.html:
- http/tests/inspector/network/resources/resource.php:
- platform/chromium/http/tests/inspector/network/network-size-expected.txt: Copied from LayoutTests/http/tests/inspector/network/network-size-expected.txt.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 6:03 AM Changeset in webkit [79856] by
-
- 5 edits in trunk/Source/WebCore
2011-02-28 Renata Hodovan <reni@webkit.org>
Reviewed by Andreas Kling.
FECompositeElement changes doesn't require relayout.
https://bugs.webkit.org/show_bug.cgi?id=55367
When the FECompositeElement receives an update message but the given value remains the same we don't need
to relayout the filter.
No new tests are needed because this modification is covered by the dynamic update tests of FEComposite.
- platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::setOperation): (WebCore::FEComposite::setK1): (WebCore::FEComposite::setK2): (WebCore::FEComposite::setK3): (WebCore::FEComposite::setK4):
- platform/graphics/filters/FEComposite.h:
- svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::setFilterEffectAttribute): (WebCore::SVGFECompositeElement::svgAttributeChanged):
- svg/SVGFECompositeElement.h:
- 5:46 AM Changeset in webkit [79855] by
-
- 2 edits in trunk/Source/WebCore
2011-02-28 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
FrameLoader: Reorder early-returns in checkCompleted()
https://bugs.webkit.org/show_bug.cgi?id=55366
Check allChildrenAreComplete() last, since it's the most expensive.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::checkCompleted):
- 5:24 AM Changeset in webkit [79854] by
-
- 3 edits in trunk/Source/WebCore
2011-02-28 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
Range::processContents needs cleanup
https://bugs.webkit.org/show_bug.cgi?id=51006
Refactored Range::processContents. Extracted childOfCommonRootBeforeOffset from processContents
which is used to find processStart and processEnd respectively. In the case of processStart,
we use the next sibling of the node returned by childOfCommonRootBeforeOffset when m_start is not
the common root because copying m_start's ancestors will result in processing too much contents.
Also extracted processNodes and deleteCharacterData from processContents and processContentsBetweenOffsets.
In addition, lengthOfContentsInNode was modified to return the correct length instead of
numeric_limits<unsigned>::max() because the convention that processContentsBetweenOffsets automatically
corrects the length when endOffset is numeric_limits<unsigned>::max() seemed more confusing than
having two switch statements that need to be consistent.
Historically, lengthOfContentsInNode was introduced in r78413 as a build fix because unsigned const
LengthOfContentsInNode added in r78409 violated WebKit C++ rules and caused build failures on Mac and
other ports.
- dom/Range.cpp: (WebCore::childOfCommonRootBeforeOffset): Extracted from processContents. (WebCore::lengthOfContentsInNode): Added. (WebCore::Range::processContents): Calls childOfCommonRootBeforeOffset, lengthOfContentsInNode, and processNodes. (WebCore::deleteCharacterData): Added. (WebCore::Range::processContentsBetweenOffsets): Calls deleteCharacterData and processNodes. (WebCore::Range::processNodes): Extracted from processContents and processContentsBetweenOffsets. (WebCore::Range::processAncestorsAndTheirSiblings):
- dom/Range.h:
- 3:47 AM Changeset in webkit [79853] by
-
- 2 edits in trunk/Source/WebCore
2011-02-28 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Test harness change follow up.
Consider missing localized string a warning, not an error in the front-end.
- inspector/front-end/inspector.js: (WebInspector.UIString):
- 3:40 AM Changeset in webkit [79852] by
-
- 2 edits in trunk/Source/WebCore
2011-02-28 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
getJNIEnv() passes wrong type to AttachCurrentThread() for JNIEnv argument on Android
https://bugs.webkit.org/show_bug.cgi?id=55218
AttachCurrentThread() in Android's JVM takes a JINEnv
argument.
No new tests, build fix only.
- bridge/jni/JNIUtility.cpp: (JSC::Bindings::getJNIEnv):
- 3:31 AM Changeset in webkit [79851] by
-
- 5 edits in trunk/Source/WebCore
2011-02-28 Renata Hodovan <reni@webkit.org>
Reviewed by Andreas Kling.
FETurbulenceElement changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=55141
When the FETurbulenceElement receives an update message but the given value remains the same we don't need
to relayout the filter.
Besides fix a typo in FETurbulence and change the paramterer type of FETurbulence::setNumOctaves from bool
to int according to the spec.
No new tests are needed because this modification is covered by the dynamic update tests of FETurbulence.
- platform/graphics/filters/FETurbulence.cpp: (WebCore::FETurbulence::FETurbulence): (WebCore::FETurbulence::create): (WebCore::FETurbulence::type): (WebCore::FETurbulence::setType): (WebCore::FETurbulence::setBaseFrequencyY): (WebCore::FETurbulence::setBaseFrequencyX): (WebCore::FETurbulence::setSeed): (WebCore::FETurbulence::setNumOctaves): (WebCore::FETurbulence::setStitchTiles): (WebCore::operator<<):
- platform/graphics/filters/FETurbulence.h:
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::setFilterEffectAttribute): (WebCore::SVGFETurbulenceElement::svgAttributeChanged): (WebCore::SVGFETurbulenceElement::build):
- svg/SVGFETurbulenceElement.h:
- 3:23 AM Changeset in webkit [79850] by
-
- 3 edits in trunk/Source/WebCore
2011-02-28 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: InspectorAgent calls offsetWidth in the middle of painting
https://bugs.webkit.org/show_bug.cgi?id=54597
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::drawElementTitle):
- 3:21 AM Changeset in webkit [79849] by
-
- 2 edits7 adds in trunk/LayoutTests
2011-02-28 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add first network test, improve harness.
https://bugs.webkit.org/show_bug.cgi?id=55306
- http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.assertGreaterOrEqual):
- http/tests/inspector/network/network-size-expected.txt: Added.
- http/tests/inspector/network/network-size.html: Added.
- http/tests/inspector/network/network-timing-expected.txt: Added.
- http/tests/inspector/network/network-timing.html: Added.
- http/tests/inspector/network/resources/resource.php: Added.
- 3:06 AM Changeset in webkit [79848] by
-
- 3 edits1 add in trunk
2011-02-28 Kristian Amlie <kristian.amlie@nokia.com>
Reviewed by Andreas Kling.
Added full webkit module profile and a syncqt profile.
This is for modularized Qt.
[Qt] WebKit patches required to work with a modularized version of Qt
https://bugs.webkit.org/show_bug.cgi?id=53916
- Source/sync.profile: Added.
2011-02-28 Kristian Amlie <kristian.amlie@nokia.com>
Reviewed by Andreas Kling.
Added full webkit module profile and a syncqt profile.
This is for modularized Qt.
[Qt] WebKit patches required to work with a modularized version of Qt
https://bugs.webkit.org/show_bug.cgi?id=53916
- qt_webkit_version.pri:
- 2:49 AM Changeset in webkit [79847] by
-
- 2 edits in trunk/Tools
2011-02-28 Joone Hur <joone.hur@collabora.co.uk>
Unreviewed, fix spelling mistake.
hardware-accelated => hardware-accelerated.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 2:04 AM Changeset in webkit [79846] by
-
- 3 edits in trunk/Tools
2011-02-28 Kristian Amlie <kristian.amlie@nokia.com>
Reviewed by Andreas Kling.
Made sure that the build-webkit --qmake argument is always respected.
Previously, it would be respected during the build, but not during
the early feature detection. The build would also fail if qmake was
not in your path, even if you specified --qmake with a valid qmake
binary.
[Qt] WebKit patches required to work with a modularized version of Qt
https://bugs.webkit.org/show_bug.cgi?id=53916
- Scripts/build-webkit:
- Scripts/webkitdirs.pm:
- 12:45 AM Changeset in webkit [79845] by
-
- 2 edits in trunk/Source/WebCore
2011-02-28 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Kent Tamura.
Bug 55355 - TextIterator should not be a friend of RenderTextControl
https://bugs.webkit.org/show_bug.cgi?id=55355
Remove need for 'friend' clause by making innerTextElement() public.
No new tests. (simple refactoring)
- rendering/RenderTextControl.h:
Feb 27, 2011:
- 11:30 PM Changeset in webkit [79844] by
-
- 3 edits2 adds in trunk
2011-02-27 Aparna Nandyal <aparna.nand@wipro.com>
Reviewed by Antonio Gomes.
[Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
https://bugs.webkit.org/show_bug.cgi?id=53917
The bug got fixed by other changes. Adding test case to avoid
regressions in the future.
- fast/overflow/horizontal-scroll-after-back-expected.txt: Added.
- fast/overflow/horizontal-scroll-after-back.html: Added.
2011-02-27 Aparna Nandyal <aparna.nand@wipro.com>
Reviewed by Antonio Gomes.
[Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
https://bugs.webkit.org/show_bug.cgi?id=53917
Adding test case to check the scenario to avoid regressions in the
future.
- tests/qwebframe/tst_qwebframe.cpp:
- 11:28 PM Changeset in webkit [79843] by
-
- 3 edits in trunk/Source/WebKit/chromium
2011-02-27 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Darin Fisher.
Pass frame history state in the context menu parameters.
https://bugs.webkit.org/show_bug.cgi?id=55232
- public/WebContextMenuData.h:
- src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
- 10:53 PM Changeset in webkit [79842] by
-
- 4 edits in trunk/Source/WebCore
2011-02-27 Patrick Gansterer <Patrick Gansterer>
Reviewed by Darin Adler.
Remove registerBaseEncodingNames and registerBaseCodecs from TextCodecWinCE
https://bugs.webkit.org/show_bug.cgi?id=55317
This functions are obsolete, since r78499 added TextCodecUTF8.
Also remove the "fast path" for UTF-8 data, because we now have a separate TextCodec.
- platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps):
- platform/text/wince/TextCodecWinCE.cpp:
- platform/text/wince/TextCodecWinCE.h:
- 9:49 PM Changeset in webkit [79841] by
-
- 3 edits in trunk/Tools
2011-02-27 Ojan Vafai <ojan@chromium.org>
Fix failing tests from http://trac.webkit.org/changeset/79837.
- Scripts/webkitpy/layout_tests/layout_package/printing.py: This was just a mistake that would break if someone tried printing with this configuration.
- Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: Method signature changed. Didn't notice that this method was being calling in a unittest.
- 9:18 PM Changeset in webkit [79840] by
-
- 6 edits5 deletes in trunk/Tools
2011-02-24 Hayato Ito <hayato@chromium.org>
Reviewed by Eric Seidel.
[NRWT] Remove test_types/* classes.
This is the last patch in the series of efforts which tried to remove test_types classes.
A single_test_runner module will take over responsibilities of test_type classes.
From this patch, we won't display statistics per test_type even if a '--verbose' option is given.
- Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
- Scripts/webkitpy/layout_tests/layout_package/test_results.py:
- Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
- Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
- Scripts/webkitpy/layout_tests/test_types/init.py: Removed.
- Scripts/webkitpy/layout_tests/test_types/image_diff.py: Removed.
- Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Removed.
- Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/test_types/text_diff.py: Removed.
- 8:35 PM Changeset in webkit [79839] by
-
- 2 edits in trunk/Source/WebKit2
Force dictionary popup to use overlay type
<rdar://problem/9052483>
https://bugs.webkit.org/show_bug.cgi?id=55337
Reviewed by Dan Bernstein.
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup): As this is only
used for the hot key version of the dictionary popup, force the overlay
style.
- 8:00 PM Changeset in webkit [79838] by
-
- 8 edits in trunk/Source/WebKit/efl
2011-02-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kent Tamura.
[EFL] Restore parameters of efl header files.
https://bugs.webkit.org/show_bug.cgi?id=55292
Restore parameters in efl header files.
- ewk/ewk_frame.h:
- ewk/ewk_tiled_backing_store.h:
- ewk/ewk_tiled_matrix.h:
- ewk/ewk_tiled_model.h:
- ewk/ewk_view.cpp: (ewk_view_pre_render_relative_radius):
- ewk/ewk_view.h:
- ewk/ewk_window_features.h:
- 7:55 PM Changeset in webkit [79837] by
-
- 7 edits in trunk/Tools
2011-02-25 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
Change results.json format to the one used by unexpected_results.json
https://bugs.webkit.org/show_bug.cgi?id=52267
Also add runtimes in milliseconds to the JSON and make the output format more compact.
Named the file full_results.json to avoid conflicting with the results.json
file the test-results server currently serves up.
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/printing.py:
- Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
- Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
- 7:39 PM Changeset in webkit [79836] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
2011-02-25 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
[codereviewtool] fix expand links on git diffs
https://bugs.webkit.org/show_bug.cgi?id=55208
In git diffs, we don't have a "revision" span at the end
of each FileDiff.
- code-review.js:
- 7:11 PM Changeset in webkit [79835] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-27 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement WTF::randomNumber in terms of WTF::cryptographicallyRandomNumber when possible
https://bugs.webkit.org/show_bug.cgi?id=55326
Currently, randomNumber does a bunch of platform-specific work that to
get a cryptographic randomness when available. Instead, we should use
cryptographicallyRandomNumber, which abstracts this work.
Unfortunately, we can't remove all of the WTF::randomNumber
implementation because not every port has access to cryptographically
random numbers.
- wtf/RandomNumber.cpp: (WTF::randomNumber):
- 5:33 PM Changeset in webkit [79834] by
-
- 3 edits in trunk/Source/WebCore
2011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Sam Weinig.
Use OwnPtr to handle the memory of RenderBlock::m_floatingObjects and RenderBlock::m_positionedObjects
https://bugs.webkit.org/show_bug.cgi?id=55327
Refactor RenderBlock to use OwnPtr for m_floatingObjects and m_positionedObjects so we do not have
to release the memory manually.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::~RenderBlock): (WebCore::RenderBlock::selectionGaps): (WebCore::RenderBlock::insertPositionedObject): (WebCore::RenderBlock::insertFloatingObject): (WebCore::RenderBlock::addOverhangingFloats): (WebCore::RenderBlock::addIntrudingFloats):
- rendering/RenderBlock.h: (WebCore::RenderBlock::positionedObjects):
- 4:10 PM Debugging With Visual Studio edited by
- Fix misspelled word; "pauses all processes" should be "pause all … (diff)
- 3:28 PM Changeset in webkit [79833] by
-
- 2 edits in trunk/Tools
Followup fix to r79827
- DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::webViewAddMessageToConsole): Replaced call to urlSuitableForTestResult with
lastPathComponent. This matches what we did here before r79827, and matches Mac.
- 3:18 PM Changeset in webkit [79832] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] [WK2] QGraphicsWKView::showContextMenu() should be public
https://bugs.webkit.org/show_bug.cgi?id=55330
Reviewed by Kenneth Rohde Christiansen.
Move QGraphicsWKView::showContextMenu() to the public API. Add documentation
on its use.
- UIProcess/API/qt/qgraphicswkview.cpp:
- UIProcess/API/qt/qgraphicswkview.h:
- 2:14 PM Changeset in webkit [79831] by
-
- 2 edits in trunk/Tools
Make bisect-builds print a trac link for the regression range
https://bugs.webkit.org/show_bug.cgi?id=55331
Reviewed by Adam Roben.
- Scripts/bisect-builds:
- 1:51 PM Changeset in webkit [79830] by
-
- 2 edits in trunk/Tools
Use iswalpha instead of isalpha when dealing with wchar_ts in EditingDelegate
Fixes <http://webkit.org/b/55062> <rdar://problem/9059907> Crash beneath
EditingDelegate::checkSpellingOfString when running fast/forms/input-text-maxlength.html or
fast/forms/input-text-paste-maxlength.html on Windows with full page heap enabled
Reviewed by Anders Carlsson.
- DumpRenderTree/win/EditingDelegate.cpp:
(indexOfFirstWordCharacter):
(wordLength):
Use iswalpha instead of isalpha, since TCHAR is really just wchar_t.
- 1:29 PM Changeset in webkit [79829] by
-
- 1 edit1 add in trunk/LayoutTests
Add Windows expected failure results for fast/events/pageshow-pagehide-on-back-cached.html
<http://webkit.org/b/55329> tracks the failure.
- platform/win/fast/events/pageshow-pagehide-on-back-cached-expected.txt: Added.
- 1:29 PM Changeset in webkit [79828] by
-
- 1 edit1 add in trunk/LayoutTests
Add Windows expected failure results for fast/images/support-broken-image-delegate.html
<http://webkit.org/b/55324> tracks the failure.
- platform/win/fast/images/support-broken-image-delegate-expected.txt: Added.
- 1:16 PM Changeset in webkit [79827] by
-
- 4 edits in trunk/Tools
Make ResourceLoadDelegate print URLs relative to the main resource on Windows
This matches Mac. (In fact, the code was ported from Mac!)
Fixes <http://webkit.org/b/55328> URLs printed by ResourceLoadDelegate on Windows don't
match Mac
Reviewed by Anders Carlsson.
- DumpRenderTree/win/DumpRenderTree.cpp:
(substringFromIndex): Added. Emulates -[NSString substringFromIndex:].
(urlSuitableForTestResult): Ported code from -[NSURL(DRTExtras)
_drt_descriptionSuitableForTestResult].
(cfStringRefToWString): Moved here from LayoutTestControllerWin.cpp.
- DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of cfStringRefToWString.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: Moved cfStringRefToWString to
DumpRenderTree.cpp.
- 11:38 AM Changeset in webkit [79826] by
-
- 2 edits in trunk/Source/WebKit/qt
2011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
[Qt] Reference the documentation of the WebKit bridge from QWebFrame::addToJavaScriptWindowObject()
https://bugs.webkit.org/show_bug.cgi?id=55322
Documentation update, add a reference to the QtWebKit bridge page.
- Api/qwebframe.cpp:
- 11:00 AM Debugging With Visual Studio edited by
- Removed unnecessary ".dll" suffixes (diff)
- 11:00 AM Debugging With Visual Studio edited by
- Updated CFShow instructions (diff)
- 10:59 AM Changeset in webkit [79825] by
-
- 9 edits3 deletes in trunk/Source/WebCore
Eliminate DeprecatedPtrList
https://bugs.webkit.org/show_bug.cgi?id=17425
Reviewed by Andreas Kling.
Remove the implementation of DeprecatedPtrList and all its references
from the build systems.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.order:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/DeprecatedPtrList.h: Removed.
- platform/DeprecatedPtrListImpl.cpp: Removed.
- platform/DeprecatedPtrListImpl.h: Removed.
- 10:25 AM Changeset in webkit [79824] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove Windows-specific html5lib results
I suspect these haven't been needed since r77781.
- platform/win/html5lib/runner-expected.txt: Removed.
- 10:15 AM Changeset in webkit [79823] by
-
- 2 edits in trunk/Tools
Change the order of Chang Shu's email addresses so the first one is their Bugzilla username
This makes Bugzilla autocompletion work correctly.
- Scripts/webkitpy/common/config/committers.py:
- 10:05 AM Changeset in webkit [79822] by
-
- 3 edits in trunk/Source/WebKit2
2011-02-27 Alejandro G. Castro <alex@igalia.com>
Unreviewed, fixed GTK compilation after r79806.
- UIProcess/gtk/WebView.cpp: (WebKit::WebView::didFinishLoadingDataForCustomRepresentation):
- UIProcess/gtk/WebView.h:
- 10:04 AM Changeset in webkit [79821] by
-
- 2 edits in trunk/LayoutTests
Skip fast/frames/iframe-plugin-load-remove-document-crash.html on Windows
It's been crashing since it was added in r79808. <http://webkit.org/b/55307> tracks the
failure.
- platform/win/Skipped:
- 9:59 AM Changeset in webkit [79820] by
-
- 4 edits in trunk
2011-02-27 Patrick Gansterer <Patrick Gansterer>
Reviewed by Andreas Kling.
[Qt] fast/loader/user-stylesheet-fast-path.html fails
https://bugs.webkit.org/show_bug.cgi?id=50911
- platform/qt/Skipped: Unskip test which is now passing.
2011-02-27 Patrick Gansterer <Patrick Gansterer>
Reviewed by Andreas Kling.
[Qt] fast/loader/user-stylesheet-fast-path.html fails
https://bugs.webkit.org/show_bug.cgi?id=50911
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setUserStyleSheetLocation): Use QUrl::fromEncoded since the passed string is already encoded.
- 9:29 AM Changeset in webkit [79819] by
-
- 2 edits in trunk/Tools
Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving
Windows 7 (and maybe Vista?) launches the post-mortem debugger with a working directory that
is different from old-run-webkit-test's. Because of this, the path to the crash log file
(which is relative to $testResultsDirectory) must be an absolute path. See the bug for more
details.
Fixes <http://webkit.org/b/55318> Crash logs aren't saved on Windows 7 when a relative
--results-directory path is used (like on the test slaves)
Reviewed by Dan Bernstein.
- Scripts/old-run-webkit-tests: Moved the call to setUpWindowsCrashLogSaving after we've
made $testResultsDirectory an absolute path.
- 8:37 AM QtWebKitDocContrib edited by
- Update some references since the code have moved. (diff)
- 7:56 AM Changeset in webkit [79818] by
-
- 3 edits in trunk/Source/WebCore
2011-02-27 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Use WTF ref counting for FontPlatformDataPrivate
https://bugs.webkit.org/show_bug.cgi?id=55303
Make FontPlatformDataPrivate a RefCounted<FPDP>.
Incidentally fixes an uninitialized member bug in FontPlatformData().
- platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::font): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::family): (WebCore::FontPlatformData::bold): (WebCore::FontPlatformData::italic): (WebCore::FontPlatformData::smallCaps): (WebCore::FontPlatformData::pixelSize):
- platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::toQFontWeight): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::hash):
- 7:51 AM Changeset in webkit [79817] by
-
- 6 edits in trunk/Source
Eliminate DeprecatedPtrList from RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=54972
Patch by Benjamin Poulain <ikipou@gmail.com> on 2011-02-27
Reviewed by Darin Adler.
Source/JavaScriptCore:
Add methods find() and contains() using an adaptor to ListHashSet.
Those method are like the one of HashSet, they allow to find objects
based on a different key than the one used to define the set.
Add convenience methods for direct access to the head and tail of the list.
Those methods are providing similar API/behavior as Vector.
- wtf/ListHashSet.h:
(WTF::::first):
(WTF::::last):
(WTF::::removeLast):
(WTF::ListHashSetTranslatorAdapter::hash):
(WTF::ListHashSetTranslatorAdapter::equal):
(WTF::::find):
(WTF::::contains):
Source/WebCore:
Refactor RenderBlock to get rid of the DeprecatedPtrList.
The floating objects are stored in a ListHashSet.
Refactoring covered by existing test.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::positionNewFloatOnLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::containsFloat):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatingObjectHashFunctions::hash):
(WebCore::RenderBlock::FloatingObjectHashFunctions::equal):
(WebCore::RenderBlock::FloatingObjectHashTranslator::hash):
(WebCore::RenderBlock::FloatingObjectHashTranslator::equal):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::matchedEndLine):
Feb 26, 2011:
- 10:53 PM Changeset in webkit [79816] by
-
- 2 edits in trunk/Source/WebCore
2011-02-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
<input value="type=submit"> throws a warning (“HTML parse error”)
https://bugs.webkit.org/show_bug.cgi?id=55120
This patch removes parse error messages from the HTML parser. These
messages are displayed at the wrong times, aren't tested, and aren't
helpful. We'll try again with some more informative messages and
better testing.
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::parseError):
- 7:38 PM Changeset in webkit [79815] by
-
- 4 edits in trunk/Source/WebCore
2011-02-26 Patrick Gansterer <Patrick Gansterer>
Reviewed by Alexey Proskuryakov.
Remove registerBaseEncodingNames and registerBaseCodecs from TextCodecBrew
https://bugs.webkit.org/show_bug.cgi?id=55309
This functions are obsolete, since r78499 added TextCodecUTF8.
- platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps):
- platform/text/brew/TextCodecBrew.cpp:
- platform/text/brew/TextCodecBrew.h:
- 7:28 PM Changeset in webkit [79814] by
-
- 2 edits in trunk
2011-02-26 Dihan Wickremasuriya <dihan.wickremasuriya@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] [Symbian] Disable dependency to a specific version of a Qt package for
non-production builds.
https://bugs.webkit.org/show_bug.cgi?id=55313
- Source/WebKit.pri:
- 6:45 PM Changeset in webkit [79813] by
-
- 2 edits in trunk/Tools
2011-02-26 Dominic Mazzoni <dmazzoni@google.com>
Reviewed by Adam Barth.
m_dumpAccessibilityNotifications should be initialized.
https://bugs.webkit.org/show_bug.cgi?id=54874
- DumpRenderTree/chromium/AccessibilityController.cpp: (AccessibilityController::AccessibilityController):
- 3:03 PM Changeset in webkit [79812] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-26 Patrick Gansterer <Patrick Gansterer>
Reviewed by Andreas Kling.
Add support for DragonFly BSD
https://bugs.webkit.org/show_bug.cgi?id=54407
DragonFly BSD is based on FreeBSD, so handle it like FreeBSD.
- wtf/Platform.h:
- 2:55 PM Changeset in webkit [79811] by
-
- 3 edits in trunk/LayoutTests
2011-02-26 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Skip the test on QT, GTK until we can figure out the plugin load problem.
https://bugs.webkit.org/show_bug.cgi?id=55307
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 2:40 PM Changeset in webkit [79810] by
-
- 3 edits2 adds in trunk
2011-02-26 Justin Schuh <jschuh@chromium.org>
Reviewed by Darin Adler.
Delay firing of mutation events while setting attribute values
https://bugs.webkit.org/show_bug.cgi?id=55199
- fast/dom/attribute-change-on-mutate-expected.txt: Added.
- fast/dom/attribute-change-on-mutate.html: Added.
2011-02-26 Justin Schuh <jschuh@chromium.org>
Reviewed by Darin Adler.
Delay firing of mutation events while setting attribute values
https://bugs.webkit.org/show_bug.cgi?id=55199
Test: fast/dom/attribute-change-on-mutate.html
- dom/Attr.cpp: (WebCore::Attr::setValue):
- 2:38 PM Changeset in webkit [79809] by
-
- 3 edits in trunk/Source/WebCore
2011-02-26 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Andreas Kling.
[Qt] Notify HTMLMediaElement when MediaPlayerPrivateQt's playback state gets changed
https://bugs.webkit.org/show_bug.cgi?id=55252
Need to invoke a callback function to notify the HTMLMediaElement
when MediaPlayerPrivateQt's playback state gets changed.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): Set a flag to ignore the playback state change for pre-roll (WebCore::MediaPlayerPrivateQt::commitLoad): Call playbackStateChanged() to notify HTMLMediaElement (WebCore::MediaPlayerPrivateQt::stateChanged):
- platform/graphics/qt/MediaPlayerPrivateQt.h:
- 1:26 PM Changeset in webkit [79808] by
-
- 3 edits2 adds in trunk
2011-02-25 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Tests that removing a document during a plugin load does not result
in crash.
https://bugs.webkit.org/show_bug.cgi?id=55289
- fast/frames/iframe-plugin-load-remove-document-crash-expected.txt: Added.
- fast/frames/iframe-plugin-load-remove-document-crash.html: Added.
2011-02-25 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
When plugin document parser finishes parsing, it runs the raw
document's parser finish functions which call the pending document
onload events that removes the frame from underneath. So, we protect
frame (and hence frameloader) in DocumentLoader::commitLoad.
https://bugs.webkit.org/show_bug.cgi?id=55289
Test: fast/frames/iframe-plugin-load-remove-document-crash.html
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitLoad):
- 1:02 PM Changeset in webkit [79807] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-26 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Asynchronous response to FramePolicyListener is not finishing the load
https://bugs.webkit.org/show_bug.cgi?id=55305
<rdar://problem/9044356>
Always initialize the receivedPolicyAction reply parameter.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::decidePolicyForNavigationAction): (WebKit::WebPageProxy::decidePolicyForMIMEType):
- 12:44 PM Changeset in webkit [79806] by
-
- 16 edits in trunk/Source/WebKit2
2011-02-26 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
DidFinishLoadingDataForCustomRepresentation should pass along the suggested filename
https://bugs.webkit.org/show_bug.cgi?id=55304
- UIProcess/API/mac/PDFViewController.h:
- UIProcess/API/mac/PDFViewController.mm: (WebKit::PDFViewController::setPDFDocumentData):
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
- UIProcess/API/mac/WKView.mm: (-[WKView _didFinishLoadingDataForCustomRepresentationWithSuggestedFilename:dataReference:CoreIPC::]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::didFinishLoadingDataForCustomRepresentation):
- UIProcess/API/qt/qwkpage_p.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didFinishLoadingDataForCustomRepresentation):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/win/WebView.cpp: (WebKit::WebView::didFinishLoadingDataForCustomRepresentation):
- UIProcess/win/WebView.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::finishedLoading):
- 12:14 PM Changeset in webkit [79805] by
-
- 18 edits31 deletes in trunk
2011-02-26 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: rolling out 79799 and 79804 for breaking xml tests on mac.
- 11:58 AM Changeset in webkit [79804] by
-
- 4 edits in trunk
2011-02-26 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: follow up to r79799. Fixing WinCE+Efl, mute new tests on Qt.
https://bugs.webkit.org/show_bug.cgi?id=55302
- CMakeLists.txt:
- platform/qt/Skipped:
- 11:10 AM Changeset in webkit [79803] by
-
- 25 edits in trunk/Source/WebKit2
2011-02-26 Anders Carlsson <andersca@apple.com>
Reviewed by Oliver Hunt.
DrawingArea should not be reference counted
https://bugs.webkit.org/show_bug.cgi?id=55284
- Shared/DrawingAreaInfo.h:
- Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode): (WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy): (WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible): (WebKit::ChunkedUpdateDrawingAreaProxy::update): (WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
- UIProcess/ChunkedUpdateDrawingAreaProxy.h:
- UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::DrawingAreaProxy):
- UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::type):
- UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
- UIProcess/TiledDrawingAreaProxy.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveSyncMessage): (WebKit::WebPageProxy::creationParameters):
- WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
- WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea): (WebKit::ChunkedUpdateDrawingArea::display): (WebKit::ChunkedUpdateDrawingArea::setSize): (WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):
- WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
- WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create): (WebKit::DrawingArea::DrawingArea):
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::create): (WebKit::DrawingAreaImpl::DrawingAreaImpl):
- WebProcess/WebPage/DrawingAreaImpl.h:
- WebProcess/WebPage/TiledDrawingArea.cpp: (WebKit::TiledDrawingArea::TiledDrawingArea):
- WebProcess/WebPage/TiledDrawingArea.h:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRect):
- WebProcess/WebPage/WebPage.h:
- 11:08 AM Changeset in webkit [79802] by
-
- 5 edits1 copy in trunk/Source/WebKit/gtk
2011-02-26 Lukasz Slachciak <l.slachciak@samsung.com>
Reviewed by Xan Lopez.
[GTK] Implemented API to set/get web application cache directory path database.
- GNUmakefile.am: Add webkitapplicationcache.h file.
- webkit/webkit.h: Add webkitapplicationcache.h file.
- webkit/webkitapplicationcache.cpp: definition of API setting and getting web application cache directory path database. (webkit_application_cache_get_database_directory_path): (webkit_application_cache_set_database_directory_path):
- webkit/webkitapplicationcache.h: Added new API file for setting and getting web application cache directory path database.
- webkit/webkitglobals.cpp: (webkitInit): use webkit_application_cache_set_database_directory_path to set default web application cache directory path database.
- 11:06 AM Changeset in webkit [79801] by
-
- 2 edits in trunk/LayoutTests
2011-02-26 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update.
Add failing expectation for fast/images/support-broken-image-delegate.html
- platform/chromium/test_expectations.txt:
- 11:00 AM Changeset in webkit [79800] by
-
- 2 edits in trunk/LayoutTests
2011-02-26 Mihai Parparita <mihaip@chromium.org>
Unreviewed update of the Chromium html5lib expectations after r79765
(diff matches the base expectations change).
- platform/chromium/html5lib/runner-expected.txt:
- 10:54 AM Changeset in webkit [79799] by
-
- 17 edits36 adds in trunk
2011-02-25 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
XML without style should render as syntax-highlighted source.
https://bugs.webkit.org/show_bug.cgi?id=13807
Added tests for XML tree view mode. Testing both logic for entering
XML tree view mode and rendering itself.
- http/tests/xmlviewer/dumpAsText/css-stylesheet-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/css-stylesheet.xml: Added.
- http/tests/xmlviewer/dumpAsText/frames-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/frames.html: Added.
- http/tests/xmlviewer/dumpAsText/mathml-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/mathml.xml: Added.
- http/tests/xmlviewer/dumpAsText/resources/css-stylesheet.css: Added. (assertion):
- http/tests/xmlviewer/dumpAsText/resources/frames-helper.xml: Added.
- http/tests/xmlviewer/dumpAsText/resources/xsl.xml: Added.
- http/tests/xmlviewer/dumpAsText/svg-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/svg.xml: Added.
- http/tests/xmlviewer/dumpAsText/wml-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/wml.xml: Added.
- http/tests/xmlviewer/dumpAsText/xhtml-tag-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/xhtml-tag.xml: Added.
- http/tests/xmlviewer/dumpAsText/xlink-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/xlink.xml: Added.
- http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml: Added.
- http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml: Added.
- http/tests/xmlviewer/dumpAsText/xmlviewer-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/xmlviewer.xml: Added.
- http/tests/xmlviewer/dumpAsText/xsl-stylesheet-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml: Added.
- http/tests/xmlviewer/dumpAsText/xul-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/xul.xml: Added.
- platform/chromium/http/tests/xmlviewer/dumpAsText/mathml-expected.txt: Added.
2011-02-25 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
XML without style should render as syntax-highlighted source.
https://bugs.webkit.org/show_bug.cgi?id=13807
XML tree view mode implemented. If XML does not have any style
information, it is rendered as highlighted source with collapsable
elements.
Tests: http/tests/xmlviewer/dumpAsText/css-stylesheet.xml
http/tests/xmlviewer/dumpAsText/frames.html
http/tests/xmlviewer/dumpAsText/mathml.xml
http/tests/xmlviewer/dumpAsText/svg.xml
http/tests/xmlviewer/dumpAsText/wml.xml
http/tests/xmlviewer/dumpAsText/xhtml-tag.xml
http/tests/xmlviewer/dumpAsText/xlink.xml
http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml
http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml
http/tests/xmlviewer/dumpAsText/xmlviewer.xml
http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml
http/tests/xmlviewer/dumpAsText/xul.xml
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchUARules):
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::createElement):
- dom/Document.h: (WebCore::Document::usesViewSourceStyles): (WebCore::Document::setUsesViewSourceStyles): (WebCore::Document::sawElementsInKnownNamespaces):
- dom/XMLDocumentParser.h:
- dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd):
- dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::parseProcessingInstruction):
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
- xml/XMLTreeViewer.cpp: Added. (WebCore::XMLTreeViewer::XMLTreeViewer): (WebCore::XMLTreeViewer::hasNoStyleInformation): (WebCore::XMLTreeViewer::transformDocumentToTreeView):
- xml/XMLTreeViewer.h: Added. (WebCore::XMLTreeViewer::~XMLTreeViewer):
- xml/XMLViewer.xsl: Added.
- xml/XSLStyleSheet.h: (WebCore::XSLStyleSheet::createFromString):
- 10:26 AM Changeset in webkit [79798] by
-
- 2 edits in trunk/Source/WebKit/gtk/po
2011-02-26 Christian Dywan <christian@lanedo.com>
Reviewed by Andreas Kling.
Untranslated network error messages
https://bugs.webkit.org/show_bug.cgi?id=55223
- POTFILES: Add FrameLoaderClientGtk.cpp.
- 9:29 AM Changeset in webkit [79797] by
-
- 4 edits in trunk/LayoutTests
2011-02-26 Adam Klein <adamk@chromium.org>
Reviewed by James Robinson.
[chromium] Update op-get-entry filesystem test to match spec
https://bugs.webkit.org/show_bug.cgi?id=55263
Chromium behavior changed in r76098. This patch updates WebKit test
to match. Both now match the spec, which says of TYPE_MISMATCH_ERR:
user agent MUST use this code when the user has attempted to look up
a file or directory, but the Entry found is of the wrong type
Reference: http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#error-code-descriptions
- fast/filesystem/op-get-entry-expected.txt:
- fast/filesystem/resources/op-get-entry.js: GetFile/GetDirectory now expected to return TYPE_MISMATCH_ERR if requesting a non-file/non-directory.
- platform/chromium/test_expectations.txt: Allow op-get-entry to pass while waiting for Chromium roll.
- 9:26 AM Changeset in webkit [79796] by
-
- 2 edits in trunk/LayoutTests
2011-02-26 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations change.
Remove failing Snow Leopard expectations for tests that were fixed by
r79754.
Skip more viewport tests added by r79783.
- platform/chromium/test_expectations.txt:
- 9:12 AM Changeset in webkit [79795] by
-
- 4 edits in trunk/Source/WebCore
2011-02-26 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Enable usage of synchronous HTTP feature in Qt
https://bugs.webkit.org/show_bug.cgi?id=37191
Currently, we spin an event loop when doing synchronous calls to
wait for completion. This patch uses synchronous requests in Qt,
if available, and spins the event loop as a fallback solution.
Based on work by Simon Hausmann and Peter Hartmann.
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::start):
- platform/network/qt/QNetworkReplyHandler.h:
- platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::setReplyFinished): (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail): (WebCore::ResourceHandle::loadResourceSynchronously):
- 9:02 AM Changeset in webkit [79794] by
-
- 3 edits2 adds in trunk
2011-02-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
REGRESSION(r79398): Webkit crash on dojo theme tester page
https://bugs.webkit.org/show_bug.cgi?id=55290
Added a test to ensure WebKit does not crash when querying style value without selection.
- editing/execCommand/value-without-selection-crash-expected.txt: Added.
- editing/execCommand/value-without-selection-crash.html: Added.
2011-02-26 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
REGRESSION(r79398): Webkit crash on dojo theme tester page
https://bugs.webkit.org/show_bug.cgi?id=55290
The bug was caused by selectionStartCSSPropertyValue's not considering the possibility
of selectionStartStyle() returning a null pointer. Fixed it by adding a null check.
Test: editing/execCommand/value-without-selection-crash.html
- editing/Editor.cpp: (WebCore::Editor::selectionStartCSSPropertyValue):
- 8:31 AM Changeset in webkit [79793] by
-
- 30 edits in trunk
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
No new tests. (no code affected, just exporting a method for DumpRenderTree use)
- WebCore.exp.in:
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
Added clearOpener method to WebFrame.
- public/WebFrame.h:
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::clearOpener):
- src/WebFrameImpl.h:
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
Added clearOpener method to DumpRenderTreeSupportGTK.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::clearOpener):
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
Added clearOpener method to WebFramePrivate.
- WebView/WebFrame.mm: (-[WebFrame _clearOpener]):
- WebView/WebFramePrivate.h:
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
Added clearOpener method to DumpRenderTreeSupportQT.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::clearOpener):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
Added clearOpener method to IWebFramePrivate.
Touched WebKit.idl to trigger build scripts.
- Interfaces/IWebFramePrivate.idl:
- Interfaces/WebKit.idl:
- WebFrame.cpp: (WebFrame::clearOpener):
- WebFrame.h:
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
Added clearOpener method to WKBundleWebFramePrivate.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameClearOpener):
- WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
Added clearOpener() calls between tests.
Some tests are using window.open() to change current window location.
This changes window.opener property whose nullity is checked before
showing xml viewer.
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController):
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
- DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::reset):
- 8:20 AM Changeset in webkit [79792] by
-
- 3 edits in trunk/Source/WebKit/efl
2011-02-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kent Tamura.
[EFL] Replace WTF_USE_SOUP macro with USE(SOUP)
https://bugs.webkit.org/show_bug.cgi?id=55296
ewk_cookies.cpp and ewk_main.cpp are using WTF_USE_SOUP macro.
So, according to policy decision macro usage, the macro needs to
be changed with USE(SOUP).
- ewk/ewk_cookies.cpp: (ewk_cookies_file_set): (ewk_cookies_clear): (ewk_cookies_get_all): (ewk_cookies_cookie_del): (ewk_cookies_cookie_free): (ewk_cookies_policy_set): (ewk_cookies_policy_get):
- ewk/ewk_main.cpp: (_ewk_init_body):
- 7:52 AM Changeset in webkit [79791] by
-
- 4 edits in trunk
2011-02-26 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
[Qt] Fix the focus in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=55288
Implement basic functionality for focus in QWKPagePrivate.
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::isViewWindowActive): (QWKPagePrivate::isViewFocused): (QWKPagePrivate::isViewVisible):
2011-02-26 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
[Qt] Fix the focus in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=55288
Give focus to the web view when a load starts.
- MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::urlChanged):
- 7:48 AM Changeset in webkit [79790] by
-
- 2 edits in trunk/Source/WebCore
2011-02-26 Jia Pu <jpu@apple.com>
Reviewed by Dan Bernstein.
On Mac, need to remove misspell underline in Editor::learnSpelling().
https://bugs.webkit.org/show_bug.cgi?id=55251
This change makes sure that the misspelling markers are removed after the word is learned.
- editing/Editor.cpp: (WebCore::Editor::learnSpelling):
- 7:38 AM Changeset in webkit [79789] by
-
- 2 edits in trunk/Tools
2011-02-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Adam Barth.
[EFL] Add coding style exceptions for EFL port
https://bugs.webkit.org/show_bug.cgi?id=54733
The EFL APIs use EFL naming style, which includes both lower-cased and camel-cased,
underscore-sparated values. But, style checking rule have found parameter_name errors
in efl directories so far.
- Scripts/webkitpy/style/checker.py: Add prameter_name rule's exception and efl directories.
- 7:32 AM Changeset in webkit [79788] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-26 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
JavaScriptCore should use the xcconfig file instead of importing that information into GYP
https://bugs.webkit.org/show_bug.cgi?id=55282
Technically, this breaks the build because I had removed one of the
warnings in this config file, but this change seems like an
improvement.
- gyp/JavaScriptCore.gyp:
- 7:29 AM Changeset in webkit [79787] by
-
- 3 edits in trunk/Tools
2011-02-26 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
check-webkit-style should check for spaces after periods in comments
https://bugs.webkit.org/show_bug.cgi?id=55253
- Scripts/webkitpy/style/checkers/cpp.py: Added the check.
- Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests and fixed the name of one related test.
- 7:00 AM Changeset in webkit [79786] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-02-26 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: rolling chromium DEPS.
- DEPS:
- 6:45 AM Changeset in webkit [79785] by
-
- 2 edits in trunk/Websites/webkit.org
2011-02-26 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
Add style guidelines about comments from the unwritten rules email.
https://bugs.webkit.org/show_bug.cgi?id=55272
- coding/coding-style.html: Added the guidelines.
- 6:40 AM Changeset in webkit [79784] by
-
- 8 edits in trunk
2011-02-26 Rik Cabanier <cabanier@adobe.com>
Reviewed by David Hyatt.
Fix that allows fixed length values to be floating point
https://bugs.webkit.org/show_bug.cgi?id=52699
Transitions now return matrices in floating point. 2 of the transition tests were failing
because they expected integer values.
- transitions/matched-transform-functions.html:
- transitions/retargetted-transition.html:
2011-02-26 Rik Cabanier <cabanier@adobe.com>
Reviewed by David Hyatt.
Fix that allows fixed length values to be floating point
https://bugs.webkit.org/show_bug.cgi?id=52699
Transitions now return matrices in floating point. 2 of the transition tests were failing
because they expected integer values.
- WebCore.xcodeproj/project.pbxproj:
- css/CSSStyleSelector.cpp: (WebCore::convertToLength): (WebCore::convertToIntLength): (WebCore::convertToFloatLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::createTransformOperations):
- platform/Length.h: (WebCore::Length::Length): (WebCore::Length::operator==): (WebCore::Length::operator!=): (WebCore::Length::rawValue): (WebCore::Length::type): (WebCore::Length::quirk): (WebCore::Length::setValue): (WebCore::Length::calcFloatValue): (WebCore::Length::isZero): (WebCore::Length::blend): (WebCore::Length::getIntValue): (WebCore::Length::getFloatValue):
- rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
- rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):
- 6:39 AM Changeset in webkit [79783] by
-
- 134 edits6 copies in trunk
2011-02-26 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Andreas Kling.
Make it possible to test the targetdensity-dpi support
https://bugs.webkit.org/show_bug.cgi?id=55142
- fast/viewport/viewport-*.html: Update to new JS API.
- fast/viewport/viewport-91.html: Add new tests.
- fast/viewport/viewport-92.html:
- fast/viewport/viewport-93.html:
- fast/viewport/viewport-94.html:
- fast/viewport/viewport-95.html:
- fast/viewport/viewport-96.html:
2011-02-26 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Andreas Kling.
Make it possible to test the targetdensity-dpi support
https://bugs.webkit.org/show_bug.cgi?id=55142
Test the viewport meta tag feature targetdensity-dpi by
adding extra arguments to dumpConfigurationForViewport
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::dumpConfigurationForViewport):
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-02-26 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Andreas Kling.
Make it possible to test the targetdensity-dpi support
https://bugs.webkit.org/show_bug.cgi?id=55142
Test the viewport meta tag feature targetdensity-dpi by
adding extra arguments to dumpConfigurationForViewport
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::viewportAsText):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-02-26 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Andreas Kling.
Make it possible to test the targetdensity-dpi support
https://bugs.webkit.org/show_bug.cgi?id=55142
Test the viewport meta tag feature targetdensity-dpi by
adding extra arguments to dumpConfigurationForViewport
Add the new arguments to the shared header and all
implementation.
- DumpRenderTree/LayoutTestController.cpp: (dumpConfigurationForViewportCallback):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::dumpConfigurationForViewport):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::dumpConfigurationForViewport):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::dumpConfigurationForViewport):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::dumpConfigurationForViewport):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::dumpConfigurationForViewport):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- 6:26 AM Changeset in webkit [79782] by
-
- 5 edits in trunk/Source/WebKit/chromium
2011-02-26 Bill Budge <bbudge@chromium.org>
Reviewed by David Levin.
WebURLRequest, WebURLResponse properties should be passed to WebCore Layer
https://bugs.webkit.org/show_bug.cgi?id=54489
No tests needed. This is already tested by ui_tests, nacl_ui_tests, and nacl_sandbox_tests
- src/WebURLRequest.cpp: (WebKit::WebURLRequestPrivateImpl::WebURLRequestPrivateImpl): (WebKit::WebURLRequest::downloadToFile): (WebKit::WebURLRequest::setDownloadToFile):
- src/WebURLRequestPrivate.h: (WebKit::WebURLRequestPrivate::WebURLRequestPrivate):
- src/WebURLResponse.cpp: (WebKit::WebURLResponsePrivateImpl::WebURLResponsePrivateImpl): (WebKit::WebURLResponse::downloadFilePath): (WebKit::WebURLResponse::setDownloadFilePath):
- src/WebURLResponsePrivate.h:
- 5:59 AM Changeset in webkit [79781] by
-
- 3 edits in trunk/Source/WebCore
2011-02-26 Eric Seidel <eric@webkit.org>
Reviewed by Maciej Stachowiak.
malloc in removeChildren shows up on profile of peacekeeper domDynamicCreationCreateElement
https://bugs.webkit.org/show_bug.cgi?id=55204
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren):
- Using an inlineCapacity of 10 for now. We may want to tweak it later.
- This removes yet another malloc from code which removes nodes (which is rather common).
- 5:47 AM Changeset in webkit [79780] by
-
- 2 edits in trunk/Source/WebCore
2011-02-26 Eric Seidel <eric@webkit.org>
Reviewed by Maciej Stachowiak.
HashSet<T>::end() creation is expensive and should be avoided
https://bugs.webkit.org/show_bug.cgi?id=55205
In the common case, m_ranges is an empty set. When that's
the case, we spend all our time in skipEmptyBuckets, walking
the hash storage skipping over empty buckets.
This looks to be at least a 5% speedup on (my local version of) peacekeeper's domDynamicCreationCreateElement.
Before:
avg 383.6666666666667
median 386
stdev 7.152311203768722
min 360
max 391
After:
avg 366.3333333333333
median 366
stdev 2.712112747574399
min 362
max 377
- dom/Document.cpp: (WebCore::Document::nodeChildrenChanged): (WebCore::Document::nodeChildrenWillBeRemoved): (WebCore::Document::nodeWillBeRemoved): (WebCore::Document::textInserted): (WebCore::Document::textRemoved): (WebCore::Document::textNodesMerged): (WebCore::Document::textNodeSplit):
- 5:15 AM Changeset in webkit [79779] by
-
- 30 edits in trunk
2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79764.
http://trac.webkit.org/changeset/79764
https://bugs.webkit.org/show_bug.cgi?id=55295
"broke Chromium builds" (Requested by rniwa on #webkit).
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController):
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
- DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::reset):
2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79764.
http://trac.webkit.org/changeset/79764
https://bugs.webkit.org/show_bug.cgi?id=55295
"broke Chromium builds" (Requested by rniwa on #webkit).
- public/WebFrame.h:
- src/WebFrameImpl.cpp:
- src/WebFrameImpl.h:
2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79764.
http://trac.webkit.org/changeset/79764
https://bugs.webkit.org/show_bug.cgi?id=55295
"broke Chromium builds" (Requested by rniwa on #webkit).
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79764.
http://trac.webkit.org/changeset/79764
https://bugs.webkit.org/show_bug.cgi?id=55295
"broke Chromium builds" (Requested by rniwa on #webkit).
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79764.
http://trac.webkit.org/changeset/79764
https://bugs.webkit.org/show_bug.cgi?id=55295
"broke Chromium builds" (Requested by rniwa on #webkit).
- Interfaces/IWebFramePrivate.idl:
- Interfaces/WebKit.idl:
- WebFrame.cpp:
- WebFrame.h:
2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79764.
http://trac.webkit.org/changeset/79764
https://bugs.webkit.org/show_bug.cgi?id=55295
"broke Chromium builds" (Requested by rniwa on #webkit).
- WebView/WebFrame.mm:
- WebView/WebFramePrivate.h:
2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79764.
http://trac.webkit.org/changeset/79764
https://bugs.webkit.org/show_bug.cgi?id=55295
"broke Chromium builds" (Requested by rniwa on #webkit).
- WebCore.exp.in:
2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79764.
http://trac.webkit.org/changeset/79764
https://bugs.webkit.org/show_bug.cgi?id=55295
"broke Chromium builds" (Requested by rniwa on #webkit).
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
- WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
- 5:14 AM Changeset in webkit [79778] by
-
- 13 edits1 copy3 adds in trunk
2011-02-26 Adam Klein <adamk@chromium.org>
Reviewed by Adam Barth.
[fileapi] Implement EntrySync.toURI by moving Entry::toURI to EntryBase
https://bugs.webkit.org/show_bug.cgi?id=54585
- fast/filesystem/resources/file-entry-to-uri-sync.js: Added.
- fast/filesystem/workers/file-entry-to-uri-sync-expected.txt: Added.
- fast/filesystem/workers/file-entry-to-uri-sync.html: Added.
2011-02-26 Adam Klein <adamk@chromium.org>
Reviewed by Adam Barth.
[fileapi] Implement EntrySync.toURI by moving Entry::toURI to EntryBase
https://bugs.webkit.org/show_bug.cgi?id=54585
In order to move toURI to EntryBase, it needed access to
SecurityOrigin. Most of the changes below were to pass a
ScriptExecutionContext to DOMFileSystemBase to enable this.
Test: fast/filesystem/workers/file-entry-to-uri-sync.html
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::DOMFileSystem):
- fileapi/DOMFileSystemBase.cpp: (WebCore::DOMFileSystemBase::DOMFileSystemBase): (WebCore::DOMFileSystemBase::securityOrigin):
- fileapi/DOMFileSystemBase.h: (WebCore::DOMFileSystemBase::create):
- fileapi/DOMFileSystemSync.cpp: (WebCore::DOMFileSystemSync::create): (WebCore::DOMFileSystemSync::DOMFileSystemSync):
- fileapi/DOMFileSystemSync.h: (WebCore::DOMFileSystemSync::create):
- fileapi/Entry.cpp:
- fileapi/Entry.h:
- fileapi/EntryBase.cpp: Added. (WebCore::EntryBase::EntryBase): (WebCore::EntryBase::~EntryBase): (WebCore::EntryBase::toURI):
- fileapi/EntryBase.h:
- fileapi/EntrySync.idl:
- 4:12 AM Changeset in webkit [79777] by
-
- 3 edits2 adds in trunk
2011-02-26 Alice Boxhall <aboxhall@chromium.org>
Reviewed by Ojan Vafai.
Tests that typing enter in the input element does not fire textInput.
https://bugs.webkit.org/show_bug.cgi?id=54152
- fast/forms/textinput-not-fired-on-enter-in-input-expected.txt: Added.
- fast/forms/textinput-not-fired-on-enter-in-input.html: Added.
2011-02-26 Alice Boxhall <aboxhall@chromium.org>
Reviewed by Ojan Vafai.
typing enter in the input element should not fire textInput
https://bugs.webkit.org/show_bug.cgi?id=54152
Stop textInput event propagation in HTMLInputElement::preDispatchEventHandler if the event target should submit implicitly.
Test: fast/forms/textinput-not-fired-on-enter-in-input.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::preDispatchEventHandler): Check m_inputType->shouldSubmitImplicitly for textInputEvents and stop propagation if true.
- 4:04 AM Changeset in webkit [79776] by
-
- 4 edits in trunk
2011-02-26 James Simonsen <simonjam@chromium.org>
Reviewed by Tony Gentilcore.
[Web Timing] loadEvent timing should refer to first load event if there are many
https://bugs.webkit.org/show_bug.cgi?id=55201
- fast/dom/script-tests/webtiming-document-open.js: (testTimingWithDocumentOpen): Fire via setTimeout to match w3c test and reveal loadEventEnd. (finishTest): Fire via setTimeout to match w3c test.
2011-02-26 James Simonsen <simonjam@chromium.org>
Reviewed by Tony Gentilcore.
[Web Timing] loadEvent timing should refer to first load event if there are many
https://bugs.webkit.org/show_bug.cgi?id=55201
Test: fast/dom/webtiming-document-open.html
- page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent):
- 3:20 AM Changeset in webkit [79775] by
-
- 4 edits in trunk/Source/WebCore
2011-02-26 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Fix isLayoutTimerActive for ports that set a minimumLayoutDelay
https://bugs.webkit.org/show_bug.cgi?id=54810
No new tests because no new functionality.
- dom/Document.cpp: (WebCore::Document::isLayoutTimerActive): Moved from HTMLParserScheduler per FIXME. Compare minimumLayoutDelay() to m_extraLayoutDelay instead of 0. This spirit of this comparison was broken by r52919. The effect would be that ports that set an extra layout delay can't yield between tokens. Note: can't be const because minimumLayoutDelay sets a member.
- dom/Document.h:
- html/parser/HTMLParserScheduler.cpp: (WebCore::HTMLParserScheduler::continueNextChunkTimerFired): (WebCore::HTMLParserScheduler::checkForYieldBeforeScript):
- 2:17 AM Changeset in webkit [79774] by
-
- 10 edits in trunk/Source
2011-02-26 David Dorwin <ddorwin@chromium.org>
Reviewed by Darin Fisher.
Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default.
fullscreen javascript bindings not implemented for v8
https://bugs.webkit.org/show_bug.cgi?id=44797
Tested by the existing fullscreen Layout Tests.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
2011-02-26 David Dorwin <ddorwin@chromium.org>
Reviewed by Darin Fisher.
Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default.
fullscreen javascript bindings not implemented for v8
https://bugs.webkit.org/show_bug.cgi?id=44797
- features.gypi:
- public/WebSettings.h:
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::supportsFullScreenForElement): (WebKit::ChromeClientImpl::enterFullScreenForElement): (WebKit::ChromeClientImpl::exitFullScreenForElement): (WebKit::ChromeClientImpl::fullScreenRendererChanged):
- src/ChromeClientImpl.h:
- src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setFullScreenEnabled):
- src/WebSettingsImpl.h:
- 2:11 AM Changeset in webkit [79773] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-26 Thouraya ANDOLSI <thouraya.andolsi@st.com>
Reviewed by Nikolas Zimmermann.
SH4 JIT SUPPORT
https://bugs.webkit.org/show_bug.cgi?id=44329
Provide an ExecutableAllocater::cacheFlush() implementation for
Linux/SH4.
- jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
- 1:45 AM Changeset in webkit [79772] by
-
- 5 edits in trunk/Source/WebCore
2011-02-26 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Prevent parser yields from triggering early dumpAsText()
https://bugs.webkit.org/show_bug.cgi?id=55187
DRT's dumpAsText() takes a snapshot when DocumentLoader::isLoadingInAPISense()
indicates the page is done. isLoadingInAPISense depends on
HTMLDocumentParser::isProcessingData(), which just checks if the parser is in an
insert() or append().
This means that if the parser is pumping in a resumeParsingAfterScriptExecution() or
resumeParsingAfterYield(), isLoadingInAPISense() may not be blocked. This patch
fixes that by repurposing m_writeNestingLevel as m_pumpSessionNestingLevel and
incrementing it in pumpTokenizer().
When I locally cause the parser to yield after every token, a lot of tests fail
because DRT snapshots too early. This patch fixes those tests, however I'm having
trouble writing a test case that reliably reproduces the problem without this patch
and passes with it (without changing yield constants). This is because it requires
4,096 tokens in a single pump session to yield and (len('<b>' * 4096 = 12k, which
doesn't always happen).
- html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::~HTMLDocumentParser): (WebCore::HTMLDocumentParser::processingData): (WebCore::HTMLDocumentParser::pumpTokenizer): (WebCore::HTMLDocumentParser::insert): (WebCore::HTMLDocumentParser::append):
- html/parser/HTMLDocumentParser.h: (WebCore::HTMLDocumentParser::inPumpSession): (WebCore::HTMLDocumentParser::shouldDelayEnd):
- html/parser/HTMLParserScheduler.h: (WebCore::PumpSession::PumpSession):
- html/parser/NestingLevelIncrementer.h:
- 1:32 AM Changeset in webkit [79771] by
-
- 16 edits3 adds in trunk
2011-02-26 Yongjun Zhang <yongjun_zhang@apple.com>
Reviewed by David Kilzer.
Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
- fast/images/resources/broken-image-with-invalid-format.png: Added.
- fast/images/support-broken-image-delegate.html: Added.
- platform/mac/fast/images/support-broken-image-delegate-expected.txt: Added.
2011-02-26 Yongjun Zhang <yongjun_zhang@apple.com>
Reviewed by David Kilzer.
Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore
should paint the default broken image when an image fails to load or decode. The method also passes the
URL of the failed image.
Test: fast/images/support-broken-image-delegate.html
- loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::shouldPaintBrokenImage):
- loader/cache/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::image): (WebCore::CachedImage::checkShouldPaintBrokenImage): (WebCore::CachedImage::error):
- loader/cache/CachedImage.h:
2011-02-26 Yongjun Zhang <yongjun_zhang@apple.com>
Reviewed by David Kilzer.
Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore
should paint the default broken image when an image fails to load or decode. The method also passes the
URL of the failed image.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::shouldPaintBrokenImage):
- WebView/WebDelegateImplementationCaching.h:
- WebView/WebDelegateImplementationCaching.mm: Added case for passing one object. (CallResourceLoadDelegateReturningBoolean):
- WebView/WebResourceLoadDelegatePrivate.h:
- WebView/WebView.mm: (-[WebView _cacheResourceLoadDelegateImplementations]):
2011-02-26 Yongjun Zhang <yongjun_zhang@apple.com>
Reviewed by David Kilzer.
Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore
should paint the default broken image when an image fails to load or decode.
- DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (setShouldPaintBrokenImageCallback): (LayoutTestController::staticFunctions): (LayoutTestController::setShouldPaintBrokenImage):
- DumpRenderTree/LayoutTestController.h: (LayoutTestController::shouldPaintBrokenImage):
- DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:shouldPaintBrokenImageForURL:]):
- 1:24 AM Changeset in webkit [79770] by
-
- 1 edit9 deletes in trunk/LayoutTests
2011-02-26 Eric Seidel <eric@webkit.org>
Reviewed by Alexey Proskuryakov.
Remove disabled xmlhttprequest/web-apps tests
https://bugs.webkit.org/show_bug.cgi?id=55181
Per ap's suggestion in:
https://bugs.webkit.org/show_bug.cgi?id=55164#c15
I don't think we've ever run these tests. Some of them
depend on 10 minute timeouts and another nonsense. :)
- http/tests/xmlhttprequest/web-apps/006-test.cgi: Removed.
- http/tests/xmlhttprequest/web-apps/006.html-disabled: Removed.
- http/tests/xmlhttprequest/web-apps/009-test.cgi: Removed.
- http/tests/xmlhttprequest/web-apps/009.html-disabled: Removed.
- http/tests/xmlhttprequest/web-apps/016-test.cgi: Removed.
- http/tests/xmlhttprequest/web-apps/016.html-disabled: Removed.
- http/tests/xmlhttprequest/web-apps/017.html-disabled: Removed.
- http/tests/xmlhttprequest/web-apps/recursion/001.html-disabled: Removed.
- http/tests/xmlhttprequest/web-apps/recursion/README: Removed.
- 1:16 AM Changeset in webkit [79769] by
-
- 2 edits in trunk/Source/WebCore
2011-02-26 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Database: Data race: should only touch the transaction queue inside the
lock.
https://bugs.webkit.org/show_bug.cgi?id=55031
- storage/Database.cpp: (WebCore::Database::changeVersion): only touch queue inside lock. (WebCore::Database::runTransaction): only touch queue inside lock.
- 1:03 AM Changeset in webkit [79768] by
-
- 2 edits in trunk/Source/WebCore
2011-02-26 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Eric Carlson.
Missing volumechangeEvent in case of mediaPlayerVolumeChanged gets callback
https://bugs.webkit.org/show_bug.cgi?id=55147
When HTMLMediaElement::mediaPlayerVolumeChanged() gets callback,
a volumechangeEvent event should be fired if the volume gets changed.
Test: media/event-attributes.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setMuted): Remove updateVolume() since it does nothing when m_player is 0. (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): Fire a volumechangeEvent when the volume is changed.
- 12:59 AM Changeset in webkit [79767] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-02-26 John Mellor <johnme@chromium.org>
Reviewed by Antonio Gomes.
[chromium] WebFrameImpl::m_totalMatchCount should be an int
https://bugs.webkit.org/show_bug.cgi?id=55134
WebFrameImpl::m_totalMatchCount should be an int instead of a size_t since it can be -1.
- src/WebFrameImpl.h:
- 12:41 AM Changeset in webkit [79766] by
-
- 2 edits in trunk/Source/WebCore
2011-02-26 Eric Seidel <eric@webkit.org>
Reviewed by Maciej Stachowiak.
disableRangeMutation quirk for mail slows down peacekeeper domDynamicCreationCreateElement
https://bugs.webkit.org/show_bug.cgi?id=55127
Before:
avg 513.4
median 515
stdev 7.234638899074368
min 490
max 528
After:
avg 508.15
median 510
stdev 6.966168243733426
min 485
max 515
Yes, the stdev is a bit high to actually support my conclusions. But looking
at the profile, this change makes a lot of sense. I'll up the iterations
for future testing.
- dom/Document.cpp:
(WebCore::disableRangeMutation):
- This check should only be compiled in if we're planning to run on Tiger or Leopard.
- 12:35 AM Changeset in webkit [79765] by
-
- 11 edits5 adds in trunk/LayoutTests
2011-02-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Synchronized tests with html5lib
https://bugs.webkit.org/show_bug.cgi?id=55128
I didn't copy all of plain-test-unsafe because it confuses pretty-diff.
- html5lib/resources/pending-spec-changes-plain-text-unsafe.dat:
- html5lib/resources/pending-spec-changes.dat:
- html5lib/resources/tests1.dat:
- html5lib/resources/tests10.dat:
- html5lib/resources/tests19.dat:
- html5lib/resources/tests20.dat:
- html5lib/resources/tests22.dat: Added.
- html5lib/resources/tests23.dat: Added.
- html5lib/resources/tests24.dat: Added.
- html5lib/resources/tests25.dat: Added.
- html5lib/resources/tests26.dat: Added.
- html5lib/resources/tests3.dat:
- html5lib/resources/tests6.dat:
- html5lib/runner-expected.txt:
- html5lib/runner.html:
- 12:16 AM Changeset in webkit [79764] by
-
- 30 edits in trunk
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
No new tests. (no code affected, just exporting a method for DumpRenderTree use)
- WebCore.exp.in:
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
Added clearOpener method to WebFrame.
- public/WebFrame.h:
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::clearOpener):
- src/WebFrameImpl.h:
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
Added clearOpener method to DumpRenderTreeSupportGTK.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::clearOpener):
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
Added clearOpener method to WebFramePrivate.
- WebView/WebFrame.mm: (-[WebFrame _clearOpener]):
- WebView/WebFramePrivate.h:
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
Added clearOpener method to DumpRenderTreeSupportQT.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::clearOpener):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
Added clearOpener method to IWebFramePrivate.
Touched WebKit.idl to trigger build scripts.
- Interfaces/IWebFramePrivate.idl:
- Interfaces/WebKit.idl:
- WebFrame.cpp: (WebFrame::clearOpener):
- WebFrame.h:
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
Added clearOpener method to WKBundleWebFramePrivate.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameClearOpener):
- WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
Added clearOpener() calls between tests.
Some tests are using window.open() to change current window location.
This changes window.opener property whose nullity is checked before
showing xml viewer.
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController):
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
- DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::reset):
- 12:13 AM Changeset in webkit [79763] by
-
- 2 edits1 add in trunk/LayoutTests
2011-02-26 Xianzhu Wang <wangxianzhu@google.com>
Reviewed by Eric Seidel.
Fix Chromium test failure http://crbug.com/33358
https://bugs.webkit.org/show_bug.cgi?id=55125
- platform/chromium/test_expectations.txt:
- platform/chromium/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added.
- 12:12 AM Changeset in webkit [79762] by
-
- 7 edits2 adds in trunk
2011-02-26 Chang Shu <chang.shu@nokia.com>
Reviewed by Antonio Gomes.
Spatial Navigation: Add support for <select> element in multiple selection mode
https://bugs.webkit.org/show_bug.cgi?id=49261
Enhanced existing tests and added new tests for the bug.
- fast/spatial-navigation/snav-multiple-select-expected.txt:
- fast/spatial-navigation/snav-multiple-select.html:
- fast/spatial-navigation/snav-single-select-list-expected.txt: Added.
- fast/spatial-navigation/snav-single-select-list.html: Added.
2011-02-26 Chang Shu <chang.shu@nokia.com>
Reviewed by Antonio Gomes.
Based on patch by Carlos Garcia Campos <cgarcia@igalia.com>.
Spatial Navigation: Add support for <select> element in multiple selection mode
https://bugs.webkit.org/show_bug.cgi?id=49261
When spatial navigation is enabled, use space key to toggle select
items. And the up and down keys should not affect selection but just
navigate through items, which is indicated visually by a focus ring.
New Test: fast/spatial-navigation/snav-single-select-list.html
Enhanced Test: fast/spatial-navigation/snav-multiple-select.html
- dom/SelectElement.cpp: (WebCore::SelectElement::listBoxDefaultEventHandler):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::addFocusRingRects):
- rendering/RenderListBox.h:
Feb 25, 2011:
- 11:55 PM Changeset in webkit [79761] by
-
- 2 edits in trunk/Tools
2011-02-25 Lukasz Slachciak <l.slachciak@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Added EWebLauncher command line option to turn on/off frame flattening
https://bugs.webkit.org/show_bug.cgi?id=54809
- EWebLauncher/main.c: Handling -f option added. (on_key_down): (browserCreate): (main):
- 11:33 PM Changeset in webkit [79760] by
-
- 6 edits in trunk/LayoutTests
2011-02-25 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Make positioned elements work with vertical text
https://bugs.webkit.org/show_bug.cgi?id=46500
Rebaseline fast/table/fixed-with-auto-with-colspan-vertical.html for r79725.
- platform/gtk/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
- platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.checksum:
- platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.png:
- platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
- platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
- 9:35 PM Changeset in webkit [79759] by
-
- 2 edits in trunk/Source/WebCore
2011-02-25 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Qt build fix; included CSSValueList.h in EditingStyle.cpp.
- editing/EditingStyle.cpp:
- 9:26 PM Changeset in webkit [79758] by
-
- 5 edits in trunk/Source/WebCore
2011-02-25 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Move HTMLEquivalent and its subclasses to EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55207
Moved HTMLEquivalent and its subclasses from ApplyStyleCommand to EditingStyle,
and renamed HTMLEquivalent, HTMLEquivalentValueList, HTMLAttributeEquivalent,
and HTMLEquivalentFontSizeAttribute to HTMLElementEquivalent, HTMLTextDecorationEquivalent,
HTMLAttributeEquivalent, and HTMLFontSizeEquivalent respectively.
Also extracted the logic to determine which element and attribute are removed
as conflictsWithImplicitStyleOfElement, conflictsWithImplicitStyleOfAttributes,
and extractConflictingImplicitStyleOfAttributes.
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
- editing/ApplyStyleCommand.h:
- editing/EditingStyle.cpp: (WebCore::HTMLElementEquivalent::create): Moved from ApplyStyleCommand.cpp. (WebCore::HTMLElementEquivalent::~HTMLElementEquivalent): Ditto. (WebCore::HTMLElementEquivalent::matches): Ditto. (WebCore::HTMLElementEquivalent::hasAttribute): Ditto. (WebCore::HTMLElementEquivalent::propertyExistsInStyle): Ditto. (WebCore::HTMLElementEquivalent::HTMLElementEquivalent): Ditto. (WebCore::HTMLElementEquivalent::valueIsPresentInStyle): Ditto. (WebCore::HTMLElementEquivalent::addToStyle): Ditto. (WebCore::HTMLTextDecorationEquivalent::create): Ditto. (WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent): Ditto. (WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle): Ditto. (WebCore::HTMLAttributeEquivalent::create): Ditto. (WebCore::HTMLAttributeEquivalent::matches): Ditto. (WebCore::HTMLAttributeEquivalent::hasAttribute): Ditto. (WebCore::HTMLAttributeEquivalent::attributeName): Ditto. (WebCore::HTMLAttributeEquivalent::HTMLAttributeEquivalent): Ditto. (WebCore::HTMLAttributeEquivalent::valueIsPresentInStyle): Ditto. (WebCore::HTMLAttributeEquivalent::addToStyle): Ditto. (WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue): Ditto. (WebCore::HTMLFontSizeEquivalent::create): Ditto. (WebCore::HTMLFontSizeEquivalent::HTMLFontSizeEquivalent): Ditto. (WebCore::HTMLFontSizeEquivalent::attributeValueAsCSSValue): Ditto. (WebCore::EditingStyle::conflictsWithImplicitStyleOfElement): Added. (WebCore::htmlAttributeEquivalents): Added. (WebCore::EditingStyle::conflictsWithImplicitStyleOfAttributes): Added. (WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes): Added.
- editing/EditingStyle.h:
- 6:49 PM Changeset in webkit [79757] by
-
- 2 edits21 adds in trunk/LayoutTests
2011-02-25 James Robinson <jamesr@chromium.org>
Update chromium expectations and add new chromium and mac-leopard baselines for new tests.
- platform/chromium-linux/fast/block/positioning/differing-writing-modes-expected.checksum: Added.
- platform/chromium-linux/fast/block/positioning/differing-writing-modes-expected.png: Added.
- platform/chromium-linux/fast/block/positioning/differing-writing-modes-replaced-expected.checksum: Added.
- platform/chromium-linux/fast/block/positioning/differing-writing-modes-replaced-expected.png: Added.
- platform/chromium-linux/fast/table/table-continuation-outline-paint-crash-expected.checksum: Added.
- platform/chromium-linux/fast/table/table-continuation-outline-paint-crash-expected.png: Added.
- platform/chromium-win/fast/block/positioning/differing-writing-modes-expected.checksum: Added.
- platform/chromium-win/fast/block/positioning/differing-writing-modes-expected.png: Added.
- platform/chromium-win/fast/block/positioning/differing-writing-modes-expected.txt: Added.
- platform/chromium-win/fast/block/positioning/differing-writing-modes-replaced-expected.checksum: Added.
- platform/chromium-win/fast/block/positioning/differing-writing-modes-replaced-expected.png: Added.
- platform/chromium-win/fast/block/positioning/differing-writing-modes-replaced-expected.txt: Added.
- platform/chromium-win/fast/table/table-continuation-outline-paint-crash-expected.checksum: Added.
- platform/chromium-win/fast/table/table-continuation-outline-paint-crash-expected.png: Added.
- platform/chromium-win/fast/table/table-continuation-outline-paint-crash-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- platform/mac-leopard/fast/block/positioning/differing-writing-modes-expected.checksum: Added.
- platform/mac-leopard/fast/block/positioning/differing-writing-modes-expected.png: Added.
- platform/mac-leopard/fast/block/positioning/differing-writing-modes-replaced-expected.checksum: Added.
- platform/mac-leopard/fast/block/positioning/differing-writing-modes-replaced-expected.png: Added.
- platform/mac-leopard/fast/table/table-continuation-outline-paint-crash-expected.checksum: Added.
- platform/mac-leopard/fast/table/table-continuation-outline-paint-crash-expected.png: Added.
- 6:45 PM Changeset in webkit [79756] by
-
- 5 edits in trunk/Source
Versioning.
- 6:18 PM Changeset in webkit [79755] by
-
- 1 copy in tags/Safari-534.22
New tag.
- 6:18 PM Changeset in webkit [79754] by
-
- 79 edits in trunk/LayoutTests
2011-02-25 Mihai Parparita <mihaip@chromium.org>
Unreviewed rebaseline.
Update mac/ pixel baselines for Snow Leopard (new results match
chromium-mac and/or chromium-mac-leopard ones, which are known to be
good).
- platform/mac/fast/backgrounds/svg-as-background-5-expected.checksum:
- platform/mac/fast/backgrounds/svg-as-background-5-expected.png:
- platform/mac/fast/block/margin-collapse/103-expected.checksum:
- platform/mac/fast/block/margin-collapse/103-expected.png:
- platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
- platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
- platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
- platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
- platform/mac/fast/css/empty-pseudo-class-expected.checksum:
- platform/mac/fast/css/empty-pseudo-class-expected.png:
- platform/mac/fast/css/first-child-pseudo-class-expected.checksum:
- platform/mac/fast/css/first-child-pseudo-class-expected.png:
- platform/mac/fast/css/first-of-type-pseudo-class-expected.checksum:
- platform/mac/fast/css/first-of-type-pseudo-class-expected.png:
- platform/mac/fast/css/font-face-default-font-expected.checksum:
- platform/mac/fast/css/font-face-default-font-expected.png:
- platform/mac/fast/css/font_property_normal-expected.checksum:
- platform/mac/fast/css/font_property_normal-expected.png:
- platform/mac/fast/css/last-child-pseudo-class-expected.checksum:
- platform/mac/fast/css/last-child-pseudo-class-expected.png:
- platform/mac/fast/css/last-of-type-pseudo-class-expected.checksum:
- platform/mac/fast/css/last-of-type-pseudo-class-expected.png:
- platform/mac/fast/css/line-height-font-order-expected.checksum:
- platform/mac/fast/css/line-height-font-order-expected.png:
- platform/mac/fast/css/only-child-pseudo-class-expected.checksum:
- platform/mac/fast/css/only-child-pseudo-class-expected.png:
- platform/mac/fast/css/only-of-type-pseudo-class-expected.checksum:
- platform/mac/fast/css/only-of-type-pseudo-class-expected.png:
- platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.checksum:
- platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
- platform/mac/fast/dynamic/008-expected.checksum:
- platform/mac/fast/dynamic/008-expected.png:
- platform/mac/fast/events/context-no-deselect-expected.checksum:
- platform/mac/fast/events/context-no-deselect-expected.png:
- platform/mac/fast/forms/placeholder-position-expected.checksum:
- platform/mac/fast/forms/placeholder-position-expected.png:
- platform/mac/fast/html/keygen-expected.checksum:
- platform/mac/fast/html/keygen-expected.png:
- platform/mac/fast/lists/dynamic-marker-crash-expected.checksum:
- platform/mac/fast/lists/dynamic-marker-crash-expected.png:
- platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum:
- platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
- platform/mac/fast/selectors/166-expected.checksum:
- platform/mac/fast/selectors/166-expected.png:
- platform/mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum:
- platform/mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png:
- platform/mac/fast/text/international/bidi-linebreak-001-expected.checksum:
- platform/mac/fast/text/international/bidi-linebreak-001-expected.png:
- platform/mac/fast/text/international/bidi-linebreak-002-expected.checksum:
- platform/mac/fast/text/international/bidi-linebreak-002-expected.png:
- platform/mac/fast/text/international/bidi-linebreak-003-expected.checksum:
- platform/mac/fast/text/international/bidi-linebreak-003-expected.png:
- platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
- platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
- platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum:
- platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
- platform/mac/fonts/sans-serif-expected.checksum:
- platform/mac/fonts/sans-serif-expected.png:
- platform/mac/svg/custom/text-dom-01-f-expected.checksum:
- platform/mac/svg/custom/text-dom-01-f-expected.png:
- platform/mac/tables/mozilla/bugs/bug113235-1-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug113235-1-expected.png:
- platform/mac/tables/mozilla/bugs/bug113424-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug113424-expected.png:
- platform/mac/tables/mozilla/bugs/bug1188-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug1188-expected.png:
- platform/mac/tables/mozilla/bugs/bug1318-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug1318-expected.png:
- platform/mac/tables/mozilla/bugs/bug16012-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug16012-expected.png:
- platform/mac/tables/mozilla/bugs/bug2479-2-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/mac/tables/mozilla/bugs/bug8858-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug8858-expected.png:
- platform/mac/tables/mozilla/core/bloomberg-expected.checksum:
- platform/mac/tables/mozilla/core/bloomberg-expected.png:
- platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.checksum:
- platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
- 5:46 PM Changeset in webkit [79753] by
-
- 2 edits in trunk/Source/WebCore
AX: Add Xcode entries back to the navigator list for Accessibility cpp files
https://bugs.webkit.org/show_bug.cgi?id=55280
Reviewed by Anders Carlsson.
- WebCore.xcodeproj/project.pbxproj:
- 5:46 PM Changeset in webkit [79752] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-25 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Plug-in process crashes when using GuardMalloc
https://bugs.webkit.org/show_bug.cgi?id=55279
<rdar://problem/9044618>
Update m_environmentPointer after copying the environment variables.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm: (WebKit::EnvironmentVariables::copyEnvironmentVariables):
- 5:40 PM Changeset in webkit [79751] by
-
- 3 edits in trunk/WebKitLibraries
Fix linking of Chromium Mac build.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- 5:34 PM Changeset in webkit [79750] by
-
- 9 edits in trunk/Source/JavaScriptCore
2011-02-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79627.
http://trac.webkit.org/changeset/79627
https://bugs.webkit.org/show_bug.cgi?id=55274
broke worker tests (Requested by olliej on #webkit).
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- runtime/Heap.cpp: (JSC::Heap::allocate):
- runtime/Heap.h:
- runtime/JSCell.h: (JSC::JSCell::JSCell::operator new): (JSC::JSCell::MarkedSpace::sizeClassFor): (JSC::JSCell::MarkedSpace::allocate):
- runtime/MarkedBlock.h:
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::allocateBlock): (JSC::MarkedSpace::reset):
- runtime/MarkedSpace.h: (JSC::MarkedSpace::SizeClass::SizeClass):
- 5:27 PM Changeset in webkit [79749] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-25 Michael Saboff <msaboff@apple.com>
Reviewed by Darin Adler.
Leak in JSParser::Scope of ScopeLabelInfo Vector
https://bugs.webkit.org/show_bug.cgi?id=55249
Changed m_labels to be an OwnPtr<>. Added VectorTraits
and Scope copy constructor to support this change.
- parser/JSParser.cpp: (JSC::JSParser::Scope::~Scope):
- 5:18 PM Changeset in webkit [79748] by
-
- 2 edits in trunk/Source/WebKit2
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess): Fixed backwards logic from last change.
- 5:10 PM Changeset in webkit [79747] by
-
- 2 edits in trunk/Source/WebKit2
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess): Fixed performance problem in production
builds by only setting DYLD_FRAMEWORK_PATH in engineering configurations.
Reviewed by Mark Rowe.
- 4:47 PM Changeset in webkit [79746] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/8036034> WebKit2 should work even if DYLD_FRAMEWORK_PATH is not set
Reviewed by Anders Carlsson.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::EnvironmentVariables::~EnvironmentVariables): Use fastFree, not delete, on
the strings here because they are allocated with fastMalloc, not new.
(WebKit::EnvironmentVariables::set): Use const more.
(WebKit::EnvironmentVariables::get): Ditto.
(WebKit::EnvironmentVariables::appendValue): Ditto.
(WebKit::EnvironmentVariables::valueIfVariableHasName): Ditto. Also fix mistake
where this would match if the name matched only a prefix of the environment variable's
name. We want to match the whole name, so we need to use memcmp, not strncmp.
(WebKit::EnvironmentVariables::createStringForVariable): Use const more.
(WebKit::ProcessLauncher::launchProcess): Use clearer name, frameworkExecutablePath,
for what was called bundlePath before. Append the frameworks path to DYLD_FRAMEWORK_PATH,
ensuring we can pick up other frameworks from the same directory in the web process.
Use a const_cast instead of a C-style cast.
- 4:46 PM Changeset in webkit [79745] by
-
- 4 edits in trunk/Source
2011-02-25 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Adam Barth.
WebSocket uses insecure random numbers
https://bugs.webkit.org/show_bug.cgi?id=54714
- JavaScriptCore.exp: Export WTF::cryptographicallyRandomNumber()
2011-02-25 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Adam Barth.
WebSocket uses insecure random numbers
https://bugs.webkit.org/show_bug.cgi?id=54714
- websockets/WebSocketHandshake.cpp: (WebCore::randomNumberLessThan): (WebCore::generateSecWebSocketKey): (WebCore::generateKey3):
- 4:37 PM Changeset in webkit [79744] by
-
- 6 edits in trunk/Source/WebCore
2011-02-25 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
Add API to enumerate/delete files downloaded for <audio> and <video>
https://bugs.webkit.org/show_bug.cgi?id=55267
Add review changes missed in r79737.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::clearMediaCacheForSite): Pass string by reference.
- html/HTMLMediaElement.h:
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::clearMediaCacheForSite): Ditto.
- 4:31 PM Changeset in webkit [79743] by
-
- 2 edits in trunk/Source/WebKit2
AX: WK2: AXApplication not returning the AXFocusedUIElement within the web area
https://bugs.webkit.org/show_bug.cgi?id=55277
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView accessibilityFocusedUIElement]):
- 4:25 PM Changeset in webkit [79742] by
-
- 2 edits in trunk/Source/WebKit2
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=55276
WebPage::close() accesses "this" after it is destroyed.
This was making many tests crash with GuardMalloc.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::close): Access "this" before it can be destroyed, not after.
- 4:02 PM Changeset in webkit [79741] by
-
- 1 edit234 adds in trunk/LayoutTests
2011-02-25 Martin Robinson <mrobinson@igalia.com>
Add the final set of missing GTK+ SVG pixel results.
- platform/gtk/svg/dynamic-updates: Add missing results.
- 4:00 PM Changeset in webkit [79740] by
-
- 1 edit202 adds in trunk/LayoutTests
2011-02-25 Martin Robinson <mrobinson@igalia.com>
Add another set of missing GTK+ SVG pixel results.
- platform/gtk/svg/dynamic-updates: Add missing pixel results.
- 3:58 PM Changeset in webkit [79739] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed.
Add missing sources to WebKit2API.pri.
- WebKit2API.pri:
- 3:58 PM Changeset in webkit [79738] by
-
- 1 edit202 adds in trunk/LayoutTests
2011-02-25 Martin Robinson <mrobinson@igalia.com>
Add the next set of missing GTK+ SVG pixel results.
- platform/gtk/svg/dom/SVGRectElement: Add missing pixel reults.
- platform/gtk/svg/dynamic-updates: Ditto.
- 3:55 PM Changeset in webkit [79737] by
-
- 6 edits in trunk/Source/WebCore
2011-02-25 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
Add API to enumerate/delete files downloaded for <audio> and <video>
https://bugs.webkit.org/show_bug.cgi?id=55267
<rdar://problem/9049280>
No new tests, this is just the plumbing.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::getSitesInMediaCache): New, call through to MediaPlayer. (WebCore::HTMLMediaElement::clearMediaCache): Ditto. (WebCore::HTMLMediaElement::clearMediaCacheForSite): Ditto.
- html/HTMLMediaElement.h:
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::getSitesInMediaCache): New, call through to media engine. (WebCore::MediaPlayer::clearMediaCache): Ditto. (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::getSitesInMediaCache): Declare new interface. (WebCore::MediaPlayerPrivateInterface::clearMediaCache): Ditto. (WebCore::MediaPlayerPrivateInterface::clearMediaCacheForSite): Ditto.
- 3:55 PM Changeset in webkit [79736] by
-
- 1 edit330 adds in trunk/LayoutTests
2011-02-25 Martin Robinson <mrobinson@igalia.com>
Add some missing GTK+ SVG pixel results.
- platform/gtk/svg: Add missing GTK+ SVG pixel results.
- 3:49 PM Changeset in webkit [79735] by
-
- 43 edits in trunk/LayoutTests
2011-02-25 Martin Robinson <mrobinson@igalia.com>
Update GTK+ SVG pixel results which have changed.
- platform/gtk/svg: Update SVG pixel resultsj
- 3:18 PM Changeset in webkit [79734] by
-
- 6 edits4 adds in trunk
2011-02-25 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Don't add inline continuation outline to the containing block's
continuationOutlineTable list if it is not enclosed by an anonymous block.
https://bugs.webkit.org/show_bug.cgi?id=54690
We currently don't reconnect inline continuations after a child removal.
As a result, those merged inlines do not get seperated and hence not get enclosed
by anonymous blocks. In this case, it is better to bail out and paint it ourself.
Test: fast/table/table-continuation-outline-paint-crash.html
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintsContinuationOutline): helper function to tell if this containing block has the continuation flow in its continuations list.
- rendering/RenderBlock.h: helper function definition.
- rendering/RenderInline.cpp: (WebCore::RenderInline::destroy): debug only code that asserts if we leave behind a continuation in the containing block's continuation list when it is getting destroyed.
2011-02-25 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Ensure that we do not add the inline continuation flow to the table's continuation
table map for painting. The layout test should not crash on assert and should show
a solid outline around the inline child.
https://bugs.webkit.org/show_bug.cgi?id=54690
- fast/table/table-continuation-outline-paint-crash.html: Added.
- platform/mac/fast/table/table-continuation-outline-paint-crash-expected.checksum: Added.
- platform/mac/fast/table/table-continuation-outline-paint-crash-expected.png: Added.
- platform/mac/fast/table/table-continuation-outline-paint-crash-expected.txt: Added.
- 2:43 PM Changeset in webkit [79733] by
-
- 7 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=55265, remove the unused "Static" type
from Length.
Reviewed by Adam Roben.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- platform/Length.h:
(WebCore::Length::isFixed):
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::layout):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::isLogicalWidthSpecified):
(WebCore::RenderImage::isLogicalHeightSpecified):
- rendering/RenderObject.h:
(WebCore::RenderObject::markContainingBlocksForLayout):
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::hasStaticX):
(WebCore::InheritedFlags::hasStaticY):
- 2:36 PM Changeset in webkit [79732] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-25 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
A WKView without a window will cause CG errors in the console
https://bugs.webkit.org/show_bug.cgi?id=55264
<rdar://problem/9044281>
Check that the window has a valid window number before trying to get its graphics context.
- UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::containingWindowGraphicsContext):
- 2:35 PM Changeset in webkit [79731] by
-
- 2 edits in trunk/LayoutTests
2011-02-25 James Robinson <jamesr@chromium.org>
Update chromium test expectations.
- platform/chromium/test_expectations.txt:
- 2:28 PM Changeset in webkit [79730] by
-
- 3 edits in trunk/Tools
2011-02-25 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79324.
http://trac.webkit.org/changeset/79324
https://bugs.webkit.org/show_bug.cgi?id=55260
Leopard Debug is once again running out of address space while
linking (Requested by aroben on #webkit).
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
- Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
- 2:20 PM Changeset in webkit [79729] by
-
- 2 edits in trunk/Source/WebCore
Windows build fix.
- platform/network/cf/CookieJarCFNet.cpp:
(WebCore::getHostnamesWithCookies): Add a const_cast.
(WebCore::deleteCookiesForHostname): Ditto.
- 2:14 PM Changeset in webkit [79728] by
-
- 18 edits9 moves30 deletes in trunk/LayoutTests
2011-02-25 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update.
Fix 16 tests for Chromium Snow Leopard by promoting chromium-mac-leopard
results to mac-leopard and removing outdated chromium-mac and
chromium-mac-snowleopard ones.
- platform/chromium-mac-leopard/svg/batik/masking/maskRegions-expected.checksum: Removed.
- platform/chromium-mac-leopard/svg/batik/masking/maskRegions-expected.png: Removed.
- platform/chromium-mac-leopard/svg/batik/masking/maskRegions-expected.txt: Removed.
- platform/chromium-mac-leopard/svg/custom/absolute-sized-content-with-resources-expected.checksum: Removed.
- platform/chromium-mac-leopard/svg/custom/absolute-sized-content-with-resources-expected.png: Removed.
- platform/chromium-mac-leopard/svg/custom/junk-data-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/custom/junk-data-expected.checksum.
- platform/chromium-mac-leopard/svg/custom/junk-data-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/junk-data-expected.png.
- platform/chromium-mac-leopard/svg/custom/junk-data-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/custom/junk-data-expected.txt.
- platform/chromium-mac-leopard/svg/custom/missing-xlink-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/custom/missing-xlink-expected.checksum.
- platform/chromium-mac-leopard/svg/custom/missing-xlink-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/missing-xlink-expected.png.
- platform/chromium-mac-leopard/svg/custom/missing-xlink-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/custom/missing-xlink-expected.txt.
- platform/chromium-mac-leopard/svg/custom/viewBox-hit-expected.checksum: Removed.
- platform/chromium-mac-leopard/svg/custom/viewBox-hit-expected.png: Removed.
- platform/chromium-mac-leopard/svg/filters/filterRes-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/filters/filterRes-expected.checksum.
- platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.checksum: Removed.
- platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.png: Removed.
- platform/chromium-mac/fast/text/justify-ideograph-simple-expected.checksum:
- platform/chromium-mac/fast/text/justify-ideograph-simple-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum: Removed.
- platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Removed.
- platform/chromium-mac/svg/batik/masking/maskRegions-expected.checksum: Removed.
- platform/chromium-mac/svg/batik/masking/maskRegions-expected.png: Removed.
- platform/chromium-mac/svg/css/text-gradient-shadow-expected.checksum: Removed.
- platform/chromium-mac/svg/custom/absolute-sized-content-with-resources-expected.checksum: Removed.
- platform/chromium-mac/svg/custom/absolute-sized-content-with-resources-expected.png: Removed.
- platform/chromium-mac/svg/custom/viewBox-hit-expected.checksum: Removed.
- platform/chromium-mac/svg/custom/viewBox-hit-expected.png: Removed.
- platform/chromium-mac/svg/filters/feComposite-expected.checksum: Removed.
- platform/chromium-mac/svg/filters/feComposite-expected.png: Removed.
- platform/chromium-mac/svg/hixie/perf/007-expected.checksum: Removed.
- platform/chromium-mac/svg/hixie/perf/007-expected.png: Removed.
- platform/chromium-mac/svg/repaint/filter-repaint-expected.checksum: Removed.
- platform/chromium-mac/svg/repaint/filter-repaint-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug23235-expected.checksum: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug23235-expected.png: Removed.
- platform/chromium-mac/tables/mozilla/marvin/x_thead_align_justify-expected.checksum: Removed.
- platform/chromium-mac/tables/mozilla/marvin/x_thead_align_justify-expected.png: Removed.
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/97619-expected.checksum: Removed.
- platform/chromium/test_expectations.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum.
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png.
- platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
- platform/mac-leopard/svg/batik/masking/maskRegions-expected.checksum:
- platform/mac-leopard/svg/batik/masking/maskRegions-expected.png:
- platform/mac-leopard/svg/batik/masking/maskRegions-expected.txt: Removed.
- platform/mac-leopard/svg/custom/absolute-sized-content-with-resources-expected.checksum:
- platform/mac-leopard/svg/custom/absolute-sized-content-with-resources-expected.png:
- platform/mac-leopard/svg/custom/viewBox-hit-expected.checksum:
- platform/mac-leopard/svg/custom/viewBox-hit-expected.png:
- platform/mac-leopard/tables/mozilla/bugs/bug23235-expected.checksum:
- platform/mac-leopard/tables/mozilla/bugs/bug23235-expected.png:
- platform/mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.checksum:
- platform/mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.png:
- platform/mac-leopard/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
- platform/mac-leopard/tables/mozilla_expected_failures/bugs/97619-expected.png:
- 2:01 PM Changeset in webkit [79727] by
-
- 2 edits in trunk/Source/WebCore
2011-02-25 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Empty Elements panel after closing and reopening Inspector
https://bugs.webkit.org/show_bug.cgi?id=55248
Fixing regression real quick. Test to follow.
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::reset):
- 1:58 PM Changeset in webkit [79726] by
-
- 2 edits in trunk/Source/WebCore
2011-02-25 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: added missing handle scope into V8InjectedScriptHostCustom.
https://bugs.webkit.org/show_bug.cgi?id=55256
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::nodeAsScriptValue): (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
- 1:45 PM Changeset in webkit [79725] by
-
- 3 edits8 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
Reviewed by Sam Weinig.
Make positioned objects work with all possible crazy combinations of mixed writing modes. Added new helper
functions that flip around the padding box of the containing block and then add in the appropriate border
side to ensure that the offset of the positioned object is actually correctly placed in the containing block's
local coordinate space.
Added two new tests of both replaced and non-replaced positioned elements in mixed writing mode environments.
Source/WebCore:
- rendering/RenderBox.cpp:
(WebCore::computeLogicalLeftPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::computeLogicalTopPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
LayoutTests:
- fast/block/positioning/differing-writing-modes-replaced.html: Added.
- fast/block/positioning/differing-writing-modes.html: Added.
- platform/mac/fast/block/positioning/differing-writing-modes-expected.checksum: Added.
- platform/mac/fast/block/positioning/differing-writing-modes-expected.png: Added.
- platform/mac/fast/block/positioning/differing-writing-modes-expected.txt: Added.
- platform/mac/fast/block/positioning/differing-writing-modes-replaced-expected.checksum: Added.
- platform/mac/fast/block/positioning/differing-writing-modes-replaced-expected.png: Added.
- platform/mac/fast/block/positioning/differing-writing-modes-replaced-expected.txt: Added.
- 1:45 PM Changeset in webkit [79724] by
-
- 2 edits2 adds in trunk/Tools
2011-02-25 Tony Chang <tony@chromium.org>
Reviewed by James Robinson.
Clean up temp files left by crashing DRTs on chromium-win
https://bugs.webkit.org/show_bug.cgi?id=55182
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- BuildSlaveSupport/chromium/remove-crash-logs: Added.
- 1:39 PM Changeset in webkit [79723] by
-
- 2 edits in trunk/LayoutTests
[Windows 7 Release Tests] http/tests/xmlhttprequest/basic-auth-nouser.html and
basic-auth-nopassword.html failing since introduction in r74609
https://bugs.webkit.org/show_bug.cgi?id=51596
Unreviewed. Adding http/tests/xmlhttprequest/basic-auth-nopassword.html to the Skipped list
because it is consistently timing out on the Windows XP Debug bot.
- platform/win-xp/Skipped:
- 1:22 PM Changeset in webkit [79722] by
-
- 15 edits in trunk/Source
WebKit2: Need a way to manage cookies from the web process
https://bugs.webkit.org/show_bug.cgi?id=55086
Reviewed by Brady Eidson and looked over by Jessie Berlin.
Source/WebCore:
Implement the functions needed to manage cookies in CookieJar (getHostnamesWithCookies,
deleteCookiesWithHostname, and deleteAllCookies) for Mac and CFNetwork (stub out the rest),
and call them from WebKit2's WebCookieManager.
No change in behavior needing tests.
- WebCore.exp.in: Added needed functions to export.
- platform/CookieJar.h:
- platform/mac/CookieJar.mm:
(WebCore::getHostnamesWithCookies): Gets all hostnames with cookies from NSHTTPCookieStorage.
(WebCore::deleteCookiesForHostname): Deletes all cookies with a given hostname from
NSHTTPCookieStorage.
(WebCore::deleteAllCookies): Deletes all cookies from NSHTTPCookieStorage.
- platform/network/cf/CookieJarCFNet.cpp:
(WebCore::getHostnamesWithCookies): Implement using CFNetwork cookie APIs.
(WebCore::deleteCookiesForHostname): Ditto.
(WebCore::deleteAllCookies): Ditto.
- platform/efl/CookieJarEfl.cpp: Added stub functions.
- platform/haiku/CookieJarHaiku.cpp: Ditto.
- platform/network/android/CookieJarAndroid.cpp: Ditto.
- platform/network/chromium/CookieJarChromium.cpp: Ditto.
- platform/network/curl/CookieJarCurl.cpp: Ditto.
- platform/network/soup/CookieJarSoup.cpp: Ditto.
- platform/network/win/CookieJarWin.cpp: Ditto.
- platform/qt/CookieJarQt.cpp: Ditto.
Source/WebKit2:
Call through to WebCore::CookieJar in our WebCookieManager functions.
- WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::getHostnamesWithCookies):
(WebKit::WebCookieManager::deleteCookiesForHostname):
(WebKit::WebCookieManager::deleteAllCookies):
- 1:21 PM Changeset in webkit [79721] by
-
- 10 edits12 moves20 deletes in trunk/LayoutTests
2011-02-25 Mihai Parparita <mihaip@chromium.org>
Fix 10 tests for Chromium Snow Leopard by promoting chromium-mac-leopard
results to mac-leopard and removing outdated chromium-mac and
chromium-mac-snowleopard ones.
- platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum: Removed.
- platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png: Removed.
- platform/chromium-mac-leopard/fast/forms/select-baseline-expected.checksum: Removed.
- platform/chromium-mac-leopard/fast/forms/select-baseline-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/text/atsui-negative-spacing-features-expected.checksum: Removed.
- platform/chromium-mac-snowleopard/fast/text/atsui-negative-spacing-features-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/text/atsui-spacing-features-expected.checksum: Removed.
- platform/chromium-mac-snowleopard/fast/text/atsui-spacing-features-expected.png: Removed.
- platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.checksum: Removed.
- platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.png: Removed.
- platform/chromium-mac/fast/forms/select-baseline-expected.checksum: Removed.
- platform/chromium-mac/fast/forms/select-baseline-expected.png: Removed.
- platform/chromium-mac/fast/forms/text-style-color-expected.checksum: Removed.
- platform/chromium-mac/fast/forms/text-style-color-expected.png: Removed.
- platform/chromium-mac/fast/multicol/shadow-breaking-expected.checksum: Removed.
- platform/chromium-mac/fast/multicol/shadow-breaking-expected.png: Removed.
- platform/chromium-mac/fast/table/028-vertical-expected.checksum: Removed.
- platform/chromium-mac/fast/table/028-vertical-expected.png: Removed.
- platform/chromium-mac/fast/text/complex-text-opacity-expected.checksum: Removed.
- platform/chromium-mac/fast/text/complex-text-opacity-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum:
- platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png:
- platform/mac-leopard/fast/dom/isindex-002-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/dom/isindex-002-expected.checksum.
- platform/mac-leopard/fast/dom/isindex-002-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/isindex-002-expected.png.
- platform/mac-leopard/fast/dom/replaceChild-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/dom/replaceChild-expected.checksum.
- platform/mac-leopard/fast/dom/replaceChild-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/replaceChild-expected.png.
- platform/mac-leopard/fast/forms/select-baseline-expected.checksum:
- platform/mac-leopard/fast/forms/select-baseline-expected.png:
- platform/mac-leopard/fast/forms/text-style-color-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/forms/text-style-color-expected.checksum.
- platform/mac-leopard/fast/forms/text-style-color-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/forms/text-style-color-expected.png.
- platform/mac-leopard/fast/multicol/shadow-breaking-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.checksum.
- platform/mac-leopard/fast/multicol/shadow-breaking-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.png.
- platform/mac-leopard/fast/table/028-vertical-expected.checksum:
- platform/mac-leopard/fast/table/028-vertical-expected.png:
- platform/mac-leopard/fast/text/atsui-negative-spacing-features-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/text/atsui-negative-spacing-features-expected.checksum.
- platform/mac-leopard/fast/text/atsui-negative-spacing-features-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/text/atsui-negative-spacing-features-expected.png.
- platform/mac-leopard/fast/text/atsui-spacing-features-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/text/atsui-spacing-features-expected.checksum.
- platform/mac-leopard/fast/text/atsui-spacing-features-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/text/atsui-spacing-features-expected.png.
- platform/mac-leopard/fast/text/complex-text-opacity-expected.checksum:
- platform/mac-leopard/fast/text/complex-text-opacity-expected.png:
- 1:04 PM Changeset in webkit [79720] by
-
- 4 edits34 adds in trunk/LayoutTests
2011-02-25 James Robinson <jamesr@chromium.org>
Add chromium win/linux baselines for new vertical replaced test and update various expectations.
- platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.checksum:
- platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png:
- platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.checksum: Added.
- platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.png: Added.
- platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.checksum: Added.
- platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.png: Added.
- platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.checksum: Added.
- platform/chromium-linux/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.png: Added.
- platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.checksum: Added.
- platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.png: Added.
- platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.checksum: Added.
- platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.png: Added.
- platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.checksum: Added.
- platform/chromium-linux/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.png: Added.
- platform/chromium-win/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.checksum: Added.
- platform/chromium-win/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.png: Added.
- platform/chromium-win/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.txt: Added.
- platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.checksum: Added.
- platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.png: Added.
- platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.txt: Added.
- platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.checksum: Added.
- platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.png: Added.
- platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.txt: Added.
- platform/chromium-win/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.checksum: Added.
- platform/chromium-win/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.png: Added.
- platform/chromium-win/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.txt: Added.
- platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.checksum: Added.
- platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.png: Added.
- platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.txt: Added.
- platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.checksum: Added.
- platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.png: Added.
- platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 1:03 PM TriagingTestFailures edited by
- Update the crash log URL to match the new URL format. (diff)
- 1:00 PM BuildingQtOnSymbian edited by
- changed to armv5 (diff)
- 12:58 PM TriagingTestFailures edited by
- Fix a link (diff)
- 12:55 PM TriagingTestFailures edited by
- Add a link to Darin's email about checking in expected failure results (diff)
- 12:30 PM Changeset in webkit [79719] by
-
- 9 edits in trunk
2011-02-25 Tony Chang <tony@chromium.org>
Unreviewed, updating chromium linux baselines after changes to
RGBToHSL code in chromium.
- platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.checksum:
- platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.png:
- platform/chromium-linux/fast/forms/menulist-style-color-expected.checksum:
- platform/chromium-linux/fast/forms/menulist-style-color-expected.png:
- platform/chromium-linux/fast/forms/select-baseline-expected.checksum:
- platform/chromium-linux/fast/forms/select-baseline-expected.png:
2011-02-25 Tony Chang <tony@chromium.org>
Roll chromium deps to include RBGToHSL fix and ICU update.
- DEPS:
- 12:20 PM Changeset in webkit [79718] by
-
- 4 edits in trunk
2011-02-25 Eric Carlson <eric.carlson@apple.com>
Reviewed by Eric Seidel.
'load' and 'error' events fired for @poster
https://bugs.webkit.org/show_bug.cgi?id=54908
- html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::dispatchLoadEvent): Don't fire events when being used by a video element.
2011-02-25 Eric Carlson <eric.carlson@apple.com>
Reviewed by Eric Seidel.
'load' and 'error' events fired for @poster
https://bugs.webkit.org/show_bug.cgi?id=54908
- media/video-poster.html: Register listeners for 'load' and 'error' events so the test will fail if they ever fire.
- 12:17 PM Changeset in webkit [79717] by
-
- 1 edit4 copies in branches/chromium/648
Merge 79699 - 2011-02-25 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Simon Fraser.
[chromium] Adding test to ensure clipping layer gets updated when layout
width/height change in the page.
https://bugs.webkit.org/show_bug.cgi?id=55103
- platform/chromium/compositing/layout-width-change-expected.checksum: Added.
- platform/chromium/compositing/layout-width-change-expected.png: Added.
- platform/chromium/compositing/layout-width-change-expected.txt: Added.
- platform/chromium/compositing/layout-width-change.html: Added.
2011-02-25 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Simon Fraser.
Update the clip layer size whenever the root layer's size and position
is updated. This only affects the accelerated compositing path.
https://bugs.webkit.org/show_bug.cgi?id=55103
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition):
Test: platform/chromium/compositing/layout-width-change.html
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition):
TBR=vangelis@chromium.org
Review URL: http://codereview.chromium.org/6597014
- 12:01 PM Changeset in webkit [79716] by
-
- 1 edit1 add in trunk/LayoutTests
media/controls-without-preload.html failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=50471
Unreviewed. Add Windows-XP specific (failing?) results to get the bots green.
- platform/win-xp/media/controls-without-preload-expected.txt: Added.
- 11:57 AM Changeset in webkit [79715] by
-
- 6 edits in trunk/Source/WebKit2
2011-02-25 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Option-clicking on links doesn't download them due to sandbox violation
https://bugs.webkit.org/show_bug.cgi?id=55250
<rdar://problem/9018359>
The change to make DecidePolicyForNavigationAction sync didn't handle the case when the
decided policy was "Download". Fix this by passing along the download ID back to the web process.
- Platform/CoreIPC/HandleMessage.h: (CoreIPC::callMemberFunction): Add new overload.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Initialize m_syncNavigationActionPolicyDownloadID.
(WebKit::WebPageProxy::receivedPolicyDecision):
Set m_syncNavigationActionPolicyDownloadID to the download ID.
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
Return the m_syncNavigationActionPolicyDownloadID.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in: Add a DownloadID reply parameter.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Don't pass a zero download ID to didReceivePolicyDecision.
- 11:57 AM Changeset in webkit [79714] by
-
- 2 edits in trunk/LayoutTests
2011-02-25 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update.
Add recent Snow Leopard failures.
- platform/chromium/test_expectations.txt:
- 11:49 AM Changeset in webkit [79713] by
-
- 2 edits6 moves6 deletes in trunk/LayoutTests
2011-02-25 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update.
Fix fast/inline/inline-box-background-repeat-x.html, fast/inline/
inline-box-background-repeat-y.html and fast/inline/
inline-box-background.html for Chromium Snow Leopard by promoting
chromium-mac-leopard results to mac-leopard and removing outdated
chromium-mac ones.
- platform/chromium-mac/fast/inline/inline-box-background-expected.checksum: Removed.
- platform/chromium-mac/fast/inline/inline-box-background-expected.png: Removed.
- platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.checksum: Removed.
- platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.png: Removed.
- platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.checksum: Removed.
- platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- platform/mac-leopard/fast/inline/inline-box-background-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-expected.checksum.
- platform/mac-leopard/fast/inline/inline-box-background-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-expected.png.
- platform/mac-leopard/fast/inline/inline-box-background-repeat-x-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-x-expected.checksum.
- platform/mac-leopard/fast/inline/inline-box-background-repeat-x-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-x-expected.png.
- platform/mac-leopard/fast/inline/inline-box-background-repeat-y-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-y-expected.checksum.
- platform/mac-leopard/fast/inline/inline-box-background-repeat-y-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-y-expected.png.
- 11:47 AM Changeset in webkit [79712] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-25 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
Move timeBeginPeriod into OS(WINDOWS) section
https://bugs.webkit.org/show_bug.cgi?id=55247
- jsc.cpp: (main): timeBeginPeriod is available on all Windows versions and not compiler specific.
- 11:46 AM Changeset in webkit [79711] by
-
- 6 edits2 copies in trunk/Source/WebKit2
2011-02-25 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> and Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement WebContext and NativeKeyboardEvent classes for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48510
- GNUmakefile.am:
- Shared/NativeWebKeyboardEvent.h: Added the GTK event attribute and constructors, in our case we need it because we use a pointer and copy the event. (WebKit::NativeWebKeyboardEvent::nativeEvent):
- Shared/gtk/NativeWebKeyboardEventGtk.cpp: Added. (WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent): We need to copy the event in the constructor to avoid two references to the same event.
- Shared/gtk/WebEventFactory.cpp: Changed the prototype of the functions to add const, we need it for the NativeWebKeyboardEvent constructor. (WebKit::modifiersForEvent): (WebKit::WebEventFactory::createWebKeyboardEvent):
- UIProcess/gtk/WebContextGtk.cpp: Added. Stubbed implementation for GTK port. Yet to implement. (WebKit::WebContext::applicationCacheDirectory): (WebKit::WebContext::platformInitializeWebProcess): (WebKit::WebContext::platformDefaultDatabaseDirectory):
- UIProcess/gtk/WebView.cpp: (WebKit::WebView::handleKeyboardEvent):
- 11:41 AM Changeset in webkit [79710] by
-
- 1 edit4 moves2 deletes in trunk/LayoutTests
2011-02-25 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update.
Fix fast/dom/34176.html and fast/dom/52776.html for Chromium Snow
Leopard by promoting chromium-mac-leopard results to mac-leopard and
removing outdated chromium-mac ones.
- platform/chromium-mac-leopard/fast/dom/52776-expected.txt: Removed.
- platform/chromium-mac/fast/dom/52776-expected.txt: Removed.
- platform/mac-leopard/fast/dom/34176-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/dom/34176-expected.checksum.
- platform/mac-leopard/fast/dom/34176-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/34176-expected.png.
- platform/mac-leopard/fast/dom/52776-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/dom/52776-expected.checksum.
- platform/mac-leopard/fast/dom/52776-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/52776-expected.png.
- 11:38 AM Changeset in webkit [79709] by
-
- 2 edits15 adds in trunk/LayoutTests
2011-02-25 James Robinson <jamesr@chromium.org>
More chromium expectations and baselines.
- platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.checksum: Added.
- platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png: Added.
- platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.checksum: Added.
- platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png: Added.
- platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.checksum: Added.
- platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 11:28 AM Changeset in webkit [79708] by
-
- 2 edits in trunk/LayoutTests
2011-02-25 James Robinson <jamesr@chromium.org>
Fix typo in Chromium test expectations.
- platform/chromium/test_expectations.txt:
- 11:20 AM Changeset in webkit [79707] by
-
- 2 edits in trunk/Source/JavaScriptCore
2011-02-25 Patrick Gansterer <Patrick Gansterer>
Unreviewed WinCE build fix for r79695.
- jsc.cpp: (main): SetErrorMode isn't available on WinCE.
- 11:18 AM Changeset in webkit [79706] by
-
- 3 edits28 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
Reviewed by Sam Weinig.
Patch computePositionedLogicalHeightReplaced to be writing-mode aware.
Added six new tests in fast/replaced.
Source/WebCore:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
LayoutTests:
- fast/replaced/vertical-lr: Added.
- fast/replaced/vertical-lr/absolute-position-percentage-width.html: Added.
- fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom.html: Added.
- fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right.html: Added.
- fast/replaced/vertical-rl: Added.
- fast/replaced/vertical-rl/absolute-position-percentage-width.html: Added.
- fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom.html: Added.
- fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right.html: Added.
- 11:17 AM Changeset in webkit [79705] by
-
- 2 edits6 adds in trunk/LayoutTests
2011-02-25 James Robinson <jamesr@chromium.org>
Update chromium expectations and baselines for some ruby tests.
- platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
- platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
- platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
- platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
- platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
- platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 11:15 AM Changeset in webkit [79704] by
-
- 2 edits8 moves8 deletes in trunk/LayoutTests
2011-02-25 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update.
Fix editing/selection/caret-rtl* for Chromium Snow Leopard. Remove
outdated chromium-mac baselines (the test will pass on Chromium SL with
the mac/ baselines). Promote the chromium-mac-leopard baselines to
mac-leopard (since the Mac port will pass with them on Leopard).
- platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Removed.
- platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png: Removed.
- platform/chromium-mac/editing/selection/caret-rtl-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/caret-rtl-expected.png: Removed.
- platform/chromium-mac/editing/selection/caret-rtl-right-expected.checksum: Removed.
- platform/chromium-mac/editing/selection/caret-rtl-right-expected.png: Removed.
- platform/chromium/test_expectations.txt:
- platform/mac-leopard/editing/selection/caret-rtl-2-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.checksum.
- platform/mac-leopard/editing/selection/caret-rtl-2-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.png.
- platform/mac-leopard/editing/selection/caret-rtl-2-left-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-2-left-expected.checksum.
- platform/mac-leopard/editing/selection/caret-rtl-2-left-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-2-left-expected.png.
- platform/mac-leopard/editing/selection/caret-rtl-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-expected.checksum.
- platform/mac-leopard/editing/selection/caret-rtl-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-expected.png.
- platform/mac-leopard/editing/selection/caret-rtl-right-expected.checksum: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-right-expected.checksum.
- platform/mac-leopard/editing/selection/caret-rtl-right-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/editing/selection/caret-rtl-right-expected.png.
- 11:14 AM Changeset in webkit [79703] by
-
- 2 edits in trunk/Source/WebKit/chromium
2011-02-15 Brett Wilson <brettw@chromium.org>
Reviewed by Darin Fisher.
Recover the mouse capture state when we recieve a mouse event where there is no longer a button down.
https://bugs.webkit.org/show_bug.cgi?id=54503
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleInputEvent):
- 11:08 AM Changeset in webkit [79702] by
-
- 10 edits in trunk/Source/WebKit2
2011-02-25 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Get rid of more old accelerated compositing code
https://bugs.webkit.org/show_bug.cgi?id=55235
- Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h:
- UIProcess/ChunkedUpdateDrawingAreaProxy.h:
- UIProcess/DrawingAreaProxy.h:
- UIProcess/DrawingAreaProxyImpl.cpp:
- UIProcess/DrawingAreaProxyImpl.h:
- WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
- WebProcess/WebPage/DrawingAreaImpl.h:
- 11:06 AM BuildingOnWindows edited by
- Clean up a bug link (diff)
- 11:01 AM Changeset in webkit [79701] by
-
- 3 edits in trunk/Source/WebCore
2011-02-25 Patrick Gansterer <Patrick Gansterer>
Unreviewed build fix.
- platform/text/brew/TextBreakIteratorBrew.cpp: (WebCore::acquireLineBreakIterator):
- platform/text/wince/TextBreakIteratorWinCE.cpp: (WebCore::acquireLineBreakIterator):
- 11:00 AM Changeset in webkit [79700] by
-
- 4 edits1 delete in trunk/LayoutTests
2011-02-25 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update.
editing/pasteboard/merge-end-list.html was failing on Chromium Snow
Leopard because it was picking up the .checksum file in chromium-mac/,
even though it would pass with the mac/ .png/.checksum. Additionally, the
chromium-mac .checksum had no corresponding .png.
Fixes things by deleting the lone .checksum in chromium-mac and updating
the mac-leopard results (which can be used by both the Mac and Chromium
ports).
- platform/chromium-mac/editing/pasteboard/merge-end-list-expected.checksum: Removed.
- platform/chromium/test_expectations.txt:
- platform/mac-leopard/editing/pasteboard/merge-end-list-expected.checksum:
- platform/mac-leopard/editing/pasteboard/merge-end-list-expected.png:
- 11:00 AM BuildingOnWindows edited by
- Add instructions for disabling UAC to get crash logs on Windows Vista/7 (diff)
- 10:58 AM Changeset in webkit [79699] by
-
- 3 edits4 adds in trunk
2011-02-25 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Simon Fraser.
[chromium] Adding test to ensure clipping layer gets updated when layout
width/height change in the page.
https://bugs.webkit.org/show_bug.cgi?id=55103
- platform/chromium/compositing/layout-width-change-expected.checksum: Added.
- platform/chromium/compositing/layout-width-change-expected.png: Added.
- platform/chromium/compositing/layout-width-change-expected.txt: Added.
- platform/chromium/compositing/layout-width-change.html: Added.
2011-02-25 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Simon Fraser.
Update the clip layer size whenever the root layer's size and position
is updated. This only affects the accelerated compositing path.
https://bugs.webkit.org/show_bug.cgi?id=55103
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition):
Test: platform/chromium/compositing/layout-width-change.html
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition):
- 10:46 AM Changeset in webkit [79698] by
-
- 2 edits in trunk/Tools
Double-check that modifying the registry worked
On Windows Vista/7 with UAC enabled, regtool will fail to modify the registry, but it will
still return a successful exit code. So we double-check here that the value we tried to
write to the registry was really written.
Fixes <http://webkit.org/b/55227> old-run-webkit-tests falsely claims to be saving crash
logs on Windows Vista/7
Reviewed by Darin Adler.
- Scripts/old-run-webkit-tests:
(writeRegistryString): After trying to write the string value, check that it was really
written.
- 10:46 AM Changeset in webkit [79697] by
-
- 2 edits in trunk/Tools
Set the 32-bit post-mortem debugger on 64-bit OSes
The post-mortem debugger is controlled by some registry values in
HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\AeDebug. On 64-bit OSes, you can either
set the values in that key, which will be used for 64-bit apps, or in the equivalent key
under Wow6432Node, which will be used for 32-bit apps. Since DumpRenderTree and
WebKitTestRunner are 32-bit, we want to use the latter location.
Fixes <http://webkit.org/b/55225> old-run-webkit-tests sets the post-mortem debugger for
64-bit apps, but should set it for 32-bit apps instead
Reviewed by Darin Adler.
- Scripts/old-run-webkit-tests:
(readRegistryString):
(writeRegistryString):
Pass --wow32 to regtool so it will get/set values beneath Wow6432Node, which is where
Windows looks for the post-mortem debugger values when a 32-bit app crashes on a 64-bit OS.
Passing --wow32 on a 32-bit OS will not have any effect.
- 10:45 AM Changeset in webkit [79696] by
-
- 2 edits in trunk/Tools
Clean up code to set up crash log saving on Windows
Fixes <http://webkit.org/b/55224> old-run-webkit-test's Windows registry code is ugly
Reviewed by David Kilzer.
- Scripts/old-run-webkit-tests:
(readRegistryString):
(writeRegistryString):
Moved code to read strings from and write strings to the registry here...
(setUpWindowsCrashLogSaving): ...from here.
- 10:45 AM Changeset in webkit [79695] by
-
- 9 edits in trunk
Work around Cygwin's crash-suppression behavior
Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which any processes it launches will
inherit. This is bad for testing/debugging, as it causes the post-mortem debugger not to be
invoked. (Cygwin does this because it makes crashes more UNIX-y.) We reset the error mode
when our test apps launch to work around Cygwin's behavior.
Fixes <http://webkit.org/b/55222> Test apps crash silently (without invoking post-mortem
debugger) when launched from Cygwin 1.7
Reviewed by Darin Adler.
Source/JavaScriptCore:
- API/tests/testapi.c: Added a now-needed #include.
(main):
- jsc.cpp:
(main):
Call ::SetErrorMode(0) to undo Cygwin's folly.
- JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Define NOMINMAX like many of our
other projects do so that windows.h won't define min/max macros that interfere with
std::numeric_limits<T>::min/max.
Tools:
- DumpRenderTree/win/DumpRenderTree.cpp:
(main):
- TestWebKitAPI/win/main.cpp:
(main):
- WebKitAPITest/main.cpp:
(main):
- WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::platformInitialize):
Call ::SetErrorMode(0) to undo Cygwin's folly.
- 10:34 AM Changeset in webkit [79694] by
-
- 12 edits in trunk/Source/WebCore
Minimize calls to ubrk_setText()
https://bugs.webkit.org/show_bug.cgi?id=54912
<rdar://problem/9032774>
Patch by Ned Holbrook <nholbrook@apple.com> on 2011-02-25
Reviewed by Dan Bernstein.
Avoid calling ubrk_setText() once per call to isBreakable() by using a LazyLineBreakIterator, which defers
break iterator creation until needed. This requires replacing the global line break iterator primitive with a
version that can be nested, since in some cases two iterators may need to be outstanding. In particular,
layoutInlineChildren() may indirectly call computePreferredLogicalWidths() and each may need an iterator.
In a test with a paragraph of Japanese text, this reduced the number of ubrk_setText() calls from 164 to 1.
- platform/text/TextBreakIterator.h: Add LazyLineBreakIterator.
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::~LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::string):
(WebCore::LazyLineBreakIterator::length):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):
- platform/text/TextBreakIteratorICU.cpp: Replace lineBreakIterator() primitive with acquireLineBreakIterator()/releaseLineBreakIterator().
(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):
- platform/text/brew/TextBreakIteratorBrew.cpp: Ditto.
(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):
- platform/text/gtk/TextBreakIteratorGtk.cpp: Ditto.
(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):
- platform/text/qt/TextBreakIteratorQt.cpp: Ditto.
(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):
- platform/text/wince/TextBreakIteratorWinCE.cpp: Ditto.
(WebCore::acquireLineBreakIterator):
(WebCore::releaseLineBreakIterator):
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren): Pass a mapping of RenderText to LazyLineBreakIterator from one call of findNextLineBreak() to the next.
(WebCore::RenderBlock::findNextLineBreak): Use said mapping, resetting LazyLineBreakIterator for any newly-encountered RenderText.
- rendering/RenderText.cpp: Use a local LazyLineBreakIterator.
(WebCore::RenderText::computePreferredLogicalWidths):
- rendering/break_lines.cpp: Accept LazyLineBreakIterator rather than UniChar buffer.
(WebCore::nextBreakablePosition):
- rendering/break_lines.h: Accept LazyLineBreakIterator rather than UniChar buffer.
(WebCore::isBreakable):
- 10:28 AM Changeset in webkit [79693] by
-
- 1 edit3 adds in trunk/LayoutTests
[Windows 7 Release Tests] fast/ruby/base-shorter-than-text.html failing since introduction
in r79629.
https://bugs.webkit.org/show_bug.cgi?id=55230
Add Windows-specific expected results. Unreviewed.
- platform/win/fast/ruby/base-shorter-than-text-expected.checksum: Added.
- platform/win/fast/ruby/base-shorter-than-text-expected.png: Added.
- platform/win/fast/ruby/base-shorter-than-text-expected.txt: Added.
- 10:25 AM Changeset in webkit [79692] by
-
- 1 edit9 adds in trunk/LayoutTests
2011-02-25 Sergio Villar Senin <svillar@igalia.com>
Unreviewed.
Added new GTK+ expectations for new tests.
- platform/gtk/svg/custom/animate-target-id-changed-expected.checksum: Added.
- platform/gtk/svg/custom/animate-target-id-changed-expected.png: Added.
- platform/gtk/svg/custom/animate-target-id-changed-expected.txt: Added.
- platform/gtk/svg/custom/animate-target-removed-from-document-expected.checksum: Added.
- platform/gtk/svg/custom/animate-target-removed-from-document-expected.png: Added.
- platform/gtk/svg/custom/animate-target-removed-from-document-expected.txt: Added.
- platform/gtk/transitions/default-timing-function-expected.checksum: Added.
- platform/gtk/transitions/default-timing-function-expected.png: Added.
- platform/gtk/transitions/default-timing-function-expected.txt: Added.
- 10:11 AM Changeset in webkit [79691] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.
Reviewed by Sam Weinig.
Patch computePositionedLogicalWidthReplaced to be writing-mode aware. Not testable yet, since the height function overwrites the values
in a vertical text environment.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
- 10:07 AM Changeset in webkit [79690] by
-
- 3 edits1 add in trunk/Source
2011-02-25 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Make the WebKit2 build system less confusing for non-Qt developers
https://bugs.webkit.org/show_bug.cgi?id=55213
- QtWebKit.pro: Move the WebKit2 API into a project include file in the WebKit2 directory and include the pri file here.
2011-02-25 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Make the WebKit2 build system less confusing for non-Qt developers
https://bugs.webkit.org/show_bug.cgi?id=55213
- WebKit2API.pri: Added.
- 9:51 AM Changeset in webkit [79689] by
-
- 3 edits3 adds in trunk
2011-02-25 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
Tests that we do not crash when removing a text node adjacent to a word break node.
https://bugs.webkit.org/show_bug.cgi?id=55206
- fast/text/resources/word-break-next-linebox-not-dirty-crash.html: Added.
- fast/text/word-break-next-linebox-not-dirty-crash-main-expected.txt: Added.
- fast/text/word-break-next-linebox-not-dirty-crash-main.html: Added.
2011-02-25 Abhishek Arya <inferno@chromium.org>
Reviewed by Dave Hyatt.
When trying to find which lines to dirty for a changed child, make sure
that we do test if the adjacent next linebox contains that changed child
and if yes, dirty it. This can happen in cases when we have a word break
between text nodes.
https://bugs.webkit.org/show_bug.cgi?id=55206
Test: fast/text/word-break-next-linebox-not-dirty-crash-main.html
- rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
- 9:35 AM Changeset in webkit [79688] by
-
- 2 edits in trunk/LayoutTests
2011-02-25 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium Snow Leopard expectations update. Remove failing
expectations for tests that pass after r79653. Add one more known
failure and flake.
- platform/chromium/test_expectations.txt:
- 9:27 AM Changeset in webkit [79687] by
-
- 1 edit1 add in trunk/Source/WebKit/gtk/po
Unreviewed translation file.
L10N: Webkit translated to Basque (eu) language
https://bugs.webkit.org/show_bug.cgi?id=36588
- eu.po: Added.
- 9:04 AM Changeset in webkit [79686] by
-
- 3 edits in trunk/Source/WebKit/qt
Unreviewed build fix for Intel ICC and MSVC.
Patch by Alexis Menard <alexis.menard@openbossa.org> on 2011-02-25
- tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::setPalette):
- tests/qwebview/tst_qwebview.cpp:
(tst_QWebView::setPalette):
- 8:56 AM Changeset in webkit [79685] by
-
- 2 edits in trunk/LayoutTests
2011-02-25 Sergio Villar Senin <svillar@igalia.com>
Unreviewed.
Added an inspector test that fails on GTK debug bots.
- platform/gtk/Skipped: inspector/extensions/extensions-events.html
- 8:43 AM Changeset in webkit [79684] by
-
- 1 edit in trunk/LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt
Unreviewed. Chromium expectations.
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt
- 8:15 AM Changeset in webkit [79683] by
-
- 3 edits in trunk/Source/WebKit/qt
2011-02-25 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Properly propagate the palette to QWebPage from QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=31742
Discovered while looking at 31742. When we set a palette on the
QGraphicsWebView we need to propagate it to the page like QWebView.
I have added the same tests as QWebView to be sure to catch potential
regressions as well as two extras QVERIFY to check the palette propagation.
- Api/qgraphicswebview.cpp: (QGraphicsWebView::event):
- tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::setPalette_data): (tst_QGraphicsWebView::setPalette):
- 8:13 AM Changeset in webkit [79682] by
-
- 3 edits2 adds in trunk
2011-02-25 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [Text editor] Add basic layout tests for the highlighter
https://bugs.webkit.org/show_bug.cgi?id=54751
Adding basic tests for the highlighter.
- inspector/editor/highlighter-basics-expected.txt: Added.
- inspector/editor/highlighter-basics.html: Added.
2011-02-25 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [Text editor] Add basic layout tests for the highlighter
https://bugs.webkit.org/show_bug.cgi?id=54751
Test: inspector/editor/highlighter-basics.html
- inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter.prototype.highlight):
- 7:02 AM Changeset in webkit [79681] by
-
- 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt
Unreviewed. Temporary disabling a newly added test.
- platform/chromium/test_expectations.txt
- 6:10 AM Changeset in webkit [79680] by
-
- 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt
Unreviewed. Correcting test expectations.
- platform/chromium/test_expectations.txt
- 5:52 AM Changeset in webkit [79679] by
-
- 1 edit38 adds in trunk/LayoutTests
2011-02-25 Sergio Villar Senin <svillar@igalia.com>
Unreviewed.
Added new GTK test expectations.
- platform/gtk/fast/block/positioning/vertical-lr: Added 6 new test expectations.
- platform/gtk/fast/block/positioning/vertical-rl: Added 6 new test expectations.
- 5:41 AM Changeset in webkit [79678] by
-
- 3 edits in trunk/Source/WebKit/qt
Unreviewed buildfix after r79672.
[Qt] Build tst_qdeclarativewebview if QT_CONFIG contains declarative.
- tests/tests.pri:
- tests/tests.pro:
- 5:35 AM Changeset in webkit [79677] by
-
- 2 edits in trunk/Source/WebCore
2011-02-24 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Huge fonts in font preview
https://bugs.webkit.org/show_bug.cgi?id=55143
- inspector/front-end/FontView.js: (WebInspector.FontView.prototype._createContentIfNeeded): (WebInspector.FontView.prototype.show): (WebInspector.FontView.prototype.resize): (WebInspector.FontView.prototype._measureElement): (WebInspector.FontView.prototype.updateFontPreviewSize):
- 5:13 AM Changeset in webkit [79676] by
-
- 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt
Unreviewed. Updating test expectations for Chromium.
- platform/chromium/test_expectations.txt
- 5:08 AM Changeset in webkit [79675] by
-
- 23 edits6 adds in trunk
2011-02-25 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Implement SVGColor/SVGPaint API
https://bugs.webkit.org/show_bug.cgi?id=55119
SVGColor::cssText() shouldn't return #RRGGBBAA colors
https://bugs.webkit.org/show_bug.cgi?id=48120
Rewrite SVGColor/SVGPaint to actually implement their desired setPaint/setColor/setURI APIs.
SVGPaint is a CSSValue, and its setPaint() function allows to switch to an arbitary paint type.
That means, unlike all other CSSValues, SVGColor/SVGPaint are mutable. That means changes to
their CSSValues should be reflected in the elements style as well as in the computed style.
This patch doesn't yet implement that, the stubbed-out method valueChanged() is what
needs to be implemented. For now you can grab a SVGColor/SVGPaint object through getCSSPropertyValue
and manipulate it, in every possible way (SVPaint.uri/paintType/colorType/color attributes are all sync'ed).
Switch to strict JS bindings (RequiresAllArguments=Raise, StrictTypeChecking) for both objects.
Enable proper serialization of colors through Color::serialized(), affects some testcases (#FF.. -> #ff..)
Add extensive tests of all SVGColor/SVGPaint API, currently shows some FAIL messages, as element style
<-> computed style is not live, after mutating SVGColor/SVGPaint. That will be implemented in a follow-up patch.
Tests: svg/dom/SVGColor.html
svg/dom/SVGPaint.html
- bindings/scripts/CodeGenerator.pm: Remove obsolete handling of "SVGPaintType", take ushort for paintType, as specified in the SVG 1.1 IDLs.
- bindings/scripts/CodeGeneratorJS.pm: Ditto.
- bindings/scripts/CodeGeneratorObjC.pm: Ditto.
- bindings/scripts/CodeGeneratorV8.pm: Ditto.
- css/SVGCSSParser.cpp: Adapt to SVGPaint/SVGColor create() naming convention changes. (WebCore::CSSParser::parseSVGValue): (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
- svg/SVGColor.cpp: Rewrite to fully implement the SVGColor API, merge all constructors into one, use more descriptable create() naming convention. (WebCore::valueChanged): Stub implementation, will land in a follow-up patch. (WebCore::SVGColor::SVGColor): (WebCore::SVGColor::setRGBColor): (WebCore::SVGColor::colorFromRGBColorString): (WebCore::SVGColor::setRGBColorICCColor): (WebCore::SVGColor::setColor): (WebCore::SVGColor::cssText):
- svg/SVGColor.h: (WebCore::SVGColor::createFromString): (WebCore::SVGColor::createFromColor): (WebCore::SVGColor::color): (WebCore::SVGColor::colorType): (WebCore::SVGColor::~SVGColor): (WebCore::SVGColor::setColor): (WebCore::SVGColor::setColorType):
- svg/SVGColor.idl: Enable strict type checking.
- svg/SVGPaint.cpp: Rewrite to fully implement the SVGPaint API, merge all constructors into one, use more descriptable create() naming convention. (WebCore::valueChanged): Stub implementation, will land in a follow-up patch. (WebCore::colorTypeForPaintType): (WebCore::SVGPaint::SVGPaint): (WebCore::SVGPaint::setUri): (WebCore::SVGPaint::defaultFill): (WebCore::SVGPaint::defaultStroke): (WebCore::SVGPaint::setPaint): (WebCore::SVGPaint::cssText): (WebCore::SVGPaint::matchesTargetURI):
- svg/SVGPaint.h: (WebCore::SVGPaint::createUnknown): (WebCore::SVGPaint::createNone): (WebCore::SVGPaint::createCurrentColor): (WebCore::SVGPaint::createColor): (WebCore::SVGPaint::createURI): (WebCore::SVGPaint::createURIAndColor): (WebCore::SVGPaint::paintType): (WebCore::SVGPaint::uri): (WebCore::SVGPaint::create): (WebCore::SVGPaint::isSVGPaint):
- svg/SVGPaint.idl: Enable strict type checking.
2011-02-25 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Implement SVGColor/SVGPaint API
https://bugs.webkit.org/show_bug.cgi?id=55119
SVGColor::cssText() shouldn't return #RRGGBBAA colors
https://bugs.webkit.org/show_bug.cgi?id=48120
Add two new tests covering the SVGColor/SVGPaint APIs.
Adapt to SVGColor::cssText() changes, color is properly serialized now.
- svg/animations/animate-color-transparent-expected.txt:
- svg/animations/animate-currentColor-expected.txt:
- svg/animations/animate-dynamic-update-attributeName-expected.txt:
- svg/animations/animate-inherit-css-property-expected.txt:
- svg/animations/script-tests/animate-color-transparent.js: (expectTransparent): (expectOtherColor):
- svg/animations/script-tests/animate-currentColor.js: (sample1):
- svg/animations/script-tests/animate-inherit-css-property.js: (sample1):
- svg/css/getComputedStyle-basic-expected.txt:
- svg/custom/getPresentationAttribute-modify.svg:
- svg/custom/rgbcolor-syntax.svg:
- svg/dom/SVGColor-expected.txt: Added.
- svg/dom/SVGColor.html: Added.
- svg/dom/SVGPaint-expected.txt: Added.
- svg/dom/SVGPaint.html: Added.
- svg/dom/script-tests/SVGColor.js: Added. (checkStopColor):
- svg/dom/script-tests/SVGPaint.js: Added. (resetStyle): (checkFillColor):
- 4:59 AM Changeset in webkit [79674] by
-
- 10 edits5 adds in trunk
2011-02-25 Renata Hodovan <reni@webkit.org>
Reviewed by Nikolas Zimmermann.
FESpecularLightingElement changes doesn't require relayout.
https://bugs.webkit.org/show_bug.cgi?id=54451
When the FESpecularLightingElement receives an update message but the given value remains the same we don't need
to relayout the filter. Otherwise, the light source requests a repaint on the specular lighting filter.
Besides add ASSERTs to DiffuseLightElement::setFilterEffectAttribute as well to avoid lightSources being null.
No new tests are needed to check the repaint because it is covered by the dynamic update tests of FESpecularLighting.
We only test what happens if we remove the light source of specularLight.
Test: svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html
- platform/graphics/filters/FESpecularLighting.cpp: (WebCore::FESpecularLighting::setSurfaceScale): (WebCore::FESpecularLighting::setSpecularConstant): (WebCore::FESpecularLighting::setSpecularExponent): (WebCore::FESpecularLighting::setKernelUnitLengthX): (WebCore::FESpecularLighting::setKernelUnitLengthY):
- platform/graphics/filters/FESpecularLighting.h:
- rendering/svg/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::postApplyResource):
- svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute): (WebCore::SVGFEDiffuseLightingElement::lightElementAttributeChanged): (WebCore::SVGFEDiffuseLightingElement::build):
- svg/SVGFEDiffuseLightingElement.h:
- svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::findLightElement): (WebCore::SVGFELightElement::findLight): (WebCore::SVGFELightElement::svgAttributeChanged):
- svg/SVGFELightElement.h:
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute): (WebCore::SVGFESpecularLightingElement::svgAttributeChanged): (WebCore::SVGFESpecularLightingElement::lightElementAttributeChanged): (WebCore::SVGFESpecularLightingElement::build):
- svg/SVGFESpecularLightingElement.h:
2011-02-25 Renata Hodovan <reni@webkit.org>
Reviewed by Nikolas Zimmermann.
FESpecularLightingElement changes doesn't require relayout.
https://bugs.webkit.org/show_bug.cgi?id=54451
Test what happens if we remove the light source of specularLight.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.txt: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html: Added.
- svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-remove-lightSource.js: Added. (executeTest):
- 4:51 AM Changeset in webkit [79673] by
-
- 6 edits in trunk/LayoutTests/platform
Unreviewed.
Updated test expectations for Chromium.
- platform/chromium-linux/fast/ruby/base-shorter-than-text-expected.png
- platform/chromium-linux/fast/ruby/base-shorter-than-text-expected.checksum
- platform/chromium-linux/fast/ruby/base-shorter-than-text-expected.txt
- platform/chromium-win/fast/ruby/base-shorter-than-text-expected.png
- platform/chromium-win/fast/ruby/base-shorter-than-text-expected.checksum
- platform/chromium-win/fast/ruby/base-shorter-than-text-expected.txt
- 4:48 AM Changeset in webkit [79672] by
-
- 4 edits7 adds in trunk/Source/WebKit/qt
2011-02-25 Gopal Raghavan <gopal.1.raghavan@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QML WebView inside a Flickable shows checkers pattern at startup
https://bugs.webkit.org/show_bug.cgi?id=50222.
This patch fixes the checkerboard visible at startup even if preferredWidth and preferredHeight are not set.
- declarative/qdeclarativewebview.cpp: (QDeclarativeWebView::init):
- tests/qdeclarativewebview: Added.
- tests/qdeclarativewebview/qdeclarativewebview.pro: Added.
- tests/qdeclarativewebview/resources: Added.
- tests/qdeclarativewebview/resources/webviewtest.qml: Added.
- tests/qdeclarativewebview/resources/webviewtestdefault.qml: Added.
- tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Added. (tst_QDeclarativeWebView::initTestCase): (tst_QDeclarativeWebView::cleanupTestCase): (tst_QDeclarativeWebView::init): (tst_QDeclarativeWebView::cleanup): (tst_QDeclarativeWebView::preferredWidthTest): (tst_QDeclarativeWebView::preferredHeightTest): (tst_QDeclarativeWebView::preferredWidthDefaultTest): (tst_QDeclarativeWebView::preferredHeightDefaultTest): (tst_QDeclarativeWebView::checkNoErrors):
- tests/tests.pri:
- tests/tests.pro:
- 3:44 AM Changeset in webkit [79671] by
-
- 4 edits1 copy3 adds in trunk/Source/WebKit2
2011-02-25 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> and Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement WebView and WebKitWebView classes for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48509
- GNUmakefile.am:
- UIProcess/API/C/gtk/WKView.cpp:
- UIProcess/API/C/gtk/WKView.h: Removed gdkrectangle from constructor.
- UIProcess/gtk/WebViewWidget.cpp: Added. The GObject interface for WebView. The GObject is the GtkWidget handle which is used by WebView class for GTK port.
- UIProcess/gtk/WebViewWidget.h: Added. The GObject interface declarations for GtkWidget handle for GTK port.
- UIProcess/gtk/WebView.cpp: Added. The native GtkWidget handle for GTK port which is associated with each WKViewRef.
- UIProcess/gtk/WebView.h: Added. Class which implements the PageClient interface. It is a wrapper over the native GtkWidget handle associated with each WKViewRef for GTK port.
- 3:40 AM Changeset in webkit [79670] by
-
- 2 edits in trunk/Source/WebKit2
2011-02-25 Alejandro G. Castro <alex@igalia.com>
Fix GTK compilation after r79654.
- GNUmakefile.am:
- 3:24 AM Changeset in webkit [79669] by
-
- 3 edits in trunk/LayoutTests
2011-02-25 Sergio Villar Senin <svillar@igalia.com>
Unreviewed.
Updated GTK test expectations after r79618.
- platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
- platform/gtk/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
- 3:07 AM Changeset in webkit [79668] by
-
- 15 edits2 deletes in trunk
[Qt] Revert the support for QNAM affined to a different thread.
https://bugs.webkit.org/show_bug.cgi?id=55149
Reviewed by Andreas Kling.
Qt 4.8 will have QNAM use its own thread internally by default,
no need to keep this complexity in WebKit.
This mainly reverts:
http://trac.webkit.org/changeset/73710
http://trac.webkit.org/changeset/73712
Source/WebCore:
- WebCore.pro:
- platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::commitLoad):
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::FormDataIODevice::FormDataIODevice):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::setLoadMode):
(WebCore::QNetworkReplyHandler::abort):
(WebCore::QNetworkReplyHandler::release):
(WebCore::ignoreHttpError):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::start):
(WebCore::QNetworkReplyHandler::sendQueuedItems):
- platform/network/qt/QNetworkReplyHandler.h:
(WebCore::QNetworkReplyHandler::reply):
- platform/network/qt/QtNAMThreadSafeProxy.cpp: Removed.
- platform/network/qt/QtNAMThreadSafeProxy.h: Removed.
- platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::willLoadFromCache):
- platform/qt/CookieJarQt.cpp:
(WebCore::cookieJar):
(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
Source/WebKit/qt:
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::download):
- tests/qwebpage/tst_qwebpage.cpp:
Tools:
- QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::~LauncherWindow):
(LauncherWindow::initializeView):
(LauncherWindow::createChrome):
- QtTestBrowser/launcherwindow.h:
(WindowOptions::WindowOptions):
- QtTestBrowser/webpage.cpp:
(WebPage::WebPage):
- QtTestBrowser/webpage.h:
- 2:44 AM Changeset in webkit [79667] by
-
- 2 edits in trunk/Source/WebKit/mac
<rdar://problem/8902546> Build fix.
- Misc/QuickDrawCompatibility.h:
- 2:05 AM Changeset in webkit [79666] by
-
- 2 edits in trunk/LayoutTests
2011-02-25 Sergio Villar Senin <svillar@igalia.com>
Unreviewed.
Skipped 3 SVG tests failing in GTK 32-bit release bot.
- platform/gtk/Skipped:
- 1:12 AM Changeset in webkit [79665] by
-
- 4 edits in trunk/LayoutTests
Unreviewed.
Update a Qt specific expected file after r79618.
- platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.checksum:
- platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.png:
- platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
- 12:30 AM Changeset in webkit [79664] by
-
- 5 edits in trunk/Source/WebCore
2011-02-25 Renata Hodovan <reni@webkit.org>
Reviewed by Andreas Kling.
FEBlendElement changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=55138
When the FEBlendElement receives an update message but the given value remains the same we don't need
to relayout the filter.
No new tests are needed because this modificiation is covered by the dynamic update tests of FEBlend.
- platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::setBlendMode):
- platform/graphics/filters/FEBlend.h:
- svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::setFilterEffectAttribute): (WebCore::SVGFEBlendElement::svgAttributeChanged): (WebCore::SVGFEBlendElement::synchronizeProperty):
- svg/SVGFEBlendElement.h:
