Timeline



Mar 17, 2011:

11:59 PM Changeset in webkit [81446] by Adam Roben
  • 3 edits in trunk/Tools

Allow values in Leaks Viewer to be shown as percentages

Double-clicking on a column will toggle between showing percentages and showing real values.

Fixes <​http://webkit.org/b/56628> Would like to view values as percentages of the total
number of leaked bytes in Leaks Viewer

Reviewed by Joe Pecoraro.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:

(LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
node's totalTime, which is used in calculating percentages.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:

(monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
showing them as percentages.

11:58 PM Changeset in webkit [81445] by Adam Roben
  • 3 edits in trunk/Tools

Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer

The Self and Total columns now report the number of leaked bytes. The new Calls column shows
the number of leaked allocations. And the new Average column shows the average number of
leaked bytes per call.

Fixes <​http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
just how many allocations

Reviewed by Joe Pecoraro.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:

(LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
line and store it with the leak stack.
(LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
properties.
(LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
.numberOfCalls now holds the number of leaked allocations.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:

(Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
appear.
(monkeyPatchInspectorObjects): Format the values as bytes.

10:39 PM Changeset in webkit [81444] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a test that is likely causing later tests to assert

<​http://webkit.org/b/56599> tracks the failure.

  • platform/win/Skipped: Replaced editing/deleting/5206311-1.html with

editing/deleting/5168598.html, which is likely causing the former to assert.

10:19 PM Changeset in webkit [81443] by Adam Roben
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows XP results for test added in r81404

The differences from Windows 7 seem to be due to different fonts being used.

  • platform/win-xp/fast/text/emphasis-combined-text-expected.txt: Added.
10:18 PM Changeset in webkit [81442] by Adam Roben
  • 2 edits in trunk/Tools

Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests

Fixes <​http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
regression tests

Reviewed by James Robinson.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:

(RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
is always populated, even when all regression tests pass.

10:09 PM Changeset in webkit [81441] by hayato@chromium.org
  • 3 edits in trunk/Tools

2011-03-10 Hayato Ito <​hayato@chromium.org>

Reviewed by Tony Chang.

Add a check logic for reftests in case that a reftest is marked AS REBASELINE.

​https://bugs.webkit.org/show_bug.cgi?id=56076

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
9:10 PM Changeset in webkit [81440] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-03-17 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QML WebView emits iconChanged() when the page title changes
​https://bugs.webkit.org/show_bug.cgi?id=56570

  • declarative/qdeclarativewebview.cpp: (QDeclarativeWebView::setPage): Don't forward the frame's titleChanged signal to the view's iconChanged signal.
9:03 PM Changeset in webkit [81439] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add some of the remaining platform/mac files to WebCore GYP build
​https://bugs.webkit.org/show_bug.cgi?id=56616

These files used to be hard, but are now magically easy. 76 link errors.

  • gyp/WebCore.gyp:
8:53 PM Changeset in webkit [81438] by commit-queue@webkit.org
  • 17 edits in trunk

2011-03-17 Adam Klein <​adamk@chromium.org>

Reviewed by Adam Barth.

[filesystem] Rename toURI->toURL, resolveLocalFileSystemURI->resolveLocalFileSystemURL
​https://bugs.webkit.org/show_bug.cgi?id=56502

Leaving the file names as-is for now to avoid svn-apply's
handling of move-and-modify.

  • fast/filesystem/directory-entry-to-uri-expected.txt:
  • fast/filesystem/file-entry-to-uri-expected.txt:
  • fast/filesystem/resources/directory-entry-to-uri.js:
  • fast/filesystem/resources/file-entry-to-uri-sync.js:
  • fast/filesystem/resources/file-entry-to-uri.js:
  • fast/filesystem/workers/file-entry-to-uri-sync-expected.txt:
  • http/tests/filesystem/resolve-uri-expected.txt:
  • http/tests/filesystem/script-tests/resolve-uri.js:

2011-03-17 Adam Klein <​adamk@chromium.org>

Reviewed by Adam Barth.

[filesystem] Rename toURI->toURL, resolveLocalFileSystemURI->resolveLocalFileSystemURL
​https://bugs.webkit.org/show_bug.cgi?id=56502

  • fileapi/Entry.idl:
  • fileapi/EntryBase.cpp: (WebCore::EntryBase::toURL):
  • fileapi/EntryBase.h:
  • fileapi/EntrySync.idl:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::resolveLocalFileSystemURL):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
8:40 PM Changeset in webkit [81437] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/696

Merge 80672
BUG=75311

8:39 PM Changeset in webkit [81436] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/648

Merge 80672
BUG=75311
Review URL: ​http://codereview.chromium.org/6711031

8:25 PM Changeset in webkit [81435] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/648

Merge 80487
BUG=74991
Review URL: ​http://codereview.chromium.org/6685081

8:20 PM Changeset in webkit [81434] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/648

Merge 80144
BUG=74562
Review URL: ​http://codereview.chromium.org/6711030

8:10 PM Changeset in webkit [81433] by cevans@google.com
  • 2 edits in branches/chromium/648

Merge 80043
BUG=74720
Review URL: ​http://codereview.chromium.org/6711029

8:06 PM Changeset in webkit [81432] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/696

Merge 80579
BUG=75155

8:05 PM Changeset in webkit [81431] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/648

Merge 80579
BUG=75155
Review URL: ​http://codereview.chromium.org/6712027

7:57 PM Changeset in webkit [81430] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/648

Merge 80520
BUG=75170
Review URL: ​http://codereview.chromium.org/6714006

7:49 PM Changeset in webkit [81429] by cevans@google.com
  • 1 edit in branches/chromium/648/Source/WebCore/plugins/PluginView.cpp

Merge 79897
BUG=73216
Review URL: ​http://codereview.chromium.org/6711028

7:46 PM Changeset in webkit [81428] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/648

Merge 79808
BUG=73216
Review URL: ​http://codereview.chromium.org/6709019

7:43 PM Changeset in webkit [81427] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the build.

  • WebKit2.xcodeproj/project.pbxproj:
7:14 PM Changeset in webkit [81426] by simonjam@chromium.org
  • 19 edits
    11 adds in trunk/LayoutTests

2011-03-17 James Simonsen <​simonjam@chromium.org>

Unreviewed, rebaseline a bunch of chromium tests.

  • platform/chromium-mac-leopard/fast/block/positioning/auto/vertical-lr/007-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/auto/vertical-rl/007-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
  • platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/english-lr-text-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/english-lr-text-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.png: Added.
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.png:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.checksum:
  • platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.checksum:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-mac-leopard/fast/ruby/base-shorter-than-text-expected.checksum: Added.
  • platform/chromium-mac-leopard/fast/ruby/base-shorter-than-text-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.checksum:
  • platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.png:
6:58 PM Changeset in webkit [81425] by abarth@webkit.org
  • 4 edits
    2 adds in trunk

2011-03-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Update CSP directive parser to match spec
​https://bugs.webkit.org/show_bug.cgi?id=56582

Test some error-handling cases.

  • http/tests/security/contentSecurityPolicy/directive-parsing-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/directive-parsing.html: Added.

2011-03-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Update CSP directive parser to match spec
​https://bugs.webkit.org/show_bug.cgi?id=56582

Brandon updated the CSP spec. I've updated our implementation to
match. In the process, I found a couple bugs in the spec, which I've
sent to the working group. This patch assumes that the bugs will be
fixed in the way I suggested. If they get fixed a different way, we
might need to update the parser again.

Test: http/tests/security/contentSecurityPolicy/directive-parsing.html

  • page/ContentSecurityPolicy.cpp: (WebCore::isDirectiveNameCharacter): (WebCore::isDirectiveValueCharacter): (WebCore::advanceUntil): (WebCore::ContentSecurityPolicy::parse): (WebCore::ContentSecurityPolicy::parseDirective):
  • page/ContentSecurityPolicy.h:
6:36 PM Changeset in webkit [81424] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-03-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should have PrivateHeaders
​https://bugs.webkit.org/show_bug.cgi?id=56604

I've manually verified that this produces the correct set of
PrivateHeaders (modulo the ForwardingHeaders and icu issue).
Unforunately, this patch breakes compile slightly, but I'll fix that
in a followup patch.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • gyp/WebCore.gyp:
6:31 PM Changeset in webkit [81423] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-17 James Simonsen <​simonjam@chromium.org>

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
6:17 PM Changeset in webkit [81422] by kbr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-17 Alexey Marinichev <​amarinichev@chromium.org>

Reviewed by Kenneth Russell.

chromium: uninitialized field in WebViewImpl
​https://bugs.webkit.org/show_bug.cgi?id=56620

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
6:11 PM Changeset in webkit [81421] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-03-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Implement PluginProcessProxy::setFullscreenWindowIsShowing
​https://bugs.webkit.org/show_bug.cgi?id=56618

  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::PluginProcessProxy): Initialize m_fullscreenWindowIsShowing.

(WebKit::PluginProcessProxy::didClose):
if m_fullscreenWindowIsShowing is true, call exitFullscreen.

  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm: (WebKit::PluginProcessProxy::getPluginProcessSerialNumber): Add helper function for getting a PSN for the plug-in process.

(WebKit::PluginProcessProxy::makePluginProcessTheFrontProcess):
Make the plug-in process the front process.

(WebKit::PluginProcessProxy::makeUIProcessTheFrontProcess):
Make the current process (the UI process) the front process.

(WebKit::PluginProcessProxy::setFullscreenWindowIsShowing):
Call enterFullscreen or exitFullscreen.

(WebKit::PluginProcessProxy::enterFullscreen):
Make the plug-in process the front process and hide the menu bar.

(WebKit::PluginProcessProxy::exitFullscreen):
Show the menu bar and if necessary make the UI process the front process.

(WebKit::PluginProcessProxy::endModal):
call makeUIProcessTheFrontProcess.

(WebKit::PluginProcessProxy::applicationDidBecomeActive):
Call makePluginProcessTheFrontProcess.

6:11 PM Changeset in webkit [81420] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-17 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Mark Rowe.

Fixed some string leaks seen on the buildbot
​https://bugs.webkit.org/show_bug.cgi?id=56619

  • runtime/PropertyMapHashTable.h: (JSC::PropertyTable::~PropertyTable): DEref!
5:52 PM Changeset in webkit [81419] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Make bidi text in <select> menus in WebKit2 on Windows match WebKit1

Fixes <​http://webkit.org/b/56614> 3 <select> bidi tests failing on Windows 7 Release
(WebKit2 Tests)

Reviewed by Sam Weinig.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):
(WebKit::WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection):
On Windows, return the same values we return in WebKit1.

5:45 PM Changeset in webkit [81418] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-03-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Implement PluginProcessProxy::setModalWindowIsShowing
​https://bugs.webkit.org/show_bug.cgi?id=56615

  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::PluginProcessProxy): Initialize m_modalWindowIsShowing.

(WebKit::PluginProcessProxy::didClose):
If m_modalWindowIsShowing is true, we must call endModal.

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm: (-[WKPlaceholderModalWindow _wantsUserAttention]): Add a WKPlaceholderModalWindow.

(WebKit::PluginProcessProxy::setModalWindowIsShowing):
Call beginModal or endModal depending on whether we're showing a modal window or not.

(WebKit::PluginProcessProxy::beginModal):
Create a fake window and start a nested run loop. Listen for NSApplicationWillBecomeActiveNotification notifications.

(WebKit::PluginProcessProxy::endModal):
Tear down the window and the run loop.

(WebKit::PluginProcessProxy::applicationDidBecomeActive):
Make sure that the plug-in process is frontmost.

5:18 PM Changeset in webkit [81417] by levin@chromium.org
  • 10 edits in trunk/LayoutTests

Misc clean-up (see files for details).

  • platform/chromium-mac-leopard/media/controls-after-reload-expected.checksum: Due to r81300.
  • platform/chromium-mac-leopard/media/controls-after-reload-expected.png: Ditto.
  • platform/chromium-mac-leopard/media/controls-without-preload-expected.checksum: Due to r81280.
  • platform/chromium-mac-leopard/media/controls-without-preload-expected.png: Ditto.
  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.checksum: Due to r81285.
  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png: Ditto.
  • platform/chromium-win-xp/media/controls-without-preload-expected.checksum: Due to r81280.
  • platform/chromium-win-xp/media/controls-without-preload-expected.png: Ditto.
  • platform/chromium/test_expectations.txt: Replace BUG_LEVIN with a bug number.
5:11 PM Changeset in webkit [81416] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-17 Jeff Miller <​jeffm@apple.com>

Reviewed by Adam Roben.

Web page shouldn't swallow alt-key combinations on Windows
​https://bugs.webkit.org/show_bug.cgi?id=56612


Make Alt+Left Arrow and Alt+Right Arrow go back and forward, but make
sure any alt-key combinations bubble up to the client.

  • WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::WebPage::performDefaultBehaviorForKeyEvent): Make Alt+Left Arrow and Alt+Right Arrow go back and forward, ignore any other alt-key combinations.
5:11 PM Changeset in webkit [81415] by mitz@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Added platform-specific expected results for fast/text/emphasis-combined-text.html

  • platform/mac-leopard/fast/text/emphasis-combined-text-expected.txt: Added.
  • platform/win/fast/text/emphasis-combined-text-expected.txt: Added.
5:10 PM Changeset in webkit [81414] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-03-17 Victoria Kirst <​vrk@google.com>

Reviewed by Kenneth Russell.

[chromium] Video colors have wrong brightness/contrast
​https://bugs.webkit.org/show_bug.cgi?id=56598

This patch changes the YUV to RGB color conversion matrix
to have brighter whites and darker blacks in accordance to
the BT.601 standard.

  • platform/graphics/chromium/ShaderChromium.cpp: (WebCore::FragmentShaderYUVVideo::FragmentShaderYUVVideo): (WebCore::FragmentShaderYUVVideo::init): (WebCore::FragmentShaderYUVVideo::getShaderString):
  • platform/graphics/chromium/ShaderChromium.h: (WebCore::FragmentShaderYUVVideo::yuvAdjLocation):
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::drawYUV):
  • platform/graphics/chromium/VideoLayerChromium.h:
5:08 PM Changeset in webkit [81413] by Adam Roben
  • 3 edits
    1 delete in trunk

Skip a compositing-sensitive test when accelerated compositing is disabled

Reviewed by Sam Weinig.

Tools:

  • Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when

accelerated compositing is disabled.

LayoutTests:

Remove some non-compositing results for a test that is now skipped in non-compositing builds

  • platform/win-xp/media/media-document-audio-repaint-expected.txt: Removed.
5:08 PM Changeset in webkit [81412] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-03-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Send SetModalWindowIsShowing and SetFullscreenWindowIsShowing messages to the UI process
​https://bugs.webkit.org/show_bug.cgi?id=56610

  • PluginProcess/mac/PluginProcessMac.mm: (WebKit::FullscreenWindowTracker::FullscreenWindowTracker): Add fullscreen window tracker class.

(WebKit::rectCoversAnyScreen):
Return whether the given rect covers any screen.

(WebKit::windowCoversAnyScreen):
Return whether the given window covers any screen.

(WebKit::FullscreenWindowTracker::windowShown):
If we're showing a fullscreen window, call PluginProcess::setFullscreenWindowIsShowing.

(WebKit::FullscreenWindowTracker::windowHidden):
If we're hiding the last fullscreen window, call PluginProcess::setFullscreenWindowIsShowing.

(WebKit::cocoaWindowShown):
(WebKit::cocoaWindowHidden):
(WebKit::carbonWindowShown):
(WebKit::carbonWindowHidden):
Call the window tracking functions.

(WebKit::setModal):
Call PluginProcess::setModalWindowIsShowing.

(WebKit::PluginProcess::setModalWindowIsShowing):
(WebKit::PluginProcess::setFullscreenWindowIsShowing):
Send CoreIPC messages.

  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/Plugins/PluginProcessProxy.messages.in: Add new messages.
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm: (WebKit::PluginProcessProxy::setModalWindowIsShowing): (WebKit::PluginProcessProxy::setFullscreenWindowIsShowing): Add stubs.
4:57 PM Changeset in webkit [81411] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-03-17 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Crash in JSC::MarkStack::drain Under Stress
​https://bugs.webkit.org/show_bug.cgi?id=56470

We perform a number of gc allocations while when
we are setting up new globals in a piece of global
code. We do this by adding new properties to the
symbol table, and then expanding the storage to fit
at the end.

If a GC happens during this time we will report an
incorrect size for the global object's symbol table
storage.

This patch corrects this by growing the storage size
before we starting adding entries to the symbol table.

  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::resizeRegisters):
4:46 PM Changeset in webkit [81410] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-17 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

1 Structure leaked beneath JSGlobalData::storeVPtrs()
​https://bugs.webkit.org/show_bug.cgi?id=56595

  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::storeVPtrs): Take local ownership of the Structure we're using, since the Executable is not designed to own the Structure.
4:43 PM Changeset in webkit [81409] by zmo@google.com
  • 2 edits in branches/chromium/696/Source/WebCore

Merge 81407 - 2011-03-17 Zhenyao Mo <​zmo@google.com>

Reviewed by Adam Barth.

RequestAnimationFrame callbacks prevent Document from being released on detach
​https://bugs.webkit.org/show_bug.cgi?id=56607

  • dom/Document.cpp: (WebCore::Document::removedLastRef): Remove RequestAnimationFrame callbacks. (WebCore::Document::detach): Ditto.

TBR=​zmo@google.com

4:27 PM Changeset in webkit [81408] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Rubber Stamped by Sam Weinig.

Add missing register-register branchTest8 to MacroAssemblerX86Common/X86Assembler.

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::branchTest8):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::testb_rr):

4:26 PM Changeset in webkit [81407] by zmo@google.com
  • 2 edits in trunk/Source/WebCore

2011-03-17 Zhenyao Mo <​zmo@google.com>

Reviewed by Adam Barth.

RequestAnimationFrame callbacks prevent Document from being released on detach
​https://bugs.webkit.org/show_bug.cgi?id=56607

  • dom/Document.cpp: (WebCore::Document::removedLastRef): Remove RequestAnimationFrame callbacks. (WebCore::Document::detach): Ditto.
4:22 PM Changeset in webkit [81406] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=56596 Overlay scrollbars sometimes
fail to appear
-and corresponding-
<rdar://problem/8953779>

Reviewed by Darin Adler.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):

4:16 PM Changeset in webkit [81405] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

4:11 PM Changeset in webkit [81404] by mitz@apple.com
  • 3 edits
    4 adds in trunk

<rdar://problem/9052166> Emphasis marks appear over combined text rather than beside it
​https://bugs.webkit.org/show_bug.cgi?id=56480

Reviewed by Beth Dakin.

Source/WebCore:

Test: fast/text/emphasis-combined-text.html

  • rendering/InlineTextBox.cpp:

(WebCore::rotation): Added this helper.
(WebCore::InlineTextBox::paint): Paint a single emphasis mark beside the combined text,
centered vertically.

LayoutTests:

  • fast/text/emphasis-combined-text.html: Added.
  • platform/mac/fast/text/emphasis-combined-text-expected.checksum: Added.
  • platform/mac/fast/text/emphasis-combined-text-expected.png: Added.
  • platform/mac/fast/text/emphasis-combined-text-expected.txt: Added.
4:11 PM Changeset in webkit [81403] by barraclough@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

Bug 56603 - DFG JIT related cleanup
Move node generation out to separate function, move binarySearch algorithm out
to StdLibExtras, fix Graph::dump() to print comma between non-node children,
even if there are no node children.

Reviewed by Sam Weinig.

  • bytecode/CodeBlock.h:

(JSC::getCallReturnOffset):
(JSC::CodeBlock::getStubInfo):
(JSC::CodeBlock::getCallLinkInfo):
(JSC::CodeBlock::getMethodCallLinkInfo):
(JSC::CodeBlock::bytecodeOffset):

  • Move binaryChop to binarySearch in StdLibExtras
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::parse):
(JSC::DFG::parse):

  • Make m_noArithmetic a member, initialize m_currentIndex in the constructor.
  • dfg/DFGByteCodeParser.h:
    • Change parse() to not take a start index (always 0).
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • Fix Graph::dump() to print comma between non-node children, even if there are no node children.
  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::JITCodeGenerator):

  • Initialize m_compileIndex in constructor.
  • dfg/DFGNonSpeculativeJIT.cpp:

(JSC::DFG::NonSpeculativeJIT::compile):

  • dfg/DFGNonSpeculativeJIT.h:
    • Spilt out compilation of individual node.
  • dfg/DFGOperations.cpp:

(JSC::DFG::operationConvertThis):

  • dfg/DFGOperations.h:
    • Cleanup parameter name.
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:
    • Spilt out compilation of individual node.
  • runtime/Executable.cpp:

(JSC::tryDFGCompile):

  • Change parse() to not take a start index (always 0).
  • wtf/StdLibExtras.h:

(WTF::binarySearch):

  • Move binaryChop to binarySearch in StdLibExtras
4:10 PM Changeset in webkit [81402] by Lucas Forschler
  • 1 copy in tags/Safari-534.25

New tag.

4:07 PM Changeset in webkit [81401] by ggaren@apple.com
  • 2 edits in trunk/Source/WebKit/mac

2011-03-17 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Fixed a leak seen on the buildbot.

  • WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::openInspectorFrontend): Smart pointers are smart.
4:07 PM Changeset in webkit [81400] by weinig@apple.com
  • 4 edits in trunk/Source/WebKit2

Allow passing a certificate chain as a user message
<rdar://problem/8951709>
​https://bugs.webkit.org/show_bug.cgi?id=56605

Reviewed by Brady Eidson.

  • Shared/API/c/mac/WKCertificateInfoMac.h:
  • Shared/API/c/mac/WKCertificateInfoMac.mm:

(WKCertificateInfoCreateWithCertficateChain):
Added. Creates a WKCertificate from a certificate chain.

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
Add encoding/decoding of WebCertificateInfo.

4:06 PM Changeset in webkit [81399] by jianli@chromium.org
  • 9 edits
    3 adds in trunk

Blob URL should not be allow to get created from the code running from data URI
​https://bugs.webkit.org/show_bug.cgi?id=56600

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/fileapi/create-blob-url-from-data-url.html

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::createPublicBlobURL):

  • fileapi/BlobURL.cpp:

(WebCore::BlobURL::createBlobURL):

  • fileapi/EntryBase.cpp:

(WebCore::EntryBase::toURI):

  • fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::start):

LayoutTests:

  • http/tests/fileapi/create-blob-url-from-data-url-expected.txt: Added.
  • http/tests/fileapi/create-blob-url-from-data-url.html: Added.
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
3:29 PM Changeset in webkit [81398] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix clang build.

Reviewed by Geoffrey Garen.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::storeVPtrs):

3:21 PM Changeset in webkit [81397] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

2011-03-17 Ryosuke Niwa <​rniwa@webkit.org>

Skip an editing test that hits assertion on non-Mac platforms.
The bug is tracked by ​https://bugs.webkit.org/show_bug.cgi?id=56599.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
3:18 PM Changeset in webkit [81396] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r80064.
​http://trac.webkit.org/changeset/80064
​https://bugs.webkit.org/show_bug.cgi?id=56588

the original test was correct (Requested by rniwa on #webkit).

  • platform/mac/editing/input/selection-change-closes-typing.html:
3:17 PM Changeset in webkit [81395] by enne@google.com
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-17 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Turn off accelerated compositing for RTL style pages.
​https://bugs.webkit.org/show_bug.cgi?id=56585

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::layout): (WebKit::WebViewImpl::pageHasRTLStyle): (WebKit::WebViewImpl::setRootGraphicsLayer):
  • src/WebViewImpl.h:
3:15 PM Changeset in webkit [81394] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-17 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.

1 Structure leaked beneath JSGlobalData::storeVPtrs()
​https://bugs.webkit.org/show_bug.cgi?id=56595

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::storeVPtrs): Now that we have an executable, we need to explicitly run its destructor.
3:14 PM Changeset in webkit [81393] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/qt

2011-03-17 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Videos look ugly when using QGraphicsWebView.
​https://bugs.webkit.org/show_bug.cgi?id=56580

We need to set QPainter::SmoothPixmapTransform on the painter for a proper rendering of the video.
QWebView does it but not QGraphicsWebView because the API does not exist. This patch is fixing it
by introducing the same API as QWebView to control the renderHints of the item. Unlike QWebView
QGraphicsWebView inherits the painter from QGraphicsScene and those flags are not set. This patch
ensure that before rendering the item we add QPainter::SmoothPixmapTransform and QPainter::TextAntialiasing
in addition of what could be set on the painter. In order to not break the rendering of all the items in the
scene we set back the painter to its original state when QGraphicsWebView is rendered.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): (QGraphicsWebView::paint): (QGraphicsWebView::renderHints): (QGraphicsWebView::setRenderHints): (QGraphicsWebView::setRenderHint):
  • Api/qgraphicswebview.h:
  • tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::renderHints):
3:04 PM Changeset in webkit [81392] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-03-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add PluginProcessShim hooks for when windows are shown and hidden
​https://bugs.webkit.org/show_bug.cgi?id=56597

  • Configurations/PluginProcessShim.xcconfig: Add HEADER_SEARCH_PATHS so we can find WebKitSystemInterface.h.
  • PluginProcess/mac/PluginProcessMac.mm: (WebKit::cocoaWindowShown): (WebKit::cocoaWindowHidden): (WebKit::carbonWindowShown): (WebKit::carbonWindowHidden): (WebKit::setModal): (WebKit::PluginProcess::initializeShim): Add empty stubs.
  • PluginProcess/mac/PluginProcessShim.h:
  • PluginProcess/mac/PluginProcessShim.mm: (WebKit::beginModal): (WebKit::endModal): Keep a modal count and call setModal accordingly.

(WebKit::shim_NSApplication_RunModalForWindow):
(WebKit::shimModalDialog):
(WebKit::shimAlert):
Call beginModal/endModal.

(WebKit::shimShowWindow):
(WebKit::shimHideWindow):
Call the shim functions.


(WebKit::WebKitPluginProcessShimInitialize):
Listen for notifications and call the necessary shim functions.

  • WebKit2.xcodeproj/project.pbxproj: Link the plug-in process shim with AppKit and QuartzCore and WKSI.
3:02 PM Changeset in webkit [81391] by Adam Roben
  • 2 edits
    2 moves in trunk/LayoutTests

Disable http/tests/inspector/network tests

They are known to be flaky. <​http://webkit.org/b/56578> tracks the issue.

  • http/tests/inspector/network/network-size.html-disabled: Renamed from LayoutTests/http/tests/inspector/network/network-size.html.
  • http/tests/inspector/network/network-timing.html-disabled: Renamed from LayoutTests/http/tests/inspector/network/network-timing.html.
  • platform/mac/Skipped: Removed a now-disabled test.
3:00 PM Changeset in webkit [81390] by Adam Roben
  • 4 edits in trunk/Tools

Start using PlatformSpecificScheduler for the Mac builders

The current set of file/directory patterns should work for Mac builders. We may discover
that there are more files and directories we can exclude from the Mac builds, but they can
be added later.

Fixes <​http://webkit.org/b/56593> Mac builders do lots of unnecessary builds

Reviewed by Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two

PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.

  • Scripts/webkitpy/common/config/build.py:

(_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
cleaned up patterns a little bit.

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest): Fixed some expected results.
(ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
platforms.

2:51 PM Changeset in webkit [81389] by jeffm@apple.com
  • 25 edits in trunk

Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:

*.mode*
*.pbxuser
*.perspective*
project.xcworkspace
xcuserdata

Examples:

  • NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj: Modified property svn:ignore.
  • NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Modified property svn:ignore.
  • NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj: Modified property svn:ignore.
  • NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj: Modified property svn:ignore.

Source/JavaScriptCore:

Source/JavaScriptGlue:

  • JavaScriptGlue.xcodeproj: Modified property svn:ignore.

Source/ThirdParty/ANGLE:

  • ANGLE.xcodeproj: Modified property svn:ignore.
  • src/build_angle.xcodeproj: Modified property svn:ignore.

Source/WebCore:

  • WebCore.xcodeproj: Modified property svn:ignore.
  • manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Modified property svn:ignore.

Source/WebKit:

  • WebKit.xcodeproj: Modified property svn:ignore.

Source/WebKit2:

  • WebKit2.xcodeproj: Modified property svn:ignore.

Tools:

  • DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
  • MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
  • WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2:45 PM Changeset in webkit [81388] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Mac build.

  • WebCore.exp.in:

Add missing symbol.

2:25 PM Changeset in webkit [81387] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

WKErrors need the PeerCertificateChain for certificate errors
<rdar://problem/8951784>
​https://bugs.webkit.org/show_bug.cgi?id=56592

Reviewed by Anders Carlsson.

  • Shared/WebCoreArgumentCoders.h:

Special case encoding/decoding of ResourceErrors for the mac.

  • Shared/mac/PlatformCertificateInfo.h:
  • Shared/mac/PlatformCertificateInfo.mm:

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
Add constructor that take the PeerCertificateChain as CFArrayRef.

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::encodeResourceError):
(CoreIPC::decodeResourceError):
Add encode/decode for ResourceError using the underlying NSError
and encoding/decoding as much of the userInfo as we know how to.
Right now this includes all string values and the PeerCertificateChain.

2:21 PM Changeset in webkit [81386] by Adam Roben
  • 2 edits in trunk/Tools

Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows

Fixes <​http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
mac-wk2

Reviewed by Anders Carlsson.

  • Scripts/old-run-webkit-tests:

(expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
we're running in WebKit2 mode.

2:03 PM Changeset in webkit [81385] by andersca@apple.com
  • 4 edits in trunk/WebKitLibraries

Add WKWindowWillOrderOffScreenNotification.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
1:49 PM Changeset in webkit [81384] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-03-17 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Adele Peterson and Enrica Casucci.

Assert that editing does not ignore position's anchorNode if position is an offset in anchor
​https://bugs.webkit.org/show_bug.cgi?id=56027

Debug build fix.

  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance): "this" can be an input element so can't always instantiate a position inside the node. Call firstPositionInOrBeforeNode instead.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::positionAvoidingPrecedingNodes): Exit early when a node's content is ignored by editing instead of just when the node is br.
  • editing/htmlediting.cpp: (WebCore::lastEditablePositionBeforePositionInRoot): The shadow ancestor node is usually an input element so don't instantiate a position inside it. Call firstPositionInOrBeforeNode instead.
1:44 PM Changeset in webkit [81383] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update test_expectations.txt

Mark some tests as SLOW in DEBUG since they are on a borderline of shorter timeout.

  • platform/chromium/test_expectations.txt:
1:43 PM Changeset in webkit [81382] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a flaky test on Mac

<​http://webkit.org/b/56578> tracks the failure.

  • platform/mac/Skipped: Added http/tests/inspector/network/network-size.html.
1:30 PM Changeset in webkit [81381] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip some flaky tests on the SnowLeopard WebKit2 bot

Tracked by <​http://webkit.org/b/56530> and <​http://webkit.org/b/56584>.

  • platform/mac-wk2/Skipped: Added http/tests/inspector/resource-har-conversion.html and

inspector/debugger/debug-inlined-scripts.html.

1:22 PM Changeset in webkit [81380] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Reverting r81197, breaks JIT + INTERPRETER build.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::hasGlobalResolveInstructionAtBytecodeOffset):
(JSC::CodeBlock::hasGlobalResolveInfoAtBytecodeOffset):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addPropertyAccessInstruction):
(JSC::CodeBlock::addGlobalResolveInstruction):
(JSC::CodeBlock::addStructureStubInfo):

  • bytecode/Opcode.h:
  • bytecode/StructureStubInfo.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::emitCatch):

1:07 PM Changeset in webkit [81379] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-17 Ben Taylor <​bentaylor.solx86@gmail.com>

Reviewed by Alexey Proskuryakov.

Add a COMPILER(SUNCC) define for Sun Studio 12.
​https://bugs.webkit.org/show_bug.cgi?56444
derived from patch 1 of 16 originally from ​https://bugs.webkit.org/show_bug.cgi?id=24932

  • wtf/Platform.h:
12:50 PM Changeset in webkit [81378] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-17 James Simonsen <​simonjam@chromium.org>

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
12:49 PM Changeset in webkit [81377] by jcivelli@chromium.org
  • 10 edits
    8 adds in trunk/Source

2011-03-17 Jay Civelli <​jcivelli@chromium.org>

Reviewed by David Levin.

Adding a contains method to Vector.
​https://bugs.webkit.org/show_bug.cgi?id=55859

  • wtf/Vector.h: (WTF::::operator): (WTF::::contains):

2011-03-17 Jay Civelli <​jcivelli@chromium.org>

Reviewed by David Levin.

Moving the method that is used to retrieve all the resources in
a page from the Chromium code (dom_operations.cc) to WebKit.
​https://bugs.webkit.org/show_bug.cgi?id=55859

  • WebKit.gyp:
  • public/WebPageSerializer.h:
  • public/WebURL.h: (WebKit::operator==): (WebKit::operator!=):
  • public/WebVector.h: (WebKit::WebVector::contains):
  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::WebDataSourceImpl):
  • src/WebPageSerializer.cpp: (WebCore::getSubResourceURLFromElement): (WebCore::retrieveResourcesForElement): (WebCore::retrieveResourcesForFrame): (WebKit::WebPageSerializer::retrieveAllResources):
  • tests/WebFrameTest.cpp:
  • tests/WebPageSerializerTest.cpp: Added.
  • tests/data/pageserialization: Added.
  • tests/data/pageserialization/awesome.png: Added.
  • tests/data/pageserialization/embed_iframe.html: Added.
  • tests/data/pageserialization/object_iframe.html: Added.
  • tests/data/pageserialization/simple_iframe.html: Added.
  • tests/data/pageserialization/simple_page.html: Added.
  • tests/data/pageserialization/top_frame.html: Added.
12:14 PM Changeset in webkit [81376] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-17 James Simonsen <​simonjam@chromium.org>

Unreviewed, update chromium test expectations.

  • platform/chromium/test_expectations.txt:
12:05 PM Changeset in webkit [81375] by podivilov@chromium.org
  • 5 edits in trunk

2011-03-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81369.
​http://trac.webkit.org/changeset/81369
​https://bugs.webkit.org/show_bug.cgi?id=56579

breaks debugger test (Requested by podivilov on #webkit).

  • inspector/debugger/debug-inlined-scripts.html:

2011-03-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81369.
​http://trac.webkit.org/changeset/81369
​https://bugs.webkit.org/show_bug.cgi?id=56579

breaks debugger test (Requested by podivilov on #webkit).

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource): (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource): (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged): (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved): (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved): (WebInspector.DebuggerPresentationModel.prototype._encodeSourceLocation): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints): (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame): (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation): (WebInspector.DebuggerPresentationModel.prototype.reset):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._parsedScriptSource): (WebInspector.ScriptsPanel.prototype._failedToParseScriptSource): (WebInspector.ScriptsPanel.prototype._scriptSourceChanged): (WebInspector.ScriptsPanel.prototype._addScript): (WebInspector.ScriptsPanel.prototype._resourceForURL): (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelectAndShowSourceFrameIfNeeded): (WebInspector.ScriptsPanel.prototype._showSourceFrame): (WebInspector.ScriptsPanel.prototype._recreateSourceFrame): (WebInspector.ScriptsPanel.prototype._sourceFileIdForScript): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
12:02 PM Changeset in webkit [81374] by rniwa@webkit.org
  • 7 edits
    2 adds in trunk

2011-03-17 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Justin Garcia.

Assert that editing does not ignore position's anchorNode if position is an offset in anchor
​https://bugs.webkit.org/show_bug.cgi?id=56027

Added a test to ensure WebKit lets users edit contents inside a button element properly.

  • editing/execCommand/button-expected.txt: Added.
  • editing/execCommand/button.html: Added.

2011-03-17 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Justin Garcia.

Assert that editing does not ignore position's anchorNode if position is an offset in anchor
​https://bugs.webkit.org/show_bug.cgi?id=56027

Added the assertion in Position::Position and Position::moveToPosition. This assertion catches
places where we instantiate positions inside a node on which editingIgnoresContent returns true.

Test: editing/execCommand/button.html

  • dom/Position.cpp: (WebCore::Position::Position): Added an assertion. (WebCore::Position::moveToPosition): Ditto.
  • dom/PositionIterator.cpp: (WebCore::PositionIterator::operator Position): Avoid creating a position immediately below a node whose content is ignored by editing. While this does not avoid creation of positions inside ignored contents completely, it works in most cases. Filed the bug 56027 to resolve the underlying problem. Without this change, the assertion hits in existing layout tests. cannot be tested directly.
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Call firstPositionInOrBeforeNode instead of firstPositionInNode because startNode may as well be a br element. Without this change, the assertion hits in existing layout tests.
  • editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing): button is editable so content is not ignored. Added a test for this.
  • editing/visible_units.cpp: (WebCore::previousBoundary): Added a FIXME. (WebCore::startPositionForLine): Because br can also have an inline text box, checking that startBox is an inline text box isn't an adequate to instantiate a position inside startNode. Call startNode->isTextNode() instead. Without this change, the assertion hits in existing layout tests.
11:45 AM Changeset in webkit [81373] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip three tests that fail on one Windows WebKit2 slave but not the other

The failures are tracked by <​http://webkit.org/b/56550>.

  • platform/win-wk2/Skipped: Added fast/events/tabindex-focus-blur-all.html,

fast/forms/button-align.html, and media/audio-mpeg4-supported.html.

11:41 AM Changeset in webkit [81372] by sullivan@apple.com
  • 2 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=56574
Dealloc'ing a WKView can leave a stale reference to it in NSWindow

Reviewed by Adam Roben.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewWillMoveToWindow:]):
Clear the outgoing window's growBoxOwner if it is this view.

11:39 AM Changeset in webkit [81371] by andersca@apple.com
  • 2 edits
    1 move in trunk/Source/WebKit2

Rename PluginProcessShim.cpp to PluginProcessShim.mm.

Rubber-stamped by John Sullivan.

  • PluginProcess/mac/PluginProcessShim.cpp: Removed.
  • PluginProcess/mac/PluginProcessShim.mm: Copied from PluginProcess/mac/PluginProcessShim.cpp.
  • WebKit2.xcodeproj/project.pbxproj:
11:28 AM Changeset in webkit [81370] by andersca@apple.com
  • 10 edits in trunk/Source/WebKit2

2011-03-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Invalidate all NPObjects for a plug-in when that plug-in is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=56511
<rdar://problem/8993491>

Before this change, we would invalidate NPObjectProxy objects and delete NPObjectMessageReceiver
objects when the last plug-in of a certain type was destroyed. Doing so caused us to hold on to memory
which we don't need, and could also lead to crashes if the NPObjectMessageReceiver would get a message and
tried to invoke it on a already deallocated NPObject.

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::initialize): If we fail to initialize, call removePluginControllerProxy instead of having WebProcessConnection do so.

(WebKit::PluginControllerProxy::destroy):
Pass the plug-in to removePluginControllerProxy.

  • PluginProcess/WebProcessConnection.cpp: (WebKit::WebProcessConnection::removePluginControllerProxy): Call NPRemoteObjectMap::pluginDestroyed when the plug-in has been destroyed.

(WebKit::WebProcessConnection::createPlugin):
Don't call removePluginControllerProxy if the plug-in fails to initialize. PluginControllerProxy::initialize now
takes care of doing this.

  • Shared/Plugins/NPObjectMessageReceiver.cpp: (WebKit::NPObjectMessageReceiver::NPObjectMessageReceiver): (WebKit::NPObjectMessageReceiver::~NPObjectMessageReceiver):
  • Shared/Plugins/NPObjectMessageReceiver.h: Remove m_shouldReleaseObjectWhenInvalidating, we now know that no NPObjects will have been deallocated by the time the NPObjectMessageReceiver is destroyed.

(WebKit::NPObjectMessageReceiver::plugin):
Add getter.


  • Shared/Plugins/NPObjectProxy.h: (WebKit::NPObjectProxy::plugin): Add getter.


  • Shared/Plugins/NPRemoteObjectMap.cpp: (WebKit::NPRemoteObjectMap::NPRemoteObjectMap): Remove m_isInvalidating.

(WebKit::NPRemoteObjectMap::npObjectProxyDestroyed):
Simplify code.

(WebKit::NPRemoteObjectMap::pluginDestroyed):
Rename invalidate to pluginDestroyed. Only invalidate/delete objects that belong to the given plug-in.

  • Shared/Plugins/NPRemoteObjectMap.h: Remove m_isInvalidating.


  • WebProcess/Plugins/PluginProcessConnection.cpp: (WebKit::PluginProcessConnection::removePluginProxy): Call NPRemoteObjectMap::pluginDestroyed when the plug-in has been destroyed.
11:14 AM Changeset in webkit [81369] by podivilov@chromium.org
  • 5 edits in trunk

2011-03-17 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract content loading logic from scripts panel.
​https://bugs.webkit.org/show_bug.cgi?id=55237

  • inspector/debugger/debug-inlined-scripts.html:

2011-03-17 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract content loading logic from scripts panel.
​https://bugs.webkit.org/show_bug.cgi?id=55237

Encapsulate source files creation logic in debugger presentation model
to support source mappings in a pluggable way.

  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.sourceFile): (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent.else.didRequestSource): (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent): (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource): (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource): (WebInspector.DebuggerPresentationModel.prototype._addScript.else.resourceFinished): (WebInspector.DebuggerPresentationModel.prototype._addScript): (WebInspector.DebuggerPresentationModel.prototype._ensureSourceFileAdded): (WebInspector.DebuggerPresentationModel.prototype._resourceForURL): (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged): (WebInspector.DebuggerPresentationModel.prototype._sourceFileAdded): (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved): (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints): (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame): (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation): (WebInspector.DebuggerPresentationModel.prototype.reset):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._sourceFileAdded): (WebInspector.ScriptsPanel.prototype._showSourceFrame): (WebInspector.ScriptsPanel.prototype._sourceFileChanged): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
11:10 AM Changeset in webkit [81368] by pfeldman@chromium.org
  • 21 edits in trunk/Source/WebCore

2011-03-17 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add types markup to the IDL, remove Value types from the protocol.
​https://bugs.webkit.org/show_bug.cgi?id=56562

  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend):
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::evaluate): (WebCore::InjectedScript::evaluateOn): (WebCore::InjectedScript::evaluateOnCallFrame): (WebCore::InjectedScript::getProperties): (WebCore::InjectedScript::setPropertyValue): (WebCore::InjectedScript::callFrames): (WebCore::InjectedScript::makeCall): (WebCore::InjectedScript::makeObjectCall):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js: (.):
  • inspector/Inspector.idl:
  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode): (WebCore::InspectorCSSAgent::getInlineStyleForNode): (WebCore::InspectorCSSAgent::getComputedStyleForNode): (WebCore::InspectorCSSAgent::getStyleSheet): (WebCore::InspectorCSSAgent::setPropertyText): (WebCore::InspectorCSSAgent::toggleProperty): (WebCore::InspectorCSSAgent::setRuleSelector): (WebCore::InspectorCSSAgent::addRule):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::resolveNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::editScriptSource): (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::currentCallFrames):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::identifierForInitialRequest):
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::evaluate): (WebCore::InspectorRuntimeAgent::evaluateOn): (WebCore::InspectorRuntimeAgent::getProperties): (WebCore::InspectorRuntimeAgent::setPropertyValue):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/ScriptCallStack.cpp: (WebCore::ScriptCallStack::buildInspectorArray):
  • inspector/ScriptCallStack.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkDispatcher.prototype._createResource):
11:07 AM Changeset in webkit [81367] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

changelog

11:07 AM Changeset in webkit [81366] by simonjam@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

first changes

10:53 AM Changeset in webkit [81365] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-17 Tony Chang <​tony@chromium.org>

Reviewed by Pavel Feldman.

[chromium] don't concatenate devtools files when debug_devtools=1
​https://bugs.webkit.org/show_bug.cgi?id=56572

  • WebKit.gyp:
10:41 AM Changeset in webkit [81364] by jorlow@chromium.org
  • 4 edits
    2 copies in branches/chromium/696/Source/WebCore

Fix crash caused by Invalid call to destroyActiveDOMObject during stopActiveDOMObjects
​https://bugs.webkit.org/show_bug.cgi?id=56350

Patch by David Grogan <​dgrogan@chromium.org> on 2011-03-15
Reviewed by Jeremy Orlow.

When a frame is unloaded, ScriptExecutionContext::stopActiveDOMObjects
calls stop() on each ActiveDOMObject.

Calling IDBDatabase::stop() can cause IDBDatabase to be destroyed:

  • IDBDatabase::stop() causes the chrome message dispatcher to remove

its reference to IDBDatabase, which it has as type
IDBDatabaseCallbacks.

  • If that reference is the last one, the IDBDatabase is destroyed.
  • Destroying an ActiveDOMObject while they are being iterated over causes

a defensive crash.

This change creates a separate IDBDatabaseCallbacks object that is not
an ActiveDOMObject, so it can be destroyed by
ScriptExecutionContext::stopActiveDOMObjects.

Because the chrome message dispatcher is only used in multi-process
chromium, that's the only platform affected. Chromium browser tests
forthcoming.

  • WebCore.gypi:
  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::~IDBDatabase):
(WebCore::IDBDatabase::setVersion):
(WebCore::IDBDatabase::close):
(WebCore::IDBDatabase::open):

  • storage/IDBDatabase.h:
  • storage/IDBDatabaseCallbacks.h:

(WebCore::IDBDatabaseCallbacks::unRegisterDatabase):

  • storage/IDBDatabaseCallbacksImpl.cpp: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h.

(WebCore::IDBDatabaseCallbacksImpl::create):
(WebCore::IDBDatabaseCallbacksImpl::IDBDatabaseCallbacksImpl):
(WebCore::IDBDatabaseCallbacksImpl::onVersionChange):
(WebCore::IDBDatabaseCallbacksImpl::unRegisterDatabase):

  • storage/IDBDatabaseCallbacksImpl.h: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h.

(WebCore::IDBDatabaseCallbacksImpl::~IDBDatabaseCallbacksImpl):
Merge 81181 - 2011-03-15 David Grogan <​dgrogan@chromium.org>

Reviewed by Jeremy Orlow.

Fix crash caused by Invalid call to destroyActiveDOMObject during stopActiveDOMObjects
​https://bugs.webkit.org/show_bug.cgi?id=56350

When a frame is unloaded, ScriptExecutionContext::stopActiveDOMObjects
calls stop() on each ActiveDOMObject.

Calling IDBDatabase::stop() can cause IDBDatabase to be destroyed:

  • IDBDatabase::stop() causes the chrome message dispatcher to remove its reference to IDBDatabase, which it has as type IDBDatabaseCallbacks.
  • If that reference is the last one, the IDBDatabase is destroyed.
  • Destroying an ActiveDOMObject while they are being iterated over causes a defensive crash.

This change creates a separate IDBDatabaseCallbacks object that is not
an ActiveDOMObject, so it can be destroyed by
ScriptExecutionContext::stopActiveDOMObjects.

Because the chrome message dispatcher is only used in multi-process
chromium, that's the only platform affected. Chromium browser tests
forthcoming.

  • WebCore.gypi:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::~IDBDatabase): (WebCore::IDBDatabase::setVersion): (WebCore::IDBDatabase::close): (WebCore::IDBDatabase::open):
  • storage/IDBDatabase.h:
  • storage/IDBDatabaseCallbacks.h: (WebCore::IDBDatabaseCallbacks::unRegisterDatabase):
  • storage/IDBDatabaseCallbacksImpl.cpp: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h. (WebCore::IDBDatabaseCallbacksImpl::create): (WebCore::IDBDatabaseCallbacksImpl::IDBDatabaseCallbacksImpl): (WebCore::IDBDatabaseCallbacksImpl::onVersionChange): (WebCore::IDBDatabaseCallbacksImpl::unRegisterDatabase):
  • storage/IDBDatabaseCallbacksImpl.h: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h. (WebCore::IDBDatabaseCallbacksImpl::~IDBDatabaseCallbacksImpl):

TBR=​commit-queue@webkit.org

10:35 AM Changeset in webkit [81363] by Adam Roben
  • 2 edits
    1 move in trunk/LayoutTests

Disable http/tests/inspector/resource-parameters.html

It is flaky. The flakiness is tracked by <​http://webkit.org/b/55867>.

  • http/tests/inspector/resource-parameters.html-disabled: Renamed from LayoutTests/http/tests/inspector/resource-parameters.html.
  • platform/qt/Skipped: Removed the test from this Skipped file since it has been disabled.
10:03 AM Changeset in webkit [81362] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-03-17 Oleg Romashin <​oleg.romashin@nokia.com>

Reviewed by Anders Carlsson.

Teach WebKit2 messages.py generator to ifdef headers include
which are related to ifdef-ed methods/types
​https://bugs.webkit.org/show_bug.cgi?id=55658

  • Scripts/webkit2/messages.py:
  • Scripts/webkit2/messages_unittest.py:
9:47 AM Changeset in webkit [81361] by commit-queue@webkit.org
  • 12 edits
    4 deletes in trunk

2011-03-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81350.
​http://trac.webkit.org/changeset/81350
​https://bugs.webkit.org/show_bug.cgi?id=56560

"Breaks twenty Chromium Webkit Win builder webkit_gpu_tests"
(Requested by apavlov on #webkit).

  • fast/canvas/script-tests/canvas-transforms-fillRect-shadow.js: (shouldBeAround):
  • platform/chromium/test_expectations.txt:

2011-03-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81350.
​http://trac.webkit.org/changeset/81350
​https://bugs.webkit.org/show_bug.cgi?id=56560

"Breaks twenty Chromium Webkit Win builder webkit_gpu_tests"
(Requested by apavlov on #webkit).

  • WebCore.gypi:
  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::State::State): (WebCore::GLES2Canvas::clearRect): (WebCore::GLES2Canvas::fillPath): (WebCore::GLES2Canvas::fillRect): (WebCore::GLES2Canvas::clipPath): (WebCore::GLES2Canvas::restore): (WebCore::GLES2Canvas::drawTexturedRect): (WebCore::GLES2Canvas::drawTexturedRectTile): (WebCore::GLES2Canvas::drawQuad):
  • platform/graphics/chromium/GLES2Canvas.h:
  • platform/graphics/gpu/BicubicShader.cpp: Removed.
  • platform/graphics/gpu/BicubicShader.h: Removed.
  • platform/graphics/gpu/ConvolutionShader.cpp: Removed.
  • platform/graphics/gpu/ConvolutionShader.h: Removed.
  • platform/graphics/gpu/DrawingBuffer.h:
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create): (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
  • platform/graphics/gpu/SharedGraphicsContext3D.h:
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::canAccelerate):
9:44 AM Changeset in webkit [81360] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-17 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Web Inspector tests timing out on Windows after r81222
​https://bugs.webkit.org/show_bug.cgi?id=56454

Remove custom expectations for Chromium tests that consistently pass locally.

  • platform/chromium/test_expectations.txt:
9:39 AM Changeset in webkit [81359] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip some tests that only fail on apple-macpro-6

<​http://webkit.org/b/56564> tracks the failures.

  • platform/mac-leopard/Skipped:
9:39 AM Changeset in webkit [81358] by mnaganov@chromium.org
  • 4 edits in trunk

2011-03-17 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Clean up Inspector strings.
​https://bugs.webkit.org/show_bug.cgi?id=56557

  • English.lproj/localizedStrings.js:

2011-03-17 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Clean up Inspector strings.
​https://bugs.webkit.org/show_bug.cgi?id=56557

Modify the script to deal correctly with "\xNN" escapes, and to
check strings in Chromium's DevTools.js.

  • Scripts/check-inspector-strings:
9:38 AM Changeset in webkit [81357] by Adam Roben
  • 3 edits in trunk/LayoutTests

Skip a test that is only failing on some Leopard slaves

svg/text/font-size-below-point-five.svg generates different results on apple-macpro-5 from
the other Leopard slaves. <​http://webkit.org/b/56544> tracks this issue.

  • platform/mac-leopard/Skipped: Skip svg/text/font-size-below-point-five.
  • platform/mac-leopard/svg/text/font-size-below-point-five-expected.txt: Reverted these

results to the results that all slaves except apple-macpro-5 generate.

9:26 AM Changeset in webkit [81356] by Joseph Pecoraro
  • 3 edits in trunk/LayoutTests

2011-03-17 Joseph Pecoraro <Joseph Pecoraro>

Unreviewed, bad expected results were added. This fixes
the expected results and unskips the test on GTK.

[GTK] fast/viewport/viewport-131.html fails
​https://bugs.webkit.org/show_bug.cgi?id=56556

  • fast/viewport/viewport-131-expected.txt:
  • platform/gtk/Skipped:
8:46 AM Changeset in webkit [81355] by podivilov@chromium.org
  • 16 edits
    2 adds in trunk

2011-03-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor event listener breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=56305

  • inspector/debugger/event-listener-breakpoints-expected.txt: Added.
  • inspector/debugger/event-listener-breakpoints.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor event listener breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=56305

  • restore event listener breakpoints one by one instead of using setAllBrowserBreakpoints
  • store event listener breakpoints in a separate separate setting
  • move presentation-related code from BreakpointManager to EventListenerBreakpointsSidebarPane

Test: inspector/debugger/event-listener-breakpoints.html

  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::setFrontend):
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::clear):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.setEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype.removeEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._saveBreakpoints): (WebInspector.BreakpointManager.prototype._validateBreakpoints): (WebInspector.BreakpointManager.prototype._createDOMBreakpointId):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.eventNameForUI): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._categoryCheckboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointCheckboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._updateCategoryCheckbox): (WebInspector.EventListenerBreakpointsSidebarPane.prototype.highlightBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane.prototype.clearBreakpointHighlight): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._saveBreakpoints): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._restoreBreakpoints):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype.setStatus): (WebInspector.CallStackSidebarPane.prototype._domBreakpointHit):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearInterface):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
8:42 AM Changeset in webkit [81354] by podivilov@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-17 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: timeline-paint.html is flaky on GTK 64-bit Debug.
​https://bugs.webkit.org/show_bug.cgi?id=56554

It is not guaranteed that we receive exactly one paint event.

  • inspector/timeline/timeline-paint.html:
  • inspector/timeline/timeline-test.js: (initialize_Timeline.InspectorTest.stopTimeline):
8:35 AM Fingerprinting edited by robert@roberthogan.net
(diff)
8:32 AM Fingerprinting edited by robert@roberthogan.net
(diff)
8:18 AM Changeset in webkit [81353] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-17 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip fast/reflections/abs-position-in-reflection.html on GTK
affected by bug 56180.

  • platform/gtk/Skipped:
8:11 AM Changeset in webkit [81352] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-17 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip flaky svg test on GTK.

  • platform/gtk/Skipped:
7:00 AM Changeset in webkit [81351] by Philippe Normand
  • 1 edit
    1 add in trunk/LayoutTests

2011-03-17 Philippe Normand <​pnormand@igalia.com>

Unreviewed, GTK baselines for fast/dynamic/text-combine.html added
in r81251.

  • platform/gtk/fast/dynamic/text-combine-expected.txt: Added.
6:57 AM Changeset in webkit [81350] by senorblanco@chromium.org
  • 12 edits
    4 adds in trunk

2011-03-16 Stephen White <​senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Implement GPU-accelerated shadows.
​https://bugs.webkit.org/show_bug.cgi?id=56476

For hard shadows, we simply offset the CTM and draw in the shadow
color. For soft shadows, we use a separable Gaussian convolution,
with a bilinear downsample and Mitchell-Netravali upsample in order to
preserve quality.

  • WebCore.gypi: Add BicubicShader and ConvolutionShader to the build.
  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::State::State): Add shadow-related members to the GLES2Canvas::State (WebCore::GLES2Canvas::State::shadowActive): Add a helper function to know if shadows are active. (WebCore::GLES2Canvas::clearRect): (WebCore::GLES2Canvas::scissorClear): Refactor the scissor clearing function out of clearRect(). (WebCore::GLES2Canvas::fillPath): Add hook for shadow rendering in paths. Bind framebuffer at this level. (WebCore::GLES2Canvas::fillRect): Add hook for shadow rendering in rects. Bind framebuffer at this level. (WebCore::GLES2Canvas::fillRectInternal): Rename fillRect() -> fillRectInternal(), which does bind its vertex buffer, but does not bind the framebuffer. (WebCore::GLES2Canvas::setShadowColor): (WebCore::GLES2Canvas::setShadowOffset): (WebCore::GLES2Canvas::setShadowBlur): (WebCore::GLES2Canvas::setShadowsIgnoreTransforms): Implement graphicsContext-style setters for shadow parameters. (WebCore::GLES2Canvas::clipPath): Call fillPathInternal(), not fillPath(). (WebCore::GLES2Canvas::restore): (WebCore::GLES2Canvas::drawTexturedRect): Bind the framebuffer at this level. Do not bind vertices here (will be done in drawTexturedQuad). (WebCore::GLES2Canvas::drawTexturedRectTile): drawQuad() -> drawTexturedQuad(). (WebCore::GLES2Canvas::convolveRect): Implement one pass of a convolution filter (X or Y). (WebCore::gauss): (WebCore::buildKernel): Some helper functions to build a Gaussian convolution kernel. (WebCore::GLES2Canvas::drawTexturedQuad): Rename drawQuad() -> drawTexturedQuad(), to be more clear. Do not bind the framebuffer at this level (it will be done higher). (WebCore::GLES2Canvas::drawTexturedQuadMitchell): Implement Mitchell-Netravali bicubic sampling, using BicubicShader. (WebCore::GLES2Canvas::fillPathInternal): Rename fillPath() -> fillPathInternal(), which does use quad vertices, but does not bind the framebuffer or set the compositing mode. (WebCore::GLES2Canvas::flipRect): Implement a helper function to flip a rectangle in Y within the canvas. (WebCore::GLES2Canvas::clearBorders): Implement a helper function to clear an n-pixel border around a rect. (WebCore::GLES2Canvas::beginShadowDraw): Setup before drawing a primitive's shadow: for hard shadows, just offset the CTM by the shadow offset. For soft shadows, bind to an offscreen DrawingBuffer. (WebCore::GLES2Canvas::endShadowDraw): Tear-down after drawing a primitive's shadow: for hard shadows, just restore the CTM. For soft shadows, downsample (if necessary), then blur in X, blur in Y, upsample if necessary).
  • platform/graphics/chromium/GLES2Canvas.h:
  • platform/graphics/gpu/BicubicShader.cpp: Added. (WebCore::BicubicShader::BicubicShader): (WebCore::BicubicShader::create): (WebCore::BicubicShader::use):
  • platform/graphics/gpu/BicubicShader.h: Added. Implement a bicubic image filtering shader.
  • platform/graphics/gpu/ConvolutionShader.cpp: Added. (WebCore::ConvolutionShader::ConvolutionShader): (WebCore::ConvolutionShader::create): (WebCore::ConvolutionShader::use):
  • platform/graphics/gpu/ConvolutionShader.h: Added. Implement a 1-dimensional convolution shader. In order to minimize texture samples, this shader is parameterized at compile time by the width of the convolution kernel.
  • platform/graphics/gpu/DrawingBuffer.h: (WebCore::DrawingBuffer::colorBuffer): Add an accessor to retrieve a DrawingBuffer's texture ID.
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create): (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::useBicubicProgram): (WebCore::SharedGraphicsContext3D::useConvolutionProgram): Create BicubicShader and cMaxKernelWidth ConvolutionShader's (one for each possible kernel width). (WebCore::SharedGraphicsContext3D::getOffscreenBuffer): Implement a simple cache of offscreen DrawingBuffers, integer-indexed. This is done to minimize the VRAM usage: only 2 buffers are used for all canvases.
  • platform/graphics/gpu/SharedGraphicsContext3D.h: Add bicubic and convolution shader members, and useXXX() functions.
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow): Hook into GraphicsContextSkia's platform shadow setters to set parameters on GLES2Canvas.
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::canAccelerate): Remove shadows (loopers) from the list of things we can't accelerate.

2011-03-16 Stephen White <​senorblanco@chromium.org>

Reviewed by Kenneth Russell.

Canvas2D GPU acceleration should support shadows
​https://bugs.webkit.org/show_bug.cgi?id=56476

  • fast/canvas/script-tests/canvas-transforms-fillRect-shadow.js: (shouldBeAround): Widen the threshold for this test, which doesn't seem to allow for a true Gaussian blur implementation.
  • platform/chromium/test_expectations.txt: Update some tests which are now passing on GPU, and some which time out due to Mesa slowness.
6:32 AM Changeset in webkit [81349] by apavlov@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-03-17 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, update expectations

  • platform/chromium-mac/fast/forms/input-number-unacceptable-style-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
5:11 AM Changeset in webkit [81348] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-03-17 Keith Kyzivat <​keith.kyzivat@nokia.com>

Reviewed by Benjamin Poulain.

Update autoinstall to install mechanize 0.2.4
​https://bugs.webkit.org/show_bug.cgi?id=56499

Newer versions of mechanize support HTTPS proxies, which is necessary
for people using webkit-patch behind firewalls.

  • Scripts/webkitpy/common/system/autoinstall.py:
  • Scripts/webkitpy/thirdparty/init.py:
5:00 AM Changeset in webkit [81347] by kov@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-03-17 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Andreas Kling.

Tiled backing store should only request repaint for updated areas
​https://bugs.webkit.org/show_bug.cgi?id=56464

Reuse updateBackBuffer's dirty rectangle calculations to only
invalidate the necessary parts of the window.

  • platform/graphics/Tile.h:
  • platform/graphics/TiledBackingStore.cpp: (WebCore::TiledBackingStore::updateTileBuffers):
  • platform/graphics/qt/TileQt.cpp: (WebCore::Tile::updateBackBuffer):
4:58 AM Changeset in webkit [81346] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-17 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip fast/profiler/window-dot-eval.html on GTK
affected by bug 56180.

  • platform/gtk/Skipped:
4:39 AM Changeset in webkit [81345] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-17 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] minor cleanup of devtools_files variable in WebKit.gyp
​https://bugs.webkit.org/show_bug.cgi?id=56503

  • WebKit.gyp: Moving duplicate variables out of a condition.
4:02 AM Changeset in webkit [81344] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-17 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip failing viewport test on GTK.

  • platform/gtk/Skipped:
3:32 AM Changeset in webkit [81343] by mnaganov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-17 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Reduce memory consumption by detailed heap snapshots indexes.
​https://bugs.webkit.org/show_bug.cgi?id=56395

  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotRetainerEdge): Added (WebInspector.HeapSnapshotRetainerEdgeIterator): Added (WebInspector.HeapSnapshotNode.prototype.get retainers): (WebInspector.HeapSnapshot.prototype.dispose): (WebInspector.HeapSnapshot.prototype.hasId): (WebInspector.HeapSnapshot.prototype.retainers): (WebInspector.HeapSnapshot.prototype._buildRetainers): (WebInspector.HeapSnapshot.prototype._buildIdsList): (WebInspector.HeapSnapshot.prototype._buildNodeIndex): (WebInspector.HeapSnapshot.prototype._findNodePositionInIndex): (WebInspector.HeapSnapshot.prototype._findNearestNodeIndex): (WebInspector.HeapSnapshot.prototype._getRetainerIndex): (WebInspector.HeapSnapshot.prototype._markInvisibleEdges): (WebInspector.HeapSnapshot.prototype._numbersComparator): (WebInspector.HeapSnapshotPathFinder.prototype.get _lastEdge): (WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter): (WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath): (WebInspector.HeapSnapshotPathFinder.prototype._pathToString):
2:49 AM Changeset in webkit [81342] by podivilov@chromium.org
  • 16 edits
    2 deletes in trunk

2011-03-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81243.
​http://trac.webkit.org/changeset/81243
​https://bugs.webkit.org/show_bug.cgi?id=56471

Breaks GTK 64-bit Debug tests (Requested by podivilov on
#webkit).

  • inspector/debugger/event-listener-breakpoints-expected.txt: Removed.
  • inspector/debugger/event-listener-breakpoints.html: Removed.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-17 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81243.
​http://trac.webkit.org/changeset/81243
​https://bugs.webkit.org/show_bug.cgi?id=56471

Breaks GTK 64-bit Debug tests (Requested by podivilov on
#webkit).

  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::setFrontend):
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::setFrontend): (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::discardBindings): (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::clear):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.createEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype._createEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype.setXHRBreakpoint): (WebInspector.BreakpointManager.prototype.removeXHRBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._saveBreakpoints): (WebInspector.BreakpointManager.prototype._validateBreakpoints): (WebInspector.BreakpointManager.prototype._createDOMBreakpointId): (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId): (WebInspector.EventListenerBreakpoint): (WebInspector.EventListenerBreakpoint.prototype._enable): (WebInspector.EventListenerBreakpoint.prototype._disable): (WebInspector.EventListenerBreakpoint.prototype._serializeToJSON): (WebInspector.EventListenerBreakpointView): (WebInspector.EventListenerBreakpointView.eventNameForUI): (WebInspector.EventListenerBreakpointView.prototype.get eventName): (WebInspector.EventListenerBreakpointView.prototype.compareTo): (WebInspector.EventListenerBreakpointView.prototype.populateLabelElement): (WebInspector.EventListenerBreakpointView.prototype.populateStatusMessageElement): (WebInspector.EventListenerBreakpointView.prototype._uiEventName):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._categoryCheckboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointCheckboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointAdded): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointHitStateChanged): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointRemoved): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._updateCategoryCheckbox): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._projectChanged):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit): (WebInspector.CallStackSidebarPane.prototype._xhrBreakpointHit): (WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearInterface):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
2:17 AM Changeset in webkit [81341] by Joseph Pecoraro
  • 1 edit
    6 adds in trunk/LayoutTests

2011-03-17 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Kenneth Rohde Christiansen.

Viewport test for user-scalable=yes
​https://bugs.webkit.org/show_bug.cgi?id=56527

Provide tests for user-scalable no, yes, and default values.

  • fast/viewport/viewport-130-expected.txt: Added.
  • fast/viewport/viewport-130.html: Added.
  • fast/viewport/viewport-131-expected.txt: Added.
  • fast/viewport/viewport-131.html: Added.
  • fast/viewport/viewport-132-expected.txt: Copied from LayoutTests/fast/viewport/viewport-1-expected.txt.
  • fast/viewport/viewport-132.html: Added.
1:49 AM Changeset in webkit [81340] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-17 Patrick Gansterer <Patrick Gansterer>

Fix the interpreter build.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): Added globalData to inheritorID().
1:35 AM Changeset in webkit [81339] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add more ObjC++ files to the build
​https://bugs.webkit.org/show_bug.cgi?id=56548

96 link errors.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
1:14 AM Changeset in webkit [81338] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Add transitions/default-timing-function.html to the SnowLeopard WebKit2 Skipped list.
​https://bugs.webkit.org/show_bug.cgi?id=56531

Reviewed by Adam Roben.

  • platform/mac-wk2/Skipped:
1:10 AM Changeset in webkit [81337] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add a few Objective-C++ files to the WebCore GYP build
​https://bugs.webkit.org/show_bug.cgi?id=56547

464 link errors.

  • gyp/WebCore.gyp:
1:04 AM Changeset in webkit [81336] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Add java/lc3/JavaObject/JavaObjectToDouble-001.html to the mac-leopard Skipped list.
​https://bugs.webkit.org/show_bug.cgi?id=56545

Reviewed by Adam Roben.

  • This test was getting different results on different slaves.
  • platform/mac-leopard/Skipped:
12:51 AM Changeset in webkit [81335] by yutak@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-17 Yuta Kitamura <​yutak@chromium.org>

Unreviewed build fix.

Non-ASCII characters in XMLTreeViewer.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=56549

  • xml/XMLTreeViewer.cpp: Replace non-ASCII characters with ASCII equivalents.
  • xml/XMLTreeViewer.h: Ditto.
12:42 AM Changeset in webkit [81334] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add plugins and bridge to the WebCore GYP build
​https://bugs.webkit.org/show_bug.cgi?id=56546

506 link errors.

  • gyp/WebCore.gyp:
12:14 AM Changeset in webkit [81333] by weinig@apple.com
  • 2 edits
    1 move in trunk/LayoutTests

Disable fast/workers/storage/interrupt-database-sync.html due to flakiness on
multiple platforms.
​https://bugs.webkit.org/show_bug.cgi?id=49906

Reviewed by Adam Roben.

  • fast/workers/storage/interrupt-database-sync.html: Removed.
  • fast/workers/storage/interrupt-database-sync.html-disabled: Copied from fast/workers/storage/interrupt-database-sync.html.
  • platform/qt/Skipped: Remove from qt Skipped list since it is now disabled.
12:04 AM Changeset in webkit [81332] by weinig@apple.com
  • 2 edits
    4 adds in trunk/LayoutTests

Adding new results for some failing tests on the Leopard Debug/Leopard Release Tester.

Reviewed by Adam Roben.

The following bugs were filed to track these issues:

​https://bugs.webkit.org/show_bug.cgi?id=56544
​https://bugs.webkit.org/show_bug.cgi?id=56545

  • platform/mac-leopard/java/lc3/JavaObject/JavaObjectToDouble-001-expected.txt: Added.
  • platform/mac-leopard/svg/text/font-size-below-point-five-expected.txt:

Mar 16, 2011:

11:51 PM Changeset in webkit [81331] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Adding plugins/destroy-on-setwindow.html to the mac-leopard Skipped list.
​https://bugs.webkit.org/show_bug.cgi?id=56165 was filed to track this issue.

Reviewed by Adam Roben.

  • platform/mac-leopard/Skipped:
11:39 PM Changeset in webkit [81330] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-03-16 Jeff Johnson <​github@lapcatsoftware.com>

Reviewed by Alexey Proskuryakov.

Logic error in -[WebHTMLView close]
​https://bugs.webkit.org/show_bug.cgi?id=56445

The function setDraggingImageURL() is no longer called and can be deleted.

No new tests. Deleting dead code.

  • page/DragController.h:

2011-03-16 Jeff Johnson <​github@lapcatsoftware.com>

Reviewed by Alexey Proskuryakov.

Logic error in -[WebHTMLView close]
​https://bugs.webkit.org/show_bug.cgi?id=56445

Page is always nil at this point, because [self _webView] is nil,
so the conditional code is never run.

  • WebView/WebHTMLView.mm: (-[WebHTMLView close]):
11:34 PM Changeset in webkit [81329] by weinig@apple.com
  • 1 edit
    16 adds in trunk/LayoutTests

Adding new results for some failing tests on the SnowLeopard WebKit2 Tester.

Reviewed by Adam Roben; Dictated, but not read, by Adam Roben.

The following bugs were filed to track these issues:

​https://bugs.webkit.org/show_bug.cgi?id=56528
​https://bugs.webkit.org/show_bug.cgi?id=56530
​https://bugs.webkit.org/show_bug.cgi?id=56531
​https://bugs.webkit.org/show_bug.cgi?id=56532
​https://bugs.webkit.org/show_bug.cgi?id=56533
​https://bugs.webkit.org/show_bug.cgi?id=56537
​https://bugs.webkit.org/show_bug.cgi?id=56539

  • platform/mac-wk2/animations/animation-controller-drt-api-expected.txt: Added.
  • platform/mac-wk2/http/tests/appcache/online-fallback-layering-expected.txt: Added.
  • platform/mac-wk2/http/tests/inspector/console-resource-errors-expected.txt: Added.
  • platform/mac-wk2/http/tests/inspector/resource-har-conversion-expected.txt: Added.
  • platform/mac-wk2/http/tests/xmlviewer/dumpAsText/frames-expected.txt: Added.
  • platform/mac-wk2/media/controls-without-preload-expected.txt: Added.
  • platform/mac-wk2/transitions/default-timing-function-expected.txt: Added.
11:31 PM Changeset in webkit [81328] by commit-queue@webkit.org
  • 5 edits in trunk

2011-03-16 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Ryosuke Niwa.

Textarea maxlength doesn't account for newlines
​https://bugs.webkit.org/show_bug.cgi?id=54443

  • fast/forms/script-tests/textarea-maxlength.js: (createFocusedTextAreaWithMaxLength3): Added two tests to make sure consecutive insertbreaks work correctly for textarea maxlength.
  • fast/forms/textarea-maxlength-expected.txt: Added two test results.

2011-03-16 Naoki Takano <​takano.naoki@gmail.com>

Reviewed by Ryosuke Niwa.

Textarea maxlength doesn't account for newlines
​https://bugs.webkit.org/show_bug.cgi?id=54443

When a user presses a return key, TypingCommand::insertLineBreak() is called.
So before append a new line, check if we can add the new line.

  • editing/TypingCommand.cpp: (WebCore::canAppendNewLineFeed): Implement new helper function to check if we can add new line. (WebCore::TypingCommand::insertLineBreak): Added check logic before adding the new line. (WebCore::TypingCommand::insertParagraphSeparator): Added check logic before adding the new line.
11:14 PM Changeset in webkit [81327] by weinig@apple.com
  • 2 edits in trunk/Tools

2011-03-16 Sam Weinig <​sam@webkit.org>

Reviewed by Adam Roben.

REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=56541

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::willSendRequestForFrame): Check for an empty host in addition to a null host. This bug was introduced when porting off of the KURL code and onto the WKURLRef version.
11:12 PM Changeset in webkit [81326] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should build more derived sources
​https://bugs.webkit.org/show_bug.cgi?id=56529

This patch brings us down to 597 link errors.

  • gyp/WebCore.gyp:
11:09 PM Changeset in webkit [81325] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-03-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP should build (most) remaining source files
​https://bugs.webkit.org/show_bug.cgi?id=56515

We're still not building all the files and we have 1305 link errors,
but this patch is progress.

  • WebCore.gypi:
  • gyp/WebCore.gyp:
  • plugins/PluginStream.cpp:
10:38 PM Changeset in webkit [81324] by alice.liu@apple.com
  • 2 edits in trunk/LayoutTests

Add fast/workers/storage/interrupt-database-sync.html to the win-xp skipped list
due to intermittent failure; tracked by ​https://bugs.webkit.org/show_bug.cgi?id=56534

  • platform/win-xp/Skipped:
10:37 PM Changeset in webkit [81323] by weinig@apple.com
  • 2 edits in trunk/Tools

Add Lucas Forschler to the list of WebKit committers.

Reviewed by Adam Roben.

  • Scripts/webkitpy/common/config/committers.py:
10:22 PM Changeset in webkit [81322] by weinig@apple.com
  • 3 edits in trunk/LayoutTests

Add compositing/transitions/singular-scale-transition.html to the Skipped lists.
Seems to be the same assert that ​https://bugs.webkit.org/show_bug.cgi?id=56488 was
filed for.

  • platform/mac/Skipped:
  • platform/win/Skipped:
10:13 PM Changeset in webkit [81321] by weinig@apple.com
  • 2 edits in trunk/Tools

Reviewed upon and dictated through Adam Roben.

Escape crashing function names in results.html. This fixes an issue
when a crash involves a type with templates.

  • Scripts/old-run-webkit-tests:
9:46 PM Changeset in webkit [81320] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix the interpreter build.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::resolve):
(JSC::Interpreter::resolveSkip):
(JSC::Interpreter::resolveGlobal):
(JSC::Interpreter::resolveGlobalDynamic):
(JSC::Interpreter::resolveBaseAndProperty):
(JSC::Interpreter::privateExecute):
Remove .get()s.

9:36 PM Changeset in webkit [81319] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Update the default navigator.vendor value
​https://bugs.webkit.org/show_bug.cgi?id=56449

Reviewed by Alexey Proskuryakov.

  • page/NavigatorBase.cpp: Updated the default value of

WEBCORE_NAVIGATOR_VENDOR.

9:27 PM Changeset in webkit [81318] by Joseph Pecoraro
  • 3 edits
    1 delete in trunk/LayoutTests

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Follow-up patch to update GTK expected results.
It looks like the GTK platform specific results for
some viewport tests match regular results, and there
were a few viewport tests that still needed expected
results since other platforms skip them.

Viewport no longer allows an auto value for "user-scalable"
​https://bugs.webkit.org/show_bug.cgi?id=55416

  • fast/viewport/viewport-58-expected.txt:
  • fast/viewport/viewport-6-expected.txt:
  • platform/gtk/fast/viewport/viewport-91-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-92-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-93-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-94-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-95-expected.txt: Removed.
  • platform/gtk/fast/viewport/viewport-96-expected.txt: Removed.
8:56 PM Changeset in webkit [81317] by commit-queue@webkit.org
  • 4 edits in trunk

2011-03-16 John Bauman <​jbauman@chromium.org>

Reviewed by James Robinson.

texImage2D gets old contents of canvas
​https://bugs.webkit.org/show_bug.cgi?id=56414

  • platform/chromium/test_expectations.txt: premultiply-alpha test now works

2011-03-16 John Bauman <​jbauman@chromium.org>

Reviewed by James Robinson.

texImage2D gets old contents of canvas
​https://bugs.webkit.org/show_bug.cgi?id=56414

Always update the canvas contents in copiedImage, as there's no reason
to ask for an out-of-date image.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::copiedImage):
8:46 PM Changeset in webkit [81316] by abarth@webkit.org
  • 7 edits in trunk/Source

2011-03-16 Adam Barth <​abarth@webkit.org>

Reviewed by James Robinson.

Remove USE(BUILTIN_UTF8_CODEC)
​https://bugs.webkit.org/show_bug.cgi?id=56508

We added this recently when we were unsure about the stability of the
built-in UTF-8 codec. However, the codec seems to be stable, so we
don't need the macro.

  • wtf/Platform.h:

2011-03-16 Adam Barth <​abarth@webkit.org>

Reviewed by James Robinson.

Remove USE(BUILTIN_UTF8_CODEC)
​https://bugs.webkit.org/show_bug.cgi?id=56508

  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerEncodingNames):
  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps):

2011-03-16 Adam Barth <​abarth@webkit.org>

Reviewed by James Robinson.

Remove USE(BUILTIN_UTF8_CODEC)
​https://bugs.webkit.org/show_bug.cgi?id=56508

  • features.gypi:
8:46 PM Changeset in webkit [81315] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Check in new results for text-combine-image-test-expected.txt.

  • platform/mac-leopard/fast/text/international/text-combine-image-test-expected.txt:
8:07 PM Changeset in webkit [81314] by weinig@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix changelog.

8:04 PM Changeset in webkit [81313] by weinig@apple.com
  • 3 edits
    8 adds in trunk/LayoutTests

Adding new results for some failing tests on the Leopard Release Tester.

The following bugs were filed to track these issues:

​https://bugs.webkit.org/show_bug.cgi?id=56516
​https://bugs.webkit.org/show_bug.cgi?id=56517
​https://bugs.webkit.org/show_bug.cgi?id=56518
​https://bugs.webkit.org/show_bug.cgi?id=56519
​https://bugs.webkit.org/show_bug.cgi?id=56521
​https://bugs.webkit.org/show_bug.cgi?id=56522
​https://bugs.webkit.org/show_bug.cgi?id=56522
​https://bugs.webkit.org/show_bug.cgi?id=56525

  • platform/mac-leopard/Skipped:
  • platform/mac-leopard/fast/blockflow/text-orientation-basic-expected.txt: Added.
  • platform/mac-leopard/fast/forms/file-input-disabled-expected.txt:
  • platform/mac-leopard/fast/forms/input-number-unacceptable-style-expected.txt: Added.
  • platform/mac-leopard/fast/ruby/base-shorter-than-text-expected.txt: Added.
  • platform/mac-leopard/fast/text/text-combine-image-test-expected.txt: Added.
  • platform/mac-leopard/media/controls-without-preload-expected.txt: Added.
  • platform/mac-leopard/platform/mac/accessibility: Added.
  • platform/mac-leopard/platform/mac/accessibility/aria-table-with-colspan-cells-expected.txt: Added.
  • platform/mac-leopard/platform/mac/accessibility/list-items-ignored-expected.txt: Added.
7:48 PM Changeset in webkit [81312] by Joseph Pecoraro
  • 122 edits in trunk/LayoutTests

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Follow-up patch landing updated expected results,
which now include the userScalable value in output.

Viewport no longer allows an auto value for "user-scalable"
​https://bugs.webkit.org/show_bug.cgi?id=55416

  • fast/viewport/viewport-1-expected.txt:
  • fast/viewport/viewport-10-expected.txt:
  • fast/viewport/viewport-100-expected.txt:
  • fast/viewport/viewport-101-expected.txt:
  • fast/viewport/viewport-102-expected.txt:
  • fast/viewport/viewport-103-expected.txt:
  • fast/viewport/viewport-104-expected.txt:
  • fast/viewport/viewport-105-expected.txt:
  • fast/viewport/viewport-106-expected.txt:
  • fast/viewport/viewport-107-expected.txt:
  • fast/viewport/viewport-108-expected.txt:
  • fast/viewport/viewport-109-expected.txt:
  • fast/viewport/viewport-11-expected.txt:
  • fast/viewport/viewport-110-expected.txt:
  • fast/viewport/viewport-111-expected.txt:
  • fast/viewport/viewport-112-expected.txt:
  • fast/viewport/viewport-113-expected.txt:
  • fast/viewport/viewport-114-expected.txt:
  • fast/viewport/viewport-115-expected.txt:
  • fast/viewport/viewport-116-expected.txt:
  • fast/viewport/viewport-117-expected.txt:
  • fast/viewport/viewport-118-expected.txt:
  • fast/viewport/viewport-119-expected.txt:
  • fast/viewport/viewport-12-expected.txt:
  • fast/viewport/viewport-120-expected.txt:
  • fast/viewport/viewport-121-expected.txt:
  • fast/viewport/viewport-122-expected.txt:
  • fast/viewport/viewport-123-expected.txt:
  • fast/viewport/viewport-124-expected.txt:
  • fast/viewport/viewport-125-expected.txt:
  • fast/viewport/viewport-129-expected.txt:
  • fast/viewport/viewport-13-expected.txt:
  • fast/viewport/viewport-14-expected.txt:
  • fast/viewport/viewport-15-expected.txt:
  • fast/viewport/viewport-16-expected.txt:
  • fast/viewport/viewport-17-expected.txt:
  • fast/viewport/viewport-18-expected.txt:
  • fast/viewport/viewport-19-expected.txt:
  • fast/viewport/viewport-2-expected.txt:
  • fast/viewport/viewport-20-expected.txt:
  • fast/viewport/viewport-21-expected.txt:
  • fast/viewport/viewport-22-expected.txt:
  • fast/viewport/viewport-23-expected.txt:
  • fast/viewport/viewport-24-expected.txt:
  • fast/viewport/viewport-25-expected.txt:
  • fast/viewport/viewport-26-expected.txt:
  • fast/viewport/viewport-27-expected.txt:
  • fast/viewport/viewport-28-expected.txt:
  • fast/viewport/viewport-29-expected.txt:
  • fast/viewport/viewport-3-expected.txt:
  • fast/viewport/viewport-30-expected.txt:
  • fast/viewport/viewport-31-expected.txt:
  • fast/viewport/viewport-32-expected.txt:
  • fast/viewport/viewport-33-expected.txt:
  • fast/viewport/viewport-34-expected.txt:
  • fast/viewport/viewport-35-expected.txt:
  • fast/viewport/viewport-36-expected.txt:
  • fast/viewport/viewport-37-expected.txt:
  • fast/viewport/viewport-38-expected.txt:
  • fast/viewport/viewport-39-expected.txt:
  • fast/viewport/viewport-4-expected.txt:
  • fast/viewport/viewport-40-expected.txt:
  • fast/viewport/viewport-41-expected.txt:
  • fast/viewport/viewport-42-expected.txt:
  • fast/viewport/viewport-43-expected.txt:
  • fast/viewport/viewport-44-expected.txt:
  • fast/viewport/viewport-46-expected.txt:
  • fast/viewport/viewport-47-expected.txt:
  • fast/viewport/viewport-48-expected.txt:
  • fast/viewport/viewport-49-expected.txt:
  • fast/viewport/viewport-5-expected.txt:
  • fast/viewport/viewport-50-expected.txt:
  • fast/viewport/viewport-51-expected.txt:
  • fast/viewport/viewport-52-expected.txt:
  • fast/viewport/viewport-53-expected.txt:
  • fast/viewport/viewport-54-expected.txt:
  • fast/viewport/viewport-55-expected.txt:
  • fast/viewport/viewport-56-expected.txt:
  • fast/viewport/viewport-57-expected.txt:
  • fast/viewport/viewport-59-expected.txt:
  • fast/viewport/viewport-60-expected.txt:
  • fast/viewport/viewport-61-expected.txt:
  • fast/viewport/viewport-62-expected.txt:
  • fast/viewport/viewport-63-expected.txt:
  • fast/viewport/viewport-64-expected.txt:
  • fast/viewport/viewport-66-expected.txt:
  • fast/viewport/viewport-67-expected.txt:
  • fast/viewport/viewport-68-expected.txt:
  • fast/viewport/viewport-69-expected.txt:
  • fast/viewport/viewport-7-expected.txt:
  • fast/viewport/viewport-70-expected.txt:
  • fast/viewport/viewport-71-expected.txt:
  • fast/viewport/viewport-72-expected.txt:
  • fast/viewport/viewport-73-expected.txt:
  • fast/viewport/viewport-74-expected.txt:
  • fast/viewport/viewport-75-expected.txt:
  • fast/viewport/viewport-76-expected.txt:
  • fast/viewport/viewport-77-expected.txt:
  • fast/viewport/viewport-78-expected.txt:
  • fast/viewport/viewport-79-expected.txt:
  • fast/viewport/viewport-8-expected.txt:
  • fast/viewport/viewport-80-expected.txt:
  • fast/viewport/viewport-81-expected.txt:
  • fast/viewport/viewport-83-expected.txt:
  • fast/viewport/viewport-85-expected.txt:
  • fast/viewport/viewport-86-expected.txt:
  • fast/viewport/viewport-88-expected.txt:
  • fast/viewport/viewport-9-expected.txt:
  • fast/viewport/viewport-90-expected.txt:
  • fast/viewport/viewport-91-expected.txt:
  • fast/viewport/viewport-92-expected.txt:
  • fast/viewport/viewport-93-expected.txt:
  • fast/viewport/viewport-94-expected.txt:
  • fast/viewport/viewport-95-expected.txt:
  • fast/viewport/viewport-96-expected.txt:
  • fast/viewport/viewport-warnings-1-expected.txt:
  • fast/viewport/viewport-warnings-2-expected.txt:
  • fast/viewport/viewport-warnings-3-expected.txt:
  • fast/viewport/viewport-warnings-4-expected.txt:
  • fast/viewport/viewport-warnings-5-expected.txt:
  • fast/viewport/viewport-warnings-6-expected.txt:
7:11 PM Changeset in webkit [81311] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-16 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

Make JIT build for ARM Thumb-2 with RVCT
​https://bugs.webkit.org/show_bug.cgi?id=56440

Derived from a patch by Dave Tapuska.

Also, modify the RVCT stub template to indicate that it preserves 8 byte stack alignment.

  • jit/JITStubs.cpp:
7:10 PM Changeset in webkit [81310] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-16 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

[chromium] include inspector gif files in the list of resources
​https://bugs.webkit.org/show_bug.cgi?id=56504

  • scripts/generate_devtools_grd.py:
6:53 PM Changeset in webkit [81309] by Joseph Pecoraro
  • 13 edits in trunk/Source

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Viewport no longer allows an auto value for "user-scalable"
​https://bugs.webkit.org/show_bug.cgi?id=55416

This restores our behavior before r67376 the default "user-scalable"
behavior can be defined by a WebKit client if a value was not
explicitly provided in web content (via the viewport <meta> tag).
Here, all WebKit ports default to "yes" after computing
viewport arguments. However, in the future they may consider
changing the default user-scalable value based on the type
of the document being viewed, a user preference, or other reasons.

Covered by existing tests. Should be no changes.

  • dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes): be explicit about 0. (WebCore::findUserScalableValue): convert to return a float, the instance variable type.
  • dom/ViewportArguments.h: (WebCore::ViewportArguments::ViewportArguments): convert the boolean back to a float to allow for 3 states. Explicit no, explicit yes, and ValueAuto to be defined by the WebKit client.

Source/WebKit/efl:

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Viewport no longer allows an auto value for "user-scalable"
​https://bugs.webkit.org/show_bug.cgi?id=55416

Make the default value for userScalable be true.

  • ewk/ewk_view.cpp: (ewk_view_viewport_attributes_get):

Source/WebKit/gtk:

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Viewport no longer allows an auto value for "user-scalable"
​https://bugs.webkit.org/show_bug.cgi?id=55416

Make the default value for userScalable be true.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::dumpConfigurationForViewport): update test output to include userScalable.
  • webkit/webkitviewportattributes.cpp: (webkitViewportAttributesRecompute):

Source/WebKit/qt:

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Viewport no longer allows an auto value for "user-scalable"
​https://bugs.webkit.org/show_bug.cgi?id=55416

Make the default value for userScalable be true.

  • Api/qwebpage.cpp: (QWebPage::viewportAttributesForSize):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::viewportAsText): update test output to include userScalable.

Source/WebKit2:

2011-03-16 Joseph Pecoraro <Joseph Pecoraro>

Viewport no longer allows an auto value for "user-scalable"
​https://bugs.webkit.org/show_bug.cgi?id=55416

Make the default value for userScalable be true.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::viewportAttributesForSize):
6:53 PM Changeset in webkit [81308] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-16 Chao-ying Fu <​fu@mips.com>

Reviewed by Darin Adler.

Fix MIPS build with const *void
​https://bugs.webkit.org/show_bug.cgi?id=56513

  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::load32): (JSC::MacroAssemblerMIPS::store32):
6:46 PM Changeset in webkit [81307] by levin@chromium.org
  • 7 edits in trunk/LayoutTests

New baselines because the play button is now a pause button due to r81300.

  • platform/chromium-linux/media/controls-after-reload-expected.checksum:
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.checksum:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-win-xp/media/controls-after-reload-expected.checksum:
  • platform/chromium-win-xp/media/controls-after-reload-expected.png:
6:05 PM Changeset in webkit [81306] by abarth@webkit.org
  • 5 edits in trunk/LayoutTests

2011-03-16 Adam Barth <​abarth@webkit.org>

Update the Skipped lists to reflect the new location of these tests.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
5:57 PM Changeset in webkit [81305] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r81289): Fix valgrind error (and crashes) when running the chromium unit test "test_shell_test".

Reviewed by Dmitry Titov.

Conditional jump or move depends on uninitialised value(s)

WebCore::RenderLayerCompositor::RenderLayerCompositor(WebCore::RenderView*) (third_party/WebKit/Source/WebCore/rendering/RenderLayerCompositor.cpp:117)

  • page/Settings.cpp:

(WebCore::Settings::Settings):

5:49 PM Changeset in webkit [81304] by Beth Dakin
  • 8 edits in trunk/Source/WebCore

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=56493 Drag-scrolling overlay
scrollbars thumb in overflow regions does not work
-and corresponding-
<rdar://problem/9112688> Drag-scrolling overlay scrollbars thumb in overflow
regions does not work

Reviewed by Darin Adler.

Up until now, overlay scrollbars have always been treated in the Render Tree as if
they have a thickness of 0 because they should not affect layout. However, it is
important to consider their size when hit-testing because otherwise, we have this
bug! This patch adds a boolean parameter to overflowClipRect(),
RenderLayer::verticalScrollbarWidth(), and
RenderLayer::horizontalScrollbarHeight(). This bool indicates whether to include
the actual overlay scrollbar thickness. It defaults to false and is only sent is
as true from RenderBloc::nodeAtPoint().

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::overflowClipRect):

  • rendering/RenderBox.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::verticalScrollbarWidth):
(WebCore::RenderLayer::horizontalScrollbarHeight):

  • rendering/RenderLayer.h:
  • rendering/RenderTable.cpp:

(WebCore::RenderTable::overflowClipRect):

  • rendering/RenderTable.h:
5:45 PM Changeset in webkit [81303] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-03-16 Bill Budge <​bbudge@chromium.org>

Reviewed by David Levin.

AssociatedURLLoader does not support Cross Origin Requests
​https://bugs.webkit.org/show_bug.cgi?id=53925

No new tests. Exposes no new functionality.

  • public/WebURLLoader.h: (WebKit::WebURLLoaderOptions::WebURLLoaderOptions):
  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::isDocumentThreadableLoaderClient): (WebKit::AssociatedURLLoader::ClientAdapter::clearClient): (WebKit::AssociatedURLLoader::ClientAdapter::create): (WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter): (WebKit::AssociatedURLLoader::ClientAdapter::willSendRequest): (WebKit::AssociatedURLLoader::ClientAdapter::didSendData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveCachedMetadata): (WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading): (WebKit::AssociatedURLLoader::ClientAdapter::didFail): (WebKit::AssociatedURLLoader::AssociatedURLLoader): (WebKit::AssociatedURLLoader::~AssociatedURLLoader): (WebKit::AssociatedURLLoader::loadSynchronously): (WebKit::AssociatedURLLoader::loadAsynchronously): (WebKit::AssociatedURLLoader::cancel): (WebKit::AssociatedURLLoader::setDefersLoading):
  • src/AssociatedURLLoader.h:
5:34 PM Changeset in webkit [81302] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-16 Keith Kyzivat <​keith.kyzivat@nokia.com>

Reviewed by Andreas Kling.

[Qt] Fix std::swap not found issue on mobile Qt devices.
​https://bugs.webkit.org/show_bug.cgi?id=56463

Include <algorithm> in TextBreakIteratorQt.cpp so std::swap is found
on some Qt mobile devices.

No new tests: No tests needed - compilation verified manually.

  • platform/text/qt/TextBreakIteratorQt.cpp: (WebCore::acquireLineBreakIterator):
5:26 PM Changeset in webkit [81301] by levin@chromium.org
  • 11 edits in trunk/LayoutTests

Update test expectations due to r81280 (media/controls-without-preload.html),
and r81285 (media-document-audio-repaint-expected).

  • platform/chromium-linux/media/controls-without-preload-expected.checksum:
  • platform/chromium-linux/media/controls-without-preload-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.checksum:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/media/controls-without-preload-expected.checksum:
  • platform/chromium-mac/media/controls-without-preload-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.checksum:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.checksum:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
5:24 PM Changeset in webkit [81300] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-03-16 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by David Levin.

Improve robustness of controls-after-reload by seeking to the start explicitly at the end of the test.
​https://bugs.webkit.org/show_bug.cgi?id=56491

  • media/controls-after-reload.html: Added an extra step to seek to 0 before the end of the test.
5:21 PM Changeset in webkit [81299] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Update the Skipped list.

Reviewed by Adam Roben.

  • platform/mac-wk2/Skipped:
5:16 PM Changeset in webkit [81298] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-03-16 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] WebGL content not shown when accelerated compositing is enabled
​https://bugs.webkit.org/show_bug.cgi?id=56339

Removed all previously implemented WebGL code from GraphicsLayerQt
because API has changed. GraphicsContext3D provides PlatformLayer
that is added as a child of GraphicsLayer and is therefore painted
through QGraphicsView pipeline.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::paint): (WebCore::GraphicsContext3DInternal::boundingRect): (WebCore::GraphicsContext3D::platformLayer): (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): (WebCore::GraphicsContext3D::reshape):
  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::GraphicsLayerQt::setContentsToCanvas):
  • platform/graphics/qt/GraphicsLayerQt.h:
5:15 PM Changeset in webkit [81297] by abarth@webkit.org
  • 1 edit
    2 copies
    3 moves
    3 adds in trunk/LayoutTests

2011-03-16 Adam Klein <​adamk@chromium.org>

Reviewed by Adam Barth.

LayoutTests exercising filesystem: URIs should run over HTTP to avoid weirdness related to file: URLs
​https://bugs.webkit.org/show_bug.cgi?id=56328

Moves the test for resolveLocalFileSystemURI into new "filesystem"
directory under http/tests/, and adjusts file paths appropriately.

  • fast/filesystem/resolve-uri-expected.txt: Removed.
  • fast/filesystem/resolve-uri.html: Removed.
  • fast/filesystem/script-tests/resolve-uri.js: Removed.
  • http/tests/filesystem: Added.
  • http/tests/filesystem/resolve-uri-expected.txt: Copied from LayoutTests/fast/filesystem/resolve-uri-expected.txt.
  • http/tests/filesystem/resolve-uri.html: Copied from LayoutTests/fast/filesystem/resolve-uri.html.
  • http/tests/filesystem/resources: Added.
  • http/tests/filesystem/resources/fs-test-util.js: Copied from LayoutTests/fast/filesystem/resources/fs-test-util.js.
  • http/tests/filesystem/script-tests: Added.
  • http/tests/filesystem/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/filesystem/script-tests/TEMPLATE.html.
  • http/tests/filesystem/script-tests/resolve-uri.js: Copied from LayoutTests/fast/filesystem/script-tests/resolve-uri.js.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped: Added new http/tests/filesystem directory to skip lists since they don't suppor the filesystem API.
5:12 PM Changeset in webkit [81296] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-03-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

NPObjectProxy and NPObjectMessageReceiver objects should know their Plugin object
​https://bugs.webkit.org/show_bug.cgi?id=56506

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::windowScriptNPObject): (WebKit::PluginControllerProxy::pluginElementNPObject): (WebKit::PluginControllerProxy::evaluate): (WebKit::PluginControllerProxy::getPluginScriptableNPObject):
  • Shared/Plugins/NPObjectMessageReceiver.cpp: (WebKit::NPObjectMessageReceiver::create): (WebKit::NPObjectMessageReceiver::NPObjectMessageReceiver): (WebKit::NPObjectMessageReceiver::invoke): (WebKit::NPObjectMessageReceiver::invokeDefault): (WebKit::NPObjectMessageReceiver::getProperty): (WebKit::NPObjectMessageReceiver::setProperty): (WebKit::NPObjectMessageReceiver::construct):
  • Shared/Plugins/NPObjectMessageReceiver.h:
  • Shared/Plugins/NPObjectProxy.cpp: (WebKit::NPObjectProxy::create): (WebKit::NPObjectProxy::NPObjectProxy): (WebKit::NPObjectProxy::invalidate): (WebKit::NPObjectProxy::initialize): (WebKit::NPObjectProxy::invoke): (WebKit::NPObjectProxy::invokeDefault): (WebKit::NPObjectProxy::getProperty): (WebKit::NPObjectProxy::setProperty): (WebKit::NPObjectProxy::construct):
  • Shared/Plugins/NPObjectProxy.h:
  • Shared/Plugins/NPRemoteObjectMap.cpp: (WebKit::NPRemoteObjectMap::createNPObjectProxy): (WebKit::NPRemoteObjectMap::registerNPObject): (WebKit::NPRemoteObjectMap::npVariantToNPVariantData): (WebKit::NPRemoteObjectMap::npVariantDataToNPVariant):
  • Shared/Plugins/NPRemoteObjectMap.h:
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::pluginScriptableNPObject): (WebKit::PluginProxy::getWindowScriptNPObject): (WebKit::PluginProxy::getPluginElementNPObject): (WebKit::PluginProxy::evaluate):
5:03 PM Changeset in webkit [81295] by rniwa@webkit.org
  • 8 edits
    2 adds in trunk

2011-03-16 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Get rid of nearestMailBlockquote
​https://bugs.webkit.org/show_bug.cgi?id=56439

Removed nearestMailBlockquote and replaced the calls to the function by calls
to enclosingNodeOfType and highestEnclosingNodeOfType.


Also fixed a bug in BreakBlockquoteCommand and DeleteSelectionCommand not to
respect editing boundaries. Added a test for the former command.

Test: editing/execCommand/break-non-editable-blockquote.html

  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): No longer crosses editing boundary when looking for a Mail blockquote.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::saveTypingStyleState): Ditto. (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::hasMatchingQuoteLevel): (WebCore::handleStyleSpansBeforeInsertion): (WebCore::ReplaceSelectionCommand::handleStyleSpans): (WebCore::ReplaceSelectionCommand::doApply):
  • editing/htmlediting.cpp: (WebCore::enclosingNodeOfType): Check rule upfront to improve the performance. (WebCore::highestEnclosingNodeOfType): Ditto; also add the missing check.
  • editing/htmlediting.h: (WebCore::firstPositionInOrBeforeNode): Added a null pointer check. (WebCore::lastPositionInOrAfterNode): Ditto.
  • editing/markup.cpp: (WebCore::highestAncestorToWrapMarkup): (WebCore::createMarkup):

2011-03-16 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Get rid of nearestMailBlockquote
​https://bugs.webkit.org/show_bug.cgi?id=56439

Added a test to ensure WebKi doesn't crash when inserting newline in quoted contents,
which is enclosed by a non-editable blockquote.

  • editing/execCommand/break-non-editable-blockquote-expected.txt: Added.
  • editing/execCommand/break-non-editable-blockquote.html: Added.
5:02 PM Changeset in webkit [81294] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-16 Adam Barth <​abarth@webkit.org>

Roll Chromium DEPS.

  • DEPS:
4:56 PM Changeset in webkit [81293] by jamesr@google.com
  • 4 edits
    4 copies in branches/chromium/696

Merge 80867 - 2011-03-11 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Adding a test for rotated large layers.
​https://bugs.webkit.org/show_bug.cgi?id=55984

  • platform/chromium/compositing/huge-layer-rotated-expected.checksum: Added.
  • platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
  • platform/chromium/compositing/huge-layer-rotated-expected.txt: Added.
  • platform/chromium/compositing/huge-layer-rotated.html: Added.

2011-03-11 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Allow large layers with non-identity transforms to be drawn
as long as their visible portion is smaller than the largest supported
texture size. This code will soon be replaced by tiled layers.
​https://bugs.webkit.org/show_bug.cgi?id=55984

Test: platform/chromium/compositing/huge-layer-rotated.html

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::updateContentsIfDirty): (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/ContentLayerChromium.h:

TBR=​vangelis@chromium.org
BUG=64947

4:51 PM Changeset in webkit [81292] by Beth Dakin
  • 2 edits in trunk/Source/WebKit2

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=54987 Crash beneath
WebPageProxy::viewWillStartLiveResize when resizing window after web process
crashed
-and corresponding-
<rdar://problem/9037685>

Reviewed by Darin Adler.

Just need simple isValid() checks here.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeUIClient):
(WebKit::WebPageProxy::viewWillStartLiveResize):
(WebKit::WebPageProxy::viewWillEndLiveResize):

4:48 PM Changeset in webkit [81291] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

2011-03-16 Jer Noble <​jer.noble@apple.com>

Reviewed by Beth Dakin.

RenderFullScreen::createFullScreenStyle() leaks
​https://bugs.webkit.org/show_bug.cgi?id=53384

Two problems: a) not calling release() on the style returned in setFullScreenRenderer
causes an unnecessary ref/deref, and b) the fullscreen renderer needs to be destroyed,
not just detached, when it is no longer needed.

  • dom/Document.cpp: (WebCore::Document::setFullScreenRenderer): Destroy the current renderer when a new one is set.
  • rendering/RenderFullScreen.cpp: (RenderFullScreen::createFullScreenStyle): release() the return value.
4:46 PM Changeset in webkit [81290] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-16 Mike Reed <​reed@google.com>

Reviewed by James Robinson.

Reestablish typeface/size/encoding when drawing stroked text
​https://bugs.webkit.org/show_bug.cgi?id=56481

No new tests. LayoutTests/svg/css/composite-shadow-text.svg

  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::paintSkiaText):
4:37 PM Changeset in webkit [81289] by commit-queue@webkit.org
  • 14 edits in trunk

2011-03-16 Daniel Sievers <​sievers@google.com>

Reviewed by James Robinson.

Add setting to always force compositing mode
​https://bugs.webkit.org/show_bug.cgi?id=56156

No new tests needed as this defaults to disabled (and is unfeasible
to be tested through property overriding at runtime).

  • page/Settings.h: (WebCore::Settings::setForceCompositingMode): (WebCore::Settings::forceCompositingMode):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::RenderLayerCompositor): (WebCore::RenderLayerCompositor::computeCompositingRequirements):
  • rendering/RenderLayerCompositor.h:

2011-03-16 Daniel Sievers <​sievers@google.com>

Reviewed by James Robinson.

Add setting to always force compositing mode
​https://bugs.webkit.org/show_bug.cgi?id=56156

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setForceCompositingMode):
  • src/WebSettingsImpl.h:

2011-03-16 Daniel Sievers <​sievers@google.com>

Reviewed by James Robinson.

Add setting to always force compositing mode
​https://bugs.webkit.org/show_bug.cgi?id=56156

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::resetWebSettings):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::setForceCompositingMode):
  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo):
  • DumpRenderTree/chromium/WebPreferences.h:
4:06 PM Changeset in webkit [81288] by vangelis@chromium.org
  • 3 edits
    4 adds in trunk

2011-03-16 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Adding a new test for transformed layer with backface
visibility set to hidden.
​https://bugs.webkit.org/show_bug.cgi?id=56237

  • platform/chromium/compositing/backface-visibility-transformed-expected.checksum: Added.
  • platform/chromium/compositing/backface-visibility-transformed-expected.png: Added.
  • platform/chromium/compositing/backface-visibility-transformed-expected.txt: Added.
  • platform/chromium/compositing/backface-visibility-transformed.html: Added.

2011-03-16 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Fixing backface visibility for transformed layers.
​https://bugs.webkit.org/show_bug.cgi?id=56237

Test: platform/chromium/compositing/backface-visibility-transformed.html

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayer):
4:01 PM Changeset in webkit [81287] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

2011-03-16 Damian Kaleta <​dkaleta@apple.com>

Reviewed by Kevin Decker.

Add a user default that will force all plugins to opt in to non-executable data
​https://bugs.webkit.org/show_bug.cgi?id=56487
<rdar://problem/9109095>

  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::PluginProcessProxy):
  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm: (WebKit::PluginProcessProxy::pluginNeedsExecutableHeap):
3:57 PM Changeset in webkit [81286] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Skip fast/js/array-sort-modifying-tostring.html on Windows because it is timing out
on Windows Debug. It is being tracked by ​https://bugs.webkit.org/show_bug.cgi?id=56496.

  • platform/win/Skipped:
3:20 PM Changeset in webkit [81285] by Dimitri Glazkov
  • 3 edits
    4 adds in trunk

2011-03-16 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r76147): Dragging slider thumb is impossible or results in drawing artifacts.
​https://bugs.webkit.org/show_bug.cgi?id=56469

Note: the test should pass on all platforms, because it was designed to not use
platform-specific metrics

  • fast/repaint/slider-thumb-float-expected.checksum: Added.
  • fast/repaint/slider-thumb-float-expected.png: Added.
  • fast/repaint/slider-thumb-float-expected.txt: Added.
  • fast/repaint/slider-thumb-float.html: Added.

2011-03-16 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r76147): Dragging slider thumb is impossible or results in drawing artifacts.
​https://bugs.webkit.org/show_bug.cgi?id=56469

Technically, this is not a regression, but rather uncovering of an old
problem. When the RenderSlider::layout was written, the layout state was
pushed with a wrong offset. However, since the whole slider track was
always repainted, the problem didn't manifest itself until we actually
started being more precise in our repaints.

Test: fast/repaint/slider-thumb-float.html

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::layout): Changed to pass actual thumb offset to the LayoutStateMaintainer, rather than thumb size.
3:18 PM Changeset in webkit [81284] by dino@apple.com
  • 4 edits in trunk/LayoutTests

2011-03-16 Dean Jackson <​dino@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=56488
transitions/scale-transition-no-start.html is crashing.

Adding to the Skipped list.

  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/win/Skipped:
3:15 PM Changeset in webkit [81283] by Dimitri Glazkov
  • 4 edits in trunk/Source/WebCore

2011-03-16 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Carlson.

Add play state callbacks to MediaControls, kill timeUpdate timer.
​https://bugs.webkit.org/show_bug.cgi?id=56473

No change in behavior, covered by existing tests.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::playbackProgressTimerFired): Added a call to

media controls.

(WebCore::HTMLMediaElement::updatePlayState): Ditto.

  • html/shadow/MediaControls.cpp: (WebCore::MediaControls::MediaControls): Removed initialization of the timer. (WebCore::MediaControls::playbackProgressed): Added. (WebCore::MediaControls::playbackStarted): Added, for now routing to just

call playbackProgressed.

(WebCore::MediaControls::playbackStopped): Ditto.
(WebCore::MediaControls::update): Removed the code to start/stop the

timer that's now gone.

  • html/shadow/MediaControls.h: Removed timer decls.
3:06 PM Changeset in webkit [81282] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-16 Bill Budge <​bbudge@chromium.org>

Reviewed by David Levin.

DocumentThreadableLoaderClient needs a protected default Constructor
​https://bugs.webkit.org/show_bug.cgi?id=56479

No new tests. Exposes no new functionality.

  • loader/DocumentThreadableLoaderClient.h: (WebCore::DocumentThreadableLoaderClient::DocumentThreadableLoaderClient):
2:59 PM Changeset in webkit [81281] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Chromium Leopard build fix attempt #2.

Same error as before.

  • bindings/v8/V8GCController.cpp:
2:47 PM Changeset in webkit [81280] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-03-16 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Carlson.

Improve robustness of controls-without-preload by seeking to the start explicitly at the end of the test.
​https://bugs.webkit.org/show_bug.cgi?id=56489

  • media/controls-without-preload.html: Added an extra step to seek to 0 before the end of the test.
2:22 PM Changeset in webkit [81279] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-03-16 Sreeram Ramachandran <​sreeram@google.com>

Reviewed by Dimitri Glazkov.

Revert of r80451. Decided to do this in WebCore instead.
​https://bugs.webkit.org/show_bug.cgi?id=55844

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:
2:16 PM Changeset in webkit [81278] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Chromium Leopard build fix attempt.

The error was 'WebCore::GrouperVisitor' has a field 'WebCore::GrouperVisitor::m_grouper' whose type uses the anonymous namespace.

  • bindings/v8/V8GCController.cpp:
2:08 PM Changeset in webkit [81277] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-16 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Dimitri Glazkov and Darin Adler.

Node::isContentEditable should always call parentNode() instead of parentOrHostNode()
​https://bugs.webkit.org/show_bug.cgi?id=56472

Replaced the call to parentOrHostNode() in Node::isContentEditable by a call to parentNode().
Node::isContentEditable now calls parentNode() on all nodes.

No tests are added since this behavior change is not visible to scripts at the moment.

  • dom/Node.cpp: (WebCore::Node::isContentEditable):
2:05 PM Changeset in webkit [81276] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-03-16 Oliver Hunt <​oliver@apple.com>

Reviewed by Darin Adler.

Remove unnecessary caller tracking shenanigans from CodeBlock
​https://bugs.webkit.org/show_bug.cgi?id=56483

This removes some leftover cruft from when we made CodeBlock
mark its callees. Removing it gives us a 0.7% progression,
reducing the overall regression to ~1.3%.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::shrinkToFit):
  • bytecode/CodeBlock.h: (JSC::CallLinkInfo::CallLinkInfo):
  • jit/JIT.cpp: (JSC::JIT::linkCall): (JSC::JIT::linkConstruct):
2:04 PM Changeset in webkit [81275] by levin@chromium.org
  • 2 edits
    76 adds in trunk/LayoutTests

o Cleaned up test_expectation to remove items due to new baselines

and remove some crashes that have been fixed.

o text-combine: Added baseline following r81251.
o Everything else: Add some not so timely baselines for r77485.

  • platform/chromium-linux/fast/dynamic/text-combine-expected.checksum: Added.
  • platform/chromium-linux/fast/dynamic/text-combine-expected.png: Added.
  • platform/chromium-linux/fast/dynamic/text-combine-expected.txt: Added.
  • platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.checksum: Added.
  • platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png: Added.
  • platform/chromium-mac/fast/dynamic/text-combine-expected.checksum: Added.
  • platform/chromium-mac/fast/dynamic/text-combine-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Added.
  • platform/chromium-mac/svg/carto.net/scrollbar-expected.checksum: Added.
  • platform/chromium-mac/svg/carto.net/scrollbar-expected.png: Added.
  • platform/chromium-mac/svg/carto.net/selectionlist-expected.checksum: Added.
  • platform/chromium-mac/svg/carto.net/selectionlist-expected.png: Added.
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.png: Added.
  • platform/chromium-mac/svg/text/selection-doubleclick-expected.checksum: Added.
  • platform/chromium-mac/svg/text/selection-doubleclick-expected.png: Added.
  • platform/chromium-mac/svg/text/selection-tripleclick-expected.checksum: Added.
  • platform/chromium-mac/svg/text/selection-tripleclick-expected.png: Added.
  • platform/chromium-mac/svg/text/text-align-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-align-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-align-02-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-align-02-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-align-03-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-align-03-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-align-05-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-align-05-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-align-06-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-align-06-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-altglyph-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-altglyph-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-deco-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-deco-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-fonts-01-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-fonts-01-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-fonts-02-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-fonts-02-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-path-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-path-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-spacing-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-spacing-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-text-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-03-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-text-03-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-04-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-text-04-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-05-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-text-05-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-06-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-text-06-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-07-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-text-07-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-08-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-text-08-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-tref-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-tref-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-tselect-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-tselect-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-tselect-02-f-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-tselect-02-f-expected.png: Added.
  • platform/chromium-mac/svg/text/text-tspan-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-tspan-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-ws-01-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-ws-01-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-ws-02-t-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-ws-02-t-expected.png: Added.
  • platform/chromium-mac/svg/text/textPathBoundsBug-expected.checksum: Added.
  • platform/chromium-mac/svg/text/textPathBoundsBug-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/color-correction-on-box-shadow-expected.checksum:
  • platform/chromium-mac-leopard/fast/css/color-correction-on-box-shadow-expected.png:
  • platform/chromium-win/fast/dynamic/text-combine-expected.checksum: Added.
  • platform/chromium-win/fast/dynamic/text-combine-expected.png: Added.
  • platform/chromium-win/fast/dynamic/text-combine-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:01 PM Changeset in webkit [81274] by Chris Fleizach
  • 14 edits in trunk/Source

WK2: Need to propagate enhanced accessibility flag from UI -> web process
​https://bugs.webkit.org/show_bug.cgi?id=56379

Reviewed by Darin Adler.

Source/WebCore:

Allow the enhanced accessibility flag to be toggleable.

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility):

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame accessibilityRoot]):

Source/WebKit2:

Support sending the enhanced accessibility flag between processes.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::~WebContext):
(WebKit::WebContext::setEnhancedAccessibility):

  • UIProcess/WebContext.h:
  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContet::platformInvalidateContext):

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):
(WebKit::WebContext::platformInvalidateContext):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformInvalidateContext):

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformInvalidateContext):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setEnhancedAccessibility):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
1:12 PM Changeset in webkit [81273] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt] Buildfix after r81230.

  • WebCore.pri: Missing include path added.
1:09 PM Changeset in webkit [81272] by oliver@apple.com
  • 100 edits in trunk/Source

2011-03-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make Structure creation require a JSGlobalData
​https://bugs.webkit.org/show_bug.cgi?id=56438

Mechanical change to make Structure::create require JSGlobalData&, and
require all users to provide the globalData.

  • API/JSCallbackConstructor.h: (JSC::JSCallbackConstructor::createStructure):
  • API/JSCallbackFunction.h: (JSC::JSCallbackFunction::createStructure):
  • API/JSCallbackObject.h: (JSC::JSCallbackObject::createStructure):
  • API/JSContextRef.cpp:
  • JavaScriptCore.exp:
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::DebuggerActivation):
  • debugger/DebuggerActivation.h: (JSC::DebuggerActivation::createStructure):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • jsc.cpp: (GlobalObject::GlobalObject): (functionRun): (jscmain):
  • runtime/Arguments.h: (JSC::Arguments::createStructure):
  • runtime/ArrayPrototype.h: (JSC::ArrayPrototype::createStructure):
  • runtime/BooleanObject.h: (JSC::BooleanObject::createStructure):
  • runtime/DateInstance.h: (JSC::DateInstance::createStructure):
  • runtime/DatePrototype.h: (JSC::DatePrototype::createStructure):
  • runtime/ErrorInstance.h: (JSC::ErrorInstance::createStructure):
  • runtime/Executable.h: (JSC::ExecutableBase::createStructure): (JSC::EvalExecutable::createStructure): (JSC::ProgramExecutable::createStructure): (JSC::FunctionExecutable::createStructure):
  • runtime/FunctionPrototype.h: (JSC::FunctionPrototype::createStructure):
  • runtime/GetterSetter.h: (JSC::GetterSetter::createStructure):
  • runtime/InternalFunction.h: (JSC::InternalFunction::createStructure):
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure):
  • runtime/JSActivation.h: (JSC::JSActivation::createStructure):
  • runtime/JSArray.cpp: (JSC::JSArray::JSArray):
  • runtime/JSArray.h: (JSC::JSArray::createStructure):
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::createStructure):
  • runtime/JSByteArray.h: (JSC::JSByteArray::JSByteArray):
  • runtime/JSCell.h: (JSC::JSCell::JSCell::createDummyStructure):
  • runtime/JSFunction.h: (JSC::JSFunction::createStructure):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::storeVPtrs): (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObject): (JSC::JSGlobalObject::createStructure):
  • runtime/JSNotAnObject.h: (JSC::JSNotAnObject::createStructure):
  • runtime/JSONObject.h: (JSC::JSONObject::createStructure):
  • runtime/JSObject.cpp: (JSC::JSObject::createInheritorID):
  • runtime/JSObject.h: (JSC::JSObject::createStructure): (JSC::JSNonFinalObject::createStructure): (JSC::JSFinalObject::createStructure): (JSC::createEmptyObjectStructure): (JSC::JSObject::inheritorID):
  • runtime/JSObjectWithGlobalObject.h: (JSC::JSObjectWithGlobalObject::createStructure):
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::createStructure):
  • runtime/JSStaticScopeObject.h: (JSC::JSStaticScopeObject::createStructure):
  • runtime/JSString.h: (JSC::RopeBuilder::createStructure):
  • runtime/JSVariableObject.h: (JSC::JSVariableObject::createStructure):
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::createStructure):
  • runtime/JSZombie.h: (JSC::JSZombie::createStructure):
  • runtime/MathObject.h: (JSC::MathObject::createStructure):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor):
  • runtime/NativeErrorConstructor.h: (JSC::NativeErrorConstructor::createStructure):
  • runtime/NumberConstructor.h: (JSC::NumberConstructor::createStructure):
  • runtime/NumberObject.h: (JSC::NumberObject::createStructure):
  • runtime/ObjectConstructor.h: (JSC::ObjectConstructor::createStructure):
  • runtime/RegExpConstructor.h: (JSC::RegExpConstructor::createStructure):
  • runtime/RegExpObject.h: (JSC::RegExpObject::createStructure):
  • runtime/ScopeChain.h: (JSC::ScopeChainNode::createStructure):
  • runtime/StringObject.h: (JSC::StringObject::createStructure):
  • runtime/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
  • runtime/StringPrototype.h: (JSC::StringPrototype::createStructure):
  • runtime/Structure.h: (JSC::Structure::create):

2011-03-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make Structure creation require a JSGlobalData
​https://bugs.webkit.org/show_bug.cgi?id=56438

Mechanical change to make all structure creation pass a JSGlobalData&.

  • JSRun.cpp: (JSGlueGlobalObject::JSGlueGlobalObject): (JSRun::JSRun):
  • JSRun.h:
  • JSUtils.cpp: (getThreadGlobalObject):
  • UserObjectImp.h: (UserObjectImp::createStructure):

2011-03-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make Structure creation require a JSGlobalData
​https://bugs.webkit.org/show_bug.cgi?id=56438

Mechanical change to make all structure creation use GlobalData

  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSAudioConstructor.h: (WebCore::JSAudioConstructor::createStructure):
  • bindings/js/JSDOMBinding.h: (WebCore::DOMObjectWithGlobalPointer::createStructure): (WebCore::DOMConstructorObject::createStructure): (WebCore::getDOMStructure):
  • bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::createStructure):
  • bindings/js/JSDOMWindowBase.h: (WebCore::JSDOMWindowBase::createStructure):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::createStructure):
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSImageConstructor.h: (WebCore::JSImageConstructor::createStructure):
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSOptionConstructor.h: (WebCore::JSOptionConstructor::createStructure):
  • bindings/js/JSWorkerContextBase.h: (WebCore::JSWorkerContextBase::createStructure):
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::initScript):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/c/CRuntimeObject.h: (JSC::Bindings::CRuntimeObject::createStructure):
  • bridge/c/c_instance.cpp: (JSC::Bindings::CRuntimeMethod::createStructure):
  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaRuntimeMethod::createStructure):
  • bridge/jni/jsc/JavaRuntimeObject.h: (JSC::Bindings::JavaRuntimeObject::createStructure):
  • bridge/objc/ObjCRuntimeObject.h: (JSC::Bindings::ObjCRuntimeObject::createStructure):
  • bridge/objc/objc_instance.mm: (ObjCRuntimeMethod::createStructure):
  • bridge/objc/objc_runtime.h: (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
  • bridge/runtime_array.h: (JSC::RuntimeArray::createStructure):
  • bridge/runtime_method.h: (JSC::RuntimeMethod::createStructure):
  • bridge/runtime_object.h: (JSC::Bindings::RuntimeObject::createStructure):

2011-03-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make Structure creation require a JSGlobalData
​https://bugs.webkit.org/show_bug.cgi?id=56438

Mechanical change to make all Structure creation use a JSGlobalData&

  • Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyRuntimeMethod::createStructure):
  • Plugins/Hosted/ProxyRuntimeObject.h: (WebKit::ProxyRuntimeObject::createStructure):

2011-03-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make Structure creation require a JSGlobalData
​https://bugs.webkit.org/show_bug.cgi?id=56438

Mechanical change to make all Structure creation use a JSGlobalData&.

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp: (WebKit::JSNPMethod::JSNPMethod):
  • WebProcess/Plugins/Netscape/JSNPMethod.h: (WebKit::JSNPMethod::createStructure):
  • WebProcess/Plugins/Netscape/JSNPObject.cpp: (WebKit::JSNPObject::JSNPObject):
  • WebProcess/Plugins/Netscape/JSNPObject.h: (WebKit::JSNPObject::createStructure):
12:54 PM Changeset in webkit [81271] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Skip plugins/refcount-leaks.html on Windows, because it is failing in release builds,
and passing in debug. This is being tracked by ​https://bugs.webkit.org/show_bug.cgi?id=56478.

  • platform/win/Skipped:
12:52 PM Changeset in webkit [81270] by rniwa@webkit.org
  • 1 edit
    3 moves in trunk/LayoutTests

2011-03-16 Ryosuke Niwa <​rniwa@webkit.org>

Build fix for r81266. "expected" should appear after "mac", "unix", and "win" not before them.

  • editing/style/iframe-onload-crash-expected-mac.txt: Removed.
  • editing/style/iframe-onload-crash-expected-unix.txt: Removed.
  • editing/style/iframe-onload-crash-expected-win.txt: Removed.
  • editing/style/iframe-onload-crash-mac-expected.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected-mac.txt.
  • editing/style/iframe-onload-crash-unix-expected.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected-unix.txt.
  • editing/style/iframe-onload-crash-win-expected.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected-win.txt.
12:49 PM Changeset in webkit [81269] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Dan Bernstein.

WebKit2: Sometimes Command-[ opens a new tab and loads the back page in it
​https://bugs.webkit.org/show_bug.cgi?id=56477
<rdar://problem/8806664>

  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::doneWithKeyEvent): Set NSApplication current event when re-dispatching a key event that returned from the web process unhandled. That way, code that looks at current event modifiers won't be confused.
12:47 PM Changeset in webkit [81268] by psolanki@apple.com
  • 2 edits in trunk/LayoutTests

Fix typo in path name. The test was just checking for onProgress was called for the content
and the error page served by Apache in this case sufficed for it to pass.

Reviewed by Alexey Proskuryakov.

  • http/tests/xmlhttprequest/xmlhttprequest-no-content-length-onProgress.html:
12:28 PM Changeset in webkit [81267] by psolanki@apple.com
  • 4 edits
    3 adds in trunk

2011-03-16 Pratik Solanki <​psolanki@apple.com>

Reviewed by Alexey Proskuryakov.

REGRESSION: Crash in adjustMIMETypeIfNecessary since r81001
​https://bugs.webkit.org/show_bug.cgi?id=56345

Add test that verifies the we don't crash when an XHR response headers don't contain
Content-Type.

  • http/tests/xmlhttprequest/resources/.htaccess:
  • http/tests/xmlhttprequest/resources/noContentType.asis: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-no-content-type-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-no-content-type.html: Added.

2011-03-16 Pratik Solanki <​psolanki@apple.com>

Reviewed by Alexey Proskuryakov.

REGRESSION: Crash in adjustMIMETypeIfNecessary since r81001
​https://bugs.webkit.org/show_bug.cgi?id=56345

Add NULL check for Content-Type header field.

Test: http/tests/xmlhttprequest/xmlhttprequest-no-content-type.html

  • platform/network/mac/WebCoreURLResponse.mm: (WebCore::adjustMIMETypeIfNecessary):
12:18 PM Changeset in webkit [81266] by leviw@chromium.org
  • 7 edits
    4 copies
    2 moves in trunk

2011-03-16 Levi Weintraub <​leviw@chromium.org>

Reviewed by Ryosuke Niwa.

REGRESSION (r81165): Assert running editing/style/iframe-onload-crash.html with non-Mac editing behavior
​https://bugs.webkit.org/show_bug.cgi?id=56407

Creating three versions of the iframe-onload-crash test to cover all editing behaviors.

  • editing/style/iframe-onload-crash-expected-mac.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected.txt.
  • editing/style/iframe-onload-crash-expected-unix.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected.txt.
  • editing/style/iframe-onload-crash-expected-win.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected.txt.
  • editing/style/iframe-onload-crash-expected.txt: Removed.
  • editing/style/iframe-onload-crash-mac.html: Copied from LayoutTests/editing/style/iframe-onload-crash.html.
  • editing/style/iframe-onload-crash-unix.html: Copied from LayoutTests/editing/style/iframe-onload-crash.html.
  • editing/style/iframe-onload-crash-win.html: Copied from LayoutTests/editing/style/iframe-onload-crash.html.
  • editing/style/iframe-onload-crash.html: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/win/Skipped:

2011-03-15 Levi Weintraub <​leviw@chromium.org>

Reviewed by Ryosuke Niwa.

REGRESSION (r81165): Assert running editing/style/iframe-onload-crash.html with non-Mac editing behavior
​https://bugs.webkit.org/show_bug.cgi?id=56407

Fixing the creation of incorrect ranges from TextIterator due to passing node/offset pairs that
weren't parent-anchored. Also changing canHaveChildrenForEditing to properly handle nodes that
have had children appended to them that editing wouldn't normally allow.

Tests: editing/style/iframe-onload-crash-mac.html

editing/style/iframe-onload-crash-unix.html
editing/style/iframe-onload-crash-win.html

  • editing/TextIterator.cpp: (WebCore::TextIterator::rangeFromLocationAndLength): Passing parent-anchored values to range.
  • editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing): Adding a condition that the nodes don't already have children for hr and datagrid, as you can append any node to another using javascript.
11:46 AM Changeset in webkit [81265] by mnaganov@chromium.org
  • 15 edits
    3 copies in trunk/Source/WebCore

2011-03-16 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Report object groups and single DOM-related objects
to the new heap profiler.
​https://bugs.webkit.org/show_bug.cgi?id=53659

  • Android.v8bindings.mk:
  • WebCore.gypi:
  • WebCore.pro:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/RetainedDOMInfo.cpp: Added. (WebCore::RetainedDOMInfo::RetainedDOMInfo):
  • bindings/v8/RetainedDOMInfo.h: Added.
  • bindings/v8/RetainedObjectInfo.h: Added.
  • bindings/v8/ScriptProfiler.cpp: (WebCore::retainedDOMInfo): (WebCore::ScriptProfiler::initialize):
  • bindings/v8/ScriptProfiler.h:
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::initContextIfNeeded):
  • bindings/v8/V8GCController.cpp: (WebCore::GroupId::GrouperItem::GrouperItem): (WebCore::GroupId::GrouperItem::groupId): (WebCore::GroupId::GrouperItem::createRetainedObjectInfo): (WebCore::calculateGroupId): (WebCore::GrouperVisitor::visitDOMWrapper): (WebCore::GrouperVisitor::applyGrouping):
  • bindings/v8/WrapperTypeInfo.h:
  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotConstructorNode): (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider): (WebInspector.HeapSnapshotDiffNode): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider): (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotRetainingPathsList.prototype.setDataSource): (WebInspector.HeapSnapshotRetainingPathsList.prototype.refresh): (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.startSearching): (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext): (WebInspector.HeapSnapshotRetainingPathsList.prototype._setRootChildrenForFinder): (WebInspector.DetailedHeapshotView.prototype._changeRetainingPathsRoot): (WebInspector.DetailedHeapshotView.prototype.get isTracingToWindowObjects):
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotNode.prototype.get className): (WebInspector.HeapSnapshot.prototype._buildAggregates): (WebInspector.HeapSnapshotPathFinder.prototype.updateRoots): (WebInspector.HeapSnapshotPathFinder.prototype._fillRootChildren):
  • inspector/front-end/heapProfiler.css: (.detailed-heapshot-view .retaining-paths-view .title > span): (.detailed-heapshot-view .retaining-paths-to-windows):
11:43 AM Changeset in webkit [81264] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Skip test fast/forms/input-autofilled.html in mac-wk2 since
layoutTestController.setAutofilled is not yet supported.

  • platform/mac-wk2/Skipped:
11:37 AM Changeset in webkit [81263] by weinig@apple.com
  • 12 edits in trunk/Source

Add WebKit2 API to figure out if an input or textarea was edited
​https://bugs.webkit.org/show_bug.cgi?id=56474

Reviewed by Adam Roben.

Source/WebCore:

Add HTMLInputElement::lastChangeWasUserEdit and HTMLTextAreaElement::lastChangeWasUserEdit
and use them to implement -[DOMHTMLInputElement _isEdited] and -[DOMHTMLTextAreaElement _isEdited]
as well as API in WebKit2.

  • WebCore.exp.in:
  • bindings/objc/DOMHTML.mm:

(-[DOMHTMLInputElement _isEdited]):
(-[DOMHTMLTextAreaElement _isEdited]):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::lastChangeWasUserEdit):

  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::lastChangeWasUserEdit):

  • html/HTMLTextAreaElement.h:

Source/WebKit2:

Expose WKBundleNodeHandleGetHTMLInputElementLastChangeWasUserEdit and
WKBundleNodeHandleGetHTMLTextAreaElementLastChangeWasUserEdit. Next time,
I will work on giving these functions longer names.

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleGetHTMLInputElementLastChangeWasUserEdit):
(WKBundleNodeHandleGetHTMLTextAreaElementLastChangeWasUserEdit):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::htmlInputElementLastChangeWasUserEdit):
(WebKit::InjectedBundleNodeHandle::htmlTextAreaElementLastChangeWasUserEdit):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
11:35 AM Changeset in webkit [81262] by ggaren@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

2011-03-16 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Some conservative root gathering cleanup
​https://bugs.webkit.org/show_bug.cgi?id=56447


SunSpider says 0.5% - 1.8% faster.

  • interpreter/RegisterFile.cpp: (JSC::RegisterFile::gatherConservativeRoots):
  • interpreter/RegisterFile.h: New helper function for doing the conservative gathering of the register file. It's still conservative, since the register file may contain uninitialized values, but it's moving-safe, because it only visits values tagged as pointers, so there's no risk of mistaking an integer for a pointer and accidentally changing it.
  • runtime/ConservativeSet.cpp: (JSC::ConservativeRoots::add):
  • runtime/ConservativeSet.h: Added a single-value add function, used above.
  • runtime/Heap.cpp: (JSC::Heap::markRoots): Separated machine stack conservative roots from register file conservative roots because machine stack roots must be pinned, but register file roots need not be pinned.


Adopted new interface for passing the current stack extent to the machine
stack root gathering routine. This allows us to exclude marking-related
data structures on the stack, and thus avoid double-marking the set of
machine roots.

  • runtime/MachineStackMarker.cpp: (JSC::MachineThreads::gatherFromCurrentThread): (JSC::MachineThreads::gatherConservativeRoots):
  • runtime/MachineStackMarker.h: Added new interface, described above.
  • runtime/MarkedBlock.h: (JSC::MarkedBlock::firstAtom):
  • wtf/StdLibExtras.h: (WTF::roundUpToMultipleOf): Moved roundUpToMultipleOf so it could be used by MachineStacks.
11:16 AM Changeset in webkit [81261] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-03-16 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

A little bit of MarkStack cleanup
​https://bugs.webkit.org/show_bug.cgi?id=56443


Moved MarkStack functions into MarkStack.h/.cpp.


SunSpider reports no change.

  • runtime/JSArray.h:
  • runtime/JSCell.h: Moved from here...
  • runtime/MarkStack.cpp: (JSC::MarkStack::markChildren): (JSC::MarkStack::drain): ...to here. Also, no need to inline drain. It's a huge function, and not called many times.
  • runtime/MarkStack.h: (JSC::MarkStack::~MarkStack): Moved near constructor, per style guide. (JSC::MarkStack::append): (JSC::MarkStack::deprecatedAppend): (JSC::MarkStack::internalAppend): Moved to here.
11:07 AM Changeset in webkit [81260] by bweinstein@apple.com
  • 2 edits
    2 adds
    1 delete in trunk/LayoutTests

More cleanup of expected results files for text combine tests from r81255.

  • platform/win/fast/dynamic/text-combine-expected.checksum: Added.
  • platform/win/fast/dynamic/text-combine-expected.png: Added.
  • platform/win/fast/text/international/text-combine-image-test-expected.txt:


  • platform/win/fast/international: Removed. This was the wrong directory.
  • platform/win/fast/international/text-combine-image-test-expected.txt: Removed. This was the wrong directory.
11:01 AM Changeset in webkit [81259] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-15 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key)
​https://bugs.webkit.org/show_bug.cgi?id=56376

  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype._setDocument):
10:58 AM Changeset in webkit [81258] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-16 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, fix live-edit test broken by r81238.

  • inspector/debugger/live-edit.html:
10:58 AM Changeset in webkit [81257] by xji@chromium.org
  • 6 edits in branches/chromium/696/Source/WebCore

Merge 80757 - Regression: Content not drawn when scrolling horizontally in an RTL page
​https://bugs.webkit.org/show_bug.cgi?id=55077

Reviewed by David Hyatt.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::calculateOverhangAreasForPainting):
Take the scroll origin into account when calculating overhang.

  • platform/ScrollView.h:
  • rendering/RenderLayer.h:
  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollOrigin):
Move identical scroll origin member from ScrollView and RenderLayer
to shared base ScrollableArea. This is also needed so that the animator
can access it.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::pinnedInDirection):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
Account for a scroll origin when doing calculating scroll offsets.

TBR=​weinig@apple.com

10:47 AM Changeset in webkit [81256] by bweinstein@apple.com
  • 1 edit
    2 moves in trunk/LayoutTests

Make the files added -expected.txt instead of -actual.txt so run-webkit-tests
will actually find them.

  • platform/win/fast/dynamic/text-combine-actual.txt: Removed.
  • platform/win/fast/dynamic/text-combine-expected.txt: Copied from platform/win/fast/dynamic/text-combine-actual.txt.
  • platform/win/fast/international/text-combine-image-test-actual.txt: Removed.
  • platform/win/fast/international/text-combine-image-test-expected.txt: Copied from platform/win/fast/international/text-combine-image-test-actual.txt.
10:44 AM Changeset in webkit [81255] by bweinstein@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Add Windows-specific results for text combine tests.

  • platform/win/fast/dynamic/text-combine-actual.txt: Added.
  • platform/win/fast/international: Added.
  • platform/win/fast/international/text-combine-image-test-actual.txt: Added.
10:22 AM Changeset in webkit [81254] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Add failing tests to the Skipped list because of missing test fonts.

  • platform/qt/Skipped:
9:52 AM Changeset in webkit [81253] by Csaba Osztrogonác
  • 2 edits
    27 adds in trunk/LayoutTests

REGRESSION (r68976): Incorrect bidi rendering in SVG text
​https://bugs.webkit.org/show_bug.cgi?id=53980

Add Qt specific expected files after r81168.

  • platform/qt/Skipped: Add new tests because of missing test fonts.
  • platform/qt/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Added.
9:38 AM Changeset in webkit [81252] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=56467
IconDatabase-related crash seen in WK2 tests

Reviewed by Adam Roben.

  • WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:

(WebKit::WebIconDatabaseProxy::setIconDataForIconURL): The IconLoader might set a null data for an icon, so handle that case.

9:27 AM Changeset in webkit [81251] by mitz@apple.com
  • 5 edits
    4 adds in trunk

text-combine text retains compressed font after adding characters to it
​https://bugs.webkit.org/show_bug.cgi?id=56448

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/dynamic/text-combine.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Allow styles with text-combine to be shared, since
only the clones on the RenderCombineText will be mutated.

  • rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange): Clone the style, to avoid mutating the parent’s
style.
(WebCore::RenderCombineText::combineText): Start off with the original font; restore it if
the text cannot be combined.

  • rendering/RenderCombineText.h:

(WebCore::RenderCombineText::originalFont): Added. Returns the parent’s font.

LayoutTests:

  • fast/dynamic/text-combine.html: Added.
  • platform/mac/fast/dynamic/text-combine-expected.checksum: Added.
  • platform/mac/fast/dynamic/text-combine-expected.png: Added.
  • platform/mac/fast/dynamic/text-combine-expected.txt: Added.
9:25 AM Changeset in webkit [81250] by Adam Roben
  • 3 edits
    1 move in trunk/LayoutTests

Disable jquery/effects.html

It often times out due to its sheer size. The failure is tracked by
<​http://webkit.org/b/56080>.

  • jquery/effects.html-disabled: Renamed from LayoutTests/jquery/effects.html.
  • platform/gtk/Skipped:
  • platform/win-xp/Skipped:

Unskipped the test since we're now disabling it via other means.

9:06 AM Changeset in webkit [81249] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-16 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skipping one more svg test failing on 32-bits release,
likely due to bug 39022.

  • platform/gtk/Skipped:
8:49 AM Changeset in webkit [81248] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] fast/text/soft-hyphen-4.html introduced in r80984
and fails because hyphenation isn't implemented yet.

  • platform/qt/Skipped: Add fast/text/soft-hyphen-4.html.
8:47 AM Changeset in webkit [81247] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-16 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip svg/W3C-I18N tests failing on 32-bits Debug only.

  • platform/gtk/Skipped:
8:41 AM Changeset in webkit [81246] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-16 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip editing/style/iframe-onload-crash.html on GTK.

  • platform/gtk/Skipped:
8:34 AM Changeset in webkit [81245] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Update Qt specific expected file after r81049.

  • platform/qt/fast/table/overflowHidden-expected.txt: Updated.
8:24 AM Changeset in webkit [81244] by podivilov@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-16 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, fix test broken by r81238.

  • inspector/debugger/live-edit.html:
  • platform/chromium/test_expectations.txt:
8:03 AM Changeset in webkit [81243] by podivilov@chromium.org
  • 16 edits
    2 adds in trunk

2011-03-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor event listener breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=56305

  • inspector/debugger/event-listener-breakpoints-expected.txt: Added.
  • inspector/debugger/event-listener-breakpoints.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: refactor event listener breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=56305

  • restore event listener breakpoints one by one instead of using setAllBrowserBreakpoints
  • store event listener breakpoints in a separate separate setting
  • move presentation-related code from BreakpointManager to EventListenerBreakpointsSidebarPane

Test: inspector/debugger/event-listener-breakpoints.html

  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::setFrontend):
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::clear):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didCommitLoadImpl):
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.setEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype.removeEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._saveBreakpoints): (WebInspector.BreakpointManager.prototype._validateBreakpoints): (WebInspector.BreakpointManager.prototype._createDOMBreakpointId):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.eventNameForUI): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._categoryCheckboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointCheckboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._updateCategoryCheckbox): (WebInspector.EventListenerBreakpointsSidebarPane.prototype.highlightBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane.prototype.clearBreakpointHighlight): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._saveBreakpoints): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._restoreBreakpoints):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype.setStatus): (WebInspector.CallStackSidebarPane.prototype._domBreakpointHit):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearInterface):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
8:00 AM Changeset in webkit [81242] by ddkilzer@apple.com
  • 3 edits in trunk/Source/WebCore

Minor clean-up after r81156, r81172

Follow-up for:
<​http://webkit.org/b/56381> Objective-C classes should be typedef-ed as structs (not void*) in C++

  • platform/graphics/GraphicsLayer.h: Removed unused @class

WebLayer declaration.

  • platform/graphics/ca/PlatformCAAnimation.h: Changed typedef

struct CAPropertyAnimation to class declaration.

7:49 AM Changeset in webkit [81241] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-16 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, update expectations.
Fix Linux Debug expectation clash for transitions/interrupted-accelerated-transition.html.
Let svg/text/font-size-below-point-five.svg fail on Mac Release.

  • platform/chromium/test_expectations.txt:
6:13 AM Changeset in webkit [81240] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-16 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, remove duplicate expectations.

  • platform/chromium/test_expectations.txt:
5:11 AM Changeset in webkit [81239] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt]Web Inspector: inspector/elements/mutate-unknown-node.html fails
​https://bugs.webkit.org/show_bug.cgi?id=56457

  • platform/qt/Skipped: Add inspector/elements/mutate-unknown-node.html.
4:48 AM Changeset in webkit [81238] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-03-16 Andrey Adaikin <​aandrey@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: Remove live-edit code
​https://bugs.webkit.org/show_bug.cgi?id=56177

  • inspector/front-end/Settings.js:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype._doubleClick):
  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorMainPanel): (WebInspector.TextEditorMainPanel.prototype.set readOnly):
4:21 AM Changeset in webkit [81237] by benjamin.poulain@nokia.com
  • 4 edits
    3 adds in trunk/Source/WebKit2

2011-03-16 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Loading an empty URL crashes
​https://bugs.webkit.org/show_bug.cgi?id=55501

A null WKURLRef is created in the API of WebKit 2 when converting a null string. The code
of WKPageLoadURL assume the WKPageRef is not null which causes crashes if it is.

This patch uses the converter toWTFString() to pass from WKPageRef to WTFString. This converter
ensure the returned string is a valid null string.

Tested through the Qt API tests.

  • UIProcess/API/C/WKPage.cpp: (WKPageLoadURL):
  • UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp: (tst_QGraphicsWKView::loadEmptyUrl):
  • UIProcess/API/qt/tests/qwkpage/qwkpage.pro: Added.
  • UIProcess/API/qt/tests/qwkpage/tst_qwkpage.cpp: Added. (tst_QWKPage::init): (tst_QWKPage::cleanup): (tst_QWKPage::loadEmptyUrl):
  • UIProcess/API/qt/tests/tests.pro:
4:09 AM Changeset in webkit [81236] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Typo fix after r81226.

  • platform/qt/Skipped: Remove unnecessary "#".
4:05 AM Changeset in webkit [81235] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-16 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, suppress Win builder failures from r81222.
Also, one tentatively stale suppression is removed.

  • platform/chromium/test_expectations.txt:
3:40 AM Changeset in webkit [81234] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-16 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Martin Robinson.

[GStreamer] There is no need to set the state of the pipeline to playing, HTMLMediaElement will do it.
​https://bugs.webkit.org/show_bug.cgi?id=56403

In case of a seek on a live pipeline there is no need to call gst_element_set_state(m_playBin, GST_STATE_PLAYING);
As soon as HTMLMediaElement::updatePlayState() is called (like when the data comes in) the playback will be relaunched
i.e the pause() made when beginScrubbing is done is just internal.

No new tests: Verified manually.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::updateStates):
3:39 AM Changeset in webkit [81233] by dino@apple.com
  • 4 edits in trunk/LayoutTests

2011-03-16 Dean Jackson <​dino@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=56242
Flaky Test: transitions/interrupted-accelerated-transition.html

Skip this while ​https://bugs.webkit.org/show_bug.cgi?id=54151
(Animation API) is in progress.

  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/win/Skipped:
2:44 AM Changeset in webkit [81232] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-16 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

fast/loader/stateobjects/replacestate-in-iframe.html caused infinite loop.
​https://bugs.webkit.org/show_bug.cgi?id=36467

Removing the test from skipped list since the problem seems to be solved.

  • platform/qt/Skipped:
2:00 AM Changeset in webkit [81231] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-15 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] media/audio-repaint.html times out again
​https://bugs.webkit.org/show_bug.cgi?id=56366

Rewrote the test to avoid a timer and attempt the seek on media
elements only after we are sure playback started to avoid an
INVALID_STATE_ERR exception.

  • media/audio-repaint.html:
1:58 AM Changeset in webkit [81230] by abarth@webkit.org
  • 13 edits in trunk/Source/WebCore

2011-03-16 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should build platform/
​https://bugs.webkit.org/show_bug.cgi?id=56430

Adding platform/ to the GYP build required disabling
ALWAYS_SEARCH_USER_PATHS, which in turn required fixing some latent
style issues. I suspect we'll end up excluding some of these files
from the build in the final analysis, but we might as well fix the
style errors while we're here.

  • bindings/js/JSMainThreadExecState.h:
  • bindings/js/ScheduledAction.h:
  • css/CSSPrimitiveValueCache.cpp:
  • gyp/WebCore.gyp:
  • platform/KillRingNone.cpp: (WebCore::KillRing::append): (WebCore::KillRing::prepend):
  • platform/graphics/ContextShadow.h:
  • platform/graphics/gpu/LoopBlinnPathProcessor.cpp: (WebCore::LoopBlinnPathProcessor::buildContours): (WebCore::TessellationState::combineCallback):
  • platform/graphics/gpu/PODRedBlackTree.h: (WebCore::PODRedBlackTree::updateNode): (WebCore::PODRedBlackTree::logIfVerbose):
  • platform/graphics/opengl/TextureMapperGL.cpp:
  • platform/graphics/opengl/TextureMapperGL.h:
  • platform/graphics/texmap/TextureMapper.h: (WebCore::BitmapTexture::save): (WebCore::TextureMapper::paintToTarget):
  • platform/graphics/texmap/TextureMapperNode.h:
1:56 AM Changeset in webkit [81229] by Philippe Normand
  • 4 edits in trunk

2011-03-15 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] http/tests/media/video-play-stall-before-meta-data.html fails
​https://bugs.webkit.org/show_bug.cgi?id=56370

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): Let the mediaPlayerClient handle the stream error, in this case the HTMLMediaElement will emit a stalled event.

2011-03-15 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] http/tests/media/video-play-stall-before-meta-data.html fails
​https://bugs.webkit.org/show_bug.cgi?id=56370

  • platform/gtk/Skipped: Unskip fixed test.
1:52 AM Changeset in webkit [81228] by Philippe Normand
  • 3 edits in trunk/Source/WebCore

2011-03-10 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] Frame accurate seeking isn't always accurate
​https://bugs.webkit.org/show_bug.cgi?id=55217

Attempt to build the seek GstClockTime position by converting the
float time value to a GTimeVal value rounded at microsecond
precision. Additionally perform the seek with the ACCURATE seek
flag. These modifications at least fix this manual-test:
​http://www.massive-interactive.nl/html5_video/smpte_test_universal.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::currentTime): (WebCore::MediaPlayerPrivateGStreamer::seek):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
1:18 AM Changeset in webkit [81227] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-16 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

[Qt] Some inspector test fail intermittently
​https://bugs.webkit.org/show_bug.cgi?id=42090

Unskip a bunch of non-http inspector tests on Qt. All these tests pass locally.

  • platform/qt/Skipped:
1:14 AM Changeset in webkit [81226] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Add failing tests to the Skipped list.

  • platform/qt/Skipped:
    • Add fast/forms/input-autofilled.html because of missing layoutTestController.setAutofilled().
    • Add fast/workers/shared-worker-frame-lifecycle.html because it is still flakey. (bug 34281)
12:51 AM Changeset in webkit [81225] by hayato@chromium.org
  • 2 edits in trunk/Tools

2011-03-15 Hayato Ito <​hayato@chromium.org>

Reviewed by Ojan Vafai.

Ignore files that will be used by reftests in old-run-webkit-tests.

​https://bugs.webkit.org/show_bug.cgi?id=55936

  • Scripts/old-run-webkit-tests:

Mar 15, 2011:

11:59 PM Changeset in webkit [81224] by Adam Roben
  • 2 edits in trunk/LayoutTests

Fix bug number typo

  • platform/win/Skipped:
11:54 PM Changeset in webkit [81223] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip an asserting test on Windows

<​http://webkit.org/b/56047> tracks the failure.

  • platform/win/Skipped: Added editing/style/iframe-onload-crash.html.
11:46 PM Changeset in webkit [81222] by yurys@chromium.org
  • 12 edits in trunk/Source/WebCore

2011-03-15 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: split InspectorAgent.populateScriptObjects into more granular agent-specific requests
​https://bugs.webkit.org/show_bug.cgi?id=56389

Instead of sending one big request populateScriptObjects each agent requests
for initial data in its constructor.

  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::pushDataCollectedOffline): (WebCore::InspectorAgent::getPreferredPanel):
  • inspector/InspectorAgent.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::setFrontend): (WebCore::InspectorDOMAgent::restore):
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setFrontend):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorProfilerAgent.h: (WebCore::InspectorProfilerAgent::isEnabled):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
  • inspector/front-end/inspector.js:
11:33 PM Changeset in webkit [81221] by levin@chromium.org
  • 3 edits
    10 deletes in trunk/LayoutTests

Fix few more baselines (which the tool didn't handle well before due to them
being in the mac-leopard directory).

svg/w3c due to r81168
svg/custom/mouse due to r81053

  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum: Removed.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Removed.
11:21 PM Changeset in webkit [81220] by rniwa@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-03-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Devirtualize isContentEditable and isRichlyContentEditable
​https://bugs.webkit.org/show_bug.cgi?id=56421

Rewrote Node::isContentEditable as a non-recursive non-virtual function.

  • dom/Document.cpp: Removed isContentEditable and isContentRichlyEditable.
  • dom/Document.h: Ditto.
  • dom/Node.cpp: (WebCore::Node::isContentEditable): Rewritten.
  • dom/Node.h: (WebCore::Node::isContentEditable): Calls isContentEditable(Editable). (WebCore::Node::isContentRichlyEditable): Calls isContentEditable(RichlyEditable).
  • html/HTMLElement.cpp: Removed isContentEditable and isContentRichlyEditable.
  • html/HTMLElement.h: Ditto.
11:00 PM Changeset in webkit [81219] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-03-15 Felipe Oliveira da Silva Netto <​f.dachshund@gmail.com>

Reviewed by Adam Roben.

Function relativeScriptsDir doesn't return the correct relative
Scripts directory.

  • Scripts/webkitdirs.pm: (relativeScriptsDir): Ensure we use the directory that contains webkitdirs.pm, not the one that contains the original script that was invoked.
10:46 PM Changeset in webkit [81218] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should build inspector/ loader/ mathml/ notifications/ and page/
​https://bugs.webkit.org/show_bug.cgi?id=56412

Yay for smooth sailing.

  • gyp/WebCore.gyp:
10:02 PM Changeset in webkit [81217] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-03-15 Ilya Sherman <​isherman@chromium.org>

Reviewed by Darin Fisher.

Move isReadOnly() from WebInputElement to WebFormControlElement
​https://bugs.webkit.org/show_bug.cgi?id=55760

  • public/WebFormControlElement.h:
  • public/WebInputElement.h:
  • src/WebFormControlElement.cpp: (WebKit::WebFormControlElement::isReadOnly):
  • src/WebInputElement.cpp:
9:13 PM Changeset in webkit [81216] by Dimitri Glazkov
  • 5 edits
    4 adds in trunk

2011-03-15 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

REGRESSION(r76147): A slider thumb that is styled cannot be programmatically moved
​https://bugs.webkit.org/show_bug.cgi?id=56059

Note: the test should pass on all platforms, because it was designed to not use
platform-specific metrics.

  • fast/dom/HTMLInputElement/input-slider-update-styled.html: Added.
  • fast/dom/HTMLInputElement/input-slider-update-styled-expected.checksum: Added.
  • fast/dom/HTMLInputElement/input-slider-update-styled-expected.png: Added.
  • fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Added.

2011-03-15 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

REGRESSION(r76147): A slider thumb that is styled cannot be programmatically moved
​https://bugs.webkit.org/show_bug.cgi?id=56059

Test: fast/dom/HTMLInputElement/input-slider-update-styled.html

  • html/RangeInputType.cpp: (WebCore::RangeInputType::valueChanged): Changed to use setPositionFromValue.
  • html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::setPositionFromValue): Added. (WebCore::SliderThumbElement::dragFrom): Changed to use setPositionFromPoint. (WebCore::SliderThumbElement::setPositionFromPoint): Ditto. (WebCore::SliderThumbElement::defaultEventHandler): Ditto.
  • html/shadow/SliderThumbElement.h: Added decls.
9:04 PM Changeset in webkit [81215] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Attempted build fix following r81213. Same song second verse.

  • platform/image-encoders/skia/PNGImageEncoder.cpp:

(WebCore::encodePixels):

8:59 PM Changeset in webkit [81214] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Attempted build fix for Chromium OSX release build following r81213.

  • platform/image-encoders/skia/JPEGImageEncoder.cpp:

(WebCore::encodePixels): Change scoping of |pixels| to be after setjmp call.

8:26 PM Changeset in webkit [81213] by commit-queue@webkit.org
  • 22 edits
    2 adds in trunk

2011-03-15 John Bauman <​jbauman@chromium.org>

Reviewed by Kenneth Russell.

Non-premultiplied-alpha canvas attribute is ignore for toDataURL, drawImage, texImage2D
​https://bugs.webkit.org/show_bug.cgi?id=56238

Add new test from webgl conformance test.

  • fast/canvas/webgl/premultiplyalpha-test-expected.txt: Added.
  • fast/canvas/webgl/premultiplyalpha-test.html: Added.
  • fast/canvas/webgl/resources/webgl-test-utils.js: Update to fix fillTexture (WebGLTestUtils):
  • platform/chromium/test_expectations.txt:
  • platform/mac-wk2/Skipped:

2011-03-15 John Bauman <​jbauman@chromium.org>

Reviewed by Kenneth Russell.

Non-premultiplied-alpha canvas attribute is ignore for toDataURL, drawImage, texImage2D
​https://bugs.webkit.org/show_bug.cgi?id=56238

Attempt to get an ImageData (non-premultiplied) from a WebGL canvas
instead of getting an ImageBuffer, so there's a chance the data can be
passed straight through to the consumer with no premultiplication
necessary. Fixes Chromium and Safari.

Test: fast/canvas/webgl/premultiplyalpha-test.html

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::toDataURL): (WebCore::HTMLCanvasElement::getImageData):
  • html/HTMLCanvasElement.h:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::paintRenderingResultsToImageData): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texSubImage2D):
  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::CGImageToDataURL): (WebCore::ImageBuffer::toDataURL): (WebCore::ImageDataToDataURL):
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::validateAttributes): (WebCore::GraphicsContext3D::readRenderingResults): (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): (WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageToDataURL): (WebCore::ImageBuffer::toDataURL): (WebCore::ImageDataToDataURL):
  • platform/image-encoders/skia/JPEGImageEncoder.cpp: (WebCore::preMultipliedBGRAtoRGB): (WebCore::RGBAtoRGB): (WebCore::encodePixels): (WebCore::JPEGImageEncoder::encode):
  • platform/image-encoders/skia/JPEGImageEncoder.h:
  • platform/image-encoders/skia/PNGImageEncoder.cpp: (WebCore::preMultipliedBGRAtoRGBA): (WebCore::encodePixels): (WebCore::PNGImageEncoder::encode):
  • platform/image-encoders/skia/PNGImageEncoder.h:

2011-03-15 John Bauman <​jbauman@chromium.org>

Reviewed by Kenneth Russell.

Non-premultiplied-alpha canvas attribute is ignore for toDataURL, drawImage, texImage2D
​https://bugs.webkit.org/show_bug.cgi?id=56238

Add support for reading a webgl context into an ImageData.

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas): (WebCore::GraphicsContext3DInternal::paintRenderingResultsToImageData):
  • src/GraphicsContext3DInternal.h:
8:10 PM Changeset in webkit [81212] by kevino@webkit.org
  • 6 edits in trunk

[wx] Build fixes after recent changes.

7:50 PM Changeset in webkit [81211] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix after r81208 for ​https://bugs.webkit.org/show_bug.cgi?id=56425

  • loader/icon/IconDatabaseBase.h: #include instead of forward declare.
7:31 PM Changeset in webkit [81210] by levin@chromium.org
  • 9 edits
    28 adds in trunk/LayoutTests

A little more clean-up due to r81168. Also, some adjustment of the results for Linux due to r81162.

  • platform/chromium-mac-leopard/svg/text/small-fonts-2-expected.txt:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
  • platform/chromium-win/svg/carto.net/selectionlist-expected.checksum:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-win/svg/text/text-text-07-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-07-t-expected.png:
  • platform/chromium/test_expectations.txt:
7:21 PM Changeset in webkit [81209] by Beth Dakin
  • 14 edits in trunk/Source/WebCore

Fix for <rdar://problem/8944558> Overlay scrollers in overflow areas need to
send notifications appropriate times (showing up, resizing)
-and corresponding-
​https://bugs.webkit.org/show_bug.cgi?id=56067

Reviewed by Darin Adler.

The general strategy here is to add a HashSet of ScrollableAreas to the page that
can be accessed when necessary to send notifications to all ScrollableAreas. In
turn, all of the ScrollableArea classes that add themselves to the HashSet must
keep a weak pointer to Page so that they can remove themselves without relying on
Frames or Renderers to still have references.

Find layers for relevant node and if the layers are in the Page's ScrollableArea
set, then send the relevant notification.

  • page/EventHandler.cpp:

(WebCore::layerForNode):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::updateMouseEventTargetNode):

When the page is set active or not active, iterate through the Page's
ScrollableAreas to send hide/show notifications.

  • page/FocusController.cpp:

(WebCore::FocusController::setActive):

When a FrameView is created, add it to the ScrollableArea set. When it's
destroyed, remove it.

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::~FrameView):

Iterate through the Page's ScrollableAreas to send the paint notification.
(WebCore::FrameView::notifyPageThatContentAreaWillPaint):

  • page/FrameView.h:

(WebCore::FrameView::disconnectFromPage):

Add the new ScrollableArea set.

  • page/Page.cpp:

(WebCore::Page::~Page):
(WebCore::Page::addScrollableArea):

7:15 PM Changeset in webkit [81208] by beidson@apple.com
  • 27 edits
    7 adds in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=56425
WebKit2 icon database.

Reviewed by Sam Weinig.

../WebCore:

  • WebCore.exp.in:

../WebKit2:

Project file paperwork:

  • DerivedSources.make:
  • DerivedSources.pro:
  • GNUmakefile.am:
  • WebKit2.pri:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:
  • Scripts/webkit2/messages.py: Special-case capitalization for messages that start with "URL" to be lowercased to "url" instead of "uRL".

Add messaging-related stuff:

  • Platform/CoreIPC/MessageID.h:
  • UIProcess/WebIconDatabase.messages.in: Added.
  • WebProcess/IconDatabase/WebIconDatabaseProxy.messages.in: Added.
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):

Prep to make WebIconDatabase an API object:

  • Shared/APIObject.h:

Add an "icon DB is enabled" flag to WebProcessCreationParameters:

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Add SPI for client apps to set the icon database path:

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetIconDatabasePath):

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/WebContext.h:

(WebKit::WebContext::setIconDatabasePath):

Hook up initialization, clearing, and messaging for the icon database:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
(WebKit::WebContext::iconDatabasePath):

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultIconDatabasePath):

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformDefaultIconDatabasePath):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformDefaultIconDatabasePath):

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformDefaultIconDatabasePath):

Add the UIProcess-side IconDatabase. It will be the "actual database" as well as the API object:

  • UIProcess/WebIconDatabase.cpp: Added.

(WebKit::WebIconDatabase::create):
(WebKit::WebIconDatabase::~WebIconDatabase):
(WebKit::WebIconDatabase::WebIconDatabase):
(WebKit::WebIconDatabase::invalidate):
(WebKit::WebIconDatabase::retainIconForPageURL):
(WebKit::WebIconDatabase::releaseIconForPageURL):
(WebKit::WebIconDatabase::setIconURLForPageURL):
(WebKit::WebIconDatabase::setIconDataForIconURL):
(WebKit::WebIconDatabase::iconDataForPageURL):
(WebKit::WebIconDatabase::iconURLForPageURL):
(WebKit::WebIconDatabase::iconDataKnownForIconURL):
(WebKit::WebIconDatabase::loadDecisionForIconURL):
(WebKit::WebIconDatabase::didReceiveMessage):
(WebKit::WebIconDatabase::didReceiveSyncMessage):

  • UIProcess/WebIconDatabase.h: Added.

(WebKit::WebIconDatabase::clearContext):
(WebKit::WebIconDatabase::type):

Add the WebProcess-side IconDatabaseProxy. It acts as the WebCore IconDatabase and operates via messaging:

  • WebProcess/IconDatabase: Added.
  • WebProcess/IconDatabase/WebIconDatabaseProxy.cpp: Added.

(WebKit::WebIconDatabaseProxy::~WebIconDatabaseProxy):
(WebKit::WebIconDatabaseProxy::WebIconDatabaseProxy):
(WebKit::WebIconDatabaseProxy::isEnabled):
(WebKit::WebIconDatabaseProxy::setEnabled):
(WebKit::WebIconDatabaseProxy::iconForPageURL):
(WebKit::WebIconDatabaseProxy::retainIconForPageURL):
(WebKit::WebIconDatabaseProxy::releaseIconForPageURL):
(WebKit::WebIconDatabaseProxy::iconURLForPageURL):
(WebKit::WebIconDatabaseProxy::iconDataKnownForIconURL):
(WebKit::WebIconDatabaseProxy::loadDecisionForIconURL):
(WebKit::WebIconDatabaseProxy::setIconURLForPageURL):
(WebKit::WebIconDatabaseProxy::setIconDataForIconURL):
(WebKit::WebIconDatabaseProxy::urlImportFinished):
(WebKit::WebIconDatabaseProxy::didReceiveMessage):

  • WebProcess/IconDatabase/WebIconDatabaseProxy.h: Added.

Hook up initialization and messaging for the icon database proxy:

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:
7:13 PM Changeset in webkit [81207] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

Update Qt specific expected results after r80846.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
6:17 PM Changeset in webkit [81206] by weinig@apple.com
  • 1 edit
    1 add in trunk/Tools

Add script to convert a patch to a prettypatch and show in the default browser
​https://bugs.webkit.org/show_bug.cgi?id=56416

Reviewed by Darin Adler.

This can be used either like

$ svn-create-patch | show-pretty-diff

or

$ show-pretty-diff patch.diff

  • Scripts/show-pretty-diff: Added.
5:50 PM Changeset in webkit [81205] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-03-15 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2: False SPOD cursor when context menu is open
<rdar://problem/9029154>
​https://bugs.webkit.org/show_bug.cgi?id=56433

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showContextMenu): Update to match showPopupMenu idiomatically, and stop the responsivenessTimer since the act of showing the context menu could spin a nested runloop.
  • UIProcess/mac/WebContextMenuProxyMac.mm: (WebKit::WebContextMenuProxyMac::showContextMenu):
  • UIProcess/qt/WebContextMenuProxyQt.cpp: (WebKit::WebContextMenuProxyQt::showContextMenu):
  • UIProcess/win/WebContextMenuProxyWin.cpp: (WebKit::WebContextMenuProxyWin::showContextMenu): Move isEmpty() check to implementations, since we don't want to show this in any case, not just the one where we check it.
5:48 PM Changeset in webkit [81204] by levin@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r81144.
​http://trac.webkit.org/changeset/81144
​https://bugs.webkit.org/show_bug.cgi?id=56432

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-03-15
It broke the ui test
NPAPITesterBase.GetURLRedirectNotification. (Requested by
dave_levin on #webkit).

  • public/WebURLLoader.h:
  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::AssociatedURLLoader):
(WebKit::AssociatedURLLoader::~AssociatedURLLoader):
(WebKit::AssociatedURLLoader::loadSynchronously):
(WebKit::AssociatedURLLoader::loadAsynchronously):
(WebKit::AssociatedURLLoader::cancel):
(WebKit::AssociatedURLLoader::setDefersLoading):
(WebKit::AssociatedURLLoader::prepareRequest):
(WebKit::AssociatedURLLoader::willSendRequest):
(WebKit::AssociatedURLLoader::didSendData):
(WebKit::AssociatedURLLoader::didReceiveResponse):
(WebKit::AssociatedURLLoader::didDownloadData):
(WebKit::AssociatedURLLoader::didReceiveData):
(WebKit::AssociatedURLLoader::didReceiveCachedMetadata):
(WebKit::AssociatedURLLoader::didFinishLoading):
(WebKit::AssociatedURLLoader::didFail):

  • src/AssociatedURLLoader.h:
5:34 PM Changeset in webkit [81203] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build should build editing, fileapi, history, and html
​https://bugs.webkit.org/show_bug.cgi?id=56411

These all went smoothly.

  • gyp/WebCore.gyp:
5:31 PM Changeset in webkit [81202] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should build dom/
​https://bugs.webkit.org/show_bug.cgi?id=56409

  • gyp/WebCore.gyp:
5:29 PM Changeset in webkit [81201] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

WebCore GYP build should build css/
​https://bugs.webkit.org/show_bug.cgi?id=56408

CSSParser.cpp #includes tokenizer.cpp, which we haven't included in the
build yet. I've punted on that problem for now, but we'll come back to
it.

  • gyp/WebCore.gyp:
5:26 PM Changeset in webkit [81200] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

WebCore GYP build should build bindings/
​https://bugs.webkit.org/show_bug.cgi?id=56406

I wanted to include bindings/objc in this patch, but they were somewhat
complicated. It looks like they include headers from the output
directory (via PrivateHeaders), but we haven't wired up the
PrivateHeaders yet.

  • gyp/WebCore.gyp:
5:13 PM Changeset in webkit [81199] by levin@chromium.org
  • 6 edits
    1 move
    14 deletes in trunk/LayoutTests

Update Leopard specific baselines for tests (editing, css) changes due to r80755.
Fix the expectation for input-autofilled.

  • platform/chromium-mac-leopard/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum:
  • platform/chromium-mac-leopard/css2.1/t1008-c44-ln-box-02-d-ag-expected.png:
  • platform/chromium-mac-leopard/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
  • platform/chromium-mac-leopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-2-expected.checksum: Removed.
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-2-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-2-left-expected.checksum: Removed.
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-2-left-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-expected.checksum: Removed.
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-expected.png: Removed.
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-right-expected.checksum: Removed.
  • platform/chromium-mac-leopard/editing/selection/caret-ltr-right-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/block/margin-collapse/103-expected.png: Removed.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.checksum: Removed.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.png: Removed.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.checksum: Removed.
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png: Removed.
  • platform/chromium/fast/forms/input-autofilled-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/forms/input-autofilled-expected.txt.
  • platform/chromium/test_expectations.txt:
5:00 PM Changeset in webkit [81198] by simonjam@chromium.org
  • 20 edits
    2 moves
    5 adds in trunk

2011-03-15 James Simonsen <​simonjam@chromium.org>

Reviewed by Tony Gentilcore.

Need different behavior for ensuring execution order of dynamically loaded scripts
​https://bugs.webkit.org/show_bug.cgi?id=50115

Dynamically added scripts with async=false will load in parallel, but execute in order.
See: ​http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#force-async

  • fast/dom/HTMLScriptElement/script-async-attr-expected.txt: Added test cases for forceAsync.
  • fast/dom/HTMLScriptElement/script-async-attr.html: Ditto.
  • http/tests/misc/script-async-load-execute-in-order-expected.txt: Added.
  • http/tests/misc/script-async-load-execute-in-order.html: Added.

2011-03-15 James Simonsen <​simonjam@chromium.org>

Reviewed by Tony Gentilcore.

Need different behavior for ensuring execution order of dynamically loaded scripts
​https://bugs.webkit.org/show_bug.cgi?id=50115

Dynamically added scripts with async=false will load in parallel, but execute in order.
See: ​http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#force-async

Tests: fast/dom/HTMLScriptElement/script-async-attr.html

http/tests/misc/script-async-load-execute-in-order.html

  • Android.mk: Rename AsyncScriptRunner -> ScriptRunner.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/DOMAllInOne.cpp: Ditto.
  • dom/Document.cpp: (WebCore::Document::Document): Ditto. (WebCore::Document::~Document): Ditto.
  • dom/Document.h: (WebCore::Document::scriptRunner): Ditto.
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::ScriptElement): Added forceAsync and willExecuteInOrder. (WebCore::ScriptElement::handleAsyncAttribute): Called by HTMLScriptElement when async attribute changes. (WebCore::ScriptElement::prepareScript): Added support for forceAsync. (WebCore::ScriptElement::notifyFinished): Tell ScriptRunner to execute in order if needed.
  • dom/ScriptElement.h: (WebCore::ScriptElement::forceAsync): Added.
  • dom/ScriptRunner.cpp: Renamed from Source/WebCore/dom/AsyncScriptRunner.cpp. (WebCore::ScriptRunner::ScriptRunner): Added in-order script queue. (WebCore::ScriptRunner::~ScriptRunner): Ditto. (WebCore::ScriptRunner::executeScriptSoon): (WebCore::ScriptRunner::queueScriptForInOrderExecution): Added. (WebCore::ScriptRunner::suspend): (WebCore::ScriptRunner::resume): (WebCore::ScriptRunner::timerFired): Execute in-order scripts if ready.
  • dom/ScriptRunner.h: Renamed from Source/WebCore/dom/AsyncScriptRunner.h. (WebCore::ScriptRunner::create): (WebCore::ScriptRunner::hasPendingScripts): Check for in-order scripts too.
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::attributeChanged): Notify ScriptElement when async changes. (WebCore::HTMLScriptElement::setAsync): Ditto. (WebCore::HTMLScriptElement::async): Include forceAsync in calculation.
  • html/HTMLScriptElement.h:
  • html/HTMLScriptElement.idl: Removed Reflect from async for custom behavior.
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Rename AsyncScriptRunner -> ScriptRunner. (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer): Ditto.
4:59 PM Changeset in webkit [81197] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Removed another deprecatedAppend
​https://bugs.webkit.org/show_bug.cgi?id=56429

Patch by Geoffrey Garen <​ggaren@apple.com> on 2011-03-15
Reviewed by Oliver Hunt.

  • collector/handles/HandleHeap.cpp:

(JSC::HandleHeap::markStrongHandles):

  • collector/handles/HandleHeap.h: Use HeapRootMarker, since handles are

marked directly by the Heap.

  • runtime/Heap.cpp:

(JSC::Heap::markRoots): Ditto.

4:59 PM Changeset in webkit [81196] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-03-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed another deprecatedAppend
​https://bugs.webkit.org/show_bug.cgi?id=56429

  • collector/handles/HandleHeap.cpp: (JSC::HandleHeap::markStrongHandles):
  • collector/handles/HandleHeap.h: Use HeapRootMarker, since handles are marked directly by the Heap.
  • runtime/Heap.cpp: (JSC::Heap::markRoots): Ditto.
4:54 PM Changeset in webkit [81195] by Martin Robinson
  • 1 edit
    319 adds in trunk/LayoutTests

2011-03-15 Martin Robinson <​mrobinson@igalia.com>

Adding new test results for GTK+.

  • platform/gtk: All files omitted to prevent overflowing the BuildBot console.
4:54 PM Changeset in webkit [81194] by tony@chromium.org
  • 163 edits in trunk/Source

2011-03-15 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

pngcrush images used by inspector
​https://bugs.webkit.org/show_bug.cgi?id=56426

This saves 120k in WebCore and 8k in WebKit/chromium. I ran
pngcrush -brute, so none of the meta data (ancillary chunks)
are modified.

No new tests, just compressing png files.

  • inspector/front-end/Images/applicationCache.png:
  • inspector/front-end/Images/auditsIcon.png:
  • inspector/front-end/Images/back.png:
  • inspector/front-end/Images/breakpointBorder.png:
  • inspector/front-end/Images/breakpointConditionalBorder.png:
  • inspector/front-end/Images/breakpointConditionalCounterBorder.png:
  • inspector/front-end/Images/breakpointCounterBorder.png:
  • inspector/front-end/Images/breakpointsActivateButtonGlyph.png:
  • inspector/front-end/Images/breakpointsDeactivateButtonGlyph.png:
  • inspector/front-end/Images/checker.png:
  • inspector/front-end/Images/clearConsoleButtonGlyph.png:
  • inspector/front-end/Images/closeButtons.png:
  • inspector/front-end/Images/consoleButtonGlyph.png:
  • inspector/front-end/Images/consoleIcon.png:
  • inspector/front-end/Images/cookie.png:
  • inspector/front-end/Images/database.png:
  • inspector/front-end/Images/databaseTable.png:
  • inspector/front-end/Images/debuggerContinue.png:
  • inspector/front-end/Images/debuggerPause.png:
  • inspector/front-end/Images/debuggerStepInto.png:
  • inspector/front-end/Images/debuggerStepOut.png:
  • inspector/front-end/Images/debuggerStepOver.png:
  • inspector/front-end/Images/disclosureTriangleSmallDown.png:
  • inspector/front-end/Images/disclosureTriangleSmallDownBlack.png:
  • inspector/front-end/Images/disclosureTriangleSmallDownWhite.png:
  • inspector/front-end/Images/disclosureTriangleSmallRight.png:
  • inspector/front-end/Images/disclosureTriangleSmallRightBlack.png:
  • inspector/front-end/Images/disclosureTriangleSmallRightDown.png:
  • inspector/front-end/Images/disclosureTriangleSmallRightDownBlack.png:
  • inspector/front-end/Images/disclosureTriangleSmallRightDownWhite.png:
  • inspector/front-end/Images/disclosureTriangleSmallRightWhite.png:
  • inspector/front-end/Images/dockButtonGlyph.png:
  • inspector/front-end/Images/elementsIcon.png:
  • inspector/front-end/Images/enableOutlineButtonGlyph.png:
  • inspector/front-end/Images/enableSolidButtonGlyph.png:
  • inspector/front-end/Images/errorIcon.png:
  • inspector/front-end/Images/errorMediumIcon.png:
  • inspector/front-end/Images/errorRedDot.png:
  • inspector/front-end/Images/excludeButtonGlyph.png:
  • inspector/front-end/Images/focusButtonGlyph.png:
  • inspector/front-end/Images/forward.png:
  • inspector/front-end/Images/frame.png:
  • inspector/front-end/Images/garbageCollectButtonGlyph.png:
  • inspector/front-end/Images/gearButtonGlyph.png:
  • inspector/front-end/Images/glossyHeader.png:
  • inspector/front-end/Images/glossyHeaderPressed.png:
  • inspector/front-end/Images/glossyHeaderSelected.png:
  • inspector/front-end/Images/glossyHeaderSelectedPressed.png:
  • inspector/front-end/Images/goArrow.png:
  • inspector/front-end/Images/graphLabelCalloutLeft.png:
  • inspector/front-end/Images/graphLabelCalloutRight.png:
  • inspector/front-end/Images/helpButtonGlyph.png:
  • inspector/front-end/Images/largerResourcesButtonGlyph.png:
  • inspector/front-end/Images/localStorage.png:
  • inspector/front-end/Images/networkIcon.png:
  • inspector/front-end/Images/nodeSearchButtonGlyph.png:
  • inspector/front-end/Images/paneAddButtons.png:
  • inspector/front-end/Images/paneBottomGrow.png:
  • inspector/front-end/Images/paneBottomGrowActive.png:
  • inspector/front-end/Images/paneGrowHandleLine.png:
  • inspector/front-end/Images/paneSettingsButtons.png:
  • inspector/front-end/Images/pauseOnExceptionButtonGlyph.png:
  • inspector/front-end/Images/percentButtonGlyph.png:
  • inspector/front-end/Images/popoverArrows.png:
  • inspector/front-end/Images/popoverBackground.png:
  • inspector/front-end/Images/profileGroupIcon.png:
  • inspector/front-end/Images/profileIcon.png:
  • inspector/front-end/Images/profileSmallIcon.png:
  • inspector/front-end/Images/profilesIcon.png:
  • inspector/front-end/Images/profilesSilhouette.png:
  • inspector/front-end/Images/programCounterBorder.png:
  • inspector/front-end/Images/radioDot.png:
  • inspector/front-end/Images/recordButtonGlyph.png:
  • inspector/front-end/Images/recordToggledButtonGlyph.png:
  • inspector/front-end/Images/reloadButtonGlyph.png:
  • inspector/front-end/Images/resourceCSSIcon.png:
  • inspector/front-end/Images/resourceDocumentIcon.png:
  • inspector/front-end/Images/resourceDocumentIconSmall.png:
  • inspector/front-end/Images/resourceJSIcon.png:
  • inspector/front-end/Images/resourcePlainIcon.png:
  • inspector/front-end/Images/resourcePlainIconSmall.png:
  • inspector/front-end/Images/resourcesIcon.png:
  • inspector/front-end/Images/resourcesSizeGraphIcon.png:
  • inspector/front-end/Images/resourcesTimeGraphIcon.png:
  • inspector/front-end/Images/scriptsIcon.png:
  • inspector/front-end/Images/scriptsSilhouette.png:
  • inspector/front-end/Images/searchSmallBlue.png:
  • inspector/front-end/Images/searchSmallBrightBlue.png:
  • inspector/front-end/Images/searchSmallGray.png:
  • inspector/front-end/Images/searchSmallWhite.png:
  • inspector/front-end/Images/segment.png:
  • inspector/front-end/Images/segmentEnd.png:
  • inspector/front-end/Images/segmentHover.png:
  • inspector/front-end/Images/segmentHoverEnd.png:
  • inspector/front-end/Images/segmentSelected.png:
  • inspector/front-end/Images/segmentSelectedEnd.png:
  • inspector/front-end/Images/sessionStorage.png:
  • inspector/front-end/Images/splitviewDimple.png:
  • inspector/front-end/Images/splitviewDividerBackground.png:
  • inspector/front-end/Images/statusbarButtons.png:
  • inspector/front-end/Images/statusbarMenuButton.png:
  • inspector/front-end/Images/statusbarMenuButtonSelected.png:
  • inspector/front-end/Images/statusbarResizerHorizontal.png:
  • inspector/front-end/Images/statusbarResizerVertical.png:
  • inspector/front-end/Images/successGreenDot.png:
  • inspector/front-end/Images/thumbActiveHoriz.png:
  • inspector/front-end/Images/thumbActiveVert.png:
  • inspector/front-end/Images/thumbHoriz.png:
  • inspector/front-end/Images/thumbHoverHoriz.png:
  • inspector/front-end/Images/thumbHoverVert.png:
  • inspector/front-end/Images/thumbVert.png:
  • inspector/front-end/Images/timelineBarBlue.png:
  • inspector/front-end/Images/timelineBarGray.png:
  • inspector/front-end/Images/timelineBarGreen.png:
  • inspector/front-end/Images/timelineBarOrange.png:
  • inspector/front-end/Images/timelineBarPurple.png:
  • inspector/front-end/Images/timelineBarRed.png:
  • inspector/front-end/Images/timelineBarYellow.png:
  • inspector/front-end/Images/timelineCheckmarks.png:
  • inspector/front-end/Images/timelineDots.png:
  • inspector/front-end/Images/timelineHollowPillBlue.png:
  • inspector/front-end/Images/timelineHollowPillGray.png:
  • inspector/front-end/Images/timelineHollowPillGreen.png:
  • inspector/front-end/Images/timelineHollowPillOrange.png:
  • inspector/front-end/Images/timelineHollowPillPurple.png:
  • inspector/front-end/Images/timelineHollowPillRed.png:
  • inspector/front-end/Images/timelineHollowPillYellow.png:
  • inspector/front-end/Images/timelineIcon.png:
  • inspector/front-end/Images/timelinePillBlue.png:
  • inspector/front-end/Images/timelinePillGray.png:
  • inspector/front-end/Images/timelinePillGreen.png:
  • inspector/front-end/Images/timelinePillOrange.png:
  • inspector/front-end/Images/timelinePillPurple.png:
  • inspector/front-end/Images/timelinePillRed.png:
  • inspector/front-end/Images/timelinePillYellow.png:
  • inspector/front-end/Images/toolbarItemSelected.png:
  • inspector/front-end/Images/trackHoriz.png:
  • inspector/front-end/Images/trackVert.png:
  • inspector/front-end/Images/treeDownTriangleBlack.png:
  • inspector/front-end/Images/treeDownTriangleWhite.png:
  • inspector/front-end/Images/treeRightTriangleBlack.png:
  • inspector/front-end/Images/treeRightTriangleWhite.png:
  • inspector/front-end/Images/treeUpTriangleBlack.png:
  • inspector/front-end/Images/treeUpTriangleWhite.png:
  • inspector/front-end/Images/undockButtonGlyph.png:
  • inspector/front-end/Images/userInputIcon.png:
  • inspector/front-end/Images/userInputPreviousIcon.png:
  • inspector/front-end/Images/userInputResultIcon.png:
  • inspector/front-end/Images/warningIcon.png:
  • inspector/front-end/Images/warningMediumIcon.png:
  • inspector/front-end/Images/warningOrangeDot.png:
  • inspector/front-end/Images/warningsErrors.png:

2011-03-15 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

pngcrush images used by inspector
​https://bugs.webkit.org/show_bug.cgi?id=56426

This saves 120k in WebCore and 8k in WebKit/chromium. I ran
pngcrush -brute, so none of the meta data (ancillary chunks)
are modified.

  • src/js/Images/segmentChromium.png:
  • src/js/Images/segmentHoverChromium.png:
  • src/js/Images/segmentHoverEndChromium.png:
  • src/js/Images/segmentSelectedChromium.png:
  • src/js/Images/segmentSelectedEndChromium.png:
  • src/js/Images/statusbarBackgroundChromium.png:
  • src/js/Images/statusbarBottomBackgroundChromium.png:
  • src/js/Images/statusbarMenuButtonChromium.png:
  • src/js/Images/statusbarMenuButtonSelectedChromium.png:
4:54 PM Changeset in webkit [81193] by ggaren@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

2011-03-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed some more deprecated / unsafe append
​https://bugs.webkit.org/show_bug.cgi?id=56428

  • collector/handles/HandleStack.cpp: (JSC::HandleStack::mark):
  • collector/handles/HandleStack.h: Mark the handle stack using a HeapRoot marker, since it's a heap root.


  • runtime/ArgList.cpp: (JSC::MarkedArgumentBuffer::markLists): (JSC::MarkedArgumentBuffer::slowAppend):
  • runtime/ArgList.h: Ditto.
  • runtime/Heap.cpp: (JSC::Heap::markRoots): Added a mark call for marking the handle stack. It seems like Oliver forgot this in his last patch. (!)
  • runtime/MarkStack.h: Removed appendSlots, since it would allow an object to embed JSValues directly instead of using WriteBarrier.

(JSC::MarkStack::append): Added a private append for a list of values.

(JSC::HeapRootMarker::mark): Access to the above.

4:42 PM Changeset in webkit [81192] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2011-03-15 Martin Robinson <​mrobinson@igalia.com>

Rebaseline some GTK+ tests after r81035 and r81049.

  • platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/gtk/fast/table/overflowHidden-expected.txt:
4:29 PM Changeset in webkit [81191] by ggaren@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

2011-03-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed a few more deprecatedAppends, and removed HeapRoot<T>
​https://bugs.webkit.org/show_bug.cgi?id=56422


Added HeapRootMarker, a privileged class for marking direct heap roots
that are iterated during each garbage collection. This is easier to use
and more reliable than HeapRoot<T>, so I've removed HeapRoot<T>.

  • debugger/Debugger.cpp: (JSC::evaluateInGlobalCallFrame):
  • debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
  • interpreter/CallFrame.h: (JSC::ExecState::exception):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • runtime/Completion.cpp: (JSC::evaluate): exception is no longer a HeapRoot<T>, so no need to call .get() on it.
  • runtime/Heap.cpp: (JSC::Heap::markProtectedObjects): (JSC::Heap::markTempSortVectors): (JSC::Heap::markRoots):
  • runtime/Heap.h: Updated to use HeapRootMarker.
  • runtime/JSCell.h: (JSC::JSCell::MarkStack::append): Added private functions for HeapRootMarker to use.
  • runtime/JSGlobalData.h: exception is no longer a HeapRoot<T>.
  • runtime/MarkStack.h: (JSC::HeapRootMarker::HeapRootMarker): (JSC::HeapRootMarker::mark): Added private functions for HeapRootMarker to use.
  • runtime/SmallStrings.cpp: (JSC::SmallStrings::markChildren): Updated to use HeapRootMarker.
  • runtime/SmallStrings.h: (JSC::SmallStrings::emptyString): (JSC::SmallStrings::singleCharacterString): (JSC::SmallStrings::singleCharacterStrings): Updated to use HeapRootMarker.
  • runtime/WriteBarrier.h: Removed HeapRoot<T>.
4:24 PM Changeset in webkit [81190] by Adam Roben
  • 1 edit
    24 adds in trunk/LayoutTests

Update Windows XP results after r81168

They differ from Windows 7 due to different fonts being used.

  • platform/win-xp/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/win-xp/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/win-xp/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/win-xp/svg/text/bidi-text-query-expected.txt: Added.
  • platform/win-xp/svg/text/bidi-tspans-expected.txt: Added.
4:24 PM Changeset in webkit [81189] by bweinstein@apple.com
  • 2 edits in trunk/Tools

Adding myself as a reviewer.

Rubber-stamped by Adam Roben.

  • Scripts/webkitpy/common/config/committers.py:
4:12 PM Changeset in webkit [81188] by oliver@apple.com
  • 16 edits
    4 adds in trunk/Source/JavaScriptCore

2011-03-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Introduce Local<T> to allow us to start moving to precise marking of locals
​https://bugs.webkit.org/show_bug.cgi?id=56394

Introduce a new handle type, Local<T> and a scoping mechanism
LocalScope to allow us to start moving towards precise marking
of temporaries and local variables.

We also start to use the new Local<> type in the JSON stringifier
so that we can have some coverage of their behaviour in the initial
checkin.

  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • collector/handles/Handle.h: (JSC::::asObject):
  • collector/handles/HandleStack.cpp: Added. (JSC::HandleStack::HandleStack): (JSC::HandleStack::mark): (JSC::HandleStack::grow):
  • collector/handles/HandleStack.h: Added. (JSC::HandleStack::enterScope): (JSC::HandleStack::zapTo): (JSC::HandleStack::leaveScope): (JSC::HandleStack::push):
  • collector/handles/Local.h: Added. (JSC::Local::internalSet): (JSC::::Local): (JSC::::operator): (JSC::LocalStack::LocalStack): (JSC::LocalStack::peek): (JSC::LocalStack::pop): (JSC::LocalStack::push): (JSC::LocalStack::isEmpty): (JSC::LocalStack::size):
  • collector/handles/LocalScope.h: Added. (JSC::LocalScope::LocalScope): (JSC::LocalScope::~LocalScope): (JSC::LocalScope::release):
  • runtime/Heap.cpp: (JSC::Heap::markRoots):
  • runtime/Heap.h: (JSC::Heap::allocateLocalHandle): (JSC::Heap::handleStack):
  • runtime/JSCell.h: (JSC::JSCell::::getString):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalData.h: (JSC::JSGlobalData::allocateLocalHandle):
  • runtime/JSONObject.cpp: (JSC::Stringifier::Stringifier): (JSC::Stringifier::stringify): (JSC::Stringifier::appendStringifiedValue): (JSC::Stringifier::Holder::Holder): (JSC::Walker::Walker): (JSC::Walker::walk): (JSC::JSONProtoFuncParse): (JSC::JSONProtoFuncStringify): (JSC::JSONStringify):
  • runtime/JSONObject.h:
  • runtime/MarkStack.h: (JSC::MarkStack::appendValues): (JSC::MarkStack::appendSlots):
3:58 PM Changeset in webkit [81187] by Adam Roben
  • 3 edits in trunk/LayoutTests

Update Windows results again after r81168

I accidentally copied the Mac results into platform/win for these two tests when I tried to
update results in r81179.

  • platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/win/svg/text/small-fonts-2-expected.txt:
3:55 PM Changeset in webkit [81186] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-03-15 Siddharth Mathur <​siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Symbian][WK2] Fix exporting and importing the WebProcessMainQt symbol
​https://bugs.webkit.org/show_bug.cgi?id=56417

Use the Q_DECL_EXPORT and Q_DECL_IMPORT macros directly to make sure
the symbol is always exported/imported.

  • WebProcess/qt/WebProcessMainQt.cpp: (WebKit::WebProcessMainQt):
  • qt/MainQt.cpp:
3:37 PM Changeset in webkit [81185] by rniwa@webkit.org
  • 8 edits
    2 adds in trunk

2011-03-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Crash in ReplaceSelectionCommand::doApply when inserting a node under a document node
​https://bugs.webkit.org/show_bug.cgi?id=56372

The bug was caused by insertNodeAfter's calling parentElement on document's child.
Fixed this by changing the node that AppendNodeCommand takes.

There was also a bug that document node always returned false for isContentEditable
and isContentRichlyEditable because they never overrode Node's default implementation.
Fixed this by overriding them in Document.

Test: editing/execCommand/append-node-under-document.html

  • dom/Document.cpp: (WebCore::Document::isContentEditable): Added. (WebCore::Document::isContentRichlyEditable): Added.
  • dom/Document.h:
  • editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::AppendNodeCommand): Takes ContainerNode instead of Element.
  • editing/AppendNodeCommand.h: (WebCore::AppendNodeCommand::create): Ditto.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::appendNode): Ditto. (WebCore::CompositeEditCommand::insertNodeAfter): Calls parentNode instead of parentElement.
  • editing/CompositeEditCommand.h:

2011-03-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Crash in ReplaceSelectionCommand::doApply when inserting a node under a document node
​https://bugs.webkit.org/show_bug.cgi?id=56372

Added a test to ensure WebKit does not crash when appending a node to a document
that has only two nested iframes.

  • editing/execCommand/append-node-under-document-expected.txt: Added.
  • editing/execCommand/append-node-under-document.html: Added.
3:32 PM Changeset in webkit [81184] by levin@chromium.org
  • 20 edits
    1 copy
    449 adds
    1 delete in trunk/LayoutTests

Compensate for r81168 (svg) and r81155 (fast/forms/input-autofilled.html) and r81049 (fast/table).
Also, remove the linux debug crashes from test expectations due to r81162 which should clear these up.
Add update baselines for transitions/default-timing-function due to r80806.

  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.png: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-align-08-b-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
  • platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.checksum:
  • platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/chromium-linux/svg/text/bidi-reorder-value-lists-expected.checksum: Added.
  • platform/chromium-linux/svg/text/bidi-reorder-value-lists-expected.png: Added.
  • platform/chromium-linux/svg/text/bidi-text-anchor-direction-expected.checksum: Added.
  • platform/chromium-linux/svg/text/bidi-text-anchor-direction-expected.png: Added.
  • platform/chromium-linux/svg/text/bidi-text-query-expected.checksum: Added.
  • platform/chromium-linux/svg/text/bidi-text-query-expected.png: Added.
  • platform/chromium-linux/svg/text/bidi-text-query-expected.txt: Added.
  • platform/chromium-linux/svg/text/bidi-tspans-expected.checksum: Added.
  • platform/chromium-linux/svg/text/bidi-tspans-expected.png: Added.
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-4-expected.checksum:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/chromium-linux/svg/text/small-fonts-2-expected.txt:
  • platform/chromium-mac/fast/table/relative-position-containment-expected.checksum: Added.
  • platform/chromium-mac/fast/table/relative-position-containment-expected.png: Added.
  • platform/chromium-mac/fast/table/relative-position-offsets-expected.checksum: Added.
  • platform/chromium-mac/fast/table/relative-position-offsets-expected.png: Added.
  • platform/chromium-mac/fast/table/relative-position-stacking-expected.checksum: Added.
  • platform/chromium-mac/fast/table/relative-position-stacking-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-container-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-container-expected.png: Added.
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-root-expected.checksum:
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/chromium-mac/svg/foreignObject/text-tref-02-b-expected.checksum: Added.
  • platform/chromium-mac/svg/foreignObject/text-tref-02-b-expected.png: Added.
  • platform/chromium-mac/svg/text/bidi-text-anchor-direction-expected.checksum: Added.
  • platform/chromium-mac/svg/text/bidi-text-anchor-direction-expected.png: Added.
  • platform/chromium-mac/svg/text/bidi-text-anchor-direction-expected.txt: Added.
  • platform/chromium-mac/svg/text/bidi-text-query-expected.checksum: Added.
  • platform/chromium-mac/svg/text/bidi-text-query-expected.png: Added.
  • platform/chromium-mac/svg/text/bidi-text-query-expected.txt: Added.
  • platform/chromium-mac/svg/text/bidi-tspans-expected.checksum: Added.
  • platform/chromium-mac/svg/text/bidi-tspans-expected.png: Added.
  • platform/chromium-mac/svg/text/bidi-tspans-expected.txt: Added.
  • platform/chromium-mac/svg/text/text-align-04-b-expected.checksum: Added.
  • platform/chromium-mac/svg/text/text-align-04-b-expected.png: Added.
  • platform/chromium-win/fast/forms/input-autofilled-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
  • platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-08-b-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Added.
  • platform/chromium-win/svg/text/bidi-reorder-value-lists-expected.checksum: Added.
  • platform/chromium-win/svg/text/bidi-reorder-value-lists-expected.png: Added.
  • platform/chromium-win/svg/text/bidi-reorder-value-lists-expected.txt: Added.
  • platform/chromium-win/svg/text/bidi-text-anchor-direction-expected.checksum: Added.
  • platform/chromium-win/svg/text/bidi-text-anchor-direction-expected.png: Added.
  • platform/chromium-win/svg/text/bidi-text-anchor-direction-expected.txt: Added.
  • platform/chromium-win/svg/text/bidi-text-query-expected.checksum: Added.
  • platform/chromium-win/svg/text/bidi-text-query-expected.png: Added.
  • platform/chromium-win/svg/text/bidi-text-query-expected.txt: Added.
  • platform/chromium-win/svg/text/bidi-tspans-expected.checksum: Added.
  • platform/chromium-win/svg/text/bidi-tspans-expected.png: Added.
  • platform/chromium-win/svg/text/bidi-tspans-expected.txt: Added.
  • platform/chromium-win/svg/text/small-fonts-2-expected.txt:
  • platform/chromium-win/svg/text/text-align-04-b-expected.txt:
  • platform/chromium-linux/transitions/default-timing-function-expected.checksum:
  • platform/chromium-linux/transitions/default-timing-function-expected.png:
  • platform/chromium-mac/transitions/default-timing-function-expected.checksum: Added.
  • platform/chromium-mac/transitions/default-timing-function-expected.png: Added.
  • platform/chromium-win/transitions/default-timing-function-expected.checksum:
  • platform/chromium-win/transitions/default-timing-function-expected.png:
  • platform/chromium/test_expectations.txt:
3:31 PM Changeset in webkit [81183] by Michael Nordman
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-15 Michael Nordman <Michael Nordman>

Reviewed by Alexey Proskuryakov.

When initiating a main resource load, let the application cache
know which frame the load is being conducted for. This patch doesn't
resolve the following bug, but the additional WebFrame parameter
should provide the chromium port with enough info to pick the
"most appropiate" cached resource.
​https://bugs.webkit.org/show_bug.cgi?id=55505

Also fixup a stale comment in stopLoadingInFrame.

  • public/WebApplicationCacheHost.h: (WebKit::WebApplicationCacheHost::willStartMainResourceRequest):
  • src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::maybeLoadMainResource): (WebCore::ApplicationCacheHost::stopLoadingInFrame):
3:26 PM Changeset in webkit [81182] by helder@sencha.com
  • 2 edits in trunk/LayoutTests

2011-03-15 Helder Correia <​helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] fast/canvas/canvas-strokeRect-gradient-shadow.html no longer fails
​https://bugs.webkit.org/show_bug.cgi?id=56413

Rect stroking uses the same code path as path stroking, which was fixed
in r80250. Therefore, the test can be removed from the Skipped list as
it now succeeds.

  • platform/qt/Skipped:
3:17 PM Changeset in webkit [81181] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebCore

2011-03-15 David Grogan <​dgrogan@chromium.org>

Reviewed by Jeremy Orlow.

Fix crash caused by Invalid call to destroyActiveDOMObject during stopActiveDOMObjects
​https://bugs.webkit.org/show_bug.cgi?id=56350

When a frame is unloaded, ScriptExecutionContext::stopActiveDOMObjects
calls stop() on each ActiveDOMObject.

Calling IDBDatabase::stop() can cause IDBDatabase to be destroyed:

  • IDBDatabase::stop() causes the chrome message dispatcher to remove its reference to IDBDatabase, which it has as type IDBDatabaseCallbacks.
  • If that reference is the last one, the IDBDatabase is destroyed.
  • Destroying an ActiveDOMObject while they are being iterated over causes a defensive crash.

This change creates a separate IDBDatabaseCallbacks object that is not
an ActiveDOMObject, so it can be destroyed by
ScriptExecutionContext::stopActiveDOMObjects.

Because the chrome message dispatcher is only used in multi-process
chromium, that's the only platform affected. Chromium browser tests
forthcoming.

  • WebCore.gypi:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::~IDBDatabase): (WebCore::IDBDatabase::setVersion): (WebCore::IDBDatabase::close): (WebCore::IDBDatabase::open):
  • storage/IDBDatabase.h:
  • storage/IDBDatabaseCallbacks.h: (WebCore::IDBDatabaseCallbacks::unRegisterDatabase):
  • storage/IDBDatabaseCallbacksImpl.cpp: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h. (WebCore::IDBDatabaseCallbacksImpl::create): (WebCore::IDBDatabaseCallbacksImpl::IDBDatabaseCallbacksImpl): (WebCore::IDBDatabaseCallbacksImpl::onVersionChange): (WebCore::IDBDatabaseCallbacksImpl::unRegisterDatabase):
  • storage/IDBDatabaseCallbacksImpl.h: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h. (WebCore::IDBDatabaseCallbacksImpl::~IDBDatabaseCallbacksImpl):
3:02 PM Changeset in webkit [81180] by levin@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-03-15 David Levin <​levin@chromium.org>

Reviewed by Adam Barth.

Links from code reviews to trac are incorrect for files in Source/WebKit.
​https://bugs.webkit.org/show_bug.cgi?id=56404

  • PrettyPatch/PrettyPatch.rb: Remove WebKit from the list of top level directories since it is now under Source.
2:48 PM Changeset in webkit [81179] by Adam Roben
  • 3 edits
    128 adds in trunk/LayoutTests

Add Windows results for tests added in r81168

The differences from the Mac results seem to be due to rounding and font differences.

  • platform/win/svg/W3C-I18N/g-dirLTR-ubNone-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
  • platform/win/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
  • platform/win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/win/svg/W3C-I18N/g-dirRTL-ubNone-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/win/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-anchor-no-markup-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-dirLTR-ubNone-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-dirRTL-ubNone-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
  • platform/win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/win/svg/W3C-I18N/tspan-direction-rtl-expected.checksum: Added.
  • platform/win/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
  • platform/win/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.checksum: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.checksum: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.checksum: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
  • platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
  • platform/win/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
  • platform/win/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
  • platform/win/svg/text/bidi-reorder-value-lists-expected.checksum: Added.
  • platform/win/svg/text/bidi-reorder-value-lists-expected.png: Added.
  • platform/win/svg/text/bidi-reorder-value-lists-expected.txt: Added.
  • platform/win/svg/text/bidi-text-anchor-direction-expected.checksum: Added.
  • platform/win/svg/text/bidi-text-anchor-direction-expected.png: Added.
  • platform/win/svg/text/bidi-text-anchor-direction-expected.txt: Added.
  • platform/win/svg/text/bidi-text-query-expected.checksum: Added.
  • platform/win/svg/text/bidi-text-query-expected.png: Added.
  • platform/win/svg/text/bidi-text-query-expected.txt: Added.
  • platform/win/svg/text/bidi-tspans-expected.checksum: Added.
  • platform/win/svg/text/bidi-tspans-expected.png: Added.
  • platform/win/svg/text/bidi-tspans-expected.txt: Added.
  • platform/win/svg/text/small-fonts-2-expected.checksum: Added.
  • platform/win/svg/text/small-fonts-2-expected.png: Added.
  • platform/win/svg/text/small-fonts-2-expected.txt:
2:42 PM Changeset in webkit [81178] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

accessibility should build in WebCore GYP build
​https://bugs.webkit.org/show_bug.cgi?id=56405

This patch changes our include/exclude strategy to more closely match
the strategy used by the Chromium GYP build system. Ideally, we'd find
a way to share more of these patterns. In the meantime, I'm going to
slowly increase the number of translation units in the project and
adjust the include/exclude filters appropriately.

  • gyp/WebCore.gyp:
2:42 PM Changeset in webkit [81177] by Nikolas Zimmermann
  • 4 edits in trunk/LayoutTests

2011-03-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

REGRESSION (r68976): Incorrect bidi rendering in SVG text
​https://bugs.webkit.org/show_bug.cgi?id=53980

Update Gtk baseline.

  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • platform/gtk/svg/text/text-align-02-b-expected.txt:
  • platform/gtk/svg/text/text-spacing-01-b-expected.txt:
2:39 PM Changeset in webkit [81176] by Nikolas Zimmermann
  • 5 edits
    47 adds in trunk/LayoutTests

2011-03-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

REGRESSION (r68976): Incorrect bidi rendering in SVG text
​https://bugs.webkit.org/show_bug.cgi?id=53980

Update Mac Leopard baseline.

  • platform/mac-leopard/svg/W3C-I18N: Added.
  • platform/mac-leopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/mac-leopard/svg/text/bidi-text-anchor-direction-expected.txt: Added.
  • platform/mac-leopard/svg/text/bidi-text-query-expected.txt: Added.
  • platform/mac-leopard/svg/text/bidi-tspans-expected.txt: Added.
  • platform/mac-leopard/svg/text/font-size-below-point-five-expected.txt:
  • platform/mac-leopard/svg/text/small-fonts-2-expected.txt:
2:37 PM Changeset in webkit [81175] by tony@chromium.org
  • 2 edits
    1 add in trunk/Source/WebKit/chromium

2011-03-15 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

[chromium] add a build target to create a grd file with devtool resources
​https://bugs.webkit.org/show_bug.cgi?id=56335

Reland with a fix to avoid really long command lines on Windows.

  • WebKit.gyp:
  • scripts/generate_devtools_grd.py: Added.
2:20 PM Changeset in webkit [81174] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Forgot to save a modification to this file when committing.

  • WebCoreSupport/WebKeyGenerator.mm: Changed "Apple Computer" to "Apple" in copyright header.
2:15 PM Changeset in webkit [81173] by ap@apple.com
  • 25 edits
    2 moves
    2 deletes in trunk

Reviewed by Darin Adler.

REGRESSION (WebKit2): keygen element doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=56402
<rdar://problem/9006545>

Covered by existing regresison tests.

  • English.lproj/Localizable.strings:
  • WebCore.exp.in: Removed WebCoreKeyGenerator, which no longer exists. Added _wkSignedPublicKeyAndChallengeString, so that this WKSI function could be used in WebCore.
  • platform/mac/SSLKeyGeneratorMac.mm: Removed.
  • platform/mac/WebCoreKeyGenerator.h: Removed.
  • platform/mac/WebCoreKeyGenerator.m: Removed.
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • WebCore.xcodeproj/project.pbxproj: Renamed SSLKeyGeneratorMac.mm to .cpp, as it doesn't use any Objective C any more. Removed WebCoreKeyGenerator, as we no longer need an interface to WebKit.
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp: (WebCore::keygenMenuItem512): (WebCore::keygenMenuItem1024): (WebCore::keygenMenuItem2048): (WebCore::keygenKeychainItemName):
  • platform/LocalizedStrings.h: Added strings used by keygen element, now that the code using them is in WebCore.
  • platform/mac/SSLKeyGeneratorMac.cpp: Copied from Source/WebCore/platform/mac/SSLKeyGeneratorMac.mm. (WebCore::getSupportedKeySizes): (WebCore::signedPublicKeyAndChallengeString): Moved the code from WebKit. There is never any need to provide implementation at runtime, like old code was doing.
  • platform/win/SSLKeyGeneratorWin.cpp: (WebCore::WebCore::getSupportedKeySizes): Added a FIXME about localization. Note that Safari for Windows doesn't support keygen.
2:02 PM Changeset in webkit [81172] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Fix clang build.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/GraphicsLayer.h:
1:40 PM Changeset in webkit [81171] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

2011-03-15 Simon Fraser <Simon Fraser>

Fix Lion build after r81161.

Pass the PlatformCALayer down into drawLayerContents()
so we can use its acceleratesDrawing() method.

  • platform/graphics/mac/WebLayer.h:
  • platform/graphics/mac/WebLayer.mm: (drawLayerContents): (-[WebLayer drawInContext:]):
  • platform/graphics/mac/WebTiledLayer.mm: (-[WebTiledLayer drawInContext:]):
1:39 PM Changeset in webkit [81170] by Nikolas Zimmermann
  • 4 edits in trunk/LayoutTests

2011-03-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

REGRESSION (r68976): Incorrect bidi rendering in SVG text
​https://bugs.webkit.org/show_bug.cgi?id=53980

Update Qt baseline, still waiting for gtk/leopard/win7/winxp.

  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/qt/svg/text/text-align-02-b-expected.txt:
  • platform/qt/svg/text/text-align-04-b-expected.txt:
1:17 PM Changeset in webkit [81169] by commit-queue@webkit.org
  • 5 edits in trunk/Source

2011-03-15 Alok priyadarshi <​alokp@chromium.org>

Reviewed by James Robinson.

Valgrind error due to uninitialized PluginLayerChromium::m_textureId
​https://bugs.webkit.org/show_bug.cgi?id=56390

  • platform/graphics/chromium/PluginLayerChromium.cpp: (WebCore::PluginLayerChromium::PluginLayerChromium):
  • platform/graphics/chromium/PluginLayerChromium.h: (WebCore::PluginLayerChromium::textureId):

2011-03-15 Alok priyadarshi <​alokp@chromium.org>

Reviewed by James Robinson.

Valgrind error due to uninitialized PluginLayerChromium::m_textureId
​https://bugs.webkit.org/show_bug.cgi?id=56390

  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::setBackingTextureId): (WebKit::WebPluginContainerImpl::platformLayer):
1:15 PM Changeset in webkit [81168] by Nikolas Zimmermann
  • 24 edits
    6 moves
    236 adds in trunk

2011-03-14 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

REGRESSION (r68976): Incorrect bidi rendering in SVG text
​https://bugs.webkit.org/show_bug.cgi?id=53980

rework the test engine or SVG "text-intro" tests so we can turn them back on
​https://bugs.webkit.org/show_bug.cgi?id=6524

svg/W3C-SVG-1.1/text-intro-0*.svg fail when MS Office fonts are present
​https://bugs.webkit.org/show_bug.cgi?id=11662

svg/batik/text/textBiDi.svg failing
​https://bugs.webkit.org/show_bug.cgi?id=17392

SVG bidi examples at w3C I18N WG tutorials are not rendered correctly.
​https://bugs.webkit.org/show_bug.cgi?id=24374

Implement proper bidirectionality support for SVG text. The actual bidi support is working
fine, the problem is that SVG demands to reorder x/y/dx/dy/rotate value lists, in order to
main correspondance between the attributes and the potentially reordered text.

Land a new suite of SVG & i18n tests, covering unicode-bidi/direction and text-anchor support
with BiDi text (Arabic mixed with Latin) in LayoutTests/svg/W3C-I18N.

Enable long-disabled SVG BiDi tests, and international fonts support in svg/W3C-SVG-1.1
by providing a SVGFont replacment, replacing the need for MS Office Fonts to be present.
These tests have some value and we'd like to have them enabled again.

  • platform/mac/svg/W3C-I18N: Added.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-direction-ltr-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-direction-ltr-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Added.
  • platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.checksum: Added.
  • platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
  • platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-08-b-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Added.
  • platform/mac/svg/text/bidi-reorder-value-lists-expected.checksum: Added.
  • platform/mac/svg/text/bidi-reorder-value-lists-expected.png: Added.
  • platform/mac/svg/text/bidi-reorder-value-lists-expected.txt: Added.
  • platform/mac/svg/text/bidi-text-anchor-direction-expected.checksum: Added.
  • platform/mac/svg/text/bidi-text-anchor-direction-expected.png: Added.
  • platform/mac/svg/text/bidi-text-anchor-direction-expected.txt: Added.
  • platform/mac/svg/text/bidi-text-query-expected.checksum: Added.
  • platform/mac/svg/text/bidi-text-query-expected.png: Added.
  • platform/mac/svg/text/bidi-text-query-expected.txt: Added.
  • platform/mac/svg/text/bidi-tspans-expected.checksum: Added.
  • platform/mac/svg/text/bidi-tspans-expected.png: Added.
  • platform/mac/svg/text/bidi-tspans-expected.txt: Added.
  • platform/mac/svg/text/small-fonts-2-expected.txt:
  • platform/mac/svg/text/text-align-02-b-expected.txt:
  • platform/mac/svg/text/text-align-04-b-expected.txt:
  • svg/W3C-I18N: Added.
  • svg/W3C-I18N/NOTE: Added.
  • svg/W3C-I18N/g-dirLTR-ubNone.svg: Added.
  • svg/W3C-I18N/g-dirLTR-ubOverride.svg: Added.
  • svg/W3C-I18N/g-dirRTL-ubNone.svg: Added.
  • svg/W3C-I18N/g-dirRTL-ubOverride.svg: Added.
  • svg/W3C-I18N/resources: Added.
  • svg/W3C-I18N/resources/img1.png: Added.
  • svg/W3C-I18N/resources/img11.png: Added.
  • svg/W3C-I18N/resources/img12.png: Added.
  • svg/W3C-I18N/resources/img13.png: Added.
  • svg/W3C-I18N/resources/img14.png: Added.
  • svg/W3C-I18N/resources/img15.png: Added.
  • svg/W3C-I18N/resources/img16.png: Added.
  • svg/W3C-I18N/resources/img17.png: Added.
  • svg/W3C-I18N/resources/img18.png: Added.
  • svg/W3C-I18N/resources/img19.png: Added.
  • svg/W3C-I18N/resources/img2.png: Added.
  • svg/W3C-I18N/resources/img20.png: Added.
  • svg/W3C-I18N/resources/img21.png: Added.
  • svg/W3C-I18N/resources/img24.png: Added.
  • svg/W3C-I18N/resources/img25.png: Added.
  • svg/W3C-I18N/resources/img3.png: Added.
  • svg/W3C-I18N/resources/img4.png: Added.
  • svg/W3C-I18N/resources/img5.png: Added.
  • svg/W3C-I18N/resources/tanchor-left-right.png: Added.
  • svg/W3C-I18N/resources/tanchor-left.png: Added.
  • svg/W3C-I18N/resources/tanchor-right.png: Added.
  • svg/W3C-I18N/text-anchor-dirLTR-anchorEnd.svg: Added.
  • svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle.svg: Added.
  • svg/W3C-I18N/text-anchor-dirLTR-anchorStart.svg: Added.
  • svg/W3C-I18N/text-anchor-dirNone-anchorEnd.svg: Added.
  • svg/W3C-I18N/text-anchor-dirNone-anchorMiddle.svg: Added.
  • svg/W3C-I18N/text-anchor-dirNone-anchorStart.svg: Added.
  • svg/W3C-I18N/text-anchor-dirRTL-anchorEnd.svg: Added.
  • svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle.svg: Added.
  • svg/W3C-I18N/text-anchor-dirRTL-anchorStart.svg: Added.
  • svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd.svg: Added.
  • svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle.svg: Added.
  • svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart.svg: Added.
  • svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd.svg: Added.
  • svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle.svg: Added.
  • svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart.svg: Added.
  • svg/W3C-I18N/text-anchor-no-markup.svg: Added.
  • svg/W3C-I18N/text-dirLTR-ubNone.svg: Added.
  • svg/W3C-I18N/text-dirLTR-ubOverride.svg: Added.
  • svg/W3C-I18N/text-dirRTL-ubNone.svg: Added.
  • svg/W3C-I18N/text-dirRTL-ubOverride.svg: Added.
  • svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context.svg: Added.
  • svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context.svg: Added.
  • svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context.svg: Added.
  • svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context.svg: Added.
  • svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context.svg: Added.
  • svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context.svg: Added.
  • svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context.svg: Added.
  • svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context.svg: Added.
  • svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context.svg: Added.
  • svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context.svg: Added.
  • svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context.svg: Added.
  • svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context.svg: Added.
  • svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context.svg: Added.
  • svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context.svg: Added.
  • svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context.svg: Added.
  • svg/W3C-I18N/tspan-direction-ltr.svg: Added.
  • svg/W3C-I18N/tspan-direction-rtl.svg: Added.
  • svg/W3C-SVG-1.1-SE/text-intro-02-b.svg: Added.
  • svg/W3C-SVG-1.1-SE/text-intro-05-t.svg: Added.
  • svg/W3C-SVG-1.1-SE/text-intro-09-b.svg: Added.
  • svg/W3C-SVG-1.1/resources/SVGExotic.svg: Added.
  • svg/W3C-SVG-1.1/text-align-08-b.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-align-08-b.svg-disabled.
  • svg/W3C-SVG-1.1/text-align-08-b.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/text-fonts-03-t.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-fonts-03-t.svg-disabled.
  • svg/W3C-SVG-1.1/text-fonts-03-t.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/text-intro-01-t.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-intro-01-t.svg-disabled.
  • svg/W3C-SVG-1.1/text-intro-01-t.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/text-intro-02-b.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-intro-02-b.svg-disabled.
  • svg/W3C-SVG-1.1/text-intro-02-b.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/text-intro-03-b.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-intro-03-b.svg-disabled.
  • svg/W3C-SVG-1.1/text-intro-03-b.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/text-intro-04-t.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-intro-04-t.svg-disabled.
  • svg/W3C-SVG-1.1/text-intro-04-t.svg-disabled: Removed.
  • svg/custom/glyph-transformation-with-hkern-expected.txt:
  • svg/text/bidi-reorder-value-lists.svg: Added.
  • svg/text/bidi-text-anchor-direction.svg: Added.
  • svg/text/bidi-text-query.svg: Added.
  • svg/text/bidi-tspans.svg: Added.

2011-03-14 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

REGRESSION (r68976): Incorrect bidi rendering in SVG text
​https://bugs.webkit.org/show_bug.cgi?id=53980

rework the test engine or SVG "text-intro" tests so we can turn them back on
​https://bugs.webkit.org/show_bug.cgi?id=6524

svg/W3C-SVG-1.1/text-intro-0*.svg fail when MS Office fonts are present
​https://bugs.webkit.org/show_bug.cgi?id=11662

svg/batik/text/textBiDi.svg failing
​https://bugs.webkit.org/show_bug.cgi?id=17392

SVG bidi examples at w3C I18N WG tutorials are not rendered correctly.
​https://bugs.webkit.org/show_bug.cgi?id=24374

Implement proper bidirectionality support for SVG text.

BiDi didn't work properly until now, because the x/y/dx/dy/rotate value lists are stored in logical order (aka. in
the order the characters appear in the markup), and when laying out bidi text, we associated the current character
in visual order with the current x/y/dx/dy/rotate value in logical order, messing up RTL text layout.
The BiDi algorithm itself, inherited by RenderBlockLineLayout, works just fine, the inline box tree is correct.

Long story:
Before the inline box tree is created, SVGTextLayoutAttributesBuilder builds a list of x/y/dx/dy/rotate/<text metrics>
for each RenderSVGInlineText* object, called SVGTextLayoutAttributes. This happens in logical order, as specified in
the markup. <text x="10 20" y="10">abcdef</text> creates a SVGTextLayoutAttributes object in the renderer associated with
"abcdef" that contains (10, 20) for x, (10) for y, the dx/dy/rotate lists are empty, and the SVGTextMetrics list holds 6
width/height values for each of the glyphs (and some other infromation, see SVGTextMetrics class).
The SVGTextLayoutAttributes object is _used by_ RenderBlockLineLayout when applying the BiDi algorithm as SVG demands
that BiDi reordering does not happen across text chunks (a text chunk is defined by an absolute position, eg. x="10").

To summarize: SVGTextLayoutAttributes are stored in all RenderSVGInlineText renderers, caching the metrics of all
characters, their position based on the DOM attributes x/y/dx/dy/rotate. Using that information it's possible to
determine whether a position starts a new text chunk, and that's used by RenderBlockLineLayout to create the
inline box tree, in _visual order_, as it will appear on screen.

After the inline box tree is created, the SVGRootInlineBox traverses its children in visual order and feeds the
found text boxes to SVGTextLayoutEngine, which lays out the text on a line or a path, according to SVG text layout
rules. For each character of the passed in InlineTextBox, it determines the x/y/dx/dy/rotate value, and the position
in the <text metrics> list of the renderer. The problem here is that the passed in text boxes are in visual order,
the x/y/.. lists are all in logical order.

Example: <text direction="rtl" unicde-bidi="bidi-override" x="10 20">abcdef</text>, reverse the text direction:

the visual order now is: "fedcba", where 'f' should be associated with x="10" and 'e' with x="20".

Fix that problem, by computing a list of text boxes in _logical_ order in advance and pass it to SVGTextLayoutEngine,
before it starts processing the boxes in visual order, fed by SVGRootInlineBox. When laying oout text, we can now
process text in visual order, but grab the x/y/.. coordinates from the renderer in logical order.

Some more work was needed to truly fix Arabic. The SVGTextLayoutAttributesBuilder measured all characters isolated,
which is not a problem with latin text, but results in wrong advances for Arabic text, as isolated forms, instead of
shaped forms are measured. This broke text-anchor support, text queries on Arabic text etc. Fixed now, covered by
dozens of new tests.

Tests: svg/W3C-I18N/g-dirLTR-ubNone.svg

svg/W3C-I18N/g-dirLTR-ubOverride.svg
svg/W3C-I18N/g-dirRTL-ubNone.svg
svg/W3C-I18N/g-dirRTL-ubOverride.svg
svg/W3C-I18N/text-anchor-dirLTR-anchorEnd.svg
svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle.svg
svg/W3C-I18N/text-anchor-dirLTR-anchorStart.svg
svg/W3C-I18N/text-anchor-dirNone-anchorEnd.svg
svg/W3C-I18N/text-anchor-dirNone-anchorMiddle.svg
svg/W3C-I18N/text-anchor-dirNone-anchorStart.svg
svg/W3C-I18N/text-anchor-dirRTL-anchorEnd.svg
svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle.svg
svg/W3C-I18N/text-anchor-dirRTL-anchorStart.svg
svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd.svg
svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle.svg
svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart.svg
svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd.svg
svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle.svg
svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart.svg
svg/W3C-I18N/text-anchor-no-markup.svg
svg/W3C-I18N/text-dirLTR-ubNone.svg
svg/W3C-I18N/text-dirLTR-ubOverride.svg
svg/W3C-I18N/text-dirRTL-ubNone.svg
svg/W3C-I18N/text-dirRTL-ubOverride.svg
svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context.svg
svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context.svg
svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context.svg
svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context.svg
svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context.svg
svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context.svg
svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context.svg
svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context.svg
svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context.svg
svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context.svg
svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context.svg
svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context.svg
svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context.svg
svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context.svg
svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context.svg
svg/W3C-I18N/tspan-direction-ltr.svg
svg/W3C-I18N/tspan-direction-rtl.svg
svg/W3C-SVG-1.1-SE/text-intro-02-b.svg
svg/W3C-SVG-1.1-SE/text-intro-05-t.svg
svg/W3C-SVG-1.1-SE/text-intro-09-b.svg
svg/W3C-SVG-1.1/text-align-08-b.svg
svg/W3C-SVG-1.1/text-fonts-03-t.svg
svg/W3C-SVG-1.1/text-intro-01-t.svg
svg/W3C-SVG-1.1/text-intro-02-b.svg
svg/W3C-SVG-1.1/text-intro-03-b.svg
svg/W3C-SVG-1.1/text-intro-04-t.svg
svg/text/bidi-reorder-value-lists.svg
svg/text/bidi-text-anchor-direction.svg
svg/text/bidi-text-query.svg
svg/text/bidi-tspans.svg

  • rendering/RenderBlockLineLayout.cpp: Remove hack that forced LTR support when unicode-bidi="normal" and handling SVG text. (WebCore::RenderBlock::determineStartPosition):
  • rendering/svg/SVGInlineTextBox.cpp: s/fragment.positionListOffset/fragment.characterOffset/ (WebCore::SVGInlineTextBox::offsetForPositionInFragment): (WebCore::SVGInlineTextBox::constructTextRun): (WebCore::SVGInlineTextBox::mapStartEndPositionsIntoFragmentCoordinates):
  • rendering/svg/SVGRenderTreeAsText.cpp: Ditto. (WebCore::writeSVGInlineTextBox):
  • rendering/svg/SVGRootInlineBox.cpp: Add new buildTextBoxListInLogicalOrder(), collecting all text boxes recursively in logical order (aka. as specified in markup).

This is needed as we have to process x/y/dx/dy/rotate value lists of text/tspan/.. elements in logical order, not in visual
order as the characters are presented on screen.

(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
(WebCore::SVGRootInlineBox::buildTextBoxListInLogicalOrder):
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):

  • rendering/svg/SVGRootInlineBox.h:
  • rendering/svg/SVGTextChunk.cpp: Cleanup code, minimize SVGTextChunks memory consumption. (WebCore::SVGTextChunk::SVGTextChunk): A text chunk now know whether its base progress direction is left-to-right or right-to-left. (WebCore::SVGTextChunk::calculateLength): (WebCore::SVGTextChunk::calculateTextAnchorShift): Make text-anchor direction aware. text-anchor="start/end" meaning depends on the context (ltr vs. rtl).
  • rendering/svg/SVGTextChunk.h: Adapt code, merging three members into a bitfield. (WebCore::SVGTextChunk::isVerticalText): (WebCore::SVGTextChunk::hasDesiredTextLength): (WebCore::SVGTextChunk::hasTextAnchor): (WebCore::SVGTextChunk::hasLengthAdjustSpacing): (WebCore::SVGTextChunk::hasLengthAdjustSpacingAndGlyphs):
  • rendering/svg/SVGTextChunkBuilder.cpp: Adapt to SVGTextChunk code changes. (WebCore::SVGTextChunkBuilder::addTextChunk): (WebCore::SVGTextChunkBuilder::processTextChunk):
  • rendering/svg/SVGTextFragment.h: Add metricsListOffset, needed only while laying out text. (WebCore::SVGTextFragment::SVGTextFragment): Rename positionListOffset to characterOffset, as it describes an offset in the textRenderer->characters() array.
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp (WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes): Fix measuring Arabic text in LTR/RTL modes. Assure that each SVGTextMetrics object

that we cache, refers to the _rendered_ character. For Arabic text that means, that we're
measuring the shaped width of the glyph, not the glyph in its isolated form. Without that
fix reordering boxes containing Arabic is wrong.

  • rendering/svg/SVGTextLayoutEngine.cpp: SVGTextLayoutEngine is fed with text boxes to be laid out in _visual_ order, left-to-right, after the BiDi algorithm

has been applied by RenderBlockLineLayout to create the inline box tree. The coordinates lists x/y/dx/dy/rotate have
to be processed in _logical_ order. SVGRootInlineBox now passes a list of text boxes in logical order to SVGTextLayoutEngine,
to assure it grabs the coordinates from the correct InlineTextBox. See examples at the top of the ChangeLog.

(WebCore::SVGTextLayoutEngine::SVGTextLayoutEngine):
(WebCore::SVGTextLayoutEngine::recordTextFragment): No need to measure text here anymore, SVGTextLayoutAttributesBuilder now provides exact advances for each glyph.

The width of a SVGTextFragment is always equal to the sum of each glyph advance. (This was not the case for
Arabic until now.)

(WebCore::SVGTextLayoutEngine::finalizeTransformMatrices):
(WebCore::SVGTextLayoutEngine::nextLogicalBoxAndOffset): Computes the next logical box and the offset to the next coordinate value in its position list.
(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):

  • rendering/svg/SVGTextLayoutEngine.h: Add CharacterRange helper struct. (WebCore::SVGTextLayoutEngine::CharacterRange::CharacterRange):
  • rendering/svg/SVGTextMetrics.cpp: Remove unused measureAllCharactersIndividually() method. (WebCore::constructTextRun): Pass direction and unicode-bidi="override" values to the TextRun, otherwhise LTR is always asumed.
  • rendering/svg/SVGTextMetrics.h: (WebCore::SVGTextMetrics::setWidth): Add private setter, only SVGTextLayoutAttributesBuilder is allowed to modify the metrics (to fix up glyph widths for Arabic).
  • rendering/svg/SVGTextQuery.cpp: s/fragment.positionListOffset/fragment.characterOffset/ (WebCore::SVGTextQuery::subStringLengthCallback): (WebCore::SVGTextQuery::startPositionOfCharacterCallback): (WebCore::SVGTextQuery::endPositionOfCharacterCallback): (WebCore::calculateGlyphBoundaries):
1:12 PM Changeset in webkit [81167] by enne@google.com
  • 2 edits in branches/chromium/696/Source/WebCore

Revert 81151 - Merge 80887 - 2011-03-11 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Compositor uses too much texture memory for scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=56212

Compositor invalidations can be off the page (and very large), but
scrollbars only need to care about the invalidation that's visible.
The large invalidation was causing the tiler layer size to grow
needlessly larger than the scrollbar.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::invalidateRootLayerRect):

TBR=​enne@google.com

TBR=​enne@google.com

12:52 PM Changeset in webkit [81166] by sergio@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix make distcheck for 1.3.13 release
​https://bugs.webkit.org/show_bug.cgi?id=56371

No new tests as this is a build fix.

  • GNUmakefile.am: added a couple of missing files.
12:36 PM Changeset in webkit [81165] by leviw@chromium.org
  • 17 edits in trunk/Source/WebCore

2011-03-08 Levi Weintraub <​leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Get rid of firstDeepEditingPositionForNode and lastDeepEditingPositionForNode
​https://bugs.webkit.org/show_bug.cgi?id=52642

Replacing calls to first/lastDeepEditingPositionForNode with calls to their analogous
functions that create new positions. Also fixing various parts of editing code that
incorrectly handled the new positions now being created.

No new tests as this is refactoring/cleanup.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionRange):
  • dom/Position.cpp: (WebCore::Position::parentAnchoredEquivalent): (WebCore::Position::previous): (WebCore::Position::next): (WebCore::Position::atFirstEditingPositionForNode): (WebCore::Position::atLastEditingPositionForNode): (WebCore::Position::upstream): (WebCore::Position::isCandidate): (WebCore::Position::getInlineBoxAndOffset):
  • dom/Position.h: (WebCore::operator==):
  • dom/PositionIterator.cpp: (WebCore::PositionIterator::operator Position):
  • editing/ApplyBlockElementCommand.cpp: (WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
  • editing/DeleteSelectionCommand.cpp: (WebCore::isTableCellEmpty): (WebCore::DeleteSelectionCommand::removeNode):
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::unlistifyParagraph):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::selectionFromContentsOfNode): (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
  • editing/htmlediting.cpp: (WebCore::firstEditablePositionAfterPositionInRoot): (WebCore::lastEditablePositionBeforePositionInRoot): (WebCore::enclosingEmptyListItem):
  • editing/htmlediting.h:
  • editing/visible_units.cpp: (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::startOfEditableContent): (WebCore::endOfEditableContent):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint):
12:22 PM Changeset in webkit [81164] by brettw@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-15 Brett Wilson <​brettw@chromium.org>

Reviewed by Adam Barth

Make WebConsoleMessage properly respect the log level.
​https://bugs.webkit.org/show_bug.cgi?id=56386

  • public/WebConsoleMessage.h: (WebKit::WebConsoleMessage::WebConsoleMessage):
11:53 AM Changeset in webkit [81163] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Attempted build fix.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::cancelAnimations):

11:45 AM Changeset in webkit [81162] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=56329

Reviewed by Dave Levin.

Fix FontCache problems on Linux. Make sure not to mutate the platform data passed in to SimpleFontData's
constructor. Change this code to match Mac and to set the new m_hasVerticalGlyphs boolean instead of
mutating orientation.

  • platform/graphics/chromium/SimpleFontDataLinux.cpp:

(WebCore::SimpleFontData::platformInit):

11:42 AM Changeset in webkit [81161] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

2011-03-15 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Disable ShadowBlur shadow drawing in accelerated contexts
​https://bugs.webkit.org/show_bug.cgi?id=56392

When drawing into a graphics context that is accelerated, don't use
ShadowBlur, because it may be slower.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::fillRectWithRoundedHole): (WebCore::GraphicsContext::setIsCALayerContext): (WebCore::GraphicsContext::isCALayerContext): (WebCore::GraphicsContext::setIsAcceleratedContext): (WebCore::GraphicsContext::isAcceleratedContext):
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
  • platform/graphics/mac/WebLayer.mm: (drawLayerContents):
11:39 AM Changeset in webkit [81160] by andersca@apple.com
  • 2 edits in trunk/Tools

Try to fix the Windows build.

  • DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:

(NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):

11:30 AM Changeset in webkit [81159] by Beth Dakin
  • 21 edits in trunk/Source

Source/WebCore: Fix for <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%

Reviewed by Simon Fraser.

Tell the ScrollAnimator to cancelAnimations() since we are navigating to a new
page.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted):

Scroll animations should be suspended if the FrameLoadState is anything but
complete.

  • page/FrameView.cpp:

(WebCore::FrameView::shouldSuspendScrollAnimations):

  • page/FrameView.h:
  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::shouldSuspendScrollAnimations):

  • rendering/RenderDataGrid.cpp:

(WebCore::RenderDataGrid::shouldSuspendScrollAnimations):

  • rendering/RenderDataGrid.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldSuspendScrollAnimations):

  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::shouldSuspendScrollAnimations):

  • rendering/RenderListBox.h:

New virtual function cancelAnimations() is only needed on the Mac, so the base
class is empty.

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::cancelAnimations):

ScrollAnimatorMac needs to keep track of whether the page has been scrolled since
it started loading. If so, we will override optimizations that wait for the
FrameLoadState to be complete before animating scrollbars.

  • platform/mac/ScrollAnimatorMac.h:

(WebCore::ScrollAnimatorMac::haveScrolledSincePageLoad):

If the scrollbar animations should be suspended, we start a timer to make sure
that we do flash the scrollbars. Animating the scrollbars is expensive, so this is
both a performance optimization and a UI enhancement since the scrollbar won't
jump around nearly as much on a page load.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterDelegate cancelAnimations]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scroll):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::cancelAnimations):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
(WebCore::ScrollAnimatorMac::startScrollbarPaintTimer):
(WebCore::ScrollAnimatorMac::scrollbarPaintTimerIsActive):
(WebCore::ScrollAnimatorMac::stopScrollbarPaintTimer):
(WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):

New WebCoreSystemInterface function to force the scrollbars to flash

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac: WebKit part of <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%

Reviewed by Simon Fraser.

New WebKitystemInterface function to force the scrollbars to flash

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2: WebKit2 part of <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%

Reviewed by Simon Fraser.

New WebKitystemInterface function to force the scrollbars to flash

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

11:25 AM Changeset in webkit [81158] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-03-15 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

Remove stale comment at RenderStyle::diff.
​https://bugs.webkit.org/show_bug.cgi?id=56387

  • rendering/style/RenderStyle.cpp: Removed comment.
11:23 AM Changeset in webkit [81157] by andersca@apple.com
  • 14 edits
    3 adds in trunk

2011-03-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Make sure that NP_Shutdown is always the last NPP function called
​https://bugs.webkit.org/show_bug.cgi?id=56391
<rdar://problem/8989902>

Make sure to always increment the load count whenever a web process connection
is opened to a plug-in process, and decrement it when the last web process connection
goes away.

  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::createWebProcessConnection): (WebKit::PluginProcess::startShutdownTimerIfNecessary):
  • Shared/Plugins/Netscape/NetscapePluginModule.cpp:
  • Shared/Plugins/Netscape/NetscapePluginModule.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::NetscapePlugin): (WebKit::NetscapePlugin::~NetscapePlugin):

2011-03-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Make sure that NP_Shutdown is always the last NPP function called
​https://bugs.webkit.org/show_bug.cgi?id=56391
<rdar://problem/8989902>

Add test.

  • plugins/npruntime/np-deallocate-called-before-np-shutdown-expected.txt: Added.
  • plugins/npruntime/np-deallocate-called-before-np-shutdown.html: Added.

2011-03-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Make sure that NP_Shutdown is always the last NPP function called
​https://bugs.webkit.org/show_bug.cgi?id=56391

Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: (PluginTest::PluginTest): (PluginTest::NP_Shutdown): (PluginTest::registerNPShutdownFunction):
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  • DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added. (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown): (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject): (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty): (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty): (NPDeallocateCalledBeforeNPShutdown::NPP_New): (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue): (NPDeallocateCalledBeforeNPShutdown::shutdown):
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NP_Shutdown):
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am:
11:22 AM Changeset in webkit [81156] by ddkilzer@apple.com
  • 4 edits in trunk/Source/WebCore

<​http://webkit.org/b/56381> Objective-C classes should be typedef-ed as structs (not void*) in C++

Reviewed by Simon Fraser.

Typedef-ing Objective-C classes as void* for pure C++ makes it
easier for bugs to creep in because compilers can't do any type
checking for void pointers.

  • platform/graphics/GraphicsContext3D.h: Changed typedef

declarations for CALayer and WebGLLayer from void* to structs.
(WebCore::GraphicsContext3D::platformLayer): Changed
static_cast<CALayer*> to reinterpret_cast<CALayer*> now that
CALayer and WebGLLayer are not void pointers.

  • platform/graphics/GraphicsLayer.h: Changed typedef declaration

for PlatformLayer from void* to struct CALayer.

  • platform/graphics/ca/PlatformCAAnimation.h: Changed typedef

declaration for CAPropertyAnimation from void* to a struct.
Extracted typdef for PlatformAnimationRef.

11:02 AM Changeset in webkit [81155] by commit-queue@webkit.org
  • 19 edits
    3 adds in trunk

2011-03-15 Ilya Sherman <​isherman@chromium.org>

Reviewed by Tony Chang.

Autofilled form elements are assigned fixed background color but not text color
​https://bugs.webkit.org/show_bug.cgi?id=48382

  • fast/forms/input-autofilled-expected.txt: Added.
  • fast/forms/input-autofilled.html: Added.
  • platform/win/fast/forms/input-autofilled-expected.txt: Added.

2011-03-15 Ilya Sherman <​isherman@chromium.org>

Reviewed by Tony Chang.

Autofilled form elements are assigned fixed background color but not text color
​https://bugs.webkit.org/show_bug.cgi?id=48382

Test: fast/forms/input-autofilled.html

  • css/html.css: (input:-webkit-autofill): Added foreground color: #000000
  • css/wml.css: (input:-webkit-autofill): Added foreground color: #000000

2011-03-15 Ilya Sherman <​isherman@chromium.org>

Reviewed by Tony Chang.

Autofilled form elements are assigned fixed background color but not text color
​https://bugs.webkit.org/show_bug.cgi?id=48382

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setAutofilled): Added.
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-03-15 Ilya Sherman <​isherman@chromium.org>

Reviewed by Tony Chang.

Autofilled form elements are assigned fixed background color but not text color
​https://bugs.webkit.org/show_bug.cgi?id=48382

  • DOM/WebDOMOperations.mm: (-[DOMHTMLInputElement _setAutofilled:]): Added (wrapper).
  • DOM/WebDOMOperationsPrivate.h:

2011-03-15 Ilya Sherman <​isherman@chromium.org>

Reviewed by Tony Chang.

Autofilled form elements are assigned fixed background color but not text color
​https://bugs.webkit.org/show_bug.cgi?id=48382

  • DumpRenderTree/LayoutTestController.cpp: (setAutofilledCallback): Added. (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setAutofilled): Added.
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAutofilled): Added.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setAutofilled): Added. (LayoutTestController::setValueForUser): Style tweak.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAutofilled): Added (stub).
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setAutofilled): Added (stub).
11:02 AM Changeset in webkit [81154] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix broken assert in new code.

Reviewed by Sam Weinig.

  • dfg/DFGAliasTracker.h:

(JSC::DFG::AliasTracker::recordPutByVal):

  • recordPutByVal is called for both PutByVal & PutByValAlias.
10:57 AM Changeset in webkit [81153] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Removed redundant code from BytecodeGenerator.

Rubber stamped by Sam Weinig.

  • bytecompiler/BytecodeGenerator.cpp:
  • bytecompiler/BytecodeGenerator.h:
    • delete uncalled code missed when reparsing was removed.
10:56 AM Changeset in webkit [81152] by tony@chromium.org
  • 2 edits
    1 delete in trunk/Source/WebKit/chromium

2011-03-15 Tony Chang <​tony@chromium.org>

Revert r81147 and r81149, broke the chromium win build.

  • WebKit.gyp:
  • scripts/generate_devtools_grd.py: Removed.
10:52 AM Changeset in webkit [81151] by enne@google.com
  • 2 edits in branches/chromium/696/Source/WebCore

Merge 80887 - 2011-03-11 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Compositor uses too much texture memory for scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=56212

Compositor invalidations can be off the page (and very large), but
scrollbars only need to care about the invalidation that's visible.
The large invalidation was causing the tiler layer size to grow
needlessly larger than the scrollbar.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::invalidateRootLayerRect):

TBR=​enne@google.com

10:51 AM Changeset in webkit [81150] by Adam Roben
  • 2 edits in trunk/Source/WebKit/mac

2011-03-15 Adam Roben <Adam Roben>

Fix a leak in WebStorageTrackerClient::dispatchDidModifyOrigin

Fixes <​http://webkit.org/b/56385> SecurityOrigin leaks seen in
WebStorageTrackerClient::dispatchDidModifyOrigin

Reviewed by Antti Koivisto.

  • Storage/WebStorageTrackerClient.mm: (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): Adopt the reference passed to us by dispatchDidModifyOrigin. (WebStorageTrackerClient::dispatchDidModifyOrigin): Added a comment and removed an unnecessary cast.
10:49 AM Changeset in webkit [81149] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-15 Tony Chang <​tony@chromium.org>

Fix chromium build using python 2.5 (with statement).

  • scripts/generate_devtools_grd.py:
10:47 AM Changeset in webkit [81148] by enne@google.com
  • 2 edits in branches/chromium/696/Source/WebCore

Merge 80824 - 2011-03-10 Chris Guillory <​chris.guillory@google.com>

Reviewed by James Robinson.

Fix for Coverity discovered NO_EFFECT (self-assign) defect.
​https://bugs.webkit.org/show_bug.cgi?id=54143

  • platform/graphics/gpu/TilingData.cpp: (WebCore::TilingData::setMaxTextureSize):

TBR=​enne@google.com

10:40 AM Changeset in webkit [81147] by tony@chromium.org
  • 2 edits
    1 add in trunk/Source/WebKit/chromium

2011-03-15 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

[chromium] add a build target to create a grd file with devtool resources
​https://bugs.webkit.org/show_bug.cgi?id=56335

This is the webkit side of the fix for
​http://code.google.com/p/chromium/issues/detail?id=35793

  • WebKit.gyp:
  • scripts/generate_devtools_grd.py: Added.
10:35 AM Changeset in webkit [81146] by Adam Roben
  • 2 edits in trunk/LayoutTests

Update WebKit2 Skipped file for some new tests that rely on unimplemented features

  • platform/mac-wk2/Skipped:
10:32 AM Changeset in webkit [81145] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Eric Carlson.

HTMLMediaElement::mediaPlayerPlaybackStateChanged should not change the "public" state of the element
if it's an internal pause for example.
​https://bugs.webkit.org/show_bug.cgi?id=56374

In case of an internal pause, the callback from the mediaplayer should be ignored to avoid reflecting the
change into the DOM.

No new tests: Verified manually.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerPlaybackStateChanged):
10:24 AM Changeset in webkit [81144] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-03-15 Bill Budge <​bbudge@chromium.org>

Reviewed by David Levin.

AssociatedURLLoader does not support Cross Origin Requests
​https://bugs.webkit.org/show_bug.cgi?id=53925

No new tests. No new functionality exposed.

  • public/WebURLLoader.h: (WebKit::WebURLLoaderOptions::WebURLLoaderOptions):
  • src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::clearClient): (WebKit::AssociatedURLLoader::ClientAdapter::create): (WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter): (WebKit::AssociatedURLLoader::ClientAdapter::willSendRequest): (WebKit::AssociatedURLLoader::ClientAdapter::didSendData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveCachedMetadata): (WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading): (WebKit::AssociatedURLLoader::ClientAdapter::didFail): (WebKit::AssociatedURLLoader::AssociatedURLLoader): (WebKit::AssociatedURLLoader::~AssociatedURLLoader): (WebKit::AssociatedURLLoader::loadSynchronously): (WebKit::AssociatedURLLoader::loadAsynchronously): (WebKit::AssociatedURLLoader::cancel): (WebKit::AssociatedURLLoader::setDefersLoading):
  • src/AssociatedURLLoader.h:
10:14 AM Changeset in webkit [81143] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-15 Alok priyadarshi <​alokp@chromium.org>

Reviewed by James Robinson.

Remove unnecessary function WebPlugin::getBackingTextureId
​https://bugs.webkit.org/show_bug.cgi?id=56122

It will be tested by Pepper2D and Pepper3D layout/smoke tests
on the Chromium side.

  • public/WebPlugin.h:
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::platformLayer):
9:51 AM Changeset in webkit [81142] by mitz@apple.com
  • 2 edits in trunk/Tools

Build fix after r81135.

  • TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
9:33 AM Changeset in webkit [81141] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-03-15 Mikhail Naganov <​mnaganov@chromium.org>

Unreviewed. Update chromium deps to pick up the latest V8.

  • DEPS:
9:30 AM Changeset in webkit [81140] by mitz@apple.com
  • 5 edits in trunk/Tools

Build fix after r81135.

  • WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
  • WebKitTestRunner/mac/TestControllerMac.mm:
  • WebKitTestRunner/mac/TestInvocationMac.mm:
  • WebKitTestRunner/mac/main.mm:
9:01 AM Changeset in webkit [81139] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

2011-03-15 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Adam Barth.

REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
​https://bugs.webkit.org/show_bug.cgi?id=56349

  • QtTestBrowser/QtTestBrowser.pro: Link against fontconfig on platforms where we use it. Copied from DumpRenderTree.pro.
8:51 AM Changeset in webkit [81138] by mitz@apple.com
  • 3 edits in trunk/Tools

Build fix after r81135.

  • DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
  • DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
8:44 AM Changeset in webkit [81137] by Martin Robinson
  • 2 edits in trunk/Source/WebKit2

2011-03-15 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Adam Barth.

[GTK] [WebKit2] The UIProcess never changes the mouse cursor
​https://bugs.webkit.org/show_bug.cgi?id=56333

Add an implementation for WebView::addCursor for WebKit2 GTK+. This allows
the cursor to change as the user mouses around the page. There is currently
no test infrastructure to track cursor changes.

  • UIProcess/gtk/WebView.cpp: (WebKit::WebView::setCursor): Ported implementation from WebKit1.
8:12 AM Changeset in webkit [81136] by podivilov@chromium.org
  • 14 edits
    2 adds in trunk

2011-03-12 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: re-implement xhr breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=56252

  • inspector/debugger/xhr-breakpoints-expected.txt: Added.
  • inspector/debugger/xhr-breakpoints.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-12 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: re-implement xhr breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=56252

  • restore xhr breakpoints one by one instead of using setAllBrowserBreakpoints
  • store xhr breakpoints in a separate setting
  • move presentation-related code from BreakpointManager to XHRBreakpointsSidebarPane

Test: inspector/debugger/xhr-breakpoints.html

  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorBrowserDebuggerAgent::clear):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.setXHRBreakpoint): (WebInspector.BreakpointManager.prototype.removeXHRBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._validateBreakpoints): (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane): (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked.finishEditing): (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu.removeBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu): (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked.finishEditing): (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype.highlightBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype.clearBreakpointHighlight): (WebInspector.XHRBreakpointsSidebarPane.prototype._saveBreakpoints): (WebInspector.XHRBreakpointsSidebarPane.prototype._restoreBreakpoints): (WebInspector.XHRBreakpointsSidebarPane.prototype._projectChanged):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype._xhrBreakpointHit):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearInterface):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/inspector.js: (WebInspector.resetFocusElement): (WebInspector.set attached):
7:59 AM Changeset in webkit [81135] by kevino@webkit.org
  • 55 edits
    3 adds in trunk

Reviewed by Darin Adler.

Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
info into the headers rather than in export symbol definition files, but disable it on
all platforms initially so we can deal with port build issues one port at a time.

​https://bugs.webkit.org/show_bug.cgi?id=27551

7:41 AM Changeset in webkit [81134] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed build fix.

Chromium: shared lib linux build are failing.

Two exclude rules for LocalizedNumberNone and TextEncodingDetectorNone were added to the wrong library.
It was webcore_remaining instead of webcore_platform.

  • WebCore.gyp/WebCore.gyp:
7:38 AM Changeset in webkit [81133] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: expanding/collapsing object shouldn&apos;t affect outer console.group expansion state
​https://bugs.webkit.org/show_bug.cgi?id=56373

  • inspector/front-end/Section.js: (WebInspector.Section): (WebInspector.Section.prototype.toggleExpanded): (WebInspector.Section.prototype.handleClick): stop click even propagation if it was handled by this section.
7:13 AM Changeset in webkit [81132] by pfeldman@chromium.org
  • 6 edits in trunk

2011-03-15 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: crash upon "html@id" search in elements panel.
​https://bugs.webkit.org/show_bug.cgi?id=56334

  • inspector/elements/elements-panel-search-expected.txt:
  • inspector/elements/elements-panel-search.html:

2011-03-15 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: crash upon "html@id" search in elements panel.
​https://bugs.webkit.org/show_bug.cgi?id=56334

  • inspector/InspectorDOMAgent.cpp:
  • inspector/front-end/ElementsTreeOutline.js:
7:02 AM Changeset in webkit [81131] by caseq@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-15 Andrey Kosyakov <​caseq@chromium.org>

Unreviewed. Swap two calls to setMonitoringXHREnabled to get rid of side effects on other tests.

  • inspector/protocol/console-agent-expected.txt:
  • inspector/protocol/console-agent.html:
6:47 AM Changeset in webkit [81130] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-15 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: further extension API cleanup (removed inspectedPage, add experimental prefix)
​https://bugs.webkit.org/show_bug.cgi?id=56327

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI):
  • inspector/front-end/ExtensionAPISchema.json:
6:08 AM Changeset in webkit [81129] by yurys@chromium.org
  • 4 edits
    2 adds in trunk

2011-03-15 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: when console.groupEnd calls twice
​https://bugs.webkit.org/show_bug.cgi?id=56114

  • inspector/console/console-nested-group-expected.txt: Added.
  • inspector/console/console-nested-group.html: Added.

2011-03-15 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: when console.groupEnd calls twice
​https://bugs.webkit.org/show_bug.cgi?id=56114

Test: inspector/console/console-nested-group.html

  • inspector/ConsoleMessage.h: (WebCore::ConsoleMessage::type):
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::addConsoleMessage): do not coalesce adjacent EndGroup messages.
3:47 AM Changeset in webkit [81128] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-03-15 Chris Mumford <​chris.mumford@palm.com>

Reviewed by Adam Barth.

Initializing several member variables that were not initialized in
their constructors. These values were all read prior to initialization
as reported by Valgrind.

No new tests: No feature additions/removals.

  • accessibility/AccessibilityImageMapLink.cpp: (WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement):
  • xml/XPathResult.cpp: (WebCore::XPathResult::XPathResult):
3:46 AM Changeset in webkit [81127] by hayato@chromium.org
  • 9 edits in trunk/Tools

2011-03-15 Hayato Ito <​hayato@chromium.org>

Reviewed by Shinichiro Hamaji.

[NRWT] Add support for reftests to new-run-webkit-tests.

​https://bugs.webkit.org/show_bug.cgi?id=55457

  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/test_files.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3:33 AM Changeset in webkit [81126] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-15 Ben Taylor <​bentaylor.solx86@gmail.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=56255
Fix build on Solaris 10/Sun Studio 12 C++

No new tests. This is to fix compilation on Solaris 10 with Sun Studio 12 C++

  • bridge/runtime_array.h: (JSC::RuntimeArray::getConcreteArray):
3:32 AM Changeset in webkit [81125] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-03-15 Philippe Normand <​pnormand@igalia.com>

Unreviewed, skip failing media test on GTK.

  • platform/gtk/Skipped:
3:19 AM Changeset in webkit [81124] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-03-15 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, update test expectations

  • platform/chromium/test_expectations.txt:
3:10 AM Changeset in webkit [81123] by alex
  • 2 edits in trunk/Tools

2011-03-15 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix compilation warning after r80892
​https://bugs.webkit.org/show_bug.cgi?id=56302

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::originsWithLocalStorage):
2:41 AM Changeset in webkit [81122] by robert@webkit.org
  • 2 edits in trunk/Tools

2011-03-15 Robert Hogan <​robert@webkit.org>

Reviewed by Adam Barth.

Document the qmakearg argument, and hint how to build webkit2 on Qt
​https://bugs.webkit.org/show_bug.cgi?id=56326

  • Scripts/build-webkit: add --qmakearg to build-webkit --help
2:09 AM Changeset in webkit [81121] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-03-15 Ilya Sherman <​isherman@chromium.org>

Reviewed by David Levin.

Update Chromium test expectations for fast/forms/onchange-setvalueforuser
​https://bugs.webkit.org/show_bug.cgi?id=56365

  • platform/chromium/fast/forms/onchange-setvalueforuser-expected.txt: Added.
12:28 AM Changeset in webkit [81120] by Adam Roben
  • 3 edits in trunk/Tools

Make Windows 7 Release (Tests) a core builder

We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
give it a few more days of greenness first.

Fixes <​http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder

Reviewed by Sam Weinig.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(BuildBot): Added a regexp to match Windows 7 Release (Tests).

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
Updated the core regexps to match the buildbot module. Updated the expected results to match
the current set of core builders.

Mar 14, 2011:

11:58 PM Changeset in webkit [81119] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <​rniwa@webkit.org>

Another Chromium rebaseline for r81095.

  • platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt:
11:50 PM Changeset in webkit [81118] by Laszlo Gombos
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-14 Laszlo Gombos <Laszlo Gombos>

Unreviewed build fix.

Buildfix when JIT is not enabled after r81079
​https://bugs.webkit.org/show_bug.cgi?id=56361

  • runtime/Executable.cpp:
11:34 PM Changeset in webkit [81117] by Adam Roben
  • 1 edit
    1 add in trunk/Tools

Add forgotten file from r81116

  • TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
11:21 PM Changeset in webkit [81116] by weinig@apple.com
  • 12 edits
    1 add in trunk

about:blank fake responses don't get serialized when sent the UIProcess
<rdar://problem/9108119>
​https://bugs.webkit.org/show_bug.cgi?id=56357

Source/WebCore:

Reviewed by Adam Roben

Test: AboutBlankLoad

  • platform/network/cf/ResourceResponse.h:
  • platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::ResourceResponse::cfURLResponse):
Create a CFURLResponseRef if one does not exist yet as we do for
NSURLResponses on the mac.

Tools:

Reviewed by Adam Roben.

  • TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.

(TestWebKitAPI::decidePolicyForResponse):
(TestWebKitAPI::TEST):
Add test that loads of about:blank have a response with a MIMEType of text/html.

  • TestWebKitAPI/PlatformUtilities.h:
  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::MIMETypeForWKURLResponse):

  • TestWebKitAPI/win/PlatformUtilitiesWin.cpp:

(TestWebKitAPI::Util::MIMETypeForWKURLResponse):
Add helper to get the MIMEType from a WKURLResponse.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Add new files.

11:11 PM Changeset in webkit [81115] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-03-14 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Darin Adler.

REGRESSION: Print preview is blank when selecting multiple pages per sheet
​https://bugs.webkit.org/show_bug.cgi?id=56341
<rdar://problem/8991382>

  • UIProcess/API/mac/WKPrintingView.mm: (pageDidDrawToPDF): Don't reset latest expected callback number after receiving a different one. We only update preview after receiving the latest expected page data (and the assumption is that AppKit will ask for pages in natural order for N-up).
10:59 PM Changeset in webkit [81114] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-14 Alexis Menard <​alexis.menard@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Seeking videos using the timeline bar does not work properly and stop the video playback.
​https://bugs.webkit.org/show_bug.cgi?id=56145

We do not need seekTimeout and queuedSeekTimeout anymore. setPosition on QMediaPlayer is good enough.
positionChanged() will be emitted when the data is buffered. On Linux the signal was not emitted because
of a bug in QtMultimedia.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): (WebCore::MediaPlayerPrivateQt::seek): (WebCore::MediaPlayerPrivateQt::stateChanged): (WebCore::MediaPlayerPrivateQt::positionChanged):
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
10:56 PM Changeset in webkit [81113] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-03-14 Alexey Marinichev <​amarinichev@chromium.org>

Reviewed by Kenneth Russell.

Graphics Context is not properly recovered if the GPU process dies.
​https://bugs.webkit.org/show_bug.cgi?id=56148

Split context recreation into two steps.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite): (WebKit::WebViewImpl::doComposite): (WebKit::WebViewImpl::reallocateRenderer):
  • src/WebViewImpl.h:
10:50 PM Changeset in webkit [81112] by morrita@google.com
  • 3 edits in trunk/LayoutTests

2011-03-14 MORITA Hajime <​morrita@google.com>

Unreviewed, skipped tests that uses an unsupported DRT API.

  • platform/qt/Skipped:
  • platform/win/Skipped:
10:48 PM Changeset in webkit [81111] by ap@apple.com
  • 5 edits in trunk

2011-03-14 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=44138
Crashes beneath SocketStreamHandle::readStreamCallback when running WebSocket tests.

  • platform/win/Skipped: Unskipped tests that should be fixed now. I couldn't verify that locally, becasue most WebSocket tests time out on my machine.

2011-03-14 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=44138
Crash beneath SocketStreamHandle::readStreamCallback when running websocket/tests/workers/worker-handshake-challenge-randomness.html

​https://bugs.webkit.org/show_bug.cgi?id=55375
http/tests/websocket/tests/reload-crash.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows

​https://bugs.webkit.org/show_bug.cgi?id=56185
http/tests/websocket/tests/url-with-credential.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows

  • platform/network/cf/SocketStreamHandle.h: Made SocketStreamHandle ThreadSafeShared, so that a pointer can be passed across threads when wrapped in a RefPtr.
  • platform/network/cf/SocketStreamHandleCFNet.cpp: Make sure that an object still exists when executing a method on main thread by using RefPtr.
10:44 PM Changeset in webkit [81110] by rniwa@webkit.org
  • 20 edits
    1 delete in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <​rniwa@webkit.org>

Chromium rebaselines for r81095.

  • platform/chromium-linux/editing/deleting/smart-delete-001-expected.txt:
  • platform/chromium-linux/editing/deleting/smart-delete-002-expected.txt:
  • platform/chromium-linux/editing/pasteboard/smart-drag-drop-expected.txt:
  • platform/chromium-linux/editing/pasteboard/smart-paste-003-expected.txt:
  • platform/chromium-linux/editing/pasteboard/smart-paste-004-expected.txt:
  • platform/chromium-linux/editing/selection/fake-drag-expected.txt: Removed.
  • platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-win/editing/deleting/smart-delete-001-expected.txt:
  • platform/chromium-win/editing/deleting/smart-delete-002-expected.txt:
  • platform/chromium-win/editing/pasteboard/smart-drag-drop-expected.txt:
  • platform/chromium-win/editing/pasteboard/smart-paste-001-expected.txt:
  • platform/chromium-win/editing/pasteboard/smart-paste-003-expected.txt:
  • platform/chromium-win/editing/pasteboard/smart-paste-004-expected.txt:
  • platform/chromium-win/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/chromium-win/editing/selection/after-line-break-expected.txt:
  • platform/chromium-win/editing/selection/expanding-selections-expected.txt:
  • platform/chromium-win/editing/selection/expanding-selections2-expected.txt:
  • platform/chromium-win/editing/selection/fake-drag-expected.txt:
  • platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-win/editing/selection/triple-click-in-pre-expected.txt:
10:31 PM Changeset in webkit [81109] by rniwa@webkit.org
  • 21 edits in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <​rniwa@webkit.org>

GTK and Qt rebaselines for r81095.

  • platform/gtk/editing/deleting/smart-delete-001-expected.txt:
  • platform/gtk/editing/deleting/smart-delete-002-expected.txt:
  • platform/gtk/editing/pasteboard/smart-paste-001-expected.txt:
  • platform/gtk/editing/pasteboard/smart-paste-003-expected.txt:
  • platform/gtk/editing/pasteboard/smart-paste-004-expected.txt:
  • platform/gtk/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/gtk/editing/pasteboard/smart-paste-008-expected.txt:
  • platform/gtk/editing/selection/expanding-selections-expected.txt:
  • platform/gtk/editing/selection/expanding-selections2-expected.txt:
  • platform/gtk/editing/selection/fake-drag-expected.txt:
  • platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/gtk/editing/selection/triple-click-in-pre-expected.txt:
  • platform/qt/editing/deleting/smart-delete-001-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-001-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-003-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-004-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/qt/editing/selection/expanding-selections-expected.txt:
  • platform/qt/editing/selection/expanding-selections2-expected.txt:
  • platform/qt/editing/selection/triple-click-in-pre-expected.txt:
10:24 PM Changeset in webkit [81108] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-03-14 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
​https://bugs.webkit.org/show_bug.cgi?id=56006

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::initializeView):
  • QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):
9:58 PM Changeset in webkit [81107] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Mac build fix. Part 1 of N.

  • WebCore.exp.in:
9:49 PM Changeset in webkit [81106] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-03-14 James Kozianski <​koz@chromium.org>

Reviewed by Ojan Vafai.

Add method to make BuildBot return test outputs
​https://bugs.webkit.org/show_bug.cgi?id=54374

The Builder.latest_cached_build will be used by the new rebaseline
script to determine the build to use baselines from.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
9:30 PM Changeset in webkit [81105] by Adam Roben
  • 10 edits
    2 adds in trunk

Make WKBundlePageCanHandleRequest return true for empty document URLs

Reviewed by Sam Weinig.

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::canHandleRequest): Return true for any URL schemes that are handled as
empty documents, and defer to the platform for everything else.

  • WebProcess/WebPage/WebPage.h: Added platformCanHandleRequest.
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformCanHandleRequest):

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::platformCanHandleRequest):

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::platformCanHandleRequest):
Renamed from canHandleRequest.

Tools:

Test that WKBundlePageCanHandleRequest returns true for empty document URLs

  • TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.

(TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
(TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
(TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
ensure the web process is initialized, then ask the bundle to run the test and assert that
it succeeded.

  • TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.

(TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
(TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
handle a given URL.
(TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
URL type cannot be handled).
(TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
result.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:

Added new files to the project.

9:11 PM Changeset in webkit [81104] by Joseph Pecoraro
  • 3 edits
    2 adds in trunk

2011-03-14 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Eric Carlson.

Stalled media elements don't stop delaying the load event
​https://bugs.webkit.org/show_bug.cgi?id=56316

  • http/tests/media/video-play-stall-before-meta-data-expected.txt: Added.
  • http/tests/media/video-play-stall-before-meta-data.html: Added.

2011-03-14 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Eric Carlson.

Stalled media elements don't stop delaying the load event
​https://bugs.webkit.org/show_bug.cgi?id=56316

We should stop delaying the load event when the load has
stalled naturally, or if we require a user gesture to
continue the load.

Test: http/tests/media/video-play-stall-before-meta-data.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState): when suspending, stop delaying. (WebCore::HTMLMediaElement::progressEventTimerFired): when stalling, stop delaying.
8:56 PM Changeset in webkit [81103] by mrowe@apple.com
  • 12 edits in trunk

Roll out r81097. It broke the 32-bit Mac build and caused assertion failures on the Windows Debug bots.

8:50 PM Changeset in webkit [81102] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-03-14 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Martin Robinson.

[GTK] Possible leaks after splitting TextCheckerClientEnchant.
​https://bugs.webkit.org/show_bug.cgi?id=55989

Convert gchar* to GOwnPtr<gchar> and refactor the code.

  • WebCoreSupport/TextCheckerClientEnchant.cpp: (WebKit::TextCheckerClientEnchant::checkSpellingOfString):
7:38 PM Changeset in webkit [81101] by morrita@google.com
  • 3 edits
    3 adds in trunk

2011-03-13 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

Crash when dragging and dropping in a document with an invalid XHTML header
​https://bugs.webkit.org/show_bug.cgi?id=48799

  • editing/pasteboard/drop-file-svg.html: Added.
  • editing/pasteboard/resources/drop-file-svg.svg: Added.

2011-03-13 MORITA Hajime <​morrita@google.com>

Reviewed by Tony Chang.

Crash when dragging and dropping in a document with an invalid XHTML header
​https://bugs.webkit.org/show_bug.cgi?id=48799

DragController tried to dispatch textInput event even when the
drag destination is not the editable area.
This change skips the event dispatching on that case.

Test: editing/pasteboard/drop-file-svg.html

  • page/DragController.cpp: (WebCore::DragController::dispatchTextInputEventFor): (WebCore::DragController::concludeEditDrag):
7:28 PM Changeset in webkit [81100] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-03-14 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Made the global object moving-GC-safe
​https://bugs.webkit.org/show_bug.cgi?id=56348


SunSpider reports no change.

  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::markChildren): Removed a dubious comment that suggested we do not need to visit all our references during GC, since that is not true in a moving GC.

Re-sorted data members by type, removed one duplicate, and added back
the one missing mark I found.

  • runtime/JSGlobalObject.h: Re-sorted data members by type.
7:27 PM Changeset in webkit [81099] by levin@chromium.org
  • 17 edits in trunk

Unreviewed, rolling out r81094.
​http://trac.webkit.org/changeset/81094
​https://bugs.webkit.org/show_bug.cgi?id=56355

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-03-14
Broke the chromium DRT related build. (Requested by dave_levin
on #webkit).

Source/WebCore:

  • WebCore.exp.in:
  • WebCore.order:
  • page/Frame.cpp:

(WebCore::Frame::layerTreeAsText):

  • page/Frame.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerTreeAsText):

  • rendering/RenderLayerCompositor.h:

Source/WebKit/chromium:

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::renderTreeAsText):
(WebKit::WebFrameImpl::layerTreeAsText):

  • src/WebFrameImpl.h:

Tools:

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::layerTreeAsText):

  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::runFileTest):
(TestShell::dump):

  • DumpRenderTree/chromium/TestShell.h:

(TestParams::TestParams):

7:24 PM Changeset in webkit [81098] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-14 Adam Barth <​abarth@webkit.org>

Apparently we need to exclude DefaultSharedWorkerRepository.cpp from
the Chromium build, otherwise the objects visible in the global scope
change.

  • WebCore.gyp/WebCore.gyp:
7:17 PM Changeset in webkit [81097] by commit-queue@webkit.org
  • 12 edits in trunk

2011-03-14 Rik Cabanier <​cabanier@gmail.com>

Reviewed by David Hyatt.

bug 56052: percentages are incorrectly rounded in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=56052

  • platform/mac/fast/css/percentage-non-integer-expected.txt:

2011-03-14 Rik Cabanier <​cabanier@adobe.com>

Reviewed by David Hyatt.

bug 56052: percentages are incorrectly rounded in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=56052

test: fast/css/percentage-non-integer.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • page/PrintContext.cpp: (WebCore::PrintContext::pageProperty):
  • platform/Length.h: (WebCore::Length::Length): (WebCore::Length::operator*=): (WebCore::Length::value): (WebCore::Length::percent): (WebCore::Length::setValue): (WebCore::Length::calcValue): (WebCore::Length::calcMinValue): (WebCore::Length::isUndefined): (WebCore::Length::isZero): (WebCore::Length::isPositive): (WebCore::Length::isNegative):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::computePreferredLogicalWidths): (WebCore::AutoTableLayout::calcEffectiveLogicalWidth): (WebCore::AutoTableLayout::layout):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::layoutRows):
  • rendering/style/BorderData.h: (WebCore::BorderData::hasBorderRadius):
7:09 PM Changeset in webkit [81096] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-14 Adam Barth <​abarth@webkit.org>

Attempted Chromium build fix. Exclude AllInOne harder.

  • WebCore.gyp/WebCore.gyp:
7:07 PM Changeset in webkit [81095] by rniwa@webkit.org
  • 19 edits in trunk

2011-03-14 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

EventHandler calls shouldChangeSelection needlessly
​https://bugs.webkit.org/show_bug.cgi?id=56324

Extracted setSelectionIfNeeded and setNonDirectionalSelectionIfNeeded and
avoided calling shouldChangeSelection and setSelection when the existing
selection is identical to that of new selection.

  • page/EventHandler.cpp: (WebCore::setSelectionIfNeeded): Extracted. (WebCore::setNonDirectionalSelectionIfNeeded): Extracted. (WebCore::EventHandler::selectClosestWordFromMouseEvent): Calls a helper function above. (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Ditto. (WebCore::EventHandler::handleMousePressEventTripleClick): Ditto. (WebCore::EventHandler::handleMousePressEventSingleClick): Ditto. (WebCore::EventHandler::updateSelectionForMouseDrag): Ditto. (WebCore::EventHandler::handleMouseReleaseEvent): Ditto.

2011-03-14 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Rework object group building.
​https://bugs.webkit.org/show_bug.cgi?id=55399

Instead of going top-down (from owner to owned elements), go up---from objects
to their group ids. That fits better to v8's object grouping model and guarantees
that each wrapper belongs to the single group.

Alas, this cannot be implemented for one kind of objects---CSSProperties.

Part of core GC algorithm and tested extensively by exisiting layout tests.

  • platform/chromium/test_expectations.txt: Temporary suppress text differences.
6:56 PM Changeset in webkit [81094] by commit-queue@webkit.org
  • 17 edits in trunk

2011-03-14 Daniel Sievers <​sievers@google.com>

Reviewed by Simon Fraser.

[Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
​https://bugs.webkit.org/show_bug.cgi?id=56139

  • WebCore.exp.in:
  • WebCore.order:
  • page/Frame.cpp: (WebCore::Frame::layerTreeAsText):
  • page/Frame.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::layerTreeAsText):
  • rendering/RenderLayerCompositor.h:

2011-03-14 Daniel Sievers <​sievers@google.com>

Reviewed by Simon Fraser.

[Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
​https://bugs.webkit.org/show_bug.cgi?id=56139

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::renderTreeAsText): (WebKit::WebFrameImpl::layerTreeAsText):
  • src/WebFrameImpl.h:

2011-03-14 Daniel Sievers <​sievers@google.com>

Reviewed by Simon Fraser.

[Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
​https://bugs.webkit.org/show_bug.cgi?id=56139

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::layerTreeAsText):
  • DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::setShowDebugLayerTree):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest): (TestShell::dump):
  • DumpRenderTree/chromium/TestShell.h: (TestParams::TestParams):
6:42 PM Changeset in webkit [81093] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-03-14 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add remaining files to WebCore.gypi
​https://bugs.webkit.org/show_bug.cgi?id=56351

Adding the remaining files to WebCore.gypi required updating the
include/exclude lists in WebCore.gyp. These lists aren't overly
elegant, but we can try to improve them in the future.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • bindings/v8/ScriptCachedFrameData.cpp:
    • Added ifdefs to this file to match the header.
  • platform/graphics/WOFFFileFormat.cpp:
    • Fixed build error when compiling without ENABLE(OPENTYPE_SANITIZER).
6:19 PM Changeset in webkit [81092] by antonm@chromium.org
  • 13 edits in trunk

2011-03-14 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Rework object group building.
​https://bugs.webkit.org/show_bug.cgi?id=55399

Instead of going top-down (from owner to owned elements), go up---from objects
to their group ids. That fits better to v8's object grouping model and guarantees
that each wrapper belongs to the single group.

Alas, this cannot be implemented for one kind of objects---CSSProperties.

Part of core GC algorithm and tested extensively by exisiting layout tests.

  • platform/chromium/test_expectations.txt: Temporary suppress text differences.

2011-03-14 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Rework object group building.
​https://bugs.webkit.org/show_bug.cgi?id=55399

Instead of going top-down (from owner to owned elements), go up---from objects
to their group ids. That fits better to v8's object grouping model and guarantees
that each wrapper belongs to the single group.

Alas, this cannot be implemented for one kind of objects---CSSProperties.

Part of core GC algorithm and tested extensively by exisiting layout tests.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/V8/V8TestInterface.cpp:
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
  • bindings/scripts/test/V8/V8TestObj.cpp:
  • bindings/v8/V8GCController.cpp: (WebCore::calculateGroupId): (WebCore::calculateRootStyleSheet): (WebCore::GrouperVisitor::visitDOMWrapper): (WebCore::GrouperVisitor::applyGrouping): (WebCore::V8GCController::gcPrologue):
  • bindings/v8/WrapperTypeInfo.h: (WebCore::WrapperTypeInfo::isSubclass):
  • css/CSSRuleList.h: (WebCore::CSSRuleList::styleList):
  • css/StyleSheetList.h: (WebCore::StyleSheetList::document):
6:15 PM Changeset in webkit [81091] by luiz@webkit.org
  • 2 edits in trunk/LayoutTests

Skipping some tests on Windows due to problems on mouse click handling.
See ​https://bugs.webkit.org/show_bug.cgi?id=56347.

  • platform/win/Skipped:
6:13 PM Changeset in webkit [81090] by rniwa@webkit.org
  • 17 edits in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <​rniwa@webkit.org>

Mac Leopard rebaselines for r81053 (Grabbed off of Chromium bots).

  • platform/mac-leopard/fast/text/atsui-rtl-override-selection-expected.checksum:
  • platform/mac-leopard/fast/text/atsui-rtl-override-selection-expected.png:
  • platform/mac-leopard/editing/selection/drag-select-1-expected.checksum:
  • platform/mac-leopard/editing/selection/drag-select-1-expected.png:
  • platform/mac-leopard/editing/selection/fake-drag-expected.checksum:
  • platform/mac-leopard/editing/selection/fake-drag-expected.png:
  • platform/mac-leopard/editing/selection/inline-closest-leaf-child-expected.checksum:
  • platform/mac-leopard/editing/selection/inline-closest-leaf-child-expected.png:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-container-expected.checksum:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-root-expected.checksum:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
6:11 PM Changeset in webkit [81089] by Chris Fleizach
  • 2 edits in trunk/Source/WebKit2

CrashTracer: 60 crashes in WebProcess at com.apple.WebKit2: -[AccessibilityWebPageObject accessibilityHitTest:] + 248
​https://bugs.webkit.org/show_bug.cgi?id=56336

Reviewed by Beth Dakin.

Crash trace indicates a nil pointer access in one of these m_page->mainFrame()->coreFrame()->view()
pointers.

  • WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:

(-[AccessibilityWebPageObject accessibilityHitTest:]):

5:53 PM Changeset in webkit [81088] by tkent@chromium.org
  • 7 edits
    2 adds in trunk

Assertion failure by form validation message for <select required> with float:left
​https://bugs.webkit.org/show_bug.cgi?id=55995

Reviewed by James Robinson.

Source/WebCore:

Test: fast/forms/interactive-validation-select-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::canMergeContiguousAnonymousBlocks):

isAnonymousBlock() doesn't mean it is a RenderBlock. We need to check isRenderBlock().

LayoutTests:

  • fast/forms/interactive-validation-select-crash-expected.txt: Added.
  • fast/forms/interactive-validation-select-crash.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
5:48 PM Changeset in webkit [81087] by alice.liu@apple.com
  • 3 edits in trunk/Source/WebKit2

Provide API for creating WKImage from CGImageRef
​https://bugs.webkit.org/show_bug.cgi?id=56159

Reviewed by Sam Weinig.

Add function for creating a WKImage from CGImage data.

  • Shared/API/c/cg/WKImageCG.cpp:

(WKImageCreateFromCGImage): Added. Creates a graphics context for the bitmap-backed image and draws into it.

  • Shared/API/c/cg/WKImageCG.h:
5:39 PM Changeset in webkit [81086] by ggaren@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

2011-03-14 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Made JSWrapperObject and subclasses moving-GC-safe
​https://bugs.webkit.org/show_bug.cgi?id=56346


SunSpider reports no change.

  • runtime/BooleanObject.cpp: (JSC::BooleanObject::BooleanObject):
  • runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance): No more need for JSGlobalData, since we don't initialize the wrapped value in our constructor.
  • runtime/DateInstance.h: Don't set the OverridesMarkChildren flag because we do not in fact override markChildren.
  • runtime/DatePrototype.h: Declare an anonymous slot, since wrapper object no longer does so for us. Also added an ASSERT to catch a latent bug, where DatePrototype stomped on its base class's anonymous slot. Hard-coded anonymous slots are a plague on our code. This doesn't cause any problems in our existing code since the base class never reads the anonymous slot it declares, but it caused crashes when I tried to start using the slot in an initial version of this patch.
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::JSWrapperObject): (JSC::JSWrapperObject::internalValue): (JSC::JSWrapperObject::setInternalValue): Resolved a problem where our internal value was stored in two places: an anonymous slot, and a data member which was not always visited during GC. Now, we only use the data member, and we always visit it. (Instead of relying on certain subclasses to set the OverridesMarkChildren bit, we set it ourselves.)
  • runtime/NumberObject.cpp: (JSC::NumberObject::NumberObject): No more need for JSGlobalData, since we don't initialize the wrapped value in our constructor.
  • runtime/NumberObject.h: Removed meaningless declaration.
  • runtime/StringObject.cpp: (JSC::StringObject::StringObject): No more need for JSGlobalData, since we don't initialize the wrapped value in our constructor.
  • runtime/StringObject.h: Don't set the OverridesMarkChildren flag because we do not in fact override markChildren.
  • runtime/StringPrototype.h: Declare an anonymous slot, since wrapper object no longer does so for us. Also added an ASSERT to catch a latent bug, where DatePrototype stomped on its base class's anonymous slot. Hard-coded anonymous slots are a plague on our code.
5:36 PM Changeset in webkit [81085] by msaboff@apple.com
  • 4 edits
    3 adds in trunk

2011-03-14 Michael Saboff <​msaboff@apple.com>

Reviewed by Gavin Barraclough.

Look-ahead assertions with back references don’t work as expected
​https://bugs.webkit.org/show_bug.cgi?id=56082

Changed parentheses assertion processing to temporarily back out the
number of known characters after the assertion while processing the
assertion. This was done so that assertions don't fail due to
checking the number of required characters as additional to the
rest of the express since assertions don't "consume" input.
Added a byte code to uncheck characters to support the change.

  • yarr/YarrInterpreter.cpp: (JSC::Yarr::Interpreter::matchDisjunction): (JSC::Yarr::ByteCompiler::uncheckInput): (JSC::Yarr::ByteCompiler::emitDisjunction):
  • yarr/YarrInterpreter.h: (JSC::Yarr::ByteTerm::UncheckInput):

2011-03-14 Michael Saboff <​msaboff@apple.com>

Reviewed by Gavin Barraclough.

Look-ahead assertions with back references don’t work as expected
​https://bugs.webkit.org/show_bug.cgi?id=56082

New tests to verify the corresponding changes.

  • fast/regex/assertion-expected.txt: Added.
  • fast/regex/assertion.html: Added.
  • fast/regex/script-tests/assertion.js: Added.
5:32 PM Changeset in webkit [81084] by kbalazs@webkit.org
  • 15 edits in trunk

2011-03-14 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Adam Roben.

[Qt][WK2]Unbreak InjectedBundle on Qt
​https://bugs.webkit.org/show_bug.cgi?id=54109

No code changes so no new tests.

Revert the changes that were needed to use KURL
in WebKitTestRunner.

  • Configurations/WebCore.xcconfig:
  • WebCore.exp.in:

2011-03-14 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Adam Roben.

[Qt][WK2]Unbreak InjectedBundle on Qt
​https://bugs.webkit.org/show_bug.cgi?id=54109

Add API's to WKURL and WKString to satisfy
WebKitTestRunner's needs.

  • Shared/API/c/WKString.cpp: (WKStringIsEqualToUTF8CStringIgnoringCase):
  • Shared/API/c/WKString.h:
  • Shared/API/c/WKURL.cpp: (WKURLCopyHostName): (WKURLCopyScheme):
  • Shared/API/c/WKURL.h:
  • Shared/WebString.h: (WebKit::WebString::equalToUTF8StringIgnoringCase):
  • Shared/WebURL.h: Added OwnPtr<KURL> member to be able to lazily parse the URL and store the result. (WebKit::WebURL::host): (WebKit::WebURL::protocol): (WebKit::WebURL::parseURLIfNecessary):
  • win/WebKit2.def: Revert the symbol exports that were needed to use KURL in WebKitTestRunner.

2011-03-14 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Adam Roben.

[Qt][WK2]Unbreak InjectedBundle on Qt
​https://bugs.webkit.org/show_bug.cgi?id=54109

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2 API's instead of KURL to analyze the URL.
  • WebKitTestRunner/StringFunctions.h: (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally in the WebKitTestRunner project. (WTR::toWK): Use adoptWK. (WTR::operator<<): Added helper for printing a WKURL.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link against WebCore.
4:59 PM Changeset in webkit [81083] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

It's the same old song (about the linux debug crash).

  • platform/chromium/test_expectations.txt:
4:52 PM Changeset in webkit [81082] by jeffm@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-03-14 Jeff Miller <​jeffm@apple.com>

Reviewed by Adam Roben.

Add WKViewSetScrollOffsetOnNextResize() to C API on Windows
​https://bugs.webkit.org/show_bug.cgi?id=56340

  • UIProcess/API/C/win/WKView.cpp: (WKViewSetScrollOffsetOnNextResize): Added.
  • UIProcess/API/C/win/WKView.h: Added WKViewSetScrollOffsetOnNextResize().
  • UIProcess/win/WebView.cpp: (WebKit::WebView::onSizeEvent): Apply any scroll offset when setting the drawing area size. (WebKit::WebView::setScrollOffsetOnNextResize): Added.
  • UIProcess/win/WebView.h: Added setScrollOffsetOnNextResize().
4:47 PM Changeset in webkit [81081] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-14 Viatcheslav Ostapenko <​ostapenko.viatcheslav@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Warning that round/roundf functions are already defined when compiled with RVCT 4 on symbian.
​https://bugs.webkit.org/show_bug.cgi?id=56133

Add condition to not compile webkit internal math round functions on RVCT compiler versions
from 3.0.0 because they are already defined in compiler math library.

  • wtf/MathExtras.h:
4:40 PM Changeset in webkit [81080] by mrowe@apple.com
  • 2 edits in trunk/Tools

Fix two memory leaks within LayoutTestController's storage support.

Reviewed by Adam Roben.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
by JSStringCreateWithCFString.
(LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
allocate.

4:31 PM Changeset in webkit [81079] by barraclough@apple.com
  • 5 edits
    20 adds in trunk/Source/JavaScriptCore

Bug 56284 - Add a dataflow intermediate representation for use in JIT generation.

Reviewed by Geoffrey Garen & Oliver Hunt.

The JSC JIT presently generates code directly from the bytecode used by the interpreter.
This is not an optimal intermediate representation for JIT code generation, since it does
not capture liveness information of values, and provides little opportunity to perform
any static analysis for even primitive types. The JIT currently generates two code paths,
a fast path handling common cases, and a slower path handling less common operand types.
However the slow path jumps back into the fast path, meaning that information arising
from the earlier type checks cannot be propagated to later operations.

This patch adds:

  • a dataflow intermediate representation capable of describing a single basic block of operations,
  • a mechanism to convert a simple, single-block bytecode functions to the new IR,
  • and a JIT code generator capable of generating code from this representation.

The JIT generates two code paths, with the slower path not reentering the fast path
mid-block, allowing speculative optimizations to be made on the hot path, with type
information arising from these speculative decisions able to be propagated through the
dataflow. Code generation of both speculative and non-speculative paths exploits the type
and liveness information represented in the dataflow graph to attempt to avoid redundant
boxing and type-checking of values, and to remove unnecessary spills of temporary values
to the RegisterFile.

The dataflow JIT currently can only support a subset of bytecode operations, limited to
arithmetic, bit-ops, and basic property access. Functions that cannot be compiled by the
dataflow JIT will be run using the existing JIT. The coverage of the dataflow JIT will be
expanded to include, control-flow, function calls, and then the long-tail of remaining
bytecode instructions. The JIT presently only support JSVALUE64, and as a consequence of
this only supports x86-64.

The status of the dataflow JIT is currently work-in-progress. Limitations of the present
JIT code generation may cause performance regressions, particularly:

  • the policy to only generate arithmetic code on the speculative path using integer instructions, never using floating point.
  • the policy to only generate arithmetic code on the non-speculative path using floating point instructions, never using integer.
  • always generating JSValue adds on the non-speculative path as a call out to a C-function, never handling this in JIT code.
  • always assuming by-Value property accesses on the speculative path to be array accesses.
  • generating all by-Value property accesses from the non-speculative path as a call out to a C-function.
  • generating all by-Indentifer property accesses as a call out to a C-function.

Due to these regressions, the code is landed in a state where it is disabled in most
cases by the ENABLE_DFG_JIT_RESTRICTIONS guard in Platform.h. As these regressions are
addressed, the JIT will be allowed to trigger in more cases.

  • JavaScriptCore.xcodeproj/project.pbxproj:
    • Added new files to Xcode project.
  • dfg: Added.
    • Added directory for new code.
  • dfg/DFGByteCodeParser.cpp: Added.
  • dfg/DFGByteCodeParser.h: Added.
    • Contruct a DFG::Graph representation from a bytecode CodeBlock.
  • dfg/DFGGenerationInfo.h: Added.
    • Track type & register information for VirtualRegisters during JIT code generation.
  • dfg/DFGGraph.cpp: Added.
  • dfg/DFGGraph.h: Added.
    • Dataflow graph intermediate representation for code generation.
  • dfg/DFGJITCodeGenerator.cpp: Added.
  • dfg/DFGJITCodeGenerator.h: Added.
    • Base class for SpeculativeJIT & NonSpeculativeJIT to share common functionality.
  • dfg/DFGJITCompiler.cpp: Added.
  • dfg/DFGJITCompiler.h: Added.
    • Class responsible for driving code generation of speculativeJIT & non-speculative code paths from the dataflow graph.
  • dfg/DFGNonSpeculativeJIT.cpp: Added.
  • dfg/DFGNonSpeculativeJIT.h: Added.
    • Used to generate the non-speculative code path, this make no assumptions about operand types.
  • dfg/DFGOperations.cpp: Added.
  • dfg/DFGOperations.h: Added.
    • Helper functions called from the JIT generated code.
  • dfg/DFGRegisterBank.h: Added.
    • Used to track contents of physical registers during JIT code generation.
  • dfg/DFGSpeculativeJIT.cpp: Added.
  • dfg/DFGSpeculativeJIT.h: Added.
    • Used to generate the speculative code path, this make assumptions about operand types to enable optimization.
  • runtime/Executable.cpp:
    • Add code to attempt to use the DFG JIT to compile a function, with fallback to the existing JIT.
  • wtf/Platform.h:
    • Added compile guards to enable the DFG JIT.
4:29 PM Changeset in webkit [81078] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add more linux debug crashers to the sad list.

  • platform/chromium/test_expectations.txt:
4:27 PM Changeset in webkit [81077] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

2011-03-14 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
​https://bugs.webkit.org/show_bug.cgi?id=56321

  • Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c" to the list of exceptions for WebKit2 C API headers.
4:24 PM Changeset in webkit [81076] by Martin Robinson
  • 7 edits
    4 adds in trunk/LayoutTests

2011-03-14 Martin Robinson <​mrobinson@igalia.com>

Update GTK+ pixel results after r81053.

  • platform/gtk/editing/selection/drag-select-1-expected.checksum:
  • platform/gtk/editing/selection/drag-select-1-expected.png:
  • platform/gtk/editing/selection/fake-drag-expected.checksum: Added.
  • platform/gtk/editing/selection/fake-drag-expected.png: Added.
  • platform/gtk/editing/selection/inline-closest-leaf-child-expected.checksum: Added.
  • platform/gtk/editing/selection/inline-closest-leaf-child-expected.png: Added.
  • platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
  • platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
4:14 PM Changeset in webkit [81075] by Adam Roben
  • 2 edits in trunk/Tools

Show the list of recent leaky builds in reverse chronological order

Previously they were being shown in a deterministic but surprising order based on
lexicographically sorting the build offsets (-1, -10, -2, -3...).

Fixes <​http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:

(RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
callback.

4:13 PM Changeset in webkit [81074] by psolanki@apple.com
  • 3 edits in trunk/WebKitLibraries

I checked in Intel-only version of these files in r80975. This fixes that by building all
the correct slices - i386/x86_64/ppc for SnowLeopard and i386/x86_64/ppc/ppc64 for Leopard.

Rubber-stamped by Mark Rowe.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
3:47 PM Changeset in webkit [81073] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Upstream test expectations from the chromium repository to WebKit.

  • platform/chromium/test_expectations.txt:
3:38 PM Changeset in webkit [81072] by rniwa@webkit.org
  • 15 edits in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <​rniwa@webkit.org>

Mac pixel rebaselines for r81053.

  • platform/mac/editing/selection/drag-select-1-expected.checksum:
  • platform/mac/editing/selection/drag-select-1-expected.png:
  • platform/mac/editing/selection/fake-drag-expected.checksum:
  • platform/mac/editing/selection/fake-drag-expected.png:
  • platform/mac/fast/text/atsui-rtl-override-selection-expected.checksum:
  • platform/mac/fast/text/atsui-rtl-override-selection-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.checksum:
  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.checksum:
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
3:31 PM Changeset in webkit [81071] by ggaren@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

2011-03-14 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed more cases of DeprecatedPtr (exception, SmallStrings)
​https://bugs.webkit.org/show_bug.cgi?id=56332

  • runtime/Identifier.cpp: (JSC::Identifier::add): (JSC::Identifier::addSlowCase): Use a variable instead of a hard-coded constant, to make this code less brittle.
  • runtime/JSGlobalData.h: Use HeapRoot instead of DeprecatedPtr because this reference is owned and managed directly by the heap.
  • runtime/JSString.cpp: (JSC::JSString::substringFromRope):
  • runtime/JSString.h: (JSC::jsSingleCharacterString): (JSC::jsSingleCharacterSubstring): (JSC::jsString): (JSC::jsStringWithFinalizer): (JSC::jsSubstring): (JSC::jsOwnedString): Use a variable instead of a hard-coded constant, to make this code less brittle.
  • runtime/SmallStrings.cpp: (JSC::SmallStringsStorage::rep): (JSC::SmallStringsStorage::SmallStringsStorage): (JSC::SmallStrings::SmallStrings): (JSC::SmallStrings::markChildren): (JSC::SmallStrings::clear): (JSC::SmallStrings::count): Use a variable instead of a hard-coded constant, to make this code less brittle.
  • runtime/SmallStrings.h: (JSC::SmallStrings::singleCharacterString): Use HeapRoot instead of DeprecatedPtr because these references are owned and managed directly by the heap.


Stop using FixedArray because we only want a very limited set
of classes to be able to use HeapRoot. (Replaced with manual ASSERTs.)

  • runtime/WriteBarrier.h: (JSC::operator==): (JSC::WriteBarrier::WriteBarrier): (JSC::HeapRoot::HeapRoot): (JSC::HeapRoot::operator=): Added HeapRoot, which is allowed to set without write barrier because we assume all HeapRoots are scanned during all GC passes.
3:28 PM Changeset in webkit [81070] by levin@chromium.org
  • 17 edits in trunk/LayoutTests

Update the chromium windows baselines for r81053.

  • platform/chromium-win/editing/selection/drag-select-1-expected.checksum:
  • platform/chromium-win/editing/selection/drag-select-1-expected.png:
  • platform/chromium-win/editing/selection/drag-select-1-expected.txt:
  • platform/chromium-win/editing/selection/fake-drag-expected.txt:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.checksum:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.checksum:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
3:25 PM Changeset in webkit [81069] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-03-14 Jarkko Sakkinen <​jarkko.j.sakkinen@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Compilation fails with --3d-canvas
​https://bugs.webkit.org/show_bug.cgi?id=55964

  • WebCore.pro:
  • platform/graphics/qt/Extensions3DQt.cpp:
3:19 PM Changeset in webkit [81068] by Adam Roben
  • 5 edits
    1 add in trunk/Tools

Show a list of up to 10 recent leaky builds when Leaks Viewer loads

Fixes <​http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
analyze

Reviewed by David Kilzer and Joe Pecoraro.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:

(#url-prompt): Made this a bit taller to make room for the list of builds.

(#recent-builds-loading-indicator):
(#recent-builds-list):
Added styles for the build list and loading indicator.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:

(LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
it. This will unescape it.
(LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
(LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
(LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
(LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
prompt UI.
(LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
now also used when a recent build is clicked.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.

(RecentBuildsLoader): Store the callback.
(RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
builder. Find the revision number, leak count, and results URL for each one. Pass the
resulting info to our callback.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:

(range): Added this helper function to return an array containing the integers [0, n).

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added

RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.

3:17 PM Changeset in webkit [81067] by rniwa@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Fixed typo in the change log entry for r81066.

3:15 PM Changeset in webkit [81066] by rniwa@webkit.org
  • 8 edits in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <​rniwa@webkit.org>

GTK rebaselines or r81053.

  • platform/gtk/editing/selection/drag-select-1-expected.txt:
  • platform/gtk/editing/selection/fake-drag-expected.txt:
  • platform/gtk/editing/selection/inline-closest-leaf-child-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
3:15 PM Changeset in webkit [81065] by bweinstein@apple.com
  • 7 edits
    2 adds in trunk/Source

FileSystemWin.cpp needs listDirectory() implementation
​https://bugs.webkit.org/show_bug.cgi?id=56331
<rdar://problem/9126635>

Reviewed by Adam Roben and Gavin Barraclough.

Source/JavaScriptCore:

Give StringConcatenate the ability to deal with const UChar*'s as a String type to append.

  • wtf/text/StringConcatenate.h:

Source/WebCore:

Move PathWalker from an inline class in WebKit2 to its own class in WebCore,
so it can be used from both WebCore and WebKit2.

Implement FileSystemWin::listDirectory using PathWalker to populate the Vector
of paths matching the passed in pattern.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/FileSystemWin.cpp:

(WebCore::listDirectory): Call through to PathWalker.

  • platform/win/PathWalker.cpp: Added.

(WebCore::PathWalker::PathWalker): Moved from WebKit2. Added a second argument

for the pattern to pass to the Windows File APIs.

(WebCore::PathWalker::~PathWalker): Moved from WebKit2.
(WebCore::PathWalker::isValid): Ditto.
(WebCore::PathWalker::data): Ditto.
(WebCore::PathWalker::step): Ditto.

  • platform/win/PathWalker.h: Added.

Source/WebKit2:

Move PathWalker down into WebCore, and call the PathWalker in WebCore
(that now has a second argument, the pattern to take).

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp:

(WebKit::PluginInfoStore::pluginPathsInDirectory):

3:14 PM Changeset in webkit [81064] by levin@chromium.org
  • 13 edits
    21 adds in trunk/LayoutTests

Add rebaselines due to two changes:
For r81053, we have

editing/selection/drag-select-1.html, editing/selection/fake-drag.html, svg/custom/mouse-move-on-svg-container-standalone.svg,
svg/custom/mouse-move-on-svg-container.xhtml, svg/custom/mouse-move-on-svg-root-standalone.svg, svg/custom/mouse-move-on-svg-root.xhtml

For r81049, we have

fast/table/overflowHidden.html, fast/table/relative-position-containment.html, fast/table/relative-position-offsets.html, fast/table/relative-position-stacking.html

  • platform/chromium-linux/editing/selection/drag-select-1-expected.checksum:
  • platform/chromium-linux/editing/selection/drag-select-1-expected.png:
  • platform/chromium-linux/editing/selection/drag-select-1-expected.txt: Added.
  • platform/chromium-linux/editing/selection/fake-drag-expected.txt: Added.
  • platform/chromium-linux/fast/table/relative-position-containment-expected.checksum: Added.
  • platform/chromium-linux/fast/table/relative-position-containment-expected.png: Added.
  • platform/chromium-linux/fast/table/relative-position-offsets-expected.checksum: Added.
  • platform/chromium-linux/fast/table/relative-position-offsets-expected.png: Added.
  • platform/chromium-linux/fast/table/relative-position-stacking-expected.checksum: Added.
  • platform/chromium-linux/fast/table/relative-position-stacking-expected.png: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.checksum:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.txt: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.checksum:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added.
  • platform/chromium-win/fast/table/overflowHidden-expected.txt:
  • platform/chromium-win/fast/table/relative-position-containment-expected.checksum: Added.
  • platform/chromium-win/fast/table/relative-position-containment-expected.png: Added.
  • platform/chromium-win/fast/table/relative-position-containment-expected.txt: Added.
  • platform/chromium-win/fast/table/relative-position-offsets-expected.checksum: Added.
  • platform/chromium-win/fast/table/relative-position-offsets-expected.png: Added.
  • platform/chromium-win/fast/table/relative-position-offsets-expected.txt: Added.
  • platform/chromium-win/fast/table/relative-position-stacking-expected.checksum: Added.
  • platform/chromium-win/fast/table/relative-position-stacking-expected.png: Added.
  • platform/chromium-win/fast/table/relative-position-stacking-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:55 PM Changeset in webkit [81063] by rniwa@webkit.org
  • 1 edit
    4 deletes in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <​rniwa@webkit.org>

Removed redundant baselines from Windows port so that rebaselines done in r81059 take effect.

  • platform/win/svg/custom/mouse-move-on-svg-container-expected.txt: Removed.
  • platform/win/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Removed.
  • platform/win/svg/custom/mouse-move-on-svg-root-expected.txt: Removed.
  • platform/win/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Removed.
2:48 PM Changeset in webkit [81062] by luiz@webkit.org
  • 2 edits
    45 adds in trunk/LayoutTests

Adjusting Snow Leopard expected results after r81035.

  • platform/mac/fast/html/details-add-summary-1-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-1-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-10-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-2-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-2-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-3-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-3-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-4-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-4-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-5-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-5-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-6-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-6-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-7-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-7-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-8-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-8-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-9-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-add-summary-9-expected.txt: Added.
  • platform/mac/fast/html/details-no-summary1-expected.txt: Added.
  • platform/mac/fast/html/details-no-summary2-expected.txt: Added.
  • platform/mac/fast/html/details-no-summary3-expected.txt: Added.
  • platform/mac/fast/html/details-no-summary4-expected.txt: Added.
  • platform/mac/fast/html/details-open-javascript-expected.txt: Added.
  • platform/mac/fast/html/details-open1-expected.txt: Added.
  • platform/mac/fast/html/details-open2-expected.txt: Added.
  • platform/mac/fast/html/details-open3-expected.txt: Added.
  • platform/mac/fast/html/details-open4-expected.txt: Added.
  • platform/mac/fast/html/details-open5-expected.txt: Added.
  • platform/mac/fast/html/details-open6-expected.txt: Added.
  • platform/mac/fast/html/details-position-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-1-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-2-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-3-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-4-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-5-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
  • platform/mac/fast/html/details-remove-summary-6-expected.txt: Added.
  • platform/mac/fast/html/details-writing-mode-expected.txt: Added.
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
2:45 PM Changeset in webkit [81061] by rniwa@webkit.org
  • 6 edits in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <​rniwa@webkit.org>

Qt rebaselines for r81053.

  • platform/qt/editing/selection/drag-select-1-expected.txt:
  • platform/qt/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
2:44 PM Changeset in webkit [81060] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit/efl

Try to fix the EFL build-bustage that their EWS bot did not see, but their core-builder did. (sigh)

  • ewk/ewk_history.cpp:

(ewk_history_item_icon_surface_get):
(ewk_history_item_icon_object_add):

2:35 PM Changeset in webkit [81059] by rniwa@webkit.org
  • 6 edits in trunk/LayoutTests

2011-03-14 Ryosuke Niwa <​rniwa@webkit.org>

Mac rebaselines for r81053.

  • platform/mac/fast/text/atsui-rtl-override-selection-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
2:25 PM Changeset in webkit [81058] by beidson@apple.com
  • 11 edits in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=56320
Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"

Reviewed by Anders Carlsson.

../WebCore:

Remove HistoryItem::icon():

  • history/HistoryItem.cpp:
  • history/HistoryItem.h:
  • WebCore.exp.in:
  • loader/icon/IconDatabaseBase.h:

(WebCore::IconDatabaseBase::defaultIcon):

../WebKit/efl:

  • ewk/ewk_history.cpp:

(ewk_history_item_icon_surface_get): Use IconDatabase directly.

../WebKit/mac:

  • History/WebHistoryItem.mm:

(-[WebHistoryItem icon]): This far-future FIXME is now irrelevant.

../WebKit/qt:

  • Api/qwebhistory.cpp:

(QWebHistoryItem::icon): Use IconDatabase directly.

2:22 PM Changeset in webkit [81057] by aestes@apple.com
  • 4 edits
    2 adds in trunk

2011-03-13 Andy Estes <​aestes@apple.com>

Reviewed by Darin Adler.

Timer-based events should inherit the user gesture state of their
originating event in certain cases.
​https://bugs.webkit.org/show_bug.cgi?id=55104

  • fast/events/popup-blocking-timers-expected.txt: Added.
  • fast/events/popup-blocking-timers.html: Added.

2011-03-14 Andy Estes <​aestes@apple.com>

Reviewed by Darin Adler.

Timer-based events should inherit the user gesture state of their
originating event in certain cases.
​https://bugs.webkit.org/show_bug.cgi?id=55104

If a timer is installed by a gesture-originated event and will fire
within one second, the timer-initiated event should behave as if it
were also initiated by a user gesture. Multi-shot timers should only
get this behavior on their first execution. Nested timers should not
get this behavior. This makes us compatible with Gecko when handling
popups and file chooser dialogs created from timer events.

Test: fast/events/popup-blocking-timers.html

  • page/DOMTimer.cpp: (WebCore::timeoutId): Create a helper function so that m_timeoutId can be initialized in the data member initialization list. (WebCore::shouldForwardUserGesture): Ditto, but for m_shouldForwardUserGesture. (WebCore::DOMTimer::DOMTimer): Move initialization of data members from the ctor body to the data member initialization list. Also rename the argument 'timeout' to 'interval'. (WebCore::DOMTimer::fired): Create a UserGestureIndicator and set its state based on the value of m_shouldForwardUserGesture. (WebCore::DOMTimer::adjustMinimumTimerInterval): m_originalTimeout was renamed to m_originalInterval.
  • page/DOMTimer.h: Add m_shouldForwardUserGesture and rename m_originalTimeout to m_originalInterval.
2:19 PM Changeset in webkit [81056] by leviw@chromium.org
  • 3 edits
    2 adds in trunk

2011-03-09 Levi Weintraub <​leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Deleting content directly following a button inserts an unnecessary placeholder
​https://bugs.webkit.org/show_bug.cgi?id=56053

Test to ensure unnecessary placeholders aren't inserted after buttons when delete is pressed.

  • editing/deleting/delete-inserts-br-after-button-expected.txt: Added.
  • editing/deleting/delete-inserts-br-after-button.html: Added.

2011-03-09 Levi Weintraub <​leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Deleting content directly following a button inserts an unnecessary placeholder
​https://bugs.webkit.org/show_bug.cgi?id=56053

Fixing a use of Node's enclosingBlockFlowElement with enclosingBlock htmlediting's
enclosingBlock, as enclosingBlockFlowElement would return inline-block elements despite
DeleteSelectionCommand treating them as blockflow.

Test: editing/deleting/delete-inserts-br-after-button.html

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs):
1:56 PM Changeset in webkit [81055] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=45164

Reviewed by Dan Bernstein.

REGRESSION: <a><img align=top></a> Clickable area too large

Make sure to clamp hit testing of quirky inline flow boxes the same way we already clamped
painting.

Source/WebCore:

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::nodeAtPoint):

LayoutTests:

  • fast/inline/inline-position-top-align-expected.txt: Added.
  • fast/inline/inline-position-top-align.html: Added.
1:53 PM Changeset in webkit [81054] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-03-14 Chris Marrin <​cmarrin@apple.com>

Reviewed by Adam Roben.

REGRESSION (r75138-r75503): Animations on Apple HTML5 Gallery demo are wrong
​https://bugs.webkit.org/show_bug.cgi?id=52845

The lastCommitTime() value in CACFLayerTreeHost was returning as the time
the render previous to this one happened. That often made it seem like
animations started more in the past than they did, breaking many animations.
The startAnimations() call actually fires from a CACF callback after all the
WebKit content has been rendered. So sending currentTime as the start time
to the animations is close enough for proper synchronization.

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp: (WebCore::CACFLayerTreeHost::notifyAnimationsStarted):
1:47 PM Changeset in webkit [81053] by rniwa@webkit.org
  • 8 edits
    2 adds in trunk

2011-03-11 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Selection uses first mousemove's localRect instead of that of mousedown
​https://bugs.webkit.org/show_bug.cgi?id=56213

Fixed the bug by adding an extra call to updateSelectionForMouseDrag in handleMouseDraggedEvent
using the mouse coordinates of the mousedown event that started the drag.

Test: editing/selection/drag-select-rapidly.html

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDraggedEvent):

2011-03-11 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

Selection uses first mousemove's localRect instead of that of mousedown
​https://bugs.webkit.org/show_bug.cgi?id=56213

Added a test to ensure the selection start is computed using the mouse coordinates passed down
to the corresponding mousedown event instead of that of the first mousemove event.

The test is co-authored by Evan Martin.

  • editing/selection/anchor-focus2-expected.txt: Editing delegate changes.
  • editing/selection/anchor-focus3-expected.txt: Ditto.
  • editing/selection/drag-select-rapidly-expected.txt: Added.
  • editing/selection/drag-select-rapidly.html: Added.
  • platform/mac/editing/selection/drag-select-1-expected.txt: Selects the correct range of text.
  • platform/mac/editing/selection/fake-drag-expected.txt: Ditto.
  • platform/mac/editing/selection/inline-closest-leaf-child-expected.txt: Ditto.
1:45 PM Changeset in webkit [81052] by levin@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

Add a baseline for linux for this test since it matches what we have for OSX
except for the typical minor font differences.

  • platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added.
  • platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
  • platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:40 PM Changeset in webkit [81051] by mrowe@apple.com
  • 4 edits in trunk

<​http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • API/JSClassRef.cpp:

(OpaqueJSClass::OpaqueJSClass): Don't leak any existing entry for the given name if
the class definition contains duplicates. This also removes what look to be leaks
of the StringImpl instances that are used as keys: the HashMap key type is a RefPtr
which retains / releases the instances at the appropriate time, so explicitly calling
ref is not necessary.

Tools:

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions): Remove duplicate entries.

1:40 PM Changeset in webkit [81050] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Apply a large, blunt object directly to the skull of the Leopard build.

Reviewed by Timothy Hatcher.

  • Configurations/Base.xcconfig: Disable the generation of debugging symbols when

building the Debug configuration on Leopard. This should cut the size of the object
files that the linker needs to process by over 85%. This will hopefully allow them
to fit in to the 32-bit address space of the Leopard linker.

1:30 PM Changeset in webkit [81049] by hyatt@apple.com
  • 10 edits
    12 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=56246

Reviewed by Beth Dakin.

Add support for relative positioning to table cells. Back out the code that hacked around the lack of support
for offsetLeft, and add new tests to demonstrate that relative positioning works.

Source/WebCore:

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::adjustRenderStyle):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::offsetParent):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRelPositioned):

  • rendering/RenderTableCell.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

  • fast/table/relative-position-containment.html: Added.
  • fast/table/relative-position-offsets.html: Added.
  • fast/table/relative-position-stacking.html: Added.
  • platform/mac/fast/table/overflowHidden-expected.txt:
  • platform/mac/fast/table/relative-position-containment-expected.checksum: Added.
  • platform/mac/fast/table/relative-position-containment-expected.png: Added.
  • platform/mac/fast/table/relative-position-containment-expected.txt: Added.
  • platform/mac/fast/table/relative-position-offsets-expected.checksum: Added.
  • platform/mac/fast/table/relative-position-offsets-expected.png: Added.
  • platform/mac/fast/table/relative-position-offsets-expected.txt: Added.
  • platform/mac/fast/table/relative-position-stacking-expected.checksum: Added.
  • platform/mac/fast/table/relative-position-stacking-expected.png: Added.
  • platform/mac/fast/table/relative-position-stacking-expected.txt: Added.
1:20 PM Changeset in webkit [81048] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

Partial backout of ​https://bugs.webkit.org/show_bug.cgi?id=56230. Go back to repainting the root
layer, since first layouts and printing mess up otherwise.

Reviewed by Beth Dakin.

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

1:19 PM Changeset in webkit [81047] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Improvements for the mondo linux debug failure list changes:

+ Add more tests that belong there.
+ Sort the tests that are there.
+ Add PASS to the lines that are there since these tests are known to pass and a passing

result for them shouldn't cause a test run to go orange.

  • platform/chromium/test_expectations.txt:
12:13 PM Changeset in webkit [81046] by alice.liu@apple.com
  • 2 edits in trunk/Tools

DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"

Reviewed by Dan Bernstein.

  • DumpRenderTree/mac/PerlSupport/Makefile:

Add whitespace when joining "-arch" with the architectures passed in as arguments.

11:59 AM Changeset in webkit [81045] by hyatt@apple.com
  • 5 edits in trunk/Source/WebCore

Clean up full repainting of layers during layout and at other times. Platforms that did not do an invalidation on
size changes were incorrectly relying on the DoFullRepaint case of RenderLayer::updateLayerPositions to invalidate
for them. However this code is now wrong, since it assumed that the outermost layer was a RenderView that encompassed
all of the child layers. This is no longer the case since the overflow changes that tightened up visual overflow
and limited that overflow only to content that the layer painted.

Reviewed by Simon Fraser.

Eliminate the DoFullRepaint flag and actually make no repainting of any kind happen from the layer code if FrameView's
m_doFullRepaint boolean is set. This will flush out any ports that aren't just invalidating the world on their
own in response to view resizes or fixed layout size changes and force them to fix things to be consistent with
the other ports.

Make the two dynamic calls to updateLayerPositions still do a full repaint by setting the repaint flag on the layer.
I'm suspicious as to the correctness of the repainting in both of these cases (both before and after this patch),
but the behavior should be the same.

No new tests, since this is untestable on ports that invalidate on a resize.

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::styleDidChange):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::removeOnlyThisLayer):

  • rendering/RenderLayer.h:
11:51 AM Changeset in webkit [81044] by levin@chromium.org
  • 3 edits
    361 adds in trunk/LayoutTests

Rebaselines due to r81035.
Also, added yet more tests to the linux debug crash sweeping through the layout tests.

  • platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-1-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-10-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-10-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-2-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-3-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-3-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-4-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-4-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-5-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-5-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-6-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-6-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-7-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-7-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-8-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-8-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-add-summary-9-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-add-summary-9-expected.png: Added.
  • platform/chromium-linux/fast/html/details-no-summary1-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-no-summary1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-no-summary2-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-no-summary2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-no-summary3-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-no-summary3-expected.png: Added.
  • platform/chromium-linux/fast/html/details-no-summary4-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-no-summary4-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open-javascript-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-open-javascript-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open1-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-open1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open2-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-open2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open3-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-open3-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open4-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-open4-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open5-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-open5-expected.png: Added.
  • platform/chromium-linux/fast/html/details-open6-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-open6-expected.png: Added.
  • platform/chromium-linux/fast/html/details-position-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-position-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-1-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-1-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-2-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-2-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-3-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-3-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-4-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-4-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-5-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-5-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-6-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-remove-summary-6-expected.png: Added.
  • platform/chromium-linux/fast/html/details-writing-mode-expected.checksum: Added.
  • platform/chromium-linux/fast/html/details-writing-mode-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-1-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-10-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-2-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-3-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-4-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-5-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-6-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-7-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-8-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.png: Added.
  • platform/chromium-mac/fast/html/details-add-summary-9-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-no-summary1-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-no-summary1-expected.png: Added.
  • platform/chromium-mac/fast/html/details-no-summary1-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-no-summary2-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-no-summary2-expected.png: Added.
  • platform/chromium-mac/fast/html/details-no-summary2-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-no-summary3-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-no-summary3-expected.png: Added.
  • platform/chromium-mac/fast/html/details-no-summary3-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-no-summary4-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-no-summary4-expected.png: Added.
  • platform/chromium-mac/fast/html/details-no-summary4-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-open-javascript-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-open-javascript-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open-javascript-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-open1-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-open1-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open1-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-open2-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-open2-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open2-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-open3-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-open3-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open3-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-open4-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-open4-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open4-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-open5-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-open5-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open5-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-open6-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-open6-expected.png: Added.
  • platform/chromium-mac/fast/html/details-open6-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-position-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-position-expected.png: Added.
  • platform/chromium-mac/fast/html/details-position-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-1-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-2-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-3-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-4-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-5-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.png: Added.
  • platform/chromium-mac/fast/html/details-remove-summary-6-expected.txt: Added.
  • platform/chromium-mac/fast/html/details-writing-mode-expected.checksum: Added.
  • platform/chromium-mac/fast/html/details-writing-mode-expected.png: Added.
  • platform/chromium-mac/fast/html/details-writing-mode-expected.txt: Added.
  • platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-1-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-1-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-10-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-10-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-10-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-2-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-2-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-3-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-3-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-3-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-4-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-4-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-4-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-5-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-5-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-5-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-6-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-6-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-6-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-7-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-7-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-7-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-8-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-8-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-8-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-add-summary-9-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-add-summary-9-expected.png: Added.
  • platform/chromium-win/fast/html/details-add-summary-9-expected.txt: Added.
  • platform/chromium-win/fast/html/details-no-summary1-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-no-summary1-expected.png: Added.
  • platform/chromium-win/fast/html/details-no-summary1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-no-summary2-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-no-summary2-expected.png: Added.
  • platform/chromium-win/fast/html/details-no-summary2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-no-summary3-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-no-summary3-expected.png: Added.
  • platform/chromium-win/fast/html/details-no-summary3-expected.txt: Added.
  • platform/chromium-win/fast/html/details-no-summary4-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-no-summary4-expected.png: Added.
  • platform/chromium-win/fast/html/details-no-summary4-expected.txt: Added.
  • platform/chromium-win/fast/html/details-open-javascript-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-open-javascript-expected.png: Added.
  • platform/chromium-win/fast/html/details-open-javascript-expected.txt: Added.
  • platform/chromium-win/fast/html/details-open1-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-open1-expected.png: Added.
  • platform/chromium-win/fast/html/details-open1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-open2-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-open2-expected.png: Added.
  • platform/chromium-win/fast/html/details-open2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-open3-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-open3-expected.png: Added.
  • platform/chromium-win/fast/html/details-open3-expected.txt: Added.
  • platform/chromium-win/fast/html/details-open4-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-open4-expected.png: Added.
  • platform/chromium-win/fast/html/details-open4-expected.txt: Added.
  • platform/chromium-win/fast/html/details-open5-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-open5-expected.png: Added.
  • platform/chromium-win/fast/html/details-open5-expected.txt: Added.
  • platform/chromium-win/fast/html/details-open6-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-open6-expected.png: Added.
  • platform/chromium-win/fast/html/details-open6-expected.txt: Added.
  • platform/chromium-win/fast/html/details-position-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-position-expected.png: Added.
  • platform/chromium-win/fast/html/details-position-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-1-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-1-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-1-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-2-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-2-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-2-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-3-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-3-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-3-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-4-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-4-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-4-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-5-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-5-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-5-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
  • platform/chromium-win/fast/html/details-remove-summary-6-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-remove-summary-6-expected.png: Added.
  • platform/chromium-win/fast/html/details-remove-summary-6-expected.txt: Added.
  • platform/chromium-win/fast/html/details-writing-mode-expected.checksum: Added.
  • platform/chromium-win/fast/html/details-writing-mode-expected.png: Added.
  • platform/chromium-win/fast/html/details-writing-mode-expected.txt: Added.
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/chromium/test_expectations.txt:
11:39 AM Changeset in webkit [81043] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix windows build

11:38 AM Changeset in webkit [81042] by dbates@webkit.org
  • 2 edits in trunk/Tools

2011-03-14 Daniel Bates <​dbates@rim.com>

​https://bugs.webkit.org/show_bug.cgi?id=55438
Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
when landing changeset 81041 <​http://trac.webkit.org/changeset/81041>.

  • Scripts/build-webkit:
11:23 AM Changeset in webkit [81041] by dbates@webkit.org
  • 3 edits in trunk/Tools

2011-03-14 Daniel Bates <​dbates@rim.com>

Reviewed by David Kilzer.

Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
​https://bugs.webkit.org/show_bug.cgi?id=55438

Separate out the EFL- and WinCE-specific logic from the port-independent logic in
webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
CMake arguments for feature defines.

  • Scripts/build-webkit:
    • Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
    • Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
    • Sorted forward declarations.
    • Initialize $makeArgs with the empty string so as to simplify its use in string operations; Modified call sites as needed.
  • Scripts/webkitdirs.pm:
    • Added cleanCMakeGeneratedProject() to clean a CMake build.
    • Added buildCMakeGeneratedProject() to build using generated build system.
    • Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
    • Added generateBuildSystemFromCMakeProject() to generate the build system from a CMake project.
    • Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
11:16 AM Changeset in webkit [81040] by oliver@apple.com
  • 32 edits in trunk/Source

2011-03-11 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Ensure all values are correctly tagged in the registerfile
​https://bugs.webkit.org/show_bug.cgi?id=56214

This patch makes sure that all JSCell pointers written to
the registerfile are correctly tagged as JSCells, and replaces
raw int usage with the immediate representation.

For performance, register pressure, and general saneness reasons
I've added abstractions for reading and writing the tag
and payload of integer registers directly for the JSVALUE64
encoding.

  • interpreter/Register.h: (JSC::Register::withInt): (JSC::Register::withCallee): (JSC::Register::operator=): (JSC::Register::i): (JSC::Register::activation): (JSC::Register::function): (JSC::Register::propertyNameIterator): (JSC::Register::scopeChain):
  • jit/JIT.h:
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall):
  • jit/JITCall32_64.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITInlineMethods.h: (JSC::JIT::emitPutToCallFrameHeader): (JSC::JIT::emitPutCellToCallFrameHeader): (JSC::JIT::emitPutIntToCallFrameHeader):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname): (JSC::JIT::emit_op_load_varargs): (JSC::JIT::emitSlow_op_load_varargs):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname):
  • jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::intPayloadFor): (JSC::JSInterfaceJIT::intTagFor):
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::returnJSValue): (JSC::SpecializedThunkJIT::returnDouble): (JSC::SpecializedThunkJIT::returnInt32): (JSC::SpecializedThunkJIT::returnJSCell):

2011-03-11 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Ensure all values are correctly tagged in the registerfile
​https://bugs.webkit.org/show_bug.cgi?id=56214

Make sure everything builds still.

  • bridge/c/c_class.cpp:
  • bridge/c/c_runtime.cpp:
  • bridge/jni/JavaMethod.cpp:
  • plugins/PluginViewNone.cpp:
11:02 AM Changeset in webkit [81039] by luiz@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix for r81035.

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::defaultEventHandler):

  • rendering/RenderDetailsMarker.cpp:

(WebCore::createDownArrowPath):
(WebCore::createUpArrowPath):
(WebCore::createLeftArrowPath):
(WebCore::createRightArrowPath):

10:52 AM Changeset in webkit [81038] by jer.noble@apple.com
  • 15 edits
    4 adds in trunk

2011-03-12 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

FullScreen: Handle entering full screen security restrictions
​https://bugs.webkit.org/show_bug.cgi?id=56264

  • fullscreen/full-screen-css.html: Use runWithKeyDown.
  • fullscreen/full-screen-remove-ancestor.html: Ditto.
  • fullscreen/full-screen-remove.html: Ditto.
  • fullscreen/full-screen-request.html: Ditto.
  • fullscreen/full-screen-twice.html: Ditto.
  • fullscreen/full-screen-test.js:
  • fullscreen/full-screen-iframe-allowed-expected.txt: Added.
  • fullscreen/full-screen-iframe-allowed.html: Added.
  • fullscreen/full-screen-iframe-not-allowed-expected.txt: Added.
  • fullscreen/full-screen-iframe-not-allowed.html: Added. (runWithKeyDown): Added. Wraps the command in a keyDown/keyPress

listener.

  • platform/mac-wk2/Skipped: Added new tests to skipped list.
  • platform/qt-wk2/Skipped: Ditto.

2011-03-13 Jer Noble <​jer.noble@apple.com>

FullScreen: Handle entering full screen security restrictions
​https://bugs.webkit.org/show_bug.cgi?id=56264

Tests: fullscreen/full-screen-iframe-allowed.html

fullscreen/full-screen-iframe-not-allowed.html

Disable full screen documents in the following conditions:
1) requesting element is in an iframe which does not have a
webkitallowfullscreen attribute.
2) page is not processing a user gesture.

  • dom/Document.cpp: (WebCore::Document::fullScreenIsAllowedForElement): Added. Checks

to see if elements contained in IFRAMES are allowed to
enter full screen.

(WebCore::Document::webkitRequestFullScreenForElement): Checks

if page is currently processing a user gesture.

  • dom/Document.h:
  • html/HTMLAttributeNames.in: Added webkitallowfullscreenAttr.
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::allowFullScreen): Added.
  • html/HTMLFrameElementBase.h:
10:46 AM Changeset in webkit [81037] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r80892): Use of uninitialized variable "m_syncCloseDatabase" in StorageAreaSync::sync
​https://bugs.webkit.org/show_bug.cgi?id=56303

Patch by Anton D'Auria <​adauria@apple.com> on 2011-03-14
Reviewed by David Levin.

Initialized m_syncCloseDatabase to false in the StorageAreaSync constructor.

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::StorageAreaSync):

10:39 AM Changeset in webkit [81036] by steveblock@google.com
  • 3 edits in trunk/Source/WebCore

2011-03-14 Steve Block <​steveblock@google.com>

Reviewed by Oliver Hunt.

JavaMethod.cpp does not compile with V8
​https://bugs.webkit.org/show_bug.cgi?id=56306

Moved the ScopeChain.h include to JavaStringJSC.

No new tests, build fix only.

  • bridge/jni/JavaMethod.cpp:
  • bridge/jni/jsc/JavaStringJSC.h
10:35 AM Changeset in webkit [81035] by luiz@webkit.org
  • 15 edits
    92 adds in trunk

HTML5 <details> and <summary>: rendering
​https://bugs.webkit.org/show_bug.cgi?id=51071

Reviewed by Dave Hyatt.

Source/WebCore:

Tests: fast/html/details-add-summary-1-and-click.html

fast/html/details-add-summary-1.html
fast/html/details-add-summary-10-and-click.html
fast/html/details-add-summary-10.html
fast/html/details-add-summary-2-and-click.html
fast/html/details-add-summary-2.html
fast/html/details-add-summary-3-and-click.html
fast/html/details-add-summary-3.html
fast/html/details-add-summary-4-and-click.html
fast/html/details-add-summary-4.html
fast/html/details-add-summary-5-and-click.html
fast/html/details-add-summary-5.html
fast/html/details-add-summary-6-and-click.html
fast/html/details-add-summary-6.html
fast/html/details-add-summary-7-and-click.html
fast/html/details-add-summary-7.html
fast/html/details-add-summary-8-and-click.html
fast/html/details-add-summary-8.html
fast/html/details-add-summary-9-and-click.html
fast/html/details-add-summary-9.html
fast/html/details-mouse-click.html
fast/html/details-no-summary1.html
fast/html/details-no-summary2.html
fast/html/details-no-summary3.html
fast/html/details-no-summary4.html
fast/html/details-open-javascript.html
fast/html/details-open1.html
fast/html/details-open2.html
fast/html/details-open3.html
fast/html/details-open4.html
fast/html/details-open5.html
fast/html/details-open6.html
fast/html/details-position.html
fast/html/details-remove-summary-1-and-click.html
fast/html/details-remove-summary-1.html
fast/html/details-remove-summary-2-and-click.html
fast/html/details-remove-summary-2.html
fast/html/details-remove-summary-3-and-click.html
fast/html/details-remove-summary-3.html
fast/html/details-remove-summary-4-and-click.html
fast/html/details-remove-summary-4.html
fast/html/details-remove-summary-5-and-click.html
fast/html/details-remove-summary-5.html
fast/html/details-remove-summary-6-and-click.html
fast/html/details-remove-summary-6.html
fast/html/details-writing-mode.html

​http://www.w3.org/TR/html5/interactive-elements.html#the-details-element

The main <summary> element is the first <summary> element of a <details> element.
All other childs of the <details> element are rendered only if the attribute 'open' is set.
Click event toggles the 'open' attribute.

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::HTMLDetailsElement):
(WebCore::HTMLDetailsElement::findMainSummary):
(WebCore::HTMLDetailsElement::childrenChanged):
(WebCore::HTMLDetailsElement::finishParsingChildren):
(WebCore::HTMLDetailsElement::parseMappedAttribute):
(WebCore::HTMLDetailsElement::childShouldCreateRenderer):
(WebCore::HTMLDetailsElement::defaultEventHandler):

  • html/HTMLDetailsElement.h:

(WebCore::HTMLDetailsElement::mainSummary):

Method createRenderer added to class HTMLSummaryElement.

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::createRenderer):

  • html/HTMLSummaryElement.h:

The first <summary> element is positioned at the top of its <details> parent.
The area occupied by this main <summary> element is the interactive area of the
<details> element. If the <details> tag has no <summary> child an OwnedSummaryRenderer
is created and added to the corresponding RenderDetails object.

  • rendering/RenderDetails.cpp:

(WebCore::RenderDetails::RenderDetails):
(WebCore::RenderDetails::destroy):
(WebCore::RenderDetails::summaryBlock):
(WebCore::RenderDetails::contentBlock):
(WebCore::RenderDetails::addChild):
(WebCore::RenderDetails::removeChild):
(WebCore::RenderDetails::setMarkerStyle):
(WebCore::RenderDetails::styleDidChange):
(WebCore::RenderDetails::getRenderPosition):
(WebCore::RenderDetails::markerDestroyed):
(WebCore::RenderDetails::summaryDestroyed):
(WebCore::RenderDetails::moveSummaryToContents):
(WebCore::RenderDetails::createSummaryStyle):
(WebCore::RenderDetails::replaceMainSummary):
(WebCore::RenderDetails::createDefaultSummary):
(WebCore::RenderDetails::checkMainSummary):
(WebCore::RenderDetails::layout):
(WebCore::RenderDetails::isOpen):
(WebCore::RenderDetails::getParentOfFirstLineBox):
(WebCore::RenderDetails::firstNonMarkerChild):
(WebCore::RenderDetails::updateMarkerLocation):

  • rendering/RenderDetails.h:

(WebCore::RenderDetails::interactiveArea):
(WebCore::RenderDetails::removeLeftoverAnonymousBlock):
(WebCore::RenderDetails::createsAnonymousWrapper):
(WebCore::RenderDetails::requiresForcedStyleRecalcPropagation):

A marker is added to the main <summary> element to indicate the current value of the 'open'
attribute of the <details> element.

  • rendering/RenderDetailsMarker.cpp:

(WebCore::RenderDetailsMarker::RenderDetailsMarker):
(WebCore::RenderDetailsMarker::destroy):
(WebCore::RenderDetailsMarker::lineHeight):
(WebCore::RenderDetailsMarker::baselinePosition):
(WebCore::RenderDetailsMarker::computePreferredLogicalWidths):
(WebCore::RenderDetailsMarker::layout):
(WebCore::RenderDetailsMarker::getRelativeMarkerRect):
(WebCore::RenderDetailsMarker::isOpen):
(WebCore::createPath):
(WebCore::createDownArrowPath):
(WebCore::createUpArrowPath):
(WebCore::createLeftArrowPath):
(WebCore::createRightArrowPath):
(WebCore::RenderDetailsMarker::orientation):
(WebCore::RenderDetailsMarker::getCanonicalPath):
(WebCore::RenderDetailsMarker::getPath):
(WebCore::RenderDetailsMarker::paint):

  • rendering/RenderDetailsMarker.h:

(WebCore::toRenderDetailsMarker):

  • rendering/RenderSummary.cpp:

(WebCore::RenderSummary::RenderSummary):
(WebCore::RenderSummary::destroy):
(WebCore::RenderSummary::parentDetails):
(WebCore::RenderSummary::styleDidChange):

  • rendering/RenderSummary.h:
  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

LayoutTests:

  • fast/html/details-add-summary-1-and-click.html: Added.
  • fast/html/details-add-summary-1.html: Added.
  • fast/html/details-add-summary-10-and-click.html: Added.
  • fast/html/details-add-summary-10.html: Added.
  • fast/html/details-add-summary-2-and-click.html: Added.
  • fast/html/details-add-summary-2.html: Added.
  • fast/html/details-add-summary-3-and-click.html: Added.
  • fast/html/details-add-summary-3.html: Added.
  • fast/html/details-add-summary-4-and-click.html: Added.
  • fast/html/details-add-summary-4.html: Added.
  • fast/html/details-add-summary-5-and-click.html: Added.
  • fast/html/details-add-summary-5.html: Added.
  • fast/html/details-add-summary-6-and-click.html: Added.
  • fast/html/details-add-summary-6.html: Added.
  • fast/html/details-add-summary-7-and-click.html: Added.
  • fast/html/details-add-summary-7.html: Added.
  • fast/html/details-add-summary-8-and-click.html: Added.
  • fast/html/details-add-summary-8.html: Added.
  • fast/html/details-add-summary-9-and-click.html: Added.
  • fast/html/details-add-summary-9.html: Added.
  • fast/html/details-mouse-click-expected.txt: Added.
  • fast/html/details-mouse-click.html: Added.
  • fast/html/details-no-summary1.html: Added.
  • fast/html/details-no-summary2.html: Added.
  • fast/html/details-no-summary3.html: Added.
  • fast/html/details-no-summary4.html: Added.
  • fast/html/details-open-javascript.html: Added.
  • fast/html/details-open1.html: Added.
  • fast/html/details-open2.html: Added.
  • fast/html/details-open3.html: Added.
  • fast/html/details-open4.html: Added.
  • fast/html/details-open5.html: Added.
  • fast/html/details-open6.html: Added.
  • fast/html/details-position.html: Added.
  • fast/html/details-remove-summary-1-and-click.html: Added.
  • fast/html/details-remove-summary-1.html: Added.
  • fast/html/details-remove-summary-2-and-click.html: Added.
  • fast/html/details-remove-summary-2.html: Added.
  • fast/html/details-remove-summary-3-and-click.html: Added.
  • fast/html/details-remove-summary-3.html: Added.
  • fast/html/details-remove-summary-4-and-click.html: Added.
  • fast/html/details-remove-summary-4.html: Added.
  • fast/html/details-remove-summary-5-and-click.html: Added.
  • fast/html/details-remove-summary-5.html: Added.
  • fast/html/details-remove-summary-6-and-click.html: Added.
  • fast/html/details-remove-summary-6.html: Added.
  • fast/html/details-writing-mode.html: Added.
  • platform/qt/fast/html/details-add-summary-1-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-1-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-10-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-10-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-2-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-2-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-3-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-3-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-4-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-4-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-5-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-5-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-6-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-6-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-7-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-7-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-8-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-8-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-9-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-add-summary-9-expected.txt: Added.
  • platform/qt/fast/html/details-no-summary1-expected.txt: Added.
  • platform/qt/fast/html/details-no-summary2-expected.txt: Added.
  • platform/qt/fast/html/details-no-summary3-expected.txt: Added.
  • platform/qt/fast/html/details-no-summary4-expected.txt: Added.
  • platform/qt/fast/html/details-open-javascript-expected.txt: Added.
  • platform/qt/fast/html/details-open1-expected.txt: Added.
  • platform/qt/fast/html/details-open2-expected.txt: Added.
  • platform/qt/fast/html/details-open3-expected.txt: Added.
  • platform/qt/fast/html/details-open4-expected.txt: Added.
  • platform/qt/fast/html/details-open5-expected.txt: Added.
  • platform/qt/fast/html/details-open6-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-1-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-2-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-3-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-4-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-5-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
  • platform/qt/fast/html/details-remove-summary-6-expected.txt: Added.
  • platform/qt/fast/html/details-writing-mode-expected.txt: Added.
  • platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
10:20 AM Changeset in webkit [81034] by beidson@apple.com
  • 3 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=56296
Clean up IconDatabaseBase header.

Reviewed by Sam Weinig.

-Get rid of the "PlatformString.h" include and replace it with a forward declaration.
-Group methods by which are used in WebCore directly and which are used in WebKit ports.

This'll make it easier to use in external frameworks (like WebKit2).

  • loader/icon/IconDatabase.h:
  • loader/icon/IconDatabaseBase.h:

(WebCore::IconDatabaseBase::retainIconForPageURL):
(WebCore::IconDatabaseBase::releaseIconForPageURL):
(WebCore::IconDatabaseBase::iconForPageURL):
(WebCore::IconDatabaseBase::setIconURLForPageURL):
(WebCore::IconDatabaseBase::setIconDataForIconURL):
(WebCore::IconDatabaseBase::iconDataKnownForIconURL):
(WebCore::IconDatabaseBase::loadDecisionForIconURL):
(WebCore::IconDatabaseBase::importIconURLForPageURL):
(WebCore::IconDatabaseBase::importIconDataForIconURL):
(WebCore::IconDatabaseBase::open):

9:47 AM Changeset in webkit [81033] by enne@google.com
  • 3 edits in branches/chromium/648/Source/WebCore

Merge 76437 - 2011-01-22 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Fix compositor repaints for offscreen fixed elements
​https://bugs.webkit.org/show_bug.cgi?id=52681

The fast path scrolling was clipping offscreen invalidations.
Additionally, the compositor was ignoring all invalidations that were
entirely out of the content rect.

Test: compositing/ to verify this caused no regressions.
Tested fix manually in browser as I could not generate a LayoutTest that reproduced the bug in run-webkit-tests.

  • page/FrameView.cpp: (WebCore::FrameView::scrollContentsFastPath):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::invalidateRootLayerRect):

TBR=​enne@google.com
Review URL: ​http://codereview.chromium.org/6686050

9:47 AM Changeset in webkit [81032] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2: No icon shown for <input type=file>
<rdar://problem/8988982>
​https://bugs.webkit.org/show_bug.cgi?id=54288

Reviewed by Darin Adler.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::chooseIconForFiles):
Add implementation for chooseIconForFiles which calls down to Icon::createIconForFiles.

9:46 AM Changeset in webkit [81031] by enne@google.com
  • 3 edits in branches/chromium/648/Source/WebCore

Merge 76864 - 2011-01-27 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

[chromium] Tiled compositor crashes if compositing turned off mid-paint
​https://bugs.webkit.org/show_bug.cgi?id=53198

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::draw):

TBR=​enne@google.com
Review URL: ​http://codereview.chromium.org/6686049

9:43 AM Changeset in webkit [81030] by podivilov@chromium.org
  • 14 edits
    2 deletes in trunk

2011-03-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81026.
​http://trac.webkit.org/changeset/81026
​https://bugs.webkit.org/show_bug.cgi?id=56313

Breaks gtk 64-bit tests (Requested by podivilov on #webkit).

  • inspector/debugger/xhr-breakpoints-expected.txt: Removed.
  • inspector/debugger/xhr-breakpoints.html: Removed.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81026.
​http://trac.webkit.org/changeset/81026
​https://bugs.webkit.org/show_bug.cgi?id=56313

Breaks gtk 64-bit tests (Requested by podivilov on #webkit).

  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorBrowserDebuggerAgent::clear):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.createXHRBreakpoint): (WebInspector.BreakpointManager.prototype._createXHRBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._validateBreakpoints): (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId): (WebInspector.BreakpointManager.prototype._createXHRBreakpointId): (WebInspector.XHRBreakpoint): (WebInspector.XHRBreakpoint.prototype._enable): (WebInspector.XHRBreakpoint.prototype._disable): (WebInspector.XHRBreakpoint.prototype._serializeToJSON): (WebInspector.XHRBreakpointView): (WebInspector.XHRBreakpointView.prototype.compareTo): (WebInspector.XHRBreakpointView.prototype.populateEditElement): (WebInspector.XHRBreakpointView.prototype.populateLabelElement): (WebInspector.XHRBreakpointView.prototype.populateStatusMessageElement):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane.addButtonClicked): (WebInspector.XHRBreakpointsSidebarPane): (WebInspector.XHRBreakpointsSidebarPane.prototype.addBreakpointItem): (WebInspector.XHRBreakpointsSidebarPane.prototype._startEditingBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._hideEditBreakpointDialog):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearInterface):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/inspector.js: (WebInspector.resetFocusElement): (WebInspector.createXHRBreakpointsSidebarPane.breakpointAdded): (WebInspector.createXHRBreakpointsSidebarPane): (WebInspector.set attached):
9:08 AM Changeset in webkit [81029] by mnaganov@chromium.org
  • 3 edits
    2 adds in trunk

2011-03-14 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Factor out binary search algo from the insertionIndexForObjectInListSortedByFunction function.
​https://bugs.webkit.org/show_bug.cgi?id=56312

Test: inspector/utilities.html

  • inspector/front-end/utilities.js:

2011-03-14 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Factor out binary search algo from the insertionIndexForObjectInListSortedByFunction function.
​https://bugs.webkit.org/show_bug.cgi?id=56312

  • inspector/utilities-expected.txt: Added.
  • inspector/utilities.html: Added.
8:33 AM Changeset in webkit [81028] by antonm@chromium.org
  • 2 edits in branches/chromium/696/Source/WebCore

Merge 80842 - 2011-03-11 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Change the way group id for CSS objects is calculated
​https://bugs.webkit.org/show_bug.cgi?id=56117

Do not treat CSSStyleDeclarations under not CSSRule as belonging to the same object group
as they should not be reachable in JavaScript.

Covered by existing layout tests. Fact of absence of retention is not trivial to prove.

  • bindings/v8/V8GCController.cpp: (WebCore::calculateGroupId): (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper):

TBR=​antonm@chromium.org

8:32 AM Changeset in webkit [81027] by antonm@chromium.org
  • 2 edits in branches/chromium/648/Source/WebCore

Merge 80842 - 2011-03-11 Anton Muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Change the way group id for CSS objects is calculated
​https://bugs.webkit.org/show_bug.cgi?id=56117

Do not treat CSSStyleDeclarations under not CSSRule as belonging to the same object group
as they should not be reachable in JavaScript.

Covered by existing layout tests. Fact of absence of retention is not trivial to prove.

  • bindings/v8/V8GCController.cpp: (WebCore::calculateGroupId): (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper):

TBR=​antonm@chromium.org
Review URL: ​http://codereview.chromium.org/6691008

8:27 AM Changeset in webkit [81026] by podivilov@chromium.org
  • 14 edits
    2 adds in trunk

2011-03-12 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: re-implement xhr breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=56252

  • inspector/debugger/xhr-breakpoints-expected.txt: Added.
  • inspector/debugger/xhr-breakpoints.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-03-12 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: re-implement xhr breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=56252

  • restore xhr breakpoints one by one instead of using setAllBrowserBreakpoints
  • store xhr breakpoints in a separate setting
  • move presentation-related code from BreakpointManager to XHRBreakpointsSidebarPane

Test: inspector/debugger/xhr-breakpoints.html

  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorBrowserDebuggerAgent::clear):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.setXHRBreakpoint): (WebInspector.BreakpointManager.prototype.removeXHRBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._validateBreakpoints): (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane): (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked.finishEditing): (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu.removeBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu): (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked.finishEditing): (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype.highlightBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype.clearBreakpointHighlight): (WebInspector.XHRBreakpointsSidebarPane.prototype._saveBreakpoints): (WebInspector.XHRBreakpointsSidebarPane.prototype._restoreBreakpoints): (WebInspector.XHRBreakpointsSidebarPane.prototype._projectChanged):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype._xhrBreakpointHit):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearInterface):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/inspector.js: (WebInspector.resetFocusElement): (WebInspector.set attached):
8:16 AM Changeset in webkit [81025] by podivilov@chromium.org
  • 7 edits in trunk

2011-03-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move breakpoints restoring to debugger presentation model.
​https://bugs.webkit.org/show_bug.cgi?id=56123

  • http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):

2011-03-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move breakpoints restoring to debugger presentation model.
​https://bugs.webkit.org/show_bug.cgi?id=56123

DebuggerModel's "breakpoint-added" and "breakpoint-removed" events are gone since
setBreakpoint/removeBreakpoint are now called from DPM only.

  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::disable): (WebCore::InspectorDebuggerAgent::enableDebuggerAfterShown):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.enableDebugger): (WebInspector.DebuggerModel.prototype._debuggerWasEnabled): (WebInspector.DebuggerModel.prototype._debuggerWasDisabled): (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId): (WebInspector.DebuggerModel.prototype.removeBreakpoint): (WebInspector.DebuggerModel.prototype._breakpointResolved): (WebInspector.DebuggerModel.prototype.reset): (WebInspector.DebuggerDispatcher.prototype.debuggerWasEnabled): (WebInspector.DebuggerDispatcher.prototype.debuggerWasDisabled):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled): (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource): (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource): (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged): (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId): (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled): (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved): (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints): (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints): (WebInspector.DebuggerPresentationModel.prototype.reset):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):
7:21 AM Changeset in webkit [81024] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r81015.
​http://trac.webkit.org/changeset/81015
​https://bugs.webkit.org/show_bug.cgi?id=56308

A Similar patch landed in r76960 (Requested by philn-tp on
#webkit).

  • GNUmakefile.am:
7:00 AM Changeset in webkit [81023] by pfeldman@chromium.org
  • 10 edits in trunk

2011-03-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: don't use innerText, use textContent instead.
​https://bugs.webkit.org/show_bug.cgi?id=56307

  • inspector/elements/edit-dom-actions-expected.txt:
  • inspector/elements/edit-dom-actions.html:
  • inspector/extensions/extensions-audits-expected.txt:

2011-03-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: don't use innerText, use textContent instead.
​https://bugs.webkit.org/show_bug.cgi?id=56307

  • inspector/front-end/AuditFormatters.js: (WebInspector.AuditFormatters.snippet):
  • inspector/front-end/ElementsTreeOutline.js:
  • inspector/front-end/GoToLineDialog.js:
  • inspector/front-end/HelpScreen.js: (WebInspector.HelpScreen):
  • inspector/front-end/ShortcutsHelp.js: (WebInspector.ShortcutsSection.prototype.renderSection): (WebInspector.ShortcutsSection.prototype._renderHeader):
6:44 AM Changeset in webkit [81022] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-14 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [Text editor] Disable live-edit in favor of the text editor
​https://bugs.webkit.org/show_bug.cgi?id=56176

  • inspector/front-end/Settings.js:
6:41 AM Changeset in webkit [81021] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-14 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] scroll does not work in source frame when mouse is inside the gutter
​https://bugs.webkit.org/show_bug.cgi?id=56095

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer):
6:36 AM Changeset in webkit [81020] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-03-11 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move breakpoints restoring after live edit to debugger presentation model.
​https://bugs.webkit.org/show_bug.cgi?id=56179

Presentation model should move breakpoints based on text diff as required by "revert to revision" action in resources panel.

  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype.reset): (WebInspector.DebuggerModel.prototype.editScriptSource.didEditScriptSource): (WebInspector.DebuggerModel.prototype.editScriptSource): (WebInspector.DebuggerModel.prototype.get callFrames): (WebInspector.DebuggerModel.prototype._pausedScript): (WebInspector.DebuggerModel.prototype._resumedScript):
  • inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
5:51 AM Changeset in webkit [81019] by apavlov@chromium.org
  • 6 edits in trunk

2011-03-10 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Optimize backend-frontend data transfer volume for CSS styles
​https://bugs.webkit.org/show_bug.cgi?id=56111

  • inspector/styles/styles-new-API.html:
  • inspector/styles/styles-source-offsets.html:

2011-03-10 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Optimize backend-frontend data transfer volume for CSS styles
​https://bugs.webkit.org/show_bug.cgi?id=56111

This change reduces the getStylesForNode() payload more than twice for BODY elements.

  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::populateObjectWithStyleProperties):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSProperty.parsePayload):
5:26 AM Changeset in webkit [81018] by jknotten@chromium.org
  • 31 edits
    4 adds in trunk

2011-03-14 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

Detach Geolocation from Frame when Page destroyed.
​https://bugs.webkit.org/show_bug.cgi?id=52877

Ensure that all geolocation permission requests are cancelled
when the page is detached from its frame.

Fix fast/dom/Geolocation/window-close-popup.html to ignore position error
generated on watch when window is closed.

  • fast/dom/Geolocation/page-reload-cancel-permission-requests-expected.txt: Added.
  • fast/dom/Geolocation/page-reload-cancel-permission-requests.html: Added.
  • fast/dom/Geolocation/resources/page-reload-cancel-permission-requests-inner.html: Added.
  • fast/dom/Geolocation/script-tests/page-reload-cancel-permission-requests.js: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt-wk2/Skipped:

2011-03-14 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

Detach Geolocation from Frame when Page destroyed.
​https://bugs.webkit.org/show_bug.cgi?id=52877

On Page destruction, any outstanding Geolocation permission
requests should be cancelled, because the Geolocation can only
access the client indirectly via m_frame->page().

Page destruction is signalled by a call to the
Frame::pageDestroyed() method. This explictly calls
DOMWindow::resetGeolocation which ultimately calls Geolocation::reset.

Geolocation::reset() detaches from the GeolocationController,
cancels requests, watches and single shots, and sets the
permission state back to Unknown.

Frame::pageDestroyed() is also called by FrameLoader even though
the page is not destroyed. We should still cancel permission
requests, because the GeolocationClient will become inaccessible
to the Geolocation object after this call.

Frame::transferChildFrameToNewDocument also indirectly calls
Geolocation::reset when the frame is reparented between
pages. Ideally we would like the Geolocation's activities to
continue after reparenting, see bug
​https://bugs.webkit.org/show_bug.cgi?id=55577

Since GeolocationController is owned by Page, and all Geolocation
objects will now unsubscribe from the GeolocationController on
pageDetached(), we no longer need to call stopUpdating() from the
GeolocationController's destructor. Instead we can simply assert
that there should be no no observers. See related bug
​https://bugs.webkit.org/show_bug.cgi?id=52216 .

Introduced new method 'numberOfPendingPermissionRequests' on
GeolocationClientMock to count the number of outstanding pending
permission requests. This provides a reusable implementation for
client-based implementations of the LayoutTestController's
numberOfPendingGeolocationPermissionRequests method.

Test: fast/dom/Geolocation/page-reload-cancel-permission-requests.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::resetGeolocation):
  • page/DOMWindow.h:
  • page/Frame.cpp: (WebCore::Frame::pageDestroyed): (WebCore::Frame::transferChildFrameToNewDocument):
  • page/Geolocation.cpp: (WebCore::Geolocation::~Geolocation): (WebCore::Geolocation::page): (WebCore::Geolocation::reset): (WebCore::Geolocation::disconnectFrame): (WebCore::Geolocation::lastPosition): (WebCore::Geolocation::requestPermission): (WebCore::Geolocation::startUpdating): (WebCore::Geolocation::stopUpdating):
  • page/Geolocation.h:
  • page/GeolocationController.cpp: (WebCore::GeolocationController::~GeolocationController):
  • page/Navigator.cpp: (WebCore::Navigator::resetGeolocation):
  • page/Navigator.h:
  • platform/mock/GeolocationClientMock.cpp: (WebCore::GeolocationClientMock::numberOfPendingPermissionRequests):
  • platform/mock/GeolocationClientMock.h:

2011-03-14 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

Detach Geolocation from Frame when Page destroyed.
​https://bugs.webkit.org/show_bug.cgi?id=52877

Add accessors to the WebGeolocationClientMock to allow the number of
pending geolocation permission requests to be queried.

  • public/WebGeolocationClientMock.h:
  • src/WebGeolocationClientMock.cpp: (WebKit::WebGeolocationClientMock::numberOfPendingPermissionRequests):

2011-03-14 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

Detach Geolocation from Frame when Page destroyed.
​https://bugs.webkit.org/show_bug.cgi?id=52877

Extend the layout test controller to expose the number of pending
geolocation requests, so that we can test that the requests have
been cancelled on page close.

  • DumpRenderTree/LayoutTestController.cpp: (numberOfPendingGeolocationPermissionRequestsCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/mac/UIDelegate.h:
  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
5:11 AM Changeset in webkit [81017] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-03-14 Andrey Adaikin <​aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION: Messed up with the tabIndex for text editor
​https://bugs.webkit.org/show_bug.cgi?id=56183

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._handleKeyDown): (WebInspector.SourceFrame.prototype._handleSave): (WebInspector.SourceFrame.prototype._handleRevertEditing):
  • inspector/front-end/TextViewer.js: (WebInspector.TextEditorMainPanel): (WebInspector.TextEditorMainPanel.prototype.set readOnly):
4:57 AM Changeset in webkit [81016] by alex
  • 2 edits
    3 adds in trunk/LayoutTests

2011-03-14 Alejandro G. Castro <​alex@igalia.com>

Rebaseline GTK+ tests after r80996.

  • platform/gtk/fast/text/soft-hyphen-2-expected.txt:
  • platform/gtk/fast/text/soft-hyphen-4-expected.checksum: Added.
  • platform/gtk/fast/text/soft-hyphen-4-expected.png: Added.
  • platform/gtk/fast/text/soft-hyphen-4-expected.txt: Added.
4:40 AM Changeset in webkit [81015] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

2011-03-14 Chris Rogers <​crogers@google.com>

Reviewed by Xan Lopez.

Add all web audio auto-generated files to GTK make system
​https://bugs.webkit.org/show_bug.cgi?id=50497

No new tests since these are build-system tweaks.

  • GNUmakefile.am:
4:21 AM Changeset in webkit [81014] by jknotten@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-14 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

Fix flaky layout test: fast/dom/Geolocation/window-close-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=56202

By testing for geolocation watch errors, the test tests more than
it should, which can cause a flaky result as demonstrated by
​https://bugs.webkit.org/show_bug.cgi?id=56126 .

  • fast/dom/Geolocation/resources/window-close-popup.html:
  • fast/dom/Geolocation/script-tests/window-close-crash.js:
4:19 AM Changeset in webkit [81013] by alex
  • 2 edits in trunk/LayoutTests

2011-03-14 Alejandro G. Castro <​alex@igalia.com>

Update more expectations after r80857.

  • platform/gtk/fast/layers/video-layer-expected.txt:
3:55 AM Changeset in webkit [81012] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Move the crash result and the bug to the debug line for the test (instead of release)
since that is where the crash occurs.

  • platform/chromium/test_expectations.txt:
3:29 AM Changeset in webkit [81011] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-03-14 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: remove the flaky part of the new inspector test for now.

  • inspector/elements/edit-dom-actions-expected.txt:
  • inspector/elements/edit-dom-actions.html:
2:45 AM Changeset in webkit [81010] by pfeldman@chromium.org
  • 9 edits in trunk

2011-03-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make DOMAgent event target, remove dependency from ElementsPanel.
​https://bugs.webkit.org/show_bug.cgi?id=56268

  • inspector/elements/elements-panel-search.html:
  • inspector/elements/mutate-unknown-node.html:

2011-03-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make DOMAgent event target, remove dependency from ElementsPanel.
​https://bugs.webkit.org/show_bug.cgi?id=56268

  • inspector/Inspector.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::reset): (WebCore::InspectorDOMAgent::performSearch): (WebCore::InspectorDOMAgent::cancelSearch): (WebCore::InspectorDOMAgent::onMatchJobsTimer): (WebCore::InspectorDOMAgent::reportNodesAsSearchResults):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.requestDocument.mycallback): (WebInspector.DOMAgent.prototype.requestDocument): (WebInspector.DOMAgent.prototype._attributesUpdated): (WebInspector.DOMAgent.prototype._characterDataModified): (WebInspector.DOMAgent.prototype._documentUpdated): (WebInspector.DOMAgent.prototype._setDocument): (WebInspector.DOMAgent.prototype._childNodeCountUpdated): (WebInspector.DOMAgent.prototype._childNodeInserted): (WebInspector.DOMAgent.prototype._childNodeRemoved): (WebInspector.DOMAgent.prototype._removeBreakpoints): (WebInspector.DOMAgent.prototype.performSearch): (WebInspector.DOMAgent.prototype.cancelSearch): (WebInspector.DOMDispatcher.prototype.searchResults):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype._reset): (WebInspector.ElementsPanel.prototype._documentUpdated): (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch): (WebInspector.ElementsPanel.prototype._addNodesToSearchResult): (WebInspector.ElementsPanel.prototype._attributesUpdated): (WebInspector.ElementsPanel.prototype._characterDataModified): (WebInspector.ElementsPanel.prototype._nodeInserted): (WebInspector.ElementsPanel.prototype._nodeRemoved): (WebInspector.ElementsPanel.prototype._childNodeCountUpdated): (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
2:42 AM Changeset in webkit [81009] by pfeldman@chromium.org
  • 7 edits
    2 adds in trunk

2011-03-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add tests for edit dom operations.
​https://bugs.webkit.org/show_bug.cgi?id=56248

  • inspector/elements/edit-dom-actions-expected.txt: Added.
  • inspector/elements/edit-dom-actions.html: Added.

2011-03-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add tests for edit dom operations.
​https://bugs.webkit.org/show_bug.cgi?id=56248

Test: inspector/elements/edit-dom-actions.html

  • inspector/Inspector.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::assertNode): (WebCore::InspectorDOMAgent::assertElement): (WebCore::InspectorDOMAgent::assertHTMLElement): (WebCore::InspectorDOMAgent::nodeToSelectOn): (WebCore::InspectorDOMAgent::querySelector): (WebCore::InspectorDOMAgent::querySelectorAll): (WebCore::InspectorDOMAgent::setAttribute): (WebCore::InspectorDOMAgent::removeAttribute): (WebCore::InspectorDOMAgent::getOuterHTML): (WebCore::InspectorDOMAgent::setOuterHTML):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype.setAttribute): (WebInspector.DOMNode.prototype.removeAttribute):
  • inspector/front-end/inspector.js: (WebInspector.startEditing.defaultFinishHandler):
2:07 AM Changeset in webkit [81008] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

2011-03-14 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Unreviewed. Modify my email address in committers.py.

  • Scripts/webkitpy/common/config/committers.py:
1:44 AM Changeset in webkit [81007] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Fix typo TEXT vs TEST.

  • platform/chromium/test_expectations.txt:
1:28 AM Changeset in webkit [81006] by levin@chromium.org
  • 3 edits
    2 adds in trunk/LayoutTests

Rebaseline some test due to r80996.
Rearrange some expectations (from IMAGE to IMAGE_TEXT) due to r80996
and add a few bugs which track the other failures.

  • platform/chromium-linux/fast/text/capitalize-boundaries-expected.txt:
  • platform/chromium-linux/fast/text/soft-hyphen-4-expected.checksum: Added.
  • platform/chromium-linux/fast/text/soft-hyphen-4-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:44 AM Changeset in webkit [81005] by beidson@apple.com
  • 4 edits in trunk/Source

<rdar://problem/8762095> and ​https://bugs.webkit.org/show_bug.cgi?id=55172
Need WK2 API to view/manage origins with LocalStorage

Reviewed by Dan Bernstein.

../WebCore:

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::initializeTracker): Make sure the TextEncoding map is initialized on the main thread

before the StorageTracker thread can do it on the background thread.

../WebKit2:

Hookup the existing API stubs to the WebCore implementations:

  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp:

(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManager::deleteAllEntries):

12:11 AM Changeset in webkit [81004] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/efl

2011-03-14 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Move cache_directory api
​https://bugs.webkit.org/show_bug.cgi?id=52139

Move cache directory related apis from ewk_view to ewk_settings because
those are not related to ewk_view.

  • ewk/ewk_main.cpp: (_ewk_init_body):
  • ewk/ewk_settings.cpp: (ewk_settings_cache_directory_path_set): (ewk_settings_cache_directory_path_get):
  • ewk/ewk_settings.h:
  • ewk/ewk_view.cpp: (_ewk_view_priv_new): (_ewk_view_priv_del):
  • ewk/ewk_view.h:

Mar 13, 2011:

1:30 AM Changeset in webkit [80958] by levin@chromium.org
  • 12 edits
    40 adds in trunk/LayoutTests

Update test results due to r80755. All of these tests started failing
on that check in and were given new baselines in that check in.

  • platform/chromium-mac/css1/text_properties/text_indent-expected.checksum: Added.
  • platform/chromium-mac/css1/text_properties/text_indent-expected.png: Added.
  • platform/chromium-mac/css1/units/length_units-expected.checksum: Added.
  • platform/chromium-mac/css1/units/length_units-expected.png: Added.
  • platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Added.
  • platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Added.
  • platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-ltr-2-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-ltr-2-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-ltr-expected.png:
  • platform/chromium-mac/editing/selection/caret-ltr-right-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-ltr-right-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-right-expected.png: Added.
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.checksum:
  • platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-mac/fast/css/ex-after-font-variant-expected.checksum: Added.
  • platform/chromium-mac/fast/css/ex-after-font-variant-expected.png: Added.
  • platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.checksum: Added.
  • platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.png: Added.
  • platform/chromium-mac/fast/forms/minWidthPercent-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/minWidthPercent-expected.png: Added.
  • platform/chromium-mac/fast/overflow/overflow-rtl-expected.checksum: Added.
  • platform/chromium-mac/fast/overflow/overflow-rtl-expected.png: Added.

Mar 12, 2011:

11:24 PM Changeset in webkit [81003] by beidson@apple.com
  • 3 edits in trunk/Source/WebCore

Fixed lock-taking order to prevent deadlock, added lock for m_client,
removed premature return in syncImportOriginIdentifiers when tracker
db does not exist because that prevented syncFileSystemAndTrackerDatabase()
from running until next LocalStorage db creation, cleaned up
StorageTracker::scheduleTask() code for readability.

Patch by Anton D'Auria <​adauria@apple.com> on 2011-03-13
Reviewed by Brady Eidson and David Levin, landed by Brady Eidson.

​https://bugs.webkit.org/show_bug.cgi?id=56285

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::trackerDatabasePath):
(WebCore::StorageTracker::syncImportOriginIdentifiers): If tracker db isn't
optionally opened (as in the case when it doesn't exist on disk), don't
exit early and call syncFileSystemAndTrackerDatabase(), which will create
a tracker db if localstorage db files are found on disk by calling setOriginDetails.
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::scheduleTask): readability changes.
(WebCore::StorageTracker::syncSetOriginDetails):
(WebCore::StorageTracker::syncDeleteAllOrigins):
(WebCore::StorageTracker::syncDeleteOrigin):
(WebCore::StorageTracker::cancelDeletingOrigin): order lock-taking consistently to avoid deadlock.
(WebCore::StorageTracker::setClient):

  • storage/StorageTracker.h:
11:20 PM Changeset in webkit [81002] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Reviewed and landed by Brady Eidson.

Patch by Anton D'Auria <​adauria@apple.com> on 2011-03-13
Invalid assertion in StorageTracker - PageGroup::numberOfPageGroups() == 1
​https://bugs.webkit.org/show_bug.cgi?id=56240

This assertion is invalid until LocalStorage is either global or is isolated by PageGroup.

  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::origins):
(WebCore::StorageTracker::deleteAllOrigins):
(WebCore::StorageTracker::deleteOrigin):

11:02 PM Changeset in webkit [81001] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Make adjustMIMETypeIfNecessary use CFNetwork directly
​https://bugs.webkit.org/show_bug.cgi?id=55912

Reviewed by Dan Bernstein.

Follow up fix for Layout Test failure. Fix typo - it should be text/plain, not test/plain.

  • platform/network/mac/WebCoreURLResponse.mm:

(WebCore::adjustMIMETypeIfNecessary):

10:47 PM Changeset in webkit [81000] by beidson@apple.com
  • 16 edits in trunk/Source/WebKit2

<rdar://problem/9127270> and ​https://bugs.webkit.org/show_bug.cgi?id=56282

Reviewed by Sam Weinig.

Pass the path along with creation parameters:

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Add SPI to set the path:

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetLocalStorageDirectory):

  • UIProcess/API/C/WKContextPrivate.h:

Pass the path along in the process creation parameters:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::localStorageDirectory):

  • UIProcess/WebContext.h:

(WebKit::WebContext::setLocalStorageDirectory):

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultLocalStorageDirectory):

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformDefaultLocalStorageDirectory):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformDefaultLocalStorageDirectory):

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformDefaultLocalStorageDirectory):

Include the path with settings updates, because WebCore needs it set on the Settings object:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::localStorageDirectory):

Sandboxing stuff:

  • WebProcess/com.apple.WebProcess.sb:
  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox):

10:35 PM Changeset in webkit [80999] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-03-12 Jer Noble <​jer.noble@apple.com>

Reviewed by Mark Rowe.

WebKit2: Build WKFullScreenWindowController cleanly in 32-bit.
​https://bugs.webkit.org/show_bug.cgi?id=56260

Include <Carbon/Carbon.h> instead of <HIToolbox/MacApplication.h>.

  • UIProcess/mac/WKFullScreenWindowController.mm:
10:23 PM Changeset in webkit [80998] by levin@chromium.org
  • 2 edits in trunk/Source/WebCore

Improve my hasitly added build fix and added a bug ​https://bugs.webkit.org/show_bug.cgi?id=56288
above addressing this FIXME.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

10:23 PM Changeset in webkit [80997] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Clean up overlapping test_expectation which I mistakenly added in my haste.

  • platform/chromium/test_expectations.txt:
10:10 PM Changeset in webkit [80996] by mitz@apple.com
  • 13 edits in trunk

Include hyphenation information in text representation of render tree
​https://bugs.webkit.org/show_bug.cgi?id=56287

Reviewed by Sam Weinig.

Source/WebCore:

(WebCore::writeTextRun): If the text box is hyphenated, output the hyphenation
string.

LayoutTests:

  • fast/text/soft-hyphen-4-expected.txt:
  • platform/mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt:
  • platform/mac-snowleopard/fast/text/hyphenate-locale-expected.txt:
  • platform/mac/fast/text/basic/014-expected.txt:
  • platform/mac/fast/text/capitalize-boundaries-expected.txt:
  • platform/mac/fast/text/hyphenate-character-expected.txt:
  • platform/mac/fast/text/hyphenate-first-word-expected.txt:
  • platform/mac/fast/text/hyphens-expected.txt:
  • platform/mac/fast/text/midword-break-after-breakable-char-expected.txt:
  • platform/mac/fast/text/soft-hyphen-2-expected.txt:
9:56 PM Changeset in webkit [80995] by ggaren@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

A few Heap-related renames (sans file moves, which should come next)
​https://bugs.webkit.org/show_bug.cgi?id=56283

Reviewed by Sam Weinig.

ConservativeSet => ConservativeRoots. "Set" was misleading, since items
are not uniqued. Also, "Roots" is more specific about what's in the set.

MachineStackMarker => MachineThreads. "Threads" is more descriptive of
the fact that this class maintains a set of all threads using JSC.
"Stack" was misleading, since this class traverses stacks and registers.
"Mark" was misleading, since this class doesn't mark anything anymore.

registerThread => addCurrentThread. "Current" is more specific.
unregisterThread => removeCurrentThread. "Current" is more specific.

"currentThreadRegistrar" => threadSpecific. The only point of this data
structure is to register a thread-specific destructor with a pointer to
this.

"mark...Conservatively" => "gather". "Mark" is not true, since these
functions don't mark anything. "Conservatively" is redundant, since they
take "ConservativeRoots" as an argument.

  • API/APIShims.h:

(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):

(JSC::ConservativeRoots::grow):
(JSC::ConservativeRoots::add):

  • runtime/ConservativeSet.h:

(JSC::ConservativeRoots::ConservativeRoots):
(JSC::ConservativeRoots::~ConservativeRoots):
(JSC::ConservativeRoots::size):
(JSC::ConservativeRoots::roots):

  • runtime/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::markRoots):

  • runtime/Heap.h:

(JSC::Heap::machineThreads):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::makeUsableFromMultipleThreads):

  • runtime/MachineStackMarker.cpp:

(JSC::MachineThreads::MachineThreads):
(JSC::MachineThreads::~MachineThreads):
(JSC::MachineThreads::makeUsableFromMultipleThreads):
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::removeThread):
(JSC::MachineThreads::removeCurrentThread):
(JSC::MachineThreads::gatherFromCurrentThreadInternal):
(JSC::MachineThreads::gatherFromCurrentThread):
(JSC::MachineThreads::gatherFromOtherThread):
(JSC::MachineThreads::gatherConservativeRoots):

  • runtime/MachineStackMarker.h:
  • runtime/MarkStack.h:

(JSC::MarkStack::append):

9:53 PM Changeset in webkit [80994] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

BUILD FIX for armv7 after r80969

Bug 56270 - The JIT 'friend's many classes in JSC; start unwinding this.
<​https://bugs.webkit.org/show_bug.cgi?id=56270>

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::load32): Made void* address argument
const.
(JSC::MacroAssemblerARMv7::store32): Ditto.

9:37 PM Changeset in webkit [80993] by levin@chromium.org
  • 4 edits in trunk

Build fix adding remaining enum values to switch statement.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

Add more crashing tests to an existing bug about the same issue
for Chromium Linux Debug. :(

  • platform/chromium/test_expectations.txt:
9:02 PM Changeset in webkit [80992] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add some test failures that I need to investigate further.
Clean up a duplicate test expectation (default-timing-function.html ).
Add a missing test expection for linux debug which was there for linux release (border-image-vertical-lr.html).

  • platform/chromium/test_expectations.txt:
9:02 PM Changeset in webkit [80991] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add more crashing tests to an existing bug about the same issue
for Chromium Linux Debug.

  • platform/chromium/test_expectations.txt:
8:02 PM Changeset in webkit [80990] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

8:01 PM Changeset in webkit [80989] by mrowe@apple.com
  • 1 copy in tags/Safari-534.24

New tag.

7:36 PM Changeset in webkit [80988] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Updated expected results after r80982.

  • platform/mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt:
6:35 PM Changeset in webkit [80987] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Not reviewed.

Try to fix the Mac build.

ConervativeSet.h, since it's now visible when compiling other projects.

6:27 PM Changeset in webkit [80986] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix windows build.

  • platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::ResourceError):
Add missing constructor.

6:16 PM Changeset in webkit [80985] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-03-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed another case of DeprecatedPtr (ConservativeSet)
​https://bugs.webkit.org/show_bug.cgi?id=56281


The ConservativeSet is an internal data structure used during marking,
so direct pointers are fine.

  • runtime/ConservativeSet.cpp: (JSC::ConservativeSet::grow):
  • runtime/ConservativeSet.h: Added some accessors, for use by MarkStack::append. (JSC::ConservativeSet::~ConservativeSet): Fixed a typo where we calculated the size of the set based on sizeof(DeprecatedPtr<T>*) instead of sizeof(DeprecatedPtr<T>). I'm not sure if this had real-world implications or not. (JSC::ConservativeSet::size): (JSC::ConservativeSet::set): Use direct pointers, as stated above.
  • runtime/Heap.cpp: (JSC::Heap::markRoots):
  • runtime/MarkStack.h: (JSC::MarkStack::append): Created a special case of append for ConservativeSet. I didn't want to add back a generic "append JSCell*" function, since other class might start using that wrong. (In the end, this function might go away, since the Heap will want to do something slightly more interesting with the conservative set, but this is OK for now.)
6:09 PM Changeset in webkit [80984] by mitz@apple.com
  • 3 edits
    4 adds in trunk

Source/WebCore: REGRESSION: Soft hyphen is not always rendered
​https://bugs.webkit.org/show_bug.cgi?id=56017

Patch by David Sosby <​dsosby@rim.com> on 2011-03-13
Reviewed by Dan Bernstein.

The check to flag a text block as hyphenated was only
occurring at break points in the line. If no break points
were found after the soft hyphen then the line would not
be flagged hyphenated. Adding a check for soft hyphen at
the end of the text run resolves the issue.

Test: fast/text/soft-hyphen-4.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::findNextLineBreak):

LayoutTests: Reviewed and tweaked by Dan Bernstein.

Patch by David Sosby <​dsosby@rim.com> on 2011-03-13
REGRESSION: Soft hyphen is not always rendered
​https://bugs.webkit.org/show_bug.cgi?id=56017

Adding new test that verifies soft hyphen is rendered
when it is the last breakable point in a line.

  • fast/text/soft-hyphen-4-expected.checksum: Added.
  • fast/text/soft-hyphen-4-expected.png: Added.
  • fast/text/soft-hyphen-4-expected.txt: Added.
  • fast/text/soft-hyphen-4.html: Added.
5:58 PM Changeset in webkit [80983] by levin@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

Update some baselines due to r80868.
Also, add MAC to a failure line where I should have put it previously.

  • platform/chromium-mac/fast/backgrounds/animated-svg-as-background-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/animated-svg-as-background-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.png: Added.
  • platform/chromium/test_expectations.txt:
5:54 PM Changeset in webkit [80982] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r80438): fast/text/hyphenate-character failing in pixel mode
​https://bugs.webkit.org/show_bug.cgi?id=56280

Reviewed by Mark Rowe.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::tryHyphenating): Avoid subtracting 1 from an unsigned 0.

5:34 PM Changeset in webkit [80981] by weinig@apple.com
  • 9 edits
    2 adds in trunk/Source

Add ability to create a WKErrorRef
<rdar://problem/9115768>
​https://bugs.webkit.org/show_bug.cgi?id=56279

Reviewed by Anders Carlsson.

Source/WebCore:

  • WebCore.exp.in:

Add new exports.

  • platform/network/cf/ResourceError.h:
  • platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::platformCompare):
(WebCore::ResourceError::cfError):
(WebCore::ResourceError::operator CFErrorRef):
(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::cfStreamError):
(WebCore::ResourceError::operator CFStreamError):

  • platform/network/mac/ResourceErrorMac.mm:

(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::platformCompare):
(WebCore::ResourceError::nsError):
(WebCore::ResourceError::operator NSError *):
(WebCore::ResourceError::cfError):
(WebCore::ResourceError::operator CFErrorRef):
Clean up ResourceError a bit and add ability to create a ResourceError from a CFErrorRef
regardless of whether CFNetwork is being used.

Source/WebKit2:

  • Shared/API/c/cf/WKErrorCF.cpp: Added.

(WKErrorCreateWithCFError):
(WKErrorCopyCFError):

  • Shared/API/c/cf/WKErrorCF.h: Added.

Add new API to create a WKErrorRef from a CFErrorRef
and vice-versa.

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Add new files.

5:34 PM Changeset in webkit [80980] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed another case of DeprecatedPtr (PutPropertySlot)
​https://bugs.webkit.org/show_bug.cgi?id=56278

  • runtime/PutPropertySlot.h: (JSC::PutPropertySlot::setExistingProperty): (JSC::PutPropertySlot::setNewProperty): (JSC::PutPropertySlot::base): Direct pointer is fine for PutPropertySlot, since it's a stack-allocated temporary.
5:31 PM Changeset in webkit [80979] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add one more failure which is related to change in this range:

​http://trac.webkit.org/log/?verbose=on&rev=80866&stop_rev=80860

that I haven't been able to narrow down yet.

  • platform/chromium/test_expectations.txt:
5:31 PM Changeset in webkit [80978] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add more crashing tests to an existing bug about the same issue
for Chromium Linux Debug.

  • platform/chromium/test_expectations.txt:
5:15 PM Changeset in webkit [80977] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-03-13 Joe Wild <​joseph.wild@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtLauncher does not load the same set of fonts as the DRT
​https://bugs.webkit.org/show_bug.cgi?id=34959

This patch adds the option "-use-test-fonts" to the QtTestBrowser.
When this option is used the webkit fonts are loaded the same
as they are in DumpRenderTree. This option can be used on
QtTestBrowser and run-launcher. It can only be used
on Linux systems with FcInit and is configured as such.

  • QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
  • QtTestBrowser/main.cpp: (initWebKitTestFonts): (launcherMain): (LauncherApplication::handleUserOptions):
5:14 PM Changeset in webkit [80976] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-03-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Removed one case of DeprecatedPtr (ScopeChainIterator)
​https://bugs.webkit.org/show_bug.cgi?id=56277

  • runtime/ScopeChain.h: Direct pointer is fine for ScopeChainIterator, since it's a stack-allocated temporary.
5:10 PM Changeset in webkit [80975] by psolanki@apple.com
  • 15 edits in trunk

Make adjustMIMETypeIfNecessary use CFNetwork directly
​https://bugs.webkit.org/show_bug.cgi?id=55912

Reviewed by Brady Eidson.

Source/WebCore:

Convert category method [NSURLResponse adjustMIMETypeIfNecessary] to C function
WebCore::adjustMIMETypeIfNecessary() that takes a CFURLResponseRef and is functionally
identical.

Testing is covered by existing LayoutTests.

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/network/mac/ResourceHandleMac.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):

  • platform/network/mac/WebCoreURLResponse.h:
  • platform/network/mac/WebCoreURLResponse.mm:

(WebCore::createBinaryExtensionsSet):
(WebCore::createExtensionToMIMETypeMap):
(WebCore::mimeTypeFromUTITree):
(WebCore::adjustMIMETypeIfNecessary):

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Support for new WKSI functions.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Support for new WKSI functions.

WebKitLibraries:

Add new WKSI functions needed to implement adjustMIMETypeIfNecessary.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
3:41 PM Changeset in webkit [80974] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Fix the expectation to refer to transitions/default-timing-function.html
instead of bug1318. My change log description also made the same mistake.

  • platform/chromium/test_expectations.txt:
3:37 PM Changeset in webkit [80973] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Sort some test expectations into a better place. Move a linux debug
crash to be near the other instances of it.

Remove fast/text/font-size-zero.html as it appears to be passing consistently.

Add the expectation for bug1318.html due to r80806 changing its output in a way
that looks less optimal than it did before.

  • platform/chromium/test_expectations.txt:
3:11 PM Changeset in webkit [80972] by barraclough@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Bug 56273 - Add three operand forms to MacroAssember operations.

Reviewed by Sam Weinig.

Adding for X86(_64) for now, should be rolled out to other backends as necessary.
These may allow more efficient code generation in some cases, avoiding the need
for unnecessary register-register move instructions.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):

  • marked these methods const.

(JSC::AbstractMacroAssembler::Jump::isSet):

  • add a method to check whether a Jump object has been set to reference an instruction, or is in a null, unset state.
  • assembler/MacroAssemblerCodeRef.h:

(JSC::FunctionPtr::FunctionPtr):

  • add non-explicit constructor, for FunctionPtr's to C/C++ functions.
  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::and32):
(JSC::MacroAssemblerX86Common::lshift32):
(JSC::MacroAssemblerX86Common::or32):
(JSC::MacroAssemblerX86Common::rshift32):
(JSC::MacroAssemblerX86Common::urshift32):
(JSC::MacroAssemblerX86Common::xor32):
(JSC::MacroAssemblerX86Common::moveDouble):
(JSC::MacroAssemblerX86Common::addDouble):
(JSC::MacroAssemblerX86Common::divDouble):
(JSC::MacroAssemblerX86Common::subDouble):
(JSC::MacroAssemblerX86Common::mulDouble):
(JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerX86Common::branchTest32):
(JSC::MacroAssemblerX86Common::branchTest8):
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::branchMul32):
(JSC::MacroAssemblerX86Common::branchSub32):

  • add three operand forms of these instructions.
  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::addDouble):
(JSC::MacroAssemblerX86_64::convertInt32ToDouble):
(JSC::MacroAssemblerX86_64::loadPtr):
(JSC::MacroAssemblerX86_64::branchTestPtr):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::JmpSrc::isSet):

  • add a method to check whether a JmpSrc object has been set to reference an instruction, or is in a null, unset state.

(JSC::X86Assembler::movsd_rr):

  • added FP register-register move.

(JSC::X86Assembler::linkJump):

  • Add an assert to check jumps aren't linked more than once.
  • jit/JITInlineMethods.h:

(JSC::JIT::emitLoadInt32ToDouble):

  • load integers to the FPU via regsiters on x86-64.
3:05 PM Changeset in webkit [80971] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add some more crashing tests to an existing bug about the same issue
for Chromium Linux Debug.

  • platform/chromium/test_expectations.txt:
2:26 PM Changeset in webkit [80970] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ARM build fix.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::load32):

2:16 PM Changeset in webkit [80969] by barraclough@apple.com
  • 21 edits in trunk/Source/JavaScriptCore

Bug 56270 - The JIT 'friend's many classes in JSC; start unwinding this.

Reviewed by Sam Weinig.

The JIT need to 'friend' other classes in order to be able to calculate offsets
of various properties, or the absolute addresses of members within specific objects,
in order to JIT generate code that will access members within the class when run.

Instead of using friends in these cases, switch to providing specific accessor
methods to provide this information. In the case of offsets, these can be static
functions, and in the case of pointers to members within a specific object these can
be const methods returning pointers to const values, to prevent clients from
modifying values otherwise encapsulated within classes.

  • bytecode/SamplingTool.h:
  • interpreter/Register.h:
  • interpreter/RegisterFile.h:
  • runtime/JSArray.h:
  • runtime/JSCell.h:
  • runtime/JSTypeInfo.h:
  • runtime/JSVariableObject.h:
  • runtime/Structure.h:
  • wtf/RefCounted.h:
    • Change these classes to no longer friend the JIT, add accessors for member offsets.
  • jit/JIT.cpp:
  • jit/JITCall32_64.cpp:
  • jit/JITInlineMethods.h:
  • jit/JITOpcodes.cpp:
  • jit/JITOpcodes32_64.cpp:
  • jit/JITPropertyAccess.cpp:
  • jit/JITPropertyAccess32_64.cpp:
    • Change the JIT to use class accessors, rather than taking object ofsets directly.
  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssemblerX86_64.h:
  • assembler/X86Assembler.h:
    • Since the accessors for objects members return const pointers to retain encapsulation, methods generating code with absolute addresses must be able to handle const pointers (the JIT doesn't write to these values, do dies treat the pointer to value as const from within the C++ code of the JIT, if not at runtime!).
1:30 PM Changeset in webkit [80968] by mitz@apple.com
  • 4 edits in trunk/Source/WebKit2

WebPageProxy cleanup
​https://bugs.webkit.org/show_bug.cgi?id=56267

Reviewed by Darin Adler.

  • UIProcess/WebPageProxy.cpp: Moved all Mac-only function implementations from

here to WebPageProxyMac.mm.

  • UIProcess/WebPageProxy.h: Cleaned up #includes.
  • UIProcess/mac/WebPageProxyMac.mm: Moved all Mac-only function implementations

here.
(WebKit::WebPageProxy::updateWindowIsVisible):
(WebKit::WebPageProxy::windowAndViewFramesChanged):
(WebKit::WebPageProxy::getMarkedRange):
(WebKit::WebPageProxy::characterIndexForPoint):
(WebKit::WebPageProxy::firstRectForCharacterRange):
(WebKit::WebPageProxy::writeSelectionToPasteboard):
(WebKit::WebPageProxy::setDragImage):
(WebKit::WebPageProxy::performDictionaryLookupAtLocation):
(WebKit::WebPageProxy::interpretKeyEvent):
(WebKit::WebPageProxy::sendComplexTextInputToPlugin):
(WebKit::WebPageProxy::uppercaseWord):
(WebKit::WebPageProxy::lowercaseWord):
(WebKit::WebPageProxy::capitalizeWord):
(WebKit::WebPageProxy::setSmartInsertDeleteEnabled):
(WebKit::WebPageProxy::didPerformDictionaryLookup):
(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
(WebKit::WebPageProxy::registerUIProcessAccessibilityTokens):
(WebKit::WebPageProxy::setComplexTextInputEnabled):

1:28 PM Changeset in webkit [80967] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/8949683> WebKit2: Drag image is offset when the page is scrolled down
​https://bugs.webkit.org/show_bug.cgi?id=56265

Reviewed by Darin Adler.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::startDrag): Send the location in view coordinates rather than
document coordinates.

1:24 PM Changeset in webkit [80966] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix a crash when dragging.

Reviewed by Mark Rowe.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::convertImageToBitmap): Retain the saved context.

12:46 PM Changeset in webkit [80965] by jeremy@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-03-13 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Dimitri Glazkov.

Update comment in CSSValueKeywords.in
​https://bugs.webkit.org/show_bug.cgi?id=56266

The enums the comment refers to were moved from RenderStyle.h to RenderStyleConstants.h
in r36579 but it appears that the comment in CSSValueKeywords.in wasn't updated.

No tests - just updating a comment.

  • css/CSSValueKeywords.in:
12:07 PM Changeset in webkit [80964] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-03-13 Anton D'Auria <​adauria@apple.com>

Reviewed by Alice Liu.

StorageTracker constructor shouldn't have initialization code and isMainThread() assertion
​https://bugs.webkit.org/show_bug.cgi?id=56259

Move all StorageTracker initialization to
StorageTracker::initializeTracker. This also removes the
requirement that the StorageTracker constructor isn't run
on the main thread.

  • storage/StorageTracker.cpp: (WebCore::StorageTracker::initializeTracker): (WebCore::StorageTracker::tracker): (WebCore::StorageTracker::StorageTracker):
11:47 AM Changeset in webkit [80963] by rwlbuis@webkit.org
  • 3 edits
    2 adds in trunk

2011-03-13 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Dave Hyatt.

REGRESSION (r61383): Navigation menu laid out incorrectly on aboardtheworld.com
​https://bugs.webkit.org/show_bug.cgi?id=53470

Prefer !important over normal properties when dealing with duplicate properties in style rules.

Test: fast/css/duplicate-property-in-rule-important.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
11:42 AM Changeset in webkit [80962] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Add expectation (and bug) for test that has failed with an image
mismatch ever since it was added in r80867.

  • platform/chromium/test_expectations.txt:
11:09 AM Changeset in webkit [80961] by levin@chromium.org
  • 5 edits
    11 adds in trunk/LayoutTests

Update test expections due to the OSX specific ex size change done in r80755.

  • platform/chromium-mac/fast/lists/008-expected.checksum: Added.
  • platform/chromium-mac/fast/lists/008-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png: Added.
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.checksum: Added.
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png: Added.
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.checksum: Added.
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.png: Added.
  • platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum: Added.
  • platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
10:04 AM Changeset in webkit [80960] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Fix test expectations due to bad update:

r80820 which limited to win/mac when it still regularly fails on Linux
and it made the test fail with the expectation IMAGE instead of IMAGE+TEXT
as well as occaisionally pass.

  • platform/chromium/test_expectations.txt:
3:07 AM Changeset in webkit [80959] by levin@chromium.org
  • 2 edits
    21 adds in trunk/LayoutTests

Added the following expectations:

fast/backgrounds/background-position-parsing.html new test in r80868
fast/css-generated-content/table-row-before-after.html new test in r80871
fast/table/dynamic-descendant-percentage-height.html new test in r80878

Updated test_expectation to cover a failure due to a missing layout test feature
and added an appropriate bug.

  • platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.checksum: Added.
  • platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.png: Added.
  • platform/chromium-linux/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
  • platform/chromium-linux/fast/css-generated-content/table-row-before-after-expected.png: Added.
  • platform/chromium-linux/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
  • platform/chromium-linux/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.png: Added.
  • platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
  • platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.png: Added.
  • platform/chromium-mac/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
  • platform/chromium-mac/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/background-position-parsing-expected.checksum: Added.
  • platform/chromium-win/fast/backgrounds/background-position-parsing-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/background-position-parsing-expected.txt: Added.
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.txt: Added.
  • platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
  • platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
  • platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.